Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1 | // |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 2 | // Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved. |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
| 7 | // validationES2.cpp: Validation functions for OpenGL ES 2.0 entry point parameters |
| 8 | |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 9 | #include "libANGLE/validationES2.h" |
| 10 | #include "libANGLE/validationES.h" |
| 11 | #include "libANGLE/Context.h" |
| 12 | #include "libANGLE/Texture.h" |
| 13 | #include "libANGLE/Framebuffer.h" |
| 14 | #include "libANGLE/Renderbuffer.h" |
| 15 | #include "libANGLE/formatutils.h" |
| 16 | #include "libANGLE/FramebufferAttachment.h" |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 17 | |
| 18 | #include "common/mathutil.h" |
| 19 | #include "common/utilities.h" |
| 20 | |
| 21 | namespace gl |
| 22 | { |
| 23 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 24 | bool ValidateES2TexImageParameters(Context *context, GLenum target, GLint level, GLenum internalformat, bool isCompressed, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 25 | GLint xoffset, GLint yoffset, GLsizei width, GLsizei height, |
| 26 | GLint border, GLenum format, GLenum type, const GLvoid *pixels) |
| 27 | { |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 28 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 29 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 30 | context->recordError(Error(GL_INVALID_ENUM)); |
| 31 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 32 | } |
| 33 | |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 34 | if (!ValidImageSize(context, target, level, width, height, 1)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 35 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 36 | context->recordError(Error(GL_INVALID_VALUE)); |
| 37 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 38 | } |
| 39 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 40 | if (level < 0 || xoffset < 0 || |
| 41 | std::numeric_limits<GLsizei>::max() - xoffset < width || |
| 42 | std::numeric_limits<GLsizei>::max() - yoffset < height) |
| 43 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 44 | context->recordError(Error(GL_INVALID_VALUE)); |
| 45 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 46 | } |
| 47 | |
Geoff Lang | 005df41 | 2013-10-16 14:12:50 -0400 | [diff] [blame] | 48 | if (!isSubImage && !isCompressed && internalformat != format) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 49 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 50 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 51 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 52 | } |
| 53 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 54 | const gl::Caps &caps = context->getCaps(); |
| 55 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 56 | if (target == GL_TEXTURE_2D) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 57 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 58 | if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) || |
| 59 | static_cast<GLuint>(height) > (caps.max2DTextureSize >> level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 60 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 61 | context->recordError(Error(GL_INVALID_VALUE)); |
| 62 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 63 | } |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 64 | } |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 65 | else if (IsCubeMapTextureTarget(target)) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 66 | { |
| 67 | if (!isSubImage && width != height) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 68 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 69 | context->recordError(Error(GL_INVALID_VALUE)); |
| 70 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 71 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 72 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 73 | if (static_cast<GLuint>(width) > (caps.maxCubeMapTextureSize >> level) || |
| 74 | static_cast<GLuint>(height) > (caps.maxCubeMapTextureSize >> level)) |
| 75 | { |
| 76 | context->recordError(Error(GL_INVALID_VALUE)); |
| 77 | return false; |
| 78 | } |
| 79 | } |
| 80 | else |
| 81 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 82 | context->recordError(Error(GL_INVALID_ENUM)); |
| 83 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 84 | } |
| 85 | |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 86 | gl::Texture *texture = context->getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 87 | if (!texture) |
| 88 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 89 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 90 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 91 | } |
| 92 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 93 | if (isSubImage) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 94 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 95 | if (format != GL_NONE) |
| 96 | { |
Geoff Lang | 051dbc7 | 2015-01-05 15:48:58 -0500 | [diff] [blame] | 97 | if (gl::GetSizedInternalFormat(format, type) != texture->getInternalFormat(target, level)) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 98 | { |
| 99 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 100 | return false; |
| 101 | } |
| 102 | } |
| 103 | |
| 104 | if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) || |
| 105 | static_cast<size_t>(yoffset + height) > texture->getHeight(target, level)) |
| 106 | { |
| 107 | context->recordError(Error(GL_INVALID_VALUE)); |
| 108 | return false; |
| 109 | } |
| 110 | } |
| 111 | else |
| 112 | { |
Geoff Lang | 69cce58 | 2015-09-17 13:20:36 -0400 | [diff] [blame] | 113 | if (texture->getImmutableFormat()) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 114 | { |
| 115 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 116 | return false; |
| 117 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 118 | } |
| 119 | |
| 120 | // Verify zero border |
| 121 | if (border != 0) |
| 122 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 123 | context->recordError(Error(GL_INVALID_VALUE)); |
| 124 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 125 | } |
| 126 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 127 | if (isCompressed) |
| 128 | { |
tmartino | 0ccd5ae | 2015-10-01 14:33:14 -0400 | [diff] [blame^] | 129 | GLenum actualInternalFormat = |
| 130 | isSubImage ? texture->getInternalFormat(target, level) : internalformat; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 131 | switch (actualInternalFormat) |
| 132 | { |
| 133 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 134 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 135 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 136 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 137 | context->recordError(Error(GL_INVALID_ENUM)); |
| 138 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 139 | } |
| 140 | break; |
| 141 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 142 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 143 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 144 | context->recordError(Error(GL_INVALID_ENUM)); |
| 145 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 146 | } |
| 147 | break; |
| 148 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 149 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 150 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 151 | context->recordError(Error(GL_INVALID_ENUM)); |
| 152 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 153 | } |
| 154 | break; |
| 155 | default: |
tmartino | 0ccd5ae | 2015-10-01 14:33:14 -0400 | [diff] [blame^] | 156 | context->recordError(Error( |
| 157 | GL_INVALID_ENUM, "internalformat is not a supported compressed internal format")); |
| 158 | return false; |
| 159 | } |
| 160 | if (!ValidCompressedImageSize(context, actualInternalFormat, width, height)) |
| 161 | { |
| 162 | context->recordError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 163 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 164 | } |
| 165 | } |
| 166 | else |
| 167 | { |
| 168 | // validate <type> by itself (used as secondary key below) |
| 169 | switch (type) |
| 170 | { |
| 171 | case GL_UNSIGNED_BYTE: |
| 172 | case GL_UNSIGNED_SHORT_5_6_5: |
| 173 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 174 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 175 | case GL_UNSIGNED_SHORT: |
| 176 | case GL_UNSIGNED_INT: |
| 177 | case GL_UNSIGNED_INT_24_8_OES: |
| 178 | case GL_HALF_FLOAT_OES: |
| 179 | case GL_FLOAT: |
| 180 | break; |
| 181 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 182 | context->recordError(Error(GL_INVALID_ENUM)); |
| 183 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 184 | } |
| 185 | |
| 186 | // validate <format> + <type> combinations |
| 187 | // - invalid <format> -> sets INVALID_ENUM |
| 188 | // - invalid <format>+<type> combination -> sets INVALID_OPERATION |
| 189 | switch (format) |
| 190 | { |
| 191 | case GL_ALPHA: |
| 192 | case GL_LUMINANCE: |
| 193 | case GL_LUMINANCE_ALPHA: |
| 194 | switch (type) |
| 195 | { |
| 196 | case GL_UNSIGNED_BYTE: |
| 197 | case GL_FLOAT: |
| 198 | case GL_HALF_FLOAT_OES: |
| 199 | break; |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 200 | default: |
| 201 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 202 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 203 | } |
| 204 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 205 | case GL_RED: |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 206 | case GL_RG: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 207 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 208 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 209 | context->recordError(Error(GL_INVALID_ENUM)); |
| 210 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 211 | } |
| 212 | switch (type) |
| 213 | { |
| 214 | case GL_UNSIGNED_BYTE: |
| 215 | case GL_FLOAT: |
| 216 | case GL_HALF_FLOAT_OES: |
| 217 | break; |
| 218 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 219 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 220 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 221 | } |
| 222 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 223 | case GL_RGB: |
| 224 | switch (type) |
| 225 | { |
| 226 | case GL_UNSIGNED_BYTE: |
| 227 | case GL_UNSIGNED_SHORT_5_6_5: |
| 228 | case GL_FLOAT: |
| 229 | case GL_HALF_FLOAT_OES: |
| 230 | break; |
| 231 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 232 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 233 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 234 | } |
| 235 | break; |
| 236 | case GL_RGBA: |
| 237 | switch (type) |
| 238 | { |
| 239 | case GL_UNSIGNED_BYTE: |
| 240 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 241 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 242 | case GL_FLOAT: |
| 243 | case GL_HALF_FLOAT_OES: |
| 244 | break; |
| 245 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 246 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 247 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 248 | } |
| 249 | break; |
| 250 | case GL_BGRA_EXT: |
| 251 | switch (type) |
| 252 | { |
| 253 | case GL_UNSIGNED_BYTE: |
| 254 | break; |
| 255 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 256 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 257 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 258 | } |
| 259 | break; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 260 | case GL_SRGB_EXT: |
| 261 | case GL_SRGB_ALPHA_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 262 | if (!context->getExtensions().sRGB) |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 263 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 264 | context->recordError(Error(GL_INVALID_ENUM)); |
| 265 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 266 | } |
| 267 | switch (type) |
| 268 | { |
| 269 | case GL_UNSIGNED_BYTE: |
| 270 | break; |
| 271 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 272 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 273 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 274 | } |
| 275 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 276 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: // error cases for compressed textures are handled below |
| 277 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 278 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 279 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
| 280 | break; |
| 281 | case GL_DEPTH_COMPONENT: |
| 282 | switch (type) |
| 283 | { |
| 284 | case GL_UNSIGNED_SHORT: |
| 285 | case GL_UNSIGNED_INT: |
| 286 | break; |
| 287 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 288 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 289 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 290 | } |
| 291 | break; |
| 292 | case GL_DEPTH_STENCIL_OES: |
| 293 | switch (type) |
| 294 | { |
| 295 | case GL_UNSIGNED_INT_24_8_OES: |
| 296 | break; |
| 297 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 298 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 299 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 300 | } |
| 301 | break; |
| 302 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 303 | context->recordError(Error(GL_INVALID_ENUM)); |
| 304 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 305 | } |
| 306 | |
| 307 | switch (format) |
| 308 | { |
| 309 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 310 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 311 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 312 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 313 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 314 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 315 | } |
| 316 | else |
| 317 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 318 | context->recordError(Error(GL_INVALID_ENUM)); |
| 319 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 320 | } |
| 321 | break; |
| 322 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 323 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 324 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 325 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 326 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 327 | } |
| 328 | else |
| 329 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 330 | context->recordError(Error(GL_INVALID_ENUM)); |
| 331 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 332 | } |
| 333 | break; |
| 334 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 335 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 336 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 337 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 338 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 339 | } |
| 340 | else |
| 341 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 342 | context->recordError(Error(GL_INVALID_ENUM)); |
| 343 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 344 | } |
| 345 | break; |
| 346 | case GL_DEPTH_COMPONENT: |
| 347 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 348 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 349 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 350 | context->recordError(Error(GL_INVALID_VALUE)); |
| 351 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 352 | } |
| 353 | if (target != GL_TEXTURE_2D) |
| 354 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 355 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 356 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 357 | } |
| 358 | // OES_depth_texture supports loading depth data and multiple levels, |
| 359 | // but ANGLE_depth_texture does not |
| 360 | if (pixels != NULL || level != 0) |
| 361 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 362 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 363 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 364 | } |
| 365 | break; |
| 366 | default: |
| 367 | break; |
| 368 | } |
| 369 | |
| 370 | if (type == GL_FLOAT) |
| 371 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 372 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 373 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 374 | context->recordError(Error(GL_INVALID_ENUM)); |
| 375 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 376 | } |
| 377 | } |
| 378 | else if (type == GL_HALF_FLOAT_OES) |
| 379 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 380 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 381 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 382 | context->recordError(Error(GL_INVALID_ENUM)); |
| 383 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 384 | } |
| 385 | } |
| 386 | } |
| 387 | |
| 388 | return true; |
| 389 | } |
| 390 | |
| 391 | |
| 392 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 393 | bool ValidateES2CopyTexImageParameters(Context* context, GLenum target, GLint level, GLenum internalformat, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 394 | GLint xoffset, GLint yoffset, GLint x, GLint y, GLsizei width, GLsizei height, |
| 395 | GLint border) |
| 396 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 397 | GLenum textureInternalFormat = GL_NONE; |
Shannon Woods | 4dfed83 | 2014-03-17 20:03:39 -0400 | [diff] [blame] | 398 | |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 399 | if (!ValidateCopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
| 400 | xoffset, yoffset, 0, x, y, width, height, border, &textureInternalFormat)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 401 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 402 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 403 | } |
| 404 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 405 | gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer(); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 406 | GLenum colorbufferFormat = framebuffer->getReadColorbuffer()->getInternalFormat(); |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 407 | const auto &internalFormatInfo = gl::GetInternalFormatInfo(textureInternalFormat); |
| 408 | GLenum textureFormat = internalFormatInfo.format; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 409 | |
| 410 | // [OpenGL ES 2.0.24] table 3.9 |
| 411 | if (isSubImage) |
| 412 | { |
| 413 | switch (textureFormat) |
| 414 | { |
| 415 | case GL_ALPHA: |
| 416 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 417 | colorbufferFormat != GL_RGBA4 && |
| 418 | colorbufferFormat != GL_RGB5_A1 && |
| 419 | colorbufferFormat != GL_RGBA8_OES) |
| 420 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 421 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 422 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 423 | } |
| 424 | break; |
| 425 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 426 | if (colorbufferFormat != GL_R8_EXT && |
| 427 | colorbufferFormat != GL_RG8_EXT && |
| 428 | colorbufferFormat != GL_RGB565 && |
| 429 | colorbufferFormat != GL_RGB8_OES && |
| 430 | colorbufferFormat != GL_RGBA4 && |
| 431 | colorbufferFormat != GL_RGB5_A1 && |
| 432 | colorbufferFormat != GL_RGBA8_OES) |
| 433 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 434 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 435 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 436 | } |
| 437 | break; |
| 438 | case GL_RED_EXT: |
| 439 | if (colorbufferFormat != GL_R8_EXT && |
| 440 | colorbufferFormat != GL_RG8_EXT && |
| 441 | colorbufferFormat != GL_RGB565 && |
| 442 | colorbufferFormat != GL_RGB8_OES && |
| 443 | colorbufferFormat != GL_RGBA4 && |
| 444 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 445 | colorbufferFormat != GL_RGBA8_OES && |
| 446 | colorbufferFormat != GL_R32F && |
| 447 | colorbufferFormat != GL_RG32F && |
| 448 | colorbufferFormat != GL_RGB32F && |
| 449 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 450 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 451 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 452 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 453 | } |
| 454 | break; |
| 455 | case GL_RG_EXT: |
| 456 | if (colorbufferFormat != GL_RG8_EXT && |
| 457 | colorbufferFormat != GL_RGB565 && |
| 458 | colorbufferFormat != GL_RGB8_OES && |
| 459 | colorbufferFormat != GL_RGBA4 && |
| 460 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 461 | colorbufferFormat != GL_RGBA8_OES && |
| 462 | colorbufferFormat != GL_RG32F && |
| 463 | colorbufferFormat != GL_RGB32F && |
| 464 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 465 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 466 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 467 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 468 | } |
| 469 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 470 | case GL_RGB: |
| 471 | if (colorbufferFormat != GL_RGB565 && |
| 472 | colorbufferFormat != GL_RGB8_OES && |
| 473 | colorbufferFormat != GL_RGBA4 && |
| 474 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 475 | colorbufferFormat != GL_RGBA8_OES && |
| 476 | colorbufferFormat != GL_RGB32F && |
| 477 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 478 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 479 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 480 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 481 | } |
| 482 | break; |
| 483 | case GL_LUMINANCE_ALPHA: |
| 484 | case GL_RGBA: |
| 485 | if (colorbufferFormat != GL_RGBA4 && |
| 486 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 487 | colorbufferFormat != GL_RGBA8_OES && |
| 488 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 489 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 490 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 491 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 492 | } |
| 493 | break; |
| 494 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 495 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 496 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 497 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 498 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 499 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 500 | case GL_DEPTH_COMPONENT: |
| 501 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 502 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 503 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 504 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 505 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 506 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 507 | } |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 508 | |
| 509 | if (internalFormatInfo.type == GL_FLOAT && |
| 510 | !context->getExtensions().textureFloat) |
| 511 | { |
| 512 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 513 | return false; |
| 514 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 515 | } |
| 516 | else |
| 517 | { |
| 518 | switch (internalformat) |
| 519 | { |
| 520 | case GL_ALPHA: |
| 521 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 522 | colorbufferFormat != GL_RGBA4 && |
| 523 | colorbufferFormat != GL_RGB5_A1 && |
| 524 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 525 | colorbufferFormat != GL_RGBA8_OES && |
| 526 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 527 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 528 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 529 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 530 | } |
| 531 | break; |
| 532 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 533 | if (colorbufferFormat != GL_R8_EXT && |
| 534 | colorbufferFormat != GL_RG8_EXT && |
| 535 | colorbufferFormat != GL_RGB565 && |
| 536 | colorbufferFormat != GL_RGB8_OES && |
| 537 | colorbufferFormat != GL_RGBA4 && |
| 538 | colorbufferFormat != GL_RGB5_A1 && |
| 539 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 540 | colorbufferFormat != GL_RGBA8_OES && |
| 541 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 542 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 543 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 544 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 545 | } |
| 546 | break; |
| 547 | case GL_RED_EXT: |
| 548 | if (colorbufferFormat != GL_R8_EXT && |
| 549 | colorbufferFormat != GL_RG8_EXT && |
| 550 | colorbufferFormat != GL_RGB565 && |
| 551 | colorbufferFormat != GL_RGB8_OES && |
| 552 | colorbufferFormat != GL_RGBA4 && |
| 553 | colorbufferFormat != GL_RGB5_A1 && |
| 554 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 555 | colorbufferFormat != GL_RGBA8_OES && |
| 556 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 557 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 558 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 559 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 560 | } |
| 561 | break; |
| 562 | case GL_RG_EXT: |
| 563 | if (colorbufferFormat != GL_RG8_EXT && |
| 564 | colorbufferFormat != GL_RGB565 && |
| 565 | colorbufferFormat != GL_RGB8_OES && |
| 566 | colorbufferFormat != GL_RGBA4 && |
| 567 | colorbufferFormat != GL_RGB5_A1 && |
| 568 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 569 | colorbufferFormat != GL_RGBA8_OES && |
| 570 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 571 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 572 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 573 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 574 | } |
| 575 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 576 | case GL_RGB: |
| 577 | if (colorbufferFormat != GL_RGB565 && |
| 578 | colorbufferFormat != GL_RGB8_OES && |
| 579 | colorbufferFormat != GL_RGBA4 && |
| 580 | colorbufferFormat != GL_RGB5_A1 && |
| 581 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 582 | colorbufferFormat != GL_RGBA8_OES && |
| 583 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 584 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 585 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 586 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 587 | } |
| 588 | break; |
| 589 | case GL_LUMINANCE_ALPHA: |
| 590 | case GL_RGBA: |
| 591 | if (colorbufferFormat != GL_RGBA4 && |
| 592 | colorbufferFormat != GL_RGB5_A1 && |
| 593 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 594 | colorbufferFormat != GL_RGBA8_OES && |
| 595 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 596 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 597 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 598 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 599 | } |
| 600 | break; |
| 601 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 602 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 603 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 604 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 605 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 606 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 607 | } |
| 608 | else |
| 609 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 610 | context->recordError(Error(GL_INVALID_ENUM)); |
| 611 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 612 | } |
| 613 | break; |
| 614 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 615 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 616 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 617 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 618 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 619 | } |
| 620 | else |
| 621 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 622 | context->recordError(Error(GL_INVALID_ENUM)); |
| 623 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 624 | } |
| 625 | break; |
| 626 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 627 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 628 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 629 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 630 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 631 | } |
| 632 | else |
| 633 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 634 | context->recordError(Error(GL_INVALID_ENUM)); |
| 635 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 636 | } |
| 637 | break; |
| 638 | case GL_DEPTH_COMPONENT: |
| 639 | case GL_DEPTH_COMPONENT16: |
| 640 | case GL_DEPTH_COMPONENT32_OES: |
| 641 | case GL_DEPTH_STENCIL_OES: |
| 642 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 643 | if (context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 644 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 645 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 646 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 647 | } |
| 648 | else |
| 649 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 650 | context->recordError(Error(GL_INVALID_ENUM)); |
| 651 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 652 | } |
| 653 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 654 | context->recordError(Error(GL_INVALID_ENUM)); |
| 655 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 656 | } |
| 657 | } |
| 658 | |
Geoff Lang | 784a8fd | 2013-09-24 12:33:16 -0400 | [diff] [blame] | 659 | // If width or height is zero, it is a no-op. Return false without setting an error. |
| 660 | return (width > 0 && height > 0); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 661 | } |
| 662 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 663 | bool ValidateES2TexStorageParameters(Context *context, GLenum target, GLsizei levels, GLenum internalformat, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 664 | GLsizei width, GLsizei height) |
| 665 | { |
| 666 | if (target != GL_TEXTURE_2D && target != GL_TEXTURE_CUBE_MAP) |
| 667 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 668 | context->recordError(Error(GL_INVALID_ENUM)); |
| 669 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 670 | } |
| 671 | |
| 672 | if (width < 1 || height < 1 || levels < 1) |
| 673 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 674 | context->recordError(Error(GL_INVALID_VALUE)); |
| 675 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 676 | } |
| 677 | |
| 678 | if (target == GL_TEXTURE_CUBE_MAP && width != height) |
| 679 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 680 | context->recordError(Error(GL_INVALID_VALUE)); |
| 681 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 682 | } |
| 683 | |
| 684 | if (levels != 1 && levels != gl::log2(std::max(width, height)) + 1) |
| 685 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 686 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 687 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 688 | } |
| 689 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 690 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat); |
| 691 | if (formatInfo.format == GL_NONE || formatInfo.type == GL_NONE) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 692 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 693 | context->recordError(Error(GL_INVALID_ENUM)); |
| 694 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 695 | } |
| 696 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 697 | const gl::Caps &caps = context->getCaps(); |
| 698 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 699 | switch (target) |
| 700 | { |
| 701 | case GL_TEXTURE_2D: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 702 | if (static_cast<GLuint>(width) > caps.max2DTextureSize || |
| 703 | static_cast<GLuint>(height) > caps.max2DTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 704 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 705 | context->recordError(Error(GL_INVALID_VALUE)); |
| 706 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 707 | } |
| 708 | break; |
| 709 | case GL_TEXTURE_CUBE_MAP: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 710 | if (static_cast<GLuint>(width) > caps.maxCubeMapTextureSize || |
| 711 | static_cast<GLuint>(height) > caps.maxCubeMapTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 712 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 713 | context->recordError(Error(GL_INVALID_VALUE)); |
| 714 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 715 | } |
| 716 | break; |
| 717 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 718 | context->recordError(Error(GL_INVALID_ENUM)); |
| 719 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 720 | } |
| 721 | |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 722 | if (levels != 1 && !context->getExtensions().textureNPOT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 723 | { |
| 724 | if (!gl::isPow2(width) || !gl::isPow2(height)) |
| 725 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 726 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 727 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 728 | } |
| 729 | } |
| 730 | |
| 731 | switch (internalformat) |
| 732 | { |
| 733 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 734 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 735 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 736 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 737 | context->recordError(Error(GL_INVALID_ENUM)); |
| 738 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 739 | } |
| 740 | break; |
| 741 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 742 | if (!context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 743 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 744 | context->recordError(Error(GL_INVALID_ENUM)); |
| 745 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 746 | } |
| 747 | break; |
| 748 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 749 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 750 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 751 | context->recordError(Error(GL_INVALID_ENUM)); |
| 752 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 753 | } |
| 754 | break; |
| 755 | case GL_RGBA32F_EXT: |
| 756 | case GL_RGB32F_EXT: |
| 757 | case GL_ALPHA32F_EXT: |
| 758 | case GL_LUMINANCE32F_EXT: |
| 759 | case GL_LUMINANCE_ALPHA32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 760 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 761 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 762 | context->recordError(Error(GL_INVALID_ENUM)); |
| 763 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 764 | } |
| 765 | break; |
| 766 | case GL_RGBA16F_EXT: |
| 767 | case GL_RGB16F_EXT: |
| 768 | case GL_ALPHA16F_EXT: |
| 769 | case GL_LUMINANCE16F_EXT: |
| 770 | case GL_LUMINANCE_ALPHA16F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 771 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 772 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 773 | context->recordError(Error(GL_INVALID_ENUM)); |
| 774 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 775 | } |
| 776 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 777 | case GL_R8_EXT: |
| 778 | case GL_RG8_EXT: |
| 779 | case GL_R16F_EXT: |
| 780 | case GL_RG16F_EXT: |
| 781 | case GL_R32F_EXT: |
| 782 | case GL_RG32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 783 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 784 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 785 | context->recordError(Error(GL_INVALID_ENUM)); |
| 786 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 787 | } |
| 788 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 789 | case GL_DEPTH_COMPONENT16: |
| 790 | case GL_DEPTH_COMPONENT32_OES: |
| 791 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 792 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 793 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 794 | context->recordError(Error(GL_INVALID_ENUM)); |
| 795 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 796 | } |
| 797 | if (target != GL_TEXTURE_2D) |
| 798 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 799 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 800 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 801 | } |
| 802 | // ANGLE_depth_texture only supports 1-level textures |
| 803 | if (levels != 1) |
| 804 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 805 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 806 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 807 | } |
| 808 | break; |
| 809 | default: |
| 810 | break; |
| 811 | } |
| 812 | |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 813 | gl::Texture *texture = context->getTargetTexture(target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 814 | if (!texture || texture->id() == 0) |
| 815 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 816 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 817 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 818 | } |
| 819 | |
Geoff Lang | 69cce58 | 2015-09-17 13:20:36 -0400 | [diff] [blame] | 820 | if (texture->getImmutableFormat()) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 821 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 822 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 823 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 824 | } |
| 825 | |
| 826 | return true; |
| 827 | } |
| 828 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 829 | // check for combinations of format and type that are valid for ReadPixels |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 830 | bool ValidES2ReadFormatType(Context *context, GLenum format, GLenum type) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 831 | { |
| 832 | switch (format) |
| 833 | { |
| 834 | case GL_RGBA: |
| 835 | switch (type) |
| 836 | { |
| 837 | case GL_UNSIGNED_BYTE: |
| 838 | break; |
| 839 | default: |
| 840 | return false; |
| 841 | } |
| 842 | break; |
| 843 | case GL_BGRA_EXT: |
| 844 | switch (type) |
| 845 | { |
| 846 | case GL_UNSIGNED_BYTE: |
| 847 | case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT: |
| 848 | case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT: |
| 849 | break; |
| 850 | default: |
| 851 | return false; |
| 852 | } |
| 853 | break; |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 854 | case GL_RG_EXT: |
| 855 | case GL_RED_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 856 | if (!context->getExtensions().textureRG) |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 857 | { |
| 858 | return false; |
| 859 | } |
| 860 | switch (type) |
| 861 | { |
| 862 | case GL_UNSIGNED_BYTE: |
| 863 | break; |
| 864 | default: |
| 865 | return false; |
| 866 | } |
| 867 | break; |
| 868 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 869 | default: |
| 870 | return false; |
| 871 | } |
| 872 | return true; |
| 873 | } |
| 874 | |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 875 | bool ValidateDiscardFramebufferEXT(Context *context, GLenum target, GLsizei numAttachments, |
| 876 | const GLenum *attachments) |
| 877 | { |
| 878 | bool defaultFramebuffer = false; |
| 879 | |
| 880 | switch (target) |
| 881 | { |
| 882 | case GL_FRAMEBUFFER: |
| 883 | defaultFramebuffer = (context->getState().getTargetFramebuffer(GL_FRAMEBUFFER)->id() == 0); |
| 884 | break; |
| 885 | default: |
| 886 | context->recordError(Error(GL_INVALID_ENUM, "Invalid framebuffer target")); |
| 887 | return false; |
| 888 | } |
| 889 | |
| 890 | return ValidateDiscardFramebufferBase(context, target, numAttachments, attachments, defaultFramebuffer); |
| 891 | } |
| 892 | |
Dian Xiang | bf18ed0 | 2015-09-11 10:50:04 -0700 | [diff] [blame] | 893 | bool ValidateDrawBuffers(Context *context, GLsizei n, const GLenum *bufs) |
| 894 | { |
| 895 | // INVALID_VALUE is generated if n is negative or greater than value of MAX_DRAW_BUFFERS |
| 896 | if (n < 0 || static_cast<GLuint>(n) > context->getCaps().maxDrawBuffers) |
| 897 | { |
| 898 | context->recordError( |
| 899 | Error(GL_INVALID_VALUE, "n must be non-negative and no greater than MAX_DRAW_BUFFERS")); |
| 900 | return false; |
| 901 | } |
| 902 | |
| 903 | ASSERT(context->getState().getDrawFramebuffer()); |
| 904 | GLuint frameBufferId = context->getState().getDrawFramebuffer()->id(); |
| 905 | GLuint maxColorAttachment = GL_COLOR_ATTACHMENT0_EXT + context->getCaps().maxColorAttachments; |
| 906 | |
| 907 | // This should come first before the check for the default frame buffer |
| 908 | // because when we switch to ES3.1+, invalid enums will return INVALID_ENUM |
| 909 | // rather than INVALID_OPERATION |
| 910 | for (int colorAttachment = 0; colorAttachment < n; colorAttachment++) |
| 911 | { |
| 912 | const GLenum attachment = GL_COLOR_ATTACHMENT0_EXT + colorAttachment; |
| 913 | |
| 914 | if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != GL_BACK && |
| 915 | (bufs[colorAttachment] < GL_COLOR_ATTACHMENT0_EXT || |
| 916 | bufs[colorAttachment] >= maxColorAttachment)) |
| 917 | { |
| 918 | // Value in bufs is not NONE, BACK, or GL_COLOR_ATTACHMENTi |
| 919 | // In the 3.0 specs, the error should return GL_INVALID_OPERATION. |
| 920 | // When we move to 3.1 specs, we should change the error to be GL_INVALID_ENUM |
| 921 | context->recordError(Error(GL_INVALID_OPERATION, "Invalid buffer value")); |
| 922 | return false; |
| 923 | } |
| 924 | else if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != attachment && |
| 925 | frameBufferId != 0) |
| 926 | { |
| 927 | // INVALID_OPERATION-GL is bound to buffer and ith argument |
| 928 | // is not COLOR_ATTACHMENTi or NONE |
| 929 | context->recordError( |
| 930 | Error(GL_INVALID_OPERATION, "Ith value does not match COLOR_ATTACHMENTi or NONE")); |
| 931 | return false; |
| 932 | } |
| 933 | } |
| 934 | |
| 935 | // INVALID_OPERATION is generated if GL is bound to the default framebuffer |
| 936 | // and n is not 1 or bufs is bound to value other than BACK and NONE |
| 937 | if (frameBufferId == 0) |
| 938 | { |
| 939 | if (n != 1) |
| 940 | { |
| 941 | context->recordError(Error(GL_INVALID_OPERATION, |
| 942 | "n must be 1 when GL is bound to the default framebuffer")); |
| 943 | return false; |
| 944 | } |
| 945 | |
| 946 | if (bufs[0] != GL_NONE && bufs[0] != GL_BACK) |
| 947 | { |
| 948 | context->recordError(Error( |
| 949 | GL_INVALID_OPERATION, |
| 950 | "Only NONE or BACK are valid values when drawing to the default framebuffer")); |
| 951 | return false; |
| 952 | } |
| 953 | } |
| 954 | |
| 955 | return true; |
| 956 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 957 | } |