blob: 92402907636ee00c53725b7f97ce4dd0b6ffbf5c [file] [log] [blame]
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001//
Geoff Langcec35902014-04-16 10:52:36 -04002// Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved.
Geoff Lange8ebe7f2013-08-05 15:03:13 -04003// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6
7// validationES.h: Validation functions for generic OpenGL ES entry point parameters
8
Geoff Lang2b5420c2014-11-19 14:20:15 -05009#include "libANGLE/validationES.h"
Jamie Madille2e406c2016-06-02 13:04:10 -040010
Geoff Lang2b5420c2014-11-19 14:20:15 -050011#include "libANGLE/Context.h"
Geoff Langa8406172015-07-21 16:53:39 -040012#include "libANGLE/Display.h"
Brandon Jones6cad5662017-06-14 13:25:13 -070013#include "libANGLE/ErrorStrings.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050014#include "libANGLE/Framebuffer.h"
15#include "libANGLE/FramebufferAttachment.h"
Geoff Langa8406172015-07-21 16:53:39 -040016#include "libANGLE/Image.h"
Geoff Lang7dd2e102014-11-10 15:19:26 -050017#include "libANGLE/Program.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040018#include "libANGLE/Query.h"
19#include "libANGLE/Texture.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050020#include "libANGLE/TransformFeedback.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040021#include "libANGLE/Uniform.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050022#include "libANGLE/VertexArray.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040023#include "libANGLE/formatutils.h"
24#include "libANGLE/validationES2.h"
25#include "libANGLE/validationES3.h"
Geoff Lange8ebe7f2013-08-05 15:03:13 -040026
27#include "common/mathutil.h"
28#include "common/utilities.h"
29
Jamie Madille2e406c2016-06-02 13:04:10 -040030using namespace angle;
31
Geoff Lange8ebe7f2013-08-05 15:03:13 -040032namespace gl
33{
Jamie Madill1ca74672015-07-21 15:14:11 -040034namespace
35{
Corentin Wallez92db6942016-12-09 13:10:36 -050036bool ValidateDrawAttribs(ValidationContext *context,
37 GLint primcount,
38 GLint maxVertex,
39 GLint vertexCount)
Jamie Madill1ca74672015-07-21 15:14:11 -040040{
Jamie Madilldfde6ab2016-06-09 07:07:18 -070041 const gl::State &state = context->getGLState();
Jamie Madill1ca74672015-07-21 15:14:11 -040042 const gl::Program *program = state.getProgram();
43
Corentin Wallez327411e2016-12-09 11:09:17 -050044 bool webglCompatibility = context->getExtensions().webglCompatibility;
45
Jamie Madill231c7f52017-04-26 13:45:37 -040046 const VertexArray *vao = state.getVertexArray();
47 const auto &vertexAttribs = vao->getVertexAttributes();
Jiawei-Shao2597fb62016-12-09 16:38:02 +080048 const auto &vertexBindings = vao->getVertexBindings();
Jamie Madill231c7f52017-04-26 13:45:37 -040049 size_t maxEnabledAttrib = vao->getMaxEnabledAttribute();
Jamie Madill1ca74672015-07-21 15:14:11 -040050 for (size_t attributeIndex = 0; attributeIndex < maxEnabledAttrib; ++attributeIndex)
51 {
52 const VertexAttribute &attrib = vertexAttribs[attributeIndex];
Corentin Wallez672f7f32017-06-15 17:42:17 -040053
54 // No need to range check for disabled attribs.
55 if (!attrib.enabled)
Jamie Madill1ca74672015-07-21 15:14:11 -040056 {
Corentin Wallezfd456442016-12-21 17:57:00 -050057 continue;
58 }
Jamie Madill1ca74672015-07-21 15:14:11 -040059
Jamie Madill231c7f52017-04-26 13:45:37 -040060 // If we have no buffer, then we either get an error, or there are no more checks to be
61 // done.
Corentin Wallez672f7f32017-06-15 17:42:17 -040062 const VertexBinding &binding = vertexBindings[attrib.bindingIndex];
63 gl::Buffer *buffer = binding.getBuffer().get();
Corentin Wallezfd456442016-12-21 17:57:00 -050064 if (!buffer)
65 {
Geoff Langfeb8c682017-02-13 16:07:35 -050066 if (webglCompatibility || !state.areClientArraysEnabled())
Corentin Wallez327411e2016-12-09 11:09:17 -050067 {
68 // [WebGL 1.0] Section 6.5 Enabled Vertex Attributes and Range Checking
Corentin Wallezfd456442016-12-21 17:57:00 -050069 // If a vertex attribute is enabled as an array via enableVertexAttribArray but
70 // no buffer is bound to that attribute via bindBuffer and vertexAttribPointer,
71 // then calls to drawArrays or drawElements will generate an INVALID_OPERATION
72 // error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -050073 context->handleError(InvalidOperation()
74 << "An enabled vertex array has no buffer.");
Corentin Wallezfd456442016-12-21 17:57:00 -050075 return false;
Corentin Wallez327411e2016-12-09 11:09:17 -050076 }
Corentin Wallezfd456442016-12-21 17:57:00 -050077 else if (attrib.pointer == nullptr)
Jamie Madill1ca74672015-07-21 15:14:11 -040078 {
79 // This is an application error that would normally result in a crash,
80 // but we catch it and return an error
Yuly Novikovc4d18aa2017-03-09 18:45:02 -050081 context->handleError(InvalidOperation()
82 << "An enabled vertex array has no buffer and no pointer.");
Jamie Madill1ca74672015-07-21 15:14:11 -040083 return false;
84 }
Corentin Wallezfd456442016-12-21 17:57:00 -050085 continue;
86 }
87
Corentin Wallez672f7f32017-06-15 17:42:17 -040088 // This needs to come after the check for client arrays as even unused attributes cannot use
89 // client-side arrays
90 if (!program->isAttribLocationActive(attributeIndex))
91 {
92 continue;
93 }
94
Corentin Wallezfd456442016-12-21 17:57:00 -050095 // If we're drawing zero vertices, we have enough data.
96 if (vertexCount <= 0 || primcount <= 0)
97 {
98 continue;
99 }
100
101 GLint maxVertexElement = 0;
Martin Radevdd5f27e2017-06-07 10:17:09 +0300102 GLuint divisor = binding.getDivisor();
103 if (divisor == 0)
Corentin Wallezfd456442016-12-21 17:57:00 -0500104 {
105 maxVertexElement = maxVertex;
106 }
107 else
108 {
Martin Radevdd5f27e2017-06-07 10:17:09 +0300109 maxVertexElement = (primcount - 1) / divisor;
Corentin Wallezfd456442016-12-21 17:57:00 -0500110 }
111
112 // We do manual overflow checks here instead of using safe_math.h because it was
113 // a bottleneck. Thanks to some properties of GL we know inequalities that can
114 // help us make the overflow checks faster.
115
116 // The max possible attribSize is 16 for a vector of 4 32 bit values.
117 constexpr uint64_t kMaxAttribSize = 16;
118 constexpr uint64_t kIntMax = std::numeric_limits<int>::max();
119 constexpr uint64_t kUint64Max = std::numeric_limits<uint64_t>::max();
120
121 // We know attribStride is given as a GLsizei which is typedefed to int.
122 // We also know an upper bound for attribSize.
123 static_assert(std::is_same<int, GLsizei>::value, "");
Jiawei-Shao2597fb62016-12-09 16:38:02 +0800124 uint64_t attribStride = ComputeVertexAttributeStride(attrib, binding);
Corentin Wallezfd456442016-12-21 17:57:00 -0500125 uint64_t attribSize = ComputeVertexAttributeTypeSize(attrib);
126 ASSERT(attribStride <= kIntMax && attribSize <= kMaxAttribSize);
127
128 // Computing the max offset using uint64_t without attrib.offset is overflow
129 // safe. Note: Last vertex element does not take the full stride!
130 static_assert(kIntMax * kIntMax < kUint64Max - kMaxAttribSize, "");
131 uint64_t attribDataSizeNoOffset = maxVertexElement * attribStride + attribSize;
132
133 // An overflow can happen when adding the offset, check for it.
Jiawei-Shao2597fb62016-12-09 16:38:02 +0800134 uint64_t attribOffset = ComputeVertexAttributeOffset(attrib, binding);
135 if (attribDataSizeNoOffset > kUint64Max - attribOffset)
Corentin Wallezfd456442016-12-21 17:57:00 -0500136 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500137 context->handleError(InvalidOperation() << "Integer overflow.");
Corentin Wallezfd456442016-12-21 17:57:00 -0500138 return false;
139 }
140 uint64_t attribDataSizeWithOffset = attribDataSizeNoOffset + attribOffset;
141
142 // [OpenGL ES 3.0.2] section 2.9.4 page 40:
143 // We can return INVALID_OPERATION if our vertex attribute does not have
144 // enough backing data.
145 if (attribDataSizeWithOffset > static_cast<uint64_t>(buffer->getSize()))
146 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500147 context->handleError(InvalidOperation()
148 << "Vertex buffer is not big enough for the draw call");
Corentin Wallezfd456442016-12-21 17:57:00 -0500149 return false;
Jamie Madill1ca74672015-07-21 15:14:11 -0400150 }
151 }
152
153 return true;
154}
155
Geoff Lang280ba992017-04-18 16:30:58 -0400156bool ValidReadPixelsTypeEnum(ValidationContext *context, GLenum type)
157{
158 switch (type)
159 {
160 // Types referenced in Table 3.4 of the ES 2.0.25 spec
161 case GL_UNSIGNED_BYTE:
162 case GL_UNSIGNED_SHORT_4_4_4_4:
163 case GL_UNSIGNED_SHORT_5_5_5_1:
164 case GL_UNSIGNED_SHORT_5_6_5:
165 return context->getClientVersion() >= ES_2_0;
166
167 // Types referenced in Table 3.2 of the ES 3.0.5 spec (Except depth stencil)
168 case GL_BYTE:
169 case GL_INT:
170 case GL_SHORT:
171 case GL_UNSIGNED_INT:
172 case GL_UNSIGNED_INT_10F_11F_11F_REV:
173 case GL_UNSIGNED_INT_24_8:
174 case GL_UNSIGNED_INT_2_10_10_10_REV:
175 case GL_UNSIGNED_INT_5_9_9_9_REV:
176 case GL_UNSIGNED_SHORT:
177 case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT:
178 case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT:
179 return context->getClientVersion() >= ES_3_0;
180
181 case GL_FLOAT:
182 return context->getClientVersion() >= ES_3_0 || context->getExtensions().textureFloat;
183
184 case GL_HALF_FLOAT:
185 return context->getClientVersion() >= ES_3_0 ||
186 context->getExtensions().textureHalfFloat;
187
188 case GL_HALF_FLOAT_OES:
189 return context->getExtensions().colorBufferHalfFloat;
190
191 default:
192 return false;
193 }
194}
195
196bool ValidReadPixelsFormatEnum(ValidationContext *context, GLenum format)
197{
198 switch (format)
199 {
200 // Formats referenced in Table 3.4 of the ES 2.0.25 spec (Except luminance)
201 case GL_RGBA:
202 case GL_RGB:
203 case GL_ALPHA:
204 return context->getClientVersion() >= ES_2_0;
205
206 // Formats referenced in Table 3.2 of the ES 3.0.5 spec
207 case GL_RG:
208 case GL_RED:
209 case GL_RGBA_INTEGER:
210 case GL_RGB_INTEGER:
211 case GL_RG_INTEGER:
212 case GL_RED_INTEGER:
213 return context->getClientVersion() >= ES_3_0;
214
215 case GL_SRGB_ALPHA_EXT:
216 case GL_SRGB_EXT:
217 return context->getExtensions().sRGB;
218
219 case GL_BGRA_EXT:
220 return context->getExtensions().readFormatBGRA;
221
222 default:
223 return false;
224 }
225}
226
Geoff Langf607c602016-09-21 11:46:48 -0400227bool ValidReadPixelsFormatType(ValidationContext *context,
228 GLenum framebufferComponentType,
229 GLenum format,
230 GLenum type)
231{
232 switch (framebufferComponentType)
233 {
234 case GL_UNSIGNED_NORMALIZED:
235 // TODO(geofflang): Don't accept BGRA here. Some chrome internals appear to try to use
236 // ReadPixels with BGRA even if the extension is not present
237 return (format == GL_RGBA && type == GL_UNSIGNED_BYTE) ||
238 (context->getExtensions().readFormatBGRA && format == GL_BGRA_EXT &&
239 type == GL_UNSIGNED_BYTE);
240
241 case GL_SIGNED_NORMALIZED:
242 return (format == GL_RGBA && type == GL_UNSIGNED_BYTE);
243
244 case GL_INT:
245 return (format == GL_RGBA_INTEGER && type == GL_INT);
246
247 case GL_UNSIGNED_INT:
248 return (format == GL_RGBA_INTEGER && type == GL_UNSIGNED_INT);
249
250 case GL_FLOAT:
251 return (format == GL_RGBA && type == GL_FLOAT);
252
253 default:
254 UNREACHABLE();
255 return false;
256 }
257}
258
Geoff Langc1984ed2016-10-07 12:41:00 -0400259template <typename ParamType>
260bool ValidateTextureWrapModeValue(Context *context, ParamType *params, bool isExternalTextureTarget)
261{
262 switch (ConvertToGLenum(params[0]))
263 {
264 case GL_CLAMP_TO_EDGE:
265 break;
266
267 case GL_REPEAT:
268 case GL_MIRRORED_REPEAT:
269 if (isExternalTextureTarget)
270 {
271 // OES_EGL_image_external specifies this error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500272 context->handleError(InvalidEnum()
273 << "external textures only support CLAMP_TO_EDGE wrap mode");
Geoff Langc1984ed2016-10-07 12:41:00 -0400274 return false;
275 }
276 break;
277
278 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500279 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400280 return false;
281 }
282
283 return true;
284}
285
286template <typename ParamType>
287bool ValidateTextureMinFilterValue(Context *context,
288 ParamType *params,
289 bool isExternalTextureTarget)
290{
291 switch (ConvertToGLenum(params[0]))
292 {
293 case GL_NEAREST:
294 case GL_LINEAR:
295 break;
296
297 case GL_NEAREST_MIPMAP_NEAREST:
298 case GL_LINEAR_MIPMAP_NEAREST:
299 case GL_NEAREST_MIPMAP_LINEAR:
300 case GL_LINEAR_MIPMAP_LINEAR:
301 if (isExternalTextureTarget)
302 {
303 // OES_EGL_image_external specifies this error.
304 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500305 InvalidEnum() << "external textures only support NEAREST and LINEAR filtering");
Geoff Langc1984ed2016-10-07 12:41:00 -0400306 return false;
307 }
308 break;
309
310 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700311 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam);
Geoff Langc1984ed2016-10-07 12:41:00 -0400312 return false;
313 }
314
315 return true;
316}
317
318template <typename ParamType>
319bool ValidateTextureMagFilterValue(Context *context, ParamType *params)
320{
321 switch (ConvertToGLenum(params[0]))
322 {
323 case GL_NEAREST:
324 case GL_LINEAR:
325 break;
326
327 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700328 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam);
Geoff Langc1984ed2016-10-07 12:41:00 -0400329 return false;
330 }
331
332 return true;
333}
334
335template <typename ParamType>
336bool ValidateTextureCompareModeValue(Context *context, ParamType *params)
337{
338 // Acceptable mode parameters from GLES 3.0.2 spec, table 3.17
339 switch (ConvertToGLenum(params[0]))
340 {
341 case GL_NONE:
342 case GL_COMPARE_REF_TO_TEXTURE:
343 break;
344
345 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500346 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400347 return false;
348 }
349
350 return true;
351}
352
353template <typename ParamType>
354bool ValidateTextureCompareFuncValue(Context *context, ParamType *params)
355{
356 // Acceptable function parameters from GLES 3.0.2 spec, table 3.17
357 switch (ConvertToGLenum(params[0]))
358 {
359 case GL_LEQUAL:
360 case GL_GEQUAL:
361 case GL_LESS:
362 case GL_GREATER:
363 case GL_EQUAL:
364 case GL_NOTEQUAL:
365 case GL_ALWAYS:
366 case GL_NEVER:
367 break;
368
369 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500370 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400371 return false;
372 }
373
374 return true;
375}
376
377template <typename ParamType>
Geoff Lang81c6b572016-10-19 14:07:52 -0700378bool ValidateTextureSRGBDecodeValue(Context *context, ParamType *params)
379{
380 if (!context->getExtensions().textureSRGBDecode)
381 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700382 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Geoff Lang81c6b572016-10-19 14:07:52 -0700383 return false;
384 }
385
386 switch (ConvertToGLenum(params[0]))
387 {
388 case GL_DECODE_EXT:
389 case GL_SKIP_DECODE_EXT:
390 break;
391
392 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500393 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Lang81c6b572016-10-19 14:07:52 -0700394 return false;
395 }
396
397 return true;
398}
399
400template <typename ParamType>
Geoff Langc1984ed2016-10-07 12:41:00 -0400401bool ValidateSamplerParameterBase(Context *context,
402 GLuint sampler,
403 GLenum pname,
404 GLsizei bufSize,
405 ParamType *params)
406{
407 if (context->getClientMajorVersion() < 3)
408 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500409 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400410 return false;
411 }
412
413 if (!context->isSampler(sampler))
414 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500415 context->handleError(InvalidOperation() << "Sampler is not valid.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400416 return false;
417 }
418
419 const GLsizei minBufSize = 1;
420 if (bufSize >= 0 && bufSize < minBufSize)
421 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500422 context->handleError(InvalidOperation() << "bufSize must be at least " << minBufSize);
Geoff Langc1984ed2016-10-07 12:41:00 -0400423 return false;
424 }
425
426 switch (pname)
427 {
428 case GL_TEXTURE_WRAP_S:
429 case GL_TEXTURE_WRAP_T:
430 case GL_TEXTURE_WRAP_R:
431 if (!ValidateTextureWrapModeValue(context, params, false))
432 {
433 return false;
434 }
435 break;
436
437 case GL_TEXTURE_MIN_FILTER:
438 if (!ValidateTextureMinFilterValue(context, params, false))
439 {
440 return false;
441 }
442 break;
443
444 case GL_TEXTURE_MAG_FILTER:
445 if (!ValidateTextureMagFilterValue(context, params))
446 {
447 return false;
448 }
449 break;
450
451 case GL_TEXTURE_MIN_LOD:
452 case GL_TEXTURE_MAX_LOD:
453 // any value is permissible
454 break;
455
456 case GL_TEXTURE_COMPARE_MODE:
457 if (!ValidateTextureCompareModeValue(context, params))
458 {
459 return false;
460 }
461 break;
462
463 case GL_TEXTURE_COMPARE_FUNC:
464 if (!ValidateTextureCompareFuncValue(context, params))
465 {
466 return false;
467 }
468 break;
469
Geoff Lang81c6b572016-10-19 14:07:52 -0700470 case GL_TEXTURE_SRGB_DECODE_EXT:
471 if (!ValidateTextureSRGBDecodeValue(context, params))
472 {
473 return false;
474 }
475 break;
476
Geoff Langc1984ed2016-10-07 12:41:00 -0400477 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700478 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langc1984ed2016-10-07 12:41:00 -0400479 return false;
480 }
481
482 return true;
483}
484
485bool ValidateGetSamplerParameterBase(Context *context,
486 GLuint sampler,
487 GLenum pname,
488 GLsizei *length)
489{
490 if (length)
491 {
492 *length = 0;
493 }
494
495 if (context->getClientMajorVersion() < 3)
496 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500497 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400498 return false;
499 }
500
501 if (!context->isSampler(sampler))
502 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500503 context->handleError(InvalidOperation() << "Sampler is not valid.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400504 return false;
505 }
506
507 switch (pname)
508 {
509 case GL_TEXTURE_WRAP_S:
510 case GL_TEXTURE_WRAP_T:
511 case GL_TEXTURE_WRAP_R:
512 case GL_TEXTURE_MIN_FILTER:
513 case GL_TEXTURE_MAG_FILTER:
514 case GL_TEXTURE_MIN_LOD:
515 case GL_TEXTURE_MAX_LOD:
516 case GL_TEXTURE_COMPARE_MODE:
517 case GL_TEXTURE_COMPARE_FUNC:
518 break;
519
Geoff Lang81c6b572016-10-19 14:07:52 -0700520 case GL_TEXTURE_SRGB_DECODE_EXT:
521 if (!context->getExtensions().textureSRGBDecode)
522 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500523 context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled.");
Geoff Lang81c6b572016-10-19 14:07:52 -0700524 return false;
525 }
526 break;
527
Geoff Langc1984ed2016-10-07 12:41:00 -0400528 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700529 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langc1984ed2016-10-07 12:41:00 -0400530 return false;
531 }
532
533 if (length)
534 {
535 *length = 1;
536 }
537 return true;
538}
539
Geoff Lang6899b872016-10-14 11:30:13 -0400540bool ValidateGetActiveUniformBlockivBase(Context *context,
541 GLuint program,
542 GLuint uniformBlockIndex,
543 GLenum pname,
544 GLsizei *length)
545{
546 if (length)
547 {
548 *length = 0;
549 }
550
551 if (context->getClientMajorVersion() < 3)
552 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500553 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Lang6899b872016-10-14 11:30:13 -0400554 return false;
555 }
556
557 Program *programObject = GetValidProgram(context, program);
558 if (!programObject)
559 {
560 return false;
561 }
562
563 if (uniformBlockIndex >= programObject->getActiveUniformBlockCount())
564 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500565 context->handleError(InvalidValue()
566 << "uniformBlockIndex exceeds active uniform block count.");
Geoff Lang6899b872016-10-14 11:30:13 -0400567 return false;
568 }
569
570 switch (pname)
571 {
572 case GL_UNIFORM_BLOCK_BINDING:
573 case GL_UNIFORM_BLOCK_DATA_SIZE:
574 case GL_UNIFORM_BLOCK_NAME_LENGTH:
575 case GL_UNIFORM_BLOCK_ACTIVE_UNIFORMS:
576 case GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES:
577 case GL_UNIFORM_BLOCK_REFERENCED_BY_VERTEX_SHADER:
578 case GL_UNIFORM_BLOCK_REFERENCED_BY_FRAGMENT_SHADER:
579 break;
580
581 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700582 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang6899b872016-10-14 11:30:13 -0400583 return false;
584 }
585
586 if (length)
587 {
588 if (pname == GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES)
589 {
590 const UniformBlock &uniformBlock =
591 programObject->getUniformBlockByIndex(uniformBlockIndex);
jchen10eaef1e52017-06-13 10:44:11 +0800592 *length = static_cast<GLsizei>(uniformBlock.memberIndexes.size());
Geoff Lang6899b872016-10-14 11:30:13 -0400593 }
594 else
595 {
596 *length = 1;
597 }
598 }
599
600 return true;
601}
602
Geoff Lang0a9661f2016-10-20 10:59:20 -0700603bool ValidateGetInternalFormativBase(Context *context,
604 GLenum target,
605 GLenum internalformat,
606 GLenum pname,
607 GLsizei bufSize,
608 GLsizei *numParams)
609{
610 if (numParams)
611 {
612 *numParams = 0;
613 }
614
615 if (context->getClientMajorVersion() < 3)
616 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500617 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Lang0a9661f2016-10-20 10:59:20 -0700618 return false;
619 }
620
621 const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat);
622 if (!formatCaps.renderable)
623 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500624 context->handleError(InvalidEnum() << "Internal format is not renderable.");
Geoff Lang0a9661f2016-10-20 10:59:20 -0700625 return false;
626 }
627
628 switch (target)
629 {
630 case GL_RENDERBUFFER:
631 break;
632
JiangYizhoubddc46b2016-12-09 09:50:51 +0800633 case GL_TEXTURE_2D_MULTISAMPLE:
634 if (context->getClientVersion() < ES_3_1)
635 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500636 context->handleError(InvalidOperation()
637 << "Texture target requires at least OpenGL ES 3.1.");
JiangYizhoubddc46b2016-12-09 09:50:51 +0800638 return false;
639 }
640 break;
641
Geoff Lang0a9661f2016-10-20 10:59:20 -0700642 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500643 context->handleError(InvalidEnum() << "Invalid target.");
Geoff Lang0a9661f2016-10-20 10:59:20 -0700644 return false;
645 }
646
647 if (bufSize < 0)
648 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700649 ANGLE_VALIDATION_ERR(context, InvalidValue(), InsufficientBufferSize);
Geoff Lang0a9661f2016-10-20 10:59:20 -0700650 return false;
651 }
652
653 GLsizei maxWriteParams = 0;
654 switch (pname)
655 {
656 case GL_NUM_SAMPLE_COUNTS:
657 maxWriteParams = 1;
658 break;
659
660 case GL_SAMPLES:
661 maxWriteParams = static_cast<GLsizei>(formatCaps.sampleCounts.size());
662 break;
663
664 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700665 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang0a9661f2016-10-20 10:59:20 -0700666 return false;
667 }
668
669 if (numParams)
670 {
671 // glGetInternalFormativ will not overflow bufSize
672 *numParams = std::min(bufSize, maxWriteParams);
673 }
674
675 return true;
676}
677
Jamie Madillc1d770e2017-04-13 17:31:24 -0400678bool ValidateUniformCommonBase(ValidationContext *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500679 gl::Program *program,
680 GLint location,
681 GLsizei count,
682 const LinkedUniform **uniformOut)
683{
684 // TODO(Jiajia): Add image uniform check in future.
685 if (count < 0)
686 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700687 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500688 return false;
689 }
690
Brandon Jones6cad5662017-06-14 13:25:13 -0700691 if (!program)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500692 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700693 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidProgramName);
694 return false;
695 }
696
697 if (!program->isLinked())
698 {
699 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500700 return false;
701 }
702
703 if (location == -1)
704 {
705 // Silently ignore the uniform command
706 return false;
707 }
708
709 const auto &uniformLocations = program->getUniformLocations();
Jamie Madillbe849e42017-05-02 15:49:00 -0400710 size_t castedLocation = static_cast<size_t>(location);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500711 if (castedLocation >= uniformLocations.size())
712 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500713 context->handleError(InvalidOperation() << "Invalid uniform location");
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500714 return false;
715 }
716
717 const auto &uniformLocation = uniformLocations[castedLocation];
718 if (uniformLocation.ignored)
719 {
720 // Silently ignore the uniform command
721 return false;
722 }
723
724 if (!uniformLocation.used)
725 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500726 context->handleError(InvalidOperation());
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500727 return false;
728 }
729
730 const auto &uniform = program->getUniformByIndex(uniformLocation.index);
731
732 // attempting to write an array to a non-array uniform is an INVALID_OPERATION
733 if (!uniform.isArray() && count > 1)
734 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500735 context->handleError(InvalidOperation());
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500736 return false;
737 }
738
739 *uniformOut = &uniform;
740 return true;
741}
742
Frank Henigman999b0fd2017-02-02 21:45:55 -0500743bool ValidateUniform1ivValue(ValidationContext *context,
Frank Henigmana98a6472017-02-02 21:38:32 -0500744 GLenum uniformType,
745 GLsizei count,
746 const GLint *value)
747{
748 // Value type is GL_INT, because we only get here from glUniform1i{v}.
749 // It is compatible with INT or BOOL.
750 // Do these cheap tests first, for a little extra speed.
751 if (GL_INT == uniformType || GL_BOOL == uniformType)
752 {
753 return true;
754 }
755
756 if (IsSamplerType(uniformType))
757 {
Frank Henigman999b0fd2017-02-02 21:45:55 -0500758 // Check that the values are in range.
759 const GLint max = context->getCaps().maxCombinedTextureImageUnits;
760 for (GLsizei i = 0; i < count; ++i)
761 {
762 if (value[i] < 0 || value[i] >= max)
763 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500764 context->handleError(InvalidValue() << "sampler uniform value out of range");
Frank Henigman999b0fd2017-02-02 21:45:55 -0500765 return false;
766 }
767 }
Frank Henigmana98a6472017-02-02 21:38:32 -0500768 return true;
769 }
770
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500771 context->handleError(InvalidOperation() << "wrong type of value for uniform");
Frank Henigmana98a6472017-02-02 21:38:32 -0500772 return false;
773}
774
Jamie Madillc1d770e2017-04-13 17:31:24 -0400775bool ValidateUniformValue(ValidationContext *context, GLenum valueType, GLenum uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500776{
777 // Check that the value type is compatible with uniform type.
Frank Henigmana98a6472017-02-02 21:38:32 -0500778 // Do the cheaper test first, for a little extra speed.
779 if (valueType == uniformType || VariableBoolVectorType(valueType) == uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500780 {
781 return true;
782 }
783
Brandon Jones6cad5662017-06-14 13:25:13 -0700784 ANGLE_VALIDATION_ERR(context, InvalidOperation(), UniformSizeDoesNotMatchMethod);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500785 return false;
786}
787
Jamie Madillc1d770e2017-04-13 17:31:24 -0400788bool ValidateUniformMatrixValue(ValidationContext *context, GLenum valueType, GLenum uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500789{
790 // Check that the value type is compatible with uniform type.
791 if (valueType == uniformType)
792 {
793 return true;
794 }
795
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500796 context->handleError(InvalidOperation() << "wrong type of value for uniform");
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500797 return false;
798}
799
Geoff Lange0cff192017-05-30 13:04:56 -0400800bool ValidateFragmentShaderColorBufferTypeMatch(ValidationContext *context)
801{
802 const Program *program = context->getGLState().getProgram();
803 const Framebuffer *framebuffer = context->getGLState().getDrawFramebuffer();
804
805 const auto &programOutputTypes = program->getOutputVariableTypes();
806 for (size_t drawBufferIdx = 0; drawBufferIdx < programOutputTypes.size(); drawBufferIdx++)
807 {
808 GLenum outputType = programOutputTypes[drawBufferIdx];
809 GLenum inputType = framebuffer->getDrawbufferWriteType(drawBufferIdx);
810 if (outputType != GL_NONE && inputType != GL_NONE && inputType != outputType)
811 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500812 context->handleError(InvalidOperation() << "Fragment shader output type does not "
813 "match the bound framebuffer attachment "
814 "type.");
Geoff Lange0cff192017-05-30 13:04:56 -0400815 return false;
816 }
817 }
818
819 return true;
820}
821
Geoff Lang9ab5b822017-05-30 16:19:23 -0400822bool ValidateVertexShaderAttributeTypeMatch(ValidationContext *context)
823{
824 const Program *program = context->getGLState().getProgram();
825 const VertexArray *vao = context->getGLState().getVertexArray();
826
827 for (const auto &shaderAttribute : program->getAttributes())
828 {
Geoff Lang69df2422017-07-05 12:42:31 -0400829 // gl_VertexID and gl_InstanceID are active attributes but don't have a bound attribute.
830 if (shaderAttribute.isBuiltIn())
831 {
832 continue;
833 }
834
Geoff Lang9ab5b822017-05-30 16:19:23 -0400835 GLenum shaderInputType = VariableComponentType(shaderAttribute.type);
836
837 const auto &attrib = vao->getVertexAttribute(shaderAttribute.location);
838 const auto &currentValue =
839 context->getGLState().getVertexAttribCurrentValue(shaderAttribute.location);
840 GLenum vertexType = attrib.enabled ? GetVertexAttributeBaseType(attrib) : currentValue.Type;
841
842 if (shaderInputType != GL_NONE && vertexType != GL_NONE && shaderInputType != vertexType)
843 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500844 context->handleError(InvalidOperation() << "Vertex shader input type does not "
845 "match the type of the bound vertex "
846 "attribute.");
Geoff Lang9ab5b822017-05-30 16:19:23 -0400847 return false;
848 }
849 }
850
851 return true;
852}
853
Geoff Langf41a7152016-09-19 15:11:17 -0400854} // anonymous namespace
855
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500856bool ValidTextureTarget(const ValidationContext *context, GLenum target)
Jamie Madill35d15012013-10-07 10:46:37 -0400857{
Jamie Madilld7460c72014-01-21 16:38:14 -0500858 switch (target)
Jamie Madill35d15012013-10-07 10:46:37 -0400859 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800860 case GL_TEXTURE_2D:
861 case GL_TEXTURE_CUBE_MAP:
862 return true;
Jamie Madill35d15012013-10-07 10:46:37 -0400863
He Yunchaoced53ae2016-11-29 15:00:51 +0800864 case GL_TEXTURE_3D:
865 case GL_TEXTURE_2D_ARRAY:
866 return (context->getClientMajorVersion() >= 3);
Jamie Madilld7460c72014-01-21 16:38:14 -0500867
He Yunchaoced53ae2016-11-29 15:00:51 +0800868 case GL_TEXTURE_2D_MULTISAMPLE:
He Yunchaoced53ae2016-11-29 15:00:51 +0800869 return (context->getClientVersion() >= Version(3, 1));
Geoff Lang3b573612016-10-31 14:08:10 -0400870
He Yunchaoced53ae2016-11-29 15:00:51 +0800871 default:
872 return false;
Jamie Madilld7460c72014-01-21 16:38:14 -0500873 }
Jamie Madill35d15012013-10-07 10:46:37 -0400874}
875
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500876bool ValidTexture2DTarget(const ValidationContext *context, GLenum target)
877{
878 switch (target)
879 {
880 case GL_TEXTURE_2D:
881 case GL_TEXTURE_CUBE_MAP:
882 return true;
883
884 default:
885 return false;
886 }
887}
888
889bool ValidTexture3DTarget(const ValidationContext *context, GLenum target)
890{
891 switch (target)
892 {
893 case GL_TEXTURE_3D:
894 case GL_TEXTURE_2D_ARRAY:
Martin Radev1be913c2016-07-11 17:59:16 +0300895 return (context->getClientMajorVersion() >= 3);
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500896
897 default:
898 return false;
899 }
900}
901
Ian Ewellbda75592016-04-18 17:25:54 -0400902// Most texture GL calls are not compatible with external textures, so we have a separate validation
903// function for use in the GL calls that do
904bool ValidTextureExternalTarget(const ValidationContext *context, GLenum target)
905{
906 return (target == GL_TEXTURE_EXTERNAL_OES) &&
907 (context->getExtensions().eglImageExternal ||
908 context->getExtensions().eglStreamConsumerExternal);
909}
910
Shannon Woods4dfed832014-03-17 20:03:39 -0400911// This function differs from ValidTextureTarget in that the target must be
912// usable as the destination of a 2D operation-- so a cube face is valid, but
913// GL_TEXTURE_CUBE_MAP is not.
Jamie Madill560a8d82014-05-21 13:06:20 -0400914// Note: duplicate of IsInternalTextureTarget
Jamie Madillc29968b2016-01-20 11:17:23 -0500915bool ValidTexture2DDestinationTarget(const ValidationContext *context, GLenum target)
Shannon Woods4dfed832014-03-17 20:03:39 -0400916{
917 switch (target)
918 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800919 case GL_TEXTURE_2D:
920 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
921 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
922 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
923 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
924 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
925 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
926 return true;
927 default:
928 return false;
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500929 }
930}
931
Jamie Madillbe849e42017-05-02 15:49:00 -0400932bool ValidateDrawElementsInstancedBase(ValidationContext *context,
933 GLenum mode,
934 GLsizei count,
935 GLenum type,
936 const GLvoid *indices,
937 GLsizei primcount)
938{
939 if (primcount < 0)
940 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500941 context->handleError(InvalidValue() << "primcount cannot be negative.");
Jamie Madillbe849e42017-05-02 15:49:00 -0400942 return false;
943 }
944
945 if (!ValidateDrawElementsCommon(context, mode, count, type, indices, primcount))
946 {
947 return false;
948 }
949
950 // No-op zero primitive count
951 return (primcount > 0);
952}
953
954bool ValidateDrawArraysInstancedBase(Context *context,
955 GLenum mode,
956 GLint first,
957 GLsizei count,
958 GLsizei primcount)
959{
960 if (primcount < 0)
961 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500962 context->handleError(InvalidValue() << "primcount cannot be negative.");
Jamie Madillbe849e42017-05-02 15:49:00 -0400963 return false;
964 }
965
966 if (!ValidateDrawArraysCommon(context, mode, first, count, primcount))
967 {
968 return false;
969 }
970
971 // No-op if zero primitive count
972 return (primcount > 0);
973}
974
Corentin Wallez0dc97812017-06-22 14:38:44 -0400975bool ValidateDrawInstancedANGLE(ValidationContext *context)
Jamie Madillbe849e42017-05-02 15:49:00 -0400976{
977 // Verify there is at least one active attribute with a divisor of zero
978 const State &state = context->getGLState();
979
980 Program *program = state.getProgram();
981
982 const auto &attribs = state.getVertexArray()->getVertexAttributes();
983 const auto &bindings = state.getVertexArray()->getVertexBindings();
984 for (size_t attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++)
985 {
986 const VertexAttribute &attrib = attribs[attributeIndex];
987 const VertexBinding &binding = bindings[attrib.bindingIndex];
Martin Radevdd5f27e2017-06-07 10:17:09 +0300988 if (program->isAttribLocationActive(attributeIndex) && binding.getDivisor() == 0)
Jamie Madillbe849e42017-05-02 15:49:00 -0400989 {
990 return true;
991 }
992 }
993
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500994 context->handleError(InvalidOperation()
995 << "At least one attribute must have a divisor of zero.");
Jamie Madillbe849e42017-05-02 15:49:00 -0400996 return false;
997}
998
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500999bool ValidTexture3DDestinationTarget(const ValidationContext *context, GLenum target)
1000{
1001 switch (target)
1002 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001003 case GL_TEXTURE_3D:
1004 case GL_TEXTURE_2D_ARRAY:
1005 return true;
1006 default:
1007 return false;
Shannon Woods4dfed832014-03-17 20:03:39 -04001008 }
1009}
1010
He Yunchao11b038b2016-11-22 21:24:04 +08001011bool ValidTexLevelDestinationTarget(const ValidationContext *context, GLenum target)
1012{
1013 switch (target)
1014 {
1015 case GL_TEXTURE_2D:
1016 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
1017 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
1018 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
1019 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
1020 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
1021 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
1022 case GL_TEXTURE_3D:
1023 case GL_TEXTURE_2D_ARRAY:
1024 case GL_TEXTURE_2D_MULTISAMPLE:
1025 return true;
1026 default:
1027 return false;
1028 }
1029}
1030
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001031bool ValidFramebufferTarget(GLenum target)
1032{
He Yunchaoced53ae2016-11-29 15:00:51 +08001033 static_assert(GL_DRAW_FRAMEBUFFER_ANGLE == GL_DRAW_FRAMEBUFFER &&
1034 GL_READ_FRAMEBUFFER_ANGLE == GL_READ_FRAMEBUFFER,
Geoff Langd4475812015-03-18 10:53:05 -04001035 "ANGLE framebuffer enums must equal the ES3 framebuffer enums.");
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001036
1037 switch (target)
1038 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001039 case GL_FRAMEBUFFER:
1040 return true;
1041 case GL_READ_FRAMEBUFFER:
1042 return true;
1043 case GL_DRAW_FRAMEBUFFER:
1044 return true;
1045 default:
1046 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001047 }
1048}
1049
Jamie Madill29639852016-09-02 15:00:09 -04001050bool ValidBufferTarget(const ValidationContext *context, GLenum target)
Jamie Madill8c96d582014-03-05 15:01:23 -05001051{
1052 switch (target)
1053 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001054 case GL_ARRAY_BUFFER:
1055 case GL_ELEMENT_ARRAY_BUFFER:
1056 return true;
Jamie Madill8c96d582014-03-05 15:01:23 -05001057
He Yunchaoced53ae2016-11-29 15:00:51 +08001058 case GL_PIXEL_PACK_BUFFER:
1059 case GL_PIXEL_UNPACK_BUFFER:
1060 return (context->getExtensions().pixelBufferObject ||
1061 context->getClientMajorVersion() >= 3);
Shannon Woods158c4382014-05-06 13:00:07 -04001062
He Yunchaoced53ae2016-11-29 15:00:51 +08001063 case GL_COPY_READ_BUFFER:
1064 case GL_COPY_WRITE_BUFFER:
1065 case GL_TRANSFORM_FEEDBACK_BUFFER:
1066 case GL_UNIFORM_BUFFER:
1067 return (context->getClientMajorVersion() >= 3);
Jamie Madill8c96d582014-03-05 15:01:23 -05001068
He Yunchaoced53ae2016-11-29 15:00:51 +08001069 case GL_ATOMIC_COUNTER_BUFFER:
1070 case GL_SHADER_STORAGE_BUFFER:
1071 case GL_DRAW_INDIRECT_BUFFER:
1072 case GL_DISPATCH_INDIRECT_BUFFER:
He Yunchaoced53ae2016-11-29 15:00:51 +08001073 return context->getClientVersion() >= Version(3, 1);
Geoff Lang3b573612016-10-31 14:08:10 -04001074
He Yunchaoced53ae2016-11-29 15:00:51 +08001075 default:
1076 return false;
Jamie Madill8c96d582014-03-05 15:01:23 -05001077 }
1078}
1079
Jamie Madillc29968b2016-01-20 11:17:23 -05001080bool ValidMipLevel(const ValidationContext *context, GLenum target, GLint level)
Geoff Langce635692013-09-24 13:56:32 -04001081{
Jamie Madillc29968b2016-01-20 11:17:23 -05001082 const auto &caps = context->getCaps();
Geoff Langaae65a42014-05-26 12:43:44 -04001083 size_t maxDimension = 0;
Geoff Langce635692013-09-24 13:56:32 -04001084 switch (target)
1085 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001086 case GL_TEXTURE_2D:
1087 maxDimension = caps.max2DTextureSize;
1088 break;
He Yunchaoced53ae2016-11-29 15:00:51 +08001089 case GL_TEXTURE_CUBE_MAP:
1090 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
1091 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
1092 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
1093 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
1094 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
1095 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
1096 maxDimension = caps.maxCubeMapTextureSize;
1097 break;
1098 case GL_TEXTURE_3D:
1099 maxDimension = caps.max3DTextureSize;
1100 break;
1101 case GL_TEXTURE_2D_ARRAY:
1102 maxDimension = caps.max2DTextureSize;
1103 break;
He Yunchao11b038b2016-11-22 21:24:04 +08001104 case GL_TEXTURE_2D_MULTISAMPLE:
1105 maxDimension = caps.max2DTextureSize;
1106 break;
He Yunchaoced53ae2016-11-29 15:00:51 +08001107 default:
1108 UNREACHABLE();
Geoff Langce635692013-09-24 13:56:32 -04001109 }
1110
Brandon Jones6cad5662017-06-14 13:25:13 -07001111 return level <= gl::log2(static_cast<int>(maxDimension)) && level >= 0;
Geoff Langce635692013-09-24 13:56:32 -04001112}
1113
Brandon Jones6cad5662017-06-14 13:25:13 -07001114bool ValidImageSizeParameters(ValidationContext *context,
Austin Kinross08528e12015-10-07 16:24:40 -07001115 GLenum target,
1116 GLint level,
1117 GLsizei width,
1118 GLsizei height,
1119 GLsizei depth,
1120 bool isSubImage)
Geoff Langce635692013-09-24 13:56:32 -04001121{
Brandon Jones6cad5662017-06-14 13:25:13 -07001122 if (width < 0 || height < 0 || depth < 0)
Geoff Langce635692013-09-24 13:56:32 -04001123 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001124 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Geoff Langce635692013-09-24 13:56:32 -04001125 return false;
1126 }
Austin Kinross08528e12015-10-07 16:24:40 -07001127 // TexSubImage parameters can be NPOT without textureNPOT extension,
1128 // as long as the destination texture is POT.
Geoff Langcc507aa2016-12-12 10:09:52 -05001129 bool hasNPOTSupport =
Geoff Lang5f319a42017-01-09 16:49:19 -05001130 context->getExtensions().textureNPOT || context->getClientVersion() >= Version(3, 0);
Geoff Langcc507aa2016-12-12 10:09:52 -05001131 if (!isSubImage && !hasNPOTSupport &&
Jamie Madill4fd75c12014-06-23 10:53:54 -04001132 (level != 0 && (!gl::isPow2(width) || !gl::isPow2(height) || !gl::isPow2(depth))))
Geoff Langce635692013-09-24 13:56:32 -04001133 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001134 ANGLE_VALIDATION_ERR(context, InvalidValue(), TextureNotPow2);
Geoff Langce635692013-09-24 13:56:32 -04001135 return false;
1136 }
1137
1138 if (!ValidMipLevel(context, target, level))
1139 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001140 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Geoff Langce635692013-09-24 13:56:32 -04001141 return false;
1142 }
1143
1144 return true;
1145}
1146
Geoff Lang0d8b7242015-09-09 14:56:53 -04001147bool CompressedTextureFormatRequiresExactSize(GLenum internalFormat)
1148{
1149 // List of compressed format that require that the texture size is smaller than or a multiple of
1150 // the compressed block size.
1151 switch (internalFormat)
1152 {
1153 case GL_COMPRESSED_RGB_S3TC_DXT1_EXT:
1154 case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT:
1155 case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE:
1156 case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE:
Geoff Langfff7a7d2017-06-02 10:39:17 -04001157 case GL_COMPRESSED_SRGB_S3TC_DXT1_EXT:
1158 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT:
1159 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT:
1160 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT:
Minmin Gonge3939b92015-12-01 15:36:51 -08001161 case GL_ETC1_RGB8_LOSSY_DECODE_ANGLE:
Minmin Gong390208b2017-02-28 18:03:06 -08001162 case GL_COMPRESSED_RGB8_LOSSY_DECODE_ETC2_ANGLE:
1163 case GL_COMPRESSED_SRGB8_LOSSY_DECODE_ETC2_ANGLE:
1164 case GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE:
1165 case GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE:
1166 case GL_COMPRESSED_RGBA8_LOSSY_DECODE_ETC2_EAC_ANGLE:
1167 case GL_COMPRESSED_SRGB8_ALPHA8_LOSSY_DECODE_ETC2_EAC_ANGLE:
Geoff Lang0d8b7242015-09-09 14:56:53 -04001168 return true;
1169
1170 default:
1171 return false;
1172 }
1173}
1174
Geoff Lang966c9402017-04-18 12:38:27 -04001175bool ValidCompressedDimension(GLsizei size, GLuint blockSize, bool smallerThanBlockSizeAllowed)
1176{
1177 return (smallerThanBlockSizeAllowed && (size > 0) && (blockSize % size == 0)) ||
1178 (size % blockSize == 0);
1179}
1180
Jamie Madillc29968b2016-01-20 11:17:23 -05001181bool ValidCompressedImageSize(const ValidationContext *context,
1182 GLenum internalFormat,
Geoff Lang966c9402017-04-18 12:38:27 -04001183 GLint level,
Jamie Madillc29968b2016-01-20 11:17:23 -05001184 GLsizei width,
1185 GLsizei height)
Geoff Langd4f180b2013-09-24 13:57:44 -04001186{
Geoff Langca271392017-04-05 12:30:00 -04001187 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat);
Geoff Lang5d601382014-07-22 15:14:06 -04001188 if (!formatInfo.compressed)
Geoff Langd4f180b2013-09-24 13:57:44 -04001189 {
1190 return false;
1191 }
1192
Geoff Lang966c9402017-04-18 12:38:27 -04001193 if (width < 0 || height < 0)
1194 {
1195 return false;
1196 }
1197
1198 if (CompressedTextureFormatRequiresExactSize(internalFormat))
1199 {
1200 // The ANGLE extensions allow specifying compressed textures with sizes smaller than the
1201 // block size for level 0 but WebGL disallows this.
1202 bool smallerThanBlockSizeAllowed =
1203 level > 0 || !context->getExtensions().webglCompatibility;
1204
1205 if (!ValidCompressedDimension(width, formatInfo.compressedBlockWidth,
1206 smallerThanBlockSizeAllowed) ||
1207 !ValidCompressedDimension(height, formatInfo.compressedBlockHeight,
1208 smallerThanBlockSizeAllowed))
1209 {
1210 return false;
1211 }
1212 }
1213
1214 return true;
1215}
1216
1217bool ValidCompressedSubImageSize(const ValidationContext *context,
1218 GLenum internalFormat,
1219 GLint xoffset,
1220 GLint yoffset,
1221 GLsizei width,
1222 GLsizei height,
1223 size_t textureWidth,
1224 size_t textureHeight)
1225{
1226 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat);
1227 if (!formatInfo.compressed)
1228 {
1229 return false;
1230 }
1231
Geoff Lang44ff5a72017-02-03 15:15:43 -05001232 if (xoffset < 0 || yoffset < 0 || width < 0 || height < 0)
Geoff Langd4f180b2013-09-24 13:57:44 -04001233 {
1234 return false;
1235 }
1236
Geoff Lang0d8b7242015-09-09 14:56:53 -04001237 if (CompressedTextureFormatRequiresExactSize(internalFormat))
1238 {
Geoff Lang44ff5a72017-02-03 15:15:43 -05001239 if (xoffset % formatInfo.compressedBlockWidth != 0 ||
Geoff Lang966c9402017-04-18 12:38:27 -04001240 yoffset % formatInfo.compressedBlockHeight != 0)
1241 {
1242 return false;
1243 }
1244
1245 // Allowed to either have data that is a multiple of block size or is smaller than the block
1246 // size but fills the entire mip
1247 bool fillsEntireMip = xoffset == 0 && yoffset == 0 &&
1248 static_cast<size_t>(width) == textureWidth &&
1249 static_cast<size_t>(height) == textureHeight;
1250 bool sizeMultipleOfBlockSize = (width % formatInfo.compressedBlockWidth) == 0 &&
1251 (height % formatInfo.compressedBlockHeight) == 0;
1252 if (!sizeMultipleOfBlockSize && !fillsEntireMip)
Geoff Lang0d8b7242015-09-09 14:56:53 -04001253 {
1254 return false;
1255 }
1256 }
1257
Geoff Langd4f180b2013-09-24 13:57:44 -04001258 return true;
1259}
1260
Geoff Langff5b2d52016-09-07 11:32:23 -04001261bool ValidImageDataSize(ValidationContext *context,
1262 GLenum textureTarget,
1263 GLsizei width,
1264 GLsizei height,
1265 GLsizei depth,
Geoff Langdbcced82017-06-06 15:55:54 -04001266 GLenum format,
Geoff Langff5b2d52016-09-07 11:32:23 -04001267 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04001268 const void *pixels,
Geoff Langff5b2d52016-09-07 11:32:23 -04001269 GLsizei imageSize)
1270{
1271 gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
1272 if (pixelUnpackBuffer == nullptr && imageSize < 0)
1273 {
1274 // Checks are not required
1275 return true;
1276 }
1277
1278 // ...the data would be unpacked from the buffer object such that the memory reads required
1279 // would exceed the data store size.
Geoff Langdbcced82017-06-06 15:55:54 -04001280 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(format, type);
1281 ASSERT(formatInfo.internalFormat != GL_NONE);
Geoff Langff5b2d52016-09-07 11:32:23 -04001282 const gl::Extents size(width, height, depth);
1283 const auto &unpack = context->getGLState().getUnpackState();
1284
1285 bool targetIs3D = textureTarget == GL_TEXTURE_3D || textureTarget == GL_TEXTURE_2D_ARRAY;
1286 auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, unpack, targetIs3D);
1287 if (endByteOrErr.isError())
1288 {
1289 context->handleError(endByteOrErr.getError());
1290 return false;
1291 }
1292
1293 GLuint endByte = endByteOrErr.getResult();
1294
1295 if (pixelUnpackBuffer)
1296 {
1297 CheckedNumeric<size_t> checkedEndByte(endByteOrErr.getResult());
1298 CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels));
1299 checkedEndByte += checkedOffset;
1300
1301 if (!checkedEndByte.IsValid() ||
1302 (checkedEndByte.ValueOrDie() > static_cast<size_t>(pixelUnpackBuffer->getSize())))
1303 {
1304 // Overflow past the end of the buffer
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001305 context->handleError(InvalidOperation());
Geoff Langff5b2d52016-09-07 11:32:23 -04001306 return false;
1307 }
1308 }
1309 else
1310 {
1311 ASSERT(imageSize >= 0);
1312 if (pixels == nullptr && imageSize != 0)
1313 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001314 context->handleError(InvalidOperation()
1315 << "imageSize must be 0 if no texture data is provided.");
Geoff Lang3feb3ff2016-10-26 10:57:45 -04001316 return false;
Geoff Langff5b2d52016-09-07 11:32:23 -04001317 }
1318
Geoff Lang3feb3ff2016-10-26 10:57:45 -04001319 if (pixels != nullptr && endByte > static_cast<GLuint>(imageSize))
Geoff Langff5b2d52016-09-07 11:32:23 -04001320 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001321 context->handleError(InvalidOperation() << "imageSize must be at least " << endByte);
Geoff Langff5b2d52016-09-07 11:32:23 -04001322 return false;
1323 }
1324 }
1325
1326 return true;
1327}
1328
Geoff Lang37dde692014-01-31 16:34:54 -05001329bool ValidQueryType(const Context *context, GLenum queryType)
1330{
He Yunchaoced53ae2016-11-29 15:00:51 +08001331 static_assert(GL_ANY_SAMPLES_PASSED == GL_ANY_SAMPLES_PASSED_EXT,
1332 "GL extension enums not equal.");
1333 static_assert(GL_ANY_SAMPLES_PASSED_CONSERVATIVE == GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
1334 "GL extension enums not equal.");
Geoff Lang37dde692014-01-31 16:34:54 -05001335
1336 switch (queryType)
1337 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001338 case GL_ANY_SAMPLES_PASSED:
1339 case GL_ANY_SAMPLES_PASSED_CONSERVATIVE:
1340 return true;
1341 case GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN:
1342 return (context->getClientMajorVersion() >= 3);
1343 case GL_TIME_ELAPSED_EXT:
1344 return context->getExtensions().disjointTimerQuery;
1345 case GL_COMMANDS_COMPLETED_CHROMIUM:
1346 return context->getExtensions().syncQuery;
1347 default:
1348 return false;
Geoff Lang37dde692014-01-31 16:34:54 -05001349 }
1350}
1351
Geoff Lang2d62ab72017-03-23 16:54:40 -04001352bool ValidateWebGLVertexAttribPointer(ValidationContext *context,
1353 GLenum type,
1354 GLboolean normalized,
1355 GLsizei stride,
Jamie Madill876429b2017-04-20 15:46:24 -04001356 const void *ptr,
Geoff Lang2d62ab72017-03-23 16:54:40 -04001357 bool pureInteger)
1358{
1359 ASSERT(context->getExtensions().webglCompatibility);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001360 // WebGL 1.0 [Section 6.11] Vertex Attribute Data Stride
1361 // The WebGL API supports vertex attribute data strides up to 255 bytes. A call to
1362 // vertexAttribPointer will generate an INVALID_VALUE error if the value for the stride
1363 // parameter exceeds 255.
1364 constexpr GLsizei kMaxWebGLStride = 255;
1365 if (stride > kMaxWebGLStride)
1366 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001367 context->handleError(InvalidValue()
1368 << "Stride is over the maximum stride allowed by WebGL.");
Geoff Lang2d62ab72017-03-23 16:54:40 -04001369 return false;
1370 }
1371
1372 // WebGL 1.0 [Section 6.4] Buffer Offset and Stride Requirements
1373 // The offset arguments to drawElements and vertexAttribPointer, and the stride argument to
1374 // vertexAttribPointer, must be a multiple of the size of the data type passed to the call,
1375 // or an INVALID_OPERATION error is generated.
1376 VertexFormatType internalType = GetVertexFormatType(type, normalized, 1, pureInteger);
1377 size_t typeSize = GetVertexFormatTypeSize(internalType);
1378
1379 ASSERT(isPow2(typeSize) && typeSize > 0);
1380 size_t sizeMask = (typeSize - 1);
1381 if ((reinterpret_cast<intptr_t>(ptr) & sizeMask) != 0)
1382 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001383 ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001384 return false;
1385 }
1386
1387 if ((stride & sizeMask) != 0)
1388 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001389 ANGLE_VALIDATION_ERR(context, InvalidOperation(), StrideMustBeMultipleOfType);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001390 return false;
1391 }
1392
1393 return true;
1394}
1395
Jamie Madillef300b12016-10-07 15:12:09 -04001396Program *GetValidProgram(ValidationContext *context, GLuint id)
Geoff Lang48dcae72014-02-05 16:28:24 -05001397{
He Yunchaoced53ae2016-11-29 15:00:51 +08001398 // ES3 spec (section 2.11.1) -- "Commands that accept shader or program object names will
1399 // generate the error INVALID_VALUE if the provided name is not the name of either a shader
1400 // or program object and INVALID_OPERATION if the provided name identifies an object
1401 // that is not the expected type."
Geoff Lang48dcae72014-02-05 16:28:24 -05001402
Dian Xiang769769a2015-09-09 15:20:08 -07001403 Program *validProgram = context->getProgram(id);
1404
1405 if (!validProgram)
Geoff Lang48dcae72014-02-05 16:28:24 -05001406 {
Dian Xiang769769a2015-09-09 15:20:08 -07001407 if (context->getShader(id))
1408 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001409 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedProgramName);
Dian Xiang769769a2015-09-09 15:20:08 -07001410 }
1411 else
1412 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001413 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidProgramName);
Dian Xiang769769a2015-09-09 15:20:08 -07001414 }
Geoff Lang48dcae72014-02-05 16:28:24 -05001415 }
Dian Xiang769769a2015-09-09 15:20:08 -07001416
1417 return validProgram;
1418}
1419
Jamie Madillef300b12016-10-07 15:12:09 -04001420Shader *GetValidShader(ValidationContext *context, GLuint id)
Dian Xiang769769a2015-09-09 15:20:08 -07001421{
1422 // See ValidProgram for spec details.
1423
1424 Shader *validShader = context->getShader(id);
1425
1426 if (!validShader)
Geoff Lang48dcae72014-02-05 16:28:24 -05001427 {
Dian Xiang769769a2015-09-09 15:20:08 -07001428 if (context->getProgram(id))
1429 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001430 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedShaderName);
Dian Xiang769769a2015-09-09 15:20:08 -07001431 }
1432 else
1433 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001434 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidShaderName);
Dian Xiang769769a2015-09-09 15:20:08 -07001435 }
Geoff Lang48dcae72014-02-05 16:28:24 -05001436 }
Dian Xiang769769a2015-09-09 15:20:08 -07001437
1438 return validShader;
Geoff Lang48dcae72014-02-05 16:28:24 -05001439}
1440
Geoff Langb1196682014-07-23 13:47:29 -04001441bool ValidateAttachmentTarget(gl::Context *context, GLenum attachment)
Jamie Madillb4472272014-07-03 10:38:55 -04001442{
1443 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
1444 {
1445 const unsigned int colorAttachment = (attachment - GL_COLOR_ATTACHMENT0_EXT);
1446
Geoff Langaae65a42014-05-26 12:43:44 -04001447 if (colorAttachment >= context->getCaps().maxColorAttachments)
Jamie Madillb4472272014-07-03 10:38:55 -04001448 {
Martin Radevd178aa42017-07-13 14:03:22 +03001449 context->handleError(
1450 InvalidOperation()
1451 << "attachment index cannot be greater or equal to MAX_COLOR_ATTACHMENTS.");
Geoff Langb1196682014-07-23 13:47:29 -04001452 return false;
Jamie Madillb4472272014-07-03 10:38:55 -04001453 }
1454 }
1455 else
1456 {
1457 switch (attachment)
1458 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001459 case GL_DEPTH_ATTACHMENT:
1460 case GL_STENCIL_ATTACHMENT:
1461 break;
Jamie Madillb4472272014-07-03 10:38:55 -04001462
He Yunchaoced53ae2016-11-29 15:00:51 +08001463 case GL_DEPTH_STENCIL_ATTACHMENT:
1464 if (!context->getExtensions().webglCompatibility &&
1465 context->getClientMajorVersion() < 3)
1466 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001467 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
He Yunchaoced53ae2016-11-29 15:00:51 +08001468 return false;
1469 }
1470 break;
Jamie Madillb4472272014-07-03 10:38:55 -04001471
He Yunchaoced53ae2016-11-29 15:00:51 +08001472 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001473 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
He Yunchaoced53ae2016-11-29 15:00:51 +08001474 return false;
Jamie Madillb4472272014-07-03 10:38:55 -04001475 }
1476 }
1477
1478 return true;
1479}
1480
Jamie Madille8fb6402017-02-14 17:56:40 -05001481bool ValidateRenderbufferStorageParametersBase(ValidationContext *context,
He Yunchaoced53ae2016-11-29 15:00:51 +08001482 GLenum target,
1483 GLsizei samples,
1484 GLenum internalformat,
1485 GLsizei width,
1486 GLsizei height)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001487{
1488 switch (target)
1489 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001490 case GL_RENDERBUFFER:
1491 break;
1492 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001493 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
He Yunchaoced53ae2016-11-29 15:00:51 +08001494 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001495 }
1496
1497 if (width < 0 || height < 0 || samples < 0)
1498 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001499 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidRenderbufferWidthHeight);
Geoff Langb1196682014-07-23 13:47:29 -04001500 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001501 }
1502
Jamie Madill4e0e6f82017-02-17 11:06:03 -05001503 // Hack for the special WebGL 1 "DEPTH_STENCIL" internal format.
1504 GLenum convertedInternalFormat = context->getConvertedRenderbufferFormat(internalformat);
1505
1506 const TextureCaps &formatCaps = context->getTextureCaps().get(convertedInternalFormat);
Geoff Langd87878e2014-09-19 15:42:59 -04001507 if (!formatCaps.renderable)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001508 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001509 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04001510 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001511 }
1512
1513 // ANGLE_framebuffer_multisample does not explicitly state that the internal format must be
1514 // sized but it does state that the format must be in the ES2.0 spec table 4.5 which contains
Corentin Walleze0902642014-11-04 12:32:15 -08001515 // only sized internal formats.
Geoff Langca271392017-04-05 12:30:00 -04001516 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(convertedInternalFormat);
1517 if (formatInfo.internalFormat == GL_NONE)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001518 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001519 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferInternalFormat);
Geoff Langb1196682014-07-23 13:47:29 -04001520 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001521 }
1522
Geoff Langaae65a42014-05-26 12:43:44 -04001523 if (static_cast<GLuint>(std::max(width, height)) > context->getCaps().maxRenderbufferSize)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001524 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001525 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04001526 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001527 }
1528
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001529 GLuint handle = context->getGLState().getRenderbufferId();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001530 if (handle == 0)
1531 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001532 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001533 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001534 }
1535
1536 return true;
1537}
1538
He Yunchaoced53ae2016-11-29 15:00:51 +08001539bool ValidateFramebufferRenderbufferParameters(gl::Context *context,
1540 GLenum target,
1541 GLenum attachment,
1542 GLenum renderbuffertarget,
1543 GLuint renderbuffer)
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001544{
Shannon Woods1da3cf62014-06-27 15:32:23 -04001545 if (!ValidFramebufferTarget(target))
1546 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001547 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04001548 return false;
Shannon Woods1da3cf62014-06-27 15:32:23 -04001549 }
1550
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001551 gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001552
Jamie Madill84115c92015-04-23 15:00:07 -04001553 ASSERT(framebuffer);
1554 if (framebuffer->id() == 0)
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001555 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001556 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001557 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001558 }
1559
Jamie Madillb4472272014-07-03 10:38:55 -04001560 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001561 {
Jamie Madillb4472272014-07-03 10:38:55 -04001562 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001563 }
1564
Jamie Madillab9d82c2014-01-21 16:38:14 -05001565 // [OpenGL ES 2.0.25] Section 4.4.3 page 112
1566 // [OpenGL ES 3.0.2] Section 4.4.2 page 201
1567 // 'renderbuffer' must be either zero or the name of an existing renderbuffer object of
1568 // type 'renderbuffertarget', otherwise an INVALID_OPERATION error is generated.
1569 if (renderbuffer != 0)
1570 {
1571 if (!context->getRenderbuffer(renderbuffer))
1572 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001573 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001574 return false;
Jamie Madillab9d82c2014-01-21 16:38:14 -05001575 }
1576 }
1577
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001578 return true;
1579}
1580
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001581bool ValidateBlitFramebufferParameters(ValidationContext *context,
Jamie Madillc29968b2016-01-20 11:17:23 -05001582 GLint srcX0,
1583 GLint srcY0,
1584 GLint srcX1,
1585 GLint srcY1,
1586 GLint dstX0,
1587 GLint dstY0,
1588 GLint dstX1,
1589 GLint dstY1,
1590 GLbitfield mask,
1591 GLenum filter)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001592{
1593 switch (filter)
1594 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001595 case GL_NEAREST:
1596 break;
1597 case GL_LINEAR:
1598 break;
1599 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001600 context->handleError(InvalidEnum());
He Yunchaoced53ae2016-11-29 15:00:51 +08001601 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001602 }
1603
1604 if ((mask & ~(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT | GL_DEPTH_BUFFER_BIT)) != 0)
1605 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001606 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04001607 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001608 }
1609
1610 if (mask == 0)
1611 {
1612 // ES3.0 spec, section 4.3.2 specifies that a mask of zero is valid and no
1613 // buffers are copied.
1614 return false;
1615 }
1616
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001617 // ES3.0 spec, section 4.3.2 states that linear filtering is only available for the
1618 // color buffer, leaving only nearest being unfiltered from above
1619 if ((mask & ~GL_COLOR_BUFFER_BIT) != 0 && filter != GL_NEAREST)
1620 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001621 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001622 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001623 }
1624
Jamie Madill51f40ec2016-06-15 14:06:00 -04001625 const auto &glState = context->getGLState();
1626 gl::Framebuffer *readFramebuffer = glState.getReadFramebuffer();
1627 gl::Framebuffer *drawFramebuffer = glState.getDrawFramebuffer();
Jamie Madill48faf802014-11-06 15:27:22 -05001628
1629 if (!readFramebuffer || !drawFramebuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001630 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001631 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001632 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001633 }
1634
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001635 if (readFramebuffer->id() == drawFramebuffer->id())
1636 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001637 context->handleError(InvalidOperation());
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001638 return false;
1639 }
1640
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001641 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill48faf802014-11-06 15:27:22 -05001642 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001643 context->handleError(InvalidFramebufferOperation());
Jamie Madill48faf802014-11-06 15:27:22 -05001644 return false;
1645 }
1646
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001647 if (drawFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill48faf802014-11-06 15:27:22 -05001648 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001649 context->handleError(InvalidFramebufferOperation());
Jamie Madill48faf802014-11-06 15:27:22 -05001650 return false;
1651 }
1652
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001653 if (drawFramebuffer->getSamples(context) != 0)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001654 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001655 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001656 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001657 }
1658
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001659 bool sameBounds = srcX0 == dstX0 && srcY0 == dstY0 && srcX1 == dstX1 && srcY1 == dstY1;
1660
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001661 if (mask & GL_COLOR_BUFFER_BIT)
1662 {
Jamie Madillb6bda4a2015-04-20 12:53:26 -04001663 const gl::FramebufferAttachment *readColorBuffer = readFramebuffer->getReadColorbuffer();
Jamie Madill6163c752015-12-07 16:32:59 -05001664 const Extensions &extensions = context->getExtensions();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001665
He Yunchao66a41a22016-12-15 16:45:05 +08001666 if (readColorBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001667 {
Jamie Madilla3944d42016-07-22 22:13:26 -04001668 const Format &readFormat = readColorBuffer->getFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001669
Geoff Langa15472a2015-08-11 11:48:03 -04001670 for (size_t drawbufferIdx = 0;
1671 drawbufferIdx < drawFramebuffer->getDrawbufferStateCount(); ++drawbufferIdx)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001672 {
Geoff Langa15472a2015-08-11 11:48:03 -04001673 const FramebufferAttachment *attachment =
1674 drawFramebuffer->getDrawBuffer(drawbufferIdx);
1675 if (attachment)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001676 {
Jamie Madilla3944d42016-07-22 22:13:26 -04001677 const Format &drawFormat = attachment->getFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001678
Geoff Langb2f3d052013-08-13 12:49:27 -04001679 // The GL ES 3.0.2 spec (pg 193) states that:
1680 // 1) If the read buffer is fixed point format, the draw buffer must be as well
He Yunchaoced53ae2016-11-29 15:00:51 +08001681 // 2) If the read buffer is an unsigned integer format, the draw buffer must be
1682 // as well
1683 // 3) If the read buffer is a signed integer format, the draw buffer must be as
1684 // well
Jamie Madill6163c752015-12-07 16:32:59 -05001685 // Changes with EXT_color_buffer_float:
1686 // Case 1) is changed to fixed point OR floating point
Jamie Madilla3944d42016-07-22 22:13:26 -04001687 GLenum readComponentType = readFormat.info->componentType;
1688 GLenum drawComponentType = drawFormat.info->componentType;
He Yunchaoced53ae2016-11-29 15:00:51 +08001689 bool readFixedPoint = (readComponentType == GL_UNSIGNED_NORMALIZED ||
Jamie Madill6163c752015-12-07 16:32:59 -05001690 readComponentType == GL_SIGNED_NORMALIZED);
1691 bool drawFixedPoint = (drawComponentType == GL_UNSIGNED_NORMALIZED ||
1692 drawComponentType == GL_SIGNED_NORMALIZED);
1693
1694 if (extensions.colorBufferFloat)
1695 {
1696 bool readFixedOrFloat = (readFixedPoint || readComponentType == GL_FLOAT);
1697 bool drawFixedOrFloat = (drawFixedPoint || drawComponentType == GL_FLOAT);
1698
1699 if (readFixedOrFloat != drawFixedOrFloat)
1700 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001701 context->handleError(InvalidOperation()
1702 << "If the read buffer contains fixed-point or "
1703 "floating-point values, the draw buffer must "
1704 "as well.");
Jamie Madill6163c752015-12-07 16:32:59 -05001705 return false;
1706 }
1707 }
1708 else if (readFixedPoint != drawFixedPoint)
1709 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001710 context->handleError(InvalidOperation()
1711 << "If the read buffer contains fixed-point values, "
1712 "the draw buffer must as well.");
Jamie Madill6163c752015-12-07 16:32:59 -05001713 return false;
1714 }
1715
1716 if (readComponentType == GL_UNSIGNED_INT &&
1717 drawComponentType != GL_UNSIGNED_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001718 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001719 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001720 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001721 }
1722
Jamie Madill6163c752015-12-07 16:32:59 -05001723 if (readComponentType == GL_INT && drawComponentType != GL_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001724 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001725 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001726 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001727 }
1728
Jamie Madilla3944d42016-07-22 22:13:26 -04001729 if (readColorBuffer->getSamples() > 0 &&
Corentin Wallez26cf35a2017-07-26 11:01:02 +00001730 (!Format::SameSized(readFormat, drawFormat) || !sameBounds))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001731 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001732 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001733 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001734 }
Geoff Lange4915782017-04-12 15:19:07 -04001735
1736 if (context->getExtensions().webglCompatibility &&
1737 *readColorBuffer == *attachment)
1738 {
1739 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001740 InvalidOperation()
1741 << "Read and write color attachments cannot be the same image.");
Geoff Lange4915782017-04-12 15:19:07 -04001742 return false;
1743 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001744 }
1745 }
1746
Jamie Madilla3944d42016-07-22 22:13:26 -04001747 if ((readFormat.info->componentType == GL_INT ||
1748 readFormat.info->componentType == GL_UNSIGNED_INT) &&
1749 filter == GL_LINEAR)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001750 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001751 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001752 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001753 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001754 }
He Yunchao66a41a22016-12-15 16:45:05 +08001755 // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment
1756 // In OpenGL ES it is undefined what happens when an operation tries to blit from a missing
1757 // attachment and WebGL defines it to be an error. We do the check unconditionally as the
1758 // situation is an application error that would lead to a crash in ANGLE.
1759 else if (drawFramebuffer->hasEnabledDrawBuffer())
1760 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001761 context->handleError(
1762 InvalidOperation()
1763 << "Attempt to read from a missing color attachment of a complete framebuffer.");
He Yunchao66a41a22016-12-15 16:45:05 +08001764 return false;
1765 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001766 }
1767
He Yunchaoced53ae2016-11-29 15:00:51 +08001768 GLenum masks[] = {GL_DEPTH_BUFFER_BIT, GL_STENCIL_BUFFER_BIT};
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001769 GLenum attachments[] = {GL_DEPTH_ATTACHMENT, GL_STENCIL_ATTACHMENT};
1770 for (size_t i = 0; i < 2; i++)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001771 {
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001772 if (mask & masks[i])
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001773 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001774 const gl::FramebufferAttachment *readBuffer =
1775 readFramebuffer->getAttachment(attachments[i]);
1776 const gl::FramebufferAttachment *drawBuffer =
1777 drawFramebuffer->getAttachment(attachments[i]);
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001778
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001779 if (readBuffer && drawBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001780 {
Corentin Wallez26cf35a2017-07-26 11:01:02 +00001781 if (!Format::SameSized(readBuffer->getFormat(), drawBuffer->getFormat()))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001782 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001783 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001784 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001785 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001786
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001787 if (readBuffer->getSamples() > 0 && !sameBounds)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001788 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001789 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001790 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001791 }
Geoff Lange4915782017-04-12 15:19:07 -04001792
1793 if (context->getExtensions().webglCompatibility && *readBuffer == *drawBuffer)
1794 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001795 context->handleError(
1796 InvalidOperation()
1797 << "Read and write depth stencil attachments cannot be the same image.");
Geoff Lange4915782017-04-12 15:19:07 -04001798 return false;
1799 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001800 }
He Yunchao66a41a22016-12-15 16:45:05 +08001801 // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment
1802 else if (drawBuffer)
1803 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001804 context->handleError(InvalidOperation() << "Attempt to read from a missing "
1805 "depth/stencil attachment of a "
1806 "complete framebuffer.");
He Yunchao66a41a22016-12-15 16:45:05 +08001807 return false;
1808 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001809 }
1810 }
1811
1812 return true;
1813}
1814
Jamie Madill4928b7c2017-06-20 12:57:39 -04001815bool ValidateReadPixelsRobustANGLE(Context *context,
Geoff Lang62fce5b2016-09-30 10:46:35 -04001816 GLint x,
1817 GLint y,
1818 GLsizei width,
1819 GLsizei height,
1820 GLenum format,
1821 GLenum type,
1822 GLsizei bufSize,
1823 GLsizei *length,
Geoff Lange93daba2017-03-30 13:54:40 -04001824 GLsizei *columns,
1825 GLsizei *rows,
Jamie Madill876429b2017-04-20 15:46:24 -04001826 void *pixels)
Geoff Lang62fce5b2016-09-30 10:46:35 -04001827{
1828 if (!ValidateRobustEntryPoint(context, bufSize))
Jamie Madillc29968b2016-01-20 11:17:23 -05001829 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001830 return false;
1831 }
1832
Geoff Lang62fce5b2016-09-30 10:46:35 -04001833 if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length,
Geoff Lange93daba2017-03-30 13:54:40 -04001834 columns, rows, pixels))
Jamie Madill26e91952014-03-05 15:01:27 -05001835 {
Geoff Langb1196682014-07-23 13:47:29 -04001836 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001837 }
1838
Geoff Lang62fce5b2016-09-30 10:46:35 -04001839 if (!ValidateRobustBufferSize(context, bufSize, *length))
Jamie Madill26e91952014-03-05 15:01:27 -05001840 {
Geoff Langb1196682014-07-23 13:47:29 -04001841 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001842 }
1843
Jamie Madillc29968b2016-01-20 11:17:23 -05001844 return true;
1845}
1846
1847bool ValidateReadnPixelsEXT(Context *context,
1848 GLint x,
1849 GLint y,
1850 GLsizei width,
1851 GLsizei height,
1852 GLenum format,
1853 GLenum type,
1854 GLsizei bufSize,
Jamie Madill876429b2017-04-20 15:46:24 -04001855 void *pixels)
Jamie Madillc29968b2016-01-20 11:17:23 -05001856{
1857 if (bufSize < 0)
1858 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001859 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Jamie Madillc29968b2016-01-20 11:17:23 -05001860 return false;
1861 }
1862
Geoff Lang62fce5b2016-09-30 10:46:35 -04001863 return ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, nullptr,
Geoff Lange93daba2017-03-30 13:54:40 -04001864 nullptr, nullptr, pixels);
Geoff Lang62fce5b2016-09-30 10:46:35 -04001865}
Jamie Madill26e91952014-03-05 15:01:27 -05001866
Jamie Madill4928b7c2017-06-20 12:57:39 -04001867bool ValidateReadnPixelsRobustANGLE(Context *context,
Geoff Lang62fce5b2016-09-30 10:46:35 -04001868 GLint x,
1869 GLint y,
1870 GLsizei width,
1871 GLsizei height,
1872 GLenum format,
1873 GLenum type,
1874 GLsizei bufSize,
1875 GLsizei *length,
Geoff Lange93daba2017-03-30 13:54:40 -04001876 GLsizei *columns,
1877 GLsizei *rows,
Jamie Madill876429b2017-04-20 15:46:24 -04001878 void *data)
Geoff Lang62fce5b2016-09-30 10:46:35 -04001879{
1880 if (!ValidateRobustEntryPoint(context, bufSize))
Jamie Madille2e406c2016-06-02 13:04:10 -04001881 {
Jamie Madille2e406c2016-06-02 13:04:10 -04001882 return false;
1883 }
1884
Geoff Lange93daba2017-03-30 13:54:40 -04001885 if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length,
1886 columns, rows, data))
Jamie Madille2e406c2016-06-02 13:04:10 -04001887 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001888 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001889 }
1890
Geoff Lang62fce5b2016-09-30 10:46:35 -04001891 if (!ValidateRobustBufferSize(context, bufSize, *length))
1892 {
1893 return false;
1894 }
1895
1896 return true;
Jamie Madill26e91952014-03-05 15:01:27 -05001897}
1898
Olli Etuaho41997e72016-03-10 13:38:39 +02001899bool ValidateGenQueriesEXT(gl::Context *context, GLsizei n)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001900{
1901 if (!context->getExtensions().occlusionQueryBoolean &&
1902 !context->getExtensions().disjointTimerQuery)
1903 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001904 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001905 return false;
1906 }
1907
Olli Etuaho41997e72016-03-10 13:38:39 +02001908 return ValidateGenOrDelete(context, n);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001909}
1910
Olli Etuaho41997e72016-03-10 13:38:39 +02001911bool ValidateDeleteQueriesEXT(gl::Context *context, GLsizei n)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001912{
1913 if (!context->getExtensions().occlusionQueryBoolean &&
1914 !context->getExtensions().disjointTimerQuery)
1915 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001916 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001917 return false;
1918 }
1919
Olli Etuaho41997e72016-03-10 13:38:39 +02001920 return ValidateGenOrDelete(context, n);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001921}
1922
1923bool ValidateBeginQueryBase(gl::Context *context, GLenum target, GLuint id)
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001924{
1925 if (!ValidQueryType(context, target))
1926 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001927 context->handleError(InvalidEnum() << "Invalid query target");
Geoff Langb1196682014-07-23 13:47:29 -04001928 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001929 }
1930
1931 if (id == 0)
1932 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001933 context->handleError(InvalidOperation() << "Query id is 0");
Geoff Langb1196682014-07-23 13:47:29 -04001934 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001935 }
1936
1937 // From EXT_occlusion_query_boolean: If BeginQueryEXT is called with an <id>
1938 // of zero, if the active query object name for <target> is non-zero (for the
1939 // targets ANY_SAMPLES_PASSED_EXT and ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, if
1940 // the active query for either target is non-zero), if <id> is the name of an
1941 // existing query object whose type does not match <target>, or if <id> is the
1942 // active query object name for any query type, the error INVALID_OPERATION is
1943 // generated.
1944
1945 // Ensure no other queries are active
1946 // NOTE: If other queries than occlusion are supported, we will need to check
1947 // separately that:
1948 // a) The query ID passed is not the current active query for any target/type
1949 // b) There are no active queries for the requested target (and in the case
1950 // of GL_ANY_SAMPLES_PASSED_EXT and GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
1951 // no query may be active for either if glBeginQuery targets either.
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001952
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001953 if (context->getGLState().isQueryActive(target))
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001954 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001955 context->handleError(InvalidOperation() << "Other query is active");
Geoff Langb1196682014-07-23 13:47:29 -04001956 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001957 }
1958
1959 Query *queryObject = context->getQuery(id, true, target);
1960
1961 // check that name was obtained with glGenQueries
1962 if (!queryObject)
1963 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001964 context->handleError(InvalidOperation() << "Invalid query id");
Geoff Langb1196682014-07-23 13:47:29 -04001965 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001966 }
1967
1968 // check for type mismatch
1969 if (queryObject->getType() != target)
1970 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001971 context->handleError(InvalidOperation() << "Query type does not match target");
Geoff Langb1196682014-07-23 13:47:29 -04001972 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001973 }
1974
1975 return true;
1976}
1977
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001978bool ValidateBeginQueryEXT(gl::Context *context, GLenum target, GLuint id)
1979{
1980 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001981 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001982 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001983 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001984 return false;
1985 }
1986
1987 return ValidateBeginQueryBase(context, target, id);
1988}
1989
1990bool ValidateEndQueryBase(gl::Context *context, GLenum target)
Jamie Madill45c785d2014-05-13 14:09:34 -04001991{
1992 if (!ValidQueryType(context, target))
1993 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001994 context->handleError(InvalidEnum() << "Invalid query target");
Geoff Langb1196682014-07-23 13:47:29 -04001995 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04001996 }
1997
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001998 const Query *queryObject = context->getGLState().getActiveQuery(target);
Jamie Madill45c785d2014-05-13 14:09:34 -04001999
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002000 if (queryObject == nullptr)
Jamie Madill45c785d2014-05-13 14:09:34 -04002001 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002002 context->handleError(InvalidOperation() << "Query target not active");
Geoff Langb1196682014-07-23 13:47:29 -04002003 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04002004 }
2005
Jamie Madill45c785d2014-05-13 14:09:34 -04002006 return true;
2007}
2008
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002009bool ValidateEndQueryEXT(gl::Context *context, GLenum target)
2010{
2011 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04002012 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002013 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002014 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002015 return false;
2016 }
2017
2018 return ValidateEndQueryBase(context, target);
2019}
2020
2021bool ValidateQueryCounterEXT(Context *context, GLuint id, GLenum target)
2022{
2023 if (!context->getExtensions().disjointTimerQuery)
2024 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002025 context->handleError(InvalidOperation() << "Disjoint timer query not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002026 return false;
2027 }
2028
2029 if (target != GL_TIMESTAMP_EXT)
2030 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002031 context->handleError(InvalidEnum() << "Invalid query target");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002032 return false;
2033 }
2034
2035 Query *queryObject = context->getQuery(id, true, target);
2036 if (queryObject == nullptr)
2037 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002038 context->handleError(InvalidOperation() << "Invalid query id");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002039 return false;
2040 }
2041
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002042 if (context->getGLState().isQueryActive(queryObject))
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002043 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002044 context->handleError(InvalidOperation() << "Query is active");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002045 return false;
2046 }
2047
2048 return true;
2049}
2050
Geoff Lang2186c382016-10-14 10:54:54 -04002051bool ValidateGetQueryivBase(Context *context, GLenum target, GLenum pname, GLsizei *numParams)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002052{
Geoff Lang2186c382016-10-14 10:54:54 -04002053 if (numParams)
2054 {
2055 *numParams = 0;
2056 }
2057
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002058 if (!ValidQueryType(context, target) && target != GL_TIMESTAMP_EXT)
2059 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002060 context->handleError(InvalidEnum() << "Invalid query type");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002061 return false;
2062 }
2063
2064 switch (pname)
2065 {
2066 case GL_CURRENT_QUERY_EXT:
2067 if (target == GL_TIMESTAMP_EXT)
2068 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002069 context->handleError(InvalidEnum() << "Cannot use current query for timestamp");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002070 return false;
2071 }
2072 break;
2073 case GL_QUERY_COUNTER_BITS_EXT:
2074 if (!context->getExtensions().disjointTimerQuery ||
2075 (target != GL_TIMESTAMP_EXT && target != GL_TIME_ELAPSED_EXT))
2076 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002077 context->handleError(InvalidEnum() << "Invalid pname");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002078 return false;
2079 }
2080 break;
2081 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002082 context->handleError(InvalidEnum() << "Invalid pname");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002083 return false;
2084 }
2085
Geoff Lang2186c382016-10-14 10:54:54 -04002086 if (numParams)
2087 {
2088 // All queries return only one value
2089 *numParams = 1;
2090 }
2091
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002092 return true;
2093}
2094
2095bool ValidateGetQueryivEXT(Context *context, GLenum target, GLenum pname, GLint *params)
2096{
2097 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04002098 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002099 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002100 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002101 return false;
2102 }
2103
Geoff Lang2186c382016-10-14 10:54:54 -04002104 return ValidateGetQueryivBase(context, target, pname, nullptr);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002105}
2106
Geoff Lang2186c382016-10-14 10:54:54 -04002107bool ValidateGetQueryivRobustANGLE(Context *context,
2108 GLenum target,
2109 GLenum pname,
2110 GLsizei bufSize,
2111 GLsizei *length,
2112 GLint *params)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002113{
Geoff Lang2186c382016-10-14 10:54:54 -04002114 if (!ValidateRobustEntryPoint(context, bufSize))
2115 {
2116 return false;
2117 }
2118
2119 if (!ValidateGetQueryivBase(context, target, pname, length))
2120 {
2121 return false;
2122 }
2123
2124 if (!ValidateRobustBufferSize(context, bufSize, *length))
2125 {
2126 return false;
2127 }
2128
2129 return true;
2130}
2131
2132bool ValidateGetQueryObjectValueBase(Context *context, GLuint id, GLenum pname, GLsizei *numParams)
2133{
2134 if (numParams)
2135 {
2136 *numParams = 0;
2137 }
2138
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002139 Query *queryObject = context->getQuery(id, false, GL_NONE);
2140
2141 if (!queryObject)
2142 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002143 context->handleError(InvalidOperation() << "Query does not exist");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002144 return false;
2145 }
2146
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002147 if (context->getGLState().isQueryActive(queryObject))
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002148 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002149 context->handleError(InvalidOperation() << "Query currently active");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002150 return false;
2151 }
2152
2153 switch (pname)
2154 {
2155 case GL_QUERY_RESULT_EXT:
2156 case GL_QUERY_RESULT_AVAILABLE_EXT:
2157 break;
2158
2159 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002160 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002161 return false;
2162 }
2163
Geoff Lang2186c382016-10-14 10:54:54 -04002164 if (numParams)
2165 {
2166 *numParams = 1;
2167 }
2168
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002169 return true;
2170}
2171
2172bool ValidateGetQueryObjectivEXT(Context *context, GLuint id, GLenum pname, GLint *params)
2173{
2174 if (!context->getExtensions().disjointTimerQuery)
2175 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002176 context->handleError(InvalidOperation() << "Timer query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002177 return false;
2178 }
Geoff Lang2186c382016-10-14 10:54:54 -04002179 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2180}
2181
2182bool ValidateGetQueryObjectivRobustANGLE(Context *context,
2183 GLuint id,
2184 GLenum pname,
2185 GLsizei bufSize,
2186 GLsizei *length,
2187 GLint *params)
2188{
2189 if (!context->getExtensions().disjointTimerQuery)
2190 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002191 context->handleError(InvalidOperation() << "Timer query extension not enabled");
Geoff Lang2186c382016-10-14 10:54:54 -04002192 return false;
2193 }
2194
2195 if (!ValidateRobustEntryPoint(context, bufSize))
2196 {
2197 return false;
2198 }
2199
2200 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2201 {
2202 return false;
2203 }
2204
2205 if (!ValidateRobustBufferSize(context, bufSize, *length))
2206 {
2207 return false;
2208 }
2209
2210 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002211}
2212
2213bool ValidateGetQueryObjectuivEXT(Context *context, GLuint id, GLenum pname, GLuint *params)
2214{
2215 if (!context->getExtensions().disjointTimerQuery &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04002216 !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002217 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002218 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002219 return false;
2220 }
Geoff Lang2186c382016-10-14 10:54:54 -04002221 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2222}
2223
2224bool ValidateGetQueryObjectuivRobustANGLE(Context *context,
2225 GLuint id,
2226 GLenum pname,
2227 GLsizei bufSize,
2228 GLsizei *length,
2229 GLuint *params)
2230{
2231 if (!context->getExtensions().disjointTimerQuery &&
2232 !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery)
2233 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002234 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002235 return false;
2236 }
2237
2238 if (!ValidateRobustEntryPoint(context, bufSize))
2239 {
2240 return false;
2241 }
2242
2243 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2244 {
2245 return false;
2246 }
2247
2248 if (!ValidateRobustBufferSize(context, bufSize, *length))
2249 {
2250 return false;
2251 }
2252
2253 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002254}
2255
2256bool ValidateGetQueryObjecti64vEXT(Context *context, GLuint id, GLenum pname, GLint64 *params)
2257{
2258 if (!context->getExtensions().disjointTimerQuery)
2259 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002260 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002261 return false;
2262 }
Geoff Lang2186c382016-10-14 10:54:54 -04002263 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2264}
2265
2266bool ValidateGetQueryObjecti64vRobustANGLE(Context *context,
2267 GLuint id,
2268 GLenum pname,
2269 GLsizei bufSize,
2270 GLsizei *length,
2271 GLint64 *params)
2272{
2273 if (!context->getExtensions().disjointTimerQuery)
2274 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002275 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002276 return false;
2277 }
2278
2279 if (!ValidateRobustEntryPoint(context, bufSize))
2280 {
2281 return false;
2282 }
2283
2284 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2285 {
2286 return false;
2287 }
2288
2289 if (!ValidateRobustBufferSize(context, bufSize, *length))
2290 {
2291 return false;
2292 }
2293
2294 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002295}
2296
2297bool ValidateGetQueryObjectui64vEXT(Context *context, GLuint id, GLenum pname, GLuint64 *params)
2298{
2299 if (!context->getExtensions().disjointTimerQuery)
2300 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002301 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002302 return false;
2303 }
Geoff Lang2186c382016-10-14 10:54:54 -04002304 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2305}
2306
2307bool ValidateGetQueryObjectui64vRobustANGLE(Context *context,
2308 GLuint id,
2309 GLenum pname,
2310 GLsizei bufSize,
2311 GLsizei *length,
2312 GLuint64 *params)
2313{
2314 if (!context->getExtensions().disjointTimerQuery)
2315 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002316 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002317 return false;
2318 }
2319
2320 if (!ValidateRobustEntryPoint(context, bufSize))
2321 {
2322 return false;
2323 }
2324
2325 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2326 {
2327 return false;
2328 }
2329
2330 if (!ValidateRobustBufferSize(context, bufSize, *length))
2331 {
2332 return false;
2333 }
2334
2335 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002336}
2337
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002338bool ValidateProgramUniform(gl::Context *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002339 GLenum valueType,
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002340 GLuint program,
2341 GLint location,
2342 GLsizei count)
2343{
2344 // Check for ES31 program uniform entry points
2345 if (context->getClientVersion() < Version(3, 1))
2346 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002347 context->handleError(InvalidOperation());
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002348 return false;
2349 }
2350
2351 const LinkedUniform *uniform = nullptr;
2352 gl::Program *programObject = GetValidProgram(context, program);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002353 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2354 ValidateUniformValue(context, valueType, uniform->type);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002355}
2356
Frank Henigmana98a6472017-02-02 21:38:32 -05002357bool ValidateProgramUniform1iv(gl::Context *context,
2358 GLuint program,
2359 GLint location,
2360 GLsizei count,
2361 const GLint *value)
2362{
2363 // Check for ES31 program uniform entry points
2364 if (context->getClientVersion() < Version(3, 1))
2365 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002366 context->handleError(InvalidOperation());
Frank Henigmana98a6472017-02-02 21:38:32 -05002367 return false;
2368 }
2369
2370 const LinkedUniform *uniform = nullptr;
2371 gl::Program *programObject = GetValidProgram(context, program);
2372 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2373 ValidateUniform1ivValue(context, uniform->type, count, value);
2374}
2375
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002376bool ValidateProgramUniformMatrix(gl::Context *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002377 GLenum valueType,
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002378 GLuint program,
2379 GLint location,
2380 GLsizei count,
2381 GLboolean transpose)
2382{
2383 // Check for ES31 program uniform entry points
2384 if (context->getClientVersion() < Version(3, 1))
2385 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002386 context->handleError(InvalidOperation());
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002387 return false;
2388 }
2389
2390 const LinkedUniform *uniform = nullptr;
2391 gl::Program *programObject = GetValidProgram(context, program);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002392 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2393 ValidateUniformMatrixValue(context, valueType, uniform->type);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002394}
2395
Jamie Madillc1d770e2017-04-13 17:31:24 -04002396bool ValidateUniform(ValidationContext *context, GLenum valueType, GLint location, GLsizei count)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002397{
2398 // Check for ES3 uniform entry points
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002399 if (VariableComponentType(valueType) == GL_UNSIGNED_INT && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002400 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002401 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002402 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002403 }
2404
Jamie Madill62d31cb2015-09-11 13:25:51 -04002405 const LinkedUniform *uniform = nullptr;
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002406 gl::Program *programObject = context->getGLState().getProgram();
2407 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2408 ValidateUniformValue(context, valueType, uniform->type);
Jamie Madillaa981bd2014-05-20 10:55:55 -04002409}
2410
Jamie Madillbe849e42017-05-02 15:49:00 -04002411bool ValidateUniform1iv(ValidationContext *context,
2412 GLint location,
2413 GLsizei count,
2414 const GLint *value)
Frank Henigmana98a6472017-02-02 21:38:32 -05002415{
2416 const LinkedUniform *uniform = nullptr;
2417 gl::Program *programObject = context->getGLState().getProgram();
2418 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2419 ValidateUniform1ivValue(context, uniform->type, count, value);
2420}
2421
Jamie Madillc1d770e2017-04-13 17:31:24 -04002422bool ValidateUniformMatrix(ValidationContext *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002423 GLenum valueType,
He Yunchaoced53ae2016-11-29 15:00:51 +08002424 GLint location,
2425 GLsizei count,
Jamie Madillaa981bd2014-05-20 10:55:55 -04002426 GLboolean transpose)
2427{
2428 // Check for ES3 uniform entry points
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002429 int rows = VariableRowCount(valueType);
2430 int cols = VariableColumnCount(valueType);
Martin Radev1be913c2016-07-11 17:59:16 +03002431 if (rows != cols && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002432 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002433 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002434 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002435 }
2436
Martin Radev1be913c2016-07-11 17:59:16 +03002437 if (transpose != GL_FALSE && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002438 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002439 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002440 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002441 }
2442
Jamie Madill62d31cb2015-09-11 13:25:51 -04002443 const LinkedUniform *uniform = nullptr;
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002444 gl::Program *programObject = context->getGLState().getProgram();
2445 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2446 ValidateUniformMatrixValue(context, valueType, uniform->type);
Jamie Madillaa981bd2014-05-20 10:55:55 -04002447}
2448
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002449bool ValidateStateQuery(ValidationContext *context,
2450 GLenum pname,
2451 GLenum *nativeType,
2452 unsigned int *numParams)
Jamie Madill893ab082014-05-16 16:56:10 -04002453{
2454 if (!context->getQueryParameterInfo(pname, nativeType, numParams))
2455 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002456 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04002457 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002458 }
2459
Jamie Madill0af26e12015-03-05 19:54:33 -05002460 const Caps &caps = context->getCaps();
2461
Jamie Madill893ab082014-05-16 16:56:10 -04002462 if (pname >= GL_DRAW_BUFFER0 && pname <= GL_DRAW_BUFFER15)
2463 {
2464 unsigned int colorAttachment = (pname - GL_DRAW_BUFFER0);
2465
Jamie Madill0af26e12015-03-05 19:54:33 -05002466 if (colorAttachment >= caps.maxDrawBuffers)
Jamie Madill893ab082014-05-16 16:56:10 -04002467 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002468 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002469 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002470 }
2471 }
2472
2473 switch (pname)
2474 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002475 case GL_TEXTURE_BINDING_2D:
2476 case GL_TEXTURE_BINDING_CUBE_MAP:
2477 case GL_TEXTURE_BINDING_3D:
2478 case GL_TEXTURE_BINDING_2D_ARRAY:
JiangYizhou24fe74c2017-07-06 16:56:50 +08002479 case GL_TEXTURE_BINDING_2D_MULTISAMPLE:
He Yunchaoced53ae2016-11-29 15:00:51 +08002480 break;
2481 case GL_TEXTURE_BINDING_EXTERNAL_OES:
2482 if (!context->getExtensions().eglStreamConsumerExternal &&
2483 !context->getExtensions().eglImageExternal)
2484 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002485 context->handleError(InvalidEnum() << "Neither NV_EGL_stream_consumer_external "
2486 "nor GL_OES_EGL_image_external "
2487 "extensions enabled");
He Yunchaoced53ae2016-11-29 15:00:51 +08002488 return false;
2489 }
2490 break;
Jamie Madill893ab082014-05-16 16:56:10 -04002491
He Yunchaoced53ae2016-11-29 15:00:51 +08002492 case GL_IMPLEMENTATION_COLOR_READ_TYPE:
2493 case GL_IMPLEMENTATION_COLOR_READ_FORMAT:
Jamie Madill893ab082014-05-16 16:56:10 -04002494 {
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002495 if (context->getGLState().getReadFramebuffer()->checkStatus(context) !=
2496 GL_FRAMEBUFFER_COMPLETE)
Jamie Madill893ab082014-05-16 16:56:10 -04002497 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002498 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002499 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002500 }
2501
Jamie Madill51f40ec2016-06-15 14:06:00 -04002502 const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer();
2503 ASSERT(framebuffer);
Martin Radev138064f2016-07-15 12:03:41 +03002504
2505 if (framebuffer->getReadBufferState() == GL_NONE)
2506 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002507 context->handleError(InvalidOperation() << "Read buffer is GL_NONE");
Martin Radev138064f2016-07-15 12:03:41 +03002508 return false;
2509 }
2510
Jamie Madillb6bda4a2015-04-20 12:53:26 -04002511 const FramebufferAttachment *attachment = framebuffer->getReadColorbuffer();
Jamie Madill3c7fa222014-06-05 13:08:51 -04002512 if (!attachment)
Jamie Madill893ab082014-05-16 16:56:10 -04002513 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002514 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002515 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002516 }
2517 }
2518 break;
2519
He Yunchaoced53ae2016-11-29 15:00:51 +08002520 default:
2521 break;
Jamie Madill893ab082014-05-16 16:56:10 -04002522 }
2523
2524 // pname is valid, but there are no parameters to return
Geoff Langff5b2d52016-09-07 11:32:23 -04002525 if (*numParams == 0)
2526 {
2527 return false;
2528 }
2529
2530 return true;
2531}
2532
2533bool ValidateRobustStateQuery(ValidationContext *context,
2534 GLenum pname,
2535 GLsizei bufSize,
2536 GLenum *nativeType,
2537 unsigned int *numParams)
2538{
2539 if (!ValidateRobustEntryPoint(context, bufSize))
2540 {
2541 return false;
2542 }
2543
2544 if (!ValidateStateQuery(context, pname, nativeType, numParams))
2545 {
2546 return false;
2547 }
2548
2549 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
Jamie Madill893ab082014-05-16 16:56:10 -04002550 {
2551 return false;
2552 }
2553
2554 return true;
2555}
2556
Jamie Madillc29968b2016-01-20 11:17:23 -05002557bool ValidateCopyTexImageParametersBase(ValidationContext *context,
2558 GLenum target,
2559 GLint level,
2560 GLenum internalformat,
2561 bool isSubImage,
2562 GLint xoffset,
2563 GLint yoffset,
2564 GLint zoffset,
2565 GLint x,
2566 GLint y,
2567 GLsizei width,
2568 GLsizei height,
2569 GLint border,
Jamie Madill0c8abca2016-07-22 20:21:26 -04002570 Format *textureFormatOut)
Jamie Madill560a8d82014-05-21 13:06:20 -04002571{
Brandon Jones6cad5662017-06-14 13:25:13 -07002572 if (xoffset < 0 || yoffset < 0 || zoffset < 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04002573 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002574 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
2575 return false;
2576 }
2577
2578 if (width < 0 || height < 0)
2579 {
2580 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Geoff Langb1196682014-07-23 13:47:29 -04002581 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002582 }
2583
He Yunchaoced53ae2016-11-29 15:00:51 +08002584 if (std::numeric_limits<GLsizei>::max() - xoffset < width ||
2585 std::numeric_limits<GLsizei>::max() - yoffset < height)
Jamie Madill560a8d82014-05-21 13:06:20 -04002586 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002587 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002588 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002589 }
2590
2591 if (border != 0)
2592 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002593 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidBorder);
Geoff Langb1196682014-07-23 13:47:29 -04002594 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002595 }
2596
2597 if (!ValidMipLevel(context, target, level))
2598 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002599 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Geoff Langb1196682014-07-23 13:47:29 -04002600 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002601 }
2602
Jamie Madill51f40ec2016-06-15 14:06:00 -04002603 const auto &state = context->getGLState();
2604 auto readFramebuffer = state.getReadFramebuffer();
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002605 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill560a8d82014-05-21 13:06:20 -04002606 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002607 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002608 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002609 }
2610
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002611 if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04002612 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002613 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002614 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002615 }
2616
Martin Radev138064f2016-07-15 12:03:41 +03002617 if (readFramebuffer->getReadBufferState() == GL_NONE)
2618 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002619 context->handleError(InvalidOperation() << "Read buffer is GL_NONE");
Martin Radev138064f2016-07-15 12:03:41 +03002620 return false;
2621 }
2622
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002623 // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment
2624 // In OpenGL ES it is undefined what happens when an operation tries to read from a missing
He Yunchao66a41a22016-12-15 16:45:05 +08002625 // attachment and WebGL defines it to be an error. We do the check unconditionally as the
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002626 // situation is an application error that would lead to a crash in ANGLE.
2627 if (readFramebuffer->getReadColorbuffer() == nullptr)
2628 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002629 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment);
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002630 return false;
2631 }
2632
Geoff Langaae65a42014-05-26 12:43:44 -04002633 const gl::Caps &caps = context->getCaps();
2634
Geoff Langaae65a42014-05-26 12:43:44 -04002635 GLuint maxDimension = 0;
Jamie Madill560a8d82014-05-21 13:06:20 -04002636 switch (target)
2637 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002638 case GL_TEXTURE_2D:
2639 maxDimension = caps.max2DTextureSize;
2640 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002641
He Yunchaoced53ae2016-11-29 15:00:51 +08002642 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
2643 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
2644 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
2645 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
2646 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
2647 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
2648 maxDimension = caps.maxCubeMapTextureSize;
2649 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002650
He Yunchaoced53ae2016-11-29 15:00:51 +08002651 case GL_TEXTURE_2D_ARRAY:
2652 maxDimension = caps.max2DTextureSize;
2653 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002654
He Yunchaoced53ae2016-11-29 15:00:51 +08002655 case GL_TEXTURE_3D:
2656 maxDimension = caps.max3DTextureSize;
2657 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002658
He Yunchaoced53ae2016-11-29 15:00:51 +08002659 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002660 context->handleError(InvalidEnum());
He Yunchaoced53ae2016-11-29 15:00:51 +08002661 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002662 }
2663
Jamie Madillc29968b2016-01-20 11:17:23 -05002664 gl::Texture *texture =
2665 state.getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target);
Jamie Madill560a8d82014-05-21 13:06:20 -04002666 if (!texture)
2667 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002668 ANGLE_VALIDATION_ERR(context, InvalidOperation(), TextureNotBound);
Geoff Langb1196682014-07-23 13:47:29 -04002669 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002670 }
2671
Geoff Lang69cce582015-09-17 13:20:36 -04002672 if (texture->getImmutableFormat() && !isSubImage)
Jamie Madill560a8d82014-05-21 13:06:20 -04002673 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002674 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002675 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002676 }
2677
Geoff Langca271392017-04-05 12:30:00 -04002678 const gl::InternalFormat &formatInfo =
2679 gl::GetInternalFormatInfo(internalformat, GL_UNSIGNED_BYTE);
Geoff Lang5d601382014-07-22 15:14:06 -04002680
Geoff Lang966c9402017-04-18 12:38:27 -04002681 if (formatInfo.depthBits > 0 || formatInfo.compressed)
Jamie Madill560a8d82014-05-21 13:06:20 -04002682 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002683 context->handleError(InvalidOperation());
Geoff Langa9be0dc2014-12-17 12:34:40 -05002684 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002685 }
2686
2687 if (isSubImage)
2688 {
Geoff Langa9be0dc2014-12-17 12:34:40 -05002689 if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) ||
2690 static_cast<size_t>(yoffset + height) > texture->getHeight(target, level) ||
2691 static_cast<size_t>(zoffset) >= texture->getDepth(target, level))
Jamie Madill560a8d82014-05-21 13:06:20 -04002692 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002693 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002694 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002695 }
2696 }
Jamie Madill6f38f822014-06-06 17:12:20 -04002697 else
2698 {
Geoff Lang691e58c2014-12-19 17:03:25 -05002699 if (IsCubeMapTextureTarget(target) && width != height)
Jamie Madill6f38f822014-06-06 17:12:20 -04002700 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002701 ANGLE_VALIDATION_ERR(context, InvalidValue(), CubemapIncomplete);
Geoff Langb1196682014-07-23 13:47:29 -04002702 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002703 }
2704
Geoff Langeb66a6e2016-10-31 13:06:12 -04002705 if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions()))
Jamie Madill6f38f822014-06-06 17:12:20 -04002706 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002707 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langb1196682014-07-23 13:47:29 -04002708 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002709 }
2710
2711 int maxLevelDimension = (maxDimension >> level);
He Yunchaoced53ae2016-11-29 15:00:51 +08002712 if (static_cast<int>(width) > maxLevelDimension ||
2713 static_cast<int>(height) > maxLevelDimension)
Jamie Madill6f38f822014-06-06 17:12:20 -04002714 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002715 ANGLE_VALIDATION_ERR(context, InvalidValue(), ResourceMaxTextureSize);
Geoff Langb1196682014-07-23 13:47:29 -04002716 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002717 }
2718 }
Jamie Madill560a8d82014-05-21 13:06:20 -04002719
Jamie Madill0c8abca2016-07-22 20:21:26 -04002720 if (textureFormatOut)
2721 {
2722 *textureFormatOut = texture->getFormat(target, level);
2723 }
Jamie Madillf695a3a2017-01-11 17:36:35 -05002724
2725 // Detect texture copying feedback loops for WebGL.
2726 if (context->getExtensions().webglCompatibility)
2727 {
Jamie Madillfd3dd432017-02-02 19:59:59 -05002728 if (readFramebuffer->formsCopyingFeedbackLoopWith(texture->id(), level, zoffset))
Jamie Madillf695a3a2017-01-11 17:36:35 -05002729 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002730 context->handleError(InvalidOperation() << "Texture copying feedback loop formed "
2731 "between Framebuffer and specified "
2732 "Texture level.");
Jamie Madillf695a3a2017-01-11 17:36:35 -05002733 return false;
2734 }
2735 }
2736
Jamie Madill560a8d82014-05-21 13:06:20 -04002737 return true;
2738}
2739
Jiajia Qind9671222016-11-29 16:30:31 +08002740bool ValidateDrawBase(ValidationContext *context, GLenum mode, GLsizei count)
Jamie Madill250d33f2014-06-06 17:09:03 -04002741{
Jamie Madill1aeb1312014-06-20 13:21:25 -04002742 switch (mode)
2743 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002744 case GL_POINTS:
2745 case GL_LINES:
2746 case GL_LINE_LOOP:
2747 case GL_LINE_STRIP:
2748 case GL_TRIANGLES:
2749 case GL_TRIANGLE_STRIP:
2750 case GL_TRIANGLE_FAN:
2751 break;
2752 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002753 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidDrawMode);
He Yunchaoced53ae2016-11-29 15:00:51 +08002754 return false;
Jamie Madill1aeb1312014-06-20 13:21:25 -04002755 }
2756
Jamie Madill250d33f2014-06-06 17:09:03 -04002757 if (count < 0)
2758 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002759 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Geoff Langb1196682014-07-23 13:47:29 -04002760 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002761 }
2762
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002763 const State &state = context->getGLState();
Geoff Langb1196682014-07-23 13:47:29 -04002764
Jamie Madill250d33f2014-06-06 17:09:03 -04002765 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002766 if (state.hasMappedBuffer(GL_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04002767 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002768 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002769 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002770 }
2771
Jamie Madillcbcde722017-01-06 14:50:00 -05002772 // Note: these separate values are not supported in WebGL, due to D3D's limitations. See
2773 // Section 6.10 of the WebGL 1.0 spec.
Jamie Madill51f40ec2016-06-15 14:06:00 -04002774 Framebuffer *framebuffer = state.getDrawFramebuffer();
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002775 if (context->getLimitations().noSeparateStencilRefsAndMasks ||
2776 context->getExtensions().webglCompatibility)
Jamie Madillac528012014-06-20 13:21:23 -04002777 {
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002778 const FramebufferAttachment *dsAttachment =
2779 framebuffer->getStencilOrDepthStencilAttachment();
2780 GLuint stencilBits = dsAttachment ? dsAttachment->getStencilSize() : 0;
He Yunchaoced53ae2016-11-29 15:00:51 +08002781 GLuint minimumRequiredStencilMask = (1 << stencilBits) - 1;
Jinyoung Hur85769f02015-10-20 17:08:44 -04002782 const DepthStencilState &depthStencilState = state.getDepthStencilState();
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002783
2784 bool differentRefs = state.getStencilRef() != state.getStencilBackRef();
2785 bool differentWritemasks =
2786 (depthStencilState.stencilWritemask & minimumRequiredStencilMask) !=
2787 (depthStencilState.stencilBackWritemask & minimumRequiredStencilMask);
2788 bool differentMasks = (depthStencilState.stencilMask & minimumRequiredStencilMask) !=
2789 (depthStencilState.stencilBackMask & minimumRequiredStencilMask);
2790
2791 if (differentRefs || differentWritemasks || differentMasks)
Geoff Lang3a86ad32015-09-01 11:47:05 -04002792 {
Jamie Madillcbcde722017-01-06 14:50:00 -05002793 if (!context->getExtensions().webglCompatibility)
2794 {
Yuly Novikovd73f8522017-01-13 17:48:57 -05002795 ERR() << "This ANGLE implementation does not support separate front/back stencil "
2796 "writemasks, reference values, or stencil mask values.";
Jamie Madillcbcde722017-01-06 14:50:00 -05002797 }
Brandon Jones6cad5662017-06-14 13:25:13 -07002798 ANGLE_VALIDATION_ERR(context, InvalidOperation(), StencilReferenceMaskOrMismatch);
Geoff Lang3a86ad32015-09-01 11:47:05 -04002799 return false;
2800 }
Jamie Madillac528012014-06-20 13:21:23 -04002801 }
2802
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002803 if (framebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill13f7d7d2014-06-20 13:21:27 -04002804 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002805 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002806 return false;
Jamie Madill13f7d7d2014-06-20 13:21:27 -04002807 }
2808
Geoff Lang7dd2e102014-11-10 15:19:26 -05002809 gl::Program *program = state.getProgram();
2810 if (!program)
Jamie Madilld4cfa572014-07-08 10:00:32 -04002811 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002812 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotBound);
Geoff Langb1196682014-07-23 13:47:29 -04002813 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04002814 }
2815
Yunchao Hef81ce4a2017-04-24 10:49:17 +08002816 if (!program->validateSamplers(nullptr, context->getCaps()))
Jamie Madilld4cfa572014-07-08 10:00:32 -04002817 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002818 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002819 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04002820 }
2821
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002822 // Uniform buffer validation
He Yunchaoced53ae2016-11-29 15:00:51 +08002823 for (unsigned int uniformBlockIndex = 0;
2824 uniformBlockIndex < program->getActiveUniformBlockCount(); uniformBlockIndex++)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002825 {
Jamie Madill62d31cb2015-09-11 13:25:51 -04002826 const gl::UniformBlock &uniformBlock = program->getUniformBlockByIndex(uniformBlockIndex);
He Yunchaoced53ae2016-11-29 15:00:51 +08002827 GLuint blockBinding = program->getUniformBlockBinding(uniformBlockIndex);
Geoff Lang5d124a62015-09-15 13:03:27 -04002828 const OffsetBindingPointer<Buffer> &uniformBuffer =
2829 state.getIndexedUniformBuffer(blockBinding);
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002830
Geoff Lang5d124a62015-09-15 13:03:27 -04002831 if (uniformBuffer.get() == nullptr)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002832 {
2833 // undefined behaviour
Jamie Madill437fa652016-05-03 15:13:24 -04002834 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002835 InvalidOperation()
2836 << "It is undefined behaviour to have a used but unbound uniform buffer.");
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002837 return false;
2838 }
2839
Geoff Lang5d124a62015-09-15 13:03:27 -04002840 size_t uniformBufferSize = uniformBuffer.getSize();
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002841 if (uniformBufferSize == 0)
2842 {
2843 // Bind the whole buffer.
Minmin Gong794e0002015-04-07 18:31:54 -07002844 uniformBufferSize = static_cast<size_t>(uniformBuffer->getSize());
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002845 }
2846
Jamie Madill62d31cb2015-09-11 13:25:51 -04002847 if (uniformBufferSize < uniformBlock.dataSize)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002848 {
2849 // undefined behaviour
Jamie Madill437fa652016-05-03 15:13:24 -04002850 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002851 InvalidOperation()
2852 << "It is undefined behaviour to use a uniform buffer that is too small.");
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002853 return false;
2854 }
2855 }
2856
Geoff Lange0cff192017-05-30 13:04:56 -04002857 // Do some additonal WebGL-specific validation
Jamie Madilla4595b82017-01-11 17:36:34 -05002858 if (context->getExtensions().webglCompatibility)
2859 {
Geoff Lange0cff192017-05-30 13:04:56 -04002860 // Detect rendering feedback loops for WebGL.
Jamie Madilla4595b82017-01-11 17:36:34 -05002861 if (framebuffer->formsRenderingFeedbackLoopWith(state))
2862 {
2863 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002864 InvalidOperation()
2865 << "Rendering feedback loop formed between Framebuffer and active Texture.");
Jamie Madilla4595b82017-01-11 17:36:34 -05002866 return false;
2867 }
Geoff Lange0cff192017-05-30 13:04:56 -04002868
Geoff Lang9ab5b822017-05-30 16:19:23 -04002869 // Detect that the vertex shader input types match the attribute types
2870 if (!ValidateVertexShaderAttributeTypeMatch(context))
2871 {
2872 return false;
2873 }
2874
Geoff Lange0cff192017-05-30 13:04:56 -04002875 // Detect that the color buffer types match the fragment shader output types
2876 if (!ValidateFragmentShaderColorBufferTypeMatch(context))
2877 {
2878 return false;
2879 }
Jamie Madilla4595b82017-01-11 17:36:34 -05002880 }
2881
Jamie Madill250d33f2014-06-06 17:09:03 -04002882 // No-op if zero count
2883 return (count > 0);
2884}
2885
Jamie Madillc1d770e2017-04-13 17:31:24 -04002886bool ValidateDrawArraysCommon(ValidationContext *context,
2887 GLenum mode,
2888 GLint first,
2889 GLsizei count,
2890 GLsizei primcount)
Jamie Madill250d33f2014-06-06 17:09:03 -04002891{
Jamie Madillfd716582014-06-06 17:09:04 -04002892 if (first < 0)
Jamie Madill250d33f2014-06-06 17:09:03 -04002893 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002894 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeStart);
Geoff Langb1196682014-07-23 13:47:29 -04002895 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002896 }
2897
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002898 const State &state = context->getGLState();
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002899 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
He Yunchaoced53ae2016-11-29 15:00:51 +08002900 if (curTransformFeedback && curTransformFeedback->isActive() &&
2901 !curTransformFeedback->isPaused() && curTransformFeedback->getPrimitiveMode() != mode)
Jamie Madillfd716582014-06-06 17:09:04 -04002902 {
2903 // It is an invalid operation to call DrawArrays or DrawArraysInstanced with a draw mode
He Yunchaoced53ae2016-11-29 15:00:51 +08002904 // that does not match the current transform feedback object's draw mode (if transform
2905 // feedback
Jamie Madillfd716582014-06-06 17:09:04 -04002906 // is active), (3.0.2, section 2.14, pg 86)
Brandon Jones6cad5662017-06-14 13:25:13 -07002907 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidDrawModeTransformFeedback);
Geoff Langb1196682014-07-23 13:47:29 -04002908 return false;
Jamie Madillfd716582014-06-06 17:09:04 -04002909 }
2910
Jiajia Qind9671222016-11-29 16:30:31 +08002911 if (!ValidateDrawBase(context, mode, count))
Corentin Wallez18a2fb32015-08-10 12:58:14 -07002912 {
2913 return false;
2914 }
2915
Corentin Wallez71168a02016-12-19 15:11:18 -08002916 // Check the computation of maxVertex doesn't overflow.
2917 // - first < 0 or count < 0 have been checked as an error condition
2918 // - count > 0 has been checked in ValidateDrawBase as it makes the call a noop
2919 // From this we know maxVertex will be positive, and only need to check if it overflows GLint.
2920 ASSERT(count > 0 && first >= 0);
2921 int64_t maxVertex = static_cast<int64_t>(first) + static_cast<int64_t>(count) - 1;
2922 if (maxVertex > static_cast<int64_t>(std::numeric_limits<GLint>::max()))
Corentin Wallez92db6942016-12-09 13:10:36 -05002923 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002924 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallez92db6942016-12-09 13:10:36 -05002925 return false;
2926 }
2927
Corentin Wallez71168a02016-12-19 15:11:18 -08002928 if (!ValidateDrawAttribs(context, primcount, static_cast<GLint>(maxVertex), count))
Jamie Madillfd716582014-06-06 17:09:04 -04002929 {
2930 return false;
2931 }
2932
2933 return true;
2934}
2935
He Yunchaoced53ae2016-11-29 15:00:51 +08002936bool ValidateDrawArraysInstanced(Context *context,
2937 GLenum mode,
2938 GLint first,
2939 GLsizei count,
2940 GLsizei primcount)
Jamie Madillfd716582014-06-06 17:09:04 -04002941{
Corentin Wallez0dc97812017-06-22 14:38:44 -04002942 return ValidateDrawArraysInstancedBase(context, mode, first, count, primcount);
Geoff Lang87a93302014-09-16 13:29:43 -04002943}
2944
He Yunchaoced53ae2016-11-29 15:00:51 +08002945bool ValidateDrawArraysInstancedANGLE(Context *context,
2946 GLenum mode,
2947 GLint first,
2948 GLsizei count,
2949 GLsizei primcount)
Geoff Lang87a93302014-09-16 13:29:43 -04002950{
Corentin Wallez170efbf2017-05-02 13:45:01 -04002951 if (!ValidateDrawArraysInstancedBase(context, mode, first, count, primcount))
Geoff Lang87a93302014-09-16 13:29:43 -04002952 {
2953 return false;
2954 }
2955
Corentin Wallez0dc97812017-06-22 14:38:44 -04002956 return ValidateDrawInstancedANGLE(context);
Geoff Lang87a93302014-09-16 13:29:43 -04002957}
2958
Jiajia Qind9671222016-11-29 16:30:31 +08002959bool ValidateDrawElementsBase(ValidationContext *context, GLenum type)
Jamie Madillfd716582014-06-06 17:09:04 -04002960{
Jamie Madill250d33f2014-06-06 17:09:03 -04002961 switch (type)
2962 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002963 case GL_UNSIGNED_BYTE:
2964 case GL_UNSIGNED_SHORT:
2965 break;
2966 case GL_UNSIGNED_INT:
2967 if (context->getClientMajorVersion() < 3 && !context->getExtensions().elementIndexUint)
2968 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002969 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte);
He Yunchaoced53ae2016-11-29 15:00:51 +08002970 return false;
2971 }
2972 break;
2973 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002974 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte);
He Yunchaoced53ae2016-11-29 15:00:51 +08002975 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002976 }
2977
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002978 const State &state = context->getGLState();
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002979
2980 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
He Yunchaoced53ae2016-11-29 15:00:51 +08002981 if (curTransformFeedback && curTransformFeedback->isActive() &&
2982 !curTransformFeedback->isPaused())
Jamie Madill250d33f2014-06-06 17:09:03 -04002983 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002984 // It is an invalid operation to call DrawElements, DrawRangeElements or
2985 // DrawElementsInstanced
Jamie Madill250d33f2014-06-06 17:09:03 -04002986 // while transform feedback is active, (3.0.2, section 2.14, pg 86)
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002987 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002988 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002989 }
2990
Jiajia Qind9671222016-11-29 16:30:31 +08002991 return true;
2992}
2993
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002994bool ValidateDrawElementsCommon(ValidationContext *context,
2995 GLenum mode,
2996 GLsizei count,
2997 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04002998 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002999 GLsizei primcount)
Jiajia Qind9671222016-11-29 16:30:31 +08003000{
3001 if (!ValidateDrawElementsBase(context, type))
3002 return false;
3003
3004 const State &state = context->getGLState();
3005
Corentin Wallez170efbf2017-05-02 13:45:01 -04003006 if (!ValidateDrawBase(context, mode, count))
3007 {
3008 return false;
3009 }
3010
Jamie Madill250d33f2014-06-06 17:09:03 -04003011 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04003012 if (state.hasMappedBuffer(GL_ELEMENT_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04003013 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003014 context->handleError(InvalidOperation() << "Index buffer is mapped.");
Geoff Langb1196682014-07-23 13:47:29 -04003015 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04003016 }
3017
He Yunchaoced53ae2016-11-29 15:00:51 +08003018 const gl::VertexArray *vao = state.getVertexArray();
Jamie Madill8e344942015-07-09 14:22:07 -04003019 gl::Buffer *elementArrayBuffer = vao->getElementArrayBuffer().get();
Jamie Madilld4cfa572014-07-08 10:00:32 -04003020
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003021 GLuint typeBytes = gl::GetTypeInfo(type).bytes;
3022
3023 if (context->getExtensions().webglCompatibility)
3024 {
3025 ASSERT(isPow2(typeBytes) && typeBytes > 0);
3026 if ((reinterpret_cast<uintptr_t>(indices) & static_cast<uintptr_t>(typeBytes - 1)) != 0)
3027 {
3028 // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements
3029 // The offset arguments to drawElements and [...], must be a multiple of the size of the
3030 // data type passed to the call, or an INVALID_OPERATION error is generated.
Brandon Jones6cad5662017-06-14 13:25:13 -07003031 ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType);
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003032 return false;
3033 }
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003034
3035 // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements
3036 // In addition the offset argument to drawElements must be non-negative or an INVALID_VALUE
3037 // error is generated.
3038 if (reinterpret_cast<intptr_t>(indices) < 0)
3039 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003040 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003041 return false;
3042 }
Geoff Langfeb8c682017-02-13 16:07:35 -05003043 }
3044
3045 if (context->getExtensions().webglCompatibility ||
3046 !context->getGLState().areClientArraysEnabled())
3047 {
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003048 if (!elementArrayBuffer && count > 0)
3049 {
3050 // [WebGL 1.0] Section 6.2 No Client Side Arrays
3051 // If drawElements is called with a count greater than zero, and no WebGLBuffer is bound
3052 // to the ELEMENT_ARRAY_BUFFER binding point, an INVALID_OPERATION error is generated.
Brandon Jones6cad5662017-06-14 13:25:13 -07003053 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MustHaveElementArrayBinding);
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003054 return false;
3055 }
3056 }
3057
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003058 if (count > 0)
Jamie Madillae3000b2014-08-25 15:47:51 -04003059 {
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003060 if (elementArrayBuffer)
Jamie Madillae3000b2014-08-25 15:47:51 -04003061 {
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003062 // The max possible type size is 8 and count is on 32 bits so doing the multiplication
3063 // in a 64 bit integer is safe. Also we are guaranteed that here count > 0.
3064 static_assert(std::is_same<int, GLsizei>::value, "GLsizei isn't the expected type");
3065 constexpr uint64_t kMaxTypeSize = 8;
3066 constexpr uint64_t kIntMax = std::numeric_limits<int>::max();
3067 constexpr uint64_t kUint64Max = std::numeric_limits<uint64_t>::max();
3068 static_assert(kIntMax < kUint64Max / kMaxTypeSize, "");
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003069
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003070 uint64_t typeSize = typeBytes;
3071 uint64_t elementCount = static_cast<uint64_t>(count);
3072 ASSERT(elementCount > 0 && typeSize <= kMaxTypeSize);
3073
3074 // Doing the multiplication here is overflow-safe
3075 uint64_t elementDataSizeNoOffset = typeSize * elementCount;
3076
3077 // The offset can be any value, check for overflows
3078 uint64_t offset = static_cast<uint64_t>(reinterpret_cast<uintptr_t>(indices));
3079 if (elementDataSizeNoOffset > kUint64Max - offset)
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003080 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003081 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003082 return false;
3083 }
3084
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003085 uint64_t elementDataSizeWithOffset = elementDataSizeNoOffset + offset;
3086 if (elementDataSizeWithOffset > static_cast<uint64_t>(elementArrayBuffer->getSize()))
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003087 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003088 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003089 return false;
3090 }
3091 }
3092 else if (!indices)
3093 {
3094 // This is an application error that would normally result in a crash,
3095 // but we catch it and return an error
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003096 context->handleError(InvalidOperation() << "No element array buffer and no pointer.");
Geoff Langb1196682014-07-23 13:47:29 -04003097 return false;
Jamie Madillae3000b2014-08-25 15:47:51 -04003098 }
Jamie Madillae3000b2014-08-25 15:47:51 -04003099 }
3100
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003101 // Use the parameter buffer to retrieve and cache the index range.
Jamie Madill2b976812014-08-25 15:47:49 -04003102 // TODO: offer fast path, with disabled index validation.
3103 // TODO: also disable index checking on back-ends that are robust to out-of-range accesses.
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003104 const auto &params = context->getParams<HasIndexRange>();
3105 const auto &indexRangeOpt = params.getIndexRange();
3106 if (!indexRangeOpt.valid())
Jamie Madill2b976812014-08-25 15:47:49 -04003107 {
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003108 // Unexpected error.
3109 return false;
Jamie Madill2b976812014-08-25 15:47:49 -04003110 }
3111
Jamie Madille79b1e12015-11-04 16:36:37 -05003112 // If we use an index greater than our maximum supported index range, return an error.
3113 // The ES3 spec does not specify behaviour here, it is undefined, but ANGLE should always
3114 // return an error if possible here.
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003115 if (static_cast<GLuint64>(indexRangeOpt.value().end) >= context->getCaps().maxElementIndex)
Jamie Madille79b1e12015-11-04 16:36:37 -05003116 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003117 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExceedsMaxElement);
Jamie Madille79b1e12015-11-04 16:36:37 -05003118 return false;
3119 }
3120
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003121 if (!ValidateDrawAttribs(context, primcount, static_cast<GLint>(indexRangeOpt.value().end),
3122 static_cast<GLint>(indexRangeOpt.value().vertexCount())))
Jamie Madillfd716582014-06-06 17:09:04 -04003123 {
3124 return false;
3125 }
3126
Geoff Lang3edfe032015-09-04 16:38:24 -04003127 // No op if there are no real indices in the index data (all are primitive restart).
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003128 return (indexRangeOpt.value().vertexIndexCount > 0);
Jamie Madillfd716582014-06-06 17:09:04 -04003129}
3130
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003131bool ValidateDrawElementsInstancedCommon(ValidationContext *context,
3132 GLenum mode,
3133 GLsizei count,
3134 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04003135 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003136 GLsizei primcount)
Jamie Madillfd716582014-06-06 17:09:04 -04003137{
Corentin Wallez0dc97812017-06-22 14:38:44 -04003138 return ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount);
Jamie Madill250d33f2014-06-06 17:09:03 -04003139}
3140
Geoff Lang3edfe032015-09-04 16:38:24 -04003141bool ValidateDrawElementsInstancedANGLE(Context *context,
3142 GLenum mode,
3143 GLsizei count,
3144 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04003145 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003146 GLsizei primcount)
Geoff Lang87a93302014-09-16 13:29:43 -04003147{
Corentin Wallez170efbf2017-05-02 13:45:01 -04003148 if (!ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount))
Geoff Lang87a93302014-09-16 13:29:43 -04003149 {
3150 return false;
3151 }
3152
Corentin Wallez0dc97812017-06-22 14:38:44 -04003153 return ValidateDrawInstancedANGLE(context);
Geoff Lang87a93302014-09-16 13:29:43 -04003154}
3155
He Yunchaoced53ae2016-11-29 15:00:51 +08003156bool ValidateFramebufferTextureBase(Context *context,
3157 GLenum target,
3158 GLenum attachment,
3159 GLuint texture,
3160 GLint level)
Jamie Madill570f7c82014-07-03 10:38:54 -04003161{
Jamie Madill55ec3b12014-07-03 10:38:57 -04003162 if (!ValidFramebufferTarget(target))
3163 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003164 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04003165 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003166 }
3167
3168 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill570f7c82014-07-03 10:38:54 -04003169 {
3170 return false;
3171 }
3172
Jamie Madill55ec3b12014-07-03 10:38:57 -04003173 if (texture != 0)
3174 {
3175 gl::Texture *tex = context->getTexture(texture);
3176
Jamie Madillbe849e42017-05-02 15:49:00 -04003177 if (tex == NULL)
Jamie Madill55ec3b12014-07-03 10:38:57 -04003178 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003179 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04003180 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003181 }
3182
3183 if (level < 0)
3184 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003185 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04003186 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003187 }
3188 }
3189
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003190 const gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
Jamie Madill84115c92015-04-23 15:00:07 -04003191 ASSERT(framebuffer);
Jamie Madill55ec3b12014-07-03 10:38:57 -04003192
Jamie Madill84115c92015-04-23 15:00:07 -04003193 if (framebuffer->id() == 0)
Jamie Madill55ec3b12014-07-03 10:38:57 -04003194 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003195 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04003196 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003197 }
3198
3199 return true;
3200}
3201
Geoff Langb1196682014-07-23 13:47:29 -04003202bool ValidateGetUniformBase(Context *context, GLuint program, GLint location)
Jamie Madill0063c512014-08-25 15:47:53 -04003203{
3204 if (program == 0)
3205 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003206 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04003207 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003208 }
3209
Dian Xiang769769a2015-09-09 15:20:08 -07003210 gl::Program *programObject = GetValidProgram(context, program);
3211 if (!programObject)
Shannon Woods4de4fd62014-11-07 16:22:02 -05003212 {
3213 return false;
3214 }
3215
Jamie Madill0063c512014-08-25 15:47:53 -04003216 if (!programObject || !programObject->isLinked())
3217 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003218 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Geoff Langb1196682014-07-23 13:47:29 -04003219 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003220 }
3221
Geoff Lang7dd2e102014-11-10 15:19:26 -05003222 if (!programObject->isValidUniformLocation(location))
Jamie Madill549c7fd2014-08-25 15:47:56 -04003223 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003224 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04003225 return false;
Jamie Madill549c7fd2014-08-25 15:47:56 -04003226 }
3227
Jamie Madill0063c512014-08-25 15:47:53 -04003228 return true;
3229}
3230
Geoff Langf41d0ee2016-10-07 13:04:23 -04003231static bool ValidateSizedGetUniform(Context *context,
3232 GLuint program,
3233 GLint location,
3234 GLsizei bufSize,
3235 GLsizei *length)
Jamie Madill78f41802014-08-25 15:47:55 -04003236{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003237 if (length)
3238 {
3239 *length = 0;
3240 }
3241
Jamie Madill78f41802014-08-25 15:47:55 -04003242 if (!ValidateGetUniformBase(context, program, location))
Jamie Madill0063c512014-08-25 15:47:53 -04003243 {
Jamie Madill78f41802014-08-25 15:47:55 -04003244 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003245 }
3246
Geoff Langf41d0ee2016-10-07 13:04:23 -04003247 if (bufSize < 0)
3248 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003249 context->handleError(InvalidValue() << "bufSize cannot be negative.");
Geoff Langf41d0ee2016-10-07 13:04:23 -04003250 return false;
3251 }
3252
Jamie Madilla502c742014-08-28 17:19:13 -04003253 gl::Program *programObject = context->getProgram(program);
3254 ASSERT(programObject);
Jamie Madill0063c512014-08-25 15:47:53 -04003255
Jamie Madill78f41802014-08-25 15:47:55 -04003256 // sized queries -- ensure the provided buffer is large enough
Jamie Madill62d31cb2015-09-11 13:25:51 -04003257 const LinkedUniform &uniform = programObject->getUniformByLocation(location);
He Yunchaoced53ae2016-11-29 15:00:51 +08003258 size_t requiredBytes = VariableExternalSize(uniform.type);
Jamie Madill78f41802014-08-25 15:47:55 -04003259 if (static_cast<size_t>(bufSize) < requiredBytes)
Jamie Madill0063c512014-08-25 15:47:53 -04003260 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003261 context->handleError(InvalidOperation()
3262 << "bufSize of at least " << requiredBytes << " is required.");
Geoff Langb1196682014-07-23 13:47:29 -04003263 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003264 }
3265
Geoff Langf41d0ee2016-10-07 13:04:23 -04003266 if (length)
3267 {
Geoff Lang94177fb2016-11-14 16:12:26 -05003268 *length = VariableComponentCount(uniform.type);
Geoff Langf41d0ee2016-10-07 13:04:23 -04003269 }
3270
Jamie Madill0063c512014-08-25 15:47:53 -04003271 return true;
3272}
3273
He Yunchaoced53ae2016-11-29 15:00:51 +08003274bool ValidateGetnUniformfvEXT(Context *context,
3275 GLuint program,
3276 GLint location,
3277 GLsizei bufSize,
3278 GLfloat *params)
Jamie Madill0063c512014-08-25 15:47:53 -04003279{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003280 return ValidateSizedGetUniform(context, program, location, bufSize, nullptr);
Jamie Madill0063c512014-08-25 15:47:53 -04003281}
3282
He Yunchaoced53ae2016-11-29 15:00:51 +08003283bool ValidateGetnUniformivEXT(Context *context,
3284 GLuint program,
3285 GLint location,
3286 GLsizei bufSize,
3287 GLint *params)
Jamie Madill0063c512014-08-25 15:47:53 -04003288{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003289 return ValidateSizedGetUniform(context, program, location, bufSize, nullptr);
3290}
3291
3292bool ValidateGetUniformfvRobustANGLE(Context *context,
3293 GLuint program,
3294 GLint location,
3295 GLsizei bufSize,
3296 GLsizei *length,
3297 GLfloat *params)
3298{
3299 if (!ValidateRobustEntryPoint(context, bufSize))
3300 {
3301 return false;
3302 }
3303
3304 // bufSize is validated in ValidateSizedGetUniform
3305 return ValidateSizedGetUniform(context, program, location, bufSize, length);
3306}
3307
3308bool ValidateGetUniformivRobustANGLE(Context *context,
3309 GLuint program,
3310 GLint location,
3311 GLsizei bufSize,
3312 GLsizei *length,
3313 GLint *params)
3314{
3315 if (!ValidateRobustEntryPoint(context, bufSize))
3316 {
3317 return false;
3318 }
3319
3320 // bufSize is validated in ValidateSizedGetUniform
3321 return ValidateSizedGetUniform(context, program, location, bufSize, length);
3322}
3323
3324bool ValidateGetUniformuivRobustANGLE(Context *context,
3325 GLuint program,
3326 GLint location,
3327 GLsizei bufSize,
3328 GLsizei *length,
3329 GLuint *params)
3330{
3331 if (!ValidateRobustEntryPoint(context, bufSize))
3332 {
3333 return false;
3334 }
3335
3336 if (context->getClientMajorVersion() < 3)
3337 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003338 context->handleError(InvalidOperation() << "Entry point requires at least OpenGL ES 3.0.");
Geoff Langf41d0ee2016-10-07 13:04:23 -04003339 return false;
3340 }
3341
3342 // bufSize is validated in ValidateSizedGetUniform
3343 return ValidateSizedGetUniform(context, program, location, bufSize, length);
Jamie Madill0063c512014-08-25 15:47:53 -04003344}
3345
He Yunchaoced53ae2016-11-29 15:00:51 +08003346bool ValidateDiscardFramebufferBase(Context *context,
3347 GLenum target,
3348 GLsizei numAttachments,
3349 const GLenum *attachments,
3350 bool defaultFramebuffer)
Austin Kinross08332632015-05-05 13:35:47 -07003351{
3352 if (numAttachments < 0)
3353 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003354 context->handleError(InvalidValue() << "numAttachments must not be less than zero");
Austin Kinross08332632015-05-05 13:35:47 -07003355 return false;
3356 }
3357
3358 for (GLsizei i = 0; i < numAttachments; ++i)
3359 {
Olli Etuaho84c9f592016-03-09 14:37:25 +02003360 if (attachments[i] >= GL_COLOR_ATTACHMENT0 && attachments[i] <= GL_COLOR_ATTACHMENT31)
Austin Kinross08332632015-05-05 13:35:47 -07003361 {
3362 if (defaultFramebuffer)
3363 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003364 context->handleError(InvalidEnum()
3365 << "Invalid attachment when the default framebuffer is bound");
Austin Kinross08332632015-05-05 13:35:47 -07003366 return false;
3367 }
3368
3369 if (attachments[i] >= GL_COLOR_ATTACHMENT0 + context->getCaps().maxColorAttachments)
3370 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003371 context->handleError(InvalidOperation() << "Requested color attachment is "
3372 "greater than the maximum supported "
3373 "color attachments");
Austin Kinross08332632015-05-05 13:35:47 -07003374 return false;
3375 }
3376 }
3377 else
3378 {
3379 switch (attachments[i])
3380 {
He Yunchaoced53ae2016-11-29 15:00:51 +08003381 case GL_DEPTH_ATTACHMENT:
3382 case GL_STENCIL_ATTACHMENT:
3383 case GL_DEPTH_STENCIL_ATTACHMENT:
3384 if (defaultFramebuffer)
3385 {
3386 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003387 InvalidEnum()
3388 << "Invalid attachment when the default framebuffer is bound");
He Yunchaoced53ae2016-11-29 15:00:51 +08003389 return false;
3390 }
3391 break;
3392 case GL_COLOR:
3393 case GL_DEPTH:
3394 case GL_STENCIL:
3395 if (!defaultFramebuffer)
3396 {
3397 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003398 InvalidEnum()
3399 << "Invalid attachment when the default framebuffer is not bound");
He Yunchaoced53ae2016-11-29 15:00:51 +08003400 return false;
3401 }
3402 break;
3403 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003404 context->handleError(InvalidEnum() << "Invalid attachment");
Austin Kinross08332632015-05-05 13:35:47 -07003405 return false;
Austin Kinross08332632015-05-05 13:35:47 -07003406 }
3407 }
3408 }
3409
3410 return true;
3411}
3412
Austin Kinross6ee1e782015-05-29 17:05:37 -07003413bool ValidateInsertEventMarkerEXT(Context *context, GLsizei length, const char *marker)
3414{
3415 // Note that debug marker calls must not set error state
3416
3417 if (length < 0)
3418 {
3419 return false;
3420 }
3421
3422 if (marker == nullptr)
3423 {
3424 return false;
3425 }
3426
3427 return true;
3428}
3429
3430bool ValidatePushGroupMarkerEXT(Context *context, GLsizei length, const char *marker)
3431{
3432 // Note that debug marker calls must not set error state
3433
3434 if (length < 0)
3435 {
3436 return false;
3437 }
3438
3439 if (length > 0 && marker == nullptr)
3440 {
3441 return false;
3442 }
3443
3444 return true;
3445}
3446
Geoff Langdcab33b2015-07-21 13:03:16 -04003447bool ValidateEGLImageTargetTexture2DOES(Context *context,
Geoff Langdcab33b2015-07-21 13:03:16 -04003448 GLenum target,
3449 egl::Image *image)
3450{
Geoff Langa8406172015-07-21 16:53:39 -04003451 if (!context->getExtensions().eglImage && !context->getExtensions().eglImageExternal)
3452 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003453 context->handleError(InvalidOperation());
Geoff Langa8406172015-07-21 16:53:39 -04003454 return false;
3455 }
3456
3457 switch (target)
3458 {
3459 case GL_TEXTURE_2D:
Geoff Langb66a9092016-05-16 15:59:14 -04003460 if (!context->getExtensions().eglImage)
3461 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003462 context->handleError(InvalidEnum()
3463 << "GL_TEXTURE_2D texture target requires GL_OES_EGL_image.");
Geoff Langb66a9092016-05-16 15:59:14 -04003464 }
3465 break;
3466
3467 case GL_TEXTURE_EXTERNAL_OES:
3468 if (!context->getExtensions().eglImageExternal)
3469 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003470 context->handleError(InvalidEnum() << "GL_TEXTURE_EXTERNAL_OES texture target "
3471 "requires GL_OES_EGL_image_external.");
Geoff Langb66a9092016-05-16 15:59:14 -04003472 }
Geoff Langa8406172015-07-21 16:53:39 -04003473 break;
3474
3475 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003476 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Geoff Langa8406172015-07-21 16:53:39 -04003477 return false;
3478 }
3479
Jamie Madill61e16b42017-06-19 11:13:23 -04003480 ASSERT(context->getCurrentDisplay());
3481 if (!context->getCurrentDisplay()->isValidImage(image))
Geoff Langa8406172015-07-21 16:53:39 -04003482 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003483 context->handleError(InvalidValue() << "EGL image is not valid.");
Geoff Langa8406172015-07-21 16:53:39 -04003484 return false;
3485 }
3486
3487 if (image->getSamples() > 0)
3488 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003489 context->handleError(InvalidOperation()
3490 << "cannot create a 2D texture from a multisampled EGL image.");
Geoff Langa8406172015-07-21 16:53:39 -04003491 return false;
3492 }
3493
Geoff Langca271392017-04-05 12:30:00 -04003494 const TextureCaps &textureCaps =
3495 context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat);
Geoff Langa8406172015-07-21 16:53:39 -04003496 if (!textureCaps.texturable)
3497 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003498 context->handleError(InvalidOperation()
3499 << "EGL image internal format is not supported as a texture.");
Geoff Langa8406172015-07-21 16:53:39 -04003500 return false;
3501 }
3502
Geoff Langdcab33b2015-07-21 13:03:16 -04003503 return true;
3504}
3505
3506bool ValidateEGLImageTargetRenderbufferStorageOES(Context *context,
Geoff Langdcab33b2015-07-21 13:03:16 -04003507 GLenum target,
3508 egl::Image *image)
3509{
Geoff Langa8406172015-07-21 16:53:39 -04003510 if (!context->getExtensions().eglImage)
3511 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003512 context->handleError(InvalidOperation());
Geoff Langa8406172015-07-21 16:53:39 -04003513 return false;
3514 }
3515
3516 switch (target)
3517 {
3518 case GL_RENDERBUFFER:
3519 break;
3520
3521 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003522 context->handleError(InvalidEnum() << "invalid renderbuffer target.");
Geoff Langa8406172015-07-21 16:53:39 -04003523 return false;
3524 }
3525
Jamie Madill61e16b42017-06-19 11:13:23 -04003526 ASSERT(context->getCurrentDisplay());
3527 if (!context->getCurrentDisplay()->isValidImage(image))
Geoff Langa8406172015-07-21 16:53:39 -04003528 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003529 context->handleError(InvalidValue() << "EGL image is not valid.");
Geoff Langa8406172015-07-21 16:53:39 -04003530 return false;
3531 }
3532
Geoff Langca271392017-04-05 12:30:00 -04003533 const TextureCaps &textureCaps =
3534 context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat);
Geoff Langa8406172015-07-21 16:53:39 -04003535 if (!textureCaps.renderable)
3536 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003537 context->handleError(InvalidOperation()
3538 << "EGL image internal format is not supported as a renderbuffer.");
Geoff Langa8406172015-07-21 16:53:39 -04003539 return false;
3540 }
3541
Geoff Langdcab33b2015-07-21 13:03:16 -04003542 return true;
3543}
Austin Kinrossbc781f32015-10-26 09:27:38 -07003544
3545bool ValidateBindVertexArrayBase(Context *context, GLuint array)
3546{
Geoff Lang36167ab2015-12-07 10:27:14 -05003547 if (!context->isVertexArrayGenerated(array))
Austin Kinrossbc781f32015-10-26 09:27:38 -07003548 {
3549 // The default VAO should always exist
3550 ASSERT(array != 0);
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003551 context->handleError(InvalidOperation());
Austin Kinrossbc781f32015-10-26 09:27:38 -07003552 return false;
3553 }
3554
3555 return true;
3556}
3557
Geoff Langc5629752015-12-07 16:29:04 -05003558bool ValidateProgramBinaryBase(Context *context,
3559 GLuint program,
3560 GLenum binaryFormat,
3561 const void *binary,
3562 GLint length)
3563{
3564 Program *programObject = GetValidProgram(context, program);
3565 if (programObject == nullptr)
3566 {
3567 return false;
3568 }
3569
3570 const std::vector<GLenum> &programBinaryFormats = context->getCaps().programBinaryFormats;
3571 if (std::find(programBinaryFormats.begin(), programBinaryFormats.end(), binaryFormat) ==
3572 programBinaryFormats.end())
3573 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003574 context->handleError(InvalidEnum() << "Program binary format is not valid.");
Geoff Langc5629752015-12-07 16:29:04 -05003575 return false;
3576 }
3577
Olli Etuahoc3e55a42016-03-09 16:29:18 +02003578 if (context->hasActiveTransformFeedback(program))
3579 {
3580 // ES 3.0.4 section 2.15 page 91
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003581 context->handleError(InvalidOperation() << "Cannot change program binary while program "
3582 "is associated with an active transform "
3583 "feedback object.");
Olli Etuahoc3e55a42016-03-09 16:29:18 +02003584 return false;
3585 }
3586
Geoff Langc5629752015-12-07 16:29:04 -05003587 return true;
3588}
3589
3590bool ValidateGetProgramBinaryBase(Context *context,
3591 GLuint program,
3592 GLsizei bufSize,
3593 GLsizei *length,
3594 GLenum *binaryFormat,
3595 void *binary)
3596{
3597 Program *programObject = GetValidProgram(context, program);
3598 if (programObject == nullptr)
3599 {
3600 return false;
3601 }
3602
3603 if (!programObject->isLinked())
3604 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003605 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Geoff Langc5629752015-12-07 16:29:04 -05003606 return false;
3607 }
3608
Jamie Madilla7d12dc2016-12-13 15:08:19 -05003609 if (context->getCaps().programBinaryFormats.empty())
3610 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003611 context->handleError(InvalidOperation() << "No program binary formats supported.");
Jamie Madilla7d12dc2016-12-13 15:08:19 -05003612 return false;
3613 }
3614
Geoff Langc5629752015-12-07 16:29:04 -05003615 return true;
3616}
Jamie Madillc29968b2016-01-20 11:17:23 -05003617
Jamie Madillc29968b2016-01-20 11:17:23 -05003618bool ValidateDrawBuffersBase(ValidationContext *context, GLsizei n, const GLenum *bufs)
3619{
3620 // INVALID_VALUE is generated if n is negative or greater than value of MAX_DRAW_BUFFERS
3621 if (n < 0 || static_cast<GLuint>(n) > context->getCaps().maxDrawBuffers)
3622 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003623 context->handleError(InvalidValue()
3624 << "n must be non-negative and no greater than MAX_DRAW_BUFFERS");
Jamie Madillc29968b2016-01-20 11:17:23 -05003625 return false;
3626 }
3627
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003628 ASSERT(context->getGLState().getDrawFramebuffer());
3629 GLuint frameBufferId = context->getGLState().getDrawFramebuffer()->id();
Jamie Madillc29968b2016-01-20 11:17:23 -05003630 GLuint maxColorAttachment = GL_COLOR_ATTACHMENT0_EXT + context->getCaps().maxColorAttachments;
3631
3632 // This should come first before the check for the default frame buffer
3633 // because when we switch to ES3.1+, invalid enums will return INVALID_ENUM
3634 // rather than INVALID_OPERATION
3635 for (int colorAttachment = 0; colorAttachment < n; colorAttachment++)
3636 {
3637 const GLenum attachment = GL_COLOR_ATTACHMENT0_EXT + colorAttachment;
3638
3639 if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != GL_BACK &&
Olli Etuaho84c9f592016-03-09 14:37:25 +02003640 (bufs[colorAttachment] < GL_COLOR_ATTACHMENT0 ||
3641 bufs[colorAttachment] > GL_COLOR_ATTACHMENT31))
Jamie Madillc29968b2016-01-20 11:17:23 -05003642 {
3643 // Value in bufs is not NONE, BACK, or GL_COLOR_ATTACHMENTi
Olli Etuaho84c9f592016-03-09 14:37:25 +02003644 // The 3.0.4 spec says to generate GL_INVALID_OPERATION here, but this
3645 // was changed to GL_INVALID_ENUM in 3.1, which dEQP also expects.
3646 // 3.1 is still a bit ambiguous about the error, but future specs are
3647 // expected to clarify that GL_INVALID_ENUM is the correct error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003648 context->handleError(InvalidEnum() << "Invalid buffer value");
Olli Etuaho84c9f592016-03-09 14:37:25 +02003649 return false;
3650 }
3651 else if (bufs[colorAttachment] >= maxColorAttachment)
3652 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003653 context->handleError(InvalidOperation()
3654 << "Buffer value is greater than MAX_DRAW_BUFFERS");
Jamie Madillc29968b2016-01-20 11:17:23 -05003655 return false;
3656 }
3657 else if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != attachment &&
3658 frameBufferId != 0)
3659 {
3660 // INVALID_OPERATION-GL is bound to buffer and ith argument
3661 // is not COLOR_ATTACHMENTi or NONE
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003662 context->handleError(InvalidOperation()
3663 << "Ith value does not match COLOR_ATTACHMENTi or NONE");
Jamie Madillc29968b2016-01-20 11:17:23 -05003664 return false;
3665 }
3666 }
3667
3668 // INVALID_OPERATION is generated if GL is bound to the default framebuffer
3669 // and n is not 1 or bufs is bound to value other than BACK and NONE
3670 if (frameBufferId == 0)
3671 {
3672 if (n != 1)
3673 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003674 context->handleError(InvalidOperation()
3675 << "n must be 1 when GL is bound to the default framebuffer");
Jamie Madillc29968b2016-01-20 11:17:23 -05003676 return false;
3677 }
3678
3679 if (bufs[0] != GL_NONE && bufs[0] != GL_BACK)
3680 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003681 context->handleError(
3682 InvalidOperation()
3683 << "Only NONE or BACK are valid values when drawing to the default framebuffer");
Jamie Madillc29968b2016-01-20 11:17:23 -05003684 return false;
3685 }
3686 }
3687
3688 return true;
3689}
3690
Geoff Lang496c02d2016-10-20 11:38:11 -07003691bool ValidateGetBufferPointervBase(Context *context,
3692 GLenum target,
3693 GLenum pname,
3694 GLsizei *length,
3695 void **params)
Olli Etuaho4f667482016-03-30 15:56:35 +03003696{
Geoff Lang496c02d2016-10-20 11:38:11 -07003697 if (length)
3698 {
3699 *length = 0;
3700 }
3701
3702 if (context->getClientMajorVersion() < 3 && !context->getExtensions().mapBuffer)
3703 {
3704 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003705 InvalidOperation()
3706 << "Context does not support OpenGL ES 3.0 or GL_OES_mapbuffer is not enabled.");
Geoff Lang496c02d2016-10-20 11:38:11 -07003707 return false;
3708 }
3709
Olli Etuaho4f667482016-03-30 15:56:35 +03003710 if (!ValidBufferTarget(context, target))
3711 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003712 context->handleError(InvalidEnum() << "Buffer target not valid: 0x" << std::hex
3713 << std::uppercase << target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003714 return false;
3715 }
3716
Geoff Lang496c02d2016-10-20 11:38:11 -07003717 switch (pname)
Olli Etuaho4f667482016-03-30 15:56:35 +03003718 {
Geoff Lang496c02d2016-10-20 11:38:11 -07003719 case GL_BUFFER_MAP_POINTER:
3720 break;
Olli Etuaho4f667482016-03-30 15:56:35 +03003721
Geoff Lang496c02d2016-10-20 11:38:11 -07003722 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003723 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang496c02d2016-10-20 11:38:11 -07003724 return false;
3725 }
Olli Etuaho4f667482016-03-30 15:56:35 +03003726
3727 // GLES 3.0 section 2.10.1: "Attempts to attempts to modify or query buffer object state for a
3728 // target bound to zero generate an INVALID_OPERATION error."
3729 // GLES 3.1 section 6.6 explicitly specifies this error.
Geoff Lang496c02d2016-10-20 11:38:11 -07003730 if (context->getGLState().getTargetBuffer(target) == nullptr)
Olli Etuaho4f667482016-03-30 15:56:35 +03003731 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003732 context->handleError(InvalidOperation()
3733 << "Can not get pointer for reserved buffer name zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003734 return false;
3735 }
3736
Geoff Lang496c02d2016-10-20 11:38:11 -07003737 if (length)
3738 {
3739 *length = 1;
3740 }
3741
Olli Etuaho4f667482016-03-30 15:56:35 +03003742 return true;
3743}
3744
3745bool ValidateUnmapBufferBase(Context *context, GLenum target)
3746{
3747 if (!ValidBufferTarget(context, target))
3748 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003749 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003750 return false;
3751 }
3752
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003753 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003754
3755 if (buffer == nullptr || !buffer->isMapped())
3756 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003757 context->handleError(InvalidOperation() << "Buffer not mapped.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003758 return false;
3759 }
3760
3761 return true;
3762}
3763
3764bool ValidateMapBufferRangeBase(Context *context,
3765 GLenum target,
3766 GLintptr offset,
3767 GLsizeiptr length,
3768 GLbitfield access)
3769{
3770 if (!ValidBufferTarget(context, target))
3771 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003772 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003773 return false;
3774 }
3775
Brandon Jones6cad5662017-06-14 13:25:13 -07003776 if (offset < 0)
Olli Etuaho4f667482016-03-30 15:56:35 +03003777 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003778 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
3779 return false;
3780 }
3781
3782 if (length < 0)
3783 {
3784 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength);
Olli Etuaho4f667482016-03-30 15:56:35 +03003785 return false;
3786 }
3787
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003788 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003789
3790 if (!buffer)
3791 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003792 context->handleError(InvalidOperation() << "Attempted to map buffer object zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003793 return false;
3794 }
3795
3796 // Check for buffer overflow
Jamie Madille2e406c2016-06-02 13:04:10 -04003797 CheckedNumeric<size_t> checkedOffset(offset);
3798 auto checkedSize = checkedOffset + length;
Olli Etuaho4f667482016-03-30 15:56:35 +03003799
Jamie Madille2e406c2016-06-02 13:04:10 -04003800 if (!checkedSize.IsValid() || checkedSize.ValueOrDie() > static_cast<size_t>(buffer->getSize()))
Olli Etuaho4f667482016-03-30 15:56:35 +03003801 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003802 context->handleError(InvalidValue() << "Mapped range does not fit into buffer dimensions.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003803 return false;
3804 }
3805
3806 // Check for invalid bits in the mask
3807 GLbitfield allAccessBits = GL_MAP_READ_BIT | GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_RANGE_BIT |
3808 GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_FLUSH_EXPLICIT_BIT |
3809 GL_MAP_UNSYNCHRONIZED_BIT;
3810
3811 if (access & ~(allAccessBits))
3812 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003813 context->handleError(InvalidValue()
3814 << "Invalid access bits: 0x" << std::hex << std::uppercase << access);
Olli Etuaho4f667482016-03-30 15:56:35 +03003815 return false;
3816 }
3817
3818 if (length == 0)
3819 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003820 context->handleError(InvalidOperation() << "Buffer mapping length is zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003821 return false;
3822 }
3823
3824 if (buffer->isMapped())
3825 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003826 context->handleError(InvalidOperation() << "Buffer is already mapped.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003827 return false;
3828 }
3829
3830 // Check for invalid bit combinations
3831 if ((access & (GL_MAP_READ_BIT | GL_MAP_WRITE_BIT)) == 0)
3832 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003833 context->handleError(InvalidOperation()
3834 << "Need to map buffer for either reading or writing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003835 return false;
3836 }
3837
3838 GLbitfield writeOnlyBits =
3839 GL_MAP_INVALIDATE_RANGE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_UNSYNCHRONIZED_BIT;
3840
3841 if ((access & GL_MAP_READ_BIT) != 0 && (access & writeOnlyBits) != 0)
3842 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003843 context->handleError(InvalidOperation()
3844 << "Invalid access bits when mapping buffer for reading: 0x"
3845 << std::hex << std::uppercase << access);
Olli Etuaho4f667482016-03-30 15:56:35 +03003846 return false;
3847 }
3848
3849 if ((access & GL_MAP_WRITE_BIT) == 0 && (access & GL_MAP_FLUSH_EXPLICIT_BIT) != 0)
3850 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003851 context->handleError(
3852 InvalidOperation()
3853 << "The explicit flushing bit may only be set if the buffer is mapped for writing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003854 return false;
3855 }
3856 return true;
3857}
3858
3859bool ValidateFlushMappedBufferRangeBase(Context *context,
3860 GLenum target,
3861 GLintptr offset,
3862 GLsizeiptr length)
3863{
Brandon Jones6cad5662017-06-14 13:25:13 -07003864 if (offset < 0)
Olli Etuaho4f667482016-03-30 15:56:35 +03003865 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003866 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
3867 return false;
3868 }
3869
3870 if (length < 0)
3871 {
3872 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength);
Olli Etuaho4f667482016-03-30 15:56:35 +03003873 return false;
3874 }
3875
3876 if (!ValidBufferTarget(context, target))
3877 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003878 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003879 return false;
3880 }
3881
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003882 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003883
3884 if (buffer == nullptr)
3885 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003886 context->handleError(InvalidOperation() << "Attempted to flush buffer object zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003887 return false;
3888 }
3889
3890 if (!buffer->isMapped() || (buffer->getAccessFlags() & GL_MAP_FLUSH_EXPLICIT_BIT) == 0)
3891 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003892 context->handleError(InvalidOperation()
3893 << "Attempted to flush a buffer not mapped for explicit flushing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003894 return false;
3895 }
3896
3897 // Check for buffer overflow
Jamie Madille2e406c2016-06-02 13:04:10 -04003898 CheckedNumeric<size_t> checkedOffset(offset);
3899 auto checkedSize = checkedOffset + length;
Olli Etuaho4f667482016-03-30 15:56:35 +03003900
Jamie Madille2e406c2016-06-02 13:04:10 -04003901 if (!checkedSize.IsValid() ||
3902 checkedSize.ValueOrDie() > static_cast<size_t>(buffer->getMapLength()))
Olli Etuaho4f667482016-03-30 15:56:35 +03003903 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003904 context->handleError(InvalidValue()
3905 << "Flushed range does not fit into buffer mapping dimensions.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003906 return false;
3907 }
3908
3909 return true;
3910}
3911
Olli Etuaho41997e72016-03-10 13:38:39 +02003912bool ValidateGenOrDelete(Context *context, GLint n)
3913{
3914 if (n < 0)
3915 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003916 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Olli Etuaho41997e72016-03-10 13:38:39 +02003917 return false;
3918 }
3919 return true;
3920}
3921
Geoff Langff5b2d52016-09-07 11:32:23 -04003922bool ValidateRobustEntryPoint(ValidationContext *context, GLsizei bufSize)
3923{
3924 if (!context->getExtensions().robustClientMemory)
3925 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003926 context->handleError(InvalidOperation()
3927 << "GL_ANGLE_robust_client_memory is not available.");
Geoff Langff5b2d52016-09-07 11:32:23 -04003928 return false;
3929 }
3930
3931 if (bufSize < 0)
3932 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003933 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Geoff Langff5b2d52016-09-07 11:32:23 -04003934 return false;
3935 }
3936
3937 return true;
3938}
3939
Geoff Lang2e43dbb2016-10-14 12:27:35 -04003940bool ValidateRobustBufferSize(ValidationContext *context, GLsizei bufSize, GLsizei numParams)
3941{
3942 if (bufSize < numParams)
3943 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003944 context->handleError(InvalidOperation() << numParams << " parameters are required but "
3945 << bufSize << " were provided.");
Geoff Lang2e43dbb2016-10-14 12:27:35 -04003946 return false;
3947 }
3948
3949 return true;
3950}
3951
Jamie Madillbe849e42017-05-02 15:49:00 -04003952bool ValidateGetFramebufferAttachmentParameterivBase(ValidationContext *context,
3953 GLenum target,
3954 GLenum attachment,
3955 GLenum pname,
3956 GLsizei *numParams)
Geoff Langff5b2d52016-09-07 11:32:23 -04003957{
Geoff Langff5b2d52016-09-07 11:32:23 -04003958 if (!ValidFramebufferTarget(target))
3959 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003960 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003961 return false;
3962 }
3963
3964 int clientVersion = context->getClientMajorVersion();
3965
3966 switch (pname)
3967 {
3968 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
3969 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
3970 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL:
3971 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE:
3972 break;
3973
Martin Radeve5285d22017-07-14 16:23:53 +03003974 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_NUM_VIEWS_ANGLE:
3975 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_MULTIVIEW_LAYOUT_ANGLE:
3976 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_BASE_VIEW_INDEX_ANGLE:
3977 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE:
3978 if (clientVersion < 3 || !context->getExtensions().multiview)
3979 {
3980 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
3981 return false;
3982 }
3983 break;
3984
Geoff Langff5b2d52016-09-07 11:32:23 -04003985 case GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING:
3986 if (clientVersion < 3 && !context->getExtensions().sRGB)
3987 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003988 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003989 return false;
3990 }
3991 break;
3992
3993 case GL_FRAMEBUFFER_ATTACHMENT_RED_SIZE:
3994 case GL_FRAMEBUFFER_ATTACHMENT_GREEN_SIZE:
3995 case GL_FRAMEBUFFER_ATTACHMENT_BLUE_SIZE:
3996 case GL_FRAMEBUFFER_ATTACHMENT_ALPHA_SIZE:
3997 case GL_FRAMEBUFFER_ATTACHMENT_DEPTH_SIZE:
3998 case GL_FRAMEBUFFER_ATTACHMENT_STENCIL_SIZE:
3999 case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:
4000 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:
4001 if (clientVersion < 3)
4002 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004003 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004004 return false;
4005 }
4006 break;
4007
4008 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004009 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004010 return false;
4011 }
4012
4013 // Determine if the attachment is a valid enum
4014 switch (attachment)
4015 {
4016 case GL_BACK:
4017 case GL_FRONT:
4018 case GL_DEPTH:
4019 case GL_STENCIL:
4020 case GL_DEPTH_STENCIL_ATTACHMENT:
4021 if (clientVersion < 3)
4022 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004023 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004024 return false;
4025 }
4026 break;
4027
4028 case GL_DEPTH_ATTACHMENT:
4029 case GL_STENCIL_ATTACHMENT:
4030 break;
4031
4032 default:
4033 if (attachment < GL_COLOR_ATTACHMENT0_EXT ||
4034 (attachment - GL_COLOR_ATTACHMENT0_EXT) >= context->getCaps().maxColorAttachments)
4035 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004036 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004037 return false;
4038 }
4039 break;
4040 }
4041
4042 const Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
4043 ASSERT(framebuffer);
4044
4045 if (framebuffer->id() == 0)
4046 {
4047 if (clientVersion < 3)
4048 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004049 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langff5b2d52016-09-07 11:32:23 -04004050 return false;
4051 }
4052
4053 switch (attachment)
4054 {
4055 case GL_BACK:
4056 case GL_DEPTH:
4057 case GL_STENCIL:
4058 break;
4059
4060 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004061 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FramebufferInvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004062 return false;
4063 }
4064 }
4065 else
4066 {
4067 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
4068 {
4069 // Valid attachment query
4070 }
4071 else
4072 {
4073 switch (attachment)
4074 {
4075 case GL_DEPTH_ATTACHMENT:
4076 case GL_STENCIL_ATTACHMENT:
4077 break;
4078
4079 case GL_DEPTH_STENCIL_ATTACHMENT:
4080 if (!framebuffer->hasValidDepthStencil())
4081 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004082 context->handleError(InvalidOperation());
Geoff Langff5b2d52016-09-07 11:32:23 -04004083 return false;
4084 }
4085 break;
4086
4087 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004088 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FramebufferInvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004089 return false;
4090 }
4091 }
4092 }
4093
4094 const FramebufferAttachment *attachmentObject = framebuffer->getAttachment(attachment);
4095 if (attachmentObject)
4096 {
4097 ASSERT(attachmentObject->type() == GL_RENDERBUFFER ||
4098 attachmentObject->type() == GL_TEXTURE ||
4099 attachmentObject->type() == GL_FRAMEBUFFER_DEFAULT);
4100
4101 switch (pname)
4102 {
4103 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
4104 if (attachmentObject->type() != GL_RENDERBUFFER &&
4105 attachmentObject->type() != GL_TEXTURE)
4106 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004107 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004108 return false;
4109 }
4110 break;
4111
4112 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL:
4113 if (attachmentObject->type() != GL_TEXTURE)
4114 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004115 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004116 return false;
4117 }
4118 break;
4119
4120 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE:
4121 if (attachmentObject->type() != GL_TEXTURE)
4122 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004123 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004124 return false;
4125 }
4126 break;
4127
4128 case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:
4129 if (attachment == GL_DEPTH_STENCIL_ATTACHMENT)
4130 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004131 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FramebufferInvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004132 return false;
4133 }
4134 break;
4135
4136 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:
4137 if (attachmentObject->type() != GL_TEXTURE)
4138 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004139 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004140 return false;
4141 }
4142 break;
4143
4144 default:
4145 break;
4146 }
4147 }
4148 else
4149 {
4150 // ES 2.0.25 spec pg 127 states that if the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE
4151 // is NONE, then querying any other pname will generate INVALID_ENUM.
4152
4153 // ES 3.0.2 spec pg 235 states that if the attachment type is none,
4154 // GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME will return zero and be an
4155 // INVALID_OPERATION for all other pnames
4156
4157 switch (pname)
4158 {
4159 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
4160 break;
4161
4162 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
4163 if (clientVersion < 3)
4164 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004165 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
4166 InvalidRenderbufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004167 return false;
4168 }
4169 break;
4170
4171 default:
4172 if (clientVersion < 3)
4173 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004174 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
4175 InvalidRenderbufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004176 return false;
4177 }
4178 else
4179 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004180 ANGLE_VALIDATION_ERR(context, InvalidOperation(),
4181 InvalidRenderbufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004182 return false;
4183 }
4184 }
4185 }
4186
Martin Radeve5285d22017-07-14 16:23:53 +03004187 if (numParams)
4188 {
4189 if (pname == GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE)
4190 {
4191 // Only when the viewport offsets are queried we can have a varying number of output
4192 // parameters.
4193 const int numViews = attachmentObject ? attachmentObject->getNumViews() : 1;
4194 *numParams = numViews * 2;
4195 }
4196 else
4197 {
4198 // For all other queries we can have only one output parameter.
4199 *numParams = 1;
4200 }
4201 }
4202
Geoff Langff5b2d52016-09-07 11:32:23 -04004203 return true;
4204}
4205
4206bool ValidateGetFramebufferAttachmentParameterivRobustANGLE(ValidationContext *context,
4207 GLenum target,
4208 GLenum attachment,
4209 GLenum pname,
4210 GLsizei bufSize,
4211 GLsizei *numParams)
4212{
4213 if (!ValidateRobustEntryPoint(context, bufSize))
4214 {
4215 return false;
4216 }
4217
Jamie Madillbe849e42017-05-02 15:49:00 -04004218 if (!ValidateGetFramebufferAttachmentParameterivBase(context, target, attachment, pname,
4219 numParams))
Geoff Langff5b2d52016-09-07 11:32:23 -04004220 {
4221 return false;
4222 }
4223
4224 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
4225 {
4226 return false;
4227 }
4228
4229 return true;
4230}
4231
Geoff Langff5b2d52016-09-07 11:32:23 -04004232bool ValidateGetBufferParameterivRobustANGLE(ValidationContext *context,
4233 GLenum target,
4234 GLenum pname,
4235 GLsizei bufSize,
Geoff Langebebe1c2016-10-14 12:01:31 -04004236 GLsizei *length,
4237 GLint *params)
Geoff Langff5b2d52016-09-07 11:32:23 -04004238{
4239 if (!ValidateRobustEntryPoint(context, bufSize))
4240 {
4241 return false;
4242 }
4243
Geoff Langebebe1c2016-10-14 12:01:31 -04004244 if (!ValidateGetBufferParameterBase(context, target, pname, false, length))
Geoff Langff5b2d52016-09-07 11:32:23 -04004245 {
4246 return false;
4247 }
4248
Geoff Langebebe1c2016-10-14 12:01:31 -04004249 if (!ValidateRobustBufferSize(context, bufSize, *length))
4250 {
4251 return false;
4252 }
4253
4254 return true;
4255}
4256
4257bool ValidateGetBufferParameteri64v(ValidationContext *context,
4258 GLenum target,
4259 GLenum pname,
4260 GLint64 *params)
4261{
4262 return ValidateGetBufferParameterBase(context, target, pname, false, nullptr);
4263}
4264
4265bool ValidateGetBufferParameteri64vRobustANGLE(ValidationContext *context,
4266 GLenum target,
4267 GLenum pname,
4268 GLsizei bufSize,
4269 GLsizei *length,
4270 GLint64 *params)
4271{
4272 if (!ValidateRobustEntryPoint(context, bufSize))
4273 {
4274 return false;
4275 }
4276
4277 if (!ValidateGetBufferParameterBase(context, target, pname, false, length))
4278 {
4279 return false;
4280 }
4281
4282 if (!ValidateRobustBufferSize(context, bufSize, *length))
Geoff Langff5b2d52016-09-07 11:32:23 -04004283 {
4284 return false;
4285 }
4286
4287 return true;
4288}
4289
Jamie Madillbe849e42017-05-02 15:49:00 -04004290bool ValidateGetProgramivBase(ValidationContext *context,
4291 GLuint program,
4292 GLenum pname,
4293 GLsizei *numParams)
Geoff Langff5b2d52016-09-07 11:32:23 -04004294{
4295 // Currently, all GetProgramiv queries return 1 parameter
Yunchao He33151a52017-04-13 09:58:17 +08004296 if (numParams)
4297 {
4298 *numParams = 1;
4299 }
Geoff Langff5b2d52016-09-07 11:32:23 -04004300
4301 Program *programObject = GetValidProgram(context, program);
4302 if (!programObject)
4303 {
4304 return false;
4305 }
4306
4307 switch (pname)
4308 {
4309 case GL_DELETE_STATUS:
4310 case GL_LINK_STATUS:
4311 case GL_VALIDATE_STATUS:
4312 case GL_INFO_LOG_LENGTH:
4313 case GL_ATTACHED_SHADERS:
4314 case GL_ACTIVE_ATTRIBUTES:
4315 case GL_ACTIVE_ATTRIBUTE_MAX_LENGTH:
4316 case GL_ACTIVE_UNIFORMS:
4317 case GL_ACTIVE_UNIFORM_MAX_LENGTH:
4318 break;
4319
4320 case GL_PROGRAM_BINARY_LENGTH:
4321 if (context->getClientMajorVersion() < 3 && !context->getExtensions().getProgramBinary)
4322 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004323 context->handleError(InvalidEnum() << "Querying GL_PROGRAM_BINARY_LENGTH "
4324 "requires GL_OES_get_program_binary or "
4325 "ES 3.0.");
Geoff Langff5b2d52016-09-07 11:32:23 -04004326 return false;
4327 }
4328 break;
4329
4330 case GL_ACTIVE_UNIFORM_BLOCKS:
4331 case GL_ACTIVE_UNIFORM_BLOCK_MAX_NAME_LENGTH:
4332 case GL_TRANSFORM_FEEDBACK_BUFFER_MODE:
4333 case GL_TRANSFORM_FEEDBACK_VARYINGS:
4334 case GL_TRANSFORM_FEEDBACK_VARYING_MAX_LENGTH:
4335 case GL_PROGRAM_BINARY_RETRIEVABLE_HINT:
4336 if (context->getClientMajorVersion() < 3)
4337 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004338 context->handleError(InvalidEnum() << "Querying requires at least ES 3.0.");
Geoff Langff5b2d52016-09-07 11:32:23 -04004339 return false;
4340 }
4341 break;
4342
Yunchao He61afff12017-03-14 15:34:03 +08004343 case GL_PROGRAM_SEPARABLE:
4344 if (context->getClientVersion() < Version(3, 1))
4345 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004346 context->handleError(InvalidEnum() << "Querying requires at least ES 3.1.");
Yunchao He61afff12017-03-14 15:34:03 +08004347 return false;
4348 }
4349 break;
4350
Geoff Langff5b2d52016-09-07 11:32:23 -04004351 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004352 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langff5b2d52016-09-07 11:32:23 -04004353 return false;
4354 }
4355
4356 return true;
4357}
4358
4359bool ValidateGetProgramivRobustANGLE(Context *context,
4360 GLuint program,
4361 GLenum pname,
4362 GLsizei bufSize,
4363 GLsizei *numParams)
4364{
4365 if (!ValidateRobustEntryPoint(context, bufSize))
4366 {
4367 return false;
4368 }
4369
Jamie Madillbe849e42017-05-02 15:49:00 -04004370 if (!ValidateGetProgramivBase(context, program, pname, numParams))
Geoff Langff5b2d52016-09-07 11:32:23 -04004371 {
4372 return false;
4373 }
4374
4375 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
4376 {
4377 return false;
4378 }
4379
4380 return true;
4381}
4382
Geoff Lang740d9022016-10-07 11:20:52 -04004383bool ValidateGetRenderbufferParameterivRobustANGLE(Context *context,
4384 GLenum target,
4385 GLenum pname,
4386 GLsizei bufSize,
4387 GLsizei *length,
4388 GLint *params)
4389{
4390 if (!ValidateRobustEntryPoint(context, bufSize))
4391 {
4392 return false;
4393 }
4394
4395 if (!ValidateGetRenderbufferParameterivBase(context, target, pname, length))
4396 {
4397 return false;
4398 }
4399
4400 if (!ValidateRobustBufferSize(context, bufSize, *length))
4401 {
4402 return false;
4403 }
4404
4405 return true;
4406}
4407
Geoff Langd7d0ed32016-10-07 11:33:51 -04004408bool ValidateGetShaderivRobustANGLE(Context *context,
4409 GLuint shader,
4410 GLenum pname,
4411 GLsizei bufSize,
4412 GLsizei *length,
4413 GLint *params)
4414{
4415 if (!ValidateRobustEntryPoint(context, bufSize))
4416 {
4417 return false;
4418 }
4419
4420 if (!ValidateGetShaderivBase(context, shader, pname, length))
4421 {
4422 return false;
4423 }
4424
4425 if (!ValidateRobustBufferSize(context, bufSize, *length))
4426 {
4427 return false;
4428 }
4429
4430 return true;
4431}
4432
Geoff Langc1984ed2016-10-07 12:41:00 -04004433bool ValidateGetTexParameterfvRobustANGLE(Context *context,
4434 GLenum target,
4435 GLenum pname,
4436 GLsizei bufSize,
4437 GLsizei *length,
4438 GLfloat *params)
4439{
4440 if (!ValidateRobustEntryPoint(context, bufSize))
4441 {
4442 return false;
4443 }
4444
4445 if (!ValidateGetTexParameterBase(context, target, pname, length))
4446 {
4447 return false;
4448 }
4449
4450 if (!ValidateRobustBufferSize(context, bufSize, *length))
4451 {
4452 return false;
4453 }
4454
4455 return true;
4456}
4457
Geoff Langc1984ed2016-10-07 12:41:00 -04004458bool ValidateGetTexParameterivRobustANGLE(Context *context,
4459 GLenum target,
4460 GLenum pname,
4461 GLsizei bufSize,
4462 GLsizei *length,
4463 GLint *params)
4464{
4465 if (!ValidateRobustEntryPoint(context, bufSize))
4466 {
4467 return false;
4468 }
4469
4470 if (!ValidateGetTexParameterBase(context, target, pname, length))
4471 {
4472 return false;
4473 }
4474
4475 if (!ValidateRobustBufferSize(context, bufSize, *length))
4476 {
4477 return false;
4478 }
4479
4480 return true;
4481}
4482
Geoff Langc1984ed2016-10-07 12:41:00 -04004483bool ValidateTexParameterfvRobustANGLE(Context *context,
4484 GLenum target,
4485 GLenum pname,
4486 GLsizei bufSize,
4487 const GLfloat *params)
4488{
4489 if (!ValidateRobustEntryPoint(context, bufSize))
4490 {
4491 return false;
4492 }
4493
4494 return ValidateTexParameterBase(context, target, pname, bufSize, params);
4495}
4496
Geoff Langc1984ed2016-10-07 12:41:00 -04004497bool ValidateTexParameterivRobustANGLE(Context *context,
4498 GLenum target,
4499 GLenum pname,
4500 GLsizei bufSize,
4501 const GLint *params)
4502{
4503 if (!ValidateRobustEntryPoint(context, bufSize))
4504 {
4505 return false;
4506 }
4507
4508 return ValidateTexParameterBase(context, target, pname, bufSize, params);
4509}
4510
4511bool ValidateGetSamplerParameterfv(Context *context, GLuint sampler, GLenum pname, GLfloat *params)
4512{
4513 return ValidateGetSamplerParameterBase(context, sampler, pname, nullptr);
4514}
4515
4516bool ValidateGetSamplerParameterfvRobustANGLE(Context *context,
4517 GLuint sampler,
4518 GLenum pname,
4519 GLuint bufSize,
4520 GLsizei *length,
4521 GLfloat *params)
4522{
4523 if (!ValidateRobustEntryPoint(context, bufSize))
4524 {
4525 return false;
4526 }
4527
4528 if (!ValidateGetSamplerParameterBase(context, sampler, pname, length))
4529 {
4530 return false;
4531 }
4532
4533 if (!ValidateRobustBufferSize(context, bufSize, *length))
4534 {
4535 return false;
4536 }
4537
4538 return true;
4539}
4540
4541bool ValidateGetSamplerParameteriv(Context *context, GLuint sampler, GLenum pname, GLint *params)
4542{
4543 return ValidateGetSamplerParameterBase(context, sampler, pname, nullptr);
4544}
4545
4546bool ValidateGetSamplerParameterivRobustANGLE(Context *context,
4547 GLuint sampler,
4548 GLenum pname,
4549 GLuint bufSize,
4550 GLsizei *length,
4551 GLint *params)
4552{
4553 if (!ValidateRobustEntryPoint(context, bufSize))
4554 {
4555 return false;
4556 }
4557
4558 if (!ValidateGetSamplerParameterBase(context, sampler, pname, length))
4559 {
4560 return false;
4561 }
4562
4563 if (!ValidateRobustBufferSize(context, bufSize, *length))
4564 {
4565 return false;
4566 }
4567
4568 return true;
4569}
4570
4571bool ValidateSamplerParameterf(Context *context, GLuint sampler, GLenum pname, GLfloat param)
4572{
4573 return ValidateSamplerParameterBase(context, sampler, pname, -1, &param);
4574}
4575
4576bool ValidateSamplerParameterfv(Context *context,
4577 GLuint sampler,
4578 GLenum pname,
4579 const GLfloat *params)
4580{
4581 return ValidateSamplerParameterBase(context, sampler, pname, -1, params);
4582}
4583
4584bool ValidateSamplerParameterfvRobustANGLE(Context *context,
4585 GLuint sampler,
4586 GLenum pname,
4587 GLsizei bufSize,
4588 const GLfloat *params)
4589{
4590 if (!ValidateRobustEntryPoint(context, bufSize))
4591 {
4592 return false;
4593 }
4594
4595 return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params);
4596}
4597
4598bool ValidateSamplerParameteri(Context *context, GLuint sampler, GLenum pname, GLint param)
4599{
4600 return ValidateSamplerParameterBase(context, sampler, pname, -1, &param);
4601}
4602
4603bool ValidateSamplerParameteriv(Context *context, GLuint sampler, GLenum pname, const GLint *params)
4604{
4605 return ValidateSamplerParameterBase(context, sampler, pname, -1, params);
4606}
4607
4608bool ValidateSamplerParameterivRobustANGLE(Context *context,
4609 GLuint sampler,
4610 GLenum pname,
4611 GLsizei bufSize,
4612 const GLint *params)
4613{
4614 if (!ValidateRobustEntryPoint(context, bufSize))
4615 {
4616 return false;
4617 }
4618
4619 return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params);
4620}
4621
Geoff Lang0b031062016-10-13 14:30:04 -04004622bool ValidateGetVertexAttribfvRobustANGLE(Context *context,
4623 GLuint index,
4624 GLenum pname,
4625 GLsizei bufSize,
4626 GLsizei *length,
4627 GLfloat *params)
4628{
4629 if (!ValidateRobustEntryPoint(context, bufSize))
4630 {
4631 return false;
4632 }
4633
4634 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false))
4635 {
4636 return false;
4637 }
4638
4639 if (!ValidateRobustBufferSize(context, bufSize, *length))
4640 {
4641 return false;
4642 }
4643
4644 return true;
4645}
4646
Geoff Lang0b031062016-10-13 14:30:04 -04004647bool ValidateGetVertexAttribivRobustANGLE(Context *context,
4648 GLuint index,
4649 GLenum pname,
4650 GLsizei bufSize,
4651 GLsizei *length,
4652 GLint *params)
4653{
4654 if (!ValidateRobustEntryPoint(context, bufSize))
4655 {
4656 return false;
4657 }
4658
4659 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false))
4660 {
4661 return false;
4662 }
4663
4664 if (!ValidateRobustBufferSize(context, bufSize, *length))
4665 {
4666 return false;
4667 }
4668
4669 return true;
4670}
4671
Geoff Lang0b031062016-10-13 14:30:04 -04004672bool ValidateGetVertexAttribPointervRobustANGLE(Context *context,
4673 GLuint index,
4674 GLenum pname,
4675 GLsizei bufSize,
4676 GLsizei *length,
4677 void **pointer)
4678{
4679 if (!ValidateRobustEntryPoint(context, bufSize))
4680 {
4681 return false;
4682 }
4683
4684 if (!ValidateGetVertexAttribBase(context, index, pname, length, true, false))
4685 {
4686 return false;
4687 }
4688
4689 if (!ValidateRobustBufferSize(context, bufSize, *length))
4690 {
4691 return false;
4692 }
4693
4694 return true;
4695}
4696
4697bool ValidateGetVertexAttribIiv(Context *context, GLuint index, GLenum pname, GLint *params)
4698{
4699 return ValidateGetVertexAttribBase(context, index, pname, nullptr, false, true);
4700}
4701
4702bool ValidateGetVertexAttribIivRobustANGLE(Context *context,
4703 GLuint index,
4704 GLenum pname,
4705 GLsizei bufSize,
4706 GLsizei *length,
4707 GLint *params)
4708{
4709 if (!ValidateRobustEntryPoint(context, bufSize))
4710 {
4711 return false;
4712 }
4713
4714 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true))
4715 {
4716 return false;
4717 }
4718
4719 if (!ValidateRobustBufferSize(context, bufSize, *length))
4720 {
4721 return false;
4722 }
4723
4724 return true;
4725}
4726
4727bool ValidateGetVertexAttribIuiv(Context *context, GLuint index, GLenum pname, GLuint *params)
4728{
4729 return ValidateGetVertexAttribBase(context, index, pname, nullptr, false, true);
4730}
4731
4732bool ValidateGetVertexAttribIuivRobustANGLE(Context *context,
4733 GLuint index,
4734 GLenum pname,
4735 GLsizei bufSize,
4736 GLsizei *length,
4737 GLuint *params)
4738{
4739 if (!ValidateRobustEntryPoint(context, bufSize))
4740 {
4741 return false;
4742 }
4743
4744 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true))
4745 {
4746 return false;
4747 }
4748
4749 if (!ValidateRobustBufferSize(context, bufSize, *length))
4750 {
4751 return false;
4752 }
4753
4754 return true;
4755}
4756
Geoff Lang6899b872016-10-14 11:30:13 -04004757bool ValidateGetActiveUniformBlockiv(Context *context,
4758 GLuint program,
4759 GLuint uniformBlockIndex,
4760 GLenum pname,
4761 GLint *params)
4762{
4763 return ValidateGetActiveUniformBlockivBase(context, program, uniformBlockIndex, pname, nullptr);
4764}
4765
4766bool ValidateGetActiveUniformBlockivRobustANGLE(Context *context,
4767 GLuint program,
4768 GLuint uniformBlockIndex,
4769 GLenum pname,
4770 GLsizei bufSize,
4771 GLsizei *length,
4772 GLint *params)
4773{
4774 if (!ValidateRobustEntryPoint(context, bufSize))
4775 {
4776 return false;
4777 }
4778
4779 if (!ValidateGetActiveUniformBlockivBase(context, program, uniformBlockIndex, pname, length))
4780 {
4781 return false;
4782 }
4783
4784 if (!ValidateRobustBufferSize(context, bufSize, *length))
4785 {
4786 return false;
4787 }
4788
4789 return true;
4790}
4791
Geoff Lang0a9661f2016-10-20 10:59:20 -07004792bool ValidateGetInternalFormativ(Context *context,
4793 GLenum target,
4794 GLenum internalformat,
4795 GLenum pname,
4796 GLsizei bufSize,
4797 GLint *params)
4798{
4799 return ValidateGetInternalFormativBase(context, target, internalformat, pname, bufSize,
4800 nullptr);
4801}
4802
4803bool ValidateGetInternalFormativRobustANGLE(Context *context,
4804 GLenum target,
4805 GLenum internalformat,
4806 GLenum pname,
4807 GLsizei bufSize,
4808 GLsizei *length,
4809 GLint *params)
4810{
4811 if (!ValidateRobustEntryPoint(context, bufSize))
4812 {
4813 return false;
4814 }
4815
4816 if (!ValidateGetInternalFormativBase(context, target, internalformat, pname, bufSize, length))
4817 {
4818 return false;
4819 }
4820
4821 if (!ValidateRobustBufferSize(context, bufSize, *length))
4822 {
4823 return false;
4824 }
4825
4826 return true;
4827}
4828
Shao80957d92017-02-20 21:25:59 +08004829bool ValidateVertexFormatBase(ValidationContext *context,
4830 GLuint attribIndex,
4831 GLint size,
4832 GLenum type,
4833 GLboolean pureInteger)
4834{
4835 const Caps &caps = context->getCaps();
4836 if (attribIndex >= caps.maxVertexAttributes)
4837 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004838 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMax);
Shao80957d92017-02-20 21:25:59 +08004839 return false;
4840 }
4841
4842 if (size < 1 || size > 4)
4843 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004844 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidVertexAttrSize);
Geoff Lang8700a982017-06-13 10:15:13 -04004845 return false;
Shao80957d92017-02-20 21:25:59 +08004846 }
4847
4848 switch (type)
4849 {
4850 case GL_BYTE:
4851 case GL_UNSIGNED_BYTE:
4852 case GL_SHORT:
4853 case GL_UNSIGNED_SHORT:
4854 break;
4855
4856 case GL_INT:
4857 case GL_UNSIGNED_INT:
4858 if (context->getClientMajorVersion() < 3)
4859 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004860 context->handleError(InvalidEnum()
4861 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004862 return false;
4863 }
4864 break;
4865
4866 case GL_FIXED:
4867 case GL_FLOAT:
4868 if (pureInteger)
4869 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004870 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004871 return false;
4872 }
4873 break;
4874
4875 case GL_HALF_FLOAT:
4876 if (context->getClientMajorVersion() < 3)
4877 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004878 context->handleError(InvalidEnum()
4879 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004880 return false;
4881 }
4882 if (pureInteger)
4883 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004884 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004885 return false;
4886 }
4887 break;
4888
4889 case GL_INT_2_10_10_10_REV:
4890 case GL_UNSIGNED_INT_2_10_10_10_REV:
4891 if (context->getClientMajorVersion() < 3)
4892 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004893 context->handleError(InvalidEnum()
4894 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004895 return false;
4896 }
4897 if (pureInteger)
4898 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004899 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004900 return false;
4901 }
4902 if (size != 4)
4903 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004904 context->handleError(InvalidOperation() << "Type is INT_2_10_10_10_REV or "
4905 "UNSIGNED_INT_2_10_10_10_REV and "
4906 "size is not 4.");
Shao80957d92017-02-20 21:25:59 +08004907 return false;
4908 }
4909 break;
4910
4911 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004912 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidType);
Shao80957d92017-02-20 21:25:59 +08004913 return false;
4914 }
4915
4916 return true;
4917}
4918
Geoff Lang76e65652017-03-27 14:58:02 -04004919// Perform validation from WebGL 2 section 5.10 "Invalid Clears":
4920// In the WebGL 2 API, trying to perform a clear when there is a mismatch between the type of the
4921// specified clear value and the type of a buffer that is being cleared generates an
4922// INVALID_OPERATION error instead of producing undefined results
4923bool ValidateWebGLFramebufferAttachmentClearType(ValidationContext *context,
4924 GLint drawbuffer,
4925 const GLenum *validComponentTypes,
4926 size_t validComponentTypeCount)
4927{
4928 const FramebufferAttachment *attachment =
4929 context->getGLState().getDrawFramebuffer()->getDrawBuffer(drawbuffer);
4930 if (attachment)
4931 {
4932 GLenum componentType = attachment->getFormat().info->componentType;
4933 const GLenum *end = validComponentTypes + validComponentTypeCount;
4934 if (std::find(validComponentTypes, end, componentType) == end)
4935 {
4936 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004937 InvalidOperation()
4938 << "No defined conversion between clear value and attachment format.");
Geoff Lang76e65652017-03-27 14:58:02 -04004939 return false;
4940 }
4941 }
4942
4943 return true;
4944}
4945
Corentin Wallezb2931602017-04-11 15:58:57 -04004946bool ValidateRobustCompressedTexImageBase(ValidationContext *context,
4947 GLsizei imageSize,
4948 GLsizei dataSize)
4949{
4950 if (!ValidateRobustEntryPoint(context, dataSize))
4951 {
4952 return false;
4953 }
4954
4955 gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
4956 if (pixelUnpackBuffer == nullptr)
4957 {
4958 if (dataSize < imageSize)
4959 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004960 context->handleError(InvalidOperation() << "dataSize must be at least " << imageSize);
Corentin Wallezb2931602017-04-11 15:58:57 -04004961 }
4962 }
4963 return true;
4964}
4965
Jamie Madillbe849e42017-05-02 15:49:00 -04004966bool ValidateGetBufferParameterBase(ValidationContext *context,
4967 GLenum target,
4968 GLenum pname,
4969 bool pointerVersion,
4970 GLsizei *numParams)
4971{
4972 if (numParams)
4973 {
4974 *numParams = 0;
4975 }
4976
4977 if (!ValidBufferTarget(context, target))
4978 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004979 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Jamie Madillbe849e42017-05-02 15:49:00 -04004980 return false;
4981 }
4982
4983 const Buffer *buffer = context->getGLState().getTargetBuffer(target);
4984 if (!buffer)
4985 {
4986 // A null buffer means that "0" is bound to the requested buffer target
Brandon Jones6cad5662017-06-14 13:25:13 -07004987 ANGLE_VALIDATION_ERR(context, InvalidOperation(), BufferNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04004988 return false;
4989 }
4990
4991 const Extensions &extensions = context->getExtensions();
4992
4993 switch (pname)
4994 {
4995 case GL_BUFFER_USAGE:
4996 case GL_BUFFER_SIZE:
4997 break;
4998
4999 case GL_BUFFER_ACCESS_OES:
5000 if (!extensions.mapBuffer)
5001 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005002 context->handleError(InvalidEnum()
5003 << "pname requires OpenGL ES 3.0 or GL_OES_mapbuffer.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005004 return false;
5005 }
5006 break;
5007
5008 case GL_BUFFER_MAPPED:
5009 static_assert(GL_BUFFER_MAPPED == GL_BUFFER_MAPPED_OES, "GL enums should be equal.");
5010 if (context->getClientMajorVersion() < 3 && !extensions.mapBuffer &&
5011 !extensions.mapBufferRange)
5012 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005013 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0, "
5014 "GL_OES_mapbuffer or "
5015 "GL_EXT_map_buffer_range.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005016 return false;
5017 }
5018 break;
5019
5020 case GL_BUFFER_MAP_POINTER:
5021 if (!pointerVersion)
5022 {
5023 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005024 InvalidEnum()
5025 << "GL_BUFFER_MAP_POINTER can only be queried with GetBufferPointerv.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005026 return false;
5027 }
5028 break;
5029
5030 case GL_BUFFER_ACCESS_FLAGS:
5031 case GL_BUFFER_MAP_OFFSET:
5032 case GL_BUFFER_MAP_LENGTH:
5033 if (context->getClientMajorVersion() < 3 && !extensions.mapBufferRange)
5034 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005035 context->handleError(InvalidEnum()
5036 << "pname requires OpenGL ES 3.0 or GL_EXT_map_buffer_range.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005037 return false;
5038 }
5039 break;
5040
5041 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005042 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005043 return false;
5044 }
5045
5046 // All buffer parameter queries return one value.
5047 if (numParams)
5048 {
5049 *numParams = 1;
5050 }
5051
5052 return true;
5053}
5054
5055bool ValidateGetRenderbufferParameterivBase(Context *context,
5056 GLenum target,
5057 GLenum pname,
5058 GLsizei *length)
5059{
5060 if (length)
5061 {
5062 *length = 0;
5063 }
5064
5065 if (target != GL_RENDERBUFFER)
5066 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005067 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005068 return false;
5069 }
5070
5071 Renderbuffer *renderbuffer = context->getGLState().getCurrentRenderbuffer();
5072 if (renderbuffer == nullptr)
5073 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005074 ANGLE_VALIDATION_ERR(context, InvalidOperation(), RenderbufferNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005075 return false;
5076 }
5077
5078 switch (pname)
5079 {
5080 case GL_RENDERBUFFER_WIDTH:
5081 case GL_RENDERBUFFER_HEIGHT:
5082 case GL_RENDERBUFFER_INTERNAL_FORMAT:
5083 case GL_RENDERBUFFER_RED_SIZE:
5084 case GL_RENDERBUFFER_GREEN_SIZE:
5085 case GL_RENDERBUFFER_BLUE_SIZE:
5086 case GL_RENDERBUFFER_ALPHA_SIZE:
5087 case GL_RENDERBUFFER_DEPTH_SIZE:
5088 case GL_RENDERBUFFER_STENCIL_SIZE:
5089 break;
5090
5091 case GL_RENDERBUFFER_SAMPLES_ANGLE:
5092 if (!context->getExtensions().framebufferMultisample)
5093 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005094 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005095 return false;
5096 }
5097 break;
5098
5099 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005100 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005101 return false;
5102 }
5103
5104 if (length)
5105 {
5106 *length = 1;
5107 }
5108 return true;
5109}
5110
5111bool ValidateGetShaderivBase(Context *context, GLuint shader, GLenum pname, GLsizei *length)
5112{
5113 if (length)
5114 {
5115 *length = 0;
5116 }
5117
5118 if (GetValidShader(context, shader) == nullptr)
5119 {
5120 return false;
5121 }
5122
5123 switch (pname)
5124 {
5125 case GL_SHADER_TYPE:
5126 case GL_DELETE_STATUS:
5127 case GL_COMPILE_STATUS:
5128 case GL_INFO_LOG_LENGTH:
5129 case GL_SHADER_SOURCE_LENGTH:
5130 break;
5131
5132 case GL_TRANSLATED_SHADER_SOURCE_LENGTH_ANGLE:
5133 if (!context->getExtensions().translatedShaderSource)
5134 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005135 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005136 return false;
5137 }
5138 break;
5139
5140 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005141 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005142 return false;
5143 }
5144
5145 if (length)
5146 {
5147 *length = 1;
5148 }
5149 return true;
5150}
5151
5152bool ValidateGetTexParameterBase(Context *context, GLenum target, GLenum pname, GLsizei *length)
5153{
5154 if (length)
5155 {
5156 *length = 0;
5157 }
5158
5159 if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
5160 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005161 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005162 return false;
5163 }
5164
5165 if (context->getTargetTexture(target) == nullptr)
5166 {
5167 // Should only be possible for external textures
Brandon Jones6cad5662017-06-14 13:25:13 -07005168 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005169 return false;
5170 }
5171
5172 switch (pname)
5173 {
5174 case GL_TEXTURE_MAG_FILTER:
5175 case GL_TEXTURE_MIN_FILTER:
5176 case GL_TEXTURE_WRAP_S:
5177 case GL_TEXTURE_WRAP_T:
5178 break;
5179
5180 case GL_TEXTURE_USAGE_ANGLE:
5181 if (!context->getExtensions().textureUsage)
5182 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005183 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005184 return false;
5185 }
5186 break;
5187
5188 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
5189 if (!context->getExtensions().textureFilterAnisotropic)
5190 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005191 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005192 return false;
5193 }
5194 break;
5195
5196 case GL_TEXTURE_IMMUTABLE_FORMAT:
5197 if (context->getClientMajorVersion() < 3 && !context->getExtensions().textureStorage)
5198 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005199 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005200 return false;
5201 }
5202 break;
5203
5204 case GL_TEXTURE_WRAP_R:
5205 case GL_TEXTURE_IMMUTABLE_LEVELS:
5206 case GL_TEXTURE_SWIZZLE_R:
5207 case GL_TEXTURE_SWIZZLE_G:
5208 case GL_TEXTURE_SWIZZLE_B:
5209 case GL_TEXTURE_SWIZZLE_A:
5210 case GL_TEXTURE_BASE_LEVEL:
5211 case GL_TEXTURE_MAX_LEVEL:
5212 case GL_TEXTURE_MIN_LOD:
5213 case GL_TEXTURE_MAX_LOD:
5214 case GL_TEXTURE_COMPARE_MODE:
5215 case GL_TEXTURE_COMPARE_FUNC:
5216 if (context->getClientMajorVersion() < 3)
5217 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005218 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005219 return false;
5220 }
5221 break;
5222
5223 case GL_TEXTURE_SRGB_DECODE_EXT:
5224 if (!context->getExtensions().textureSRGBDecode)
5225 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005226 context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005227 return false;
5228 }
5229 break;
5230
5231 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005232 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005233 return false;
5234 }
5235
5236 if (length)
5237 {
5238 *length = 1;
5239 }
5240 return true;
5241}
5242
5243bool ValidateGetVertexAttribBase(Context *context,
5244 GLuint index,
5245 GLenum pname,
5246 GLsizei *length,
5247 bool pointer,
5248 bool pureIntegerEntryPoint)
5249{
5250 if (length)
5251 {
5252 *length = 0;
5253 }
5254
5255 if (pureIntegerEntryPoint && context->getClientMajorVersion() < 3)
5256 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005257 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005258 return false;
5259 }
5260
5261 if (index >= context->getCaps().maxVertexAttributes)
5262 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005263 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMax);
Jamie Madillbe849e42017-05-02 15:49:00 -04005264 return false;
5265 }
5266
5267 if (pointer)
5268 {
5269 if (pname != GL_VERTEX_ATTRIB_ARRAY_POINTER)
5270 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005271 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005272 return false;
5273 }
5274 }
5275 else
5276 {
5277 switch (pname)
5278 {
5279 case GL_VERTEX_ATTRIB_ARRAY_ENABLED:
5280 case GL_VERTEX_ATTRIB_ARRAY_SIZE:
5281 case GL_VERTEX_ATTRIB_ARRAY_STRIDE:
5282 case GL_VERTEX_ATTRIB_ARRAY_TYPE:
5283 case GL_VERTEX_ATTRIB_ARRAY_NORMALIZED:
5284 case GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING:
5285 case GL_CURRENT_VERTEX_ATTRIB:
5286 break;
5287
5288 case GL_VERTEX_ATTRIB_ARRAY_DIVISOR:
5289 static_assert(
5290 GL_VERTEX_ATTRIB_ARRAY_DIVISOR == GL_VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE,
5291 "ANGLE extension enums not equal to GL enums.");
5292 if (context->getClientMajorVersion() < 3 &&
5293 !context->getExtensions().instancedArrays)
5294 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005295 context->handleError(InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_DIVISOR "
5296 "requires OpenGL ES 3.0 or "
5297 "GL_ANGLE_instanced_arrays.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005298 return false;
5299 }
5300 break;
5301
5302 case GL_VERTEX_ATTRIB_ARRAY_INTEGER:
5303 if (context->getClientMajorVersion() < 3)
5304 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005305 context->handleError(
5306 InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_INTEGER requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005307 return false;
5308 }
5309 break;
5310
5311 case GL_VERTEX_ATTRIB_BINDING:
5312 case GL_VERTEX_ATTRIB_RELATIVE_OFFSET:
5313 if (context->getClientVersion() < ES_3_1)
5314 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005315 context->handleError(InvalidEnum()
5316 << "Vertex Attrib Bindings require OpenGL ES 3.1.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005317 return false;
5318 }
5319 break;
5320
5321 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005322 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005323 return false;
5324 }
5325 }
5326
5327 if (length)
5328 {
5329 if (pname == GL_CURRENT_VERTEX_ATTRIB)
5330 {
5331 *length = 4;
5332 }
5333 else
5334 {
5335 *length = 1;
5336 }
5337 }
5338
5339 return true;
5340}
5341
Jamie Madill4928b7c2017-06-20 12:57:39 -04005342bool ValidateReadPixelsBase(Context *context,
Jamie Madillbe849e42017-05-02 15:49:00 -04005343 GLint x,
5344 GLint y,
5345 GLsizei width,
5346 GLsizei height,
5347 GLenum format,
5348 GLenum type,
5349 GLsizei bufSize,
5350 GLsizei *length,
5351 GLsizei *columns,
5352 GLsizei *rows,
5353 void *pixels)
5354{
5355 if (length != nullptr)
5356 {
5357 *length = 0;
5358 }
5359 if (rows != nullptr)
5360 {
5361 *rows = 0;
5362 }
5363 if (columns != nullptr)
5364 {
5365 *columns = 0;
5366 }
5367
5368 if (width < 0 || height < 0)
5369 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005370 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005371 return false;
5372 }
5373
5374 auto readFramebuffer = context->getGLState().getReadFramebuffer();
5375
5376 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
5377 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005378 context->handleError(InvalidFramebufferOperation());
Jamie Madillbe849e42017-05-02 15:49:00 -04005379 return false;
5380 }
5381
5382 if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0)
5383 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005384 context->handleError(InvalidOperation());
Jamie Madillbe849e42017-05-02 15:49:00 -04005385 return false;
5386 }
5387
5388 const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer();
5389 ASSERT(framebuffer);
5390
5391 if (framebuffer->getReadBufferState() == GL_NONE)
5392 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005393 context->handleError(InvalidOperation() << "Read buffer is GL_NONE");
Jamie Madillbe849e42017-05-02 15:49:00 -04005394 return false;
5395 }
5396
5397 const FramebufferAttachment *readBuffer = framebuffer->getReadColorbuffer();
5398 // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment
5399 // In OpenGL ES it is undefined what happens when an operation tries to read from a missing
5400 // attachment and WebGL defines it to be an error. We do the check unconditionnaly as the
5401 // situation is an application error that would lead to a crash in ANGLE.
5402 if (readBuffer == nullptr)
5403 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005404 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment);
Jamie Madillbe849e42017-05-02 15:49:00 -04005405 return false;
5406 }
5407
Geoff Lang280ba992017-04-18 16:30:58 -04005408 if (context->getExtensions().webglCompatibility)
5409 {
5410 // The ES 2.0 spec states that the format must be "among those defined in table 3.4,
5411 // excluding formats LUMINANCE and LUMINANCE_ALPHA.". This requires validating the format
5412 // and type before validating the combination of format and type. However, the
5413 // dEQP-GLES3.functional.negative_api.buffer.read_pixels passes GL_LUMINANCE as a format and
5414 // verifies that GL_INVALID_OPERATION is generated.
5415 // TODO(geofflang): Update this check to be done in all/no cases once this is resolved in
5416 // dEQP/WebGL.
5417 if (!ValidReadPixelsFormatEnum(context, format))
5418 {
5419 context->handleError(InvalidEnum() << "Invalid read format.");
5420 return false;
5421 }
5422
5423 if (!ValidReadPixelsTypeEnum(context, type))
5424 {
5425 context->handleError(InvalidEnum() << "Invalid read type.");
5426 return false;
5427 }
5428 }
5429
Jamie Madill4928b7c2017-06-20 12:57:39 -04005430 GLenum currentFormat = framebuffer->getImplementationColorReadFormat(context);
5431 GLenum currentType = framebuffer->getImplementationColorReadType(context);
Jamie Madillbe849e42017-05-02 15:49:00 -04005432 GLenum currentComponentType = readBuffer->getFormat().info->componentType;
5433
5434 bool validFormatTypeCombination =
5435 ValidReadPixelsFormatType(context, currentComponentType, format, type);
5436
5437 if (!(currentFormat == format && currentType == type) && !validFormatTypeCombination)
5438 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005439 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MismatchedTypeAndFormat);
Jamie Madillbe849e42017-05-02 15:49:00 -04005440 return false;
5441 }
5442
5443 // Check for pixel pack buffer related API errors
5444 gl::Buffer *pixelPackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_PACK_BUFFER);
5445 if (pixelPackBuffer != nullptr && pixelPackBuffer->isMapped())
5446 {
5447 // ...the buffer object's data store is currently mapped.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005448 context->handleError(InvalidOperation() << "Pixel pack buffer is mapped.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005449 return false;
5450 }
5451
5452 // .. the data would be packed to the buffer object such that the memory writes required
5453 // would exceed the data store size.
5454 const InternalFormat &formatInfo = GetInternalFormatInfo(format, type);
5455 const gl::Extents size(width, height, 1);
5456 const auto &pack = context->getGLState().getPackState();
5457
5458 auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, pack, false);
5459 if (endByteOrErr.isError())
5460 {
5461 context->handleError(endByteOrErr.getError());
5462 return false;
5463 }
5464
5465 size_t endByte = endByteOrErr.getResult();
5466 if (bufSize >= 0)
5467 {
5468 if (pixelPackBuffer == nullptr && static_cast<size_t>(bufSize) < endByte)
5469 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005470 context->handleError(InvalidOperation()
5471 << "bufSize must be at least " << endByte << " bytes.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005472 return false;
5473 }
5474 }
5475
5476 if (pixelPackBuffer != nullptr)
5477 {
5478 CheckedNumeric<size_t> checkedEndByte(endByte);
5479 CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels));
5480 checkedEndByte += checkedOffset;
5481
5482 if (checkedEndByte.ValueOrDie() > static_cast<size_t>(pixelPackBuffer->getSize()))
5483 {
5484 // Overflow past the end of the buffer
Brandon Jones6cad5662017-06-14 13:25:13 -07005485 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ParamOverflow);
Jamie Madillbe849e42017-05-02 15:49:00 -04005486 return false;
5487 }
5488 }
5489
5490 if (pixelPackBuffer == nullptr && length != nullptr)
5491 {
5492 if (endByte > static_cast<size_t>(std::numeric_limits<GLsizei>::max()))
5493 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005494 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Jamie Madillbe849e42017-05-02 15:49:00 -04005495 return false;
5496 }
5497
5498 *length = static_cast<GLsizei>(endByte);
5499 }
5500
5501 auto getClippedExtent = [](GLint start, GLsizei length, int bufferSize) {
5502 angle::CheckedNumeric<int> clippedExtent(length);
5503 if (start < 0)
5504 {
5505 // "subtract" the area that is less than 0
5506 clippedExtent += start;
5507 }
5508
5509 const int readExtent = start + length;
5510 if (readExtent > bufferSize)
5511 {
5512 // Subtract the region to the right of the read buffer
5513 clippedExtent -= (readExtent - bufferSize);
5514 }
5515
5516 if (!clippedExtent.IsValid())
5517 {
5518 return 0;
5519 }
5520
5521 return std::max(clippedExtent.ValueOrDie(), 0);
5522 };
5523
5524 if (columns != nullptr)
5525 {
5526 *columns = getClippedExtent(x, width, readBuffer->getSize().width);
5527 }
5528
5529 if (rows != nullptr)
5530 {
5531 *rows = getClippedExtent(y, height, readBuffer->getSize().height);
5532 }
5533
5534 return true;
5535}
5536
5537template <typename ParamType>
5538bool ValidateTexParameterBase(Context *context,
5539 GLenum target,
5540 GLenum pname,
5541 GLsizei bufSize,
5542 const ParamType *params)
5543{
5544 if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
5545 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005546 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005547 return false;
5548 }
5549
5550 if (context->getTargetTexture(target) == nullptr)
5551 {
5552 // Should only be possible for external textures
Brandon Jones6cad5662017-06-14 13:25:13 -07005553 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005554 return false;
5555 }
5556
5557 const GLsizei minBufSize = 1;
5558 if (bufSize >= 0 && bufSize < minBufSize)
5559 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005560 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005561 return false;
5562 }
5563
5564 switch (pname)
5565 {
5566 case GL_TEXTURE_WRAP_R:
5567 case GL_TEXTURE_SWIZZLE_R:
5568 case GL_TEXTURE_SWIZZLE_G:
5569 case GL_TEXTURE_SWIZZLE_B:
5570 case GL_TEXTURE_SWIZZLE_A:
5571 case GL_TEXTURE_BASE_LEVEL:
5572 case GL_TEXTURE_MAX_LEVEL:
5573 case GL_TEXTURE_COMPARE_MODE:
5574 case GL_TEXTURE_COMPARE_FUNC:
5575 case GL_TEXTURE_MIN_LOD:
5576 case GL_TEXTURE_MAX_LOD:
5577 if (context->getClientMajorVersion() < 3)
5578 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005579 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005580 return false;
5581 }
5582 if (target == GL_TEXTURE_EXTERNAL_OES &&
5583 !context->getExtensions().eglImageExternalEssl3)
5584 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005585 context->handleError(InvalidEnum() << "ES3 texture parameters are not "
5586 "available without "
5587 "GL_OES_EGL_image_external_essl3.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005588 return false;
5589 }
5590 break;
5591
5592 default:
5593 break;
5594 }
5595
JiangYizhou4cff8d62017-07-06 14:54:09 +08005596 if (target == GL_TEXTURE_2D_MULTISAMPLE)
5597 {
5598 switch (pname)
5599 {
5600 case GL_TEXTURE_MIN_FILTER:
5601 case GL_TEXTURE_MAG_FILTER:
5602 case GL_TEXTURE_WRAP_S:
5603 case GL_TEXTURE_WRAP_T:
5604 case GL_TEXTURE_WRAP_R:
5605 case GL_TEXTURE_MIN_LOD:
5606 case GL_TEXTURE_MAX_LOD:
5607 case GL_TEXTURE_COMPARE_MODE:
5608 case GL_TEXTURE_COMPARE_FUNC:
5609 context->handleError(InvalidEnum()
5610 << "Invalid parameter for 2D multisampled textures.");
5611 return false;
5612 }
5613 }
5614
Jamie Madillbe849e42017-05-02 15:49:00 -04005615 switch (pname)
5616 {
5617 case GL_TEXTURE_WRAP_S:
5618 case GL_TEXTURE_WRAP_T:
5619 case GL_TEXTURE_WRAP_R:
5620 if (!ValidateTextureWrapModeValue(context, params, target == GL_TEXTURE_EXTERNAL_OES))
5621 {
5622 return false;
5623 }
5624 break;
5625
5626 case GL_TEXTURE_MIN_FILTER:
5627 if (!ValidateTextureMinFilterValue(context, params, target == GL_TEXTURE_EXTERNAL_OES))
5628 {
5629 return false;
5630 }
5631 break;
5632
5633 case GL_TEXTURE_MAG_FILTER:
5634 if (!ValidateTextureMagFilterValue(context, params))
5635 {
5636 return false;
5637 }
5638 break;
5639
5640 case GL_TEXTURE_USAGE_ANGLE:
5641 switch (ConvertToGLenum(params[0]))
5642 {
5643 case GL_NONE:
5644 case GL_FRAMEBUFFER_ATTACHMENT_ANGLE:
5645 break;
5646
5647 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005648 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005649 return false;
5650 }
5651 break;
5652
5653 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
5654 if (!context->getExtensions().textureFilterAnisotropic)
5655 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005656 context->handleError(InvalidEnum() << "GL_EXT_texture_anisotropic is not enabled.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005657 return false;
5658 }
5659
5660 // we assume the parameter passed to this validation method is truncated, not rounded
5661 if (params[0] < 1)
5662 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005663 context->handleError(InvalidValue() << "Max anisotropy must be at least 1.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005664 return false;
5665 }
5666 break;
5667
5668 case GL_TEXTURE_MIN_LOD:
5669 case GL_TEXTURE_MAX_LOD:
5670 // any value is permissible
5671 break;
5672
5673 case GL_TEXTURE_COMPARE_MODE:
5674 if (!ValidateTextureCompareModeValue(context, params))
5675 {
5676 return false;
5677 }
5678 break;
5679
5680 case GL_TEXTURE_COMPARE_FUNC:
5681 if (!ValidateTextureCompareFuncValue(context, params))
5682 {
5683 return false;
5684 }
5685 break;
5686
5687 case GL_TEXTURE_SWIZZLE_R:
5688 case GL_TEXTURE_SWIZZLE_G:
5689 case GL_TEXTURE_SWIZZLE_B:
5690 case GL_TEXTURE_SWIZZLE_A:
5691 switch (ConvertToGLenum(params[0]))
5692 {
5693 case GL_RED:
5694 case GL_GREEN:
5695 case GL_BLUE:
5696 case GL_ALPHA:
5697 case GL_ZERO:
5698 case GL_ONE:
5699 break;
5700
5701 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005702 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005703 return false;
5704 }
5705 break;
5706
5707 case GL_TEXTURE_BASE_LEVEL:
5708 if (params[0] < 0)
5709 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005710 context->handleError(InvalidValue() << "Base level must be at least 0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005711 return false;
5712 }
5713 if (target == GL_TEXTURE_EXTERNAL_OES && static_cast<GLuint>(params[0]) != 0)
5714 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005715 context->handleError(InvalidOperation()
5716 << "Base level must be 0 for external textures.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005717 return false;
5718 }
JiangYizhou4cff8d62017-07-06 14:54:09 +08005719 if (target == GL_TEXTURE_2D_MULTISAMPLE && static_cast<GLuint>(params[0]) != 0)
5720 {
5721 context->handleError(InvalidOperation()
5722 << "Base level must be 0 for multisampled textures.");
5723 return false;
5724 }
Jamie Madillbe849e42017-05-02 15:49:00 -04005725 break;
5726
5727 case GL_TEXTURE_MAX_LEVEL:
5728 if (params[0] < 0)
5729 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005730 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Jamie Madillbe849e42017-05-02 15:49:00 -04005731 return false;
5732 }
5733 break;
5734
5735 case GL_DEPTH_STENCIL_TEXTURE_MODE:
5736 if (context->getClientVersion() < Version(3, 1))
5737 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005738 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumRequiresGLES31);
Jamie Madillbe849e42017-05-02 15:49:00 -04005739 return false;
5740 }
5741 switch (ConvertToGLenum(params[0]))
5742 {
5743 case GL_DEPTH_COMPONENT:
5744 case GL_STENCIL_INDEX:
5745 break;
5746
5747 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005748 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005749 return false;
5750 }
5751 break;
5752
5753 case GL_TEXTURE_SRGB_DECODE_EXT:
5754 if (!ValidateTextureSRGBDecodeValue(context, params))
5755 {
5756 return false;
5757 }
5758 break;
5759
5760 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005761 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005762 return false;
5763 }
5764
5765 return true;
5766}
5767
5768template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLfloat *);
5769template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLint *);
5770
Jamie Madillc29968b2016-01-20 11:17:23 -05005771} // namespace gl