Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1 | // |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 2 | // Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved. |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
| 7 | // validationES2.cpp: Validation functions for OpenGL ES 2.0 entry point parameters |
| 8 | |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 9 | #include "libANGLE/validationES2.h" |
| 10 | #include "libANGLE/validationES.h" |
| 11 | #include "libANGLE/Context.h" |
| 12 | #include "libANGLE/Texture.h" |
| 13 | #include "libANGLE/Framebuffer.h" |
| 14 | #include "libANGLE/Renderbuffer.h" |
| 15 | #include "libANGLE/formatutils.h" |
| 16 | #include "libANGLE/FramebufferAttachment.h" |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 17 | |
| 18 | #include "common/mathutil.h" |
| 19 | #include "common/utilities.h" |
| 20 | |
| 21 | namespace gl |
| 22 | { |
| 23 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 24 | bool ValidateES2TexImageParameters(Context *context, GLenum target, GLint level, GLenum internalformat, bool isCompressed, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 25 | GLint xoffset, GLint yoffset, GLsizei width, GLsizei height, |
| 26 | GLint border, GLenum format, GLenum type, const GLvoid *pixels) |
| 27 | { |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 28 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 29 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 30 | context->recordError(Error(GL_INVALID_ENUM)); |
| 31 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 32 | } |
| 33 | |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 34 | if (!ValidImageSize(context, target, level, width, height, 1)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 35 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 36 | context->recordError(Error(GL_INVALID_VALUE)); |
| 37 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 38 | } |
| 39 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 40 | if (level < 0 || xoffset < 0 || |
| 41 | std::numeric_limits<GLsizei>::max() - xoffset < width || |
| 42 | std::numeric_limits<GLsizei>::max() - yoffset < height) |
| 43 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 44 | context->recordError(Error(GL_INVALID_VALUE)); |
| 45 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 46 | } |
| 47 | |
Geoff Lang | 005df41 | 2013-10-16 14:12:50 -0400 | [diff] [blame] | 48 | if (!isSubImage && !isCompressed && internalformat != format) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 49 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 50 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 51 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 52 | } |
| 53 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 54 | const gl::Caps &caps = context->getCaps(); |
| 55 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 56 | if (target == GL_TEXTURE_2D) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 57 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 58 | if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) || |
| 59 | static_cast<GLuint>(height) > (caps.max2DTextureSize >> level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 60 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 61 | context->recordError(Error(GL_INVALID_VALUE)); |
| 62 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 63 | } |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 64 | } |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 65 | else if (IsCubeMapTextureTarget(target)) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 66 | { |
| 67 | if (!isSubImage && width != height) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 68 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 69 | context->recordError(Error(GL_INVALID_VALUE)); |
| 70 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 71 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 72 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 73 | if (static_cast<GLuint>(width) > (caps.maxCubeMapTextureSize >> level) || |
| 74 | static_cast<GLuint>(height) > (caps.maxCubeMapTextureSize >> level)) |
| 75 | { |
| 76 | context->recordError(Error(GL_INVALID_VALUE)); |
| 77 | return false; |
| 78 | } |
| 79 | } |
| 80 | else |
| 81 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 82 | context->recordError(Error(GL_INVALID_ENUM)); |
| 83 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 84 | } |
| 85 | |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 86 | gl::Texture *texture = context->getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 87 | if (!texture) |
| 88 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 89 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 90 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 91 | } |
| 92 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 93 | if (isSubImage) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 94 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 95 | if (format != GL_NONE) |
| 96 | { |
Geoff Lang | 051dbc7 | 2015-01-05 15:48:58 -0500 | [diff] [blame] | 97 | if (gl::GetSizedInternalFormat(format, type) != texture->getInternalFormat(target, level)) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 98 | { |
| 99 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 100 | return false; |
| 101 | } |
| 102 | } |
| 103 | |
| 104 | if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) || |
| 105 | static_cast<size_t>(yoffset + height) > texture->getHeight(target, level)) |
| 106 | { |
| 107 | context->recordError(Error(GL_INVALID_VALUE)); |
| 108 | return false; |
| 109 | } |
| 110 | } |
| 111 | else |
| 112 | { |
| 113 | if (texture->isImmutable()) |
| 114 | { |
| 115 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 116 | return false; |
| 117 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 118 | } |
| 119 | |
| 120 | // Verify zero border |
| 121 | if (border != 0) |
| 122 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 123 | context->recordError(Error(GL_INVALID_VALUE)); |
| 124 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 125 | } |
| 126 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 127 | GLenum actualInternalFormat = isSubImage ? texture->getInternalFormat(target, level) : internalformat; |
| 128 | const InternalFormat &actualFormatInfo = GetInternalFormatInfo(actualInternalFormat); |
| 129 | |
| 130 | if (isCompressed != actualFormatInfo.compressed) |
| 131 | { |
| 132 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 133 | return false; |
| 134 | } |
| 135 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 136 | if (isCompressed) |
| 137 | { |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 138 | if (!ValidCompressedImageSize(context, actualInternalFormat, width, height)) |
| 139 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 140 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 141 | return false; |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 142 | } |
| 143 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 144 | switch (actualInternalFormat) |
| 145 | { |
| 146 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 147 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 148 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 149 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 150 | context->recordError(Error(GL_INVALID_ENUM)); |
| 151 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 152 | } |
| 153 | break; |
| 154 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 155 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 156 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 157 | context->recordError(Error(GL_INVALID_ENUM)); |
| 158 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 159 | } |
| 160 | break; |
| 161 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 162 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 163 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 164 | context->recordError(Error(GL_INVALID_ENUM)); |
| 165 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 166 | } |
| 167 | break; |
| 168 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 169 | context->recordError(Error(GL_INVALID_ENUM)); |
| 170 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 171 | } |
| 172 | } |
| 173 | else |
| 174 | { |
| 175 | // validate <type> by itself (used as secondary key below) |
| 176 | switch (type) |
| 177 | { |
| 178 | case GL_UNSIGNED_BYTE: |
| 179 | case GL_UNSIGNED_SHORT_5_6_5: |
| 180 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 181 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 182 | case GL_UNSIGNED_SHORT: |
| 183 | case GL_UNSIGNED_INT: |
| 184 | case GL_UNSIGNED_INT_24_8_OES: |
| 185 | case GL_HALF_FLOAT_OES: |
| 186 | case GL_FLOAT: |
| 187 | break; |
| 188 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 189 | context->recordError(Error(GL_INVALID_ENUM)); |
| 190 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 191 | } |
| 192 | |
| 193 | // validate <format> + <type> combinations |
| 194 | // - invalid <format> -> sets INVALID_ENUM |
| 195 | // - invalid <format>+<type> combination -> sets INVALID_OPERATION |
| 196 | switch (format) |
| 197 | { |
| 198 | case GL_ALPHA: |
| 199 | case GL_LUMINANCE: |
| 200 | case GL_LUMINANCE_ALPHA: |
| 201 | switch (type) |
| 202 | { |
| 203 | case GL_UNSIGNED_BYTE: |
| 204 | case GL_FLOAT: |
| 205 | case GL_HALF_FLOAT_OES: |
| 206 | break; |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 207 | default: |
| 208 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 209 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 210 | } |
| 211 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 212 | case GL_RED: |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 213 | case GL_RG: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 214 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 215 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 216 | context->recordError(Error(GL_INVALID_ENUM)); |
| 217 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 218 | } |
| 219 | switch (type) |
| 220 | { |
| 221 | case GL_UNSIGNED_BYTE: |
| 222 | case GL_FLOAT: |
| 223 | case GL_HALF_FLOAT_OES: |
| 224 | break; |
| 225 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 226 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 227 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 228 | } |
| 229 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 230 | case GL_RGB: |
| 231 | switch (type) |
| 232 | { |
| 233 | case GL_UNSIGNED_BYTE: |
| 234 | case GL_UNSIGNED_SHORT_5_6_5: |
| 235 | case GL_FLOAT: |
| 236 | case GL_HALF_FLOAT_OES: |
| 237 | break; |
| 238 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 239 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 240 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 241 | } |
| 242 | break; |
| 243 | case GL_RGBA: |
| 244 | switch (type) |
| 245 | { |
| 246 | case GL_UNSIGNED_BYTE: |
| 247 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 248 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 249 | case GL_FLOAT: |
| 250 | case GL_HALF_FLOAT_OES: |
| 251 | break; |
| 252 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 253 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 254 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 255 | } |
| 256 | break; |
| 257 | case GL_BGRA_EXT: |
| 258 | switch (type) |
| 259 | { |
| 260 | case GL_UNSIGNED_BYTE: |
| 261 | break; |
| 262 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 263 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 264 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 265 | } |
| 266 | break; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 267 | case GL_SRGB_EXT: |
| 268 | case GL_SRGB_ALPHA_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 269 | if (!context->getExtensions().sRGB) |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 270 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 271 | context->recordError(Error(GL_INVALID_ENUM)); |
| 272 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 273 | } |
| 274 | switch (type) |
| 275 | { |
| 276 | case GL_UNSIGNED_BYTE: |
| 277 | break; |
| 278 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 279 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 280 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 281 | } |
| 282 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 283 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: // error cases for compressed textures are handled below |
| 284 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 285 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 286 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
| 287 | break; |
| 288 | case GL_DEPTH_COMPONENT: |
| 289 | switch (type) |
| 290 | { |
| 291 | case GL_UNSIGNED_SHORT: |
| 292 | case GL_UNSIGNED_INT: |
| 293 | break; |
| 294 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 295 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 296 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 297 | } |
| 298 | break; |
| 299 | case GL_DEPTH_STENCIL_OES: |
| 300 | switch (type) |
| 301 | { |
| 302 | case GL_UNSIGNED_INT_24_8_OES: |
| 303 | break; |
| 304 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 305 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 306 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 307 | } |
| 308 | break; |
| 309 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 310 | context->recordError(Error(GL_INVALID_ENUM)); |
| 311 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 312 | } |
| 313 | |
| 314 | switch (format) |
| 315 | { |
| 316 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 317 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 318 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 319 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 320 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 321 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 322 | } |
| 323 | else |
| 324 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 325 | context->recordError(Error(GL_INVALID_ENUM)); |
| 326 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 327 | } |
| 328 | break; |
| 329 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 330 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 331 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 332 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 333 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 334 | } |
| 335 | else |
| 336 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 337 | context->recordError(Error(GL_INVALID_ENUM)); |
| 338 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 339 | } |
| 340 | break; |
| 341 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 342 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 343 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 344 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 345 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 346 | } |
| 347 | else |
| 348 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 349 | context->recordError(Error(GL_INVALID_ENUM)); |
| 350 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 351 | } |
| 352 | break; |
| 353 | case GL_DEPTH_COMPONENT: |
| 354 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 355 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 356 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 357 | context->recordError(Error(GL_INVALID_VALUE)); |
| 358 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 359 | } |
| 360 | if (target != GL_TEXTURE_2D) |
| 361 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 362 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 363 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 364 | } |
| 365 | // OES_depth_texture supports loading depth data and multiple levels, |
| 366 | // but ANGLE_depth_texture does not |
| 367 | if (pixels != NULL || level != 0) |
| 368 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 369 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 370 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 371 | } |
| 372 | break; |
| 373 | default: |
| 374 | break; |
| 375 | } |
| 376 | |
| 377 | if (type == GL_FLOAT) |
| 378 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 379 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 380 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 381 | context->recordError(Error(GL_INVALID_ENUM)); |
| 382 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 383 | } |
| 384 | } |
| 385 | else if (type == GL_HALF_FLOAT_OES) |
| 386 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 387 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 388 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 389 | context->recordError(Error(GL_INVALID_ENUM)); |
| 390 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 391 | } |
| 392 | } |
| 393 | } |
| 394 | |
| 395 | return true; |
| 396 | } |
| 397 | |
| 398 | |
| 399 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 400 | bool ValidateES2CopyTexImageParameters(Context* context, GLenum target, GLint level, GLenum internalformat, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 401 | GLint xoffset, GLint yoffset, GLint x, GLint y, GLsizei width, GLsizei height, |
| 402 | GLint border) |
| 403 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 404 | GLenum textureInternalFormat = GL_NONE; |
Shannon Woods | 4dfed83 | 2014-03-17 20:03:39 -0400 | [diff] [blame] | 405 | |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 406 | if (!ValidateCopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
| 407 | xoffset, yoffset, 0, x, y, width, height, border, &textureInternalFormat)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 408 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 409 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 410 | } |
| 411 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 412 | gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer(); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 413 | GLenum colorbufferFormat = framebuffer->getReadColorbuffer()->getInternalFormat(); |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 414 | const auto &internalFormatInfo = gl::GetInternalFormatInfo(textureInternalFormat); |
| 415 | GLenum textureFormat = internalFormatInfo.format; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 416 | |
| 417 | // [OpenGL ES 2.0.24] table 3.9 |
| 418 | if (isSubImage) |
| 419 | { |
| 420 | switch (textureFormat) |
| 421 | { |
| 422 | case GL_ALPHA: |
| 423 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 424 | colorbufferFormat != GL_RGBA4 && |
| 425 | colorbufferFormat != GL_RGB5_A1 && |
| 426 | colorbufferFormat != GL_RGBA8_OES) |
| 427 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 428 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 429 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 430 | } |
| 431 | break; |
| 432 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 433 | if (colorbufferFormat != GL_R8_EXT && |
| 434 | colorbufferFormat != GL_RG8_EXT && |
| 435 | colorbufferFormat != GL_RGB565 && |
| 436 | colorbufferFormat != GL_RGB8_OES && |
| 437 | colorbufferFormat != GL_RGBA4 && |
| 438 | colorbufferFormat != GL_RGB5_A1 && |
| 439 | colorbufferFormat != GL_RGBA8_OES) |
| 440 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 441 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 442 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 443 | } |
| 444 | break; |
| 445 | case GL_RED_EXT: |
| 446 | if (colorbufferFormat != GL_R8_EXT && |
| 447 | colorbufferFormat != GL_RG8_EXT && |
| 448 | colorbufferFormat != GL_RGB565 && |
| 449 | colorbufferFormat != GL_RGB8_OES && |
| 450 | colorbufferFormat != GL_RGBA4 && |
| 451 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 452 | colorbufferFormat != GL_RGBA8_OES && |
| 453 | colorbufferFormat != GL_R32F && |
| 454 | colorbufferFormat != GL_RG32F && |
| 455 | colorbufferFormat != GL_RGB32F && |
| 456 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 457 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 458 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 459 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 460 | } |
| 461 | break; |
| 462 | case GL_RG_EXT: |
| 463 | if (colorbufferFormat != GL_RG8_EXT && |
| 464 | colorbufferFormat != GL_RGB565 && |
| 465 | colorbufferFormat != GL_RGB8_OES && |
| 466 | colorbufferFormat != GL_RGBA4 && |
| 467 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 468 | colorbufferFormat != GL_RGBA8_OES && |
| 469 | colorbufferFormat != GL_RG32F && |
| 470 | colorbufferFormat != GL_RGB32F && |
| 471 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 472 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 473 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 474 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 475 | } |
| 476 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 477 | case GL_RGB: |
| 478 | if (colorbufferFormat != GL_RGB565 && |
| 479 | colorbufferFormat != GL_RGB8_OES && |
| 480 | colorbufferFormat != GL_RGBA4 && |
| 481 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 482 | colorbufferFormat != GL_RGBA8_OES && |
| 483 | colorbufferFormat != GL_RGB32F && |
| 484 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 485 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 486 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 487 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 488 | } |
| 489 | break; |
| 490 | case GL_LUMINANCE_ALPHA: |
| 491 | case GL_RGBA: |
| 492 | if (colorbufferFormat != GL_RGBA4 && |
| 493 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 494 | colorbufferFormat != GL_RGBA8_OES && |
| 495 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 496 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 497 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 498 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 499 | } |
| 500 | break; |
| 501 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 502 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 503 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 504 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 505 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 506 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 507 | case GL_DEPTH_COMPONENT: |
| 508 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 509 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 510 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 511 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 512 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 513 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 514 | } |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 515 | |
| 516 | if (internalFormatInfo.type == GL_FLOAT && |
| 517 | !context->getExtensions().textureFloat) |
| 518 | { |
| 519 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 520 | return false; |
| 521 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 522 | } |
| 523 | else |
| 524 | { |
| 525 | switch (internalformat) |
| 526 | { |
| 527 | case GL_ALPHA: |
| 528 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 529 | colorbufferFormat != GL_RGBA4 && |
| 530 | colorbufferFormat != GL_RGB5_A1 && |
| 531 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 532 | colorbufferFormat != GL_RGBA8_OES && |
| 533 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 534 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 535 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 536 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 537 | } |
| 538 | break; |
| 539 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 540 | if (colorbufferFormat != GL_R8_EXT && |
| 541 | colorbufferFormat != GL_RG8_EXT && |
| 542 | colorbufferFormat != GL_RGB565 && |
| 543 | colorbufferFormat != GL_RGB8_OES && |
| 544 | colorbufferFormat != GL_RGBA4 && |
| 545 | colorbufferFormat != GL_RGB5_A1 && |
| 546 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 547 | colorbufferFormat != GL_RGBA8_OES && |
| 548 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 549 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 550 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 551 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 552 | } |
| 553 | break; |
| 554 | case GL_RED_EXT: |
| 555 | if (colorbufferFormat != GL_R8_EXT && |
| 556 | colorbufferFormat != GL_RG8_EXT && |
| 557 | colorbufferFormat != GL_RGB565 && |
| 558 | colorbufferFormat != GL_RGB8_OES && |
| 559 | colorbufferFormat != GL_RGBA4 && |
| 560 | colorbufferFormat != GL_RGB5_A1 && |
| 561 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 562 | colorbufferFormat != GL_RGBA8_OES && |
| 563 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 564 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 565 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 566 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 567 | } |
| 568 | break; |
| 569 | case GL_RG_EXT: |
| 570 | if (colorbufferFormat != GL_RG8_EXT && |
| 571 | colorbufferFormat != GL_RGB565 && |
| 572 | colorbufferFormat != GL_RGB8_OES && |
| 573 | colorbufferFormat != GL_RGBA4 && |
| 574 | colorbufferFormat != GL_RGB5_A1 && |
| 575 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 576 | colorbufferFormat != GL_RGBA8_OES && |
| 577 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 578 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 579 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 580 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 581 | } |
| 582 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 583 | case GL_RGB: |
| 584 | if (colorbufferFormat != GL_RGB565 && |
| 585 | colorbufferFormat != GL_RGB8_OES && |
| 586 | colorbufferFormat != GL_RGBA4 && |
| 587 | colorbufferFormat != GL_RGB5_A1 && |
| 588 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 589 | colorbufferFormat != GL_RGBA8_OES && |
| 590 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 591 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 592 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 593 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 594 | } |
| 595 | break; |
| 596 | case GL_LUMINANCE_ALPHA: |
| 597 | case GL_RGBA: |
| 598 | if (colorbufferFormat != GL_RGBA4 && |
| 599 | colorbufferFormat != GL_RGB5_A1 && |
| 600 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 601 | colorbufferFormat != GL_RGBA8_OES && |
| 602 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 603 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 604 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 605 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 606 | } |
| 607 | break; |
| 608 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 609 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 610 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 611 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 612 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 613 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 614 | } |
| 615 | else |
| 616 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 617 | context->recordError(Error(GL_INVALID_ENUM)); |
| 618 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 619 | } |
| 620 | break; |
| 621 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 622 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 623 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 624 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 625 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 626 | } |
| 627 | else |
| 628 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 629 | context->recordError(Error(GL_INVALID_ENUM)); |
| 630 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 631 | } |
| 632 | break; |
| 633 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 634 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 635 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 636 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 637 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 638 | } |
| 639 | else |
| 640 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 641 | context->recordError(Error(GL_INVALID_ENUM)); |
| 642 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 643 | } |
| 644 | break; |
| 645 | case GL_DEPTH_COMPONENT: |
| 646 | case GL_DEPTH_COMPONENT16: |
| 647 | case GL_DEPTH_COMPONENT32_OES: |
| 648 | case GL_DEPTH_STENCIL_OES: |
| 649 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 650 | if (context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 651 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 652 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 653 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 654 | } |
| 655 | else |
| 656 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 657 | context->recordError(Error(GL_INVALID_ENUM)); |
| 658 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 659 | } |
| 660 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 661 | context->recordError(Error(GL_INVALID_ENUM)); |
| 662 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 663 | } |
| 664 | } |
| 665 | |
Geoff Lang | 784a8fd | 2013-09-24 12:33:16 -0400 | [diff] [blame] | 666 | // If width or height is zero, it is a no-op. Return false without setting an error. |
| 667 | return (width > 0 && height > 0); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 668 | } |
| 669 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 670 | bool ValidateES2TexStorageParameters(Context *context, GLenum target, GLsizei levels, GLenum internalformat, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 671 | GLsizei width, GLsizei height) |
| 672 | { |
| 673 | if (target != GL_TEXTURE_2D && target != GL_TEXTURE_CUBE_MAP) |
| 674 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 675 | context->recordError(Error(GL_INVALID_ENUM)); |
| 676 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 677 | } |
| 678 | |
| 679 | if (width < 1 || height < 1 || levels < 1) |
| 680 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 681 | context->recordError(Error(GL_INVALID_VALUE)); |
| 682 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 683 | } |
| 684 | |
| 685 | if (target == GL_TEXTURE_CUBE_MAP && width != height) |
| 686 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 687 | context->recordError(Error(GL_INVALID_VALUE)); |
| 688 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 689 | } |
| 690 | |
| 691 | if (levels != 1 && levels != gl::log2(std::max(width, height)) + 1) |
| 692 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 693 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 694 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 695 | } |
| 696 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 697 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat); |
| 698 | if (formatInfo.format == GL_NONE || formatInfo.type == GL_NONE) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 699 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 700 | context->recordError(Error(GL_INVALID_ENUM)); |
| 701 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 702 | } |
| 703 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 704 | const gl::Caps &caps = context->getCaps(); |
| 705 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 706 | switch (target) |
| 707 | { |
| 708 | case GL_TEXTURE_2D: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 709 | if (static_cast<GLuint>(width) > caps.max2DTextureSize || |
| 710 | static_cast<GLuint>(height) > caps.max2DTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 711 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 712 | context->recordError(Error(GL_INVALID_VALUE)); |
| 713 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 714 | } |
| 715 | break; |
| 716 | case GL_TEXTURE_CUBE_MAP: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 717 | if (static_cast<GLuint>(width) > caps.maxCubeMapTextureSize || |
| 718 | static_cast<GLuint>(height) > caps.maxCubeMapTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 719 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 720 | context->recordError(Error(GL_INVALID_VALUE)); |
| 721 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 722 | } |
| 723 | break; |
| 724 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 725 | context->recordError(Error(GL_INVALID_ENUM)); |
| 726 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 727 | } |
| 728 | |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 729 | if (levels != 1 && !context->getExtensions().textureNPOT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 730 | { |
| 731 | if (!gl::isPow2(width) || !gl::isPow2(height)) |
| 732 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 733 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 734 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 735 | } |
| 736 | } |
| 737 | |
| 738 | switch (internalformat) |
| 739 | { |
| 740 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 741 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 742 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 743 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 744 | context->recordError(Error(GL_INVALID_ENUM)); |
| 745 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 746 | } |
| 747 | break; |
| 748 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 749 | if (!context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 750 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 751 | context->recordError(Error(GL_INVALID_ENUM)); |
| 752 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 753 | } |
| 754 | break; |
| 755 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 756 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 757 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 758 | context->recordError(Error(GL_INVALID_ENUM)); |
| 759 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 760 | } |
| 761 | break; |
| 762 | case GL_RGBA32F_EXT: |
| 763 | case GL_RGB32F_EXT: |
| 764 | case GL_ALPHA32F_EXT: |
| 765 | case GL_LUMINANCE32F_EXT: |
| 766 | case GL_LUMINANCE_ALPHA32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 767 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 768 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 769 | context->recordError(Error(GL_INVALID_ENUM)); |
| 770 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 771 | } |
| 772 | break; |
| 773 | case GL_RGBA16F_EXT: |
| 774 | case GL_RGB16F_EXT: |
| 775 | case GL_ALPHA16F_EXT: |
| 776 | case GL_LUMINANCE16F_EXT: |
| 777 | case GL_LUMINANCE_ALPHA16F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 778 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 779 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 780 | context->recordError(Error(GL_INVALID_ENUM)); |
| 781 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 782 | } |
| 783 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 784 | case GL_R8_EXT: |
| 785 | case GL_RG8_EXT: |
| 786 | case GL_R16F_EXT: |
| 787 | case GL_RG16F_EXT: |
| 788 | case GL_R32F_EXT: |
| 789 | case GL_RG32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 790 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 791 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 792 | context->recordError(Error(GL_INVALID_ENUM)); |
| 793 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 794 | } |
| 795 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 796 | case GL_DEPTH_COMPONENT16: |
| 797 | case GL_DEPTH_COMPONENT32_OES: |
| 798 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 799 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 800 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 801 | context->recordError(Error(GL_INVALID_ENUM)); |
| 802 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 803 | } |
| 804 | if (target != GL_TEXTURE_2D) |
| 805 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 806 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 807 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 808 | } |
| 809 | // ANGLE_depth_texture only supports 1-level textures |
| 810 | if (levels != 1) |
| 811 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 812 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 813 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 814 | } |
| 815 | break; |
| 816 | default: |
| 817 | break; |
| 818 | } |
| 819 | |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 820 | gl::Texture *texture = context->getTargetTexture(target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 821 | if (!texture || texture->id() == 0) |
| 822 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 823 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 824 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 825 | } |
| 826 | |
| 827 | if (texture->isImmutable()) |
| 828 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 829 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 830 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 831 | } |
| 832 | |
| 833 | return true; |
| 834 | } |
| 835 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 836 | // check for combinations of format and type that are valid for ReadPixels |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 837 | bool ValidES2ReadFormatType(Context *context, GLenum format, GLenum type) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 838 | { |
| 839 | switch (format) |
| 840 | { |
| 841 | case GL_RGBA: |
| 842 | switch (type) |
| 843 | { |
| 844 | case GL_UNSIGNED_BYTE: |
| 845 | break; |
| 846 | default: |
| 847 | return false; |
| 848 | } |
| 849 | break; |
| 850 | case GL_BGRA_EXT: |
| 851 | switch (type) |
| 852 | { |
| 853 | case GL_UNSIGNED_BYTE: |
| 854 | case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT: |
| 855 | case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT: |
| 856 | break; |
| 857 | default: |
| 858 | return false; |
| 859 | } |
| 860 | break; |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 861 | case GL_RG_EXT: |
| 862 | case GL_RED_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 863 | if (!context->getExtensions().textureRG) |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 864 | { |
| 865 | return false; |
| 866 | } |
| 867 | switch (type) |
| 868 | { |
| 869 | case GL_UNSIGNED_BYTE: |
| 870 | break; |
| 871 | default: |
| 872 | return false; |
| 873 | } |
| 874 | break; |
| 875 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 876 | default: |
| 877 | return false; |
| 878 | } |
| 879 | return true; |
| 880 | } |
| 881 | |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 882 | bool ValidateDiscardFramebufferEXT(Context *context, GLenum target, GLsizei numAttachments, |
| 883 | const GLenum *attachments) |
| 884 | { |
| 885 | bool defaultFramebuffer = false; |
| 886 | |
| 887 | switch (target) |
| 888 | { |
| 889 | case GL_FRAMEBUFFER: |
| 890 | defaultFramebuffer = (context->getState().getTargetFramebuffer(GL_FRAMEBUFFER)->id() == 0); |
| 891 | break; |
| 892 | default: |
| 893 | context->recordError(Error(GL_INVALID_ENUM, "Invalid framebuffer target")); |
| 894 | return false; |
| 895 | } |
| 896 | |
| 897 | return ValidateDiscardFramebufferBase(context, target, numAttachments, attachments, defaultFramebuffer); |
| 898 | } |
| 899 | |
Dian Xiang | bf18ed0 | 2015-09-11 10:50:04 -0700 | [diff] [blame] | 900 | bool ValidateDrawBuffers(Context *context, GLsizei n, const GLenum *bufs) |
| 901 | { |
| 902 | // INVALID_VALUE is generated if n is negative or greater than value of MAX_DRAW_BUFFERS |
| 903 | if (n < 0 || static_cast<GLuint>(n) > context->getCaps().maxDrawBuffers) |
| 904 | { |
| 905 | context->recordError( |
| 906 | Error(GL_INVALID_VALUE, "n must be non-negative and no greater than MAX_DRAW_BUFFERS")); |
| 907 | return false; |
| 908 | } |
| 909 | |
| 910 | ASSERT(context->getState().getDrawFramebuffer()); |
| 911 | GLuint frameBufferId = context->getState().getDrawFramebuffer()->id(); |
| 912 | GLuint maxColorAttachment = GL_COLOR_ATTACHMENT0_EXT + context->getCaps().maxColorAttachments; |
| 913 | |
| 914 | // This should come first before the check for the default frame buffer |
| 915 | // because when we switch to ES3.1+, invalid enums will return INVALID_ENUM |
| 916 | // rather than INVALID_OPERATION |
| 917 | for (int colorAttachment = 0; colorAttachment < n; colorAttachment++) |
| 918 | { |
| 919 | const GLenum attachment = GL_COLOR_ATTACHMENT0_EXT + colorAttachment; |
| 920 | |
| 921 | if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != GL_BACK && |
| 922 | (bufs[colorAttachment] < GL_COLOR_ATTACHMENT0_EXT || |
| 923 | bufs[colorAttachment] >= maxColorAttachment)) |
| 924 | { |
| 925 | // Value in bufs is not NONE, BACK, or GL_COLOR_ATTACHMENTi |
| 926 | // In the 3.0 specs, the error should return GL_INVALID_OPERATION. |
| 927 | // When we move to 3.1 specs, we should change the error to be GL_INVALID_ENUM |
| 928 | context->recordError(Error(GL_INVALID_OPERATION, "Invalid buffer value")); |
| 929 | return false; |
| 930 | } |
| 931 | else if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != attachment && |
| 932 | frameBufferId != 0) |
| 933 | { |
| 934 | // INVALID_OPERATION-GL is bound to buffer and ith argument |
| 935 | // is not COLOR_ATTACHMENTi or NONE |
| 936 | context->recordError( |
| 937 | Error(GL_INVALID_OPERATION, "Ith value does not match COLOR_ATTACHMENTi or NONE")); |
| 938 | return false; |
| 939 | } |
| 940 | } |
| 941 | |
| 942 | // INVALID_OPERATION is generated if GL is bound to the default framebuffer |
| 943 | // and n is not 1 or bufs is bound to value other than BACK and NONE |
| 944 | if (frameBufferId == 0) |
| 945 | { |
| 946 | if (n != 1) |
| 947 | { |
| 948 | context->recordError(Error(GL_INVALID_OPERATION, |
| 949 | "n must be 1 when GL is bound to the default framebuffer")); |
| 950 | return false; |
| 951 | } |
| 952 | |
| 953 | if (bufs[0] != GL_NONE && bufs[0] != GL_BACK) |
| 954 | { |
| 955 | context->recordError(Error( |
| 956 | GL_INVALID_OPERATION, |
| 957 | "Only NONE or BACK are valid values when drawing to the default framebuffer")); |
| 958 | return false; |
| 959 | } |
| 960 | } |
| 961 | |
| 962 | return true; |
| 963 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 964 | } |