blob: 29b3eff88a2dcd424405a9c28c897695479a8a22 [file] [log] [blame]
John Stiles44e96be2020-08-31 13:16:04 -04001/*
2 * Copyright 2020 Google LLC
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8#include "src/sksl/SkSLInliner.h"
9
John Stiles2d7973a2020-10-02 15:01:03 -040010#include <limits.h>
John Stiles44e96be2020-08-31 13:16:04 -040011#include <memory>
12#include <unordered_set>
13
Ethan Nicholasdaed2592021-03-04 14:30:25 -050014#include "include/private/SkSLLayout.h"
John Stiles44e96be2020-08-31 13:16:04 -040015#include "src/sksl/SkSLAnalysis.h"
16#include "src/sksl/ir/SkSLBinaryExpression.h"
17#include "src/sksl/ir/SkSLBoolLiteral.h"
18#include "src/sksl/ir/SkSLBreakStatement.h"
19#include "src/sksl/ir/SkSLConstructor.h"
John Stiles7384b372021-04-01 13:48:15 -040020#include "src/sksl/ir/SkSLConstructorArray.h"
John Stiles8cad6372021-04-07 12:31:13 -040021#include "src/sksl/ir/SkSLConstructorCompound.h"
22#include "src/sksl/ir/SkSLConstructorCompoundCast.h"
John Stilese1182782021-03-30 22:09:37 -040023#include "src/sksl/ir/SkSLConstructorDiagonalMatrix.h"
John Stiles5abb9e12021-04-06 13:47:19 -040024#include "src/sksl/ir/SkSLConstructorMatrixResize.h"
John Stilesfd7252f2021-04-04 22:24:40 -040025#include "src/sksl/ir/SkSLConstructorScalarCast.h"
John Stiles2938eea2021-04-01 18:58:25 -040026#include "src/sksl/ir/SkSLConstructorSplat.h"
John Stilesd47330f2021-04-08 23:25:52 -040027#include "src/sksl/ir/SkSLConstructorStruct.h"
John Stiles44e96be2020-08-31 13:16:04 -040028#include "src/sksl/ir/SkSLContinueStatement.h"
29#include "src/sksl/ir/SkSLDiscardStatement.h"
30#include "src/sksl/ir/SkSLDoStatement.h"
31#include "src/sksl/ir/SkSLEnum.h"
32#include "src/sksl/ir/SkSLExpressionStatement.h"
33#include "src/sksl/ir/SkSLExternalFunctionCall.h"
Brian Osmanbe0b3b72021-01-06 14:27:35 -050034#include "src/sksl/ir/SkSLExternalFunctionReference.h"
John Stiles44e96be2020-08-31 13:16:04 -040035#include "src/sksl/ir/SkSLField.h"
36#include "src/sksl/ir/SkSLFieldAccess.h"
37#include "src/sksl/ir/SkSLFloatLiteral.h"
38#include "src/sksl/ir/SkSLForStatement.h"
39#include "src/sksl/ir/SkSLFunctionCall.h"
40#include "src/sksl/ir/SkSLFunctionDeclaration.h"
41#include "src/sksl/ir/SkSLFunctionDefinition.h"
42#include "src/sksl/ir/SkSLFunctionReference.h"
43#include "src/sksl/ir/SkSLIfStatement.h"
44#include "src/sksl/ir/SkSLIndexExpression.h"
John Stiles98c1f822020-09-09 14:18:53 -040045#include "src/sksl/ir/SkSLInlineMarker.h"
John Stiles44e96be2020-08-31 13:16:04 -040046#include "src/sksl/ir/SkSLIntLiteral.h"
47#include "src/sksl/ir/SkSLInterfaceBlock.h"
John Stiles44e96be2020-08-31 13:16:04 -040048#include "src/sksl/ir/SkSLNop.h"
John Stiles44e96be2020-08-31 13:16:04 -040049#include "src/sksl/ir/SkSLPostfixExpression.h"
50#include "src/sksl/ir/SkSLPrefixExpression.h"
51#include "src/sksl/ir/SkSLReturnStatement.h"
52#include "src/sksl/ir/SkSLSetting.h"
53#include "src/sksl/ir/SkSLSwitchCase.h"
54#include "src/sksl/ir/SkSLSwitchStatement.h"
55#include "src/sksl/ir/SkSLSwizzle.h"
56#include "src/sksl/ir/SkSLTernaryExpression.h"
57#include "src/sksl/ir/SkSLUnresolvedFunction.h"
58#include "src/sksl/ir/SkSLVarDeclarations.h"
John Stiles44e96be2020-08-31 13:16:04 -040059#include "src/sksl/ir/SkSLVariable.h"
60#include "src/sksl/ir/SkSLVariableReference.h"
John Stiles44e96be2020-08-31 13:16:04 -040061
62namespace SkSL {
63namespace {
64
John Stiles031a7672020-11-13 16:13:18 -050065static constexpr int kInlinedStatementLimit = 2500;
66
John Stiles44e96be2020-08-31 13:16:04 -040067static int count_returns_at_end_of_control_flow(const FunctionDefinition& funcDef) {
68 class CountReturnsAtEndOfControlFlow : public ProgramVisitor {
69 public:
70 CountReturnsAtEndOfControlFlow(const FunctionDefinition& funcDef) {
71 this->visitProgramElement(funcDef);
72 }
73
John Stiles5b408a32021-03-17 09:53:32 -040074 bool visitExpression(const Expression& expr) override {
75 // Do not recurse into expressions.
76 return false;
77 }
78
John Stiles44e96be2020-08-31 13:16:04 -040079 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -040080 switch (stmt.kind()) {
81 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -040082 // Check only the last statement of a block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -040083 const auto& block = stmt.as<Block>();
84 return block.children().size() &&
85 this->visitStatement(*block.children().back());
John Stiles44e96be2020-08-31 13:16:04 -040086 }
Ethan Nicholase6592142020-09-08 10:22:09 -040087 case Statement::Kind::kSwitch:
Ethan Nicholase6592142020-09-08 10:22:09 -040088 case Statement::Kind::kDo:
89 case Statement::Kind::kFor:
John Stiles44e96be2020-08-31 13:16:04 -040090 // Don't introspect switches or loop structures at all.
91 return false;
92
Ethan Nicholase6592142020-09-08 10:22:09 -040093 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -040094 ++fNumReturns;
95 [[fallthrough]];
96
97 default:
John Stiles93442622020-09-11 12:11:27 -040098 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -040099 }
100 }
101
102 int fNumReturns = 0;
103 using INHERITED = ProgramVisitor;
104 };
105
106 return CountReturnsAtEndOfControlFlow{funcDef}.fNumReturns;
107}
108
John Stiles991b09d2020-09-10 13:33:40 -0400109static bool contains_recursive_call(const FunctionDeclaration& funcDecl) {
110 class ContainsRecursiveCall : public ProgramVisitor {
111 public:
112 bool visit(const FunctionDeclaration& funcDecl) {
113 fFuncDecl = &funcDecl;
Ethan Nicholased84b732020-10-08 11:45:44 -0400114 return funcDecl.definition() ? this->visitProgramElement(*funcDecl.definition())
115 : false;
John Stiles991b09d2020-09-10 13:33:40 -0400116 }
117
118 bool visitExpression(const Expression& expr) override {
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400119 if (expr.is<FunctionCall>() && expr.as<FunctionCall>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400120 return true;
121 }
122 return INHERITED::visitExpression(expr);
123 }
124
125 bool visitStatement(const Statement& stmt) override {
Ethan Nicholasceb62142020-10-09 16:51:18 -0400126 if (stmt.is<InlineMarker>() &&
127 stmt.as<InlineMarker>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400128 return true;
129 }
130 return INHERITED::visitStatement(stmt);
131 }
132
133 const FunctionDeclaration* fFuncDecl;
134 using INHERITED = ProgramVisitor;
135 };
136
137 return ContainsRecursiveCall{}.visit(funcDecl);
138}
139
John Stiles6d696082020-10-01 10:18:54 -0400140static std::unique_ptr<Statement>* find_parent_statement(
141 const std::vector<std::unique_ptr<Statement>*>& stmtStack) {
John Stiles915a38c2020-09-14 09:38:13 -0400142 SkASSERT(!stmtStack.empty());
143
144 // Walk the statement stack from back to front, ignoring the last element (which is the
145 // enclosing statement).
146 auto iter = stmtStack.rbegin();
147 ++iter;
148
149 // Anything counts as a parent statement other than a scopeless Block.
150 for (; iter != stmtStack.rend(); ++iter) {
John Stiles6d696082020-10-01 10:18:54 -0400151 std::unique_ptr<Statement>* stmt = *iter;
152 if (!(*stmt)->is<Block>() || (*stmt)->as<Block>().isScope()) {
John Stiles915a38c2020-09-14 09:38:13 -0400153 return stmt;
154 }
155 }
156
157 // There wasn't any parent statement to be found.
158 return nullptr;
159}
160
John Stilese41b4ee2020-09-28 12:28:16 -0400161std::unique_ptr<Expression> clone_with_ref_kind(const Expression& expr,
162 VariableReference::RefKind refKind) {
163 std::unique_ptr<Expression> clone = expr.clone();
John Stiles47c0a742021-02-09 09:30:35 -0500164 Analysis::UpdateRefKind(clone.get(), refKind);
John Stilese41b4ee2020-09-28 12:28:16 -0400165 return clone;
166}
167
John Stiles77702f12020-12-17 14:38:56 -0500168class CountReturnsWithLimit : public ProgramVisitor {
169public:
170 CountReturnsWithLimit(const FunctionDefinition& funcDef, int limit) : fLimit(limit) {
171 this->visitProgramElement(funcDef);
172 }
173
John Stiles5b408a32021-03-17 09:53:32 -0400174 bool visitExpression(const Expression& expr) override {
175 // Do not recurse into expressions.
176 return false;
177 }
178
John Stiles77702f12020-12-17 14:38:56 -0500179 bool visitStatement(const Statement& stmt) override {
180 switch (stmt.kind()) {
181 case Statement::Kind::kReturn: {
182 ++fNumReturns;
183 fDeepestReturn = std::max(fDeepestReturn, fScopedBlockDepth);
184 return (fNumReturns >= fLimit) || INHERITED::visitStatement(stmt);
185 }
John Stilesc5ff4862020-12-22 13:47:05 -0500186 case Statement::Kind::kVarDeclaration: {
187 if (fScopedBlockDepth > 1) {
188 fVariablesInBlocks = true;
189 }
190 return INHERITED::visitStatement(stmt);
191 }
John Stiles77702f12020-12-17 14:38:56 -0500192 case Statement::Kind::kBlock: {
193 int depthIncrement = stmt.as<Block>().isScope() ? 1 : 0;
194 fScopedBlockDepth += depthIncrement;
195 bool result = INHERITED::visitStatement(stmt);
196 fScopedBlockDepth -= depthIncrement;
John Stilesc5ff4862020-12-22 13:47:05 -0500197 if (fNumReturns == 0 && fScopedBlockDepth <= 1) {
198 // If closing this block puts us back at the top level, and we haven't
199 // encountered any return statements yet, any vardecls we may have encountered
200 // up until this point can be ignored. They are out of scope now, and they were
201 // never used in a return statement.
202 fVariablesInBlocks = false;
203 }
John Stiles77702f12020-12-17 14:38:56 -0500204 return result;
205 }
206 default:
207 return INHERITED::visitStatement(stmt);
208 }
209 }
210
211 int fNumReturns = 0;
212 int fDeepestReturn = 0;
213 int fLimit = 0;
214 int fScopedBlockDepth = 0;
John Stilesc5ff4862020-12-22 13:47:05 -0500215 bool fVariablesInBlocks = false;
John Stiles77702f12020-12-17 14:38:56 -0500216 using INHERITED = ProgramVisitor;
217};
218
John Stiles44e96be2020-08-31 13:16:04 -0400219} // namespace
220
John Stiles77702f12020-12-17 14:38:56 -0500221Inliner::ReturnComplexity Inliner::GetReturnComplexity(const FunctionDefinition& funcDef) {
222 int returnsAtEndOfControlFlow = count_returns_at_end_of_control_flow(funcDef);
223 CountReturnsWithLimit counter{funcDef, returnsAtEndOfControlFlow + 1};
John Stiles77702f12020-12-17 14:38:56 -0500224 if (counter.fNumReturns > returnsAtEndOfControlFlow) {
225 return ReturnComplexity::kEarlyReturns;
226 }
John Stilesc5ff4862020-12-22 13:47:05 -0500227 if (counter.fNumReturns > 1) {
John Stiles77702f12020-12-17 14:38:56 -0500228 return ReturnComplexity::kScopedReturns;
229 }
John Stilesc5ff4862020-12-22 13:47:05 -0500230 if (counter.fVariablesInBlocks && counter.fDeepestReturn > 1) {
231 return ReturnComplexity::kScopedReturns;
232 }
John Stiles8937cd42021-03-17 19:32:59 +0000233 return ReturnComplexity::kSingleSafeReturn;
John Stiles77702f12020-12-17 14:38:56 -0500234}
235
John Stilesb61ee902020-09-21 12:26:59 -0400236void Inliner::ensureScopedBlocks(Statement* inlinedBody, Statement* parentStmt) {
237 // No changes necessary if this statement isn't actually a block.
238 if (!inlinedBody || !inlinedBody->is<Block>()) {
239 return;
240 }
241
242 // No changes necessary if the parent statement doesn't require a scope.
243 if (!parentStmt || !(parentStmt->is<IfStatement>() || parentStmt->is<ForStatement>() ||
Brian Osmand6f23382020-12-15 17:08:59 -0500244 parentStmt->is<DoStatement>())) {
John Stilesb61ee902020-09-21 12:26:59 -0400245 return;
246 }
247
248 Block& block = inlinedBody->as<Block>();
249
250 // The inliner will create inlined function bodies as a Block containing multiple statements,
251 // but no scope. Normally, this is fine, but if this block is used as the statement for a
252 // do/for/if/while, this isn't actually possible to represent textually; a scope must be added
253 // for the generated code to match the intent. In the case of Blocks nested inside other Blocks,
254 // we add the scope to the outermost block if needed. Zero-statement blocks have similar
255 // issues--if we don't represent the Block textually somehow, we run the risk of accidentally
256 // absorbing the following statement into our loop--so we also add a scope to these.
257 for (Block* nestedBlock = &block;; ) {
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400258 if (nestedBlock->isScope()) {
John Stilesb61ee902020-09-21 12:26:59 -0400259 // We found an explicit scope; all is well.
260 return;
261 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400262 if (nestedBlock->children().size() != 1) {
John Stilesb61ee902020-09-21 12:26:59 -0400263 // We found a block with multiple (or zero) statements, but no scope? Let's add a scope
264 // to the outermost block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400265 block.setIsScope(true);
John Stilesb61ee902020-09-21 12:26:59 -0400266 return;
267 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400268 if (!nestedBlock->children()[0]->is<Block>()) {
John Stilesb61ee902020-09-21 12:26:59 -0400269 // This block has exactly one thing inside, and it's not another block. No need to scope
270 // it.
271 return;
272 }
273 // We have to go deeper.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400274 nestedBlock = &nestedBlock->children()[0]->as<Block>();
John Stilesb61ee902020-09-21 12:26:59 -0400275 }
276}
277
John Stilesd1204642021-02-17 16:30:02 -0500278void Inliner::reset(ModifiersPool* modifiers) {
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400279 fModifiers = modifiers;
Ethan Nicholas6f4eee22021-01-11 12:37:42 -0500280 fMangler.reset();
John Stiles031a7672020-11-13 16:13:18 -0500281 fInlinedStatementCounter = 0;
John Stiles44e96be2020-08-31 13:16:04 -0400282}
283
284std::unique_ptr<Expression> Inliner::inlineExpression(int offset,
285 VariableRewriteMap* varMap,
John Stilesd7cc0932020-11-30 12:24:27 -0500286 SymbolTable* symbolTableForExpression,
John Stiles44e96be2020-08-31 13:16:04 -0400287 const Expression& expression) {
288 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
289 if (e) {
John Stilesd7cc0932020-11-30 12:24:27 -0500290 return this->inlineExpression(offset, varMap, symbolTableForExpression, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400291 }
292 return nullptr;
293 };
John Stiles8e3b6be2020-10-13 11:14:08 -0400294 auto argList = [&](const ExpressionArray& originalArgs) -> ExpressionArray {
295 ExpressionArray args;
John Stilesf4bda742020-10-14 16:57:41 -0400296 args.reserve_back(originalArgs.size());
John Stiles44e96be2020-08-31 13:16:04 -0400297 for (const std::unique_ptr<Expression>& arg : originalArgs) {
298 args.push_back(expr(arg));
299 }
300 return args;
301 };
302
Ethan Nicholase6592142020-09-08 10:22:09 -0400303 switch (expression.kind()) {
304 case Expression::Kind::kBinary: {
John Stiles6a1a98c2021-01-14 18:35:34 -0500305 const BinaryExpression& binaryExpr = expression.as<BinaryExpression>();
John Stilese2aec432021-03-01 09:27:48 -0500306 return BinaryExpression::Make(*fContext,
307 expr(binaryExpr.left()),
308 binaryExpr.getOperator(),
309 expr(binaryExpr.right()));
John Stiles44e96be2020-08-31 13:16:04 -0400310 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400311 case Expression::Kind::kBoolLiteral:
312 case Expression::Kind::kIntLiteral:
313 case Expression::Kind::kFloatLiteral:
John Stiles44e96be2020-08-31 13:16:04 -0400314 return expression.clone();
John Stiles7384b372021-04-01 13:48:15 -0400315 case Expression::Kind::kConstructorArray: {
316 const ConstructorArray& ctor = expression.as<ConstructorArray>();
317 return ConstructorArray::Make(*fContext, offset,
318 *ctor.type().clone(symbolTableForExpression),
319 argList(ctor.arguments()));
320 }
John Stiles8cad6372021-04-07 12:31:13 -0400321 case Expression::Kind::kConstructorCompound: {
322 const ConstructorCompound& ctor = expression.as<ConstructorCompound>();
323 return ConstructorCompound::Make(*fContext, offset,
John Stiles2bec8ab2021-04-06 18:40:04 -0400324 *ctor.type().clone(symbolTableForExpression),
325 argList(ctor.arguments()));
326 }
John Stiles8cad6372021-04-07 12:31:13 -0400327 case Expression::Kind::kConstructorCompoundCast: {
328 const ConstructorCompoundCast& ctor = expression.as<ConstructorCompoundCast>();
329 return ConstructorCompoundCast::Make(*fContext, offset,
John Stiles268a73f2021-04-07 12:30:22 -0400330 *ctor.type().clone(symbolTableForExpression),
331 expr(ctor.argument()));
332 }
John Stilese1182782021-03-30 22:09:37 -0400333 case Expression::Kind::kConstructorDiagonalMatrix: {
334 const ConstructorDiagonalMatrix& ctor = expression.as<ConstructorDiagonalMatrix>();
335 return ConstructorDiagonalMatrix::Make(*fContext, offset,
336 *ctor.type().clone(symbolTableForExpression),
337 expr(ctor.argument()));
338 }
John Stiles5abb9e12021-04-06 13:47:19 -0400339 case Expression::Kind::kConstructorMatrixResize: {
340 const ConstructorMatrixResize& ctor = expression.as<ConstructorMatrixResize>();
341 return ConstructorMatrixResize::Make(*fContext, offset,
342 *ctor.type().clone(symbolTableForExpression),
343 expr(ctor.argument()));
344 }
John Stilesfd7252f2021-04-04 22:24:40 -0400345 case Expression::Kind::kConstructorScalarCast: {
346 const ConstructorScalarCast& ctor = expression.as<ConstructorScalarCast>();
347 return ConstructorScalarCast::Make(*fContext, offset,
348 *ctor.type().clone(symbolTableForExpression),
349 expr(ctor.argument()));
350 }
John Stiles2938eea2021-04-01 18:58:25 -0400351 case Expression::Kind::kConstructorSplat: {
352 const ConstructorSplat& ctor = expression.as<ConstructorSplat>();
353 return ConstructorSplat::Make(*fContext, offset,
354 *ctor.type().clone(symbolTableForExpression),
355 expr(ctor.argument()));
356 }
John Stilesd47330f2021-04-08 23:25:52 -0400357 case Expression::Kind::kConstructorStruct: {
358 const ConstructorStruct& ctor = expression.as<ConstructorStruct>();
359 return ConstructorStruct::Make(*fContext, offset,
360 *ctor.type().clone(symbolTableForExpression),
361 argList(ctor.arguments()));
362 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400363 case Expression::Kind::kExternalFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400364 const ExternalFunctionCall& externalCall = expression.as<ExternalFunctionCall>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400365 return std::make_unique<ExternalFunctionCall>(offset, &externalCall.function(),
Ethan Nicholas6e86ec92020-09-30 14:29:56 -0400366 argList(externalCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400367 }
Brian Osmanbe0b3b72021-01-06 14:27:35 -0500368 case Expression::Kind::kExternalFunctionReference:
John Stiles44e96be2020-08-31 13:16:04 -0400369 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400370 case Expression::Kind::kFieldAccess: {
John Stiles44e96be2020-08-31 13:16:04 -0400371 const FieldAccess& f = expression.as<FieldAccess>();
John Stiles06d600f2021-03-08 09:18:21 -0500372 return FieldAccess::Make(*fContext, expr(f.base()), f.fieldIndex(), f.ownerKind());
John Stiles44e96be2020-08-31 13:16:04 -0400373 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400374 case Expression::Kind::kFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400375 const FunctionCall& funcCall = expression.as<FunctionCall>();
John Stilescd7ba502021-03-19 10:54:59 -0400376 return FunctionCall::Make(*fContext,
377 offset,
378 funcCall.type().clone(symbolTableForExpression),
379 funcCall.function(),
380 argList(funcCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400381 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400382 case Expression::Kind::kFunctionReference:
Brian Osman2b3b35f2020-09-08 09:17:36 -0400383 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400384 case Expression::Kind::kIndex: {
John Stiles44e96be2020-08-31 13:16:04 -0400385 const IndexExpression& idx = expression.as<IndexExpression>();
John Stiles51d33982021-03-08 09:18:07 -0500386 return IndexExpression::Make(*fContext, expr(idx.base()), expr(idx.index()));
John Stiles44e96be2020-08-31 13:16:04 -0400387 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400388 case Expression::Kind::kPrefix: {
John Stiles44e96be2020-08-31 13:16:04 -0400389 const PrefixExpression& p = expression.as<PrefixExpression>();
John Stilesb0eb20f2021-02-26 15:29:33 -0500390 return PrefixExpression::Make(*fContext, p.getOperator(), expr(p.operand()));
John Stiles44e96be2020-08-31 13:16:04 -0400391 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400392 case Expression::Kind::kPostfix: {
John Stiles44e96be2020-08-31 13:16:04 -0400393 const PostfixExpression& p = expression.as<PostfixExpression>();
John Stiles52d3b012021-02-26 15:56:48 -0500394 return PostfixExpression::Make(*fContext, expr(p.operand()), p.getOperator());
John Stiles44e96be2020-08-31 13:16:04 -0400395 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400396 case Expression::Kind::kSetting:
John Stiles44e96be2020-08-31 13:16:04 -0400397 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400398 case Expression::Kind::kSwizzle: {
John Stiles44e96be2020-08-31 13:16:04 -0400399 const Swizzle& s = expression.as<Swizzle>();
John Stiles6e88e042021-02-19 14:09:38 -0500400 return Swizzle::Make(*fContext, expr(s.base()), s.components());
John Stiles44e96be2020-08-31 13:16:04 -0400401 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400402 case Expression::Kind::kTernary: {
John Stiles44e96be2020-08-31 13:16:04 -0400403 const TernaryExpression& t = expression.as<TernaryExpression>();
John Stiles90518f72021-02-26 20:44:54 -0500404 return TernaryExpression::Make(*fContext, expr(t.test()),
405 expr(t.ifTrue()), expr(t.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400406 }
Brian Osman83ba9302020-09-11 13:33:46 -0400407 case Expression::Kind::kTypeReference:
408 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400409 case Expression::Kind::kVariableReference: {
John Stiles44e96be2020-08-31 13:16:04 -0400410 const VariableReference& v = expression.as<VariableReference>();
Ethan Nicholas78686922020-10-08 06:46:27 -0400411 auto varMapIter = varMap->find(v.variable());
John Stilese41b4ee2020-09-28 12:28:16 -0400412 if (varMapIter != varMap->end()) {
Ethan Nicholas78686922020-10-08 06:46:27 -0400413 return clone_with_ref_kind(*varMapIter->second, v.refKind());
John Stiles44e96be2020-08-31 13:16:04 -0400414 }
415 return v.clone();
416 }
417 default:
418 SkASSERT(false);
419 return nullptr;
420 }
421}
422
423std::unique_ptr<Statement> Inliner::inlineStatement(int offset,
424 VariableRewriteMap* varMap,
425 SymbolTable* symbolTableForStatement,
John Stiles77702f12020-12-17 14:38:56 -0500426 std::unique_ptr<Expression>* resultExpr,
427 ReturnComplexity returnComplexity,
Brian Osman3887a012020-09-30 13:22:27 -0400428 const Statement& statement,
429 bool isBuiltinCode) {
John Stiles44e96be2020-08-31 13:16:04 -0400430 auto stmt = [&](const std::unique_ptr<Statement>& s) -> std::unique_ptr<Statement> {
431 if (s) {
John Stilesa5f3c312020-09-22 12:05:16 -0400432 return this->inlineStatement(offset, varMap, symbolTableForStatement, resultExpr,
John Stiles77702f12020-12-17 14:38:56 -0500433 returnComplexity, *s, isBuiltinCode);
John Stiles44e96be2020-08-31 13:16:04 -0400434 }
435 return nullptr;
436 };
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400437 auto blockStmts = [&](const Block& block) {
John Stiles8f2a0cf2020-10-13 12:48:21 -0400438 StatementArray result;
John Stilesf4bda742020-10-14 16:57:41 -0400439 result.reserve_back(block.children().size());
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400440 for (const std::unique_ptr<Statement>& child : block.children()) {
441 result.push_back(stmt(child));
442 }
443 return result;
444 };
John Stiles44e96be2020-08-31 13:16:04 -0400445 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
446 if (e) {
John Stilesd7cc0932020-11-30 12:24:27 -0500447 return this->inlineExpression(offset, varMap, symbolTableForStatement, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400448 }
449 return nullptr;
450 };
John Stiles031a7672020-11-13 16:13:18 -0500451
452 ++fInlinedStatementCounter;
453
Ethan Nicholase6592142020-09-08 10:22:09 -0400454 switch (statement.kind()) {
455 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -0400456 const Block& b = statement.as<Block>();
John Stilesbf16b6c2021-03-12 19:24:31 -0500457 return Block::Make(offset, blockStmts(b),
458 SymbolTable::WrapIfBuiltin(b.symbolTable()),
459 b.isScope());
John Stiles44e96be2020-08-31 13:16:04 -0400460 }
461
Ethan Nicholase6592142020-09-08 10:22:09 -0400462 case Statement::Kind::kBreak:
463 case Statement::Kind::kContinue:
464 case Statement::Kind::kDiscard:
John Stiles44e96be2020-08-31 13:16:04 -0400465 return statement.clone();
466
Ethan Nicholase6592142020-09-08 10:22:09 -0400467 case Statement::Kind::kDo: {
John Stiles44e96be2020-08-31 13:16:04 -0400468 const DoStatement& d = statement.as<DoStatement>();
John Stilesea5822e2021-02-26 11:18:20 -0500469 return DoStatement::Make(*fContext, stmt(d.statement()), expr(d.test()));
John Stiles44e96be2020-08-31 13:16:04 -0400470 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400471 case Statement::Kind::kExpression: {
John Stiles44e96be2020-08-31 13:16:04 -0400472 const ExpressionStatement& e = statement.as<ExpressionStatement>();
John Stiles3e5871c2021-02-25 20:52:03 -0500473 return ExpressionStatement::Make(*fContext, expr(e.expression()));
John Stiles44e96be2020-08-31 13:16:04 -0400474 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400475 case Statement::Kind::kFor: {
John Stiles44e96be2020-08-31 13:16:04 -0400476 const ForStatement& f = statement.as<ForStatement>();
477 // need to ensure initializer is evaluated first so that we've already remapped its
478 // declarations by the time we evaluate test & next
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400479 std::unique_ptr<Statement> initializer = stmt(f.initializer());
John Stilesb321a072021-02-25 16:24:19 -0500480 return ForStatement::Make(*fContext, offset, std::move(initializer), expr(f.test()),
481 expr(f.next()), stmt(f.statement()),
482 SymbolTable::WrapIfBuiltin(f.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400483 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400484 case Statement::Kind::kIf: {
John Stiles44e96be2020-08-31 13:16:04 -0400485 const IfStatement& i = statement.as<IfStatement>();
John Stilescf3059e2021-02-25 14:27:02 -0500486 return IfStatement::Make(*fContext, offset, i.isStatic(), expr(i.test()),
487 stmt(i.ifTrue()), stmt(i.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400488 }
John Stiles98c1f822020-09-09 14:18:53 -0400489 case Statement::Kind::kInlineMarker:
Ethan Nicholase6592142020-09-08 10:22:09 -0400490 case Statement::Kind::kNop:
John Stiles44e96be2020-08-31 13:16:04 -0400491 return statement.clone();
John Stilesea5822e2021-02-26 11:18:20 -0500492
Ethan Nicholase6592142020-09-08 10:22:09 -0400493 case Statement::Kind::kReturn: {
John Stiles44e96be2020-08-31 13:16:04 -0400494 const ReturnStatement& r = statement.as<ReturnStatement>();
John Stiles77702f12020-12-17 14:38:56 -0500495 if (!r.expression()) {
John Stilesdc208472021-03-17 10:58:16 -0400496 // This function doesn't return a value. We won't inline functions with early
497 // returns, so a return statement is a no-op and can be treated as such.
498 return Nop::Make();
John Stiles44e96be2020-08-31 13:16:04 -0400499 }
John Stiles77702f12020-12-17 14:38:56 -0500500
John Stilesc5ff4862020-12-22 13:47:05 -0500501 // If a function only contains a single return, and it doesn't reference variables from
502 // inside an Block's scope, we don't need to store the result in a variable at all. Just
503 // replace the function-call expression with the function's return expression.
John Stiles77702f12020-12-17 14:38:56 -0500504 SkASSERT(resultExpr);
John Stilesc5ff4862020-12-22 13:47:05 -0500505 if (returnComplexity <= ReturnComplexity::kSingleSafeReturn) {
John Stiles77702f12020-12-17 14:38:56 -0500506 *resultExpr = expr(r.expression());
John Stilesa0c04d62021-03-11 23:07:24 -0500507 return Nop::Make();
John Stiles77702f12020-12-17 14:38:56 -0500508 }
509
510 // For more complex functions, assign their result into a variable.
John Stiles511c5002021-02-25 11:17:02 -0500511 SkASSERT(*resultExpr);
John Stiles3e5871c2021-02-25 20:52:03 -0500512 auto assignment = ExpressionStatement::Make(
513 *fContext,
John Stilese2aec432021-03-01 09:27:48 -0500514 BinaryExpression::Make(
515 *fContext,
516 clone_with_ref_kind(**resultExpr, VariableRefKind::kWrite),
John Stiles77702f12020-12-17 14:38:56 -0500517 Token::Kind::TK_EQ,
John Stilese2aec432021-03-01 09:27:48 -0500518 expr(r.expression())));
John Stiles77702f12020-12-17 14:38:56 -0500519
John Stiles77702f12020-12-17 14:38:56 -0500520 // Functions without early returns aren't wrapped in a for loop and don't need to worry
521 // about breaking out of the control flow.
John Stiles3e5871c2021-02-25 20:52:03 -0500522 return assignment;
John Stiles44e96be2020-08-31 13:16:04 -0400523 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400524 case Statement::Kind::kSwitch: {
John Stiles44e96be2020-08-31 13:16:04 -0400525 const SwitchStatement& ss = statement.as<SwitchStatement>();
John Stilesb23a64b2021-03-11 08:27:59 -0500526 StatementArray cases;
527 cases.reserve_back(ss.cases().size());
528 for (const std::unique_ptr<Statement>& statement : ss.cases()) {
529 const SwitchCase& sc = statement->as<SwitchCase>();
530 cases.push_back(std::make_unique<SwitchCase>(offset, expr(sc.value()),
531 stmt(sc.statement())));
John Stiles44e96be2020-08-31 13:16:04 -0400532 }
John Stilese1d1b082021-02-23 13:44:36 -0500533 return SwitchStatement::Make(*fContext, offset, ss.isStatic(), expr(ss.value()),
534 std::move(cases), SymbolTable::WrapIfBuiltin(ss.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400535 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400536 case Statement::Kind::kVarDeclaration: {
John Stiles44e96be2020-08-31 13:16:04 -0400537 const VarDeclaration& decl = statement.as<VarDeclaration>();
John Stiles35fee4c2020-12-16 18:25:14 +0000538 std::unique_ptr<Expression> initialValue = expr(decl.value());
John Stilesddcc8432021-01-15 15:32:32 -0500539 const Variable& variable = decl.var();
540
John Stiles35fee4c2020-12-16 18:25:14 +0000541 // We assign unique names to inlined variables--scopes hide most of the problems in this
542 // regard, but see `InlinerAvoidsVariableNameOverlap` for a counterexample where unique
543 // names are important.
John Stilesd51c9792021-03-18 11:40:14 -0400544 const String* name = symbolTableForStatement->takeOwnershipOfString(
545 fMangler.uniqueName(variable.name(), symbolTableForStatement));
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500546 auto clonedVar = std::make_unique<Variable>(
547 offset,
548 &variable.modifiers(),
John Stilesd51c9792021-03-18 11:40:14 -0400549 name->c_str(),
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500550 variable.type().clone(symbolTableForStatement),
551 isBuiltinCode,
552 variable.storage());
553 (*varMap)[&variable] = std::make_unique<VariableReference>(offset, clonedVar.get());
John Stilese67bd132021-03-19 18:39:25 -0400554 auto result = VarDeclaration::Make(*fContext,
555 clonedVar.get(),
556 decl.baseType().clone(symbolTableForStatement),
557 decl.arraySize(),
558 std::move(initialValue));
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500559 symbolTableForStatement->takeOwnershipOfSymbol(std::move(clonedVar));
John Stilese67bd132021-03-19 18:39:25 -0400560 return result;
John Stiles44e96be2020-08-31 13:16:04 -0400561 }
John Stiles44e96be2020-08-31 13:16:04 -0400562 default:
563 SkASSERT(false);
564 return nullptr;
565 }
566}
567
John Stiles7b920442020-12-17 10:43:41 -0500568Inliner::InlineVariable Inliner::makeInlineVariable(const String& baseName,
569 const Type* type,
570 SymbolTable* symbolTable,
571 Modifiers modifiers,
572 bool isBuiltinCode,
573 std::unique_ptr<Expression>* initialValue) {
574 // $floatLiteral or $intLiteral aren't real types that we can use for scratch variables, so
575 // replace them if they ever appear here. If this happens, we likely forgot to coerce a type
576 // somewhere during compilation.
John Stiles14975272021-01-12 11:41:14 -0500577 if (type->isLiteral()) {
578 SkDEBUGFAIL("found a $literal type while inlining");
579 type = &type->scalarTypeForLiteral();
John Stiles7b920442020-12-17 10:43:41 -0500580 }
581
John Stilesbff24ab2021-03-17 13:20:10 -0400582 // Out parameters aren't supported.
583 SkASSERT(!(modifiers.fFlags & Modifiers::kOut_Flag));
584
John Stiles7b920442020-12-17 10:43:41 -0500585 // Provide our new variable with a unique name, and add it to our symbol table.
John Stilesd51c9792021-03-18 11:40:14 -0400586 const String* name =
587 symbolTable->takeOwnershipOfString(fMangler.uniqueName(baseName, symbolTable));
John Stiles7b920442020-12-17 10:43:41 -0500588
589 // Create our new variable and add it to the symbol table.
590 InlineVariable result;
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500591 auto var = std::make_unique<Variable>(/*offset=*/-1,
592 fModifiers->addToPool(Modifiers()),
John Stilesd51c9792021-03-18 11:40:14 -0400593 name->c_str(),
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500594 type,
595 isBuiltinCode,
596 Variable::Storage::kLocal);
John Stiles7b920442020-12-17 10:43:41 -0500597
John Stilesbff24ab2021-03-17 13:20:10 -0400598 // Create our variable declaration.
John Stilese67bd132021-03-19 18:39:25 -0400599 result.fVarDecl = VarDeclaration::Make(*fContext, var.get(), type, /*arraySize=*/0,
600 std::move(*initialValue));
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500601 result.fVarSymbol = symbolTable->add(std::move(var));
John Stiles7b920442020-12-17 10:43:41 -0500602 return result;
603}
604
John Stiles6eadf132020-09-08 10:16:10 -0400605Inliner::InlinedCall Inliner::inlineCall(FunctionCall* call,
John Stiles78047582020-12-16 16:17:41 -0500606 std::shared_ptr<SymbolTable> symbolTable,
John Stiles30fce9c2021-03-18 09:24:06 -0400607 const ProgramUsage& usage,
Brian Osman3887a012020-09-30 13:22:27 -0400608 const FunctionDeclaration* caller) {
John Stiles44e96be2020-08-31 13:16:04 -0400609 // Inlining is more complicated here than in a typical compiler, because we have to have a
610 // high-level IR and can't just drop statements into the middle of an expression or even use
611 // gotos.
612 //
613 // Since we can't insert statements into an expression, we run the inline function as extra
614 // statements before the statement we're currently processing, relying on a lack of execution
615 // order guarantees. Since we can't use gotos (which are normally used to replace return
616 // statements), we wrap the whole function in a loop and use break statements to jump to the
617 // end.
John Stiles44e96be2020-08-31 13:16:04 -0400618 SkASSERT(fContext);
619 SkASSERT(call);
Ethan Nicholased84b732020-10-08 11:45:44 -0400620 SkASSERT(this->isSafeToInline(call->function().definition()));
John Stiles44e96be2020-08-31 13:16:04 -0400621
John Stiles8e3b6be2020-10-13 11:14:08 -0400622 ExpressionArray& arguments = call->arguments();
John Stiles6eadf132020-09-08 10:16:10 -0400623 const int offset = call->fOffset;
Ethan Nicholased84b732020-10-08 11:45:44 -0400624 const FunctionDefinition& function = *call->function().definition();
John Stiles28257db2021-03-17 15:18:09 -0400625 const Block& body = function.body()->as<Block>();
John Stiles77702f12020-12-17 14:38:56 -0500626 const ReturnComplexity returnComplexity = GetReturnComplexity(function);
John Stiles6eadf132020-09-08 10:16:10 -0400627
John Stiles28257db2021-03-17 15:18:09 -0400628 StatementArray inlineStatements;
629 int expectedStmtCount = 1 + // Inline marker
630 1 + // Result variable
631 arguments.size() + // Function argument temp-vars
632 body.children().size(); // Inlined code
John Stiles98c1f822020-09-09 14:18:53 -0400633
John Stiles28257db2021-03-17 15:18:09 -0400634 inlineStatements.reserve_back(expectedStmtCount);
635 inlineStatements.push_back(InlineMarker::Make(&call->function()));
John Stiles44e96be2020-08-31 13:16:04 -0400636
John Stilese41b4ee2020-09-28 12:28:16 -0400637 std::unique_ptr<Expression> resultExpr;
John Stiles511c5002021-02-25 11:17:02 -0500638 if (returnComplexity > ReturnComplexity::kSingleSafeReturn &&
John Stiles2558c462021-03-16 17:49:20 -0400639 !function.declaration().returnType().isVoid()) {
John Stiles511c5002021-02-25 11:17:02 -0500640 // Create a variable to hold the result in the extra statements. We don't need to do this
641 // for void-return functions, or in cases that are simple enough that we can just replace
642 // the function-call node with the result expression.
John Stiles44e96be2020-08-31 13:16:04 -0400643 std::unique_ptr<Expression> noInitialValue;
John Stiles7b920442020-12-17 10:43:41 -0500644 InlineVariable var = this->makeInlineVariable(function.declaration().name(),
645 &function.declaration().returnType(),
646 symbolTable.get(), Modifiers{},
647 caller->isBuiltin(), &noInitialValue);
John Stiles28257db2021-03-17 15:18:09 -0400648 inlineStatements.push_back(std::move(var.fVarDecl));
John Stiles7b920442020-12-17 10:43:41 -0500649 resultExpr = std::make_unique<VariableReference>(/*offset=*/-1, var.fVarSymbol);
John Stiles511c5002021-02-25 11:17:02 -0500650 }
John Stiles44e96be2020-08-31 13:16:04 -0400651
652 // Create variables in the extra statements to hold the arguments, and assign the arguments to
653 // them.
654 VariableRewriteMap varMap;
John Stilesbff24ab2021-03-17 13:20:10 -0400655 for (int i = 0; i < arguments.count(); ++i) {
John Stiles049f0df2021-03-19 09:39:44 -0400656 // If the parameter isn't written to within the inline function ...
John Stilesbff24ab2021-03-17 13:20:10 -0400657 const Variable* param = function.declaration().parameters()[i];
John Stiles049f0df2021-03-19 09:39:44 -0400658 const ProgramUsage::VariableCounts& paramUsage = usage.get(*param);
659 if (!paramUsage.fWrite) {
660 // ... and can be inlined trivially (e.g. a swizzle, or a constant array index),
661 // or any expression without side effects that is only accessed at most once...
662 if ((paramUsage.fRead > 1) ? Analysis::IsTrivialExpression(*arguments[i])
663 : !arguments[i]->hasSideEffects()) {
John Stilesf201af82020-09-29 16:57:55 -0400664 // ... we don't need to copy it at all! We can just use the existing expression.
665 varMap[param] = arguments[i]->clone();
John Stiles44e96be2020-08-31 13:16:04 -0400666 continue;
667 }
668 }
John Stiles7b920442020-12-17 10:43:41 -0500669 InlineVariable var = this->makeInlineVariable(param->name(), &arguments[i]->type(),
670 symbolTable.get(), param->modifiers(),
671 caller->isBuiltin(), &arguments[i]);
John Stiles28257db2021-03-17 15:18:09 -0400672 inlineStatements.push_back(std::move(var.fVarDecl));
John Stiles7b920442020-12-17 10:43:41 -0500673 varMap[param] = std::make_unique<VariableReference>(/*offset=*/-1, var.fVarSymbol);
John Stiles44e96be2020-08-31 13:16:04 -0400674 }
675
John Stiles7b920442020-12-17 10:43:41 -0500676 for (const std::unique_ptr<Statement>& stmt : body.children()) {
John Stiles28257db2021-03-17 15:18:09 -0400677 inlineStatements.push_back(this->inlineStatement(offset, &varMap, symbolTable.get(),
678 &resultExpr, returnComplexity, *stmt,
679 caller->isBuiltin()));
John Stiles44e96be2020-08-31 13:16:04 -0400680 }
681
John Stiles28257db2021-03-17 15:18:09 -0400682 SkASSERT(inlineStatements.count() <= expectedStmtCount);
683
John Stilesbf16b6c2021-03-12 19:24:31 -0500684 // Wrap all of the generated statements in a block. We need a real Block here, so we can't use
685 // MakeUnscoped. This is because we need to add another child statement to the Block later.
John Stiles28257db2021-03-17 15:18:09 -0400686 InlinedCall inlinedCall;
687 inlinedCall.fInlinedBody = Block::Make(offset, std::move(inlineStatements),
John Stilesbf16b6c2021-03-12 19:24:31 -0500688 /*symbols=*/nullptr, /*isScope=*/false);
689
John Stiles0c2d14a2021-03-01 10:08:08 -0500690 if (resultExpr) {
691 // Return our result expression as-is.
John Stilese41b4ee2020-09-28 12:28:16 -0400692 inlinedCall.fReplacementExpr = std::move(resultExpr);
John Stiles2558c462021-03-16 17:49:20 -0400693 } else if (function.declaration().returnType().isVoid()) {
John Stiles44e96be2020-08-31 13:16:04 -0400694 // It's a void function, so it doesn't actually result in anything, but we have to return
695 // something non-null as a standin.
John Stiles9ce80f72021-03-11 22:35:19 -0500696 inlinedCall.fReplacementExpr = BoolLiteral::Make(*fContext, offset, /*value=*/false);
John Stiles0c2d14a2021-03-01 10:08:08 -0500697 } else {
698 // It's a non-void function, but it never created a result expression--that is, it never
John Stiles2dda50d2021-03-03 10:46:44 -0500699 // returned anything on any path! This should have been detected in the function finalizer.
700 // Still, discard our output and generate an error.
701 SkDEBUGFAIL("inliner found non-void function that fails to return a value on any path");
702 fContext->fErrors.error(function.fOffset, "inliner found non-void function '" +
John Stiles0c2d14a2021-03-01 10:08:08 -0500703 function.declaration().name() +
John Stiles2dda50d2021-03-03 10:46:44 -0500704 "' that fails to return a value on any path");
John Stiles0c2d14a2021-03-01 10:08:08 -0500705 inlinedCall = {};
John Stiles44e96be2020-08-31 13:16:04 -0400706 }
707
John Stiles44e96be2020-08-31 13:16:04 -0400708 return inlinedCall;
709}
710
John Stiles2d7973a2020-10-02 15:01:03 -0400711bool Inliner::isSafeToInline(const FunctionDefinition* functionDef) {
John Stiles1c03d332020-10-13 10:30:23 -0400712 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
John Stilesd1204642021-02-17 16:30:02 -0500713 if (this->settings().fInlineThreshold <= 0) {
John Stiles1c03d332020-10-13 10:30:23 -0400714 return false;
715 }
716
John Stiles031a7672020-11-13 16:13:18 -0500717 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
718 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
719 return false;
720 }
721
John Stiles2d7973a2020-10-02 15:01:03 -0400722 if (functionDef == nullptr) {
John Stiles44e96be2020-08-31 13:16:04 -0400723 // Can't inline something if we don't actually have its definition.
724 return false;
725 }
John Stiles2d7973a2020-10-02 15:01:03 -0400726
John Stiles0dd1a772021-03-09 22:14:27 -0500727 if (functionDef->declaration().modifiers().fFlags & Modifiers::kNoInline_Flag) {
728 // Refuse to inline functions decorated with `noinline`.
729 return false;
730 }
731
John Stilesbff24ab2021-03-17 13:20:10 -0400732 // We don't allow inlining a function with out parameters. (See skia:11326 for rationale.)
733 for (const Variable* param : functionDef->declaration().parameters()) {
734 if (param->modifiers().fFlags & Modifiers::Flag::kOut_Flag) {
735 return false;
736 }
737 }
738
John Stilesdc208472021-03-17 10:58:16 -0400739 // We don't have a mechanism to simulate early returns, so we can't inline if there is one.
740 return GetReturnComplexity(*functionDef) < ReturnComplexity::kEarlyReturns;
John Stiles44e96be2020-08-31 13:16:04 -0400741}
742
John Stiles2d7973a2020-10-02 15:01:03 -0400743// A candidate function for inlining, containing everything that `inlineCall` needs.
744struct InlineCandidate {
John Stiles78047582020-12-16 16:17:41 -0500745 std::shared_ptr<SymbolTable> fSymbols; // the SymbolTable of the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400746 std::unique_ptr<Statement>* fParentStmt; // the parent Statement of the enclosing stmt
747 std::unique_ptr<Statement>* fEnclosingStmt; // the Statement containing the candidate
748 std::unique_ptr<Expression>* fCandidateExpr; // the candidate FunctionCall to be inlined
749 FunctionDefinition* fEnclosingFunction; // the Function containing the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400750};
John Stiles93442622020-09-11 12:11:27 -0400751
John Stiles2d7973a2020-10-02 15:01:03 -0400752struct InlineCandidateList {
753 std::vector<InlineCandidate> fCandidates;
754};
755
756class InlineCandidateAnalyzer {
John Stiles70957c82020-10-02 16:42:10 -0400757public:
758 // A list of all the inlining candidates we found during analysis.
759 InlineCandidateList* fCandidateList;
John Stiles2d7973a2020-10-02 15:01:03 -0400760
John Stiles70957c82020-10-02 16:42:10 -0400761 // A stack of the symbol tables; since most nodes don't have one, expected to be shallower than
762 // the enclosing-statement stack.
John Stiles78047582020-12-16 16:17:41 -0500763 std::vector<std::shared_ptr<SymbolTable>> fSymbolTableStack;
John Stiles70957c82020-10-02 16:42:10 -0400764 // A stack of "enclosing" statements--these would be suitable for the inliner to use for adding
765 // new instructions. Not all statements are suitable (e.g. a for-loop's initializer). The
766 // inliner might replace a statement with a block containing the statement.
767 std::vector<std::unique_ptr<Statement>*> fEnclosingStmtStack;
768 // The function that we're currently processing (i.e. inlining into).
769 FunctionDefinition* fEnclosingFunction = nullptr;
John Stiles93442622020-09-11 12:11:27 -0400770
Brian Osman0006ad02020-11-18 15:38:39 -0500771 void visit(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -0500772 std::shared_ptr<SymbolTable> symbols,
Brian Osman0006ad02020-11-18 15:38:39 -0500773 InlineCandidateList* candidateList) {
John Stiles70957c82020-10-02 16:42:10 -0400774 fCandidateList = candidateList;
Brian Osman0006ad02020-11-18 15:38:39 -0500775 fSymbolTableStack.push_back(symbols);
John Stiles93442622020-09-11 12:11:27 -0400776
Brian Osman0006ad02020-11-18 15:38:39 -0500777 for (const std::unique_ptr<ProgramElement>& pe : elements) {
Brian Osman1179fcf2020-10-08 16:04:40 -0400778 this->visitProgramElement(pe.get());
John Stiles93442622020-09-11 12:11:27 -0400779 }
780
John Stiles70957c82020-10-02 16:42:10 -0400781 fSymbolTableStack.pop_back();
782 fCandidateList = nullptr;
783 }
784
785 void visitProgramElement(ProgramElement* pe) {
786 switch (pe->kind()) {
787 case ProgramElement::Kind::kFunction: {
788 FunctionDefinition& funcDef = pe->as<FunctionDefinition>();
Brian Osman0006ad02020-11-18 15:38:39 -0500789 fEnclosingFunction = &funcDef;
790 this->visitStatement(&funcDef.body());
John Stiles70957c82020-10-02 16:42:10 -0400791 break;
John Stiles93442622020-09-11 12:11:27 -0400792 }
John Stiles70957c82020-10-02 16:42:10 -0400793 default:
794 // The inliner can't operate outside of a function's scope.
795 break;
796 }
797 }
798
799 void visitStatement(std::unique_ptr<Statement>* stmt,
800 bool isViableAsEnclosingStatement = true) {
801 if (!*stmt) {
802 return;
John Stiles93442622020-09-11 12:11:27 -0400803 }
804
John Stiles70957c82020-10-02 16:42:10 -0400805 size_t oldEnclosingStmtStackSize = fEnclosingStmtStack.size();
806 size_t oldSymbolStackSize = fSymbolTableStack.size();
John Stiles93442622020-09-11 12:11:27 -0400807
John Stiles70957c82020-10-02 16:42:10 -0400808 if (isViableAsEnclosingStatement) {
809 fEnclosingStmtStack.push_back(stmt);
John Stiles93442622020-09-11 12:11:27 -0400810 }
811
John Stiles70957c82020-10-02 16:42:10 -0400812 switch ((*stmt)->kind()) {
813 case Statement::Kind::kBreak:
814 case Statement::Kind::kContinue:
815 case Statement::Kind::kDiscard:
816 case Statement::Kind::kInlineMarker:
817 case Statement::Kind::kNop:
818 break;
819
820 case Statement::Kind::kBlock: {
821 Block& block = (*stmt)->as<Block>();
822 if (block.symbolTable()) {
John Stiles78047582020-12-16 16:17:41 -0500823 fSymbolTableStack.push_back(block.symbolTable());
John Stiles70957c82020-10-02 16:42:10 -0400824 }
825
826 for (std::unique_ptr<Statement>& stmt : block.children()) {
827 this->visitStatement(&stmt);
828 }
829 break;
John Stiles93442622020-09-11 12:11:27 -0400830 }
John Stiles70957c82020-10-02 16:42:10 -0400831 case Statement::Kind::kDo: {
832 DoStatement& doStmt = (*stmt)->as<DoStatement>();
833 // The loop body is a candidate for inlining.
834 this->visitStatement(&doStmt.statement());
835 // The inliner isn't smart enough to inline the test-expression for a do-while
836 // loop at this time. There are two limitations:
837 // - We would need to insert the inlined-body block at the very end of the do-
838 // statement's inner fStatement. We don't support that today, but it's doable.
839 // - We cannot inline the test expression if the loop uses `continue` anywhere; that
840 // would skip over the inlined block that evaluates the test expression. There
841 // isn't a good fix for this--any workaround would be more complex than the cost
842 // of a function call. However, loops that don't use `continue` would still be
843 // viable candidates for inlining.
844 break;
John Stiles93442622020-09-11 12:11:27 -0400845 }
John Stiles70957c82020-10-02 16:42:10 -0400846 case Statement::Kind::kExpression: {
847 ExpressionStatement& expr = (*stmt)->as<ExpressionStatement>();
848 this->visitExpression(&expr.expression());
849 break;
850 }
851 case Statement::Kind::kFor: {
852 ForStatement& forStmt = (*stmt)->as<ForStatement>();
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400853 if (forStmt.symbols()) {
John Stiles78047582020-12-16 16:17:41 -0500854 fSymbolTableStack.push_back(forStmt.symbols());
John Stiles70957c82020-10-02 16:42:10 -0400855 }
856
857 // The initializer and loop body are candidates for inlining.
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400858 this->visitStatement(&forStmt.initializer(),
John Stiles70957c82020-10-02 16:42:10 -0400859 /*isViableAsEnclosingStatement=*/false);
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400860 this->visitStatement(&forStmt.statement());
John Stiles70957c82020-10-02 16:42:10 -0400861
862 // The inliner isn't smart enough to inline the test- or increment-expressions
863 // of a for loop loop at this time. There are a handful of limitations:
864 // - We would need to insert the test-expression block at the very beginning of the
865 // for-loop's inner fStatement, and the increment-expression block at the very
866 // end. We don't support that today, but it's doable.
867 // - The for-loop's built-in test-expression would need to be dropped entirely,
868 // and the loop would be halted via a break statement at the end of the inlined
869 // test-expression. This is again something we don't support today, but it could
870 // be implemented.
871 // - We cannot inline the increment-expression if the loop uses `continue` anywhere;
872 // that would skip over the inlined block that evaluates the increment expression.
873 // There isn't a good fix for this--any workaround would be more complex than the
874 // cost of a function call. However, loops that don't use `continue` would still
875 // be viable candidates for increment-expression inlining.
876 break;
877 }
878 case Statement::Kind::kIf: {
879 IfStatement& ifStmt = (*stmt)->as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400880 this->visitExpression(&ifStmt.test());
881 this->visitStatement(&ifStmt.ifTrue());
882 this->visitStatement(&ifStmt.ifFalse());
John Stiles70957c82020-10-02 16:42:10 -0400883 break;
884 }
885 case Statement::Kind::kReturn: {
886 ReturnStatement& returnStmt = (*stmt)->as<ReturnStatement>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400887 this->visitExpression(&returnStmt.expression());
John Stiles70957c82020-10-02 16:42:10 -0400888 break;
889 }
890 case Statement::Kind::kSwitch: {
891 SwitchStatement& switchStmt = (*stmt)->as<SwitchStatement>();
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400892 if (switchStmt.symbols()) {
John Stiles78047582020-12-16 16:17:41 -0500893 fSymbolTableStack.push_back(switchStmt.symbols());
John Stiles70957c82020-10-02 16:42:10 -0400894 }
895
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400896 this->visitExpression(&switchStmt.value());
John Stilesb23a64b2021-03-11 08:27:59 -0500897 for (const std::unique_ptr<Statement>& switchCase : switchStmt.cases()) {
John Stiles70957c82020-10-02 16:42:10 -0400898 // The switch-case's fValue cannot be a FunctionCall; skip it.
John Stilesb23a64b2021-03-11 08:27:59 -0500899 this->visitStatement(&switchCase->as<SwitchCase>().statement());
John Stiles70957c82020-10-02 16:42:10 -0400900 }
901 break;
902 }
903 case Statement::Kind::kVarDeclaration: {
904 VarDeclaration& varDeclStmt = (*stmt)->as<VarDeclaration>();
905 // Don't need to scan the declaration's sizes; those are always IntLiterals.
Ethan Nicholasc51f33e2020-10-13 13:49:44 -0400906 this->visitExpression(&varDeclStmt.value());
John Stiles70957c82020-10-02 16:42:10 -0400907 break;
908 }
John Stiles70957c82020-10-02 16:42:10 -0400909 default:
910 SkUNREACHABLE;
John Stiles93442622020-09-11 12:11:27 -0400911 }
912
John Stiles70957c82020-10-02 16:42:10 -0400913 // Pop our symbol and enclosing-statement stacks.
914 fSymbolTableStack.resize(oldSymbolStackSize);
915 fEnclosingStmtStack.resize(oldEnclosingStmtStackSize);
916 }
917
918 void visitExpression(std::unique_ptr<Expression>* expr) {
919 if (!*expr) {
920 return;
John Stiles93442622020-09-11 12:11:27 -0400921 }
John Stiles70957c82020-10-02 16:42:10 -0400922
923 switch ((*expr)->kind()) {
924 case Expression::Kind::kBoolLiteral:
925 case Expression::Kind::kDefined:
Brian Osmanbe0b3b72021-01-06 14:27:35 -0500926 case Expression::Kind::kExternalFunctionReference:
John Stiles70957c82020-10-02 16:42:10 -0400927 case Expression::Kind::kFieldAccess:
928 case Expression::Kind::kFloatLiteral:
929 case Expression::Kind::kFunctionReference:
930 case Expression::Kind::kIntLiteral:
John Stiles70957c82020-10-02 16:42:10 -0400931 case Expression::Kind::kSetting:
932 case Expression::Kind::kTypeReference:
933 case Expression::Kind::kVariableReference:
934 // Nothing to scan here.
935 break;
936
937 case Expression::Kind::kBinary: {
938 BinaryExpression& binaryExpr = (*expr)->as<BinaryExpression>();
John Stiles2d4f9592020-10-30 10:29:12 -0400939 this->visitExpression(&binaryExpr.left());
John Stiles70957c82020-10-02 16:42:10 -0400940
941 // Logical-and and logical-or binary expressions do not inline the right side,
942 // because that would invalidate short-circuiting. That is, when evaluating
943 // expressions like these:
944 // (false && x()) // always false
945 // (true || y()) // always true
946 // It is illegal for side-effects from x() or y() to occur. The simplest way to
947 // enforce that rule is to avoid inlining the right side entirely. However, it is
948 // safe for other types of binary expression to inline both sides.
John Stiles45990502021-02-16 10:55:27 -0500949 Operator op = binaryExpr.getOperator();
950 bool shortCircuitable = (op.kind() == Token::Kind::TK_LOGICALAND ||
951 op.kind() == Token::Kind::TK_LOGICALOR);
John Stiles70957c82020-10-02 16:42:10 -0400952 if (!shortCircuitable) {
John Stiles2d4f9592020-10-30 10:29:12 -0400953 this->visitExpression(&binaryExpr.right());
John Stiles70957c82020-10-02 16:42:10 -0400954 }
955 break;
956 }
John Stiles7384b372021-04-01 13:48:15 -0400957 case Expression::Kind::kConstructorArray:
John Stiles8cad6372021-04-07 12:31:13 -0400958 case Expression::Kind::kConstructorCompound:
959 case Expression::Kind::kConstructorCompoundCast:
John Stiles2938eea2021-04-01 18:58:25 -0400960 case Expression::Kind::kConstructorDiagonalMatrix:
John Stiles5abb9e12021-04-06 13:47:19 -0400961 case Expression::Kind::kConstructorMatrixResize:
John Stilesfd7252f2021-04-04 22:24:40 -0400962 case Expression::Kind::kConstructorScalarCast:
John Stilesd47330f2021-04-08 23:25:52 -0400963 case Expression::Kind::kConstructorSplat:
964 case Expression::Kind::kConstructorStruct: {
John Stiles7384b372021-04-01 13:48:15 -0400965 AnyConstructor& constructorExpr = (*expr)->asAnyConstructor();
966 for (std::unique_ptr<Expression>& arg : constructorExpr.argumentSpan()) {
John Stiles70957c82020-10-02 16:42:10 -0400967 this->visitExpression(&arg);
968 }
969 break;
970 }
971 case Expression::Kind::kExternalFunctionCall: {
972 ExternalFunctionCall& funcCallExpr = (*expr)->as<ExternalFunctionCall>();
973 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
974 this->visitExpression(&arg);
975 }
976 break;
977 }
978 case Expression::Kind::kFunctionCall: {
979 FunctionCall& funcCallExpr = (*expr)->as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400980 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
John Stiles70957c82020-10-02 16:42:10 -0400981 this->visitExpression(&arg);
982 }
983 this->addInlineCandidate(expr);
984 break;
985 }
John Stiles708faba2021-03-19 09:43:23 -0400986 case Expression::Kind::kIndex: {
John Stiles70957c82020-10-02 16:42:10 -0400987 IndexExpression& indexExpr = (*expr)->as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400988 this->visitExpression(&indexExpr.base());
989 this->visitExpression(&indexExpr.index());
John Stiles70957c82020-10-02 16:42:10 -0400990 break;
991 }
992 case Expression::Kind::kPostfix: {
993 PostfixExpression& postfixExpr = (*expr)->as<PostfixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400994 this->visitExpression(&postfixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -0400995 break;
996 }
997 case Expression::Kind::kPrefix: {
998 PrefixExpression& prefixExpr = (*expr)->as<PrefixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400999 this->visitExpression(&prefixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001000 break;
1001 }
1002 case Expression::Kind::kSwizzle: {
1003 Swizzle& swizzleExpr = (*expr)->as<Swizzle>();
Ethan Nicholas6b4d5812020-10-12 16:11:51 -04001004 this->visitExpression(&swizzleExpr.base());
John Stiles70957c82020-10-02 16:42:10 -04001005 break;
1006 }
1007 case Expression::Kind::kTernary: {
1008 TernaryExpression& ternaryExpr = (*expr)->as<TernaryExpression>();
1009 // The test expression is a candidate for inlining.
Ethan Nicholasdd218162020-10-08 05:48:01 -04001010 this->visitExpression(&ternaryExpr.test());
John Stiles70957c82020-10-02 16:42:10 -04001011 // The true- and false-expressions cannot be inlined, because we are only allowed to
1012 // evaluate one side.
1013 break;
1014 }
1015 default:
1016 SkUNREACHABLE;
1017 }
1018 }
1019
1020 void addInlineCandidate(std::unique_ptr<Expression>* candidate) {
1021 fCandidateList->fCandidates.push_back(
1022 InlineCandidate{fSymbolTableStack.back(),
1023 find_parent_statement(fEnclosingStmtStack),
1024 fEnclosingStmtStack.back(),
1025 candidate,
John Stiles9b9415e2020-11-23 14:48:06 -05001026 fEnclosingFunction});
John Stiles70957c82020-10-02 16:42:10 -04001027 }
John Stiles2d7973a2020-10-02 15:01:03 -04001028};
John Stiles93442622020-09-11 12:11:27 -04001029
John Stiles9b9415e2020-11-23 14:48:06 -05001030static const FunctionDeclaration& candidate_func(const InlineCandidate& candidate) {
1031 return (*candidate.fCandidateExpr)->as<FunctionCall>().function();
1032}
John Stiles915a38c2020-09-14 09:38:13 -04001033
John Stiles9b9415e2020-11-23 14:48:06 -05001034bool Inliner::candidateCanBeInlined(const InlineCandidate& candidate, InlinabilityCache* cache) {
1035 const FunctionDeclaration& funcDecl = candidate_func(candidate);
John Stiles1c03d332020-10-13 10:30:23 -04001036 auto [iter, wasInserted] = cache->insert({&funcDecl, false});
John Stiles2d7973a2020-10-02 15:01:03 -04001037 if (wasInserted) {
1038 // Recursion is forbidden here to avoid an infinite death spiral of inlining.
John Stiles132cfdd2021-03-15 22:08:38 +00001039 iter->second = this->isSafeToInline(funcDecl.definition()) &&
1040 !contains_recursive_call(funcDecl);
John Stiles93442622020-09-11 12:11:27 -04001041 }
1042
John Stiles2d7973a2020-10-02 15:01:03 -04001043 return iter->second;
1044}
1045
John Stiles9b9415e2020-11-23 14:48:06 -05001046int Inliner::getFunctionSize(const FunctionDeclaration& funcDecl, FunctionSizeCache* cache) {
1047 auto [iter, wasInserted] = cache->insert({&funcDecl, 0});
John Stiles2d7973a2020-10-02 15:01:03 -04001048 if (wasInserted) {
John Stiles9b9415e2020-11-23 14:48:06 -05001049 iter->second = Analysis::NodeCountUpToLimit(*funcDecl.definition(),
John Stilesd1204642021-02-17 16:30:02 -05001050 this->settings().fInlineThreshold);
John Stiles2d7973a2020-10-02 15:01:03 -04001051 }
John Stiles2d7973a2020-10-02 15:01:03 -04001052 return iter->second;
1053}
1054
Brian Osman0006ad02020-11-18 15:38:39 -05001055void Inliner::buildCandidateList(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -05001056 std::shared_ptr<SymbolTable> symbols, ProgramUsage* usage,
Brian Osman0006ad02020-11-18 15:38:39 -05001057 InlineCandidateList* candidateList) {
John Stiles2d7973a2020-10-02 15:01:03 -04001058 // This is structured much like a ProgramVisitor, but does not actually use ProgramVisitor.
1059 // The analyzer needs to keep track of the `unique_ptr<T>*` of statements and expressions so
1060 // that they can later be replaced, and ProgramVisitor does not provide this; it only provides a
1061 // `const T&`.
1062 InlineCandidateAnalyzer analyzer;
Brian Osman0006ad02020-11-18 15:38:39 -05001063 analyzer.visit(elements, symbols, candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001064
John Stiles0ad233f2020-11-25 11:02:05 -05001065 // Early out if there are no inlining candidates.
John Stiles2d7973a2020-10-02 15:01:03 -04001066 std::vector<InlineCandidate>& candidates = candidateList->fCandidates;
John Stiles0ad233f2020-11-25 11:02:05 -05001067 if (candidates.empty()) {
1068 return;
1069 }
1070
1071 // Remove candidates that are not safe to inline.
John Stiles2d7973a2020-10-02 15:01:03 -04001072 InlinabilityCache cache;
1073 candidates.erase(std::remove_if(candidates.begin(),
1074 candidates.end(),
1075 [&](const InlineCandidate& candidate) {
1076 return !this->candidateCanBeInlined(candidate, &cache);
1077 }),
1078 candidates.end());
1079
John Stiles0ad233f2020-11-25 11:02:05 -05001080 // If the inline threshold is unlimited, or if we have no candidates left, our candidate list is
1081 // complete.
John Stilesd1204642021-02-17 16:30:02 -05001082 if (this->settings().fInlineThreshold == INT_MAX || candidates.empty()) {
John Stiles0ad233f2020-11-25 11:02:05 -05001083 return;
John Stiles2d7973a2020-10-02 15:01:03 -04001084 }
John Stiles0ad233f2020-11-25 11:02:05 -05001085
1086 // Remove candidates on a per-function basis if the effect of inlining would be to make more
1087 // than `inlineThreshold` nodes. (i.e. if Func() would be inlined six times and its size is
1088 // 10 nodes, it should be inlined if the inlineThreshold is 60 or higher.)
1089 FunctionSizeCache functionSizeCache;
1090 FunctionSizeCache candidateTotalCost;
1091 for (InlineCandidate& candidate : candidates) {
1092 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1093 candidateTotalCost[&fnDecl] += this->getFunctionSize(fnDecl, &functionSizeCache);
1094 }
1095
John Stilesd1204642021-02-17 16:30:02 -05001096 candidates.erase(std::remove_if(candidates.begin(), candidates.end(),
1097 [&](const InlineCandidate& candidate) {
1098 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1099 if (fnDecl.modifiers().fFlags & Modifiers::kInline_Flag) {
1100 // Functions marked `inline` ignore size limitations.
1101 return false;
1102 }
1103 if (usage->get(fnDecl) == 1) {
1104 // If a function is only used once, it's cost-free to inline.
1105 return false;
1106 }
1107 if (candidateTotalCost[&fnDecl] <= this->settings().fInlineThreshold) {
1108 // We won't exceed the inline threshold by inlining this.
1109 return false;
1110 }
1111 // Inlining this function will add too many IRNodes.
1112 return true;
1113 }),
1114 candidates.end());
John Stiles2d7973a2020-10-02 15:01:03 -04001115}
1116
Brian Osman0006ad02020-11-18 15:38:39 -05001117bool Inliner::analyze(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -05001118 std::shared_ptr<SymbolTable> symbols,
Brian Osman0006ad02020-11-18 15:38:39 -05001119 ProgramUsage* usage) {
John Stilesd34d56e2020-10-12 12:04:47 -04001120 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
John Stilesd1204642021-02-17 16:30:02 -05001121 if (this->settings().fInlineThreshold <= 0) {
John Stilesd34d56e2020-10-12 12:04:47 -04001122 return false;
1123 }
1124
John Stiles031a7672020-11-13 16:13:18 -05001125 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
1126 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1127 return false;
1128 }
1129
John Stiles2d7973a2020-10-02 15:01:03 -04001130 InlineCandidateList candidateList;
John Stiles9b9415e2020-11-23 14:48:06 -05001131 this->buildCandidateList(elements, symbols, usage, &candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001132
John Stiles915a38c2020-09-14 09:38:13 -04001133 // Inline the candidates where we've determined that it's safe to do so.
John Stiles708faba2021-03-19 09:43:23 -04001134 using StatementRemappingTable = std::unordered_map<std::unique_ptr<Statement>*,
1135 std::unique_ptr<Statement>*>;
1136 StatementRemappingTable statementRemappingTable;
1137
John Stiles915a38c2020-09-14 09:38:13 -04001138 bool madeChanges = false;
John Stiles2d7973a2020-10-02 15:01:03 -04001139 for (const InlineCandidate& candidate : candidateList.fCandidates) {
John Stiles915a38c2020-09-14 09:38:13 -04001140 FunctionCall& funcCall = (*candidate.fCandidateExpr)->as<FunctionCall>();
John Stiles915a38c2020-09-14 09:38:13 -04001141
John Stiles915a38c2020-09-14 09:38:13 -04001142 // Convert the function call to its inlined equivalent.
John Stiles30fce9c2021-03-18 09:24:06 -04001143 InlinedCall inlinedCall = this->inlineCall(&funcCall, candidate.fSymbols, *usage,
Ethan Nicholas0a5d0962020-10-14 13:33:18 -04001144 &candidate.fEnclosingFunction->declaration());
John Stiles915a38c2020-09-14 09:38:13 -04001145
John Stiles0c2d14a2021-03-01 10:08:08 -05001146 // Stop if an error was detected during the inlining process.
1147 if (!inlinedCall.fInlinedBody && !inlinedCall.fReplacementExpr) {
1148 break;
John Stiles915a38c2020-09-14 09:38:13 -04001149 }
1150
John Stiles0c2d14a2021-03-01 10:08:08 -05001151 // Ensure that the inlined body has a scope if it needs one.
1152 this->ensureScopedBlocks(inlinedCall.fInlinedBody.get(), candidate.fParentStmt->get());
1153
1154 // Add references within the inlined body
1155 usage->add(inlinedCall.fInlinedBody.get());
1156
John Stiles708faba2021-03-19 09:43:23 -04001157 // Look up the enclosing statement; remap it if necessary.
1158 std::unique_ptr<Statement>* enclosingStmt = candidate.fEnclosingStmt;
1159 for (;;) {
1160 auto iter = statementRemappingTable.find(enclosingStmt);
1161 if (iter == statementRemappingTable.end()) {
1162 break;
1163 }
1164 enclosingStmt = iter->second;
1165 }
1166
John Stiles0c2d14a2021-03-01 10:08:08 -05001167 // Move the enclosing statement to the end of the unscoped Block containing the inlined
1168 // function, then replace the enclosing statement with that Block.
1169 // Before:
1170 // fInlinedBody = Block{ stmt1, stmt2, stmt3 }
1171 // fEnclosingStmt = stmt4
1172 // After:
1173 // fInlinedBody = null
1174 // fEnclosingStmt = Block{ stmt1, stmt2, stmt3, stmt4 }
John Stiles708faba2021-03-19 09:43:23 -04001175 inlinedCall.fInlinedBody->children().push_back(std::move(*enclosingStmt));
1176 *enclosingStmt = std::move(inlinedCall.fInlinedBody);
John Stiles0c2d14a2021-03-01 10:08:08 -05001177
John Stiles915a38c2020-09-14 09:38:13 -04001178 // Replace the candidate function call with our replacement expression.
Brian Osman010ce6a2020-10-19 16:34:10 -04001179 usage->replace(candidate.fCandidateExpr->get(), inlinedCall.fReplacementExpr.get());
John Stiles915a38c2020-09-14 09:38:13 -04001180 *candidate.fCandidateExpr = std::move(inlinedCall.fReplacementExpr);
1181 madeChanges = true;
1182
John Stiles708faba2021-03-19 09:43:23 -04001183 // If anything else pointed at our enclosing statement, it's now pointing at a Block
1184 // containing many other statements as well. Maintain a fix-up table to account for this.
1185 statementRemappingTable[enclosingStmt] = &(*enclosingStmt)->as<Block>().children().back();
1186
John Stiles031a7672020-11-13 16:13:18 -05001187 // Stop inlining if we've reached our hard cap on new statements.
1188 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1189 break;
1190 }
1191
John Stiles915a38c2020-09-14 09:38:13 -04001192 // Note that nothing was destroyed except for the FunctionCall. All other nodes should
1193 // remain valid.
1194 }
1195
1196 return madeChanges;
John Stiles93442622020-09-11 12:11:27 -04001197}
1198
John Stiles44e96be2020-08-31 13:16:04 -04001199} // namespace SkSL