blob: af037681536403fa62b50827c956e3b315024c21 [file] [log] [blame]
John Stiles44e96be2020-08-31 13:16:04 -04001/*
2 * Copyright 2020 Google LLC
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8#include "src/sksl/SkSLInliner.h"
9
John Stiles2d7973a2020-10-02 15:01:03 -040010#include <limits.h>
John Stiles44e96be2020-08-31 13:16:04 -040011#include <memory>
12#include <unordered_set>
13
14#include "src/sksl/SkSLAnalysis.h"
15#include "src/sksl/ir/SkSLBinaryExpression.h"
16#include "src/sksl/ir/SkSLBoolLiteral.h"
17#include "src/sksl/ir/SkSLBreakStatement.h"
18#include "src/sksl/ir/SkSLConstructor.h"
19#include "src/sksl/ir/SkSLContinueStatement.h"
20#include "src/sksl/ir/SkSLDiscardStatement.h"
21#include "src/sksl/ir/SkSLDoStatement.h"
22#include "src/sksl/ir/SkSLEnum.h"
23#include "src/sksl/ir/SkSLExpressionStatement.h"
24#include "src/sksl/ir/SkSLExternalFunctionCall.h"
25#include "src/sksl/ir/SkSLExternalValueReference.h"
26#include "src/sksl/ir/SkSLField.h"
27#include "src/sksl/ir/SkSLFieldAccess.h"
28#include "src/sksl/ir/SkSLFloatLiteral.h"
29#include "src/sksl/ir/SkSLForStatement.h"
30#include "src/sksl/ir/SkSLFunctionCall.h"
31#include "src/sksl/ir/SkSLFunctionDeclaration.h"
32#include "src/sksl/ir/SkSLFunctionDefinition.h"
33#include "src/sksl/ir/SkSLFunctionReference.h"
34#include "src/sksl/ir/SkSLIfStatement.h"
35#include "src/sksl/ir/SkSLIndexExpression.h"
John Stiles98c1f822020-09-09 14:18:53 -040036#include "src/sksl/ir/SkSLInlineMarker.h"
John Stiles44e96be2020-08-31 13:16:04 -040037#include "src/sksl/ir/SkSLIntLiteral.h"
38#include "src/sksl/ir/SkSLInterfaceBlock.h"
39#include "src/sksl/ir/SkSLLayout.h"
40#include "src/sksl/ir/SkSLNop.h"
41#include "src/sksl/ir/SkSLNullLiteral.h"
42#include "src/sksl/ir/SkSLPostfixExpression.h"
43#include "src/sksl/ir/SkSLPrefixExpression.h"
44#include "src/sksl/ir/SkSLReturnStatement.h"
45#include "src/sksl/ir/SkSLSetting.h"
46#include "src/sksl/ir/SkSLSwitchCase.h"
47#include "src/sksl/ir/SkSLSwitchStatement.h"
48#include "src/sksl/ir/SkSLSwizzle.h"
49#include "src/sksl/ir/SkSLTernaryExpression.h"
50#include "src/sksl/ir/SkSLUnresolvedFunction.h"
51#include "src/sksl/ir/SkSLVarDeclarations.h"
John Stiles44e96be2020-08-31 13:16:04 -040052#include "src/sksl/ir/SkSLVariable.h"
53#include "src/sksl/ir/SkSLVariableReference.h"
John Stiles44e96be2020-08-31 13:16:04 -040054
55namespace SkSL {
56namespace {
57
John Stiles031a7672020-11-13 16:13:18 -050058static constexpr int kInlinedStatementLimit = 2500;
59
John Stiles44e96be2020-08-31 13:16:04 -040060static int count_returns_at_end_of_control_flow(const FunctionDefinition& funcDef) {
61 class CountReturnsAtEndOfControlFlow : public ProgramVisitor {
62 public:
63 CountReturnsAtEndOfControlFlow(const FunctionDefinition& funcDef) {
64 this->visitProgramElement(funcDef);
65 }
66
67 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -040068 switch (stmt.kind()) {
69 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -040070 // Check only the last statement of a block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -040071 const auto& block = stmt.as<Block>();
72 return block.children().size() &&
73 this->visitStatement(*block.children().back());
John Stiles44e96be2020-08-31 13:16:04 -040074 }
Ethan Nicholase6592142020-09-08 10:22:09 -040075 case Statement::Kind::kSwitch:
Ethan Nicholase6592142020-09-08 10:22:09 -040076 case Statement::Kind::kDo:
77 case Statement::Kind::kFor:
John Stiles44e96be2020-08-31 13:16:04 -040078 // Don't introspect switches or loop structures at all.
79 return false;
80
Ethan Nicholase6592142020-09-08 10:22:09 -040081 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -040082 ++fNumReturns;
83 [[fallthrough]];
84
85 default:
John Stiles93442622020-09-11 12:11:27 -040086 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -040087 }
88 }
89
90 int fNumReturns = 0;
91 using INHERITED = ProgramVisitor;
92 };
93
94 return CountReturnsAtEndOfControlFlow{funcDef}.fNumReturns;
95}
96
John Stiles74ebd7e2020-12-17 14:41:50 -050097static int count_returns_in_continuable_constructs(const FunctionDefinition& funcDef) {
98 class CountReturnsInContinuableConstructs : public ProgramVisitor {
John Stiles44e96be2020-08-31 13:16:04 -040099 public:
John Stiles74ebd7e2020-12-17 14:41:50 -0500100 CountReturnsInContinuableConstructs(const FunctionDefinition& funcDef) {
John Stiles44e96be2020-08-31 13:16:04 -0400101 this->visitProgramElement(funcDef);
102 }
103
104 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -0400105 switch (stmt.kind()) {
Ethan Nicholase6592142020-09-08 10:22:09 -0400106 case Statement::Kind::kDo:
107 case Statement::Kind::kFor: {
John Stiles74ebd7e2020-12-17 14:41:50 -0500108 ++fInsideContinuableConstruct;
John Stiles93442622020-09-11 12:11:27 -0400109 bool result = INHERITED::visitStatement(stmt);
John Stiles74ebd7e2020-12-17 14:41:50 -0500110 --fInsideContinuableConstruct;
John Stiles44e96be2020-08-31 13:16:04 -0400111 return result;
112 }
113
Ethan Nicholase6592142020-09-08 10:22:09 -0400114 case Statement::Kind::kReturn:
John Stiles74ebd7e2020-12-17 14:41:50 -0500115 fNumReturns += (fInsideContinuableConstruct > 0) ? 1 : 0;
John Stiles44e96be2020-08-31 13:16:04 -0400116 [[fallthrough]];
117
118 default:
John Stiles93442622020-09-11 12:11:27 -0400119 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400120 }
121 }
122
123 int fNumReturns = 0;
John Stiles74ebd7e2020-12-17 14:41:50 -0500124 int fInsideContinuableConstruct = 0;
John Stiles44e96be2020-08-31 13:16:04 -0400125 using INHERITED = ProgramVisitor;
126 };
127
John Stiles74ebd7e2020-12-17 14:41:50 -0500128 return CountReturnsInContinuableConstructs{funcDef}.fNumReturns;
John Stiles44e96be2020-08-31 13:16:04 -0400129}
130
John Stiles991b09d2020-09-10 13:33:40 -0400131static bool contains_recursive_call(const FunctionDeclaration& funcDecl) {
132 class ContainsRecursiveCall : public ProgramVisitor {
133 public:
134 bool visit(const FunctionDeclaration& funcDecl) {
135 fFuncDecl = &funcDecl;
Ethan Nicholased84b732020-10-08 11:45:44 -0400136 return funcDecl.definition() ? this->visitProgramElement(*funcDecl.definition())
137 : false;
John Stiles991b09d2020-09-10 13:33:40 -0400138 }
139
140 bool visitExpression(const Expression& expr) override {
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400141 if (expr.is<FunctionCall>() && expr.as<FunctionCall>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400142 return true;
143 }
144 return INHERITED::visitExpression(expr);
145 }
146
147 bool visitStatement(const Statement& stmt) override {
Ethan Nicholasceb62142020-10-09 16:51:18 -0400148 if (stmt.is<InlineMarker>() &&
149 stmt.as<InlineMarker>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400150 return true;
151 }
152 return INHERITED::visitStatement(stmt);
153 }
154
155 const FunctionDeclaration* fFuncDecl;
156 using INHERITED = ProgramVisitor;
157 };
158
159 return ContainsRecursiveCall{}.visit(funcDecl);
160}
161
John Stiles44e96be2020-08-31 13:16:04 -0400162static const Type* copy_if_needed(const Type* src, SymbolTable& symbolTable) {
John Stilesc0c51062020-12-03 17:16:29 -0500163 if (src->isArray()) {
John Stilesc5ff4862020-12-22 13:47:05 -0500164 return symbolTable.takeOwnershipOfSymbol(
165 Type::MakeArrayType(src->name(), src->componentType(), src->columns()));
John Stiles44e96be2020-08-31 13:16:04 -0400166 }
167 return src;
168}
169
John Stiles6d696082020-10-01 10:18:54 -0400170static std::unique_ptr<Statement>* find_parent_statement(
171 const std::vector<std::unique_ptr<Statement>*>& stmtStack) {
John Stiles915a38c2020-09-14 09:38:13 -0400172 SkASSERT(!stmtStack.empty());
173
174 // Walk the statement stack from back to front, ignoring the last element (which is the
175 // enclosing statement).
176 auto iter = stmtStack.rbegin();
177 ++iter;
178
179 // Anything counts as a parent statement other than a scopeless Block.
180 for (; iter != stmtStack.rend(); ++iter) {
John Stiles6d696082020-10-01 10:18:54 -0400181 std::unique_ptr<Statement>* stmt = *iter;
182 if (!(*stmt)->is<Block>() || (*stmt)->as<Block>().isScope()) {
John Stiles915a38c2020-09-14 09:38:13 -0400183 return stmt;
184 }
185 }
186
187 // There wasn't any parent statement to be found.
188 return nullptr;
189}
190
John Stilese41b4ee2020-09-28 12:28:16 -0400191std::unique_ptr<Expression> clone_with_ref_kind(const Expression& expr,
192 VariableReference::RefKind refKind) {
193 std::unique_ptr<Expression> clone = expr.clone();
John Stiles70b82422020-09-30 10:55:12 -0400194 class SetRefKindInExpression : public ProgramWriter {
John Stilese41b4ee2020-09-28 12:28:16 -0400195 public:
196 SetRefKindInExpression(VariableReference::RefKind refKind) : fRefKind(refKind) {}
John Stiles70b82422020-09-30 10:55:12 -0400197 bool visitExpression(Expression& expr) override {
John Stilese41b4ee2020-09-28 12:28:16 -0400198 if (expr.is<VariableReference>()) {
John Stiles70b82422020-09-30 10:55:12 -0400199 expr.as<VariableReference>().setRefKind(fRefKind);
John Stilese41b4ee2020-09-28 12:28:16 -0400200 }
201 return INHERITED::visitExpression(expr);
202 }
203
204 private:
205 VariableReference::RefKind fRefKind;
206
John Stiles70b82422020-09-30 10:55:12 -0400207 using INHERITED = ProgramWriter;
John Stilese41b4ee2020-09-28 12:28:16 -0400208 };
209
210 SetRefKindInExpression{refKind}.visitExpression(*clone);
211 return clone;
212}
213
John Stiles77702f12020-12-17 14:38:56 -0500214class CountReturnsWithLimit : public ProgramVisitor {
215public:
216 CountReturnsWithLimit(const FunctionDefinition& funcDef, int limit) : fLimit(limit) {
217 this->visitProgramElement(funcDef);
218 }
219
220 bool visitStatement(const Statement& stmt) override {
221 switch (stmt.kind()) {
222 case Statement::Kind::kReturn: {
223 ++fNumReturns;
224 fDeepestReturn = std::max(fDeepestReturn, fScopedBlockDepth);
225 return (fNumReturns >= fLimit) || INHERITED::visitStatement(stmt);
226 }
John Stilesc5ff4862020-12-22 13:47:05 -0500227 case Statement::Kind::kVarDeclaration: {
228 if (fScopedBlockDepth > 1) {
229 fVariablesInBlocks = true;
230 }
231 return INHERITED::visitStatement(stmt);
232 }
John Stiles77702f12020-12-17 14:38:56 -0500233 case Statement::Kind::kBlock: {
234 int depthIncrement = stmt.as<Block>().isScope() ? 1 : 0;
235 fScopedBlockDepth += depthIncrement;
236 bool result = INHERITED::visitStatement(stmt);
237 fScopedBlockDepth -= depthIncrement;
John Stilesc5ff4862020-12-22 13:47:05 -0500238 if (fNumReturns == 0 && fScopedBlockDepth <= 1) {
239 // If closing this block puts us back at the top level, and we haven't
240 // encountered any return statements yet, any vardecls we may have encountered
241 // up until this point can be ignored. They are out of scope now, and they were
242 // never used in a return statement.
243 fVariablesInBlocks = false;
244 }
John Stiles77702f12020-12-17 14:38:56 -0500245 return result;
246 }
247 default:
248 return INHERITED::visitStatement(stmt);
249 }
250 }
251
252 int fNumReturns = 0;
253 int fDeepestReturn = 0;
254 int fLimit = 0;
255 int fScopedBlockDepth = 0;
John Stilesc5ff4862020-12-22 13:47:05 -0500256 bool fVariablesInBlocks = false;
John Stiles77702f12020-12-17 14:38:56 -0500257 using INHERITED = ProgramVisitor;
258};
259
John Stiles44e96be2020-08-31 13:16:04 -0400260} // namespace
261
John Stiles77702f12020-12-17 14:38:56 -0500262Inliner::ReturnComplexity Inliner::GetReturnComplexity(const FunctionDefinition& funcDef) {
263 int returnsAtEndOfControlFlow = count_returns_at_end_of_control_flow(funcDef);
264 CountReturnsWithLimit counter{funcDef, returnsAtEndOfControlFlow + 1};
John Stiles77702f12020-12-17 14:38:56 -0500265 if (counter.fNumReturns > returnsAtEndOfControlFlow) {
266 return ReturnComplexity::kEarlyReturns;
267 }
John Stilesc5ff4862020-12-22 13:47:05 -0500268 if (counter.fNumReturns > 1) {
John Stiles77702f12020-12-17 14:38:56 -0500269 return ReturnComplexity::kScopedReturns;
270 }
John Stilesc5ff4862020-12-22 13:47:05 -0500271 if (counter.fVariablesInBlocks && counter.fDeepestReturn > 1) {
272 return ReturnComplexity::kScopedReturns;
273 }
274 return ReturnComplexity::kSingleSafeReturn;
John Stiles77702f12020-12-17 14:38:56 -0500275}
276
John Stilesb61ee902020-09-21 12:26:59 -0400277void Inliner::ensureScopedBlocks(Statement* inlinedBody, Statement* parentStmt) {
278 // No changes necessary if this statement isn't actually a block.
279 if (!inlinedBody || !inlinedBody->is<Block>()) {
280 return;
281 }
282
283 // No changes necessary if the parent statement doesn't require a scope.
284 if (!parentStmt || !(parentStmt->is<IfStatement>() || parentStmt->is<ForStatement>() ||
Brian Osmand6f23382020-12-15 17:08:59 -0500285 parentStmt->is<DoStatement>())) {
John Stilesb61ee902020-09-21 12:26:59 -0400286 return;
287 }
288
289 Block& block = inlinedBody->as<Block>();
290
291 // The inliner will create inlined function bodies as a Block containing multiple statements,
292 // but no scope. Normally, this is fine, but if this block is used as the statement for a
293 // do/for/if/while, this isn't actually possible to represent textually; a scope must be added
294 // for the generated code to match the intent. In the case of Blocks nested inside other Blocks,
295 // we add the scope to the outermost block if needed. Zero-statement blocks have similar
296 // issues--if we don't represent the Block textually somehow, we run the risk of accidentally
297 // absorbing the following statement into our loop--so we also add a scope to these.
298 for (Block* nestedBlock = &block;; ) {
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400299 if (nestedBlock->isScope()) {
John Stilesb61ee902020-09-21 12:26:59 -0400300 // We found an explicit scope; all is well.
301 return;
302 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400303 if (nestedBlock->children().size() != 1) {
John Stilesb61ee902020-09-21 12:26:59 -0400304 // We found a block with multiple (or zero) statements, but no scope? Let's add a scope
305 // to the outermost block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400306 block.setIsScope(true);
John Stilesb61ee902020-09-21 12:26:59 -0400307 return;
308 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400309 if (!nestedBlock->children()[0]->is<Block>()) {
John Stilesb61ee902020-09-21 12:26:59 -0400310 // This block has exactly one thing inside, and it's not another block. No need to scope
311 // it.
312 return;
313 }
314 // We have to go deeper.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400315 nestedBlock = &nestedBlock->children()[0]->as<Block>();
John Stilesb61ee902020-09-21 12:26:59 -0400316 }
317}
318
Brian Osman0006ad02020-11-18 15:38:39 -0500319void Inliner::reset(ModifiersPool* modifiers, const Program::Settings* settings) {
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400320 fModifiers = modifiers;
321 fSettings = settings;
John Stiles44e96be2020-08-31 13:16:04 -0400322 fInlineVarCounter = 0;
John Stiles031a7672020-11-13 16:13:18 -0500323 fInlinedStatementCounter = 0;
John Stiles44e96be2020-08-31 13:16:04 -0400324}
325
John Stiles6f31e272020-12-16 13:30:54 -0500326String Inliner::uniqueNameForInlineVar(String baseName, SymbolTable* symbolTable) {
327 // The inliner runs more than once, so the base name might already have a prefix like "_123_x".
328 // Let's strip that prefix off to make the generated code easier to read.
329 if (baseName.startsWith("_")) {
330 // Determine if we have a string of digits.
331 int offset = 1;
332 while (isdigit(baseName[offset])) {
333 ++offset;
334 }
335 // If we found digits, another underscore, and anything else, that's the inliner prefix.
336 // Strip it off.
337 if (offset > 1 && baseName[offset] == '_' && baseName[offset + 1] != '\0') {
338 baseName.erase(0, offset + 1);
339 } else {
340 // This name doesn't contain an inliner prefix, but it does start with an underscore.
341 // OpenGL disallows two consecutive underscores anywhere in the string, and we'll be
342 // adding one as part of the inliner prefix, so strip the leading underscore.
343 baseName.erase(0, 1);
344 }
345 }
John Stilesc75abb82020-09-14 18:24:12 -0400346
347 // Append a unique numeric prefix to avoid name overlap. Check the symbol table to make sure
348 // we're not reusing an existing name. (Note that within a single compilation pass, this check
349 // isn't fully comprehensive, as code isn't always generated in top-to-bottom order.)
350 String uniqueName;
351 for (;;) {
John Stiles6f31e272020-12-16 13:30:54 -0500352 uniqueName = String::printf("_%d_%s", fInlineVarCounter++, baseName.c_str());
John Stilesc75abb82020-09-14 18:24:12 -0400353 StringFragment frag{uniqueName.data(), uniqueName.length()};
354 if ((*symbolTable)[frag] == nullptr) {
355 break;
356 }
357 }
358
359 return uniqueName;
360}
361
John Stiles44e96be2020-08-31 13:16:04 -0400362std::unique_ptr<Expression> Inliner::inlineExpression(int offset,
363 VariableRewriteMap* varMap,
John Stilesd7cc0932020-11-30 12:24:27 -0500364 SymbolTable* symbolTableForExpression,
John Stiles44e96be2020-08-31 13:16:04 -0400365 const Expression& expression) {
366 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
367 if (e) {
John Stilesd7cc0932020-11-30 12:24:27 -0500368 return this->inlineExpression(offset, varMap, symbolTableForExpression, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400369 }
370 return nullptr;
371 };
John Stiles8e3b6be2020-10-13 11:14:08 -0400372 auto argList = [&](const ExpressionArray& originalArgs) -> ExpressionArray {
373 ExpressionArray args;
John Stilesf4bda742020-10-14 16:57:41 -0400374 args.reserve_back(originalArgs.size());
John Stiles44e96be2020-08-31 13:16:04 -0400375 for (const std::unique_ptr<Expression>& arg : originalArgs) {
376 args.push_back(expr(arg));
377 }
378 return args;
379 };
380
Ethan Nicholase6592142020-09-08 10:22:09 -0400381 switch (expression.kind()) {
382 case Expression::Kind::kBinary: {
John Stiles44e96be2020-08-31 13:16:04 -0400383 const BinaryExpression& b = expression.as<BinaryExpression>();
384 return std::make_unique<BinaryExpression>(offset,
John Stiles2d4f9592020-10-30 10:29:12 -0400385 expr(b.left()),
Ethan Nicholasc8d9c8e2020-09-22 15:05:37 -0400386 b.getOperator(),
John Stiles2d4f9592020-10-30 10:29:12 -0400387 expr(b.right()),
Ethan Nicholas30d30222020-09-11 12:27:26 -0400388 &b.type());
John Stiles44e96be2020-08-31 13:16:04 -0400389 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400390 case Expression::Kind::kBoolLiteral:
391 case Expression::Kind::kIntLiteral:
392 case Expression::Kind::kFloatLiteral:
393 case Expression::Kind::kNullLiteral:
John Stiles44e96be2020-08-31 13:16:04 -0400394 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400395 case Expression::Kind::kConstructor: {
John Stiles44e96be2020-08-31 13:16:04 -0400396 const Constructor& constructor = expression.as<Constructor>();
John Stilesd7cc0932020-11-30 12:24:27 -0500397 const Type* type = copy_if_needed(&constructor.type(), *symbolTableForExpression);
398 return std::make_unique<Constructor>(offset, type, argList(constructor.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400399 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400400 case Expression::Kind::kExternalFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400401 const ExternalFunctionCall& externalCall = expression.as<ExternalFunctionCall>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400402 return std::make_unique<ExternalFunctionCall>(offset, &externalCall.function(),
Ethan Nicholas6e86ec92020-09-30 14:29:56 -0400403 argList(externalCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400404 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400405 case Expression::Kind::kExternalValue:
John Stiles44e96be2020-08-31 13:16:04 -0400406 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400407 case Expression::Kind::kFieldAccess: {
John Stiles44e96be2020-08-31 13:16:04 -0400408 const FieldAccess& f = expression.as<FieldAccess>();
Ethan Nicholas7a95b202020-10-09 11:55:40 -0400409 return std::make_unique<FieldAccess>(expr(f.base()), f.fieldIndex(), f.ownerKind());
John Stiles44e96be2020-08-31 13:16:04 -0400410 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400411 case Expression::Kind::kFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400412 const FunctionCall& funcCall = expression.as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400413 return std::make_unique<FunctionCall>(offset, &funcCall.type(), &funcCall.function(),
414 argList(funcCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400415 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400416 case Expression::Kind::kFunctionReference:
Brian Osman2b3b35f2020-09-08 09:17:36 -0400417 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400418 case Expression::Kind::kIndex: {
John Stiles44e96be2020-08-31 13:16:04 -0400419 const IndexExpression& idx = expression.as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400420 return std::make_unique<IndexExpression>(*fContext, expr(idx.base()),
421 expr(idx.index()));
John Stiles44e96be2020-08-31 13:16:04 -0400422 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400423 case Expression::Kind::kPrefix: {
John Stiles44e96be2020-08-31 13:16:04 -0400424 const PrefixExpression& p = expression.as<PrefixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400425 return std::make_unique<PrefixExpression>(p.getOperator(), expr(p.operand()));
John Stiles44e96be2020-08-31 13:16:04 -0400426 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400427 case Expression::Kind::kPostfix: {
John Stiles44e96be2020-08-31 13:16:04 -0400428 const PostfixExpression& p = expression.as<PostfixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400429 return std::make_unique<PostfixExpression>(expr(p.operand()), p.getOperator());
John Stiles44e96be2020-08-31 13:16:04 -0400430 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400431 case Expression::Kind::kSetting:
John Stiles44e96be2020-08-31 13:16:04 -0400432 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400433 case Expression::Kind::kSwizzle: {
John Stiles44e96be2020-08-31 13:16:04 -0400434 const Swizzle& s = expression.as<Swizzle>();
Ethan Nicholas6b4d5812020-10-12 16:11:51 -0400435 return std::make_unique<Swizzle>(*fContext, expr(s.base()), s.components());
John Stiles44e96be2020-08-31 13:16:04 -0400436 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400437 case Expression::Kind::kTernary: {
John Stiles44e96be2020-08-31 13:16:04 -0400438 const TernaryExpression& t = expression.as<TernaryExpression>();
Ethan Nicholasdd218162020-10-08 05:48:01 -0400439 return std::make_unique<TernaryExpression>(offset, expr(t.test()),
440 expr(t.ifTrue()), expr(t.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400441 }
Brian Osman83ba9302020-09-11 13:33:46 -0400442 case Expression::Kind::kTypeReference:
443 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400444 case Expression::Kind::kVariableReference: {
John Stiles44e96be2020-08-31 13:16:04 -0400445 const VariableReference& v = expression.as<VariableReference>();
Ethan Nicholas78686922020-10-08 06:46:27 -0400446 auto varMapIter = varMap->find(v.variable());
John Stilese41b4ee2020-09-28 12:28:16 -0400447 if (varMapIter != varMap->end()) {
Ethan Nicholas78686922020-10-08 06:46:27 -0400448 return clone_with_ref_kind(*varMapIter->second, v.refKind());
John Stiles44e96be2020-08-31 13:16:04 -0400449 }
450 return v.clone();
451 }
452 default:
453 SkASSERT(false);
454 return nullptr;
455 }
456}
457
458std::unique_ptr<Statement> Inliner::inlineStatement(int offset,
459 VariableRewriteMap* varMap,
460 SymbolTable* symbolTableForStatement,
John Stiles77702f12020-12-17 14:38:56 -0500461 std::unique_ptr<Expression>* resultExpr,
462 ReturnComplexity returnComplexity,
Brian Osman3887a012020-09-30 13:22:27 -0400463 const Statement& statement,
464 bool isBuiltinCode) {
John Stiles44e96be2020-08-31 13:16:04 -0400465 auto stmt = [&](const std::unique_ptr<Statement>& s) -> std::unique_ptr<Statement> {
466 if (s) {
John Stilesa5f3c312020-09-22 12:05:16 -0400467 return this->inlineStatement(offset, varMap, symbolTableForStatement, resultExpr,
John Stiles77702f12020-12-17 14:38:56 -0500468 returnComplexity, *s, isBuiltinCode);
John Stiles44e96be2020-08-31 13:16:04 -0400469 }
470 return nullptr;
471 };
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400472 auto blockStmts = [&](const Block& block) {
John Stiles8f2a0cf2020-10-13 12:48:21 -0400473 StatementArray result;
John Stilesf4bda742020-10-14 16:57:41 -0400474 result.reserve_back(block.children().size());
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400475 for (const std::unique_ptr<Statement>& child : block.children()) {
476 result.push_back(stmt(child));
477 }
478 return result;
479 };
John Stiles8f2a0cf2020-10-13 12:48:21 -0400480 auto stmts = [&](const StatementArray& ss) {
481 StatementArray result;
John Stilesf4bda742020-10-14 16:57:41 -0400482 result.reserve_back(ss.size());
John Stiles44e96be2020-08-31 13:16:04 -0400483 for (const auto& s : ss) {
484 result.push_back(stmt(s));
485 }
486 return result;
487 };
488 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
489 if (e) {
John Stilesd7cc0932020-11-30 12:24:27 -0500490 return this->inlineExpression(offset, varMap, symbolTableForStatement, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400491 }
492 return nullptr;
493 };
John Stiles031a7672020-11-13 16:13:18 -0500494
495 ++fInlinedStatementCounter;
496
Ethan Nicholase6592142020-09-08 10:22:09 -0400497 switch (statement.kind()) {
498 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -0400499 const Block& b = statement.as<Block>();
John Stilesa1e2b412020-10-20 14:51:28 -0400500 return std::make_unique<Block>(offset, blockStmts(b),
501 SymbolTable::WrapIfBuiltin(b.symbolTable()),
502 b.isScope());
John Stiles44e96be2020-08-31 13:16:04 -0400503 }
504
Ethan Nicholase6592142020-09-08 10:22:09 -0400505 case Statement::Kind::kBreak:
506 case Statement::Kind::kContinue:
507 case Statement::Kind::kDiscard:
John Stiles44e96be2020-08-31 13:16:04 -0400508 return statement.clone();
509
Ethan Nicholase6592142020-09-08 10:22:09 -0400510 case Statement::Kind::kDo: {
John Stiles44e96be2020-08-31 13:16:04 -0400511 const DoStatement& d = statement.as<DoStatement>();
Ethan Nicholas1fd61162020-09-28 13:14:19 -0400512 return std::make_unique<DoStatement>(offset, stmt(d.statement()), expr(d.test()));
John Stiles44e96be2020-08-31 13:16:04 -0400513 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400514 case Statement::Kind::kExpression: {
John Stiles44e96be2020-08-31 13:16:04 -0400515 const ExpressionStatement& e = statement.as<ExpressionStatement>();
Ethan Nicholasd503a5a2020-09-30 09:29:55 -0400516 return std::make_unique<ExpressionStatement>(expr(e.expression()));
John Stiles44e96be2020-08-31 13:16:04 -0400517 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400518 case Statement::Kind::kFor: {
John Stiles44e96be2020-08-31 13:16:04 -0400519 const ForStatement& f = statement.as<ForStatement>();
520 // need to ensure initializer is evaluated first so that we've already remapped its
521 // declarations by the time we evaluate test & next
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400522 std::unique_ptr<Statement> initializer = stmt(f.initializer());
523 return std::make_unique<ForStatement>(offset, std::move(initializer), expr(f.test()),
John Stilesa1e2b412020-10-20 14:51:28 -0400524 expr(f.next()), stmt(f.statement()),
525 SymbolTable::WrapIfBuiltin(f.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400526 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400527 case Statement::Kind::kIf: {
John Stiles44e96be2020-08-31 13:16:04 -0400528 const IfStatement& i = statement.as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400529 return std::make_unique<IfStatement>(offset, i.isStatic(), expr(i.test()),
530 stmt(i.ifTrue()), stmt(i.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400531 }
John Stiles98c1f822020-09-09 14:18:53 -0400532 case Statement::Kind::kInlineMarker:
Ethan Nicholase6592142020-09-08 10:22:09 -0400533 case Statement::Kind::kNop:
John Stiles44e96be2020-08-31 13:16:04 -0400534 return statement.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400535 case Statement::Kind::kReturn: {
John Stiles44e96be2020-08-31 13:16:04 -0400536 const ReturnStatement& r = statement.as<ReturnStatement>();
John Stiles77702f12020-12-17 14:38:56 -0500537 if (!r.expression()) {
538 if (returnComplexity >= ReturnComplexity::kEarlyReturns) {
539 // This function doesn't return a value, but has early returns, so we've wrapped
540 // it in a for loop. Use a continue to jump to the end of the loop and "leave"
541 // the function.
John Stiles7b920442020-12-17 10:43:41 -0500542 return std::make_unique<ContinueStatement>(offset);
John Stiles44e96be2020-08-31 13:16:04 -0400543 } else {
John Stiles77702f12020-12-17 14:38:56 -0500544 // This function doesn't exit early or return a value. A return statement at the
545 // end is a no-op and can be treated as such.
John Stiles44e96be2020-08-31 13:16:04 -0400546 return std::make_unique<Nop>();
547 }
548 }
John Stiles77702f12020-12-17 14:38:56 -0500549
John Stilesc5ff4862020-12-22 13:47:05 -0500550 // If a function only contains a single return, and it doesn't reference variables from
551 // inside an Block's scope, we don't need to store the result in a variable at all. Just
552 // replace the function-call expression with the function's return expression.
John Stiles77702f12020-12-17 14:38:56 -0500553 SkASSERT(resultExpr);
554 SkASSERT(*resultExpr);
John Stilesc5ff4862020-12-22 13:47:05 -0500555 if (returnComplexity <= ReturnComplexity::kSingleSafeReturn) {
John Stiles77702f12020-12-17 14:38:56 -0500556 *resultExpr = expr(r.expression());
557 return std::make_unique<Nop>();
558 }
559
560 // For more complex functions, assign their result into a variable.
561 auto assignment =
562 std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
563 offset,
564 clone_with_ref_kind(**resultExpr, VariableReference::RefKind::kWrite),
565 Token::Kind::TK_EQ,
566 expr(r.expression()),
567 &resultExpr->get()->type()));
568
569 // Early returns are wrapped in a for loop; we need to synthesize a continue statement
570 // to "leave" the function.
571 if (returnComplexity >= ReturnComplexity::kEarlyReturns) {
572 StatementArray block;
573 block.reserve_back(2);
574 block.push_back(std::move(assignment));
575 block.push_back(std::make_unique<ContinueStatement>(offset));
576 return std::make_unique<Block>(offset, std::move(block), /*symbols=*/nullptr,
577 /*isScope=*/true);
578 }
579 // Functions without early returns aren't wrapped in a for loop and don't need to worry
580 // about breaking out of the control flow.
581 return std::move(assignment);
582
John Stiles44e96be2020-08-31 13:16:04 -0400583 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400584 case Statement::Kind::kSwitch: {
John Stiles44e96be2020-08-31 13:16:04 -0400585 const SwitchStatement& ss = statement.as<SwitchStatement>();
586 std::vector<std::unique_ptr<SwitchCase>> cases;
John Stiles2d4f9592020-10-30 10:29:12 -0400587 cases.reserve(ss.cases().size());
588 for (const std::unique_ptr<SwitchCase>& sc : ss.cases()) {
589 cases.push_back(std::make_unique<SwitchCase>(offset, expr(sc->value()),
590 stmts(sc->statements())));
John Stiles44e96be2020-08-31 13:16:04 -0400591 }
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400592 return std::make_unique<SwitchStatement>(offset, ss.isStatic(), expr(ss.value()),
John Stilesa1e2b412020-10-20 14:51:28 -0400593 std::move(cases),
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400594 SymbolTable::WrapIfBuiltin(ss.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400595 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400596 case Statement::Kind::kVarDeclaration: {
John Stiles44e96be2020-08-31 13:16:04 -0400597 const VarDeclaration& decl = statement.as<VarDeclaration>();
John Stiles35fee4c2020-12-16 18:25:14 +0000598 std::unique_ptr<Expression> initialValue = expr(decl.value());
599 int arraySize = decl.arraySize();
600 const Variable& old = decl.var();
601 // We assign unique names to inlined variables--scopes hide most of the problems in this
602 // regard, but see `InlinerAvoidsVariableNameOverlap` for a counterexample where unique
603 // names are important.
604 auto name = std::make_unique<String>(
605 this->uniqueNameForInlineVar(String(old.name()), symbolTableForStatement));
606 const String* namePtr = symbolTableForStatement->takeOwnershipOfString(std::move(name));
607 const Type* baseTypePtr = copy_if_needed(&decl.baseType(), *symbolTableForStatement);
608 const Type* typePtr = copy_if_needed(&old.type(), *symbolTableForStatement);
609 const Variable* clone = symbolTableForStatement->takeOwnershipOfSymbol(
610 std::make_unique<Variable>(offset,
611 &old.modifiers(),
612 namePtr->c_str(),
613 typePtr,
614 isBuiltinCode,
615 old.storage(),
616 initialValue.get()));
617 (*varMap)[&old] = std::make_unique<VariableReference>(offset, clone);
618 return std::make_unique<VarDeclaration>(clone, baseTypePtr, arraySize,
619 std::move(initialValue));
John Stiles44e96be2020-08-31 13:16:04 -0400620 }
John Stiles44e96be2020-08-31 13:16:04 -0400621 default:
622 SkASSERT(false);
623 return nullptr;
624 }
625}
626
John Stiles7b920442020-12-17 10:43:41 -0500627Inliner::InlineVariable Inliner::makeInlineVariable(const String& baseName,
628 const Type* type,
629 SymbolTable* symbolTable,
630 Modifiers modifiers,
631 bool isBuiltinCode,
632 std::unique_ptr<Expression>* initialValue) {
633 // $floatLiteral or $intLiteral aren't real types that we can use for scratch variables, so
634 // replace them if they ever appear here. If this happens, we likely forgot to coerce a type
635 // somewhere during compilation.
636 if (type == fContext->fFloatLiteral_Type.get()) {
637 SkDEBUGFAIL("found a $floatLiteral type while inlining");
638 type = fContext->fFloat_Type.get();
639 } else if (type == fContext->fIntLiteral_Type.get()) {
640 SkDEBUGFAIL("found an $intLiteral type while inlining");
641 type = fContext->fInt_Type.get();
642 }
643
644 // Provide our new variable with a unique name, and add it to our symbol table.
645 const String* namePtr = symbolTable->takeOwnershipOfString(
646 std::make_unique<String>(this->uniqueNameForInlineVar(baseName, symbolTable)));
647 StringFragment nameFrag{namePtr->c_str(), namePtr->length()};
648
649 // Create our new variable and add it to the symbol table.
650 InlineVariable result;
651 result.fVarSymbol =
652 symbolTable->add(std::make_unique<Variable>(/*offset=*/-1,
653 fModifiers->addToPool(Modifiers()),
654 nameFrag,
655 type,
656 isBuiltinCode,
657 Variable::Storage::kLocal,
658 initialValue->get()));
659
660 // Prepare the variable declaration (taking extra care with `out` params to not clobber any
661 // initial value).
662 if (*initialValue && (modifiers.fFlags & Modifiers::kOut_Flag)) {
663 result.fVarDecl = std::make_unique<VarDeclaration>(result.fVarSymbol, type, /*arraySize=*/0,
664 (*initialValue)->clone());
665 } else {
666 result.fVarDecl = std::make_unique<VarDeclaration>(result.fVarSymbol, type, /*arraySize=*/0,
667 std::move(*initialValue));
668 }
669 return result;
670}
671
John Stiles6eadf132020-09-08 10:16:10 -0400672Inliner::InlinedCall Inliner::inlineCall(FunctionCall* call,
John Stiles78047582020-12-16 16:17:41 -0500673 std::shared_ptr<SymbolTable> symbolTable,
Brian Osman3887a012020-09-30 13:22:27 -0400674 const FunctionDeclaration* caller) {
John Stiles44e96be2020-08-31 13:16:04 -0400675 // Inlining is more complicated here than in a typical compiler, because we have to have a
676 // high-level IR and can't just drop statements into the middle of an expression or even use
677 // gotos.
678 //
679 // Since we can't insert statements into an expression, we run the inline function as extra
680 // statements before the statement we're currently processing, relying on a lack of execution
681 // order guarantees. Since we can't use gotos (which are normally used to replace return
682 // statements), we wrap the whole function in a loop and use break statements to jump to the
683 // end.
684 SkASSERT(fSettings);
685 SkASSERT(fContext);
686 SkASSERT(call);
Ethan Nicholased84b732020-10-08 11:45:44 -0400687 SkASSERT(this->isSafeToInline(call->function().definition()));
John Stiles44e96be2020-08-31 13:16:04 -0400688
John Stiles8e3b6be2020-10-13 11:14:08 -0400689 ExpressionArray& arguments = call->arguments();
John Stiles6eadf132020-09-08 10:16:10 -0400690 const int offset = call->fOffset;
Ethan Nicholased84b732020-10-08 11:45:44 -0400691 const FunctionDefinition& function = *call->function().definition();
John Stiles77702f12020-12-17 14:38:56 -0500692 const ReturnComplexity returnComplexity = GetReturnComplexity(function);
693 bool hasEarlyReturn = (returnComplexity >= ReturnComplexity::kEarlyReturns);
John Stiles6eadf132020-09-08 10:16:10 -0400694
John Stiles44e96be2020-08-31 13:16:04 -0400695 InlinedCall inlinedCall;
John Stiles8f2a0cf2020-10-13 12:48:21 -0400696 inlinedCall.fInlinedBody = std::make_unique<Block>(offset, StatementArray{},
John Stiles6eadf132020-09-08 10:16:10 -0400697 /*symbols=*/nullptr,
698 /*isScope=*/false);
John Stiles98c1f822020-09-09 14:18:53 -0400699
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400700 Block& inlinedBody = *inlinedCall.fInlinedBody;
John Stiles82f373c2020-10-20 13:58:05 -0400701 inlinedBody.children().reserve_back(
702 1 + // Inline marker
703 1 + // Result variable
704 arguments.size() + // Function arguments (passing in)
705 arguments.size() + // Function arguments (copy out-params back)
John Stiles7b920442020-12-17 10:43:41 -0500706 1); // Block for inlined code
John Stiles98c1f822020-09-09 14:18:53 -0400707
Ethan Nicholasceb62142020-10-09 16:51:18 -0400708 inlinedBody.children().push_back(std::make_unique<InlineMarker>(&call->function()));
John Stiles44e96be2020-08-31 13:16:04 -0400709
John Stiles44e96be2020-08-31 13:16:04 -0400710 // Create a variable to hold the result in the extra statements (excepting void).
John Stilese41b4ee2020-09-28 12:28:16 -0400711 std::unique_ptr<Expression> resultExpr;
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400712 if (function.declaration().returnType() != *fContext->fVoid_Type) {
John Stiles44e96be2020-08-31 13:16:04 -0400713 std::unique_ptr<Expression> noInitialValue;
John Stiles7b920442020-12-17 10:43:41 -0500714 InlineVariable var = this->makeInlineVariable(function.declaration().name(),
715 &function.declaration().returnType(),
716 symbolTable.get(), Modifiers{},
717 caller->isBuiltin(), &noInitialValue);
718 inlinedBody.children().push_back(std::move(var.fVarDecl));
719 resultExpr = std::make_unique<VariableReference>(/*offset=*/-1, var.fVarSymbol);
John Stiles35fee4c2020-12-16 18:25:14 +0000720 }
John Stiles44e96be2020-08-31 13:16:04 -0400721
722 // Create variables in the extra statements to hold the arguments, and assign the arguments to
723 // them.
724 VariableRewriteMap varMap;
John Stilese41b4ee2020-09-28 12:28:16 -0400725 std::vector<int> argsToCopyBack;
John Stiles44e96be2020-08-31 13:16:04 -0400726 for (int i = 0; i < (int) arguments.size(); ++i) {
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400727 const Variable* param = function.declaration().parameters()[i];
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400728 bool isOutParam = param->modifiers().fFlags & Modifiers::kOut_Flag;
John Stiles44e96be2020-08-31 13:16:04 -0400729
John Stiles44733aa2020-09-29 17:42:23 -0400730 // If this argument can be inlined trivially (e.g. a swizzle, or a constant array index)...
John Stilesc30fbca2020-11-19 16:25:49 -0500731 if (Analysis::IsTrivialExpression(*arguments[i])) {
John Stilese41b4ee2020-09-28 12:28:16 -0400732 // ... and it's an `out` param, or it isn't written to within the inline function...
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400733 if (isOutParam || !Analysis::StatementWritesToVariable(*function.body(), *param)) {
John Stilesf201af82020-09-29 16:57:55 -0400734 // ... we don't need to copy it at all! We can just use the existing expression.
735 varMap[param] = arguments[i]->clone();
John Stiles44e96be2020-08-31 13:16:04 -0400736 continue;
737 }
738 }
John Stilese41b4ee2020-09-28 12:28:16 -0400739 if (isOutParam) {
740 argsToCopyBack.push_back(i);
741 }
John Stiles7b920442020-12-17 10:43:41 -0500742 InlineVariable var = this->makeInlineVariable(param->name(), &arguments[i]->type(),
743 symbolTable.get(), param->modifiers(),
744 caller->isBuiltin(), &arguments[i]);
745 inlinedBody.children().push_back(std::move(var.fVarDecl));
746 varMap[param] = std::make_unique<VariableReference>(/*offset=*/-1, var.fVarSymbol);
John Stiles44e96be2020-08-31 13:16:04 -0400747 }
748
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400749 const Block& body = function.body()->as<Block>();
John Stiles7b920442020-12-17 10:43:41 -0500750 StatementArray* inlineStatements;
751
John Stiles44e96be2020-08-31 13:16:04 -0400752 if (hasEarlyReturn) {
753 // Since we output to backends that don't have a goto statement (which would normally be
John Stiles7b920442020-12-17 10:43:41 -0500754 // used to perform an early return), we fake it by wrapping the function in a single-
755 // iteration for loop, and use a continue statement to jump to the end of the loop
756 // prematurely.
757
758 // int _1_loop = 0;
759 symbolTable = std::make_shared<SymbolTable>(std::move(symbolTable), caller->isBuiltin());
760 const Type* intType = fContext->fInt_Type.get();
761 std::unique_ptr<Expression> initialValue = std::make_unique<IntLiteral>(/*offset=*/-1,
762 /*value=*/0,
763 intType);
764 InlineVariable loopVar = this->makeInlineVariable("loop", intType, symbolTable.get(),
765 Modifiers{}, caller->isBuiltin(),
766 &initialValue);
767
768 // _1_loop < 1;
769 std::unique_ptr<Expression> test = std::make_unique<BinaryExpression>(
John Stiles44e96be2020-08-31 13:16:04 -0400770 /*offset=*/-1,
John Stiles7b920442020-12-17 10:43:41 -0500771 std::make_unique<VariableReference>(/*offset=*/-1, loopVar.fVarSymbol),
772 Token::Kind::TK_LT,
773 std::make_unique<IntLiteral>(/*offset=*/-1, /*value=*/1, intType),
774 fContext->fBool_Type.get());
775
776 // _1_loop++
777 std::unique_ptr<Expression> increment = std::make_unique<PostfixExpression>(
778 std::make_unique<VariableReference>(/*offset=*/-1, loopVar.fVarSymbol,
779 VariableReference::RefKind::kReadWrite),
780 Token::Kind::TK_PLUSPLUS);
781
782 // {...}
783 auto innerBlock = std::make_unique<Block>(offset, StatementArray{},
784 /*symbols=*/nullptr, /*isScope=*/true);
785 inlineStatements = &innerBlock->children();
786
787 // for (int _1_loop = 0; _1_loop < 1; _1_loop++) {...}
788 inlinedBody.children().push_back(std::make_unique<ForStatement>(/*offset=*/-1,
789 std::move(loopVar.fVarDecl),
790 std::move(test),
791 std::move(increment),
792 std::move(innerBlock),
793 symbolTable));
John Stiles44e96be2020-08-31 13:16:04 -0400794 } else {
John Stilesfa9a0832020-12-17 10:43:58 -0500795 // No early returns, so we can just dump the code into our existing scopeless block.
796 inlineStatements = &inlinedBody.children();
John Stiles7b920442020-12-17 10:43:41 -0500797 }
798
799 inlineStatements->reserve_back(body.children().size() + argsToCopyBack.size());
800 for (const std::unique_ptr<Statement>& stmt : body.children()) {
801 inlineStatements->push_back(this->inlineStatement(offset, &varMap, symbolTable.get(),
John Stiles77702f12020-12-17 14:38:56 -0500802 &resultExpr, returnComplexity, *stmt,
John Stiles7b920442020-12-17 10:43:41 -0500803 caller->isBuiltin()));
John Stiles44e96be2020-08-31 13:16:04 -0400804 }
805
John Stilese41b4ee2020-09-28 12:28:16 -0400806 // Copy back the values of `out` parameters into their real destinations.
807 for (int i : argsToCopyBack) {
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400808 const Variable* p = function.declaration().parameters()[i];
John Stilese41b4ee2020-09-28 12:28:16 -0400809 SkASSERT(varMap.find(p) != varMap.end());
John Stiles7b920442020-12-17 10:43:41 -0500810 inlineStatements->push_back(
John Stilese41b4ee2020-09-28 12:28:16 -0400811 std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
812 offset,
Ethan Nicholas453f67f2020-10-09 10:43:45 -0400813 clone_with_ref_kind(*arguments[i], VariableReference::RefKind::kWrite),
John Stilese41b4ee2020-09-28 12:28:16 -0400814 Token::Kind::TK_EQ,
815 std::move(varMap[p]),
816 &arguments[i]->type())));
John Stiles44e96be2020-08-31 13:16:04 -0400817 }
818
John Stilese41b4ee2020-09-28 12:28:16 -0400819 if (resultExpr != nullptr) {
820 // Return our result variable as our replacement expression.
John Stilese41b4ee2020-09-28 12:28:16 -0400821 inlinedCall.fReplacementExpr = std::move(resultExpr);
John Stiles44e96be2020-08-31 13:16:04 -0400822 } else {
823 // It's a void function, so it doesn't actually result in anything, but we have to return
824 // something non-null as a standin.
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400825 inlinedCall.fReplacementExpr = std::make_unique<BoolLiteral>(*fContext,
826 offset,
John Stiles44e96be2020-08-31 13:16:04 -0400827 /*value=*/false);
828 }
829
John Stiles44e96be2020-08-31 13:16:04 -0400830 return inlinedCall;
831}
832
John Stiles2d7973a2020-10-02 15:01:03 -0400833bool Inliner::isSafeToInline(const FunctionDefinition* functionDef) {
John Stiles44e96be2020-08-31 13:16:04 -0400834 SkASSERT(fSettings);
835
John Stiles1c03d332020-10-13 10:30:23 -0400836 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
837 if (fSettings->fInlineThreshold <= 0) {
838 return false;
839 }
840
John Stiles031a7672020-11-13 16:13:18 -0500841 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
842 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
843 return false;
844 }
845
John Stiles2d7973a2020-10-02 15:01:03 -0400846 if (functionDef == nullptr) {
John Stiles44e96be2020-08-31 13:16:04 -0400847 // Can't inline something if we don't actually have its definition.
848 return false;
849 }
John Stiles2d7973a2020-10-02 15:01:03 -0400850
John Stiles74ebd7e2020-12-17 14:41:50 -0500851 // We don't have any mechanism to simulate early returns within a construct that supports
852 // continues (for/do/while), so we can't inline if there's a return inside one.
853 bool hasReturnInContinuableConstruct =
854 (count_returns_in_continuable_constructs(*functionDef) > 0);
855 return !hasReturnInContinuableConstruct;
John Stiles44e96be2020-08-31 13:16:04 -0400856}
857
John Stiles2d7973a2020-10-02 15:01:03 -0400858// A candidate function for inlining, containing everything that `inlineCall` needs.
859struct InlineCandidate {
John Stiles78047582020-12-16 16:17:41 -0500860 std::shared_ptr<SymbolTable> fSymbols; // the SymbolTable of the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400861 std::unique_ptr<Statement>* fParentStmt; // the parent Statement of the enclosing stmt
862 std::unique_ptr<Statement>* fEnclosingStmt; // the Statement containing the candidate
863 std::unique_ptr<Expression>* fCandidateExpr; // the candidate FunctionCall to be inlined
864 FunctionDefinition* fEnclosingFunction; // the Function containing the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400865};
John Stiles93442622020-09-11 12:11:27 -0400866
John Stiles2d7973a2020-10-02 15:01:03 -0400867struct InlineCandidateList {
868 std::vector<InlineCandidate> fCandidates;
869};
870
871class InlineCandidateAnalyzer {
John Stiles70957c82020-10-02 16:42:10 -0400872public:
873 // A list of all the inlining candidates we found during analysis.
874 InlineCandidateList* fCandidateList;
John Stiles2d7973a2020-10-02 15:01:03 -0400875
John Stiles70957c82020-10-02 16:42:10 -0400876 // A stack of the symbol tables; since most nodes don't have one, expected to be shallower than
877 // the enclosing-statement stack.
John Stiles78047582020-12-16 16:17:41 -0500878 std::vector<std::shared_ptr<SymbolTable>> fSymbolTableStack;
John Stiles70957c82020-10-02 16:42:10 -0400879 // A stack of "enclosing" statements--these would be suitable for the inliner to use for adding
880 // new instructions. Not all statements are suitable (e.g. a for-loop's initializer). The
881 // inliner might replace a statement with a block containing the statement.
882 std::vector<std::unique_ptr<Statement>*> fEnclosingStmtStack;
883 // The function that we're currently processing (i.e. inlining into).
884 FunctionDefinition* fEnclosingFunction = nullptr;
John Stiles93442622020-09-11 12:11:27 -0400885
Brian Osman0006ad02020-11-18 15:38:39 -0500886 void visit(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -0500887 std::shared_ptr<SymbolTable> symbols,
Brian Osman0006ad02020-11-18 15:38:39 -0500888 InlineCandidateList* candidateList) {
John Stiles70957c82020-10-02 16:42:10 -0400889 fCandidateList = candidateList;
Brian Osman0006ad02020-11-18 15:38:39 -0500890 fSymbolTableStack.push_back(symbols);
John Stiles93442622020-09-11 12:11:27 -0400891
Brian Osman0006ad02020-11-18 15:38:39 -0500892 for (const std::unique_ptr<ProgramElement>& pe : elements) {
Brian Osman1179fcf2020-10-08 16:04:40 -0400893 this->visitProgramElement(pe.get());
John Stiles93442622020-09-11 12:11:27 -0400894 }
895
John Stiles70957c82020-10-02 16:42:10 -0400896 fSymbolTableStack.pop_back();
897 fCandidateList = nullptr;
898 }
899
900 void visitProgramElement(ProgramElement* pe) {
901 switch (pe->kind()) {
902 case ProgramElement::Kind::kFunction: {
903 FunctionDefinition& funcDef = pe->as<FunctionDefinition>();
Brian Osman0006ad02020-11-18 15:38:39 -0500904 fEnclosingFunction = &funcDef;
905 this->visitStatement(&funcDef.body());
John Stiles70957c82020-10-02 16:42:10 -0400906 break;
John Stiles93442622020-09-11 12:11:27 -0400907 }
John Stiles70957c82020-10-02 16:42:10 -0400908 default:
909 // The inliner can't operate outside of a function's scope.
910 break;
911 }
912 }
913
914 void visitStatement(std::unique_ptr<Statement>* stmt,
915 bool isViableAsEnclosingStatement = true) {
916 if (!*stmt) {
917 return;
John Stiles93442622020-09-11 12:11:27 -0400918 }
919
John Stiles70957c82020-10-02 16:42:10 -0400920 size_t oldEnclosingStmtStackSize = fEnclosingStmtStack.size();
921 size_t oldSymbolStackSize = fSymbolTableStack.size();
John Stiles93442622020-09-11 12:11:27 -0400922
John Stiles70957c82020-10-02 16:42:10 -0400923 if (isViableAsEnclosingStatement) {
924 fEnclosingStmtStack.push_back(stmt);
John Stiles93442622020-09-11 12:11:27 -0400925 }
926
John Stiles70957c82020-10-02 16:42:10 -0400927 switch ((*stmt)->kind()) {
928 case Statement::Kind::kBreak:
929 case Statement::Kind::kContinue:
930 case Statement::Kind::kDiscard:
931 case Statement::Kind::kInlineMarker:
932 case Statement::Kind::kNop:
933 break;
934
935 case Statement::Kind::kBlock: {
936 Block& block = (*stmt)->as<Block>();
937 if (block.symbolTable()) {
John Stiles78047582020-12-16 16:17:41 -0500938 fSymbolTableStack.push_back(block.symbolTable());
John Stiles70957c82020-10-02 16:42:10 -0400939 }
940
941 for (std::unique_ptr<Statement>& stmt : block.children()) {
942 this->visitStatement(&stmt);
943 }
944 break;
John Stiles93442622020-09-11 12:11:27 -0400945 }
John Stiles70957c82020-10-02 16:42:10 -0400946 case Statement::Kind::kDo: {
947 DoStatement& doStmt = (*stmt)->as<DoStatement>();
948 // The loop body is a candidate for inlining.
949 this->visitStatement(&doStmt.statement());
950 // The inliner isn't smart enough to inline the test-expression for a do-while
951 // loop at this time. There are two limitations:
952 // - We would need to insert the inlined-body block at the very end of the do-
953 // statement's inner fStatement. We don't support that today, but it's doable.
954 // - We cannot inline the test expression if the loop uses `continue` anywhere; that
955 // would skip over the inlined block that evaluates the test expression. There
956 // isn't a good fix for this--any workaround would be more complex than the cost
957 // of a function call. However, loops that don't use `continue` would still be
958 // viable candidates for inlining.
959 break;
John Stiles93442622020-09-11 12:11:27 -0400960 }
John Stiles70957c82020-10-02 16:42:10 -0400961 case Statement::Kind::kExpression: {
962 ExpressionStatement& expr = (*stmt)->as<ExpressionStatement>();
963 this->visitExpression(&expr.expression());
964 break;
965 }
966 case Statement::Kind::kFor: {
967 ForStatement& forStmt = (*stmt)->as<ForStatement>();
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400968 if (forStmt.symbols()) {
John Stiles78047582020-12-16 16:17:41 -0500969 fSymbolTableStack.push_back(forStmt.symbols());
John Stiles70957c82020-10-02 16:42:10 -0400970 }
971
972 // The initializer and loop body are candidates for inlining.
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400973 this->visitStatement(&forStmt.initializer(),
John Stiles70957c82020-10-02 16:42:10 -0400974 /*isViableAsEnclosingStatement=*/false);
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400975 this->visitStatement(&forStmt.statement());
John Stiles70957c82020-10-02 16:42:10 -0400976
977 // The inliner isn't smart enough to inline the test- or increment-expressions
978 // of a for loop loop at this time. There are a handful of limitations:
979 // - We would need to insert the test-expression block at the very beginning of the
980 // for-loop's inner fStatement, and the increment-expression block at the very
981 // end. We don't support that today, but it's doable.
982 // - The for-loop's built-in test-expression would need to be dropped entirely,
983 // and the loop would be halted via a break statement at the end of the inlined
984 // test-expression. This is again something we don't support today, but it could
985 // be implemented.
986 // - We cannot inline the increment-expression if the loop uses `continue` anywhere;
987 // that would skip over the inlined block that evaluates the increment expression.
988 // There isn't a good fix for this--any workaround would be more complex than the
989 // cost of a function call. However, loops that don't use `continue` would still
990 // be viable candidates for increment-expression inlining.
991 break;
992 }
993 case Statement::Kind::kIf: {
994 IfStatement& ifStmt = (*stmt)->as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400995 this->visitExpression(&ifStmt.test());
996 this->visitStatement(&ifStmt.ifTrue());
997 this->visitStatement(&ifStmt.ifFalse());
John Stiles70957c82020-10-02 16:42:10 -0400998 break;
999 }
1000 case Statement::Kind::kReturn: {
1001 ReturnStatement& returnStmt = (*stmt)->as<ReturnStatement>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -04001002 this->visitExpression(&returnStmt.expression());
John Stiles70957c82020-10-02 16:42:10 -04001003 break;
1004 }
1005 case Statement::Kind::kSwitch: {
1006 SwitchStatement& switchStmt = (*stmt)->as<SwitchStatement>();
Ethan Nicholas01b05e52020-10-22 15:53:41 -04001007 if (switchStmt.symbols()) {
John Stiles78047582020-12-16 16:17:41 -05001008 fSymbolTableStack.push_back(switchStmt.symbols());
John Stiles70957c82020-10-02 16:42:10 -04001009 }
1010
Ethan Nicholas01b05e52020-10-22 15:53:41 -04001011 this->visitExpression(&switchStmt.value());
John Stiles2d4f9592020-10-30 10:29:12 -04001012 for (const std::unique_ptr<SwitchCase>& switchCase : switchStmt.cases()) {
John Stiles70957c82020-10-02 16:42:10 -04001013 // The switch-case's fValue cannot be a FunctionCall; skip it.
John Stiles2d4f9592020-10-30 10:29:12 -04001014 for (std::unique_ptr<Statement>& caseBlock : switchCase->statements()) {
John Stiles70957c82020-10-02 16:42:10 -04001015 this->visitStatement(&caseBlock);
1016 }
1017 }
1018 break;
1019 }
1020 case Statement::Kind::kVarDeclaration: {
1021 VarDeclaration& varDeclStmt = (*stmt)->as<VarDeclaration>();
1022 // Don't need to scan the declaration's sizes; those are always IntLiterals.
Ethan Nicholasc51f33e2020-10-13 13:49:44 -04001023 this->visitExpression(&varDeclStmt.value());
John Stiles70957c82020-10-02 16:42:10 -04001024 break;
1025 }
John Stiles70957c82020-10-02 16:42:10 -04001026 default:
1027 SkUNREACHABLE;
John Stiles93442622020-09-11 12:11:27 -04001028 }
1029
John Stiles70957c82020-10-02 16:42:10 -04001030 // Pop our symbol and enclosing-statement stacks.
1031 fSymbolTableStack.resize(oldSymbolStackSize);
1032 fEnclosingStmtStack.resize(oldEnclosingStmtStackSize);
1033 }
1034
1035 void visitExpression(std::unique_ptr<Expression>* expr) {
1036 if (!*expr) {
1037 return;
John Stiles93442622020-09-11 12:11:27 -04001038 }
John Stiles70957c82020-10-02 16:42:10 -04001039
1040 switch ((*expr)->kind()) {
1041 case Expression::Kind::kBoolLiteral:
1042 case Expression::Kind::kDefined:
1043 case Expression::Kind::kExternalValue:
1044 case Expression::Kind::kFieldAccess:
1045 case Expression::Kind::kFloatLiteral:
1046 case Expression::Kind::kFunctionReference:
1047 case Expression::Kind::kIntLiteral:
1048 case Expression::Kind::kNullLiteral:
1049 case Expression::Kind::kSetting:
1050 case Expression::Kind::kTypeReference:
1051 case Expression::Kind::kVariableReference:
1052 // Nothing to scan here.
1053 break;
1054
1055 case Expression::Kind::kBinary: {
1056 BinaryExpression& binaryExpr = (*expr)->as<BinaryExpression>();
John Stiles2d4f9592020-10-30 10:29:12 -04001057 this->visitExpression(&binaryExpr.left());
John Stiles70957c82020-10-02 16:42:10 -04001058
1059 // Logical-and and logical-or binary expressions do not inline the right side,
1060 // because that would invalidate short-circuiting. That is, when evaluating
1061 // expressions like these:
1062 // (false && x()) // always false
1063 // (true || y()) // always true
1064 // It is illegal for side-effects from x() or y() to occur. The simplest way to
1065 // enforce that rule is to avoid inlining the right side entirely. However, it is
1066 // safe for other types of binary expression to inline both sides.
1067 Token::Kind op = binaryExpr.getOperator();
1068 bool shortCircuitable = (op == Token::Kind::TK_LOGICALAND ||
1069 op == Token::Kind::TK_LOGICALOR);
1070 if (!shortCircuitable) {
John Stiles2d4f9592020-10-30 10:29:12 -04001071 this->visitExpression(&binaryExpr.right());
John Stiles70957c82020-10-02 16:42:10 -04001072 }
1073 break;
1074 }
1075 case Expression::Kind::kConstructor: {
1076 Constructor& constructorExpr = (*expr)->as<Constructor>();
1077 for (std::unique_ptr<Expression>& arg : constructorExpr.arguments()) {
1078 this->visitExpression(&arg);
1079 }
1080 break;
1081 }
1082 case Expression::Kind::kExternalFunctionCall: {
1083 ExternalFunctionCall& funcCallExpr = (*expr)->as<ExternalFunctionCall>();
1084 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
1085 this->visitExpression(&arg);
1086 }
1087 break;
1088 }
1089 case Expression::Kind::kFunctionCall: {
1090 FunctionCall& funcCallExpr = (*expr)->as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -04001091 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
John Stiles70957c82020-10-02 16:42:10 -04001092 this->visitExpression(&arg);
1093 }
1094 this->addInlineCandidate(expr);
1095 break;
1096 }
1097 case Expression::Kind::kIndex:{
1098 IndexExpression& indexExpr = (*expr)->as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -04001099 this->visitExpression(&indexExpr.base());
1100 this->visitExpression(&indexExpr.index());
John Stiles70957c82020-10-02 16:42:10 -04001101 break;
1102 }
1103 case Expression::Kind::kPostfix: {
1104 PostfixExpression& postfixExpr = (*expr)->as<PostfixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -04001105 this->visitExpression(&postfixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001106 break;
1107 }
1108 case Expression::Kind::kPrefix: {
1109 PrefixExpression& prefixExpr = (*expr)->as<PrefixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -04001110 this->visitExpression(&prefixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001111 break;
1112 }
1113 case Expression::Kind::kSwizzle: {
1114 Swizzle& swizzleExpr = (*expr)->as<Swizzle>();
Ethan Nicholas6b4d5812020-10-12 16:11:51 -04001115 this->visitExpression(&swizzleExpr.base());
John Stiles70957c82020-10-02 16:42:10 -04001116 break;
1117 }
1118 case Expression::Kind::kTernary: {
1119 TernaryExpression& ternaryExpr = (*expr)->as<TernaryExpression>();
1120 // The test expression is a candidate for inlining.
Ethan Nicholasdd218162020-10-08 05:48:01 -04001121 this->visitExpression(&ternaryExpr.test());
John Stiles70957c82020-10-02 16:42:10 -04001122 // The true- and false-expressions cannot be inlined, because we are only allowed to
1123 // evaluate one side.
1124 break;
1125 }
1126 default:
1127 SkUNREACHABLE;
1128 }
1129 }
1130
1131 void addInlineCandidate(std::unique_ptr<Expression>* candidate) {
1132 fCandidateList->fCandidates.push_back(
1133 InlineCandidate{fSymbolTableStack.back(),
1134 find_parent_statement(fEnclosingStmtStack),
1135 fEnclosingStmtStack.back(),
1136 candidate,
John Stiles9b9415e2020-11-23 14:48:06 -05001137 fEnclosingFunction});
John Stiles70957c82020-10-02 16:42:10 -04001138 }
John Stiles2d7973a2020-10-02 15:01:03 -04001139};
John Stiles93442622020-09-11 12:11:27 -04001140
John Stiles9b9415e2020-11-23 14:48:06 -05001141static const FunctionDeclaration& candidate_func(const InlineCandidate& candidate) {
1142 return (*candidate.fCandidateExpr)->as<FunctionCall>().function();
1143}
John Stiles915a38c2020-09-14 09:38:13 -04001144
John Stiles9b9415e2020-11-23 14:48:06 -05001145bool Inliner::candidateCanBeInlined(const InlineCandidate& candidate, InlinabilityCache* cache) {
1146 const FunctionDeclaration& funcDecl = candidate_func(candidate);
John Stiles1c03d332020-10-13 10:30:23 -04001147 auto [iter, wasInserted] = cache->insert({&funcDecl, false});
John Stiles2d7973a2020-10-02 15:01:03 -04001148 if (wasInserted) {
1149 // Recursion is forbidden here to avoid an infinite death spiral of inlining.
John Stiles1c03d332020-10-13 10:30:23 -04001150 iter->second = this->isSafeToInline(funcDecl.definition()) &&
1151 !contains_recursive_call(funcDecl);
John Stiles93442622020-09-11 12:11:27 -04001152 }
1153
John Stiles2d7973a2020-10-02 15:01:03 -04001154 return iter->second;
1155}
1156
John Stiles9b9415e2020-11-23 14:48:06 -05001157int Inliner::getFunctionSize(const FunctionDeclaration& funcDecl, FunctionSizeCache* cache) {
1158 auto [iter, wasInserted] = cache->insert({&funcDecl, 0});
John Stiles2d7973a2020-10-02 15:01:03 -04001159 if (wasInserted) {
John Stiles9b9415e2020-11-23 14:48:06 -05001160 iter->second = Analysis::NodeCountUpToLimit(*funcDecl.definition(),
1161 fSettings->fInlineThreshold);
John Stiles2d7973a2020-10-02 15:01:03 -04001162 }
John Stiles2d7973a2020-10-02 15:01:03 -04001163 return iter->second;
1164}
1165
Brian Osman0006ad02020-11-18 15:38:39 -05001166void Inliner::buildCandidateList(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -05001167 std::shared_ptr<SymbolTable> symbols, ProgramUsage* usage,
Brian Osman0006ad02020-11-18 15:38:39 -05001168 InlineCandidateList* candidateList) {
John Stiles2d7973a2020-10-02 15:01:03 -04001169 // This is structured much like a ProgramVisitor, but does not actually use ProgramVisitor.
1170 // The analyzer needs to keep track of the `unique_ptr<T>*` of statements and expressions so
1171 // that they can later be replaced, and ProgramVisitor does not provide this; it only provides a
1172 // `const T&`.
1173 InlineCandidateAnalyzer analyzer;
Brian Osman0006ad02020-11-18 15:38:39 -05001174 analyzer.visit(elements, symbols, candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001175
John Stiles0ad233f2020-11-25 11:02:05 -05001176 // Early out if there are no inlining candidates.
John Stiles2d7973a2020-10-02 15:01:03 -04001177 std::vector<InlineCandidate>& candidates = candidateList->fCandidates;
John Stiles0ad233f2020-11-25 11:02:05 -05001178 if (candidates.empty()) {
1179 return;
1180 }
1181
1182 // Remove candidates that are not safe to inline.
John Stiles2d7973a2020-10-02 15:01:03 -04001183 InlinabilityCache cache;
1184 candidates.erase(std::remove_if(candidates.begin(),
1185 candidates.end(),
1186 [&](const InlineCandidate& candidate) {
1187 return !this->candidateCanBeInlined(candidate, &cache);
1188 }),
1189 candidates.end());
1190
John Stiles0ad233f2020-11-25 11:02:05 -05001191 // If the inline threshold is unlimited, or if we have no candidates left, our candidate list is
1192 // complete.
1193 if (fSettings->fInlineThreshold == INT_MAX || candidates.empty()) {
1194 return;
John Stiles2d7973a2020-10-02 15:01:03 -04001195 }
John Stiles0ad233f2020-11-25 11:02:05 -05001196
1197 // Remove candidates on a per-function basis if the effect of inlining would be to make more
1198 // than `inlineThreshold` nodes. (i.e. if Func() would be inlined six times and its size is
1199 // 10 nodes, it should be inlined if the inlineThreshold is 60 or higher.)
1200 FunctionSizeCache functionSizeCache;
1201 FunctionSizeCache candidateTotalCost;
1202 for (InlineCandidate& candidate : candidates) {
1203 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1204 candidateTotalCost[&fnDecl] += this->getFunctionSize(fnDecl, &functionSizeCache);
1205 }
1206
1207 candidates.erase(
1208 std::remove_if(candidates.begin(),
1209 candidates.end(),
1210 [&](const InlineCandidate& candidate) {
1211 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1212 if (fnDecl.modifiers().fFlags & Modifiers::kInline_Flag) {
1213 // Functions marked `inline` ignore size limitations.
1214 return false;
1215 }
1216 if (usage->get(fnDecl) == 1) {
1217 // If a function is only used once, it's cost-free to inline.
1218 return false;
1219 }
1220 if (candidateTotalCost[&fnDecl] <= fSettings->fInlineThreshold) {
1221 // We won't exceed the inline threshold by inlining this.
1222 return false;
1223 }
1224 // Inlining this function will add too many IRNodes.
1225 return true;
1226 }),
1227 candidates.end());
John Stiles2d7973a2020-10-02 15:01:03 -04001228}
1229
Brian Osman0006ad02020-11-18 15:38:39 -05001230bool Inliner::analyze(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -05001231 std::shared_ptr<SymbolTable> symbols,
Brian Osman0006ad02020-11-18 15:38:39 -05001232 ProgramUsage* usage) {
John Stilesd34d56e2020-10-12 12:04:47 -04001233 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
1234 if (fSettings->fInlineThreshold <= 0) {
1235 return false;
1236 }
1237
John Stiles031a7672020-11-13 16:13:18 -05001238 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
1239 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1240 return false;
1241 }
1242
John Stiles2d7973a2020-10-02 15:01:03 -04001243 InlineCandidateList candidateList;
John Stiles9b9415e2020-11-23 14:48:06 -05001244 this->buildCandidateList(elements, symbols, usage, &candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001245
John Stiles915a38c2020-09-14 09:38:13 -04001246 // Inline the candidates where we've determined that it's safe to do so.
1247 std::unordered_set<const std::unique_ptr<Statement>*> enclosingStmtSet;
1248 bool madeChanges = false;
John Stiles2d7973a2020-10-02 15:01:03 -04001249 for (const InlineCandidate& candidate : candidateList.fCandidates) {
John Stiles915a38c2020-09-14 09:38:13 -04001250 FunctionCall& funcCall = (*candidate.fCandidateExpr)->as<FunctionCall>();
John Stiles915a38c2020-09-14 09:38:13 -04001251
1252 // Inlining two expressions using the same enclosing statement in the same inlining pass
1253 // does not work properly. If this happens, skip it; we'll get it in the next pass.
1254 auto [unusedIter, inserted] = enclosingStmtSet.insert(candidate.fEnclosingStmt);
1255 if (!inserted) {
1256 continue;
1257 }
1258
1259 // Convert the function call to its inlined equivalent.
Brian Osman3887a012020-09-30 13:22:27 -04001260 InlinedCall inlinedCall = this->inlineCall(&funcCall, candidate.fSymbols,
Ethan Nicholas0a5d0962020-10-14 13:33:18 -04001261 &candidate.fEnclosingFunction->declaration());
John Stiles915a38c2020-09-14 09:38:13 -04001262 if (inlinedCall.fInlinedBody) {
1263 // Ensure that the inlined body has a scope if it needs one.
John Stiles6d696082020-10-01 10:18:54 -04001264 this->ensureScopedBlocks(inlinedCall.fInlinedBody.get(), candidate.fParentStmt->get());
John Stiles915a38c2020-09-14 09:38:13 -04001265
Brian Osman010ce6a2020-10-19 16:34:10 -04001266 // Add references within the inlined body
1267 usage->add(inlinedCall.fInlinedBody.get());
1268
John Stiles915a38c2020-09-14 09:38:13 -04001269 // Move the enclosing statement to the end of the unscoped Block containing the inlined
1270 // function, then replace the enclosing statement with that Block.
1271 // Before:
1272 // fInlinedBody = Block{ stmt1, stmt2, stmt3 }
1273 // fEnclosingStmt = stmt4
1274 // After:
1275 // fInlinedBody = null
1276 // fEnclosingStmt = Block{ stmt1, stmt2, stmt3, stmt4 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -04001277 inlinedCall.fInlinedBody->children().push_back(std::move(*candidate.fEnclosingStmt));
John Stiles915a38c2020-09-14 09:38:13 -04001278 *candidate.fEnclosingStmt = std::move(inlinedCall.fInlinedBody);
1279 }
1280
1281 // Replace the candidate function call with our replacement expression.
Brian Osman010ce6a2020-10-19 16:34:10 -04001282 usage->replace(candidate.fCandidateExpr->get(), inlinedCall.fReplacementExpr.get());
John Stiles915a38c2020-09-14 09:38:13 -04001283 *candidate.fCandidateExpr = std::move(inlinedCall.fReplacementExpr);
1284 madeChanges = true;
1285
John Stiles031a7672020-11-13 16:13:18 -05001286 // Stop inlining if we've reached our hard cap on new statements.
1287 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1288 break;
1289 }
1290
John Stiles915a38c2020-09-14 09:38:13 -04001291 // Note that nothing was destroyed except for the FunctionCall. All other nodes should
1292 // remain valid.
1293 }
1294
1295 return madeChanges;
John Stiles93442622020-09-11 12:11:27 -04001296}
1297
John Stiles44e96be2020-08-31 13:16:04 -04001298} // namespace SkSL