blob: 50b8268b994d77b464e6bed33a963b35bd5b1f7d [file] [log] [blame]
John Stiles44e96be2020-08-31 13:16:04 -04001/*
2 * Copyright 2020 Google LLC
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8#include "src/sksl/SkSLInliner.h"
9
John Stiles2d7973a2020-10-02 15:01:03 -040010#include <limits.h>
John Stiles44e96be2020-08-31 13:16:04 -040011#include <memory>
12#include <unordered_set>
13
14#include "src/sksl/SkSLAnalysis.h"
15#include "src/sksl/ir/SkSLBinaryExpression.h"
16#include "src/sksl/ir/SkSLBoolLiteral.h"
17#include "src/sksl/ir/SkSLBreakStatement.h"
18#include "src/sksl/ir/SkSLConstructor.h"
19#include "src/sksl/ir/SkSLContinueStatement.h"
20#include "src/sksl/ir/SkSLDiscardStatement.h"
21#include "src/sksl/ir/SkSLDoStatement.h"
22#include "src/sksl/ir/SkSLEnum.h"
23#include "src/sksl/ir/SkSLExpressionStatement.h"
24#include "src/sksl/ir/SkSLExternalFunctionCall.h"
Brian Osmanbe0b3b72021-01-06 14:27:35 -050025#include "src/sksl/ir/SkSLExternalFunctionReference.h"
John Stiles44e96be2020-08-31 13:16:04 -040026#include "src/sksl/ir/SkSLField.h"
27#include "src/sksl/ir/SkSLFieldAccess.h"
28#include "src/sksl/ir/SkSLFloatLiteral.h"
29#include "src/sksl/ir/SkSLForStatement.h"
30#include "src/sksl/ir/SkSLFunctionCall.h"
31#include "src/sksl/ir/SkSLFunctionDeclaration.h"
32#include "src/sksl/ir/SkSLFunctionDefinition.h"
33#include "src/sksl/ir/SkSLFunctionReference.h"
34#include "src/sksl/ir/SkSLIfStatement.h"
35#include "src/sksl/ir/SkSLIndexExpression.h"
John Stiles98c1f822020-09-09 14:18:53 -040036#include "src/sksl/ir/SkSLInlineMarker.h"
John Stiles44e96be2020-08-31 13:16:04 -040037#include "src/sksl/ir/SkSLIntLiteral.h"
38#include "src/sksl/ir/SkSLInterfaceBlock.h"
39#include "src/sksl/ir/SkSLLayout.h"
40#include "src/sksl/ir/SkSLNop.h"
John Stiles44e96be2020-08-31 13:16:04 -040041#include "src/sksl/ir/SkSLPostfixExpression.h"
42#include "src/sksl/ir/SkSLPrefixExpression.h"
43#include "src/sksl/ir/SkSLReturnStatement.h"
44#include "src/sksl/ir/SkSLSetting.h"
45#include "src/sksl/ir/SkSLSwitchCase.h"
46#include "src/sksl/ir/SkSLSwitchStatement.h"
47#include "src/sksl/ir/SkSLSwizzle.h"
48#include "src/sksl/ir/SkSLTernaryExpression.h"
49#include "src/sksl/ir/SkSLUnresolvedFunction.h"
50#include "src/sksl/ir/SkSLVarDeclarations.h"
John Stiles44e96be2020-08-31 13:16:04 -040051#include "src/sksl/ir/SkSLVariable.h"
52#include "src/sksl/ir/SkSLVariableReference.h"
John Stiles44e96be2020-08-31 13:16:04 -040053
54namespace SkSL {
55namespace {
56
John Stiles031a7672020-11-13 16:13:18 -050057static constexpr int kInlinedStatementLimit = 2500;
58
John Stiles44e96be2020-08-31 13:16:04 -040059static int count_returns_at_end_of_control_flow(const FunctionDefinition& funcDef) {
60 class CountReturnsAtEndOfControlFlow : public ProgramVisitor {
61 public:
62 CountReturnsAtEndOfControlFlow(const FunctionDefinition& funcDef) {
63 this->visitProgramElement(funcDef);
64 }
65
66 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -040067 switch (stmt.kind()) {
68 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -040069 // Check only the last statement of a block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -040070 const auto& block = stmt.as<Block>();
71 return block.children().size() &&
72 this->visitStatement(*block.children().back());
John Stiles44e96be2020-08-31 13:16:04 -040073 }
Ethan Nicholase6592142020-09-08 10:22:09 -040074 case Statement::Kind::kSwitch:
Ethan Nicholase6592142020-09-08 10:22:09 -040075 case Statement::Kind::kDo:
76 case Statement::Kind::kFor:
John Stiles44e96be2020-08-31 13:16:04 -040077 // Don't introspect switches or loop structures at all.
78 return false;
79
Ethan Nicholase6592142020-09-08 10:22:09 -040080 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -040081 ++fNumReturns;
82 [[fallthrough]];
83
84 default:
John Stiles93442622020-09-11 12:11:27 -040085 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -040086 }
87 }
88
89 int fNumReturns = 0;
90 using INHERITED = ProgramVisitor;
91 };
92
93 return CountReturnsAtEndOfControlFlow{funcDef}.fNumReturns;
94}
95
John Stiles74ebd7e2020-12-17 14:41:50 -050096static int count_returns_in_continuable_constructs(const FunctionDefinition& funcDef) {
97 class CountReturnsInContinuableConstructs : public ProgramVisitor {
John Stiles44e96be2020-08-31 13:16:04 -040098 public:
John Stiles74ebd7e2020-12-17 14:41:50 -050099 CountReturnsInContinuableConstructs(const FunctionDefinition& funcDef) {
John Stiles44e96be2020-08-31 13:16:04 -0400100 this->visitProgramElement(funcDef);
101 }
102
103 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -0400104 switch (stmt.kind()) {
Ethan Nicholase6592142020-09-08 10:22:09 -0400105 case Statement::Kind::kDo:
106 case Statement::Kind::kFor: {
John Stiles74ebd7e2020-12-17 14:41:50 -0500107 ++fInsideContinuableConstruct;
John Stiles93442622020-09-11 12:11:27 -0400108 bool result = INHERITED::visitStatement(stmt);
John Stiles74ebd7e2020-12-17 14:41:50 -0500109 --fInsideContinuableConstruct;
John Stiles44e96be2020-08-31 13:16:04 -0400110 return result;
111 }
112
Ethan Nicholase6592142020-09-08 10:22:09 -0400113 case Statement::Kind::kReturn:
John Stiles74ebd7e2020-12-17 14:41:50 -0500114 fNumReturns += (fInsideContinuableConstruct > 0) ? 1 : 0;
John Stiles44e96be2020-08-31 13:16:04 -0400115 [[fallthrough]];
116
117 default:
John Stiles93442622020-09-11 12:11:27 -0400118 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -0400119 }
120 }
121
122 int fNumReturns = 0;
John Stiles74ebd7e2020-12-17 14:41:50 -0500123 int fInsideContinuableConstruct = 0;
John Stiles44e96be2020-08-31 13:16:04 -0400124 using INHERITED = ProgramVisitor;
125 };
126
John Stiles74ebd7e2020-12-17 14:41:50 -0500127 return CountReturnsInContinuableConstructs{funcDef}.fNumReturns;
John Stiles44e96be2020-08-31 13:16:04 -0400128}
129
John Stiles991b09d2020-09-10 13:33:40 -0400130static bool contains_recursive_call(const FunctionDeclaration& funcDecl) {
131 class ContainsRecursiveCall : public ProgramVisitor {
132 public:
133 bool visit(const FunctionDeclaration& funcDecl) {
134 fFuncDecl = &funcDecl;
Ethan Nicholased84b732020-10-08 11:45:44 -0400135 return funcDecl.definition() ? this->visitProgramElement(*funcDecl.definition())
136 : false;
John Stiles991b09d2020-09-10 13:33:40 -0400137 }
138
139 bool visitExpression(const Expression& expr) override {
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400140 if (expr.is<FunctionCall>() && expr.as<FunctionCall>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400141 return true;
142 }
143 return INHERITED::visitExpression(expr);
144 }
145
146 bool visitStatement(const Statement& stmt) override {
Ethan Nicholasceb62142020-10-09 16:51:18 -0400147 if (stmt.is<InlineMarker>() &&
148 stmt.as<InlineMarker>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400149 return true;
150 }
151 return INHERITED::visitStatement(stmt);
152 }
153
154 const FunctionDeclaration* fFuncDecl;
155 using INHERITED = ProgramVisitor;
156 };
157
158 return ContainsRecursiveCall{}.visit(funcDecl);
159}
160
John Stiles6d696082020-10-01 10:18:54 -0400161static std::unique_ptr<Statement>* find_parent_statement(
162 const std::vector<std::unique_ptr<Statement>*>& stmtStack) {
John Stiles915a38c2020-09-14 09:38:13 -0400163 SkASSERT(!stmtStack.empty());
164
165 // Walk the statement stack from back to front, ignoring the last element (which is the
166 // enclosing statement).
167 auto iter = stmtStack.rbegin();
168 ++iter;
169
170 // Anything counts as a parent statement other than a scopeless Block.
171 for (; iter != stmtStack.rend(); ++iter) {
John Stiles6d696082020-10-01 10:18:54 -0400172 std::unique_ptr<Statement>* stmt = *iter;
173 if (!(*stmt)->is<Block>() || (*stmt)->as<Block>().isScope()) {
John Stiles915a38c2020-09-14 09:38:13 -0400174 return stmt;
175 }
176 }
177
178 // There wasn't any parent statement to be found.
179 return nullptr;
180}
181
John Stilese41b4ee2020-09-28 12:28:16 -0400182std::unique_ptr<Expression> clone_with_ref_kind(const Expression& expr,
183 VariableReference::RefKind refKind) {
184 std::unique_ptr<Expression> clone = expr.clone();
John Stiles47c0a742021-02-09 09:30:35 -0500185 Analysis::UpdateRefKind(clone.get(), refKind);
John Stilese41b4ee2020-09-28 12:28:16 -0400186 return clone;
187}
188
John Stiles77702f12020-12-17 14:38:56 -0500189class CountReturnsWithLimit : public ProgramVisitor {
190public:
191 CountReturnsWithLimit(const FunctionDefinition& funcDef, int limit) : fLimit(limit) {
192 this->visitProgramElement(funcDef);
193 }
194
195 bool visitStatement(const Statement& stmt) override {
196 switch (stmt.kind()) {
197 case Statement::Kind::kReturn: {
198 ++fNumReturns;
199 fDeepestReturn = std::max(fDeepestReturn, fScopedBlockDepth);
200 return (fNumReturns >= fLimit) || INHERITED::visitStatement(stmt);
201 }
John Stilesc5ff4862020-12-22 13:47:05 -0500202 case Statement::Kind::kVarDeclaration: {
203 if (fScopedBlockDepth > 1) {
204 fVariablesInBlocks = true;
205 }
206 return INHERITED::visitStatement(stmt);
207 }
John Stiles77702f12020-12-17 14:38:56 -0500208 case Statement::Kind::kBlock: {
209 int depthIncrement = stmt.as<Block>().isScope() ? 1 : 0;
210 fScopedBlockDepth += depthIncrement;
211 bool result = INHERITED::visitStatement(stmt);
212 fScopedBlockDepth -= depthIncrement;
John Stilesc5ff4862020-12-22 13:47:05 -0500213 if (fNumReturns == 0 && fScopedBlockDepth <= 1) {
214 // If closing this block puts us back at the top level, and we haven't
215 // encountered any return statements yet, any vardecls we may have encountered
216 // up until this point can be ignored. They are out of scope now, and they were
217 // never used in a return statement.
218 fVariablesInBlocks = false;
219 }
John Stiles77702f12020-12-17 14:38:56 -0500220 return result;
221 }
222 default:
223 return INHERITED::visitStatement(stmt);
224 }
225 }
226
227 int fNumReturns = 0;
228 int fDeepestReturn = 0;
229 int fLimit = 0;
230 int fScopedBlockDepth = 0;
John Stilesc5ff4862020-12-22 13:47:05 -0500231 bool fVariablesInBlocks = false;
John Stiles77702f12020-12-17 14:38:56 -0500232 using INHERITED = ProgramVisitor;
233};
234
John Stiles44e96be2020-08-31 13:16:04 -0400235} // namespace
236
John Stiles77702f12020-12-17 14:38:56 -0500237Inliner::ReturnComplexity Inliner::GetReturnComplexity(const FunctionDefinition& funcDef) {
238 int returnsAtEndOfControlFlow = count_returns_at_end_of_control_flow(funcDef);
239 CountReturnsWithLimit counter{funcDef, returnsAtEndOfControlFlow + 1};
John Stiles77702f12020-12-17 14:38:56 -0500240 if (counter.fNumReturns > returnsAtEndOfControlFlow) {
241 return ReturnComplexity::kEarlyReturns;
242 }
John Stilesc5ff4862020-12-22 13:47:05 -0500243 if (counter.fNumReturns > 1) {
John Stiles77702f12020-12-17 14:38:56 -0500244 return ReturnComplexity::kScopedReturns;
245 }
John Stilesc5ff4862020-12-22 13:47:05 -0500246 if (counter.fVariablesInBlocks && counter.fDeepestReturn > 1) {
247 return ReturnComplexity::kScopedReturns;
248 }
249 return ReturnComplexity::kSingleSafeReturn;
John Stiles77702f12020-12-17 14:38:56 -0500250}
251
John Stilesb61ee902020-09-21 12:26:59 -0400252void Inliner::ensureScopedBlocks(Statement* inlinedBody, Statement* parentStmt) {
253 // No changes necessary if this statement isn't actually a block.
254 if (!inlinedBody || !inlinedBody->is<Block>()) {
255 return;
256 }
257
258 // No changes necessary if the parent statement doesn't require a scope.
259 if (!parentStmt || !(parentStmt->is<IfStatement>() || parentStmt->is<ForStatement>() ||
Brian Osmand6f23382020-12-15 17:08:59 -0500260 parentStmt->is<DoStatement>())) {
John Stilesb61ee902020-09-21 12:26:59 -0400261 return;
262 }
263
264 Block& block = inlinedBody->as<Block>();
265
266 // The inliner will create inlined function bodies as a Block containing multiple statements,
267 // but no scope. Normally, this is fine, but if this block is used as the statement for a
268 // do/for/if/while, this isn't actually possible to represent textually; a scope must be added
269 // for the generated code to match the intent. In the case of Blocks nested inside other Blocks,
270 // we add the scope to the outermost block if needed. Zero-statement blocks have similar
271 // issues--if we don't represent the Block textually somehow, we run the risk of accidentally
272 // absorbing the following statement into our loop--so we also add a scope to these.
273 for (Block* nestedBlock = &block;; ) {
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400274 if (nestedBlock->isScope()) {
John Stilesb61ee902020-09-21 12:26:59 -0400275 // We found an explicit scope; all is well.
276 return;
277 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400278 if (nestedBlock->children().size() != 1) {
John Stilesb61ee902020-09-21 12:26:59 -0400279 // We found a block with multiple (or zero) statements, but no scope? Let's add a scope
280 // to the outermost block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400281 block.setIsScope(true);
John Stilesb61ee902020-09-21 12:26:59 -0400282 return;
283 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400284 if (!nestedBlock->children()[0]->is<Block>()) {
John Stilesb61ee902020-09-21 12:26:59 -0400285 // This block has exactly one thing inside, and it's not another block. No need to scope
286 // it.
287 return;
288 }
289 // We have to go deeper.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400290 nestedBlock = &nestedBlock->children()[0]->as<Block>();
John Stilesb61ee902020-09-21 12:26:59 -0400291 }
292}
293
Brian Osman0006ad02020-11-18 15:38:39 -0500294void Inliner::reset(ModifiersPool* modifiers, const Program::Settings* settings) {
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400295 fModifiers = modifiers;
296 fSettings = settings;
Ethan Nicholas6f4eee22021-01-11 12:37:42 -0500297 fMangler.reset();
John Stiles031a7672020-11-13 16:13:18 -0500298 fInlinedStatementCounter = 0;
John Stiles44e96be2020-08-31 13:16:04 -0400299}
300
301std::unique_ptr<Expression> Inliner::inlineExpression(int offset,
302 VariableRewriteMap* varMap,
John Stilesd7cc0932020-11-30 12:24:27 -0500303 SymbolTable* symbolTableForExpression,
John Stiles44e96be2020-08-31 13:16:04 -0400304 const Expression& expression) {
305 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
306 if (e) {
John Stilesd7cc0932020-11-30 12:24:27 -0500307 return this->inlineExpression(offset, varMap, symbolTableForExpression, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400308 }
309 return nullptr;
310 };
John Stiles8e3b6be2020-10-13 11:14:08 -0400311 auto argList = [&](const ExpressionArray& originalArgs) -> ExpressionArray {
312 ExpressionArray args;
John Stilesf4bda742020-10-14 16:57:41 -0400313 args.reserve_back(originalArgs.size());
John Stiles44e96be2020-08-31 13:16:04 -0400314 for (const std::unique_ptr<Expression>& arg : originalArgs) {
315 args.push_back(expr(arg));
316 }
317 return args;
318 };
319
Ethan Nicholase6592142020-09-08 10:22:09 -0400320 switch (expression.kind()) {
321 case Expression::Kind::kBinary: {
John Stiles6a1a98c2021-01-14 18:35:34 -0500322 const BinaryExpression& binaryExpr = expression.as<BinaryExpression>();
John Stilesddcc8432021-01-15 15:32:32 -0500323 return std::make_unique<BinaryExpression>(
324 offset,
325 expr(binaryExpr.left()),
326 binaryExpr.getOperator(),
327 expr(binaryExpr.right()),
328 binaryExpr.type().clone(symbolTableForExpression));
John Stiles44e96be2020-08-31 13:16:04 -0400329 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400330 case Expression::Kind::kBoolLiteral:
331 case Expression::Kind::kIntLiteral:
332 case Expression::Kind::kFloatLiteral:
John Stiles44e96be2020-08-31 13:16:04 -0400333 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400334 case Expression::Kind::kConstructor: {
John Stiles44e96be2020-08-31 13:16:04 -0400335 const Constructor& constructor = expression.as<Constructor>();
John Stilesddcc8432021-01-15 15:32:32 -0500336 return std::make_unique<Constructor>(offset,
337 constructor.type().clone(symbolTableForExpression),
338 argList(constructor.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400339 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400340 case Expression::Kind::kExternalFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400341 const ExternalFunctionCall& externalCall = expression.as<ExternalFunctionCall>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400342 return std::make_unique<ExternalFunctionCall>(offset, &externalCall.function(),
Ethan Nicholas6e86ec92020-09-30 14:29:56 -0400343 argList(externalCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400344 }
Brian Osmanbe0b3b72021-01-06 14:27:35 -0500345 case Expression::Kind::kExternalFunctionReference:
John Stiles44e96be2020-08-31 13:16:04 -0400346 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400347 case Expression::Kind::kFieldAccess: {
John Stiles44e96be2020-08-31 13:16:04 -0400348 const FieldAccess& f = expression.as<FieldAccess>();
Ethan Nicholas7a95b202020-10-09 11:55:40 -0400349 return std::make_unique<FieldAccess>(expr(f.base()), f.fieldIndex(), f.ownerKind());
John Stiles44e96be2020-08-31 13:16:04 -0400350 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400351 case Expression::Kind::kFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400352 const FunctionCall& funcCall = expression.as<FunctionCall>();
John Stilesddcc8432021-01-15 15:32:32 -0500353 return std::make_unique<FunctionCall>(offset,
354 funcCall.type().clone(symbolTableForExpression),
355 &funcCall.function(),
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400356 argList(funcCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400357 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400358 case Expression::Kind::kFunctionReference:
Brian Osman2b3b35f2020-09-08 09:17:36 -0400359 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400360 case Expression::Kind::kIndex: {
John Stiles44e96be2020-08-31 13:16:04 -0400361 const IndexExpression& idx = expression.as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400362 return std::make_unique<IndexExpression>(*fContext, expr(idx.base()),
363 expr(idx.index()));
John Stiles44e96be2020-08-31 13:16:04 -0400364 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400365 case Expression::Kind::kPrefix: {
John Stiles44e96be2020-08-31 13:16:04 -0400366 const PrefixExpression& p = expression.as<PrefixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400367 return std::make_unique<PrefixExpression>(p.getOperator(), expr(p.operand()));
John Stiles44e96be2020-08-31 13:16:04 -0400368 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400369 case Expression::Kind::kPostfix: {
John Stiles44e96be2020-08-31 13:16:04 -0400370 const PostfixExpression& p = expression.as<PostfixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -0400371 return std::make_unique<PostfixExpression>(expr(p.operand()), p.getOperator());
John Stiles44e96be2020-08-31 13:16:04 -0400372 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400373 case Expression::Kind::kSetting:
John Stiles44e96be2020-08-31 13:16:04 -0400374 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400375 case Expression::Kind::kSwizzle: {
John Stiles44e96be2020-08-31 13:16:04 -0400376 const Swizzle& s = expression.as<Swizzle>();
Ethan Nicholas6b4d5812020-10-12 16:11:51 -0400377 return std::make_unique<Swizzle>(*fContext, expr(s.base()), s.components());
John Stiles44e96be2020-08-31 13:16:04 -0400378 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400379 case Expression::Kind::kTernary: {
John Stiles44e96be2020-08-31 13:16:04 -0400380 const TernaryExpression& t = expression.as<TernaryExpression>();
Ethan Nicholasdd218162020-10-08 05:48:01 -0400381 return std::make_unique<TernaryExpression>(offset, expr(t.test()),
382 expr(t.ifTrue()), expr(t.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400383 }
Brian Osman83ba9302020-09-11 13:33:46 -0400384 case Expression::Kind::kTypeReference:
385 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400386 case Expression::Kind::kVariableReference: {
John Stiles44e96be2020-08-31 13:16:04 -0400387 const VariableReference& v = expression.as<VariableReference>();
Ethan Nicholas78686922020-10-08 06:46:27 -0400388 auto varMapIter = varMap->find(v.variable());
John Stilese41b4ee2020-09-28 12:28:16 -0400389 if (varMapIter != varMap->end()) {
Ethan Nicholas78686922020-10-08 06:46:27 -0400390 return clone_with_ref_kind(*varMapIter->second, v.refKind());
John Stiles44e96be2020-08-31 13:16:04 -0400391 }
392 return v.clone();
393 }
394 default:
395 SkASSERT(false);
396 return nullptr;
397 }
398}
399
400std::unique_ptr<Statement> Inliner::inlineStatement(int offset,
401 VariableRewriteMap* varMap,
402 SymbolTable* symbolTableForStatement,
John Stiles77702f12020-12-17 14:38:56 -0500403 std::unique_ptr<Expression>* resultExpr,
404 ReturnComplexity returnComplexity,
Brian Osman3887a012020-09-30 13:22:27 -0400405 const Statement& statement,
406 bool isBuiltinCode) {
John Stiles44e96be2020-08-31 13:16:04 -0400407 auto stmt = [&](const std::unique_ptr<Statement>& s) -> std::unique_ptr<Statement> {
408 if (s) {
John Stilesa5f3c312020-09-22 12:05:16 -0400409 return this->inlineStatement(offset, varMap, symbolTableForStatement, resultExpr,
John Stiles77702f12020-12-17 14:38:56 -0500410 returnComplexity, *s, isBuiltinCode);
John Stiles44e96be2020-08-31 13:16:04 -0400411 }
412 return nullptr;
413 };
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400414 auto blockStmts = [&](const Block& block) {
John Stiles8f2a0cf2020-10-13 12:48:21 -0400415 StatementArray result;
John Stilesf4bda742020-10-14 16:57:41 -0400416 result.reserve_back(block.children().size());
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400417 for (const std::unique_ptr<Statement>& child : block.children()) {
418 result.push_back(stmt(child));
419 }
420 return result;
421 };
John Stiles8f2a0cf2020-10-13 12:48:21 -0400422 auto stmts = [&](const StatementArray& ss) {
423 StatementArray result;
John Stilesf4bda742020-10-14 16:57:41 -0400424 result.reserve_back(ss.size());
John Stiles44e96be2020-08-31 13:16:04 -0400425 for (const auto& s : ss) {
426 result.push_back(stmt(s));
427 }
428 return result;
429 };
430 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
431 if (e) {
John Stilesd7cc0932020-11-30 12:24:27 -0500432 return this->inlineExpression(offset, varMap, symbolTableForStatement, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400433 }
434 return nullptr;
435 };
John Stiles031a7672020-11-13 16:13:18 -0500436
437 ++fInlinedStatementCounter;
438
Ethan Nicholase6592142020-09-08 10:22:09 -0400439 switch (statement.kind()) {
440 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -0400441 const Block& b = statement.as<Block>();
John Stilesa1e2b412020-10-20 14:51:28 -0400442 return std::make_unique<Block>(offset, blockStmts(b),
443 SymbolTable::WrapIfBuiltin(b.symbolTable()),
444 b.isScope());
John Stiles44e96be2020-08-31 13:16:04 -0400445 }
446
Ethan Nicholase6592142020-09-08 10:22:09 -0400447 case Statement::Kind::kBreak:
448 case Statement::Kind::kContinue:
449 case Statement::Kind::kDiscard:
John Stiles44e96be2020-08-31 13:16:04 -0400450 return statement.clone();
451
Ethan Nicholase6592142020-09-08 10:22:09 -0400452 case Statement::Kind::kDo: {
John Stiles44e96be2020-08-31 13:16:04 -0400453 const DoStatement& d = statement.as<DoStatement>();
Ethan Nicholas1fd61162020-09-28 13:14:19 -0400454 return std::make_unique<DoStatement>(offset, stmt(d.statement()), expr(d.test()));
John Stiles44e96be2020-08-31 13:16:04 -0400455 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400456 case Statement::Kind::kExpression: {
John Stiles44e96be2020-08-31 13:16:04 -0400457 const ExpressionStatement& e = statement.as<ExpressionStatement>();
Ethan Nicholasd503a5a2020-09-30 09:29:55 -0400458 return std::make_unique<ExpressionStatement>(expr(e.expression()));
John Stiles44e96be2020-08-31 13:16:04 -0400459 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400460 case Statement::Kind::kFor: {
John Stiles44e96be2020-08-31 13:16:04 -0400461 const ForStatement& f = statement.as<ForStatement>();
462 // need to ensure initializer is evaluated first so that we've already remapped its
463 // declarations by the time we evaluate test & next
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400464 std::unique_ptr<Statement> initializer = stmt(f.initializer());
465 return std::make_unique<ForStatement>(offset, std::move(initializer), expr(f.test()),
John Stilesa1e2b412020-10-20 14:51:28 -0400466 expr(f.next()), stmt(f.statement()),
467 SymbolTable::WrapIfBuiltin(f.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400468 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400469 case Statement::Kind::kIf: {
John Stiles44e96be2020-08-31 13:16:04 -0400470 const IfStatement& i = statement.as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400471 return std::make_unique<IfStatement>(offset, i.isStatic(), expr(i.test()),
472 stmt(i.ifTrue()), stmt(i.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400473 }
John Stiles98c1f822020-09-09 14:18:53 -0400474 case Statement::Kind::kInlineMarker:
Ethan Nicholase6592142020-09-08 10:22:09 -0400475 case Statement::Kind::kNop:
John Stiles44e96be2020-08-31 13:16:04 -0400476 return statement.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400477 case Statement::Kind::kReturn: {
John Stiles44e96be2020-08-31 13:16:04 -0400478 const ReturnStatement& r = statement.as<ReturnStatement>();
John Stiles77702f12020-12-17 14:38:56 -0500479 if (!r.expression()) {
480 if (returnComplexity >= ReturnComplexity::kEarlyReturns) {
481 // This function doesn't return a value, but has early returns, so we've wrapped
482 // it in a for loop. Use a continue to jump to the end of the loop and "leave"
483 // the function.
John Stiles7b920442020-12-17 10:43:41 -0500484 return std::make_unique<ContinueStatement>(offset);
John Stiles44e96be2020-08-31 13:16:04 -0400485 } else {
John Stiles77702f12020-12-17 14:38:56 -0500486 // This function doesn't exit early or return a value. A return statement at the
487 // end is a no-op and can be treated as such.
John Stiles44e96be2020-08-31 13:16:04 -0400488 return std::make_unique<Nop>();
489 }
490 }
John Stiles77702f12020-12-17 14:38:56 -0500491
John Stilesc5ff4862020-12-22 13:47:05 -0500492 // If a function only contains a single return, and it doesn't reference variables from
493 // inside an Block's scope, we don't need to store the result in a variable at all. Just
494 // replace the function-call expression with the function's return expression.
John Stiles77702f12020-12-17 14:38:56 -0500495 SkASSERT(resultExpr);
496 SkASSERT(*resultExpr);
John Stilesc5ff4862020-12-22 13:47:05 -0500497 if (returnComplexity <= ReturnComplexity::kSingleSafeReturn) {
John Stiles77702f12020-12-17 14:38:56 -0500498 *resultExpr = expr(r.expression());
499 return std::make_unique<Nop>();
500 }
501
502 // For more complex functions, assign their result into a variable.
503 auto assignment =
504 std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
505 offset,
506 clone_with_ref_kind(**resultExpr, VariableReference::RefKind::kWrite),
507 Token::Kind::TK_EQ,
508 expr(r.expression()),
John Stilesddcc8432021-01-15 15:32:32 -0500509 (*resultExpr)->type().clone(symbolTableForStatement)));
John Stiles77702f12020-12-17 14:38:56 -0500510
511 // Early returns are wrapped in a for loop; we need to synthesize a continue statement
512 // to "leave" the function.
513 if (returnComplexity >= ReturnComplexity::kEarlyReturns) {
514 StatementArray block;
515 block.reserve_back(2);
516 block.push_back(std::move(assignment));
517 block.push_back(std::make_unique<ContinueStatement>(offset));
518 return std::make_unique<Block>(offset, std::move(block), /*symbols=*/nullptr,
519 /*isScope=*/true);
520 }
521 // Functions without early returns aren't wrapped in a for loop and don't need to worry
522 // about breaking out of the control flow.
523 return std::move(assignment);
524
John Stiles44e96be2020-08-31 13:16:04 -0400525 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400526 case Statement::Kind::kSwitch: {
John Stiles44e96be2020-08-31 13:16:04 -0400527 const SwitchStatement& ss = statement.as<SwitchStatement>();
528 std::vector<std::unique_ptr<SwitchCase>> cases;
John Stiles2d4f9592020-10-30 10:29:12 -0400529 cases.reserve(ss.cases().size());
530 for (const std::unique_ptr<SwitchCase>& sc : ss.cases()) {
531 cases.push_back(std::make_unique<SwitchCase>(offset, expr(sc->value()),
532 stmts(sc->statements())));
John Stiles44e96be2020-08-31 13:16:04 -0400533 }
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400534 return std::make_unique<SwitchStatement>(offset, ss.isStatic(), expr(ss.value()),
John Stilesa1e2b412020-10-20 14:51:28 -0400535 std::move(cases),
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400536 SymbolTable::WrapIfBuiltin(ss.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400537 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400538 case Statement::Kind::kVarDeclaration: {
John Stiles44e96be2020-08-31 13:16:04 -0400539 const VarDeclaration& decl = statement.as<VarDeclaration>();
John Stiles35fee4c2020-12-16 18:25:14 +0000540 std::unique_ptr<Expression> initialValue = expr(decl.value());
John Stilesddcc8432021-01-15 15:32:32 -0500541 const Variable& variable = decl.var();
542
John Stiles35fee4c2020-12-16 18:25:14 +0000543 // We assign unique names to inlined variables--scopes hide most of the problems in this
544 // regard, but see `InlinerAvoidsVariableNameOverlap` for a counterexample where unique
545 // names are important.
John Stilesddcc8432021-01-15 15:32:32 -0500546 auto name = std::make_unique<String>(fMangler.uniqueName(variable.name(),
Ethan Nicholas6f4eee22021-01-11 12:37:42 -0500547 symbolTableForStatement));
John Stiles35fee4c2020-12-16 18:25:14 +0000548 const String* namePtr = symbolTableForStatement->takeOwnershipOfString(std::move(name));
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500549 auto clonedVar = std::make_unique<Variable>(
550 offset,
551 &variable.modifiers(),
552 namePtr->c_str(),
553 variable.type().clone(symbolTableForStatement),
554 isBuiltinCode,
555 variable.storage());
556 (*varMap)[&variable] = std::make_unique<VariableReference>(offset, clonedVar.get());
557 auto result = std::make_unique<VarDeclaration>(clonedVar.get(),
John Stilesddcc8432021-01-15 15:32:32 -0500558 decl.baseType().clone(symbolTableForStatement),
559 decl.arraySize(),
John Stiles35fee4c2020-12-16 18:25:14 +0000560 std::move(initialValue));
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500561 clonedVar->setDeclaration(result.get());
562 symbolTableForStatement->takeOwnershipOfSymbol(std::move(clonedVar));
563 return std::move(result);
John Stiles44e96be2020-08-31 13:16:04 -0400564 }
John Stiles44e96be2020-08-31 13:16:04 -0400565 default:
566 SkASSERT(false);
567 return nullptr;
568 }
569}
570
John Stiles7b920442020-12-17 10:43:41 -0500571Inliner::InlineVariable Inliner::makeInlineVariable(const String& baseName,
572 const Type* type,
573 SymbolTable* symbolTable,
574 Modifiers modifiers,
575 bool isBuiltinCode,
576 std::unique_ptr<Expression>* initialValue) {
577 // $floatLiteral or $intLiteral aren't real types that we can use for scratch variables, so
578 // replace them if they ever appear here. If this happens, we likely forgot to coerce a type
579 // somewhere during compilation.
John Stiles14975272021-01-12 11:41:14 -0500580 if (type->isLiteral()) {
581 SkDEBUGFAIL("found a $literal type while inlining");
582 type = &type->scalarTypeForLiteral();
John Stiles7b920442020-12-17 10:43:41 -0500583 }
584
585 // Provide our new variable with a unique name, and add it to our symbol table.
586 const String* namePtr = symbolTable->takeOwnershipOfString(
Ethan Nicholas6f4eee22021-01-11 12:37:42 -0500587 std::make_unique<String>(fMangler.uniqueName(baseName, symbolTable)));
John Stiles7b920442020-12-17 10:43:41 -0500588 StringFragment nameFrag{namePtr->c_str(), namePtr->length()};
589
590 // Create our new variable and add it to the symbol table.
591 InlineVariable result;
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500592 auto var = std::make_unique<Variable>(/*offset=*/-1,
593 fModifiers->addToPool(Modifiers()),
594 nameFrag,
595 type,
596 isBuiltinCode,
597 Variable::Storage::kLocal);
John Stiles7b920442020-12-17 10:43:41 -0500598
599 // Prepare the variable declaration (taking extra care with `out` params to not clobber any
600 // initial value).
601 if (*initialValue && (modifiers.fFlags & Modifiers::kOut_Flag)) {
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500602 result.fVarDecl = std::make_unique<VarDeclaration>(var.get(), type, /*arraySize=*/0,
John Stiles7b920442020-12-17 10:43:41 -0500603 (*initialValue)->clone());
604 } else {
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500605 result.fVarDecl = std::make_unique<VarDeclaration>(var.get(), type, /*arraySize=*/0,
John Stiles7b920442020-12-17 10:43:41 -0500606 std::move(*initialValue));
607 }
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500608 var->setDeclaration(&result.fVarDecl->as<VarDeclaration>());
609 result.fVarSymbol = symbolTable->add(std::move(var));
John Stiles7b920442020-12-17 10:43:41 -0500610 return result;
611}
612
John Stiles6eadf132020-09-08 10:16:10 -0400613Inliner::InlinedCall Inliner::inlineCall(FunctionCall* call,
John Stiles78047582020-12-16 16:17:41 -0500614 std::shared_ptr<SymbolTable> symbolTable,
Brian Osman3887a012020-09-30 13:22:27 -0400615 const FunctionDeclaration* caller) {
John Stiles44e96be2020-08-31 13:16:04 -0400616 // Inlining is more complicated here than in a typical compiler, because we have to have a
617 // high-level IR and can't just drop statements into the middle of an expression or even use
618 // gotos.
619 //
620 // Since we can't insert statements into an expression, we run the inline function as extra
621 // statements before the statement we're currently processing, relying on a lack of execution
622 // order guarantees. Since we can't use gotos (which are normally used to replace return
623 // statements), we wrap the whole function in a loop and use break statements to jump to the
624 // end.
625 SkASSERT(fSettings);
626 SkASSERT(fContext);
627 SkASSERT(call);
Ethan Nicholased84b732020-10-08 11:45:44 -0400628 SkASSERT(this->isSafeToInline(call->function().definition()));
John Stiles44e96be2020-08-31 13:16:04 -0400629
John Stiles8e3b6be2020-10-13 11:14:08 -0400630 ExpressionArray& arguments = call->arguments();
John Stiles6eadf132020-09-08 10:16:10 -0400631 const int offset = call->fOffset;
Ethan Nicholased84b732020-10-08 11:45:44 -0400632 const FunctionDefinition& function = *call->function().definition();
John Stiles77702f12020-12-17 14:38:56 -0500633 const ReturnComplexity returnComplexity = GetReturnComplexity(function);
634 bool hasEarlyReturn = (returnComplexity >= ReturnComplexity::kEarlyReturns);
John Stiles6eadf132020-09-08 10:16:10 -0400635
John Stiles44e96be2020-08-31 13:16:04 -0400636 InlinedCall inlinedCall;
John Stiles8f2a0cf2020-10-13 12:48:21 -0400637 inlinedCall.fInlinedBody = std::make_unique<Block>(offset, StatementArray{},
John Stiles6eadf132020-09-08 10:16:10 -0400638 /*symbols=*/nullptr,
639 /*isScope=*/false);
John Stiles98c1f822020-09-09 14:18:53 -0400640
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400641 Block& inlinedBody = *inlinedCall.fInlinedBody;
John Stiles82f373c2020-10-20 13:58:05 -0400642 inlinedBody.children().reserve_back(
643 1 + // Inline marker
644 1 + // Result variable
645 arguments.size() + // Function arguments (passing in)
646 arguments.size() + // Function arguments (copy out-params back)
John Stiles7b920442020-12-17 10:43:41 -0500647 1); // Block for inlined code
John Stiles98c1f822020-09-09 14:18:53 -0400648
Ethan Nicholasceb62142020-10-09 16:51:18 -0400649 inlinedBody.children().push_back(std::make_unique<InlineMarker>(&call->function()));
John Stiles44e96be2020-08-31 13:16:04 -0400650
John Stiles44e96be2020-08-31 13:16:04 -0400651 // Create a variable to hold the result in the extra statements (excepting void).
John Stilese41b4ee2020-09-28 12:28:16 -0400652 std::unique_ptr<Expression> resultExpr;
John Stiles54e7c052021-01-11 14:22:36 -0500653 if (function.declaration().returnType() != *fContext->fTypes.fVoid) {
John Stiles44e96be2020-08-31 13:16:04 -0400654 std::unique_ptr<Expression> noInitialValue;
John Stiles7b920442020-12-17 10:43:41 -0500655 InlineVariable var = this->makeInlineVariable(function.declaration().name(),
656 &function.declaration().returnType(),
657 symbolTable.get(), Modifiers{},
658 caller->isBuiltin(), &noInitialValue);
659 inlinedBody.children().push_back(std::move(var.fVarDecl));
660 resultExpr = std::make_unique<VariableReference>(/*offset=*/-1, var.fVarSymbol);
John Stiles35fee4c2020-12-16 18:25:14 +0000661 }
John Stiles44e96be2020-08-31 13:16:04 -0400662
663 // Create variables in the extra statements to hold the arguments, and assign the arguments to
664 // them.
665 VariableRewriteMap varMap;
John Stilese41b4ee2020-09-28 12:28:16 -0400666 std::vector<int> argsToCopyBack;
John Stiles44e96be2020-08-31 13:16:04 -0400667 for (int i = 0; i < (int) arguments.size(); ++i) {
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400668 const Variable* param = function.declaration().parameters()[i];
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400669 bool isOutParam = param->modifiers().fFlags & Modifiers::kOut_Flag;
John Stiles44e96be2020-08-31 13:16:04 -0400670
John Stiles44733aa2020-09-29 17:42:23 -0400671 // If this argument can be inlined trivially (e.g. a swizzle, or a constant array index)...
John Stilesc30fbca2020-11-19 16:25:49 -0500672 if (Analysis::IsTrivialExpression(*arguments[i])) {
John Stilese41b4ee2020-09-28 12:28:16 -0400673 // ... and it's an `out` param, or it isn't written to within the inline function...
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400674 if (isOutParam || !Analysis::StatementWritesToVariable(*function.body(), *param)) {
John Stilesf201af82020-09-29 16:57:55 -0400675 // ... we don't need to copy it at all! We can just use the existing expression.
676 varMap[param] = arguments[i]->clone();
John Stiles44e96be2020-08-31 13:16:04 -0400677 continue;
678 }
679 }
John Stilese41b4ee2020-09-28 12:28:16 -0400680 if (isOutParam) {
681 argsToCopyBack.push_back(i);
682 }
John Stiles7b920442020-12-17 10:43:41 -0500683 InlineVariable var = this->makeInlineVariable(param->name(), &arguments[i]->type(),
684 symbolTable.get(), param->modifiers(),
685 caller->isBuiltin(), &arguments[i]);
686 inlinedBody.children().push_back(std::move(var.fVarDecl));
687 varMap[param] = std::make_unique<VariableReference>(/*offset=*/-1, var.fVarSymbol);
John Stiles44e96be2020-08-31 13:16:04 -0400688 }
689
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400690 const Block& body = function.body()->as<Block>();
John Stiles7b920442020-12-17 10:43:41 -0500691 StatementArray* inlineStatements;
692
John Stiles44e96be2020-08-31 13:16:04 -0400693 if (hasEarlyReturn) {
694 // Since we output to backends that don't have a goto statement (which would normally be
John Stiles7b920442020-12-17 10:43:41 -0500695 // used to perform an early return), we fake it by wrapping the function in a single-
696 // iteration for loop, and use a continue statement to jump to the end of the loop
697 // prematurely.
698
699 // int _1_loop = 0;
700 symbolTable = std::make_shared<SymbolTable>(std::move(symbolTable), caller->isBuiltin());
John Stiles54e7c052021-01-11 14:22:36 -0500701 const Type* intType = fContext->fTypes.fInt.get();
John Stiles7b920442020-12-17 10:43:41 -0500702 std::unique_ptr<Expression> initialValue = std::make_unique<IntLiteral>(/*offset=*/-1,
703 /*value=*/0,
704 intType);
705 InlineVariable loopVar = this->makeInlineVariable("loop", intType, symbolTable.get(),
706 Modifiers{}, caller->isBuiltin(),
707 &initialValue);
708
709 // _1_loop < 1;
710 std::unique_ptr<Expression> test = std::make_unique<BinaryExpression>(
John Stiles44e96be2020-08-31 13:16:04 -0400711 /*offset=*/-1,
John Stiles7b920442020-12-17 10:43:41 -0500712 std::make_unique<VariableReference>(/*offset=*/-1, loopVar.fVarSymbol),
713 Token::Kind::TK_LT,
714 std::make_unique<IntLiteral>(/*offset=*/-1, /*value=*/1, intType),
John Stiles54e7c052021-01-11 14:22:36 -0500715 fContext->fTypes.fBool.get());
John Stiles7b920442020-12-17 10:43:41 -0500716
717 // _1_loop++
718 std::unique_ptr<Expression> increment = std::make_unique<PostfixExpression>(
719 std::make_unique<VariableReference>(/*offset=*/-1, loopVar.fVarSymbol,
720 VariableReference::RefKind::kReadWrite),
721 Token::Kind::TK_PLUSPLUS);
722
723 // {...}
724 auto innerBlock = std::make_unique<Block>(offset, StatementArray{},
725 /*symbols=*/nullptr, /*isScope=*/true);
726 inlineStatements = &innerBlock->children();
727
728 // for (int _1_loop = 0; _1_loop < 1; _1_loop++) {...}
729 inlinedBody.children().push_back(std::make_unique<ForStatement>(/*offset=*/-1,
730 std::move(loopVar.fVarDecl),
731 std::move(test),
732 std::move(increment),
733 std::move(innerBlock),
734 symbolTable));
John Stiles44e96be2020-08-31 13:16:04 -0400735 } else {
John Stilesfa9a0832020-12-17 10:43:58 -0500736 // No early returns, so we can just dump the code into our existing scopeless block.
737 inlineStatements = &inlinedBody.children();
John Stiles7b920442020-12-17 10:43:41 -0500738 }
739
740 inlineStatements->reserve_back(body.children().size() + argsToCopyBack.size());
741 for (const std::unique_ptr<Statement>& stmt : body.children()) {
742 inlineStatements->push_back(this->inlineStatement(offset, &varMap, symbolTable.get(),
John Stiles77702f12020-12-17 14:38:56 -0500743 &resultExpr, returnComplexity, *stmt,
John Stiles7b920442020-12-17 10:43:41 -0500744 caller->isBuiltin()));
John Stiles44e96be2020-08-31 13:16:04 -0400745 }
746
John Stilese41b4ee2020-09-28 12:28:16 -0400747 // Copy back the values of `out` parameters into their real destinations.
748 for (int i : argsToCopyBack) {
Ethan Nicholas0a5d0962020-10-14 13:33:18 -0400749 const Variable* p = function.declaration().parameters()[i];
John Stilese41b4ee2020-09-28 12:28:16 -0400750 SkASSERT(varMap.find(p) != varMap.end());
John Stiles7b920442020-12-17 10:43:41 -0500751 inlineStatements->push_back(
John Stilese41b4ee2020-09-28 12:28:16 -0400752 std::make_unique<ExpressionStatement>(std::make_unique<BinaryExpression>(
753 offset,
Ethan Nicholas453f67f2020-10-09 10:43:45 -0400754 clone_with_ref_kind(*arguments[i], VariableReference::RefKind::kWrite),
John Stilese41b4ee2020-09-28 12:28:16 -0400755 Token::Kind::TK_EQ,
756 std::move(varMap[p]),
757 &arguments[i]->type())));
John Stiles44e96be2020-08-31 13:16:04 -0400758 }
759
John Stilese41b4ee2020-09-28 12:28:16 -0400760 if (resultExpr != nullptr) {
761 // Return our result variable as our replacement expression.
John Stilese41b4ee2020-09-28 12:28:16 -0400762 inlinedCall.fReplacementExpr = std::move(resultExpr);
John Stiles44e96be2020-08-31 13:16:04 -0400763 } else {
764 // It's a void function, so it doesn't actually result in anything, but we have to return
765 // something non-null as a standin.
Ethan Nicholas041fd0a2020-10-07 16:42:04 -0400766 inlinedCall.fReplacementExpr = std::make_unique<BoolLiteral>(*fContext,
767 offset,
John Stiles44e96be2020-08-31 13:16:04 -0400768 /*value=*/false);
769 }
770
John Stiles44e96be2020-08-31 13:16:04 -0400771 return inlinedCall;
772}
773
John Stiles2d7973a2020-10-02 15:01:03 -0400774bool Inliner::isSafeToInline(const FunctionDefinition* functionDef) {
John Stiles44e96be2020-08-31 13:16:04 -0400775 SkASSERT(fSettings);
776
John Stiles1c03d332020-10-13 10:30:23 -0400777 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
778 if (fSettings->fInlineThreshold <= 0) {
779 return false;
780 }
781
John Stiles031a7672020-11-13 16:13:18 -0500782 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
783 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
784 return false;
785 }
786
John Stiles2d7973a2020-10-02 15:01:03 -0400787 if (functionDef == nullptr) {
John Stiles44e96be2020-08-31 13:16:04 -0400788 // Can't inline something if we don't actually have its definition.
789 return false;
790 }
John Stiles2d7973a2020-10-02 15:01:03 -0400791
John Stiles74ebd7e2020-12-17 14:41:50 -0500792 // We don't have any mechanism to simulate early returns within a construct that supports
793 // continues (for/do/while), so we can't inline if there's a return inside one.
794 bool hasReturnInContinuableConstruct =
795 (count_returns_in_continuable_constructs(*functionDef) > 0);
796 return !hasReturnInContinuableConstruct;
John Stiles44e96be2020-08-31 13:16:04 -0400797}
798
John Stiles2d7973a2020-10-02 15:01:03 -0400799// A candidate function for inlining, containing everything that `inlineCall` needs.
800struct InlineCandidate {
John Stiles78047582020-12-16 16:17:41 -0500801 std::shared_ptr<SymbolTable> fSymbols; // the SymbolTable of the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400802 std::unique_ptr<Statement>* fParentStmt; // the parent Statement of the enclosing stmt
803 std::unique_ptr<Statement>* fEnclosingStmt; // the Statement containing the candidate
804 std::unique_ptr<Expression>* fCandidateExpr; // the candidate FunctionCall to be inlined
805 FunctionDefinition* fEnclosingFunction; // the Function containing the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400806};
John Stiles93442622020-09-11 12:11:27 -0400807
John Stiles2d7973a2020-10-02 15:01:03 -0400808struct InlineCandidateList {
809 std::vector<InlineCandidate> fCandidates;
810};
811
812class InlineCandidateAnalyzer {
John Stiles70957c82020-10-02 16:42:10 -0400813public:
814 // A list of all the inlining candidates we found during analysis.
815 InlineCandidateList* fCandidateList;
John Stiles2d7973a2020-10-02 15:01:03 -0400816
John Stiles70957c82020-10-02 16:42:10 -0400817 // A stack of the symbol tables; since most nodes don't have one, expected to be shallower than
818 // the enclosing-statement stack.
John Stiles78047582020-12-16 16:17:41 -0500819 std::vector<std::shared_ptr<SymbolTable>> fSymbolTableStack;
John Stiles70957c82020-10-02 16:42:10 -0400820 // A stack of "enclosing" statements--these would be suitable for the inliner to use for adding
821 // new instructions. Not all statements are suitable (e.g. a for-loop's initializer). The
822 // inliner might replace a statement with a block containing the statement.
823 std::vector<std::unique_ptr<Statement>*> fEnclosingStmtStack;
824 // The function that we're currently processing (i.e. inlining into).
825 FunctionDefinition* fEnclosingFunction = nullptr;
John Stiles93442622020-09-11 12:11:27 -0400826
Brian Osman0006ad02020-11-18 15:38:39 -0500827 void visit(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -0500828 std::shared_ptr<SymbolTable> symbols,
Brian Osman0006ad02020-11-18 15:38:39 -0500829 InlineCandidateList* candidateList) {
John Stiles70957c82020-10-02 16:42:10 -0400830 fCandidateList = candidateList;
Brian Osman0006ad02020-11-18 15:38:39 -0500831 fSymbolTableStack.push_back(symbols);
John Stiles93442622020-09-11 12:11:27 -0400832
Brian Osman0006ad02020-11-18 15:38:39 -0500833 for (const std::unique_ptr<ProgramElement>& pe : elements) {
Brian Osman1179fcf2020-10-08 16:04:40 -0400834 this->visitProgramElement(pe.get());
John Stiles93442622020-09-11 12:11:27 -0400835 }
836
John Stiles70957c82020-10-02 16:42:10 -0400837 fSymbolTableStack.pop_back();
838 fCandidateList = nullptr;
839 }
840
841 void visitProgramElement(ProgramElement* pe) {
842 switch (pe->kind()) {
843 case ProgramElement::Kind::kFunction: {
844 FunctionDefinition& funcDef = pe->as<FunctionDefinition>();
Brian Osman0006ad02020-11-18 15:38:39 -0500845 fEnclosingFunction = &funcDef;
846 this->visitStatement(&funcDef.body());
John Stiles70957c82020-10-02 16:42:10 -0400847 break;
John Stiles93442622020-09-11 12:11:27 -0400848 }
John Stiles70957c82020-10-02 16:42:10 -0400849 default:
850 // The inliner can't operate outside of a function's scope.
851 break;
852 }
853 }
854
855 void visitStatement(std::unique_ptr<Statement>* stmt,
856 bool isViableAsEnclosingStatement = true) {
857 if (!*stmt) {
858 return;
John Stiles93442622020-09-11 12:11:27 -0400859 }
860
John Stiles70957c82020-10-02 16:42:10 -0400861 size_t oldEnclosingStmtStackSize = fEnclosingStmtStack.size();
862 size_t oldSymbolStackSize = fSymbolTableStack.size();
John Stiles93442622020-09-11 12:11:27 -0400863
John Stiles70957c82020-10-02 16:42:10 -0400864 if (isViableAsEnclosingStatement) {
865 fEnclosingStmtStack.push_back(stmt);
John Stiles93442622020-09-11 12:11:27 -0400866 }
867
John Stiles70957c82020-10-02 16:42:10 -0400868 switch ((*stmt)->kind()) {
869 case Statement::Kind::kBreak:
870 case Statement::Kind::kContinue:
871 case Statement::Kind::kDiscard:
872 case Statement::Kind::kInlineMarker:
873 case Statement::Kind::kNop:
874 break;
875
876 case Statement::Kind::kBlock: {
877 Block& block = (*stmt)->as<Block>();
878 if (block.symbolTable()) {
John Stiles78047582020-12-16 16:17:41 -0500879 fSymbolTableStack.push_back(block.symbolTable());
John Stiles70957c82020-10-02 16:42:10 -0400880 }
881
882 for (std::unique_ptr<Statement>& stmt : block.children()) {
883 this->visitStatement(&stmt);
884 }
885 break;
John Stiles93442622020-09-11 12:11:27 -0400886 }
John Stiles70957c82020-10-02 16:42:10 -0400887 case Statement::Kind::kDo: {
888 DoStatement& doStmt = (*stmt)->as<DoStatement>();
889 // The loop body is a candidate for inlining.
890 this->visitStatement(&doStmt.statement());
891 // The inliner isn't smart enough to inline the test-expression for a do-while
892 // loop at this time. There are two limitations:
893 // - We would need to insert the inlined-body block at the very end of the do-
894 // statement's inner fStatement. We don't support that today, but it's doable.
895 // - We cannot inline the test expression if the loop uses `continue` anywhere; that
896 // would skip over the inlined block that evaluates the test expression. There
897 // isn't a good fix for this--any workaround would be more complex than the cost
898 // of a function call. However, loops that don't use `continue` would still be
899 // viable candidates for inlining.
900 break;
John Stiles93442622020-09-11 12:11:27 -0400901 }
John Stiles70957c82020-10-02 16:42:10 -0400902 case Statement::Kind::kExpression: {
903 ExpressionStatement& expr = (*stmt)->as<ExpressionStatement>();
904 this->visitExpression(&expr.expression());
905 break;
906 }
907 case Statement::Kind::kFor: {
908 ForStatement& forStmt = (*stmt)->as<ForStatement>();
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400909 if (forStmt.symbols()) {
John Stiles78047582020-12-16 16:17:41 -0500910 fSymbolTableStack.push_back(forStmt.symbols());
John Stiles70957c82020-10-02 16:42:10 -0400911 }
912
913 // The initializer and loop body are candidates for inlining.
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400914 this->visitStatement(&forStmt.initializer(),
John Stiles70957c82020-10-02 16:42:10 -0400915 /*isViableAsEnclosingStatement=*/false);
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400916 this->visitStatement(&forStmt.statement());
John Stiles70957c82020-10-02 16:42:10 -0400917
918 // The inliner isn't smart enough to inline the test- or increment-expressions
919 // of a for loop loop at this time. There are a handful of limitations:
920 // - We would need to insert the test-expression block at the very beginning of the
921 // for-loop's inner fStatement, and the increment-expression block at the very
922 // end. We don't support that today, but it's doable.
923 // - The for-loop's built-in test-expression would need to be dropped entirely,
924 // and the loop would be halted via a break statement at the end of the inlined
925 // test-expression. This is again something we don't support today, but it could
926 // be implemented.
927 // - We cannot inline the increment-expression if the loop uses `continue` anywhere;
928 // that would skip over the inlined block that evaluates the increment expression.
929 // There isn't a good fix for this--any workaround would be more complex than the
930 // cost of a function call. However, loops that don't use `continue` would still
931 // be viable candidates for increment-expression inlining.
932 break;
933 }
934 case Statement::Kind::kIf: {
935 IfStatement& ifStmt = (*stmt)->as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400936 this->visitExpression(&ifStmt.test());
937 this->visitStatement(&ifStmt.ifTrue());
938 this->visitStatement(&ifStmt.ifFalse());
John Stiles70957c82020-10-02 16:42:10 -0400939 break;
940 }
941 case Statement::Kind::kReturn: {
942 ReturnStatement& returnStmt = (*stmt)->as<ReturnStatement>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400943 this->visitExpression(&returnStmt.expression());
John Stiles70957c82020-10-02 16:42:10 -0400944 break;
945 }
946 case Statement::Kind::kSwitch: {
947 SwitchStatement& switchStmt = (*stmt)->as<SwitchStatement>();
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400948 if (switchStmt.symbols()) {
John Stiles78047582020-12-16 16:17:41 -0500949 fSymbolTableStack.push_back(switchStmt.symbols());
John Stiles70957c82020-10-02 16:42:10 -0400950 }
951
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400952 this->visitExpression(&switchStmt.value());
John Stiles2d4f9592020-10-30 10:29:12 -0400953 for (const std::unique_ptr<SwitchCase>& switchCase : switchStmt.cases()) {
John Stiles70957c82020-10-02 16:42:10 -0400954 // The switch-case's fValue cannot be a FunctionCall; skip it.
John Stiles2d4f9592020-10-30 10:29:12 -0400955 for (std::unique_ptr<Statement>& caseBlock : switchCase->statements()) {
John Stiles70957c82020-10-02 16:42:10 -0400956 this->visitStatement(&caseBlock);
957 }
958 }
959 break;
960 }
961 case Statement::Kind::kVarDeclaration: {
962 VarDeclaration& varDeclStmt = (*stmt)->as<VarDeclaration>();
963 // Don't need to scan the declaration's sizes; those are always IntLiterals.
Ethan Nicholasc51f33e2020-10-13 13:49:44 -0400964 this->visitExpression(&varDeclStmt.value());
John Stiles70957c82020-10-02 16:42:10 -0400965 break;
966 }
John Stiles70957c82020-10-02 16:42:10 -0400967 default:
968 SkUNREACHABLE;
John Stiles93442622020-09-11 12:11:27 -0400969 }
970
John Stiles70957c82020-10-02 16:42:10 -0400971 // Pop our symbol and enclosing-statement stacks.
972 fSymbolTableStack.resize(oldSymbolStackSize);
973 fEnclosingStmtStack.resize(oldEnclosingStmtStackSize);
974 }
975
976 void visitExpression(std::unique_ptr<Expression>* expr) {
977 if (!*expr) {
978 return;
John Stiles93442622020-09-11 12:11:27 -0400979 }
John Stiles70957c82020-10-02 16:42:10 -0400980
981 switch ((*expr)->kind()) {
982 case Expression::Kind::kBoolLiteral:
983 case Expression::Kind::kDefined:
Brian Osmanbe0b3b72021-01-06 14:27:35 -0500984 case Expression::Kind::kExternalFunctionReference:
John Stiles70957c82020-10-02 16:42:10 -0400985 case Expression::Kind::kFieldAccess:
986 case Expression::Kind::kFloatLiteral:
987 case Expression::Kind::kFunctionReference:
988 case Expression::Kind::kIntLiteral:
John Stiles70957c82020-10-02 16:42:10 -0400989 case Expression::Kind::kSetting:
990 case Expression::Kind::kTypeReference:
991 case Expression::Kind::kVariableReference:
992 // Nothing to scan here.
993 break;
994
995 case Expression::Kind::kBinary: {
996 BinaryExpression& binaryExpr = (*expr)->as<BinaryExpression>();
John Stiles2d4f9592020-10-30 10:29:12 -0400997 this->visitExpression(&binaryExpr.left());
John Stiles70957c82020-10-02 16:42:10 -0400998
999 // Logical-and and logical-or binary expressions do not inline the right side,
1000 // because that would invalidate short-circuiting. That is, when evaluating
1001 // expressions like these:
1002 // (false && x()) // always false
1003 // (true || y()) // always true
1004 // It is illegal for side-effects from x() or y() to occur. The simplest way to
1005 // enforce that rule is to avoid inlining the right side entirely. However, it is
1006 // safe for other types of binary expression to inline both sides.
1007 Token::Kind op = binaryExpr.getOperator();
1008 bool shortCircuitable = (op == Token::Kind::TK_LOGICALAND ||
1009 op == Token::Kind::TK_LOGICALOR);
1010 if (!shortCircuitable) {
John Stiles2d4f9592020-10-30 10:29:12 -04001011 this->visitExpression(&binaryExpr.right());
John Stiles70957c82020-10-02 16:42:10 -04001012 }
1013 break;
1014 }
1015 case Expression::Kind::kConstructor: {
1016 Constructor& constructorExpr = (*expr)->as<Constructor>();
1017 for (std::unique_ptr<Expression>& arg : constructorExpr.arguments()) {
1018 this->visitExpression(&arg);
1019 }
1020 break;
1021 }
1022 case Expression::Kind::kExternalFunctionCall: {
1023 ExternalFunctionCall& funcCallExpr = (*expr)->as<ExternalFunctionCall>();
1024 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
1025 this->visitExpression(&arg);
1026 }
1027 break;
1028 }
1029 case Expression::Kind::kFunctionCall: {
1030 FunctionCall& funcCallExpr = (*expr)->as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -04001031 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
John Stiles70957c82020-10-02 16:42:10 -04001032 this->visitExpression(&arg);
1033 }
1034 this->addInlineCandidate(expr);
1035 break;
1036 }
1037 case Expression::Kind::kIndex:{
1038 IndexExpression& indexExpr = (*expr)->as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -04001039 this->visitExpression(&indexExpr.base());
1040 this->visitExpression(&indexExpr.index());
John Stiles70957c82020-10-02 16:42:10 -04001041 break;
1042 }
1043 case Expression::Kind::kPostfix: {
1044 PostfixExpression& postfixExpr = (*expr)->as<PostfixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -04001045 this->visitExpression(&postfixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001046 break;
1047 }
1048 case Expression::Kind::kPrefix: {
1049 PrefixExpression& prefixExpr = (*expr)->as<PrefixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -04001050 this->visitExpression(&prefixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001051 break;
1052 }
1053 case Expression::Kind::kSwizzle: {
1054 Swizzle& swizzleExpr = (*expr)->as<Swizzle>();
Ethan Nicholas6b4d5812020-10-12 16:11:51 -04001055 this->visitExpression(&swizzleExpr.base());
John Stiles70957c82020-10-02 16:42:10 -04001056 break;
1057 }
1058 case Expression::Kind::kTernary: {
1059 TernaryExpression& ternaryExpr = (*expr)->as<TernaryExpression>();
1060 // The test expression is a candidate for inlining.
Ethan Nicholasdd218162020-10-08 05:48:01 -04001061 this->visitExpression(&ternaryExpr.test());
John Stiles70957c82020-10-02 16:42:10 -04001062 // The true- and false-expressions cannot be inlined, because we are only allowed to
1063 // evaluate one side.
1064 break;
1065 }
1066 default:
1067 SkUNREACHABLE;
1068 }
1069 }
1070
1071 void addInlineCandidate(std::unique_ptr<Expression>* candidate) {
1072 fCandidateList->fCandidates.push_back(
1073 InlineCandidate{fSymbolTableStack.back(),
1074 find_parent_statement(fEnclosingStmtStack),
1075 fEnclosingStmtStack.back(),
1076 candidate,
John Stiles9b9415e2020-11-23 14:48:06 -05001077 fEnclosingFunction});
John Stiles70957c82020-10-02 16:42:10 -04001078 }
John Stiles2d7973a2020-10-02 15:01:03 -04001079};
John Stiles93442622020-09-11 12:11:27 -04001080
John Stiles9b9415e2020-11-23 14:48:06 -05001081static const FunctionDeclaration& candidate_func(const InlineCandidate& candidate) {
1082 return (*candidate.fCandidateExpr)->as<FunctionCall>().function();
1083}
John Stiles915a38c2020-09-14 09:38:13 -04001084
John Stiles9b9415e2020-11-23 14:48:06 -05001085bool Inliner::candidateCanBeInlined(const InlineCandidate& candidate, InlinabilityCache* cache) {
1086 const FunctionDeclaration& funcDecl = candidate_func(candidate);
John Stiles1c03d332020-10-13 10:30:23 -04001087 auto [iter, wasInserted] = cache->insert({&funcDecl, false});
John Stiles2d7973a2020-10-02 15:01:03 -04001088 if (wasInserted) {
1089 // Recursion is forbidden here to avoid an infinite death spiral of inlining.
John Stiles1c03d332020-10-13 10:30:23 -04001090 iter->second = this->isSafeToInline(funcDecl.definition()) &&
1091 !contains_recursive_call(funcDecl);
John Stiles93442622020-09-11 12:11:27 -04001092 }
1093
John Stiles2d7973a2020-10-02 15:01:03 -04001094 return iter->second;
1095}
1096
John Stiles9b9415e2020-11-23 14:48:06 -05001097int Inliner::getFunctionSize(const FunctionDeclaration& funcDecl, FunctionSizeCache* cache) {
1098 auto [iter, wasInserted] = cache->insert({&funcDecl, 0});
John Stiles2d7973a2020-10-02 15:01:03 -04001099 if (wasInserted) {
John Stiles9b9415e2020-11-23 14:48:06 -05001100 iter->second = Analysis::NodeCountUpToLimit(*funcDecl.definition(),
1101 fSettings->fInlineThreshold);
John Stiles2d7973a2020-10-02 15:01:03 -04001102 }
John Stiles2d7973a2020-10-02 15:01:03 -04001103 return iter->second;
1104}
1105
Brian Osman0006ad02020-11-18 15:38:39 -05001106void Inliner::buildCandidateList(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -05001107 std::shared_ptr<SymbolTable> symbols, ProgramUsage* usage,
Brian Osman0006ad02020-11-18 15:38:39 -05001108 InlineCandidateList* candidateList) {
John Stiles2d7973a2020-10-02 15:01:03 -04001109 // This is structured much like a ProgramVisitor, but does not actually use ProgramVisitor.
1110 // The analyzer needs to keep track of the `unique_ptr<T>*` of statements and expressions so
1111 // that they can later be replaced, and ProgramVisitor does not provide this; it only provides a
1112 // `const T&`.
1113 InlineCandidateAnalyzer analyzer;
Brian Osman0006ad02020-11-18 15:38:39 -05001114 analyzer.visit(elements, symbols, candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001115
John Stiles0ad233f2020-11-25 11:02:05 -05001116 // Early out if there are no inlining candidates.
John Stiles2d7973a2020-10-02 15:01:03 -04001117 std::vector<InlineCandidate>& candidates = candidateList->fCandidates;
John Stiles0ad233f2020-11-25 11:02:05 -05001118 if (candidates.empty()) {
1119 return;
1120 }
1121
1122 // Remove candidates that are not safe to inline.
John Stiles2d7973a2020-10-02 15:01:03 -04001123 InlinabilityCache cache;
1124 candidates.erase(std::remove_if(candidates.begin(),
1125 candidates.end(),
1126 [&](const InlineCandidate& candidate) {
1127 return !this->candidateCanBeInlined(candidate, &cache);
1128 }),
1129 candidates.end());
1130
John Stiles0ad233f2020-11-25 11:02:05 -05001131 // If the inline threshold is unlimited, or if we have no candidates left, our candidate list is
1132 // complete.
1133 if (fSettings->fInlineThreshold == INT_MAX || candidates.empty()) {
1134 return;
John Stiles2d7973a2020-10-02 15:01:03 -04001135 }
John Stiles0ad233f2020-11-25 11:02:05 -05001136
1137 // Remove candidates on a per-function basis if the effect of inlining would be to make more
1138 // than `inlineThreshold` nodes. (i.e. if Func() would be inlined six times and its size is
1139 // 10 nodes, it should be inlined if the inlineThreshold is 60 or higher.)
1140 FunctionSizeCache functionSizeCache;
1141 FunctionSizeCache candidateTotalCost;
1142 for (InlineCandidate& candidate : candidates) {
1143 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1144 candidateTotalCost[&fnDecl] += this->getFunctionSize(fnDecl, &functionSizeCache);
1145 }
1146
1147 candidates.erase(
1148 std::remove_if(candidates.begin(),
1149 candidates.end(),
1150 [&](const InlineCandidate& candidate) {
1151 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1152 if (fnDecl.modifiers().fFlags & Modifiers::kInline_Flag) {
1153 // Functions marked `inline` ignore size limitations.
1154 return false;
1155 }
1156 if (usage->get(fnDecl) == 1) {
1157 // If a function is only used once, it's cost-free to inline.
1158 return false;
1159 }
1160 if (candidateTotalCost[&fnDecl] <= fSettings->fInlineThreshold) {
1161 // We won't exceed the inline threshold by inlining this.
1162 return false;
1163 }
1164 // Inlining this function will add too many IRNodes.
1165 return true;
1166 }),
1167 candidates.end());
John Stiles2d7973a2020-10-02 15:01:03 -04001168}
1169
Brian Osman0006ad02020-11-18 15:38:39 -05001170bool Inliner::analyze(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -05001171 std::shared_ptr<SymbolTable> symbols,
Brian Osman0006ad02020-11-18 15:38:39 -05001172 ProgramUsage* usage) {
John Stilesd34d56e2020-10-12 12:04:47 -04001173 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
1174 if (fSettings->fInlineThreshold <= 0) {
1175 return false;
1176 }
1177
John Stiles031a7672020-11-13 16:13:18 -05001178 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
1179 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1180 return false;
1181 }
1182
John Stiles2d7973a2020-10-02 15:01:03 -04001183 InlineCandidateList candidateList;
John Stiles9b9415e2020-11-23 14:48:06 -05001184 this->buildCandidateList(elements, symbols, usage, &candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001185
John Stiles915a38c2020-09-14 09:38:13 -04001186 // Inline the candidates where we've determined that it's safe to do so.
1187 std::unordered_set<const std::unique_ptr<Statement>*> enclosingStmtSet;
1188 bool madeChanges = false;
John Stiles2d7973a2020-10-02 15:01:03 -04001189 for (const InlineCandidate& candidate : candidateList.fCandidates) {
John Stiles915a38c2020-09-14 09:38:13 -04001190 FunctionCall& funcCall = (*candidate.fCandidateExpr)->as<FunctionCall>();
John Stiles915a38c2020-09-14 09:38:13 -04001191
1192 // Inlining two expressions using the same enclosing statement in the same inlining pass
1193 // does not work properly. If this happens, skip it; we'll get it in the next pass.
1194 auto [unusedIter, inserted] = enclosingStmtSet.insert(candidate.fEnclosingStmt);
1195 if (!inserted) {
1196 continue;
1197 }
1198
1199 // Convert the function call to its inlined equivalent.
Brian Osman3887a012020-09-30 13:22:27 -04001200 InlinedCall inlinedCall = this->inlineCall(&funcCall, candidate.fSymbols,
Ethan Nicholas0a5d0962020-10-14 13:33:18 -04001201 &candidate.fEnclosingFunction->declaration());
John Stiles915a38c2020-09-14 09:38:13 -04001202 if (inlinedCall.fInlinedBody) {
1203 // Ensure that the inlined body has a scope if it needs one.
John Stiles6d696082020-10-01 10:18:54 -04001204 this->ensureScopedBlocks(inlinedCall.fInlinedBody.get(), candidate.fParentStmt->get());
John Stiles915a38c2020-09-14 09:38:13 -04001205
Brian Osman010ce6a2020-10-19 16:34:10 -04001206 // Add references within the inlined body
1207 usage->add(inlinedCall.fInlinedBody.get());
1208
John Stiles915a38c2020-09-14 09:38:13 -04001209 // Move the enclosing statement to the end of the unscoped Block containing the inlined
1210 // function, then replace the enclosing statement with that Block.
1211 // Before:
1212 // fInlinedBody = Block{ stmt1, stmt2, stmt3 }
1213 // fEnclosingStmt = stmt4
1214 // After:
1215 // fInlinedBody = null
1216 // fEnclosingStmt = Block{ stmt1, stmt2, stmt3, stmt4 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -04001217 inlinedCall.fInlinedBody->children().push_back(std::move(*candidate.fEnclosingStmt));
John Stiles915a38c2020-09-14 09:38:13 -04001218 *candidate.fEnclosingStmt = std::move(inlinedCall.fInlinedBody);
1219 }
1220
1221 // Replace the candidate function call with our replacement expression.
Brian Osman010ce6a2020-10-19 16:34:10 -04001222 usage->replace(candidate.fCandidateExpr->get(), inlinedCall.fReplacementExpr.get());
John Stiles915a38c2020-09-14 09:38:13 -04001223 *candidate.fCandidateExpr = std::move(inlinedCall.fReplacementExpr);
1224 madeChanges = true;
1225
John Stiles031a7672020-11-13 16:13:18 -05001226 // Stop inlining if we've reached our hard cap on new statements.
1227 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1228 break;
1229 }
1230
John Stiles915a38c2020-09-14 09:38:13 -04001231 // Note that nothing was destroyed except for the FunctionCall. All other nodes should
1232 // remain valid.
1233 }
1234
1235 return madeChanges;
John Stiles93442622020-09-11 12:11:27 -04001236}
1237
John Stiles44e96be2020-08-31 13:16:04 -04001238} // namespace SkSL