blob: 2321ada86f9c6adb06eeac33e155399e14a75bdc [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Yves Gerey3e707812018-11-28 16:47:49 +010011#include <stdint.h>
Henrik Boström933d8b02017-10-10 10:05:16 -070012#include <memory>
Yves Gerey3e707812018-11-28 16:47:49 +010013#include <string>
14#include <utility>
Henrik Boström933d8b02017-10-10 10:05:16 -070015#include <vector>
16
Karl Wiberg918f50c2018-07-05 11:40:33 +020017#include "absl/memory/memory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010018#include "absl/types/optional.h"
19#include "api/audio/audio_mixer.h"
20#include "api/audio_codecs/audio_decoder_factory.h"
21#include "api/audio_codecs/audio_encoder_factory.h"
Karl Wiberg1b0eae32017-10-17 14:48:54 +020022#include "api/audio_codecs/builtin_audio_decoder_factory.h"
23#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Mirko Bonadei2ff3f492018-11-22 09:00:13 +010024#include "api/create_peerconnection_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070025#include "api/jsep.h"
Steve Anton10542f22019-01-11 09:11:00 -080026#include "api/media_stream_interface.h"
27#include "api/media_types.h"
28#include "api/peer_connection_interface.h"
29#include "api/rtc_error.h"
30#include "api/rtp_parameters.h"
31#include "api/rtp_receiver_interface.h"
32#include "api/rtp_sender_interface.h"
33#include "api/rtp_transceiver_interface.h"
Mirko Bonadeid9708072019-01-25 20:26:48 +010034#include "api/scoped_refptr.h"
Steve Anton10542f22019-01-11 09:11:00 -080035#include "api/set_remote_description_observer_interface.h"
36#include "api/uma_metrics.h"
Anders Carlsson67537952018-05-03 11:28:29 +020037#include "api/video_codecs/builtin_video_decoder_factory.h"
38#include "api/video_codecs/builtin_video_encoder_factory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010039#include "api/video_codecs/video_decoder_factory.h"
40#include "api/video_codecs/video_encoder_factory.h"
Steve Anton10542f22019-01-11 09:11:00 -080041#include "media/base/stream_params.h"
Yves Gerey3e707812018-11-28 16:47:49 +010042#include "modules/audio_device/include/audio_device.h"
43#include "modules/audio_processing/include/audio_processing.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "p2p/base/port_allocator.h"
45#include "pc/media_session.h"
46#include "pc/peer_connection_wrapper.h"
47#include "pc/sdp_utils.h"
48#include "pc/session_description.h"
49#include "pc/test/fake_audio_capture_module.h"
50#include "pc/test/mock_peer_connection_observers.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070051#include "rtc_base/checks.h"
52#include "rtc_base/gunit.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "rtc_base/ref_counted_object.h"
54#include "rtc_base/rtc_certificate_generator.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070055#include "rtc_base/thread.h"
Mirko Bonadei17f48782018-09-28 08:51:10 +020056#include "system_wrappers/include/metrics.h"
Steve Anton9158ef62017-11-27 13:01:52 -080057#include "test/gmock.h"
Yves Gerey3e707812018-11-28 16:47:49 +010058#include "test/gtest.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070059
60// This file contains tests for RTP Media API-related behavior of
61// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
62
Steve Anton9158ef62017-11-27 13:01:52 -080063namespace webrtc {
64
65using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
66using ::testing::ElementsAre;
67using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 15:30:18 -070068using ::testing::Values;
Henrik Boström933d8b02017-10-10 10:05:16 -070069
Henrik Boström31638672017-11-23 17:48:32 +010070const uint32_t kDefaultTimeout = 10000u;
71
72template <typename MethodFunctor>
73class OnSuccessObserver : public rtc::RefCountedObject<
74 webrtc::SetRemoteDescriptionObserverInterface> {
75 public:
76 explicit OnSuccessObserver(MethodFunctor on_success)
77 : on_success_(std::move(on_success)) {}
78
79 // webrtc::SetRemoteDescriptionObserverInterface implementation.
80 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
81 RTC_CHECK(error.ok());
82 on_success_();
83 }
84
85 private:
86 MethodFunctor on_success_;
87};
88
Steve Anton3172c032018-05-03 15:30:18 -070089class PeerConnectionRtpBaseTest : public testing::Test {
Henrik Boström933d8b02017-10-10 10:05:16 -070090 public:
Steve Anton3172c032018-05-03 15:30:18 -070091 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
92 : sdp_semantics_(sdp_semantics),
93 pc_factory_(
Steve Anton9158ef62017-11-27 13:01:52 -080094 CreatePeerConnectionFactory(rtc::Thread::Current(),
95 rtc::Thread::Current(),
96 rtc::Thread::Current(),
97 FakeAudioCaptureModule::Create(),
98 CreateBuiltinAudioEncoderFactory(),
99 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 11:28:29 +0200100 CreateBuiltinVideoEncoderFactory(),
101 CreateBuiltinVideoDecoderFactory(),
102 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 12:54:53 -0700103 nullptr /* audio_processing */)) {
104 webrtc::metrics::Reset();
105 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700106
Steve Anton9158ef62017-11-27 13:01:52 -0800107 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
108 return CreatePeerConnection(RTCConfiguration());
109 }
110
Steve Antone831b8c2018-02-01 12:22:16 -0800111 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
112 RTCConfiguration config;
113 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 15:30:18 -0700114 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 12:22:16 -0800115 }
116
Steve Anton9158ef62017-11-27 13:01:52 -0800117 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
118 RTCConfiguration config;
119 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 15:30:18 -0700120 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 13:01:52 -0800121 }
122
123 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
124 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 15:30:18 -0700125 RTCConfiguration modified_config = config;
126 modified_config.sdp_semantics = sdp_semantics_;
127 return CreatePeerConnectionInternal(modified_config);
128 }
129
130 protected:
131 const SdpSemantics sdp_semantics_;
132 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
133
134 private:
135 // Private so that tests don't accidentally bypass the SdpSemantics
136 // adjustment.
137 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
138 const RTCConfiguration& config) {
Karl Wiberg918f50c2018-07-05 11:40:33 +0200139 auto observer = absl::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -0700140 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
141 observer.get());
Yves Gerey4e933292018-10-31 15:36:05 +0100142 EXPECT_TRUE(pc.get());
143 observer->SetPeerConnectionInterface(pc.get());
Karl Wiberg918f50c2018-07-05 11:40:33 +0200144 return absl::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
145 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -0700146 }
Steve Anton3172c032018-05-03 15:30:18 -0700147};
Henrik Boström933d8b02017-10-10 10:05:16 -0700148
Steve Anton3172c032018-05-03 15:30:18 -0700149class PeerConnectionRtpTest
150 : public PeerConnectionRtpBaseTest,
151 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 10:05:16 -0700152 protected:
Steve Anton3172c032018-05-03 15:30:18 -0700153 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
154};
155
156class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
157 protected:
158 PeerConnectionRtpTestPlanB()
159 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
160};
161
162class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
163 protected:
164 PeerConnectionRtpTestUnifiedPlan()
165 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Henrik Boström933d8b02017-10-10 10:05:16 -0700166};
167
Henrik Boström31638672017-11-23 17:48:32 +0100168// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
169// setting the remote description.
Henrik Boström31638672017-11-23 17:48:32 +0100170
Steve Anton3172c032018-05-03 15:30:18 -0700171TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700172 auto caller = CreatePeerConnection();
173 auto callee = CreatePeerConnection();
174
Steve Anton3172c032018-05-03 15:30:18 -0700175 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700176 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700177
Henrik Boström31638672017-11-23 17:48:32 +0100178 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700179 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100180 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 15:30:18 -0700181
182 if (sdp_semantics_ == SdpSemantics::kPlanB) {
183 // Since we are not supporting the no stream case with Plan B, there should
184 // be a generated stream, even though we didn't set one with AddTrack.
185 ASSERT_EQ(1u, add_track_event.streams.size());
186 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
187 } else {
188 EXPECT_EQ(0u, add_track_event.streams.size());
189 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700190}
191
Steve Anton3172c032018-05-03 15:30:18 -0700192TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700193 auto caller = CreatePeerConnection();
194 auto callee = CreatePeerConnection();
195
Steve Anton3172c032018-05-03 15:30:18 -0700196 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700197 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700198
Henrik Boström31638672017-11-23 17:48:32 +0100199 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100200 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100201 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700202 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100203 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
204 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700205}
206
Steve Anton3172c032018-05-03 15:30:18 -0700207TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700208 auto caller = CreatePeerConnection();
209 auto callee = CreatePeerConnection();
210
Steve Anton3172c032018-05-03 15:30:18 -0700211 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700212 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100213 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700214 ASSERT_TRUE(
215 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
216
Henrik Boström933d8b02017-10-10 10:05:16 -0700217 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700218 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700219
Henrik Boström31638672017-11-23 17:48:32 +0100220 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700221 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
222 callee->observer()->remove_track_events_);
223}
224
Steve Anton3172c032018-05-03 15:30:18 -0700225TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700226 auto caller = CreatePeerConnection();
227 auto callee = CreatePeerConnection();
228
Steve Anton3172c032018-05-03 15:30:18 -0700229 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700230 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100231 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700232 ASSERT_TRUE(
233 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
234
Henrik Boström933d8b02017-10-10 10:05:16 -0700235 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700236 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700237
Henrik Boström31638672017-11-23 17:48:32 +0100238 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700239 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
240 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700241 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700242}
243
Steve Anton3172c032018-05-03 15:30:18 -0700244TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700245 auto caller = CreatePeerConnection();
246 auto callee = CreatePeerConnection();
247
Seth Hampson845e8782018-03-02 11:34:10 -0800248 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700249 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
250 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700251 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100252 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 15:30:18 -0700253 ASSERT_TRUE(
254 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700255
256 // Remove "audio_track1".
257 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700258 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100259 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700260 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800261 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700262 callee->observer()->add_track_events_[0].receiver},
263 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700264 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
265 ASSERT_TRUE(
266 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700267
268 // Remove "audio_track2".
269 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700270 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100271 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700272 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
273 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700274 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700275}
276
Seth Hampson5b4f0752018-04-02 16:31:36 -0700277// Tests the edge case that if a stream ID changes for a given track that both
278// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 15:30:18 -0700279TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700280 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
281 auto caller = CreatePeerConnection();
282 auto callee = CreatePeerConnection();
283
284 const char kStreamId1[] = "stream1";
285 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700286 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700287 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700288 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
289
290 // Change the stream ID of the sender in the session description.
291 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 15:30:18 -0700292 auto* audio_desc =
293 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700294 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
295 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 15:30:18 -0700296 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700297
298 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
299 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
300 kStreamId2);
301 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
302 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
303 kStreamId1);
304}
305
Steve Anton8b815cd2018-02-16 16:14:42 -0800306// Tests that setting a remote description with sending transceivers will fire
307// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 16:31:36 -0700308// with receive only transceivers will not call OnTrack. One transceiver is
309// created without any stream_ids, while the other is created with multiple
310// stream_ids.
Steve Anton3172c032018-05-03 15:30:18 -0700311TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 16:31:36 -0700312 const std::string kStreamId1 = "video_stream1";
313 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700314 auto caller = CreatePeerConnection();
315 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800316
317 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 16:31:36 -0700318 RtpTransceiverInit video_transceiver_init;
319 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
320 auto video_transceiver =
321 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-16 16:14:42 -0800322
323 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
324
325 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
326 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
327 EXPECT_EQ(audio_transceiver->mid(),
328 callee->pc()->GetTransceivers()[0]->mid());
329 EXPECT_EQ(video_transceiver->mid(),
330 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700331 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
332 callee->pc()->GetTransceivers()[0]->receiver()->streams();
333 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
334 callee->pc()->GetTransceivers()[1]->receiver()->streams();
335 ASSERT_EQ(0u, audio_streams.size());
336 ASSERT_EQ(2u, video_streams.size());
337 EXPECT_EQ(kStreamId1, video_streams[0]->id());
338 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-16 16:14:42 -0800339}
340
341// Test that doing additional offer/answer exchanges with no changes to tracks
342// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 15:30:18 -0700343TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
344 auto caller = CreatePeerConnection();
345 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800346
347 caller->AddAudioTrack("audio");
348 callee->AddAudioTrack("audio");
349
350 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
351 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
352 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
353
354 // If caller reoffers with no changes expect no additional OnTrack calls.
355 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
356 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
357 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
358
359 // Also if callee reoffers with no changes expect no additional OnTrack calls.
360 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
361 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
362 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
363}
364
365// Test that OnTrack is called when the transceiver direction changes to send
366// the track.
Steve Anton3172c032018-05-03 15:30:18 -0700367TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
368 auto caller = CreatePeerConnection();
369 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800370
371 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
372 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
373 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
374 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
375 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
376
377 transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
378 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
379 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
380 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
381
382 // If the direction changes but it is still receiving on the remote side, then
383 // OnTrack should not be fired again.
384 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
385 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
386 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
387 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
388}
389
390// Test that OnTrack is called twice when a sendrecv call is started, the callee
391// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -0700392TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
393 auto caller = CreatePeerConnection();
394 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800395
396 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
397
398 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
399 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
400 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
401
402 // Put the call on hold by no longer receiving the track.
403 callee->pc()->GetTransceivers()[0]->SetDirection(
404 RtpTransceiverDirection::kInactive);
405
406 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
407 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
408 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
409
410 // Resume the call by changing the direction to recvonly. This should call
411 // OnTrack again on the callee side.
412 callee->pc()->GetTransceivers()[0]->SetDirection(
413 RtpTransceiverDirection::kRecvOnly);
414
415 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
416 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
417 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
418}
419
Steve Anton3172c032018-05-03 15:30:18 -0700420// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 14:25:36 -0700421// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 15:30:18 -0700422TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700423 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 17:48:32 +0100424 auto caller = CreatePeerConnection();
425 auto callee = CreatePeerConnection();
426
Steve Anton3172c032018-05-03 15:30:18 -0700427 caller->AddAudioTrack("audio_track", {});
428
Amit Hilbuchae3df542019-01-07 12:13:08 -0800429 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700430 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
431
Amit Hilbuchae3df542019-01-07 12:13:08 -0800432 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton0f5400a2018-07-17 14:25:36 -0700433 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700434}
435
436// Test that setting a remote offer twice with no answer in the middle and the
437// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 14:25:36 -0700438// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 15:30:18 -0700439TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700440 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 15:30:18 -0700441 auto caller = CreatePeerConnection();
442 auto callee = CreatePeerConnection();
443
444 auto sender = caller->AddAudioTrack("audio_track", {});
445
Amit Hilbuchae3df542019-01-07 12:13:08 -0800446 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700447 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700448 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700449
450 caller->pc()->RemoveTrack(sender);
451
Amit Hilbuchae3df542019-01-07 12:13:08 -0800452 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700453 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700454 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
455}
456
457// Test that changing the direction from receiving to not receiving between
458// setting the remote offer and creating / setting the local answer results in
459// a remove track event when SetLocalDescription is called.
460TEST_F(PeerConnectionRtpTestUnifiedPlan,
461 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
462 auto caller = CreatePeerConnection();
463 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
464 auto callee = CreatePeerConnection();
465 callee->AddAudioTrack("audio_track", {});
466
467 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
468 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700469 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700470
471 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
472 callee_transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
473
474 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
475 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
476 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700477}
478
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100479TEST_F(PeerConnectionRtpTestUnifiedPlan, ChangeMsidWhileReceiving) {
480 auto caller = CreatePeerConnection();
481 caller->AddAudioTrack("audio_track", {"stream1"});
482 auto callee = CreatePeerConnection();
Amit Hilbuchae3df542019-01-07 12:13:08 -0800483 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100484
485 ASSERT_EQ(1u, callee->observer()->on_track_transceivers_.size());
486 auto transceiver = callee->observer()->on_track_transceivers_[0];
487 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
488 EXPECT_EQ("stream1", transceiver->receiver()->streams()[0]->id());
489
Amit Hilbuchae3df542019-01-07 12:13:08 -0800490 ASSERT_TRUE(callee->CreateAnswerAndSetAsLocal());
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100491
492 // Change the stream ID in the offer.
493 // TODO(https://crbug.com/webrtc/10129): When RtpSenderInterface::SetStreams
494 // is supported, this can use that instead of munging the SDP.
495 auto offer = caller->CreateOffer();
496 auto contents = offer->description()->contents();
497 ASSERT_EQ(1u, contents.size());
498 auto& stream_params = contents[0].media_description()->mutable_streams();
499 ASSERT_EQ(1u, stream_params.size());
500 stream_params[0].set_stream_ids({"stream2"});
501 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
502 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
503 EXPECT_EQ("stream2", transceiver->receiver()->streams()[0]->id());
504}
505
Steve Anton3172c032018-05-03 15:30:18 -0700506// These tests examine the state of the peer connection as a result of
507// performing SetRemoteDescription().
508
509TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
510 auto caller = CreatePeerConnection();
511 auto callee = CreatePeerConnection();
512
513 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700514 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100515
516 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
517 auto receiver_added = callee->pc()->GetReceivers()[0];
518 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 15:30:18 -0700519
520 if (sdp_semantics_ == SdpSemantics::kPlanB) {
521 // Since we are not supporting the no stream case with Plan B, there should
522 // be a generated stream, even though we didn't set one with AddTrack.
523 ASSERT_EQ(1u, receiver_added->streams().size());
524 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
525 } else {
526 EXPECT_EQ(0u, receiver_added->streams().size());
527 }
Henrik Boström31638672017-11-23 17:48:32 +0100528}
529
Steve Anton3172c032018-05-03 15:30:18 -0700530TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100531 auto caller = CreatePeerConnection();
532 auto callee = CreatePeerConnection();
533
Steve Anton3172c032018-05-03 15:30:18 -0700534 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700535 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100536
537 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
538 auto receiver_added = callee->pc()->GetReceivers()[0];
539 EXPECT_EQ("audio_track", receiver_added->track()->id());
540 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700541 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 17:48:32 +0100542 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
543}
544
Steve Anton3172c032018-05-03 15:30:18 -0700545TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100546 auto caller = CreatePeerConnection();
547 auto callee = CreatePeerConnection();
548
Steve Anton3172c032018-05-03 15:30:18 -0700549 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100550 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700551 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
552
Henrik Boström31638672017-11-23 17:48:32 +0100553 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
554 auto receiver = callee->pc()->GetReceivers()[0];
555 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700556 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100557
Steve Anton3172c032018-05-03 15:30:18 -0700558 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
559 // With Unified Plan the receiver stays but the transceiver transitions to
560 // inactive.
561 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
562 EXPECT_EQ(RtpTransceiverDirection::kInactive,
563 callee->pc()->GetTransceivers()[0]->current_direction());
564 } else {
565 // With Plan B the receiver is removed.
566 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
567 }
Henrik Boström31638672017-11-23 17:48:32 +0100568}
569
Steve Anton3172c032018-05-03 15:30:18 -0700570TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100571 auto caller = CreatePeerConnection();
572 auto callee = CreatePeerConnection();
573
Steve Anton3172c032018-05-03 15:30:18 -0700574 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100575 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700576 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100577 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
578 auto receiver = callee->pc()->GetReceivers()[0];
579 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700580 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100581
Steve Anton3172c032018-05-03 15:30:18 -0700582 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
583 // With Unified Plan the receiver stays but the transceiver transitions to
584 // inactive.
585 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
586 EXPECT_EQ(RtpTransceiverDirection::kInactive,
587 callee->pc()->GetTransceivers()[0]->current_direction());
588 } else {
589 // With Plan B the receiver is removed.
590 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
591 }
Henrik Boström31638672017-11-23 17:48:32 +0100592}
593
Steve Anton3172c032018-05-03 15:30:18 -0700594TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100595 auto caller = CreatePeerConnection();
596 auto callee = CreatePeerConnection();
597
Seth Hampson845e8782018-03-02 11:34:10 -0800598 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700599 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
600 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
601 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
602 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 17:48:32 +0100603
604 // Remove "audio_track1".
605 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Steve Anton3172c032018-05-03 15:30:18 -0700606 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
607
608 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
609 // With Unified Plan the receiver stays but the transceiver transitions to
610 // inactive.
611 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
612 auto transceiver = callee->pc()->GetTransceivers()[0];
613 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
614 EXPECT_EQ(RtpTransceiverDirection::kInactive,
615 transceiver->current_direction());
616 } else {
617 // With Plan B the receiver is removed.
618 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
619 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
620 }
Henrik Boström31638672017-11-23 17:48:32 +0100621
622 // Remove "audio_track2".
623 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Steve Anton3172c032018-05-03 15:30:18 -0700624 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
625
626 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
627 // With Unified Plan the receiver stays but the transceiver transitions to
628 // inactive.
629 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
630 auto transceiver = callee->pc()->GetTransceivers()[1];
631 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
632 EXPECT_EQ(RtpTransceiverDirection::kInactive,
633 transceiver->current_direction());
634 } else {
635 // With Plan B the receiver is removed.
636 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
637 }
Henrik Boström31638672017-11-23 17:48:32 +0100638}
639
Florent Castelliabe301f2018-06-12 18:33:49 +0200640TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
641 auto caller = CreatePeerConnection();
642 auto callee = CreatePeerConnection();
643 auto sender = caller->AddAudioTrack("audio_track");
644 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
645
646 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
647 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
648
649 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
650 auto receiver = callee->pc()->GetReceivers()[0];
651 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
652}
653
654TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
655 auto caller = CreatePeerConnection();
656 auto callee = CreatePeerConnection();
657 auto sender = caller->AddVideoTrack("video_track");
658 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
659
660 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
661 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
662
663 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
664 auto receiver = callee->pc()->GetReceivers()[0];
665 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
666}
667
Henrik Boström31638672017-11-23 17:48:32 +0100668// Invokes SetRemoteDescription() twice in a row without synchronizing the two
669// calls and examine the state of the peer connection inside the callbacks to
670// ensure that the second call does not occur prematurely, contaminating the
671// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 15:30:18 -0700672TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 17:48:32 +0100673 StatesCorrelateWithSetRemoteDescriptionCall) {
674 auto caller = CreatePeerConnection();
675 auto callee = CreatePeerConnection();
676
Henrik Boström31638672017-11-23 17:48:32 +0100677 // Create SDP for adding a track and for removing it. This will be used in the
678 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 15:30:18 -0700679 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100680 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
681 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
682 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
683
684 // In the first SetRemoteDescription() callback, check that we have a
685 // receiver for the track.
686 auto pc = callee->pc();
687 bool srd1_callback_called = false;
688 auto srd1_callback = [&srd1_callback_called, &pc]() {
689 EXPECT_EQ(pc->GetReceivers().size(), 1u);
690 srd1_callback_called = true;
691 };
692
693 // In the second SetRemoteDescription() callback, check that the receiver has
694 // been removed.
695 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
696 // Instead, the transceiver owning the receiver will become inactive.
697 // https://crbug.com/webrtc/7600
698 bool srd2_callback_called = false;
699 auto srd2_callback = [&srd2_callback_called, &pc]() {
700 EXPECT_TRUE(pc->GetReceivers().empty());
701 srd2_callback_called = true;
702 };
703
704 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
705 // calls. The callbacks verify that the two calls are synchronized, as in, the
706 // effects of the second SetRemoteDescription() call must not have happened by
707 // the time the first callback is invoked. If it has then the receiver that is
708 // added as a result of the first SetRemoteDescription() call will already
709 // have been removed as a result of the second SetRemoteDescription() call
710 // when the first callback is invoked.
711 callee->pc()->SetRemoteDescription(
712 std::move(srd1_sdp),
713 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
714 callee->pc()->SetRemoteDescription(
715 std::move(srd2_sdp),
716 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
717 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
718 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
719}
720
Seth Hampson5897a6e2018-04-03 11:16:33 -0700721// Tests that a remote track is created with the signaled MSIDs when they are
722// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
723// lines).
Steve Anton3172c032018-05-03 15:30:18 -0700724TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
725 auto caller = CreatePeerConnection();
726 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 11:16:33 -0700727 const char kStreamId1[] = "stream1";
728 const char kStreamId2[] = "stream2";
729 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
730 {kStreamId1, kStreamId2});
731
732 auto offer = caller->CreateOfferAndSetAsLocal();
733 // Munge the offer to take out everything but the stream_ids.
734 auto contents = offer->description()->contents();
735 ASSERT_TRUE(!contents.empty());
736 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
737 std::vector<std::string> stream_ids =
738 contents[0].media_description()->streams()[0].stream_ids();
739 contents[0].media_description()->mutable_streams().clear();
740 cricket::StreamParams new_stream;
741 new_stream.set_stream_ids(stream_ids);
742 contents[0].media_description()->AddStream(new_stream);
743
744 // Set the remote description and verify that the streams were added to the
745 // receiver correctly.
746 ASSERT_TRUE(
747 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
748 auto receivers = callee->pc()->GetReceivers();
749 ASSERT_EQ(receivers.size(), 1u);
750 ASSERT_EQ(receivers[0]->streams().size(), 2u);
751 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
752 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
753}
754
Seth Hampson5b4f0752018-04-02 16:31:36 -0700755// Tests that with Unified Plan if the the stream id changes for a track when
756// when setting a new remote description, that the media stream is updated
757// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 14:25:36 -0700758// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
759// test.
760TEST_F(PeerConnectionRtpTestUnifiedPlan,
761 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700762 auto caller = CreatePeerConnection();
763 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 16:31:36 -0700764
765 const char kStreamId1[] = "stream1";
766 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 14:25:36 -0700767 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700768 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700769 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
770
771 // Change the stream id of the sender in the session description.
772 auto offer = caller->CreateOfferAndSetAsLocal();
773 auto contents = offer->description()->contents();
774 ASSERT_EQ(contents.size(), 1u);
775 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
776 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
777 {kStreamId2});
778
Steve Anton0f5400a2018-07-17 14:25:36 -0700779 // Set the remote description and verify that the stream was updated
780 // properly.
781 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700782 auto receivers = callee->pc()->GetReceivers();
783 ASSERT_EQ(receivers.size(), 1u);
784 ASSERT_EQ(receivers[0]->streams().size(), 1u);
785 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
786}
787
788// This tests a regression caught by a downstream client, that occured when
789// applying a remote description with a SessionDescription object that
790// contained StreamParams that didn't have ids. Although there were multiple
791// remote audio senders, FindSenderInfo didn't find them as unique, because
792// it looked up by StreamParam.id, which none had. This meant only one
793// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 15:30:18 -0700794TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700795 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
796 auto caller = CreatePeerConnection();
797 auto callee = CreatePeerConnection();
798
799 const char kStreamId1[] = "stream1";
800 const char kStreamId2[] = "stream2";
801 caller->AddAudioTrack("audio_track1", {kStreamId1});
802 caller->AddAudioTrack("audio_track2", {kStreamId2});
803
804 auto offer = caller->CreateOfferAndSetAsLocal();
805 auto mutable_streams =
806 cricket::GetFirstAudioContentDescription(offer->description())
807 ->mutable_streams();
808 ASSERT_EQ(mutable_streams.size(), 2u);
809 // Clear the IDs in the StreamParams.
810 mutable_streams[0].id.clear();
811 mutable_streams[1].id.clear();
812 ASSERT_TRUE(
813 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
814
815 auto receivers = callee->pc()->GetReceivers();
816 ASSERT_EQ(receivers.size(), 2u);
817 ASSERT_EQ(receivers[0]->streams().size(), 1u);
818 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
819 ASSERT_EQ(receivers[1]->streams().size(), 1u);
820 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
821}
822
Henrik Boström31638672017-11-23 17:48:32 +0100823// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 17:48:32 +0100824
825// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 15:30:18 -0700826TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 17:48:32 +0100827 auto caller = CreatePeerConnection();
828 auto callee = CreatePeerConnection();
829
830 std::string error;
831 ASSERT_TRUE(
832 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
833}
834
835// Verifies legacy behavior: The observer is not called if if the peer
836// connection is destroyed because the asynchronous callback is executed in the
837// peer connection's message handler.
Steve Anton3172c032018-05-03 15:30:18 -0700838TEST_P(PeerConnectionRtpTest,
839 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 17:48:32 +0100840 auto caller = CreatePeerConnection();
841 auto callee = CreatePeerConnection();
842
843 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
844 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
845
846 auto offer = caller->CreateOfferAndSetAsLocal();
847 callee->pc()->SetRemoteDescription(observer, offer.release());
848 callee = nullptr;
849 rtc::Thread::Current()->ProcessMessages(0);
850 EXPECT_FALSE(observer->called());
851}
852
Steve Antonf9381f02017-12-14 10:23:57 -0800853// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800854
855// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 15:30:18 -0700856TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
857 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800858 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
859}
860
861// Test that a transceiver created with the audio kind has the correct initial
862// properties.
Steve Anton3172c032018-05-03 15:30:18 -0700863TEST_F(PeerConnectionRtpTestUnifiedPlan,
864 AddTransceiverHasCorrectInitProperties) {
865 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800866
867 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200868 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 13:01:52 -0800869 EXPECT_FALSE(transceiver->stopped());
870 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200871 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 13:01:52 -0800872}
873
874// Test that adding a transceiver with the audio kind creates an audio sender
875// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 15:30:18 -0700876TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800877 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700878 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800879
880 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 11:43:08 -0800881 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800882
883 ASSERT_TRUE(transceiver->sender());
884 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
885
886 ASSERT_TRUE(transceiver->receiver());
887 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
888
889 auto track = transceiver->receiver()->track();
890 ASSERT_TRUE(track);
891 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
892 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
893}
894
895// Test that adding a transceiver with the video kind creates an video sender
896// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 15:30:18 -0700897TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800898 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700899 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800900
901 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 11:43:08 -0800902 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800903
904 ASSERT_TRUE(transceiver->sender());
905 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
906
907 ASSERT_TRUE(transceiver->receiver());
908 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
909
910 auto track = transceiver->receiver()->track();
911 ASSERT_TRUE(track);
912 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
913 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
914}
915
916// Test that after a call to AddTransceiver, the transceiver shows in
917// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
918// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 15:30:18 -0700919TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
920 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800921
922 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
923 EXPECT_EQ(
924 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
925 caller->pc()->GetTransceivers());
926 EXPECT_EQ(
927 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
928 transceiver->sender()},
929 caller->pc()->GetSenders());
930 EXPECT_EQ(
931 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
932 transceiver->receiver()},
933 caller->pc()->GetReceivers());
934}
935
936// Test that the direction passed in through the AddTransceiver init parameter
937// is set in the returned transceiver.
Steve Anton3172c032018-05-03 15:30:18 -0700938TEST_F(PeerConnectionRtpTestUnifiedPlan,
939 AddTransceiverWithDirectionIsReflected) {
940 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800941
942 RtpTransceiverInit init;
943 init.direction = RtpTransceiverDirection::kSendOnly;
944 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
945 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
946}
947
Steve Anton9158ef62017-11-27 13:01:52 -0800948// Test that calling AddTransceiver with a track creates a transceiver which has
949// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 15:30:18 -0700950TEST_F(PeerConnectionRtpTestUnifiedPlan,
951 AddTransceiverWithTrackCreatesSenderWithTrack) {
952 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800953
954 auto audio_track = caller->CreateAudioTrack("audio track");
955 auto transceiver = caller->AddTransceiver(audio_track);
956
957 auto sender = transceiver->sender();
958 ASSERT_TRUE(sender->track());
959 EXPECT_EQ(audio_track, sender->track());
960
961 auto receiver = transceiver->receiver();
962 ASSERT_TRUE(receiver->track());
963 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
964 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
965 receiver->track()->state());
966}
967
968// Test that calling AddTransceiver twice with the same track creates distinct
969// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 15:30:18 -0700970TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800971 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 15:30:18 -0700972 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800973
974 auto audio_track = caller->CreateAudioTrack("audio track");
975
976 auto transceiver1 = caller->AddTransceiver(audio_track);
977 auto transceiver2 = caller->AddTransceiver(audio_track);
978
979 EXPECT_NE(transceiver1, transceiver2);
980
981 auto sender1 = transceiver1->sender();
982 auto sender2 = transceiver2->sender();
983 EXPECT_NE(sender1, sender2);
984 EXPECT_EQ(audio_track, sender1->track());
985 EXPECT_EQ(audio_track, sender2->track());
986
987 EXPECT_THAT(caller->pc()->GetTransceivers(),
988 UnorderedElementsAre(transceiver1, transceiver2));
989 EXPECT_THAT(caller->pc()->GetSenders(),
990 UnorderedElementsAre(sender1, sender2));
991}
992
Steve Anton3fe1b152017-12-12 10:20:08 -0800993// RtpTransceiver error handling tests.
994
Steve Anton3172c032018-05-03 15:30:18 -0700995TEST_F(PeerConnectionRtpTestUnifiedPlan,
996 AddTransceiverWithInvalidKindReturnsError) {
997 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800998
999 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
1000 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
1001}
1002
Steve Anton3172c032018-05-03 15:30:18 -07001003TEST_F(PeerConnectionRtpTestUnifiedPlan,
1004 CanClosePeerConnectionWithoutCrashing) {
1005 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -08001006
1007 caller->pc()->Close();
1008}
1009
Steve Antonf9381f02017-12-14 10:23:57 -08001010// Unified Plan AddTrack tests.
1011
Steve Antonf9381f02017-12-14 10:23:57 -08001012// Test that adding an audio track creates a new audio RtpSender with the given
1013// track.
Steve Anton3172c032018-05-03 15:30:18 -07001014TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
1015 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001016
1017 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001018 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001019 ASSERT_TRUE(sender);
1020
1021 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
1022 EXPECT_EQ(audio_track, sender->track());
1023}
1024
1025// Test that adding a video track creates a new video RtpSender with the given
1026// track.
Steve Anton3172c032018-05-03 15:30:18 -07001027TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
1028 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001029
1030 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001031 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001032 ASSERT_TRUE(sender);
1033
1034 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
1035 EXPECT_EQ(video_track, sender->track());
1036}
1037
1038// Test that adding a track to a new PeerConnection creates an RtpTransceiver
1039// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 15:30:18 -07001040TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
1041 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001042
1043 auto sender = caller->AddAudioTrack("a");
1044 ASSERT_TRUE(sender);
1045
1046 auto transceivers = caller->pc()->GetTransceivers();
1047 ASSERT_EQ(1u, transceivers.size());
1048 EXPECT_EQ(sender, transceivers[0]->sender());
1049 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
1050}
1051
1052// Test that if a transceiver of the same type but no track had been added to
1053// the PeerConnection and later a call to AddTrack is made, the resulting sender
1054// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 15:30:18 -07001055TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1056 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001057
1058 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1059 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001060 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001061 ASSERT_TRUE(sender);
1062
1063 auto transceivers = caller->pc()->GetTransceivers();
1064 ASSERT_EQ(1u, transceivers.size());
1065 EXPECT_EQ(transceiver, transceivers[0]);
1066 EXPECT_EQ(sender, transceiver->sender());
1067 EXPECT_EQ(audio_track, sender->track());
1068}
1069
1070// Test that adding two tracks to a new PeerConnection creates two
1071// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 15:30:18 -07001072TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1073 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001074
1075 auto sender1 = caller->AddAudioTrack("a");
1076 auto sender2 = caller->AddVideoTrack("v");
1077 ASSERT_TRUE(sender2);
1078
1079 auto transceivers = caller->pc()->GetTransceivers();
1080 ASSERT_EQ(2u, transceivers.size());
1081 EXPECT_EQ(sender1, transceivers[0]->sender());
1082 EXPECT_EQ(sender2, transceivers[1]->sender());
1083}
1084
1085// Test that if there are multiple transceivers with no sending track then a
1086// later call to AddTrack will use the one of the same type as the newly-added
1087// track.
Steve Anton3172c032018-05-03 15:30:18 -07001088TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1089 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001090
1091 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1092 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1093 auto sender = caller->AddVideoTrack("v");
1094
1095 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1096 EXPECT_NE(sender, audio_transceiver->sender());
1097 EXPECT_EQ(sender, video_transceiver->sender());
1098}
1099
1100// Test that if the only transceivers that do not have a sending track have a
1101// different type from the added track, then AddTrack will create a new
1102// transceiver for the track.
Steve Anton3172c032018-05-03 15:30:18 -07001103TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001104 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 15:30:18 -07001105 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001106
1107 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1108 auto sender = caller->AddVideoTrack("v");
1109
1110 auto transceivers = caller->pc()->GetTransceivers();
1111 ASSERT_EQ(2u, transceivers.size());
1112 EXPECT_NE(sender, transceivers[0]->sender());
1113 EXPECT_EQ(sender, transceivers[1]->sender());
1114}
1115
1116// Test that the first available transceiver is reused by AddTrack when multiple
1117// are available.
Steve Anton3172c032018-05-03 15:30:18 -07001118TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001119 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001120 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001121
1122 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1123 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1124 auto sender = caller->AddAudioTrack("a");
1125
1126 auto transceivers = caller->pc()->GetTransceivers();
1127 ASSERT_EQ(2u, transceivers.size());
1128 EXPECT_EQ(sender, transceivers[0]->sender());
1129 EXPECT_NE(sender, transceivers[1]->sender());
1130}
1131
1132// Test that a call to AddTrack that reuses a transceiver will change the
1133// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 15:30:18 -07001134TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001135 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001136 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001137
1138 RtpTransceiverInit init;
1139 init.direction = RtpTransceiverDirection::kInactive;
1140 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1141
1142 caller->observer()->clear_negotiation_needed();
1143 ASSERT_TRUE(caller->AddAudioTrack("a"));
1144 EXPECT_TRUE(caller->observer()->negotiation_needed());
1145
1146 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1147}
1148
1149// Test that a call to AddTrack that reuses a transceiver will change the
1150// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -07001151TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001152 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 15:30:18 -07001153 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001154
1155 RtpTransceiverInit init;
1156 init.direction = RtpTransceiverDirection::kRecvOnly;
1157 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1158
1159 caller->observer()->clear_negotiation_needed();
1160 ASSERT_TRUE(caller->AddAudioTrack("a"));
1161 EXPECT_TRUE(caller->observer()->negotiation_needed());
1162
1163 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1164}
1165
Steve Anton3172c032018-05-03 15:30:18 -07001166TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-10 16:26:06 -08001167 const std::string kTrackId = "audio_track";
1168
Steve Anton3172c032018-05-03 15:30:18 -07001169 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-10 16:26:06 -08001170
1171 auto audio_track = caller->CreateAudioTrack(kTrackId);
1172 auto sender = caller->AddTrack(audio_track);
1173
1174 EXPECT_EQ(kTrackId, sender->id());
1175}
1176
Steve Antonf9381f02017-12-14 10:23:57 -08001177// Unified Plan AddTrack error handling.
1178
Steve Anton3172c032018-05-03 15:30:18 -07001179TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1180 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001181
1182 auto audio_track = caller->CreateAudioTrack("a");
1183 caller->pc()->Close();
1184
1185 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001186 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001187 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001188 EXPECT_FALSE(caller->observer()->negotiation_needed());
1189}
1190
Steve Anton3172c032018-05-03 15:30:18 -07001191TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1192 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001193
1194 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001195 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -08001196
1197 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001198 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001199 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001200 EXPECT_FALSE(caller->observer()->negotiation_needed());
1201}
1202
1203// Unified Plan RemoveTrack tests.
1204
1205// Test that calling RemoveTrack on a sender with a previously-added track
1206// clears the sender's track.
Steve Anton3172c032018-05-03 15:30:18 -07001207TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1208 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001209
1210 auto sender = caller->AddAudioTrack("a");
1211 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1212
1213 EXPECT_FALSE(sender->track());
1214}
1215
1216// Test that calling RemoveTrack on a sender where the transceiver is configured
1217// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 15:30:18 -07001218TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001219 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001220 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001221
1222 RtpTransceiverInit init;
1223 init.direction = RtpTransceiverDirection::kSendRecv;
1224 auto transceiver =
1225 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1226
1227 caller->observer()->clear_negotiation_needed();
1228 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1229 EXPECT_TRUE(caller->observer()->negotiation_needed());
1230
1231 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
1232 EXPECT_TRUE(caller->observer()->renegotiation_needed_);
1233}
1234
1235// Test that calling RemoveTrack on a sender where the transceiver is configured
1236// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 15:30:18 -07001237TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001238 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 15:30:18 -07001239 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001240
1241 RtpTransceiverInit init;
1242 init.direction = RtpTransceiverDirection::kSendOnly;
1243 auto transceiver =
1244 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1245
1246 caller->observer()->clear_negotiation_needed();
1247 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1248 EXPECT_TRUE(caller->observer()->negotiation_needed());
1249
1250 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1251}
1252
1253// Test that calling RemoveTrack with a sender that has a null track results in
1254// no change in state.
Steve Anton3172c032018-05-03 15:30:18 -07001255TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1256 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001257
1258 auto sender = caller->AddAudioTrack("a");
1259 auto transceiver = caller->pc()->GetTransceivers()[0];
1260 ASSERT_TRUE(sender->SetTrack(nullptr));
1261
1262 caller->observer()->clear_negotiation_needed();
1263 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1264 EXPECT_FALSE(caller->observer()->negotiation_needed());
1265
1266 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1267}
1268
1269// Unified Plan RemoveTrack error handling.
1270
Steve Anton3172c032018-05-03 15:30:18 -07001271TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1272 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001273
1274 auto sender = caller->AddAudioTrack("a");
1275 caller->pc()->Close();
1276
1277 caller->observer()->clear_negotiation_needed();
1278 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
1279 EXPECT_FALSE(caller->observer()->negotiation_needed());
1280}
1281
Steve Anton3172c032018-05-03 15:30:18 -07001282TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001283 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 15:30:18 -07001284 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001285
1286 auto sender = caller->AddAudioTrack("a");
1287 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1288
1289 caller->observer()->clear_negotiation_needed();
1290 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
1291 EXPECT_FALSE(caller->observer()->negotiation_needed());
1292}
1293
Steve Anton60b6c1d2018-06-13 11:32:27 -07001294// Test that setting offers that add/remove/add a track repeatedly without
1295// setting the appropriate answer in between works.
1296// These are regression tests for bugs.webrtc.org/9401
1297TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1298 auto caller = CreatePeerConnection();
1299
1300 auto sender1 = caller->AddAudioTrack("audio1");
1301 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1302
1303 caller->pc()->RemoveTrack(sender1);
1304 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1305
1306 // This will re-use the transceiver created by the first AddTrack.
1307 auto sender2 = caller->AddAudioTrack("audio2");
1308 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1309
1310 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1311 EXPECT_EQ(sender1, sender2);
1312}
1313TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1314 auto caller = CreatePeerConnection();
1315
1316 auto sender1 = caller->AddVideoTrack("video1");
1317 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1318
1319 caller->pc()->RemoveTrack(sender1);
1320 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1321
1322 // This will re-use the transceiver created by the first AddTrack.
1323 auto sender2 = caller->AddVideoTrack("video2");
1324 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1325
1326 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1327 EXPECT_EQ(sender1, sender2);
1328}
1329
Steve Anton07563732018-06-26 11:13:50 -07001330// Test that CreateOffer succeeds if two tracks with the same label are added.
1331TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1332 auto caller = CreatePeerConnection();
1333
1334 auto audio_sender = caller->AddAudioTrack("track", {});
1335 auto video_sender = caller->AddVideoTrack("track", {});
1336
1337 EXPECT_TRUE(caller->CreateOffer());
1338
1339 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1340 EXPECT_NE(audio_sender->id(), video_sender->id());
1341}
1342
1343// Test that CreateAnswer succeeds if two tracks with the same label are added.
1344TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1345 auto caller = CreatePeerConnection();
1346 auto callee = CreatePeerConnection();
1347
1348 RtpTransceiverInit recvonly;
1349 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1350 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1351 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1352
1353 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1354
1355 auto audio_sender = callee->AddAudioTrack("track", {});
1356 auto video_sender = callee->AddVideoTrack("track", {});
1357
1358 EXPECT_TRUE(callee->CreateAnswer());
1359
1360 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1361 EXPECT_NE(audio_sender->id(), video_sender->id());
1362}
1363
1364// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1365// m= section with a random sender id (different from the first, now rejected,
1366// m= section).
1367TEST_F(PeerConnectionRtpTestUnifiedPlan,
1368 AddRemoveAddTrackGeneratesNewSenderId) {
1369 auto caller = CreatePeerConnection();
1370 auto callee = CreatePeerConnection();
1371
1372 auto track = caller->CreateVideoTrack("video");
1373 auto sender1 = caller->AddTrack(track);
1374 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1375
1376 caller->pc()->RemoveTrack(sender1);
1377 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1378
1379 auto sender2 = caller->AddTrack(track);
1380
1381 EXPECT_NE(sender1, sender2);
1382 EXPECT_NE(sender1->id(), sender2->id());
1383 std::string sender2_id = sender2->id();
1384
1385 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1386
1387 // The sender's ID should not change after negotiation.
1388 EXPECT_EQ(sender2_id, sender2->id());
1389}
1390
Steve Anton52d86772018-02-20 15:48:12 -08001391// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1392// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 15:30:18 -07001393TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001394 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001395 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001396
1397 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1398
1399 caller->observer()->clear_negotiation_needed();
1400 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1401 EXPECT_TRUE(caller->observer()->negotiation_needed());
1402}
1403
1404// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1405// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 15:30:18 -07001406TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001407 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001408 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001409
1410 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1411
1412 caller->observer()->clear_negotiation_needed();
1413 transceiver->SetDirection(transceiver->direction());
1414 EXPECT_FALSE(caller->observer()->negotiation_needed());
1415}
1416
1417// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1418// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001419TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001420 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001421 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001422
1423 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1424 transceiver->Stop();
1425
1426 caller->observer()->clear_negotiation_needed();
1427 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1428 EXPECT_FALSE(caller->observer()->negotiation_needed());
1429}
1430
Florent Castelli892acf02018-10-01 22:47:20 +02001431// Test that AddTransceiver fails if trying to use simulcast using
1432// send_encodings as it isn't currently supported.
1433TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForUnsupportedSimulcast) {
1434 auto caller = CreatePeerConnection();
1435
1436 RtpTransceiverInit init;
1437 init.send_encodings.emplace_back();
1438 init.send_encodings.emplace_back();
1439 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
1440 EXPECT_EQ(result.error().type(), RTCErrorType::UNSUPPORTED_PARAMETER);
1441}
1442
1443// Test that AddTransceiver fails if trying to use unimplemented RTP encoding
1444// parameters with the send_encodings parameters.
1445TEST_F(PeerConnectionRtpTestUnifiedPlan,
1446 CheckForUnsupportedEncodingParameters) {
1447 auto caller = CreatePeerConnection();
1448
1449 RtpTransceiverInit init;
1450 init.send_encodings.emplace_back();
1451
1452 auto default_send_encodings = init.send_encodings;
1453
Henrik Grunelle1301a82018-12-13 12:13:22 +00001454 // Unimplemented RtpParameters: ssrc, codec_payload_type, fec, rtx, dtx,
Florent Castelli892acf02018-10-01 22:47:20 +02001455 // ptime, scale_resolution_down_by, scale_framerate_down_by, rid,
1456 // dependency_rids.
1457 init.send_encodings[0].ssrc = 1;
1458 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1459 caller->pc()
1460 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1461 .error()
1462 .type());
1463 init.send_encodings = default_send_encodings;
1464
Henrik Grunelle1301a82018-12-13 12:13:22 +00001465 init.send_encodings[0].codec_payload_type = 1;
1466 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1467 caller->pc()
1468 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1469 .error()
1470 .type());
1471 init.send_encodings = default_send_encodings;
1472
Florent Castelli892acf02018-10-01 22:47:20 +02001473 init.send_encodings[0].fec = RtpFecParameters();
1474 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1475 caller->pc()
1476 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1477 .error()
1478 .type());
1479 init.send_encodings = default_send_encodings;
1480
1481 init.send_encodings[0].rtx = RtpRtxParameters();
1482 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1483 caller->pc()
1484 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1485 .error()
1486 .type());
1487 init.send_encodings = default_send_encodings;
1488
1489 init.send_encodings[0].dtx = DtxStatus::ENABLED;
1490 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1491 caller->pc()
1492 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1493 .error()
1494 .type());
1495 init.send_encodings = default_send_encodings;
1496
1497 init.send_encodings[0].ptime = 1;
1498 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1499 caller->pc()
1500 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1501 .error()
1502 .type());
1503 init.send_encodings = default_send_encodings;
1504
1505 init.send_encodings[0].scale_resolution_down_by = 2.0;
1506 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1507 caller->pc()
1508 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1509 .error()
1510 .type());
1511 init.send_encodings = default_send_encodings;
1512
1513 init.send_encodings[0].rid = "dummy_rid";
1514 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1515 caller->pc()
1516 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1517 .error()
1518 .type());
1519 init.send_encodings = default_send_encodings;
1520
1521 init.send_encodings[0].dependency_rids.push_back("dummy_rid");
1522 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1523 caller->pc()
1524 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1525 .error()
1526 .type());
1527}
1528
1529// Test that AddTransceiver transfers the send_encodings to the sender and they
1530// are retained after SetLocalDescription().
1531TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) {
1532 auto caller = CreatePeerConnection();
1533
1534 RtpTransceiverInit init;
1535 init.send_encodings.emplace_back();
1536 init.send_encodings[0].active = false;
1537 init.send_encodings[0].max_bitrate_bps = 180000;
1538
1539 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1540 ASSERT_TRUE(result.ok());
1541
1542 auto init_send_encodings = result.value()->sender()->init_send_encodings();
1543 EXPECT_FALSE(init_send_encodings[0].active);
1544 EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000);
1545
1546 auto parameters = result.value()->sender()->GetParameters();
1547 EXPECT_FALSE(parameters.encodings[0].active);
1548 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1549
1550 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1551
1552 parameters = result.value()->sender()->GetParameters();
1553 EXPECT_FALSE(parameters.encodings[0].active);
1554 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1555}
1556
Steve Antone831b8c2018-02-01 12:22:16 -08001557// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1558// options for this kind of signaling: media section based (a=msid) and ssrc
1559// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1560// we want to ensure compatibility with older Plan B endpoints that might expect
1561// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1562// types but answers with the same type as the offer.
1563
Steve Anton3172c032018-05-03 15:30:18 -07001564class PeerConnectionMsidSignalingTest
1565 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 12:22:16 -08001566
1567TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1568 auto caller = CreatePeerConnectionWithUnifiedPlan();
1569 caller->AddAudioTrack("caller_audio");
1570 auto callee = CreatePeerConnectionWithUnifiedPlan();
1571 callee->AddAudioTrack("callee_audio");
1572
1573 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1574
1575 // Offer should have had both a=msid and a=ssrc MSID lines.
1576 auto* offer = callee->pc()->remote_description();
1577 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1578 cricket::kMsidSignalingSsrcAttribute),
1579 offer->description()->msid_signaling());
1580
1581 // Answer should have had only a=msid lines.
1582 auto* answer = caller->pc()->remote_description();
1583 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1584 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 23:48:00 +01001585 // Check that this is counted correctly
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001586 EXPECT_EQ(2, webrtc::metrics::NumSamples(
1587 "WebRTC.PeerConnection.SdpSemanticNegotiated"));
1588 EXPECT_EQ(2, webrtc::metrics::NumEvents(
1589 "WebRTC.PeerConnection.SdpSemanticNegotiated",
1590 kSdpSemanticNegotiatedUnifiedPlan));
Steve Antone831b8c2018-02-01 12:22:16 -08001591}
1592
1593TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1594 auto caller = CreatePeerConnectionWithPlanB();
1595 caller->AddAudioTrack("caller_audio");
1596 auto callee = CreatePeerConnectionWithUnifiedPlan();
1597 callee->AddAudioTrack("callee_audio");
1598
1599 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1600
1601 // Offer should have only a=ssrc MSID lines.
1602 auto* offer = callee->pc()->remote_description();
1603 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1604 offer->description()->msid_signaling());
1605
1606 // Answer should have only a=ssrc MSID lines to match the offer.
1607 auto* answer = caller->pc()->remote_description();
1608 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1609 answer->description()->msid_signaling());
1610}
1611
Seth Hampson5b4f0752018-04-02 16:31:36 -07001612// This tests that a Plan B endpoint appropriately sets the remote description
1613// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1614// that signal no stream ids or multiple stream ids we expect that the Plan B
1615// endpoint always has exactly one media stream per track.
1616TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1617 const std::string kStreamId1 = "audio_stream_1";
1618 const std::string kStreamId2 = "audio_stream_2";
1619
1620 auto caller = CreatePeerConnectionWithUnifiedPlan();
1621 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1622 caller->AddVideoTrack("caller_video", {});
1623 auto callee = CreatePeerConnectionWithPlanB();
1624 callee->AddAudioTrack("callee_audio");
1625 caller->AddVideoTrack("callee_video");
1626
1627 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1628
1629 // Offer should have had both a=msid and a=ssrc MSID lines.
1630 auto* offer = callee->pc()->remote_description();
1631 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1632 cricket::kMsidSignalingSsrcAttribute),
1633 offer->description()->msid_signaling());
1634
1635 // Callee should always have 1 stream for all of it's receivers.
1636 const auto& track_events = callee->observer()->add_track_events_;
1637 ASSERT_EQ(2u, track_events.size());
1638 ASSERT_EQ(1u, track_events[0].streams.size());
1639 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1640 ASSERT_EQ(1u, track_events[1].streams.size());
1641 // This autogenerated a stream id for the empty one signalled.
1642 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1643}
1644
Steve Antone831b8c2018-02-01 12:22:16 -08001645TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1646 auto caller = CreatePeerConnectionWithUnifiedPlan();
1647 caller->AddAudioTrack("caller_audio");
1648 auto callee = CreatePeerConnectionWithUnifiedPlan();
1649 callee->AddAudioTrack("callee_audio");
1650
1651 auto offer = caller->CreateOffer();
1652 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1653 // section only.
1654 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1655
1656 ASSERT_TRUE(
1657 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1658 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1659
1660 // Answer should have only a=msid to match the offer.
1661 auto answer = callee->CreateAnswer();
1662 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1663 answer->description()->msid_signaling());
1664}
1665
Steve Anton8e20f172018-03-06 10:55:04 -08001666// Test that the correct UMA metrics are reported for simple/complex SDP.
1667
Steve Anton3172c032018-05-03 15:30:18 -07001668class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 10:55:04 -08001669
1670#ifdef HAVE_SCTP
1671TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1672 auto caller = CreatePeerConnectionWithUnifiedPlan();
1673 caller->CreateDataChannel("dc");
1674 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001675
1676 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001677 // Note that only the callee does ReportSdpFormatReceived.
1678 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1679 "WebRTC.PeerConnection.SdpFormatReceived"));
1680 EXPECT_EQ(
1681 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1682 kSdpFormatReceivedNoTracks));
Steve Anton8e20f172018-03-06 10:55:04 -08001683}
1684#endif // HAVE_SCTP
1685
1686TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1687 auto caller = CreatePeerConnectionWithUnifiedPlan();
1688 caller->AddAudioTrack("audio");
1689 caller->AddVideoTrack("video");
1690 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001691
1692 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001693 // Note that only the callee does ReportSdpFormatReceived.
1694 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1695 "WebRTC.PeerConnection.SdpFormatReceived"));
1696 EXPECT_EQ(
1697 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1698 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001699}
1700
1701TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1702 auto caller = CreatePeerConnectionWithPlanB();
1703 caller->AddVideoTrack("video"); // Video only.
1704 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001705
1706 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1707
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001708 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1709 "WebRTC.PeerConnection.SdpFormatReceived"));
1710 EXPECT_EQ(
1711 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1712 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001713}
1714
1715TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1716 auto caller = CreatePeerConnectionWithUnifiedPlan();
1717 caller->AddAudioTrack("audio1");
1718 caller->AddAudioTrack("audio2");
1719 caller->AddVideoTrack("video");
1720 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001721
1722 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001723 // Note that only the callee does ReportSdpFormatReceived.
1724 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1725 "WebRTC.PeerConnection.SdpFormatReceived"));
1726 EXPECT_EQ(
1727 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1728 kSdpFormatReceivedComplexUnifiedPlan));
Steve Anton8e20f172018-03-06 10:55:04 -08001729}
1730
1731TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1732 auto caller = CreatePeerConnectionWithPlanB();
1733 caller->AddVideoTrack("video1");
1734 caller->AddVideoTrack("video2");
1735 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001736
Steve Antonba42e992018-04-09 14:10:01 -07001737 // This fails since Unified Plan cannot set a session description with
1738 // multiple "Plan B tracks" in the same media section. But we still expect the
1739 // SDP Format to be recorded.
1740 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001741 // Note that only the callee does ReportSdpFormatReceived.
1742 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1743 "WebRTC.PeerConnection.SdpFormatReceived"));
1744 EXPECT_EQ(
1745 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1746 kSdpFormatReceivedComplexPlanB));
Steve Anton8e20f172018-03-06 10:55:04 -08001747}
1748
Henrik Boström91d039b2018-01-11 17:43:30 +01001749// Sender setups in a call.
1750
Steve Anton3172c032018-05-03 15:30:18 -07001751TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 17:43:30 +01001752 auto caller = CreatePeerConnection();
1753 auto callee = CreatePeerConnection();
1754
1755 auto track = caller->CreateAudioTrack("audio_track");
1756 auto sender1 = caller->AddTrack(track);
1757 ASSERT_TRUE(sender1);
1758 // We need to temporarily reset the track for the subsequent AddTrack() to
1759 // succeed.
1760 EXPECT_TRUE(sender1->SetTrack(nullptr));
1761 auto sender2 = caller->AddTrack(track);
1762 EXPECT_TRUE(sender2);
1763 EXPECT_TRUE(sender1->SetTrack(track));
1764
Steve Anton3172c032018-05-03 15:30:18 -07001765 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1766 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
1767 // return true, and doing |callee->SetRemoteDescription()| should work.
1768 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
1769 } else {
1770 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
1771 }
Henrik Boström91d039b2018-01-11 17:43:30 +01001772}
1773
Steve Anton3172c032018-05-03 15:30:18 -07001774INSTANTIATE_TEST_CASE_P(PeerConnectionRtpTest,
1775 PeerConnectionRtpTest,
1776 Values(SdpSemantics::kPlanB,
1777 SdpSemantics::kUnifiedPlan));
1778
Steve Anton9158ef62017-11-27 13:01:52 -08001779} // namespace webrtc