blob: 4e42b9e3b44651b47e9f8869aeda0c44a5f07044 [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visitICmp and visitFCmp functions.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000015#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000016#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000017#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000018#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000019#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000020#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000021#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000022#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000023#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000024#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000025#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000026#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000027#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000028
Chris Lattner2188e402010-01-04 07:37:31 +000029using namespace llvm;
30using namespace PatternMatch;
31
Chandler Carruth964daaa2014-04-22 02:55:47 +000032#define DEBUG_TYPE "instcombine"
33
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000034// How many times is a select replaced by one of its operands?
35STATISTIC(NumSel, "Number of select opts");
36
Chris Lattner98457102011-02-10 05:23:05 +000037
Sanjay Patel5f0217f2016-06-05 16:46:18 +000038/// Compute Result = In1+In2, returning true if the result overflowed for this
39/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000040static bool addWithOverflow(APInt &Result, const APInt &In1,
41 const APInt &In2, bool IsSigned = false) {
42 bool Overflow;
43 if (IsSigned)
44 Result = In1.sadd_ov(In2, Overflow);
45 else
46 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000047
Craig Topper6e025a32017-10-01 23:53:54 +000048 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000049}
50
Sanjay Patel5f0217f2016-06-05 16:46:18 +000051/// Compute Result = In1-In2, returning true if the result overflowed for this
52/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000053static bool subWithOverflow(APInt &Result, const APInt &In1,
54 const APInt &In2, bool IsSigned = false) {
55 bool Overflow;
56 if (IsSigned)
57 Result = In1.ssub_ov(In2, Overflow);
58 else
59 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000060
Craig Topper6e025a32017-10-01 23:53:54 +000061 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000062}
63
Balaram Makam569eaec2016-05-04 21:32:14 +000064/// Given an icmp instruction, return true if any use of this comparison is a
65/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000066static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000067 for (auto *U : I.users())
68 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000069 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000070 return false;
71}
72
Sanjay Patel5f0217f2016-06-05 16:46:18 +000073/// Given an exploded icmp instruction, return true if the comparison only
74/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
75/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000076static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000077 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000078 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000079 case ICmpInst::ICMP_SLT: // True if LHS s< 0
80 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000081 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000082 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
83 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000084 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000085 case ICmpInst::ICMP_SGT: // True if LHS s> -1
86 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000087 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000088 case ICmpInst::ICMP_UGT:
89 // True if LHS u> RHS and RHS == high-bit-mask - 1
90 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000091 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000092 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000093 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
94 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000095 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000096 default:
97 return false;
98 }
99}
100
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000101/// Returns true if the exploded icmp can be expressed as a signed comparison
102/// to zero and updates the predicate accordingly.
103/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000104/// TODO: Refactor with decomposeBitTestICmp()?
105static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000106 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000107 return false;
108
Craig Topper73ba1c82017-06-07 07:40:37 +0000109 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000110 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000111
Craig Topper73ba1c82017-06-07 07:40:37 +0000112 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000113 if (Pred == ICmpInst::ICMP_SLT) {
114 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000116 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000117 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000118 if (Pred == ICmpInst::ICMP_SGT) {
119 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000121 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000122 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000123
124 return false;
125}
126
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000127/// Given a signed integer type and a set of known zero and one bits, compute
128/// the maximum and minimum values that could have the specified known zero and
129/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000130/// TODO: Move to method on KnownBits struct?
131static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000132 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000133 assert(Known.getBitWidth() == Min.getBitWidth() &&
134 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000135 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000136 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000137
138 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
139 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000140 Min = Known.One;
141 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000142
Chris Lattner2188e402010-01-04 07:37:31 +0000143 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000144 Min.setSignBit();
145 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000146 }
147}
148
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000149/// Given an unsigned integer type and a set of known zero and one bits, compute
150/// the maximum and minimum values that could have the specified known zero and
151/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000152/// TODO: Move to method on KnownBits struct?
153static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000154 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000155 assert(Known.getBitWidth() == Min.getBitWidth() &&
156 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000157 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000158 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000159
Chris Lattner2188e402010-01-04 07:37:31 +0000160 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000161 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000162 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000163 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000164}
165
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000166/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000167/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000168/// where GV is a global variable with a constant initializer. Try to simplify
169/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000170/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
171///
172/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000173/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000174Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
175 GlobalVariable *GV,
176 CmpInst &ICI,
177 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000178 Constant *Init = GV->getInitializer();
179 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000180 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000181
Chris Lattnerfe741762012-01-31 02:55:06 +0000182 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000183 // Don't blow up on huge arrays.
184 if (ArrayElementCount > MaxArraySizeForCombine)
185 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000186
Chris Lattner2188e402010-01-04 07:37:31 +0000187 // There are many forms of this optimization we can handle, for now, just do
188 // the simple index into a single-dimensional array.
189 //
190 // Require: GEP GV, 0, i {{, constant indices}}
191 if (GEP->getNumOperands() < 3 ||
192 !isa<ConstantInt>(GEP->getOperand(1)) ||
193 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
194 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000195 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000196
197 // Check that indices after the variable are constants and in-range for the
198 // type they index. Collect the indices. This is typically for arrays of
199 // structs.
200 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000201
Chris Lattnerfe741762012-01-31 02:55:06 +0000202 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000203 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
204 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000205 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000206
Chris Lattner2188e402010-01-04 07:37:31 +0000207 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000208 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000209
Chris Lattner229907c2011-07-18 04:54:35 +0000210 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000211 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000212 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000213 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000214 EltTy = ATy->getElementType();
215 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000216 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000217 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000218
Chris Lattner2188e402010-01-04 07:37:31 +0000219 LaterIndices.push_back(IdxVal);
220 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000221
Chris Lattner2188e402010-01-04 07:37:31 +0000222 enum { Overdefined = -3, Undefined = -2 };
223
224 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000225
Chris Lattner2188e402010-01-04 07:37:31 +0000226 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
227 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
228 // and 87 is the second (and last) index. FirstTrueElement is -2 when
229 // undefined, otherwise set to the first true element. SecondTrueElement is
230 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
231 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
232
233 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
234 // form "i != 47 & i != 87". Same state transitions as for true elements.
235 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000236
Chris Lattner2188e402010-01-04 07:37:31 +0000237 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
238 /// define a state machine that triggers for ranges of values that the index
239 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
240 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
241 /// index in the range (inclusive). We use -2 for undefined here because we
242 /// use relative comparisons and don't want 0-1 to match -1.
243 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000244
Chris Lattner2188e402010-01-04 07:37:31 +0000245 // MagicBitvector - This is a magic bitvector where we set a bit if the
246 // comparison is true for element 'i'. If there are 64 elements or less in
247 // the array, this will fully represent all the comparison results.
248 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000249
Chris Lattner2188e402010-01-04 07:37:31 +0000250 // Scan the array and see if one of our patterns matches.
251 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000252 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
253 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000254 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000255
Chris Lattner2188e402010-01-04 07:37:31 +0000256 // If this is indexing an array of structures, get the structure element.
257 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000258 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000259
Chris Lattner2188e402010-01-04 07:37:31 +0000260 // If the element is masked, handle it.
261 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000262
Chris Lattner2188e402010-01-04 07:37:31 +0000263 // Find out if the comparison would be true or false for the i'th element.
264 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000265 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000266 // If the result is undef for this element, ignore it.
267 if (isa<UndefValue>(C)) {
268 // Extend range state machines to cover this element in case there is an
269 // undef in the middle of the range.
270 if (TrueRangeEnd == (int)i-1)
271 TrueRangeEnd = i;
272 if (FalseRangeEnd == (int)i-1)
273 FalseRangeEnd = i;
274 continue;
275 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000276
Chris Lattner2188e402010-01-04 07:37:31 +0000277 // If we can't compute the result for any of the elements, we have to give
278 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000279 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000280
Chris Lattner2188e402010-01-04 07:37:31 +0000281 // Otherwise, we know if the comparison is true or false for this element,
282 // update our state machines.
283 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000284
Chris Lattner2188e402010-01-04 07:37:31 +0000285 // State machine for single/double/range index comparison.
286 if (IsTrueForElt) {
287 // Update the TrueElement state machine.
288 if (FirstTrueElement == Undefined)
289 FirstTrueElement = TrueRangeEnd = i; // First true element.
290 else {
291 // Update double-compare state machine.
292 if (SecondTrueElement == Undefined)
293 SecondTrueElement = i;
294 else
295 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000296
Chris Lattner2188e402010-01-04 07:37:31 +0000297 // Update range state machine.
298 if (TrueRangeEnd == (int)i-1)
299 TrueRangeEnd = i;
300 else
301 TrueRangeEnd = Overdefined;
302 }
303 } else {
304 // Update the FalseElement state machine.
305 if (FirstFalseElement == Undefined)
306 FirstFalseElement = FalseRangeEnd = i; // First false element.
307 else {
308 // Update double-compare state machine.
309 if (SecondFalseElement == Undefined)
310 SecondFalseElement = i;
311 else
312 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000313
Chris Lattner2188e402010-01-04 07:37:31 +0000314 // Update range state machine.
315 if (FalseRangeEnd == (int)i-1)
316 FalseRangeEnd = i;
317 else
318 FalseRangeEnd = Overdefined;
319 }
320 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000321
Chris Lattner2188e402010-01-04 07:37:31 +0000322 // If this element is in range, update our magic bitvector.
323 if (i < 64 && IsTrueForElt)
324 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000325
Chris Lattner2188e402010-01-04 07:37:31 +0000326 // If all of our states become overdefined, bail out early. Since the
327 // predicate is expensive, only check it every 8 elements. This is only
328 // really useful for really huge arrays.
329 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
330 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
331 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000332 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000333 }
334
335 // Now that we've scanned the entire array, emit our new comparison(s). We
336 // order the state machines in complexity of the generated code.
337 Value *Idx = GEP->getOperand(2);
338
Matt Arsenault5aeae182013-08-19 21:40:31 +0000339 // If the index is larger than the pointer size of the target, truncate the
340 // index down like the GEP would do implicitly. We don't have to do this for
341 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000342 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000343 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000344 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
345 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000346 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000347 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000348
Chris Lattner2188e402010-01-04 07:37:31 +0000349 // If the comparison is only true for one or two elements, emit direct
350 // comparisons.
351 if (SecondTrueElement != Overdefined) {
352 // None true -> false.
353 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000354 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000355
Chris Lattner2188e402010-01-04 07:37:31 +0000356 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000357
Chris Lattner2188e402010-01-04 07:37:31 +0000358 // True for one element -> 'i == 47'.
359 if (SecondTrueElement == Undefined)
360 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000361
Chris Lattner2188e402010-01-04 07:37:31 +0000362 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000363 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000364 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000365 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000366 return BinaryOperator::CreateOr(C1, C2);
367 }
368
369 // If the comparison is only false for one or two elements, emit direct
370 // comparisons.
371 if (SecondFalseElement != Overdefined) {
372 // None false -> true.
373 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000374 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000375
Chris Lattner2188e402010-01-04 07:37:31 +0000376 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
377
378 // False for one element -> 'i != 47'.
379 if (SecondFalseElement == Undefined)
380 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000381
Chris Lattner2188e402010-01-04 07:37:31 +0000382 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000383 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000384 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000385 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000386 return BinaryOperator::CreateAnd(C1, C2);
387 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000388
Chris Lattner2188e402010-01-04 07:37:31 +0000389 // If the comparison can be replaced with a range comparison for the elements
390 // where it is true, emit the range check.
391 if (TrueRangeEnd != Overdefined) {
392 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000393
Chris Lattner2188e402010-01-04 07:37:31 +0000394 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
395 if (FirstTrueElement) {
396 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000397 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000398 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000399
Chris Lattner2188e402010-01-04 07:37:31 +0000400 Value *End = ConstantInt::get(Idx->getType(),
401 TrueRangeEnd-FirstTrueElement+1);
402 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
403 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000404
Chris Lattner2188e402010-01-04 07:37:31 +0000405 // False range check.
406 if (FalseRangeEnd != Overdefined) {
407 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
408 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
409 if (FirstFalseElement) {
410 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000411 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000412 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000413
Chris Lattner2188e402010-01-04 07:37:31 +0000414 Value *End = ConstantInt::get(Idx->getType(),
415 FalseRangeEnd-FirstFalseElement);
416 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
417 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000418
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000419 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000420 // of this load, replace it with computation that does:
421 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000422 {
Craig Topperf40110f2014-04-25 05:29:35 +0000423 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000424
425 // Look for an appropriate type:
426 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000427 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000428 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
429 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000430 else
431 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000432
Craig Topperf40110f2014-04-25 05:29:35 +0000433 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000434 Value *V = Builder.CreateIntCast(Idx, Ty, false);
435 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
436 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000437 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
438 }
Chris Lattner2188e402010-01-04 07:37:31 +0000439 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000440
Craig Topperf40110f2014-04-25 05:29:35 +0000441 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000442}
443
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000444/// Return a value that can be used to compare the *offset* implied by a GEP to
445/// zero. For example, if we have &A[i], we want to return 'i' for
446/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
447/// are involved. The above expression would also be legal to codegen as
448/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
449/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000450/// to generate the first by knowing that pointer arithmetic doesn't overflow.
451///
452/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000453///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000454static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000455 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000456 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000457
Chris Lattner2188e402010-01-04 07:37:31 +0000458 // Check to see if this gep only has a single variable index. If so, and if
459 // any constant indices are a multiple of its scale, then we can compute this
460 // in terms of the scale of the variable index. For example, if the GEP
461 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
462 // because the expression will cross zero at the same point.
463 unsigned i, e = GEP->getNumOperands();
464 int64_t Offset = 0;
465 for (i = 1; i != e; ++i, ++GTI) {
466 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
467 // Compute the aggregate offset of constant indices.
468 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000469
Chris Lattner2188e402010-01-04 07:37:31 +0000470 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000471 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000472 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000473 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000474 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000475 Offset += Size*CI->getSExtValue();
476 }
477 } else {
478 // Found our variable index.
479 break;
480 }
481 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000482
Chris Lattner2188e402010-01-04 07:37:31 +0000483 // If there are no variable indices, we must have a constant offset, just
484 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000485 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000486
Chris Lattner2188e402010-01-04 07:37:31 +0000487 Value *VariableIdx = GEP->getOperand(i);
488 // Determine the scale factor of the variable element. For example, this is
489 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000490 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000491
Chris Lattner2188e402010-01-04 07:37:31 +0000492 // Verify that there are no other variable indices. If so, emit the hard way.
493 for (++i, ++GTI; i != e; ++i, ++GTI) {
494 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000495 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000496
Chris Lattner2188e402010-01-04 07:37:31 +0000497 // Compute the aggregate offset of constant indices.
498 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000499
Chris Lattner2188e402010-01-04 07:37:31 +0000500 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000501 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000502 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000503 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000504 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000505 Offset += Size*CI->getSExtValue();
506 }
507 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000508
Chris Lattner2188e402010-01-04 07:37:31 +0000509 // Okay, we know we have a single variable index, which must be a
510 // pointer/array/vector index. If there is no offset, life is simple, return
511 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000512 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000513 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000514 if (Offset == 0) {
515 // Cast to intptrty in case a truncation occurs. If an extension is needed,
516 // we don't need to bother extending: the extension won't affect where the
517 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000518 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000519 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000520 }
Chris Lattner2188e402010-01-04 07:37:31 +0000521 return VariableIdx;
522 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000523
Chris Lattner2188e402010-01-04 07:37:31 +0000524 // Otherwise, there is an index. The computation we will do will be modulo
525 // the pointer size, so get it.
526 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 Offset &= PtrSizeMask;
529 VariableScale &= PtrSizeMask;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000530
Chris Lattner2188e402010-01-04 07:37:31 +0000531 // To do this transformation, any constant index must be a multiple of the
532 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
533 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
534 // multiple of the variable scale.
535 int64_t NewOffs = Offset / (int64_t)VariableScale;
536 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000537 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000538
Chris Lattner2188e402010-01-04 07:37:31 +0000539 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000540 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000542 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000543 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000544 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000545}
546
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000547/// Returns true if we can rewrite Start as a GEP with pointer Base
548/// and some integer offset. The nodes that need to be re-written
549/// for this transformation will be added to Explored.
550static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
551 const DataLayout &DL,
552 SetVector<Value *> &Explored) {
553 SmallVector<Value *, 16> WorkList(1, Start);
554 Explored.insert(Base);
555
556 // The following traversal gives us an order which can be used
557 // when doing the final transformation. Since in the final
558 // transformation we create the PHI replacement instructions first,
559 // we don't have to get them in any particular order.
560 //
561 // However, for other instructions we will have to traverse the
562 // operands of an instruction first, which means that we have to
563 // do a post-order traversal.
564 while (!WorkList.empty()) {
565 SetVector<PHINode *> PHIs;
566
567 while (!WorkList.empty()) {
568 if (Explored.size() >= 100)
569 return false;
570
571 Value *V = WorkList.back();
572
573 if (Explored.count(V) != 0) {
574 WorkList.pop_back();
575 continue;
576 }
577
578 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000579 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000580 // We've found some value that we can't explore which is different from
581 // the base. Therefore we can't do this transformation.
582 return false;
583
584 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
585 auto *CI = dyn_cast<CastInst>(V);
586 if (!CI->isNoopCast(DL))
587 return false;
588
589 if (Explored.count(CI->getOperand(0)) == 0)
590 WorkList.push_back(CI->getOperand(0));
591 }
592
593 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
594 // We're limiting the GEP to having one index. This will preserve
595 // the original pointer type. We could handle more cases in the
596 // future.
597 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
598 GEP->getType() != Start->getType())
599 return false;
600
601 if (Explored.count(GEP->getOperand(0)) == 0)
602 WorkList.push_back(GEP->getOperand(0));
603 }
604
605 if (WorkList.back() == V) {
606 WorkList.pop_back();
607 // We've finished visiting this node, mark it as such.
608 Explored.insert(V);
609 }
610
611 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000612 // We cannot transform PHIs on unsplittable basic blocks.
613 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
614 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000615 Explored.insert(PN);
616 PHIs.insert(PN);
617 }
618 }
619
620 // Explore the PHI nodes further.
621 for (auto *PN : PHIs)
622 for (Value *Op : PN->incoming_values())
623 if (Explored.count(Op) == 0)
624 WorkList.push_back(Op);
625 }
626
627 // Make sure that we can do this. Since we can't insert GEPs in a basic
628 // block before a PHI node, we can't easily do this transformation if
629 // we have PHI node users of transformed instructions.
630 for (Value *Val : Explored) {
631 for (Value *Use : Val->uses()) {
632
633 auto *PHI = dyn_cast<PHINode>(Use);
634 auto *Inst = dyn_cast<Instruction>(Val);
635
636 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
637 Explored.count(PHI) == 0)
638 continue;
639
640 if (PHI->getParent() == Inst->getParent())
641 return false;
642 }
643 }
644 return true;
645}
646
647// Sets the appropriate insert point on Builder where we can add
648// a replacement Instruction for V (if that is possible).
649static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
650 bool Before = true) {
651 if (auto *PHI = dyn_cast<PHINode>(V)) {
652 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
653 return;
654 }
655 if (auto *I = dyn_cast<Instruction>(V)) {
656 if (!Before)
657 I = &*std::next(I->getIterator());
658 Builder.SetInsertPoint(I);
659 return;
660 }
661 if (auto *A = dyn_cast<Argument>(V)) {
662 // Set the insertion point in the entry block.
663 BasicBlock &Entry = A->getParent()->getEntryBlock();
664 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
665 return;
666 }
667 // Otherwise, this is a constant and we don't need to set a new
668 // insertion point.
669 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
670}
671
672/// Returns a re-written value of Start as an indexed GEP using Base as a
673/// pointer.
674static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
675 const DataLayout &DL,
676 SetVector<Value *> &Explored) {
677 // Perform all the substitutions. This is a bit tricky because we can
678 // have cycles in our use-def chains.
679 // 1. Create the PHI nodes without any incoming values.
680 // 2. Create all the other values.
681 // 3. Add the edges for the PHI nodes.
682 // 4. Emit GEPs to get the original pointers.
683 // 5. Remove the original instructions.
684 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000685 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000686
687 DenseMap<Value *, Value *> NewInsts;
688 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
689
690 // Create the new PHI nodes, without adding any incoming values.
691 for (Value *Val : Explored) {
692 if (Val == Base)
693 continue;
694 // Create empty phi nodes. This avoids cyclic dependencies when creating
695 // the remaining instructions.
696 if (auto *PHI = dyn_cast<PHINode>(Val))
697 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
698 PHI->getName() + ".idx", PHI);
699 }
700 IRBuilder<> Builder(Base->getContext());
701
702 // Create all the other instructions.
703 for (Value *Val : Explored) {
704
705 if (NewInsts.find(Val) != NewInsts.end())
706 continue;
707
708 if (auto *CI = dyn_cast<CastInst>(Val)) {
709 NewInsts[CI] = NewInsts[CI->getOperand(0)];
710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
835 if (!GEPLHS->hasAllConstantIndices())
836 return nullptr;
837
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000838 // Make sure the pointers have the same type.
839 if (GEPLHS->getType() != RHS->getType())
840 return nullptr;
841
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000842 Value *PtrBase, *Index;
843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
844
845 // The set of nodes that will take part in this transformation.
846 SetVector<Value *> Nodes;
847
848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
849 return nullptr;
850
851 // We know we can re-write this as
852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
853 // Since we've only looked through inbouds GEPs we know that we
854 // can't have overflow on either side. We can therefore re-write
855 // this as:
856 // OFFSET1 cmp OFFSET2
857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
858
859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
861 // offset. Since Index is the offset of LHS to the base pointer, we will now
862 // compare the offsets instead of comparing the pointers.
863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
864}
865
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000866/// Fold comparisons between a GEP instruction and something else. At this point
867/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000868Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000869 ICmpInst::Predicate Cond,
870 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000871 // Don't transform signed compares of GEPs into index compares. Even if the
872 // GEP is inbounds, the final add of the base pointer can have signed overflow
873 // and would change the result of the icmp.
874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000875 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000876 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000877 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000878
Matt Arsenault44f60d02014-06-09 19:20:29 +0000879 // Look through bitcasts and addrspacecasts. We do not however want to remove
880 // 0 GEPs.
881 if (!isa<GetElementPtrInst>(RHS))
882 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000883
884 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000885 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
887 // This transformation (ignoring the base and scales) is valid because we
888 // know pointers can't overflow since the gep is inbounds. See if we can
889 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000891
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000893 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000894 Offset = EmitGEPOffset(GEPLHS);
895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
896 Constant::getNullValue(Offset->getType()));
897 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
898 // If the base pointers are different, but the indices are the same, just
899 // compare the base pointer.
900 if (PtrBase != GEPRHS->getOperand(0)) {
901 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
902 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
903 GEPRHS->getOperand(0)->getType();
904 if (IndicesTheSame)
905 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
906 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
907 IndicesTheSame = false;
908 break;
909 }
910
911 // If all indices are the same, just compare the base pointers.
912 if (IndicesTheSame)
David Majnemer5953d372013-06-29 10:28:04 +0000913 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000914
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000915 // If we're comparing GEPs with two base pointers that only differ in type
916 // and both GEPs have only constant indices or just one use, then fold
917 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000918 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000919 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
920 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
921 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000922 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000923 Value *LOffset = EmitGEPOffset(GEPLHS);
924 Value *ROffset = EmitGEPOffset(GEPRHS);
925
926 // If we looked through an addrspacecast between different sized address
927 // spaces, the LHS and RHS pointers are different sized
928 // integers. Truncate to the smaller one.
929 Type *LHSIndexTy = LOffset->getType();
930 Type *RHSIndexTy = ROffset->getType();
931 if (LHSIndexTy != RHSIndexTy) {
932 if (LHSIndexTy->getPrimitiveSizeInBits() <
933 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000934 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000935 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000936 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000937 }
938
Craig Topperbb4069e2017-07-07 23:16:26 +0000939 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
940 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000941 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000942 }
943
Chris Lattner2188e402010-01-04 07:37:31 +0000944 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000945 // different. Try convert this to an indexed compare by looking through
946 // PHIs/casts.
947 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000948 }
949
950 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000951 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000952 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000953 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000954
955 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000956 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000957 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000958
Stuart Hastings66a82b92011-05-14 05:55:10 +0000959 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000960 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
961 // If the GEPs only differ by one index, compare it.
962 unsigned NumDifferences = 0; // Keep track of # differences.
963 unsigned DiffOperand = 0; // The operand that differs.
964 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
965 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
966 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
967 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
968 // Irreconcilable differences.
969 NumDifferences = 2;
970 break;
971 } else {
972 if (NumDifferences++) break;
973 DiffOperand = i;
974 }
975 }
976
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +0000977 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +0000978 return replaceInstUsesWith(I, // No comparison is needed here.
Craig Topperbb4069e2017-07-07 23:16:26 +0000979 Builder.getInt1(ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +0000980
Stuart Hastings66a82b92011-05-14 05:55:10 +0000981 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +0000982 Value *LHSV = GEPLHS->getOperand(DiffOperand);
983 Value *RHSV = GEPRHS->getOperand(DiffOperand);
984 // Make sure we do a signed comparison here.
985 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
986 }
987 }
988
989 // Only lower this if the icmp is the only user of the GEP or if we expect
990 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000991 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +0000992 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
993 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
994 Value *L = EmitGEPOffset(GEPLHS);
995 Value *R = EmitGEPOffset(GEPRHS);
996 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
997 }
998 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000999
1000 // Try convert this to an indexed compare by looking through PHIs/casts as a
1001 // last resort.
1002 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001003}
1004
Pete Cooper980a9352016-08-12 17:13:28 +00001005Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1006 const AllocaInst *Alloca,
1007 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001008 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1009
1010 // It would be tempting to fold away comparisons between allocas and any
1011 // pointer not based on that alloca (e.g. an argument). However, even
1012 // though such pointers cannot alias, they can still compare equal.
1013 //
1014 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1015 // doesn't escape we can argue that it's impossible to guess its value, and we
1016 // can therefore act as if any such guesses are wrong.
1017 //
1018 // The code below checks that the alloca doesn't escape, and that it's only
1019 // used in a comparison once (the current instruction). The
1020 // single-comparison-use condition ensures that we're trivially folding all
1021 // comparisons against the alloca consistently, and avoids the risk of
1022 // erroneously folding a comparison of the pointer with itself.
1023
1024 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1025
Pete Cooper980a9352016-08-12 17:13:28 +00001026 SmallVector<const Use *, 32> Worklist;
1027 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001028 if (Worklist.size() >= MaxIter)
1029 return nullptr;
1030 Worklist.push_back(&U);
1031 }
1032
1033 unsigned NumCmps = 0;
1034 while (!Worklist.empty()) {
1035 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001036 const Use *U = Worklist.pop_back_val();
1037 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001038 --MaxIter;
1039
1040 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1041 isa<SelectInst>(V)) {
1042 // Track the uses.
1043 } else if (isa<LoadInst>(V)) {
1044 // Loading from the pointer doesn't escape it.
1045 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001046 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001047 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1048 if (SI->getValueOperand() == U->get())
1049 return nullptr;
1050 continue;
1051 } else if (isa<ICmpInst>(V)) {
1052 if (NumCmps++)
1053 return nullptr; // Found more than one cmp.
1054 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001055 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001056 switch (Intrin->getIntrinsicID()) {
1057 // These intrinsics don't escape or compare the pointer. Memset is safe
1058 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1059 // we don't allow stores, so src cannot point to V.
1060 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001061 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1062 continue;
1063 default:
1064 return nullptr;
1065 }
1066 } else {
1067 return nullptr;
1068 }
Pete Cooper980a9352016-08-12 17:13:28 +00001069 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001070 if (Worklist.size() >= MaxIter)
1071 return nullptr;
1072 Worklist.push_back(&U);
1073 }
1074 }
1075
1076 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001077 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001078 ICI,
1079 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1080}
1081
Sanjay Patel5f0217f2016-06-05 16:46:18 +00001082/// Fold "icmp pred (X+CI), X".
Craig Toppera85f8622017-08-23 05:46:09 +00001083Instruction *InstCombiner::foldICmpAddOpConst(Value *X, ConstantInt *CI,
Sanjay Patel43395062016-07-21 18:07:40 +00001084 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001085 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001086 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001087 // operators.
Jim Grosbach129c52a2011-09-30 18:09:53 +00001088
Chris Lattner8c92b572010-01-08 17:48:19 +00001089 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001090 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1091 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1092 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00001093 Value *R =
Chris Lattner8c92b572010-01-08 17:48:19 +00001094 ConstantExpr::getSub(ConstantInt::getAllOnesValue(CI->getType()), CI);
Chris Lattner2188e402010-01-04 07:37:31 +00001095 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1096 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001097
Chris Lattner2188e402010-01-04 07:37:31 +00001098 // (X+1) >u X --> X <u (0-1) --> X != 255
1099 // (X+2) >u X --> X <u (0-2) --> X <u 254
1100 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001101 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Chris Lattner2188e402010-01-04 07:37:31 +00001102 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantExpr::getNeg(CI));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001103
Chris Lattner2188e402010-01-04 07:37:31 +00001104 unsigned BitWidth = CI->getType()->getPrimitiveSizeInBits();
1105 ConstantInt *SMax = ConstantInt::get(X->getContext(),
1106 APInt::getSignedMaxValue(BitWidth));
1107
1108 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1109 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1110 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1111 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1112 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1113 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001114 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Chris Lattner2188e402010-01-04 07:37:31 +00001115 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantExpr::getSub(SMax, CI));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001116
Chris Lattner2188e402010-01-04 07:37:31 +00001117 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1118 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1119 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1120 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1121 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1122 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001123
Chris Lattner2188e402010-01-04 07:37:31 +00001124 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbb4069e2017-07-07 23:16:26 +00001125 Constant *C = Builder.getInt(CI->getValue() - 1);
Chris Lattner2188e402010-01-04 07:37:31 +00001126 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantExpr::getSub(SMax, C));
1127}
1128
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001129/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1130/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1131/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1132Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1133 const APInt &AP1,
1134 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001135 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1136
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001137 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1138 if (I.getPredicate() == I.ICMP_NE)
1139 Pred = CmpInst::getInversePredicate(Pred);
1140 return new ICmpInst(Pred, LHS, RHS);
1141 };
1142
David Majnemer2abb8182014-10-25 07:13:13 +00001143 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001144 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001145 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001146
1147 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001148 if (IsAShr) {
1149 if (AP2.isAllOnesValue())
1150 return nullptr;
1151 if (AP2.isNegative() != AP1.isNegative())
1152 return nullptr;
1153 if (AP2.sgt(AP1))
1154 return nullptr;
1155 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001156
David Majnemerd2056022014-10-21 19:51:55 +00001157 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001158 // 'A' must be large enough to shift out the highest set bit.
1159 return getICmp(I.ICMP_UGT, A,
1160 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001161
David Majnemerd2056022014-10-21 19:51:55 +00001162 if (AP1 == AP2)
1163 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001164
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001165 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001166 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001167 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001168 else
David Majnemere5977eb2015-09-19 00:48:26 +00001169 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001170
David Majnemerd2056022014-10-21 19:51:55 +00001171 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001172 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1173 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001174 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001175 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1176 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001177 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001178 } else if (AP1 == AP2.lshr(Shift)) {
1179 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1180 }
David Majnemerd2056022014-10-21 19:51:55 +00001181 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001182
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001183 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001184 // FIXME: This should always be handled by InstSimplify?
1185 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1186 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001187}
Chris Lattner2188e402010-01-04 07:37:31 +00001188
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001189/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1190/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1191Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1192 const APInt &AP1,
1193 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001194 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1195
David Majnemer59939ac2014-10-19 08:23:08 +00001196 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1197 if (I.getPredicate() == I.ICMP_NE)
1198 Pred = CmpInst::getInversePredicate(Pred);
1199 return new ICmpInst(Pred, LHS, RHS);
1200 };
1201
David Majnemer2abb8182014-10-25 07:13:13 +00001202 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001203 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001204 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001205
1206 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1207
1208 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001209 return getICmp(
1210 I.ICMP_UGE, A,
1211 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001212
1213 if (AP1 == AP2)
1214 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1215
1216 // Get the distance between the lowest bits that are set.
1217 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1218
1219 if (Shift > 0 && AP2.shl(Shift) == AP1)
1220 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1221
1222 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001223 // FIXME: This should always be handled by InstSimplify?
1224 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1225 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001226}
1227
Sanjay Patel06b127a2016-09-15 14:37:50 +00001228/// The caller has matched a pattern of the form:
1229/// I = icmp ugt (add (add A, B), CI2), CI1
1230/// If this is of the form:
1231/// sum = a + b
1232/// if (sum+128 >u 255)
1233/// Then replace it with llvm.sadd.with.overflow.i8.
1234///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001235static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001236 ConstantInt *CI2, ConstantInt *CI1,
1237 InstCombiner &IC) {
1238 // The transformation we're trying to do here is to transform this into an
1239 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1240 // with a narrower add, and discard the add-with-constant that is part of the
1241 // range check (if we can't eliminate it, this isn't profitable).
1242
1243 // In order to eliminate the add-with-constant, the compare can be its only
1244 // use.
1245 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1246 if (!AddWithCst->hasOneUse())
1247 return nullptr;
1248
1249 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1250 if (!CI2->getValue().isPowerOf2())
1251 return nullptr;
1252 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1253 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1254 return nullptr;
1255
1256 // The width of the new add formed is 1 more than the bias.
1257 ++NewWidth;
1258
1259 // Check to see that CI1 is an all-ones value with NewWidth bits.
1260 if (CI1->getBitWidth() == NewWidth ||
1261 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1262 return nullptr;
1263
1264 // This is only really a signed overflow check if the inputs have been
1265 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1266 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1267 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1268 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1269 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1270 return nullptr;
1271
1272 // In order to replace the original add with a narrower
1273 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1274 // and truncates that discard the high bits of the add. Verify that this is
1275 // the case.
1276 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1277 for (User *U : OrigAdd->users()) {
1278 if (U == AddWithCst)
1279 continue;
1280
1281 // Only accept truncates for now. We would really like a nice recursive
1282 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1283 // chain to see which bits of a value are actually demanded. If the
1284 // original add had another add which was then immediately truncated, we
1285 // could still do the transformation.
1286 TruncInst *TI = dyn_cast<TruncInst>(U);
1287 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1288 return nullptr;
1289 }
1290
1291 // If the pattern matches, truncate the inputs to the narrower type and
1292 // use the sadd_with_overflow intrinsic to efficiently compute both the
1293 // result and the overflow bit.
1294 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
1295 Value *F = Intrinsic::getDeclaration(I.getModule(),
1296 Intrinsic::sadd_with_overflow, NewType);
1297
Craig Topperbb4069e2017-07-07 23:16:26 +00001298 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001299
1300 // Put the new code above the original add, in case there are any uses of the
1301 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001302 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001303
Craig Topperbb4069e2017-07-07 23:16:26 +00001304 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1305 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1306 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1307 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1308 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001309
1310 // The inner add was the result of the narrow add, zero extended to the
1311 // wider type. Replace it with the result computed by the intrinsic.
1312 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1313
1314 // The original icmp gets replaced with the overflow value.
1315 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1316}
1317
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001318// Handle (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1319Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1320 CmpInst::Predicate Pred = Cmp.getPredicate();
1321 Value *X = Cmp.getOperand(0);
1322
1323 if (match(Cmp.getOperand(1), m_Zero()) && Pred == ICmpInst::ICMP_SGT) {
1324 Value *A, *B;
1325 SelectPatternResult SPR = matchSelectPattern(X, A, B);
1326 if (SPR.Flavor == SPF_SMIN) {
1327 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1328 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1329 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1330 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1331 }
1332 }
1333 return nullptr;
1334}
1335
Sanjay Patel06b127a2016-09-15 14:37:50 +00001336// Fold icmp Pred X, C.
Sanjay Patel97459832016-09-15 15:11:12 +00001337Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
1338 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001339 Value *X = Cmp.getOperand(0);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001340
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001341 const APInt *C;
1342 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel97459832016-09-15 15:11:12 +00001343 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001344
Sanjay Patel97459832016-09-15 15:11:12 +00001345 Value *A = nullptr, *B = nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001346
Sanjay Patel97459832016-09-15 15:11:12 +00001347 // Match the following pattern, which is a common idiom when writing
1348 // overflow-safe integer arithmetic functions. The source performs an addition
1349 // in wider type and explicitly checks for overflow using comparisons against
1350 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1351 //
1352 // TODO: This could probably be generalized to handle other overflow-safe
1353 // operations if we worked out the formulas to compute the appropriate magic
1354 // constants.
1355 //
1356 // sum = a + b
1357 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
1358 {
1359 ConstantInt *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1360 if (Pred == ICmpInst::ICMP_UGT &&
1361 match(X, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001362 if (Instruction *Res = processUGT_ADDCST_ADD(
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001363 Cmp, A, B, CI2, cast<ConstantInt>(Cmp.getOperand(1)), *this))
Sanjay Patel97459832016-09-15 15:11:12 +00001364 return Res;
1365 }
Sanjay Patel06b127a2016-09-15 14:37:50 +00001366
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001367 // FIXME: Use m_APInt to allow folds for splat constants.
1368 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1));
1369 if (!CI)
1370 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001371
Sanjay Patel97459832016-09-15 15:11:12 +00001372 // Canonicalize icmp instructions based on dominating conditions.
1373 BasicBlock *Parent = Cmp.getParent();
1374 BasicBlock *Dom = Parent->getSinglePredecessor();
1375 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr;
1376 ICmpInst::Predicate Pred2;
1377 BasicBlock *TrueBB, *FalseBB;
1378 ConstantInt *CI2;
1379 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)),
1380 TrueBB, FalseBB)) &&
1381 TrueBB != FalseBB) {
1382 ConstantRange CR =
1383 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue());
1384 ConstantRange DominatingCR =
1385 (Parent == TrueBB)
1386 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue())
1387 : ConstantRange::makeExactICmpRegion(
1388 CmpInst::getInversePredicate(Pred2), CI2->getValue());
1389 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1390 ConstantRange Difference = DominatingCR.difference(CR);
1391 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001392 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001393 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001394 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001395
Sanjay Patel97459832016-09-15 15:11:12 +00001396 // If this is a normal comparison, it demands all bits. If it is a sign
1397 // bit comparison, it only demands the sign bit.
1398 bool UnusedBit;
1399 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit);
1400
1401 // Canonicalizing a sign bit comparison that gets used in a branch,
1402 // pessimizes codegen by generating branch on zero instruction instead
1403 // of a test and branch. So we avoid canonicalizing in such situations
1404 // because test and branch instruction has better branch displacement
1405 // than compare and branch instruction.
Eric Christophera95aac32017-06-30 01:57:48 +00001406 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1407 return nullptr;
1408
1409 if (auto *AI = Intersection.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001410 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*AI));
Eric Christophera95aac32017-06-30 01:57:48 +00001411 if (auto *AD = Difference.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001412 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*AD));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001413 }
1414
1415 return nullptr;
1416}
1417
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001418/// Fold icmp (trunc X, Y), C.
1419Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001420 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001421 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001422 ICmpInst::Predicate Pred = Cmp.getPredicate();
1423 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001424 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001425 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1426 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001427 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001428 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1429 ConstantInt::get(V->getType(), 1));
1430 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001431
1432 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001433 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1434 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001435 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1436 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001437 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001438
1439 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001440 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001441 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001442 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001443 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001444 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001445 }
1446 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001447
Sanjay Patela3f4f082016-08-16 17:54:36 +00001448 return nullptr;
1449}
1450
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001451/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001452Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1453 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001454 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001455 Value *X = Xor->getOperand(0);
1456 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001457 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001458 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001459 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001460
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001461 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1462 // fold the xor.
1463 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001464 bool TrueIfSigned = false;
1465 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001466
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001467 // If the sign bit of the XorCst is not set, there is no change to
1468 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001469 if (!XorC->isNegative()) {
1470 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001471 Worklist.Add(Xor);
1472 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001473 }
1474
Craig Topperdf63b962017-10-03 19:14:23 +00001475 // Emit the opposite comparison.
1476 if (TrueIfSigned)
1477 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1478 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001479 else
Craig Topperdf63b962017-10-03 19:14:23 +00001480 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1481 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001482 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001483
1484 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001485 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1486 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001487 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1488 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001489 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001490 }
1491
Craig Topperbcfd2d12017-04-20 16:56:25 +00001492 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001493 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1494 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1495 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001496 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001497 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001498 }
1499 }
1500
1501 // (icmp ugt (xor X, C), ~C) -> (icmp ult X, C)
1502 // iff -C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001503 if (Pred == ICmpInst::ICMP_UGT && *XorC == ~C && (C + 1).isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001504 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001505
1506 // (icmp ult (xor X, C), -C) -> (icmp uge X, C)
1507 // iff -C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001508 if (Pred == ICmpInst::ICMP_ULT && *XorC == -C && C.isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001509 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001510
Sanjay Patela3f4f082016-08-16 17:54:36 +00001511 return nullptr;
1512}
1513
Sanjay Patel14e0e182016-08-26 18:28:46 +00001514/// Fold icmp (and (sh X, Y), C2), C1.
1515Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001516 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001517 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1518 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001519 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001520
Sanjay Patelda9c5622016-08-26 17:15:22 +00001521 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1522 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1523 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001524 // This seemingly simple opportunity to fold away a shift turns out to be
1525 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001526 unsigned ShiftOpcode = Shift->getOpcode();
1527 bool IsShl = ShiftOpcode == Instruction::Shl;
1528 const APInt *C3;
1529 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001530 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001531 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001532 // For a left shift, we can fold if the comparison is not signed. We can
1533 // also fold a signed comparison if the mask value and comparison value
1534 // are not negative. These constraints may not be obvious, but we can
1535 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001536 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001537 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001538 } else {
1539 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001540 // For a logical right shift, we can fold if the comparison is not signed.
1541 // We can also fold a signed comparison if the shifted mask value and the
1542 // shifted comparison value are not negative. These constraints may not be
1543 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001544 // For an arithmetic shift right we can do the same, if we ensure
1545 // the And doesn't use any bits being shifted in. Normally these would
1546 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1547 // additional user.
1548 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1549 if (!Cmp.isSigned() ||
1550 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1551 CanFold = true;
1552 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001553 }
1554
Sanjay Patelda9c5622016-08-26 17:15:22 +00001555 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001556 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001557 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001558 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001559 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001560 // If we shifted bits out, the fold is not going to work out. As a
1561 // special case, check to see if this means that the result is always
1562 // true or false now.
1563 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001564 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001565 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001566 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001567 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001568 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001569 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001570 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001571 And->setOperand(0, Shift->getOperand(0));
1572 Worklist.Add(Shift); // Shift is dead.
1573 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001574 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001575 }
1576 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001577
Sanjay Patelda9c5622016-08-26 17:15:22 +00001578 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1579 // preferable because it allows the C2 << Y expression to be hoisted out of a
1580 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001581 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001582 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1583 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001584 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001585 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1586 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001587
Sanjay Patelda9c5622016-08-26 17:15:22 +00001588 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001589 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001590 Cmp.setOperand(0, NewAnd);
1591 return &Cmp;
1592 }
1593
Sanjay Patel14e0e182016-08-26 18:28:46 +00001594 return nullptr;
1595}
1596
1597/// Fold icmp (and X, C2), C1.
1598Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1599 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001600 const APInt &C1) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001601 const APInt *C2;
1602 if (!match(And->getOperand(1), m_APInt(C2)))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001603 return nullptr;
1604
Craig Topper8bf62212017-09-26 18:47:25 +00001605 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001606 return nullptr;
1607
Sanjay Patel6b490972016-09-04 14:32:15 +00001608 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1609 // the input width without changing the value produced, eliminate the cast:
1610 //
1611 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1612 //
1613 // We can do this transformation if the constants do not have their sign bits
1614 // set or if it is an equality comparison. Extending a relational comparison
1615 // when we're checking the sign bit would not work.
1616 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001617 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001618 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001619 // TODO: Is this a good transform for vectors? Wider types may reduce
1620 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001621 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001622 if (!Cmp.getType()->isVectorTy()) {
1623 Type *WideType = W->getType();
1624 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001625 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001626 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001627 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001628 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001629 }
1630 }
1631
Craig Topper8ed1aa92017-10-03 05:31:07 +00001632 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001633 return I;
1634
Sanjay Patelda9c5622016-08-26 17:15:22 +00001635 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001636 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001637 //
1638 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001639 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001640 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001641 Constant *One = cast<Constant>(And->getOperand(1));
1642 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001643 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001644 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1645 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1646 unsigned UsesRemoved = 0;
1647 if (And->hasOneUse())
1648 ++UsesRemoved;
1649 if (Or->hasOneUse())
1650 ++UsesRemoved;
1651 if (LShr->hasOneUse())
1652 ++UsesRemoved;
1653
1654 // Compute A & ((1 << B) | 1)
1655 Value *NewOr = nullptr;
1656 if (auto *C = dyn_cast<Constant>(B)) {
1657 if (UsesRemoved >= 1)
1658 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1659 } else {
1660 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001661 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1662 /*HasNUW=*/true),
1663 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001664 }
1665 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001666 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001667 Cmp.setOperand(0, NewAnd);
1668 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001669 }
1670 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001671 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001672
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001673 return nullptr;
1674}
1675
1676/// Fold icmp (and X, Y), C.
1677Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1678 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001679 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001680 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1681 return I;
1682
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001683 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001684
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001685 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1686 Value *X = And->getOperand(0);
1687 Value *Y = And->getOperand(1);
1688 if (auto *LI = dyn_cast<LoadInst>(X))
1689 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1690 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001691 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001692 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1693 ConstantInt *C2 = cast<ConstantInt>(Y);
1694 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001695 return Res;
1696 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001697
1698 if (!Cmp.isEquality())
1699 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001700
1701 // X & -C == -C -> X > u ~C
1702 // X & -C != -C -> X <= u ~C
1703 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001704 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001705 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1706 : CmpInst::ICMP_ULE;
1707 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1708 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001709
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001710 // (X & C2) == 0 -> (trunc X) >= 0
1711 // (X & C2) != 0 -> (trunc X) < 0
1712 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1713 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001714 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001715 int32_t ExactLogBase2 = C2->exactLogBase2();
1716 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1717 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1718 if (And->getType()->isVectorTy())
1719 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001720 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001721 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1722 : CmpInst::ICMP_SLT;
1723 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001724 }
1725 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001726
Sanjay Patela3f4f082016-08-16 17:54:36 +00001727 return nullptr;
1728}
1729
Sanjay Patel943e92e2016-08-17 16:30:43 +00001730/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001731Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001732 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001733 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001734 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001735 // icmp slt signum(V) 1 --> icmp slt V, 1
1736 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001737 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001738 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1739 ConstantInt::get(V->getType(), 1));
1740 }
1741
Sanjay Patel50c82c42017-04-05 17:57:05 +00001742 // X | C == C --> X <=u C
1743 // X | C != C --> X >u C
1744 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1745 if (Cmp.isEquality() && Cmp.getOperand(1) == Or->getOperand(1) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001746 (C + 1).isPowerOf2()) {
Sanjay Patel50c82c42017-04-05 17:57:05 +00001747 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1748 return new ICmpInst(Pred, Or->getOperand(0), Or->getOperand(1));
1749 }
1750
Craig Topper8ed1aa92017-10-03 05:31:07 +00001751 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001752 return nullptr;
1753
1754 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001755 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001756 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1757 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001758 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001759 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001760 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001761 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001762 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1763 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1764 }
1765
1766 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1767 // a shorter form that has more potential to be folded even further.
1768 Value *X1, *X2, *X3, *X4;
1769 if (match(Or->getOperand(0), m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1770 match(Or->getOperand(1), m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
1771 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1772 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1773 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1774 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1775 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1776 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001777 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001778
Sanjay Patela3f4f082016-08-16 17:54:36 +00001779 return nullptr;
1780}
1781
Sanjay Patel63478072016-08-18 15:44:44 +00001782/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001783Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1784 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001785 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001786 const APInt *MulC;
1787 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001788 return nullptr;
1789
Sanjay Patel63478072016-08-18 15:44:44 +00001790 // If this is a test of the sign bit and the multiply is sign-preserving with
1791 // a constant operand, use the multiply LHS operand instead.
1792 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001793 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001794 if (MulC->isNegative())
1795 Pred = ICmpInst::getSwappedPredicate(Pred);
1796 return new ICmpInst(Pred, Mul->getOperand(0),
1797 Constant::getNullValue(Mul->getType()));
1798 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001799
1800 return nullptr;
1801}
1802
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001803/// Fold icmp (shl 1, Y), C.
1804static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001805 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001806 Value *Y;
1807 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1808 return nullptr;
1809
1810 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001811 unsigned TypeBits = C.getBitWidth();
1812 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001813 ICmpInst::Predicate Pred = Cmp.getPredicate();
1814 if (Cmp.isUnsigned()) {
1815 // (1 << Y) pred C -> Y pred Log2(C)
1816 if (!CIsPowerOf2) {
1817 // (1 << Y) < 30 -> Y <= 4
1818 // (1 << Y) <= 30 -> Y <= 4
1819 // (1 << Y) >= 30 -> Y > 4
1820 // (1 << Y) > 30 -> Y > 4
1821 if (Pred == ICmpInst::ICMP_ULT)
1822 Pred = ICmpInst::ICMP_ULE;
1823 else if (Pred == ICmpInst::ICMP_UGE)
1824 Pred = ICmpInst::ICMP_UGT;
1825 }
1826
1827 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1828 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001829 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001830 if (CLog2 == TypeBits - 1) {
1831 if (Pred == ICmpInst::ICMP_UGE)
1832 Pred = ICmpInst::ICMP_EQ;
1833 else if (Pred == ICmpInst::ICMP_ULT)
1834 Pred = ICmpInst::ICMP_NE;
1835 }
1836 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1837 } else if (Cmp.isSigned()) {
1838 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001839 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001840 // (1 << Y) <= -1 -> Y == 31
1841 if (Pred == ICmpInst::ICMP_SLE)
1842 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1843
1844 // (1 << Y) > -1 -> Y != 31
1845 if (Pred == ICmpInst::ICMP_SGT)
1846 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001847 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001848 // (1 << Y) < 0 -> Y == 31
1849 // (1 << Y) <= 0 -> Y == 31
1850 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1851 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1852
1853 // (1 << Y) >= 0 -> Y != 31
1854 // (1 << Y) > 0 -> Y != 31
1855 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1856 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1857 }
1858 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001859 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001860 }
1861
1862 return nullptr;
1863}
1864
Sanjay Patel38b75062016-08-19 17:20:37 +00001865/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001866Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1867 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001868 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001869 const APInt *ShiftVal;
1870 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001871 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001872
Sanjay Patelfa7de602016-08-19 22:33:26 +00001873 const APInt *ShiftAmt;
1874 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001875 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001876
Sanjay Patel38b75062016-08-19 17:20:37 +00001877 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001878 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001879 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001880 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001881 return nullptr;
1882
Sanjay Patele38e79c2016-08-19 17:34:05 +00001883 ICmpInst::Predicate Pred = Cmp.getPredicate();
1884 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001885 Type *ShType = Shl->getType();
1886
Sanjay Patel291c3d82017-01-19 16:12:10 +00001887 // NSW guarantees that we are only shifting out sign bits from the high bits,
1888 // so we can ASHR the compare constant without needing a mask and eliminate
1889 // the shift.
1890 if (Shl->hasNoSignedWrap()) {
1891 if (Pred == ICmpInst::ICMP_SGT) {
1892 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001893 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001894 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1895 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001896 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1897 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001898 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001899 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1900 }
1901 if (Pred == ICmpInst::ICMP_SLT) {
1902 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
1903 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
1904 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
1905 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00001906 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
1907 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00001908 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1909 }
1910 // If this is a signed comparison to 0 and the shift is sign preserving,
1911 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
1912 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001913 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00001914 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
1915 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001916
Sanjay Patel291c3d82017-01-19 16:12:10 +00001917 // NUW guarantees that we are only shifting out zero bits from the high bits,
1918 // so we can LSHR the compare constant without needing a mask and eliminate
1919 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00001920 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00001921 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00001922 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001923 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001924 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1925 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001926 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1927 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001928 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00001929 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1930 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001931 if (Pred == ICmpInst::ICMP_ULT) {
1932 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
1933 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
1934 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
1935 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00001936 assert(C.ugt(0) && "ult 0 should have been eliminated");
1937 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00001938 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1939 }
1940 }
1941
Sanjay Patel291c3d82017-01-19 16:12:10 +00001942 if (Cmp.isEquality() && Shl->hasOneUse()) {
1943 // Strength-reduce the shift into an 'and'.
1944 Constant *Mask = ConstantInt::get(
1945 ShType,
1946 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00001947 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00001948 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00001949 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001950 }
1951
Sanjay Patela3f4f082016-08-16 17:54:36 +00001952 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
1953 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001954 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00001955 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00001956 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00001957 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00001958 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00001959 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00001960 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00001961 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00001962 }
1963
Sanjay Patel643d21a2016-08-21 17:10:07 +00001964 // Transform (icmp pred iM (shl iM %v, N), C)
1965 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
1966 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00001967 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00001968 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00001969 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00001970 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001971 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00001972 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00001973 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001974 if (ShType->isVectorTy())
1975 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00001976 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00001977 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00001978 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001979 }
1980
1981 return nullptr;
1982}
1983
Sanjay Patela3920492016-08-22 20:45:06 +00001984/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001985Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
1986 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001987 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00001988 // An exact shr only shifts out zero bits, so:
1989 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00001990 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00001991 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00001992 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001993 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00001994 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00001995
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001996 const APInt *ShiftVal;
1997 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001998 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001999
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002000 const APInt *ShiftAmt;
2001 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002002 return nullptr;
2003
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002004 // Check that the shift amount is in range. If not, don't perform undefined
2005 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002006 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002007 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002008 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2009 return nullptr;
2010
Sanjay Pateld64e9882016-08-23 22:05:55 +00002011 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002012 bool IsExact = Shr->isExact();
2013 Type *ShrTy = Shr->getType();
2014 // TODO: If we could guarantee that InstSimplify would handle all of the
2015 // constant-value-based preconditions in the folds below, then we could assert
2016 // those conditions rather than checking them. This is difficult because of
2017 // undef/poison (PR34838).
2018 if (IsAShr) {
2019 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2020 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2021 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2022 APInt ShiftedC = C.shl(ShAmtVal);
2023 if (ShiftedC.ashr(ShAmtVal) == C)
2024 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2025 }
2026 if (Pred == CmpInst::ICMP_SGT) {
2027 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2028 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2029 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2030 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2031 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2032 }
2033 } else {
2034 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2035 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2036 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2037 APInt ShiftedC = C.shl(ShAmtVal);
2038 if (ShiftedC.lshr(ShAmtVal) == C)
2039 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2040 }
2041 if (Pred == CmpInst::ICMP_UGT) {
2042 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2043 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2044 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2045 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2046 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002047 }
2048
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002049 if (!Cmp.isEquality())
2050 return nullptr;
2051
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002052 // Handle equality comparisons of shift-by-constant.
2053
Sanjay Patel8e297742016-08-24 13:55:55 +00002054 // If the comparison constant changes with the shift, the comparison cannot
2055 // succeed (bits of the comparison constant cannot match the shifted value).
2056 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002057 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2058 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002059 "Expected icmp+shr simplify did not occur.");
2060
Sanjay Patel934738a2017-10-15 15:39:15 +00002061 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002062 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002063 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002064 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002065
Sanjay Patel934738a2017-10-15 15:39:15 +00002066 if (Shr->hasOneUse()) {
2067 // Canonicalize the shift into an 'and':
2068 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002069 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002070 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002071 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002072 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002073 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002074
2075 return nullptr;
2076}
2077
Sanjay Patel12a41052016-08-18 17:37:26 +00002078/// Fold icmp (udiv X, Y), C.
2079Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002080 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002081 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002082 const APInt *C2;
2083 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2084 return nullptr;
2085
Craig Topper29c282e2017-06-07 07:40:29 +00002086 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002087
2088 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2089 Value *Y = UDiv->getOperand(1);
2090 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002091 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002092 "icmp ugt X, UINT_MAX should have been simplified already.");
2093 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002094 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002095 }
2096
2097 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2098 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002099 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002100 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002101 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002102 }
2103
2104 return nullptr;
2105}
2106
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002107/// Fold icmp ({su}div X, Y), C.
2108Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2109 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002110 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002111 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002112 // Fold this div into the comparison, producing a range check.
2113 // Determine, based on the divide type, what the range is being
2114 // checked. If there is an overflow on the low or high side, remember
2115 // it, otherwise compute the range [low, hi) bounding the new value.
2116 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002117 const APInt *C2;
2118 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002119 return nullptr;
2120
Sanjay Patel16554142016-08-24 23:03:36 +00002121 // FIXME: If the operand types don't match the type of the divide
2122 // then don't attempt this transform. The code below doesn't have the
2123 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002124 // vice versa). This is because (x /s C2) <s C produces different
2125 // results than (x /s C2) <u C or (x /u C2) <s C or even
2126 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002127 // work. :( The if statement below tests that condition and bails
2128 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002129 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2130 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002131 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002132
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002133 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2134 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2135 // division-by-constant cases should be present, we can not assert that they
2136 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002137 if (C2->isNullValue() || C2->isOneValue() ||
2138 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002139 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002140
Craig Topper6e025a32017-10-01 23:53:54 +00002141 // Compute Prod = C * C2. We are essentially solving an equation of
2142 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002143 // By solving for X, we can turn this into a range check instead of computing
2144 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002145 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002146
Sanjay Patel541aef42016-08-31 21:57:21 +00002147 // Determine if the product overflows by seeing if the product is not equal to
2148 // the divide. Make sure we do the same kind of divide as in the LHS
2149 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002150 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002151
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002152 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002153
2154 // If the division is known to be exact, then there is no remainder from the
2155 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002156 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002157
2158 // Figure out the interval that is being checked. For example, a comparison
2159 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2160 // Compute this interval based on the constants involved and the signedness of
2161 // the compare/divide. This computes a half-open interval, keeping track of
2162 // whether either value in the interval overflows. After analysis each
2163 // overflow variable is set to 0 if it's corresponding bound variable is valid
2164 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2165 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002166 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002167
2168 if (!DivIsSigned) { // udiv
2169 // e.g. X/5 op 3 --> [15, 20)
2170 LoBound = Prod;
2171 HiOverflow = LoOverflow = ProdOV;
2172 if (!HiOverflow) {
2173 // If this is not an exact divide, then many values in the range collapse
2174 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002175 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002176 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002177 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002178 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002179 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002180 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002181 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002182 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002183 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2184 HiOverflow = LoOverflow = ProdOV;
2185 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002186 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002187 } else { // (X / pos) op neg
2188 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002189 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002190 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2191 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002192 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002193 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002194 }
2195 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002196 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002197 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002198 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002199 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002200 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002201 LoBound = RangeSize + 1;
2202 HiBound = -RangeSize;
2203 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002204 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002205 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002206 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002207 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002208 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002209 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002210 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2211 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002212 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002213 } else { // (X / neg) op neg
2214 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2215 LoOverflow = HiOverflow = ProdOV;
2216 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002217 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002218 }
2219
2220 // Dividing by a negative swaps the condition. LT <-> GT
2221 Pred = ICmpInst::getSwappedPredicate(Pred);
2222 }
2223
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002224 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002225 switch (Pred) {
2226 default: llvm_unreachable("Unhandled icmp opcode!");
2227 case ICmpInst::ICMP_EQ:
2228 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002229 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002230 if (HiOverflow)
2231 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002232 ICmpInst::ICMP_UGE, X,
2233 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002234 if (LoOverflow)
2235 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002236 ICmpInst::ICMP_ULT, X,
2237 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002238 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002239 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002240 case ICmpInst::ICMP_NE:
2241 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002242 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002243 if (HiOverflow)
2244 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002245 ICmpInst::ICMP_ULT, X,
2246 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002247 if (LoOverflow)
2248 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002249 ICmpInst::ICMP_UGE, X,
2250 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002251 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002252 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002253 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002254 case ICmpInst::ICMP_ULT:
2255 case ICmpInst::ICMP_SLT:
2256 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002257 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002258 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002259 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002260 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002261 case ICmpInst::ICMP_UGT:
2262 case ICmpInst::ICMP_SGT:
2263 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002264 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002265 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002266 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002267 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002268 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2269 ConstantInt::get(Div->getType(), HiBound));
2270 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2271 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002272 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002273
2274 return nullptr;
2275}
2276
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002277/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002278Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2279 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002280 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002281 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2282 ICmpInst::Predicate Pred = Cmp.getPredicate();
2283
2284 // The following transforms are only worth it if the only user of the subtract
2285 // is the icmp.
2286 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002287 return nullptr;
2288
Sanjay Patel886a5422016-09-15 18:05:17 +00002289 if (Sub->hasNoSignedWrap()) {
2290 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002291 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002292 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002293
Sanjay Patel886a5422016-09-15 18:05:17 +00002294 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002295 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002296 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2297
2298 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002299 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002300 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2301
2302 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002303 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002304 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2305 }
2306
2307 const APInt *C2;
2308 if (!match(X, m_APInt(C2)))
2309 return nullptr;
2310
2311 // C2 - Y <u C -> (Y | (C - 1)) == C2
2312 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002313 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2314 (*C2 & (C - 1)) == (C - 1))
2315 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002316
2317 // C2 - Y >u C -> (Y | C) != C2
2318 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002319 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2320 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002321
2322 return nullptr;
2323}
2324
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002325/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002326Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2327 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002328 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002329 Value *Y = Add->getOperand(1);
2330 const APInt *C2;
2331 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002332 return nullptr;
2333
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002334 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002335 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002336 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002337 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002338
2339 // If the add does not wrap, we can always adjust the compare by subtracting
2340 // the constants. Equality comparisons are handled elsewhere. SGE/SLE are
2341 // canonicalized to SGT/SLT.
2342 if (Add->hasNoSignedWrap() &&
2343 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) {
2344 bool Overflow;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002345 APInt NewC = C.ssub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002346 // If there is overflow, the result must be true or false.
2347 // TODO: Can we assert there is no overflow because InstSimplify always
2348 // handles those cases?
2349 if (!Overflow)
2350 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2351 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2352 }
2353
Craig Topper8ed1aa92017-10-03 05:31:07 +00002354 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002355 const APInt &Upper = CR.getUpper();
2356 const APInt &Lower = CR.getLower();
2357 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002358 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002359 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002360 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002361 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002362 } else {
2363 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002364 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002365 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002366 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002367 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002368
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002369 if (!Add->hasOneUse())
2370 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00002371
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002372 // X+C <u C2 -> (X & -C2) == C
2373 // iff C & (C2-1) == 0
2374 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002375 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2376 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002377 ConstantExpr::getNeg(cast<Constant>(Y)));
2378
2379 // X+C >u C2 -> (X & ~C2) != C
2380 // iff C & C2 == 0
2381 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002382 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2383 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002384 ConstantExpr::getNeg(cast<Constant>(Y)));
2385
Sanjay Patela3f4f082016-08-16 17:54:36 +00002386 return nullptr;
2387}
2388
Anna Thomasd67165c2017-06-23 13:41:45 +00002389bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2390 Value *&RHS, ConstantInt *&Less,
2391 ConstantInt *&Equal,
2392 ConstantInt *&Greater) {
2393 // TODO: Generalize this to work with other comparison idioms or ensure
2394 // they get canonicalized into this form.
2395
2396 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2397 // Greater), where Equal, Less and Greater are placeholders for any three
2398 // constants.
2399 ICmpInst::Predicate PredA, PredB;
2400 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2401 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2402 PredA == ICmpInst::ICMP_EQ &&
2403 match(SI->getFalseValue(),
2404 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2405 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2406 PredB == ICmpInst::ICMP_SLT) {
2407 return true;
2408 }
2409 return false;
2410}
2411
2412Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002413 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002414 ConstantInt *C) {
2415
2416 assert(C && "Cmp RHS should be a constant int!");
2417 // If we're testing a constant value against the result of a three way
2418 // comparison, the result can be expressed directly in terms of the
2419 // original values being compared. Note: We could possibly be more
2420 // aggressive here and remove the hasOneUse test. The original select is
2421 // really likely to simplify or sink when we remove a test of the result.
2422 Value *OrigLHS, *OrigRHS;
2423 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2424 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002425 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2426 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002427 assert(C1LessThan && C2Equal && C3GreaterThan);
2428
2429 bool TrueWhenLessThan =
2430 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2431 ->isAllOnesValue();
2432 bool TrueWhenEqual =
2433 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2434 ->isAllOnesValue();
2435 bool TrueWhenGreaterThan =
2436 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2437 ->isAllOnesValue();
2438
2439 // This generates the new instruction that will replace the original Cmp
2440 // Instruction. Instead of enumerating the various combinations when
2441 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2442 // false, we rely on chaining of ORs and future passes of InstCombine to
2443 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2444
2445 // When none of the three constants satisfy the predicate for the RHS (C),
2446 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002447 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002448 if (TrueWhenLessThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002449 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002450 if (TrueWhenEqual)
Craig Topperbb4069e2017-07-07 23:16:26 +00002451 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002452 if (TrueWhenGreaterThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002453 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002454
2455 return replaceInstUsesWith(Cmp, Cond);
2456 }
2457 return nullptr;
2458}
2459
Daniel Neilson901acfa2018-04-03 17:26:20 +00002460Instruction *InstCombiner::foldICmpBitCastConstant(ICmpInst &Cmp,
2461 BitCastInst *Bitcast,
2462 const APInt &C) {
2463 // Folding: icmp <pred> iN X, C
2464 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2465 // and C is a splat of a K-bit pattern
2466 // and SC is a constant vector = <C', C', C', ..., C'>
2467 // Into:
2468 // %E = extractelement <M x iK> %vec, i32 C'
2469 // icmp <pred> iK %E, trunc(C)
2470 if (!Bitcast->getType()->isIntegerTy() ||
2471 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2472 return nullptr;
2473
2474 Value *BCIOp = Bitcast->getOperand(0);
2475 Value *Vec = nullptr; // 1st vector arg of the shufflevector
2476 Constant *Mask = nullptr; // Mask arg of the shufflevector
2477 if (match(BCIOp,
2478 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2479 // Check whether every element of Mask is the same constant
2480 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
2481 auto *VecTy = cast<VectorType>(BCIOp->getType());
2482 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
2483 auto Pred = Cmp.getPredicate();
2484 if (C.isSplat(EltTy->getBitWidth())) {
2485 // Fold the icmp based on the value of C
2486 // If C is M copies of an iK sized bit pattern,
2487 // then:
2488 // => %E = extractelement <N x iK> %vec, i32 Elem
2489 // icmp <pred> iK %SplatVal, <pattern>
2490 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
2491 Value *NewC = ConstantInt::get(EltTy, C.trunc(EltTy->getBitWidth()));
2492 return new ICmpInst(Pred, Extract, NewC);
2493 }
2494 }
2495 }
2496 return nullptr;
2497}
2498
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002499/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2500/// where X is some kind of instruction.
2501Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002502 const APInt *C;
2503 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002504 return nullptr;
2505
Craig Toppera94069f2017-08-23 05:46:08 +00002506 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002507 switch (BO->getOpcode()) {
2508 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002509 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002510 return I;
2511 break;
2512 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002513 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002514 return I;
2515 break;
2516 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002517 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002518 return I;
2519 break;
2520 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002521 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002522 return I;
2523 break;
2524 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002525 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002526 return I;
2527 break;
2528 case Instruction::LShr:
2529 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002530 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002531 return I;
2532 break;
2533 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002534 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002535 return I;
2536 LLVM_FALLTHROUGH;
2537 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002538 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002539 return I;
2540 break;
2541 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002542 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002543 return I;
2544 break;
2545 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002546 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002547 return I;
2548 break;
2549 default:
2550 break;
2551 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002552 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002553 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002554 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002555 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002556
Anna Thomasd67165c2017-06-23 13:41:45 +00002557 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002558
2559 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2560 // For now, we only support constant integers while folding the
2561 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2562 // similar to the cases handled by binary ops above.
2563 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2564 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002565 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002566 }
2567
2568 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002569 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002570 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002571 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002572
Daniel Neilson901acfa2018-04-03 17:26:20 +00002573 if (auto *BCI = dyn_cast<BitCastInst>(Cmp.getOperand(0))) {
2574 if (Instruction *I = foldICmpBitCastConstant(Cmp, BCI, *C))
2575 return I;
2576 }
2577
Craig Topper8ed1aa92017-10-03 05:31:07 +00002578 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002579 return I;
2580
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002581 return nullptr;
2582}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002583
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002584/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2585/// icmp eq/ne BO, C.
2586Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2587 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002588 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002589 // TODO: Some of these folds could work with arbitrary constants, but this
2590 // function is limited to scalar and vector splat constants.
2591 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002592 return nullptr;
2593
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002594 ICmpInst::Predicate Pred = Cmp.getPredicate();
2595 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2596 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002597 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002598
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002599 switch (BO->getOpcode()) {
2600 case Instruction::SRem:
2601 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002602 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002603 const APInt *BOC;
2604 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002605 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002606 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002607 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002608 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002609 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002610 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002611 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002612 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002613 const APInt *BOC;
2614 if (match(BOp1, m_APInt(BOC))) {
2615 if (BO->hasOneUse()) {
2616 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002617 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002618 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002619 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002620 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2621 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002622 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002623 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002624 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002625 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002626 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002627 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002628 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002629 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002630 }
2631 }
2632 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002633 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002634 case Instruction::Xor:
2635 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002636 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002637 // For the xor case, we can xor two constants together, eliminating
2638 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002639 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002640 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002641 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002642 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002643 }
2644 }
2645 break;
2646 case Instruction::Sub:
2647 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002648 const APInt *BOC;
2649 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002650 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002651 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002652 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002653 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002654 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002655 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002656 }
2657 }
2658 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002659 case Instruction::Or: {
2660 const APInt *BOC;
2661 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002662 // Comparing if all bits outside of a constant mask are set?
2663 // Replace (X | C) == -1 with (X & ~C) == ~C.
2664 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002665 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002666 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002667 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002668 }
2669 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002670 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002671 case Instruction::And: {
2672 const APInt *BOC;
2673 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002674 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002675 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002676 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002677 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002678
2679 // Don't perform the following transforms if the AND has multiple uses
2680 if (!BO->hasOneUse())
2681 break;
2682
2683 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0
Craig Topperbcfd2d12017-04-20 16:56:25 +00002684 if (BOC->isSignMask()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002685 Constant *Zero = Constant::getNullValue(BOp0->getType());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002686 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
2687 return new ICmpInst(NewPred, BOp0, Zero);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002688 }
2689
2690 // ((X & ~7) == 0) --> X < 8
Craig Topper8ed1aa92017-10-03 05:31:07 +00002691 if (C.isNullValue() && (~(*BOC) + 1).isPowerOf2()) {
Sanjay Pateld938e882016-08-04 20:05:02 +00002692 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002693 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
2694 return new ICmpInst(NewPred, BOp0, NegBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002695 }
2696 }
2697 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002698 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002699 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002700 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002701 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002702 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002703 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002704 // General case : (mul X, C) != 0 iff X != 0
2705 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002706 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002707 }
2708 }
2709 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002710 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002711 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002712 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002713 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2714 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002715 }
2716 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002717 default:
2718 break;
2719 }
2720 return nullptr;
2721}
2722
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002723/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2724Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002725 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002726 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0));
2727 if (!II || !Cmp.isEquality())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002728 return nullptr;
2729
Sanjay Patelb51e0722017-07-02 16:05:11 +00002730 // Handle icmp {eq|ne} <intrinsic>, Constant.
2731 Type *Ty = II->getType();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002732 switch (II->getIntrinsicID()) {
2733 case Intrinsic::bswap:
2734 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002735 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002736 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002737 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002738
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002739 case Intrinsic::ctlz:
2740 case Intrinsic::cttz:
Amaury Sechet6bea6742016-08-04 05:27:20 +00002741 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002742 if (C == C.getBitWidth()) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002743 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002744 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002745 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002746 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002747 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002748 break;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002749
Amaury Sechet6bea6742016-08-04 05:27:20 +00002750 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002751 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002752 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002753 bool IsZero = C.isNullValue();
2754 if (IsZero || C == C.getBitWidth()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002755 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002756 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002757 auto *NewOp =
2758 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002759 Cmp.setOperand(1, NewOp);
2760 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002761 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002762 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002763 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002764 default:
2765 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002766 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002767
Craig Topperf40110f2014-04-25 05:29:35 +00002768 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002769}
2770
Sanjay Patel10494b22016-09-16 16:10:22 +00002771/// Handle icmp with constant (but not simple integer constant) RHS.
2772Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
2773 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2774 Constant *RHSC = dyn_cast<Constant>(Op1);
2775 Instruction *LHSI = dyn_cast<Instruction>(Op0);
2776 if (!RHSC || !LHSI)
2777 return nullptr;
2778
2779 switch (LHSI->getOpcode()) {
2780 case Instruction::GetElementPtr:
2781 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
2782 if (RHSC->isNullValue() &&
2783 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
2784 return new ICmpInst(
2785 I.getPredicate(), LHSI->getOperand(0),
2786 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2787 break;
2788 case Instruction::PHI:
2789 // Only fold icmp into the PHI if the phi and icmp are in the same
2790 // block. If in the same block, we're encouraging jump threading. If
2791 // not, we are just pessimizing the code by making an i1 phi.
2792 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00002793 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00002794 return NV;
2795 break;
2796 case Instruction::Select: {
2797 // If either operand of the select is a constant, we can fold the
2798 // comparison into the select arms, which will cause one to be
2799 // constant folded and the select turned into a bitwise or.
2800 Value *Op1 = nullptr, *Op2 = nullptr;
2801 ConstantInt *CI = nullptr;
2802 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
2803 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2804 CI = dyn_cast<ConstantInt>(Op1);
2805 }
2806 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
2807 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2808 CI = dyn_cast<ConstantInt>(Op2);
2809 }
2810
2811 // We only want to perform this transformation if it will not lead to
2812 // additional code. This is true if either both sides of the select
2813 // fold to a constant (in which case the icmp is replaced with a select
2814 // which will usually simplify) or this is the only user of the
2815 // select (in which case we are trading a select+icmp for a simpler
2816 // select+icmp) or all uses of the select can be replaced based on
2817 // dominance information ("Global cases").
2818 bool Transform = false;
2819 if (Op1 && Op2)
2820 Transform = true;
2821 else if (Op1 || Op2) {
2822 // Local case
2823 if (LHSI->hasOneUse())
2824 Transform = true;
2825 // Global cases
2826 else if (CI && !CI->isZero())
2827 // When Op1 is constant try replacing select with second operand.
2828 // Otherwise Op2 is constant and try replacing select with first
2829 // operand.
2830 Transform =
2831 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
2832 }
2833 if (Transform) {
2834 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00002835 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
2836 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002837 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00002838 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
2839 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002840 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
2841 }
2842 break;
2843 }
2844 case Instruction::IntToPtr:
2845 // icmp pred inttoptr(X), null -> icmp pred X, 0
2846 if (RHSC->isNullValue() &&
2847 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
2848 return new ICmpInst(
2849 I.getPredicate(), LHSI->getOperand(0),
2850 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2851 break;
2852
2853 case Instruction::Load:
2854 // Try to optimize things like "A[i] > 4" to index computations.
2855 if (GetElementPtrInst *GEP =
2856 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
2857 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
2858 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
2859 !cast<LoadInst>(LHSI)->isVolatile())
2860 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
2861 return Res;
2862 }
2863 break;
2864 }
2865
2866 return nullptr;
2867}
2868
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002869/// Some comparisons can be simplified.
2870/// In this case, we are looking for comparisons that look like
2871/// a check for a lossy truncation.
2872/// Folds:
2873/// x & (-1 >> y) SrcPred x to x DstPred (-1 >> y)
2874/// The Mask can be a constant, too.
2875static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
2876 InstCombiner::BuilderTy &Builder) {
2877 ICmpInst::Predicate SrcPred;
2878 Value *X, *M;
2879 auto m_Mask = m_CombineOr(m_LShr(m_AllOnes(), m_Value()), m_LowBitMask());
2880 if (!match(&I, m_c_ICmp(SrcPred,
2881 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
2882 m_Deferred(X))))
2883 return nullptr;
2884
2885 ICmpInst::Predicate DstPred;
2886 switch (SrcPred) {
2887 case ICmpInst::Predicate::ICMP_EQ:
2888 // x & (-1 >> y) == x -> x u<= (-1 >> y)
2889 DstPred = ICmpInst::Predicate::ICMP_ULE;
2890 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00002891 case ICmpInst::Predicate::ICMP_NE:
2892 // x & (-1 >> y) != x -> x u> (-1 >> y)
2893 DstPred = ICmpInst::Predicate::ICMP_UGT;
2894 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00002895 case ICmpInst::Predicate::ICMP_UGT:
2896 // x u> x & (-1 >> y) -> x u> (-1 >> y)
2897 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
2898 DstPred = ICmpInst::Predicate::ICMP_UGT;
2899 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00002900 case ICmpInst::Predicate::ICMP_UGE:
2901 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
2902 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
2903 DstPred = ICmpInst::Predicate::ICMP_ULE;
2904 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00002905 case ICmpInst::Predicate::ICMP_ULT:
2906 // x & (-1 >> y) u< x -> x u> (-1 >> y)
2907 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
2908 DstPred = ICmpInst::Predicate::ICMP_UGT;
2909 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00002910 case ICmpInst::Predicate::ICMP_ULE:
2911 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
2912 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
2913 DstPred = ICmpInst::Predicate::ICMP_ULE;
2914 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00002915 case ICmpInst::Predicate::ICMP_SGT:
2916 // x s> x & (-1 >> y) -> x s> (-1 >> y)
2917 if (X != I.getOperand(0)) // X must be on LHS of comparison!
2918 return nullptr; // Ignore the other case.
2919 DstPred = ICmpInst::Predicate::ICMP_SGT;
2920 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002921 // TODO: more folds are possible, https://bugs.llvm.org/show_bug.cgi?id=38123
2922 default:
2923 return nullptr;
2924 }
2925
2926 return Builder.CreateICmp(DstPred, X, M);
2927}
2928
Sanjay Patel10494b22016-09-16 16:10:22 +00002929/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00002930/// TODO: A large part of this logic is duplicated in InstSimplify's
2931/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
2932/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00002933Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
2934 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2935
2936 // Special logic for binary operators.
2937 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
2938 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
2939 if (!BO0 && !BO1)
2940 return nullptr;
2941
Sanjay Patel2a062632017-05-08 16:33:42 +00002942 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00002943 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
2944 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
2945 NoOp0WrapProblem =
2946 ICmpInst::isEquality(Pred) ||
2947 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
2948 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
2949 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
2950 NoOp1WrapProblem =
2951 ICmpInst::isEquality(Pred) ||
2952 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
2953 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
2954
2955 // Analyze the case when either Op0 or Op1 is an add instruction.
2956 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
2957 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
2958 if (BO0 && BO0->getOpcode() == Instruction::Add) {
2959 A = BO0->getOperand(0);
2960 B = BO0->getOperand(1);
2961 }
2962 if (BO1 && BO1->getOpcode() == Instruction::Add) {
2963 C = BO1->getOperand(0);
2964 D = BO1->getOperand(1);
2965 }
2966
Sanjay Patel10494b22016-09-16 16:10:22 +00002967 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
2968 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
2969 return new ICmpInst(Pred, A == Op1 ? B : A,
2970 Constant::getNullValue(Op1->getType()));
2971
2972 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
2973 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
2974 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
2975 C == Op0 ? D : C);
2976
2977 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
2978 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
2979 NoOp1WrapProblem &&
2980 // Try not to increase register pressure.
2981 BO0->hasOneUse() && BO1->hasOneUse()) {
2982 // Determine Y and Z in the form icmp (X+Y), (X+Z).
2983 Value *Y, *Z;
2984 if (A == C) {
2985 // C + B == C + D -> B == D
2986 Y = B;
2987 Z = D;
2988 } else if (A == D) {
2989 // D + B == C + D -> B == C
2990 Y = B;
2991 Z = C;
2992 } else if (B == C) {
2993 // A + C == C + D -> A == D
2994 Y = A;
2995 Z = D;
2996 } else {
2997 assert(B == D);
2998 // A + D == C + D -> A == C
2999 Y = A;
3000 Z = C;
3001 }
3002 return new ICmpInst(Pred, Y, Z);
3003 }
3004
3005 // icmp slt (X + -1), Y -> icmp sle X, Y
3006 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3007 match(B, m_AllOnes()))
3008 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3009
3010 // icmp sge (X + -1), Y -> icmp sgt X, Y
3011 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3012 match(B, m_AllOnes()))
3013 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3014
3015 // icmp sle (X + 1), Y -> icmp slt X, Y
3016 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3017 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3018
3019 // icmp sgt (X + 1), Y -> icmp sge X, Y
3020 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3021 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3022
3023 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3024 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3025 match(D, m_AllOnes()))
3026 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3027
3028 // icmp sle X, (Y + -1) -> icmp slt X, Y
3029 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3030 match(D, m_AllOnes()))
3031 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3032
3033 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3034 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3035 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3036
3037 // icmp slt X, (Y + 1) -> icmp sle X, Y
3038 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3039 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3040
Sanjay Patel40f40172017-01-13 23:25:46 +00003041 // TODO: The subtraction-related identities shown below also hold, but
3042 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3043 // wouldn't happen even if they were implemented.
3044 //
3045 // icmp ult (X - 1), Y -> icmp ule X, Y
3046 // icmp uge (X - 1), Y -> icmp ugt X, Y
3047 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3048 // icmp ule X, (Y - 1) -> icmp ult X, Y
3049
3050 // icmp ule (X + 1), Y -> icmp ult X, Y
3051 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3052 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3053
3054 // icmp ugt (X + 1), Y -> icmp uge X, Y
3055 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3056 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3057
3058 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3059 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3060 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3061
3062 // icmp ult X, (Y + 1) -> icmp ule X, Y
3063 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3064 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3065
Sanjay Patel10494b22016-09-16 16:10:22 +00003066 // if C1 has greater magnitude than C2:
3067 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3068 // s.t. C3 = C1 - C2
3069 //
3070 // if C2 has greater magnitude than C1:
3071 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3072 // s.t. C3 = C2 - C1
3073 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3074 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3075 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3076 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3077 const APInt &AP1 = C1->getValue();
3078 const APInt &AP2 = C2->getValue();
3079 if (AP1.isNegative() == AP2.isNegative()) {
3080 APInt AP1Abs = C1->getValue().abs();
3081 APInt AP2Abs = C2->getValue().abs();
3082 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003083 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3084 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003085 return new ICmpInst(Pred, NewAdd, C);
3086 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003087 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3088 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003089 return new ICmpInst(Pred, A, NewAdd);
3090 }
3091 }
3092 }
3093
3094 // Analyze the case when either Op0 or Op1 is a sub instruction.
3095 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3096 A = nullptr;
3097 B = nullptr;
3098 C = nullptr;
3099 D = nullptr;
3100 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3101 A = BO0->getOperand(0);
3102 B = BO0->getOperand(1);
3103 }
3104 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3105 C = BO1->getOperand(0);
3106 D = BO1->getOperand(1);
3107 }
3108
3109 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3110 if (A == Op1 && NoOp0WrapProblem)
3111 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003112 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3113 if (C == Op0 && NoOp1WrapProblem)
3114 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3115
Sanjay Patelcbb04502018-04-02 20:37:40 +00003116 // (A - B) >u A --> A <u B
3117 if (A == Op1 && Pred == ICmpInst::ICMP_UGT)
3118 return new ICmpInst(ICmpInst::ICMP_ULT, A, B);
3119 // C <u (C - D) --> C <u D
3120 if (C == Op0 && Pred == ICmpInst::ICMP_ULT)
3121 return new ICmpInst(ICmpInst::ICMP_ULT, C, D);
3122
Sanjay Patel10494b22016-09-16 16:10:22 +00003123 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3124 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3125 // Try not to increase register pressure.
3126 BO0->hasOneUse() && BO1->hasOneUse())
3127 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003128 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3129 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3130 // Try not to increase register pressure.
3131 BO0->hasOneUse() && BO1->hasOneUse())
3132 return new ICmpInst(Pred, D, B);
3133
3134 // icmp (0-X) < cst --> x > -cst
3135 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3136 Value *X;
3137 if (match(BO0, m_Neg(m_Value(X))))
3138 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1))
3139 if (!RHSC->isMinValue(/*isSigned=*/true))
3140 return new ICmpInst(I.getSwappedPredicate(), X,
3141 ConstantExpr::getNeg(RHSC));
3142 }
3143
3144 BinaryOperator *SRem = nullptr;
3145 // icmp (srem X, Y), Y
3146 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3147 SRem = BO0;
3148 // icmp Y, (srem X, Y)
3149 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3150 Op0 == BO1->getOperand(1))
3151 SRem = BO1;
3152 if (SRem) {
3153 // We don't check hasOneUse to avoid increasing register pressure because
3154 // the value we use is the same value this instruction was already using.
3155 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3156 default:
3157 break;
3158 case ICmpInst::ICMP_EQ:
3159 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3160 case ICmpInst::ICMP_NE:
3161 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3162 case ICmpInst::ICMP_SGT:
3163 case ICmpInst::ICMP_SGE:
3164 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3165 Constant::getAllOnesValue(SRem->getType()));
3166 case ICmpInst::ICMP_SLT:
3167 case ICmpInst::ICMP_SLE:
3168 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3169 Constant::getNullValue(SRem->getType()));
3170 }
3171 }
3172
3173 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3174 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3175 switch (BO0->getOpcode()) {
3176 default:
3177 break;
3178 case Instruction::Add:
3179 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003180 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003181 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003182 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003183
3184 const APInt *C;
3185 if (match(BO0->getOperand(1), m_APInt(C))) {
3186 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3187 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003188 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003189 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003190 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003191 }
3192
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003193 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3194 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003195 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003196 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003197 NewPred = I.getSwappedPredicate(NewPred);
3198 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003199 }
3200 }
3201 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003202 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003203 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003204 if (!I.isEquality())
3205 break;
3206
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003207 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003208 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3209 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003210 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3211 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003212 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003213 Constant *Mask = ConstantInt::get(
3214 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003215 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003216 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3217 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003218 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003219 }
Sanjay Patel51506122017-05-25 14:13:57 +00003220 // If there are no trailing zeros in the multiplier, just eliminate
3221 // the multiplies (no masking is needed):
3222 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3223 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003224 }
3225 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003226 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003227 case Instruction::UDiv:
3228 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003229 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003230 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003231 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3232
Sanjay Patel10494b22016-09-16 16:10:22 +00003233 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003234 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3235 break;
3236 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3237
Sanjay Patel10494b22016-09-16 16:10:22 +00003238 case Instruction::AShr:
3239 if (!BO0->isExact() || !BO1->isExact())
3240 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003241 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003242
Sanjay Patel10494b22016-09-16 16:10:22 +00003243 case Instruction::Shl: {
3244 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3245 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3246 if (!NUW && !NSW)
3247 break;
3248 if (!NSW && I.isSigned())
3249 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003250 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003251 }
3252 }
3253 }
3254
3255 if (BO0) {
3256 // Transform A & (L - 1) `ult` L --> L != 0
3257 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003258 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003259
Sanjay Patel2a062632017-05-08 16:33:42 +00003260 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003261 auto *Zero = Constant::getNullValue(BO0->getType());
3262 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3263 }
3264 }
3265
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003266 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3267 return replaceInstUsesWith(I, V);
3268
Sanjay Patel10494b22016-09-16 16:10:22 +00003269 return nullptr;
3270}
3271
Sanjay Pateldd46b522016-12-19 17:32:37 +00003272/// Fold icmp Pred min|max(X, Y), X.
3273static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003274 ICmpInst::Predicate Pred = Cmp.getPredicate();
3275 Value *Op0 = Cmp.getOperand(0);
3276 Value *X = Cmp.getOperand(1);
3277
Sanjay Pateldd46b522016-12-19 17:32:37 +00003278 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003279 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003280 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3281 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3282 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003283 std::swap(Op0, X);
3284 Pred = Cmp.getSwappedPredicate();
3285 }
3286
3287 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003288 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003289 // smin(X, Y) == X --> X s<= Y
3290 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003291 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3292 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3293
Sanjay Pateldd46b522016-12-19 17:32:37 +00003294 // smin(X, Y) != X --> X s> Y
3295 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003296 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3297 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3298
3299 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003300 // smin(X, Y) s<= X --> true
3301 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003302 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003303 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003304
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003305 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003306 // smax(X, Y) == X --> X s>= Y
3307 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003308 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3309 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003310
Sanjay Pateldd46b522016-12-19 17:32:37 +00003311 // smax(X, Y) != X --> X s< Y
3312 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003313 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3314 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003315
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003316 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003317 // smax(X, Y) s>= X --> true
3318 // smax(X, Y) s< X --> false
3319 return nullptr;
3320 }
3321
3322 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3323 // umin(X, Y) == X --> X u<= Y
3324 // umin(X, Y) u>= X --> X u<= Y
3325 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3326 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3327
3328 // umin(X, Y) != X --> X u> Y
3329 // umin(X, Y) u< X --> X u> Y
3330 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3331 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3332
3333 // These cases should be handled in InstSimplify:
3334 // umin(X, Y) u<= X --> true
3335 // umin(X, Y) u> X --> false
3336 return nullptr;
3337 }
3338
3339 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3340 // umax(X, Y) == X --> X u>= Y
3341 // umax(X, Y) u<= X --> X u>= Y
3342 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3343 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3344
3345 // umax(X, Y) != X --> X u< Y
3346 // umax(X, Y) u> X --> X u< Y
3347 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3348 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3349
3350 // These cases should be handled in InstSimplify:
3351 // umax(X, Y) u>= X --> true
3352 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003353 return nullptr;
3354 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003355
Sanjay Pateld6406412016-12-15 19:13:37 +00003356 return nullptr;
3357}
3358
Sanjay Patel10494b22016-09-16 16:10:22 +00003359Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3360 if (!I.isEquality())
3361 return nullptr;
3362
3363 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003364 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003365 Value *A, *B, *C, *D;
3366 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3367 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3368 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003369 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003370 }
3371
3372 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3373 // A^c1 == C^c2 --> A == C^(c1^c2)
3374 ConstantInt *C1, *C2;
3375 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3376 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003377 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3378 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003379 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003380 }
3381
3382 // A^B == A^D -> B == D
3383 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003384 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003385 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003386 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003387 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003388 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003389 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003390 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003391 }
3392 }
3393
3394 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3395 // A == (A^B) -> B == 0
3396 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003397 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003398 }
3399
3400 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3401 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3402 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3403 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3404
3405 if (A == C) {
3406 X = B;
3407 Y = D;
3408 Z = A;
3409 } else if (A == D) {
3410 X = B;
3411 Y = C;
3412 Z = A;
3413 } else if (B == C) {
3414 X = A;
3415 Y = D;
3416 Z = B;
3417 } else if (B == D) {
3418 X = A;
3419 Y = C;
3420 Z = B;
3421 }
3422
3423 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003424 Op1 = Builder.CreateXor(X, Y);
3425 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003426 I.setOperand(0, Op1);
3427 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3428 return &I;
3429 }
3430 }
3431
3432 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3433 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3434 ConstantInt *Cst1;
3435 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3436 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3437 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3438 match(Op1, m_ZExt(m_Value(A))))) {
3439 APInt Pow2 = Cst1->getValue() + 1;
3440 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3441 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003442 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003443 }
3444
3445 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3446 // For lshr and ashr pairs.
3447 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3448 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3449 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3450 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3451 unsigned TypeBits = Cst1->getBitWidth();
3452 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3453 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003454 ICmpInst::Predicate NewPred =
3455 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003456 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003457 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003458 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003459 }
3460 }
3461
3462 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3463 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3464 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3465 unsigned TypeBits = Cst1->getBitWidth();
3466 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3467 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003468 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003469 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003470 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003471 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003472 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003473 }
3474 }
3475
3476 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3477 // "icmp (and X, mask), cst"
3478 uint64_t ShAmt = 0;
3479 if (Op0->hasOneUse() &&
3480 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3481 match(Op1, m_ConstantInt(Cst1)) &&
3482 // Only do this when A has multiple uses. This is most important to do
3483 // when it exposes other optimizations.
3484 !A->hasOneUse()) {
3485 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3486
3487 if (ShAmt < ASize) {
3488 APInt MaskV =
3489 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3490 MaskV <<= ShAmt;
3491
3492 APInt CmpV = Cst1->getValue().zext(ASize);
3493 CmpV <<= ShAmt;
3494
Craig Topperbb4069e2017-07-07 23:16:26 +00003495 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
3496 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00003497 }
3498 }
3499
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003500 // If both operands are byte-swapped or bit-reversed, just compare the
3501 // original values.
3502 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
3503 // and handle more intrinsics.
3504 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00003505 (match(Op0, m_BitReverse(m_Value(A))) &&
3506 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003507 return new ICmpInst(Pred, A, B);
3508
Sanjay Patel10494b22016-09-16 16:10:22 +00003509 return nullptr;
3510}
3511
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003512/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3513/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003514Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003515 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003516 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003517 Type *SrcTy = LHSCIOp->getType();
3518 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003519 Value *RHSCIOp;
3520
Jim Grosbach129c52a2011-09-30 18:09:53 +00003521 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003522 // integer type is the same size as the pointer type.
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003523 const auto& CompatibleSizes = [&](Type* SrcTy, Type* DestTy) -> bool {
3524 if (isa<VectorType>(SrcTy)) {
3525 SrcTy = cast<VectorType>(SrcTy)->getElementType();
3526 DestTy = cast<VectorType>(DestTy)->getElementType();
3527 }
3528 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
3529 };
Mehdi Aminia28d91d2015-03-10 02:37:25 +00003530 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003531 CompatibleSizes(SrcTy, DestTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +00003532 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003533 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00003534 Value *RHSCIOp = RHSC->getOperand(0);
3535 if (RHSCIOp->getType()->getPointerAddressSpace() ==
3536 LHSCIOp->getType()->getPointerAddressSpace()) {
3537 RHSOp = RHSC->getOperand(0);
3538 // If the pointer types don't match, insert a bitcast.
3539 if (LHSCIOp->getType() != RHSOp->getType())
Craig Topperbb4069e2017-07-07 23:16:26 +00003540 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType());
Michael Liaod266b922015-02-13 04:51:26 +00003541 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003542 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003543 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003544 }
Chris Lattner2188e402010-01-04 07:37:31 +00003545
3546 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003547 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003548 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003549
Chris Lattner2188e402010-01-04 07:37:31 +00003550 // The code below only handles extension cast instructions, so far.
3551 // Enforce this.
3552 if (LHSCI->getOpcode() != Instruction::ZExt &&
3553 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00003554 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003555
3556 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003557 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00003558
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003559 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003560 // Not an extension from the same type?
3561 RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003562 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00003563 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00003564
Chris Lattner2188e402010-01-04 07:37:31 +00003565 // If the signedness of the two casts doesn't agree (i.e. one is a sext
3566 // and the other is a zext), then we can't handle this.
3567 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00003568 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003569
3570 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003571 if (ICmp.isEquality())
3572 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003573
3574 // A signed comparison of sign extended values simplifies into a
3575 // signed comparison.
3576 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003577 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003578
3579 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003580 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003581 }
3582
Sanjay Patel4c204232016-06-04 20:39:22 +00003583 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003584 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
3585 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00003586 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003587
3588 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003589 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003590 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003591 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00003592
3593 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003594 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00003595 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003596 if (ICmp.isEquality())
3597 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003598
3599 // A signed comparison of sign extended values simplifies into a
3600 // signed comparison.
3601 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003602 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003603
3604 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003605 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003606 }
3607
Sanjay Patel6a333c32016-06-06 16:56:57 +00003608 // The re-extended constant changed, partly changed (in the case of a vector),
3609 // or could not be determined to be equal (in the case of a constant
3610 // expression), so the constant cannot be represented in the shorter type.
3611 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003612 // All the cases that fold to true or false will have already been handled
3613 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00003614
Sanjay Patel6a333c32016-06-06 16:56:57 +00003615 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00003616 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003617
3618 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
3619 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003620
3621 // We're performing an unsigned comp with a sign extended value.
3622 // This is true if the input is >= 0. [aka >s -1]
3623 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Craig Topperbb4069e2017-07-07 23:16:26 +00003624 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00003625
3626 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003627 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
3628 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00003629
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003630 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00003631 return BinaryOperator::CreateNot(Result);
3632}
3633
Sanjoy Dasb0984472015-04-08 04:27:22 +00003634bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS,
3635 Value *RHS, Instruction &OrigI,
3636 Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00003637 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
3638 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003639
3640 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) {
3641 Result = OpResult;
3642 Overflow = OverflowVal;
3643 if (ReuseName)
3644 Result->takeName(&OrigI);
3645 return true;
3646 };
3647
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003648 // If the overflow check was an add followed by a compare, the insertion point
3649 // may be pointing to the compare. We want to insert the new instructions
3650 // before the add in case there are uses of the add between the add and the
3651 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00003652 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003653
Sanjoy Dasb0984472015-04-08 04:27:22 +00003654 switch (OCF) {
3655 case OCF_INVALID:
3656 llvm_unreachable("bad overflow check kind!");
3657
3658 case OCF_UNSIGNED_ADD: {
3659 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI);
3660 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003661 return SetResult(Builder.CreateNUWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003662 true);
3663
3664 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003665 return SetResult(Builder.CreateAdd(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003666
3667 // Fall through uadd into sadd
3668 LLVM_FALLTHROUGH;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003669 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003670 case OCF_SIGNED_ADD: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003671 // X + 0 -> {X, false}
3672 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003673 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003674
3675 // We can strength reduce this signed add into a regular add if we can prove
3676 // that it will never overflow.
3677 if (OCF == OCF_SIGNED_ADD)
Craig Topper2b1fc322017-05-22 06:25:31 +00003678 if (willNotOverflowSignedAdd(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003679 return SetResult(Builder.CreateNSWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003680 true);
Sanjoy Das72cb5e12015-06-05 18:04:42 +00003681 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003682 }
3683
3684 case OCF_UNSIGNED_SUB:
3685 case OCF_SIGNED_SUB: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003686 // X - 0 -> {X, false}
3687 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003688 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003689
3690 if (OCF == OCF_SIGNED_SUB) {
Craig Topper2b1fc322017-05-22 06:25:31 +00003691 if (willNotOverflowSignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003692 return SetResult(Builder.CreateNSWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003693 true);
3694 } else {
Craig Topper2b1fc322017-05-22 06:25:31 +00003695 if (willNotOverflowUnsignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003696 return SetResult(Builder.CreateNUWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003697 true);
3698 }
3699 break;
3700 }
3701
3702 case OCF_UNSIGNED_MUL: {
3703 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI);
3704 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003705 return SetResult(Builder.CreateNUWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003706 true);
3707 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003708 return SetResult(Builder.CreateMul(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003709 LLVM_FALLTHROUGH;
3710 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003711 case OCF_SIGNED_MUL:
3712 // X * undef -> undef
3713 if (isa<UndefValue>(RHS))
Craig Topperbb4069e2017-07-07 23:16:26 +00003714 return SetResult(RHS, UndefValue::get(Builder.getInt1Ty()), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003715
David Majnemer27e89ba2015-05-21 23:04:21 +00003716 // X * 0 -> {0, false}
3717 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003718 return SetResult(RHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003719
David Majnemer27e89ba2015-05-21 23:04:21 +00003720 // X * 1 -> {X, false}
3721 if (match(RHS, m_One()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003722 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003723
3724 if (OCF == OCF_SIGNED_MUL)
Craig Topper2b1fc322017-05-22 06:25:31 +00003725 if (willNotOverflowSignedMul(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003726 return SetResult(Builder.CreateNSWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003727 true);
Sanjoy Dasc80dad62015-06-05 18:04:46 +00003728 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003729 }
3730
3731 return false;
3732}
3733
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00003734/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003735/// overflow.
3736///
3737/// The caller has matched a pattern of the form:
3738/// I = cmp u (mul(zext A, zext B), V
3739/// The function checks if this is a test for overflow and if so replaces
3740/// multiplication with call to 'mul.with.overflow' intrinsic.
3741///
3742/// \param I Compare instruction.
3743/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
3744/// the compare instruction. Must be of integer type.
3745/// \param OtherVal The other argument of compare instruction.
3746/// \returns Instruction which must replace the compare instruction, NULL if no
3747/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003748static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003749 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00003750 // Don't bother doing this transformation for pointers, don't do it for
3751 // vectors.
3752 if (!isa<IntegerType>(MulVal->getType()))
3753 return nullptr;
3754
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003755 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
3756 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00003757 auto *MulInstr = dyn_cast<Instruction>(MulVal);
3758 if (!MulInstr)
3759 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003760 assert(MulInstr->getOpcode() == Instruction::Mul);
3761
David Majnemer634ca232014-11-01 23:46:05 +00003762 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
3763 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003764 assert(LHS->getOpcode() == Instruction::ZExt);
3765 assert(RHS->getOpcode() == Instruction::ZExt);
3766 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
3767
3768 // Calculate type and width of the result produced by mul.with.overflow.
3769 Type *TyA = A->getType(), *TyB = B->getType();
3770 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
3771 WidthB = TyB->getPrimitiveSizeInBits();
3772 unsigned MulWidth;
3773 Type *MulType;
3774 if (WidthB > WidthA) {
3775 MulWidth = WidthB;
3776 MulType = TyB;
3777 } else {
3778 MulWidth = WidthA;
3779 MulType = TyA;
3780 }
3781
3782 // In order to replace the original mul with a narrower mul.with.overflow,
3783 // all uses must ignore upper bits of the product. The number of used low
3784 // bits must be not greater than the width of mul.with.overflow.
3785 if (MulVal->hasNUsesOrMore(2))
3786 for (User *U : MulVal->users()) {
3787 if (U == &I)
3788 continue;
3789 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3790 // Check if truncation ignores bits above MulWidth.
3791 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
3792 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003793 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003794 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3795 // Check if AND ignores bits above MulWidth.
3796 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00003797 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003798 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
3799 const APInt &CVal = CI->getValue();
3800 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003801 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00003802 } else {
3803 // In this case we could have the operand of the binary operation
3804 // being defined in another block, and performing the replacement
3805 // could break the dominance relation.
3806 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003807 }
3808 } else {
3809 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00003810 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003811 }
3812 }
3813
3814 // Recognize patterns
3815 switch (I.getPredicate()) {
3816 case ICmpInst::ICMP_EQ:
3817 case ICmpInst::ICMP_NE:
3818 // Recognize pattern:
3819 // mulval = mul(zext A, zext B)
3820 // cmp eq/neq mulval, zext trunc mulval
3821 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
3822 if (Zext->hasOneUse()) {
3823 Value *ZextArg = Zext->getOperand(0);
3824 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
3825 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
3826 break; //Recognized
3827 }
3828
3829 // Recognize pattern:
3830 // mulval = mul(zext A, zext B)
3831 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
3832 ConstantInt *CI;
3833 Value *ValToMask;
3834 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
3835 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00003836 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003837 const APInt &CVal = CI->getValue() + 1;
3838 if (CVal.isPowerOf2()) {
3839 unsigned MaskWidth = CVal.logBase2();
3840 if (MaskWidth == MulWidth)
3841 break; // Recognized
3842 }
3843 }
Craig Topperf40110f2014-04-25 05:29:35 +00003844 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003845
3846 case ICmpInst::ICMP_UGT:
3847 // Recognize pattern:
3848 // mulval = mul(zext A, zext B)
3849 // cmp ugt mulval, max
3850 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3851 APInt MaxVal = APInt::getMaxValue(MulWidth);
3852 MaxVal = MaxVal.zext(CI->getBitWidth());
3853 if (MaxVal.eq(CI->getValue()))
3854 break; // Recognized
3855 }
Craig Topperf40110f2014-04-25 05:29:35 +00003856 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003857
3858 case ICmpInst::ICMP_UGE:
3859 // Recognize pattern:
3860 // mulval = mul(zext A, zext B)
3861 // cmp uge mulval, max+1
3862 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3863 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
3864 if (MaxVal.eq(CI->getValue()))
3865 break; // Recognized
3866 }
Craig Topperf40110f2014-04-25 05:29:35 +00003867 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003868
3869 case ICmpInst::ICMP_ULE:
3870 // Recognize pattern:
3871 // mulval = mul(zext A, zext B)
3872 // cmp ule mulval, max
3873 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3874 APInt MaxVal = APInt::getMaxValue(MulWidth);
3875 MaxVal = MaxVal.zext(CI->getBitWidth());
3876 if (MaxVal.eq(CI->getValue()))
3877 break; // Recognized
3878 }
Craig Topperf40110f2014-04-25 05:29:35 +00003879 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003880
3881 case ICmpInst::ICMP_ULT:
3882 // Recognize pattern:
3883 // mulval = mul(zext A, zext B)
3884 // cmp ule mulval, max + 1
3885 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003886 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003887 if (MaxVal.eq(CI->getValue()))
3888 break; // Recognized
3889 }
Craig Topperf40110f2014-04-25 05:29:35 +00003890 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003891
3892 default:
Craig Topperf40110f2014-04-25 05:29:35 +00003893 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003894 }
3895
Craig Topperbb4069e2017-07-07 23:16:26 +00003896 InstCombiner::BuilderTy &Builder = IC.Builder;
3897 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003898
3899 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
3900 Value *MulA = A, *MulB = B;
3901 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00003902 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003903 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00003904 MulB = Builder.CreateZExt(B, MulType);
Sanjay Patelaf674fb2015-12-14 17:24:23 +00003905 Value *F = Intrinsic::getDeclaration(I.getModule(),
3906 Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00003907 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003908 IC.Worklist.Add(MulInstr);
3909
3910 // If there are uses of mul result other than the comparison, we know that
3911 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003912 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003913 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003914 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00003915 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
3916 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003917 if (U == &I || U == OtherVal)
3918 continue;
3919 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3920 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00003921 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003922 else
3923 TI->setOperand(0, Mul);
3924 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3925 assert(BO->getOpcode() == Instruction::And);
3926 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00003927 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
3928 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00003929 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00003930 Instruction *Zext =
3931 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
3932 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00003933 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003934 } else {
3935 llvm_unreachable("Unexpected Binary operation");
3936 }
Davide Italiano579064e2017-07-16 18:56:30 +00003937 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003938 }
3939 }
3940 if (isa<Instruction>(OtherVal))
3941 IC.Worklist.Add(cast<Instruction>(OtherVal));
3942
3943 // The original icmp gets replaced with the overflow value, maybe inverted
3944 // depending on predicate.
3945 bool Inverse = false;
3946 switch (I.getPredicate()) {
3947 case ICmpInst::ICMP_NE:
3948 break;
3949 case ICmpInst::ICMP_EQ:
3950 Inverse = true;
3951 break;
3952 case ICmpInst::ICMP_UGT:
3953 case ICmpInst::ICMP_UGE:
3954 if (I.getOperand(0) == MulVal)
3955 break;
3956 Inverse = true;
3957 break;
3958 case ICmpInst::ICMP_ULT:
3959 case ICmpInst::ICMP_ULE:
3960 if (I.getOperand(1) == MulVal)
3961 break;
3962 Inverse = true;
3963 break;
3964 default:
3965 llvm_unreachable("Unexpected predicate");
3966 }
3967 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003968 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003969 return BinaryOperator::CreateNot(Res);
3970 }
3971
3972 return ExtractValueInst::Create(Call, 1);
3973}
3974
Sanjay Patel5f0217f2016-06-05 16:46:18 +00003975/// When performing a comparison against a constant, it is possible that not all
3976/// the bits in the LHS are demanded. This helper method computes the mask that
3977/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00003978static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00003979 const APInt *RHS;
3980 if (!match(I.getOperand(1), m_APInt(RHS)))
3981 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003982
Craig Topper3edda872017-09-22 18:57:23 +00003983 // If this is a normal comparison, it demands all bits. If it is a sign bit
3984 // comparison, it only demands the sign bit.
3985 bool UnusedBit;
3986 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
3987 return APInt::getSignMask(BitWidth);
3988
Owen Andersond490c2d2011-01-11 00:36:45 +00003989 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00003990 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00003991 // correspond to the trailing ones of the comparand. The value of these
3992 // bits doesn't impact the outcome of the comparison, because any value
3993 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00003994 case ICmpInst::ICMP_UGT:
3995 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00003996
Owen Andersond490c2d2011-01-11 00:36:45 +00003997 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
3998 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00003999 case ICmpInst::ICMP_ULT:
4000 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004001
Owen Andersond490c2d2011-01-11 00:36:45 +00004002 default:
4003 return APInt::getAllOnesValue(BitWidth);
4004 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004005}
Chris Lattner2188e402010-01-04 07:37:31 +00004006
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004007/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004008/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004009/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004010/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004011/// The rationale is that several architectures use the same instruction for
4012/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004013/// match.
4014/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004015static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4016 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004017 // FIXME: we may want to go through inttoptrs or bitcasts.
4018 if (Op0->getType()->isPointerTy())
4019 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004020 // If a subtract already has the same operands as a compare, swapping would be
4021 // bad. If a subtract has the same operands as a compare but in reverse order,
4022 // then swapping is good.
4023 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004024 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004025 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4026 GoodToSwap++;
4027 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4028 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004029 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004030 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004031}
4032
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004033/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004034/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004035///
4036/// \param DI Definition
4037/// \param UI Use
4038/// \param DB Block that must dominate all uses of \p DI outside
4039/// the parent block
4040/// \return true when \p UI is the only use of \p DI in the parent block
4041/// and all other uses of \p DI are in blocks dominated by \p DB.
4042///
4043bool InstCombiner::dominatesAllUses(const Instruction *DI,
4044 const Instruction *UI,
4045 const BasicBlock *DB) const {
4046 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004047 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004048 if (!DI->getParent())
4049 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004050 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004051 if (DI->getParent() != UI->getParent())
4052 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004053 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004054 if (DI->getParent() == DB)
4055 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004056 for (const User *U : DI->users()) {
4057 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004058 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004059 return false;
4060 }
4061 return true;
4062}
4063
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004064/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004065static bool isChainSelectCmpBranch(const SelectInst *SI) {
4066 const BasicBlock *BB = SI->getParent();
4067 if (!BB)
4068 return false;
4069 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4070 if (!BI || BI->getNumSuccessors() != 2)
4071 return false;
4072 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4073 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4074 return false;
4075 return true;
4076}
4077
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004078/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004079/// in select-icmp sequence. This will eventually result in the elimination
4080/// of the select.
4081///
4082/// \param SI Select instruction
4083/// \param Icmp Compare instruction
4084/// \param SIOpd Operand that replaces the select
4085///
4086/// Notes:
4087/// - The replacement is global and requires dominator information
4088/// - The caller is responsible for the actual replacement
4089///
4090/// Example:
4091///
4092/// entry:
4093/// %4 = select i1 %3, %C* %0, %C* null
4094/// %5 = icmp eq %C* %4, null
4095/// br i1 %5, label %9, label %7
4096/// ...
4097/// ; <label>:7 ; preds = %entry
4098/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4099/// ...
4100///
4101/// can be transformed to
4102///
4103/// %5 = icmp eq %C* %0, null
4104/// %6 = select i1 %3, i1 %5, i1 true
4105/// br i1 %6, label %9, label %7
4106/// ...
4107/// ; <label>:7 ; preds = %entry
4108/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4109///
4110/// Similar when the first operand of the select is a constant or/and
4111/// the compare is for not equal rather than equal.
4112///
4113/// NOTE: The function is only called when the select and compare constants
4114/// are equal, the optimization can work only for EQ predicates. This is not a
4115/// major restriction since a NE compare should be 'normalized' to an equal
4116/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004117/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004118bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4119 const ICmpInst *Icmp,
4120 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004121 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004122 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4123 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004124 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004125 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004126 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4127 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4128 // replaced can be reached on either path. So the uniqueness check
4129 // guarantees that the path all uses of SI (outside SI's parent) are on
4130 // is disjoint from all other paths out of SI. But that information
4131 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004132 // of compile-time. It should also be noticed that we check for a single
4133 // predecessor and not only uniqueness. This to handle the situation when
4134 // Succ and Succ1 points to the same basic block.
4135 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004136 NumSel++;
4137 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4138 return true;
4139 }
4140 }
4141 return false;
4142}
4143
Sanjay Patel3151dec2016-09-12 15:24:31 +00004144/// Try to fold the comparison based on range information we can get by checking
4145/// whether bits are known to be zero or one in the inputs.
4146Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4147 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4148 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004149 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004150
4151 // Get scalar or pointer size.
4152 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4153 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004154 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004155
4156 if (!BitWidth)
4157 return nullptr;
4158
Craig Topperb45eabc2017-04-26 16:39:58 +00004159 KnownBits Op0Known(BitWidth);
4160 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004161
Craig Topper47596dd2017-03-25 06:52:52 +00004162 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004163 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004164 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004165 return &I;
4166
Craig Topper47596dd2017-03-25 06:52:52 +00004167 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004168 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004169 return &I;
4170
4171 // Given the known and unknown bits, compute a range that the LHS could be
4172 // in. Compute the Min, Max and RHS values based on the known bits. For the
4173 // EQ and NE we use unsigned values.
4174 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4175 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4176 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004177 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4178 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004179 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004180 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4181 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004182 }
4183
Sanjay Patelc63f9012018-01-04 14:31:56 +00004184 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4185 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004186 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004187 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004188 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004189 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004190 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004191
4192 // Based on the range information we know about the LHS, see if we can
4193 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004194 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004195 default:
4196 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004197 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004198 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004199 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4200 return Pred == CmpInst::ICMP_EQ
4201 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4202 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4203 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004204
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004205 // If all bits are known zero except for one, then we know at most one bit
4206 // is set. If the comparison is against zero, then this is a check to see if
4207 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004208 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004209 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004210 // If the LHS is an AND with the same constant, look through it.
4211 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004212 const APInt *LHSC;
4213 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4214 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004215 LHS = Op0;
4216
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004217 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004218 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4219 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004220 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004221 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004222 // ((1 << X) & 8) == 0 -> X != 3
4223 // ((1 << X) & 8) != 0 -> X == 3
4224 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4225 auto NewPred = ICmpInst::getInversePredicate(Pred);
4226 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004227 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004228 // ((1 << X) & 7) == 0 -> X >= 3
4229 // ((1 << X) & 7) != 0 -> X < 3
4230 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4231 auto NewPred =
4232 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4233 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004234 }
4235 }
4236
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004237 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004238 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004239 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004240 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4241 // ((8 >>u X) & 1) == 0 -> X != 3
4242 // ((8 >>u X) & 1) != 0 -> X == 3
4243 unsigned CmpVal = CI->countTrailingZeros();
4244 auto NewPred = ICmpInst::getInversePredicate(Pred);
4245 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4246 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004247 }
4248 break;
4249 }
4250 case ICmpInst::ICMP_ULT: {
4251 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4252 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4253 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4254 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4255 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4256 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4257
Craig Topper0cd25942017-09-27 22:57:18 +00004258 const APInt *CmpC;
4259 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004260 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004261 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004262 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004263 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004264 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4265 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004266 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004267 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4268 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004269 }
4270 break;
4271 }
4272 case ICmpInst::ICMP_UGT: {
4273 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4274 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004275 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4276 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004277 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4278 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4279
Craig Topper0cd25942017-09-27 22:57:18 +00004280 const APInt *CmpC;
4281 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004282 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004283 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004284 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004285 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004286 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4287 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004288 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004289 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4290 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004291 }
4292 break;
4293 }
Craig Topper0cd25942017-09-27 22:57:18 +00004294 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004295 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4296 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4297 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4298 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4299 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4300 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004301 const APInt *CmpC;
4302 if (match(Op1, m_APInt(CmpC))) {
4303 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004304 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004305 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004306 }
4307 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004308 }
4309 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004310 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4311 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4312 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4313 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004314 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4315 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004316 const APInt *CmpC;
4317 if (match(Op1, m_APInt(CmpC))) {
4318 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004319 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004320 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004321 }
4322 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004323 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004324 case ICmpInst::ICMP_SGE:
4325 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4326 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4327 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4328 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4329 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004330 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4331 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004332 break;
4333 case ICmpInst::ICMP_SLE:
4334 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4335 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4336 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4337 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4338 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004339 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4340 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004341 break;
4342 case ICmpInst::ICMP_UGE:
4343 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4344 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4345 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4346 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4347 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004348 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4349 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004350 break;
4351 case ICmpInst::ICMP_ULE:
4352 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4353 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4354 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4355 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4356 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004357 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4358 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004359 break;
4360 }
4361
4362 // Turn a signed comparison into an unsigned one if both operands are known to
4363 // have the same sign.
4364 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004365 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4366 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004367 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4368
4369 return nullptr;
4370}
4371
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004372/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4373/// it into the appropriate icmp lt or icmp gt instruction. This transform
4374/// allows them to be folded in visitICmpInst.
Sanjay Patele9b2c322016-05-17 00:57:57 +00004375static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4376 ICmpInst::Predicate Pred = I.getPredicate();
4377 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE &&
4378 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE)
4379 return nullptr;
4380
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004381 Value *Op0 = I.getOperand(0);
4382 Value *Op1 = I.getOperand(1);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004383 auto *Op1C = dyn_cast<Constant>(Op1);
4384 if (!Op1C)
4385 return nullptr;
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004386
Sanjay Patele9b2c322016-05-17 00:57:57 +00004387 // Check if the constant operand can be safely incremented/decremented without
4388 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled
4389 // the edge cases for us, so we just assert on them. For vectors, we must
4390 // handle the edge cases.
4391 Type *Op1Type = Op1->getType();
4392 bool IsSigned = I.isSigned();
4393 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Sanjay Patel18254932016-05-17 01:12:31 +00004394 auto *CI = dyn_cast<ConstantInt>(Op1C);
4395 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004396 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4397 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
4398 } else if (Op1Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004399 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004400 // are for scalar, we could remove the min/max checks. However, to do that,
4401 // we would have to use insertelement/shufflevector to replace edge values.
4402 unsigned NumElts = Op1Type->getVectorNumElements();
4403 for (unsigned i = 0; i != NumElts; ++i) {
4404 Constant *Elt = Op1C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004405 if (!Elt)
4406 return nullptr;
4407
Sanjay Patele9b2c322016-05-17 00:57:57 +00004408 if (isa<UndefValue>(Elt))
4409 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004410
Sanjay Patele9b2c322016-05-17 00:57:57 +00004411 // Bail out if we can't determine if this constant is min/max or if we
4412 // know that this constant is min/max.
4413 auto *CI = dyn_cast<ConstantInt>(Elt);
4414 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
4415 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004416 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004417 } else {
4418 // ConstantExpr?
4419 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004420 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004421
Sanjay Patele9b2c322016-05-17 00:57:57 +00004422 // Increment or decrement the constant and set the new comparison predicate:
4423 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT
Sanjay Patel22b01fe2016-05-17 20:20:40 +00004424 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004425 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT;
4426 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred;
4427 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne));
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004428}
4429
Sanjay Patele5747e32017-05-17 22:15:07 +00004430/// Integer compare with boolean values can always be turned into bitwise ops.
4431static Instruction *canonicalizeICmpBool(ICmpInst &I,
4432 InstCombiner::BuilderTy &Builder) {
4433 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004434 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004435
Sanjay Patelba212c22017-05-17 22:29:40 +00004436 // A boolean compared to true/false can be simplified to Op0/true/false in
4437 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4438 // Cases not handled by InstSimplify are always 'not' of Op0.
4439 if (match(B, m_Zero())) {
4440 switch (I.getPredicate()) {
4441 case CmpInst::ICMP_EQ: // A == 0 -> !A
4442 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4443 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4444 return BinaryOperator::CreateNot(A);
4445 default:
4446 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4447 }
4448 } else if (match(B, m_One())) {
4449 switch (I.getPredicate()) {
4450 case CmpInst::ICMP_NE: // A != 1 -> !A
4451 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4452 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4453 return BinaryOperator::CreateNot(A);
4454 default:
4455 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4456 }
4457 }
4458
Sanjay Patele5747e32017-05-17 22:15:07 +00004459 switch (I.getPredicate()) {
4460 default:
4461 llvm_unreachable("Invalid icmp instruction!");
4462 case ICmpInst::ICMP_EQ:
4463 // icmp eq i1 A, B -> ~(A ^ B)
4464 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4465
4466 case ICmpInst::ICMP_NE:
4467 // icmp ne i1 A, B -> A ^ B
4468 return BinaryOperator::CreateXor(A, B);
4469
4470 case ICmpInst::ICMP_UGT:
4471 // icmp ugt -> icmp ult
4472 std::swap(A, B);
4473 LLVM_FALLTHROUGH;
4474 case ICmpInst::ICMP_ULT:
4475 // icmp ult i1 A, B -> ~A & B
4476 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4477
4478 case ICmpInst::ICMP_SGT:
4479 // icmp sgt -> icmp slt
4480 std::swap(A, B);
4481 LLVM_FALLTHROUGH;
4482 case ICmpInst::ICMP_SLT:
4483 // icmp slt i1 A, B -> A & ~B
4484 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4485
4486 case ICmpInst::ICMP_UGE:
4487 // icmp uge -> icmp ule
4488 std::swap(A, B);
4489 LLVM_FALLTHROUGH;
4490 case ICmpInst::ICMP_ULE:
4491 // icmp ule i1 A, B -> ~A | B
4492 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4493
4494 case ICmpInst::ICMP_SGE:
4495 // icmp sge -> icmp sle
4496 std::swap(A, B);
4497 LLVM_FALLTHROUGH;
4498 case ICmpInst::ICMP_SLE:
4499 // icmp sle i1 A, B -> A | ~B
4500 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4501 }
4502}
4503
Chris Lattner2188e402010-01-04 07:37:31 +00004504Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
4505 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00004506 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00004507 unsigned Op0Cplxity = getComplexity(Op0);
4508 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004509
Chris Lattner2188e402010-01-04 07:37:31 +00004510 /// Orders the operands of the compare so that they are listed from most
4511 /// complex to least complex. This puts constants before unary operators,
4512 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004513 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00004514 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004515 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00004516 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00004517 Changed = true;
4518 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004519
Daniel Berlin2c75c632017-04-26 20:56:07 +00004520 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
4521 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004522 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004523
Uriel Korach18972232017-09-10 08:31:22 +00004524 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00004525 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00004526 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004527 Value *Cond, *SelectTrue, *SelectFalse;
4528 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00004529 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004530 if (Value *V = dyn_castNegVal(SelectTrue)) {
4531 if (V == SelectFalse)
4532 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
4533 }
4534 else if (Value *V = dyn_castNegVal(SelectFalse)) {
4535 if (V == SelectTrue)
4536 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00004537 }
4538 }
4539 }
4540
Craig Topperfde47232017-07-09 07:04:03 +00004541 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00004542 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00004543 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004544
Sanjay Patele9b2c322016-05-17 00:57:57 +00004545 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004546 return NewICmp;
4547
Sanjay Patel06b127a2016-09-15 14:37:50 +00004548 if (Instruction *Res = foldICmpWithConstant(I))
4549 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004550
Max Kazantsev20da7e42018-07-06 04:04:13 +00004551 if (Instruction *Res = foldICmpUsingKnownBits(I))
4552 return Res;
4553
Chris Lattner2188e402010-01-04 07:37:31 +00004554 // Test if the ICmpInst instruction is used exclusively by a select as
4555 // part of a minimum or maximum operation. If so, refrain from doing
4556 // any other folding. This helps out other analyses which understand
4557 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4558 // and CodeGen. And in this case, at least one of the comparison
4559 // operands has at least one user besides the compare (the select),
4560 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00004561 //
4562 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00004563 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00004564 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
4565 Value *A, *B;
4566 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
4567 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00004568 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00004569 }
Chris Lattner2188e402010-01-04 07:37:31 +00004570
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00004571 // Do this after checking for min/max to prevent infinite looping.
4572 if (Instruction *Res = foldICmpWithZero(I))
4573 return Res;
4574
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00004575 // FIXME: We only do this after checking for min/max to prevent infinite
4576 // looping caused by a reverse canonicalization of these patterns for min/max.
4577 // FIXME: The organization of folds is a mess. These would naturally go into
4578 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
4579 // down here after the min/max restriction.
4580 ICmpInst::Predicate Pred = I.getPredicate();
4581 const APInt *C;
4582 if (match(Op1, m_APInt(C))) {
4583 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
4584 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
4585 Constant *Zero = Constant::getNullValue(Op0->getType());
4586 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
4587 }
4588
4589 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
4590 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
4591 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
4592 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
4593 }
4594 }
4595
Sanjay Patelf58f68c2016-09-10 15:03:44 +00004596 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00004597 return Res;
4598
Sanjay Patel10494b22016-09-16 16:10:22 +00004599 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
4600 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004601
4602 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
4603 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00004604 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00004605 return NI;
4606 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004607 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00004608 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
4609 return NI;
4610
Hans Wennborgf1f36512015-10-07 00:20:07 +00004611 // Try to optimize equality comparisons against alloca-based pointers.
4612 if (Op0->getType()->isPointerTy() && I.isEquality()) {
4613 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
4614 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004615 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004616 return New;
4617 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004618 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004619 return New;
4620 }
4621
Sanjay Patel841aac02018-03-25 14:01:42 +00004622 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
Roman Lebedeve6da3062018-03-18 15:53:02 +00004623 Value *X;
Sanjay Patel745a9c62018-03-24 15:45:02 +00004624 if (match(Op0, m_BitCast(m_SIToFP(m_Value(X))))) {
Sanjay Patel841aac02018-03-25 14:01:42 +00004625 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
4626 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
4627 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
4628 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
4629 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
4630 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
4631 match(Op1, m_Zero()))
Sanjay Patel745a9c62018-03-24 15:45:02 +00004632 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patel841aac02018-03-25 14:01:42 +00004633
4634 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
4635 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
4636 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
4637
4638 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
Sanjay Patel745a9c62018-03-24 15:45:02 +00004639 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
4640 return new ICmpInst(Pred, X, ConstantInt::getAllOnesValue(X->getType()));
4641 }
Roman Lebedeve6da3062018-03-18 15:53:02 +00004642
4643 // Zero-equality checks are preserved through unsigned floating-point casts:
4644 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
4645 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
4646 if (match(Op0, m_BitCast(m_UIToFP(m_Value(X)))))
4647 if (I.isEquality() && match(Op1, m_Zero()))
4648 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
4649
Chris Lattner2188e402010-01-04 07:37:31 +00004650 // Test to see if the operands of the icmp are casted versions of other
4651 // values. If the ptr->ptr cast can be stripped off both arguments, we do so
4652 // now.
4653 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004654 if (Op0->getType()->isPointerTy() &&
4655 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004656 // We keep moving the cast from the left operand over to the right
4657 // operand, where it can often be eliminated completely.
4658 Op0 = CI->getOperand(0);
4659
4660 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
4661 // so eliminate it as well.
4662 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1))
4663 Op1 = CI2->getOperand(0);
4664
4665 // If Op1 is a constant, we can fold the cast into the constant.
4666 if (Op0->getType() != Op1->getType()) {
4667 if (Constant *Op1C = dyn_cast<Constant>(Op1)) {
4668 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType());
4669 } else {
4670 // Otherwise, cast the RHS right before the icmp
Craig Topperbb4069e2017-07-07 23:16:26 +00004671 Op1 = Builder.CreateBitCast(Op1, Op0->getType());
Chris Lattner2188e402010-01-04 07:37:31 +00004672 }
4673 }
4674 return new ICmpInst(I.getPredicate(), Op0, Op1);
4675 }
4676 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004677
Chris Lattner2188e402010-01-04 07:37:31 +00004678 if (isa<CastInst>(Op0)) {
4679 // Handle the special case of: icmp (cast bool to X), <cst>
4680 // This comes up when you have code like
4681 // int X = A < B;
4682 // if (X) ...
4683 // For generality, we handle any zero-extension of any operand comparison
4684 // with a constant or another cast from the same type.
4685 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004686 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00004687 return R;
4688 }
Chris Lattner2188e402010-01-04 07:37:31 +00004689
Sanjay Patel10494b22016-09-16 16:10:22 +00004690 if (Instruction *Res = foldICmpBinOp(I))
4691 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00004692
Sanjay Pateldd46b522016-12-19 17:32:37 +00004693 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00004694 return Res;
4695
Sanjay Patel10494b22016-09-16 16:10:22 +00004696 {
4697 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00004698 // Transform (A & ~B) == 0 --> (A & B) != 0
4699 // and (A & ~B) != 0 --> (A & B) == 0
4700 // if A is a power of 2.
4701 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00004702 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00004703 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00004704 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00004705 Op1);
4706
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004707 // ~X < ~Y --> Y < X
4708 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004709 if (match(Op0, m_Not(m_Value(A)))) {
4710 if (match(Op1, m_Not(m_Value(B))))
4711 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004712
Sanjay Patelce241f42017-06-02 16:29:41 +00004713 const APInt *C;
4714 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004715 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00004716 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004717 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00004718
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004719 Instruction *AddI = nullptr;
4720 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
4721 m_Instruction(AddI))) &&
4722 isa<IntegerType>(A->getType())) {
4723 Value *Result;
4724 Constant *Overflow;
4725 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result,
4726 Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00004727 replaceInstUsesWith(*AddI, Result);
4728 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004729 }
4730 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004731
4732 // (zext a) * (zext b) --> llvm.umul.with.overflow.
4733 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004734 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004735 return R;
4736 }
4737 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004738 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004739 return R;
4740 }
Chris Lattner2188e402010-01-04 07:37:31 +00004741 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004742
Sanjay Patel10494b22016-09-16 16:10:22 +00004743 if (Instruction *Res = foldICmpEquality(I))
4744 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004745
David Majnemerc1eca5a2014-11-06 23:23:30 +00004746 // The 'cmpxchg' instruction returns an aggregate containing the old value and
4747 // an i1 which indicates whether or not we successfully did the swap.
4748 //
4749 // Replace comparisons between the old value and the expected value with the
4750 // indicator that 'cmpxchg' returns.
4751 //
4752 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
4753 // spuriously fail. In those cases, the old value may equal the expected
4754 // value but it is possible for the swap to not occur.
4755 if (I.getPredicate() == ICmpInst::ICMP_EQ)
4756 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
4757 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
4758 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
4759 !ACXI->isWeak())
4760 return ExtractValueInst::Create(ACXI, 1);
4761
Chris Lattner2188e402010-01-04 07:37:31 +00004762 {
4763 Value *X; ConstantInt *Cst;
4764 // icmp X+Cst, X
4765 if (match(Op0, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op1 == X)
Craig Toppera85f8622017-08-23 05:46:09 +00004766 return foldICmpAddOpConst(X, Cst, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004767
4768 // icmp X, X+Cst
4769 if (match(Op1, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op0 == X)
Craig Toppera85f8622017-08-23 05:46:09 +00004770 return foldICmpAddOpConst(X, Cst, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004771 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00004772
Craig Topperf40110f2014-04-25 05:29:35 +00004773 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004774}
4775
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004776/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00004777Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00004778 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00004779 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004780 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004781
Chris Lattner2188e402010-01-04 07:37:31 +00004782 // Get the width of the mantissa. We don't want to hack on conversions that
4783 // might lose information from the integer, e.g. "i64 -> float"
4784 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00004785 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004786
Matt Arsenault55e73122015-01-06 15:50:59 +00004787 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
4788
Chris Lattner2188e402010-01-04 07:37:31 +00004789 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004790
Matt Arsenault55e73122015-01-06 15:50:59 +00004791 if (I.isEquality()) {
4792 FCmpInst::Predicate P = I.getPredicate();
4793 bool IsExact = false;
4794 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
4795 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
4796
4797 // If the floating point constant isn't an integer value, we know if we will
4798 // ever compare equal / not equal to it.
4799 if (!IsExact) {
4800 // TODO: Can never be -0.0 and other non-representable values
4801 APFloat RHSRoundInt(RHS);
4802 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
4803 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
4804 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00004805 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00004806
4807 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00004808 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00004809 }
4810 }
4811
4812 // TODO: If the constant is exactly representable, is it always OK to do
4813 // equality compares as integer?
4814 }
4815
Arch D. Robison8ed08542015-09-15 17:51:59 +00004816 // Check to see that the input is converted from an integer type that is small
4817 // enough that preserves all bits. TODO: check here for "known" sign bits.
4818 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
4819 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00004820
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004821 // Following test does NOT adjust InputSize downwards for signed inputs,
4822 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00004823 // to distinguish it from one less than that value.
4824 if ((int)InputSize > MantissaWidth) {
4825 // Conversion would lose accuracy. Check if loss can impact comparison.
4826 int Exp = ilogb(RHS);
4827 if (Exp == APFloat::IEK_Inf) {
4828 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004829 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004830 // Conversion could create infinity.
4831 return nullptr;
4832 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004833 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00004834 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004835 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004836 // Conversion could affect comparison.
4837 return nullptr;
4838 }
4839 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004840
Chris Lattner2188e402010-01-04 07:37:31 +00004841 // Otherwise, we can potentially simplify the comparison. We know that it
4842 // will always come through as an integer value and we know the constant is
4843 // not a NAN (it would have been previously simplified).
4844 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00004845
Chris Lattner2188e402010-01-04 07:37:31 +00004846 ICmpInst::Predicate Pred;
4847 switch (I.getPredicate()) {
4848 default: llvm_unreachable("Unexpected predicate!");
4849 case FCmpInst::FCMP_UEQ:
4850 case FCmpInst::FCMP_OEQ:
4851 Pred = ICmpInst::ICMP_EQ;
4852 break;
4853 case FCmpInst::FCMP_UGT:
4854 case FCmpInst::FCMP_OGT:
4855 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
4856 break;
4857 case FCmpInst::FCMP_UGE:
4858 case FCmpInst::FCMP_OGE:
4859 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
4860 break;
4861 case FCmpInst::FCMP_ULT:
4862 case FCmpInst::FCMP_OLT:
4863 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
4864 break;
4865 case FCmpInst::FCMP_ULE:
4866 case FCmpInst::FCMP_OLE:
4867 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
4868 break;
4869 case FCmpInst::FCMP_UNE:
4870 case FCmpInst::FCMP_ONE:
4871 Pred = ICmpInst::ICMP_NE;
4872 break;
4873 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00004874 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004875 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00004876 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004877 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004878
Chris Lattner2188e402010-01-04 07:37:31 +00004879 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004880
Chris Lattner2188e402010-01-04 07:37:31 +00004881 // See if the FP constant is too large for the integer. For example,
4882 // comparing an i8 to 300.0.
4883 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004884
Chris Lattner2188e402010-01-04 07:37:31 +00004885 if (!LHSUnsigned) {
4886 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
4887 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00004888 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004889 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
4890 APFloat::rmNearestTiesToEven);
4891 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
4892 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
4893 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004894 return replaceInstUsesWith(I, Builder.getTrue());
4895 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004896 }
4897 } else {
4898 // If the RHS value is > UnsignedMax, fold the comparison. This handles
4899 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00004900 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004901 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
4902 APFloat::rmNearestTiesToEven);
4903 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
4904 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
4905 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004906 return replaceInstUsesWith(I, Builder.getTrue());
4907 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004908 }
4909 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004910
Chris Lattner2188e402010-01-04 07:37:31 +00004911 if (!LHSUnsigned) {
4912 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00004913 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004914 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
4915 APFloat::rmNearestTiesToEven);
4916 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
4917 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
4918 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004919 return replaceInstUsesWith(I, Builder.getTrue());
4920 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004921 }
Devang Patel698452b2012-02-13 23:05:18 +00004922 } else {
4923 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00004924 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00004925 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
4926 APFloat::rmNearestTiesToEven);
4927 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
4928 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
4929 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004930 return replaceInstUsesWith(I, Builder.getTrue());
4931 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00004932 }
Chris Lattner2188e402010-01-04 07:37:31 +00004933 }
4934
4935 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
4936 // [0, UMAX], but it may still be fractional. See if it is fractional by
4937 // casting the FP value to the integer value and back, checking for equality.
4938 // Don't do this for zero, because -0.0 is not fractional.
4939 Constant *RHSInt = LHSUnsigned
4940 ? ConstantExpr::getFPToUI(RHSC, IntTy)
4941 : ConstantExpr::getFPToSI(RHSC, IntTy);
4942 if (!RHS.isZero()) {
4943 bool Equal = LHSUnsigned
4944 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
4945 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
4946 if (!Equal) {
4947 // If we had a comparison against a fractional value, we have to adjust
4948 // the compare predicate and sometimes the value. RHSC is rounded towards
4949 // zero at this point.
4950 switch (Pred) {
4951 default: llvm_unreachable("Unexpected integer comparison!");
4952 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00004953 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004954 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00004955 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004956 case ICmpInst::ICMP_ULE:
4957 // (float)int <= 4.4 --> int <= 4
4958 // (float)int <= -4.4 --> false
4959 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004960 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004961 break;
4962 case ICmpInst::ICMP_SLE:
4963 // (float)int <= 4.4 --> int <= 4
4964 // (float)int <= -4.4 --> int < -4
4965 if (RHS.isNegative())
4966 Pred = ICmpInst::ICMP_SLT;
4967 break;
4968 case ICmpInst::ICMP_ULT:
4969 // (float)int < -4.4 --> false
4970 // (float)int < 4.4 --> int <= 4
4971 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004972 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004973 Pred = ICmpInst::ICMP_ULE;
4974 break;
4975 case ICmpInst::ICMP_SLT:
4976 // (float)int < -4.4 --> int < -4
4977 // (float)int < 4.4 --> int <= 4
4978 if (!RHS.isNegative())
4979 Pred = ICmpInst::ICMP_SLE;
4980 break;
4981 case ICmpInst::ICMP_UGT:
4982 // (float)int > 4.4 --> int > 4
4983 // (float)int > -4.4 --> true
4984 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004985 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004986 break;
4987 case ICmpInst::ICMP_SGT:
4988 // (float)int > 4.4 --> int > 4
4989 // (float)int > -4.4 --> int >= -4
4990 if (RHS.isNegative())
4991 Pred = ICmpInst::ICMP_SGE;
4992 break;
4993 case ICmpInst::ICMP_UGE:
4994 // (float)int >= -4.4 --> true
4995 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00004996 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004997 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004998 Pred = ICmpInst::ICMP_UGT;
4999 break;
5000 case ICmpInst::ICMP_SGE:
5001 // (float)int >= -4.4 --> int >= -4
5002 // (float)int >= 4.4 --> int > 4
5003 if (!RHS.isNegative())
5004 Pred = ICmpInst::ICMP_SGT;
5005 break;
5006 }
5007 }
5008 }
5009
5010 // Lower this FP comparison into an appropriate integer version of the
5011 // comparison.
5012 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5013}
5014
5015Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5016 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005017
Chris Lattner2188e402010-01-04 07:37:31 +00005018 /// Orders the operands of the compare so that they are listed from most
5019 /// complex to least complex. This puts constants before unary operators,
5020 /// before binary operators.
5021 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5022 I.swapOperands();
5023 Changed = true;
5024 }
5025
Sanjay Patel6b139462017-09-02 15:11:55 +00005026 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005027 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005028 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5029 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005030 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005031
5032 // Simplify 'fcmp pred X, X'
5033 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005034 switch (Pred) {
5035 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005036 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5037 case FCmpInst::FCMP_ULT: // True if unordered or less than
5038 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5039 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5040 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5041 I.setPredicate(FCmpInst::FCMP_UNO);
5042 I.setOperand(1, Constant::getNullValue(Op0->getType()));
5043 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005044
Chris Lattner2188e402010-01-04 07:37:31 +00005045 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5046 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5047 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5048 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5049 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5050 I.setPredicate(FCmpInst::FCMP_ORD);
5051 I.setOperand(1, Constant::getNullValue(Op0->getType()));
5052 return &I;
5053 }
5054 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005055
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005056 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5057 // then canonicalize the operand to 0.0.
5058 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Sanjay Patel93e64dd2018-03-25 21:16:33 +00005059 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0)) {
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005060 I.setOperand(0, ConstantFP::getNullValue(Op0->getType()));
5061 return &I;
5062 }
Sanjay Patel93e64dd2018-03-25 21:16:33 +00005063 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1)) {
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005064 I.setOperand(1, ConstantFP::getNullValue(Op0->getType()));
5065 return &I;
5066 }
5067 }
5068
James Molloy2b21a7c2015-05-20 18:41:25 +00005069 // Test if the FCmpInst instruction is used exclusively by a select as
5070 // part of a minimum or maximum operation. If so, refrain from doing
5071 // any other folding. This helps out other analyses which understand
5072 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5073 // and CodeGen. And in this case, at least one of the comparison
5074 // operands has at least one user besides the compare (the select),
5075 // which would often largely negate the benefit of folding anyway.
5076 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005077 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5078 Value *A, *B;
5079 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5080 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005081 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005082 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005083
Chris Lattner2188e402010-01-04 07:37:31 +00005084 // Handle fcmp with constant RHS
5085 if (Constant *RHSC = dyn_cast<Constant>(Op1)) {
5086 if (Instruction *LHSI = dyn_cast<Instruction>(Op0))
5087 switch (LHSI->getOpcode()) {
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005088 case Instruction::FPExt: {
5089 // fcmp (fpext x), C -> fcmp x, (fptrunc C) if fptrunc is lossless
5090 FPExtInst *LHSExt = cast<FPExtInst>(LHSI);
5091 ConstantFP *RHSF = dyn_cast<ConstantFP>(RHSC);
5092 if (!RHSF)
5093 break;
5094
5095 const fltSemantics *Sem;
5096 // FIXME: This shouldn't be here.
Dan Gohman518cda42011-12-17 00:04:22 +00005097 if (LHSExt->getSrcTy()->isHalfTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005098 Sem = &APFloat::IEEEhalf();
Dan Gohman518cda42011-12-17 00:04:22 +00005099 else if (LHSExt->getSrcTy()->isFloatTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005100 Sem = &APFloat::IEEEsingle();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005101 else if (LHSExt->getSrcTy()->isDoubleTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005102 Sem = &APFloat::IEEEdouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005103 else if (LHSExt->getSrcTy()->isFP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005104 Sem = &APFloat::IEEEquad();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005105 else if (LHSExt->getSrcTy()->isX86_FP80Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005106 Sem = &APFloat::x87DoubleExtended();
Ulrich Weigand6a9bb512012-10-30 12:33:18 +00005107 else if (LHSExt->getSrcTy()->isPPC_FP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005108 Sem = &APFloat::PPCDoubleDouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005109 else
5110 break;
5111
5112 bool Lossy;
5113 APFloat F = RHSF->getValueAPF();
5114 F.convert(*Sem, APFloat::rmNearestTiesToEven, &Lossy);
5115
Jim Grosbach24ff8342011-09-30 18:45:50 +00005116 // Avoid lossy conversions and denormals. Zero is a special case
5117 // that's OK to convert.
Jim Grosbach011dafb2011-09-30 19:58:46 +00005118 APFloat Fabs = F;
5119 Fabs.clearSign();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005120 if (!Lossy &&
Jim Grosbach011dafb2011-09-30 19:58:46 +00005121 ((Fabs.compare(APFloat::getSmallestNormalized(*Sem)) !=
5122 APFloat::cmpLessThan) || Fabs.isZero()))
Jim Grosbach24ff8342011-09-30 18:45:50 +00005123
Sanjay Patel6b139462017-09-02 15:11:55 +00005124 return new FCmpInst(Pred, LHSExt->getOperand(0),
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005125 ConstantFP::get(RHSC->getContext(), F));
5126 break;
5127 }
Chris Lattner2188e402010-01-04 07:37:31 +00005128 case Instruction::PHI:
5129 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5130 // block. If in the same block, we're encouraging jump threading. If
5131 // not, we are just pessimizing the code by making an i1 phi.
5132 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00005133 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005134 return NV;
5135 break;
5136 case Instruction::SIToFP:
5137 case Instruction::UIToFP:
Sanjay Patel43395062016-07-21 18:07:40 +00005138 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
Chris Lattner2188e402010-01-04 07:37:31 +00005139 return NV;
5140 break;
Benjamin Kramera8c5d082011-03-31 10:12:15 +00005141 case Instruction::FSub: {
5142 // fcmp pred (fneg x), C -> fcmp swap(pred) x, -C
5143 Value *Op;
5144 if (match(LHSI, m_FNeg(m_Value(Op))))
5145 return new FCmpInst(I.getSwappedPredicate(), Op,
5146 ConstantExpr::getFNeg(RHSC));
5147 break;
5148 }
Dan Gohman94732022010-02-24 06:46:09 +00005149 case Instruction::Load:
5150 if (GetElementPtrInst *GEP =
5151 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
5152 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5153 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5154 !cast<LoadInst>(LHSI)->isVolatile())
Sanjay Patel43395062016-07-21 18:07:40 +00005155 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
Dan Gohman94732022010-02-24 06:46:09 +00005156 return Res;
5157 }
5158 break;
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005159 case Instruction::Call: {
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00005160 if (!RHSC->isNullValue())
5161 break;
5162
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005163 CallInst *CI = cast<CallInst>(LHSI);
Justin Bogner99798402016-08-05 01:06:44 +00005164 Intrinsic::ID IID = getIntrinsicForCallSite(CI, &TLI);
David Majnemer2e02ba72016-04-15 17:21:03 +00005165 if (IID != Intrinsic::fabs)
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00005166 break;
5167
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005168 // Various optimization for fabs compared with zero.
Sanjay Patel6b139462017-09-02 15:11:55 +00005169 switch (Pred) {
David Majnemer2e02ba72016-04-15 17:21:03 +00005170 default:
5171 break;
5172 // fabs(x) < 0 --> false
5173 case FCmpInst::FCMP_OLT:
5174 llvm_unreachable("handled by SimplifyFCmpInst");
5175 // fabs(x) > 0 --> x != 0
5176 case FCmpInst::FCMP_OGT:
5177 return new FCmpInst(FCmpInst::FCMP_ONE, CI->getArgOperand(0), RHSC);
5178 // fabs(x) <= 0 --> x == 0
5179 case FCmpInst::FCMP_OLE:
5180 return new FCmpInst(FCmpInst::FCMP_OEQ, CI->getArgOperand(0), RHSC);
5181 // fabs(x) >= 0 --> !isnan(x)
5182 case FCmpInst::FCMP_OGE:
5183 return new FCmpInst(FCmpInst::FCMP_ORD, CI->getArgOperand(0), RHSC);
5184 // fabs(x) == 0 --> x == 0
5185 // fabs(x) != 0 --> x != 0
5186 case FCmpInst::FCMP_OEQ:
5187 case FCmpInst::FCMP_UEQ:
5188 case FCmpInst::FCMP_ONE:
5189 case FCmpInst::FCMP_UNE:
Sanjay Patel6b139462017-09-02 15:11:55 +00005190 return new FCmpInst(Pred, CI->getArgOperand(0), RHSC);
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005191 }
5192 }
Chris Lattner2188e402010-01-04 07:37:31 +00005193 }
Chris Lattner2188e402010-01-04 07:37:31 +00005194 }
5195
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00005196 // fcmp pred (fneg x), (fneg y) -> fcmp swap(pred) x, y
Benjamin Kramerd159d942011-03-31 10:12:22 +00005197 Value *X, *Y;
5198 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00005199 return new FCmpInst(I.getSwappedPredicate(), X, Y);
Benjamin Kramerd159d942011-03-31 10:12:22 +00005200
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005201 // fcmp (fpext x), (fpext y) -> fcmp x, y
5202 if (FPExtInst *LHSExt = dyn_cast<FPExtInst>(Op0))
5203 if (FPExtInst *RHSExt = dyn_cast<FPExtInst>(Op1))
5204 if (LHSExt->getSrcTy() == RHSExt->getSrcTy())
Sanjay Patel6b139462017-09-02 15:11:55 +00005205 return new FCmpInst(Pred, LHSExt->getOperand(0), RHSExt->getOperand(0));
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005206
Craig Topperf40110f2014-04-25 05:29:35 +00005207 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005208}