blob: 54b0ee5ead608c9d8ae6b60c1a7705525f798c3f [file] [log] [blame]
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001//
2// Copyright 2016 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6// ContextVk.cpp:
7// Implements the class methods for ContextVk.
8//
9
10#include "libANGLE/renderer/vulkan/ContextVk.h"
11
Jamie Madill20e005b2017-04-07 14:19:22 -040012#include "common/bitset_utils.h"
Jamie Madill9e54b5a2016-05-25 12:57:39 -040013#include "common/debug.h"
Frank Henigmana53d0e12018-02-13 00:06:06 -050014#include "common/utilities.h"
Jamie Madillbd159f02017-10-09 19:39:06 -040015#include "libANGLE/Context.h"
Jamie Madilldf68a6f2017-01-13 17:29:53 -050016#include "libANGLE/Program.h"
Geoff Langcaa55cd2018-07-05 13:19:35 -040017#include "libANGLE/Surface.h"
Jamie Madillacccc6c2016-05-03 17:22:10 -040018#include "libANGLE/renderer/vulkan/BufferVk.h"
Jamie Madill1f46bc12018-02-20 16:09:43 -050019#include "libANGLE/renderer/vulkan/CommandGraph.h"
Jamie Madillacccc6c2016-05-03 17:22:10 -040020#include "libANGLE/renderer/vulkan/CompilerVk.h"
Jamie Madillacccc6c2016-05-03 17:22:10 -040021#include "libANGLE/renderer/vulkan/FenceNVVk.h"
Jamie Madillacccc6c2016-05-03 17:22:10 -040022#include "libANGLE/renderer/vulkan/FramebufferVk.h"
Yunchao Hea336b902017-08-02 16:05:21 +080023#include "libANGLE/renderer/vulkan/ProgramPipelineVk.h"
Jamie Madillacccc6c2016-05-03 17:22:10 -040024#include "libANGLE/renderer/vulkan/ProgramVk.h"
25#include "libANGLE/renderer/vulkan/QueryVk.h"
26#include "libANGLE/renderer/vulkan/RenderbufferVk.h"
27#include "libANGLE/renderer/vulkan/RendererVk.h"
28#include "libANGLE/renderer/vulkan/SamplerVk.h"
29#include "libANGLE/renderer/vulkan/ShaderVk.h"
Jamie Madill70b5bb02017-08-28 13:32:37 -040030#include "libANGLE/renderer/vulkan/SyncVk.h"
Jamie Madillacccc6c2016-05-03 17:22:10 -040031#include "libANGLE/renderer/vulkan/TextureVk.h"
32#include "libANGLE/renderer/vulkan/TransformFeedbackVk.h"
33#include "libANGLE/renderer/vulkan/VertexArrayVk.h"
Jamie Madill9e54b5a2016-05-25 12:57:39 -040034
35namespace rx
36{
Luc Ferron14f48172018-04-11 08:43:28 -040037
38namespace
39{
Jamie Madill21061022018-07-12 23:56:30 -040040GLenum DefaultGLErrorCode(VkResult result)
41{
42 switch (result)
43 {
44 case VK_ERROR_OUT_OF_HOST_MEMORY:
45 case VK_ERROR_OUT_OF_DEVICE_MEMORY:
46 case VK_ERROR_TOO_MANY_OBJECTS:
47 return GL_OUT_OF_MEMORY;
48 default:
49 return GL_INVALID_OPERATION;
50 }
51}
52
Luc Ferron14f48172018-04-11 08:43:28 -040053constexpr gl::Rectangle kMaxSizedScissor(0,
54 0,
55 std::numeric_limits<int>::max(),
56 std::numeric_limits<int>::max());
57
Jamie Madill9aef3672018-04-27 11:45:06 -040058constexpr VkColorComponentFlags kAllColorChannelsMask =
59 (VK_COLOR_COMPONENT_R_BIT | VK_COLOR_COMPONENT_G_BIT | VK_COLOR_COMPONENT_B_BIT |
60 VK_COLOR_COMPONENT_A_BIT);
Jamie Madill5a4c9322018-07-16 11:01:58 -040061
62constexpr VkBufferUsageFlags kVertexBufferUsage = VK_BUFFER_USAGE_VERTEX_BUFFER_BIT;
63constexpr size_t kDefaultValueSize = sizeof(float) * 4;
64constexpr size_t kDefaultBufferSize = kDefaultValueSize * 16;
Luc Ferron14f48172018-04-11 08:43:28 -040065} // anonymous namespace
66
Jamie Madill5a4c9322018-07-16 11:01:58 -040067// std::array only uses aggregate init. Thus we make a helper macro to reduce on code duplication.
68#define INIT \
69 { \
70 kVertexBufferUsage, kDefaultBufferSize \
71 }
72
Jamie Madillacccc6c2016-05-03 17:22:10 -040073ContextVk::ContextVk(const gl::ContextState &state, RendererVk *renderer)
Jamie Madill49ac74b2017-12-21 14:42:33 -050074 : ContextImpl(state),
Jamie Madill21061022018-07-12 23:56:30 -040075 vk::Context(renderer),
Jamie Madill493f9572018-05-24 19:52:15 -040076 mCurrentDrawMode(gl::PrimitiveMode::InvalidEnum),
Frank Henigman17448952017-01-05 15:48:26 -050077 mTexturesDirty(false),
Jamie Madill9aef3672018-04-27 11:45:06 -040078 mVertexArrayBindingHasChanged(false),
Geoff Langcaa55cd2018-07-05 13:19:35 -040079 mClearColorMask(kAllColorChannelsMask),
Jamie Madill834a3a12018-07-09 13:32:39 -040080 mFlipYForCurrentSurface(false),
81 mDriverUniformsBuffer(VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, sizeof(DriverUniforms) * 16),
Jamie Madill5a4c9322018-07-16 11:01:58 -040082 mDriverUniformsDescriptorSet(VK_NULL_HANDLE),
83 mDefaultAttribBuffers{{INIT, INIT, INIT, INIT, INIT, INIT, INIT, INIT, INIT, INIT, INIT, INIT,
84 INIT, INIT, INIT, INIT}}
Jamie Madill9e54b5a2016-05-25 12:57:39 -040085{
Jamie Madillf4d693c2018-02-14 16:38:16 -050086 memset(&mClearColorValue, 0, sizeof(mClearColorValue));
87 memset(&mClearDepthStencilValue, 0, sizeof(mClearDepthStencilValue));
Jamie Madill9e54b5a2016-05-25 12:57:39 -040088}
89
Jamie Madill84c662b2018-07-12 15:56:55 -040090ContextVk::~ContextVk() = default;
Jamie Madill9e54b5a2016-05-25 12:57:39 -040091
Jamie Madill76e471e2017-10-21 09:56:01 -040092void ContextVk::onDestroy(const gl::Context *context)
93{
Jamie Madill834a3a12018-07-09 13:32:39 -040094 mDriverUniformsSetLayout.reset();
Luc Ferron90968362018-05-04 08:47:22 -040095 mIncompleteTextures.onDestroy(context);
Jamie Madill834a3a12018-07-09 13:32:39 -040096 mDriverUniformsBuffer.destroy(getDevice());
Jamie Madilledeaa832018-06-22 09:18:41 -040097
98 for (vk::DynamicDescriptorPool &descriptorPool : mDynamicDescriptorPools)
99 {
100 descriptorPool.destroy(getDevice());
101 }
Jamie Madill5a4c9322018-07-16 11:01:58 -0400102
103 for (vk::DynamicBuffer &defaultBuffer : mDefaultAttribBuffers)
104 {
105 defaultBuffer.destroy(getDevice());
106 }
Jamie Madill76e471e2017-10-21 09:56:01 -0400107}
108
Luc Ferron90968362018-05-04 08:47:22 -0400109gl::Error ContextVk::getIncompleteTexture(const gl::Context *context,
110 gl::TextureType type,
111 gl::Texture **textureOut)
112{
113 // At some point, we'll need to support multisample and we'll pass "this" instead of nullptr
114 // and implement the necessary interface.
115 return mIncompleteTextures.getIncompleteTexture(context, type, nullptr, textureOut);
116}
117
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400118gl::Error ContextVk::initialize()
119{
Jamie Madill8a4c49f2018-06-21 15:43:06 -0400120 // Note that this may reserve more sets than strictly necessary for a particular layout.
Jamie Madille4a6d7a2018-07-09 13:32:37 -0400121 VkDescriptorPoolSize uniformPoolSize = {
122 VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC,
123 GetUniformBufferDescriptorCount() * vk::kDefaultDescriptorPoolMaxSets};
Jamie Madill834a3a12018-07-09 13:32:39 -0400124
Jamie Madill21061022018-07-12 23:56:30 -0400125 ANGLE_TRY(mDynamicDescriptorPools[kUniformsDescriptorSetIndex].init(this, uniformPoolSize));
Jamie Madille4a6d7a2018-07-09 13:32:37 -0400126
127 VkDescriptorPoolSize imageSamplerPoolSize = {
128 VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER,
129 mRenderer->getMaxActiveTextures() * vk::kDefaultDescriptorPoolMaxSets};
Jamie Madill21061022018-07-12 23:56:30 -0400130 ANGLE_TRY(mDynamicDescriptorPools[kTextureDescriptorSetIndex].init(this, imageSamplerPoolSize));
Jamie Madill76e471e2017-10-21 09:56:01 -0400131
Jamie Madill834a3a12018-07-09 13:32:39 -0400132 VkDescriptorPoolSize driverUniformsPoolSize = {VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
133 vk::kDefaultDescriptorPoolMaxSets};
134 ANGLE_TRY(mDynamicDescriptorPools[kDriverUniformsDescriptorSetIndex].init(
Jamie Madill21061022018-07-12 23:56:30 -0400135 this, driverUniformsPoolSize));
Jamie Madill834a3a12018-07-09 13:32:39 -0400136
Frank Henigman18f7e502018-07-19 16:06:43 -0400137 size_t minAlignment = static_cast<size_t>(
138 mRenderer->getPhysicalDeviceProperties().limits.minUniformBufferOffsetAlignment);
139 mDriverUniformsBuffer.init(minAlignment, mRenderer);
140
Jamie Madillf2f6d372018-01-10 21:37:23 -0500141 mPipelineDesc.reset(new vk::PipelineDesc());
142 mPipelineDesc->initDefaults();
143
Jamie Madill5a4c9322018-07-16 11:01:58 -0400144 // Initialize current value/default attribute buffers.
145 for (vk::DynamicBuffer &buffer : mDefaultAttribBuffers)
146 {
147 buffer.init(1, mRenderer);
148 }
149
Jamie Madille09bd5d2016-11-29 16:20:35 -0500150 return gl::NoError();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400151}
152
Jamie Madillafa02a22017-11-23 12:57:38 -0500153gl::Error ContextVk::flush(const gl::Context *context)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400154{
Jamie Madilla2f043d2018-07-10 17:21:20 -0400155 // TODO(jmadill): Multiple flushes will need to insert semaphores. http://anglebug.com/2504
Luc Ferron33140402018-03-08 13:57:52 -0500156
157 // dEQP tests rely on having no errors thrown at the end of the test and they always call
158 // flush at the end of the their tests. Just returning NoError until we implement flush
159 // allow us to work on enabling many tests in the meantime.
Jamie Madilla2f043d2018-07-10 17:21:20 -0400160 WARN() << "Flush is unimplemented. http://anglebug.com/2504";
Luc Ferron33140402018-03-08 13:57:52 -0500161 return gl::NoError();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400162}
163
Jamie Madillafa02a22017-11-23 12:57:38 -0500164gl::Error ContextVk::finish(const gl::Context *context)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400165{
Jamie Madill21061022018-07-12 23:56:30 -0400166 return mRenderer->finish(this);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400167}
168
Jamie Madill06ca6342018-07-12 15:56:53 -0400169gl::Error ContextVk::initPipeline(const gl::DrawCallParams &drawCallParams)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400170{
Jamie Madillffa4cbb2018-01-23 13:04:07 -0500171 ASSERT(!mCurrentPipeline);
Jamie Madill72106562017-03-24 14:18:50 -0400172
Jamie Madillf2f6d372018-01-10 21:37:23 -0500173 const gl::State &state = mState.getState();
174 VertexArrayVk *vertexArrayVk = vk::GetImpl(state.getVertexArray());
175 FramebufferVk *framebufferVk = vk::GetImpl(state.getDrawFramebuffer());
176 ProgramVk *programVk = vk::GetImpl(state.getProgram());
Luc Ferronceb71902018-02-05 15:18:47 -0500177 const gl::AttributesMask activeAttribLocationsMask =
178 state.getProgram()->getActiveAttribLocationsMask();
Jamie Madillf2f6d372018-01-10 21:37:23 -0500179
180 // Ensure the topology of the pipeline description is updated.
181 mPipelineDesc->updateTopology(mCurrentDrawMode);
Jamie Madilldf68a6f2017-01-13 17:29:53 -0500182
Jamie Madill112a3a82018-01-23 13:04:06 -0500183 // Copy over the latest attrib and binding descriptions.
Frank Henigman419acc82018-06-24 19:57:31 -0400184 vertexArrayVk->getPackedInputDescriptions(mPipelineDesc.get());
Jamie Madilldf68a6f2017-01-13 17:29:53 -0500185
Jamie Madillf2f6d372018-01-10 21:37:23 -0500186 // Ensure that the RenderPass description is updated.
Jamie Madillb90779e2018-04-27 11:45:01 -0400187 mPipelineDesc->updateRenderPassDesc(framebufferVk->getRenderPassDesc());
Jamie Madilldf68a6f2017-01-13 17:29:53 -0500188
Jamie Madill06ca6342018-07-12 15:56:53 -0400189 // Trigger draw call shader patching and fill out the pipeline desc.
190 const vk::ShaderAndSerial *vertexShaderAndSerial = nullptr;
191 const vk::ShaderAndSerial *fragmentShaderAndSerial = nullptr;
Jamie Madill242c4fe2018-07-12 15:56:56 -0400192 const vk::PipelineLayout *pipelineLayout = nullptr;
Jamie Madill06ca6342018-07-12 15:56:53 -0400193 ANGLE_TRY(programVk->initShaders(this, drawCallParams, &vertexShaderAndSerial,
Jamie Madill242c4fe2018-07-12 15:56:56 -0400194 &fragmentShaderAndSerial, &pipelineLayout));
Jamie Madill06ca6342018-07-12 15:56:53 -0400195
196 mPipelineDesc->updateShaders(vertexShaderAndSerial->getSerial(),
197 fragmentShaderAndSerial->getSerial());
198
Jamie Madill06ca6342018-07-12 15:56:53 -0400199 ANGLE_TRY(mRenderer->getPipeline(this, *vertexShaderAndSerial, *fragmentShaderAndSerial,
Jamie Madill242c4fe2018-07-12 15:56:56 -0400200 *pipelineLayout, *mPipelineDesc, activeAttribLocationsMask,
Jamie Madill06ca6342018-07-12 15:56:53 -0400201 &mCurrentPipeline));
Jamie Madilldf68a6f2017-01-13 17:29:53 -0500202
Jamie Madill72106562017-03-24 14:18:50 -0400203 return gl::NoError();
204}
205
Luc Ferron90968362018-05-04 08:47:22 -0400206gl::Error ContextVk::setupDraw(const gl::Context *context,
207 const gl::DrawCallParams &drawCallParams,
Jamie Madill316c6062018-05-29 10:49:45 -0400208 vk::CommandBuffer **commandBufferOut,
209 bool *shouldApplyVertexArrayOut)
Jamie Madill72106562017-03-24 14:18:50 -0400210{
Jamie Madill32fd63b2018-03-31 11:20:35 -0400211 if (drawCallParams.mode() != mCurrentDrawMode)
Jamie Madill72106562017-03-24 14:18:50 -0400212 {
213 invalidateCurrentPipeline();
Jamie Madill32fd63b2018-03-31 11:20:35 -0400214 mCurrentDrawMode = drawCallParams.mode();
Jamie Madill72106562017-03-24 14:18:50 -0400215 }
216
Jamie Madill5a4c9322018-07-16 11:01:58 -0400217 if (mDirtyDefaultAttribs.any())
218 {
219 ANGLE_TRY(updateDefaultAttributes());
220 }
221
Jamie Madillffa4cbb2018-01-23 13:04:07 -0500222 if (!mCurrentPipeline)
Jamie Madill72106562017-03-24 14:18:50 -0400223 {
Jamie Madill06ca6342018-07-12 15:56:53 -0400224 ANGLE_TRY(initPipeline(drawCallParams));
Jamie Madill72106562017-03-24 14:18:50 -0400225 }
226
Jamie Madill50cf2be2018-06-15 09:46:57 -0400227 const auto &state = mState.getState();
228 const gl::Program *programGL = state.getProgram();
229 ProgramVk *programVk = vk::GetImpl(programGL);
Jamie Madill316c6062018-05-29 10:49:45 -0400230 const gl::Framebuffer *framebuffer = state.getDrawFramebuffer();
231 FramebufferVk *framebufferVk = vk::GetImpl(framebuffer);
Jamie Madill50cf2be2018-06-15 09:46:57 -0400232 Serial queueSerial = mRenderer->getCurrentQueueSerial();
Jamie Madill72106562017-03-24 14:18:50 -0400233
Jamie Madill316c6062018-05-29 10:49:45 -0400234 vk::RecordingMode mode = vk::RecordingMode::Start;
235 ANGLE_TRY(framebufferVk->getCommandBufferForDraw(this, commandBufferOut, &mode));
Jamie Madilldf68a6f2017-01-13 17:29:53 -0500236
Jamie Madill316c6062018-05-29 10:49:45 -0400237 if (mode == vk::RecordingMode::Start)
Jamie Madill49ac74b2017-12-21 14:42:33 -0500238 {
Jamie Madill316c6062018-05-29 10:49:45 -0400239 mTexturesDirty = true;
240 *shouldApplyVertexArrayOut = true;
Jamie Madill49ac74b2017-12-21 14:42:33 -0500241 }
242 else
243 {
Luc Ferron6ed167a2018-06-13 13:45:55 -0400244 *shouldApplyVertexArrayOut = mVertexArrayBindingHasChanged;
245 mVertexArrayBindingHasChanged = false;
Jamie Madill49ac74b2017-12-21 14:42:33 -0500246 }
247
248 // Ensure any writes to the textures are flushed before we read from them.
249 if (mTexturesDirty)
250 {
251 mTexturesDirty = false;
Jamie Madill84c662b2018-07-12 15:56:55 -0400252
Jamie Madill49ac74b2017-12-21 14:42:33 -0500253 // TODO(jmadill): Should probably merge this for loop with programVk's descriptor update.
Jamie Madill7e4eff12018-08-08 15:49:26 -0400254 for (size_t textureIndex : programGL->getActiveSamplersMask())
Jamie Madill49ac74b2017-12-21 14:42:33 -0500255 {
Jamie Madill84c662b2018-07-12 15:56:55 -0400256 TextureVk *textureVk = mActiveTextures[textureIndex];
257 ANGLE_TRY(textureVk->ensureImageInitialized(this));
258 textureVk->addReadDependency(framebufferVk);
Jamie Madill49ac74b2017-12-21 14:42:33 -0500259 }
260 }
261
Jamie Madill316c6062018-05-29 10:49:45 -0400262 (*commandBufferOut)->bindPipeline(VK_PIPELINE_BIND_POINT_GRAPHICS, mCurrentPipeline->get());
Jamie Madill49ac74b2017-12-21 14:42:33 -0500263
264 // Update the queue serial for the pipeline object.
Jamie Madillffa4cbb2018-01-23 13:04:07 -0500265 ASSERT(mCurrentPipeline && mCurrentPipeline->valid());
266 mCurrentPipeline->updateSerial(queueSerial);
Jamie Madilldf68a6f2017-01-13 17:29:53 -0500267
Jamie Madill76e471e2017-10-21 09:56:01 -0400268 // Bind the graphics descriptor sets.
Jamie Madill242c4fe2018-07-12 15:56:56 -0400269 ANGLE_TRY(programVk->updateDescriptorSets(this, drawCallParams, mDriverUniformsDescriptorSet,
270 *commandBufferOut));
Jamie Madilldf68a6f2017-01-13 17:29:53 -0500271 return gl::NoError();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400272}
273
Jamie Madill493f9572018-05-24 19:52:15 -0400274gl::Error ContextVk::drawArrays(const gl::Context *context,
275 gl::PrimitiveMode mode,
276 GLint first,
277 GLsizei count)
Jamie Madilld03a8492017-10-03 15:46:06 -0400278{
Jamie Madill32fd63b2018-03-31 11:20:35 -0400279 const gl::DrawCallParams &drawCallParams = context->getParams<gl::DrawCallParams>();
280
Jamie Madill316c6062018-05-29 10:49:45 -0400281 vk::CommandBuffer *commandBuffer = nullptr;
282 bool shouldApplyVertexArray = false;
283 ANGLE_TRY(setupDraw(context, drawCallParams, &commandBuffer, &shouldApplyVertexArray));
Luc Ferron360098d2018-02-21 07:33:50 -0500284
Jamie Madillc3755fc2018-04-05 08:39:13 -0400285 const gl::VertexArray *vertexArray = context->getGLState().getVertexArray();
286 VertexArrayVk *vertexArrayVk = vk::GetImpl(vertexArray);
Jamie Madill21061022018-07-12 23:56:30 -0400287 ANGLE_TRY(
288 vertexArrayVk->drawArrays(context, drawCallParams, commandBuffer, shouldApplyVertexArray));
Luc Ferron360098d2018-02-21 07:33:50 -0500289
Jamie Madilld03a8492017-10-03 15:46:06 -0400290 return gl::NoError();
291}
292
Jamie Madillc564c072017-06-01 12:45:42 -0400293gl::Error ContextVk::drawArraysInstanced(const gl::Context *context,
Jamie Madill493f9572018-05-24 19:52:15 -0400294 gl::PrimitiveMode mode,
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400295 GLint first,
296 GLsizei count,
297 GLsizei instanceCount)
298{
299 UNIMPLEMENTED();
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500300 return gl::InternalError();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400301}
302
Jamie Madillc564c072017-06-01 12:45:42 -0400303gl::Error ContextVk::drawElements(const gl::Context *context,
Jamie Madill493f9572018-05-24 19:52:15 -0400304 gl::PrimitiveMode mode,
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400305 GLsizei count,
306 GLenum type,
Qin Jiajia1da00652017-06-20 17:16:25 +0800307 const void *indices)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400308{
Jamie Madill32fd63b2018-03-31 11:20:35 -0400309 const gl::DrawCallParams &drawCallParams = context->getParams<gl::DrawCallParams>();
310
Jamie Madill316c6062018-05-29 10:49:45 -0400311 vk::CommandBuffer *commandBuffer = nullptr;
312 bool shouldApplyVertexArray = false;
313 ANGLE_TRY(setupDraw(context, drawCallParams, &commandBuffer, &shouldApplyVertexArray));
Jamie Madilld03a8492017-10-03 15:46:06 -0400314
Jamie Madillc3755fc2018-04-05 08:39:13 -0400315 gl::VertexArray *vao = mState.getState().getVertexArray();
316 VertexArrayVk *vertexArrayVk = vk::GetImpl(vao);
Jamie Madill21061022018-07-12 23:56:30 -0400317 ANGLE_TRY(vertexArrayVk->drawElements(context, drawCallParams, commandBuffer,
Jamie Madill316c6062018-05-29 10:49:45 -0400318 shouldApplyVertexArray));
Jamie Madilld03a8492017-10-03 15:46:06 -0400319
320 return gl::NoError();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400321}
322
Jamie Madillc564c072017-06-01 12:45:42 -0400323gl::Error ContextVk::drawElementsInstanced(const gl::Context *context,
Jamie Madill493f9572018-05-24 19:52:15 -0400324 gl::PrimitiveMode mode,
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400325 GLsizei count,
326 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -0400327 const void *indices,
Qin Jiajia1da00652017-06-20 17:16:25 +0800328 GLsizei instances)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400329{
330 UNIMPLEMENTED();
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500331 return gl::InternalError();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400332}
333
Jamie Madillc564c072017-06-01 12:45:42 -0400334gl::Error ContextVk::drawRangeElements(const gl::Context *context,
Jamie Madill493f9572018-05-24 19:52:15 -0400335 gl::PrimitiveMode mode,
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400336 GLuint start,
337 GLuint end,
338 GLsizei count,
339 GLenum type,
Qin Jiajia1da00652017-06-20 17:16:25 +0800340 const void *indices)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400341{
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500342 return gl::NoError();
343}
344
345VkDevice ContextVk::getDevice() const
346{
347 return mRenderer->getDevice();
348}
349
Jamie Madillc564c072017-06-01 12:45:42 -0400350gl::Error ContextVk::drawArraysIndirect(const gl::Context *context,
Jamie Madill493f9572018-05-24 19:52:15 -0400351 gl::PrimitiveMode mode,
Jamie Madillc564c072017-06-01 12:45:42 -0400352 const void *indirect)
Jiajia Qind9671222016-11-29 16:30:31 +0800353{
354 UNIMPLEMENTED();
355 return gl::InternalError() << "DrawArraysIndirect hasn't been implemented for vulkan backend.";
356}
357
Jamie Madillc564c072017-06-01 12:45:42 -0400358gl::Error ContextVk::drawElementsIndirect(const gl::Context *context,
Jamie Madill493f9572018-05-24 19:52:15 -0400359 gl::PrimitiveMode mode,
Jamie Madillc564c072017-06-01 12:45:42 -0400360 GLenum type,
361 const void *indirect)
Jiajia Qind9671222016-11-29 16:30:31 +0800362{
363 UNIMPLEMENTED();
364 return gl::InternalError()
365 << "DrawElementsIndirect hasn't been implemented for vulkan backend.";
366}
367
Corentin Wallez87fbe1c2016-08-03 14:41:42 -0400368GLenum ContextVk::getResetStatus()
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400369{
370 UNIMPLEMENTED();
Corentin Wallez87fbe1c2016-08-03 14:41:42 -0400371 return GL_NO_ERROR;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400372}
373
374std::string ContextVk::getVendorString() const
375{
376 UNIMPLEMENTED();
377 return std::string();
378}
379
380std::string ContextVk::getRendererDescription() const
381{
Jamie Madille09bd5d2016-11-29 16:20:35 -0500382 return mRenderer->getRendererDescription();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400383}
384
385void ContextVk::insertEventMarker(GLsizei length, const char *marker)
386{
387 UNIMPLEMENTED();
388}
389
390void ContextVk::pushGroupMarker(GLsizei length, const char *marker)
391{
392 UNIMPLEMENTED();
393}
394
395void ContextVk::popGroupMarker()
396{
397 UNIMPLEMENTED();
398}
399
Geoff Lang5d5253a2017-11-22 14:51:12 -0500400void ContextVk::pushDebugGroup(GLenum source, GLuint id, GLsizei length, const char *message)
401{
402 UNIMPLEMENTED();
403}
404
405void ContextVk::popDebugGroup()
406{
407 UNIMPLEMENTED();
408}
409
Luc Ferron82eda932018-07-09 15:10:22 -0400410bool ContextVk::isViewportFlipEnabledForDrawFBO() const
Luc Ferronbf6dc372018-06-28 15:24:19 -0400411{
Luc Ferron82eda932018-07-09 15:10:22 -0400412 return mFlipViewportForDrawFramebuffer && mFlipYForCurrentSurface;
413}
414
415bool ContextVk::isViewportFlipEnabledForReadFBO() const
416{
417 return mFlipViewportForReadFramebuffer;
Luc Ferronbf6dc372018-06-28 15:24:19 -0400418}
419
Luc Ferron0bb940a2018-06-22 09:59:34 -0400420void ContextVk::updateColorMask(const gl::BlendState &blendState)
Luc Ferron5fd36932018-06-19 14:55:50 -0400421{
422 mClearColorMask =
423 gl_vk::GetColorComponentFlags(blendState.colorMaskRed, blendState.colorMaskGreen,
424 blendState.colorMaskBlue, blendState.colorMaskAlpha);
425
426 FramebufferVk *framebufferVk = vk::GetImpl(mState.getState().getDrawFramebuffer());
427 mPipelineDesc->updateColorWriteMask(mClearColorMask,
428 framebufferVk->getEmulatedAlphaAttachmentMask());
429}
430
Jamie Madill84c662b2018-07-12 15:56:55 -0400431void ContextVk::updateScissor(const gl::State &glState) const
Luc Ferrond17bdfe2018-04-05 13:50:10 -0400432{
Jamie Madill84c662b2018-07-12 15:56:55 -0400433 FramebufferVk *framebufferVk = vk::GetImpl(glState.getDrawFramebuffer());
Luc Ferronbf6dc372018-06-28 15:24:19 -0400434 gl::Box dimensions = framebufferVk->getState().getDimensions();
435 gl::Rectangle renderArea(0, 0, dimensions.width, dimensions.height);
436
Luc Ferrond17bdfe2018-04-05 13:50:10 -0400437 if (glState.isScissorTestEnabled())
438 {
Luc Ferron82eda932018-07-09 15:10:22 -0400439 mPipelineDesc->updateScissor(glState.getScissor(), isViewportFlipEnabledForDrawFBO(),
440 renderArea);
Luc Ferrond17bdfe2018-04-05 13:50:10 -0400441 }
442 else
443 {
Luc Ferron14f48172018-04-11 08:43:28 -0400444 // If the scissor test isn't enabled, we can simply use a really big scissor that's
445 // certainly larger than the current surface using the maximum size of a 2D texture
446 // for the width and height.
Luc Ferron82eda932018-07-09 15:10:22 -0400447 mPipelineDesc->updateScissor(kMaxSizedScissor, isViewportFlipEnabledForDrawFBO(),
448 renderArea);
Luc Ferrond17bdfe2018-04-05 13:50:10 -0400449 }
450}
451
Jamie Madill189ad872018-07-09 13:32:37 -0400452gl::Error ContextVk::syncState(const gl::Context *context, const gl::State::DirtyBits &dirtyBits)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400453{
Jamie Madill72106562017-03-24 14:18:50 -0400454 if (dirtyBits.any())
455 {
456 invalidateCurrentPipeline();
457 }
Jamie Madillebf72992017-10-13 14:09:45 -0400458
459 const auto &glState = context->getGLState();
460
461 // TODO(jmadill): Full dirty bits implementation.
Jamie Madill5547b382017-10-23 18:16:01 -0400462 bool dirtyTextures = false;
Jamie Madillebf72992017-10-13 14:09:45 -0400463
464 for (auto dirtyBit : dirtyBits)
465 {
466 switch (dirtyBit)
467 {
468 case gl::State::DIRTY_BIT_SCISSOR_TEST_ENABLED:
Jamie Madillebf72992017-10-13 14:09:45 -0400469 case gl::State::DIRTY_BIT_SCISSOR:
Luc Ferron14f48172018-04-11 08:43:28 -0400470 updateScissor(glState);
Jamie Madillebf72992017-10-13 14:09:45 -0400471 break;
472 case gl::State::DIRTY_BIT_VIEWPORT:
Luc Ferron1a135ad2018-07-04 10:35:31 -0400473 {
474 FramebufferVk *framebufferVk = vk::GetImpl(glState.getDrawFramebuffer());
475 mPipelineDesc->updateViewport(framebufferVk, glState.getViewport(),
476 glState.getNearPlane(), glState.getFarPlane(),
Luc Ferron82eda932018-07-09 15:10:22 -0400477 isViewportFlipEnabledForDrawFBO());
Luc Ferrone8356092018-07-12 12:36:47 -0400478 ANGLE_TRY(updateDriverUniforms(glState));
Jamie Madillebf72992017-10-13 14:09:45 -0400479 break;
Luc Ferron1a135ad2018-07-04 10:35:31 -0400480 }
Jamie Madillebf72992017-10-13 14:09:45 -0400481 case gl::State::DIRTY_BIT_DEPTH_RANGE:
Luc Ferron0986f1c2018-04-16 13:47:23 -0400482 mPipelineDesc->updateDepthRange(glState.getNearPlane(), glState.getFarPlane());
Luc Ferrone8356092018-07-12 12:36:47 -0400483 ANGLE_TRY(updateDriverUniforms(glState));
Jamie Madillebf72992017-10-13 14:09:45 -0400484 break;
485 case gl::State::DIRTY_BIT_BLEND_ENABLED:
Luc Ferronf8be7562018-02-06 15:59:11 -0500486 mPipelineDesc->updateBlendEnabled(glState.isBlendEnabled());
Jamie Madillebf72992017-10-13 14:09:45 -0400487 break;
488 case gl::State::DIRTY_BIT_BLEND_COLOR:
Luc Ferronf8be7562018-02-06 15:59:11 -0500489 mPipelineDesc->updateBlendColor(glState.getBlendColor());
Jamie Madillebf72992017-10-13 14:09:45 -0400490 break;
491 case gl::State::DIRTY_BIT_BLEND_FUNCS:
Luc Ferronf8be7562018-02-06 15:59:11 -0500492 mPipelineDesc->updateBlendFuncs(glState.getBlendState());
Jamie Madillebf72992017-10-13 14:09:45 -0400493 break;
494 case gl::State::DIRTY_BIT_BLEND_EQUATIONS:
Luc Ferronf8be7562018-02-06 15:59:11 -0500495 mPipelineDesc->updateBlendEquations(glState.getBlendState());
Jamie Madillebf72992017-10-13 14:09:45 -0400496 break;
497 case gl::State::DIRTY_BIT_COLOR_MASK:
Luc Ferron0bb940a2018-06-22 09:59:34 -0400498 updateColorMask(glState.getBlendState());
Jamie Madillebf72992017-10-13 14:09:45 -0400499 break;
500 case gl::State::DIRTY_BIT_SAMPLE_ALPHA_TO_COVERAGE_ENABLED:
Jamie Madillebf72992017-10-13 14:09:45 -0400501 break;
502 case gl::State::DIRTY_BIT_SAMPLE_COVERAGE_ENABLED:
Jamie Madillebf72992017-10-13 14:09:45 -0400503 break;
504 case gl::State::DIRTY_BIT_SAMPLE_COVERAGE:
Jamie Madillebf72992017-10-13 14:09:45 -0400505 break;
506 case gl::State::DIRTY_BIT_SAMPLE_MASK_ENABLED:
Jamie Madillebf72992017-10-13 14:09:45 -0400507 break;
Jamie Madillc67323a2017-11-02 23:11:41 -0400508 case gl::State::DIRTY_BIT_SAMPLE_MASK:
Jamie Madillebf72992017-10-13 14:09:45 -0400509 break;
510 case gl::State::DIRTY_BIT_DEPTH_TEST_ENABLED:
Geoff Langc16f5182018-07-18 10:40:03 -0400511 mPipelineDesc->updateDepthTestEnabled(glState.getDepthStencilState(),
512 glState.getDrawFramebuffer());
Jamie Madillebf72992017-10-13 14:09:45 -0400513 break;
514 case gl::State::DIRTY_BIT_DEPTH_FUNC:
Jamie Madill0cec82a2018-03-14 09:21:07 -0400515 mPipelineDesc->updateDepthFunc(glState.getDepthStencilState());
Jamie Madillebf72992017-10-13 14:09:45 -0400516 break;
517 case gl::State::DIRTY_BIT_DEPTH_MASK:
Geoff Langc16f5182018-07-18 10:40:03 -0400518 mPipelineDesc->updateDepthWriteEnabled(glState.getDepthStencilState(),
519 glState.getDrawFramebuffer());
Jamie Madillebf72992017-10-13 14:09:45 -0400520 break;
521 case gl::State::DIRTY_BIT_STENCIL_TEST_ENABLED:
Geoff Langc16f5182018-07-18 10:40:03 -0400522 mPipelineDesc->updateStencilTestEnabled(glState.getDepthStencilState(),
523 glState.getDrawFramebuffer());
Jamie Madillebf72992017-10-13 14:09:45 -0400524 break;
525 case gl::State::DIRTY_BIT_STENCIL_FUNCS_FRONT:
Luc Ferron364a9552018-03-29 09:44:51 -0400526 mPipelineDesc->updateStencilFrontFuncs(glState.getStencilRef(),
527 glState.getDepthStencilState());
Jamie Madillebf72992017-10-13 14:09:45 -0400528 break;
529 case gl::State::DIRTY_BIT_STENCIL_FUNCS_BACK:
Luc Ferron364a9552018-03-29 09:44:51 -0400530 mPipelineDesc->updateStencilBackFuncs(glState.getStencilBackRef(),
531 glState.getDepthStencilState());
Jamie Madillebf72992017-10-13 14:09:45 -0400532 break;
533 case gl::State::DIRTY_BIT_STENCIL_OPS_FRONT:
Luc Ferron364a9552018-03-29 09:44:51 -0400534 mPipelineDesc->updateStencilFrontOps(glState.getDepthStencilState());
Jamie Madillebf72992017-10-13 14:09:45 -0400535 break;
536 case gl::State::DIRTY_BIT_STENCIL_OPS_BACK:
Luc Ferron364a9552018-03-29 09:44:51 -0400537 mPipelineDesc->updateStencilBackOps(glState.getDepthStencilState());
Jamie Madillebf72992017-10-13 14:09:45 -0400538 break;
539 case gl::State::DIRTY_BIT_STENCIL_WRITEMASK_FRONT:
Geoff Langc16f5182018-07-18 10:40:03 -0400540 mPipelineDesc->updateStencilFrontWriteMask(glState.getDepthStencilState(),
541 glState.getDrawFramebuffer());
Jamie Madillebf72992017-10-13 14:09:45 -0400542 break;
543 case gl::State::DIRTY_BIT_STENCIL_WRITEMASK_BACK:
Geoff Langc16f5182018-07-18 10:40:03 -0400544 mPipelineDesc->updateStencilBackWriteMask(glState.getDepthStencilState(),
545 glState.getDrawFramebuffer());
Jamie Madillebf72992017-10-13 14:09:45 -0400546 break;
547 case gl::State::DIRTY_BIT_CULL_FACE_ENABLED:
548 case gl::State::DIRTY_BIT_CULL_FACE:
Luc Ferronb70ad522018-07-09 16:06:26 -0400549 mPipelineDesc->updateCullMode(glState.getRasterizerState());
Jamie Madillebf72992017-10-13 14:09:45 -0400550 break;
551 case gl::State::DIRTY_BIT_FRONT_FACE:
Luc Ferronb70ad522018-07-09 16:06:26 -0400552 mPipelineDesc->updateFrontFace(glState.getRasterizerState(),
553 isViewportFlipEnabledForDrawFBO());
Jamie Madillebf72992017-10-13 14:09:45 -0400554 break;
555 case gl::State::DIRTY_BIT_POLYGON_OFFSET_FILL_ENABLED:
Frank Henigmand731ff82018-08-13 18:18:51 -0400556 mPipelineDesc->updatePolygonOffsetFillEnabled(glState.isPolygonOffsetFillEnabled());
Jamie Madillebf72992017-10-13 14:09:45 -0400557 break;
558 case gl::State::DIRTY_BIT_POLYGON_OFFSET:
Frank Henigmand731ff82018-08-13 18:18:51 -0400559 mPipelineDesc->updatePolygonOffset(glState.getRasterizerState());
Jamie Madillebf72992017-10-13 14:09:45 -0400560 break;
561 case gl::State::DIRTY_BIT_RASTERIZER_DISCARD_ENABLED:
Jamie Madillebf72992017-10-13 14:09:45 -0400562 break;
563 case gl::State::DIRTY_BIT_LINE_WIDTH:
Jamie Madillf2f6d372018-01-10 21:37:23 -0500564 mPipelineDesc->updateLineWidth(glState.getLineWidth());
Jamie Madillebf72992017-10-13 14:09:45 -0400565 break;
566 case gl::State::DIRTY_BIT_PRIMITIVE_RESTART_ENABLED:
Jamie Madillebf72992017-10-13 14:09:45 -0400567 break;
568 case gl::State::DIRTY_BIT_CLEAR_COLOR:
Jamie Madillf4d693c2018-02-14 16:38:16 -0500569 mClearColorValue.color.float32[0] = glState.getColorClearValue().red;
570 mClearColorValue.color.float32[1] = glState.getColorClearValue().green;
571 mClearColorValue.color.float32[2] = glState.getColorClearValue().blue;
572 mClearColorValue.color.float32[3] = glState.getColorClearValue().alpha;
Jamie Madillebf72992017-10-13 14:09:45 -0400573 break;
574 case gl::State::DIRTY_BIT_CLEAR_DEPTH:
Jamie Madillf4d693c2018-02-14 16:38:16 -0500575 mClearDepthStencilValue.depthStencil.depth = glState.getDepthClearValue();
Jamie Madillebf72992017-10-13 14:09:45 -0400576 break;
577 case gl::State::DIRTY_BIT_CLEAR_STENCIL:
Jamie Madillf4d693c2018-02-14 16:38:16 -0500578 mClearDepthStencilValue.depthStencil.stencil =
579 static_cast<uint32_t>(glState.getStencilClearValue());
Jamie Madillebf72992017-10-13 14:09:45 -0400580 break;
Jamie Madillc67323a2017-11-02 23:11:41 -0400581 case gl::State::DIRTY_BIT_UNPACK_STATE:
Luc Ferronf9749ea2018-04-24 15:34:53 -0400582 // This is a no-op, its only important to use the right unpack state when we do
583 // setImage or setSubImage in TextureVk, which is plumbed through the frontend call
Jamie Madillebf72992017-10-13 14:09:45 -0400584 break;
Corentin Wallez29a20992017-11-06 18:23:16 -0500585 case gl::State::DIRTY_BIT_UNPACK_BUFFER_BINDING:
Corentin Wallez29a20992017-11-06 18:23:16 -0500586 break;
Jamie Madillc67323a2017-11-02 23:11:41 -0400587 case gl::State::DIRTY_BIT_PACK_STATE:
Luc Ferrona1c72422018-05-14 15:58:28 -0400588 // This is a no-op, its only important to use the right pack state when we do
589 // call readPixels later on.
Jamie Madillebf72992017-10-13 14:09:45 -0400590 break;
Corentin Wallez29a20992017-11-06 18:23:16 -0500591 case gl::State::DIRTY_BIT_PACK_BUFFER_BINDING:
Corentin Wallez29a20992017-11-06 18:23:16 -0500592 break;
Jamie Madillebf72992017-10-13 14:09:45 -0400593 case gl::State::DIRTY_BIT_DITHER_ENABLED:
Jamie Madillebf72992017-10-13 14:09:45 -0400594 break;
595 case gl::State::DIRTY_BIT_GENERATE_MIPMAP_HINT:
Jamie Madillebf72992017-10-13 14:09:45 -0400596 break;
597 case gl::State::DIRTY_BIT_SHADER_DERIVATIVE_HINT:
Jamie Madillebf72992017-10-13 14:09:45 -0400598 break;
599 case gl::State::DIRTY_BIT_READ_FRAMEBUFFER_BINDING:
Luc Ferron82eda932018-07-09 15:10:22 -0400600 updateFlipViewportReadFramebuffer(context->getGLState());
Jamie Madillebf72992017-10-13 14:09:45 -0400601 break;
602 case gl::State::DIRTY_BIT_DRAW_FRAMEBUFFER_BINDING:
Luc Ferron1a135ad2018-07-04 10:35:31 -0400603 {
Luc Ferrone8356092018-07-12 12:36:47 -0400604 ANGLE_TRY(updateDriverUniforms(glState));
605 updateFlipViewportDrawFramebuffer(glState);
Luc Ferron1a135ad2018-07-04 10:35:31 -0400606 FramebufferVk *framebufferVk = vk::GetImpl(glState.getDrawFramebuffer());
607 mPipelineDesc->updateViewport(framebufferVk, glState.getViewport(),
608 glState.getNearPlane(), glState.getFarPlane(),
Luc Ferron82eda932018-07-09 15:10:22 -0400609 isViewportFlipEnabledForDrawFBO());
Luc Ferron0bb940a2018-06-22 09:59:34 -0400610 updateColorMask(glState.getBlendState());
Luc Ferronb70ad522018-07-09 16:06:26 -0400611 mPipelineDesc->updateCullMode(glState.getRasterizerState());
Luc Ferronbf6dc372018-06-28 15:24:19 -0400612 updateScissor(glState);
Geoff Langc16f5182018-07-18 10:40:03 -0400613 mPipelineDesc->updateDepthTestEnabled(glState.getDepthStencilState(),
614 glState.getDrawFramebuffer());
615 mPipelineDesc->updateDepthWriteEnabled(glState.getDepthStencilState(),
616 glState.getDrawFramebuffer());
617 mPipelineDesc->updateStencilTestEnabled(glState.getDepthStencilState(),
618 glState.getDrawFramebuffer());
619 mPipelineDesc->updateStencilFrontWriteMask(glState.getDepthStencilState(),
620 glState.getDrawFramebuffer());
621 mPipelineDesc->updateStencilBackWriteMask(glState.getDepthStencilState(),
622 glState.getDrawFramebuffer());
Jamie Madillebf72992017-10-13 14:09:45 -0400623 break;
Luc Ferron1a135ad2018-07-04 10:35:31 -0400624 }
Jamie Madillebf72992017-10-13 14:09:45 -0400625 case gl::State::DIRTY_BIT_RENDERBUFFER_BINDING:
Jamie Madillebf72992017-10-13 14:09:45 -0400626 break;
627 case gl::State::DIRTY_BIT_VERTEX_ARRAY_BINDING:
Jamie Madill5a4c9322018-07-16 11:01:58 -0400628 {
Jamie Madillc3755fc2018-04-05 08:39:13 -0400629 mVertexArrayBindingHasChanged = true;
Jamie Madill5a4c9322018-07-16 11:01:58 -0400630
631 // Note that we should implement faster dirty bits for VAO changes in ES 3.0.
632 // This might require keeping separate dirty info for the data and state.
633 mDirtyDefaultAttribs.set();
Jamie Madillebf72992017-10-13 14:09:45 -0400634 break;
Jamie Madill5a4c9322018-07-16 11:01:58 -0400635 }
Jamie Madillebf72992017-10-13 14:09:45 -0400636 case gl::State::DIRTY_BIT_DRAW_INDIRECT_BUFFER_BINDING:
Jamie Madillebf72992017-10-13 14:09:45 -0400637 break;
Qin Jiajiaa98a2812017-11-30 18:12:06 +0800638 case gl::State::DIRTY_BIT_DISPATCH_INDIRECT_BUFFER_BINDING:
Qin Jiajiaa98a2812017-11-30 18:12:06 +0800639 break;
Jamie Madillebf72992017-10-13 14:09:45 -0400640 case gl::State::DIRTY_BIT_PROGRAM_BINDING:
Jamie Madillebf72992017-10-13 14:09:45 -0400641 break;
642 case gl::State::DIRTY_BIT_PROGRAM_EXECUTABLE:
643 {
Jamie Madill5547b382017-10-23 18:16:01 -0400644 dirtyTextures = true;
Jamie Madill06ca6342018-07-12 15:56:53 -0400645 // No additional work is needed here. We will update the pipeline desc later.
Jamie Madillebf72992017-10-13 14:09:45 -0400646 break;
647 }
648 case gl::State::DIRTY_BIT_TEXTURE_BINDINGS:
Jamie Madill5547b382017-10-23 18:16:01 -0400649 dirtyTextures = true;
Jamie Madillebf72992017-10-13 14:09:45 -0400650 break;
651 case gl::State::DIRTY_BIT_SAMPLER_BINDINGS:
Jamie Madill5547b382017-10-23 18:16:01 -0400652 dirtyTextures = true;
Jamie Madillebf72992017-10-13 14:09:45 -0400653 break;
Geoff Langded79232017-11-28 15:21:11 -0500654 case gl::State::DIRTY_BIT_TRANSFORM_FEEDBACK_BINDING:
Geoff Langded79232017-11-28 15:21:11 -0500655 break;
Xinghua Cao10a4d432017-11-28 14:46:26 +0800656 case gl::State::DIRTY_BIT_SHADER_STORAGE_BUFFER_BINDING:
Xinghua Cao10a4d432017-11-28 14:46:26 +0800657 break;
Jamie Madillf4141212017-12-12 15:08:07 -0500658 case gl::State::DIRTY_BIT_UNIFORM_BUFFER_BINDINGS:
Jamie Madillf4141212017-12-12 15:08:07 -0500659 break;
Jamie Madillebf72992017-10-13 14:09:45 -0400660 case gl::State::DIRTY_BIT_MULTISAMPLING:
Jamie Madillebf72992017-10-13 14:09:45 -0400661 break;
662 case gl::State::DIRTY_BIT_SAMPLE_ALPHA_TO_ONE:
Jamie Madillebf72992017-10-13 14:09:45 -0400663 break;
664 case gl::State::DIRTY_BIT_COVERAGE_MODULATION:
Jamie Madillebf72992017-10-13 14:09:45 -0400665 break;
666 case gl::State::DIRTY_BIT_PATH_RENDERING_MATRIX_MV:
Jamie Madillebf72992017-10-13 14:09:45 -0400667 break;
668 case gl::State::DIRTY_BIT_PATH_RENDERING_MATRIX_PROJ:
Jamie Madillebf72992017-10-13 14:09:45 -0400669 break;
670 case gl::State::DIRTY_BIT_PATH_RENDERING_STENCIL_STATE:
Jamie Madillebf72992017-10-13 14:09:45 -0400671 break;
672 case gl::State::DIRTY_BIT_FRAMEBUFFER_SRGB:
Jamie Madillebf72992017-10-13 14:09:45 -0400673 break;
Jamie Madillc67323a2017-11-02 23:11:41 -0400674 case gl::State::DIRTY_BIT_CURRENT_VALUES:
Jamie Madill5a4c9322018-07-16 11:01:58 -0400675 {
676 for (size_t attribIndex : glState.getAndResetDirtyCurrentValues())
677 {
678 invalidateDefaultAttribute(attribIndex);
679 }
Jamie Madillc67323a2017-11-02 23:11:41 -0400680 break;
Jamie Madill5a4c9322018-07-16 11:01:58 -0400681 }
682 break;
Jamie Madillebf72992017-10-13 14:09:45 -0400683 default:
Jamie Madillc67323a2017-11-02 23:11:41 -0400684 UNREACHABLE();
Jamie Madillebf72992017-10-13 14:09:45 -0400685 break;
686 }
687 }
Jamie Madill5547b382017-10-23 18:16:01 -0400688
689 if (dirtyTextures)
690 {
Jamie Madill84c662b2018-07-12 15:56:55 -0400691 ANGLE_TRY(updateActiveTextures(context));
692
Jamie Madille1f3ad42017-10-28 23:00:42 -0400693 ProgramVk *programVk = vk::GetImpl(glState.getProgram());
Jamie Madill5547b382017-10-23 18:16:01 -0400694 programVk->invalidateTextures();
Jamie Madill49ac74b2017-12-21 14:42:33 -0500695 mTexturesDirty = true;
Jamie Madill5547b382017-10-23 18:16:01 -0400696 }
Jamie Madill189ad872018-07-09 13:32:37 -0400697
698 return gl::NoError();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400699}
700
701GLint ContextVk::getGPUDisjoint()
702{
703 UNIMPLEMENTED();
704 return GLint();
705}
706
707GLint64 ContextVk::getTimestamp()
708{
709 UNIMPLEMENTED();
710 return GLint64();
711}
712
Luc Ferron5396f2a2018-07-12 08:24:23 -0400713gl::Error ContextVk::onMakeCurrent(const gl::Context *context)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400714{
Geoff Langcaa55cd2018-07-05 13:19:35 -0400715 // Flip viewports if FeaturesVk::flipViewportY is enabled and the user did not request that the
716 // surface is flipped.
717 egl::Surface *drawSurface = context->getCurrentDrawSurface();
718 mFlipYForCurrentSurface =
719 drawSurface != nullptr && mRenderer->getFeatures().flipViewportY &&
720 !IsMaskFlagSet(drawSurface->getOrientation(), EGL_SURFACE_ORIENTATION_INVERT_Y_ANGLE);
Luc Ferron82eda932018-07-09 15:10:22 -0400721
722 const gl::State &glState = context->getGLState();
723 updateFlipViewportDrawFramebuffer(glState);
724 updateFlipViewportReadFramebuffer(glState);
Luc Ferrone8356092018-07-12 12:36:47 -0400725 ANGLE_TRY(updateDriverUniforms(glState));
Luc Ferron5396f2a2018-07-12 08:24:23 -0400726 return gl::NoError();
Luc Ferron82eda932018-07-09 15:10:22 -0400727}
728
729void ContextVk::updateFlipViewportDrawFramebuffer(const gl::State &glState)
730{
731 gl::Framebuffer *drawFramebuffer = glState.getDrawFramebuffer();
732 mFlipViewportForDrawFramebuffer =
733 drawFramebuffer->isDefault() && mRenderer->getFeatures().flipViewportY;
734}
735
736void ContextVk::updateFlipViewportReadFramebuffer(const gl::State &glState)
737{
738 gl::Framebuffer *readFramebuffer = glState.getReadFramebuffer();
739 mFlipViewportForReadFramebuffer =
740 readFramebuffer->isDefault() && mRenderer->getFeatures().flipViewportY;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400741}
742
Jiawei Shaod0a7d102018-05-07 12:40:20 +0800743gl::Caps ContextVk::getNativeCaps() const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400744{
Jamie Madillacccc6c2016-05-03 17:22:10 -0400745 return mRenderer->getNativeCaps();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400746}
747
748const gl::TextureCapsMap &ContextVk::getNativeTextureCaps() const
749{
Jamie Madillacccc6c2016-05-03 17:22:10 -0400750 return mRenderer->getNativeTextureCaps();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400751}
752
753const gl::Extensions &ContextVk::getNativeExtensions() const
754{
Jamie Madillacccc6c2016-05-03 17:22:10 -0400755 return mRenderer->getNativeExtensions();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400756}
757
758const gl::Limitations &ContextVk::getNativeLimitations() const
759{
Jamie Madillacccc6c2016-05-03 17:22:10 -0400760 return mRenderer->getNativeLimitations();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400761}
762
763CompilerImpl *ContextVk::createCompiler()
764{
Jamie Madillacccc6c2016-05-03 17:22:10 -0400765 return new CompilerVk();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400766}
767
Jamie Madillacccc6c2016-05-03 17:22:10 -0400768ShaderImpl *ContextVk::createShader(const gl::ShaderState &state)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400769{
Jamie Madillacccc6c2016-05-03 17:22:10 -0400770 return new ShaderVk(state);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400771}
772
Jamie Madillacccc6c2016-05-03 17:22:10 -0400773ProgramImpl *ContextVk::createProgram(const gl::ProgramState &state)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400774{
Jamie Madillacccc6c2016-05-03 17:22:10 -0400775 return new ProgramVk(state);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400776}
777
Jamie Madillacccc6c2016-05-03 17:22:10 -0400778FramebufferImpl *ContextVk::createFramebuffer(const gl::FramebufferState &state)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400779{
Jamie Madill639bc902018-07-18 17:08:27 -0400780 return FramebufferVk::CreateUserFBO(mRenderer, state);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400781}
782
783TextureImpl *ContextVk::createTexture(const gl::TextureState &state)
784{
Luc Ferrona9ab0f32018-05-17 17:03:55 -0400785 return new TextureVk(state, mRenderer);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400786}
787
Jamie Madille703c602018-02-20 10:21:48 -0500788RenderbufferImpl *ContextVk::createRenderbuffer(const gl::RenderbufferState &state)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400789{
Jamie Madille703c602018-02-20 10:21:48 -0500790 return new RenderbufferVk(state);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400791}
792
Jamie Madill8f775602016-11-03 16:45:34 -0400793BufferImpl *ContextVk::createBuffer(const gl::BufferState &state)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400794{
Jamie Madill8f775602016-11-03 16:45:34 -0400795 return new BufferVk(state);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400796}
797
Jamie Madillacccc6c2016-05-03 17:22:10 -0400798VertexArrayImpl *ContextVk::createVertexArray(const gl::VertexArrayState &state)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400799{
Luc Ferrona9ab0f32018-05-17 17:03:55 -0400800 return new VertexArrayVk(state, mRenderer);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400801}
802
Corentin Wallezad3ae902018-03-09 13:40:42 -0500803QueryImpl *ContextVk::createQuery(gl::QueryType type)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400804{
Jamie Madillacccc6c2016-05-03 17:22:10 -0400805 return new QueryVk(type);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400806}
807
808FenceNVImpl *ContextVk::createFenceNV()
809{
Jamie Madillacccc6c2016-05-03 17:22:10 -0400810 return new FenceNVVk();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400811}
812
Jamie Madill70b5bb02017-08-28 13:32:37 -0400813SyncImpl *ContextVk::createSync()
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400814{
Jamie Madill70b5bb02017-08-28 13:32:37 -0400815 return new SyncVk();
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400816}
817
Geoff Lang73bd2182016-07-15 13:01:24 -0400818TransformFeedbackImpl *ContextVk::createTransformFeedback(const gl::TransformFeedbackState &state)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400819{
Geoff Lang73bd2182016-07-15 13:01:24 -0400820 return new TransformFeedbackVk(state);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400821}
822
Jamie Madill06ef36b2017-09-09 23:32:46 -0400823SamplerImpl *ContextVk::createSampler(const gl::SamplerState &state)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400824{
Jamie Madill06ef36b2017-09-09 23:32:46 -0400825 return new SamplerVk(state);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400826}
827
Yunchao Hea336b902017-08-02 16:05:21 +0800828ProgramPipelineImpl *ContextVk::createProgramPipeline(const gl::ProgramPipelineState &state)
829{
830 return new ProgramPipelineVk(state);
831}
832
Sami Väisänene45e53b2016-05-25 10:36:04 +0300833std::vector<PathImpl *> ContextVk::createPaths(GLsizei)
834{
835 return std::vector<PathImpl *>();
836}
837
Jamie Madill72106562017-03-24 14:18:50 -0400838void ContextVk::invalidateCurrentPipeline()
839{
Jamie Madillffa4cbb2018-01-23 13:04:07 -0500840 mCurrentPipeline = nullptr;
Jamie Madill72106562017-03-24 14:18:50 -0400841}
842
Jamie Madillfe548342017-06-19 11:13:24 -0400843gl::Error ContextVk::dispatchCompute(const gl::Context *context,
844 GLuint numGroupsX,
845 GLuint numGroupsY,
846 GLuint numGroupsZ)
Xinghua Cao2b396592017-03-29 15:36:04 +0800847{
848 UNIMPLEMENTED();
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500849 return gl::InternalError();
Xinghua Cao2b396592017-03-29 15:36:04 +0800850}
851
Qin Jiajia62fcf622017-11-30 16:16:12 +0800852gl::Error ContextVk::dispatchComputeIndirect(const gl::Context *context, GLintptr indirect)
853{
854 UNIMPLEMENTED();
855 return gl::InternalError();
856}
857
Xinghua Cao89c422a2017-11-29 18:24:20 +0800858gl::Error ContextVk::memoryBarrier(const gl::Context *context, GLbitfield barriers)
859{
860 UNIMPLEMENTED();
861 return gl::InternalError();
862}
863
864gl::Error ContextVk::memoryBarrierByRegion(const gl::Context *context, GLbitfield barriers)
865{
866 UNIMPLEMENTED();
867 return gl::InternalError();
868}
869
Jamie Madilledeaa832018-06-22 09:18:41 -0400870vk::DynamicDescriptorPool *ContextVk::getDynamicDescriptorPool(uint32_t descriptorSetIndex)
Jamie Madill76e471e2017-10-21 09:56:01 -0400871{
Jamie Madilledeaa832018-06-22 09:18:41 -0400872 return &mDynamicDescriptorPools[descriptorSetIndex];
Jamie Madill76e471e2017-10-21 09:56:01 -0400873}
874
Jamie Madillf4d693c2018-02-14 16:38:16 -0500875const VkClearValue &ContextVk::getClearColorValue() const
876{
877 return mClearColorValue;
878}
879
880const VkClearValue &ContextVk::getClearDepthStencilValue() const
881{
882 return mClearDepthStencilValue;
883}
884
Jamie Madill9aef3672018-04-27 11:45:06 -0400885VkColorComponentFlags ContextVk::getClearColorMask() const
886{
887 return mClearColorMask;
888}
Jamie Madill834a3a12018-07-09 13:32:39 -0400889
Jamie Madill1266d202018-06-29 09:11:34 -0400890const FeaturesVk &ContextVk::getFeatures() const
891{
892 return mRenderer->getFeatures();
893}
Jamie Madill834a3a12018-07-09 13:32:39 -0400894
Luc Ferrone8356092018-07-12 12:36:47 -0400895angle::Result ContextVk::updateDriverUniforms(const gl::State &glState)
Jamie Madill834a3a12018-07-09 13:32:39 -0400896{
Jamie Madill834a3a12018-07-09 13:32:39 -0400897 // Release any previously retained buffers.
898 mDriverUniformsBuffer.releaseRetainedBuffers(mRenderer);
899
Luc Ferrone8356092018-07-12 12:36:47 -0400900 const gl::Rectangle &glViewport = glState.getViewport();
Jamie Madill834a3a12018-07-09 13:32:39 -0400901
902 // Allocate a new region in the dynamic buffer.
903 uint8_t *ptr = nullptr;
904 VkBuffer buffer = VK_NULL_HANDLE;
Jamie Madill4c310832018-08-29 13:43:17 -0400905 VkDeviceSize offset = 0;
Jamie Madill834a3a12018-07-09 13:32:39 -0400906 bool newBufferAllocated = false;
Jamie Madill21061022018-07-12 23:56:30 -0400907 ANGLE_TRY(mDriverUniformsBuffer.allocate(this, sizeof(DriverUniforms), &ptr, &buffer, &offset,
908 &newBufferAllocated));
Luc Ferron9ff9c772018-07-11 13:08:18 -0400909 float scaleY = isViewportFlipEnabledForDrawFBO() ? 1.0f : -1.0f;
Jamie Madill834a3a12018-07-09 13:32:39 -0400910
Luc Ferrone8356092018-07-12 12:36:47 -0400911 float depthRangeNear = glState.getNearPlane();
912 float depthRangeFar = glState.getFarPlane();
913 float depthRangeDiff = depthRangeFar - depthRangeNear;
914
Jamie Madill834a3a12018-07-09 13:32:39 -0400915 // Copy and flush to the device.
916 DriverUniforms *driverUniforms = reinterpret_cast<DriverUniforms *>(ptr);
Luc Ferron9ff9c772018-07-11 13:08:18 -0400917 *driverUniforms = {
918 {static_cast<float>(glViewport.x), static_cast<float>(glViewport.y),
919 static_cast<float>(glViewport.width), static_cast<float>(glViewport.height)},
Luc Ferrone8356092018-07-12 12:36:47 -0400920 {1.0f, scaleY, 1.0f, 1.0f},
921 {depthRangeNear, depthRangeFar, depthRangeDiff, 0.0f}};
Jamie Madill834a3a12018-07-09 13:32:39 -0400922
Jamie Madill21061022018-07-12 23:56:30 -0400923 ANGLE_TRY(mDriverUniformsBuffer.flush(this));
Jamie Madill834a3a12018-07-09 13:32:39 -0400924
925 // Get the descriptor set layout.
926 if (!mDriverUniformsSetLayout.valid())
927 {
928 vk::DescriptorSetLayoutDesc desc;
929 desc.update(0, VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, 1);
930
Jamie Madill21061022018-07-12 23:56:30 -0400931 ANGLE_TRY(mRenderer->getDescriptorSetLayout(this, desc, &mDriverUniformsSetLayout));
Jamie Madill834a3a12018-07-09 13:32:39 -0400932 }
933
934 // Allocate a new descriptor set.
935 ANGLE_TRY(mDynamicDescriptorPools[kDriverUniformsDescriptorSetIndex].allocateSets(
936 this, mDriverUniformsSetLayout.get().ptr(), 1, &mDriverUniformsDescriptorSet));
937
938 // Update the driver uniform descriptor set.
939 VkDescriptorBufferInfo bufferInfo;
940 bufferInfo.buffer = buffer;
941 bufferInfo.offset = offset;
942 bufferInfo.range = sizeof(DriverUniforms);
943
944 VkWriteDescriptorSet writeInfo;
945 writeInfo.sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET;
946 writeInfo.pNext = nullptr;
947 writeInfo.dstSet = mDriverUniformsDescriptorSet;
948 writeInfo.dstBinding = 0;
949 writeInfo.dstArrayElement = 0;
950 writeInfo.descriptorCount = 1;
951 writeInfo.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER;
952 writeInfo.pImageInfo = nullptr;
953 writeInfo.pTexelBufferView = nullptr;
954 writeInfo.pBufferInfo = &bufferInfo;
955
956 vkUpdateDescriptorSets(getDevice(), 1, &writeInfo, 0, nullptr);
957
Jamie Madill21061022018-07-12 23:56:30 -0400958 return angle::Result::Continue();
959}
960
961void ContextVk::handleError(VkResult errorCode, const char *file, unsigned int line)
962{
963 GLenum glErrorCode = DefaultGLErrorCode(errorCode);
964
965 std::stringstream errorStream;
966 errorStream << "Internal Vulkan error: " << VulkanResultString(errorCode) << ", in " << file
967 << ", line " << line << ".";
968
969 mErrors->handleError(gl::Error(glErrorCode, glErrorCode, errorStream.str()));
Jamie Madill834a3a12018-07-09 13:32:39 -0400970}
Jamie Madill84c662b2018-07-12 15:56:55 -0400971
972gl::Error ContextVk::updateActiveTextures(const gl::Context *context)
973{
Jamie Madill4787d702018-08-08 15:49:26 -0400974 const gl::State &glState = mState.getState();
975 const gl::Program *program = glState.getProgram();
Jamie Madill84c662b2018-07-12 15:56:55 -0400976
977 mActiveTextures.fill(nullptr);
978
Jamie Madill4787d702018-08-08 15:49:26 -0400979 const gl::ActiveTexturePointerArray &textures = glState.getActiveTexturesCache();
980 const gl::ActiveTextureMask &activeTextures = program->getActiveSamplersMask();
981 const gl::ActiveTextureTypeArray &textureTypes = program->getActiveSamplerTypes();
982
983 for (size_t textureUnit : activeTextures)
Jamie Madill84c662b2018-07-12 15:56:55 -0400984 {
Jamie Madill4787d702018-08-08 15:49:26 -0400985 gl::Texture *texture = textures[textureUnit];
986 gl::TextureType textureType = textureTypes[textureUnit];
Jamie Madill84c662b2018-07-12 15:56:55 -0400987
Jamie Madill4787d702018-08-08 15:49:26 -0400988 // Null textures represent incomplete textures.
989 if (texture == nullptr)
Jamie Madill84c662b2018-07-12 15:56:55 -0400990 {
Jamie Madill4787d702018-08-08 15:49:26 -0400991 ANGLE_TRY(getIncompleteTexture(context, textureType, &texture));
Jamie Madill84c662b2018-07-12 15:56:55 -0400992 }
Jamie Madill4787d702018-08-08 15:49:26 -0400993
994 mActiveTextures[textureUnit] = vk::GetImpl(texture);
Jamie Madill84c662b2018-07-12 15:56:55 -0400995 }
996
997 return gl::NoError();
998}
999
1000const gl::ActiveTextureArray<TextureVk *> &ContextVk::getActiveTextures() const
1001{
1002 return mActiveTextures;
1003}
Jamie Madill5a4c9322018-07-16 11:01:58 -04001004
1005void ContextVk::invalidateDefaultAttribute(size_t attribIndex)
1006{
1007 mDirtyDefaultAttribs.set(attribIndex);
1008}
1009
1010angle::Result ContextVk::updateDefaultAttributes()
1011{
1012 ASSERT(mDirtyDefaultAttribs.any());
1013
1014 const gl::Program *program = mState.getState().getProgram();
1015 ASSERT(program);
1016
1017 const gl::AttributesMask &programAttribs = program->getActiveAttribLocationsMask();
1018 const gl::AttributesMask &attribsToUpdate = (programAttribs & mDirtyDefaultAttribs);
1019
1020 for (size_t attribIndex : attribsToUpdate)
1021 {
1022 ANGLE_TRY(updateDefaultAttribute(attribIndex))
1023 }
1024
1025 mDirtyDefaultAttribs &= ~attribsToUpdate;
1026 return angle::Result::Continue();
1027}
1028
1029angle::Result ContextVk::updateDefaultAttribute(size_t attribIndex)
1030{
1031 vk::DynamicBuffer &defaultBuffer = mDefaultAttribBuffers[attribIndex];
1032
1033 defaultBuffer.releaseRetainedBuffers(mRenderer);
1034
1035 uint8_t *ptr;
1036 VkBuffer bufferHandle = VK_NULL_HANDLE;
Jamie Madill4c310832018-08-29 13:43:17 -04001037 VkDeviceSize offset = 0;
Jamie Madill5a4c9322018-07-16 11:01:58 -04001038 ANGLE_TRY(
1039 defaultBuffer.allocate(this, kDefaultValueSize, &ptr, &bufferHandle, &offset, nullptr));
1040
1041 const gl::State &glState = mState.getState();
1042 const gl::VertexAttribCurrentValueData &defaultValue =
1043 glState.getVertexAttribCurrentValues()[attribIndex];
1044
1045 ASSERT(defaultValue.Type == GL_FLOAT);
1046
1047 memcpy(ptr, defaultValue.FloatValues, kDefaultValueSize);
1048
1049 ANGLE_TRY(defaultBuffer.flush(this));
1050
1051 VertexArrayVk *vertexArrayVk = vk::GetImpl(glState.getVertexArray());
Jamie Madill4c310832018-08-29 13:43:17 -04001052 vertexArrayVk->updateDefaultAttrib(mRenderer, attribIndex, bufferHandle,
1053 static_cast<uint32_t>(offset));
Jamie Madill5a4c9322018-07-16 11:01:58 -04001054 return angle::Result::Continue();
1055}
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001056} // namespace rx