blob: 604e8b4581e43296199ce3fa38817eb26d340f18 [file] [log] [blame]
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001//
2// Copyright 2016 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6// VertexArrayVk.cpp:
7// Implements the class methods for VertexArrayVk.
8//
9
10#include "libANGLE/renderer/vulkan/VertexArrayVk.h"
11
12#include "common/debug.h"
13
Jamie Madillc564c072017-06-01 12:45:42 -040014#include "libANGLE/Context.h"
Jamie Madillbd159f02017-10-09 19:39:06 -040015#include "libANGLE/renderer/vulkan/BufferVk.h"
Jamie Madill1f46bc12018-02-20 16:09:43 -050016#include "libANGLE/renderer/vulkan/CommandGraph.h"
Jamie Madilldd43e6c2017-03-24 14:18:49 -040017#include "libANGLE/renderer/vulkan/ContextVk.h"
Jamie Madill316c6062018-05-29 10:49:45 -040018#include "libANGLE/renderer/vulkan/FramebufferVk.h"
Jamie Madillc3755fc2018-04-05 08:39:13 -040019#include "libANGLE/renderer/vulkan/RendererVk.h"
Jamie Madill3c424b42018-01-19 12:35:09 -050020#include "libANGLE/renderer/vulkan/vk_format_utils.h"
Jamie Madilldd43e6c2017-03-24 14:18:49 -040021
Jamie Madill9e54b5a2016-05-25 12:57:39 -040022namespace rx
23{
Jamie Madillc3755fc2018-04-05 08:39:13 -040024namespace
25{
26constexpr size_t kDynamicVertexDataSize = 1024 * 1024;
27constexpr size_t kDynamicIndexDataSize = 1024 * 8;
28} // anonymous namespace
Jamie Madill9e54b5a2016-05-25 12:57:39 -040029
Luc Ferrona9ab0f32018-05-17 17:03:55 -040030VertexArrayVk::VertexArrayVk(const gl::VertexArrayState &state, RendererVk *renderer)
Jamie Madillbd159f02017-10-09 19:39:06 -040031 : VertexArrayImpl(state),
Jamie Madillda854a22017-11-30 17:24:21 -050032 mCurrentArrayBufferHandles{},
Frank Henigman17448952017-01-05 15:48:26 -050033 mCurrentArrayBufferOffsets{},
Jamie Madillda854a22017-11-30 17:24:21 -050034 mCurrentArrayBufferResources{},
Jamie Madillc3755fc2018-04-05 08:39:13 -040035 mCurrentElementArrayBufferHandle(VK_NULL_HANDLE),
36 mCurrentElementArrayBufferOffset(0),
37 mCurrentElementArrayBufferResource(nullptr),
38 mDynamicVertexData(VK_BUFFER_USAGE_VERTEX_BUFFER_BIT, kDynamicVertexDataSize),
39 mDynamicIndexData(VK_BUFFER_USAGE_INDEX_BUFFER_BIT, kDynamicIndexDataSize),
Luc Ferron6ed167a2018-06-13 13:45:55 -040040 mTranslatedByteIndexData(VK_BUFFER_USAGE_INDEX_BUFFER_BIT, kDynamicIndexDataSize),
Luc Ferrona9ab0f32018-05-17 17:03:55 -040041 mLineLoopHelper(renderer),
Jamie Madillb8e39662018-04-04 11:41:42 -040042 mDirtyLineLoopTranslation(true),
Jamie Madillc3755fc2018-04-05 08:39:13 -040043 mVertexBuffersDirty(false),
Luc Ferron49aacad2018-06-12 08:33:59 -040044 mIndexBufferDirty(false),
45 mLastIndexBufferOffset(0)
Jamie Madill9e54b5a2016-05-25 12:57:39 -040046{
Jamie Madillda854a22017-11-30 17:24:21 -050047 mCurrentArrayBufferHandles.fill(VK_NULL_HANDLE);
Frank Henigman17448952017-01-05 15:48:26 -050048 mCurrentArrayBufferOffsets.fill(0);
Jamie Madillda854a22017-11-30 17:24:21 -050049 mCurrentArrayBufferResources.fill(nullptr);
Jamie Madill112a3a82018-01-23 13:04:06 -050050
51 mPackedInputBindings.fill({0, 0});
52 mPackedInputAttributes.fill({0, 0, 0});
Jamie Madillc3755fc2018-04-05 08:39:13 -040053
Luc Ferrona9ab0f32018-05-17 17:03:55 -040054 mDynamicVertexData.init(1, renderer);
55 mDynamicIndexData.init(1, renderer);
Luc Ferron6ed167a2018-06-13 13:45:55 -040056 mTranslatedByteIndexData.init(1, renderer);
Jamie Madill9e54b5a2016-05-25 12:57:39 -040057}
58
Jamie Madillacf2f3a2017-11-21 19:22:44 -050059VertexArrayVk::~VertexArrayVk()
60{
61}
62
Jamie Madill4928b7c2017-06-20 12:57:39 -040063void VertexArrayVk::destroy(const gl::Context *context)
Jamie Madill9e54b5a2016-05-25 12:57:39 -040064{
Jamie Madillc3755fc2018-04-05 08:39:13 -040065 VkDevice device = vk::GetImpl(context)->getRenderer()->getDevice();
Jamie Madillc3755fc2018-04-05 08:39:13 -040066 mDynamicVertexData.destroy(device);
67 mDynamicIndexData.destroy(device);
Luc Ferron6ed167a2018-06-13 13:45:55 -040068 mTranslatedByteIndexData.destroy(device);
Jamie Madill22f12fe2018-04-08 14:23:40 -040069 mLineLoopHelper.destroy(device);
Jamie Madill9e54b5a2016-05-25 12:57:39 -040070}
71
Jamie Madillc3755fc2018-04-05 08:39:13 -040072gl::Error VertexArrayVk::streamVertexData(RendererVk *renderer,
73 const gl::AttributesMask &attribsToStream,
Jamie Madill32fd63b2018-03-31 11:20:35 -040074 const gl::DrawCallParams &drawCallParams)
Frank Henigman17448952017-01-05 15:48:26 -050075{
Jamie Madillc3755fc2018-04-05 08:39:13 -040076 ASSERT(!attribsToStream.none());
77
Jamie Madillbcef3222018-04-13 15:19:11 -040078 const auto &attribs = mState.getVertexAttributes();
79 const auto &bindings = mState.getVertexBindings();
Frank Henigman17448952017-01-05 15:48:26 -050080
Jamie Madill32fd63b2018-03-31 11:20:35 -040081 const size_t lastVertex = drawCallParams.firstVertex() + drawCallParams.vertexCount();
82
Frank Henigman17448952017-01-05 15:48:26 -050083 // TODO(fjhenigman): When we have a bunch of interleaved attributes, they end up
84 // un-interleaved, wasting space and copying time. Consider improving on that.
Jamie Madillb8e39662018-04-04 11:41:42 -040085 for (size_t attribIndex : attribsToStream)
Frank Henigman17448952017-01-05 15:48:26 -050086 {
Frank Henigman6dd4a922018-03-02 16:35:13 -050087 const gl::VertexAttribute &attrib = attribs[attribIndex];
88 const gl::VertexBinding &binding = bindings[attrib.bindingIndex];
89 ASSERT(attrib.enabled && binding.getBuffer().get() == nullptr);
Frank Henigman17448952017-01-05 15:48:26 -050090
Frank Henigman6dd4a922018-03-02 16:35:13 -050091 // TODO(fjhenigman): Work with more formats than just GL_FLOAT.
92 if (attrib.type != GL_FLOAT)
Frank Henigman17448952017-01-05 15:48:26 -050093 {
Frank Henigman6dd4a922018-03-02 16:35:13 -050094 UNIMPLEMENTED();
95 return gl::InternalError();
Frank Henigman17448952017-01-05 15:48:26 -050096 }
Frank Henigman6dd4a922018-03-02 16:35:13 -050097
98 // Only [firstVertex, lastVertex] is needed by the upcoming draw so that
99 // is all we copy, but we allocate space for [0, lastVertex] so indexing
100 // will work. If we don't start at zero all the indices will be off.
101 // TODO(fjhenigman): See if we can account for indices being off by adjusting
102 // the offset, thus avoiding wasted memory.
Jamie Madill32fd63b2018-03-31 11:20:35 -0400103 const size_t firstByte = drawCallParams.firstVertex() * binding.getStride();
Frank Henigman6dd4a922018-03-02 16:35:13 -0500104 const size_t lastByte =
105 lastVertex * binding.getStride() + gl::ComputeVertexAttributeTypeSize(attrib);
Jamie Madill493f9572018-05-24 19:52:15 -0400106 uint8_t *dst = nullptr;
Luc Ferron7a06ac12018-03-15 10:17:04 -0400107 uint32_t offset = 0;
Jamie Madillc3755fc2018-04-05 08:39:13 -0400108 ANGLE_TRY(mDynamicVertexData.allocate(
109 renderer, lastByte, &dst, &mCurrentArrayBufferHandles[attribIndex], &offset, nullptr));
Luc Ferron7a06ac12018-03-15 10:17:04 -0400110 mCurrentArrayBufferOffsets[attribIndex] = static_cast<VkDeviceSize>(offset);
Frank Henigman6dd4a922018-03-02 16:35:13 -0500111 memcpy(dst + firstByte, static_cast<const uint8_t *>(attrib.pointer) + firstByte,
112 lastByte - firstByte);
Frank Henigman17448952017-01-05 15:48:26 -0500113 }
114
Jamie Madillc3755fc2018-04-05 08:39:13 -0400115 ANGLE_TRY(mDynamicVertexData.flush(renderer->getDevice()));
Luc Ferron61859812018-05-09 14:17:39 -0400116 mDynamicVertexData.releaseRetainedBuffers(renderer);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400117 return gl::NoError();
118}
119
120gl::Error VertexArrayVk::streamIndexData(RendererVk *renderer,
121 const gl::DrawCallParams &drawCallParams)
122{
123 ASSERT(!mState.getElementArrayBuffer().get());
124
125 uint32_t offset = 0;
126
127 const GLsizei amount = sizeof(GLushort) * drawCallParams.indexCount();
128 GLubyte *dst = nullptr;
129
130 ANGLE_TRY(mDynamicIndexData.allocate(renderer, amount, &dst, &mCurrentElementArrayBufferHandle,
131 &offset, nullptr));
132 if (drawCallParams.type() == GL_UNSIGNED_BYTE)
133 {
134 // Unsigned bytes don't have direct support in Vulkan so we have to expand the
135 // memory to a GLushort.
136 const GLubyte *in = static_cast<const GLubyte *>(drawCallParams.indices());
137 GLushort *expandedDst = reinterpret_cast<GLushort *>(dst);
138 for (GLsizei index = 0; index < drawCallParams.indexCount(); index++)
139 {
140 expandedDst[index] = static_cast<GLushort>(in[index]);
141 }
142 }
143 else
144 {
145 memcpy(dst, drawCallParams.indices(), amount);
146 }
147 ANGLE_TRY(mDynamicIndexData.flush(renderer->getDevice()));
Luc Ferron61859812018-05-09 14:17:39 -0400148 mDynamicIndexData.releaseRetainedBuffers(renderer);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400149 mCurrentElementArrayBufferOffset = offset;
Frank Henigman17448952017-01-05 15:48:26 -0500150 return gl::NoError();
151}
152
Jamie Madilla56467e2018-04-11 16:19:41 -0400153#define ANGLE_VERTEX_DIRTY_ATTRIB_FUNC(INDEX) \
154 case gl::VertexArray::DIRTY_BIT_ATTRIB_0 + INDEX: \
155 syncDirtyAttrib(attribs[INDEX], bindings[attribs[INDEX].bindingIndex], INDEX); \
156 invalidatePipeline = true; \
157 break;
158
159#define ANGLE_VERTEX_DIRTY_BINDING_FUNC(INDEX) \
160 case gl::VertexArray::DIRTY_BIT_BINDING_0 + INDEX: \
161 syncDirtyAttrib(attribs[INDEX], bindings[attribs[INDEX].bindingIndex], INDEX); \
162 invalidatePipeline = true; \
163 break;
164
165#define ANGLE_VERTEX_DIRTY_BUFFER_DATA_FUNC(INDEX) \
166 case gl::VertexArray::DIRTY_BIT_BUFFER_DATA_0 + INDEX: \
167 break;
168
Frank Henigman0af5b862018-03-27 20:19:33 -0400169gl::Error VertexArrayVk::syncState(const gl::Context *context,
170 const gl::VertexArray::DirtyBits &dirtyBits,
171 const gl::VertexArray::DirtyAttribBitsArray &attribBits,
172 const gl::VertexArray::DirtyBindingBitsArray &bindingBits)
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400173{
174 ASSERT(dirtyBits.any());
Jamie Madill72106562017-03-24 14:18:50 -0400175
Jamie Madillc3755fc2018-04-05 08:39:13 -0400176 bool invalidatePipeline = false;
177
Jamie Madillbd159f02017-10-09 19:39:06 -0400178 // Invalidate current pipeline.
Jamie Madillacf2f3a2017-11-21 19:22:44 -0500179 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madillbd159f02017-10-09 19:39:06 -0400180
181 // Rebuild current attribute buffers cache. This will fail horribly if the buffer changes.
182 // TODO(jmadill): Handle buffer storage changes.
183 const auto &attribs = mState.getVertexAttributes();
184 const auto &bindings = mState.getVertexBindings();
185
Jamie Madill09463932018-04-04 05:26:59 -0400186 for (size_t dirtyBit : dirtyBits)
Jamie Madillbd159f02017-10-09 19:39:06 -0400187 {
Jamie Madill09463932018-04-04 05:26:59 -0400188 switch (dirtyBit)
Jamie Madillda854a22017-11-30 17:24:21 -0500189 {
Jamie Madill09463932018-04-04 05:26:59 -0400190 case gl::VertexArray::DIRTY_BIT_ELEMENT_ARRAY_BUFFER:
Jamie Madillda854a22017-11-30 17:24:21 -0500191 {
Jamie Madill09463932018-04-04 05:26:59 -0400192 gl::Buffer *bufferGL = mState.getElementArrayBuffer().get();
193 if (bufferGL)
194 {
Jamie Madillc3755fc2018-04-05 08:39:13 -0400195 BufferVk *bufferVk = vk::GetImpl(bufferGL);
196 mCurrentElementArrayBufferResource = bufferVk;
197 mCurrentElementArrayBufferHandle = bufferVk->getVkBuffer().getHandle();
Jamie Madill09463932018-04-04 05:26:59 -0400198 }
199 else
200 {
201 mCurrentElementArrayBufferResource = nullptr;
Jamie Madillc3755fc2018-04-05 08:39:13 -0400202 mCurrentElementArrayBufferHandle = VK_NULL_HANDLE;
Jamie Madill09463932018-04-04 05:26:59 -0400203 }
Luc Ferron387b3b32018-05-28 10:11:57 -0400204
205 mCurrentElementArrayBufferOffset = 0;
206 mLineLoopBufferFirstIndex.reset();
207 mLineLoopBufferLastIndex.reset();
Jamie Madillb8e39662018-04-04 11:41:42 -0400208 mIndexBufferDirty = true;
209 mDirtyLineLoopTranslation = true;
Jamie Madill09463932018-04-04 05:26:59 -0400210 break;
Jamie Madillda854a22017-11-30 17:24:21 -0500211 }
Jamie Madill09463932018-04-04 05:26:59 -0400212
213 case gl::VertexArray::DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA:
Jamie Madillc3755fc2018-04-05 08:39:13 -0400214 mLineLoopBufferFirstIndex.reset();
215 mLineLoopBufferLastIndex.reset();
Jamie Madillb8e39662018-04-04 11:41:42 -0400216 mDirtyLineLoopTranslation = true;
Jamie Madill09463932018-04-04 05:26:59 -0400217 break;
218
Jamie Madilla56467e2018-04-11 16:19:41 -0400219 ANGLE_VERTEX_INDEX_CASES(ANGLE_VERTEX_DIRTY_ATTRIB_FUNC);
220 ANGLE_VERTEX_INDEX_CASES(ANGLE_VERTEX_DIRTY_BINDING_FUNC);
221 ANGLE_VERTEX_INDEX_CASES(ANGLE_VERTEX_DIRTY_BUFFER_DATA_FUNC);
222
Jamie Madill09463932018-04-04 05:26:59 -0400223 default:
Jamie Madilla56467e2018-04-11 16:19:41 -0400224 UNREACHABLE();
Jamie Madill09463932018-04-04 05:26:59 -0400225 break;
Jamie Madillbd159f02017-10-09 19:39:06 -0400226 }
227 }
Frank Henigman0af5b862018-03-27 20:19:33 -0400228
Jamie Madillc3755fc2018-04-05 08:39:13 -0400229 if (invalidatePipeline)
230 {
231 mVertexBuffersDirty = true;
232 contextVk->invalidateCurrentPipeline();
233 }
234
Frank Henigman0af5b862018-03-27 20:19:33 -0400235 return gl::NoError();
Jamie Madillbd159f02017-10-09 19:39:06 -0400236}
237
Jamie Madilla56467e2018-04-11 16:19:41 -0400238void VertexArrayVk::syncDirtyAttrib(const gl::VertexAttribute &attrib,
239 const gl::VertexBinding &binding,
240 size_t attribIndex)
241{
242 // Invalidate the input description for pipelines.
243 mDirtyPackedInputs.set(attribIndex);
244
245 if (attrib.enabled)
246 {
247 gl::Buffer *bufferGL = binding.getBuffer().get();
248
249 if (bufferGL)
250 {
251 BufferVk *bufferVk = vk::GetImpl(bufferGL);
252 mCurrentArrayBufferResources[attribIndex] = bufferVk;
253 mCurrentArrayBufferHandles[attribIndex] = bufferVk->getVkBuffer().getHandle();
Jamie Madilla56467e2018-04-11 16:19:41 -0400254 }
255 else
256 {
257 mCurrentArrayBufferResources[attribIndex] = nullptr;
258 mCurrentArrayBufferHandles[attribIndex] = VK_NULL_HANDLE;
Jamie Madilla56467e2018-04-11 16:19:41 -0400259 }
260 // TODO(jmadill): Offset handling. Assume zero for now.
261 mCurrentArrayBufferOffsets[attribIndex] = 0;
262 }
263 else
264 {
Jamie Madilla56467e2018-04-11 16:19:41 -0400265 UNIMPLEMENTED();
266 }
267}
268
Jamie Madillda854a22017-11-30 17:24:21 -0500269const gl::AttribArray<VkBuffer> &VertexArrayVk::getCurrentArrayBufferHandles() const
Jamie Madillbd159f02017-10-09 19:39:06 -0400270{
Jamie Madillda854a22017-11-30 17:24:21 -0500271 return mCurrentArrayBufferHandles;
Jamie Madillbd159f02017-10-09 19:39:06 -0400272}
273
Frank Henigman17448952017-01-05 15:48:26 -0500274const gl::AttribArray<VkDeviceSize> &VertexArrayVk::getCurrentArrayBufferOffsets() const
275{
276 return mCurrentArrayBufferOffsets;
277}
278
Jamie Madill316c6062018-05-29 10:49:45 -0400279void VertexArrayVk::updateArrayBufferReadDependencies(vk::CommandGraphResource *drawFramebuffer,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400280 const gl::AttributesMask &activeAttribsMask,
281 Serial serial)
Jamie Madillbd159f02017-10-09 19:39:06 -0400282{
Jamie Madillda854a22017-11-30 17:24:21 -0500283 // Handle the bound array buffers.
Jamie Madillc3755fc2018-04-05 08:39:13 -0400284 for (size_t attribIndex : activeAttribsMask)
Jamie Madillbd159f02017-10-09 19:39:06 -0400285 {
Frank Henigman17448952017-01-05 15:48:26 -0500286 if (mCurrentArrayBufferResources[attribIndex])
Jamie Madill316c6062018-05-29 10:49:45 -0400287 mCurrentArrayBufferResources[attribIndex]->addReadDependency(drawFramebuffer);
Jamie Madillda854a22017-11-30 17:24:21 -0500288 }
Jamie Madillc3755fc2018-04-05 08:39:13 -0400289}
Jamie Madillda854a22017-11-30 17:24:21 -0500290
Jamie Madill316c6062018-05-29 10:49:45 -0400291void VertexArrayVk::updateElementArrayBufferReadDependency(
292 vk::CommandGraphResource *drawFramebuffer,
293 Serial serial)
Jamie Madillc3755fc2018-04-05 08:39:13 -0400294{
Jamie Madillda854a22017-11-30 17:24:21 -0500295 // Handle the bound element array buffer.
Jamie Madillc3755fc2018-04-05 08:39:13 -0400296 if (mCurrentElementArrayBufferResource)
Jamie Madillda854a22017-11-30 17:24:21 -0500297 {
Jamie Madill316c6062018-05-29 10:49:45 -0400298 mCurrentElementArrayBufferResource->addReadDependency(drawFramebuffer);
Jamie Madillbd159f02017-10-09 19:39:06 -0400299 }
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400300}
301
Jamie Madill112a3a82018-01-23 13:04:06 -0500302void VertexArrayVk::getPackedInputDescriptions(vk::PipelineDesc *pipelineDesc)
Jamie Madillebf72992017-10-13 14:09:45 -0400303{
Jamie Madill112a3a82018-01-23 13:04:06 -0500304 updatePackedInputDescriptions();
305 pipelineDesc->updateVertexInputInfo(mPackedInputBindings, mPackedInputAttributes);
Jamie Madillebf72992017-10-13 14:09:45 -0400306}
307
Jamie Madill112a3a82018-01-23 13:04:06 -0500308void VertexArrayVk::updatePackedInputDescriptions()
Jamie Madillebf72992017-10-13 14:09:45 -0400309{
Jamie Madill112a3a82018-01-23 13:04:06 -0500310 if (!mDirtyPackedInputs.any())
Jamie Madillebf72992017-10-13 14:09:45 -0400311 {
312 return;
313 }
314
315 const auto &attribs = mState.getVertexAttributes();
316 const auto &bindings = mState.getVertexBindings();
317
Jamie Madill112a3a82018-01-23 13:04:06 -0500318 for (auto attribIndex : mDirtyPackedInputs)
Jamie Madillebf72992017-10-13 14:09:45 -0400319 {
320 const auto &attrib = attribs[attribIndex];
321 const auto &binding = bindings[attrib.bindingIndex];
322 if (attrib.enabled)
323 {
Jamie Madill112a3a82018-01-23 13:04:06 -0500324 updatePackedInputInfo(static_cast<uint32_t>(attribIndex), binding, attrib);
Jamie Madillebf72992017-10-13 14:09:45 -0400325 }
326 else
327 {
328 UNIMPLEMENTED();
329 }
330 }
331
Jamie Madill112a3a82018-01-23 13:04:06 -0500332 mDirtyPackedInputs.reset();
333}
334
335void VertexArrayVk::updatePackedInputInfo(uint32_t attribIndex,
336 const gl::VertexBinding &binding,
337 const gl::VertexAttribute &attrib)
338{
339 vk::PackedVertexInputBindingDesc &bindingDesc = mPackedInputBindings[attribIndex];
340
341 size_t attribSize = gl::ComputeVertexAttributeTypeSize(attrib);
342 ASSERT(attribSize <= std::numeric_limits<uint16_t>::max());
343
Frank Henigmana8e868f2018-01-28 23:32:25 -0500344 bindingDesc.stride = static_cast<uint16_t>(binding.getStride());
Jamie Madill112a3a82018-01-23 13:04:06 -0500345 bindingDesc.inputRate = static_cast<uint16_t>(
346 binding.getDivisor() > 0 ? VK_VERTEX_INPUT_RATE_INSTANCE : VK_VERTEX_INPUT_RATE_VERTEX);
347
348 gl::VertexFormatType vertexFormatType = gl::GetVertexFormatType(attrib);
349 VkFormat vkFormat = vk::GetNativeVertexFormat(vertexFormatType);
350 ASSERT(vkFormat <= std::numeric_limits<uint16_t>::max());
351
352 vk::PackedVertexInputAttributeDesc &attribDesc = mPackedInputAttributes[attribIndex];
353 attribDesc.format = static_cast<uint16_t>(vkFormat);
354 attribDesc.location = static_cast<uint16_t>(attribIndex);
355 attribDesc.offset = static_cast<uint32_t>(ComputeVertexAttributeOffset(attrib, binding));
Jamie Madillebf72992017-10-13 14:09:45 -0400356}
357
Jamie Madillc3755fc2018-04-05 08:39:13 -0400358gl::Error VertexArrayVk::drawArrays(const gl::Context *context,
359 RendererVk *renderer,
360 const gl::DrawCallParams &drawCallParams,
Jamie Madill316c6062018-05-29 10:49:45 -0400361 vk::CommandBuffer *commandBuffer,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400362 bool newCommandBuffer)
363{
Jamie Madillc3755fc2018-04-05 08:39:13 -0400364 ASSERT(commandBuffer->valid());
365
Jamie Madill316c6062018-05-29 10:49:45 -0400366 ANGLE_TRY(onDraw(context, renderer, drawCallParams, commandBuffer, newCommandBuffer));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400367
Jamie Madill18e323a2018-05-11 16:54:17 -0400368 // Note: Vertex indexes can be arbitrarily large.
369 uint32_t clampedVertexCount = drawCallParams.getClampedVertexCount<uint32_t>();
370
Jamie Madill493f9572018-05-24 19:52:15 -0400371 if (drawCallParams.mode() != gl::PrimitiveMode::LineLoop)
Jamie Madillc3755fc2018-04-05 08:39:13 -0400372 {
Jamie Madill18e323a2018-05-11 16:54:17 -0400373 commandBuffer->draw(clampedVertexCount, 1, drawCallParams.firstVertex(), 0);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400374 return gl::NoError();
375 }
376
377 // Handle GL_LINE_LOOP drawArrays.
Jamie Madill18e323a2018-05-11 16:54:17 -0400378 size_t lastVertex = static_cast<size_t>(drawCallParams.firstVertex() + clampedVertexCount);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400379 if (!mLineLoopBufferFirstIndex.valid() || !mLineLoopBufferLastIndex.valid() ||
380 mLineLoopBufferFirstIndex != drawCallParams.firstVertex() ||
381 mLineLoopBufferLastIndex != lastVertex)
382 {
Jamie Madill22f12fe2018-04-08 14:23:40 -0400383 ANGLE_TRY(mLineLoopHelper.getIndexBufferForDrawArrays(renderer, drawCallParams,
384 &mCurrentElementArrayBufferHandle,
385 &mCurrentElementArrayBufferOffset));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400386
387 mLineLoopBufferFirstIndex = drawCallParams.firstVertex();
388 mLineLoopBufferLastIndex = lastVertex;
389 }
390
391 commandBuffer->bindIndexBuffer(mCurrentElementArrayBufferHandle,
392 mCurrentElementArrayBufferOffset, VK_INDEX_TYPE_UINT32);
393
Jamie Madill18e323a2018-05-11 16:54:17 -0400394 vk::LineLoopHelper::Draw(clampedVertexCount, commandBuffer);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400395
396 return gl::NoError();
397}
398
399gl::Error VertexArrayVk::drawElements(const gl::Context *context,
400 RendererVk *renderer,
401 const gl::DrawCallParams &drawCallParams,
Jamie Madill316c6062018-05-29 10:49:45 -0400402 vk::CommandBuffer *commandBuffer,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400403 bool newCommandBuffer)
404{
Jamie Madillc3755fc2018-04-05 08:39:13 -0400405 ASSERT(commandBuffer->valid());
406
Jamie Madill493f9572018-05-24 19:52:15 -0400407 if (drawCallParams.mode() != gl::PrimitiveMode::LineLoop)
Jamie Madillc3755fc2018-04-05 08:39:13 -0400408 {
Jamie Madill316c6062018-05-29 10:49:45 -0400409 ANGLE_TRY(
410 onIndexedDraw(context, renderer, drawCallParams, commandBuffer, newCommandBuffer));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400411 commandBuffer->drawIndexed(drawCallParams.indexCount(), 1, 0, 0, 0);
412 return gl::NoError();
413 }
414
415 // Handle GL_LINE_LOOP drawElements.
Jamie Madillb8e39662018-04-04 11:41:42 -0400416 if (mDirtyLineLoopTranslation)
417 {
Luc Ferrona9120462018-04-12 13:11:03 -0400418 gl::Buffer *elementArrayBuffer = mState.getElementArrayBuffer().get();
419 VkIndexType indexType = gl_vk::GetIndexType(drawCallParams.type());
420
421 if (!elementArrayBuffer)
422 {
423 ANGLE_TRY(mLineLoopHelper.getIndexBufferForClientElementArray(
Luc Ferron3e313802018-06-11 14:44:33 -0400424 renderer, drawCallParams, &mCurrentElementArrayBufferHandle,
425 &mCurrentElementArrayBufferOffset));
Luc Ferrona9120462018-04-12 13:11:03 -0400426 }
427 else
428 {
Luc Ferrona4fa9c22018-04-13 07:00:56 -0400429 // When using an element array buffer, 'indices' is an offset to the first element.
430 intptr_t offset = reinterpret_cast<intptr_t>(drawCallParams.indices());
Luc Ferrona9120462018-04-12 13:11:03 -0400431 BufferVk *elementArrayBufferVk = vk::GetImpl(elementArrayBuffer);
432 ANGLE_TRY(mLineLoopHelper.getIndexBufferForElementArrayBuffer(
Luc Ferrona4fa9c22018-04-13 07:00:56 -0400433 renderer, elementArrayBufferVk, indexType, drawCallParams.indexCount(), offset,
Luc Ferrona9120462018-04-12 13:11:03 -0400434 &mCurrentElementArrayBufferHandle, &mCurrentElementArrayBufferOffset));
435 }
Jamie Madillb8e39662018-04-04 11:41:42 -0400436 }
Jamie Madillc3755fc2018-04-05 08:39:13 -0400437
Jamie Madill316c6062018-05-29 10:49:45 -0400438 ANGLE_TRY(onIndexedDraw(context, renderer, drawCallParams, commandBuffer, newCommandBuffer));
Jamie Madill22f12fe2018-04-08 14:23:40 -0400439 vk::LineLoopHelper::Draw(drawCallParams.indexCount(), commandBuffer);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400440
441 return gl::NoError();
442}
443
444gl::Error VertexArrayVk::onDraw(const gl::Context *context,
445 RendererVk *renderer,
446 const gl::DrawCallParams &drawCallParams,
Jamie Madill316c6062018-05-29 10:49:45 -0400447 vk::CommandBuffer *commandBuffer,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400448 bool newCommandBuffer)
449{
450 const gl::State &state = context->getGLState();
451 const gl::Program *programGL = state.getProgram();
Jamie Madillbcef3222018-04-13 15:19:11 -0400452 const gl::AttributesMask &clientAttribs = mState.getEnabledClientMemoryAttribsMask();
Jamie Madillc3755fc2018-04-05 08:39:13 -0400453 const gl::AttributesMask &activeAttribs = programGL->getActiveAttribLocationsMask();
454 uint32_t maxAttrib = programGL->getState().getMaxActiveAttribLocation();
455
Jamie Madillbcef3222018-04-13 15:19:11 -0400456 if (clientAttribs.any())
Jamie Madillc3755fc2018-04-05 08:39:13 -0400457 {
Jamie Madillbcef3222018-04-13 15:19:11 -0400458 const gl::AttributesMask &attribsToStream = (clientAttribs & activeAttribs);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400459 if (attribsToStream.any())
460 {
461 ANGLE_TRY(drawCallParams.ensureIndexRangeResolved(context));
462 ANGLE_TRY(streamVertexData(renderer, attribsToStream, drawCallParams));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400463 commandBuffer->bindVertexBuffers(0, maxAttrib, mCurrentArrayBufferHandles.data(),
464 mCurrentArrayBufferOffsets.data());
465 }
466 }
467 else if (mVertexBuffersDirty || newCommandBuffer)
468 {
Luc Ferron44162472018-04-06 13:20:45 -0400469 if (maxAttrib > 0)
470 {
Luc Ferron44162472018-04-06 13:20:45 -0400471 commandBuffer->bindVertexBuffers(0, maxAttrib, mCurrentArrayBufferHandles.data(),
472 mCurrentArrayBufferOffsets.data());
Jamie Madill316c6062018-05-29 10:49:45 -0400473
474 vk::CommandGraphResource *drawFramebuffer = vk::GetImpl(state.getDrawFramebuffer());
475 updateArrayBufferReadDependencies(drawFramebuffer, activeAttribs,
Luc Ferron44162472018-04-06 13:20:45 -0400476 renderer->getCurrentQueueSerial());
477 }
Luc Ferronc1e02682018-04-11 11:02:55 -0400478
Jamie Madillc3755fc2018-04-05 08:39:13 -0400479 mVertexBuffersDirty = false;
Luc Ferronc1e02682018-04-11 11:02:55 -0400480
481 // This forces the binding to happen if we follow a drawElement call from a drawArrays call.
482 mIndexBufferDirty = true;
Luc Ferron983c4292018-04-10 13:05:45 -0400483
484 // If we've had a drawElements call with a line loop before, we want to make sure this is
485 // invalidated the next time drawElements is called since we use the same index buffer for
486 // both calls.
487 mDirtyLineLoopTranslation = true;
Jamie Madillc3755fc2018-04-05 08:39:13 -0400488 }
489
490 return gl::NoError();
491}
492
493gl::Error VertexArrayVk::onIndexedDraw(const gl::Context *context,
494 RendererVk *renderer,
495 const gl::DrawCallParams &drawCallParams,
Jamie Madill316c6062018-05-29 10:49:45 -0400496 vk::CommandBuffer *commandBuffer,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400497 bool newCommandBuffer)
498{
Jamie Madill316c6062018-05-29 10:49:45 -0400499 ANGLE_TRY(onDraw(context, renderer, drawCallParams, commandBuffer, newCommandBuffer));
Luc Ferron49aacad2018-06-12 08:33:59 -0400500 bool isLineLoop = drawCallParams.mode() == gl::PrimitiveMode::LineLoop;
Luc Ferron6ed167a2018-06-13 13:45:55 -0400501 gl::Buffer *glBuffer = mState.getElementArrayBuffer().get();
502 uintptr_t offset =
503 glBuffer && !isLineLoop ? reinterpret_cast<uintptr_t>(drawCallParams.indices()) : 0;
Jamie Madillc3755fc2018-04-05 08:39:13 -0400504
Luc Ferron6ed167a2018-06-13 13:45:55 -0400505 if (!glBuffer && !isLineLoop)
Jamie Madillc3755fc2018-04-05 08:39:13 -0400506 {
507 ANGLE_TRY(drawCallParams.ensureIndexRangeResolved(context));
508 ANGLE_TRY(streamIndexData(renderer, drawCallParams));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400509 commandBuffer->bindIndexBuffer(mCurrentElementArrayBufferHandle,
510 mCurrentElementArrayBufferOffset,
511 gl_vk::GetIndexType(drawCallParams.type()));
512 }
Luc Ferron49aacad2018-06-12 08:33:59 -0400513 else if (mIndexBufferDirty || newCommandBuffer || offset != mLastIndexBufferOffset)
Jamie Madillc3755fc2018-04-05 08:39:13 -0400514 {
Luc Ferron3e313802018-06-11 14:44:33 -0400515 if (drawCallParams.type() == GL_UNSIGNED_BYTE &&
516 drawCallParams.mode() != gl::PrimitiveMode::LineLoop)
Jamie Madillc3755fc2018-04-05 08:39:13 -0400517 {
Luc Ferron6ed167a2018-06-13 13:45:55 -0400518 // Unsigned bytes don't have direct support in Vulkan so we have to expand the
519 // memory to a GLushort.
520 BufferVk *bufferVk = vk::GetImpl(glBuffer);
521 void *srcDataMapping = nullptr;
522 ASSERT(!glBuffer->isMapped());
523 ANGLE_TRY(bufferVk->map(context, 0, &srcDataMapping));
524 uint8_t *srcData = reinterpret_cast<uint8_t *>(srcDataMapping);
525 intptr_t offsetIntoSrcData = reinterpret_cast<intptr_t>(drawCallParams.indices());
526 srcData += offsetIntoSrcData;
527
528 // Allocate a new buffer that's double the size of the buffer provided by the user to
529 // go from unsigned byte to unsigned short.
530 uint8_t *allocatedData = nullptr;
531 bool newBufferAllocated = false;
532 uint32_t expandedDataOffset = 0;
533 mTranslatedByteIndexData.allocate(
534 renderer, static_cast<size_t>(bufferVk->getSize()) * 2, &allocatedData,
535 &mCurrentElementArrayBufferHandle, &expandedDataOffset, &newBufferAllocated);
536 mCurrentElementArrayBufferOffset = static_cast<VkDeviceSize>(expandedDataOffset);
537
538 // Expand the source into the destination
539 ASSERT(!context->getGLState().isPrimitiveRestartEnabled());
540 uint16_t *expandedDst = reinterpret_cast<uint16_t *>(allocatedData);
541 for (GLsizei index = 0; index < bufferVk->getSize() - offsetIntoSrcData; index++)
542 {
543 expandedDst[index] = static_cast<GLushort>(srcData[index]);
544 }
545
546 // Make sure our writes are available.
547 mTranslatedByteIndexData.flush(renderer->getDevice());
548 GLboolean result = false;
549 ANGLE_TRY(bufferVk->unmap(context, &result));
550
551 // We do not add the offset from the drawCallParams here because we've already copied
552 // the source starting at the offset requested.
553 commandBuffer->bindIndexBuffer(mCurrentElementArrayBufferHandle,
554 mCurrentElementArrayBufferOffset,
555 gl_vk::GetIndexType(drawCallParams.type()));
556 }
557 else
558 {
559 commandBuffer->bindIndexBuffer(mCurrentElementArrayBufferHandle,
560 mCurrentElementArrayBufferOffset + offset,
561 gl_vk::GetIndexType(drawCallParams.type()));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400562 }
563
Luc Ferron49aacad2018-06-12 08:33:59 -0400564 mLastIndexBufferOffset = offset;
Jamie Madill316c6062018-05-29 10:49:45 -0400565
566 const gl::State &glState = context->getGLState();
567 vk::CommandGraphResource *drawFramebuffer = vk::GetImpl(glState.getDrawFramebuffer());
568 updateElementArrayBufferReadDependency(drawFramebuffer, renderer->getCurrentQueueSerial());
Jamie Madillc3755fc2018-04-05 08:39:13 -0400569 mIndexBufferDirty = false;
Luc Ferron983c4292018-04-10 13:05:45 -0400570
571 // If we've had a drawArrays call with a line loop before, we want to make sure this is
572 // invalidated the next time drawArrays is called since we use the same index buffer for
573 // both calls.
574 mLineLoopBufferFirstIndex.reset();
575 mLineLoopBufferLastIndex.reset();
Jamie Madillc3755fc2018-04-05 08:39:13 -0400576 }
577
578 return gl::NoError();
579}
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400580} // namespace rx