blob: 5e7806bd2d02fb2a516cee4752b25731f104a1d2 [file] [log] [blame]
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001//
Geoff Langcec35902014-04-16 10:52:36 -04002// Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved.
Geoff Lange8ebe7f2013-08-05 15:03:13 -04003// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6
7// validationES.h: Validation functions for generic OpenGL ES entry point parameters
8
Geoff Lang2b5420c2014-11-19 14:20:15 -05009#include "libANGLE/validationES.h"
Jamie Madille2e406c2016-06-02 13:04:10 -040010
Geoff Lang2b5420c2014-11-19 14:20:15 -050011#include "libANGLE/Context.h"
Geoff Langa8406172015-07-21 16:53:39 -040012#include "libANGLE/Display.h"
Brandon Jones6cad5662017-06-14 13:25:13 -070013#include "libANGLE/ErrorStrings.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050014#include "libANGLE/Framebuffer.h"
15#include "libANGLE/FramebufferAttachment.h"
Geoff Langa8406172015-07-21 16:53:39 -040016#include "libANGLE/Image.h"
Geoff Lang7dd2e102014-11-10 15:19:26 -050017#include "libANGLE/Program.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040018#include "libANGLE/Query.h"
19#include "libANGLE/Texture.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050020#include "libANGLE/TransformFeedback.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040021#include "libANGLE/Uniform.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050022#include "libANGLE/VertexArray.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040023#include "libANGLE/formatutils.h"
24#include "libANGLE/validationES2.h"
25#include "libANGLE/validationES3.h"
Geoff Lange8ebe7f2013-08-05 15:03:13 -040026
27#include "common/mathutil.h"
28#include "common/utilities.h"
29
Jamie Madille2e406c2016-06-02 13:04:10 -040030using namespace angle;
31
Geoff Lange8ebe7f2013-08-05 15:03:13 -040032namespace gl
33{
Jamie Madill1ca74672015-07-21 15:14:11 -040034namespace
35{
Corentin Wallez92db6942016-12-09 13:10:36 -050036bool ValidateDrawAttribs(ValidationContext *context,
37 GLint primcount,
38 GLint maxVertex,
39 GLint vertexCount)
Jamie Madill1ca74672015-07-21 15:14:11 -040040{
Jamie Madilldfde6ab2016-06-09 07:07:18 -070041 const gl::State &state = context->getGLState();
Jamie Madill1ca74672015-07-21 15:14:11 -040042 const gl::Program *program = state.getProgram();
43
Corentin Wallez327411e2016-12-09 11:09:17 -050044 bool webglCompatibility = context->getExtensions().webglCompatibility;
45
Jamie Madill231c7f52017-04-26 13:45:37 -040046 const VertexArray *vao = state.getVertexArray();
47 const auto &vertexAttribs = vao->getVertexAttributes();
Jiawei-Shao2597fb62016-12-09 16:38:02 +080048 const auto &vertexBindings = vao->getVertexBindings();
Jamie Madill231c7f52017-04-26 13:45:37 -040049 size_t maxEnabledAttrib = vao->getMaxEnabledAttribute();
Jamie Madill1ca74672015-07-21 15:14:11 -040050 for (size_t attributeIndex = 0; attributeIndex < maxEnabledAttrib; ++attributeIndex)
51 {
52 const VertexAttribute &attrib = vertexAttribs[attributeIndex];
Corentin Wallez672f7f32017-06-15 17:42:17 -040053
54 // No need to range check for disabled attribs.
55 if (!attrib.enabled)
Jamie Madill1ca74672015-07-21 15:14:11 -040056 {
Corentin Wallezfd456442016-12-21 17:57:00 -050057 continue;
58 }
Jamie Madill1ca74672015-07-21 15:14:11 -040059
Jamie Madill231c7f52017-04-26 13:45:37 -040060 // If we have no buffer, then we either get an error, or there are no more checks to be
61 // done.
Corentin Wallez672f7f32017-06-15 17:42:17 -040062 const VertexBinding &binding = vertexBindings[attrib.bindingIndex];
63 gl::Buffer *buffer = binding.getBuffer().get();
Corentin Wallezfd456442016-12-21 17:57:00 -050064 if (!buffer)
65 {
Geoff Langfeb8c682017-02-13 16:07:35 -050066 if (webglCompatibility || !state.areClientArraysEnabled())
Corentin Wallez327411e2016-12-09 11:09:17 -050067 {
68 // [WebGL 1.0] Section 6.5 Enabled Vertex Attributes and Range Checking
Corentin Wallezfd456442016-12-21 17:57:00 -050069 // If a vertex attribute is enabled as an array via enableVertexAttribArray but
70 // no buffer is bound to that attribute via bindBuffer and vertexAttribPointer,
71 // then calls to drawArrays or drawElements will generate an INVALID_OPERATION
72 // error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -050073 context->handleError(InvalidOperation()
74 << "An enabled vertex array has no buffer.");
Corentin Wallezfd456442016-12-21 17:57:00 -050075 return false;
Corentin Wallez327411e2016-12-09 11:09:17 -050076 }
Corentin Wallezfd456442016-12-21 17:57:00 -050077 else if (attrib.pointer == nullptr)
Jamie Madill1ca74672015-07-21 15:14:11 -040078 {
79 // This is an application error that would normally result in a crash,
80 // but we catch it and return an error
Yuly Novikovc4d18aa2017-03-09 18:45:02 -050081 context->handleError(InvalidOperation()
82 << "An enabled vertex array has no buffer and no pointer.");
Jamie Madill1ca74672015-07-21 15:14:11 -040083 return false;
84 }
Corentin Wallezfd456442016-12-21 17:57:00 -050085 continue;
86 }
87
Corentin Wallez672f7f32017-06-15 17:42:17 -040088 // This needs to come after the check for client arrays as even unused attributes cannot use
89 // client-side arrays
90 if (!program->isAttribLocationActive(attributeIndex))
91 {
92 continue;
93 }
94
Corentin Wallezfd456442016-12-21 17:57:00 -050095 // If we're drawing zero vertices, we have enough data.
96 if (vertexCount <= 0 || primcount <= 0)
97 {
98 continue;
99 }
100
101 GLint maxVertexElement = 0;
Martin Radevdd5f27e2017-06-07 10:17:09 +0300102 GLuint divisor = binding.getDivisor();
103 if (divisor == 0)
Corentin Wallezfd456442016-12-21 17:57:00 -0500104 {
105 maxVertexElement = maxVertex;
106 }
107 else
108 {
Martin Radevdd5f27e2017-06-07 10:17:09 +0300109 maxVertexElement = (primcount - 1) / divisor;
Corentin Wallezfd456442016-12-21 17:57:00 -0500110 }
111
112 // We do manual overflow checks here instead of using safe_math.h because it was
113 // a bottleneck. Thanks to some properties of GL we know inequalities that can
114 // help us make the overflow checks faster.
115
116 // The max possible attribSize is 16 for a vector of 4 32 bit values.
117 constexpr uint64_t kMaxAttribSize = 16;
118 constexpr uint64_t kIntMax = std::numeric_limits<int>::max();
119 constexpr uint64_t kUint64Max = std::numeric_limits<uint64_t>::max();
120
121 // We know attribStride is given as a GLsizei which is typedefed to int.
122 // We also know an upper bound for attribSize.
123 static_assert(std::is_same<int, GLsizei>::value, "");
Jiawei-Shao2597fb62016-12-09 16:38:02 +0800124 uint64_t attribStride = ComputeVertexAttributeStride(attrib, binding);
Corentin Wallezfd456442016-12-21 17:57:00 -0500125 uint64_t attribSize = ComputeVertexAttributeTypeSize(attrib);
126 ASSERT(attribStride <= kIntMax && attribSize <= kMaxAttribSize);
127
128 // Computing the max offset using uint64_t without attrib.offset is overflow
129 // safe. Note: Last vertex element does not take the full stride!
130 static_assert(kIntMax * kIntMax < kUint64Max - kMaxAttribSize, "");
131 uint64_t attribDataSizeNoOffset = maxVertexElement * attribStride + attribSize;
132
133 // An overflow can happen when adding the offset, check for it.
Jiawei-Shao2597fb62016-12-09 16:38:02 +0800134 uint64_t attribOffset = ComputeVertexAttributeOffset(attrib, binding);
135 if (attribDataSizeNoOffset > kUint64Max - attribOffset)
Corentin Wallezfd456442016-12-21 17:57:00 -0500136 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500137 context->handleError(InvalidOperation() << "Integer overflow.");
Corentin Wallezfd456442016-12-21 17:57:00 -0500138 return false;
139 }
140 uint64_t attribDataSizeWithOffset = attribDataSizeNoOffset + attribOffset;
141
142 // [OpenGL ES 3.0.2] section 2.9.4 page 40:
143 // We can return INVALID_OPERATION if our vertex attribute does not have
144 // enough backing data.
145 if (attribDataSizeWithOffset > static_cast<uint64_t>(buffer->getSize()))
146 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500147 context->handleError(InvalidOperation()
148 << "Vertex buffer is not big enough for the draw call");
Corentin Wallezfd456442016-12-21 17:57:00 -0500149 return false;
Jamie Madill1ca74672015-07-21 15:14:11 -0400150 }
151 }
152
153 return true;
154}
155
Geoff Lang280ba992017-04-18 16:30:58 -0400156bool ValidReadPixelsTypeEnum(ValidationContext *context, GLenum type)
157{
158 switch (type)
159 {
160 // Types referenced in Table 3.4 of the ES 2.0.25 spec
161 case GL_UNSIGNED_BYTE:
162 case GL_UNSIGNED_SHORT_4_4_4_4:
163 case GL_UNSIGNED_SHORT_5_5_5_1:
164 case GL_UNSIGNED_SHORT_5_6_5:
165 return context->getClientVersion() >= ES_2_0;
166
167 // Types referenced in Table 3.2 of the ES 3.0.5 spec (Except depth stencil)
168 case GL_BYTE:
169 case GL_INT:
170 case GL_SHORT:
171 case GL_UNSIGNED_INT:
172 case GL_UNSIGNED_INT_10F_11F_11F_REV:
173 case GL_UNSIGNED_INT_24_8:
174 case GL_UNSIGNED_INT_2_10_10_10_REV:
175 case GL_UNSIGNED_INT_5_9_9_9_REV:
176 case GL_UNSIGNED_SHORT:
177 case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT:
178 case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT:
179 return context->getClientVersion() >= ES_3_0;
180
181 case GL_FLOAT:
182 return context->getClientVersion() >= ES_3_0 || context->getExtensions().textureFloat;
183
184 case GL_HALF_FLOAT:
185 return context->getClientVersion() >= ES_3_0 ||
186 context->getExtensions().textureHalfFloat;
187
188 case GL_HALF_FLOAT_OES:
189 return context->getExtensions().colorBufferHalfFloat;
190
191 default:
192 return false;
193 }
194}
195
196bool ValidReadPixelsFormatEnum(ValidationContext *context, GLenum format)
197{
198 switch (format)
199 {
200 // Formats referenced in Table 3.4 of the ES 2.0.25 spec (Except luminance)
201 case GL_RGBA:
202 case GL_RGB:
203 case GL_ALPHA:
204 return context->getClientVersion() >= ES_2_0;
205
206 // Formats referenced in Table 3.2 of the ES 3.0.5 spec
207 case GL_RG:
208 case GL_RED:
209 case GL_RGBA_INTEGER:
210 case GL_RGB_INTEGER:
211 case GL_RG_INTEGER:
212 case GL_RED_INTEGER:
213 return context->getClientVersion() >= ES_3_0;
214
215 case GL_SRGB_ALPHA_EXT:
216 case GL_SRGB_EXT:
217 return context->getExtensions().sRGB;
218
219 case GL_BGRA_EXT:
220 return context->getExtensions().readFormatBGRA;
221
222 default:
223 return false;
224 }
225}
226
Geoff Langf607c602016-09-21 11:46:48 -0400227bool ValidReadPixelsFormatType(ValidationContext *context,
228 GLenum framebufferComponentType,
229 GLenum format,
230 GLenum type)
231{
232 switch (framebufferComponentType)
233 {
234 case GL_UNSIGNED_NORMALIZED:
235 // TODO(geofflang): Don't accept BGRA here. Some chrome internals appear to try to use
236 // ReadPixels with BGRA even if the extension is not present
237 return (format == GL_RGBA && type == GL_UNSIGNED_BYTE) ||
238 (context->getExtensions().readFormatBGRA && format == GL_BGRA_EXT &&
239 type == GL_UNSIGNED_BYTE);
240
241 case GL_SIGNED_NORMALIZED:
242 return (format == GL_RGBA && type == GL_UNSIGNED_BYTE);
243
244 case GL_INT:
245 return (format == GL_RGBA_INTEGER && type == GL_INT);
246
247 case GL_UNSIGNED_INT:
248 return (format == GL_RGBA_INTEGER && type == GL_UNSIGNED_INT);
249
250 case GL_FLOAT:
251 return (format == GL_RGBA && type == GL_FLOAT);
252
253 default:
254 UNREACHABLE();
255 return false;
256 }
257}
258
Geoff Langc1984ed2016-10-07 12:41:00 -0400259template <typename ParamType>
260bool ValidateTextureWrapModeValue(Context *context, ParamType *params, bool isExternalTextureTarget)
261{
262 switch (ConvertToGLenum(params[0]))
263 {
264 case GL_CLAMP_TO_EDGE:
265 break;
266
267 case GL_REPEAT:
268 case GL_MIRRORED_REPEAT:
269 if (isExternalTextureTarget)
270 {
271 // OES_EGL_image_external specifies this error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500272 context->handleError(InvalidEnum()
273 << "external textures only support CLAMP_TO_EDGE wrap mode");
Geoff Langc1984ed2016-10-07 12:41:00 -0400274 return false;
275 }
276 break;
277
278 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500279 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400280 return false;
281 }
282
283 return true;
284}
285
286template <typename ParamType>
287bool ValidateTextureMinFilterValue(Context *context,
288 ParamType *params,
289 bool isExternalTextureTarget)
290{
291 switch (ConvertToGLenum(params[0]))
292 {
293 case GL_NEAREST:
294 case GL_LINEAR:
295 break;
296
297 case GL_NEAREST_MIPMAP_NEAREST:
298 case GL_LINEAR_MIPMAP_NEAREST:
299 case GL_NEAREST_MIPMAP_LINEAR:
300 case GL_LINEAR_MIPMAP_LINEAR:
301 if (isExternalTextureTarget)
302 {
303 // OES_EGL_image_external specifies this error.
304 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500305 InvalidEnum() << "external textures only support NEAREST and LINEAR filtering");
Geoff Langc1984ed2016-10-07 12:41:00 -0400306 return false;
307 }
308 break;
309
310 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700311 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam);
Geoff Langc1984ed2016-10-07 12:41:00 -0400312 return false;
313 }
314
315 return true;
316}
317
318template <typename ParamType>
319bool ValidateTextureMagFilterValue(Context *context, ParamType *params)
320{
321 switch (ConvertToGLenum(params[0]))
322 {
323 case GL_NEAREST:
324 case GL_LINEAR:
325 break;
326
327 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700328 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam);
Geoff Langc1984ed2016-10-07 12:41:00 -0400329 return false;
330 }
331
332 return true;
333}
334
335template <typename ParamType>
336bool ValidateTextureCompareModeValue(Context *context, ParamType *params)
337{
338 // Acceptable mode parameters from GLES 3.0.2 spec, table 3.17
339 switch (ConvertToGLenum(params[0]))
340 {
341 case GL_NONE:
342 case GL_COMPARE_REF_TO_TEXTURE:
343 break;
344
345 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500346 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400347 return false;
348 }
349
350 return true;
351}
352
353template <typename ParamType>
354bool ValidateTextureCompareFuncValue(Context *context, ParamType *params)
355{
356 // Acceptable function parameters from GLES 3.0.2 spec, table 3.17
357 switch (ConvertToGLenum(params[0]))
358 {
359 case GL_LEQUAL:
360 case GL_GEQUAL:
361 case GL_LESS:
362 case GL_GREATER:
363 case GL_EQUAL:
364 case GL_NOTEQUAL:
365 case GL_ALWAYS:
366 case GL_NEVER:
367 break;
368
369 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500370 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400371 return false;
372 }
373
374 return true;
375}
376
377template <typename ParamType>
Geoff Lang81c6b572016-10-19 14:07:52 -0700378bool ValidateTextureSRGBDecodeValue(Context *context, ParamType *params)
379{
380 if (!context->getExtensions().textureSRGBDecode)
381 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700382 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Geoff Lang81c6b572016-10-19 14:07:52 -0700383 return false;
384 }
385
386 switch (ConvertToGLenum(params[0]))
387 {
388 case GL_DECODE_EXT:
389 case GL_SKIP_DECODE_EXT:
390 break;
391
392 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500393 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Lang81c6b572016-10-19 14:07:52 -0700394 return false;
395 }
396
397 return true;
398}
399
400template <typename ParamType>
Geoff Langc1984ed2016-10-07 12:41:00 -0400401bool ValidateSamplerParameterBase(Context *context,
402 GLuint sampler,
403 GLenum pname,
404 GLsizei bufSize,
405 ParamType *params)
406{
407 if (context->getClientMajorVersion() < 3)
408 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500409 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400410 return false;
411 }
412
413 if (!context->isSampler(sampler))
414 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500415 context->handleError(InvalidOperation() << "Sampler is not valid.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400416 return false;
417 }
418
419 const GLsizei minBufSize = 1;
420 if (bufSize >= 0 && bufSize < minBufSize)
421 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500422 context->handleError(InvalidOperation() << "bufSize must be at least " << minBufSize);
Geoff Langc1984ed2016-10-07 12:41:00 -0400423 return false;
424 }
425
426 switch (pname)
427 {
428 case GL_TEXTURE_WRAP_S:
429 case GL_TEXTURE_WRAP_T:
430 case GL_TEXTURE_WRAP_R:
431 if (!ValidateTextureWrapModeValue(context, params, false))
432 {
433 return false;
434 }
435 break;
436
437 case GL_TEXTURE_MIN_FILTER:
438 if (!ValidateTextureMinFilterValue(context, params, false))
439 {
440 return false;
441 }
442 break;
443
444 case GL_TEXTURE_MAG_FILTER:
445 if (!ValidateTextureMagFilterValue(context, params))
446 {
447 return false;
448 }
449 break;
450
451 case GL_TEXTURE_MIN_LOD:
452 case GL_TEXTURE_MAX_LOD:
453 // any value is permissible
454 break;
455
456 case GL_TEXTURE_COMPARE_MODE:
457 if (!ValidateTextureCompareModeValue(context, params))
458 {
459 return false;
460 }
461 break;
462
463 case GL_TEXTURE_COMPARE_FUNC:
464 if (!ValidateTextureCompareFuncValue(context, params))
465 {
466 return false;
467 }
468 break;
469
Geoff Lang81c6b572016-10-19 14:07:52 -0700470 case GL_TEXTURE_SRGB_DECODE_EXT:
471 if (!ValidateTextureSRGBDecodeValue(context, params))
472 {
473 return false;
474 }
475 break;
476
Geoff Langc1984ed2016-10-07 12:41:00 -0400477 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700478 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langc1984ed2016-10-07 12:41:00 -0400479 return false;
480 }
481
482 return true;
483}
484
485bool ValidateGetSamplerParameterBase(Context *context,
486 GLuint sampler,
487 GLenum pname,
488 GLsizei *length)
489{
490 if (length)
491 {
492 *length = 0;
493 }
494
495 if (context->getClientMajorVersion() < 3)
496 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500497 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400498 return false;
499 }
500
501 if (!context->isSampler(sampler))
502 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500503 context->handleError(InvalidOperation() << "Sampler is not valid.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400504 return false;
505 }
506
507 switch (pname)
508 {
509 case GL_TEXTURE_WRAP_S:
510 case GL_TEXTURE_WRAP_T:
511 case GL_TEXTURE_WRAP_R:
512 case GL_TEXTURE_MIN_FILTER:
513 case GL_TEXTURE_MAG_FILTER:
514 case GL_TEXTURE_MIN_LOD:
515 case GL_TEXTURE_MAX_LOD:
516 case GL_TEXTURE_COMPARE_MODE:
517 case GL_TEXTURE_COMPARE_FUNC:
518 break;
519
Geoff Lang81c6b572016-10-19 14:07:52 -0700520 case GL_TEXTURE_SRGB_DECODE_EXT:
521 if (!context->getExtensions().textureSRGBDecode)
522 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500523 context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled.");
Geoff Lang81c6b572016-10-19 14:07:52 -0700524 return false;
525 }
526 break;
527
Geoff Langc1984ed2016-10-07 12:41:00 -0400528 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700529 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langc1984ed2016-10-07 12:41:00 -0400530 return false;
531 }
532
533 if (length)
534 {
535 *length = 1;
536 }
537 return true;
538}
539
Geoff Lang6899b872016-10-14 11:30:13 -0400540bool ValidateGetActiveUniformBlockivBase(Context *context,
541 GLuint program,
542 GLuint uniformBlockIndex,
543 GLenum pname,
544 GLsizei *length)
545{
546 if (length)
547 {
548 *length = 0;
549 }
550
551 if (context->getClientMajorVersion() < 3)
552 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500553 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Lang6899b872016-10-14 11:30:13 -0400554 return false;
555 }
556
557 Program *programObject = GetValidProgram(context, program);
558 if (!programObject)
559 {
560 return false;
561 }
562
563 if (uniformBlockIndex >= programObject->getActiveUniformBlockCount())
564 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500565 context->handleError(InvalidValue()
566 << "uniformBlockIndex exceeds active uniform block count.");
Geoff Lang6899b872016-10-14 11:30:13 -0400567 return false;
568 }
569
570 switch (pname)
571 {
572 case GL_UNIFORM_BLOCK_BINDING:
573 case GL_UNIFORM_BLOCK_DATA_SIZE:
574 case GL_UNIFORM_BLOCK_NAME_LENGTH:
575 case GL_UNIFORM_BLOCK_ACTIVE_UNIFORMS:
576 case GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES:
577 case GL_UNIFORM_BLOCK_REFERENCED_BY_VERTEX_SHADER:
578 case GL_UNIFORM_BLOCK_REFERENCED_BY_FRAGMENT_SHADER:
579 break;
580
581 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700582 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang6899b872016-10-14 11:30:13 -0400583 return false;
584 }
585
586 if (length)
587 {
588 if (pname == GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES)
589 {
590 const UniformBlock &uniformBlock =
591 programObject->getUniformBlockByIndex(uniformBlockIndex);
jchen10eaef1e52017-06-13 10:44:11 +0800592 *length = static_cast<GLsizei>(uniformBlock.memberIndexes.size());
Geoff Lang6899b872016-10-14 11:30:13 -0400593 }
594 else
595 {
596 *length = 1;
597 }
598 }
599
600 return true;
601}
602
Geoff Lang0a9661f2016-10-20 10:59:20 -0700603bool ValidateGetInternalFormativBase(Context *context,
604 GLenum target,
605 GLenum internalformat,
606 GLenum pname,
607 GLsizei bufSize,
608 GLsizei *numParams)
609{
610 if (numParams)
611 {
612 *numParams = 0;
613 }
614
615 if (context->getClientMajorVersion() < 3)
616 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500617 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Lang0a9661f2016-10-20 10:59:20 -0700618 return false;
619 }
620
621 const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat);
622 if (!formatCaps.renderable)
623 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500624 context->handleError(InvalidEnum() << "Internal format is not renderable.");
Geoff Lang0a9661f2016-10-20 10:59:20 -0700625 return false;
626 }
627
628 switch (target)
629 {
630 case GL_RENDERBUFFER:
631 break;
632
JiangYizhoubddc46b2016-12-09 09:50:51 +0800633 case GL_TEXTURE_2D_MULTISAMPLE:
634 if (context->getClientVersion() < ES_3_1)
635 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500636 context->handleError(InvalidOperation()
637 << "Texture target requires at least OpenGL ES 3.1.");
JiangYizhoubddc46b2016-12-09 09:50:51 +0800638 return false;
639 }
640 break;
641
Geoff Lang0a9661f2016-10-20 10:59:20 -0700642 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500643 context->handleError(InvalidEnum() << "Invalid target.");
Geoff Lang0a9661f2016-10-20 10:59:20 -0700644 return false;
645 }
646
647 if (bufSize < 0)
648 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700649 ANGLE_VALIDATION_ERR(context, InvalidValue(), InsufficientBufferSize);
Geoff Lang0a9661f2016-10-20 10:59:20 -0700650 return false;
651 }
652
653 GLsizei maxWriteParams = 0;
654 switch (pname)
655 {
656 case GL_NUM_SAMPLE_COUNTS:
657 maxWriteParams = 1;
658 break;
659
660 case GL_SAMPLES:
661 maxWriteParams = static_cast<GLsizei>(formatCaps.sampleCounts.size());
662 break;
663
664 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700665 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang0a9661f2016-10-20 10:59:20 -0700666 return false;
667 }
668
669 if (numParams)
670 {
671 // glGetInternalFormativ will not overflow bufSize
672 *numParams = std::min(bufSize, maxWriteParams);
673 }
674
675 return true;
676}
677
Jamie Madillc1d770e2017-04-13 17:31:24 -0400678bool ValidateUniformCommonBase(ValidationContext *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500679 gl::Program *program,
680 GLint location,
681 GLsizei count,
682 const LinkedUniform **uniformOut)
683{
684 // TODO(Jiajia): Add image uniform check in future.
685 if (count < 0)
686 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700687 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500688 return false;
689 }
690
Brandon Jones6cad5662017-06-14 13:25:13 -0700691 if (!program)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500692 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700693 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidProgramName);
694 return false;
695 }
696
697 if (!program->isLinked())
698 {
699 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500700 return false;
701 }
702
703 if (location == -1)
704 {
705 // Silently ignore the uniform command
706 return false;
707 }
708
709 const auto &uniformLocations = program->getUniformLocations();
Jamie Madillbe849e42017-05-02 15:49:00 -0400710 size_t castedLocation = static_cast<size_t>(location);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500711 if (castedLocation >= uniformLocations.size())
712 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500713 context->handleError(InvalidOperation() << "Invalid uniform location");
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500714 return false;
715 }
716
717 const auto &uniformLocation = uniformLocations[castedLocation];
718 if (uniformLocation.ignored)
719 {
720 // Silently ignore the uniform command
721 return false;
722 }
723
724 if (!uniformLocation.used)
725 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500726 context->handleError(InvalidOperation());
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500727 return false;
728 }
729
730 const auto &uniform = program->getUniformByIndex(uniformLocation.index);
731
732 // attempting to write an array to a non-array uniform is an INVALID_OPERATION
733 if (!uniform.isArray() && count > 1)
734 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500735 context->handleError(InvalidOperation());
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500736 return false;
737 }
738
739 *uniformOut = &uniform;
740 return true;
741}
742
Frank Henigman999b0fd2017-02-02 21:45:55 -0500743bool ValidateUniform1ivValue(ValidationContext *context,
Frank Henigmana98a6472017-02-02 21:38:32 -0500744 GLenum uniformType,
745 GLsizei count,
746 const GLint *value)
747{
748 // Value type is GL_INT, because we only get here from glUniform1i{v}.
749 // It is compatible with INT or BOOL.
750 // Do these cheap tests first, for a little extra speed.
751 if (GL_INT == uniformType || GL_BOOL == uniformType)
752 {
753 return true;
754 }
755
756 if (IsSamplerType(uniformType))
757 {
Frank Henigman999b0fd2017-02-02 21:45:55 -0500758 // Check that the values are in range.
759 const GLint max = context->getCaps().maxCombinedTextureImageUnits;
760 for (GLsizei i = 0; i < count; ++i)
761 {
762 if (value[i] < 0 || value[i] >= max)
763 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500764 context->handleError(InvalidValue() << "sampler uniform value out of range");
Frank Henigman999b0fd2017-02-02 21:45:55 -0500765 return false;
766 }
767 }
Frank Henigmana98a6472017-02-02 21:38:32 -0500768 return true;
769 }
770
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500771 context->handleError(InvalidOperation() << "wrong type of value for uniform");
Frank Henigmana98a6472017-02-02 21:38:32 -0500772 return false;
773}
774
Jamie Madillc1d770e2017-04-13 17:31:24 -0400775bool ValidateUniformValue(ValidationContext *context, GLenum valueType, GLenum uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500776{
777 // Check that the value type is compatible with uniform type.
Frank Henigmana98a6472017-02-02 21:38:32 -0500778 // Do the cheaper test first, for a little extra speed.
779 if (valueType == uniformType || VariableBoolVectorType(valueType) == uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500780 {
781 return true;
782 }
783
Brandon Jones6cad5662017-06-14 13:25:13 -0700784 ANGLE_VALIDATION_ERR(context, InvalidOperation(), UniformSizeDoesNotMatchMethod);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500785 return false;
786}
787
Jamie Madillc1d770e2017-04-13 17:31:24 -0400788bool ValidateUniformMatrixValue(ValidationContext *context, GLenum valueType, GLenum uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500789{
790 // Check that the value type is compatible with uniform type.
791 if (valueType == uniformType)
792 {
793 return true;
794 }
795
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500796 context->handleError(InvalidOperation() << "wrong type of value for uniform");
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500797 return false;
798}
799
Geoff Lange0cff192017-05-30 13:04:56 -0400800bool ValidateFragmentShaderColorBufferTypeMatch(ValidationContext *context)
801{
802 const Program *program = context->getGLState().getProgram();
803 const Framebuffer *framebuffer = context->getGLState().getDrawFramebuffer();
804
805 const auto &programOutputTypes = program->getOutputVariableTypes();
806 for (size_t drawBufferIdx = 0; drawBufferIdx < programOutputTypes.size(); drawBufferIdx++)
807 {
808 GLenum outputType = programOutputTypes[drawBufferIdx];
809 GLenum inputType = framebuffer->getDrawbufferWriteType(drawBufferIdx);
810 if (outputType != GL_NONE && inputType != GL_NONE && inputType != outputType)
811 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500812 context->handleError(InvalidOperation() << "Fragment shader output type does not "
813 "match the bound framebuffer attachment "
814 "type.");
Geoff Lange0cff192017-05-30 13:04:56 -0400815 return false;
816 }
817 }
818
819 return true;
820}
821
Geoff Lang9ab5b822017-05-30 16:19:23 -0400822bool ValidateVertexShaderAttributeTypeMatch(ValidationContext *context)
823{
824 const Program *program = context->getGLState().getProgram();
825 const VertexArray *vao = context->getGLState().getVertexArray();
826
827 for (const auto &shaderAttribute : program->getAttributes())
828 {
Geoff Lang69df2422017-07-05 12:42:31 -0400829 // gl_VertexID and gl_InstanceID are active attributes but don't have a bound attribute.
830 if (shaderAttribute.isBuiltIn())
831 {
832 continue;
833 }
834
Geoff Lang9ab5b822017-05-30 16:19:23 -0400835 GLenum shaderInputType = VariableComponentType(shaderAttribute.type);
836
837 const auto &attrib = vao->getVertexAttribute(shaderAttribute.location);
838 const auto &currentValue =
839 context->getGLState().getVertexAttribCurrentValue(shaderAttribute.location);
840 GLenum vertexType = attrib.enabled ? GetVertexAttributeBaseType(attrib) : currentValue.Type;
841
842 if (shaderInputType != GL_NONE && vertexType != GL_NONE && shaderInputType != vertexType)
843 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500844 context->handleError(InvalidOperation() << "Vertex shader input type does not "
845 "match the type of the bound vertex "
846 "attribute.");
Geoff Lang9ab5b822017-05-30 16:19:23 -0400847 return false;
848 }
849 }
850
851 return true;
852}
853
Geoff Langf41a7152016-09-19 15:11:17 -0400854} // anonymous namespace
855
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500856bool ValidTextureTarget(const ValidationContext *context, GLenum target)
Jamie Madill35d15012013-10-07 10:46:37 -0400857{
Jamie Madilld7460c72014-01-21 16:38:14 -0500858 switch (target)
Jamie Madill35d15012013-10-07 10:46:37 -0400859 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800860 case GL_TEXTURE_2D:
861 case GL_TEXTURE_CUBE_MAP:
862 return true;
Jamie Madill35d15012013-10-07 10:46:37 -0400863
He Yunchaoced53ae2016-11-29 15:00:51 +0800864 case GL_TEXTURE_3D:
865 case GL_TEXTURE_2D_ARRAY:
866 return (context->getClientMajorVersion() >= 3);
Jamie Madilld7460c72014-01-21 16:38:14 -0500867
He Yunchaoced53ae2016-11-29 15:00:51 +0800868 case GL_TEXTURE_2D_MULTISAMPLE:
He Yunchaoced53ae2016-11-29 15:00:51 +0800869 return (context->getClientVersion() >= Version(3, 1));
Geoff Lang3b573612016-10-31 14:08:10 -0400870
He Yunchaoced53ae2016-11-29 15:00:51 +0800871 default:
872 return false;
Jamie Madilld7460c72014-01-21 16:38:14 -0500873 }
Jamie Madill35d15012013-10-07 10:46:37 -0400874}
875
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500876bool ValidTexture2DTarget(const ValidationContext *context, GLenum target)
877{
878 switch (target)
879 {
880 case GL_TEXTURE_2D:
881 case GL_TEXTURE_CUBE_MAP:
882 return true;
883
884 default:
885 return false;
886 }
887}
888
889bool ValidTexture3DTarget(const ValidationContext *context, GLenum target)
890{
891 switch (target)
892 {
893 case GL_TEXTURE_3D:
894 case GL_TEXTURE_2D_ARRAY:
Martin Radev1be913c2016-07-11 17:59:16 +0300895 return (context->getClientMajorVersion() >= 3);
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500896
897 default:
898 return false;
899 }
900}
901
Ian Ewellbda75592016-04-18 17:25:54 -0400902// Most texture GL calls are not compatible with external textures, so we have a separate validation
903// function for use in the GL calls that do
904bool ValidTextureExternalTarget(const ValidationContext *context, GLenum target)
905{
906 return (target == GL_TEXTURE_EXTERNAL_OES) &&
907 (context->getExtensions().eglImageExternal ||
908 context->getExtensions().eglStreamConsumerExternal);
909}
910
Shannon Woods4dfed832014-03-17 20:03:39 -0400911// This function differs from ValidTextureTarget in that the target must be
912// usable as the destination of a 2D operation-- so a cube face is valid, but
913// GL_TEXTURE_CUBE_MAP is not.
Jamie Madill560a8d82014-05-21 13:06:20 -0400914// Note: duplicate of IsInternalTextureTarget
Jamie Madillc29968b2016-01-20 11:17:23 -0500915bool ValidTexture2DDestinationTarget(const ValidationContext *context, GLenum target)
Shannon Woods4dfed832014-03-17 20:03:39 -0400916{
917 switch (target)
918 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800919 case GL_TEXTURE_2D:
920 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
921 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
922 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
923 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
924 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
925 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
926 return true;
927 default:
928 return false;
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500929 }
930}
931
Jamie Madillbe849e42017-05-02 15:49:00 -0400932bool ValidateDrawElementsInstancedBase(ValidationContext *context,
933 GLenum mode,
934 GLsizei count,
935 GLenum type,
936 const GLvoid *indices,
937 GLsizei primcount)
938{
939 if (primcount < 0)
940 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500941 context->handleError(InvalidValue() << "primcount cannot be negative.");
Jamie Madillbe849e42017-05-02 15:49:00 -0400942 return false;
943 }
944
945 if (!ValidateDrawElementsCommon(context, mode, count, type, indices, primcount))
946 {
947 return false;
948 }
949
950 // No-op zero primitive count
951 return (primcount > 0);
952}
953
954bool ValidateDrawArraysInstancedBase(Context *context,
955 GLenum mode,
956 GLint first,
957 GLsizei count,
958 GLsizei primcount)
959{
960 if (primcount < 0)
961 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500962 context->handleError(InvalidValue() << "primcount cannot be negative.");
Jamie Madillbe849e42017-05-02 15:49:00 -0400963 return false;
964 }
965
966 if (!ValidateDrawArraysCommon(context, mode, first, count, primcount))
967 {
968 return false;
969 }
970
971 // No-op if zero primitive count
972 return (primcount > 0);
973}
974
Corentin Wallez0dc97812017-06-22 14:38:44 -0400975bool ValidateDrawInstancedANGLE(ValidationContext *context)
Jamie Madillbe849e42017-05-02 15:49:00 -0400976{
977 // Verify there is at least one active attribute with a divisor of zero
978 const State &state = context->getGLState();
979
980 Program *program = state.getProgram();
981
982 const auto &attribs = state.getVertexArray()->getVertexAttributes();
983 const auto &bindings = state.getVertexArray()->getVertexBindings();
984 for (size_t attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++)
985 {
986 const VertexAttribute &attrib = attribs[attributeIndex];
987 const VertexBinding &binding = bindings[attrib.bindingIndex];
Martin Radevdd5f27e2017-06-07 10:17:09 +0300988 if (program->isAttribLocationActive(attributeIndex) && binding.getDivisor() == 0)
Jamie Madillbe849e42017-05-02 15:49:00 -0400989 {
990 return true;
991 }
992 }
993
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500994 context->handleError(InvalidOperation()
995 << "At least one attribute must have a divisor of zero.");
Jamie Madillbe849e42017-05-02 15:49:00 -0400996 return false;
997}
998
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500999bool ValidTexture3DDestinationTarget(const ValidationContext *context, GLenum target)
1000{
1001 switch (target)
1002 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001003 case GL_TEXTURE_3D:
1004 case GL_TEXTURE_2D_ARRAY:
1005 return true;
1006 default:
1007 return false;
Shannon Woods4dfed832014-03-17 20:03:39 -04001008 }
1009}
1010
He Yunchao11b038b2016-11-22 21:24:04 +08001011bool ValidTexLevelDestinationTarget(const ValidationContext *context, GLenum target)
1012{
1013 switch (target)
1014 {
1015 case GL_TEXTURE_2D:
1016 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
1017 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
1018 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
1019 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
1020 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
1021 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
1022 case GL_TEXTURE_3D:
1023 case GL_TEXTURE_2D_ARRAY:
1024 case GL_TEXTURE_2D_MULTISAMPLE:
1025 return true;
1026 default:
1027 return false;
1028 }
1029}
1030
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001031bool ValidFramebufferTarget(GLenum target)
1032{
He Yunchaoced53ae2016-11-29 15:00:51 +08001033 static_assert(GL_DRAW_FRAMEBUFFER_ANGLE == GL_DRAW_FRAMEBUFFER &&
1034 GL_READ_FRAMEBUFFER_ANGLE == GL_READ_FRAMEBUFFER,
Geoff Langd4475812015-03-18 10:53:05 -04001035 "ANGLE framebuffer enums must equal the ES3 framebuffer enums.");
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001036
1037 switch (target)
1038 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001039 case GL_FRAMEBUFFER:
1040 return true;
1041 case GL_READ_FRAMEBUFFER:
1042 return true;
1043 case GL_DRAW_FRAMEBUFFER:
1044 return true;
1045 default:
1046 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001047 }
1048}
1049
Jamie Madill29639852016-09-02 15:00:09 -04001050bool ValidBufferTarget(const ValidationContext *context, GLenum target)
Jamie Madill8c96d582014-03-05 15:01:23 -05001051{
1052 switch (target)
1053 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001054 case GL_ARRAY_BUFFER:
1055 case GL_ELEMENT_ARRAY_BUFFER:
1056 return true;
Jamie Madill8c96d582014-03-05 15:01:23 -05001057
He Yunchaoced53ae2016-11-29 15:00:51 +08001058 case GL_PIXEL_PACK_BUFFER:
1059 case GL_PIXEL_UNPACK_BUFFER:
1060 return (context->getExtensions().pixelBufferObject ||
1061 context->getClientMajorVersion() >= 3);
Shannon Woods158c4382014-05-06 13:00:07 -04001062
He Yunchaoced53ae2016-11-29 15:00:51 +08001063 case GL_COPY_READ_BUFFER:
1064 case GL_COPY_WRITE_BUFFER:
1065 case GL_TRANSFORM_FEEDBACK_BUFFER:
1066 case GL_UNIFORM_BUFFER:
1067 return (context->getClientMajorVersion() >= 3);
Jamie Madill8c96d582014-03-05 15:01:23 -05001068
He Yunchaoced53ae2016-11-29 15:00:51 +08001069 case GL_ATOMIC_COUNTER_BUFFER:
1070 case GL_SHADER_STORAGE_BUFFER:
1071 case GL_DRAW_INDIRECT_BUFFER:
1072 case GL_DISPATCH_INDIRECT_BUFFER:
He Yunchaoced53ae2016-11-29 15:00:51 +08001073 return context->getClientVersion() >= Version(3, 1);
Geoff Lang3b573612016-10-31 14:08:10 -04001074
He Yunchaoced53ae2016-11-29 15:00:51 +08001075 default:
1076 return false;
Jamie Madill8c96d582014-03-05 15:01:23 -05001077 }
1078}
1079
Jamie Madillc29968b2016-01-20 11:17:23 -05001080bool ValidMipLevel(const ValidationContext *context, GLenum target, GLint level)
Geoff Langce635692013-09-24 13:56:32 -04001081{
Jamie Madillc29968b2016-01-20 11:17:23 -05001082 const auto &caps = context->getCaps();
Geoff Langaae65a42014-05-26 12:43:44 -04001083 size_t maxDimension = 0;
Geoff Langce635692013-09-24 13:56:32 -04001084 switch (target)
1085 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001086 case GL_TEXTURE_2D:
1087 maxDimension = caps.max2DTextureSize;
1088 break;
He Yunchaoced53ae2016-11-29 15:00:51 +08001089 case GL_TEXTURE_CUBE_MAP:
1090 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
1091 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
1092 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
1093 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
1094 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
1095 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
1096 maxDimension = caps.maxCubeMapTextureSize;
1097 break;
1098 case GL_TEXTURE_3D:
1099 maxDimension = caps.max3DTextureSize;
1100 break;
1101 case GL_TEXTURE_2D_ARRAY:
1102 maxDimension = caps.max2DTextureSize;
1103 break;
He Yunchao11b038b2016-11-22 21:24:04 +08001104 case GL_TEXTURE_2D_MULTISAMPLE:
1105 maxDimension = caps.max2DTextureSize;
1106 break;
He Yunchaoced53ae2016-11-29 15:00:51 +08001107 default:
1108 UNREACHABLE();
Geoff Langce635692013-09-24 13:56:32 -04001109 }
1110
Brandon Jones6cad5662017-06-14 13:25:13 -07001111 return level <= gl::log2(static_cast<int>(maxDimension)) && level >= 0;
Geoff Langce635692013-09-24 13:56:32 -04001112}
1113
Brandon Jones6cad5662017-06-14 13:25:13 -07001114bool ValidImageSizeParameters(ValidationContext *context,
Austin Kinross08528e12015-10-07 16:24:40 -07001115 GLenum target,
1116 GLint level,
1117 GLsizei width,
1118 GLsizei height,
1119 GLsizei depth,
1120 bool isSubImage)
Geoff Langce635692013-09-24 13:56:32 -04001121{
Brandon Jones6cad5662017-06-14 13:25:13 -07001122 if (width < 0 || height < 0 || depth < 0)
Geoff Langce635692013-09-24 13:56:32 -04001123 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001124 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Geoff Langce635692013-09-24 13:56:32 -04001125 return false;
1126 }
Austin Kinross08528e12015-10-07 16:24:40 -07001127 // TexSubImage parameters can be NPOT without textureNPOT extension,
1128 // as long as the destination texture is POT.
Geoff Langcc507aa2016-12-12 10:09:52 -05001129 bool hasNPOTSupport =
Geoff Lang5f319a42017-01-09 16:49:19 -05001130 context->getExtensions().textureNPOT || context->getClientVersion() >= Version(3, 0);
Geoff Langcc507aa2016-12-12 10:09:52 -05001131 if (!isSubImage && !hasNPOTSupport &&
Jamie Madill4fd75c12014-06-23 10:53:54 -04001132 (level != 0 && (!gl::isPow2(width) || !gl::isPow2(height) || !gl::isPow2(depth))))
Geoff Langce635692013-09-24 13:56:32 -04001133 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001134 ANGLE_VALIDATION_ERR(context, InvalidValue(), TextureNotPow2);
Geoff Langce635692013-09-24 13:56:32 -04001135 return false;
1136 }
1137
1138 if (!ValidMipLevel(context, target, level))
1139 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001140 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Geoff Langce635692013-09-24 13:56:32 -04001141 return false;
1142 }
1143
1144 return true;
1145}
1146
Geoff Lang0d8b7242015-09-09 14:56:53 -04001147bool CompressedTextureFormatRequiresExactSize(GLenum internalFormat)
1148{
1149 // List of compressed format that require that the texture size is smaller than or a multiple of
1150 // the compressed block size.
1151 switch (internalFormat)
1152 {
1153 case GL_COMPRESSED_RGB_S3TC_DXT1_EXT:
1154 case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT:
1155 case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE:
1156 case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE:
Geoff Langfff7a7d2017-06-02 10:39:17 -04001157 case GL_COMPRESSED_SRGB_S3TC_DXT1_EXT:
1158 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT:
1159 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT:
1160 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT:
Minmin Gonge3939b92015-12-01 15:36:51 -08001161 case GL_ETC1_RGB8_LOSSY_DECODE_ANGLE:
Minmin Gong390208b2017-02-28 18:03:06 -08001162 case GL_COMPRESSED_RGB8_LOSSY_DECODE_ETC2_ANGLE:
1163 case GL_COMPRESSED_SRGB8_LOSSY_DECODE_ETC2_ANGLE:
1164 case GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE:
1165 case GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE:
1166 case GL_COMPRESSED_RGBA8_LOSSY_DECODE_ETC2_EAC_ANGLE:
1167 case GL_COMPRESSED_SRGB8_ALPHA8_LOSSY_DECODE_ETC2_EAC_ANGLE:
Geoff Lang0d8b7242015-09-09 14:56:53 -04001168 return true;
1169
1170 default:
1171 return false;
1172 }
1173}
1174
Geoff Lang966c9402017-04-18 12:38:27 -04001175bool ValidCompressedDimension(GLsizei size, GLuint blockSize, bool smallerThanBlockSizeAllowed)
1176{
1177 return (smallerThanBlockSizeAllowed && (size > 0) && (blockSize % size == 0)) ||
1178 (size % blockSize == 0);
1179}
1180
Jamie Madillc29968b2016-01-20 11:17:23 -05001181bool ValidCompressedImageSize(const ValidationContext *context,
1182 GLenum internalFormat,
Geoff Lang966c9402017-04-18 12:38:27 -04001183 GLint level,
Jamie Madillc29968b2016-01-20 11:17:23 -05001184 GLsizei width,
1185 GLsizei height)
Geoff Langd4f180b2013-09-24 13:57:44 -04001186{
Geoff Langca271392017-04-05 12:30:00 -04001187 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat);
Geoff Lang5d601382014-07-22 15:14:06 -04001188 if (!formatInfo.compressed)
Geoff Langd4f180b2013-09-24 13:57:44 -04001189 {
1190 return false;
1191 }
1192
Geoff Lang966c9402017-04-18 12:38:27 -04001193 if (width < 0 || height < 0)
1194 {
1195 return false;
1196 }
1197
1198 if (CompressedTextureFormatRequiresExactSize(internalFormat))
1199 {
1200 // The ANGLE extensions allow specifying compressed textures with sizes smaller than the
1201 // block size for level 0 but WebGL disallows this.
1202 bool smallerThanBlockSizeAllowed =
1203 level > 0 || !context->getExtensions().webglCompatibility;
1204
1205 if (!ValidCompressedDimension(width, formatInfo.compressedBlockWidth,
1206 smallerThanBlockSizeAllowed) ||
1207 !ValidCompressedDimension(height, formatInfo.compressedBlockHeight,
1208 smallerThanBlockSizeAllowed))
1209 {
1210 return false;
1211 }
1212 }
1213
1214 return true;
1215}
1216
1217bool ValidCompressedSubImageSize(const ValidationContext *context,
1218 GLenum internalFormat,
1219 GLint xoffset,
1220 GLint yoffset,
1221 GLsizei width,
1222 GLsizei height,
1223 size_t textureWidth,
1224 size_t textureHeight)
1225{
1226 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat);
1227 if (!formatInfo.compressed)
1228 {
1229 return false;
1230 }
1231
Geoff Lang44ff5a72017-02-03 15:15:43 -05001232 if (xoffset < 0 || yoffset < 0 || width < 0 || height < 0)
Geoff Langd4f180b2013-09-24 13:57:44 -04001233 {
1234 return false;
1235 }
1236
Geoff Lang0d8b7242015-09-09 14:56:53 -04001237 if (CompressedTextureFormatRequiresExactSize(internalFormat))
1238 {
Geoff Lang44ff5a72017-02-03 15:15:43 -05001239 if (xoffset % formatInfo.compressedBlockWidth != 0 ||
Geoff Lang966c9402017-04-18 12:38:27 -04001240 yoffset % formatInfo.compressedBlockHeight != 0)
1241 {
1242 return false;
1243 }
1244
1245 // Allowed to either have data that is a multiple of block size or is smaller than the block
1246 // size but fills the entire mip
1247 bool fillsEntireMip = xoffset == 0 && yoffset == 0 &&
1248 static_cast<size_t>(width) == textureWidth &&
1249 static_cast<size_t>(height) == textureHeight;
1250 bool sizeMultipleOfBlockSize = (width % formatInfo.compressedBlockWidth) == 0 &&
1251 (height % formatInfo.compressedBlockHeight) == 0;
1252 if (!sizeMultipleOfBlockSize && !fillsEntireMip)
Geoff Lang0d8b7242015-09-09 14:56:53 -04001253 {
1254 return false;
1255 }
1256 }
1257
Geoff Langd4f180b2013-09-24 13:57:44 -04001258 return true;
1259}
1260
Geoff Langff5b2d52016-09-07 11:32:23 -04001261bool ValidImageDataSize(ValidationContext *context,
1262 GLenum textureTarget,
1263 GLsizei width,
1264 GLsizei height,
1265 GLsizei depth,
Geoff Langdbcced82017-06-06 15:55:54 -04001266 GLenum format,
Geoff Langff5b2d52016-09-07 11:32:23 -04001267 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04001268 const void *pixels,
Geoff Langff5b2d52016-09-07 11:32:23 -04001269 GLsizei imageSize)
1270{
1271 gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
1272 if (pixelUnpackBuffer == nullptr && imageSize < 0)
1273 {
1274 // Checks are not required
1275 return true;
1276 }
1277
1278 // ...the data would be unpacked from the buffer object such that the memory reads required
1279 // would exceed the data store size.
Geoff Langdbcced82017-06-06 15:55:54 -04001280 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(format, type);
1281 ASSERT(formatInfo.internalFormat != GL_NONE);
Geoff Langff5b2d52016-09-07 11:32:23 -04001282 const gl::Extents size(width, height, depth);
1283 const auto &unpack = context->getGLState().getUnpackState();
1284
1285 bool targetIs3D = textureTarget == GL_TEXTURE_3D || textureTarget == GL_TEXTURE_2D_ARRAY;
1286 auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, unpack, targetIs3D);
1287 if (endByteOrErr.isError())
1288 {
1289 context->handleError(endByteOrErr.getError());
1290 return false;
1291 }
1292
1293 GLuint endByte = endByteOrErr.getResult();
1294
1295 if (pixelUnpackBuffer)
1296 {
1297 CheckedNumeric<size_t> checkedEndByte(endByteOrErr.getResult());
1298 CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels));
1299 checkedEndByte += checkedOffset;
1300
1301 if (!checkedEndByte.IsValid() ||
1302 (checkedEndByte.ValueOrDie() > static_cast<size_t>(pixelUnpackBuffer->getSize())))
1303 {
1304 // Overflow past the end of the buffer
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001305 context->handleError(InvalidOperation());
Geoff Langff5b2d52016-09-07 11:32:23 -04001306 return false;
1307 }
1308 }
1309 else
1310 {
1311 ASSERT(imageSize >= 0);
1312 if (pixels == nullptr && imageSize != 0)
1313 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001314 context->handleError(InvalidOperation()
1315 << "imageSize must be 0 if no texture data is provided.");
Geoff Lang3feb3ff2016-10-26 10:57:45 -04001316 return false;
Geoff Langff5b2d52016-09-07 11:32:23 -04001317 }
1318
Geoff Lang3feb3ff2016-10-26 10:57:45 -04001319 if (pixels != nullptr && endByte > static_cast<GLuint>(imageSize))
Geoff Langff5b2d52016-09-07 11:32:23 -04001320 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001321 context->handleError(InvalidOperation() << "imageSize must be at least " << endByte);
Geoff Langff5b2d52016-09-07 11:32:23 -04001322 return false;
1323 }
1324 }
1325
1326 return true;
1327}
1328
Geoff Lang37dde692014-01-31 16:34:54 -05001329bool ValidQueryType(const Context *context, GLenum queryType)
1330{
He Yunchaoced53ae2016-11-29 15:00:51 +08001331 static_assert(GL_ANY_SAMPLES_PASSED == GL_ANY_SAMPLES_PASSED_EXT,
1332 "GL extension enums not equal.");
1333 static_assert(GL_ANY_SAMPLES_PASSED_CONSERVATIVE == GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
1334 "GL extension enums not equal.");
Geoff Lang37dde692014-01-31 16:34:54 -05001335
1336 switch (queryType)
1337 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001338 case GL_ANY_SAMPLES_PASSED:
1339 case GL_ANY_SAMPLES_PASSED_CONSERVATIVE:
1340 return true;
1341 case GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN:
1342 return (context->getClientMajorVersion() >= 3);
1343 case GL_TIME_ELAPSED_EXT:
1344 return context->getExtensions().disjointTimerQuery;
1345 case GL_COMMANDS_COMPLETED_CHROMIUM:
1346 return context->getExtensions().syncQuery;
1347 default:
1348 return false;
Geoff Lang37dde692014-01-31 16:34:54 -05001349 }
1350}
1351
Geoff Lang2d62ab72017-03-23 16:54:40 -04001352bool ValidateWebGLVertexAttribPointer(ValidationContext *context,
1353 GLenum type,
1354 GLboolean normalized,
1355 GLsizei stride,
Jamie Madill876429b2017-04-20 15:46:24 -04001356 const void *ptr,
Geoff Lang2d62ab72017-03-23 16:54:40 -04001357 bool pureInteger)
1358{
1359 ASSERT(context->getExtensions().webglCompatibility);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001360 // WebGL 1.0 [Section 6.11] Vertex Attribute Data Stride
1361 // The WebGL API supports vertex attribute data strides up to 255 bytes. A call to
1362 // vertexAttribPointer will generate an INVALID_VALUE error if the value for the stride
1363 // parameter exceeds 255.
1364 constexpr GLsizei kMaxWebGLStride = 255;
1365 if (stride > kMaxWebGLStride)
1366 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001367 context->handleError(InvalidValue()
1368 << "Stride is over the maximum stride allowed by WebGL.");
Geoff Lang2d62ab72017-03-23 16:54:40 -04001369 return false;
1370 }
1371
1372 // WebGL 1.0 [Section 6.4] Buffer Offset and Stride Requirements
1373 // The offset arguments to drawElements and vertexAttribPointer, and the stride argument to
1374 // vertexAttribPointer, must be a multiple of the size of the data type passed to the call,
1375 // or an INVALID_OPERATION error is generated.
1376 VertexFormatType internalType = GetVertexFormatType(type, normalized, 1, pureInteger);
1377 size_t typeSize = GetVertexFormatTypeSize(internalType);
1378
1379 ASSERT(isPow2(typeSize) && typeSize > 0);
1380 size_t sizeMask = (typeSize - 1);
1381 if ((reinterpret_cast<intptr_t>(ptr) & sizeMask) != 0)
1382 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001383 ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001384 return false;
1385 }
1386
1387 if ((stride & sizeMask) != 0)
1388 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001389 ANGLE_VALIDATION_ERR(context, InvalidOperation(), StrideMustBeMultipleOfType);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001390 return false;
1391 }
1392
1393 return true;
1394}
1395
Jamie Madillef300b12016-10-07 15:12:09 -04001396Program *GetValidProgram(ValidationContext *context, GLuint id)
Geoff Lang48dcae72014-02-05 16:28:24 -05001397{
He Yunchaoced53ae2016-11-29 15:00:51 +08001398 // ES3 spec (section 2.11.1) -- "Commands that accept shader or program object names will
1399 // generate the error INVALID_VALUE if the provided name is not the name of either a shader
1400 // or program object and INVALID_OPERATION if the provided name identifies an object
1401 // that is not the expected type."
Geoff Lang48dcae72014-02-05 16:28:24 -05001402
Dian Xiang769769a2015-09-09 15:20:08 -07001403 Program *validProgram = context->getProgram(id);
1404
1405 if (!validProgram)
Geoff Lang48dcae72014-02-05 16:28:24 -05001406 {
Dian Xiang769769a2015-09-09 15:20:08 -07001407 if (context->getShader(id))
1408 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001409 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedProgramName);
Dian Xiang769769a2015-09-09 15:20:08 -07001410 }
1411 else
1412 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001413 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidProgramName);
Dian Xiang769769a2015-09-09 15:20:08 -07001414 }
Geoff Lang48dcae72014-02-05 16:28:24 -05001415 }
Dian Xiang769769a2015-09-09 15:20:08 -07001416
1417 return validProgram;
1418}
1419
Jamie Madillef300b12016-10-07 15:12:09 -04001420Shader *GetValidShader(ValidationContext *context, GLuint id)
Dian Xiang769769a2015-09-09 15:20:08 -07001421{
1422 // See ValidProgram for spec details.
1423
1424 Shader *validShader = context->getShader(id);
1425
1426 if (!validShader)
Geoff Lang48dcae72014-02-05 16:28:24 -05001427 {
Dian Xiang769769a2015-09-09 15:20:08 -07001428 if (context->getProgram(id))
1429 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001430 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedShaderName);
Dian Xiang769769a2015-09-09 15:20:08 -07001431 }
1432 else
1433 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001434 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidShaderName);
Dian Xiang769769a2015-09-09 15:20:08 -07001435 }
Geoff Lang48dcae72014-02-05 16:28:24 -05001436 }
Dian Xiang769769a2015-09-09 15:20:08 -07001437
1438 return validShader;
Geoff Lang48dcae72014-02-05 16:28:24 -05001439}
1440
Geoff Langb1196682014-07-23 13:47:29 -04001441bool ValidateAttachmentTarget(gl::Context *context, GLenum attachment)
Jamie Madillb4472272014-07-03 10:38:55 -04001442{
1443 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
1444 {
1445 const unsigned int colorAttachment = (attachment - GL_COLOR_ATTACHMENT0_EXT);
1446
Geoff Langaae65a42014-05-26 12:43:44 -04001447 if (colorAttachment >= context->getCaps().maxColorAttachments)
Jamie Madillb4472272014-07-03 10:38:55 -04001448 {
Martin Radevd178aa42017-07-13 14:03:22 +03001449 context->handleError(
1450 InvalidOperation()
1451 << "attachment index cannot be greater or equal to MAX_COLOR_ATTACHMENTS.");
Geoff Langb1196682014-07-23 13:47:29 -04001452 return false;
Jamie Madillb4472272014-07-03 10:38:55 -04001453 }
1454 }
1455 else
1456 {
1457 switch (attachment)
1458 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001459 case GL_DEPTH_ATTACHMENT:
1460 case GL_STENCIL_ATTACHMENT:
1461 break;
Jamie Madillb4472272014-07-03 10:38:55 -04001462
He Yunchaoced53ae2016-11-29 15:00:51 +08001463 case GL_DEPTH_STENCIL_ATTACHMENT:
1464 if (!context->getExtensions().webglCompatibility &&
1465 context->getClientMajorVersion() < 3)
1466 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001467 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
He Yunchaoced53ae2016-11-29 15:00:51 +08001468 return false;
1469 }
1470 break;
Jamie Madillb4472272014-07-03 10:38:55 -04001471
He Yunchaoced53ae2016-11-29 15:00:51 +08001472 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001473 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
He Yunchaoced53ae2016-11-29 15:00:51 +08001474 return false;
Jamie Madillb4472272014-07-03 10:38:55 -04001475 }
1476 }
1477
1478 return true;
1479}
1480
Jamie Madille8fb6402017-02-14 17:56:40 -05001481bool ValidateRenderbufferStorageParametersBase(ValidationContext *context,
He Yunchaoced53ae2016-11-29 15:00:51 +08001482 GLenum target,
1483 GLsizei samples,
1484 GLenum internalformat,
1485 GLsizei width,
1486 GLsizei height)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001487{
1488 switch (target)
1489 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001490 case GL_RENDERBUFFER:
1491 break;
1492 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001493 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
He Yunchaoced53ae2016-11-29 15:00:51 +08001494 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001495 }
1496
1497 if (width < 0 || height < 0 || samples < 0)
1498 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001499 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidRenderbufferWidthHeight);
Geoff Langb1196682014-07-23 13:47:29 -04001500 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001501 }
1502
Jamie Madill4e0e6f82017-02-17 11:06:03 -05001503 // Hack for the special WebGL 1 "DEPTH_STENCIL" internal format.
1504 GLenum convertedInternalFormat = context->getConvertedRenderbufferFormat(internalformat);
1505
1506 const TextureCaps &formatCaps = context->getTextureCaps().get(convertedInternalFormat);
Geoff Langd87878e2014-09-19 15:42:59 -04001507 if (!formatCaps.renderable)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001508 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001509 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04001510 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001511 }
1512
1513 // ANGLE_framebuffer_multisample does not explicitly state that the internal format must be
1514 // sized but it does state that the format must be in the ES2.0 spec table 4.5 which contains
Corentin Walleze0902642014-11-04 12:32:15 -08001515 // only sized internal formats.
Geoff Langca271392017-04-05 12:30:00 -04001516 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(convertedInternalFormat);
1517 if (formatInfo.internalFormat == GL_NONE)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001518 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001519 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferInternalFormat);
Geoff Langb1196682014-07-23 13:47:29 -04001520 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001521 }
1522
Geoff Langaae65a42014-05-26 12:43:44 -04001523 if (static_cast<GLuint>(std::max(width, height)) > context->getCaps().maxRenderbufferSize)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001524 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001525 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04001526 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001527 }
1528
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001529 GLuint handle = context->getGLState().getRenderbufferId();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001530 if (handle == 0)
1531 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001532 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001533 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001534 }
1535
1536 return true;
1537}
1538
He Yunchaoced53ae2016-11-29 15:00:51 +08001539bool ValidateFramebufferRenderbufferParameters(gl::Context *context,
1540 GLenum target,
1541 GLenum attachment,
1542 GLenum renderbuffertarget,
1543 GLuint renderbuffer)
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001544{
Shannon Woods1da3cf62014-06-27 15:32:23 -04001545 if (!ValidFramebufferTarget(target))
1546 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001547 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04001548 return false;
Shannon Woods1da3cf62014-06-27 15:32:23 -04001549 }
1550
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001551 gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001552
Jamie Madill84115c92015-04-23 15:00:07 -04001553 ASSERT(framebuffer);
1554 if (framebuffer->id() == 0)
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001555 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001556 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001557 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001558 }
1559
Jamie Madillb4472272014-07-03 10:38:55 -04001560 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001561 {
Jamie Madillb4472272014-07-03 10:38:55 -04001562 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001563 }
1564
Jamie Madillab9d82c2014-01-21 16:38:14 -05001565 // [OpenGL ES 2.0.25] Section 4.4.3 page 112
1566 // [OpenGL ES 3.0.2] Section 4.4.2 page 201
1567 // 'renderbuffer' must be either zero or the name of an existing renderbuffer object of
1568 // type 'renderbuffertarget', otherwise an INVALID_OPERATION error is generated.
1569 if (renderbuffer != 0)
1570 {
1571 if (!context->getRenderbuffer(renderbuffer))
1572 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001573 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001574 return false;
Jamie Madillab9d82c2014-01-21 16:38:14 -05001575 }
1576 }
1577
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001578 return true;
1579}
1580
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001581bool ValidateBlitFramebufferParameters(ValidationContext *context,
Jamie Madillc29968b2016-01-20 11:17:23 -05001582 GLint srcX0,
1583 GLint srcY0,
1584 GLint srcX1,
1585 GLint srcY1,
1586 GLint dstX0,
1587 GLint dstY0,
1588 GLint dstX1,
1589 GLint dstY1,
1590 GLbitfield mask,
1591 GLenum filter)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001592{
1593 switch (filter)
1594 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001595 case GL_NEAREST:
1596 break;
1597 case GL_LINEAR:
1598 break;
1599 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001600 context->handleError(InvalidEnum());
He Yunchaoced53ae2016-11-29 15:00:51 +08001601 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001602 }
1603
1604 if ((mask & ~(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT | GL_DEPTH_BUFFER_BIT)) != 0)
1605 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001606 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04001607 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001608 }
1609
1610 if (mask == 0)
1611 {
1612 // ES3.0 spec, section 4.3.2 specifies that a mask of zero is valid and no
1613 // buffers are copied.
1614 return false;
1615 }
1616
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001617 // ES3.0 spec, section 4.3.2 states that linear filtering is only available for the
1618 // color buffer, leaving only nearest being unfiltered from above
1619 if ((mask & ~GL_COLOR_BUFFER_BIT) != 0 && filter != GL_NEAREST)
1620 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001621 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001622 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001623 }
1624
Jamie Madill51f40ec2016-06-15 14:06:00 -04001625 const auto &glState = context->getGLState();
1626 gl::Framebuffer *readFramebuffer = glState.getReadFramebuffer();
1627 gl::Framebuffer *drawFramebuffer = glState.getDrawFramebuffer();
Jamie Madill48faf802014-11-06 15:27:22 -05001628
1629 if (!readFramebuffer || !drawFramebuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001630 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001631 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001632 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001633 }
1634
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001635 if (readFramebuffer->id() == drawFramebuffer->id())
1636 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001637 context->handleError(InvalidOperation());
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001638 return false;
1639 }
1640
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001641 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill48faf802014-11-06 15:27:22 -05001642 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001643 context->handleError(InvalidFramebufferOperation());
Jamie Madill48faf802014-11-06 15:27:22 -05001644 return false;
1645 }
1646
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001647 if (drawFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill48faf802014-11-06 15:27:22 -05001648 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001649 context->handleError(InvalidFramebufferOperation());
Jamie Madill48faf802014-11-06 15:27:22 -05001650 return false;
1651 }
1652
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001653 if (drawFramebuffer->getSamples(context) != 0)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001654 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001655 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001656 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001657 }
1658
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001659 bool sameBounds = srcX0 == dstX0 && srcY0 == dstY0 && srcX1 == dstX1 && srcY1 == dstY1;
1660
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001661 if (mask & GL_COLOR_BUFFER_BIT)
1662 {
Jamie Madillb6bda4a2015-04-20 12:53:26 -04001663 const gl::FramebufferAttachment *readColorBuffer = readFramebuffer->getReadColorbuffer();
Jamie Madill6163c752015-12-07 16:32:59 -05001664 const Extensions &extensions = context->getExtensions();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001665
He Yunchao66a41a22016-12-15 16:45:05 +08001666 if (readColorBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001667 {
Jamie Madilla3944d42016-07-22 22:13:26 -04001668 const Format &readFormat = readColorBuffer->getFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001669
Geoff Langa15472a2015-08-11 11:48:03 -04001670 for (size_t drawbufferIdx = 0;
1671 drawbufferIdx < drawFramebuffer->getDrawbufferStateCount(); ++drawbufferIdx)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001672 {
Geoff Langa15472a2015-08-11 11:48:03 -04001673 const FramebufferAttachment *attachment =
1674 drawFramebuffer->getDrawBuffer(drawbufferIdx);
1675 if (attachment)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001676 {
Jamie Madilla3944d42016-07-22 22:13:26 -04001677 const Format &drawFormat = attachment->getFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001678
Geoff Langb2f3d052013-08-13 12:49:27 -04001679 // The GL ES 3.0.2 spec (pg 193) states that:
1680 // 1) If the read buffer is fixed point format, the draw buffer must be as well
He Yunchaoced53ae2016-11-29 15:00:51 +08001681 // 2) If the read buffer is an unsigned integer format, the draw buffer must be
1682 // as well
1683 // 3) If the read buffer is a signed integer format, the draw buffer must be as
1684 // well
Jamie Madill6163c752015-12-07 16:32:59 -05001685 // Changes with EXT_color_buffer_float:
1686 // Case 1) is changed to fixed point OR floating point
Jamie Madilla3944d42016-07-22 22:13:26 -04001687 GLenum readComponentType = readFormat.info->componentType;
1688 GLenum drawComponentType = drawFormat.info->componentType;
He Yunchaoced53ae2016-11-29 15:00:51 +08001689 bool readFixedPoint = (readComponentType == GL_UNSIGNED_NORMALIZED ||
Jamie Madill6163c752015-12-07 16:32:59 -05001690 readComponentType == GL_SIGNED_NORMALIZED);
1691 bool drawFixedPoint = (drawComponentType == GL_UNSIGNED_NORMALIZED ||
1692 drawComponentType == GL_SIGNED_NORMALIZED);
1693
1694 if (extensions.colorBufferFloat)
1695 {
1696 bool readFixedOrFloat = (readFixedPoint || readComponentType == GL_FLOAT);
1697 bool drawFixedOrFloat = (drawFixedPoint || drawComponentType == GL_FLOAT);
1698
1699 if (readFixedOrFloat != drawFixedOrFloat)
1700 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001701 context->handleError(InvalidOperation()
1702 << "If the read buffer contains fixed-point or "
1703 "floating-point values, the draw buffer must "
1704 "as well.");
Jamie Madill6163c752015-12-07 16:32:59 -05001705 return false;
1706 }
1707 }
1708 else if (readFixedPoint != drawFixedPoint)
1709 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001710 context->handleError(InvalidOperation()
1711 << "If the read buffer contains fixed-point values, "
1712 "the draw buffer must as well.");
Jamie Madill6163c752015-12-07 16:32:59 -05001713 return false;
1714 }
1715
1716 if (readComponentType == GL_UNSIGNED_INT &&
1717 drawComponentType != GL_UNSIGNED_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001718 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001719 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001720 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001721 }
1722
Jamie Madill6163c752015-12-07 16:32:59 -05001723 if (readComponentType == GL_INT && drawComponentType != GL_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001724 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001725 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001726 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001727 }
1728
Jamie Madilla3944d42016-07-22 22:13:26 -04001729 if (readColorBuffer->getSamples() > 0 &&
Kenneth Russell69382852017-07-21 16:38:44 -04001730 (!Format::EquivalentForBlit(readFormat, drawFormat) || !sameBounds))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001731 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001732 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001733 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001734 }
Geoff Lange4915782017-04-12 15:19:07 -04001735
1736 if (context->getExtensions().webglCompatibility &&
1737 *readColorBuffer == *attachment)
1738 {
1739 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001740 InvalidOperation()
1741 << "Read and write color attachments cannot be the same image.");
Geoff Lange4915782017-04-12 15:19:07 -04001742 return false;
1743 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001744 }
1745 }
1746
Jamie Madilla3944d42016-07-22 22:13:26 -04001747 if ((readFormat.info->componentType == GL_INT ||
1748 readFormat.info->componentType == GL_UNSIGNED_INT) &&
1749 filter == GL_LINEAR)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001750 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001751 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001752 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001753 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001754 }
He Yunchao66a41a22016-12-15 16:45:05 +08001755 // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment
1756 // In OpenGL ES it is undefined what happens when an operation tries to blit from a missing
1757 // attachment and WebGL defines it to be an error. We do the check unconditionally as the
1758 // situation is an application error that would lead to a crash in ANGLE.
1759 else if (drawFramebuffer->hasEnabledDrawBuffer())
1760 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001761 context->handleError(
1762 InvalidOperation()
1763 << "Attempt to read from a missing color attachment of a complete framebuffer.");
He Yunchao66a41a22016-12-15 16:45:05 +08001764 return false;
1765 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001766 }
1767
He Yunchaoced53ae2016-11-29 15:00:51 +08001768 GLenum masks[] = {GL_DEPTH_BUFFER_BIT, GL_STENCIL_BUFFER_BIT};
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001769 GLenum attachments[] = {GL_DEPTH_ATTACHMENT, GL_STENCIL_ATTACHMENT};
1770 for (size_t i = 0; i < 2; i++)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001771 {
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001772 if (mask & masks[i])
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001773 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001774 const gl::FramebufferAttachment *readBuffer =
1775 readFramebuffer->getAttachment(attachments[i]);
1776 const gl::FramebufferAttachment *drawBuffer =
1777 drawFramebuffer->getAttachment(attachments[i]);
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001778
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001779 if (readBuffer && drawBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001780 {
Kenneth Russell69382852017-07-21 16:38:44 -04001781 if (!Format::EquivalentForBlit(readBuffer->getFormat(), drawBuffer->getFormat()))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001782 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001783 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001784 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001785 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001786
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001787 if (readBuffer->getSamples() > 0 && !sameBounds)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001788 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001789 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001790 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001791 }
Geoff Lange4915782017-04-12 15:19:07 -04001792
1793 if (context->getExtensions().webglCompatibility && *readBuffer == *drawBuffer)
1794 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001795 context->handleError(
1796 InvalidOperation()
1797 << "Read and write depth stencil attachments cannot be the same image.");
Geoff Lange4915782017-04-12 15:19:07 -04001798 return false;
1799 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001800 }
He Yunchao66a41a22016-12-15 16:45:05 +08001801 // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment
1802 else if (drawBuffer)
1803 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001804 context->handleError(InvalidOperation() << "Attempt to read from a missing "
1805 "depth/stencil attachment of a "
1806 "complete framebuffer.");
He Yunchao66a41a22016-12-15 16:45:05 +08001807 return false;
1808 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001809 }
1810 }
1811
1812 return true;
1813}
1814
Jamie Madill4928b7c2017-06-20 12:57:39 -04001815bool ValidateReadPixelsRobustANGLE(Context *context,
Geoff Lang62fce5b2016-09-30 10:46:35 -04001816 GLint x,
1817 GLint y,
1818 GLsizei width,
1819 GLsizei height,
1820 GLenum format,
1821 GLenum type,
1822 GLsizei bufSize,
1823 GLsizei *length,
Geoff Lange93daba2017-03-30 13:54:40 -04001824 GLsizei *columns,
1825 GLsizei *rows,
Jamie Madill876429b2017-04-20 15:46:24 -04001826 void *pixels)
Geoff Lang62fce5b2016-09-30 10:46:35 -04001827{
1828 if (!ValidateRobustEntryPoint(context, bufSize))
Jamie Madillc29968b2016-01-20 11:17:23 -05001829 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001830 return false;
1831 }
1832
Geoff Lang62fce5b2016-09-30 10:46:35 -04001833 if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length,
Geoff Lange93daba2017-03-30 13:54:40 -04001834 columns, rows, pixels))
Jamie Madill26e91952014-03-05 15:01:27 -05001835 {
Geoff Langb1196682014-07-23 13:47:29 -04001836 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001837 }
1838
Geoff Lang62fce5b2016-09-30 10:46:35 -04001839 if (!ValidateRobustBufferSize(context, bufSize, *length))
Jamie Madill26e91952014-03-05 15:01:27 -05001840 {
Geoff Langb1196682014-07-23 13:47:29 -04001841 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001842 }
1843
Jamie Madillc29968b2016-01-20 11:17:23 -05001844 return true;
1845}
1846
1847bool ValidateReadnPixelsEXT(Context *context,
1848 GLint x,
1849 GLint y,
1850 GLsizei width,
1851 GLsizei height,
1852 GLenum format,
1853 GLenum type,
1854 GLsizei bufSize,
Jamie Madill876429b2017-04-20 15:46:24 -04001855 void *pixels)
Jamie Madillc29968b2016-01-20 11:17:23 -05001856{
1857 if (bufSize < 0)
1858 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001859 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Jamie Madillc29968b2016-01-20 11:17:23 -05001860 return false;
1861 }
1862
Geoff Lang62fce5b2016-09-30 10:46:35 -04001863 return ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, nullptr,
Geoff Lange93daba2017-03-30 13:54:40 -04001864 nullptr, nullptr, pixels);
Geoff Lang62fce5b2016-09-30 10:46:35 -04001865}
Jamie Madill26e91952014-03-05 15:01:27 -05001866
Jamie Madill4928b7c2017-06-20 12:57:39 -04001867bool ValidateReadnPixelsRobustANGLE(Context *context,
Geoff Lang62fce5b2016-09-30 10:46:35 -04001868 GLint x,
1869 GLint y,
1870 GLsizei width,
1871 GLsizei height,
1872 GLenum format,
1873 GLenum type,
1874 GLsizei bufSize,
1875 GLsizei *length,
Geoff Lange93daba2017-03-30 13:54:40 -04001876 GLsizei *columns,
1877 GLsizei *rows,
Jamie Madill876429b2017-04-20 15:46:24 -04001878 void *data)
Geoff Lang62fce5b2016-09-30 10:46:35 -04001879{
1880 if (!ValidateRobustEntryPoint(context, bufSize))
Jamie Madille2e406c2016-06-02 13:04:10 -04001881 {
Jamie Madille2e406c2016-06-02 13:04:10 -04001882 return false;
1883 }
1884
Geoff Lange93daba2017-03-30 13:54:40 -04001885 if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length,
1886 columns, rows, data))
Jamie Madille2e406c2016-06-02 13:04:10 -04001887 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001888 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001889 }
1890
Geoff Lang62fce5b2016-09-30 10:46:35 -04001891 if (!ValidateRobustBufferSize(context, bufSize, *length))
1892 {
1893 return false;
1894 }
1895
1896 return true;
Jamie Madill26e91952014-03-05 15:01:27 -05001897}
1898
Olli Etuaho41997e72016-03-10 13:38:39 +02001899bool ValidateGenQueriesEXT(gl::Context *context, GLsizei n)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001900{
1901 if (!context->getExtensions().occlusionQueryBoolean &&
1902 !context->getExtensions().disjointTimerQuery)
1903 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001904 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001905 return false;
1906 }
1907
Olli Etuaho41997e72016-03-10 13:38:39 +02001908 return ValidateGenOrDelete(context, n);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001909}
1910
Olli Etuaho41997e72016-03-10 13:38:39 +02001911bool ValidateDeleteQueriesEXT(gl::Context *context, GLsizei n)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001912{
1913 if (!context->getExtensions().occlusionQueryBoolean &&
1914 !context->getExtensions().disjointTimerQuery)
1915 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001916 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001917 return false;
1918 }
1919
Olli Etuaho41997e72016-03-10 13:38:39 +02001920 return ValidateGenOrDelete(context, n);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001921}
1922
1923bool ValidateBeginQueryBase(gl::Context *context, GLenum target, GLuint id)
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001924{
1925 if (!ValidQueryType(context, target))
1926 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001927 context->handleError(InvalidEnum() << "Invalid query target");
Geoff Langb1196682014-07-23 13:47:29 -04001928 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001929 }
1930
1931 if (id == 0)
1932 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001933 context->handleError(InvalidOperation() << "Query id is 0");
Geoff Langb1196682014-07-23 13:47:29 -04001934 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001935 }
1936
1937 // From EXT_occlusion_query_boolean: If BeginQueryEXT is called with an <id>
1938 // of zero, if the active query object name for <target> is non-zero (for the
1939 // targets ANY_SAMPLES_PASSED_EXT and ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, if
1940 // the active query for either target is non-zero), if <id> is the name of an
1941 // existing query object whose type does not match <target>, or if <id> is the
1942 // active query object name for any query type, the error INVALID_OPERATION is
1943 // generated.
1944
1945 // Ensure no other queries are active
1946 // NOTE: If other queries than occlusion are supported, we will need to check
1947 // separately that:
1948 // a) The query ID passed is not the current active query for any target/type
1949 // b) There are no active queries for the requested target (and in the case
1950 // of GL_ANY_SAMPLES_PASSED_EXT and GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
1951 // no query may be active for either if glBeginQuery targets either.
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001952
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001953 if (context->getGLState().isQueryActive(target))
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001954 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001955 context->handleError(InvalidOperation() << "Other query is active");
Geoff Langb1196682014-07-23 13:47:29 -04001956 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001957 }
1958
1959 Query *queryObject = context->getQuery(id, true, target);
1960
1961 // check that name was obtained with glGenQueries
1962 if (!queryObject)
1963 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001964 context->handleError(InvalidOperation() << "Invalid query id");
Geoff Langb1196682014-07-23 13:47:29 -04001965 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001966 }
1967
1968 // check for type mismatch
1969 if (queryObject->getType() != target)
1970 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001971 context->handleError(InvalidOperation() << "Query type does not match target");
Geoff Langb1196682014-07-23 13:47:29 -04001972 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001973 }
1974
1975 return true;
1976}
1977
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001978bool ValidateBeginQueryEXT(gl::Context *context, GLenum target, GLuint id)
1979{
1980 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001981 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001982 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001983 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001984 return false;
1985 }
1986
1987 return ValidateBeginQueryBase(context, target, id);
1988}
1989
1990bool ValidateEndQueryBase(gl::Context *context, GLenum target)
Jamie Madill45c785d2014-05-13 14:09:34 -04001991{
1992 if (!ValidQueryType(context, target))
1993 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001994 context->handleError(InvalidEnum() << "Invalid query target");
Geoff Langb1196682014-07-23 13:47:29 -04001995 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04001996 }
1997
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001998 const Query *queryObject = context->getGLState().getActiveQuery(target);
Jamie Madill45c785d2014-05-13 14:09:34 -04001999
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002000 if (queryObject == nullptr)
Jamie Madill45c785d2014-05-13 14:09:34 -04002001 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002002 context->handleError(InvalidOperation() << "Query target not active");
Geoff Langb1196682014-07-23 13:47:29 -04002003 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04002004 }
2005
Jamie Madill45c785d2014-05-13 14:09:34 -04002006 return true;
2007}
2008
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002009bool ValidateEndQueryEXT(gl::Context *context, GLenum target)
2010{
2011 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04002012 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002013 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002014 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002015 return false;
2016 }
2017
2018 return ValidateEndQueryBase(context, target);
2019}
2020
2021bool ValidateQueryCounterEXT(Context *context, GLuint id, GLenum target)
2022{
2023 if (!context->getExtensions().disjointTimerQuery)
2024 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002025 context->handleError(InvalidOperation() << "Disjoint timer query not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002026 return false;
2027 }
2028
2029 if (target != GL_TIMESTAMP_EXT)
2030 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002031 context->handleError(InvalidEnum() << "Invalid query target");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002032 return false;
2033 }
2034
2035 Query *queryObject = context->getQuery(id, true, target);
2036 if (queryObject == nullptr)
2037 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002038 context->handleError(InvalidOperation() << "Invalid query id");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002039 return false;
2040 }
2041
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002042 if (context->getGLState().isQueryActive(queryObject))
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002043 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002044 context->handleError(InvalidOperation() << "Query is active");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002045 return false;
2046 }
2047
2048 return true;
2049}
2050
Geoff Lang2186c382016-10-14 10:54:54 -04002051bool ValidateGetQueryivBase(Context *context, GLenum target, GLenum pname, GLsizei *numParams)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002052{
Geoff Lang2186c382016-10-14 10:54:54 -04002053 if (numParams)
2054 {
2055 *numParams = 0;
2056 }
2057
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002058 if (!ValidQueryType(context, target) && target != GL_TIMESTAMP_EXT)
2059 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002060 context->handleError(InvalidEnum() << "Invalid query type");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002061 return false;
2062 }
2063
2064 switch (pname)
2065 {
2066 case GL_CURRENT_QUERY_EXT:
2067 if (target == GL_TIMESTAMP_EXT)
2068 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002069 context->handleError(InvalidEnum() << "Cannot use current query for timestamp");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002070 return false;
2071 }
2072 break;
2073 case GL_QUERY_COUNTER_BITS_EXT:
2074 if (!context->getExtensions().disjointTimerQuery ||
2075 (target != GL_TIMESTAMP_EXT && target != GL_TIME_ELAPSED_EXT))
2076 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002077 context->handleError(InvalidEnum() << "Invalid pname");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002078 return false;
2079 }
2080 break;
2081 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002082 context->handleError(InvalidEnum() << "Invalid pname");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002083 return false;
2084 }
2085
Geoff Lang2186c382016-10-14 10:54:54 -04002086 if (numParams)
2087 {
2088 // All queries return only one value
2089 *numParams = 1;
2090 }
2091
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002092 return true;
2093}
2094
2095bool ValidateGetQueryivEXT(Context *context, GLenum target, GLenum pname, GLint *params)
2096{
2097 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04002098 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002099 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002100 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002101 return false;
2102 }
2103
Geoff Lang2186c382016-10-14 10:54:54 -04002104 return ValidateGetQueryivBase(context, target, pname, nullptr);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002105}
2106
Geoff Lang2186c382016-10-14 10:54:54 -04002107bool ValidateGetQueryivRobustANGLE(Context *context,
2108 GLenum target,
2109 GLenum pname,
2110 GLsizei bufSize,
2111 GLsizei *length,
2112 GLint *params)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002113{
Geoff Lang2186c382016-10-14 10:54:54 -04002114 if (!ValidateRobustEntryPoint(context, bufSize))
2115 {
2116 return false;
2117 }
2118
2119 if (!ValidateGetQueryivBase(context, target, pname, length))
2120 {
2121 return false;
2122 }
2123
2124 if (!ValidateRobustBufferSize(context, bufSize, *length))
2125 {
2126 return false;
2127 }
2128
2129 return true;
2130}
2131
2132bool ValidateGetQueryObjectValueBase(Context *context, GLuint id, GLenum pname, GLsizei *numParams)
2133{
2134 if (numParams)
2135 {
2136 *numParams = 0;
2137 }
2138
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002139 Query *queryObject = context->getQuery(id, false, GL_NONE);
2140
2141 if (!queryObject)
2142 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002143 context->handleError(InvalidOperation() << "Query does not exist");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002144 return false;
2145 }
2146
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002147 if (context->getGLState().isQueryActive(queryObject))
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002148 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002149 context->handleError(InvalidOperation() << "Query currently active");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002150 return false;
2151 }
2152
2153 switch (pname)
2154 {
2155 case GL_QUERY_RESULT_EXT:
2156 case GL_QUERY_RESULT_AVAILABLE_EXT:
2157 break;
2158
2159 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002160 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002161 return false;
2162 }
2163
Geoff Lang2186c382016-10-14 10:54:54 -04002164 if (numParams)
2165 {
2166 *numParams = 1;
2167 }
2168
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002169 return true;
2170}
2171
2172bool ValidateGetQueryObjectivEXT(Context *context, GLuint id, GLenum pname, GLint *params)
2173{
2174 if (!context->getExtensions().disjointTimerQuery)
2175 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002176 context->handleError(InvalidOperation() << "Timer query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002177 return false;
2178 }
Geoff Lang2186c382016-10-14 10:54:54 -04002179 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2180}
2181
2182bool ValidateGetQueryObjectivRobustANGLE(Context *context,
2183 GLuint id,
2184 GLenum pname,
2185 GLsizei bufSize,
2186 GLsizei *length,
2187 GLint *params)
2188{
2189 if (!context->getExtensions().disjointTimerQuery)
2190 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002191 context->handleError(InvalidOperation() << "Timer query extension not enabled");
Geoff Lang2186c382016-10-14 10:54:54 -04002192 return false;
2193 }
2194
2195 if (!ValidateRobustEntryPoint(context, bufSize))
2196 {
2197 return false;
2198 }
2199
2200 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2201 {
2202 return false;
2203 }
2204
2205 if (!ValidateRobustBufferSize(context, bufSize, *length))
2206 {
2207 return false;
2208 }
2209
2210 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002211}
2212
2213bool ValidateGetQueryObjectuivEXT(Context *context, GLuint id, GLenum pname, GLuint *params)
2214{
2215 if (!context->getExtensions().disjointTimerQuery &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04002216 !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002217 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002218 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002219 return false;
2220 }
Geoff Lang2186c382016-10-14 10:54:54 -04002221 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2222}
2223
2224bool ValidateGetQueryObjectuivRobustANGLE(Context *context,
2225 GLuint id,
2226 GLenum pname,
2227 GLsizei bufSize,
2228 GLsizei *length,
2229 GLuint *params)
2230{
2231 if (!context->getExtensions().disjointTimerQuery &&
2232 !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery)
2233 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002234 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002235 return false;
2236 }
2237
2238 if (!ValidateRobustEntryPoint(context, bufSize))
2239 {
2240 return false;
2241 }
2242
2243 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2244 {
2245 return false;
2246 }
2247
2248 if (!ValidateRobustBufferSize(context, bufSize, *length))
2249 {
2250 return false;
2251 }
2252
2253 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002254}
2255
2256bool ValidateGetQueryObjecti64vEXT(Context *context, GLuint id, GLenum pname, GLint64 *params)
2257{
2258 if (!context->getExtensions().disjointTimerQuery)
2259 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002260 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002261 return false;
2262 }
Geoff Lang2186c382016-10-14 10:54:54 -04002263 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2264}
2265
2266bool ValidateGetQueryObjecti64vRobustANGLE(Context *context,
2267 GLuint id,
2268 GLenum pname,
2269 GLsizei bufSize,
2270 GLsizei *length,
2271 GLint64 *params)
2272{
2273 if (!context->getExtensions().disjointTimerQuery)
2274 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002275 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002276 return false;
2277 }
2278
2279 if (!ValidateRobustEntryPoint(context, bufSize))
2280 {
2281 return false;
2282 }
2283
2284 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2285 {
2286 return false;
2287 }
2288
2289 if (!ValidateRobustBufferSize(context, bufSize, *length))
2290 {
2291 return false;
2292 }
2293
2294 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002295}
2296
2297bool ValidateGetQueryObjectui64vEXT(Context *context, GLuint id, GLenum pname, GLuint64 *params)
2298{
2299 if (!context->getExtensions().disjointTimerQuery)
2300 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002301 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002302 return false;
2303 }
Geoff Lang2186c382016-10-14 10:54:54 -04002304 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2305}
2306
2307bool ValidateGetQueryObjectui64vRobustANGLE(Context *context,
2308 GLuint id,
2309 GLenum pname,
2310 GLsizei bufSize,
2311 GLsizei *length,
2312 GLuint64 *params)
2313{
2314 if (!context->getExtensions().disjointTimerQuery)
2315 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002316 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002317 return false;
2318 }
2319
2320 if (!ValidateRobustEntryPoint(context, bufSize))
2321 {
2322 return false;
2323 }
2324
2325 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2326 {
2327 return false;
2328 }
2329
2330 if (!ValidateRobustBufferSize(context, bufSize, *length))
2331 {
2332 return false;
2333 }
2334
2335 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002336}
2337
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002338bool ValidateProgramUniform(gl::Context *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002339 GLenum valueType,
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002340 GLuint program,
2341 GLint location,
2342 GLsizei count)
2343{
2344 // Check for ES31 program uniform entry points
2345 if (context->getClientVersion() < Version(3, 1))
2346 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002347 context->handleError(InvalidOperation());
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002348 return false;
2349 }
2350
2351 const LinkedUniform *uniform = nullptr;
2352 gl::Program *programObject = GetValidProgram(context, program);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002353 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2354 ValidateUniformValue(context, valueType, uniform->type);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002355}
2356
Frank Henigmana98a6472017-02-02 21:38:32 -05002357bool ValidateProgramUniform1iv(gl::Context *context,
2358 GLuint program,
2359 GLint location,
2360 GLsizei count,
2361 const GLint *value)
2362{
2363 // Check for ES31 program uniform entry points
2364 if (context->getClientVersion() < Version(3, 1))
2365 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002366 context->handleError(InvalidOperation());
Frank Henigmana98a6472017-02-02 21:38:32 -05002367 return false;
2368 }
2369
2370 const LinkedUniform *uniform = nullptr;
2371 gl::Program *programObject = GetValidProgram(context, program);
2372 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2373 ValidateUniform1ivValue(context, uniform->type, count, value);
2374}
2375
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002376bool ValidateProgramUniformMatrix(gl::Context *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002377 GLenum valueType,
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002378 GLuint program,
2379 GLint location,
2380 GLsizei count,
2381 GLboolean transpose)
2382{
2383 // Check for ES31 program uniform entry points
2384 if (context->getClientVersion() < Version(3, 1))
2385 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002386 context->handleError(InvalidOperation());
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002387 return false;
2388 }
2389
2390 const LinkedUniform *uniform = nullptr;
2391 gl::Program *programObject = GetValidProgram(context, program);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002392 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2393 ValidateUniformMatrixValue(context, valueType, uniform->type);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002394}
2395
Jamie Madillc1d770e2017-04-13 17:31:24 -04002396bool ValidateUniform(ValidationContext *context, GLenum valueType, GLint location, GLsizei count)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002397{
2398 // Check for ES3 uniform entry points
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002399 if (VariableComponentType(valueType) == GL_UNSIGNED_INT && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002400 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002401 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002402 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002403 }
2404
Jamie Madill62d31cb2015-09-11 13:25:51 -04002405 const LinkedUniform *uniform = nullptr;
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002406 gl::Program *programObject = context->getGLState().getProgram();
2407 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2408 ValidateUniformValue(context, valueType, uniform->type);
Jamie Madillaa981bd2014-05-20 10:55:55 -04002409}
2410
Jamie Madillbe849e42017-05-02 15:49:00 -04002411bool ValidateUniform1iv(ValidationContext *context,
2412 GLint location,
2413 GLsizei count,
2414 const GLint *value)
Frank Henigmana98a6472017-02-02 21:38:32 -05002415{
2416 const LinkedUniform *uniform = nullptr;
2417 gl::Program *programObject = context->getGLState().getProgram();
2418 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2419 ValidateUniform1ivValue(context, uniform->type, count, value);
2420}
2421
Jamie Madillc1d770e2017-04-13 17:31:24 -04002422bool ValidateUniformMatrix(ValidationContext *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002423 GLenum valueType,
He Yunchaoced53ae2016-11-29 15:00:51 +08002424 GLint location,
2425 GLsizei count,
Jamie Madillaa981bd2014-05-20 10:55:55 -04002426 GLboolean transpose)
2427{
2428 // Check for ES3 uniform entry points
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002429 int rows = VariableRowCount(valueType);
2430 int cols = VariableColumnCount(valueType);
Martin Radev1be913c2016-07-11 17:59:16 +03002431 if (rows != cols && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002432 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002433 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002434 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002435 }
2436
Martin Radev1be913c2016-07-11 17:59:16 +03002437 if (transpose != GL_FALSE && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002438 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002439 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002440 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002441 }
2442
Jamie Madill62d31cb2015-09-11 13:25:51 -04002443 const LinkedUniform *uniform = nullptr;
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002444 gl::Program *programObject = context->getGLState().getProgram();
2445 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2446 ValidateUniformMatrixValue(context, valueType, uniform->type);
Jamie Madillaa981bd2014-05-20 10:55:55 -04002447}
2448
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002449bool ValidateStateQuery(ValidationContext *context,
2450 GLenum pname,
2451 GLenum *nativeType,
2452 unsigned int *numParams)
Jamie Madill893ab082014-05-16 16:56:10 -04002453{
2454 if (!context->getQueryParameterInfo(pname, nativeType, numParams))
2455 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002456 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04002457 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002458 }
2459
Jamie Madill0af26e12015-03-05 19:54:33 -05002460 const Caps &caps = context->getCaps();
2461
Jamie Madill893ab082014-05-16 16:56:10 -04002462 if (pname >= GL_DRAW_BUFFER0 && pname <= GL_DRAW_BUFFER15)
2463 {
2464 unsigned int colorAttachment = (pname - GL_DRAW_BUFFER0);
2465
Jamie Madill0af26e12015-03-05 19:54:33 -05002466 if (colorAttachment >= caps.maxDrawBuffers)
Jamie Madill893ab082014-05-16 16:56:10 -04002467 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002468 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002469 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002470 }
2471 }
2472
2473 switch (pname)
2474 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002475 case GL_TEXTURE_BINDING_2D:
2476 case GL_TEXTURE_BINDING_CUBE_MAP:
2477 case GL_TEXTURE_BINDING_3D:
2478 case GL_TEXTURE_BINDING_2D_ARRAY:
JiangYizhou24fe74c2017-07-06 16:56:50 +08002479 case GL_TEXTURE_BINDING_2D_MULTISAMPLE:
He Yunchaoced53ae2016-11-29 15:00:51 +08002480 break;
2481 case GL_TEXTURE_BINDING_EXTERNAL_OES:
2482 if (!context->getExtensions().eglStreamConsumerExternal &&
2483 !context->getExtensions().eglImageExternal)
2484 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002485 context->handleError(InvalidEnum() << "Neither NV_EGL_stream_consumer_external "
2486 "nor GL_OES_EGL_image_external "
2487 "extensions enabled");
He Yunchaoced53ae2016-11-29 15:00:51 +08002488 return false;
2489 }
2490 break;
Jamie Madill893ab082014-05-16 16:56:10 -04002491
He Yunchaoced53ae2016-11-29 15:00:51 +08002492 case GL_IMPLEMENTATION_COLOR_READ_TYPE:
2493 case GL_IMPLEMENTATION_COLOR_READ_FORMAT:
Jamie Madill893ab082014-05-16 16:56:10 -04002494 {
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002495 if (context->getGLState().getReadFramebuffer()->checkStatus(context) !=
2496 GL_FRAMEBUFFER_COMPLETE)
Jamie Madill893ab082014-05-16 16:56:10 -04002497 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002498 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002499 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002500 }
2501
Jamie Madill51f40ec2016-06-15 14:06:00 -04002502 const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer();
2503 ASSERT(framebuffer);
Martin Radev138064f2016-07-15 12:03:41 +03002504
2505 if (framebuffer->getReadBufferState() == GL_NONE)
2506 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002507 context->handleError(InvalidOperation() << "Read buffer is GL_NONE");
Martin Radev138064f2016-07-15 12:03:41 +03002508 return false;
2509 }
2510
Jamie Madillb6bda4a2015-04-20 12:53:26 -04002511 const FramebufferAttachment *attachment = framebuffer->getReadColorbuffer();
Jamie Madill3c7fa222014-06-05 13:08:51 -04002512 if (!attachment)
Jamie Madill893ab082014-05-16 16:56:10 -04002513 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002514 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002515 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002516 }
2517 }
2518 break;
2519
He Yunchaoced53ae2016-11-29 15:00:51 +08002520 default:
2521 break;
Jamie Madill893ab082014-05-16 16:56:10 -04002522 }
2523
2524 // pname is valid, but there are no parameters to return
Geoff Langff5b2d52016-09-07 11:32:23 -04002525 if (*numParams == 0)
2526 {
2527 return false;
2528 }
2529
2530 return true;
2531}
2532
2533bool ValidateRobustStateQuery(ValidationContext *context,
2534 GLenum pname,
2535 GLsizei bufSize,
2536 GLenum *nativeType,
2537 unsigned int *numParams)
2538{
2539 if (!ValidateRobustEntryPoint(context, bufSize))
2540 {
2541 return false;
2542 }
2543
2544 if (!ValidateStateQuery(context, pname, nativeType, numParams))
2545 {
2546 return false;
2547 }
2548
2549 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
Jamie Madill893ab082014-05-16 16:56:10 -04002550 {
2551 return false;
2552 }
2553
2554 return true;
2555}
2556
Jamie Madillc29968b2016-01-20 11:17:23 -05002557bool ValidateCopyTexImageParametersBase(ValidationContext *context,
2558 GLenum target,
2559 GLint level,
2560 GLenum internalformat,
2561 bool isSubImage,
2562 GLint xoffset,
2563 GLint yoffset,
2564 GLint zoffset,
2565 GLint x,
2566 GLint y,
2567 GLsizei width,
2568 GLsizei height,
2569 GLint border,
Jamie Madill0c8abca2016-07-22 20:21:26 -04002570 Format *textureFormatOut)
Jamie Madill560a8d82014-05-21 13:06:20 -04002571{
Brandon Jones6cad5662017-06-14 13:25:13 -07002572 if (xoffset < 0 || yoffset < 0 || zoffset < 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04002573 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002574 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
2575 return false;
2576 }
2577
2578 if (width < 0 || height < 0)
2579 {
2580 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Geoff Langb1196682014-07-23 13:47:29 -04002581 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002582 }
2583
He Yunchaoced53ae2016-11-29 15:00:51 +08002584 if (std::numeric_limits<GLsizei>::max() - xoffset < width ||
2585 std::numeric_limits<GLsizei>::max() - yoffset < height)
Jamie Madill560a8d82014-05-21 13:06:20 -04002586 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002587 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002588 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002589 }
2590
2591 if (border != 0)
2592 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002593 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidBorder);
Geoff Langb1196682014-07-23 13:47:29 -04002594 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002595 }
2596
2597 if (!ValidMipLevel(context, target, level))
2598 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002599 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Geoff Langb1196682014-07-23 13:47:29 -04002600 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002601 }
2602
Jamie Madill51f40ec2016-06-15 14:06:00 -04002603 const auto &state = context->getGLState();
2604 auto readFramebuffer = state.getReadFramebuffer();
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002605 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill560a8d82014-05-21 13:06:20 -04002606 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002607 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002608 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002609 }
2610
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002611 if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04002612 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002613 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002614 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002615 }
2616
Martin Radev138064f2016-07-15 12:03:41 +03002617 if (readFramebuffer->getReadBufferState() == GL_NONE)
2618 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002619 context->handleError(InvalidOperation() << "Read buffer is GL_NONE");
Martin Radev138064f2016-07-15 12:03:41 +03002620 return false;
2621 }
2622
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002623 // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment
2624 // In OpenGL ES it is undefined what happens when an operation tries to read from a missing
He Yunchao66a41a22016-12-15 16:45:05 +08002625 // attachment and WebGL defines it to be an error. We do the check unconditionally as the
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002626 // situation is an application error that would lead to a crash in ANGLE.
2627 if (readFramebuffer->getReadColorbuffer() == nullptr)
2628 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002629 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment);
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002630 return false;
2631 }
2632
Geoff Langaae65a42014-05-26 12:43:44 -04002633 const gl::Caps &caps = context->getCaps();
2634
Geoff Langaae65a42014-05-26 12:43:44 -04002635 GLuint maxDimension = 0;
Jamie Madill560a8d82014-05-21 13:06:20 -04002636 switch (target)
2637 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002638 case GL_TEXTURE_2D:
2639 maxDimension = caps.max2DTextureSize;
2640 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002641
He Yunchaoced53ae2016-11-29 15:00:51 +08002642 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
2643 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
2644 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
2645 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
2646 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
2647 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
2648 maxDimension = caps.maxCubeMapTextureSize;
2649 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002650
He Yunchaoced53ae2016-11-29 15:00:51 +08002651 case GL_TEXTURE_2D_ARRAY:
2652 maxDimension = caps.max2DTextureSize;
2653 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002654
He Yunchaoced53ae2016-11-29 15:00:51 +08002655 case GL_TEXTURE_3D:
2656 maxDimension = caps.max3DTextureSize;
2657 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002658
He Yunchaoced53ae2016-11-29 15:00:51 +08002659 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002660 context->handleError(InvalidEnum());
He Yunchaoced53ae2016-11-29 15:00:51 +08002661 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002662 }
2663
Jamie Madillc29968b2016-01-20 11:17:23 -05002664 gl::Texture *texture =
2665 state.getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target);
Jamie Madill560a8d82014-05-21 13:06:20 -04002666 if (!texture)
2667 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002668 ANGLE_VALIDATION_ERR(context, InvalidOperation(), TextureNotBound);
Geoff Langb1196682014-07-23 13:47:29 -04002669 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002670 }
2671
Geoff Lang69cce582015-09-17 13:20:36 -04002672 if (texture->getImmutableFormat() && !isSubImage)
Jamie Madill560a8d82014-05-21 13:06:20 -04002673 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002674 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002675 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002676 }
2677
Geoff Langca271392017-04-05 12:30:00 -04002678 const gl::InternalFormat &formatInfo =
2679 gl::GetInternalFormatInfo(internalformat, GL_UNSIGNED_BYTE);
Geoff Lang5d601382014-07-22 15:14:06 -04002680
Geoff Lang966c9402017-04-18 12:38:27 -04002681 if (formatInfo.depthBits > 0 || formatInfo.compressed)
Jamie Madill560a8d82014-05-21 13:06:20 -04002682 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002683 context->handleError(InvalidOperation());
Geoff Langa9be0dc2014-12-17 12:34:40 -05002684 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002685 }
2686
2687 if (isSubImage)
2688 {
Geoff Langa9be0dc2014-12-17 12:34:40 -05002689 if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) ||
2690 static_cast<size_t>(yoffset + height) > texture->getHeight(target, level) ||
2691 static_cast<size_t>(zoffset) >= texture->getDepth(target, level))
Jamie Madill560a8d82014-05-21 13:06:20 -04002692 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002693 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002694 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002695 }
2696 }
Jamie Madill6f38f822014-06-06 17:12:20 -04002697 else
2698 {
Geoff Lang691e58c2014-12-19 17:03:25 -05002699 if (IsCubeMapTextureTarget(target) && width != height)
Jamie Madill6f38f822014-06-06 17:12:20 -04002700 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002701 ANGLE_VALIDATION_ERR(context, InvalidValue(), CubemapIncomplete);
Geoff Langb1196682014-07-23 13:47:29 -04002702 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002703 }
2704
Geoff Langeb66a6e2016-10-31 13:06:12 -04002705 if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions()))
Jamie Madill6f38f822014-06-06 17:12:20 -04002706 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002707 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langb1196682014-07-23 13:47:29 -04002708 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002709 }
2710
2711 int maxLevelDimension = (maxDimension >> level);
He Yunchaoced53ae2016-11-29 15:00:51 +08002712 if (static_cast<int>(width) > maxLevelDimension ||
2713 static_cast<int>(height) > maxLevelDimension)
Jamie Madill6f38f822014-06-06 17:12:20 -04002714 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002715 ANGLE_VALIDATION_ERR(context, InvalidValue(), ResourceMaxTextureSize);
Geoff Langb1196682014-07-23 13:47:29 -04002716 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002717 }
2718 }
Jamie Madill560a8d82014-05-21 13:06:20 -04002719
Jamie Madill0c8abca2016-07-22 20:21:26 -04002720 if (textureFormatOut)
2721 {
2722 *textureFormatOut = texture->getFormat(target, level);
2723 }
Jamie Madillf695a3a2017-01-11 17:36:35 -05002724
2725 // Detect texture copying feedback loops for WebGL.
2726 if (context->getExtensions().webglCompatibility)
2727 {
Jamie Madillfd3dd432017-02-02 19:59:59 -05002728 if (readFramebuffer->formsCopyingFeedbackLoopWith(texture->id(), level, zoffset))
Jamie Madillf695a3a2017-01-11 17:36:35 -05002729 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002730 context->handleError(InvalidOperation() << "Texture copying feedback loop formed "
2731 "between Framebuffer and specified "
2732 "Texture level.");
Jamie Madillf695a3a2017-01-11 17:36:35 -05002733 return false;
2734 }
2735 }
2736
Jamie Madill560a8d82014-05-21 13:06:20 -04002737 return true;
2738}
2739
Jiajia Qind9671222016-11-29 16:30:31 +08002740bool ValidateDrawBase(ValidationContext *context, GLenum mode, GLsizei count)
Jamie Madill250d33f2014-06-06 17:09:03 -04002741{
Jamie Madill1aeb1312014-06-20 13:21:25 -04002742 switch (mode)
2743 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002744 case GL_POINTS:
2745 case GL_LINES:
2746 case GL_LINE_LOOP:
2747 case GL_LINE_STRIP:
2748 case GL_TRIANGLES:
2749 case GL_TRIANGLE_STRIP:
2750 case GL_TRIANGLE_FAN:
2751 break;
2752 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002753 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidDrawMode);
He Yunchaoced53ae2016-11-29 15:00:51 +08002754 return false;
Jamie Madill1aeb1312014-06-20 13:21:25 -04002755 }
2756
Jamie Madill250d33f2014-06-06 17:09:03 -04002757 if (count < 0)
2758 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002759 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Geoff Langb1196682014-07-23 13:47:29 -04002760 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002761 }
2762
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002763 const State &state = context->getGLState();
Geoff Langb1196682014-07-23 13:47:29 -04002764
Jamie Madill250d33f2014-06-06 17:09:03 -04002765 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002766 if (state.hasMappedBuffer(GL_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04002767 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002768 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002769 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002770 }
2771
Jamie Madillcbcde722017-01-06 14:50:00 -05002772 // Note: these separate values are not supported in WebGL, due to D3D's limitations. See
2773 // Section 6.10 of the WebGL 1.0 spec.
Jamie Madill51f40ec2016-06-15 14:06:00 -04002774 Framebuffer *framebuffer = state.getDrawFramebuffer();
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002775 if (context->getLimitations().noSeparateStencilRefsAndMasks ||
2776 context->getExtensions().webglCompatibility)
Jamie Madillac528012014-06-20 13:21:23 -04002777 {
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002778 const FramebufferAttachment *dsAttachment =
2779 framebuffer->getStencilOrDepthStencilAttachment();
2780 GLuint stencilBits = dsAttachment ? dsAttachment->getStencilSize() : 0;
He Yunchaoced53ae2016-11-29 15:00:51 +08002781 GLuint minimumRequiredStencilMask = (1 << stencilBits) - 1;
Jinyoung Hur85769f02015-10-20 17:08:44 -04002782 const DepthStencilState &depthStencilState = state.getDepthStencilState();
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002783
2784 bool differentRefs = state.getStencilRef() != state.getStencilBackRef();
2785 bool differentWritemasks =
2786 (depthStencilState.stencilWritemask & minimumRequiredStencilMask) !=
2787 (depthStencilState.stencilBackWritemask & minimumRequiredStencilMask);
2788 bool differentMasks = (depthStencilState.stencilMask & minimumRequiredStencilMask) !=
2789 (depthStencilState.stencilBackMask & minimumRequiredStencilMask);
2790
2791 if (differentRefs || differentWritemasks || differentMasks)
Geoff Lang3a86ad32015-09-01 11:47:05 -04002792 {
Jamie Madillcbcde722017-01-06 14:50:00 -05002793 if (!context->getExtensions().webglCompatibility)
2794 {
Yuly Novikovd73f8522017-01-13 17:48:57 -05002795 ERR() << "This ANGLE implementation does not support separate front/back stencil "
2796 "writemasks, reference values, or stencil mask values.";
Jamie Madillcbcde722017-01-06 14:50:00 -05002797 }
Brandon Jones6cad5662017-06-14 13:25:13 -07002798 ANGLE_VALIDATION_ERR(context, InvalidOperation(), StencilReferenceMaskOrMismatch);
Geoff Lang3a86ad32015-09-01 11:47:05 -04002799 return false;
2800 }
Jamie Madillac528012014-06-20 13:21:23 -04002801 }
2802
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002803 if (framebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill13f7d7d2014-06-20 13:21:27 -04002804 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002805 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002806 return false;
Jamie Madill13f7d7d2014-06-20 13:21:27 -04002807 }
2808
Geoff Lang7dd2e102014-11-10 15:19:26 -05002809 gl::Program *program = state.getProgram();
2810 if (!program)
Jamie Madilld4cfa572014-07-08 10:00:32 -04002811 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002812 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotBound);
Geoff Langb1196682014-07-23 13:47:29 -04002813 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04002814 }
2815
Yunchao Hef81ce4a2017-04-24 10:49:17 +08002816 if (!program->validateSamplers(nullptr, context->getCaps()))
Jamie Madilld4cfa572014-07-08 10:00:32 -04002817 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002818 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002819 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04002820 }
2821
Martin Radev7cf61662017-07-26 17:10:53 +03002822 if (context->getExtensions().multiview)
2823 {
Martin Radev7e69f762017-07-27 14:54:13 +03002824 const int programNumViews = program->getNumViews();
2825 const int framebufferNumViews = framebuffer->getNumViews();
2826 if (programNumViews != -1 && framebufferNumViews != programNumViews)
Martin Radev7cf61662017-07-26 17:10:53 +03002827 {
2828 context->handleError(InvalidOperation() << "The number of views in the active program "
2829 "and draw framebuffer does not match.");
2830 return false;
2831 }
Martin Radev7e69f762017-07-27 14:54:13 +03002832
2833 const TransformFeedback *transformFeedbackObject = state.getCurrentTransformFeedback();
2834 if (transformFeedbackObject != nullptr && transformFeedbackObject->isActive() &&
2835 framebufferNumViews > 1)
2836 {
2837 context->handleError(InvalidOperation()
2838 << "There is an active transform feedback object "
2839 "when the number of views in the active draw "
2840 "framebuffer is greater than 1.");
2841 return false;
2842 }
Martin Radev7cf61662017-07-26 17:10:53 +03002843 }
2844
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002845 // Uniform buffer validation
He Yunchaoced53ae2016-11-29 15:00:51 +08002846 for (unsigned int uniformBlockIndex = 0;
2847 uniformBlockIndex < program->getActiveUniformBlockCount(); uniformBlockIndex++)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002848 {
Jamie Madill62d31cb2015-09-11 13:25:51 -04002849 const gl::UniformBlock &uniformBlock = program->getUniformBlockByIndex(uniformBlockIndex);
He Yunchaoced53ae2016-11-29 15:00:51 +08002850 GLuint blockBinding = program->getUniformBlockBinding(uniformBlockIndex);
Geoff Lang5d124a62015-09-15 13:03:27 -04002851 const OffsetBindingPointer<Buffer> &uniformBuffer =
2852 state.getIndexedUniformBuffer(blockBinding);
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002853
Geoff Lang5d124a62015-09-15 13:03:27 -04002854 if (uniformBuffer.get() == nullptr)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002855 {
2856 // undefined behaviour
Jamie Madill437fa652016-05-03 15:13:24 -04002857 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002858 InvalidOperation()
2859 << "It is undefined behaviour to have a used but unbound uniform buffer.");
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002860 return false;
2861 }
2862
Geoff Lang5d124a62015-09-15 13:03:27 -04002863 size_t uniformBufferSize = uniformBuffer.getSize();
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002864 if (uniformBufferSize == 0)
2865 {
2866 // Bind the whole buffer.
Minmin Gong794e0002015-04-07 18:31:54 -07002867 uniformBufferSize = static_cast<size_t>(uniformBuffer->getSize());
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002868 }
2869
Jamie Madill62d31cb2015-09-11 13:25:51 -04002870 if (uniformBufferSize < uniformBlock.dataSize)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002871 {
2872 // undefined behaviour
Jamie Madill437fa652016-05-03 15:13:24 -04002873 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002874 InvalidOperation()
2875 << "It is undefined behaviour to use a uniform buffer that is too small.");
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002876 return false;
2877 }
2878 }
2879
Geoff Lange0cff192017-05-30 13:04:56 -04002880 // Do some additonal WebGL-specific validation
Jamie Madilla4595b82017-01-11 17:36:34 -05002881 if (context->getExtensions().webglCompatibility)
2882 {
Geoff Lange0cff192017-05-30 13:04:56 -04002883 // Detect rendering feedback loops for WebGL.
Jamie Madilla4595b82017-01-11 17:36:34 -05002884 if (framebuffer->formsRenderingFeedbackLoopWith(state))
2885 {
2886 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002887 InvalidOperation()
2888 << "Rendering feedback loop formed between Framebuffer and active Texture.");
Jamie Madilla4595b82017-01-11 17:36:34 -05002889 return false;
2890 }
Geoff Lange0cff192017-05-30 13:04:56 -04002891
Geoff Lang9ab5b822017-05-30 16:19:23 -04002892 // Detect that the vertex shader input types match the attribute types
2893 if (!ValidateVertexShaderAttributeTypeMatch(context))
2894 {
2895 return false;
2896 }
2897
Geoff Lange0cff192017-05-30 13:04:56 -04002898 // Detect that the color buffer types match the fragment shader output types
2899 if (!ValidateFragmentShaderColorBufferTypeMatch(context))
2900 {
2901 return false;
2902 }
Jamie Madilla4595b82017-01-11 17:36:34 -05002903 }
2904
Jamie Madill250d33f2014-06-06 17:09:03 -04002905 // No-op if zero count
2906 return (count > 0);
2907}
2908
Jamie Madillc1d770e2017-04-13 17:31:24 -04002909bool ValidateDrawArraysCommon(ValidationContext *context,
2910 GLenum mode,
2911 GLint first,
2912 GLsizei count,
2913 GLsizei primcount)
Jamie Madill250d33f2014-06-06 17:09:03 -04002914{
Jamie Madillfd716582014-06-06 17:09:04 -04002915 if (first < 0)
Jamie Madill250d33f2014-06-06 17:09:03 -04002916 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002917 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeStart);
Geoff Langb1196682014-07-23 13:47:29 -04002918 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002919 }
2920
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002921 const State &state = context->getGLState();
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002922 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
He Yunchaoced53ae2016-11-29 15:00:51 +08002923 if (curTransformFeedback && curTransformFeedback->isActive() &&
2924 !curTransformFeedback->isPaused() && curTransformFeedback->getPrimitiveMode() != mode)
Jamie Madillfd716582014-06-06 17:09:04 -04002925 {
2926 // It is an invalid operation to call DrawArrays or DrawArraysInstanced with a draw mode
He Yunchaoced53ae2016-11-29 15:00:51 +08002927 // that does not match the current transform feedback object's draw mode (if transform
2928 // feedback
Jamie Madillfd716582014-06-06 17:09:04 -04002929 // is active), (3.0.2, section 2.14, pg 86)
Brandon Jones6cad5662017-06-14 13:25:13 -07002930 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidDrawModeTransformFeedback);
Geoff Langb1196682014-07-23 13:47:29 -04002931 return false;
Jamie Madillfd716582014-06-06 17:09:04 -04002932 }
2933
Jiajia Qind9671222016-11-29 16:30:31 +08002934 if (!ValidateDrawBase(context, mode, count))
Corentin Wallez18a2fb32015-08-10 12:58:14 -07002935 {
2936 return false;
2937 }
2938
Corentin Wallez71168a02016-12-19 15:11:18 -08002939 // Check the computation of maxVertex doesn't overflow.
2940 // - first < 0 or count < 0 have been checked as an error condition
2941 // - count > 0 has been checked in ValidateDrawBase as it makes the call a noop
2942 // From this we know maxVertex will be positive, and only need to check if it overflows GLint.
2943 ASSERT(count > 0 && first >= 0);
2944 int64_t maxVertex = static_cast<int64_t>(first) + static_cast<int64_t>(count) - 1;
2945 if (maxVertex > static_cast<int64_t>(std::numeric_limits<GLint>::max()))
Corentin Wallez92db6942016-12-09 13:10:36 -05002946 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002947 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallez92db6942016-12-09 13:10:36 -05002948 return false;
2949 }
2950
Corentin Wallez71168a02016-12-19 15:11:18 -08002951 if (!ValidateDrawAttribs(context, primcount, static_cast<GLint>(maxVertex), count))
Jamie Madillfd716582014-06-06 17:09:04 -04002952 {
2953 return false;
2954 }
2955
2956 return true;
2957}
2958
He Yunchaoced53ae2016-11-29 15:00:51 +08002959bool ValidateDrawArraysInstanced(Context *context,
2960 GLenum mode,
2961 GLint first,
2962 GLsizei count,
2963 GLsizei primcount)
Jamie Madillfd716582014-06-06 17:09:04 -04002964{
Corentin Wallez0dc97812017-06-22 14:38:44 -04002965 return ValidateDrawArraysInstancedBase(context, mode, first, count, primcount);
Geoff Lang87a93302014-09-16 13:29:43 -04002966}
2967
He Yunchaoced53ae2016-11-29 15:00:51 +08002968bool ValidateDrawArraysInstancedANGLE(Context *context,
2969 GLenum mode,
2970 GLint first,
2971 GLsizei count,
2972 GLsizei primcount)
Geoff Lang87a93302014-09-16 13:29:43 -04002973{
Corentin Wallez170efbf2017-05-02 13:45:01 -04002974 if (!ValidateDrawArraysInstancedBase(context, mode, first, count, primcount))
Geoff Lang87a93302014-09-16 13:29:43 -04002975 {
2976 return false;
2977 }
2978
Corentin Wallez0dc97812017-06-22 14:38:44 -04002979 return ValidateDrawInstancedANGLE(context);
Geoff Lang87a93302014-09-16 13:29:43 -04002980}
2981
Jiajia Qind9671222016-11-29 16:30:31 +08002982bool ValidateDrawElementsBase(ValidationContext *context, GLenum type)
Jamie Madillfd716582014-06-06 17:09:04 -04002983{
Jamie Madill250d33f2014-06-06 17:09:03 -04002984 switch (type)
2985 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002986 case GL_UNSIGNED_BYTE:
2987 case GL_UNSIGNED_SHORT:
2988 break;
2989 case GL_UNSIGNED_INT:
2990 if (context->getClientMajorVersion() < 3 && !context->getExtensions().elementIndexUint)
2991 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002992 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte);
He Yunchaoced53ae2016-11-29 15:00:51 +08002993 return false;
2994 }
2995 break;
2996 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002997 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte);
He Yunchaoced53ae2016-11-29 15:00:51 +08002998 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002999 }
3000
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003001 const State &state = context->getGLState();
Jamie Madilld9ba4f72014-08-04 10:47:59 -04003002
3003 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
He Yunchaoced53ae2016-11-29 15:00:51 +08003004 if (curTransformFeedback && curTransformFeedback->isActive() &&
3005 !curTransformFeedback->isPaused())
Jamie Madill250d33f2014-06-06 17:09:03 -04003006 {
He Yunchaoced53ae2016-11-29 15:00:51 +08003007 // It is an invalid operation to call DrawElements, DrawRangeElements or
3008 // DrawElementsInstanced
Jamie Madill250d33f2014-06-06 17:09:03 -04003009 // while transform feedback is active, (3.0.2, section 2.14, pg 86)
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003010 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04003011 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04003012 }
3013
Jiajia Qind9671222016-11-29 16:30:31 +08003014 return true;
3015}
3016
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003017bool ValidateDrawElementsCommon(ValidationContext *context,
3018 GLenum mode,
3019 GLsizei count,
3020 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04003021 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003022 GLsizei primcount)
Jiajia Qind9671222016-11-29 16:30:31 +08003023{
3024 if (!ValidateDrawElementsBase(context, type))
3025 return false;
3026
3027 const State &state = context->getGLState();
3028
Corentin Wallez170efbf2017-05-02 13:45:01 -04003029 if (!ValidateDrawBase(context, mode, count))
3030 {
3031 return false;
3032 }
3033
Jamie Madill250d33f2014-06-06 17:09:03 -04003034 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04003035 if (state.hasMappedBuffer(GL_ELEMENT_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04003036 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003037 context->handleError(InvalidOperation() << "Index buffer is mapped.");
Geoff Langb1196682014-07-23 13:47:29 -04003038 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04003039 }
3040
He Yunchaoced53ae2016-11-29 15:00:51 +08003041 const gl::VertexArray *vao = state.getVertexArray();
Jamie Madill8e344942015-07-09 14:22:07 -04003042 gl::Buffer *elementArrayBuffer = vao->getElementArrayBuffer().get();
Jamie Madilld4cfa572014-07-08 10:00:32 -04003043
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003044 GLuint typeBytes = gl::GetTypeInfo(type).bytes;
3045
3046 if (context->getExtensions().webglCompatibility)
3047 {
3048 ASSERT(isPow2(typeBytes) && typeBytes > 0);
3049 if ((reinterpret_cast<uintptr_t>(indices) & static_cast<uintptr_t>(typeBytes - 1)) != 0)
3050 {
3051 // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements
3052 // The offset arguments to drawElements and [...], must be a multiple of the size of the
3053 // data type passed to the call, or an INVALID_OPERATION error is generated.
Brandon Jones6cad5662017-06-14 13:25:13 -07003054 ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType);
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003055 return false;
3056 }
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003057
3058 // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements
3059 // In addition the offset argument to drawElements must be non-negative or an INVALID_VALUE
3060 // error is generated.
3061 if (reinterpret_cast<intptr_t>(indices) < 0)
3062 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003063 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003064 return false;
3065 }
Geoff Langfeb8c682017-02-13 16:07:35 -05003066 }
3067
3068 if (context->getExtensions().webglCompatibility ||
3069 !context->getGLState().areClientArraysEnabled())
3070 {
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003071 if (!elementArrayBuffer && count > 0)
3072 {
3073 // [WebGL 1.0] Section 6.2 No Client Side Arrays
3074 // If drawElements is called with a count greater than zero, and no WebGLBuffer is bound
3075 // to the ELEMENT_ARRAY_BUFFER binding point, an INVALID_OPERATION error is generated.
Brandon Jones6cad5662017-06-14 13:25:13 -07003076 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MustHaveElementArrayBinding);
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003077 return false;
3078 }
3079 }
3080
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003081 if (count > 0)
Jamie Madillae3000b2014-08-25 15:47:51 -04003082 {
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003083 if (elementArrayBuffer)
Jamie Madillae3000b2014-08-25 15:47:51 -04003084 {
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003085 // The max possible type size is 8 and count is on 32 bits so doing the multiplication
3086 // in a 64 bit integer is safe. Also we are guaranteed that here count > 0.
3087 static_assert(std::is_same<int, GLsizei>::value, "GLsizei isn't the expected type");
3088 constexpr uint64_t kMaxTypeSize = 8;
3089 constexpr uint64_t kIntMax = std::numeric_limits<int>::max();
3090 constexpr uint64_t kUint64Max = std::numeric_limits<uint64_t>::max();
3091 static_assert(kIntMax < kUint64Max / kMaxTypeSize, "");
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003092
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003093 uint64_t typeSize = typeBytes;
3094 uint64_t elementCount = static_cast<uint64_t>(count);
3095 ASSERT(elementCount > 0 && typeSize <= kMaxTypeSize);
3096
3097 // Doing the multiplication here is overflow-safe
3098 uint64_t elementDataSizeNoOffset = typeSize * elementCount;
3099
3100 // The offset can be any value, check for overflows
3101 uint64_t offset = static_cast<uint64_t>(reinterpret_cast<uintptr_t>(indices));
3102 if (elementDataSizeNoOffset > kUint64Max - offset)
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003103 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003104 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003105 return false;
3106 }
3107
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003108 uint64_t elementDataSizeWithOffset = elementDataSizeNoOffset + offset;
3109 if (elementDataSizeWithOffset > static_cast<uint64_t>(elementArrayBuffer->getSize()))
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003110 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003111 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003112 return false;
3113 }
3114 }
3115 else if (!indices)
3116 {
3117 // This is an application error that would normally result in a crash,
3118 // but we catch it and return an error
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003119 context->handleError(InvalidOperation() << "No element array buffer and no pointer.");
Geoff Langb1196682014-07-23 13:47:29 -04003120 return false;
Jamie Madillae3000b2014-08-25 15:47:51 -04003121 }
Jamie Madillae3000b2014-08-25 15:47:51 -04003122 }
3123
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003124 // Use the parameter buffer to retrieve and cache the index range.
Jamie Madill2b976812014-08-25 15:47:49 -04003125 // TODO: offer fast path, with disabled index validation.
3126 // TODO: also disable index checking on back-ends that are robust to out-of-range accesses.
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003127 const auto &params = context->getParams<HasIndexRange>();
3128 const auto &indexRangeOpt = params.getIndexRange();
3129 if (!indexRangeOpt.valid())
Jamie Madill2b976812014-08-25 15:47:49 -04003130 {
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003131 // Unexpected error.
3132 return false;
Jamie Madill2b976812014-08-25 15:47:49 -04003133 }
3134
Jamie Madille79b1e12015-11-04 16:36:37 -05003135 // If we use an index greater than our maximum supported index range, return an error.
3136 // The ES3 spec does not specify behaviour here, it is undefined, but ANGLE should always
3137 // return an error if possible here.
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003138 if (static_cast<GLuint64>(indexRangeOpt.value().end) >= context->getCaps().maxElementIndex)
Jamie Madille79b1e12015-11-04 16:36:37 -05003139 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003140 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExceedsMaxElement);
Jamie Madille79b1e12015-11-04 16:36:37 -05003141 return false;
3142 }
3143
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003144 if (!ValidateDrawAttribs(context, primcount, static_cast<GLint>(indexRangeOpt.value().end),
3145 static_cast<GLint>(indexRangeOpt.value().vertexCount())))
Jamie Madillfd716582014-06-06 17:09:04 -04003146 {
3147 return false;
3148 }
3149
Geoff Lang3edfe032015-09-04 16:38:24 -04003150 // No op if there are no real indices in the index data (all are primitive restart).
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003151 return (indexRangeOpt.value().vertexIndexCount > 0);
Jamie Madillfd716582014-06-06 17:09:04 -04003152}
3153
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003154bool ValidateDrawElementsInstancedCommon(ValidationContext *context,
3155 GLenum mode,
3156 GLsizei count,
3157 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04003158 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003159 GLsizei primcount)
Jamie Madillfd716582014-06-06 17:09:04 -04003160{
Corentin Wallez0dc97812017-06-22 14:38:44 -04003161 return ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount);
Jamie Madill250d33f2014-06-06 17:09:03 -04003162}
3163
Geoff Lang3edfe032015-09-04 16:38:24 -04003164bool ValidateDrawElementsInstancedANGLE(Context *context,
3165 GLenum mode,
3166 GLsizei count,
3167 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04003168 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003169 GLsizei primcount)
Geoff Lang87a93302014-09-16 13:29:43 -04003170{
Corentin Wallez170efbf2017-05-02 13:45:01 -04003171 if (!ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount))
Geoff Lang87a93302014-09-16 13:29:43 -04003172 {
3173 return false;
3174 }
3175
Corentin Wallez0dc97812017-06-22 14:38:44 -04003176 return ValidateDrawInstancedANGLE(context);
Geoff Lang87a93302014-09-16 13:29:43 -04003177}
3178
He Yunchaoced53ae2016-11-29 15:00:51 +08003179bool ValidateFramebufferTextureBase(Context *context,
3180 GLenum target,
3181 GLenum attachment,
3182 GLuint texture,
3183 GLint level)
Jamie Madill570f7c82014-07-03 10:38:54 -04003184{
Jamie Madill55ec3b12014-07-03 10:38:57 -04003185 if (!ValidFramebufferTarget(target))
3186 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003187 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04003188 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003189 }
3190
3191 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill570f7c82014-07-03 10:38:54 -04003192 {
3193 return false;
3194 }
3195
Jamie Madill55ec3b12014-07-03 10:38:57 -04003196 if (texture != 0)
3197 {
3198 gl::Texture *tex = context->getTexture(texture);
3199
Jamie Madillbe849e42017-05-02 15:49:00 -04003200 if (tex == NULL)
Jamie Madill55ec3b12014-07-03 10:38:57 -04003201 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003202 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04003203 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003204 }
3205
3206 if (level < 0)
3207 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003208 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04003209 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003210 }
3211 }
3212
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003213 const gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
Jamie Madill84115c92015-04-23 15:00:07 -04003214 ASSERT(framebuffer);
Jamie Madill55ec3b12014-07-03 10:38:57 -04003215
Jamie Madill84115c92015-04-23 15:00:07 -04003216 if (framebuffer->id() == 0)
Jamie Madill55ec3b12014-07-03 10:38:57 -04003217 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003218 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04003219 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003220 }
3221
3222 return true;
3223}
3224
Geoff Langb1196682014-07-23 13:47:29 -04003225bool ValidateGetUniformBase(Context *context, GLuint program, GLint location)
Jamie Madill0063c512014-08-25 15:47:53 -04003226{
3227 if (program == 0)
3228 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003229 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04003230 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003231 }
3232
Dian Xiang769769a2015-09-09 15:20:08 -07003233 gl::Program *programObject = GetValidProgram(context, program);
3234 if (!programObject)
Shannon Woods4de4fd62014-11-07 16:22:02 -05003235 {
3236 return false;
3237 }
3238
Jamie Madill0063c512014-08-25 15:47:53 -04003239 if (!programObject || !programObject->isLinked())
3240 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003241 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Geoff Langb1196682014-07-23 13:47:29 -04003242 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003243 }
3244
Geoff Lang7dd2e102014-11-10 15:19:26 -05003245 if (!programObject->isValidUniformLocation(location))
Jamie Madill549c7fd2014-08-25 15:47:56 -04003246 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003247 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04003248 return false;
Jamie Madill549c7fd2014-08-25 15:47:56 -04003249 }
3250
Jamie Madill0063c512014-08-25 15:47:53 -04003251 return true;
3252}
3253
Geoff Langf41d0ee2016-10-07 13:04:23 -04003254static bool ValidateSizedGetUniform(Context *context,
3255 GLuint program,
3256 GLint location,
3257 GLsizei bufSize,
3258 GLsizei *length)
Jamie Madill78f41802014-08-25 15:47:55 -04003259{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003260 if (length)
3261 {
3262 *length = 0;
3263 }
3264
Jamie Madill78f41802014-08-25 15:47:55 -04003265 if (!ValidateGetUniformBase(context, program, location))
Jamie Madill0063c512014-08-25 15:47:53 -04003266 {
Jamie Madill78f41802014-08-25 15:47:55 -04003267 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003268 }
3269
Geoff Langf41d0ee2016-10-07 13:04:23 -04003270 if (bufSize < 0)
3271 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003272 context->handleError(InvalidValue() << "bufSize cannot be negative.");
Geoff Langf41d0ee2016-10-07 13:04:23 -04003273 return false;
3274 }
3275
Jamie Madilla502c742014-08-28 17:19:13 -04003276 gl::Program *programObject = context->getProgram(program);
3277 ASSERT(programObject);
Jamie Madill0063c512014-08-25 15:47:53 -04003278
Jamie Madill78f41802014-08-25 15:47:55 -04003279 // sized queries -- ensure the provided buffer is large enough
Jamie Madill62d31cb2015-09-11 13:25:51 -04003280 const LinkedUniform &uniform = programObject->getUniformByLocation(location);
He Yunchaoced53ae2016-11-29 15:00:51 +08003281 size_t requiredBytes = VariableExternalSize(uniform.type);
Jamie Madill78f41802014-08-25 15:47:55 -04003282 if (static_cast<size_t>(bufSize) < requiredBytes)
Jamie Madill0063c512014-08-25 15:47:53 -04003283 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003284 context->handleError(InvalidOperation()
3285 << "bufSize of at least " << requiredBytes << " is required.");
Geoff Langb1196682014-07-23 13:47:29 -04003286 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003287 }
3288
Geoff Langf41d0ee2016-10-07 13:04:23 -04003289 if (length)
3290 {
Geoff Lang94177fb2016-11-14 16:12:26 -05003291 *length = VariableComponentCount(uniform.type);
Geoff Langf41d0ee2016-10-07 13:04:23 -04003292 }
3293
Jamie Madill0063c512014-08-25 15:47:53 -04003294 return true;
3295}
3296
He Yunchaoced53ae2016-11-29 15:00:51 +08003297bool ValidateGetnUniformfvEXT(Context *context,
3298 GLuint program,
3299 GLint location,
3300 GLsizei bufSize,
3301 GLfloat *params)
Jamie Madill0063c512014-08-25 15:47:53 -04003302{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003303 return ValidateSizedGetUniform(context, program, location, bufSize, nullptr);
Jamie Madill0063c512014-08-25 15:47:53 -04003304}
3305
He Yunchaoced53ae2016-11-29 15:00:51 +08003306bool ValidateGetnUniformivEXT(Context *context,
3307 GLuint program,
3308 GLint location,
3309 GLsizei bufSize,
3310 GLint *params)
Jamie Madill0063c512014-08-25 15:47:53 -04003311{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003312 return ValidateSizedGetUniform(context, program, location, bufSize, nullptr);
3313}
3314
3315bool ValidateGetUniformfvRobustANGLE(Context *context,
3316 GLuint program,
3317 GLint location,
3318 GLsizei bufSize,
3319 GLsizei *length,
3320 GLfloat *params)
3321{
3322 if (!ValidateRobustEntryPoint(context, bufSize))
3323 {
3324 return false;
3325 }
3326
3327 // bufSize is validated in ValidateSizedGetUniform
3328 return ValidateSizedGetUniform(context, program, location, bufSize, length);
3329}
3330
3331bool ValidateGetUniformivRobustANGLE(Context *context,
3332 GLuint program,
3333 GLint location,
3334 GLsizei bufSize,
3335 GLsizei *length,
3336 GLint *params)
3337{
3338 if (!ValidateRobustEntryPoint(context, bufSize))
3339 {
3340 return false;
3341 }
3342
3343 // bufSize is validated in ValidateSizedGetUniform
3344 return ValidateSizedGetUniform(context, program, location, bufSize, length);
3345}
3346
3347bool ValidateGetUniformuivRobustANGLE(Context *context,
3348 GLuint program,
3349 GLint location,
3350 GLsizei bufSize,
3351 GLsizei *length,
3352 GLuint *params)
3353{
3354 if (!ValidateRobustEntryPoint(context, bufSize))
3355 {
3356 return false;
3357 }
3358
3359 if (context->getClientMajorVersion() < 3)
3360 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003361 context->handleError(InvalidOperation() << "Entry point requires at least OpenGL ES 3.0.");
Geoff Langf41d0ee2016-10-07 13:04:23 -04003362 return false;
3363 }
3364
3365 // bufSize is validated in ValidateSizedGetUniform
3366 return ValidateSizedGetUniform(context, program, location, bufSize, length);
Jamie Madill0063c512014-08-25 15:47:53 -04003367}
3368
He Yunchaoced53ae2016-11-29 15:00:51 +08003369bool ValidateDiscardFramebufferBase(Context *context,
3370 GLenum target,
3371 GLsizei numAttachments,
3372 const GLenum *attachments,
3373 bool defaultFramebuffer)
Austin Kinross08332632015-05-05 13:35:47 -07003374{
3375 if (numAttachments < 0)
3376 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003377 context->handleError(InvalidValue() << "numAttachments must not be less than zero");
Austin Kinross08332632015-05-05 13:35:47 -07003378 return false;
3379 }
3380
3381 for (GLsizei i = 0; i < numAttachments; ++i)
3382 {
Olli Etuaho84c9f592016-03-09 14:37:25 +02003383 if (attachments[i] >= GL_COLOR_ATTACHMENT0 && attachments[i] <= GL_COLOR_ATTACHMENT31)
Austin Kinross08332632015-05-05 13:35:47 -07003384 {
3385 if (defaultFramebuffer)
3386 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003387 context->handleError(InvalidEnum()
3388 << "Invalid attachment when the default framebuffer is bound");
Austin Kinross08332632015-05-05 13:35:47 -07003389 return false;
3390 }
3391
3392 if (attachments[i] >= GL_COLOR_ATTACHMENT0 + context->getCaps().maxColorAttachments)
3393 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003394 context->handleError(InvalidOperation() << "Requested color attachment is "
3395 "greater than the maximum supported "
3396 "color attachments");
Austin Kinross08332632015-05-05 13:35:47 -07003397 return false;
3398 }
3399 }
3400 else
3401 {
3402 switch (attachments[i])
3403 {
He Yunchaoced53ae2016-11-29 15:00:51 +08003404 case GL_DEPTH_ATTACHMENT:
3405 case GL_STENCIL_ATTACHMENT:
3406 case GL_DEPTH_STENCIL_ATTACHMENT:
3407 if (defaultFramebuffer)
3408 {
3409 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003410 InvalidEnum()
3411 << "Invalid attachment when the default framebuffer is bound");
He Yunchaoced53ae2016-11-29 15:00:51 +08003412 return false;
3413 }
3414 break;
3415 case GL_COLOR:
3416 case GL_DEPTH:
3417 case GL_STENCIL:
3418 if (!defaultFramebuffer)
3419 {
3420 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003421 InvalidEnum()
3422 << "Invalid attachment when the default framebuffer is not bound");
He Yunchaoced53ae2016-11-29 15:00:51 +08003423 return false;
3424 }
3425 break;
3426 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003427 context->handleError(InvalidEnum() << "Invalid attachment");
Austin Kinross08332632015-05-05 13:35:47 -07003428 return false;
Austin Kinross08332632015-05-05 13:35:47 -07003429 }
3430 }
3431 }
3432
3433 return true;
3434}
3435
Austin Kinross6ee1e782015-05-29 17:05:37 -07003436bool ValidateInsertEventMarkerEXT(Context *context, GLsizei length, const char *marker)
3437{
3438 // Note that debug marker calls must not set error state
3439
3440 if (length < 0)
3441 {
3442 return false;
3443 }
3444
3445 if (marker == nullptr)
3446 {
3447 return false;
3448 }
3449
3450 return true;
3451}
3452
3453bool ValidatePushGroupMarkerEXT(Context *context, GLsizei length, const char *marker)
3454{
3455 // Note that debug marker calls must not set error state
3456
3457 if (length < 0)
3458 {
3459 return false;
3460 }
3461
3462 if (length > 0 && marker == nullptr)
3463 {
3464 return false;
3465 }
3466
3467 return true;
3468}
3469
Geoff Langdcab33b2015-07-21 13:03:16 -04003470bool ValidateEGLImageTargetTexture2DOES(Context *context,
Geoff Langdcab33b2015-07-21 13:03:16 -04003471 GLenum target,
3472 egl::Image *image)
3473{
Geoff Langa8406172015-07-21 16:53:39 -04003474 if (!context->getExtensions().eglImage && !context->getExtensions().eglImageExternal)
3475 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003476 context->handleError(InvalidOperation());
Geoff Langa8406172015-07-21 16:53:39 -04003477 return false;
3478 }
3479
3480 switch (target)
3481 {
3482 case GL_TEXTURE_2D:
Geoff Langb66a9092016-05-16 15:59:14 -04003483 if (!context->getExtensions().eglImage)
3484 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003485 context->handleError(InvalidEnum()
3486 << "GL_TEXTURE_2D texture target requires GL_OES_EGL_image.");
Geoff Langb66a9092016-05-16 15:59:14 -04003487 }
3488 break;
3489
3490 case GL_TEXTURE_EXTERNAL_OES:
3491 if (!context->getExtensions().eglImageExternal)
3492 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003493 context->handleError(InvalidEnum() << "GL_TEXTURE_EXTERNAL_OES texture target "
3494 "requires GL_OES_EGL_image_external.");
Geoff Langb66a9092016-05-16 15:59:14 -04003495 }
Geoff Langa8406172015-07-21 16:53:39 -04003496 break;
3497
3498 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003499 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Geoff Langa8406172015-07-21 16:53:39 -04003500 return false;
3501 }
3502
Jamie Madill61e16b42017-06-19 11:13:23 -04003503 ASSERT(context->getCurrentDisplay());
3504 if (!context->getCurrentDisplay()->isValidImage(image))
Geoff Langa8406172015-07-21 16:53:39 -04003505 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003506 context->handleError(InvalidValue() << "EGL image is not valid.");
Geoff Langa8406172015-07-21 16:53:39 -04003507 return false;
3508 }
3509
3510 if (image->getSamples() > 0)
3511 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003512 context->handleError(InvalidOperation()
3513 << "cannot create a 2D texture from a multisampled EGL image.");
Geoff Langa8406172015-07-21 16:53:39 -04003514 return false;
3515 }
3516
Geoff Langca271392017-04-05 12:30:00 -04003517 const TextureCaps &textureCaps =
3518 context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat);
Geoff Langa8406172015-07-21 16:53:39 -04003519 if (!textureCaps.texturable)
3520 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003521 context->handleError(InvalidOperation()
3522 << "EGL image internal format is not supported as a texture.");
Geoff Langa8406172015-07-21 16:53:39 -04003523 return false;
3524 }
3525
Geoff Langdcab33b2015-07-21 13:03:16 -04003526 return true;
3527}
3528
3529bool ValidateEGLImageTargetRenderbufferStorageOES(Context *context,
Geoff Langdcab33b2015-07-21 13:03:16 -04003530 GLenum target,
3531 egl::Image *image)
3532{
Geoff Langa8406172015-07-21 16:53:39 -04003533 if (!context->getExtensions().eglImage)
3534 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003535 context->handleError(InvalidOperation());
Geoff Langa8406172015-07-21 16:53:39 -04003536 return false;
3537 }
3538
3539 switch (target)
3540 {
3541 case GL_RENDERBUFFER:
3542 break;
3543
3544 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003545 context->handleError(InvalidEnum() << "invalid renderbuffer target.");
Geoff Langa8406172015-07-21 16:53:39 -04003546 return false;
3547 }
3548
Jamie Madill61e16b42017-06-19 11:13:23 -04003549 ASSERT(context->getCurrentDisplay());
3550 if (!context->getCurrentDisplay()->isValidImage(image))
Geoff Langa8406172015-07-21 16:53:39 -04003551 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003552 context->handleError(InvalidValue() << "EGL image is not valid.");
Geoff Langa8406172015-07-21 16:53:39 -04003553 return false;
3554 }
3555
Geoff Langca271392017-04-05 12:30:00 -04003556 const TextureCaps &textureCaps =
3557 context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat);
Geoff Langa8406172015-07-21 16:53:39 -04003558 if (!textureCaps.renderable)
3559 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003560 context->handleError(InvalidOperation()
3561 << "EGL image internal format is not supported as a renderbuffer.");
Geoff Langa8406172015-07-21 16:53:39 -04003562 return false;
3563 }
3564
Geoff Langdcab33b2015-07-21 13:03:16 -04003565 return true;
3566}
Austin Kinrossbc781f32015-10-26 09:27:38 -07003567
3568bool ValidateBindVertexArrayBase(Context *context, GLuint array)
3569{
Geoff Lang36167ab2015-12-07 10:27:14 -05003570 if (!context->isVertexArrayGenerated(array))
Austin Kinrossbc781f32015-10-26 09:27:38 -07003571 {
3572 // The default VAO should always exist
3573 ASSERT(array != 0);
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003574 context->handleError(InvalidOperation());
Austin Kinrossbc781f32015-10-26 09:27:38 -07003575 return false;
3576 }
3577
3578 return true;
3579}
3580
Geoff Langc5629752015-12-07 16:29:04 -05003581bool ValidateProgramBinaryBase(Context *context,
3582 GLuint program,
3583 GLenum binaryFormat,
3584 const void *binary,
3585 GLint length)
3586{
3587 Program *programObject = GetValidProgram(context, program);
3588 if (programObject == nullptr)
3589 {
3590 return false;
3591 }
3592
3593 const std::vector<GLenum> &programBinaryFormats = context->getCaps().programBinaryFormats;
3594 if (std::find(programBinaryFormats.begin(), programBinaryFormats.end(), binaryFormat) ==
3595 programBinaryFormats.end())
3596 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003597 context->handleError(InvalidEnum() << "Program binary format is not valid.");
Geoff Langc5629752015-12-07 16:29:04 -05003598 return false;
3599 }
3600
Olli Etuahoc3e55a42016-03-09 16:29:18 +02003601 if (context->hasActiveTransformFeedback(program))
3602 {
3603 // ES 3.0.4 section 2.15 page 91
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003604 context->handleError(InvalidOperation() << "Cannot change program binary while program "
3605 "is associated with an active transform "
3606 "feedback object.");
Olli Etuahoc3e55a42016-03-09 16:29:18 +02003607 return false;
3608 }
3609
Geoff Langc5629752015-12-07 16:29:04 -05003610 return true;
3611}
3612
3613bool ValidateGetProgramBinaryBase(Context *context,
3614 GLuint program,
3615 GLsizei bufSize,
3616 GLsizei *length,
3617 GLenum *binaryFormat,
3618 void *binary)
3619{
3620 Program *programObject = GetValidProgram(context, program);
3621 if (programObject == nullptr)
3622 {
3623 return false;
3624 }
3625
3626 if (!programObject->isLinked())
3627 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003628 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Geoff Langc5629752015-12-07 16:29:04 -05003629 return false;
3630 }
3631
Jamie Madilla7d12dc2016-12-13 15:08:19 -05003632 if (context->getCaps().programBinaryFormats.empty())
3633 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003634 context->handleError(InvalidOperation() << "No program binary formats supported.");
Jamie Madilla7d12dc2016-12-13 15:08:19 -05003635 return false;
3636 }
3637
Geoff Langc5629752015-12-07 16:29:04 -05003638 return true;
3639}
Jamie Madillc29968b2016-01-20 11:17:23 -05003640
Jamie Madillc29968b2016-01-20 11:17:23 -05003641bool ValidateDrawBuffersBase(ValidationContext *context, GLsizei n, const GLenum *bufs)
3642{
3643 // INVALID_VALUE is generated if n is negative or greater than value of MAX_DRAW_BUFFERS
3644 if (n < 0 || static_cast<GLuint>(n) > context->getCaps().maxDrawBuffers)
3645 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003646 context->handleError(InvalidValue()
3647 << "n must be non-negative and no greater than MAX_DRAW_BUFFERS");
Jamie Madillc29968b2016-01-20 11:17:23 -05003648 return false;
3649 }
3650
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003651 ASSERT(context->getGLState().getDrawFramebuffer());
3652 GLuint frameBufferId = context->getGLState().getDrawFramebuffer()->id();
Jamie Madillc29968b2016-01-20 11:17:23 -05003653 GLuint maxColorAttachment = GL_COLOR_ATTACHMENT0_EXT + context->getCaps().maxColorAttachments;
3654
3655 // This should come first before the check for the default frame buffer
3656 // because when we switch to ES3.1+, invalid enums will return INVALID_ENUM
3657 // rather than INVALID_OPERATION
3658 for (int colorAttachment = 0; colorAttachment < n; colorAttachment++)
3659 {
3660 const GLenum attachment = GL_COLOR_ATTACHMENT0_EXT + colorAttachment;
3661
3662 if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != GL_BACK &&
Olli Etuaho84c9f592016-03-09 14:37:25 +02003663 (bufs[colorAttachment] < GL_COLOR_ATTACHMENT0 ||
3664 bufs[colorAttachment] > GL_COLOR_ATTACHMENT31))
Jamie Madillc29968b2016-01-20 11:17:23 -05003665 {
3666 // Value in bufs is not NONE, BACK, or GL_COLOR_ATTACHMENTi
Olli Etuaho84c9f592016-03-09 14:37:25 +02003667 // The 3.0.4 spec says to generate GL_INVALID_OPERATION here, but this
3668 // was changed to GL_INVALID_ENUM in 3.1, which dEQP also expects.
3669 // 3.1 is still a bit ambiguous about the error, but future specs are
3670 // expected to clarify that GL_INVALID_ENUM is the correct error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003671 context->handleError(InvalidEnum() << "Invalid buffer value");
Olli Etuaho84c9f592016-03-09 14:37:25 +02003672 return false;
3673 }
3674 else if (bufs[colorAttachment] >= maxColorAttachment)
3675 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003676 context->handleError(InvalidOperation()
3677 << "Buffer value is greater than MAX_DRAW_BUFFERS");
Jamie Madillc29968b2016-01-20 11:17:23 -05003678 return false;
3679 }
3680 else if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != attachment &&
3681 frameBufferId != 0)
3682 {
3683 // INVALID_OPERATION-GL is bound to buffer and ith argument
3684 // is not COLOR_ATTACHMENTi or NONE
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003685 context->handleError(InvalidOperation()
3686 << "Ith value does not match COLOR_ATTACHMENTi or NONE");
Jamie Madillc29968b2016-01-20 11:17:23 -05003687 return false;
3688 }
3689 }
3690
3691 // INVALID_OPERATION is generated if GL is bound to the default framebuffer
3692 // and n is not 1 or bufs is bound to value other than BACK and NONE
3693 if (frameBufferId == 0)
3694 {
3695 if (n != 1)
3696 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003697 context->handleError(InvalidOperation()
3698 << "n must be 1 when GL is bound to the default framebuffer");
Jamie Madillc29968b2016-01-20 11:17:23 -05003699 return false;
3700 }
3701
3702 if (bufs[0] != GL_NONE && bufs[0] != GL_BACK)
3703 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003704 context->handleError(
3705 InvalidOperation()
3706 << "Only NONE or BACK are valid values when drawing to the default framebuffer");
Jamie Madillc29968b2016-01-20 11:17:23 -05003707 return false;
3708 }
3709 }
3710
3711 return true;
3712}
3713
Geoff Lang496c02d2016-10-20 11:38:11 -07003714bool ValidateGetBufferPointervBase(Context *context,
3715 GLenum target,
3716 GLenum pname,
3717 GLsizei *length,
3718 void **params)
Olli Etuaho4f667482016-03-30 15:56:35 +03003719{
Geoff Lang496c02d2016-10-20 11:38:11 -07003720 if (length)
3721 {
3722 *length = 0;
3723 }
3724
3725 if (context->getClientMajorVersion() < 3 && !context->getExtensions().mapBuffer)
3726 {
3727 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003728 InvalidOperation()
3729 << "Context does not support OpenGL ES 3.0 or GL_OES_mapbuffer is not enabled.");
Geoff Lang496c02d2016-10-20 11:38:11 -07003730 return false;
3731 }
3732
Olli Etuaho4f667482016-03-30 15:56:35 +03003733 if (!ValidBufferTarget(context, target))
3734 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003735 context->handleError(InvalidEnum() << "Buffer target not valid: 0x" << std::hex
3736 << std::uppercase << target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003737 return false;
3738 }
3739
Geoff Lang496c02d2016-10-20 11:38:11 -07003740 switch (pname)
Olli Etuaho4f667482016-03-30 15:56:35 +03003741 {
Geoff Lang496c02d2016-10-20 11:38:11 -07003742 case GL_BUFFER_MAP_POINTER:
3743 break;
Olli Etuaho4f667482016-03-30 15:56:35 +03003744
Geoff Lang496c02d2016-10-20 11:38:11 -07003745 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003746 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang496c02d2016-10-20 11:38:11 -07003747 return false;
3748 }
Olli Etuaho4f667482016-03-30 15:56:35 +03003749
3750 // GLES 3.0 section 2.10.1: "Attempts to attempts to modify or query buffer object state for a
3751 // target bound to zero generate an INVALID_OPERATION error."
3752 // GLES 3.1 section 6.6 explicitly specifies this error.
Geoff Lang496c02d2016-10-20 11:38:11 -07003753 if (context->getGLState().getTargetBuffer(target) == nullptr)
Olli Etuaho4f667482016-03-30 15:56:35 +03003754 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003755 context->handleError(InvalidOperation()
3756 << "Can not get pointer for reserved buffer name zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003757 return false;
3758 }
3759
Geoff Lang496c02d2016-10-20 11:38:11 -07003760 if (length)
3761 {
3762 *length = 1;
3763 }
3764
Olli Etuaho4f667482016-03-30 15:56:35 +03003765 return true;
3766}
3767
3768bool ValidateUnmapBufferBase(Context *context, GLenum target)
3769{
3770 if (!ValidBufferTarget(context, target))
3771 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003772 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003773 return false;
3774 }
3775
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003776 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003777
3778 if (buffer == nullptr || !buffer->isMapped())
3779 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003780 context->handleError(InvalidOperation() << "Buffer not mapped.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003781 return false;
3782 }
3783
3784 return true;
3785}
3786
3787bool ValidateMapBufferRangeBase(Context *context,
3788 GLenum target,
3789 GLintptr offset,
3790 GLsizeiptr length,
3791 GLbitfield access)
3792{
3793 if (!ValidBufferTarget(context, target))
3794 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003795 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003796 return false;
3797 }
3798
Brandon Jones6cad5662017-06-14 13:25:13 -07003799 if (offset < 0)
Olli Etuaho4f667482016-03-30 15:56:35 +03003800 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003801 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
3802 return false;
3803 }
3804
3805 if (length < 0)
3806 {
3807 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength);
Olli Etuaho4f667482016-03-30 15:56:35 +03003808 return false;
3809 }
3810
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003811 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003812
3813 if (!buffer)
3814 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003815 context->handleError(InvalidOperation() << "Attempted to map buffer object zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003816 return false;
3817 }
3818
3819 // Check for buffer overflow
Jamie Madille2e406c2016-06-02 13:04:10 -04003820 CheckedNumeric<size_t> checkedOffset(offset);
3821 auto checkedSize = checkedOffset + length;
Olli Etuaho4f667482016-03-30 15:56:35 +03003822
Jamie Madille2e406c2016-06-02 13:04:10 -04003823 if (!checkedSize.IsValid() || checkedSize.ValueOrDie() > static_cast<size_t>(buffer->getSize()))
Olli Etuaho4f667482016-03-30 15:56:35 +03003824 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003825 context->handleError(InvalidValue() << "Mapped range does not fit into buffer dimensions.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003826 return false;
3827 }
3828
3829 // Check for invalid bits in the mask
3830 GLbitfield allAccessBits = GL_MAP_READ_BIT | GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_RANGE_BIT |
3831 GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_FLUSH_EXPLICIT_BIT |
3832 GL_MAP_UNSYNCHRONIZED_BIT;
3833
3834 if (access & ~(allAccessBits))
3835 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003836 context->handleError(InvalidValue()
3837 << "Invalid access bits: 0x" << std::hex << std::uppercase << access);
Olli Etuaho4f667482016-03-30 15:56:35 +03003838 return false;
3839 }
3840
3841 if (length == 0)
3842 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003843 context->handleError(InvalidOperation() << "Buffer mapping length is zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003844 return false;
3845 }
3846
3847 if (buffer->isMapped())
3848 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003849 context->handleError(InvalidOperation() << "Buffer is already mapped.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003850 return false;
3851 }
3852
3853 // Check for invalid bit combinations
3854 if ((access & (GL_MAP_READ_BIT | GL_MAP_WRITE_BIT)) == 0)
3855 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003856 context->handleError(InvalidOperation()
3857 << "Need to map buffer for either reading or writing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003858 return false;
3859 }
3860
3861 GLbitfield writeOnlyBits =
3862 GL_MAP_INVALIDATE_RANGE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_UNSYNCHRONIZED_BIT;
3863
3864 if ((access & GL_MAP_READ_BIT) != 0 && (access & writeOnlyBits) != 0)
3865 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003866 context->handleError(InvalidOperation()
3867 << "Invalid access bits when mapping buffer for reading: 0x"
3868 << std::hex << std::uppercase << access);
Olli Etuaho4f667482016-03-30 15:56:35 +03003869 return false;
3870 }
3871
3872 if ((access & GL_MAP_WRITE_BIT) == 0 && (access & GL_MAP_FLUSH_EXPLICIT_BIT) != 0)
3873 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003874 context->handleError(
3875 InvalidOperation()
3876 << "The explicit flushing bit may only be set if the buffer is mapped for writing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003877 return false;
3878 }
3879 return true;
3880}
3881
3882bool ValidateFlushMappedBufferRangeBase(Context *context,
3883 GLenum target,
3884 GLintptr offset,
3885 GLsizeiptr length)
3886{
Brandon Jones6cad5662017-06-14 13:25:13 -07003887 if (offset < 0)
Olli Etuaho4f667482016-03-30 15:56:35 +03003888 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003889 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
3890 return false;
3891 }
3892
3893 if (length < 0)
3894 {
3895 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength);
Olli Etuaho4f667482016-03-30 15:56:35 +03003896 return false;
3897 }
3898
3899 if (!ValidBufferTarget(context, target))
3900 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003901 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003902 return false;
3903 }
3904
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003905 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003906
3907 if (buffer == nullptr)
3908 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003909 context->handleError(InvalidOperation() << "Attempted to flush buffer object zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003910 return false;
3911 }
3912
3913 if (!buffer->isMapped() || (buffer->getAccessFlags() & GL_MAP_FLUSH_EXPLICIT_BIT) == 0)
3914 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003915 context->handleError(InvalidOperation()
3916 << "Attempted to flush a buffer not mapped for explicit flushing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003917 return false;
3918 }
3919
3920 // Check for buffer overflow
Jamie Madille2e406c2016-06-02 13:04:10 -04003921 CheckedNumeric<size_t> checkedOffset(offset);
3922 auto checkedSize = checkedOffset + length;
Olli Etuaho4f667482016-03-30 15:56:35 +03003923
Jamie Madille2e406c2016-06-02 13:04:10 -04003924 if (!checkedSize.IsValid() ||
3925 checkedSize.ValueOrDie() > static_cast<size_t>(buffer->getMapLength()))
Olli Etuaho4f667482016-03-30 15:56:35 +03003926 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003927 context->handleError(InvalidValue()
3928 << "Flushed range does not fit into buffer mapping dimensions.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003929 return false;
3930 }
3931
3932 return true;
3933}
3934
Olli Etuaho41997e72016-03-10 13:38:39 +02003935bool ValidateGenOrDelete(Context *context, GLint n)
3936{
3937 if (n < 0)
3938 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003939 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Olli Etuaho41997e72016-03-10 13:38:39 +02003940 return false;
3941 }
3942 return true;
3943}
3944
Geoff Langff5b2d52016-09-07 11:32:23 -04003945bool ValidateRobustEntryPoint(ValidationContext *context, GLsizei bufSize)
3946{
3947 if (!context->getExtensions().robustClientMemory)
3948 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003949 context->handleError(InvalidOperation()
3950 << "GL_ANGLE_robust_client_memory is not available.");
Geoff Langff5b2d52016-09-07 11:32:23 -04003951 return false;
3952 }
3953
3954 if (bufSize < 0)
3955 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003956 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Geoff Langff5b2d52016-09-07 11:32:23 -04003957 return false;
3958 }
3959
3960 return true;
3961}
3962
Geoff Lang2e43dbb2016-10-14 12:27:35 -04003963bool ValidateRobustBufferSize(ValidationContext *context, GLsizei bufSize, GLsizei numParams)
3964{
3965 if (bufSize < numParams)
3966 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003967 context->handleError(InvalidOperation() << numParams << " parameters are required but "
3968 << bufSize << " were provided.");
Geoff Lang2e43dbb2016-10-14 12:27:35 -04003969 return false;
3970 }
3971
3972 return true;
3973}
3974
Jamie Madillbe849e42017-05-02 15:49:00 -04003975bool ValidateGetFramebufferAttachmentParameterivBase(ValidationContext *context,
3976 GLenum target,
3977 GLenum attachment,
3978 GLenum pname,
3979 GLsizei *numParams)
Geoff Langff5b2d52016-09-07 11:32:23 -04003980{
Geoff Langff5b2d52016-09-07 11:32:23 -04003981 if (!ValidFramebufferTarget(target))
3982 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003983 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003984 return false;
3985 }
3986
3987 int clientVersion = context->getClientMajorVersion();
3988
3989 switch (pname)
3990 {
3991 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
3992 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
3993 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL:
3994 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE:
3995 break;
3996
Martin Radeve5285d22017-07-14 16:23:53 +03003997 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_NUM_VIEWS_ANGLE:
3998 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_MULTIVIEW_LAYOUT_ANGLE:
3999 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_BASE_VIEW_INDEX_ANGLE:
4000 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE:
4001 if (clientVersion < 3 || !context->getExtensions().multiview)
4002 {
4003 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
4004 return false;
4005 }
4006 break;
4007
Geoff Langff5b2d52016-09-07 11:32:23 -04004008 case GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING:
4009 if (clientVersion < 3 && !context->getExtensions().sRGB)
4010 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004011 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004012 return false;
4013 }
4014 break;
4015
4016 case GL_FRAMEBUFFER_ATTACHMENT_RED_SIZE:
4017 case GL_FRAMEBUFFER_ATTACHMENT_GREEN_SIZE:
4018 case GL_FRAMEBUFFER_ATTACHMENT_BLUE_SIZE:
4019 case GL_FRAMEBUFFER_ATTACHMENT_ALPHA_SIZE:
4020 case GL_FRAMEBUFFER_ATTACHMENT_DEPTH_SIZE:
4021 case GL_FRAMEBUFFER_ATTACHMENT_STENCIL_SIZE:
4022 case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:
4023 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:
4024 if (clientVersion < 3)
4025 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004026 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004027 return false;
4028 }
4029 break;
4030
4031 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004032 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004033 return false;
4034 }
4035
4036 // Determine if the attachment is a valid enum
4037 switch (attachment)
4038 {
4039 case GL_BACK:
4040 case GL_FRONT:
4041 case GL_DEPTH:
4042 case GL_STENCIL:
4043 case GL_DEPTH_STENCIL_ATTACHMENT:
4044 if (clientVersion < 3)
4045 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004046 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004047 return false;
4048 }
4049 break;
4050
4051 case GL_DEPTH_ATTACHMENT:
4052 case GL_STENCIL_ATTACHMENT:
4053 break;
4054
4055 default:
4056 if (attachment < GL_COLOR_ATTACHMENT0_EXT ||
4057 (attachment - GL_COLOR_ATTACHMENT0_EXT) >= context->getCaps().maxColorAttachments)
4058 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004059 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004060 return false;
4061 }
4062 break;
4063 }
4064
4065 const Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
4066 ASSERT(framebuffer);
4067
4068 if (framebuffer->id() == 0)
4069 {
4070 if (clientVersion < 3)
4071 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004072 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langff5b2d52016-09-07 11:32:23 -04004073 return false;
4074 }
4075
4076 switch (attachment)
4077 {
4078 case GL_BACK:
4079 case GL_DEPTH:
4080 case GL_STENCIL:
4081 break;
4082
4083 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004084 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FramebufferInvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004085 return false;
4086 }
4087 }
4088 else
4089 {
4090 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
4091 {
4092 // Valid attachment query
4093 }
4094 else
4095 {
4096 switch (attachment)
4097 {
4098 case GL_DEPTH_ATTACHMENT:
4099 case GL_STENCIL_ATTACHMENT:
4100 break;
4101
4102 case GL_DEPTH_STENCIL_ATTACHMENT:
4103 if (!framebuffer->hasValidDepthStencil())
4104 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004105 context->handleError(InvalidOperation());
Geoff Langff5b2d52016-09-07 11:32:23 -04004106 return false;
4107 }
4108 break;
4109
4110 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004111 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FramebufferInvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004112 return false;
4113 }
4114 }
4115 }
4116
4117 const FramebufferAttachment *attachmentObject = framebuffer->getAttachment(attachment);
4118 if (attachmentObject)
4119 {
4120 ASSERT(attachmentObject->type() == GL_RENDERBUFFER ||
4121 attachmentObject->type() == GL_TEXTURE ||
4122 attachmentObject->type() == GL_FRAMEBUFFER_DEFAULT);
4123
4124 switch (pname)
4125 {
4126 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
4127 if (attachmentObject->type() != GL_RENDERBUFFER &&
4128 attachmentObject->type() != GL_TEXTURE)
4129 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004130 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004131 return false;
4132 }
4133 break;
4134
4135 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL:
4136 if (attachmentObject->type() != GL_TEXTURE)
4137 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004138 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004139 return false;
4140 }
4141 break;
4142
4143 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE:
4144 if (attachmentObject->type() != GL_TEXTURE)
4145 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004146 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004147 return false;
4148 }
4149 break;
4150
4151 case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:
4152 if (attachment == GL_DEPTH_STENCIL_ATTACHMENT)
4153 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004154 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FramebufferInvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004155 return false;
4156 }
4157 break;
4158
4159 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:
4160 if (attachmentObject->type() != GL_TEXTURE)
4161 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004162 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004163 return false;
4164 }
4165 break;
4166
4167 default:
4168 break;
4169 }
4170 }
4171 else
4172 {
4173 // ES 2.0.25 spec pg 127 states that if the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE
4174 // is NONE, then querying any other pname will generate INVALID_ENUM.
4175
4176 // ES 3.0.2 spec pg 235 states that if the attachment type is none,
4177 // GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME will return zero and be an
4178 // INVALID_OPERATION for all other pnames
4179
4180 switch (pname)
4181 {
4182 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
4183 break;
4184
4185 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
4186 if (clientVersion < 3)
4187 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004188 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
4189 InvalidRenderbufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004190 return false;
4191 }
4192 break;
4193
4194 default:
4195 if (clientVersion < 3)
4196 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004197 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
4198 InvalidRenderbufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004199 return false;
4200 }
4201 else
4202 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004203 ANGLE_VALIDATION_ERR(context, InvalidOperation(),
4204 InvalidRenderbufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004205 return false;
4206 }
4207 }
4208 }
4209
Martin Radeve5285d22017-07-14 16:23:53 +03004210 if (numParams)
4211 {
4212 if (pname == GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE)
4213 {
4214 // Only when the viewport offsets are queried we can have a varying number of output
4215 // parameters.
4216 const int numViews = attachmentObject ? attachmentObject->getNumViews() : 1;
4217 *numParams = numViews * 2;
4218 }
4219 else
4220 {
4221 // For all other queries we can have only one output parameter.
4222 *numParams = 1;
4223 }
4224 }
4225
Geoff Langff5b2d52016-09-07 11:32:23 -04004226 return true;
4227}
4228
4229bool ValidateGetFramebufferAttachmentParameterivRobustANGLE(ValidationContext *context,
4230 GLenum target,
4231 GLenum attachment,
4232 GLenum pname,
4233 GLsizei bufSize,
4234 GLsizei *numParams)
4235{
4236 if (!ValidateRobustEntryPoint(context, bufSize))
4237 {
4238 return false;
4239 }
4240
Jamie Madillbe849e42017-05-02 15:49:00 -04004241 if (!ValidateGetFramebufferAttachmentParameterivBase(context, target, attachment, pname,
4242 numParams))
Geoff Langff5b2d52016-09-07 11:32:23 -04004243 {
4244 return false;
4245 }
4246
4247 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
4248 {
4249 return false;
4250 }
4251
4252 return true;
4253}
4254
Geoff Langff5b2d52016-09-07 11:32:23 -04004255bool ValidateGetBufferParameterivRobustANGLE(ValidationContext *context,
4256 GLenum target,
4257 GLenum pname,
4258 GLsizei bufSize,
Geoff Langebebe1c2016-10-14 12:01:31 -04004259 GLsizei *length,
4260 GLint *params)
Geoff Langff5b2d52016-09-07 11:32:23 -04004261{
4262 if (!ValidateRobustEntryPoint(context, bufSize))
4263 {
4264 return false;
4265 }
4266
Geoff Langebebe1c2016-10-14 12:01:31 -04004267 if (!ValidateGetBufferParameterBase(context, target, pname, false, length))
Geoff Langff5b2d52016-09-07 11:32:23 -04004268 {
4269 return false;
4270 }
4271
Geoff Langebebe1c2016-10-14 12:01:31 -04004272 if (!ValidateRobustBufferSize(context, bufSize, *length))
4273 {
4274 return false;
4275 }
4276
4277 return true;
4278}
4279
4280bool ValidateGetBufferParameteri64v(ValidationContext *context,
4281 GLenum target,
4282 GLenum pname,
4283 GLint64 *params)
4284{
4285 return ValidateGetBufferParameterBase(context, target, pname, false, nullptr);
4286}
4287
4288bool ValidateGetBufferParameteri64vRobustANGLE(ValidationContext *context,
4289 GLenum target,
4290 GLenum pname,
4291 GLsizei bufSize,
4292 GLsizei *length,
4293 GLint64 *params)
4294{
4295 if (!ValidateRobustEntryPoint(context, bufSize))
4296 {
4297 return false;
4298 }
4299
4300 if (!ValidateGetBufferParameterBase(context, target, pname, false, length))
4301 {
4302 return false;
4303 }
4304
4305 if (!ValidateRobustBufferSize(context, bufSize, *length))
Geoff Langff5b2d52016-09-07 11:32:23 -04004306 {
4307 return false;
4308 }
4309
4310 return true;
4311}
4312
Jamie Madillbe849e42017-05-02 15:49:00 -04004313bool ValidateGetProgramivBase(ValidationContext *context,
4314 GLuint program,
4315 GLenum pname,
4316 GLsizei *numParams)
Geoff Langff5b2d52016-09-07 11:32:23 -04004317{
4318 // Currently, all GetProgramiv queries return 1 parameter
Yunchao He33151a52017-04-13 09:58:17 +08004319 if (numParams)
4320 {
4321 *numParams = 1;
4322 }
Geoff Langff5b2d52016-09-07 11:32:23 -04004323
4324 Program *programObject = GetValidProgram(context, program);
4325 if (!programObject)
4326 {
4327 return false;
4328 }
4329
4330 switch (pname)
4331 {
4332 case GL_DELETE_STATUS:
4333 case GL_LINK_STATUS:
4334 case GL_VALIDATE_STATUS:
4335 case GL_INFO_LOG_LENGTH:
4336 case GL_ATTACHED_SHADERS:
4337 case GL_ACTIVE_ATTRIBUTES:
4338 case GL_ACTIVE_ATTRIBUTE_MAX_LENGTH:
4339 case GL_ACTIVE_UNIFORMS:
4340 case GL_ACTIVE_UNIFORM_MAX_LENGTH:
4341 break;
4342
4343 case GL_PROGRAM_BINARY_LENGTH:
4344 if (context->getClientMajorVersion() < 3 && !context->getExtensions().getProgramBinary)
4345 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004346 context->handleError(InvalidEnum() << "Querying GL_PROGRAM_BINARY_LENGTH "
4347 "requires GL_OES_get_program_binary or "
4348 "ES 3.0.");
Geoff Langff5b2d52016-09-07 11:32:23 -04004349 return false;
4350 }
4351 break;
4352
4353 case GL_ACTIVE_UNIFORM_BLOCKS:
4354 case GL_ACTIVE_UNIFORM_BLOCK_MAX_NAME_LENGTH:
4355 case GL_TRANSFORM_FEEDBACK_BUFFER_MODE:
4356 case GL_TRANSFORM_FEEDBACK_VARYINGS:
4357 case GL_TRANSFORM_FEEDBACK_VARYING_MAX_LENGTH:
4358 case GL_PROGRAM_BINARY_RETRIEVABLE_HINT:
4359 if (context->getClientMajorVersion() < 3)
4360 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004361 context->handleError(InvalidEnum() << "Querying requires at least ES 3.0.");
Geoff Langff5b2d52016-09-07 11:32:23 -04004362 return false;
4363 }
4364 break;
4365
Yunchao He61afff12017-03-14 15:34:03 +08004366 case GL_PROGRAM_SEPARABLE:
4367 if (context->getClientVersion() < Version(3, 1))
4368 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004369 context->handleError(InvalidEnum() << "Querying requires at least ES 3.1.");
Yunchao He61afff12017-03-14 15:34:03 +08004370 return false;
4371 }
4372 break;
4373
Geoff Langff5b2d52016-09-07 11:32:23 -04004374 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004375 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langff5b2d52016-09-07 11:32:23 -04004376 return false;
4377 }
4378
4379 return true;
4380}
4381
4382bool ValidateGetProgramivRobustANGLE(Context *context,
4383 GLuint program,
4384 GLenum pname,
4385 GLsizei bufSize,
4386 GLsizei *numParams)
4387{
4388 if (!ValidateRobustEntryPoint(context, bufSize))
4389 {
4390 return false;
4391 }
4392
Jamie Madillbe849e42017-05-02 15:49:00 -04004393 if (!ValidateGetProgramivBase(context, program, pname, numParams))
Geoff Langff5b2d52016-09-07 11:32:23 -04004394 {
4395 return false;
4396 }
4397
4398 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
4399 {
4400 return false;
4401 }
4402
4403 return true;
4404}
4405
Geoff Lang740d9022016-10-07 11:20:52 -04004406bool ValidateGetRenderbufferParameterivRobustANGLE(Context *context,
4407 GLenum target,
4408 GLenum pname,
4409 GLsizei bufSize,
4410 GLsizei *length,
4411 GLint *params)
4412{
4413 if (!ValidateRobustEntryPoint(context, bufSize))
4414 {
4415 return false;
4416 }
4417
4418 if (!ValidateGetRenderbufferParameterivBase(context, target, pname, length))
4419 {
4420 return false;
4421 }
4422
4423 if (!ValidateRobustBufferSize(context, bufSize, *length))
4424 {
4425 return false;
4426 }
4427
4428 return true;
4429}
4430
Geoff Langd7d0ed32016-10-07 11:33:51 -04004431bool ValidateGetShaderivRobustANGLE(Context *context,
4432 GLuint shader,
4433 GLenum pname,
4434 GLsizei bufSize,
4435 GLsizei *length,
4436 GLint *params)
4437{
4438 if (!ValidateRobustEntryPoint(context, bufSize))
4439 {
4440 return false;
4441 }
4442
4443 if (!ValidateGetShaderivBase(context, shader, pname, length))
4444 {
4445 return false;
4446 }
4447
4448 if (!ValidateRobustBufferSize(context, bufSize, *length))
4449 {
4450 return false;
4451 }
4452
4453 return true;
4454}
4455
Geoff Langc1984ed2016-10-07 12:41:00 -04004456bool ValidateGetTexParameterfvRobustANGLE(Context *context,
4457 GLenum target,
4458 GLenum pname,
4459 GLsizei bufSize,
4460 GLsizei *length,
4461 GLfloat *params)
4462{
4463 if (!ValidateRobustEntryPoint(context, bufSize))
4464 {
4465 return false;
4466 }
4467
4468 if (!ValidateGetTexParameterBase(context, target, pname, length))
4469 {
4470 return false;
4471 }
4472
4473 if (!ValidateRobustBufferSize(context, bufSize, *length))
4474 {
4475 return false;
4476 }
4477
4478 return true;
4479}
4480
Geoff Langc1984ed2016-10-07 12:41:00 -04004481bool ValidateGetTexParameterivRobustANGLE(Context *context,
4482 GLenum target,
4483 GLenum pname,
4484 GLsizei bufSize,
4485 GLsizei *length,
4486 GLint *params)
4487{
4488 if (!ValidateRobustEntryPoint(context, bufSize))
4489 {
4490 return false;
4491 }
4492
4493 if (!ValidateGetTexParameterBase(context, target, pname, length))
4494 {
4495 return false;
4496 }
4497
4498 if (!ValidateRobustBufferSize(context, bufSize, *length))
4499 {
4500 return false;
4501 }
4502
4503 return true;
4504}
4505
Geoff Langc1984ed2016-10-07 12:41:00 -04004506bool ValidateTexParameterfvRobustANGLE(Context *context,
4507 GLenum target,
4508 GLenum pname,
4509 GLsizei bufSize,
4510 const GLfloat *params)
4511{
4512 if (!ValidateRobustEntryPoint(context, bufSize))
4513 {
4514 return false;
4515 }
4516
4517 return ValidateTexParameterBase(context, target, pname, bufSize, params);
4518}
4519
Geoff Langc1984ed2016-10-07 12:41:00 -04004520bool ValidateTexParameterivRobustANGLE(Context *context,
4521 GLenum target,
4522 GLenum pname,
4523 GLsizei bufSize,
4524 const GLint *params)
4525{
4526 if (!ValidateRobustEntryPoint(context, bufSize))
4527 {
4528 return false;
4529 }
4530
4531 return ValidateTexParameterBase(context, target, pname, bufSize, params);
4532}
4533
4534bool ValidateGetSamplerParameterfv(Context *context, GLuint sampler, GLenum pname, GLfloat *params)
4535{
4536 return ValidateGetSamplerParameterBase(context, sampler, pname, nullptr);
4537}
4538
4539bool ValidateGetSamplerParameterfvRobustANGLE(Context *context,
4540 GLuint sampler,
4541 GLenum pname,
4542 GLuint bufSize,
4543 GLsizei *length,
4544 GLfloat *params)
4545{
4546 if (!ValidateRobustEntryPoint(context, bufSize))
4547 {
4548 return false;
4549 }
4550
4551 if (!ValidateGetSamplerParameterBase(context, sampler, pname, length))
4552 {
4553 return false;
4554 }
4555
4556 if (!ValidateRobustBufferSize(context, bufSize, *length))
4557 {
4558 return false;
4559 }
4560
4561 return true;
4562}
4563
4564bool ValidateGetSamplerParameteriv(Context *context, GLuint sampler, GLenum pname, GLint *params)
4565{
4566 return ValidateGetSamplerParameterBase(context, sampler, pname, nullptr);
4567}
4568
4569bool ValidateGetSamplerParameterivRobustANGLE(Context *context,
4570 GLuint sampler,
4571 GLenum pname,
4572 GLuint bufSize,
4573 GLsizei *length,
4574 GLint *params)
4575{
4576 if (!ValidateRobustEntryPoint(context, bufSize))
4577 {
4578 return false;
4579 }
4580
4581 if (!ValidateGetSamplerParameterBase(context, sampler, pname, length))
4582 {
4583 return false;
4584 }
4585
4586 if (!ValidateRobustBufferSize(context, bufSize, *length))
4587 {
4588 return false;
4589 }
4590
4591 return true;
4592}
4593
4594bool ValidateSamplerParameterf(Context *context, GLuint sampler, GLenum pname, GLfloat param)
4595{
4596 return ValidateSamplerParameterBase(context, sampler, pname, -1, &param);
4597}
4598
4599bool ValidateSamplerParameterfv(Context *context,
4600 GLuint sampler,
4601 GLenum pname,
4602 const GLfloat *params)
4603{
4604 return ValidateSamplerParameterBase(context, sampler, pname, -1, params);
4605}
4606
4607bool ValidateSamplerParameterfvRobustANGLE(Context *context,
4608 GLuint sampler,
4609 GLenum pname,
4610 GLsizei bufSize,
4611 const GLfloat *params)
4612{
4613 if (!ValidateRobustEntryPoint(context, bufSize))
4614 {
4615 return false;
4616 }
4617
4618 return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params);
4619}
4620
4621bool ValidateSamplerParameteri(Context *context, GLuint sampler, GLenum pname, GLint param)
4622{
4623 return ValidateSamplerParameterBase(context, sampler, pname, -1, &param);
4624}
4625
4626bool ValidateSamplerParameteriv(Context *context, GLuint sampler, GLenum pname, const GLint *params)
4627{
4628 return ValidateSamplerParameterBase(context, sampler, pname, -1, params);
4629}
4630
4631bool ValidateSamplerParameterivRobustANGLE(Context *context,
4632 GLuint sampler,
4633 GLenum pname,
4634 GLsizei bufSize,
4635 const GLint *params)
4636{
4637 if (!ValidateRobustEntryPoint(context, bufSize))
4638 {
4639 return false;
4640 }
4641
4642 return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params);
4643}
4644
Geoff Lang0b031062016-10-13 14:30:04 -04004645bool ValidateGetVertexAttribfvRobustANGLE(Context *context,
4646 GLuint index,
4647 GLenum pname,
4648 GLsizei bufSize,
4649 GLsizei *length,
4650 GLfloat *params)
4651{
4652 if (!ValidateRobustEntryPoint(context, bufSize))
4653 {
4654 return false;
4655 }
4656
4657 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false))
4658 {
4659 return false;
4660 }
4661
4662 if (!ValidateRobustBufferSize(context, bufSize, *length))
4663 {
4664 return false;
4665 }
4666
4667 return true;
4668}
4669
Geoff Lang0b031062016-10-13 14:30:04 -04004670bool ValidateGetVertexAttribivRobustANGLE(Context *context,
4671 GLuint index,
4672 GLenum pname,
4673 GLsizei bufSize,
4674 GLsizei *length,
4675 GLint *params)
4676{
4677 if (!ValidateRobustEntryPoint(context, bufSize))
4678 {
4679 return false;
4680 }
4681
4682 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false))
4683 {
4684 return false;
4685 }
4686
4687 if (!ValidateRobustBufferSize(context, bufSize, *length))
4688 {
4689 return false;
4690 }
4691
4692 return true;
4693}
4694
Geoff Lang0b031062016-10-13 14:30:04 -04004695bool ValidateGetVertexAttribPointervRobustANGLE(Context *context,
4696 GLuint index,
4697 GLenum pname,
4698 GLsizei bufSize,
4699 GLsizei *length,
4700 void **pointer)
4701{
4702 if (!ValidateRobustEntryPoint(context, bufSize))
4703 {
4704 return false;
4705 }
4706
4707 if (!ValidateGetVertexAttribBase(context, index, pname, length, true, false))
4708 {
4709 return false;
4710 }
4711
4712 if (!ValidateRobustBufferSize(context, bufSize, *length))
4713 {
4714 return false;
4715 }
4716
4717 return true;
4718}
4719
4720bool ValidateGetVertexAttribIiv(Context *context, GLuint index, GLenum pname, GLint *params)
4721{
4722 return ValidateGetVertexAttribBase(context, index, pname, nullptr, false, true);
4723}
4724
4725bool ValidateGetVertexAttribIivRobustANGLE(Context *context,
4726 GLuint index,
4727 GLenum pname,
4728 GLsizei bufSize,
4729 GLsizei *length,
4730 GLint *params)
4731{
4732 if (!ValidateRobustEntryPoint(context, bufSize))
4733 {
4734 return false;
4735 }
4736
4737 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true))
4738 {
4739 return false;
4740 }
4741
4742 if (!ValidateRobustBufferSize(context, bufSize, *length))
4743 {
4744 return false;
4745 }
4746
4747 return true;
4748}
4749
4750bool ValidateGetVertexAttribIuiv(Context *context, GLuint index, GLenum pname, GLuint *params)
4751{
4752 return ValidateGetVertexAttribBase(context, index, pname, nullptr, false, true);
4753}
4754
4755bool ValidateGetVertexAttribIuivRobustANGLE(Context *context,
4756 GLuint index,
4757 GLenum pname,
4758 GLsizei bufSize,
4759 GLsizei *length,
4760 GLuint *params)
4761{
4762 if (!ValidateRobustEntryPoint(context, bufSize))
4763 {
4764 return false;
4765 }
4766
4767 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true))
4768 {
4769 return false;
4770 }
4771
4772 if (!ValidateRobustBufferSize(context, bufSize, *length))
4773 {
4774 return false;
4775 }
4776
4777 return true;
4778}
4779
Geoff Lang6899b872016-10-14 11:30:13 -04004780bool ValidateGetActiveUniformBlockiv(Context *context,
4781 GLuint program,
4782 GLuint uniformBlockIndex,
4783 GLenum pname,
4784 GLint *params)
4785{
4786 return ValidateGetActiveUniformBlockivBase(context, program, uniformBlockIndex, pname, nullptr);
4787}
4788
4789bool ValidateGetActiveUniformBlockivRobustANGLE(Context *context,
4790 GLuint program,
4791 GLuint uniformBlockIndex,
4792 GLenum pname,
4793 GLsizei bufSize,
4794 GLsizei *length,
4795 GLint *params)
4796{
4797 if (!ValidateRobustEntryPoint(context, bufSize))
4798 {
4799 return false;
4800 }
4801
4802 if (!ValidateGetActiveUniformBlockivBase(context, program, uniformBlockIndex, pname, length))
4803 {
4804 return false;
4805 }
4806
4807 if (!ValidateRobustBufferSize(context, bufSize, *length))
4808 {
4809 return false;
4810 }
4811
4812 return true;
4813}
4814
Geoff Lang0a9661f2016-10-20 10:59:20 -07004815bool ValidateGetInternalFormativ(Context *context,
4816 GLenum target,
4817 GLenum internalformat,
4818 GLenum pname,
4819 GLsizei bufSize,
4820 GLint *params)
4821{
4822 return ValidateGetInternalFormativBase(context, target, internalformat, pname, bufSize,
4823 nullptr);
4824}
4825
4826bool ValidateGetInternalFormativRobustANGLE(Context *context,
4827 GLenum target,
4828 GLenum internalformat,
4829 GLenum pname,
4830 GLsizei bufSize,
4831 GLsizei *length,
4832 GLint *params)
4833{
4834 if (!ValidateRobustEntryPoint(context, bufSize))
4835 {
4836 return false;
4837 }
4838
4839 if (!ValidateGetInternalFormativBase(context, target, internalformat, pname, bufSize, length))
4840 {
4841 return false;
4842 }
4843
4844 if (!ValidateRobustBufferSize(context, bufSize, *length))
4845 {
4846 return false;
4847 }
4848
4849 return true;
4850}
4851
Shao80957d92017-02-20 21:25:59 +08004852bool ValidateVertexFormatBase(ValidationContext *context,
4853 GLuint attribIndex,
4854 GLint size,
4855 GLenum type,
4856 GLboolean pureInteger)
4857{
4858 const Caps &caps = context->getCaps();
4859 if (attribIndex >= caps.maxVertexAttributes)
4860 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004861 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMax);
Shao80957d92017-02-20 21:25:59 +08004862 return false;
4863 }
4864
4865 if (size < 1 || size > 4)
4866 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004867 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidVertexAttrSize);
Geoff Lang8700a982017-06-13 10:15:13 -04004868 return false;
Shao80957d92017-02-20 21:25:59 +08004869 }
4870
4871 switch (type)
4872 {
4873 case GL_BYTE:
4874 case GL_UNSIGNED_BYTE:
4875 case GL_SHORT:
4876 case GL_UNSIGNED_SHORT:
4877 break;
4878
4879 case GL_INT:
4880 case GL_UNSIGNED_INT:
4881 if (context->getClientMajorVersion() < 3)
4882 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004883 context->handleError(InvalidEnum()
4884 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004885 return false;
4886 }
4887 break;
4888
4889 case GL_FIXED:
4890 case GL_FLOAT:
4891 if (pureInteger)
4892 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004893 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004894 return false;
4895 }
4896 break;
4897
4898 case GL_HALF_FLOAT:
4899 if (context->getClientMajorVersion() < 3)
4900 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004901 context->handleError(InvalidEnum()
4902 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004903 return false;
4904 }
4905 if (pureInteger)
4906 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004907 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004908 return false;
4909 }
4910 break;
4911
4912 case GL_INT_2_10_10_10_REV:
4913 case GL_UNSIGNED_INT_2_10_10_10_REV:
4914 if (context->getClientMajorVersion() < 3)
4915 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004916 context->handleError(InvalidEnum()
4917 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004918 return false;
4919 }
4920 if (pureInteger)
4921 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004922 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004923 return false;
4924 }
4925 if (size != 4)
4926 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004927 context->handleError(InvalidOperation() << "Type is INT_2_10_10_10_REV or "
4928 "UNSIGNED_INT_2_10_10_10_REV and "
4929 "size is not 4.");
Shao80957d92017-02-20 21:25:59 +08004930 return false;
4931 }
4932 break;
4933
4934 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004935 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidType);
Shao80957d92017-02-20 21:25:59 +08004936 return false;
4937 }
4938
4939 return true;
4940}
4941
Geoff Lang76e65652017-03-27 14:58:02 -04004942// Perform validation from WebGL 2 section 5.10 "Invalid Clears":
4943// In the WebGL 2 API, trying to perform a clear when there is a mismatch between the type of the
4944// specified clear value and the type of a buffer that is being cleared generates an
4945// INVALID_OPERATION error instead of producing undefined results
4946bool ValidateWebGLFramebufferAttachmentClearType(ValidationContext *context,
4947 GLint drawbuffer,
4948 const GLenum *validComponentTypes,
4949 size_t validComponentTypeCount)
4950{
4951 const FramebufferAttachment *attachment =
4952 context->getGLState().getDrawFramebuffer()->getDrawBuffer(drawbuffer);
4953 if (attachment)
4954 {
4955 GLenum componentType = attachment->getFormat().info->componentType;
4956 const GLenum *end = validComponentTypes + validComponentTypeCount;
4957 if (std::find(validComponentTypes, end, componentType) == end)
4958 {
4959 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004960 InvalidOperation()
4961 << "No defined conversion between clear value and attachment format.");
Geoff Lang76e65652017-03-27 14:58:02 -04004962 return false;
4963 }
4964 }
4965
4966 return true;
4967}
4968
Corentin Wallezb2931602017-04-11 15:58:57 -04004969bool ValidateRobustCompressedTexImageBase(ValidationContext *context,
4970 GLsizei imageSize,
4971 GLsizei dataSize)
4972{
4973 if (!ValidateRobustEntryPoint(context, dataSize))
4974 {
4975 return false;
4976 }
4977
4978 gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
4979 if (pixelUnpackBuffer == nullptr)
4980 {
4981 if (dataSize < imageSize)
4982 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004983 context->handleError(InvalidOperation() << "dataSize must be at least " << imageSize);
Corentin Wallezb2931602017-04-11 15:58:57 -04004984 }
4985 }
4986 return true;
4987}
4988
Jamie Madillbe849e42017-05-02 15:49:00 -04004989bool ValidateGetBufferParameterBase(ValidationContext *context,
4990 GLenum target,
4991 GLenum pname,
4992 bool pointerVersion,
4993 GLsizei *numParams)
4994{
4995 if (numParams)
4996 {
4997 *numParams = 0;
4998 }
4999
5000 if (!ValidBufferTarget(context, target))
5001 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005002 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Jamie Madillbe849e42017-05-02 15:49:00 -04005003 return false;
5004 }
5005
5006 const Buffer *buffer = context->getGLState().getTargetBuffer(target);
5007 if (!buffer)
5008 {
5009 // A null buffer means that "0" is bound to the requested buffer target
Brandon Jones6cad5662017-06-14 13:25:13 -07005010 ANGLE_VALIDATION_ERR(context, InvalidOperation(), BufferNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005011 return false;
5012 }
5013
5014 const Extensions &extensions = context->getExtensions();
5015
5016 switch (pname)
5017 {
5018 case GL_BUFFER_USAGE:
5019 case GL_BUFFER_SIZE:
5020 break;
5021
5022 case GL_BUFFER_ACCESS_OES:
5023 if (!extensions.mapBuffer)
5024 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005025 context->handleError(InvalidEnum()
5026 << "pname requires OpenGL ES 3.0 or GL_OES_mapbuffer.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005027 return false;
5028 }
5029 break;
5030
5031 case GL_BUFFER_MAPPED:
5032 static_assert(GL_BUFFER_MAPPED == GL_BUFFER_MAPPED_OES, "GL enums should be equal.");
5033 if (context->getClientMajorVersion() < 3 && !extensions.mapBuffer &&
5034 !extensions.mapBufferRange)
5035 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005036 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0, "
5037 "GL_OES_mapbuffer or "
5038 "GL_EXT_map_buffer_range.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005039 return false;
5040 }
5041 break;
5042
5043 case GL_BUFFER_MAP_POINTER:
5044 if (!pointerVersion)
5045 {
5046 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005047 InvalidEnum()
5048 << "GL_BUFFER_MAP_POINTER can only be queried with GetBufferPointerv.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005049 return false;
5050 }
5051 break;
5052
5053 case GL_BUFFER_ACCESS_FLAGS:
5054 case GL_BUFFER_MAP_OFFSET:
5055 case GL_BUFFER_MAP_LENGTH:
5056 if (context->getClientMajorVersion() < 3 && !extensions.mapBufferRange)
5057 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005058 context->handleError(InvalidEnum()
5059 << "pname requires OpenGL ES 3.0 or GL_EXT_map_buffer_range.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005060 return false;
5061 }
5062 break;
5063
5064 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005065 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005066 return false;
5067 }
5068
5069 // All buffer parameter queries return one value.
5070 if (numParams)
5071 {
5072 *numParams = 1;
5073 }
5074
5075 return true;
5076}
5077
5078bool ValidateGetRenderbufferParameterivBase(Context *context,
5079 GLenum target,
5080 GLenum pname,
5081 GLsizei *length)
5082{
5083 if (length)
5084 {
5085 *length = 0;
5086 }
5087
5088 if (target != GL_RENDERBUFFER)
5089 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005090 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005091 return false;
5092 }
5093
5094 Renderbuffer *renderbuffer = context->getGLState().getCurrentRenderbuffer();
5095 if (renderbuffer == nullptr)
5096 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005097 ANGLE_VALIDATION_ERR(context, InvalidOperation(), RenderbufferNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005098 return false;
5099 }
5100
5101 switch (pname)
5102 {
5103 case GL_RENDERBUFFER_WIDTH:
5104 case GL_RENDERBUFFER_HEIGHT:
5105 case GL_RENDERBUFFER_INTERNAL_FORMAT:
5106 case GL_RENDERBUFFER_RED_SIZE:
5107 case GL_RENDERBUFFER_GREEN_SIZE:
5108 case GL_RENDERBUFFER_BLUE_SIZE:
5109 case GL_RENDERBUFFER_ALPHA_SIZE:
5110 case GL_RENDERBUFFER_DEPTH_SIZE:
5111 case GL_RENDERBUFFER_STENCIL_SIZE:
5112 break;
5113
5114 case GL_RENDERBUFFER_SAMPLES_ANGLE:
5115 if (!context->getExtensions().framebufferMultisample)
5116 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005117 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005118 return false;
5119 }
5120 break;
5121
5122 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005123 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005124 return false;
5125 }
5126
5127 if (length)
5128 {
5129 *length = 1;
5130 }
5131 return true;
5132}
5133
5134bool ValidateGetShaderivBase(Context *context, GLuint shader, GLenum pname, GLsizei *length)
5135{
5136 if (length)
5137 {
5138 *length = 0;
5139 }
5140
5141 if (GetValidShader(context, shader) == nullptr)
5142 {
5143 return false;
5144 }
5145
5146 switch (pname)
5147 {
5148 case GL_SHADER_TYPE:
5149 case GL_DELETE_STATUS:
5150 case GL_COMPILE_STATUS:
5151 case GL_INFO_LOG_LENGTH:
5152 case GL_SHADER_SOURCE_LENGTH:
5153 break;
5154
5155 case GL_TRANSLATED_SHADER_SOURCE_LENGTH_ANGLE:
5156 if (!context->getExtensions().translatedShaderSource)
5157 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005158 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005159 return false;
5160 }
5161 break;
5162
5163 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005164 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005165 return false;
5166 }
5167
5168 if (length)
5169 {
5170 *length = 1;
5171 }
5172 return true;
5173}
5174
5175bool ValidateGetTexParameterBase(Context *context, GLenum target, GLenum pname, GLsizei *length)
5176{
5177 if (length)
5178 {
5179 *length = 0;
5180 }
5181
5182 if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
5183 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005184 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005185 return false;
5186 }
5187
5188 if (context->getTargetTexture(target) == nullptr)
5189 {
5190 // Should only be possible for external textures
Brandon Jones6cad5662017-06-14 13:25:13 -07005191 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005192 return false;
5193 }
5194
5195 switch (pname)
5196 {
5197 case GL_TEXTURE_MAG_FILTER:
5198 case GL_TEXTURE_MIN_FILTER:
5199 case GL_TEXTURE_WRAP_S:
5200 case GL_TEXTURE_WRAP_T:
5201 break;
5202
5203 case GL_TEXTURE_USAGE_ANGLE:
5204 if (!context->getExtensions().textureUsage)
5205 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005206 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005207 return false;
5208 }
5209 break;
5210
5211 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
5212 if (!context->getExtensions().textureFilterAnisotropic)
5213 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005214 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005215 return false;
5216 }
5217 break;
5218
5219 case GL_TEXTURE_IMMUTABLE_FORMAT:
5220 if (context->getClientMajorVersion() < 3 && !context->getExtensions().textureStorage)
5221 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005222 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005223 return false;
5224 }
5225 break;
5226
5227 case GL_TEXTURE_WRAP_R:
5228 case GL_TEXTURE_IMMUTABLE_LEVELS:
5229 case GL_TEXTURE_SWIZZLE_R:
5230 case GL_TEXTURE_SWIZZLE_G:
5231 case GL_TEXTURE_SWIZZLE_B:
5232 case GL_TEXTURE_SWIZZLE_A:
5233 case GL_TEXTURE_BASE_LEVEL:
5234 case GL_TEXTURE_MAX_LEVEL:
5235 case GL_TEXTURE_MIN_LOD:
5236 case GL_TEXTURE_MAX_LOD:
5237 case GL_TEXTURE_COMPARE_MODE:
5238 case GL_TEXTURE_COMPARE_FUNC:
5239 if (context->getClientMajorVersion() < 3)
5240 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005241 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005242 return false;
5243 }
5244 break;
5245
5246 case GL_TEXTURE_SRGB_DECODE_EXT:
5247 if (!context->getExtensions().textureSRGBDecode)
5248 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005249 context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005250 return false;
5251 }
5252 break;
5253
5254 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005255 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005256 return false;
5257 }
5258
5259 if (length)
5260 {
5261 *length = 1;
5262 }
5263 return true;
5264}
5265
5266bool ValidateGetVertexAttribBase(Context *context,
5267 GLuint index,
5268 GLenum pname,
5269 GLsizei *length,
5270 bool pointer,
5271 bool pureIntegerEntryPoint)
5272{
5273 if (length)
5274 {
5275 *length = 0;
5276 }
5277
5278 if (pureIntegerEntryPoint && context->getClientMajorVersion() < 3)
5279 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005280 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005281 return false;
5282 }
5283
5284 if (index >= context->getCaps().maxVertexAttributes)
5285 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005286 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMax);
Jamie Madillbe849e42017-05-02 15:49:00 -04005287 return false;
5288 }
5289
5290 if (pointer)
5291 {
5292 if (pname != GL_VERTEX_ATTRIB_ARRAY_POINTER)
5293 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005294 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005295 return false;
5296 }
5297 }
5298 else
5299 {
5300 switch (pname)
5301 {
5302 case GL_VERTEX_ATTRIB_ARRAY_ENABLED:
5303 case GL_VERTEX_ATTRIB_ARRAY_SIZE:
5304 case GL_VERTEX_ATTRIB_ARRAY_STRIDE:
5305 case GL_VERTEX_ATTRIB_ARRAY_TYPE:
5306 case GL_VERTEX_ATTRIB_ARRAY_NORMALIZED:
5307 case GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING:
5308 case GL_CURRENT_VERTEX_ATTRIB:
5309 break;
5310
5311 case GL_VERTEX_ATTRIB_ARRAY_DIVISOR:
5312 static_assert(
5313 GL_VERTEX_ATTRIB_ARRAY_DIVISOR == GL_VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE,
5314 "ANGLE extension enums not equal to GL enums.");
5315 if (context->getClientMajorVersion() < 3 &&
5316 !context->getExtensions().instancedArrays)
5317 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005318 context->handleError(InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_DIVISOR "
5319 "requires OpenGL ES 3.0 or "
5320 "GL_ANGLE_instanced_arrays.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005321 return false;
5322 }
5323 break;
5324
5325 case GL_VERTEX_ATTRIB_ARRAY_INTEGER:
5326 if (context->getClientMajorVersion() < 3)
5327 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005328 context->handleError(
5329 InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_INTEGER requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005330 return false;
5331 }
5332 break;
5333
5334 case GL_VERTEX_ATTRIB_BINDING:
5335 case GL_VERTEX_ATTRIB_RELATIVE_OFFSET:
5336 if (context->getClientVersion() < ES_3_1)
5337 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005338 context->handleError(InvalidEnum()
5339 << "Vertex Attrib Bindings require OpenGL ES 3.1.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005340 return false;
5341 }
5342 break;
5343
5344 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005345 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005346 return false;
5347 }
5348 }
5349
5350 if (length)
5351 {
5352 if (pname == GL_CURRENT_VERTEX_ATTRIB)
5353 {
5354 *length = 4;
5355 }
5356 else
5357 {
5358 *length = 1;
5359 }
5360 }
5361
5362 return true;
5363}
5364
Jamie Madill4928b7c2017-06-20 12:57:39 -04005365bool ValidateReadPixelsBase(Context *context,
Jamie Madillbe849e42017-05-02 15:49:00 -04005366 GLint x,
5367 GLint y,
5368 GLsizei width,
5369 GLsizei height,
5370 GLenum format,
5371 GLenum type,
5372 GLsizei bufSize,
5373 GLsizei *length,
5374 GLsizei *columns,
5375 GLsizei *rows,
5376 void *pixels)
5377{
5378 if (length != nullptr)
5379 {
5380 *length = 0;
5381 }
5382 if (rows != nullptr)
5383 {
5384 *rows = 0;
5385 }
5386 if (columns != nullptr)
5387 {
5388 *columns = 0;
5389 }
5390
5391 if (width < 0 || height < 0)
5392 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005393 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005394 return false;
5395 }
5396
5397 auto readFramebuffer = context->getGLState().getReadFramebuffer();
5398
5399 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
5400 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005401 context->handleError(InvalidFramebufferOperation());
Jamie Madillbe849e42017-05-02 15:49:00 -04005402 return false;
5403 }
5404
5405 if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0)
5406 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005407 context->handleError(InvalidOperation());
Jamie Madillbe849e42017-05-02 15:49:00 -04005408 return false;
5409 }
5410
5411 const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer();
5412 ASSERT(framebuffer);
5413
5414 if (framebuffer->getReadBufferState() == GL_NONE)
5415 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005416 context->handleError(InvalidOperation() << "Read buffer is GL_NONE");
Jamie Madillbe849e42017-05-02 15:49:00 -04005417 return false;
5418 }
5419
5420 const FramebufferAttachment *readBuffer = framebuffer->getReadColorbuffer();
5421 // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment
5422 // In OpenGL ES it is undefined what happens when an operation tries to read from a missing
5423 // attachment and WebGL defines it to be an error. We do the check unconditionnaly as the
5424 // situation is an application error that would lead to a crash in ANGLE.
5425 if (readBuffer == nullptr)
5426 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005427 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment);
Jamie Madillbe849e42017-05-02 15:49:00 -04005428 return false;
5429 }
5430
Geoff Lang280ba992017-04-18 16:30:58 -04005431 if (context->getExtensions().webglCompatibility)
5432 {
5433 // The ES 2.0 spec states that the format must be "among those defined in table 3.4,
5434 // excluding formats LUMINANCE and LUMINANCE_ALPHA.". This requires validating the format
5435 // and type before validating the combination of format and type. However, the
5436 // dEQP-GLES3.functional.negative_api.buffer.read_pixels passes GL_LUMINANCE as a format and
5437 // verifies that GL_INVALID_OPERATION is generated.
5438 // TODO(geofflang): Update this check to be done in all/no cases once this is resolved in
5439 // dEQP/WebGL.
5440 if (!ValidReadPixelsFormatEnum(context, format))
5441 {
5442 context->handleError(InvalidEnum() << "Invalid read format.");
5443 return false;
5444 }
5445
5446 if (!ValidReadPixelsTypeEnum(context, type))
5447 {
5448 context->handleError(InvalidEnum() << "Invalid read type.");
5449 return false;
5450 }
5451 }
5452
Jamie Madill4928b7c2017-06-20 12:57:39 -04005453 GLenum currentFormat = framebuffer->getImplementationColorReadFormat(context);
5454 GLenum currentType = framebuffer->getImplementationColorReadType(context);
Jamie Madillbe849e42017-05-02 15:49:00 -04005455 GLenum currentComponentType = readBuffer->getFormat().info->componentType;
5456
5457 bool validFormatTypeCombination =
5458 ValidReadPixelsFormatType(context, currentComponentType, format, type);
5459
5460 if (!(currentFormat == format && currentType == type) && !validFormatTypeCombination)
5461 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005462 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MismatchedTypeAndFormat);
Jamie Madillbe849e42017-05-02 15:49:00 -04005463 return false;
5464 }
5465
5466 // Check for pixel pack buffer related API errors
5467 gl::Buffer *pixelPackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_PACK_BUFFER);
5468 if (pixelPackBuffer != nullptr && pixelPackBuffer->isMapped())
5469 {
5470 // ...the buffer object's data store is currently mapped.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005471 context->handleError(InvalidOperation() << "Pixel pack buffer is mapped.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005472 return false;
5473 }
5474
5475 // .. the data would be packed to the buffer object such that the memory writes required
5476 // would exceed the data store size.
5477 const InternalFormat &formatInfo = GetInternalFormatInfo(format, type);
5478 const gl::Extents size(width, height, 1);
5479 const auto &pack = context->getGLState().getPackState();
5480
5481 auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, pack, false);
5482 if (endByteOrErr.isError())
5483 {
5484 context->handleError(endByteOrErr.getError());
5485 return false;
5486 }
5487
5488 size_t endByte = endByteOrErr.getResult();
5489 if (bufSize >= 0)
5490 {
5491 if (pixelPackBuffer == nullptr && static_cast<size_t>(bufSize) < endByte)
5492 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005493 context->handleError(InvalidOperation()
5494 << "bufSize must be at least " << endByte << " bytes.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005495 return false;
5496 }
5497 }
5498
5499 if (pixelPackBuffer != nullptr)
5500 {
5501 CheckedNumeric<size_t> checkedEndByte(endByte);
5502 CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels));
5503 checkedEndByte += checkedOffset;
5504
5505 if (checkedEndByte.ValueOrDie() > static_cast<size_t>(pixelPackBuffer->getSize()))
5506 {
5507 // Overflow past the end of the buffer
Brandon Jones6cad5662017-06-14 13:25:13 -07005508 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ParamOverflow);
Jamie Madillbe849e42017-05-02 15:49:00 -04005509 return false;
5510 }
5511 }
5512
5513 if (pixelPackBuffer == nullptr && length != nullptr)
5514 {
5515 if (endByte > static_cast<size_t>(std::numeric_limits<GLsizei>::max()))
5516 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005517 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Jamie Madillbe849e42017-05-02 15:49:00 -04005518 return false;
5519 }
5520
5521 *length = static_cast<GLsizei>(endByte);
5522 }
5523
5524 auto getClippedExtent = [](GLint start, GLsizei length, int bufferSize) {
5525 angle::CheckedNumeric<int> clippedExtent(length);
5526 if (start < 0)
5527 {
5528 // "subtract" the area that is less than 0
5529 clippedExtent += start;
5530 }
5531
5532 const int readExtent = start + length;
5533 if (readExtent > bufferSize)
5534 {
5535 // Subtract the region to the right of the read buffer
5536 clippedExtent -= (readExtent - bufferSize);
5537 }
5538
5539 if (!clippedExtent.IsValid())
5540 {
5541 return 0;
5542 }
5543
5544 return std::max(clippedExtent.ValueOrDie(), 0);
5545 };
5546
5547 if (columns != nullptr)
5548 {
5549 *columns = getClippedExtent(x, width, readBuffer->getSize().width);
5550 }
5551
5552 if (rows != nullptr)
5553 {
5554 *rows = getClippedExtent(y, height, readBuffer->getSize().height);
5555 }
5556
5557 return true;
5558}
5559
5560template <typename ParamType>
5561bool ValidateTexParameterBase(Context *context,
5562 GLenum target,
5563 GLenum pname,
5564 GLsizei bufSize,
5565 const ParamType *params)
5566{
5567 if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
5568 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005569 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005570 return false;
5571 }
5572
5573 if (context->getTargetTexture(target) == nullptr)
5574 {
5575 // Should only be possible for external textures
Brandon Jones6cad5662017-06-14 13:25:13 -07005576 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005577 return false;
5578 }
5579
5580 const GLsizei minBufSize = 1;
5581 if (bufSize >= 0 && bufSize < minBufSize)
5582 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005583 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005584 return false;
5585 }
5586
5587 switch (pname)
5588 {
5589 case GL_TEXTURE_WRAP_R:
5590 case GL_TEXTURE_SWIZZLE_R:
5591 case GL_TEXTURE_SWIZZLE_G:
5592 case GL_TEXTURE_SWIZZLE_B:
5593 case GL_TEXTURE_SWIZZLE_A:
5594 case GL_TEXTURE_BASE_LEVEL:
5595 case GL_TEXTURE_MAX_LEVEL:
5596 case GL_TEXTURE_COMPARE_MODE:
5597 case GL_TEXTURE_COMPARE_FUNC:
5598 case GL_TEXTURE_MIN_LOD:
5599 case GL_TEXTURE_MAX_LOD:
5600 if (context->getClientMajorVersion() < 3)
5601 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005602 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005603 return false;
5604 }
5605 if (target == GL_TEXTURE_EXTERNAL_OES &&
5606 !context->getExtensions().eglImageExternalEssl3)
5607 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005608 context->handleError(InvalidEnum() << "ES3 texture parameters are not "
5609 "available without "
5610 "GL_OES_EGL_image_external_essl3.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005611 return false;
5612 }
5613 break;
5614
5615 default:
5616 break;
5617 }
5618
JiangYizhou4cff8d62017-07-06 14:54:09 +08005619 if (target == GL_TEXTURE_2D_MULTISAMPLE)
5620 {
5621 switch (pname)
5622 {
5623 case GL_TEXTURE_MIN_FILTER:
5624 case GL_TEXTURE_MAG_FILTER:
5625 case GL_TEXTURE_WRAP_S:
5626 case GL_TEXTURE_WRAP_T:
5627 case GL_TEXTURE_WRAP_R:
5628 case GL_TEXTURE_MIN_LOD:
5629 case GL_TEXTURE_MAX_LOD:
5630 case GL_TEXTURE_COMPARE_MODE:
5631 case GL_TEXTURE_COMPARE_FUNC:
5632 context->handleError(InvalidEnum()
5633 << "Invalid parameter for 2D multisampled textures.");
5634 return false;
5635 }
5636 }
5637
Jamie Madillbe849e42017-05-02 15:49:00 -04005638 switch (pname)
5639 {
5640 case GL_TEXTURE_WRAP_S:
5641 case GL_TEXTURE_WRAP_T:
5642 case GL_TEXTURE_WRAP_R:
5643 if (!ValidateTextureWrapModeValue(context, params, target == GL_TEXTURE_EXTERNAL_OES))
5644 {
5645 return false;
5646 }
5647 break;
5648
5649 case GL_TEXTURE_MIN_FILTER:
5650 if (!ValidateTextureMinFilterValue(context, params, target == GL_TEXTURE_EXTERNAL_OES))
5651 {
5652 return false;
5653 }
5654 break;
5655
5656 case GL_TEXTURE_MAG_FILTER:
5657 if (!ValidateTextureMagFilterValue(context, params))
5658 {
5659 return false;
5660 }
5661 break;
5662
5663 case GL_TEXTURE_USAGE_ANGLE:
5664 switch (ConvertToGLenum(params[0]))
5665 {
5666 case GL_NONE:
5667 case GL_FRAMEBUFFER_ATTACHMENT_ANGLE:
5668 break;
5669
5670 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005671 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005672 return false;
5673 }
5674 break;
5675
5676 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
5677 if (!context->getExtensions().textureFilterAnisotropic)
5678 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005679 context->handleError(InvalidEnum() << "GL_EXT_texture_anisotropic is not enabled.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005680 return false;
5681 }
5682
5683 // we assume the parameter passed to this validation method is truncated, not rounded
5684 if (params[0] < 1)
5685 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005686 context->handleError(InvalidValue() << "Max anisotropy must be at least 1.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005687 return false;
5688 }
5689 break;
5690
5691 case GL_TEXTURE_MIN_LOD:
5692 case GL_TEXTURE_MAX_LOD:
5693 // any value is permissible
5694 break;
5695
5696 case GL_TEXTURE_COMPARE_MODE:
5697 if (!ValidateTextureCompareModeValue(context, params))
5698 {
5699 return false;
5700 }
5701 break;
5702
5703 case GL_TEXTURE_COMPARE_FUNC:
5704 if (!ValidateTextureCompareFuncValue(context, params))
5705 {
5706 return false;
5707 }
5708 break;
5709
5710 case GL_TEXTURE_SWIZZLE_R:
5711 case GL_TEXTURE_SWIZZLE_G:
5712 case GL_TEXTURE_SWIZZLE_B:
5713 case GL_TEXTURE_SWIZZLE_A:
5714 switch (ConvertToGLenum(params[0]))
5715 {
5716 case GL_RED:
5717 case GL_GREEN:
5718 case GL_BLUE:
5719 case GL_ALPHA:
5720 case GL_ZERO:
5721 case GL_ONE:
5722 break;
5723
5724 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005725 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005726 return false;
5727 }
5728 break;
5729
5730 case GL_TEXTURE_BASE_LEVEL:
5731 if (params[0] < 0)
5732 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005733 context->handleError(InvalidValue() << "Base level must be at least 0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005734 return false;
5735 }
5736 if (target == GL_TEXTURE_EXTERNAL_OES && static_cast<GLuint>(params[0]) != 0)
5737 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005738 context->handleError(InvalidOperation()
5739 << "Base level must be 0 for external textures.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005740 return false;
5741 }
JiangYizhou4cff8d62017-07-06 14:54:09 +08005742 if (target == GL_TEXTURE_2D_MULTISAMPLE && static_cast<GLuint>(params[0]) != 0)
5743 {
5744 context->handleError(InvalidOperation()
5745 << "Base level must be 0 for multisampled textures.");
5746 return false;
5747 }
Jamie Madillbe849e42017-05-02 15:49:00 -04005748 break;
5749
5750 case GL_TEXTURE_MAX_LEVEL:
5751 if (params[0] < 0)
5752 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005753 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Jamie Madillbe849e42017-05-02 15:49:00 -04005754 return false;
5755 }
5756 break;
5757
5758 case GL_DEPTH_STENCIL_TEXTURE_MODE:
5759 if (context->getClientVersion() < Version(3, 1))
5760 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005761 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumRequiresGLES31);
Jamie Madillbe849e42017-05-02 15:49:00 -04005762 return false;
5763 }
5764 switch (ConvertToGLenum(params[0]))
5765 {
5766 case GL_DEPTH_COMPONENT:
5767 case GL_STENCIL_INDEX:
5768 break;
5769
5770 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005771 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005772 return false;
5773 }
5774 break;
5775
5776 case GL_TEXTURE_SRGB_DECODE_EXT:
5777 if (!ValidateTextureSRGBDecodeValue(context, params))
5778 {
5779 return false;
5780 }
5781 break;
5782
5783 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005784 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005785 return false;
5786 }
5787
5788 return true;
5789}
5790
5791template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLfloat *);
5792template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLint *);
5793
Jamie Madillc29968b2016-01-20 11:17:23 -05005794} // namespace gl