blob: ca17d5a092ff6bf2331b4e81cf27aa181312136c [file] [log] [blame]
John Stiles44e96be2020-08-31 13:16:04 -04001/*
2 * Copyright 2020 Google LLC
3 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
6 */
7
8#include "src/sksl/SkSLInliner.h"
9
John Stiles2d7973a2020-10-02 15:01:03 -040010#include <limits.h>
John Stiles44e96be2020-08-31 13:16:04 -040011#include <memory>
12#include <unordered_set>
13
Ethan Nicholasdaed2592021-03-04 14:30:25 -050014#include "include/private/SkSLLayout.h"
Ethan Nicholas17807552021-10-01 09:42:36 -040015#include "src/sksl/analysis/SkSLProgramVisitor.h"
John Stiles44e96be2020-08-31 13:16:04 -040016#include "src/sksl/ir/SkSLBinaryExpression.h"
John Stiles44e96be2020-08-31 13:16:04 -040017#include "src/sksl/ir/SkSLBreakStatement.h"
Brian Osmaneb0f29d2021-08-04 11:34:16 -040018#include "src/sksl/ir/SkSLChildCall.h"
John Stiles44e96be2020-08-31 13:16:04 -040019#include "src/sksl/ir/SkSLConstructor.h"
John Stiles7384b372021-04-01 13:48:15 -040020#include "src/sksl/ir/SkSLConstructorArray.h"
John Stilese3ae9682021-08-05 10:35:01 -040021#include "src/sksl/ir/SkSLConstructorArrayCast.h"
John Stiles8cad6372021-04-07 12:31:13 -040022#include "src/sksl/ir/SkSLConstructorCompound.h"
23#include "src/sksl/ir/SkSLConstructorCompoundCast.h"
John Stilese1182782021-03-30 22:09:37 -040024#include "src/sksl/ir/SkSLConstructorDiagonalMatrix.h"
John Stiles5abb9e12021-04-06 13:47:19 -040025#include "src/sksl/ir/SkSLConstructorMatrixResize.h"
John Stilesfd7252f2021-04-04 22:24:40 -040026#include "src/sksl/ir/SkSLConstructorScalarCast.h"
John Stiles2938eea2021-04-01 18:58:25 -040027#include "src/sksl/ir/SkSLConstructorSplat.h"
John Stilesd47330f2021-04-08 23:25:52 -040028#include "src/sksl/ir/SkSLConstructorStruct.h"
John Stiles44e96be2020-08-31 13:16:04 -040029#include "src/sksl/ir/SkSLContinueStatement.h"
30#include "src/sksl/ir/SkSLDiscardStatement.h"
31#include "src/sksl/ir/SkSLDoStatement.h"
John Stiles44e96be2020-08-31 13:16:04 -040032#include "src/sksl/ir/SkSLExpressionStatement.h"
33#include "src/sksl/ir/SkSLExternalFunctionCall.h"
Brian Osmanbe0b3b72021-01-06 14:27:35 -050034#include "src/sksl/ir/SkSLExternalFunctionReference.h"
John Stiles44e96be2020-08-31 13:16:04 -040035#include "src/sksl/ir/SkSLField.h"
36#include "src/sksl/ir/SkSLFieldAccess.h"
John Stiles44e96be2020-08-31 13:16:04 -040037#include "src/sksl/ir/SkSLForStatement.h"
38#include "src/sksl/ir/SkSLFunctionCall.h"
39#include "src/sksl/ir/SkSLFunctionDeclaration.h"
40#include "src/sksl/ir/SkSLFunctionDefinition.h"
41#include "src/sksl/ir/SkSLFunctionReference.h"
42#include "src/sksl/ir/SkSLIfStatement.h"
43#include "src/sksl/ir/SkSLIndexExpression.h"
John Stiles98c1f822020-09-09 14:18:53 -040044#include "src/sksl/ir/SkSLInlineMarker.h"
John Stiles44e96be2020-08-31 13:16:04 -040045#include "src/sksl/ir/SkSLInterfaceBlock.h"
John Stiles7591d4b2021-09-13 13:32:06 -040046#include "src/sksl/ir/SkSLLiteral.h"
John Stiles44e96be2020-08-31 13:16:04 -040047#include "src/sksl/ir/SkSLNop.h"
John Stiles44e96be2020-08-31 13:16:04 -040048#include "src/sksl/ir/SkSLPostfixExpression.h"
49#include "src/sksl/ir/SkSLPrefixExpression.h"
50#include "src/sksl/ir/SkSLReturnStatement.h"
51#include "src/sksl/ir/SkSLSetting.h"
52#include "src/sksl/ir/SkSLSwitchCase.h"
53#include "src/sksl/ir/SkSLSwitchStatement.h"
54#include "src/sksl/ir/SkSLSwizzle.h"
55#include "src/sksl/ir/SkSLTernaryExpression.h"
56#include "src/sksl/ir/SkSLUnresolvedFunction.h"
57#include "src/sksl/ir/SkSLVarDeclarations.h"
John Stiles44e96be2020-08-31 13:16:04 -040058#include "src/sksl/ir/SkSLVariable.h"
59#include "src/sksl/ir/SkSLVariableReference.h"
John Stiles44e96be2020-08-31 13:16:04 -040060
61namespace SkSL {
62namespace {
63
John Stiles031a7672020-11-13 16:13:18 -050064static constexpr int kInlinedStatementLimit = 2500;
65
John Stiles44e96be2020-08-31 13:16:04 -040066static int count_returns_at_end_of_control_flow(const FunctionDefinition& funcDef) {
67 class CountReturnsAtEndOfControlFlow : public ProgramVisitor {
68 public:
69 CountReturnsAtEndOfControlFlow(const FunctionDefinition& funcDef) {
70 this->visitProgramElement(funcDef);
71 }
72
John Stiles5b408a32021-03-17 09:53:32 -040073 bool visitExpression(const Expression& expr) override {
74 // Do not recurse into expressions.
75 return false;
76 }
77
John Stiles44e96be2020-08-31 13:16:04 -040078 bool visitStatement(const Statement& stmt) override {
Ethan Nicholase6592142020-09-08 10:22:09 -040079 switch (stmt.kind()) {
80 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -040081 // Check only the last statement of a block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -040082 const auto& block = stmt.as<Block>();
83 return block.children().size() &&
84 this->visitStatement(*block.children().back());
John Stiles44e96be2020-08-31 13:16:04 -040085 }
Ethan Nicholase6592142020-09-08 10:22:09 -040086 case Statement::Kind::kSwitch:
Ethan Nicholase6592142020-09-08 10:22:09 -040087 case Statement::Kind::kDo:
88 case Statement::Kind::kFor:
John Stiles44e96be2020-08-31 13:16:04 -040089 // Don't introspect switches or loop structures at all.
90 return false;
91
Ethan Nicholase6592142020-09-08 10:22:09 -040092 case Statement::Kind::kReturn:
John Stiles44e96be2020-08-31 13:16:04 -040093 ++fNumReturns;
94 [[fallthrough]];
95
96 default:
John Stiles93442622020-09-11 12:11:27 -040097 return INHERITED::visitStatement(stmt);
John Stiles44e96be2020-08-31 13:16:04 -040098 }
99 }
100
101 int fNumReturns = 0;
102 using INHERITED = ProgramVisitor;
103 };
104
105 return CountReturnsAtEndOfControlFlow{funcDef}.fNumReturns;
106}
107
John Stiles991b09d2020-09-10 13:33:40 -0400108static bool contains_recursive_call(const FunctionDeclaration& funcDecl) {
109 class ContainsRecursiveCall : public ProgramVisitor {
110 public:
111 bool visit(const FunctionDeclaration& funcDecl) {
112 fFuncDecl = &funcDecl;
Ethan Nicholased84b732020-10-08 11:45:44 -0400113 return funcDecl.definition() ? this->visitProgramElement(*funcDecl.definition())
114 : false;
John Stiles991b09d2020-09-10 13:33:40 -0400115 }
116
117 bool visitExpression(const Expression& expr) override {
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400118 if (expr.is<FunctionCall>() && expr.as<FunctionCall>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400119 return true;
120 }
121 return INHERITED::visitExpression(expr);
122 }
123
124 bool visitStatement(const Statement& stmt) override {
Ethan Nicholasceb62142020-10-09 16:51:18 -0400125 if (stmt.is<InlineMarker>() &&
126 stmt.as<InlineMarker>().function().matches(*fFuncDecl)) {
John Stiles991b09d2020-09-10 13:33:40 -0400127 return true;
128 }
129 return INHERITED::visitStatement(stmt);
130 }
131
132 const FunctionDeclaration* fFuncDecl;
133 using INHERITED = ProgramVisitor;
134 };
135
136 return ContainsRecursiveCall{}.visit(funcDecl);
137}
138
John Stiles6d696082020-10-01 10:18:54 -0400139static std::unique_ptr<Statement>* find_parent_statement(
140 const std::vector<std::unique_ptr<Statement>*>& stmtStack) {
John Stiles915a38c2020-09-14 09:38:13 -0400141 SkASSERT(!stmtStack.empty());
142
143 // Walk the statement stack from back to front, ignoring the last element (which is the
144 // enclosing statement).
145 auto iter = stmtStack.rbegin();
146 ++iter;
147
148 // Anything counts as a parent statement other than a scopeless Block.
149 for (; iter != stmtStack.rend(); ++iter) {
John Stiles6d696082020-10-01 10:18:54 -0400150 std::unique_ptr<Statement>* stmt = *iter;
151 if (!(*stmt)->is<Block>() || (*stmt)->as<Block>().isScope()) {
John Stiles915a38c2020-09-14 09:38:13 -0400152 return stmt;
153 }
154 }
155
156 // There wasn't any parent statement to be found.
157 return nullptr;
158}
159
John Stilese41b4ee2020-09-28 12:28:16 -0400160std::unique_ptr<Expression> clone_with_ref_kind(const Expression& expr,
161 VariableReference::RefKind refKind) {
162 std::unique_ptr<Expression> clone = expr.clone();
John Stilesbb8cf582021-08-26 23:34:59 -0400163 Analysis::UpdateVariableRefKind(clone.get(), refKind);
John Stilese41b4ee2020-09-28 12:28:16 -0400164 return clone;
165}
166
John Stiles77702f12020-12-17 14:38:56 -0500167class CountReturnsWithLimit : public ProgramVisitor {
168public:
169 CountReturnsWithLimit(const FunctionDefinition& funcDef, int limit) : fLimit(limit) {
170 this->visitProgramElement(funcDef);
171 }
172
John Stiles5b408a32021-03-17 09:53:32 -0400173 bool visitExpression(const Expression& expr) override {
174 // Do not recurse into expressions.
175 return false;
176 }
177
John Stiles77702f12020-12-17 14:38:56 -0500178 bool visitStatement(const Statement& stmt) override {
179 switch (stmt.kind()) {
180 case Statement::Kind::kReturn: {
181 ++fNumReturns;
182 fDeepestReturn = std::max(fDeepestReturn, fScopedBlockDepth);
183 return (fNumReturns >= fLimit) || INHERITED::visitStatement(stmt);
184 }
John Stilesc5ff4862020-12-22 13:47:05 -0500185 case Statement::Kind::kVarDeclaration: {
186 if (fScopedBlockDepth > 1) {
187 fVariablesInBlocks = true;
188 }
189 return INHERITED::visitStatement(stmt);
190 }
John Stiles77702f12020-12-17 14:38:56 -0500191 case Statement::Kind::kBlock: {
192 int depthIncrement = stmt.as<Block>().isScope() ? 1 : 0;
193 fScopedBlockDepth += depthIncrement;
194 bool result = INHERITED::visitStatement(stmt);
195 fScopedBlockDepth -= depthIncrement;
John Stilesc5ff4862020-12-22 13:47:05 -0500196 if (fNumReturns == 0 && fScopedBlockDepth <= 1) {
197 // If closing this block puts us back at the top level, and we haven't
198 // encountered any return statements yet, any vardecls we may have encountered
199 // up until this point can be ignored. They are out of scope now, and they were
200 // never used in a return statement.
201 fVariablesInBlocks = false;
202 }
John Stiles77702f12020-12-17 14:38:56 -0500203 return result;
204 }
205 default:
206 return INHERITED::visitStatement(stmt);
207 }
208 }
209
210 int fNumReturns = 0;
211 int fDeepestReturn = 0;
212 int fLimit = 0;
213 int fScopedBlockDepth = 0;
John Stilesc5ff4862020-12-22 13:47:05 -0500214 bool fVariablesInBlocks = false;
John Stiles77702f12020-12-17 14:38:56 -0500215 using INHERITED = ProgramVisitor;
216};
217
John Stiles44e96be2020-08-31 13:16:04 -0400218} // namespace
219
John Stilesda25cff2021-10-06 11:31:06 -0400220const Variable* Inliner::RemapVariable(const Variable* variable,
221 const VariableRewriteMap* varMap) {
222 auto iter = varMap->find(variable);
223 if (iter == varMap->end()) {
224 SkDEBUGFAILF("rewrite map does not contain variable '%.*s'",
225 (int)variable->name().size(), variable->name().data());
226 return variable;
227 }
228 Expression* expr = iter->second.get();
229 SkASSERT(expr);
230 if (!expr->is<VariableReference>()) {
231 SkDEBUGFAILF("rewrite map contains non-variable replacement for '%.*s'",
232 (int)variable->name().size(), variable->name().data());
233 return variable;
234 }
235 return expr->as<VariableReference>().variable();
236}
237
John Stiles77702f12020-12-17 14:38:56 -0500238Inliner::ReturnComplexity Inliner::GetReturnComplexity(const FunctionDefinition& funcDef) {
239 int returnsAtEndOfControlFlow = count_returns_at_end_of_control_flow(funcDef);
240 CountReturnsWithLimit counter{funcDef, returnsAtEndOfControlFlow + 1};
John Stiles77702f12020-12-17 14:38:56 -0500241 if (counter.fNumReturns > returnsAtEndOfControlFlow) {
242 return ReturnComplexity::kEarlyReturns;
243 }
John Stilesc5ff4862020-12-22 13:47:05 -0500244 if (counter.fNumReturns > 1) {
John Stiles77702f12020-12-17 14:38:56 -0500245 return ReturnComplexity::kScopedReturns;
246 }
John Stilesc5ff4862020-12-22 13:47:05 -0500247 if (counter.fVariablesInBlocks && counter.fDeepestReturn > 1) {
248 return ReturnComplexity::kScopedReturns;
249 }
John Stiles8937cd42021-03-17 19:32:59 +0000250 return ReturnComplexity::kSingleSafeReturn;
John Stiles77702f12020-12-17 14:38:56 -0500251}
252
John Stilesb61ee902020-09-21 12:26:59 -0400253void Inliner::ensureScopedBlocks(Statement* inlinedBody, Statement* parentStmt) {
254 // No changes necessary if this statement isn't actually a block.
255 if (!inlinedBody || !inlinedBody->is<Block>()) {
256 return;
257 }
258
259 // No changes necessary if the parent statement doesn't require a scope.
260 if (!parentStmt || !(parentStmt->is<IfStatement>() || parentStmt->is<ForStatement>() ||
Brian Osmand6f23382020-12-15 17:08:59 -0500261 parentStmt->is<DoStatement>())) {
John Stilesb61ee902020-09-21 12:26:59 -0400262 return;
263 }
264
265 Block& block = inlinedBody->as<Block>();
266
267 // The inliner will create inlined function bodies as a Block containing multiple statements,
268 // but no scope. Normally, this is fine, but if this block is used as the statement for a
269 // do/for/if/while, this isn't actually possible to represent textually; a scope must be added
270 // for the generated code to match the intent. In the case of Blocks nested inside other Blocks,
271 // we add the scope to the outermost block if needed. Zero-statement blocks have similar
272 // issues--if we don't represent the Block textually somehow, we run the risk of accidentally
273 // absorbing the following statement into our loop--so we also add a scope to these.
274 for (Block* nestedBlock = &block;; ) {
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400275 if (nestedBlock->isScope()) {
John Stilesb61ee902020-09-21 12:26:59 -0400276 // We found an explicit scope; all is well.
277 return;
278 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400279 if (nestedBlock->children().size() != 1) {
John Stilesb61ee902020-09-21 12:26:59 -0400280 // We found a block with multiple (or zero) statements, but no scope? Let's add a scope
281 // to the outermost block.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400282 block.setIsScope(true);
John Stilesb61ee902020-09-21 12:26:59 -0400283 return;
284 }
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400285 if (!nestedBlock->children()[0]->is<Block>()) {
John Stilesb61ee902020-09-21 12:26:59 -0400286 // This block has exactly one thing inside, and it's not another block. No need to scope
287 // it.
288 return;
289 }
290 // We have to go deeper.
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400291 nestedBlock = &nestedBlock->children()[0]->as<Block>();
John Stilesb61ee902020-09-21 12:26:59 -0400292 }
293}
294
John Stiles10d39d92021-05-04 16:13:14 -0400295void Inliner::reset() {
John Stiles2dda4b62021-09-16 13:18:10 -0400296 fContext->fMangler->reset();
John Stiles031a7672020-11-13 16:13:18 -0500297 fInlinedStatementCounter = 0;
John Stiles44e96be2020-08-31 13:16:04 -0400298}
299
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400300std::unique_ptr<Expression> Inliner::inlineExpression(int line,
John Stiles44e96be2020-08-31 13:16:04 -0400301 VariableRewriteMap* varMap,
John Stilesd7cc0932020-11-30 12:24:27 -0500302 SymbolTable* symbolTableForExpression,
John Stiles44e96be2020-08-31 13:16:04 -0400303 const Expression& expression) {
304 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
305 if (e) {
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400306 return this->inlineExpression(line, varMap, symbolTableForExpression, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400307 }
308 return nullptr;
309 };
John Stiles8e3b6be2020-10-13 11:14:08 -0400310 auto argList = [&](const ExpressionArray& originalArgs) -> ExpressionArray {
311 ExpressionArray args;
John Stilesf4bda742020-10-14 16:57:41 -0400312 args.reserve_back(originalArgs.size());
John Stiles44e96be2020-08-31 13:16:04 -0400313 for (const std::unique_ptr<Expression>& arg : originalArgs) {
314 args.push_back(expr(arg));
315 }
316 return args;
317 };
318
Ethan Nicholase6592142020-09-08 10:22:09 -0400319 switch (expression.kind()) {
320 case Expression::Kind::kBinary: {
John Stiles6a1a98c2021-01-14 18:35:34 -0500321 const BinaryExpression& binaryExpr = expression.as<BinaryExpression>();
John Stilese2aec432021-03-01 09:27:48 -0500322 return BinaryExpression::Make(*fContext,
323 expr(binaryExpr.left()),
324 binaryExpr.getOperator(),
325 expr(binaryExpr.right()));
John Stiles44e96be2020-08-31 13:16:04 -0400326 }
John Stiles7591d4b2021-09-13 13:32:06 -0400327 case Expression::Kind::kLiteral:
John Stiles44e96be2020-08-31 13:16:04 -0400328 return expression.clone();
Brian Osmaneb0f29d2021-08-04 11:34:16 -0400329 case Expression::Kind::kChildCall: {
330 const ChildCall& childCall = expression.as<ChildCall>();
331 return ChildCall::Make(*fContext,
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400332 line,
Brian Osmaneb0f29d2021-08-04 11:34:16 -0400333 childCall.type().clone(symbolTableForExpression),
334 childCall.child(),
335 argList(childCall.arguments()));
336 }
John Stiles7384b372021-04-01 13:48:15 -0400337 case Expression::Kind::kConstructorArray: {
338 const ConstructorArray& ctor = expression.as<ConstructorArray>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400339 return ConstructorArray::Make(*fContext, line,
John Stiles7384b372021-04-01 13:48:15 -0400340 *ctor.type().clone(symbolTableForExpression),
341 argList(ctor.arguments()));
342 }
John Stilese3ae9682021-08-05 10:35:01 -0400343 case Expression::Kind::kConstructorArrayCast: {
344 const ConstructorArrayCast& ctor = expression.as<ConstructorArrayCast>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400345 return ConstructorArrayCast::Make(*fContext, line,
John Stilese3ae9682021-08-05 10:35:01 -0400346 *ctor.type().clone(symbolTableForExpression),
347 expr(ctor.argument()));
348 }
John Stiles8cad6372021-04-07 12:31:13 -0400349 case Expression::Kind::kConstructorCompound: {
350 const ConstructorCompound& ctor = expression.as<ConstructorCompound>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400351 return ConstructorCompound::Make(*fContext, line,
John Stiles2bec8ab2021-04-06 18:40:04 -0400352 *ctor.type().clone(symbolTableForExpression),
353 argList(ctor.arguments()));
354 }
John Stiles8cad6372021-04-07 12:31:13 -0400355 case Expression::Kind::kConstructorCompoundCast: {
356 const ConstructorCompoundCast& ctor = expression.as<ConstructorCompoundCast>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400357 return ConstructorCompoundCast::Make(*fContext, line,
John Stiles268a73f2021-04-07 12:30:22 -0400358 *ctor.type().clone(symbolTableForExpression),
359 expr(ctor.argument()));
360 }
John Stilese1182782021-03-30 22:09:37 -0400361 case Expression::Kind::kConstructorDiagonalMatrix: {
362 const ConstructorDiagonalMatrix& ctor = expression.as<ConstructorDiagonalMatrix>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400363 return ConstructorDiagonalMatrix::Make(*fContext, line,
John Stilese1182782021-03-30 22:09:37 -0400364 *ctor.type().clone(symbolTableForExpression),
365 expr(ctor.argument()));
366 }
John Stiles5abb9e12021-04-06 13:47:19 -0400367 case Expression::Kind::kConstructorMatrixResize: {
368 const ConstructorMatrixResize& ctor = expression.as<ConstructorMatrixResize>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400369 return ConstructorMatrixResize::Make(*fContext, line,
John Stiles5abb9e12021-04-06 13:47:19 -0400370 *ctor.type().clone(symbolTableForExpression),
371 expr(ctor.argument()));
372 }
John Stilesfd7252f2021-04-04 22:24:40 -0400373 case Expression::Kind::kConstructorScalarCast: {
374 const ConstructorScalarCast& ctor = expression.as<ConstructorScalarCast>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400375 return ConstructorScalarCast::Make(*fContext, line,
John Stilesfd7252f2021-04-04 22:24:40 -0400376 *ctor.type().clone(symbolTableForExpression),
377 expr(ctor.argument()));
378 }
John Stiles2938eea2021-04-01 18:58:25 -0400379 case Expression::Kind::kConstructorSplat: {
380 const ConstructorSplat& ctor = expression.as<ConstructorSplat>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400381 return ConstructorSplat::Make(*fContext, line,
John Stiles2938eea2021-04-01 18:58:25 -0400382 *ctor.type().clone(symbolTableForExpression),
383 expr(ctor.argument()));
384 }
John Stilesd47330f2021-04-08 23:25:52 -0400385 case Expression::Kind::kConstructorStruct: {
386 const ConstructorStruct& ctor = expression.as<ConstructorStruct>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400387 return ConstructorStruct::Make(*fContext, line,
John Stilesd47330f2021-04-08 23:25:52 -0400388 *ctor.type().clone(symbolTableForExpression),
389 argList(ctor.arguments()));
390 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400391 case Expression::Kind::kExternalFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400392 const ExternalFunctionCall& externalCall = expression.as<ExternalFunctionCall>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400393 return std::make_unique<ExternalFunctionCall>(line, &externalCall.function(),
Ethan Nicholas6e86ec92020-09-30 14:29:56 -0400394 argList(externalCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400395 }
Brian Osmanbe0b3b72021-01-06 14:27:35 -0500396 case Expression::Kind::kExternalFunctionReference:
John Stiles44e96be2020-08-31 13:16:04 -0400397 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400398 case Expression::Kind::kFieldAccess: {
John Stiles44e96be2020-08-31 13:16:04 -0400399 const FieldAccess& f = expression.as<FieldAccess>();
John Stiles06d600f2021-03-08 09:18:21 -0500400 return FieldAccess::Make(*fContext, expr(f.base()), f.fieldIndex(), f.ownerKind());
John Stiles44e96be2020-08-31 13:16:04 -0400401 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400402 case Expression::Kind::kFunctionCall: {
John Stiles44e96be2020-08-31 13:16:04 -0400403 const FunctionCall& funcCall = expression.as<FunctionCall>();
John Stilescd7ba502021-03-19 10:54:59 -0400404 return FunctionCall::Make(*fContext,
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400405 line,
John Stilescd7ba502021-03-19 10:54:59 -0400406 funcCall.type().clone(symbolTableForExpression),
407 funcCall.function(),
408 argList(funcCall.arguments()));
John Stiles44e96be2020-08-31 13:16:04 -0400409 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400410 case Expression::Kind::kFunctionReference:
Brian Osman2b3b35f2020-09-08 09:17:36 -0400411 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400412 case Expression::Kind::kIndex: {
John Stiles44e96be2020-08-31 13:16:04 -0400413 const IndexExpression& idx = expression.as<IndexExpression>();
John Stiles51d33982021-03-08 09:18:07 -0500414 return IndexExpression::Make(*fContext, expr(idx.base()), expr(idx.index()));
John Stiles44e96be2020-08-31 13:16:04 -0400415 }
Brian Osman3099f792021-09-01 13:12:16 -0400416 case Expression::Kind::kMethodReference:
417 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400418 case Expression::Kind::kPrefix: {
John Stiles44e96be2020-08-31 13:16:04 -0400419 const PrefixExpression& p = expression.as<PrefixExpression>();
John Stilesb0eb20f2021-02-26 15:29:33 -0500420 return PrefixExpression::Make(*fContext, p.getOperator(), expr(p.operand()));
John Stiles44e96be2020-08-31 13:16:04 -0400421 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400422 case Expression::Kind::kPostfix: {
John Stiles44e96be2020-08-31 13:16:04 -0400423 const PostfixExpression& p = expression.as<PostfixExpression>();
John Stiles52d3b012021-02-26 15:56:48 -0500424 return PostfixExpression::Make(*fContext, expr(p.operand()), p.getOperator());
John Stiles44e96be2020-08-31 13:16:04 -0400425 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400426 case Expression::Kind::kSetting:
John Stiles44e96be2020-08-31 13:16:04 -0400427 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400428 case Expression::Kind::kSwizzle: {
John Stiles44e96be2020-08-31 13:16:04 -0400429 const Swizzle& s = expression.as<Swizzle>();
John Stiles6e88e042021-02-19 14:09:38 -0500430 return Swizzle::Make(*fContext, expr(s.base()), s.components());
John Stiles44e96be2020-08-31 13:16:04 -0400431 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400432 case Expression::Kind::kTernary: {
John Stiles44e96be2020-08-31 13:16:04 -0400433 const TernaryExpression& t = expression.as<TernaryExpression>();
John Stiles90518f72021-02-26 20:44:54 -0500434 return TernaryExpression::Make(*fContext, expr(t.test()),
435 expr(t.ifTrue()), expr(t.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400436 }
Brian Osman83ba9302020-09-11 13:33:46 -0400437 case Expression::Kind::kTypeReference:
438 return expression.clone();
Ethan Nicholase6592142020-09-08 10:22:09 -0400439 case Expression::Kind::kVariableReference: {
John Stiles44e96be2020-08-31 13:16:04 -0400440 const VariableReference& v = expression.as<VariableReference>();
Ethan Nicholas78686922020-10-08 06:46:27 -0400441 auto varMapIter = varMap->find(v.variable());
John Stilese41b4ee2020-09-28 12:28:16 -0400442 if (varMapIter != varMap->end()) {
Ethan Nicholas78686922020-10-08 06:46:27 -0400443 return clone_with_ref_kind(*varMapIter->second, v.refKind());
John Stiles44e96be2020-08-31 13:16:04 -0400444 }
445 return v.clone();
446 }
447 default:
448 SkASSERT(false);
449 return nullptr;
450 }
451}
452
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400453std::unique_ptr<Statement> Inliner::inlineStatement(int line,
John Stiles44e96be2020-08-31 13:16:04 -0400454 VariableRewriteMap* varMap,
455 SymbolTable* symbolTableForStatement,
John Stiles77702f12020-12-17 14:38:56 -0500456 std::unique_ptr<Expression>* resultExpr,
457 ReturnComplexity returnComplexity,
Brian Osman3887a012020-09-30 13:22:27 -0400458 const Statement& statement,
459 bool isBuiltinCode) {
John Stiles44e96be2020-08-31 13:16:04 -0400460 auto stmt = [&](const std::unique_ptr<Statement>& s) -> std::unique_ptr<Statement> {
461 if (s) {
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400462 return this->inlineStatement(line, varMap, symbolTableForStatement, resultExpr,
John Stiles77702f12020-12-17 14:38:56 -0500463 returnComplexity, *s, isBuiltinCode);
John Stiles44e96be2020-08-31 13:16:04 -0400464 }
465 return nullptr;
466 };
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400467 auto blockStmts = [&](const Block& block) {
John Stiles8f2a0cf2020-10-13 12:48:21 -0400468 StatementArray result;
John Stilesf4bda742020-10-14 16:57:41 -0400469 result.reserve_back(block.children().size());
Ethan Nicholas7bd60432020-09-25 14:31:59 -0400470 for (const std::unique_ptr<Statement>& child : block.children()) {
471 result.push_back(stmt(child));
472 }
473 return result;
474 };
John Stiles44e96be2020-08-31 13:16:04 -0400475 auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> {
476 if (e) {
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400477 return this->inlineExpression(line, varMap, symbolTableForStatement, *e);
John Stiles44e96be2020-08-31 13:16:04 -0400478 }
479 return nullptr;
480 };
John Stiles031a7672020-11-13 16:13:18 -0500481
482 ++fInlinedStatementCounter;
483
Ethan Nicholase6592142020-09-08 10:22:09 -0400484 switch (statement.kind()) {
485 case Statement::Kind::kBlock: {
John Stiles44e96be2020-08-31 13:16:04 -0400486 const Block& b = statement.as<Block>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400487 return Block::Make(line, blockStmts(b),
John Stilesbf16b6c2021-03-12 19:24:31 -0500488 SymbolTable::WrapIfBuiltin(b.symbolTable()),
489 b.isScope());
John Stiles44e96be2020-08-31 13:16:04 -0400490 }
491
Ethan Nicholase6592142020-09-08 10:22:09 -0400492 case Statement::Kind::kBreak:
493 case Statement::Kind::kContinue:
494 case Statement::Kind::kDiscard:
John Stiles44e96be2020-08-31 13:16:04 -0400495 return statement.clone();
496
Ethan Nicholase6592142020-09-08 10:22:09 -0400497 case Statement::Kind::kDo: {
John Stiles44e96be2020-08-31 13:16:04 -0400498 const DoStatement& d = statement.as<DoStatement>();
John Stilesea5822e2021-02-26 11:18:20 -0500499 return DoStatement::Make(*fContext, stmt(d.statement()), expr(d.test()));
John Stiles44e96be2020-08-31 13:16:04 -0400500 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400501 case Statement::Kind::kExpression: {
John Stiles44e96be2020-08-31 13:16:04 -0400502 const ExpressionStatement& e = statement.as<ExpressionStatement>();
John Stiles3e5871c2021-02-25 20:52:03 -0500503 return ExpressionStatement::Make(*fContext, expr(e.expression()));
John Stiles44e96be2020-08-31 13:16:04 -0400504 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400505 case Statement::Kind::kFor: {
John Stiles44e96be2020-08-31 13:16:04 -0400506 const ForStatement& f = statement.as<ForStatement>();
507 // need to ensure initializer is evaluated first so that we've already remapped its
508 // declarations by the time we evaluate test & next
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400509 std::unique_ptr<Statement> initializer = stmt(f.initializer());
John Stilesda25cff2021-10-06 11:31:06 -0400510
511 std::unique_ptr<LoopUnrollInfo> unrollInfo;
512 if (f.unrollInfo()) {
513 // The for loop's unroll-info points to the Variable in the initializer as the
514 // index. This variable has been rewritten into a clone by the inliner, so we need
515 // to update the loop-unroll info to point to the clone.
516 unrollInfo = std::make_unique<LoopUnrollInfo>(*f.unrollInfo());
517 unrollInfo->fIndex = RemapVariable(unrollInfo->fIndex, varMap);
518 }
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400519 return ForStatement::Make(*fContext, line, std::move(initializer), expr(f.test()),
John Stilesda25cff2021-10-06 11:31:06 -0400520 expr(f.next()), stmt(f.statement()), std::move(unrollInfo),
John Stilesb321a072021-02-25 16:24:19 -0500521 SymbolTable::WrapIfBuiltin(f.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400522 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400523 case Statement::Kind::kIf: {
John Stiles44e96be2020-08-31 13:16:04 -0400524 const IfStatement& i = statement.as<IfStatement>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400525 return IfStatement::Make(*fContext, line, i.isStatic(), expr(i.test()),
John Stilescf3059e2021-02-25 14:27:02 -0500526 stmt(i.ifTrue()), stmt(i.ifFalse()));
John Stiles44e96be2020-08-31 13:16:04 -0400527 }
John Stiles98c1f822020-09-09 14:18:53 -0400528 case Statement::Kind::kInlineMarker:
Ethan Nicholase6592142020-09-08 10:22:09 -0400529 case Statement::Kind::kNop:
John Stiles44e96be2020-08-31 13:16:04 -0400530 return statement.clone();
John Stilesea5822e2021-02-26 11:18:20 -0500531
Ethan Nicholase6592142020-09-08 10:22:09 -0400532 case Statement::Kind::kReturn: {
John Stiles44e96be2020-08-31 13:16:04 -0400533 const ReturnStatement& r = statement.as<ReturnStatement>();
John Stiles77702f12020-12-17 14:38:56 -0500534 if (!r.expression()) {
John Stilesdc208472021-03-17 10:58:16 -0400535 // This function doesn't return a value. We won't inline functions with early
536 // returns, so a return statement is a no-op and can be treated as such.
537 return Nop::Make();
John Stiles44e96be2020-08-31 13:16:04 -0400538 }
John Stiles77702f12020-12-17 14:38:56 -0500539
John Stilesc5ff4862020-12-22 13:47:05 -0500540 // If a function only contains a single return, and it doesn't reference variables from
541 // inside an Block's scope, we don't need to store the result in a variable at all. Just
542 // replace the function-call expression with the function's return expression.
John Stiles77702f12020-12-17 14:38:56 -0500543 SkASSERT(resultExpr);
John Stilesc5ff4862020-12-22 13:47:05 -0500544 if (returnComplexity <= ReturnComplexity::kSingleSafeReturn) {
John Stiles77702f12020-12-17 14:38:56 -0500545 *resultExpr = expr(r.expression());
John Stilesa0c04d62021-03-11 23:07:24 -0500546 return Nop::Make();
John Stiles77702f12020-12-17 14:38:56 -0500547 }
548
549 // For more complex functions, assign their result into a variable.
John Stiles511c5002021-02-25 11:17:02 -0500550 SkASSERT(*resultExpr);
John Stiles3e5871c2021-02-25 20:52:03 -0500551 auto assignment = ExpressionStatement::Make(
552 *fContext,
John Stilese2aec432021-03-01 09:27:48 -0500553 BinaryExpression::Make(
554 *fContext,
555 clone_with_ref_kind(**resultExpr, VariableRefKind::kWrite),
John Stiles77702f12020-12-17 14:38:56 -0500556 Token::Kind::TK_EQ,
John Stilese2aec432021-03-01 09:27:48 -0500557 expr(r.expression())));
John Stiles77702f12020-12-17 14:38:56 -0500558
John Stiles77702f12020-12-17 14:38:56 -0500559 // Functions without early returns aren't wrapped in a for loop and don't need to worry
560 // about breaking out of the control flow.
John Stiles3e5871c2021-02-25 20:52:03 -0500561 return assignment;
John Stiles44e96be2020-08-31 13:16:04 -0400562 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400563 case Statement::Kind::kSwitch: {
John Stiles44e96be2020-08-31 13:16:04 -0400564 const SwitchStatement& ss = statement.as<SwitchStatement>();
John Stilesb23a64b2021-03-11 08:27:59 -0500565 StatementArray cases;
566 cases.reserve_back(ss.cases().size());
John Stiles628777c2021-08-04 22:07:41 -0400567 for (const std::unique_ptr<Statement>& switchCaseStmt : ss.cases()) {
568 const SwitchCase& sc = switchCaseStmt->as<SwitchCase>();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400569 cases.push_back(std::make_unique<SwitchCase>(line, expr(sc.value()),
John Stilesb23a64b2021-03-11 08:27:59 -0500570 stmt(sc.statement())));
John Stiles44e96be2020-08-31 13:16:04 -0400571 }
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400572 return SwitchStatement::Make(*fContext, line, ss.isStatic(), expr(ss.value()),
John Stilese1d1b082021-02-23 13:44:36 -0500573 std::move(cases), SymbolTable::WrapIfBuiltin(ss.symbols()));
John Stiles44e96be2020-08-31 13:16:04 -0400574 }
Ethan Nicholase6592142020-09-08 10:22:09 -0400575 case Statement::Kind::kVarDeclaration: {
John Stiles44e96be2020-08-31 13:16:04 -0400576 const VarDeclaration& decl = statement.as<VarDeclaration>();
John Stiles35fee4c2020-12-16 18:25:14 +0000577 std::unique_ptr<Expression> initialValue = expr(decl.value());
John Stilesddcc8432021-01-15 15:32:32 -0500578 const Variable& variable = decl.var();
579
John Stiles35fee4c2020-12-16 18:25:14 +0000580 // We assign unique names to inlined variables--scopes hide most of the problems in this
581 // regard, but see `InlinerAvoidsVariableNameOverlap` for a counterexample where unique
582 // names are important.
John Stilesd51c9792021-03-18 11:40:14 -0400583 const String* name = symbolTableForStatement->takeOwnershipOfString(
John Stiles2dda4b62021-09-16 13:18:10 -0400584 fContext->fMangler->uniqueName(variable.name(), symbolTableForStatement));
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500585 auto clonedVar = std::make_unique<Variable>(
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400586 line,
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500587 &variable.modifiers(),
John Stilesd51c9792021-03-18 11:40:14 -0400588 name->c_str(),
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500589 variable.type().clone(symbolTableForStatement),
590 isBuiltinCode,
591 variable.storage());
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400592 (*varMap)[&variable] = VariableReference::Make(line, clonedVar.get());
John Stilese67bd132021-03-19 18:39:25 -0400593 auto result = VarDeclaration::Make(*fContext,
594 clonedVar.get(),
595 decl.baseType().clone(symbolTableForStatement),
596 decl.arraySize(),
597 std::move(initialValue));
Ethan Nicholas5b9b0db2021-01-21 13:12:01 -0500598 symbolTableForStatement->takeOwnershipOfSymbol(std::move(clonedVar));
John Stilese67bd132021-03-19 18:39:25 -0400599 return result;
John Stiles44e96be2020-08-31 13:16:04 -0400600 }
John Stiles44e96be2020-08-31 13:16:04 -0400601 default:
602 SkASSERT(false);
603 return nullptr;
604 }
605}
606
John Stiles6eadf132020-09-08 10:16:10 -0400607Inliner::InlinedCall Inliner::inlineCall(FunctionCall* call,
John Stiles78047582020-12-16 16:17:41 -0500608 std::shared_ptr<SymbolTable> symbolTable,
John Stiles30fce9c2021-03-18 09:24:06 -0400609 const ProgramUsage& usage,
Brian Osman3887a012020-09-30 13:22:27 -0400610 const FunctionDeclaration* caller) {
John Stiles941812f2021-09-16 15:12:02 -0400611 using ScratchVariable = Variable::ScratchVariable;
612
John Stiles44e96be2020-08-31 13:16:04 -0400613 // Inlining is more complicated here than in a typical compiler, because we have to have a
614 // high-level IR and can't just drop statements into the middle of an expression or even use
615 // gotos.
616 //
617 // Since we can't insert statements into an expression, we run the inline function as extra
618 // statements before the statement we're currently processing, relying on a lack of execution
619 // order guarantees. Since we can't use gotos (which are normally used to replace return
620 // statements), we wrap the whole function in a loop and use break statements to jump to the
621 // end.
John Stiles44e96be2020-08-31 13:16:04 -0400622 SkASSERT(fContext);
623 SkASSERT(call);
Ethan Nicholased84b732020-10-08 11:45:44 -0400624 SkASSERT(this->isSafeToInline(call->function().definition()));
John Stiles44e96be2020-08-31 13:16:04 -0400625
John Stiles8e3b6be2020-10-13 11:14:08 -0400626 ExpressionArray& arguments = call->arguments();
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400627 const int line = call->fLine;
Ethan Nicholased84b732020-10-08 11:45:44 -0400628 const FunctionDefinition& function = *call->function().definition();
John Stiles28257db2021-03-17 15:18:09 -0400629 const Block& body = function.body()->as<Block>();
John Stiles77702f12020-12-17 14:38:56 -0500630 const ReturnComplexity returnComplexity = GetReturnComplexity(function);
John Stiles6eadf132020-09-08 10:16:10 -0400631
John Stiles28257db2021-03-17 15:18:09 -0400632 StatementArray inlineStatements;
633 int expectedStmtCount = 1 + // Inline marker
634 1 + // Result variable
635 arguments.size() + // Function argument temp-vars
636 body.children().size(); // Inlined code
John Stiles98c1f822020-09-09 14:18:53 -0400637
John Stiles28257db2021-03-17 15:18:09 -0400638 inlineStatements.reserve_back(expectedStmtCount);
639 inlineStatements.push_back(InlineMarker::Make(&call->function()));
John Stiles44e96be2020-08-31 13:16:04 -0400640
John Stilese41b4ee2020-09-28 12:28:16 -0400641 std::unique_ptr<Expression> resultExpr;
John Stiles511c5002021-02-25 11:17:02 -0500642 if (returnComplexity > ReturnComplexity::kSingleSafeReturn &&
John Stiles2558c462021-03-16 17:49:20 -0400643 !function.declaration().returnType().isVoid()) {
John Stiles511c5002021-02-25 11:17:02 -0500644 // Create a variable to hold the result in the extra statements. We don't need to do this
645 // for void-return functions, or in cases that are simple enough that we can just replace
646 // the function-call node with the result expression.
John Stiles941812f2021-09-16 15:12:02 -0400647 ScratchVariable var = Variable::MakeScratchVariable(*fContext,
648 function.declaration().name(),
649 &function.declaration().returnType(),
650 Modifiers{},
651 symbolTable.get(),
652 /*initialValue=*/nullptr);
John Stiles28257db2021-03-17 15:18:09 -0400653 inlineStatements.push_back(std::move(var.fVarDecl));
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400654 resultExpr = VariableReference::Make(/*line=*/-1, var.fVarSymbol);
John Stiles511c5002021-02-25 11:17:02 -0500655 }
John Stiles44e96be2020-08-31 13:16:04 -0400656
657 // Create variables in the extra statements to hold the arguments, and assign the arguments to
658 // them.
659 VariableRewriteMap varMap;
John Stilesbff24ab2021-03-17 13:20:10 -0400660 for (int i = 0; i < arguments.count(); ++i) {
John Stiles049f0df2021-03-19 09:39:44 -0400661 // If the parameter isn't written to within the inline function ...
John Stiles941812f2021-09-16 15:12:02 -0400662 Expression* arg = arguments[i].get();
John Stilesbff24ab2021-03-17 13:20:10 -0400663 const Variable* param = function.declaration().parameters()[i];
John Stiles049f0df2021-03-19 09:39:44 -0400664 const ProgramUsage::VariableCounts& paramUsage = usage.get(*param);
665 if (!paramUsage.fWrite) {
666 // ... and can be inlined trivially (e.g. a swizzle, or a constant array index),
667 // or any expression without side effects that is only accessed at most once...
John Stiles941812f2021-09-16 15:12:02 -0400668 if ((paramUsage.fRead > 1) ? Analysis::IsTrivialExpression(*arg)
669 : !arg->hasSideEffects()) {
John Stilesf201af82020-09-29 16:57:55 -0400670 // ... we don't need to copy it at all! We can just use the existing expression.
John Stiles941812f2021-09-16 15:12:02 -0400671 varMap[param] = arg->clone();
John Stiles44e96be2020-08-31 13:16:04 -0400672 continue;
673 }
674 }
John Stiles941812f2021-09-16 15:12:02 -0400675 ScratchVariable var = Variable::MakeScratchVariable(*fContext,
676 param->name(),
677 &arg->type(),
678 param->modifiers(),
679 symbolTable.get(),
680 std::move(arguments[i]));
John Stiles28257db2021-03-17 15:18:09 -0400681 inlineStatements.push_back(std::move(var.fVarDecl));
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400682 varMap[param] = VariableReference::Make(/*line=*/-1, var.fVarSymbol);
John Stiles44e96be2020-08-31 13:16:04 -0400683 }
684
John Stiles7b920442020-12-17 10:43:41 -0500685 for (const std::unique_ptr<Statement>& stmt : body.children()) {
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400686 inlineStatements.push_back(this->inlineStatement(line, &varMap, symbolTable.get(),
John Stiles28257db2021-03-17 15:18:09 -0400687 &resultExpr, returnComplexity, *stmt,
688 caller->isBuiltin()));
John Stiles44e96be2020-08-31 13:16:04 -0400689 }
690
John Stiles28257db2021-03-17 15:18:09 -0400691 SkASSERT(inlineStatements.count() <= expectedStmtCount);
692
John Stilesbf16b6c2021-03-12 19:24:31 -0500693 // Wrap all of the generated statements in a block. We need a real Block here, so we can't use
694 // MakeUnscoped. This is because we need to add another child statement to the Block later.
John Stiles28257db2021-03-17 15:18:09 -0400695 InlinedCall inlinedCall;
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400696 inlinedCall.fInlinedBody = Block::Make(line, std::move(inlineStatements),
John Stilesbf16b6c2021-03-12 19:24:31 -0500697 /*symbols=*/nullptr, /*isScope=*/false);
698
John Stiles0c2d14a2021-03-01 10:08:08 -0500699 if (resultExpr) {
700 // Return our result expression as-is.
John Stilese41b4ee2020-09-28 12:28:16 -0400701 inlinedCall.fReplacementExpr = std::move(resultExpr);
John Stiles2558c462021-03-16 17:49:20 -0400702 } else if (function.declaration().returnType().isVoid()) {
John Stiles44e96be2020-08-31 13:16:04 -0400703 // It's a void function, so it doesn't actually result in anything, but we have to return
704 // something non-null as a standin.
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400705 inlinedCall.fReplacementExpr = Literal::MakeBool(*fContext, line, /*value=*/false);
John Stiles0c2d14a2021-03-01 10:08:08 -0500706 } else {
707 // It's a non-void function, but it never created a result expression--that is, it never
John Stiles2dda50d2021-03-03 10:46:44 -0500708 // returned anything on any path! This should have been detected in the function finalizer.
709 // Still, discard our output and generate an error.
710 SkDEBUGFAIL("inliner found non-void function that fails to return a value on any path");
Ethan Nicholas89cfde12021-09-27 11:20:34 -0400711 fContext->fErrors->error(function.fLine, "inliner found non-void function '" +
712 function.declaration().name() +
713 "' that fails to return a value on any path");
John Stiles0c2d14a2021-03-01 10:08:08 -0500714 inlinedCall = {};
John Stiles44e96be2020-08-31 13:16:04 -0400715 }
716
John Stiles44e96be2020-08-31 13:16:04 -0400717 return inlinedCall;
718}
719
John Stiles2d7973a2020-10-02 15:01:03 -0400720bool Inliner::isSafeToInline(const FunctionDefinition* functionDef) {
John Stiles1c03d332020-10-13 10:30:23 -0400721 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
John Stilesd1204642021-02-17 16:30:02 -0500722 if (this->settings().fInlineThreshold <= 0) {
John Stiles1c03d332020-10-13 10:30:23 -0400723 return false;
724 }
725
John Stiles031a7672020-11-13 16:13:18 -0500726 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
727 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
728 return false;
729 }
730
John Stiles2d7973a2020-10-02 15:01:03 -0400731 if (functionDef == nullptr) {
John Stiles44e96be2020-08-31 13:16:04 -0400732 // Can't inline something if we don't actually have its definition.
733 return false;
734 }
John Stiles2d7973a2020-10-02 15:01:03 -0400735
John Stiles0dd1a772021-03-09 22:14:27 -0500736 if (functionDef->declaration().modifiers().fFlags & Modifiers::kNoInline_Flag) {
737 // Refuse to inline functions decorated with `noinline`.
738 return false;
739 }
740
John Stilesbff24ab2021-03-17 13:20:10 -0400741 // We don't allow inlining a function with out parameters. (See skia:11326 for rationale.)
742 for (const Variable* param : functionDef->declaration().parameters()) {
743 if (param->modifiers().fFlags & Modifiers::Flag::kOut_Flag) {
744 return false;
745 }
746 }
747
John Stilesdc208472021-03-17 10:58:16 -0400748 // We don't have a mechanism to simulate early returns, so we can't inline if there is one.
749 return GetReturnComplexity(*functionDef) < ReturnComplexity::kEarlyReturns;
John Stiles44e96be2020-08-31 13:16:04 -0400750}
751
John Stiles2d7973a2020-10-02 15:01:03 -0400752// A candidate function for inlining, containing everything that `inlineCall` needs.
753struct InlineCandidate {
John Stiles78047582020-12-16 16:17:41 -0500754 std::shared_ptr<SymbolTable> fSymbols; // the SymbolTable of the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400755 std::unique_ptr<Statement>* fParentStmt; // the parent Statement of the enclosing stmt
756 std::unique_ptr<Statement>* fEnclosingStmt; // the Statement containing the candidate
757 std::unique_ptr<Expression>* fCandidateExpr; // the candidate FunctionCall to be inlined
758 FunctionDefinition* fEnclosingFunction; // the Function containing the candidate
John Stiles2d7973a2020-10-02 15:01:03 -0400759};
John Stiles93442622020-09-11 12:11:27 -0400760
John Stiles2d7973a2020-10-02 15:01:03 -0400761struct InlineCandidateList {
762 std::vector<InlineCandidate> fCandidates;
763};
764
765class InlineCandidateAnalyzer {
John Stiles70957c82020-10-02 16:42:10 -0400766public:
767 // A list of all the inlining candidates we found during analysis.
768 InlineCandidateList* fCandidateList;
John Stiles2d7973a2020-10-02 15:01:03 -0400769
John Stiles70957c82020-10-02 16:42:10 -0400770 // A stack of the symbol tables; since most nodes don't have one, expected to be shallower than
771 // the enclosing-statement stack.
John Stiles78047582020-12-16 16:17:41 -0500772 std::vector<std::shared_ptr<SymbolTable>> fSymbolTableStack;
John Stiles70957c82020-10-02 16:42:10 -0400773 // A stack of "enclosing" statements--these would be suitable for the inliner to use for adding
774 // new instructions. Not all statements are suitable (e.g. a for-loop's initializer). The
775 // inliner might replace a statement with a block containing the statement.
776 std::vector<std::unique_ptr<Statement>*> fEnclosingStmtStack;
777 // The function that we're currently processing (i.e. inlining into).
778 FunctionDefinition* fEnclosingFunction = nullptr;
John Stiles93442622020-09-11 12:11:27 -0400779
Brian Osman0006ad02020-11-18 15:38:39 -0500780 void visit(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -0500781 std::shared_ptr<SymbolTable> symbols,
Brian Osman0006ad02020-11-18 15:38:39 -0500782 InlineCandidateList* candidateList) {
John Stiles70957c82020-10-02 16:42:10 -0400783 fCandidateList = candidateList;
Brian Osman0006ad02020-11-18 15:38:39 -0500784 fSymbolTableStack.push_back(symbols);
John Stiles93442622020-09-11 12:11:27 -0400785
Brian Osman0006ad02020-11-18 15:38:39 -0500786 for (const std::unique_ptr<ProgramElement>& pe : elements) {
Brian Osman1179fcf2020-10-08 16:04:40 -0400787 this->visitProgramElement(pe.get());
John Stiles93442622020-09-11 12:11:27 -0400788 }
789
John Stiles70957c82020-10-02 16:42:10 -0400790 fSymbolTableStack.pop_back();
791 fCandidateList = nullptr;
792 }
793
794 void visitProgramElement(ProgramElement* pe) {
795 switch (pe->kind()) {
796 case ProgramElement::Kind::kFunction: {
797 FunctionDefinition& funcDef = pe->as<FunctionDefinition>();
Brian Osman0006ad02020-11-18 15:38:39 -0500798 fEnclosingFunction = &funcDef;
799 this->visitStatement(&funcDef.body());
John Stiles70957c82020-10-02 16:42:10 -0400800 break;
John Stiles93442622020-09-11 12:11:27 -0400801 }
John Stiles70957c82020-10-02 16:42:10 -0400802 default:
803 // The inliner can't operate outside of a function's scope.
804 break;
805 }
806 }
807
808 void visitStatement(std::unique_ptr<Statement>* stmt,
809 bool isViableAsEnclosingStatement = true) {
810 if (!*stmt) {
811 return;
John Stiles93442622020-09-11 12:11:27 -0400812 }
813
John Stiles70957c82020-10-02 16:42:10 -0400814 size_t oldEnclosingStmtStackSize = fEnclosingStmtStack.size();
815 size_t oldSymbolStackSize = fSymbolTableStack.size();
John Stiles93442622020-09-11 12:11:27 -0400816
John Stiles70957c82020-10-02 16:42:10 -0400817 if (isViableAsEnclosingStatement) {
818 fEnclosingStmtStack.push_back(stmt);
John Stiles93442622020-09-11 12:11:27 -0400819 }
820
John Stiles70957c82020-10-02 16:42:10 -0400821 switch ((*stmt)->kind()) {
822 case Statement::Kind::kBreak:
823 case Statement::Kind::kContinue:
824 case Statement::Kind::kDiscard:
825 case Statement::Kind::kInlineMarker:
826 case Statement::Kind::kNop:
827 break;
828
829 case Statement::Kind::kBlock: {
830 Block& block = (*stmt)->as<Block>();
831 if (block.symbolTable()) {
John Stiles78047582020-12-16 16:17:41 -0500832 fSymbolTableStack.push_back(block.symbolTable());
John Stiles70957c82020-10-02 16:42:10 -0400833 }
834
John Stiles628777c2021-08-04 22:07:41 -0400835 for (std::unique_ptr<Statement>& blockStmt : block.children()) {
836 this->visitStatement(&blockStmt);
John Stiles70957c82020-10-02 16:42:10 -0400837 }
838 break;
John Stiles93442622020-09-11 12:11:27 -0400839 }
John Stiles70957c82020-10-02 16:42:10 -0400840 case Statement::Kind::kDo: {
841 DoStatement& doStmt = (*stmt)->as<DoStatement>();
842 // The loop body is a candidate for inlining.
843 this->visitStatement(&doStmt.statement());
844 // The inliner isn't smart enough to inline the test-expression for a do-while
845 // loop at this time. There are two limitations:
846 // - We would need to insert the inlined-body block at the very end of the do-
847 // statement's inner fStatement. We don't support that today, but it's doable.
848 // - We cannot inline the test expression if the loop uses `continue` anywhere; that
849 // would skip over the inlined block that evaluates the test expression. There
850 // isn't a good fix for this--any workaround would be more complex than the cost
851 // of a function call. However, loops that don't use `continue` would still be
852 // viable candidates for inlining.
853 break;
John Stiles93442622020-09-11 12:11:27 -0400854 }
John Stiles70957c82020-10-02 16:42:10 -0400855 case Statement::Kind::kExpression: {
856 ExpressionStatement& expr = (*stmt)->as<ExpressionStatement>();
857 this->visitExpression(&expr.expression());
858 break;
859 }
860 case Statement::Kind::kFor: {
861 ForStatement& forStmt = (*stmt)->as<ForStatement>();
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400862 if (forStmt.symbols()) {
John Stiles78047582020-12-16 16:17:41 -0500863 fSymbolTableStack.push_back(forStmt.symbols());
John Stiles70957c82020-10-02 16:42:10 -0400864 }
865
866 // The initializer and loop body are candidates for inlining.
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400867 this->visitStatement(&forStmt.initializer(),
John Stiles70957c82020-10-02 16:42:10 -0400868 /*isViableAsEnclosingStatement=*/false);
Ethan Nicholas0d31ed52020-10-05 14:47:09 -0400869 this->visitStatement(&forStmt.statement());
John Stiles70957c82020-10-02 16:42:10 -0400870
871 // The inliner isn't smart enough to inline the test- or increment-expressions
872 // of a for loop loop at this time. There are a handful of limitations:
873 // - We would need to insert the test-expression block at the very beginning of the
874 // for-loop's inner fStatement, and the increment-expression block at the very
875 // end. We don't support that today, but it's doable.
876 // - The for-loop's built-in test-expression would need to be dropped entirely,
877 // and the loop would be halted via a break statement at the end of the inlined
878 // test-expression. This is again something we don't support today, but it could
879 // be implemented.
880 // - We cannot inline the increment-expression if the loop uses `continue` anywhere;
881 // that would skip over the inlined block that evaluates the increment expression.
882 // There isn't a good fix for this--any workaround would be more complex than the
883 // cost of a function call. However, loops that don't use `continue` would still
884 // be viable candidates for increment-expression inlining.
885 break;
886 }
887 case Statement::Kind::kIf: {
888 IfStatement& ifStmt = (*stmt)->as<IfStatement>();
Ethan Nicholas8c44eca2020-10-07 16:47:09 -0400889 this->visitExpression(&ifStmt.test());
890 this->visitStatement(&ifStmt.ifTrue());
891 this->visitStatement(&ifStmt.ifFalse());
John Stiles70957c82020-10-02 16:42:10 -0400892 break;
893 }
894 case Statement::Kind::kReturn: {
895 ReturnStatement& returnStmt = (*stmt)->as<ReturnStatement>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -0400896 this->visitExpression(&returnStmt.expression());
John Stiles70957c82020-10-02 16:42:10 -0400897 break;
898 }
899 case Statement::Kind::kSwitch: {
900 SwitchStatement& switchStmt = (*stmt)->as<SwitchStatement>();
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400901 if (switchStmt.symbols()) {
John Stiles78047582020-12-16 16:17:41 -0500902 fSymbolTableStack.push_back(switchStmt.symbols());
John Stiles70957c82020-10-02 16:42:10 -0400903 }
904
Ethan Nicholas01b05e52020-10-22 15:53:41 -0400905 this->visitExpression(&switchStmt.value());
John Stilesb23a64b2021-03-11 08:27:59 -0500906 for (const std::unique_ptr<Statement>& switchCase : switchStmt.cases()) {
John Stiles70957c82020-10-02 16:42:10 -0400907 // The switch-case's fValue cannot be a FunctionCall; skip it.
John Stilesb23a64b2021-03-11 08:27:59 -0500908 this->visitStatement(&switchCase->as<SwitchCase>().statement());
John Stiles70957c82020-10-02 16:42:10 -0400909 }
910 break;
911 }
912 case Statement::Kind::kVarDeclaration: {
913 VarDeclaration& varDeclStmt = (*stmt)->as<VarDeclaration>();
914 // Don't need to scan the declaration's sizes; those are always IntLiterals.
Ethan Nicholasc51f33e2020-10-13 13:49:44 -0400915 this->visitExpression(&varDeclStmt.value());
John Stiles70957c82020-10-02 16:42:10 -0400916 break;
917 }
John Stiles70957c82020-10-02 16:42:10 -0400918 default:
919 SkUNREACHABLE;
John Stiles93442622020-09-11 12:11:27 -0400920 }
921
John Stiles70957c82020-10-02 16:42:10 -0400922 // Pop our symbol and enclosing-statement stacks.
923 fSymbolTableStack.resize(oldSymbolStackSize);
924 fEnclosingStmtStack.resize(oldEnclosingStmtStackSize);
925 }
926
927 void visitExpression(std::unique_ptr<Expression>* expr) {
928 if (!*expr) {
929 return;
John Stiles93442622020-09-11 12:11:27 -0400930 }
John Stiles70957c82020-10-02 16:42:10 -0400931
932 switch ((*expr)->kind()) {
Brian Osmanbe0b3b72021-01-06 14:27:35 -0500933 case Expression::Kind::kExternalFunctionReference:
John Stiles70957c82020-10-02 16:42:10 -0400934 case Expression::Kind::kFieldAccess:
John Stiles70957c82020-10-02 16:42:10 -0400935 case Expression::Kind::kFunctionReference:
John Stiles7591d4b2021-09-13 13:32:06 -0400936 case Expression::Kind::kLiteral:
Brian Osman3099f792021-09-01 13:12:16 -0400937 case Expression::Kind::kMethodReference:
John Stiles70957c82020-10-02 16:42:10 -0400938 case Expression::Kind::kSetting:
939 case Expression::Kind::kTypeReference:
940 case Expression::Kind::kVariableReference:
941 // Nothing to scan here.
942 break;
943
944 case Expression::Kind::kBinary: {
945 BinaryExpression& binaryExpr = (*expr)->as<BinaryExpression>();
John Stiles2d4f9592020-10-30 10:29:12 -0400946 this->visitExpression(&binaryExpr.left());
John Stiles70957c82020-10-02 16:42:10 -0400947
948 // Logical-and and logical-or binary expressions do not inline the right side,
949 // because that would invalidate short-circuiting. That is, when evaluating
950 // expressions like these:
951 // (false && x()) // always false
952 // (true || y()) // always true
953 // It is illegal for side-effects from x() or y() to occur. The simplest way to
954 // enforce that rule is to avoid inlining the right side entirely. However, it is
955 // safe for other types of binary expression to inline both sides.
John Stiles45990502021-02-16 10:55:27 -0500956 Operator op = binaryExpr.getOperator();
957 bool shortCircuitable = (op.kind() == Token::Kind::TK_LOGICALAND ||
958 op.kind() == Token::Kind::TK_LOGICALOR);
John Stiles70957c82020-10-02 16:42:10 -0400959 if (!shortCircuitable) {
John Stiles2d4f9592020-10-30 10:29:12 -0400960 this->visitExpression(&binaryExpr.right());
John Stiles70957c82020-10-02 16:42:10 -0400961 }
962 break;
963 }
Brian Osmaneb0f29d2021-08-04 11:34:16 -0400964 case Expression::Kind::kChildCall: {
965 ChildCall& childCallExpr = (*expr)->as<ChildCall>();
966 for (std::unique_ptr<Expression>& arg : childCallExpr.arguments()) {
967 this->visitExpression(&arg);
968 }
969 break;
970 }
John Stiles7384b372021-04-01 13:48:15 -0400971 case Expression::Kind::kConstructorArray:
John Stilese3ae9682021-08-05 10:35:01 -0400972 case Expression::Kind::kConstructorArrayCast:
John Stiles8cad6372021-04-07 12:31:13 -0400973 case Expression::Kind::kConstructorCompound:
974 case Expression::Kind::kConstructorCompoundCast:
John Stiles2938eea2021-04-01 18:58:25 -0400975 case Expression::Kind::kConstructorDiagonalMatrix:
John Stiles5abb9e12021-04-06 13:47:19 -0400976 case Expression::Kind::kConstructorMatrixResize:
John Stilesfd7252f2021-04-04 22:24:40 -0400977 case Expression::Kind::kConstructorScalarCast:
John Stilesd47330f2021-04-08 23:25:52 -0400978 case Expression::Kind::kConstructorSplat:
979 case Expression::Kind::kConstructorStruct: {
John Stiles7384b372021-04-01 13:48:15 -0400980 AnyConstructor& constructorExpr = (*expr)->asAnyConstructor();
981 for (std::unique_ptr<Expression>& arg : constructorExpr.argumentSpan()) {
John Stiles70957c82020-10-02 16:42:10 -0400982 this->visitExpression(&arg);
983 }
984 break;
985 }
986 case Expression::Kind::kExternalFunctionCall: {
987 ExternalFunctionCall& funcCallExpr = (*expr)->as<ExternalFunctionCall>();
988 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
989 this->visitExpression(&arg);
990 }
991 break;
992 }
993 case Expression::Kind::kFunctionCall: {
994 FunctionCall& funcCallExpr = (*expr)->as<FunctionCall>();
Ethan Nicholas0dec9922020-10-05 15:51:52 -0400995 for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) {
John Stiles70957c82020-10-02 16:42:10 -0400996 this->visitExpression(&arg);
997 }
998 this->addInlineCandidate(expr);
999 break;
1000 }
John Stiles708faba2021-03-19 09:43:23 -04001001 case Expression::Kind::kIndex: {
John Stiles70957c82020-10-02 16:42:10 -04001002 IndexExpression& indexExpr = (*expr)->as<IndexExpression>();
Ethan Nicholas2a4952d2020-10-08 15:35:56 -04001003 this->visitExpression(&indexExpr.base());
1004 this->visitExpression(&indexExpr.index());
John Stiles70957c82020-10-02 16:42:10 -04001005 break;
1006 }
1007 case Expression::Kind::kPostfix: {
1008 PostfixExpression& postfixExpr = (*expr)->as<PostfixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -04001009 this->visitExpression(&postfixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001010 break;
1011 }
1012 case Expression::Kind::kPrefix: {
1013 PrefixExpression& prefixExpr = (*expr)->as<PrefixExpression>();
Ethan Nicholas444ccc62020-10-09 10:16:22 -04001014 this->visitExpression(&prefixExpr.operand());
John Stiles70957c82020-10-02 16:42:10 -04001015 break;
1016 }
1017 case Expression::Kind::kSwizzle: {
1018 Swizzle& swizzleExpr = (*expr)->as<Swizzle>();
Ethan Nicholas6b4d5812020-10-12 16:11:51 -04001019 this->visitExpression(&swizzleExpr.base());
John Stiles70957c82020-10-02 16:42:10 -04001020 break;
1021 }
1022 case Expression::Kind::kTernary: {
1023 TernaryExpression& ternaryExpr = (*expr)->as<TernaryExpression>();
1024 // The test expression is a candidate for inlining.
Ethan Nicholasdd218162020-10-08 05:48:01 -04001025 this->visitExpression(&ternaryExpr.test());
John Stiles70957c82020-10-02 16:42:10 -04001026 // The true- and false-expressions cannot be inlined, because we are only allowed to
1027 // evaluate one side.
1028 break;
1029 }
1030 default:
1031 SkUNREACHABLE;
1032 }
1033 }
1034
1035 void addInlineCandidate(std::unique_ptr<Expression>* candidate) {
1036 fCandidateList->fCandidates.push_back(
1037 InlineCandidate{fSymbolTableStack.back(),
1038 find_parent_statement(fEnclosingStmtStack),
1039 fEnclosingStmtStack.back(),
1040 candidate,
John Stiles9b9415e2020-11-23 14:48:06 -05001041 fEnclosingFunction});
John Stiles70957c82020-10-02 16:42:10 -04001042 }
John Stiles2d7973a2020-10-02 15:01:03 -04001043};
John Stiles93442622020-09-11 12:11:27 -04001044
John Stiles9b9415e2020-11-23 14:48:06 -05001045static const FunctionDeclaration& candidate_func(const InlineCandidate& candidate) {
1046 return (*candidate.fCandidateExpr)->as<FunctionCall>().function();
1047}
John Stiles915a38c2020-09-14 09:38:13 -04001048
John Stiles9b9415e2020-11-23 14:48:06 -05001049bool Inliner::candidateCanBeInlined(const InlineCandidate& candidate, InlinabilityCache* cache) {
1050 const FunctionDeclaration& funcDecl = candidate_func(candidate);
John Stiles1c03d332020-10-13 10:30:23 -04001051 auto [iter, wasInserted] = cache->insert({&funcDecl, false});
John Stiles2d7973a2020-10-02 15:01:03 -04001052 if (wasInserted) {
1053 // Recursion is forbidden here to avoid an infinite death spiral of inlining.
John Stiles132cfdd2021-03-15 22:08:38 +00001054 iter->second = this->isSafeToInline(funcDecl.definition()) &&
1055 !contains_recursive_call(funcDecl);
John Stiles93442622020-09-11 12:11:27 -04001056 }
1057
John Stiles2d7973a2020-10-02 15:01:03 -04001058 return iter->second;
1059}
1060
John Stiles9b9415e2020-11-23 14:48:06 -05001061int Inliner::getFunctionSize(const FunctionDeclaration& funcDecl, FunctionSizeCache* cache) {
1062 auto [iter, wasInserted] = cache->insert({&funcDecl, 0});
John Stiles2d7973a2020-10-02 15:01:03 -04001063 if (wasInserted) {
John Stiles9b9415e2020-11-23 14:48:06 -05001064 iter->second = Analysis::NodeCountUpToLimit(*funcDecl.definition(),
John Stilesd1204642021-02-17 16:30:02 -05001065 this->settings().fInlineThreshold);
John Stiles2d7973a2020-10-02 15:01:03 -04001066 }
John Stiles2d7973a2020-10-02 15:01:03 -04001067 return iter->second;
1068}
1069
Brian Osman0006ad02020-11-18 15:38:39 -05001070void Inliner::buildCandidateList(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -05001071 std::shared_ptr<SymbolTable> symbols, ProgramUsage* usage,
Brian Osman0006ad02020-11-18 15:38:39 -05001072 InlineCandidateList* candidateList) {
John Stiles2d7973a2020-10-02 15:01:03 -04001073 // This is structured much like a ProgramVisitor, but does not actually use ProgramVisitor.
1074 // The analyzer needs to keep track of the `unique_ptr<T>*` of statements and expressions so
1075 // that they can later be replaced, and ProgramVisitor does not provide this; it only provides a
1076 // `const T&`.
1077 InlineCandidateAnalyzer analyzer;
Brian Osman0006ad02020-11-18 15:38:39 -05001078 analyzer.visit(elements, symbols, candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001079
John Stiles0ad233f2020-11-25 11:02:05 -05001080 // Early out if there are no inlining candidates.
John Stiles2d7973a2020-10-02 15:01:03 -04001081 std::vector<InlineCandidate>& candidates = candidateList->fCandidates;
John Stiles0ad233f2020-11-25 11:02:05 -05001082 if (candidates.empty()) {
1083 return;
1084 }
1085
1086 // Remove candidates that are not safe to inline.
John Stiles2d7973a2020-10-02 15:01:03 -04001087 InlinabilityCache cache;
1088 candidates.erase(std::remove_if(candidates.begin(),
1089 candidates.end(),
1090 [&](const InlineCandidate& candidate) {
1091 return !this->candidateCanBeInlined(candidate, &cache);
1092 }),
1093 candidates.end());
1094
John Stiles0ad233f2020-11-25 11:02:05 -05001095 // If the inline threshold is unlimited, or if we have no candidates left, our candidate list is
1096 // complete.
John Stilesd1204642021-02-17 16:30:02 -05001097 if (this->settings().fInlineThreshold == INT_MAX || candidates.empty()) {
John Stiles0ad233f2020-11-25 11:02:05 -05001098 return;
John Stiles2d7973a2020-10-02 15:01:03 -04001099 }
John Stiles0ad233f2020-11-25 11:02:05 -05001100
1101 // Remove candidates on a per-function basis if the effect of inlining would be to make more
1102 // than `inlineThreshold` nodes. (i.e. if Func() would be inlined six times and its size is
1103 // 10 nodes, it should be inlined if the inlineThreshold is 60 or higher.)
1104 FunctionSizeCache functionSizeCache;
1105 FunctionSizeCache candidateTotalCost;
1106 for (InlineCandidate& candidate : candidates) {
1107 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1108 candidateTotalCost[&fnDecl] += this->getFunctionSize(fnDecl, &functionSizeCache);
1109 }
1110
John Stilesd1204642021-02-17 16:30:02 -05001111 candidates.erase(std::remove_if(candidates.begin(), candidates.end(),
1112 [&](const InlineCandidate& candidate) {
1113 const FunctionDeclaration& fnDecl = candidate_func(candidate);
1114 if (fnDecl.modifiers().fFlags & Modifiers::kInline_Flag) {
1115 // Functions marked `inline` ignore size limitations.
1116 return false;
1117 }
1118 if (usage->get(fnDecl) == 1) {
1119 // If a function is only used once, it's cost-free to inline.
1120 return false;
1121 }
1122 if (candidateTotalCost[&fnDecl] <= this->settings().fInlineThreshold) {
1123 // We won't exceed the inline threshold by inlining this.
1124 return false;
1125 }
1126 // Inlining this function will add too many IRNodes.
1127 return true;
1128 }),
1129 candidates.end());
John Stiles2d7973a2020-10-02 15:01:03 -04001130}
1131
Brian Osman0006ad02020-11-18 15:38:39 -05001132bool Inliner::analyze(const std::vector<std::unique_ptr<ProgramElement>>& elements,
John Stiles78047582020-12-16 16:17:41 -05001133 std::shared_ptr<SymbolTable> symbols,
Brian Osman0006ad02020-11-18 15:38:39 -05001134 ProgramUsage* usage) {
John Stilesd34d56e2020-10-12 12:04:47 -04001135 // A threshold of zero indicates that the inliner is completely disabled, so we can just return.
John Stilesd1204642021-02-17 16:30:02 -05001136 if (this->settings().fInlineThreshold <= 0) {
John Stilesd34d56e2020-10-12 12:04:47 -04001137 return false;
1138 }
1139
John Stiles031a7672020-11-13 16:13:18 -05001140 // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl)
1141 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1142 return false;
1143 }
1144
John Stiles2d7973a2020-10-02 15:01:03 -04001145 InlineCandidateList candidateList;
John Stiles9b9415e2020-11-23 14:48:06 -05001146 this->buildCandidateList(elements, symbols, usage, &candidateList);
John Stiles2d7973a2020-10-02 15:01:03 -04001147
John Stiles915a38c2020-09-14 09:38:13 -04001148 // Inline the candidates where we've determined that it's safe to do so.
John Stiles708faba2021-03-19 09:43:23 -04001149 using StatementRemappingTable = std::unordered_map<std::unique_ptr<Statement>*,
1150 std::unique_ptr<Statement>*>;
1151 StatementRemappingTable statementRemappingTable;
1152
John Stiles915a38c2020-09-14 09:38:13 -04001153 bool madeChanges = false;
John Stiles2d7973a2020-10-02 15:01:03 -04001154 for (const InlineCandidate& candidate : candidateList.fCandidates) {
John Stiles915a38c2020-09-14 09:38:13 -04001155 FunctionCall& funcCall = (*candidate.fCandidateExpr)->as<FunctionCall>();
John Stiles915a38c2020-09-14 09:38:13 -04001156
John Stiles915a38c2020-09-14 09:38:13 -04001157 // Convert the function call to its inlined equivalent.
John Stiles30fce9c2021-03-18 09:24:06 -04001158 InlinedCall inlinedCall = this->inlineCall(&funcCall, candidate.fSymbols, *usage,
Ethan Nicholas0a5d0962020-10-14 13:33:18 -04001159 &candidate.fEnclosingFunction->declaration());
John Stiles915a38c2020-09-14 09:38:13 -04001160
John Stiles0c2d14a2021-03-01 10:08:08 -05001161 // Stop if an error was detected during the inlining process.
1162 if (!inlinedCall.fInlinedBody && !inlinedCall.fReplacementExpr) {
1163 break;
John Stiles915a38c2020-09-14 09:38:13 -04001164 }
1165
John Stiles0c2d14a2021-03-01 10:08:08 -05001166 // Ensure that the inlined body has a scope if it needs one.
1167 this->ensureScopedBlocks(inlinedCall.fInlinedBody.get(), candidate.fParentStmt->get());
1168
1169 // Add references within the inlined body
1170 usage->add(inlinedCall.fInlinedBody.get());
1171
John Stiles708faba2021-03-19 09:43:23 -04001172 // Look up the enclosing statement; remap it if necessary.
1173 std::unique_ptr<Statement>* enclosingStmt = candidate.fEnclosingStmt;
1174 for (;;) {
1175 auto iter = statementRemappingTable.find(enclosingStmt);
1176 if (iter == statementRemappingTable.end()) {
1177 break;
1178 }
1179 enclosingStmt = iter->second;
1180 }
1181
John Stiles0c2d14a2021-03-01 10:08:08 -05001182 // Move the enclosing statement to the end of the unscoped Block containing the inlined
1183 // function, then replace the enclosing statement with that Block.
1184 // Before:
1185 // fInlinedBody = Block{ stmt1, stmt2, stmt3 }
1186 // fEnclosingStmt = stmt4
1187 // After:
1188 // fInlinedBody = null
1189 // fEnclosingStmt = Block{ stmt1, stmt2, stmt3, stmt4 }
John Stiles708faba2021-03-19 09:43:23 -04001190 inlinedCall.fInlinedBody->children().push_back(std::move(*enclosingStmt));
1191 *enclosingStmt = std::move(inlinedCall.fInlinedBody);
John Stiles0c2d14a2021-03-01 10:08:08 -05001192
John Stiles915a38c2020-09-14 09:38:13 -04001193 // Replace the candidate function call with our replacement expression.
John Stiles60dbf072021-08-02 14:22:34 -04001194 usage->remove(candidate.fCandidateExpr->get());
1195 usage->add(inlinedCall.fReplacementExpr.get());
John Stiles915a38c2020-09-14 09:38:13 -04001196 *candidate.fCandidateExpr = std::move(inlinedCall.fReplacementExpr);
1197 madeChanges = true;
1198
John Stiles708faba2021-03-19 09:43:23 -04001199 // If anything else pointed at our enclosing statement, it's now pointing at a Block
1200 // containing many other statements as well. Maintain a fix-up table to account for this.
1201 statementRemappingTable[enclosingStmt] = &(*enclosingStmt)->as<Block>().children().back();
1202
John Stiles031a7672020-11-13 16:13:18 -05001203 // Stop inlining if we've reached our hard cap on new statements.
1204 if (fInlinedStatementCounter >= kInlinedStatementLimit) {
1205 break;
1206 }
1207
John Stiles915a38c2020-09-14 09:38:13 -04001208 // Note that nothing was destroyed except for the FunctionCall. All other nodes should
1209 // remain valid.
1210 }
1211
1212 return madeChanges;
John Stiles93442622020-09-11 12:11:27 -04001213}
1214
John Stiles44e96be2020-08-31 13:16:04 -04001215} // namespace SkSL