blob: 67aa98d3c83f9815b55d1b7ee7e911f326b3c019 [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Yves Gerey3e707812018-11-28 16:47:49 +010011#include <stdint.h>
Jonas Olssona4d87372019-07-05 19:08:33 +020012
Henrik Boström933d8b02017-10-10 10:05:16 -070013#include <memory>
Yves Gerey3e707812018-11-28 16:47:49 +010014#include <string>
15#include <utility>
Henrik Boström933d8b02017-10-10 10:05:16 -070016#include <vector>
17
Karl Wiberg918f50c2018-07-05 11:40:33 +020018#include "absl/memory/memory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010019#include "absl/types/optional.h"
20#include "api/audio/audio_mixer.h"
21#include "api/audio_codecs/audio_decoder_factory.h"
22#include "api/audio_codecs/audio_encoder_factory.h"
Karl Wiberg1b0eae32017-10-17 14:48:54 +020023#include "api/audio_codecs/builtin_audio_decoder_factory.h"
24#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Mirko Bonadei2ff3f492018-11-22 09:00:13 +010025#include "api/create_peerconnection_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070026#include "api/jsep.h"
Steve Anton10542f22019-01-11 09:11:00 -080027#include "api/media_stream_interface.h"
28#include "api/media_types.h"
29#include "api/peer_connection_interface.h"
30#include "api/rtc_error.h"
31#include "api/rtp_parameters.h"
32#include "api/rtp_receiver_interface.h"
33#include "api/rtp_sender_interface.h"
34#include "api/rtp_transceiver_interface.h"
Mirko Bonadeid9708072019-01-25 20:26:48 +010035#include "api/scoped_refptr.h"
Steve Anton10542f22019-01-11 09:11:00 -080036#include "api/set_remote_description_observer_interface.h"
37#include "api/uma_metrics.h"
Anders Carlsson67537952018-05-03 11:28:29 +020038#include "api/video_codecs/builtin_video_decoder_factory.h"
39#include "api/video_codecs/builtin_video_encoder_factory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010040#include "api/video_codecs/video_decoder_factory.h"
41#include "api/video_codecs/video_encoder_factory.h"
Steve Anton10542f22019-01-11 09:11:00 -080042#include "media/base/stream_params.h"
Yves Gerey3e707812018-11-28 16:47:49 +010043#include "modules/audio_device/include/audio_device.h"
44#include "modules/audio_processing/include/audio_processing.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "p2p/base/port_allocator.h"
46#include "pc/media_session.h"
47#include "pc/peer_connection_wrapper.h"
48#include "pc/sdp_utils.h"
49#include "pc/session_description.h"
50#include "pc/test/fake_audio_capture_module.h"
51#include "pc/test/mock_peer_connection_observers.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070052#include "rtc_base/checks.h"
53#include "rtc_base/gunit.h"
Steve Anton10542f22019-01-11 09:11:00 -080054#include "rtc_base/ref_counted_object.h"
55#include "rtc_base/rtc_certificate_generator.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070056#include "rtc_base/thread.h"
Mirko Bonadei17f48782018-09-28 08:51:10 +020057#include "system_wrappers/include/metrics.h"
Steve Anton9158ef62017-11-27 13:01:52 -080058#include "test/gmock.h"
Yves Gerey3e707812018-11-28 16:47:49 +010059#include "test/gtest.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070060
61// This file contains tests for RTP Media API-related behavior of
62// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
63
Steve Anton9158ef62017-11-27 13:01:52 -080064namespace webrtc {
65
66using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
67using ::testing::ElementsAre;
Steve Antonc1e6e862019-03-04 14:43:44 -080068using ::testing::Pair;
Steve Anton9158ef62017-11-27 13:01:52 -080069using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 15:30:18 -070070using ::testing::Values;
Henrik Boström933d8b02017-10-10 10:05:16 -070071
Henrik Boström31638672017-11-23 17:48:32 +010072const uint32_t kDefaultTimeout = 10000u;
73
74template <typename MethodFunctor>
75class OnSuccessObserver : public rtc::RefCountedObject<
76 webrtc::SetRemoteDescriptionObserverInterface> {
77 public:
78 explicit OnSuccessObserver(MethodFunctor on_success)
79 : on_success_(std::move(on_success)) {}
80
81 // webrtc::SetRemoteDescriptionObserverInterface implementation.
82 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
83 RTC_CHECK(error.ok());
84 on_success_();
85 }
86
87 private:
88 MethodFunctor on_success_;
89};
90
Mirko Bonadei6a489f22019-04-09 15:11:12 +020091class PeerConnectionRtpBaseTest : public ::testing::Test {
Henrik Boström933d8b02017-10-10 10:05:16 -070092 public:
Steve Anton3172c032018-05-03 15:30:18 -070093 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
94 : sdp_semantics_(sdp_semantics),
95 pc_factory_(
Steve Anton9158ef62017-11-27 13:01:52 -080096 CreatePeerConnectionFactory(rtc::Thread::Current(),
97 rtc::Thread::Current(),
98 rtc::Thread::Current(),
99 FakeAudioCaptureModule::Create(),
100 CreateBuiltinAudioEncoderFactory(),
101 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 11:28:29 +0200102 CreateBuiltinVideoEncoderFactory(),
103 CreateBuiltinVideoDecoderFactory(),
104 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 12:54:53 -0700105 nullptr /* audio_processing */)) {
106 webrtc::metrics::Reset();
107 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700108
Steve Anton9158ef62017-11-27 13:01:52 -0800109 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
110 return CreatePeerConnection(RTCConfiguration());
111 }
112
Steve Antone831b8c2018-02-01 12:22:16 -0800113 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
114 RTCConfiguration config;
115 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 15:30:18 -0700116 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 12:22:16 -0800117 }
118
Steve Anton9158ef62017-11-27 13:01:52 -0800119 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
120 RTCConfiguration config;
121 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 15:30:18 -0700122 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 13:01:52 -0800123 }
124
125 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
126 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 15:30:18 -0700127 RTCConfiguration modified_config = config;
128 modified_config.sdp_semantics = sdp_semantics_;
129 return CreatePeerConnectionInternal(modified_config);
130 }
131
132 protected:
133 const SdpSemantics sdp_semantics_;
134 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
135
136 private:
137 // Private so that tests don't accidentally bypass the SdpSemantics
138 // adjustment.
139 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
140 const RTCConfiguration& config) {
Karl Wiberg918f50c2018-07-05 11:40:33 +0200141 auto observer = absl::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -0700142 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
143 observer.get());
Yves Gerey4e933292018-10-31 15:36:05 +0100144 EXPECT_TRUE(pc.get());
145 observer->SetPeerConnectionInterface(pc.get());
Karl Wiberg918f50c2018-07-05 11:40:33 +0200146 return absl::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
147 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -0700148 }
Steve Anton3172c032018-05-03 15:30:18 -0700149};
Henrik Boström933d8b02017-10-10 10:05:16 -0700150
Steve Anton3172c032018-05-03 15:30:18 -0700151class PeerConnectionRtpTest
152 : public PeerConnectionRtpBaseTest,
153 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 10:05:16 -0700154 protected:
Steve Anton3172c032018-05-03 15:30:18 -0700155 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
156};
157
158class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
159 protected:
160 PeerConnectionRtpTestPlanB()
161 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
162};
163
164class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
165 protected:
166 PeerConnectionRtpTestUnifiedPlan()
167 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Henrik Boström933d8b02017-10-10 10:05:16 -0700168};
169
Henrik Boström31638672017-11-23 17:48:32 +0100170// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
171// setting the remote description.
Henrik Boström31638672017-11-23 17:48:32 +0100172
Steve Anton3172c032018-05-03 15:30:18 -0700173TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700174 auto caller = CreatePeerConnection();
175 auto callee = CreatePeerConnection();
176
Steve Anton3172c032018-05-03 15:30:18 -0700177 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700178 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700179
Henrik Boström31638672017-11-23 17:48:32 +0100180 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700181 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100182 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 15:30:18 -0700183
184 if (sdp_semantics_ == SdpSemantics::kPlanB) {
185 // Since we are not supporting the no stream case with Plan B, there should
186 // be a generated stream, even though we didn't set one with AddTrack.
187 ASSERT_EQ(1u, add_track_event.streams.size());
188 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
189 } else {
190 EXPECT_EQ(0u, add_track_event.streams.size());
191 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700192}
193
Steve Anton3172c032018-05-03 15:30:18 -0700194TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700195 auto caller = CreatePeerConnection();
196 auto callee = CreatePeerConnection();
197
Steve Anton3172c032018-05-03 15:30:18 -0700198 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700199 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700200
Henrik Boström31638672017-11-23 17:48:32 +0100201 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100202 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100203 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700204 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100205 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
206 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700207}
208
Steve Anton3172c032018-05-03 15:30:18 -0700209TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700210 auto caller = CreatePeerConnection();
211 auto callee = CreatePeerConnection();
212
Steve Anton3172c032018-05-03 15:30:18 -0700213 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700214 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100215 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700216 ASSERT_TRUE(
217 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
218
Henrik Boström933d8b02017-10-10 10:05:16 -0700219 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700220 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700221
Henrik Boström31638672017-11-23 17:48:32 +0100222 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700223 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
224 callee->observer()->remove_track_events_);
225}
226
Steve Anton3172c032018-05-03 15:30:18 -0700227TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700228 auto caller = CreatePeerConnection();
229 auto callee = CreatePeerConnection();
230
Steve Anton3172c032018-05-03 15:30:18 -0700231 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700232 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100233 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700234 ASSERT_TRUE(
235 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
236
Henrik Boström933d8b02017-10-10 10:05:16 -0700237 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700238 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700239
Henrik Boström31638672017-11-23 17:48:32 +0100240 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700241 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
242 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700243 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700244}
245
Steve Anton3172c032018-05-03 15:30:18 -0700246TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700247 auto caller = CreatePeerConnection();
248 auto callee = CreatePeerConnection();
249
Seth Hampson845e8782018-03-02 11:34:10 -0800250 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700251 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
252 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700253 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100254 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 15:30:18 -0700255 ASSERT_TRUE(
256 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700257
258 // Remove "audio_track1".
259 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700260 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100261 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700262 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800263 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700264 callee->observer()->add_track_events_[0].receiver},
265 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700266 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
267 ASSERT_TRUE(
268 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700269
270 // Remove "audio_track2".
271 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700272 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100273 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700274 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
275 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700276 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700277}
278
Seth Hampson5b4f0752018-04-02 16:31:36 -0700279// Tests the edge case that if a stream ID changes for a given track that both
280// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 15:30:18 -0700281TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700282 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
283 auto caller = CreatePeerConnection();
284 auto callee = CreatePeerConnection();
285
286 const char kStreamId1[] = "stream1";
287 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700288 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700289 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700290 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
291
292 // Change the stream ID of the sender in the session description.
293 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 15:30:18 -0700294 auto* audio_desc =
295 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700296 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
297 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 15:30:18 -0700298 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700299
300 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
301 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
302 kStreamId2);
303 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
304 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
305 kStreamId1);
306}
307
Steve Anton8b815cd2018-02-16 16:14:42 -0800308// Tests that setting a remote description with sending transceivers will fire
309// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 16:31:36 -0700310// with receive only transceivers will not call OnTrack. One transceiver is
311// created without any stream_ids, while the other is created with multiple
312// stream_ids.
Steve Anton3172c032018-05-03 15:30:18 -0700313TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 16:31:36 -0700314 const std::string kStreamId1 = "video_stream1";
315 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700316 auto caller = CreatePeerConnection();
317 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800318
319 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 16:31:36 -0700320 RtpTransceiverInit video_transceiver_init;
321 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
322 auto video_transceiver =
323 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-16 16:14:42 -0800324
325 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
326
327 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
328 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
329 EXPECT_EQ(audio_transceiver->mid(),
330 callee->pc()->GetTransceivers()[0]->mid());
331 EXPECT_EQ(video_transceiver->mid(),
332 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700333 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
334 callee->pc()->GetTransceivers()[0]->receiver()->streams();
335 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
336 callee->pc()->GetTransceivers()[1]->receiver()->streams();
337 ASSERT_EQ(0u, audio_streams.size());
338 ASSERT_EQ(2u, video_streams.size());
339 EXPECT_EQ(kStreamId1, video_streams[0]->id());
340 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-16 16:14:42 -0800341}
342
343// Test that doing additional offer/answer exchanges with no changes to tracks
344// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 15:30:18 -0700345TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
346 auto caller = CreatePeerConnection();
347 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800348
349 caller->AddAudioTrack("audio");
350 callee->AddAudioTrack("audio");
351
352 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
353 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
354 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
355
356 // If caller reoffers with no changes expect no additional OnTrack calls.
357 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
358 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
359 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
360
361 // Also if callee reoffers with no changes expect no additional OnTrack calls.
362 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
363 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
364 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
365}
366
367// Test that OnTrack is called when the transceiver direction changes to send
368// the track.
Steve Anton3172c032018-05-03 15:30:18 -0700369TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
370 auto caller = CreatePeerConnection();
371 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800372
373 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
374 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
375 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
376 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
377 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
378
379 transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
380 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
381 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
382 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
383
384 // If the direction changes but it is still receiving on the remote side, then
385 // OnTrack should not be fired again.
386 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
387 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
388 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
389 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
390}
391
392// Test that OnTrack is called twice when a sendrecv call is started, the callee
393// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -0700394TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
395 auto caller = CreatePeerConnection();
396 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800397
398 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
399
400 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
401 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
402 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
403
404 // Put the call on hold by no longer receiving the track.
405 callee->pc()->GetTransceivers()[0]->SetDirection(
406 RtpTransceiverDirection::kInactive);
407
408 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
409 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
410 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
411
412 // Resume the call by changing the direction to recvonly. This should call
413 // OnTrack again on the callee side.
414 callee->pc()->GetTransceivers()[0]->SetDirection(
415 RtpTransceiverDirection::kRecvOnly);
416
417 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
418 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
419 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
420}
421
Steve Anton3172c032018-05-03 15:30:18 -0700422// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 14:25:36 -0700423// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 15:30:18 -0700424TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700425 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 17:48:32 +0100426 auto caller = CreatePeerConnection();
427 auto callee = CreatePeerConnection();
428
Steve Anton3172c032018-05-03 15:30:18 -0700429 caller->AddAudioTrack("audio_track", {});
430
Amit Hilbuchae3df542019-01-07 12:13:08 -0800431 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700432 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
433
Amit Hilbuchae3df542019-01-07 12:13:08 -0800434 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton0f5400a2018-07-17 14:25:36 -0700435 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700436}
437
438// Test that setting a remote offer twice with no answer in the middle and the
439// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 14:25:36 -0700440// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 15:30:18 -0700441TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700442 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 15:30:18 -0700443 auto caller = CreatePeerConnection();
444 auto callee = CreatePeerConnection();
445
446 auto sender = caller->AddAudioTrack("audio_track", {});
447
Amit Hilbuchae3df542019-01-07 12:13:08 -0800448 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700449 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700450 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700451
452 caller->pc()->RemoveTrack(sender);
453
Amit Hilbuchae3df542019-01-07 12:13:08 -0800454 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700455 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700456 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
457}
458
459// Test that changing the direction from receiving to not receiving between
460// setting the remote offer and creating / setting the local answer results in
461// a remove track event when SetLocalDescription is called.
462TEST_F(PeerConnectionRtpTestUnifiedPlan,
463 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
464 auto caller = CreatePeerConnection();
465 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
466 auto callee = CreatePeerConnection();
467 callee->AddAudioTrack("audio_track", {});
468
469 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
470 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700471 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700472
473 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
474 callee_transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
475
476 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
477 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
478 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700479}
480
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100481TEST_F(PeerConnectionRtpTestUnifiedPlan, ChangeMsidWhileReceiving) {
482 auto caller = CreatePeerConnection();
483 caller->AddAudioTrack("audio_track", {"stream1"});
484 auto callee = CreatePeerConnection();
Amit Hilbuchae3df542019-01-07 12:13:08 -0800485 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100486
487 ASSERT_EQ(1u, callee->observer()->on_track_transceivers_.size());
488 auto transceiver = callee->observer()->on_track_transceivers_[0];
489 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
490 EXPECT_EQ("stream1", transceiver->receiver()->streams()[0]->id());
491
Amit Hilbuchae3df542019-01-07 12:13:08 -0800492 ASSERT_TRUE(callee->CreateAnswerAndSetAsLocal());
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100493
494 // Change the stream ID in the offer.
Guido Urdaneta1ff16c82019-05-20 19:31:53 +0200495 caller->pc()->GetSenders()[0]->SetStreams({"stream2"});
496 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100497 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
498 EXPECT_EQ("stream2", transceiver->receiver()->streams()[0]->id());
499}
500
Steve Anton3172c032018-05-03 15:30:18 -0700501// These tests examine the state of the peer connection as a result of
502// performing SetRemoteDescription().
503
504TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
505 auto caller = CreatePeerConnection();
506 auto callee = CreatePeerConnection();
507
508 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700509 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100510
511 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
512 auto receiver_added = callee->pc()->GetReceivers()[0];
513 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 15:30:18 -0700514
515 if (sdp_semantics_ == SdpSemantics::kPlanB) {
516 // Since we are not supporting the no stream case with Plan B, there should
517 // be a generated stream, even though we didn't set one with AddTrack.
518 ASSERT_EQ(1u, receiver_added->streams().size());
519 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
520 } else {
521 EXPECT_EQ(0u, receiver_added->streams().size());
522 }
Henrik Boström31638672017-11-23 17:48:32 +0100523}
524
Steve Anton3172c032018-05-03 15:30:18 -0700525TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100526 auto caller = CreatePeerConnection();
527 auto callee = CreatePeerConnection();
528
Steve Anton3172c032018-05-03 15:30:18 -0700529 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700530 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100531
532 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
533 auto receiver_added = callee->pc()->GetReceivers()[0];
534 EXPECT_EQ("audio_track", receiver_added->track()->id());
535 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700536 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 17:48:32 +0100537 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
538}
539
Steve Anton3172c032018-05-03 15:30:18 -0700540TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100541 auto caller = CreatePeerConnection();
542 auto callee = CreatePeerConnection();
543
Steve Anton3172c032018-05-03 15:30:18 -0700544 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100545 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700546 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
547
Henrik Boström31638672017-11-23 17:48:32 +0100548 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
549 auto receiver = callee->pc()->GetReceivers()[0];
550 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700551 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100552
Steve Anton3172c032018-05-03 15:30:18 -0700553 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
554 // With Unified Plan the receiver stays but the transceiver transitions to
555 // inactive.
556 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
557 EXPECT_EQ(RtpTransceiverDirection::kInactive,
558 callee->pc()->GetTransceivers()[0]->current_direction());
559 } else {
560 // With Plan B the receiver is removed.
561 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
562 }
Henrik Boström31638672017-11-23 17:48:32 +0100563}
564
Steve Anton3172c032018-05-03 15:30:18 -0700565TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100566 auto caller = CreatePeerConnection();
567 auto callee = CreatePeerConnection();
568
Steve Anton3172c032018-05-03 15:30:18 -0700569 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100570 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700571 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100572 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
573 auto receiver = callee->pc()->GetReceivers()[0];
574 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700575 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100576
Steve Anton3172c032018-05-03 15:30:18 -0700577 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
578 // With Unified Plan the receiver stays but the transceiver transitions to
579 // inactive.
580 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
581 EXPECT_EQ(RtpTransceiverDirection::kInactive,
582 callee->pc()->GetTransceivers()[0]->current_direction());
583 } else {
584 // With Plan B the receiver is removed.
585 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
586 }
Henrik Boström31638672017-11-23 17:48:32 +0100587}
588
Steve Anton3172c032018-05-03 15:30:18 -0700589TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100590 auto caller = CreatePeerConnection();
591 auto callee = CreatePeerConnection();
592
Seth Hampson845e8782018-03-02 11:34:10 -0800593 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700594 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
595 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
596 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
597 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 17:48:32 +0100598
599 // Remove "audio_track1".
600 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Steve Anton3172c032018-05-03 15:30:18 -0700601 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
602
603 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
604 // With Unified Plan the receiver stays but the transceiver transitions to
605 // inactive.
606 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
607 auto transceiver = callee->pc()->GetTransceivers()[0];
608 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
609 EXPECT_EQ(RtpTransceiverDirection::kInactive,
610 transceiver->current_direction());
611 } else {
612 // With Plan B the receiver is removed.
613 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
614 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
615 }
Henrik Boström31638672017-11-23 17:48:32 +0100616
617 // Remove "audio_track2".
618 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Steve Anton3172c032018-05-03 15:30:18 -0700619 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
620
621 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
622 // With Unified Plan the receiver stays but the transceiver transitions to
623 // inactive.
624 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
625 auto transceiver = callee->pc()->GetTransceivers()[1];
626 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
627 EXPECT_EQ(RtpTransceiverDirection::kInactive,
628 transceiver->current_direction());
629 } else {
630 // With Plan B the receiver is removed.
631 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
632 }
Henrik Boström31638672017-11-23 17:48:32 +0100633}
634
Florent Castelliabe301f2018-06-12 18:33:49 +0200635TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
636 auto caller = CreatePeerConnection();
637 auto callee = CreatePeerConnection();
638 auto sender = caller->AddAudioTrack("audio_track");
639 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
640
641 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
642 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
643
644 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
645 auto receiver = callee->pc()->GetReceivers()[0];
646 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
647}
648
649TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
650 auto caller = CreatePeerConnection();
651 auto callee = CreatePeerConnection();
652 auto sender = caller->AddVideoTrack("video_track");
653 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
654
655 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
656 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
657
658 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
659 auto receiver = callee->pc()->GetReceivers()[0];
660 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
661}
662
Henrik Boström31638672017-11-23 17:48:32 +0100663// Invokes SetRemoteDescription() twice in a row without synchronizing the two
664// calls and examine the state of the peer connection inside the callbacks to
665// ensure that the second call does not occur prematurely, contaminating the
666// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 15:30:18 -0700667TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 17:48:32 +0100668 StatesCorrelateWithSetRemoteDescriptionCall) {
669 auto caller = CreatePeerConnection();
670 auto callee = CreatePeerConnection();
671
Henrik Boström31638672017-11-23 17:48:32 +0100672 // Create SDP for adding a track and for removing it. This will be used in the
673 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 15:30:18 -0700674 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100675 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
676 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
677 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
678
679 // In the first SetRemoteDescription() callback, check that we have a
680 // receiver for the track.
681 auto pc = callee->pc();
682 bool srd1_callback_called = false;
683 auto srd1_callback = [&srd1_callback_called, &pc]() {
684 EXPECT_EQ(pc->GetReceivers().size(), 1u);
685 srd1_callback_called = true;
686 };
687
688 // In the second SetRemoteDescription() callback, check that the receiver has
689 // been removed.
690 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
691 // Instead, the transceiver owning the receiver will become inactive.
692 // https://crbug.com/webrtc/7600
693 bool srd2_callback_called = false;
694 auto srd2_callback = [&srd2_callback_called, &pc]() {
695 EXPECT_TRUE(pc->GetReceivers().empty());
696 srd2_callback_called = true;
697 };
698
699 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
700 // calls. The callbacks verify that the two calls are synchronized, as in, the
701 // effects of the second SetRemoteDescription() call must not have happened by
702 // the time the first callback is invoked. If it has then the receiver that is
703 // added as a result of the first SetRemoteDescription() call will already
704 // have been removed as a result of the second SetRemoteDescription() call
705 // when the first callback is invoked.
706 callee->pc()->SetRemoteDescription(
707 std::move(srd1_sdp),
708 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
709 callee->pc()->SetRemoteDescription(
710 std::move(srd2_sdp),
711 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
712 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
713 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
714}
715
Seth Hampson5897a6e2018-04-03 11:16:33 -0700716// Tests that a remote track is created with the signaled MSIDs when they are
717// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
718// lines).
Steve Anton3172c032018-05-03 15:30:18 -0700719TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
720 auto caller = CreatePeerConnection();
721 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 11:16:33 -0700722 const char kStreamId1[] = "stream1";
723 const char kStreamId2[] = "stream2";
724 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
725 {kStreamId1, kStreamId2});
726
727 auto offer = caller->CreateOfferAndSetAsLocal();
728 // Munge the offer to take out everything but the stream_ids.
729 auto contents = offer->description()->contents();
730 ASSERT_TRUE(!contents.empty());
731 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
732 std::vector<std::string> stream_ids =
733 contents[0].media_description()->streams()[0].stream_ids();
734 contents[0].media_description()->mutable_streams().clear();
735 cricket::StreamParams new_stream;
736 new_stream.set_stream_ids(stream_ids);
737 contents[0].media_description()->AddStream(new_stream);
738
739 // Set the remote description and verify that the streams were added to the
740 // receiver correctly.
741 ASSERT_TRUE(
742 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
743 auto receivers = callee->pc()->GetReceivers();
744 ASSERT_EQ(receivers.size(), 1u);
745 ASSERT_EQ(receivers[0]->streams().size(), 2u);
746 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
747 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
748}
749
Seth Hampson5b4f0752018-04-02 16:31:36 -0700750// Tests that with Unified Plan if the the stream id changes for a track when
751// when setting a new remote description, that the media stream is updated
752// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 14:25:36 -0700753// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
754// test.
755TEST_F(PeerConnectionRtpTestUnifiedPlan,
756 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700757 auto caller = CreatePeerConnection();
758 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 16:31:36 -0700759
760 const char kStreamId1[] = "stream1";
761 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 14:25:36 -0700762 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700763 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700764 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
765
766 // Change the stream id of the sender in the session description.
767 auto offer = caller->CreateOfferAndSetAsLocal();
768 auto contents = offer->description()->contents();
769 ASSERT_EQ(contents.size(), 1u);
770 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
771 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
772 {kStreamId2});
773
Steve Anton0f5400a2018-07-17 14:25:36 -0700774 // Set the remote description and verify that the stream was updated
775 // properly.
776 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700777 auto receivers = callee->pc()->GetReceivers();
778 ASSERT_EQ(receivers.size(), 1u);
779 ASSERT_EQ(receivers[0]->streams().size(), 1u);
780 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
781}
782
783// This tests a regression caught by a downstream client, that occured when
784// applying a remote description with a SessionDescription object that
785// contained StreamParams that didn't have ids. Although there were multiple
786// remote audio senders, FindSenderInfo didn't find them as unique, because
787// it looked up by StreamParam.id, which none had. This meant only one
788// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 15:30:18 -0700789TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700790 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
791 auto caller = CreatePeerConnection();
792 auto callee = CreatePeerConnection();
793
794 const char kStreamId1[] = "stream1";
795 const char kStreamId2[] = "stream2";
796 caller->AddAudioTrack("audio_track1", {kStreamId1});
797 caller->AddAudioTrack("audio_track2", {kStreamId2});
798
799 auto offer = caller->CreateOfferAndSetAsLocal();
800 auto mutable_streams =
801 cricket::GetFirstAudioContentDescription(offer->description())
802 ->mutable_streams();
803 ASSERT_EQ(mutable_streams.size(), 2u);
804 // Clear the IDs in the StreamParams.
805 mutable_streams[0].id.clear();
806 mutable_streams[1].id.clear();
807 ASSERT_TRUE(
808 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
809
810 auto receivers = callee->pc()->GetReceivers();
811 ASSERT_EQ(receivers.size(), 2u);
812 ASSERT_EQ(receivers[0]->streams().size(), 1u);
813 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
814 ASSERT_EQ(receivers[1]->streams().size(), 1u);
815 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
816}
817
Henrik Boström31638672017-11-23 17:48:32 +0100818// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 17:48:32 +0100819
820// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 15:30:18 -0700821TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 17:48:32 +0100822 auto caller = CreatePeerConnection();
823 auto callee = CreatePeerConnection();
824
825 std::string error;
826 ASSERT_TRUE(
827 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
828}
829
830// Verifies legacy behavior: The observer is not called if if the peer
831// connection is destroyed because the asynchronous callback is executed in the
832// peer connection's message handler.
Steve Anton3172c032018-05-03 15:30:18 -0700833TEST_P(PeerConnectionRtpTest,
834 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 17:48:32 +0100835 auto caller = CreatePeerConnection();
836 auto callee = CreatePeerConnection();
837
838 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
839 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
840
841 auto offer = caller->CreateOfferAndSetAsLocal();
842 callee->pc()->SetRemoteDescription(observer, offer.release());
843 callee = nullptr;
844 rtc::Thread::Current()->ProcessMessages(0);
845 EXPECT_FALSE(observer->called());
846}
847
Steve Antonf9381f02017-12-14 10:23:57 -0800848// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800849
850// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 15:30:18 -0700851TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
852 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800853 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
854}
855
856// Test that a transceiver created with the audio kind has the correct initial
857// properties.
Steve Anton3172c032018-05-03 15:30:18 -0700858TEST_F(PeerConnectionRtpTestUnifiedPlan,
859 AddTransceiverHasCorrectInitProperties) {
860 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800861
862 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200863 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 13:01:52 -0800864 EXPECT_FALSE(transceiver->stopped());
865 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200866 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 13:01:52 -0800867}
868
869// Test that adding a transceiver with the audio kind creates an audio sender
870// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 15:30:18 -0700871TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800872 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700873 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800874
875 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 11:43:08 -0800876 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800877
878 ASSERT_TRUE(transceiver->sender());
879 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
880
881 ASSERT_TRUE(transceiver->receiver());
882 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
883
884 auto track = transceiver->receiver()->track();
885 ASSERT_TRUE(track);
886 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
887 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
888}
889
890// Test that adding a transceiver with the video kind creates an video sender
891// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 15:30:18 -0700892TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800893 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700894 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800895
896 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 11:43:08 -0800897 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800898
899 ASSERT_TRUE(transceiver->sender());
900 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
901
902 ASSERT_TRUE(transceiver->receiver());
903 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
904
905 auto track = transceiver->receiver()->track();
906 ASSERT_TRUE(track);
907 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
908 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
909}
910
911// Test that after a call to AddTransceiver, the transceiver shows in
912// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
913// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 15:30:18 -0700914TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
915 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800916
917 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
918 EXPECT_EQ(
919 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
920 caller->pc()->GetTransceivers());
921 EXPECT_EQ(
922 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
923 transceiver->sender()},
924 caller->pc()->GetSenders());
925 EXPECT_EQ(
926 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
927 transceiver->receiver()},
928 caller->pc()->GetReceivers());
929}
930
931// Test that the direction passed in through the AddTransceiver init parameter
932// is set in the returned transceiver.
Steve Anton3172c032018-05-03 15:30:18 -0700933TEST_F(PeerConnectionRtpTestUnifiedPlan,
934 AddTransceiverWithDirectionIsReflected) {
935 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800936
937 RtpTransceiverInit init;
938 init.direction = RtpTransceiverDirection::kSendOnly;
939 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
940 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
941}
942
Steve Anton9158ef62017-11-27 13:01:52 -0800943// Test that calling AddTransceiver with a track creates a transceiver which has
944// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 15:30:18 -0700945TEST_F(PeerConnectionRtpTestUnifiedPlan,
946 AddTransceiverWithTrackCreatesSenderWithTrack) {
947 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800948
949 auto audio_track = caller->CreateAudioTrack("audio track");
950 auto transceiver = caller->AddTransceiver(audio_track);
951
952 auto sender = transceiver->sender();
953 ASSERT_TRUE(sender->track());
954 EXPECT_EQ(audio_track, sender->track());
955
956 auto receiver = transceiver->receiver();
957 ASSERT_TRUE(receiver->track());
958 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
959 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
960 receiver->track()->state());
961}
962
963// Test that calling AddTransceiver twice with the same track creates distinct
964// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 15:30:18 -0700965TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800966 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 15:30:18 -0700967 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800968
969 auto audio_track = caller->CreateAudioTrack("audio track");
970
971 auto transceiver1 = caller->AddTransceiver(audio_track);
972 auto transceiver2 = caller->AddTransceiver(audio_track);
973
974 EXPECT_NE(transceiver1, transceiver2);
975
976 auto sender1 = transceiver1->sender();
977 auto sender2 = transceiver2->sender();
978 EXPECT_NE(sender1, sender2);
979 EXPECT_EQ(audio_track, sender1->track());
980 EXPECT_EQ(audio_track, sender2->track());
981
982 EXPECT_THAT(caller->pc()->GetTransceivers(),
983 UnorderedElementsAre(transceiver1, transceiver2));
984 EXPECT_THAT(caller->pc()->GetSenders(),
985 UnorderedElementsAre(sender1, sender2));
986}
987
Steve Anton3fe1b152017-12-12 10:20:08 -0800988// RtpTransceiver error handling tests.
989
Steve Anton3172c032018-05-03 15:30:18 -0700990TEST_F(PeerConnectionRtpTestUnifiedPlan,
991 AddTransceiverWithInvalidKindReturnsError) {
992 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800993
994 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
995 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
996}
997
Steve Anton3172c032018-05-03 15:30:18 -0700998TEST_F(PeerConnectionRtpTestUnifiedPlan,
999 CanClosePeerConnectionWithoutCrashing) {
1000 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -08001001
1002 caller->pc()->Close();
1003}
1004
Steve Antonf9381f02017-12-14 10:23:57 -08001005// Unified Plan AddTrack tests.
1006
Steve Antonf9381f02017-12-14 10:23:57 -08001007// Test that adding an audio track creates a new audio RtpSender with the given
1008// track.
Steve Anton3172c032018-05-03 15:30:18 -07001009TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
1010 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001011
1012 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001013 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001014 ASSERT_TRUE(sender);
1015
1016 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
1017 EXPECT_EQ(audio_track, sender->track());
1018}
1019
1020// Test that adding a video track creates a new video RtpSender with the given
1021// track.
Steve Anton3172c032018-05-03 15:30:18 -07001022TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
1023 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001024
1025 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001026 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001027 ASSERT_TRUE(sender);
1028
1029 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
1030 EXPECT_EQ(video_track, sender->track());
1031}
1032
1033// Test that adding a track to a new PeerConnection creates an RtpTransceiver
1034// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 15:30:18 -07001035TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
1036 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001037
1038 auto sender = caller->AddAudioTrack("a");
1039 ASSERT_TRUE(sender);
1040
1041 auto transceivers = caller->pc()->GetTransceivers();
1042 ASSERT_EQ(1u, transceivers.size());
1043 EXPECT_EQ(sender, transceivers[0]->sender());
1044 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
1045}
1046
1047// Test that if a transceiver of the same type but no track had been added to
1048// the PeerConnection and later a call to AddTrack is made, the resulting sender
1049// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 15:30:18 -07001050TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1051 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001052
1053 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1054 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001055 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001056 ASSERT_TRUE(sender);
1057
1058 auto transceivers = caller->pc()->GetTransceivers();
1059 ASSERT_EQ(1u, transceivers.size());
1060 EXPECT_EQ(transceiver, transceivers[0]);
1061 EXPECT_EQ(sender, transceiver->sender());
1062 EXPECT_EQ(audio_track, sender->track());
1063}
1064
1065// Test that adding two tracks to a new PeerConnection creates two
1066// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 15:30:18 -07001067TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1068 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001069
1070 auto sender1 = caller->AddAudioTrack("a");
1071 auto sender2 = caller->AddVideoTrack("v");
1072 ASSERT_TRUE(sender2);
1073
1074 auto transceivers = caller->pc()->GetTransceivers();
1075 ASSERT_EQ(2u, transceivers.size());
1076 EXPECT_EQ(sender1, transceivers[0]->sender());
1077 EXPECT_EQ(sender2, transceivers[1]->sender());
1078}
1079
1080// Test that if there are multiple transceivers with no sending track then a
1081// later call to AddTrack will use the one of the same type as the newly-added
1082// track.
Steve Anton3172c032018-05-03 15:30:18 -07001083TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1084 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001085
1086 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1087 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1088 auto sender = caller->AddVideoTrack("v");
1089
1090 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1091 EXPECT_NE(sender, audio_transceiver->sender());
1092 EXPECT_EQ(sender, video_transceiver->sender());
1093}
1094
1095// Test that if the only transceivers that do not have a sending track have a
1096// different type from the added track, then AddTrack will create a new
1097// transceiver for the track.
Steve Anton3172c032018-05-03 15:30:18 -07001098TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001099 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 15:30:18 -07001100 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001101
1102 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1103 auto sender = caller->AddVideoTrack("v");
1104
1105 auto transceivers = caller->pc()->GetTransceivers();
1106 ASSERT_EQ(2u, transceivers.size());
1107 EXPECT_NE(sender, transceivers[0]->sender());
1108 EXPECT_EQ(sender, transceivers[1]->sender());
1109}
1110
1111// Test that the first available transceiver is reused by AddTrack when multiple
1112// are available.
Steve Anton3172c032018-05-03 15:30:18 -07001113TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001114 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001115 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001116
1117 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1118 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1119 auto sender = caller->AddAudioTrack("a");
1120
1121 auto transceivers = caller->pc()->GetTransceivers();
1122 ASSERT_EQ(2u, transceivers.size());
1123 EXPECT_EQ(sender, transceivers[0]->sender());
1124 EXPECT_NE(sender, transceivers[1]->sender());
1125}
1126
1127// Test that a call to AddTrack that reuses a transceiver will change the
1128// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 15:30:18 -07001129TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001130 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001131 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001132 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001133
1134 RtpTransceiverInit init;
1135 init.direction = RtpTransceiverDirection::kInactive;
1136 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001137 EXPECT_TRUE(caller->observer()->negotiation_needed());
Steve Antonf9381f02017-12-14 10:23:57 -08001138
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001139 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Steve Antonf9381f02017-12-14 10:23:57 -08001140 caller->observer()->clear_negotiation_needed();
1141 ASSERT_TRUE(caller->AddAudioTrack("a"));
1142 EXPECT_TRUE(caller->observer()->negotiation_needed());
1143
1144 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1145}
1146
1147// Test that a call to AddTrack that reuses a transceiver will change the
1148// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -07001149TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001150 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 15:30:18 -07001151 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001152 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001153
1154 RtpTransceiverInit init;
1155 init.direction = RtpTransceiverDirection::kRecvOnly;
1156 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001157 EXPECT_TRUE(caller->observer()->negotiation_needed());
Steve Antonf9381f02017-12-14 10:23:57 -08001158
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001159 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Steve Antonf9381f02017-12-14 10:23:57 -08001160 caller->observer()->clear_negotiation_needed();
1161 ASSERT_TRUE(caller->AddAudioTrack("a"));
1162 EXPECT_TRUE(caller->observer()->negotiation_needed());
1163
1164 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1165}
1166
Steve Anton3172c032018-05-03 15:30:18 -07001167TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-10 16:26:06 -08001168 const std::string kTrackId = "audio_track";
1169
Steve Anton3172c032018-05-03 15:30:18 -07001170 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-10 16:26:06 -08001171
1172 auto audio_track = caller->CreateAudioTrack(kTrackId);
1173 auto sender = caller->AddTrack(audio_track);
1174
1175 EXPECT_EQ(kTrackId, sender->id());
1176}
1177
Steve Antonf9381f02017-12-14 10:23:57 -08001178// Unified Plan AddTrack error handling.
1179
Steve Anton3172c032018-05-03 15:30:18 -07001180TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1181 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001182
1183 auto audio_track = caller->CreateAudioTrack("a");
1184 caller->pc()->Close();
1185
1186 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001187 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001188 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001189 EXPECT_FALSE(caller->observer()->negotiation_needed());
1190}
1191
Steve Anton3172c032018-05-03 15:30:18 -07001192TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1193 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001194
1195 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001196 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -08001197
1198 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001199 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001200 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001201 EXPECT_FALSE(caller->observer()->negotiation_needed());
1202}
1203
1204// Unified Plan RemoveTrack tests.
1205
1206// Test that calling RemoveTrack on a sender with a previously-added track
1207// clears the sender's track.
Steve Anton3172c032018-05-03 15:30:18 -07001208TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1209 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001210
1211 auto sender = caller->AddAudioTrack("a");
1212 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1213
1214 EXPECT_FALSE(sender->track());
1215}
1216
1217// Test that calling RemoveTrack on a sender where the transceiver is configured
1218// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 15:30:18 -07001219TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001220 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001221 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001222 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001223
1224 RtpTransceiverInit init;
1225 init.direction = RtpTransceiverDirection::kSendRecv;
1226 auto transceiver =
1227 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001228 EXPECT_TRUE(caller->observer()->negotiation_needed());
Steve Antonf9381f02017-12-14 10:23:57 -08001229
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001230 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Steve Antonf9381f02017-12-14 10:23:57 -08001231 caller->observer()->clear_negotiation_needed();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001232
Steve Antonf9381f02017-12-14 10:23:57 -08001233 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1234 EXPECT_TRUE(caller->observer()->negotiation_needed());
1235
1236 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
Steve Antonf9381f02017-12-14 10:23:57 -08001237}
1238
1239// Test that calling RemoveTrack on a sender where the transceiver is configured
1240// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 15:30:18 -07001241TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001242 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 15:30:18 -07001243 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001244 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001245
1246 RtpTransceiverInit init;
1247 init.direction = RtpTransceiverDirection::kSendOnly;
1248 auto transceiver =
1249 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001250 EXPECT_TRUE(caller->observer()->negotiation_needed());
Steve Antonf9381f02017-12-14 10:23:57 -08001251
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001252 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Steve Antonf9381f02017-12-14 10:23:57 -08001253 caller->observer()->clear_negotiation_needed();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001254
Steve Antonf9381f02017-12-14 10:23:57 -08001255 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1256 EXPECT_TRUE(caller->observer()->negotiation_needed());
1257
1258 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1259}
1260
1261// Test that calling RemoveTrack with a sender that has a null track results in
1262// no change in state.
Steve Anton3172c032018-05-03 15:30:18 -07001263TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1264 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001265
1266 auto sender = caller->AddAudioTrack("a");
1267 auto transceiver = caller->pc()->GetTransceivers()[0];
1268 ASSERT_TRUE(sender->SetTrack(nullptr));
1269
1270 caller->observer()->clear_negotiation_needed();
1271 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1272 EXPECT_FALSE(caller->observer()->negotiation_needed());
1273
1274 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1275}
1276
1277// Unified Plan RemoveTrack error handling.
1278
Steve Anton3172c032018-05-03 15:30:18 -07001279TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1280 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001281
1282 auto sender = caller->AddAudioTrack("a");
1283 caller->pc()->Close();
1284
1285 caller->observer()->clear_negotiation_needed();
1286 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
1287 EXPECT_FALSE(caller->observer()->negotiation_needed());
1288}
1289
Steve Anton3172c032018-05-03 15:30:18 -07001290TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001291 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 15:30:18 -07001292 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001293
1294 auto sender = caller->AddAudioTrack("a");
1295 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1296
1297 caller->observer()->clear_negotiation_needed();
1298 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
1299 EXPECT_FALSE(caller->observer()->negotiation_needed());
1300}
1301
Steve Anton60b6c1d2018-06-13 11:32:27 -07001302// Test that setting offers that add/remove/add a track repeatedly without
1303// setting the appropriate answer in between works.
1304// These are regression tests for bugs.webrtc.org/9401
1305TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1306 auto caller = CreatePeerConnection();
1307
1308 auto sender1 = caller->AddAudioTrack("audio1");
1309 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1310
1311 caller->pc()->RemoveTrack(sender1);
1312 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1313
1314 // This will re-use the transceiver created by the first AddTrack.
1315 auto sender2 = caller->AddAudioTrack("audio2");
1316 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1317
1318 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1319 EXPECT_EQ(sender1, sender2);
1320}
1321TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1322 auto caller = CreatePeerConnection();
1323
1324 auto sender1 = caller->AddVideoTrack("video1");
1325 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1326
1327 caller->pc()->RemoveTrack(sender1);
1328 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1329
1330 // This will re-use the transceiver created by the first AddTrack.
1331 auto sender2 = caller->AddVideoTrack("video2");
1332 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1333
1334 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1335 EXPECT_EQ(sender1, sender2);
1336}
1337
Steve Anton07563732018-06-26 11:13:50 -07001338// Test that CreateOffer succeeds if two tracks with the same label are added.
1339TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1340 auto caller = CreatePeerConnection();
1341
1342 auto audio_sender = caller->AddAudioTrack("track", {});
1343 auto video_sender = caller->AddVideoTrack("track", {});
1344
1345 EXPECT_TRUE(caller->CreateOffer());
1346
1347 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1348 EXPECT_NE(audio_sender->id(), video_sender->id());
1349}
1350
1351// Test that CreateAnswer succeeds if two tracks with the same label are added.
1352TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1353 auto caller = CreatePeerConnection();
1354 auto callee = CreatePeerConnection();
1355
1356 RtpTransceiverInit recvonly;
1357 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1358 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1359 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1360
1361 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1362
1363 auto audio_sender = callee->AddAudioTrack("track", {});
1364 auto video_sender = callee->AddVideoTrack("track", {});
1365
1366 EXPECT_TRUE(callee->CreateAnswer());
1367
1368 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1369 EXPECT_NE(audio_sender->id(), video_sender->id());
1370}
1371
1372// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1373// m= section with a random sender id (different from the first, now rejected,
1374// m= section).
1375TEST_F(PeerConnectionRtpTestUnifiedPlan,
1376 AddRemoveAddTrackGeneratesNewSenderId) {
1377 auto caller = CreatePeerConnection();
1378 auto callee = CreatePeerConnection();
1379
1380 auto track = caller->CreateVideoTrack("video");
1381 auto sender1 = caller->AddTrack(track);
1382 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1383
1384 caller->pc()->RemoveTrack(sender1);
1385 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1386
1387 auto sender2 = caller->AddTrack(track);
1388
1389 EXPECT_NE(sender1, sender2);
1390 EXPECT_NE(sender1->id(), sender2->id());
1391 std::string sender2_id = sender2->id();
1392
1393 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1394
1395 // The sender's ID should not change after negotiation.
1396 EXPECT_EQ(sender2_id, sender2->id());
1397}
1398
Steve Anton52d86772018-02-20 15:48:12 -08001399// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1400// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 15:30:18 -07001401TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001402 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001403 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001404 auto callee = CreatePeerConnection();
1405 EXPECT_FALSE(caller->observer()->negotiation_needed());
Steve Anton52d86772018-02-20 15:48:12 -08001406
1407 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001408 EXPECT_TRUE(caller->observer()->negotiation_needed());
Steve Anton52d86772018-02-20 15:48:12 -08001409
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001410 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Steve Anton52d86772018-02-20 15:48:12 -08001411 caller->observer()->clear_negotiation_needed();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001412
Steve Anton52d86772018-02-20 15:48:12 -08001413 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1414 EXPECT_TRUE(caller->observer()->negotiation_needed());
1415}
1416
1417// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1418// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 15:30:18 -07001419TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001420 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001421 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001422
1423 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1424
1425 caller->observer()->clear_negotiation_needed();
1426 transceiver->SetDirection(transceiver->direction());
1427 EXPECT_FALSE(caller->observer()->negotiation_needed());
1428}
1429
1430// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1431// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001432TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001433 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001434 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001435
1436 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1437 transceiver->Stop();
1438
1439 caller->observer()->clear_negotiation_needed();
1440 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1441 EXPECT_FALSE(caller->observer()->negotiation_needed());
1442}
1443
Florent Castelli892acf02018-10-01 22:47:20 +02001444// Test that AddTransceiver fails if trying to use unimplemented RTP encoding
1445// parameters with the send_encodings parameters.
1446TEST_F(PeerConnectionRtpTestUnifiedPlan,
1447 CheckForUnsupportedEncodingParameters) {
1448 auto caller = CreatePeerConnection();
1449
1450 RtpTransceiverInit init;
1451 init.send_encodings.emplace_back();
1452
1453 auto default_send_encodings = init.send_encodings;
1454
Henrik Grunelle1301a82018-12-13 12:13:22 +00001455 // Unimplemented RtpParameters: ssrc, codec_payload_type, fec, rtx, dtx,
Amit Hilbuchaa584152019-02-06 17:09:52 -08001456 // ptime, scale_framerate_down_by, dependency_rids.
Florent Castelli892acf02018-10-01 22:47:20 +02001457 init.send_encodings[0].ssrc = 1;
1458 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1459 caller->pc()
1460 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1461 .error()
1462 .type());
1463 init.send_encodings = default_send_encodings;
1464
Henrik Grunelle1301a82018-12-13 12:13:22 +00001465 init.send_encodings[0].codec_payload_type = 1;
1466 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1467 caller->pc()
1468 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1469 .error()
1470 .type());
1471 init.send_encodings = default_send_encodings;
1472
Florent Castelli892acf02018-10-01 22:47:20 +02001473 init.send_encodings[0].fec = RtpFecParameters();
1474 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1475 caller->pc()
1476 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1477 .error()
1478 .type());
1479 init.send_encodings = default_send_encodings;
1480
1481 init.send_encodings[0].rtx = RtpRtxParameters();
1482 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1483 caller->pc()
1484 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1485 .error()
1486 .type());
1487 init.send_encodings = default_send_encodings;
1488
1489 init.send_encodings[0].dtx = DtxStatus::ENABLED;
1490 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1491 caller->pc()
1492 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1493 .error()
1494 .type());
1495 init.send_encodings = default_send_encodings;
1496
1497 init.send_encodings[0].ptime = 1;
1498 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1499 caller->pc()
1500 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1501 .error()
1502 .type());
1503 init.send_encodings = default_send_encodings;
1504
Florent Castelli892acf02018-10-01 22:47:20 +02001505 init.send_encodings[0].dependency_rids.push_back("dummy_rid");
1506 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1507 caller->pc()
1508 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1509 .error()
1510 .type());
1511}
1512
Florent Castellic1a0bcb2019-01-29 14:26:48 +01001513// Test that AddTransceiver fails if trying to use invalid RTP encoding
1514// parameters with the send_encodings parameters.
1515TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForInvalidEncodingParameters) {
1516 auto caller = CreatePeerConnection();
1517
1518 RtpTransceiverInit init;
1519 init.send_encodings.emplace_back();
1520
1521 auto default_send_encodings = init.send_encodings;
1522
1523 init.send_encodings[0].scale_resolution_down_by = 0.5;
1524 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1525 caller->pc()
1526 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1527 .error()
1528 .type());
1529 init.send_encodings = default_send_encodings;
1530
1531 init.send_encodings[0].bitrate_priority = 0;
1532 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1533 caller->pc()
1534 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1535 .error()
1536 .type());
1537 init.send_encodings = default_send_encodings;
1538
1539 init.send_encodings[0].min_bitrate_bps = 200000;
1540 init.send_encodings[0].max_bitrate_bps = 100000;
1541 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1542 caller->pc()
1543 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1544 .error()
1545 .type());
1546 init.send_encodings = default_send_encodings;
1547
1548 init.send_encodings[0].num_temporal_layers = 0;
1549 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1550 caller->pc()
1551 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1552 .error()
1553 .type());
1554 init.send_encodings = default_send_encodings;
1555
1556 init.send_encodings[0].num_temporal_layers = 5;
1557 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1558 caller->pc()
1559 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1560 .error()
1561 .type());
1562 init.send_encodings = default_send_encodings;
1563}
1564
Florent Castelli892acf02018-10-01 22:47:20 +02001565// Test that AddTransceiver transfers the send_encodings to the sender and they
1566// are retained after SetLocalDescription().
1567TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) {
1568 auto caller = CreatePeerConnection();
1569
1570 RtpTransceiverInit init;
1571 init.send_encodings.emplace_back();
1572 init.send_encodings[0].active = false;
1573 init.send_encodings[0].max_bitrate_bps = 180000;
1574
1575 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1576 ASSERT_TRUE(result.ok());
1577
1578 auto init_send_encodings = result.value()->sender()->init_send_encodings();
1579 EXPECT_FALSE(init_send_encodings[0].active);
1580 EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000);
1581
1582 auto parameters = result.value()->sender()->GetParameters();
1583 EXPECT_FALSE(parameters.encodings[0].active);
1584 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1585
1586 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1587
1588 parameters = result.value()->sender()->GetParameters();
1589 EXPECT_FALSE(parameters.encodings[0].active);
1590 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1591}
1592
Steve Antone831b8c2018-02-01 12:22:16 -08001593// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1594// options for this kind of signaling: media section based (a=msid) and ssrc
1595// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1596// we want to ensure compatibility with older Plan B endpoints that might expect
1597// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1598// types but answers with the same type as the offer.
1599
Steve Anton3172c032018-05-03 15:30:18 -07001600class PeerConnectionMsidSignalingTest
1601 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 12:22:16 -08001602
1603TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1604 auto caller = CreatePeerConnectionWithUnifiedPlan();
1605 caller->AddAudioTrack("caller_audio");
1606 auto callee = CreatePeerConnectionWithUnifiedPlan();
1607 callee->AddAudioTrack("callee_audio");
1608
1609 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1610
1611 // Offer should have had both a=msid and a=ssrc MSID lines.
1612 auto* offer = callee->pc()->remote_description();
1613 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1614 cricket::kMsidSignalingSsrcAttribute),
1615 offer->description()->msid_signaling());
1616
1617 // Answer should have had only a=msid lines.
1618 auto* answer = caller->pc()->remote_description();
1619 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1620 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 23:48:00 +01001621 // Check that this is counted correctly
Steve Antonc1e6e862019-03-04 14:43:44 -08001622 EXPECT_THAT(metrics::Samples("WebRTC.PeerConnection.SdpSemanticNegotiated"),
1623 ElementsAre(Pair(kSdpSemanticNegotiatedUnifiedPlan, 2)));
Steve Antone831b8c2018-02-01 12:22:16 -08001624}
1625
1626TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1627 auto caller = CreatePeerConnectionWithPlanB();
1628 caller->AddAudioTrack("caller_audio");
1629 auto callee = CreatePeerConnectionWithUnifiedPlan();
1630 callee->AddAudioTrack("callee_audio");
1631
1632 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1633
1634 // Offer should have only a=ssrc MSID lines.
1635 auto* offer = callee->pc()->remote_description();
1636 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1637 offer->description()->msid_signaling());
1638
1639 // Answer should have only a=ssrc MSID lines to match the offer.
1640 auto* answer = caller->pc()->remote_description();
1641 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1642 answer->description()->msid_signaling());
1643}
1644
Seth Hampson5b4f0752018-04-02 16:31:36 -07001645// This tests that a Plan B endpoint appropriately sets the remote description
1646// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1647// that signal no stream ids or multiple stream ids we expect that the Plan B
1648// endpoint always has exactly one media stream per track.
1649TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1650 const std::string kStreamId1 = "audio_stream_1";
1651 const std::string kStreamId2 = "audio_stream_2";
1652
1653 auto caller = CreatePeerConnectionWithUnifiedPlan();
1654 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1655 caller->AddVideoTrack("caller_video", {});
1656 auto callee = CreatePeerConnectionWithPlanB();
1657 callee->AddAudioTrack("callee_audio");
1658 caller->AddVideoTrack("callee_video");
1659
1660 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1661
1662 // Offer should have had both a=msid and a=ssrc MSID lines.
1663 auto* offer = callee->pc()->remote_description();
1664 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1665 cricket::kMsidSignalingSsrcAttribute),
1666 offer->description()->msid_signaling());
1667
1668 // Callee should always have 1 stream for all of it's receivers.
1669 const auto& track_events = callee->observer()->add_track_events_;
1670 ASSERT_EQ(2u, track_events.size());
1671 ASSERT_EQ(1u, track_events[0].streams.size());
1672 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1673 ASSERT_EQ(1u, track_events[1].streams.size());
1674 // This autogenerated a stream id for the empty one signalled.
1675 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1676}
1677
Steve Antone831b8c2018-02-01 12:22:16 -08001678TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1679 auto caller = CreatePeerConnectionWithUnifiedPlan();
1680 caller->AddAudioTrack("caller_audio");
1681 auto callee = CreatePeerConnectionWithUnifiedPlan();
1682 callee->AddAudioTrack("callee_audio");
1683
1684 auto offer = caller->CreateOffer();
1685 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1686 // section only.
1687 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1688
1689 ASSERT_TRUE(
1690 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1691 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1692
1693 // Answer should have only a=msid to match the offer.
1694 auto answer = callee->CreateAnswer();
1695 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1696 answer->description()->msid_signaling());
1697}
1698
Steve Anton8e20f172018-03-06 10:55:04 -08001699// Test that the correct UMA metrics are reported for simple/complex SDP.
1700
Steve Anton3172c032018-05-03 15:30:18 -07001701class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 10:55:04 -08001702
1703#ifdef HAVE_SCTP
1704TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1705 auto caller = CreatePeerConnectionWithUnifiedPlan();
1706 caller->CreateDataChannel("dc");
1707 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001708
1709 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001710 // Note that only the callee does ReportSdpFormatReceived.
Steve Antonc1e6e862019-03-04 14:43:44 -08001711 EXPECT_THAT(metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1712 ElementsAre(Pair(kSdpFormatReceivedNoTracks, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001713}
1714#endif // HAVE_SCTP
1715
1716TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1717 auto caller = CreatePeerConnectionWithUnifiedPlan();
1718 caller->AddAudioTrack("audio");
1719 caller->AddVideoTrack("video");
1720 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001721
1722 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001723 // Note that only the callee does ReportSdpFormatReceived.
Steve Antonc1e6e862019-03-04 14:43:44 -08001724 EXPECT_THAT(metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1725 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001726}
1727
1728TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1729 auto caller = CreatePeerConnectionWithPlanB();
1730 caller->AddVideoTrack("video"); // Video only.
1731 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001732
1733 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Steve Antonc1e6e862019-03-04 14:43:44 -08001734 // Note that only the callee does ReportSdpFormatReceived.
1735 EXPECT_THAT(metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1736 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001737}
1738
1739TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1740 auto caller = CreatePeerConnectionWithUnifiedPlan();
1741 caller->AddAudioTrack("audio1");
1742 caller->AddAudioTrack("audio2");
1743 caller->AddVideoTrack("video");
1744 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001745
1746 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001747 // Note that only the callee does ReportSdpFormatReceived.
Steve Antonc1e6e862019-03-04 14:43:44 -08001748 EXPECT_THAT(metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1749 ElementsAre(Pair(kSdpFormatReceivedComplexUnifiedPlan, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001750}
1751
1752TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1753 auto caller = CreatePeerConnectionWithPlanB();
1754 caller->AddVideoTrack("video1");
1755 caller->AddVideoTrack("video2");
1756 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001757
Steve Antonba42e992018-04-09 14:10:01 -07001758 // This fails since Unified Plan cannot set a session description with
1759 // multiple "Plan B tracks" in the same media section. But we still expect the
1760 // SDP Format to be recorded.
1761 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001762 // Note that only the callee does ReportSdpFormatReceived.
Steve Antonc1e6e862019-03-04 14:43:44 -08001763 EXPECT_THAT(metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1764 ElementsAre(Pair(kSdpFormatReceivedComplexPlanB, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001765}
1766
Henrik Boström91d039b2018-01-11 17:43:30 +01001767// Sender setups in a call.
1768
Steve Anton3172c032018-05-03 15:30:18 -07001769TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 17:43:30 +01001770 auto caller = CreatePeerConnection();
1771 auto callee = CreatePeerConnection();
1772
1773 auto track = caller->CreateAudioTrack("audio_track");
1774 auto sender1 = caller->AddTrack(track);
1775 ASSERT_TRUE(sender1);
1776 // We need to temporarily reset the track for the subsequent AddTrack() to
1777 // succeed.
1778 EXPECT_TRUE(sender1->SetTrack(nullptr));
1779 auto sender2 = caller->AddTrack(track);
1780 EXPECT_TRUE(sender2);
1781 EXPECT_TRUE(sender1->SetTrack(track));
1782
Steve Anton3172c032018-05-03 15:30:18 -07001783 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1784 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
1785 // return true, and doing |callee->SetRemoteDescription()| should work.
1786 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
1787 } else {
1788 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
1789 }
Henrik Boström91d039b2018-01-11 17:43:30 +01001790}
1791
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001792// This test exercises the code path that fires a NegotiationNeeded
1793// notification when the stream IDs of the local description differ from
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02001794// the ones in the transceiver.
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001795TEST_F(PeerConnectionRtpTestUnifiedPlan,
1796 ChangeAssociatedStreamsTriggersRenegotiation) {
1797 auto caller = CreatePeerConnection();
1798 auto callee = CreatePeerConnection();
1799
1800 RtpTransceiverInit init;
1801 init.direction = RtpTransceiverDirection::kSendRecv;
1802 auto transceiver =
1803 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1804 EXPECT_TRUE(caller->observer()->negotiation_needed());
1805
1806 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1807 caller->observer()->clear_negotiation_needed();
1808
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02001809 transceiver->sender()->SetStreams({"stream3", "stream4", "stream5"});
Henrik Andreasssoncc189172019-05-20 09:01:38 +00001810 EXPECT_TRUE(caller->observer()->negotiation_needed());
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02001811
1812 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
1813 auto callee_streams = callee->pc()->GetReceivers()[0]->streams();
1814 ASSERT_EQ(3u, callee_streams.size());
1815 EXPECT_EQ("stream3", callee_streams[0]->id());
1816 EXPECT_EQ("stream4", callee_streams[1]->id());
1817 EXPECT_EQ("stream5", callee_streams[2]->id());
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001818}
1819
Mirko Bonadeic84f6612019-01-31 12:20:57 +01001820INSTANTIATE_TEST_SUITE_P(PeerConnectionRtpTest,
1821 PeerConnectionRtpTest,
1822 Values(SdpSemantics::kPlanB,
1823 SdpSemantics::kUnifiedPlan));
Steve Anton3172c032018-05-03 15:30:18 -07001824
Steve Anton9158ef62017-11-27 13:01:52 -08001825} // namespace webrtc