blob: da40a38fc1bf0e59f268d438b279d84237fb6e13 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
333 "ERROR: a/IBaz.aidl:1.47-51: 'out IBinder bar' can only be an in parameter.\n";
334 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700335 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700336 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900337}
338
Jiyong Park40782d02020-07-24 19:17:43 +0900339TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700340 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
341 const string expected_stderr =
342 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700343 CaptureStderr();
344 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
345 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900346}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700347
Jiyong Park40782d02020-07-24 19:17:43 +0900348TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700349 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900350 const string expected_stderr =
351 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700352 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700353 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700354 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700355}
356
Devin Moore7b8d5c92020-03-17 14:14:08 -0700357TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700358 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
359 const string expected_stderr =
360 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
361 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700362 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700363 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700364}
365
Devin Moore7b8d5c92020-03-17 14:14:08 -0700366TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700367 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
368 const string expected_stderr =
369 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
370 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700371 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700372 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800373}
374
Devin Moore2f2077a2020-08-28 11:27:53 -0700375TEST_P(AidlTest, AcceptNullableList) {
376 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
377 const string expected_stderr = "";
378 CaptureStderr();
379 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
380 EXPECT_EQ(expected_stderr, GetCapturedStderr());
381}
382
Devin Moore7b8d5c92020-03-17 14:14:08 -0700383TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700384 const string method = "package a; interface IFoo { void f(int a, int a); }";
385 const string expected_stderr =
386 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
387 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700388 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700389 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700390}
391
Jeongik Cha13066da2020-08-06 15:43:19 +0900392TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
393 const string method = "package a; parcelable Foo { int a; String a; }";
394 const string expected_stderr =
395 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
396 CaptureStderr();
397 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
399}
400
Devin Moore7b8d5c92020-03-17 14:14:08 -0700401TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700402 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
403 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
404 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700405 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700406 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100407}
408
Devin Moore7b8d5c92020-03-17 14:14:08 -0700409TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700410 AidlError error;
411 const string method = "package a; @nullable interface IFoo { int f(); }";
412 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800413 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900414 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700415 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
418 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800419}
420
Devin Moore7b8d5c92020-03-17 14:14:08 -0700421TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700422 AidlError error;
423 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
424 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800425 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900426 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700427 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700428 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700429 EXPECT_EQ(expected_stderr, GetCapturedStderr());
430 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800431}
432
Devin Moore7b8d5c92020-03-17 14:14:08 -0700433TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700434 AidlError error;
435 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
436 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000437 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900438 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900439 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700440 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000441 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700442 EXPECT_EQ(expected_stderr, GetCapturedStderr());
443 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800444}
445
Devin Moore7b8d5c92020-03-17 14:14:08 -0700446TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700447 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000448 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700449 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000450 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900451 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDebug, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700452 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700453 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000454 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700455 EXPECT_EQ(expected_stderr, GetCapturedStderr());
456 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800457}
458
Jiyong Park40782d02020-07-24 19:17:43 +0900459TEST_P(AidlTest, ParsesNonNullableAnnotation) {
460 auto parse_result =
461 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
462 ASSERT_NE(nullptr, parse_result);
463 const AidlInterface* interface = parse_result->AsInterface();
464 ASSERT_NE(nullptr, interface);
465 ASSERT_FALSE(interface->GetMethods().empty());
466 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
467}
468
Devin Moore7b8d5c92020-03-17 14:14:08 -0700469TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900470 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
471 typenames_, GetLanguage());
472 ASSERT_NE(nullptr, parse_result);
473 const AidlInterface* interface = parse_result->AsInterface();
474 ASSERT_NE(nullptr, interface);
475 ASSERT_FALSE(interface->GetMethods().empty());
476 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
477}
478
479TEST_P(AidlTest, ParsesNonUtf8Annotations) {
480 auto parse_result =
481 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
482 ASSERT_NE(nullptr, parse_result);
483 const AidlInterface* interface = parse_result->AsInterface();
484 ASSERT_NE(nullptr, interface);
485 ASSERT_FALSE(interface->GetMethods().empty());
486 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800487}
488
Devin Moore7b8d5c92020-03-17 14:14:08 -0700489TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900490 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
491 typenames_, GetLanguage());
492 ASSERT_NE(nullptr, parse_result);
493 const AidlInterface* interface = parse_result->AsInterface();
494 ASSERT_NE(nullptr, interface);
495 ASSERT_FALSE(interface->GetMethods().empty());
496 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800497}
498
Devin Moore7b8d5c92020-03-17 14:14:08 -0700499TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700500 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700501 const string expected_stderr =
502 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
503 "\"vintf\"'\n"
504 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
505 "--structured\n";
506 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700507 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700508 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700509 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700510 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700511}
512
Devin Moore7b8d5c92020-03-17 14:14:08 -0700513TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700514 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700515 const string expected_stderr =
516 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
517 "--structured\n";
518 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700519 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700520 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700521 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700523}
524
Devin Moore7b8d5c92020-03-17 14:14:08 -0700525TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700526 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700527 const string expected_stderr =
528 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
529 "\"vintf\"'\n";
530 CaptureStderr();
531 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700532 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700533 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700535}
536
Devin Moore7b8d5c92020-03-17 14:14:08 -0700537TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700538 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700539 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
540 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700541 ASSERT_EQ(AidlError::OK, error);
542 ASSERT_NE(nullptr, parse_result);
543 const AidlInterface* interface = parse_result->AsInterface();
544 ASSERT_NE(nullptr, interface);
545 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546}
547
Jeongik Cha64783ed2019-06-07 18:30:54 +0900548TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
549 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900550 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
551 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900552 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700553 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900554 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900555 "a/Foo.aidl",
556 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900557
558 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900559 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700560 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900561 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700562 "Parcelable must be defined in AIDL directly.\n";
563 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900564 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700565 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700566
567 CaptureStderr();
568 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
569 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900570}
571
Jiyong Park43113fb2020-07-20 16:26:19 +0900572TEST_F(AidlTest, ParsesJavaDebugAnnotation) {
573 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
574 @JavaDebug parcelable IFoo { int a; float b; })");
575 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
576 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
577
578 string java_out;
579 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
580 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
581
582 // Other backends shouldn't be bothered
583 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
584 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
585
586 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
587 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
588}
589
590TEST_F(AidlTest, RejectsJavaDebugAnnotation) {
591 {
592 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug interface IFoo{}");
593 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
594 CaptureStderr();
595 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
596 const std::string expected_stderr =
597 "ERROR: a/IFoo.aidl:1.22-32: 'JavaDebug' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900598 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
599 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900600 EXPECT_EQ(expected_stderr, GetCapturedStderr());
601 }
602
603 {
604 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug enum IFoo { A=1, }");
605 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
606 CaptureStderr();
607 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
608 const std::string expected_stderr =
609 "ERROR: a/IFoo.aidl:1.27-32: 'JavaDebug' is not a supported annotation for this node. "
610 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
611 EXPECT_EQ(expected_stderr, GetCapturedStderr());
612 }
613}
614
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900615TEST_P(AidlTest, ParseDescriptorAnnotation) {
616 AidlError error;
617 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
618 typenames_, GetLanguage(), &error, {"--structured"});
619 ASSERT_EQ(AidlError::OK, error);
620 ASSERT_NE(nullptr, parse_result);
621 const AidlInterface* interface = parse_result->AsInterface();
622 ASSERT_NE(nullptr, interface);
623 ASSERT_EQ("IBar", interface->GetDescriptor());
624}
625
Jiyong Park40782d02020-07-24 19:17:43 +0900626TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700627 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700628 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900629}
630
631TEST_P(AidlTest, AcceptsOnewayInterface) {
632 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700633 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700634}
Christopher Wileyef140932015-11-03 09:29:19 -0800635
Devin Moore7b8d5c92020-03-17 14:14:08 -0700636TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700637 const string oneway_method =
638 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700639 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100640}
641
Steven Moreland65297cc2020-04-20 20:17:36 -0700642TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
643 const string oneway_method =
644 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
645 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
646 ASSERT_NE(nullptr, defined);
647 const AidlInterface* iface = defined->AsInterface();
648 ASSERT_NE(nullptr, iface);
649
650 const auto& methods = iface->GetMethods();
651 ASSERT_EQ(1u, methods.size());
652 const auto& method = methods[0];
653 const AidlTypeSpecifier& ret_type = method->GetType();
654
655 // TODO(b/151102494): these annotations should be on the method
656 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
657 ASSERT_TRUE(ret_type.IsHide());
658}
659
Devin Moore7b8d5c92020-03-17 14:14:08 -0700660TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100661 string foo_interface =
662 "package a; /* foo */ interface IFoo {"
663 " /* i */ int i();"
664 " /* j */ @nullable String j();"
665 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
666
Devin Moore7b8d5c92020-03-17 14:14:08 -0700667 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100668 EXPECT_NE(nullptr, parse_result);
669 EXPECT_EQ("/* foo */", parse_result->GetComments());
670
671 const AidlInterface* interface = parse_result->AsInterface();
672 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
673 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
674 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
675}
676
Jooyung Han1a551d32020-10-05 15:37:26 +0900677TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
678 io_delegate_.SetFileContents("p/cpp_header.aidl",
679 R"(package p;
680 parcelable cpp_header cpp_header "bar/header";)");
681 import_paths_.emplace("");
682 const string input_path = "p/IFoo.aidl";
683 const string input = R"(package p;
684 import p.cpp_header;
685 interface IFoo {
686 // get bar
687 cpp_header get();
688 })";
689
690 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
691 EXPECT_NE(nullptr, parse_result);
692 const AidlInterface* interface = parse_result->AsInterface();
693 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
694}
695
Christopher Wileyef140932015-11-03 09:29:19 -0800696TEST_F(AidlTest, ParsesPreprocessedFile) {
697 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
698 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700699 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900700 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700701 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
702 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800703}
704
705TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
706 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
707 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900708
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700709 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900710 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700711 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
712 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800713}
714
Devin Moore7b8d5c92020-03-17 14:14:08 -0700715TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800716 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
717 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
718 "interface IBar {}");
719 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900720 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900721 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700722 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800723 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900724
Christopher Wiley41544372015-11-03 14:52:29 -0800725 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700726 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
727 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800728 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700729 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900730 ambiguous_type.Resolve(typenames_);
731 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800732}
733
Jiyong Park8f6ec462020-01-19 20:52:47 +0900734// Special case of PreferImportToPreprocessed. Imported type should be preferred
735// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700736TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900737 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
738 io_delegate_.SetFileContents("one/IBar.aidl",
739 "package one; "
740 "interface IBar {}");
741 preprocessed_files_.push_back("preprocessed");
742 import_paths_.emplace("");
743 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700744 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900745 EXPECT_NE(nullptr, parse_result);
746
747 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700748 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
749 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900750 // But if we request just "IBar" we should get our imported one.
751 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
752 ambiguous_type.Resolve(typenames_);
753 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
754}
755
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800756TEST_F(AidlTest, WritePreprocessedFile) {
757 io_delegate_.SetFileContents("p/Outer.aidl",
758 "package p; parcelable Outer.Inner;");
759 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
760 "interface IBar {}");
761
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900762 vector<string> args {
763 "aidl",
764 "--preprocess",
765 "preprocessed",
766 "p/Outer.aidl",
767 "one/IBar.aidl"};
768 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800769 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
770
771 string output;
772 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
773 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
774}
775
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900776TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100777 io_delegate_.SetFileContents(
778 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800779 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100780 "parcelable Rect {\n"
781 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800782 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100783 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800784 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100785 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100786 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
787 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100788 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900789 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900790 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100791 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900792
793 vector<string> args{"aidl", "Rect.aidl"};
794 Options options = Options::From(args);
795 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
796
797 string output;
798 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900799 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900800}
801
Devin Moore2f2077a2020-08-28 11:27:53 -0700802TEST_F(AidlTest, CppHeaderIncludes) {
803 io_delegate_.SetFileContents("IFoo.aidl",
804 "interface IFoo {\n"
805 " @nullable List<String> foo();\n"
806 "}");
807
808 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
809 Options options = Options::From(args);
810 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
811 std::vector<std::string> empty;
812 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
813 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
814 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
815
816 // Make sure the optional and String16.h includes are added
817 string output;
818 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
819 EXPECT_EQ(kExpectedCppHeaderOutput, output);
820}
821
Devin Moore7b8d5c92020-03-17 14:14:08 -0700822TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700823 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800824 io_delegate_.SetFileContents("p/Outer.aidl",
825 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900826 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700827 CaptureStderr();
828 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
829 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700830 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700831 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800832}
833
Devin Moore7b8d5c92020-03-17 14:14:08 -0700834TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800835 io_delegate_.SetFileContents("preprocessed",
836 "parcelable p.Outer.Inner;");
837 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900838 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700839 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800840 // TODO(wiley): This should actually return nullptr because we require
841 // the outer class name. However, for legacy reasons,
842 // this behavior must be maintained. b/17415692
843 EXPECT_NE(nullptr, parse_result);
844}
845
Christopher Wiley632801d2015-11-05 14:15:49 -0800846TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700847 const string expected_foo_stderr =
848 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
849 "Declared parcelables should be in their own file and/or cannot be used with --structured "
850 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700851 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
852
Christopher Wiley632801d2015-11-05 14:15:49 -0800853 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700854 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700855 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900856 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700857 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900858
Steven Morelande2c64b42018-09-18 15:06:37 -0700859 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900860 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700861 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900862 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700863 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700864
Devin Moore097a3ab2020-03-11 16:08:44 -0700865 const string expected_bar_stderr =
866 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
867 "Declared parcelables should be in their own file and/or cannot be used with --structured "
868 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700869 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
870
Jiyong Parkda8c6932019-08-12 19:56:08 +0900871 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700872 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700873 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900874 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700875 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700876 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700877 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700878 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700879 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800880}
881
Devin Moore7b8d5c92020-03-17 14:14:08 -0700882TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700883 const string expected_stderr =
884 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
885 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700886 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
887 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700888 AidlError error;
889 CaptureStderr();
890 EXPECT_EQ(
891 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700892 Parse("p/IFoo.aidl",
893 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700894 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700895 EXPECT_EQ(expected_stderr, GetCapturedStderr());
896 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700897}
898
Devin Moore7b8d5c92020-03-17 14:14:08 -0700899TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700900 AidlError error;
901 const string expected_stderr =
902 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
903 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900904 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
905 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700906 interface IFoo {
907 const String DUPLICATED = "d";
908 const int DUPLICATED = 1;
909 }
910 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700911 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700912 EXPECT_EQ(expected_stderr, GetCapturedStderr());
913 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700914}
915
Devin Moore7b8d5c92020-03-17 14:14:08 -0700916TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700917 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700918 const string expected_stderr =
919 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700920 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700921 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
922 R"(package p;
923 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700924 parcelable IBar {}
925 parcelable StructuredParcelable {}
926 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900927 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700928 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700929 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700930 // Parse success is important for clear error handling even if the cases aren't
931 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700932 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700933}
934
Devin Moore7b8d5c92020-03-17 14:14:08 -0700935TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 AidlError error;
937 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
938 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700939 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
941 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700942}
943
Steven Morelandf9e922f2020-07-08 21:15:27 +0000944TEST_P(AidlTest, FailOnEmptyListWithComma) {
945 AidlError error;
946 const string expected_stderr =
947 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
948 CaptureStderr();
949 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
950 typenames_, GetLanguage(), &error));
951 EXPECT_EQ(expected_stderr, GetCapturedStderr());
952 EXPECT_EQ(AidlError::PARSE_ERROR, error);
953}
954
Devin Moore7b8d5c92020-03-17 14:14:08 -0700955TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700956 AidlError error;
957 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -0700958 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700959 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900960 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
961 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700962 interface IFoo {
963 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
964 }
965 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700966 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700967 EXPECT_EQ(expected_stderr, GetCapturedStderr());
968 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -0700969}
970
Jiyong Park18132182020-06-08 20:24:40 +0900971TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
972 AidlError error;
973 const string expected_stderr =
974 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
975 "cpp_header (which can also be used as an identifier)\n";
976 CaptureStderr();
977 // Notice the trailing dot(.) in the name, which isn't a correct name
978 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
979 GetLanguage(), &error));
980 EXPECT_EQ(expected_stderr, GetCapturedStderr());
981 EXPECT_EQ(AidlError::PARSE_ERROR, error);
982}
983
984TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
985 AidlError error;
986 const string expected_stderr =
987 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
988 "cpp_header (which can also be used as an identifier)\n";
989 CaptureStderr();
990 // Notice the trailing dot(.) in the package name
991 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
992 GetLanguage(), &error));
993 EXPECT_EQ(expected_stderr, GetCapturedStderr());
994 EXPECT_EQ(AidlError::PARSE_ERROR, error);
995}
996
Devin Moore7b8d5c92020-03-17 14:14:08 -0700997TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700998 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700999 auto parse_result = Parse("p/IFoo.aidl",
1000 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001001 interface IFoo {
1002 const int POSITIVE_HEX_VALUE = 0xf5;
1003 }
1004 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001005 typenames_, GetLanguage(), &error);
1006 EXPECT_NE(nullptr, parse_result);
1007 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001008 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001009 const auto& cpp_constants = interface->GetConstantDeclarations();
1010 EXPECT_EQ((size_t)1, cpp_constants.size());
1011 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001012 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001013 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001014}
1015
Devin Moore7b8d5c92020-03-17 14:14:08 -07001016TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001017 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001018 auto parse_result = Parse("p/IFoo.aidl",
1019 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001020 interface IFoo {
1021 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1022 }
1023 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001024 typenames_, GetLanguage(), &error);
1025 ASSERT_NE(nullptr, parse_result);
1026 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001027 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001028 const auto& cpp_constants = interface->GetConstantDeclarations();
1029 EXPECT_EQ((size_t)1, cpp_constants.size());
1030 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001031 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001032 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001033}
1034
Devin Moore7b8d5c92020-03-17 14:14:08 -07001035TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001036 io_delegate_.SetFileContents(
1037 "p/Outer.aidl",
1038 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001039 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001040 const string input_path = "p/IFoo.aidl";
1041 const string input = "package p; import p.Outer; interface IFoo"
1042 " { Outer.Inner get(); }";
1043
Devin Moore7b8d5c92020-03-17 14:14:08 -07001044 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1045 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001046
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001047 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001048 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001049 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1050 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001051}
1052
Devin Moore7b8d5c92020-03-17 14:14:08 -07001053TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001054 io_delegate_.SetFileContents(
1055 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001056 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001057 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001058 const string input_path = "p/IFoo.aidl";
1059 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001060 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1061 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001062 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001063 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1064 native_type.Resolve(typenames_);
1065
1066 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1067 // C++ understands C++ specific stuff
1068 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1069 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001070 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001071 EXPECT_EQ(1u, headers.size());
1072 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001073}
1074
Christopher Wileyf8136192016-04-12 14:19:35 -07001075TEST_F(AidlTest, WritesCorrectDependencyFile) {
1076 // While the in tree build system always gives us an output file name,
1077 // other android tools take advantage of our ability to infer the intended
1078 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001079 vector<string> args = {
1080 "aidl",
1081 "-d dep/file/path",
1082 "-o place/for/output",
1083 "p/IFoo.aidl"};
1084 Options options = Options::From(args);
1085 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001086 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001087 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001088 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001089 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1090}
1091
Dan Willemsen93298ee2016-11-10 23:55:55 -08001092TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1093 // While the in tree build system always gives us an output file name,
1094 // other android tools take advantage of our ability to infer the intended
1095 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001096 vector<string> args = {
1097 "aidl",
1098 "-d dep/file/path",
1099 "--ninja",
1100 "-o place/for/output",
1101 "p/IFoo.aidl"};
1102 Options options = Options::From(args);
1103 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001104 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001105 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001106 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001107 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1108}
1109
Jiyong Parkdf202122019-09-30 20:48:35 +09001110TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001111 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1112 // this by calling aidl with every .aidl file it finds, then parsing the
1113 // generated dependency files. Those that reference .java output files are
1114 // for interfaces and those that do not are parcelables. However, for both
1115 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001116 vector<string> args = {
1117 "aidl",
1118 "-o place/for/output",
1119 "-d dep/file/path",
1120 "p/Foo.aidl"};
1121 Options options = Options::From(args);
1122 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001123 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001124 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001125 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001126 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1127}
1128
1129TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1130 vector<string> args = {
1131 "aidl",
1132 "--structured",
1133 "-o place/for/output",
1134 "-d dep/file/path",
1135 "p/Foo.aidl"};
1136 Options options = Options::From(args);
1137 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1138 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1139 string actual_dep_file_contents;
1140 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1141 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001142}
1143
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001144TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1145 vector<string> args = {
1146 "aidl",
1147 "--lang=java",
1148 "-o place/for/output",
1149 "p/Foo.aidl"};
1150 Options options = Options::From(args);
1151 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1152 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1153 string output_file_contents;
1154 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1155}
1156
Jeongik Cha08ca2182019-11-21 14:01:13 +09001157// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001158TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001159 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001160 "package a; interface IFoo {\n"
1161 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001162 string expected_stderr;
1163 switch (GetLanguage()) {
1164 case Options::Language::CPP:
1165 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001166 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001167 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1168 "String and IBinder.\n";
1169 break;
1170 case Options::Language::JAVA:
1171 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001172 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001173 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1174 "String, IBinder, and ParcelFileDescriptor.\n";
1175 break;
1176 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001177 case Options::Language::RUST:
1178 expected_stderr =
1179 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1180 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001181 default:
1182 AIDL_FATAL(AIDL_LOCATION_HERE)
1183 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1184 }
1185 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001186 AidlTypenames tn1;
1187 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001188 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001189
1190 string primitive_parcelable =
1191 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001192 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001193 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001194 AidlTypenames tn2;
1195 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001196 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001197}
1198
Devin Moore21b26772020-08-26 16:37:56 -07001199TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001200 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001201 const string list_array_parcelable =
1202 "package a; parcelable Foo {\n"
1203 " List[] lists; }";
1204 CaptureStderr();
1205 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1206 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1207}
1208
Jiyong Parkf8d53612020-05-04 14:06:13 +09001209TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1210 AidlError error;
1211 string expected_stderr =
1212 "ERROR: a/IFoo.aidl:2.7-11: "
1213 "Encountered an untyped List or Map. The use of untyped List/Map is "
1214 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1215 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1216 if (GetLanguage() != Options::Language::JAVA) {
1217 expected_stderr =
1218 "ERROR: a/IFoo.aidl:2.1-7: "
1219 "Currently, only the Java backend supports non-generic List.\n";
1220 }
1221
1222 const string primitive_interface =
1223 "package a; interface IFoo {\n"
1224 " List foo(); }";
1225 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001226 AidlTypenames tn1;
1227 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001228 {"--structured"}));
1229 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001230
1231 string primitive_parcelable =
1232 "package a; parcelable IFoo {\n"
1233 " List foo;}";
1234 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001235 AidlTypenames tn2;
1236 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001237 {"--structured"}));
1238 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1239}
1240
Jeongik Cha225519b2020-08-29 01:55:32 +09001241TEST_P(AidlTest, ExtensionTest) {
1242 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001243 string extendable_parcelable =
1244 "package a; parcelable Data {\n"
1245 " ParcelableHolder extension;\n"
1246 " ParcelableHolder extension2;\n"
1247 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001248 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001249 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1250 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001251 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001252 "yet.\n",
1253 GetCapturedStderr());
1254 } else {
1255 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1256 EXPECT_EQ("", GetCapturedStderr());
1257 }
1258}
1259TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1260 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001261 string parcelableholder_return_interface =
1262 "package a; interface IFoo {\n"
1263 " ParcelableHolder foo();\n"
1264 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001265 EXPECT_EQ(nullptr,
1266 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001267
Jeongik Cha8f02a532020-10-14 00:16:28 +09001268 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001269 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001270 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001271 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001272 "yet.\n",
1273 GetCapturedStderr());
1274 return;
1275 }
1276 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1277 GetCapturedStderr());
1278}
1279
1280TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1281 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001282 string extendable_parcelable_arg_interface =
1283 "package a; interface IFoo {\n"
1284 " void foo(in ParcelableHolder ph);\n"
1285 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001286 EXPECT_EQ(nullptr,
1287 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1288
Jeongik Cha8f02a532020-10-14 00:16:28 +09001289 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001290 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001291 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001292 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001293 "yet.\n",
1294 GetCapturedStderr());
1295 return;
1296 }
1297 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1298 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001299}
1300
Jiyong Park02da7422018-07-16 16:00:26 +09001301TEST_F(AidlTest, ApiDump) {
1302 io_delegate_.SetFileContents(
1303 "foo/bar/IFoo.aidl",
1304 "package foo.bar;\n"
1305 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001306 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001307 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001308 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001309 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1310 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1311 " IFoo foo3(IFoo foo);\n"
1312 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001313 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001314 " const int A = 1;\n"
1315 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001316 "}\n");
1317 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1318 "package foo.bar;\n"
1319 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001320 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001321 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001322 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001323 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001324 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001325 " int y;\n"
1326 " IFoo foo;\n"
1327 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001328 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001329 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001330 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001331 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001332 "}\n");
1333 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001334 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1335 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001336 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001337 bool result = dump_api(options, io_delegate_);
1338 ASSERT_TRUE(result);
1339 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001340 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001341 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001342/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001343interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001344 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001345 int foo(out int[] a, String b, boolean c, inout List<String> d);
1346 int foo2(@utf8InCpp String x, inout List<String> y);
1347 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1348 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001349 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001350 const int A = 1;
1351 const String STR = "Hello";
1352}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001353)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001354
Jiyong Parke59c3682018-09-11 23:10:25 +09001355 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001356 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001357/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001358parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001359 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001360 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001361 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001362 int y;
1363 foo.bar.IFoo foo;
1364 List<foo.bar.IFoo> a;
1365 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001366 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001367 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001368}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001369)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001370}
1371
Jiyong Parked65bf42018-08-28 15:43:27 +09001372TEST_F(AidlTest, ApiDumpWithManualIds) {
1373 io_delegate_.SetFileContents(
1374 "foo/bar/IFoo.aidl",
1375 "package foo.bar;\n"
1376 "interface IFoo {\n"
1377 " int foo() = 1;\n"
1378 " int bar() = 2;\n"
1379 " int baz() = 10;\n"
1380 "}\n");
1381
Jiyong Parke59c3682018-09-11 23:10:25 +09001382 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001383 Options options = Options::From(args);
1384 bool result = dump_api(options, io_delegate_);
1385 ASSERT_TRUE(result);
1386 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001387 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001388 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001389interface IFoo {
1390 int foo() = 1;
1391 int bar() = 2;
1392 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001393}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001394)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001395}
1396
1397TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001398 const string expected_stderr =
1399 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1400 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001401 io_delegate_.SetFileContents(
1402 "foo/bar/IFoo.aidl",
1403 "package foo.bar;\n"
1404 "interface IFoo {\n"
1405 " int foo() = 1;\n"
1406 " int bar();\n"
1407 " int baz() = 10;\n"
1408 "}\n");
1409
Jiyong Parke59c3682018-09-11 23:10:25 +09001410 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001411 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001412 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001413 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001414 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001415}
1416
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001417TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001418 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001419 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1420 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001421 const string expected_map_stderr =
1422 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001423 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1424 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001425 "package p; interface IFoo {"
1426 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001427 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001428 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001429 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001430
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001431 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001432 "package p; interface IFoo {"
1433 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001434 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001435 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001436 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001437}
1438
Jeongik Chae48d9942020-01-02 17:39:00 +09001439TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001440 const string expected_stderr =
1441 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001442 Options options = Options::From("aidl -I p p/IFoo.aidl");
1443 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1444
1445 io_delegate_.SetFileContents("p/IFoo.aidl",
1446 "package p; interface IFoo {"
1447 "Map<String, Bar> foo();}");
1448 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1449
1450 io_delegate_.SetFileContents("p/IFoo.aidl",
1451 "package p; interface IFoo {"
1452 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001453 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001454 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001455 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001456
1457 io_delegate_.SetFileContents("p/IFoo.aidl",
1458 "package p; interface IFoo {"
1459 "Map<String, String> foo();}");
1460 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1461
1462 io_delegate_.SetFileContents("p/IFoo.aidl",
1463 "package p; interface IFoo {"
1464 "Map<String, ParcelFileDescriptor> foo();}");
1465 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1466}
1467
Jeongik Chadf76dc72019-11-28 00:08:47 +09001468TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001469 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001470 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1471 io_delegate_.SetFileContents(options.InputFiles().front(),
1472 "package p; interface IFoo {"
1473 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001474 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001475 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001476 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001477}
1478
1479TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1480 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1481 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001482 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001483 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001484 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1485 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001486
1487 Options options = Options::From("aidl -I p p/IFoo.aidl");
1488 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1489 io_delegate_.SetFileContents("p/IFoo.aidl",
1490 "package p; interface IFoo {"
1491 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001492 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001493 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001494 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001495 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001496 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001497 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001498 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1499 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001500 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1501 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1502 io_delegate_.SetFileContents("p/IFoo.aidl",
1503 "package p; interface IFoo {"
1504 "Bar<String, ParcelFileDescriptor> foo();}");
1505 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001506
1507 io_delegate_.SetFileContents("p/IFoo.aidl",
1508 "package p; interface IFoo {"
1509 "Bar<int, long> foo();}");
1510
1511 io_delegate_.SetFileContents("p/IFoo.aidl",
1512 "package p; interface IFoo {"
1513 "Bar<int[], long[]> foo();}");
1514
1515 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001516}
1517
Jeongik Cha0e426012019-07-29 15:57:02 +09001518TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1519 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001520 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1521 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001522 for (const auto& rawOption : rawOptions) {
1523 string expected_stderr =
1524 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001525 Options options = Options::From(rawOption);
1526 io_delegate_.SetFileContents(options.InputFiles().front(),
1527 "package foo.bar;\n"
1528 "interface IFoo1 { int foo(); }\n"
1529 "interface IFoo2 { int foo(); }\n"
1530 "parcelable Data1 { int a; int b;}\n"
1531 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001532 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001533 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001534 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001535
Jeongik Cha0e426012019-07-29 15:57:02 +09001536 io_delegate_.SetFileContents(options.InputFiles().front(),
1537 "package foo.bar;\n"
1538 "interface IFoo1 { int foo(); }\n"
1539 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001540 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001541 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001542 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001543
Devin Moore5de18ed2020-04-02 13:52:29 -07001544 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001545 io_delegate_.SetFileContents(options.InputFiles().front(),
1546 "package foo.bar;\n"
1547 "parcelable Data1 { int a; int b;}\n"
1548 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001549 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001550 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001551 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001552 }
1553}
1554
Devin Moorebdba2a82020-03-31 15:19:02 -07001555TEST_P(AidlTest, FailParseOnEmptyFile) {
1556 const string contents = "";
1557 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1558 CaptureStderr();
1559 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1560 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1561}
1562
Jiyong Parkb034bf02018-07-30 17:44:33 +09001563TEST_F(AidlTest, MultipleInputFiles) {
1564 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001565 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001566
1567 io_delegate_.SetFileContents(options.InputFiles().at(0),
1568 "package foo.bar;\n"
1569 "import foo.bar.Data;\n"
1570 "interface IFoo { Data getData(); }\n");
1571
1572 io_delegate_.SetFileContents(options.InputFiles().at(1),
1573 "package foo.bar;\n"
1574 "import foo.bar.IFoo;\n"
1575 "parcelable Data { IFoo foo; }\n");
1576
1577 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1578
1579 string content;
1580 for (const auto file : {
1581 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1582 content.clear();
1583 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1584 EXPECT_FALSE(content.empty());
1585 }
1586}
1587
1588TEST_F(AidlTest, MultipleInputFilesCpp) {
1589 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001590 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001591
1592 io_delegate_.SetFileContents(options.InputFiles().at(0),
1593 "package foo.bar;\n"
1594 "import foo.bar.Data;\n"
1595 "interface IFoo { Data getData(); }\n");
1596
1597 io_delegate_.SetFileContents(options.InputFiles().at(1),
1598 "package foo.bar;\n"
1599 "import foo.bar.IFoo;\n"
1600 "parcelable Data { IFoo foo; }\n");
1601
1602 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1603
1604 string content;
1605 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001606 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001607 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1608 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1609 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1610 content.clear();
1611 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1612 EXPECT_FALSE(content.empty());
1613 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001614}
1615
Andrei Homescub62afd92020-05-11 19:24:59 -07001616TEST_F(AidlTest, MultipleInputFilesRust) {
1617 Options options =
1618 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1619
1620 io_delegate_.SetFileContents(options.InputFiles().at(0),
1621 "package foo.bar;\n"
1622 "import foo.bar.Data;\n"
1623 "interface IFoo { Data getData(); }\n");
1624
1625 io_delegate_.SetFileContents(options.InputFiles().at(1),
1626 "package foo.bar;\n"
1627 "import foo.bar.IFoo;\n"
1628 "parcelable Data { IFoo foo; }\n");
1629
1630 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1631
1632 string content;
1633 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1634 content.clear();
1635 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1636 EXPECT_FALSE(content.empty());
1637 }
1638}
1639
Devin Moore097a3ab2020-03-11 16:08:44 -07001640TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1641 const string expected_stderr =
1642 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001643 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1644 // int getInterfaceVersion() is one of the meta transactions
1645 io_delegate_.SetFileContents(options.InputFiles().front(),
1646 "package p; interface IFoo {"
1647 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001648 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001649 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001650 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1651}
Jiyong Park309668e2018-07-28 16:55:44 +09001652
Devin Moore097a3ab2020-03-11 16:08:44 -07001653TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1654 // boolean getInterfaceVersion() is not a meta transaction, but should be
1655 // prevented because return type is not part of a method signature
1656 const string expected_stderr =
1657 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1658 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001659 io_delegate_.SetFileContents(options.InputFiles().front(),
1660 "package p; interface IFoo {"
1661 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001662 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001663 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001664 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1665}
Jiyong Park309668e2018-07-28 16:55:44 +09001666
Devin Moore097a3ab2020-03-11 16:08:44 -07001667TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001668 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001669 const string expected_stderr =
1670 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1671 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001672 io_delegate_.SetFileContents(options.InputFiles().front(),
1673 "package p; interface IFoo {"
1674 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001675 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001676 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001677 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001678
1679 // this is not a meta interface method as it differs type arguments
1680 io_delegate_.SetFileContents(options.InputFiles().front(),
1681 "package p; interface IFoo {"
1682 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001683 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001684}
1685
Daniel Norman85aed542019-08-21 12:01:14 -07001686TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001687 Options options = Options::From("aidl --checkapi old new");
1688 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1689 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1690 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1691 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1692
1693 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1694}
1695
Jiyong Park3656c3c2018-08-01 20:02:01 +09001696TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001697 Options options = Options::From("aidl --checkapi old new");
1698 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1699 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001700
1701 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1702}
1703
Daniel Norman85aed542019-08-21 12:01:14 -07001704class AidlTestCompatibleChanges : public AidlTest {
1705 protected:
1706 Options options_ = Options::From("aidl --checkapi old new");
1707};
1708
1709TEST_F(AidlTestCompatibleChanges, NewType) {
1710 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1711 "package p;"
1712 "interface IFoo {"
1713 " void foo(int a);"
1714 "}");
1715 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1716 "package p;"
1717 "interface IFoo {"
1718 " void foo(int a);"
1719 "}");
1720 io_delegate_.SetFileContents("new/p/IBar.aidl",
1721 "package p;"
1722 "interface IBar {"
1723 " void bar();"
1724 "}");
1725 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1726}
1727
1728TEST_F(AidlTestCompatibleChanges, NewMethod) {
1729 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1730 "package p;"
1731 "interface IFoo {"
1732 " void foo(int a);"
1733 "}");
1734 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1735 "package p;"
1736 "interface IFoo {"
1737 " void foo(int a);"
1738 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001739 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001740 "}");
1741 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1742}
1743
1744TEST_F(AidlTestCompatibleChanges, NewField) {
1745 io_delegate_.SetFileContents("old/p/Data.aidl",
1746 "package p;"
1747 "parcelable Data {"
1748 " int foo;"
1749 "}");
1750 io_delegate_.SetFileContents("new/p/Data.aidl",
1751 "package p;"
1752 "parcelable Data {"
1753 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001754 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001755 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001756 "}");
1757 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1758}
1759
1760TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1761 io_delegate_.SetFileContents("old/p/Enum.aidl",
1762 "package p;"
1763 "enum Enum {"
1764 " FOO = 1,"
1765 "}");
1766 io_delegate_.SetFileContents("new/p/Enum.aidl",
1767 "package p;"
1768 "enum Enum {"
1769 " FOO = 1,"
1770 " BAR = 2,"
1771 "}");
1772 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1773}
1774
1775TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1776 io_delegate_.SetFileContents("old/p/Enum.aidl",
1777 "package p;"
1778 "enum Enum {"
1779 " FOO = 1,"
1780 " BAR = 2,"
1781 "}");
1782 io_delegate_.SetFileContents("new/p/Enum.aidl",
1783 "package p;"
1784 "enum Enum {"
1785 " BAR = 2,"
1786 " FOO = 1,"
1787 "}");
1788 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1789}
1790
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001791TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1792 io_delegate_.SetFileContents("old/p/Union.aidl",
1793 "package p;"
1794 "union Union {"
1795 " String foo;"
1796 "}");
1797 io_delegate_.SetFileContents("new/p/Union.aidl",
1798 "package p;"
1799 "union Union {"
1800 " String foo;"
1801 " int num;"
1802 "}");
1803 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1804}
1805
Daniel Norman85aed542019-08-21 12:01:14 -07001806TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001807 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1808 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001809 "interface IFoo {"
1810 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001811 "}");
1812 io_delegate_.SetFileContents("old/p/Data.aidl",
1813 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001814 "parcelable Data {"
1815 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001816 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001817 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1818 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001819 "interface IFoo {"
1820 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001821 "}");
1822 io_delegate_.SetFileContents("new/p/Data.aidl",
1823 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001824 "parcelable Data {"
1825 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001826 "}");
1827 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1828 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001829 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001830 " void foo(int a);"
1831 "}");
1832 io_delegate_.SetFileContents("new/q/Data.aidl",
1833 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001834 "parcelable Data {"
1835 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001836 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001837 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1838}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001839
Daniel Norman85aed542019-08-21 12:01:14 -07001840TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1841 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1842 "package p;"
1843 "interface IFoo {"
1844 " void foo(int a);"
1845 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001846 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1847 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001848 "interface IFoo {"
1849 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001850 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001851 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1852}
Jiyong Parke59c3682018-09-11 23:10:25 +09001853
Daniel Norman85aed542019-08-21 12:01:14 -07001854TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001855 io_delegate_.SetFileContents("old/p/I.aidl",
1856 "package p; interface I {"
1857 "const int A = 1; }");
1858 io_delegate_.SetFileContents("new/p/I.aidl",
1859 "package p ; interface I {"
1860 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001861 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1862}
Jiyong Parka428d212018-08-29 22:26:30 +09001863
Daniel Norman85aed542019-08-21 12:01:14 -07001864TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001865 io_delegate_.SetFileContents("old/p/I.aidl",
1866 "package p; interface I {"
1867 "const int A = 1; const int B = 2;}");
1868 io_delegate_.SetFileContents("new/p/I.aidl",
1869 "package p ; interface I {"
1870 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001871 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001872}
1873
Jooyung Han636fd2f2020-10-22 11:33:45 +09001874TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
1875 io_delegate_.SetFileContents("old/p/Data.aidl",
1876 "package p;"
1877 "parcelable Data {"
1878 " int num;"
1879 "}");
1880 io_delegate_.SetFileContents(
1881 "new/p/Data.aidl",
1882 "package p;"
1883 "parcelable Data {"
1884 " int num;"
1885 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
1886 "}");
1887 io_delegate_.SetFileContents("new/p/Enum.aidl",
1888 "package p;"
1889 "enum Enum {"
1890 " FOO = 0,"
1891 " BAR = 1,"
1892 "}");
1893 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1894}
1895
Daniel Norman85aed542019-08-21 12:01:14 -07001896class AidlTestIncompatibleChanges : public AidlTest {
1897 protected:
1898 Options options_ = Options::From("aidl --checkapi old new");
1899};
1900
1901TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001902 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001903 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1904 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001905 "interface IFoo {"
1906 " void foo(in String[] str);"
1907 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001908 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001909 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001910 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001911 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001912}
1913
1914TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001915 const string expected_stderr =
1916 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001917 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1918 "package p;"
1919 "interface IFoo {"
1920 " void foo(in String[] str);"
1921 " void bar(@utf8InCpp String str);"
1922 "}");
1923 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1924 "package p;"
1925 "interface IFoo {"
1926 " void foo(in String[] str);"
1927 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001928 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001929 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001930 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001931}
1932
Jiyong Parkf8d53612020-05-04 14:06:13 +09001933TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1934 const string expected_stderr =
1935 "ERROR: new/p/IFoo.aidl:1.61-65: "
1936 "Encountered an untyped List or Map. The use of untyped List/Map is "
1937 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1938 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1939 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1940 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1941 "package p;"
1942 "interface IFoo {"
1943 " void foo(in String[] str);"
1944 "}");
1945 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1946 "package p;"
1947 "interface IFoo {"
1948 " void foo(in String[] str);"
1949 " void bar(in List arg);"
1950 "}");
1951 CaptureStderr();
1952 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1953 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1954}
1955
1956TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
1957 const string expected_stderr =
1958 "ERROR: new/p/Data.aidl:1.54-59: "
1959 "Encountered an untyped List or Map. The use of untyped List/Map is "
1960 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1961 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1962 "ERROR: new/p/Data.aidl: Failed to read.\n";
1963 io_delegate_.SetFileContents("old/p/Data.aidl",
1964 "package p;"
1965 "parcelable Data {"
1966 " int foo;"
1967 "}");
1968 io_delegate_.SetFileContents("new/p/Data.aidl",
1969 "package p;"
1970 "parcelable Data {"
1971 " int foo;"
1972 " @nullable List list;"
1973 "}");
1974 CaptureStderr();
1975 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1976 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1977}
1978
Daniel Norman85aed542019-08-21 12:01:14 -07001979TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001980 const string expected_stderr =
1981 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001982 io_delegate_.SetFileContents("old/p/Data.aidl",
1983 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001984 "parcelable Data {"
1985 " int foo;"
1986 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001987 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001988 io_delegate_.SetFileContents("new/p/Data.aidl",
1989 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001990 "parcelable Data {"
1991 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001992 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001993 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001994 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001995 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001996}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001997
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001998TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
1999 const string expected_stderr =
2000 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2001 "backends. Please either provide a default value for this field or mark the field as "
2002 "@nullable. This value or a null value will be used automatically when an old version of "
2003 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2004 "order to make sure your code continues to be backwards compatible, make sure the default or "
2005 "null value does not cause a semantic change to this parcelable.\n";
2006 io_delegate_.SetFileContents("old/p/Data.aidl",
2007 "package p;"
2008 "parcelable Data {"
2009 " int num;"
2010 "}");
2011 io_delegate_.SetFileContents("new/p/Data.aidl",
2012 "package p;"
2013 "parcelable Data {"
2014 " int num;"
2015 " String str;"
2016 "}");
2017 CaptureStderr();
2018 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2019 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2020}
2021
Jooyung Han636fd2f2020-10-22 11:33:45 +09002022TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2023 const string expected_stderr =
2024 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2025 "Please make sure 'Enum' has '0' as a valid value.\n";
2026 io_delegate_.SetFileContents("old/p/Data.aidl",
2027 "package p;"
2028 "parcelable Data {"
2029 " int num;"
2030 "}");
2031 io_delegate_.SetFileContents("new/p/Data.aidl",
2032 "package p;"
2033 "parcelable Data {"
2034 " int num;"
2035 " p.Enum e;"
2036 "}");
2037 io_delegate_.SetFileContents("new/p/Enum.aidl",
2038 "package p;"
2039 "enum Enum {"
2040 " FOO = 1,"
2041 " BAR = 2,"
2042 "}");
2043 CaptureStderr();
2044 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2045 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2046}
2047
Daniel Norman85aed542019-08-21 12:01:14 -07002048TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002049 const string expected_stderr =
2050 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002051 io_delegate_.SetFileContents("old/p/Enum.aidl",
2052 "package p;"
2053 "enum Enum {"
2054 " FOO = 1,"
2055 " BAR = 2,"
2056 "}");
2057 io_delegate_.SetFileContents("new/p/Enum.aidl",
2058 "package p;"
2059 "enum Enum {"
2060 " BAR = 2,"
2061 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002062 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002063 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002064 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002065}
2066
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002067TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2068 const string expected_stderr =
2069 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2070 io_delegate_.SetFileContents("old/p/Union.aidl",
2071 "package p;"
2072 "union Union {"
2073 " String str;"
2074 " int num;"
2075 "}");
2076 io_delegate_.SetFileContents("new/p/Union.aidl",
2077 "package p;"
2078 "union Union {"
2079 " String str;"
2080 "}");
2081 CaptureStderr();
2082 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2083 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2084}
2085
Daniel Norman85aed542019-08-21 12:01:14 -07002086TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002087 const string expected_stderr =
2088 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002089 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2090 "package p;"
2091 "interface IFoo {"
2092 " void foo(in String[] str);"
2093 " void bar(@utf8InCpp String str);"
2094 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002095 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2096 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002097 "interface IFoo {"
2098 " void foo(in String[] str);"
2099 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002100 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002101 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002102 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002103 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002104}
2105
Daniel Norman85aed542019-08-21 12:01:14 -07002106TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002107 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002108 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2109 "package p;"
2110 "interface IFoo {"
2111 " void foo(in String[] str);"
2112 " void bar(@utf8InCpp String str);"
2113 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002114 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2115 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002116 "interface IFoo2 {"
2117 " void foo(in String[] str);"
2118 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002119 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002120 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002121 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002122 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002123}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002124
Daniel Norman85aed542019-08-21 12:01:14 -07002125TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002126 const string expected_stderr =
2127 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002128 io_delegate_.SetFileContents("old/p/Enum.aidl",
2129 "package p;"
2130 "enum Enum {"
2131 " FOO = 1,"
2132 " BAR = 2,"
2133 "}");
2134 io_delegate_.SetFileContents("new/p/Enum.aidl",
2135 "package p;"
2136 "enum Enum {"
2137 " FOO = 3,"
2138 " BAR = 2,"
2139 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002140 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002141 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002142 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002143}
2144
2145TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002146 const string expected_stderr =
2147 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2148 "from 0 to 1.\n"
2149 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2150 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002151 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2152 "package p;"
2153 "interface IFoo {"
2154 " void foo(in String[] str);"
2155 " void bar(@utf8InCpp String str);"
2156 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002157 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2158 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002159 "interface IFoo {"
2160 " void bar(@utf8InCpp String str);"
2161 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002162 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002163 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002164 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002165 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002166}
2167
2168TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002169 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002170 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2171 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002172 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002173 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002174 "parcelable Data {"
2175 " int foo;"
2176 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002177 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002178 io_delegate_.SetFileContents("new/p/Data.aidl",
2179 "package p;"
2180 "parcelable Data {"
2181 " int bar;"
2182 " int foo;"
2183 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002184 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002185 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002186 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002187}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002188
Daniel Norman85aed542019-08-21 12:01:14 -07002189TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002190 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002191 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002192 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002193 "interface IFoo {"
2194 " void foo(in String[] str);"
2195 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002196 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002197 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2198 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002199 "interface IFoo {"
2200 " void foo(out String[] str);"
2201 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002202 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002203 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002204 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002205 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002206}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002207
Daniel Norman85aed542019-08-21 12:01:14 -07002208TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002209 const string expected_stderr =
2210 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002211 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2212 "package p;"
2213 "interface IFoo {"
2214 " void foo(in String[] str);"
2215 " void bar(@utf8InCpp String str);"
2216 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002217 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2218 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002219 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002220 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002221 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002222 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002223 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002224 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002225 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002226}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002227
Daniel Norman85aed542019-08-21 12:01:14 -07002228TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002229 const string expected_stderr =
2230 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002231 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2232 "package p;"
2233 "interface IFoo {"
2234 " void foo(in String[] str);"
2235 " void bar(@utf8InCpp String str);"
2236 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002237 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2238 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002239 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002240 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002241 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002242 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002243 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002244 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002245 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002246}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002247
Devin Mooredb7ac512020-08-07 11:17:36 -07002248TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2249 const string expected_stderr =
2250 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2251 io_delegate_.SetFileContents("old/p/Foo.aidl",
2252 "package p;"
2253 "parcelable Foo {"
2254 " int A;"
2255 "}");
2256 io_delegate_.SetFileContents("new/p/Foo.aidl",
2257 "package p;"
2258 "@JavaOnlyStableParcelable parcelable Foo {"
2259 " int A;"
2260 "}");
2261 CaptureStderr();
2262 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2264}
2265
2266TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2267 const string expected_stderr =
2268 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2269 io_delegate_.SetFileContents("old/p/Foo.aidl",
2270 "package p;"
2271 "@JavaOnlyStableParcelable parcelable Foo {"
2272 " int A;"
2273 "}");
2274 io_delegate_.SetFileContents("new/p/Foo.aidl",
2275 "package p;"
2276 "parcelable Foo {"
2277 " int A;"
2278 "}");
2279 CaptureStderr();
2280 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2281 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2282}
2283
Daniel Norman85aed542019-08-21 12:01:14 -07002284TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002285 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002286 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2287 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002288 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002289 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002290 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002292}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002293
Daniel Norman85aed542019-08-21 12:01:14 -07002294TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002295 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002296 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2297 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002298 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002299 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002300 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002301}
Jiyong Parka428d212018-08-29 22:26:30 +09002302
Daniel Norman85aed542019-08-21 12:01:14 -07002303TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002304 const string expected_stderr =
2305 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002306 io_delegate_.SetFileContents("old/p/I.aidl",
2307 "package p; interface I {"
2308 "const int A = 1; const int B = 2;}");
2309 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002310 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002311 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002312 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002313}
Jiyong Parka428d212018-08-29 22:26:30 +09002314
Daniel Norman85aed542019-08-21 12:01:14 -07002315TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002316 const string expected_stderr =
2317 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002318 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2319 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002320 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002321 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002323}
2324
Devin Moorec7e47a32020-08-07 10:55:25 -07002325TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2326 const string expected_stderr =
2327 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2328 "This is an incompatible change for FixedSize types.\n";
2329 io_delegate_.SetFileContents("old/p/Foo.aidl",
2330 "package p; @FixedSize parcelable Foo { int A = 1; }");
2331 io_delegate_.SetFileContents("new/p/Foo.aidl",
2332 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2333 CaptureStderr();
2334 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2335 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2336}
2337
2338TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2339 const string expected_stderr =
2340 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2341 io_delegate_.SetFileContents("old/p/Foo.aidl",
2342 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2343 io_delegate_.SetFileContents("new/p/Foo.aidl",
2344 "package p; @FixedSize parcelable Foo { int A = 1; }");
2345 CaptureStderr();
2346 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2348}
2349
2350TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2351 const string expected_stderr =
2352 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2353 "a.\n"
2354 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2355 "b.\n"
2356 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2357 "c.\n"
2358 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2359 "d.\n"
2360 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2361 "e.\n"
2362 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2363 "f.\n";
2364
2365 io_delegate_.SetFileContents("Foo.aidl",
2366 "@FixedSize parcelable Foo { "
2367 " int[] a;"
2368 " Bar b;"
2369 " String c;"
2370 " ParcelFileDescriptor d;"
2371 " IBinder e;"
2372 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002373 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002374 "}");
2375 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2376 Options options =
2377 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2378
2379 CaptureStderr();
2380 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2382}
2383
2384TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2385 const string expected_stderr = "";
2386
2387 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2388 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2389 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2390 Options options =
2391 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2392
2393 CaptureStderr();
2394 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2395 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2396}
2397
Jiyong Park8c380532018-08-30 14:55:26 +09002398TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002399 const string expected_stderr =
2400 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2401 "dir1/q/IBar.aidl\n"
2402 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002403 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002404 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2405 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2406 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2407 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2408
Devin Moore097a3ab2020-03-11 16:08:44 -07002409 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002410 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002411 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002412}
2413
Jiyong Parked65bf42018-08-28 15:43:27 +09002414TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002415 const string expected_stderr =
2416 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2417 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002418 Options options = Options::From("aidl --checkapi old new");
2419 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2420 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002421
2422 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2423
Jiyong Parke59c3682018-09-11 23:10:25 +09002424 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002425 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002426 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002427 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002428}
2429
Jiyong Parke05195e2018-10-08 18:24:23 +09002430TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2431 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2432 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002433 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002434
2435 // use without import
2436 io_delegate_.SetFileContents("p/IFoo.aidl",
2437 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2438 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2439 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002440 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002441
Devin Moore7b8d5c92020-03-17 14:14:08 -07002442 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002443 io_delegate_.SetFileContents(
2444 "p/IFoo.aidl",
2445 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2446 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2447 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002448 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002449
2450 // use with import (as before)
2451 io_delegate_.SetFileContents("p/IFoo.aidl",
2452 "package p;"
2453 "import android.os.ParcelFileDescriptor;"
2454 "interface IFoo{"
2455 " void foo(in ParcelFileDescriptor fd);"
2456 "}");
2457 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2458 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002459 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002460}
Jiyong Parked65bf42018-08-28 15:43:27 +09002461
Jiyong Park3633b722019-04-11 15:38:26 +09002462TEST_F(AidlTest, ManualIds) {
2463 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2464 io_delegate_.SetFileContents("IFoo.aidl",
2465 "interface IFoo {\n"
2466 " void foo() = 0;\n"
2467 " void bar() = 1;\n"
2468 "}");
2469 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2470}
2471
2472TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2473 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2474 io_delegate_.SetFileContents("IFoo.aidl",
2475 "interface IFoo {\n"
2476 " void foo() = 0;\n"
2477 " void bar() = 1;\n"
2478 "}");
2479 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2480}
2481
2482TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002483 const string expected_stderr =
2484 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002485 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2486 io_delegate_.SetFileContents("IFoo.aidl",
2487 "interface IFoo {\n"
2488 " void foo() = 3;\n"
2489 " void bar() = 3;\n"
2490 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002491 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002492 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002493 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002494}
2495
2496TEST_F(AidlTest, FailOnOutOfRangeIds) {
2497 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002498 const string expected_stderr =
2499 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2500 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002501 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2502 io_delegate_.SetFileContents("IFoo.aidl",
2503 "interface IFoo {\n"
2504 " void foo() = 3;\n"
2505 " void bar() = 16777115;\n"
2506 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002507 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002508 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002509 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002510}
2511
2512TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002513 const string expected_stderr =
2514 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002515 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2516 io_delegate_.SetFileContents("IFoo.aidl",
2517 "interface IFoo {\n"
2518 " void foo() = 3;\n"
2519 " void bar();\n"
2520 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002521 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002522 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002523 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002524}
2525
Jiyong Parkc6816252019-07-08 08:12:28 +09002526TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2527 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2528 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2529 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2530 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2531}
2532
2533TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002534 const string expected_stderr =
2535 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2536 "dir/IBar.aidl\n"
2537 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002538 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002539
Jiyong Parkc6816252019-07-08 08:12:28 +09002540 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2541 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2542 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2543 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002544 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002545 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002546 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002547}
2548
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002549TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2550 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2551 "package a.b;\n"
2552 "import a.b.IBar;\n"
2553 "import a.b.IQux;\n"
2554 "interface IFoo { IQux foo(); }\n");
2555 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2556 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2557
2558 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2559 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2560
2561 string output;
2562 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2563 // IBar was imported but wasn't used. include is not expected.
2564 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2565 // IBar was imported and used. include is expected.
2566 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2567}
2568
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002569TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002570 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002571 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002572 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2573 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002574 interface IFoo {
2575 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002576 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002577 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002578 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002579 // JavaPassthrough should work with other types as well (e.g. enum)
2580 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2581 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2582 @JavaPassthrough(annotation="@com.android.AliceTwo")
2583 @Backing(type="byte")
2584 enum MyEnum {
2585 a, b, c
2586 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002587
Jooyung Han4cde01d2020-10-13 11:10:47 +09002588 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002589 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2590
2591 string java_out;
2592 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002593 // type-decl-level annotations with newline at the end
2594 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2595 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2596 // member-decl-level annotations with newline at the end
2597 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2598 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2599 // inline annotations with space at the end
2600 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002601
Jooyung Han4cde01d2020-10-13 11:10:47 +09002602 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2603 // type-decl-level annotations with newline at the end
2604 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2605 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2606
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002607 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002608 Options cpp_options =
2609 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002610 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2611
Jooyung Han4cde01d2020-10-13 11:10:47 +09002612 Options ndk_options =
2613 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002614 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002615
Jooyung Han4cde01d2020-10-13 11:10:47 +09002616 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002617 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002618}
2619
Andrei Homescue61feb52020-08-18 15:44:24 -07002620TEST_F(AidlTest, ParseRustDerive) {
2621 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2622 @RustDerive(Clone=true, Copy=false)
2623 parcelable Foo {
2624 int a;
2625 })");
2626
2627 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2628 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2629
2630 string rust_out;
2631 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2632 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2633
2634 // Other backends shouldn't be bothered
2635 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2636 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2637
2638 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2639 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2640
2641 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2642 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2643}
2644
Jiyong Park56f73d72019-06-11 12:20:28 +09002645class AidlOutputPathTest : public AidlTest {
2646 protected:
2647 void SetUp() override {
2648 AidlTest::SetUp();
2649 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2650 }
2651
2652 void Test(const Options& options, const std::string expected_output_path) {
2653 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2654 // check the existence
2655 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2656 }
2657};
2658
2659TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2660 // <out_dir> / <package_name> / <type_name>.java
2661 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2662}
2663
2664TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2665 // when output file is explicitly set, it is always respected. -o option is
2666 // ignored.
2667 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2668}
2669
2670TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2671 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2672}
2673
2674TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2675 // output is the same as the input file except for the suffix
2676 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2677}
2678
Devin Moore7b8d5c92020-03-17 14:14:08 -07002679TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002680 AidlError error;
2681 const string expected_stderr =
2682 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2683 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002684 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2685 R"(package p;
2686 interface IFoo {
2687 const int int32_max_oob = 2147483650;
2688 }
2689 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002690 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002691 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2692 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002693}
2694
Devin Moore7b8d5c92020-03-17 14:14:08 -07002695TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002696 AidlError error;
2697 const string expected_stderr =
2698 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2699 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002700 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2701 R"(package p;
2702 interface IFoo {
2703 const int int32_min_oob = -2147483650;
2704 }
2705 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002706 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002707 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2708 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002709}
2710
Devin Moore7b8d5c92020-03-17 14:14:08 -07002711TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002712 AidlError error;
2713 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002714 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002715 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002716 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2717 R"(package p;
2718 interface IFoo {
2719 const long int64_max_oob = 21474836509999999999999999;
2720 }
2721 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002722 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002723 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2724 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002725}
2726
Devin Moore7b8d5c92020-03-17 14:14:08 -07002727TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002728 AidlError error;
2729 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002730 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002731 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002732 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2733 R"(package p;
2734 interface IFoo {
2735 const long int64_min_oob = -21474836509999999999999999;
2736 }
2737 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002738 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002739 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2740 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002741}
2742
Devin Moore7b8d5c92020-03-17 14:14:08 -07002743TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002744 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002745 const string expected_stderr =
2746 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2747 "literal: byte\n"
2748 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2749 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002750 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2751 R"(package p;
2752 @Backing(type="byte")
2753 enum TestEnum {
2754 FOO = 127,
2755 BAR,
2756 }
2757 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002758 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002759 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002760 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002761}
2762
Devin Mooredecaf292020-04-30 09:16:40 -07002763TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2764 AidlError error;
2765 const string expected_stderr =
2766 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2767 "be one of: type\n"
2768 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2769 "be one of: type\n";
2770 CaptureStderr();
2771 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2772 R"(package p;
2773 @Backing(foo="byte")
2774 enum TestEnum {
2775 FOO = 1,
2776 BAR,
2777 }
2778 )",
2779 typenames_, GetLanguage(), &error));
2780 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2781 EXPECT_EQ(AidlError::BAD_TYPE, error);
2782}
2783
Jooyung Han66813932020-10-23 13:24:44 +09002784TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002785 io_delegate_.SetFileContents("Foo.aidl",
2786 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2787 "Map<String, Baz> d; Bar[] e; }");
2788 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2789 io_delegate_.SetFileContents("Baz.aidl",
2790 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002791 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2792 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2793}
2794
Jooyung Han66813932020-10-23 13:24:44 +09002795TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002796 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002797 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2798 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2799 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2800}
2801
Jooyung Han66813932020-10-23 13:24:44 +09002802TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002803 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002804 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo); }");
2805 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2806 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2807}
2808
Jooyung Han66813932020-10-23 13:24:44 +09002809TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002810 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002811 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo); }");
2812 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2813 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2814}
2815
Jooyung Han66813932020-10-23 13:24:44 +09002816TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002817 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002818 Options options = Options::From("aidl --lang=java Foo.aidl");
2819 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002820 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002821 "capitalizing the first letter\n";
2822 CaptureStderr();
2823 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2824 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2825}
Devin Moore53fc99c2020-08-12 08:07:52 -07002826
Jooyung Han1f14ab32020-10-14 13:48:29 +09002827const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2828
2829#include <a/ByteEnum.h>
2830#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09002831#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002832#include <binder/Status.h>
2833#include <cstdint>
Jooyung Han3df81ae2020-10-17 17:59:59 +09002834#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002835#include <utility>
2836#include <variant>
2837#include <vector>
2838
2839namespace a {
2840
2841class Foo : public ::android::Parcelable {
2842public:
Jooyung Han97945de2020-10-15 16:41:38 +09002843 inline bool operator!=(const Foo& rhs) const {
2844 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002845 }
Jooyung Han97945de2020-10-15 16:41:38 +09002846 inline bool operator<(const Foo& rhs) const {
2847 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002848 }
Jooyung Han97945de2020-10-15 16:41:38 +09002849 inline bool operator<=(const Foo& rhs) const {
2850 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002851 }
Jooyung Han97945de2020-10-15 16:41:38 +09002852 inline bool operator==(const Foo& rhs) const {
2853 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002854 }
Jooyung Han97945de2020-10-15 16:41:38 +09002855 inline bool operator>(const Foo& rhs) const {
2856 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002857 }
Jooyung Han97945de2020-10-15 16:41:38 +09002858 inline bool operator>=(const Foo& rhs) const {
2859 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002860 }
Jooyung Han97945de2020-10-15 16:41:38 +09002861
Jooyung Han1f14ab32020-10-14 13:48:29 +09002862 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09002863 ns = 0, // int[] ns;
2864 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002865 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002866 };
Jooyung Han97945de2020-10-15 16:41:38 +09002867
Jooyung Han1f14ab32020-10-14 13:48:29 +09002868 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09002869 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002870
2871 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09002872 Foo(const Foo&) = default;
2873 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002874 Foo& operator=(const Foo&) = default;
2875 Foo& operator=(Foo&&) = default;
2876
Jooyung Han97945de2020-10-15 16:41:38 +09002877 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
2878 constexpr Foo(_Tp&& _arg)
2879 : _value(std::forward<_Tp>(_arg)) {}
2880
2881 template <typename... _Tp>
2882 constexpr explicit Foo(_Tp&&... _args)
2883 : _value(std::forward<_Tp>(_args)...) {}
2884
2885 template <Tag _tag, typename... _Tp>
2886 static Foo make(_Tp&&... _args) {
2887 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002888 }
Jooyung Han97945de2020-10-15 16:41:38 +09002889
2890 template <Tag _tag, typename _Tp, typename... _Up>
2891 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
2892 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002893 }
2894
2895 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002896 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002897 }
2898
Jooyung Han97945de2020-10-15 16:41:38 +09002899 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002900 const auto& get() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002901 if (getTag() != _tag) { abort(); }
2902 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002903 }
2904
Jooyung Han97945de2020-10-15 16:41:38 +09002905 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002906 auto& get() {
Jooyung Han97945de2020-10-15 16:41:38 +09002907 if (getTag() != _tag) { abort(); }
2908 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002909 }
2910
Jooyung Han97945de2020-10-15 16:41:38 +09002911 template <Tag _tag, typename... _Tp>
2912 void set(_Tp&&... _args) {
2913 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002914 }
2915
2916 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
2917 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
2918 static const std::string& getParcelableDescriptor() {
2919 static const std::string DESCIPTOR = "a.Foo";
2920 return DESCIPTOR;
2921 }
2922private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09002923 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002924}; // class Foo
2925
2926} // namespace a
2927)";
2928
2929const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
2930
2931namespace a {
2932
2933::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
2934 ::android::status_t _aidl_ret_status;
2935 int32_t _aidl_tag;
2936 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
2937 switch (_aidl_tag) {
2938 case ns: {
2939 ::std::vector<int32_t> _aidl_value;
2940 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2941 set<ns>(std::move(_aidl_value));
2942 return ::android::OK; }
2943 case e: {
2944 ::a::ByteEnum _aidl_value;
2945 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
2946 set<e>(std::move(_aidl_value));
2947 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09002948 case pfd: {
2949 ::android::os::ParcelFileDescriptor _aidl_value;
2950 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2951 set<pfd>(std::move(_aidl_value));
2952 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09002953 }
2954 return ::android::BAD_VALUE;
2955}
2956
2957::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
2958 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
2959 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
2960 switch (getTag()) {
2961 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
2962 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09002963 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002964 }
2965 abort();
2966}
2967
2968} // namespace a
2969)";
2970
Jooyung Han6beac042020-10-17 21:59:43 +09002971const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
2972#include <android/binder_interface_utils.h>
2973#include <android/binder_parcelable_utils.h>
2974
2975#include <type_traits>
2976#include <utility>
2977#include <variant>
2978#include <cstdint>
2979#include <memory>
2980#include <optional>
2981#include <string>
2982#include <vector>
2983#ifdef BINDER_STABILITY_SUPPORT
2984#include <android/binder_stability.h>
2985#endif // BINDER_STABILITY_SUPPORT
2986#include <aidl/a/ByteEnum.h>
2987namespace aidl {
2988namespace a {
2989class Foo {
2990public:
2991 typedef std::false_type fixed_size;
2992 static const char* descriptor;
2993
2994 enum Tag : int32_t {
2995 ns = 0, // int[] ns;
2996 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002997 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09002998 };
2999
3000 template<typename _Tp>
3001 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3002
3003 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3004 Foo(const Foo&) = default;
3005 Foo(Foo&&) = default;
3006 Foo& operator=(const Foo&) = default;
3007 Foo& operator=(Foo&&) = default;
3008
3009 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
3010 constexpr Foo(_Tp&& _arg)
3011 : _value(std::forward<_Tp>(_arg)) {}
3012
3013 template <typename... _Tp>
3014 constexpr explicit Foo(_Tp&&... _args)
3015 : _value(std::forward<_Tp>(_args)...) {}
3016
3017 template <Tag _tag, typename... _Tp>
3018 static Foo make(_Tp&&... _args) {
3019 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3020 }
3021
3022 template <Tag _tag, typename _Tp, typename... _Up>
3023 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3024 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3025 }
3026
3027 Tag getTag() const {
3028 return static_cast<Tag>(_value.index());
3029 }
3030
3031 template <Tag _tag>
3032 const auto& get() const {
3033 if (getTag() != _tag) { abort(); }
3034 return std::get<_tag>(_value);
3035 }
3036
3037 template <Tag _tag>
3038 auto& get() {
3039 if (getTag() != _tag) { abort(); }
3040 return std::get<_tag>(_value);
3041 }
3042
3043 template <Tag _tag, typename... _Tp>
3044 void set(_Tp&&... _args) {
3045 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3046 }
3047
3048 binder_status_t readFromParcel(const AParcel* _parcel);
3049 binder_status_t writeToParcel(AParcel* _parcel) const;
3050 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
3051private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003052 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003053};
3054} // namespace a
3055} // namespace aidl
3056)";
3057
3058const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3059
3060#include <android/binder_parcel_utils.h>
3061
3062namespace aidl {
3063namespace a {
3064const char* Foo::descriptor = "a.Foo";
3065
3066binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3067 binder_status_t _aidl_ret_status;
3068 int32_t _aidl_tag;
3069 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3070 switch (_aidl_tag) {
3071 case ns: {
3072 std::vector<int32_t> _aidl_value;
3073 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3074 set<ns>(std::move(_aidl_value));
3075 return STATUS_OK; }
3076 case e: {
3077 ::aidl::a::ByteEnum _aidl_value;
3078 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
3079 set<e>(std::move(_aidl_value));
3080 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003081 case pfd: {
3082 ::ndk::ScopedFileDescriptor _aidl_value;
3083 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3084 set<pfd>(std::move(_aidl_value));
3085 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003086 }
3087 return STATUS_BAD_VALUE;
3088}
3089binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3090 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3091 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3092 switch (getTag()) {
3093 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3094 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003095 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003096 }
3097 abort();
3098}
3099
3100} // namespace a
3101} // namespace aidl
3102)";
3103
Jooyung Han1f14ab32020-10-14 13:48:29 +09003104const char kUnionExampleExpectedOutputJava[] = R"(/*
3105 * This file is auto-generated. DO NOT MODIFY.
3106 */
3107package a;
3108
3109
3110public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003111 // tags for union fields
3112 public final static int ns = 0; // int[] ns;
3113 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003114 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003115
3116 private int _tag;
3117 private Object _value;
3118
3119 public Foo() {
3120 int[] value = {42};
3121 _set(ns, value);
3122 }
Jooyung Han97945de2020-10-15 16:41:38 +09003123
Jooyung Han1f14ab32020-10-14 13:48:29 +09003124 private Foo(android.os.Parcel _aidl_parcel) {
3125 readFromParcel(_aidl_parcel);
3126 }
Jooyung Han97945de2020-10-15 16:41:38 +09003127
Jooyung Han1f14ab32020-10-14 13:48:29 +09003128 private Foo(int tag, Object value) {
3129 _set(tag, value);
3130 }
3131
3132 public int getTag() {
3133 return _tag;
3134 }
3135
Jooyung Han97945de2020-10-15 16:41:38 +09003136 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003137
3138 public static Foo ns(int[] _value) {
3139 return new Foo(ns, _value);
3140 }
Jooyung Han97945de2020-10-15 16:41:38 +09003141
Jooyung Han1f14ab32020-10-14 13:48:29 +09003142 public int[] getNs() {
3143 _assertTag(ns);
3144 return (int[]) _value;
3145 }
Jooyung Han97945de2020-10-15 16:41:38 +09003146
Jooyung Han1f14ab32020-10-14 13:48:29 +09003147 public void setNs(int[] _value) {
3148 _set(ns, _value);
3149 }
3150
Jooyung Han97945de2020-10-15 16:41:38 +09003151 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003152
3153 public static Foo e(byte _value) {
3154 return new Foo(e, _value);
3155 }
Jooyung Han97945de2020-10-15 16:41:38 +09003156
Jooyung Han1f14ab32020-10-14 13:48:29 +09003157 public byte getE() {
3158 _assertTag(e);
3159 return (byte) _value;
3160 }
Jooyung Han97945de2020-10-15 16:41:38 +09003161
Jooyung Han1f14ab32020-10-14 13:48:29 +09003162 public void setE(byte _value) {
3163 _set(e, _value);
3164 }
3165
Jooyung Hand2fa0232020-10-19 02:51:41 +09003166 // ParcelFileDescriptor pfd;
3167
3168 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3169 return new Foo(pfd, _value);
3170 }
3171
3172 public android.os.ParcelFileDescriptor getPfd() {
3173 _assertTag(pfd);
3174 return (android.os.ParcelFileDescriptor) _value;
3175 }
3176
3177 public void setPfd(android.os.ParcelFileDescriptor _value) {
3178 _set(pfd, _value);
3179 }
3180
Jooyung Han1f14ab32020-10-14 13:48:29 +09003181 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3182 @Override
3183 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003184 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003185 }
3186 @Override
3187 public Foo[] newArray(int _aidl_size) {
3188 return new Foo[_aidl_size];
3189 }
3190 };
Jooyung Han97945de2020-10-15 16:41:38 +09003191
Jooyung Han1f14ab32020-10-14 13:48:29 +09003192 @Override
3193 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3194 _aidl_parcel.writeInt(_tag);
3195 switch (_tag) {
3196 case ns:
3197 _aidl_parcel.writeIntArray(getNs());
3198 break;
3199 case e:
3200 _aidl_parcel.writeByte(getE());
3201 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003202 case pfd:
3203 if ((getPfd()!=null)) {
3204 _aidl_parcel.writeInt(1);
3205 getPfd().writeToParcel(_aidl_parcel, 0);
3206 }
3207 else {
3208 _aidl_parcel.writeInt(0);
3209 }
3210 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003211 }
3212 }
Jooyung Han97945de2020-10-15 16:41:38 +09003213
Jooyung Han1f14ab32020-10-14 13:48:29 +09003214 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3215 int _aidl_tag;
3216 _aidl_tag = _aidl_parcel.readInt();
3217 switch (_aidl_tag) {
3218 case ns: {
3219 int[] _aidl_value;
3220 _aidl_value = _aidl_parcel.createIntArray();
3221 _set(_aidl_tag, _aidl_value);
3222 return; }
3223 case e: {
3224 byte _aidl_value;
3225 _aidl_value = _aidl_parcel.readByte();
3226 _set(_aidl_tag, _aidl_value);
3227 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003228 case pfd: {
3229 android.os.ParcelFileDescriptor _aidl_value;
3230 if ((0!=_aidl_parcel.readInt())) {
3231 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3232 }
3233 else {
3234 _aidl_value = null;
3235 }
3236 _set(_aidl_tag, _aidl_value);
3237 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003238 }
3239 throw new RuntimeException("union: out of range: " + _aidl_tag);
3240 }
Jooyung Han97945de2020-10-15 16:41:38 +09003241
Jooyung Han1f14ab32020-10-14 13:48:29 +09003242 @Override
3243 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003244 int _mask = 0;
3245 switch (getTag()) {
3246 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003247 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003248 break;
3249 }
3250 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003251 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003252 private int describeContents(Object _v) {
3253 if (_v == null) return 0;
3254 if (_v instanceof android.os.Parcelable) {
3255 return ((android.os.Parcelable) _v).describeContents();
3256 }
3257 return 0;
3258 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003259
3260 private void _assertTag(int tag) {
3261 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003262 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003263 }
3264 }
Jooyung Han97945de2020-10-15 16:41:38 +09003265
Jooyung Han1f14ab32020-10-14 13:48:29 +09003266 private String _tagString(int _tag) {
3267 switch (_tag) {
3268 case ns: return "ns";
3269 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003270 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003271 }
3272 throw new IllegalStateException("unknown field: " + _tag);
3273 }
Jooyung Han97945de2020-10-15 16:41:38 +09003274
Jooyung Han1f14ab32020-10-14 13:48:29 +09003275 private void _set(int tag, Object value) {
3276 this._tag = tag;
3277 this._value = value;
3278 }
3279}
3280)";
3281
Jooyung Han97945de2020-10-15 16:41:38 +09003282struct AidlUnionTest : ::testing::Test {
3283 void SetUp() override {
3284 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003285package a;
3286import a.ByteEnum;
3287union Foo {
3288 int[] ns = {42};
3289 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003290 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003291}
3292)");
Jooyung Han97945de2020-10-15 16:41:38 +09003293 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003294package a;
3295@Backing(type="byte")
3296enum ByteEnum {
3297 a, b, c
3298}
3299)");
Jooyung Han97945de2020-10-15 16:41:38 +09003300 }
3301 FakeIoDelegate io_delegate_;
3302 void Compile(string lang) {
3303 string command = "aidl --structured -I. -o out --lang=" + lang;
3304 if (lang == "cpp" || lang == "ndk") {
3305 command += " -h out";
3306 }
3307 command += " a/Foo.aidl";
3308 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003309 CaptureStderr();
3310 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3311 auto err = GetCapturedStderr();
3312 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003313 }
3314 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3315 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003316 string actual;
3317 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3318 EXPECT_EQ(expected, actual);
3319 }
Jooyung Han97945de2020-10-15 16:41:38 +09003320 }
3321};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003322
Jooyung Han97945de2020-10-15 16:41:38 +09003323TEST_F(AidlUnionTest, Example_Cpp) {
3324 Compile("cpp");
3325 EXPECT_COMPILE_OUTPUTS(
3326 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3327 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3328}
3329
Jooyung Han6beac042020-10-17 21:59:43 +09003330TEST_F(AidlUnionTest, Example_Ndk) {
3331 Compile("ndk");
3332 EXPECT_COMPILE_OUTPUTS(
3333 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3334 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3335}
3336
Jooyung Han97945de2020-10-15 16:41:38 +09003337TEST_F(AidlUnionTest, Example_Java) {
3338 Compile("java");
3339 EXPECT_COMPILE_OUTPUTS(
3340 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003341 // TODO(b/170689477) Rust
3342}
3343
Jooyung Hanfe89f122020-10-14 03:49:18 +09003344TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3345 const string method = "package a; union Foo {}";
3346 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3347 CaptureStderr();
3348 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3349 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3350}
3351
3352TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3353 const string method = "package a; union Foo { ParcelableHolder x; }";
3354 const string expected_stderr =
3355 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3356 CaptureStderr();
3357 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3358 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3359}
3360
Devin Moore53fc99c2020-08-12 08:07:52 -07003361TEST_P(AidlTest, GenericStructuredParcelable) {
3362 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3363 Options options =
3364 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3365 const string expected_stderr = "";
3366 CaptureStderr();
3367 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3368 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3369}
3370
Jooyung Han14004ed2020-10-16 03:49:57 +09003371struct GenericAidlTest : ::testing::Test {
3372 FakeIoDelegate io_delegate_;
3373 void Compile(string cmd) {
3374 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux> > x; }");
3375 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3376 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3377 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3378
3379 Options options = Options::From(cmd);
3380 CaptureStderr();
3381 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3382 EXPECT_EQ("", GetCapturedStderr());
3383 }
3384};
3385
3386TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3387 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3388 string code;
3389 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3390 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3391 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3392 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3393}
3394
3395TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3396 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3397 string code;
3398 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3399 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3400 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3401 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3402}
3403
Devin Moore53fc99c2020-08-12 08:07:52 -07003404TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3405 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3406 Options options =
3407 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3408 const string expected_stderr =
3409 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3410 CaptureStderr();
3411 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3412 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3413}
3414
3415TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3416 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3417 Options options =
3418 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3419 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3420 CaptureStderr();
3421 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3422 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3423}
3424
Jooyung Hanea2147c2020-10-21 18:16:56 +09003425constexpr char kDescriptContentsWithUntypedListMapInJava[] = R"(
3426 @Override
3427 public int describeContents() {
3428 int _mask = 0;
3429 _mask |= describeContents(l);
3430 _mask |= describeContents(m);
3431 return _mask;
3432 }
3433 private int describeContents(Object _v) {
3434 if (_v == null) return 0;
3435 Class<?> _clazz = _v.getClass();
3436 if (_clazz.isArray() && _clazz.getComponentType() == Object.class) {
3437 int _mask = 0;
3438 for (Object o : (Object[]) _v) {
3439 _mask |= describeContents(o);
3440 }
3441 return _mask;
3442 }
3443 if (_v instanceof java.io.FileDescriptor) {
3444 return android.os.Parcelable.CONTENTS_FILE_DESCRIPTOR;
3445 }
3446 if (_v instanceof java.util.Collection) {
3447 int _mask = 0;
3448 for (Object o : (java.util.Collection) _v) {
3449 _mask |= describeContents(o);
3450 }
3451 return _mask;
3452 }
3453 if (_v instanceof java.util.Map) {
3454 return describeContents(((java.util.Map) _v).values());
3455 }
3456 if (_v instanceof android.os.Parcelable) {
3457 return ((android.os.Parcelable) _v).describeContents();
3458 }
3459 if (_v instanceof android.util.SparseArray) {
3460 android.util.SparseArray _sa = (android.util.SparseArray) _v;
3461 int _mask = 0;
3462 int _N = _sa.size();
3463 int _i = 0;
3464 while (_i < _N) {
3465 _mask |= describeContents(_sa.valueAt(_i));
3466 _i++;
3467 }
3468 return _mask;
3469 }
3470 return 0;
3471 }
3472)";
3473TEST_F(AidlTest, SupportUntypeListAndMap) {
3474 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3475 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3476 CaptureStderr();
3477 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3478 EXPECT_EQ("", GetCapturedStderr());
3479
3480 string code;
3481 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
3482 EXPECT_THAT(code, testing::HasSubstr(kDescriptContentsWithUntypedListMapInJava));
3483}
3484
Christopher Wiley90be4e32015-10-20 14:55:25 -07003485} // namespace aidl
3486} // namespace android