blob: c3b7d4cf50cc8b55c43dc13bf7f70fae61cd5ce1 [file] [log] [blame]
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001//
Geoff Langcec35902014-04-16 10:52:36 -04002// Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved.
Geoff Lange8ebe7f2013-08-05 15:03:13 -04003// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6
7// validationES.h: Validation functions for generic OpenGL ES entry point parameters
8
Geoff Lang2b5420c2014-11-19 14:20:15 -05009#include "libANGLE/validationES.h"
Jamie Madille2e406c2016-06-02 13:04:10 -040010
Geoff Lang2b5420c2014-11-19 14:20:15 -050011#include "libANGLE/Context.h"
Geoff Langa8406172015-07-21 16:53:39 -040012#include "libANGLE/Display.h"
Brandon Jones6cad5662017-06-14 13:25:13 -070013#include "libANGLE/ErrorStrings.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050014#include "libANGLE/Framebuffer.h"
15#include "libANGLE/FramebufferAttachment.h"
Geoff Langa8406172015-07-21 16:53:39 -040016#include "libANGLE/Image.h"
Geoff Lang7dd2e102014-11-10 15:19:26 -050017#include "libANGLE/Program.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040018#include "libANGLE/Query.h"
19#include "libANGLE/Texture.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050020#include "libANGLE/TransformFeedback.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040021#include "libANGLE/Uniform.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050022#include "libANGLE/VertexArray.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040023#include "libANGLE/formatutils.h"
24#include "libANGLE/validationES2.h"
25#include "libANGLE/validationES3.h"
Geoff Lange8ebe7f2013-08-05 15:03:13 -040026
27#include "common/mathutil.h"
28#include "common/utilities.h"
29
Jamie Madille2e406c2016-06-02 13:04:10 -040030using namespace angle;
31
Geoff Lange8ebe7f2013-08-05 15:03:13 -040032namespace gl
33{
Jamie Madill1ca74672015-07-21 15:14:11 -040034namespace
35{
Corentin Wallez92db6942016-12-09 13:10:36 -050036bool ValidateDrawAttribs(ValidationContext *context,
37 GLint primcount,
38 GLint maxVertex,
39 GLint vertexCount)
Jamie Madill1ca74672015-07-21 15:14:11 -040040{
Jamie Madilldfde6ab2016-06-09 07:07:18 -070041 const gl::State &state = context->getGLState();
Jamie Madill1ca74672015-07-21 15:14:11 -040042 const gl::Program *program = state.getProgram();
43
Corentin Wallez327411e2016-12-09 11:09:17 -050044 bool webglCompatibility = context->getExtensions().webglCompatibility;
45
Jamie Madill231c7f52017-04-26 13:45:37 -040046 const VertexArray *vao = state.getVertexArray();
47 const auto &vertexAttribs = vao->getVertexAttributes();
Jiawei-Shao2597fb62016-12-09 16:38:02 +080048 const auto &vertexBindings = vao->getVertexBindings();
Jamie Madill231c7f52017-04-26 13:45:37 -040049 size_t maxEnabledAttrib = vao->getMaxEnabledAttribute();
Jamie Madill1ca74672015-07-21 15:14:11 -040050 for (size_t attributeIndex = 0; attributeIndex < maxEnabledAttrib; ++attributeIndex)
51 {
52 const VertexAttribute &attrib = vertexAttribs[attributeIndex];
Corentin Wallez672f7f32017-06-15 17:42:17 -040053
54 // No need to range check for disabled attribs.
55 if (!attrib.enabled)
Jamie Madill1ca74672015-07-21 15:14:11 -040056 {
Corentin Wallezfd456442016-12-21 17:57:00 -050057 continue;
58 }
Jamie Madill1ca74672015-07-21 15:14:11 -040059
Jamie Madill231c7f52017-04-26 13:45:37 -040060 // If we have no buffer, then we either get an error, or there are no more checks to be
61 // done.
Corentin Wallez672f7f32017-06-15 17:42:17 -040062 const VertexBinding &binding = vertexBindings[attrib.bindingIndex];
63 gl::Buffer *buffer = binding.getBuffer().get();
Corentin Wallezfd456442016-12-21 17:57:00 -050064 if (!buffer)
65 {
Geoff Langfeb8c682017-02-13 16:07:35 -050066 if (webglCompatibility || !state.areClientArraysEnabled())
Corentin Wallez327411e2016-12-09 11:09:17 -050067 {
68 // [WebGL 1.0] Section 6.5 Enabled Vertex Attributes and Range Checking
Corentin Wallezfd456442016-12-21 17:57:00 -050069 // If a vertex attribute is enabled as an array via enableVertexAttribArray but
70 // no buffer is bound to that attribute via bindBuffer and vertexAttribPointer,
71 // then calls to drawArrays or drawElements will generate an INVALID_OPERATION
72 // error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -050073 context->handleError(InvalidOperation()
74 << "An enabled vertex array has no buffer.");
Corentin Wallezfd456442016-12-21 17:57:00 -050075 return false;
Corentin Wallez327411e2016-12-09 11:09:17 -050076 }
Corentin Wallezfd456442016-12-21 17:57:00 -050077 else if (attrib.pointer == nullptr)
Jamie Madill1ca74672015-07-21 15:14:11 -040078 {
79 // This is an application error that would normally result in a crash,
80 // but we catch it and return an error
Yuly Novikovc4d18aa2017-03-09 18:45:02 -050081 context->handleError(InvalidOperation()
82 << "An enabled vertex array has no buffer and no pointer.");
Jamie Madill1ca74672015-07-21 15:14:11 -040083 return false;
84 }
Corentin Wallezfd456442016-12-21 17:57:00 -050085 continue;
86 }
87
Corentin Wallez672f7f32017-06-15 17:42:17 -040088 // This needs to come after the check for client arrays as even unused attributes cannot use
89 // client-side arrays
90 if (!program->isAttribLocationActive(attributeIndex))
91 {
92 continue;
93 }
94
Corentin Wallezfd456442016-12-21 17:57:00 -050095 // If we're drawing zero vertices, we have enough data.
96 if (vertexCount <= 0 || primcount <= 0)
97 {
98 continue;
99 }
100
101 GLint maxVertexElement = 0;
Martin Radevdd5f27e2017-06-07 10:17:09 +0300102 GLuint divisor = binding.getDivisor();
103 if (divisor == 0)
Corentin Wallezfd456442016-12-21 17:57:00 -0500104 {
105 maxVertexElement = maxVertex;
106 }
107 else
108 {
Martin Radevdd5f27e2017-06-07 10:17:09 +0300109 maxVertexElement = (primcount - 1) / divisor;
Corentin Wallezfd456442016-12-21 17:57:00 -0500110 }
111
112 // We do manual overflow checks here instead of using safe_math.h because it was
113 // a bottleneck. Thanks to some properties of GL we know inequalities that can
114 // help us make the overflow checks faster.
115
116 // The max possible attribSize is 16 for a vector of 4 32 bit values.
117 constexpr uint64_t kMaxAttribSize = 16;
118 constexpr uint64_t kIntMax = std::numeric_limits<int>::max();
119 constexpr uint64_t kUint64Max = std::numeric_limits<uint64_t>::max();
120
121 // We know attribStride is given as a GLsizei which is typedefed to int.
122 // We also know an upper bound for attribSize.
123 static_assert(std::is_same<int, GLsizei>::value, "");
Jiawei-Shao2597fb62016-12-09 16:38:02 +0800124 uint64_t attribStride = ComputeVertexAttributeStride(attrib, binding);
Corentin Wallezfd456442016-12-21 17:57:00 -0500125 uint64_t attribSize = ComputeVertexAttributeTypeSize(attrib);
126 ASSERT(attribStride <= kIntMax && attribSize <= kMaxAttribSize);
127
128 // Computing the max offset using uint64_t without attrib.offset is overflow
129 // safe. Note: Last vertex element does not take the full stride!
130 static_assert(kIntMax * kIntMax < kUint64Max - kMaxAttribSize, "");
131 uint64_t attribDataSizeNoOffset = maxVertexElement * attribStride + attribSize;
132
133 // An overflow can happen when adding the offset, check for it.
Jiawei-Shao2597fb62016-12-09 16:38:02 +0800134 uint64_t attribOffset = ComputeVertexAttributeOffset(attrib, binding);
135 if (attribDataSizeNoOffset > kUint64Max - attribOffset)
Corentin Wallezfd456442016-12-21 17:57:00 -0500136 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500137 context->handleError(InvalidOperation() << "Integer overflow.");
Corentin Wallezfd456442016-12-21 17:57:00 -0500138 return false;
139 }
140 uint64_t attribDataSizeWithOffset = attribDataSizeNoOffset + attribOffset;
141
142 // [OpenGL ES 3.0.2] section 2.9.4 page 40:
143 // We can return INVALID_OPERATION if our vertex attribute does not have
144 // enough backing data.
145 if (attribDataSizeWithOffset > static_cast<uint64_t>(buffer->getSize()))
146 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500147 context->handleError(InvalidOperation()
148 << "Vertex buffer is not big enough for the draw call");
Corentin Wallezfd456442016-12-21 17:57:00 -0500149 return false;
Jamie Madill1ca74672015-07-21 15:14:11 -0400150 }
151 }
152
153 return true;
154}
155
Geoff Lang280ba992017-04-18 16:30:58 -0400156bool ValidReadPixelsTypeEnum(ValidationContext *context, GLenum type)
157{
158 switch (type)
159 {
160 // Types referenced in Table 3.4 of the ES 2.0.25 spec
161 case GL_UNSIGNED_BYTE:
162 case GL_UNSIGNED_SHORT_4_4_4_4:
163 case GL_UNSIGNED_SHORT_5_5_5_1:
164 case GL_UNSIGNED_SHORT_5_6_5:
165 return context->getClientVersion() >= ES_2_0;
166
167 // Types referenced in Table 3.2 of the ES 3.0.5 spec (Except depth stencil)
168 case GL_BYTE:
169 case GL_INT:
170 case GL_SHORT:
171 case GL_UNSIGNED_INT:
172 case GL_UNSIGNED_INT_10F_11F_11F_REV:
173 case GL_UNSIGNED_INT_24_8:
174 case GL_UNSIGNED_INT_2_10_10_10_REV:
175 case GL_UNSIGNED_INT_5_9_9_9_REV:
176 case GL_UNSIGNED_SHORT:
177 case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT:
178 case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT:
179 return context->getClientVersion() >= ES_3_0;
180
181 case GL_FLOAT:
182 return context->getClientVersion() >= ES_3_0 || context->getExtensions().textureFloat;
183
184 case GL_HALF_FLOAT:
185 return context->getClientVersion() >= ES_3_0 ||
186 context->getExtensions().textureHalfFloat;
187
188 case GL_HALF_FLOAT_OES:
189 return context->getExtensions().colorBufferHalfFloat;
190
191 default:
192 return false;
193 }
194}
195
196bool ValidReadPixelsFormatEnum(ValidationContext *context, GLenum format)
197{
198 switch (format)
199 {
200 // Formats referenced in Table 3.4 of the ES 2.0.25 spec (Except luminance)
201 case GL_RGBA:
202 case GL_RGB:
203 case GL_ALPHA:
204 return context->getClientVersion() >= ES_2_0;
205
206 // Formats referenced in Table 3.2 of the ES 3.0.5 spec
207 case GL_RG:
208 case GL_RED:
209 case GL_RGBA_INTEGER:
210 case GL_RGB_INTEGER:
211 case GL_RG_INTEGER:
212 case GL_RED_INTEGER:
213 return context->getClientVersion() >= ES_3_0;
214
215 case GL_SRGB_ALPHA_EXT:
216 case GL_SRGB_EXT:
217 return context->getExtensions().sRGB;
218
219 case GL_BGRA_EXT:
220 return context->getExtensions().readFormatBGRA;
221
222 default:
223 return false;
224 }
225}
226
Geoff Langf607c602016-09-21 11:46:48 -0400227bool ValidReadPixelsFormatType(ValidationContext *context,
228 GLenum framebufferComponentType,
229 GLenum format,
230 GLenum type)
231{
232 switch (framebufferComponentType)
233 {
234 case GL_UNSIGNED_NORMALIZED:
235 // TODO(geofflang): Don't accept BGRA here. Some chrome internals appear to try to use
236 // ReadPixels with BGRA even if the extension is not present
237 return (format == GL_RGBA && type == GL_UNSIGNED_BYTE) ||
238 (context->getExtensions().readFormatBGRA && format == GL_BGRA_EXT &&
239 type == GL_UNSIGNED_BYTE);
240
241 case GL_SIGNED_NORMALIZED:
242 return (format == GL_RGBA && type == GL_UNSIGNED_BYTE);
243
244 case GL_INT:
245 return (format == GL_RGBA_INTEGER && type == GL_INT);
246
247 case GL_UNSIGNED_INT:
248 return (format == GL_RGBA_INTEGER && type == GL_UNSIGNED_INT);
249
250 case GL_FLOAT:
251 return (format == GL_RGBA && type == GL_FLOAT);
252
253 default:
254 UNREACHABLE();
255 return false;
256 }
257}
258
Geoff Langc1984ed2016-10-07 12:41:00 -0400259template <typename ParamType>
260bool ValidateTextureWrapModeValue(Context *context, ParamType *params, bool isExternalTextureTarget)
261{
262 switch (ConvertToGLenum(params[0]))
263 {
264 case GL_CLAMP_TO_EDGE:
265 break;
266
267 case GL_REPEAT:
268 case GL_MIRRORED_REPEAT:
269 if (isExternalTextureTarget)
270 {
271 // OES_EGL_image_external specifies this error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500272 context->handleError(InvalidEnum()
273 << "external textures only support CLAMP_TO_EDGE wrap mode");
Geoff Langc1984ed2016-10-07 12:41:00 -0400274 return false;
275 }
276 break;
277
278 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500279 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400280 return false;
281 }
282
283 return true;
284}
285
286template <typename ParamType>
287bool ValidateTextureMinFilterValue(Context *context,
288 ParamType *params,
289 bool isExternalTextureTarget)
290{
291 switch (ConvertToGLenum(params[0]))
292 {
293 case GL_NEAREST:
294 case GL_LINEAR:
295 break;
296
297 case GL_NEAREST_MIPMAP_NEAREST:
298 case GL_LINEAR_MIPMAP_NEAREST:
299 case GL_NEAREST_MIPMAP_LINEAR:
300 case GL_LINEAR_MIPMAP_LINEAR:
301 if (isExternalTextureTarget)
302 {
303 // OES_EGL_image_external specifies this error.
304 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500305 InvalidEnum() << "external textures only support NEAREST and LINEAR filtering");
Geoff Langc1984ed2016-10-07 12:41:00 -0400306 return false;
307 }
308 break;
309
310 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700311 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam);
Geoff Langc1984ed2016-10-07 12:41:00 -0400312 return false;
313 }
314
315 return true;
316}
317
318template <typename ParamType>
319bool ValidateTextureMagFilterValue(Context *context, ParamType *params)
320{
321 switch (ConvertToGLenum(params[0]))
322 {
323 case GL_NEAREST:
324 case GL_LINEAR:
325 break;
326
327 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700328 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam);
Geoff Langc1984ed2016-10-07 12:41:00 -0400329 return false;
330 }
331
332 return true;
333}
334
335template <typename ParamType>
336bool ValidateTextureCompareModeValue(Context *context, ParamType *params)
337{
338 // Acceptable mode parameters from GLES 3.0.2 spec, table 3.17
339 switch (ConvertToGLenum(params[0]))
340 {
341 case GL_NONE:
342 case GL_COMPARE_REF_TO_TEXTURE:
343 break;
344
345 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500346 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400347 return false;
348 }
349
350 return true;
351}
352
353template <typename ParamType>
354bool ValidateTextureCompareFuncValue(Context *context, ParamType *params)
355{
356 // Acceptable function parameters from GLES 3.0.2 spec, table 3.17
357 switch (ConvertToGLenum(params[0]))
358 {
359 case GL_LEQUAL:
360 case GL_GEQUAL:
361 case GL_LESS:
362 case GL_GREATER:
363 case GL_EQUAL:
364 case GL_NOTEQUAL:
365 case GL_ALWAYS:
366 case GL_NEVER:
367 break;
368
369 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500370 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400371 return false;
372 }
373
374 return true;
375}
376
377template <typename ParamType>
Geoff Lang81c6b572016-10-19 14:07:52 -0700378bool ValidateTextureSRGBDecodeValue(Context *context, ParamType *params)
379{
380 if (!context->getExtensions().textureSRGBDecode)
381 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700382 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Geoff Lang81c6b572016-10-19 14:07:52 -0700383 return false;
384 }
385
386 switch (ConvertToGLenum(params[0]))
387 {
388 case GL_DECODE_EXT:
389 case GL_SKIP_DECODE_EXT:
390 break;
391
392 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500393 context->handleError(InvalidEnum() << "Unknown param value.");
Geoff Lang81c6b572016-10-19 14:07:52 -0700394 return false;
395 }
396
397 return true;
398}
399
400template <typename ParamType>
Geoff Langc1984ed2016-10-07 12:41:00 -0400401bool ValidateSamplerParameterBase(Context *context,
402 GLuint sampler,
403 GLenum pname,
404 GLsizei bufSize,
405 ParamType *params)
406{
407 if (context->getClientMajorVersion() < 3)
408 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500409 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400410 return false;
411 }
412
413 if (!context->isSampler(sampler))
414 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500415 context->handleError(InvalidOperation() << "Sampler is not valid.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400416 return false;
417 }
418
419 const GLsizei minBufSize = 1;
420 if (bufSize >= 0 && bufSize < minBufSize)
421 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500422 context->handleError(InvalidOperation() << "bufSize must be at least " << minBufSize);
Geoff Langc1984ed2016-10-07 12:41:00 -0400423 return false;
424 }
425
426 switch (pname)
427 {
428 case GL_TEXTURE_WRAP_S:
429 case GL_TEXTURE_WRAP_T:
430 case GL_TEXTURE_WRAP_R:
431 if (!ValidateTextureWrapModeValue(context, params, false))
432 {
433 return false;
434 }
435 break;
436
437 case GL_TEXTURE_MIN_FILTER:
438 if (!ValidateTextureMinFilterValue(context, params, false))
439 {
440 return false;
441 }
442 break;
443
444 case GL_TEXTURE_MAG_FILTER:
445 if (!ValidateTextureMagFilterValue(context, params))
446 {
447 return false;
448 }
449 break;
450
451 case GL_TEXTURE_MIN_LOD:
452 case GL_TEXTURE_MAX_LOD:
453 // any value is permissible
454 break;
455
456 case GL_TEXTURE_COMPARE_MODE:
457 if (!ValidateTextureCompareModeValue(context, params))
458 {
459 return false;
460 }
461 break;
462
463 case GL_TEXTURE_COMPARE_FUNC:
464 if (!ValidateTextureCompareFuncValue(context, params))
465 {
466 return false;
467 }
468 break;
469
Geoff Lang81c6b572016-10-19 14:07:52 -0700470 case GL_TEXTURE_SRGB_DECODE_EXT:
471 if (!ValidateTextureSRGBDecodeValue(context, params))
472 {
473 return false;
474 }
475 break;
476
Geoff Langc1984ed2016-10-07 12:41:00 -0400477 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700478 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langc1984ed2016-10-07 12:41:00 -0400479 return false;
480 }
481
482 return true;
483}
484
485bool ValidateGetSamplerParameterBase(Context *context,
486 GLuint sampler,
487 GLenum pname,
488 GLsizei *length)
489{
490 if (length)
491 {
492 *length = 0;
493 }
494
495 if (context->getClientMajorVersion() < 3)
496 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500497 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400498 return false;
499 }
500
501 if (!context->isSampler(sampler))
502 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500503 context->handleError(InvalidOperation() << "Sampler is not valid.");
Geoff Langc1984ed2016-10-07 12:41:00 -0400504 return false;
505 }
506
507 switch (pname)
508 {
509 case GL_TEXTURE_WRAP_S:
510 case GL_TEXTURE_WRAP_T:
511 case GL_TEXTURE_WRAP_R:
512 case GL_TEXTURE_MIN_FILTER:
513 case GL_TEXTURE_MAG_FILTER:
514 case GL_TEXTURE_MIN_LOD:
515 case GL_TEXTURE_MAX_LOD:
516 case GL_TEXTURE_COMPARE_MODE:
517 case GL_TEXTURE_COMPARE_FUNC:
518 break;
519
Geoff Lang81c6b572016-10-19 14:07:52 -0700520 case GL_TEXTURE_SRGB_DECODE_EXT:
521 if (!context->getExtensions().textureSRGBDecode)
522 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500523 context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled.");
Geoff Lang81c6b572016-10-19 14:07:52 -0700524 return false;
525 }
526 break;
527
Geoff Langc1984ed2016-10-07 12:41:00 -0400528 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700529 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langc1984ed2016-10-07 12:41:00 -0400530 return false;
531 }
532
533 if (length)
534 {
535 *length = 1;
536 }
537 return true;
538}
539
Geoff Lang6899b872016-10-14 11:30:13 -0400540bool ValidateGetActiveUniformBlockivBase(Context *context,
541 GLuint program,
542 GLuint uniformBlockIndex,
543 GLenum pname,
544 GLsizei *length)
545{
546 if (length)
547 {
548 *length = 0;
549 }
550
551 if (context->getClientMajorVersion() < 3)
552 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500553 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Lang6899b872016-10-14 11:30:13 -0400554 return false;
555 }
556
557 Program *programObject = GetValidProgram(context, program);
558 if (!programObject)
559 {
560 return false;
561 }
562
563 if (uniformBlockIndex >= programObject->getActiveUniformBlockCount())
564 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500565 context->handleError(InvalidValue()
566 << "uniformBlockIndex exceeds active uniform block count.");
Geoff Lang6899b872016-10-14 11:30:13 -0400567 return false;
568 }
569
570 switch (pname)
571 {
572 case GL_UNIFORM_BLOCK_BINDING:
573 case GL_UNIFORM_BLOCK_DATA_SIZE:
574 case GL_UNIFORM_BLOCK_NAME_LENGTH:
575 case GL_UNIFORM_BLOCK_ACTIVE_UNIFORMS:
576 case GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES:
577 case GL_UNIFORM_BLOCK_REFERENCED_BY_VERTEX_SHADER:
578 case GL_UNIFORM_BLOCK_REFERENCED_BY_FRAGMENT_SHADER:
579 break;
580
581 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700582 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang6899b872016-10-14 11:30:13 -0400583 return false;
584 }
585
586 if (length)
587 {
588 if (pname == GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES)
589 {
590 const UniformBlock &uniformBlock =
591 programObject->getUniformBlockByIndex(uniformBlockIndex);
jchen10eaef1e52017-06-13 10:44:11 +0800592 *length = static_cast<GLsizei>(uniformBlock.memberIndexes.size());
Geoff Lang6899b872016-10-14 11:30:13 -0400593 }
594 else
595 {
596 *length = 1;
597 }
598 }
599
600 return true;
601}
602
Geoff Lang0a9661f2016-10-20 10:59:20 -0700603bool ValidateGetInternalFormativBase(Context *context,
604 GLenum target,
605 GLenum internalformat,
606 GLenum pname,
607 GLsizei bufSize,
608 GLsizei *numParams)
609{
610 if (numParams)
611 {
612 *numParams = 0;
613 }
614
615 if (context->getClientMajorVersion() < 3)
616 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500617 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Geoff Lang0a9661f2016-10-20 10:59:20 -0700618 return false;
619 }
620
621 const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat);
622 if (!formatCaps.renderable)
623 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500624 context->handleError(InvalidEnum() << "Internal format is not renderable.");
Geoff Lang0a9661f2016-10-20 10:59:20 -0700625 return false;
626 }
627
628 switch (target)
629 {
630 case GL_RENDERBUFFER:
631 break;
632
JiangYizhoubddc46b2016-12-09 09:50:51 +0800633 case GL_TEXTURE_2D_MULTISAMPLE:
634 if (context->getClientVersion() < ES_3_1)
635 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500636 context->handleError(InvalidOperation()
637 << "Texture target requires at least OpenGL ES 3.1.");
JiangYizhoubddc46b2016-12-09 09:50:51 +0800638 return false;
639 }
640 break;
641
Geoff Lang0a9661f2016-10-20 10:59:20 -0700642 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500643 context->handleError(InvalidEnum() << "Invalid target.");
Geoff Lang0a9661f2016-10-20 10:59:20 -0700644 return false;
645 }
646
647 if (bufSize < 0)
648 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700649 ANGLE_VALIDATION_ERR(context, InvalidValue(), InsufficientBufferSize);
Geoff Lang0a9661f2016-10-20 10:59:20 -0700650 return false;
651 }
652
653 GLsizei maxWriteParams = 0;
654 switch (pname)
655 {
656 case GL_NUM_SAMPLE_COUNTS:
657 maxWriteParams = 1;
658 break;
659
660 case GL_SAMPLES:
661 maxWriteParams = static_cast<GLsizei>(formatCaps.sampleCounts.size());
662 break;
663
664 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700665 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang0a9661f2016-10-20 10:59:20 -0700666 return false;
667 }
668
669 if (numParams)
670 {
671 // glGetInternalFormativ will not overflow bufSize
672 *numParams = std::min(bufSize, maxWriteParams);
673 }
674
675 return true;
676}
677
Jamie Madillc1d770e2017-04-13 17:31:24 -0400678bool ValidateUniformCommonBase(ValidationContext *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500679 gl::Program *program,
680 GLint location,
681 GLsizei count,
682 const LinkedUniform **uniformOut)
683{
684 // TODO(Jiajia): Add image uniform check in future.
685 if (count < 0)
686 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700687 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500688 return false;
689 }
690
Brandon Jones6cad5662017-06-14 13:25:13 -0700691 if (!program)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500692 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700693 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidProgramName);
694 return false;
695 }
696
697 if (!program->isLinked())
698 {
699 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500700 return false;
701 }
702
703 if (location == -1)
704 {
705 // Silently ignore the uniform command
706 return false;
707 }
708
709 const auto &uniformLocations = program->getUniformLocations();
Jamie Madillbe849e42017-05-02 15:49:00 -0400710 size_t castedLocation = static_cast<size_t>(location);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500711 if (castedLocation >= uniformLocations.size())
712 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500713 context->handleError(InvalidOperation() << "Invalid uniform location");
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500714 return false;
715 }
716
717 const auto &uniformLocation = uniformLocations[castedLocation];
718 if (uniformLocation.ignored)
719 {
720 // Silently ignore the uniform command
721 return false;
722 }
723
724 if (!uniformLocation.used)
725 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500726 context->handleError(InvalidOperation());
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500727 return false;
728 }
729
730 const auto &uniform = program->getUniformByIndex(uniformLocation.index);
731
732 // attempting to write an array to a non-array uniform is an INVALID_OPERATION
733 if (!uniform.isArray() && count > 1)
734 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500735 context->handleError(InvalidOperation());
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500736 return false;
737 }
738
739 *uniformOut = &uniform;
740 return true;
741}
742
Frank Henigman999b0fd2017-02-02 21:45:55 -0500743bool ValidateUniform1ivValue(ValidationContext *context,
Frank Henigmana98a6472017-02-02 21:38:32 -0500744 GLenum uniformType,
745 GLsizei count,
746 const GLint *value)
747{
748 // Value type is GL_INT, because we only get here from glUniform1i{v}.
749 // It is compatible with INT or BOOL.
750 // Do these cheap tests first, for a little extra speed.
751 if (GL_INT == uniformType || GL_BOOL == uniformType)
752 {
753 return true;
754 }
755
756 if (IsSamplerType(uniformType))
757 {
Frank Henigman999b0fd2017-02-02 21:45:55 -0500758 // Check that the values are in range.
759 const GLint max = context->getCaps().maxCombinedTextureImageUnits;
760 for (GLsizei i = 0; i < count; ++i)
761 {
762 if (value[i] < 0 || value[i] >= max)
763 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500764 context->handleError(InvalidValue() << "sampler uniform value out of range");
Frank Henigman999b0fd2017-02-02 21:45:55 -0500765 return false;
766 }
767 }
Frank Henigmana98a6472017-02-02 21:38:32 -0500768 return true;
769 }
770
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500771 context->handleError(InvalidOperation() << "wrong type of value for uniform");
Frank Henigmana98a6472017-02-02 21:38:32 -0500772 return false;
773}
774
Jamie Madillc1d770e2017-04-13 17:31:24 -0400775bool ValidateUniformValue(ValidationContext *context, GLenum valueType, GLenum uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500776{
777 // Check that the value type is compatible with uniform type.
Frank Henigmana98a6472017-02-02 21:38:32 -0500778 // Do the cheaper test first, for a little extra speed.
779 if (valueType == uniformType || VariableBoolVectorType(valueType) == uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500780 {
781 return true;
782 }
783
Brandon Jones6cad5662017-06-14 13:25:13 -0700784 ANGLE_VALIDATION_ERR(context, InvalidOperation(), UniformSizeDoesNotMatchMethod);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500785 return false;
786}
787
Jamie Madillc1d770e2017-04-13 17:31:24 -0400788bool ValidateUniformMatrixValue(ValidationContext *context, GLenum valueType, GLenum uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500789{
790 // Check that the value type is compatible with uniform type.
791 if (valueType == uniformType)
792 {
793 return true;
794 }
795
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500796 context->handleError(InvalidOperation() << "wrong type of value for uniform");
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500797 return false;
798}
799
Geoff Lange0cff192017-05-30 13:04:56 -0400800bool ValidateFragmentShaderColorBufferTypeMatch(ValidationContext *context)
801{
802 const Program *program = context->getGLState().getProgram();
803 const Framebuffer *framebuffer = context->getGLState().getDrawFramebuffer();
804
805 const auto &programOutputTypes = program->getOutputVariableTypes();
806 for (size_t drawBufferIdx = 0; drawBufferIdx < programOutputTypes.size(); drawBufferIdx++)
807 {
808 GLenum outputType = programOutputTypes[drawBufferIdx];
809 GLenum inputType = framebuffer->getDrawbufferWriteType(drawBufferIdx);
810 if (outputType != GL_NONE && inputType != GL_NONE && inputType != outputType)
811 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500812 context->handleError(InvalidOperation() << "Fragment shader output type does not "
813 "match the bound framebuffer attachment "
814 "type.");
Geoff Lange0cff192017-05-30 13:04:56 -0400815 return false;
816 }
817 }
818
819 return true;
820}
821
Geoff Lang9ab5b822017-05-30 16:19:23 -0400822bool ValidateVertexShaderAttributeTypeMatch(ValidationContext *context)
823{
824 const Program *program = context->getGLState().getProgram();
825 const VertexArray *vao = context->getGLState().getVertexArray();
826
827 for (const auto &shaderAttribute : program->getAttributes())
828 {
Geoff Lang69df2422017-07-05 12:42:31 -0400829 // gl_VertexID and gl_InstanceID are active attributes but don't have a bound attribute.
830 if (shaderAttribute.isBuiltIn())
831 {
832 continue;
833 }
834
Geoff Lang9ab5b822017-05-30 16:19:23 -0400835 GLenum shaderInputType = VariableComponentType(shaderAttribute.type);
836
837 const auto &attrib = vao->getVertexAttribute(shaderAttribute.location);
838 const auto &currentValue =
839 context->getGLState().getVertexAttribCurrentValue(shaderAttribute.location);
840 GLenum vertexType = attrib.enabled ? GetVertexAttributeBaseType(attrib) : currentValue.Type;
841
842 if (shaderInputType != GL_NONE && vertexType != GL_NONE && shaderInputType != vertexType)
843 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500844 context->handleError(InvalidOperation() << "Vertex shader input type does not "
845 "match the type of the bound vertex "
846 "attribute.");
Geoff Lang9ab5b822017-05-30 16:19:23 -0400847 return false;
848 }
849 }
850
851 return true;
852}
853
Geoff Langf41a7152016-09-19 15:11:17 -0400854} // anonymous namespace
855
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500856bool ValidTextureTarget(const ValidationContext *context, GLenum target)
Jamie Madill35d15012013-10-07 10:46:37 -0400857{
Jamie Madilld7460c72014-01-21 16:38:14 -0500858 switch (target)
Jamie Madill35d15012013-10-07 10:46:37 -0400859 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800860 case GL_TEXTURE_2D:
861 case GL_TEXTURE_CUBE_MAP:
862 return true;
Jamie Madill35d15012013-10-07 10:46:37 -0400863
He Yunchaoced53ae2016-11-29 15:00:51 +0800864 case GL_TEXTURE_3D:
865 case GL_TEXTURE_2D_ARRAY:
866 return (context->getClientMajorVersion() >= 3);
Jamie Madilld7460c72014-01-21 16:38:14 -0500867
He Yunchaoced53ae2016-11-29 15:00:51 +0800868 case GL_TEXTURE_2D_MULTISAMPLE:
He Yunchaoced53ae2016-11-29 15:00:51 +0800869 return (context->getClientVersion() >= Version(3, 1));
Geoff Lang3b573612016-10-31 14:08:10 -0400870
He Yunchaoced53ae2016-11-29 15:00:51 +0800871 default:
872 return false;
Jamie Madilld7460c72014-01-21 16:38:14 -0500873 }
Jamie Madill35d15012013-10-07 10:46:37 -0400874}
875
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500876bool ValidTexture2DTarget(const ValidationContext *context, GLenum target)
877{
878 switch (target)
879 {
880 case GL_TEXTURE_2D:
881 case GL_TEXTURE_CUBE_MAP:
882 return true;
883
884 default:
885 return false;
886 }
887}
888
889bool ValidTexture3DTarget(const ValidationContext *context, GLenum target)
890{
891 switch (target)
892 {
893 case GL_TEXTURE_3D:
894 case GL_TEXTURE_2D_ARRAY:
Martin Radev1be913c2016-07-11 17:59:16 +0300895 return (context->getClientMajorVersion() >= 3);
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500896
897 default:
898 return false;
899 }
900}
901
Ian Ewellbda75592016-04-18 17:25:54 -0400902// Most texture GL calls are not compatible with external textures, so we have a separate validation
903// function for use in the GL calls that do
904bool ValidTextureExternalTarget(const ValidationContext *context, GLenum target)
905{
906 return (target == GL_TEXTURE_EXTERNAL_OES) &&
907 (context->getExtensions().eglImageExternal ||
908 context->getExtensions().eglStreamConsumerExternal);
909}
910
Shannon Woods4dfed832014-03-17 20:03:39 -0400911// This function differs from ValidTextureTarget in that the target must be
912// usable as the destination of a 2D operation-- so a cube face is valid, but
913// GL_TEXTURE_CUBE_MAP is not.
Jamie Madill560a8d82014-05-21 13:06:20 -0400914// Note: duplicate of IsInternalTextureTarget
Jamie Madillc29968b2016-01-20 11:17:23 -0500915bool ValidTexture2DDestinationTarget(const ValidationContext *context, GLenum target)
Shannon Woods4dfed832014-03-17 20:03:39 -0400916{
917 switch (target)
918 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800919 case GL_TEXTURE_2D:
920 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
921 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
922 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
923 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
924 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
925 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
926 return true;
927 default:
928 return false;
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500929 }
930}
931
Jamie Madillbe849e42017-05-02 15:49:00 -0400932bool ValidateDrawElementsInstancedBase(ValidationContext *context,
933 GLenum mode,
934 GLsizei count,
935 GLenum type,
936 const GLvoid *indices,
937 GLsizei primcount)
938{
939 if (primcount < 0)
940 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500941 context->handleError(InvalidValue() << "primcount cannot be negative.");
Jamie Madillbe849e42017-05-02 15:49:00 -0400942 return false;
943 }
944
945 if (!ValidateDrawElementsCommon(context, mode, count, type, indices, primcount))
946 {
947 return false;
948 }
949
950 // No-op zero primitive count
951 return (primcount > 0);
952}
953
954bool ValidateDrawArraysInstancedBase(Context *context,
955 GLenum mode,
956 GLint first,
957 GLsizei count,
958 GLsizei primcount)
959{
960 if (primcount < 0)
961 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500962 context->handleError(InvalidValue() << "primcount cannot be negative.");
Jamie Madillbe849e42017-05-02 15:49:00 -0400963 return false;
964 }
965
966 if (!ValidateDrawArraysCommon(context, mode, first, count, primcount))
967 {
968 return false;
969 }
970
971 // No-op if zero primitive count
972 return (primcount > 0);
973}
974
Corentin Wallez0dc97812017-06-22 14:38:44 -0400975bool ValidateDrawInstancedANGLE(ValidationContext *context)
Jamie Madillbe849e42017-05-02 15:49:00 -0400976{
977 // Verify there is at least one active attribute with a divisor of zero
978 const State &state = context->getGLState();
979
980 Program *program = state.getProgram();
981
982 const auto &attribs = state.getVertexArray()->getVertexAttributes();
983 const auto &bindings = state.getVertexArray()->getVertexBindings();
984 for (size_t attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++)
985 {
986 const VertexAttribute &attrib = attribs[attributeIndex];
987 const VertexBinding &binding = bindings[attrib.bindingIndex];
Martin Radevdd5f27e2017-06-07 10:17:09 +0300988 if (program->isAttribLocationActive(attributeIndex) && binding.getDivisor() == 0)
Jamie Madillbe849e42017-05-02 15:49:00 -0400989 {
990 return true;
991 }
992 }
993
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500994 context->handleError(InvalidOperation()
995 << "At least one attribute must have a divisor of zero.");
Jamie Madillbe849e42017-05-02 15:49:00 -0400996 return false;
997}
998
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500999bool ValidTexture3DDestinationTarget(const ValidationContext *context, GLenum target)
1000{
1001 switch (target)
1002 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001003 case GL_TEXTURE_3D:
1004 case GL_TEXTURE_2D_ARRAY:
1005 return true;
1006 default:
1007 return false;
Shannon Woods4dfed832014-03-17 20:03:39 -04001008 }
1009}
1010
He Yunchao11b038b2016-11-22 21:24:04 +08001011bool ValidTexLevelDestinationTarget(const ValidationContext *context, GLenum target)
1012{
1013 switch (target)
1014 {
1015 case GL_TEXTURE_2D:
1016 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
1017 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
1018 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
1019 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
1020 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
1021 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
1022 case GL_TEXTURE_3D:
1023 case GL_TEXTURE_2D_ARRAY:
1024 case GL_TEXTURE_2D_MULTISAMPLE:
1025 return true;
1026 default:
1027 return false;
1028 }
1029}
1030
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001031bool ValidFramebufferTarget(GLenum target)
1032{
He Yunchaoced53ae2016-11-29 15:00:51 +08001033 static_assert(GL_DRAW_FRAMEBUFFER_ANGLE == GL_DRAW_FRAMEBUFFER &&
1034 GL_READ_FRAMEBUFFER_ANGLE == GL_READ_FRAMEBUFFER,
Geoff Langd4475812015-03-18 10:53:05 -04001035 "ANGLE framebuffer enums must equal the ES3 framebuffer enums.");
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001036
1037 switch (target)
1038 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001039 case GL_FRAMEBUFFER:
1040 return true;
1041 case GL_READ_FRAMEBUFFER:
1042 return true;
1043 case GL_DRAW_FRAMEBUFFER:
1044 return true;
1045 default:
1046 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001047 }
1048}
1049
Jamie Madill29639852016-09-02 15:00:09 -04001050bool ValidBufferTarget(const ValidationContext *context, GLenum target)
Jamie Madill8c96d582014-03-05 15:01:23 -05001051{
1052 switch (target)
1053 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001054 case GL_ARRAY_BUFFER:
1055 case GL_ELEMENT_ARRAY_BUFFER:
1056 return true;
Jamie Madill8c96d582014-03-05 15:01:23 -05001057
He Yunchaoced53ae2016-11-29 15:00:51 +08001058 case GL_PIXEL_PACK_BUFFER:
1059 case GL_PIXEL_UNPACK_BUFFER:
1060 return (context->getExtensions().pixelBufferObject ||
1061 context->getClientMajorVersion() >= 3);
Shannon Woods158c4382014-05-06 13:00:07 -04001062
He Yunchaoced53ae2016-11-29 15:00:51 +08001063 case GL_COPY_READ_BUFFER:
1064 case GL_COPY_WRITE_BUFFER:
1065 case GL_TRANSFORM_FEEDBACK_BUFFER:
1066 case GL_UNIFORM_BUFFER:
1067 return (context->getClientMajorVersion() >= 3);
Jamie Madill8c96d582014-03-05 15:01:23 -05001068
He Yunchaoced53ae2016-11-29 15:00:51 +08001069 case GL_ATOMIC_COUNTER_BUFFER:
1070 case GL_SHADER_STORAGE_BUFFER:
1071 case GL_DRAW_INDIRECT_BUFFER:
1072 case GL_DISPATCH_INDIRECT_BUFFER:
He Yunchaoced53ae2016-11-29 15:00:51 +08001073 return context->getClientVersion() >= Version(3, 1);
Geoff Lang3b573612016-10-31 14:08:10 -04001074
He Yunchaoced53ae2016-11-29 15:00:51 +08001075 default:
1076 return false;
Jamie Madill8c96d582014-03-05 15:01:23 -05001077 }
1078}
1079
Jamie Madillc29968b2016-01-20 11:17:23 -05001080bool ValidMipLevel(const ValidationContext *context, GLenum target, GLint level)
Geoff Langce635692013-09-24 13:56:32 -04001081{
Jamie Madillc29968b2016-01-20 11:17:23 -05001082 const auto &caps = context->getCaps();
Geoff Langaae65a42014-05-26 12:43:44 -04001083 size_t maxDimension = 0;
Geoff Langce635692013-09-24 13:56:32 -04001084 switch (target)
1085 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001086 case GL_TEXTURE_2D:
1087 maxDimension = caps.max2DTextureSize;
1088 break;
He Yunchaoced53ae2016-11-29 15:00:51 +08001089 case GL_TEXTURE_CUBE_MAP:
1090 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
1091 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
1092 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
1093 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
1094 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
1095 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
1096 maxDimension = caps.maxCubeMapTextureSize;
1097 break;
1098 case GL_TEXTURE_3D:
1099 maxDimension = caps.max3DTextureSize;
1100 break;
1101 case GL_TEXTURE_2D_ARRAY:
1102 maxDimension = caps.max2DTextureSize;
1103 break;
He Yunchao11b038b2016-11-22 21:24:04 +08001104 case GL_TEXTURE_2D_MULTISAMPLE:
1105 maxDimension = caps.max2DTextureSize;
1106 break;
He Yunchaoced53ae2016-11-29 15:00:51 +08001107 default:
1108 UNREACHABLE();
Geoff Langce635692013-09-24 13:56:32 -04001109 }
1110
Brandon Jones6cad5662017-06-14 13:25:13 -07001111 return level <= gl::log2(static_cast<int>(maxDimension)) && level >= 0;
Geoff Langce635692013-09-24 13:56:32 -04001112}
1113
Brandon Jones6cad5662017-06-14 13:25:13 -07001114bool ValidImageSizeParameters(ValidationContext *context,
Austin Kinross08528e12015-10-07 16:24:40 -07001115 GLenum target,
1116 GLint level,
1117 GLsizei width,
1118 GLsizei height,
1119 GLsizei depth,
1120 bool isSubImage)
Geoff Langce635692013-09-24 13:56:32 -04001121{
Brandon Jones6cad5662017-06-14 13:25:13 -07001122 if (width < 0 || height < 0 || depth < 0)
Geoff Langce635692013-09-24 13:56:32 -04001123 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001124 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Geoff Langce635692013-09-24 13:56:32 -04001125 return false;
1126 }
Austin Kinross08528e12015-10-07 16:24:40 -07001127 // TexSubImage parameters can be NPOT without textureNPOT extension,
1128 // as long as the destination texture is POT.
Geoff Langcc507aa2016-12-12 10:09:52 -05001129 bool hasNPOTSupport =
Geoff Lang5f319a42017-01-09 16:49:19 -05001130 context->getExtensions().textureNPOT || context->getClientVersion() >= Version(3, 0);
Geoff Langcc507aa2016-12-12 10:09:52 -05001131 if (!isSubImage && !hasNPOTSupport &&
Jamie Madill4fd75c12014-06-23 10:53:54 -04001132 (level != 0 && (!gl::isPow2(width) || !gl::isPow2(height) || !gl::isPow2(depth))))
Geoff Langce635692013-09-24 13:56:32 -04001133 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001134 ANGLE_VALIDATION_ERR(context, InvalidValue(), TextureNotPow2);
Geoff Langce635692013-09-24 13:56:32 -04001135 return false;
1136 }
1137
1138 if (!ValidMipLevel(context, target, level))
1139 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001140 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Geoff Langce635692013-09-24 13:56:32 -04001141 return false;
1142 }
1143
1144 return true;
1145}
1146
Geoff Lang0d8b7242015-09-09 14:56:53 -04001147bool CompressedTextureFormatRequiresExactSize(GLenum internalFormat)
1148{
1149 // List of compressed format that require that the texture size is smaller than or a multiple of
1150 // the compressed block size.
1151 switch (internalFormat)
1152 {
1153 case GL_COMPRESSED_RGB_S3TC_DXT1_EXT:
1154 case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT:
1155 case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE:
1156 case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE:
Geoff Langfff7a7d2017-06-02 10:39:17 -04001157 case GL_COMPRESSED_SRGB_S3TC_DXT1_EXT:
1158 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT:
1159 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT:
1160 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT:
Minmin Gonge3939b92015-12-01 15:36:51 -08001161 case GL_ETC1_RGB8_LOSSY_DECODE_ANGLE:
Minmin Gong390208b2017-02-28 18:03:06 -08001162 case GL_COMPRESSED_RGB8_LOSSY_DECODE_ETC2_ANGLE:
1163 case GL_COMPRESSED_SRGB8_LOSSY_DECODE_ETC2_ANGLE:
1164 case GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE:
1165 case GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE:
1166 case GL_COMPRESSED_RGBA8_LOSSY_DECODE_ETC2_EAC_ANGLE:
1167 case GL_COMPRESSED_SRGB8_ALPHA8_LOSSY_DECODE_ETC2_EAC_ANGLE:
Geoff Lang0d8b7242015-09-09 14:56:53 -04001168 return true;
1169
1170 default:
1171 return false;
1172 }
1173}
1174
Geoff Lang966c9402017-04-18 12:38:27 -04001175bool ValidCompressedDimension(GLsizei size, GLuint blockSize, bool smallerThanBlockSizeAllowed)
1176{
1177 return (smallerThanBlockSizeAllowed && (size > 0) && (blockSize % size == 0)) ||
1178 (size % blockSize == 0);
1179}
1180
Jamie Madillc29968b2016-01-20 11:17:23 -05001181bool ValidCompressedImageSize(const ValidationContext *context,
1182 GLenum internalFormat,
Geoff Lang966c9402017-04-18 12:38:27 -04001183 GLint level,
Jamie Madillc29968b2016-01-20 11:17:23 -05001184 GLsizei width,
1185 GLsizei height)
Geoff Langd4f180b2013-09-24 13:57:44 -04001186{
Geoff Langca271392017-04-05 12:30:00 -04001187 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat);
Geoff Lang5d601382014-07-22 15:14:06 -04001188 if (!formatInfo.compressed)
Geoff Langd4f180b2013-09-24 13:57:44 -04001189 {
1190 return false;
1191 }
1192
Geoff Lang966c9402017-04-18 12:38:27 -04001193 if (width < 0 || height < 0)
1194 {
1195 return false;
1196 }
1197
1198 if (CompressedTextureFormatRequiresExactSize(internalFormat))
1199 {
1200 // The ANGLE extensions allow specifying compressed textures with sizes smaller than the
1201 // block size for level 0 but WebGL disallows this.
1202 bool smallerThanBlockSizeAllowed =
1203 level > 0 || !context->getExtensions().webglCompatibility;
1204
1205 if (!ValidCompressedDimension(width, formatInfo.compressedBlockWidth,
1206 smallerThanBlockSizeAllowed) ||
1207 !ValidCompressedDimension(height, formatInfo.compressedBlockHeight,
1208 smallerThanBlockSizeAllowed))
1209 {
1210 return false;
1211 }
1212 }
1213
1214 return true;
1215}
1216
1217bool ValidCompressedSubImageSize(const ValidationContext *context,
1218 GLenum internalFormat,
1219 GLint xoffset,
1220 GLint yoffset,
1221 GLsizei width,
1222 GLsizei height,
1223 size_t textureWidth,
1224 size_t textureHeight)
1225{
1226 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat);
1227 if (!formatInfo.compressed)
1228 {
1229 return false;
1230 }
1231
Geoff Lang44ff5a72017-02-03 15:15:43 -05001232 if (xoffset < 0 || yoffset < 0 || width < 0 || height < 0)
Geoff Langd4f180b2013-09-24 13:57:44 -04001233 {
1234 return false;
1235 }
1236
Geoff Lang0d8b7242015-09-09 14:56:53 -04001237 if (CompressedTextureFormatRequiresExactSize(internalFormat))
1238 {
Geoff Lang44ff5a72017-02-03 15:15:43 -05001239 if (xoffset % formatInfo.compressedBlockWidth != 0 ||
Geoff Lang966c9402017-04-18 12:38:27 -04001240 yoffset % formatInfo.compressedBlockHeight != 0)
1241 {
1242 return false;
1243 }
1244
1245 // Allowed to either have data that is a multiple of block size or is smaller than the block
1246 // size but fills the entire mip
1247 bool fillsEntireMip = xoffset == 0 && yoffset == 0 &&
1248 static_cast<size_t>(width) == textureWidth &&
1249 static_cast<size_t>(height) == textureHeight;
1250 bool sizeMultipleOfBlockSize = (width % formatInfo.compressedBlockWidth) == 0 &&
1251 (height % formatInfo.compressedBlockHeight) == 0;
1252 if (!sizeMultipleOfBlockSize && !fillsEntireMip)
Geoff Lang0d8b7242015-09-09 14:56:53 -04001253 {
1254 return false;
1255 }
1256 }
1257
Geoff Langd4f180b2013-09-24 13:57:44 -04001258 return true;
1259}
1260
Geoff Langff5b2d52016-09-07 11:32:23 -04001261bool ValidImageDataSize(ValidationContext *context,
1262 GLenum textureTarget,
1263 GLsizei width,
1264 GLsizei height,
1265 GLsizei depth,
Geoff Langdbcced82017-06-06 15:55:54 -04001266 GLenum format,
Geoff Langff5b2d52016-09-07 11:32:23 -04001267 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04001268 const void *pixels,
Geoff Langff5b2d52016-09-07 11:32:23 -04001269 GLsizei imageSize)
1270{
1271 gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
1272 if (pixelUnpackBuffer == nullptr && imageSize < 0)
1273 {
1274 // Checks are not required
1275 return true;
1276 }
1277
1278 // ...the data would be unpacked from the buffer object such that the memory reads required
1279 // would exceed the data store size.
Geoff Langdbcced82017-06-06 15:55:54 -04001280 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(format, type);
1281 ASSERT(formatInfo.internalFormat != GL_NONE);
Geoff Langff5b2d52016-09-07 11:32:23 -04001282 const gl::Extents size(width, height, depth);
1283 const auto &unpack = context->getGLState().getUnpackState();
1284
1285 bool targetIs3D = textureTarget == GL_TEXTURE_3D || textureTarget == GL_TEXTURE_2D_ARRAY;
1286 auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, unpack, targetIs3D);
1287 if (endByteOrErr.isError())
1288 {
1289 context->handleError(endByteOrErr.getError());
1290 return false;
1291 }
1292
1293 GLuint endByte = endByteOrErr.getResult();
1294
1295 if (pixelUnpackBuffer)
1296 {
1297 CheckedNumeric<size_t> checkedEndByte(endByteOrErr.getResult());
1298 CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels));
1299 checkedEndByte += checkedOffset;
1300
1301 if (!checkedEndByte.IsValid() ||
1302 (checkedEndByte.ValueOrDie() > static_cast<size_t>(pixelUnpackBuffer->getSize())))
1303 {
1304 // Overflow past the end of the buffer
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001305 context->handleError(InvalidOperation());
Geoff Langff5b2d52016-09-07 11:32:23 -04001306 return false;
1307 }
1308 }
1309 else
1310 {
1311 ASSERT(imageSize >= 0);
1312 if (pixels == nullptr && imageSize != 0)
1313 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001314 context->handleError(InvalidOperation()
1315 << "imageSize must be 0 if no texture data is provided.");
Geoff Lang3feb3ff2016-10-26 10:57:45 -04001316 return false;
Geoff Langff5b2d52016-09-07 11:32:23 -04001317 }
1318
Geoff Lang3feb3ff2016-10-26 10:57:45 -04001319 if (pixels != nullptr && endByte > static_cast<GLuint>(imageSize))
Geoff Langff5b2d52016-09-07 11:32:23 -04001320 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001321 context->handleError(InvalidOperation() << "imageSize must be at least " << endByte);
Geoff Langff5b2d52016-09-07 11:32:23 -04001322 return false;
1323 }
1324 }
1325
1326 return true;
1327}
1328
Geoff Lang37dde692014-01-31 16:34:54 -05001329bool ValidQueryType(const Context *context, GLenum queryType)
1330{
He Yunchaoced53ae2016-11-29 15:00:51 +08001331 static_assert(GL_ANY_SAMPLES_PASSED == GL_ANY_SAMPLES_PASSED_EXT,
1332 "GL extension enums not equal.");
1333 static_assert(GL_ANY_SAMPLES_PASSED_CONSERVATIVE == GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
1334 "GL extension enums not equal.");
Geoff Lang37dde692014-01-31 16:34:54 -05001335
1336 switch (queryType)
1337 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001338 case GL_ANY_SAMPLES_PASSED:
1339 case GL_ANY_SAMPLES_PASSED_CONSERVATIVE:
1340 return true;
1341 case GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN:
1342 return (context->getClientMajorVersion() >= 3);
1343 case GL_TIME_ELAPSED_EXT:
1344 return context->getExtensions().disjointTimerQuery;
1345 case GL_COMMANDS_COMPLETED_CHROMIUM:
1346 return context->getExtensions().syncQuery;
1347 default:
1348 return false;
Geoff Lang37dde692014-01-31 16:34:54 -05001349 }
1350}
1351
Geoff Lang2d62ab72017-03-23 16:54:40 -04001352bool ValidateWebGLVertexAttribPointer(ValidationContext *context,
1353 GLenum type,
1354 GLboolean normalized,
1355 GLsizei stride,
Jamie Madill876429b2017-04-20 15:46:24 -04001356 const void *ptr,
Geoff Lang2d62ab72017-03-23 16:54:40 -04001357 bool pureInteger)
1358{
1359 ASSERT(context->getExtensions().webglCompatibility);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001360 // WebGL 1.0 [Section 6.11] Vertex Attribute Data Stride
1361 // The WebGL API supports vertex attribute data strides up to 255 bytes. A call to
1362 // vertexAttribPointer will generate an INVALID_VALUE error if the value for the stride
1363 // parameter exceeds 255.
1364 constexpr GLsizei kMaxWebGLStride = 255;
1365 if (stride > kMaxWebGLStride)
1366 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001367 context->handleError(InvalidValue()
1368 << "Stride is over the maximum stride allowed by WebGL.");
Geoff Lang2d62ab72017-03-23 16:54:40 -04001369 return false;
1370 }
1371
1372 // WebGL 1.0 [Section 6.4] Buffer Offset and Stride Requirements
1373 // The offset arguments to drawElements and vertexAttribPointer, and the stride argument to
1374 // vertexAttribPointer, must be a multiple of the size of the data type passed to the call,
1375 // or an INVALID_OPERATION error is generated.
1376 VertexFormatType internalType = GetVertexFormatType(type, normalized, 1, pureInteger);
1377 size_t typeSize = GetVertexFormatTypeSize(internalType);
1378
1379 ASSERT(isPow2(typeSize) && typeSize > 0);
1380 size_t sizeMask = (typeSize - 1);
1381 if ((reinterpret_cast<intptr_t>(ptr) & sizeMask) != 0)
1382 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001383 ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001384 return false;
1385 }
1386
1387 if ((stride & sizeMask) != 0)
1388 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001389 ANGLE_VALIDATION_ERR(context, InvalidOperation(), StrideMustBeMultipleOfType);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001390 return false;
1391 }
1392
1393 return true;
1394}
1395
Jamie Madillef300b12016-10-07 15:12:09 -04001396Program *GetValidProgram(ValidationContext *context, GLuint id)
Geoff Lang48dcae72014-02-05 16:28:24 -05001397{
He Yunchaoced53ae2016-11-29 15:00:51 +08001398 // ES3 spec (section 2.11.1) -- "Commands that accept shader or program object names will
1399 // generate the error INVALID_VALUE if the provided name is not the name of either a shader
1400 // or program object and INVALID_OPERATION if the provided name identifies an object
1401 // that is not the expected type."
Geoff Lang48dcae72014-02-05 16:28:24 -05001402
Dian Xiang769769a2015-09-09 15:20:08 -07001403 Program *validProgram = context->getProgram(id);
1404
1405 if (!validProgram)
Geoff Lang48dcae72014-02-05 16:28:24 -05001406 {
Dian Xiang769769a2015-09-09 15:20:08 -07001407 if (context->getShader(id))
1408 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001409 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedProgramName);
Dian Xiang769769a2015-09-09 15:20:08 -07001410 }
1411 else
1412 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001413 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidProgramName);
Dian Xiang769769a2015-09-09 15:20:08 -07001414 }
Geoff Lang48dcae72014-02-05 16:28:24 -05001415 }
Dian Xiang769769a2015-09-09 15:20:08 -07001416
1417 return validProgram;
1418}
1419
Jamie Madillef300b12016-10-07 15:12:09 -04001420Shader *GetValidShader(ValidationContext *context, GLuint id)
Dian Xiang769769a2015-09-09 15:20:08 -07001421{
1422 // See ValidProgram for spec details.
1423
1424 Shader *validShader = context->getShader(id);
1425
1426 if (!validShader)
Geoff Lang48dcae72014-02-05 16:28:24 -05001427 {
Dian Xiang769769a2015-09-09 15:20:08 -07001428 if (context->getProgram(id))
1429 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001430 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedShaderName);
Dian Xiang769769a2015-09-09 15:20:08 -07001431 }
1432 else
1433 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001434 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidShaderName);
Dian Xiang769769a2015-09-09 15:20:08 -07001435 }
Geoff Lang48dcae72014-02-05 16:28:24 -05001436 }
Dian Xiang769769a2015-09-09 15:20:08 -07001437
1438 return validShader;
Geoff Lang48dcae72014-02-05 16:28:24 -05001439}
1440
Geoff Langb1196682014-07-23 13:47:29 -04001441bool ValidateAttachmentTarget(gl::Context *context, GLenum attachment)
Jamie Madillb4472272014-07-03 10:38:55 -04001442{
1443 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
1444 {
1445 const unsigned int colorAttachment = (attachment - GL_COLOR_ATTACHMENT0_EXT);
1446
Geoff Langaae65a42014-05-26 12:43:44 -04001447 if (colorAttachment >= context->getCaps().maxColorAttachments)
Jamie Madillb4472272014-07-03 10:38:55 -04001448 {
Martin Radevd178aa42017-07-13 14:03:22 +03001449 context->handleError(
1450 InvalidOperation()
1451 << "attachment index cannot be greater or equal to MAX_COLOR_ATTACHMENTS.");
Geoff Langb1196682014-07-23 13:47:29 -04001452 return false;
Jamie Madillb4472272014-07-03 10:38:55 -04001453 }
1454 }
1455 else
1456 {
1457 switch (attachment)
1458 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001459 case GL_DEPTH_ATTACHMENT:
1460 case GL_STENCIL_ATTACHMENT:
1461 break;
Jamie Madillb4472272014-07-03 10:38:55 -04001462
He Yunchaoced53ae2016-11-29 15:00:51 +08001463 case GL_DEPTH_STENCIL_ATTACHMENT:
1464 if (!context->getExtensions().webglCompatibility &&
1465 context->getClientMajorVersion() < 3)
1466 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001467 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
He Yunchaoced53ae2016-11-29 15:00:51 +08001468 return false;
1469 }
1470 break;
Jamie Madillb4472272014-07-03 10:38:55 -04001471
He Yunchaoced53ae2016-11-29 15:00:51 +08001472 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001473 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
He Yunchaoced53ae2016-11-29 15:00:51 +08001474 return false;
Jamie Madillb4472272014-07-03 10:38:55 -04001475 }
1476 }
1477
1478 return true;
1479}
1480
Jamie Madille8fb6402017-02-14 17:56:40 -05001481bool ValidateRenderbufferStorageParametersBase(ValidationContext *context,
He Yunchaoced53ae2016-11-29 15:00:51 +08001482 GLenum target,
1483 GLsizei samples,
1484 GLenum internalformat,
1485 GLsizei width,
1486 GLsizei height)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001487{
1488 switch (target)
1489 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001490 case GL_RENDERBUFFER:
1491 break;
1492 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001493 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
He Yunchaoced53ae2016-11-29 15:00:51 +08001494 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001495 }
1496
1497 if (width < 0 || height < 0 || samples < 0)
1498 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001499 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidRenderbufferWidthHeight);
Geoff Langb1196682014-07-23 13:47:29 -04001500 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001501 }
1502
Jamie Madill4e0e6f82017-02-17 11:06:03 -05001503 // Hack for the special WebGL 1 "DEPTH_STENCIL" internal format.
1504 GLenum convertedInternalFormat = context->getConvertedRenderbufferFormat(internalformat);
1505
1506 const TextureCaps &formatCaps = context->getTextureCaps().get(convertedInternalFormat);
Geoff Langd87878e2014-09-19 15:42:59 -04001507 if (!formatCaps.renderable)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001508 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001509 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04001510 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001511 }
1512
1513 // ANGLE_framebuffer_multisample does not explicitly state that the internal format must be
1514 // sized but it does state that the format must be in the ES2.0 spec table 4.5 which contains
Corentin Walleze0902642014-11-04 12:32:15 -08001515 // only sized internal formats.
Geoff Langca271392017-04-05 12:30:00 -04001516 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(convertedInternalFormat);
1517 if (formatInfo.internalFormat == GL_NONE)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001518 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001519 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferInternalFormat);
Geoff Langb1196682014-07-23 13:47:29 -04001520 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001521 }
1522
Geoff Langaae65a42014-05-26 12:43:44 -04001523 if (static_cast<GLuint>(std::max(width, height)) > context->getCaps().maxRenderbufferSize)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001524 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001525 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04001526 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001527 }
1528
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001529 GLuint handle = context->getGLState().getRenderbufferId();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001530 if (handle == 0)
1531 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001532 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001533 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001534 }
1535
1536 return true;
1537}
1538
He Yunchaoced53ae2016-11-29 15:00:51 +08001539bool ValidateFramebufferRenderbufferParameters(gl::Context *context,
1540 GLenum target,
1541 GLenum attachment,
1542 GLenum renderbuffertarget,
1543 GLuint renderbuffer)
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001544{
Shannon Woods1da3cf62014-06-27 15:32:23 -04001545 if (!ValidFramebufferTarget(target))
1546 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001547 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04001548 return false;
Shannon Woods1da3cf62014-06-27 15:32:23 -04001549 }
1550
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001551 gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001552
Jamie Madill84115c92015-04-23 15:00:07 -04001553 ASSERT(framebuffer);
1554 if (framebuffer->id() == 0)
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001555 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001556 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001557 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001558 }
1559
Jamie Madillb4472272014-07-03 10:38:55 -04001560 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001561 {
Jamie Madillb4472272014-07-03 10:38:55 -04001562 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001563 }
1564
Jamie Madillab9d82c2014-01-21 16:38:14 -05001565 // [OpenGL ES 2.0.25] Section 4.4.3 page 112
1566 // [OpenGL ES 3.0.2] Section 4.4.2 page 201
1567 // 'renderbuffer' must be either zero or the name of an existing renderbuffer object of
1568 // type 'renderbuffertarget', otherwise an INVALID_OPERATION error is generated.
1569 if (renderbuffer != 0)
1570 {
1571 if (!context->getRenderbuffer(renderbuffer))
1572 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001573 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001574 return false;
Jamie Madillab9d82c2014-01-21 16:38:14 -05001575 }
1576 }
1577
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001578 return true;
1579}
1580
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001581bool ValidateBlitFramebufferParameters(ValidationContext *context,
Jamie Madillc29968b2016-01-20 11:17:23 -05001582 GLint srcX0,
1583 GLint srcY0,
1584 GLint srcX1,
1585 GLint srcY1,
1586 GLint dstX0,
1587 GLint dstY0,
1588 GLint dstX1,
1589 GLint dstY1,
1590 GLbitfield mask,
1591 GLenum filter)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001592{
1593 switch (filter)
1594 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001595 case GL_NEAREST:
1596 break;
1597 case GL_LINEAR:
1598 break;
1599 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001600 context->handleError(InvalidEnum());
He Yunchaoced53ae2016-11-29 15:00:51 +08001601 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001602 }
1603
1604 if ((mask & ~(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT | GL_DEPTH_BUFFER_BIT)) != 0)
1605 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001606 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04001607 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001608 }
1609
1610 if (mask == 0)
1611 {
1612 // ES3.0 spec, section 4.3.2 specifies that a mask of zero is valid and no
1613 // buffers are copied.
1614 return false;
1615 }
1616
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001617 // ES3.0 spec, section 4.3.2 states that linear filtering is only available for the
1618 // color buffer, leaving only nearest being unfiltered from above
1619 if ((mask & ~GL_COLOR_BUFFER_BIT) != 0 && filter != GL_NEAREST)
1620 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001621 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001622 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001623 }
1624
Jamie Madill51f40ec2016-06-15 14:06:00 -04001625 const auto &glState = context->getGLState();
1626 gl::Framebuffer *readFramebuffer = glState.getReadFramebuffer();
1627 gl::Framebuffer *drawFramebuffer = glState.getDrawFramebuffer();
Jamie Madill48faf802014-11-06 15:27:22 -05001628
1629 if (!readFramebuffer || !drawFramebuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001630 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001631 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001632 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001633 }
1634
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001635 if (readFramebuffer->id() == drawFramebuffer->id())
1636 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001637 context->handleError(InvalidOperation());
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001638 return false;
1639 }
1640
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001641 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill48faf802014-11-06 15:27:22 -05001642 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001643 context->handleError(InvalidFramebufferOperation());
Jamie Madill48faf802014-11-06 15:27:22 -05001644 return false;
1645 }
1646
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001647 if (drawFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill48faf802014-11-06 15:27:22 -05001648 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001649 context->handleError(InvalidFramebufferOperation());
Jamie Madill48faf802014-11-06 15:27:22 -05001650 return false;
1651 }
1652
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001653 if (drawFramebuffer->getSamples(context) != 0)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001654 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001655 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001656 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001657 }
1658
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001659 bool sameBounds = srcX0 == dstX0 && srcY0 == dstY0 && srcX1 == dstX1 && srcY1 == dstY1;
1660
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001661 if (mask & GL_COLOR_BUFFER_BIT)
1662 {
Jamie Madillb6bda4a2015-04-20 12:53:26 -04001663 const gl::FramebufferAttachment *readColorBuffer = readFramebuffer->getReadColorbuffer();
Jamie Madill6163c752015-12-07 16:32:59 -05001664 const Extensions &extensions = context->getExtensions();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001665
He Yunchao66a41a22016-12-15 16:45:05 +08001666 if (readColorBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001667 {
Jamie Madilla3944d42016-07-22 22:13:26 -04001668 const Format &readFormat = readColorBuffer->getFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001669
Geoff Langa15472a2015-08-11 11:48:03 -04001670 for (size_t drawbufferIdx = 0;
1671 drawbufferIdx < drawFramebuffer->getDrawbufferStateCount(); ++drawbufferIdx)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001672 {
Geoff Langa15472a2015-08-11 11:48:03 -04001673 const FramebufferAttachment *attachment =
1674 drawFramebuffer->getDrawBuffer(drawbufferIdx);
1675 if (attachment)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001676 {
Jamie Madilla3944d42016-07-22 22:13:26 -04001677 const Format &drawFormat = attachment->getFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001678
Geoff Langb2f3d052013-08-13 12:49:27 -04001679 // The GL ES 3.0.2 spec (pg 193) states that:
1680 // 1) If the read buffer is fixed point format, the draw buffer must be as well
He Yunchaoced53ae2016-11-29 15:00:51 +08001681 // 2) If the read buffer is an unsigned integer format, the draw buffer must be
1682 // as well
1683 // 3) If the read buffer is a signed integer format, the draw buffer must be as
1684 // well
Jamie Madill6163c752015-12-07 16:32:59 -05001685 // Changes with EXT_color_buffer_float:
1686 // Case 1) is changed to fixed point OR floating point
Jamie Madilla3944d42016-07-22 22:13:26 -04001687 GLenum readComponentType = readFormat.info->componentType;
1688 GLenum drawComponentType = drawFormat.info->componentType;
He Yunchaoced53ae2016-11-29 15:00:51 +08001689 bool readFixedPoint = (readComponentType == GL_UNSIGNED_NORMALIZED ||
Jamie Madill6163c752015-12-07 16:32:59 -05001690 readComponentType == GL_SIGNED_NORMALIZED);
1691 bool drawFixedPoint = (drawComponentType == GL_UNSIGNED_NORMALIZED ||
1692 drawComponentType == GL_SIGNED_NORMALIZED);
1693
1694 if (extensions.colorBufferFloat)
1695 {
1696 bool readFixedOrFloat = (readFixedPoint || readComponentType == GL_FLOAT);
1697 bool drawFixedOrFloat = (drawFixedPoint || drawComponentType == GL_FLOAT);
1698
1699 if (readFixedOrFloat != drawFixedOrFloat)
1700 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001701 context->handleError(InvalidOperation()
1702 << "If the read buffer contains fixed-point or "
1703 "floating-point values, the draw buffer must "
1704 "as well.");
Jamie Madill6163c752015-12-07 16:32:59 -05001705 return false;
1706 }
1707 }
1708 else if (readFixedPoint != drawFixedPoint)
1709 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001710 context->handleError(InvalidOperation()
1711 << "If the read buffer contains fixed-point values, "
1712 "the draw buffer must as well.");
Jamie Madill6163c752015-12-07 16:32:59 -05001713 return false;
1714 }
1715
1716 if (readComponentType == GL_UNSIGNED_INT &&
1717 drawComponentType != GL_UNSIGNED_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001718 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001719 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001720 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001721 }
1722
Jamie Madill6163c752015-12-07 16:32:59 -05001723 if (readComponentType == GL_INT && drawComponentType != GL_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001724 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001725 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001726 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001727 }
1728
Jamie Madilla3944d42016-07-22 22:13:26 -04001729 if (readColorBuffer->getSamples() > 0 &&
Kenneth Russell69382852017-07-21 16:38:44 -04001730 (!Format::EquivalentForBlit(readFormat, drawFormat) || !sameBounds))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001731 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001732 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001733 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001734 }
Geoff Lange4915782017-04-12 15:19:07 -04001735
1736 if (context->getExtensions().webglCompatibility &&
1737 *readColorBuffer == *attachment)
1738 {
1739 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001740 InvalidOperation()
1741 << "Read and write color attachments cannot be the same image.");
Geoff Lange4915782017-04-12 15:19:07 -04001742 return false;
1743 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001744 }
1745 }
1746
Jamie Madilla3944d42016-07-22 22:13:26 -04001747 if ((readFormat.info->componentType == GL_INT ||
1748 readFormat.info->componentType == GL_UNSIGNED_INT) &&
1749 filter == GL_LINEAR)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001750 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001751 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001752 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001753 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001754 }
He Yunchao66a41a22016-12-15 16:45:05 +08001755 // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment
1756 // In OpenGL ES it is undefined what happens when an operation tries to blit from a missing
1757 // attachment and WebGL defines it to be an error. We do the check unconditionally as the
1758 // situation is an application error that would lead to a crash in ANGLE.
1759 else if (drawFramebuffer->hasEnabledDrawBuffer())
1760 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001761 context->handleError(
1762 InvalidOperation()
1763 << "Attempt to read from a missing color attachment of a complete framebuffer.");
He Yunchao66a41a22016-12-15 16:45:05 +08001764 return false;
1765 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001766 }
1767
He Yunchaoced53ae2016-11-29 15:00:51 +08001768 GLenum masks[] = {GL_DEPTH_BUFFER_BIT, GL_STENCIL_BUFFER_BIT};
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001769 GLenum attachments[] = {GL_DEPTH_ATTACHMENT, GL_STENCIL_ATTACHMENT};
1770 for (size_t i = 0; i < 2; i++)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001771 {
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001772 if (mask & masks[i])
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001773 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001774 const gl::FramebufferAttachment *readBuffer =
1775 readFramebuffer->getAttachment(attachments[i]);
1776 const gl::FramebufferAttachment *drawBuffer =
1777 drawFramebuffer->getAttachment(attachments[i]);
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001778
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001779 if (readBuffer && drawBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001780 {
Kenneth Russell69382852017-07-21 16:38:44 -04001781 if (!Format::EquivalentForBlit(readBuffer->getFormat(), drawBuffer->getFormat()))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001782 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001783 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001784 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001785 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001786
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001787 if (readBuffer->getSamples() > 0 && !sameBounds)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001788 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001789 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001790 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001791 }
Geoff Lange4915782017-04-12 15:19:07 -04001792
1793 if (context->getExtensions().webglCompatibility && *readBuffer == *drawBuffer)
1794 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001795 context->handleError(
1796 InvalidOperation()
1797 << "Read and write depth stencil attachments cannot be the same image.");
Geoff Lange4915782017-04-12 15:19:07 -04001798 return false;
1799 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001800 }
He Yunchao66a41a22016-12-15 16:45:05 +08001801 // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment
1802 else if (drawBuffer)
1803 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001804 context->handleError(InvalidOperation() << "Attempt to read from a missing "
1805 "depth/stencil attachment of a "
1806 "complete framebuffer.");
He Yunchao66a41a22016-12-15 16:45:05 +08001807 return false;
1808 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001809 }
1810 }
1811
Martin Radeva3ed4572017-07-27 18:29:37 +03001812 // ANGLE_multiview, Revision 1:
1813 // Calling BlitFramebuffer will result in an INVALID_FRAMEBUFFER_OPERATION error if the
1814 // multi-view layout of the current draw framebuffer or read framebuffer is not NONE.
1815 if (readFramebuffer->getMultiviewLayout() != GL_NONE)
1816 {
1817 context->handleError(InvalidFramebufferOperation()
1818 << "Attempt to read from a multi-view framebuffer.");
1819 return false;
1820 }
1821 if (drawFramebuffer->getMultiviewLayout() != GL_NONE)
1822 {
1823 context->handleError(InvalidFramebufferOperation()
1824 << "Attempt to write to a multi-view framebuffer.");
1825 return false;
1826 }
1827
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001828 return true;
1829}
1830
Jamie Madill4928b7c2017-06-20 12:57:39 -04001831bool ValidateReadPixelsRobustANGLE(Context *context,
Geoff Lang62fce5b2016-09-30 10:46:35 -04001832 GLint x,
1833 GLint y,
1834 GLsizei width,
1835 GLsizei height,
1836 GLenum format,
1837 GLenum type,
1838 GLsizei bufSize,
1839 GLsizei *length,
Geoff Lange93daba2017-03-30 13:54:40 -04001840 GLsizei *columns,
1841 GLsizei *rows,
Jamie Madill876429b2017-04-20 15:46:24 -04001842 void *pixels)
Geoff Lang62fce5b2016-09-30 10:46:35 -04001843{
1844 if (!ValidateRobustEntryPoint(context, bufSize))
Jamie Madillc29968b2016-01-20 11:17:23 -05001845 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001846 return false;
1847 }
1848
Geoff Lang62fce5b2016-09-30 10:46:35 -04001849 if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length,
Geoff Lange93daba2017-03-30 13:54:40 -04001850 columns, rows, pixels))
Jamie Madill26e91952014-03-05 15:01:27 -05001851 {
Geoff Langb1196682014-07-23 13:47:29 -04001852 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001853 }
1854
Geoff Lang62fce5b2016-09-30 10:46:35 -04001855 if (!ValidateRobustBufferSize(context, bufSize, *length))
Jamie Madill26e91952014-03-05 15:01:27 -05001856 {
Geoff Langb1196682014-07-23 13:47:29 -04001857 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001858 }
1859
Jamie Madillc29968b2016-01-20 11:17:23 -05001860 return true;
1861}
1862
1863bool ValidateReadnPixelsEXT(Context *context,
1864 GLint x,
1865 GLint y,
1866 GLsizei width,
1867 GLsizei height,
1868 GLenum format,
1869 GLenum type,
1870 GLsizei bufSize,
Jamie Madill876429b2017-04-20 15:46:24 -04001871 void *pixels)
Jamie Madillc29968b2016-01-20 11:17:23 -05001872{
1873 if (bufSize < 0)
1874 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001875 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Jamie Madillc29968b2016-01-20 11:17:23 -05001876 return false;
1877 }
1878
Geoff Lang62fce5b2016-09-30 10:46:35 -04001879 return ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, nullptr,
Geoff Lange93daba2017-03-30 13:54:40 -04001880 nullptr, nullptr, pixels);
Geoff Lang62fce5b2016-09-30 10:46:35 -04001881}
Jamie Madill26e91952014-03-05 15:01:27 -05001882
Jamie Madill4928b7c2017-06-20 12:57:39 -04001883bool ValidateReadnPixelsRobustANGLE(Context *context,
Geoff Lang62fce5b2016-09-30 10:46:35 -04001884 GLint x,
1885 GLint y,
1886 GLsizei width,
1887 GLsizei height,
1888 GLenum format,
1889 GLenum type,
1890 GLsizei bufSize,
1891 GLsizei *length,
Geoff Lange93daba2017-03-30 13:54:40 -04001892 GLsizei *columns,
1893 GLsizei *rows,
Jamie Madill876429b2017-04-20 15:46:24 -04001894 void *data)
Geoff Lang62fce5b2016-09-30 10:46:35 -04001895{
1896 if (!ValidateRobustEntryPoint(context, bufSize))
Jamie Madille2e406c2016-06-02 13:04:10 -04001897 {
Jamie Madille2e406c2016-06-02 13:04:10 -04001898 return false;
1899 }
1900
Geoff Lange93daba2017-03-30 13:54:40 -04001901 if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length,
1902 columns, rows, data))
Jamie Madille2e406c2016-06-02 13:04:10 -04001903 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001904 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001905 }
1906
Geoff Lang62fce5b2016-09-30 10:46:35 -04001907 if (!ValidateRobustBufferSize(context, bufSize, *length))
1908 {
1909 return false;
1910 }
1911
1912 return true;
Jamie Madill26e91952014-03-05 15:01:27 -05001913}
1914
Olli Etuaho41997e72016-03-10 13:38:39 +02001915bool ValidateGenQueriesEXT(gl::Context *context, GLsizei n)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001916{
1917 if (!context->getExtensions().occlusionQueryBoolean &&
1918 !context->getExtensions().disjointTimerQuery)
1919 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001920 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001921 return false;
1922 }
1923
Olli Etuaho41997e72016-03-10 13:38:39 +02001924 return ValidateGenOrDelete(context, n);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001925}
1926
Olli Etuaho41997e72016-03-10 13:38:39 +02001927bool ValidateDeleteQueriesEXT(gl::Context *context, GLsizei n)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001928{
1929 if (!context->getExtensions().occlusionQueryBoolean &&
1930 !context->getExtensions().disjointTimerQuery)
1931 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001932 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001933 return false;
1934 }
1935
Olli Etuaho41997e72016-03-10 13:38:39 +02001936 return ValidateGenOrDelete(context, n);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001937}
1938
1939bool ValidateBeginQueryBase(gl::Context *context, GLenum target, GLuint id)
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001940{
1941 if (!ValidQueryType(context, target))
1942 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001943 context->handleError(InvalidEnum() << "Invalid query target");
Geoff Langb1196682014-07-23 13:47:29 -04001944 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001945 }
1946
1947 if (id == 0)
1948 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001949 context->handleError(InvalidOperation() << "Query id is 0");
Geoff Langb1196682014-07-23 13:47:29 -04001950 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001951 }
1952
1953 // From EXT_occlusion_query_boolean: If BeginQueryEXT is called with an <id>
1954 // of zero, if the active query object name for <target> is non-zero (for the
1955 // targets ANY_SAMPLES_PASSED_EXT and ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, if
1956 // the active query for either target is non-zero), if <id> is the name of an
1957 // existing query object whose type does not match <target>, or if <id> is the
1958 // active query object name for any query type, the error INVALID_OPERATION is
1959 // generated.
1960
1961 // Ensure no other queries are active
1962 // NOTE: If other queries than occlusion are supported, we will need to check
1963 // separately that:
1964 // a) The query ID passed is not the current active query for any target/type
1965 // b) There are no active queries for the requested target (and in the case
1966 // of GL_ANY_SAMPLES_PASSED_EXT and GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
1967 // no query may be active for either if glBeginQuery targets either.
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001968
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001969 if (context->getGLState().isQueryActive(target))
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001970 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001971 context->handleError(InvalidOperation() << "Other query is active");
Geoff Langb1196682014-07-23 13:47:29 -04001972 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001973 }
1974
1975 Query *queryObject = context->getQuery(id, true, target);
1976
1977 // check that name was obtained with glGenQueries
1978 if (!queryObject)
1979 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001980 context->handleError(InvalidOperation() << "Invalid query id");
Geoff Langb1196682014-07-23 13:47:29 -04001981 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001982 }
1983
1984 // check for type mismatch
1985 if (queryObject->getType() != target)
1986 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001987 context->handleError(InvalidOperation() << "Query type does not match target");
Geoff Langb1196682014-07-23 13:47:29 -04001988 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001989 }
1990
1991 return true;
1992}
1993
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001994bool ValidateBeginQueryEXT(gl::Context *context, GLenum target, GLuint id)
1995{
1996 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001997 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001998 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001999 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002000 return false;
2001 }
2002
2003 return ValidateBeginQueryBase(context, target, id);
2004}
2005
2006bool ValidateEndQueryBase(gl::Context *context, GLenum target)
Jamie Madill45c785d2014-05-13 14:09:34 -04002007{
2008 if (!ValidQueryType(context, target))
2009 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002010 context->handleError(InvalidEnum() << "Invalid query target");
Geoff Langb1196682014-07-23 13:47:29 -04002011 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04002012 }
2013
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002014 const Query *queryObject = context->getGLState().getActiveQuery(target);
Jamie Madill45c785d2014-05-13 14:09:34 -04002015
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002016 if (queryObject == nullptr)
Jamie Madill45c785d2014-05-13 14:09:34 -04002017 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002018 context->handleError(InvalidOperation() << "Query target not active");
Geoff Langb1196682014-07-23 13:47:29 -04002019 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04002020 }
2021
Jamie Madill45c785d2014-05-13 14:09:34 -04002022 return true;
2023}
2024
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002025bool ValidateEndQueryEXT(gl::Context *context, GLenum target)
2026{
2027 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04002028 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002029 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002030 context->handleError(InvalidOperation() << "Query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002031 return false;
2032 }
2033
2034 return ValidateEndQueryBase(context, target);
2035}
2036
2037bool ValidateQueryCounterEXT(Context *context, GLuint id, GLenum target)
2038{
2039 if (!context->getExtensions().disjointTimerQuery)
2040 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002041 context->handleError(InvalidOperation() << "Disjoint timer query not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002042 return false;
2043 }
2044
2045 if (target != GL_TIMESTAMP_EXT)
2046 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002047 context->handleError(InvalidEnum() << "Invalid query target");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002048 return false;
2049 }
2050
2051 Query *queryObject = context->getQuery(id, true, target);
2052 if (queryObject == nullptr)
2053 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002054 context->handleError(InvalidOperation() << "Invalid query id");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002055 return false;
2056 }
2057
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002058 if (context->getGLState().isQueryActive(queryObject))
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002059 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002060 context->handleError(InvalidOperation() << "Query is active");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002061 return false;
2062 }
2063
2064 return true;
2065}
2066
Geoff Lang2186c382016-10-14 10:54:54 -04002067bool ValidateGetQueryivBase(Context *context, GLenum target, GLenum pname, GLsizei *numParams)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002068{
Geoff Lang2186c382016-10-14 10:54:54 -04002069 if (numParams)
2070 {
2071 *numParams = 0;
2072 }
2073
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002074 if (!ValidQueryType(context, target) && target != GL_TIMESTAMP_EXT)
2075 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002076 context->handleError(InvalidEnum() << "Invalid query type");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002077 return false;
2078 }
2079
2080 switch (pname)
2081 {
2082 case GL_CURRENT_QUERY_EXT:
2083 if (target == GL_TIMESTAMP_EXT)
2084 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002085 context->handleError(InvalidEnum() << "Cannot use current query for timestamp");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002086 return false;
2087 }
2088 break;
2089 case GL_QUERY_COUNTER_BITS_EXT:
2090 if (!context->getExtensions().disjointTimerQuery ||
2091 (target != GL_TIMESTAMP_EXT && target != GL_TIME_ELAPSED_EXT))
2092 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002093 context->handleError(InvalidEnum() << "Invalid pname");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002094 return false;
2095 }
2096 break;
2097 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002098 context->handleError(InvalidEnum() << "Invalid pname");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002099 return false;
2100 }
2101
Geoff Lang2186c382016-10-14 10:54:54 -04002102 if (numParams)
2103 {
2104 // All queries return only one value
2105 *numParams = 1;
2106 }
2107
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002108 return true;
2109}
2110
2111bool ValidateGetQueryivEXT(Context *context, GLenum target, GLenum pname, GLint *params)
2112{
2113 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04002114 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002115 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002116 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002117 return false;
2118 }
2119
Geoff Lang2186c382016-10-14 10:54:54 -04002120 return ValidateGetQueryivBase(context, target, pname, nullptr);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002121}
2122
Geoff Lang2186c382016-10-14 10:54:54 -04002123bool ValidateGetQueryivRobustANGLE(Context *context,
2124 GLenum target,
2125 GLenum pname,
2126 GLsizei bufSize,
2127 GLsizei *length,
2128 GLint *params)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002129{
Geoff Lang2186c382016-10-14 10:54:54 -04002130 if (!ValidateRobustEntryPoint(context, bufSize))
2131 {
2132 return false;
2133 }
2134
2135 if (!ValidateGetQueryivBase(context, target, pname, length))
2136 {
2137 return false;
2138 }
2139
2140 if (!ValidateRobustBufferSize(context, bufSize, *length))
2141 {
2142 return false;
2143 }
2144
2145 return true;
2146}
2147
2148bool ValidateGetQueryObjectValueBase(Context *context, GLuint id, GLenum pname, GLsizei *numParams)
2149{
2150 if (numParams)
2151 {
2152 *numParams = 0;
2153 }
2154
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002155 Query *queryObject = context->getQuery(id, false, GL_NONE);
2156
2157 if (!queryObject)
2158 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002159 context->handleError(InvalidOperation() << "Query does not exist");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002160 return false;
2161 }
2162
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002163 if (context->getGLState().isQueryActive(queryObject))
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002164 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002165 context->handleError(InvalidOperation() << "Query currently active");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002166 return false;
2167 }
2168
2169 switch (pname)
2170 {
2171 case GL_QUERY_RESULT_EXT:
2172 case GL_QUERY_RESULT_AVAILABLE_EXT:
2173 break;
2174
2175 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002176 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002177 return false;
2178 }
2179
Geoff Lang2186c382016-10-14 10:54:54 -04002180 if (numParams)
2181 {
2182 *numParams = 1;
2183 }
2184
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002185 return true;
2186}
2187
2188bool ValidateGetQueryObjectivEXT(Context *context, GLuint id, GLenum pname, GLint *params)
2189{
2190 if (!context->getExtensions().disjointTimerQuery)
2191 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002192 context->handleError(InvalidOperation() << "Timer query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002193 return false;
2194 }
Geoff Lang2186c382016-10-14 10:54:54 -04002195 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2196}
2197
2198bool ValidateGetQueryObjectivRobustANGLE(Context *context,
2199 GLuint id,
2200 GLenum pname,
2201 GLsizei bufSize,
2202 GLsizei *length,
2203 GLint *params)
2204{
2205 if (!context->getExtensions().disjointTimerQuery)
2206 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002207 context->handleError(InvalidOperation() << "Timer query extension not enabled");
Geoff Lang2186c382016-10-14 10:54:54 -04002208 return false;
2209 }
2210
2211 if (!ValidateRobustEntryPoint(context, bufSize))
2212 {
2213 return false;
2214 }
2215
2216 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2217 {
2218 return false;
2219 }
2220
2221 if (!ValidateRobustBufferSize(context, bufSize, *length))
2222 {
2223 return false;
2224 }
2225
2226 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002227}
2228
2229bool ValidateGetQueryObjectuivEXT(Context *context, GLuint id, GLenum pname, GLuint *params)
2230{
2231 if (!context->getExtensions().disjointTimerQuery &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04002232 !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002233 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002234 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002235 return false;
2236 }
Geoff Lang2186c382016-10-14 10:54:54 -04002237 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2238}
2239
2240bool ValidateGetQueryObjectuivRobustANGLE(Context *context,
2241 GLuint id,
2242 GLenum pname,
2243 GLsizei bufSize,
2244 GLsizei *length,
2245 GLuint *params)
2246{
2247 if (!context->getExtensions().disjointTimerQuery &&
2248 !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery)
2249 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002250 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002251 return false;
2252 }
2253
2254 if (!ValidateRobustEntryPoint(context, bufSize))
2255 {
2256 return false;
2257 }
2258
2259 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2260 {
2261 return false;
2262 }
2263
2264 if (!ValidateRobustBufferSize(context, bufSize, *length))
2265 {
2266 return false;
2267 }
2268
2269 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002270}
2271
2272bool ValidateGetQueryObjecti64vEXT(Context *context, GLuint id, GLenum pname, GLint64 *params)
2273{
2274 if (!context->getExtensions().disjointTimerQuery)
2275 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002276 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002277 return false;
2278 }
Geoff Lang2186c382016-10-14 10:54:54 -04002279 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2280}
2281
2282bool ValidateGetQueryObjecti64vRobustANGLE(Context *context,
2283 GLuint id,
2284 GLenum pname,
2285 GLsizei bufSize,
2286 GLsizei *length,
2287 GLint64 *params)
2288{
2289 if (!context->getExtensions().disjointTimerQuery)
2290 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002291 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002292 return false;
2293 }
2294
2295 if (!ValidateRobustEntryPoint(context, bufSize))
2296 {
2297 return false;
2298 }
2299
2300 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2301 {
2302 return false;
2303 }
2304
2305 if (!ValidateRobustBufferSize(context, bufSize, *length))
2306 {
2307 return false;
2308 }
2309
2310 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002311}
2312
2313bool ValidateGetQueryObjectui64vEXT(Context *context, GLuint id, GLenum pname, GLuint64 *params)
2314{
2315 if (!context->getExtensions().disjointTimerQuery)
2316 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002317 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002318 return false;
2319 }
Geoff Lang2186c382016-10-14 10:54:54 -04002320 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2321}
2322
2323bool ValidateGetQueryObjectui64vRobustANGLE(Context *context,
2324 GLuint id,
2325 GLenum pname,
2326 GLsizei bufSize,
2327 GLsizei *length,
2328 GLuint64 *params)
2329{
2330 if (!context->getExtensions().disjointTimerQuery)
2331 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002332 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002333 return false;
2334 }
2335
2336 if (!ValidateRobustEntryPoint(context, bufSize))
2337 {
2338 return false;
2339 }
2340
2341 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2342 {
2343 return false;
2344 }
2345
2346 if (!ValidateRobustBufferSize(context, bufSize, *length))
2347 {
2348 return false;
2349 }
2350
2351 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002352}
2353
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002354bool ValidateProgramUniform(gl::Context *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002355 GLenum valueType,
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002356 GLuint program,
2357 GLint location,
2358 GLsizei count)
2359{
2360 // Check for ES31 program uniform entry points
2361 if (context->getClientVersion() < Version(3, 1))
2362 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002363 context->handleError(InvalidOperation());
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002364 return false;
2365 }
2366
2367 const LinkedUniform *uniform = nullptr;
2368 gl::Program *programObject = GetValidProgram(context, program);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002369 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2370 ValidateUniformValue(context, valueType, uniform->type);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002371}
2372
Frank Henigmana98a6472017-02-02 21:38:32 -05002373bool ValidateProgramUniform1iv(gl::Context *context,
2374 GLuint program,
2375 GLint location,
2376 GLsizei count,
2377 const GLint *value)
2378{
2379 // Check for ES31 program uniform entry points
2380 if (context->getClientVersion() < Version(3, 1))
2381 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002382 context->handleError(InvalidOperation());
Frank Henigmana98a6472017-02-02 21:38:32 -05002383 return false;
2384 }
2385
2386 const LinkedUniform *uniform = nullptr;
2387 gl::Program *programObject = GetValidProgram(context, program);
2388 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2389 ValidateUniform1ivValue(context, uniform->type, count, value);
2390}
2391
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002392bool ValidateProgramUniformMatrix(gl::Context *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002393 GLenum valueType,
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002394 GLuint program,
2395 GLint location,
2396 GLsizei count,
2397 GLboolean transpose)
2398{
2399 // Check for ES31 program uniform entry points
2400 if (context->getClientVersion() < Version(3, 1))
2401 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002402 context->handleError(InvalidOperation());
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002403 return false;
2404 }
2405
2406 const LinkedUniform *uniform = nullptr;
2407 gl::Program *programObject = GetValidProgram(context, program);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002408 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2409 ValidateUniformMatrixValue(context, valueType, uniform->type);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002410}
2411
Jamie Madillc1d770e2017-04-13 17:31:24 -04002412bool ValidateUniform(ValidationContext *context, GLenum valueType, GLint location, GLsizei count)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002413{
2414 // Check for ES3 uniform entry points
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002415 if (VariableComponentType(valueType) == GL_UNSIGNED_INT && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002416 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002417 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002418 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002419 }
2420
Jamie Madill62d31cb2015-09-11 13:25:51 -04002421 const LinkedUniform *uniform = nullptr;
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002422 gl::Program *programObject = context->getGLState().getProgram();
2423 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2424 ValidateUniformValue(context, valueType, uniform->type);
Jamie Madillaa981bd2014-05-20 10:55:55 -04002425}
2426
Jamie Madillbe849e42017-05-02 15:49:00 -04002427bool ValidateUniform1iv(ValidationContext *context,
2428 GLint location,
2429 GLsizei count,
2430 const GLint *value)
Frank Henigmana98a6472017-02-02 21:38:32 -05002431{
2432 const LinkedUniform *uniform = nullptr;
2433 gl::Program *programObject = context->getGLState().getProgram();
2434 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2435 ValidateUniform1ivValue(context, uniform->type, count, value);
2436}
2437
Jamie Madillc1d770e2017-04-13 17:31:24 -04002438bool ValidateUniformMatrix(ValidationContext *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002439 GLenum valueType,
He Yunchaoced53ae2016-11-29 15:00:51 +08002440 GLint location,
2441 GLsizei count,
Jamie Madillaa981bd2014-05-20 10:55:55 -04002442 GLboolean transpose)
2443{
2444 // Check for ES3 uniform entry points
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002445 int rows = VariableRowCount(valueType);
2446 int cols = VariableColumnCount(valueType);
Martin Radev1be913c2016-07-11 17:59:16 +03002447 if (rows != cols && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002448 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002449 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002450 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002451 }
2452
Martin Radev1be913c2016-07-11 17:59:16 +03002453 if (transpose != GL_FALSE && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002454 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002455 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002456 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002457 }
2458
Jamie Madill62d31cb2015-09-11 13:25:51 -04002459 const LinkedUniform *uniform = nullptr;
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002460 gl::Program *programObject = context->getGLState().getProgram();
2461 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2462 ValidateUniformMatrixValue(context, valueType, uniform->type);
Jamie Madillaa981bd2014-05-20 10:55:55 -04002463}
2464
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002465bool ValidateStateQuery(ValidationContext *context,
2466 GLenum pname,
2467 GLenum *nativeType,
2468 unsigned int *numParams)
Jamie Madill893ab082014-05-16 16:56:10 -04002469{
2470 if (!context->getQueryParameterInfo(pname, nativeType, numParams))
2471 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002472 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04002473 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002474 }
2475
Jamie Madill0af26e12015-03-05 19:54:33 -05002476 const Caps &caps = context->getCaps();
2477
Jamie Madill893ab082014-05-16 16:56:10 -04002478 if (pname >= GL_DRAW_BUFFER0 && pname <= GL_DRAW_BUFFER15)
2479 {
2480 unsigned int colorAttachment = (pname - GL_DRAW_BUFFER0);
2481
Jamie Madill0af26e12015-03-05 19:54:33 -05002482 if (colorAttachment >= caps.maxDrawBuffers)
Jamie Madill893ab082014-05-16 16:56:10 -04002483 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002484 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002485 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002486 }
2487 }
2488
2489 switch (pname)
2490 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002491 case GL_TEXTURE_BINDING_2D:
2492 case GL_TEXTURE_BINDING_CUBE_MAP:
2493 case GL_TEXTURE_BINDING_3D:
2494 case GL_TEXTURE_BINDING_2D_ARRAY:
JiangYizhou24fe74c2017-07-06 16:56:50 +08002495 case GL_TEXTURE_BINDING_2D_MULTISAMPLE:
He Yunchaoced53ae2016-11-29 15:00:51 +08002496 break;
2497 case GL_TEXTURE_BINDING_EXTERNAL_OES:
2498 if (!context->getExtensions().eglStreamConsumerExternal &&
2499 !context->getExtensions().eglImageExternal)
2500 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002501 context->handleError(InvalidEnum() << "Neither NV_EGL_stream_consumer_external "
2502 "nor GL_OES_EGL_image_external "
2503 "extensions enabled");
He Yunchaoced53ae2016-11-29 15:00:51 +08002504 return false;
2505 }
2506 break;
Jamie Madill893ab082014-05-16 16:56:10 -04002507
He Yunchaoced53ae2016-11-29 15:00:51 +08002508 case GL_IMPLEMENTATION_COLOR_READ_TYPE:
2509 case GL_IMPLEMENTATION_COLOR_READ_FORMAT:
Jamie Madill893ab082014-05-16 16:56:10 -04002510 {
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002511 if (context->getGLState().getReadFramebuffer()->checkStatus(context) !=
2512 GL_FRAMEBUFFER_COMPLETE)
Jamie Madill893ab082014-05-16 16:56:10 -04002513 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002514 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002515 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002516 }
2517
Jamie Madill51f40ec2016-06-15 14:06:00 -04002518 const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer();
2519 ASSERT(framebuffer);
Martin Radev138064f2016-07-15 12:03:41 +03002520
2521 if (framebuffer->getReadBufferState() == GL_NONE)
2522 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002523 context->handleError(InvalidOperation() << "Read buffer is GL_NONE");
Martin Radev138064f2016-07-15 12:03:41 +03002524 return false;
2525 }
2526
Jamie Madillb6bda4a2015-04-20 12:53:26 -04002527 const FramebufferAttachment *attachment = framebuffer->getReadColorbuffer();
Jamie Madill3c7fa222014-06-05 13:08:51 -04002528 if (!attachment)
Jamie Madill893ab082014-05-16 16:56:10 -04002529 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002530 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002531 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002532 }
2533 }
2534 break;
2535
He Yunchaoced53ae2016-11-29 15:00:51 +08002536 default:
2537 break;
Jamie Madill893ab082014-05-16 16:56:10 -04002538 }
2539
2540 // pname is valid, but there are no parameters to return
Geoff Langff5b2d52016-09-07 11:32:23 -04002541 if (*numParams == 0)
2542 {
2543 return false;
2544 }
2545
2546 return true;
2547}
2548
2549bool ValidateRobustStateQuery(ValidationContext *context,
2550 GLenum pname,
2551 GLsizei bufSize,
2552 GLenum *nativeType,
2553 unsigned int *numParams)
2554{
2555 if (!ValidateRobustEntryPoint(context, bufSize))
2556 {
2557 return false;
2558 }
2559
2560 if (!ValidateStateQuery(context, pname, nativeType, numParams))
2561 {
2562 return false;
2563 }
2564
2565 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
Jamie Madill893ab082014-05-16 16:56:10 -04002566 {
2567 return false;
2568 }
2569
2570 return true;
2571}
2572
Jamie Madillc29968b2016-01-20 11:17:23 -05002573bool ValidateCopyTexImageParametersBase(ValidationContext *context,
2574 GLenum target,
2575 GLint level,
2576 GLenum internalformat,
2577 bool isSubImage,
2578 GLint xoffset,
2579 GLint yoffset,
2580 GLint zoffset,
2581 GLint x,
2582 GLint y,
2583 GLsizei width,
2584 GLsizei height,
2585 GLint border,
Jamie Madill0c8abca2016-07-22 20:21:26 -04002586 Format *textureFormatOut)
Jamie Madill560a8d82014-05-21 13:06:20 -04002587{
Brandon Jones6cad5662017-06-14 13:25:13 -07002588 if (xoffset < 0 || yoffset < 0 || zoffset < 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04002589 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002590 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
2591 return false;
2592 }
2593
2594 if (width < 0 || height < 0)
2595 {
2596 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Geoff Langb1196682014-07-23 13:47:29 -04002597 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002598 }
2599
He Yunchaoced53ae2016-11-29 15:00:51 +08002600 if (std::numeric_limits<GLsizei>::max() - xoffset < width ||
2601 std::numeric_limits<GLsizei>::max() - yoffset < height)
Jamie Madill560a8d82014-05-21 13:06:20 -04002602 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002603 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002604 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002605 }
2606
2607 if (border != 0)
2608 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002609 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidBorder);
Geoff Langb1196682014-07-23 13:47:29 -04002610 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002611 }
2612
2613 if (!ValidMipLevel(context, target, level))
2614 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002615 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Geoff Langb1196682014-07-23 13:47:29 -04002616 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002617 }
2618
Jamie Madill51f40ec2016-06-15 14:06:00 -04002619 const auto &state = context->getGLState();
2620 auto readFramebuffer = state.getReadFramebuffer();
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002621 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill560a8d82014-05-21 13:06:20 -04002622 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002623 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002624 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002625 }
2626
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002627 if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04002628 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002629 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002630 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002631 }
2632
Martin Radev138064f2016-07-15 12:03:41 +03002633 if (readFramebuffer->getReadBufferState() == GL_NONE)
2634 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002635 context->handleError(InvalidOperation() << "Read buffer is GL_NONE");
Martin Radev138064f2016-07-15 12:03:41 +03002636 return false;
2637 }
2638
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002639 // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment
2640 // In OpenGL ES it is undefined what happens when an operation tries to read from a missing
He Yunchao66a41a22016-12-15 16:45:05 +08002641 // attachment and WebGL defines it to be an error. We do the check unconditionally as the
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002642 // situation is an application error that would lead to a crash in ANGLE.
Martin Radev04e2c3b2017-07-27 16:54:35 +03002643 const FramebufferAttachment *source = readFramebuffer->getReadColorbuffer();
2644 if (source == nullptr)
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002645 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002646 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment);
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002647 return false;
2648 }
2649
Martin Radev04e2c3b2017-07-27 16:54:35 +03002650 // ANGLE_multiview spec, Revision 1:
2651 // Calling CopyTexSubImage3D, CopyTexImage2D, or CopyTexSubImage2D will result in an
2652 // INVALID_FRAMEBUFFER_OPERATION error if the multi-view layout of the current read framebuffer
2653 // is not NONE.
2654 if (source->getMultiviewLayout() != GL_NONE)
2655 {
2656 context->handleError(InvalidFramebufferOperation()
2657 << "The active read framebuffer object has multiview attachments.");
2658 return false;
2659 }
2660
Geoff Langaae65a42014-05-26 12:43:44 -04002661 const gl::Caps &caps = context->getCaps();
2662
Geoff Langaae65a42014-05-26 12:43:44 -04002663 GLuint maxDimension = 0;
Jamie Madill560a8d82014-05-21 13:06:20 -04002664 switch (target)
2665 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002666 case GL_TEXTURE_2D:
2667 maxDimension = caps.max2DTextureSize;
2668 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002669
He Yunchaoced53ae2016-11-29 15:00:51 +08002670 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
2671 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
2672 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
2673 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
2674 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
2675 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
2676 maxDimension = caps.maxCubeMapTextureSize;
2677 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002678
He Yunchaoced53ae2016-11-29 15:00:51 +08002679 case GL_TEXTURE_2D_ARRAY:
2680 maxDimension = caps.max2DTextureSize;
2681 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002682
He Yunchaoced53ae2016-11-29 15:00:51 +08002683 case GL_TEXTURE_3D:
2684 maxDimension = caps.max3DTextureSize;
2685 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002686
He Yunchaoced53ae2016-11-29 15:00:51 +08002687 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002688 context->handleError(InvalidEnum());
He Yunchaoced53ae2016-11-29 15:00:51 +08002689 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002690 }
2691
Jamie Madillc29968b2016-01-20 11:17:23 -05002692 gl::Texture *texture =
2693 state.getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target);
Jamie Madill560a8d82014-05-21 13:06:20 -04002694 if (!texture)
2695 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002696 ANGLE_VALIDATION_ERR(context, InvalidOperation(), TextureNotBound);
Geoff Langb1196682014-07-23 13:47:29 -04002697 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002698 }
2699
Geoff Lang69cce582015-09-17 13:20:36 -04002700 if (texture->getImmutableFormat() && !isSubImage)
Jamie Madill560a8d82014-05-21 13:06:20 -04002701 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002702 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002703 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002704 }
2705
Geoff Langca271392017-04-05 12:30:00 -04002706 const gl::InternalFormat &formatInfo =
2707 gl::GetInternalFormatInfo(internalformat, GL_UNSIGNED_BYTE);
Geoff Lang5d601382014-07-22 15:14:06 -04002708
Geoff Lang966c9402017-04-18 12:38:27 -04002709 if (formatInfo.depthBits > 0 || formatInfo.compressed)
Jamie Madill560a8d82014-05-21 13:06:20 -04002710 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002711 context->handleError(InvalidOperation());
Geoff Langa9be0dc2014-12-17 12:34:40 -05002712 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002713 }
2714
2715 if (isSubImage)
2716 {
Geoff Langa9be0dc2014-12-17 12:34:40 -05002717 if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) ||
2718 static_cast<size_t>(yoffset + height) > texture->getHeight(target, level) ||
2719 static_cast<size_t>(zoffset) >= texture->getDepth(target, level))
Jamie Madill560a8d82014-05-21 13:06:20 -04002720 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002721 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002722 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002723 }
2724 }
Jamie Madill6f38f822014-06-06 17:12:20 -04002725 else
2726 {
Geoff Lang691e58c2014-12-19 17:03:25 -05002727 if (IsCubeMapTextureTarget(target) && width != height)
Jamie Madill6f38f822014-06-06 17:12:20 -04002728 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002729 ANGLE_VALIDATION_ERR(context, InvalidValue(), CubemapIncomplete);
Geoff Langb1196682014-07-23 13:47:29 -04002730 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002731 }
2732
Geoff Langeb66a6e2016-10-31 13:06:12 -04002733 if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions()))
Jamie Madill6f38f822014-06-06 17:12:20 -04002734 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002735 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langb1196682014-07-23 13:47:29 -04002736 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002737 }
2738
2739 int maxLevelDimension = (maxDimension >> level);
He Yunchaoced53ae2016-11-29 15:00:51 +08002740 if (static_cast<int>(width) > maxLevelDimension ||
2741 static_cast<int>(height) > maxLevelDimension)
Jamie Madill6f38f822014-06-06 17:12:20 -04002742 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002743 ANGLE_VALIDATION_ERR(context, InvalidValue(), ResourceMaxTextureSize);
Geoff Langb1196682014-07-23 13:47:29 -04002744 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002745 }
2746 }
Jamie Madill560a8d82014-05-21 13:06:20 -04002747
Jamie Madill0c8abca2016-07-22 20:21:26 -04002748 if (textureFormatOut)
2749 {
2750 *textureFormatOut = texture->getFormat(target, level);
2751 }
Jamie Madillf695a3a2017-01-11 17:36:35 -05002752
2753 // Detect texture copying feedback loops for WebGL.
2754 if (context->getExtensions().webglCompatibility)
2755 {
Jamie Madillfd3dd432017-02-02 19:59:59 -05002756 if (readFramebuffer->formsCopyingFeedbackLoopWith(texture->id(), level, zoffset))
Jamie Madillf695a3a2017-01-11 17:36:35 -05002757 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002758 context->handleError(InvalidOperation() << "Texture copying feedback loop formed "
2759 "between Framebuffer and specified "
2760 "Texture level.");
Jamie Madillf695a3a2017-01-11 17:36:35 -05002761 return false;
2762 }
2763 }
2764
Jamie Madill560a8d82014-05-21 13:06:20 -04002765 return true;
2766}
2767
Jiajia Qind9671222016-11-29 16:30:31 +08002768bool ValidateDrawBase(ValidationContext *context, GLenum mode, GLsizei count)
Jamie Madill250d33f2014-06-06 17:09:03 -04002769{
Jamie Madill1aeb1312014-06-20 13:21:25 -04002770 switch (mode)
2771 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002772 case GL_POINTS:
2773 case GL_LINES:
2774 case GL_LINE_LOOP:
2775 case GL_LINE_STRIP:
2776 case GL_TRIANGLES:
2777 case GL_TRIANGLE_STRIP:
2778 case GL_TRIANGLE_FAN:
2779 break;
2780 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002781 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidDrawMode);
He Yunchaoced53ae2016-11-29 15:00:51 +08002782 return false;
Jamie Madill1aeb1312014-06-20 13:21:25 -04002783 }
2784
Jamie Madill250d33f2014-06-06 17:09:03 -04002785 if (count < 0)
2786 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002787 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Geoff Langb1196682014-07-23 13:47:29 -04002788 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002789 }
2790
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002791 const State &state = context->getGLState();
Geoff Langb1196682014-07-23 13:47:29 -04002792
Jamie Madill250d33f2014-06-06 17:09:03 -04002793 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002794 if (state.hasMappedBuffer(GL_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04002795 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002796 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002797 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002798 }
2799
Jamie Madillcbcde722017-01-06 14:50:00 -05002800 // Note: these separate values are not supported in WebGL, due to D3D's limitations. See
2801 // Section 6.10 of the WebGL 1.0 spec.
Jamie Madill51f40ec2016-06-15 14:06:00 -04002802 Framebuffer *framebuffer = state.getDrawFramebuffer();
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002803 if (context->getLimitations().noSeparateStencilRefsAndMasks ||
2804 context->getExtensions().webglCompatibility)
Jamie Madillac528012014-06-20 13:21:23 -04002805 {
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002806 const FramebufferAttachment *dsAttachment =
2807 framebuffer->getStencilOrDepthStencilAttachment();
2808 GLuint stencilBits = dsAttachment ? dsAttachment->getStencilSize() : 0;
He Yunchaoced53ae2016-11-29 15:00:51 +08002809 GLuint minimumRequiredStencilMask = (1 << stencilBits) - 1;
Jinyoung Hur85769f02015-10-20 17:08:44 -04002810 const DepthStencilState &depthStencilState = state.getDepthStencilState();
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002811
2812 bool differentRefs = state.getStencilRef() != state.getStencilBackRef();
2813 bool differentWritemasks =
2814 (depthStencilState.stencilWritemask & minimumRequiredStencilMask) !=
2815 (depthStencilState.stencilBackWritemask & minimumRequiredStencilMask);
2816 bool differentMasks = (depthStencilState.stencilMask & minimumRequiredStencilMask) !=
2817 (depthStencilState.stencilBackMask & minimumRequiredStencilMask);
2818
2819 if (differentRefs || differentWritemasks || differentMasks)
Geoff Lang3a86ad32015-09-01 11:47:05 -04002820 {
Jamie Madillcbcde722017-01-06 14:50:00 -05002821 if (!context->getExtensions().webglCompatibility)
2822 {
Yuly Novikovd73f8522017-01-13 17:48:57 -05002823 ERR() << "This ANGLE implementation does not support separate front/back stencil "
2824 "writemasks, reference values, or stencil mask values.";
Jamie Madillcbcde722017-01-06 14:50:00 -05002825 }
Brandon Jones6cad5662017-06-14 13:25:13 -07002826 ANGLE_VALIDATION_ERR(context, InvalidOperation(), StencilReferenceMaskOrMismatch);
Geoff Lang3a86ad32015-09-01 11:47:05 -04002827 return false;
2828 }
Jamie Madillac528012014-06-20 13:21:23 -04002829 }
2830
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002831 if (framebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill13f7d7d2014-06-20 13:21:27 -04002832 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002833 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002834 return false;
Jamie Madill13f7d7d2014-06-20 13:21:27 -04002835 }
2836
Geoff Lang7dd2e102014-11-10 15:19:26 -05002837 gl::Program *program = state.getProgram();
2838 if (!program)
Jamie Madilld4cfa572014-07-08 10:00:32 -04002839 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002840 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotBound);
Geoff Langb1196682014-07-23 13:47:29 -04002841 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04002842 }
2843
Yunchao Hef81ce4a2017-04-24 10:49:17 +08002844 if (!program->validateSamplers(nullptr, context->getCaps()))
Jamie Madilld4cfa572014-07-08 10:00:32 -04002845 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002846 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002847 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04002848 }
2849
Martin Radev7cf61662017-07-26 17:10:53 +03002850 if (context->getExtensions().multiview)
2851 {
Martin Radev7e69f762017-07-27 14:54:13 +03002852 const int programNumViews = program->getNumViews();
2853 const int framebufferNumViews = framebuffer->getNumViews();
2854 if (programNumViews != -1 && framebufferNumViews != programNumViews)
Martin Radev7cf61662017-07-26 17:10:53 +03002855 {
2856 context->handleError(InvalidOperation() << "The number of views in the active program "
2857 "and draw framebuffer does not match.");
2858 return false;
2859 }
Martin Radev7e69f762017-07-27 14:54:13 +03002860
2861 const TransformFeedback *transformFeedbackObject = state.getCurrentTransformFeedback();
2862 if (transformFeedbackObject != nullptr && transformFeedbackObject->isActive() &&
2863 framebufferNumViews > 1)
2864 {
2865 context->handleError(InvalidOperation()
2866 << "There is an active transform feedback object "
2867 "when the number of views in the active draw "
2868 "framebuffer is greater than 1.");
2869 return false;
2870 }
Martin Radev7cf61662017-07-26 17:10:53 +03002871 }
2872
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002873 // Uniform buffer validation
He Yunchaoced53ae2016-11-29 15:00:51 +08002874 for (unsigned int uniformBlockIndex = 0;
2875 uniformBlockIndex < program->getActiveUniformBlockCount(); uniformBlockIndex++)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002876 {
Jamie Madill62d31cb2015-09-11 13:25:51 -04002877 const gl::UniformBlock &uniformBlock = program->getUniformBlockByIndex(uniformBlockIndex);
He Yunchaoced53ae2016-11-29 15:00:51 +08002878 GLuint blockBinding = program->getUniformBlockBinding(uniformBlockIndex);
Geoff Lang5d124a62015-09-15 13:03:27 -04002879 const OffsetBindingPointer<Buffer> &uniformBuffer =
2880 state.getIndexedUniformBuffer(blockBinding);
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002881
Geoff Lang5d124a62015-09-15 13:03:27 -04002882 if (uniformBuffer.get() == nullptr)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002883 {
2884 // undefined behaviour
Jamie Madill437fa652016-05-03 15:13:24 -04002885 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002886 InvalidOperation()
2887 << "It is undefined behaviour to have a used but unbound uniform buffer.");
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002888 return false;
2889 }
2890
Geoff Lang5d124a62015-09-15 13:03:27 -04002891 size_t uniformBufferSize = uniformBuffer.getSize();
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002892 if (uniformBufferSize == 0)
2893 {
2894 // Bind the whole buffer.
Minmin Gong794e0002015-04-07 18:31:54 -07002895 uniformBufferSize = static_cast<size_t>(uniformBuffer->getSize());
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002896 }
2897
Jamie Madill62d31cb2015-09-11 13:25:51 -04002898 if (uniformBufferSize < uniformBlock.dataSize)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002899 {
2900 // undefined behaviour
Jamie Madill437fa652016-05-03 15:13:24 -04002901 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002902 InvalidOperation()
2903 << "It is undefined behaviour to use a uniform buffer that is too small.");
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002904 return false;
2905 }
2906 }
2907
Geoff Lange0cff192017-05-30 13:04:56 -04002908 // Do some additonal WebGL-specific validation
Jamie Madilla4595b82017-01-11 17:36:34 -05002909 if (context->getExtensions().webglCompatibility)
2910 {
Geoff Lange0cff192017-05-30 13:04:56 -04002911 // Detect rendering feedback loops for WebGL.
Jamie Madilla4595b82017-01-11 17:36:34 -05002912 if (framebuffer->formsRenderingFeedbackLoopWith(state))
2913 {
2914 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002915 InvalidOperation()
2916 << "Rendering feedback loop formed between Framebuffer and active Texture.");
Jamie Madilla4595b82017-01-11 17:36:34 -05002917 return false;
2918 }
Geoff Lange0cff192017-05-30 13:04:56 -04002919
Geoff Lang9ab5b822017-05-30 16:19:23 -04002920 // Detect that the vertex shader input types match the attribute types
2921 if (!ValidateVertexShaderAttributeTypeMatch(context))
2922 {
2923 return false;
2924 }
2925
Geoff Lange0cff192017-05-30 13:04:56 -04002926 // Detect that the color buffer types match the fragment shader output types
2927 if (!ValidateFragmentShaderColorBufferTypeMatch(context))
2928 {
2929 return false;
2930 }
Jamie Madilla4595b82017-01-11 17:36:34 -05002931 }
2932
Jamie Madill250d33f2014-06-06 17:09:03 -04002933 // No-op if zero count
2934 return (count > 0);
2935}
2936
Jamie Madillc1d770e2017-04-13 17:31:24 -04002937bool ValidateDrawArraysCommon(ValidationContext *context,
2938 GLenum mode,
2939 GLint first,
2940 GLsizei count,
2941 GLsizei primcount)
Jamie Madill250d33f2014-06-06 17:09:03 -04002942{
Jamie Madillfd716582014-06-06 17:09:04 -04002943 if (first < 0)
Jamie Madill250d33f2014-06-06 17:09:03 -04002944 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002945 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeStart);
Geoff Langb1196682014-07-23 13:47:29 -04002946 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002947 }
2948
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002949 const State &state = context->getGLState();
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002950 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
He Yunchaoced53ae2016-11-29 15:00:51 +08002951 if (curTransformFeedback && curTransformFeedback->isActive() &&
2952 !curTransformFeedback->isPaused() && curTransformFeedback->getPrimitiveMode() != mode)
Jamie Madillfd716582014-06-06 17:09:04 -04002953 {
2954 // It is an invalid operation to call DrawArrays or DrawArraysInstanced with a draw mode
He Yunchaoced53ae2016-11-29 15:00:51 +08002955 // that does not match the current transform feedback object's draw mode (if transform
2956 // feedback
Jamie Madillfd716582014-06-06 17:09:04 -04002957 // is active), (3.0.2, section 2.14, pg 86)
Brandon Jones6cad5662017-06-14 13:25:13 -07002958 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidDrawModeTransformFeedback);
Geoff Langb1196682014-07-23 13:47:29 -04002959 return false;
Jamie Madillfd716582014-06-06 17:09:04 -04002960 }
2961
Jiajia Qind9671222016-11-29 16:30:31 +08002962 if (!ValidateDrawBase(context, mode, count))
Corentin Wallez18a2fb32015-08-10 12:58:14 -07002963 {
2964 return false;
2965 }
2966
Corentin Wallez71168a02016-12-19 15:11:18 -08002967 // Check the computation of maxVertex doesn't overflow.
2968 // - first < 0 or count < 0 have been checked as an error condition
2969 // - count > 0 has been checked in ValidateDrawBase as it makes the call a noop
2970 // From this we know maxVertex will be positive, and only need to check if it overflows GLint.
2971 ASSERT(count > 0 && first >= 0);
2972 int64_t maxVertex = static_cast<int64_t>(first) + static_cast<int64_t>(count) - 1;
2973 if (maxVertex > static_cast<int64_t>(std::numeric_limits<GLint>::max()))
Corentin Wallez92db6942016-12-09 13:10:36 -05002974 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002975 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallez92db6942016-12-09 13:10:36 -05002976 return false;
2977 }
2978
Corentin Wallez71168a02016-12-19 15:11:18 -08002979 if (!ValidateDrawAttribs(context, primcount, static_cast<GLint>(maxVertex), count))
Jamie Madillfd716582014-06-06 17:09:04 -04002980 {
2981 return false;
2982 }
2983
2984 return true;
2985}
2986
He Yunchaoced53ae2016-11-29 15:00:51 +08002987bool ValidateDrawArraysInstanced(Context *context,
2988 GLenum mode,
2989 GLint first,
2990 GLsizei count,
2991 GLsizei primcount)
Jamie Madillfd716582014-06-06 17:09:04 -04002992{
Corentin Wallez0dc97812017-06-22 14:38:44 -04002993 return ValidateDrawArraysInstancedBase(context, mode, first, count, primcount);
Geoff Lang87a93302014-09-16 13:29:43 -04002994}
2995
He Yunchaoced53ae2016-11-29 15:00:51 +08002996bool ValidateDrawArraysInstancedANGLE(Context *context,
2997 GLenum mode,
2998 GLint first,
2999 GLsizei count,
3000 GLsizei primcount)
Geoff Lang87a93302014-09-16 13:29:43 -04003001{
Corentin Wallez170efbf2017-05-02 13:45:01 -04003002 if (!ValidateDrawArraysInstancedBase(context, mode, first, count, primcount))
Geoff Lang87a93302014-09-16 13:29:43 -04003003 {
3004 return false;
3005 }
3006
Corentin Wallez0dc97812017-06-22 14:38:44 -04003007 return ValidateDrawInstancedANGLE(context);
Geoff Lang87a93302014-09-16 13:29:43 -04003008}
3009
Jiajia Qind9671222016-11-29 16:30:31 +08003010bool ValidateDrawElementsBase(ValidationContext *context, GLenum type)
Jamie Madillfd716582014-06-06 17:09:04 -04003011{
Jamie Madill250d33f2014-06-06 17:09:03 -04003012 switch (type)
3013 {
He Yunchaoced53ae2016-11-29 15:00:51 +08003014 case GL_UNSIGNED_BYTE:
3015 case GL_UNSIGNED_SHORT:
3016 break;
3017 case GL_UNSIGNED_INT:
3018 if (context->getClientMajorVersion() < 3 && !context->getExtensions().elementIndexUint)
3019 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003020 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte);
He Yunchaoced53ae2016-11-29 15:00:51 +08003021 return false;
3022 }
3023 break;
3024 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003025 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte);
He Yunchaoced53ae2016-11-29 15:00:51 +08003026 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04003027 }
3028
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003029 const State &state = context->getGLState();
Jamie Madilld9ba4f72014-08-04 10:47:59 -04003030
3031 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
He Yunchaoced53ae2016-11-29 15:00:51 +08003032 if (curTransformFeedback && curTransformFeedback->isActive() &&
3033 !curTransformFeedback->isPaused())
Jamie Madill250d33f2014-06-06 17:09:03 -04003034 {
He Yunchaoced53ae2016-11-29 15:00:51 +08003035 // It is an invalid operation to call DrawElements, DrawRangeElements or
3036 // DrawElementsInstanced
Jamie Madill250d33f2014-06-06 17:09:03 -04003037 // while transform feedback is active, (3.0.2, section 2.14, pg 86)
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003038 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04003039 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04003040 }
3041
Jiajia Qind9671222016-11-29 16:30:31 +08003042 return true;
3043}
3044
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003045bool ValidateDrawElementsCommon(ValidationContext *context,
3046 GLenum mode,
3047 GLsizei count,
3048 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04003049 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003050 GLsizei primcount)
Jiajia Qind9671222016-11-29 16:30:31 +08003051{
3052 if (!ValidateDrawElementsBase(context, type))
3053 return false;
3054
3055 const State &state = context->getGLState();
3056
Corentin Wallez170efbf2017-05-02 13:45:01 -04003057 if (!ValidateDrawBase(context, mode, count))
3058 {
3059 return false;
3060 }
3061
Jamie Madill250d33f2014-06-06 17:09:03 -04003062 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04003063 if (state.hasMappedBuffer(GL_ELEMENT_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04003064 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003065 context->handleError(InvalidOperation() << "Index buffer is mapped.");
Geoff Langb1196682014-07-23 13:47:29 -04003066 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04003067 }
3068
He Yunchaoced53ae2016-11-29 15:00:51 +08003069 const gl::VertexArray *vao = state.getVertexArray();
Jamie Madill8e344942015-07-09 14:22:07 -04003070 gl::Buffer *elementArrayBuffer = vao->getElementArrayBuffer().get();
Jamie Madilld4cfa572014-07-08 10:00:32 -04003071
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003072 GLuint typeBytes = gl::GetTypeInfo(type).bytes;
3073
3074 if (context->getExtensions().webglCompatibility)
3075 {
3076 ASSERT(isPow2(typeBytes) && typeBytes > 0);
3077 if ((reinterpret_cast<uintptr_t>(indices) & static_cast<uintptr_t>(typeBytes - 1)) != 0)
3078 {
3079 // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements
3080 // The offset arguments to drawElements and [...], must be a multiple of the size of the
3081 // data type passed to the call, or an INVALID_OPERATION error is generated.
Brandon Jones6cad5662017-06-14 13:25:13 -07003082 ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType);
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003083 return false;
3084 }
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003085
3086 // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements
3087 // In addition the offset argument to drawElements must be non-negative or an INVALID_VALUE
3088 // error is generated.
3089 if (reinterpret_cast<intptr_t>(indices) < 0)
3090 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003091 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003092 return false;
3093 }
Geoff Langfeb8c682017-02-13 16:07:35 -05003094 }
3095
3096 if (context->getExtensions().webglCompatibility ||
3097 !context->getGLState().areClientArraysEnabled())
3098 {
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003099 if (!elementArrayBuffer && count > 0)
3100 {
3101 // [WebGL 1.0] Section 6.2 No Client Side Arrays
3102 // If drawElements is called with a count greater than zero, and no WebGLBuffer is bound
3103 // to the ELEMENT_ARRAY_BUFFER binding point, an INVALID_OPERATION error is generated.
Brandon Jones6cad5662017-06-14 13:25:13 -07003104 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MustHaveElementArrayBinding);
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05003105 return false;
3106 }
3107 }
3108
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003109 if (count > 0)
Jamie Madillae3000b2014-08-25 15:47:51 -04003110 {
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003111 if (elementArrayBuffer)
Jamie Madillae3000b2014-08-25 15:47:51 -04003112 {
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003113 // The max possible type size is 8 and count is on 32 bits so doing the multiplication
3114 // in a 64 bit integer is safe. Also we are guaranteed that here count > 0.
3115 static_assert(std::is_same<int, GLsizei>::value, "GLsizei isn't the expected type");
3116 constexpr uint64_t kMaxTypeSize = 8;
3117 constexpr uint64_t kIntMax = std::numeric_limits<int>::max();
3118 constexpr uint64_t kUint64Max = std::numeric_limits<uint64_t>::max();
3119 static_assert(kIntMax < kUint64Max / kMaxTypeSize, "");
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003120
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003121 uint64_t typeSize = typeBytes;
3122 uint64_t elementCount = static_cast<uint64_t>(count);
3123 ASSERT(elementCount > 0 && typeSize <= kMaxTypeSize);
3124
3125 // Doing the multiplication here is overflow-safe
3126 uint64_t elementDataSizeNoOffset = typeSize * elementCount;
3127
3128 // The offset can be any value, check for overflows
3129 uint64_t offset = static_cast<uint64_t>(reinterpret_cast<uintptr_t>(indices));
3130 if (elementDataSizeNoOffset > kUint64Max - offset)
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003131 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003132 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003133 return false;
3134 }
3135
Corentin Wallezfe9306a2017-02-01 17:41:05 -05003136 uint64_t elementDataSizeWithOffset = elementDataSizeNoOffset + offset;
3137 if (elementDataSizeWithOffset > static_cast<uint64_t>(elementArrayBuffer->getSize()))
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003138 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003139 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Corentin Wallez0844f2d2017-01-31 17:02:59 -05003140 return false;
3141 }
3142 }
3143 else if (!indices)
3144 {
3145 // This is an application error that would normally result in a crash,
3146 // but we catch it and return an error
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003147 context->handleError(InvalidOperation() << "No element array buffer and no pointer.");
Geoff Langb1196682014-07-23 13:47:29 -04003148 return false;
Jamie Madillae3000b2014-08-25 15:47:51 -04003149 }
Jamie Madillae3000b2014-08-25 15:47:51 -04003150 }
3151
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003152 // Use the parameter buffer to retrieve and cache the index range.
Jamie Madill2b976812014-08-25 15:47:49 -04003153 // TODO: offer fast path, with disabled index validation.
3154 // TODO: also disable index checking on back-ends that are robust to out-of-range accesses.
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003155 const auto &params = context->getParams<HasIndexRange>();
3156 const auto &indexRangeOpt = params.getIndexRange();
3157 if (!indexRangeOpt.valid())
Jamie Madill2b976812014-08-25 15:47:49 -04003158 {
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003159 // Unexpected error.
3160 return false;
Jamie Madill2b976812014-08-25 15:47:49 -04003161 }
3162
Jamie Madille79b1e12015-11-04 16:36:37 -05003163 // If we use an index greater than our maximum supported index range, return an error.
3164 // The ES3 spec does not specify behaviour here, it is undefined, but ANGLE should always
3165 // return an error if possible here.
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003166 if (static_cast<GLuint64>(indexRangeOpt.value().end) >= context->getCaps().maxElementIndex)
Jamie Madille79b1e12015-11-04 16:36:37 -05003167 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003168 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExceedsMaxElement);
Jamie Madille79b1e12015-11-04 16:36:37 -05003169 return false;
3170 }
3171
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003172 if (!ValidateDrawAttribs(context, primcount, static_cast<GLint>(indexRangeOpt.value().end),
3173 static_cast<GLint>(indexRangeOpt.value().vertexCount())))
Jamie Madillfd716582014-06-06 17:09:04 -04003174 {
3175 return false;
3176 }
3177
Geoff Lang3edfe032015-09-04 16:38:24 -04003178 // No op if there are no real indices in the index data (all are primitive restart).
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003179 return (indexRangeOpt.value().vertexIndexCount > 0);
Jamie Madillfd716582014-06-06 17:09:04 -04003180}
3181
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003182bool ValidateDrawElementsInstancedCommon(ValidationContext *context,
3183 GLenum mode,
3184 GLsizei count,
3185 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04003186 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003187 GLsizei primcount)
Jamie Madillfd716582014-06-06 17:09:04 -04003188{
Corentin Wallez0dc97812017-06-22 14:38:44 -04003189 return ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount);
Jamie Madill250d33f2014-06-06 17:09:03 -04003190}
3191
Geoff Lang3edfe032015-09-04 16:38:24 -04003192bool ValidateDrawElementsInstancedANGLE(Context *context,
3193 GLenum mode,
3194 GLsizei count,
3195 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04003196 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04003197 GLsizei primcount)
Geoff Lang87a93302014-09-16 13:29:43 -04003198{
Corentin Wallez170efbf2017-05-02 13:45:01 -04003199 if (!ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount))
Geoff Lang87a93302014-09-16 13:29:43 -04003200 {
3201 return false;
3202 }
3203
Corentin Wallez0dc97812017-06-22 14:38:44 -04003204 return ValidateDrawInstancedANGLE(context);
Geoff Lang87a93302014-09-16 13:29:43 -04003205}
3206
He Yunchaoced53ae2016-11-29 15:00:51 +08003207bool ValidateFramebufferTextureBase(Context *context,
3208 GLenum target,
3209 GLenum attachment,
3210 GLuint texture,
3211 GLint level)
Jamie Madill570f7c82014-07-03 10:38:54 -04003212{
Jamie Madill55ec3b12014-07-03 10:38:57 -04003213 if (!ValidFramebufferTarget(target))
3214 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003215 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04003216 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003217 }
3218
3219 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill570f7c82014-07-03 10:38:54 -04003220 {
3221 return false;
3222 }
3223
Jamie Madill55ec3b12014-07-03 10:38:57 -04003224 if (texture != 0)
3225 {
3226 gl::Texture *tex = context->getTexture(texture);
3227
Jamie Madillbe849e42017-05-02 15:49:00 -04003228 if (tex == NULL)
Jamie Madill55ec3b12014-07-03 10:38:57 -04003229 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003230 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04003231 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003232 }
3233
3234 if (level < 0)
3235 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003236 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04003237 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003238 }
3239 }
3240
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003241 const gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
Jamie Madill84115c92015-04-23 15:00:07 -04003242 ASSERT(framebuffer);
Jamie Madill55ec3b12014-07-03 10:38:57 -04003243
Jamie Madill84115c92015-04-23 15:00:07 -04003244 if (framebuffer->id() == 0)
Jamie Madill55ec3b12014-07-03 10:38:57 -04003245 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003246 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04003247 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003248 }
3249
3250 return true;
3251}
3252
Geoff Langb1196682014-07-23 13:47:29 -04003253bool ValidateGetUniformBase(Context *context, GLuint program, GLint location)
Jamie Madill0063c512014-08-25 15:47:53 -04003254{
3255 if (program == 0)
3256 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003257 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04003258 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003259 }
3260
Dian Xiang769769a2015-09-09 15:20:08 -07003261 gl::Program *programObject = GetValidProgram(context, program);
3262 if (!programObject)
Shannon Woods4de4fd62014-11-07 16:22:02 -05003263 {
3264 return false;
3265 }
3266
Jamie Madill0063c512014-08-25 15:47:53 -04003267 if (!programObject || !programObject->isLinked())
3268 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003269 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Geoff Langb1196682014-07-23 13:47:29 -04003270 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003271 }
3272
Geoff Lang7dd2e102014-11-10 15:19:26 -05003273 if (!programObject->isValidUniformLocation(location))
Jamie Madill549c7fd2014-08-25 15:47:56 -04003274 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003275 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04003276 return false;
Jamie Madill549c7fd2014-08-25 15:47:56 -04003277 }
3278
Jamie Madill0063c512014-08-25 15:47:53 -04003279 return true;
3280}
3281
Geoff Langf41d0ee2016-10-07 13:04:23 -04003282static bool ValidateSizedGetUniform(Context *context,
3283 GLuint program,
3284 GLint location,
3285 GLsizei bufSize,
3286 GLsizei *length)
Jamie Madill78f41802014-08-25 15:47:55 -04003287{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003288 if (length)
3289 {
3290 *length = 0;
3291 }
3292
Jamie Madill78f41802014-08-25 15:47:55 -04003293 if (!ValidateGetUniformBase(context, program, location))
Jamie Madill0063c512014-08-25 15:47:53 -04003294 {
Jamie Madill78f41802014-08-25 15:47:55 -04003295 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003296 }
3297
Geoff Langf41d0ee2016-10-07 13:04:23 -04003298 if (bufSize < 0)
3299 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003300 context->handleError(InvalidValue() << "bufSize cannot be negative.");
Geoff Langf41d0ee2016-10-07 13:04:23 -04003301 return false;
3302 }
3303
Jamie Madilla502c742014-08-28 17:19:13 -04003304 gl::Program *programObject = context->getProgram(program);
3305 ASSERT(programObject);
Jamie Madill0063c512014-08-25 15:47:53 -04003306
Jamie Madill78f41802014-08-25 15:47:55 -04003307 // sized queries -- ensure the provided buffer is large enough
Jamie Madill62d31cb2015-09-11 13:25:51 -04003308 const LinkedUniform &uniform = programObject->getUniformByLocation(location);
He Yunchaoced53ae2016-11-29 15:00:51 +08003309 size_t requiredBytes = VariableExternalSize(uniform.type);
Jamie Madill78f41802014-08-25 15:47:55 -04003310 if (static_cast<size_t>(bufSize) < requiredBytes)
Jamie Madill0063c512014-08-25 15:47:53 -04003311 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003312 context->handleError(InvalidOperation()
3313 << "bufSize of at least " << requiredBytes << " is required.");
Geoff Langb1196682014-07-23 13:47:29 -04003314 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003315 }
3316
Geoff Langf41d0ee2016-10-07 13:04:23 -04003317 if (length)
3318 {
Geoff Lang94177fb2016-11-14 16:12:26 -05003319 *length = VariableComponentCount(uniform.type);
Geoff Langf41d0ee2016-10-07 13:04:23 -04003320 }
3321
Jamie Madill0063c512014-08-25 15:47:53 -04003322 return true;
3323}
3324
He Yunchaoced53ae2016-11-29 15:00:51 +08003325bool ValidateGetnUniformfvEXT(Context *context,
3326 GLuint program,
3327 GLint location,
3328 GLsizei bufSize,
3329 GLfloat *params)
Jamie Madill0063c512014-08-25 15:47:53 -04003330{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003331 return ValidateSizedGetUniform(context, program, location, bufSize, nullptr);
Jamie Madill0063c512014-08-25 15:47:53 -04003332}
3333
He Yunchaoced53ae2016-11-29 15:00:51 +08003334bool ValidateGetnUniformivEXT(Context *context,
3335 GLuint program,
3336 GLint location,
3337 GLsizei bufSize,
3338 GLint *params)
Jamie Madill0063c512014-08-25 15:47:53 -04003339{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003340 return ValidateSizedGetUniform(context, program, location, bufSize, nullptr);
3341}
3342
3343bool ValidateGetUniformfvRobustANGLE(Context *context,
3344 GLuint program,
3345 GLint location,
3346 GLsizei bufSize,
3347 GLsizei *length,
3348 GLfloat *params)
3349{
3350 if (!ValidateRobustEntryPoint(context, bufSize))
3351 {
3352 return false;
3353 }
3354
3355 // bufSize is validated in ValidateSizedGetUniform
3356 return ValidateSizedGetUniform(context, program, location, bufSize, length);
3357}
3358
3359bool ValidateGetUniformivRobustANGLE(Context *context,
3360 GLuint program,
3361 GLint location,
3362 GLsizei bufSize,
3363 GLsizei *length,
3364 GLint *params)
3365{
3366 if (!ValidateRobustEntryPoint(context, bufSize))
3367 {
3368 return false;
3369 }
3370
3371 // bufSize is validated in ValidateSizedGetUniform
3372 return ValidateSizedGetUniform(context, program, location, bufSize, length);
3373}
3374
3375bool ValidateGetUniformuivRobustANGLE(Context *context,
3376 GLuint program,
3377 GLint location,
3378 GLsizei bufSize,
3379 GLsizei *length,
3380 GLuint *params)
3381{
3382 if (!ValidateRobustEntryPoint(context, bufSize))
3383 {
3384 return false;
3385 }
3386
3387 if (context->getClientMajorVersion() < 3)
3388 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003389 context->handleError(InvalidOperation() << "Entry point requires at least OpenGL ES 3.0.");
Geoff Langf41d0ee2016-10-07 13:04:23 -04003390 return false;
3391 }
3392
3393 // bufSize is validated in ValidateSizedGetUniform
3394 return ValidateSizedGetUniform(context, program, location, bufSize, length);
Jamie Madill0063c512014-08-25 15:47:53 -04003395}
3396
He Yunchaoced53ae2016-11-29 15:00:51 +08003397bool ValidateDiscardFramebufferBase(Context *context,
3398 GLenum target,
3399 GLsizei numAttachments,
3400 const GLenum *attachments,
3401 bool defaultFramebuffer)
Austin Kinross08332632015-05-05 13:35:47 -07003402{
3403 if (numAttachments < 0)
3404 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003405 context->handleError(InvalidValue() << "numAttachments must not be less than zero");
Austin Kinross08332632015-05-05 13:35:47 -07003406 return false;
3407 }
3408
3409 for (GLsizei i = 0; i < numAttachments; ++i)
3410 {
Olli Etuaho84c9f592016-03-09 14:37:25 +02003411 if (attachments[i] >= GL_COLOR_ATTACHMENT0 && attachments[i] <= GL_COLOR_ATTACHMENT31)
Austin Kinross08332632015-05-05 13:35:47 -07003412 {
3413 if (defaultFramebuffer)
3414 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003415 context->handleError(InvalidEnum()
3416 << "Invalid attachment when the default framebuffer is bound");
Austin Kinross08332632015-05-05 13:35:47 -07003417 return false;
3418 }
3419
3420 if (attachments[i] >= GL_COLOR_ATTACHMENT0 + context->getCaps().maxColorAttachments)
3421 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003422 context->handleError(InvalidOperation() << "Requested color attachment is "
3423 "greater than the maximum supported "
3424 "color attachments");
Austin Kinross08332632015-05-05 13:35:47 -07003425 return false;
3426 }
3427 }
3428 else
3429 {
3430 switch (attachments[i])
3431 {
He Yunchaoced53ae2016-11-29 15:00:51 +08003432 case GL_DEPTH_ATTACHMENT:
3433 case GL_STENCIL_ATTACHMENT:
3434 case GL_DEPTH_STENCIL_ATTACHMENT:
3435 if (defaultFramebuffer)
3436 {
3437 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003438 InvalidEnum()
3439 << "Invalid attachment when the default framebuffer is bound");
He Yunchaoced53ae2016-11-29 15:00:51 +08003440 return false;
3441 }
3442 break;
3443 case GL_COLOR:
3444 case GL_DEPTH:
3445 case GL_STENCIL:
3446 if (!defaultFramebuffer)
3447 {
3448 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003449 InvalidEnum()
3450 << "Invalid attachment when the default framebuffer is not bound");
He Yunchaoced53ae2016-11-29 15:00:51 +08003451 return false;
3452 }
3453 break;
3454 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003455 context->handleError(InvalidEnum() << "Invalid attachment");
Austin Kinross08332632015-05-05 13:35:47 -07003456 return false;
Austin Kinross08332632015-05-05 13:35:47 -07003457 }
3458 }
3459 }
3460
3461 return true;
3462}
3463
Austin Kinross6ee1e782015-05-29 17:05:37 -07003464bool ValidateInsertEventMarkerEXT(Context *context, GLsizei length, const char *marker)
3465{
3466 // Note that debug marker calls must not set error state
3467
3468 if (length < 0)
3469 {
3470 return false;
3471 }
3472
3473 if (marker == nullptr)
3474 {
3475 return false;
3476 }
3477
3478 return true;
3479}
3480
3481bool ValidatePushGroupMarkerEXT(Context *context, GLsizei length, const char *marker)
3482{
3483 // Note that debug marker calls must not set error state
3484
3485 if (length < 0)
3486 {
3487 return false;
3488 }
3489
3490 if (length > 0 && marker == nullptr)
3491 {
3492 return false;
3493 }
3494
3495 return true;
3496}
3497
Geoff Langdcab33b2015-07-21 13:03:16 -04003498bool ValidateEGLImageTargetTexture2DOES(Context *context,
Geoff Langdcab33b2015-07-21 13:03:16 -04003499 GLenum target,
3500 egl::Image *image)
3501{
Geoff Langa8406172015-07-21 16:53:39 -04003502 if (!context->getExtensions().eglImage && !context->getExtensions().eglImageExternal)
3503 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003504 context->handleError(InvalidOperation());
Geoff Langa8406172015-07-21 16:53:39 -04003505 return false;
3506 }
3507
3508 switch (target)
3509 {
3510 case GL_TEXTURE_2D:
Geoff Langb66a9092016-05-16 15:59:14 -04003511 if (!context->getExtensions().eglImage)
3512 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003513 context->handleError(InvalidEnum()
3514 << "GL_TEXTURE_2D texture target requires GL_OES_EGL_image.");
Geoff Langb66a9092016-05-16 15:59:14 -04003515 }
3516 break;
3517
3518 case GL_TEXTURE_EXTERNAL_OES:
3519 if (!context->getExtensions().eglImageExternal)
3520 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003521 context->handleError(InvalidEnum() << "GL_TEXTURE_EXTERNAL_OES texture target "
3522 "requires GL_OES_EGL_image_external.");
Geoff Langb66a9092016-05-16 15:59:14 -04003523 }
Geoff Langa8406172015-07-21 16:53:39 -04003524 break;
3525
3526 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003527 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Geoff Langa8406172015-07-21 16:53:39 -04003528 return false;
3529 }
3530
Jamie Madill61e16b42017-06-19 11:13:23 -04003531 ASSERT(context->getCurrentDisplay());
3532 if (!context->getCurrentDisplay()->isValidImage(image))
Geoff Langa8406172015-07-21 16:53:39 -04003533 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003534 context->handleError(InvalidValue() << "EGL image is not valid.");
Geoff Langa8406172015-07-21 16:53:39 -04003535 return false;
3536 }
3537
3538 if (image->getSamples() > 0)
3539 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003540 context->handleError(InvalidOperation()
3541 << "cannot create a 2D texture from a multisampled EGL image.");
Geoff Langa8406172015-07-21 16:53:39 -04003542 return false;
3543 }
3544
Geoff Langca271392017-04-05 12:30:00 -04003545 const TextureCaps &textureCaps =
3546 context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat);
Geoff Langa8406172015-07-21 16:53:39 -04003547 if (!textureCaps.texturable)
3548 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003549 context->handleError(InvalidOperation()
3550 << "EGL image internal format is not supported as a texture.");
Geoff Langa8406172015-07-21 16:53:39 -04003551 return false;
3552 }
3553
Geoff Langdcab33b2015-07-21 13:03:16 -04003554 return true;
3555}
3556
3557bool ValidateEGLImageTargetRenderbufferStorageOES(Context *context,
Geoff Langdcab33b2015-07-21 13:03:16 -04003558 GLenum target,
3559 egl::Image *image)
3560{
Geoff Langa8406172015-07-21 16:53:39 -04003561 if (!context->getExtensions().eglImage)
3562 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003563 context->handleError(InvalidOperation());
Geoff Langa8406172015-07-21 16:53:39 -04003564 return false;
3565 }
3566
3567 switch (target)
3568 {
3569 case GL_RENDERBUFFER:
3570 break;
3571
3572 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003573 context->handleError(InvalidEnum() << "invalid renderbuffer target.");
Geoff Langa8406172015-07-21 16:53:39 -04003574 return false;
3575 }
3576
Jamie Madill61e16b42017-06-19 11:13:23 -04003577 ASSERT(context->getCurrentDisplay());
3578 if (!context->getCurrentDisplay()->isValidImage(image))
Geoff Langa8406172015-07-21 16:53:39 -04003579 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003580 context->handleError(InvalidValue() << "EGL image is not valid.");
Geoff Langa8406172015-07-21 16:53:39 -04003581 return false;
3582 }
3583
Geoff Langca271392017-04-05 12:30:00 -04003584 const TextureCaps &textureCaps =
3585 context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat);
Geoff Langa8406172015-07-21 16:53:39 -04003586 if (!textureCaps.renderable)
3587 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003588 context->handleError(InvalidOperation()
3589 << "EGL image internal format is not supported as a renderbuffer.");
Geoff Langa8406172015-07-21 16:53:39 -04003590 return false;
3591 }
3592
Geoff Langdcab33b2015-07-21 13:03:16 -04003593 return true;
3594}
Austin Kinrossbc781f32015-10-26 09:27:38 -07003595
3596bool ValidateBindVertexArrayBase(Context *context, GLuint array)
3597{
Geoff Lang36167ab2015-12-07 10:27:14 -05003598 if (!context->isVertexArrayGenerated(array))
Austin Kinrossbc781f32015-10-26 09:27:38 -07003599 {
3600 // The default VAO should always exist
3601 ASSERT(array != 0);
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003602 context->handleError(InvalidOperation());
Austin Kinrossbc781f32015-10-26 09:27:38 -07003603 return false;
3604 }
3605
3606 return true;
3607}
3608
Geoff Langc5629752015-12-07 16:29:04 -05003609bool ValidateProgramBinaryBase(Context *context,
3610 GLuint program,
3611 GLenum binaryFormat,
3612 const void *binary,
3613 GLint length)
3614{
3615 Program *programObject = GetValidProgram(context, program);
3616 if (programObject == nullptr)
3617 {
3618 return false;
3619 }
3620
3621 const std::vector<GLenum> &programBinaryFormats = context->getCaps().programBinaryFormats;
3622 if (std::find(programBinaryFormats.begin(), programBinaryFormats.end(), binaryFormat) ==
3623 programBinaryFormats.end())
3624 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003625 context->handleError(InvalidEnum() << "Program binary format is not valid.");
Geoff Langc5629752015-12-07 16:29:04 -05003626 return false;
3627 }
3628
Olli Etuahoc3e55a42016-03-09 16:29:18 +02003629 if (context->hasActiveTransformFeedback(program))
3630 {
3631 // ES 3.0.4 section 2.15 page 91
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003632 context->handleError(InvalidOperation() << "Cannot change program binary while program "
3633 "is associated with an active transform "
3634 "feedback object.");
Olli Etuahoc3e55a42016-03-09 16:29:18 +02003635 return false;
3636 }
3637
Geoff Langc5629752015-12-07 16:29:04 -05003638 return true;
3639}
3640
3641bool ValidateGetProgramBinaryBase(Context *context,
3642 GLuint program,
3643 GLsizei bufSize,
3644 GLsizei *length,
3645 GLenum *binaryFormat,
3646 void *binary)
3647{
3648 Program *programObject = GetValidProgram(context, program);
3649 if (programObject == nullptr)
3650 {
3651 return false;
3652 }
3653
3654 if (!programObject->isLinked())
3655 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003656 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Geoff Langc5629752015-12-07 16:29:04 -05003657 return false;
3658 }
3659
Jamie Madilla7d12dc2016-12-13 15:08:19 -05003660 if (context->getCaps().programBinaryFormats.empty())
3661 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003662 context->handleError(InvalidOperation() << "No program binary formats supported.");
Jamie Madilla7d12dc2016-12-13 15:08:19 -05003663 return false;
3664 }
3665
Geoff Langc5629752015-12-07 16:29:04 -05003666 return true;
3667}
Jamie Madillc29968b2016-01-20 11:17:23 -05003668
Jamie Madillc29968b2016-01-20 11:17:23 -05003669bool ValidateDrawBuffersBase(ValidationContext *context, GLsizei n, const GLenum *bufs)
3670{
3671 // INVALID_VALUE is generated if n is negative or greater than value of MAX_DRAW_BUFFERS
3672 if (n < 0 || static_cast<GLuint>(n) > context->getCaps().maxDrawBuffers)
3673 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003674 context->handleError(InvalidValue()
3675 << "n must be non-negative and no greater than MAX_DRAW_BUFFERS");
Jamie Madillc29968b2016-01-20 11:17:23 -05003676 return false;
3677 }
3678
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003679 ASSERT(context->getGLState().getDrawFramebuffer());
3680 GLuint frameBufferId = context->getGLState().getDrawFramebuffer()->id();
Jamie Madillc29968b2016-01-20 11:17:23 -05003681 GLuint maxColorAttachment = GL_COLOR_ATTACHMENT0_EXT + context->getCaps().maxColorAttachments;
3682
3683 // This should come first before the check for the default frame buffer
3684 // because when we switch to ES3.1+, invalid enums will return INVALID_ENUM
3685 // rather than INVALID_OPERATION
3686 for (int colorAttachment = 0; colorAttachment < n; colorAttachment++)
3687 {
3688 const GLenum attachment = GL_COLOR_ATTACHMENT0_EXT + colorAttachment;
3689
3690 if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != GL_BACK &&
Olli Etuaho84c9f592016-03-09 14:37:25 +02003691 (bufs[colorAttachment] < GL_COLOR_ATTACHMENT0 ||
3692 bufs[colorAttachment] > GL_COLOR_ATTACHMENT31))
Jamie Madillc29968b2016-01-20 11:17:23 -05003693 {
3694 // Value in bufs is not NONE, BACK, or GL_COLOR_ATTACHMENTi
Olli Etuaho84c9f592016-03-09 14:37:25 +02003695 // The 3.0.4 spec says to generate GL_INVALID_OPERATION here, but this
3696 // was changed to GL_INVALID_ENUM in 3.1, which dEQP also expects.
3697 // 3.1 is still a bit ambiguous about the error, but future specs are
3698 // expected to clarify that GL_INVALID_ENUM is the correct error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003699 context->handleError(InvalidEnum() << "Invalid buffer value");
Olli Etuaho84c9f592016-03-09 14:37:25 +02003700 return false;
3701 }
3702 else if (bufs[colorAttachment] >= maxColorAttachment)
3703 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003704 context->handleError(InvalidOperation()
3705 << "Buffer value is greater than MAX_DRAW_BUFFERS");
Jamie Madillc29968b2016-01-20 11:17:23 -05003706 return false;
3707 }
3708 else if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != attachment &&
3709 frameBufferId != 0)
3710 {
3711 // INVALID_OPERATION-GL is bound to buffer and ith argument
3712 // is not COLOR_ATTACHMENTi or NONE
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003713 context->handleError(InvalidOperation()
3714 << "Ith value does not match COLOR_ATTACHMENTi or NONE");
Jamie Madillc29968b2016-01-20 11:17:23 -05003715 return false;
3716 }
3717 }
3718
3719 // INVALID_OPERATION is generated if GL is bound to the default framebuffer
3720 // and n is not 1 or bufs is bound to value other than BACK and NONE
3721 if (frameBufferId == 0)
3722 {
3723 if (n != 1)
3724 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003725 context->handleError(InvalidOperation()
3726 << "n must be 1 when GL is bound to the default framebuffer");
Jamie Madillc29968b2016-01-20 11:17:23 -05003727 return false;
3728 }
3729
3730 if (bufs[0] != GL_NONE && bufs[0] != GL_BACK)
3731 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003732 context->handleError(
3733 InvalidOperation()
3734 << "Only NONE or BACK are valid values when drawing to the default framebuffer");
Jamie Madillc29968b2016-01-20 11:17:23 -05003735 return false;
3736 }
3737 }
3738
3739 return true;
3740}
3741
Geoff Lang496c02d2016-10-20 11:38:11 -07003742bool ValidateGetBufferPointervBase(Context *context,
3743 GLenum target,
3744 GLenum pname,
3745 GLsizei *length,
3746 void **params)
Olli Etuaho4f667482016-03-30 15:56:35 +03003747{
Geoff Lang496c02d2016-10-20 11:38:11 -07003748 if (length)
3749 {
3750 *length = 0;
3751 }
3752
3753 if (context->getClientMajorVersion() < 3 && !context->getExtensions().mapBuffer)
3754 {
3755 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003756 InvalidOperation()
3757 << "Context does not support OpenGL ES 3.0 or GL_OES_mapbuffer is not enabled.");
Geoff Lang496c02d2016-10-20 11:38:11 -07003758 return false;
3759 }
3760
Olli Etuaho4f667482016-03-30 15:56:35 +03003761 if (!ValidBufferTarget(context, target))
3762 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003763 context->handleError(InvalidEnum() << "Buffer target not valid: 0x" << std::hex
3764 << std::uppercase << target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003765 return false;
3766 }
3767
Geoff Lang496c02d2016-10-20 11:38:11 -07003768 switch (pname)
Olli Etuaho4f667482016-03-30 15:56:35 +03003769 {
Geoff Lang496c02d2016-10-20 11:38:11 -07003770 case GL_BUFFER_MAP_POINTER:
3771 break;
Olli Etuaho4f667482016-03-30 15:56:35 +03003772
Geoff Lang496c02d2016-10-20 11:38:11 -07003773 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003774 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang496c02d2016-10-20 11:38:11 -07003775 return false;
3776 }
Olli Etuaho4f667482016-03-30 15:56:35 +03003777
3778 // GLES 3.0 section 2.10.1: "Attempts to attempts to modify or query buffer object state for a
3779 // target bound to zero generate an INVALID_OPERATION error."
3780 // GLES 3.1 section 6.6 explicitly specifies this error.
Geoff Lang496c02d2016-10-20 11:38:11 -07003781 if (context->getGLState().getTargetBuffer(target) == nullptr)
Olli Etuaho4f667482016-03-30 15:56:35 +03003782 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003783 context->handleError(InvalidOperation()
3784 << "Can not get pointer for reserved buffer name zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003785 return false;
3786 }
3787
Geoff Lang496c02d2016-10-20 11:38:11 -07003788 if (length)
3789 {
3790 *length = 1;
3791 }
3792
Olli Etuaho4f667482016-03-30 15:56:35 +03003793 return true;
3794}
3795
3796bool ValidateUnmapBufferBase(Context *context, GLenum target)
3797{
3798 if (!ValidBufferTarget(context, target))
3799 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003800 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003801 return false;
3802 }
3803
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003804 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003805
3806 if (buffer == nullptr || !buffer->isMapped())
3807 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003808 context->handleError(InvalidOperation() << "Buffer not mapped.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003809 return false;
3810 }
3811
3812 return true;
3813}
3814
3815bool ValidateMapBufferRangeBase(Context *context,
3816 GLenum target,
3817 GLintptr offset,
3818 GLsizeiptr length,
3819 GLbitfield access)
3820{
3821 if (!ValidBufferTarget(context, target))
3822 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003823 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003824 return false;
3825 }
3826
Brandon Jones6cad5662017-06-14 13:25:13 -07003827 if (offset < 0)
Olli Etuaho4f667482016-03-30 15:56:35 +03003828 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003829 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
3830 return false;
3831 }
3832
3833 if (length < 0)
3834 {
3835 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength);
Olli Etuaho4f667482016-03-30 15:56:35 +03003836 return false;
3837 }
3838
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003839 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003840
3841 if (!buffer)
3842 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003843 context->handleError(InvalidOperation() << "Attempted to map buffer object zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003844 return false;
3845 }
3846
3847 // Check for buffer overflow
Jamie Madille2e406c2016-06-02 13:04:10 -04003848 CheckedNumeric<size_t> checkedOffset(offset);
3849 auto checkedSize = checkedOffset + length;
Olli Etuaho4f667482016-03-30 15:56:35 +03003850
Jamie Madille2e406c2016-06-02 13:04:10 -04003851 if (!checkedSize.IsValid() || checkedSize.ValueOrDie() > static_cast<size_t>(buffer->getSize()))
Olli Etuaho4f667482016-03-30 15:56:35 +03003852 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003853 context->handleError(InvalidValue() << "Mapped range does not fit into buffer dimensions.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003854 return false;
3855 }
3856
3857 // Check for invalid bits in the mask
3858 GLbitfield allAccessBits = GL_MAP_READ_BIT | GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_RANGE_BIT |
3859 GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_FLUSH_EXPLICIT_BIT |
3860 GL_MAP_UNSYNCHRONIZED_BIT;
3861
3862 if (access & ~(allAccessBits))
3863 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003864 context->handleError(InvalidValue()
3865 << "Invalid access bits: 0x" << std::hex << std::uppercase << access);
Olli Etuaho4f667482016-03-30 15:56:35 +03003866 return false;
3867 }
3868
3869 if (length == 0)
3870 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003871 context->handleError(InvalidOperation() << "Buffer mapping length is zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003872 return false;
3873 }
3874
3875 if (buffer->isMapped())
3876 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003877 context->handleError(InvalidOperation() << "Buffer is already mapped.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003878 return false;
3879 }
3880
3881 // Check for invalid bit combinations
3882 if ((access & (GL_MAP_READ_BIT | GL_MAP_WRITE_BIT)) == 0)
3883 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003884 context->handleError(InvalidOperation()
3885 << "Need to map buffer for either reading or writing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003886 return false;
3887 }
3888
3889 GLbitfield writeOnlyBits =
3890 GL_MAP_INVALIDATE_RANGE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_UNSYNCHRONIZED_BIT;
3891
3892 if ((access & GL_MAP_READ_BIT) != 0 && (access & writeOnlyBits) != 0)
3893 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003894 context->handleError(InvalidOperation()
3895 << "Invalid access bits when mapping buffer for reading: 0x"
3896 << std::hex << std::uppercase << access);
Olli Etuaho4f667482016-03-30 15:56:35 +03003897 return false;
3898 }
3899
3900 if ((access & GL_MAP_WRITE_BIT) == 0 && (access & GL_MAP_FLUSH_EXPLICIT_BIT) != 0)
3901 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003902 context->handleError(
3903 InvalidOperation()
3904 << "The explicit flushing bit may only be set if the buffer is mapped for writing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003905 return false;
3906 }
3907 return true;
3908}
3909
3910bool ValidateFlushMappedBufferRangeBase(Context *context,
3911 GLenum target,
3912 GLintptr offset,
3913 GLsizeiptr length)
3914{
Brandon Jones6cad5662017-06-14 13:25:13 -07003915 if (offset < 0)
Olli Etuaho4f667482016-03-30 15:56:35 +03003916 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003917 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
3918 return false;
3919 }
3920
3921 if (length < 0)
3922 {
3923 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength);
Olli Etuaho4f667482016-03-30 15:56:35 +03003924 return false;
3925 }
3926
3927 if (!ValidBufferTarget(context, target))
3928 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003929 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003930 return false;
3931 }
3932
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003933 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003934
3935 if (buffer == nullptr)
3936 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003937 context->handleError(InvalidOperation() << "Attempted to flush buffer object zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003938 return false;
3939 }
3940
3941 if (!buffer->isMapped() || (buffer->getAccessFlags() & GL_MAP_FLUSH_EXPLICIT_BIT) == 0)
3942 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003943 context->handleError(InvalidOperation()
3944 << "Attempted to flush a buffer not mapped for explicit flushing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003945 return false;
3946 }
3947
3948 // Check for buffer overflow
Jamie Madille2e406c2016-06-02 13:04:10 -04003949 CheckedNumeric<size_t> checkedOffset(offset);
3950 auto checkedSize = checkedOffset + length;
Olli Etuaho4f667482016-03-30 15:56:35 +03003951
Jamie Madille2e406c2016-06-02 13:04:10 -04003952 if (!checkedSize.IsValid() ||
3953 checkedSize.ValueOrDie() > static_cast<size_t>(buffer->getMapLength()))
Olli Etuaho4f667482016-03-30 15:56:35 +03003954 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003955 context->handleError(InvalidValue()
3956 << "Flushed range does not fit into buffer mapping dimensions.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003957 return false;
3958 }
3959
3960 return true;
3961}
3962
Olli Etuaho41997e72016-03-10 13:38:39 +02003963bool ValidateGenOrDelete(Context *context, GLint n)
3964{
3965 if (n < 0)
3966 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003967 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Olli Etuaho41997e72016-03-10 13:38:39 +02003968 return false;
3969 }
3970 return true;
3971}
3972
Geoff Langff5b2d52016-09-07 11:32:23 -04003973bool ValidateRobustEntryPoint(ValidationContext *context, GLsizei bufSize)
3974{
3975 if (!context->getExtensions().robustClientMemory)
3976 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003977 context->handleError(InvalidOperation()
3978 << "GL_ANGLE_robust_client_memory is not available.");
Geoff Langff5b2d52016-09-07 11:32:23 -04003979 return false;
3980 }
3981
3982 if (bufSize < 0)
3983 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003984 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Geoff Langff5b2d52016-09-07 11:32:23 -04003985 return false;
3986 }
3987
3988 return true;
3989}
3990
Geoff Lang2e43dbb2016-10-14 12:27:35 -04003991bool ValidateRobustBufferSize(ValidationContext *context, GLsizei bufSize, GLsizei numParams)
3992{
3993 if (bufSize < numParams)
3994 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003995 context->handleError(InvalidOperation() << numParams << " parameters are required but "
3996 << bufSize << " were provided.");
Geoff Lang2e43dbb2016-10-14 12:27:35 -04003997 return false;
3998 }
3999
4000 return true;
4001}
4002
Jamie Madillbe849e42017-05-02 15:49:00 -04004003bool ValidateGetFramebufferAttachmentParameterivBase(ValidationContext *context,
4004 GLenum target,
4005 GLenum attachment,
4006 GLenum pname,
4007 GLsizei *numParams)
Geoff Langff5b2d52016-09-07 11:32:23 -04004008{
Geoff Langff5b2d52016-09-07 11:32:23 -04004009 if (!ValidFramebufferTarget(target))
4010 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004011 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004012 return false;
4013 }
4014
4015 int clientVersion = context->getClientMajorVersion();
4016
4017 switch (pname)
4018 {
4019 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
4020 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
4021 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL:
4022 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE:
4023 break;
4024
Martin Radeve5285d22017-07-14 16:23:53 +03004025 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_NUM_VIEWS_ANGLE:
4026 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_MULTIVIEW_LAYOUT_ANGLE:
4027 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_BASE_VIEW_INDEX_ANGLE:
4028 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE:
4029 if (clientVersion < 3 || !context->getExtensions().multiview)
4030 {
4031 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
4032 return false;
4033 }
4034 break;
4035
Geoff Langff5b2d52016-09-07 11:32:23 -04004036 case GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING:
4037 if (clientVersion < 3 && !context->getExtensions().sRGB)
4038 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004039 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004040 return false;
4041 }
4042 break;
4043
4044 case GL_FRAMEBUFFER_ATTACHMENT_RED_SIZE:
4045 case GL_FRAMEBUFFER_ATTACHMENT_GREEN_SIZE:
4046 case GL_FRAMEBUFFER_ATTACHMENT_BLUE_SIZE:
4047 case GL_FRAMEBUFFER_ATTACHMENT_ALPHA_SIZE:
4048 case GL_FRAMEBUFFER_ATTACHMENT_DEPTH_SIZE:
4049 case GL_FRAMEBUFFER_ATTACHMENT_STENCIL_SIZE:
4050 case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:
4051 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:
4052 if (clientVersion < 3)
4053 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004054 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004055 return false;
4056 }
4057 break;
4058
4059 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004060 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004061 return false;
4062 }
4063
4064 // Determine if the attachment is a valid enum
4065 switch (attachment)
4066 {
4067 case GL_BACK:
4068 case GL_FRONT:
4069 case GL_DEPTH:
4070 case GL_STENCIL:
4071 case GL_DEPTH_STENCIL_ATTACHMENT:
4072 if (clientVersion < 3)
4073 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004074 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004075 return false;
4076 }
4077 break;
4078
4079 case GL_DEPTH_ATTACHMENT:
4080 case GL_STENCIL_ATTACHMENT:
4081 break;
4082
4083 default:
4084 if (attachment < GL_COLOR_ATTACHMENT0_EXT ||
4085 (attachment - GL_COLOR_ATTACHMENT0_EXT) >= context->getCaps().maxColorAttachments)
4086 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004087 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04004088 return false;
4089 }
4090 break;
4091 }
4092
4093 const Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
4094 ASSERT(framebuffer);
4095
4096 if (framebuffer->id() == 0)
4097 {
4098 if (clientVersion < 3)
4099 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004100 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langff5b2d52016-09-07 11:32:23 -04004101 return false;
4102 }
4103
4104 switch (attachment)
4105 {
4106 case GL_BACK:
4107 case GL_DEPTH:
4108 case GL_STENCIL:
4109 break;
4110
4111 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004112 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FramebufferInvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004113 return false;
4114 }
4115 }
4116 else
4117 {
4118 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
4119 {
4120 // Valid attachment query
4121 }
4122 else
4123 {
4124 switch (attachment)
4125 {
4126 case GL_DEPTH_ATTACHMENT:
4127 case GL_STENCIL_ATTACHMENT:
4128 break;
4129
4130 case GL_DEPTH_STENCIL_ATTACHMENT:
4131 if (!framebuffer->hasValidDepthStencil())
4132 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004133 context->handleError(InvalidOperation());
Geoff Langff5b2d52016-09-07 11:32:23 -04004134 return false;
4135 }
4136 break;
4137
4138 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004139 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FramebufferInvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004140 return false;
4141 }
4142 }
4143 }
4144
4145 const FramebufferAttachment *attachmentObject = framebuffer->getAttachment(attachment);
4146 if (attachmentObject)
4147 {
4148 ASSERT(attachmentObject->type() == GL_RENDERBUFFER ||
4149 attachmentObject->type() == GL_TEXTURE ||
4150 attachmentObject->type() == GL_FRAMEBUFFER_DEFAULT);
4151
4152 switch (pname)
4153 {
4154 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
4155 if (attachmentObject->type() != GL_RENDERBUFFER &&
4156 attachmentObject->type() != GL_TEXTURE)
4157 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004158 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004159 return false;
4160 }
4161 break;
4162
4163 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL:
4164 if (attachmentObject->type() != GL_TEXTURE)
4165 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004166 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004167 return false;
4168 }
4169 break;
4170
4171 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE:
4172 if (attachmentObject->type() != GL_TEXTURE)
4173 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004174 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004175 return false;
4176 }
4177 break;
4178
4179 case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:
4180 if (attachment == GL_DEPTH_STENCIL_ATTACHMENT)
4181 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004182 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FramebufferInvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004183 return false;
4184 }
4185 break;
4186
4187 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:
4188 if (attachmentObject->type() != GL_TEXTURE)
4189 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004190 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04004191 return false;
4192 }
4193 break;
4194
4195 default:
4196 break;
4197 }
4198 }
4199 else
4200 {
4201 // ES 2.0.25 spec pg 127 states that if the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE
4202 // is NONE, then querying any other pname will generate INVALID_ENUM.
4203
4204 // ES 3.0.2 spec pg 235 states that if the attachment type is none,
4205 // GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME will return zero and be an
4206 // INVALID_OPERATION for all other pnames
4207
4208 switch (pname)
4209 {
4210 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
4211 break;
4212
4213 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
4214 if (clientVersion < 3)
4215 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004216 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
4217 InvalidRenderbufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004218 return false;
4219 }
4220 break;
4221
4222 default:
4223 if (clientVersion < 3)
4224 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004225 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
4226 InvalidRenderbufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004227 return false;
4228 }
4229 else
4230 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004231 ANGLE_VALIDATION_ERR(context, InvalidOperation(),
4232 InvalidRenderbufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004233 return false;
4234 }
4235 }
4236 }
4237
Martin Radeve5285d22017-07-14 16:23:53 +03004238 if (numParams)
4239 {
4240 if (pname == GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE)
4241 {
4242 // Only when the viewport offsets are queried we can have a varying number of output
4243 // parameters.
4244 const int numViews = attachmentObject ? attachmentObject->getNumViews() : 1;
4245 *numParams = numViews * 2;
4246 }
4247 else
4248 {
4249 // For all other queries we can have only one output parameter.
4250 *numParams = 1;
4251 }
4252 }
4253
Geoff Langff5b2d52016-09-07 11:32:23 -04004254 return true;
4255}
4256
4257bool ValidateGetFramebufferAttachmentParameterivRobustANGLE(ValidationContext *context,
4258 GLenum target,
4259 GLenum attachment,
4260 GLenum pname,
4261 GLsizei bufSize,
4262 GLsizei *numParams)
4263{
4264 if (!ValidateRobustEntryPoint(context, bufSize))
4265 {
4266 return false;
4267 }
4268
Jamie Madillbe849e42017-05-02 15:49:00 -04004269 if (!ValidateGetFramebufferAttachmentParameterivBase(context, target, attachment, pname,
4270 numParams))
Geoff Langff5b2d52016-09-07 11:32:23 -04004271 {
4272 return false;
4273 }
4274
4275 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
4276 {
4277 return false;
4278 }
4279
4280 return true;
4281}
4282
Geoff Langff5b2d52016-09-07 11:32:23 -04004283bool ValidateGetBufferParameterivRobustANGLE(ValidationContext *context,
4284 GLenum target,
4285 GLenum pname,
4286 GLsizei bufSize,
Geoff Langebebe1c2016-10-14 12:01:31 -04004287 GLsizei *length,
4288 GLint *params)
Geoff Langff5b2d52016-09-07 11:32:23 -04004289{
4290 if (!ValidateRobustEntryPoint(context, bufSize))
4291 {
4292 return false;
4293 }
4294
Geoff Langebebe1c2016-10-14 12:01:31 -04004295 if (!ValidateGetBufferParameterBase(context, target, pname, false, length))
Geoff Langff5b2d52016-09-07 11:32:23 -04004296 {
4297 return false;
4298 }
4299
Geoff Langebebe1c2016-10-14 12:01:31 -04004300 if (!ValidateRobustBufferSize(context, bufSize, *length))
4301 {
4302 return false;
4303 }
4304
4305 return true;
4306}
4307
4308bool ValidateGetBufferParameteri64v(ValidationContext *context,
4309 GLenum target,
4310 GLenum pname,
4311 GLint64 *params)
4312{
4313 return ValidateGetBufferParameterBase(context, target, pname, false, nullptr);
4314}
4315
4316bool ValidateGetBufferParameteri64vRobustANGLE(ValidationContext *context,
4317 GLenum target,
4318 GLenum pname,
4319 GLsizei bufSize,
4320 GLsizei *length,
4321 GLint64 *params)
4322{
4323 if (!ValidateRobustEntryPoint(context, bufSize))
4324 {
4325 return false;
4326 }
4327
4328 if (!ValidateGetBufferParameterBase(context, target, pname, false, length))
4329 {
4330 return false;
4331 }
4332
4333 if (!ValidateRobustBufferSize(context, bufSize, *length))
Geoff Langff5b2d52016-09-07 11:32:23 -04004334 {
4335 return false;
4336 }
4337
4338 return true;
4339}
4340
Jamie Madillbe849e42017-05-02 15:49:00 -04004341bool ValidateGetProgramivBase(ValidationContext *context,
4342 GLuint program,
4343 GLenum pname,
4344 GLsizei *numParams)
Geoff Langff5b2d52016-09-07 11:32:23 -04004345{
4346 // Currently, all GetProgramiv queries return 1 parameter
Yunchao He33151a52017-04-13 09:58:17 +08004347 if (numParams)
4348 {
4349 *numParams = 1;
4350 }
Geoff Langff5b2d52016-09-07 11:32:23 -04004351
4352 Program *programObject = GetValidProgram(context, program);
4353 if (!programObject)
4354 {
4355 return false;
4356 }
4357
4358 switch (pname)
4359 {
4360 case GL_DELETE_STATUS:
4361 case GL_LINK_STATUS:
4362 case GL_VALIDATE_STATUS:
4363 case GL_INFO_LOG_LENGTH:
4364 case GL_ATTACHED_SHADERS:
4365 case GL_ACTIVE_ATTRIBUTES:
4366 case GL_ACTIVE_ATTRIBUTE_MAX_LENGTH:
4367 case GL_ACTIVE_UNIFORMS:
4368 case GL_ACTIVE_UNIFORM_MAX_LENGTH:
4369 break;
4370
4371 case GL_PROGRAM_BINARY_LENGTH:
4372 if (context->getClientMajorVersion() < 3 && !context->getExtensions().getProgramBinary)
4373 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004374 context->handleError(InvalidEnum() << "Querying GL_PROGRAM_BINARY_LENGTH "
4375 "requires GL_OES_get_program_binary or "
4376 "ES 3.0.");
Geoff Langff5b2d52016-09-07 11:32:23 -04004377 return false;
4378 }
4379 break;
4380
4381 case GL_ACTIVE_UNIFORM_BLOCKS:
4382 case GL_ACTIVE_UNIFORM_BLOCK_MAX_NAME_LENGTH:
4383 case GL_TRANSFORM_FEEDBACK_BUFFER_MODE:
4384 case GL_TRANSFORM_FEEDBACK_VARYINGS:
4385 case GL_TRANSFORM_FEEDBACK_VARYING_MAX_LENGTH:
4386 case GL_PROGRAM_BINARY_RETRIEVABLE_HINT:
4387 if (context->getClientMajorVersion() < 3)
4388 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004389 context->handleError(InvalidEnum() << "Querying requires at least ES 3.0.");
Geoff Langff5b2d52016-09-07 11:32:23 -04004390 return false;
4391 }
4392 break;
4393
Yunchao He61afff12017-03-14 15:34:03 +08004394 case GL_PROGRAM_SEPARABLE:
4395 if (context->getClientVersion() < Version(3, 1))
4396 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004397 context->handleError(InvalidEnum() << "Querying requires at least ES 3.1.");
Yunchao He61afff12017-03-14 15:34:03 +08004398 return false;
4399 }
4400 break;
4401
Geoff Langff5b2d52016-09-07 11:32:23 -04004402 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004403 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langff5b2d52016-09-07 11:32:23 -04004404 return false;
4405 }
4406
4407 return true;
4408}
4409
4410bool ValidateGetProgramivRobustANGLE(Context *context,
4411 GLuint program,
4412 GLenum pname,
4413 GLsizei bufSize,
4414 GLsizei *numParams)
4415{
4416 if (!ValidateRobustEntryPoint(context, bufSize))
4417 {
4418 return false;
4419 }
4420
Jamie Madillbe849e42017-05-02 15:49:00 -04004421 if (!ValidateGetProgramivBase(context, program, pname, numParams))
Geoff Langff5b2d52016-09-07 11:32:23 -04004422 {
4423 return false;
4424 }
4425
4426 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
4427 {
4428 return false;
4429 }
4430
4431 return true;
4432}
4433
Geoff Lang740d9022016-10-07 11:20:52 -04004434bool ValidateGetRenderbufferParameterivRobustANGLE(Context *context,
4435 GLenum target,
4436 GLenum pname,
4437 GLsizei bufSize,
4438 GLsizei *length,
4439 GLint *params)
4440{
4441 if (!ValidateRobustEntryPoint(context, bufSize))
4442 {
4443 return false;
4444 }
4445
4446 if (!ValidateGetRenderbufferParameterivBase(context, target, pname, length))
4447 {
4448 return false;
4449 }
4450
4451 if (!ValidateRobustBufferSize(context, bufSize, *length))
4452 {
4453 return false;
4454 }
4455
4456 return true;
4457}
4458
Geoff Langd7d0ed32016-10-07 11:33:51 -04004459bool ValidateGetShaderivRobustANGLE(Context *context,
4460 GLuint shader,
4461 GLenum pname,
4462 GLsizei bufSize,
4463 GLsizei *length,
4464 GLint *params)
4465{
4466 if (!ValidateRobustEntryPoint(context, bufSize))
4467 {
4468 return false;
4469 }
4470
4471 if (!ValidateGetShaderivBase(context, shader, pname, length))
4472 {
4473 return false;
4474 }
4475
4476 if (!ValidateRobustBufferSize(context, bufSize, *length))
4477 {
4478 return false;
4479 }
4480
4481 return true;
4482}
4483
Geoff Langc1984ed2016-10-07 12:41:00 -04004484bool ValidateGetTexParameterfvRobustANGLE(Context *context,
4485 GLenum target,
4486 GLenum pname,
4487 GLsizei bufSize,
4488 GLsizei *length,
4489 GLfloat *params)
4490{
4491 if (!ValidateRobustEntryPoint(context, bufSize))
4492 {
4493 return false;
4494 }
4495
4496 if (!ValidateGetTexParameterBase(context, target, pname, length))
4497 {
4498 return false;
4499 }
4500
4501 if (!ValidateRobustBufferSize(context, bufSize, *length))
4502 {
4503 return false;
4504 }
4505
4506 return true;
4507}
4508
Geoff Langc1984ed2016-10-07 12:41:00 -04004509bool ValidateGetTexParameterivRobustANGLE(Context *context,
4510 GLenum target,
4511 GLenum pname,
4512 GLsizei bufSize,
4513 GLsizei *length,
4514 GLint *params)
4515{
4516 if (!ValidateRobustEntryPoint(context, bufSize))
4517 {
4518 return false;
4519 }
4520
4521 if (!ValidateGetTexParameterBase(context, target, pname, length))
4522 {
4523 return false;
4524 }
4525
4526 if (!ValidateRobustBufferSize(context, bufSize, *length))
4527 {
4528 return false;
4529 }
4530
4531 return true;
4532}
4533
Geoff Langc1984ed2016-10-07 12:41:00 -04004534bool ValidateTexParameterfvRobustANGLE(Context *context,
4535 GLenum target,
4536 GLenum pname,
4537 GLsizei bufSize,
4538 const GLfloat *params)
4539{
4540 if (!ValidateRobustEntryPoint(context, bufSize))
4541 {
4542 return false;
4543 }
4544
4545 return ValidateTexParameterBase(context, target, pname, bufSize, params);
4546}
4547
Geoff Langc1984ed2016-10-07 12:41:00 -04004548bool ValidateTexParameterivRobustANGLE(Context *context,
4549 GLenum target,
4550 GLenum pname,
4551 GLsizei bufSize,
4552 const GLint *params)
4553{
4554 if (!ValidateRobustEntryPoint(context, bufSize))
4555 {
4556 return false;
4557 }
4558
4559 return ValidateTexParameterBase(context, target, pname, bufSize, params);
4560}
4561
4562bool ValidateGetSamplerParameterfv(Context *context, GLuint sampler, GLenum pname, GLfloat *params)
4563{
4564 return ValidateGetSamplerParameterBase(context, sampler, pname, nullptr);
4565}
4566
4567bool ValidateGetSamplerParameterfvRobustANGLE(Context *context,
4568 GLuint sampler,
4569 GLenum pname,
4570 GLuint bufSize,
4571 GLsizei *length,
4572 GLfloat *params)
4573{
4574 if (!ValidateRobustEntryPoint(context, bufSize))
4575 {
4576 return false;
4577 }
4578
4579 if (!ValidateGetSamplerParameterBase(context, sampler, pname, length))
4580 {
4581 return false;
4582 }
4583
4584 if (!ValidateRobustBufferSize(context, bufSize, *length))
4585 {
4586 return false;
4587 }
4588
4589 return true;
4590}
4591
4592bool ValidateGetSamplerParameteriv(Context *context, GLuint sampler, GLenum pname, GLint *params)
4593{
4594 return ValidateGetSamplerParameterBase(context, sampler, pname, nullptr);
4595}
4596
4597bool ValidateGetSamplerParameterivRobustANGLE(Context *context,
4598 GLuint sampler,
4599 GLenum pname,
4600 GLuint bufSize,
4601 GLsizei *length,
4602 GLint *params)
4603{
4604 if (!ValidateRobustEntryPoint(context, bufSize))
4605 {
4606 return false;
4607 }
4608
4609 if (!ValidateGetSamplerParameterBase(context, sampler, pname, length))
4610 {
4611 return false;
4612 }
4613
4614 if (!ValidateRobustBufferSize(context, bufSize, *length))
4615 {
4616 return false;
4617 }
4618
4619 return true;
4620}
4621
4622bool ValidateSamplerParameterf(Context *context, GLuint sampler, GLenum pname, GLfloat param)
4623{
4624 return ValidateSamplerParameterBase(context, sampler, pname, -1, &param);
4625}
4626
4627bool ValidateSamplerParameterfv(Context *context,
4628 GLuint sampler,
4629 GLenum pname,
4630 const GLfloat *params)
4631{
4632 return ValidateSamplerParameterBase(context, sampler, pname, -1, params);
4633}
4634
4635bool ValidateSamplerParameterfvRobustANGLE(Context *context,
4636 GLuint sampler,
4637 GLenum pname,
4638 GLsizei bufSize,
4639 const GLfloat *params)
4640{
4641 if (!ValidateRobustEntryPoint(context, bufSize))
4642 {
4643 return false;
4644 }
4645
4646 return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params);
4647}
4648
4649bool ValidateSamplerParameteri(Context *context, GLuint sampler, GLenum pname, GLint param)
4650{
4651 return ValidateSamplerParameterBase(context, sampler, pname, -1, &param);
4652}
4653
4654bool ValidateSamplerParameteriv(Context *context, GLuint sampler, GLenum pname, const GLint *params)
4655{
4656 return ValidateSamplerParameterBase(context, sampler, pname, -1, params);
4657}
4658
4659bool ValidateSamplerParameterivRobustANGLE(Context *context,
4660 GLuint sampler,
4661 GLenum pname,
4662 GLsizei bufSize,
4663 const GLint *params)
4664{
4665 if (!ValidateRobustEntryPoint(context, bufSize))
4666 {
4667 return false;
4668 }
4669
4670 return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params);
4671}
4672
Geoff Lang0b031062016-10-13 14:30:04 -04004673bool ValidateGetVertexAttribfvRobustANGLE(Context *context,
4674 GLuint index,
4675 GLenum pname,
4676 GLsizei bufSize,
4677 GLsizei *length,
4678 GLfloat *params)
4679{
4680 if (!ValidateRobustEntryPoint(context, bufSize))
4681 {
4682 return false;
4683 }
4684
4685 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false))
4686 {
4687 return false;
4688 }
4689
4690 if (!ValidateRobustBufferSize(context, bufSize, *length))
4691 {
4692 return false;
4693 }
4694
4695 return true;
4696}
4697
Geoff Lang0b031062016-10-13 14:30:04 -04004698bool ValidateGetVertexAttribivRobustANGLE(Context *context,
4699 GLuint index,
4700 GLenum pname,
4701 GLsizei bufSize,
4702 GLsizei *length,
4703 GLint *params)
4704{
4705 if (!ValidateRobustEntryPoint(context, bufSize))
4706 {
4707 return false;
4708 }
4709
4710 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false))
4711 {
4712 return false;
4713 }
4714
4715 if (!ValidateRobustBufferSize(context, bufSize, *length))
4716 {
4717 return false;
4718 }
4719
4720 return true;
4721}
4722
Geoff Lang0b031062016-10-13 14:30:04 -04004723bool ValidateGetVertexAttribPointervRobustANGLE(Context *context,
4724 GLuint index,
4725 GLenum pname,
4726 GLsizei bufSize,
4727 GLsizei *length,
4728 void **pointer)
4729{
4730 if (!ValidateRobustEntryPoint(context, bufSize))
4731 {
4732 return false;
4733 }
4734
4735 if (!ValidateGetVertexAttribBase(context, index, pname, length, true, false))
4736 {
4737 return false;
4738 }
4739
4740 if (!ValidateRobustBufferSize(context, bufSize, *length))
4741 {
4742 return false;
4743 }
4744
4745 return true;
4746}
4747
4748bool ValidateGetVertexAttribIiv(Context *context, GLuint index, GLenum pname, GLint *params)
4749{
4750 return ValidateGetVertexAttribBase(context, index, pname, nullptr, false, true);
4751}
4752
4753bool ValidateGetVertexAttribIivRobustANGLE(Context *context,
4754 GLuint index,
4755 GLenum pname,
4756 GLsizei bufSize,
4757 GLsizei *length,
4758 GLint *params)
4759{
4760 if (!ValidateRobustEntryPoint(context, bufSize))
4761 {
4762 return false;
4763 }
4764
4765 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true))
4766 {
4767 return false;
4768 }
4769
4770 if (!ValidateRobustBufferSize(context, bufSize, *length))
4771 {
4772 return false;
4773 }
4774
4775 return true;
4776}
4777
4778bool ValidateGetVertexAttribIuiv(Context *context, GLuint index, GLenum pname, GLuint *params)
4779{
4780 return ValidateGetVertexAttribBase(context, index, pname, nullptr, false, true);
4781}
4782
4783bool ValidateGetVertexAttribIuivRobustANGLE(Context *context,
4784 GLuint index,
4785 GLenum pname,
4786 GLsizei bufSize,
4787 GLsizei *length,
4788 GLuint *params)
4789{
4790 if (!ValidateRobustEntryPoint(context, bufSize))
4791 {
4792 return false;
4793 }
4794
4795 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true))
4796 {
4797 return false;
4798 }
4799
4800 if (!ValidateRobustBufferSize(context, bufSize, *length))
4801 {
4802 return false;
4803 }
4804
4805 return true;
4806}
4807
Geoff Lang6899b872016-10-14 11:30:13 -04004808bool ValidateGetActiveUniformBlockiv(Context *context,
4809 GLuint program,
4810 GLuint uniformBlockIndex,
4811 GLenum pname,
4812 GLint *params)
4813{
4814 return ValidateGetActiveUniformBlockivBase(context, program, uniformBlockIndex, pname, nullptr);
4815}
4816
4817bool ValidateGetActiveUniformBlockivRobustANGLE(Context *context,
4818 GLuint program,
4819 GLuint uniformBlockIndex,
4820 GLenum pname,
4821 GLsizei bufSize,
4822 GLsizei *length,
4823 GLint *params)
4824{
4825 if (!ValidateRobustEntryPoint(context, bufSize))
4826 {
4827 return false;
4828 }
4829
4830 if (!ValidateGetActiveUniformBlockivBase(context, program, uniformBlockIndex, pname, length))
4831 {
4832 return false;
4833 }
4834
4835 if (!ValidateRobustBufferSize(context, bufSize, *length))
4836 {
4837 return false;
4838 }
4839
4840 return true;
4841}
4842
Geoff Lang0a9661f2016-10-20 10:59:20 -07004843bool ValidateGetInternalFormativ(Context *context,
4844 GLenum target,
4845 GLenum internalformat,
4846 GLenum pname,
4847 GLsizei bufSize,
4848 GLint *params)
4849{
4850 return ValidateGetInternalFormativBase(context, target, internalformat, pname, bufSize,
4851 nullptr);
4852}
4853
4854bool ValidateGetInternalFormativRobustANGLE(Context *context,
4855 GLenum target,
4856 GLenum internalformat,
4857 GLenum pname,
4858 GLsizei bufSize,
4859 GLsizei *length,
4860 GLint *params)
4861{
4862 if (!ValidateRobustEntryPoint(context, bufSize))
4863 {
4864 return false;
4865 }
4866
4867 if (!ValidateGetInternalFormativBase(context, target, internalformat, pname, bufSize, length))
4868 {
4869 return false;
4870 }
4871
4872 if (!ValidateRobustBufferSize(context, bufSize, *length))
4873 {
4874 return false;
4875 }
4876
4877 return true;
4878}
4879
Shao80957d92017-02-20 21:25:59 +08004880bool ValidateVertexFormatBase(ValidationContext *context,
4881 GLuint attribIndex,
4882 GLint size,
4883 GLenum type,
4884 GLboolean pureInteger)
4885{
4886 const Caps &caps = context->getCaps();
4887 if (attribIndex >= caps.maxVertexAttributes)
4888 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004889 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMax);
Shao80957d92017-02-20 21:25:59 +08004890 return false;
4891 }
4892
4893 if (size < 1 || size > 4)
4894 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004895 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidVertexAttrSize);
Geoff Lang8700a982017-06-13 10:15:13 -04004896 return false;
Shao80957d92017-02-20 21:25:59 +08004897 }
4898
4899 switch (type)
4900 {
4901 case GL_BYTE:
4902 case GL_UNSIGNED_BYTE:
4903 case GL_SHORT:
4904 case GL_UNSIGNED_SHORT:
4905 break;
4906
4907 case GL_INT:
4908 case GL_UNSIGNED_INT:
4909 if (context->getClientMajorVersion() < 3)
4910 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004911 context->handleError(InvalidEnum()
4912 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004913 return false;
4914 }
4915 break;
4916
4917 case GL_FIXED:
4918 case GL_FLOAT:
4919 if (pureInteger)
4920 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004921 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004922 return false;
4923 }
4924 break;
4925
4926 case GL_HALF_FLOAT:
4927 if (context->getClientMajorVersion() < 3)
4928 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004929 context->handleError(InvalidEnum()
4930 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004931 return false;
4932 }
4933 if (pureInteger)
4934 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004935 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004936 return false;
4937 }
4938 break;
4939
4940 case GL_INT_2_10_10_10_REV:
4941 case GL_UNSIGNED_INT_2_10_10_10_REV:
4942 if (context->getClientMajorVersion() < 3)
4943 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004944 context->handleError(InvalidEnum()
4945 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004946 return false;
4947 }
4948 if (pureInteger)
4949 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004950 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004951 return false;
4952 }
4953 if (size != 4)
4954 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004955 context->handleError(InvalidOperation() << "Type is INT_2_10_10_10_REV or "
4956 "UNSIGNED_INT_2_10_10_10_REV and "
4957 "size is not 4.");
Shao80957d92017-02-20 21:25:59 +08004958 return false;
4959 }
4960 break;
4961
4962 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004963 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidType);
Shao80957d92017-02-20 21:25:59 +08004964 return false;
4965 }
4966
4967 return true;
4968}
4969
Geoff Lang76e65652017-03-27 14:58:02 -04004970// Perform validation from WebGL 2 section 5.10 "Invalid Clears":
4971// In the WebGL 2 API, trying to perform a clear when there is a mismatch between the type of the
4972// specified clear value and the type of a buffer that is being cleared generates an
4973// INVALID_OPERATION error instead of producing undefined results
4974bool ValidateWebGLFramebufferAttachmentClearType(ValidationContext *context,
4975 GLint drawbuffer,
4976 const GLenum *validComponentTypes,
4977 size_t validComponentTypeCount)
4978{
4979 const FramebufferAttachment *attachment =
4980 context->getGLState().getDrawFramebuffer()->getDrawBuffer(drawbuffer);
4981 if (attachment)
4982 {
4983 GLenum componentType = attachment->getFormat().info->componentType;
4984 const GLenum *end = validComponentTypes + validComponentTypeCount;
4985 if (std::find(validComponentTypes, end, componentType) == end)
4986 {
4987 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004988 InvalidOperation()
4989 << "No defined conversion between clear value and attachment format.");
Geoff Lang76e65652017-03-27 14:58:02 -04004990 return false;
4991 }
4992 }
4993
4994 return true;
4995}
4996
Corentin Wallezb2931602017-04-11 15:58:57 -04004997bool ValidateRobustCompressedTexImageBase(ValidationContext *context,
4998 GLsizei imageSize,
4999 GLsizei dataSize)
5000{
5001 if (!ValidateRobustEntryPoint(context, dataSize))
5002 {
5003 return false;
5004 }
5005
5006 gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
5007 if (pixelUnpackBuffer == nullptr)
5008 {
5009 if (dataSize < imageSize)
5010 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005011 context->handleError(InvalidOperation() << "dataSize must be at least " << imageSize);
Corentin Wallezb2931602017-04-11 15:58:57 -04005012 }
5013 }
5014 return true;
5015}
5016
Jamie Madillbe849e42017-05-02 15:49:00 -04005017bool ValidateGetBufferParameterBase(ValidationContext *context,
5018 GLenum target,
5019 GLenum pname,
5020 bool pointerVersion,
5021 GLsizei *numParams)
5022{
5023 if (numParams)
5024 {
5025 *numParams = 0;
5026 }
5027
5028 if (!ValidBufferTarget(context, target))
5029 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005030 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Jamie Madillbe849e42017-05-02 15:49:00 -04005031 return false;
5032 }
5033
5034 const Buffer *buffer = context->getGLState().getTargetBuffer(target);
5035 if (!buffer)
5036 {
5037 // A null buffer means that "0" is bound to the requested buffer target
Brandon Jones6cad5662017-06-14 13:25:13 -07005038 ANGLE_VALIDATION_ERR(context, InvalidOperation(), BufferNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005039 return false;
5040 }
5041
5042 const Extensions &extensions = context->getExtensions();
5043
5044 switch (pname)
5045 {
5046 case GL_BUFFER_USAGE:
5047 case GL_BUFFER_SIZE:
5048 break;
5049
5050 case GL_BUFFER_ACCESS_OES:
5051 if (!extensions.mapBuffer)
5052 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005053 context->handleError(InvalidEnum()
5054 << "pname requires OpenGL ES 3.0 or GL_OES_mapbuffer.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005055 return false;
5056 }
5057 break;
5058
5059 case GL_BUFFER_MAPPED:
5060 static_assert(GL_BUFFER_MAPPED == GL_BUFFER_MAPPED_OES, "GL enums should be equal.");
5061 if (context->getClientMajorVersion() < 3 && !extensions.mapBuffer &&
5062 !extensions.mapBufferRange)
5063 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005064 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0, "
5065 "GL_OES_mapbuffer or "
5066 "GL_EXT_map_buffer_range.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005067 return false;
5068 }
5069 break;
5070
5071 case GL_BUFFER_MAP_POINTER:
5072 if (!pointerVersion)
5073 {
5074 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005075 InvalidEnum()
5076 << "GL_BUFFER_MAP_POINTER can only be queried with GetBufferPointerv.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005077 return false;
5078 }
5079 break;
5080
5081 case GL_BUFFER_ACCESS_FLAGS:
5082 case GL_BUFFER_MAP_OFFSET:
5083 case GL_BUFFER_MAP_LENGTH:
5084 if (context->getClientMajorVersion() < 3 && !extensions.mapBufferRange)
5085 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005086 context->handleError(InvalidEnum()
5087 << "pname requires OpenGL ES 3.0 or GL_EXT_map_buffer_range.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005088 return false;
5089 }
5090 break;
5091
5092 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005093 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005094 return false;
5095 }
5096
5097 // All buffer parameter queries return one value.
5098 if (numParams)
5099 {
5100 *numParams = 1;
5101 }
5102
5103 return true;
5104}
5105
5106bool ValidateGetRenderbufferParameterivBase(Context *context,
5107 GLenum target,
5108 GLenum pname,
5109 GLsizei *length)
5110{
5111 if (length)
5112 {
5113 *length = 0;
5114 }
5115
5116 if (target != GL_RENDERBUFFER)
5117 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005118 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005119 return false;
5120 }
5121
5122 Renderbuffer *renderbuffer = context->getGLState().getCurrentRenderbuffer();
5123 if (renderbuffer == nullptr)
5124 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005125 ANGLE_VALIDATION_ERR(context, InvalidOperation(), RenderbufferNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005126 return false;
5127 }
5128
5129 switch (pname)
5130 {
5131 case GL_RENDERBUFFER_WIDTH:
5132 case GL_RENDERBUFFER_HEIGHT:
5133 case GL_RENDERBUFFER_INTERNAL_FORMAT:
5134 case GL_RENDERBUFFER_RED_SIZE:
5135 case GL_RENDERBUFFER_GREEN_SIZE:
5136 case GL_RENDERBUFFER_BLUE_SIZE:
5137 case GL_RENDERBUFFER_ALPHA_SIZE:
5138 case GL_RENDERBUFFER_DEPTH_SIZE:
5139 case GL_RENDERBUFFER_STENCIL_SIZE:
5140 break;
5141
5142 case GL_RENDERBUFFER_SAMPLES_ANGLE:
5143 if (!context->getExtensions().framebufferMultisample)
5144 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005145 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005146 return false;
5147 }
5148 break;
5149
5150 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005151 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005152 return false;
5153 }
5154
5155 if (length)
5156 {
5157 *length = 1;
5158 }
5159 return true;
5160}
5161
5162bool ValidateGetShaderivBase(Context *context, GLuint shader, GLenum pname, GLsizei *length)
5163{
5164 if (length)
5165 {
5166 *length = 0;
5167 }
5168
5169 if (GetValidShader(context, shader) == nullptr)
5170 {
5171 return false;
5172 }
5173
5174 switch (pname)
5175 {
5176 case GL_SHADER_TYPE:
5177 case GL_DELETE_STATUS:
5178 case GL_COMPILE_STATUS:
5179 case GL_INFO_LOG_LENGTH:
5180 case GL_SHADER_SOURCE_LENGTH:
5181 break;
5182
5183 case GL_TRANSLATED_SHADER_SOURCE_LENGTH_ANGLE:
5184 if (!context->getExtensions().translatedShaderSource)
5185 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005186 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005187 return false;
5188 }
5189 break;
5190
5191 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005192 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005193 return false;
5194 }
5195
5196 if (length)
5197 {
5198 *length = 1;
5199 }
5200 return true;
5201}
5202
5203bool ValidateGetTexParameterBase(Context *context, GLenum target, GLenum pname, GLsizei *length)
5204{
5205 if (length)
5206 {
5207 *length = 0;
5208 }
5209
5210 if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
5211 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005212 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005213 return false;
5214 }
5215
5216 if (context->getTargetTexture(target) == nullptr)
5217 {
5218 // Should only be possible for external textures
Brandon Jones6cad5662017-06-14 13:25:13 -07005219 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005220 return false;
5221 }
5222
5223 switch (pname)
5224 {
5225 case GL_TEXTURE_MAG_FILTER:
5226 case GL_TEXTURE_MIN_FILTER:
5227 case GL_TEXTURE_WRAP_S:
5228 case GL_TEXTURE_WRAP_T:
5229 break;
5230
5231 case GL_TEXTURE_USAGE_ANGLE:
5232 if (!context->getExtensions().textureUsage)
5233 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005234 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005235 return false;
5236 }
5237 break;
5238
5239 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
5240 if (!context->getExtensions().textureFilterAnisotropic)
5241 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005242 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005243 return false;
5244 }
5245 break;
5246
5247 case GL_TEXTURE_IMMUTABLE_FORMAT:
5248 if (context->getClientMajorVersion() < 3 && !context->getExtensions().textureStorage)
5249 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005250 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04005251 return false;
5252 }
5253 break;
5254
5255 case GL_TEXTURE_WRAP_R:
5256 case GL_TEXTURE_IMMUTABLE_LEVELS:
5257 case GL_TEXTURE_SWIZZLE_R:
5258 case GL_TEXTURE_SWIZZLE_G:
5259 case GL_TEXTURE_SWIZZLE_B:
5260 case GL_TEXTURE_SWIZZLE_A:
5261 case GL_TEXTURE_BASE_LEVEL:
5262 case GL_TEXTURE_MAX_LEVEL:
5263 case GL_TEXTURE_MIN_LOD:
5264 case GL_TEXTURE_MAX_LOD:
5265 case GL_TEXTURE_COMPARE_MODE:
5266 case GL_TEXTURE_COMPARE_FUNC:
5267 if (context->getClientMajorVersion() < 3)
5268 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005269 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005270 return false;
5271 }
5272 break;
5273
5274 case GL_TEXTURE_SRGB_DECODE_EXT:
5275 if (!context->getExtensions().textureSRGBDecode)
5276 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005277 context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005278 return false;
5279 }
5280 break;
5281
5282 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005283 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005284 return false;
5285 }
5286
5287 if (length)
5288 {
5289 *length = 1;
5290 }
5291 return true;
5292}
5293
5294bool ValidateGetVertexAttribBase(Context *context,
5295 GLuint index,
5296 GLenum pname,
5297 GLsizei *length,
5298 bool pointer,
5299 bool pureIntegerEntryPoint)
5300{
5301 if (length)
5302 {
5303 *length = 0;
5304 }
5305
5306 if (pureIntegerEntryPoint && context->getClientMajorVersion() < 3)
5307 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005308 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005309 return false;
5310 }
5311
5312 if (index >= context->getCaps().maxVertexAttributes)
5313 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005314 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMax);
Jamie Madillbe849e42017-05-02 15:49:00 -04005315 return false;
5316 }
5317
5318 if (pointer)
5319 {
5320 if (pname != GL_VERTEX_ATTRIB_ARRAY_POINTER)
5321 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005322 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005323 return false;
5324 }
5325 }
5326 else
5327 {
5328 switch (pname)
5329 {
5330 case GL_VERTEX_ATTRIB_ARRAY_ENABLED:
5331 case GL_VERTEX_ATTRIB_ARRAY_SIZE:
5332 case GL_VERTEX_ATTRIB_ARRAY_STRIDE:
5333 case GL_VERTEX_ATTRIB_ARRAY_TYPE:
5334 case GL_VERTEX_ATTRIB_ARRAY_NORMALIZED:
5335 case GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING:
5336 case GL_CURRENT_VERTEX_ATTRIB:
5337 break;
5338
5339 case GL_VERTEX_ATTRIB_ARRAY_DIVISOR:
5340 static_assert(
5341 GL_VERTEX_ATTRIB_ARRAY_DIVISOR == GL_VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE,
5342 "ANGLE extension enums not equal to GL enums.");
5343 if (context->getClientMajorVersion() < 3 &&
5344 !context->getExtensions().instancedArrays)
5345 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005346 context->handleError(InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_DIVISOR "
5347 "requires OpenGL ES 3.0 or "
5348 "GL_ANGLE_instanced_arrays.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005349 return false;
5350 }
5351 break;
5352
5353 case GL_VERTEX_ATTRIB_ARRAY_INTEGER:
5354 if (context->getClientMajorVersion() < 3)
5355 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005356 context->handleError(
5357 InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_INTEGER requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005358 return false;
5359 }
5360 break;
5361
5362 case GL_VERTEX_ATTRIB_BINDING:
5363 case GL_VERTEX_ATTRIB_RELATIVE_OFFSET:
5364 if (context->getClientVersion() < ES_3_1)
5365 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005366 context->handleError(InvalidEnum()
5367 << "Vertex Attrib Bindings require OpenGL ES 3.1.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005368 return false;
5369 }
5370 break;
5371
5372 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005373 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005374 return false;
5375 }
5376 }
5377
5378 if (length)
5379 {
5380 if (pname == GL_CURRENT_VERTEX_ATTRIB)
5381 {
5382 *length = 4;
5383 }
5384 else
5385 {
5386 *length = 1;
5387 }
5388 }
5389
5390 return true;
5391}
5392
Jamie Madill4928b7c2017-06-20 12:57:39 -04005393bool ValidateReadPixelsBase(Context *context,
Jamie Madillbe849e42017-05-02 15:49:00 -04005394 GLint x,
5395 GLint y,
5396 GLsizei width,
5397 GLsizei height,
5398 GLenum format,
5399 GLenum type,
5400 GLsizei bufSize,
5401 GLsizei *length,
5402 GLsizei *columns,
5403 GLsizei *rows,
5404 void *pixels)
5405{
5406 if (length != nullptr)
5407 {
5408 *length = 0;
5409 }
5410 if (rows != nullptr)
5411 {
5412 *rows = 0;
5413 }
5414 if (columns != nullptr)
5415 {
5416 *columns = 0;
5417 }
5418
5419 if (width < 0 || height < 0)
5420 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005421 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005422 return false;
5423 }
5424
5425 auto readFramebuffer = context->getGLState().getReadFramebuffer();
5426
5427 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
5428 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005429 context->handleError(InvalidFramebufferOperation());
Jamie Madillbe849e42017-05-02 15:49:00 -04005430 return false;
5431 }
5432
5433 if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0)
5434 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005435 context->handleError(InvalidOperation());
Jamie Madillbe849e42017-05-02 15:49:00 -04005436 return false;
5437 }
5438
5439 const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer();
5440 ASSERT(framebuffer);
5441
5442 if (framebuffer->getReadBufferState() == GL_NONE)
5443 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005444 context->handleError(InvalidOperation() << "Read buffer is GL_NONE");
Jamie Madillbe849e42017-05-02 15:49:00 -04005445 return false;
5446 }
5447
5448 const FramebufferAttachment *readBuffer = framebuffer->getReadColorbuffer();
5449 // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment
5450 // In OpenGL ES it is undefined what happens when an operation tries to read from a missing
5451 // attachment and WebGL defines it to be an error. We do the check unconditionnaly as the
5452 // situation is an application error that would lead to a crash in ANGLE.
5453 if (readBuffer == nullptr)
5454 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005455 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment);
Jamie Madillbe849e42017-05-02 15:49:00 -04005456 return false;
5457 }
5458
Martin Radev28031682017-07-28 14:47:56 +03005459 // ANGLE_multiview, Revision 1:
5460 // ReadPixels generates an INVALID_FRAMEBUFFER_OPERATION error if the multi-view layout of the
5461 // current read framebuffer is not NONE.
5462 if (readBuffer->getMultiviewLayout() != GL_NONE)
5463 {
5464 context->handleError(InvalidFramebufferOperation()
5465 << "Attempting to read from a multi-view framebuffer.");
5466 return false;
5467 }
5468
Geoff Lang280ba992017-04-18 16:30:58 -04005469 if (context->getExtensions().webglCompatibility)
5470 {
5471 // The ES 2.0 spec states that the format must be "among those defined in table 3.4,
5472 // excluding formats LUMINANCE and LUMINANCE_ALPHA.". This requires validating the format
5473 // and type before validating the combination of format and type. However, the
5474 // dEQP-GLES3.functional.negative_api.buffer.read_pixels passes GL_LUMINANCE as a format and
5475 // verifies that GL_INVALID_OPERATION is generated.
5476 // TODO(geofflang): Update this check to be done in all/no cases once this is resolved in
5477 // dEQP/WebGL.
5478 if (!ValidReadPixelsFormatEnum(context, format))
5479 {
5480 context->handleError(InvalidEnum() << "Invalid read format.");
5481 return false;
5482 }
5483
5484 if (!ValidReadPixelsTypeEnum(context, type))
5485 {
5486 context->handleError(InvalidEnum() << "Invalid read type.");
5487 return false;
5488 }
5489 }
5490
Jamie Madill4928b7c2017-06-20 12:57:39 -04005491 GLenum currentFormat = framebuffer->getImplementationColorReadFormat(context);
5492 GLenum currentType = framebuffer->getImplementationColorReadType(context);
Jamie Madillbe849e42017-05-02 15:49:00 -04005493 GLenum currentComponentType = readBuffer->getFormat().info->componentType;
5494
5495 bool validFormatTypeCombination =
5496 ValidReadPixelsFormatType(context, currentComponentType, format, type);
5497
5498 if (!(currentFormat == format && currentType == type) && !validFormatTypeCombination)
5499 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005500 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MismatchedTypeAndFormat);
Jamie Madillbe849e42017-05-02 15:49:00 -04005501 return false;
5502 }
5503
5504 // Check for pixel pack buffer related API errors
5505 gl::Buffer *pixelPackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_PACK_BUFFER);
5506 if (pixelPackBuffer != nullptr && pixelPackBuffer->isMapped())
5507 {
5508 // ...the buffer object's data store is currently mapped.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005509 context->handleError(InvalidOperation() << "Pixel pack buffer is mapped.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005510 return false;
5511 }
5512
5513 // .. the data would be packed to the buffer object such that the memory writes required
5514 // would exceed the data store size.
5515 const InternalFormat &formatInfo = GetInternalFormatInfo(format, type);
5516 const gl::Extents size(width, height, 1);
5517 const auto &pack = context->getGLState().getPackState();
5518
5519 auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, pack, false);
5520 if (endByteOrErr.isError())
5521 {
5522 context->handleError(endByteOrErr.getError());
5523 return false;
5524 }
5525
5526 size_t endByte = endByteOrErr.getResult();
5527 if (bufSize >= 0)
5528 {
5529 if (pixelPackBuffer == nullptr && static_cast<size_t>(bufSize) < endByte)
5530 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005531 context->handleError(InvalidOperation()
5532 << "bufSize must be at least " << endByte << " bytes.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005533 return false;
5534 }
5535 }
5536
5537 if (pixelPackBuffer != nullptr)
5538 {
5539 CheckedNumeric<size_t> checkedEndByte(endByte);
5540 CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels));
5541 checkedEndByte += checkedOffset;
5542
5543 if (checkedEndByte.ValueOrDie() > static_cast<size_t>(pixelPackBuffer->getSize()))
5544 {
5545 // Overflow past the end of the buffer
Brandon Jones6cad5662017-06-14 13:25:13 -07005546 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ParamOverflow);
Jamie Madillbe849e42017-05-02 15:49:00 -04005547 return false;
5548 }
5549 }
5550
5551 if (pixelPackBuffer == nullptr && length != nullptr)
5552 {
5553 if (endByte > static_cast<size_t>(std::numeric_limits<GLsizei>::max()))
5554 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005555 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Jamie Madillbe849e42017-05-02 15:49:00 -04005556 return false;
5557 }
5558
5559 *length = static_cast<GLsizei>(endByte);
5560 }
5561
5562 auto getClippedExtent = [](GLint start, GLsizei length, int bufferSize) {
5563 angle::CheckedNumeric<int> clippedExtent(length);
5564 if (start < 0)
5565 {
5566 // "subtract" the area that is less than 0
5567 clippedExtent += start;
5568 }
5569
5570 const int readExtent = start + length;
5571 if (readExtent > bufferSize)
5572 {
5573 // Subtract the region to the right of the read buffer
5574 clippedExtent -= (readExtent - bufferSize);
5575 }
5576
5577 if (!clippedExtent.IsValid())
5578 {
5579 return 0;
5580 }
5581
5582 return std::max(clippedExtent.ValueOrDie(), 0);
5583 };
5584
5585 if (columns != nullptr)
5586 {
5587 *columns = getClippedExtent(x, width, readBuffer->getSize().width);
5588 }
5589
5590 if (rows != nullptr)
5591 {
5592 *rows = getClippedExtent(y, height, readBuffer->getSize().height);
5593 }
5594
5595 return true;
5596}
5597
5598template <typename ParamType>
5599bool ValidateTexParameterBase(Context *context,
5600 GLenum target,
5601 GLenum pname,
5602 GLsizei bufSize,
5603 const ParamType *params)
5604{
5605 if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
5606 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005607 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005608 return false;
5609 }
5610
5611 if (context->getTargetTexture(target) == nullptr)
5612 {
5613 // Should only be possible for external textures
Brandon Jones6cad5662017-06-14 13:25:13 -07005614 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005615 return false;
5616 }
5617
5618 const GLsizei minBufSize = 1;
5619 if (bufSize >= 0 && bufSize < minBufSize)
5620 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005621 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005622 return false;
5623 }
5624
5625 switch (pname)
5626 {
5627 case GL_TEXTURE_WRAP_R:
5628 case GL_TEXTURE_SWIZZLE_R:
5629 case GL_TEXTURE_SWIZZLE_G:
5630 case GL_TEXTURE_SWIZZLE_B:
5631 case GL_TEXTURE_SWIZZLE_A:
5632 case GL_TEXTURE_BASE_LEVEL:
5633 case GL_TEXTURE_MAX_LEVEL:
5634 case GL_TEXTURE_COMPARE_MODE:
5635 case GL_TEXTURE_COMPARE_FUNC:
5636 case GL_TEXTURE_MIN_LOD:
5637 case GL_TEXTURE_MAX_LOD:
5638 if (context->getClientMajorVersion() < 3)
5639 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005640 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005641 return false;
5642 }
5643 if (target == GL_TEXTURE_EXTERNAL_OES &&
5644 !context->getExtensions().eglImageExternalEssl3)
5645 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005646 context->handleError(InvalidEnum() << "ES3 texture parameters are not "
5647 "available without "
5648 "GL_OES_EGL_image_external_essl3.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005649 return false;
5650 }
5651 break;
5652
5653 default:
5654 break;
5655 }
5656
JiangYizhou4cff8d62017-07-06 14:54:09 +08005657 if (target == GL_TEXTURE_2D_MULTISAMPLE)
5658 {
5659 switch (pname)
5660 {
5661 case GL_TEXTURE_MIN_FILTER:
5662 case GL_TEXTURE_MAG_FILTER:
5663 case GL_TEXTURE_WRAP_S:
5664 case GL_TEXTURE_WRAP_T:
5665 case GL_TEXTURE_WRAP_R:
5666 case GL_TEXTURE_MIN_LOD:
5667 case GL_TEXTURE_MAX_LOD:
5668 case GL_TEXTURE_COMPARE_MODE:
5669 case GL_TEXTURE_COMPARE_FUNC:
5670 context->handleError(InvalidEnum()
5671 << "Invalid parameter for 2D multisampled textures.");
5672 return false;
5673 }
5674 }
5675
Jamie Madillbe849e42017-05-02 15:49:00 -04005676 switch (pname)
5677 {
5678 case GL_TEXTURE_WRAP_S:
5679 case GL_TEXTURE_WRAP_T:
5680 case GL_TEXTURE_WRAP_R:
5681 if (!ValidateTextureWrapModeValue(context, params, target == GL_TEXTURE_EXTERNAL_OES))
5682 {
5683 return false;
5684 }
5685 break;
5686
5687 case GL_TEXTURE_MIN_FILTER:
5688 if (!ValidateTextureMinFilterValue(context, params, target == GL_TEXTURE_EXTERNAL_OES))
5689 {
5690 return false;
5691 }
5692 break;
5693
5694 case GL_TEXTURE_MAG_FILTER:
5695 if (!ValidateTextureMagFilterValue(context, params))
5696 {
5697 return false;
5698 }
5699 break;
5700
5701 case GL_TEXTURE_USAGE_ANGLE:
5702 switch (ConvertToGLenum(params[0]))
5703 {
5704 case GL_NONE:
5705 case GL_FRAMEBUFFER_ATTACHMENT_ANGLE:
5706 break;
5707
5708 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005709 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005710 return false;
5711 }
5712 break;
5713
5714 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
5715 if (!context->getExtensions().textureFilterAnisotropic)
5716 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005717 context->handleError(InvalidEnum() << "GL_EXT_texture_anisotropic is not enabled.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005718 return false;
5719 }
5720
5721 // we assume the parameter passed to this validation method is truncated, not rounded
5722 if (params[0] < 1)
5723 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005724 context->handleError(InvalidValue() << "Max anisotropy must be at least 1.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005725 return false;
5726 }
5727 break;
5728
5729 case GL_TEXTURE_MIN_LOD:
5730 case GL_TEXTURE_MAX_LOD:
5731 // any value is permissible
5732 break;
5733
5734 case GL_TEXTURE_COMPARE_MODE:
5735 if (!ValidateTextureCompareModeValue(context, params))
5736 {
5737 return false;
5738 }
5739 break;
5740
5741 case GL_TEXTURE_COMPARE_FUNC:
5742 if (!ValidateTextureCompareFuncValue(context, params))
5743 {
5744 return false;
5745 }
5746 break;
5747
5748 case GL_TEXTURE_SWIZZLE_R:
5749 case GL_TEXTURE_SWIZZLE_G:
5750 case GL_TEXTURE_SWIZZLE_B:
5751 case GL_TEXTURE_SWIZZLE_A:
5752 switch (ConvertToGLenum(params[0]))
5753 {
5754 case GL_RED:
5755 case GL_GREEN:
5756 case GL_BLUE:
5757 case GL_ALPHA:
5758 case GL_ZERO:
5759 case GL_ONE:
5760 break;
5761
5762 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005763 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005764 return false;
5765 }
5766 break;
5767
5768 case GL_TEXTURE_BASE_LEVEL:
5769 if (params[0] < 0)
5770 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005771 context->handleError(InvalidValue() << "Base level must be at least 0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005772 return false;
5773 }
5774 if (target == GL_TEXTURE_EXTERNAL_OES && static_cast<GLuint>(params[0]) != 0)
5775 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005776 context->handleError(InvalidOperation()
5777 << "Base level must be 0 for external textures.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005778 return false;
5779 }
JiangYizhou4cff8d62017-07-06 14:54:09 +08005780 if (target == GL_TEXTURE_2D_MULTISAMPLE && static_cast<GLuint>(params[0]) != 0)
5781 {
5782 context->handleError(InvalidOperation()
5783 << "Base level must be 0 for multisampled textures.");
5784 return false;
5785 }
Jamie Madillbe849e42017-05-02 15:49:00 -04005786 break;
5787
5788 case GL_TEXTURE_MAX_LEVEL:
5789 if (params[0] < 0)
5790 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005791 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Jamie Madillbe849e42017-05-02 15:49:00 -04005792 return false;
5793 }
5794 break;
5795
5796 case GL_DEPTH_STENCIL_TEXTURE_MODE:
5797 if (context->getClientVersion() < Version(3, 1))
5798 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005799 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumRequiresGLES31);
Jamie Madillbe849e42017-05-02 15:49:00 -04005800 return false;
5801 }
5802 switch (ConvertToGLenum(params[0]))
5803 {
5804 case GL_DEPTH_COMPONENT:
5805 case GL_STENCIL_INDEX:
5806 break;
5807
5808 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005809 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005810 return false;
5811 }
5812 break;
5813
5814 case GL_TEXTURE_SRGB_DECODE_EXT:
5815 if (!ValidateTextureSRGBDecodeValue(context, params))
5816 {
5817 return false;
5818 }
5819 break;
5820
5821 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005822 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005823 return false;
5824 }
5825
5826 return true;
5827}
5828
5829template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLfloat *);
5830template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLint *);
5831
Jamie Madillc29968b2016-01-20 11:17:23 -05005832} // namespace gl