blob: 734a4c98bcaa256c4aa99447214170db5e21b35b [file] [log] [blame]
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001/*
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002 *
Courtney Goeltzenleuchter8a17da52015-10-29 13:50:34 -06003 * Copyright (C) 2015 Valve Corporation
Michael Lentine329697b2015-10-06 14:56:18 -07004 * Copyright (C) 2015 Google, Inc.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005 *
6 * Permission is hereby granted, free of charge, to any person obtaining a
7 * copy of this software and associated documentation files (the "Software"),
8 * to deal in the Software without restriction, including without limitation
9 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
10 * and/or sell copies of the Software, and to permit persons to whom the
11 * Software is furnished to do so, subject to the following conditions:
12 *
13 * The above copyright notice and this permission notice shall be included
14 * in all copies or substantial portions of the Software.
15 *
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
22 * DEALINGS IN THE SOFTWARE.
Courtney Goeltzenleuchter96cd7952015-10-30 11:14:30 -060023 *
Tobin Ehlisd17c28c2015-12-03 09:40:56 -070024 * Author: Cody Northrop <cnorthrop@google.com>
Courtney Goeltzenleuchter96cd7952015-10-30 11:14:30 -060025 * Author: Michael Lentine <mlentine@google.com>
Tobin Ehlisd17c28c2015-12-03 09:40:56 -070026 * Author: Tobin Ehlis <tobine@google.com>
27 * Author: Chia-I Wu <olv@google.com>
Tobin Ehlis32479352015-12-01 09:48:58 -070028 * Author: Chris Forbes <chrisf@ijw.co.nz>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060029 */
30
31#include <stdio.h>
32#include <stdlib.h>
33#include <string.h>
Tobin Ehlis32479352015-12-01 09:48:58 -070034#include <assert.h>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060035#include <unordered_map>
Michael Lentine329697b2015-10-06 14:56:18 -070036#include <unordered_set>
Tobin Ehlis32479352015-12-01 09:48:58 -070037#include <map>
38#include <string>
39#include <iostream>
40#include <algorithm>
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070041#include <list>
Tobin Ehlis32479352015-12-01 09:48:58 -070042#include <spirv.hpp>
Tobin Ehlisd17c28c2015-12-03 09:40:56 -070043#include <set>
Tobin Ehlis63bb9482015-03-17 16:24:32 -060044
Tobin Ehlis7a51d902015-07-03 10:34:49 -060045#include "vk_loader_platform.h"
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -060046#include "vk_dispatch_table_helper.h"
47#include "vk_struct_string_helper_cpp.h"
Tony Barboura938abb2015-04-22 11:36:22 -060048#if defined(__GNUC__)
Tobin Ehlis63bb9482015-03-17 16:24:32 -060049#pragma GCC diagnostic ignored "-Wwrite-strings"
Tony Barboura938abb2015-04-22 11:36:22 -060050#endif
Tony Barboura938abb2015-04-22 11:36:22 -060051#if defined(__GNUC__)
Tobin Ehlis63bb9482015-03-17 16:24:32 -060052#pragma GCC diagnostic warning "-Wwrite-strings"
Tony Barboura938abb2015-04-22 11:36:22 -060053#endif
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -060054#include "vk_struct_size_helper.h"
Tobin Ehlis63bb9482015-03-17 16:24:32 -060055#include "draw_state.h"
Tobin Ehlis56d204a2015-07-03 10:15:26 -060056#include "vk_layer_config.h"
Michael Lentine8469dd62015-11-20 09:48:52 -080057#include "vulkan/vk_debug_marker_layer.h"
Tobin Ehlis56d204a2015-07-03 10:15:26 -060058#include "vk_layer_table.h"
59#include "vk_layer_debug_marker_table.h"
60#include "vk_layer_data.h"
61#include "vk_layer_logging.h"
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -060062#include "vk_layer_extension_utils.h"
Tobin Ehlisb46be812015-10-23 16:00:08 -060063#include "vk_layer_utils.h"
Tobin Ehlis63bb9482015-03-17 16:24:32 -060064
Mark Lobodzinski78940a42015-11-30 16:48:53 -070065// This definition controls whether image layout transitions are enabled/disabled.
66// disable until corner cases are fixed
67#define DISABLE_IMAGE_LAYOUT_VALIDATION
68
Tobin Ehlis32479352015-12-01 09:48:58 -070069using std::unordered_map;
70using std::unordered_set;
71
Tobin Ehlis4c8381e2015-12-14 13:46:38 -070072// Track command pools and their command buffers
73struct CMD_POOL_INFO {
74 VkCommandPoolCreateFlags createFlags;
75 list<VkCommandBuffer> commandBuffers; // list container of cmd buffers allocated from this pool
76};
77
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060078struct devExts {
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -070079 VkBool32 debug_marker_enabled;
Michael Lentine27b0f902015-10-12 11:30:14 -050080 VkBool32 wsi_enabled;
81 unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE*> swapchainMap;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060082};
83
Tobin Ehlis32479352015-12-01 09:48:58 -070084// fwd decls
85struct shader_module;
86struct render_pass;
87
Cody Northrop73bb6572015-09-28 15:09:32 -060088struct layer_data {
Tobin Ehlisad61de42015-12-02 13:53:34 -070089 debug_report_data* report_data;
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -070090 std::vector<VkDebugReportCallbackEXT> logging_callback;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -060091 VkLayerDispatchTable* device_dispatch_table;
92 VkLayerInstanceDispatchTable* instance_dispatch_table;
93 devExts device_extensions;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -060094 // Layer specific data
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -070095 unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> sampleMap;
96 unordered_map<VkImageView, unique_ptr<VkImageViewCreateInfo>> imageViewMap;
97 unordered_map<VkImage, unique_ptr<VkImageCreateInfo>> imageMap;
98 unordered_map<VkBufferView, unique_ptr<VkBufferViewCreateInfo>> bufferViewMap;
99 unordered_map<VkBuffer, unique_ptr<VkBufferCreateInfo>> bufferMap;
100 unordered_map<VkPipeline, PIPELINE_NODE*> pipelineMap;
Tobin Ehlis4c8381e2015-12-14 13:46:38 -0700101 unordered_map<VkCommandPool, CMD_POOL_INFO> commandPoolMap;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700102 unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE*> descriptorPoolMap;
103 unordered_map<VkDescriptorSet, SET_NODE*> setMap;
Tobin Ehlisad61de42015-12-02 13:53:34 -0700104 unordered_map<VkDescriptorSetLayout, LAYOUT_NODE*> descriptorSetLayoutMap;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700105 unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap;
106 unordered_map<VkDeviceMemory, VkImage> memImageMap;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600107 // Map for layout chains
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -0700108 unordered_map<void*, GLOBAL_CB_NODE*> commandBufferMap;
109 unordered_map<VkFramebuffer, VkFramebufferCreateInfo*> frameBufferMap;
110 unordered_map<VkImage, IMAGE_NODE*> imageLayoutMap;
111 unordered_map<VkRenderPass, RENDER_PASS_NODE*> renderPassMap;
Tobin Ehlisad61de42015-12-02 13:53:34 -0700112 unordered_map<VkShaderModule, shader_module*> shaderModuleMap;
Michael Lentine27b0f902015-10-12 11:30:14 -0500113 // Current render pass
114 VkRenderPassBeginInfo renderPassBeginInfo;
115 uint32_t currentSubpass;
Cody Northrop73bb6572015-09-28 15:09:32 -0600116
117 layer_data() :
118 report_data(nullptr),
Tobin Ehlise6ab55a2015-10-07 09:38:40 -0600119 device_dispatch_table(nullptr),
120 instance_dispatch_table(nullptr),
121 device_extensions()
Cody Northrop73bb6572015-09-28 15:09:32 -0600122 {};
123};
Tobin Ehlis32479352015-12-01 09:48:58 -0700124// Code imported from ShaderChecker
125static void
126build_type_def_index(std::vector<unsigned> const &words, std::unordered_map<unsigned, unsigned> &type_def_index);
127
128struct shader_module {
129 /* the spirv image itself */
130 vector<uint32_t> words;
131 /* a mapping of <id> to the first word of its def. this is useful because walking type
132 * trees requires jumping all over the instruction stream.
133 */
134 unordered_map<unsigned, unsigned> type_def_index;
135
136 shader_module(VkShaderModuleCreateInfo const *pCreateInfo) :
137 words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)),
138 type_def_index() {
139
140 build_type_def_index(words, type_def_index);
141 }
142};
143
Tobin Ehlisd04ccab2015-10-07 15:40:22 -0600144// TODO : Do we need to guard access to layer_data_map w/ lock?
Tobin Ehlisad61de42015-12-02 13:53:34 -0700145static unordered_map<void*, layer_data*> layer_data_map;
Courtney Goeltzenleuchterc280adc2015-06-13 21:23:09 -0600146
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600147static LOADER_PLATFORM_THREAD_ONCE_DECLARATION(g_initOnce);
148// TODO : This can be much smarter, using separate locks for separate global data
149static int globalLockInitialized = 0;
150static loader_platform_thread_mutex globalLock;
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600151#define MAX_TID 513
152static loader_platform_thread_id g_tidMapping[MAX_TID] = {0};
153static uint32_t g_maxTID = 0;
Tobin Ehlisfde4dce2015-06-16 15:50:44 -0600154
155template layer_data *get_my_data_ptr<layer_data>(
156 void *data_key,
157 std::unordered_map<void *, layer_data *> &data_map);
158
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600159// Map actual TID to an index value and return that index
160// This keeps TIDs in range from 0-MAX_TID and simplifies compares between runs
161static uint32_t getTIDIndex() {
162 loader_platform_thread_id tid = loader_platform_get_thread_id();
163 for (uint32_t i = 0; i < g_maxTID; i++) {
164 if (tid == g_tidMapping[i])
165 return i;
166 }
167 // Don't yet have mapping, set it and return newly set index
168 uint32_t retVal = (uint32_t) g_maxTID;
169 g_tidMapping[g_maxTID++] = tid;
170 assert(g_maxTID < MAX_TID);
171 return retVal;
172}
Tobin Ehlis982099b2015-11-05 09:52:49 -0700173
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600174// Return a string representation of CMD_TYPE enum
175static string cmdTypeToString(CMD_TYPE cmd)
176{
177 switch (cmd)
178 {
179 case CMD_BINDPIPELINE:
180 return "CMD_BINDPIPELINE";
181 case CMD_BINDPIPELINEDELTA:
182 return "CMD_BINDPIPELINEDELTA";
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -0600183 case CMD_SETVIEWPORTSTATE:
184 return "CMD_SETVIEWPORTSTATE";
185 case CMD_SETLINEWIDTHSTATE:
186 return "CMD_SETLINEWIDTHSTATE";
187 case CMD_SETDEPTHBIASSTATE:
188 return "CMD_SETDEPTHBIASSTATE";
189 case CMD_SETBLENDSTATE:
190 return "CMD_SETBLENDSTATE";
191 case CMD_SETDEPTHBOUNDSSTATE:
192 return "CMD_SETDEPTHBOUNDSSTATE";
193 case CMD_SETSTENCILREADMASKSTATE:
194 return "CMD_SETSTENCILREADMASKSTATE";
195 case CMD_SETSTENCILWRITEMASKSTATE:
196 return "CMD_SETSTENCILWRITEMASKSTATE";
197 case CMD_SETSTENCILREFERENCESTATE:
198 return "CMD_SETSTENCILREFERENCESTATE";
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600199 case CMD_BINDDESCRIPTORSETS:
200 return "CMD_BINDDESCRIPTORSETS";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600201 case CMD_BINDINDEXBUFFER:
202 return "CMD_BINDINDEXBUFFER";
203 case CMD_BINDVERTEXBUFFER:
204 return "CMD_BINDVERTEXBUFFER";
205 case CMD_DRAW:
206 return "CMD_DRAW";
207 case CMD_DRAWINDEXED:
208 return "CMD_DRAWINDEXED";
209 case CMD_DRAWINDIRECT:
210 return "CMD_DRAWINDIRECT";
211 case CMD_DRAWINDEXEDINDIRECT:
212 return "CMD_DRAWINDEXEDINDIRECT";
213 case CMD_DISPATCH:
214 return "CMD_DISPATCH";
215 case CMD_DISPATCHINDIRECT:
216 return "CMD_DISPATCHINDIRECT";
217 case CMD_COPYBUFFER:
218 return "CMD_COPYBUFFER";
219 case CMD_COPYIMAGE:
220 return "CMD_COPYIMAGE";
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -0600221 case CMD_BLITIMAGE:
222 return "CMD_BLITIMAGE";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600223 case CMD_COPYBUFFERTOIMAGE:
224 return "CMD_COPYBUFFERTOIMAGE";
225 case CMD_COPYIMAGETOBUFFER:
226 return "CMD_COPYIMAGETOBUFFER";
227 case CMD_CLONEIMAGEDATA:
228 return "CMD_CLONEIMAGEDATA";
229 case CMD_UPDATEBUFFER:
230 return "CMD_UPDATEBUFFER";
231 case CMD_FILLBUFFER:
232 return "CMD_FILLBUFFER";
233 case CMD_CLEARCOLORIMAGE:
234 return "CMD_CLEARCOLORIMAGE";
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -0600235 case CMD_CLEARATTACHMENTS:
Tobin Ehlis8cd650e2015-07-01 16:46:13 -0600236 return "CMD_CLEARCOLORATTACHMENT";
237 case CMD_CLEARDEPTHSTENCILIMAGE:
238 return "CMD_CLEARDEPTHSTENCILIMAGE";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600239 case CMD_RESOLVEIMAGE:
240 return "CMD_RESOLVEIMAGE";
241 case CMD_SETEVENT:
242 return "CMD_SETEVENT";
243 case CMD_RESETEVENT:
244 return "CMD_RESETEVENT";
245 case CMD_WAITEVENTS:
246 return "CMD_WAITEVENTS";
247 case CMD_PIPELINEBARRIER:
248 return "CMD_PIPELINEBARRIER";
249 case CMD_BEGINQUERY:
250 return "CMD_BEGINQUERY";
251 case CMD_ENDQUERY:
252 return "CMD_ENDQUERY";
253 case CMD_RESETQUERYPOOL:
254 return "CMD_RESETQUERYPOOL";
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -0600255 case CMD_COPYQUERYPOOLRESULTS:
256 return "CMD_COPYQUERYPOOLRESULTS";
Tobin Ehlis63bb9482015-03-17 16:24:32 -0600257 case CMD_WRITETIMESTAMP:
258 return "CMD_WRITETIMESTAMP";
259 case CMD_INITATOMICCOUNTERS:
260 return "CMD_INITATOMICCOUNTERS";
261 case CMD_LOADATOMICCOUNTERS:
262 return "CMD_LOADATOMICCOUNTERS";
263 case CMD_SAVEATOMICCOUNTERS:
264 return "CMD_SAVEATOMICCOUNTERS";
265 case CMD_BEGINRENDERPASS:
266 return "CMD_BEGINRENDERPASS";
267 case CMD_ENDRENDERPASS:
268 return "CMD_ENDRENDERPASS";
269 case CMD_DBGMARKERBEGIN:
270 return "CMD_DBGMARKERBEGIN";
271 case CMD_DBGMARKEREND:
272 return "CMD_DBGMARKEREND";
273 default:
274 return "UNKNOWN";
275 }
276}
Tobin Ehlis32479352015-12-01 09:48:58 -0700277
278// SPIRV utility functions
279static void
280build_type_def_index(std::vector<unsigned> const &words, std::unordered_map<unsigned, unsigned> &type_def_index)
281{
282 unsigned int const *code = (unsigned int const *)&words[0];
283 size_t size = words.size();
284
285 unsigned word = 5;
286 while (word < size) {
287 unsigned opcode = code[word] & 0x0ffffu;
288 unsigned oplen = (code[word] & 0xffff0000u) >> 16;
289
290 switch (opcode) {
291 case spv::OpTypeVoid:
292 case spv::OpTypeBool:
293 case spv::OpTypeInt:
294 case spv::OpTypeFloat:
295 case spv::OpTypeVector:
296 case spv::OpTypeMatrix:
297 case spv::OpTypeImage:
298 case spv::OpTypeSampler:
299 case spv::OpTypeSampledImage:
300 case spv::OpTypeArray:
301 case spv::OpTypeRuntimeArray:
302 case spv::OpTypeStruct:
303 case spv::OpTypeOpaque:
304 case spv::OpTypePointer:
305 case spv::OpTypeFunction:
306 case spv::OpTypeEvent:
307 case spv::OpTypeDeviceEvent:
308 case spv::OpTypeReserveId:
309 case spv::OpTypeQueue:
310 case spv::OpTypePipe:
311 type_def_index[code[word+1]] = word;
312 break;
313
314 default:
315 /* We only care about type definitions */
316 break;
317 }
318
319 word += oplen;
320 }
321}
322
323bool
324shader_is_spirv(VkShaderModuleCreateInfo const *pCreateInfo)
325{
326 uint32_t *words = (uint32_t *)pCreateInfo->pCode;
327 size_t sizeInWords = pCreateInfo->codeSize / sizeof(uint32_t);
328
329 /* Just validate that the header makes sense. */
330 return sizeInWords >= 5 && words[0] == spv::MagicNumber && words[1] == spv::Version;
331}
332
333static char const *
334storage_class_name(unsigned sc)
335{
336 switch (sc) {
337 case spv::StorageClassInput: return "input";
338 case spv::StorageClassOutput: return "output";
339 case spv::StorageClassUniformConstant: return "const uniform";
340 case spv::StorageClassUniform: return "uniform";
341 case spv::StorageClassWorkgroup: return "workgroup local";
342 case spv::StorageClassCrossWorkgroup: return "workgroup global";
343 case spv::StorageClassPrivate: return "private global";
344 case spv::StorageClassFunction: return "function";
345 case spv::StorageClassGeneric: return "generic";
346 case spv::StorageClassAtomicCounter: return "atomic counter";
347 case spv::StorageClassImage: return "image";
348 default: return "unknown";
349 }
350}
351
352/* returns ptr to null terminator */
353static char *
354describe_type(char *dst, shader_module const *src, unsigned type)
355{
356 auto type_def_it = src->type_def_index.find(type);
357
358 if (type_def_it == src->type_def_index.end()) {
359 return dst + sprintf(dst, "undef");
360 }
361
362 unsigned int const *code = (unsigned int const *)&src->words[type_def_it->second];
363 unsigned opcode = code[0] & 0x0ffffu;
364 switch (opcode) {
365 case spv::OpTypeBool:
366 return dst + sprintf(dst, "bool");
367 case spv::OpTypeInt:
368 return dst + sprintf(dst, "%cint%d", code[3] ? 's' : 'u', code[2]);
369 case spv::OpTypeFloat:
370 return dst + sprintf(dst, "float%d", code[2]);
371 case spv::OpTypeVector:
372 dst += sprintf(dst, "vec%d of ", code[3]);
373 return describe_type(dst, src, code[2]);
374 case spv::OpTypeMatrix:
375 dst += sprintf(dst, "mat%d of ", code[3]);
376 return describe_type(dst, src, code[2]);
377 case spv::OpTypeArray:
378 dst += sprintf(dst, "arr[%d] of ", code[3]);
379 return describe_type(dst, src, code[2]);
380 case spv::OpTypePointer:
381 dst += sprintf(dst, "ptr to %s ", storage_class_name(code[2]));
382 return describe_type(dst, src, code[3]);
383 case spv::OpTypeStruct:
384 {
385 unsigned oplen = code[0] >> 16;
386 dst += sprintf(dst, "struct of (");
387 for (unsigned i = 2; i < oplen; i++) {
388 dst = describe_type(dst, src, code[i]);
389 dst += sprintf(dst, i == oplen-1 ? ")" : ", ");
390 }
391 return dst;
392 }
393 case spv::OpTypeSampler:
394 return dst + sprintf(dst, "sampler");
395 default:
396 return dst + sprintf(dst, "oddtype");
397 }
398}
399
400static bool
401types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool b_arrayed)
402{
403 auto a_type_def_it = a->type_def_index.find(a_type);
404 auto b_type_def_it = b->type_def_index.find(b_type);
405
406 if (a_type_def_it == a->type_def_index.end()) {
407 return false;
408 }
409
410 if (b_type_def_it == b->type_def_index.end()) {
411 return false;
412 }
413
414 /* walk two type trees together, and complain about differences */
415 unsigned int const *a_code = (unsigned int const *)&a->words[a_type_def_it->second];
416 unsigned int const *b_code = (unsigned int const *)&b->words[b_type_def_it->second];
417
418 unsigned a_opcode = a_code[0] & 0x0ffffu;
419 unsigned b_opcode = b_code[0] & 0x0ffffu;
420
421 if (b_arrayed && b_opcode == spv::OpTypeArray) {
422 /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */
423 return types_match(a, b, a_type, b_code[2], false);
424 }
425
426 if (a_opcode != b_opcode) {
427 return false;
428 }
429
430 switch (a_opcode) {
431 /* if b_arrayed and we hit a leaf type, then we can't match -- there's nowhere for the extra OpTypeArray to be! */
432 case spv::OpTypeBool:
433 return true && !b_arrayed;
434 case spv::OpTypeInt:
435 /* match on width, signedness */
436 return a_code[2] == b_code[2] && a_code[3] == b_code[3] && !b_arrayed;
437 case spv::OpTypeFloat:
438 /* match on width */
439 return a_code[2] == b_code[2] && !b_arrayed;
440 case spv::OpTypeVector:
441 case spv::OpTypeMatrix:
442 case spv::OpTypeArray:
443 /* match on element type, count. these all have the same layout. we don't get here if
444 * b_arrayed -- that is handled above. */
445 return !b_arrayed && types_match(a, b, a_code[2], b_code[2], b_arrayed) && a_code[3] == b_code[3];
446 case spv::OpTypeStruct:
447 /* match on all element types */
448 {
449 if (b_arrayed) {
450 /* for the purposes of matching different levels of arrayness, structs are leaves. */
451 return false;
452 }
453
454 unsigned a_len = a_code[0] >> 16;
455 unsigned b_len = b_code[0] >> 16;
456
457 if (a_len != b_len) {
458 return false; /* structs cannot match if member counts differ */
459 }
460
461 for (unsigned i = 2; i < a_len; i++) {
462 if (!types_match(a, b, a_code[i], b_code[i], b_arrayed)) {
463 return false;
464 }
465 }
466
467 return true;
468 }
469 case spv::OpTypePointer:
470 /* match on pointee type. storage class is expected to differ */
471 return types_match(a, b, a_code[3], b_code[3], b_arrayed);
472
473 default:
474 /* remaining types are CLisms, or may not appear in the interfaces we
475 * are interested in. Just claim no match.
476 */
477 return false;
478
479 }
480}
481
482static int
483value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def)
484{
485 auto it = map.find(id);
486 if (it == map.end())
487 return def;
488 else
489 return it->second;
490}
491
492
493static unsigned
494get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level)
495{
496 auto type_def_it = src->type_def_index.find(type);
497
498 if (type_def_it == src->type_def_index.end()) {
499 return 1; /* This is actually broken SPIR-V... */
500 }
501
502 unsigned int const *code = (unsigned int const *)&src->words[type_def_it->second];
503 unsigned opcode = code[0] & 0x0ffffu;
504
505 switch (opcode) {
506 case spv::OpTypePointer:
507 /* see through the ptr -- this is only ever at the toplevel for graphics shaders;
508 * we're never actually passing pointers around. */
509 return get_locations_consumed_by_type(src, code[3], strip_array_level);
510 case spv::OpTypeArray:
511 if (strip_array_level) {
512 return get_locations_consumed_by_type(src, code[2], false);
513 }
514 else {
515 return code[3] * get_locations_consumed_by_type(src, code[2], false);
516 }
517 case spv::OpTypeMatrix:
518 /* num locations is the dimension * element size */
519 return code[3] * get_locations_consumed_by_type(src, code[2], false);
520 default:
521 /* everything else is just 1. */
522 return 1;
523
524 /* TODO: extend to handle 64bit scalar types, whose vectors may need
525 * multiple locations. */
526 }
527}
528
529
530struct interface_var {
531 uint32_t id;
532 uint32_t type_id;
533 uint32_t offset;
534 /* TODO: collect the name, too? Isn't required to be present. */
535};
536
537static void
538collect_interface_by_location(layer_data *my_data, VkDevice dev,
539 shader_module const *src, spv::StorageClass sinterface,
540 std::map<uint32_t, interface_var> &out,
541 std::map<uint32_t, interface_var> &builtins_out,
542 bool is_array_of_verts)
543{
544 unsigned int const *code = (unsigned int const *)&src->words[0];
545 size_t size = src->words.size();
546
547 std::unordered_map<unsigned, unsigned> var_locations;
548 std::unordered_map<unsigned, unsigned> var_builtins;
549
550 unsigned word = 5;
551 while (word < size) {
552
553 unsigned opcode = code[word] & 0x0ffffu;
554 unsigned oplen = (code[word] & 0xffff0000u) >> 16;
555
556 /* We consider two interface models: SSO rendezvous-by-location, and
557 * builtins. Complain about anything that fits neither model.
558 */
559 if (opcode == spv::OpDecorate) {
560 if (code[word+2] == spv::DecorationLocation) {
561 var_locations[code[word+1]] = code[word+3];
562 }
563
564 if (code[word+2] == spv::DecorationBuiltIn) {
565 var_builtins[code[word+1]] = code[word+3];
566 }
567 }
568
569 /* TODO: handle grouped decorations */
570 /* TODO: handle index=1 dual source outputs from FS -- two vars will
571 * have the same location, and we DONT want to clobber. */
572
573 if (opcode == spv::OpVariable && code[word+3] == sinterface) {
574 unsigned id = code[word+2];
575 unsigned type = code[word+1];
576
577 int location = value_or_default(var_locations, code[word+2], -1);
578 int builtin = value_or_default(var_builtins, code[word+2], -1);
579
580 if (location == -1 && builtin == -1) {
581 /* No location defined, and not bound to an API builtin.
582 * The spec says nothing about how this case works (or doesn't)
583 * for interface matching.
584 */
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700585 log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700586 "var %d (type %d) in %s interface has no Location or Builtin decoration",
587 code[word+2], code[word+1], storage_class_name(sinterface));
588 }
589 else if (location != -1) {
590 /* A user-defined interface variable, with a location. Where a variable
591 * occupied multiple locations, emit one result for each. */
592 unsigned num_locations = get_locations_consumed_by_type(src, type,
593 is_array_of_verts);
Courtney Goeltzenleuchter740451a2015-12-16 16:06:06 -0700594 for (unsigned int offset = 0; offset < num_locations; offset++) {
Tobin Ehlis32479352015-12-01 09:48:58 -0700595 interface_var v;
596 v.id = id;
597 v.type_id = type;
598 v.offset = offset;
599 out[location + offset] = v;
600 }
601 }
602 else {
603 /* A builtin interface variable */
604 /* Note that since builtin interface variables do not consume numbered
605 * locations, there is no larger-than-vec4 consideration as above
606 */
607 interface_var v;
608 v.id = id;
609 v.type_id = type;
610 v.offset = 0;
611 builtins_out[builtin] = v;
612 }
613 }
614
615 word += oplen;
616 }
617}
618
619static void
620collect_interface_by_descriptor_slot(layer_data *my_data, VkDevice dev,
621 shader_module const *src, spv::StorageClass sinterface,
622 std::map<std::pair<unsigned, unsigned>, interface_var> &out)
623{
624 unsigned int const *code = (unsigned int const *)&src->words[0];
625 size_t size = src->words.size();
626
627 std::unordered_map<unsigned, unsigned> var_sets;
628 std::unordered_map<unsigned, unsigned> var_bindings;
629
630 unsigned word = 5;
631 while (word < size) {
632
633 unsigned opcode = code[word] & 0x0ffffu;
634 unsigned oplen = (code[word] & 0xffff0000u) >> 16;
635
636 /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both
637 * DecorationDescriptorSet and DecorationBinding.
638 */
639 if (opcode == spv::OpDecorate) {
640 if (code[word+2] == spv::DecorationDescriptorSet) {
641 var_sets[code[word+1]] = code[word+3];
642 }
643
644 if (code[word+2] == spv::DecorationBinding) {
645 var_bindings[code[word+1]] = code[word+3];
646 }
647 }
648
649 if (opcode == spv::OpVariable && (code[word+3] == spv::StorageClassUniform ||
650 code[word+3] == spv::StorageClassUniformConstant)) {
651 unsigned set = value_or_default(var_sets, code[word+2], 0);
652 unsigned binding = value_or_default(var_bindings, code[word+2], 0);
653
654 auto existing_it = out.find(std::make_pair(set, binding));
655 if (existing_it != out.end()) {
656 /* conflict within spv image */
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700657 log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0,
Tobin Ehlis32479352015-12-01 09:48:58 -0700658 SHADER_CHECKER_INCONSISTENT_SPIRV, "SC",
659 "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition",
660 code[word+2], code[word+1], storage_class_name(sinterface),
661 existing_it->first.first, existing_it->first.second);
662 }
663
664 interface_var v;
665 v.id = code[word+2];
666 v.type_id = code[word+1];
667 out[std::make_pair(set, binding)] = v;
668 }
669
670 word += oplen;
671 }
672}
673
674static bool
675validate_interface_between_stages(layer_data *my_data, VkDevice dev,
676 shader_module const *producer, char const *producer_name,
677 shader_module const *consumer, char const *consumer_name,
678 bool consumer_arrayed_input)
679{
680 std::map<uint32_t, interface_var> outputs;
681 std::map<uint32_t, interface_var> inputs;
682
683 std::map<uint32_t, interface_var> builtin_outputs;
684 std::map<uint32_t, interface_var> builtin_inputs;
685
686 bool pass = true;
687
688 collect_interface_by_location(my_data, dev, producer, spv::StorageClassOutput, outputs, builtin_outputs, false);
689 collect_interface_by_location(my_data, dev, consumer, spv::StorageClassInput, inputs, builtin_inputs,
690 consumer_arrayed_input);
691
692 auto a_it = outputs.begin();
693 auto b_it = inputs.begin();
694
695 /* maps sorted by key (location); walk them together to find mismatches */
696 while ((outputs.size() > 0 && a_it != outputs.end()) || ( inputs.size() && b_it != inputs.end())) {
697 bool a_at_end = outputs.size() == 0 || a_it == outputs.end();
698 bool b_at_end = inputs.size() == 0 || b_it == inputs.end();
699 auto a_first = a_at_end ? 0 : a_it->first;
700 auto b_first = b_at_end ? 0 : b_it->first;
701
702 if (b_at_end || ((!a_at_end) && (a_first < b_first))) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700703 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700704 "%s writes to output location %d which is not consumed by %s", producer_name, a_first, consumer_name)) {
705 pass = false;
706 }
707 a_it++;
708 }
709 else if (a_at_end || a_first > b_first) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700710 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700711 "%s consumes input location %d which is not written by %s", consumer_name, b_first, producer_name)) {
712 pass = false;
713 }
714 b_it++;
715 }
716 else {
717 if (types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, consumer_arrayed_input)) {
718 /* OK! */
719 }
720 else {
721 char producer_type[1024];
722 char consumer_type[1024];
723 describe_type(producer_type, producer, a_it->second.type_id);
724 describe_type(consumer_type, consumer, b_it->second.type_id);
725
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700726 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700727 "Type mismatch on location %d: '%s' vs '%s'", a_it->first, producer_type, consumer_type)) {
728 pass = false;
729 }
730 }
731 a_it++;
732 b_it++;
733 }
734 }
735
736 return pass;
737}
738
739enum FORMAT_TYPE {
740 FORMAT_TYPE_UNDEFINED,
741 FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */
742 FORMAT_TYPE_SINT,
743 FORMAT_TYPE_UINT,
744};
745
746static unsigned
747get_format_type(VkFormat fmt) {
748 switch (fmt) {
749 case VK_FORMAT_UNDEFINED:
750 return FORMAT_TYPE_UNDEFINED;
751 case VK_FORMAT_R8_SINT:
752 case VK_FORMAT_R8G8_SINT:
753 case VK_FORMAT_R8G8B8_SINT:
754 case VK_FORMAT_R8G8B8A8_SINT:
755 case VK_FORMAT_R16_SINT:
756 case VK_FORMAT_R16G16_SINT:
757 case VK_FORMAT_R16G16B16_SINT:
758 case VK_FORMAT_R16G16B16A16_SINT:
759 case VK_FORMAT_R32_SINT:
760 case VK_FORMAT_R32G32_SINT:
761 case VK_FORMAT_R32G32B32_SINT:
762 case VK_FORMAT_R32G32B32A32_SINT:
763 case VK_FORMAT_B8G8R8_SINT:
764 case VK_FORMAT_B8G8R8A8_SINT:
765 case VK_FORMAT_A2B10G10R10_SINT_PACK32:
766 case VK_FORMAT_A2R10G10B10_SINT_PACK32:
767 return FORMAT_TYPE_SINT;
768 case VK_FORMAT_R8_UINT:
769 case VK_FORMAT_R8G8_UINT:
770 case VK_FORMAT_R8G8B8_UINT:
771 case VK_FORMAT_R8G8B8A8_UINT:
772 case VK_FORMAT_R16_UINT:
773 case VK_FORMAT_R16G16_UINT:
774 case VK_FORMAT_R16G16B16_UINT:
775 case VK_FORMAT_R16G16B16A16_UINT:
776 case VK_FORMAT_R32_UINT:
777 case VK_FORMAT_R32G32_UINT:
778 case VK_FORMAT_R32G32B32_UINT:
779 case VK_FORMAT_R32G32B32A32_UINT:
780 case VK_FORMAT_B8G8R8_UINT:
781 case VK_FORMAT_B8G8R8A8_UINT:
782 case VK_FORMAT_A2B10G10R10_UINT_PACK32:
783 case VK_FORMAT_A2R10G10B10_UINT_PACK32:
784 return FORMAT_TYPE_UINT;
785 default:
786 return FORMAT_TYPE_FLOAT;
787 }
788}
789
790/* characterizes a SPIR-V type appearing in an interface to a FF stage,
791 * for comparison to a VkFormat's characterization above. */
792static unsigned
793get_fundamental_type(shader_module const *src, unsigned type)
794{
795 auto type_def_it = src->type_def_index.find(type);
796
797 if (type_def_it == src->type_def_index.end()) {
798 return FORMAT_TYPE_UNDEFINED;
799 }
800
801 unsigned int const *code = (unsigned int const *)&src->words[type_def_it->second];
802 unsigned opcode = code[0] & 0x0ffffu;
803 switch (opcode) {
804 case spv::OpTypeInt:
805 return code[3] ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT;
806 case spv::OpTypeFloat:
807 return FORMAT_TYPE_FLOAT;
808 case spv::OpTypeVector:
809 return get_fundamental_type(src, code[2]);
810 case spv::OpTypeMatrix:
811 return get_fundamental_type(src, code[2]);
812 case spv::OpTypeArray:
813 return get_fundamental_type(src, code[2]);
814 case spv::OpTypePointer:
815 return get_fundamental_type(src, code[3]);
816 default:
817 return FORMAT_TYPE_UNDEFINED;
818 }
819}
820
821static bool
822validate_vi_consistency(layer_data *my_data, VkDevice dev, VkPipelineVertexInputStateCreateInfo const *vi)
823{
824 /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer.
825 * each binding should be specified only once.
826 */
827 std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings;
828 bool pass = true;
829
830 for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) {
831 auto desc = &vi->pVertexBindingDescriptions[i];
832 auto & binding = bindings[desc->binding];
833 if (binding) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700834 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INCONSISTENT_VI, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700835 "Duplicate vertex input binding descriptions for binding %d", desc->binding)) {
836 pass = false;
837 }
838 }
839 else {
840 binding = desc;
841 }
842 }
843
844 return pass;
845}
846
847static bool
848validate_vi_against_vs_inputs(layer_data *my_data, VkDevice dev, VkPipelineVertexInputStateCreateInfo const *vi, shader_module const *vs)
849{
850 std::map<uint32_t, interface_var> inputs;
851 /* we collect builtin inputs, but they will never appear in the VI state --
852 * the vs builtin inputs are generated in the pipeline, not sourced from buffers (VertexID, etc)
853 */
854 std::map<uint32_t, interface_var> builtin_inputs;
855 bool pass = true;
856
857 collect_interface_by_location(my_data, dev, vs, spv::StorageClassInput, inputs, builtin_inputs, false);
858
859 /* Build index by location */
860 std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs;
861 if (vi) {
862 for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++)
863 attribs[vi->pVertexAttributeDescriptions[i].location] = &vi->pVertexAttributeDescriptions[i];
864 }
865
866 auto it_a = attribs.begin();
867 auto it_b = inputs.begin();
868
869 while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) {
870 bool a_at_end = attribs.size() == 0 || it_a == attribs.end();
871 bool b_at_end = inputs.size() == 0 || it_b == inputs.end();
872 auto a_first = a_at_end ? 0 : it_a->first;
873 auto b_first = b_at_end ? 0 : it_b->first;
874 if (b_at_end || a_first < b_first) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700875 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700876 "Vertex attribute at location %d not consumed by VS", a_first)) {
877 pass = false;
878 }
879 it_a++;
880 }
881 else if (a_at_end || b_first < a_first) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700882 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700883 "VS consumes input at location %d but not provided", b_first)) {
884 pass = false;
885 }
886 it_b++;
887 }
888 else {
889 unsigned attrib_type = get_format_type(it_a->second->format);
890 unsigned input_type = get_fundamental_type(vs, it_b->second.type_id);
891
892 /* type checking */
893 if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) {
894 char vs_type[1024];
895 describe_type(vs_type, vs, it_b->second.type_id);
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700896 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700897 "Attribute type of `%s` at location %d does not match VS input type of `%s`",
898 string_VkFormat(it_a->second->format), a_first, vs_type)) {
899 pass = false;
900 }
901 }
902
903 /* OK! */
904 it_a++;
905 it_b++;
906 }
907 }
908
909 return pass;
910}
911
912static bool
Tobin Ehlisad61de42015-12-02 13:53:34 -0700913validate_fs_outputs_against_render_pass(layer_data *my_data, VkDevice dev, shader_module const *fs, RENDER_PASS_NODE const *rp, uint32_t subpass)
Tobin Ehlis32479352015-12-01 09:48:58 -0700914{
Tobin Ehlisad61de42015-12-02 13:53:34 -0700915 const std::vector<VkFormat> &color_formats = rp->subpassColorFormats[subpass];
Tobin Ehlis32479352015-12-01 09:48:58 -0700916 std::map<uint32_t, interface_var> outputs;
917 std::map<uint32_t, interface_var> builtin_outputs;
918 bool pass = true;
919
920 /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */
921
922 collect_interface_by_location(my_data, dev, fs, spv::StorageClassOutput, outputs, builtin_outputs, false);
923
924 auto it = outputs.begin();
925 uint32_t attachment = 0;
926
927 /* Walk attachment list and outputs together -- this is a little overpowered since attachments
928 * are currently dense, but the parallel with matching between shader stages is nice.
929 */
930
931 /* TODO: Figure out compile error with cb->attachmentCount */
932 while ((outputs.size() > 0 && it != outputs.end()) || attachment < color_formats.size()) {
933 if (attachment == color_formats.size() || ( it != outputs.end() && it->first < attachment)) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700934 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700935 "FS writes to output location %d with no matching attachment", it->first)) {
936 pass = false;
937 }
938 it++;
939 }
940 else if (it == outputs.end() || it->first > attachment) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700941 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700942 "Attachment %d not written by FS", attachment)) {
943 pass = false;
944 }
945 attachment++;
946 }
947 else {
948 unsigned output_type = get_fundamental_type(fs, it->second.type_id);
949 unsigned att_type = get_format_type(color_formats[attachment]);
950
951 /* type checking */
952 if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) {
953 char fs_type[1024];
954 describe_type(fs_type, fs, it->second.type_id);
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -0700955 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -0700956 "Attachment %d of type `%s` does not match FS output type of `%s`",
957 attachment, string_VkFormat(color_formats[attachment]), fs_type)) {
958 pass = false;
959 }
960 }
961
962 /* OK! */
963 it++;
964 attachment++;
965 }
966 }
967
968 return pass;
969}
970
971
972struct shader_stage_attributes {
973 char const * const name;
974 bool arrayed_input;
975};
976
977
978static shader_stage_attributes
979shader_stage_attribs[] = {
980 { "vertex shader", false },
981 { "tessellation control shader", true },
982 { "tessellation evaluation shader", false },
983 { "geometry shader", true },
984 { "fragment shader", false },
985};
986
Tobin Ehlisad61de42015-12-02 13:53:34 -0700987// For given pipelineLayout verify that the setLayout at slot.first
988// has the requested binding at slot.second
Tobin Ehlis32479352015-12-01 09:48:58 -0700989static bool
Tobin Ehlisad61de42015-12-02 13:53:34 -0700990has_descriptor_binding(layer_data* my_data,
991 vector<VkDescriptorSetLayout>* pipelineLayout,
Tobin Ehlis32479352015-12-01 09:48:58 -0700992 std::pair<unsigned, unsigned> slot)
993{
Tobin Ehlisad61de42015-12-02 13:53:34 -0700994 if (!pipelineLayout)
Tobin Ehlis32479352015-12-01 09:48:58 -0700995 return false;
996
Tobin Ehlisad61de42015-12-02 13:53:34 -0700997 if (slot.first >= pipelineLayout->size())
Tobin Ehlis32479352015-12-01 09:48:58 -0700998 return false;
999
Tobin Ehlisad61de42015-12-02 13:53:34 -07001000 auto set = my_data->descriptorSetLayoutMap[(*pipelineLayout)[slot.first]]->bindings;
Tobin Ehlis32479352015-12-01 09:48:58 -07001001
Tobin Ehlisad61de42015-12-02 13:53:34 -07001002 return (set.find(slot.second) != set.end());
Tobin Ehlis32479352015-12-01 09:48:58 -07001003}
1004
1005static uint32_t get_shader_stage_id(VkShaderStageFlagBits stage)
1006{
1007 uint32_t bit_pos = u_ffs(stage);
1008 return bit_pos-1;
1009}
1010
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001011// Block of code at start here for managing/tracking Pipeline state that this layer cares about
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001012
1013static uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0};
1014
Chia-I Wu1f851912015-10-27 18:04:07 +08001015// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001016// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates
1017// to that same cmd buffer by separate thread are not changing state from underneath us
1018// Track the last cmd buffer touched by this thread
Tobin Ehlis32479352015-12-01 09:48:58 -07001019
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001020#define MAX_BINDING 0xFFFFFFFF // Default vtxBinding value in CB Node to identify if no vtxBinding set
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001021// prototype
Chia-I Wu1f851912015-10-27 18:04:07 +08001022static GLOBAL_CB_NODE* getCBNode(layer_data*, const VkCommandBuffer);
Tobin Ehlis982099b2015-11-05 09:52:49 -07001023
Courtney Goeltzenleuchter1f41f542015-07-09 11:44:38 -06001024static VkBool32 hasDrawCmd(GLOBAL_CB_NODE* pCB)
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06001025{
1026 for (uint32_t i=0; i<NUM_DRAW_TYPES; i++) {
1027 if (pCB->drawCount[i])
1028 return VK_TRUE;
1029 }
1030 return VK_FALSE;
1031}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001032
Tobin Ehlis97866202015-06-10 12:57:07 -06001033// Check object status for selected flag state
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001034static VkBool32 validate_status(layer_data* my_data, GLOBAL_CB_NODE* pNode, CBStatusFlags enable_mask, CBStatusFlags status_mask, CBStatusFlags status_flag, VkFlags msg_flags, DRAW_STATE_ERROR error_code, const char* fail_msg)
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06001035{
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06001036 // If non-zero enable mask is present, check it against status but if enable_mask
1037 // is 0 then no enable required so we should always just check status
1038 if ((!enable_mask) || (enable_mask & pNode->status)) {
1039 if ((pNode->status & status_mask) != status_flag) {
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06001040 // TODO : How to pass dispatchable objects as srcObject? Here src obj should be cmd buffer
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001041 return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, error_code, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08001042 "CB object %#" PRIxLEAST64 ": %s", reinterpret_cast<uint64_t>(pNode->commandBuffer), fail_msg);
Tobin Ehlis97866202015-06-10 12:57:07 -06001043 }
Tobin Ehlis97866202015-06-10 12:57:07 -06001044 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001045 return VK_FALSE;
Tobin Ehlis97866202015-06-10 12:57:07 -06001046}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001047
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001048// Retrieve pipeline node ptr for given pipeline object
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001049static PIPELINE_NODE* getPipeline(layer_data* my_data, const VkPipeline pipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001050{
1051 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08001052 if (my_data->pipelineMap.find(pipeline) == my_data->pipelineMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001053 loader_platform_thread_unlock_mutex(&globalLock);
1054 return NULL;
1055 }
1056 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08001057 return my_data->pipelineMap[pipeline];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001058}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001059
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001060// Return VK_TRUE if for a given PSO, the given state enum is dynamic, else return VK_FALSE
1061static VkBool32 isDynamic(const PIPELINE_NODE* pPipeline, const VkDynamicState state)
1062{
1063 if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) {
1064 for (uint32_t i=0; i<pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) {
1065 if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i])
1066 return VK_TRUE;
1067 }
1068 }
1069 return VK_FALSE;
1070}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001071
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06001072// Validate state stored as flags at time of draw call
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001073static VkBool32 validate_draw_state_flags(layer_data* my_data, GLOBAL_CB_NODE* pCB, VkBool32 indexedDraw) {
Courtney Goeltzenleuchter1f41f542015-07-09 11:44:38 -06001074 VkBool32 result;
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001075 result = validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_VIEWPORT_SET, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, "Dynamic viewport state not set for this command buffer");
1076 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_SCISSOR_SET, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, "Dynamic scissor state not set for this command buffer");
1077 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_LINE_WIDTH_SET, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer");
1078 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_DEPTH_BIAS_SET, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer");
1079 result |= validate_status(my_data, pCB, CBSTATUS_COLOR_BLEND_WRITE_ENABLE, CBSTATUS_BLEND_SET, CBSTATUS_BLEND_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend object state not set for this command buffer");
1080 result |= validate_status(my_data, pCB, CBSTATUS_DEPTH_WRITE_ENABLE, CBSTATUS_DEPTH_BOUNDS_SET, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer");
1081 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_READ_MASK_SET, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer");
1082 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_WRITE_MASK_SET, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer");
1083 result |= validate_status(my_data, pCB, CBSTATUS_STENCIL_TEST_ENABLE, CBSTATUS_STENCIL_REFERENCE_SET, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer");
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06001084 if (indexedDraw)
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001085 result |= validate_status(my_data, pCB, CBSTATUS_NONE, CBSTATUS_INDEX_BUFFER_BOUND, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_INDEX_BUFFER_NOT_BOUND, "Index buffer object not bound to this command buffer when Indexed Draw attempted");
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06001086 return result;
1087}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001088
1089// For give SET_NODE, verify that its Set is compatible w/ the setLayout corresponding to pipelineLayout[layoutIndex]
1090static bool verify_set_layout_compatibility(layer_data* my_data, const SET_NODE* pSet, const VkPipelineLayout layout, const uint32_t layoutIndex, string& errorMsg)
1091{
Tobin Ehliscb085292015-12-01 09:57:09 -07001092 stringstream errorStr;
Tobin Ehlis982099b2015-11-05 09:52:49 -07001093 if (my_data->pipelineLayoutMap.find(layout) == my_data->pipelineLayoutMap.end()) {
Tobin Ehliscb085292015-12-01 09:57:09 -07001094 errorStr << "invalid VkPipelineLayout (" << layout << ")";
1095 errorMsg = errorStr.str();
Tobin Ehlis982099b2015-11-05 09:52:49 -07001096 return false;
1097 }
1098 PIPELINE_LAYOUT_NODE pl = my_data->pipelineLayoutMap[layout];
1099 if (layoutIndex >= pl.descriptorSetLayouts.size()) {
Tobin Ehliscb085292015-12-01 09:57:09 -07001100 errorStr << "VkPipelineLayout (" << layout << ") only contains " << pl.descriptorSetLayouts.size() << " setLayouts corresponding to sets 0-" << pl.descriptorSetLayouts.size()-1 << ", but you're attempting to bind set to index " << layoutIndex;
1101 errorMsg = errorStr.str();
Tobin Ehlis982099b2015-11-05 09:52:49 -07001102 return false;
1103 }
1104 // Get the specific setLayout from PipelineLayout that overlaps this set
Tobin Ehlisad61de42015-12-02 13:53:34 -07001105 LAYOUT_NODE* pLayoutNode = my_data->descriptorSetLayoutMap[pl.descriptorSetLayouts[layoutIndex]];
Tobin Ehlis982099b2015-11-05 09:52:49 -07001106 if (pLayoutNode->layout == pSet->pLayout->layout) { // trivial pass case
1107 return true;
1108 }
Courtney Goeltzenleuchter740451a2015-12-16 16:06:06 -07001109 size_t descriptorCount = pLayoutNode->descriptorTypes.size();
Tobin Ehlis982099b2015-11-05 09:52:49 -07001110 if (descriptorCount != pSet->pLayout->descriptorTypes.size()) {
Tobin Ehliscb085292015-12-01 09:57:09 -07001111 errorStr << "setLayout " << layoutIndex << " from pipelineLayout " << layout << " has " << descriptorCount << " descriptors, but corresponding set being bound has " << pSet->pLayout->descriptorTypes.size() << " descriptors.";
1112 errorMsg = errorStr.str();
Tobin Ehlis982099b2015-11-05 09:52:49 -07001113 return false; // trivial fail case
1114 }
1115 // Now need to check set against corresponding pipelineLayout to verify compatibility
Courtney Goeltzenleuchter740451a2015-12-16 16:06:06 -07001116 for (size_t i=0; i<descriptorCount; ++i) {
Tobin Ehlis982099b2015-11-05 09:52:49 -07001117 // Need to verify that layouts are identically defined
1118 // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor
1119 // do we also need to check immutable samplers?
1120 if (pLayoutNode->descriptorTypes[i] != pSet->pLayout->descriptorTypes[i]) {
Tobin Ehliscb085292015-12-01 09:57:09 -07001121 errorStr << "descriptor " << i << " for descriptorSet being bound is type '" << string_VkDescriptorType(pSet->pLayout->descriptorTypes[i]) << "' but corresponding descriptor from pipelineLayout is type '" << string_VkDescriptorType(pLayoutNode->descriptorTypes[i]) << "'";
1122 errorMsg = errorStr.str();
Tobin Ehlis982099b2015-11-05 09:52:49 -07001123 return false;
1124 }
1125 if (pLayoutNode->stageFlags[i] != pSet->pLayout->stageFlags[i]) {
Tobin Ehliscb085292015-12-01 09:57:09 -07001126 errorStr << "stageFlags " << i << " for descriptorSet being bound is " << pSet->pLayout->stageFlags[i] << "' but corresponding descriptor from pipelineLayout has stageFlags " << pLayoutNode->stageFlags[i];
1127 errorMsg = errorStr.str();
Tobin Ehlis982099b2015-11-05 09:52:49 -07001128 return false;
1129 }
1130 }
1131 return true;
1132}
1133
Tobin Ehlisd17c28c2015-12-03 09:40:56 -07001134// Validate that the shaders used by the given pipeline
1135// As a side effect this function also records the sets that are actually used by the pipeline
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07001136static VkBool32
Tobin Ehlisd17c28c2015-12-03 09:40:56 -07001137validate_pipeline_shaders(layer_data *my_data, VkDevice dev, PIPELINE_NODE* pPipeline)
Tobin Ehlis32479352015-12-01 09:48:58 -07001138{
Tobin Ehlisd17c28c2015-12-03 09:40:56 -07001139 VkGraphicsPipelineCreateInfo const *pCreateInfo = &pPipeline->graphicsPipelineCI;
Tobin Ehlis32479352015-12-01 09:48:58 -07001140 /* We seem to allow pipeline stages to be specified out of order, so collect and identify them
1141 * before trying to do anything more: */
1142 int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT);
1143 int geometry_stage = get_shader_stage_id(VK_SHADER_STAGE_GEOMETRY_BIT);
1144 int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT);
1145
1146 shader_module **shaders = new shader_module*[fragment_stage + 1]; /* exclude CS */
1147 memset(shaders, 0, sizeof(shader_module *) * (fragment_stage +1));
Tobin Ehlisad61de42015-12-02 13:53:34 -07001148 RENDER_PASS_NODE const *rp = 0;
Tobin Ehlis32479352015-12-01 09:48:58 -07001149 VkPipelineVertexInputStateCreateInfo const *vi = 0;
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07001150 VkBool32 pass = true;
Tobin Ehlis32479352015-12-01 09:48:58 -07001151
1152 for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) {
1153 VkPipelineShaderStageCreateInfo const *pStage = &pCreateInfo->pStages[i];
1154 if (pStage->sType == VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO) {
1155
1156 if ((pStage->stage & (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT
1157 | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT)) == 0) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001158 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0, SHADER_CHECKER_UNKNOWN_STAGE, "SC",
Tobin Ehlis32479352015-12-01 09:48:58 -07001159 "Unknown shader stage %d", pStage->stage)) {
1160 pass = false;
1161 }
1162 }
1163 else {
Tobin Ehlisad61de42015-12-02 13:53:34 -07001164 shader_module *module = my_data->shaderModuleMap[pStage->module];
Tobin Ehlis32479352015-12-01 09:48:58 -07001165 shaders[get_shader_stage_id(pStage->stage)] = module;
1166
1167 /* validate descriptor set layout against what the spirv module actually uses */
1168 std::map<std::pair<unsigned, unsigned>, interface_var> descriptor_uses;
1169 collect_interface_by_descriptor_slot(my_data, dev, module, spv::StorageClassUniform,
1170 descriptor_uses);
1171
Tobin Ehlisad61de42015-12-02 13:53:34 -07001172 auto layouts = pCreateInfo->layout != VK_NULL_HANDLE ?
1173 &(my_data->pipelineLayoutMap[pCreateInfo->layout].descriptorSetLayouts) : nullptr;
Tobin Ehlis32479352015-12-01 09:48:58 -07001174
1175 for (auto it = descriptor_uses.begin(); it != descriptor_uses.end(); it++) {
Tobin Ehlisd17c28c2015-12-03 09:40:56 -07001176 // As a side-effect of this function, capture which sets are used by the pipeline
1177 pPipeline->active_sets.insert(it->first.first);
Tobin Ehlis32479352015-12-01 09:48:58 -07001178
1179 /* find the matching binding */
Tobin Ehlisad61de42015-12-02 13:53:34 -07001180 auto found = has_descriptor_binding(my_data, layouts, it->first);
Tobin Ehlis32479352015-12-01 09:48:58 -07001181
1182 if (!found) {
1183 char type_name[1024];
1184 describe_type(type_name, module, it->second.type_id);
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001185 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/0, 0,
Tobin Ehlis32479352015-12-01 09:48:58 -07001186 SHADER_CHECKER_MISSING_DESCRIPTOR, "SC",
1187 "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout",
1188 it->first.first, it->first.second, type_name)) {
1189 pass = false;
1190 }
1191 }
1192 }
1193 }
1194 }
1195 }
1196
1197 if (pCreateInfo->renderPass != VK_NULL_HANDLE)
Tobin Ehlisad61de42015-12-02 13:53:34 -07001198 rp = my_data->renderPassMap[pCreateInfo->renderPass];
Tobin Ehlis32479352015-12-01 09:48:58 -07001199
1200 vi = pCreateInfo->pVertexInputState;
1201
1202 if (vi) {
1203 pass = validate_vi_consistency(my_data, dev, vi) && pass;
1204 }
1205
1206 if (shaders[vertex_stage]) {
1207 pass = validate_vi_against_vs_inputs(my_data, dev, vi, shaders[vertex_stage]) && pass;
1208 }
1209
1210 /* TODO: enforce rules about present combinations of shaders */
1211 int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT);
1212 int consumer = get_shader_stage_id(VK_SHADER_STAGE_GEOMETRY_BIT);
1213
1214 while (!shaders[producer] && producer != fragment_stage) {
1215 producer++;
1216 consumer++;
1217 }
1218
1219 for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) {
1220 assert(shaders[producer]);
1221 if (shaders[consumer]) {
1222 pass = validate_interface_between_stages(my_data, dev,
1223 shaders[producer], shader_stage_attribs[producer].name,
1224 shaders[consumer], shader_stage_attribs[consumer].name,
1225 shader_stage_attribs[consumer].arrayed_input) && pass;
1226
1227 producer = consumer;
1228 }
1229 }
1230
1231 if (shaders[fragment_stage] && rp) {
1232 pass = validate_fs_outputs_against_render_pass(my_data, dev, shaders[fragment_stage], rp, pCreateInfo->subpass) && pass;
1233 }
1234
1235 delete shaders;
1236
1237 return pass;
1238}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001239
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06001240// Validate overall state at the time of a draw call
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001241static VkBool32 validate_draw_state(layer_data* my_data, GLOBAL_CB_NODE* pCB, VkBool32 indexedDraw) {
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06001242 // First check flag states
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001243 VkBool32 result = validate_draw_state_flags(my_data, pCB, indexedDraw);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001244 PIPELINE_NODE* pPipe = getPipeline(my_data, pCB->lastBoundPipeline);
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06001245 // Now complete other state checks
Tobin Ehlis12ab7dc2015-09-09 13:31:01 -06001246 // TODO : Currently only performing next check if *something* was bound (non-zero last bound)
1247 // There is probably a better way to gate when this check happens, and to know if something *should* have been bound
1248 // We should have that check separately and then gate this check based on that check
Mark Lobodzinski611cf592015-12-18 15:35:38 -07001249 if (pPipe) {
1250 if (pCB->lastBoundPipelineLayout) {
1251 string errorString;
1252 for (auto setIndex : pPipe->active_sets) {
1253 // If valid set is not bound throw an error
1254 if ((pCB->boundDescriptorSets.size() <= setIndex) || (!pCB->boundDescriptorSets[setIndex])) {
1255 result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS",
1256 "VkPipeline %#" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, setIndex);
1257 } else if (!verify_set_layout_compatibility(my_data, my_data->setMap[pCB->boundDescriptorSets[setIndex]], pPipe->graphicsPipelineCI.layout, setIndex, errorString)) {
1258 // Set is bound but not compatible w/ overlapping pipelineLayout from PSO
1259 VkDescriptorSet setHandle = my_data->setMap[pCB->boundDescriptorSets[setIndex]]->set;
1260 result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)setHandle, 0, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS",
1261 "VkDescriptorSet (%#" PRIxLEAST64 ") bound as set #%u is not compatible with overlapping VkPipelineLayout %#" PRIxLEAST64 " due to: %s",
1262 (uint64_t)setHandle, setIndex, (uint64_t)pPipe->graphicsPipelineCI.layout, errorString.c_str());
1263 }
Tobin Ehlisd17c28c2015-12-03 09:40:56 -07001264 }
1265 }
Mark Lobodzinski74e84692015-12-14 15:14:10 -07001266
Mark Lobodzinski611cf592015-12-18 15:35:38 -07001267 // Verify Vtx binding
1268 if (pPipe->vtxBindingCount > 0) {
1269 VkPipelineVertexInputStateCreateInfo *vtxInCI = &pPipe->vertexInputCI;
1270 for (uint32_t i = 0; i < vtxInCI->vertexBindingDescriptionCount; i++) {
1271 if ((pCB->boundVtxBuffers.size() < (i+1)) || (pCB->boundVtxBuffers[i] == VK_NULL_HANDLE)) {
1272 result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS",
1273 "The Pipeline State Object (%#" PRIxLEAST64 ") expects that this Command Buffer's vertex binding Index %d should be set via vkCmdBindVertexBuffers.",
1274 (uint64_t)pCB->lastBoundPipeline, i);
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001275
Mark Lobodzinski611cf592015-12-18 15:35:38 -07001276 }
1277 }
1278 } else {
1279 if (!pCB->boundVtxBuffers.empty()) {
1280 result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS,
1281 "DS", "Vertex buffers are bound to command buffer (%#" PRIxLEAST64 ") but no vertex buffers are attached to this Pipeline State Object (%#" PRIxLEAST64 ").",
1282 (uint64_t)pCB->commandBuffer, (uint64_t)pCB->lastBoundPipeline);
Tobin Ehlisd28acef2015-09-09 15:12:35 -06001283 }
1284 }
Mark Lobodzinski74e84692015-12-14 15:14:10 -07001285
Mark Lobodzinski611cf592015-12-18 15:35:38 -07001286 // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count
1287 VkBool32 dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT);
1288 VkBool32 dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR);
1289 if (dynViewport) {
1290 if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) {
1291 result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
1292 "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER ", but PSO viewportCount is %u. These counts must match.", pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount);
1293 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001294 }
Mark Lobodzinski611cf592015-12-18 15:35:38 -07001295 if (dynScissor) {
1296 if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) {
1297 result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
1298 "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER ", but PSO scissorCount is %u. These counts must match.", pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount);
1299 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001300 }
1301 }
Tobin Ehlisc6c3d6d2015-06-22 17:20:50 -06001302 return result;
1303}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001304
Tobin Ehlisde63c532015-06-18 15:59:33 -06001305// Verify that create state for a pipeline is valid
Tobin Ehlisd17c28c2015-12-03 09:40:56 -07001306static VkBool32 verifyPipelineCreateState(layer_data* my_data, const VkDevice device, PIPELINE_NODE* pPipeline)
Tobin Ehlisde63c532015-06-18 15:59:33 -06001307{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001308 VkBool32 skipCall = VK_FALSE;
Mark Lobodzinski312274f2015-12-16 14:25:22 -07001309
Tobin Ehlisd17c28c2015-12-03 09:40:56 -07001310 if (!validate_pipeline_shaders(my_data, device, pPipeline)) {
Tobin Ehlisad61de42015-12-02 13:53:34 -07001311 skipCall = VK_TRUE;
1312 }
Mark Lobodzinski312274f2015-12-16 14:25:22 -07001313
Tobin Ehlisde63c532015-06-18 15:59:33 -06001314 // VS is required
1315 if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001316 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -06001317 "Invalid Pipeline CreateInfo State: Vtx Shader required");
Tobin Ehlisde63c532015-06-18 15:59:33 -06001318 }
1319 // Either both or neither TC/TE shaders should be defined
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -06001320 if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) !=
1321 ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0) ) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001322 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -06001323 "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair");
Tobin Ehlisde63c532015-06-18 15:59:33 -06001324 }
1325 // Compute shaders should be specified independent of Gfx shaders
1326 if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) &&
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -06001327 (pPipeline->active_shaders & (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT |
1328 VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | VK_SHADER_STAGE_GEOMETRY_BIT |
Tobin Ehlisde63c532015-06-18 15:59:33 -06001329 VK_SHADER_STAGE_FRAGMENT_BIT))) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001330 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Tobin Ehlisde63c532015-06-18 15:59:33 -06001331 "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline");
Tobin Ehlisde63c532015-06-18 15:59:33 -06001332 }
Chia-I Wu99ba2bb2015-10-31 00:31:16 +08001333 // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines.
Tobin Ehlisde63c532015-06-18 15:59:33 -06001334 // Mismatching primitive topology and tessellation fails graphics pipeline creation.
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -06001335 if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) &&
Chia-I Wu99ba2bb2015-10-31 00:31:16 +08001336 (pPipeline->iaStateCI.topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001337 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +08001338 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA topology for tessellation pipelines");
Tobin Ehlisde63c532015-06-18 15:59:33 -06001339 }
Chia-I Wu99ba2bb2015-10-31 00:31:16 +08001340 if (pPipeline->iaStateCI.topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) {
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -06001341 if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001342 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +08001343 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines");
Tobin Ehlis20693172015-09-17 08:46:18 -06001344 }
1345 if (!pPipeline->tessStateCI.patchControlPoints || (pPipeline->tessStateCI.patchControlPoints > 32)) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001346 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS",
Chia-I Wu99ba2bb2015-10-31 00:31:16 +08001347 "Invalid Pipeline CreateInfo State: VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology used with patchControlPoints value %u."
Tobin Ehlis20693172015-09-17 08:46:18 -06001348 " patchControlPoints should be >0 and <=32.", pPipeline->tessStateCI.patchControlPoints);
1349 }
Tobin Ehlisde63c532015-06-18 15:59:33 -06001350 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001351 // Viewport state must be included and viewport and scissor counts should always match
Tobin Ehlis9e839e52015-10-01 11:15:13 -06001352 // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001353 if (!pPipeline->graphicsPipelineCI.pViewportState) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001354 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001355 "Gfx Pipeline pViewportState is null. Even if viewport and scissors are dynamic PSO must include viewportCount and scissorCount in pViewportState.");
1356 } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != pPipeline->graphicsPipelineCI.pViewportState->viewportCount) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001357 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Tobin Ehlis9e839e52015-10-01 11:15:13 -06001358 "Gfx Pipeline viewport count (%u) must match scissor count (%u).", pPipeline->vpStateCI.viewportCount, pPipeline->vpStateCI.scissorCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001359 } else {
1360 // If viewport or scissor are not dynamic, then verify that data is appropriate for count
1361 VkBool32 dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT);
1362 VkBool32 dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR);
1363 if (!dynViewport) {
1364 if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && !pPipeline->graphicsPipelineCI.pViewportState->pViewports) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001365 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Courtney Goeltzenleuchter95e6dba2015-11-25 11:38:54 -07001366 "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you must either include pViewports data, or include viewport in pDynamicState and set it with vkCmdSetViewport().", pPipeline->graphicsPipelineCI.pViewportState->viewportCount);
Tobin Ehlis9e839e52015-10-01 11:15:13 -06001367 }
1368 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001369 if (!dynScissor) {
1370 if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && !pPipeline->graphicsPipelineCI.pViewportState->pScissors) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001371 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS",
Courtney Goeltzenleuchter95e6dba2015-11-25 11:38:54 -07001372 "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you must either include pScissors data, or include scissor in pDynamicState and set it with vkCmdSetScissor().", pPipeline->graphicsPipelineCI.pViewportState->scissorCount);
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06001373 }
Tobin Ehlis9e839e52015-10-01 11:15:13 -06001374 }
1375 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001376 return skipCall;
Tobin Ehlisde63c532015-06-18 15:59:33 -06001377}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001378
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001379// Init the pipeline mapping info based on pipeline create info LL tree
1380// Threading note : Calls to this function should wrapped in mutex
Tobin Ehlisd17c28c2015-12-03 09:40:56 -07001381// TODO : this should really just be in the constructor for PIPELINE_NODE
Mark Lobodzinski2adea752015-11-10 15:25:01 -07001382static PIPELINE_NODE* initGraphicsPipeline(layer_data* dev_data, const VkGraphicsPipelineCreateInfo* pCreateInfo, PIPELINE_NODE* pBasePipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001383{
Tobin Ehlisde63c532015-06-18 15:59:33 -06001384 PIPELINE_NODE* pPipeline = new PIPELINE_NODE;
Mark Lobodzinskie443d2b2015-12-11 11:56:07 -07001385
Tobin Ehlisde63c532015-06-18 15:59:33 -06001386 if (pBasePipeline) {
Mark Lobodzinskie443d2b2015-12-11 11:56:07 -07001387 *pPipeline = *pBasePipeline;
Tobin Ehlisde63c532015-06-18 15:59:33 -06001388 }
Mark Lobodzinskie443d2b2015-12-11 11:56:07 -07001389
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001390 // First init create info
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001391 memcpy(&pPipeline->graphicsPipelineCI, pCreateInfo, sizeof(VkGraphicsPipelineCreateInfo));
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001392
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001393 size_t bufferSize = 0;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001394 const VkPipelineVertexInputStateCreateInfo* pVICI = NULL;
Tobin Ehlis59db5712015-07-13 13:14:24 -06001395 const VkPipelineColorBlendStateCreateInfo* pCBCI = NULL;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001396
1397 for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) {
1398 const VkPipelineShaderStageCreateInfo *pPSSCI = &pCreateInfo->pStages[i];
1399
Chia-I Wu062ad152015-10-31 00:31:16 +08001400 switch (pPSSCI->stage) {
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -06001401 case VK_SHADER_STAGE_VERTEX_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001402 memcpy(&pPipeline->vsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
1403 pPipeline->active_shaders |= VK_SHADER_STAGE_VERTEX_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001404 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -06001405 case VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001406 memcpy(&pPipeline->tcsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -06001407 pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001408 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -06001409 case VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001410 memcpy(&pPipeline->tesCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
Courtney Goeltzenleuchterc6fd2262015-10-15 17:35:38 -06001411 pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001412 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -06001413 case VK_SHADER_STAGE_GEOMETRY_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001414 memcpy(&pPipeline->gsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
1415 pPipeline->active_shaders |= VK_SHADER_STAGE_GEOMETRY_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001416 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -06001417 case VK_SHADER_STAGE_FRAGMENT_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001418 memcpy(&pPipeline->fsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo));
1419 pPipeline->active_shaders |= VK_SHADER_STAGE_FRAGMENT_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001420 break;
Courtney Goeltzenleuchter8e2f0972015-10-21 17:08:06 -06001421 case VK_SHADER_STAGE_COMPUTE_BIT:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001422 // TODO : Flag error, CS is specified through VkComputePipelineCreateInfo
1423 pPipeline->active_shaders |= VK_SHADER_STAGE_COMPUTE_BIT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001424 break;
1425 default:
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001426 // TODO : Flag error
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001427 break;
1428 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001429 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001430 // Copy over GraphicsPipelineCreateInfo structure embedded pointers
1431 if (pCreateInfo->stageCount != 0) {
1432 pPipeline->graphicsPipelineCI.pStages = new VkPipelineShaderStageCreateInfo[pCreateInfo->stageCount];
1433 bufferSize = pCreateInfo->stageCount * sizeof(VkPipelineShaderStageCreateInfo);
1434 memcpy((void*)pPipeline->graphicsPipelineCI.pStages, pCreateInfo->pStages, bufferSize);
1435 }
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001436 if (pCreateInfo->pVertexInputState != NULL) {
1437 memcpy((void*)&pPipeline->vertexInputCI, pCreateInfo->pVertexInputState , sizeof(VkPipelineVertexInputStateCreateInfo));
1438 // Copy embedded ptrs
1439 pVICI = pCreateInfo->pVertexInputState;
Chia-I Wu763a7492015-10-26 20:48:51 +08001440 pPipeline->vtxBindingCount = pVICI->vertexBindingDescriptionCount;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001441 if (pPipeline->vtxBindingCount) {
1442 pPipeline->pVertexBindingDescriptions = new VkVertexInputBindingDescription[pPipeline->vtxBindingCount];
1443 bufferSize = pPipeline->vtxBindingCount * sizeof(VkVertexInputBindingDescription);
1444 memcpy((void*)pPipeline->pVertexBindingDescriptions, pVICI->pVertexBindingDescriptions, bufferSize);
1445 }
Chia-I Wu763a7492015-10-26 20:48:51 +08001446 pPipeline->vtxAttributeCount = pVICI->vertexAttributeDescriptionCount;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001447 if (pPipeline->vtxAttributeCount) {
1448 pPipeline->pVertexAttributeDescriptions = new VkVertexInputAttributeDescription[pPipeline->vtxAttributeCount];
1449 bufferSize = pPipeline->vtxAttributeCount * sizeof(VkVertexInputAttributeDescription);
1450 memcpy((void*)pPipeline->pVertexAttributeDescriptions, pVICI->pVertexAttributeDescriptions, bufferSize);
1451 }
1452 pPipeline->graphicsPipelineCI.pVertexInputState = &pPipeline->vertexInputCI;
1453 }
Tony Barboure307f582015-07-10 15:29:03 -06001454 if (pCreateInfo->pInputAssemblyState != NULL) {
1455 memcpy((void*)&pPipeline->iaStateCI, pCreateInfo->pInputAssemblyState, sizeof(VkPipelineInputAssemblyStateCreateInfo));
1456 pPipeline->graphicsPipelineCI.pInputAssemblyState = &pPipeline->iaStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001457 }
Tony Barboure307f582015-07-10 15:29:03 -06001458 if (pCreateInfo->pTessellationState != NULL) {
1459 memcpy((void*)&pPipeline->tessStateCI, pCreateInfo->pTessellationState, sizeof(VkPipelineTessellationStateCreateInfo));
1460 pPipeline->graphicsPipelineCI.pTessellationState = &pPipeline->tessStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001461 }
Tony Barboure307f582015-07-10 15:29:03 -06001462 if (pCreateInfo->pViewportState != NULL) {
1463 memcpy((void*)&pPipeline->vpStateCI, pCreateInfo->pViewportState, sizeof(VkPipelineViewportStateCreateInfo));
1464 pPipeline->graphicsPipelineCI.pViewportState = &pPipeline->vpStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001465 }
Chia-I Wu1f851912015-10-27 18:04:07 +08001466 if (pCreateInfo->pRasterizationState != NULL) {
1467 memcpy((void*)&pPipeline->rsStateCI, pCreateInfo->pRasterizationState, sizeof(VkPipelineRasterizationStateCreateInfo));
1468 pPipeline->graphicsPipelineCI.pRasterizationState = &pPipeline->rsStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001469 }
Tony Barboure307f582015-07-10 15:29:03 -06001470 if (pCreateInfo->pMultisampleState != NULL) {
1471 memcpy((void*)&pPipeline->msStateCI, pCreateInfo->pMultisampleState, sizeof(VkPipelineMultisampleStateCreateInfo));
1472 pPipeline->graphicsPipelineCI.pMultisampleState = &pPipeline->msStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001473 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001474 if (pCreateInfo->pDepthStencilState != NULL) {
1475 memcpy((void*)&pPipeline->dsStateCI, pCreateInfo->pDepthStencilState, sizeof(VkPipelineDepthStencilStateCreateInfo));
1476 pPipeline->graphicsPipelineCI.pDepthStencilState = &pPipeline->dsStateCI;
1477 }
Tony Barboure307f582015-07-10 15:29:03 -06001478 if (pCreateInfo->pColorBlendState != NULL) {
1479 memcpy((void*)&pPipeline->cbStateCI, pCreateInfo->pColorBlendState, sizeof(VkPipelineColorBlendStateCreateInfo));
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001480 // Copy embedded ptrs
Tony Barboure307f582015-07-10 15:29:03 -06001481 pCBCI = pCreateInfo->pColorBlendState;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001482 pPipeline->attachmentCount = pCBCI->attachmentCount;
1483 if (pPipeline->attachmentCount) {
Tony Barboure307f582015-07-10 15:29:03 -06001484 pPipeline->pAttachments = new VkPipelineColorBlendAttachmentState[pPipeline->attachmentCount];
1485 bufferSize = pPipeline->attachmentCount * sizeof(VkPipelineColorBlendAttachmentState);
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001486 memcpy((void*)pPipeline->pAttachments, pCBCI->pAttachments, bufferSize);
1487 }
Tony Barboure307f582015-07-10 15:29:03 -06001488 pPipeline->graphicsPipelineCI.pColorBlendState = &pPipeline->cbStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001489 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001490 if (pCreateInfo->pDynamicState != NULL) {
1491 memcpy((void*)&pPipeline->dynStateCI, pCreateInfo->pDynamicState, sizeof(VkPipelineDynamicStateCreateInfo));
1492 if (pPipeline->dynStateCI.dynamicStateCount) {
1493 pPipeline->dynStateCI.pDynamicStates = new VkDynamicState[pPipeline->dynStateCI.dynamicStateCount];
1494 bufferSize = pPipeline->dynStateCI.dynamicStateCount * sizeof(VkDynamicState);
1495 memcpy((void*)pPipeline->dynStateCI.pDynamicStates, pCreateInfo->pDynamicState->pDynamicStates, bufferSize);
1496 }
1497 pPipeline->graphicsPipelineCI.pDynamicState = &pPipeline->dynStateCI;
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001498 }
Tobin Ehlisd17c28c2015-12-03 09:40:56 -07001499 pPipeline->active_sets.clear();
Tobin Ehlisde63c532015-06-18 15:59:33 -06001500 return pPipeline;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001501}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001502
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001503// Free the Pipeline nodes
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001504static void deletePipelines(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001505{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001506 if (my_data->pipelineMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -06001507 return;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001508 for (auto ii=my_data->pipelineMap.begin(); ii!=my_data->pipelineMap.end(); ++ii) {
Mark Lobodzinski0e0fb5c2015-06-23 15:11:57 -06001509 if ((*ii).second->graphicsPipelineCI.stageCount != 0) {
1510 delete[] (*ii).second->graphicsPipelineCI.pStages;
1511 }
Tobin Ehliscd3109e2015-04-01 11:59:08 -06001512 if ((*ii).second->pVertexBindingDescriptions) {
1513 delete[] (*ii).second->pVertexBindingDescriptions;
1514 }
1515 if ((*ii).second->pVertexAttributeDescriptions) {
1516 delete[] (*ii).second->pVertexAttributeDescriptions;
1517 }
1518 if ((*ii).second->pAttachments) {
1519 delete[] (*ii).second->pAttachments;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001520 }
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06001521 if ((*ii).second->dynStateCI.dynamicStateCount != 0) {
1522 delete[] (*ii).second->dynStateCI.pDynamicStates;
1523 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001524 delete (*ii).second;
1525 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001526 my_data->pipelineMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001527}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001528
Tobin Ehlis2464b882015-04-01 08:40:34 -06001529// For given pipeline, return number of MSAA samples, or one if MSAA disabled
Chia-I Wu3138d6a2015-10-31 00:31:16 +08001530static VkSampleCountFlagBits getNumSamples(layer_data* my_data, const VkPipeline pipeline)
Tobin Ehlis2464b882015-04-01 08:40:34 -06001531{
Chia-I Wue420a332015-10-26 20:04:44 +08001532 PIPELINE_NODE* pPipe = my_data->pipelineMap[pipeline];
Tobin Ehlisb3a506f2015-07-13 14:51:15 -06001533 if (VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pPipe->msStateCI.sType) {
Chia-I Wu1f851912015-10-27 18:04:07 +08001534 return pPipe->msStateCI.rasterizationSamples;
Tobin Ehlisb3a506f2015-07-13 14:51:15 -06001535 }
Chia-I Wu3138d6a2015-10-31 00:31:16 +08001536 return VK_SAMPLE_COUNT_1_BIT;
Tobin Ehlis2464b882015-04-01 08:40:34 -06001537}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001538
Tobin Ehlis2464b882015-04-01 08:40:34 -06001539// Validate state related to the PSO
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001540static VkBool32 validatePipelineState(layer_data* my_data, const GLOBAL_CB_NODE* pCB, const VkPipelineBindPoint pipelineBindPoint, const VkPipeline pipeline)
Tobin Ehlis2464b882015-04-01 08:40:34 -06001541{
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06001542 if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) {
Tobin Ehlis2464b882015-04-01 08:40:34 -06001543 // Verify that any MSAA request in PSO matches sample# in bound FB
Chia-I Wu3138d6a2015-10-31 00:31:16 +08001544 VkSampleCountFlagBits psoNumSamples = getNumSamples(my_data, pipeline);
Tobin Ehlis2464b882015-04-01 08:40:34 -06001545 if (pCB->activeRenderPass) {
Tobin Ehlisad61de42015-12-02 13:53:34 -07001546 const VkRenderPassCreateInfo* pRPCI = my_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo;
Chia-I Wuc278df82015-07-07 11:50:03 +08001547 const VkSubpassDescription* pSD = &pRPCI->pSubpasses[pCB->activeSubpass];
Chia-I Wu3138d6a2015-10-31 00:31:16 +08001548 VkSampleCountFlagBits subpassNumSamples = (VkSampleCountFlagBits) 0;
Chia-I Wuc278df82015-07-07 11:50:03 +08001549 uint32_t i;
1550
Chia-I Wu763a7492015-10-26 20:48:51 +08001551 for (i = 0; i < pSD->colorAttachmentCount; i++) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +08001552 VkSampleCountFlagBits samples;
Chia-I Wuc278df82015-07-07 11:50:03 +08001553
Cody Northrop6de6b0b2015-08-04 11:16:41 -06001554 if (pSD->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED)
Chia-I Wuc278df82015-07-07 11:50:03 +08001555 continue;
1556
Cody Northrop6de6b0b2015-08-04 11:16:41 -06001557 samples = pRPCI->pAttachments[pSD->pColorAttachments[i].attachment].samples;
Chia-I Wu3138d6a2015-10-31 00:31:16 +08001558 if (subpassNumSamples == (VkSampleCountFlagBits) 0) {
Chia-I Wuc278df82015-07-07 11:50:03 +08001559 subpassNumSamples = samples;
1560 } else if (subpassNumSamples != samples) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +08001561 subpassNumSamples = (VkSampleCountFlagBits) -1;
Chia-I Wuc278df82015-07-07 11:50:03 +08001562 break;
1563 }
1564 }
Chia-I Wuce532f72015-10-26 17:32:47 +08001565 if (pSD->pDepthStencilAttachment && pSD->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
Chia-I Wu3138d6a2015-10-31 00:31:16 +08001566 const VkSampleCountFlagBits samples = pRPCI->pAttachments[pSD->pDepthStencilAttachment->attachment].samples;
1567 if (subpassNumSamples == (VkSampleCountFlagBits) 0)
Chia-I Wuc278df82015-07-07 11:50:03 +08001568 subpassNumSamples = samples;
1569 else if (subpassNumSamples != samples)
Chia-I Wu3138d6a2015-10-31 00:31:16 +08001570 subpassNumSamples = (VkSampleCountFlagBits) -1;
Chia-I Wuc278df82015-07-07 11:50:03 +08001571 }
1572
1573 if (psoNumSamples != subpassNumSamples) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001574 return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, (uint64_t) pipeline, 0, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06001575 "Num samples mismatch! Binding PSO (%#" PRIxLEAST64 ") with %u samples while current RenderPass (%#" PRIxLEAST64 ") w/ %u samples!",
Chia-I Wue420a332015-10-26 20:04:44 +08001576 (uint64_t) pipeline, psoNumSamples, (uint64_t) pCB->activeRenderPass, subpassNumSamples);
Tobin Ehlis2464b882015-04-01 08:40:34 -06001577 }
1578 } else {
1579 // TODO : I believe it's an error if we reach this point and don't have an activeRenderPass
1580 // Verify and flag error as appropriate
1581 }
1582 // TODO : Add more checks here
1583 } else {
1584 // TODO : Validate non-gfx pipeline updates
1585 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001586 return VK_FALSE;
Tobin Ehlis2464b882015-04-01 08:40:34 -06001587}
1588
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001589// Block of code at start here specifically for managing/tracking DSs
1590
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001591// Return Pool node ptr for specified pool or else NULL
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001592static DESCRIPTOR_POOL_NODE* getPoolNode(layer_data* my_data, const VkDescriptorPool pool)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001593{
1594 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001595 if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001596 loader_platform_thread_unlock_mutex(&globalLock);
1597 return NULL;
1598 }
1599 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07001600 return my_data->descriptorPoolMap[pool];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001601}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001602
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001603// Return Set node ptr for specified set or else NULL
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001604static SET_NODE* getSetNode(layer_data* my_data, const VkDescriptorSet set)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001605{
1606 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08001607 if (my_data->setMap.find(set) == my_data->setMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001608 loader_platform_thread_unlock_mutex(&globalLock);
1609 return NULL;
1610 }
1611 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08001612 return my_data->setMap[set];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001613}
1614
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06001615static LAYOUT_NODE* getLayoutNode(layer_data* my_data, const VkDescriptorSetLayout layout) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001616 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlisad61de42015-12-02 13:53:34 -07001617 if (my_data->descriptorSetLayoutMap.find(layout) == my_data->descriptorSetLayoutMap.end()) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001618 loader_platform_thread_unlock_mutex(&globalLock);
1619 return NULL;
1620 }
1621 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisad61de42015-12-02 13:53:34 -07001622 return my_data->descriptorSetLayoutMap[layout];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001623}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001624
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001625// Return VK_FALSE if update struct is of valid type, otherwise flag error and return code from callback
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001626static VkBool32 validUpdateStruct(layer_data* my_data, const VkDevice device, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001627{
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001628 switch (pUpdateStruct->sType)
1629 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001630 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
1631 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001632 return VK_FALSE;
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001633 default:
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001634 return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001635 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType);
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001636 }
1637}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001638
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001639// Set count for given update struct in the last parameter
Courtney Goeltzenleuchter5bc11202015-12-16 16:08:44 -07001640// Return value of skipCall, which is only VK_TRUE if error occurs and callback signals execution to cease
Tobin Ehlise66ec962015-10-27 12:54:50 -06001641static uint32_t getUpdateCount(layer_data* my_data, const VkDevice device, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001642{
1643 switch (pUpdateStruct->sType)
1644 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001645 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
Chia-I Wu763a7492015-10-26 20:48:51 +08001646 return ((VkWriteDescriptorSet*)pUpdateStruct)->descriptorCount;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001647 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001648 // TODO : Need to understand this case better and make sure code is correct
Chia-I Wu763a7492015-10-26 20:48:51 +08001649 return ((VkCopyDescriptorSet*)pUpdateStruct)->descriptorCount;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001650 }
Courtney Goeltzenleuchter902a0862015-12-16 16:08:08 -07001651
1652 return 0;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001653}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001654
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001655// For given Layout Node and binding, return index where that binding begins
1656static uint32_t getBindingStartIndex(const LAYOUT_NODE* pLayout, const uint32_t binding)
1657{
1658 uint32_t offsetIndex = 0;
Chia-I Wub5689ee2015-10-31 00:31:16 +08001659 for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) {
1660 if (pLayout->createInfo.pBinding[i].binding == binding)
1661 break;
Chia-I Wu045654f2015-11-06 06:42:02 +08001662 offsetIndex += pLayout->createInfo.pBinding[i].descriptorCount;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001663 }
1664 return offsetIndex;
1665}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001666
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001667// For given layout node and binding, return last index that is updated
1668static uint32_t getBindingEndIndex(const LAYOUT_NODE* pLayout, const uint32_t binding)
1669{
1670 uint32_t offsetIndex = 0;
Chia-I Wub5689ee2015-10-31 00:31:16 +08001671 for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) {
Chia-I Wu045654f2015-11-06 06:42:02 +08001672 offsetIndex += pLayout->createInfo.pBinding[i].descriptorCount;
Chia-I Wub5689ee2015-10-31 00:31:16 +08001673 if (pLayout->createInfo.pBinding[i].binding == binding)
1674 break;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001675 }
1676 return offsetIndex-1;
1677}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001678
Tobin Ehlise66ec962015-10-27 12:54:50 -06001679// For given layout and update, return the first overall index of the layout that is updated
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001680static uint32_t getUpdateStartIndex(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const uint32_t binding, const uint32_t arrayIndex, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001681{
Tobin Ehlise66ec962015-10-27 12:54:50 -06001682 return getBindingStartIndex(pLayout, binding)+arrayIndex;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001683}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001684
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001685// For given layout and update, return the last overall index of the layout that is updated
1686static uint32_t getUpdateEndIndex(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const uint32_t binding, const uint32_t arrayIndex, const GENERIC_HEADER* pUpdateStruct)
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001687{
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001688 uint32_t count = getUpdateCount(my_data, device, pUpdateStruct);
Tobin Ehlise66ec962015-10-27 12:54:50 -06001689 return getBindingStartIndex(pLayout, binding)+arrayIndex+count-1;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001690}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001691
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001692// Verify that the descriptor type in the update struct matches what's expected by the layout
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001693static VkBool32 validateUpdateConsistency(layer_data* my_data, const VkDevice device, const LAYOUT_NODE* pLayout, const GENERIC_HEADER* pUpdateStruct, uint32_t startIndex, uint32_t endIndex)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001694{
1695 // First get actual type of update
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001696 VkBool32 skipCall = VK_FALSE;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001697 VkDescriptorType actualType;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001698 uint32_t i = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001699 switch (pUpdateStruct->sType)
1700 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001701 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
1702 actualType = ((VkWriteDescriptorSet*)pUpdateStruct)->descriptorType;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001703 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001704 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
1705 /* no need to validate */
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001706 return VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001707 break;
1708 default:
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001709 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06001710 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001711 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001712 if (VK_FALSE == skipCall) {
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001713 // Set first stageFlags as reference and verify that all other updates match it
1714 VkShaderStageFlags refStageFlags = pLayout->stageFlags[startIndex];
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001715 for (i = startIndex; i <= endIndex; i++) {
Tobin Ehlis91423d22015-10-20 10:11:55 -06001716 if (pLayout->descriptorTypes[i] != actualType) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001717 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001718 "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!",
1719 string_VkDescriptorType(actualType), string_VkDescriptorType(pLayout->descriptorTypes[i]));
1720 }
1721 if (pLayout->stageFlags[i] != refStageFlags) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001722 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_DESCRIPTOR_STAGEFLAGS_MISMATCH, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001723 "Write descriptor update has stageFlags %x that do not match overlapping binding descriptor stageFlags of %x!",
1724 refStageFlags, pLayout->stageFlags[i]);
Tobin Ehlis3b341092015-09-30 08:30:20 -06001725 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001726 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001727 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001728 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001729}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001730
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001731// Determine the update type, allocate a new struct of that type, shadow the given pUpdate
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001732// struct into the pNewNode param. Return VK_TRUE if error condition encountered and callback signals early exit.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001733// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001734static VkBool32 shadowUpdateNode(layer_data* my_data, const VkDevice device, GENERIC_HEADER* pUpdate, GENERIC_HEADER** pNewNode)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001735{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001736 VkBool32 skipCall = VK_FALSE;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001737 VkWriteDescriptorSet* pWDS = NULL;
1738 VkCopyDescriptorSet* pCDS = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001739 size_t array_size = 0;
1740 size_t base_array_size = 0;
1741 size_t total_array_size = 0;
1742 size_t baseBuffAddr = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001743 switch (pUpdate->sType)
1744 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001745 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
1746 pWDS = new VkWriteDescriptorSet;
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001747 *pNewNode = (GENERIC_HEADER*)pWDS;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001748 memcpy(pWDS, pUpdate, sizeof(VkWriteDescriptorSet));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -06001749
1750 switch (pWDS->descriptorType) {
1751 case VK_DESCRIPTOR_TYPE_SAMPLER:
1752 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
1753 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
1754 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
1755 {
Chia-I Wu763a7492015-10-26 20:48:51 +08001756 VkDescriptorImageInfo *info = new VkDescriptorImageInfo[pWDS->descriptorCount];
1757 memcpy(info, pWDS->pImageInfo, pWDS->descriptorCount * sizeof(VkDescriptorImageInfo));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -06001758 pWDS->pImageInfo = info;
Tobin Ehliscb085292015-12-01 09:57:09 -07001759 }
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -06001760 break;
1761 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
1762 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
1763 {
Chia-I Wu763a7492015-10-26 20:48:51 +08001764 VkBufferView *info = new VkBufferView[pWDS->descriptorCount];
1765 memcpy(info, pWDS->pTexelBufferView, pWDS->descriptorCount * sizeof(VkBufferView));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -06001766 pWDS->pTexelBufferView = info;
1767 }
1768 break;
1769 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
1770 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
1771 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
1772 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
1773 {
Chia-I Wu763a7492015-10-26 20:48:51 +08001774 VkDescriptorBufferInfo *info = new VkDescriptorBufferInfo[pWDS->descriptorCount];
1775 memcpy(info, pWDS->pBufferInfo, pWDS->descriptorCount * sizeof(VkDescriptorBufferInfo));
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -06001776 pWDS->pBufferInfo = info;
1777 }
1778 break;
1779 default:
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07001780 return VK_ERROR_VALIDATION_FAILED_EXT;
Courtney Goeltzenleuchter34aa5c82015-10-23 13:38:14 -06001781 break;
1782 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001783 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001784 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
1785 pCDS = new VkCopyDescriptorSet;
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001786 *pNewNode = (GENERIC_HEADER*)pCDS;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001787 memcpy(pCDS, pUpdate, sizeof(VkCopyDescriptorSet));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001788 break;
1789 default:
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001790 if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_UPDATE_STRUCT, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001791 "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", string_VkStructureType(pUpdate->sType), pUpdate->sType))
1792 return VK_TRUE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001793 }
1794 // Make sure that pNext for the end of shadow copy is NULL
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001795 (*pNewNode)->pNext = NULL;
1796 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001797}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001798
Tobin Ehlisb46be812015-10-23 16:00:08 -06001799// Verify that given sampler is valid
1800static VkBool32 validateSampler(const layer_data* my_data, const VkSampler* pSampler, const VkBool32 immutable)
1801{
1802 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001803 auto sampIt = my_data->sampleMap.find(*pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001804 if (sampIt == my_data->sampleMap.end()) {
1805 if (!immutable) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001806 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, (uint64_t) *pSampler, 0, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001807 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid sampler %#" PRIxLEAST64, (uint64_t) *pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001808 } else { // immutable
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001809 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, (uint64_t) *pSampler, 0, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001810 "vkUpdateDescriptorSets: Attempt to update descriptor whose binding has an invalid immutable sampler %#" PRIxLEAST64, (uint64_t) *pSampler);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001811 }
1812 } else {
1813 // TODO : Any further checks we want to do on the sampler?
1814 }
1815 return skipCall;
1816}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001817
Tobin Ehlisb46be812015-10-23 16:00:08 -06001818// Verify that given imageView is valid
1819static VkBool32 validateImageView(const layer_data* my_data, const VkImageView* pImageView, const VkImageLayout imageLayout)
1820{
1821 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001822 auto ivIt = my_data->imageViewMap.find(*pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001823 if (ivIt == my_data->imageViewMap.end()) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001824 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001825 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid imageView %#" PRIxLEAST64, (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001826 } else {
1827 // Validate that imageLayout is compatible with aspectMask and image format
1828 VkImageAspectFlags aspectMask = ivIt->second->subresourceRange.aspectMask;
Chia-I Wue420a332015-10-26 20:04:44 +08001829 VkImage image = ivIt->second->image;
Michael Lentineee4ad4d2015-10-23 12:41:44 -07001830 // TODO : Check here in case we have a bad image
Chia-I Wue420a332015-10-26 20:04:44 +08001831 auto imgIt = my_data->imageMap.find(image);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001832 if (imgIt == my_data->imageMap.end()) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001833 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, (uint64_t) image, 0, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS",
Michael Lentineee4ad4d2015-10-23 12:41:44 -07001834 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid image %#" PRIxLEAST64 " in imageView %#" PRIxLEAST64, (uint64_t) image, (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001835 } else {
1836 VkFormat format = (*imgIt).second->format;
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07001837 VkBool32 ds = vk_format_is_depth_or_stencil(format);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001838 switch (imageLayout) {
1839 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL:
1840 // Only Color bit must be set
1841 if ((aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001842 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001843 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001844 " that does not have VK_IMAGE_ASPECT_COLOR_BIT set.", (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001845 }
1846 // format must NOT be DS
1847 if (ds) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001848 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001849 DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001850 " but the image format is %s which is not a color format.", (uint64_t) *pImageView, string_VkFormat(format));
Tobin Ehlisb46be812015-10-23 16:00:08 -06001851 }
1852 break;
1853 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL:
1854 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL:
1855 // Depth or stencil bit must be set, but both must NOT be set
1856 if (aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) {
1857 if (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) {
1858 // both must NOT be set
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001859 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001860 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001861 " that has both STENCIL and DEPTH aspects set", (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001862 }
1863 } else if (!(aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) {
1864 // Neither were set
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001865 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001866 DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001867 " that does not have STENCIL or DEPTH aspect set.", string_VkImageLayout(imageLayout), (uint64_t) *pImageView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001868 }
1869 // format must be DS
1870 if (!ds) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001871 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, (uint64_t) *pImageView, 0,
Tobin Ehlisb46be812015-10-23 16:00:08 -06001872 DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 ""
Chia-I Wue420a332015-10-26 20:04:44 +08001873 " but the image format is %s which is not a depth/stencil format.", string_VkImageLayout(imageLayout), (uint64_t) *pImageView, string_VkFormat(format));
Tobin Ehlisb46be812015-10-23 16:00:08 -06001874 }
1875 break;
1876 default:
1877 // anything to check for other layouts?
1878 break;
1879 }
1880 }
1881 }
1882 return skipCall;
1883}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001884
Tobin Ehlisb46be812015-10-23 16:00:08 -06001885// Verify that given bufferView is valid
1886static VkBool32 validateBufferView(const layer_data* my_data, const VkBufferView* pBufferView)
1887{
1888 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001889 auto sampIt = my_data->bufferViewMap.find(*pBufferView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001890 if (sampIt == my_data->bufferViewMap.end()) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001891 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT, (uint64_t) *pBufferView, 0, DRAWSTATE_BUFFERVIEW_DESCRIPTOR_ERROR, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001892 "vkUpdateDescriptorSets: Attempt to update descriptor with invalid bufferView %#" PRIxLEAST64, (uint64_t) *pBufferView);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001893 } else {
1894 // TODO : Any further checks we want to do on the bufferView?
1895 }
1896 return skipCall;
1897}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001898
Tobin Ehlisb46be812015-10-23 16:00:08 -06001899// Verify that given bufferInfo is valid
1900static VkBool32 validateBufferInfo(const layer_data* my_data, const VkDescriptorBufferInfo* pBufferInfo)
1901{
1902 VkBool32 skipCall = VK_FALSE;
Chia-I Wue420a332015-10-26 20:04:44 +08001903 auto sampIt = my_data->bufferMap.find(pBufferInfo->buffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001904 if (sampIt == my_data->bufferMap.end()) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001905 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, (uint64_t) pBufferInfo->buffer, 0, DRAWSTATE_BUFFERINFO_DESCRIPTOR_ERROR, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08001906 "vkUpdateDescriptorSets: Attempt to update descriptor where bufferInfo has invalid buffer %#" PRIxLEAST64, (uint64_t) pBufferInfo->buffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06001907 } else {
1908 // TODO : Any further checks we want to do on the bufferView?
1909 }
1910 return skipCall;
1911}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001912
Tobin Ehlisb46be812015-10-23 16:00:08 -06001913static VkBool32 validateUpdateContents(const layer_data* my_data, const VkWriteDescriptorSet *pWDS, const VkDescriptorSetLayoutBinding* pLayoutBinding)
1914{
1915 VkBool32 skipCall = VK_FALSE;
1916 // First verify that for the given Descriptor type, the correct DescriptorInfo data is supplied
1917 VkBufferView* pBufferView = NULL;
1918 const VkSampler* pSampler = NULL;
1919 VkImageView* pImageView = NULL;
1920 VkImageLayout* pImageLayout = NULL;
1921 VkDescriptorBufferInfo* pBufferInfo = NULL;
1922 VkBool32 immutable = VK_FALSE;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001923 uint32_t i = 0;
1924 // For given update type, verify that update contents are correct
1925 switch (pWDS->descriptorType) {
1926 case VK_DESCRIPTOR_TYPE_SAMPLER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001927 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001928 skipCall |= validateSampler(my_data, &(pWDS->pImageInfo[i].sampler), immutable);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001929 }
1930 break;
1931 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001932 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001933 if (NULL == pLayoutBinding->pImmutableSamplers) {
1934 pSampler = &(pWDS->pImageInfo[i].sampler);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001935 if (immutable) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001936 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, (uint64_t) *pSampler, 0, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001937 "vkUpdateDescriptorSets: Update #%u is not an immutable sampler %#" PRIxLEAST64 ", but previous update(s) from this "
1938 "VkWriteDescriptorSet struct used an immutable sampler. All updates from a single struct must either "
Chia-I Wue420a332015-10-26 20:04:44 +08001939 "use immutable or non-immutable samplers.", i, (uint64_t) *pSampler);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001940 }
Tobin Ehlisb46be812015-10-23 16:00:08 -06001941 } else {
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001942 if (i>0 && !immutable) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07001943 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, (uint64_t) *pSampler, 0, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS",
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001944 "vkUpdateDescriptorSets: Update #%u is an immutable sampler, but previous update(s) from this "
1945 "VkWriteDescriptorSet struct used a non-immutable sampler. All updates from a single struct must either "
1946 "use immutable or non-immutable samplers.", i);
1947 }
Tobin Ehlisb46be812015-10-23 16:00:08 -06001948 immutable = VK_TRUE;
1949 pSampler = &(pLayoutBinding->pImmutableSamplers[i]);
1950 }
1951 skipCall |= validateSampler(my_data, pSampler, immutable);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001952 }
1953 // Intentionally fall through here to also validate image stuff
1954 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
1955 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
1956 case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT:
Chia-I Wu763a7492015-10-26 20:48:51 +08001957 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001958 skipCall |= validateImageView(my_data, &(pWDS->pImageInfo[i].imageView), pWDS->pImageInfo[i].imageLayout);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001959 }
1960 break;
1961 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
1962 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
Chia-I Wu763a7492015-10-26 20:48:51 +08001963 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001964 skipCall |= validateBufferView(my_data, &(pWDS->pTexelBufferView[i]));
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001965 }
1966 break;
1967 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
1968 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
1969 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
1970 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
Chia-I Wu763a7492015-10-26 20:48:51 +08001971 for (i=0; i<pWDS->descriptorCount; ++i) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06001972 skipCall |= validateBufferInfo(my_data, &(pWDS->pBufferInfo[i]));
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001973 }
1974 break;
Tobin Ehlisb46be812015-10-23 16:00:08 -06001975 }
1976 return skipCall;
1977}
Tobin Ehlis982099b2015-11-05 09:52:49 -07001978
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001979// update DS mappings based on write and copy update arrays
Chia-I Wu483e7702015-10-26 17:20:32 +08001980static VkBool32 dsUpdate(layer_data* my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pWDS, uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pCDS)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001981{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001982 VkBool32 skipCall = VK_FALSE;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08001983
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001984 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06001985 LAYOUT_NODE* pLayout = NULL;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06001986 VkDescriptorSetLayoutCreateInfo* pLayoutCI = NULL;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06001987 // Validate Write updates
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06001988 uint32_t i = 0;
Chia-I Wu483e7702015-10-26 17:20:32 +08001989 for (i=0; i < descriptorWriteCount; i++) {
Chia-I Wu1f851912015-10-27 18:04:07 +08001990 VkDescriptorSet ds = pWDS[i].dstSet;
Chia-I Wue420a332015-10-26 20:04:44 +08001991 SET_NODE* pSet = my_data->setMap[ds];
Tobin Ehlisb46be812015-10-23 16:00:08 -06001992 GENERIC_HEADER* pUpdate = (GENERIC_HEADER*) &pWDS[i];
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06001993 pLayout = pSet->pLayout;
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001994 // First verify valid update struct
Tobin Ehlis42d440c2015-10-20 17:06:16 -06001995 if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == VK_TRUE) {
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06001996 break;
1997 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06001998 uint32_t binding = 0, endIndex = 0;
Chia-I Wu1f851912015-10-27 18:04:07 +08001999 binding = pWDS[i].dstBinding;
Tobin Ehlis68fbd442015-10-27 12:25:35 -06002000 // Make sure that layout being updated has the binding being updated
Chia-I Wub5689ee2015-10-31 00:31:16 +08002001 if (pLayout->bindings.find(binding) == pLayout->bindings.end()) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002002 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) ds, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08002003 "Descriptor Set %" PRIu64 " does not have binding to match update binding %u for update type %s!", reinterpret_cast<uint64_t>(ds), binding, string_VkStructureType(pUpdate->sType));
Tobin Ehlise42007c2015-06-19 13:00:59 -06002004 } else {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002005 // Next verify that update falls within size of given binding
Chia-I Wu1f851912015-10-27 18:04:07 +08002006 endIndex = getUpdateEndIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002007 if (getBindingEndIndex(pLayout, binding) < endIndex) {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002008 pLayoutCI = &pLayout->createInfo;
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06002009 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002010 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) ds, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002011 "Descriptor update type of %s is out of bounds for matching binding %u in Layout w/ CI:\n%s!", string_VkStructureType(pUpdate->sType), binding, DSstr.c_str());
Tobin Ehlise42007c2015-06-19 13:00:59 -06002012 } else { // TODO : should we skip update on a type mismatch or force it?
Tobin Ehlis68fbd442015-10-27 12:25:35 -06002013 uint32_t startIndex;
Chia-I Wu1f851912015-10-27 18:04:07 +08002014 startIndex = getUpdateStartIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06002015 // Layout bindings match w/ update, now verify that update type & stageFlags are the same for entire update
2016 if ((skipCall = validateUpdateConsistency(my_data, device, pLayout, pUpdate, startIndex, endIndex)) == VK_FALSE) {
2017 // The update is within bounds and consistent, but need to make sure contents make sense as well
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002018 if ((skipCall = validateUpdateContents(my_data, &pWDS[i], &pLayout->createInfo.pBinding[binding])) == VK_FALSE) {
Tobin Ehlisb46be812015-10-23 16:00:08 -06002019 // Update is good. Save the update info
2020 // Create new update struct for this set's shadow copy
2021 GENERIC_HEADER* pNewNode = NULL;
2022 skipCall |= shadowUpdateNode(my_data, device, pUpdate, &pNewNode);
2023 if (NULL == pNewNode) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002024 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) ds, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Tobin Ehlisb46be812015-10-23 16:00:08 -06002025 "Out of memory while attempting to allocate UPDATE struct in vkUpdateDescriptors()");
2026 } else {
2027 // Insert shadow node into LL of updates for this set
2028 pNewNode->pNext = pSet->pUpdateStructs;
2029 pSet->pUpdateStructs = pNewNode;
2030 // Now update appropriate descriptor(s) to point to new Update node
Tobin Ehlisb46be812015-10-23 16:00:08 -06002031 for (uint32_t j = startIndex; j <= endIndex; j++) {
2032 assert(j<pSet->descriptorCount);
2033 pSet->ppDescriptors[j] = pNewNode;
2034 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002035 }
2036 }
2037 }
2038 }
2039 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002040 }
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002041 // Now validate copy updates
Chia-I Wu483e7702015-10-26 17:20:32 +08002042 for (i=0; i < descriptorCopyCount; ++i) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002043 SET_NODE *pSrcSet = NULL, *pDstSet = NULL;
2044 LAYOUT_NODE *pSrcLayout = NULL, *pDstLayout = NULL;
2045 uint32_t srcStartIndex = 0, srcEndIndex = 0, dstStartIndex = 0, dstEndIndex = 0;
2046 // For each copy make sure that update falls within given layout and that types match
Chia-I Wue420a332015-10-26 20:04:44 +08002047 pSrcSet = my_data->setMap[pCDS[i].srcSet];
Chia-I Wu1f851912015-10-27 18:04:07 +08002048 pDstSet = my_data->setMap[pCDS[i].dstSet];
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002049 pSrcLayout = pSrcSet->pLayout;
2050 pDstLayout = pDstSet->pLayout;
2051 // Validate that src binding is valid for src set layout
Chia-I Wub5689ee2015-10-31 00:31:16 +08002052 if (pSrcLayout->bindings.find(pCDS[i].srcBinding) == pSrcLayout->bindings.end()) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002053 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pSrcSet->set, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002054 "Copy descriptor update %u has srcBinding %u which is out of bounds for underlying SetLayout %#" PRIxLEAST64 " which only has bindings 0-%u.",
Chia-I Wu763a7492015-10-26 20:48:51 +08002055 i, pCDS[i].srcBinding, (uint64_t) pSrcLayout->layout, pSrcLayout->createInfo.bindingCount-1);
Chia-I Wub5689ee2015-10-31 00:31:16 +08002056 } else if (pDstLayout->bindings.find(pCDS[i].dstBinding) == pDstLayout->bindings.end()) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002057 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDstSet->set, 0, DRAWSTATE_INVALID_UPDATE_INDEX, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08002058 "Copy descriptor update %u has dstBinding %u which is out of bounds for underlying SetLayout %#" PRIxLEAST64 " which only has bindings 0-%u.",
2059 i, pCDS[i].dstBinding, (uint64_t) pDstLayout->layout, pDstLayout->createInfo.bindingCount-1);
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002060 } else {
2061 // Proceed with validation. Bindings are ok, but make sure update is within bounds of given layout
2062 srcEndIndex = getUpdateEndIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu1f851912015-10-27 18:04:07 +08002063 dstEndIndex = getUpdateEndIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002064 if (getBindingEndIndex(pSrcLayout, pCDS[i].srcBinding) < srcEndIndex) {
2065 pLayoutCI = &pSrcLayout->createInfo;
2066 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002067 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pSrcSet->set, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002068 "Copy descriptor src update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", pCDS[i].srcBinding, DSstr.c_str());
Chia-I Wu1f851912015-10-27 18:04:07 +08002069 } else if (getBindingEndIndex(pDstLayout, pCDS[i].dstBinding) < dstEndIndex) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002070 pLayoutCI = &pDstLayout->createInfo;
2071 string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} ");
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002072 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDstSet->set, 0, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08002073 "Copy descriptor dest update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", pCDS[i].dstBinding, DSstr.c_str());
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002074 } else {
2075 srcStartIndex = getUpdateStartIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu1f851912015-10-27 18:04:07 +08002076 dstStartIndex = getUpdateStartIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, (const GENERIC_HEADER*)&(pCDS[i]));
Chia-I Wu763a7492015-10-26 20:48:51 +08002077 for (uint32_t j=0; j<pCDS[i].descriptorCount; ++j) {
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002078 // For copy just make sure that the types match and then perform the update
2079 if (pSrcLayout->descriptorTypes[srcStartIndex+j] != pDstLayout->descriptorTypes[dstStartIndex+j]) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002080 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS",
Tobin Ehlisd2e246e2015-10-27 15:43:38 -06002081 "Copy descriptor update index %u, update count #%u, has src update descriptor type %s that does not match overlapping dest descriptor type of %s!",
2082 i, j+1, string_VkDescriptorType(pSrcLayout->descriptorTypes[srcStartIndex+j]), string_VkDescriptorType(pDstLayout->descriptorTypes[dstStartIndex+j]));
2083 } else {
2084 // point dst descriptor at corresponding src descriptor
2085 pDstSet->ppDescriptors[j+dstStartIndex] = pSrcSet->ppDescriptors[j+srcStartIndex];
2086 }
2087 }
2088 }
2089 }
2090 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002091 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002092 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002093}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002094
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002095// Verify that given pool has descriptors that are being requested for allocation
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002096static VkBool32 validate_descriptor_availability_in_pool(layer_data* dev_data, DESCRIPTOR_POOL_NODE* pPoolNode, uint32_t count, const VkDescriptorSetLayout* pSetLayouts)
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002097{
2098 VkBool32 skipCall = VK_FALSE;
2099 uint32_t i = 0, j = 0;
2100 for (i=0; i<count; ++i) {
2101 LAYOUT_NODE* pLayout = getLayoutNode(dev_data, pSetLayouts[i]);
2102 if (NULL == pLayout) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002103 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t) pSetLayouts[i], 0, DRAWSTATE_INVALID_LAYOUT, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08002104 "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pSetLayouts[i]);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002105 } else {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002106 uint32_t typeIndex = 0, poolSizeCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08002107 for (j=0; j<pLayout->createInfo.bindingCount; ++j) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002108 typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBinding[j].descriptorType);
Chia-I Wu045654f2015-11-06 06:42:02 +08002109 poolSizeCount = pLayout->createInfo.pBinding[j].descriptorCount;
Chia-I Wuc51b1212015-10-27 19:25:11 +08002110 if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002111 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t) pLayout->layout, 0, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS",
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002112 "Unable to allocate %u descriptors of type %s from pool %#" PRIxLEAST64 ". This pool only has %u descriptors of this type remaining.",
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002113 poolSizeCount, string_VkDescriptorType(pLayout->createInfo.pBinding[j].descriptorType), (uint64_t) pPoolNode->pool, pPoolNode->availableDescriptorTypeCount[typeIndex]);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002114 } else { // Decrement available descriptors of this type
Chia-I Wuc51b1212015-10-27 19:25:11 +08002115 pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount;
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002116 }
2117 }
2118 }
2119 }
2120 return skipCall;
2121}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002122
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002123// Free the shadowed update node for this Set
2124// NOTE : Calls to this function should be wrapped in mutex
2125static void freeShadowUpdateTree(SET_NODE* pSet)
2126{
2127 GENERIC_HEADER* pShadowUpdate = pSet->pUpdateStructs;
2128 pSet->pUpdateStructs = NULL;
2129 GENERIC_HEADER* pFreeUpdate = pShadowUpdate;
2130 // Clear the descriptor mappings as they will now be invalid
2131 memset(pSet->ppDescriptors, 0, pSet->descriptorCount*sizeof(GENERIC_HEADER*));
2132 while(pShadowUpdate) {
2133 pFreeUpdate = pShadowUpdate;
2134 pShadowUpdate = (GENERIC_HEADER*)pShadowUpdate->pNext;
2135 uint32_t index = 0;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08002136 VkWriteDescriptorSet * pWDS = NULL;
2137 VkCopyDescriptorSet * pCDS = NULL;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002138 void** ppToFree = NULL;
2139 switch (pFreeUpdate->sType)
2140 {
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08002141 case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET:
2142 pWDS = (VkWriteDescriptorSet*)pFreeUpdate;
Tony Barbourf740f902015-11-02 11:46:29 -07002143 switch (pWDS->descriptorType) {
2144 case VK_DESCRIPTOR_TYPE_SAMPLER:
2145 case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER:
2146 case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE:
2147 case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE:
2148 {
2149 delete[] pWDS->pImageInfo;
2150 }
2151 break;
2152 case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER:
2153 case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER:
2154 {
2155 delete[] pWDS->pTexelBufferView;
2156 }
2157 break;
2158 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER:
2159 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER:
2160 case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC:
2161 case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC:
2162 {
2163 delete[] pWDS->pBufferInfo;
2164 }
2165 break;
2166 default:
2167 break;
Courtney Goeltzenleuchtere4099742015-10-22 15:31:56 -06002168 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002169 break;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08002170 case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET:
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002171 break;
2172 default:
2173 assert(0);
2174 break;
2175 }
Tobin Ehliseaf28662015-04-08 10:58:37 -06002176 delete pFreeUpdate;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002177 }
2178}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002179
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002180// Free all DS Pools including their Sets & related sub-structs
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002181// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002182static void deletePools(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002183{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002184 if (my_data->descriptorPoolMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -06002185 return;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002186 for (auto ii=my_data->descriptorPoolMap.begin(); ii!=my_data->descriptorPoolMap.end(); ++ii) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002187 SET_NODE* pSet = (*ii).second->pSets;
2188 SET_NODE* pFreeSet = pSet;
2189 while (pSet) {
2190 pFreeSet = pSet;
2191 pSet = pSet->pNext;
Tobin Ehliseaf28662015-04-08 10:58:37 -06002192 // Freeing layouts handled in deleteLayouts() function
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002193 // Free Update shadow struct tree
2194 freeShadowUpdateTree(pFreeSet);
2195 if (pFreeSet->ppDescriptors) {
Chris Forbes4506d3f2015-06-04 10:49:27 +12002196 delete[] pFreeSet->ppDescriptors;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002197 }
2198 delete pFreeSet;
2199 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002200 delete (*ii).second;
2201 }
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002202 my_data->descriptorPoolMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002203}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002204
Tobin Ehliseaf28662015-04-08 10:58:37 -06002205// WARN : Once deleteLayouts() called, any layout ptrs in Pool/Set data structure will be invalid
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002206// NOTE : Calls to this function should be wrapped in mutex
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002207static void deleteLayouts(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002208{
Tobin Ehlisad61de42015-12-02 13:53:34 -07002209 if (my_data->descriptorSetLayoutMap.size() <= 0)
David Pinedof5997ab2015-04-27 16:36:17 -06002210 return;
Tobin Ehlisad61de42015-12-02 13:53:34 -07002211 for (auto ii=my_data->descriptorSetLayoutMap.begin(); ii!=my_data->descriptorSetLayoutMap.end(); ++ii) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002212 LAYOUT_NODE* pLayout = (*ii).second;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002213 if (pLayout->createInfo.pBinding) {
Chia-I Wu763a7492015-10-26 20:48:51 +08002214 for (uint32_t i=0; i<pLayout->createInfo.bindingCount; i++) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002215 if (pLayout->createInfo.pBinding[i].pImmutableSamplers)
2216 delete[] pLayout->createInfo.pBinding[i].pImmutableSamplers;
Tobin Ehliseaf28662015-04-08 10:58:37 -06002217 }
Chia-I Wuf03cbf72015-10-31 00:31:16 +08002218 delete[] pLayout->createInfo.pBinding;
Tobin Ehliseaf28662015-04-08 10:58:37 -06002219 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002220 delete pLayout;
2221 }
Tobin Ehlisad61de42015-12-02 13:53:34 -07002222 my_data->descriptorSetLayoutMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002223}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002224
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002225// Currently clearing a set is removing all previous updates to that set
2226// TODO : Validate if this is correct clearing behavior
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002227static void clearDescriptorSet(layer_data* my_data, VkDescriptorSet set)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002228{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002229 SET_NODE* pSet = getSetNode(my_data, set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002230 if (!pSet) {
2231 // TODO : Return error
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002232 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002233 loader_platform_thread_lock_mutex(&globalLock);
2234 freeShadowUpdateTree(pSet);
2235 loader_platform_thread_unlock_mutex(&globalLock);
2236 }
2237}
2238
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002239static void clearDescriptorPool(layer_data* my_data, const VkDevice device, const VkDescriptorPool pool, VkDescriptorPoolResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002240{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002241 DESCRIPTOR_POOL_NODE* pPool = getPoolNode(my_data, pool);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002242 if (!pPool) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002243 log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, (uint64_t) pool, 0, DRAWSTATE_INVALID_POOL, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08002244 "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t) pool);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002245 } else {
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06002246 // TODO: validate flags
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002247 // For every set off of this pool, clear it
2248 SET_NODE* pSet = pPool->pSets;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002249 while (pSet) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002250 clearDescriptorSet(my_data, pSet->set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002251 }
Tobin Ehlisc6457d22015-10-20 16:16:04 -06002252 // Reset available count to max count for this pool
2253 for (uint32_t i=0; i<pPool->availableDescriptorTypeCount.size(); ++i) {
2254 pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i];
2255 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002256 }
2257}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002258
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002259// For given CB object, fetch associated CB Node from map
Chia-I Wu1f851912015-10-27 18:04:07 +08002260static GLOBAL_CB_NODE* getCBNode(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002261{
2262 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002263 if (my_data->commandBufferMap.count(cb) == 0) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002264 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002265 // TODO : How to pass cb as srcObj here?
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002266 log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08002267 "Attempt to use CommandBuffer %#" PRIxLEAST64 " that doesn't exist!", reinterpret_cast<uint64_t>(cb));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002268 return NULL;
2269 }
2270 loader_platform_thread_unlock_mutex(&globalLock);
Chia-I Wu1f851912015-10-27 18:04:07 +08002271 return my_data->commandBufferMap[cb];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002272}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002273
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002274// Free all CB Nodes
2275// NOTE : Calls to this function should be wrapped in mutex
Chia-I Wu1f851912015-10-27 18:04:07 +08002276static void deleteCommandBuffers(layer_data* my_data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002277{
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002278 if (my_data->commandBufferMap.size() <= 0) {
David Pinedof5997ab2015-04-27 16:36:17 -06002279 return;
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002280 }
Chia-I Wu1f851912015-10-27 18:04:07 +08002281 for (auto ii=my_data->commandBufferMap.begin(); ii!=my_data->commandBufferMap.end(); ++ii) {
Courtney Goeltzenleuchter09098a72015-04-27 15:04:43 -06002282 vector<CMD_NODE*> cmd_node_list = (*ii).second->pCmds;
2283 while (!cmd_node_list.empty()) {
2284 CMD_NODE* cmd_node = cmd_node_list.back();
2285 delete cmd_node;
2286 cmd_node_list.pop_back();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002287 }
2288 delete (*ii).second;
2289 }
Chia-I Wu1f851912015-10-27 18:04:07 +08002290 my_data->commandBufferMap.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002291}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002292
Chia-I Wu1f851912015-10-27 18:04:07 +08002293static VkBool32 report_error_no_cb_begin(const layer_data* dev_data, const VkCommandBuffer cb, const char* caller_name)
Tobin Ehlise42007c2015-06-19 13:00:59 -06002294{
Tobin Ehlisb51cb782015-12-16 08:19:42 -07002295 return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
2296 (uint64_t)cb, 0, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS",
2297 "You must call vkBeginCommandBuffer() before this call to %s", caller_name);
Tobin Ehlise42007c2015-06-19 13:00:59 -06002298}
Michael Lentine2b9eda42015-10-28 15:55:18 -07002299
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07002300VkBool32 validateCmdsInCmdBuffer(const layer_data* dev_data, const GLOBAL_CB_NODE* pCB, const CMD_TYPE cmd_type) {
Tony Barbour778b08c2015-12-17 15:54:05 -07002301 // TODO : I think this is trying to validate this part of the spec:
2302 // If contents is VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS, the contents are recorded in secondary command
2303 // buffers that will be called from the primary command buffer, and vkCmdExecuteCommands is the only valid command
2304 // on the command buffer until vkCmdNextSubpass or vkCmdEndRenderPass.
2305 //
2306 // But the code below is forceing vkCmdExecuteCommands to be the only thing in the command buffer which is not necessary
2307 // it just needs to be the only thing in the renderpass
2308 //
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07002309 VkBool32 skip_call = false;
Tony Barbour778b08c2015-12-17 15:54:05 -07002310 //for (auto cmd : pCB->pCmds) {
2311 // if (cmd_type == CMD_EXECUTECOMMANDS && cmd->type != CMD_EXECUTECOMMANDS) {
2312 // skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
2313 // "vkCmdExecuteCommands() cannot be called on a cmd buffer with exsiting commands.");
2314 // }
2315 // if (cmd_type != CMD_EXECUTECOMMANDS && cmd->type == CMD_EXECUTECOMMANDS) {
2316 // skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
2317 // "Commands cannot be added to a cmd buffer with exsiting secondary commands.");
2318 // }
2319 //}
Michael Lentine2b9eda42015-10-28 15:55:18 -07002320 return skip_call;
2321}
2322
Tobin Ehlisb51cb782015-12-16 08:19:42 -07002323// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not
2324// in the recording state or if there's an issue with the Cmd ordering
2325static VkBool32 addCmd(const layer_data* my_data, GLOBAL_CB_NODE* pCB, const CMD_TYPE cmd, const char* caller_name)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002326{
Tobin Ehlisb51cb782015-12-16 08:19:42 -07002327 VkBool32 skipCall = VK_FALSE;
2328 if (pCB->state != CB_RECORDING) {
2329 skipCall |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name);
2330 skipCall |= validateCmdsInCmdBuffer(my_data, pCB, cmd);
2331 CMD_NODE* pCmd = new CMD_NODE;
2332 if (pCmd) {
2333 // init cmd node and append to end of cmd LL
2334 memset(pCmd, 0, sizeof(CMD_NODE));
2335 pCmd->cmdNumber = ++pCB->numCmds;
2336 pCmd->type = cmd;
2337 pCB->pCmds.push_back(pCmd);
2338 } else {
2339 // TODO : How to pass cb as srcObj here?
2340 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
2341 "Out of memory while attempting to allocate new CMD_NODE for commandBuffer %#" PRIxLEAST64, reinterpret_cast<uint64_t>(pCB->commandBuffer));
2342 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002343 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002344 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002345}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002346
Chia-I Wu1f851912015-10-27 18:04:07 +08002347static void resetCB(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002348{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002349 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002350 if (pCB) {
Courtney Goeltzenleuchterf03711e2015-04-27 17:16:56 -06002351 vector<CMD_NODE*> cmd_list = pCB->pCmds;
2352 while (!cmd_list.empty()) {
2353 delete cmd_list.back();
2354 cmd_list.pop_back();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002355 }
Courtney Goeltzenleuchterf03711e2015-04-27 17:16:56 -06002356 pCB->pCmds.clear();
Tobin Ehlis0cea4082015-08-18 07:10:58 -06002357 // Reset CB state (need to save createInfo)
Chia-I Wu1f851912015-10-27 18:04:07 +08002358 VkCommandBufferAllocateInfo saveCBCI = pCB->createInfo;
Chia-I Wu1f851912015-10-27 18:04:07 +08002359 pCB->commandBuffer = cb;
Tobin Ehlis0cea4082015-08-18 07:10:58 -06002360 pCB->createInfo = saveCBCI;
Michael Lentine27b0f902015-10-12 11:30:14 -05002361 memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo));
2362 pCB->fence = 0;
2363 pCB->numCmds = 0;
2364 memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t));
2365 pCB->state = CB_NEW;
2366 pCB->submitCount = 0;
2367 pCB->status = 0;
2368 pCB->pCmds.clear();
2369 pCB->lastBoundPipeline = 0;
2370 pCB->viewports.clear();
2371 pCB->scissors.clear();
2372 pCB->lineWidth = 0;
2373 pCB->depthBiasConstantFactor = 0;
2374 pCB->depthBiasClamp = 0;
2375 pCB->depthBiasSlopeFactor = 0;
2376 memset(pCB->blendConstants, 0, 4 * sizeof(float));
2377 pCB->minDepthBounds = 0;
2378 pCB->maxDepthBounds = 0;
2379 memset(&pCB->front, 0, sizeof(stencil_data));
2380 memset(&pCB->back, 0, sizeof(stencil_data));
2381 pCB->lastBoundDescriptorSet = 0;
2382 pCB->lastBoundPipelineLayout = 0;
2383 pCB->activeRenderPass = 0;
2384 pCB->activeSubpass = 0;
2385 pCB->framebuffer = 0;
Michael Lentine27b0f902015-10-12 11:30:14 -05002386 pCB->boundDescriptorSets.clear();
2387 pCB->imageLayoutMap.clear();
Mark Lobodzinski74e84692015-12-14 15:14:10 -07002388 pCB->boundVtxBuffers.clear();
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002389 }
2390}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002391
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002392// Set PSO-related status bits for CB, including dynamic state set via PSO
Tobin Ehlis97866202015-06-10 12:57:07 -06002393static void set_cb_pso_status(GLOBAL_CB_NODE* pCB, const PIPELINE_NODE* pPipe)
2394{
2395 for (uint32_t i = 0; i < pPipe->cbStateCI.attachmentCount; i++) {
Chia-I Wuc51b1212015-10-27 19:25:11 +08002396 if (0 != pPipe->pAttachments[i].colorWriteMask) {
Tobin Ehlis97866202015-06-10 12:57:07 -06002397 pCB->status |= CBSTATUS_COLOR_BLEND_WRITE_ENABLE;
2398 }
2399 }
2400 if (pPipe->dsStateCI.depthWriteEnable) {
Cody Northrop2605cb02015-08-18 15:21:16 -06002401 pCB->status |= CBSTATUS_DEPTH_WRITE_ENABLE;
2402 }
Cody Northrop2605cb02015-08-18 15:21:16 -06002403 if (pPipe->dsStateCI.stencilTestEnable) {
2404 pCB->status |= CBSTATUS_STENCIL_TEST_ENABLE;
Tobin Ehlis97866202015-06-10 12:57:07 -06002405 }
Tobin Ehlisa88e2f52015-10-02 11:00:56 -06002406 // Account for any dynamic state not set via this PSO
2407 if (!pPipe->dynStateCI.dynamicStateCount) { // All state is static
2408 pCB->status = CBSTATUS_ALL;
2409 } else {
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002410 // First consider all state on
2411 // Then unset any state that's noted as dynamic in PSO
2412 // Finally OR that into CB statemask
2413 CBStatusFlags psoDynStateMask = CBSTATUS_ALL;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002414 for (uint32_t i=0; i < pPipe->dynStateCI.dynamicStateCount; i++) {
2415 switch (pPipe->dynStateCI.pDynamicStates[i]) {
2416 case VK_DYNAMIC_STATE_VIEWPORT:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002417 psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002418 break;
2419 case VK_DYNAMIC_STATE_SCISSOR:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002420 psoDynStateMask &= ~CBSTATUS_SCISSOR_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002421 break;
2422 case VK_DYNAMIC_STATE_LINE_WIDTH:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002423 psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002424 break;
2425 case VK_DYNAMIC_STATE_DEPTH_BIAS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002426 psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002427 break;
2428 case VK_DYNAMIC_STATE_BLEND_CONSTANTS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002429 psoDynStateMask &= ~CBSTATUS_BLEND_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002430 break;
2431 case VK_DYNAMIC_STATE_DEPTH_BOUNDS:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002432 psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002433 break;
2434 case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002435 psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002436 break;
2437 case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002438 psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002439 break;
2440 case VK_DYNAMIC_STATE_STENCIL_REFERENCE:
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002441 psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002442 break;
2443 default:
2444 // TODO : Flag error here
2445 break;
2446 }
2447 }
Tobin Ehlis3dec46c2015-10-01 09:24:40 -06002448 pCB->status |= psoDynStateMask;
Tobin Ehlisf6cb4672015-09-29 08:18:34 -06002449 }
Tobin Ehlis97866202015-06-10 12:57:07 -06002450}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002451
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002452// Print the last bound Gfx Pipeline
Chia-I Wu1f851912015-10-27 18:04:07 +08002453static VkBool32 printPipeline(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002454{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002455 VkBool32 skipCall = VK_FALSE;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002456 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002457 if (pCB) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002458 PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBoundPipeline);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002459 if (!pPipeTrav) {
2460 // nothing to print
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002461 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002462 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08002463 "%s", vk_print_vkgraphicspipelinecreateinfo(&pPipeTrav->graphicsPipelineCI, "{DS}").c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002464 }
2465 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002466 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002467}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002468
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002469// Print details of DS config to stdout
Chia-I Wu1f851912015-10-27 18:04:07 +08002470static VkBool32 printDSConfig(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002471{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002472 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002473 char ds_config_str[1024*256] = {0}; // TODO : Currently making this buffer HUGE w/o overrun protection. Need to be smarter, start smaller, and grow as needed.
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002474 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
Tobin Ehlis7297f192015-06-09 08:39:32 -06002475 if (pCB && pCB->lastBoundDescriptorSet) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002476 SET_NODE* pSet = getSetNode(my_data, pCB->lastBoundDescriptorSet);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002477 DESCRIPTOR_POOL_NODE* pPool = getPoolNode(my_data, pSet->pool);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002478 // Print out pool details
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002479 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08002480 "Details for pool %#" PRIxLEAST64 ".", (uint64_t) pPool->pool);
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06002481 string poolStr = vk_print_vkdescriptorpoolcreateinfo(&pPool->createInfo, " ");
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002482 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002483 "%s", poolStr.c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002484 // Print out set details
2485 char prefix[10];
2486 uint32_t index = 0;
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002487 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08002488 "Details for descriptor set %#" PRIxLEAST64 ".", (uint64_t) pSet->set);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002489 LAYOUT_NODE* pLayout = pSet->pLayout;
2490 // Print layout details
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002491 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08002492 "Layout #%u, (object %#" PRIxLEAST64 ") for DS %#" PRIxLEAST64 ".", index+1, reinterpret_cast<uint64_t>(pLayout->layout), reinterpret_cast<uint64_t>(pSet->set));
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002493 sprintf(prefix, " [L%u] ", index);
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06002494 string DSLstr = vk_print_vkdescriptorsetlayoutcreateinfo(&pLayout->createInfo, prefix).c_str();
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002495 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002496 "%s", DSLstr.c_str());
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06002497 index++;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002498 GENERIC_HEADER* pUpdate = pSet->pUpdateStructs;
2499 if (pUpdate) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002500 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08002501 "Update Chain [UC] for descriptor set %#" PRIxLEAST64 ":", (uint64_t) pSet->set);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002502 sprintf(prefix, " [UC] ");
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002503 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08002504 "%s", dynamic_display(pUpdate, prefix).c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002505 // TODO : If there is a "view" associated with this update, print CI for that view
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002506 } else {
Tobin Ehlis2bca8b02015-06-15 08:41:17 -06002507 if (0 != pSet->descriptorCount) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002508 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08002509 "No Update Chain for descriptor set %#" PRIxLEAST64 " which has %u descriptors (vkUpdateDescriptors has not been called)", (uint64_t) pSet->set, pSet->descriptorCount);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002510 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002511 skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08002512 "FYI: No descriptors in descriptor set %#" PRIxLEAST64 ".", (uint64_t) pSet->set);
Tobin Ehlis2bca8b02015-06-15 08:41:17 -06002513 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002514 }
2515 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002516 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002517}
2518
Chia-I Wu1f851912015-10-27 18:04:07 +08002519static void printCB(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002520{
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002521 GLOBAL_CB_NODE* pCB = getCBNode(my_data, cb);
David Pinedof5997ab2015-04-27 16:36:17 -06002522 if (pCB && pCB->pCmds.size() > 0) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002523 log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_NONE, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002524 "Cmds in CB %p", (void*)cb);
Courtney Goeltzenleuchtercf2a5362015-04-27 11:16:35 -06002525 vector<CMD_NODE*> pCmds = pCB->pCmds;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002526 for (auto ii=pCmds.begin(); ii!=pCmds.end(); ++ii) {
2527 // TODO : Need to pass cb as srcObj here
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002528 log_msg(my_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NONE, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08002529 " CMD#%" PRIu64 ": %s", (*ii)->cmdNumber, cmdTypeToString((*ii)->type).c_str());
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002530 }
Tobin Ehlisa366ca22015-06-19 15:07:05 -06002531 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002532 // Nothing to print
2533 }
2534}
2535
Chia-I Wu1f851912015-10-27 18:04:07 +08002536static VkBool32 synchAndPrintDSConfig(layer_data* my_data, const VkCommandBuffer cb)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002537{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002538 VkBool32 skipCall = VK_FALSE;
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002539 if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFO_BIT_EXT)) {
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002540 return skipCall;
Mike Stroyanfa2f2222015-08-12 17:11:28 -06002541 }
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002542 skipCall |= printDSConfig(my_data, cb);
2543 skipCall |= printPipeline(my_data, cb);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002544 return skipCall;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002545}
2546
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002547// Flags validation error if the associated call is made inside a render pass. The apiName
2548// routine should ONLY be called outside a render pass.
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002549static VkBool32 insideRenderPass(const layer_data* my_data, GLOBAL_CB_NODE *pCB, const char *apiName)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002550{
2551 VkBool32 inside = VK_FALSE;
2552 if (pCB->activeRenderPass) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002553 inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Chia-I Wu1f851912015-10-27 18:04:07 +08002554 (uint64_t)pCB->commandBuffer, 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002555 "%s: It is invalid to issue this call inside an active render pass (%#" PRIxLEAST64 ")",
Chia-I Wue420a332015-10-26 20:04:44 +08002556 apiName, (uint64_t) pCB->activeRenderPass);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002557 }
2558 return inside;
2559}
2560
2561// Flags validation error if the associated call is made outside a render pass. The apiName
2562// routine should ONLY be called inside a render pass.
Tobin Ehlis42d440c2015-10-20 17:06:16 -06002563static VkBool32 outsideRenderPass(const layer_data* my_data, GLOBAL_CB_NODE *pCB, const char *apiName)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002564{
2565 VkBool32 outside = VK_FALSE;
Mark Lobodzinski611cf592015-12-18 15:35:38 -07002566 if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) &&
2567 (!pCB->activeRenderPass)) ||
2568 ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) &&
2569 (!pCB->activeRenderPass) &&
2570 !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002571 outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Chia-I Wu1f851912015-10-27 18:04:07 +08002572 (uint64_t)pCB->commandBuffer, 0, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS",
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06002573 "%s: This call must be issued inside an active render pass.", apiName);
2574 }
2575 return outside;
2576}
2577
Courtney Goeltzenleuchterb03a0bf2015-11-25 14:31:49 -07002578static void init_draw_state(layer_data *my_data, const VkAllocationCallbacks *pAllocator)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002579{
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002580 uint32_t report_flags = 0;
2581 uint32_t debug_action = 0;
2582 FILE *log_output = NULL;
2583 const char *option_str;
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002584 VkDebugReportCallbackEXT callback;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002585 // initialize DrawState options
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002586 report_flags = getLayerOptionFlags("DrawStateReportFlags", 0);
2587 getLayerOptionEnum("DrawStateDebugAction", (uint32_t *) &debug_action);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002588
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002589 if (debug_action & VK_DBG_LAYER_ACTION_LOG_MSG)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002590 {
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002591 option_str = getLayerOption("DrawStateLogFilename");
Tobin Ehlisb4b6e7c2015-09-15 09:55:54 -06002592 log_output = getLayerLogOutput(option_str, "DrawState");
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002593 VkDebugReportCallbackCreateInfoEXT dbgInfo;
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07002594 memset(&dbgInfo, 0, sizeof(dbgInfo));
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002595 dbgInfo.sType = VK_STRUCTURE_TYPE_DEBUG_REPORT_CREATE_INFO_EXT;
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07002596 dbgInfo.pfnCallback = log_callback;
2597 dbgInfo.pUserData = log_output;
2598 dbgInfo.flags = report_flags;
2599 layer_create_msg_callback(my_data->report_data, &dbgInfo, pAllocator, &callback);
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06002600 my_data->logging_callback.push_back(callback);
2601 }
2602
2603 if (debug_action & VK_DBG_LAYER_ACTION_DEBUG_OUTPUT) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002604 VkDebugReportCallbackCreateInfoEXT dbgInfo;
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07002605 memset(&dbgInfo, 0, sizeof(dbgInfo));
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002606 dbgInfo.sType = VK_STRUCTURE_TYPE_DEBUG_REPORT_CREATE_INFO_EXT;
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07002607 dbgInfo.pfnCallback = win32_debug_output_msg;
2608 dbgInfo.pUserData = log_output;
2609 dbgInfo.flags = report_flags;
2610 layer_create_msg_callback(my_data->report_data, &dbgInfo, pAllocator, &callback);
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06002611 my_data->logging_callback.push_back(callback);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002612 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002613
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002614 if (!globalLockInitialized)
2615 {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002616 loader_platform_thread_create_mutex(&globalLock);
2617 globalLockInitialized = 1;
2618 }
2619}
2620
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002621VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkInstance* pInstance)
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06002622{
Tobin Ehliscb085292015-12-01 09:57:09 -07002623 // TODOSC : Shouldn't need any customization here
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002624 layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map);
2625 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Chia-I Wu69f40122015-10-26 21:10:41 +08002626 VkResult result = pTable->CreateInstance(pCreateInfo, pAllocator, pInstance);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06002627
2628 if (result == VK_SUCCESS) {
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002629 layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map);
2630 my_data->report_data = debug_report_create_instance(
2631 pTable,
2632 *pInstance,
Chia-I Wu763a7492015-10-26 20:48:51 +08002633 pCreateInfo->enabledExtensionNameCount,
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002634 pCreateInfo->ppEnabledExtensionNames);
Courtney Goeltzenleuchterf4a2eba2015-06-08 14:58:39 -06002635
Courtney Goeltzenleuchterb03a0bf2015-11-25 14:31:49 -07002636 init_draw_state(my_data, pAllocator);
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06002637 }
2638 return result;
2639}
2640
Jon Ashburne0fa2282015-05-20 09:00:28 -06002641/* hook DestroyInstance to remove tableInstanceMap entry */
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002642VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks* pAllocator)
Jon Ashburne0fa2282015-05-20 09:00:28 -06002643{
Tobin Ehliscb085292015-12-01 09:57:09 -07002644 // TODOSC : Shouldn't need any customization here
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002645 dispatch_key key = get_dispatch_key(instance);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002646 layer_data *my_data = get_my_data_ptr(key, layer_data_map);
2647 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Chia-I Wu69f40122015-10-26 21:10:41 +08002648 pTable->DestroyInstance(instance, pAllocator);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002649
2650 // Clean up logging callback, if any
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06002651 while (my_data->logging_callback.size() > 0) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002652 VkDebugReportCallbackEXT callback = my_data->logging_callback.back();
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07002653 layer_destroy_msg_callback(my_data->report_data, callback, pAllocator);
Courtney Goeltzenleuchter1781b1c2015-10-05 15:58:38 -06002654 my_data->logging_callback.pop_back();
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002655 }
2656
Courtney Goeltzenleuchter2d034fd2015-06-28 13:01:17 -06002657 layer_debug_report_destroy_instance(my_data->report_data);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002658 delete my_data->instance_dispatch_table;
2659 layer_data_map.erase(key);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002660 // TODO : Potential race here with separate threads creating/destroying instance
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002661 if (layer_data_map.empty()) {
Mike Stroyand9dd0072015-08-18 15:56:18 -06002662 // Release mutex when destroying last instance.
2663 loader_platform_thread_delete_mutex(&globalLock);
2664 globalLockInitialized = 0;
2665 }
Jon Ashburne0fa2282015-05-20 09:00:28 -06002666}
2667
Jon Ashburnf0615e22015-05-25 14:11:37 -06002668static void createDeviceRegisterExtensions(const VkDeviceCreateInfo* pCreateInfo, VkDevice device)
2669{
Tony Barbour29b12062015-07-13 13:37:24 -06002670 uint32_t i;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002671 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2672 dev_data->device_extensions.debug_marker_enabled = false;
Michael Lentine27b0f902015-10-12 11:30:14 -05002673 dev_data->device_extensions.wsi_enabled = false;
2674
2675
2676 VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table;
2677 PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr;
2678
Michael Lentine27b0f902015-10-12 11:30:14 -05002679 pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR) gpa(device, "vkCreateSwapchainKHR");
2680 pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR) gpa(device, "vkDestroySwapchainKHR");
2681 pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR) gpa(device, "vkGetSwapchainImagesKHR");
2682 pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR) gpa(device, "vkAcquireNextImageKHR");
2683 pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR) gpa(device, "vkQueuePresentKHR");
Jon Ashburnf0615e22015-05-25 14:11:37 -06002684
Chia-I Wu763a7492015-10-26 20:48:51 +08002685 for (i = 0; i < pCreateInfo->enabledExtensionNameCount; i++) {
Ian Elliottc623ba52015-11-20 14:13:17 -07002686 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) {
Michael Lentine27b0f902015-10-12 11:30:14 -05002687 dev_data->device_extensions.wsi_enabled = true;
2688 }
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002689 if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], DEBUG_MARKER_EXTENSION_NAME) == 0) {
Jon Ashburn6f8cd632015-06-01 09:37:38 -06002690 /* Found a matching extension name, mark it enabled and init dispatch table*/
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002691 dev_data->device_extensions.debug_marker_enabled = true;
Jon Ashburnc1d059f2015-12-10 19:12:21 -07002692 initDebugMarkerTable(device);
2693
Jon Ashburnf0615e22015-05-25 14:11:37 -06002694 }
Jon Ashburnf0615e22015-05-25 14:11:37 -06002695 }
2696}
2697
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002698VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDevice* pDevice)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002699{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002700 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002701 VkResult result = dev_data->device_dispatch_table->CreateDevice(gpu, pCreateInfo, pAllocator, pDevice);
Tobin Ehliscb085292015-12-01 09:57:09 -07002702 // TODOSC : shouldn't need any customization here
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002703 if (result == VK_SUCCESS) {
2704 layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002705 dev_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice);
Jon Ashburn7e07faf2015-06-18 15:02:58 -06002706 createDeviceRegisterExtensions(pCreateInfo, *pDevice);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06002707 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002708 return result;
2709}
Tobin Ehlis982099b2015-11-05 09:52:49 -07002710
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002711// prototype
2712static void deleteRenderPasses(layer_data*);
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002713VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002714{
Tobin Ehliscb085292015-12-01 09:57:09 -07002715 // TODOSC : Shouldn't need any customization here
Jeremy Hayesea1fef52015-06-19 11:37:38 -06002716 dispatch_key key = get_dispatch_key(device);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002717 layer_data* dev_data = get_my_data_ptr(key, layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002718 // Free all the memory
2719 loader_platform_thread_lock_mutex(&globalLock);
2720 deletePipelines(dev_data);
2721 deleteRenderPasses(dev_data);
Chia-I Wu1f851912015-10-27 18:04:07 +08002722 deleteCommandBuffers(dev_data);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002723 deletePools(dev_data);
2724 deleteLayouts(dev_data);
Tobin Ehlisb46be812015-10-23 16:00:08 -06002725 dev_data->imageViewMap.clear();
2726 dev_data->imageMap.clear();
2727 dev_data->bufferViewMap.clear();
2728 dev_data->bufferMap.clear();
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002729 loader_platform_thread_unlock_mutex(&globalLock);
2730
Chia-I Wu69f40122015-10-26 21:10:41 +08002731 dev_data->device_dispatch_table->DestroyDevice(device, pAllocator);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06002732 tableDebugMarkerMap.erase(key);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002733 delete dev_data->device_dispatch_table;
2734 layer_data_map.erase(key);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002735}
2736
Courtney Goeltzenleuchterd89520d2015-12-01 14:08:28 -07002737static const VkExtensionProperties instance_extensions[] = {
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06002738 {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002739 VK_EXT_DEBUG_REPORT_EXTENSION_NAME,
2740 VK_EXT_DEBUG_REPORT_REVISION
Courtney Goeltzenleuchter1c7c65d2015-06-10 17:39:03 -06002741 }
Jon Ashburneb2728b2015-04-10 14:33:07 -06002742};
2743
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002744VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceExtensionProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002745 const char *pLayerName,
2746 uint32_t *pCount,
2747 VkExtensionProperties* pProperties)
Jon Ashburneb2728b2015-04-10 14:33:07 -06002748{
Courtney Goeltzenleuchterd89520d2015-12-01 14:08:28 -07002749 return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties);
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002750}
Jon Ashburneb2728b2015-04-10 14:33:07 -06002751
Courtney Goeltzenleuchterd89520d2015-12-01 14:08:28 -07002752static const VkLayerProperties ds_global_layers[] = {
2753 {
2754 "DrawState",
2755 VK_API_VERSION,
2756 VK_MAKE_VERSION(0, 1, 0),
2757 "Validation layer: DrawState",
2758 }
2759};
2760
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002761VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateInstanceLayerProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002762 uint32_t *pCount,
2763 VkLayerProperties* pProperties)
2764{
2765 return util_GetLayerProperties(ARRAY_SIZE(ds_global_layers),
2766 ds_global_layers,
2767 pCount, pProperties);
2768}
Jon Ashburneb2728b2015-04-10 14:33:07 -06002769
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002770static const VkExtensionProperties ds_device_extensions[] = {
2771 {
2772 DEBUG_MARKER_EXTENSION_NAME,
2773 VK_MAKE_VERSION(0, 1, 0),
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002774 }
2775};
2776
2777static const VkLayerProperties ds_device_layers[] = {
2778 {
2779 "DrawState",
2780 VK_API_VERSION,
2781 VK_MAKE_VERSION(0, 1, 0),
2782 "Validation layer: DrawState",
2783 }
2784};
2785
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002786VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002787 VkPhysicalDevice physicalDevice,
2788 const char* pLayerName,
2789 uint32_t* pCount,
2790 VkExtensionProperties* pProperties)
2791{
Tobin Ehlis32479352015-12-01 09:48:58 -07002792 // DrawState does not have any physical device extensions
Jon Ashburnaff81ff2015-11-02 17:37:20 -07002793 if (pLayerName == NULL) {
2794 dispatch_key key = get_dispatch_key(physicalDevice);
2795 layer_data *my_data = get_my_data_ptr(key, layer_data_map);
Tobin Ehlis32479352015-12-01 09:48:58 -07002796 return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(
Jon Ashburnaff81ff2015-11-02 17:37:20 -07002797 physicalDevice,
2798 NULL,
2799 pCount,
2800 pProperties);
2801 } else {
2802 return util_GetExtensionProperties(ARRAY_SIZE(ds_device_extensions),
2803 ds_device_extensions,
2804 pCount, pProperties);
2805 }
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002806}
2807
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002808VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceLayerProperties(
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002809 VkPhysicalDevice physicalDevice,
2810 uint32_t* pCount,
2811 VkLayerProperties* pProperties)
2812{
Tobin Ehlis32479352015-12-01 09:48:58 -07002813 /* DrawState physical device layers are the same as global */
Courtney Goeltzenleuchter73e8bd42015-07-06 22:31:52 -06002814 return util_GetLayerProperties(ARRAY_SIZE(ds_device_layers), ds_device_layers,
2815 pCount, pProperties);
Jon Ashburneb2728b2015-04-10 14:33:07 -06002816}
2817
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07002818VkBool32 ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) {
2819 VkBool32 skip_call = false;
Michael Lentine27b0f902015-10-12 11:30:14 -05002820 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
2821 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
2822 for (auto cb_image_data : pCB->imageLayoutMap) {
2823 auto image_data = dev_data->imageLayoutMap.find(cb_image_data.first);
2824 if (image_data == dev_data->imageLayoutMap.end()) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002825 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentinecbc4a5e2015-11-03 16:19:46 -08002826 "Cannot submit cmd buffer using deleted image %" PRIu64 ".", reinterpret_cast<uint64_t>(cb_image_data.first));
Michael Lentine27b0f902015-10-12 11:30:14 -05002827 } else {
2828 if (dev_data->imageLayoutMap[cb_image_data.first]->layout != cb_image_data.second.initialLayout) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002829 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05002830 "Cannot submit cmd buffer using image with layout %d when first use is %d.", dev_data->imageLayoutMap[cb_image_data.first]->layout, cb_image_data.second.initialLayout);
2831 }
2832 dev_data->imageLayoutMap[cb_image_data.first]->layout = cb_image_data.second.layout;
2833 }
2834 }
2835 return skip_call;
2836}
2837
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002838VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo* pSubmits, VkFence fence)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002839{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002840 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis28be0be2015-05-22 12:38:16 -06002841 GLOBAL_CB_NODE* pCB = NULL;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06002842 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map);
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06002843 for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) {
Chia-I Wu483e7702015-10-26 17:20:32 +08002844 const VkSubmitInfo *submit = &pSubmits[submit_idx];
Chia-I Wu763a7492015-10-26 20:48:51 +08002845 for (uint32_t i=0; i < submit->commandBufferCount; i++) {
Mark Lobodzinski78940a42015-11-30 16:48:53 -07002846
2847#ifndef DISABLE_IMAGE_LAYOUT_VALIDATION
2848 skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]);
2849#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
2850
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06002851 // Validate that cmd buffers have been updated
2852 pCB = getCBNode(dev_data, submit->pCommandBuffers[i]);
2853 loader_platform_thread_lock_mutex(&globalLock);
2854 pCB->submitCount++; // increment submit count
Chia-I Wu1f851912015-10-27 18:04:07 +08002855 if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002856 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05002857 "CB %#" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT set, but has been submitted %#" PRIxLEAST64 " times.",
2858 reinterpret_cast<uint64_t>(pCB->commandBuffer), pCB->submitCount);
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06002859 }
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07002860 if (CB_RECORDED != pCB->state) {
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06002861 // Flag error for using CB w/o vkEndCommandBuffer() called
2862 // TODO : How to pass cb as srcObj?
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07002863 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08002864 "You must call vkEndCommandBuffer() on CB %#" PRIxLEAST64 " before this call to vkQueueSubmit()!", reinterpret_cast<uint64_t>(pCB->commandBuffer));
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06002865 loader_platform_thread_unlock_mutex(&globalLock);
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07002866 return VK_ERROR_VALIDATION_FAILED_EXT;
Courtney Goeltzenleuchter3ec31622015-10-20 18:04:07 -06002867 }
Tobin Ehlise90b1712015-05-27 14:30:06 -06002868 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis28be0be2015-05-22 12:38:16 -06002869 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002870 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06002871 if (VK_FALSE == skipCall)
Chia-I Wu483e7702015-10-26 17:20:32 +08002872 return dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence);
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07002873 return VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002874}
2875
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002876VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06002877{
Chia-I Wu69f40122015-10-26 21:10:41 +08002878 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyFence(device, fence, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002879 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002880}
2881
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002882VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002883{
Chia-I Wu69f40122015-10-26 21:10:41 +08002884 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002885 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002886}
2887
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002888VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002889{
Chia-I Wu69f40122015-10-26 21:10:41 +08002890 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyEvent(device, event, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002891 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002892}
2893
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002894VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002895{
Chia-I Wu69f40122015-10-26 21:10:41 +08002896 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002897 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002898}
2899
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002900VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002901{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002902 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002903 dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002904 dev_data->bufferMap.erase(buffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002905}
2906
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002907VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002908{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002909 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002910 dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002911 dev_data->bufferViewMap.erase(bufferView);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002912}
2913
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002914VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002915{
Tobin Ehlisb46be812015-10-23 16:00:08 -06002916 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08002917 dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator);
Chia-I Wue420a332015-10-26 20:04:44 +08002918 dev_data->imageMap.erase(image);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002919}
2920
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002921VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002922{
Chia-I Wu69f40122015-10-26 21:10:41 +08002923 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyImageView(device, imageView, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002924 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002925}
2926
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002927VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002928{
Chia-I Wu69f40122015-10-26 21:10:41 +08002929 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002930 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002931}
2932
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002933VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002934{
Chia-I Wu69f40122015-10-26 21:10:41 +08002935 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002936 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002937}
2938
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002939VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002940{
Chia-I Wu69f40122015-10-26 21:10:41 +08002941 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002942 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002943}
2944
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002945VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002946{
Chia-I Wu69f40122015-10-26 21:10:41 +08002947 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002948 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002949}
2950
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002951VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002952{
Chia-I Wu69f40122015-10-26 21:10:41 +08002953 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002954 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002955}
2956
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002957VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002958{
Chia-I Wu69f40122015-10-26 21:10:41 +08002959 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002960 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002961}
2962
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08002963VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t count, const VkCommandBuffer *pCommandBuffers)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06002964{
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002965 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2966
Courtney Goeltzenleuchter740451a2015-12-16 16:06:06 -07002967 for (uint32_t i = 0; i < count; i++) {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002968 // Delete CB information structure, and remove from commandBufferMap
2969 auto cb = dev_data->commandBufferMap.find(pCommandBuffers[i]);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002970 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002971 if (cb != dev_data->commandBufferMap.end()) {
2972 delete (*cb).second;
2973 dev_data->commandBufferMap.erase(cb);
2974 }
2975
2976 // Remove commandBuffer reference from commandPoolMap
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07002977 dev_data->commandPoolMap[commandPool].commandBuffers.remove(pCommandBuffers[i]);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002978 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002979 }
2980
2981 dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, count, pCommandBuffers);
2982}
2983
2984VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkCommandPool* pCommandPool)
2985{
2986 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
2987
2988 VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool);
2989
2990 if (VK_SUCCESS == result) {
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002991 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07002992 dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags;
Mark Lobodzinski13b66742015-11-20 14:33:48 -07002993 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07002994 }
2995 return result;
2996}
2997
2998VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks* pAllocator)
2999{
3000 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07003001 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003002
3003 // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap
3004 if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) {
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003005 for (auto poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); poolCb != dev_data->commandPoolMap[commandPool].commandBuffers.end();) {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003006 auto del_cb = dev_data->commandBufferMap.find(*poolCb);
3007 delete (*del_cb).second; // delete CB info structure
3008 dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer from cbMap
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003009 poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.erase(poolCb); // Remove CB reference from commandPoolMap's list
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003010 }
3011 }
3012 dev_data->commandPoolMap.erase(commandPool);
Mark Lobodzinski13b66742015-11-20 14:33:48 -07003013
3014 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003015 dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003016}
3017
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003018VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetCommandPool(
3019 VkDevice device,
3020 VkCommandPool commandPool,
3021 VkCommandPoolResetFlags flags)
3022{
3023 layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003024 VkResult result = VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003025
3026 result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags);
3027 // Reset all of the CBs allocated from this pool
3028 if (VK_SUCCESS == result) {
3029 auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin();
3030 while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) {
3031 resetCB(dev_data, (*it));
3032 ++it;
3033 }
3034 }
3035 return result;
3036}
3037
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003038VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003039{
Chia-I Wu69f40122015-10-26 21:10:41 +08003040 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003041 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003042}
3043
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003044VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks* pAllocator)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003045{
Chia-I Wu69f40122015-10-26 21:10:41 +08003046 get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003047 // TODO : Clean up any internal data structures using this obj.
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003048}
3049
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003050VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBuffer(VkDevice device, const VkBufferCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkBuffer* pBuffer)
Tobin Ehlisb46be812015-10-23 16:00:08 -06003051{
3052 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003053 VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer);
Tobin Ehlisb46be812015-10-23 16:00:08 -06003054 if (VK_SUCCESS == result) {
3055 loader_platform_thread_lock_mutex(&globalLock);
3056 // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid
Chia-I Wue420a332015-10-26 20:04:44 +08003057 dev_data->bufferMap[*pBuffer] = unique_ptr<VkBufferCreateInfo>(new VkBufferCreateInfo(*pCreateInfo));
Tobin Ehlisb46be812015-10-23 16:00:08 -06003058 loader_platform_thread_unlock_mutex(&globalLock);
3059 }
3060 return result;
3061}
3062
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003063VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBufferView(VkDevice device, const VkBufferViewCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkBufferView* pView)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003064{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003065 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003066 VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003067 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003068 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08003069 dev_data->bufferViewMap[*pView] = unique_ptr<VkBufferViewCreateInfo>(new VkBufferViewCreateInfo(*pCreateInfo));
Tobin Ehlisb46be812015-10-23 16:00:08 -06003070 loader_platform_thread_unlock_mutex(&globalLock);
3071 }
3072 return result;
3073}
3074
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003075VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImage(VkDevice device, const VkImageCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkImage* pImage)
Tobin Ehlisb46be812015-10-23 16:00:08 -06003076{
3077 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003078 VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage);
Tobin Ehlisb46be812015-10-23 16:00:08 -06003079 if (VK_SUCCESS == result) {
Michael Lentine27b0f902015-10-12 11:30:14 -05003080 IMAGE_NODE* image_node = new IMAGE_NODE;
3081 image_node->layout = pCreateInfo->initialLayout;
Tobin Ehlisb46be812015-10-23 16:00:08 -06003082 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08003083 dev_data->imageMap[*pImage] = unique_ptr<VkImageCreateInfo>(new VkImageCreateInfo(*pCreateInfo));
Michael Lentine27b0f902015-10-12 11:30:14 -05003084 dev_data->imageLayoutMap[*pImage] = image_node;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003085 loader_platform_thread_unlock_mutex(&globalLock);
3086 }
3087 return result;
3088}
3089
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003090VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImageView(VkDevice device, const VkImageViewCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkImageView* pView)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003091{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003092 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003093 VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003094 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003095 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08003096 dev_data->imageViewMap[*pView] = unique_ptr<VkImageViewCreateInfo>(new VkImageViewCreateInfo(*pCreateInfo));
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06003097 loader_platform_thread_unlock_mutex(&globalLock);
3098 }
3099 return result;
3100}
3101
Jon Ashburn0d60d272015-07-09 15:02:25 -06003102//TODO handle pipeline caches
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003103VKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineCache(
Jon Ashburn0d60d272015-07-09 15:02:25 -06003104 VkDevice device,
3105 const VkPipelineCacheCreateInfo* pCreateInfo,
Chia-I Wu1f851912015-10-27 18:04:07 +08003106 const VkAllocationCallbacks* pAllocator,
Jon Ashburn0d60d272015-07-09 15:02:25 -06003107 VkPipelineCache* pPipelineCache)
3108{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003109 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003110 VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache);
Jon Ashburn0d60d272015-07-09 15:02:25 -06003111 return result;
3112}
3113
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003114VKAPI_ATTR void VKAPI_CALL vkDestroyPipelineCache(
Jon Ashburn0d60d272015-07-09 15:02:25 -06003115 VkDevice device,
Chia-I Wu69f40122015-10-26 21:10:41 +08003116 VkPipelineCache pipelineCache,
Chia-I Wu1f851912015-10-27 18:04:07 +08003117 const VkAllocationCallbacks* pAllocator)
Jon Ashburn0d60d272015-07-09 15:02:25 -06003118{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003119 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003120 dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator);
Jon Ashburn0d60d272015-07-09 15:02:25 -06003121}
3122
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003123VKAPI_ATTR VkResult VKAPI_CALL vkGetPipelineCacheData(
Jon Ashburn0d60d272015-07-09 15:02:25 -06003124 VkDevice device,
3125 VkPipelineCache pipelineCache,
Chia-I Wu28c3c432015-10-26 19:17:06 +08003126 size_t* pDataSize,
Jon Ashburn0d60d272015-07-09 15:02:25 -06003127 void* pData)
3128{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003129 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu28c3c432015-10-26 19:17:06 +08003130 VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData);
Jon Ashburn0d60d272015-07-09 15:02:25 -06003131 return result;
3132}
3133
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003134VKAPI_ATTR VkResult VKAPI_CALL vkMergePipelineCaches(
Jon Ashburn0d60d272015-07-09 15:02:25 -06003135 VkDevice device,
Chia-I Wu1f851912015-10-27 18:04:07 +08003136 VkPipelineCache dstCache,
Jon Ashburn0d60d272015-07-09 15:02:25 -06003137 uint32_t srcCacheCount,
3138 const VkPipelineCache* pSrcCaches)
3139{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003140 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu1f851912015-10-27 18:04:07 +08003141 VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches);
Jon Ashburn0d60d272015-07-09 15:02:25 -06003142 return result;
3143}
3144
Mark Lobodzinski2adea752015-11-10 15:25:01 -07003145VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateGraphicsPipelines(
3146 VkDevice device,
3147 VkPipelineCache pipelineCache,
3148 uint32_t count,
3149 const VkGraphicsPipelineCreateInfo *pCreateInfos,
3150 const VkAllocationCallbacks *pAllocator,
3151 VkPipeline *pPipelines)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003152{
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06003153 VkResult result = VK_SUCCESS;
Tobin Ehlise48be202015-09-16 10:33:53 -06003154 //TODO What to do with pipelineCache?
Tobin Ehlisde63c532015-06-18 15:59:33 -06003155 // The order of operations here is a little convoluted but gets the job done
3156 // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct
3157 // 2. Create state is then validated (which uses flags setup during shadowing)
3158 // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap
Tobin Ehlise48be202015-09-16 10:33:53 -06003159 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis76c18852015-09-17 16:33:58 -06003160 // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic
3161 vector<PIPELINE_NODE*> pPipeNode(count);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003162 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinski2adea752015-11-10 15:25:01 -07003163
Tobin Ehlise48be202015-09-16 10:33:53 -06003164 uint32_t i=0;
Tobin Ehlisde63c532015-06-18 15:59:33 -06003165 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinski2adea752015-11-10 15:25:01 -07003166
Tobin Ehlise48be202015-09-16 10:33:53 -06003167 for (i=0; i<count; i++) {
Mark Lobodzinski2adea752015-11-10 15:25:01 -07003168 pPipeNode[i] = initGraphicsPipeline(dev_data, &pCreateInfos[i], NULL);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003169 skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]);
Tobin Ehlise48be202015-09-16 10:33:53 -06003170 }
Mark Lobodzinski2adea752015-11-10 15:25:01 -07003171
Tobin Ehlisde63c532015-06-18 15:59:33 -06003172 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis32479352015-12-01 09:48:58 -07003173
Tobin Ehlisad61de42015-12-02 13:53:34 -07003174 if (VK_FALSE == skipCall) {
Mark Lobodzinski2adea752015-11-10 15:25:01 -07003175 result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device,
3176 pipelineCache, count, pCreateInfos, pAllocator, pPipelines);
Tobin Ehlisde63c532015-06-18 15:59:33 -06003177 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlise48be202015-09-16 10:33:53 -06003178 for (i=0; i<count; i++) {
3179 pPipeNode[i]->pipeline = pPipelines[i];
Chia-I Wue420a332015-10-26 20:04:44 +08003180 dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i];
Tobin Ehlise48be202015-09-16 10:33:53 -06003181 }
Tobin Ehlisde63c532015-06-18 15:59:33 -06003182 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003183 } else {
Tobin Ehlise48be202015-09-16 10:33:53 -06003184 for (i=0; i<count; i++) {
3185 if (pPipeNode[i]) {
3186 // If we allocated a pipeNode, need to clean it up here
3187 delete[] pPipeNode[i]->pVertexBindingDescriptions;
3188 delete[] pPipeNode[i]->pVertexAttributeDescriptions;
3189 delete[] pPipeNode[i]->pAttachments;
3190 delete pPipeNode[i];
3191 }
Tobin Ehlisde63c532015-06-18 15:59:33 -06003192 }
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003193 return VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlisde63c532015-06-18 15:59:33 -06003194 }
Courtney Goeltzenleuchter9452ac22015-04-13 16:16:04 -06003195 return result;
3196}
3197
Mark Lobodzinski2adea752015-11-10 15:25:01 -07003198VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateComputePipelines(
3199 VkDevice device,
3200 VkPipelineCache pipelineCache,
3201 uint32_t count,
3202 const VkComputePipelineCreateInfo *pCreateInfos,
3203 const VkAllocationCallbacks *pAllocator,
3204 VkPipeline *pPipelines)
3205{
3206 VkResult result = VK_SUCCESS;
3207 VkBool32 skipCall = VK_FALSE;
3208
3209 // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic
3210 vector<PIPELINE_NODE*> pPipeNode(count);
3211 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
3212
3213 uint32_t i=0;
3214 loader_platform_thread_lock_mutex(&globalLock);
3215 for (i=0; i<count; i++) {
3216 // TODO: Verify compute stage bits
3217
3218 // Create and initialize internal tracking data structure
3219 pPipeNode[i] = new PIPELINE_NODE;
3220 memset((void*)pPipeNode[i], 0, sizeof(PIPELINE_NODE));
3221 memcpy(&pPipeNode[i]->computePipelineCI, (const void*)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo));
3222
3223 // TODO: Add Compute Pipeline Verification
3224 // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]);
3225 }
3226 loader_platform_thread_unlock_mutex(&globalLock);
3227
3228 if (VK_FALSE == skipCall) {
3229 result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines);
3230 loader_platform_thread_lock_mutex(&globalLock);
3231 for (i=0; i<count; i++) {
3232 pPipeNode[i]->pipeline = pPipelines[i];
3233 dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i];
3234 }
3235 loader_platform_thread_unlock_mutex(&globalLock);
3236 } else {
3237 for (i=0; i<count; i++) {
3238 if (pPipeNode[i]) {
3239 // Clean up any locally allocated data structures
3240 delete pPipeNode[i];
3241 }
3242 }
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003243 return VK_ERROR_VALIDATION_FAILED_EXT;
Mark Lobodzinski2adea752015-11-10 15:25:01 -07003244 }
3245 return result;
3246}
3247
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003248VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSampler(VkDevice device, const VkSamplerCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkSampler* pSampler)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003249{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003250 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003251 VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003252 if (VK_SUCCESS == result) {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003253 loader_platform_thread_lock_mutex(&globalLock);
Chia-I Wue420a332015-10-26 20:04:44 +08003254 dev_data->sampleMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003255 loader_platform_thread_unlock_mutex(&globalLock);
3256 }
3257 return result;
3258}
3259
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003260VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDescriptorSetLayout* pSetLayout)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003261{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003262 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003263 VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003264 if (VK_SUCCESS == result) {
Tobin Ehliscb085292015-12-01 09:57:09 -07003265 // TODOSC : Capture layout bindings set
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003266 LAYOUT_NODE* pNewNode = new LAYOUT_NODE;
3267 if (NULL == pNewNode) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003268 if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t) *pSetLayout, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003269 "Out of memory while attempting to allocate LAYOUT_NODE in vkCreateDescriptorSetLayout()"))
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003270 return VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003271 }
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06003272 memcpy((void*)&pNewNode->createInfo, pCreateInfo, sizeof(VkDescriptorSetLayoutCreateInfo));
Chia-I Wuf03cbf72015-10-31 00:31:16 +08003273 pNewNode->createInfo.pBinding = new VkDescriptorSetLayoutBinding[pCreateInfo->bindingCount];
3274 memcpy((void*)pNewNode->createInfo.pBinding, pCreateInfo->pBinding, sizeof(VkDescriptorSetLayoutBinding)*pCreateInfo->bindingCount);
Chia-I Wub5689ee2015-10-31 00:31:16 +08003275 // g++ does not like reserve with size 0
3276 if (pCreateInfo->bindingCount)
3277 pNewNode->bindings.reserve(pCreateInfo->bindingCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003278 uint32_t totalCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08003279 for (uint32_t i=0; i<pCreateInfo->bindingCount; i++) {
Chia-I Wub5689ee2015-10-31 00:31:16 +08003280 if (!pNewNode->bindings.insert(pCreateInfo->pBinding[i].binding).second) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003281 if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t) *pSetLayout, 0, DRAWSTATE_INVALID_LAYOUT, "DS",
Chia-I Wub5689ee2015-10-31 00:31:16 +08003282 "duplicated binding number in VkDescriptorSetLayoutBinding"))
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003283 return VK_ERROR_VALIDATION_FAILED_EXT;
Chia-I Wub5689ee2015-10-31 00:31:16 +08003284 }
3285
Chia-I Wu045654f2015-11-06 06:42:02 +08003286 totalCount += pCreateInfo->pBinding[i].descriptorCount;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08003287 if (pCreateInfo->pBinding[i].pImmutableSamplers) {
3288 VkSampler** ppIS = (VkSampler**)&pNewNode->createInfo.pBinding[i].pImmutableSamplers;
Chia-I Wu045654f2015-11-06 06:42:02 +08003289 *ppIS = new VkSampler[pCreateInfo->pBinding[i].descriptorCount];
3290 memcpy(*ppIS, pCreateInfo->pBinding[i].pImmutableSamplers, pCreateInfo->pBinding[i].descriptorCount*sizeof(VkSampler));
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06003291 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003292 }
3293 if (totalCount > 0) {
Cody Northrop8a908322015-10-26 14:07:35 -06003294 pNewNode->descriptorTypes.resize(totalCount);
Tobin Ehlis68fbd442015-10-27 12:25:35 -06003295 pNewNode->stageFlags.resize(totalCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003296 uint32_t offset = 0;
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06003297 uint32_t j = 0;
Tobin Ehlis61ebb312015-11-04 12:28:28 -07003298 VkDescriptorType dType;
Chia-I Wu763a7492015-10-26 20:48:51 +08003299 for (uint32_t i=0; i<pCreateInfo->bindingCount; i++) {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07003300 dType = pCreateInfo->pBinding[i].descriptorType;
Chia-I Wu045654f2015-11-06 06:42:02 +08003301 for (j = 0; j < pCreateInfo->pBinding[i].descriptorCount; j++) {
Tobin Ehlis61ebb312015-11-04 12:28:28 -07003302 pNewNode->descriptorTypes[offset + j] = dType;
Chia-I Wuf03cbf72015-10-31 00:31:16 +08003303 pNewNode->stageFlags[offset + j] = pCreateInfo->pBinding[i].stageFlags;
Tobin Ehlis61ebb312015-11-04 12:28:28 -07003304 if ((dType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) ||
3305 (dType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) {
3306 pNewNode->dynamicDescriptorCount++;
3307 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003308 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06003309 offset += j;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003310 }
3311 }
3312 pNewNode->layout = *pSetLayout;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003313 pNewNode->startIndex = 0;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003314 pNewNode->endIndex = pNewNode->startIndex + totalCount - 1;
3315 assert(pNewNode->endIndex >= pNewNode->startIndex);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003316 // Put new node at Head of global Layer list
3317 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlisad61de42015-12-02 13:53:34 -07003318 dev_data->descriptorSetLayoutMap[*pSetLayout] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003319 loader_platform_thread_unlock_mutex(&globalLock);
3320 }
3321 return result;
3322}
3323
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003324VKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkPipelineLayout* pPipelineLayout)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003325{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003326 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003327 VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003328 if (VK_SUCCESS == result) {
Tobin Ehliscb085292015-12-01 09:57:09 -07003329 // TODOSC : Merge capture of the setLayouts per pipeline
Tobin Ehlis982099b2015-11-05 09:52:49 -07003330 PIPELINE_LAYOUT_NODE& plNode = dev_data->pipelineLayoutMap[*pPipelineLayout];
Chia-I Wu763a7492015-10-26 20:48:51 +08003331 plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount);
Tobin Ehlis91423d22015-10-20 10:11:55 -06003332 uint32_t i = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08003333 for (i=0; i<pCreateInfo->setLayoutCount; ++i) {
Tobin Ehlis91423d22015-10-20 10:11:55 -06003334 plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i];
3335 }
Cody Northrop8a908322015-10-26 14:07:35 -06003336 plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount);
Tobin Ehlis91423d22015-10-20 10:11:55 -06003337 for (i=0; i<pCreateInfo->pushConstantRangeCount; ++i) {
3338 plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i];
3339 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06003340 }
3341 return result;
3342}
3343
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003344VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkDescriptorPool* pDescriptorPool)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003345{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003346 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08003347 VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003348 if (VK_SUCCESS == result) {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06003349 // Insert this pool into Global Pool LL at head
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003350 if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, (uint64_t) *pDescriptorPool, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08003351 "Created Descriptor Pool %#" PRIxLEAST64, (uint64_t) *pDescriptorPool))
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003352 return VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003353 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003354 DESCRIPTOR_POOL_NODE* pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003355 if (NULL == pNewNode) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003356 if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, (uint64_t) *pDescriptorPool, 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003357 "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()"))
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003358 return VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003359 } else {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003360 dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003361 }
3362 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003363 } else {
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06003364 // Need to do anything if pool create fails?
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003365 }
3366 return result;
3367}
3368
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003369VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003370{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003371 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06003372 VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003373 if (VK_SUCCESS == result) {
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06003374 clearDescriptorPool(dev_data, device, descriptorPool, flags);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003375 }
3376 return result;
3377}
3378
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003379VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo* pAllocateInfo, VkDescriptorSet* pDescriptorSets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003380{
Tobin Ehlisc6457d22015-10-20 16:16:04 -06003381 VkBool32 skipCall = VK_FALSE;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003382 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06003383 // Verify that requested descriptorSets are available in pool
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003384 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06003385 if (!pPoolNode) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003386 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, (uint64_t) pAllocateInfo->descriptorPool, 0, DRAWSTATE_INVALID_POOL, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08003387 "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06003388 } else { // Make sure pool has all the available descriptors before calling down chain
Chia-I Wu1f851912015-10-27 18:04:07 +08003389 skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->setLayoutCount, pAllocateInfo->pSetLayouts);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06003390 }
3391 if (skipCall)
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003392 return VK_ERROR_VALIDATION_FAILED_EXT;
Chia-I Wu1f851912015-10-27 18:04:07 +08003393 VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets);
Cody Northropc8aa4a52015-08-03 12:47:29 -06003394 if (VK_SUCCESS == result) {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003395 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06003396 if (pPoolNode) {
Chia-I Wu1f851912015-10-27 18:04:07 +08003397 if (pAllocateInfo->setLayoutCount == 0) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003398 log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, pAllocateInfo->setLayoutCount, 0, DRAWSTATE_NONE, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08003399 "AllocateDescriptorSets called with 0 count");
Cody Northropc8aa4a52015-08-03 12:47:29 -06003400 }
Chia-I Wu1f851912015-10-27 18:04:07 +08003401 for (uint32_t i = 0; i < pAllocateInfo->setLayoutCount; i++) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003402 log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
Chia-I Wue420a332015-10-26 20:04:44 +08003403 "Created Descriptor Set %#" PRIxLEAST64, (uint64_t) pDescriptorSets[i]);
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06003404 // Create new set node and add to head of pool nodes
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003405 SET_NODE* pNewNode = new SET_NODE;
3406 if (NULL == pNewNode) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003407 if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_OUT_OF_MEMORY, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08003408 "Out of memory while attempting to allocate SET_NODE in vkAllocateDescriptorSets()"))
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003409 return VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003410 } else {
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003411 memset(pNewNode, 0, sizeof(SET_NODE));
Tobin Ehlisf6e93e02015-10-19 12:09:13 -06003412 // TODO : Pool should store a total count of each type of Descriptor available
3413 // When descriptors are allocated, decrement the count and validate here
3414 // that the count doesn't go below 0. One reset/free need to bump count back up.
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06003415 // Insert set at head of Set LL for this pool
3416 pNewNode->pNext = pPoolNode->pSets;
3417 pPoolNode->pSets = pNewNode;
Chia-I Wu1f851912015-10-27 18:04:07 +08003418 LAYOUT_NODE* pLayout = getLayoutNode(dev_data, pAllocateInfo->pSetLayouts[i]);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003419 if (NULL == pLayout) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003420 if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t) pAllocateInfo->pSetLayouts[i], 0, DRAWSTATE_INVALID_LAYOUT, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08003421 "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", (uint64_t) pAllocateInfo->pSetLayouts[i]))
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003422 return VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003423 }
Tobin Ehlisdd82f6b2015-04-03 12:01:11 -06003424 pNewNode->pLayout = pLayout;
Chia-I Wu1f851912015-10-27 18:04:07 +08003425 pNewNode->pool = pAllocateInfo->descriptorPool;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003426 pNewNode->set = pDescriptorSets[i];
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003427 pNewNode->descriptorCount = pLayout->endIndex + 1;
3428 if (pNewNode->descriptorCount) {
3429 size_t descriptorArraySize = sizeof(GENERIC_HEADER*)*pNewNode->descriptorCount;
3430 pNewNode->ppDescriptors = new GENERIC_HEADER*[descriptorArraySize];
3431 memset(pNewNode->ppDescriptors, 0, descriptorArraySize);
3432 }
Chia-I Wue420a332015-10-26 20:04:44 +08003433 dev_data->setMap[pDescriptorSets[i]] = pNewNode;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003434 }
3435 }
3436 }
3437 }
3438 return result;
3439}
3440
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003441VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet* pDescriptorSets)
Tony Barbourb857d312015-07-10 10:50:45 -06003442{
Tobin Ehlis3c543112015-10-08 13:13:50 -06003443 VkBool32 skipCall = VK_FALSE;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003444 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003445 DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool);
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06003446 if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) {
3447 // Can't Free from a NON_FREE pool
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003448 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, (uint64_t)device, 0, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS",
Courtney Goeltzenleuchter831c1832015-10-23 14:21:05 -06003449 "It is invalid to call vkFreeDescriptorSets() with a pool created without setting VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT.");
Tobin Ehlis3c543112015-10-08 13:13:50 -06003450 }
3451 if (skipCall)
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003452 return VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003453 VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets);
Tobin Ehlisc6457d22015-10-20 16:16:04 -06003454 if (VK_SUCCESS == result) {
3455 // For each freed descriptor add it back into the pool as available
3456 for (uint32_t i=0; i<count; ++i) {
Chia-I Wue420a332015-10-26 20:04:44 +08003457 SET_NODE* pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking
Tobin Ehlisc6457d22015-10-20 16:16:04 -06003458 LAYOUT_NODE* pLayout = pSet->pLayout;
Chia-I Wuc51b1212015-10-27 19:25:11 +08003459 uint32_t typeIndex = 0, poolSizeCount = 0;
Chia-I Wu763a7492015-10-26 20:48:51 +08003460 for (uint32_t j=0; j<pLayout->createInfo.bindingCount; ++j) {
Chia-I Wuf03cbf72015-10-31 00:31:16 +08003461 typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBinding[j].descriptorType);
Chia-I Wu045654f2015-11-06 06:42:02 +08003462 poolSizeCount = pLayout->createInfo.pBinding[j].descriptorCount;
Chia-I Wuc51b1212015-10-27 19:25:11 +08003463 pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount;
Tobin Ehlisc6457d22015-10-20 16:16:04 -06003464 }
3465 }
3466 }
3467 // TODO : Any other clean-up or book-keeping to do here?
Tony Barbourb857d312015-07-10 10:50:45 -06003468 return result;
3469}
3470
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003471VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pDescriptorWrites, uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pDescriptorCopies)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003472{
Tobin Ehlis68fbd442015-10-27 12:25:35 -06003473 // dsUpdate will return VK_TRUE only if a bailout error occurs, so we want to call down tree when update returns VK_FALSE
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06003474 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu483e7702015-10-26 17:20:32 +08003475 if (!dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies)) {
3476 dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies);
Jon Ashburne0fa2282015-05-20 09:00:28 -06003477 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003478}
3479
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003480VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo* pCreateInfo, VkCommandBuffer* pCommandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003481{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06003482 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu1f851912015-10-27 18:04:07 +08003483 VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003484 if (VK_SUCCESS == result) {
Courtney Goeltzenleuchter740451a2015-12-16 16:06:06 -07003485 for (uint32_t i = 0; i < pCreateInfo->bufferCount; i++) {
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003486 // Validate command pool
3487 if (dev_data->commandPoolMap.find(pCreateInfo->commandPool) != dev_data->commandPoolMap.end()) {
Mark Lobodzinski13b66742015-11-20 14:33:48 -07003488 loader_platform_thread_lock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003489 // Add command buffer to its commandPool map
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003490 dev_data->commandPoolMap[pCreateInfo->commandPool].commandBuffers.push_back(pCommandBuffer[i]);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003491 GLOBAL_CB_NODE* pCB = new GLOBAL_CB_NODE;
3492 // Add command buffer to map
3493 dev_data->commandBufferMap[pCommandBuffer[i]] = pCB;
Mark Lobodzinski13b66742015-11-20 14:33:48 -07003494 loader_platform_thread_unlock_mutex(&globalLock);
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003495 resetCB(dev_data, pCommandBuffer[i]);
3496 pCB->commandBuffer = pCommandBuffer[i];
3497 pCB->createInfo = *pCreateInfo;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07003498 }
3499 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003500 }
3501 return result;
3502}
3503
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003504VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo* pBeginInfo)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003505{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003506 VkBool32 skipCall = false;
Chia-I Wu1f851912015-10-27 18:04:07 +08003507 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06003508 // Validate command buffer level
Chia-I Wu1f851912015-10-27 18:04:07 +08003509 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06003510 if (pCB) {
Mark Lobodzinskia1420862015-11-19 13:22:11 -07003511 if (pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) {
Chia-I Wue420a332015-10-26 20:04:44 +08003512 if (pBeginInfo->renderPass || pBeginInfo->framebuffer) {
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06003513 // These should be NULL for a Primary CB
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003514 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS",
Tobin Ehlisc5191da2015-12-16 07:17:23 -07003515 "vkBeginCommandBuffer(): Primary Command Buffer (%p) may not specify framebuffer or renderpass parameters.", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06003516 }
Tobin Ehlisc5191da2015-12-16 07:17:23 -07003517 } else { // Secondary Command Buffer
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003518 // TODO : Add check here from spec "If commandBuffer is a secondary command buffer and either the
3519 // occlusionQueryEnable member of pBeginInfo is VK_FALSE, or the precise occlusion queries feature
3520 // is not enabled, the queryFlags member of pBeginInfo must not contain VK_QUERY_CONTROL_PRECISE_BIT"
Tobin Ehlisc5191da2015-12-16 07:17:23 -07003521 if (!pBeginInfo->renderPass) { // renderpass should NOT be null for an Secondary CB
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003522 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS",
Tobin Ehlisc5191da2015-12-16 07:17:23 -07003523 "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must specify a valid renderpass parameter.", (void*)commandBuffer);
3524 }
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003525 if (!pBeginInfo->framebuffer) { // framebuffer may be null for an Secondary CB, but this affects perf according to spec section on vkBeginCommandBuffer:
3526 // Specifying the exact framebuffer that the secondary command buffer will be executed with may result in better performance at command buffer execution time.
Tobin Ehlisc5191da2015-12-16 07:17:23 -07003527 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS",
3528 "vkBeginCommandBuffer(): Secondary Command Buffers (%p) may perform better if a valid framebuffer parameter is specified.", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06003529 }
3530 }
Tobin Ehlis0cea4082015-08-18 07:10:58 -06003531 pCB->beginInfo = *pBeginInfo;
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003532 if (CB_RECORDING == pCB->state) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003533 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS",
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003534 "vkBeginCommandBuffer(): Cannot call Begin on CB (%#" PRIxLEAST64 ") in the RECORDING state. Must first call vkEndCommandBuffer().", (uint64_t)commandBuffer);
3535 } else if (CB_RECORDED == pCB->state) {
3536 VkCommandPool cmdPool = pCB->createInfo.commandPool;
3537 if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003538 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer,
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003539 0, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS",
3540 "Call to vkBeginCommandBuffer() on command buffer (%#" PRIxLEAST64 ") attempts to implicitly reset cmdBuffer created from command pool (%#" PRIxLEAST64 ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.",
3541 (uint64_t) commandBuffer, (uint64_t) cmdPool);
3542 }
3543 }
Tobin Ehlis0cea4082015-08-18 07:10:58 -06003544 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003545 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08003546 "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB %p!", (void*)commandBuffer);
Mark Lobodzinski90bf5b02015-08-04 16:24:20 -06003547 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003548 if (skipCall) {
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003549 return VK_ERROR_VALIDATION_FAILED_EXT;
Courtney Goeltzenleuchter3abd86e2015-09-04 15:03:52 -06003550 }
Chia-I Wu1f851912015-10-27 18:04:07 +08003551 VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo);
Mark Lobodzinski2ad35592015-11-12 16:14:04 -07003552 if ((VK_SUCCESS == result) && (pCB != NULL)) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003553 if (CB_RECORDED == pCB->state) { resetCB(dev_data, commandBuffer); } pCB->state = CB_RECORDING; }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003554 return result;
3555}
3556
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003557VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEndCommandBuffer(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003558{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003559 VkBool32 skipCall = VK_FALSE;
Courtney Goeltzenleuchtera54b76a2015-09-04 13:39:59 -06003560 VkResult result = VK_SUCCESS;
Chia-I Wu1f851912015-10-27 18:04:07 +08003561 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3562 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003563 if (pCB) {
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003564 if (pCB->state != CB_RECORDING) {
Chia-I Wu1f851912015-10-27 18:04:07 +08003565 skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003566 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003567 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003568 if (VK_FALSE == skipCall) {
Chia-I Wu1f851912015-10-27 18:04:07 +08003569 result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003570 if (VK_SUCCESS == result) {
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003571 pCB->state = CB_RECORDED;
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003572 // Reset CB status flags
3573 pCB->status = 0;
Chia-I Wu1f851912015-10-27 18:04:07 +08003574 printCB(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003575 }
3576 } else {
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003577 result = VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003578 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003579 return result;
3580}
3581
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003582VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003583{
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003584 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003585 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003586 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
3587 VkCommandPool cmdPool = pCB->createInfo.commandPool;
3588 if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07003589 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t) commandBuffer,
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07003590 0, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS",
3591 "Attempt to reset command buffer (%#" PRIxLEAST64 ") created from command pool (%#" PRIxLEAST64 ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.",
3592 (uint64_t) commandBuffer, (uint64_t) cmdPool);
3593 }
3594 if (skipCall)
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07003595 return VK_ERROR_VALIDATION_FAILED_EXT;
Chia-I Wu1f851912015-10-27 18:04:07 +08003596 VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06003597 if (VK_SUCCESS == result) {
Chia-I Wu1f851912015-10-27 18:04:07 +08003598 resetCB(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003599 }
3600 return result;
3601}
3602
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003603VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003604{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003605 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003606 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3607 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003608 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003609 skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()");
3610 if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) {
3611 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, (uint64_t) pipeline,
3612 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
3613 "Incorrectly binding compute pipeline (%#" PRIxLEAST64 ") during active RenderPass (%#" PRIxLEAST64 ")",
3614 (uint64_t) pipeline, (uint64_t) pCB->activeRenderPass);
3615 } else if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) {
3616 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdBindPipeline");
3617 }
3618
3619 PIPELINE_NODE* pPN = getPipeline(dev_data, pipeline);
3620 if (pPN) {
3621 pCB->lastBoundPipeline = pipeline;
3622 loader_platform_thread_lock_mutex(&globalLock);
3623 set_cb_pso_status(pCB, pPN);
3624 loader_platform_thread_unlock_mutex(&globalLock);
3625 skipCall |= validatePipelineState(dev_data, pCB, pipelineBindPoint, pipeline);
Tobin Ehlisa366ca22015-06-19 15:07:05 -06003626 } else {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003627 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT,
3628 (uint64_t) pipeline, 0, DRAWSTATE_INVALID_PIPELINE, "DS",
3629 "Attempt to bind Pipeline %#" PRIxLEAST64 " that doesn't exist!", reinterpret_cast<uint64_t>(pipeline));
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003630 }
3631 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003632 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003633 dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003634}
3635
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003636VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetViewport(
Chia-I Wu1f851912015-10-27 18:04:07 +08003637 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06003638 uint32_t viewportCount,
3639 const VkViewport* pViewports)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003640{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003641 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003642 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3643 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003644 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003645 skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()");
3646 loader_platform_thread_lock_mutex(&globalLock);
3647 pCB->status |= CBSTATUS_VIEWPORT_SET;
3648 pCB->viewports.resize(viewportCount);
3649 memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport));
3650 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlise42007c2015-06-19 13:00:59 -06003651 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003652 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003653 dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, viewportCount, pViewports);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06003654}
3655
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003656VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetScissor(
Chia-I Wu1f851912015-10-27 18:04:07 +08003657 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06003658 uint32_t scissorCount,
3659 const VkRect2D* pScissors)
3660{
3661 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003662 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3663 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06003664 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003665 skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()");
3666 loader_platform_thread_lock_mutex(&globalLock);
3667 pCB->status |= CBSTATUS_SCISSOR_SET;
3668 pCB->scissors.resize(scissorCount);
3669 memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D));
3670 loader_platform_thread_unlock_mutex(&globalLock);
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06003671 }
3672 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003673 dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, scissorCount, pScissors);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003674}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003675
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003676VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003677{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003678 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003679 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3680 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003681 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003682 skipCall |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()");
3683 /* TODO: Do we still need this lock? */
3684 loader_platform_thread_lock_mutex(&globalLock);
3685 pCB->status |= CBSTATUS_LINE_WIDTH_SET;
3686 pCB->lineWidth = lineWidth;
3687 loader_platform_thread_unlock_mutex(&globalLock);
Cody Northropf5bd2252015-08-17 11:10:49 -06003688 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003689 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003690 dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth);
Cody Northropf5bd2252015-08-17 11:10:49 -06003691}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003692
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003693VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetDepthBias(
Chia-I Wu1f851912015-10-27 18:04:07 +08003694 VkCommandBuffer commandBuffer,
Chia-I Wufa950c52015-10-26 19:08:09 +08003695 float depthBiasConstantFactor,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003696 float depthBiasClamp,
Chia-I Wufa950c52015-10-26 19:08:09 +08003697 float depthBiasSlopeFactor)
Cody Northropf5bd2252015-08-17 11:10:49 -06003698{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003699 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003700 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3701 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Cody Northropf5bd2252015-08-17 11:10:49 -06003702 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003703 skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()");
3704 pCB->status |= CBSTATUS_DEPTH_BIAS_SET;
3705 pCB->depthBiasConstantFactor = depthBiasConstantFactor;
3706 pCB->depthBiasClamp = depthBiasClamp;
3707 pCB->depthBiasSlopeFactor = depthBiasSlopeFactor;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003708 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003709 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003710 dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, depthBiasSlopeFactor);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003711}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003712
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003713VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4])
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003714{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003715 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003716 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3717 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003718 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003719 skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()");
3720 pCB->status |= CBSTATUS_BLEND_SET;
3721 memcpy(pCB->blendConstants, blendConstants, 4 * sizeof(float));
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003722 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003723 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003724 dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003725}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003726
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003727VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetDepthBounds(
Chia-I Wu1f851912015-10-27 18:04:07 +08003728 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003729 float minDepthBounds,
3730 float maxDepthBounds)
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003731{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003732 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003733 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3734 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003735 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003736 skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()");
3737 pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET;
3738 pCB->minDepthBounds = minDepthBounds;
3739 pCB->maxDepthBounds = maxDepthBounds;
Cody Northrop2605cb02015-08-18 15:21:16 -06003740 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003741 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003742 dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds);
Cody Northrop2605cb02015-08-18 15:21:16 -06003743}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003744
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003745VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilCompareMask(
Chia-I Wu1f851912015-10-27 18:04:07 +08003746 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003747 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08003748 uint32_t compareMask)
Cody Northrop2605cb02015-08-18 15:21:16 -06003749{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003750 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003751 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3752 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Cody Northrop2605cb02015-08-18 15:21:16 -06003753 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003754 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()");
3755 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
3756 pCB->front.compareMask = compareMask;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003757 }
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003758 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
3759 pCB->back.compareMask = compareMask;
3760 }
3761 /* TODO: Do we need to track front and back separately? */
3762 /* TODO: We aren't capturing the faceMask, do we need to? */
3763 pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003764 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003765 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08003766 dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask);
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06003767}
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003768
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003769VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilWriteMask(
Chia-I Wu1f851912015-10-27 18:04:07 +08003770 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003771 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08003772 uint32_t writeMask)
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003773{
3774 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003775 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3776 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003777 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003778 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()");
3779 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
3780 pCB->front.writeMask = writeMask;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003781 }
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003782 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
3783 pCB->back.writeMask = writeMask;
3784 }
3785 pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003786 }
3787 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08003788 dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003789}
3790
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003791VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetStencilReference(
Chia-I Wu1f851912015-10-27 18:04:07 +08003792 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003793 VkStencilFaceFlags faceMask,
Chia-I Wuc51b1212015-10-27 19:25:11 +08003794 uint32_t reference)
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003795{
3796 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003797 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3798 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003799 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003800 skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()");
3801 if (faceMask & VK_STENCIL_FACE_FRONT_BIT) {
3802 pCB->front.reference = reference;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003803 }
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003804 if (faceMask & VK_STENCIL_FACE_BACK_BIT) {
3805 pCB->back.reference = reference;
3806 }
3807 pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003808 }
3809 if (VK_FALSE == skipCall)
Chia-I Wuc51b1212015-10-27 19:25:11 +08003810 dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference);
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06003811}
3812
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003813VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, uint32_t firstSet, uint32_t setCount, const VkDescriptorSet* pDescriptorSets, uint32_t dynamicOffsetCount, const uint32_t* pDynamicOffsets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003814{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003815 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003816 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3817 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003818 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003819 if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) {
3820 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS",
3821 "Incorrectly binding compute DescriptorSets during active RenderPass (%#" PRIxLEAST64 ")", (uint64_t) pCB->activeRenderPass);
3822 } else if ((VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) && (!pCB->activeRenderPass)) {
3823 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdBindDescriptorSets");
3824 }
3825 skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()");
3826 // Track total count of dynamic descriptor types to make sure we have an offset for each one
3827 uint32_t totalDynamicDescriptors = 0;
3828 string errorString = "";
3829 uint32_t lastSetIndex = firstSet+setCount-1;
3830 if (lastSetIndex >= pCB->boundDescriptorSets.size())
3831 pCB->boundDescriptorSets.resize(lastSetIndex+1);
3832 VkDescriptorSet oldFinalBoundSet = pCB->boundDescriptorSets[lastSetIndex];
3833 for (uint32_t i=0; i<setCount; i++) {
3834 SET_NODE* pSet = getSetNode(dev_data, pDescriptorSets[i]);
3835 if (pSet) {
3836 loader_platform_thread_lock_mutex(&globalLock);
3837 pCB->lastBoundDescriptorSet = pDescriptorSets[i];
3838 pCB->lastBoundPipelineLayout = layout;
3839 pCB->boundDescriptorSets[i+firstSet] = pDescriptorSets[i];
3840 loader_platform_thread_unlock_mutex(&globalLock);
3841 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
3842 "DS %#" PRIxLEAST64 " bound on pipeline %s", (uint64_t) pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint));
3843 if (!pSet->pUpdateStructs) {
3844 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS",
3845 "DS %#" PRIxLEAST64 " bound but it was never updated. You may want to either update it or not bind it.", (uint64_t) pDescriptorSets[i]);
3846 }
3847 // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout
3848 if (!verify_set_layout_compatibility(dev_data, pSet, layout, i+firstSet, errorString)) {
3849 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS",
3850 "descriptorSet #%u being bound is not compatible with overlapping layout in pipelineLayout due to: %s", i, errorString.c_str());
3851 }
3852 totalDynamicDescriptors += pSet->pLayout->dynamicDescriptorCount;
3853 } else {
3854 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pDescriptorSets[i], 0, DRAWSTATE_INVALID_SET, "DS",
3855 "Attempt to bind DS %#" PRIxLEAST64 " that doesn't exist!", (uint64_t) pDescriptorSets[i]);
Mark Lobodzinski611cf592015-12-18 15:35:38 -07003856 }
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003857 // Check if newly last bound set invalidates any remaining bound sets
3858 if ((pCB->boundDescriptorSets.size()-1) > (lastSetIndex)) {
3859 if (oldFinalBoundSet && !verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, errorString)) {
3860 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) oldFinalBoundSet, 0, DRAWSTATE_NONE, "DS",
3861 "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u is incompatible with set %#" PRIxLEAST64 " newly bound as set #%u so set #%u and any subsequent sets were disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) oldFinalBoundSet, lastSetIndex, (uint64_t) pCB->boundDescriptorSets[lastSetIndex], lastSetIndex, lastSetIndex+1, (uint64_t) layout);
Tobin Ehlis982099b2015-11-05 09:52:49 -07003862 pCB->boundDescriptorSets.resize(lastSetIndex+1);
Tobin Ehlis61ebb312015-11-04 12:28:28 -07003863 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003864 }
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003865 // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound
3866 if (totalDynamicDescriptors != dynamicOffsetCount) {
3867 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t) commandBuffer, 0, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS",
3868 "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount is %u. It should exactly match the number of dynamic descriptors.", setCount, totalDynamicDescriptors, dynamicOffsetCount);
3869 }
3870 }
3871 // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update
3872 if (firstSet > 0) { // Check set #s below the first bound set
3873 for (uint32_t i=0; i<firstSet; ++i) {
3874 if (pCB->boundDescriptorSets[i] && !verify_set_layout_compatibility(dev_data, dev_data->setMap[pCB->boundDescriptorSets[i]], layout, i, errorString)) {
3875 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) pCB->boundDescriptorSets[i], 0, DRAWSTATE_NONE, "DS",
3876 "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u was disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) pCB->boundDescriptorSets[i], i, (uint64_t) layout);
3877 pCB->boundDescriptorSets[i] = VK_NULL_HANDLE;
3878 }
3879 }
3880 }
3881 // Check if newly last bound set invalidates any remaining bound sets
3882 if ((pCB->boundDescriptorSets.size()-1) > (lastSetIndex)) {
3883 if (oldFinalBoundSet && !verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, errorString)) {
3884 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t) oldFinalBoundSet, 0, DRAWSTATE_NONE, "DS",
3885 "DescriptorSetDS %#" PRIxLEAST64 " previously bound as set #%u is incompatible with set %#" PRIxLEAST64 " newly bound as set #%u so set #%u and any subsequent sets were disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", (uint64_t) oldFinalBoundSet, lastSetIndex, (uint64_t) pCB->boundDescriptorSets[lastSetIndex], lastSetIndex, lastSetIndex+1, (uint64_t) layout);
3886 pCB->boundDescriptorSets.resize(lastSetIndex+1);
3887 }
3888 }
3889 // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound
3890 if (totalDynamicDescriptors != dynamicOffsetCount) {
3891 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t) commandBuffer, 0, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS",
3892 "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount is %u. It should exactly match the number of dynamic descriptors.", setCount, totalDynamicDescriptors, dynamicOffsetCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003893 }
3894 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003895 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003896 dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, pDescriptorSets, dynamicOffsetCount, pDynamicOffsets);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003897}
3898
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003899VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003900{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003901 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003902 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3903 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003904 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003905 skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()");
3906 VkDeviceSize offset_align = 0;
3907 switch (indexType) {
3908 case VK_INDEX_TYPE_UINT16:
3909 offset_align = 2;
3910 break;
3911 case VK_INDEX_TYPE_UINT32:
3912 offset_align = 4;
3913 break;
3914 default:
3915 // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0
3916 break;
3917 }
3918 if (!offset_align || (offset % offset_align)) {
3919 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS",
3920 "vkCmdBindIndexBuffer() offset (%#" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", offset, string_VkIndexType(indexType));
Tobin Ehlise42007c2015-06-19 13:00:59 -06003921 }
Tobin Ehlis8d199e52015-09-17 12:24:13 -06003922 pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003923 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003924 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003925 dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003926}
3927
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003928VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindVertexBuffers(
Mark Lobodzinski74e84692015-12-14 15:14:10 -07003929 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter46962942015-04-16 13:38:46 -06003930 uint32_t startBinding,
3931 uint32_t bindingCount,
Mark Lobodzinski74e84692015-12-14 15:14:10 -07003932 const VkBuffer *pBuffers,
3933 const VkDeviceSize *pOffsets)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003934{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003935 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003936 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3937 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003938 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003939 addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()");
3940 if ((startBinding + bindingCount) > pCB->boundVtxBuffers.size()) {
3941 pCB->boundVtxBuffers.resize(startBinding+bindingCount, VK_NULL_HANDLE);
3942 }
3943 for (auto i = 0; i < bindingCount; i++) {
3944 pCB->boundVtxBuffers[i+startBinding] = pBuffers[i];
Tobin Ehlis0b551cd2015-05-28 12:10:17 -06003945 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003946 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003947 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003948 dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, startBinding, bindingCount, pBuffers, pOffsets);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003949}
3950
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003951VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, uint32_t firstVertex, uint32_t firstInstance)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003952{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003953 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08003954 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3955 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003956 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003957 skipCall |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()");
3958 pCB->drawCount[DRAW]++;
3959 skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE);
3960 // TODO : Need to pass commandBuffer as srcObj here
3961 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NONE, "DS",
3962 "vkCmdDraw() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW]++);
3963 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003964 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003965 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003966 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003967 dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003968}
3969
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003970VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, uint32_t firstInstance)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003971{
Chia-I Wu1f851912015-10-27 18:04:07 +08003972 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3973 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003974 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003975 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003976 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()");
3977 pCB->drawCount[DRAW_INDEXED]++;
3978 skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE);
3979 // TODO : Need to pass commandBuffer as srcObj here
3980 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NONE, "DS",
3981 "vkCmdDrawIndexed() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++);
3982 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06003983 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed");
Jon Ashburne0fa2282015-05-20 09:00:28 -06003984 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003985 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08003986 dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, firstInstance);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003987}
3988
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08003989VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003990{
Chia-I Wu1f851912015-10-27 18:04:07 +08003991 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
3992 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06003993 VkBool32 skipCall = VK_FALSE;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06003994 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07003995 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()");
3996 pCB->drawCount[DRAW_INDIRECT]++;
3997 skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE);
3998 // TODO : Need to pass commandBuffer as srcObj here
3999 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NONE, "DS",
4000 "vkCmdDrawIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++);
4001 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004002 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect");
Jon Ashburne0fa2282015-05-20 09:00:28 -06004003 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004004 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004005 dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004006}
4007
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004008VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004009{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004010 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004011 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4012 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004013 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004014 skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()");
4015 pCB->drawCount[DRAW_INDEXED_INDIRECT]++;
4016 skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE);
4017 // TODO : Need to pass commandBuffer as srcObj here
4018 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFO_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_NONE, "DS",
4019 "vkCmdDrawIndexedIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED_INDIRECT]++);
4020 skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004021 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect");
Jon Ashburne0fa2282015-05-20 09:00:28 -06004022 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004023 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004024 dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004025}
4026
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004027VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004028{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004029 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004030 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4031 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004032 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004033 skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004034 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004035 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004036 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004037 dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004038}
4039
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004040VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004041{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004042 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004043 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4044 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004045 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004046 skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004047 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004048 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004049 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004050 dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004051}
4052
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004053VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, uint32_t regionCount, const VkBufferCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004054{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004055 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004056 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4057 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004058 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004059 skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER, "vkCmdCopyBuffer()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004060 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004061 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004062 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004063 dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004064}
4065
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004066VkBool32 VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageLayout srcImageLayout) {
4067 VkBool32 skip_call = false;
Mark Lobodzinski78940a42015-11-30 16:48:53 -07004068
4069#ifdef DISABLE_IMAGE_LAYOUT_VALIDATION
4070 // TODO: Fix -- initialLayout may have been set in a previous command buffer
4071 return skip_call;
4072#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
4073
Michael Lentine27b0f902015-10-12 11:30:14 -05004074 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4075 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
4076 auto src_image_element = pCB->imageLayoutMap.find(srcImage);
4077 if (src_image_element == pCB->imageLayoutMap.end()) {
4078 pCB->imageLayoutMap[srcImage].initialLayout = srcImageLayout;
4079 pCB->imageLayoutMap[srcImage].layout = srcImageLayout;
4080 return false;
4081 }
4082 if (src_image_element->second.layout != srcImageLayout) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004083 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004084 "Cannot copy from an image whose source layout is %d and doesn't match the current layout %d.", srcImageLayout, src_image_element->second.layout);
4085 }
4086 if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) {
4087 if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004088 // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning.
4089 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine472af7d2015-10-16 18:08:09 -05004090 "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL.");
Michael Lentine27b0f902015-10-12 11:30:14 -05004091 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004092 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine472af7d2015-10-16 18:08:09 -05004093 "Layout for input image is %d but can only be TRANSFER_SRC_OPTIMAL or GENERAL.", srcImageLayout);
Michael Lentine27b0f902015-10-12 11:30:14 -05004094 }
4095 }
4096 return skip_call;
4097}
4098
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004099VkBool32 VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageLayout destImageLayout) {
4100 VkBool32 skip_call = false;
Mark Lobodzinski78940a42015-11-30 16:48:53 -07004101
4102#ifdef DISABLE_IMAGE_LAYOUT_VALIDATION
4103 // TODO: Fix -- initialLayout may have been set in a previous command buffer
4104 return skip_call;
4105#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
4106
Michael Lentine27b0f902015-10-12 11:30:14 -05004107 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4108 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
4109 auto dest_image_element = pCB->imageLayoutMap.find(destImage);
4110 if (dest_image_element == pCB->imageLayoutMap.end()) {
4111 pCB->imageLayoutMap[destImage].initialLayout = destImageLayout;
4112 pCB->imageLayoutMap[destImage].layout = destImageLayout;
4113 return false;
4114 }
4115 if (dest_image_element->second.layout != destImageLayout) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004116 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004117 "Cannot copy from an image whose dest layout is %d and doesn't match the current layout %d.", destImageLayout, dest_image_element->second.layout);
4118 }
4119 if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) {
4120 if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004121 // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning.
4122 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERF_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004123 "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL.");
4124 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004125 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004126 "Layout for output image is %d but can only be TRANSFER_DST_OPTIMAL or GENERAL.", destImageLayout);
4127 }
4128 }
4129 return skip_call;
4130}
4131
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004132VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004133 VkImage srcImage,
4134 VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08004135 VkImage dstImage,
4136 VkImageLayout dstImageLayout,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004137 uint32_t regionCount, const VkImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004138{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004139 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004140 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4141 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004142 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004143 skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE, "vkCmdCopyImage()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004144 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage");
Michael Lentine27b0f902015-10-12 11:30:14 -05004145 skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, srcImageLayout);
4146 skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, dstImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004147 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004148 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004149 dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004150}
4151
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004152VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBlitImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004153 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08004154 VkImage dstImage, VkImageLayout dstImageLayout,
Mark Lobodzinski20f68592015-05-22 14:43:25 -05004155 uint32_t regionCount, const VkImageBlit* pRegions,
Chia-I Wu3603b082015-10-26 16:49:32 +08004156 VkFilter filter)
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06004157{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004158 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004159 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4160 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06004161 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004162 skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE, "vkCmdBlitImage()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004163 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage");
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06004164 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004165 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004166 dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions, filter);
Courtney Goeltzenleuchter6ff8ebc2015-04-03 14:42:51 -06004167}
4168
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004169VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004170 VkBuffer srcBuffer,
Chia-I Wu1f851912015-10-27 18:04:07 +08004171 VkImage dstImage, VkImageLayout dstImageLayout,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004172 uint32_t regionCount, const VkBufferImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004173{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004174 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004175 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4176 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004177 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004178 skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004179 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage");
Michael Lentine27b0f902015-10-12 11:30:14 -05004180 skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, dstImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004181 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004182 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004183 dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004184}
4185
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004186VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004187 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08004188 VkBuffer dstBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004189 uint32_t regionCount, const VkBufferImageCopy* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004190{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004191 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004192 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4193 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004194 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004195 skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004196 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer");
Michael Lentine27b0f902015-10-12 11:30:14 -05004197 skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, srcImageLayout);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004198 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004199 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004200 dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004201}
4202
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004203VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t* pData)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004204{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004205 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004206 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4207 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004208 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004209 skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004210 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004211 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004212 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004213 dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004214}
4215
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004216VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004217{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004218 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004219 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4220 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004221 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004222 skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER, "vkCmdFillBuffer()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004223 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004224 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004225 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004226 dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004227}
4228
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004229VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearAttachments(
Chia-I Wu1f851912015-10-27 18:04:07 +08004230 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06004231 uint32_t attachmentCount,
4232 const VkClearAttachment* pAttachments,
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06004233 uint32_t rectCount,
Courtney Goeltzenleuchtera12e2912015-10-15 18:22:08 -06004234 const VkClearRect* pRects)
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06004235{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004236 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004237 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4238 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06004239 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004240 skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()");
4241 // Warn if this is issued prior to Draw Cmd and clearing the entire attachment
4242 if (!hasDrawCmd(pCB) &&
4243 (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) &&
4244 (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) {
4245 // TODO : commandBuffer should be srcObj
4246 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS",
4247 "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds."
4248 " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", reinterpret_cast<uint64_t>(commandBuffer));
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06004249 }
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06004250 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments");
4251 }
4252
4253 // Validate that attachment is in reference list of active subpass
4254 if (pCB->activeRenderPass) {
Tobin Ehlisad61de42015-12-02 13:53:34 -07004255 const VkRenderPassCreateInfo *pRPCI = dev_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo;
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06004256 const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass];
4257
4258 for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) {
4259 const VkClearAttachment *attachment = &pAttachments[attachment_idx];
4260 if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) {
4261 VkBool32 found = VK_FALSE;
Chia-I Wu763a7492015-10-26 20:48:51 +08004262 for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) {
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06004263 if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) {
4264 found = VK_TRUE;
4265 break;
4266 }
4267 }
4268 if (VK_FALSE == found) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004269 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Chia-I Wu1f851912015-10-27 18:04:07 +08004270 (uint64_t)commandBuffer, 0, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS",
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06004271 "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d",
4272 attachment->colorAttachment, pCB->activeSubpass);
4273 }
4274 } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) {
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07004275 if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass
Mark Lobodzinskiea1fff22015-11-18 08:58:31 -07004276 (pSD->pDepthStencilAttachment->attachment == VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07004277
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004278 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT,
Mark Lobodzinski1523e3a2015-11-17 15:11:24 -07004279 (uint64_t)commandBuffer, 0, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS",
4280 "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found in active subpass %d",
4281 attachment->colorAttachment,
4282 (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED,
4283 pCB->activeSubpass);
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06004284 }
4285 }
4286 }
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06004287 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004288 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004289 dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects);
Tobin Ehlis8cd650e2015-07-01 16:46:13 -06004290}
4291
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004292VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearColorImage(
Chia-I Wu1f851912015-10-27 18:04:07 +08004293 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchterda4a99e2015-04-23 17:49:22 -06004294 VkImage image, VkImageLayout imageLayout,
Chris Forbese3105972015-06-24 14:34:53 +12004295 const VkClearColorValue *pColor,
Courtney Goeltzenleuchterda4a99e2015-04-23 17:49:22 -06004296 uint32_t rangeCount, const VkImageSubresourceRange* pRanges)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004297{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004298 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004299 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4300 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004301 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004302 skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004303 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004304 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004305 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004306 dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004307}
4308
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004309VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearDepthStencilImage(
Chia-I Wu1f851912015-10-27 18:04:07 +08004310 VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter315ad992015-09-15 18:03:22 -06004311 VkImage image, VkImageLayout imageLayout,
4312 const VkClearDepthStencilValue *pDepthStencil,
4313 uint32_t rangeCount,
4314 const VkImageSubresourceRange* pRanges)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004315{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004316 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004317 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4318 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004319 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004320 skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004321 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004322 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004323 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004324 dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, pRanges);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004325}
4326
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004327VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResolveImage(VkCommandBuffer commandBuffer,
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004328 VkImage srcImage, VkImageLayout srcImageLayout,
Chia-I Wu1f851912015-10-27 18:04:07 +08004329 VkImage dstImage, VkImageLayout dstImageLayout,
Tony Barbour11f74372015-04-13 15:02:52 -06004330 uint32_t regionCount, const VkImageResolve* pRegions)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004331{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004332 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004333 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4334 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004335 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004336 skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE, "vkCmdResolveImage()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004337 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004338 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004339 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004340 dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, pRegions);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004341}
4342
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004343VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004344{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004345 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004346 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4347 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004348 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004349 skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004350 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004351 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004352 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004353 dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004354}
4355
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004356VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004357{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004358 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004359 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4360 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004361 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004362 skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004363 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004364 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004365 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004366 dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004367}
4368
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004369VkBool32 TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const void* const* ppMemBarriers) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004370 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4371 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004372 VkBool32 skip = false;
Mark Lobodzinski78940a42015-11-30 16:48:53 -07004373
4374#ifdef DISABLE_IMAGE_LAYOUT_VALIDATION
4375 // TODO: Fix -- pay attention to image subresource ranges -- not all subresources transition at the same time
4376 return skip;
4377#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
4378
Michael Lentine27b0f902015-10-12 11:30:14 -05004379 for (uint32_t i = 0; i < memBarrierCount; ++i) {
4380 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
4381 if (mem_barrier && mem_barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) {
4382 auto image_mem_barrier = reinterpret_cast<const VkImageMemoryBarrier*>(mem_barrier);
4383 auto image_data = pCB->imageLayoutMap.find(image_mem_barrier->image);
4384 if (image_data == pCB->imageLayoutMap.end()) {
4385 pCB->imageLayoutMap[image_mem_barrier->image].initialLayout = image_mem_barrier->oldLayout;
4386 pCB->imageLayoutMap[image_mem_barrier->image].layout = image_mem_barrier->newLayout;
4387 } else {
4388 if (image_data->second.layout != image_mem_barrier->oldLayout) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004389 skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Courtney Goeltzenleuchter95e6dba2015-11-25 11:38:54 -07004390 "You cannot transition the layout from %d when current layout is %d.", image_mem_barrier->oldLayout, image_data->second.layout);
Michael Lentine27b0f902015-10-12 11:30:14 -05004391 }
4392 image_data->second.layout = image_mem_barrier->newLayout;
4393 }
4394 }
4395 }
4396 return skip;
4397}
4398
Michael Lentine8469dd62015-11-20 09:48:52 -08004399// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set.
4400// If required_bit is zero, accessMask must have at least one of 'optional_bits' set
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004401VkBool32 ValidateMaskBits(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags& accessMask, const VkImageLayout& layout, VkAccessFlags required_bit, VkAccessFlags optional_bits) {
4402 VkBool32 skip_call = false;
Michael Lentine8469dd62015-11-20 09:48:52 -08004403 if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) {
4404 if (accessMask & !(required_bit | optional_bits)) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004405 // TODO: Verify against Valid Use
4406 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Michael Lentine8469dd62015-11-20 09:48:52 -08004407 "Additional bits in accessMask %d are specified when layout is %s.", accessMask, string_VkImageLayout(layout));
Michael Lentine472af7d2015-10-16 18:08:09 -05004408 }
4409 } else {
Michael Lentine8469dd62015-11-20 09:48:52 -08004410 if (!required_bit) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004411 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Michael Lentine8469dd62015-11-20 09:48:52 -08004412 "AccessMask %d must contain at least one of access bits %d when layout is %s.",
4413 accessMask, optional_bits, string_VkImageLayout(layout));
4414 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004415 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Michael Lentine8469dd62015-11-20 09:48:52 -08004416 "AccessMask %d must have required access bit %d and may have optional bits %d when layout is %s.",
4417 accessMask, required_bit, optional_bits,string_VkImageLayout(layout));
4418 }
Michael Lentine472af7d2015-10-16 18:08:09 -05004419 }
4420 return skip_call;
4421}
4422
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004423VkBool32 ValidateMaskBitsFromLayouts(const layer_data* my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags& accessMask, const VkImageLayout& layout) {
4424 VkBool32 skip_call = false;
Michael Lentine8469dd62015-11-20 09:48:52 -08004425 switch (layout) {
4426 case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: {
4427 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, VK_ACCESS_COLOR_ATTACHMENT_READ_BIT);
4428 break;
Michael Lentine472af7d2015-10-16 18:08:09 -05004429 }
Michael Lentine8469dd62015-11-20 09:48:52 -08004430 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: {
4431 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT);
4432 break;
Michael Lentine472af7d2015-10-16 18:08:09 -05004433 }
Michael Lentine8469dd62015-11-20 09:48:52 -08004434 case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: {
4435 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0);
4436 break;
4437 }
4438 case VK_IMAGE_LAYOUT_PREINITIALIZED: {
4439 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0);
4440 break;
4441 }
4442 case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: {
4443 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT);
4444 break;
4445 }
4446 case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: {
4447 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT);
4448 break;
4449 }
4450 case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: {
4451 skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0);
4452 break;
4453 }
4454 case VK_IMAGE_LAYOUT_UNDEFINED: {
4455 if (accessMask != 0) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004456 // TODO: Verify against Valid Use section spec
4457 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Michael Lentine8469dd62015-11-20 09:48:52 -08004458 "Additional bits in accessMask %d are specified when layout is %s.", accessMask, string_VkImageLayout(layout));
4459 }
4460 break;
4461 }
4462 case VK_IMAGE_LAYOUT_GENERAL:
4463 default: {
4464 break;
4465 }
Michael Lentine472af7d2015-10-16 18:08:09 -05004466 }
4467 return skip_call;
4468}
4469
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004470VkBool32 ValidateBarriers(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const void* const* ppMemBarriers) {
4471 VkBool32 skip_call = false;
Michael Lentine07ff1a12015-10-15 17:07:00 -05004472 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4473 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
4474 if (pCB->activeRenderPass && memBarrierCount) {
4475 for (uint32_t i = 0; i < memBarrierCount; ++i) {
4476 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
4477 if (mem_barrier && mem_barrier->sType != VK_STRUCTURE_TYPE_MEMORY_BARRIER) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004478 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Michael Lentine07ff1a12015-10-15 17:07:00 -05004479 "Image or Buffers Barriers cannot be used during a render pass.");
4480 }
4481 }
4482 if (!dev_data->renderPassMap[pCB->activeRenderPass]->hasSelfDependency[pCB->activeSubpass]) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004483 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_BARRIER, "DS",
Michael Lentine07ff1a12015-10-15 17:07:00 -05004484 "Barriers cannot be set during subpass %d with no self dependency specified.", pCB->activeSubpass);
4485 }
4486 }
Mark Lobodzinskib684b512015-11-20 09:27:27 -07004487
Michael Lentine472af7d2015-10-16 18:08:09 -05004488 for (uint32_t i = 0; i < memBarrierCount; ++i) {
4489 auto mem_barrier = reinterpret_cast<const VkMemoryBarrier*>(ppMemBarriers[i]);
4490 if (mem_barrier && mem_barrier->sType == VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER) {
4491 auto image_mem_barrier = reinterpret_cast<const VkImageMemoryBarrier*>(mem_barrier);
Michael Lentine8469dd62015-11-20 09:48:52 -08004492 skip_call |= ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, image_mem_barrier->srcAccessMask, image_mem_barrier->oldLayout);
4493 skip_call |= ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, image_mem_barrier->dstAccessMask, image_mem_barrier->newLayout);
Michael Lentine472af7d2015-10-16 18:08:09 -05004494 }
4495 }
Mark Lobodzinskib95fc092015-12-03 15:42:32 -07004496
Michael Lentine07ff1a12015-10-15 17:07:00 -05004497 return skip_call;
4498}
4499
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004500VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent* pEvents, VkPipelineStageFlags sourceStageMask, VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const void* const* ppMemoryBarriers)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004501{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004502 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004503 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4504 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004505 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004506 skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()");
Michael Lentine27b0f902015-10-12 11:30:14 -05004507 skipCall |= TransitionImageLayouts(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Michael Lentine07ff1a12015-10-15 17:07:00 -05004508 skipCall |= ValidateBarriers(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004509 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004510 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004511 dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004512}
4513
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004514VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const void* const* ppMemoryBarriers)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004515{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004516 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004517 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4518 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004519 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004520 skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()");
Michael Lentine27b0f902015-10-12 11:30:14 -05004521 skipCall |= TransitionImageLayouts(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Michael Lentine07ff1a12015-10-15 17:07:00 -05004522 skipCall |= ValidateBarriers(commandBuffer, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004523 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004524 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004525 dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, memoryBarrierCount, ppMemoryBarriers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004526}
4527
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004528VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004529{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004530 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004531 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4532 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004533 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004534 skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004535 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004536 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004537 dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004538}
4539
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004540VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004541{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004542 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004543 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4544 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004545 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004546 skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY, "vkCmdEndQuery()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004547 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004548 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004549 dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004550}
4551
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004552VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t startQuery, uint32_t queryCount)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004553{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004554 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004555 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4556 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004557 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004558 skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "vkCmdResetQueryPool()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004559 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004560 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004561 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004562 dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, startQuery, queryCount);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004563}
4564
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004565VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t startQuery,
Chia-I Wu1f851912015-10-27 18:04:07 +08004566 uint32_t queryCount, VkBuffer dstBuffer, VkDeviceSize dstOffset,
Chia-I Wu1f6942d2015-10-26 18:36:20 +08004567 VkDeviceSize stride, VkQueryResultFlags flags)
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004568{
4569 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004570 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4571 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004572 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004573 skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()");
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004574 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults");
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004575 }
4576 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004577 dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool,
4578 startQuery, queryCount, dstBuffer, dstOffset, stride, flags);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06004579}
4580
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004581VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004582{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004583 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08004584 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
4585 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004586 if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07004587 skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004588 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06004589 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08004590 dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06004591}
4592
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004593VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkFramebuffer* pFramebuffer)
Tobin Ehlis2464b882015-04-01 08:40:34 -06004594{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06004595 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Chia-I Wu69f40122015-10-26 21:10:41 +08004596 VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004597 if (VK_SUCCESS == result) {
Tobin Ehlis2464b882015-04-01 08:40:34 -06004598 // Shadow create info and store in map
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004599 VkFramebufferCreateInfo* localFBCI = new VkFramebufferCreateInfo(*pCreateInfo);
Chia-I Wuc278df82015-07-07 11:50:03 +08004600 if (pCreateInfo->pAttachments) {
Courtney Goeltzenleuchter1856d6f2015-09-01 17:30:39 -06004601 localFBCI->pAttachments = new VkImageView[localFBCI->attachmentCount];
4602 memcpy((void*)localFBCI->pAttachments, pCreateInfo->pAttachments, localFBCI->attachmentCount*sizeof(VkImageView));
Tobin Ehlis2464b882015-04-01 08:40:34 -06004603 }
Chia-I Wue420a332015-10-26 20:04:44 +08004604 dev_data->frameBufferMap[*pFramebuffer] = localFBCI;
Tobin Ehlis2464b882015-04-01 08:40:34 -06004605 }
4606 return result;
4607}
4608
Michael Lentine329697b2015-10-06 14:56:18 -07004609// Store the DAG.
4610struct DAGNode {
4611 uint32_t pass;
4612 std::vector<uint32_t> prev;
4613 std::vector<uint32_t> next;
4614};
4615
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07004616VkBool32 FindDependency(const int index, const int dependent, const std::vector<DAGNode>& subpass_to_node, std::unordered_set<uint32_t>& processed_nodes) {
Michael Lentine329697b2015-10-06 14:56:18 -07004617 // If we have already checked this node we have not found a dependency path so return false.
4618 if (processed_nodes.count(index))
4619 return false;
4620 processed_nodes.insert(index);
4621 const DAGNode& node = subpass_to_node[index];
4622 // Look for a dependency path. If one exists return true else recurse on the previous nodes.
4623 if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) {
4624 for (auto elem : node.prev) {
4625 if (FindDependency(elem, dependent, subpass_to_node, processed_nodes))
4626 return true;
4627 }
4628 } else {
4629 return true;
4630 }
4631 return false;
4632}
4633
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07004634VkBool32 CheckDependencyExists(const layer_data* my_data, VkDevice device, const int subpass, const std::vector<uint32_t>& dependent_subpasses, const std::vector<DAGNode>& subpass_to_node, VkBool32& skip_call) {
4635 VkBool32 result = true;
Michael Lentine329697b2015-10-06 14:56:18 -07004636 // Loop through all subpasses that share the same attachment and make sure a dependency exists
4637 for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) {
4638 if (subpass == dependent_subpasses[k])
4639 continue;
4640 const DAGNode& node = subpass_to_node[subpass];
4641 // Check for a specified dependency between the two nodes. If one exists we are done.
4642 auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]);
4643 auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]);
4644 if (prev_elem == node.prev.end() && next_elem == node.next.end()) {
4645 // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error.
4646 std::unordered_set<uint32_t> processed_nodes;
4647 if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) ||
4648 FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004649 // TODO: Verify against Valid Use section of spec
4650 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07004651 "A dependency between subpasses %d and %d must exist but only an implicit one is specified.",
4652 subpass, dependent_subpasses[k]);
4653 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004654 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07004655 "A dependency between subpasses %d and %d must exist but one is not specified.",
4656 subpass, dependent_subpasses[k]);
4657 result = false;
4658 }
4659 }
4660 }
4661 return result;
4662}
4663
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07004664VkBool32 CheckPreserved(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, const int index, const int attachment, const std::vector<DAGNode>& subpass_to_node, int depth, VkBool32& skip_call) {
Michael Lentine329697b2015-10-06 14:56:18 -07004665 const DAGNode& node = subpass_to_node[index];
4666 // If this node writes to the attachment return true as next nodes need to preserve the attachment.
4667 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[index];
Chia-I Wu763a7492015-10-26 20:48:51 +08004668 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07004669 if (attachment == subpass.pColorAttachments[j].attachment)
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07004670 return VK_TRUE;
Michael Lentine329697b2015-10-06 14:56:18 -07004671 }
Chia-I Wuce532f72015-10-26 17:32:47 +08004672 if (subpass.pDepthStencilAttachment &&
4673 subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
4674 if (attachment == subpass.pDepthStencilAttachment->attachment)
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07004675 return VK_TRUE;
Michael Lentine329697b2015-10-06 14:56:18 -07004676 }
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07004677 VkBool32 result = VK_FALSE;
Michael Lentine329697b2015-10-06 14:56:18 -07004678 // Loop through previous nodes and see if any of them write to the attachment.
4679 for (auto elem : node.prev) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004680 result |= CheckPreserved(my_data, device, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004681 }
4682 // If the attachment was written to by a previous node than this node needs to preserve it.
4683 if (result && depth > 0) {
4684 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[index];
Courtney Goeltzenleuchterf2bca902015-11-03 15:41:43 -07004685 VkBool32 has_preserved = false;
Chia-I Wu763a7492015-10-26 20:48:51 +08004686 for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07004687 if (subpass.pPreserveAttachments[j].attachment == attachment) {
4688 has_preserved = true;
4689 break;
4690 }
4691 }
4692 if (!has_preserved) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004693 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07004694 "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index);
4695 }
4696 }
4697 return result;
4698}
4699
Michael Lentine27b0f902015-10-12 11:30:14 -05004700VkBool32 ValidateDependencies(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, std::vector<DAGNode>& subpass_to_node) {
4701 VkBool32 skip_call = false;
Michael Lentine329697b2015-10-06 14:56:18 -07004702 std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount);
4703 std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount);
Michael Lentine27b0f902015-10-12 11:30:14 -05004704
Michael Lentine329697b2015-10-06 14:56:18 -07004705 // Create DAG
4706 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4707 DAGNode& subpass_node = subpass_to_node[i];
4708 subpass_node.pass = i;
4709 }
4710 for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) {
4711 const VkSubpassDependency& dependency = pCreateInfo->pDependencies[i];
Chia-I Wu1f851912015-10-27 18:04:07 +08004712 if (dependency.srcSubpass > dependency.dstSubpass) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004713 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine329697b2015-10-06 14:56:18 -07004714 "Dependency graph must be specified such that an earlier pass cannot depend on a later pass.");
4715 }
Chia-I Wu1f851912015-10-27 18:04:07 +08004716 subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass);
4717 subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass);
Michael Lentine329697b2015-10-06 14:56:18 -07004718 }
Michael Lentine27b0f902015-10-12 11:30:14 -05004719
Michael Lentine329697b2015-10-06 14:56:18 -07004720 // Find for each attachment the subpasses that use them.
4721 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4722 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08004723 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07004724 input_attachment_to_subpass[subpass.pInputAttachments[j].attachment].push_back(i);
4725 }
Chia-I Wu763a7492015-10-26 20:48:51 +08004726 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07004727 output_attachment_to_subpass[subpass.pColorAttachments[j].attachment].push_back(i);
4728 }
Chia-I Wuce532f72015-10-26 17:32:47 +08004729 if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
4730 output_attachment_to_subpass[subpass.pDepthStencilAttachment->attachment].push_back(i);
Michael Lentine329697b2015-10-06 14:56:18 -07004731 }
4732 }
4733 // If there is a dependency needed make sure one exists
4734 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4735 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
4736 // If the attachment is an input then all subpasses that output must have a dependency relationship
Chia-I Wu763a7492015-10-26 20:48:51 +08004737 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07004738 const uint32_t& attachment = subpass.pInputAttachments[j].attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004739 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004740 }
4741 // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship
Chia-I Wu763a7492015-10-26 20:48:51 +08004742 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
Michael Lentine329697b2015-10-06 14:56:18 -07004743 const uint32_t& attachment = subpass.pColorAttachments[j].attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004744 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
4745 CheckDependencyExists(my_data, device, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004746 }
Chia-I Wuce532f72015-10-26 17:32:47 +08004747 if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) {
4748 const uint32_t& attachment = subpass.pDepthStencilAttachment->attachment;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004749 CheckDependencyExists(my_data, device, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call);
4750 CheckDependencyExists(my_data, device, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004751 }
4752 }
4753 // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was written.
4754 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4755 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08004756 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004757 CheckPreserved(my_data, device, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call);
Michael Lentine329697b2015-10-06 14:56:18 -07004758 }
4759 }
4760 return skip_call;
4761}
4762
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004763VkBool32 ValidateLayouts(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo) {
4764 VkBool32 skip = false;
Mark Lobodzinski78940a42015-11-30 16:48:53 -07004765
4766#ifdef DISABLE_IMAGE_LAYOUT_VALIDATION
4767 return skip;
4768#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
4769
Michael Lentine27b0f902015-10-12 11:30:14 -05004770 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4771 const VkSubpassDescription& subpass = pCreateInfo->pSubpasses[i];
4772 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
4773 if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL &&
4774 subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) {
4775 if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004776 // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance
4777 skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004778 "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL.");
4779 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004780 skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004781 "Layout for input attachment is %d but can only be READ_ONLY_OPTIMAL or GENERAL.", subpass.pInputAttachments[j].attachment);
4782 }
4783 }
4784 }
4785 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
4786 if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) {
4787 if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004788 // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance
4789 skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004790 "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL.");
4791 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004792 skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004793 "Layout for color attachment is %d but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", subpass.pColorAttachments[j].attachment);
4794 }
4795 }
4796 }
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06004797 if ((subpass.pDepthStencilAttachment != NULL) &&
4798 (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) {
Michael Lentine27b0f902015-10-12 11:30:14 -05004799 if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) {
4800 if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004801 // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance
4802 skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARN_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004803 "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL.");
4804 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004805 skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004806 "Layout for depth attachment is %d but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", subpass.pDepthStencilAttachment->attachment);
4807 }
4808 }
4809 }
4810 }
4811 return skip;
4812}
4813
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004814VkBool32 CreatePassDAG(const layer_data* my_data, VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, std::vector<DAGNode>& subpass_to_node, std::vector<bool>& has_self_dependency) {
4815 VkBool32 skip_call = false;
Michael Lentine27b0f902015-10-12 11:30:14 -05004816 for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) {
4817 DAGNode& subpass_node = subpass_to_node[i];
4818 subpass_node.pass = i;
4819 }
4820 for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) {
4821 const VkSubpassDependency& dependency = pCreateInfo->pDependencies[i];
4822 if (dependency.srcSubpass > dependency.dstSubpass) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004823 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004824 "Depedency graph must be specified such that an earlier pass cannot depend on a later pass.");
Michael Lentine07ff1a12015-10-15 17:07:00 -05004825 } else if (dependency.srcSubpass == dependency.dstSubpass) {
4826 has_self_dependency[dependency.srcSubpass] = true;
Michael Lentine27b0f902015-10-12 11:30:14 -05004827 }
4828 subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass);
4829 subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass);
4830 }
4831 return skip_call;
4832}
Tobin Ehliscb085292015-12-01 09:57:09 -07004833// TODOSC : Add intercept of vkCreateShaderModule
Michael Lentine27b0f902015-10-12 11:30:14 -05004834
Tobin Ehlis32479352015-12-01 09:48:58 -07004835VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateShaderModule(
4836 VkDevice device,
4837 const VkShaderModuleCreateInfo *pCreateInfo,
4838 const VkAllocationCallbacks* pAllocator,
4839 VkShaderModule *pShaderModule)
4840{
4841 layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004842 VkBool32 skip_call = false;
Tobin Ehlis32479352015-12-01 09:48:58 -07004843 if (!shader_is_spirv(pCreateInfo)) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004844 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT,
Tobin Ehlis32479352015-12-01 09:48:58 -07004845 /* dev */ 0, 0, SHADER_CHECKER_NON_SPIRV_SHADER, "SC",
4846 "Shader is not SPIR-V");
4847 }
4848
4849 if (skip_call)
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07004850 return VK_ERROR_VALIDATION_FAILED_EXT;
Tobin Ehlis32479352015-12-01 09:48:58 -07004851
4852 VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule);
4853
4854 if (res == VK_SUCCESS) {
4855 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlisad61de42015-12-02 13:53:34 -07004856 my_data->shaderModuleMap[*pShaderModule] = new shader_module(pCreateInfo);
Tobin Ehlis32479352015-12-01 09:48:58 -07004857 loader_platform_thread_unlock_mutex(&globalLock);
4858 }
4859 return res;
4860}
4861
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08004862VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo* pCreateInfo, const VkAllocationCallbacks* pAllocator, VkRenderPass* pRenderPass)
Tobin Ehlis2464b882015-04-01 08:40:34 -06004863{
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004864 VkBool32 skip_call = false;
Tobin Ehlis42d440c2015-10-20 17:06:16 -06004865 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Michael Lentine27b0f902015-10-12 11:30:14 -05004866 // Create DAG
Michael Lentine07ff1a12015-10-15 17:07:00 -05004867 std::vector<bool> has_self_dependency(pCreateInfo->subpassCount);
Michael Lentine27b0f902015-10-12 11:30:14 -05004868 std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount);
Michael Lentine07ff1a12015-10-15 17:07:00 -05004869 skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency);
Michael Lentine27b0f902015-10-12 11:30:14 -05004870 // Validate using DAG
4871 skip_call |= ValidateDependencies(dev_data, device, pCreateInfo, subpass_to_node);
4872 skip_call |= ValidateLayouts(dev_data, device, pCreateInfo);
4873 if (skip_call) {
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07004874 return VK_ERROR_VALIDATION_FAILED_EXT;
Michael Lentine329697b2015-10-06 14:56:18 -07004875 }
Chia-I Wu69f40122015-10-26 21:10:41 +08004876 VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06004877 if (VK_SUCCESS == result) {
Tobin Ehliscb085292015-12-01 09:57:09 -07004878 // TODOSC : Merge in tracking of renderpass from ShaderChecker
Tobin Ehlis2464b882015-04-01 08:40:34 -06004879 // Shadow create info and store in map
Courtney Goeltzenleuchter382489d2015-04-10 08:34:15 -06004880 VkRenderPassCreateInfo* localRPCI = new VkRenderPassCreateInfo(*pCreateInfo);
Chia-I Wuc278df82015-07-07 11:50:03 +08004881 if (pCreateInfo->pAttachments) {
4882 localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount];
4883 memcpy((void*)localRPCI->pAttachments, pCreateInfo->pAttachments, localRPCI->attachmentCount*sizeof(VkAttachmentDescription));
Tobin Ehlis2464b882015-04-01 08:40:34 -06004884 }
Chia-I Wuc278df82015-07-07 11:50:03 +08004885 if (pCreateInfo->pSubpasses) {
4886 localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount];
4887 memcpy((void*)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount*sizeof(VkSubpassDescription));
4888
4889 for (uint32_t i = 0; i < localRPCI->subpassCount; i++) {
4890 VkSubpassDescription *subpass = (VkSubpassDescription *) &localRPCI->pSubpasses[i];
Chia-I Wu763a7492015-10-26 20:48:51 +08004891 const uint32_t attachmentCount = subpass->inputAttachmentCount +
4892 subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments?1:0)) +
Chia-I Wuce532f72015-10-26 17:32:47 +08004893 ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004894 VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount];
4895
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004896 memcpy(attachments, subpass->pInputAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004897 sizeof(attachments[0]) * subpass->inputAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004898 subpass->pInputAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004899 attachments += subpass->inputAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004900
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004901 memcpy(attachments, subpass->pColorAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004902 sizeof(attachments[0]) * subpass->colorAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004903 subpass->pColorAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004904 attachments += subpass->colorAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004905
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004906 if (subpass->pResolveAttachments) {
4907 memcpy(attachments, subpass->pResolveAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004908 sizeof(attachments[0]) * subpass->colorAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004909 subpass->pResolveAttachments = attachments;
Chia-I Wu763a7492015-10-26 20:48:51 +08004910 attachments += subpass->colorAttachmentCount;
Chia-I Wuc278df82015-07-07 11:50:03 +08004911 }
4912
Chia-I Wuce532f72015-10-26 17:32:47 +08004913 if (subpass->pDepthStencilAttachment) {
4914 memcpy(attachments, subpass->pDepthStencilAttachment,
4915 sizeof(attachments[0]) * 1);
4916 subpass->pDepthStencilAttachment = attachments;
4917 attachments += 1;
4918 }
4919
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004920 memcpy(attachments, subpass->pPreserveAttachments,
Chia-I Wu763a7492015-10-26 20:48:51 +08004921 sizeof(attachments[0]) * subpass->preserveAttachmentCount);
Cody Northrop6de6b0b2015-08-04 11:16:41 -06004922 subpass->pPreserveAttachments = attachments;
Chia-I Wuc278df82015-07-07 11:50:03 +08004923 }
Tobin Ehlis2464b882015-04-01 08:40:34 -06004924 }
Chia-I Wuc278df82015-07-07 11:50:03 +08004925 if (pCreateInfo->pDependencies) {
4926 localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount];
4927 memcpy((void*)localRPCI->pDependencies, pCreateInfo->pDependencies, localRPCI->dependencyCount*sizeof(VkSubpassDependency));
Tobin Ehlis2464b882015-04-01 08:40:34 -06004928 }
Tobin Ehlis32479352015-12-01 09:48:58 -07004929 loader_platform_thread_lock_mutex(&globalLock);
Tobin Ehlisad61de42015-12-02 13:53:34 -07004930 dev_data->renderPassMap[*pRenderPass] = new RENDER_PASS_NODE(localRPCI);
Michael Lentine07ff1a12015-10-15 17:07:00 -05004931 dev_data->renderPassMap[*pRenderPass]->hasSelfDependency = has_self_dependency;
Tobin Ehlis32479352015-12-01 09:48:58 -07004932 loader_platform_thread_unlock_mutex(&globalLock);
Tobin Ehlis2464b882015-04-01 08:40:34 -06004933 }
4934 return result;
4935}
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004936// Free the renderpass shadow
4937static void deleteRenderPasses(layer_data* my_data)
4938{
4939 if (my_data->renderPassMap.size() <= 0)
4940 return;
4941 for (auto ii=my_data->renderPassMap.begin(); ii!=my_data->renderPassMap.end(); ++ii) {
Tobin Ehlisad61de42015-12-02 13:53:34 -07004942 const VkRenderPassCreateInfo* pRenderPassInfo = (*ii).second->pCreateInfo;
Michael Lentine07ff1a12015-10-15 17:07:00 -05004943 if (pRenderPassInfo->pAttachments) {
4944 delete[] pRenderPassInfo->pAttachments;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004945 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004946 if (pRenderPassInfo->pSubpasses) {
4947 for (uint32_t i=0; i<pRenderPassInfo->subpassCount; ++i) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004948 // Attachements are all allocated in a block, so just need to
4949 // find the first non-null one to delete
Michael Lentine07ff1a12015-10-15 17:07:00 -05004950 if (pRenderPassInfo->pSubpasses[i].pInputAttachments) {
4951 delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments;
4952 } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) {
4953 delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments;
4954 } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) {
4955 delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments;
4956 } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) {
4957 delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004958 }
4959 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004960 delete[] pRenderPassInfo->pSubpasses;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004961 }
Michael Lentine07ff1a12015-10-15 17:07:00 -05004962 if (pRenderPassInfo->pDependencies) {
4963 delete[] pRenderPassInfo->pDependencies;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004964 }
Tobin Ehlisad61de42015-12-02 13:53:34 -07004965 delete pRenderPassInfo;
Michael Lentine07ff1a12015-10-15 17:07:00 -05004966 delete (*ii).second;
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06004967 }
4968 my_data->renderPassMap.clear();
4969}
Michael Lentine27b0f902015-10-12 11:30:14 -05004970
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07004971VkBool32 VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin) {
4972 VkBool32 skip_call = false;
Michael Lentine27b0f902015-10-12 11:30:14 -05004973 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4974 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
Tobin Ehlisad61de42015-12-02 13:53:34 -07004975 const VkRenderPassCreateInfo* pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05004976 const VkFramebufferCreateInfo* pFramebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer];
4977 if (pRenderPassInfo->attachmentCount != pFramebufferInfo->attachmentCount) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004978 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004979 "You cannot start a render pass using a framebuffer with a different number of attachments.");
4980 }
4981 for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) {
4982 const VkImageView& image_view = pFramebufferInfo->pAttachments[i];
4983 const VkImage& image = dev_data->imageViewMap[image_view]->image;
4984 auto image_data = pCB->imageLayoutMap.find(image);
4985 if (image_data == pCB->imageLayoutMap.end()) {
4986 pCB->imageLayoutMap[image].initialLayout = pRenderPassInfo->pAttachments[i].initialLayout;
4987 pCB->imageLayoutMap[image].layout = pRenderPassInfo->pAttachments[i].initialLayout;
4988 } else if (pRenderPassInfo->pAttachments[i].initialLayout != image_data->second.layout) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07004989 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05004990 "You cannot start a render pass using attachment %i where the intial layout differs from the starting layout.", i);
4991 }
4992 }
4993 return skip_call;
4994}
4995
4996void TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin, const int subpass_index) {
4997 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
4998 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
4999 auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass);
5000 if (render_pass_data == dev_data->renderPassMap.end()) {
5001 return;
5002 }
Tobin Ehlisad61de42015-12-02 13:53:34 -07005003 const VkRenderPassCreateInfo* pRenderPassInfo = render_pass_data->second->pCreateInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05005004 auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer);
5005 if (framebuffer_data == dev_data->frameBufferMap.end()) {
5006 return;
5007 }
5008 const VkFramebufferCreateInfo* pFramebufferInfo = framebuffer_data->second;
5009 const VkSubpassDescription& subpass = pRenderPassInfo->pSubpasses[subpass_index];
5010 for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) {
5011 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pInputAttachments[j].attachment];
5012 auto image_view_data = dev_data->imageViewMap.find(image_view);
5013 if (image_view_data != dev_data->imageViewMap.end()) {
5014 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
5015 if (image_layout != pCB->imageLayoutMap.end()) {
5016 image_layout->second.layout = subpass.pInputAttachments[j].layout;
5017 }
5018 }
5019 }
5020 for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) {
5021 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pColorAttachments[j].attachment];
5022 auto image_view_data = dev_data->imageViewMap.find(image_view);
5023 if (image_view_data != dev_data->imageViewMap.end()) {
5024 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
5025 if (image_layout != pCB->imageLayoutMap.end()) {
5026 image_layout->second.layout = subpass.pColorAttachments[j].layout;
5027 }
5028 }
5029 }
Michael Lentine2b9eda42015-10-28 15:55:18 -07005030 if ((subpass.pDepthStencilAttachment != NULL) &&
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06005031 (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) {
Michael Lentine27b0f902015-10-12 11:30:14 -05005032 const VkImageView& image_view = pFramebufferInfo->pAttachments[subpass.pDepthStencilAttachment->attachment];
5033 auto image_view_data = dev_data->imageViewMap.find(image_view);
5034 if (image_view_data != dev_data->imageViewMap.end()) {
5035 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
5036 if (image_layout != pCB->imageLayoutMap.end()) {
5037 image_layout->second.layout = subpass.pDepthStencilAttachment->layout;
5038 }
5039 }
5040 }
5041}
5042
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07005043VkBool32 validatePrimaryCommandBuffer(const layer_data* my_data, const GLOBAL_CB_NODE* pCB, const std::string& cmd_name) {
5044 VkBool32 skip_call = false;
Michael Lentine2b9eda42015-10-28 15:55:18 -07005045 if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005046 skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 0, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS",
Michael Lentine2b9eda42015-10-28 15:55:18 -07005047 "Cannot execute command %s on a secondary command buffer.", cmd_name.c_str());
5048 }
5049 return skip_call;
5050}
5051
Michael Lentine27b0f902015-10-12 11:30:14 -05005052void TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo* pRenderPassBegin) {
5053 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map);
5054 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, cmdBuffer);
5055 auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass);
5056 if (render_pass_data == dev_data->renderPassMap.end()) {
5057 return;
5058 }
Tobin Ehlisad61de42015-12-02 13:53:34 -07005059 const VkRenderPassCreateInfo* pRenderPassInfo = render_pass_data->second->pCreateInfo;
Michael Lentine27b0f902015-10-12 11:30:14 -05005060 auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer);
5061 if (framebuffer_data == dev_data->frameBufferMap.end()) {
5062 return;
5063 }
5064 const VkFramebufferCreateInfo* pFramebufferInfo = framebuffer_data->second;
5065 for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) {
5066 const VkImageView& image_view = pFramebufferInfo->pAttachments[i];
5067 auto image_view_data = dev_data->imageViewMap.find(image_view);
5068 if (image_view_data != dev_data->imageViewMap.end()) {
5069 auto image_layout = pCB->imageLayoutMap.find(image_view_data->second->image);
5070 if (image_layout != pCB->imageLayoutMap.end()) {
5071 image_layout->second.layout = pRenderPassInfo->pAttachments[i].finalLayout;
5072 }
5073 }
5074 }
5075}
5076
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005077VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005078{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005079 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08005080 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
5081 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005082 if (pCB) {
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06005083 if (pRenderPassBegin && pRenderPassBegin->renderPass) {
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06005084 skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin);
Tobin Ehlis42d440c2015-10-20 17:06:16 -06005085 skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass");
Michael Lentine2b9eda42015-10-28 15:55:18 -07005086 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass");
Tobin Ehlisb51cb782015-12-16 08:19:42 -07005087 skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()");
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06005088 pCB->activeRenderPass = pRenderPassBegin->renderPass;
Michael Lentine27b0f902015-10-12 11:30:14 -05005089 // This is a shallow copy as that is all that is needed for now
5090 pCB->activeRenderPassBeginInfo = *pRenderPassBegin;
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06005091 pCB->activeSubpass = 0;
5092 pCB->framebuffer = pRenderPassBegin->framebuffer;
5093 if (pCB->lastBoundPipeline) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06005094 skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, pCB->lastBoundPipeline);
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06005095 }
Tobin Ehlise4076782015-06-24 15:53:07 -06005096 } else {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005097 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_RENDERPASS, "DS",
Tobin Ehlis8b6c2352015-06-23 16:13:03 -06005098 "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()");
Tony Barbourb9f82ba2015-04-06 11:09:26 -06005099 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005100 }
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06005101 if (VK_FALSE == skipCall) {
Chia-I Wu1f851912015-10-27 18:04:07 +08005102 dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents);
Mark Lobodzinskic344bef2015-10-28 13:03:56 -06005103 // This is a shallow copy as that is all that is needed for now
5104 dev_data->renderPassBeginInfo = *pRenderPassBegin;
5105 dev_data->currentSubpass = 0;
5106 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005107}
5108
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005109VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents)
Chia-I Wuc278df82015-07-07 11:50:03 +08005110{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005111 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08005112 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
5113 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Michael Lentine27b0f902015-10-12 11:30:14 -05005114 TransitionSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo, ++dev_data->currentSubpass);
Chia-I Wuc278df82015-07-07 11:50:03 +08005115 if (pCB) {
Michael Lentine2b9eda42015-10-28 15:55:18 -07005116 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass");
Tobin Ehlisb51cb782015-12-16 08:19:42 -07005117 skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()");
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06005118 pCB->activeSubpass++;
Tony Barbourcbc0fa82015-12-15 10:24:45 -07005119 TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06005120 if (pCB->lastBoundPipeline) {
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06005121 skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, pCB->lastBoundPipeline);
Chia-I Wuc278df82015-07-07 11:50:03 +08005122 }
Tobin Ehlis42d440c2015-10-20 17:06:16 -06005123 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass");
Chia-I Wuc278df82015-07-07 11:50:03 +08005124 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005125 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08005126 dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents);
Chia-I Wuc278df82015-07-07 11:50:03 +08005127}
5128
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005129VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndRenderPass(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005130{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005131 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08005132 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
5133 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Michael Lentine27b0f902015-10-12 11:30:14 -05005134 TransitionFinalSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005135 if (pCB) {
Michael Lentine2b9eda42015-10-28 15:55:18 -07005136 skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass");
Michael Lentine2b9eda42015-10-28 15:55:18 -07005137 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass");
Tobin Ehlisb51cb782015-12-16 08:19:42 -07005138 skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()");
Michael Lentine27b0f902015-10-12 11:30:14 -05005139 TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo);
Mark Lobodzinskia0f061c2015-09-30 16:19:16 -06005140 pCB->activeRenderPass = 0;
5141 pCB->activeSubpass = 0;
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08005142 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005143 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08005144 dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer);
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08005145}
5146
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005147VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer* pCommandBuffers)
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08005148{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005149 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08005150 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
5151 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Chia-I Wu88eaa3b2015-06-26 15:34:39 +08005152 if (pCB) {
Tobin Ehlis5f728d32015-09-17 14:18:16 -06005153 GLOBAL_CB_NODE* pSubCB = NULL;
Chia-I Wu1f851912015-10-27 18:04:07 +08005154 for (uint32_t i=0; i<commandBuffersCount; i++) {
5155 pSubCB = getCBNode(dev_data, pCommandBuffers[i]);
Tobin Ehlis5f728d32015-09-17 14:18:16 -06005156 if (!pSubCB) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005157 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08005158 "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p in element %u of pCommandBuffers array.", (void*)pCommandBuffers[i], i);
5159 } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005160 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS",
Chia-I Wu1f851912015-10-27 18:04:07 +08005161 "vkCmdExecuteCommands() called w/ Primary Cmd Buffer %p in element %u of pCommandBuffers array. All cmd buffers in pCommandBuffers array must be secondary.", (void*)pCommandBuffers[i], i);
Tobin Ehlis5f728d32015-09-17 14:18:16 -06005162 }
5163 }
Michael Lentine2b9eda42015-10-28 15:55:18 -07005164 skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands");
Tobin Ehlisb51cb782015-12-16 08:19:42 -07005165 skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005166 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005167 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08005168 dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005169}
5170
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07005171VkBool32 ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) {
5172 VkBool32 skip_call = false;
Michael Lentineee4ad4d2015-10-23 12:41:44 -07005173 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
5174 auto mem_data = dev_data->memImageMap.find(mem);
5175 if (mem_data != dev_data->memImageMap.end()) {
5176 auto image_data = dev_data->imageLayoutMap.find(mem_data->second);
5177 if (image_data != dev_data->imageLayoutMap.end()) {
5178 if (image_data->second->layout != VK_IMAGE_LAYOUT_PREINITIALIZED && image_data->second->layout != VK_IMAGE_LAYOUT_GENERAL) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005179 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT) 0, 0, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentineee4ad4d2015-10-23 12:41:44 -07005180 "Cannot map an image with layout %d. Only GENERAL or PREINITIALIZED are supported.", image_data->second->layout);
5181 }
5182 }
5183 }
5184 return skip_call;
5185}
5186
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005187VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkMapMemory(
Michael Lentineee4ad4d2015-10-23 12:41:44 -07005188 VkDevice device,
5189 VkDeviceMemory mem,
5190 VkDeviceSize offset,
5191 VkDeviceSize size,
5192 VkFlags flags,
5193 void **ppData)
5194{
5195 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Mark Lobodzinski78940a42015-11-30 16:48:53 -07005196
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07005197 VkBool32 skip_call = VK_FALSE;
Mark Lobodzinski78940a42015-11-30 16:48:53 -07005198#ifndef DISABLE_IMAGE_LAYOUT_VALIDATION
5199 skip_call = ValidateMapImageLayouts(device, mem);
5200#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
5201
Michael Lentineee4ad4d2015-10-23 12:41:44 -07005202 if (VK_FALSE == skip_call) {
5203 return dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData);
5204 }
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07005205 return VK_ERROR_VALIDATION_FAILED_EXT;
Michael Lentineee4ad4d2015-10-23 12:41:44 -07005206}
5207
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005208VKAPI_ATTR VkResult VKAPI_CALL vkBindImageMemory(
Michael Lentineee4ad4d2015-10-23 12:41:44 -07005209 VkDevice device,
5210 VkImage image,
5211 VkDeviceMemory mem,
5212 VkDeviceSize memOffset)
5213{
5214 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
5215 VkResult result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memOffset);
5216 loader_platform_thread_lock_mutex(&globalLock);
5217 dev_data->memImageMap[mem] = image;
5218 loader_platform_thread_unlock_mutex(&globalLock);
5219 return result;
5220}
5221
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005222VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSwapchainKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05005223 VkDevice device,
5224 const VkSwapchainCreateInfoKHR *pCreateInfo,
Ian Elliottc623ba52015-11-20 14:13:17 -07005225 const VkAllocationCallbacks *pAllocator,
Michael Lentine27b0f902015-10-12 11:30:14 -05005226 VkSwapchainKHR *pSwapchain)
5227{
5228 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Ian Elliottc623ba52015-11-20 14:13:17 -07005229 VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain);
Michael Lentine27b0f902015-10-12 11:30:14 -05005230
5231 if (VK_SUCCESS == result) {
5232 SWAPCHAIN_NODE *swapchain_data = new SWAPCHAIN_NODE;
5233 loader_platform_thread_lock_mutex(&globalLock);
5234 dev_data->device_extensions.swapchainMap[*pSwapchain] = swapchain_data;
5235 loader_platform_thread_unlock_mutex(&globalLock);
5236 }
5237
5238 return result;
5239}
5240
Ian Elliottc623ba52015-11-20 14:13:17 -07005241VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroySwapchainKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05005242 VkDevice device,
Ian Elliottc623ba52015-11-20 14:13:17 -07005243 VkSwapchainKHR swapchain,
5244 const VkAllocationCallbacks *pAllocator)
Michael Lentine27b0f902015-10-12 11:30:14 -05005245{
5246 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
Michael Lentine27b0f902015-10-12 11:30:14 -05005247
5248 loader_platform_thread_lock_mutex(&globalLock);
5249 auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain);
5250 if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) {
5251 if (swapchain_data->second->images.size() > 0) {
5252 for (auto swapchain_image : swapchain_data->second->images) {
5253 auto image_item = dev_data->imageLayoutMap.find(swapchain_image);
5254 if (image_item != dev_data->imageLayoutMap.end())
5255 dev_data->imageLayoutMap.erase(image_item);
5256 }
5257 }
5258 delete swapchain_data->second;
5259 dev_data->device_extensions.swapchainMap.erase(swapchain);
5260 }
5261 loader_platform_thread_unlock_mutex(&globalLock);
Ian Elliottc623ba52015-11-20 14:13:17 -07005262 return dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator);
Michael Lentine27b0f902015-10-12 11:30:14 -05005263}
5264
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005265VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkGetSwapchainImagesKHR(
Michael Lentine27b0f902015-10-12 11:30:14 -05005266 VkDevice device,
5267 VkSwapchainKHR swapchain,
5268 uint32_t* pCount,
5269 VkImage* pSwapchainImages)
5270{
5271 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map);
5272 VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages);
5273
5274 if (result == VK_SUCCESS && pSwapchainImages != NULL) {
5275 // This should never happen and is checked by param checker.
5276 if (!pCount) return result;
5277 for (uint32_t i = 0; i < *pCount; ++i) {
5278 IMAGE_NODE* image_node = new IMAGE_NODE;
5279 image_node->layout = VK_IMAGE_LAYOUT_UNDEFINED;
5280 loader_platform_thread_lock_mutex(&globalLock);
5281 dev_data->device_extensions.swapchainMap[swapchain]->images.push_back(pSwapchainImages[i]);
5282 dev_data->imageLayoutMap[pSwapchainImages[i]] = image_node;
5283 loader_platform_thread_unlock_mutex(&globalLock);
5284 }
5285 }
5286 return result;
5287}
5288
Ian Elliottc623ba52015-11-20 14:13:17 -07005289VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR* pPresentInfo)
Michael Lentine27b0f902015-10-12 11:30:14 -05005290{
5291 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map);
Courtney Goeltzenleuchterda665bf2015-12-16 16:07:01 -07005292 VkBool32 skip_call = false;
Michael Lentine27b0f902015-10-12 11:30:14 -05005293
Mark Lobodzinski78940a42015-11-30 16:48:53 -07005294#ifndef DISABLE_IMAGE_LAYOUT_VALIDATION
Michael Lentine27b0f902015-10-12 11:30:14 -05005295 if (pPresentInfo) {
5296 for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) {
Ian Elliottc623ba52015-11-20 14:13:17 -07005297 auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->pSwapchains[i]);
5298 if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && pPresentInfo->pImageIndices[i] < swapchain_data->second->images.size()) {
5299 VkImage image = swapchain_data->second->images[pPresentInfo->pImageIndices[i]];
Michael Lentine27b0f902015-10-12 11:30:14 -05005300 auto image_data = dev_data->imageLayoutMap.find(image);
5301 if (image_data != dev_data->imageLayoutMap.end()) {
Ian Elliottc623ba52015-11-20 14:13:17 -07005302 if (image_data->second->layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005303 skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, (uint64_t)queue, 0, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS",
Michael Lentine27b0f902015-10-12 11:30:14 -05005304 "Images passed to present must be in layout PRESENT_SOURCE_KHR but is in %d", image_data->second->layout);
5305 }
5306 }
5307 }
5308 }
5309 }
Mark Lobodzinski78940a42015-11-30 16:48:53 -07005310#endif // DISABLE_IMAGE_LAYOUT_VALIDATION
Michael Lentine27b0f902015-10-12 11:30:14 -05005311
5312 if (VK_FALSE == skip_call)
5313 return dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo);
Courtney Goeltzenleuchter48605a52015-12-10 16:41:22 -07005314 return VK_ERROR_VALIDATION_FAILED_EXT;
Michael Lentine27b0f902015-10-12 11:30:14 -05005315}
5316
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005317VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDebugReportCallbackEXT(
5318 VkInstance instance,
5319 const VkDebugReportCallbackCreateInfoEXT* pCreateInfo,
5320 const VkAllocationCallbacks* pAllocator,
5321 VkDebugReportCallbackEXT* pMsgCallback)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005322{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005323 layer_data* my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07005324 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005325 VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback);
Tobin Ehlisc91330b2015-06-16 09:04:30 -06005326 if (VK_SUCCESS == res) {
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07005327 res = layer_create_msg_callback(my_data->report_data, pCreateInfo, pAllocator, pMsgCallback);
Tobin Ehlisc91330b2015-06-16 09:04:30 -06005328 }
5329 return res;
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005330}
5331
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005332VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07005333 VkInstance instance,
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005334 VkDebugReportCallbackEXT msgCallback,
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07005335 const VkAllocationCallbacks* pAllocator)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005336{
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005337 layer_data* my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07005338 VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table;
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005339 pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator);
Courtney Goeltzenleuchterf6a6e222015-11-30 12:13:14 -07005340 layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005341}
5342
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005343VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDebugReportMessageEXT(
Courtney Goeltzenleuchter5a424ce2015-12-01 14:10:55 -07005344 VkInstance instance,
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005345 VkDebugReportFlagsEXT flags,
5346 VkDebugReportObjectTypeEXT objType,
Courtney Goeltzenleuchter5a424ce2015-12-01 14:10:55 -07005347 uint64_t object,
5348 size_t location,
5349 int32_t msgCode,
5350 const char* pLayerPrefix,
5351 const char* pMsg)
5352{
5353 layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005354 my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg);
Courtney Goeltzenleuchter5a424ce2015-12-01 14:10:55 -07005355}
5356
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005357VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDbgMarkerBegin(VkCommandBuffer commandBuffer, const char* pMarker)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005358{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005359 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08005360 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
5361 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005362 if (!dev_data->device_extensions.debug_marker_enabled) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005363 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_EXTENSION, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06005364 "Attempt to use CmdDbgMarkerBegin but extension disabled!");
Jon Ashburn6f8cd632015-06-01 09:37:38 -06005365 return;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06005366 } else if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07005367 skipCall |= addCmd(dev_data, pCB, CMD_DBGMARKERBEGIN, "vkCmdDbgMarkerBegin()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005368 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005369 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08005370 debug_marker_dispatch_table(commandBuffer)->CmdDbgMarkerBegin(commandBuffer, pMarker);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005371}
5372
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005373VK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDbgMarkerEnd(VkCommandBuffer commandBuffer)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005374{
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005375 VkBool32 skipCall = VK_FALSE;
Chia-I Wu1f851912015-10-27 18:04:07 +08005376 layer_data* dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map);
5377 GLOBAL_CB_NODE* pCB = getCBNode(dev_data, commandBuffer);
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005378 if (!dev_data->device_extensions.debug_marker_enabled) {
Courtney Goeltzenleuchteracb13592015-12-09 15:48:16 -07005379 skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, 0, DRAWSTATE_INVALID_EXTENSION, "DS",
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06005380 "Attempt to use CmdDbgMarkerEnd but extension disabled!");
Jon Ashburn6f8cd632015-06-01 09:37:38 -06005381 return;
Tobin Ehlisa366ca22015-06-19 15:07:05 -06005382 } else if (pCB) {
Tobin Ehlisb51cb782015-12-16 08:19:42 -07005383 skipCall |= addCmd(dev_data, pCB, CMD_DBGMARKEREND, "vkCmdDbgMarkerEnd()");
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005384 }
Tobin Ehlis48ddcb82015-09-09 11:31:10 -06005385 if (VK_FALSE == skipCall)
Chia-I Wu1f851912015-10-27 18:04:07 +08005386 debug_marker_dispatch_table(commandBuffer)->CmdDbgMarkerEnd(commandBuffer);
Jon Ashburn6f8cd632015-06-01 09:37:38 -06005387}
5388
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005389VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char* funcName)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005390{
Jon Ashburn1245cec2015-05-18 13:20:15 -06005391 if (dev == NULL)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005392 return NULL;
Jon Ashburne0fa2282015-05-20 09:00:28 -06005393
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005394 layer_data *dev_data;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06005395 /* loader uses this to force layer initialization; device object is wrapped */
5396 if (!strcmp(funcName, "vkGetDeviceProcAddr")) {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005397 VkBaseLayerObject* wrapped_dev = (VkBaseLayerObject*) dev;
5398 dev_data = get_my_data_ptr(get_dispatch_key(wrapped_dev->baseObject), layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06005399 dev_data->device_dispatch_table = new VkLayerDispatchTable;
5400 layer_initialize_dispatch_table(dev_data->device_dispatch_table, wrapped_dev);
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005401 return (PFN_vkVoidFunction) vkGetDeviceProcAddr;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06005402 }
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005403 dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map);
Courtney Goeltzenleuchterbe637992015-06-25 18:01:43 -06005404 if (!strcmp(funcName, "vkCreateDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005405 return (PFN_vkVoidFunction) vkCreateDevice;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005406 if (!strcmp(funcName, "vkDestroyDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005407 return (PFN_vkVoidFunction) vkDestroyDevice;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005408 if (!strcmp(funcName, "vkQueueSubmit"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005409 return (PFN_vkVoidFunction) vkQueueSubmit;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005410 if (!strcmp(funcName, "vkDestroyInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005411 return (PFN_vkVoidFunction) vkDestroyInstance;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005412 if (!strcmp(funcName, "vkDestroyDevice"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005413 return (PFN_vkVoidFunction) vkDestroyDevice;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005414 if (!strcmp(funcName, "vkDestroyFence"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005415 return (PFN_vkVoidFunction) vkDestroyFence;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005416 if (!strcmp(funcName, "vkDestroySemaphore"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005417 return (PFN_vkVoidFunction) vkDestroySemaphore;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005418 if (!strcmp(funcName, "vkDestroyEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005419 return (PFN_vkVoidFunction) vkDestroyEvent;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005420 if (!strcmp(funcName, "vkDestroyQueryPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005421 return (PFN_vkVoidFunction) vkDestroyQueryPool;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005422 if (!strcmp(funcName, "vkDestroyBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005423 return (PFN_vkVoidFunction) vkDestroyBuffer;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005424 if (!strcmp(funcName, "vkDestroyBufferView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005425 return (PFN_vkVoidFunction) vkDestroyBufferView;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005426 if (!strcmp(funcName, "vkDestroyImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005427 return (PFN_vkVoidFunction) vkDestroyImage;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005428 if (!strcmp(funcName, "vkDestroyImageView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005429 return (PFN_vkVoidFunction) vkDestroyImageView;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005430 if (!strcmp(funcName, "vkDestroyShaderModule"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005431 return (PFN_vkVoidFunction) vkDestroyShaderModule;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005432 if (!strcmp(funcName, "vkDestroyPipeline"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005433 return (PFN_vkVoidFunction) vkDestroyPipeline;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005434 if (!strcmp(funcName, "vkDestroyPipelineLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005435 return (PFN_vkVoidFunction) vkDestroyPipelineLayout;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005436 if (!strcmp(funcName, "vkDestroySampler"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005437 return (PFN_vkVoidFunction) vkDestroySampler;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005438 if (!strcmp(funcName, "vkDestroyDescriptorSetLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005439 return (PFN_vkVoidFunction) vkDestroyDescriptorSetLayout;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005440 if (!strcmp(funcName, "vkDestroyDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005441 return (PFN_vkVoidFunction) vkDestroyDescriptorPool;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005442 if (!strcmp(funcName, "vkDestroyFramebuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005443 return (PFN_vkVoidFunction) vkDestroyFramebuffer;
Tobin Ehlis1dce5f12015-07-07 10:42:20 -06005444 if (!strcmp(funcName, "vkDestroyRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005445 return (PFN_vkVoidFunction) vkDestroyRenderPass;
Tobin Ehlisb46be812015-10-23 16:00:08 -06005446 if (!strcmp(funcName, "vkCreateBuffer"))
5447 return (PFN_vkVoidFunction) vkCreateBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005448 if (!strcmp(funcName, "vkCreateBufferView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005449 return (PFN_vkVoidFunction) vkCreateBufferView;
Tobin Ehlisb46be812015-10-23 16:00:08 -06005450 if (!strcmp(funcName, "vkCreateImage"))
5451 return (PFN_vkVoidFunction) vkCreateImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005452 if (!strcmp(funcName, "vkCreateImageView"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005453 return (PFN_vkVoidFunction) vkCreateImageView;
Jon Ashburn0d60d272015-07-09 15:02:25 -06005454 if (!strcmp(funcName, "CreatePipelineCache"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005455 return (PFN_vkVoidFunction) vkCreatePipelineCache;
Jon Ashburn0d60d272015-07-09 15:02:25 -06005456 if (!strcmp(funcName, "DestroyPipelineCache"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005457 return (PFN_vkVoidFunction) vkDestroyPipelineCache;
Jon Ashburn0d60d272015-07-09 15:02:25 -06005458 if (!strcmp(funcName, "GetPipelineCacheData"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005459 return (PFN_vkVoidFunction) vkGetPipelineCacheData;
Jon Ashburn0d60d272015-07-09 15:02:25 -06005460 if (!strcmp(funcName, "MergePipelineCaches"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005461 return (PFN_vkVoidFunction) vkMergePipelineCaches;
Jon Ashburn0d60d272015-07-09 15:02:25 -06005462 if (!strcmp(funcName, "vkCreateGraphicsPipelines"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005463 return (PFN_vkVoidFunction) vkCreateGraphicsPipelines;
Mark Lobodzinski2adea752015-11-10 15:25:01 -07005464 if (!strcmp(funcName, "vkCreateComputePipelines"))
5465 return (PFN_vkVoidFunction) vkCreateComputePipelines;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005466 if (!strcmp(funcName, "vkCreateSampler"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005467 return (PFN_vkVoidFunction) vkCreateSampler;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005468 if (!strcmp(funcName, "vkCreateDescriptorSetLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005469 return (PFN_vkVoidFunction) vkCreateDescriptorSetLayout;
Mark Lobodzinski556f7212015-04-17 14:11:39 -05005470 if (!strcmp(funcName, "vkCreatePipelineLayout"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005471 return (PFN_vkVoidFunction) vkCreatePipelineLayout;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005472 if (!strcmp(funcName, "vkCreateDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005473 return (PFN_vkVoidFunction) vkCreateDescriptorPool;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005474 if (!strcmp(funcName, "vkResetDescriptorPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005475 return (PFN_vkVoidFunction) vkResetDescriptorPool;
Chia-I Wu1f851912015-10-27 18:04:07 +08005476 if (!strcmp(funcName, "vkAllocateDescriptorSets"))
5477 return (PFN_vkVoidFunction) vkAllocateDescriptorSets;
Tobin Ehlis3c543112015-10-08 13:13:50 -06005478 if (!strcmp(funcName, "vkFreeDescriptorSets"))
5479 return (PFN_vkVoidFunction) vkFreeDescriptorSets;
Chia-I Wu8cd8ecd2015-05-25 16:27:55 +08005480 if (!strcmp(funcName, "vkUpdateDescriptorSets"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005481 return (PFN_vkVoidFunction) vkUpdateDescriptorSets;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07005482 if (!strcmp(funcName, "vkCreateCommandPool"))
5483 return (PFN_vkVoidFunction) vkCreateCommandPool;
5484 if (!strcmp(funcName, "vkDestroyCommandPool"))
5485 return (PFN_vkVoidFunction) vkDestroyCommandPool;
Tobin Ehlis4c8381e2015-12-14 13:46:38 -07005486 if (!strcmp(funcName, "vkResetCommandPool"))
5487 return (PFN_vkVoidFunction) vkResetCommandPool;
Chia-I Wu1f851912015-10-27 18:04:07 +08005488 if (!strcmp(funcName, "vkAllocateCommandBuffers"))
5489 return (PFN_vkVoidFunction) vkAllocateCommandBuffers;
Mark Lobodzinskia3b99d82015-11-18 08:38:27 -07005490 if (!strcmp(funcName, "vkFreeCommandBuffers"))
5491 return (PFN_vkVoidFunction) vkFreeCommandBuffers;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005492 if (!strcmp(funcName, "vkBeginCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005493 return (PFN_vkVoidFunction) vkBeginCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005494 if (!strcmp(funcName, "vkEndCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005495 return (PFN_vkVoidFunction) vkEndCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005496 if (!strcmp(funcName, "vkResetCommandBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005497 return (PFN_vkVoidFunction) vkResetCommandBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005498 if (!strcmp(funcName, "vkCmdBindPipeline"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005499 return (PFN_vkVoidFunction) vkCmdBindPipeline;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06005500 if (!strcmp(funcName, "vkCmdSetViewport"))
5501 return (PFN_vkVoidFunction) vkCmdSetViewport;
Courtney Goeltzenleuchter932cdb52015-09-21 11:44:06 -06005502 if (!strcmp(funcName, "vkCmdSetScissor"))
5503 return (PFN_vkVoidFunction) vkCmdSetScissor;
Courtney Goeltzenleuchter09772bb2015-09-17 15:06:17 -06005504 if (!strcmp(funcName, "vkCmdSetLineWidth"))
5505 return (PFN_vkVoidFunction) vkCmdSetLineWidth;
5506 if (!strcmp(funcName, "vkCmdSetDepthBias"))
5507 return (PFN_vkVoidFunction) vkCmdSetDepthBias;
5508 if (!strcmp(funcName, "vkCmdSetBlendConstants"))
5509 return (PFN_vkVoidFunction) vkCmdSetBlendConstants;
5510 if (!strcmp(funcName, "vkCmdSetDepthBounds"))
5511 return (PFN_vkVoidFunction) vkCmdSetDepthBounds;
5512 if (!strcmp(funcName, "vkCmdSetStencilCompareMask"))
5513 return (PFN_vkVoidFunction) vkCmdSetStencilCompareMask;
5514 if (!strcmp(funcName, "vkCmdSetStencilWriteMask"))
5515 return (PFN_vkVoidFunction) vkCmdSetStencilWriteMask;
5516 if (!strcmp(funcName, "vkCmdSetStencilReference"))
5517 return (PFN_vkVoidFunction) vkCmdSetStencilReference;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005518 if (!strcmp(funcName, "vkCmdBindDescriptorSets"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005519 return (PFN_vkVoidFunction) vkCmdBindDescriptorSets;
Courtney Goeltzenleuchter46962942015-04-16 13:38:46 -06005520 if (!strcmp(funcName, "vkCmdBindVertexBuffers"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005521 return (PFN_vkVoidFunction) vkCmdBindVertexBuffers;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005522 if (!strcmp(funcName, "vkCmdBindIndexBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005523 return (PFN_vkVoidFunction) vkCmdBindIndexBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005524 if (!strcmp(funcName, "vkCmdDraw"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005525 return (PFN_vkVoidFunction) vkCmdDraw;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005526 if (!strcmp(funcName, "vkCmdDrawIndexed"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005527 return (PFN_vkVoidFunction) vkCmdDrawIndexed;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005528 if (!strcmp(funcName, "vkCmdDrawIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005529 return (PFN_vkVoidFunction) vkCmdDrawIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005530 if (!strcmp(funcName, "vkCmdDrawIndexedIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005531 return (PFN_vkVoidFunction) vkCmdDrawIndexedIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005532 if (!strcmp(funcName, "vkCmdDispatch"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005533 return (PFN_vkVoidFunction) vkCmdDispatch;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005534 if (!strcmp(funcName, "vkCmdDispatchIndirect"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005535 return (PFN_vkVoidFunction) vkCmdDispatchIndirect;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005536 if (!strcmp(funcName, "vkCmdCopyBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005537 return (PFN_vkVoidFunction) vkCmdCopyBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005538 if (!strcmp(funcName, "vkCmdCopyImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005539 return (PFN_vkVoidFunction) vkCmdCopyImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005540 if (!strcmp(funcName, "vkCmdCopyBufferToImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005541 return (PFN_vkVoidFunction) vkCmdCopyBufferToImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005542 if (!strcmp(funcName, "vkCmdCopyImageToBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005543 return (PFN_vkVoidFunction) vkCmdCopyImageToBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005544 if (!strcmp(funcName, "vkCmdUpdateBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005545 return (PFN_vkVoidFunction) vkCmdUpdateBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005546 if (!strcmp(funcName, "vkCmdFillBuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005547 return (PFN_vkVoidFunction) vkCmdFillBuffer;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005548 if (!strcmp(funcName, "vkCmdClearColorImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005549 return (PFN_vkVoidFunction) vkCmdClearColorImage;
Chris Forbes2951d7d2015-06-22 17:21:59 +12005550 if (!strcmp(funcName, "vkCmdClearDepthStencilImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005551 return (PFN_vkVoidFunction) vkCmdClearDepthStencilImage;
Courtney Goeltzenleuchter9feb0732015-10-15 16:51:05 -06005552 if (!strcmp(funcName, "vkCmdClearAttachments"))
5553 return (PFN_vkVoidFunction) vkCmdClearAttachments;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005554 if (!strcmp(funcName, "vkCmdResolveImage"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005555 return (PFN_vkVoidFunction) vkCmdResolveImage;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005556 if (!strcmp(funcName, "vkCmdSetEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005557 return (PFN_vkVoidFunction) vkCmdSetEvent;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005558 if (!strcmp(funcName, "vkCmdResetEvent"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005559 return (PFN_vkVoidFunction) vkCmdResetEvent;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005560 if (!strcmp(funcName, "vkCmdWaitEvents"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005561 return (PFN_vkVoidFunction) vkCmdWaitEvents;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005562 if (!strcmp(funcName, "vkCmdPipelineBarrier"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005563 return (PFN_vkVoidFunction) vkCmdPipelineBarrier;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005564 if (!strcmp(funcName, "vkCmdBeginQuery"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005565 return (PFN_vkVoidFunction) vkCmdBeginQuery;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005566 if (!strcmp(funcName, "vkCmdEndQuery"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005567 return (PFN_vkVoidFunction) vkCmdEndQuery;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005568 if (!strcmp(funcName, "vkCmdResetQueryPool"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005569 return (PFN_vkVoidFunction) vkCmdResetQueryPool;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005570 if (!strcmp(funcName, "vkCmdWriteTimestamp"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005571 return (PFN_vkVoidFunction) vkCmdWriteTimestamp;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005572 if (!strcmp(funcName, "vkCreateFramebuffer"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005573 return (PFN_vkVoidFunction) vkCreateFramebuffer;
Tobin Ehlis32479352015-12-01 09:48:58 -07005574 if (!strcmp(funcName, "vkCreateShaderModule"))
5575 return (PFN_vkVoidFunction) vkCreateShaderModule;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005576 if (!strcmp(funcName, "vkCreateRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005577 return (PFN_vkVoidFunction) vkCreateRenderPass;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005578 if (!strcmp(funcName, "vkCmdBeginRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005579 return (PFN_vkVoidFunction) vkCmdBeginRenderPass;
Chia-I Wuc278df82015-07-07 11:50:03 +08005580 if (!strcmp(funcName, "vkCmdNextSubpass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005581 return (PFN_vkVoidFunction) vkCmdNextSubpass;
Courtney Goeltzenleuchter9cc421e2015-04-08 15:36:08 -06005582 if (!strcmp(funcName, "vkCmdEndRenderPass"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005583 return (PFN_vkVoidFunction) vkCmdEndRenderPass;
Tobin Ehlis5f728d32015-09-17 14:18:16 -06005584 if (!strcmp(funcName, "vkCmdExecuteCommands"))
5585 return (PFN_vkVoidFunction) vkCmdExecuteCommands;
Michael Lentineee4ad4d2015-10-23 12:41:44 -07005586 if (!strcmp(funcName, "vkMapMemory"))
5587 return (PFN_vkVoidFunction) vkMapMemory;
Jon Ashburn6f8cd632015-06-01 09:37:38 -06005588
Michael Lentine27b0f902015-10-12 11:30:14 -05005589 if (dev_data->device_extensions.wsi_enabled)
5590 {
5591 if (!strcmp(funcName, "vkCreateSwapchainKHR"))
5592 return (PFN_vkVoidFunction) vkCreateSwapchainKHR;
5593 if (!strcmp(funcName, "vkDestroySwapchainKHR"))
5594 return (PFN_vkVoidFunction) vkDestroySwapchainKHR;
5595 if (!strcmp(funcName, "vkGetSwapchainImagesKHR"))
5596 return (PFN_vkVoidFunction) vkGetSwapchainImagesKHR;
5597 if (!strcmp(funcName, "vkQueuePresentKHR"))
5598 return (PFN_vkVoidFunction) vkQueuePresentKHR;
5599 }
5600
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005601 VkLayerDispatchTable* pTable = dev_data->device_dispatch_table;
5602 if (dev_data->device_extensions.debug_marker_enabled)
Jon Ashburn4f2575f2015-05-28 16:25:02 -06005603 {
Jon Ashburn7e07faf2015-06-18 15:02:58 -06005604 if (!strcmp(funcName, "vkCmdDbgMarkerBegin"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005605 return (PFN_vkVoidFunction) vkCmdDbgMarkerBegin;
Jon Ashburn7e07faf2015-06-18 15:02:58 -06005606 if (!strcmp(funcName, "vkCmdDbgMarkerEnd"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005607 return (PFN_vkVoidFunction) vkCmdDbgMarkerEnd;
Jon Ashburn6f8cd632015-06-01 09:37:38 -06005608 }
5609 {
Jon Ashburn4f2575f2015-05-28 16:25:02 -06005610 if (pTable->GetDeviceProcAddr == NULL)
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005611 return NULL;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06005612 return pTable->GetDeviceProcAddr(dev, funcName);
Jon Ashburn79b78ac2015-05-05 14:22:52 -06005613 }
5614}
5615
Chia-I Wuaf9e4fd2015-11-06 06:42:02 +08005616VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char* funcName)
Jon Ashburn79b78ac2015-05-05 14:22:52 -06005617{
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005618 PFN_vkVoidFunction fptr;
Jon Ashburn79b78ac2015-05-05 14:22:52 -06005619 if (instance == NULL)
5620 return NULL;
5621
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005622 layer_data* my_data;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06005623 /* loader uses this to force layer initialization; instance object is wrapped */
5624 if (!strcmp(funcName, "vkGetInstanceProcAddr")) {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005625 VkBaseLayerObject* wrapped_inst = (VkBaseLayerObject*) instance;
5626 my_data = get_my_data_ptr(get_dispatch_key(wrapped_inst->baseObject), layer_data_map);
Tobin Ehlisd04ccab2015-10-07 15:40:22 -06005627 my_data->instance_dispatch_table = new VkLayerInstanceDispatchTable;
5628 layer_init_instance_dispatch_table(my_data->instance_dispatch_table, wrapped_inst);
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005629 return (PFN_vkVoidFunction) vkGetInstanceProcAddr;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06005630 }
Courtney Goeltzenleuchter3c9f6ec2015-06-01 14:29:58 -06005631 if (!strcmp(funcName, "vkCreateInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005632 return (PFN_vkVoidFunction) vkCreateInstance;
Jon Ashburne0fa2282015-05-20 09:00:28 -06005633 if (!strcmp(funcName, "vkDestroyInstance"))
Courtney Goeltzenleuchtera4c8c712015-07-12 14:35:22 -06005634 return (PFN_vkVoidFunction) vkDestroyInstance;
Courtney Goeltzenleuchter74c4ce92015-09-14 17:22:16 -06005635 if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties"))
5636 return (PFN_vkVoidFunction) vkEnumerateInstanceLayerProperties;
5637 if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties"))
5638 return (PFN_vkVoidFunction) vkEnumerateInstanceExtensionProperties;
5639 if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties"))
5640 return (PFN_vkVoidFunction) vkEnumerateDeviceLayerProperties;
5641 if (!strcmp(funcName, "vkEnumerateDeviceExtensionProperties"))
5642 return (PFN_vkVoidFunction) vkEnumerateDeviceExtensionProperties;
Courtney Goeltzenleuchtercc899fe2015-06-01 14:33:14 -06005643
Tobin Ehlis32479352015-12-01 09:48:58 -07005644 my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map);
Tobin Ehlisfde4dce2015-06-16 15:50:44 -06005645 fptr = debug_report_get_instance_proc_addr(my_data->report_data, funcName);
Courtney Goeltzenleuchtercc899fe2015-06-01 14:33:14 -06005646 if (fptr)
5647 return fptr;
5648
Jon Ashburn4f2575f2015-05-28 16:25:02 -06005649 {
Tobin Ehlise6ab55a2015-10-07 09:38:40 -06005650 VkLayerInstanceDispatchTable* pTable = my_data->instance_dispatch_table;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06005651 if (pTable->GetInstanceProcAddr == NULL)
Jon Ashburn79b78ac2015-05-05 14:22:52 -06005652 return NULL;
Jon Ashburn4f2575f2015-05-28 16:25:02 -06005653 return pTable->GetInstanceProcAddr(instance, funcName);
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005654 }
Tobin Ehlis63bb9482015-03-17 16:24:32 -06005655}