blob: 9e4a816a45eca7097895b8aaa7b668303f8c8454 [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Yves Gerey3e707812018-11-28 16:47:49 +010011#include <stdint.h>
Jonas Olssona4d87372019-07-05 19:08:33 +020012
Henrik Boström933d8b02017-10-10 10:05:16 -070013#include <memory>
Yves Gerey3e707812018-11-28 16:47:49 +010014#include <string>
15#include <utility>
Henrik Boström933d8b02017-10-10 10:05:16 -070016#include <vector>
17
Yves Gerey3e707812018-11-28 16:47:49 +010018#include "absl/types/optional.h"
19#include "api/audio/audio_mixer.h"
20#include "api/audio_codecs/audio_decoder_factory.h"
21#include "api/audio_codecs/audio_encoder_factory.h"
Karl Wiberg1b0eae32017-10-17 14:48:54 +020022#include "api/audio_codecs/builtin_audio_decoder_factory.h"
23#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Mirko Bonadei2ff3f492018-11-22 09:00:13 +010024#include "api/create_peerconnection_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070025#include "api/jsep.h"
Steve Anton10542f22019-01-11 09:11:00 -080026#include "api/media_stream_interface.h"
27#include "api/media_types.h"
28#include "api/peer_connection_interface.h"
29#include "api/rtc_error.h"
30#include "api/rtp_parameters.h"
31#include "api/rtp_receiver_interface.h"
32#include "api/rtp_sender_interface.h"
33#include "api/rtp_transceiver_interface.h"
Mirko Bonadeid9708072019-01-25 20:26:48 +010034#include "api/scoped_refptr.h"
Steve Anton10542f22019-01-11 09:11:00 -080035#include "api/set_remote_description_observer_interface.h"
36#include "api/uma_metrics.h"
Anders Carlsson67537952018-05-03 11:28:29 +020037#include "api/video_codecs/builtin_video_decoder_factory.h"
38#include "api/video_codecs/builtin_video_encoder_factory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010039#include "api/video_codecs/video_decoder_factory.h"
40#include "api/video_codecs/video_encoder_factory.h"
Steve Anton10542f22019-01-11 09:11:00 -080041#include "media/base/stream_params.h"
Yves Gerey3e707812018-11-28 16:47:49 +010042#include "modules/audio_device/include/audio_device.h"
43#include "modules/audio_processing/include/audio_processing.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "p2p/base/port_allocator.h"
45#include "pc/media_session.h"
46#include "pc/peer_connection_wrapper.h"
47#include "pc/sdp_utils.h"
48#include "pc/session_description.h"
49#include "pc/test/fake_audio_capture_module.h"
50#include "pc/test/mock_peer_connection_observers.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070051#include "rtc_base/checks.h"
52#include "rtc_base/gunit.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "rtc_base/ref_counted_object.h"
54#include "rtc_base/rtc_certificate_generator.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070055#include "rtc_base/thread.h"
Mirko Bonadei17f48782018-09-28 08:51:10 +020056#include "system_wrappers/include/metrics.h"
Steve Anton9158ef62017-11-27 13:01:52 -080057#include "test/gmock.h"
Yves Gerey3e707812018-11-28 16:47:49 +010058#include "test/gtest.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070059
60// This file contains tests for RTP Media API-related behavior of
61// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
62
Steve Anton9158ef62017-11-27 13:01:52 -080063namespace webrtc {
64
65using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
66using ::testing::ElementsAre;
Steve Antonc1e6e862019-03-04 14:43:44 -080067using ::testing::Pair;
Steve Anton9158ef62017-11-27 13:01:52 -080068using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 15:30:18 -070069using ::testing::Values;
Henrik Boström933d8b02017-10-10 10:05:16 -070070
Henrik Boström31638672017-11-23 17:48:32 +010071const uint32_t kDefaultTimeout = 10000u;
72
73template <typename MethodFunctor>
74class OnSuccessObserver : public rtc::RefCountedObject<
75 webrtc::SetRemoteDescriptionObserverInterface> {
76 public:
77 explicit OnSuccessObserver(MethodFunctor on_success)
78 : on_success_(std::move(on_success)) {}
79
80 // webrtc::SetRemoteDescriptionObserverInterface implementation.
81 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
82 RTC_CHECK(error.ok());
83 on_success_();
84 }
85
86 private:
87 MethodFunctor on_success_;
88};
89
Mirko Bonadei6a489f22019-04-09 15:11:12 +020090class PeerConnectionRtpBaseTest : public ::testing::Test {
Henrik Boström933d8b02017-10-10 10:05:16 -070091 public:
Steve Anton3172c032018-05-03 15:30:18 -070092 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
93 : sdp_semantics_(sdp_semantics),
94 pc_factory_(
Steve Anton9158ef62017-11-27 13:01:52 -080095 CreatePeerConnectionFactory(rtc::Thread::Current(),
96 rtc::Thread::Current(),
97 rtc::Thread::Current(),
98 FakeAudioCaptureModule::Create(),
99 CreateBuiltinAudioEncoderFactory(),
100 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 11:28:29 +0200101 CreateBuiltinVideoEncoderFactory(),
102 CreateBuiltinVideoDecoderFactory(),
103 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 12:54:53 -0700104 nullptr /* audio_processing */)) {
105 webrtc::metrics::Reset();
106 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700107
Steve Anton9158ef62017-11-27 13:01:52 -0800108 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
109 return CreatePeerConnection(RTCConfiguration());
110 }
111
Steve Antone831b8c2018-02-01 12:22:16 -0800112 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
113 RTCConfiguration config;
114 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 15:30:18 -0700115 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 12:22:16 -0800116 }
117
Steve Anton9158ef62017-11-27 13:01:52 -0800118 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
119 RTCConfiguration config;
120 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 15:30:18 -0700121 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 13:01:52 -0800122 }
123
124 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
125 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 15:30:18 -0700126 RTCConfiguration modified_config = config;
127 modified_config.sdp_semantics = sdp_semantics_;
128 return CreatePeerConnectionInternal(modified_config);
129 }
130
131 protected:
132 const SdpSemantics sdp_semantics_;
133 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
134
135 private:
136 // Private so that tests don't accidentally bypass the SdpSemantics
137 // adjustment.
138 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
139 const RTCConfiguration& config) {
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200140 auto observer = std::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -0700141 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
142 observer.get());
Yves Gerey4e933292018-10-31 15:36:05 +0100143 EXPECT_TRUE(pc.get());
144 observer->SetPeerConnectionInterface(pc.get());
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200145 return std::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
146 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -0700147 }
Steve Anton3172c032018-05-03 15:30:18 -0700148};
Henrik Boström933d8b02017-10-10 10:05:16 -0700149
Steve Anton3172c032018-05-03 15:30:18 -0700150class PeerConnectionRtpTest
151 : public PeerConnectionRtpBaseTest,
152 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 10:05:16 -0700153 protected:
Steve Anton3172c032018-05-03 15:30:18 -0700154 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
155};
156
157class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
158 protected:
159 PeerConnectionRtpTestPlanB()
160 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
161};
162
163class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
164 protected:
165 PeerConnectionRtpTestUnifiedPlan()
166 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Henrik Boström933d8b02017-10-10 10:05:16 -0700167};
168
Henrik Boström31638672017-11-23 17:48:32 +0100169// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
170// setting the remote description.
Henrik Boström31638672017-11-23 17:48:32 +0100171
Steve Anton3172c032018-05-03 15:30:18 -0700172TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700173 auto caller = CreatePeerConnection();
174 auto callee = CreatePeerConnection();
175
Steve Anton3172c032018-05-03 15:30:18 -0700176 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700177 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700178
Henrik Boström31638672017-11-23 17:48:32 +0100179 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700180 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100181 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 15:30:18 -0700182
183 if (sdp_semantics_ == SdpSemantics::kPlanB) {
184 // Since we are not supporting the no stream case with Plan B, there should
185 // be a generated stream, even though we didn't set one with AddTrack.
186 ASSERT_EQ(1u, add_track_event.streams.size());
187 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
188 } else {
189 EXPECT_EQ(0u, add_track_event.streams.size());
190 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700191}
192
Steve Anton3172c032018-05-03 15:30:18 -0700193TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700194 auto caller = CreatePeerConnection();
195 auto callee = CreatePeerConnection();
196
Steve Anton3172c032018-05-03 15:30:18 -0700197 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700198 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700199
Henrik Boström31638672017-11-23 17:48:32 +0100200 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100201 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100202 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700203 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100204 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
205 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700206}
207
Steve Anton3172c032018-05-03 15:30:18 -0700208TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700209 auto caller = CreatePeerConnection();
210 auto callee = CreatePeerConnection();
211
Steve Anton3172c032018-05-03 15:30:18 -0700212 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700213 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100214 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700215 ASSERT_TRUE(
216 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
217
Henrik Boström933d8b02017-10-10 10:05:16 -0700218 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700219 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700220
Henrik Boström31638672017-11-23 17:48:32 +0100221 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700222 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
223 callee->observer()->remove_track_events_);
224}
225
Steve Anton3172c032018-05-03 15:30:18 -0700226TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700227 auto caller = CreatePeerConnection();
228 auto callee = CreatePeerConnection();
229
Steve Anton3172c032018-05-03 15:30:18 -0700230 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700231 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100232 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700233 ASSERT_TRUE(
234 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
235
Henrik Boström933d8b02017-10-10 10:05:16 -0700236 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700237 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700238
Henrik Boström31638672017-11-23 17:48:32 +0100239 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700240 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
241 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700242 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700243}
244
Steve Anton3172c032018-05-03 15:30:18 -0700245TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700246 auto caller = CreatePeerConnection();
247 auto callee = CreatePeerConnection();
248
Seth Hampson845e8782018-03-02 11:34:10 -0800249 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700250 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
251 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700252 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100253 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 15:30:18 -0700254 ASSERT_TRUE(
255 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700256
257 // Remove "audio_track1".
258 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700259 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100260 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700261 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800262 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700263 callee->observer()->add_track_events_[0].receiver},
264 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700265 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
266 ASSERT_TRUE(
267 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700268
269 // Remove "audio_track2".
270 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700271 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100272 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700273 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
274 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700275 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700276}
277
Seth Hampson5b4f0752018-04-02 16:31:36 -0700278// Tests the edge case that if a stream ID changes for a given track that both
279// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 15:30:18 -0700280TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700281 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
282 auto caller = CreatePeerConnection();
283 auto callee = CreatePeerConnection();
284
285 const char kStreamId1[] = "stream1";
286 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700287 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700288 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700289 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
290
291 // Change the stream ID of the sender in the session description.
292 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 15:30:18 -0700293 auto* audio_desc =
294 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700295 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
296 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 15:30:18 -0700297 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700298
299 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
300 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
301 kStreamId2);
302 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
303 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
304 kStreamId1);
305}
306
Steve Anton8b815cd2018-02-16 16:14:42 -0800307// Tests that setting a remote description with sending transceivers will fire
308// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 16:31:36 -0700309// with receive only transceivers will not call OnTrack. One transceiver is
310// created without any stream_ids, while the other is created with multiple
311// stream_ids.
Steve Anton3172c032018-05-03 15:30:18 -0700312TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 16:31:36 -0700313 const std::string kStreamId1 = "video_stream1";
314 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700315 auto caller = CreatePeerConnection();
316 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800317
318 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 16:31:36 -0700319 RtpTransceiverInit video_transceiver_init;
320 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
321 auto video_transceiver =
322 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-16 16:14:42 -0800323
324 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
325
326 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
327 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
328 EXPECT_EQ(audio_transceiver->mid(),
329 callee->pc()->GetTransceivers()[0]->mid());
330 EXPECT_EQ(video_transceiver->mid(),
331 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700332 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
333 callee->pc()->GetTransceivers()[0]->receiver()->streams();
334 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
335 callee->pc()->GetTransceivers()[1]->receiver()->streams();
336 ASSERT_EQ(0u, audio_streams.size());
337 ASSERT_EQ(2u, video_streams.size());
338 EXPECT_EQ(kStreamId1, video_streams[0]->id());
339 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-16 16:14:42 -0800340}
341
342// Test that doing additional offer/answer exchanges with no changes to tracks
343// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 15:30:18 -0700344TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
345 auto caller = CreatePeerConnection();
346 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800347
348 caller->AddAudioTrack("audio");
349 callee->AddAudioTrack("audio");
350
351 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
352 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
353 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
354
355 // If caller reoffers with no changes expect no additional OnTrack calls.
356 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
357 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
358 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
359
360 // Also if callee reoffers with no changes expect no additional OnTrack calls.
361 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
362 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
363 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
364}
365
366// Test that OnTrack is called when the transceiver direction changes to send
367// the track.
Steve Anton3172c032018-05-03 15:30:18 -0700368TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
369 auto caller = CreatePeerConnection();
370 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800371
372 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
373 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
374 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
375 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
376 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
377
378 transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
379 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
380 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
381 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
382
383 // If the direction changes but it is still receiving on the remote side, then
384 // OnTrack should not be fired again.
385 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
386 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
387 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
388 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
389}
390
391// Test that OnTrack is called twice when a sendrecv call is started, the callee
392// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -0700393TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
394 auto caller = CreatePeerConnection();
395 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800396
397 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
398
399 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
400 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
401 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
402
403 // Put the call on hold by no longer receiving the track.
404 callee->pc()->GetTransceivers()[0]->SetDirection(
405 RtpTransceiverDirection::kInactive);
406
407 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
408 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
409 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
410
411 // Resume the call by changing the direction to recvonly. This should call
412 // OnTrack again on the callee side.
413 callee->pc()->GetTransceivers()[0]->SetDirection(
414 RtpTransceiverDirection::kRecvOnly);
415
416 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
417 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
418 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
419}
420
Steve Anton3172c032018-05-03 15:30:18 -0700421// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 14:25:36 -0700422// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 15:30:18 -0700423TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700424 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 17:48:32 +0100425 auto caller = CreatePeerConnection();
426 auto callee = CreatePeerConnection();
427
Steve Anton3172c032018-05-03 15:30:18 -0700428 caller->AddAudioTrack("audio_track", {});
429
Amit Hilbuchae3df542019-01-07 12:13:08 -0800430 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700431 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
432
Amit Hilbuchae3df542019-01-07 12:13:08 -0800433 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton0f5400a2018-07-17 14:25:36 -0700434 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700435}
436
437// Test that setting a remote offer twice with no answer in the middle and the
438// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 14:25:36 -0700439// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 15:30:18 -0700440TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700441 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 15:30:18 -0700442 auto caller = CreatePeerConnection();
443 auto callee = CreatePeerConnection();
444
445 auto sender = caller->AddAudioTrack("audio_track", {});
446
Amit Hilbuchae3df542019-01-07 12:13:08 -0800447 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700448 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700449 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700450
451 caller->pc()->RemoveTrack(sender);
452
Amit Hilbuchae3df542019-01-07 12:13:08 -0800453 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700454 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700455 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
456}
457
458// Test that changing the direction from receiving to not receiving between
459// setting the remote offer and creating / setting the local answer results in
460// a remove track event when SetLocalDescription is called.
461TEST_F(PeerConnectionRtpTestUnifiedPlan,
462 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
463 auto caller = CreatePeerConnection();
464 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
465 auto callee = CreatePeerConnection();
466 callee->AddAudioTrack("audio_track", {});
467
468 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
469 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700470 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700471
472 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
473 callee_transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
474
475 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
476 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
477 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700478}
479
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100480TEST_F(PeerConnectionRtpTestUnifiedPlan, ChangeMsidWhileReceiving) {
481 auto caller = CreatePeerConnection();
482 caller->AddAudioTrack("audio_track", {"stream1"});
483 auto callee = CreatePeerConnection();
Amit Hilbuchae3df542019-01-07 12:13:08 -0800484 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100485
486 ASSERT_EQ(1u, callee->observer()->on_track_transceivers_.size());
487 auto transceiver = callee->observer()->on_track_transceivers_[0];
488 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
489 EXPECT_EQ("stream1", transceiver->receiver()->streams()[0]->id());
490
Amit Hilbuchae3df542019-01-07 12:13:08 -0800491 ASSERT_TRUE(callee->CreateAnswerAndSetAsLocal());
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100492
493 // Change the stream ID in the offer.
Guido Urdaneta1ff16c82019-05-20 19:31:53 +0200494 caller->pc()->GetSenders()[0]->SetStreams({"stream2"});
495 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100496 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
497 EXPECT_EQ("stream2", transceiver->receiver()->streams()[0]->id());
498}
499
Steve Anton3172c032018-05-03 15:30:18 -0700500// These tests examine the state of the peer connection as a result of
501// performing SetRemoteDescription().
502
503TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
504 auto caller = CreatePeerConnection();
505 auto callee = CreatePeerConnection();
506
507 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700508 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100509
510 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
511 auto receiver_added = callee->pc()->GetReceivers()[0];
512 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 15:30:18 -0700513
514 if (sdp_semantics_ == SdpSemantics::kPlanB) {
515 // Since we are not supporting the no stream case with Plan B, there should
516 // be a generated stream, even though we didn't set one with AddTrack.
517 ASSERT_EQ(1u, receiver_added->streams().size());
518 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
519 } else {
520 EXPECT_EQ(0u, receiver_added->streams().size());
521 }
Henrik Boström31638672017-11-23 17:48:32 +0100522}
523
Steve Anton3172c032018-05-03 15:30:18 -0700524TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100525 auto caller = CreatePeerConnection();
526 auto callee = CreatePeerConnection();
527
Steve Anton3172c032018-05-03 15:30:18 -0700528 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700529 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100530
531 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
532 auto receiver_added = callee->pc()->GetReceivers()[0];
533 EXPECT_EQ("audio_track", receiver_added->track()->id());
534 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700535 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 17:48:32 +0100536 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
537}
538
Steve Anton3172c032018-05-03 15:30:18 -0700539TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100540 auto caller = CreatePeerConnection();
541 auto callee = CreatePeerConnection();
542
Steve Anton3172c032018-05-03 15:30:18 -0700543 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100544 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700545 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
546
Henrik Boström31638672017-11-23 17:48:32 +0100547 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
548 auto receiver = callee->pc()->GetReceivers()[0];
549 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700550 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100551
Steve Anton3172c032018-05-03 15:30:18 -0700552 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
553 // With Unified Plan the receiver stays but the transceiver transitions to
554 // inactive.
555 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
556 EXPECT_EQ(RtpTransceiverDirection::kInactive,
557 callee->pc()->GetTransceivers()[0]->current_direction());
558 } else {
559 // With Plan B the receiver is removed.
560 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
561 }
Henrik Boström31638672017-11-23 17:48:32 +0100562}
563
Steve Anton3172c032018-05-03 15:30:18 -0700564TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100565 auto caller = CreatePeerConnection();
566 auto callee = CreatePeerConnection();
567
Steve Anton3172c032018-05-03 15:30:18 -0700568 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100569 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700570 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100571 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
572 auto receiver = callee->pc()->GetReceivers()[0];
573 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700574 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100575
Steve Anton3172c032018-05-03 15:30:18 -0700576 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
577 // With Unified Plan the receiver stays but the transceiver transitions to
578 // inactive.
579 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
580 EXPECT_EQ(RtpTransceiverDirection::kInactive,
581 callee->pc()->GetTransceivers()[0]->current_direction());
582 } else {
583 // With Plan B the receiver is removed.
584 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
585 }
Henrik Boström31638672017-11-23 17:48:32 +0100586}
587
Steve Anton3172c032018-05-03 15:30:18 -0700588TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100589 auto caller = CreatePeerConnection();
590 auto callee = CreatePeerConnection();
591
Seth Hampson845e8782018-03-02 11:34:10 -0800592 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700593 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
594 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
595 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
596 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 17:48:32 +0100597
598 // Remove "audio_track1".
599 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Steve Anton3172c032018-05-03 15:30:18 -0700600 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
601
602 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
603 // With Unified Plan the receiver stays but the transceiver transitions to
604 // inactive.
605 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
606 auto transceiver = callee->pc()->GetTransceivers()[0];
607 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
608 EXPECT_EQ(RtpTransceiverDirection::kInactive,
609 transceiver->current_direction());
610 } else {
611 // With Plan B the receiver is removed.
612 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
613 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
614 }
Henrik Boström31638672017-11-23 17:48:32 +0100615
616 // Remove "audio_track2".
617 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Steve Anton3172c032018-05-03 15:30:18 -0700618 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
619
620 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
621 // With Unified Plan the receiver stays but the transceiver transitions to
622 // inactive.
623 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
624 auto transceiver = callee->pc()->GetTransceivers()[1];
625 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
626 EXPECT_EQ(RtpTransceiverDirection::kInactive,
627 transceiver->current_direction());
628 } else {
629 // With Plan B the receiver is removed.
630 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
631 }
Henrik Boström31638672017-11-23 17:48:32 +0100632}
633
Florent Castelliabe301f2018-06-12 18:33:49 +0200634TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
635 auto caller = CreatePeerConnection();
636 auto callee = CreatePeerConnection();
637 auto sender = caller->AddAudioTrack("audio_track");
638 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
639
640 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
641 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
642
643 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
644 auto receiver = callee->pc()->GetReceivers()[0];
645 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
646}
647
648TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
649 auto caller = CreatePeerConnection();
650 auto callee = CreatePeerConnection();
651 auto sender = caller->AddVideoTrack("video_track");
652 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
653
654 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
655 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
656
657 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
658 auto receiver = callee->pc()->GetReceivers()[0];
659 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
660}
661
Henrik Boström31638672017-11-23 17:48:32 +0100662// Invokes SetRemoteDescription() twice in a row without synchronizing the two
663// calls and examine the state of the peer connection inside the callbacks to
664// ensure that the second call does not occur prematurely, contaminating the
665// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 15:30:18 -0700666TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 17:48:32 +0100667 StatesCorrelateWithSetRemoteDescriptionCall) {
668 auto caller = CreatePeerConnection();
669 auto callee = CreatePeerConnection();
670
Henrik Boström31638672017-11-23 17:48:32 +0100671 // Create SDP for adding a track and for removing it. This will be used in the
672 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 15:30:18 -0700673 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100674 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
675 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
676 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
677
678 // In the first SetRemoteDescription() callback, check that we have a
679 // receiver for the track.
680 auto pc = callee->pc();
681 bool srd1_callback_called = false;
682 auto srd1_callback = [&srd1_callback_called, &pc]() {
683 EXPECT_EQ(pc->GetReceivers().size(), 1u);
684 srd1_callback_called = true;
685 };
686
687 // In the second SetRemoteDescription() callback, check that the receiver has
688 // been removed.
689 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
690 // Instead, the transceiver owning the receiver will become inactive.
691 // https://crbug.com/webrtc/7600
692 bool srd2_callback_called = false;
693 auto srd2_callback = [&srd2_callback_called, &pc]() {
694 EXPECT_TRUE(pc->GetReceivers().empty());
695 srd2_callback_called = true;
696 };
697
698 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
699 // calls. The callbacks verify that the two calls are synchronized, as in, the
700 // effects of the second SetRemoteDescription() call must not have happened by
701 // the time the first callback is invoked. If it has then the receiver that is
702 // added as a result of the first SetRemoteDescription() call will already
703 // have been removed as a result of the second SetRemoteDescription() call
704 // when the first callback is invoked.
705 callee->pc()->SetRemoteDescription(
706 std::move(srd1_sdp),
707 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
708 callee->pc()->SetRemoteDescription(
709 std::move(srd2_sdp),
710 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
711 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
712 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
713}
714
Seth Hampson5897a6e2018-04-03 11:16:33 -0700715// Tests that a remote track is created with the signaled MSIDs when they are
716// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
717// lines).
Steve Anton3172c032018-05-03 15:30:18 -0700718TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
719 auto caller = CreatePeerConnection();
720 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 11:16:33 -0700721 const char kStreamId1[] = "stream1";
722 const char kStreamId2[] = "stream2";
723 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
724 {kStreamId1, kStreamId2});
725
726 auto offer = caller->CreateOfferAndSetAsLocal();
727 // Munge the offer to take out everything but the stream_ids.
728 auto contents = offer->description()->contents();
729 ASSERT_TRUE(!contents.empty());
730 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
731 std::vector<std::string> stream_ids =
732 contents[0].media_description()->streams()[0].stream_ids();
733 contents[0].media_description()->mutable_streams().clear();
734 cricket::StreamParams new_stream;
735 new_stream.set_stream_ids(stream_ids);
736 contents[0].media_description()->AddStream(new_stream);
737
738 // Set the remote description and verify that the streams were added to the
739 // receiver correctly.
740 ASSERT_TRUE(
741 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
742 auto receivers = callee->pc()->GetReceivers();
743 ASSERT_EQ(receivers.size(), 1u);
744 ASSERT_EQ(receivers[0]->streams().size(), 2u);
745 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
746 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
747}
748
Seth Hampson5b4f0752018-04-02 16:31:36 -0700749// Tests that with Unified Plan if the the stream id changes for a track when
750// when setting a new remote description, that the media stream is updated
751// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 14:25:36 -0700752// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
753// test.
754TEST_F(PeerConnectionRtpTestUnifiedPlan,
755 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700756 auto caller = CreatePeerConnection();
757 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 16:31:36 -0700758
759 const char kStreamId1[] = "stream1";
760 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 14:25:36 -0700761 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700762 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700763 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
764
765 // Change the stream id of the sender in the session description.
766 auto offer = caller->CreateOfferAndSetAsLocal();
767 auto contents = offer->description()->contents();
768 ASSERT_EQ(contents.size(), 1u);
769 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
770 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
771 {kStreamId2});
772
Steve Anton0f5400a2018-07-17 14:25:36 -0700773 // Set the remote description and verify that the stream was updated
774 // properly.
775 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700776 auto receivers = callee->pc()->GetReceivers();
777 ASSERT_EQ(receivers.size(), 1u);
778 ASSERT_EQ(receivers[0]->streams().size(), 1u);
779 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
780}
781
782// This tests a regression caught by a downstream client, that occured when
783// applying a remote description with a SessionDescription object that
784// contained StreamParams that didn't have ids. Although there were multiple
785// remote audio senders, FindSenderInfo didn't find them as unique, because
786// it looked up by StreamParam.id, which none had. This meant only one
787// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 15:30:18 -0700788TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700789 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
790 auto caller = CreatePeerConnection();
791 auto callee = CreatePeerConnection();
792
793 const char kStreamId1[] = "stream1";
794 const char kStreamId2[] = "stream2";
795 caller->AddAudioTrack("audio_track1", {kStreamId1});
796 caller->AddAudioTrack("audio_track2", {kStreamId2});
797
798 auto offer = caller->CreateOfferAndSetAsLocal();
799 auto mutable_streams =
800 cricket::GetFirstAudioContentDescription(offer->description())
801 ->mutable_streams();
802 ASSERT_EQ(mutable_streams.size(), 2u);
803 // Clear the IDs in the StreamParams.
804 mutable_streams[0].id.clear();
805 mutable_streams[1].id.clear();
806 ASSERT_TRUE(
807 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
808
809 auto receivers = callee->pc()->GetReceivers();
810 ASSERT_EQ(receivers.size(), 2u);
811 ASSERT_EQ(receivers[0]->streams().size(), 1u);
812 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
813 ASSERT_EQ(receivers[1]->streams().size(), 1u);
814 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
815}
816
Henrik Boström31638672017-11-23 17:48:32 +0100817// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 17:48:32 +0100818
819// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 15:30:18 -0700820TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 17:48:32 +0100821 auto caller = CreatePeerConnection();
822 auto callee = CreatePeerConnection();
823
824 std::string error;
825 ASSERT_TRUE(
826 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
827}
828
829// Verifies legacy behavior: The observer is not called if if the peer
830// connection is destroyed because the asynchronous callback is executed in the
831// peer connection's message handler.
Steve Anton3172c032018-05-03 15:30:18 -0700832TEST_P(PeerConnectionRtpTest,
833 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 17:48:32 +0100834 auto caller = CreatePeerConnection();
835 auto callee = CreatePeerConnection();
836
837 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
838 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
839
840 auto offer = caller->CreateOfferAndSetAsLocal();
841 callee->pc()->SetRemoteDescription(observer, offer.release());
842 callee = nullptr;
843 rtc::Thread::Current()->ProcessMessages(0);
844 EXPECT_FALSE(observer->called());
845}
846
Steve Antonf9381f02017-12-14 10:23:57 -0800847// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800848
849// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 15:30:18 -0700850TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
851 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800852 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
853}
854
855// Test that a transceiver created with the audio kind has the correct initial
856// properties.
Steve Anton3172c032018-05-03 15:30:18 -0700857TEST_F(PeerConnectionRtpTestUnifiedPlan,
858 AddTransceiverHasCorrectInitProperties) {
859 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800860
861 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200862 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 13:01:52 -0800863 EXPECT_FALSE(transceiver->stopped());
864 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200865 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 13:01:52 -0800866}
867
868// Test that adding a transceiver with the audio kind creates an audio sender
869// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 15:30:18 -0700870TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800871 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700872 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800873
874 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 11:43:08 -0800875 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800876
877 ASSERT_TRUE(transceiver->sender());
878 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
879
880 ASSERT_TRUE(transceiver->receiver());
881 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
882
883 auto track = transceiver->receiver()->track();
884 ASSERT_TRUE(track);
885 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
886 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
887}
888
889// Test that adding a transceiver with the video kind creates an video sender
890// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 15:30:18 -0700891TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800892 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700893 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800894
895 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 11:43:08 -0800896 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800897
898 ASSERT_TRUE(transceiver->sender());
899 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
900
901 ASSERT_TRUE(transceiver->receiver());
902 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
903
904 auto track = transceiver->receiver()->track();
905 ASSERT_TRUE(track);
906 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
907 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
908}
909
910// Test that after a call to AddTransceiver, the transceiver shows in
911// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
912// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 15:30:18 -0700913TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
914 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800915
916 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
917 EXPECT_EQ(
918 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
919 caller->pc()->GetTransceivers());
920 EXPECT_EQ(
921 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
922 transceiver->sender()},
923 caller->pc()->GetSenders());
924 EXPECT_EQ(
925 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
926 transceiver->receiver()},
927 caller->pc()->GetReceivers());
928}
929
930// Test that the direction passed in through the AddTransceiver init parameter
931// is set in the returned transceiver.
Steve Anton3172c032018-05-03 15:30:18 -0700932TEST_F(PeerConnectionRtpTestUnifiedPlan,
933 AddTransceiverWithDirectionIsReflected) {
934 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800935
936 RtpTransceiverInit init;
937 init.direction = RtpTransceiverDirection::kSendOnly;
938 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
939 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
940}
941
Steve Anton9158ef62017-11-27 13:01:52 -0800942// Test that calling AddTransceiver with a track creates a transceiver which has
943// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 15:30:18 -0700944TEST_F(PeerConnectionRtpTestUnifiedPlan,
945 AddTransceiverWithTrackCreatesSenderWithTrack) {
946 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800947
948 auto audio_track = caller->CreateAudioTrack("audio track");
949 auto transceiver = caller->AddTransceiver(audio_track);
950
951 auto sender = transceiver->sender();
952 ASSERT_TRUE(sender->track());
953 EXPECT_EQ(audio_track, sender->track());
954
955 auto receiver = transceiver->receiver();
956 ASSERT_TRUE(receiver->track());
957 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
958 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
959 receiver->track()->state());
960}
961
962// Test that calling AddTransceiver twice with the same track creates distinct
963// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 15:30:18 -0700964TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800965 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 15:30:18 -0700966 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800967
968 auto audio_track = caller->CreateAudioTrack("audio track");
969
970 auto transceiver1 = caller->AddTransceiver(audio_track);
971 auto transceiver2 = caller->AddTransceiver(audio_track);
972
973 EXPECT_NE(transceiver1, transceiver2);
974
975 auto sender1 = transceiver1->sender();
976 auto sender2 = transceiver2->sender();
977 EXPECT_NE(sender1, sender2);
978 EXPECT_EQ(audio_track, sender1->track());
979 EXPECT_EQ(audio_track, sender2->track());
980
981 EXPECT_THAT(caller->pc()->GetTransceivers(),
982 UnorderedElementsAre(transceiver1, transceiver2));
983 EXPECT_THAT(caller->pc()->GetSenders(),
984 UnorderedElementsAre(sender1, sender2));
985}
986
Steve Anton3fe1b152017-12-12 10:20:08 -0800987// RtpTransceiver error handling tests.
988
Steve Anton3172c032018-05-03 15:30:18 -0700989TEST_F(PeerConnectionRtpTestUnifiedPlan,
990 AddTransceiverWithInvalidKindReturnsError) {
991 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800992
993 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
994 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
995}
996
Steve Anton3172c032018-05-03 15:30:18 -0700997TEST_F(PeerConnectionRtpTestUnifiedPlan,
998 CanClosePeerConnectionWithoutCrashing) {
999 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -08001000
1001 caller->pc()->Close();
1002}
1003
Steve Antonf9381f02017-12-14 10:23:57 -08001004// Unified Plan AddTrack tests.
1005
Steve Antonf9381f02017-12-14 10:23:57 -08001006// Test that adding an audio track creates a new audio RtpSender with the given
1007// track.
Steve Anton3172c032018-05-03 15:30:18 -07001008TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
1009 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001010
1011 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001012 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001013 ASSERT_TRUE(sender);
1014
1015 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
1016 EXPECT_EQ(audio_track, sender->track());
1017}
1018
1019// Test that adding a video track creates a new video RtpSender with the given
1020// track.
Steve Anton3172c032018-05-03 15:30:18 -07001021TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
1022 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001023
1024 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001025 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001026 ASSERT_TRUE(sender);
1027
1028 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
1029 EXPECT_EQ(video_track, sender->track());
1030}
1031
1032// Test that adding a track to a new PeerConnection creates an RtpTransceiver
1033// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 15:30:18 -07001034TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
1035 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001036
1037 auto sender = caller->AddAudioTrack("a");
1038 ASSERT_TRUE(sender);
1039
1040 auto transceivers = caller->pc()->GetTransceivers();
1041 ASSERT_EQ(1u, transceivers.size());
1042 EXPECT_EQ(sender, transceivers[0]->sender());
1043 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
1044}
1045
1046// Test that if a transceiver of the same type but no track had been added to
1047// the PeerConnection and later a call to AddTrack is made, the resulting sender
1048// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 15:30:18 -07001049TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1050 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001051
1052 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1053 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001054 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001055 ASSERT_TRUE(sender);
1056
1057 auto transceivers = caller->pc()->GetTransceivers();
1058 ASSERT_EQ(1u, transceivers.size());
1059 EXPECT_EQ(transceiver, transceivers[0]);
1060 EXPECT_EQ(sender, transceiver->sender());
1061 EXPECT_EQ(audio_track, sender->track());
1062}
1063
1064// Test that adding two tracks to a new PeerConnection creates two
1065// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 15:30:18 -07001066TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1067 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001068
1069 auto sender1 = caller->AddAudioTrack("a");
1070 auto sender2 = caller->AddVideoTrack("v");
1071 ASSERT_TRUE(sender2);
1072
1073 auto transceivers = caller->pc()->GetTransceivers();
1074 ASSERT_EQ(2u, transceivers.size());
1075 EXPECT_EQ(sender1, transceivers[0]->sender());
1076 EXPECT_EQ(sender2, transceivers[1]->sender());
1077}
1078
1079// Test that if there are multiple transceivers with no sending track then a
1080// later call to AddTrack will use the one of the same type as the newly-added
1081// track.
Steve Anton3172c032018-05-03 15:30:18 -07001082TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1083 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001084
1085 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1086 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1087 auto sender = caller->AddVideoTrack("v");
1088
1089 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1090 EXPECT_NE(sender, audio_transceiver->sender());
1091 EXPECT_EQ(sender, video_transceiver->sender());
1092}
1093
1094// Test that if the only transceivers that do not have a sending track have a
1095// different type from the added track, then AddTrack will create a new
1096// transceiver for the track.
Steve Anton3172c032018-05-03 15:30:18 -07001097TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001098 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 15:30:18 -07001099 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001100
1101 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1102 auto sender = caller->AddVideoTrack("v");
1103
1104 auto transceivers = caller->pc()->GetTransceivers();
1105 ASSERT_EQ(2u, transceivers.size());
1106 EXPECT_NE(sender, transceivers[0]->sender());
1107 EXPECT_EQ(sender, transceivers[1]->sender());
1108}
1109
1110// Test that the first available transceiver is reused by AddTrack when multiple
1111// are available.
Steve Anton3172c032018-05-03 15:30:18 -07001112TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001113 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001114 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001115
1116 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1117 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1118 auto sender = caller->AddAudioTrack("a");
1119
1120 auto transceivers = caller->pc()->GetTransceivers();
1121 ASSERT_EQ(2u, transceivers.size());
1122 EXPECT_EQ(sender, transceivers[0]->sender());
1123 EXPECT_NE(sender, transceivers[1]->sender());
1124}
1125
1126// Test that a call to AddTrack that reuses a transceiver will change the
1127// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 15:30:18 -07001128TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001129 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001130 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001131 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001132
1133 RtpTransceiverInit init;
1134 init.direction = RtpTransceiverDirection::kInactive;
1135 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001136 EXPECT_TRUE(caller->observer()->negotiation_needed());
Steve Antonf9381f02017-12-14 10:23:57 -08001137
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001138 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Steve Antonf9381f02017-12-14 10:23:57 -08001139 caller->observer()->clear_negotiation_needed();
1140 ASSERT_TRUE(caller->AddAudioTrack("a"));
1141 EXPECT_TRUE(caller->observer()->negotiation_needed());
1142
1143 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1144}
1145
1146// Test that a call to AddTrack that reuses a transceiver will change the
1147// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -07001148TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001149 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 15:30:18 -07001150 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001151 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001152
1153 RtpTransceiverInit init;
1154 init.direction = RtpTransceiverDirection::kRecvOnly;
1155 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001156 EXPECT_TRUE(caller->observer()->negotiation_needed());
Steve Antonf9381f02017-12-14 10:23:57 -08001157
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001158 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Steve Antonf9381f02017-12-14 10:23:57 -08001159 caller->observer()->clear_negotiation_needed();
1160 ASSERT_TRUE(caller->AddAudioTrack("a"));
1161 EXPECT_TRUE(caller->observer()->negotiation_needed());
1162
1163 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1164}
1165
Steve Anton3172c032018-05-03 15:30:18 -07001166TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-10 16:26:06 -08001167 const std::string kTrackId = "audio_track";
1168
Steve Anton3172c032018-05-03 15:30:18 -07001169 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-10 16:26:06 -08001170
1171 auto audio_track = caller->CreateAudioTrack(kTrackId);
1172 auto sender = caller->AddTrack(audio_track);
1173
1174 EXPECT_EQ(kTrackId, sender->id());
1175}
1176
Steve Antonf9381f02017-12-14 10:23:57 -08001177// Unified Plan AddTrack error handling.
1178
Steve Anton3172c032018-05-03 15:30:18 -07001179TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1180 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001181
1182 auto audio_track = caller->CreateAudioTrack("a");
1183 caller->pc()->Close();
1184
1185 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001186 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001187 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001188 EXPECT_FALSE(caller->observer()->negotiation_needed());
1189}
1190
Steve Anton3172c032018-05-03 15:30:18 -07001191TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1192 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001193
1194 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001195 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -08001196
1197 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001198 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001199 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001200 EXPECT_FALSE(caller->observer()->negotiation_needed());
1201}
1202
1203// Unified Plan RemoveTrack tests.
1204
1205// Test that calling RemoveTrack on a sender with a previously-added track
1206// clears the sender's track.
Steve Anton3172c032018-05-03 15:30:18 -07001207TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1208 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001209
1210 auto sender = caller->AddAudioTrack("a");
1211 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1212
1213 EXPECT_FALSE(sender->track());
1214}
1215
1216// Test that calling RemoveTrack on a sender where the transceiver is configured
1217// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 15:30:18 -07001218TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001219 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001220 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001221 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001222
1223 RtpTransceiverInit init;
1224 init.direction = RtpTransceiverDirection::kSendRecv;
1225 auto transceiver =
1226 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001227 EXPECT_TRUE(caller->observer()->negotiation_needed());
Steve Antonf9381f02017-12-14 10:23:57 -08001228
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001229 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Steve Antonf9381f02017-12-14 10:23:57 -08001230 caller->observer()->clear_negotiation_needed();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001231
Steve Antonf9381f02017-12-14 10:23:57 -08001232 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1233 EXPECT_TRUE(caller->observer()->negotiation_needed());
1234
1235 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
Steve Antonf9381f02017-12-14 10:23:57 -08001236}
1237
1238// Test that calling RemoveTrack on a sender where the transceiver is configured
1239// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 15:30:18 -07001240TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001241 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 15:30:18 -07001242 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001243 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001244
1245 RtpTransceiverInit init;
1246 init.direction = RtpTransceiverDirection::kSendOnly;
1247 auto transceiver =
1248 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001249 EXPECT_TRUE(caller->observer()->negotiation_needed());
Steve Antonf9381f02017-12-14 10:23:57 -08001250
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001251 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Steve Antonf9381f02017-12-14 10:23:57 -08001252 caller->observer()->clear_negotiation_needed();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001253
Steve Antonf9381f02017-12-14 10:23:57 -08001254 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1255 EXPECT_TRUE(caller->observer()->negotiation_needed());
1256
1257 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1258}
1259
1260// Test that calling RemoveTrack with a sender that has a null track results in
1261// no change in state.
Steve Anton3172c032018-05-03 15:30:18 -07001262TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1263 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001264
1265 auto sender = caller->AddAudioTrack("a");
1266 auto transceiver = caller->pc()->GetTransceivers()[0];
1267 ASSERT_TRUE(sender->SetTrack(nullptr));
1268
1269 caller->observer()->clear_negotiation_needed();
1270 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1271 EXPECT_FALSE(caller->observer()->negotiation_needed());
1272
1273 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1274}
1275
1276// Unified Plan RemoveTrack error handling.
1277
Steve Anton3172c032018-05-03 15:30:18 -07001278TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1279 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001280
1281 auto sender = caller->AddAudioTrack("a");
1282 caller->pc()->Close();
1283
1284 caller->observer()->clear_negotiation_needed();
1285 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
1286 EXPECT_FALSE(caller->observer()->negotiation_needed());
1287}
1288
Steve Anton3172c032018-05-03 15:30:18 -07001289TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001290 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 15:30:18 -07001291 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001292
1293 auto sender = caller->AddAudioTrack("a");
1294 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1295
1296 caller->observer()->clear_negotiation_needed();
1297 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
1298 EXPECT_FALSE(caller->observer()->negotiation_needed());
1299}
1300
Steve Anton60b6c1d2018-06-13 11:32:27 -07001301// Test that setting offers that add/remove/add a track repeatedly without
1302// setting the appropriate answer in between works.
1303// These are regression tests for bugs.webrtc.org/9401
1304TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1305 auto caller = CreatePeerConnection();
1306
1307 auto sender1 = caller->AddAudioTrack("audio1");
1308 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1309
1310 caller->pc()->RemoveTrack(sender1);
1311 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1312
1313 // This will re-use the transceiver created by the first AddTrack.
1314 auto sender2 = caller->AddAudioTrack("audio2");
1315 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1316
1317 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1318 EXPECT_EQ(sender1, sender2);
1319}
1320TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1321 auto caller = CreatePeerConnection();
1322
1323 auto sender1 = caller->AddVideoTrack("video1");
1324 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1325
1326 caller->pc()->RemoveTrack(sender1);
1327 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1328
1329 // This will re-use the transceiver created by the first AddTrack.
1330 auto sender2 = caller->AddVideoTrack("video2");
1331 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1332
1333 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1334 EXPECT_EQ(sender1, sender2);
1335}
1336
Steve Anton07563732018-06-26 11:13:50 -07001337// Test that CreateOffer succeeds if two tracks with the same label are added.
1338TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1339 auto caller = CreatePeerConnection();
1340
1341 auto audio_sender = caller->AddAudioTrack("track", {});
1342 auto video_sender = caller->AddVideoTrack("track", {});
1343
1344 EXPECT_TRUE(caller->CreateOffer());
1345
1346 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1347 EXPECT_NE(audio_sender->id(), video_sender->id());
1348}
1349
1350// Test that CreateAnswer succeeds if two tracks with the same label are added.
1351TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1352 auto caller = CreatePeerConnection();
1353 auto callee = CreatePeerConnection();
1354
1355 RtpTransceiverInit recvonly;
1356 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1357 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1358 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1359
1360 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1361
1362 auto audio_sender = callee->AddAudioTrack("track", {});
1363 auto video_sender = callee->AddVideoTrack("track", {});
1364
1365 EXPECT_TRUE(callee->CreateAnswer());
1366
1367 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1368 EXPECT_NE(audio_sender->id(), video_sender->id());
1369}
1370
1371// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1372// m= section with a random sender id (different from the first, now rejected,
1373// m= section).
1374TEST_F(PeerConnectionRtpTestUnifiedPlan,
1375 AddRemoveAddTrackGeneratesNewSenderId) {
1376 auto caller = CreatePeerConnection();
1377 auto callee = CreatePeerConnection();
1378
1379 auto track = caller->CreateVideoTrack("video");
1380 auto sender1 = caller->AddTrack(track);
1381 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1382
1383 caller->pc()->RemoveTrack(sender1);
1384 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1385
1386 auto sender2 = caller->AddTrack(track);
1387
1388 EXPECT_NE(sender1, sender2);
1389 EXPECT_NE(sender1->id(), sender2->id());
1390 std::string sender2_id = sender2->id();
1391
1392 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1393
1394 // The sender's ID should not change after negotiation.
1395 EXPECT_EQ(sender2_id, sender2->id());
1396}
1397
Steve Anton52d86772018-02-20 15:48:12 -08001398// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1399// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 15:30:18 -07001400TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001401 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001402 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001403 auto callee = CreatePeerConnection();
1404 EXPECT_FALSE(caller->observer()->negotiation_needed());
Steve Anton52d86772018-02-20 15:48:12 -08001405
1406 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001407 EXPECT_TRUE(caller->observer()->negotiation_needed());
Steve Anton52d86772018-02-20 15:48:12 -08001408
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001409 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Steve Anton52d86772018-02-20 15:48:12 -08001410 caller->observer()->clear_negotiation_needed();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001411
Steve Anton52d86772018-02-20 15:48:12 -08001412 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1413 EXPECT_TRUE(caller->observer()->negotiation_needed());
1414}
1415
1416// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1417// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 15:30:18 -07001418TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001419 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001420 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001421
1422 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1423
1424 caller->observer()->clear_negotiation_needed();
1425 transceiver->SetDirection(transceiver->direction());
1426 EXPECT_FALSE(caller->observer()->negotiation_needed());
1427}
1428
1429// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1430// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001431TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001432 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001433 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001434
1435 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1436 transceiver->Stop();
1437
1438 caller->observer()->clear_negotiation_needed();
1439 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1440 EXPECT_FALSE(caller->observer()->negotiation_needed());
1441}
1442
Florent Castelli892acf02018-10-01 22:47:20 +02001443// Test that AddTransceiver fails if trying to use unimplemented RTP encoding
1444// parameters with the send_encodings parameters.
1445TEST_F(PeerConnectionRtpTestUnifiedPlan,
1446 CheckForUnsupportedEncodingParameters) {
1447 auto caller = CreatePeerConnection();
1448
1449 RtpTransceiverInit init;
1450 init.send_encodings.emplace_back();
1451
1452 auto default_send_encodings = init.send_encodings;
1453
Henrik Grunelle1301a82018-12-13 12:13:22 +00001454 // Unimplemented RtpParameters: ssrc, codec_payload_type, fec, rtx, dtx,
Amit Hilbuchaa584152019-02-06 17:09:52 -08001455 // ptime, scale_framerate_down_by, dependency_rids.
Florent Castelli892acf02018-10-01 22:47:20 +02001456 init.send_encodings[0].ssrc = 1;
1457 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1458 caller->pc()
1459 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1460 .error()
1461 .type());
1462 init.send_encodings = default_send_encodings;
Florent Castelli892acf02018-10-01 22:47:20 +02001463}
1464
Florent Castellic1a0bcb2019-01-29 14:26:48 +01001465// Test that AddTransceiver fails if trying to use invalid RTP encoding
1466// parameters with the send_encodings parameters.
1467TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForInvalidEncodingParameters) {
1468 auto caller = CreatePeerConnection();
1469
1470 RtpTransceiverInit init;
1471 init.send_encodings.emplace_back();
1472
1473 auto default_send_encodings = init.send_encodings;
1474
1475 init.send_encodings[0].scale_resolution_down_by = 0.5;
1476 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1477 caller->pc()
1478 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1479 .error()
1480 .type());
1481 init.send_encodings = default_send_encodings;
1482
1483 init.send_encodings[0].bitrate_priority = 0;
1484 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1485 caller->pc()
1486 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1487 .error()
1488 .type());
1489 init.send_encodings = default_send_encodings;
1490
1491 init.send_encodings[0].min_bitrate_bps = 200000;
1492 init.send_encodings[0].max_bitrate_bps = 100000;
1493 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1494 caller->pc()
1495 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1496 .error()
1497 .type());
1498 init.send_encodings = default_send_encodings;
1499
1500 init.send_encodings[0].num_temporal_layers = 0;
1501 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1502 caller->pc()
1503 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1504 .error()
1505 .type());
1506 init.send_encodings = default_send_encodings;
1507
1508 init.send_encodings[0].num_temporal_layers = 5;
1509 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1510 caller->pc()
1511 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1512 .error()
1513 .type());
1514 init.send_encodings = default_send_encodings;
1515}
1516
Florent Castelli892acf02018-10-01 22:47:20 +02001517// Test that AddTransceiver transfers the send_encodings to the sender and they
1518// are retained after SetLocalDescription().
1519TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) {
1520 auto caller = CreatePeerConnection();
1521
1522 RtpTransceiverInit init;
1523 init.send_encodings.emplace_back();
1524 init.send_encodings[0].active = false;
1525 init.send_encodings[0].max_bitrate_bps = 180000;
1526
1527 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1528 ASSERT_TRUE(result.ok());
1529
1530 auto init_send_encodings = result.value()->sender()->init_send_encodings();
1531 EXPECT_FALSE(init_send_encodings[0].active);
1532 EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000);
1533
1534 auto parameters = result.value()->sender()->GetParameters();
1535 EXPECT_FALSE(parameters.encodings[0].active);
1536 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1537
1538 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1539
1540 parameters = result.value()->sender()->GetParameters();
1541 EXPECT_FALSE(parameters.encodings[0].active);
1542 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1543}
1544
Steve Antone831b8c2018-02-01 12:22:16 -08001545// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1546// options for this kind of signaling: media section based (a=msid) and ssrc
1547// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1548// we want to ensure compatibility with older Plan B endpoints that might expect
1549// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1550// types but answers with the same type as the offer.
1551
Steve Anton3172c032018-05-03 15:30:18 -07001552class PeerConnectionMsidSignalingTest
1553 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 12:22:16 -08001554
1555TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1556 auto caller = CreatePeerConnectionWithUnifiedPlan();
1557 caller->AddAudioTrack("caller_audio");
1558 auto callee = CreatePeerConnectionWithUnifiedPlan();
1559 callee->AddAudioTrack("callee_audio");
1560
1561 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1562
1563 // Offer should have had both a=msid and a=ssrc MSID lines.
1564 auto* offer = callee->pc()->remote_description();
1565 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1566 cricket::kMsidSignalingSsrcAttribute),
1567 offer->description()->msid_signaling());
1568
1569 // Answer should have had only a=msid lines.
1570 auto* answer = caller->pc()->remote_description();
1571 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1572 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 23:48:00 +01001573 // Check that this is counted correctly
Ying Wangef3998f2019-12-09 13:06:53 +01001574 EXPECT_METRIC_THAT(
1575 metrics::Samples("WebRTC.PeerConnection.SdpSemanticNegotiated"),
1576 ElementsAre(Pair(kSdpSemanticNegotiatedUnifiedPlan, 2)));
Steve Antone831b8c2018-02-01 12:22:16 -08001577}
1578
1579TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1580 auto caller = CreatePeerConnectionWithPlanB();
1581 caller->AddAudioTrack("caller_audio");
1582 auto callee = CreatePeerConnectionWithUnifiedPlan();
1583 callee->AddAudioTrack("callee_audio");
1584
1585 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1586
1587 // Offer should have only a=ssrc MSID lines.
1588 auto* offer = callee->pc()->remote_description();
1589 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1590 offer->description()->msid_signaling());
1591
1592 // Answer should have only a=ssrc MSID lines to match the offer.
1593 auto* answer = caller->pc()->remote_description();
1594 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1595 answer->description()->msid_signaling());
1596}
1597
Seth Hampson5b4f0752018-04-02 16:31:36 -07001598// This tests that a Plan B endpoint appropriately sets the remote description
1599// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1600// that signal no stream ids or multiple stream ids we expect that the Plan B
1601// endpoint always has exactly one media stream per track.
1602TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1603 const std::string kStreamId1 = "audio_stream_1";
1604 const std::string kStreamId2 = "audio_stream_2";
1605
1606 auto caller = CreatePeerConnectionWithUnifiedPlan();
1607 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1608 caller->AddVideoTrack("caller_video", {});
1609 auto callee = CreatePeerConnectionWithPlanB();
1610 callee->AddAudioTrack("callee_audio");
1611 caller->AddVideoTrack("callee_video");
1612
1613 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1614
1615 // Offer should have had both a=msid and a=ssrc MSID lines.
1616 auto* offer = callee->pc()->remote_description();
1617 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1618 cricket::kMsidSignalingSsrcAttribute),
1619 offer->description()->msid_signaling());
1620
1621 // Callee should always have 1 stream for all of it's receivers.
1622 const auto& track_events = callee->observer()->add_track_events_;
1623 ASSERT_EQ(2u, track_events.size());
1624 ASSERT_EQ(1u, track_events[0].streams.size());
1625 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1626 ASSERT_EQ(1u, track_events[1].streams.size());
1627 // This autogenerated a stream id for the empty one signalled.
1628 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1629}
1630
Steve Antone831b8c2018-02-01 12:22:16 -08001631TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1632 auto caller = CreatePeerConnectionWithUnifiedPlan();
1633 caller->AddAudioTrack("caller_audio");
1634 auto callee = CreatePeerConnectionWithUnifiedPlan();
1635 callee->AddAudioTrack("callee_audio");
1636
1637 auto offer = caller->CreateOffer();
1638 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1639 // section only.
1640 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1641
1642 ASSERT_TRUE(
1643 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1644 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1645
1646 // Answer should have only a=msid to match the offer.
1647 auto answer = callee->CreateAnswer();
1648 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1649 answer->description()->msid_signaling());
1650}
1651
Steve Anton8e20f172018-03-06 10:55:04 -08001652// Test that the correct UMA metrics are reported for simple/complex SDP.
1653
Steve Anton3172c032018-05-03 15:30:18 -07001654class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 10:55:04 -08001655
1656#ifdef HAVE_SCTP
1657TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1658 auto caller = CreatePeerConnectionWithUnifiedPlan();
1659 caller->CreateDataChannel("dc");
1660 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001661
1662 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001663 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001664 EXPECT_METRIC_THAT(
1665 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1666 ElementsAre(Pair(kSdpFormatReceivedNoTracks, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001667}
1668#endif // HAVE_SCTP
1669
1670TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1671 auto caller = CreatePeerConnectionWithUnifiedPlan();
1672 caller->AddAudioTrack("audio");
1673 caller->AddVideoTrack("video");
1674 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001675
1676 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001677 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001678 EXPECT_METRIC_THAT(
1679 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1680 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001681}
1682
1683TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1684 auto caller = CreatePeerConnectionWithPlanB();
1685 caller->AddVideoTrack("video"); // Video only.
1686 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001687
1688 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Steve Antonc1e6e862019-03-04 14:43:44 -08001689 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001690 EXPECT_METRIC_THAT(
1691 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1692 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001693}
1694
1695TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1696 auto caller = CreatePeerConnectionWithUnifiedPlan();
1697 caller->AddAudioTrack("audio1");
1698 caller->AddAudioTrack("audio2");
1699 caller->AddVideoTrack("video");
1700 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001701
1702 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001703 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001704 EXPECT_METRIC_THAT(
1705 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1706 ElementsAre(Pair(kSdpFormatReceivedComplexUnifiedPlan, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001707}
1708
1709TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1710 auto caller = CreatePeerConnectionWithPlanB();
1711 caller->AddVideoTrack("video1");
1712 caller->AddVideoTrack("video2");
1713 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001714
Steve Antonba42e992018-04-09 14:10:01 -07001715 // This fails since Unified Plan cannot set a session description with
1716 // multiple "Plan B tracks" in the same media section. But we still expect the
1717 // SDP Format to be recorded.
1718 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001719 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001720 EXPECT_METRIC_THAT(
1721 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1722 ElementsAre(Pair(kSdpFormatReceivedComplexPlanB, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001723}
1724
Henrik Boström91d039b2018-01-11 17:43:30 +01001725// Sender setups in a call.
1726
Steve Anton3172c032018-05-03 15:30:18 -07001727TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 17:43:30 +01001728 auto caller = CreatePeerConnection();
1729 auto callee = CreatePeerConnection();
1730
1731 auto track = caller->CreateAudioTrack("audio_track");
1732 auto sender1 = caller->AddTrack(track);
1733 ASSERT_TRUE(sender1);
1734 // We need to temporarily reset the track for the subsequent AddTrack() to
1735 // succeed.
1736 EXPECT_TRUE(sender1->SetTrack(nullptr));
1737 auto sender2 = caller->AddTrack(track);
1738 EXPECT_TRUE(sender2);
1739 EXPECT_TRUE(sender1->SetTrack(track));
1740
Steve Anton3172c032018-05-03 15:30:18 -07001741 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1742 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
1743 // return true, and doing |callee->SetRemoteDescription()| should work.
1744 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
1745 } else {
1746 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
1747 }
Henrik Boström91d039b2018-01-11 17:43:30 +01001748}
1749
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001750// This test exercises the code path that fires a NegotiationNeeded
1751// notification when the stream IDs of the local description differ from
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02001752// the ones in the transceiver.
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001753TEST_F(PeerConnectionRtpTestUnifiedPlan,
1754 ChangeAssociatedStreamsTriggersRenegotiation) {
1755 auto caller = CreatePeerConnection();
1756 auto callee = CreatePeerConnection();
1757
1758 RtpTransceiverInit init;
1759 init.direction = RtpTransceiverDirection::kSendRecv;
1760 auto transceiver =
1761 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1762 EXPECT_TRUE(caller->observer()->negotiation_needed());
1763
1764 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1765 caller->observer()->clear_negotiation_needed();
1766
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02001767 transceiver->sender()->SetStreams({"stream3", "stream4", "stream5"});
Henrik Andreasssoncc189172019-05-20 09:01:38 +00001768 EXPECT_TRUE(caller->observer()->negotiation_needed());
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02001769
1770 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
1771 auto callee_streams = callee->pc()->GetReceivers()[0]->streams();
1772 ASSERT_EQ(3u, callee_streams.size());
1773 EXPECT_EQ("stream3", callee_streams[0]->id());
1774 EXPECT_EQ("stream4", callee_streams[1]->id());
1775 EXPECT_EQ("stream5", callee_streams[2]->id());
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001776}
1777
Mirko Bonadeic84f6612019-01-31 12:20:57 +01001778INSTANTIATE_TEST_SUITE_P(PeerConnectionRtpTest,
1779 PeerConnectionRtpTest,
1780 Values(SdpSemantics::kPlanB,
1781 SdpSemantics::kUnifiedPlan));
Steve Anton3172c032018-05-03 15:30:18 -07001782
Steve Anton9158ef62017-11-27 13:01:52 -08001783} // namespace webrtc