blob: be01fa4a67a7ec0270c8aaaf786caf6a4ef9980d [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
333 "ERROR: a/IBaz.aidl:1.47-51: 'out IBinder bar' can only be an in parameter.\n";
334 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700335 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700336 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900337}
338
Jiyong Park40782d02020-07-24 19:17:43 +0900339TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700340 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
341 const string expected_stderr =
342 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700343 CaptureStderr();
344 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
345 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900346}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700347
Jiyong Park40782d02020-07-24 19:17:43 +0900348TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700349 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900350 const string expected_stderr =
351 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700352 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700353 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700354 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700355}
356
Devin Moore7b8d5c92020-03-17 14:14:08 -0700357TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700358 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
359 const string expected_stderr =
360 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
361 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700362 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700363 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700364}
365
Devin Moore7b8d5c92020-03-17 14:14:08 -0700366TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700367 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
368 const string expected_stderr =
369 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
370 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700371 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700372 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800373}
374
Devin Moore2f2077a2020-08-28 11:27:53 -0700375TEST_P(AidlTest, AcceptNullableList) {
376 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
377 const string expected_stderr = "";
378 CaptureStderr();
379 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
380 EXPECT_EQ(expected_stderr, GetCapturedStderr());
381}
382
Devin Moore7b8d5c92020-03-17 14:14:08 -0700383TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700384 const string method = "package a; interface IFoo { void f(int a, int a); }";
385 const string expected_stderr =
386 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
387 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700388 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700389 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700390}
391
Jeongik Cha13066da2020-08-06 15:43:19 +0900392TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
393 const string method = "package a; parcelable Foo { int a; String a; }";
394 const string expected_stderr =
395 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
396 CaptureStderr();
397 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
399}
400
Jooyung Hand902a972020-10-23 17:32:44 +0900401TEST_P(AidlTest, RejectsRepeatedAnnotations) {
402 const string method = R"(@Hide @Hide parcelable Foo {})";
403 const string expected_stderr =
404 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
405 "Foo.aidl:1.1-6\n";
406 CaptureStderr();
407 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
408 EXPECT_EQ(expected_stderr, GetCapturedStderr());
409}
410
Devin Moore7b8d5c92020-03-17 14:14:08 -0700411TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700412 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
413 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
414 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700415 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700416 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100417}
418
Devin Moore7b8d5c92020-03-17 14:14:08 -0700419TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700420 AidlError error;
421 const string method = "package a; @nullable interface IFoo { int f(); }";
422 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800423 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900424 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700425 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700427 EXPECT_EQ(expected_stderr, GetCapturedStderr());
428 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800429}
430
Devin Moore7b8d5c92020-03-17 14:14:08 -0700431TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700432 AidlError error;
433 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
434 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800435 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900436 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700437 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700438 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700439 EXPECT_EQ(expected_stderr, GetCapturedStderr());
440 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800441}
442
Devin Moore7b8d5c92020-03-17 14:14:08 -0700443TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 AidlError error;
445 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
446 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000447 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900448 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900449 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700450 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000451 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700452 EXPECT_EQ(expected_stderr, GetCapturedStderr());
453 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800454}
455
Devin Moore7b8d5c92020-03-17 14:14:08 -0700456TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700457 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000458 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700459 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000460 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900461 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDebug, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700462 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700463 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000464 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700465 EXPECT_EQ(expected_stderr, GetCapturedStderr());
466 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800467}
468
Jiyong Park40782d02020-07-24 19:17:43 +0900469TEST_P(AidlTest, ParsesNonNullableAnnotation) {
470 auto parse_result =
471 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
472 ASSERT_NE(nullptr, parse_result);
473 const AidlInterface* interface = parse_result->AsInterface();
474 ASSERT_NE(nullptr, interface);
475 ASSERT_FALSE(interface->GetMethods().empty());
476 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
477}
478
Devin Moore7b8d5c92020-03-17 14:14:08 -0700479TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900480 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
481 typenames_, GetLanguage());
482 ASSERT_NE(nullptr, parse_result);
483 const AidlInterface* interface = parse_result->AsInterface();
484 ASSERT_NE(nullptr, interface);
485 ASSERT_FALSE(interface->GetMethods().empty());
486 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
487}
488
489TEST_P(AidlTest, ParsesNonUtf8Annotations) {
490 auto parse_result =
491 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
492 ASSERT_NE(nullptr, parse_result);
493 const AidlInterface* interface = parse_result->AsInterface();
494 ASSERT_NE(nullptr, interface);
495 ASSERT_FALSE(interface->GetMethods().empty());
496 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800497}
498
Devin Moore7b8d5c92020-03-17 14:14:08 -0700499TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900500 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
501 typenames_, GetLanguage());
502 ASSERT_NE(nullptr, parse_result);
503 const AidlInterface* interface = parse_result->AsInterface();
504 ASSERT_NE(nullptr, interface);
505 ASSERT_FALSE(interface->GetMethods().empty());
506 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800507}
508
Devin Moore7b8d5c92020-03-17 14:14:08 -0700509TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700510 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700511 const string expected_stderr =
512 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
513 "\"vintf\"'\n"
514 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
515 "--structured\n";
516 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700517 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700518 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700519 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700520 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521}
522
Devin Moore7b8d5c92020-03-17 14:14:08 -0700523TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700524 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700525 const string expected_stderr =
526 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
527 "--structured\n";
528 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700529 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700530 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700531 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700532 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533}
534
Devin Moore7b8d5c92020-03-17 14:14:08 -0700535TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700536 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700537 const string expected_stderr =
538 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
539 "\"vintf\"'\n";
540 CaptureStderr();
541 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700542 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700543 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700544 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545}
546
Devin Moore7b8d5c92020-03-17 14:14:08 -0700547TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700548 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700549 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
550 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700551 ASSERT_EQ(AidlError::OK, error);
552 ASSERT_NE(nullptr, parse_result);
553 const AidlInterface* interface = parse_result->AsInterface();
554 ASSERT_NE(nullptr, interface);
555 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700556}
557
Jeongik Cha64783ed2019-06-07 18:30:54 +0900558TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
559 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900560 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
561 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900562 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700563 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900564 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900565 "a/Foo.aidl",
566 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900567
568 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900569 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700570 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900571 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700572 "Parcelable must be defined in AIDL directly.\n";
573 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900574 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700575 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700576
577 CaptureStderr();
578 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
579 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900580}
581
Jiyong Park43113fb2020-07-20 16:26:19 +0900582TEST_F(AidlTest, ParsesJavaDebugAnnotation) {
583 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
584 @JavaDebug parcelable IFoo { int a; float b; })");
585 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
586 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
587
588 string java_out;
589 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
590 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
591
592 // Other backends shouldn't be bothered
593 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
594 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
595
596 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
597 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
598}
599
600TEST_F(AidlTest, RejectsJavaDebugAnnotation) {
601 {
602 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug interface IFoo{}");
603 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
604 CaptureStderr();
605 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
606 const std::string expected_stderr =
607 "ERROR: a/IFoo.aidl:1.22-32: 'JavaDebug' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900608 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
609 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900610 EXPECT_EQ(expected_stderr, GetCapturedStderr());
611 }
612
613 {
614 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug enum IFoo { A=1, }");
615 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
616 CaptureStderr();
617 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
618 const std::string expected_stderr =
619 "ERROR: a/IFoo.aidl:1.27-32: 'JavaDebug' is not a supported annotation for this node. "
620 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
621 EXPECT_EQ(expected_stderr, GetCapturedStderr());
622 }
623}
624
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900625TEST_P(AidlTest, ParseDescriptorAnnotation) {
626 AidlError error;
627 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
628 typenames_, GetLanguage(), &error, {"--structured"});
629 ASSERT_EQ(AidlError::OK, error);
630 ASSERT_NE(nullptr, parse_result);
631 const AidlInterface* interface = parse_result->AsInterface();
632 ASSERT_NE(nullptr, interface);
633 ASSERT_EQ("IBar", interface->GetDescriptor());
634}
635
Jiyong Park40782d02020-07-24 19:17:43 +0900636TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700637 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700638 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900639}
640
641TEST_P(AidlTest, AcceptsOnewayInterface) {
642 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700643 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700644}
Christopher Wileyef140932015-11-03 09:29:19 -0800645
Devin Moore7b8d5c92020-03-17 14:14:08 -0700646TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700647 const string oneway_method =
648 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700649 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100650}
651
Steven Moreland65297cc2020-04-20 20:17:36 -0700652TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
653 const string oneway_method =
654 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
655 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
656 ASSERT_NE(nullptr, defined);
657 const AidlInterface* iface = defined->AsInterface();
658 ASSERT_NE(nullptr, iface);
659
660 const auto& methods = iface->GetMethods();
661 ASSERT_EQ(1u, methods.size());
662 const auto& method = methods[0];
663 const AidlTypeSpecifier& ret_type = method->GetType();
664
665 // TODO(b/151102494): these annotations should be on the method
666 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
667 ASSERT_TRUE(ret_type.IsHide());
668}
669
Devin Moore7b8d5c92020-03-17 14:14:08 -0700670TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100671 string foo_interface =
672 "package a; /* foo */ interface IFoo {"
673 " /* i */ int i();"
674 " /* j */ @nullable String j();"
675 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
676
Devin Moore7b8d5c92020-03-17 14:14:08 -0700677 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100678 EXPECT_NE(nullptr, parse_result);
679 EXPECT_EQ("/* foo */", parse_result->GetComments());
680
681 const AidlInterface* interface = parse_result->AsInterface();
682 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
683 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
684 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
685}
686
Jooyung Han1a551d32020-10-05 15:37:26 +0900687TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
688 io_delegate_.SetFileContents("p/cpp_header.aidl",
689 R"(package p;
690 parcelable cpp_header cpp_header "bar/header";)");
691 import_paths_.emplace("");
692 const string input_path = "p/IFoo.aidl";
693 const string input = R"(package p;
694 import p.cpp_header;
695 interface IFoo {
696 // get bar
697 cpp_header get();
698 })";
699
700 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
701 EXPECT_NE(nullptr, parse_result);
702 const AidlInterface* interface = parse_result->AsInterface();
703 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
704}
705
Christopher Wileyef140932015-11-03 09:29:19 -0800706TEST_F(AidlTest, ParsesPreprocessedFile) {
707 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
708 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700709 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900710 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700711 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
712 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800713}
714
715TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
716 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
717 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900718
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700719 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900720 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700721 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
722 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800723}
724
Devin Moore7b8d5c92020-03-17 14:14:08 -0700725TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800726 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
727 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
728 "interface IBar {}");
729 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900730 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900731 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700732 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800733 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900734
Christopher Wiley41544372015-11-03 14:52:29 -0800735 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700736 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
737 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800738 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700739 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900740 ambiguous_type.Resolve(typenames_);
741 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800742}
743
Jiyong Park8f6ec462020-01-19 20:52:47 +0900744// Special case of PreferImportToPreprocessed. Imported type should be preferred
745// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700746TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900747 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
748 io_delegate_.SetFileContents("one/IBar.aidl",
749 "package one; "
750 "interface IBar {}");
751 preprocessed_files_.push_back("preprocessed");
752 import_paths_.emplace("");
753 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700754 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900755 EXPECT_NE(nullptr, parse_result);
756
757 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700758 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
759 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900760 // But if we request just "IBar" we should get our imported one.
761 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
762 ambiguous_type.Resolve(typenames_);
763 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
764}
765
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800766TEST_F(AidlTest, WritePreprocessedFile) {
767 io_delegate_.SetFileContents("p/Outer.aidl",
768 "package p; parcelable Outer.Inner;");
769 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
770 "interface IBar {}");
771
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900772 vector<string> args {
773 "aidl",
774 "--preprocess",
775 "preprocessed",
776 "p/Outer.aidl",
777 "one/IBar.aidl"};
778 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800779 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
780
781 string output;
782 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
783 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
784}
785
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900786TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100787 io_delegate_.SetFileContents(
788 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800789 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100790 "parcelable Rect {\n"
791 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800792 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100793 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800794 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100795 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100796 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
797 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100798 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900799 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900800 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100801 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900802
803 vector<string> args{"aidl", "Rect.aidl"};
804 Options options = Options::From(args);
805 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
806
807 string output;
808 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900809 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900810}
811
Devin Moore2f2077a2020-08-28 11:27:53 -0700812TEST_F(AidlTest, CppHeaderIncludes) {
813 io_delegate_.SetFileContents("IFoo.aidl",
814 "interface IFoo {\n"
815 " @nullable List<String> foo();\n"
816 "}");
817
818 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
819 Options options = Options::From(args);
820 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
821 std::vector<std::string> empty;
822 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
823 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
824 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
825
826 // Make sure the optional and String16.h includes are added
827 string output;
828 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
829 EXPECT_EQ(kExpectedCppHeaderOutput, output);
830}
831
Devin Moore7b8d5c92020-03-17 14:14:08 -0700832TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700833 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800834 io_delegate_.SetFileContents("p/Outer.aidl",
835 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900836 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700837 CaptureStderr();
838 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
839 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700840 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700841 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800842}
843
Devin Moore7b8d5c92020-03-17 14:14:08 -0700844TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800845 io_delegate_.SetFileContents("preprocessed",
846 "parcelable p.Outer.Inner;");
847 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900848 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700849 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800850 // TODO(wiley): This should actually return nullptr because we require
851 // the outer class name. However, for legacy reasons,
852 // this behavior must be maintained. b/17415692
853 EXPECT_NE(nullptr, parse_result);
854}
855
Christopher Wiley632801d2015-11-05 14:15:49 -0800856TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700857 const string expected_foo_stderr =
858 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
859 "Declared parcelables should be in their own file and/or cannot be used with --structured "
860 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700861 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
862
Christopher Wiley632801d2015-11-05 14:15:49 -0800863 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700864 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700865 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900866 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700867 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900868
Steven Morelande2c64b42018-09-18 15:06:37 -0700869 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900870 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700871 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900872 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700873 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700874
Devin Moore097a3ab2020-03-11 16:08:44 -0700875 const string expected_bar_stderr =
876 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
877 "Declared parcelables should be in their own file and/or cannot be used with --structured "
878 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700879 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
880
Jiyong Parkda8c6932019-08-12 19:56:08 +0900881 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700882 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700883 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900884 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700885 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700886 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700887 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700888 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700889 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800890}
891
Devin Moore7b8d5c92020-03-17 14:14:08 -0700892TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700893 const string expected_stderr =
894 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
895 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700896 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
897 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700898 AidlError error;
899 CaptureStderr();
900 EXPECT_EQ(
901 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700902 Parse("p/IFoo.aidl",
903 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700904 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700905 EXPECT_EQ(expected_stderr, GetCapturedStderr());
906 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700907}
908
Devin Moore7b8d5c92020-03-17 14:14:08 -0700909TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700910 AidlError error;
911 const string expected_stderr =
912 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
913 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900914 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
915 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700916 interface IFoo {
917 const String DUPLICATED = "d";
918 const int DUPLICATED = 1;
919 }
920 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700921 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 EXPECT_EQ(expected_stderr, GetCapturedStderr());
923 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700924}
925
Devin Moore7b8d5c92020-03-17 14:14:08 -0700926TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700927 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700928 const string expected_stderr =
929 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700930 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700931 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
932 R"(package p;
933 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700934 parcelable IBar {}
935 parcelable StructuredParcelable {}
936 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900937 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700938 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700939 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700940 // Parse success is important for clear error handling even if the cases aren't
941 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700942 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700943}
944
Devin Moore7b8d5c92020-03-17 14:14:08 -0700945TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700946 AidlError error;
947 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
948 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700949 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700950 EXPECT_EQ(expected_stderr, GetCapturedStderr());
951 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700952}
953
Steven Morelandf9e922f2020-07-08 21:15:27 +0000954TEST_P(AidlTest, FailOnEmptyListWithComma) {
955 AidlError error;
956 const string expected_stderr =
957 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
958 CaptureStderr();
959 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
960 typenames_, GetLanguage(), &error));
961 EXPECT_EQ(expected_stderr, GetCapturedStderr());
962 EXPECT_EQ(AidlError::PARSE_ERROR, error);
963}
964
Devin Moore7b8d5c92020-03-17 14:14:08 -0700965TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700966 AidlError error;
967 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -0700968 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700969 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900970 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
971 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700972 interface IFoo {
973 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
974 }
975 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700976 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700977 EXPECT_EQ(expected_stderr, GetCapturedStderr());
978 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -0700979}
980
Jiyong Park18132182020-06-08 20:24:40 +0900981TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
982 AidlError error;
983 const string expected_stderr =
984 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
985 "cpp_header (which can also be used as an identifier)\n";
986 CaptureStderr();
987 // Notice the trailing dot(.) in the name, which isn't a correct name
988 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
989 GetLanguage(), &error));
990 EXPECT_EQ(expected_stderr, GetCapturedStderr());
991 EXPECT_EQ(AidlError::PARSE_ERROR, error);
992}
993
994TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
995 AidlError error;
996 const string expected_stderr =
997 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
998 "cpp_header (which can also be used as an identifier)\n";
999 CaptureStderr();
1000 // Notice the trailing dot(.) in the package name
1001 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1002 GetLanguage(), &error));
1003 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1004 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1005}
1006
Devin Moore7b8d5c92020-03-17 14:14:08 -07001007TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001008 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001009 auto parse_result = Parse("p/IFoo.aidl",
1010 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001011 interface IFoo {
1012 const int POSITIVE_HEX_VALUE = 0xf5;
1013 }
1014 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001015 typenames_, GetLanguage(), &error);
1016 EXPECT_NE(nullptr, parse_result);
1017 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001018 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001019 const auto& cpp_constants = interface->GetConstantDeclarations();
1020 EXPECT_EQ((size_t)1, cpp_constants.size());
1021 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001022 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001023 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001024}
1025
Devin Moore7b8d5c92020-03-17 14:14:08 -07001026TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001027 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001028 auto parse_result = Parse("p/IFoo.aidl",
1029 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001030 interface IFoo {
1031 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1032 }
1033 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001034 typenames_, GetLanguage(), &error);
1035 ASSERT_NE(nullptr, parse_result);
1036 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001037 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001038 const auto& cpp_constants = interface->GetConstantDeclarations();
1039 EXPECT_EQ((size_t)1, cpp_constants.size());
1040 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001041 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001042 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001043}
1044
Devin Moore7b8d5c92020-03-17 14:14:08 -07001045TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001046 io_delegate_.SetFileContents(
1047 "p/Outer.aidl",
1048 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001049 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001050 const string input_path = "p/IFoo.aidl";
1051 const string input = "package p; import p.Outer; interface IFoo"
1052 " { Outer.Inner get(); }";
1053
Devin Moore7b8d5c92020-03-17 14:14:08 -07001054 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1055 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001056
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001057 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001058 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001059 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1060 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001061}
1062
Devin Moore7b8d5c92020-03-17 14:14:08 -07001063TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001064 io_delegate_.SetFileContents(
1065 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001066 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001067 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001068 const string input_path = "p/IFoo.aidl";
1069 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001070 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1071 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001072 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001073 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1074 native_type.Resolve(typenames_);
1075
1076 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1077 // C++ understands C++ specific stuff
1078 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1079 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001080 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001081 EXPECT_EQ(1u, headers.size());
1082 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001083}
1084
Christopher Wileyf8136192016-04-12 14:19:35 -07001085TEST_F(AidlTest, WritesCorrectDependencyFile) {
1086 // While the in tree build system always gives us an output file name,
1087 // other android tools take advantage of our ability to infer the intended
1088 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001089 vector<string> args = {
1090 "aidl",
1091 "-d dep/file/path",
1092 "-o place/for/output",
1093 "p/IFoo.aidl"};
1094 Options options = Options::From(args);
1095 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001096 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001097 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001098 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001099 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1100}
1101
Dan Willemsen93298ee2016-11-10 23:55:55 -08001102TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1103 // While the in tree build system always gives us an output file name,
1104 // other android tools take advantage of our ability to infer the intended
1105 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001106 vector<string> args = {
1107 "aidl",
1108 "-d dep/file/path",
1109 "--ninja",
1110 "-o place/for/output",
1111 "p/IFoo.aidl"};
1112 Options options = Options::From(args);
1113 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001114 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001115 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001116 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001117 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1118}
1119
Jiyong Parkdf202122019-09-30 20:48:35 +09001120TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001121 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1122 // this by calling aidl with every .aidl file it finds, then parsing the
1123 // generated dependency files. Those that reference .java output files are
1124 // for interfaces and those that do not are parcelables. However, for both
1125 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001126 vector<string> args = {
1127 "aidl",
1128 "-o place/for/output",
1129 "-d dep/file/path",
1130 "p/Foo.aidl"};
1131 Options options = Options::From(args);
1132 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001133 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001134 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001135 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001136 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1137}
1138
1139TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1140 vector<string> args = {
1141 "aidl",
1142 "--structured",
1143 "-o place/for/output",
1144 "-d dep/file/path",
1145 "p/Foo.aidl"};
1146 Options options = Options::From(args);
1147 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1148 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1149 string actual_dep_file_contents;
1150 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1151 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001152}
1153
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001154TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1155 vector<string> args = {
1156 "aidl",
1157 "--lang=java",
1158 "-o place/for/output",
1159 "p/Foo.aidl"};
1160 Options options = Options::From(args);
1161 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1162 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1163 string output_file_contents;
1164 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1165}
1166
Jeongik Cha08ca2182019-11-21 14:01:13 +09001167// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001168TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001169 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001170 "package a; interface IFoo {\n"
1171 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001172 string expected_stderr;
1173 switch (GetLanguage()) {
1174 case Options::Language::CPP:
1175 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001176 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001177 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1178 "String and IBinder.\n";
1179 break;
1180 case Options::Language::JAVA:
1181 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001182 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001183 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1184 "String, IBinder, and ParcelFileDescriptor.\n";
1185 break;
1186 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001187 case Options::Language::RUST:
1188 expected_stderr =
1189 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1190 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001191 default:
1192 AIDL_FATAL(AIDL_LOCATION_HERE)
1193 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1194 }
1195 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001196 AidlTypenames tn1;
1197 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001198 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001199
1200 string primitive_parcelable =
1201 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001202 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001203 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001204 AidlTypenames tn2;
1205 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001206 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001207}
1208
Devin Moore21b26772020-08-26 16:37:56 -07001209TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001210 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001211 const string list_array_parcelable =
1212 "package a; parcelable Foo {\n"
1213 " List[] lists; }";
1214 CaptureStderr();
1215 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1216 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1217}
1218
Jiyong Parkf8d53612020-05-04 14:06:13 +09001219TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1220 AidlError error;
1221 string expected_stderr =
1222 "ERROR: a/IFoo.aidl:2.7-11: "
1223 "Encountered an untyped List or Map. The use of untyped List/Map is "
1224 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1225 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1226 if (GetLanguage() != Options::Language::JAVA) {
1227 expected_stderr =
1228 "ERROR: a/IFoo.aidl:2.1-7: "
1229 "Currently, only the Java backend supports non-generic List.\n";
1230 }
1231
1232 const string primitive_interface =
1233 "package a; interface IFoo {\n"
1234 " List foo(); }";
1235 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001236 AidlTypenames tn1;
1237 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001238 {"--structured"}));
1239 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001240
1241 string primitive_parcelable =
1242 "package a; parcelable IFoo {\n"
1243 " List foo;}";
1244 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001245 AidlTypenames tn2;
1246 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001247 {"--structured"}));
1248 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1249}
1250
Jeongik Cha225519b2020-08-29 01:55:32 +09001251TEST_P(AidlTest, ExtensionTest) {
1252 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001253 string extendable_parcelable =
1254 "package a; parcelable Data {\n"
1255 " ParcelableHolder extension;\n"
1256 " ParcelableHolder extension2;\n"
1257 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001258 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001259 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1260 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001261 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001262 "yet.\n",
1263 GetCapturedStderr());
1264 } else {
1265 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1266 EXPECT_EQ("", GetCapturedStderr());
1267 }
1268}
1269TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1270 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001271 string parcelableholder_return_interface =
1272 "package a; interface IFoo {\n"
1273 " ParcelableHolder foo();\n"
1274 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001275 EXPECT_EQ(nullptr,
1276 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001277
Jeongik Cha8f02a532020-10-14 00:16:28 +09001278 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001279 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001280 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001281 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001282 "yet.\n",
1283 GetCapturedStderr());
1284 return;
1285 }
1286 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1287 GetCapturedStderr());
1288}
1289
1290TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1291 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001292 string extendable_parcelable_arg_interface =
1293 "package a; interface IFoo {\n"
1294 " void foo(in ParcelableHolder ph);\n"
1295 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001296 EXPECT_EQ(nullptr,
1297 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1298
Jeongik Cha8f02a532020-10-14 00:16:28 +09001299 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001300 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001301 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001302 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001303 "yet.\n",
1304 GetCapturedStderr());
1305 return;
1306 }
1307 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1308 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001309}
1310
Jiyong Park02da7422018-07-16 16:00:26 +09001311TEST_F(AidlTest, ApiDump) {
1312 io_delegate_.SetFileContents(
1313 "foo/bar/IFoo.aidl",
1314 "package foo.bar;\n"
1315 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001316 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001317 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001318 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001319 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1320 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1321 " IFoo foo3(IFoo foo);\n"
1322 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001323 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001324 " const int A = 1;\n"
1325 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001326 "}\n");
1327 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1328 "package foo.bar;\n"
1329 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001330 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001331 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001332 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001333 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001334 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001335 " int y;\n"
1336 " IFoo foo;\n"
1337 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001338 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001339 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001340 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001341 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001342 "}\n");
1343 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001344 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1345 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001346 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001347 bool result = dump_api(options, io_delegate_);
1348 ASSERT_TRUE(result);
1349 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001350 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001351 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001352/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001353interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001354 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001355 int foo(out int[] a, String b, boolean c, inout List<String> d);
1356 int foo2(@utf8InCpp String x, inout List<String> y);
1357 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1358 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001359 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001360 const int A = 1;
1361 const String STR = "Hello";
1362}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001363)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001364
Jiyong Parke59c3682018-09-11 23:10:25 +09001365 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001366 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001367/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001368parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001369 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001370 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001371 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001372 int y;
1373 foo.bar.IFoo foo;
1374 List<foo.bar.IFoo> a;
1375 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001376 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001377 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001378}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001379)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001380}
1381
Jiyong Parked65bf42018-08-28 15:43:27 +09001382TEST_F(AidlTest, ApiDumpWithManualIds) {
1383 io_delegate_.SetFileContents(
1384 "foo/bar/IFoo.aidl",
1385 "package foo.bar;\n"
1386 "interface IFoo {\n"
1387 " int foo() = 1;\n"
1388 " int bar() = 2;\n"
1389 " int baz() = 10;\n"
1390 "}\n");
1391
Jiyong Parke59c3682018-09-11 23:10:25 +09001392 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001393 Options options = Options::From(args);
1394 bool result = dump_api(options, io_delegate_);
1395 ASSERT_TRUE(result);
1396 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001397 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001398 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001399interface IFoo {
1400 int foo() = 1;
1401 int bar() = 2;
1402 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001403}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001404)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001405}
1406
1407TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001408 const string expected_stderr =
1409 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1410 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001411 io_delegate_.SetFileContents(
1412 "foo/bar/IFoo.aidl",
1413 "package foo.bar;\n"
1414 "interface IFoo {\n"
1415 " int foo() = 1;\n"
1416 " int bar();\n"
1417 " int baz() = 10;\n"
1418 "}\n");
1419
Jiyong Parke59c3682018-09-11 23:10:25 +09001420 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001421 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001422 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001423 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001424 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001425}
1426
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001427TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001428 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001429 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1430 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001431 const string expected_map_stderr =
1432 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001433 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1434 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001435 "package p; interface IFoo {"
1436 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001437 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001438 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001439 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001440
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001441 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001442 "package p; interface IFoo {"
1443 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001444 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001445 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001446 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001447}
1448
Jeongik Chae48d9942020-01-02 17:39:00 +09001449TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001450 const string expected_stderr =
1451 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001452 Options options = Options::From("aidl -I p p/IFoo.aidl");
1453 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1454
1455 io_delegate_.SetFileContents("p/IFoo.aidl",
1456 "package p; interface IFoo {"
1457 "Map<String, Bar> foo();}");
1458 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1459
1460 io_delegate_.SetFileContents("p/IFoo.aidl",
1461 "package p; interface IFoo {"
1462 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001463 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001464 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001465 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001466
1467 io_delegate_.SetFileContents("p/IFoo.aidl",
1468 "package p; interface IFoo {"
1469 "Map<String, String> foo();}");
1470 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1471
1472 io_delegate_.SetFileContents("p/IFoo.aidl",
1473 "package p; interface IFoo {"
1474 "Map<String, ParcelFileDescriptor> foo();}");
1475 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1476}
1477
Jeongik Chadf76dc72019-11-28 00:08:47 +09001478TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001479 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001480 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1481 io_delegate_.SetFileContents(options.InputFiles().front(),
1482 "package p; interface IFoo {"
1483 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001484 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001485 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001486 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001487}
1488
1489TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1490 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1491 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001492 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001493 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001494 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1495 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001496
1497 Options options = Options::From("aidl -I p p/IFoo.aidl");
1498 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1499 io_delegate_.SetFileContents("p/IFoo.aidl",
1500 "package p; interface IFoo {"
1501 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001502 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001503 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001504 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001505 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001506 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001507 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001508 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1509 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001510 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1511 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1512 io_delegate_.SetFileContents("p/IFoo.aidl",
1513 "package p; interface IFoo {"
1514 "Bar<String, ParcelFileDescriptor> foo();}");
1515 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001516
1517 io_delegate_.SetFileContents("p/IFoo.aidl",
1518 "package p; interface IFoo {"
1519 "Bar<int, long> foo();}");
1520
1521 io_delegate_.SetFileContents("p/IFoo.aidl",
1522 "package p; interface IFoo {"
1523 "Bar<int[], long[]> foo();}");
1524
1525 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001526}
1527
Jeongik Cha0e426012019-07-29 15:57:02 +09001528TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1529 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001530 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1531 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001532 for (const auto& rawOption : rawOptions) {
1533 string expected_stderr =
1534 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001535 Options options = Options::From(rawOption);
1536 io_delegate_.SetFileContents(options.InputFiles().front(),
1537 "package foo.bar;\n"
1538 "interface IFoo1 { int foo(); }\n"
1539 "interface IFoo2 { int foo(); }\n"
1540 "parcelable Data1 { int a; int b;}\n"
1541 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001542 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001543 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001545
Jeongik Cha0e426012019-07-29 15:57:02 +09001546 io_delegate_.SetFileContents(options.InputFiles().front(),
1547 "package foo.bar;\n"
1548 "interface IFoo1 { int foo(); }\n"
1549 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001550 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001551 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001552 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001553
Devin Moore5de18ed2020-04-02 13:52:29 -07001554 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001555 io_delegate_.SetFileContents(options.InputFiles().front(),
1556 "package foo.bar;\n"
1557 "parcelable Data1 { int a; int b;}\n"
1558 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001559 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001560 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001561 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001562 }
1563}
1564
Devin Moorebdba2a82020-03-31 15:19:02 -07001565TEST_P(AidlTest, FailParseOnEmptyFile) {
1566 const string contents = "";
1567 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1568 CaptureStderr();
1569 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1570 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1571}
1572
Jiyong Parkb034bf02018-07-30 17:44:33 +09001573TEST_F(AidlTest, MultipleInputFiles) {
1574 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001575 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001576
1577 io_delegate_.SetFileContents(options.InputFiles().at(0),
1578 "package foo.bar;\n"
1579 "import foo.bar.Data;\n"
1580 "interface IFoo { Data getData(); }\n");
1581
1582 io_delegate_.SetFileContents(options.InputFiles().at(1),
1583 "package foo.bar;\n"
1584 "import foo.bar.IFoo;\n"
1585 "parcelable Data { IFoo foo; }\n");
1586
1587 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1588
1589 string content;
1590 for (const auto file : {
1591 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1592 content.clear();
1593 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1594 EXPECT_FALSE(content.empty());
1595 }
1596}
1597
1598TEST_F(AidlTest, MultipleInputFilesCpp) {
1599 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001600 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001601
1602 io_delegate_.SetFileContents(options.InputFiles().at(0),
1603 "package foo.bar;\n"
1604 "import foo.bar.Data;\n"
1605 "interface IFoo { Data getData(); }\n");
1606
1607 io_delegate_.SetFileContents(options.InputFiles().at(1),
1608 "package foo.bar;\n"
1609 "import foo.bar.IFoo;\n"
1610 "parcelable Data { IFoo foo; }\n");
1611
1612 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1613
1614 string content;
1615 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001616 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001617 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1618 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1619 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1620 content.clear();
1621 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1622 EXPECT_FALSE(content.empty());
1623 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001624}
1625
Andrei Homescub62afd92020-05-11 19:24:59 -07001626TEST_F(AidlTest, MultipleInputFilesRust) {
1627 Options options =
1628 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1629
1630 io_delegate_.SetFileContents(options.InputFiles().at(0),
1631 "package foo.bar;\n"
1632 "import foo.bar.Data;\n"
1633 "interface IFoo { Data getData(); }\n");
1634
1635 io_delegate_.SetFileContents(options.InputFiles().at(1),
1636 "package foo.bar;\n"
1637 "import foo.bar.IFoo;\n"
1638 "parcelable Data { IFoo foo; }\n");
1639
1640 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1641
1642 string content;
1643 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1644 content.clear();
1645 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1646 EXPECT_FALSE(content.empty());
1647 }
1648}
1649
Devin Moore097a3ab2020-03-11 16:08:44 -07001650TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1651 const string expected_stderr =
1652 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001653 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1654 // int getInterfaceVersion() is one of the meta transactions
1655 io_delegate_.SetFileContents(options.InputFiles().front(),
1656 "package p; interface IFoo {"
1657 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001658 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001659 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001660 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1661}
Jiyong Park309668e2018-07-28 16:55:44 +09001662
Devin Moore097a3ab2020-03-11 16:08:44 -07001663TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1664 // boolean getInterfaceVersion() is not a meta transaction, but should be
1665 // prevented because return type is not part of a method signature
1666 const string expected_stderr =
1667 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1668 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001669 io_delegate_.SetFileContents(options.InputFiles().front(),
1670 "package p; interface IFoo {"
1671 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001672 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001673 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001674 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1675}
Jiyong Park309668e2018-07-28 16:55:44 +09001676
Devin Moore097a3ab2020-03-11 16:08:44 -07001677TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001678 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001679 const string expected_stderr =
1680 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1681 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001682 io_delegate_.SetFileContents(options.InputFiles().front(),
1683 "package p; interface IFoo {"
1684 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001685 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001686 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001687 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001688
1689 // this is not a meta interface method as it differs type arguments
1690 io_delegate_.SetFileContents(options.InputFiles().front(),
1691 "package p; interface IFoo {"
1692 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001693 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001694}
1695
Daniel Norman85aed542019-08-21 12:01:14 -07001696TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001697 Options options = Options::From("aidl --checkapi old new");
1698 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1699 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1700 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1701 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1702
1703 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1704}
1705
Jiyong Park3656c3c2018-08-01 20:02:01 +09001706TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001707 Options options = Options::From("aidl --checkapi old new");
1708 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1709 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001710
1711 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1712}
1713
Daniel Norman85aed542019-08-21 12:01:14 -07001714class AidlTestCompatibleChanges : public AidlTest {
1715 protected:
1716 Options options_ = Options::From("aidl --checkapi old new");
1717};
1718
1719TEST_F(AidlTestCompatibleChanges, NewType) {
1720 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1721 "package p;"
1722 "interface IFoo {"
1723 " void foo(int a);"
1724 "}");
1725 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1726 "package p;"
1727 "interface IFoo {"
1728 " void foo(int a);"
1729 "}");
1730 io_delegate_.SetFileContents("new/p/IBar.aidl",
1731 "package p;"
1732 "interface IBar {"
1733 " void bar();"
1734 "}");
1735 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1736}
1737
1738TEST_F(AidlTestCompatibleChanges, NewMethod) {
1739 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1740 "package p;"
1741 "interface IFoo {"
1742 " void foo(int a);"
1743 "}");
1744 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1745 "package p;"
1746 "interface IFoo {"
1747 " void foo(int a);"
1748 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001749 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001750 "}");
1751 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1752}
1753
1754TEST_F(AidlTestCompatibleChanges, NewField) {
1755 io_delegate_.SetFileContents("old/p/Data.aidl",
1756 "package p;"
1757 "parcelable Data {"
1758 " int foo;"
1759 "}");
1760 io_delegate_.SetFileContents("new/p/Data.aidl",
1761 "package p;"
1762 "parcelable Data {"
1763 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001764 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001765 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001766 "}");
1767 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1768}
1769
1770TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1771 io_delegate_.SetFileContents("old/p/Enum.aidl",
1772 "package p;"
1773 "enum Enum {"
1774 " FOO = 1,"
1775 "}");
1776 io_delegate_.SetFileContents("new/p/Enum.aidl",
1777 "package p;"
1778 "enum Enum {"
1779 " FOO = 1,"
1780 " BAR = 2,"
1781 "}");
1782 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1783}
1784
1785TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1786 io_delegate_.SetFileContents("old/p/Enum.aidl",
1787 "package p;"
1788 "enum Enum {"
1789 " FOO = 1,"
1790 " BAR = 2,"
1791 "}");
1792 io_delegate_.SetFileContents("new/p/Enum.aidl",
1793 "package p;"
1794 "enum Enum {"
1795 " BAR = 2,"
1796 " FOO = 1,"
1797 "}");
1798 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1799}
1800
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001801TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1802 io_delegate_.SetFileContents("old/p/Union.aidl",
1803 "package p;"
1804 "union Union {"
1805 " String foo;"
1806 "}");
1807 io_delegate_.SetFileContents("new/p/Union.aidl",
1808 "package p;"
1809 "union Union {"
1810 " String foo;"
1811 " int num;"
1812 "}");
1813 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1814}
1815
Daniel Norman85aed542019-08-21 12:01:14 -07001816TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001817 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1818 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001819 "interface IFoo {"
1820 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001821 "}");
1822 io_delegate_.SetFileContents("old/p/Data.aidl",
1823 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001824 "parcelable Data {"
1825 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001826 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001827 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1828 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001829 "interface IFoo {"
1830 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001831 "}");
1832 io_delegate_.SetFileContents("new/p/Data.aidl",
1833 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001834 "parcelable Data {"
1835 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001836 "}");
1837 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1838 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001839 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001840 " void foo(int a);"
1841 "}");
1842 io_delegate_.SetFileContents("new/q/Data.aidl",
1843 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001844 "parcelable Data {"
1845 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001846 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001847 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1848}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001849
Daniel Norman85aed542019-08-21 12:01:14 -07001850TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1851 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1852 "package p;"
1853 "interface IFoo {"
1854 " void foo(int a);"
1855 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001856 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1857 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001858 "interface IFoo {"
1859 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001860 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001861 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1862}
Jiyong Parke59c3682018-09-11 23:10:25 +09001863
Daniel Norman85aed542019-08-21 12:01:14 -07001864TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001865 io_delegate_.SetFileContents("old/p/I.aidl",
1866 "package p; interface I {"
1867 "const int A = 1; }");
1868 io_delegate_.SetFileContents("new/p/I.aidl",
1869 "package p ; interface I {"
1870 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001871 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1872}
Jiyong Parka428d212018-08-29 22:26:30 +09001873
Daniel Norman85aed542019-08-21 12:01:14 -07001874TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001875 io_delegate_.SetFileContents("old/p/I.aidl",
1876 "package p; interface I {"
1877 "const int A = 1; const int B = 2;}");
1878 io_delegate_.SetFileContents("new/p/I.aidl",
1879 "package p ; interface I {"
1880 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001881 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001882}
1883
Jooyung Han636fd2f2020-10-22 11:33:45 +09001884TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
1885 io_delegate_.SetFileContents("old/p/Data.aidl",
1886 "package p;"
1887 "parcelable Data {"
1888 " int num;"
1889 "}");
1890 io_delegate_.SetFileContents(
1891 "new/p/Data.aidl",
1892 "package p;"
1893 "parcelable Data {"
1894 " int num;"
1895 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
1896 "}");
1897 io_delegate_.SetFileContents("new/p/Enum.aidl",
1898 "package p;"
1899 "enum Enum {"
1900 " FOO = 0,"
1901 " BAR = 1,"
1902 "}");
1903 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1904}
1905
Daniel Norman85aed542019-08-21 12:01:14 -07001906class AidlTestIncompatibleChanges : public AidlTest {
1907 protected:
1908 Options options_ = Options::From("aidl --checkapi old new");
1909};
1910
1911TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001912 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001913 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1914 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001915 "interface IFoo {"
1916 " void foo(in String[] str);"
1917 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001918 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001919 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001920 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001921 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001922}
1923
1924TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001925 const string expected_stderr =
1926 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001927 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1928 "package p;"
1929 "interface IFoo {"
1930 " void foo(in String[] str);"
1931 " void bar(@utf8InCpp String str);"
1932 "}");
1933 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1934 "package p;"
1935 "interface IFoo {"
1936 " void foo(in String[] str);"
1937 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001938 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001939 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001941}
1942
Jiyong Parkf8d53612020-05-04 14:06:13 +09001943TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1944 const string expected_stderr =
1945 "ERROR: new/p/IFoo.aidl:1.61-65: "
1946 "Encountered an untyped List or Map. The use of untyped List/Map is "
1947 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1948 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1949 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1950 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1951 "package p;"
1952 "interface IFoo {"
1953 " void foo(in String[] str);"
1954 "}");
1955 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1956 "package p;"
1957 "interface IFoo {"
1958 " void foo(in String[] str);"
1959 " void bar(in List arg);"
1960 "}");
1961 CaptureStderr();
1962 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1963 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1964}
1965
1966TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
1967 const string expected_stderr =
1968 "ERROR: new/p/Data.aidl:1.54-59: "
1969 "Encountered an untyped List or Map. The use of untyped List/Map is "
1970 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1971 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1972 "ERROR: new/p/Data.aidl: Failed to read.\n";
1973 io_delegate_.SetFileContents("old/p/Data.aidl",
1974 "package p;"
1975 "parcelable Data {"
1976 " int foo;"
1977 "}");
1978 io_delegate_.SetFileContents("new/p/Data.aidl",
1979 "package p;"
1980 "parcelable Data {"
1981 " int foo;"
1982 " @nullable List list;"
1983 "}");
1984 CaptureStderr();
1985 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1986 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1987}
1988
Daniel Norman85aed542019-08-21 12:01:14 -07001989TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001990 const string expected_stderr =
1991 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001992 io_delegate_.SetFileContents("old/p/Data.aidl",
1993 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001994 "parcelable Data {"
1995 " int foo;"
1996 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001997 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001998 io_delegate_.SetFileContents("new/p/Data.aidl",
1999 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002000 "parcelable Data {"
2001 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002002 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002003 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002004 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002005 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002006}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002007
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002008TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2009 const string expected_stderr =
2010 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2011 "backends. Please either provide a default value for this field or mark the field as "
2012 "@nullable. This value or a null value will be used automatically when an old version of "
2013 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2014 "order to make sure your code continues to be backwards compatible, make sure the default or "
2015 "null value does not cause a semantic change to this parcelable.\n";
2016 io_delegate_.SetFileContents("old/p/Data.aidl",
2017 "package p;"
2018 "parcelable Data {"
2019 " int num;"
2020 "}");
2021 io_delegate_.SetFileContents("new/p/Data.aidl",
2022 "package p;"
2023 "parcelable Data {"
2024 " int num;"
2025 " String str;"
2026 "}");
2027 CaptureStderr();
2028 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2029 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2030}
2031
Jooyung Han636fd2f2020-10-22 11:33:45 +09002032TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2033 const string expected_stderr =
2034 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2035 "Please make sure 'Enum' has '0' as a valid value.\n";
2036 io_delegate_.SetFileContents("old/p/Data.aidl",
2037 "package p;"
2038 "parcelable Data {"
2039 " int num;"
2040 "}");
2041 io_delegate_.SetFileContents("new/p/Data.aidl",
2042 "package p;"
2043 "parcelable Data {"
2044 " int num;"
2045 " p.Enum e;"
2046 "}");
2047 io_delegate_.SetFileContents("new/p/Enum.aidl",
2048 "package p;"
2049 "enum Enum {"
2050 " FOO = 1,"
2051 " BAR = 2,"
2052 "}");
2053 CaptureStderr();
2054 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2055 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2056}
2057
Daniel Norman85aed542019-08-21 12:01:14 -07002058TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002059 const string expected_stderr =
2060 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002061 io_delegate_.SetFileContents("old/p/Enum.aidl",
2062 "package p;"
2063 "enum Enum {"
2064 " FOO = 1,"
2065 " BAR = 2,"
2066 "}");
2067 io_delegate_.SetFileContents("new/p/Enum.aidl",
2068 "package p;"
2069 "enum Enum {"
2070 " BAR = 2,"
2071 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002072 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002073 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002074 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002075}
2076
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002077TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2078 const string expected_stderr =
2079 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2080 io_delegate_.SetFileContents("old/p/Union.aidl",
2081 "package p;"
2082 "union Union {"
2083 " String str;"
2084 " int num;"
2085 "}");
2086 io_delegate_.SetFileContents("new/p/Union.aidl",
2087 "package p;"
2088 "union Union {"
2089 " String str;"
2090 "}");
2091 CaptureStderr();
2092 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2093 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2094}
2095
Daniel Norman85aed542019-08-21 12:01:14 -07002096TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002097 const string expected_stderr =
2098 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002099 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2100 "package p;"
2101 "interface IFoo {"
2102 " void foo(in String[] str);"
2103 " void bar(@utf8InCpp String str);"
2104 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002105 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2106 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002107 "interface IFoo {"
2108 " void foo(in String[] str);"
2109 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002110 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002111 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002112 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002113 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002114}
2115
Daniel Norman85aed542019-08-21 12:01:14 -07002116TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002117 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002118 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2119 "package p;"
2120 "interface IFoo {"
2121 " void foo(in String[] str);"
2122 " void bar(@utf8InCpp String str);"
2123 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002124 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2125 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002126 "interface IFoo2 {"
2127 " void foo(in String[] str);"
2128 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002129 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002130 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002131 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002132 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002133}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002134
Daniel Norman85aed542019-08-21 12:01:14 -07002135TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002136 const string expected_stderr =
2137 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002138 io_delegate_.SetFileContents("old/p/Enum.aidl",
2139 "package p;"
2140 "enum Enum {"
2141 " FOO = 1,"
2142 " BAR = 2,"
2143 "}");
2144 io_delegate_.SetFileContents("new/p/Enum.aidl",
2145 "package p;"
2146 "enum Enum {"
2147 " FOO = 3,"
2148 " BAR = 2,"
2149 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002150 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002151 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002152 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002153}
2154
2155TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002156 const string expected_stderr =
2157 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2158 "from 0 to 1.\n"
2159 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2160 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002161 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2162 "package p;"
2163 "interface IFoo {"
2164 " void foo(in String[] str);"
2165 " void bar(@utf8InCpp String str);"
2166 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002167 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2168 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002169 "interface IFoo {"
2170 " void bar(@utf8InCpp String str);"
2171 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002172 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002173 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002174 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002175 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002176}
2177
2178TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002179 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002180 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2181 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002182 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002183 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002184 "parcelable Data {"
2185 " int foo;"
2186 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002187 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002188 io_delegate_.SetFileContents("new/p/Data.aidl",
2189 "package p;"
2190 "parcelable Data {"
2191 " int bar;"
2192 " int foo;"
2193 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002194 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002195 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002196 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002197}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002198
Daniel Norman85aed542019-08-21 12:01:14 -07002199TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002200 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002201 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002202 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002203 "interface IFoo {"
2204 " void foo(in String[] str);"
2205 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002206 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002207 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2208 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002209 "interface IFoo {"
2210 " void foo(out String[] str);"
2211 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002212 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002213 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002214 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002215 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002216}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002217
Daniel Norman85aed542019-08-21 12:01:14 -07002218TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002219 const string expected_stderr =
2220 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002221 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2222 "package p;"
2223 "interface IFoo {"
2224 " void foo(in String[] str);"
2225 " void bar(@utf8InCpp String str);"
2226 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002227 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2228 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002229 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002230 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002231 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002232 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002233 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002234 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002235 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002236}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002237
Daniel Norman85aed542019-08-21 12:01:14 -07002238TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002239 const string expected_stderr =
2240 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002241 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2242 "package p;"
2243 "interface IFoo {"
2244 " void foo(in String[] str);"
2245 " void bar(@utf8InCpp String str);"
2246 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002247 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2248 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002249 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002250 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002251 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002252 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002253 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002254 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002255 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002256}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002257
Devin Mooredb7ac512020-08-07 11:17:36 -07002258TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2259 const string expected_stderr =
2260 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2261 io_delegate_.SetFileContents("old/p/Foo.aidl",
2262 "package p;"
2263 "parcelable Foo {"
2264 " int A;"
2265 "}");
2266 io_delegate_.SetFileContents("new/p/Foo.aidl",
2267 "package p;"
2268 "@JavaOnlyStableParcelable parcelable Foo {"
2269 " int A;"
2270 "}");
2271 CaptureStderr();
2272 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2273 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2274}
2275
2276TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2277 const string expected_stderr =
2278 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2279 io_delegate_.SetFileContents("old/p/Foo.aidl",
2280 "package p;"
2281 "@JavaOnlyStableParcelable parcelable Foo {"
2282 " int A;"
2283 "}");
2284 io_delegate_.SetFileContents("new/p/Foo.aidl",
2285 "package p;"
2286 "parcelable Foo {"
2287 " int A;"
2288 "}");
2289 CaptureStderr();
2290 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2292}
2293
Daniel Norman85aed542019-08-21 12:01:14 -07002294TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002295 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002296 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2297 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002298 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002299 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002300 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002301 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002302}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002303
Daniel Norman85aed542019-08-21 12:01:14 -07002304TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002305 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002306 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2307 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002308 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002309 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002310 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002311}
Jiyong Parka428d212018-08-29 22:26:30 +09002312
Daniel Norman85aed542019-08-21 12:01:14 -07002313TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002314 const string expected_stderr =
2315 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002316 io_delegate_.SetFileContents("old/p/I.aidl",
2317 "package p; interface I {"
2318 "const int A = 1; const int B = 2;}");
2319 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002320 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002321 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002323}
Jiyong Parka428d212018-08-29 22:26:30 +09002324
Daniel Norman85aed542019-08-21 12:01:14 -07002325TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002326 const string expected_stderr =
2327 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002328 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2329 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002330 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002331 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002332 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002333}
2334
Devin Moorec7e47a32020-08-07 10:55:25 -07002335TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2336 const string expected_stderr =
2337 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2338 "This is an incompatible change for FixedSize types.\n";
2339 io_delegate_.SetFileContents("old/p/Foo.aidl",
2340 "package p; @FixedSize parcelable Foo { int A = 1; }");
2341 io_delegate_.SetFileContents("new/p/Foo.aidl",
2342 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2343 CaptureStderr();
2344 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2345 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2346}
2347
2348TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2349 const string expected_stderr =
2350 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2351 io_delegate_.SetFileContents("old/p/Foo.aidl",
2352 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2353 io_delegate_.SetFileContents("new/p/Foo.aidl",
2354 "package p; @FixedSize parcelable Foo { int A = 1; }");
2355 CaptureStderr();
2356 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2358}
2359
2360TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2361 const string expected_stderr =
2362 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2363 "a.\n"
2364 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2365 "b.\n"
2366 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2367 "c.\n"
2368 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2369 "d.\n"
2370 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2371 "e.\n"
2372 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2373 "f.\n";
2374
2375 io_delegate_.SetFileContents("Foo.aidl",
2376 "@FixedSize parcelable Foo { "
2377 " int[] a;"
2378 " Bar b;"
2379 " String c;"
2380 " ParcelFileDescriptor d;"
2381 " IBinder e;"
2382 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002383 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002384 "}");
2385 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2386 Options options =
2387 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2388
2389 CaptureStderr();
2390 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2391 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2392}
2393
2394TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2395 const string expected_stderr = "";
2396
2397 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2398 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2399 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2400 Options options =
2401 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2402
2403 CaptureStderr();
2404 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2405 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2406}
2407
Jiyong Park8c380532018-08-30 14:55:26 +09002408TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002409 const string expected_stderr =
2410 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2411 "dir1/q/IBar.aidl\n"
2412 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002413 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002414 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2415 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2416 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2417 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2418
Devin Moore097a3ab2020-03-11 16:08:44 -07002419 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002420 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002421 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002422}
2423
Jiyong Parked65bf42018-08-28 15:43:27 +09002424TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002425 const string expected_stderr =
2426 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2427 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002428 Options options = Options::From("aidl --checkapi old new");
2429 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2430 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002431
2432 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2433
Jiyong Parke59c3682018-09-11 23:10:25 +09002434 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002435 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002436 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002437 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002438}
2439
Jiyong Parke05195e2018-10-08 18:24:23 +09002440TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2441 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2442 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002443 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002444
2445 // use without import
2446 io_delegate_.SetFileContents("p/IFoo.aidl",
2447 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2448 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2449 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002450 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002451
Devin Moore7b8d5c92020-03-17 14:14:08 -07002452 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002453 io_delegate_.SetFileContents(
2454 "p/IFoo.aidl",
2455 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2456 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2457 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002458 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002459
2460 // use with import (as before)
2461 io_delegate_.SetFileContents("p/IFoo.aidl",
2462 "package p;"
2463 "import android.os.ParcelFileDescriptor;"
2464 "interface IFoo{"
2465 " void foo(in ParcelFileDescriptor fd);"
2466 "}");
2467 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2468 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002469 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002470}
Jiyong Parked65bf42018-08-28 15:43:27 +09002471
Jiyong Park3633b722019-04-11 15:38:26 +09002472TEST_F(AidlTest, ManualIds) {
2473 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2474 io_delegate_.SetFileContents("IFoo.aidl",
2475 "interface IFoo {\n"
2476 " void foo() = 0;\n"
2477 " void bar() = 1;\n"
2478 "}");
2479 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2480}
2481
2482TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2483 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2484 io_delegate_.SetFileContents("IFoo.aidl",
2485 "interface IFoo {\n"
2486 " void foo() = 0;\n"
2487 " void bar() = 1;\n"
2488 "}");
2489 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2490}
2491
2492TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002493 const string expected_stderr =
2494 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002495 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2496 io_delegate_.SetFileContents("IFoo.aidl",
2497 "interface IFoo {\n"
2498 " void foo() = 3;\n"
2499 " void bar() = 3;\n"
2500 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002501 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002502 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002503 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002504}
2505
2506TEST_F(AidlTest, FailOnOutOfRangeIds) {
2507 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002508 const string expected_stderr =
2509 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2510 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002511 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2512 io_delegate_.SetFileContents("IFoo.aidl",
2513 "interface IFoo {\n"
2514 " void foo() = 3;\n"
2515 " void bar() = 16777115;\n"
2516 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002517 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002518 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002519 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002520}
2521
2522TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002523 const string expected_stderr =
2524 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002525 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2526 io_delegate_.SetFileContents("IFoo.aidl",
2527 "interface IFoo {\n"
2528 " void foo() = 3;\n"
2529 " void bar();\n"
2530 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002531 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002532 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002533 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002534}
2535
Jiyong Parkc6816252019-07-08 08:12:28 +09002536TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2537 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2538 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2539 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2540 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2541}
2542
2543TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002544 const string expected_stderr =
2545 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2546 "dir/IBar.aidl\n"
2547 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002548 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002549
Jiyong Parkc6816252019-07-08 08:12:28 +09002550 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2551 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2552 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2553 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002554 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002555 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002556 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002557}
2558
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002559TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2560 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2561 "package a.b;\n"
2562 "import a.b.IBar;\n"
2563 "import a.b.IQux;\n"
2564 "interface IFoo { IQux foo(); }\n");
2565 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2566 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2567
2568 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2569 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2570
2571 string output;
2572 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2573 // IBar was imported but wasn't used. include is not expected.
2574 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2575 // IBar was imported and used. include is expected.
2576 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2577}
2578
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002579TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002580 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002581 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002582 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2583 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002584 interface IFoo {
2585 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002586 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002587 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002588 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002589 // JavaPassthrough should work with other types as well (e.g. enum)
2590 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2591 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2592 @JavaPassthrough(annotation="@com.android.AliceTwo")
2593 @Backing(type="byte")
2594 enum MyEnum {
2595 a, b, c
2596 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002597
Jooyung Han4cde01d2020-10-13 11:10:47 +09002598 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002599 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2600
2601 string java_out;
2602 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002603 // type-decl-level annotations with newline at the end
2604 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2605 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2606 // member-decl-level annotations with newline at the end
2607 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2608 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2609 // inline annotations with space at the end
2610 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002611
Jooyung Han4cde01d2020-10-13 11:10:47 +09002612 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2613 // type-decl-level annotations with newline at the end
2614 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2615 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2616
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002617 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002618 Options cpp_options =
2619 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002620 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2621
Jooyung Han4cde01d2020-10-13 11:10:47 +09002622 Options ndk_options =
2623 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002624 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002625
Jooyung Han4cde01d2020-10-13 11:10:47 +09002626 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002627 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002628}
2629
Andrei Homescue61feb52020-08-18 15:44:24 -07002630TEST_F(AidlTest, ParseRustDerive) {
2631 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2632 @RustDerive(Clone=true, Copy=false)
2633 parcelable Foo {
2634 int a;
2635 })");
2636
2637 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2638 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2639
2640 string rust_out;
2641 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2642 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2643
2644 // Other backends shouldn't be bothered
2645 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2646 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2647
2648 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2649 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2650
2651 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2652 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2653}
2654
Jiyong Park56f73d72019-06-11 12:20:28 +09002655class AidlOutputPathTest : public AidlTest {
2656 protected:
2657 void SetUp() override {
2658 AidlTest::SetUp();
2659 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2660 }
2661
2662 void Test(const Options& options, const std::string expected_output_path) {
2663 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2664 // check the existence
2665 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2666 }
2667};
2668
2669TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2670 // <out_dir> / <package_name> / <type_name>.java
2671 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2672}
2673
2674TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2675 // when output file is explicitly set, it is always respected. -o option is
2676 // ignored.
2677 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2678}
2679
2680TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2681 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2682}
2683
2684TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2685 // output is the same as the input file except for the suffix
2686 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2687}
2688
Devin Moore7b8d5c92020-03-17 14:14:08 -07002689TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002690 AidlError error;
2691 const string expected_stderr =
2692 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2693 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002694 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2695 R"(package p;
2696 interface IFoo {
2697 const int int32_max_oob = 2147483650;
2698 }
2699 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002700 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002701 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2702 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002703}
2704
Devin Moore7b8d5c92020-03-17 14:14:08 -07002705TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002706 AidlError error;
2707 const string expected_stderr =
2708 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2709 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002710 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2711 R"(package p;
2712 interface IFoo {
2713 const int int32_min_oob = -2147483650;
2714 }
2715 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002716 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002717 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2718 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002719}
2720
Devin Moore7b8d5c92020-03-17 14:14:08 -07002721TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002722 AidlError error;
2723 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002724 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002725 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002726 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2727 R"(package p;
2728 interface IFoo {
2729 const long int64_max_oob = 21474836509999999999999999;
2730 }
2731 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002732 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002733 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2734 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002735}
2736
Devin Moore7b8d5c92020-03-17 14:14:08 -07002737TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002738 AidlError error;
2739 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002740 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002741 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002742 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2743 R"(package p;
2744 interface IFoo {
2745 const long int64_min_oob = -21474836509999999999999999;
2746 }
2747 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002748 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002749 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2750 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002751}
2752
Devin Moore7b8d5c92020-03-17 14:14:08 -07002753TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002754 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002755 const string expected_stderr =
2756 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2757 "literal: byte\n"
2758 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2759 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002760 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2761 R"(package p;
2762 @Backing(type="byte")
2763 enum TestEnum {
2764 FOO = 127,
2765 BAR,
2766 }
2767 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002768 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002769 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002770 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002771}
2772
Devin Mooredecaf292020-04-30 09:16:40 -07002773TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2774 AidlError error;
2775 const string expected_stderr =
2776 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2777 "be one of: type\n"
2778 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2779 "be one of: type\n";
2780 CaptureStderr();
2781 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2782 R"(package p;
2783 @Backing(foo="byte")
2784 enum TestEnum {
2785 FOO = 1,
2786 BAR,
2787 }
2788 )",
2789 typenames_, GetLanguage(), &error));
2790 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2791 EXPECT_EQ(AidlError::BAD_TYPE, error);
2792}
2793
Jooyung Han66813932020-10-23 13:24:44 +09002794TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002795 io_delegate_.SetFileContents("Foo.aidl",
2796 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2797 "Map<String, Baz> d; Bar[] e; }");
2798 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2799 io_delegate_.SetFileContents("Baz.aidl",
2800 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002801 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2802 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2803}
2804
Jooyung Han66813932020-10-23 13:24:44 +09002805TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002806 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002807 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2808 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2809 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2810}
2811
Jooyung Han66813932020-10-23 13:24:44 +09002812TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002813 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002814 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo); }");
2815 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2816 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2817}
2818
Jooyung Han66813932020-10-23 13:24:44 +09002819TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002820 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002821 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo); }");
2822 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2823 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2824}
2825
Jooyung Han66813932020-10-23 13:24:44 +09002826TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002827 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002828 Options options = Options::From("aidl --lang=java Foo.aidl");
2829 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002830 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002831 "capitalizing the first letter\n";
2832 CaptureStderr();
2833 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2834 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2835}
Devin Moore53fc99c2020-08-12 08:07:52 -07002836
Jooyung Han1f14ab32020-10-14 13:48:29 +09002837const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2838
2839#include <a/ByteEnum.h>
2840#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09002841#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002842#include <binder/Status.h>
2843#include <cstdint>
Jooyung Han3df81ae2020-10-17 17:59:59 +09002844#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002845#include <utility>
2846#include <variant>
2847#include <vector>
2848
2849namespace a {
2850
2851class Foo : public ::android::Parcelable {
2852public:
Jooyung Han97945de2020-10-15 16:41:38 +09002853 inline bool operator!=(const Foo& rhs) const {
2854 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002855 }
Jooyung Han97945de2020-10-15 16:41:38 +09002856 inline bool operator<(const Foo& rhs) const {
2857 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002858 }
Jooyung Han97945de2020-10-15 16:41:38 +09002859 inline bool operator<=(const Foo& rhs) const {
2860 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002861 }
Jooyung Han97945de2020-10-15 16:41:38 +09002862 inline bool operator==(const Foo& rhs) const {
2863 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002864 }
Jooyung Han97945de2020-10-15 16:41:38 +09002865 inline bool operator>(const Foo& rhs) const {
2866 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002867 }
Jooyung Han97945de2020-10-15 16:41:38 +09002868 inline bool operator>=(const Foo& rhs) const {
2869 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002870 }
Jooyung Han97945de2020-10-15 16:41:38 +09002871
Jooyung Han1f14ab32020-10-14 13:48:29 +09002872 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09002873 ns = 0, // int[] ns;
2874 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002875 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002876 };
Jooyung Han97945de2020-10-15 16:41:38 +09002877
Jooyung Han1f14ab32020-10-14 13:48:29 +09002878 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09002879 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002880
2881 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09002882 Foo(const Foo&) = default;
2883 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002884 Foo& operator=(const Foo&) = default;
2885 Foo& operator=(Foo&&) = default;
2886
Jooyung Han97945de2020-10-15 16:41:38 +09002887 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
2888 constexpr Foo(_Tp&& _arg)
2889 : _value(std::forward<_Tp>(_arg)) {}
2890
2891 template <typename... _Tp>
2892 constexpr explicit Foo(_Tp&&... _args)
2893 : _value(std::forward<_Tp>(_args)...) {}
2894
2895 template <Tag _tag, typename... _Tp>
2896 static Foo make(_Tp&&... _args) {
2897 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002898 }
Jooyung Han97945de2020-10-15 16:41:38 +09002899
2900 template <Tag _tag, typename _Tp, typename... _Up>
2901 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
2902 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002903 }
2904
2905 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002906 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002907 }
2908
Jooyung Han97945de2020-10-15 16:41:38 +09002909 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002910 const auto& get() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002911 if (getTag() != _tag) { abort(); }
2912 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002913 }
2914
Jooyung Han97945de2020-10-15 16:41:38 +09002915 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002916 auto& get() {
Jooyung Han97945de2020-10-15 16:41:38 +09002917 if (getTag() != _tag) { abort(); }
2918 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002919 }
2920
Jooyung Han97945de2020-10-15 16:41:38 +09002921 template <Tag _tag, typename... _Tp>
2922 void set(_Tp&&... _args) {
2923 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002924 }
2925
2926 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
2927 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
2928 static const std::string& getParcelableDescriptor() {
2929 static const std::string DESCIPTOR = "a.Foo";
2930 return DESCIPTOR;
2931 }
2932private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09002933 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002934}; // class Foo
2935
2936} // namespace a
2937)";
2938
2939const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
2940
2941namespace a {
2942
2943::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
2944 ::android::status_t _aidl_ret_status;
2945 int32_t _aidl_tag;
2946 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
2947 switch (_aidl_tag) {
2948 case ns: {
2949 ::std::vector<int32_t> _aidl_value;
2950 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2951 set<ns>(std::move(_aidl_value));
2952 return ::android::OK; }
2953 case e: {
2954 ::a::ByteEnum _aidl_value;
2955 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
2956 set<e>(std::move(_aidl_value));
2957 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09002958 case pfd: {
2959 ::android::os::ParcelFileDescriptor _aidl_value;
2960 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2961 set<pfd>(std::move(_aidl_value));
2962 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09002963 }
2964 return ::android::BAD_VALUE;
2965}
2966
2967::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
2968 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
2969 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
2970 switch (getTag()) {
2971 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
2972 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09002973 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002974 }
2975 abort();
2976}
2977
2978} // namespace a
2979)";
2980
Jooyung Han6beac042020-10-17 21:59:43 +09002981const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
2982#include <android/binder_interface_utils.h>
2983#include <android/binder_parcelable_utils.h>
2984
2985#include <type_traits>
2986#include <utility>
2987#include <variant>
2988#include <cstdint>
2989#include <memory>
2990#include <optional>
2991#include <string>
2992#include <vector>
2993#ifdef BINDER_STABILITY_SUPPORT
2994#include <android/binder_stability.h>
2995#endif // BINDER_STABILITY_SUPPORT
2996#include <aidl/a/ByteEnum.h>
2997namespace aidl {
2998namespace a {
2999class Foo {
3000public:
3001 typedef std::false_type fixed_size;
3002 static const char* descriptor;
3003
3004 enum Tag : int32_t {
3005 ns = 0, // int[] ns;
3006 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003007 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003008 };
3009
3010 template<typename _Tp>
3011 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3012
3013 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3014 Foo(const Foo&) = default;
3015 Foo(Foo&&) = default;
3016 Foo& operator=(const Foo&) = default;
3017 Foo& operator=(Foo&&) = default;
3018
3019 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
3020 constexpr Foo(_Tp&& _arg)
3021 : _value(std::forward<_Tp>(_arg)) {}
3022
3023 template <typename... _Tp>
3024 constexpr explicit Foo(_Tp&&... _args)
3025 : _value(std::forward<_Tp>(_args)...) {}
3026
3027 template <Tag _tag, typename... _Tp>
3028 static Foo make(_Tp&&... _args) {
3029 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3030 }
3031
3032 template <Tag _tag, typename _Tp, typename... _Up>
3033 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3034 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3035 }
3036
3037 Tag getTag() const {
3038 return static_cast<Tag>(_value.index());
3039 }
3040
3041 template <Tag _tag>
3042 const auto& get() const {
3043 if (getTag() != _tag) { abort(); }
3044 return std::get<_tag>(_value);
3045 }
3046
3047 template <Tag _tag>
3048 auto& get() {
3049 if (getTag() != _tag) { abort(); }
3050 return std::get<_tag>(_value);
3051 }
3052
3053 template <Tag _tag, typename... _Tp>
3054 void set(_Tp&&... _args) {
3055 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3056 }
3057
3058 binder_status_t readFromParcel(const AParcel* _parcel);
3059 binder_status_t writeToParcel(AParcel* _parcel) const;
3060 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
3061private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003062 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003063};
3064} // namespace a
3065} // namespace aidl
3066)";
3067
3068const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3069
3070#include <android/binder_parcel_utils.h>
3071
3072namespace aidl {
3073namespace a {
3074const char* Foo::descriptor = "a.Foo";
3075
3076binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3077 binder_status_t _aidl_ret_status;
3078 int32_t _aidl_tag;
3079 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3080 switch (_aidl_tag) {
3081 case ns: {
3082 std::vector<int32_t> _aidl_value;
3083 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3084 set<ns>(std::move(_aidl_value));
3085 return STATUS_OK; }
3086 case e: {
3087 ::aidl::a::ByteEnum _aidl_value;
3088 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
3089 set<e>(std::move(_aidl_value));
3090 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003091 case pfd: {
3092 ::ndk::ScopedFileDescriptor _aidl_value;
3093 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3094 set<pfd>(std::move(_aidl_value));
3095 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003096 }
3097 return STATUS_BAD_VALUE;
3098}
3099binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3100 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3101 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3102 switch (getTag()) {
3103 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3104 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003105 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003106 }
3107 abort();
3108}
3109
3110} // namespace a
3111} // namespace aidl
3112)";
3113
Jooyung Han1f14ab32020-10-14 13:48:29 +09003114const char kUnionExampleExpectedOutputJava[] = R"(/*
3115 * This file is auto-generated. DO NOT MODIFY.
3116 */
3117package a;
3118
3119
3120public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003121 // tags for union fields
3122 public final static int ns = 0; // int[] ns;
3123 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003124 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003125
3126 private int _tag;
3127 private Object _value;
3128
3129 public Foo() {
3130 int[] value = {42};
3131 _set(ns, value);
3132 }
Jooyung Han97945de2020-10-15 16:41:38 +09003133
Jooyung Han1f14ab32020-10-14 13:48:29 +09003134 private Foo(android.os.Parcel _aidl_parcel) {
3135 readFromParcel(_aidl_parcel);
3136 }
Jooyung Han97945de2020-10-15 16:41:38 +09003137
Jooyung Han1f14ab32020-10-14 13:48:29 +09003138 private Foo(int tag, Object value) {
3139 _set(tag, value);
3140 }
3141
3142 public int getTag() {
3143 return _tag;
3144 }
3145
Jooyung Han97945de2020-10-15 16:41:38 +09003146 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003147
3148 public static Foo ns(int[] _value) {
3149 return new Foo(ns, _value);
3150 }
Jooyung Han97945de2020-10-15 16:41:38 +09003151
Jooyung Han1f14ab32020-10-14 13:48:29 +09003152 public int[] getNs() {
3153 _assertTag(ns);
3154 return (int[]) _value;
3155 }
Jooyung Han97945de2020-10-15 16:41:38 +09003156
Jooyung Han1f14ab32020-10-14 13:48:29 +09003157 public void setNs(int[] _value) {
3158 _set(ns, _value);
3159 }
3160
Jooyung Han97945de2020-10-15 16:41:38 +09003161 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003162
3163 public static Foo e(byte _value) {
3164 return new Foo(e, _value);
3165 }
Jooyung Han97945de2020-10-15 16:41:38 +09003166
Jooyung Han1f14ab32020-10-14 13:48:29 +09003167 public byte getE() {
3168 _assertTag(e);
3169 return (byte) _value;
3170 }
Jooyung Han97945de2020-10-15 16:41:38 +09003171
Jooyung Han1f14ab32020-10-14 13:48:29 +09003172 public void setE(byte _value) {
3173 _set(e, _value);
3174 }
3175
Jooyung Hand2fa0232020-10-19 02:51:41 +09003176 // ParcelFileDescriptor pfd;
3177
3178 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3179 return new Foo(pfd, _value);
3180 }
3181
3182 public android.os.ParcelFileDescriptor getPfd() {
3183 _assertTag(pfd);
3184 return (android.os.ParcelFileDescriptor) _value;
3185 }
3186
3187 public void setPfd(android.os.ParcelFileDescriptor _value) {
3188 _set(pfd, _value);
3189 }
3190
Jooyung Han1f14ab32020-10-14 13:48:29 +09003191 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3192 @Override
3193 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003194 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003195 }
3196 @Override
3197 public Foo[] newArray(int _aidl_size) {
3198 return new Foo[_aidl_size];
3199 }
3200 };
Jooyung Han97945de2020-10-15 16:41:38 +09003201
Jooyung Han1f14ab32020-10-14 13:48:29 +09003202 @Override
3203 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3204 _aidl_parcel.writeInt(_tag);
3205 switch (_tag) {
3206 case ns:
3207 _aidl_parcel.writeIntArray(getNs());
3208 break;
3209 case e:
3210 _aidl_parcel.writeByte(getE());
3211 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003212 case pfd:
3213 if ((getPfd()!=null)) {
3214 _aidl_parcel.writeInt(1);
3215 getPfd().writeToParcel(_aidl_parcel, 0);
3216 }
3217 else {
3218 _aidl_parcel.writeInt(0);
3219 }
3220 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003221 }
3222 }
Jooyung Han97945de2020-10-15 16:41:38 +09003223
Jooyung Han1f14ab32020-10-14 13:48:29 +09003224 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3225 int _aidl_tag;
3226 _aidl_tag = _aidl_parcel.readInt();
3227 switch (_aidl_tag) {
3228 case ns: {
3229 int[] _aidl_value;
3230 _aidl_value = _aidl_parcel.createIntArray();
3231 _set(_aidl_tag, _aidl_value);
3232 return; }
3233 case e: {
3234 byte _aidl_value;
3235 _aidl_value = _aidl_parcel.readByte();
3236 _set(_aidl_tag, _aidl_value);
3237 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003238 case pfd: {
3239 android.os.ParcelFileDescriptor _aidl_value;
3240 if ((0!=_aidl_parcel.readInt())) {
3241 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3242 }
3243 else {
3244 _aidl_value = null;
3245 }
3246 _set(_aidl_tag, _aidl_value);
3247 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003248 }
3249 throw new RuntimeException("union: out of range: " + _aidl_tag);
3250 }
Jooyung Han97945de2020-10-15 16:41:38 +09003251
Jooyung Han1f14ab32020-10-14 13:48:29 +09003252 @Override
3253 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003254 int _mask = 0;
3255 switch (getTag()) {
3256 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003257 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003258 break;
3259 }
3260 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003261 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003262 private int describeContents(Object _v) {
3263 if (_v == null) return 0;
3264 if (_v instanceof android.os.Parcelable) {
3265 return ((android.os.Parcelable) _v).describeContents();
3266 }
3267 return 0;
3268 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003269
3270 private void _assertTag(int tag) {
3271 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003272 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003273 }
3274 }
Jooyung Han97945de2020-10-15 16:41:38 +09003275
Jooyung Han1f14ab32020-10-14 13:48:29 +09003276 private String _tagString(int _tag) {
3277 switch (_tag) {
3278 case ns: return "ns";
3279 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003280 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003281 }
3282 throw new IllegalStateException("unknown field: " + _tag);
3283 }
Jooyung Han97945de2020-10-15 16:41:38 +09003284
Jooyung Han1f14ab32020-10-14 13:48:29 +09003285 private void _set(int tag, Object value) {
3286 this._tag = tag;
3287 this._value = value;
3288 }
3289}
3290)";
3291
Jooyung Han97945de2020-10-15 16:41:38 +09003292struct AidlUnionTest : ::testing::Test {
3293 void SetUp() override {
3294 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003295package a;
3296import a.ByteEnum;
3297union Foo {
3298 int[] ns = {42};
3299 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003300 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003301}
3302)");
Jooyung Han97945de2020-10-15 16:41:38 +09003303 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003304package a;
3305@Backing(type="byte")
3306enum ByteEnum {
3307 a, b, c
3308}
3309)");
Jooyung Han97945de2020-10-15 16:41:38 +09003310 }
3311 FakeIoDelegate io_delegate_;
3312 void Compile(string lang) {
3313 string command = "aidl --structured -I. -o out --lang=" + lang;
3314 if (lang == "cpp" || lang == "ndk") {
3315 command += " -h out";
3316 }
3317 command += " a/Foo.aidl";
3318 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003319 CaptureStderr();
3320 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3321 auto err = GetCapturedStderr();
3322 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003323 }
3324 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3325 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003326 string actual;
3327 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3328 EXPECT_EQ(expected, actual);
3329 }
Jooyung Han97945de2020-10-15 16:41:38 +09003330 }
3331};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003332
Jooyung Han97945de2020-10-15 16:41:38 +09003333TEST_F(AidlUnionTest, Example_Cpp) {
3334 Compile("cpp");
3335 EXPECT_COMPILE_OUTPUTS(
3336 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3337 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3338}
3339
Jooyung Han6beac042020-10-17 21:59:43 +09003340TEST_F(AidlUnionTest, Example_Ndk) {
3341 Compile("ndk");
3342 EXPECT_COMPILE_OUTPUTS(
3343 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3344 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3345}
3346
Jooyung Han97945de2020-10-15 16:41:38 +09003347TEST_F(AidlUnionTest, Example_Java) {
3348 Compile("java");
3349 EXPECT_COMPILE_OUTPUTS(
3350 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003351 // TODO(b/170689477) Rust
3352}
3353
Jooyung Hanfe89f122020-10-14 03:49:18 +09003354TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3355 const string method = "package a; union Foo {}";
3356 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3357 CaptureStderr();
3358 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3359 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3360}
3361
3362TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3363 const string method = "package a; union Foo { ParcelableHolder x; }";
3364 const string expected_stderr =
3365 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3366 CaptureStderr();
3367 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3368 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3369}
3370
Devin Moore53fc99c2020-08-12 08:07:52 -07003371TEST_P(AidlTest, GenericStructuredParcelable) {
3372 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3373 Options options =
3374 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3375 const string expected_stderr = "";
3376 CaptureStderr();
3377 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3378 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3379}
3380
Jooyung Han14004ed2020-10-16 03:49:57 +09003381struct GenericAidlTest : ::testing::Test {
3382 FakeIoDelegate io_delegate_;
3383 void Compile(string cmd) {
3384 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux> > x; }");
3385 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3386 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3387 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3388
3389 Options options = Options::From(cmd);
3390 CaptureStderr();
3391 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3392 EXPECT_EQ("", GetCapturedStderr());
3393 }
3394};
3395
3396TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3397 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3398 string code;
3399 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3400 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3401 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3402 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3403}
3404
3405TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3406 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3407 string code;
3408 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3409 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3410 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3411 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3412}
3413
Devin Moore53fc99c2020-08-12 08:07:52 -07003414TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3415 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3416 Options options =
3417 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3418 const string expected_stderr =
3419 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3420 CaptureStderr();
3421 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3422 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3423}
3424
3425TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3426 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3427 Options options =
3428 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3429 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3430 CaptureStderr();
3431 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3432 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3433}
3434
Jooyung Hanea2147c2020-10-21 18:16:56 +09003435constexpr char kDescriptContentsWithUntypedListMapInJava[] = R"(
3436 @Override
3437 public int describeContents() {
3438 int _mask = 0;
3439 _mask |= describeContents(l);
3440 _mask |= describeContents(m);
3441 return _mask;
3442 }
3443 private int describeContents(Object _v) {
3444 if (_v == null) return 0;
3445 Class<?> _clazz = _v.getClass();
3446 if (_clazz.isArray() && _clazz.getComponentType() == Object.class) {
3447 int _mask = 0;
3448 for (Object o : (Object[]) _v) {
3449 _mask |= describeContents(o);
3450 }
3451 return _mask;
3452 }
3453 if (_v instanceof java.io.FileDescriptor) {
3454 return android.os.Parcelable.CONTENTS_FILE_DESCRIPTOR;
3455 }
3456 if (_v instanceof java.util.Collection) {
3457 int _mask = 0;
3458 for (Object o : (java.util.Collection) _v) {
3459 _mask |= describeContents(o);
3460 }
3461 return _mask;
3462 }
3463 if (_v instanceof java.util.Map) {
3464 return describeContents(((java.util.Map) _v).values());
3465 }
3466 if (_v instanceof android.os.Parcelable) {
3467 return ((android.os.Parcelable) _v).describeContents();
3468 }
3469 if (_v instanceof android.util.SparseArray) {
3470 android.util.SparseArray _sa = (android.util.SparseArray) _v;
3471 int _mask = 0;
3472 int _N = _sa.size();
3473 int _i = 0;
3474 while (_i < _N) {
3475 _mask |= describeContents(_sa.valueAt(_i));
3476 _i++;
3477 }
3478 return _mask;
3479 }
3480 return 0;
3481 }
3482)";
3483TEST_F(AidlTest, SupportUntypeListAndMap) {
3484 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3485 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3486 CaptureStderr();
3487 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3488 EXPECT_EQ("", GetCapturedStderr());
3489
3490 string code;
3491 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
3492 EXPECT_THAT(code, testing::HasSubstr(kDescriptContentsWithUntypedListMapInJava));
3493}
3494
Christopher Wiley90be4e32015-10-20 14:55:25 -07003495} // namespace aidl
3496} // namespace android