blob: 44f4ac671f3de8ef67f346a1bd288707e7897ac6 [file] [log] [blame]
Chris Lattner59907c42007-08-10 20:18:51 +00001//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner0bc735f2007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattner59907c42007-08-10 20:18:51 +00007//
8//===----------------------------------------------------------------------===//
9//
Mike Stump1eb44332009-09-09 15:08:12 +000010// This file implements extra semantic analysis beyond what is enforced
Chris Lattner59907c42007-08-10 20:18:51 +000011// by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
John McCall5f8d6042011-08-27 01:09:30 +000015#include "clang/Sema/Initialization.h"
Douglas Gregore737f502010-08-12 20:07:10 +000016#include "clang/Sema/Sema.h"
John McCall2d887082010-08-25 22:03:47 +000017#include "clang/Sema/SemaInternal.h"
Eli Friedman276b0612011-10-11 02:20:01 +000018#include "clang/Sema/Initialization.h"
John McCall781472f2010-08-25 08:40:02 +000019#include "clang/Sema/ScopeInfo.h"
Ted Kremenek826a3452010-07-16 02:11:22 +000020#include "clang/Analysis/Analyses/FormatString.h"
Chris Lattner59907c42007-08-10 20:18:51 +000021#include "clang/AST/ASTContext.h"
Ken Dyck199c3d62010-01-11 17:06:35 +000022#include "clang/AST/CharUnits.h"
John McCall384aff82010-08-25 07:42:41 +000023#include "clang/AST/DeclCXX.h"
Daniel Dunbarc4a1dea2008-08-11 05:35:13 +000024#include "clang/AST/DeclObjC.h"
Ted Kremenek23245122007-08-20 16:18:38 +000025#include "clang/AST/ExprCXX.h"
Ted Kremenek7ff22b22008-06-16 18:00:42 +000026#include "clang/AST/ExprObjC.h"
John McCallf85e1932011-06-15 23:02:42 +000027#include "clang/AST/EvaluatedExprVisitor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000028#include "clang/AST/DeclObjC.h"
29#include "clang/AST/StmtCXX.h"
30#include "clang/AST/StmtObjC.h"
Chris Lattner59907c42007-08-10 20:18:51 +000031#include "clang/Lex/Preprocessor.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000032#include "llvm/ADT/BitVector.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000033#include "llvm/ADT/SmallString.h"
Mike Stumpf8c49212010-01-21 03:59:47 +000034#include "llvm/ADT/STLExtras.h"
Tom Care3bfc5f42010-06-09 04:11:11 +000035#include "llvm/Support/raw_ostream.h"
Eric Christopher691ebc32010-04-17 02:26:23 +000036#include "clang/Basic/TargetBuiltins.h"
Nate Begeman26a31422010-06-08 02:47:44 +000037#include "clang/Basic/TargetInfo.h"
Fariborz Jahanian7da71022010-09-07 19:38:13 +000038#include "clang/Basic/ConvertUTF.h"
Zhongxing Xua1f3dba2009-05-20 01:55:10 +000039#include <limits>
Chris Lattner59907c42007-08-10 20:18:51 +000040using namespace clang;
John McCall781472f2010-08-25 08:40:02 +000041using namespace sema;
Chris Lattner59907c42007-08-10 20:18:51 +000042
Chris Lattner60800082009-02-18 17:49:48 +000043SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
44 unsigned ByteNo) const {
Chris Lattner08f92e32010-11-17 07:37:15 +000045 return SL->getLocationOfByte(ByteNo, PP.getSourceManager(),
David Blaikie4e4d0842012-03-11 07:00:24 +000046 PP.getLangOpts(), PP.getTargetInfo());
Chris Lattner60800082009-02-18 17:49:48 +000047}
48
John McCall8e10f3b2011-02-26 05:39:39 +000049/// Checks that a call expression's argument count is the desired number.
50/// This is useful when doing custom type-checking. Returns true on error.
51static bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) {
52 unsigned argCount = call->getNumArgs();
53 if (argCount == desiredArgCount) return false;
54
55 if (argCount < desiredArgCount)
56 return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args)
57 << 0 /*function call*/ << desiredArgCount << argCount
58 << call->getSourceRange();
59
60 // Highlight all the excess arguments.
61 SourceRange range(call->getArg(desiredArgCount)->getLocStart(),
62 call->getArg(argCount - 1)->getLocEnd());
63
64 return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args)
65 << 0 /*function call*/ << desiredArgCount << argCount
66 << call->getArg(1)->getSourceRange();
67}
68
Julien Lerougee5939212012-04-28 17:39:16 +000069/// Check that the first argument to __builtin_annotation is an integer
70/// and the second argument is a non-wide string literal.
71static bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) {
72 if (checkArgCount(S, TheCall, 2))
73 return true;
74
75 // First argument should be an integer.
76 Expr *ValArg = TheCall->getArg(0);
77 QualType Ty = ValArg->getType();
78 if (!Ty->isIntegerType()) {
79 S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg)
80 << ValArg->getSourceRange();
Julien Lerouge77f68bb2011-09-09 22:41:49 +000081 return true;
82 }
Julien Lerougee5939212012-04-28 17:39:16 +000083
84 // Second argument should be a constant string.
85 Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts();
86 StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg);
87 if (!Literal || !Literal->isAscii()) {
88 S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg)
89 << StrArg->getSourceRange();
90 return true;
91 }
92
93 TheCall->setType(Ty);
Julien Lerouge77f68bb2011-09-09 22:41:49 +000094 return false;
95}
96
John McCall60d7b3a2010-08-24 06:29:42 +000097ExprResult
Anders Carlssond406bf02009-08-16 01:56:34 +000098Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
John McCall60d7b3a2010-08-24 06:29:42 +000099 ExprResult TheCallResult(Owned(TheCall));
Douglas Gregor2def4832008-11-17 20:34:05 +0000100
Chris Lattner946928f2010-10-01 23:23:24 +0000101 // Find out if any arguments are required to be integer constant expressions.
102 unsigned ICEArguments = 0;
103 ASTContext::GetBuiltinTypeError Error;
104 Context.GetBuiltinType(BuiltinID, Error, &ICEArguments);
105 if (Error != ASTContext::GE_None)
106 ICEArguments = 0; // Don't diagnose previously diagnosed errors.
107
108 // If any arguments are required to be ICE's, check and diagnose.
109 for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) {
110 // Skip arguments not required to be ICE's.
111 if ((ICEArguments & (1 << ArgNo)) == 0) continue;
112
113 llvm::APSInt Result;
114 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
115 return true;
116 ICEArguments &= ~(1 << ArgNo);
117 }
118
Anders Carlssond406bf02009-08-16 01:56:34 +0000119 switch (BuiltinID) {
Chris Lattner30ce3442007-12-19 23:59:04 +0000120 case Builtin::BI__builtin___CFStringMakeConstantString:
Chris Lattner925e60d2007-12-28 05:29:59 +0000121 assert(TheCall->getNumArgs() == 1 &&
Chris Lattner1b9a0792007-12-20 00:26:33 +0000122 "Wrong # arguments to builtin CFStringMakeConstantString");
Chris Lattner69039812009-02-18 06:01:06 +0000123 if (CheckObjCString(TheCall->getArg(0)))
Sebastian Redl0eb23302009-01-19 00:08:26 +0000124 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000125 break;
Ted Kremenek49ff7a12008-07-09 17:58:53 +0000126 case Builtin::BI__builtin_stdarg_start:
Chris Lattner30ce3442007-12-19 23:59:04 +0000127 case Builtin::BI__builtin_va_start:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000128 if (SemaBuiltinVAStart(TheCall))
129 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000130 break;
Chris Lattner1b9a0792007-12-20 00:26:33 +0000131 case Builtin::BI__builtin_isgreater:
132 case Builtin::BI__builtin_isgreaterequal:
133 case Builtin::BI__builtin_isless:
134 case Builtin::BI__builtin_islessequal:
135 case Builtin::BI__builtin_islessgreater:
136 case Builtin::BI__builtin_isunordered:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000137 if (SemaBuiltinUnorderedCompare(TheCall))
138 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000139 break;
Benjamin Kramere771a7a2010-02-15 22:42:31 +0000140 case Builtin::BI__builtin_fpclassify:
141 if (SemaBuiltinFPClassification(TheCall, 6))
142 return ExprError();
143 break;
Eli Friedman9ac6f622009-08-31 20:06:00 +0000144 case Builtin::BI__builtin_isfinite:
145 case Builtin::BI__builtin_isinf:
146 case Builtin::BI__builtin_isinf_sign:
147 case Builtin::BI__builtin_isnan:
148 case Builtin::BI__builtin_isnormal:
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +0000149 if (SemaBuiltinFPClassification(TheCall, 1))
Eli Friedman9ac6f622009-08-31 20:06:00 +0000150 return ExprError();
151 break;
Eli Friedmand38617c2008-05-14 19:38:39 +0000152 case Builtin::BI__builtin_shufflevector:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000153 return SemaBuiltinShuffleVector(TheCall);
154 // TheCall will be freed by the smart pointer here, but that's fine, since
155 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
Daniel Dunbar4493f792008-07-21 22:59:13 +0000156 case Builtin::BI__builtin_prefetch:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000157 if (SemaBuiltinPrefetch(TheCall))
158 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000159 break;
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +0000160 case Builtin::BI__builtin_object_size:
Sebastian Redl0eb23302009-01-19 00:08:26 +0000161 if (SemaBuiltinObjectSize(TheCall))
162 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000163 break;
Eli Friedmand875fed2009-05-03 04:46:36 +0000164 case Builtin::BI__builtin_longjmp:
165 if (SemaBuiltinLongjmp(TheCall))
166 return ExprError();
Anders Carlssond406bf02009-08-16 01:56:34 +0000167 break;
John McCall8e10f3b2011-02-26 05:39:39 +0000168
169 case Builtin::BI__builtin_classify_type:
170 if (checkArgCount(*this, TheCall, 1)) return true;
171 TheCall->setType(Context.IntTy);
172 break;
Chris Lattner75c29a02010-10-12 17:47:42 +0000173 case Builtin::BI__builtin_constant_p:
John McCall8e10f3b2011-02-26 05:39:39 +0000174 if (checkArgCount(*this, TheCall, 1)) return true;
175 TheCall->setType(Context.IntTy);
Chris Lattner75c29a02010-10-12 17:47:42 +0000176 break;
Chris Lattner5caa3702009-05-08 06:58:22 +0000177 case Builtin::BI__sync_fetch_and_add:
Douglas Gregora9766412011-11-28 16:30:08 +0000178 case Builtin::BI__sync_fetch_and_add_1:
179 case Builtin::BI__sync_fetch_and_add_2:
180 case Builtin::BI__sync_fetch_and_add_4:
181 case Builtin::BI__sync_fetch_and_add_8:
182 case Builtin::BI__sync_fetch_and_add_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000183 case Builtin::BI__sync_fetch_and_sub:
Douglas Gregora9766412011-11-28 16:30:08 +0000184 case Builtin::BI__sync_fetch_and_sub_1:
185 case Builtin::BI__sync_fetch_and_sub_2:
186 case Builtin::BI__sync_fetch_and_sub_4:
187 case Builtin::BI__sync_fetch_and_sub_8:
188 case Builtin::BI__sync_fetch_and_sub_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000189 case Builtin::BI__sync_fetch_and_or:
Douglas Gregora9766412011-11-28 16:30:08 +0000190 case Builtin::BI__sync_fetch_and_or_1:
191 case Builtin::BI__sync_fetch_and_or_2:
192 case Builtin::BI__sync_fetch_and_or_4:
193 case Builtin::BI__sync_fetch_and_or_8:
194 case Builtin::BI__sync_fetch_and_or_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000195 case Builtin::BI__sync_fetch_and_and:
Douglas Gregora9766412011-11-28 16:30:08 +0000196 case Builtin::BI__sync_fetch_and_and_1:
197 case Builtin::BI__sync_fetch_and_and_2:
198 case Builtin::BI__sync_fetch_and_and_4:
199 case Builtin::BI__sync_fetch_and_and_8:
200 case Builtin::BI__sync_fetch_and_and_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000201 case Builtin::BI__sync_fetch_and_xor:
Douglas Gregora9766412011-11-28 16:30:08 +0000202 case Builtin::BI__sync_fetch_and_xor_1:
203 case Builtin::BI__sync_fetch_and_xor_2:
204 case Builtin::BI__sync_fetch_and_xor_4:
205 case Builtin::BI__sync_fetch_and_xor_8:
206 case Builtin::BI__sync_fetch_and_xor_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000207 case Builtin::BI__sync_add_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000208 case Builtin::BI__sync_add_and_fetch_1:
209 case Builtin::BI__sync_add_and_fetch_2:
210 case Builtin::BI__sync_add_and_fetch_4:
211 case Builtin::BI__sync_add_and_fetch_8:
212 case Builtin::BI__sync_add_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000213 case Builtin::BI__sync_sub_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000214 case Builtin::BI__sync_sub_and_fetch_1:
215 case Builtin::BI__sync_sub_and_fetch_2:
216 case Builtin::BI__sync_sub_and_fetch_4:
217 case Builtin::BI__sync_sub_and_fetch_8:
218 case Builtin::BI__sync_sub_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000219 case Builtin::BI__sync_and_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000220 case Builtin::BI__sync_and_and_fetch_1:
221 case Builtin::BI__sync_and_and_fetch_2:
222 case Builtin::BI__sync_and_and_fetch_4:
223 case Builtin::BI__sync_and_and_fetch_8:
224 case Builtin::BI__sync_and_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000225 case Builtin::BI__sync_or_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000226 case Builtin::BI__sync_or_and_fetch_1:
227 case Builtin::BI__sync_or_and_fetch_2:
228 case Builtin::BI__sync_or_and_fetch_4:
229 case Builtin::BI__sync_or_and_fetch_8:
230 case Builtin::BI__sync_or_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000231 case Builtin::BI__sync_xor_and_fetch:
Douglas Gregora9766412011-11-28 16:30:08 +0000232 case Builtin::BI__sync_xor_and_fetch_1:
233 case Builtin::BI__sync_xor_and_fetch_2:
234 case Builtin::BI__sync_xor_and_fetch_4:
235 case Builtin::BI__sync_xor_and_fetch_8:
236 case Builtin::BI__sync_xor_and_fetch_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000237 case Builtin::BI__sync_val_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000238 case Builtin::BI__sync_val_compare_and_swap_1:
239 case Builtin::BI__sync_val_compare_and_swap_2:
240 case Builtin::BI__sync_val_compare_and_swap_4:
241 case Builtin::BI__sync_val_compare_and_swap_8:
242 case Builtin::BI__sync_val_compare_and_swap_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000243 case Builtin::BI__sync_bool_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000244 case Builtin::BI__sync_bool_compare_and_swap_1:
245 case Builtin::BI__sync_bool_compare_and_swap_2:
246 case Builtin::BI__sync_bool_compare_and_swap_4:
247 case Builtin::BI__sync_bool_compare_and_swap_8:
248 case Builtin::BI__sync_bool_compare_and_swap_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000249 case Builtin::BI__sync_lock_test_and_set:
Douglas Gregora9766412011-11-28 16:30:08 +0000250 case Builtin::BI__sync_lock_test_and_set_1:
251 case Builtin::BI__sync_lock_test_and_set_2:
252 case Builtin::BI__sync_lock_test_and_set_4:
253 case Builtin::BI__sync_lock_test_and_set_8:
254 case Builtin::BI__sync_lock_test_and_set_16:
Chris Lattner5caa3702009-05-08 06:58:22 +0000255 case Builtin::BI__sync_lock_release:
Douglas Gregora9766412011-11-28 16:30:08 +0000256 case Builtin::BI__sync_lock_release_1:
257 case Builtin::BI__sync_lock_release_2:
258 case Builtin::BI__sync_lock_release_4:
259 case Builtin::BI__sync_lock_release_8:
260 case Builtin::BI__sync_lock_release_16:
Chris Lattner23aa9c82011-04-09 03:57:26 +0000261 case Builtin::BI__sync_swap:
Douglas Gregora9766412011-11-28 16:30:08 +0000262 case Builtin::BI__sync_swap_1:
263 case Builtin::BI__sync_swap_2:
264 case Builtin::BI__sync_swap_4:
265 case Builtin::BI__sync_swap_8:
266 case Builtin::BI__sync_swap_16:
Chandler Carruthd2014572010-07-09 18:59:35 +0000267 return SemaBuiltinAtomicOverloaded(move(TheCallResult));
Richard Smithff34d402012-04-12 05:08:17 +0000268#define BUILTIN(ID, TYPE, ATTRS)
269#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \
270 case Builtin::BI##ID: \
271 return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::AO##ID);
272#include "clang/Basic/Builtins.def"
Julien Lerouge77f68bb2011-09-09 22:41:49 +0000273 case Builtin::BI__builtin_annotation:
Julien Lerougee5939212012-04-28 17:39:16 +0000274 if (SemaBuiltinAnnotation(*this, TheCall))
Julien Lerouge77f68bb2011-09-09 22:41:49 +0000275 return ExprError();
276 break;
Nate Begeman26a31422010-06-08 02:47:44 +0000277 }
278
279 // Since the target specific builtins for each arch overlap, only check those
280 // of the arch we are compiling for.
281 if (BuiltinID >= Builtin::FirstTSBuiltin) {
Douglas Gregorbcfd1f52011-09-02 00:18:52 +0000282 switch (Context.getTargetInfo().getTriple().getArch()) {
Nate Begeman26a31422010-06-08 02:47:44 +0000283 case llvm::Triple::arm:
284 case llvm::Triple::thumb:
285 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
286 return ExprError();
287 break;
Nate Begeman26a31422010-06-08 02:47:44 +0000288 default:
289 break;
290 }
291 }
292
293 return move(TheCallResult);
294}
295
Nate Begeman61eecf52010-06-14 05:21:25 +0000296// Get the valid immediate range for the specified NEON type code.
297static unsigned RFT(unsigned t, bool shift = false) {
Bob Wilsonda95f732011-11-08 01:16:11 +0000298 NeonTypeFlags Type(t);
299 int IsQuad = Type.isQuad();
300 switch (Type.getEltType()) {
301 case NeonTypeFlags::Int8:
302 case NeonTypeFlags::Poly8:
303 return shift ? 7 : (8 << IsQuad) - 1;
304 case NeonTypeFlags::Int16:
305 case NeonTypeFlags::Poly16:
306 return shift ? 15 : (4 << IsQuad) - 1;
307 case NeonTypeFlags::Int32:
308 return shift ? 31 : (2 << IsQuad) - 1;
309 case NeonTypeFlags::Int64:
310 return shift ? 63 : (1 << IsQuad) - 1;
311 case NeonTypeFlags::Float16:
312 assert(!shift && "cannot shift float types!");
313 return (4 << IsQuad) - 1;
314 case NeonTypeFlags::Float32:
315 assert(!shift && "cannot shift float types!");
316 return (2 << IsQuad) - 1;
Nate Begeman61eecf52010-06-14 05:21:25 +0000317 }
David Blaikie7530c032012-01-17 06:56:22 +0000318 llvm_unreachable("Invalid NeonTypeFlag!");
Nate Begeman61eecf52010-06-14 05:21:25 +0000319}
320
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000321/// getNeonEltType - Return the QualType corresponding to the elements of
322/// the vector type specified by the NeonTypeFlags. This is used to check
323/// the pointer arguments for Neon load/store intrinsics.
324static QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) {
325 switch (Flags.getEltType()) {
326 case NeonTypeFlags::Int8:
327 return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
328 case NeonTypeFlags::Int16:
329 return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy;
330 case NeonTypeFlags::Int32:
331 return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy;
332 case NeonTypeFlags::Int64:
333 return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy;
334 case NeonTypeFlags::Poly8:
335 return Context.SignedCharTy;
336 case NeonTypeFlags::Poly16:
337 return Context.ShortTy;
338 case NeonTypeFlags::Float16:
339 return Context.UnsignedShortTy;
340 case NeonTypeFlags::Float32:
341 return Context.FloatTy;
342 }
David Blaikie7530c032012-01-17 06:56:22 +0000343 llvm_unreachable("Invalid NeonTypeFlag!");
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000344}
345
Nate Begeman26a31422010-06-08 02:47:44 +0000346bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000347 llvm::APSInt Result;
348
Nate Begeman0d15c532010-06-13 04:47:52 +0000349 unsigned mask = 0;
Nate Begeman61eecf52010-06-14 05:21:25 +0000350 unsigned TV = 0;
Bob Wilson46482552011-11-16 21:32:23 +0000351 int PtrArgNum = -1;
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000352 bool HasConstPtr = false;
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000353 switch (BuiltinID) {
Nate Begemana23326b2010-06-17 04:17:01 +0000354#define GET_NEON_OVERLOAD_CHECK
355#include "clang/Basic/arm_neon.inc"
356#undef GET_NEON_OVERLOAD_CHECK
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000357 }
358
Nate Begeman0d15c532010-06-13 04:47:52 +0000359 // For NEON intrinsics which are overloaded on vector element type, validate
360 // the immediate which specifies which variant to emit.
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000361 unsigned ImmArg = TheCall->getNumArgs()-1;
Nate Begeman0d15c532010-06-13 04:47:52 +0000362 if (mask) {
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000363 if (SemaBuiltinConstantArg(TheCall, ImmArg, Result))
Nate Begeman0d15c532010-06-13 04:47:52 +0000364 return true;
365
Bob Wilsonda95f732011-11-08 01:16:11 +0000366 TV = Result.getLimitedValue(64);
367 if ((TV > 63) || (mask & (1 << TV)) == 0)
Nate Begeman0d15c532010-06-13 04:47:52 +0000368 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000369 << TheCall->getArg(ImmArg)->getSourceRange();
370 }
371
Bob Wilson46482552011-11-16 21:32:23 +0000372 if (PtrArgNum >= 0) {
Bob Wilson6f9f03e2011-11-08 05:04:11 +0000373 // Check that pointer arguments have the specified type.
Bob Wilson46482552011-11-16 21:32:23 +0000374 Expr *Arg = TheCall->getArg(PtrArgNum);
375 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg))
376 Arg = ICE->getSubExpr();
377 ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg);
378 QualType RHSTy = RHS.get()->getType();
379 QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context);
380 if (HasConstPtr)
381 EltTy = EltTy.withConst();
382 QualType LHSTy = Context.getPointerType(EltTy);
383 AssignConvertType ConvTy;
384 ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS);
385 if (RHS.isInvalid())
386 return true;
387 if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy,
388 RHS.get(), AA_Assigning))
389 return true;
Nate Begeman0d15c532010-06-13 04:47:52 +0000390 }
Nate Begeman1c2a88c2010-06-09 01:10:23 +0000391
Nate Begeman0d15c532010-06-13 04:47:52 +0000392 // For NEON intrinsics which take an immediate value as part of the
393 // instruction, range check them here.
Nate Begeman61eecf52010-06-14 05:21:25 +0000394 unsigned i = 0, l = 0, u = 0;
Nate Begeman0d15c532010-06-13 04:47:52 +0000395 switch (BuiltinID) {
396 default: return false;
Nate Begemanbb37f502010-07-29 22:48:34 +0000397 case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
398 case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
Nate Begeman99c40bb2010-08-03 21:32:34 +0000399 case ARM::BI__builtin_arm_vcvtr_f:
400 case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
Nate Begemana23326b2010-06-17 04:17:01 +0000401#define GET_NEON_IMMEDIATE_CHECK
402#include "clang/Basic/arm_neon.inc"
403#undef GET_NEON_IMMEDIATE_CHECK
Nate Begeman0d15c532010-06-13 04:47:52 +0000404 };
405
Nate Begeman61eecf52010-06-14 05:21:25 +0000406 // Check that the immediate argument is actually a constant.
Nate Begeman0d15c532010-06-13 04:47:52 +0000407 if (SemaBuiltinConstantArg(TheCall, i, Result))
408 return true;
409
Nate Begeman61eecf52010-06-14 05:21:25 +0000410 // Range check against the upper/lower values for this isntruction.
Nate Begeman0d15c532010-06-13 04:47:52 +0000411 unsigned Val = Result.getZExtValue();
Nate Begeman61eecf52010-06-14 05:21:25 +0000412 if (Val < l || Val > (u + l))
Nate Begeman0d15c532010-06-13 04:47:52 +0000413 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Benjamin Kramer476d8b82010-08-11 14:47:12 +0000414 << l << u+l << TheCall->getArg(i)->getSourceRange();
Nate Begeman0d15c532010-06-13 04:47:52 +0000415
Nate Begeman99c40bb2010-08-03 21:32:34 +0000416 // FIXME: VFP Intrinsics should error if VFP not present.
Nate Begeman26a31422010-06-08 02:47:44 +0000417 return false;
Anders Carlssond406bf02009-08-16 01:56:34 +0000418}
Daniel Dunbarde454282008-10-02 18:44:07 +0000419
Anders Carlssond406bf02009-08-16 01:56:34 +0000420/// CheckFunctionCall - Check a direct function call for various correctness
421/// and safety properties not strictly enforced by the C type system.
422bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) {
423 // Get the IdentifierInfo* for the called function.
424 IdentifierInfo *FnInfo = FDecl->getIdentifier();
425
426 // None of the checks below are needed for functions that don't have
427 // simple names (e.g., C++ conversion functions).
428 if (!FnInfo)
429 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000430
Daniel Dunbarde454282008-10-02 18:44:07 +0000431 // FIXME: This mechanism should be abstracted to be less fragile and
432 // more efficient. For example, just map function ids to custom
433 // handlers.
434
Ted Kremenekc82faca2010-09-09 04:33:05 +0000435 // Printf and scanf checking.
436 for (specific_attr_iterator<FormatAttr>
437 i = FDecl->specific_attr_begin<FormatAttr>(),
438 e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +0000439 CheckFormatArguments(*i, TheCall);
Chris Lattner59907c42007-08-10 20:18:51 +0000440 }
Mike Stump1eb44332009-09-09 15:08:12 +0000441
Ted Kremenekc82faca2010-09-09 04:33:05 +0000442 for (specific_attr_iterator<NonNullAttr>
443 i = FDecl->specific_attr_begin<NonNullAttr>(),
444 e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) {
Nick Lewycky909a70d2011-03-25 01:44:32 +0000445 CheckNonNullArguments(*i, TheCall->getArgs(),
446 TheCall->getCallee()->getLocStart());
Ted Kremenekc82faca2010-09-09 04:33:05 +0000447 }
Sebastian Redl0eb23302009-01-19 00:08:26 +0000448
Anna Zaks0a151a12012-01-17 00:37:07 +0000449 unsigned CMId = FDecl->getMemoryFunctionKind();
450 if (CMId == 0)
Anna Zaksd9b859a2012-01-13 21:52:01 +0000451 return false;
Ted Kremenekbd5da9d2011-08-18 20:55:45 +0000452
Anna Zaksd9b859a2012-01-13 21:52:01 +0000453 // Handle memory setting and copying functions.
Anna Zaks0a151a12012-01-17 00:37:07 +0000454 if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat)
Ted Kremenekbd5da9d2011-08-18 20:55:45 +0000455 CheckStrlcpycatArguments(TheCall, FnInfo);
Anna Zaksc36bedc2012-02-01 19:08:57 +0000456 else if (CMId == Builtin::BIstrncat)
457 CheckStrncatArguments(TheCall, FnInfo);
Anna Zaksd9b859a2012-01-13 21:52:01 +0000458 else
Anna Zaks0a151a12012-01-17 00:37:07 +0000459 CheckMemaccessArguments(TheCall, CMId, FnInfo);
Chandler Carruth7ccc95b2011-04-27 07:05:31 +0000460
Anders Carlssond406bf02009-08-16 01:56:34 +0000461 return false;
Anders Carlsson71993dd2007-08-17 05:31:46 +0000462}
463
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +0000464bool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac,
465 Expr **Args, unsigned NumArgs) {
466 for (specific_attr_iterator<FormatAttr>
467 i = Method->specific_attr_begin<FormatAttr>(),
468 e = Method->specific_attr_end<FormatAttr>(); i != e ; ++i) {
469
470 CheckFormatArguments(*i, Args, NumArgs, false, lbrac,
471 Method->getSourceRange());
472 }
473
474 // diagnose nonnull arguments.
475 for (specific_attr_iterator<NonNullAttr>
476 i = Method->specific_attr_begin<NonNullAttr>(),
477 e = Method->specific_attr_end<NonNullAttr>(); i != e; ++i) {
478 CheckNonNullArguments(*i, Args, lbrac);
479 }
480
481 return false;
482}
483
Anders Carlssond406bf02009-08-16 01:56:34 +0000484bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) {
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000485 const VarDecl *V = dyn_cast<VarDecl>(NDecl);
486 if (!V)
Anders Carlssond406bf02009-08-16 01:56:34 +0000487 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000488
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000489 QualType Ty = V->getType();
490 if (!Ty->isBlockPointerType())
Anders Carlssond406bf02009-08-16 01:56:34 +0000491 return false;
Mike Stump1eb44332009-09-09 15:08:12 +0000492
Jean-Daniel Dupas43d12512012-01-25 00:55:11 +0000493 // format string checking.
494 for (specific_attr_iterator<FormatAttr>
495 i = NDecl->specific_attr_begin<FormatAttr>(),
496 e = NDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) {
497 CheckFormatArguments(*i, TheCall);
498 }
Anders Carlssond406bf02009-08-16 01:56:34 +0000499
500 return false;
Fariborz Jahanian725165f2009-05-18 21:05:18 +0000501}
502
Richard Smithff34d402012-04-12 05:08:17 +0000503ExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult,
504 AtomicExpr::AtomicOp Op) {
Eli Friedman276b0612011-10-11 02:20:01 +0000505 CallExpr *TheCall = cast<CallExpr>(TheCallResult.get());
506 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
Eli Friedman276b0612011-10-11 02:20:01 +0000507
Richard Smithff34d402012-04-12 05:08:17 +0000508 // All these operations take one of the following forms:
509 enum {
510 // C __c11_atomic_init(A *, C)
511 Init,
512 // C __c11_atomic_load(A *, int)
513 Load,
514 // void __atomic_load(A *, CP, int)
515 Copy,
516 // C __c11_atomic_add(A *, M, int)
517 Arithmetic,
518 // C __atomic_exchange_n(A *, CP, int)
519 Xchg,
520 // void __atomic_exchange(A *, C *, CP, int)
521 GNUXchg,
522 // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int)
523 C11CmpXchg,
524 // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int)
525 GNUCmpXchg
526 } Form = Init;
527 const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 };
528 const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 };
529 // where:
530 // C is an appropriate type,
531 // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins,
532 // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise,
533 // M is C if C is an integer, and ptrdiff_t if C is a pointer, and
534 // the int parameters are for orderings.
Eli Friedman276b0612011-10-11 02:20:01 +0000535
Richard Smithff34d402012-04-12 05:08:17 +0000536 assert(AtomicExpr::AO__c11_atomic_init == 0 &&
537 AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load
538 && "need to update code for modified C11 atomics");
539 bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init &&
540 Op <= AtomicExpr::AO__c11_atomic_fetch_xor;
541 bool IsN = Op == AtomicExpr::AO__atomic_load_n ||
542 Op == AtomicExpr::AO__atomic_store_n ||
543 Op == AtomicExpr::AO__atomic_exchange_n ||
544 Op == AtomicExpr::AO__atomic_compare_exchange_n;
545 bool IsAddSub = false;
546
547 switch (Op) {
548 case AtomicExpr::AO__c11_atomic_init:
549 Form = Init;
550 break;
551
552 case AtomicExpr::AO__c11_atomic_load:
553 case AtomicExpr::AO__atomic_load_n:
554 Form = Load;
555 break;
556
557 case AtomicExpr::AO__c11_atomic_store:
558 case AtomicExpr::AO__atomic_load:
559 case AtomicExpr::AO__atomic_store:
560 case AtomicExpr::AO__atomic_store_n:
561 Form = Copy;
562 break;
563
564 case AtomicExpr::AO__c11_atomic_fetch_add:
565 case AtomicExpr::AO__c11_atomic_fetch_sub:
566 case AtomicExpr::AO__atomic_fetch_add:
567 case AtomicExpr::AO__atomic_fetch_sub:
568 case AtomicExpr::AO__atomic_add_fetch:
569 case AtomicExpr::AO__atomic_sub_fetch:
570 IsAddSub = true;
571 // Fall through.
572 case AtomicExpr::AO__c11_atomic_fetch_and:
573 case AtomicExpr::AO__c11_atomic_fetch_or:
574 case AtomicExpr::AO__c11_atomic_fetch_xor:
575 case AtomicExpr::AO__atomic_fetch_and:
576 case AtomicExpr::AO__atomic_fetch_or:
577 case AtomicExpr::AO__atomic_fetch_xor:
Richard Smith51b92402012-04-13 06:31:38 +0000578 case AtomicExpr::AO__atomic_fetch_nand:
Richard Smithff34d402012-04-12 05:08:17 +0000579 case AtomicExpr::AO__atomic_and_fetch:
580 case AtomicExpr::AO__atomic_or_fetch:
581 case AtomicExpr::AO__atomic_xor_fetch:
Richard Smith51b92402012-04-13 06:31:38 +0000582 case AtomicExpr::AO__atomic_nand_fetch:
Richard Smithff34d402012-04-12 05:08:17 +0000583 Form = Arithmetic;
584 break;
585
586 case AtomicExpr::AO__c11_atomic_exchange:
587 case AtomicExpr::AO__atomic_exchange_n:
588 Form = Xchg;
589 break;
590
591 case AtomicExpr::AO__atomic_exchange:
592 Form = GNUXchg;
593 break;
594
595 case AtomicExpr::AO__c11_atomic_compare_exchange_strong:
596 case AtomicExpr::AO__c11_atomic_compare_exchange_weak:
597 Form = C11CmpXchg;
598 break;
599
600 case AtomicExpr::AO__atomic_compare_exchange:
601 case AtomicExpr::AO__atomic_compare_exchange_n:
602 Form = GNUCmpXchg;
603 break;
604 }
605
606 // Check we have the right number of arguments.
607 if (TheCall->getNumArgs() < NumArgs[Form]) {
Eli Friedman276b0612011-10-11 02:20:01 +0000608 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Richard Smithff34d402012-04-12 05:08:17 +0000609 << 0 << NumArgs[Form] << TheCall->getNumArgs()
Eli Friedman276b0612011-10-11 02:20:01 +0000610 << TheCall->getCallee()->getSourceRange();
611 return ExprError();
Richard Smithff34d402012-04-12 05:08:17 +0000612 } else if (TheCall->getNumArgs() > NumArgs[Form]) {
613 Diag(TheCall->getArg(NumArgs[Form])->getLocStart(),
Eli Friedman276b0612011-10-11 02:20:01 +0000614 diag::err_typecheck_call_too_many_args)
Richard Smithff34d402012-04-12 05:08:17 +0000615 << 0 << NumArgs[Form] << TheCall->getNumArgs()
Eli Friedman276b0612011-10-11 02:20:01 +0000616 << TheCall->getCallee()->getSourceRange();
617 return ExprError();
618 }
619
Richard Smithff34d402012-04-12 05:08:17 +0000620 // Inspect the first argument of the atomic operation.
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000621 Expr *Ptr = TheCall->getArg(0);
Eli Friedman276b0612011-10-11 02:20:01 +0000622 Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get();
623 const PointerType *pointerType = Ptr->getType()->getAs<PointerType>();
624 if (!pointerType) {
Richard Smithff34d402012-04-12 05:08:17 +0000625 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
Eli Friedman276b0612011-10-11 02:20:01 +0000626 << Ptr->getType() << Ptr->getSourceRange();
627 return ExprError();
628 }
629
Richard Smithff34d402012-04-12 05:08:17 +0000630 // For a __c11 builtin, this should be a pointer to an _Atomic type.
631 QualType AtomTy = pointerType->getPointeeType(); // 'A'
632 QualType ValType = AtomTy; // 'C'
633 if (IsC11) {
634 if (!AtomTy->isAtomicType()) {
635 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic)
636 << Ptr->getType() << Ptr->getSourceRange();
637 return ExprError();
638 }
639 ValType = AtomTy->getAs<AtomicType>()->getValueType();
Eli Friedman276b0612011-10-11 02:20:01 +0000640 }
Eli Friedman276b0612011-10-11 02:20:01 +0000641
Richard Smithff34d402012-04-12 05:08:17 +0000642 // For an arithmetic operation, the implied arithmetic must be well-formed.
643 if (Form == Arithmetic) {
644 // gcc does not enforce these rules for GNU atomics, but we do so for sanity.
645 if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) {
646 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
647 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
648 return ExprError();
649 }
650 if (!IsAddSub && !ValType->isIntegerType()) {
651 Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int)
652 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
653 return ExprError();
654 }
655 } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) {
656 // For __atomic_*_n operations, the value type must be a scalar integral or
657 // pointer type which is 1, 2, 4, 8 or 16 bytes in length.
Eli Friedman276b0612011-10-11 02:20:01 +0000658 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
Richard Smithff34d402012-04-12 05:08:17 +0000659 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
660 return ExprError();
661 }
662
663 if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) {
664 // For GNU atomics, require a trivially-copyable type. This is not part of
665 // the GNU atomics specification, but we enforce it for sanity.
666 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy)
Eli Friedman276b0612011-10-11 02:20:01 +0000667 << Ptr->getType() << Ptr->getSourceRange();
668 return ExprError();
669 }
670
Richard Smithff34d402012-04-12 05:08:17 +0000671 // FIXME: For any builtin other than a load, the ValType must not be
672 // const-qualified.
Eli Friedman276b0612011-10-11 02:20:01 +0000673
674 switch (ValType.getObjCLifetime()) {
675 case Qualifiers::OCL_None:
676 case Qualifiers::OCL_ExplicitNone:
677 // okay
678 break;
679
680 case Qualifiers::OCL_Weak:
681 case Qualifiers::OCL_Strong:
682 case Qualifiers::OCL_Autoreleasing:
Richard Smithff34d402012-04-12 05:08:17 +0000683 // FIXME: Can this happen? By this point, ValType should be known
684 // to be trivially copyable.
Eli Friedman276b0612011-10-11 02:20:01 +0000685 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
686 << ValType << Ptr->getSourceRange();
687 return ExprError();
688 }
689
690 QualType ResultType = ValType;
Richard Smithff34d402012-04-12 05:08:17 +0000691 if (Form == Copy || Form == GNUXchg || Form == Init)
Eli Friedman276b0612011-10-11 02:20:01 +0000692 ResultType = Context.VoidTy;
Richard Smithff34d402012-04-12 05:08:17 +0000693 else if (Form == C11CmpXchg || Form == GNUCmpXchg)
Eli Friedman276b0612011-10-11 02:20:01 +0000694 ResultType = Context.BoolTy;
695
Richard Smithff34d402012-04-12 05:08:17 +0000696 // The type of a parameter passed 'by value'. In the GNU atomics, such
697 // arguments are actually passed as pointers.
698 QualType ByValType = ValType; // 'CP'
699 if (!IsC11 && !IsN)
700 ByValType = Ptr->getType();
701
Eli Friedman276b0612011-10-11 02:20:01 +0000702 // The first argument --- the pointer --- has a fixed type; we
703 // deduce the types of the rest of the arguments accordingly. Walk
704 // the remaining arguments, converting them to the deduced value type.
Richard Smithff34d402012-04-12 05:08:17 +0000705 for (unsigned i = 1; i != NumArgs[Form]; ++i) {
Eli Friedman276b0612011-10-11 02:20:01 +0000706 QualType Ty;
Richard Smithff34d402012-04-12 05:08:17 +0000707 if (i < NumVals[Form] + 1) {
708 switch (i) {
709 case 1:
710 // The second argument is the non-atomic operand. For arithmetic, this
711 // is always passed by value, and for a compare_exchange it is always
712 // passed by address. For the rest, GNU uses by-address and C11 uses
713 // by-value.
714 assert(Form != Load);
715 if (Form == Init || (Form == Arithmetic && ValType->isIntegerType()))
716 Ty = ValType;
717 else if (Form == Copy || Form == Xchg)
718 Ty = ByValType;
719 else if (Form == Arithmetic)
720 Ty = Context.getPointerDiffType();
721 else
722 Ty = Context.getPointerType(ValType.getUnqualifiedType());
723 break;
724 case 2:
725 // The third argument to compare_exchange / GNU exchange is a
726 // (pointer to a) desired value.
727 Ty = ByValType;
728 break;
729 case 3:
730 // The fourth argument to GNU compare_exchange is a 'weak' flag.
731 Ty = Context.BoolTy;
732 break;
733 }
Eli Friedman276b0612011-10-11 02:20:01 +0000734 } else {
735 // The order(s) are always converted to int.
736 Ty = Context.IntTy;
737 }
Richard Smithff34d402012-04-12 05:08:17 +0000738
Eli Friedman276b0612011-10-11 02:20:01 +0000739 InitializedEntity Entity =
740 InitializedEntity::InitializeParameter(Context, Ty, false);
Richard Smithff34d402012-04-12 05:08:17 +0000741 ExprResult Arg = TheCall->getArg(i);
Eli Friedman276b0612011-10-11 02:20:01 +0000742 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
743 if (Arg.isInvalid())
744 return true;
745 TheCall->setArg(i, Arg.get());
746 }
747
Richard Smithff34d402012-04-12 05:08:17 +0000748 // Permute the arguments into a 'consistent' order.
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000749 SmallVector<Expr*, 5> SubExprs;
750 SubExprs.push_back(Ptr);
Richard Smithff34d402012-04-12 05:08:17 +0000751 switch (Form) {
752 case Init:
753 // Note, AtomicExpr::getVal1() has a special case for this atomic.
David Chisnall7a7ee302012-01-16 17:27:18 +0000754 SubExprs.push_back(TheCall->getArg(1)); // Val1
Richard Smithff34d402012-04-12 05:08:17 +0000755 break;
756 case Load:
757 SubExprs.push_back(TheCall->getArg(1)); // Order
758 break;
759 case Copy:
760 case Arithmetic:
761 case Xchg:
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000762 SubExprs.push_back(TheCall->getArg(2)); // Order
763 SubExprs.push_back(TheCall->getArg(1)); // Val1
Richard Smithff34d402012-04-12 05:08:17 +0000764 break;
765 case GNUXchg:
766 // Note, AtomicExpr::getVal2() has a special case for this atomic.
767 SubExprs.push_back(TheCall->getArg(3)); // Order
768 SubExprs.push_back(TheCall->getArg(1)); // Val1
769 SubExprs.push_back(TheCall->getArg(2)); // Val2
770 break;
771 case C11CmpXchg:
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000772 SubExprs.push_back(TheCall->getArg(3)); // Order
773 SubExprs.push_back(TheCall->getArg(1)); // Val1
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000774 SubExprs.push_back(TheCall->getArg(4)); // OrderFail
David Chisnall2ebb98a2012-03-29 17:58:59 +0000775 SubExprs.push_back(TheCall->getArg(2)); // Val2
Richard Smithff34d402012-04-12 05:08:17 +0000776 break;
777 case GNUCmpXchg:
778 SubExprs.push_back(TheCall->getArg(4)); // Order
779 SubExprs.push_back(TheCall->getArg(1)); // Val1
780 SubExprs.push_back(TheCall->getArg(5)); // OrderFail
781 SubExprs.push_back(TheCall->getArg(2)); // Val2
782 SubExprs.push_back(TheCall->getArg(3)); // Weak
783 break;
Eli Friedman276b0612011-10-11 02:20:01 +0000784 }
Eli Friedmandfa64ba2011-10-14 22:48:56 +0000785
786 return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(),
787 SubExprs.data(), SubExprs.size(),
788 ResultType, Op,
789 TheCall->getRParenLoc()));
Eli Friedman276b0612011-10-11 02:20:01 +0000790}
791
792
John McCall5f8d6042011-08-27 01:09:30 +0000793/// checkBuiltinArgument - Given a call to a builtin function, perform
794/// normal type-checking on the given argument, updating the call in
795/// place. This is useful when a builtin function requires custom
796/// type-checking for some of its arguments but not necessarily all of
797/// them.
798///
799/// Returns true on error.
800static bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) {
801 FunctionDecl *Fn = E->getDirectCallee();
802 assert(Fn && "builtin call without direct callee!");
803
804 ParmVarDecl *Param = Fn->getParamDecl(ArgIndex);
805 InitializedEntity Entity =
806 InitializedEntity::InitializeParameter(S.Context, Param);
807
808 ExprResult Arg = E->getArg(0);
809 Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
810 if (Arg.isInvalid())
811 return true;
812
813 E->setArg(ArgIndex, Arg.take());
814 return false;
815}
816
Chris Lattner5caa3702009-05-08 06:58:22 +0000817/// SemaBuiltinAtomicOverloaded - We have a call to a function like
818/// __sync_fetch_and_add, which is an overloaded function based on the pointer
819/// type of its first argument. The main ActOnCallExpr routines have already
820/// promoted the types of arguments because all of these calls are prototyped as
821/// void(...).
822///
823/// This function goes through and does final semantic checking for these
824/// builtins,
John McCall60d7b3a2010-08-24 06:29:42 +0000825ExprResult
826Sema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
Chandler Carruthd2014572010-07-09 18:59:35 +0000827 CallExpr *TheCall = (CallExpr *)TheCallResult.get();
Chris Lattner5caa3702009-05-08 06:58:22 +0000828 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
829 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
830
831 // Ensure that we have at least one argument to do type inference from.
Chandler Carruthd2014572010-07-09 18:59:35 +0000832 if (TheCall->getNumArgs() < 1) {
833 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
834 << 0 << 1 << TheCall->getNumArgs()
835 << TheCall->getCallee()->getSourceRange();
836 return ExprError();
837 }
Mike Stump1eb44332009-09-09 15:08:12 +0000838
Chris Lattner5caa3702009-05-08 06:58:22 +0000839 // Inspect the first argument of the atomic builtin. This should always be
840 // a pointer type, whose element is an integral scalar or pointer type.
841 // Because it is a pointer type, we don't have to worry about any implicit
842 // casts here.
Chandler Carruthd2014572010-07-09 18:59:35 +0000843 // FIXME: We don't allow floating point scalars as input.
Chris Lattner5caa3702009-05-08 06:58:22 +0000844 Expr *FirstArg = TheCall->getArg(0);
Eli Friedman8c382062012-01-23 02:35:22 +0000845 ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg);
846 if (FirstArgResult.isInvalid())
847 return ExprError();
848 FirstArg = FirstArgResult.take();
849 TheCall->setArg(0, FirstArg);
850
John McCallf85e1932011-06-15 23:02:42 +0000851 const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>();
852 if (!pointerType) {
Chandler Carruthd2014572010-07-09 18:59:35 +0000853 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
854 << FirstArg->getType() << FirstArg->getSourceRange();
855 return ExprError();
856 }
Mike Stump1eb44332009-09-09 15:08:12 +0000857
John McCallf85e1932011-06-15 23:02:42 +0000858 QualType ValType = pointerType->getPointeeType();
Chris Lattnerdd5fa7a2010-09-17 21:12:38 +0000859 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
Chandler Carruthd2014572010-07-09 18:59:35 +0000860 !ValType->isBlockPointerType()) {
861 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
862 << FirstArg->getType() << FirstArg->getSourceRange();
863 return ExprError();
864 }
Chris Lattner5caa3702009-05-08 06:58:22 +0000865
John McCallf85e1932011-06-15 23:02:42 +0000866 switch (ValType.getObjCLifetime()) {
867 case Qualifiers::OCL_None:
868 case Qualifiers::OCL_ExplicitNone:
869 // okay
870 break;
871
872 case Qualifiers::OCL_Weak:
873 case Qualifiers::OCL_Strong:
874 case Qualifiers::OCL_Autoreleasing:
Argyrios Kyrtzidisb8b03132011-06-24 00:08:59 +0000875 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
John McCallf85e1932011-06-15 23:02:42 +0000876 << ValType << FirstArg->getSourceRange();
877 return ExprError();
878 }
879
John McCallb45ae252011-10-05 07:41:44 +0000880 // Strip any qualifiers off ValType.
881 ValType = ValType.getUnqualifiedType();
882
Chandler Carruth8d13d222010-07-18 20:54:12 +0000883 // The majority of builtins return a value, but a few have special return
884 // types, so allow them to override appropriately below.
885 QualType ResultType = ValType;
886
Chris Lattner5caa3702009-05-08 06:58:22 +0000887 // We need to figure out which concrete builtin this maps onto. For example,
888 // __sync_fetch_and_add with a 2 byte object turns into
889 // __sync_fetch_and_add_2.
890#define BUILTIN_ROW(x) \
891 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
892 Builtin::BI##x##_8, Builtin::BI##x##_16 }
Mike Stump1eb44332009-09-09 15:08:12 +0000893
Chris Lattner5caa3702009-05-08 06:58:22 +0000894 static const unsigned BuiltinIndices[][5] = {
895 BUILTIN_ROW(__sync_fetch_and_add),
896 BUILTIN_ROW(__sync_fetch_and_sub),
897 BUILTIN_ROW(__sync_fetch_and_or),
898 BUILTIN_ROW(__sync_fetch_and_and),
899 BUILTIN_ROW(__sync_fetch_and_xor),
Mike Stump1eb44332009-09-09 15:08:12 +0000900
Chris Lattner5caa3702009-05-08 06:58:22 +0000901 BUILTIN_ROW(__sync_add_and_fetch),
902 BUILTIN_ROW(__sync_sub_and_fetch),
903 BUILTIN_ROW(__sync_and_and_fetch),
904 BUILTIN_ROW(__sync_or_and_fetch),
905 BUILTIN_ROW(__sync_xor_and_fetch),
Mike Stump1eb44332009-09-09 15:08:12 +0000906
Chris Lattner5caa3702009-05-08 06:58:22 +0000907 BUILTIN_ROW(__sync_val_compare_and_swap),
908 BUILTIN_ROW(__sync_bool_compare_and_swap),
909 BUILTIN_ROW(__sync_lock_test_and_set),
Chris Lattner23aa9c82011-04-09 03:57:26 +0000910 BUILTIN_ROW(__sync_lock_release),
911 BUILTIN_ROW(__sync_swap)
Chris Lattner5caa3702009-05-08 06:58:22 +0000912 };
Mike Stump1eb44332009-09-09 15:08:12 +0000913#undef BUILTIN_ROW
914
Chris Lattner5caa3702009-05-08 06:58:22 +0000915 // Determine the index of the size.
916 unsigned SizeIndex;
Ken Dyck199c3d62010-01-11 17:06:35 +0000917 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
Chris Lattner5caa3702009-05-08 06:58:22 +0000918 case 1: SizeIndex = 0; break;
919 case 2: SizeIndex = 1; break;
920 case 4: SizeIndex = 2; break;
921 case 8: SizeIndex = 3; break;
922 case 16: SizeIndex = 4; break;
923 default:
Chandler Carruthd2014572010-07-09 18:59:35 +0000924 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
925 << FirstArg->getType() << FirstArg->getSourceRange();
926 return ExprError();
Chris Lattner5caa3702009-05-08 06:58:22 +0000927 }
Mike Stump1eb44332009-09-09 15:08:12 +0000928
Chris Lattner5caa3702009-05-08 06:58:22 +0000929 // Each of these builtins has one pointer argument, followed by some number of
930 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
931 // that we ignore. Find out which row of BuiltinIndices to read from as well
932 // as the number of fixed args.
Douglas Gregor7814e6d2009-09-12 00:22:50 +0000933 unsigned BuiltinID = FDecl->getBuiltinID();
Chris Lattner5caa3702009-05-08 06:58:22 +0000934 unsigned BuiltinIndex, NumFixed = 1;
935 switch (BuiltinID) {
David Blaikieb219cfc2011-09-23 05:06:16 +0000936 default: llvm_unreachable("Unknown overloaded atomic builtin!");
Douglas Gregora9766412011-11-28 16:30:08 +0000937 case Builtin::BI__sync_fetch_and_add:
938 case Builtin::BI__sync_fetch_and_add_1:
939 case Builtin::BI__sync_fetch_and_add_2:
940 case Builtin::BI__sync_fetch_and_add_4:
941 case Builtin::BI__sync_fetch_and_add_8:
942 case Builtin::BI__sync_fetch_and_add_16:
943 BuiltinIndex = 0;
944 break;
945
946 case Builtin::BI__sync_fetch_and_sub:
947 case Builtin::BI__sync_fetch_and_sub_1:
948 case Builtin::BI__sync_fetch_and_sub_2:
949 case Builtin::BI__sync_fetch_and_sub_4:
950 case Builtin::BI__sync_fetch_and_sub_8:
951 case Builtin::BI__sync_fetch_and_sub_16:
952 BuiltinIndex = 1;
953 break;
954
955 case Builtin::BI__sync_fetch_and_or:
956 case Builtin::BI__sync_fetch_and_or_1:
957 case Builtin::BI__sync_fetch_and_or_2:
958 case Builtin::BI__sync_fetch_and_or_4:
959 case Builtin::BI__sync_fetch_and_or_8:
960 case Builtin::BI__sync_fetch_and_or_16:
961 BuiltinIndex = 2;
962 break;
963
964 case Builtin::BI__sync_fetch_and_and:
965 case Builtin::BI__sync_fetch_and_and_1:
966 case Builtin::BI__sync_fetch_and_and_2:
967 case Builtin::BI__sync_fetch_and_and_4:
968 case Builtin::BI__sync_fetch_and_and_8:
969 case Builtin::BI__sync_fetch_and_and_16:
970 BuiltinIndex = 3;
971 break;
Mike Stump1eb44332009-09-09 15:08:12 +0000972
Douglas Gregora9766412011-11-28 16:30:08 +0000973 case Builtin::BI__sync_fetch_and_xor:
974 case Builtin::BI__sync_fetch_and_xor_1:
975 case Builtin::BI__sync_fetch_and_xor_2:
976 case Builtin::BI__sync_fetch_and_xor_4:
977 case Builtin::BI__sync_fetch_and_xor_8:
978 case Builtin::BI__sync_fetch_and_xor_16:
979 BuiltinIndex = 4;
980 break;
981
982 case Builtin::BI__sync_add_and_fetch:
983 case Builtin::BI__sync_add_and_fetch_1:
984 case Builtin::BI__sync_add_and_fetch_2:
985 case Builtin::BI__sync_add_and_fetch_4:
986 case Builtin::BI__sync_add_and_fetch_8:
987 case Builtin::BI__sync_add_and_fetch_16:
988 BuiltinIndex = 5;
989 break;
990
991 case Builtin::BI__sync_sub_and_fetch:
992 case Builtin::BI__sync_sub_and_fetch_1:
993 case Builtin::BI__sync_sub_and_fetch_2:
994 case Builtin::BI__sync_sub_and_fetch_4:
995 case Builtin::BI__sync_sub_and_fetch_8:
996 case Builtin::BI__sync_sub_and_fetch_16:
997 BuiltinIndex = 6;
998 break;
999
1000 case Builtin::BI__sync_and_and_fetch:
1001 case Builtin::BI__sync_and_and_fetch_1:
1002 case Builtin::BI__sync_and_and_fetch_2:
1003 case Builtin::BI__sync_and_and_fetch_4:
1004 case Builtin::BI__sync_and_and_fetch_8:
1005 case Builtin::BI__sync_and_and_fetch_16:
1006 BuiltinIndex = 7;
1007 break;
1008
1009 case Builtin::BI__sync_or_and_fetch:
1010 case Builtin::BI__sync_or_and_fetch_1:
1011 case Builtin::BI__sync_or_and_fetch_2:
1012 case Builtin::BI__sync_or_and_fetch_4:
1013 case Builtin::BI__sync_or_and_fetch_8:
1014 case Builtin::BI__sync_or_and_fetch_16:
1015 BuiltinIndex = 8;
1016 break;
1017
1018 case Builtin::BI__sync_xor_and_fetch:
1019 case Builtin::BI__sync_xor_and_fetch_1:
1020 case Builtin::BI__sync_xor_and_fetch_2:
1021 case Builtin::BI__sync_xor_and_fetch_4:
1022 case Builtin::BI__sync_xor_and_fetch_8:
1023 case Builtin::BI__sync_xor_and_fetch_16:
1024 BuiltinIndex = 9;
1025 break;
Mike Stump1eb44332009-09-09 15:08:12 +00001026
Chris Lattner5caa3702009-05-08 06:58:22 +00001027 case Builtin::BI__sync_val_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +00001028 case Builtin::BI__sync_val_compare_and_swap_1:
1029 case Builtin::BI__sync_val_compare_and_swap_2:
1030 case Builtin::BI__sync_val_compare_and_swap_4:
1031 case Builtin::BI__sync_val_compare_and_swap_8:
1032 case Builtin::BI__sync_val_compare_and_swap_16:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +00001033 BuiltinIndex = 10;
Chris Lattner5caa3702009-05-08 06:58:22 +00001034 NumFixed = 2;
1035 break;
Douglas Gregora9766412011-11-28 16:30:08 +00001036
Chris Lattner5caa3702009-05-08 06:58:22 +00001037 case Builtin::BI__sync_bool_compare_and_swap:
Douglas Gregora9766412011-11-28 16:30:08 +00001038 case Builtin::BI__sync_bool_compare_and_swap_1:
1039 case Builtin::BI__sync_bool_compare_and_swap_2:
1040 case Builtin::BI__sync_bool_compare_and_swap_4:
1041 case Builtin::BI__sync_bool_compare_and_swap_8:
1042 case Builtin::BI__sync_bool_compare_and_swap_16:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +00001043 BuiltinIndex = 11;
Chris Lattner5caa3702009-05-08 06:58:22 +00001044 NumFixed = 2;
Chandler Carruth8d13d222010-07-18 20:54:12 +00001045 ResultType = Context.BoolTy;
Chris Lattner5caa3702009-05-08 06:58:22 +00001046 break;
Douglas Gregora9766412011-11-28 16:30:08 +00001047
1048 case Builtin::BI__sync_lock_test_and_set:
1049 case Builtin::BI__sync_lock_test_and_set_1:
1050 case Builtin::BI__sync_lock_test_and_set_2:
1051 case Builtin::BI__sync_lock_test_and_set_4:
1052 case Builtin::BI__sync_lock_test_and_set_8:
1053 case Builtin::BI__sync_lock_test_and_set_16:
1054 BuiltinIndex = 12;
1055 break;
1056
Chris Lattner5caa3702009-05-08 06:58:22 +00001057 case Builtin::BI__sync_lock_release:
Douglas Gregora9766412011-11-28 16:30:08 +00001058 case Builtin::BI__sync_lock_release_1:
1059 case Builtin::BI__sync_lock_release_2:
1060 case Builtin::BI__sync_lock_release_4:
1061 case Builtin::BI__sync_lock_release_8:
1062 case Builtin::BI__sync_lock_release_16:
Daniel Dunbar7eff7c42010-03-25 17:13:09 +00001063 BuiltinIndex = 13;
Chris Lattner5caa3702009-05-08 06:58:22 +00001064 NumFixed = 0;
Chandler Carruth8d13d222010-07-18 20:54:12 +00001065 ResultType = Context.VoidTy;
Chris Lattner5caa3702009-05-08 06:58:22 +00001066 break;
Douglas Gregora9766412011-11-28 16:30:08 +00001067
1068 case Builtin::BI__sync_swap:
1069 case Builtin::BI__sync_swap_1:
1070 case Builtin::BI__sync_swap_2:
1071 case Builtin::BI__sync_swap_4:
1072 case Builtin::BI__sync_swap_8:
1073 case Builtin::BI__sync_swap_16:
1074 BuiltinIndex = 14;
1075 break;
Chris Lattner5caa3702009-05-08 06:58:22 +00001076 }
Mike Stump1eb44332009-09-09 15:08:12 +00001077
Chris Lattner5caa3702009-05-08 06:58:22 +00001078 // Now that we know how many fixed arguments we expect, first check that we
1079 // have at least that many.
Chandler Carruthd2014572010-07-09 18:59:35 +00001080 if (TheCall->getNumArgs() < 1+NumFixed) {
1081 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
1082 << 0 << 1+NumFixed << TheCall->getNumArgs()
1083 << TheCall->getCallee()->getSourceRange();
1084 return ExprError();
1085 }
Mike Stump1eb44332009-09-09 15:08:12 +00001086
Chris Lattnere7ac0a92009-05-08 15:36:58 +00001087 // Get the decl for the concrete builtin from this, we can tell what the
1088 // concrete integer type we should convert to is.
1089 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
1090 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
1091 IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
Mike Stump1eb44332009-09-09 15:08:12 +00001092 FunctionDecl *NewBuiltinDecl =
Chris Lattnere7ac0a92009-05-08 15:36:58 +00001093 cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
1094 TUScope, false, DRE->getLocStart()));
Chandler Carruthd2014572010-07-09 18:59:35 +00001095
John McCallf871d0c2010-08-07 06:22:56 +00001096 // The first argument --- the pointer --- has a fixed type; we
1097 // deduce the types of the rest of the arguments accordingly. Walk
1098 // the remaining arguments, converting them to the deduced value type.
Chris Lattner5caa3702009-05-08 06:58:22 +00001099 for (unsigned i = 0; i != NumFixed; ++i) {
John Wiegley429bb272011-04-08 18:41:53 +00001100 ExprResult Arg = TheCall->getArg(i+1);
Mike Stump1eb44332009-09-09 15:08:12 +00001101
Chris Lattner5caa3702009-05-08 06:58:22 +00001102 // GCC does an implicit conversion to the pointer or integer ValType. This
1103 // can fail in some cases (1i -> int**), check for this error case now.
John McCallb45ae252011-10-05 07:41:44 +00001104 // Initialize the argument.
1105 InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
1106 ValType, /*consume*/ false);
1107 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
John Wiegley429bb272011-04-08 18:41:53 +00001108 if (Arg.isInvalid())
Chandler Carruthd2014572010-07-09 18:59:35 +00001109 return ExprError();
Mike Stump1eb44332009-09-09 15:08:12 +00001110
Chris Lattner5caa3702009-05-08 06:58:22 +00001111 // Okay, we have something that *can* be converted to the right type. Check
1112 // to see if there is a potentially weird extension going on here. This can
1113 // happen when you do an atomic operation on something like an char* and
1114 // pass in 42. The 42 gets converted to char. This is even more strange
1115 // for things like 45.123 -> char, etc.
Mike Stump1eb44332009-09-09 15:08:12 +00001116 // FIXME: Do this check.
John McCallb45ae252011-10-05 07:41:44 +00001117 TheCall->setArg(i+1, Arg.take());
Chris Lattner5caa3702009-05-08 06:58:22 +00001118 }
Mike Stump1eb44332009-09-09 15:08:12 +00001119
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +00001120 ASTContext& Context = this->getASTContext();
1121
1122 // Create a new DeclRefExpr to refer to the new decl.
1123 DeclRefExpr* NewDRE = DeclRefExpr::Create(
1124 Context,
1125 DRE->getQualifierLoc(),
Abramo Bagnarae4b92762012-01-27 09:46:47 +00001126 SourceLocation(),
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +00001127 NewBuiltinDecl,
John McCallf4b88a42012-03-10 09:33:50 +00001128 /*enclosing*/ false,
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +00001129 DRE->getLocation(),
1130 NewBuiltinDecl->getType(),
1131 DRE->getValueKind());
Mike Stump1eb44332009-09-09 15:08:12 +00001132
Chris Lattner5caa3702009-05-08 06:58:22 +00001133 // Set the callee in the CallExpr.
1134 // FIXME: This leaks the original parens and implicit casts.
Douglas Gregorbbcb7ea2011-09-09 16:51:10 +00001135 ExprResult PromotedCall = UsualUnaryConversions(NewDRE);
John Wiegley429bb272011-04-08 18:41:53 +00001136 if (PromotedCall.isInvalid())
1137 return ExprError();
1138 TheCall->setCallee(PromotedCall.take());
Mike Stump1eb44332009-09-09 15:08:12 +00001139
Chandler Carruthdb4325b2010-07-18 07:23:17 +00001140 // Change the result type of the call to match the original value type. This
1141 // is arbitrary, but the codegen for these builtins ins design to handle it
1142 // gracefully.
Chandler Carruth8d13d222010-07-18 20:54:12 +00001143 TheCall->setType(ResultType);
Chandler Carruthd2014572010-07-09 18:59:35 +00001144
1145 return move(TheCallResult);
Chris Lattner5caa3702009-05-08 06:58:22 +00001146}
1147
Chris Lattner69039812009-02-18 06:01:06 +00001148/// CheckObjCString - Checks that the argument to the builtin
Anders Carlsson71993dd2007-08-17 05:31:46 +00001149/// CFString constructor is correct
Steve Narofffd942622009-04-13 20:26:29 +00001150/// Note: It might also make sense to do the UTF-16 conversion here (would
1151/// simplify the backend).
Chris Lattner69039812009-02-18 06:01:06 +00001152bool Sema::CheckObjCString(Expr *Arg) {
Chris Lattner56f34942008-02-13 01:02:39 +00001153 Arg = Arg->IgnoreParenCasts();
Anders Carlsson71993dd2007-08-17 05:31:46 +00001154 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
1155
Douglas Gregor5cee1192011-07-27 05:40:30 +00001156 if (!Literal || !Literal->isAscii()) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001157 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
1158 << Arg->getSourceRange();
Anders Carlsson9cdc4d32007-08-17 15:44:17 +00001159 return true;
Anders Carlsson71993dd2007-08-17 05:31:46 +00001160 }
Mike Stump1eb44332009-09-09 15:08:12 +00001161
Fariborz Jahanian7da71022010-09-07 19:38:13 +00001162 if (Literal->containsNonAsciiOrNull()) {
Chris Lattner5f9e2722011-07-23 10:55:15 +00001163 StringRef String = Literal->getString();
Fariborz Jahanian7da71022010-09-07 19:38:13 +00001164 unsigned NumBytes = String.size();
Chris Lattner5f9e2722011-07-23 10:55:15 +00001165 SmallVector<UTF16, 128> ToBuf(NumBytes);
Fariborz Jahanian7da71022010-09-07 19:38:13 +00001166 const UTF8 *FromPtr = (UTF8 *)String.data();
1167 UTF16 *ToPtr = &ToBuf[0];
1168
1169 ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes,
1170 &ToPtr, ToPtr + NumBytes,
1171 strictConversion);
1172 // Check for conversion failure.
1173 if (Result != conversionOK)
1174 Diag(Arg->getLocStart(),
1175 diag::warn_cfstring_truncated) << Arg->getSourceRange();
1176 }
Anders Carlsson9cdc4d32007-08-17 15:44:17 +00001177 return false;
Chris Lattner59907c42007-08-10 20:18:51 +00001178}
1179
Chris Lattnerc27c6652007-12-20 00:05:45 +00001180/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
1181/// Emit an error and return true on failure, return false on success.
Chris Lattner925e60d2007-12-28 05:29:59 +00001182bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
1183 Expr *Fn = TheCall->getCallee();
1184 if (TheCall->getNumArgs() > 2) {
Chris Lattner2c21a072008-11-21 18:44:24 +00001185 Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001186 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +00001187 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1188 << Fn->getSourceRange()
Mike Stump1eb44332009-09-09 15:08:12 +00001189 << SourceRange(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001190 (*(TheCall->arg_end()-1))->getLocEnd());
Chris Lattner30ce3442007-12-19 23:59:04 +00001191 return true;
1192 }
Eli Friedman56f20ae2008-12-15 22:05:35 +00001193
1194 if (TheCall->getNumArgs() < 2) {
Eric Christopherd77b9a22010-04-16 04:48:22 +00001195 return Diag(TheCall->getLocEnd(),
1196 diag::err_typecheck_call_too_few_args_at_least)
1197 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
Eli Friedman56f20ae2008-12-15 22:05:35 +00001198 }
1199
John McCall5f8d6042011-08-27 01:09:30 +00001200 // Type-check the first argument normally.
1201 if (checkBuiltinArgument(*this, TheCall, 0))
1202 return true;
1203
Chris Lattnerc27c6652007-12-20 00:05:45 +00001204 // Determine whether the current function is variadic or not.
Douglas Gregor9ea9bdb2010-03-01 23:15:13 +00001205 BlockScopeInfo *CurBlock = getCurBlock();
Chris Lattnerc27c6652007-12-20 00:05:45 +00001206 bool isVariadic;
Steve Naroffcd9c5142009-04-15 19:33:47 +00001207 if (CurBlock)
John McCallc71a4912010-06-04 19:02:56 +00001208 isVariadic = CurBlock->TheDecl->isVariadic();
Ted Kremenek9498d382010-04-29 16:49:01 +00001209 else if (FunctionDecl *FD = getCurFunctionDecl())
1210 isVariadic = FD->isVariadic();
1211 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +00001212 isVariadic = getCurMethodDecl()->isVariadic();
Mike Stump1eb44332009-09-09 15:08:12 +00001213
Chris Lattnerc27c6652007-12-20 00:05:45 +00001214 if (!isVariadic) {
Chris Lattner30ce3442007-12-19 23:59:04 +00001215 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
1216 return true;
1217 }
Mike Stump1eb44332009-09-09 15:08:12 +00001218
Chris Lattner30ce3442007-12-19 23:59:04 +00001219 // Verify that the second argument to the builtin is the last argument of the
1220 // current function or method.
1221 bool SecondArgIsLastNamedArgument = false;
Anders Carlssone2c14102008-02-13 01:22:59 +00001222 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001223
Anders Carlsson88cf2262008-02-11 04:20:54 +00001224 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
1225 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
Chris Lattner30ce3442007-12-19 23:59:04 +00001226 // FIXME: This isn't correct for methods (results in bogus warning).
1227 // Get the last formal in the current function.
Anders Carlsson88cf2262008-02-11 04:20:54 +00001228 const ParmVarDecl *LastArg;
Steve Naroffcd9c5142009-04-15 19:33:47 +00001229 if (CurBlock)
1230 LastArg = *(CurBlock->TheDecl->param_end()-1);
1231 else if (FunctionDecl *FD = getCurFunctionDecl())
Chris Lattner371f2582008-12-04 23:50:19 +00001232 LastArg = *(FD->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +00001233 else
Argyrios Kyrtzidis53d0ea52008-06-28 06:07:14 +00001234 LastArg = *(getCurMethodDecl()->param_end()-1);
Chris Lattner30ce3442007-12-19 23:59:04 +00001235 SecondArgIsLastNamedArgument = PV == LastArg;
1236 }
1237 }
Mike Stump1eb44332009-09-09 15:08:12 +00001238
Chris Lattner30ce3442007-12-19 23:59:04 +00001239 if (!SecondArgIsLastNamedArgument)
Mike Stump1eb44332009-09-09 15:08:12 +00001240 Diag(TheCall->getArg(1)->getLocStart(),
Chris Lattner30ce3442007-12-19 23:59:04 +00001241 diag::warn_second_parameter_of_va_start_not_last_named_argument);
1242 return false;
Eli Friedman6cfda232008-05-20 08:23:37 +00001243}
Chris Lattner30ce3442007-12-19 23:59:04 +00001244
Chris Lattner1b9a0792007-12-20 00:26:33 +00001245/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
1246/// friends. This is declared to take (...), so we have to check everything.
Chris Lattner925e60d2007-12-28 05:29:59 +00001247bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
1248 if (TheCall->getNumArgs() < 2)
Chris Lattner2c21a072008-11-21 18:44:24 +00001249 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +00001250 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
Chris Lattner925e60d2007-12-28 05:29:59 +00001251 if (TheCall->getNumArgs() > 2)
Mike Stump1eb44332009-09-09 15:08:12 +00001252 return Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001253 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +00001254 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001255 << SourceRange(TheCall->getArg(2)->getLocStart(),
1256 (*(TheCall->arg_end()-1))->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +00001257
John Wiegley429bb272011-04-08 18:41:53 +00001258 ExprResult OrigArg0 = TheCall->getArg(0);
1259 ExprResult OrigArg1 = TheCall->getArg(1);
Douglas Gregorcde01732009-05-19 22:10:17 +00001260
Chris Lattner1b9a0792007-12-20 00:26:33 +00001261 // Do standard promotions between the two arguments, returning their common
1262 // type.
Chris Lattner925e60d2007-12-28 05:29:59 +00001263 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
John Wiegley429bb272011-04-08 18:41:53 +00001264 if (OrigArg0.isInvalid() || OrigArg1.isInvalid())
1265 return true;
Daniel Dunbar403bc2b2009-02-19 19:28:43 +00001266
1267 // Make sure any conversions are pushed back into the call; this is
1268 // type safe since unordered compare builtins are declared as "_Bool
1269 // foo(...)".
John Wiegley429bb272011-04-08 18:41:53 +00001270 TheCall->setArg(0, OrigArg0.get());
1271 TheCall->setArg(1, OrigArg1.get());
Mike Stump1eb44332009-09-09 15:08:12 +00001272
John Wiegley429bb272011-04-08 18:41:53 +00001273 if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent())
Douglas Gregorcde01732009-05-19 22:10:17 +00001274 return false;
1275
Chris Lattner1b9a0792007-12-20 00:26:33 +00001276 // If the common type isn't a real floating type, then the arguments were
1277 // invalid for this operation.
1278 if (!Res->isRealFloatingType())
John Wiegley429bb272011-04-08 18:41:53 +00001279 return Diag(OrigArg0.get()->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001280 diag::err_typecheck_call_invalid_ordered_compare)
John Wiegley429bb272011-04-08 18:41:53 +00001281 << OrigArg0.get()->getType() << OrigArg1.get()->getType()
1282 << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd());
Mike Stump1eb44332009-09-09 15:08:12 +00001283
Chris Lattner1b9a0792007-12-20 00:26:33 +00001284 return false;
1285}
1286
Benjamin Kramere771a7a2010-02-15 22:42:31 +00001287/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
1288/// __builtin_isnan and friends. This is declared to take (...), so we have
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001289/// to check everything. We expect the last argument to be a floating point
1290/// value.
1291bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
1292 if (TheCall->getNumArgs() < NumArgs)
Eli Friedman9ac6f622009-08-31 20:06:00 +00001293 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherd77b9a22010-04-16 04:48:22 +00001294 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001295 if (TheCall->getNumArgs() > NumArgs)
1296 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +00001297 diag::err_typecheck_call_too_many_args)
Eric Christopherccfa9632010-04-16 04:56:46 +00001298 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001299 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +00001300 (*(TheCall->arg_end()-1))->getLocEnd());
1301
Benjamin Kramer3b1e26b2010-02-16 10:07:31 +00001302 Expr *OrigArg = TheCall->getArg(NumArgs-1);
Mike Stump1eb44332009-09-09 15:08:12 +00001303
Eli Friedman9ac6f622009-08-31 20:06:00 +00001304 if (OrigArg->isTypeDependent())
1305 return false;
1306
Chris Lattner81368fb2010-05-06 05:50:07 +00001307 // This operation requires a non-_Complex floating-point number.
Eli Friedman9ac6f622009-08-31 20:06:00 +00001308 if (!OrigArg->getType()->isRealFloatingType())
Mike Stump1eb44332009-09-09 15:08:12 +00001309 return Diag(OrigArg->getLocStart(),
Eli Friedman9ac6f622009-08-31 20:06:00 +00001310 diag::err_typecheck_call_invalid_unary_fp)
1311 << OrigArg->getType() << OrigArg->getSourceRange();
Mike Stump1eb44332009-09-09 15:08:12 +00001312
Chris Lattner81368fb2010-05-06 05:50:07 +00001313 // If this is an implicit conversion from float -> double, remove it.
1314 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
1315 Expr *CastArg = Cast->getSubExpr();
1316 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
1317 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
1318 "promotion from float to double is the only expected cast here");
1319 Cast->setSubExpr(0);
Chris Lattner81368fb2010-05-06 05:50:07 +00001320 TheCall->setArg(NumArgs-1, CastArg);
Chris Lattner81368fb2010-05-06 05:50:07 +00001321 }
1322 }
1323
Eli Friedman9ac6f622009-08-31 20:06:00 +00001324 return false;
1325}
1326
Eli Friedmand38617c2008-05-14 19:38:39 +00001327/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
1328// This is declared to take (...), so we have to check everything.
John McCall60d7b3a2010-08-24 06:29:42 +00001329ExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
Nate Begeman37b6a572010-06-08 00:16:34 +00001330 if (TheCall->getNumArgs() < 2)
Sebastian Redl0eb23302009-01-19 00:08:26 +00001331 return ExprError(Diag(TheCall->getLocEnd(),
Eric Christopherd77b9a22010-04-16 04:48:22 +00001332 diag::err_typecheck_call_too_few_args_at_least)
Nate Begeman37b6a572010-06-08 00:16:34 +00001333 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Eric Christopherd77b9a22010-04-16 04:48:22 +00001334 << TheCall->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +00001335
Nate Begeman37b6a572010-06-08 00:16:34 +00001336 // Determine which of the following types of shufflevector we're checking:
1337 // 1) unary, vector mask: (lhs, mask)
1338 // 2) binary, vector mask: (lhs, rhs, mask)
1339 // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
1340 QualType resType = TheCall->getArg(0)->getType();
1341 unsigned numElements = 0;
1342
Douglas Gregorcde01732009-05-19 22:10:17 +00001343 if (!TheCall->getArg(0)->isTypeDependent() &&
1344 !TheCall->getArg(1)->isTypeDependent()) {
Nate Begeman37b6a572010-06-08 00:16:34 +00001345 QualType LHSType = TheCall->getArg(0)->getType();
1346 QualType RHSType = TheCall->getArg(1)->getType();
1347
1348 if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
Douglas Gregorcde01732009-05-19 22:10:17 +00001349 Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
Mike Stump1eb44332009-09-09 15:08:12 +00001350 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +00001351 TheCall->getArg(1)->getLocEnd());
1352 return ExprError();
1353 }
Nate Begeman37b6a572010-06-08 00:16:34 +00001354
1355 numElements = LHSType->getAs<VectorType>()->getNumElements();
1356 unsigned numResElements = TheCall->getNumArgs() - 2;
Mike Stump1eb44332009-09-09 15:08:12 +00001357
Nate Begeman37b6a572010-06-08 00:16:34 +00001358 // Check to see if we have a call with 2 vector arguments, the unary shuffle
1359 // with mask. If so, verify that RHS is an integer vector type with the
1360 // same number of elts as lhs.
1361 if (TheCall->getNumArgs() == 2) {
Douglas Gregorf6094622010-07-23 15:58:24 +00001362 if (!RHSType->hasIntegerRepresentation() ||
Nate Begeman37b6a572010-06-08 00:16:34 +00001363 RHSType->getAs<VectorType>()->getNumElements() != numElements)
1364 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
1365 << SourceRange(TheCall->getArg(1)->getLocStart(),
1366 TheCall->getArg(1)->getLocEnd());
1367 numResElements = numElements;
1368 }
1369 else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
Douglas Gregorcde01732009-05-19 22:10:17 +00001370 Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
Mike Stump1eb44332009-09-09 15:08:12 +00001371 << SourceRange(TheCall->getArg(0)->getLocStart(),
Douglas Gregorcde01732009-05-19 22:10:17 +00001372 TheCall->getArg(1)->getLocEnd());
1373 return ExprError();
Nate Begeman37b6a572010-06-08 00:16:34 +00001374 } else if (numElements != numResElements) {
1375 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
Chris Lattner788b0fd2010-06-23 06:00:24 +00001376 resType = Context.getVectorType(eltType, numResElements,
Bob Wilsone86d78c2010-11-10 21:56:12 +00001377 VectorType::GenericVector);
Douglas Gregorcde01732009-05-19 22:10:17 +00001378 }
Eli Friedmand38617c2008-05-14 19:38:39 +00001379 }
1380
1381 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
Douglas Gregorcde01732009-05-19 22:10:17 +00001382 if (TheCall->getArg(i)->isTypeDependent() ||
1383 TheCall->getArg(i)->isValueDependent())
1384 continue;
1385
Nate Begeman37b6a572010-06-08 00:16:34 +00001386 llvm::APSInt Result(32);
1387 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
1388 return ExprError(Diag(TheCall->getLocStart(),
1389 diag::err_shufflevector_nonconstant_argument)
1390 << TheCall->getArg(i)->getSourceRange());
Sebastian Redl0eb23302009-01-19 00:08:26 +00001391
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +00001392 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
Sebastian Redl0eb23302009-01-19 00:08:26 +00001393 return ExprError(Diag(TheCall->getLocStart(),
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001394 diag::err_shufflevector_argument_too_large)
Sebastian Redl0eb23302009-01-19 00:08:26 +00001395 << TheCall->getArg(i)->getSourceRange());
Eli Friedmand38617c2008-05-14 19:38:39 +00001396 }
1397
Chris Lattner5f9e2722011-07-23 10:55:15 +00001398 SmallVector<Expr*, 32> exprs;
Eli Friedmand38617c2008-05-14 19:38:39 +00001399
Chris Lattnerd1a0b6d2008-08-10 02:05:13 +00001400 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
Eli Friedmand38617c2008-05-14 19:38:39 +00001401 exprs.push_back(TheCall->getArg(i));
1402 TheCall->setArg(i, 0);
1403 }
1404
Nate Begemana88dc302009-08-12 02:10:25 +00001405 return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
Nate Begeman37b6a572010-06-08 00:16:34 +00001406 exprs.size(), resType,
Ted Kremenek8189cde2009-02-07 01:47:29 +00001407 TheCall->getCallee()->getLocStart(),
1408 TheCall->getRParenLoc()));
Eli Friedmand38617c2008-05-14 19:38:39 +00001409}
Chris Lattner30ce3442007-12-19 23:59:04 +00001410
Daniel Dunbar4493f792008-07-21 22:59:13 +00001411/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
1412// This is declared to take (const void*, ...) and can take two
1413// optional constant int args.
1414bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001415 unsigned NumArgs = TheCall->getNumArgs();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001416
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001417 if (NumArgs > 3)
Eric Christopherccfa9632010-04-16 04:56:46 +00001418 return Diag(TheCall->getLocEnd(),
1419 diag::err_typecheck_call_too_many_args_at_most)
1420 << 0 /*function call*/ << 3 << NumArgs
1421 << TheCall->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001422
1423 // Argument 0 is checked for us and the remaining arguments must be
1424 // constant integers.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001425 for (unsigned i = 1; i != NumArgs; ++i) {
Daniel Dunbar4493f792008-07-21 22:59:13 +00001426 Expr *Arg = TheCall->getArg(i);
Eric Christopher691ebc32010-04-17 02:26:23 +00001427
Eli Friedman9aef7262009-12-04 00:30:06 +00001428 llvm::APSInt Result;
Eric Christopher691ebc32010-04-17 02:26:23 +00001429 if (SemaBuiltinConstantArg(TheCall, i, Result))
1430 return true;
Mike Stump1eb44332009-09-09 15:08:12 +00001431
Daniel Dunbar4493f792008-07-21 22:59:13 +00001432 // FIXME: gcc issues a warning and rewrites these to 0. These
1433 // seems especially odd for the third argument since the default
1434 // is 3.
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001435 if (i == 1) {
Eli Friedman9aef7262009-12-04 00:30:06 +00001436 if (Result.getLimitedValue() > 1)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001437 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +00001438 << "0" << "1" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001439 } else {
Eli Friedman9aef7262009-12-04 00:30:06 +00001440 if (Result.getLimitedValue() > 3)
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001441 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Chris Lattner21fb98e2009-09-23 06:06:36 +00001442 << "0" << "3" << Arg->getSourceRange();
Daniel Dunbar4493f792008-07-21 22:59:13 +00001443 }
1444 }
1445
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001446 return false;
Daniel Dunbar4493f792008-07-21 22:59:13 +00001447}
1448
Eric Christopher691ebc32010-04-17 02:26:23 +00001449/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
1450/// TheCall is a constant expression.
1451bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
1452 llvm::APSInt &Result) {
1453 Expr *Arg = TheCall->getArg(ArgNum);
1454 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
1455 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
1456
1457 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
1458
1459 if (!Arg->isIntegerConstantExpr(Result, Context))
1460 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
Eric Christopher5e896552010-04-19 18:23:02 +00001461 << FDecl->getDeclName() << Arg->getSourceRange();
Eric Christopher691ebc32010-04-17 02:26:23 +00001462
Chris Lattner21fb98e2009-09-23 06:06:36 +00001463 return false;
1464}
1465
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001466/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
1467/// int type). This simply type checks that type is one of the defined
1468/// constants (0-3).
Chris Lattnerfc8f0e12011-04-15 05:22:18 +00001469// For compatibility check 0-3, llvm only handles 0 and 2.
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001470bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
Eric Christopher691ebc32010-04-17 02:26:23 +00001471 llvm::APSInt Result;
1472
1473 // Check constant-ness first.
1474 if (SemaBuiltinConstantArg(TheCall, 1, Result))
1475 return true;
1476
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001477 Expr *Arg = TheCall->getArg(1);
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001478 if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
Chris Lattnerfa25bbb2008-11-19 05:08:23 +00001479 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
1480 << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
Daniel Dunbard5f8a4f2008-09-03 21:13:56 +00001481 }
1482
1483 return false;
1484}
1485
Eli Friedman586d6a82009-05-03 06:04:26 +00001486/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
Eli Friedmand875fed2009-05-03 04:46:36 +00001487/// This checks that val is a constant 1.
1488bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
1489 Expr *Arg = TheCall->getArg(1);
Eric Christopher691ebc32010-04-17 02:26:23 +00001490 llvm::APSInt Result;
Douglas Gregorcde01732009-05-19 22:10:17 +00001491
Eric Christopher691ebc32010-04-17 02:26:23 +00001492 // TODO: This is less than ideal. Overload this to take a value.
1493 if (SemaBuiltinConstantArg(TheCall, 1, Result))
1494 return true;
1495
1496 if (Result != 1)
Eli Friedmand875fed2009-05-03 04:46:36 +00001497 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
1498 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1499
1500 return false;
1501}
1502
Ted Kremenekb43e8ad2011-02-24 23:03:04 +00001503// Handle i > 1 ? "x" : "y", recursively.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001504bool Sema::SemaCheckStringLiteral(const Expr *E, Expr **Args,
1505 unsigned NumArgs, bool HasVAListArg,
Ted Kremenek826a3452010-07-16 02:11:22 +00001506 unsigned format_idx, unsigned firstDataArg,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001507 FormatStringType Type, bool inFunctionCall) {
Ted Kremenek4fe64412010-09-09 03:51:39 +00001508 tryAgain:
Douglas Gregorcde01732009-05-19 22:10:17 +00001509 if (E->isTypeDependent() || E->isValueDependent())
1510 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001511
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001512 E = E->IgnoreParenCasts();
Peter Collingbournef111d932011-04-15 00:35:48 +00001513
David Blaikiea73cdcb2012-02-10 21:07:25 +00001514 if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull))
1515 // Technically -Wformat-nonliteral does not warn about this case.
1516 // The behavior of printf and friends in this case is implementation
1517 // dependent. Ideally if the format string cannot be null then
1518 // it should have a 'nonnull' attribute in the function prototype.
1519 return true;
1520
Ted Kremenekd30ef872009-01-12 23:09:09 +00001521 switch (E->getStmtClass()) {
John McCall56ca35d2011-02-17 10:25:35 +00001522 case Stmt::BinaryConditionalOperatorClass:
Ted Kremenekd30ef872009-01-12 23:09:09 +00001523 case Stmt::ConditionalOperatorClass: {
John McCall56ca35d2011-02-17 10:25:35 +00001524 const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E);
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001525 return SemaCheckStringLiteral(C->getTrueExpr(), Args, NumArgs, HasVAListArg,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001526 format_idx, firstDataArg, Type,
Richard Trieu55733de2011-10-28 00:41:25 +00001527 inFunctionCall)
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001528 && SemaCheckStringLiteral(C->getFalseExpr(), Args, NumArgs, HasVAListArg,
1529 format_idx, firstDataArg, Type,
1530 inFunctionCall);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001531 }
1532
1533 case Stmt::ImplicitCastExprClass: {
Ted Kremenek4fe64412010-09-09 03:51:39 +00001534 E = cast<ImplicitCastExpr>(E)->getSubExpr();
1535 goto tryAgain;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001536 }
1537
John McCall56ca35d2011-02-17 10:25:35 +00001538 case Stmt::OpaqueValueExprClass:
1539 if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) {
1540 E = src;
1541 goto tryAgain;
1542 }
1543 return false;
1544
Ted Kremenekb43e8ad2011-02-24 23:03:04 +00001545 case Stmt::PredefinedExprClass:
1546 // While __func__, etc., are technically not string literals, they
1547 // cannot contain format specifiers and thus are not a security
1548 // liability.
1549 return true;
1550
Ted Kremenek082d9362009-03-20 21:35:28 +00001551 case Stmt::DeclRefExprClass: {
1552 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001553
Ted Kremenek082d9362009-03-20 21:35:28 +00001554 // As an exception, do not flag errors for variables binding to
1555 // const string literals.
1556 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
1557 bool isConstant = false;
1558 QualType T = DR->getType();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001559
Ted Kremenek082d9362009-03-20 21:35:28 +00001560 if (const ArrayType *AT = Context.getAsArrayType(T)) {
1561 isConstant = AT->getElementType().isConstant(Context);
Mike Stumpac5fc7c2009-08-04 21:02:39 +00001562 } else if (const PointerType *PT = T->getAs<PointerType>()) {
Mike Stump1eb44332009-09-09 15:08:12 +00001563 isConstant = T.isConstant(Context) &&
Ted Kremenek082d9362009-03-20 21:35:28 +00001564 PT->getPointeeType().isConstant(Context);
Jean-Daniel Dupase98e5b52012-01-25 10:35:33 +00001565 } else if (T->isObjCObjectPointerType()) {
1566 // In ObjC, there is usually no "const ObjectPointer" type,
1567 // so don't check if the pointee type is constant.
1568 isConstant = T.isConstant(Context);
Ted Kremenek082d9362009-03-20 21:35:28 +00001569 }
Mike Stump1eb44332009-09-09 15:08:12 +00001570
Ted Kremenek082d9362009-03-20 21:35:28 +00001571 if (isConstant) {
Sebastian Redl31310a22010-02-01 20:16:42 +00001572 if (const Expr *Init = VD->getAnyInitializer())
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001573 return SemaCheckStringLiteral(Init, Args, NumArgs,
Ted Kremenek826a3452010-07-16 02:11:22 +00001574 HasVAListArg, format_idx, firstDataArg,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001575 Type, /*inFunctionCall*/false);
Ted Kremenek082d9362009-03-20 21:35:28 +00001576 }
Mike Stump1eb44332009-09-09 15:08:12 +00001577
Anders Carlssond966a552009-06-28 19:55:58 +00001578 // For vprintf* functions (i.e., HasVAListArg==true), we add a
1579 // special check to see if the format string is a function parameter
1580 // of the function calling the printf function. If the function
1581 // has an attribute indicating it is a printf-like function, then we
1582 // should suppress warnings concerning non-literals being used in a call
1583 // to a vprintf function. For example:
1584 //
1585 // void
1586 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
1587 // va_list ap;
1588 // va_start(ap, fmt);
1589 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
1590 // ...
1591 //
Jean-Daniel Dupasf57c4132012-02-21 20:00:53 +00001592 if (HasVAListArg) {
1593 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) {
1594 if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) {
1595 int PVIndex = PV->getFunctionScopeIndex() + 1;
1596 for (specific_attr_iterator<FormatAttr>
1597 i = ND->specific_attr_begin<FormatAttr>(),
1598 e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) {
1599 FormatAttr *PVFormat = *i;
1600 // adjust for implicit parameter
1601 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
1602 if (MD->isInstance())
1603 ++PVIndex;
1604 // We also check if the formats are compatible.
1605 // We can't pass a 'scanf' string to a 'printf' function.
1606 if (PVIndex == PVFormat->getFormatIdx() &&
1607 Type == GetFormatStringType(PVFormat))
1608 return true;
1609 }
1610 }
1611 }
1612 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001613 }
Mike Stump1eb44332009-09-09 15:08:12 +00001614
Ted Kremenek082d9362009-03-20 21:35:28 +00001615 return false;
1616 }
Ted Kremenekd30ef872009-01-12 23:09:09 +00001617
Jean-Daniel Dupas52aabaf2012-02-07 19:01:42 +00001618 case Stmt::CallExprClass:
1619 case Stmt::CXXMemberCallExprClass: {
Anders Carlsson8f031b32009-06-27 04:05:33 +00001620 const CallExpr *CE = cast<CallExpr>(E);
Jean-Daniel Dupas52aabaf2012-02-07 19:01:42 +00001621 if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) {
1622 if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) {
1623 unsigned ArgIndex = FA->getFormatIdx();
1624 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
1625 if (MD->isInstance())
1626 --ArgIndex;
1627 const Expr *Arg = CE->getArg(ArgIndex - 1);
Mike Stump1eb44332009-09-09 15:08:12 +00001628
Jean-Daniel Dupas52aabaf2012-02-07 19:01:42 +00001629 return SemaCheckStringLiteral(Arg, Args, NumArgs, HasVAListArg,
1630 format_idx, firstDataArg, Type,
1631 inFunctionCall);
Anders Carlsson8f031b32009-06-27 04:05:33 +00001632 }
1633 }
Mike Stump1eb44332009-09-09 15:08:12 +00001634
Anders Carlsson8f031b32009-06-27 04:05:33 +00001635 return false;
1636 }
Ted Kremenek082d9362009-03-20 21:35:28 +00001637 case Stmt::ObjCStringLiteralClass:
1638 case Stmt::StringLiteralClass: {
1639 const StringLiteral *StrE = NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00001640
Ted Kremenek082d9362009-03-20 21:35:28 +00001641 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
Ted Kremenekd30ef872009-01-12 23:09:09 +00001642 StrE = ObjCFExpr->getString();
1643 else
Ted Kremenek082d9362009-03-20 21:35:28 +00001644 StrE = cast<StringLiteral>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00001645
Ted Kremenekd30ef872009-01-12 23:09:09 +00001646 if (StrE) {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001647 CheckFormatString(StrE, E, Args, NumArgs, HasVAListArg, format_idx,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001648 firstDataArg, Type, inFunctionCall);
Ted Kremenekd30ef872009-01-12 23:09:09 +00001649 return true;
1650 }
Mike Stump1eb44332009-09-09 15:08:12 +00001651
Ted Kremenekd30ef872009-01-12 23:09:09 +00001652 return false;
1653 }
Mike Stump1eb44332009-09-09 15:08:12 +00001654
Ted Kremenek082d9362009-03-20 21:35:28 +00001655 default:
1656 return false;
Ted Kremenekd30ef872009-01-12 23:09:09 +00001657 }
1658}
1659
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001660void
Mike Stump1eb44332009-09-09 15:08:12 +00001661Sema::CheckNonNullArguments(const NonNullAttr *NonNull,
Nick Lewycky909a70d2011-03-25 01:44:32 +00001662 const Expr * const *ExprArgs,
1663 SourceLocation CallSiteLoc) {
Sean Huntcf807c42010-08-18 23:23:40 +00001664 for (NonNullAttr::args_iterator i = NonNull->args_begin(),
1665 e = NonNull->args_end();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001666 i != e; ++i) {
Nick Lewycky909a70d2011-03-25 01:44:32 +00001667 const Expr *ArgExpr = ExprArgs[*i];
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001668 if (ArgExpr->isNullPointerConstant(Context,
Douglas Gregorce940492009-09-25 04:25:58 +00001669 Expr::NPC_ValueDependentIsNotNull))
Nick Lewycky909a70d2011-03-25 01:44:32 +00001670 Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange();
Fariborz Jahaniane898f8a2009-05-21 18:48:51 +00001671 }
1672}
Ted Kremenekd30ef872009-01-12 23:09:09 +00001673
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001674Sema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) {
1675 return llvm::StringSwitch<FormatStringType>(Format->getType())
1676 .Case("scanf", FST_Scanf)
1677 .Cases("printf", "printf0", FST_Printf)
1678 .Cases("NSString", "CFString", FST_NSString)
1679 .Case("strftime", FST_Strftime)
1680 .Case("strfmon", FST_Strfmon)
1681 .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf)
1682 .Default(FST_Unknown);
1683}
1684
Ted Kremenek826a3452010-07-16 02:11:22 +00001685/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar
1686/// functions) for correct use of format strings.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001687void Sema::CheckFormatArguments(const FormatAttr *Format, CallExpr *TheCall) {
1688 bool IsCXXMember = false;
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001689 // The way the format attribute works in GCC, the implicit this argument
1690 // of member functions is counted. However, it doesn't appear in our own
1691 // lists, so decrement format_idx in that case.
Jean-Daniel Dupas52aabaf2012-02-07 19:01:42 +00001692 IsCXXMember = isa<CXXMemberCallExpr>(TheCall);
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001693 CheckFormatArguments(Format, TheCall->getArgs(), TheCall->getNumArgs(),
1694 IsCXXMember, TheCall->getRParenLoc(),
1695 TheCall->getCallee()->getSourceRange());
1696}
1697
1698void Sema::CheckFormatArguments(const FormatAttr *Format, Expr **Args,
1699 unsigned NumArgs, bool IsCXXMember,
1700 SourceLocation Loc, SourceRange Range) {
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001701 bool HasVAListArg = Format->getFirstArg() == 0;
1702 unsigned format_idx = Format->getFormatIdx() - 1;
1703 unsigned firstDataArg = HasVAListArg ? 0 : Format->getFirstArg() - 1;
1704 if (IsCXXMember) {
1705 if (format_idx == 0)
1706 return;
1707 --format_idx;
1708 if(firstDataArg != 0)
1709 --firstDataArg;
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001710 }
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001711 CheckFormatArguments(Args, NumArgs, HasVAListArg, format_idx,
1712 firstDataArg, GetFormatStringType(Format), Loc, Range);
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001713}
Sebastian Redl4a2614e2009-11-17 18:02:24 +00001714
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001715void Sema::CheckFormatArguments(Expr **Args, unsigned NumArgs,
1716 bool HasVAListArg, unsigned format_idx,
1717 unsigned firstDataArg, FormatStringType Type,
1718 SourceLocation Loc, SourceRange Range) {
Ted Kremenek826a3452010-07-16 02:11:22 +00001719 // CHECK: printf/scanf-like function is called with no format string.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001720 if (format_idx >= NumArgs) {
1721 Diag(Loc, diag::warn_missing_format_string) << Range;
Ted Kremenek71895b92007-08-14 17:39:48 +00001722 return;
1723 }
Mike Stump1eb44332009-09-09 15:08:12 +00001724
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001725 const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +00001726
Chris Lattner59907c42007-08-10 20:18:51 +00001727 // CHECK: format string is not a string literal.
Mike Stump1eb44332009-09-09 15:08:12 +00001728 //
Ted Kremenek71895b92007-08-14 17:39:48 +00001729 // Dynamically generated format strings are difficult to
1730 // automatically vet at compile time. Requiring that format strings
1731 // are string literals: (1) permits the checking of format strings by
1732 // the compiler and thereby (2) can practically remove the source of
1733 // many format string exploits.
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001734
Mike Stump1eb44332009-09-09 15:08:12 +00001735 // Format string can be either ObjC string (e.g. @"%d") or
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001736 // C string (e.g. "%d")
Mike Stump1eb44332009-09-09 15:08:12 +00001737 // ObjC string uses the same format specifiers as C string, so we can use
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001738 // the same format string checking logic for both ObjC and C strings.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001739 if (SemaCheckStringLiteral(OrigFormatExpr, Args, NumArgs, HasVAListArg,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00001740 format_idx, firstDataArg, Type))
Chris Lattner1cd3e1f2009-04-29 04:49:34 +00001741 return; // Literal format string found, check done!
Ted Kremenek7ff22b22008-06-16 18:00:42 +00001742
Jean-Daniel Dupas2837a2f2012-02-07 23:10:53 +00001743 // Strftime is particular as it always uses a single 'time' argument,
1744 // so it is safe to pass a non-literal string.
1745 if (Type == FST_Strftime)
1746 return;
1747
Jean-Daniel Dupasce3aa392012-01-30 19:46:17 +00001748 // Do not emit diag when the string param is a macro expansion and the
1749 // format is either NSString or CFString. This is a hack to prevent
1750 // diag when using the NSLocalizedString and CFCopyLocalizedString macros
1751 // which are usually used in place of NS and CF string literals.
1752 if (Type == FST_NSString && Args[format_idx]->getLocStart().isMacroID())
1753 return;
1754
Chris Lattner655f1412009-04-29 04:59:47 +00001755 // If there are no arguments specified, warn with -Wformat-security, otherwise
1756 // warn only with -Wformat-nonliteral.
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001757 if (NumArgs == format_idx+1)
1758 Diag(Args[format_idx]->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001759 diag::warn_format_nonliteral_noargs)
Chris Lattner655f1412009-04-29 04:59:47 +00001760 << OrigFormatExpr->getSourceRange();
1761 else
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001762 Diag(Args[format_idx]->getLocStart(),
Ted Kremenek826a3452010-07-16 02:11:22 +00001763 diag::warn_format_nonliteral)
Chris Lattner655f1412009-04-29 04:59:47 +00001764 << OrigFormatExpr->getSourceRange();
Ted Kremenekd30ef872009-01-12 23:09:09 +00001765}
Ted Kremenek71895b92007-08-14 17:39:48 +00001766
Ted Kremeneke0e53132010-01-28 23:39:18 +00001767namespace {
Ted Kremenek826a3452010-07-16 02:11:22 +00001768class CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1769protected:
Ted Kremeneke0e53132010-01-28 23:39:18 +00001770 Sema &S;
1771 const StringLiteral *FExpr;
1772 const Expr *OrigFormatExpr;
Ted Kremenek6ee76532010-03-25 03:59:12 +00001773 const unsigned FirstDataArg;
Ted Kremeneke0e53132010-01-28 23:39:18 +00001774 const unsigned NumDataArgs;
1775 const bool IsObjCLiteral;
1776 const char *Beg; // Start of format string.
Ted Kremenek0d277352010-01-29 01:06:55 +00001777 const bool HasVAListArg;
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001778 const Expr * const *Args;
1779 const unsigned NumArgs;
Ted Kremenek0d277352010-01-29 01:06:55 +00001780 unsigned FormatIdx;
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001781 llvm::BitVector CoveredArgs;
Ted Kremenekefaff192010-02-27 01:41:03 +00001782 bool usesPositionalArgs;
1783 bool atFirstArg;
Richard Trieu55733de2011-10-28 00:41:25 +00001784 bool inFunctionCall;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001785public:
Ted Kremenek826a3452010-07-16 02:11:22 +00001786 CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
Ted Kremenek6ee76532010-03-25 03:59:12 +00001787 const Expr *origFormatExpr, unsigned firstDataArg,
Ted Kremeneke0e53132010-01-28 23:39:18 +00001788 unsigned numDataArgs, bool isObjCLiteral,
Ted Kremenek0d277352010-01-29 01:06:55 +00001789 const char *beg, bool hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001790 Expr **args, unsigned numArgs,
1791 unsigned formatIdx, bool inFunctionCall)
Ted Kremeneke0e53132010-01-28 23:39:18 +00001792 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
Ted Kremenek6ee76532010-03-25 03:59:12 +00001793 FirstDataArg(firstDataArg),
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001794 NumDataArgs(numDataArgs),
Ted Kremenek0d277352010-01-29 01:06:55 +00001795 IsObjCLiteral(isObjCLiteral), Beg(beg),
1796 HasVAListArg(hasVAListArg),
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001797 Args(args), NumArgs(numArgs), FormatIdx(formatIdx),
Richard Trieu55733de2011-10-28 00:41:25 +00001798 usesPositionalArgs(false), atFirstArg(true),
1799 inFunctionCall(inFunctionCall) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00001800 CoveredArgs.resize(numDataArgs);
1801 CoveredArgs.reset();
1802 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001803
Ted Kremenek07d161f2010-01-29 01:50:07 +00001804 void DoneProcessing();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001805
Ted Kremenek826a3452010-07-16 02:11:22 +00001806 void HandleIncompleteSpecifier(const char *startSpecifier,
1807 unsigned specifierLen);
Hans Wennborg76517422012-02-22 10:17:01 +00001808
1809 void HandleNonStandardLengthModifier(
1810 const analyze_format_string::LengthModifier &LM,
1811 const char *startSpecifier, unsigned specifierLen);
1812
1813 void HandleNonStandardConversionSpecifier(
1814 const analyze_format_string::ConversionSpecifier &CS,
1815 const char *startSpecifier, unsigned specifierLen);
1816
1817 void HandleNonStandardConversionSpecification(
1818 const analyze_format_string::LengthModifier &LM,
1819 const analyze_format_string::ConversionSpecifier &CS,
1820 const char *startSpecifier, unsigned specifierLen);
1821
Hans Wennborgf8562642012-03-09 10:10:54 +00001822 virtual void HandlePosition(const char *startPos, unsigned posLen);
1823
Ted Kremenekefaff192010-02-27 01:41:03 +00001824 virtual void HandleInvalidPosition(const char *startSpecifier,
1825 unsigned specifierLen,
Ted Kremenek826a3452010-07-16 02:11:22 +00001826 analyze_format_string::PositionContext p);
Ted Kremenekefaff192010-02-27 01:41:03 +00001827
1828 virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1829
Ted Kremeneke0e53132010-01-28 23:39:18 +00001830 void HandleNullChar(const char *nullCharacter);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001831
Richard Trieu55733de2011-10-28 00:41:25 +00001832 template <typename Range>
1833 static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall,
1834 const Expr *ArgumentExpr,
1835 PartialDiagnostic PDiag,
1836 SourceLocation StringLoc,
1837 bool IsStringLocation, Range StringRange,
1838 FixItHint Fixit = FixItHint());
1839
Ted Kremenek826a3452010-07-16 02:11:22 +00001840protected:
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001841 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
1842 const char *startSpec,
1843 unsigned specifierLen,
1844 const char *csStart, unsigned csLen);
Richard Trieu55733de2011-10-28 00:41:25 +00001845
1846 void HandlePositionalNonpositionalArgs(SourceLocation Loc,
1847 const char *startSpec,
1848 unsigned specifierLen);
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001849
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001850 SourceRange getFormatStringRange();
Ted Kremenek826a3452010-07-16 02:11:22 +00001851 CharSourceRange getSpecifierRange(const char *startSpecifier,
1852 unsigned specifierLen);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001853 SourceLocation getLocationOfByte(const char *x);
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001854
Ted Kremenek0d277352010-01-29 01:06:55 +00001855 const Expr *getDataArg(unsigned i) const;
Ted Kremenek666a1972010-07-26 19:45:42 +00001856
1857 bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
1858 const analyze_format_string::ConversionSpecifier &CS,
1859 const char *startSpecifier, unsigned specifierLen,
1860 unsigned argIndex);
Richard Trieu55733de2011-10-28 00:41:25 +00001861
1862 template <typename Range>
1863 void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc,
1864 bool IsStringLocation, Range StringRange,
1865 FixItHint Fixit = FixItHint());
1866
1867 void CheckPositionalAndNonpositionalArgs(
1868 const analyze_format_string::FormatSpecifier *FS);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001869};
1870}
1871
Ted Kremenek826a3452010-07-16 02:11:22 +00001872SourceRange CheckFormatHandler::getFormatStringRange() {
Ted Kremeneke0e53132010-01-28 23:39:18 +00001873 return OrigFormatExpr->getSourceRange();
1874}
1875
Ted Kremenek826a3452010-07-16 02:11:22 +00001876CharSourceRange CheckFormatHandler::
1877getSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
Tom Care45f9b7e2010-06-21 21:21:01 +00001878 SourceLocation Start = getLocationOfByte(startSpecifier);
1879 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1);
1880
1881 // Advance the end SourceLocation by one due to half-open ranges.
Argyrios Kyrtzidisa64ccef2011-09-19 20:40:19 +00001882 End = End.getLocWithOffset(1);
Tom Care45f9b7e2010-06-21 21:21:01 +00001883
1884 return CharSourceRange::getCharRange(Start, End);
Ted Kremenekf88c8e02010-01-29 20:55:36 +00001885}
1886
Ted Kremenek826a3452010-07-16 02:11:22 +00001887SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001888 return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
Ted Kremeneke0e53132010-01-28 23:39:18 +00001889}
1890
Ted Kremenek826a3452010-07-16 02:11:22 +00001891void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
1892 unsigned specifierLen){
Richard Trieu55733de2011-10-28 00:41:25 +00001893 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier),
1894 getLocationOfByte(startSpecifier),
1895 /*IsStringLocation*/true,
1896 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek808015a2010-01-29 03:16:21 +00001897}
1898
Hans Wennborg76517422012-02-22 10:17:01 +00001899void CheckFormatHandler::HandleNonStandardLengthModifier(
1900 const analyze_format_string::LengthModifier &LM,
1901 const char *startSpecifier, unsigned specifierLen) {
1902 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) << LM.toString()
Hans Wennborgf8562642012-03-09 10:10:54 +00001903 << 0,
Hans Wennborg76517422012-02-22 10:17:01 +00001904 getLocationOfByte(LM.getStart()),
1905 /*IsStringLocation*/true,
1906 getSpecifierRange(startSpecifier, specifierLen));
1907}
1908
1909void CheckFormatHandler::HandleNonStandardConversionSpecifier(
1910 const analyze_format_string::ConversionSpecifier &CS,
1911 const char *startSpecifier, unsigned specifierLen) {
1912 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) << CS.toString()
Hans Wennborgf8562642012-03-09 10:10:54 +00001913 << 1,
Hans Wennborg76517422012-02-22 10:17:01 +00001914 getLocationOfByte(CS.getStart()),
1915 /*IsStringLocation*/true,
1916 getSpecifierRange(startSpecifier, specifierLen));
1917}
1918
1919void CheckFormatHandler::HandleNonStandardConversionSpecification(
1920 const analyze_format_string::LengthModifier &LM,
1921 const analyze_format_string::ConversionSpecifier &CS,
1922 const char *startSpecifier, unsigned specifierLen) {
1923 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_conversion_spec)
1924 << LM.toString() << CS.toString(),
1925 getLocationOfByte(LM.getStart()),
1926 /*IsStringLocation*/true,
1927 getSpecifierRange(startSpecifier, specifierLen));
1928}
1929
Hans Wennborgf8562642012-03-09 10:10:54 +00001930void CheckFormatHandler::HandlePosition(const char *startPos,
1931 unsigned posLen) {
1932 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg),
1933 getLocationOfByte(startPos),
1934 /*IsStringLocation*/true,
1935 getSpecifierRange(startPos, posLen));
1936}
1937
Ted Kremenekefaff192010-02-27 01:41:03 +00001938void
Ted Kremenek826a3452010-07-16 02:11:22 +00001939CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
1940 analyze_format_string::PositionContext p) {
Richard Trieu55733de2011-10-28 00:41:25 +00001941 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier)
1942 << (unsigned) p,
1943 getLocationOfByte(startPos), /*IsStringLocation*/true,
1944 getSpecifierRange(startPos, posLen));
Ted Kremenekefaff192010-02-27 01:41:03 +00001945}
1946
Ted Kremenek826a3452010-07-16 02:11:22 +00001947void CheckFormatHandler::HandleZeroPosition(const char *startPos,
Ted Kremenekefaff192010-02-27 01:41:03 +00001948 unsigned posLen) {
Richard Trieu55733de2011-10-28 00:41:25 +00001949 EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier),
1950 getLocationOfByte(startPos),
1951 /*IsStringLocation*/true,
1952 getSpecifierRange(startPos, posLen));
Ted Kremenekefaff192010-02-27 01:41:03 +00001953}
1954
Ted Kremenek826a3452010-07-16 02:11:22 +00001955void CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
Ted Kremenek0c069442011-03-15 21:18:48 +00001956 if (!IsObjCLiteral) {
1957 // The presence of a null character is likely an error.
Richard Trieu55733de2011-10-28 00:41:25 +00001958 EmitFormatDiagnostic(
1959 S.PDiag(diag::warn_printf_format_string_contains_null_char),
1960 getLocationOfByte(nullCharacter), /*IsStringLocation*/true,
1961 getFormatStringRange());
Ted Kremenek0c069442011-03-15 21:18:48 +00001962 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001963}
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00001964
Ted Kremenek826a3452010-07-16 02:11:22 +00001965const Expr *CheckFormatHandler::getDataArg(unsigned i) const {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00001966 return Args[FirstDataArg + i];
Ted Kremenek826a3452010-07-16 02:11:22 +00001967}
1968
1969void CheckFormatHandler::DoneProcessing() {
1970 // Does the number of data arguments exceed the number of
1971 // format conversions in the format string?
1972 if (!HasVAListArg) {
1973 // Find any arguments that weren't covered.
1974 CoveredArgs.flip();
1975 signed notCoveredArg = CoveredArgs.find_first();
1976 if (notCoveredArg >= 0) {
1977 assert((unsigned)notCoveredArg < NumDataArgs);
Bob Wilsonc03f2df2012-05-03 19:47:19 +00001978 SourceLocation Loc = getDataArg((unsigned) notCoveredArg)->getLocStart();
1979 if (!S.getSourceManager().isInSystemMacro(Loc)) {
1980 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used),
1981 Loc,
1982 /*IsStringLocation*/false, getFormatStringRange());
1983 }
Ted Kremenek826a3452010-07-16 02:11:22 +00001984 }
1985 }
1986}
1987
Ted Kremenekc09b6a52010-07-19 21:25:57 +00001988bool
1989CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
1990 SourceLocation Loc,
1991 const char *startSpec,
1992 unsigned specifierLen,
1993 const char *csStart,
1994 unsigned csLen) {
1995
1996 bool keepGoing = true;
1997 if (argIndex < NumDataArgs) {
1998 // Consider the argument coverered, even though the specifier doesn't
1999 // make sense.
2000 CoveredArgs.set(argIndex);
2001 }
2002 else {
2003 // If argIndex exceeds the number of data arguments we
2004 // don't issue a warning because that is just a cascade of warnings (and
2005 // they may have intended '%%' anyway). We don't want to continue processing
2006 // the format string after this point, however, as we will like just get
2007 // gibberish when trying to match arguments.
2008 keepGoing = false;
2009 }
2010
Richard Trieu55733de2011-10-28 00:41:25 +00002011 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion)
2012 << StringRef(csStart, csLen),
2013 Loc, /*IsStringLocation*/true,
2014 getSpecifierRange(startSpec, specifierLen));
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002015
2016 return keepGoing;
2017}
2018
Richard Trieu55733de2011-10-28 00:41:25 +00002019void
2020CheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc,
2021 const char *startSpec,
2022 unsigned specifierLen) {
2023 EmitFormatDiagnostic(
2024 S.PDiag(diag::warn_format_mix_positional_nonpositional_args),
2025 Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen));
2026}
2027
Ted Kremenek666a1972010-07-26 19:45:42 +00002028bool
2029CheckFormatHandler::CheckNumArgs(
2030 const analyze_format_string::FormatSpecifier &FS,
2031 const analyze_format_string::ConversionSpecifier &CS,
2032 const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
2033
2034 if (argIndex >= NumDataArgs) {
Richard Trieu55733de2011-10-28 00:41:25 +00002035 PartialDiagnostic PDiag = FS.usesPositionalArg()
2036 ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args)
2037 << (argIndex+1) << NumDataArgs)
2038 : S.PDiag(diag::warn_printf_insufficient_data_args);
2039 EmitFormatDiagnostic(
2040 PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true,
2041 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek666a1972010-07-26 19:45:42 +00002042 return false;
2043 }
2044 return true;
2045}
2046
Richard Trieu55733de2011-10-28 00:41:25 +00002047template<typename Range>
2048void CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag,
2049 SourceLocation Loc,
2050 bool IsStringLocation,
2051 Range StringRange,
2052 FixItHint FixIt) {
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002053 EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag,
Richard Trieu55733de2011-10-28 00:41:25 +00002054 Loc, IsStringLocation, StringRange, FixIt);
2055}
2056
2057/// \brief If the format string is not within the funcion call, emit a note
2058/// so that the function call and string are in diagnostic messages.
2059///
2060/// \param inFunctionCall if true, the format string is within the function
2061/// call and only one diagnostic message will be produced. Otherwise, an
2062/// extra note will be emitted pointing to location of the format string.
2063///
2064/// \param ArgumentExpr the expression that is passed as the format string
2065/// argument in the function call. Used for getting locations when two
2066/// diagnostics are emitted.
2067///
2068/// \param PDiag the callee should already have provided any strings for the
2069/// diagnostic message. This function only adds locations and fixits
2070/// to diagnostics.
2071///
2072/// \param Loc primary location for diagnostic. If two diagnostics are
2073/// required, one will be at Loc and a new SourceLocation will be created for
2074/// the other one.
2075///
2076/// \param IsStringLocation if true, Loc points to the format string should be
2077/// used for the note. Otherwise, Loc points to the argument list and will
2078/// be used with PDiag.
2079///
2080/// \param StringRange some or all of the string to highlight. This is
2081/// templated so it can accept either a CharSourceRange or a SourceRange.
2082///
2083/// \param Fixit optional fix it hint for the format string.
2084template<typename Range>
2085void CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall,
2086 const Expr *ArgumentExpr,
2087 PartialDiagnostic PDiag,
2088 SourceLocation Loc,
2089 bool IsStringLocation,
2090 Range StringRange,
2091 FixItHint FixIt) {
2092 if (InFunctionCall)
2093 S.Diag(Loc, PDiag) << StringRange << FixIt;
2094 else {
2095 S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag)
2096 << ArgumentExpr->getSourceRange();
2097 S.Diag(IsStringLocation ? Loc : StringRange.getBegin(),
2098 diag::note_format_string_defined)
2099 << StringRange << FixIt;
2100 }
2101}
2102
Ted Kremenek826a3452010-07-16 02:11:22 +00002103//===--- CHECK: Printf format string checking ------------------------------===//
2104
2105namespace {
2106class CheckPrintfHandler : public CheckFormatHandler {
2107public:
2108 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
2109 const Expr *origFormatExpr, unsigned firstDataArg,
2110 unsigned numDataArgs, bool isObjCLiteral,
2111 const char *beg, bool hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002112 Expr **Args, unsigned NumArgs,
2113 unsigned formatIdx, bool inFunctionCall)
Ted Kremenek826a3452010-07-16 02:11:22 +00002114 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
2115 numDataArgs, isObjCLiteral, beg, hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002116 Args, NumArgs, formatIdx, inFunctionCall) {}
Ted Kremenek826a3452010-07-16 02:11:22 +00002117
2118
2119 bool HandleInvalidPrintfConversionSpecifier(
2120 const analyze_printf::PrintfSpecifier &FS,
2121 const char *startSpecifier,
2122 unsigned specifierLen);
2123
2124 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
2125 const char *startSpecifier,
2126 unsigned specifierLen);
2127
2128 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
2129 const char *startSpecifier, unsigned specifierLen);
2130 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
2131 const analyze_printf::OptionalAmount &Amt,
2132 unsigned type,
2133 const char *startSpecifier, unsigned specifierLen);
2134 void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
2135 const analyze_printf::OptionalFlag &flag,
2136 const char *startSpecifier, unsigned specifierLen);
2137 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
2138 const analyze_printf::OptionalFlag &ignoredFlag,
2139 const analyze_printf::OptionalFlag &flag,
2140 const char *startSpecifier, unsigned specifierLen);
2141};
2142}
2143
2144bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
2145 const analyze_printf::PrintfSpecifier &FS,
2146 const char *startSpecifier,
2147 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002148 const analyze_printf::PrintfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002149 FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00002150
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002151 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2152 getLocationOfByte(CS.getStart()),
2153 startSpecifier, specifierLen,
2154 CS.getStart(), CS.getLength());
Ted Kremenek26ac2e02010-01-29 02:40:24 +00002155}
2156
Ted Kremenek826a3452010-07-16 02:11:22 +00002157bool CheckPrintfHandler::HandleAmount(
2158 const analyze_format_string::OptionalAmount &Amt,
2159 unsigned k, const char *startSpecifier,
2160 unsigned specifierLen) {
Ted Kremenek0d277352010-01-29 01:06:55 +00002161
2162 if (Amt.hasDataArgument()) {
Ted Kremenek0d277352010-01-29 01:06:55 +00002163 if (!HasVAListArg) {
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002164 unsigned argIndex = Amt.getArgIndex();
2165 if (argIndex >= NumDataArgs) {
Richard Trieu55733de2011-10-28 00:41:25 +00002166 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg)
2167 << k,
2168 getLocationOfByte(Amt.getStart()),
2169 /*IsStringLocation*/true,
2170 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek0d277352010-01-29 01:06:55 +00002171 // Don't do any more checking. We will just emit
2172 // spurious errors.
2173 return false;
2174 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002175
Ted Kremenek0d277352010-01-29 01:06:55 +00002176 // Type check the data argument. It should be an 'int'.
Ted Kremenek31f8e322010-01-29 23:32:22 +00002177 // Although not in conformance with C99, we also allow the argument to be
2178 // an 'unsigned int' as that is a reasonably safe case. GCC also
2179 // doesn't emit a warning for that case.
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002180 CoveredArgs.set(argIndex);
2181 const Expr *Arg = getDataArg(argIndex);
Ted Kremenek0d277352010-01-29 01:06:55 +00002182 QualType T = Arg->getType();
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002183
2184 const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context);
2185 assert(ATR.isValid());
2186
2187 if (!ATR.matchesType(S.Context, T)) {
Richard Trieu55733de2011-10-28 00:41:25 +00002188 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type)
Hans Wennborga792aff2011-12-07 10:33:11 +00002189 << k << ATR.getRepresentativeTypeName(S.Context)
Richard Trieu55733de2011-10-28 00:41:25 +00002190 << T << Arg->getSourceRange(),
2191 getLocationOfByte(Amt.getStart()),
2192 /*IsStringLocation*/true,
2193 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek0d277352010-01-29 01:06:55 +00002194 // Don't do any more checking. We will just emit
2195 // spurious errors.
2196 return false;
2197 }
2198 }
2199 }
2200 return true;
2201}
Ted Kremenek0d277352010-01-29 01:06:55 +00002202
Tom Caree4ee9662010-06-17 19:00:27 +00002203void CheckPrintfHandler::HandleInvalidAmount(
Ted Kremenek826a3452010-07-16 02:11:22 +00002204 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00002205 const analyze_printf::OptionalAmount &Amt,
2206 unsigned type,
2207 const char *startSpecifier,
2208 unsigned specifierLen) {
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002209 const analyze_printf::PrintfConversionSpecifier &CS =
2210 FS.getConversionSpecifier();
Tom Caree4ee9662010-06-17 19:00:27 +00002211
Richard Trieu55733de2011-10-28 00:41:25 +00002212 FixItHint fixit =
2213 Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant
2214 ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
2215 Amt.getConstantLength()))
2216 : FixItHint();
2217
2218 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount)
2219 << type << CS.toString(),
2220 getLocationOfByte(Amt.getStart()),
2221 /*IsStringLocation*/true,
2222 getSpecifierRange(startSpecifier, specifierLen),
2223 fixit);
Tom Caree4ee9662010-06-17 19:00:27 +00002224}
2225
Ted Kremenek826a3452010-07-16 02:11:22 +00002226void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00002227 const analyze_printf::OptionalFlag &flag,
2228 const char *startSpecifier,
2229 unsigned specifierLen) {
2230 // Warn about pointless flag with a fixit removal.
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002231 const analyze_printf::PrintfConversionSpecifier &CS =
2232 FS.getConversionSpecifier();
Richard Trieu55733de2011-10-28 00:41:25 +00002233 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag)
2234 << flag.toString() << CS.toString(),
2235 getLocationOfByte(flag.getPosition()),
2236 /*IsStringLocation*/true,
2237 getSpecifierRange(startSpecifier, specifierLen),
2238 FixItHint::CreateRemoval(
2239 getSpecifierRange(flag.getPosition(), 1)));
Tom Caree4ee9662010-06-17 19:00:27 +00002240}
2241
2242void CheckPrintfHandler::HandleIgnoredFlag(
Ted Kremenek826a3452010-07-16 02:11:22 +00002243 const analyze_printf::PrintfSpecifier &FS,
Tom Caree4ee9662010-06-17 19:00:27 +00002244 const analyze_printf::OptionalFlag &ignoredFlag,
2245 const analyze_printf::OptionalFlag &flag,
2246 const char *startSpecifier,
2247 unsigned specifierLen) {
2248 // Warn about ignored flag with a fixit removal.
Richard Trieu55733de2011-10-28 00:41:25 +00002249 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag)
2250 << ignoredFlag.toString() << flag.toString(),
2251 getLocationOfByte(ignoredFlag.getPosition()),
2252 /*IsStringLocation*/true,
2253 getSpecifierRange(startSpecifier, specifierLen),
2254 FixItHint::CreateRemoval(
2255 getSpecifierRange(ignoredFlag.getPosition(), 1)));
Tom Caree4ee9662010-06-17 19:00:27 +00002256}
2257
Ted Kremeneke0e53132010-01-28 23:39:18 +00002258bool
Ted Kremenek826a3452010-07-16 02:11:22 +00002259CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
Ted Kremenek5c41ee82010-02-11 09:27:41 +00002260 &FS,
Ted Kremeneke0e53132010-01-28 23:39:18 +00002261 const char *startSpecifier,
2262 unsigned specifierLen) {
2263
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002264 using namespace analyze_format_string;
Ted Kremenekefaff192010-02-27 01:41:03 +00002265 using namespace analyze_printf;
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002266 const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremeneke0e53132010-01-28 23:39:18 +00002267
Ted Kremenekbaa40062010-07-19 22:01:06 +00002268 if (FS.consumesDataArgument()) {
2269 if (atFirstArg) {
2270 atFirstArg = false;
2271 usesPositionalArgs = FS.usesPositionalArg();
2272 }
2273 else if (usesPositionalArgs != FS.usesPositionalArg()) {
Richard Trieu55733de2011-10-28 00:41:25 +00002274 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
2275 startSpecifier, specifierLen);
Ted Kremenekbaa40062010-07-19 22:01:06 +00002276 return false;
2277 }
Ted Kremenek0d277352010-01-29 01:06:55 +00002278 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002279
Ted Kremenekefaff192010-02-27 01:41:03 +00002280 // First check if the field width, precision, and conversion specifier
2281 // have matching data arguments.
2282 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
2283 startSpecifier, specifierLen)) {
2284 return false;
2285 }
2286
2287 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
2288 startSpecifier, specifierLen)) {
Ted Kremenek0d277352010-01-29 01:06:55 +00002289 return false;
2290 }
2291
Ted Kremenekf88c8e02010-01-29 20:55:36 +00002292 if (!CS.consumesDataArgument()) {
2293 // FIXME: Technically specifying a precision or field width here
2294 // makes no sense. Worth issuing a warning at some point.
Ted Kremenek0e5675d2010-02-10 02:16:30 +00002295 return true;
Ted Kremenekf88c8e02010-01-29 20:55:36 +00002296 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002297
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002298 // Consume the argument.
2299 unsigned argIndex = FS.getArgIndex();
Ted Kremeneke3fc5472010-02-27 08:34:51 +00002300 if (argIndex < NumDataArgs) {
2301 // The check to see if the argIndex is valid will come later.
2302 // We set the bit here because we may exit early from this
2303 // function if we encounter some other error.
2304 CoveredArgs.set(argIndex);
2305 }
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002306
2307 // Check for using an Objective-C specific conversion specifier
2308 // in a non-ObjC literal.
2309 if (!IsObjCLiteral && CS.isObjCArg()) {
Ted Kremenek826a3452010-07-16 02:11:22 +00002310 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
2311 specifierLen);
Ted Kremenek7f70dc82010-02-26 19:18:41 +00002312 }
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002313
Tom Caree4ee9662010-06-17 19:00:27 +00002314 // Check for invalid use of field width
2315 if (!FS.hasValidFieldWidth()) {
Tom Care45f9b7e2010-06-21 21:21:01 +00002316 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
Tom Caree4ee9662010-06-17 19:00:27 +00002317 startSpecifier, specifierLen);
2318 }
2319
2320 // Check for invalid use of precision
2321 if (!FS.hasValidPrecision()) {
2322 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
2323 startSpecifier, specifierLen);
2324 }
2325
2326 // Check each flag does not conflict with any other component.
Ted Kremenek65197b42011-01-08 05:28:46 +00002327 if (!FS.hasValidThousandsGroupingPrefix())
2328 HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00002329 if (!FS.hasValidLeadingZeros())
2330 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
2331 if (!FS.hasValidPlusPrefix())
2332 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
Tom Care45f9b7e2010-06-21 21:21:01 +00002333 if (!FS.hasValidSpacePrefix())
2334 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00002335 if (!FS.hasValidAlternativeForm())
2336 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
2337 if (!FS.hasValidLeftJustified())
2338 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
2339
2340 // Check that flags are not ignored by another flag
Tom Care45f9b7e2010-06-21 21:21:01 +00002341 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
2342 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
2343 startSpecifier, specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00002344 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
2345 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
2346 startSpecifier, specifierLen);
2347
2348 // Check the length modifier is valid with the given conversion specifier.
2349 const LengthModifier &LM = FS.getLengthModifier();
2350 if (!FS.hasValidLengthModifier())
Richard Trieu55733de2011-10-28 00:41:25 +00002351 EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length)
2352 << LM.toString() << CS.toString(),
2353 getLocationOfByte(LM.getStart()),
2354 /*IsStringLocation*/true,
2355 getSpecifierRange(startSpecifier, specifierLen),
2356 FixItHint::CreateRemoval(
2357 getSpecifierRange(LM.getStart(),
2358 LM.getLength())));
Hans Wennborg76517422012-02-22 10:17:01 +00002359 if (!FS.hasStandardLengthModifier())
2360 HandleNonStandardLengthModifier(LM, startSpecifier, specifierLen);
David Blaikie4e4d0842012-03-11 07:00:24 +00002361 if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
Hans Wennborg76517422012-02-22 10:17:01 +00002362 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
2363 if (!FS.hasStandardLengthConversionCombination())
2364 HandleNonStandardConversionSpecification(LM, CS, startSpecifier,
2365 specifierLen);
Tom Caree4ee9662010-06-17 19:00:27 +00002366
2367 // Are we using '%n'?
Ted Kremenek35d353b2010-07-20 20:04:10 +00002368 if (CS.getKind() == ConversionSpecifier::nArg) {
Tom Caree4ee9662010-06-17 19:00:27 +00002369 // Issue a warning about this being a possible security issue.
Richard Trieu55733de2011-10-28 00:41:25 +00002370 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_write_back),
2371 getLocationOfByte(CS.getStart()),
2372 /*IsStringLocation*/true,
2373 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremeneke82d8042010-01-29 01:35:25 +00002374 // Continue checking the other format specifiers.
2375 return true;
2376 }
Ted Kremenek5c41ee82010-02-11 09:27:41 +00002377
Ted Kremenekda51f0d2010-01-29 01:43:31 +00002378 // The remaining checks depend on the data arguments.
2379 if (HasVAListArg)
2380 return true;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002381
Ted Kremenek666a1972010-07-26 19:45:42 +00002382 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenekda51f0d2010-01-29 01:43:31 +00002383 return false;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00002384
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002385 // Now type check the data expression that matches the
2386 // format specifier.
2387 const Expr *Ex = getDataArg(argIndex);
Nico Weber339b9072012-01-31 01:43:25 +00002388 const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context,
2389 IsObjCLiteral);
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002390 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
2391 // Check if we didn't match because of an implicit cast from a 'char'
2392 // or 'short' to an 'int'. This is done because printf is a varargs
2393 // function.
2394 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex))
James Molloy392da482012-05-04 10:55:22 +00002395 if (ICE->getType() == S.Context.IntTy ||
2396 ICE->getType() == S.Context.UnsignedIntTy) {
Ted Kremenek4d8ae4d2010-10-21 04:00:58 +00002397 // All further checking is done on the subexpression.
2398 Ex = ICE->getSubExpr();
2399 if (ATR.matchesType(S.Context, Ex->getType()))
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002400 return true;
Ted Kremenek4d8ae4d2010-10-21 04:00:58 +00002401 }
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002402
2403 // We may be able to offer a FixItHint if it is a supported type.
2404 PrintfSpecifier fixedFS = FS;
David Blaikie4e4d0842012-03-11 07:00:24 +00002405 bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(),
Hans Wennborgbe6126a2012-02-15 09:59:46 +00002406 S.Context, IsObjCLiteral);
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002407
2408 if (success) {
2409 // Get the fix string from the fixed format specifier
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +00002410 SmallString<128> buf;
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002411 llvm::raw_svector_ostream os(buf);
2412 fixedFS.toString(os);
2413
Richard Trieu55733de2011-10-28 00:41:25 +00002414 EmitFormatDiagnostic(
2415 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
Hans Wennborga792aff2011-12-07 10:33:11 +00002416 << ATR.getRepresentativeTypeName(S.Context) << Ex->getType()
Richard Trieu55733de2011-10-28 00:41:25 +00002417 << Ex->getSourceRange(),
2418 getLocationOfByte(CS.getStart()),
2419 /*IsStringLocation*/true,
2420 getSpecifierRange(startSpecifier, specifierLen),
2421 FixItHint::CreateReplacement(
2422 getSpecifierRange(startSpecifier, specifierLen),
2423 os.str()));
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002424 }
2425 else {
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002426 EmitFormatDiagnostic(
2427 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2428 << ATR.getRepresentativeTypeName(S.Context) << Ex->getType()
2429 << getSpecifierRange(startSpecifier, specifierLen)
2430 << Ex->getSourceRange(),
2431 getLocationOfByte(CS.getStart()),
2432 true,
2433 getSpecifierRange(startSpecifier, specifierLen));
Michael J. Spencer96827eb2010-07-27 04:46:02 +00002434 }
2435 }
2436
Ted Kremeneke0e53132010-01-28 23:39:18 +00002437 return true;
2438}
2439
Ted Kremenek826a3452010-07-16 02:11:22 +00002440//===--- CHECK: Scanf format string checking ------------------------------===//
2441
2442namespace {
2443class CheckScanfHandler : public CheckFormatHandler {
2444public:
2445 CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
2446 const Expr *origFormatExpr, unsigned firstDataArg,
2447 unsigned numDataArgs, bool isObjCLiteral,
2448 const char *beg, bool hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002449 Expr **Args, unsigned NumArgs,
2450 unsigned formatIdx, bool inFunctionCall)
Ted Kremenek826a3452010-07-16 02:11:22 +00002451 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
2452 numDataArgs, isObjCLiteral, beg, hasVAListArg,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002453 Args, NumArgs, formatIdx, inFunctionCall) {}
Ted Kremenek826a3452010-07-16 02:11:22 +00002454
2455 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
2456 const char *startSpecifier,
2457 unsigned specifierLen);
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002458
2459 bool HandleInvalidScanfConversionSpecifier(
2460 const analyze_scanf::ScanfSpecifier &FS,
2461 const char *startSpecifier,
2462 unsigned specifierLen);
Ted Kremenekb7c21012010-07-16 18:28:03 +00002463
2464 void HandleIncompleteScanList(const char *start, const char *end);
Ted Kremenek826a3452010-07-16 02:11:22 +00002465};
Ted Kremenek07d161f2010-01-29 01:50:07 +00002466}
Ted Kremeneke0e53132010-01-28 23:39:18 +00002467
Ted Kremenekb7c21012010-07-16 18:28:03 +00002468void CheckScanfHandler::HandleIncompleteScanList(const char *start,
2469 const char *end) {
Richard Trieu55733de2011-10-28 00:41:25 +00002470 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete),
2471 getLocationOfByte(end), /*IsStringLocation*/true,
2472 getSpecifierRange(start, end - start));
Ted Kremenekb7c21012010-07-16 18:28:03 +00002473}
2474
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002475bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
2476 const analyze_scanf::ScanfSpecifier &FS,
2477 const char *startSpecifier,
2478 unsigned specifierLen) {
2479
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002480 const analyze_scanf::ScanfConversionSpecifier &CS =
Ted Kremenekc09b6a52010-07-19 21:25:57 +00002481 FS.getConversionSpecifier();
2482
2483 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2484 getLocationOfByte(CS.getStart()),
2485 startSpecifier, specifierLen,
2486 CS.getStart(), CS.getLength());
2487}
2488
Ted Kremenek826a3452010-07-16 02:11:22 +00002489bool CheckScanfHandler::HandleScanfSpecifier(
2490 const analyze_scanf::ScanfSpecifier &FS,
2491 const char *startSpecifier,
2492 unsigned specifierLen) {
2493
2494 using namespace analyze_scanf;
2495 using namespace analyze_format_string;
2496
Ted Kremenek6ecb9502010-07-20 20:04:27 +00002497 const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremenek826a3452010-07-16 02:11:22 +00002498
Ted Kremenekbaa40062010-07-19 22:01:06 +00002499 // Handle case where '%' and '*' don't consume an argument. These shouldn't
2500 // be used to decide if we are using positional arguments consistently.
2501 if (FS.consumesDataArgument()) {
2502 if (atFirstArg) {
2503 atFirstArg = false;
2504 usesPositionalArgs = FS.usesPositionalArg();
2505 }
2506 else if (usesPositionalArgs != FS.usesPositionalArg()) {
Richard Trieu55733de2011-10-28 00:41:25 +00002507 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
2508 startSpecifier, specifierLen);
Ted Kremenekbaa40062010-07-19 22:01:06 +00002509 return false;
2510 }
Ted Kremenek826a3452010-07-16 02:11:22 +00002511 }
2512
2513 // Check if the field with is non-zero.
2514 const OptionalAmount &Amt = FS.getFieldWidth();
2515 if (Amt.getHowSpecified() == OptionalAmount::Constant) {
2516 if (Amt.getConstantAmount() == 0) {
2517 const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
2518 Amt.getConstantLength());
Richard Trieu55733de2011-10-28 00:41:25 +00002519 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width),
2520 getLocationOfByte(Amt.getStart()),
2521 /*IsStringLocation*/true, R,
2522 FixItHint::CreateRemoval(R));
Ted Kremenek826a3452010-07-16 02:11:22 +00002523 }
2524 }
2525
2526 if (!FS.consumesDataArgument()) {
2527 // FIXME: Technically specifying a precision or field width here
2528 // makes no sense. Worth issuing a warning at some point.
2529 return true;
2530 }
2531
2532 // Consume the argument.
2533 unsigned argIndex = FS.getArgIndex();
2534 if (argIndex < NumDataArgs) {
2535 // The check to see if the argIndex is valid will come later.
2536 // We set the bit here because we may exit early from this
2537 // function if we encounter some other error.
2538 CoveredArgs.set(argIndex);
2539 }
2540
Ted Kremenek1e51c202010-07-20 20:04:47 +00002541 // Check the length modifier is valid with the given conversion specifier.
2542 const LengthModifier &LM = FS.getLengthModifier();
2543 if (!FS.hasValidLengthModifier()) {
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002544 const CharSourceRange &R = getSpecifierRange(LM.getStart(), LM.getLength());
2545 EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length)
2546 << LM.toString() << CS.toString()
2547 << getSpecifierRange(startSpecifier, specifierLen),
2548 getLocationOfByte(LM.getStart()),
2549 /*IsStringLocation*/true, R,
2550 FixItHint::CreateRemoval(R));
Ted Kremenek1e51c202010-07-20 20:04:47 +00002551 }
2552
Hans Wennborg76517422012-02-22 10:17:01 +00002553 if (!FS.hasStandardLengthModifier())
2554 HandleNonStandardLengthModifier(LM, startSpecifier, specifierLen);
David Blaikie4e4d0842012-03-11 07:00:24 +00002555 if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
Hans Wennborg76517422012-02-22 10:17:01 +00002556 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
2557 if (!FS.hasStandardLengthConversionCombination())
2558 HandleNonStandardConversionSpecification(LM, CS, startSpecifier,
2559 specifierLen);
2560
Ted Kremenek826a3452010-07-16 02:11:22 +00002561 // The remaining checks depend on the data arguments.
2562 if (HasVAListArg)
2563 return true;
2564
Ted Kremenek666a1972010-07-26 19:45:42 +00002565 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenek826a3452010-07-16 02:11:22 +00002566 return false;
Ted Kremenek826a3452010-07-16 02:11:22 +00002567
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002568 // Check that the argument type matches the format specifier.
2569 const Expr *Ex = getDataArg(argIndex);
2570 const analyze_scanf::ScanfArgTypeResult &ATR = FS.getArgType(S.Context);
2571 if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
2572 ScanfSpecifier fixedFS = FS;
David Blaikie4e4d0842012-03-11 07:00:24 +00002573 bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(),
Hans Wennborgbe6126a2012-02-15 09:59:46 +00002574 S.Context);
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002575
2576 if (success) {
2577 // Get the fix string from the fixed format specifier.
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +00002578 SmallString<128> buf;
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002579 llvm::raw_svector_ostream os(buf);
2580 fixedFS.toString(os);
2581
2582 EmitFormatDiagnostic(
2583 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2584 << ATR.getRepresentativeTypeName(S.Context) << Ex->getType()
2585 << Ex->getSourceRange(),
2586 getLocationOfByte(CS.getStart()),
2587 /*IsStringLocation*/true,
2588 getSpecifierRange(startSpecifier, specifierLen),
2589 FixItHint::CreateReplacement(
2590 getSpecifierRange(startSpecifier, specifierLen),
2591 os.str()));
2592 } else {
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002593 EmitFormatDiagnostic(
2594 S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002595 << ATR.getRepresentativeTypeName(S.Context) << Ex->getType()
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +00002596 << Ex->getSourceRange(),
2597 getLocationOfByte(CS.getStart()),
2598 /*IsStringLocation*/true,
2599 getSpecifierRange(startSpecifier, specifierLen));
Hans Wennborg6fcd9322011-12-10 13:20:11 +00002600 }
2601 }
2602
Ted Kremenek826a3452010-07-16 02:11:22 +00002603 return true;
2604}
2605
2606void Sema::CheckFormatString(const StringLiteral *FExpr,
Ted Kremenek0e5675d2010-02-10 02:16:30 +00002607 const Expr *OrigFormatExpr,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002608 Expr **Args, unsigned NumArgs,
2609 bool HasVAListArg, unsigned format_idx,
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00002610 unsigned firstDataArg, FormatStringType Type,
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002611 bool inFunctionCall) {
Ted Kremenek826a3452010-07-16 02:11:22 +00002612
Ted Kremeneke0e53132010-01-28 23:39:18 +00002613 // CHECK: is the format string a wide literal?
Douglas Gregor5cee1192011-07-27 05:40:30 +00002614 if (!FExpr->isAscii()) {
Richard Trieu55733de2011-10-28 00:41:25 +00002615 CheckFormatHandler::EmitFormatDiagnostic(
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002616 *this, inFunctionCall, Args[format_idx],
Richard Trieu55733de2011-10-28 00:41:25 +00002617 PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(),
2618 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
Ted Kremeneke0e53132010-01-28 23:39:18 +00002619 return;
2620 }
Ted Kremenek826a3452010-07-16 02:11:22 +00002621
Ted Kremeneke0e53132010-01-28 23:39:18 +00002622 // Str - The format string. NOTE: this is NOT null-terminated!
Chris Lattner5f9e2722011-07-23 10:55:15 +00002623 StringRef StrRef = FExpr->getString();
Benjamin Kramer2f4eaef2010-08-17 12:54:38 +00002624 const char *Str = StrRef.data();
2625 unsigned StrLen = StrRef.size();
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002626 const unsigned numDataArgs = NumArgs - firstDataArg;
Ted Kremenek826a3452010-07-16 02:11:22 +00002627
Ted Kremeneke0e53132010-01-28 23:39:18 +00002628 // CHECK: empty format string?
Ted Kremenek4cd57912011-09-29 05:52:16 +00002629 if (StrLen == 0 && numDataArgs > 0) {
Richard Trieu55733de2011-10-28 00:41:25 +00002630 CheckFormatHandler::EmitFormatDiagnostic(
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002631 *this, inFunctionCall, Args[format_idx],
Richard Trieu55733de2011-10-28 00:41:25 +00002632 PDiag(diag::warn_empty_format_string), FExpr->getLocStart(),
2633 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
Ted Kremeneke0e53132010-01-28 23:39:18 +00002634 return;
2635 }
Ted Kremenek826a3452010-07-16 02:11:22 +00002636
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00002637 if (Type == FST_Printf || Type == FST_NSString) {
Ted Kremenek826a3452010-07-16 02:11:22 +00002638 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
Ted Kremenek4cd57912011-09-29 05:52:16 +00002639 numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr),
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002640 Str, HasVAListArg, Args, NumArgs, format_idx,
Richard Trieu55733de2011-10-28 00:41:25 +00002641 inFunctionCall);
Ted Kremenek826a3452010-07-16 02:11:22 +00002642
Hans Wennborgd02deeb2011-12-15 10:25:47 +00002643 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen,
David Blaikie4e4d0842012-03-11 07:00:24 +00002644 getLangOpts()))
Ted Kremenek826a3452010-07-16 02:11:22 +00002645 H.DoneProcessing();
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00002646 } else if (Type == FST_Scanf) {
Ted Kremenek826a3452010-07-16 02:11:22 +00002647 CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
Ted Kremenek4cd57912011-09-29 05:52:16 +00002648 numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr),
Jean-Daniel Dupas29c3f812012-01-17 20:03:31 +00002649 Str, HasVAListArg, Args, NumArgs, format_idx,
Richard Trieu55733de2011-10-28 00:41:25 +00002650 inFunctionCall);
Ted Kremenek826a3452010-07-16 02:11:22 +00002651
Hans Wennborgd02deeb2011-12-15 10:25:47 +00002652 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen,
David Blaikie4e4d0842012-03-11 07:00:24 +00002653 getLangOpts()))
Ted Kremenek826a3452010-07-16 02:11:22 +00002654 H.DoneProcessing();
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +00002655 } // TODO: handle other formats
Ted Kremenekce7024e2010-01-28 01:18:22 +00002656}
2657
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002658//===--- CHECK: Standard memory functions ---------------------------------===//
2659
Douglas Gregor2a053a32011-05-03 20:05:22 +00002660/// \brief Determine whether the given type is a dynamic class type (e.g.,
2661/// whether it has a vtable).
2662static bool isDynamicClassType(QualType T) {
2663 if (CXXRecordDecl *Record = T->getAsCXXRecordDecl())
2664 if (CXXRecordDecl *Definition = Record->getDefinition())
2665 if (Definition->isDynamicClass())
2666 return true;
2667
2668 return false;
2669}
2670
Chandler Carrutha72a12f2011-06-21 23:04:20 +00002671/// \brief If E is a sizeof expression, returns its argument expression,
Chandler Carruth000d4282011-06-16 09:09:40 +00002672/// otherwise returns NULL.
2673static const Expr *getSizeOfExprArg(const Expr* E) {
Nico Webere4a1c642011-06-14 16:14:58 +00002674 if (const UnaryExprOrTypeTraitExpr *SizeOf =
Chandler Carruth000d4282011-06-16 09:09:40 +00002675 dyn_cast<UnaryExprOrTypeTraitExpr>(E))
2676 if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType())
2677 return SizeOf->getArgumentExpr()->IgnoreParenImpCasts();
Nico Webere4a1c642011-06-14 16:14:58 +00002678
Chandler Carruth000d4282011-06-16 09:09:40 +00002679 return 0;
2680}
2681
Chandler Carrutha72a12f2011-06-21 23:04:20 +00002682/// \brief If E is a sizeof expression, returns its argument type.
Chandler Carruth000d4282011-06-16 09:09:40 +00002683static QualType getSizeOfArgType(const Expr* E) {
2684 if (const UnaryExprOrTypeTraitExpr *SizeOf =
2685 dyn_cast<UnaryExprOrTypeTraitExpr>(E))
2686 if (SizeOf->getKind() == clang::UETT_SizeOf)
2687 return SizeOf->getTypeOfArgument();
2688
2689 return QualType();
Nico Webere4a1c642011-06-14 16:14:58 +00002690}
2691
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002692/// \brief Check for dangerous or invalid arguments to memset().
2693///
Chandler Carruth929f0132011-06-03 06:23:57 +00002694/// This issues warnings on known problematic, dangerous or unspecified
Matt Beaumont-Gaycc2f30c2011-08-05 00:22:34 +00002695/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp'
2696/// function calls.
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002697///
2698/// \param Call The call expression to diagnose.
Matt Beaumont-Gaycc2f30c2011-08-05 00:22:34 +00002699void Sema::CheckMemaccessArguments(const CallExpr *Call,
Anna Zaks0a151a12012-01-17 00:37:07 +00002700 unsigned BId,
Matt Beaumont-Gaycc2f30c2011-08-05 00:22:34 +00002701 IdentifierInfo *FnName) {
Anna Zaks0a151a12012-01-17 00:37:07 +00002702 assert(BId != 0);
2703
Ted Kremenek1d59f7f2011-04-28 01:38:02 +00002704 // It is possible to have a non-standard definition of memset. Validate
Douglas Gregor707a23e2011-06-16 17:56:04 +00002705 // we have enough arguments, and if not, abort further checking.
Anna Zaks0a151a12012-01-17 00:37:07 +00002706 unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3);
Nico Webercda57822011-10-13 22:30:23 +00002707 if (Call->getNumArgs() < ExpectedNumArgs)
Ted Kremenek1d59f7f2011-04-28 01:38:02 +00002708 return;
2709
Anna Zaks0a151a12012-01-17 00:37:07 +00002710 unsigned LastArg = (BId == Builtin::BImemset ||
2711 BId == Builtin::BIstrndup ? 1 : 2);
2712 unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2);
Nico Webercda57822011-10-13 22:30:23 +00002713 const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts();
Chandler Carruth000d4282011-06-16 09:09:40 +00002714
2715 // We have special checking when the length is a sizeof expression.
2716 QualType SizeOfArgTy = getSizeOfArgType(LenExpr);
2717 const Expr *SizeOfArg = getSizeOfExprArg(LenExpr);
2718 llvm::FoldingSetNodeID SizeOfArgID;
2719
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002720 for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) {
2721 const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts();
Nico Webere4a1c642011-06-14 16:14:58 +00002722 SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange();
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002723
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002724 QualType DestTy = Dest->getType();
2725 if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) {
2726 QualType PointeeTy = DestPtrTy->getPointeeType();
John McCallf85e1932011-06-15 23:02:42 +00002727
Chandler Carruth000d4282011-06-16 09:09:40 +00002728 // Never warn about void type pointers. This can be used to suppress
2729 // false positives.
2730 if (PointeeTy->isVoidType())
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002731 continue;
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002732
Chandler Carruth000d4282011-06-16 09:09:40 +00002733 // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by
2734 // actually comparing the expressions for equality. Because computing the
2735 // expression IDs can be expensive, we only do this if the diagnostic is
2736 // enabled.
2737 if (SizeOfArg &&
2738 Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess,
2739 SizeOfArg->getExprLoc())) {
2740 // We only compute IDs for expressions if the warning is enabled, and
2741 // cache the sizeof arg's ID.
2742 if (SizeOfArgID == llvm::FoldingSetNodeID())
2743 SizeOfArg->Profile(SizeOfArgID, Context, true);
2744 llvm::FoldingSetNodeID DestID;
2745 Dest->Profile(DestID, Context, true);
2746 if (DestID == SizeOfArgID) {
Nico Webercda57822011-10-13 22:30:23 +00002747 // TODO: For strncpy() and friends, this could suggest sizeof(dst)
2748 // over sizeof(src) as well.
Chandler Carruth000d4282011-06-16 09:09:40 +00002749 unsigned ActionIdx = 0; // Default is to suggest dereferencing.
2750 if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest))
2751 if (UnaryOp->getOpcode() == UO_AddrOf)
2752 ActionIdx = 1; // If its an address-of operator, just remove it.
2753 if (Context.getTypeSize(PointeeTy) == Context.getCharWidth())
2754 ActionIdx = 2; // If the pointee's size is sizeof(char),
2755 // suggest an explicit length.
Anna Zaksd9b859a2012-01-13 21:52:01 +00002756 unsigned DestSrcSelect =
Anna Zaks0a151a12012-01-17 00:37:07 +00002757 (BId == Builtin::BIstrndup ? 1 : ArgIdx);
Chandler Carruth000d4282011-06-16 09:09:40 +00002758 DiagRuntimeBehavior(SizeOfArg->getExprLoc(), Dest,
2759 PDiag(diag::warn_sizeof_pointer_expr_memaccess)
Nico Webercda57822011-10-13 22:30:23 +00002760 << FnName << DestSrcSelect << ActionIdx
Chandler Carruth000d4282011-06-16 09:09:40 +00002761 << Dest->getSourceRange()
2762 << SizeOfArg->getSourceRange());
2763 break;
2764 }
2765 }
2766
2767 // Also check for cases where the sizeof argument is the exact same
2768 // type as the memory argument, and where it points to a user-defined
2769 // record type.
2770 if (SizeOfArgTy != QualType()) {
2771 if (PointeeTy->isRecordType() &&
2772 Context.typesAreCompatible(SizeOfArgTy, DestTy)) {
2773 DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest,
2774 PDiag(diag::warn_sizeof_pointer_type_memaccess)
2775 << FnName << SizeOfArgTy << ArgIdx
2776 << PointeeTy << Dest->getSourceRange()
2777 << LenExpr->getSourceRange());
2778 break;
2779 }
Nico Webere4a1c642011-06-14 16:14:58 +00002780 }
2781
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002782 // Always complain about dynamic classes.
Anna Zaks0a151a12012-01-17 00:37:07 +00002783 if (isDynamicClassType(PointeeTy)) {
2784
2785 unsigned OperationType = 0;
2786 // "overwritten" if we're warning about the destination for any call
2787 // but memcmp; otherwise a verb appropriate to the call.
2788 if (ArgIdx != 0 || BId == Builtin::BImemcmp) {
2789 if (BId == Builtin::BImemcpy)
2790 OperationType = 1;
2791 else if(BId == Builtin::BImemmove)
2792 OperationType = 2;
2793 else if (BId == Builtin::BImemcmp)
2794 OperationType = 3;
2795 }
2796
Matt Beaumont-Gay5c5218e2011-08-19 20:40:18 +00002797 DiagRuntimeBehavior(
2798 Dest->getExprLoc(), Dest,
2799 PDiag(diag::warn_dyn_class_memaccess)
Anna Zaks0a151a12012-01-17 00:37:07 +00002800 << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx)
Anna Zaksd9b859a2012-01-13 21:52:01 +00002801 << FnName << PointeeTy
Anna Zaks0a151a12012-01-17 00:37:07 +00002802 << OperationType
Matt Beaumont-Gay5c5218e2011-08-19 20:40:18 +00002803 << Call->getCallee()->getSourceRange());
Anna Zaks0a151a12012-01-17 00:37:07 +00002804 } else if (PointeeTy.hasNonTrivialObjCLifetime() &&
2805 BId != Builtin::BImemset)
Matt Beaumont-Gay5c5218e2011-08-19 20:40:18 +00002806 DiagRuntimeBehavior(
2807 Dest->getExprLoc(), Dest,
2808 PDiag(diag::warn_arc_object_memaccess)
2809 << ArgIdx << FnName << PointeeTy
2810 << Call->getCallee()->getSourceRange());
John McCallf85e1932011-06-15 23:02:42 +00002811 else
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002812 continue;
John McCallf85e1932011-06-15 23:02:42 +00002813
2814 DiagRuntimeBehavior(
2815 Dest->getExprLoc(), Dest,
Chandler Carruth929f0132011-06-03 06:23:57 +00002816 PDiag(diag::note_bad_memaccess_silence)
Douglas Gregor06bc9eb2011-05-03 20:37:33 +00002817 << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)"));
2818 break;
2819 }
Chandler Carruth7ccc95b2011-04-27 07:05:31 +00002820 }
2821}
2822
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00002823// A little helper routine: ignore addition and subtraction of integer literals.
2824// This intentionally does not ignore all integer constant expressions because
2825// we don't want to remove sizeof().
2826static const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) {
2827 Ex = Ex->IgnoreParenCasts();
2828
2829 for (;;) {
2830 const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex);
2831 if (!BO || !BO->isAdditiveOp())
2832 break;
2833
2834 const Expr *RHS = BO->getRHS()->IgnoreParenCasts();
2835 const Expr *LHS = BO->getLHS()->IgnoreParenCasts();
2836
2837 if (isa<IntegerLiteral>(RHS))
2838 Ex = LHS;
2839 else if (isa<IntegerLiteral>(LHS))
2840 Ex = RHS;
2841 else
2842 break;
2843 }
2844
2845 return Ex;
2846}
2847
2848// Warn if the user has made the 'size' argument to strlcpy or strlcat
2849// be the size of the source, instead of the destination.
2850void Sema::CheckStrlcpycatArguments(const CallExpr *Call,
2851 IdentifierInfo *FnName) {
2852
2853 // Don't crash if the user has the wrong number of arguments
2854 if (Call->getNumArgs() != 3)
2855 return;
2856
2857 const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context);
2858 const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context);
2859 const Expr *CompareWithSrc = NULL;
2860
2861 // Look for 'strlcpy(dst, x, sizeof(x))'
2862 if (const Expr *Ex = getSizeOfExprArg(SizeArg))
2863 CompareWithSrc = Ex;
2864 else {
2865 // Look for 'strlcpy(dst, x, strlen(x))'
2866 if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) {
Richard Smith180f4792011-11-10 06:34:14 +00002867 if (SizeCall->isBuiltinCall() == Builtin::BIstrlen
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00002868 && SizeCall->getNumArgs() == 1)
2869 CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context);
2870 }
2871 }
2872
2873 if (!CompareWithSrc)
2874 return;
2875
2876 // Determine if the argument to sizeof/strlen is equal to the source
2877 // argument. In principle there's all kinds of things you could do
2878 // here, for instance creating an == expression and evaluating it with
2879 // EvaluateAsBooleanCondition, but this uses a more direct technique:
2880 const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg);
2881 if (!SrcArgDRE)
2882 return;
2883
2884 const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc);
2885 if (!CompareWithSrcDRE ||
2886 SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl())
2887 return;
2888
2889 const Expr *OriginalSizeArg = Call->getArg(2);
2890 Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size)
2891 << OriginalSizeArg->getSourceRange() << FnName;
2892
2893 // Output a FIXIT hint if the destination is an array (rather than a
2894 // pointer to an array). This could be enhanced to handle some
2895 // pointers if we know the actual size, like if DstArg is 'array+2'
2896 // we could say 'sizeof(array)-2'.
2897 const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts();
Ted Kremenek8f746222011-08-18 22:48:41 +00002898 QualType DstArgTy = DstArg->getType();
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00002899
Ted Kremenek8f746222011-08-18 22:48:41 +00002900 // Only handle constant-sized or VLAs, but not flexible members.
2901 if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) {
2902 // Only issue the FIXIT for arrays of size > 1.
2903 if (CAT->getSize().getSExtValue() <= 1)
2904 return;
2905 } else if (!DstArgTy->isVariableArrayType()) {
2906 return;
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00002907 }
Ted Kremenek8f746222011-08-18 22:48:41 +00002908
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +00002909 SmallString<128> sizeString;
Ted Kremenek8f746222011-08-18 22:48:41 +00002910 llvm::raw_svector_ostream OS(sizeString);
2911 OS << "sizeof(";
Douglas Gregor8987b232011-09-27 23:30:47 +00002912 DstArg->printPretty(OS, Context, 0, getPrintingPolicy());
Ted Kremenek8f746222011-08-18 22:48:41 +00002913 OS << ")";
2914
2915 Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size)
2916 << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(),
2917 OS.str());
Ted Kremenekbd5da9d2011-08-18 20:55:45 +00002918}
2919
Anna Zaksc36bedc2012-02-01 19:08:57 +00002920/// Check if two expressions refer to the same declaration.
2921static bool referToTheSameDecl(const Expr *E1, const Expr *E2) {
2922 if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1))
2923 if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2))
2924 return D1->getDecl() == D2->getDecl();
2925 return false;
2926}
2927
2928static const Expr *getStrlenExprArg(const Expr *E) {
2929 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
2930 const FunctionDecl *FD = CE->getDirectCallee();
2931 if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen)
2932 return 0;
2933 return CE->getArg(0)->IgnoreParenCasts();
2934 }
2935 return 0;
2936}
2937
2938// Warn on anti-patterns as the 'size' argument to strncat.
2939// The correct size argument should look like following:
2940// strncat(dst, src, sizeof(dst) - strlen(dest) - 1);
2941void Sema::CheckStrncatArguments(const CallExpr *CE,
2942 IdentifierInfo *FnName) {
2943 // Don't crash if the user has the wrong number of arguments.
2944 if (CE->getNumArgs() < 3)
2945 return;
2946 const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts();
2947 const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts();
2948 const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts();
2949
2950 // Identify common expressions, which are wrongly used as the size argument
2951 // to strncat and may lead to buffer overflows.
2952 unsigned PatternType = 0;
2953 if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) {
2954 // - sizeof(dst)
2955 if (referToTheSameDecl(SizeOfArg, DstArg))
2956 PatternType = 1;
2957 // - sizeof(src)
2958 else if (referToTheSameDecl(SizeOfArg, SrcArg))
2959 PatternType = 2;
2960 } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) {
2961 if (BE->getOpcode() == BO_Sub) {
2962 const Expr *L = BE->getLHS()->IgnoreParenCasts();
2963 const Expr *R = BE->getRHS()->IgnoreParenCasts();
2964 // - sizeof(dst) - strlen(dst)
2965 if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) &&
2966 referToTheSameDecl(DstArg, getStrlenExprArg(R)))
2967 PatternType = 1;
2968 // - sizeof(src) - (anything)
2969 else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L)))
2970 PatternType = 2;
2971 }
2972 }
2973
2974 if (PatternType == 0)
2975 return;
2976
Anna Zaksafdb0412012-02-03 01:27:37 +00002977 // Generate the diagnostic.
2978 SourceLocation SL = LenArg->getLocStart();
2979 SourceRange SR = LenArg->getSourceRange();
2980 SourceManager &SM = PP.getSourceManager();
2981
2982 // If the function is defined as a builtin macro, do not show macro expansion.
2983 if (SM.isMacroArgExpansion(SL)) {
2984 SL = SM.getSpellingLoc(SL);
2985 SR = SourceRange(SM.getSpellingLoc(SR.getBegin()),
2986 SM.getSpellingLoc(SR.getEnd()));
2987 }
2988
Anna Zaksc36bedc2012-02-01 19:08:57 +00002989 if (PatternType == 1)
Anna Zaksafdb0412012-02-03 01:27:37 +00002990 Diag(SL, diag::warn_strncat_large_size) << SR;
Anna Zaksc36bedc2012-02-01 19:08:57 +00002991 else
Anna Zaksafdb0412012-02-03 01:27:37 +00002992 Diag(SL, diag::warn_strncat_src_size) << SR;
Anna Zaksc36bedc2012-02-01 19:08:57 +00002993
2994 // Output a FIXIT hint if the destination is an array (rather than a
2995 // pointer to an array). This could be enhanced to handle some
2996 // pointers if we know the actual size, like if DstArg is 'array+2'
2997 // we could say 'sizeof(array)-2'.
2998 QualType DstArgTy = DstArg->getType();
2999
3000 // Only handle constant-sized or VLAs, but not flexible members.
3001 if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) {
3002 // Only issue the FIXIT for arrays of size > 1.
3003 if (CAT->getSize().getSExtValue() <= 1)
3004 return;
3005 } else if (!DstArgTy->isVariableArrayType()) {
3006 return;
3007 }
3008
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +00003009 SmallString<128> sizeString;
Anna Zaksc36bedc2012-02-01 19:08:57 +00003010 llvm::raw_svector_ostream OS(sizeString);
3011 OS << "sizeof(";
3012 DstArg->printPretty(OS, Context, 0, getPrintingPolicy());
3013 OS << ") - ";
3014 OS << "strlen(";
3015 DstArg->printPretty(OS, Context, 0, getPrintingPolicy());
3016 OS << ") - 1";
3017
Anna Zaksafdb0412012-02-03 01:27:37 +00003018 Diag(SL, diag::note_strncat_wrong_size)
3019 << FixItHint::CreateReplacement(SR, OS.str());
Anna Zaksc36bedc2012-02-01 19:08:57 +00003020}
3021
Ted Kremenek06de2762007-08-17 16:46:58 +00003022//===--- CHECK: Return Address of Stack Variable --------------------------===//
3023
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003024static Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3025 Decl *ParentDecl);
3026static Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars,
3027 Decl *ParentDecl);
Ted Kremenek06de2762007-08-17 16:46:58 +00003028
3029/// CheckReturnStackAddr - Check if a return statement returns the address
3030/// of a stack variable.
3031void
3032Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
3033 SourceLocation ReturnLoc) {
Mike Stump1eb44332009-09-09 15:08:12 +00003034
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003035 Expr *stackE = 0;
Chris Lattner5f9e2722011-07-23 10:55:15 +00003036 SmallVector<DeclRefExpr *, 8> refVars;
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003037
3038 // Perform checking for returned stack addresses, local blocks,
3039 // label addresses or references to temporaries.
John McCallf85e1932011-06-15 23:02:42 +00003040 if (lhsType->isPointerType() ||
David Blaikie4e4d0842012-03-11 07:00:24 +00003041 (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) {
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003042 stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0);
Mike Stumpac5fc7c2009-08-04 21:02:39 +00003043 } else if (lhsType->isReferenceType()) {
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003044 stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0);
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003045 }
3046
3047 if (stackE == 0)
3048 return; // Nothing suspicious was found.
3049
3050 SourceLocation diagLoc;
3051 SourceRange diagRange;
3052 if (refVars.empty()) {
3053 diagLoc = stackE->getLocStart();
3054 diagRange = stackE->getSourceRange();
3055 } else {
3056 // We followed through a reference variable. 'stackE' contains the
3057 // problematic expression but we will warn at the return statement pointing
3058 // at the reference variable. We will later display the "trail" of
3059 // reference variables using notes.
3060 diagLoc = refVars[0]->getLocStart();
3061 diagRange = refVars[0]->getSourceRange();
3062 }
3063
3064 if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var.
3065 Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref
3066 : diag::warn_ret_stack_addr)
3067 << DR->getDecl()->getDeclName() << diagRange;
3068 } else if (isa<BlockExpr>(stackE)) { // local block.
3069 Diag(diagLoc, diag::err_ret_local_block) << diagRange;
3070 } else if (isa<AddrLabelExpr>(stackE)) { // address of label.
3071 Diag(diagLoc, diag::warn_ret_addr_label) << diagRange;
3072 } else { // local temporary.
3073 Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref
3074 : diag::warn_ret_local_temp_addr)
3075 << diagRange;
3076 }
3077
3078 // Display the "trail" of reference variables that we followed until we
3079 // found the problematic expression using notes.
3080 for (unsigned i = 0, e = refVars.size(); i != e; ++i) {
3081 VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl());
3082 // If this var binds to another reference var, show the range of the next
3083 // var, otherwise the var binds to the problematic expression, in which case
3084 // show the range of the expression.
3085 SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange()
3086 : stackE->getSourceRange();
3087 Diag(VD->getLocation(), diag::note_ref_var_local_bind)
3088 << VD->getDeclName() << range;
Ted Kremenek06de2762007-08-17 16:46:58 +00003089 }
3090}
3091
3092/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
3093/// check if the expression in a return statement evaluates to an address
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003094/// to a location on the stack, a local block, an address of a label, or a
3095/// reference to local temporary. The recursion is used to traverse the
Ted Kremenek06de2762007-08-17 16:46:58 +00003096/// AST of the return expression, with recursion backtracking when we
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003097/// encounter a subexpression that (1) clearly does not lead to one of the
3098/// above problematic expressions (2) is something we cannot determine leads to
3099/// a problematic expression based on such local checking.
3100///
3101/// Both EvalAddr and EvalVal follow through reference variables to evaluate
3102/// the expression that they point to. Such variables are added to the
3103/// 'refVars' vector so that we know what the reference variable "trail" was.
Ted Kremenek06de2762007-08-17 16:46:58 +00003104///
Ted Kremeneke8c600f2007-08-28 17:02:55 +00003105/// EvalAddr processes expressions that are pointers that are used as
3106/// references (and not L-values). EvalVal handles all other values.
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003107/// At the base case of the recursion is a check for the above problematic
3108/// expressions.
Ted Kremenek06de2762007-08-17 16:46:58 +00003109///
3110/// This implementation handles:
3111///
3112/// * pointer-to-pointer casts
3113/// * implicit conversions from array references to pointers
3114/// * taking the address of fields
3115/// * arbitrary interplay between "&" and "*" operators
3116/// * pointer arithmetic from an address of a stack variable
3117/// * taking the address of an array element where the array is on the stack
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003118static Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3119 Decl *ParentDecl) {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003120 if (E->isTypeDependent())
3121 return NULL;
3122
Ted Kremenek06de2762007-08-17 16:46:58 +00003123 // We should only be called for evaluating pointer expressions.
David Chisnall0f436562009-08-17 16:35:33 +00003124 assert((E->getType()->isAnyPointerType() ||
Steve Naroffdd972f22008-09-05 22:11:13 +00003125 E->getType()->isBlockPointerType() ||
Ted Kremeneka526c5c2008-01-07 19:49:32 +00003126 E->getType()->isObjCQualifiedIdType()) &&
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003127 "EvalAddr only works on pointers");
Mike Stump1eb44332009-09-09 15:08:12 +00003128
Peter Collingbournef111d932011-04-15 00:35:48 +00003129 E = E->IgnoreParens();
3130
Ted Kremenek06de2762007-08-17 16:46:58 +00003131 // Our "symbolic interpreter" is just a dispatch off the currently
3132 // viewed AST node. We then recursively traverse the AST by calling
3133 // EvalAddr and EvalVal appropriately.
3134 switch (E->getStmtClass()) {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003135 case Stmt::DeclRefExprClass: {
3136 DeclRefExpr *DR = cast<DeclRefExpr>(E);
3137
3138 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
3139 // If this is a reference variable, follow through to the expression that
3140 // it points to.
3141 if (V->hasLocalStorage() &&
3142 V->getType()->isReferenceType() && V->hasInit()) {
3143 // Add the reference variable to the "trail".
3144 refVars.push_back(DR);
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003145 return EvalAddr(V->getInit(), refVars, ParentDecl);
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003146 }
3147
3148 return NULL;
3149 }
Ted Kremenek06de2762007-08-17 16:46:58 +00003150
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003151 case Stmt::UnaryOperatorClass: {
3152 // The only unary operator that make sense to handle here
3153 // is AddrOf. All others don't make sense as pointers.
3154 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003155
John McCall2de56d12010-08-25 11:45:40 +00003156 if (U->getOpcode() == UO_AddrOf)
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003157 return EvalVal(U->getSubExpr(), refVars, ParentDecl);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003158 else
Ted Kremenek06de2762007-08-17 16:46:58 +00003159 return NULL;
3160 }
Mike Stump1eb44332009-09-09 15:08:12 +00003161
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003162 case Stmt::BinaryOperatorClass: {
3163 // Handle pointer arithmetic. All other binary operators are not valid
3164 // in this context.
3165 BinaryOperator *B = cast<BinaryOperator>(E);
John McCall2de56d12010-08-25 11:45:40 +00003166 BinaryOperatorKind op = B->getOpcode();
Mike Stump1eb44332009-09-09 15:08:12 +00003167
John McCall2de56d12010-08-25 11:45:40 +00003168 if (op != BO_Add && op != BO_Sub)
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003169 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +00003170
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003171 Expr *Base = B->getLHS();
3172
3173 // Determine which argument is the real pointer base. It could be
3174 // the RHS argument instead of the LHS.
3175 if (!Base->getType()->isPointerType()) Base = B->getRHS();
Mike Stump1eb44332009-09-09 15:08:12 +00003176
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003177 assert (Base->getType()->isPointerType());
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003178 return EvalAddr(Base, refVars, ParentDecl);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003179 }
Steve Naroff61f40a22008-09-10 19:17:48 +00003180
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003181 // For conditional operators we need to see if either the LHS or RHS are
3182 // valid DeclRefExpr*s. If one of them is valid, we return it.
3183 case Stmt::ConditionalOperatorClass: {
3184 ConditionalOperator *C = cast<ConditionalOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003185
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003186 // Handle the GNU extension for missing LHS.
Douglas Gregor9ee5ee82010-10-21 16:21:08 +00003187 if (Expr *lhsExpr = C->getLHS()) {
3188 // In C++, we can have a throw-expression, which has 'void' type.
3189 if (!lhsExpr->getType()->isVoidType())
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003190 if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl))
Douglas Gregor9ee5ee82010-10-21 16:21:08 +00003191 return LHS;
3192 }
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003193
Douglas Gregor9ee5ee82010-10-21 16:21:08 +00003194 // In C++, we can have a throw-expression, which has 'void' type.
3195 if (C->getRHS()->getType()->isVoidType())
3196 return NULL;
3197
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003198 return EvalAddr(C->getRHS(), refVars, ParentDecl);
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003199 }
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003200
3201 case Stmt::BlockExprClass:
John McCall469a1eb2011-02-02 13:00:07 +00003202 if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures())
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003203 return E; // local block.
3204 return NULL;
3205
3206 case Stmt::AddrLabelExprClass:
3207 return E; // address of label.
Mike Stump1eb44332009-09-09 15:08:12 +00003208
John McCall80ee6e82011-11-10 05:35:25 +00003209 case Stmt::ExprWithCleanupsClass:
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003210 return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,
3211 ParentDecl);
John McCall80ee6e82011-11-10 05:35:25 +00003212
Ted Kremenek54b52742008-08-07 00:49:01 +00003213 // For casts, we need to handle conversions from arrays to
3214 // pointer values, and pointer-to-pointer conversions.
Douglas Gregor49badde2008-10-27 19:41:14 +00003215 case Stmt::ImplicitCastExprClass:
Douglas Gregor6eec8e82008-10-28 15:36:24 +00003216 case Stmt::CStyleCastExprClass:
John McCallf85e1932011-06-15 23:02:42 +00003217 case Stmt::CXXFunctionalCastExprClass:
Eli Friedman8b9414e2012-02-23 23:04:32 +00003218 case Stmt::ObjCBridgedCastExprClass:
Mike Stump1eb44332009-09-09 15:08:12 +00003219 case Stmt::CXXStaticCastExprClass:
3220 case Stmt::CXXDynamicCastExprClass:
Douglas Gregor49badde2008-10-27 19:41:14 +00003221 case Stmt::CXXConstCastExprClass:
3222 case Stmt::CXXReinterpretCastExprClass: {
Eli Friedman8b9414e2012-02-23 23:04:32 +00003223 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
3224 switch (cast<CastExpr>(E)->getCastKind()) {
3225 case CK_BitCast:
3226 case CK_LValueToRValue:
3227 case CK_NoOp:
3228 case CK_BaseToDerived:
3229 case CK_DerivedToBase:
3230 case CK_UncheckedDerivedToBase:
3231 case CK_Dynamic:
3232 case CK_CPointerToObjCPointerCast:
3233 case CK_BlockPointerToObjCPointerCast:
3234 case CK_AnyPointerToBlockPointerCast:
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003235 return EvalAddr(SubExpr, refVars, ParentDecl);
Eli Friedman8b9414e2012-02-23 23:04:32 +00003236
3237 case CK_ArrayToPointerDecay:
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003238 return EvalVal(SubExpr, refVars, ParentDecl);
Eli Friedman8b9414e2012-02-23 23:04:32 +00003239
3240 default:
3241 return 0;
3242 }
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003243 }
Mike Stump1eb44332009-09-09 15:08:12 +00003244
Douglas Gregor03e80032011-06-21 17:03:29 +00003245 case Stmt::MaterializeTemporaryExprClass:
3246 if (Expr *Result = EvalAddr(
3247 cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003248 refVars, ParentDecl))
Douglas Gregor03e80032011-06-21 17:03:29 +00003249 return Result;
3250
3251 return E;
3252
Chris Lattnerfae3f1f2007-12-28 05:31:15 +00003253 // Everything else: we simply don't reason about them.
3254 default:
3255 return NULL;
3256 }
Ted Kremenek06de2762007-08-17 16:46:58 +00003257}
Mike Stump1eb44332009-09-09 15:08:12 +00003258
Ted Kremenek06de2762007-08-17 16:46:58 +00003259
3260/// EvalVal - This function is complements EvalAddr in the mutual recursion.
3261/// See the comments for EvalAddr for more details.
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003262static Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3263 Decl *ParentDecl) {
Ted Kremenek68957a92010-08-04 20:01:07 +00003264do {
Ted Kremeneke8c600f2007-08-28 17:02:55 +00003265 // We should only be called for evaluating non-pointer expressions, or
3266 // expressions with a pointer type that are not used as references but instead
3267 // are l-values (e.g., DeclRefExpr with a pointer type).
Mike Stump1eb44332009-09-09 15:08:12 +00003268
Ted Kremenek06de2762007-08-17 16:46:58 +00003269 // Our "symbolic interpreter" is just a dispatch off the currently
3270 // viewed AST node. We then recursively traverse the AST by calling
3271 // EvalAddr and EvalVal appropriately.
Peter Collingbournef111d932011-04-15 00:35:48 +00003272
3273 E = E->IgnoreParens();
Ted Kremenek06de2762007-08-17 16:46:58 +00003274 switch (E->getStmtClass()) {
Ted Kremenek68957a92010-08-04 20:01:07 +00003275 case Stmt::ImplicitCastExprClass: {
3276 ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
John McCall5baba9d2010-08-25 10:28:54 +00003277 if (IE->getValueKind() == VK_LValue) {
Ted Kremenek68957a92010-08-04 20:01:07 +00003278 E = IE->getSubExpr();
3279 continue;
3280 }
3281 return NULL;
3282 }
3283
John McCall80ee6e82011-11-10 05:35:25 +00003284 case Stmt::ExprWithCleanupsClass:
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003285 return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl);
John McCall80ee6e82011-11-10 05:35:25 +00003286
Douglas Gregora2813ce2009-10-23 18:54:35 +00003287 case Stmt::DeclRefExprClass: {
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003288 // When we hit a DeclRefExpr we are looking at code that refers to a
3289 // variable's name. If it's not a reference variable we check if it has
3290 // local storage within the function, and if so, return the expression.
Ted Kremenek06de2762007-08-17 16:46:58 +00003291 DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003292
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003293 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) {
3294 // Check if it refers to itself, e.g. "int& i = i;".
3295 if (V == ParentDecl)
3296 return DR;
3297
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003298 if (V->hasLocalStorage()) {
3299 if (!V->getType()->isReferenceType())
3300 return DR;
3301
3302 // Reference variable, follow through to the expression that
3303 // it points to.
3304 if (V->hasInit()) {
3305 // Add the reference variable to the "trail".
3306 refVars.push_back(DR);
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003307 return EvalVal(V->getInit(), refVars, V);
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003308 }
3309 }
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003310 }
Mike Stump1eb44332009-09-09 15:08:12 +00003311
Ted Kremenek06de2762007-08-17 16:46:58 +00003312 return NULL;
3313 }
Mike Stump1eb44332009-09-09 15:08:12 +00003314
Ted Kremenek06de2762007-08-17 16:46:58 +00003315 case Stmt::UnaryOperatorClass: {
3316 // The only unary operator that make sense to handle here
3317 // is Deref. All others don't resolve to a "name." This includes
3318 // handling all sorts of rvalues passed to a unary operator.
3319 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003320
John McCall2de56d12010-08-25 11:45:40 +00003321 if (U->getOpcode() == UO_Deref)
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003322 return EvalAddr(U->getSubExpr(), refVars, ParentDecl);
Ted Kremenek06de2762007-08-17 16:46:58 +00003323
3324 return NULL;
3325 }
Mike Stump1eb44332009-09-09 15:08:12 +00003326
Ted Kremenek06de2762007-08-17 16:46:58 +00003327 case Stmt::ArraySubscriptExprClass: {
3328 // Array subscripts are potential references to data on the stack. We
3329 // retrieve the DeclRefExpr* for the array variable if it indeed
3330 // has local storage.
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003331 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl);
Ted Kremenek06de2762007-08-17 16:46:58 +00003332 }
Mike Stump1eb44332009-09-09 15:08:12 +00003333
Ted Kremenek06de2762007-08-17 16:46:58 +00003334 case Stmt::ConditionalOperatorClass: {
3335 // For conditional operators we need to see if either the LHS or RHS are
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003336 // non-NULL Expr's. If one is non-NULL, we return it.
Ted Kremenek06de2762007-08-17 16:46:58 +00003337 ConditionalOperator *C = cast<ConditionalOperator>(E);
3338
Anders Carlsson39073232007-11-30 19:04:31 +00003339 // Handle the GNU extension for missing LHS.
3340 if (Expr *lhsExpr = C->getLHS())
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003341 if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl))
Anders Carlsson39073232007-11-30 19:04:31 +00003342 return LHS;
3343
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003344 return EvalVal(C->getRHS(), refVars, ParentDecl);
Ted Kremenek06de2762007-08-17 16:46:58 +00003345 }
Mike Stump1eb44332009-09-09 15:08:12 +00003346
Ted Kremenek06de2762007-08-17 16:46:58 +00003347 // Accesses to members are potential references to data on the stack.
Douglas Gregor83f6faf2009-08-31 23:41:50 +00003348 case Stmt::MemberExprClass: {
Ted Kremenek06de2762007-08-17 16:46:58 +00003349 MemberExpr *M = cast<MemberExpr>(E);
Mike Stump1eb44332009-09-09 15:08:12 +00003350
Ted Kremenek06de2762007-08-17 16:46:58 +00003351 // Check for indirect access. We only want direct field accesses.
Ted Kremeneka423e812010-09-02 01:12:13 +00003352 if (M->isArrow())
Ted Kremenek06de2762007-08-17 16:46:58 +00003353 return NULL;
Ted Kremeneka423e812010-09-02 01:12:13 +00003354
3355 // Check whether the member type is itself a reference, in which case
3356 // we're not going to refer to the member, but to what the member refers to.
3357 if (M->getMemberDecl()->getType()->isReferenceType())
3358 return NULL;
3359
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003360 return EvalVal(M->getBase(), refVars, ParentDecl);
Ted Kremenek06de2762007-08-17 16:46:58 +00003361 }
Mike Stump1eb44332009-09-09 15:08:12 +00003362
Douglas Gregor03e80032011-06-21 17:03:29 +00003363 case Stmt::MaterializeTemporaryExprClass:
3364 if (Expr *Result = EvalVal(
3365 cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
Argyrios Kyrtzidise720ce72012-04-30 23:23:55 +00003366 refVars, ParentDecl))
Douglas Gregor03e80032011-06-21 17:03:29 +00003367 return Result;
3368
3369 return E;
3370
Ted Kremenek06de2762007-08-17 16:46:58 +00003371 default:
Argyrios Kyrtzidis26e10be2010-11-30 22:57:32 +00003372 // Check that we don't return or take the address of a reference to a
3373 // temporary. This is only useful in C++.
3374 if (!E->isTypeDependent() && E->isRValue())
3375 return E;
3376
3377 // Everything else: we simply don't reason about them.
Ted Kremenek06de2762007-08-17 16:46:58 +00003378 return NULL;
3379 }
Ted Kremenek68957a92010-08-04 20:01:07 +00003380} while (true);
Ted Kremenek06de2762007-08-17 16:46:58 +00003381}
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003382
3383//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
3384
3385/// Check for comparisons of floating point operands using != and ==.
3386/// Issue a warning if these are no self-comparisons, as they are not likely
3387/// to do what the programmer intended.
Richard Trieudd225092011-09-15 21:56:47 +00003388void Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) {
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003389 bool EmitWarning = true;
Mike Stump1eb44332009-09-09 15:08:12 +00003390
Richard Trieudd225092011-09-15 21:56:47 +00003391 Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts();
3392 Expr* RightExprSansParen = RHS->IgnoreParenImpCasts();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003393
3394 // Special case: check for x == x (which is OK).
3395 // Do not emit warnings for such cases.
3396 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
3397 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
3398 if (DRL->getDecl() == DRR->getDecl())
3399 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00003400
3401
Ted Kremenek1b500bb2007-11-29 00:59:04 +00003402 // Special case: check for comparisons against literals that can be exactly
3403 // represented by APFloat. In such cases, do not emit a warning. This
3404 // is a heuristic: often comparison against such literals are used to
3405 // detect if a value in a variable has not changed. This clearly can
3406 // lead to false negatives.
3407 if (EmitWarning) {
3408 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
3409 if (FLL->isExact())
3410 EmitWarning = false;
Mike Stumpac5fc7c2009-08-04 21:02:39 +00003411 } else
Ted Kremenek1b500bb2007-11-29 00:59:04 +00003412 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){
3413 if (FLR->isExact())
3414 EmitWarning = false;
3415 }
3416 }
Mike Stump1eb44332009-09-09 15:08:12 +00003417
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003418 // Check for comparisons with builtin types.
Sebastian Redl0eb23302009-01-19 00:08:26 +00003419 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003420 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
Richard Smith180f4792011-11-10 06:34:14 +00003421 if (CL->isBuiltinCall())
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003422 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00003423
Sebastian Redl0eb23302009-01-19 00:08:26 +00003424 if (EmitWarning)
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003425 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
Richard Smith180f4792011-11-10 06:34:14 +00003426 if (CR->isBuiltinCall())
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003427 EmitWarning = false;
Mike Stump1eb44332009-09-09 15:08:12 +00003428
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003429 // Emit the diagnostic.
3430 if (EmitWarning)
Richard Trieudd225092011-09-15 21:56:47 +00003431 Diag(Loc, diag::warn_floatingpoint_eq)
3432 << LHS->getSourceRange() << RHS->getSourceRange();
Ted Kremenek588e5eb2007-11-25 00:58:00 +00003433}
John McCallba26e582010-01-04 23:21:16 +00003434
John McCallf2370c92010-01-06 05:24:50 +00003435//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
3436//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
John McCallba26e582010-01-04 23:21:16 +00003437
John McCallf2370c92010-01-06 05:24:50 +00003438namespace {
John McCallba26e582010-01-04 23:21:16 +00003439
John McCallf2370c92010-01-06 05:24:50 +00003440/// Structure recording the 'active' range of an integer-valued
3441/// expression.
3442struct IntRange {
3443 /// The number of bits active in the int.
3444 unsigned Width;
John McCallba26e582010-01-04 23:21:16 +00003445
John McCallf2370c92010-01-06 05:24:50 +00003446 /// True if the int is known not to have negative values.
3447 bool NonNegative;
John McCallba26e582010-01-04 23:21:16 +00003448
John McCallf2370c92010-01-06 05:24:50 +00003449 IntRange(unsigned Width, bool NonNegative)
3450 : Width(Width), NonNegative(NonNegative)
3451 {}
John McCallba26e582010-01-04 23:21:16 +00003452
John McCall1844a6e2010-11-10 23:38:19 +00003453 /// Returns the range of the bool type.
John McCallf2370c92010-01-06 05:24:50 +00003454 static IntRange forBoolType() {
3455 return IntRange(1, true);
John McCall51313c32010-01-04 23:31:57 +00003456 }
3457
John McCall1844a6e2010-11-10 23:38:19 +00003458 /// Returns the range of an opaque value of the given integral type.
3459 static IntRange forValueOfType(ASTContext &C, QualType T) {
3460 return forValueOfCanonicalType(C,
3461 T->getCanonicalTypeInternal().getTypePtr());
John McCall51313c32010-01-04 23:31:57 +00003462 }
3463
John McCall1844a6e2010-11-10 23:38:19 +00003464 /// Returns the range of an opaque value of a canonical integral type.
3465 static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) {
John McCallf2370c92010-01-06 05:24:50 +00003466 assert(T->isCanonicalUnqualified());
3467
3468 if (const VectorType *VT = dyn_cast<VectorType>(T))
3469 T = VT->getElementType().getTypePtr();
3470 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
3471 T = CT->getElementType().getTypePtr();
John McCall323ed742010-05-06 08:58:33 +00003472
John McCall091f23f2010-11-09 22:22:12 +00003473 // For enum types, use the known bit width of the enumerators.
John McCall323ed742010-05-06 08:58:33 +00003474 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
3475 EnumDecl *Enum = ET->getDecl();
John McCall5e1cdac2011-10-07 06:10:15 +00003476 if (!Enum->isCompleteDefinition())
John McCall091f23f2010-11-09 22:22:12 +00003477 return IntRange(C.getIntWidth(QualType(T, 0)), false);
3478
John McCall323ed742010-05-06 08:58:33 +00003479 unsigned NumPositive = Enum->getNumPositiveBits();
3480 unsigned NumNegative = Enum->getNumNegativeBits();
3481
3482 return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
3483 }
John McCallf2370c92010-01-06 05:24:50 +00003484
3485 const BuiltinType *BT = cast<BuiltinType>(T);
3486 assert(BT->isInteger());
3487
3488 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
3489 }
3490
John McCall1844a6e2010-11-10 23:38:19 +00003491 /// Returns the "target" range of a canonical integral type, i.e.
3492 /// the range of values expressible in the type.
3493 ///
3494 /// This matches forValueOfCanonicalType except that enums have the
3495 /// full range of their type, not the range of their enumerators.
3496 static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) {
3497 assert(T->isCanonicalUnqualified());
3498
3499 if (const VectorType *VT = dyn_cast<VectorType>(T))
3500 T = VT->getElementType().getTypePtr();
3501 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
3502 T = CT->getElementType().getTypePtr();
3503 if (const EnumType *ET = dyn_cast<EnumType>(T))
Douglas Gregor69ff26b2011-09-08 23:29:05 +00003504 T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr();
John McCall1844a6e2010-11-10 23:38:19 +00003505
3506 const BuiltinType *BT = cast<BuiltinType>(T);
3507 assert(BT->isInteger());
3508
3509 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
3510 }
3511
3512 /// Returns the supremum of two ranges: i.e. their conservative merge.
John McCallc0cd21d2010-02-23 19:22:29 +00003513 static IntRange join(IntRange L, IntRange R) {
John McCallf2370c92010-01-06 05:24:50 +00003514 return IntRange(std::max(L.Width, R.Width),
John McCall60fad452010-01-06 22:07:33 +00003515 L.NonNegative && R.NonNegative);
3516 }
3517
John McCall1844a6e2010-11-10 23:38:19 +00003518 /// Returns the infinum of two ranges: i.e. their aggressive merge.
John McCallc0cd21d2010-02-23 19:22:29 +00003519 static IntRange meet(IntRange L, IntRange R) {
John McCall60fad452010-01-06 22:07:33 +00003520 return IntRange(std::min(L.Width, R.Width),
3521 L.NonNegative || R.NonNegative);
John McCallf2370c92010-01-06 05:24:50 +00003522 }
3523};
3524
Ted Kremenek0692a192012-01-31 05:37:37 +00003525static IntRange GetValueRange(ASTContext &C, llvm::APSInt &value,
3526 unsigned MaxWidth) {
John McCallf2370c92010-01-06 05:24:50 +00003527 if (value.isSigned() && value.isNegative())
3528 return IntRange(value.getMinSignedBits(), false);
3529
3530 if (value.getBitWidth() > MaxWidth)
Jay Foad9f71a8f2010-12-07 08:25:34 +00003531 value = value.trunc(MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00003532
3533 // isNonNegative() just checks the sign bit without considering
3534 // signedness.
3535 return IntRange(value.getActiveBits(), true);
3536}
3537
Ted Kremenek0692a192012-01-31 05:37:37 +00003538static IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
3539 unsigned MaxWidth) {
John McCallf2370c92010-01-06 05:24:50 +00003540 if (result.isInt())
3541 return GetValueRange(C, result.getInt(), MaxWidth);
3542
3543 if (result.isVector()) {
John McCall0acc3112010-01-06 22:57:21 +00003544 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
3545 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
3546 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
3547 R = IntRange::join(R, El);
3548 }
John McCallf2370c92010-01-06 05:24:50 +00003549 return R;
3550 }
3551
3552 if (result.isComplexInt()) {
3553 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
3554 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
3555 return IntRange::join(R, I);
John McCall51313c32010-01-04 23:31:57 +00003556 }
3557
3558 // This can happen with lossless casts to intptr_t of "based" lvalues.
3559 // Assume it might use arbitrary bits.
John McCall0acc3112010-01-06 22:57:21 +00003560 // FIXME: The only reason we need to pass the type in here is to get
3561 // the sign right on this one case. It would be nice if APValue
3562 // preserved this.
Eli Friedman65639282012-01-04 23:13:47 +00003563 assert(result.isLValue() || result.isAddrLabelDiff());
Douglas Gregor5e9ebb32011-05-21 16:28:01 +00003564 return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType());
John McCall51313c32010-01-04 23:31:57 +00003565}
John McCallf2370c92010-01-06 05:24:50 +00003566
3567/// Pseudo-evaluate the given integer expression, estimating the
3568/// range of values it might take.
3569///
3570/// \param MaxWidth - the width to which the value will be truncated
Ted Kremenek0692a192012-01-31 05:37:37 +00003571static IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
John McCallf2370c92010-01-06 05:24:50 +00003572 E = E->IgnoreParens();
3573
3574 // Try a full evaluation first.
3575 Expr::EvalResult result;
Richard Smith51f47082011-10-29 00:50:52 +00003576 if (E->EvaluateAsRValue(result, C))
John McCall0acc3112010-01-06 22:57:21 +00003577 return GetValueRange(C, result.Val, E->getType(), MaxWidth);
John McCallf2370c92010-01-06 05:24:50 +00003578
3579 // I think we only want to look through implicit casts here; if the
3580 // user has an explicit widening cast, we should treat the value as
3581 // being of the new, wider type.
3582 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
Eli Friedmanb17ee5b2011-12-15 02:41:52 +00003583 if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue)
John McCallf2370c92010-01-06 05:24:50 +00003584 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
3585
John McCall1844a6e2010-11-10 23:38:19 +00003586 IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType());
John McCallf2370c92010-01-06 05:24:50 +00003587
John McCall2de56d12010-08-25 11:45:40 +00003588 bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast);
John McCall60fad452010-01-06 22:07:33 +00003589
John McCallf2370c92010-01-06 05:24:50 +00003590 // Assume that non-integer casts can span the full range of the type.
John McCall60fad452010-01-06 22:07:33 +00003591 if (!isIntegerCast)
John McCallf2370c92010-01-06 05:24:50 +00003592 return OutputTypeRange;
3593
3594 IntRange SubRange
3595 = GetExprRange(C, CE->getSubExpr(),
3596 std::min(MaxWidth, OutputTypeRange.Width));
3597
3598 // Bail out if the subexpr's range is as wide as the cast type.
3599 if (SubRange.Width >= OutputTypeRange.Width)
3600 return OutputTypeRange;
3601
3602 // Otherwise, we take the smaller width, and we're non-negative if
3603 // either the output type or the subexpr is.
3604 return IntRange(SubRange.Width,
3605 SubRange.NonNegative || OutputTypeRange.NonNegative);
3606 }
3607
3608 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
3609 // If we can fold the condition, just take that operand.
3610 bool CondResult;
3611 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
3612 return GetExprRange(C, CondResult ? CO->getTrueExpr()
3613 : CO->getFalseExpr(),
3614 MaxWidth);
3615
3616 // Otherwise, conservatively merge.
3617 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
3618 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
3619 return IntRange::join(L, R);
3620 }
3621
3622 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
3623 switch (BO->getOpcode()) {
3624
3625 // Boolean-valued operations are single-bit and positive.
John McCall2de56d12010-08-25 11:45:40 +00003626 case BO_LAnd:
3627 case BO_LOr:
3628 case BO_LT:
3629 case BO_GT:
3630 case BO_LE:
3631 case BO_GE:
3632 case BO_EQ:
3633 case BO_NE:
John McCallf2370c92010-01-06 05:24:50 +00003634 return IntRange::forBoolType();
3635
John McCall862ff872011-07-13 06:35:24 +00003636 // The type of the assignments is the type of the LHS, so the RHS
3637 // is not necessarily the same type.
John McCall2de56d12010-08-25 11:45:40 +00003638 case BO_MulAssign:
3639 case BO_DivAssign:
3640 case BO_RemAssign:
3641 case BO_AddAssign:
3642 case BO_SubAssign:
John McCall862ff872011-07-13 06:35:24 +00003643 case BO_XorAssign:
3644 case BO_OrAssign:
3645 // TODO: bitfields?
John McCall1844a6e2010-11-10 23:38:19 +00003646 return IntRange::forValueOfType(C, E->getType());
John McCallc0cd21d2010-02-23 19:22:29 +00003647
John McCall862ff872011-07-13 06:35:24 +00003648 // Simple assignments just pass through the RHS, which will have
3649 // been coerced to the LHS type.
3650 case BO_Assign:
3651 // TODO: bitfields?
3652 return GetExprRange(C, BO->getRHS(), MaxWidth);
3653
John McCallf2370c92010-01-06 05:24:50 +00003654 // Operations with opaque sources are black-listed.
John McCall2de56d12010-08-25 11:45:40 +00003655 case BO_PtrMemD:
3656 case BO_PtrMemI:
John McCall1844a6e2010-11-10 23:38:19 +00003657 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00003658
John McCall60fad452010-01-06 22:07:33 +00003659 // Bitwise-and uses the *infinum* of the two source ranges.
John McCall2de56d12010-08-25 11:45:40 +00003660 case BO_And:
3661 case BO_AndAssign:
John McCall60fad452010-01-06 22:07:33 +00003662 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
3663 GetExprRange(C, BO->getRHS(), MaxWidth));
3664
John McCallf2370c92010-01-06 05:24:50 +00003665 // Left shift gets black-listed based on a judgement call.
John McCall2de56d12010-08-25 11:45:40 +00003666 case BO_Shl:
John McCall3aae6092010-04-07 01:14:35 +00003667 // ...except that we want to treat '1 << (blah)' as logically
3668 // positive. It's an important idiom.
3669 if (IntegerLiteral *I
3670 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
3671 if (I->getValue() == 1) {
John McCall1844a6e2010-11-10 23:38:19 +00003672 IntRange R = IntRange::forValueOfType(C, E->getType());
John McCall3aae6092010-04-07 01:14:35 +00003673 return IntRange(R.Width, /*NonNegative*/ true);
3674 }
3675 }
3676 // fallthrough
3677
John McCall2de56d12010-08-25 11:45:40 +00003678 case BO_ShlAssign:
John McCall1844a6e2010-11-10 23:38:19 +00003679 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00003680
John McCall60fad452010-01-06 22:07:33 +00003681 // Right shift by a constant can narrow its left argument.
John McCall2de56d12010-08-25 11:45:40 +00003682 case BO_Shr:
3683 case BO_ShrAssign: {
John McCall60fad452010-01-06 22:07:33 +00003684 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
3685
3686 // If the shift amount is a positive constant, drop the width by
3687 // that much.
3688 llvm::APSInt shift;
3689 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
3690 shift.isNonNegative()) {
3691 unsigned zext = shift.getZExtValue();
3692 if (zext >= L.Width)
3693 L.Width = (L.NonNegative ? 0 : 1);
3694 else
3695 L.Width -= zext;
3696 }
3697
3698 return L;
3699 }
3700
3701 // Comma acts as its right operand.
John McCall2de56d12010-08-25 11:45:40 +00003702 case BO_Comma:
John McCallf2370c92010-01-06 05:24:50 +00003703 return GetExprRange(C, BO->getRHS(), MaxWidth);
3704
John McCall60fad452010-01-06 22:07:33 +00003705 // Black-list pointer subtractions.
John McCall2de56d12010-08-25 11:45:40 +00003706 case BO_Sub:
John McCallf2370c92010-01-06 05:24:50 +00003707 if (BO->getLHS()->getType()->isPointerType())
John McCall1844a6e2010-11-10 23:38:19 +00003708 return IntRange::forValueOfType(C, E->getType());
John McCall00fe7612011-07-14 22:39:48 +00003709 break;
Ted Kremenek4e4b30e2010-02-16 01:46:59 +00003710
John McCall00fe7612011-07-14 22:39:48 +00003711 // The width of a division result is mostly determined by the size
3712 // of the LHS.
3713 case BO_Div: {
3714 // Don't 'pre-truncate' the operands.
3715 unsigned opWidth = C.getIntWidth(E->getType());
3716 IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
3717
3718 // If the divisor is constant, use that.
3719 llvm::APSInt divisor;
3720 if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) {
3721 unsigned log2 = divisor.logBase2(); // floor(log_2(divisor))
3722 if (log2 >= L.Width)
3723 L.Width = (L.NonNegative ? 0 : 1);
3724 else
3725 L.Width = std::min(L.Width - log2, MaxWidth);
3726 return L;
3727 }
3728
3729 // Otherwise, just use the LHS's width.
3730 IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
3731 return IntRange(L.Width, L.NonNegative && R.NonNegative);
3732 }
3733
3734 // The result of a remainder can't be larger than the result of
3735 // either side.
3736 case BO_Rem: {
3737 // Don't 'pre-truncate' the operands.
3738 unsigned opWidth = C.getIntWidth(E->getType());
3739 IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
3740 IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
3741
3742 IntRange meet = IntRange::meet(L, R);
3743 meet.Width = std::min(meet.Width, MaxWidth);
3744 return meet;
3745 }
3746
3747 // The default behavior is okay for these.
3748 case BO_Mul:
3749 case BO_Add:
3750 case BO_Xor:
3751 case BO_Or:
John McCallf2370c92010-01-06 05:24:50 +00003752 break;
3753 }
3754
John McCall00fe7612011-07-14 22:39:48 +00003755 // The default case is to treat the operation as if it were closed
3756 // on the narrowest type that encompasses both operands.
John McCallf2370c92010-01-06 05:24:50 +00003757 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
3758 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
3759 return IntRange::join(L, R);
3760 }
3761
3762 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
3763 switch (UO->getOpcode()) {
3764 // Boolean-valued operations are white-listed.
John McCall2de56d12010-08-25 11:45:40 +00003765 case UO_LNot:
John McCallf2370c92010-01-06 05:24:50 +00003766 return IntRange::forBoolType();
3767
3768 // Operations with opaque sources are black-listed.
John McCall2de56d12010-08-25 11:45:40 +00003769 case UO_Deref:
3770 case UO_AddrOf: // should be impossible
John McCall1844a6e2010-11-10 23:38:19 +00003771 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00003772
3773 default:
3774 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
3775 }
3776 }
Douglas Gregor8ecdb652010-04-28 22:16:22 +00003777
3778 if (dyn_cast<OffsetOfExpr>(E)) {
John McCall1844a6e2010-11-10 23:38:19 +00003779 IntRange::forValueOfType(C, E->getType());
Douglas Gregor8ecdb652010-04-28 22:16:22 +00003780 }
John McCallf2370c92010-01-06 05:24:50 +00003781
Richard Smitha6b8b2c2011-10-10 18:28:20 +00003782 if (FieldDecl *BitField = E->getBitField())
3783 return IntRange(BitField->getBitWidthValue(C),
Douglas Gregor5e9ebb32011-05-21 16:28:01 +00003784 BitField->getType()->isUnsignedIntegerOrEnumerationType());
John McCallf2370c92010-01-06 05:24:50 +00003785
John McCall1844a6e2010-11-10 23:38:19 +00003786 return IntRange::forValueOfType(C, E->getType());
John McCallf2370c92010-01-06 05:24:50 +00003787}
John McCall51313c32010-01-04 23:31:57 +00003788
Ted Kremenek0692a192012-01-31 05:37:37 +00003789static IntRange GetExprRange(ASTContext &C, Expr *E) {
John McCall323ed742010-05-06 08:58:33 +00003790 return GetExprRange(C, E, C.getIntWidth(E->getType()));
3791}
3792
John McCall51313c32010-01-04 23:31:57 +00003793/// Checks whether the given value, which currently has the given
3794/// source semantics, has the same value when coerced through the
3795/// target semantics.
Ted Kremenek0692a192012-01-31 05:37:37 +00003796static bool IsSameFloatAfterCast(const llvm::APFloat &value,
3797 const llvm::fltSemantics &Src,
3798 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00003799 llvm::APFloat truncated = value;
3800
3801 bool ignored;
3802 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
3803 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
3804
3805 return truncated.bitwiseIsEqual(value);
3806}
3807
3808/// Checks whether the given value, which currently has the given
3809/// source semantics, has the same value when coerced through the
3810/// target semantics.
3811///
3812/// The value might be a vector of floats (or a complex number).
Ted Kremenek0692a192012-01-31 05:37:37 +00003813static bool IsSameFloatAfterCast(const APValue &value,
3814 const llvm::fltSemantics &Src,
3815 const llvm::fltSemantics &Tgt) {
John McCall51313c32010-01-04 23:31:57 +00003816 if (value.isFloat())
3817 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
3818
3819 if (value.isVector()) {
3820 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
3821 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
3822 return false;
3823 return true;
3824 }
3825
3826 assert(value.isComplexFloat());
3827 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
3828 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
3829}
3830
Ted Kremenek0692a192012-01-31 05:37:37 +00003831static void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC);
John McCall323ed742010-05-06 08:58:33 +00003832
Ted Kremeneke3b159c2010-09-23 21:43:44 +00003833static bool IsZero(Sema &S, Expr *E) {
3834 // Suppress cases where we are comparing against an enum constant.
3835 if (const DeclRefExpr *DR =
3836 dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts()))
3837 if (isa<EnumConstantDecl>(DR->getDecl()))
3838 return false;
3839
3840 // Suppress cases where the '0' value is expanded from a macro.
3841 if (E->getLocStart().isMacroID())
3842 return false;
3843
John McCall323ed742010-05-06 08:58:33 +00003844 llvm::APSInt Value;
3845 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
3846}
3847
John McCall372e1032010-10-06 00:25:24 +00003848static bool HasEnumType(Expr *E) {
3849 // Strip off implicit integral promotions.
3850 while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
Argyrios Kyrtzidis63b57ae2010-10-07 21:52:18 +00003851 if (ICE->getCastKind() != CK_IntegralCast &&
3852 ICE->getCastKind() != CK_NoOp)
John McCall372e1032010-10-06 00:25:24 +00003853 break;
Argyrios Kyrtzidis63b57ae2010-10-07 21:52:18 +00003854 E = ICE->getSubExpr();
John McCall372e1032010-10-06 00:25:24 +00003855 }
3856
3857 return E->getType()->isEnumeralType();
3858}
3859
Ted Kremenek0692a192012-01-31 05:37:37 +00003860static void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
John McCall2de56d12010-08-25 11:45:40 +00003861 BinaryOperatorKind op = E->getOpcode();
Douglas Gregor14af91a2010-12-21 07:22:56 +00003862 if (E->isValueDependent())
3863 return;
3864
John McCall2de56d12010-08-25 11:45:40 +00003865 if (op == BO_LT && IsZero(S, E->getRHS())) {
John McCall323ed742010-05-06 08:58:33 +00003866 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00003867 << "< 0" << "false" << HasEnumType(E->getLHS())
John McCall323ed742010-05-06 08:58:33 +00003868 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00003869 } else if (op == BO_GE && IsZero(S, E->getRHS())) {
John McCall323ed742010-05-06 08:58:33 +00003870 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00003871 << ">= 0" << "true" << HasEnumType(E->getLHS())
John McCall323ed742010-05-06 08:58:33 +00003872 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00003873 } else if (op == BO_GT && IsZero(S, E->getLHS())) {
John McCall323ed742010-05-06 08:58:33 +00003874 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00003875 << "0 >" << "false" << HasEnumType(E->getRHS())
John McCall323ed742010-05-06 08:58:33 +00003876 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCall2de56d12010-08-25 11:45:40 +00003877 } else if (op == BO_LE && IsZero(S, E->getLHS())) {
John McCall323ed742010-05-06 08:58:33 +00003878 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
John McCall372e1032010-10-06 00:25:24 +00003879 << "0 <=" << "true" << HasEnumType(E->getRHS())
John McCall323ed742010-05-06 08:58:33 +00003880 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
3881 }
3882}
3883
3884/// Analyze the operands of the given comparison. Implements the
3885/// fallback case from AnalyzeComparison.
Ted Kremenek0692a192012-01-31 05:37:37 +00003886static void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
John McCallb4eb64d2010-10-08 02:01:28 +00003887 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
3888 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
John McCall323ed742010-05-06 08:58:33 +00003889}
John McCall51313c32010-01-04 23:31:57 +00003890
John McCallba26e582010-01-04 23:21:16 +00003891/// \brief Implements -Wsign-compare.
3892///
Richard Trieudd225092011-09-15 21:56:47 +00003893/// \param E the binary operator to check for warnings
Ted Kremenek0692a192012-01-31 05:37:37 +00003894static void AnalyzeComparison(Sema &S, BinaryOperator *E) {
John McCall323ed742010-05-06 08:58:33 +00003895 // The type the comparison is being performed in.
3896 QualType T = E->getLHS()->getType();
3897 assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
3898 && "comparison with mismatched types");
John McCallba26e582010-01-04 23:21:16 +00003899
John McCall323ed742010-05-06 08:58:33 +00003900 // We don't do anything special if this isn't an unsigned integral
3901 // comparison: we're only interested in integral comparisons, and
3902 // signed comparisons only happen in cases we don't care to warn about.
Douglas Gregor3e026e32011-02-19 22:34:59 +00003903 //
3904 // We also don't care about value-dependent expressions or expressions
3905 // whose result is a constant.
3906 if (!T->hasUnsignedIntegerRepresentation()
3907 || E->isValueDependent() || E->isIntegerConstantExpr(S.Context))
John McCall323ed742010-05-06 08:58:33 +00003908 return AnalyzeImpConvsInComparison(S, E);
John McCallf2370c92010-01-06 05:24:50 +00003909
Richard Trieudd225092011-09-15 21:56:47 +00003910 Expr *LHS = E->getLHS()->IgnoreParenImpCasts();
3911 Expr *RHS = E->getRHS()->IgnoreParenImpCasts();
John McCallba26e582010-01-04 23:21:16 +00003912
John McCall323ed742010-05-06 08:58:33 +00003913 // Check to see if one of the (unmodified) operands is of different
3914 // signedness.
3915 Expr *signedOperand, *unsignedOperand;
Richard Trieudd225092011-09-15 21:56:47 +00003916 if (LHS->getType()->hasSignedIntegerRepresentation()) {
3917 assert(!RHS->getType()->hasSignedIntegerRepresentation() &&
John McCall323ed742010-05-06 08:58:33 +00003918 "unsigned comparison between two signed integer expressions?");
Richard Trieudd225092011-09-15 21:56:47 +00003919 signedOperand = LHS;
3920 unsignedOperand = RHS;
3921 } else if (RHS->getType()->hasSignedIntegerRepresentation()) {
3922 signedOperand = RHS;
3923 unsignedOperand = LHS;
John McCallba26e582010-01-04 23:21:16 +00003924 } else {
John McCall323ed742010-05-06 08:58:33 +00003925 CheckTrivialUnsignedComparison(S, E);
3926 return AnalyzeImpConvsInComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00003927 }
3928
John McCall323ed742010-05-06 08:58:33 +00003929 // Otherwise, calculate the effective range of the signed operand.
3930 IntRange signedRange = GetExprRange(S.Context, signedOperand);
John McCallf2370c92010-01-06 05:24:50 +00003931
John McCall323ed742010-05-06 08:58:33 +00003932 // Go ahead and analyze implicit conversions in the operands. Note
3933 // that we skip the implicit conversions on both sides.
Richard Trieudd225092011-09-15 21:56:47 +00003934 AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc());
3935 AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc());
John McCallba26e582010-01-04 23:21:16 +00003936
John McCall323ed742010-05-06 08:58:33 +00003937 // If the signed range is non-negative, -Wsign-compare won't fire,
3938 // but we should still check for comparisons which are always true
3939 // or false.
3940 if (signedRange.NonNegative)
3941 return CheckTrivialUnsignedComparison(S, E);
John McCallba26e582010-01-04 23:21:16 +00003942
3943 // For (in)equality comparisons, if the unsigned operand is a
3944 // constant which cannot collide with a overflowed signed operand,
3945 // then reinterpreting the signed operand as unsigned will not
3946 // change the result of the comparison.
John McCall323ed742010-05-06 08:58:33 +00003947 if (E->isEqualityOp()) {
3948 unsigned comparisonWidth = S.Context.getIntWidth(T);
3949 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
John McCallba26e582010-01-04 23:21:16 +00003950
John McCall323ed742010-05-06 08:58:33 +00003951 // We should never be unable to prove that the unsigned operand is
3952 // non-negative.
3953 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
3954
3955 if (unsignedRange.Width < comparisonWidth)
3956 return;
3957 }
3958
Douglas Gregor6d3b93d2012-05-01 01:53:49 +00003959 S.DiagRuntimeBehavior(E->getOperatorLoc(), E,
3960 S.PDiag(diag::warn_mixed_sign_comparison)
3961 << LHS->getType() << RHS->getType()
3962 << LHS->getSourceRange() << RHS->getSourceRange());
John McCallba26e582010-01-04 23:21:16 +00003963}
3964
John McCall15d7d122010-11-11 03:21:53 +00003965/// Analyzes an attempt to assign the given value to a bitfield.
3966///
3967/// Returns true if there was something fishy about the attempt.
Ted Kremenek0692a192012-01-31 05:37:37 +00003968static bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init,
3969 SourceLocation InitLoc) {
John McCall15d7d122010-11-11 03:21:53 +00003970 assert(Bitfield->isBitField());
3971 if (Bitfield->isInvalidDecl())
3972 return false;
3973
John McCall91b60142010-11-11 05:33:51 +00003974 // White-list bool bitfields.
3975 if (Bitfield->getType()->isBooleanType())
3976 return false;
3977
Douglas Gregor46ff3032011-02-04 13:09:01 +00003978 // Ignore value- or type-dependent expressions.
3979 if (Bitfield->getBitWidth()->isValueDependent() ||
3980 Bitfield->getBitWidth()->isTypeDependent() ||
3981 Init->isValueDependent() ||
3982 Init->isTypeDependent())
3983 return false;
3984
John McCall15d7d122010-11-11 03:21:53 +00003985 Expr *OriginalInit = Init->IgnoreParenImpCasts();
3986
Richard Smith80d4b552011-12-28 19:48:30 +00003987 llvm::APSInt Value;
3988 if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects))
John McCall15d7d122010-11-11 03:21:53 +00003989 return false;
3990
John McCall15d7d122010-11-11 03:21:53 +00003991 unsigned OriginalWidth = Value.getBitWidth();
Richard Smitha6b8b2c2011-10-10 18:28:20 +00003992 unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context);
John McCall15d7d122010-11-11 03:21:53 +00003993
3994 if (OriginalWidth <= FieldWidth)
3995 return false;
3996
Eli Friedman3a643af2012-01-26 23:11:39 +00003997 // Compute the value which the bitfield will contain.
Jay Foad9f71a8f2010-12-07 08:25:34 +00003998 llvm::APSInt TruncatedValue = Value.trunc(FieldWidth);
Eli Friedman3a643af2012-01-26 23:11:39 +00003999 TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType());
John McCall15d7d122010-11-11 03:21:53 +00004000
Eli Friedman3a643af2012-01-26 23:11:39 +00004001 // Check whether the stored value is equal to the original value.
4002 TruncatedValue = TruncatedValue.extend(OriginalWidth);
John McCall15d7d122010-11-11 03:21:53 +00004003 if (Value == TruncatedValue)
4004 return false;
4005
Eli Friedman3a643af2012-01-26 23:11:39 +00004006 // Special-case bitfields of width 1: booleans are naturally 0/1, and
Eli Friedman34ff0622012-02-02 00:40:20 +00004007 // therefore don't strictly fit into a signed bitfield of width 1.
4008 if (FieldWidth == 1 && Value == 1)
Eli Friedman3a643af2012-01-26 23:11:39 +00004009 return false;
4010
John McCall15d7d122010-11-11 03:21:53 +00004011 std::string PrettyValue = Value.toString(10);
4012 std::string PrettyTrunc = TruncatedValue.toString(10);
4013
4014 S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant)
4015 << PrettyValue << PrettyTrunc << OriginalInit->getType()
4016 << Init->getSourceRange();
4017
4018 return true;
4019}
4020
John McCallbeb22aa2010-11-09 23:24:47 +00004021/// Analyze the given simple or compound assignment for warning-worthy
4022/// operations.
Ted Kremenek0692a192012-01-31 05:37:37 +00004023static void AnalyzeAssignment(Sema &S, BinaryOperator *E) {
John McCallbeb22aa2010-11-09 23:24:47 +00004024 // Just recurse on the LHS.
4025 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4026
4027 // We want to recurse on the RHS as normal unless we're assigning to
4028 // a bitfield.
4029 if (FieldDecl *Bitfield = E->getLHS()->getBitField()) {
John McCall15d7d122010-11-11 03:21:53 +00004030 if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(),
4031 E->getOperatorLoc())) {
4032 // Recurse, ignoring any implicit conversions on the RHS.
4033 return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(),
4034 E->getOperatorLoc());
John McCallbeb22aa2010-11-09 23:24:47 +00004035 }
4036 }
4037
4038 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
4039}
4040
John McCall51313c32010-01-04 23:31:57 +00004041/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
Ted Kremenek0692a192012-01-31 05:37:37 +00004042static void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T,
Anna Zaksc36bedc2012-02-01 19:08:57 +00004043 SourceLocation CContext, unsigned diag,
4044 bool pruneControlFlow = false) {
4045 if (pruneControlFlow) {
4046 S.DiagRuntimeBehavior(E->getExprLoc(), E,
4047 S.PDiag(diag)
4048 << SourceType << T << E->getSourceRange()
4049 << SourceRange(CContext));
4050 return;
4051 }
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00004052 S.Diag(E->getExprLoc(), diag)
4053 << SourceType << T << E->getSourceRange() << SourceRange(CContext);
4054}
4055
Chandler Carruthe1b02e02011-04-05 06:47:57 +00004056/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
Ted Kremenek0692a192012-01-31 05:37:37 +00004057static void DiagnoseImpCast(Sema &S, Expr *E, QualType T,
Anna Zaksc36bedc2012-02-01 19:08:57 +00004058 SourceLocation CContext, unsigned diag,
4059 bool pruneControlFlow = false) {
4060 DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow);
Chandler Carruthe1b02e02011-04-05 06:47:57 +00004061}
4062
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00004063/// Diagnose an implicit cast from a literal expression. Does not warn when the
4064/// cast wouldn't lose information.
Chandler Carruthf65076e2011-04-10 08:36:24 +00004065void DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T,
4066 SourceLocation CContext) {
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00004067 // Try to convert the literal exactly to an integer. If we can, don't warn.
Chandler Carruthf65076e2011-04-10 08:36:24 +00004068 bool isExact = false;
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00004069 const llvm::APFloat &Value = FL->getValue();
Jeffrey Yasskin3e1ef782011-07-15 17:03:07 +00004070 llvm::APSInt IntegerValue(S.Context.getIntWidth(T),
4071 T->hasUnsignedIntegerRepresentation());
4072 if (Value.convertToInteger(IntegerValue,
Chandler Carruthf65076e2011-04-10 08:36:24 +00004073 llvm::APFloat::rmTowardZero, &isExact)
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00004074 == llvm::APFloat::opOK && isExact)
Chandler Carruthf65076e2011-04-10 08:36:24 +00004075 return;
4076
Matt Beaumont-Gay9ce63772011-10-14 15:36:25 +00004077 S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer)
4078 << FL->getType() << T << FL->getSourceRange() << SourceRange(CContext);
Chandler Carruthf65076e2011-04-10 08:36:24 +00004079}
4080
John McCall091f23f2010-11-09 22:22:12 +00004081std::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) {
4082 if (!Range.Width) return "0";
4083
4084 llvm::APSInt ValueInRange = Value;
4085 ValueInRange.setIsSigned(!Range.NonNegative);
Jay Foad9f71a8f2010-12-07 08:25:34 +00004086 ValueInRange = ValueInRange.trunc(Range.Width);
John McCall091f23f2010-11-09 22:22:12 +00004087 return ValueInRange.toString(10);
4088}
4089
John McCall323ed742010-05-06 08:58:33 +00004090void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
John McCallb4eb64d2010-10-08 02:01:28 +00004091 SourceLocation CC, bool *ICContext = 0) {
John McCall323ed742010-05-06 08:58:33 +00004092 if (E->isTypeDependent() || E->isValueDependent()) return;
John McCall51313c32010-01-04 23:31:57 +00004093
John McCall323ed742010-05-06 08:58:33 +00004094 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
4095 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
4096 if (Source == Target) return;
4097 if (Target->isDependentType()) return;
John McCall51313c32010-01-04 23:31:57 +00004098
Chandler Carruth108f7562011-07-26 05:40:03 +00004099 // If the conversion context location is invalid don't complain. We also
4100 // don't want to emit a warning if the issue occurs from the expansion of
4101 // a system macro. The problem is that 'getSpellingLoc()' is slow, so we
4102 // delay this check as long as possible. Once we detect we are in that
4103 // scenario, we just return.
Ted Kremenekef9ff882011-03-10 20:03:42 +00004104 if (CC.isInvalid())
John McCallb4eb64d2010-10-08 02:01:28 +00004105 return;
4106
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00004107 // Diagnose implicit casts to bool.
4108 if (Target->isSpecificBuiltinType(BuiltinType::Bool)) {
4109 if (isa<StringLiteral>(E))
4110 // Warn on string literal to bool. Checks for string literals in logical
4111 // expressions, for instances, assert(0 && "error here"), is prevented
4112 // by a check in AnalyzeImplicitConversions().
4113 return DiagnoseImpCast(S, E, T, CC,
4114 diag::warn_impcast_string_literal_to_bool);
Lang Hamese14ca9f2011-12-05 20:49:50 +00004115 if (Source->isFunctionType()) {
4116 // Warn on function to bool. Checks free functions and static member
4117 // functions. Weakly imported functions are excluded from the check,
4118 // since it's common to test their value to check whether the linker
4119 // found a definition for them.
4120 ValueDecl *D = 0;
4121 if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) {
4122 D = R->getDecl();
4123 } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) {
4124 D = M->getMemberDecl();
4125 }
4126
4127 if (D && !D->isWeak()) {
Richard Trieu26b45d82011-12-06 04:48:01 +00004128 if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) {
4129 S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool)
4130 << F << E->getSourceRange() << SourceRange(CC);
David Blaikie2def7732011-12-09 21:42:37 +00004131 S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence)
4132 << FixItHint::CreateInsertion(E->getExprLoc(), "&");
4133 QualType ReturnType;
4134 UnresolvedSet<4> NonTemplateOverloads;
4135 S.isExprCallable(*E, ReturnType, NonTemplateOverloads);
4136 if (!ReturnType.isNull()
4137 && ReturnType->isSpecificBuiltinType(BuiltinType::Bool))
4138 S.Diag(E->getExprLoc(), diag::note_function_to_bool_call)
4139 << FixItHint::CreateInsertion(
4140 S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()");
Richard Trieu26b45d82011-12-06 04:48:01 +00004141 return;
4142 }
Lang Hamese14ca9f2011-12-05 20:49:50 +00004143 }
4144 }
David Blaikiee37cdc42011-09-29 04:06:47 +00004145 return; // Other casts to bool are not checked.
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00004146 }
John McCall51313c32010-01-04 23:31:57 +00004147
4148 // Strip vector types.
4149 if (isa<VectorType>(Source)) {
Ted Kremenekef9ff882011-03-10 20:03:42 +00004150 if (!isa<VectorType>(Target)) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004151 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004152 return;
John McCallb4eb64d2010-10-08 02:01:28 +00004153 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar);
Ted Kremenekef9ff882011-03-10 20:03:42 +00004154 }
Chris Lattnerb792b302011-06-14 04:51:15 +00004155
4156 // If the vector cast is cast between two vectors of the same size, it is
4157 // a bitcast, not a conversion.
4158 if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target))
4159 return;
John McCall51313c32010-01-04 23:31:57 +00004160
4161 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
4162 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
4163 }
4164
4165 // Strip complex types.
4166 if (isa<ComplexType>(Source)) {
Ted Kremenekef9ff882011-03-10 20:03:42 +00004167 if (!isa<ComplexType>(Target)) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004168 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004169 return;
4170
John McCallb4eb64d2010-10-08 02:01:28 +00004171 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar);
Ted Kremenekef9ff882011-03-10 20:03:42 +00004172 }
John McCall51313c32010-01-04 23:31:57 +00004173
4174 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
4175 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
4176 }
4177
4178 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
4179 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
4180
4181 // If the source is floating point...
4182 if (SourceBT && SourceBT->isFloatingPoint()) {
4183 // ...and the target is floating point...
4184 if (TargetBT && TargetBT->isFloatingPoint()) {
4185 // ...then warn if we're dropping FP rank.
4186
4187 // Builtin FP kinds are ordered by increasing FP rank.
4188 if (SourceBT->getKind() > TargetBT->getKind()) {
4189 // Don't warn about float constants that are precisely
4190 // representable in the target type.
4191 Expr::EvalResult result;
Richard Smith51f47082011-10-29 00:50:52 +00004192 if (E->EvaluateAsRValue(result, S.Context)) {
John McCall51313c32010-01-04 23:31:57 +00004193 // Value might be a float, a float vector, or a float complex.
4194 if (IsSameFloatAfterCast(result.Val,
John McCall323ed742010-05-06 08:58:33 +00004195 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
4196 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
John McCall51313c32010-01-04 23:31:57 +00004197 return;
4198 }
4199
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004200 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004201 return;
4202
John McCallb4eb64d2010-10-08 02:01:28 +00004203 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision);
John McCall51313c32010-01-04 23:31:57 +00004204 }
4205 return;
4206 }
4207
Ted Kremenekef9ff882011-03-10 20:03:42 +00004208 // If the target is integral, always warn.
Chandler Carrutha5b93322011-02-17 11:05:49 +00004209 if ((TargetBT && TargetBT->isInteger())) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004210 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004211 return;
4212
Chandler Carrutha5b93322011-02-17 11:05:49 +00004213 Expr *InnerE = E->IgnoreParenImpCasts();
Matt Beaumont-Gay634c8af2011-09-08 22:30:47 +00004214 // We also want to warn on, e.g., "int i = -1.234"
4215 if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE))
4216 if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus)
4217 InnerE = UOp->getSubExpr()->IgnoreParenImpCasts();
4218
Chandler Carruthf65076e2011-04-10 08:36:24 +00004219 if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) {
4220 DiagnoseFloatingLiteralImpCast(S, FL, T, CC);
Chandler Carrutha5b93322011-02-17 11:05:49 +00004221 } else {
4222 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer);
4223 }
4224 }
John McCall51313c32010-01-04 23:31:57 +00004225
4226 return;
4227 }
4228
John McCallf2370c92010-01-06 05:24:50 +00004229 if (!Source->isIntegerType() || !Target->isIntegerType())
John McCall51313c32010-01-04 23:31:57 +00004230 return;
4231
Richard Trieu1838ca52011-05-29 19:59:02 +00004232 if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull)
4233 == Expr::NPCK_GNUNull) && Target->isIntegerType()) {
David Blaikieb1360492012-03-16 20:30:12 +00004234 SourceLocation Loc = E->getSourceRange().getBegin();
4235 if (Loc.isMacroID())
4236 Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first;
4237 S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer)
David Blaikie2c0abf42012-04-30 18:27:22 +00004238 << T << clang::SourceRange(CC)
4239 << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T));
Richard Trieu1838ca52011-05-29 19:59:02 +00004240 return;
4241 }
4242
John McCall323ed742010-05-06 08:58:33 +00004243 IntRange SourceRange = GetExprRange(S.Context, E);
John McCall1844a6e2010-11-10 23:38:19 +00004244 IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target);
John McCallf2370c92010-01-06 05:24:50 +00004245
4246 if (SourceRange.Width > TargetRange.Width) {
John McCall091f23f2010-11-09 22:22:12 +00004247 // If the source is a constant, use a default-on diagnostic.
4248 // TODO: this should happen for bitfield stores, too.
4249 llvm::APSInt Value(32);
4250 if (E->isIntegerConstantExpr(Value, S.Context)) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004251 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004252 return;
4253
John McCall091f23f2010-11-09 22:22:12 +00004254 std::string PrettySourceValue = Value.toString(10);
4255 std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
4256
Ted Kremenek5e745da2011-10-22 02:37:33 +00004257 S.DiagRuntimeBehavior(E->getExprLoc(), E,
4258 S.PDiag(diag::warn_impcast_integer_precision_constant)
4259 << PrettySourceValue << PrettyTargetValue
4260 << E->getType() << T << E->getSourceRange()
4261 << clang::SourceRange(CC));
John McCall091f23f2010-11-09 22:22:12 +00004262 return;
4263 }
4264
Chris Lattnerb792b302011-06-14 04:51:15 +00004265 // People want to build with -Wshorten-64-to-32 and not -Wconversion.
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004266 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004267 return;
4268
David Blaikie37050842012-04-12 22:40:54 +00004269 if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64)
Anna Zaksc36bedc2012-02-01 19:08:57 +00004270 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32,
4271 /* pruneControlFlow */ true);
John McCallb4eb64d2010-10-08 02:01:28 +00004272 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision);
John McCall323ed742010-05-06 08:58:33 +00004273 }
4274
4275 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
4276 (!TargetRange.NonNegative && SourceRange.NonNegative &&
4277 SourceRange.Width == TargetRange.Width)) {
Ted Kremenekef9ff882011-03-10 20:03:42 +00004278
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004279 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004280 return;
4281
John McCall323ed742010-05-06 08:58:33 +00004282 unsigned DiagID = diag::warn_impcast_integer_sign;
4283
4284 // Traditionally, gcc has warned about this under -Wsign-compare.
4285 // We also want to warn about it in -Wconversion.
4286 // So if -Wconversion is off, use a completely identical diagnostic
4287 // in the sign-compare group.
4288 // The conditional-checking code will
4289 if (ICContext) {
4290 DiagID = diag::warn_impcast_integer_sign_conditional;
4291 *ICContext = true;
4292 }
4293
John McCallb4eb64d2010-10-08 02:01:28 +00004294 return DiagnoseImpCast(S, E, T, CC, DiagID);
John McCall51313c32010-01-04 23:31:57 +00004295 }
4296
Douglas Gregor284cc8d2011-02-22 02:45:07 +00004297 // Diagnose conversions between different enumeration types.
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00004298 // In C, we pretend that the type of an EnumConstantDecl is its enumeration
4299 // type, to give us better diagnostics.
4300 QualType SourceType = E->getType();
David Blaikie4e4d0842012-03-11 07:00:24 +00004301 if (!S.getLangOpts().CPlusPlus) {
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00004302 if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
4303 if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) {
4304 EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext());
4305 SourceType = S.Context.getTypeDeclType(Enum);
4306 Source = S.Context.getCanonicalType(SourceType).getTypePtr();
4307 }
4308 }
4309
Douglas Gregor284cc8d2011-02-22 02:45:07 +00004310 if (const EnumType *SourceEnum = Source->getAs<EnumType>())
4311 if (const EnumType *TargetEnum = Target->getAs<EnumType>())
4312 if ((SourceEnum->getDecl()->getIdentifier() ||
Richard Smith162e1c12011-04-15 14:24:37 +00004313 SourceEnum->getDecl()->getTypedefNameForAnonDecl()) &&
Douglas Gregor284cc8d2011-02-22 02:45:07 +00004314 (TargetEnum->getDecl()->getIdentifier() ||
Richard Smith162e1c12011-04-15 14:24:37 +00004315 TargetEnum->getDecl()->getTypedefNameForAnonDecl()) &&
Ted Kremenekef9ff882011-03-10 20:03:42 +00004316 SourceEnum != TargetEnum) {
Matt Beaumont-Gayd87a0cd2012-01-06 22:43:58 +00004317 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenekef9ff882011-03-10 20:03:42 +00004318 return;
4319
Douglas Gregor5a5b38f2011-03-12 00:14:31 +00004320 return DiagnoseImpCast(S, E, SourceType, T, CC,
Douglas Gregor284cc8d2011-02-22 02:45:07 +00004321 diag::warn_impcast_different_enum_types);
Ted Kremenekef9ff882011-03-10 20:03:42 +00004322 }
Douglas Gregor284cc8d2011-02-22 02:45:07 +00004323
John McCall51313c32010-01-04 23:31:57 +00004324 return;
4325}
4326
John McCall323ed742010-05-06 08:58:33 +00004327void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T);
4328
4329void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
John McCallb4eb64d2010-10-08 02:01:28 +00004330 SourceLocation CC, bool &ICContext) {
John McCall323ed742010-05-06 08:58:33 +00004331 E = E->IgnoreParenImpCasts();
4332
4333 if (isa<ConditionalOperator>(E))
4334 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T);
4335
John McCallb4eb64d2010-10-08 02:01:28 +00004336 AnalyzeImplicitConversions(S, E, CC);
John McCall323ed742010-05-06 08:58:33 +00004337 if (E->getType() != T)
John McCallb4eb64d2010-10-08 02:01:28 +00004338 return CheckImplicitConversion(S, E, T, CC, &ICContext);
John McCall323ed742010-05-06 08:58:33 +00004339 return;
4340}
4341
4342void CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) {
John McCallb4eb64d2010-10-08 02:01:28 +00004343 SourceLocation CC = E->getQuestionLoc();
4344
4345 AnalyzeImplicitConversions(S, E->getCond(), CC);
John McCall323ed742010-05-06 08:58:33 +00004346
4347 bool Suspicious = false;
John McCallb4eb64d2010-10-08 02:01:28 +00004348 CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious);
4349 CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious);
John McCall323ed742010-05-06 08:58:33 +00004350
4351 // If -Wconversion would have warned about either of the candidates
4352 // for a signedness conversion to the context type...
4353 if (!Suspicious) return;
4354
4355 // ...but it's currently ignored...
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00004356 if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional,
4357 CC))
John McCall323ed742010-05-06 08:58:33 +00004358 return;
4359
John McCall323ed742010-05-06 08:58:33 +00004360 // ...then check whether it would have warned about either of the
4361 // candidates for a signedness conversion to the condition type.
Richard Trieu52541612011-07-21 02:46:28 +00004362 if (E->getType() == T) return;
4363
4364 Suspicious = false;
4365 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
4366 E->getType(), CC, &Suspicious);
4367 if (!Suspicious)
4368 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
John McCallb4eb64d2010-10-08 02:01:28 +00004369 E->getType(), CC, &Suspicious);
John McCall323ed742010-05-06 08:58:33 +00004370}
4371
4372/// AnalyzeImplicitConversions - Find and report any interesting
4373/// implicit conversions in the given expression. There are a couple
4374/// of competing diagnostics here, -Wconversion and -Wsign-compare.
John McCallb4eb64d2010-10-08 02:01:28 +00004375void AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) {
John McCall323ed742010-05-06 08:58:33 +00004376 QualType T = OrigE->getType();
4377 Expr *E = OrigE->IgnoreParenImpCasts();
4378
Douglas Gregorf8b6e152011-10-10 17:38:18 +00004379 if (E->isTypeDependent() || E->isValueDependent())
4380 return;
4381
John McCall323ed742010-05-06 08:58:33 +00004382 // For conditional operators, we analyze the arguments as if they
4383 // were being fed directly into the output.
4384 if (isa<ConditionalOperator>(E)) {
4385 ConditionalOperator *CO = cast<ConditionalOperator>(E);
4386 CheckConditionalOperator(S, CO, T);
4387 return;
4388 }
4389
4390 // Go ahead and check any implicit conversions we might have skipped.
4391 // The non-canonical typecheck is just an optimization;
4392 // CheckImplicitConversion will filter out dead implicit conversions.
4393 if (E->getType() != T)
John McCallb4eb64d2010-10-08 02:01:28 +00004394 CheckImplicitConversion(S, E, T, CC);
John McCall323ed742010-05-06 08:58:33 +00004395
4396 // Now continue drilling into this expression.
4397
4398 // Skip past explicit casts.
4399 if (isa<ExplicitCastExpr>(E)) {
4400 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
John McCallb4eb64d2010-10-08 02:01:28 +00004401 return AnalyzeImplicitConversions(S, E, CC);
John McCall323ed742010-05-06 08:58:33 +00004402 }
4403
John McCallbeb22aa2010-11-09 23:24:47 +00004404 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
4405 // Do a somewhat different check with comparison operators.
4406 if (BO->isComparisonOp())
4407 return AnalyzeComparison(S, BO);
4408
Eli Friedman0fa06382012-01-26 23:34:06 +00004409 // And with simple assignments.
4410 if (BO->getOpcode() == BO_Assign)
John McCallbeb22aa2010-11-09 23:24:47 +00004411 return AnalyzeAssignment(S, BO);
4412 }
John McCall323ed742010-05-06 08:58:33 +00004413
4414 // These break the otherwise-useful invariant below. Fortunately,
4415 // we don't really need to recurse into them, because any internal
4416 // expressions should have been analyzed already when they were
4417 // built into statements.
4418 if (isa<StmtExpr>(E)) return;
4419
4420 // Don't descend into unevaluated contexts.
Peter Collingbournef4e3cfb2011-03-11 19:24:49 +00004421 if (isa<UnaryExprOrTypeTraitExpr>(E)) return;
John McCall323ed742010-05-06 08:58:33 +00004422
4423 // Now just recurse over the expression's children.
John McCallb4eb64d2010-10-08 02:01:28 +00004424 CC = E->getExprLoc();
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00004425 BinaryOperator *BO = dyn_cast<BinaryOperator>(E);
4426 bool IsLogicalOperator = BO && BO->isLogicalOp();
4427 for (Stmt::child_range I = E->children(); I; ++I) {
Douglas Gregor54042f12012-02-09 10:18:50 +00004428 Expr *ChildExpr = dyn_cast_or_null<Expr>(*I);
Douglas Gregor503384f2012-02-09 00:47:04 +00004429 if (!ChildExpr)
4430 continue;
4431
Richard Trieuf1f8b1a2011-09-23 20:10:00 +00004432 if (IsLogicalOperator &&
4433 isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts()))
4434 // Ignore checking string literals that are in logical operators.
4435 continue;
4436 AnalyzeImplicitConversions(S, ChildExpr, CC);
4437 }
John McCall323ed742010-05-06 08:58:33 +00004438}
4439
4440} // end anonymous namespace
4441
4442/// Diagnoses "dangerous" implicit conversions within the given
4443/// expression (which is a full expression). Implements -Wconversion
4444/// and -Wsign-compare.
John McCallb4eb64d2010-10-08 02:01:28 +00004445///
4446/// \param CC the "context" location of the implicit conversion, i.e.
4447/// the most location of the syntactic entity requiring the implicit
4448/// conversion
4449void Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) {
John McCall323ed742010-05-06 08:58:33 +00004450 // Don't diagnose in unevaluated contexts.
4451 if (ExprEvalContexts.back().Context == Sema::Unevaluated)
4452 return;
4453
4454 // Don't diagnose for value- or type-dependent expressions.
4455 if (E->isTypeDependent() || E->isValueDependent())
4456 return;
4457
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004458 // Check for array bounds violations in cases where the check isn't triggered
4459 // elsewhere for other Expr types (like BinaryOperators), e.g. when an
4460 // ArraySubscriptExpr is on the RHS of a variable initialization.
4461 CheckArrayAccess(E);
4462
John McCallb4eb64d2010-10-08 02:01:28 +00004463 // This is not the right CC for (e.g.) a variable initialization.
4464 AnalyzeImplicitConversions(*this, E, CC);
John McCall323ed742010-05-06 08:58:33 +00004465}
4466
John McCall15d7d122010-11-11 03:21:53 +00004467void Sema::CheckBitFieldInitialization(SourceLocation InitLoc,
4468 FieldDecl *BitField,
4469 Expr *Init) {
4470 (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc);
4471}
4472
Mike Stumpf8c49212010-01-21 03:59:47 +00004473/// CheckParmsForFunctionDef - Check that the parameters of the given
4474/// function are appropriate for the definition of a function. This
4475/// takes care of any checks that cannot be performed on the
4476/// declaration itself, e.g., that the types of each of the function
4477/// parameters are complete.
Douglas Gregor82aa7132010-11-01 18:37:59 +00004478bool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd,
4479 bool CheckParameterNames) {
Mike Stumpf8c49212010-01-21 03:59:47 +00004480 bool HasInvalidParm = false;
Douglas Gregor82aa7132010-11-01 18:37:59 +00004481 for (; P != PEnd; ++P) {
4482 ParmVarDecl *Param = *P;
4483
Mike Stumpf8c49212010-01-21 03:59:47 +00004484 // C99 6.7.5.3p4: the parameters in a parameter type list in a
4485 // function declarator that is part of a function definition of
4486 // that function shall not have incomplete type.
4487 //
4488 // This is also C++ [dcl.fct]p6.
4489 if (!Param->isInvalidDecl() &&
4490 RequireCompleteType(Param->getLocation(), Param->getType(),
Douglas Gregord10099e2012-05-04 16:32:21 +00004491 diag::err_typecheck_decl_incomplete_type)) {
Mike Stumpf8c49212010-01-21 03:59:47 +00004492 Param->setInvalidDecl();
4493 HasInvalidParm = true;
4494 }
4495
4496 // C99 6.9.1p5: If the declarator includes a parameter type list, the
4497 // declaration of each parameter shall include an identifier.
Douglas Gregor82aa7132010-11-01 18:37:59 +00004498 if (CheckParameterNames &&
4499 Param->getIdentifier() == 0 &&
Mike Stumpf8c49212010-01-21 03:59:47 +00004500 !Param->isImplicit() &&
David Blaikie4e4d0842012-03-11 07:00:24 +00004501 !getLangOpts().CPlusPlus)
Mike Stumpf8c49212010-01-21 03:59:47 +00004502 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
Sam Weinigd17e3402010-02-01 05:02:49 +00004503
4504 // C99 6.7.5.3p12:
4505 // If the function declarator is not part of a definition of that
4506 // function, parameters may have incomplete type and may use the [*]
4507 // notation in their sequences of declarator specifiers to specify
4508 // variable length array types.
4509 QualType PType = Param->getOriginalType();
4510 if (const ArrayType *AT = Context.getAsArrayType(PType)) {
4511 if (AT->getSizeModifier() == ArrayType::Star) {
4512 // FIXME: This diagnosic should point the the '[*]' if source-location
4513 // information is added for it.
4514 Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
4515 }
4516 }
Mike Stumpf8c49212010-01-21 03:59:47 +00004517 }
4518
4519 return HasInvalidParm;
4520}
John McCallb7f4ffe2010-08-12 21:44:57 +00004521
4522/// CheckCastAlign - Implements -Wcast-align, which warns when a
4523/// pointer cast increases the alignment requirements.
4524void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
4525 // This is actually a lot of work to potentially be doing on every
4526 // cast; don't do it if we're ignoring -Wcast_align (as is the default).
Argyrios Kyrtzidis08274082010-12-15 18:44:22 +00004527 if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align,
4528 TRange.getBegin())
David Blaikied6471f72011-09-25 23:23:43 +00004529 == DiagnosticsEngine::Ignored)
John McCallb7f4ffe2010-08-12 21:44:57 +00004530 return;
4531
4532 // Ignore dependent types.
4533 if (T->isDependentType() || Op->getType()->isDependentType())
4534 return;
4535
4536 // Require that the destination be a pointer type.
4537 const PointerType *DestPtr = T->getAs<PointerType>();
4538 if (!DestPtr) return;
4539
4540 // If the destination has alignment 1, we're done.
4541 QualType DestPointee = DestPtr->getPointeeType();
4542 if (DestPointee->isIncompleteType()) return;
4543 CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
4544 if (DestAlign.isOne()) return;
4545
4546 // Require that the source be a pointer type.
4547 const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
4548 if (!SrcPtr) return;
4549 QualType SrcPointee = SrcPtr->getPointeeType();
4550
4551 // Whitelist casts from cv void*. We already implicitly
4552 // whitelisted casts to cv void*, since they have alignment 1.
4553 // Also whitelist casts involving incomplete types, which implicitly
4554 // includes 'void'.
4555 if (SrcPointee->isIncompleteType()) return;
4556
4557 CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
4558 if (SrcAlign >= DestAlign) return;
4559
4560 Diag(TRange.getBegin(), diag::warn_cast_align)
4561 << Op->getType() << T
4562 << static_cast<unsigned>(SrcAlign.getQuantity())
4563 << static_cast<unsigned>(DestAlign.getQuantity())
4564 << TRange << Op->getSourceRange();
4565}
4566
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004567static const Type* getElementType(const Expr *BaseExpr) {
4568 const Type* EltType = BaseExpr->getType().getTypePtr();
4569 if (EltType->isAnyPointerType())
4570 return EltType->getPointeeType().getTypePtr();
4571 else if (EltType->isArrayType())
4572 return EltType->getBaseElementTypeUnsafe();
4573 return EltType;
4574}
4575
Chandler Carruthc2684342011-08-05 09:10:50 +00004576/// \brief Check whether this array fits the idiom of a size-one tail padded
4577/// array member of a struct.
4578///
4579/// We avoid emitting out-of-bounds access warnings for such arrays as they are
4580/// commonly used to emulate flexible arrays in C89 code.
4581static bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size,
4582 const NamedDecl *ND) {
4583 if (Size != 1 || !ND) return false;
4584
4585 const FieldDecl *FD = dyn_cast<FieldDecl>(ND);
4586 if (!FD) return false;
4587
4588 // Don't consider sizes resulting from macro expansions or template argument
4589 // substitution to form C89 tail-padded arrays.
Sean Callanand2cf3482012-05-04 18:22:53 +00004590
4591 TypeSourceInfo *TInfo = FD->getTypeSourceInfo();
4592 if (TInfo) {
4593 ConstantArrayTypeLoc TL =
4594 cast<ConstantArrayTypeLoc>(TInfo->getTypeLoc());
4595 const Expr *SizeExpr = dyn_cast<IntegerLiteral>(TL.getSizeExpr());
4596 if (!SizeExpr || SizeExpr->getExprLoc().isMacroID())
4597 return false;
4598 }
Chandler Carruthc2684342011-08-05 09:10:50 +00004599
4600 const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext());
Matt Beaumont-Gay381711c2011-11-29 22:43:53 +00004601 if (!RD) return false;
4602 if (RD->isUnion()) return false;
4603 if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) {
4604 if (!CRD->isStandardLayout()) return false;
4605 }
Chandler Carruthc2684342011-08-05 09:10:50 +00004606
Benjamin Kramer22d4fed2011-08-06 03:04:42 +00004607 // See if this is the last field decl in the record.
4608 const Decl *D = FD;
4609 while ((D = D->getNextDeclInContext()))
4610 if (isa<FieldDecl>(D))
4611 return false;
4612 return true;
Chandler Carruthc2684342011-08-05 09:10:50 +00004613}
4614
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004615void Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004616 const ArraySubscriptExpr *ASE,
Richard Smith25b009a2011-12-16 19:31:14 +00004617 bool AllowOnePastEnd, bool IndexNegated) {
Eli Friedman92b670e2012-02-27 21:21:40 +00004618 IndexExpr = IndexExpr->IgnoreParenImpCasts();
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004619 if (IndexExpr->isValueDependent())
4620 return;
4621
Matt Beaumont-Gay8ef8f432011-12-12 22:35:02 +00004622 const Type *EffectiveType = getElementType(BaseExpr);
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004623 BaseExpr = BaseExpr->IgnoreParenCasts();
Chandler Carruth34064582011-02-17 20:55:08 +00004624 const ConstantArrayType *ArrayTy =
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004625 Context.getAsConstantArrayType(BaseExpr->getType());
Chandler Carruth34064582011-02-17 20:55:08 +00004626 if (!ArrayTy)
Ted Kremeneka0125d82011-02-16 01:57:07 +00004627 return;
Chandler Carruth35001ca2011-02-17 21:10:52 +00004628
Chandler Carruth34064582011-02-17 20:55:08 +00004629 llvm::APSInt index;
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004630 if (!IndexExpr->EvaluateAsInt(index, Context))
Ted Kremeneka0125d82011-02-16 01:57:07 +00004631 return;
Richard Smith25b009a2011-12-16 19:31:14 +00004632 if (IndexNegated)
4633 index = -index;
Ted Kremenek8fd0a5d2011-02-16 04:01:44 +00004634
Chandler Carruthba447122011-08-05 08:07:29 +00004635 const NamedDecl *ND = NULL;
Chandler Carruthba447122011-08-05 08:07:29 +00004636 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
4637 ND = dyn_cast<NamedDecl>(DRE->getDecl());
Chandler Carruthc2684342011-08-05 09:10:50 +00004638 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
Chandler Carruthba447122011-08-05 08:07:29 +00004639 ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
Chandler Carruthba447122011-08-05 08:07:29 +00004640
Ted Kremenek9e060ca2011-02-23 23:06:04 +00004641 if (index.isUnsigned() || !index.isNegative()) {
Ted Kremenek25b3b842011-02-18 02:27:00 +00004642 llvm::APInt size = ArrayTy->getSize();
Chandler Carruth35001ca2011-02-17 21:10:52 +00004643 if (!size.isStrictlyPositive())
4644 return;
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004645
4646 const Type* BaseType = getElementType(BaseExpr);
Nico Weberde5998f2011-09-17 22:59:41 +00004647 if (BaseType != EffectiveType) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004648 // Make sure we're comparing apples to apples when comparing index to size
4649 uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
4650 uint64_t array_typesize = Context.getTypeSize(BaseType);
Kaelyn Uhraind10f4bc2011-08-10 19:47:25 +00004651 // Handle ptrarith_typesize being zero, such as when casting to void*
Kaelyn Uhrain18f16972011-08-10 18:49:28 +00004652 if (!ptrarith_typesize) ptrarith_typesize = 1;
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004653 if (ptrarith_typesize != array_typesize) {
4654 // There's a cast to a different size type involved
4655 uint64_t ratio = array_typesize / ptrarith_typesize;
4656 // TODO: Be smarter about handling cases where array_typesize is not a
4657 // multiple of ptrarith_typesize
4658 if (ptrarith_typesize * ratio == array_typesize)
4659 size *= llvm::APInt(size.getBitWidth(), ratio);
4660 }
4661 }
4662
Chandler Carruth34064582011-02-17 20:55:08 +00004663 if (size.getBitWidth() > index.getBitWidth())
Eli Friedman92b670e2012-02-27 21:21:40 +00004664 index = index.zext(size.getBitWidth());
Ted Kremenek25b3b842011-02-18 02:27:00 +00004665 else if (size.getBitWidth() < index.getBitWidth())
Eli Friedman92b670e2012-02-27 21:21:40 +00004666 size = size.zext(index.getBitWidth());
Ted Kremenek25b3b842011-02-18 02:27:00 +00004667
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004668 // For array subscripting the index must be less than size, but for pointer
4669 // arithmetic also allow the index (offset) to be equal to size since
4670 // computing the next address after the end of the array is legal and
4671 // commonly done e.g. in C++ iterators and range-based for loops.
Eli Friedman92b670e2012-02-27 21:21:40 +00004672 if (AllowOnePastEnd ? index.ule(size) : index.ult(size))
Chandler Carruthba447122011-08-05 08:07:29 +00004673 return;
4674
4675 // Also don't warn for arrays of size 1 which are members of some
4676 // structure. These are often used to approximate flexible arrays in C89
4677 // code.
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004678 if (IsTailPaddedMemberArray(*this, size, ND))
Ted Kremenek8fd0a5d2011-02-16 04:01:44 +00004679 return;
Chandler Carruth34064582011-02-17 20:55:08 +00004680
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004681 // Suppress the warning if the subscript expression (as identified by the
4682 // ']' location) and the index expression are both from macro expansions
4683 // within a system header.
4684 if (ASE) {
4685 SourceLocation RBracketLoc = SourceMgr.getSpellingLoc(
4686 ASE->getRBracketLoc());
4687 if (SourceMgr.isInSystemHeader(RBracketLoc)) {
4688 SourceLocation IndexLoc = SourceMgr.getSpellingLoc(
4689 IndexExpr->getLocStart());
4690 if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc))
4691 return;
4692 }
4693 }
4694
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004695 unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds;
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004696 if (ASE)
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004697 DiagID = diag::warn_array_index_exceeds_bounds;
4698
4699 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
4700 PDiag(DiagID) << index.toString(10, true)
4701 << size.toString(10, true)
4702 << (unsigned)size.getLimitedValue(~0U)
4703 << IndexExpr->getSourceRange());
Chandler Carruth34064582011-02-17 20:55:08 +00004704 } else {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004705 unsigned DiagID = diag::warn_array_index_precedes_bounds;
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004706 if (!ASE) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004707 DiagID = diag::warn_ptr_arith_precedes_bounds;
4708 if (index.isNegative()) index = -index;
4709 }
4710
4711 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
4712 PDiag(DiagID) << index.toString(10, true)
4713 << IndexExpr->getSourceRange());
Ted Kremeneka0125d82011-02-16 01:57:07 +00004714 }
Chandler Carruth35001ca2011-02-17 21:10:52 +00004715
Matt Beaumont-Gaycfbc5b52011-11-29 19:27:11 +00004716 if (!ND) {
4717 // Try harder to find a NamedDecl to point at in the note.
4718 while (const ArraySubscriptExpr *ASE =
4719 dyn_cast<ArraySubscriptExpr>(BaseExpr))
4720 BaseExpr = ASE->getBase()->IgnoreParenCasts();
4721 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
4722 ND = dyn_cast<NamedDecl>(DRE->getDecl());
4723 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
4724 ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
4725 }
4726
Chandler Carruth35001ca2011-02-17 21:10:52 +00004727 if (ND)
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004728 DiagRuntimeBehavior(ND->getLocStart(), BaseExpr,
4729 PDiag(diag::note_array_index_out_of_bounds)
4730 << ND->getDeclName());
Ted Kremeneka0125d82011-02-16 01:57:07 +00004731}
4732
Ted Kremenek3aea4da2011-03-01 18:41:00 +00004733void Sema::CheckArrayAccess(const Expr *expr) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004734 int AllowOnePastEnd = 0;
4735 while (expr) {
4736 expr = expr->IgnoreParenImpCasts();
Ted Kremenek3aea4da2011-03-01 18:41:00 +00004737 switch (expr->getStmtClass()) {
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004738 case Stmt::ArraySubscriptExprClass: {
4739 const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr);
Matt Beaumont-Gay80fb7dd2011-12-14 16:02:15 +00004740 CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE,
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004741 AllowOnePastEnd > 0);
Ted Kremenek3aea4da2011-03-01 18:41:00 +00004742 return;
Kaelyn Uhraind6c88652011-08-05 23:18:04 +00004743 }
4744 case Stmt::UnaryOperatorClass: {
4745 // Only unwrap the * and & unary operators
4746 const UnaryOperator *UO = cast<UnaryOperator>(expr);
4747 expr = UO->getSubExpr();
4748 switch (UO->getOpcode()) {
4749 case UO_AddrOf:
4750 AllowOnePastEnd++;
4751 break;
4752 case UO_Deref:
4753 AllowOnePastEnd--;
4754 break;
4755 default:
4756 return;
4757 }
4758 break;
4759 }
Ted Kremenek3aea4da2011-03-01 18:41:00 +00004760 case Stmt::ConditionalOperatorClass: {
4761 const ConditionalOperator *cond = cast<ConditionalOperator>(expr);
4762 if (const Expr *lhs = cond->getLHS())
4763 CheckArrayAccess(lhs);
4764 if (const Expr *rhs = cond->getRHS())
4765 CheckArrayAccess(rhs);
4766 return;
4767 }
4768 default:
4769 return;
4770 }
Peter Collingbournef111d932011-04-15 00:35:48 +00004771 }
Ted Kremenek3aea4da2011-03-01 18:41:00 +00004772}
John McCallf85e1932011-06-15 23:02:42 +00004773
4774//===--- CHECK: Objective-C retain cycles ----------------------------------//
4775
4776namespace {
4777 struct RetainCycleOwner {
4778 RetainCycleOwner() : Variable(0), Indirect(false) {}
4779 VarDecl *Variable;
4780 SourceRange Range;
4781 SourceLocation Loc;
4782 bool Indirect;
4783
4784 void setLocsFrom(Expr *e) {
4785 Loc = e->getExprLoc();
4786 Range = e->getSourceRange();
4787 }
4788 };
4789}
4790
4791/// Consider whether capturing the given variable can possibly lead to
4792/// a retain cycle.
4793static bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) {
4794 // In ARC, it's captured strongly iff the variable has __strong
4795 // lifetime. In MRR, it's captured strongly if the variable is
4796 // __block and has an appropriate type.
4797 if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
4798 return false;
4799
4800 owner.Variable = var;
4801 owner.setLocsFrom(ref);
4802 return true;
4803}
4804
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00004805static bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) {
John McCallf85e1932011-06-15 23:02:42 +00004806 while (true) {
4807 e = e->IgnoreParens();
4808 if (CastExpr *cast = dyn_cast<CastExpr>(e)) {
4809 switch (cast->getCastKind()) {
4810 case CK_BitCast:
4811 case CK_LValueBitCast:
4812 case CK_LValueToRValue:
John McCall33e56f32011-09-10 06:18:15 +00004813 case CK_ARCReclaimReturnedObject:
John McCallf85e1932011-06-15 23:02:42 +00004814 e = cast->getSubExpr();
4815 continue;
4816
John McCallf85e1932011-06-15 23:02:42 +00004817 default:
4818 return false;
4819 }
4820 }
4821
4822 if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) {
4823 ObjCIvarDecl *ivar = ref->getDecl();
4824 if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
4825 return false;
4826
4827 // Try to find a retain cycle in the base.
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00004828 if (!findRetainCycleOwner(S, ref->getBase(), owner))
John McCallf85e1932011-06-15 23:02:42 +00004829 return false;
4830
4831 if (ref->isFreeIvar()) owner.setLocsFrom(ref);
4832 owner.Indirect = true;
4833 return true;
4834 }
4835
4836 if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) {
4837 VarDecl *var = dyn_cast<VarDecl>(ref->getDecl());
4838 if (!var) return false;
4839 return considerVariable(var, ref, owner);
4840 }
4841
John McCallf85e1932011-06-15 23:02:42 +00004842 if (MemberExpr *member = dyn_cast<MemberExpr>(e)) {
4843 if (member->isArrow()) return false;
4844
4845 // Don't count this as an indirect ownership.
4846 e = member->getBase();
4847 continue;
4848 }
4849
John McCall4b9c2d22011-11-06 09:01:30 +00004850 if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) {
4851 // Only pay attention to pseudo-objects on property references.
4852 ObjCPropertyRefExpr *pre
4853 = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm()
4854 ->IgnoreParens());
4855 if (!pre) return false;
4856 if (pre->isImplicitProperty()) return false;
4857 ObjCPropertyDecl *property = pre->getExplicitProperty();
4858 if (!property->isRetaining() &&
4859 !(property->getPropertyIvarDecl() &&
4860 property->getPropertyIvarDecl()->getType()
4861 .getObjCLifetime() == Qualifiers::OCL_Strong))
4862 return false;
4863
4864 owner.Indirect = true;
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00004865 if (pre->isSuperReceiver()) {
4866 owner.Variable = S.getCurMethodDecl()->getSelfDecl();
4867 if (!owner.Variable)
4868 return false;
4869 owner.Loc = pre->getLocation();
4870 owner.Range = pre->getSourceRange();
4871 return true;
4872 }
John McCall4b9c2d22011-11-06 09:01:30 +00004873 e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase())
4874 ->getSourceExpr());
4875 continue;
4876 }
4877
John McCallf85e1932011-06-15 23:02:42 +00004878 // Array ivars?
4879
4880 return false;
4881 }
4882}
4883
4884namespace {
4885 struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> {
4886 FindCaptureVisitor(ASTContext &Context, VarDecl *variable)
4887 : EvaluatedExprVisitor<FindCaptureVisitor>(Context),
4888 Variable(variable), Capturer(0) {}
4889
4890 VarDecl *Variable;
4891 Expr *Capturer;
4892
4893 void VisitDeclRefExpr(DeclRefExpr *ref) {
4894 if (ref->getDecl() == Variable && !Capturer)
4895 Capturer = ref;
4896 }
4897
John McCallf85e1932011-06-15 23:02:42 +00004898 void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) {
4899 if (Capturer) return;
4900 Visit(ref->getBase());
4901 if (Capturer && ref->isFreeIvar())
4902 Capturer = ref;
4903 }
4904
4905 void VisitBlockExpr(BlockExpr *block) {
4906 // Look inside nested blocks
4907 if (block->getBlockDecl()->capturesVariable(Variable))
4908 Visit(block->getBlockDecl()->getBody());
4909 }
4910 };
4911}
4912
4913/// Check whether the given argument is a block which captures a
4914/// variable.
4915static Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) {
4916 assert(owner.Variable && owner.Loc.isValid());
4917
4918 e = e->IgnoreParenCasts();
4919 BlockExpr *block = dyn_cast<BlockExpr>(e);
4920 if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable))
4921 return 0;
4922
4923 FindCaptureVisitor visitor(S.Context, owner.Variable);
4924 visitor.Visit(block->getBlockDecl()->getBody());
4925 return visitor.Capturer;
4926}
4927
4928static void diagnoseRetainCycle(Sema &S, Expr *capturer,
4929 RetainCycleOwner &owner) {
4930 assert(capturer);
4931 assert(owner.Variable && owner.Loc.isValid());
4932
4933 S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle)
4934 << owner.Variable << capturer->getSourceRange();
4935 S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner)
4936 << owner.Indirect << owner.Range;
4937}
4938
4939/// Check for a keyword selector that starts with the word 'add' or
4940/// 'set'.
4941static bool isSetterLikeSelector(Selector sel) {
4942 if (sel.isUnarySelector()) return false;
4943
Chris Lattner5f9e2722011-07-23 10:55:15 +00004944 StringRef str = sel.getNameForSlot(0);
John McCallf85e1932011-06-15 23:02:42 +00004945 while (!str.empty() && str.front() == '_') str = str.substr(1);
Ted Kremenek968a0ee2011-12-01 00:59:21 +00004946 if (str.startswith("set"))
John McCallf85e1932011-06-15 23:02:42 +00004947 str = str.substr(3);
Ted Kremenek968a0ee2011-12-01 00:59:21 +00004948 else if (str.startswith("add")) {
4949 // Specially whitelist 'addOperationWithBlock:'.
4950 if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock"))
4951 return false;
4952 str = str.substr(3);
4953 }
John McCallf85e1932011-06-15 23:02:42 +00004954 else
4955 return false;
4956
4957 if (str.empty()) return true;
4958 return !islower(str.front());
4959}
4960
4961/// Check a message send to see if it's likely to cause a retain cycle.
4962void Sema::checkRetainCycles(ObjCMessageExpr *msg) {
4963 // Only check instance methods whose selector looks like a setter.
4964 if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector()))
4965 return;
4966
4967 // Try to find a variable that the receiver is strongly owned by.
4968 RetainCycleOwner owner;
4969 if (msg->getReceiverKind() == ObjCMessageExpr::Instance) {
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00004970 if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner))
John McCallf85e1932011-06-15 23:02:42 +00004971 return;
4972 } else {
4973 assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance);
4974 owner.Variable = getCurMethodDecl()->getSelfDecl();
4975 owner.Loc = msg->getSuperLoc();
4976 owner.Range = msg->getSuperLoc();
4977 }
4978
4979 // Check whether the receiver is captured by any of the arguments.
4980 for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i)
4981 if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
4982 return diagnoseRetainCycle(*this, capturer, owner);
4983}
4984
4985/// Check a property assign to see if it's likely to cause a retain cycle.
4986void Sema::checkRetainCycles(Expr *receiver, Expr *argument) {
4987 RetainCycleOwner owner;
Fariborz Jahanian6e6f93a2012-01-10 19:28:26 +00004988 if (!findRetainCycleOwner(*this, receiver, owner))
John McCallf85e1932011-06-15 23:02:42 +00004989 return;
4990
4991 if (Expr *capturer = findCapturingExpr(*this, argument, owner))
4992 diagnoseRetainCycle(*this, capturer, owner);
4993}
4994
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004995bool Sema::checkUnsafeAssigns(SourceLocation Loc,
John McCallf85e1932011-06-15 23:02:42 +00004996 QualType LHS, Expr *RHS) {
4997 Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime();
4998 if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone)
Fariborz Jahanian921c1432011-06-24 18:25:34 +00004999 return false;
5000 // strip off any implicit cast added to get to the one arc-specific
5001 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
John McCall33e56f32011-09-10 06:18:15 +00005002 if (cast->getCastKind() == CK_ARCConsumeObject) {
John McCallf85e1932011-06-15 23:02:42 +00005003 Diag(Loc, diag::warn_arc_retained_assign)
5004 << (LT == Qualifiers::OCL_ExplicitNone)
5005 << RHS->getSourceRange();
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005006 return true;
5007 }
5008 RHS = cast->getSubExpr();
5009 }
5010 return false;
John McCallf85e1932011-06-15 23:02:42 +00005011}
5012
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005013void Sema::checkUnsafeExprAssigns(SourceLocation Loc,
5014 Expr *LHS, Expr *RHS) {
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00005015 QualType LHSType;
5016 // PropertyRef on LHS type need be directly obtained from
5017 // its declaration as it has a PsuedoType.
5018 ObjCPropertyRefExpr *PRE
5019 = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens());
5020 if (PRE && !PRE->isImplicitProperty()) {
5021 const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
5022 if (PD)
5023 LHSType = PD->getType();
5024 }
5025
5026 if (LHSType.isNull())
5027 LHSType = LHS->getType();
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005028 if (checkUnsafeAssigns(Loc, LHSType, RHS))
5029 return;
5030 Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime();
5031 // FIXME. Check for other life times.
5032 if (LT != Qualifiers::OCL_None)
5033 return;
5034
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00005035 if (PRE) {
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005036 if (PRE->isImplicitProperty())
5037 return;
5038 const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
5039 if (!PD)
5040 return;
5041
5042 unsigned Attributes = PD->getPropertyAttributes();
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00005043 if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) {
5044 // when 'assign' attribute was not explicitly specified
5045 // by user, ignore it and rely on property type itself
5046 // for lifetime info.
5047 unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten();
5048 if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) &&
5049 LHSType->isObjCRetainableType())
5050 return;
5051
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005052 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
John McCall33e56f32011-09-10 06:18:15 +00005053 if (cast->getCastKind() == CK_ARCConsumeObject) {
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005054 Diag(Loc, diag::warn_arc_retained_property_assign)
5055 << RHS->getSourceRange();
5056 return;
5057 }
5058 RHS = cast->getSubExpr();
5059 }
Fariborz Jahanian87eaf722012-01-17 22:58:16 +00005060 }
Fariborz Jahanian921c1432011-06-24 18:25:34 +00005061 }
5062}
Dmitri Gribenko625bb562012-02-14 22:14:32 +00005063
5064//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===//
5065
5066namespace {
5067bool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr,
5068 SourceLocation StmtLoc,
5069 const NullStmt *Body) {
5070 // Do not warn if the body is a macro that expands to nothing, e.g:
5071 //
5072 // #define CALL(x)
5073 // if (condition)
5074 // CALL(0);
5075 //
5076 if (Body->hasLeadingEmptyMacro())
5077 return false;
5078
5079 // Get line numbers of statement and body.
5080 bool StmtLineInvalid;
5081 unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc,
5082 &StmtLineInvalid);
5083 if (StmtLineInvalid)
5084 return false;
5085
5086 bool BodyLineInvalid;
5087 unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(),
5088 &BodyLineInvalid);
5089 if (BodyLineInvalid)
5090 return false;
5091
5092 // Warn if null statement and body are on the same line.
5093 if (StmtLine != BodyLine)
5094 return false;
5095
5096 return true;
5097}
5098} // Unnamed namespace
5099
5100void Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc,
5101 const Stmt *Body,
5102 unsigned DiagID) {
5103 // Since this is a syntactic check, don't emit diagnostic for template
5104 // instantiations, this just adds noise.
5105 if (CurrentInstantiationScope)
5106 return;
5107
5108 // The body should be a null statement.
5109 const NullStmt *NBody = dyn_cast<NullStmt>(Body);
5110 if (!NBody)
5111 return;
5112
5113 // Do the usual checks.
5114 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
5115 return;
5116
5117 Diag(NBody->getSemiLoc(), DiagID);
5118 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
5119}
5120
5121void Sema::DiagnoseEmptyLoopBody(const Stmt *S,
5122 const Stmt *PossibleBody) {
5123 assert(!CurrentInstantiationScope); // Ensured by caller
5124
5125 SourceLocation StmtLoc;
5126 const Stmt *Body;
5127 unsigned DiagID;
5128 if (const ForStmt *FS = dyn_cast<ForStmt>(S)) {
5129 StmtLoc = FS->getRParenLoc();
5130 Body = FS->getBody();
5131 DiagID = diag::warn_empty_for_body;
5132 } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) {
5133 StmtLoc = WS->getCond()->getSourceRange().getEnd();
5134 Body = WS->getBody();
5135 DiagID = diag::warn_empty_while_body;
5136 } else
5137 return; // Neither `for' nor `while'.
5138
5139 // The body should be a null statement.
5140 const NullStmt *NBody = dyn_cast<NullStmt>(Body);
5141 if (!NBody)
5142 return;
5143
5144 // Skip expensive checks if diagnostic is disabled.
5145 if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) ==
5146 DiagnosticsEngine::Ignored)
5147 return;
5148
5149 // Do the usual checks.
5150 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
5151 return;
5152
5153 // `for(...);' and `while(...);' are popular idioms, so in order to keep
5154 // noise level low, emit diagnostics only if for/while is followed by a
5155 // CompoundStmt, e.g.:
5156 // for (int i = 0; i < n; i++);
5157 // {
5158 // a(i);
5159 // }
5160 // or if for/while is followed by a statement with more indentation
5161 // than for/while itself:
5162 // for (int i = 0; i < n; i++);
5163 // a(i);
5164 bool ProbableTypo = isa<CompoundStmt>(PossibleBody);
5165 if (!ProbableTypo) {
5166 bool BodyColInvalid;
5167 unsigned BodyCol = SourceMgr.getPresumedColumnNumber(
5168 PossibleBody->getLocStart(),
5169 &BodyColInvalid);
5170 if (BodyColInvalid)
5171 return;
5172
5173 bool StmtColInvalid;
5174 unsigned StmtCol = SourceMgr.getPresumedColumnNumber(
5175 S->getLocStart(),
5176 &StmtColInvalid);
5177 if (StmtColInvalid)
5178 return;
5179
5180 if (BodyCol > StmtCol)
5181 ProbableTypo = true;
5182 }
5183
5184 if (ProbableTypo) {
5185 Diag(NBody->getSemiLoc(), DiagID);
5186 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
5187 }
5188}