Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 1 | // |
| 2 | // Copyright 2016 The ANGLE Project Authors. All rights reserved. |
| 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | // FramebufferVk.cpp: |
| 7 | // Implements the class methods for FramebufferVk. |
| 8 | // |
| 9 | |
| 10 | #include "libANGLE/renderer/vulkan/FramebufferVk.h" |
| 11 | |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 12 | #include <vulkan/vulkan.h> |
Jamie Madill | 231c7f5 | 2017-04-26 13:45:37 -0400 | [diff] [blame] | 13 | #include <array> |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 14 | |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 15 | #include "common/debug.h" |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 16 | #include "libANGLE/Context.h" |
| 17 | #include "libANGLE/Display.h" |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 18 | #include "libANGLE/formatutils.h" |
| 19 | #include "libANGLE/renderer/renderer_utils.h" |
Jamie Madill | 1f46bc1 | 2018-02-20 16:09:43 -0500 | [diff] [blame] | 20 | #include "libANGLE/renderer/vulkan/CommandGraph.h" |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 21 | #include "libANGLE/renderer/vulkan/ContextVk.h" |
Jamie Madill | 5deea72 | 2017-02-16 10:44:46 -0500 | [diff] [blame] | 22 | #include "libANGLE/renderer/vulkan/DisplayVk.h" |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 23 | #include "libANGLE/renderer/vulkan/RenderTargetVk.h" |
| 24 | #include "libANGLE/renderer/vulkan/RendererVk.h" |
| 25 | #include "libANGLE/renderer/vulkan/SurfaceVk.h" |
Jamie Madill | 3c424b4 | 2018-01-19 12:35:09 -0500 | [diff] [blame] | 26 | #include "libANGLE/renderer/vulkan/vk_format_utils.h" |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 27 | |
| 28 | namespace rx |
| 29 | { |
| 30 | |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 31 | namespace |
| 32 | { |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 33 | constexpr size_t kMinReadPixelsBufferSize = 128000; |
| 34 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 35 | const gl::InternalFormat &GetReadAttachmentInfo(const gl::Context *context, |
| 36 | RenderTargetVk *renderTarget) |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 37 | { |
Jamie Madill | bc54342 | 2018-03-30 10:43:19 -0400 | [diff] [blame] | 38 | GLenum implFormat = |
| 39 | renderTarget->image->getFormat().textureFormat().fboImplementationInternalFormat; |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 40 | return gl::GetSizedInternalFormatInfo(implFormat); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 41 | } |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 42 | } // anonymous namespace< |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 43 | |
| 44 | // static |
| 45 | FramebufferVk *FramebufferVk::CreateUserFBO(const gl::FramebufferState &state) |
| 46 | { |
| 47 | return new FramebufferVk(state); |
| 48 | } |
| 49 | |
| 50 | // static |
| 51 | FramebufferVk *FramebufferVk::CreateDefaultFBO(const gl::FramebufferState &state, |
| 52 | WindowSurfaceVk *backbuffer) |
| 53 | { |
| 54 | return new FramebufferVk(state, backbuffer); |
| 55 | } |
| 56 | |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 57 | FramebufferVk::FramebufferVk(const gl::FramebufferState &state) |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 58 | : FramebufferImpl(state), |
| 59 | mBackbuffer(nullptr), |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 60 | mActiveColorComponents(0), |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 61 | mReadPixelsBuffer(VK_BUFFER_USAGE_TRANSFER_DST_BIT, kMinReadPixelsBufferSize) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 62 | { |
| 63 | } |
| 64 | |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 65 | FramebufferVk::FramebufferVk(const gl::FramebufferState &state, WindowSurfaceVk *backbuffer) |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 66 | : FramebufferImpl(state), |
| 67 | mBackbuffer(backbuffer), |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 68 | mActiveColorComponents(0), |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 69 | mReadPixelsBuffer(VK_BUFFER_USAGE_TRANSFER_DST_BIT, kMinReadPixelsBufferSize) |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 70 | { |
| 71 | } |
| 72 | |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame^] | 73 | FramebufferVk::~FramebufferVk() = default; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 74 | |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 75 | void FramebufferVk::destroy(const gl::Context *context) |
Jamie Madill | 5deea72 | 2017-02-16 10:44:46 -0500 | [diff] [blame] | 76 | { |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 77 | ContextVk *contextVk = vk::GetImpl(context); |
| 78 | RendererVk *renderer = contextVk->getRenderer(); |
Jamie Madill | 526543c | 2017-10-28 10:59:16 -0400 | [diff] [blame] | 79 | renderer->releaseResource(*this, &mFramebuffer); |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 80 | |
| 81 | mReadPixelsBuffer.destroy(contextVk->getDevice()); |
Jamie Madill | 5deea72 | 2017-02-16 10:44:46 -0500 | [diff] [blame] | 82 | } |
| 83 | |
Jamie Madill | 4928b7c | 2017-06-20 12:57:39 -0400 | [diff] [blame] | 84 | gl::Error FramebufferVk::discard(const gl::Context *context, |
| 85 | size_t count, |
| 86 | const GLenum *attachments) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 87 | { |
| 88 | UNIMPLEMENTED(); |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 89 | return gl::InternalError(); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 90 | } |
| 91 | |
Jamie Madill | 4928b7c | 2017-06-20 12:57:39 -0400 | [diff] [blame] | 92 | gl::Error FramebufferVk::invalidate(const gl::Context *context, |
| 93 | size_t count, |
| 94 | const GLenum *attachments) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 95 | { |
| 96 | UNIMPLEMENTED(); |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 97 | return gl::InternalError(); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 98 | } |
| 99 | |
Jamie Madill | 4928b7c | 2017-06-20 12:57:39 -0400 | [diff] [blame] | 100 | gl::Error FramebufferVk::invalidateSub(const gl::Context *context, |
| 101 | size_t count, |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 102 | const GLenum *attachments, |
| 103 | const gl::Rectangle &area) |
| 104 | { |
| 105 | UNIMPLEMENTED(); |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 106 | return gl::InternalError(); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 107 | } |
| 108 | |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 109 | gl::Error FramebufferVk::clear(const gl::Context *context, GLbitfield mask) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 110 | { |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 111 | ContextVk *contextVk = vk::GetImpl(context); |
| 112 | RendererVk *renderer = contextVk->getRenderer(); |
| 113 | Serial currentSerial = renderer->getCurrentQueueSerial(); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 114 | |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 115 | // This command buffer is only started once. |
| 116 | vk::CommandBuffer *commandBuffer = nullptr; |
| 117 | vk::CommandGraphNode *writingNode = nullptr; |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 118 | |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 119 | const gl::FramebufferAttachment *depthAttachment = mState.getDepthAttachment(); |
| 120 | bool clearDepth = (depthAttachment && (mask & GL_DEPTH_BUFFER_BIT) != 0); |
| 121 | ASSERT(!clearDepth || depthAttachment->isAttached()); |
| 122 | |
| 123 | const gl::FramebufferAttachment *stencilAttachment = mState.getStencilAttachment(); |
| 124 | bool clearStencil = (stencilAttachment && (mask & GL_STENCIL_BUFFER_BIT) != 0); |
| 125 | ASSERT(!clearStencil || stencilAttachment->isAttached()); |
| 126 | |
Luc Ferron | a8af3a6 | 2018-03-29 14:44:24 -0400 | [diff] [blame] | 127 | bool clearColor = IsMaskFlagSet(static_cast<int>(mask), GL_COLOR_BUFFER_BIT); |
| 128 | |
Luc Ferron | 8836f63 | 2018-04-05 07:26:53 -0400 | [diff] [blame] | 129 | const gl::FramebufferAttachment *depthStencilAttachment = mState.getDepthStencilAttachment(); |
Jamie Madill | d47044a | 2018-04-27 11:45:03 -0400 | [diff] [blame] | 130 | const gl::State &glState = context->getGLState(); |
Luc Ferron | 8836f63 | 2018-04-05 07:26:53 -0400 | [diff] [blame] | 131 | |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 132 | // The most costly clear mode is when we need to mask out specific color channels. This can |
| 133 | // only be done with a draw call. The scissor region however can easily be integrated with |
| 134 | // this method. Similarly for depth/stencil clear. |
| 135 | VkColorComponentFlags colorMaskFlags = contextVk->getClearColorMask(); |
| 136 | if (clearColor && (mActiveColorComponents & colorMaskFlags) != mActiveColorComponents) |
| 137 | { |
Jamie Madill | 78cd940 | 2018-05-10 16:49:58 -0400 | [diff] [blame] | 138 | ANGLE_TRY(clearWithDraw(contextVk, colorMaskFlags)); |
| 139 | |
| 140 | // Stencil clears must be handled separately. The only way to write out a stencil value from |
| 141 | // a fragment shader in Vulkan is with VK_EXT_shader_stencil_export. Support for this |
| 142 | // extension is sparse. Hence, we call into the RenderPass clear path. We similarly clear |
| 143 | // depth to keep the code simple, but depth clears could be combined with the masked color |
| 144 | // clears as an optimization. |
| 145 | |
| 146 | if (clearDepth || clearStencil) |
| 147 | { |
| 148 | // Masked stencil clears are currently not implemented. |
| 149 | // TODO(jmadill): Masked stencil clear. http://anglebug.com/2540 |
| 150 | ANGLE_TRY(clearWithClearAttachments(contextVk, false, clearDepth, clearStencil)); |
| 151 | } |
| 152 | return gl::NoError(); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 153 | } |
| 154 | |
Luc Ferron | 8836f63 | 2018-04-05 07:26:53 -0400 | [diff] [blame] | 155 | // If we clear the depth OR the stencil but not both, and we have a packed depth stencil |
| 156 | // attachment, we need to use clearAttachment instead of clearDepthStencil since Vulkan won't |
| 157 | // allow us to clear one or the other separately. |
| 158 | bool isSingleClearOnPackedDepthStencilAttachment = |
| 159 | depthStencilAttachment && (clearDepth != clearStencil); |
Jamie Madill | d47044a | 2018-04-27 11:45:03 -0400 | [diff] [blame] | 160 | if (glState.isScissorTestEnabled() || isSingleClearOnPackedDepthStencilAttachment) |
Luc Ferron | a8af3a6 | 2018-03-29 14:44:24 -0400 | [diff] [blame] | 161 | { |
| 162 | // With scissor test enabled, we clear very differently and we don't need to access |
| 163 | // the image inside each attachment we can just use clearCmdAttachments with our |
| 164 | // scissor region instead. |
Jamie Madill | 78cd940 | 2018-05-10 16:49:58 -0400 | [diff] [blame] | 165 | |
| 166 | // Masked stencil clears are currently not implemented. |
| 167 | // TODO(jmadill): Masked stencil clear. http://anglebug.com/2540 |
Jamie Madill | b90779e | 2018-04-27 11:45:01 -0400 | [diff] [blame] | 168 | ANGLE_TRY(clearWithClearAttachments(contextVk, clearColor, clearDepth, clearStencil)); |
Luc Ferron | a8af3a6 | 2018-03-29 14:44:24 -0400 | [diff] [blame] | 169 | return gl::NoError(); |
| 170 | } |
| 171 | |
| 172 | // Standard Depth/stencil clear without scissor. |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 173 | if (clearDepth || clearStencil) |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 174 | { |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 175 | ANGLE_TRY(beginWriteResource(renderer, &commandBuffer)); |
Jamie Madill | 9cceac4 | 2018-03-31 14:19:16 -0400 | [diff] [blame] | 176 | writingNode = getCurrentWritingNode(); |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 177 | |
| 178 | const VkClearDepthStencilValue &clearDepthStencilValue = |
| 179 | contextVk->getClearDepthStencilValue().depthStencil; |
| 180 | |
| 181 | // We only support packed depth/stencil, not separate. |
Luc Ferron | 8836f63 | 2018-04-05 07:26:53 -0400 | [diff] [blame] | 182 | ASSERT(!(clearDepth && clearStencil) || depthStencilAttachment); |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 183 | |
Luc Ferron | e6a40d0 | 2018-03-22 10:30:57 -0400 | [diff] [blame] | 184 | const VkImageAspectFlags aspectFlags = |
| 185 | (depthAttachment ? VK_IMAGE_ASPECT_DEPTH_BIT : 0) | |
| 186 | (stencilAttachment ? VK_IMAGE_ASPECT_STENCIL_BIT : 0); |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 187 | |
| 188 | RenderTargetVk *renderTarget = mRenderTargetCache.getDepthStencil(); |
| 189 | renderTarget->resource->onWriteResource(writingNode, currentSerial); |
Jamie Madill | 858c1cc | 2018-03-31 14:19:13 -0400 | [diff] [blame] | 190 | renderTarget->image->clearDepthStencil(aspectFlags, clearDepthStencilValue, commandBuffer); |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 191 | |
Luc Ferron | a8af3a6 | 2018-03-29 14:44:24 -0400 | [diff] [blame] | 192 | if (!clearColor) |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 193 | { |
| 194 | return gl::NoError(); |
| 195 | } |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 196 | } |
| 197 | |
Luc Ferron | a8af3a6 | 2018-03-29 14:44:24 -0400 | [diff] [blame] | 198 | ASSERT(clearColor); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 199 | const auto *attachment = mState.getFirstNonNullAttachment(); |
| 200 | ASSERT(attachment && attachment->isAttached()); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 201 | |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 202 | if (!commandBuffer) |
| 203 | { |
| 204 | ANGLE_TRY(beginWriteResource(renderer, &commandBuffer)); |
Jamie Madill | 9cceac4 | 2018-03-31 14:19:16 -0400 | [diff] [blame] | 205 | writingNode = getCurrentWritingNode(); |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 206 | } |
Jamie Madill | efb5a5c | 2018-01-29 15:56:59 -0500 | [diff] [blame] | 207 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 208 | // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394 |
| 209 | const auto &colorRenderTargets = mRenderTargetCache.getColors(); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 210 | const VkClearColorValue &clearColorValue = contextVk->getClearColorValue().color; |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 211 | for (size_t colorIndex : mState.getEnabledDrawBuffers()) |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 212 | { |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 213 | RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex]; |
| 214 | ASSERT(colorRenderTarget); |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 215 | colorRenderTarget->resource->onWriteResource(writingNode, currentSerial); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 216 | colorRenderTarget->image->clearColor(clearColorValue, commandBuffer); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 217 | } |
| 218 | |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 219 | return gl::NoError(); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 220 | } |
| 221 | |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 222 | gl::Error FramebufferVk::clearBufferfv(const gl::Context *context, |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 223 | GLenum buffer, |
| 224 | GLint drawbuffer, |
| 225 | const GLfloat *values) |
| 226 | { |
| 227 | UNIMPLEMENTED(); |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 228 | return gl::InternalError(); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 229 | } |
| 230 | |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 231 | gl::Error FramebufferVk::clearBufferuiv(const gl::Context *context, |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 232 | GLenum buffer, |
| 233 | GLint drawbuffer, |
| 234 | const GLuint *values) |
| 235 | { |
| 236 | UNIMPLEMENTED(); |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 237 | return gl::InternalError(); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 238 | } |
| 239 | |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 240 | gl::Error FramebufferVk::clearBufferiv(const gl::Context *context, |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 241 | GLenum buffer, |
| 242 | GLint drawbuffer, |
| 243 | const GLint *values) |
| 244 | { |
| 245 | UNIMPLEMENTED(); |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 246 | return gl::InternalError(); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 247 | } |
| 248 | |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 249 | gl::Error FramebufferVk::clearBufferfi(const gl::Context *context, |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 250 | GLenum buffer, |
| 251 | GLint drawbuffer, |
| 252 | GLfloat depth, |
| 253 | GLint stencil) |
| 254 | { |
| 255 | UNIMPLEMENTED(); |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 256 | return gl::InternalError(); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 257 | } |
| 258 | |
Jamie Madill | 4928b7c | 2017-06-20 12:57:39 -0400 | [diff] [blame] | 259 | GLenum FramebufferVk::getImplementationColorReadFormat(const gl::Context *context) const |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 260 | { |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 261 | return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).format; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 262 | } |
| 263 | |
Jamie Madill | 4928b7c | 2017-06-20 12:57:39 -0400 | [diff] [blame] | 264 | GLenum FramebufferVk::getImplementationColorReadType(const gl::Context *context) const |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 265 | { |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 266 | return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).type; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 267 | } |
| 268 | |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 269 | gl::Error FramebufferVk::readPixels(const gl::Context *context, |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 270 | const gl::Rectangle &area, |
| 271 | GLenum format, |
| 272 | GLenum type, |
Jamie Madill | d482615 | 2017-09-21 11:18:59 -0400 | [diff] [blame] | 273 | void *pixels) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 274 | { |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 275 | // Clip read area to framebuffer. |
| 276 | const gl::Extents &fbSize = getState().getReadAttachment()->getSize(); |
| 277 | const gl::Rectangle fbRect(0, 0, fbSize.width, fbSize.height); |
| 278 | gl::Rectangle clippedArea; |
| 279 | if (!ClipRectangle(area, fbRect, &clippedArea)) |
| 280 | { |
| 281 | // nothing to read |
| 282 | return gl::NoError(); |
| 283 | } |
| 284 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 285 | const gl::State &glState = context->getGLState(); |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 286 | RendererVk *renderer = vk::GetImpl(context)->getRenderer(); |
| 287 | |
| 288 | vk::CommandBuffer *commandBuffer = nullptr; |
| 289 | ANGLE_TRY(beginWriteResource(renderer, &commandBuffer)); |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 290 | |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 291 | const gl::PixelPackState &packState = context->getGLState().getPackState(); |
| 292 | const gl::InternalFormat &sizedFormatInfo = gl::GetInternalFormatInfo(format, type); |
| 293 | |
| 294 | GLuint outputPitch = 0; |
| 295 | ANGLE_TRY_RESULT( |
| 296 | sizedFormatInfo.computeRowPitch(type, area.width, packState.alignment, packState.rowLength), |
| 297 | outputPitch); |
| 298 | GLuint outputSkipBytes = 0; |
Jeff Gilbert | 31d3deb | 2018-05-18 18:32:16 -0700 | [diff] [blame] | 299 | ANGLE_TRY_RESULT(sizedFormatInfo.computeSkipBytes(type, outputPitch, 0, packState, false), |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 300 | outputSkipBytes); |
| 301 | |
| 302 | outputSkipBytes += (clippedArea.x - area.x) * sizedFormatInfo.pixelBytes + |
| 303 | (clippedArea.y - area.y) * outputPitch; |
Luc Ferron | 6028422 | 2018-03-20 16:01:44 -0400 | [diff] [blame] | 304 | |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 305 | PackPixelsParams params; |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 306 | params.area = clippedArea; |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 307 | params.format = format; |
| 308 | params.type = type; |
Luc Ferron | 6028422 | 2018-03-20 16:01:44 -0400 | [diff] [blame] | 309 | params.outputPitch = outputPitch; |
Corentin Wallez | 336129f | 2017-10-17 15:55:40 -0400 | [diff] [blame] | 310 | params.packBuffer = glState.getTargetBuffer(gl::BufferBinding::PixelPack); |
Corentin Wallez | cda6af1 | 2017-10-30 19:20:37 -0400 | [diff] [blame] | 311 | params.pack = glState.getPackState(); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 312 | |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame^] | 313 | ANGLE_TRY(readPixelsImpl(context, clippedArea, params, |
| 314 | reinterpret_cast<uint8_t *>(pixels) + outputSkipBytes)); |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 315 | mReadPixelsBuffer.releaseRetainedBuffers(renderer); |
| 316 | return gl::NoError(); |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 317 | } |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 318 | |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame^] | 319 | RenderTargetVk *FramebufferVk::getColorReadRenderTarget() const |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 320 | { |
| 321 | RenderTargetVk *renderTarget = mRenderTargetCache.getColorRead(mState); |
| 322 | ASSERT(renderTarget && renderTarget->image->valid()); |
| 323 | return renderTarget; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 324 | } |
| 325 | |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 326 | gl::Error FramebufferVk::blit(const gl::Context *context, |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 327 | const gl::Rectangle &sourceArea, |
| 328 | const gl::Rectangle &destArea, |
| 329 | GLbitfield mask, |
| 330 | GLenum filter) |
| 331 | { |
| 332 | UNIMPLEMENTED(); |
Yuly Novikov | c4d18aa | 2017-03-09 18:45:02 -0500 | [diff] [blame] | 333 | return gl::InternalError(); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 334 | } |
| 335 | |
Kenneth Russell | ce8602a | 2017-10-03 18:23:08 -0700 | [diff] [blame] | 336 | bool FramebufferVk::checkStatus(const gl::Context *context) const |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 337 | { |
Jamie Madill | b79e7bb | 2017-10-24 13:55:50 -0400 | [diff] [blame] | 338 | return true; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 339 | } |
| 340 | |
Jamie Madill | 19fa1c6 | 2018-03-08 09:47:21 -0500 | [diff] [blame] | 341 | gl::Error FramebufferVk::syncState(const gl::Context *context, |
| 342 | const gl::Framebuffer::DirtyBits &dirtyBits) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 343 | { |
Jamie Madill | e1f3ad4 | 2017-10-28 23:00:42 -0400 | [diff] [blame] | 344 | ContextVk *contextVk = vk::GetImpl(context); |
Jamie Madill | 7bd1666 | 2017-10-28 19:40:50 -0400 | [diff] [blame] | 345 | RendererVk *renderer = contextVk->getRenderer(); |
Jamie Madill | dd43e6c | 2017-03-24 14:18:49 -0400 | [diff] [blame] | 346 | |
| 347 | ASSERT(dirtyBits.any()); |
Jamie Madill | 57d9cbb | 2018-04-27 11:45:04 -0400 | [diff] [blame] | 348 | for (size_t dirtyBit : dirtyBits) |
| 349 | { |
| 350 | switch (dirtyBit) |
| 351 | { |
| 352 | case gl::Framebuffer::DIRTY_BIT_DEPTH_ATTACHMENT: |
| 353 | case gl::Framebuffer::DIRTY_BIT_STENCIL_ATTACHMENT: |
| 354 | ANGLE_TRY(mRenderTargetCache.updateDepthStencilRenderTarget(context, mState)); |
| 355 | break; |
| 356 | case gl::Framebuffer::DIRTY_BIT_DRAW_BUFFERS: |
| 357 | case gl::Framebuffer::DIRTY_BIT_READ_BUFFER: |
| 358 | case gl::Framebuffer::DIRTY_BIT_DEFAULT_WIDTH: |
| 359 | case gl::Framebuffer::DIRTY_BIT_DEFAULT_HEIGHT: |
| 360 | case gl::Framebuffer::DIRTY_BIT_DEFAULT_SAMPLES: |
| 361 | case gl::Framebuffer::DIRTY_BIT_DEFAULT_FIXED_SAMPLE_LOCATIONS: |
| 362 | break; |
| 363 | default: |
| 364 | { |
| 365 | ASSERT(gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0 == 0 && |
| 366 | dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_MAX); |
| 367 | size_t colorIndex = |
| 368 | static_cast<size_t>(dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0); |
| 369 | ANGLE_TRY(mRenderTargetCache.updateColorRenderTarget(context, mState, colorIndex)); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 370 | |
| 371 | // Update cached masks for masked clears. |
| 372 | RenderTargetVk *renderTarget = mRenderTargetCache.getColors()[colorIndex]; |
| 373 | if (renderTarget) |
| 374 | { |
| 375 | const angle::Format &format = renderTarget->image->getFormat().textureFormat(); |
| 376 | updateActiveColorMasks(colorIndex, format.redBits > 0, format.greenBits > 0, |
| 377 | format.blueBits > 0, format.alphaBits > 0); |
| 378 | } |
| 379 | else |
| 380 | { |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame^] | 381 | updateActiveColorMasks(colorIndex, false, false, false, false); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 382 | } |
Jamie Madill | 57d9cbb | 2018-04-27 11:45:04 -0400 | [diff] [blame] | 383 | break; |
| 384 | } |
| 385 | } |
| 386 | } |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 387 | |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 388 | mActiveColorComponents = gl_vk::GetColorComponentFlags( |
| 389 | mActiveColorComponentMasks[0].any(), mActiveColorComponentMasks[1].any(), |
| 390 | mActiveColorComponentMasks[2].any(), mActiveColorComponentMasks[3].any()); |
| 391 | |
Jamie Madill | 9f2a861 | 2017-11-30 12:43:09 -0500 | [diff] [blame] | 392 | mRenderPassDesc.reset(); |
Jamie Madill | 7bd1666 | 2017-10-28 19:40:50 -0400 | [diff] [blame] | 393 | renderer->releaseResource(*this, &mFramebuffer); |
Jamie Madill | 49ac74b | 2017-12-21 14:42:33 -0500 | [diff] [blame] | 394 | |
Jamie Madill | 9cceac4 | 2018-03-31 14:19:16 -0400 | [diff] [blame] | 395 | // Trigger a new set of secondary commands next time we render to this FBO. |
| 396 | getNewWritingNode(renderer); |
Jamie Madill | 7210656 | 2017-03-24 14:18:50 -0400 | [diff] [blame] | 397 | |
Jamie Madill | 7210656 | 2017-03-24 14:18:50 -0400 | [diff] [blame] | 398 | contextVk->invalidateCurrentPipeline(); |
Jamie Madill | 19fa1c6 | 2018-03-08 09:47:21 -0500 | [diff] [blame] | 399 | |
| 400 | return gl::NoError(); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 401 | } |
| 402 | |
Jamie Madill | b90779e | 2018-04-27 11:45:01 -0400 | [diff] [blame] | 403 | const vk::RenderPassDesc &FramebufferVk::getRenderPassDesc() |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 404 | { |
Jamie Madill | 9f2a861 | 2017-11-30 12:43:09 -0500 | [diff] [blame] | 405 | if (mRenderPassDesc.valid()) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 406 | { |
Jamie Madill | 9f2a861 | 2017-11-30 12:43:09 -0500 | [diff] [blame] | 407 | return mRenderPassDesc.value(); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 408 | } |
| 409 | |
Jamie Madill | 0b684ce | 2017-11-23 12:57:39 -0500 | [diff] [blame] | 410 | vk::RenderPassDesc desc; |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 411 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 412 | // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394 |
| 413 | const auto &colorRenderTargets = mRenderTargetCache.getColors(); |
| 414 | for (size_t colorIndex : mState.getEnabledDrawBuffers()) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 415 | { |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 416 | RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex]; |
| 417 | ASSERT(colorRenderTarget); |
Jamie Madill | bc54342 | 2018-03-30 10:43:19 -0400 | [diff] [blame] | 418 | desc.packColorAttachment(*colorRenderTarget->image); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 419 | } |
| 420 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 421 | RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil(); |
| 422 | if (depthStencilRenderTarget) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 423 | { |
Jamie Madill | bc54342 | 2018-03-30 10:43:19 -0400 | [diff] [blame] | 424 | desc.packDepthStencilAttachment(*depthStencilRenderTarget->image); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 425 | } |
| 426 | |
Jamie Madill | 9f2a861 | 2017-11-30 12:43:09 -0500 | [diff] [blame] | 427 | mRenderPassDesc = desc; |
| 428 | return mRenderPassDesc.value(); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 429 | } |
| 430 | |
Jamie Madill | b90779e | 2018-04-27 11:45:01 -0400 | [diff] [blame] | 431 | gl::ErrorOrResult<vk::Framebuffer *> FramebufferVk::getFramebuffer(RendererVk *rendererVk) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 432 | { |
| 433 | // If we've already created our cached Framebuffer, return it. |
Jamie Madill | dd43e6c | 2017-03-24 14:18:49 -0400 | [diff] [blame] | 434 | if (mFramebuffer.valid()) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 435 | { |
| 436 | return &mFramebuffer; |
| 437 | } |
| 438 | |
Jamie Madill | b90779e | 2018-04-27 11:45:01 -0400 | [diff] [blame] | 439 | const vk::RenderPassDesc &desc = getRenderPassDesc(); |
Jamie Madill | 9f2a861 | 2017-11-30 12:43:09 -0500 | [diff] [blame] | 440 | |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 441 | vk::RenderPass *renderPass = nullptr; |
Jamie Madill | 9f2a861 | 2017-11-30 12:43:09 -0500 | [diff] [blame] | 442 | ANGLE_TRY(rendererVk->getCompatibleRenderPass(desc, &renderPass)); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 443 | |
| 444 | // If we've a Framebuffer provided by a Surface (default FBO/backbuffer), query it. |
Jamie Madill | 9f2a861 | 2017-11-30 12:43:09 -0500 | [diff] [blame] | 445 | VkDevice device = rendererVk->getDevice(); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 446 | if (mBackbuffer) |
| 447 | { |
| 448 | return mBackbuffer->getCurrentFramebuffer(device, *renderPass); |
| 449 | } |
| 450 | |
| 451 | // Gather VkImageViews over all FBO attachments, also size of attached region. |
| 452 | std::vector<VkImageView> attachments; |
| 453 | gl::Extents attachmentsSize; |
| 454 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 455 | // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394 |
| 456 | const auto &colorRenderTargets = mRenderTargetCache.getColors(); |
| 457 | for (size_t colorIndex : mState.getEnabledDrawBuffers()) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 458 | { |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 459 | RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex]; |
| 460 | ASSERT(colorRenderTarget); |
| 461 | attachments.push_back(colorRenderTarget->imageView->getHandle()); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 462 | |
Jamie Madill | bc54342 | 2018-03-30 10:43:19 -0400 | [diff] [blame] | 463 | ASSERT(attachmentsSize.empty() || |
| 464 | attachmentsSize == colorRenderTarget->image->getExtents()); |
| 465 | attachmentsSize = colorRenderTarget->image->getExtents(); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 466 | } |
| 467 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 468 | RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil(); |
| 469 | if (depthStencilRenderTarget) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 470 | { |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 471 | attachments.push_back(depthStencilRenderTarget->imageView->getHandle()); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 472 | |
Jamie Madill | bc54342 | 2018-03-30 10:43:19 -0400 | [diff] [blame] | 473 | ASSERT(attachmentsSize.empty() || |
| 474 | attachmentsSize == depthStencilRenderTarget->image->getExtents()); |
| 475 | attachmentsSize = depthStencilRenderTarget->image->getExtents(); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 476 | } |
| 477 | |
| 478 | ASSERT(!attachments.empty()); |
| 479 | |
| 480 | VkFramebufferCreateInfo framebufferInfo; |
| 481 | |
| 482 | framebufferInfo.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO; |
| 483 | framebufferInfo.pNext = nullptr; |
| 484 | framebufferInfo.flags = 0; |
Jamie Madill | 9f2a861 | 2017-11-30 12:43:09 -0500 | [diff] [blame] | 485 | framebufferInfo.renderPass = renderPass->getHandle(); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 486 | framebufferInfo.attachmentCount = static_cast<uint32_t>(attachments.size()); |
| 487 | framebufferInfo.pAttachments = attachments.data(); |
| 488 | framebufferInfo.width = static_cast<uint32_t>(attachmentsSize.width); |
| 489 | framebufferInfo.height = static_cast<uint32_t>(attachmentsSize.height); |
| 490 | framebufferInfo.layers = 1; |
| 491 | |
Jamie Madill | 25301b6 | 2017-10-28 20:59:31 -0400 | [diff] [blame] | 492 | ANGLE_TRY(mFramebuffer.init(device, framebufferInfo)); |
Jamie Madill | 5deea72 | 2017-02-16 10:44:46 -0500 | [diff] [blame] | 493 | |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 494 | return &mFramebuffer; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 495 | } |
| 496 | |
Jamie Madill | b90779e | 2018-04-27 11:45:01 -0400 | [diff] [blame] | 497 | gl::Error FramebufferVk::clearWithClearAttachments(ContextVk *contextVk, |
| 498 | bool clearColor, |
| 499 | bool clearDepth, |
| 500 | bool clearStencil) |
Luc Ferron | 5242d5b | 2018-02-15 07:14:35 -0500 | [diff] [blame] | 501 | { |
Luc Ferron | 5242d5b | 2018-02-15 07:14:35 -0500 | [diff] [blame] | 502 | RendererVk *renderer = contextVk->getRenderer(); |
| 503 | |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 504 | getNewWritingNode(renderer); |
| 505 | |
Luc Ferron | 5242d5b | 2018-02-15 07:14:35 -0500 | [diff] [blame] | 506 | // This command can only happen inside a render pass, so obtain one if its already happening |
| 507 | // or create a new one if not. |
| 508 | vk::CommandGraphNode *node = nullptr; |
| 509 | vk::CommandBuffer *commandBuffer = nullptr; |
Jamie Madill | b90779e | 2018-04-27 11:45:01 -0400 | [diff] [blame] | 510 | ANGLE_TRY(getCommandGraphNodeForDraw(contextVk, &node)); |
Luc Ferron | 5242d5b | 2018-02-15 07:14:35 -0500 | [diff] [blame] | 511 | if (node->getInsideRenderPassCommands()->valid()) |
| 512 | { |
| 513 | commandBuffer = node->getInsideRenderPassCommands(); |
| 514 | } |
| 515 | else |
| 516 | { |
| 517 | ANGLE_TRY(node->beginInsideRenderPassRecording(renderer, &commandBuffer)); |
| 518 | } |
| 519 | |
Luc Ferron | e4c38be | 2018-04-17 11:09:16 -0400 | [diff] [blame] | 520 | // TODO(jmadill): Cube map attachments. http://anglebug.com/2470 |
| 521 | // We assume for now that we always need to clear only 1 layer starting at the |
| 522 | // baseArrayLayer 0, this might need to change depending how we'll implement |
| 523 | // cube maps, 3d textures and array textures. |
| 524 | VkClearRect clearRect; |
| 525 | clearRect.baseArrayLayer = 0; |
| 526 | clearRect.layerCount = 1; |
| 527 | |
| 528 | // When clearing, the scissor region must be clipped to the renderArea per the validation rules |
| 529 | // in Vulkan. |
| 530 | gl::Rectangle intersection; |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 531 | if (!gl::ClipRectangle(contextVk->getGLState().getScissor(), node->getRenderPassRenderArea(), |
| 532 | &intersection)) |
Luc Ferron | e4c38be | 2018-04-17 11:09:16 -0400 | [diff] [blame] | 533 | { |
| 534 | // There is nothing to clear since the scissor is outside of the render area. |
| 535 | return gl::NoError(); |
| 536 | } |
Luc Ferron | e4c38be | 2018-04-17 11:09:16 -0400 | [diff] [blame] | 537 | clearRect.rect = gl_vk::GetRect(intersection); |
| 538 | |
Luc Ferron | 5242d5b | 2018-02-15 07:14:35 -0500 | [diff] [blame] | 539 | gl::AttachmentArray<VkClearAttachment> clearAttachments; |
| 540 | int clearAttachmentIndex = 0; |
Luc Ferron | a8af3a6 | 2018-03-29 14:44:24 -0400 | [diff] [blame] | 541 | |
| 542 | if (clearColor) |
Luc Ferron | 5242d5b | 2018-02-15 07:14:35 -0500 | [diff] [blame] | 543 | { |
Luc Ferron | a8af3a6 | 2018-03-29 14:44:24 -0400 | [diff] [blame] | 544 | // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394 |
| 545 | for (size_t colorIndex : mState.getEnabledDrawBuffers()) |
| 546 | { |
| 547 | VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex]; |
| 548 | clearAttachment.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT; |
| 549 | clearAttachment.colorAttachment = static_cast<uint32_t>(colorIndex); |
| 550 | clearAttachment.clearValue = contextVk->getClearColorValue(); |
| 551 | ++clearAttachmentIndex; |
| 552 | } |
| 553 | } |
| 554 | |
| 555 | if (clearDepth && clearStencil && mState.getDepthStencilAttachment() != nullptr) |
| 556 | { |
| 557 | // When we have a packed depth/stencil attachment we can do 1 clear for both when it |
| 558 | // applies. |
Luc Ferron | 5242d5b | 2018-02-15 07:14:35 -0500 | [diff] [blame] | 559 | VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex]; |
Luc Ferron | a8af3a6 | 2018-03-29 14:44:24 -0400 | [diff] [blame] | 560 | clearAttachment.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT; |
| 561 | clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED; |
| 562 | clearAttachment.clearValue = contextVk->getClearDepthStencilValue(); |
Luc Ferron | 5242d5b | 2018-02-15 07:14:35 -0500 | [diff] [blame] | 563 | ++clearAttachmentIndex; |
| 564 | } |
Luc Ferron | a8af3a6 | 2018-03-29 14:44:24 -0400 | [diff] [blame] | 565 | else |
| 566 | { |
| 567 | if (clearDepth) |
| 568 | { |
| 569 | VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex]; |
| 570 | clearAttachment.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT; |
| 571 | clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED; |
| 572 | clearAttachment.clearValue = contextVk->getClearDepthStencilValue(); |
| 573 | ++clearAttachmentIndex; |
| 574 | } |
| 575 | |
| 576 | if (clearStencil) |
| 577 | { |
| 578 | VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex]; |
| 579 | clearAttachment.aspectMask = VK_IMAGE_ASPECT_STENCIL_BIT; |
| 580 | clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED; |
| 581 | clearAttachment.clearValue = contextVk->getClearDepthStencilValue(); |
| 582 | ++clearAttachmentIndex; |
| 583 | } |
| 584 | } |
Luc Ferron | 5242d5b | 2018-02-15 07:14:35 -0500 | [diff] [blame] | 585 | |
Luc Ferron | a8af3a6 | 2018-03-29 14:44:24 -0400 | [diff] [blame] | 586 | commandBuffer->clearAttachments(static_cast<uint32_t>(clearAttachmentIndex), |
Luc Ferron | 5242d5b | 2018-02-15 07:14:35 -0500 | [diff] [blame] | 587 | clearAttachments.data(), 1, &clearRect); |
| 588 | return gl::NoError(); |
| 589 | } |
| 590 | |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 591 | gl::Error FramebufferVk::clearWithDraw(ContextVk *contextVk, VkColorComponentFlags colorMaskFlags) |
| 592 | { |
| 593 | RendererVk *renderer = contextVk->getRenderer(); |
| 594 | vk::ShaderLibrary *shaderLibrary = renderer->getShaderLibrary(); |
| 595 | |
| 596 | const vk::ShaderAndSerial *fullScreenQuad = nullptr; |
| 597 | ANGLE_TRY(shaderLibrary->getShader(renderer, vk::InternalShaderID::FullScreenQuad_vert, |
| 598 | &fullScreenQuad)); |
| 599 | |
jchen10 | be7f44f | 2018-05-21 14:35:32 +0800 | [diff] [blame] | 600 | const vk::ShaderAndSerial *pushConstantColor = nullptr; |
| 601 | ANGLE_TRY(shaderLibrary->getShader(renderer, vk::InternalShaderID::PushConstantColor_frag, |
| 602 | &pushConstantColor)); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 603 | |
| 604 | const vk::PipelineLayout *pipelineLayout = nullptr; |
jchen10 | be7f44f | 2018-05-21 14:35:32 +0800 | [diff] [blame] | 605 | ANGLE_TRY(renderer->getInternalPushConstantPipelineLayout(&pipelineLayout)); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 606 | |
| 607 | vk::CommandBuffer *commandBuffer = nullptr; |
| 608 | ANGLE_TRY(beginWriteResource(renderer, &commandBuffer)); |
| 609 | |
| 610 | vk::CommandGraphNode *node = nullptr; |
| 611 | ANGLE_TRY(getCommandGraphNodeForDraw(contextVk, &node)); |
| 612 | |
| 613 | // This pipeline desc could be cached. |
| 614 | vk::PipelineDesc pipelineDesc; |
| 615 | pipelineDesc.initDefaults(); |
| 616 | pipelineDesc.updateColorWriteMask(colorMaskFlags); |
| 617 | pipelineDesc.updateRenderPassDesc(getRenderPassDesc()); |
jchen10 | be7f44f | 2018-05-21 14:35:32 +0800 | [diff] [blame] | 618 | pipelineDesc.updateShaders(fullScreenQuad->queueSerial(), pushConstantColor->queueSerial()); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 619 | pipelineDesc.updateViewport(node->getRenderPassRenderArea(), 0.0f, 1.0f); |
| 620 | |
| 621 | const gl::State &glState = contextVk->getGLState(); |
| 622 | if (glState.isScissorTestEnabled()) |
| 623 | { |
| 624 | gl::Rectangle intersection; |
| 625 | if (!gl::ClipRectangle(glState.getScissor(), node->getRenderPassRenderArea(), |
| 626 | &intersection)) |
| 627 | { |
| 628 | return gl::NoError(); |
| 629 | } |
| 630 | |
| 631 | pipelineDesc.updateScissor(intersection); |
| 632 | } |
| 633 | else |
| 634 | { |
| 635 | pipelineDesc.updateScissor(node->getRenderPassRenderArea()); |
| 636 | } |
| 637 | |
| 638 | vk::PipelineAndSerial *pipeline = nullptr; |
jchen10 | be7f44f | 2018-05-21 14:35:32 +0800 | [diff] [blame] | 639 | ANGLE_TRY(renderer->getInternalPipeline(*fullScreenQuad, *pushConstantColor, *pipelineLayout, |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 640 | pipelineDesc, gl::AttributesMask(), &pipeline)); |
| 641 | pipeline->updateSerial(renderer->getCurrentQueueSerial()); |
| 642 | |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 643 | |
| 644 | vk::CommandBuffer *drawCommandBuffer = nullptr; |
| 645 | ANGLE_TRY(node->beginInsideRenderPassRecording(renderer, &drawCommandBuffer)); |
| 646 | |
jchen10 | be7f44f | 2018-05-21 14:35:32 +0800 | [diff] [blame] | 647 | VkClearColorValue clearColorValue = contextVk->getClearColorValue().color; |
| 648 | drawCommandBuffer->pushConstants(*pipelineLayout, VK_SHADER_STAGE_FRAGMENT_BIT, 0, |
| 649 | sizeof(VkClearColorValue), clearColorValue.float32); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 650 | |
| 651 | // TODO(jmadill): Masked combined color and depth/stencil clear. http://anglebug.com/2455 |
| 652 | // Any active queries submitted by the user should also be paused here. |
| 653 | drawCommandBuffer->bindPipeline(VK_PIPELINE_BIND_POINT_GRAPHICS, pipeline->get()); |
| 654 | drawCommandBuffer->draw(6, 1, 0, 0); |
| 655 | |
| 656 | return gl::NoError(); |
| 657 | } |
| 658 | |
Geoff Lang | 1345507 | 2018-05-09 11:24:43 -0400 | [diff] [blame] | 659 | gl::Error FramebufferVk::getSamplePosition(const gl::Context *context, |
| 660 | size_t index, |
| 661 | GLfloat *xy) const |
JiangYizhou | bddc46b | 2016-12-09 09:50:51 +0800 | [diff] [blame] | 662 | { |
| 663 | UNIMPLEMENTED(); |
| 664 | return gl::InternalError() << "getSamplePosition is unimplemented."; |
| 665 | } |
| 666 | |
Jamie Madill | b90779e | 2018-04-27 11:45:01 -0400 | [diff] [blame] | 667 | gl::Error FramebufferVk::getCommandGraphNodeForDraw(ContextVk *contextVk, |
Jamie Madill | e4c5a23 | 2018-03-02 21:00:31 -0500 | [diff] [blame] | 668 | vk::CommandGraphNode **nodeOut) |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 669 | { |
Jamie Madill | 49ac74b | 2017-12-21 14:42:33 -0500 | [diff] [blame] | 670 | RendererVk *renderer = contextVk->getRenderer(); |
| 671 | Serial currentSerial = renderer->getCurrentQueueSerial(); |
Jamie Madill | bef918c | 2017-12-13 13:11:30 -0500 | [diff] [blame] | 672 | |
Jamie Madill | 9cceac4 | 2018-03-31 14:19:16 -0400 | [diff] [blame] | 673 | // This will reset the current writing node if it has been completed. |
| 674 | updateQueueSerial(currentSerial); |
| 675 | |
| 676 | if (hasChildlessWritingNode()) |
Jamie Madill | 4c26fc2 | 2017-02-24 11:04:10 -0500 | [diff] [blame] | 677 | { |
Jamie Madill | 9cceac4 | 2018-03-31 14:19:16 -0400 | [diff] [blame] | 678 | *nodeOut = getCurrentWritingNode(); |
| 679 | } |
| 680 | else |
| 681 | { |
| 682 | *nodeOut = getNewWritingNode(renderer); |
Jamie Madill | 4c26fc2 | 2017-02-24 11:04:10 -0500 | [diff] [blame] | 683 | } |
| 684 | |
Jamie Madill | 9cceac4 | 2018-03-31 14:19:16 -0400 | [diff] [blame] | 685 | if ((*nodeOut)->getInsideRenderPassCommands()->valid()) |
| 686 | { |
| 687 | return gl::NoError(); |
| 688 | } |
Jamie Madill | 4c26fc2 | 2017-02-24 11:04:10 -0500 | [diff] [blame] | 689 | |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 690 | vk::Framebuffer *framebuffer = nullptr; |
Jamie Madill | b90779e | 2018-04-27 11:45:01 -0400 | [diff] [blame] | 691 | ANGLE_TRY_RESULT(getFramebuffer(renderer), framebuffer); |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 692 | |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 693 | std::vector<VkClearValue> attachmentClearValues; |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 694 | |
Jamie Madill | 9cceac4 | 2018-03-31 14:19:16 -0400 | [diff] [blame] | 695 | if (!(*nodeOut)->getOutsideRenderPassCommands()->valid()) |
| 696 | { |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame^] | 697 | vk::CommandBuffer *commandBuffer = nullptr; |
Jamie Madill | 9cceac4 | 2018-03-31 14:19:16 -0400 | [diff] [blame] | 698 | ANGLE_TRY((*nodeOut)->beginOutsideRenderPassRecording( |
| 699 | renderer->getDevice(), renderer->getCommandPool(), &commandBuffer)); |
| 700 | } |
Jamie Madill | e4c5a23 | 2018-03-02 21:00:31 -0500 | [diff] [blame] | 701 | |
Jamie Madill | 49ac74b | 2017-12-21 14:42:33 -0500 | [diff] [blame] | 702 | // Initialize RenderPass info. |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 703 | // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394 |
| 704 | const auto &colorRenderTargets = mRenderTargetCache.getColors(); |
| 705 | for (size_t colorIndex : mState.getEnabledDrawBuffers()) |
Jamie Madill | 4c26fc2 | 2017-02-24 11:04:10 -0500 | [diff] [blame] | 706 | { |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 707 | RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex]; |
| 708 | ASSERT(colorRenderTarget); |
Jamie Madill | 49ac74b | 2017-12-21 14:42:33 -0500 | [diff] [blame] | 709 | |
Jamie Madill | 9cceac4 | 2018-03-31 14:19:16 -0400 | [diff] [blame] | 710 | (*nodeOut)->appendColorRenderTarget(currentSerial, colorRenderTarget); |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 711 | attachmentClearValues.emplace_back(contextVk->getClearColorValue()); |
| 712 | } |
| 713 | |
| 714 | RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil(); |
| 715 | if (depthStencilRenderTarget) |
| 716 | { |
Jamie Madill | 9cceac4 | 2018-03-31 14:19:16 -0400 | [diff] [blame] | 717 | (*nodeOut)->appendDepthStencilRenderTarget(currentSerial, depthStencilRenderTarget); |
Jamie Madill | f4d693c | 2018-02-14 16:38:16 -0500 | [diff] [blame] | 718 | attachmentClearValues.emplace_back(contextVk->getClearDepthStencilValue()); |
Jamie Madill | 49ac74b | 2017-12-21 14:42:33 -0500 | [diff] [blame] | 719 | } |
| 720 | |
Luc Ferron | d17bdfe | 2018-04-05 13:50:10 -0400 | [diff] [blame] | 721 | gl::Rectangle renderArea = |
| 722 | gl::Rectangle(0, 0, mState.getDimensions().width, mState.getDimensions().height); |
Jamie Madill | f4d693c | 2018-02-14 16:38:16 -0500 | [diff] [blame] | 723 | // Hard-code RenderPass to clear the first render target to the current clear value. |
| 724 | // TODO(jmadill): Proper clear value implementation. http://anglebug.com/2361 |
Luc Ferron | d17bdfe | 2018-04-05 13:50:10 -0400 | [diff] [blame] | 725 | (*nodeOut)->storeRenderPassInfo(*framebuffer, renderArea, attachmentClearValues); |
Jamie Madill | 49ac74b | 2017-12-21 14:42:33 -0500 | [diff] [blame] | 726 | |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 727 | return gl::NoError(); |
| 728 | } |
| 729 | |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 730 | void FramebufferVk::updateActiveColorMasks(size_t colorIndex, bool r, bool g, bool b, bool a) |
| 731 | { |
| 732 | mActiveColorComponentMasks[0].set(colorIndex, r); |
| 733 | mActiveColorComponentMasks[1].set(colorIndex, g); |
| 734 | mActiveColorComponentMasks[2].set(colorIndex, b); |
| 735 | mActiveColorComponentMasks[3].set(colorIndex, a); |
| 736 | } |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 737 | |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame^] | 738 | gl::Error FramebufferVk::readPixelsImpl(const gl::Context *context, |
| 739 | const gl::Rectangle &area, |
| 740 | const PackPixelsParams &packPixelsParams, |
| 741 | void *pixels) |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 742 | { |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame^] | 743 | ContextVk *contextVk = vk::GetImpl(context); |
| 744 | RendererVk *renderer = contextVk->getRenderer(); |
| 745 | |
| 746 | if (!mReadPixelsBuffer.valid()) |
| 747 | { |
| 748 | mReadPixelsBuffer.init(1, renderer); |
| 749 | ASSERT(mReadPixelsBuffer.valid()); |
| 750 | } |
| 751 | |
| 752 | vk::CommandBuffer *commandBuffer = nullptr; |
| 753 | ANGLE_TRY(beginWriteResource(renderer, &commandBuffer)); |
| 754 | |
| 755 | RenderTargetVk *renderTarget = getColorReadRenderTarget(); |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 756 | |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 757 | vk::ImageHelper *renderTargetImage = renderTarget->image; |
| 758 | const angle::Format &angleFormat = renderTargetImage->getFormat().textureFormat(); |
| 759 | VkBuffer bufferHandle = VK_NULL_HANDLE; |
| 760 | uint8_t *readPixelBuffer = nullptr; |
| 761 | bool newBufferAllocated = false; |
| 762 | uint32_t stagingOffset = 0; |
| 763 | size_t allocationSize = area.width * angleFormat.pixelBytes * area.height; |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 764 | |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame^] | 765 | mReadPixelsBuffer.allocate(renderer, allocationSize, &readPixelBuffer, &bufferHandle, |
| 766 | &stagingOffset, &newBufferAllocated); |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 767 | |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 768 | VkBufferImageCopy region; |
| 769 | region.bufferImageHeight = area.height; |
| 770 | region.bufferOffset = static_cast<VkDeviceSize>(stagingOffset); |
| 771 | region.bufferRowLength = area.width; |
| 772 | region.imageExtent.width = area.width; |
| 773 | region.imageExtent.height = area.height; |
| 774 | region.imageExtent.depth = 1; |
| 775 | region.imageOffset.x = area.x; |
| 776 | region.imageOffset.y = area.y; |
| 777 | region.imageOffset.z = 0; |
| 778 | region.imageSubresource.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT; |
| 779 | region.imageSubresource.baseArrayLayer = 0; |
| 780 | region.imageSubresource.layerCount = 1; |
| 781 | region.imageSubresource.mipLevel = 0; |
| 782 | |
| 783 | renderTargetImage->changeLayoutWithStages( |
| 784 | VK_IMAGE_ASPECT_COLOR_BIT, VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, |
| 785 | VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, commandBuffer); |
| 786 | |
| 787 | commandBuffer->copyImageToBuffer(renderTargetImage->getImage(), |
| 788 | renderTargetImage->getCurrentLayout(), bufferHandle, 1, |
| 789 | ®ion); |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 790 | |
| 791 | // Triggers a full finish. |
| 792 | // TODO(jmadill): Don't block on asynchronous readback. |
| 793 | ANGLE_TRY(renderer->finish(context)); |
| 794 | |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 795 | // The buffer we copied to needs to be invalidated before we read from it because its not been |
| 796 | // created with the host coherent bit. |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame^] | 797 | ANGLE_TRY(mReadPixelsBuffer.invalidate(renderer->getDevice())); |
Yuly Novikov | 6c6c76c | 2018-05-17 18:45:06 +0000 | [diff] [blame] | 798 | |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 799 | PackPixels(packPixelsParams, angleFormat, area.width * angleFormat.pixelBytes, readPixelBuffer, |
| 800 | reinterpret_cast<uint8_t *>(pixels)); |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 801 | |
| 802 | return vk::NoError(); |
| 803 | } |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame^] | 804 | |
| 805 | const gl::Extents &FramebufferVk::getReadImageExtents() const |
| 806 | { |
| 807 | return getColorReadRenderTarget()->image->getExtents(); |
| 808 | } |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 809 | } // namespace rx |