Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 1 | /* Copyright (c) 2015-2017 The Khronos Group Inc. |
| 2 | * Copyright (c) 2015-2017 Valve Corporation |
| 3 | * Copyright (c) 2015-2017 LunarG, Inc. |
| 4 | * Copyright (C) 2015-2017 Google Inc. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 6 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 7 | * you may not use this file except in compliance with the License. |
| 8 | * You may obtain a copy of the License at |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 10 | * http://www.apache.org/licenses/LICENSE-2.0 |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 12 | * Unless required by applicable law or agreed to in writing, software |
| 13 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 14 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 15 | * See the License for the specific language governing permissions and |
| 16 | * limitations under the License. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 17 | * |
| 18 | * Author: Cody Northrop <cnorthrop@google.com> |
| 19 | * Author: Michael Lentine <mlentine@google.com> |
| 20 | * Author: Tobin Ehlis <tobine@google.com> |
| 21 | * Author: Chia-I Wu <olv@google.com> |
| 22 | * Author: Chris Forbes <chrisf@ijw.co.nz> |
| 23 | * Author: Mark Lobodzinski <mark@lunarg.com> |
| 24 | * Author: Ian Elliott <ianelliott@google.com> |
Mark Lobodzinski | 9ea3d38 | 2017-01-11 15:25:28 -0700 | [diff] [blame] | 25 | * Author: Dave Houlton <daveh@lunarg.com> |
| 26 | * Author: Dustin Graves <dustin@lunarg.com> |
| 27 | * Author: Jeremy Hayes <jeremy@lunarg.com> |
| 28 | * Author: Jon Ashburn <jon@lunarg.com> |
| 29 | * Author: Karl Schultz <karl@lunarg.com> |
| 30 | * Author: Mark Young <marky@lunarg.com> |
| 31 | * Author: Mike Schuchardt <mikes@lunarg.com> |
| 32 | * Author: Mike Weiblen <mikew@lunarg.com> |
| 33 | * Author: Tony Barbour <tony@LunarG.com> |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 34 | */ |
| 35 | |
| 36 | // Allow use of STL min and max functions in Windows |
| 37 | #define NOMINMAX |
| 38 | |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 39 | #include <SPIRV/spirv.hpp> |
| 40 | #include <algorithm> |
| 41 | #include <assert.h> |
| 42 | #include <iostream> |
| 43 | #include <list> |
| 44 | #include <map> |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 45 | #include <mutex> |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 46 | #include <set> |
Mark Lobodzinski | 9acd2e3 | 2016-12-21 15:22:39 -0700 | [diff] [blame] | 47 | #include <sstream> |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 48 | #include <stdio.h> |
| 49 | #include <stdlib.h> |
| 50 | #include <string.h> |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 51 | #include <string> |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 52 | #include <tuple> |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 53 | |
| 54 | #include "vk_loader_platform.h" |
| 55 | #include "vk_dispatch_table_helper.h" |
Mark Lobodzinski | 9acd2e3 | 2016-12-21 15:22:39 -0700 | [diff] [blame] | 56 | #include "vk_enum_string_helper.h" |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 57 | #if defined(__GNUC__) |
| 58 | #pragma GCC diagnostic ignored "-Wwrite-strings" |
| 59 | #endif |
| 60 | #if defined(__GNUC__) |
| 61 | #pragma GCC diagnostic warning "-Wwrite-strings" |
| 62 | #endif |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 63 | #include "core_validation.h" |
Mark Lobodzinski | 42fe5f7 | 2017-01-11 11:36:16 -0700 | [diff] [blame^] | 64 | #include "buffer_validation.h" |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 65 | #include "vk_layer_table.h" |
| 66 | #include "vk_layer_data.h" |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 67 | #include "vk_layer_extension_utils.h" |
| 68 | #include "vk_layer_utils.h" |
Chris Forbes | b4afd0f | 2016-04-04 10:48:35 +1200 | [diff] [blame] | 69 | #include "spirv-tools/libspirv.h" |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 70 | |
| 71 | #if defined __ANDROID__ |
| 72 | #include <android/log.h> |
| 73 | #define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) |
| 74 | #else |
Michael Lentine | 860b0fe | 2016-05-20 10:14:00 -0500 | [diff] [blame] | 75 | #define LOGCONSOLE(...) \ |
| 76 | { \ |
| 77 | printf(__VA_ARGS__); \ |
| 78 | printf("\n"); \ |
| 79 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 80 | #endif |
| 81 | |
Mike Stroyan | b985fca | 2016-11-01 11:50:16 -0600 | [diff] [blame] | 82 | // This intentionally includes a cpp file |
| 83 | #include "vk_safe_struct.cpp" |
| 84 | |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 85 | using namespace std; |
| 86 | |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 87 | namespace core_validation { |
| 88 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 89 | using std::unordered_map; |
| 90 | using std::unordered_set; |
| 91 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 92 | // WSI Image Objects bypass usual Image Object creation methods. A special Memory |
| 93 | // Object value will be used to identify them internally. |
| 94 | static const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 95 | // 2nd special memory handle used to flag object as unbound from memory |
| 96 | static const VkDeviceMemory MEMORY_UNBOUND = VkDeviceMemory(~((uint64_t)(0)) - 1); |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 97 | |
Jamie Madill | 6069c82 | 2016-12-15 09:35:36 -0500 | [diff] [blame] | 98 | // A special value of (0xFFFFFFFF, 0xFFFFFFFF) indicates that the surface size will be determined |
| 99 | // by the extent of a swapchain targeting the surface. |
| 100 | static const uint32_t kSurfaceSizeFromSwapchain = 0xFFFFFFFFu; |
| 101 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 102 | struct devExts { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 103 | bool wsi_enabled; |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 104 | bool wsi_display_swapchain_enabled; |
Tobin Ehlis | 80c9afa | 2016-06-02 12:45:31 -0600 | [diff] [blame] | 105 | unordered_map<VkSwapchainKHR, unique_ptr<SWAPCHAIN_NODE>> swapchainMap; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 106 | unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; |
| 107 | }; |
| 108 | |
| 109 | // fwd decls |
| 110 | struct shader_module; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 111 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 112 | struct instance_layer_data { |
Chris Forbes | 5ce44e3 | 2016-10-03 17:18:42 +1300 | [diff] [blame] | 113 | VkInstance instance = VK_NULL_HANDLE; |
Chris Forbes | 5ce44e3 | 2016-10-03 17:18:42 +1300 | [diff] [blame] | 114 | debug_report_data *report_data = nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 115 | std::vector<VkDebugReportCallbackEXT> logging_callback; |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 116 | VkLayerInstanceDispatchTable dispatch_table; |
| 117 | |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 118 | CALL_STATE vkEnumeratePhysicalDevicesState = UNCALLED; |
| 119 | uint32_t physical_devices_count = 0; |
| 120 | CHECK_DISABLED disabled = {}; |
| 121 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 122 | unordered_map<VkPhysicalDevice, PHYSICAL_DEVICE_STATE> physical_device_map; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 123 | unordered_map<VkSurfaceKHR, SURFACE_STATE> surface_map; |
| 124 | |
| 125 | bool surfaceExtensionEnabled = false; |
| 126 | bool displayExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 127 | bool androidSurfaceExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 128 | bool mirSurfaceExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 129 | bool waylandSurfaceExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 130 | bool win32SurfaceExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 131 | bool xcbSurfaceExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 132 | bool xlibSurfaceExtensionEnabled = false; |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 133 | }; |
| 134 | |
| 135 | struct layer_data { |
| 136 | debug_report_data *report_data = nullptr; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 137 | VkLayerDispatchTable dispatch_table; |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 138 | |
Chris Forbes | 5ce44e3 | 2016-10-03 17:18:42 +1300 | [diff] [blame] | 139 | devExts device_extensions = {}; |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 140 | unordered_set<VkQueue> queues; // All queues under given device |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 141 | // Global set of all cmdBuffers that are inFlight on this device |
| 142 | unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; |
| 143 | // Layer specific data |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 144 | unordered_map<VkSampler, unique_ptr<SAMPLER_STATE>> samplerMap; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 145 | unordered_map<VkImageView, unique_ptr<IMAGE_VIEW_STATE>> imageViewMap; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 146 | unordered_map<VkImage, unique_ptr<IMAGE_STATE>> imageMap; |
Tobin Ehlis | 8b87246 | 2016-09-14 08:12:08 -0600 | [diff] [blame] | 147 | unordered_map<VkBufferView, unique_ptr<BUFFER_VIEW_STATE>> bufferViewMap; |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 148 | unordered_map<VkBuffer, unique_ptr<BUFFER_STATE>> bufferMap; |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 149 | unordered_map<VkPipeline, PIPELINE_STATE *> pipelineMap; |
Chris Forbes | 456c07a | 2016-06-21 13:04:18 +1200 | [diff] [blame] | 150 | unordered_map<VkCommandPool, COMMAND_POOL_NODE> commandPoolMap; |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 151 | unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_STATE *> descriptorPoolMap; |
Tobin Ehlis | 05be5df | 2016-05-05 08:25:02 -0600 | [diff] [blame] | 152 | unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; |
Tobin Ehlis | 0a43bde | 2016-05-03 08:31:08 -0600 | [diff] [blame] | 153 | unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 154 | unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 155 | unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 156 | unordered_map<VkFence, FENCE_NODE> fenceMap; |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 157 | unordered_map<VkQueue, QUEUE_STATE> queueMap; |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 158 | unordered_map<VkEvent, EVENT_STATE> eventMap; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 159 | unordered_map<QueryObject, bool> queryToStateMap; |
| 160 | unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; |
| 161 | unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 162 | unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 163 | unordered_map<VkFramebuffer, unique_ptr<FRAMEBUFFER_STATE>> frameBufferMap; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 164 | unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; |
| 165 | unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 166 | unordered_map<VkRenderPass, unique_ptr<RENDER_PASS_STATE>> renderPassMap; |
Chris Forbes | 90da2e9 | 2016-03-18 16:30:03 +1300 | [diff] [blame] | 167 | unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; |
Mark Lobodzinski | e6ce3f6 | 2016-12-10 10:53:34 -0700 | [diff] [blame] | 168 | |
Chris Forbes | 5ce44e3 | 2016-10-03 17:18:42 +1300 | [diff] [blame] | 169 | VkDevice device = VK_NULL_HANDLE; |
Mark Lobodzinski | cf0f7b6 | 2016-11-16 12:12:56 -0700 | [diff] [blame] | 170 | VkPhysicalDevice physical_device = VK_NULL_HANDLE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 171 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 172 | instance_layer_data *instance_data = nullptr; // from device to enclosing instance |
Chris Forbes | 2e6c494 | 2016-10-03 17:44:52 +1300 | [diff] [blame] | 173 | |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 174 | VkPhysicalDeviceFeatures enabled_features = {}; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 175 | // Device specific data |
Chris Forbes | 5ce44e3 | 2016-10-03 17:18:42 +1300 | [diff] [blame] | 176 | PHYS_DEV_PROPERTIES_NODE phys_dev_properties = {}; |
| 177 | VkPhysicalDeviceMemoryProperties phys_dev_mem_props = {}; |
Mark Lobodzinski | f685859 | 2017-01-11 09:34:01 -0700 | [diff] [blame] | 178 | VkPhysicalDeviceProperties phys_dev_props = {}; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 179 | }; |
| 180 | |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 181 | // TODO : Do we need to guard access to layer_data_map w/ lock? |
| 182 | static unordered_map<void *, layer_data *> layer_data_map; |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 183 | static unordered_map<void *, instance_layer_data *> instance_layer_data_map; |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 184 | |
Chia-I Wu | d199274 | 2016-05-06 11:36:52 +0800 | [diff] [blame] | 185 | static const VkLayerProperties global_layer = { |
Jon Ashburn | dc9111c | 2016-03-22 12:57:13 -0600 | [diff] [blame] | 186 | "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", |
Chia-I Wu | d199274 | 2016-05-06 11:36:52 +0800 | [diff] [blame] | 187 | }; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 188 | |
| 189 | template <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { |
| 190 | bool foundLayer = false; |
| 191 | for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { |
Chia-I Wu | d199274 | 2016-05-06 11:36:52 +0800 | [diff] [blame] | 192 | if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 193 | foundLayer = true; |
| 194 | } |
| 195 | // This has to be logged to console as we don't have a callback at this point. |
| 196 | if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { |
| 197 | LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", |
Chia-I Wu | d199274 | 2016-05-06 11:36:52 +0800 | [diff] [blame] | 198 | global_layer.layerName); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 199 | } |
| 200 | } |
| 201 | } |
| 202 | |
| 203 | // Code imported from shader_checker |
| 204 | static void build_def_index(shader_module *); |
| 205 | |
| 206 | // A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words |
| 207 | // without the caller needing to care too much about the physical SPIRV module layout. |
| 208 | struct spirv_inst_iter { |
| 209 | std::vector<uint32_t>::const_iterator zero; |
| 210 | std::vector<uint32_t>::const_iterator it; |
| 211 | |
Chris Forbes | ce7d7e0 | 2016-05-11 11:44:12 +1200 | [diff] [blame] | 212 | uint32_t len() { |
| 213 | auto result = *it >> 16; |
| 214 | assert(result > 0); |
| 215 | return result; |
| 216 | } |
| 217 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 218 | uint32_t opcode() { return *it & 0x0ffffu; } |
Chris Forbes | ce7d7e0 | 2016-05-11 11:44:12 +1200 | [diff] [blame] | 219 | |
| 220 | uint32_t const &word(unsigned n) { |
| 221 | assert(n < len()); |
| 222 | return it[n]; |
| 223 | } |
| 224 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 225 | uint32_t offset() { return (uint32_t)(it - zero); } |
| 226 | |
| 227 | spirv_inst_iter() {} |
| 228 | |
| 229 | spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} |
| 230 | |
| 231 | bool operator==(spirv_inst_iter const &other) { return it == other.it; } |
| 232 | |
| 233 | bool operator!=(spirv_inst_iter const &other) { return it != other.it; } |
| 234 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 235 | spirv_inst_iter operator++(int) { // x++ |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 236 | spirv_inst_iter ii = *this; |
| 237 | it += len(); |
| 238 | return ii; |
| 239 | } |
| 240 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 241 | spirv_inst_iter operator++() { // ++x; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 242 | it += len(); |
| 243 | return *this; |
| 244 | } |
| 245 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 246 | // The iterator and the value are the same thing. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 247 | spirv_inst_iter &operator*() { return *this; } |
| 248 | spirv_inst_iter const &operator*() const { return *this; } |
| 249 | }; |
| 250 | |
| 251 | struct shader_module { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 252 | // The spirv image itself |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 253 | vector<uint32_t> words; |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 254 | // A mapping of <id> to the first word of its def. this is useful because walking type |
| 255 | // trees, constant expressions, etc requires jumping all over the instruction stream. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 256 | unordered_map<unsigned, unsigned> def_index; |
| 257 | |
| 258 | shader_module(VkShaderModuleCreateInfo const *pCreateInfo) |
| 259 | : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), |
| 260 | def_index() { |
| 261 | |
| 262 | build_def_index(this); |
| 263 | } |
| 264 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 265 | // Expose begin() / end() to enable range-based for |
| 266 | spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } // First insn |
| 267 | spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } // Just past last insn |
| 268 | // Given an offset into the module, produce an iterator there. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 269 | spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } |
| 270 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 271 | // Gets an iterator to the definition of an id |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 272 | spirv_inst_iter get_def(unsigned id) const { |
| 273 | auto it = def_index.find(id); |
| 274 | if (it == def_index.end()) { |
| 275 | return end(); |
| 276 | } |
| 277 | return at(it->second); |
| 278 | } |
| 279 | }; |
| 280 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 281 | // TODO : This can be much smarter, using separate locks for separate global data |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 282 | static std::mutex global_lock; |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 283 | |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 284 | // Return IMAGE_VIEW_STATE ptr for specified imageView or else NULL |
| 285 | IMAGE_VIEW_STATE *getImageViewState(const layer_data *dev_data, VkImageView image_view) { |
Tobin Ehlis | d5fb09e | 2016-06-02 10:54:09 -0600 | [diff] [blame] | 286 | auto iv_it = dev_data->imageViewMap.find(image_view); |
| 287 | if (iv_it == dev_data->imageViewMap.end()) { |
| 288 | return nullptr; |
| 289 | } |
| 290 | return iv_it->second.get(); |
| 291 | } |
Tobin Ehlis | e2f8029 | 2016-06-02 10:08:53 -0600 | [diff] [blame] | 292 | // Return sampler node ptr for specified sampler or else NULL |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 293 | SAMPLER_STATE *getSamplerState(const layer_data *dev_data, VkSampler sampler) { |
Tobin Ehlis | d5fb09e | 2016-06-02 10:54:09 -0600 | [diff] [blame] | 294 | auto sampler_it = dev_data->samplerMap.find(sampler); |
| 295 | if (sampler_it == dev_data->samplerMap.end()) { |
Tobin Ehlis | e2f8029 | 2016-06-02 10:08:53 -0600 | [diff] [blame] | 296 | return nullptr; |
| 297 | } |
| 298 | return sampler_it->second.get(); |
| 299 | } |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 300 | // Return image state ptr for specified image or else NULL |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 301 | IMAGE_STATE *getImageState(const layer_data *dev_data, VkImage image) { |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 302 | auto img_it = dev_data->imageMap.find(image); |
| 303 | if (img_it == dev_data->imageMap.end()) { |
| 304 | return nullptr; |
| 305 | } |
| 306 | return img_it->second.get(); |
| 307 | } |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 308 | // Return buffer state ptr for specified buffer or else NULL |
| 309 | BUFFER_STATE *getBufferState(const layer_data *dev_data, VkBuffer buffer) { |
Tobin Ehlis | d5fb09e | 2016-06-02 10:54:09 -0600 | [diff] [blame] | 310 | auto buff_it = dev_data->bufferMap.find(buffer); |
| 311 | if (buff_it == dev_data->bufferMap.end()) { |
Tobin Ehlis | 94bc5d2 | 2016-06-02 07:46:52 -0600 | [diff] [blame] | 312 | return nullptr; |
| 313 | } |
| 314 | return buff_it->second.get(); |
| 315 | } |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 316 | // Return swapchain node for specified swapchain or else NULL |
Tobin Ehlis | e83a46a | 2016-06-02 12:48:25 -0600 | [diff] [blame] | 317 | SWAPCHAIN_NODE *getSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 318 | auto swp_it = dev_data->device_extensions.swapchainMap.find(swapchain); |
| 319 | if (swp_it == dev_data->device_extensions.swapchainMap.end()) { |
| 320 | return nullptr; |
| 321 | } |
Tobin Ehlis | 80c9afa | 2016-06-02 12:45:31 -0600 | [diff] [blame] | 322 | return swp_it->second.get(); |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 323 | } |
Tobin Ehlis | 969a526 | 2016-06-02 12:13:32 -0600 | [diff] [blame] | 324 | // Return swapchain for specified image or else NULL |
Tobin Ehlis | e83a46a | 2016-06-02 12:48:25 -0600 | [diff] [blame] | 325 | VkSwapchainKHR getSwapchainFromImage(const layer_data *dev_data, VkImage image) { |
Tobin Ehlis | 969a526 | 2016-06-02 12:13:32 -0600 | [diff] [blame] | 326 | auto img_it = dev_data->device_extensions.imageToSwapchainMap.find(image); |
| 327 | if (img_it == dev_data->device_extensions.imageToSwapchainMap.end()) { |
| 328 | return VK_NULL_HANDLE; |
| 329 | } |
| 330 | return img_it->second; |
| 331 | } |
Tobin Ehlis | 424859c | 2016-06-02 09:43:11 -0600 | [diff] [blame] | 332 | // Return buffer node ptr for specified buffer or else NULL |
Tobin Ehlis | 8b87246 | 2016-09-14 08:12:08 -0600 | [diff] [blame] | 333 | BUFFER_VIEW_STATE *getBufferViewState(const layer_data *my_data, VkBufferView buffer_view) { |
Tobin Ehlis | 424859c | 2016-06-02 09:43:11 -0600 | [diff] [blame] | 334 | auto bv_it = my_data->bufferViewMap.find(buffer_view); |
| 335 | if (bv_it == my_data->bufferViewMap.end()) { |
| 336 | return nullptr; |
| 337 | } |
| 338 | return bv_it->second.get(); |
| 339 | } |
Tobin Ehlis | 94bc5d2 | 2016-06-02 07:46:52 -0600 | [diff] [blame] | 340 | |
Chris Forbes | a70b6e1 | 2016-06-10 15:21:43 +1200 | [diff] [blame] | 341 | FENCE_NODE *getFenceNode(layer_data *dev_data, VkFence fence) { |
| 342 | auto it = dev_data->fenceMap.find(fence); |
| 343 | if (it == dev_data->fenceMap.end()) { |
| 344 | return nullptr; |
| 345 | } |
| 346 | return &it->second; |
| 347 | } |
| 348 | |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 349 | EVENT_STATE *getEventNode(layer_data *dev_data, VkEvent event) { |
Tobin Ehlis | cab6b7d | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 350 | auto it = dev_data->eventMap.find(event); |
| 351 | if (it == dev_data->eventMap.end()) { |
| 352 | return nullptr; |
| 353 | } |
| 354 | return &it->second; |
| 355 | } |
| 356 | |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 357 | QUERY_POOL_NODE *getQueryPoolNode(layer_data *dev_data, VkQueryPool query_pool) { |
| 358 | auto it = dev_data->queryPoolMap.find(query_pool); |
| 359 | if (it == dev_data->queryPoolMap.end()) { |
| 360 | return nullptr; |
| 361 | } |
| 362 | return &it->second; |
| 363 | } |
| 364 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 365 | QUEUE_STATE *getQueueState(layer_data *dev_data, VkQueue queue) { |
Chris Forbes | a70b6e1 | 2016-06-10 15:21:43 +1200 | [diff] [blame] | 366 | auto it = dev_data->queueMap.find(queue); |
| 367 | if (it == dev_data->queueMap.end()) { |
| 368 | return nullptr; |
| 369 | } |
| 370 | return &it->second; |
| 371 | } |
| 372 | |
Chris Forbes | 28b668e | 2016-06-16 12:17:09 +1200 | [diff] [blame] | 373 | SEMAPHORE_NODE *getSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { |
| 374 | auto it = dev_data->semaphoreMap.find(semaphore); |
| 375 | if (it == dev_data->semaphoreMap.end()) { |
| 376 | return nullptr; |
| 377 | } |
| 378 | return &it->second; |
| 379 | } |
| 380 | |
Chris Forbes | 456c07a | 2016-06-21 13:04:18 +1200 | [diff] [blame] | 381 | COMMAND_POOL_NODE *getCommandPoolNode(layer_data *dev_data, VkCommandPool pool) { |
| 382 | auto it = dev_data->commandPoolMap.find(pool); |
| 383 | if (it == dev_data->commandPoolMap.end()) { |
| 384 | return nullptr; |
| 385 | } |
| 386 | return &it->second; |
| 387 | } |
Chris Forbes | 8245eba | 2016-10-03 17:36:32 +1300 | [diff] [blame] | 388 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 389 | PHYSICAL_DEVICE_STATE *getPhysicalDeviceState(instance_layer_data *instance_data, VkPhysicalDevice phys) { |
| 390 | auto it = instance_data->physical_device_map.find(phys); |
| 391 | if (it == instance_data->physical_device_map.end()) { |
Chris Forbes | 8245eba | 2016-10-03 17:36:32 +1300 | [diff] [blame] | 392 | return nullptr; |
| 393 | } |
| 394 | return &it->second; |
| 395 | } |
| 396 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 397 | SURFACE_STATE *getSurfaceState(instance_layer_data *instance_data, VkSurfaceKHR surface) { |
| 398 | auto it = instance_data->surface_map.find(surface); |
| 399 | if (it == instance_data->surface_map.end()) { |
| 400 | return nullptr; |
| 401 | } |
| 402 | return &it->second; |
| 403 | } |
| 404 | |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 405 | // Return ptr to memory binding for given handle of specified type |
| 406 | static BINDABLE *GetObjectMemBinding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 407 | switch (type) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 408 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: |
| 409 | return getImageState(my_data, VkImage(handle)); |
| 410 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 411 | return getBufferState(my_data, VkBuffer(handle)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 412 | default: |
| 413 | break; |
| 414 | } |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 415 | return nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 416 | } |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 417 | // prototype |
Chris Forbes | 664ca7f | 2016-05-06 16:55:18 +1200 | [diff] [blame] | 418 | static GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 419 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 420 | // Helper function to validate correct usage bits set for buffers or images |
| 421 | // Verify that (actual & desired) flags != 0 or, |
| 422 | // if strict is true, verify that (actual & desired) flags == desired |
| 423 | // In case of error, report it via dbg callbacks |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 424 | static bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, uint64_t obj_handle, |
| 425 | VkDebugReportObjectTypeEXT obj_type, int32_t const msgCode, char const *ty_str, |
| 426 | char const *func_name, char const *usage_str) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 427 | bool correct_usage = false; |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 428 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 429 | if (strict) |
| 430 | correct_usage = ((actual & desired) == desired); |
| 431 | else |
| 432 | correct_usage = ((actual & desired) != 0); |
| 433 | if (!correct_usage) { |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 434 | if (msgCode == -1) { |
| 435 | // TODO: Fix callers with msgCode == -1 to use correct validation checks. |
| 436 | skip_call = |
| 437 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, |
| 438 | MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 |
| 439 | " used by %s. In this case, %s should have %s set during creation.", |
| 440 | ty_str, obj_handle, func_name, ty_str, usage_str); |
| 441 | } else { |
| 442 | const char *valid_usage = (msgCode == -1) ? "" : validation_error_map[msgCode]; |
| 443 | skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, msgCode, "MEM", |
| 444 | "Invalid usage flag for %s 0x%" PRIxLEAST64 |
| 445 | " used by %s. In this case, %s should have %s set during creation. %s", |
| 446 | ty_str, obj_handle, func_name, ty_str, usage_str, valid_usage); |
| 447 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 448 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 449 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 450 | } |
| 451 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 452 | // Helper function to validate usage flags for buffers |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 453 | // For given buffer_state send actual vs. desired usage off to helper above where |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 454 | // an error will be flagged if usage is not correct |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 455 | static bool ValidateImageUsageFlags(layer_data *dev_data, IMAGE_STATE const *image_state, VkFlags desired, VkBool32 strict, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 456 | int32_t const msgCode, char const *func_name, char const *usage_string) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 457 | return validate_usage_flags(dev_data, image_state->createInfo.usage, desired, strict, |
| 458 | reinterpret_cast<const uint64_t &>(image_state->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 459 | msgCode, "image", func_name, usage_string); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 460 | } |
| 461 | |
| 462 | // Helper function to validate usage flags for buffers |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 463 | // For given buffer_state send actual vs. desired usage off to helper above where |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 464 | // an error will be flagged if usage is not correct |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 465 | static bool ValidateBufferUsageFlags(layer_data *dev_data, BUFFER_STATE const *buffer_state, VkFlags desired, VkBool32 strict, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 466 | int32_t const msgCode, char const *func_name, char const *usage_string) { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 467 | return validate_usage_flags(dev_data, buffer_state->createInfo.usage, desired, strict, |
| 468 | reinterpret_cast<const uint64_t &>(buffer_state->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 469 | msgCode, "buffer", func_name, usage_string); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 470 | } |
| 471 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 472 | // Return ptr to info in map container containing mem, or NULL if not found |
| 473 | // Calls to this function should be wrapped in mutex |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 474 | DEVICE_MEM_INFO *getMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { |
| 475 | auto mem_it = dev_data->memObjMap.find(mem); |
| 476 | if (mem_it == dev_data->memObjMap.end()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 477 | return NULL; |
| 478 | } |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 479 | return mem_it->second.get(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 480 | } |
| 481 | |
| 482 | static void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, |
| 483 | const VkMemoryAllocateInfo *pAllocateInfo) { |
| 484 | assert(object != NULL); |
| 485 | |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 486 | my_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 487 | } |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 488 | |
| 489 | // Helper function to print lowercase string of object type |
| 490 | // TODO: Unify string helper functions, this should really come out of a string helper if not there already |
| 491 | static const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { |
| 492 | switch (type) { |
| 493 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: |
| 494 | return "image"; |
| 495 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: |
| 496 | return "buffer"; |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 497 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: |
| 498 | return "image view"; |
| 499 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: |
| 500 | return "buffer view"; |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 501 | case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: |
| 502 | return "swapchain"; |
| 503 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: |
| 504 | return "descriptor set"; |
| 505 | case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: |
Tobin Ehlis | b0fcdfa | 2016-09-06 20:37:39 -0600 | [diff] [blame] | 506 | return "framebuffer"; |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 507 | case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: |
| 508 | return "event"; |
| 509 | case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: |
| 510 | return "query pool"; |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 511 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: |
| 512 | return "descriptor pool"; |
| 513 | case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: |
| 514 | return "command pool"; |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 515 | case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: |
| 516 | return "pipeline"; |
| 517 | case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: |
| 518 | return "sampler"; |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 519 | case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: |
| 520 | return "renderpass"; |
| 521 | case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: |
| 522 | return "device memory"; |
Tobin Ehlis | 7d1dd14 | 2016-08-18 08:23:30 -0600 | [diff] [blame] | 523 | case VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT: |
| 524 | return "semaphore"; |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 525 | default: |
| 526 | return "unknown"; |
| 527 | } |
| 528 | } |
| 529 | |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 530 | // For given bound_object_handle, bound to given mem allocation, verify that the range for the bound object is valid |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 531 | static bool ValidateMemoryIsValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t bound_object_handle, |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 532 | VkDebugReportObjectTypeEXT type, const char *functionName) { |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 533 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); |
| 534 | if (mem_info) { |
| 535 | if (!mem_info->bound_ranges[bound_object_handle].valid) { |
Karl Schultz | e52f014 | 2016-09-29 16:11:35 -0600 | [diff] [blame] | 536 | return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
Tobin Ehlis | d28978b | 2016-09-06 18:46:55 -0600 | [diff] [blame] | 537 | reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 538 | "%s: Cannot read invalid region of memory allocation 0x%" PRIx64 " for bound %s object 0x%" PRIx64 |
| 539 | ", please fill the memory before using.", |
| 540 | functionName, reinterpret_cast<uint64_t &>(mem), object_type_to_string(type), bound_object_handle); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 541 | } |
| 542 | } |
| 543 | return false; |
| 544 | } |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 545 | // For given image_state |
| 546 | // If mem is special swapchain key, then verify that image_state valid member is true |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 547 | // Else verify that the image's bound memory range is valid |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 548 | static bool ValidateImageMemoryIsValid(layer_data *dev_data, IMAGE_STATE *image_state, const char *functionName) { |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 549 | if (image_state->binding.mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 550 | if (!image_state->valid) { |
Karl Schultz | e52f014 | 2016-09-29 16:11:35 -0600 | [diff] [blame] | 551 | return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 552 | reinterpret_cast<uint64_t &>(image_state->binding.mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 553 | "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 554 | functionName, reinterpret_cast<uint64_t &>(image_state->image)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 555 | } |
| 556 | } else { |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 557 | return ValidateMemoryIsValid(dev_data, image_state->binding.mem, reinterpret_cast<uint64_t &>(image_state->image), |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 558 | VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, functionName); |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 559 | } |
| 560 | return false; |
| 561 | } |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 562 | // For given buffer_state, verify that the range it's bound to is valid |
| 563 | static bool ValidateBufferMemoryIsValid(layer_data *dev_data, BUFFER_STATE *buffer_state, const char *functionName) { |
| 564 | return ValidateMemoryIsValid(dev_data, buffer_state->binding.mem, reinterpret_cast<uint64_t &>(buffer_state->buffer), |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 565 | VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, functionName); |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 566 | } |
| 567 | // For the given memory allocation, set the range bound by the given handle object to the valid param value |
| 568 | static void SetMemoryValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, bool valid) { |
| 569 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); |
| 570 | if (mem_info) { |
| 571 | mem_info->bound_ranges[handle].valid = valid; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 572 | } |
| 573 | } |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 574 | // For given image node |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 575 | // If mem is special swapchain key, then set entire image_state to valid param value |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 576 | // Else set the image's bound memory range to valid param value |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 577 | static void SetImageMemoryValid(layer_data *dev_data, IMAGE_STATE *image_state, bool valid) { |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 578 | if (image_state->binding.mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 579 | image_state->valid = valid; |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 580 | } else { |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 581 | SetMemoryValid(dev_data, image_state->binding.mem, reinterpret_cast<uint64_t &>(image_state->image), valid); |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 582 | } |
| 583 | } |
| 584 | // For given buffer node set the buffer's bound memory range to valid param value |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 585 | static void SetBufferMemoryValid(layer_data *dev_data, BUFFER_STATE *buffer_state, bool valid) { |
| 586 | SetMemoryValid(dev_data, buffer_state->binding.mem, reinterpret_cast<uint64_t &>(buffer_state->buffer), valid); |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 587 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 588 | // Find CB Info and add mem reference to list container |
| 589 | // Find Mem Obj Info and add CB reference to list container |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 590 | static bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, |
| 591 | const char *apiName) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 592 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 593 | |
| 594 | // Skip validation if this image was created through WSI |
| 595 | if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
| 596 | |
| 597 | // First update CB binding in MemObj mini CB list |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 598 | DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 599 | if (pMemInfo) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 600 | // Now update CBInfo's Mem reference list |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 601 | GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, cb); |
| 602 | pMemInfo->cb_bindings.insert(cb_node); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 603 | // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 604 | if (cb_node) { |
| 605 | cb_node->memObjs.insert(mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 606 | } |
| 607 | } |
| 608 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 609 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 610 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 611 | |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 612 | // Create binding link between given sampler and command buffer node |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 613 | void AddCommandBufferBindingSampler(GLOBAL_CB_NODE *cb_node, SAMPLER_STATE *sampler_state) { |
| 614 | sampler_state->cb_bindings.insert(cb_node); |
| 615 | cb_node->object_bindings.insert( |
| 616 | {reinterpret_cast<uint64_t &>(sampler_state->sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}); |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 617 | } |
| 618 | |
| 619 | // Create binding link between given image node and command buffer node |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 620 | void AddCommandBufferBindingImage(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_STATE *image_state) { |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 621 | // Skip validation if this image was created through WSI |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 622 | if (image_state->binding.mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 623 | // First update CB binding in MemObj mini CB list |
Tobin Ehlis | 640a81c | 2016-11-15 15:37:18 -0700 | [diff] [blame] | 624 | for (auto mem_binding : image_state->GetBoundMemory()) { |
| 625 | DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem_binding); |
| 626 | if (pMemInfo) { |
| 627 | pMemInfo->cb_bindings.insert(cb_node); |
| 628 | // Now update CBInfo's Mem reference list |
| 629 | cb_node->memObjs.insert(mem_binding); |
| 630 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 631 | } |
Tobin Ehlis | 6fcd6e4 | 2016-09-21 14:28:42 -0600 | [diff] [blame] | 632 | // Now update cb binding for image |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 633 | cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(image_state->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); |
| 634 | image_state->cb_bindings.insert(cb_node); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 635 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 636 | } |
| 637 | |
Tobin Ehlis | 15b8ea0 | 2016-09-19 14:02:58 -0600 | [diff] [blame] | 638 | // Create binding link between given image view node and its image with command buffer node |
| 639 | void AddCommandBufferBindingImageView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_VIEW_STATE *view_state) { |
| 640 | // First add bindings for imageView |
| 641 | view_state->cb_bindings.insert(cb_node); |
Tobin Ehlis | 15b8ea0 | 2016-09-19 14:02:58 -0600 | [diff] [blame] | 642 | cb_node->object_bindings.insert( |
| 643 | {reinterpret_cast<uint64_t &>(view_state->image_view), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT}); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 644 | auto image_state = getImageState(dev_data, view_state->create_info.image); |
Tobin Ehlis | 15b8ea0 | 2016-09-19 14:02:58 -0600 | [diff] [blame] | 645 | // Add bindings for image within imageView |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 646 | if (image_state) { |
| 647 | AddCommandBufferBindingImage(dev_data, cb_node, image_state); |
Tobin Ehlis | 15b8ea0 | 2016-09-19 14:02:58 -0600 | [diff] [blame] | 648 | } |
| 649 | } |
| 650 | |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 651 | // Create binding link between given buffer node and command buffer node |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 652 | void AddCommandBufferBindingBuffer(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_STATE *buffer_state) { |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 653 | // First update CB binding in MemObj mini CB list |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 654 | for (auto mem_binding : buffer_state->GetBoundMemory()) { |
Tobin Ehlis | 640a81c | 2016-11-15 15:37:18 -0700 | [diff] [blame] | 655 | DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem_binding); |
| 656 | if (pMemInfo) { |
| 657 | pMemInfo->cb_bindings.insert(cb_node); |
| 658 | // Now update CBInfo's Mem reference list |
| 659 | cb_node->memObjs.insert(mem_binding); |
| 660 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 661 | } |
| 662 | // Now update cb binding for buffer |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 663 | cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(buffer_state->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); |
| 664 | buffer_state->cb_bindings.insert(cb_node); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 665 | } |
| 666 | |
Tobin Ehlis | 2515c0e | 2016-09-28 07:12:28 -0600 | [diff] [blame] | 667 | // Create binding link between given buffer view node and its buffer with command buffer node |
| 668 | void AddCommandBufferBindingBufferView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_VIEW_STATE *view_state) { |
| 669 | // First add bindings for bufferView |
| 670 | view_state->cb_bindings.insert(cb_node); |
| 671 | cb_node->object_bindings.insert( |
| 672 | {reinterpret_cast<uint64_t &>(view_state->buffer_view), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT}); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 673 | auto buffer_state = getBufferState(dev_data, view_state->create_info.buffer); |
Tobin Ehlis | 2515c0e | 2016-09-28 07:12:28 -0600 | [diff] [blame] | 674 | // Add bindings for buffer within bufferView |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 675 | if (buffer_state) { |
| 676 | AddCommandBufferBindingBuffer(dev_data, cb_node, buffer_state); |
Tobin Ehlis | 2515c0e | 2016-09-28 07:12:28 -0600 | [diff] [blame] | 677 | } |
| 678 | } |
| 679 | |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 680 | // For every mem obj bound to particular CB, free bindings related to that CB |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 681 | static void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { |
| 682 | if (cb_node) { |
| 683 | if (cb_node->memObjs.size() > 0) { |
| 684 | for (auto mem : cb_node->memObjs) { |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 685 | DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 686 | if (pInfo) { |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 687 | pInfo->cb_bindings.erase(cb_node); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 688 | } |
| 689 | } |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 690 | cb_node->memObjs.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 691 | } |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 692 | cb_node->validate_functions.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 693 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 694 | } |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 695 | // Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up |
| 696 | static void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { |
| 697 | clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 698 | } |
| 699 | |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 700 | // Clear a single object binding from given memory object, or report error if binding is missing |
| 701 | static bool ClearMemoryObjectBinding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type, VkDeviceMemory mem) { |
| 702 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); |
| 703 | // This obj is bound to a memory object. Remove the reference to this object in that memory object's list |
Jeremy Hayes | 971ba4c | 2016-12-01 11:39:42 -0700 | [diff] [blame] | 704 | if (mem_info) { |
| 705 | mem_info->obj_bindings.erase({handle, type}); |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 706 | } |
| 707 | return false; |
| 708 | } |
| 709 | |
| 710 | // ClearMemoryObjectBindings clears the binding of objects to memory |
| 711 | // For the given object it pulls the memory bindings and makes sure that the bindings |
| 712 | // no longer refer to the object being cleared. This occurs when objects are destroyed. |
| 713 | static bool ClearMemoryObjectBindings(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { |
| 714 | bool skip = false; |
| 715 | BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); |
| 716 | if (mem_binding) { |
| 717 | if (!mem_binding->sparse) { |
| 718 | skip = ClearMemoryObjectBinding(dev_data, handle, type, mem_binding->binding.mem); |
| 719 | } else { // Sparse, clear all bindings |
| 720 | for (auto& sparse_mem_binding : mem_binding->sparse_bindings) { |
| 721 | skip |= ClearMemoryObjectBinding(dev_data, handle, type, sparse_mem_binding.mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 722 | } |
| 723 | } |
| 724 | } |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 725 | return skip; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 726 | } |
| 727 | |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 728 | // For given mem object, verify that it is not null or UNBOUND, if it is, report error. Return skip value. |
| 729 | bool VerifyBoundMemoryIsValid(const layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, const char *api_name, |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 730 | const char *type_name, UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 731 | bool result = false; |
| 732 | if (VK_NULL_HANDLE == mem) { |
| 733 | result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 734 | __LINE__, error_code, "MEM", |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 735 | "%s: Vk%s object 0x%" PRIxLEAST64 " used with no memory bound. Memory should be bound by calling " |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 736 | "vkBind%sMemory(). %s", |
| 737 | api_name, type_name, handle, type_name, validation_error_map[error_code]); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 738 | } else if (MEMORY_UNBOUND == mem) { |
| 739 | result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 740 | __LINE__, error_code, "MEM", |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 741 | "%s: Vk%s object 0x%" PRIxLEAST64 " used with no memory bound and previously bound memory was freed. " |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 742 | "Memory must not be freed prior to this operation. %s", |
| 743 | api_name, type_name, handle, validation_error_map[error_code]); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 744 | } |
| 745 | return result; |
| 746 | } |
| 747 | |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 748 | // Check to see if memory was ever bound to this image |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 749 | bool ValidateMemoryIsBoundToImage(const layer_data *dev_data, const IMAGE_STATE *image_state, const char *api_name, |
| 750 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 751 | bool result = false; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 752 | if (0 == (static_cast<uint32_t>(image_state->createInfo.flags) & VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 753 | result = VerifyBoundMemoryIsValid(dev_data, image_state->binding.mem, |
| 754 | reinterpret_cast<const uint64_t &>(image_state->image), api_name, "Image", error_code); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 755 | } |
| 756 | return result; |
| 757 | } |
| 758 | |
| 759 | // Check to see if memory was bound to this buffer |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 760 | bool ValidateMemoryIsBoundToBuffer(const layer_data *dev_data, const BUFFER_STATE *buffer_state, const char *api_name, |
| 761 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 762 | bool result = false; |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 763 | if (0 == (static_cast<uint32_t>(buffer_state->createInfo.flags) & VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) { |
| 764 | result = VerifyBoundMemoryIsValid(dev_data, buffer_state->binding.mem, |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 765 | reinterpret_cast<const uint64_t &>(buffer_state->buffer), api_name, "Buffer", error_code); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 766 | } |
| 767 | return result; |
| 768 | } |
| 769 | |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 770 | // SetMemBinding is used to establish immutable, non-sparse binding between a single image/buffer object and memory object |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 771 | // For NULL mem case, output warning |
| 772 | // Make sure given object is in global object map |
| 773 | // IF a previous binding existed, output validation error |
| 774 | // Otherwise, add reference from objectInfo to memoryInfo |
| 775 | // Add reference off of objInfo |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 776 | // TODO: We may need to refactor or pass in multiple valid usage statements to handle multiple valid usage conditions. |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 777 | static bool SetMemBinding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, VkDebugReportObjectTypeEXT type, |
| 778 | const char *apiName) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 779 | bool skip_call = false; |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 780 | // It's an error to bind an object to NULL memory |
Jeremy Hayes | 35fe172 | 2016-12-13 13:09:44 -0700 | [diff] [blame] | 781 | if (mem != VK_NULL_HANDLE) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 782 | BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 783 | assert(mem_binding); |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 784 | // TODO : Add check here to make sure object isn't sparse |
| 785 | // VALIDATION_ERROR_00792 for buffers |
| 786 | // VALIDATION_ERROR_00804 for images |
| 787 | assert(!mem_binding->sparse); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 788 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); |
| 789 | if (mem_info) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 790 | DEVICE_MEM_INFO *prev_binding = getMemObjInfo(dev_data, mem_binding->binding.mem); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 791 | if (prev_binding) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 792 | // TODO: VALIDATION_ERROR_00791 and VALIDATION_ERROR_00803 |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 793 | skip_call |= |
| 794 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 795 | reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", |
| 796 | "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 |
| 797 | ") which has already been bound to mem object 0x%" PRIxLEAST64, |
| 798 | apiName, reinterpret_cast<uint64_t &>(mem), handle, reinterpret_cast<uint64_t &>(prev_binding->mem)); |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 799 | } else if (mem_binding->binding.mem == MEMORY_UNBOUND) { |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 800 | skip_call |= |
| 801 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 802 | reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", |
| 803 | "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 |
| 804 | ") which was previous bound to memory that has since been freed. Memory bindings are immutable in " |
| 805 | "Vulkan so this attempt to bind to new memory is not allowed.", |
| 806 | apiName, reinterpret_cast<uint64_t &>(mem), handle); |
Tobin Ehlis | d5b56ea | 2016-05-11 14:40:44 -0600 | [diff] [blame] | 807 | } else { |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 808 | mem_info->obj_bindings.insert({handle, type}); |
Tobin Ehlis | d5b56ea | 2016-05-11 14:40:44 -0600 | [diff] [blame] | 809 | // For image objects, make sure default memory state is correctly set |
| 810 | // TODO : What's the best/correct way to handle this? |
| 811 | if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 812 | auto const image_state = getImageState(dev_data, VkImage(handle)); |
| 813 | if (image_state) { |
| 814 | VkImageCreateInfo ici = image_state->createInfo; |
Tobin Ehlis | d5b56ea | 2016-05-11 14:40:44 -0600 | [diff] [blame] | 815 | if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { |
| 816 | // TODO:: More memory state transition stuff. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 817 | } |
| 818 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 819 | } |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 820 | mem_binding->binding.mem = mem; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 821 | } |
| 822 | } |
| 823 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 824 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 825 | } |
| 826 | |
| 827 | // For NULL mem case, clear any previous binding Else... |
| 828 | // Make sure given object is in its object map |
| 829 | // IF a previous binding existed, update binding |
| 830 | // Add reference from objectInfo to memoryInfo |
| 831 | // Add reference off of object's binding info |
Chris Forbes | 73b82b1 | 2016-04-06 15:16:26 +1200 | [diff] [blame] | 832 | // Return VK_TRUE if addition is successful, VK_FALSE otherwise |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 833 | static bool SetSparseMemBinding(layer_data *dev_data, MEM_BINDING binding, uint64_t handle, VkDebugReportObjectTypeEXT type, |
| 834 | const char *apiName) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 835 | bool skip_call = VK_FALSE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 836 | // Handle NULL case separately, just clear previous binding & decrement reference |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 837 | if (binding.mem == VK_NULL_HANDLE) { |
| 838 | // TODO : This should cause the range of the resource to be unbound according to spec |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 839 | } else { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 840 | BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); |
| 841 | assert(mem_binding); |
| 842 | assert(mem_binding->sparse); |
| 843 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, binding.mem); |
| 844 | if (mem_info) { |
| 845 | mem_info->obj_bindings.insert({handle, type}); |
Tobin Ehlis | d5b56ea | 2016-05-11 14:40:44 -0600 | [diff] [blame] | 846 | // Need to set mem binding for this object |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 847 | mem_binding->sparse_bindings.insert(binding); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 848 | } |
| 849 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 850 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 851 | } |
| 852 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 853 | // Return a string representation of CMD_TYPE enum |
| 854 | static string cmdTypeToString(CMD_TYPE cmd) { |
| 855 | switch (cmd) { |
| 856 | case CMD_BINDPIPELINE: |
| 857 | return "CMD_BINDPIPELINE"; |
| 858 | case CMD_BINDPIPELINEDELTA: |
| 859 | return "CMD_BINDPIPELINEDELTA"; |
| 860 | case CMD_SETVIEWPORTSTATE: |
| 861 | return "CMD_SETVIEWPORTSTATE"; |
| 862 | case CMD_SETLINEWIDTHSTATE: |
| 863 | return "CMD_SETLINEWIDTHSTATE"; |
| 864 | case CMD_SETDEPTHBIASSTATE: |
| 865 | return "CMD_SETDEPTHBIASSTATE"; |
| 866 | case CMD_SETBLENDSTATE: |
| 867 | return "CMD_SETBLENDSTATE"; |
| 868 | case CMD_SETDEPTHBOUNDSSTATE: |
| 869 | return "CMD_SETDEPTHBOUNDSSTATE"; |
| 870 | case CMD_SETSTENCILREADMASKSTATE: |
| 871 | return "CMD_SETSTENCILREADMASKSTATE"; |
| 872 | case CMD_SETSTENCILWRITEMASKSTATE: |
| 873 | return "CMD_SETSTENCILWRITEMASKSTATE"; |
| 874 | case CMD_SETSTENCILREFERENCESTATE: |
| 875 | return "CMD_SETSTENCILREFERENCESTATE"; |
| 876 | case CMD_BINDDESCRIPTORSETS: |
| 877 | return "CMD_BINDDESCRIPTORSETS"; |
| 878 | case CMD_BINDINDEXBUFFER: |
| 879 | return "CMD_BINDINDEXBUFFER"; |
| 880 | case CMD_BINDVERTEXBUFFER: |
| 881 | return "CMD_BINDVERTEXBUFFER"; |
| 882 | case CMD_DRAW: |
| 883 | return "CMD_DRAW"; |
| 884 | case CMD_DRAWINDEXED: |
| 885 | return "CMD_DRAWINDEXED"; |
| 886 | case CMD_DRAWINDIRECT: |
| 887 | return "CMD_DRAWINDIRECT"; |
| 888 | case CMD_DRAWINDEXEDINDIRECT: |
| 889 | return "CMD_DRAWINDEXEDINDIRECT"; |
| 890 | case CMD_DISPATCH: |
| 891 | return "CMD_DISPATCH"; |
| 892 | case CMD_DISPATCHINDIRECT: |
| 893 | return "CMD_DISPATCHINDIRECT"; |
| 894 | case CMD_COPYBUFFER: |
| 895 | return "CMD_COPYBUFFER"; |
| 896 | case CMD_COPYIMAGE: |
| 897 | return "CMD_COPYIMAGE"; |
| 898 | case CMD_BLITIMAGE: |
| 899 | return "CMD_BLITIMAGE"; |
| 900 | case CMD_COPYBUFFERTOIMAGE: |
| 901 | return "CMD_COPYBUFFERTOIMAGE"; |
| 902 | case CMD_COPYIMAGETOBUFFER: |
| 903 | return "CMD_COPYIMAGETOBUFFER"; |
| 904 | case CMD_CLONEIMAGEDATA: |
| 905 | return "CMD_CLONEIMAGEDATA"; |
| 906 | case CMD_UPDATEBUFFER: |
| 907 | return "CMD_UPDATEBUFFER"; |
| 908 | case CMD_FILLBUFFER: |
| 909 | return "CMD_FILLBUFFER"; |
| 910 | case CMD_CLEARCOLORIMAGE: |
| 911 | return "CMD_CLEARCOLORIMAGE"; |
| 912 | case CMD_CLEARATTACHMENTS: |
| 913 | return "CMD_CLEARCOLORATTACHMENT"; |
| 914 | case CMD_CLEARDEPTHSTENCILIMAGE: |
| 915 | return "CMD_CLEARDEPTHSTENCILIMAGE"; |
| 916 | case CMD_RESOLVEIMAGE: |
| 917 | return "CMD_RESOLVEIMAGE"; |
| 918 | case CMD_SETEVENT: |
| 919 | return "CMD_SETEVENT"; |
| 920 | case CMD_RESETEVENT: |
| 921 | return "CMD_RESETEVENT"; |
| 922 | case CMD_WAITEVENTS: |
| 923 | return "CMD_WAITEVENTS"; |
| 924 | case CMD_PIPELINEBARRIER: |
| 925 | return "CMD_PIPELINEBARRIER"; |
| 926 | case CMD_BEGINQUERY: |
| 927 | return "CMD_BEGINQUERY"; |
| 928 | case CMD_ENDQUERY: |
| 929 | return "CMD_ENDQUERY"; |
| 930 | case CMD_RESETQUERYPOOL: |
| 931 | return "CMD_RESETQUERYPOOL"; |
| 932 | case CMD_COPYQUERYPOOLRESULTS: |
| 933 | return "CMD_COPYQUERYPOOLRESULTS"; |
| 934 | case CMD_WRITETIMESTAMP: |
| 935 | return "CMD_WRITETIMESTAMP"; |
| 936 | case CMD_INITATOMICCOUNTERS: |
| 937 | return "CMD_INITATOMICCOUNTERS"; |
| 938 | case CMD_LOADATOMICCOUNTERS: |
| 939 | return "CMD_LOADATOMICCOUNTERS"; |
| 940 | case CMD_SAVEATOMICCOUNTERS: |
| 941 | return "CMD_SAVEATOMICCOUNTERS"; |
| 942 | case CMD_BEGINRENDERPASS: |
| 943 | return "CMD_BEGINRENDERPASS"; |
| 944 | case CMD_ENDRENDERPASS: |
| 945 | return "CMD_ENDRENDERPASS"; |
| 946 | default: |
| 947 | return "UNKNOWN"; |
| 948 | } |
| 949 | } |
| 950 | |
| 951 | // SPIRV utility functions |
| 952 | static void build_def_index(shader_module *module) { |
| 953 | for (auto insn : *module) { |
| 954 | switch (insn.opcode()) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 955 | // Types |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 956 | case spv::OpTypeVoid: |
| 957 | case spv::OpTypeBool: |
| 958 | case spv::OpTypeInt: |
| 959 | case spv::OpTypeFloat: |
| 960 | case spv::OpTypeVector: |
| 961 | case spv::OpTypeMatrix: |
| 962 | case spv::OpTypeImage: |
| 963 | case spv::OpTypeSampler: |
| 964 | case spv::OpTypeSampledImage: |
| 965 | case spv::OpTypeArray: |
| 966 | case spv::OpTypeRuntimeArray: |
| 967 | case spv::OpTypeStruct: |
| 968 | case spv::OpTypeOpaque: |
| 969 | case spv::OpTypePointer: |
| 970 | case spv::OpTypeFunction: |
| 971 | case spv::OpTypeEvent: |
| 972 | case spv::OpTypeDeviceEvent: |
| 973 | case spv::OpTypeReserveId: |
| 974 | case spv::OpTypeQueue: |
| 975 | case spv::OpTypePipe: |
| 976 | module->def_index[insn.word(1)] = insn.offset(); |
| 977 | break; |
| 978 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 979 | // Fixed constants |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 980 | case spv::OpConstantTrue: |
| 981 | case spv::OpConstantFalse: |
| 982 | case spv::OpConstant: |
| 983 | case spv::OpConstantComposite: |
| 984 | case spv::OpConstantSampler: |
| 985 | case spv::OpConstantNull: |
| 986 | module->def_index[insn.word(2)] = insn.offset(); |
| 987 | break; |
| 988 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 989 | // Specialization constants |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 990 | case spv::OpSpecConstantTrue: |
| 991 | case spv::OpSpecConstantFalse: |
| 992 | case spv::OpSpecConstant: |
| 993 | case spv::OpSpecConstantComposite: |
| 994 | case spv::OpSpecConstantOp: |
| 995 | module->def_index[insn.word(2)] = insn.offset(); |
| 996 | break; |
| 997 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 998 | // Variables |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 999 | case spv::OpVariable: |
| 1000 | module->def_index[insn.word(2)] = insn.offset(); |
| 1001 | break; |
| 1002 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1003 | // Functions |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1004 | case spv::OpFunction: |
| 1005 | module->def_index[insn.word(2)] = insn.offset(); |
| 1006 | break; |
| 1007 | |
| 1008 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1009 | // We don't care about any other defs for now. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1010 | break; |
| 1011 | } |
| 1012 | } |
| 1013 | } |
| 1014 | |
| 1015 | static spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { |
| 1016 | for (auto insn : *src) { |
| 1017 | if (insn.opcode() == spv::OpEntryPoint) { |
| 1018 | auto entrypointName = (char const *)&insn.word(3); |
| 1019 | auto entrypointStageBits = 1u << insn.word(1); |
| 1020 | |
| 1021 | if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { |
| 1022 | return insn; |
| 1023 | } |
| 1024 | } |
| 1025 | } |
| 1026 | |
| 1027 | return src->end(); |
| 1028 | } |
| 1029 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1030 | static char const *storage_class_name(unsigned sc) { |
| 1031 | switch (sc) { |
| 1032 | case spv::StorageClassInput: |
| 1033 | return "input"; |
| 1034 | case spv::StorageClassOutput: |
| 1035 | return "output"; |
| 1036 | case spv::StorageClassUniformConstant: |
| 1037 | return "const uniform"; |
| 1038 | case spv::StorageClassUniform: |
| 1039 | return "uniform"; |
| 1040 | case spv::StorageClassWorkgroup: |
| 1041 | return "workgroup local"; |
| 1042 | case spv::StorageClassCrossWorkgroup: |
| 1043 | return "workgroup global"; |
| 1044 | case spv::StorageClassPrivate: |
| 1045 | return "private global"; |
| 1046 | case spv::StorageClassFunction: |
| 1047 | return "function"; |
| 1048 | case spv::StorageClassGeneric: |
| 1049 | return "generic"; |
| 1050 | case spv::StorageClassAtomicCounter: |
| 1051 | return "atomic counter"; |
| 1052 | case spv::StorageClassImage: |
| 1053 | return "image"; |
| 1054 | case spv::StorageClassPushConstant: |
| 1055 | return "push constant"; |
| 1056 | default: |
| 1057 | return "unknown"; |
| 1058 | } |
| 1059 | } |
| 1060 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1061 | // Get the value of an integral constant |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1062 | unsigned get_constant_value(shader_module const *src, unsigned id) { |
| 1063 | auto value = src->get_def(id); |
| 1064 | assert(value != src->end()); |
| 1065 | |
| 1066 | if (value.opcode() != spv::OpConstant) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1067 | // TODO: Either ensure that the specialization transform is already performed on a module we're |
| 1068 | // considering here, OR -- specialize on the fly now. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1069 | return 1; |
| 1070 | } |
| 1071 | |
| 1072 | return value.word(3); |
| 1073 | } |
| 1074 | |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1075 | |
| 1076 | static void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1077 | auto insn = src->get_def(type); |
| 1078 | assert(insn != src->end()); |
| 1079 | |
| 1080 | switch (insn.opcode()) { |
| 1081 | case spv::OpTypeBool: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1082 | ss << "bool"; |
| 1083 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1084 | case spv::OpTypeInt: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1085 | ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); |
| 1086 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1087 | case spv::OpTypeFloat: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1088 | ss << "float" << insn.word(2); |
| 1089 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1090 | case spv::OpTypeVector: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1091 | ss << "vec" << insn.word(3) << " of "; |
| 1092 | describe_type_inner(ss, src, insn.word(2)); |
| 1093 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1094 | case spv::OpTypeMatrix: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1095 | ss << "mat" << insn.word(3) << " of "; |
| 1096 | describe_type_inner(ss, src, insn.word(2)); |
| 1097 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1098 | case spv::OpTypeArray: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1099 | ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; |
| 1100 | describe_type_inner(ss, src, insn.word(2)); |
| 1101 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1102 | case spv::OpTypePointer: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1103 | ss << "ptr to " << storage_class_name(insn.word(2)) << " "; |
| 1104 | describe_type_inner(ss, src, insn.word(3)); |
| 1105 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1106 | case spv::OpTypeStruct: { |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1107 | ss << "struct of ("; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1108 | for (unsigned i = 2; i < insn.len(); i++) { |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1109 | describe_type_inner(ss, src, insn.word(i)); |
| 1110 | if (i == insn.len() - 1) { |
| 1111 | ss << ")"; |
| 1112 | } else { |
| 1113 | ss << ", "; |
| 1114 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1115 | } |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1116 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1117 | } |
| 1118 | case spv::OpTypeSampler: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1119 | ss << "sampler"; |
| 1120 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1121 | case spv::OpTypeSampledImage: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1122 | ss << "sampler+"; |
| 1123 | describe_type_inner(ss, src, insn.word(2)); |
| 1124 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1125 | case spv::OpTypeImage: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1126 | ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; |
| 1127 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1128 | default: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1129 | ss << "oddtype"; |
| 1130 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1131 | } |
| 1132 | } |
| 1133 | |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1134 | |
| 1135 | static std::string describe_type(shader_module const *src, unsigned type) { |
| 1136 | std::ostringstream ss; |
| 1137 | describe_type_inner(ss, src, type); |
| 1138 | return ss.str(); |
| 1139 | } |
| 1140 | |
| 1141 | |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1142 | static bool is_narrow_numeric_type(spirv_inst_iter type) |
| 1143 | { |
| 1144 | if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) |
| 1145 | return false; |
| 1146 | return type.word(2) < 64; |
| 1147 | } |
| 1148 | |
| 1149 | |
| 1150 | static bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1151 | // Walk two type trees together, and complain about differences |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1152 | auto a_insn = a->get_def(a_type); |
| 1153 | auto b_insn = b->get_def(b_type); |
| 1154 | assert(a_insn != a->end()); |
| 1155 | assert(b_insn != b->end()); |
| 1156 | |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1157 | if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1158 | return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1159 | } |
| 1160 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1161 | if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1162 | // We probably just found the extra level of arrayness in b_type: compare the type inside it to a_type |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1163 | return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); |
| 1164 | } |
| 1165 | |
| 1166 | if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { |
| 1167 | return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1168 | } |
| 1169 | |
| 1170 | if (a_insn.opcode() != b_insn.opcode()) { |
| 1171 | return false; |
| 1172 | } |
| 1173 | |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1174 | if (a_insn.opcode() == spv::OpTypePointer) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1175 | // Match on pointee type. storage class is expected to differ |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1176 | return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1177 | } |
| 1178 | |
| 1179 | if (a_arrayed || b_arrayed) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1180 | // If we havent resolved array-of-verts by here, we're not going to. |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1181 | return false; |
| 1182 | } |
| 1183 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1184 | switch (a_insn.opcode()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1185 | case spv::OpTypeBool: |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1186 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1187 | case spv::OpTypeInt: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1188 | // Match on width, signedness |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1189 | return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1190 | case spv::OpTypeFloat: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1191 | // Match on width |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1192 | return a_insn.word(2) == b_insn.word(2); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1193 | case spv::OpTypeVector: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1194 | // Match on element type, count. |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1195 | if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) |
| 1196 | return false; |
| 1197 | if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { |
| 1198 | return a_insn.word(3) >= b_insn.word(3); |
| 1199 | } |
| 1200 | else { |
| 1201 | return a_insn.word(3) == b_insn.word(3); |
| 1202 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1203 | case spv::OpTypeMatrix: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1204 | // Match on element type, count. |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1205 | return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1206 | case spv::OpTypeArray: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1207 | // Match on element type, count. these all have the same layout. we don't get here if b_arrayed. This differs from |
| 1208 | // vector & matrix types in that the array size is the id of a constant instruction, * not a literal within OpTypeArray |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1209 | return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1210 | get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); |
| 1211 | case spv::OpTypeStruct: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1212 | // Match on all element types |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1213 | { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1214 | if (a_insn.len() != b_insn.len()) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1215 | return false; // Structs cannot match if member counts differ |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1216 | } |
| 1217 | |
| 1218 | for (unsigned i = 2; i < a_insn.len(); i++) { |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1219 | if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1220 | return false; |
| 1221 | } |
| 1222 | } |
| 1223 | |
| 1224 | return true; |
| 1225 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1226 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1227 | // Remaining types are CLisms, or may not appear in the interfaces we are interested in. Just claim no match. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1228 | return false; |
| 1229 | } |
| 1230 | } |
| 1231 | |
| 1232 | static int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { |
| 1233 | auto it = map.find(id); |
| 1234 | if (it == map.end()) |
| 1235 | return def; |
| 1236 | else |
| 1237 | return it->second; |
| 1238 | } |
| 1239 | |
| 1240 | static unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { |
| 1241 | auto insn = src->get_def(type); |
| 1242 | assert(insn != src->end()); |
| 1243 | |
| 1244 | switch (insn.opcode()) { |
| 1245 | case spv::OpTypePointer: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1246 | // See through the ptr -- this is only ever at the toplevel for graphics shaders we're never actually passing |
| 1247 | // pointers around. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1248 | return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); |
| 1249 | case spv::OpTypeArray: |
| 1250 | if (strip_array_level) { |
| 1251 | return get_locations_consumed_by_type(src, insn.word(2), false); |
| 1252 | } else { |
| 1253 | return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); |
| 1254 | } |
| 1255 | case spv::OpTypeMatrix: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1256 | // Num locations is the dimension * element size |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1257 | return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); |
Chris Forbes | b91daf0 | 2016-04-21 14:46:48 +1200 | [diff] [blame] | 1258 | case spv::OpTypeVector: { |
| 1259 | auto scalar_type = src->get_def(insn.word(2)); |
| 1260 | auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? |
| 1261 | scalar_type.word(2) : 32; |
| 1262 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1263 | // Locations are 128-bit wide; 3- and 4-component vectors of 64 bit types require two. |
Chris Forbes | b91daf0 | 2016-04-21 14:46:48 +1200 | [diff] [blame] | 1264 | return (bit_width * insn.word(3) + 127) / 128; |
| 1265 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1266 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1267 | // Everything else is just 1. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1268 | return 1; |
| 1269 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1270 | // TODO: extend to handle 64bit scalar types, whose vectors may need multiple locations. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1271 | } |
| 1272 | } |
| 1273 | |
Chris Forbes | e32b78a | 2016-04-21 15:00:58 +1200 | [diff] [blame] | 1274 | static unsigned get_locations_consumed_by_format(VkFormat format) { |
| 1275 | switch (format) { |
| 1276 | case VK_FORMAT_R64G64B64A64_SFLOAT: |
| 1277 | case VK_FORMAT_R64G64B64A64_SINT: |
| 1278 | case VK_FORMAT_R64G64B64A64_UINT: |
| 1279 | case VK_FORMAT_R64G64B64_SFLOAT: |
| 1280 | case VK_FORMAT_R64G64B64_SINT: |
| 1281 | case VK_FORMAT_R64G64B64_UINT: |
| 1282 | return 2; |
| 1283 | default: |
| 1284 | return 1; |
| 1285 | } |
| 1286 | } |
| 1287 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1288 | typedef std::pair<unsigned, unsigned> location_t; |
| 1289 | typedef std::pair<unsigned, unsigned> descriptor_slot_t; |
| 1290 | |
| 1291 | struct interface_var { |
| 1292 | uint32_t id; |
| 1293 | uint32_t type_id; |
| 1294 | uint32_t offset; |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1295 | bool is_patch; |
Chris Forbes | a0ab815 | 2016-04-20 13:34:27 +1200 | [diff] [blame] | 1296 | bool is_block_member; |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1297 | bool is_relaxed_precision; |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1298 | // TODO: collect the name, too? Isn't required to be present. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1299 | }; |
| 1300 | |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1301 | struct shader_stage_attributes { |
| 1302 | char const *const name; |
| 1303 | bool arrayed_input; |
| 1304 | bool arrayed_output; |
| 1305 | }; |
| 1306 | |
| 1307 | static shader_stage_attributes shader_stage_attribs[] = { |
| 1308 | {"vertex shader", false, false}, |
| 1309 | {"tessellation control shader", true, true}, |
| 1310 | {"tessellation evaluation shader", true, false}, |
| 1311 | {"geometry shader", true, false}, |
| 1312 | {"fragment shader", false, false}, |
| 1313 | }; |
| 1314 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1315 | static spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { |
| 1316 | while (true) { |
| 1317 | |
| 1318 | if (def.opcode() == spv::OpTypePointer) { |
| 1319 | def = src->get_def(def.word(3)); |
| 1320 | } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { |
| 1321 | def = src->get_def(def.word(2)); |
| 1322 | is_array_of_verts = false; |
| 1323 | } else if (def.opcode() == spv::OpTypeStruct) { |
| 1324 | return def; |
| 1325 | } else { |
| 1326 | return src->end(); |
| 1327 | } |
| 1328 | } |
| 1329 | } |
| 1330 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1331 | static void collect_interface_block_members(shader_module const *src, |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1332 | std::map<location_t, interface_var> *out, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1333 | std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1334 | uint32_t id, uint32_t type_id, bool is_patch) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1335 | // Walk down the type_id presented, trying to determine whether it's actually an interface block. |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1336 | auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1337 | if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1338 | // This isn't an interface block. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1339 | return; |
| 1340 | } |
| 1341 | |
| 1342 | std::unordered_map<unsigned, unsigned> member_components; |
Chris Forbes | f929b16 | 2016-11-30 12:55:40 +1300 | [diff] [blame] | 1343 | std::unordered_map<unsigned, unsigned> member_relaxed_precision; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1344 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1345 | // Walk all the OpMemberDecorate for type's result id -- first pass, collect components. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1346 | for (auto insn : *src) { |
| 1347 | if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { |
| 1348 | unsigned member_index = insn.word(2); |
| 1349 | |
| 1350 | if (insn.word(3) == spv::DecorationComponent) { |
| 1351 | unsigned component = insn.word(4); |
| 1352 | member_components[member_index] = component; |
| 1353 | } |
Chris Forbes | f929b16 | 2016-11-30 12:55:40 +1300 | [diff] [blame] | 1354 | |
| 1355 | if (insn.word(3) == spv::DecorationRelaxedPrecision) { |
| 1356 | member_relaxed_precision[member_index] = 1; |
| 1357 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1358 | } |
| 1359 | } |
| 1360 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1361 | // Second pass -- produce the output, from Location decorations |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1362 | for (auto insn : *src) { |
| 1363 | if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { |
| 1364 | unsigned member_index = insn.word(2); |
| 1365 | unsigned member_type_id = type.word(2 + member_index); |
| 1366 | |
| 1367 | if (insn.word(3) == spv::DecorationLocation) { |
| 1368 | unsigned location = insn.word(4); |
| 1369 | unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); |
| 1370 | auto component_it = member_components.find(member_index); |
| 1371 | unsigned component = component_it == member_components.end() ? 0 : component_it->second; |
Chris Forbes | f929b16 | 2016-11-30 12:55:40 +1300 | [diff] [blame] | 1372 | bool is_relaxed_precision = member_relaxed_precision.find(member_index) != member_relaxed_precision.end(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1373 | |
| 1374 | for (unsigned int offset = 0; offset < num_locations; offset++) { |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1375 | interface_var v = {}; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1376 | v.id = id; |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1377 | // TODO: member index in interface_var too? |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1378 | v.type_id = member_type_id; |
| 1379 | v.offset = offset; |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1380 | v.is_patch = is_patch; |
Chris Forbes | a0ab815 | 2016-04-20 13:34:27 +1200 | [diff] [blame] | 1381 | v.is_block_member = true; |
Chris Forbes | f929b16 | 2016-11-30 12:55:40 +1300 | [diff] [blame] | 1382 | v.is_relaxed_precision = is_relaxed_precision; |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1383 | (*out)[std::make_pair(location + offset, component)] = v; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1384 | } |
| 1385 | } |
| 1386 | } |
| 1387 | } |
| 1388 | } |
| 1389 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1390 | static std::map<location_t, interface_var> collect_interface_by_location( |
| 1391 | shader_module const *src, spirv_inst_iter entrypoint, |
| 1392 | spv::StorageClass sinterface, bool is_array_of_verts) { |
| 1393 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1394 | std::unordered_map<unsigned, unsigned> var_locations; |
| 1395 | std::unordered_map<unsigned, unsigned> var_builtins; |
| 1396 | std::unordered_map<unsigned, unsigned> var_components; |
| 1397 | std::unordered_map<unsigned, unsigned> blocks; |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1398 | std::unordered_map<unsigned, unsigned> var_patch; |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1399 | std::unordered_map<unsigned, unsigned> var_relaxed_precision; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1400 | |
| 1401 | for (auto insn : *src) { |
| 1402 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1403 | // We consider two interface models: SSO rendezvous-by-location, and builtins. Complain about anything that |
| 1404 | // fits neither model. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1405 | if (insn.opcode() == spv::OpDecorate) { |
| 1406 | if (insn.word(2) == spv::DecorationLocation) { |
| 1407 | var_locations[insn.word(1)] = insn.word(3); |
| 1408 | } |
| 1409 | |
| 1410 | if (insn.word(2) == spv::DecorationBuiltIn) { |
| 1411 | var_builtins[insn.word(1)] = insn.word(3); |
| 1412 | } |
| 1413 | |
| 1414 | if (insn.word(2) == spv::DecorationComponent) { |
| 1415 | var_components[insn.word(1)] = insn.word(3); |
| 1416 | } |
| 1417 | |
| 1418 | if (insn.word(2) == spv::DecorationBlock) { |
| 1419 | blocks[insn.word(1)] = 1; |
| 1420 | } |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1421 | |
| 1422 | if (insn.word(2) == spv::DecorationPatch) { |
| 1423 | var_patch[insn.word(1)] = 1; |
| 1424 | } |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1425 | |
| 1426 | if (insn.word(2) == spv::DecorationRelaxedPrecision) { |
| 1427 | var_relaxed_precision[insn.word(1)] = 1; |
| 1428 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1429 | } |
| 1430 | } |
| 1431 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1432 | // TODO: handle grouped decorations |
| 1433 | // TODO: handle index=1 dual source outputs from FS -- two vars will have the same location, and we DON'T want to clobber. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1434 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1435 | // Find the end of the entrypoint's name string. additional zero bytes follow the actual null terminator, to fill out the |
| 1436 | // rest of the word - so we only need to look at the last byte in the word to determine which word contains the terminator. |
Michael Mc Donnell | 75ecdb7 | 2016-04-03 14:47:51 -0700 | [diff] [blame] | 1437 | uint32_t word = 3; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1438 | while (entrypoint.word(word) & 0xff000000u) { |
| 1439 | ++word; |
| 1440 | } |
| 1441 | ++word; |
| 1442 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1443 | std::map<location_t, interface_var> out; |
| 1444 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1445 | for (; word < entrypoint.len(); word++) { |
| 1446 | auto insn = src->get_def(entrypoint.word(word)); |
| 1447 | assert(insn != src->end()); |
| 1448 | assert(insn.opcode() == spv::OpVariable); |
| 1449 | |
Jamie Madill | 2b6b8d5 | 2016-04-04 15:09:51 -0400 | [diff] [blame] | 1450 | if (insn.word(3) == static_cast<uint32_t>(sinterface)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1451 | unsigned id = insn.word(2); |
| 1452 | unsigned type = insn.word(1); |
| 1453 | |
| 1454 | int location = value_or_default(var_locations, id, -1); |
| 1455 | int builtin = value_or_default(var_builtins, id, -1); |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1456 | unsigned component = value_or_default(var_components, id, 0); // Unspecified is OK, is 0 |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1457 | bool is_patch = var_patch.find(id) != var_patch.end(); |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1458 | bool is_relaxed_precision = var_relaxed_precision.find(id) != var_relaxed_precision.end(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1459 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1460 | // All variables and interface block members in the Input or Output storage classes must be decorated with either |
| 1461 | // a builtin or an explicit location. |
| 1462 | // |
| 1463 | // TODO: integrate the interface block support here. For now, don't complain -- a valid SPIRV module will only hit |
| 1464 | // this path for the interface block case, as the individual members of the type are decorated, rather than |
| 1465 | // variable declarations. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1466 | |
| 1467 | if (location != -1) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1468 | // A user-defined interface variable, with a location. Where a variable occupied multiple locations, emit |
| 1469 | // one result for each. |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1470 | unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1471 | for (unsigned int offset = 0; offset < num_locations; offset++) { |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1472 | interface_var v = {}; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1473 | v.id = id; |
| 1474 | v.type_id = type; |
| 1475 | v.offset = offset; |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1476 | v.is_patch = is_patch; |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1477 | v.is_relaxed_precision = is_relaxed_precision; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1478 | out[std::make_pair(location + offset, component)] = v; |
| 1479 | } |
| 1480 | } else if (builtin == -1) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1481 | // An interface block instance |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1482 | collect_interface_block_members(src, &out, blocks, is_array_of_verts, id, type, is_patch); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1483 | } |
| 1484 | } |
| 1485 | } |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1486 | |
| 1487 | return out; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1488 | } |
| 1489 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1490 | static std::vector<std::pair<uint32_t, interface_var>> collect_interface_by_input_attachment_index( |
| 1491 | debug_report_data *report_data, shader_module const *src, |
| 1492 | std::unordered_set<uint32_t> const &accessible_ids) { |
| 1493 | |
| 1494 | std::vector<std::pair<uint32_t, interface_var>> out; |
Chris Forbes | 07ac1f3 | 2016-08-22 14:58:35 +1200 | [diff] [blame] | 1495 | |
| 1496 | for (auto insn : *src) { |
| 1497 | if (insn.opcode() == spv::OpDecorate) { |
| 1498 | if (insn.word(2) == spv::DecorationInputAttachmentIndex) { |
| 1499 | auto attachment_index = insn.word(3); |
| 1500 | auto id = insn.word(1); |
| 1501 | |
| 1502 | if (accessible_ids.count(id)) { |
| 1503 | auto def = src->get_def(id); |
| 1504 | assert(def != src->end()); |
| 1505 | |
| 1506 | if (def.opcode() == spv::OpVariable && insn.word(3) == spv::StorageClassUniformConstant) { |
Chris Forbes | 56f2845 | 2016-08-22 15:31:18 +1200 | [diff] [blame] | 1507 | auto num_locations = get_locations_consumed_by_type(src, def.word(1), false); |
| 1508 | for (unsigned int offset = 0; offset < num_locations; offset++) { |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1509 | interface_var v = {}; |
Chris Forbes | 56f2845 | 2016-08-22 15:31:18 +1200 | [diff] [blame] | 1510 | v.id = id; |
| 1511 | v.type_id = def.word(1); |
| 1512 | v.offset = offset; |
Chris Forbes | 56f2845 | 2016-08-22 15:31:18 +1200 | [diff] [blame] | 1513 | out.emplace_back(attachment_index + offset, v); |
| 1514 | } |
Chris Forbes | 07ac1f3 | 2016-08-22 14:58:35 +1200 | [diff] [blame] | 1515 | } |
| 1516 | } |
| 1517 | } |
| 1518 | } |
| 1519 | } |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1520 | |
| 1521 | return out; |
Chris Forbes | 07ac1f3 | 2016-08-22 14:58:35 +1200 | [diff] [blame] | 1522 | } |
| 1523 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1524 | static std::vector<std::pair<descriptor_slot_t, interface_var>> collect_interface_by_descriptor_slot( |
| 1525 | debug_report_data *report_data, shader_module const *src, |
| 1526 | std::unordered_set<uint32_t> const &accessible_ids) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1527 | |
| 1528 | std::unordered_map<unsigned, unsigned> var_sets; |
| 1529 | std::unordered_map<unsigned, unsigned> var_bindings; |
| 1530 | |
| 1531 | for (auto insn : *src) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1532 | // All variables in the Uniform or UniformConstant storage classes are required to be decorated with both |
| 1533 | // DecorationDescriptorSet and DecorationBinding. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1534 | if (insn.opcode() == spv::OpDecorate) { |
| 1535 | if (insn.word(2) == spv::DecorationDescriptorSet) { |
| 1536 | var_sets[insn.word(1)] = insn.word(3); |
| 1537 | } |
| 1538 | |
| 1539 | if (insn.word(2) == spv::DecorationBinding) { |
| 1540 | var_bindings[insn.word(1)] = insn.word(3); |
| 1541 | } |
| 1542 | } |
| 1543 | } |
| 1544 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1545 | std::vector<std::pair<descriptor_slot_t, interface_var>> out; |
| 1546 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1547 | for (auto id : accessible_ids) { |
| 1548 | auto insn = src->get_def(id); |
| 1549 | assert(insn != src->end()); |
| 1550 | |
| 1551 | if (insn.opcode() == spv::OpVariable && |
| 1552 | (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { |
| 1553 | unsigned set = value_or_default(var_sets, insn.word(2), 0); |
| 1554 | unsigned binding = value_or_default(var_bindings, insn.word(2), 0); |
| 1555 | |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1556 | interface_var v = {}; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1557 | v.id = insn.word(2); |
| 1558 | v.type_id = insn.word(1); |
Chris Forbes | be8986a | 2016-07-19 15:08:38 +1200 | [diff] [blame] | 1559 | out.emplace_back(std::make_pair(set, binding), v); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1560 | } |
| 1561 | } |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1562 | |
| 1563 | return out; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1564 | } |
| 1565 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1566 | static bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1567 | spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1568 | shader_module const *consumer, spirv_inst_iter consumer_entrypoint, |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1569 | shader_stage_attributes const *consumer_stage) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1570 | bool pass = true; |
| 1571 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1572 | auto outputs = collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, producer_stage->arrayed_output); |
| 1573 | auto inputs = collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, consumer_stage->arrayed_input); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1574 | |
| 1575 | auto a_it = outputs.begin(); |
| 1576 | auto b_it = inputs.begin(); |
| 1577 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1578 | // Maps sorted by key (location); walk them together to find mismatches |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1579 | while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { |
| 1580 | bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); |
| 1581 | bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); |
| 1582 | auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; |
| 1583 | auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; |
| 1584 | |
| 1585 | if (b_at_end || ((!a_at_end) && (a_first < b_first))) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1586 | if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 1587 | __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1588 | "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, |
| 1589 | a_first.second, consumer_stage->name)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1590 | pass = false; |
| 1591 | } |
| 1592 | a_it++; |
| 1593 | } else if (a_at_end || a_first > b_first) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1594 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1595 | __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1596 | "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, |
| 1597 | producer_stage->name)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1598 | pass = false; |
| 1599 | } |
| 1600 | b_it++; |
| 1601 | } else { |
Chris Forbes | a0ab815 | 2016-04-20 13:34:27 +1200 | [diff] [blame] | 1602 | // subtleties of arrayed interfaces: |
| 1603 | // - if is_patch, then the member is not arrayed, even though the interface may be. |
| 1604 | // - if is_block_member, then the extra array level of an arrayed interface is not |
| 1605 | // expressed in the member type -- it's expressed in the block type. |
Chris Forbes | 218deeb | 2016-03-29 16:57:02 +1300 | [diff] [blame] | 1606 | if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, |
Chris Forbes | a0ab815 | 2016-04-20 13:34:27 +1200 | [diff] [blame] | 1607 | producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, |
| 1608 | consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1609 | true)) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1610 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1611 | __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1612 | a_first.first, a_first.second, |
| 1613 | describe_type(producer, a_it->second.type_id).c_str(), |
| 1614 | describe_type(consumer, b_it->second.type_id).c_str())) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1615 | pass = false; |
| 1616 | } |
| 1617 | } |
Chris Forbes | 218deeb | 2016-03-29 16:57:02 +1300 | [diff] [blame] | 1618 | if (a_it->second.is_patch != b_it->second.is_patch) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1619 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 0, |
Chris Forbes | 218deeb | 2016-03-29 16:57:02 +1300 | [diff] [blame] | 1620 | __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
Chris Forbes | a0193bc | 2016-04-04 19:19:47 +1200 | [diff] [blame] | 1621 | "Decoration mismatch on location %u.%u: is per-%s in %s stage but " |
Chris Forbes | 218deeb | 2016-03-29 16:57:02 +1300 | [diff] [blame] | 1622 | "per-%s in %s stage", a_first.first, a_first.second, |
| 1623 | a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, |
| 1624 | b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { |
| 1625 | pass = false; |
| 1626 | } |
| 1627 | } |
Chris Forbes | 4420839 | 2016-11-30 12:45:00 +1300 | [diff] [blame] | 1628 | if (a_it->second.is_relaxed_precision != b_it->second.is_relaxed_precision) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1629 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 0, |
Chris Forbes | 4420839 | 2016-11-30 12:45:00 +1300 | [diff] [blame] | 1630 | __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
| 1631 | "Decoration mismatch on location %u.%u: %s and %s stages differ in precision", |
| 1632 | a_first.first, a_first.second, |
| 1633 | producer_stage->name, |
| 1634 | consumer_stage->name)) { |
| 1635 | pass = false; |
| 1636 | } |
| 1637 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1638 | a_it++; |
| 1639 | b_it++; |
| 1640 | } |
| 1641 | } |
| 1642 | |
| 1643 | return pass; |
| 1644 | } |
| 1645 | |
| 1646 | enum FORMAT_TYPE { |
| 1647 | FORMAT_TYPE_UNDEFINED, |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1648 | FORMAT_TYPE_FLOAT, // UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1649 | FORMAT_TYPE_SINT, |
| 1650 | FORMAT_TYPE_UINT, |
| 1651 | }; |
| 1652 | |
| 1653 | static unsigned get_format_type(VkFormat fmt) { |
| 1654 | switch (fmt) { |
| 1655 | case VK_FORMAT_UNDEFINED: |
| 1656 | return FORMAT_TYPE_UNDEFINED; |
| 1657 | case VK_FORMAT_R8_SINT: |
| 1658 | case VK_FORMAT_R8G8_SINT: |
| 1659 | case VK_FORMAT_R8G8B8_SINT: |
| 1660 | case VK_FORMAT_R8G8B8A8_SINT: |
| 1661 | case VK_FORMAT_R16_SINT: |
| 1662 | case VK_FORMAT_R16G16_SINT: |
| 1663 | case VK_FORMAT_R16G16B16_SINT: |
| 1664 | case VK_FORMAT_R16G16B16A16_SINT: |
| 1665 | case VK_FORMAT_R32_SINT: |
| 1666 | case VK_FORMAT_R32G32_SINT: |
| 1667 | case VK_FORMAT_R32G32B32_SINT: |
| 1668 | case VK_FORMAT_R32G32B32A32_SINT: |
Chris Forbes | f57a520 | 2016-04-20 14:22:07 +1200 | [diff] [blame] | 1669 | case VK_FORMAT_R64_SINT: |
| 1670 | case VK_FORMAT_R64G64_SINT: |
| 1671 | case VK_FORMAT_R64G64B64_SINT: |
| 1672 | case VK_FORMAT_R64G64B64A64_SINT: |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1673 | case VK_FORMAT_B8G8R8_SINT: |
| 1674 | case VK_FORMAT_B8G8R8A8_SINT: |
Chris Forbes | e9a21d4 | 2016-04-20 14:16:10 +1200 | [diff] [blame] | 1675 | case VK_FORMAT_A8B8G8R8_SINT_PACK32: |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1676 | case VK_FORMAT_A2B10G10R10_SINT_PACK32: |
| 1677 | case VK_FORMAT_A2R10G10B10_SINT_PACK32: |
| 1678 | return FORMAT_TYPE_SINT; |
| 1679 | case VK_FORMAT_R8_UINT: |
| 1680 | case VK_FORMAT_R8G8_UINT: |
| 1681 | case VK_FORMAT_R8G8B8_UINT: |
| 1682 | case VK_FORMAT_R8G8B8A8_UINT: |
| 1683 | case VK_FORMAT_R16_UINT: |
| 1684 | case VK_FORMAT_R16G16_UINT: |
| 1685 | case VK_FORMAT_R16G16B16_UINT: |
| 1686 | case VK_FORMAT_R16G16B16A16_UINT: |
| 1687 | case VK_FORMAT_R32_UINT: |
| 1688 | case VK_FORMAT_R32G32_UINT: |
| 1689 | case VK_FORMAT_R32G32B32_UINT: |
| 1690 | case VK_FORMAT_R32G32B32A32_UINT: |
Chris Forbes | f57a520 | 2016-04-20 14:22:07 +1200 | [diff] [blame] | 1691 | case VK_FORMAT_R64_UINT: |
| 1692 | case VK_FORMAT_R64G64_UINT: |
| 1693 | case VK_FORMAT_R64G64B64_UINT: |
| 1694 | case VK_FORMAT_R64G64B64A64_UINT: |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1695 | case VK_FORMAT_B8G8R8_UINT: |
| 1696 | case VK_FORMAT_B8G8R8A8_UINT: |
Chris Forbes | e9a21d4 | 2016-04-20 14:16:10 +1200 | [diff] [blame] | 1697 | case VK_FORMAT_A8B8G8R8_UINT_PACK32: |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1698 | case VK_FORMAT_A2B10G10R10_UINT_PACK32: |
| 1699 | case VK_FORMAT_A2R10G10B10_UINT_PACK32: |
| 1700 | return FORMAT_TYPE_UINT; |
| 1701 | default: |
| 1702 | return FORMAT_TYPE_FLOAT; |
| 1703 | } |
| 1704 | } |
| 1705 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1706 | // characterizes a SPIR-V type appearing in an interface to a FF stage, for comparison to a VkFormat's characterization above. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1707 | static unsigned get_fundamental_type(shader_module const *src, unsigned type) { |
| 1708 | auto insn = src->get_def(type); |
| 1709 | assert(insn != src->end()); |
| 1710 | |
| 1711 | switch (insn.opcode()) { |
| 1712 | case spv::OpTypeInt: |
| 1713 | return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; |
| 1714 | case spv::OpTypeFloat: |
| 1715 | return FORMAT_TYPE_FLOAT; |
| 1716 | case spv::OpTypeVector: |
| 1717 | return get_fundamental_type(src, insn.word(2)); |
| 1718 | case spv::OpTypeMatrix: |
| 1719 | return get_fundamental_type(src, insn.word(2)); |
| 1720 | case spv::OpTypeArray: |
| 1721 | return get_fundamental_type(src, insn.word(2)); |
| 1722 | case spv::OpTypePointer: |
| 1723 | return get_fundamental_type(src, insn.word(3)); |
Chris Forbes | 383352e | 2016-08-22 16:36:54 +1200 | [diff] [blame] | 1724 | case spv::OpTypeImage: |
| 1725 | return get_fundamental_type(src, insn.word(2)); |
| 1726 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1727 | default: |
| 1728 | return FORMAT_TYPE_UNDEFINED; |
| 1729 | } |
| 1730 | } |
| 1731 | |
| 1732 | static uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { |
| 1733 | uint32_t bit_pos = u_ffs(stage); |
| 1734 | return bit_pos - 1; |
| 1735 | } |
| 1736 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1737 | static bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1738 | // Walk the binding descriptions, which describe the step rate and stride of each vertex buffer. Each binding should |
| 1739 | // be specified only once. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1740 | std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; |
| 1741 | bool pass = true; |
| 1742 | |
| 1743 | for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { |
| 1744 | auto desc = &vi->pVertexBindingDescriptions[i]; |
| 1745 | auto &binding = bindings[desc->binding]; |
| 1746 | if (binding) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 1747 | // TODO: VALIDATION_ERROR_02105 perhaps? |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1748 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1749 | __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", |
| 1750 | "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { |
| 1751 | pass = false; |
| 1752 | } |
| 1753 | } else { |
| 1754 | binding = desc; |
| 1755 | } |
| 1756 | } |
| 1757 | |
| 1758 | return pass; |
| 1759 | } |
| 1760 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1761 | static bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1762 | shader_module const *vs, spirv_inst_iter entrypoint) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1763 | bool pass = true; |
| 1764 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1765 | auto inputs = collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, false); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1766 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1767 | // Build index by location |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1768 | std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; |
| 1769 | if (vi) { |
Chris Forbes | e32b78a | 2016-04-21 15:00:58 +1200 | [diff] [blame] | 1770 | for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { |
| 1771 | auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); |
| 1772 | for (auto j = 0u; j < num_locations; j++) { |
| 1773 | attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; |
| 1774 | } |
| 1775 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1776 | } |
| 1777 | |
| 1778 | auto it_a = attribs.begin(); |
| 1779 | auto it_b = inputs.begin(); |
Chris Forbes | 22dd5d2 | 2016-07-06 12:18:26 +1200 | [diff] [blame] | 1780 | bool used = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1781 | |
| 1782 | while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { |
| 1783 | bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); |
| 1784 | bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); |
| 1785 | auto a_first = a_at_end ? 0 : it_a->first; |
| 1786 | auto b_first = b_at_end ? 0 : it_b->first.first; |
| 1787 | if (!a_at_end && (b_at_end || a_first < b_first)) { |
Chris Forbes | 22dd5d2 | 2016-07-06 12:18:26 +1200 | [diff] [blame] | 1788 | if (!used && log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 1789 | __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 1790 | "Vertex attribute at location %d not consumed by vertex shader", a_first)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1791 | pass = false; |
| 1792 | } |
Chris Forbes | 22dd5d2 | 2016-07-06 12:18:26 +1200 | [diff] [blame] | 1793 | used = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1794 | it_a++; |
| 1795 | } else if (!b_at_end && (a_at_end || b_first < a_first)) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1796 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 0, |
Mike Weiblen | 15bd38e | 2016-10-03 19:19:41 -0600 | [diff] [blame] | 1797 | __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Vertex shader consumes input at location %d but not provided", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1798 | b_first)) { |
| 1799 | pass = false; |
| 1800 | } |
| 1801 | it_b++; |
| 1802 | } else { |
| 1803 | unsigned attrib_type = get_format_type(it_a->second->format); |
| 1804 | unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); |
| 1805 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1806 | // Type checking |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1807 | if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1808 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1809 | __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
Mike Weiblen | 15bd38e | 2016-10-03 19:19:41 -0600 | [diff] [blame] | 1810 | "Attribute type of `%s` at location %d does not match vertex shader input type of `%s`", |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1811 | string_VkFormat(it_a->second->format), a_first, |
| 1812 | describe_type(vs, it_b->second.type_id).c_str())) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1813 | pass = false; |
| 1814 | } |
| 1815 | } |
| 1816 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1817 | // OK! |
Chris Forbes | 22dd5d2 | 2016-07-06 12:18:26 +1200 | [diff] [blame] | 1818 | used = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1819 | it_b++; |
| 1820 | } |
| 1821 | } |
| 1822 | |
| 1823 | return pass; |
| 1824 | } |
| 1825 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1826 | static bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 1827 | spirv_inst_iter entrypoint, VkRenderPassCreateInfo const *rpci, |
| 1828 | uint32_t subpass_index) { |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1829 | std::map<uint32_t, VkFormat> color_attachments; |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 1830 | auto subpass = rpci->pSubpasses[subpass_index]; |
| 1831 | for (auto i = 0u; i < subpass.colorAttachmentCount; ++i) { |
Tobin Ehlis | 0265618 | 2016-07-01 13:54:41 -0600 | [diff] [blame] | 1832 | uint32_t attachment = subpass.pColorAttachments[i].attachment; |
| 1833 | if (attachment == VK_ATTACHMENT_UNUSED) |
| 1834 | continue; |
| 1835 | if (rpci->pAttachments[attachment].format != VK_FORMAT_UNDEFINED) { |
| 1836 | color_attachments[i] = rpci->pAttachments[attachment].format; |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1837 | } |
| 1838 | } |
| 1839 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1840 | bool pass = true; |
| 1841 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1842 | // TODO: dual source blend index (spv::DecIndex, zero if not provided) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1843 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1844 | auto outputs = collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, false); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1845 | |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1846 | auto it_a = outputs.begin(); |
| 1847 | auto it_b = color_attachments.begin(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1848 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1849 | // Walk attachment list and outputs together |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1850 | |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1851 | while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { |
| 1852 | bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); |
| 1853 | bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); |
| 1854 | |
| 1855 | if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1856 | if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1857 | __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 1858 | "fragment shader writes to output location %d with no matching attachment", it_a->first.first)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1859 | pass = false; |
| 1860 | } |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1861 | it_a++; |
| 1862 | } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1863 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 1864 | __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by fragment shader", |
| 1865 | it_b->first)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1866 | pass = false; |
| 1867 | } |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1868 | it_b++; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1869 | } else { |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1870 | unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); |
| 1871 | unsigned att_type = get_format_type(it_b->second); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1872 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1873 | // Type checking |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1874 | if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1875 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1876 | __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 1877 | "Attachment %d of type `%s` does not match fragment shader output type of `%s`", it_b->first, |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1878 | string_VkFormat(it_b->second), |
| 1879 | describe_type(fs, it_a->second.type_id).c_str())) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1880 | pass = false; |
| 1881 | } |
| 1882 | } |
| 1883 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1884 | // OK! |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1885 | it_a++; |
| 1886 | it_b++; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1887 | } |
| 1888 | } |
| 1889 | |
| 1890 | return pass; |
| 1891 | } |
| 1892 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1893 | // For some analyses, we need to know about all ids referenced by the static call tree of a particular entrypoint. This is |
| 1894 | // important for identifying the set of shader resources actually used by an entrypoint, for example. |
| 1895 | // Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. |
| 1896 | // - NOT the shader input/output interfaces. |
| 1897 | // |
| 1898 | // TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth |
| 1899 | // converting parts of this to be generated from the machine-readable spec instead. |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1900 | static std::unordered_set<uint32_t> mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint) { |
| 1901 | std::unordered_set<uint32_t> ids; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1902 | std::unordered_set<uint32_t> worklist; |
| 1903 | worklist.insert(entrypoint.word(2)); |
| 1904 | |
| 1905 | while (!worklist.empty()) { |
| 1906 | auto id_iter = worklist.begin(); |
| 1907 | auto id = *id_iter; |
| 1908 | worklist.erase(id_iter); |
| 1909 | |
| 1910 | auto insn = src->get_def(id); |
| 1911 | if (insn == src->end()) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1912 | // ID is something we didn't collect in build_def_index. that's OK -- we'll stumble across all kinds of things here |
| 1913 | // that we may not care about. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1914 | continue; |
| 1915 | } |
| 1916 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1917 | // Try to add to the output set |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1918 | if (!ids.insert(id).second) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1919 | continue; // If we already saw this id, we don't want to walk it again. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1920 | } |
| 1921 | |
| 1922 | switch (insn.opcode()) { |
| 1923 | case spv::OpFunction: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1924 | // Scan whole body of the function, enlisting anything interesting |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1925 | while (++insn, insn.opcode() != spv::OpFunctionEnd) { |
| 1926 | switch (insn.opcode()) { |
| 1927 | case spv::OpLoad: |
| 1928 | case spv::OpAtomicLoad: |
| 1929 | case spv::OpAtomicExchange: |
| 1930 | case spv::OpAtomicCompareExchange: |
| 1931 | case spv::OpAtomicCompareExchangeWeak: |
| 1932 | case spv::OpAtomicIIncrement: |
| 1933 | case spv::OpAtomicIDecrement: |
| 1934 | case spv::OpAtomicIAdd: |
| 1935 | case spv::OpAtomicISub: |
| 1936 | case spv::OpAtomicSMin: |
| 1937 | case spv::OpAtomicUMin: |
| 1938 | case spv::OpAtomicSMax: |
| 1939 | case spv::OpAtomicUMax: |
| 1940 | case spv::OpAtomicAnd: |
| 1941 | case spv::OpAtomicOr: |
| 1942 | case spv::OpAtomicXor: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1943 | worklist.insert(insn.word(3)); // ptr |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1944 | break; |
| 1945 | case spv::OpStore: |
| 1946 | case spv::OpAtomicStore: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1947 | worklist.insert(insn.word(1)); // ptr |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1948 | break; |
| 1949 | case spv::OpAccessChain: |
| 1950 | case spv::OpInBoundsAccessChain: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1951 | worklist.insert(insn.word(3)); // base ptr |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1952 | break; |
| 1953 | case spv::OpSampledImage: |
| 1954 | case spv::OpImageSampleImplicitLod: |
| 1955 | case spv::OpImageSampleExplicitLod: |
| 1956 | case spv::OpImageSampleDrefImplicitLod: |
| 1957 | case spv::OpImageSampleDrefExplicitLod: |
| 1958 | case spv::OpImageSampleProjImplicitLod: |
| 1959 | case spv::OpImageSampleProjExplicitLod: |
| 1960 | case spv::OpImageSampleProjDrefImplicitLod: |
| 1961 | case spv::OpImageSampleProjDrefExplicitLod: |
| 1962 | case spv::OpImageFetch: |
| 1963 | case spv::OpImageGather: |
| 1964 | case spv::OpImageDrefGather: |
| 1965 | case spv::OpImageRead: |
| 1966 | case spv::OpImage: |
| 1967 | case spv::OpImageQueryFormat: |
| 1968 | case spv::OpImageQueryOrder: |
| 1969 | case spv::OpImageQuerySizeLod: |
| 1970 | case spv::OpImageQuerySize: |
| 1971 | case spv::OpImageQueryLod: |
| 1972 | case spv::OpImageQueryLevels: |
| 1973 | case spv::OpImageQuerySamples: |
| 1974 | case spv::OpImageSparseSampleImplicitLod: |
| 1975 | case spv::OpImageSparseSampleExplicitLod: |
| 1976 | case spv::OpImageSparseSampleDrefImplicitLod: |
| 1977 | case spv::OpImageSparseSampleDrefExplicitLod: |
| 1978 | case spv::OpImageSparseSampleProjImplicitLod: |
| 1979 | case spv::OpImageSparseSampleProjExplicitLod: |
| 1980 | case spv::OpImageSparseSampleProjDrefImplicitLod: |
| 1981 | case spv::OpImageSparseSampleProjDrefExplicitLod: |
| 1982 | case spv::OpImageSparseFetch: |
| 1983 | case spv::OpImageSparseGather: |
| 1984 | case spv::OpImageSparseDrefGather: |
| 1985 | case spv::OpImageTexelPointer: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1986 | worklist.insert(insn.word(3)); // Image or sampled image |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1987 | break; |
| 1988 | case spv::OpImageWrite: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1989 | worklist.insert(insn.word(1)); // Image -- different operand order to above |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1990 | break; |
| 1991 | case spv::OpFunctionCall: |
Michael Mc Donnell | 75ecdb7 | 2016-04-03 14:47:51 -0700 | [diff] [blame] | 1992 | for (uint32_t i = 3; i < insn.len(); i++) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1993 | worklist.insert(insn.word(i)); // fn itself, and all args |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1994 | } |
| 1995 | break; |
| 1996 | |
| 1997 | case spv::OpExtInst: |
Michael Mc Donnell | 75ecdb7 | 2016-04-03 14:47:51 -0700 | [diff] [blame] | 1998 | for (uint32_t i = 5; i < insn.len(); i++) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1999 | worklist.insert(insn.word(i)); // Operands to ext inst |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2000 | } |
| 2001 | break; |
| 2002 | } |
| 2003 | } |
| 2004 | break; |
| 2005 | } |
| 2006 | } |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 2007 | |
| 2008 | return ids; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2009 | } |
| 2010 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2011 | static bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2012 | std::vector<VkPushConstantRange> const *push_constant_ranges, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2013 | shader_module const *src, spirv_inst_iter type, |
| 2014 | VkShaderStageFlagBits stage) { |
| 2015 | bool pass = true; |
| 2016 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2017 | // Strip off ptrs etc |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2018 | type = get_struct_type(src, type, false); |
| 2019 | assert(type != src->end()); |
| 2020 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2021 | // Validate directly off the offsets. this isn't quite correct for arrays and matrices, but is a good first step. |
| 2022 | // TODO: arrays, matrices, weird sizes |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2023 | for (auto insn : *src) { |
| 2024 | if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { |
| 2025 | |
| 2026 | if (insn.word(3) == spv::DecorationOffset) { |
| 2027 | unsigned offset = insn.word(4); |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2028 | auto size = 4; // Bytes; TODO: calculate this based on the type |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2029 | |
| 2030 | bool found_range = false; |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2031 | for (auto const &range : *push_constant_ranges) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2032 | if (range.offset <= offset && range.offset + range.size >= offset + size) { |
| 2033 | found_range = true; |
| 2034 | |
| 2035 | if ((range.stageFlags & stage) == 0) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2036 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 2037 | __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2038 | "Push constant range covering variable starting at " |
| 2039 | "offset %u not accessible from stage %s", |
| 2040 | offset, string_VkShaderStageFlagBits(stage))) { |
| 2041 | pass = false; |
| 2042 | } |
| 2043 | } |
| 2044 | |
| 2045 | break; |
| 2046 | } |
| 2047 | } |
| 2048 | |
| 2049 | if (!found_range) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2050 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 2051 | __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2052 | "Push constant range covering variable starting at " |
| 2053 | "offset %u not declared in layout", |
| 2054 | offset)) { |
| 2055 | pass = false; |
| 2056 | } |
| 2057 | } |
| 2058 | } |
| 2059 | } |
| 2060 | } |
| 2061 | |
| 2062 | return pass; |
| 2063 | } |
| 2064 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2065 | static bool validate_push_constant_usage(debug_report_data *report_data, |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2066 | std::vector<VkPushConstantRange> const *push_constant_ranges, shader_module const *src, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2067 | std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { |
| 2068 | bool pass = true; |
| 2069 | |
| 2070 | for (auto id : accessible_ids) { |
| 2071 | auto def_insn = src->get_def(id); |
| 2072 | if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2073 | pass &= validate_push_constant_block_against_pipeline(report_data, push_constant_ranges, src, |
| 2074 | src->get_def(def_insn.word(1)), stage); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2075 | } |
| 2076 | } |
| 2077 | |
| 2078 | return pass; |
| 2079 | } |
| 2080 | |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 2081 | // For given pipelineLayout verify that the set_layout_node at slot.first |
| 2082 | // has the requested binding at slot.second and return ptr to that binding |
Chris Forbes | 81d9521 | 2016-05-20 18:27:28 +1200 | [diff] [blame] | 2083 | static VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2084 | |
| 2085 | if (!pipelineLayout) |
Chris Forbes | 4e4191b | 2016-03-18 11:14:27 +1300 | [diff] [blame] | 2086 | return nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2087 | |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2088 | if (slot.first >= pipelineLayout->set_layouts.size()) |
Chris Forbes | 4e4191b | 2016-03-18 11:14:27 +1300 | [diff] [blame] | 2089 | return nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2090 | |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2091 | return pipelineLayout->set_layouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2092 | } |
| 2093 | |
| 2094 | // Block of code at start here for managing/tracking Pipeline state that this layer cares about |
| 2095 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2096 | // TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound |
| 2097 | // Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates |
| 2098 | // to that same cmd buffer by separate thread are not changing state from underneath us |
| 2099 | // Track the last cmd buffer touched by this thread |
| 2100 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2101 | static bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2102 | for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { |
| 2103 | if (pCB->drawCount[i]) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2104 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2105 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2106 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2107 | } |
| 2108 | |
| 2109 | // Check object status for selected flag state |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2110 | static bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2111 | const char *fail_msg, UNIQUE_VALIDATION_ERROR_CODE const msg_code) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2112 | if (!(pNode->status & status_mask)) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2113 | char const *const message = validation_error_map[msg_code]; |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2114 | return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2115 | reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, msg_code, "DS", |
| 2116 | "command buffer object 0x%p: %s. %s.", pNode->commandBuffer, fail_msg, message); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2117 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2118 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2119 | } |
| 2120 | |
| 2121 | // Retrieve pipeline node ptr for given pipeline object |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2122 | static PIPELINE_STATE *getPipelineState(layer_data const *my_data, VkPipeline pipeline) { |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2123 | auto it = my_data->pipelineMap.find(pipeline); |
| 2124 | if (it == my_data->pipelineMap.end()) { |
| 2125 | return nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2126 | } |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2127 | return it->second; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2128 | } |
| 2129 | |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 2130 | static RENDER_PASS_STATE *getRenderPassState(layer_data const *my_data, VkRenderPass renderpass) { |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 2131 | auto it = my_data->renderPassMap.find(renderpass); |
| 2132 | if (it == my_data->renderPassMap.end()) { |
| 2133 | return nullptr; |
| 2134 | } |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 2135 | return it->second.get(); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 2136 | } |
| 2137 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 2138 | static FRAMEBUFFER_STATE *getFramebufferState(const layer_data *my_data, VkFramebuffer framebuffer) { |
Chris Forbes | 05e03b7 | 2016-05-17 15:27:58 +1200 | [diff] [blame] | 2139 | auto it = my_data->frameBufferMap.find(framebuffer); |
| 2140 | if (it == my_data->frameBufferMap.end()) { |
| 2141 | return nullptr; |
| 2142 | } |
Tobin Ehlis | 82d2db3 | 2016-06-22 08:29:24 -0600 | [diff] [blame] | 2143 | return it->second.get(); |
Chris Forbes | 05e03b7 | 2016-05-17 15:27:58 +1200 | [diff] [blame] | 2144 | } |
| 2145 | |
Tobin Ehlis | 815e813 | 2016-06-02 13:02:17 -0600 | [diff] [blame] | 2146 | cvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { |
Chris Forbes | 056d992 | 2016-05-20 17:04:07 +1200 | [diff] [blame] | 2147 | auto it = my_data->descriptorSetLayoutMap.find(dsLayout); |
| 2148 | if (it == my_data->descriptorSetLayoutMap.end()) { |
| 2149 | return nullptr; |
| 2150 | } |
| 2151 | return it->second; |
| 2152 | } |
| 2153 | |
Tobin Ehlis | c1d9be1 | 2016-10-13 10:18:18 -0600 | [diff] [blame] | 2154 | static PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { |
Chris Forbes | 81d9521 | 2016-05-20 18:27:28 +1200 | [diff] [blame] | 2155 | auto it = my_data->pipelineLayoutMap.find(pipeLayout); |
| 2156 | if (it == my_data->pipelineLayoutMap.end()) { |
| 2157 | return nullptr; |
| 2158 | } |
| 2159 | return &it->second; |
| 2160 | } |
| 2161 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2162 | // Return true if for a given PSO, the given state enum is dynamic, else return false |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2163 | static bool isDynamic(const PIPELINE_STATE *pPipeline, const VkDynamicState state) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2164 | if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { |
| 2165 | for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { |
| 2166 | if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2167 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2168 | } |
| 2169 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2170 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2171 | } |
| 2172 | |
| 2173 | // Validate state stored as flags at time of draw call |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2174 | static bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_STATE *pPipe, bool indexed, |
| 2175 | UNIQUE_VALIDATION_ERROR_CODE const msg_code) { |
Chris Forbes | b2ba95b | 2016-09-16 17:11:50 +1200 | [diff] [blame] | 2176 | bool result = false; |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 2177 | if (pPipe->graphicsPipelineCI.pInputAssemblyState && |
| 2178 | ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || |
| 2179 | (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2180 | result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2181 | "Dynamic line width state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2182 | } |
Dustin Graves | bd9c1a9 | 2016-04-05 15:15:40 -0600 | [diff] [blame] | 2183 | if (pPipe->graphicsPipelineCI.pRasterizationState && |
| 2184 | (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2185 | result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2186 | "Dynamic depth bias state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2187 | } |
| 2188 | if (pPipe->blendConstantsEnabled) { |
| 2189 | result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2190 | "Dynamic blend constants state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2191 | } |
Dustin Graves | bd9c1a9 | 2016-04-05 15:15:40 -0600 | [diff] [blame] | 2192 | if (pPipe->graphicsPipelineCI.pDepthStencilState && |
| 2193 | (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2194 | result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2195 | "Dynamic depth bounds state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2196 | } |
Dustin Graves | bd9c1a9 | 2016-04-05 15:15:40 -0600 | [diff] [blame] | 2197 | if (pPipe->graphicsPipelineCI.pDepthStencilState && |
| 2198 | (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2199 | result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2200 | "Dynamic stencil read mask state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2201 | result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2202 | "Dynamic stencil write mask state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2203 | result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2204 | "Dynamic stencil reference state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2205 | } |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 2206 | if (indexed) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2207 | result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2208 | "Index buffer object not bound to this command buffer when Indexed Draw attempted", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2209 | } |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2210 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2211 | return result; |
| 2212 | } |
| 2213 | |
| 2214 | // Verify attachment reference compatibility according to spec |
| 2215 | // If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this |
Mark Lobodzinski | 4c94c28 | 2016-06-20 18:49:25 -0600 | [diff] [blame] | 2216 | // If both AttachmentReference arrays have requested index, check their corresponding AttachmentDescriptions |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2217 | // to make sure that format and samples counts match. |
| 2218 | // If not, they are not compatible. |
| 2219 | static bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, |
| 2220 | const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, |
| 2221 | const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, |
| 2222 | const VkAttachmentDescription *pSecondaryAttachments) { |
Tobin Ehlis | c231aae | 2016-06-10 02:36:25 -0600 | [diff] [blame] | 2223 | // Check potential NULL cases first to avoid nullptr issues later |
| 2224 | if (pPrimary == nullptr) { |
| 2225 | if (pSecondary == nullptr) { |
| 2226 | return true; |
| 2227 | } |
| 2228 | return false; |
| 2229 | } else if (pSecondary == nullptr) { |
| 2230 | return false; |
| 2231 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2232 | if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED |
Mark Young | eeafb15 | 2016-03-24 10:14:35 -0600 | [diff] [blame] | 2233 | if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) |
| 2234 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2235 | } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED |
Mark Young | eeafb15 | 2016-03-24 10:14:35 -0600 | [diff] [blame] | 2236 | if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) |
| 2237 | return true; |
Mark Lobodzinski | 4c94c28 | 2016-06-20 18:49:25 -0600 | [diff] [blame] | 2238 | } else { // Format and sample count must match |
| 2239 | if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) && (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { |
| 2240 | return true; |
| 2241 | } else if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) || (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { |
| 2242 | return false; |
| 2243 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2244 | if ((pPrimaryAttachments[pPrimary[index].attachment].format == |
| 2245 | pSecondaryAttachments[pSecondary[index].attachment].format) && |
| 2246 | (pPrimaryAttachments[pPrimary[index].attachment].samples == |
| 2247 | pSecondaryAttachments[pSecondary[index].attachment].samples)) |
| 2248 | return true; |
| 2249 | } |
| 2250 | // Format and sample counts didn't match |
| 2251 | return false; |
| 2252 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 2253 | // TODO : Scrub verify_renderpass_compatibility() and validateRenderPassCompatibility() and unify them and/or share code |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 2254 | // For given primary RenderPass object and secondry RenderPassCreateInfo, verify that they're compatible |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 2255 | static bool verify_renderpass_compatibility(const layer_data *my_data, const VkRenderPassCreateInfo *primaryRPCI, |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 2256 | const VkRenderPassCreateInfo *secondaryRPCI, string &errorMsg) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2257 | if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2258 | stringstream errorStr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2259 | errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount |
| 2260 | << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; |
| 2261 | errorMsg = errorStr.str(); |
| 2262 | return false; |
| 2263 | } |
| 2264 | uint32_t spIndex = 0; |
| 2265 | for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { |
| 2266 | // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible |
| 2267 | uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; |
| 2268 | uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; |
| 2269 | uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); |
| 2270 | for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { |
| 2271 | if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, |
| 2272 | primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, |
| 2273 | secondaryColorCount, secondaryRPCI->pAttachments)) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2274 | stringstream errorStr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2275 | errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; |
| 2276 | errorMsg = errorStr.str(); |
| 2277 | return false; |
| 2278 | } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, |
| 2279 | primaryColorCount, primaryRPCI->pAttachments, |
| 2280 | secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, |
| 2281 | secondaryColorCount, secondaryRPCI->pAttachments)) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2282 | stringstream errorStr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2283 | errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; |
| 2284 | errorMsg = errorStr.str(); |
| 2285 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2286 | } |
| 2287 | } |
Chris Forbes | b442e56 | 2016-04-11 18:32:23 +1200 | [diff] [blame] | 2288 | |
| 2289 | if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, |
| 2290 | 1, primaryRPCI->pAttachments, |
| 2291 | secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, |
| 2292 | 1, secondaryRPCI->pAttachments)) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2293 | stringstream errorStr; |
Chris Forbes | b442e56 | 2016-04-11 18:32:23 +1200 | [diff] [blame] | 2294 | errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; |
| 2295 | errorMsg = errorStr.str(); |
| 2296 | return false; |
| 2297 | } |
| 2298 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2299 | uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; |
| 2300 | uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; |
| 2301 | uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); |
| 2302 | for (uint32_t i = 0; i < inputMax; ++i) { |
| 2303 | if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, |
| 2304 | primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, |
| 2305 | secondaryColorCount, secondaryRPCI->pAttachments)) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2306 | stringstream errorStr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2307 | errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; |
| 2308 | errorMsg = errorStr.str(); |
| 2309 | return false; |
| 2310 | } |
| 2311 | } |
| 2312 | } |
| 2313 | return true; |
| 2314 | } |
| 2315 | |
Tobin Ehlis | 05be5df | 2016-05-05 08:25:02 -0600 | [diff] [blame] | 2316 | // For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to |
| 2317 | // pipelineLayout[layoutIndex] |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 2318 | static bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *descriptor_set, |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 2319 | PIPELINE_LAYOUT_NODE const *pipeline_layout, const uint32_t layoutIndex, |
| 2320 | string &errorMsg) { |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2321 | auto num_sets = pipeline_layout->set_layouts.size(); |
Tobin Ehlis | a382a95 | 2016-07-07 09:20:13 -0600 | [diff] [blame] | 2322 | if (layoutIndex >= num_sets) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2323 | stringstream errorStr; |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 2324 | errorStr << "VkPipelineLayout (" << pipeline_layout->layout << ") only contains " << num_sets |
| 2325 | << " setLayouts corresponding to sets 0-" << num_sets - 1 << ", but you're attempting to bind set to index " |
| 2326 | << layoutIndex; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2327 | errorMsg = errorStr.str(); |
| 2328 | return false; |
| 2329 | } |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2330 | auto layout_node = pipeline_layout->set_layouts[layoutIndex]; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 2331 | return descriptor_set->IsCompatible(layout_node, &errorMsg); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2332 | } |
| 2333 | |
| 2334 | // Validate that data for each specialization entry is fully contained within the buffer. |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2335 | static bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2336 | bool pass = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2337 | |
| 2338 | VkSpecializationInfo const *spec = info->pSpecializationInfo; |
| 2339 | |
| 2340 | if (spec) { |
| 2341 | for (auto i = 0u; i < spec->mapEntryCount; i++) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2342 | // TODO: This is a good place for VALIDATION_ERROR_00589. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2343 | if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2344 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 0, __LINE__, |
| 2345 | VALIDATION_ERROR_00590, "SC", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2346 | "Specialization entry %u (for constant id %u) references memory outside provided " |
| 2347 | "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2348 | " bytes provided). %s.", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2349 | i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2350 | spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize, |
| 2351 | validation_error_map[VALIDATION_ERROR_00590])) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2352 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2353 | pass = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2354 | } |
| 2355 | } |
| 2356 | } |
| 2357 | } |
| 2358 | |
| 2359 | return pass; |
| 2360 | } |
| 2361 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2362 | static bool descriptor_type_match(shader_module const *module, uint32_t type_id, |
Chris Forbes | b9fb5fc | 2016-03-18 11:21:35 +1300 | [diff] [blame] | 2363 | VkDescriptorType descriptor_type, unsigned &descriptor_count) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2364 | auto type = module->get_def(type_id); |
| 2365 | |
Chris Forbes | b9fb5fc | 2016-03-18 11:21:35 +1300 | [diff] [blame] | 2366 | descriptor_count = 1; |
| 2367 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2368 | // Strip off any array or ptrs. Where we remove array levels, adjust the descriptor count for each dimension. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2369 | while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { |
Chris Forbes | a136109 | 2016-03-18 11:26:06 +1300 | [diff] [blame] | 2370 | if (type.opcode() == spv::OpTypeArray) { |
| 2371 | descriptor_count *= get_constant_value(module, type.word(3)); |
| 2372 | type = module->get_def(type.word(2)); |
| 2373 | } |
| 2374 | else { |
| 2375 | type = module->get_def(type.word(3)); |
| 2376 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2377 | } |
| 2378 | |
| 2379 | switch (type.opcode()) { |
| 2380 | case spv::OpTypeStruct: { |
| 2381 | for (auto insn : *module) { |
| 2382 | if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { |
| 2383 | if (insn.word(2) == spv::DecorationBlock) { |
| 2384 | return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || |
| 2385 | descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; |
| 2386 | } else if (insn.word(2) == spv::DecorationBufferBlock) { |
| 2387 | return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || |
| 2388 | descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; |
| 2389 | } |
| 2390 | } |
| 2391 | } |
| 2392 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2393 | // Invalid |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2394 | return false; |
| 2395 | } |
| 2396 | |
| 2397 | case spv::OpTypeSampler: |
Chris Forbes | b9e3a08 | 2016-07-19 14:50:04 +1200 | [diff] [blame] | 2398 | return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER || |
| 2399 | descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2400 | |
| 2401 | case spv::OpTypeSampledImage: |
Chris Forbes | ccf300b | 2016-03-24 14:14:45 +1300 | [diff] [blame] | 2402 | if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2403 | // Slight relaxation for some GLSL historical madness: samplerBuffer doesn't really have a sampler, and a texel |
| 2404 | // buffer descriptor doesn't really provide one. Allow this slight mismatch. |
Chris Forbes | ccf300b | 2016-03-24 14:14:45 +1300 | [diff] [blame] | 2405 | auto image_type = module->get_def(type.word(2)); |
| 2406 | auto dim = image_type.word(3); |
| 2407 | auto sampled = image_type.word(7); |
| 2408 | return dim == spv::DimBuffer && sampled == 1; |
| 2409 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2410 | return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; |
| 2411 | |
| 2412 | case spv::OpTypeImage: { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2413 | // Many descriptor types backing image types-- depends on dimension and whether the image will be used with a sampler. |
| 2414 | // SPIRV for Vulkan requires that sampled be 1 or 2 -- leaving the decision to runtime is unacceptable. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2415 | auto dim = type.word(3); |
| 2416 | auto sampled = type.word(7); |
| 2417 | |
| 2418 | if (dim == spv::DimSubpassData) { |
| 2419 | return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; |
| 2420 | } else if (dim == spv::DimBuffer) { |
| 2421 | if (sampled == 1) { |
| 2422 | return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; |
| 2423 | } else { |
| 2424 | return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; |
| 2425 | } |
| 2426 | } else if (sampled == 1) { |
Chris Forbes | b9e3a08 | 2016-07-19 14:50:04 +1200 | [diff] [blame] | 2427 | return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE || |
| 2428 | descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2429 | } else { |
| 2430 | return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; |
| 2431 | } |
| 2432 | } |
| 2433 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2434 | // We shouldn't really see any other junk types -- but if we do, they're a mismatch. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2435 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2436 | return false; // Mismatch |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2437 | } |
| 2438 | } |
| 2439 | |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2440 | static bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2441 | if (!feature) { |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2442 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 2443 | __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2444 | "Shader requires VkPhysicalDeviceFeatures::%s but is not " |
| 2445 | "enabled on the device", |
| 2446 | feature_name)) { |
| 2447 | return false; |
| 2448 | } |
| 2449 | } |
| 2450 | |
| 2451 | return true; |
| 2452 | } |
| 2453 | |
Chris Forbes | c9b826c | 2016-05-13 13:17:42 +1200 | [diff] [blame] | 2454 | static bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, |
| 2455 | VkPhysicalDeviceFeatures const *enabledFeatures) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2456 | bool pass = true; |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2457 | |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2458 | |
| 2459 | for (auto insn : *src) { |
| 2460 | if (insn.opcode() == spv::OpCapability) { |
| 2461 | switch (insn.word(1)) { |
| 2462 | case spv::CapabilityMatrix: |
| 2463 | case spv::CapabilityShader: |
| 2464 | case spv::CapabilityInputAttachment: |
| 2465 | case spv::CapabilitySampled1D: |
| 2466 | case spv::CapabilityImage1D: |
| 2467 | case spv::CapabilitySampledBuffer: |
| 2468 | case spv::CapabilityImageBuffer: |
| 2469 | case spv::CapabilityImageQuery: |
| 2470 | case spv::CapabilityDerivativeControl: |
| 2471 | // Always supported by a Vulkan 1.0 implementation -- no feature bits. |
| 2472 | break; |
| 2473 | |
| 2474 | case spv::CapabilityGeometry: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2475 | pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2476 | break; |
| 2477 | |
| 2478 | case spv::CapabilityTessellation: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2479 | pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2480 | break; |
| 2481 | |
| 2482 | case spv::CapabilityFloat64: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2483 | pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2484 | break; |
| 2485 | |
| 2486 | case spv::CapabilityInt64: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2487 | pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2488 | break; |
| 2489 | |
| 2490 | case spv::CapabilityTessellationPointSize: |
| 2491 | case spv::CapabilityGeometryPointSize: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2492 | pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2493 | "shaderTessellationAndGeometryPointSize"); |
| 2494 | break; |
| 2495 | |
| 2496 | case spv::CapabilityImageGatherExtended: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2497 | pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2498 | break; |
| 2499 | |
| 2500 | case spv::CapabilityStorageImageMultisample: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2501 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2502 | break; |
| 2503 | |
| 2504 | case spv::CapabilityUniformBufferArrayDynamicIndexing: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2505 | pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2506 | "shaderUniformBufferArrayDynamicIndexing"); |
| 2507 | break; |
| 2508 | |
| 2509 | case spv::CapabilitySampledImageArrayDynamicIndexing: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2510 | pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2511 | "shaderSampledImageArrayDynamicIndexing"); |
| 2512 | break; |
| 2513 | |
| 2514 | case spv::CapabilityStorageBufferArrayDynamicIndexing: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2515 | pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2516 | "shaderStorageBufferArrayDynamicIndexing"); |
| 2517 | break; |
| 2518 | |
| 2519 | case spv::CapabilityStorageImageArrayDynamicIndexing: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2520 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2521 | "shaderStorageImageArrayDynamicIndexing"); |
| 2522 | break; |
| 2523 | |
| 2524 | case spv::CapabilityClipDistance: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2525 | pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2526 | break; |
| 2527 | |
| 2528 | case spv::CapabilityCullDistance: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2529 | pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2530 | break; |
| 2531 | |
| 2532 | case spv::CapabilityImageCubeArray: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2533 | pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2534 | break; |
| 2535 | |
| 2536 | case spv::CapabilitySampleRateShading: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2537 | pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2538 | break; |
| 2539 | |
| 2540 | case spv::CapabilitySparseResidency: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2541 | pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2542 | break; |
| 2543 | |
| 2544 | case spv::CapabilityMinLod: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2545 | pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2546 | break; |
| 2547 | |
| 2548 | case spv::CapabilitySampledCubeArray: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2549 | pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2550 | break; |
| 2551 | |
| 2552 | case spv::CapabilityImageMSArray: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2553 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2554 | break; |
| 2555 | |
| 2556 | case spv::CapabilityStorageImageExtendedFormats: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2557 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2558 | "shaderStorageImageExtendedFormats"); |
| 2559 | break; |
| 2560 | |
| 2561 | case spv::CapabilityInterpolationFunction: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2562 | pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2563 | break; |
| 2564 | |
| 2565 | case spv::CapabilityStorageImageReadWithoutFormat: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2566 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2567 | "shaderStorageImageReadWithoutFormat"); |
| 2568 | break; |
| 2569 | |
| 2570 | case spv::CapabilityStorageImageWriteWithoutFormat: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2571 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2572 | "shaderStorageImageWriteWithoutFormat"); |
| 2573 | break; |
| 2574 | |
| 2575 | case spv::CapabilityMultiViewport: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2576 | pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2577 | break; |
| 2578 | |
| 2579 | default: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2580 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2581 | __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", |
| 2582 | "Shader declares capability %u, not supported in Vulkan.", |
| 2583 | insn.word(1))) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2584 | pass = false; |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2585 | break; |
| 2586 | } |
| 2587 | } |
| 2588 | } |
| 2589 | |
| 2590 | return pass; |
| 2591 | } |
| 2592 | |
Chris Forbes | c7090a8 | 2016-07-25 18:10:41 +1200 | [diff] [blame] | 2593 | |
| 2594 | static uint32_t descriptor_type_to_reqs(shader_module const *module, uint32_t type_id) { |
Chris Forbes | 0b38947 | 2016-07-25 18:12:05 +1200 | [diff] [blame] | 2595 | auto type = module->get_def(type_id); |
| 2596 | |
| 2597 | while (true) { |
| 2598 | switch (type.opcode()) { |
| 2599 | case spv::OpTypeArray: |
| 2600 | case spv::OpTypeSampledImage: |
| 2601 | type = module->get_def(type.word(2)); |
| 2602 | break; |
| 2603 | case spv::OpTypePointer: |
| 2604 | type = module->get_def(type.word(3)); |
| 2605 | break; |
| 2606 | case spv::OpTypeImage: { |
| 2607 | auto dim = type.word(3); |
| 2608 | auto arrayed = type.word(5); |
| 2609 | auto msaa = type.word(6); |
| 2610 | |
| 2611 | switch (dim) { |
| 2612 | case spv::Dim1D: |
Chris Forbes | 0d250c2 | 2016-08-02 08:08:16 +1200 | [diff] [blame] | 2613 | return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_1D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_1D; |
Chris Forbes | 0b38947 | 2016-07-25 18:12:05 +1200 | [diff] [blame] | 2614 | case spv::Dim2D: |
| 2615 | return (msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE) | |
Chris Forbes | 0d250c2 | 2016-08-02 08:08:16 +1200 | [diff] [blame] | 2616 | (arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_2D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_2D); |
Chris Forbes | 0b38947 | 2016-07-25 18:12:05 +1200 | [diff] [blame] | 2617 | case spv::Dim3D: |
| 2618 | return DESCRIPTOR_REQ_VIEW_TYPE_3D; |
| 2619 | case spv::DimCube: |
Chris Forbes | 0d250c2 | 2016-08-02 08:08:16 +1200 | [diff] [blame] | 2620 | return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_CUBE_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_CUBE; |
Chris Forbes | 48a1b2e | 2016-08-31 11:59:48 -0700 | [diff] [blame] | 2621 | case spv::DimSubpassData: |
| 2622 | return msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE; |
| 2623 | default: // buffer, etc. |
Chris Forbes | 0b38947 | 2016-07-25 18:12:05 +1200 | [diff] [blame] | 2624 | return 0; |
| 2625 | } |
| 2626 | } |
| 2627 | default: |
| 2628 | return 0; |
| 2629 | } |
| 2630 | } |
Chris Forbes | c7090a8 | 2016-07-25 18:10:41 +1200 | [diff] [blame] | 2631 | } |
| 2632 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2633 | static bool |
| 2634 | validate_pipeline_shader_stage(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *pStage, |
| 2635 | PIPELINE_STATE *pipeline, shader_module **out_module, spirv_inst_iter *out_entrypoint, |
| 2636 | VkPhysicalDeviceFeatures const *enabledFeatures, |
| 2637 | std::unordered_map<VkShaderModule, std::unique_ptr<shader_module>> const &shaderModuleMap) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2638 | bool pass = true; |
Chris Forbes | c9b826c | 2016-05-13 13:17:42 +1200 | [diff] [blame] | 2639 | auto module_it = shaderModuleMap.find(pStage->module); |
| 2640 | auto module = *out_module = module_it->second.get(); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2641 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2642 | // Find the entrypoint |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2643 | auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); |
| 2644 | if (entrypoint == module->end()) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2645 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, VALIDATION_ERROR_00510, |
| 2646 | "SC", "No entrypoint found named `%s` for stage %s. %s.", pStage->pName, |
| 2647 | string_VkShaderStageFlagBits(pStage->stage), validation_error_map[VALIDATION_ERROR_00510])) { |
Chris Forbes | 1a89b3f | 2016-09-09 11:23:39 +1200 | [diff] [blame] | 2648 | return false; // no point continuing beyond here, any analysis is just going to be garbage. |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2649 | } |
| 2650 | } |
| 2651 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2652 | // Validate shader capabilities against enabled device features |
Chris Forbes | 19b6058 | 2016-05-13 13:27:58 +1200 | [diff] [blame] | 2653 | pass &= validate_shader_capabilities(report_data, module, enabledFeatures); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2654 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2655 | // Mark accessible ids |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 2656 | auto accessible_ids = mark_accessible_ids(module, entrypoint); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2657 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2658 | // Validate descriptor set layout against what the entrypoint actually uses |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 2659 | auto descriptor_uses = collect_interface_by_descriptor_slot(report_data, module, accessible_ids); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2660 | |
Tobin Ehlis | 97f401a | 2016-07-07 08:12:03 -0600 | [diff] [blame] | 2661 | auto pipelineLayout = pipeline->pipeline_layout; |
Chris Forbes | 337dbbb | 2016-05-13 13:39:17 +1200 | [diff] [blame] | 2662 | |
Chris Forbes | 1a89b3f | 2016-09-09 11:23:39 +1200 | [diff] [blame] | 2663 | pass &= validate_specialization_offsets(report_data, pStage); |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2664 | pass &= validate_push_constant_usage(report_data, &pipelineLayout.push_constant_ranges, module, accessible_ids, pStage->stage); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2665 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2666 | // Validate descriptor use |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2667 | for (auto use : descriptor_uses) { |
| 2668 | // While validating shaders capture which slots are used by the pipeline |
Chris Forbes | c7090a8 | 2016-07-25 18:10:41 +1200 | [diff] [blame] | 2669 | auto & reqs = pipeline->active_slots[use.first.first][use.first.second]; |
| 2670 | reqs = descriptor_req(reqs | descriptor_type_to_reqs(module, use.second.type_id)); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2671 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2672 | // Verify given pipelineLayout has requested setLayout with requested binding |
Tobin Ehlis | b73587d | 2016-07-07 08:14:48 -0600 | [diff] [blame] | 2673 | const auto &binding = get_descriptor_binding(&pipelineLayout, use.first); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2674 | unsigned required_descriptor_count; |
| 2675 | |
| 2676 | if (!binding) { |
Chris Forbes | 19b6058 | 2016-05-13 13:27:58 +1200 | [diff] [blame] | 2677 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 2678 | __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2679 | "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", |
| 2680 | use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2681 | pass = false; |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2682 | } |
| 2683 | } else if (~binding->stageFlags & pStage->stage) { |
Chris Forbes | 19b6058 | 2016-05-13 13:27:58 +1200 | [diff] [blame] | 2684 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2685 | 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2686 | "Shader uses descriptor slot %u.%u (used " |
| 2687 | "as type `%s`) but descriptor not " |
| 2688 | "accessible from stage %s", |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 2689 | use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2690 | string_VkShaderStageFlagBits(pStage->stage))) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2691 | pass = false; |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2692 | } |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2693 | } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2694 | required_descriptor_count)) { |
Chris Forbes | 19b6058 | 2016-05-13 13:27:58 +1200 | [diff] [blame] | 2695 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 2696 | SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " |
| 2697 | "%u.%u (used as type `%s`) but " |
| 2698 | "descriptor of type %s", |
| 2699 | use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2700 | string_VkDescriptorType(binding->descriptorType))) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2701 | pass = false; |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2702 | } |
| 2703 | } else if (binding->descriptorCount < required_descriptor_count) { |
Chris Forbes | 19b6058 | 2016-05-13 13:27:58 +1200 | [diff] [blame] | 2704 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 2705 | SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2706 | "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", |
| 2707 | required_descriptor_count, use.first.first, use.first.second, |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 2708 | describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2709 | pass = false; |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2710 | } |
| 2711 | } |
| 2712 | } |
| 2713 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2714 | // Validate use of input attachments against subpass structure |
Chris Forbes | 8420fea | 2016-08-22 15:20:11 +1200 | [diff] [blame] | 2715 | if (pStage->stage == VK_SHADER_STAGE_FRAGMENT_BIT) { |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 2716 | auto input_attachment_uses = collect_interface_by_input_attachment_index(report_data, module, accessible_ids); |
Chris Forbes | 8420fea | 2016-08-22 15:20:11 +1200 | [diff] [blame] | 2717 | |
| 2718 | auto rpci = pipeline->render_pass_ci.ptr(); |
| 2719 | auto subpass = pipeline->graphicsPipelineCI.subpass; |
| 2720 | |
| 2721 | for (auto use : input_attachment_uses) { |
| 2722 | auto input_attachments = rpci->pSubpasses[subpass].pInputAttachments; |
| 2723 | auto index = (input_attachments && use.first < rpci->pSubpasses[subpass].inputAttachmentCount) ? |
| 2724 | input_attachments[use.first].attachment : VK_ATTACHMENT_UNUSED; |
| 2725 | |
| 2726 | if (index == VK_ATTACHMENT_UNUSED) { |
| 2727 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 2728 | SHADER_CHECKER_MISSING_INPUT_ATTACHMENT, "SC", |
| 2729 | "Shader consumes input attachment index %d but not provided in subpass", |
| 2730 | use.first)) { |
| 2731 | pass = false; |
| 2732 | } |
| 2733 | } |
Chris Forbes | 74e7bf5 | 2016-08-22 16:11:22 +1200 | [diff] [blame] | 2734 | else if (get_format_type(rpci->pAttachments[index].format) != |
| 2735 | get_fundamental_type(module, use.second.type_id)) { |
| 2736 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 2737 | SHADER_CHECKER_INPUT_ATTACHMENT_TYPE_MISMATCH, "SC", |
| 2738 | "Subpass input attachment %u format of %s does not match type used in shader `%s`", |
| 2739 | use.first, string_VkFormat(rpci->pAttachments[index].format), |
| 2740 | describe_type(module, use.second.type_id).c_str())) { |
| 2741 | pass = false; |
| 2742 | } |
| 2743 | } |
Chris Forbes | 8420fea | 2016-08-22 15:20:11 +1200 | [diff] [blame] | 2744 | } |
| 2745 | } |
| 2746 | |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2747 | return pass; |
| 2748 | } |
| 2749 | |
| 2750 | |
Tobin Ehlis | 81e8ca4 | 2016-03-24 09:17:25 -0600 | [diff] [blame] | 2751 | // Validate that the shaders used by the given pipeline and store the active_slots |
| 2752 | // that are actually used by the pipeline into pPipeline->active_slots |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2753 | static bool |
| 2754 | validate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_STATE *pPipeline, |
| 2755 | VkPhysicalDeviceFeatures const *enabledFeatures, |
| 2756 | std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const &shaderModuleMap) { |
Chris Forbes | 6f6844a | 2016-04-27 14:00:44 +1200 | [diff] [blame] | 2757 | auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2758 | int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); |
| 2759 | int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); |
| 2760 | |
| 2761 | shader_module *shaders[5]; |
| 2762 | memset(shaders, 0, sizeof(shaders)); |
| 2763 | spirv_inst_iter entrypoints[5]; |
| 2764 | memset(entrypoints, 0, sizeof(entrypoints)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2765 | VkPipelineVertexInputStateCreateInfo const *vi = 0; |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2766 | bool pass = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2767 | |
| 2768 | for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { |
Chris Forbes | 6f6844a | 2016-04-27 14:00:44 +1200 | [diff] [blame] | 2769 | auto pStage = &pCreateInfo->pStages[i]; |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2770 | auto stage_id = get_shader_stage_id(pStage->stage); |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2771 | pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, |
Chris Forbes | c9b826c | 2016-05-13 13:17:42 +1200 | [diff] [blame] | 2772 | &shaders[stage_id], &entrypoints[stage_id], |
| 2773 | enabledFeatures, shaderModuleMap); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2774 | } |
| 2775 | |
Chris Forbes | e721009 | 2016-09-13 11:22:22 +1200 | [diff] [blame] | 2776 | // if the shader stages are no good individually, cross-stage validation is pointless. |
Chris Forbes | ddb7d71 | 2016-09-09 11:26:20 +1200 | [diff] [blame] | 2777 | if (!pass) |
| 2778 | return false; |
| 2779 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2780 | vi = pCreateInfo->pVertexInputState; |
| 2781 | |
| 2782 | if (vi) { |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2783 | pass &= validate_vi_consistency(report_data, vi); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2784 | } |
| 2785 | |
| 2786 | if (shaders[vertex_stage]) { |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2787 | pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2788 | } |
| 2789 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2790 | int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); |
| 2791 | int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); |
| 2792 | |
| 2793 | while (!shaders[producer] && producer != fragment_stage) { |
| 2794 | producer++; |
| 2795 | consumer++; |
| 2796 | } |
| 2797 | |
| 2798 | for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { |
| 2799 | assert(shaders[producer]); |
| 2800 | if (shaders[consumer]) { |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2801 | pass &= validate_interface_between_stages(report_data, |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 2802 | shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], |
| 2803 | shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2804 | |
| 2805 | producer = consumer; |
| 2806 | } |
| 2807 | } |
| 2808 | |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 2809 | if (shaders[fragment_stage]) { |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2810 | pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 2811 | pPipeline->render_pass_ci.ptr(), pCreateInfo->subpass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2812 | } |
| 2813 | |
| 2814 | return pass; |
| 2815 | } |
| 2816 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2817 | static bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_STATE *pPipeline, |
| 2818 | VkPhysicalDeviceFeatures const *enabledFeatures, |
| 2819 | std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const &shaderModuleMap) { |
Chris Forbes | 6f6844a | 2016-04-27 14:00:44 +1200 | [diff] [blame] | 2820 | auto pCreateInfo = pPipeline->computePipelineCI.ptr(); |
Chris Forbes | b029e6f | 2016-03-30 14:04:36 +1300 | [diff] [blame] | 2821 | |
Chris Forbes | b029e6f | 2016-03-30 14:04:36 +1300 | [diff] [blame] | 2822 | shader_module *module; |
| 2823 | spirv_inst_iter entrypoint; |
| 2824 | |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2825 | return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, |
Chris Forbes | c9b826c | 2016-05-13 13:17:42 +1200 | [diff] [blame] | 2826 | &module, &entrypoint, enabledFeatures, shaderModuleMap); |
Chris Forbes | b029e6f | 2016-03-30 14:04:36 +1300 | [diff] [blame] | 2827 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2828 | // Return Set node ptr for specified set or else NULL |
Tobin Ehlis | e83a46a | 2016-06-02 12:48:25 -0600 | [diff] [blame] | 2829 | cvdescriptorset::DescriptorSet *getSetNode(const layer_data *my_data, VkDescriptorSet set) { |
Tobin Ehlis | 6a72dc7 | 2016-06-01 16:41:17 -0600 | [diff] [blame] | 2830 | auto set_it = my_data->setMap.find(set); |
| 2831 | if (set_it == my_data->setMap.end()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2832 | return NULL; |
| 2833 | } |
Tobin Ehlis | 6a72dc7 | 2016-06-01 16:41:17 -0600 | [diff] [blame] | 2834 | return set_it->second; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2835 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2836 | |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2837 | // For given pipeline, return number of MSAA samples, or one if MSAA disabled |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2838 | static VkSampleCountFlagBits getNumSamples(PIPELINE_STATE const *pipe) { |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2839 | if (pipe->graphicsPipelineCI.pMultisampleState != NULL && |
| 2840 | VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2841 | return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; |
| 2842 | } |
| 2843 | return VK_SAMPLE_COUNT_1_BIT; |
| 2844 | } |
| 2845 | |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2846 | static void list_bits(std::ostream& s, uint32_t bits) { |
| 2847 | for (int i = 0; i < 32 && bits; i++) { |
| 2848 | if (bits & (1 << i)) { |
| 2849 | s << i; |
| 2850 | bits &= ~(1 << i); |
| 2851 | if (bits) { |
| 2852 | s << ","; |
| 2853 | } |
| 2854 | } |
| 2855 | } |
| 2856 | } |
| 2857 | |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2858 | // Validate draw-time state related to the PSO |
Tobin Ehlis | 288cb7e | 2016-12-21 08:30:22 -0700 | [diff] [blame] | 2859 | static bool ValidatePipelineDrawtimeState(layer_data const *my_data, LAST_BOUND_STATE const &state, const GLOBAL_CB_NODE *pCB, |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2860 | PIPELINE_STATE const *pPipeline) { |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2861 | bool skip_call = false; |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2862 | |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 2863 | // Verify vertex binding |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2864 | if (pPipeline->vertexBindingDescriptions.size() > 0) { |
| 2865 | for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { |
Tobin Ehlis | 9b9fdd3 | 2016-08-03 09:59:17 -0600 | [diff] [blame] | 2866 | auto vertex_binding = pPipeline->vertexBindingDescriptions[i].binding; |
| 2867 | if ((pCB->currentDrawData.buffers.size() < (vertex_binding + 1)) || |
| 2868 | (pCB->currentDrawData.buffers[vertex_binding] == VK_NULL_HANDLE)) { |
| 2869 | skip_call |= log_msg( |
| 2870 | my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 2871 | DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", |
| 2872 | "The Pipeline State Object (0x%" PRIxLEAST64 ") expects that this Command Buffer's vertex binding Index %u " |
| 2873 | "should be set via vkCmdBindVertexBuffers. This is because VkVertexInputBindingDescription struct " |
| 2874 | "at index " PRINTF_SIZE_T_SPECIFIER " of pVertexBindingDescriptions has a binding value of %u.", |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2875 | (uint64_t)state.pipeline_state->pipeline, vertex_binding, i, vertex_binding); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2876 | } |
| 2877 | } |
| 2878 | } else { |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 2879 | if (!pCB->currentDrawData.buffers.empty() && !pCB->vertex_buffer_used) { |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2880 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, |
Tobin Ehlis | eb00b0d | 2016-08-17 07:55:55 -0600 | [diff] [blame] | 2881 | 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 2882 | "Vertex buffers are bound to command buffer (0x%p" |
Tobin Ehlis | eb00b0d | 2016-08-17 07:55:55 -0600 | [diff] [blame] | 2883 | ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 2884 | pCB->commandBuffer, (uint64_t)state.pipeline_state->pipeline); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2885 | } |
| 2886 | } |
| 2887 | // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. |
| 2888 | // Skip check if rasterization is disabled or there is no viewport. |
| 2889 | if ((!pPipeline->graphicsPipelineCI.pRasterizationState || |
| 2890 | (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && |
| 2891 | pPipeline->graphicsPipelineCI.pViewportState) { |
| 2892 | bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); |
| 2893 | bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2894 | |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2895 | if (dynViewport) { |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2896 | auto requiredViewportsMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->viewportCount) - 1; |
| 2897 | auto missingViewportMask = ~pCB->viewportMask & requiredViewportsMask; |
| 2898 | if (missingViewportMask) { |
| 2899 | std::stringstream ss; |
| 2900 | ss << "Dynamic viewport(s) "; |
| 2901 | list_bits(ss, missingViewportMask); |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 2902 | ss << " are used by pipeline state object, but were not provided via calls to vkCmdSetViewport()."; |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2903 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
| 2904 | __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", |
| 2905 | "%s", ss.str().c_str()); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2906 | } |
| 2907 | } |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2908 | |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2909 | if (dynScissor) { |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2910 | auto requiredScissorMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->scissorCount) - 1; |
| 2911 | auto missingScissorMask = ~pCB->scissorMask & requiredScissorMask; |
| 2912 | if (missingScissorMask) { |
| 2913 | std::stringstream ss; |
| 2914 | ss << "Dynamic scissor(s) "; |
| 2915 | list_bits(ss, missingScissorMask); |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 2916 | ss << " are used by pipeline state object, but were not provided via calls to vkCmdSetScissor()."; |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2917 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
| 2918 | __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", |
| 2919 | "%s", ss.str().c_str()); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2920 | } |
| 2921 | } |
| 2922 | } |
| 2923 | |
| 2924 | // Verify that any MSAA request in PSO matches sample# in bound FB |
| 2925 | // Skip the check if rasterization is disabled. |
| 2926 | if (!pPipeline->graphicsPipelineCI.pRasterizationState || |
| 2927 | (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { |
| 2928 | VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); |
| 2929 | if (pCB->activeRenderPass) { |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 2930 | auto const render_pass_info = pCB->activeRenderPass->createInfo.ptr(); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2931 | const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2932 | uint32_t i; |
| 2933 | |
| 2934 | const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; |
| 2935 | if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && |
| 2936 | (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { |
| 2937 | skip_call |= |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2938 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2939 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2940 | "Render pass subpass %u mismatch with blending state defined and blend state attachment " |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 2941 | "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2942 | "must be the same at draw-time.", |
| 2943 | pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2944 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2945 | } |
| 2946 | |
Chris Forbes | 3437922 | 2016-06-29 18:15:41 +1200 | [diff] [blame] | 2947 | unsigned subpass_num_samples = 0; |
Chris Forbes | 074ec14 | 2016-06-29 10:50:41 +1200 | [diff] [blame] | 2948 | |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2949 | for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { |
Chris Forbes | 3437922 | 2016-06-29 18:15:41 +1200 | [diff] [blame] | 2950 | auto attachment = subpass_desc->pColorAttachments[i].attachment; |
| 2951 | if (attachment != VK_ATTACHMENT_UNUSED) |
| 2952 | subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2953 | } |
Chris Forbes | 074ec14 | 2016-06-29 10:50:41 +1200 | [diff] [blame] | 2954 | |
Chris Forbes | 3437922 | 2016-06-29 18:15:41 +1200 | [diff] [blame] | 2955 | if (subpass_desc->pDepthStencilAttachment && |
| 2956 | subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 2957 | auto attachment = subpass_desc->pDepthStencilAttachment->attachment; |
| 2958 | subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2959 | } |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2960 | |
Jamie Madill | 5738e27 | 2016-07-06 13:37:33 -0400 | [diff] [blame] | 2961 | if (subpass_num_samples && static_cast<unsigned>(pso_num_samples) != subpass_num_samples) { |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2962 | skip_call |= |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2963 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2964 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 2965 | "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 |
| 2966 | ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2967 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, |
Chris Forbes | a4937a7 | 2016-05-06 16:31:14 +1200 | [diff] [blame] | 2968 | reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2969 | } |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2970 | } else { |
| 2971 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| 2972 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", |
| 2973 | "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", |
| 2974 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2975 | } |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2976 | } |
Tobin Ehlis | 09d67d0 | 2016-06-07 06:06:01 -0600 | [diff] [blame] | 2977 | // Verify that PSO creation renderPass is compatible with active renderPass |
| 2978 | if (pCB->activeRenderPass) { |
| 2979 | std::string err_string; |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 2980 | if ((pCB->activeRenderPass->renderPass != pPipeline->graphicsPipelineCI.renderPass) && |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 2981 | !verify_renderpass_compatibility(my_data, pCB->activeRenderPass->createInfo.ptr(), pPipeline->render_pass_ci.ptr(), |
Tobin Ehlis | 09d67d0 | 2016-06-07 06:06:01 -0600 | [diff] [blame] | 2982 | err_string)) { |
| 2983 | // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with |
| 2984 | skip_call |= |
| 2985 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| 2986 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", |
| 2987 | "At Draw time the active render pass (0x%" PRIxLEAST64 ") is incompatible w/ gfx pipeline " |
| 2988 | "(0x%" PRIxLEAST64 ") that was created w/ render pass (0x%" PRIxLEAST64 ") due to: %s", |
Chris Forbes | 8249444 | 2016-10-17 15:45:49 +1300 | [diff] [blame] | 2989 | reinterpret_cast<uint64_t &>(pCB->activeRenderPass->renderPass), |
| 2990 | reinterpret_cast<uint64_t const &>(pPipeline->pipeline), |
Tobin Ehlis | 09d67d0 | 2016-06-07 06:06:01 -0600 | [diff] [blame] | 2991 | reinterpret_cast<const uint64_t &>(pPipeline->graphicsPipelineCI.renderPass), err_string.c_str()); |
| 2992 | } |
Chris Forbes | a58c452 | 2016-09-28 15:19:39 +1300 | [diff] [blame] | 2993 | |
| 2994 | if (pPipeline->graphicsPipelineCI.subpass != pCB->activeSubpass) { |
| 2995 | skip_call |= |
| 2996 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| 2997 | reinterpret_cast<uint64_t const &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", |
| 2998 | "Pipeline was built for subpass %u but used in subpass %u", pPipeline->graphicsPipelineCI.subpass, |
| 2999 | pCB->activeSubpass); |
| 3000 | } |
Tobin Ehlis | 09d67d0 | 2016-06-07 06:06:01 -0600 | [diff] [blame] | 3001 | } |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 3002 | // TODO : Add more checks here |
| 3003 | |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 3004 | return skip_call; |
| 3005 | } |
| 3006 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3007 | // Validate overall state at the time of a draw call |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3008 | static bool ValidateDrawState(layer_data *my_data, GLOBAL_CB_NODE *cb_node, const bool indexed, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 3009 | const VkPipelineBindPoint bind_point, const char *function, |
| 3010 | UNIQUE_VALIDATION_ERROR_CODE const msg_code) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3011 | bool result = false; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3012 | auto const &state = cb_node->lastBound[bind_point]; |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3013 | PIPELINE_STATE *pPipe = state.pipeline_state; |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3014 | if (nullptr == pPipe) { |
| 3015 | result |= log_msg( |
| 3016 | my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 3017 | DRAWSTATE_INVALID_PIPELINE, "DS", |
| 3018 | "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); |
| 3019 | // Early return as any further checks below will be busted w/o a pipeline |
| 3020 | if (result) |
| 3021 | return true; |
| 3022 | } |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 3023 | // First check flag states |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3024 | if (VK_PIPELINE_BIND_POINT_GRAPHICS == bind_point) |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 3025 | result = validate_draw_state_flags(my_data, cb_node, pPipe, indexed, msg_code); |
Tobin Ehlis | 2e319d4 | 2016-03-25 11:49:51 -0600 | [diff] [blame] | 3026 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3027 | // Now complete other state checks |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 3028 | if (VK_NULL_HANDLE != state.pipeline_layout.layout) { |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3029 | string errorString; |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 3030 | auto pipeline_layout = pPipe->pipeline_layout; |
Chris Forbes | e96eb49 | 2016-05-31 16:45:13 +1200 | [diff] [blame] | 3031 | |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3032 | for (const auto &set_binding_pair : pPipe->active_slots) { |
| 3033 | uint32_t setIndex = set_binding_pair.first; |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3034 | // If valid set is not bound throw an error |
| 3035 | if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { |
| 3036 | result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3037 | DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 3038 | "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3039 | setIndex); |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 3040 | } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], &pipeline_layout, setIndex, |
| 3041 | errorString)) { |
| 3042 | // Set is bound but not compatible w/ overlapping pipeline_layout from PSO |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 3043 | VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3044 | result |= |
| 3045 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| 3046 | (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 3047 | "VkDescriptorSet (0x%" PRIxLEAST64 |
| 3048 | ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 3049 | reinterpret_cast<uint64_t &>(setHandle), setIndex, reinterpret_cast<uint64_t &>(pipeline_layout.layout), |
| 3050 | errorString.c_str()); |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3051 | } else { // Valid set is bound and layout compatible, validate that it's updated |
| 3052 | // Pull the set node |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3053 | cvdescriptorset::DescriptorSet *descriptor_set = state.boundDescriptorSets[setIndex]; |
Tobin Ehlis | f951910 | 2016-08-17 09:49:13 -0600 | [diff] [blame] | 3054 | // Gather active bindings |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 3055 | std::unordered_set<uint32_t> active_bindings; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3056 | for (auto binding : set_binding_pair.second) { |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 3057 | active_bindings.insert(binding.first); |
Tobin Ehlis | f951910 | 2016-08-17 09:49:13 -0600 | [diff] [blame] | 3058 | } |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3059 | // Make sure set has been updated if it has no immutable samplers |
| 3060 | // If it has immutable samplers, we'll flag error later as needed depending on binding |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3061 | if (!descriptor_set->IsUpdated()) { |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 3062 | for (auto binding : active_bindings) { |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3063 | if (!descriptor_set->GetImmutableSamplerPtrFromBinding(binding)) { |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3064 | result |= log_msg( |
| 3065 | my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3066 | (uint64_t)descriptor_set->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 3067 | "Descriptor Set 0x%" PRIxLEAST64 " bound but was never updated. It is now being used to draw so " |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3068 | "this will result in undefined behavior.", |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3069 | (uint64_t)descriptor_set->GetSet()); |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3070 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3071 | } |
| 3072 | } |
Tobin Ehlis | 205f003 | 2016-12-29 11:39:10 -0700 | [diff] [blame] | 3073 | // Validate the draw-time state for this descriptor set |
| 3074 | std::string err_str; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3075 | if (!descriptor_set->ValidateDrawState(set_binding_pair.second, state.dynamicOffsets[setIndex], &err_str)) { |
| 3076 | auto set = descriptor_set->GetSet(); |
Tobin Ehlis | 205f003 | 2016-12-29 11:39:10 -0700 | [diff] [blame] | 3077 | result |= |
| 3078 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| 3079 | reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", |
| 3080 | "Descriptor set 0x%" PRIxLEAST64 " encountered the following validation error at %s() time: %s", |
| 3081 | reinterpret_cast<const uint64_t &>(set), function, err_str.c_str()); |
| 3082 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3083 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3084 | } |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3085 | } |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 3086 | |
| 3087 | // Check general pipeline state that needs to be validated at drawtime |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3088 | if (VK_PIPELINE_BIND_POINT_GRAPHICS == bind_point) |
Tobin Ehlis | 288cb7e | 2016-12-21 08:30:22 -0700 | [diff] [blame] | 3089 | result |= ValidatePipelineDrawtimeState(my_data, state, cb_node, pPipe); |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 3090 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3091 | return result; |
| 3092 | } |
| 3093 | |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3094 | static void UpdateDrawState(layer_data *my_data, GLOBAL_CB_NODE *cb_state, const VkPipelineBindPoint bind_point) { |
| 3095 | auto const &state = cb_state->lastBound[bind_point]; |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3096 | PIPELINE_STATE *pPipe = state.pipeline_state; |
| 3097 | if (VK_NULL_HANDLE != state.pipeline_layout.layout) { |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3098 | for (const auto &set_binding_pair : pPipe->active_slots) { |
| 3099 | uint32_t setIndex = set_binding_pair.first; |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3100 | // Pull the set node |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3101 | cvdescriptorset::DescriptorSet *descriptor_set = state.boundDescriptorSets[setIndex]; |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3102 | // Bind this set and its active descriptor resources to the command buffer |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3103 | descriptor_set->BindCommandBuffer(cb_state, set_binding_pair.second); |
Tobin Ehlis | 205f003 | 2016-12-29 11:39:10 -0700 | [diff] [blame] | 3104 | // For given active slots record updated images & buffers |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3105 | descriptor_set->GetStorageUpdates(set_binding_pair.second, &cb_state->updateBuffers, &cb_state->updateImages); |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3106 | } |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3107 | } |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 3108 | if (pPipe->vertexBindingDescriptions.size() > 0) { |
| 3109 | cb_state->vertex_buffer_used = true; |
| 3110 | } |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3111 | } |
| 3112 | |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 3113 | // Validate HW line width capabilities prior to setting requested line width. |
| 3114 | static bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { |
| 3115 | bool skip_call = false; |
| 3116 | |
| 3117 | // First check to see if the physical device supports wide lines. |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 3118 | if ((VK_FALSE == my_data->enabled_features.wideLines) && (1.0f != lineWidth)) { |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 3119 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, |
| 3120 | dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " |
| 3121 | "not supported/enabled so lineWidth must be 1.0f!", |
| 3122 | lineWidth); |
| 3123 | } else { |
| 3124 | // Otherwise, make sure the width falls in the valid range. |
| 3125 | if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || |
| 3126 | (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { |
| 3127 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, |
| 3128 | __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " |
| 3129 | "to between [%f, %f]!", |
| 3130 | lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], |
| 3131 | my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); |
| 3132 | } |
| 3133 | } |
| 3134 | |
| 3135 | return skip_call; |
| 3136 | } |
| 3137 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3138 | // Verify that create state for a pipeline is valid |
Mark Lobodzinski | 44e5999 | 2016-11-16 09:51:44 -0700 | [diff] [blame] | 3139 | static bool verifyPipelineCreateState(layer_data *my_data, std::vector<PIPELINE_STATE *> pPipelines, int pipelineIndex) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3140 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3141 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3142 | PIPELINE_STATE *pPipeline = pPipelines[pipelineIndex]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3143 | |
| 3144 | // If create derivative bit is set, check that we've specified a base |
| 3145 | // pipeline correctly, and that the base pipeline was created to allow |
| 3146 | // derivatives. |
| 3147 | if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3148 | PIPELINE_STATE *pBasePipeline = nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3149 | if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ |
| 3150 | (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3151 | // This check is a superset of VALIDATION_ERROR_00526 and VALIDATION_ERROR_00528 |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3152 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3153 | DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
| 3154 | "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3155 | } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { |
| 3156 | if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3157 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3158 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3159 | VALIDATION_ERROR_00518, "DS", |
| 3160 | "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline. %s", |
| 3161 | validation_error_map[VALIDATION_ERROR_00518]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3162 | } else { |
| 3163 | pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; |
| 3164 | } |
| 3165 | } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3166 | pBasePipeline = getPipelineState(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3167 | } |
| 3168 | |
| 3169 | if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3170 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3171 | DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
| 3172 | "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3173 | } |
| 3174 | } |
| 3175 | |
| 3176 | if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 3177 | if (!my_data->enabled_features.independentBlend) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 3178 | if (pPipeline->attachments.size() > 1) { |
Chris Forbes | 1ae3d40 | 2016-03-24 11:42:09 +1300 | [diff] [blame] | 3179 | VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; |
Mark Lobodzinski | 2f02dc9 | 2016-03-23 14:34:52 -0600 | [diff] [blame] | 3180 | for (size_t i = 1; i < pPipeline->attachments.size(); i++) { |
Mark Mueller | 35d4131 | 2016-07-13 14:49:35 -0600 | [diff] [blame] | 3181 | // Quoting the spec: "If [the independent blend] feature is not enabled, the VkPipelineColorBlendAttachmentState |
| 3182 | // settings for all color attachments must be identical." VkPipelineColorBlendAttachmentState contains |
| 3183 | // only attachment state, so memcmp is best suited for the comparison |
| 3184 | if (memcmp(static_cast<const void *>(pAttachments), static_cast<const void *>(&pAttachments[i]), |
| 3185 | sizeof(pAttachments[0]))) { |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3186 | skip_call |= |
| 3187 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3188 | VALIDATION_ERROR_01532, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " |
| 3189 | "enabled, all elements of pAttachments must be identical. %s", |
| 3190 | validation_error_map[VALIDATION_ERROR_01532]); |
Mark Mueller | 35d4131 | 2016-07-13 14:49:35 -0600 | [diff] [blame] | 3191 | break; |
Mark Lobodzinski | 2f02dc9 | 2016-03-23 14:34:52 -0600 | [diff] [blame] | 3192 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3193 | } |
| 3194 | } |
| 3195 | } |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 3196 | if (!my_data->enabled_features.logicOp && |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3197 | (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3198 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3199 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3200 | VALIDATION_ERROR_01533, "DS", |
| 3201 | "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE. %s", |
| 3202 | validation_error_map[VALIDATION_ERROR_01533]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3203 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3204 | } |
| 3205 | |
Tobin Ehlis | 81e8ca4 | 2016-03-24 09:17:25 -0600 | [diff] [blame] | 3206 | // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3207 | // produces nonsense errors that confuse users. Other layers should already |
| 3208 | // emit errors for renderpass being invalid. |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 3209 | auto renderPass = getRenderPassState(my_data, pPipeline->graphicsPipelineCI.renderPass); |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 3210 | if (renderPass && pPipeline->graphicsPipelineCI.subpass >= renderPass->createInfo.subpassCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3211 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3212 | VALIDATION_ERROR_02122, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " |
| 3213 | "is out of range for this renderpass (0..%u). %s", |
| 3214 | pPipeline->graphicsPipelineCI.subpass, renderPass->createInfo.subpassCount - 1, |
| 3215 | validation_error_map[VALIDATION_ERROR_02122]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3216 | } |
| 3217 | |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 3218 | if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->enabled_features, |
Chris Forbes | c9b826c | 2016-05-13 13:17:42 +1200 | [diff] [blame] | 3219 | my_data->shaderModuleMap)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3220 | skip_call = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3221 | } |
Chris Forbes | 3001c77 | 2016-04-06 11:21:28 +1200 | [diff] [blame] | 3222 | // Each shader's stage must be unique |
| 3223 | if (pPipeline->duplicate_shaders) { |
| 3224 | for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { |
| 3225 | if (pPipeline->duplicate_shaders & stage) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3226 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
| 3227 | __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
| 3228 | "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", |
| 3229 | string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); |
Chris Forbes | 3001c77 | 2016-04-06 11:21:28 +1200 | [diff] [blame] | 3230 | } |
| 3231 | } |
| 3232 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3233 | // VS is required |
| 3234 | if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3235 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3236 | VALIDATION_ERROR_00532, "DS", "Invalid Pipeline CreateInfo State: Vertex Shader required. %s", |
| 3237 | validation_error_map[VALIDATION_ERROR_00532]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3238 | } |
| 3239 | // Either both or neither TC/TE shaders should be defined |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3240 | if ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) && |
| 3241 | !(pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3242 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3243 | VALIDATION_ERROR_00534, "DS", |
| 3244 | "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair. %s", |
| 3245 | validation_error_map[VALIDATION_ERROR_00534]); |
| 3246 | } |
| 3247 | if (!(pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) && |
| 3248 | (pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT)) { |
| 3249 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3250 | VALIDATION_ERROR_00535, "DS", |
| 3251 | "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair. %s", |
| 3252 | validation_error_map[VALIDATION_ERROR_00535]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3253 | } |
| 3254 | // Compute shaders should be specified independent of Gfx shaders |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3255 | if (pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3256 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3257 | VALIDATION_ERROR_00533, "DS", |
| 3258 | "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline. %s", |
| 3259 | validation_error_map[VALIDATION_ERROR_00533]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3260 | } |
| 3261 | // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. |
| 3262 | // Mismatching primitive topology and tessellation fails graphics pipeline creation. |
| 3263 | if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 3264 | (!pPipeline->graphicsPipelineCI.pInputAssemblyState || |
| 3265 | pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3266 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3267 | VALIDATION_ERROR_02099, "DS", "Invalid Pipeline CreateInfo State: " |
| 3268 | "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " |
| 3269 | "topology for tessellation pipelines. %s", |
| 3270 | validation_error_map[VALIDATION_ERROR_02099]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3271 | } |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 3272 | if (pPipeline->graphicsPipelineCI.pInputAssemblyState && |
| 3273 | pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3274 | if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3275 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3276 | VALIDATION_ERROR_02100, "DS", "Invalid Pipeline CreateInfo State: " |
| 3277 | "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " |
| 3278 | "topology is only valid for tessellation pipelines. %s", |
| 3279 | validation_error_map[VALIDATION_ERROR_02100]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3280 | } |
| 3281 | } |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3282 | |
| 3283 | if (pPipeline->graphicsPipelineCI.pTessellationState && |
| 3284 | ((pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints == 0) || |
| 3285 | (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > |
| 3286 | my_data->phys_dev_properties.properties.limits.maxTessellationPatchSize))) { |
| 3287 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3288 | VALIDATION_ERROR_01426, "DS", "Invalid Pipeline CreateInfo State: " |
| 3289 | "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " |
| 3290 | "topology used with patchControlPoints value %u." |
| 3291 | " patchControlPoints should be >0 and <=%u. %s", |
| 3292 | pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints, |
| 3293 | my_data->phys_dev_properties.properties.limits.maxTessellationPatchSize, |
| 3294 | validation_error_map[VALIDATION_ERROR_01426]); |
| 3295 | } |
| 3296 | |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 3297 | // If a rasterization state is provided, make sure that the line width conforms to the HW. |
| 3298 | if (pPipeline->graphicsPipelineCI.pRasterizationState) { |
| 3299 | if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { |
Chris Forbes | 8249444 | 2016-10-17 15:45:49 +1300 | [diff] [blame] | 3300 | skip_call |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, |
| 3301 | reinterpret_cast<uint64_t const &>(pPipeline->pipeline), |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3302 | pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 3303 | } |
| 3304 | } |
Chris Forbes | d39376d | 2016-09-08 17:55:54 +1200 | [diff] [blame] | 3305 | |
Mark Lobodzinski | b23aa45 | 2016-12-16 13:06:41 -0700 | [diff] [blame] | 3306 | // If rasterization is not disabled and subpass uses a depth/stencil attachment, pDepthStencilState must be a pointer to a |
| 3307 | // valid structure |
| 3308 | if (pPipeline->graphicsPipelineCI.pRasterizationState && |
| 3309 | (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 3310 | auto subpass_desc = renderPass ? &renderPass->createInfo.pSubpasses[pPipeline->graphicsPipelineCI.subpass] : nullptr; |
Chris Forbes | d39376d | 2016-09-08 17:55:54 +1200 | [diff] [blame] | 3311 | if (subpass_desc && subpass_desc->pDepthStencilAttachment && |
| 3312 | subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 3313 | if (!pPipeline->graphicsPipelineCI.pDepthStencilState) { |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3314 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 3315 | 0, __LINE__, VALIDATION_ERROR_02115, "DS", |
Chris Forbes | d39376d | 2016-09-08 17:55:54 +1200 | [diff] [blame] | 3316 | "Invalid Pipeline CreateInfo State: " |
| 3317 | "pDepthStencilState is NULL when rasterization is enabled and subpass uses a " |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3318 | "depth/stencil attachment. %s", |
| 3319 | validation_error_map[VALIDATION_ERROR_02115]); |
Chris Forbes | d39376d | 2016-09-08 17:55:54 +1200 | [diff] [blame] | 3320 | } |
| 3321 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3322 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3323 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3324 | } |
| 3325 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3326 | // Free the Pipeline nodes |
| 3327 | static void deletePipelines(layer_data *my_data) { |
| 3328 | if (my_data->pipelineMap.size() <= 0) |
| 3329 | return; |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 3330 | for (auto &pipe_map_pair : my_data->pipelineMap) { |
| 3331 | delete pipe_map_pair.second; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3332 | } |
| 3333 | my_data->pipelineMap.clear(); |
| 3334 | } |
| 3335 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3336 | // Block of code at start here specifically for managing/tracking DSs |
| 3337 | |
| 3338 | // Return Pool node ptr for specified pool or else NULL |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 3339 | DESCRIPTOR_POOL_STATE *getDescriptorPoolState(const layer_data *dev_data, const VkDescriptorPool pool) { |
Tobin Ehlis | 71a93d3 | 2016-05-26 13:12:38 -0600 | [diff] [blame] | 3340 | auto pool_it = dev_data->descriptorPoolMap.find(pool); |
| 3341 | if (pool_it == dev_data->descriptorPoolMap.end()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3342 | return NULL; |
| 3343 | } |
Tobin Ehlis | 71a93d3 | 2016-05-26 13:12:38 -0600 | [diff] [blame] | 3344 | return pool_it->second; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3345 | } |
| 3346 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3347 | // Return false if update struct is of valid type, otherwise flag error and return code from callback |
| 3348 | static bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3349 | switch (pUpdateStruct->sType) { |
| 3350 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
| 3351 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3352 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3353 | default: |
| 3354 | return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3355 | DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", |
| 3356 | "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", |
| 3357 | string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); |
| 3358 | } |
| 3359 | } |
| 3360 | |
| 3361 | // Set count for given update struct in the last parameter |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3362 | static uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { |
| 3363 | switch (pUpdateStruct->sType) { |
| 3364 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
| 3365 | return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; |
| 3366 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
| 3367 | // TODO : Need to understand this case better and make sure code is correct |
| 3368 | return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; |
| 3369 | default: |
| 3370 | return 0; |
| 3371 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3372 | } |
| 3373 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3374 | // For given layout and update, return the first overall index of the layout that is updated |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3375 | static uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3376 | const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3377 | return binding_start_index + arrayIndex; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3378 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3379 | // For given layout and update, return the last overall index of the layout that is updated |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3380 | static uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3381 | const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { |
| 3382 | uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3383 | return binding_start_index + arrayIndex + count - 1; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3384 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3385 | // Verify that the descriptor type in the update struct matches what's expected by the layout |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3386 | static bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3387 | const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3388 | // First get actual type of update |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3389 | bool skip_call = false; |
Jamie Madill | 2b6b8d5 | 2016-04-04 15:09:51 -0400 | [diff] [blame] | 3390 | VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3391 | switch (pUpdateStruct->sType) { |
| 3392 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
| 3393 | actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; |
| 3394 | break; |
| 3395 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 3396 | // No need to validate |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3397 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3398 | break; |
| 3399 | default: |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3400 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3401 | DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", |
| 3402 | "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", |
| 3403 | string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3404 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3405 | if (!skip_call) { |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3406 | if (layout_type != actualType) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3407 | skip_call |= log_msg( |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3408 | my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3409 | DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", |
| 3410 | "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", |
| 3411 | string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3412 | } |
| 3413 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3414 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3415 | } |
Michael Lentine | f7bf684 | 2016-03-30 15:57:52 -0500 | [diff] [blame] | 3416 | //TODO: Consolidate functions |
| 3417 | bool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { |
| 3418 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); |
| 3419 | if (!(imgpair.subresource.aspectMask & aspectMask)) { |
| 3420 | return false; |
| 3421 | } |
| 3422 | VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; |
| 3423 | imgpair.subresource.aspectMask = aspectMask; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3424 | auto imgsubIt = pCB->imageLayoutMap.find(imgpair); |
| 3425 | if (imgsubIt == pCB->imageLayoutMap.end()) { |
Michael Lentine | f7bf684 | 2016-03-30 15:57:52 -0500 | [diff] [blame] | 3426 | return false; |
| 3427 | } |
| 3428 | if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { |
| 3429 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 3430 | reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", |
| 3431 | "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", |
| 3432 | reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); |
| 3433 | } |
| 3434 | if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { |
| 3435 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 3436 | reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", |
| 3437 | "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", |
| 3438 | reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3439 | } |
| 3440 | node = imgsubIt->second; |
| 3441 | return true; |
| 3442 | } |
| 3443 | |
Michael Lentine | f7bf684 | 2016-03-30 15:57:52 -0500 | [diff] [blame] | 3444 | bool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { |
| 3445 | if (!(imgpair.subresource.aspectMask & aspectMask)) { |
| 3446 | return false; |
| 3447 | } |
| 3448 | VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; |
| 3449 | imgpair.subresource.aspectMask = aspectMask; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3450 | auto imgsubIt = my_data->imageLayoutMap.find(imgpair); |
| 3451 | if (imgsubIt == my_data->imageLayoutMap.end()) { |
Michael Lentine | f7bf684 | 2016-03-30 15:57:52 -0500 | [diff] [blame] | 3452 | return false; |
| 3453 | } |
| 3454 | if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { |
| 3455 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 3456 | reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", |
| 3457 | "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", |
| 3458 | reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3459 | } |
| 3460 | layout = imgsubIt->second.layout; |
| 3461 | return true; |
| 3462 | } |
| 3463 | |
Michael Lentine | f7bf684 | 2016-03-30 15:57:52 -0500 | [diff] [blame] | 3464 | // find layout(s) on the cmd buf level |
| 3465 | bool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { |
| 3466 | ImageSubresourcePair imgpair = {image, true, range}; |
| 3467 | node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); |
| 3468 | FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); |
| 3469 | FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 3470 | FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 3471 | FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); |
| 3472 | if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { |
| 3473 | imgpair = {image, false, VkImageSubresource()}; |
| 3474 | auto imgsubIt = pCB->imageLayoutMap.find(imgpair); |
| 3475 | if (imgsubIt == pCB->imageLayoutMap.end()) |
| 3476 | return false; |
| 3477 | node = imgsubIt->second; |
| 3478 | } |
| 3479 | return true; |
| 3480 | } |
| 3481 | |
| 3482 | // find layout(s) on the global level |
| 3483 | bool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { |
| 3484 | layout = VK_IMAGE_LAYOUT_MAX_ENUM; |
| 3485 | FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); |
| 3486 | FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 3487 | FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 3488 | FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); |
| 3489 | if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { |
| 3490 | imgpair = {imgpair.image, false, VkImageSubresource()}; |
| 3491 | auto imgsubIt = my_data->imageLayoutMap.find(imgpair); |
| 3492 | if (imgsubIt == my_data->imageLayoutMap.end()) |
| 3493 | return false; |
| 3494 | layout = imgsubIt->second.layout; |
| 3495 | } |
| 3496 | return true; |
| 3497 | } |
| 3498 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3499 | bool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { |
| 3500 | ImageSubresourcePair imgpair = {image, true, range}; |
| 3501 | return FindLayout(my_data, imgpair, layout); |
| 3502 | } |
| 3503 | |
| 3504 | bool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { |
| 3505 | auto sub_data = my_data->imageSubresourceMap.find(image); |
| 3506 | if (sub_data == my_data->imageSubresourceMap.end()) |
| 3507 | return false; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 3508 | auto image_state = getImageState(my_data, image); |
| 3509 | if (!image_state) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3510 | return false; |
| 3511 | bool ignoreGlobal = false; |
| 3512 | // TODO: Make this robust for >1 aspect mask. Now it will just say ignore |
| 3513 | // potential errors in this case. |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 3514 | if (sub_data->second.size() >= (image_state->createInfo.arrayLayers * image_state->createInfo.mipLevels + 1)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3515 | ignoreGlobal = true; |
| 3516 | } |
| 3517 | for (auto imgsubpair : sub_data->second) { |
| 3518 | if (ignoreGlobal && !imgsubpair.hasSubresource) |
| 3519 | continue; |
| 3520 | auto img_data = my_data->imageLayoutMap.find(imgsubpair); |
| 3521 | if (img_data != my_data->imageLayoutMap.end()) { |
| 3522 | layouts.push_back(img_data->second.layout); |
| 3523 | } |
| 3524 | } |
| 3525 | return true; |
| 3526 | } |
| 3527 | |
| 3528 | // Set the layout on the global level |
| 3529 | void SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { |
| 3530 | VkImage &image = imgpair.image; |
| 3531 | // TODO (mlentine): Maybe set format if new? Not used atm. |
| 3532 | my_data->imageLayoutMap[imgpair].layout = layout; |
| 3533 | // TODO (mlentine): Maybe make vector a set? |
| 3534 | auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); |
| 3535 | if (subresource == my_data->imageSubresourceMap[image].end()) { |
| 3536 | my_data->imageSubresourceMap[image].push_back(imgpair); |
| 3537 | } |
| 3538 | } |
| 3539 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3540 | // Set the layout on the cmdbuf level |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3541 | void SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3542 | pCB->imageLayoutMap[imgpair] = node; |
| 3543 | // TODO (mlentine): Maybe make vector a set? |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3544 | auto subresource = |
| 3545 | std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); |
| 3546 | if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { |
| 3547 | pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3548 | } |
| 3549 | } |
| 3550 | |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3551 | void SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3552 | // TODO (mlentine): Maybe make vector a set? |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3553 | if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != |
| 3554 | pCB->imageSubresourceMap[imgpair.image].end()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3555 | pCB->imageLayoutMap[imgpair].layout = layout; |
| 3556 | } else { |
| 3557 | // TODO (mlentine): Could be expensive and might need to be removed. |
| 3558 | assert(imgpair.hasSubresource); |
| 3559 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
Mark Lobodzinski | 41bfce0 | 2016-03-28 14:34:40 -0600 | [diff] [blame] | 3560 | if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { |
| 3561 | node.initialLayout = layout; |
| 3562 | } |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3563 | SetLayout(pCB, imgpair, {node.initialLayout, layout}); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3564 | } |
| 3565 | } |
| 3566 | |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3567 | template <class OBJECT, class LAYOUT> |
| 3568 | void SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { |
| 3569 | if (imgpair.subresource.aspectMask & aspectMask) { |
| 3570 | imgpair.subresource.aspectMask = aspectMask; |
| 3571 | SetLayout(pObject, imgpair, layout); |
| 3572 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3573 | } |
| 3574 | |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3575 | template <class OBJECT, class LAYOUT> |
| 3576 | void SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3577 | ImageSubresourcePair imgpair = {image, true, range}; |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3578 | SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); |
| 3579 | SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 3580 | SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 3581 | SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3582 | } |
| 3583 | |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3584 | template <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3585 | ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3586 | SetLayout(pObject, image, imgpair, layout); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3587 | } |
| 3588 | |
| 3589 | void SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 3590 | auto view_state = getImageViewState(dev_data, imageView); |
| 3591 | assert(view_state); |
Tobin Ehlis | c8ca031 | 2016-09-22 07:30:05 -0600 | [diff] [blame] | 3592 | auto image = view_state->create_info.image; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 3593 | const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3594 | // TODO: Do not iterate over every possibility - consolidate where possible |
| 3595 | for (uint32_t j = 0; j < subRange.levelCount; j++) { |
| 3596 | uint32_t level = subRange.baseMipLevel + j; |
| 3597 | for (uint32_t k = 0; k < subRange.layerCount; k++) { |
| 3598 | uint32_t layer = subRange.baseArrayLayer + k; |
| 3599 | VkImageSubresource sub = {subRange.aspectMask, level, layer}; |
Mark Lobodzinski | 2af8e3f | 2016-08-01 15:51:39 -0600 | [diff] [blame] | 3600 | // TODO: If ImageView was created with depth or stencil, transition both layouts as |
| 3601 | // the aspectMask is ignored and both are used. Verify that the extra implicit layout |
| 3602 | // is OK for descriptor set layout validation |
Mark Lobodzinski | 77a5d6f | 2016-08-05 09:38:18 -0600 | [diff] [blame] | 3603 | if (subRange.aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 3604 | if (vk_format_is_depth_and_stencil(view_state->create_info.format)) { |
Mark Lobodzinski | 77a5d6f | 2016-08-05 09:38:18 -0600 | [diff] [blame] | 3605 | sub.aspectMask |= (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 3606 | } |
| 3607 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3608 | SetLayout(pCB, image, sub, layout); |
| 3609 | } |
| 3610 | } |
| 3611 | } |
| 3612 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3613 | // Validate that given set is valid and that it's not being used by an in-flight CmdBuffer |
| 3614 | // func_str is the name of the calling function |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3615 | // Return false if no errors occur |
| 3616 | // Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 3617 | static bool validateIdleDescriptorSet(const layer_data *dev_data, VkDescriptorSet set, std::string func_str) { |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 3618 | if (dev_data->instance_data->disabled.idle_descriptor_set) |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 3619 | return false; |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3620 | bool skip_call = false; |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 3621 | auto set_node = dev_data->setMap.find(set); |
| 3622 | if (set_node == dev_data->setMap.end()) { |
| 3623 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3624 | (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 3625 | "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3626 | (uint64_t)(set)); |
| 3627 | } else { |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 3628 | // TODO : This covers various error cases so should pass error enum into this function and use passed in enum here |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3629 | if (set_node->second->in_use.load()) { |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 3630 | skip_call |= |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 3631 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 3632 | (uint64_t)(set), __LINE__, VALIDATION_ERROR_00919, "DS", |
| 3633 | "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer. %s", |
| 3634 | func_str.c_str(), (uint64_t)(set), validation_error_map[VALIDATION_ERROR_00919]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3635 | } |
| 3636 | } |
| 3637 | return skip_call; |
| 3638 | } |
Chris Forbes | 367c032 | 2016-05-16 11:19:50 +1200 | [diff] [blame] | 3639 | |
Tobin Ehlis | ffbfe3f | 2016-05-26 13:39:11 -0600 | [diff] [blame] | 3640 | // Remove set from setMap and delete the set |
Tobin Ehlis | e335453 | 2016-05-05 13:49:42 -0600 | [diff] [blame] | 3641 | static void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { |
Tobin Ehlis | e335453 | 2016-05-05 13:49:42 -0600 | [diff] [blame] | 3642 | dev_data->setMap.erase(descriptor_set->GetSet()); |
| 3643 | delete descriptor_set; |
| 3644 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3645 | // Free all DS Pools including their Sets & related sub-structs |
| 3646 | // NOTE : Calls to this function should be wrapped in mutex |
| 3647 | static void deletePools(layer_data *my_data) { |
| 3648 | if (my_data->descriptorPoolMap.size() <= 0) |
| 3649 | return; |
| 3650 | for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { |
Tobin Ehlis | 5789b8f | 2016-05-05 13:18:20 -0600 | [diff] [blame] | 3651 | // Remove this pools' sets from setMap and delete them |
Tobin Ehlis | 0a43bde | 2016-05-03 08:31:08 -0600 | [diff] [blame] | 3652 | for (auto ds : (*ii).second->sets) { |
Tobin Ehlis | e335453 | 2016-05-05 13:49:42 -0600 | [diff] [blame] | 3653 | freeDescriptorSet(my_data, ds); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3654 | } |
Tobin Ehlis | 9bfd449 | 2016-05-05 15:09:11 -0600 | [diff] [blame] | 3655 | (*ii).second->sets.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3656 | } |
| 3657 | my_data->descriptorPoolMap.clear(); |
| 3658 | } |
| 3659 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3660 | static void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, |
| 3661 | VkDescriptorPoolResetFlags flags) { |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 3662 | DESCRIPTOR_POOL_STATE *pPool = getDescriptorPoolState(my_data, pool); |
Tobin Ehlis | 5d749ea | 2016-07-18 13:14:01 -0600 | [diff] [blame] | 3663 | // TODO: validate flags |
| 3664 | // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet |
| 3665 | for (auto ds : pPool->sets) { |
| 3666 | freeDescriptorSet(my_data, ds); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3667 | } |
Tobin Ehlis | 5d749ea | 2016-07-18 13:14:01 -0600 | [diff] [blame] | 3668 | pPool->sets.clear(); |
| 3669 | // Reset available count for each type and available sets for this pool |
| 3670 | for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { |
| 3671 | pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; |
| 3672 | } |
| 3673 | pPool->availableSets = pPool->maxSets; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3674 | } |
| 3675 | |
| 3676 | // For given CB object, fetch associated CB Node from map |
Chris Forbes | 664ca7f | 2016-05-06 16:55:18 +1200 | [diff] [blame] | 3677 | static GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { |
| 3678 | auto it = my_data->commandBufferMap.find(cb); |
| 3679 | if (it == my_data->commandBufferMap.end()) { |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 3680 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3681 | reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 3682 | "Attempt to use CommandBuffer 0x%p that doesn't exist!", cb); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3683 | return NULL; |
| 3684 | } |
Chris Forbes | 664ca7f | 2016-05-06 16:55:18 +1200 | [diff] [blame] | 3685 | return it->second; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3686 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3687 | // Free all CB Nodes |
| 3688 | // NOTE : Calls to this function should be wrapped in mutex |
| 3689 | static void deleteCommandBuffers(layer_data *my_data) { |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 3690 | if (my_data->commandBufferMap.empty()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3691 | return; |
| 3692 | } |
| 3693 | for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { |
| 3694 | delete (*ii).second; |
| 3695 | } |
| 3696 | my_data->commandBufferMap.clear(); |
| 3697 | } |
| 3698 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3699 | static bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3700 | return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3701 | (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", |
| 3702 | "You must call vkBeginCommandBuffer() before this call to %s", caller_name); |
| 3703 | } |
| 3704 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 3705 | // If a renderpass is active, verify that the given command type is appropriate for current subpass state |
| 3706 | bool ValidateCmdSubpassState(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3707 | if (!pCB->activeRenderPass) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3708 | return false; |
| 3709 | bool skip_call = false; |
Tobin Ehlis | f5d1a09 | 2016-05-17 14:50:07 -0600 | [diff] [blame] | 3710 | if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && |
| 3711 | (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3712 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3713 | DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| 3714 | "Commands cannot be called in a subpass using secondary command buffers."); |
| 3715 | } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { |
| 3716 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3717 | DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| 3718 | "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); |
| 3719 | } |
| 3720 | return skip_call; |
| 3721 | } |
| 3722 | |
| 3723 | static bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { |
| 3724 | if (!(flags & VK_QUEUE_GRAPHICS_BIT)) |
| 3725 | return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3726 | DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| 3727 | "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); |
| 3728 | return false; |
| 3729 | } |
| 3730 | |
| 3731 | static bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { |
| 3732 | if (!(flags & VK_QUEUE_COMPUTE_BIT)) |
| 3733 | return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3734 | DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| 3735 | "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); |
| 3736 | return false; |
| 3737 | } |
| 3738 | |
| 3739 | static bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { |
| 3740 | if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) |
| 3741 | return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3742 | DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| 3743 | "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); |
| 3744 | return false; |
| 3745 | } |
| 3746 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 3747 | // Validate the given command being added to the specified cmd buffer, flagging errors if CB is not |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3748 | // in the recording state or if there's an issue with the Cmd ordering |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 3749 | static bool ValidateCmd(layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3750 | bool skip_call = false; |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 3751 | auto pPool = getCommandPoolNode(my_data, pCB->createInfo.commandPool); |
| 3752 | if (pPool) { |
| 3753 | VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].queueFlags; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3754 | switch (cmd) { |
| 3755 | case CMD_BINDPIPELINE: |
| 3756 | case CMD_BINDPIPELINEDELTA: |
| 3757 | case CMD_BINDDESCRIPTORSETS: |
| 3758 | case CMD_FILLBUFFER: |
| 3759 | case CMD_CLEARCOLORIMAGE: |
| 3760 | case CMD_SETEVENT: |
| 3761 | case CMD_RESETEVENT: |
| 3762 | case CMD_WAITEVENTS: |
| 3763 | case CMD_BEGINQUERY: |
| 3764 | case CMD_ENDQUERY: |
| 3765 | case CMD_RESETQUERYPOOL: |
| 3766 | case CMD_COPYQUERYPOOLRESULTS: |
| 3767 | case CMD_WRITETIMESTAMP: |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3768 | skip_call |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3769 | break; |
| 3770 | case CMD_SETVIEWPORTSTATE: |
| 3771 | case CMD_SETSCISSORSTATE: |
| 3772 | case CMD_SETLINEWIDTHSTATE: |
| 3773 | case CMD_SETDEPTHBIASSTATE: |
| 3774 | case CMD_SETBLENDSTATE: |
| 3775 | case CMD_SETDEPTHBOUNDSSTATE: |
| 3776 | case CMD_SETSTENCILREADMASKSTATE: |
| 3777 | case CMD_SETSTENCILWRITEMASKSTATE: |
| 3778 | case CMD_SETSTENCILREFERENCESTATE: |
| 3779 | case CMD_BINDINDEXBUFFER: |
| 3780 | case CMD_BINDVERTEXBUFFER: |
| 3781 | case CMD_DRAW: |
| 3782 | case CMD_DRAWINDEXED: |
| 3783 | case CMD_DRAWINDIRECT: |
| 3784 | case CMD_DRAWINDEXEDINDIRECT: |
| 3785 | case CMD_BLITIMAGE: |
| 3786 | case CMD_CLEARATTACHMENTS: |
| 3787 | case CMD_CLEARDEPTHSTENCILIMAGE: |
| 3788 | case CMD_RESOLVEIMAGE: |
| 3789 | case CMD_BEGINRENDERPASS: |
| 3790 | case CMD_NEXTSUBPASS: |
| 3791 | case CMD_ENDRENDERPASS: |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3792 | skip_call |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3793 | break; |
| 3794 | case CMD_DISPATCH: |
| 3795 | case CMD_DISPATCHINDIRECT: |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3796 | skip_call |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3797 | break; |
| 3798 | case CMD_COPYBUFFER: |
| 3799 | case CMD_COPYIMAGE: |
| 3800 | case CMD_COPYBUFFERTOIMAGE: |
| 3801 | case CMD_COPYIMAGETOBUFFER: |
| 3802 | case CMD_CLONEIMAGEDATA: |
| 3803 | case CMD_UPDATEBUFFER: |
| 3804 | case CMD_PIPELINEBARRIER: |
| 3805 | case CMD_EXECUTECOMMANDS: |
Tobin Ehlis | 244fe58 | 2016-05-16 11:23:01 -0600 | [diff] [blame] | 3806 | case CMD_END: |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3807 | break; |
| 3808 | default: |
| 3809 | break; |
| 3810 | } |
| 3811 | } |
| 3812 | if (pCB->state != CB_RECORDING) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3813 | skip_call |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); |
Tobin Ehlis | 244fe58 | 2016-05-16 11:23:01 -0600 | [diff] [blame] | 3814 | } else { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 3815 | skip_call |= ValidateCmdSubpassState(my_data, pCB, cmd); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3816 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3817 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3818 | } |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 3819 | |
| 3820 | static void UpdateCmdBufferLastCmd(layer_data *my_data, GLOBAL_CB_NODE *cb_state, const CMD_TYPE cmd) { |
| 3821 | if (cb_state->state == CB_RECORDING) { |
| 3822 | cb_state->last_cmd = cmd; |
| 3823 | } |
| 3824 | } |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3825 | // For given object struct return a ptr of BASE_NODE type for its wrapping struct |
| 3826 | BASE_NODE *GetStateStructPtrFromObject(layer_data *dev_data, VK_OBJECT object_struct) { |
| 3827 | BASE_NODE *base_ptr = nullptr; |
| 3828 | switch (object_struct.type) { |
| 3829 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { |
| 3830 | base_ptr = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(object_struct.handle)); |
| 3831 | break; |
| 3832 | } |
| 3833 | case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 3834 | base_ptr = getSamplerState(dev_data, reinterpret_cast<VkSampler &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3835 | break; |
| 3836 | } |
| 3837 | case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { |
| 3838 | base_ptr = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(object_struct.handle)); |
| 3839 | break; |
| 3840 | } |
| 3841 | case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3842 | base_ptr = getPipelineState(dev_data, reinterpret_cast<VkPipeline &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3843 | break; |
| 3844 | } |
| 3845 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 3846 | base_ptr = getBufferState(dev_data, reinterpret_cast<VkBuffer &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3847 | break; |
| 3848 | } |
| 3849 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: { |
| 3850 | base_ptr = getBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(object_struct.handle)); |
| 3851 | break; |
| 3852 | } |
| 3853 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 3854 | base_ptr = getImageState(dev_data, reinterpret_cast<VkImage &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3855 | break; |
| 3856 | } |
| 3857 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: { |
| 3858 | base_ptr = getImageViewState(dev_data, reinterpret_cast<VkImageView &>(object_struct.handle)); |
| 3859 | break; |
| 3860 | } |
| 3861 | case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { |
| 3862 | base_ptr = getEventNode(dev_data, reinterpret_cast<VkEvent &>(object_struct.handle)); |
| 3863 | break; |
| 3864 | } |
| 3865 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: { |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 3866 | base_ptr = getDescriptorPoolState(dev_data, reinterpret_cast<VkDescriptorPool &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3867 | break; |
| 3868 | } |
| 3869 | case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: { |
| 3870 | base_ptr = getCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(object_struct.handle)); |
| 3871 | break; |
| 3872 | } |
| 3873 | case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: { |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 3874 | base_ptr = getFramebufferState(dev_data, reinterpret_cast<VkFramebuffer &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3875 | break; |
| 3876 | } |
| 3877 | case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 3878 | base_ptr = getRenderPassState(dev_data, reinterpret_cast<VkRenderPass &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3879 | break; |
| 3880 | } |
| 3881 | case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: { |
| 3882 | base_ptr = getMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(object_struct.handle)); |
| 3883 | break; |
| 3884 | } |
| 3885 | default: |
| 3886 | // TODO : Any other objects to be handled here? |
| 3887 | assert(0); |
| 3888 | break; |
| 3889 | } |
| 3890 | return base_ptr; |
| 3891 | } |
| 3892 | |
Tobin Ehlis | bfb8cc3 | 2016-07-08 13:27:48 -0600 | [diff] [blame] | 3893 | // Tie the VK_OBJECT to the cmd buffer which includes: |
| 3894 | // Add object_binding to cmd buffer |
| 3895 | // Add cb_binding to object |
| 3896 | static void addCommandBufferBinding(std::unordered_set<GLOBAL_CB_NODE *> *cb_bindings, VK_OBJECT obj, GLOBAL_CB_NODE *cb_node) { |
| 3897 | cb_bindings->insert(cb_node); |
| 3898 | cb_node->object_bindings.insert(obj); |
| 3899 | } |
Tobin Ehlis | 96f1d60 | 2016-07-08 12:33:45 -0600 | [diff] [blame] | 3900 | // For a given object, if cb_node is in that objects cb_bindings, remove cb_node |
| 3901 | static void removeCommandBufferBinding(layer_data *dev_data, VK_OBJECT const *object, GLOBAL_CB_NODE *cb_node) { |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3902 | BASE_NODE *base_obj = GetStateStructPtrFromObject(dev_data, *object); |
| 3903 | if (base_obj) |
| 3904 | base_obj->cb_bindings.erase(cb_node); |
Tobin Ehlis | 96f1d60 | 2016-07-08 12:33:45 -0600 | [diff] [blame] | 3905 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3906 | // Reset the command buffer state |
| 3907 | // Maintain the createInfo and set state to CB_NEW, but clear all other state |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 3908 | static void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { |
| 3909 | GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3910 | if (pCB) { |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 3911 | pCB->in_use.store(0); |
Chris Forbes | e46e0a1 | 2016-12-20 11:33:11 +1300 | [diff] [blame] | 3912 | pCB->last_cmd = CMD_NONE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3913 | // Reset CB state (note that createInfo is not cleared) |
| 3914 | pCB->commandBuffer = cb; |
| 3915 | memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); |
| 3916 | memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3917 | pCB->numCmds = 0; |
| 3918 | memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); |
| 3919 | pCB->state = CB_NEW; |
| 3920 | pCB->submitCount = 0; |
| 3921 | pCB->status = 0; |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 3922 | pCB->viewportMask = 0; |
| 3923 | pCB->scissorMask = 0; |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 3924 | |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 3925 | for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 3926 | pCB->lastBound[i].reset(); |
| 3927 | } |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 3928 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3929 | memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); |
Chris Forbes | a4937a7 | 2016-05-06 16:31:14 +1200 | [diff] [blame] | 3930 | pCB->activeRenderPass = nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3931 | pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; |
| 3932 | pCB->activeSubpass = 0; |
Tobin Ehlis | 2556f5b | 2016-06-24 17:22:16 -0600 | [diff] [blame] | 3933 | pCB->broken_bindings.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3934 | pCB->waitedEvents.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3935 | pCB->events.clear(); |
Mark Lobodzinski | c54d24e | 2016-06-13 16:56:26 -0600 | [diff] [blame] | 3936 | pCB->writeEventsBeforeWait.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3937 | pCB->waitedEventsBeforeQueryReset.clear(); |
| 3938 | pCB->queryToStateMap.clear(); |
| 3939 | pCB->activeQueries.clear(); |
| 3940 | pCB->startedQueries.clear(); |
Michael Lentine | 11fe377 | 2016-04-20 11:39:50 -0500 | [diff] [blame] | 3941 | pCB->imageSubresourceMap.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3942 | pCB->imageLayoutMap.clear(); |
| 3943 | pCB->eventToStageMap.clear(); |
| 3944 | pCB->drawData.clear(); |
| 3945 | pCB->currentDrawData.buffers.clear(); |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 3946 | pCB->vertex_buffer_used = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3947 | pCB->primaryCommandBuffer = VK_NULL_HANDLE; |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 3948 | // Make sure any secondaryCommandBuffers are removed from globalInFlight |
| 3949 | for (auto secondary_cb : pCB->secondaryCommandBuffers) { |
| 3950 | dev_data->globalInFlightCmdBuffers.erase(secondary_cb); |
| 3951 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3952 | pCB->secondaryCommandBuffers.clear(); |
Tobin Ehlis | 2e319d4 | 2016-03-25 11:49:51 -0600 | [diff] [blame] | 3953 | pCB->updateImages.clear(); |
| 3954 | pCB->updateBuffers.clear(); |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 3955 | clear_cmd_buf_and_mem_references(dev_data, pCB); |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 3956 | pCB->eventUpdates.clear(); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 3957 | pCB->queryUpdates.clear(); |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 3958 | |
Tobin Ehlis | 96f1d60 | 2016-07-08 12:33:45 -0600 | [diff] [blame] | 3959 | // Remove object bindings |
| 3960 | for (auto obj : pCB->object_bindings) { |
| 3961 | removeCommandBufferBinding(dev_data, &obj, pCB); |
| 3962 | } |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 3963 | pCB->object_bindings.clear(); |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 3964 | // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list |
| 3965 | for (auto framebuffer : pCB->framebuffers) { |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 3966 | auto fb_state = getFramebufferState(dev_data, framebuffer); |
| 3967 | if (fb_state) |
| 3968 | fb_state->cb_bindings.erase(pCB); |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 3969 | } |
| 3970 | pCB->framebuffers.clear(); |
Tobin Ehlis | 51b5f05 | 2016-05-16 08:36:40 -0600 | [diff] [blame] | 3971 | pCB->activeFramebuffer = VK_NULL_HANDLE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3972 | } |
| 3973 | } |
| 3974 | |
| 3975 | // Set PSO-related status bits for CB, including dynamic state set via PSO |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3976 | static void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_STATE *pPipe) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3977 | // Account for any dynamic state not set via this PSO |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 3978 | if (!pPipe->graphicsPipelineCI.pDynamicState || |
| 3979 | !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static |
Tobin Ehlis | eebcc65 | 2016-10-25 15:23:08 -0600 | [diff] [blame] | 3980 | pCB->status |= CBSTATUS_ALL_STATE_SET; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3981 | } else { |
| 3982 | // First consider all state on |
| 3983 | // Then unset any state that's noted as dynamic in PSO |
| 3984 | // Finally OR that into CB statemask |
Tobin Ehlis | eebcc65 | 2016-10-25 15:23:08 -0600 | [diff] [blame] | 3985 | CBStatusFlags psoDynStateMask = CBSTATUS_ALL_STATE_SET; |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 3986 | for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { |
| 3987 | switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3988 | case VK_DYNAMIC_STATE_LINE_WIDTH: |
| 3989 | psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; |
| 3990 | break; |
| 3991 | case VK_DYNAMIC_STATE_DEPTH_BIAS: |
| 3992 | psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; |
| 3993 | break; |
| 3994 | case VK_DYNAMIC_STATE_BLEND_CONSTANTS: |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 3995 | psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3996 | break; |
| 3997 | case VK_DYNAMIC_STATE_DEPTH_BOUNDS: |
| 3998 | psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; |
| 3999 | break; |
| 4000 | case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: |
| 4001 | psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; |
| 4002 | break; |
| 4003 | case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: |
| 4004 | psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; |
| 4005 | break; |
| 4006 | case VK_DYNAMIC_STATE_STENCIL_REFERENCE: |
| 4007 | psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; |
| 4008 | break; |
| 4009 | default: |
| 4010 | // TODO : Flag error here |
| 4011 | break; |
| 4012 | } |
| 4013 | } |
| 4014 | pCB->status |= psoDynStateMask; |
| 4015 | } |
| 4016 | } |
| 4017 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4018 | // Flags validation error if the associated call is made inside a render pass. The apiName |
| 4019 | // routine should ONLY be called outside a render pass. |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 4020 | static bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName, |
| 4021 | UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 4022 | bool inside = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4023 | if (pCB->activeRenderPass) { |
| 4024 | inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 4025 | (uint64_t)pCB->commandBuffer, __LINE__, msgCode, "DS", |
| 4026 | "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 "). %s", apiName, |
| 4027 | (uint64_t)pCB->activeRenderPass->renderPass, validation_error_map[msgCode]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4028 | } |
| 4029 | return inside; |
| 4030 | } |
| 4031 | |
| 4032 | // Flags validation error if the associated call is made outside a render pass. The apiName |
| 4033 | // routine should ONLY be called inside a render pass. |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 4034 | static bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName, |
| 4035 | UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 4036 | bool outside = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4037 | if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || |
| 4038 | ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && |
| 4039 | !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { |
| 4040 | outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 4041 | (uint64_t)pCB->commandBuffer, __LINE__, msgCode, "DS", |
| 4042 | "%s: This call must be issued inside an active render pass. %s", apiName, validation_error_map[msgCode]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4043 | } |
| 4044 | return outside; |
| 4045 | } |
| 4046 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 4047 | static void init_core_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4048 | |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 4049 | layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4050 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4051 | } |
| 4052 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 4053 | static void checkInstanceRegisterExtensions(const VkInstanceCreateInfo *pCreateInfo, instance_layer_data *instance_data) { |
| 4054 | for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) { |
| 4055 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SURFACE_EXTENSION_NAME)) |
| 4056 | instance_data->surfaceExtensionEnabled = true; |
| 4057 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_DISPLAY_EXTENSION_NAME)) |
| 4058 | instance_data->displayExtensionEnabled = true; |
| 4059 | #ifdef VK_USE_PLATFORM_ANDROID_KHR |
| 4060 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_ANDROID_SURFACE_EXTENSION_NAME)) |
| 4061 | instance_data->androidSurfaceExtensionEnabled = true; |
| 4062 | #endif |
| 4063 | #ifdef VK_USE_PLATFORM_MIR_KHR |
| 4064 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_MIR_SURFACE_EXTENSION_NAME)) |
| 4065 | instance_data->mirSurfaceExtensionEnabled = true; |
| 4066 | #endif |
| 4067 | #ifdef VK_USE_PLATFORM_WAYLAND_KHR |
| 4068 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_WAYLAND_SURFACE_EXTENSION_NAME)) |
| 4069 | instance_data->waylandSurfaceExtensionEnabled = true; |
| 4070 | #endif |
| 4071 | #ifdef VK_USE_PLATFORM_WIN32_KHR |
| 4072 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_WIN32_SURFACE_EXTENSION_NAME)) |
| 4073 | instance_data->win32SurfaceExtensionEnabled = true; |
| 4074 | #endif |
| 4075 | #ifdef VK_USE_PLATFORM_XCB_KHR |
| 4076 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_XCB_SURFACE_EXTENSION_NAME)) |
| 4077 | instance_data->xcbSurfaceExtensionEnabled = true; |
| 4078 | #endif |
| 4079 | #ifdef VK_USE_PLATFORM_XLIB_KHR |
| 4080 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_XLIB_SURFACE_EXTENSION_NAME)) |
| 4081 | instance_data->xlibSurfaceExtensionEnabled = true; |
| 4082 | #endif |
| 4083 | } |
| 4084 | } |
| 4085 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 4086 | VKAPI_ATTR VkResult VKAPI_CALL |
| 4087 | CreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4088 | VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); |
| 4089 | |
| 4090 | assert(chain_info->u.pLayerInfo); |
| 4091 | PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; |
| 4092 | PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); |
| 4093 | if (fpCreateInstance == NULL) |
| 4094 | return VK_ERROR_INITIALIZATION_FAILED; |
| 4095 | |
| 4096 | // Advance the link info for the next element on the chain |
| 4097 | chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; |
| 4098 | |
| 4099 | VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); |
| 4100 | if (result != VK_SUCCESS) |
| 4101 | return result; |
| 4102 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 4103 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), instance_layer_data_map); |
Chia-I Wu | b2c32ea | 2016-05-06 12:19:33 +0800 | [diff] [blame] | 4104 | instance_data->instance = *pInstance; |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4105 | layer_init_instance_dispatch_table(*pInstance, &instance_data->dispatch_table, fpGetInstanceProcAddr); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4106 | |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4107 | instance_data->report_data = debug_report_create_instance( |
| 4108 | &instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, pCreateInfo->ppEnabledExtensionNames); |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 4109 | checkInstanceRegisterExtensions(pCreateInfo, instance_data); |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 4110 | init_core_validation(instance_data, pAllocator); |
Mark Lobodzinski | bbe3d97 | 2016-06-29 10:53:51 -0600 | [diff] [blame] | 4111 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4112 | ValidateLayerOrdering(*pCreateInfo); |
| 4113 | |
| 4114 | return result; |
| 4115 | } |
| 4116 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 4117 | // Hook DestroyInstance to remove tableInstanceMap entry |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 4118 | VKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4119 | // TODOSC : Shouldn't need any customization here |
| 4120 | dispatch_key key = get_dispatch_key(instance); |
| 4121 | // TBD: Need any locking this early, in case this function is called at the |
| 4122 | // same time by more than one thread? |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4123 | instance_layer_data *instance_data = get_my_data_ptr(key, instance_layer_data_map); |
| 4124 | instance_data->dispatch_table.DestroyInstance(instance, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4125 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4126 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4127 | // Clean up logging callback, if any |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4128 | while (instance_data->logging_callback.size() > 0) { |
| 4129 | VkDebugReportCallbackEXT callback = instance_data->logging_callback.back(); |
| 4130 | layer_destroy_msg_callback(instance_data->report_data, callback, pAllocator); |
| 4131 | instance_data->logging_callback.pop_back(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4132 | } |
| 4133 | |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4134 | layer_debug_report_destroy_instance(instance_data->report_data); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4135 | layer_data_map.erase(key); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4136 | } |
| 4137 | |
Mark Young | aa1aa3a | 2016-07-05 16:41:50 -0600 | [diff] [blame] | 4138 | static void checkDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4139 | uint32_t i; |
| 4140 | // TBD: Need any locking, in case this function is called at the same time |
| 4141 | // by more than one thread? |
| 4142 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 4143 | dev_data->device_extensions.wsi_enabled = false; |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 4144 | dev_data->device_extensions.wsi_display_swapchain_enabled = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4145 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4146 | for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { |
| 4147 | if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) |
| 4148 | dev_data->device_extensions.wsi_enabled = true; |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 4149 | if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_DISPLAY_SWAPCHAIN_EXTENSION_NAME) == 0) |
| 4150 | dev_data->device_extensions.wsi_display_swapchain_enabled = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4151 | } |
| 4152 | } |
| 4153 | |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4154 | // Verify that queue family has been properly requested |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 4155 | static bool ValidateRequestedQueueFamilyProperties(instance_layer_data *instance_data, VkPhysicalDevice gpu, |
| 4156 | const VkDeviceCreateInfo *create_info) { |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4157 | bool skip_call = false; |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4158 | auto physical_device_state = getPhysicalDeviceState(instance_data, gpu); |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4159 | // First check is app has actually requested queueFamilyProperties |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4160 | if (!physical_device_state) { |
| 4161 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4162 | 0, __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", |
| 4163 | "Invalid call to vkCreateDevice() w/o first calling vkEnumeratePhysicalDevices()."); |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4164 | } else if (QUERY_DETAILS != physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4165 | // TODO: This is not called out as an invalid use in the spec so make more informative recommendation. |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4166 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4167 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, |
| 4168 | "DL", "Call to vkCreateDevice() w/o first calling vkGetPhysicalDeviceQueueFamilyProperties()."); |
| 4169 | } else { |
| 4170 | // Check that the requested queue properties are valid |
| 4171 | for (uint32_t i = 0; i < create_info->queueCreateInfoCount; i++) { |
| 4172 | uint32_t requestedIndex = create_info->pQueueCreateInfos[i].queueFamilyIndex; |
Chris Forbes | 8c09adb | 2016-10-03 18:06:20 +1300 | [diff] [blame] | 4173 | if (requestedIndex >= physical_device_state->queue_family_properties.size()) { |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4174 | skip_call |= log_msg( |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4175 | instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4176 | __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", |
| 4177 | "Invalid queue create request in vkCreateDevice(). Invalid queueFamilyIndex %u requested.", requestedIndex); |
| 4178 | } else if (create_info->pQueueCreateInfos[i].queueCount > |
Chris Forbes | 8c09adb | 2016-10-03 18:06:20 +1300 | [diff] [blame] | 4179 | physical_device_state->queue_family_properties[requestedIndex].queueCount) { |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4180 | skip_call |= |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4181 | log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4182 | 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", |
| 4183 | "Invalid queue create request in vkCreateDevice(). QueueFamilyIndex %u only has %u queues, but " |
| 4184 | "requested queueCount is %u.", |
Chris Forbes | 8c09adb | 2016-10-03 18:06:20 +1300 | [diff] [blame] | 4185 | requestedIndex, physical_device_state->queue_family_properties[requestedIndex].queueCount, |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4186 | create_info->pQueueCreateInfos[i].queueCount); |
| 4187 | } |
| 4188 | } |
| 4189 | } |
| 4190 | return skip_call; |
| 4191 | } |
| 4192 | |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4193 | // Verify that features have been queried and that they are available |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 4194 | static bool ValidateRequestedFeatures(instance_layer_data *dev_data, VkPhysicalDevice phys, const VkPhysicalDeviceFeatures *requested_features) { |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4195 | bool skip_call = false; |
| 4196 | |
Chris Forbes | 8245eba | 2016-10-03 17:36:32 +1300 | [diff] [blame] | 4197 | auto phys_device_state = getPhysicalDeviceState(dev_data, phys); |
| 4198 | const VkBool32 *actual = reinterpret_cast<VkBool32 *>(&phys_device_state->features); |
Mark Lobodzinski | bbe3d97 | 2016-06-29 10:53:51 -0600 | [diff] [blame] | 4199 | const VkBool32 *requested = reinterpret_cast<const VkBool32 *>(requested_features); |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4200 | // TODO : This is a nice, compact way to loop through struct, but a bad way to report issues |
| 4201 | // Need to provide the struct member name with the issue. To do that seems like we'll |
| 4202 | // have to loop through each struct member which should be done w/ codegen to keep in synch. |
| 4203 | uint32_t errors = 0; |
| 4204 | uint32_t total_bools = sizeof(VkPhysicalDeviceFeatures) / sizeof(VkBool32); |
| 4205 | for (uint32_t i = 0; i < total_bools; i++) { |
| 4206 | if (requested[i] > actual[i]) { |
| 4207 | // TODO: Add index to struct member name helper to be able to include a feature name |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4208 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4209 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, |
| 4210 | "DL", "While calling vkCreateDevice(), requesting feature #%u in VkPhysicalDeviceFeatures struct, " |
| 4211 | "which is not available on this device.", |
| 4212 | i); |
| 4213 | errors++; |
| 4214 | } |
| 4215 | } |
Chris Forbes | 8245eba | 2016-10-03 17:36:32 +1300 | [diff] [blame] | 4216 | if (errors && (UNCALLED == phys_device_state->vkGetPhysicalDeviceFeaturesState)) { |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4217 | // If user didn't request features, notify them that they should |
| 4218 | // TODO: Verify this against the spec. I believe this is an invalid use of the API and should return an error |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4219 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 4220 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, |
| 4221 | "DL", "You requested features that are unavailable on this device. You should first query feature " |
| 4222 | "availability by calling vkGetPhysicalDeviceFeatures()."); |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4223 | } |
| 4224 | return skip_call; |
| 4225 | } |
| 4226 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 4227 | VKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, |
| 4228 | const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 4229 | instance_layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), instance_layer_data_map); |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4230 | bool skip_call = false; |
| 4231 | |
| 4232 | // Check that any requested features are available |
| 4233 | if (pCreateInfo->pEnabledFeatures) { |
Chris Forbes | 8245eba | 2016-10-03 17:36:32 +1300 | [diff] [blame] | 4234 | skip_call |= ValidateRequestedFeatures(my_instance_data, gpu, pCreateInfo->pEnabledFeatures); |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4235 | } |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4236 | skip_call |= ValidateRequestedQueueFamilyProperties(my_instance_data, gpu, pCreateInfo); |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4237 | |
Mark Mueller | 49b3200 | 2016-08-16 09:47:31 -0600 | [diff] [blame] | 4238 | if (skip_call) { |
| 4239 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 4240 | } |
| 4241 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4242 | VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); |
| 4243 | |
| 4244 | assert(chain_info->u.pLayerInfo); |
| 4245 | PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; |
| 4246 | PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; |
Chia-I Wu | b2c32ea | 2016-05-06 12:19:33 +0800 | [diff] [blame] | 4247 | PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4248 | if (fpCreateDevice == NULL) { |
| 4249 | return VK_ERROR_INITIALIZATION_FAILED; |
| 4250 | } |
| 4251 | |
| 4252 | // Advance the link info for the next element on the chain |
| 4253 | chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; |
| 4254 | |
| 4255 | VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); |
| 4256 | if (result != VK_SUCCESS) { |
| 4257 | return result; |
| 4258 | } |
| 4259 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4260 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4261 | layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); |
| 4262 | |
Chris Forbes | 2e6c494 | 2016-10-03 17:44:52 +1300 | [diff] [blame] | 4263 | my_device_data->instance_data = my_instance_data; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4264 | // Setup device dispatch table |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 4265 | layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr); |
Chris Forbes | 1586450 | 2016-03-30 11:35:21 +1300 | [diff] [blame] | 4266 | my_device_data->device = *pDevice; |
Mark Lobodzinski | cf0f7b6 | 2016-11-16 12:12:56 -0700 | [diff] [blame] | 4267 | // Save PhysicalDevice handle |
| 4268 | my_device_data->physical_device = gpu; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4269 | |
| 4270 | my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); |
Mark Young | aa1aa3a | 2016-07-05 16:41:50 -0600 | [diff] [blame] | 4271 | checkDeviceRegisterExtensions(pCreateInfo, *pDevice); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4272 | // Get physical device limits for this device |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4273 | my_instance_data->dispatch_table.GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4274 | uint32_t count; |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4275 | my_instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 4276 | my_device_data->phys_dev_properties.queue_family_properties.resize(count); |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4277 | my_instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties( |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 4278 | gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4279 | // TODO: device limits should make sure these are compatible |
| 4280 | if (pCreateInfo->pEnabledFeatures) { |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 4281 | my_device_data->enabled_features = *pCreateInfo->pEnabledFeatures; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4282 | } else { |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 4283 | memset(&my_device_data->enabled_features, 0, sizeof(VkPhysicalDeviceFeatures)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4284 | } |
Mark Lobodzinski | f685859 | 2017-01-11 09:34:01 -0700 | [diff] [blame] | 4285 | // Store physical device properties and physical device mem limits into device layer_data structs |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4286 | my_instance_data->dispatch_table.GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); |
Mark Lobodzinski | f685859 | 2017-01-11 09:34:01 -0700 | [diff] [blame] | 4287 | my_instance_data->dispatch_table.GetPhysicalDeviceProperties(gpu, &my_device_data->phys_dev_props); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4288 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4289 | |
| 4290 | ValidateLayerOrdering(*pCreateInfo); |
| 4291 | |
| 4292 | return result; |
| 4293 | } |
| 4294 | |
| 4295 | // prototype |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 4296 | VKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4297 | // TODOSC : Shouldn't need any customization here |
Tobin Ehlis | bdacdd8 | 2016-10-12 07:25:59 -0600 | [diff] [blame] | 4298 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4299 | dispatch_key key = get_dispatch_key(device); |
| 4300 | layer_data *dev_data = get_my_data_ptr(key, layer_data_map); |
| 4301 | // Free all the memory |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4302 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4303 | deletePipelines(dev_data); |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 4304 | dev_data->renderPassMap.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4305 | deleteCommandBuffers(dev_data); |
Tobin Ehlis | 9bfd449 | 2016-05-05 15:09:11 -0600 | [diff] [blame] | 4306 | // This will also delete all sets in the pool & remove them from setMap |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4307 | deletePools(dev_data); |
Tobin Ehlis | 9bfd449 | 2016-05-05 15:09:11 -0600 | [diff] [blame] | 4308 | // All sets should be removed |
| 4309 | assert(dev_data->setMap.empty()); |
Tobin Ehlis | 546326f | 2016-04-26 11:06:05 -0600 | [diff] [blame] | 4310 | for (auto del_layout : dev_data->descriptorSetLayoutMap) { |
| 4311 | delete del_layout.second; |
| 4312 | } |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 4313 | dev_data->descriptorSetLayoutMap.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4314 | dev_data->imageViewMap.clear(); |
| 4315 | dev_data->imageMap.clear(); |
| 4316 | dev_data->imageSubresourceMap.clear(); |
| 4317 | dev_data->imageLayoutMap.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4318 | dev_data->bufferViewMap.clear(); |
| 4319 | dev_data->bufferMap.clear(); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4320 | // Queues persist until device is destroyed |
| 4321 | dev_data->queueMap.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4322 | // Report any memory leaks |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4323 | layer_debug_report_destroy_device(device); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4324 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4325 | |
| 4326 | #if DISPATCH_MAP_DEBUG |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4327 | fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4328 | #endif |
Tobin Ehlis | bdacdd8 | 2016-10-12 07:25:59 -0600 | [diff] [blame] | 4329 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 4330 | dev_data->dispatch_table.DestroyDevice(device, pAllocator); |
Tobin Ehlis | bdacdd8 | 2016-10-12 07:25:59 -0600 | [diff] [blame] | 4331 | layer_data_map.erase(key); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4332 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4333 | } |
| 4334 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4335 | static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; |
| 4336 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4337 | // This validates that the initial layout specified in the command buffer for |
| 4338 | // the IMAGE is the same |
| 4339 | // as the global IMAGE layout |
Chris Forbes | 3535888 | 2016-05-17 17:42:27 +1200 | [diff] [blame] | 4340 | static bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 4341 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4342 | for (auto cb_image_data : pCB->imageLayoutMap) { |
| 4343 | VkImageLayout imageLayout; |
| 4344 | if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { |
| 4345 | skip_call |= |
| 4346 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4347 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4348 | reinterpret_cast<const uint64_t &>(cb_image_data.first)); |
| 4349 | } else { |
| 4350 | if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { |
| 4351 | // TODO: Set memory invalid which is in mem_tracker currently |
| 4352 | } else if (imageLayout != cb_image_data.second.initialLayout) { |
Mark Young | 000d14d | 2016-04-11 16:53:53 -0600 | [diff] [blame] | 4353 | if (cb_image_data.first.hasSubresource) { |
| 4354 | skip_call |= log_msg( |
| 4355 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Chris Forbes | 3535888 | 2016-05-17 17:42:27 +1200 | [diff] [blame] | 4356 | reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4357 | "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " |
Mark Young | 000d14d | 2016-04-11 16:53:53 -0600 | [diff] [blame] | 4358 | "with layout %s when first use is %s.", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4359 | reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, |
| 4360 | cb_image_data.first.subresource.arrayLayer, |
| 4361 | cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), |
Mark Young | 000d14d | 2016-04-11 16:53:53 -0600 | [diff] [blame] | 4362 | string_VkImageLayout(cb_image_data.second.initialLayout)); |
| 4363 | } else { |
| 4364 | skip_call |= log_msg( |
| 4365 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Chris Forbes | 3535888 | 2016-05-17 17:42:27 +1200 | [diff] [blame] | 4366 | reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4367 | "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " |
Mark Young | 000d14d | 2016-04-11 16:53:53 -0600 | [diff] [blame] | 4368 | "first use is %s.", |
| 4369 | reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), |
| 4370 | string_VkImageLayout(cb_image_data.second.initialLayout)); |
| 4371 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4372 | } |
| 4373 | SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); |
| 4374 | } |
| 4375 | } |
| 4376 | return skip_call; |
| 4377 | } |
Mark Lobodzinski | f7422d9 | 2016-03-25 15:22:33 -0600 | [diff] [blame] | 4378 | |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4379 | // Loop through bound objects and increment their in_use counts |
| 4380 | // For any unknown objects, flag an error |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4381 | static bool ValidateAndIncrementBoundObjects(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4382 | bool skip = false; |
| 4383 | DRAW_STATE_ERROR error_code = DRAWSTATE_NONE; |
| 4384 | BASE_NODE *base_obj = nullptr; |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4385 | for (auto obj : cb_node->object_bindings) { |
| 4386 | switch (obj.type) { |
| 4387 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4388 | base_obj = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(obj.handle)); |
| 4389 | error_code = DRAWSTATE_INVALID_DESCRIPTOR_SET; |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4390 | break; |
| 4391 | } |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 4392 | case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 4393 | base_obj = getSamplerState(dev_data, reinterpret_cast<VkSampler &>(obj.handle)); |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4394 | error_code = DRAWSTATE_INVALID_SAMPLER; |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 4395 | break; |
| 4396 | } |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4397 | case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4398 | base_obj = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(obj.handle)); |
| 4399 | error_code = DRAWSTATE_INVALID_QUERY_POOL; |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4400 | break; |
| 4401 | } |
| 4402 | case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 4403 | base_obj = getPipelineState(dev_data, reinterpret_cast<VkPipeline &>(obj.handle)); |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4404 | error_code = DRAWSTATE_INVALID_PIPELINE; |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4405 | break; |
| 4406 | } |
| 4407 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 4408 | base_obj = getBufferState(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4409 | error_code = DRAWSTATE_INVALID_BUFFER; |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4410 | break; |
| 4411 | } |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4412 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: { |
| 4413 | base_obj = getBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(obj.handle)); |
| 4414 | error_code = DRAWSTATE_INVALID_BUFFER_VIEW; |
| 4415 | break; |
| 4416 | } |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4417 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 4418 | base_obj = getImageState(dev_data, reinterpret_cast<VkImage &>(obj.handle)); |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4419 | error_code = DRAWSTATE_INVALID_IMAGE; |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4420 | break; |
| 4421 | } |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4422 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: { |
| 4423 | base_obj = getImageViewState(dev_data, reinterpret_cast<VkImageView &>(obj.handle)); |
| 4424 | error_code = DRAWSTATE_INVALID_IMAGE_VIEW; |
| 4425 | break; |
| 4426 | } |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4427 | case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4428 | base_obj = getEventNode(dev_data, reinterpret_cast<VkEvent &>(obj.handle)); |
| 4429 | error_code = DRAWSTATE_INVALID_EVENT; |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4430 | break; |
| 4431 | } |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4432 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: { |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 4433 | base_obj = getDescriptorPoolState(dev_data, reinterpret_cast<VkDescriptorPool &>(obj.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4434 | error_code = DRAWSTATE_INVALID_DESCRIPTOR_POOL; |
| 4435 | break; |
| 4436 | } |
| 4437 | case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: { |
| 4438 | base_obj = getCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(obj.handle)); |
| 4439 | error_code = DRAWSTATE_INVALID_COMMAND_POOL; |
| 4440 | break; |
| 4441 | } |
| 4442 | case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: { |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 4443 | base_obj = getFramebufferState(dev_data, reinterpret_cast<VkFramebuffer &>(obj.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4444 | error_code = DRAWSTATE_INVALID_FRAMEBUFFER; |
| 4445 | break; |
| 4446 | } |
| 4447 | case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 4448 | base_obj = getRenderPassState(dev_data, reinterpret_cast<VkRenderPass &>(obj.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4449 | error_code = DRAWSTATE_INVALID_RENDERPASS; |
| 4450 | break; |
| 4451 | } |
| 4452 | case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: { |
| 4453 | base_obj = getMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(obj.handle)); |
| 4454 | error_code = DRAWSTATE_INVALID_DEVICE_MEMORY; |
| 4455 | break; |
| 4456 | } |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4457 | default: |
| 4458 | // TODO : Merge handling of other objects types into this code |
| 4459 | break; |
| 4460 | } |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4461 | if (!base_obj) { |
| 4462 | skip |= |
| 4463 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj.type, obj.handle, __LINE__, error_code, "DS", |
| 4464 | "Cannot submit cmd buffer using deleted %s 0x%" PRIx64 ".", object_type_to_string(obj.type), obj.handle); |
| 4465 | } else { |
| 4466 | base_obj->in_use.fetch_add(1); |
| 4467 | } |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4468 | } |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4469 | return skip; |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4470 | } |
| 4471 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4472 | // Track which resources are in-flight by atomically incrementing their "in_use" count |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4473 | static bool validateAndIncrementResources(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 4474 | bool skip_call = false; |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4475 | |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4476 | cb_node->in_use.fetch_add(1); |
| 4477 | dev_data->globalInFlightCmdBuffers.insert(cb_node->commandBuffer); |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4478 | |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4479 | // First Increment for all "generic" objects bound to cmd buffer, followed by special-case objects below |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4480 | skip_call |= ValidateAndIncrementBoundObjects(dev_data, cb_node); |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4481 | // TODO : We should be able to remove the NULL look-up checks from the code below as long as |
| 4482 | // all the corresponding cases are verified to cause CB_INVALID state and the CB_INVALID state |
| 4483 | // should then be flagged prior to calling this function |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4484 | for (auto drawDataElement : cb_node->drawData) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4485 | for (auto buffer : drawDataElement.buffers) { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 4486 | auto buffer_state = getBufferState(dev_data, buffer); |
| 4487 | if (!buffer_state) { |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4488 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4489 | (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4490 | "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4491 | } else { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 4492 | buffer_state->in_use.fetch_add(1); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4493 | } |
| 4494 | } |
| 4495 | } |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4496 | for (auto event : cb_node->writeEventsBeforeWait) { |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 4497 | auto event_state = getEventNode(dev_data, event); |
| 4498 | if (event_state) |
| 4499 | event_state->write_in_use++; |
Michael Lentine | 860b0fe | 2016-05-20 10:14:00 -0500 | [diff] [blame] | 4500 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4501 | return skip_call; |
| 4502 | } |
| 4503 | |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4504 | // Note: This function assumes that the global lock is held by the calling thread. |
| 4505 | // For the given queue, verify the queue state up to the given seq number. |
| 4506 | // Currently the only check is to make sure that if there are events to be waited on prior to |
| 4507 | // a QueryReset, make sure that all such events have been signalled. |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4508 | static bool VerifyQueueStateToSeq(layer_data *dev_data, QUEUE_STATE *queue, uint64_t seq) { |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4509 | bool skip = false; |
| 4510 | auto queue_seq = queue->seq; |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4511 | std::unordered_map<VkQueue, uint64_t> other_queue_seqs; |
| 4512 | auto sub_it = queue->submissions.begin(); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4513 | while (queue_seq < seq) { |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4514 | for (auto &wait : sub_it->waitSemaphores) { |
| 4515 | auto &last_seq = other_queue_seqs[wait.queue]; |
| 4516 | last_seq = std::max(last_seq, wait.seq); |
| 4517 | } |
| 4518 | for (auto cb : sub_it->cbs) { |
| 4519 | auto cb_node = getCBNode(dev_data, cb); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4520 | if (cb_node) { |
| 4521 | for (auto queryEventsPair : cb_node->waitedEventsBeforeQueryReset) { |
| 4522 | for (auto event : queryEventsPair.second) { |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4523 | if (dev_data->eventMap[event].needsSignaled) { |
| 4524 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4525 | VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", |
| 4526 | "Cannot get query results on queryPool 0x%" PRIx64 |
| 4527 | " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", |
| 4528 | (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); |
| 4529 | } |
| 4530 | } |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 4531 | } |
| 4532 | } |
| 4533 | } |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4534 | sub_it++; |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4535 | queue_seq++; |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 4536 | } |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4537 | for (auto qs : other_queue_seqs) { |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4538 | skip |= VerifyQueueStateToSeq(dev_data, getQueueState(dev_data, qs.first), qs.second); |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4539 | } |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4540 | return skip; |
| 4541 | } |
| 4542 | |
| 4543 | // When the given fence is retired, verify outstanding queue operations through the point of the fence |
| 4544 | static bool VerifyQueueStateToFence(layer_data *dev_data, VkFence fence) { |
| 4545 | auto fence_state = getFenceNode(dev_data, fence); |
| 4546 | if (VK_NULL_HANDLE != fence_state->signaler.first) { |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4547 | return VerifyQueueStateToSeq(dev_data, getQueueState(dev_data, fence_state->signaler.first), fence_state->signaler.second); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4548 | } |
| 4549 | return false; |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 4550 | } |
Chris Forbes | 5e3bfd6 | 2016-06-24 17:04:54 +1200 | [diff] [blame] | 4551 | |
| 4552 | // TODO: nuke this completely. |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 4553 | // Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers |
| 4554 | static inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { |
| 4555 | // Pull it off of global list initially, but if we find it in any other queue list, add it back in |
| 4556 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); |
| 4557 | pCB->in_use.fetch_sub(1); |
| 4558 | if (!pCB->in_use.load()) { |
| 4559 | dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); |
| 4560 | } |
| 4561 | } |
| 4562 | |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4563 | // Decrement in-use count for objects bound to command buffer |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4564 | static void DecrementBoundResources(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { |
Tobin Ehlis | 1dc7d5a | 2016-09-14 07:01:11 -0600 | [diff] [blame] | 4565 | BASE_NODE *base_obj = nullptr; |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4566 | for (auto obj : cb_node->object_bindings) { |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4567 | base_obj = GetStateStructPtrFromObject(dev_data, obj); |
Tobin Ehlis | 1dc7d5a | 2016-09-14 07:01:11 -0600 | [diff] [blame] | 4568 | if (base_obj) { |
| 4569 | base_obj->in_use.fetch_sub(1); |
| 4570 | } |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4571 | } |
| 4572 | } |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4573 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4574 | static void RetireWorkOnQueue(layer_data *dev_data, QUEUE_STATE *pQueue, uint64_t seq) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4575 | std::unordered_map<VkQueue, uint64_t> otherQueueSeqs; |
| 4576 | |
| 4577 | // Roll this queue forward, one submission at a time. |
| 4578 | while (pQueue->seq < seq) { |
| 4579 | auto & submission = pQueue->submissions.front(); |
| 4580 | |
| 4581 | for (auto & wait : submission.waitSemaphores) { |
| 4582 | auto pSemaphore = getSemaphoreNode(dev_data, wait.semaphore); |
Mark Lobodzinski | c3343ae | 2016-11-11 15:27:12 -0700 | [diff] [blame] | 4583 | if (pSemaphore) { |
| 4584 | pSemaphore->in_use.fetch_sub(1); |
| 4585 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4586 | auto & lastSeq = otherQueueSeqs[wait.queue]; |
| 4587 | lastSeq = std::max(lastSeq, wait.seq); |
| 4588 | } |
| 4589 | |
| 4590 | for (auto & semaphore : submission.signalSemaphores) { |
| 4591 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
Mark Lobodzinski | c3343ae | 2016-11-11 15:27:12 -0700 | [diff] [blame] | 4592 | if (pSemaphore) { |
| 4593 | pSemaphore->in_use.fetch_sub(1); |
| 4594 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4595 | } |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 4596 | |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4597 | for (auto cb : submission.cbs) { |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4598 | auto cb_node = getCBNode(dev_data, cb); |
Mark Lobodzinski | c3343ae | 2016-11-11 15:27:12 -0700 | [diff] [blame] | 4599 | if (!cb_node) { |
| 4600 | continue; |
| 4601 | } |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4602 | // First perform decrement on general case bound objects |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4603 | DecrementBoundResources(dev_data, cb_node); |
| 4604 | for (auto drawDataElement : cb_node->drawData) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4605 | for (auto buffer : drawDataElement.buffers) { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 4606 | auto buffer_state = getBufferState(dev_data, buffer); |
| 4607 | if (buffer_state) { |
| 4608 | buffer_state->in_use.fetch_sub(1); |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4609 | } |
| 4610 | } |
| 4611 | } |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4612 | for (auto event : cb_node->writeEventsBeforeWait) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4613 | auto eventNode = dev_data->eventMap.find(event); |
| 4614 | if (eventNode != dev_data->eventMap.end()) { |
| 4615 | eventNode->second.write_in_use--; |
| 4616 | } |
| 4617 | } |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4618 | for (auto queryStatePair : cb_node->queryToStateMap) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4619 | dev_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; |
| 4620 | } |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4621 | for (auto eventStagePair : cb_node->eventToStageMap) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4622 | dev_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; |
| 4623 | } |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 4624 | |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4625 | removeInFlightCmdBuffer(dev_data, cb); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4626 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4627 | |
| 4628 | auto pFence = getFenceNode(dev_data, submission.fence); |
| 4629 | if (pFence) { |
| 4630 | pFence->state = FENCE_RETIRED; |
| 4631 | } |
| 4632 | |
| 4633 | pQueue->submissions.pop_front(); |
| 4634 | pQueue->seq++; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4635 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4636 | |
| 4637 | // Roll other queues forward to the highest seq we saw a wait for |
| 4638 | for (auto qs : otherQueueSeqs) { |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4639 | RetireWorkOnQueue(dev_data, getQueueState(dev_data, qs.first), qs.second); |
Michael Lentine | b48e141 | 2016-04-29 18:37:32 -0500 | [diff] [blame] | 4640 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4641 | } |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4642 | |
| 4643 | |
| 4644 | // Submit a fence to a queue, delimiting previous fences and previous untracked |
| 4645 | // work by it. |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4646 | static void SubmitFence(QUEUE_STATE *pQueue, FENCE_NODE *pFence, uint64_t submitCount) { |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 4647 | pFence->state = FENCE_INFLIGHT; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4648 | pFence->signaler.first = pQueue->queue; |
| 4649 | pFence->signaler.second = pQueue->seq + pQueue->submissions.size() + submitCount; |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 4650 | } |
| 4651 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 4652 | static bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4653 | bool skip_call = false; |
| 4654 | if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && |
| 4655 | !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4656 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 4657 | 0, __LINE__, VALIDATION_ERROR_00133, "DS", |
| 4658 | "Command Buffer 0x%p is already in use and is not marked for simultaneous use. %s", pCB->commandBuffer, |
| 4659 | validation_error_map[VALIDATION_ERROR_00133]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4660 | } |
| 4661 | return skip_call; |
| 4662 | } |
| 4663 | |
Tobin Ehlis | f7cf915 | 2016-09-27 13:10:33 -0600 | [diff] [blame] | 4664 | static bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const char *call_source) { |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4665 | bool skip = false; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 4666 | if (dev_data->instance_data->disabled.command_buffer_state) |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4667 | return skip; |
Tobin Ehlis | e5184af | 2016-04-14 15:44:20 -0600 | [diff] [blame] | 4668 | // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once |
| 4669 | if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4670 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 4671 | __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4672 | "Commandbuffer 0x%p was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4673 | "set, but has been submitted 0x%" PRIxLEAST64 " times.", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4674 | pCB->commandBuffer, pCB->submitCount); |
Tobin Ehlis | e5184af | 2016-04-14 15:44:20 -0600 | [diff] [blame] | 4675 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4676 | // Validate that cmd buffers have been updated |
| 4677 | if (CB_RECORDED != pCB->state) { |
| 4678 | if (CB_INVALID == pCB->state) { |
| 4679 | // Inform app of reason CB invalid |
Tobin Ehlis | 2556f5b | 2016-06-24 17:22:16 -0600 | [diff] [blame] | 4680 | for (auto obj : pCB->broken_bindings) { |
| 4681 | const char *type_str = object_type_to_string(obj.type); |
| 4682 | // Descriptor sets are a special case that can be either destroyed or updated to invalidated a CB |
| 4683 | const char *cause_str = |
| 4684 | (obj.type == VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT) ? "destroyed or updated" : "destroyed"; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4685 | |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4686 | skip |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4687 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 4688 | reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4689 | "You are submitting command buffer 0x%p that is invalid because bound %s 0x%" PRIxLEAST64 " was %s.", |
| 4690 | pCB->commandBuffer, type_str, obj.handle, cause_str); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4691 | } |
| 4692 | } else { // Flag error for using CB w/o vkEndCommandBuffer() called |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4693 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 4694 | (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4695 | "You must call vkEndCommandBuffer() on command buffer 0x%p before this call to %s!", pCB->commandBuffer, |
| 4696 | call_source); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4697 | } |
| 4698 | } |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4699 | return skip; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4700 | } |
| 4701 | |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 4702 | // Validate that queueFamilyIndices of primary command buffers match this queue |
| 4703 | // Secondary command buffers were previously validated in vkCmdExecuteCommands(). |
| 4704 | static bool validateQueueFamilyIndices(layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkQueue queue) { |
| 4705 | bool skip_call = false; |
| 4706 | auto pPool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4707 | auto queue_state = getQueueState(dev_data, queue); |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 4708 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4709 | if (pPool && queue_state && (pPool->queueFamilyIndex != queue_state->queueFamilyIndex)) { |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 4710 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 4711 | reinterpret_cast<uint64_t>(pCB->commandBuffer), __LINE__, VALIDATION_ERROR_00139, "DS", |
| 4712 | "vkQueueSubmit: Primary command buffer 0x%p created in queue family %d is being submitted on queue " |
| 4713 | "0x%p from queue family %d. %s", |
| 4714 | pCB->commandBuffer, pPool->queueFamilyIndex, queue, queue_state->queueFamilyIndex, |
| 4715 | validation_error_map[VALIDATION_ERROR_00139]); |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 4716 | } |
| 4717 | |
| 4718 | return skip_call; |
| 4719 | } |
| 4720 | |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4721 | static bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4722 | // Track in-use for resources off of primary and any secondary CBs |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4723 | bool skip_call = false; |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4724 | |
| 4725 | // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing |
| 4726 | // on device |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4727 | skip_call |= validateCommandBufferSimultaneousUse(dev_data, pCB); |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4728 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4729 | skip_call |= validateAndIncrementResources(dev_data, pCB); |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4730 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4731 | if (!pCB->secondaryCommandBuffers.empty()) { |
| 4732 | for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4733 | GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4734 | skip_call |= validateAndIncrementResources(dev_data, pSubCB); |
Tobin Ehlis | 1857d61 | 2016-05-09 13:22:50 -0600 | [diff] [blame] | 4735 | if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && |
| 4736 | !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 4737 | log_msg( |
| 4738 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 4739 | __LINE__, VALIDATION_ERROR_00135, "DS", |
| 4740 | "Commandbuffer 0x%p was submitted with secondary buffer 0x%p but that buffer has subsequently been bound to " |
| 4741 | "primary cmd buffer 0x%p and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set. %s", |
| 4742 | pCB->commandBuffer, secondaryCmdBuffer, pSubCB->primaryCommandBuffer, |
| 4743 | validation_error_map[VALIDATION_ERROR_00135]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4744 | } |
| 4745 | } |
| 4746 | } |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4747 | |
Tobin Ehlis | f7cf915 | 2016-09-27 13:10:33 -0600 | [diff] [blame] | 4748 | skip_call |= validateCommandBufferState(dev_data, pCB, "vkQueueSubmit()"); |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4749 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4750 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4751 | } |
| 4752 | |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4753 | static bool |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4754 | ValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4755 | { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4756 | bool skip_call = false; |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4757 | |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4758 | if (pFence) { |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 4759 | if (pFence->state == FENCE_INFLIGHT) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 4760 | // TODO: opportunities for VALIDATION_ERROR_00127, VALIDATION_ERROR_01647, VALIDATION_ERROR_01953 |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4761 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| 4762 | (uint64_t)(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", |
| 4763 | "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(pFence->fence)); |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 4764 | } |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4765 | |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 4766 | else if (pFence->state == FENCE_RETIRED) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 4767 | // TODO: opportunities for VALIDATION_ERROR_00126, VALIDATION_ERROR_01646, VALIDATION_ERROR_01953 |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4768 | skip_call |= |
| 4769 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| 4770 | reinterpret_cast<uint64_t &>(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", |
| 4771 | "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", |
| 4772 | reinterpret_cast<uint64_t &>(pFence->fence)); |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 4773 | } |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4774 | } |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4775 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4776 | return skip_call; |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4777 | } |
| 4778 | |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4779 | |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4780 | VKAPI_ATTR VkResult VKAPI_CALL |
| 4781 | QueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4782 | bool skip_call = false; |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4783 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
| 4784 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| 4785 | std::unique_lock<std::mutex> lock(global_lock); |
| 4786 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4787 | auto pQueue = getQueueState(dev_data, queue); |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4788 | auto pFence = getFenceNode(dev_data, fence); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4789 | skip_call |= ValidateFenceForSubmit(dev_data, pFence); |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4790 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4791 | if (skip_call) { |
Chris Forbes | 40028e2 | 2016-06-13 09:59:34 +1200 | [diff] [blame] | 4792 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 4793 | } |
| 4794 | |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4795 | // Mark the fence in-use. |
| 4796 | if (pFence) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4797 | SubmitFence(pQueue, pFence, std::max(1u, submitCount)); |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4798 | } |
| 4799 | |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4800 | // Now verify each individual submit |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4801 | for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { |
| 4802 | const VkSubmitInfo *submit = &pSubmits[submit_idx]; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4803 | vector<SEMAPHORE_WAIT> semaphore_waits; |
| 4804 | vector<VkSemaphore> semaphore_signals; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4805 | for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4806 | VkSemaphore semaphore = submit->pWaitSemaphores[i]; |
| 4807 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4808 | if (pSemaphore) { |
| 4809 | if (pSemaphore->signaled) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4810 | if (pSemaphore->signaler.first != VK_NULL_HANDLE) { |
| 4811 | semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); |
| 4812 | pSemaphore->in_use.fetch_add(1); |
| 4813 | } |
| 4814 | pSemaphore->signaler.first = VK_NULL_HANDLE; |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4815 | pSemaphore->signaled = false; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4816 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4817 | skip_call |= |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4818 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| 4819 | reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4820 | "Queue 0x%p is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", queue, |
| 4821 | reinterpret_cast<const uint64_t &>(semaphore)); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4822 | } |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4823 | } |
| 4824 | } |
| 4825 | for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4826 | VkSemaphore semaphore = submit->pSignalSemaphores[i]; |
| 4827 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
| 4828 | if (pSemaphore) { |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4829 | if (pSemaphore->signaled) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4830 | skip_call |= |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4831 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| 4832 | reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4833 | "Queue 0x%p is signaling semaphore 0x%" PRIx64 |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4834 | " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4835 | queue, reinterpret_cast<const uint64_t &>(semaphore), |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4836 | reinterpret_cast<uint64_t &>(pSemaphore->signaler.first)); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4837 | } else { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4838 | pSemaphore->signaler.first = queue; |
| 4839 | pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4840 | pSemaphore->signaled = true; |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4841 | pSemaphore->in_use.fetch_add(1); |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4842 | semaphore_signals.push_back(semaphore); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4843 | } |
| 4844 | } |
| 4845 | } |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4846 | |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4847 | std::vector<VkCommandBuffer> cbs; |
| 4848 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4849 | for (uint32_t i = 0; i < submit->commandBufferCount; i++) { |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4850 | auto cb_node = getCBNode(dev_data, submit->pCommandBuffers[i]); |
| 4851 | skip_call |= ValidateCmdBufImageLayouts(dev_data, cb_node); |
| 4852 | if (cb_node) { |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4853 | cbs.push_back(submit->pCommandBuffers[i]); |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4854 | for (auto secondaryCmdBuffer : cb_node->secondaryCommandBuffers) { |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4855 | cbs.push_back(secondaryCmdBuffer); |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4856 | } |
| 4857 | |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4858 | cb_node->submitCount++; // increment submit count |
| 4859 | skip_call |= validatePrimaryCommandBufferState(dev_data, cb_node); |
| 4860 | skip_call |= validateQueueFamilyIndices(dev_data, cb_node, queue); |
Tobin Ehlis | 545fae3 | 2016-09-06 20:37:01 -0600 | [diff] [blame] | 4861 | // Potential early exit here as bad object state may crash in delayed function calls |
| 4862 | if (skip_call) |
| 4863 | return result; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4864 | // Call submit-time functions to validate/update state |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4865 | for (auto &function : cb_node->validate_functions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4866 | skip_call |= function(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4867 | } |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4868 | for (auto &function : cb_node->eventUpdates) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4869 | skip_call |= function(queue); |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 4870 | } |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4871 | for (auto &function : cb_node->queryUpdates) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4872 | skip_call |= function(queue); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 4873 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4874 | } |
| 4875 | } |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4876 | |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4877 | pQueue->submissions.emplace_back(cbs, semaphore_waits, semaphore_signals, |
| 4878 | submit_idx == submitCount - 1 ? fence : VK_NULL_HANDLE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4879 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4880 | |
| 4881 | if (pFence && !submitCount) { |
| 4882 | // If no submissions, but just dropping a fence on the end of the queue, |
| 4883 | // record an empty submission with just the fence, so we can determine |
| 4884 | // its completion. |
| 4885 | pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), |
| 4886 | std::vector<SEMAPHORE_WAIT>(), |
| 4887 | std::vector<VkSemaphore>(), |
| 4888 | fence); |
| 4889 | } |
| 4890 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4891 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4892 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 4893 | result = dev_data->dispatch_table.QueueSubmit(queue, submitCount, pSubmits, fence); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4894 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4895 | return result; |
| 4896 | } |
| 4897 | |
Karl Schultz | 8e3bccf | 2016-11-11 16:09:47 -0700 | [diff] [blame] | 4898 | static bool PreCallValidateAllocateMemory(layer_data *dev_data) { |
| 4899 | bool skip = false; |
| 4900 | if (dev_data->memObjMap.size() >= dev_data->phys_dev_properties.properties.limits.maxMemoryAllocationCount) { |
| 4901 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| 4902 | reinterpret_cast<const uint64_t &>(dev_data->device), __LINE__, VALIDATION_ERROR_00611, "MEM", |
| 4903 | "Number of currently valid memory objects is not less than the maximum allowed (%u). %s", |
| 4904 | dev_data->phys_dev_properties.properties.limits.maxMemoryAllocationCount, |
| 4905 | validation_error_map[VALIDATION_ERROR_00611]); |
| 4906 | } |
| 4907 | return skip; |
| 4908 | } |
| 4909 | |
| 4910 | static void PostCallRecordAllocateMemory(layer_data *dev_data, const VkMemoryAllocateInfo *pAllocateInfo, VkDeviceMemory *pMemory) { |
| 4911 | add_mem_obj_info(dev_data, dev_data->device, *pMemory, pAllocateInfo); |
Karl Schultz | 8e3bccf | 2016-11-11 16:09:47 -0700 | [diff] [blame] | 4912 | return; |
| 4913 | } |
| 4914 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 4915 | VKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, |
| 4916 | const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { |
Karl Schultz | 8e3bccf | 2016-11-11 16:09:47 -0700 | [diff] [blame] | 4917 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| 4918 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 4919 | std::unique_lock<std::mutex> lock(global_lock); |
| 4920 | bool skip = PreCallValidateAllocateMemory(dev_data); |
| 4921 | if (!skip) { |
| 4922 | lock.unlock(); |
| 4923 | result = dev_data->dispatch_table.AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); |
| 4924 | lock.lock(); |
| 4925 | if (VK_SUCCESS == result) { |
| 4926 | PostCallRecordAllocateMemory(dev_data, pAllocateInfo, pMemory); |
| 4927 | } |
Mark Lobodzinski | 8fbf571 | 2016-11-14 08:18:09 -0700 | [diff] [blame] | 4928 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4929 | return result; |
| 4930 | } |
| 4931 | |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4932 | // For given obj node, if it is use, flag a validation error and return callback result, else return false |
| 4933 | bool ValidateObjectNotInUse(const layer_data *dev_data, BASE_NODE *obj_node, VK_OBJECT obj_struct, |
| 4934 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| 4935 | if (dev_data->instance_data->disabled.object_in_use) |
| 4936 | return false; |
| 4937 | bool skip = false; |
| 4938 | if (obj_node->in_use.load()) { |
| 4939 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_struct.type, obj_struct.handle, __LINE__, |
| 4940 | error_code, "DS", "Cannot delete %s 0x%" PRIx64 " that is currently in use by a command buffer. %s", |
| 4941 | object_type_to_string(obj_struct.type), obj_struct.handle, validation_error_map[error_code]); |
| 4942 | } |
| 4943 | return skip; |
| 4944 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4945 | |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4946 | static bool PreCallValidateFreeMemory(layer_data *dev_data, VkDeviceMemory mem, DEVICE_MEM_INFO **mem_info, VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 4947 | *mem_info = getMemObjInfo(dev_data, mem); |
| 4948 | *obj_struct = {reinterpret_cast<uint64_t &>(mem), VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT}; |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4949 | if (dev_data->instance_data->disabled.free_memory) |
| 4950 | return false; |
| 4951 | bool skip = false; |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4952 | if (*mem_info) { |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4953 | skip |= ValidateObjectNotInUse(dev_data, *mem_info, *obj_struct, VALIDATION_ERROR_00620); |
| 4954 | } |
| 4955 | return skip; |
| 4956 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4957 | |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4958 | static void PostCallRecordFreeMemory(layer_data *dev_data, VkDeviceMemory mem, DEVICE_MEM_INFO *mem_info, VK_OBJECT obj_struct) { |
| 4959 | // Clear mem binding for any bound objects |
Tobin Ehlis | 5b38d77 | 2016-10-25 22:00:47 -0600 | [diff] [blame] | 4960 | for (auto obj : mem_info->obj_bindings) { |
| 4961 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, MEMTRACK_FREED_MEM_REF, |
| 4962 | "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, obj.handle, |
| 4963 | (uint64_t)mem_info->mem); |
| 4964 | switch (obj.type) { |
| 4965 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { |
| 4966 | auto image_state = getImageState(dev_data, reinterpret_cast<VkImage &>(obj.handle)); |
| 4967 | assert(image_state); // Any destroyed images should already be removed from bindings |
| 4968 | image_state->binding.mem = MEMORY_UNBOUND; |
| 4969 | break; |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4970 | } |
Tobin Ehlis | 5b38d77 | 2016-10-25 22:00:47 -0600 | [diff] [blame] | 4971 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 4972 | auto buffer_state = getBufferState(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); |
| 4973 | assert(buffer_state); // Any destroyed buffers should already be removed from bindings |
| 4974 | buffer_state->binding.mem = MEMORY_UNBOUND; |
Tobin Ehlis | 5b38d77 | 2016-10-25 22:00:47 -0600 | [diff] [blame] | 4975 | break; |
| 4976 | } |
| 4977 | default: |
| 4978 | // Should only have buffer or image objects bound to memory |
| 4979 | assert(0); |
| 4980 | } |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4981 | } |
| 4982 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 4983 | invalidateCommandBuffers(dev_data, mem_info->cb_bindings, obj_struct); |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4984 | dev_data->memObjMap.erase(mem); |
| 4985 | } |
| 4986 | |
| 4987 | VKAPI_ATTR void VKAPI_CALL FreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { |
| 4988 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 4989 | DEVICE_MEM_INFO *mem_info = nullptr; |
| 4990 | VK_OBJECT obj_struct; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4991 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4992 | bool skip = PreCallValidateFreeMemory(dev_data, mem, &mem_info, &obj_struct); |
| 4993 | if (!skip) { |
| 4994 | lock.unlock(); |
| 4995 | dev_data->dispatch_table.FreeMemory(device, mem, pAllocator); |
| 4996 | lock.lock(); |
| 4997 | PostCallRecordFreeMemory(dev_data, mem, mem_info, obj_struct); |
Mark Mueller | f377ffb | 2016-07-11 15:03:44 -0600 | [diff] [blame] | 4998 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4999 | } |
| 5000 | |
Tobin Ehlis | b495d5f | 2016-08-04 09:33:02 -0600 | [diff] [blame] | 5001 | // Validate that given Map memory range is valid. This means that the memory should not already be mapped, |
| 5002 | // and that the size of the map range should be: |
| 5003 | // 1. Not zero |
| 5004 | // 2. Within the size of the memory allocation |
| 5005 | static bool ValidateMapMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5006 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5007 | |
| 5008 | if (size == 0) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5009 | skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 5010 | (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", |
| 5011 | "VkMapMemory: Attempting to map memory range of size zero"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5012 | } |
| 5013 | |
| 5014 | auto mem_element = my_data->memObjMap.find(mem); |
| 5015 | if (mem_element != my_data->memObjMap.end()) { |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 5016 | auto mem_info = mem_element->second.get(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5017 | // It is an application error to call VkMapMemory on an object that is already mapped |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5018 | if (mem_info->mem_range.size != 0) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5019 | skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 5020 | (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", |
| 5021 | "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5022 | } |
| 5023 | |
| 5024 | // Validate that offset + size is within object's allocationSize |
| 5025 | if (size == VK_WHOLE_SIZE) { |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5026 | if (offset >= mem_info->alloc_info.allocationSize) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5027 | skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 5028 | VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, |
| 5029 | "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 |
| 5030 | " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5031 | offset, mem_info->alloc_info.allocationSize, mem_info->alloc_info.allocationSize); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5032 | } |
| 5033 | } else { |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5034 | if ((offset + size) > mem_info->alloc_info.allocationSize) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5035 | skip_call = log_msg( |
| 5036 | my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 5037 | (uint64_t)mem, __LINE__, VALIDATION_ERROR_00628, "MEM", |
| 5038 | "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64 ". %s", offset, |
| 5039 | size + offset, mem_info->alloc_info.allocationSize, validation_error_map[VALIDATION_ERROR_00628]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5040 | } |
| 5041 | } |
| 5042 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5043 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5044 | } |
| 5045 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 5046 | static void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 5047 | auto mem_info = getMemObjInfo(my_data, mem); |
| 5048 | if (mem_info) { |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5049 | mem_info->mem_range.offset = offset; |
| 5050 | mem_info->mem_range.size = size; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5051 | } |
| 5052 | } |
| 5053 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 5054 | static bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5055 | bool skip_call = false; |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 5056 | auto mem_info = getMemObjInfo(my_data, mem); |
| 5057 | if (mem_info) { |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5058 | if (!mem_info->mem_range.size) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5059 | // Valid Usage: memory must currently be mapped |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5060 | skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5061 | (uint64_t)mem, __LINE__, VALIDATION_ERROR_00649, "MEM", |
| 5062 | "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64 ". %s", (uint64_t)mem, |
| 5063 | validation_error_map[VALIDATION_ERROR_00649]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5064 | } |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5065 | mem_info->mem_range.size = 0; |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5066 | if (mem_info->shadow_copy) { |
| 5067 | free(mem_info->shadow_copy_base); |
| 5068 | mem_info->shadow_copy_base = 0; |
| 5069 | mem_info->shadow_copy = 0; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5070 | } |
| 5071 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5072 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5073 | } |
| 5074 | |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5075 | // Guard value for pad data |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5076 | static char NoncoherentMemoryFillValue = 0xb; |
| 5077 | |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5078 | static void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, |
| 5079 | void **ppData) { |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 5080 | auto mem_info = getMemObjInfo(dev_data, mem); |
| 5081 | if (mem_info) { |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5082 | mem_info->p_driver_data = *ppData; |
| 5083 | uint32_t index = mem_info->alloc_info.memoryTypeIndex; |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 5084 | if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5085 | mem_info->shadow_copy = 0; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5086 | } else { |
| 5087 | if (size == VK_WHOLE_SIZE) { |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5088 | size = mem_info->alloc_info.allocationSize - offset; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5089 | } |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5090 | mem_info->shadow_pad_size = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; |
| 5091 | assert(vk_safe_modulo(mem_info->shadow_pad_size, |
| 5092 | dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment) == 0); |
| 5093 | // Ensure start of mapped region reflects hardware alignment constraints |
| 5094 | uint64_t map_alignment = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; |
| 5095 | |
| 5096 | // From spec: (ppData - offset) must be aligned to at least limits::minMemoryMapAlignment. |
| 5097 | uint64_t start_offset = offset % map_alignment; |
| 5098 | // Data passed to driver will be wrapped by a guardband of data to detect over- or under-writes. |
Mark Lobodzinski | 4dc768c | 2016-10-03 16:01:12 -0600 | [diff] [blame] | 5099 | mem_info->shadow_copy_base = malloc(static_cast<size_t>(2 * mem_info->shadow_pad_size + size + map_alignment + start_offset)); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5100 | |
| 5101 | mem_info->shadow_copy = |
| 5102 | reinterpret_cast<char *>((reinterpret_cast<uintptr_t>(mem_info->shadow_copy_base) + map_alignment) & |
| 5103 | ~(map_alignment - 1)) + start_offset; |
| 5104 | assert(vk_safe_modulo(reinterpret_cast<uintptr_t>(mem_info->shadow_copy) + mem_info->shadow_pad_size - start_offset, |
| 5105 | map_alignment) == 0); |
| 5106 | |
Mark Lobodzinski | 4dc768c | 2016-10-03 16:01:12 -0600 | [diff] [blame] | 5107 | memset(mem_info->shadow_copy, NoncoherentMemoryFillValue, static_cast<size_t>(2 * mem_info->shadow_pad_size + size)); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5108 | *ppData = static_cast<char *>(mem_info->shadow_copy) + mem_info->shadow_pad_size; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5109 | } |
| 5110 | } |
| 5111 | } |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5112 | |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 5113 | // Verify that state for fence being waited on is appropriate. That is, |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 5114 | // a fence being waited on should not already be signaled and |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 5115 | // it should have been submitted on a queue or during acquire next image |
Chris Forbes | 5141e92 | 2016-06-15 13:10:28 +1200 | [diff] [blame] | 5116 | static inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5117 | bool skip_call = false; |
Chris Forbes | 53a1736 | 2016-06-15 13:03:31 +1200 | [diff] [blame] | 5118 | |
Chris Forbes | 5141e92 | 2016-06-15 13:10:28 +1200 | [diff] [blame] | 5119 | auto pFence = getFenceNode(dev_data, fence); |
Chris Forbes | 53a1736 | 2016-06-15 13:03:31 +1200 | [diff] [blame] | 5120 | if (pFence) { |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 5121 | if (pFence->state == FENCE_UNSIGNALED) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5122 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| 5123 | reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", |
| 5124 | "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " |
| 5125 | "acquire next image.", |
| 5126 | apiCall, reinterpret_cast<uint64_t &>(fence)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5127 | } |
| 5128 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5129 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5130 | } |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 5131 | |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5132 | static void RetireFence(layer_data *dev_data, VkFence fence) { |
Chris Forbes | 61e8ff5 | 2016-09-21 11:18:30 +1200 | [diff] [blame] | 5133 | auto pFence = getFenceNode(dev_data, fence); |
| 5134 | if (pFence->signaler.first != VK_NULL_HANDLE) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 5135 | // Fence signaller is a queue -- use this as proof that prior operations on that queue have completed. |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 5136 | RetireWorkOnQueue(dev_data, getQueueState(dev_data, pFence->signaler.first), pFence->signaler.second); |
Chris Forbes | 61e8ff5 | 2016-09-21 11:18:30 +1200 | [diff] [blame] | 5137 | } |
Chris Forbes | 2238406 | 2016-09-21 13:36:19 +1200 | [diff] [blame] | 5138 | else { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 5139 | // Fence signaller is the WSI. We're not tracking what the WSI op actually /was/ in CV yet, but we need to mark |
| 5140 | // the fence as retired. |
Chris Forbes | 2238406 | 2016-09-21 13:36:19 +1200 | [diff] [blame] | 5141 | pFence->state = FENCE_RETIRED; |
Chris Forbes | 2238406 | 2016-09-21 13:36:19 +1200 | [diff] [blame] | 5142 | } |
Chris Forbes | 61e8ff5 | 2016-09-21 11:18:30 +1200 | [diff] [blame] | 5143 | } |
| 5144 | |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5145 | static bool PreCallValidateWaitForFences(layer_data *dev_data, uint32_t fence_count, const VkFence *fences) { |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5146 | if (dev_data->instance_data->disabled.wait_for_fences) |
| 5147 | return false; |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5148 | bool skip = false; |
| 5149 | for (uint32_t i = 0; i < fence_count; i++) { |
| 5150 | skip |= verifyWaitFenceState(dev_data, fences[i], "vkWaitForFences"); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5151 | skip |= VerifyQueueStateToFence(dev_data, fences[i]); |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5152 | } |
| 5153 | return skip; |
| 5154 | } |
| 5155 | |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5156 | static void PostCallRecordWaitForFences(layer_data *dev_data, uint32_t fence_count, const VkFence *fences, VkBool32 wait_all) { |
| 5157 | // When we know that all fences are complete we can clean/remove their CBs |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5158 | if ((VK_TRUE == wait_all) || (1 == fence_count)) { |
| 5159 | for (uint32_t i = 0; i < fence_count; i++) { |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5160 | RetireFence(dev_data, fences[i]); |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5161 | } |
| 5162 | } |
| 5163 | // NOTE : Alternate case not handled here is when some fences have completed. In |
| 5164 | // this case for app to guarantee which fences completed it will have to call |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5165 | // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5166 | } |
| 5167 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5168 | VKAPI_ATTR VkResult VKAPI_CALL |
| 5169 | WaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5170 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5171 | // Verify fence status of submitted fences |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5172 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5173 | bool skip = PreCallValidateWaitForFences(dev_data, fenceCount, pFences); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5174 | lock.unlock(); |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5175 | if (skip) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5176 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 5177 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5178 | VkResult result = dev_data->dispatch_table.WaitForFences(device, fenceCount, pFences, waitAll, timeout); |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 5179 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5180 | if (result == VK_SUCCESS) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5181 | lock.lock(); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5182 | PostCallRecordWaitForFences(dev_data, fenceCount, pFences, waitAll); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5183 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5184 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5185 | return result; |
| 5186 | } |
| 5187 | |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5188 | static bool PreCallValidateGetFenceStatus(layer_data *dev_data, VkFence fence) { |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5189 | if (dev_data->instance_data->disabled.get_fence_state) |
| 5190 | return false; |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5191 | return verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); |
| 5192 | } |
| 5193 | |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5194 | static void PostCallRecordGetFenceStatus(layer_data *dev_data, VkFence fence) { RetireFence(dev_data, fence); } |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5195 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5196 | VKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5197 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5198 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5199 | bool skip = PreCallValidateGetFenceStatus(dev_data, fence); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5200 | lock.unlock(); |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5201 | if (skip) |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5202 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 5203 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5204 | VkResult result = dev_data->dispatch_table.GetFenceStatus(device, fence); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5205 | if (result == VK_SUCCESS) { |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5206 | lock.lock(); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5207 | PostCallRecordGetFenceStatus(dev_data, fence); |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5208 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5209 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5210 | return result; |
| 5211 | } |
| 5212 | |
Tobin Ehlis | 75fcac7 | 2016-12-15 11:34:33 -0700 | [diff] [blame] | 5213 | static void PostCallRecordGetDeviceQueue(layer_data *dev_data, uint32_t q_family_index, VkQueue queue) { |
| 5214 | // Add queue to tracking set only if it is new |
| 5215 | auto result = dev_data->queues.emplace(queue); |
| 5216 | if (result.second == true) { |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 5217 | QUEUE_STATE *queue_state = &dev_data->queueMap[queue]; |
Tobin Ehlis | 75fcac7 | 2016-12-15 11:34:33 -0700 | [diff] [blame] | 5218 | queue_state->queue = queue; |
| 5219 | queue_state->queueFamilyIndex = q_family_index; |
| 5220 | queue_state->seq = 0; |
| 5221 | } |
| 5222 | } |
| 5223 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5224 | VKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, |
Mark Lobodzinski | 600e93d | 2016-03-29 09:49:15 -0600 | [diff] [blame] | 5225 | VkQueue *pQueue) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5226 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5227 | dev_data->dispatch_table.GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5228 | std::lock_guard<std::mutex> lock(global_lock); |
Mark Lobodzinski | 600e93d | 2016-03-29 09:49:15 -0600 | [diff] [blame] | 5229 | |
Tobin Ehlis | 75fcac7 | 2016-12-15 11:34:33 -0700 | [diff] [blame] | 5230 | PostCallRecordGetDeviceQueue(dev_data, queueFamilyIndex, *pQueue); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5231 | } |
| 5232 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 5233 | static bool PreCallValidateQueueWaitIdle(layer_data *dev_data, VkQueue queue, QUEUE_STATE **queue_state) { |
| 5234 | *queue_state = getQueueState(dev_data, queue); |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5235 | if (dev_data->instance_data->disabled.queue_wait_idle) |
| 5236 | return false; |
| 5237 | return VerifyQueueStateToSeq(dev_data, *queue_state, (*queue_state)->seq + (*queue_state)->submissions.size()); |
Tobin Ehlis | 4d8e6a4 | 2016-12-06 13:20:09 -0700 | [diff] [blame] | 5238 | } |
| 5239 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 5240 | static void PostCallRecordQueueWaitIdle(layer_data *dev_data, QUEUE_STATE *queue_state) { |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5241 | RetireWorkOnQueue(dev_data, queue_state, queue_state->seq + queue_state->submissions.size()); |
Tobin Ehlis | 4d8e6a4 | 2016-12-06 13:20:09 -0700 | [diff] [blame] | 5242 | } |
| 5243 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5244 | VKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5245 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 5246 | QUEUE_STATE *queue_state = nullptr; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 5247 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4d8e6a4 | 2016-12-06 13:20:09 -0700 | [diff] [blame] | 5248 | bool skip = PreCallValidateQueueWaitIdle(dev_data, queue, &queue_state); |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 5249 | lock.unlock(); |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 5250 | if (skip) |
| 5251 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5252 | VkResult result = dev_data->dispatch_table.QueueWaitIdle(queue); |
Tobin Ehlis | 4d8e6a4 | 2016-12-06 13:20:09 -0700 | [diff] [blame] | 5253 | if (VK_SUCCESS == result) { |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5254 | lock.lock(); |
| 5255 | PostCallRecordQueueWaitIdle(dev_data, queue_state); |
| 5256 | lock.unlock(); |
Tobin Ehlis | 4d8e6a4 | 2016-12-06 13:20:09 -0700 | [diff] [blame] | 5257 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5258 | return result; |
| 5259 | } |
| 5260 | |
Tobin Ehlis | 08aacd9 | 2016-12-06 13:08:18 -0700 | [diff] [blame] | 5261 | static bool PreCallValidateDeviceWaitIdle(layer_data *dev_data) { |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5262 | if (dev_data->instance_data->disabled.device_wait_idle) |
| 5263 | return false; |
Tobin Ehlis | 08aacd9 | 2016-12-06 13:08:18 -0700 | [diff] [blame] | 5264 | bool skip = false; |
| 5265 | for (auto &queue : dev_data->queueMap) { |
| 5266 | skip |= VerifyQueueStateToSeq(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); |
| 5267 | } |
| 5268 | return skip; |
| 5269 | } |
| 5270 | |
| 5271 | static void PostCallRecordDeviceWaitIdle(layer_data *dev_data) { |
| 5272 | for (auto &queue : dev_data->queueMap) { |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5273 | RetireWorkOnQueue(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5274 | } |
Tobin Ehlis | 08aacd9 | 2016-12-06 13:08:18 -0700 | [diff] [blame] | 5275 | } |
| 5276 | |
| 5277 | VKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { |
| 5278 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5279 | std::unique_lock<std::mutex> lock(global_lock); |
| 5280 | bool skip = PreCallValidateDeviceWaitIdle(dev_data); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5281 | lock.unlock(); |
Tobin Ehlis | 08aacd9 | 2016-12-06 13:08:18 -0700 | [diff] [blame] | 5282 | if (skip) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5283 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5284 | VkResult result = dev_data->dispatch_table.DeviceWaitIdle(device); |
Tobin Ehlis | 08aacd9 | 2016-12-06 13:08:18 -0700 | [diff] [blame] | 5285 | if (VK_SUCCESS == result) { |
| 5286 | lock.lock(); |
| 5287 | PostCallRecordDeviceWaitIdle(dev_data); |
| 5288 | lock.unlock(); |
| 5289 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5290 | return result; |
| 5291 | } |
| 5292 | |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5293 | static bool PreCallValidateDestroyFence(layer_data *dev_data, VkFence fence, FENCE_NODE **fence_node, VK_OBJECT *obj_struct) { |
| 5294 | *fence_node = getFenceNode(dev_data, fence); |
| 5295 | *obj_struct = {reinterpret_cast<uint64_t &>(fence), VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT}; |
Tobin Ehlis | 653c522 | 2016-12-15 14:35:21 -0700 | [diff] [blame] | 5296 | if (dev_data->instance_data->disabled.destroy_fence) |
| 5297 | return false; |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5298 | bool skip = false; |
| 5299 | if (*fence_node) { |
| 5300 | if ((*fence_node)->state == FENCE_INFLIGHT) { |
| 5301 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| 5302 | (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", "Fence 0x%" PRIx64 " is in use.", |
| 5303 | (uint64_t)(fence)); |
| 5304 | } |
| 5305 | } |
| 5306 | return skip; |
| 5307 | } |
| 5308 | |
| 5309 | static void PostCallRecordDestroyFence(layer_data *dev_data, VkFence fence) { dev_data->fenceMap.erase(fence); } |
| 5310 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5311 | VKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5312 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5313 | // Common data objects used pre & post call |
| 5314 | FENCE_NODE *fence_node = nullptr; |
| 5315 | VK_OBJECT obj_struct; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5316 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5317 | bool skip = PreCallValidateDestroyFence(dev_data, fence, &fence_node, &obj_struct); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 5318 | |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5319 | if (!skip) { |
| 5320 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5321 | dev_data->dispatch_table.DestroyFence(device, fence, pAllocator); |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5322 | lock.lock(); |
| 5323 | PostCallRecordDestroyFence(dev_data, fence); |
| 5324 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5325 | } |
| 5326 | |
Tobin Ehlis | 6ed8e14 | 2016-12-15 14:32:22 -0700 | [diff] [blame] | 5327 | static bool PreCallValidateDestroySemaphore(layer_data *dev_data, VkSemaphore semaphore, SEMAPHORE_NODE **sema_node, |
| 5328 | VK_OBJECT *obj_struct) { |
| 5329 | *sema_node = getSemaphoreNode(dev_data, semaphore); |
| 5330 | *obj_struct = {reinterpret_cast<uint64_t &>(semaphore), VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT}; |
Tobin Ehlis | fdedd1e | 2016-12-15 14:36:56 -0700 | [diff] [blame] | 5331 | if (dev_data->instance_data->disabled.destroy_semaphore) |
| 5332 | return false; |
Tobin Ehlis | 6ed8e14 | 2016-12-15 14:32:22 -0700 | [diff] [blame] | 5333 | bool skip = false; |
| 5334 | if (*sema_node) { |
| 5335 | skip |= ValidateObjectNotInUse(dev_data, *sema_node, *obj_struct, VALIDATION_ERROR_00199); |
| 5336 | } |
| 5337 | return skip; |
| 5338 | } |
| 5339 | |
| 5340 | static void PostCallRecordDestroySemaphore(layer_data *dev_data, VkSemaphore sema) { dev_data->semaphoreMap.erase(sema); } |
| 5341 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5342 | VKAPI_ATTR void VKAPI_CALL |
| 5343 | DestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5344 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 6ed8e14 | 2016-12-15 14:32:22 -0700 | [diff] [blame] | 5345 | SEMAPHORE_NODE *sema_node; |
| 5346 | VK_OBJECT obj_struct; |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 5347 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 6ed8e14 | 2016-12-15 14:32:22 -0700 | [diff] [blame] | 5348 | bool skip = PreCallValidateDestroySemaphore(dev_data, semaphore, &sema_node, &obj_struct); |
Tobin Ehlis | 7d1dd14 | 2016-08-18 08:23:30 -0600 | [diff] [blame] | 5349 | if (!skip) { |
Tobin Ehlis | 7d1dd14 | 2016-08-18 08:23:30 -0600 | [diff] [blame] | 5350 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5351 | dev_data->dispatch_table.DestroySemaphore(device, semaphore, pAllocator); |
Tobin Ehlis | 6ed8e14 | 2016-12-15 14:32:22 -0700 | [diff] [blame] | 5352 | lock.lock(); |
| 5353 | PostCallRecordDestroySemaphore(dev_data, semaphore); |
Mark Mueller | 0782cea | 2016-08-24 10:42:17 -0600 | [diff] [blame] | 5354 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5355 | } |
| 5356 | |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 5357 | static bool PreCallValidateDestroyEvent(layer_data *dev_data, VkEvent event, EVENT_STATE **event_state, VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 5358 | *event_state = getEventNode(dev_data, event); |
| 5359 | *obj_struct = {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}; |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5360 | if (dev_data->instance_data->disabled.destroy_event) |
| 5361 | return false; |
| 5362 | bool skip = false; |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5363 | if (*event_state) { |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5364 | skip |= ValidateObjectNotInUse(dev_data, *event_state, *obj_struct, VALIDATION_ERROR_00213); |
| 5365 | } |
| 5366 | return skip; |
| 5367 | } |
| 5368 | |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 5369 | static void PostCallRecordDestroyEvent(layer_data *dev_data, VkEvent event, EVENT_STATE *event_state, VK_OBJECT obj_struct) { |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 5370 | invalidateCommandBuffers(dev_data, event_state->cb_bindings, obj_struct); |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5371 | dev_data->eventMap.erase(event); |
| 5372 | } |
| 5373 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5374 | VKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5375 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 5376 | EVENT_STATE *event_state = nullptr; |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5377 | VK_OBJECT obj_struct; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5378 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5379 | bool skip = PreCallValidateDestroyEvent(dev_data, event, &event_state, &obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5380 | if (!skip) { |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5381 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5382 | dev_data->dispatch_table.DestroyEvent(device, event, pAllocator); |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5383 | lock.lock(); |
| 5384 | PostCallRecordDestroyEvent(dev_data, event, event_state, obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5385 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5386 | } |
| 5387 | |
Tobin Ehlis | d8f5535 | 2016-12-16 14:56:41 -0700 | [diff] [blame] | 5388 | static bool PreCallValidateDestroyQueryPool(layer_data *dev_data, VkQueryPool query_pool, QUERY_POOL_NODE **qp_state, |
| 5389 | VK_OBJECT *obj_struct) { |
| 5390 | *qp_state = getQueryPoolNode(dev_data, query_pool); |
| 5391 | *obj_struct = {reinterpret_cast<uint64_t &>(query_pool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}; |
Tobin Ehlis | 4531515 | 2016-12-16 15:02:44 -0700 | [diff] [blame] | 5392 | if (dev_data->instance_data->disabled.destroy_query_pool) |
| 5393 | return false; |
Tobin Ehlis | d8f5535 | 2016-12-16 14:56:41 -0700 | [diff] [blame] | 5394 | bool skip = false; |
| 5395 | if (*qp_state) { |
| 5396 | skip |= ValidateObjectNotInUse(dev_data, *qp_state, *obj_struct, VALIDATION_ERROR_01012); |
| 5397 | } |
| 5398 | return skip; |
| 5399 | } |
| 5400 | |
| 5401 | static void PostCallRecordDestroyQueryPool(layer_data *dev_data, VkQueryPool query_pool, QUERY_POOL_NODE *qp_state, VK_OBJECT obj_struct) { |
| 5402 | invalidateCommandBuffers(dev_data, qp_state->cb_bindings, obj_struct); |
| 5403 | dev_data->queryPoolMap.erase(query_pool); |
| 5404 | } |
| 5405 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5406 | VKAPI_ATTR void VKAPI_CALL |
| 5407 | DestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 5408 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | d8f5535 | 2016-12-16 14:56:41 -0700 | [diff] [blame] | 5409 | QUERY_POOL_NODE *qp_state = nullptr; |
| 5410 | VK_OBJECT obj_struct; |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 5411 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d8f5535 | 2016-12-16 14:56:41 -0700 | [diff] [blame] | 5412 | bool skip = PreCallValidateDestroyQueryPool(dev_data, queryPool, &qp_state, &obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5413 | if (!skip) { |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5414 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5415 | dev_data->dispatch_table.DestroyQueryPool(device, queryPool, pAllocator); |
Tobin Ehlis | d8f5535 | 2016-12-16 14:56:41 -0700 | [diff] [blame] | 5416 | lock.lock(); |
| 5417 | PostCallRecordDestroyQueryPool(dev_data, queryPool, qp_state, obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5418 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5419 | } |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5420 | static bool PreCallValidateGetQueryPoolResults(layer_data *dev_data, VkQueryPool query_pool, uint32_t first_query, |
| 5421 | uint32_t query_count, VkQueryResultFlags flags, |
| 5422 | unordered_map<QueryObject, vector<VkCommandBuffer>> *queries_in_flight) { |
| 5423 | for (auto cmd_buffer : dev_data->globalInFlightCmdBuffers) { |
| 5424 | auto cb = getCBNode(dev_data, cmd_buffer); |
| 5425 | for (auto query_state_pair : cb->queryToStateMap) { |
| 5426 | (*queries_in_flight)[query_state_pair.first].push_back(cmd_buffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5427 | } |
| 5428 | } |
Tobin Ehlis | 4fbe1c2 | 2016-12-19 10:20:43 -0700 | [diff] [blame] | 5429 | if (dev_data->instance_data->disabled.get_query_pool_results) |
| 5430 | return false; |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5431 | bool skip = false; |
| 5432 | for (uint32_t i = 0; i < query_count; ++i) { |
| 5433 | QueryObject query = {query_pool, first_query + i}; |
| 5434 | auto qif_pair = queries_in_flight->find(query); |
| 5435 | auto query_state_pair = dev_data->queryToStateMap.find(query); |
| 5436 | if (query_state_pair != dev_data->queryToStateMap.end()) { |
Mark Lobodzinski | 6a31218 | 2016-04-01 15:58:32 -0600 | [diff] [blame] | 5437 | // Available and in flight |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5438 | if (qif_pair != queries_in_flight->end() && query_state_pair != dev_data->queryToStateMap.end() && |
| 5439 | query_state_pair->second) { |
| 5440 | for (auto cmd_buffer : qif_pair->second) { |
| 5441 | auto cb = getCBNode(dev_data, cmd_buffer); |
| 5442 | auto query_event_pair = cb->waitedEventsBeforeQueryReset.find(query); |
| 5443 | if (query_event_pair == cb->waitedEventsBeforeQueryReset.end()) { |
| 5444 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 5445 | VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| 5446 | "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", |
| 5447 | (uint64_t)(query_pool), first_query + i); |
| 5448 | } |
| 5449 | } |
| 5450 | // Unavailable and in flight |
| 5451 | } else if (qif_pair != queries_in_flight->end() && query_state_pair != dev_data->queryToStateMap.end() && |
| 5452 | !query_state_pair->second) { |
| 5453 | // TODO : Can there be the same query in use by multiple command buffers in flight? |
| 5454 | bool make_available = false; |
| 5455 | for (auto cmd_buffer : qif_pair->second) { |
| 5456 | auto cb = getCBNode(dev_data, cmd_buffer); |
| 5457 | make_available |= cb->queryToStateMap[query]; |
| 5458 | } |
| 5459 | if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { |
| 5460 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 5461 | VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| 5462 | "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", |
| 5463 | (uint64_t)(query_pool), first_query + i); |
| 5464 | } |
| 5465 | // Unavailable |
| 5466 | } else if (query_state_pair != dev_data->queryToStateMap.end() && !query_state_pair->second) { |
| 5467 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, |
| 5468 | __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| 5469 | "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", |
| 5470 | (uint64_t)(query_pool), first_query + i); |
| 5471 | // Uninitialized |
| 5472 | } else if (query_state_pair == dev_data->queryToStateMap.end()) { |
| 5473 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, |
| 5474 | __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| 5475 | "Cannot get query results on queryPool 0x%" PRIx64 |
| 5476 | " with index %d as data has not been collected for this index.", |
| 5477 | (uint64_t)(query_pool), first_query + i); |
| 5478 | } |
| 5479 | } |
| 5480 | } |
| 5481 | return skip; |
| 5482 | } |
| 5483 | |
| 5484 | static void PostCallRecordGetQueryPoolResults(layer_data *dev_data, VkQueryPool query_pool, uint32_t first_query, |
| 5485 | uint32_t query_count, |
| 5486 | unordered_map<QueryObject, vector<VkCommandBuffer>> *queries_in_flight) { |
| 5487 | for (uint32_t i = 0; i < query_count; ++i) { |
| 5488 | QueryObject query = {query_pool, first_query + i}; |
| 5489 | auto qif_pair = queries_in_flight->find(query); |
| 5490 | auto query_state_pair = dev_data->queryToStateMap.find(query); |
| 5491 | if (query_state_pair != dev_data->queryToStateMap.end()) { |
| 5492 | // Available and in flight |
| 5493 | if (qif_pair != queries_in_flight->end() && query_state_pair != dev_data->queryToStateMap.end() && |
| 5494 | query_state_pair->second) { |
| 5495 | for (auto cmd_buffer : qif_pair->second) { |
| 5496 | auto cb = getCBNode(dev_data, cmd_buffer); |
| 5497 | auto query_event_pair = cb->waitedEventsBeforeQueryReset.find(query); |
| 5498 | if (query_event_pair != cb->waitedEventsBeforeQueryReset.end()) { |
| 5499 | for (auto event : query_event_pair->second) { |
Mark Lobodzinski | 6a31218 | 2016-04-01 15:58:32 -0600 | [diff] [blame] | 5500 | dev_data->eventMap[event].needsSignaled = true; |
| 5501 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5502 | } |
| 5503 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5504 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5505 | } |
| 5506 | } |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5507 | } |
| 5508 | |
| 5509 | VKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, |
| 5510 | size_t dataSize, void *pData, VkDeviceSize stride, VkQueryResultFlags flags) { |
| 5511 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5512 | unordered_map<QueryObject, vector<VkCommandBuffer>> queries_in_flight; |
| 5513 | std::unique_lock<std::mutex> lock(global_lock); |
| 5514 | bool skip = PreCallValidateGetQueryPoolResults(dev_data, queryPool, firstQuery, queryCount, flags, &queries_in_flight); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5515 | lock.unlock(); |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5516 | if (skip) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5517 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5518 | VkResult result = |
| 5519 | dev_data->dispatch_table.GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, flags); |
| 5520 | lock.lock(); |
| 5521 | PostCallRecordGetQueryPoolResults(dev_data, queryPool, firstQuery, queryCount, &queries_in_flight); |
| 5522 | lock.unlock(); |
| 5523 | return result; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5524 | } |
| 5525 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 5526 | static bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { |
| 5527 | bool skip_call = false; |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 5528 | auto buffer_state = getBufferState(my_data, buffer); |
| 5529 | if (!buffer_state) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5530 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 5531 | (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 5532 | "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5533 | } else { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 5534 | if (buffer_state->in_use.load()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5535 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5536 | (uint64_t)(buffer), __LINE__, VALIDATION_ERROR_00676, "DS", |
| 5537 | "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer. %s", (uint64_t)(buffer), |
| 5538 | validation_error_map[VALIDATION_ERROR_00676]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5539 | } |
| 5540 | } |
| 5541 | return skip_call; |
| 5542 | } |
| 5543 | |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5544 | // Return true if given ranges intersect, else false |
| 5545 | // Prereq : For both ranges, range->end - range->start > 0. This case should have already resulted |
| 5546 | // in an error so not checking that here |
| 5547 | // pad_ranges bool indicates a linear and non-linear comparison which requires padding |
| 5548 | // In the case where padding is required, if an alias is encountered then a validation error is reported and skip_call |
| 5549 | // may be set by the callback function so caller should merge in skip_call value if padding case is possible. |
Tobin Ehlis | 17b6552 | 2016-08-12 14:26:31 -0600 | [diff] [blame] | 5550 | static bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, MEMORY_RANGE const *range2, bool *skip_call) { |
| 5551 | *skip_call = false; |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5552 | auto r1_start = range1->start; |
| 5553 | auto r1_end = range1->end; |
| 5554 | auto r2_start = range2->start; |
| 5555 | auto r2_end = range2->end; |
| 5556 | VkDeviceSize pad_align = 1; |
| 5557 | if (range1->linear != range2->linear) { |
| 5558 | pad_align = dev_data->phys_dev_properties.properties.limits.bufferImageGranularity; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5559 | } |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5560 | if ((r1_end & ~(pad_align - 1)) < (r2_start & ~(pad_align - 1))) |
| 5561 | return false; |
| 5562 | if ((r1_start & ~(pad_align - 1)) > (r2_end & ~(pad_align - 1))) |
| 5563 | return false; |
| 5564 | |
| 5565 | if (range1->linear != range2->linear) { |
Tobin Ehlis | 951f6ae | 2016-12-13 12:16:58 -0700 | [diff] [blame] | 5566 | // In linear vs. non-linear case, warn of aliasing |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5567 | const char *r1_linear_str = range1->linear ? "Linear" : "Non-linear"; |
| 5568 | const char *r1_type_str = range1->image ? "image" : "buffer"; |
| 5569 | const char *r2_linear_str = range2->linear ? "linear" : "non-linear"; |
| 5570 | const char *r2_type_str = range2->image ? "image" : "buffer"; |
| 5571 | auto obj_type = range1->image ? VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT : VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT; |
Tobin Ehlis | 951f6ae | 2016-12-13 12:16:58 -0700 | [diff] [blame] | 5572 | *skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, obj_type, range1->handle, 0, |
| 5573 | MEMTRACK_INVALID_ALIASING, "MEM", "%s %s 0x%" PRIx64 " is aliased with %s %s 0x%" PRIx64 |
| 5574 | " which may indicate a bug. For further info refer to the " |
| 5575 | "Buffer-Image Granularity section of the Vulkan specification. " |
| 5576 | "(https://www.khronos.org/registry/vulkan/specs/1.0-extensions/" |
| 5577 | "xhtml/vkspec.html#resources-bufferimagegranularity)", |
| 5578 | r1_linear_str, r1_type_str, range1->handle, r2_linear_str, r2_type_str, range2->handle); |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5579 | } |
| 5580 | // Ranges intersect |
| 5581 | return true; |
| 5582 | } |
Tobin Ehlis | 0a78ef9 | 2016-08-12 14:12:44 -0600 | [diff] [blame] | 5583 | // Simplified rangesIntersect that calls above function to check range1 for intersection with offset & end addresses |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 5584 | static bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, VkDeviceSize offset, VkDeviceSize end) { |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5585 | // Create a local MEMORY_RANGE struct to wrap offset/size |
| 5586 | MEMORY_RANGE range_wrap; |
| 5587 | // Synch linear with range1 to avoid padding and potential validation error case |
| 5588 | range_wrap.linear = range1->linear; |
| 5589 | range_wrap.start = offset; |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 5590 | range_wrap.end = end; |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5591 | bool tmp_bool; |
Tobin Ehlis | 17b6552 | 2016-08-12 14:26:31 -0600 | [diff] [blame] | 5592 | return rangesIntersect(dev_data, range1, &range_wrap, &tmp_bool); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5593 | } |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 5594 | // For given mem_info, set all ranges valid that intersect [offset-end] range |
| 5595 | // TODO : For ranges where there is no alias, we may want to create new buffer ranges that are valid |
| 5596 | static void SetMemRangesValid(layer_data const *dev_data, DEVICE_MEM_INFO *mem_info, VkDeviceSize offset, VkDeviceSize end) { |
| 5597 | bool tmp_bool = false; |
Tobin Ehlis | 125fc63 | 2016-12-13 12:39:44 -0700 | [diff] [blame] | 5598 | MEMORY_RANGE map_range = {}; |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 5599 | map_range.linear = true; |
| 5600 | map_range.start = offset; |
| 5601 | map_range.end = end; |
| 5602 | for (auto &handle_range_pair : mem_info->bound_ranges) { |
Tobin Ehlis | 17b6552 | 2016-08-12 14:26:31 -0600 | [diff] [blame] | 5603 | if (rangesIntersect(dev_data, &handle_range_pair.second, &map_range, &tmp_bool)) { |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 5604 | // TODO : WARN here if tmp_bool true? |
| 5605 | handle_range_pair.second.valid = true; |
| 5606 | } |
| 5607 | } |
| 5608 | } |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5609 | // Object with given handle is being bound to memory w/ given mem_info struct. |
| 5610 | // Track the newly bound memory range with given memoryOffset |
| 5611 | // Also scan any previous ranges, track aliased ranges with new range, and flag an error if a linear |
| 5612 | // and non-linear range incorrectly overlap. |
| 5613 | // Return true if an error is flagged and the user callback returns "true", otherwise false |
| 5614 | // is_image indicates an image object, otherwise handle is for a buffer |
| 5615 | // is_linear indicates a buffer or linear image |
| 5616 | static bool InsertMemoryRange(layer_data const *dev_data, uint64_t handle, DEVICE_MEM_INFO *mem_info, VkDeviceSize memoryOffset, |
| 5617 | VkMemoryRequirements memRequirements, bool is_image, bool is_linear) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 5618 | bool skip_call = false; |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5619 | MEMORY_RANGE range; |
Tobin Ehlis | b3593a4 | 2016-03-16 16:00:36 -0600 | [diff] [blame] | 5620 | |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5621 | range.image = is_image; |
| 5622 | range.handle = handle; |
| 5623 | range.linear = is_linear; |
Tobin Ehlis | c3e9c7b | 2016-08-10 17:00:51 -0600 | [diff] [blame] | 5624 | range.valid = mem_info->global_valid; |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5625 | range.memory = mem_info->mem; |
| 5626 | range.start = memoryOffset; |
| 5627 | range.size = memRequirements.size; |
| 5628 | range.end = memoryOffset + memRequirements.size - 1; |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5629 | range.aliases.clear(); |
| 5630 | // Update Memory aliasing |
Tobin Ehlis | 6f3a2d1 | 2016-12-13 12:26:44 -0700 | [diff] [blame] | 5631 | // Save aliased ranges so we can copy into final map entry below. Can't do it in loop b/c we don't yet have final ptr. If we |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5632 | // inserted into map before loop to get the final ptr, then we may enter loop when not needed & we check range against itself |
| 5633 | std::unordered_set<MEMORY_RANGE *> tmp_alias_ranges; |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5634 | for (auto &obj_range_pair : mem_info->bound_ranges) { |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5635 | auto check_range = &obj_range_pair.second; |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5636 | bool intersection_error = false; |
Tobin Ehlis | 17b6552 | 2016-08-12 14:26:31 -0600 | [diff] [blame] | 5637 | if (rangesIntersect(dev_data, &range, check_range, &intersection_error)) { |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5638 | skip_call |= intersection_error; |
| 5639 | range.aliases.insert(check_range); |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5640 | tmp_alias_ranges.insert(check_range); |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5641 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5642 | } |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5643 | mem_info->bound_ranges[handle] = std::move(range); |
| 5644 | for (auto tmp_range : tmp_alias_ranges) { |
| 5645 | tmp_range->aliases.insert(&mem_info->bound_ranges[handle]); |
| 5646 | } |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5647 | if (is_image) |
| 5648 | mem_info->bound_images.insert(handle); |
| 5649 | else |
| 5650 | mem_info->bound_buffers.insert(handle); |
| 5651 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5652 | return skip_call; |
| 5653 | } |
| 5654 | |
Tobin Ehlis | e20d21f | 2016-08-10 18:01:27 -0600 | [diff] [blame] | 5655 | static bool InsertImageMemoryRange(layer_data const *dev_data, VkImage image, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5656 | VkMemoryRequirements mem_reqs, bool is_linear) { |
Tobin Ehlis | e20d21f | 2016-08-10 18:01:27 -0600 | [diff] [blame] | 5657 | return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(image), mem_info, mem_offset, mem_reqs, true, is_linear); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5658 | } |
| 5659 | |
Tobin Ehlis | e20d21f | 2016-08-10 18:01:27 -0600 | [diff] [blame] | 5660 | static bool InsertBufferMemoryRange(layer_data const *dev_data, VkBuffer buffer, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5661 | VkMemoryRequirements mem_reqs) { |
Tobin Ehlis | e20d21f | 2016-08-10 18:01:27 -0600 | [diff] [blame] | 5662 | return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(buffer), mem_info, mem_offset, mem_reqs, false, true); |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5663 | } |
| 5664 | |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5665 | // Remove MEMORY_RANGE struct for give handle from bound_ranges of mem_info |
| 5666 | // is_image indicates if handle is for image or buffer |
| 5667 | // This function will also remove the handle-to-index mapping from the appropriate |
| 5668 | // map and clean up any aliases for range being removed. |
| 5669 | static void RemoveMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info, bool is_image) { |
| 5670 | auto erase_range = &mem_info->bound_ranges[handle]; |
| 5671 | for (auto alias_range : erase_range->aliases) { |
| 5672 | alias_range->aliases.erase(erase_range); |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5673 | } |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5674 | erase_range->aliases.clear(); |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5675 | mem_info->bound_ranges.erase(handle); |
Tobin Ehlis | fed999f | 2016-09-21 15:09:45 -0600 | [diff] [blame] | 5676 | if (is_image) { |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5677 | mem_info->bound_images.erase(handle); |
Tobin Ehlis | fed999f | 2016-09-21 15:09:45 -0600 | [diff] [blame] | 5678 | } else { |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5679 | mem_info->bound_buffers.erase(handle); |
Tobin Ehlis | fed999f | 2016-09-21 15:09:45 -0600 | [diff] [blame] | 5680 | } |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5681 | } |
| 5682 | |
| 5683 | static void RemoveBufferMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, false); } |
| 5684 | |
| 5685 | static void RemoveImageMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, true); } |
| 5686 | |
Tobin Ehlis | 4f94a0c | 2016-12-19 10:53:58 -0700 | [diff] [blame] | 5687 | static bool PreCallValidateDestroyBuffer(layer_data *dev_data, VkBuffer buffer, BUFFER_STATE **buffer_state, |
| 5688 | VK_OBJECT *obj_struct) { |
| 5689 | *buffer_state = getBufferState(dev_data, buffer); |
| 5690 | *obj_struct = {reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}; |
Tobin Ehlis | 98a94f1 | 2016-12-19 10:57:29 -0700 | [diff] [blame] | 5691 | if (dev_data->instance_data->disabled.destroy_buffer) |
| 5692 | return false; |
Tobin Ehlis | 4f94a0c | 2016-12-19 10:53:58 -0700 | [diff] [blame] | 5693 | bool skip = false; |
| 5694 | if (*buffer_state) { |
| 5695 | skip |= validateIdleBuffer(dev_data, buffer); |
| 5696 | } |
| 5697 | return skip; |
| 5698 | } |
| 5699 | |
| 5700 | static void PostCallRecordDestroyBuffer(layer_data *dev_data, VkBuffer buffer, BUFFER_STATE *buffer_state, VK_OBJECT obj_struct) { |
| 5701 | invalidateCommandBuffers(dev_data, buffer_state->cb_bindings, obj_struct); |
| 5702 | for (auto mem_binding : buffer_state->GetBoundMemory()) { |
| 5703 | auto mem_info = getMemObjInfo(dev_data, mem_binding); |
| 5704 | if (mem_info) { |
| 5705 | RemoveBufferMemoryRange(reinterpret_cast<uint64_t &>(buffer), mem_info); |
| 5706 | } |
| 5707 | } |
| 5708 | ClearMemoryObjectBindings(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); |
| 5709 | dev_data->bufferMap.erase(buffer_state->buffer); |
| 5710 | } |
| 5711 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5712 | VKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, |
| 5713 | const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5714 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 4f94a0c | 2016-12-19 10:53:58 -0700 | [diff] [blame] | 5715 | BUFFER_STATE *buffer_state = nullptr; |
| 5716 | VK_OBJECT obj_struct; |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5717 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4f94a0c | 2016-12-19 10:53:58 -0700 | [diff] [blame] | 5718 | bool skip = PreCallValidateDestroyBuffer(dev_data, buffer, &buffer_state, &obj_struct); |
| 5719 | if (!skip) { |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5720 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5721 | dev_data->dispatch_table.DestroyBuffer(device, buffer, pAllocator); |
Tobin Ehlis | 4f94a0c | 2016-12-19 10:53:58 -0700 | [diff] [blame] | 5722 | lock.lock(); |
| 5723 | PostCallRecordDestroyBuffer(dev_data, buffer, buffer_state, obj_struct); |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5724 | } |
| 5725 | } |
| 5726 | |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5727 | static bool PreCallValidateDestroyBufferView(layer_data *dev_data, VkBufferView buffer_view, BUFFER_VIEW_STATE **buffer_view_state, |
| 5728 | VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 5729 | *buffer_view_state = getBufferViewState(dev_data, buffer_view); |
| 5730 | *obj_struct = {reinterpret_cast<uint64_t &>(buffer_view), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 5731 | if (dev_data->instance_data->disabled.destroy_buffer_view) |
Tobin Ehlis | b1c2e76 | 2016-09-28 14:25:44 -0600 | [diff] [blame] | 5732 | return false; |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5733 | bool skip = false; |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5734 | if (*buffer_view_state) { |
Tobin Ehlis | 4a98a71 | 2016-10-12 09:58:35 -0600 | [diff] [blame] | 5735 | skip |= ValidateObjectNotInUse(dev_data, *buffer_view_state, *obj_struct, VALIDATION_ERROR_00701); |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5736 | } |
| 5737 | return skip; |
| 5738 | } |
| 5739 | |
| 5740 | static void PostCallRecordDestroyBufferView(layer_data *dev_data, VkBufferView buffer_view, BUFFER_VIEW_STATE *buffer_view_state, |
| 5741 | VK_OBJECT obj_struct) { |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5742 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 5743 | invalidateCommandBuffers(dev_data, buffer_view_state->cb_bindings, obj_struct); |
Tobin Ehlis | 7fa33f4 | 2016-10-05 21:50:14 -0600 | [diff] [blame] | 5744 | dev_data->bufferViewMap.erase(buffer_view); |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5745 | } |
| 5746 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5747 | VKAPI_ATTR void VKAPI_CALL |
| 5748 | DestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5749 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5750 | // Common data objects used pre & post call |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5751 | BUFFER_VIEW_STATE *buffer_view_state = nullptr; |
| 5752 | VK_OBJECT obj_struct; |
Tobin Ehlis | d4aef97 | 2016-10-12 08:53:27 -0600 | [diff] [blame] | 5753 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5754 | // Validate state before calling down chain, update common data if we'll be calling down chain |
| 5755 | bool skip = PreCallValidateDestroyBufferView(dev_data, bufferView, &buffer_view_state, &obj_struct); |
Tobin Ehlis | d79532b | 2016-09-26 17:38:00 -0600 | [diff] [blame] | 5756 | if (!skip) { |
Tobin Ehlis | d79532b | 2016-09-26 17:38:00 -0600 | [diff] [blame] | 5757 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5758 | dev_data->dispatch_table.DestroyBufferView(device, bufferView, pAllocator); |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5759 | lock.lock(); |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5760 | PostCallRecordDestroyBufferView(dev_data, bufferView, buffer_view_state, obj_struct); |
Tobin Ehlis | d79532b | 2016-09-26 17:38:00 -0600 | [diff] [blame] | 5761 | } |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5762 | } |
| 5763 | |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 5764 | static bool PreCallValidateDestroyImage(layer_data *dev_data, VkImage image, IMAGE_STATE **image_state, VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 5765 | *image_state = getImageState(dev_data, image); |
| 5766 | *obj_struct = {reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 5767 | if (dev_data->instance_data->disabled.destroy_image) |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5768 | return false; |
| 5769 | bool skip = false; |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5770 | if (*image_state) { |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5771 | skip |= ValidateObjectNotInUse(dev_data, *image_state, *obj_struct, VALIDATION_ERROR_00743); |
| 5772 | } |
| 5773 | return skip; |
| 5774 | } |
| 5775 | |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 5776 | static void PostCallRecordDestroyImage(layer_data *dev_data, VkImage image, IMAGE_STATE *image_state, VK_OBJECT obj_struct) { |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 5777 | invalidateCommandBuffers(dev_data, image_state->cb_bindings, obj_struct); |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5778 | // Clean up memory mapping, bindings and range references for image |
Tobin Ehlis | 640a81c | 2016-11-15 15:37:18 -0700 | [diff] [blame] | 5779 | for (auto mem_binding : image_state->GetBoundMemory()) { |
| 5780 | auto mem_info = getMemObjInfo(dev_data, mem_binding); |
| 5781 | if (mem_info) { |
| 5782 | RemoveImageMemoryRange(obj_struct.handle, mem_info); |
| 5783 | } |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5784 | } |
Tobin Ehlis | 2fca09c | 2016-10-11 18:46:21 -0600 | [diff] [blame] | 5785 | ClearMemoryObjectBindings(dev_data, obj_struct.handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5786 | // Remove image from imageMap |
| 5787 | dev_data->imageMap.erase(image); |
| 5788 | |
| 5789 | const auto &sub_entry = dev_data->imageSubresourceMap.find(image); |
| 5790 | if (sub_entry != dev_data->imageSubresourceMap.end()) { |
| 5791 | for (const auto &pair : sub_entry->second) { |
| 5792 | dev_data->imageLayoutMap.erase(pair); |
| 5793 | } |
| 5794 | dev_data->imageSubresourceMap.erase(sub_entry); |
| 5795 | } |
| 5796 | } |
| 5797 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5798 | VKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5799 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 5800 | IMAGE_STATE *image_state = nullptr; |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5801 | VK_OBJECT obj_struct; |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 5802 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5803 | bool skip = PreCallValidateDestroyImage(dev_data, image, &image_state, &obj_struct); |
Tobin Ehlis | 6fcd6e4 | 2016-09-21 14:28:42 -0600 | [diff] [blame] | 5804 | if (!skip) { |
Tobin Ehlis | 6fcd6e4 | 2016-09-21 14:28:42 -0600 | [diff] [blame] | 5805 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5806 | dev_data->dispatch_table.DestroyImage(device, image, pAllocator); |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5807 | lock.lock(); |
| 5808 | PostCallRecordDestroyImage(dev_data, image, image_state, obj_struct); |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5809 | } |
| 5810 | } |
| 5811 | |
Mark Lobodzinski | b5563d3 | 2016-06-14 12:11:29 -0600 | [diff] [blame] | 5812 | static bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5813 | const char *funcName, UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Mark Lobodzinski | b5563d3 | 2016-06-14 12:11:29 -0600 | [diff] [blame] | 5814 | bool skip_call = false; |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5815 | if (((1 << mem_info->alloc_info.memoryTypeIndex) & memory_type_bits) == 0) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5816 | skip_call = |
| 5817 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 5818 | reinterpret_cast<const uint64_t &>(mem_info->mem), __LINE__, msgCode, "MT", |
| 5819 | "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " |
| 5820 | "type (0x%X) of this memory object 0x%" PRIx64 ". %s", |
| 5821 | funcName, memory_type_bits, mem_info->alloc_info.memoryTypeIndex, |
| 5822 | reinterpret_cast<const uint64_t &>(mem_info->mem), validation_error_map[msgCode]); |
Mark Lobodzinski | b5563d3 | 2016-06-14 12:11:29 -0600 | [diff] [blame] | 5823 | } |
| 5824 | return skip_call; |
| 5825 | } |
| 5826 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5827 | VKAPI_ATTR VkResult VKAPI_CALL |
| 5828 | BindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { |
Tobin Ehlis | b3593a4 | 2016-03-16 16:00:36 -0600 | [diff] [blame] | 5829 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5830 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5831 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5832 | // Track objects tied to memory |
Tobin Ehlis | e20d21f | 2016-08-10 18:01:27 -0600 | [diff] [blame] | 5833 | uint64_t buffer_handle = reinterpret_cast<uint64_t &>(buffer); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 5834 | bool skip_call = SetMemBinding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 5835 | auto buffer_state = getBufferState(dev_data, buffer); |
| 5836 | if (buffer_state) { |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5837 | if (!buffer_state->memory_requirements_checked) { |
| 5838 | // There's not an explicit requirement in the spec to call vkGetBufferMemoryRequirements() prior to calling |
| 5839 | // BindBufferMemory but it's implied in that memory being bound must conform with VkMemoryRequirements from |
| 5840 | // vkGetBufferMemoryRequirements() |
| 5841 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 5842 | buffer_handle, __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", |
| 5843 | "vkBindBufferMemory(): Binding memory to buffer 0x%" PRIxLEAST64 |
| 5844 | " but vkGetBufferMemoryRequirements() has not been called on that buffer.", |
| 5845 | buffer_handle); |
| 5846 | // Make the call for them so we can verify the state |
| 5847 | lock.unlock(); |
| 5848 | dev_data->dispatch_table.GetBufferMemoryRequirements(device, buffer, &buffer_state->requirements); |
| 5849 | lock.lock(); |
| 5850 | } |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 5851 | buffer_state->binding.mem = mem; |
| 5852 | buffer_state->binding.offset = memoryOffset; |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5853 | buffer_state->binding.size = buffer_state->requirements.size; |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5854 | |
| 5855 | // Track and validate bound memory range information |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 5856 | auto mem_info = getMemObjInfo(dev_data, mem); |
| 5857 | if (mem_info) { |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5858 | skip_call |= InsertBufferMemoryRange(dev_data, buffer, mem_info, memoryOffset, buffer_state->requirements); |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5859 | skip_call |= ValidateMemoryTypes(dev_data, mem_info, buffer_state->requirements.memoryTypeBits, "vkBindBufferMemory()", |
| 5860 | VALIDATION_ERROR_00797); |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5861 | } |
| 5862 | |
Dustin Graves | a97c394 | 2016-03-31 18:01:37 -0600 | [diff] [blame] | 5863 | // Validate memory requirements alignment |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5864 | if (vk_safe_modulo(memoryOffset, buffer_state->requirements.alignment) != 0) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5865 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 5866 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, VALIDATION_ERROR_02174, "DS", |
| 5867 | "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " |
| 5868 | "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 |
| 5869 | ", returned from a call to vkGetBufferMemoryRequirements with buffer. %s", |
| 5870 | memoryOffset, buffer_state->requirements.alignment, validation_error_map[VALIDATION_ERROR_02174]); |
Dustin Graves | a97c394 | 2016-03-31 18:01:37 -0600 | [diff] [blame] | 5871 | } |
Mark Mueller | ec0bafe | 2016-07-07 11:57:59 -0600 | [diff] [blame] | 5872 | |
Dustin Graves | a97c394 | 2016-03-31 18:01:37 -0600 | [diff] [blame] | 5873 | // Validate device limits alignments |
Mark Mueller | ec0bafe | 2016-07-07 11:57:59 -0600 | [diff] [blame] | 5874 | static const VkBufferUsageFlagBits usage_list[3] = { |
| 5875 | static_cast<VkBufferUsageFlagBits>(VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT), |
| 5876 | VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, |
| 5877 | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT}; |
| 5878 | static const char *memory_type[3] = {"texel", |
| 5879 | "uniform", |
| 5880 | "storage"}; |
| 5881 | static const char *offset_name[3] = { |
| 5882 | "minTexelBufferOffsetAlignment", |
| 5883 | "minUniformBufferOffsetAlignment", |
| 5884 | "minStorageBufferOffsetAlignment" |
| 5885 | }; |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5886 | static const UNIQUE_VALIDATION_ERROR_CODE msgCode[3] = { |
| 5887 | VALIDATION_ERROR_00794, |
| 5888 | VALIDATION_ERROR_00795, |
| 5889 | VALIDATION_ERROR_00796 |
| 5890 | }; |
Mark Mueller | ec0bafe | 2016-07-07 11:57:59 -0600 | [diff] [blame] | 5891 | |
| 5892 | // Keep this one fresh! |
| 5893 | const VkDeviceSize offset_requirement[3] = { |
| 5894 | dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment, |
| 5895 | dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, |
| 5896 | dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment |
| 5897 | }; |
Tobin Ehlis | 94bc5d2 | 2016-06-02 07:46:52 -0600 | [diff] [blame] | 5898 | VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; |
Mark Mueller | ec0bafe | 2016-07-07 11:57:59 -0600 | [diff] [blame] | 5899 | |
| 5900 | for (int i = 0; i < 3; i++) { |
| 5901 | if (usage & usage_list[i]) { |
| 5902 | if (vk_safe_modulo(memoryOffset, offset_requirement[i]) != 0) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5903 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 5904 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, msgCode[i], "DS", |
| 5905 | "vkBindBufferMemory(): %s memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " |
| 5906 | "device limit %s 0x%" PRIxLEAST64 ". %s", |
| 5907 | memory_type[i], memoryOffset, offset_name[i], offset_requirement[i], |
| 5908 | validation_error_map[msgCode[i]]); |
Mark Mueller | ec0bafe | 2016-07-07 11:57:59 -0600 | [diff] [blame] | 5909 | } |
Dustin Graves | a97c394 | 2016-03-31 18:01:37 -0600 | [diff] [blame] | 5910 | } |
| 5911 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5912 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5913 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5914 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5915 | result = dev_data->dispatch_table.BindBufferMemory(device, buffer, mem, memoryOffset); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5916 | } |
| 5917 | return result; |
| 5918 | } |
| 5919 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5920 | VKAPI_ATTR void VKAPI_CALL |
| 5921 | GetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { |
Tobin Ehlis | 530bb0a | 2016-11-16 08:57:22 -0700 | [diff] [blame] | 5922 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5923 | dev_data->dispatch_table.GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 5924 | auto buffer_state = getBufferState(dev_data, buffer); |
Tobin Ehlis | 530bb0a | 2016-11-16 08:57:22 -0700 | [diff] [blame] | 5925 | if (buffer_state) { |
| 5926 | buffer_state->requirements = *pMemoryRequirements; |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5927 | buffer_state->memory_requirements_checked = true; |
Tobin Ehlis | 530bb0a | 2016-11-16 08:57:22 -0700 | [diff] [blame] | 5928 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5929 | } |
| 5930 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5931 | VKAPI_ATTR void VKAPI_CALL |
| 5932 | GetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { |
Tobin Ehlis | 530bb0a | 2016-11-16 08:57:22 -0700 | [diff] [blame] | 5933 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5934 | dev_data->dispatch_table.GetImageMemoryRequirements(device, image, pMemoryRequirements); |
| 5935 | auto image_state = getImageState(dev_data, image); |
| 5936 | if (image_state) { |
| 5937 | image_state->requirements = *pMemoryRequirements; |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5938 | image_state->memory_requirements_checked = true; |
Tobin Ehlis | 530bb0a | 2016-11-16 08:57:22 -0700 | [diff] [blame] | 5939 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5940 | } |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 5941 | |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5942 | static bool PreCallValidateDestroyImageView(layer_data *dev_data, VkImageView image_view, IMAGE_VIEW_STATE **image_view_state, |
| 5943 | VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 5944 | *image_view_state = getImageViewState(dev_data, image_view); |
| 5945 | *obj_struct = {reinterpret_cast<uint64_t &>(image_view), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 5946 | if (dev_data->instance_data->disabled.destroy_image_view) |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5947 | return false; |
| 5948 | bool skip = false; |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5949 | if (*image_view_state) { |
Tobin Ehlis | 4a98a71 | 2016-10-12 09:58:35 -0600 | [diff] [blame] | 5950 | skip |= ValidateObjectNotInUse(dev_data, *image_view_state, *obj_struct, VALIDATION_ERROR_00776); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5951 | } |
| 5952 | return skip; |
| 5953 | } |
| 5954 | |
| 5955 | static void PostCallRecordDestroyImageView(layer_data *dev_data, VkImageView image_view, IMAGE_VIEW_STATE *image_view_state, |
| 5956 | VK_OBJECT obj_struct) { |
| 5957 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 5958 | invalidateCommandBuffers(dev_data, image_view_state->cb_bindings, obj_struct); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5959 | dev_data->imageViewMap.erase(image_view); |
| 5960 | } |
| 5961 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5962 | VKAPI_ATTR void VKAPI_CALL |
| 5963 | DestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | dd9830a | 2016-09-19 13:10:37 -0600 | [diff] [blame] | 5964 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5965 | // Common data objects used pre & post call |
| 5966 | IMAGE_VIEW_STATE *image_view_state = nullptr; |
| 5967 | VK_OBJECT obj_struct; |
Tobin Ehlis | d4aef97 | 2016-10-12 08:53:27 -0600 | [diff] [blame] | 5968 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5969 | bool skip = PreCallValidateDestroyImageView(dev_data, imageView, &image_view_state, &obj_struct); |
Tobin Ehlis | dd9830a | 2016-09-19 13:10:37 -0600 | [diff] [blame] | 5970 | if (!skip) { |
Tobin Ehlis | dd9830a | 2016-09-19 13:10:37 -0600 | [diff] [blame] | 5971 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5972 | dev_data->dispatch_table.DestroyImageView(device, imageView, pAllocator); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5973 | lock.lock(); |
| 5974 | PostCallRecordDestroyImageView(dev_data, imageView, image_view_state, obj_struct); |
Tobin Ehlis | dd9830a | 2016-09-19 13:10:37 -0600 | [diff] [blame] | 5975 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5976 | } |
| 5977 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5978 | VKAPI_ATTR void VKAPI_CALL |
| 5979 | DestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { |
Chris Forbes | 90da2e9 | 2016-03-18 16:30:03 +1300 | [diff] [blame] | 5980 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5981 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5982 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | 90da2e9 | 2016-03-18 16:30:03 +1300 | [diff] [blame] | 5983 | my_data->shaderModuleMap.erase(shaderModule); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5984 | lock.unlock(); |
Chris Forbes | 90da2e9 | 2016-03-18 16:30:03 +1300 | [diff] [blame] | 5985 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5986 | my_data->dispatch_table.DestroyShaderModule(device, shaderModule, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5987 | } |
| 5988 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 5989 | static bool PreCallValidateDestroyPipeline(layer_data *dev_data, VkPipeline pipeline, PIPELINE_STATE **pipeline_state, |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 5990 | VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 5991 | *pipeline_state = getPipelineState(dev_data, pipeline); |
| 5992 | *obj_struct = {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 5993 | if (dev_data->instance_data->disabled.destroy_pipeline) |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 5994 | return false; |
| 5995 | bool skip = false; |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 5996 | if (*pipeline_state) { |
Tobin Ehlis | 4a98a71 | 2016-10-12 09:58:35 -0600 | [diff] [blame] | 5997 | skip |= ValidateObjectNotInUse(dev_data, *pipeline_state, *obj_struct, VALIDATION_ERROR_00555); |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 5998 | } |
| 5999 | return skip; |
| 6000 | } |
| 6001 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6002 | static void PostCallRecordDestroyPipeline(layer_data *dev_data, VkPipeline pipeline, PIPELINE_STATE *pipeline_state, |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6003 | VK_OBJECT obj_struct) { |
| 6004 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6005 | invalidateCommandBuffers(dev_data, pipeline_state->cb_bindings, obj_struct); |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6006 | dev_data->pipelineMap.erase(pipeline); |
| 6007 | } |
| 6008 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6009 | VKAPI_ATTR void VKAPI_CALL |
| 6010 | DestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | aa0bc16 | 2016-07-08 15:42:38 -0600 | [diff] [blame] | 6011 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6012 | PIPELINE_STATE *pipeline_state = nullptr; |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6013 | VK_OBJECT obj_struct; |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 6014 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6015 | bool skip = PreCallValidateDestroyPipeline(dev_data, pipeline, &pipeline_state, &obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6016 | if (!skip) { |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6017 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6018 | dev_data->dispatch_table.DestroyPipeline(device, pipeline, pAllocator); |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6019 | lock.lock(); |
| 6020 | PostCallRecordDestroyPipeline(dev_data, pipeline, pipeline_state, obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6021 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6022 | } |
| 6023 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6024 | VKAPI_ATTR void VKAPI_CALL |
| 6025 | DestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | 7e5b375 | 2016-07-07 12:04:20 -0600 | [diff] [blame] | 6026 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 3b4926e | 2016-07-07 13:40:29 -0600 | [diff] [blame] | 6027 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 7e5b375 | 2016-07-07 12:04:20 -0600 | [diff] [blame] | 6028 | dev_data->pipelineLayoutMap.erase(pipelineLayout); |
Tobin Ehlis | 3b4926e | 2016-07-07 13:40:29 -0600 | [diff] [blame] | 6029 | lock.unlock(); |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 6030 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6031 | dev_data->dispatch_table.DestroyPipelineLayout(device, pipelineLayout, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6032 | } |
| 6033 | |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 6034 | static bool PreCallValidateDestroySampler(layer_data *dev_data, VkSampler sampler, SAMPLER_STATE **sampler_state, |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6035 | VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6036 | *sampler_state = getSamplerState(dev_data, sampler); |
| 6037 | *obj_struct = {reinterpret_cast<uint64_t &>(sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}; |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6038 | if (dev_data->instance_data->disabled.destroy_sampler) |
| 6039 | return false; |
| 6040 | bool skip = false; |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6041 | if (*sampler_state) { |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6042 | skip |= ValidateObjectNotInUse(dev_data, *sampler_state, *obj_struct, VALIDATION_ERROR_00837); |
| 6043 | } |
| 6044 | return skip; |
| 6045 | } |
| 6046 | |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 6047 | static void PostCallRecordDestroySampler(layer_data *dev_data, VkSampler sampler, SAMPLER_STATE *sampler_state, |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6048 | VK_OBJECT obj_struct) { |
| 6049 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6050 | if (sampler_state) |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6051 | invalidateCommandBuffers(dev_data, sampler_state->cb_bindings, obj_struct); |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6052 | dev_data->samplerMap.erase(sampler); |
| 6053 | } |
| 6054 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6055 | VKAPI_ATTR void VKAPI_CALL |
| 6056 | DestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 6057 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 6058 | SAMPLER_STATE *sampler_state = nullptr; |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6059 | VK_OBJECT obj_struct; |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 6060 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6061 | bool skip = PreCallValidateDestroySampler(dev_data, sampler, &sampler_state, &obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6062 | if (!skip) { |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6063 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6064 | dev_data->dispatch_table.DestroySampler(device, sampler, pAllocator); |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6065 | lock.lock(); |
| 6066 | PostCallRecordDestroySampler(dev_data, sampler, sampler_state, obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6067 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6068 | } |
| 6069 | |
Tobin Ehlis | 2c140ae | 2016-12-19 11:16:14 -0700 | [diff] [blame] | 6070 | static void PostCallRecordDestroyDescriptorSetLayout(layer_data *dev_data, VkDescriptorSetLayout ds_layout) { |
| 6071 | dev_data->descriptorSetLayoutMap.erase(ds_layout); |
| 6072 | } |
| 6073 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6074 | VKAPI_ATTR void VKAPI_CALL |
| 6075 | DestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | 2c140ae | 2016-12-19 11:16:14 -0700 | [diff] [blame] | 6076 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6077 | dev_data->dispatch_table.DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); |
| 6078 | std::unique_lock<std::mutex> lock(global_lock); |
| 6079 | PostCallRecordDestroyDescriptorSetLayout(dev_data, descriptorSetLayout); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6080 | } |
| 6081 | |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6082 | static bool PreCallValidateDestroyDescriptorPool(layer_data *dev_data, VkDescriptorPool pool, |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 6083 | DESCRIPTOR_POOL_STATE **desc_pool_state, VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6084 | *desc_pool_state = getDescriptorPoolState(dev_data, pool); |
| 6085 | *obj_struct = {reinterpret_cast<uint64_t &>(pool), VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 6086 | if (dev_data->instance_data->disabled.destroy_descriptor_pool) |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6087 | return false; |
| 6088 | bool skip = false; |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6089 | if (*desc_pool_state) { |
Tobin Ehlis | 4a98a71 | 2016-10-12 09:58:35 -0600 | [diff] [blame] | 6090 | skip |= ValidateObjectNotInUse(dev_data, *desc_pool_state, *obj_struct, VALIDATION_ERROR_00901); |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6091 | } |
| 6092 | return skip; |
| 6093 | } |
| 6094 | |
| 6095 | static void PostCallRecordDestroyDescriptorPool(layer_data *dev_data, VkDescriptorPool descriptorPool, |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 6096 | DESCRIPTOR_POOL_STATE *desc_pool_state, VK_OBJECT obj_struct) { |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6097 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6098 | invalidateCommandBuffers(dev_data, desc_pool_state->cb_bindings, obj_struct); |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6099 | // Free sets that were in this pool |
| 6100 | for (auto ds : desc_pool_state->sets) { |
| 6101 | freeDescriptorSet(dev_data, ds); |
| 6102 | } |
| 6103 | dev_data->descriptorPoolMap.erase(descriptorPool); |
| 6104 | } |
| 6105 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6106 | VKAPI_ATTR void VKAPI_CALL |
| 6107 | DestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6108 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 6109 | DESCRIPTOR_POOL_STATE *desc_pool_state = nullptr; |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6110 | VK_OBJECT obj_struct; |
| 6111 | std::unique_lock<std::mutex> lock(global_lock); |
| 6112 | bool skip = PreCallValidateDestroyDescriptorPool(dev_data, descriptorPool, &desc_pool_state, &obj_struct); |
| 6113 | if (!skip) { |
| 6114 | lock.unlock(); |
| 6115 | dev_data->dispatch_table.DestroyDescriptorPool(device, descriptorPool, pAllocator); |
| 6116 | lock.lock(); |
| 6117 | PostCallRecordDestroyDescriptorPool(dev_data, descriptorPool, desc_pool_state, obj_struct); |
| 6118 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6119 | } |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6120 | // Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result |
| 6121 | // If this is a secondary command buffer, then make sure its primary is also in-flight |
| 6122 | // If primary is not in-flight, then remove secondary from global in-flight set |
| 6123 | // This function is only valid at a point when cmdBuffer is being reset or freed |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6124 | static bool checkCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action, |
| 6125 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6126 | bool skip_call = false; |
| 6127 | if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { |
| 6128 | // Primary CB or secondary where primary is also in-flight is an error |
| 6129 | if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || |
| 6130 | (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6131 | skip_call |= |
| 6132 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 6133 | reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, error_code, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 6134 | "Attempt to %s command buffer (0x%p) which is in use. %s", action, cb_node->commandBuffer, |
| 6135 | validation_error_map[error_code]); |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6136 | } |
| 6137 | } |
| 6138 | return skip_call; |
| 6139 | } |
Chris Forbes | e30fb98 | 2016-06-21 12:35:16 +1200 | [diff] [blame] | 6140 | |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6141 | // Iterate over all cmdBuffers in given commandPool and verify that each is not in use |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6142 | static bool checkCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool, const char *action, |
| 6143 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6144 | bool skip_call = false; |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6145 | for (auto cmd_buffer : pPool->commandBuffers) { |
| 6146 | if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6147 | skip_call |= checkCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action, error_code); |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6148 | } |
| 6149 | } |
| 6150 | return skip_call; |
| 6151 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6152 | |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6153 | static void clearCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool) { |
| 6154 | for (auto cmd_buffer : pPool->commandBuffers) { |
| 6155 | dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); |
Chris Forbes | e30fb98 | 2016-06-21 12:35:16 +1200 | [diff] [blame] | 6156 | } |
| 6157 | } |
| 6158 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6159 | VKAPI_ATTR void VKAPI_CALL |
| 6160 | FreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6161 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6162 | bool skip_call = false; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6163 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6164 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6165 | for (uint32_t i = 0; i < commandBufferCount; i++) { |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6166 | auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6167 | // Delete CB information structure, and remove from commandBufferMap |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6168 | if (cb_node) { |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6169 | skip_call |= checkCommandBufferInFlight(dev_data, cb_node, "free", VALIDATION_ERROR_00096); |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6170 | } |
| 6171 | } |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6172 | |
| 6173 | if (skip_call) |
| 6174 | return; |
| 6175 | |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6176 | auto pPool = getCommandPoolNode(dev_data, commandPool); |
| 6177 | for (uint32_t i = 0; i < commandBufferCount; i++) { |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6178 | auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6179 | // Delete CB information structure, and remove from commandBufferMap |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6180 | if (cb_node) { |
| 6181 | dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6182 | // reset prior to delete for data clean-up |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6183 | resetCB(dev_data, cb_node->commandBuffer); |
| 6184 | dev_data->commandBufferMap.erase(cb_node->commandBuffer); |
| 6185 | delete cb_node; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6186 | } |
| 6187 | |
| 6188 | // Remove commandBuffer reference from commandPoolMap |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6189 | pPool->commandBuffers.remove(pCommandBuffers[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6190 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6191 | lock.unlock(); |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 6192 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6193 | dev_data->dispatch_table.FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6194 | } |
| 6195 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6196 | VKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, |
| 6197 | const VkAllocationCallbacks *pAllocator, |
| 6198 | VkCommandPool *pCommandPool) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6199 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6200 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6201 | VkResult result = dev_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6202 | |
| 6203 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6204 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6205 | dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; |
| 6206 | dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6207 | } |
| 6208 | return result; |
| 6209 | } |
| 6210 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6211 | VKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, |
| 6212 | const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6213 | |
| 6214 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 8a7519b | 2016-11-21 12:30:06 -0700 | [diff] [blame] | 6215 | bool skip = false; |
| 6216 | if (pCreateInfo && pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) { |
| 6217 | if (!dev_data->enabled_features.pipelineStatisticsQuery) { |
| 6218 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, |
| 6219 | __LINE__, VALIDATION_ERROR_01006, "DS", |
| 6220 | "Query pool with type VK_QUERY_TYPE_PIPELINE_STATISTICS created on a device " |
| 6221 | "with VkDeviceCreateInfo.pEnabledFeatures.pipelineStatisticsQuery == VK_FALSE. %s", |
| 6222 | validation_error_map[VALIDATION_ERROR_01006]); |
| 6223 | } |
| 6224 | } |
| 6225 | |
| 6226 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| 6227 | if (!skip) { |
| 6228 | result = dev_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); |
| 6229 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6230 | if (result == VK_SUCCESS) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6231 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | 7d1dd14 | 2016-08-18 08:23:30 -0600 | [diff] [blame] | 6232 | QUERY_POOL_NODE *qp_node = &dev_data->queryPoolMap[*pQueryPool]; |
| 6233 | qp_node->createInfo = *pCreateInfo; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6234 | } |
| 6235 | return result; |
| 6236 | } |
| 6237 | |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6238 | static bool PreCallValidateDestroyCommandPool(layer_data *dev_data, VkCommandPool pool, COMMAND_POOL_NODE **cp_state) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6239 | *cp_state = getCommandPoolNode(dev_data, pool); |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6240 | if (dev_data->instance_data->disabled.destroy_command_pool) |
| 6241 | return false; |
| 6242 | bool skip = false; |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6243 | if (*cp_state) { |
| 6244 | // Verify that command buffers in pool are complete (not in-flight) |
| 6245 | skip |= checkCommandBuffersInFlight(dev_data, *cp_state, "destroy command pool with", VALIDATION_ERROR_00077); |
| 6246 | } |
| 6247 | return skip; |
| 6248 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6249 | |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6250 | static void PostCallRecordDestroyCommandPool(layer_data *dev_data, VkCommandPool pool, COMMAND_POOL_NODE *cp_state) { |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6251 | // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandBufferMap |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6252 | clearCommandBuffersInFlight(dev_data, cp_state); |
| 6253 | for (auto cb : cp_state->commandBuffers) { |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6254 | clear_cmd_buf_and_mem_references(dev_data, cb); |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6255 | auto cb_node = getCBNode(dev_data, cb); |
Tobin Ehlis | 1589d54 | 2016-07-22 16:55:19 -0600 | [diff] [blame] | 6256 | // Remove references to this cb_node prior to delete |
| 6257 | // TODO : Need better solution here, resetCB? |
Mark Lobodzinski | 3c9a384 | 2016-07-15 13:53:44 -0600 | [diff] [blame] | 6258 | for (auto obj : cb_node->object_bindings) { |
| 6259 | removeCommandBufferBinding(dev_data, &obj, cb_node); |
| 6260 | } |
Tobin Ehlis | 1589d54 | 2016-07-22 16:55:19 -0600 | [diff] [blame] | 6261 | for (auto framebuffer : cb_node->framebuffers) { |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 6262 | auto fb_state = getFramebufferState(dev_data, framebuffer); |
| 6263 | if (fb_state) |
| 6264 | fb_state->cb_bindings.erase(cb_node); |
Tobin Ehlis | 1589d54 | 2016-07-22 16:55:19 -0600 | [diff] [blame] | 6265 | } |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6266 | dev_data->commandBufferMap.erase(cb); // Remove this command buffer |
| 6267 | delete cb_node; // delete CB info structure |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6268 | } |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6269 | dev_data->commandPoolMap.erase(pool); |
| 6270 | } |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 6271 | |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6272 | // Destroy commandPool along with all of the commandBuffers allocated from that pool |
| 6273 | VKAPI_ATTR void VKAPI_CALL DestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { |
| 6274 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6275 | COMMAND_POOL_NODE *cp_state = nullptr; |
| 6276 | std::unique_lock<std::mutex> lock(global_lock); |
| 6277 | bool skip = PreCallValidateDestroyCommandPool(dev_data, commandPool, &cp_state); |
| 6278 | if (!skip) { |
| 6279 | lock.unlock(); |
| 6280 | dev_data->dispatch_table.DestroyCommandPool(device, commandPool, pAllocator); |
| 6281 | lock.lock(); |
| 6282 | PostCallRecordDestroyCommandPool(dev_data, commandPool, cp_state); |
| 6283 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6284 | } |
| 6285 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6286 | VKAPI_ATTR VkResult VKAPI_CALL |
| 6287 | ResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6288 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6289 | bool skip_call = false; |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 6290 | |
Chris Forbes | 6be1b5a | 2016-06-21 18:17:41 +1200 | [diff] [blame] | 6291 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6292 | auto pPool = getCommandPoolNode(dev_data, commandPool); |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6293 | skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "reset command pool with", VALIDATION_ERROR_00072); |
Chris Forbes | 6be1b5a | 2016-06-21 18:17:41 +1200 | [diff] [blame] | 6294 | lock.unlock(); |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6295 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6296 | if (skip_call) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6297 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 6298 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6299 | VkResult result = dev_data->dispatch_table.ResetCommandPool(device, commandPool, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6300 | |
| 6301 | // Reset all of the CBs allocated from this pool |
| 6302 | if (VK_SUCCESS == result) { |
Chris Forbes | 6be1b5a | 2016-06-21 18:17:41 +1200 | [diff] [blame] | 6303 | lock.lock(); |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6304 | clearCommandBuffersInFlight(dev_data, pPool); |
| 6305 | for (auto cmdBuffer : pPool->commandBuffers) { |
| 6306 | resetCB(dev_data, cmdBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6307 | } |
Chris Forbes | 6be1b5a | 2016-06-21 18:17:41 +1200 | [diff] [blame] | 6308 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6309 | } |
| 6310 | return result; |
| 6311 | } |
| 6312 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6313 | VKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6314 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6315 | bool skip_call = false; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6316 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6317 | for (uint32_t i = 0; i < fenceCount; ++i) { |
Chris Forbes | 0111ee6 | 2016-06-15 15:48:52 +1200 | [diff] [blame] | 6318 | auto pFence = getFenceNode(dev_data, pFences[i]); |
Chris Forbes | 9c457b9 | 2016-06-21 18:10:47 +1200 | [diff] [blame] | 6319 | if (pFence && pFence->state == FENCE_INFLIGHT) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6320 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 6321 | reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, VALIDATION_ERROR_00183, "DS", |
| 6322 | "Fence 0x%" PRIx64 " is in use. %s", reinterpret_cast<const uint64_t &>(pFences[i]), |
| 6323 | validation_error_map[VALIDATION_ERROR_00183]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6324 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6325 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6326 | lock.unlock(); |
Chris Forbes | 9c457b9 | 2016-06-21 18:10:47 +1200 | [diff] [blame] | 6327 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6328 | if (skip_call) |
Chris Forbes | 9c457b9 | 2016-06-21 18:10:47 +1200 | [diff] [blame] | 6329 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 6330 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6331 | VkResult result = dev_data->dispatch_table.ResetFences(device, fenceCount, pFences); |
Chris Forbes | 9c457b9 | 2016-06-21 18:10:47 +1200 | [diff] [blame] | 6332 | |
| 6333 | if (result == VK_SUCCESS) { |
| 6334 | lock.lock(); |
| 6335 | for (uint32_t i = 0; i < fenceCount; ++i) { |
| 6336 | auto pFence = getFenceNode(dev_data, pFences[i]); |
| 6337 | if (pFence) { |
| 6338 | pFence->state = FENCE_UNSIGNALED; |
Chris Forbes | 9c457b9 | 2016-06-21 18:10:47 +1200 | [diff] [blame] | 6339 | } |
| 6340 | } |
| 6341 | lock.unlock(); |
| 6342 | } |
| 6343 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6344 | return result; |
| 6345 | } |
| 6346 | |
Tobin Ehlis | 2556f5b | 2016-06-24 17:22:16 -0600 | [diff] [blame] | 6347 | // For given cb_nodes, invalidate them and track object causing invalidation |
Tobin Ehlis | ab294d8 | 2016-11-21 15:23:51 -0700 | [diff] [blame] | 6348 | void invalidateCommandBuffers(const layer_data *dev_data, std::unordered_set<GLOBAL_CB_NODE *> const &cb_nodes, VK_OBJECT obj) { |
Tobin Ehlis | 2556f5b | 2016-06-24 17:22:16 -0600 | [diff] [blame] | 6349 | for (auto cb_node : cb_nodes) { |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6350 | if (cb_node->state == CB_RECORDING) { |
| 6351 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Tobin Ehlis | fda58e2 | 2016-11-21 15:15:52 -0700 | [diff] [blame] | 6352 | (uint64_t)(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 6353 | "Invalidating a command buffer that's currently being recorded: 0x%p.", cb_node->commandBuffer); |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6354 | } |
Tobin Ehlis | 2556f5b | 2016-06-24 17:22:16 -0600 | [diff] [blame] | 6355 | cb_node->state = CB_INVALID; |
| 6356 | cb_node->broken_bindings.push_back(obj); |
| 6357 | } |
| 6358 | } |
| 6359 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 6360 | static bool PreCallValidateDestroyFramebuffer(layer_data *dev_data, VkFramebuffer framebuffer, |
| 6361 | FRAMEBUFFER_STATE **framebuffer_state, VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6362 | *framebuffer_state = getFramebufferState(dev_data, framebuffer); |
| 6363 | *obj_struct = {reinterpret_cast<uint64_t &>(framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 6364 | if (dev_data->instance_data->disabled.destroy_framebuffer) |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6365 | return false; |
| 6366 | bool skip = false; |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6367 | if (*framebuffer_state) { |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6368 | skip |= ValidateObjectNotInUse(dev_data, *framebuffer_state, *obj_struct, VALIDATION_ERROR_00422); |
| 6369 | } |
| 6370 | return skip; |
| 6371 | } |
| 6372 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 6373 | static void PostCallRecordDestroyFramebuffer(layer_data *dev_data, VkFramebuffer framebuffer, FRAMEBUFFER_STATE *framebuffer_state, |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6374 | VK_OBJECT obj_struct) { |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6375 | invalidateCommandBuffers(dev_data, framebuffer_state->cb_bindings, obj_struct); |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6376 | dev_data->frameBufferMap.erase(framebuffer); |
| 6377 | } |
| 6378 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6379 | VKAPI_ATTR void VKAPI_CALL |
| 6380 | DestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6381 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 6382 | FRAMEBUFFER_STATE *framebuffer_state = nullptr; |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6383 | VK_OBJECT obj_struct; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6384 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6385 | bool skip = PreCallValidateDestroyFramebuffer(dev_data, framebuffer, &framebuffer_state, &obj_struct); |
| 6386 | if (!skip) { |
| 6387 | lock.unlock(); |
| 6388 | dev_data->dispatch_table.DestroyFramebuffer(device, framebuffer, pAllocator); |
| 6389 | lock.lock(); |
| 6390 | PostCallRecordDestroyFramebuffer(dev_data, framebuffer, framebuffer_state, obj_struct); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6391 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6392 | } |
| 6393 | |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6394 | static bool PreCallValidateDestroyRenderPass(layer_data *dev_data, VkRenderPass render_pass, RENDER_PASS_STATE **rp_state, |
| 6395 | VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6396 | *rp_state = getRenderPassState(dev_data, render_pass); |
| 6397 | *obj_struct = {reinterpret_cast<uint64_t &>(render_pass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 6398 | if (dev_data->instance_data->disabled.destroy_renderpass) |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6399 | return false; |
| 6400 | bool skip = false; |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6401 | if (*rp_state) { |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6402 | skip |= ValidateObjectNotInUse(dev_data, *rp_state, *obj_struct, VALIDATION_ERROR_00393); |
| 6403 | } |
| 6404 | return skip; |
| 6405 | } |
| 6406 | |
| 6407 | static void PostCallRecordDestroyRenderPass(layer_data *dev_data, VkRenderPass render_pass, RENDER_PASS_STATE *rp_state, |
| 6408 | VK_OBJECT obj_struct) { |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6409 | invalidateCommandBuffers(dev_data, rp_state->cb_bindings, obj_struct); |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6410 | dev_data->renderPassMap.erase(render_pass); |
| 6411 | } |
| 6412 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6413 | VKAPI_ATTR void VKAPI_CALL |
| 6414 | DestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6415 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6416 | RENDER_PASS_STATE *rp_state = nullptr; |
| 6417 | VK_OBJECT obj_struct; |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 6418 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6419 | bool skip = PreCallValidateDestroyRenderPass(dev_data, renderPass, &rp_state, &obj_struct); |
Tobin Ehlis | a549524 | 2016-09-19 14:20:37 -0600 | [diff] [blame] | 6420 | if (!skip) { |
Tobin Ehlis | a549524 | 2016-09-19 14:20:37 -0600 | [diff] [blame] | 6421 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6422 | dev_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator); |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6423 | lock.lock(); |
| 6424 | PostCallRecordDestroyRenderPass(dev_data, renderPass, rp_state, obj_struct); |
Tobin Ehlis | a549524 | 2016-09-19 14:20:37 -0600 | [diff] [blame] | 6425 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6426 | } |
| 6427 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6428 | VKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, |
| 6429 | const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6430 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Karl Schultz | a9ef1e5 | 2016-10-06 17:53:48 -0600 | [diff] [blame] | 6431 | // TODO: Add check for VALIDATION_ERROR_00658 |
| 6432 | // TODO: Add check for VALIDATION_ERROR_00666 |
| 6433 | // TODO: Add check for VALIDATION_ERROR_00667 |
| 6434 | // TODO: Add check for VALIDATION_ERROR_00668 |
| 6435 | // TODO: Add check for VALIDATION_ERROR_00669 |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6436 | VkResult result = dev_data->dispatch_table.CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6437 | |
| 6438 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6439 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6440 | // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 6441 | dev_data->bufferMap.insert(std::make_pair(*pBuffer, unique_ptr<BUFFER_STATE>(new BUFFER_STATE(*pBuffer, pCreateInfo)))); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6442 | } |
| 6443 | return result; |
| 6444 | } |
| 6445 | |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6446 | static bool PreCallValidateCreateBufferView(layer_data *dev_data, const VkBufferViewCreateInfo *pCreateInfo) { |
| 6447 | bool skip_call = false; |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 6448 | BUFFER_STATE *buffer_state = getBufferState(dev_data, pCreateInfo->buffer); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6449 | // If this isn't a sparse buffer, it needs to have memory backing it at CreateBufferView time |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 6450 | if (buffer_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 6451 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buffer_state, "vkCreateBufferView()", VALIDATION_ERROR_02522); |
Tobin Ehlis | 18bca09 | 2016-06-29 09:07:52 -0600 | [diff] [blame] | 6452 | // In order to create a valid buffer view, the buffer must have been created with at least one of the |
| 6453 | // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 6454 | skip_call |= ValidateBufferUsageFlags( |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 6455 | dev_data, buffer_state, VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 6456 | VALIDATION_ERROR_00694, "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 6457 | } |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6458 | return skip_call; |
| 6459 | } |
| 6460 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6461 | VKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, |
| 6462 | const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6463 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6464 | std::unique_lock<std::mutex> lock(global_lock); |
| 6465 | bool skip_call = PreCallValidateCreateBufferView(dev_data, pCreateInfo); |
| 6466 | lock.unlock(); |
| 6467 | if (skip_call) |
| 6468 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6469 | VkResult result = dev_data->dispatch_table.CreateBufferView(device, pCreateInfo, pAllocator, pView); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6470 | if (VK_SUCCESS == result) { |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6471 | lock.lock(); |
Tobin Ehlis | 8b87246 | 2016-09-14 08:12:08 -0600 | [diff] [blame] | 6472 | dev_data->bufferViewMap[*pView] = unique_ptr<BUFFER_VIEW_STATE>(new BUFFER_VIEW_STATE(*pView, pCreateInfo)); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6473 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6474 | } |
| 6475 | return result; |
| 6476 | } |
| 6477 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6478 | VKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, |
| 6479 | const VkAllocationCallbacks *pAllocator, VkImage *pImage) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6480 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | f20f094 | 2016-03-22 10:07:26 -0600 | [diff] [blame] | 6481 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6482 | VkResult result = dev_data->dispatch_table.CreateImage(device, pCreateInfo, pAllocator, pImage); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6483 | |
| 6484 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6485 | std::lock_guard<std::mutex> lock(global_lock); |
Mark Lobodzinski | 42fe5f7 | 2017-01-11 11:36:16 -0700 | [diff] [blame^] | 6486 | PostCallRecordCreateImage(dev_data->imageMap, dev_data->imageSubresourceMap, dev_data->imageLayoutMap, pCreateInfo, pImage); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6487 | } |
| 6488 | return result; |
| 6489 | } |
| 6490 | |
| 6491 | static void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 6492 | // Expects global_lock to be held by caller |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6493 | |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6494 | auto image_state = getImageState(dev_data, image); |
| 6495 | if (image_state) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 6496 | // If the caller used the special values VK_REMAINING_MIP_LEVELS and VK_REMAINING_ARRAY_LAYERS, resolve them now in our |
| 6497 | // internal state to the actual values. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6498 | if (range->levelCount == VK_REMAINING_MIP_LEVELS) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6499 | range->levelCount = image_state->createInfo.mipLevels - range->baseMipLevel; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6500 | } |
| 6501 | |
| 6502 | if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6503 | range->layerCount = image_state->createInfo.arrayLayers - range->baseArrayLayer; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6504 | } |
| 6505 | } |
| 6506 | } |
| 6507 | |
| 6508 | // Return the correct layer/level counts if the caller used the special |
| 6509 | // values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. |
| 6510 | static void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, |
| 6511 | VkImage image) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 6512 | // Expects global_lock to be held by caller |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6513 | |
| 6514 | *levels = range.levelCount; |
| 6515 | *layers = range.layerCount; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6516 | auto image_state = getImageState(dev_data, image); |
| 6517 | if (image_state) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6518 | if (range.levelCount == VK_REMAINING_MIP_LEVELS) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6519 | *levels = image_state->createInfo.mipLevels - range.baseMipLevel; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6520 | } |
| 6521 | if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6522 | *layers = image_state->createInfo.arrayLayers - range.baseArrayLayer; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6523 | } |
| 6524 | } |
| 6525 | } |
| 6526 | |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6527 | // For the given format verify that the aspect masks make sense |
| 6528 | static bool ValidateImageAspectMask(layer_data *dev_data, VkImage image, VkFormat format, VkImageAspectFlags aspect_mask, |
| 6529 | const char *func_name) { |
| 6530 | bool skip = false; |
| 6531 | if (vk_format_is_color(format)) { |
| 6532 | if ((aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { |
| 6533 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6534 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6535 | "%s: Color image formats must have the VK_IMAGE_ASPECT_COLOR_BIT set. %s", func_name, |
| 6536 | validation_error_map[VALIDATION_ERROR_00741]); |
Tobin Ehlis | a4306ef | 2017-01-02 10:04:56 -0700 | [diff] [blame] | 6537 | } else if ((aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) != aspect_mask) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6538 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6539 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6540 | "%s: Color image formats must have ONLY the VK_IMAGE_ASPECT_COLOR_BIT set. %s", func_name, |
| 6541 | validation_error_map[VALIDATION_ERROR_00741]); |
| 6542 | } |
| 6543 | } else if (vk_format_is_depth_and_stencil(format)) { |
| 6544 | if ((aspect_mask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) == 0) { |
| 6545 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6546 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", "%s: Depth/stencil image formats must have " |
| 6547 | "at least one of VK_IMAGE_ASPECT_DEPTH_BIT " |
| 6548 | "and VK_IMAGE_ASPECT_STENCIL_BIT set. %s", |
| 6549 | func_name, validation_error_map[VALIDATION_ERROR_00741]); |
Tobin Ehlis | a4306ef | 2017-01-02 10:04:56 -0700 | [diff] [blame] | 6550 | } else if ((aspect_mask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) != aspect_mask) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6551 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6552 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6553 | "%s: Combination depth/stencil image formats can have only the VK_IMAGE_ASPECT_DEPTH_BIT and " |
| 6554 | "VK_IMAGE_ASPECT_STENCIL_BIT set. %s", |
| 6555 | func_name, validation_error_map[VALIDATION_ERROR_00741]); |
| 6556 | } |
| 6557 | } else if (vk_format_is_depth_only(format)) { |
| 6558 | if ((aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) != VK_IMAGE_ASPECT_DEPTH_BIT) { |
| 6559 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6560 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6561 | "%s: Depth-only image formats must have the VK_IMAGE_ASPECT_DEPTH_BIT set. %s", func_name, |
| 6562 | validation_error_map[VALIDATION_ERROR_00741]); |
Tobin Ehlis | a4306ef | 2017-01-02 10:04:56 -0700 | [diff] [blame] | 6563 | } else if ((aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) != aspect_mask) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6564 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6565 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6566 | "%s: Depth-only image formats can have only the VK_IMAGE_ASPECT_DEPTH_BIT set. %s", func_name, |
| 6567 | validation_error_map[VALIDATION_ERROR_00741]); |
| 6568 | } |
| 6569 | } else if (vk_format_is_stencil_only(format)) { |
| 6570 | if ((aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) != VK_IMAGE_ASPECT_STENCIL_BIT) { |
| 6571 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6572 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6573 | "%s: Stencil-only image formats must have the VK_IMAGE_ASPECT_STENCIL_BIT set. %s", func_name, |
| 6574 | validation_error_map[VALIDATION_ERROR_00741]); |
Tobin Ehlis | a4306ef | 2017-01-02 10:04:56 -0700 | [diff] [blame] | 6575 | } else if ((aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) != aspect_mask) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6576 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6577 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6578 | "%s: Stencil-only image formats can have only the VK_IMAGE_ASPECT_STENCIL_BIT set. %s", func_name, |
| 6579 | validation_error_map[VALIDATION_ERROR_00741]); |
| 6580 | } |
| 6581 | } |
| 6582 | return skip; |
| 6583 | } |
| 6584 | |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6585 | static bool PreCallValidateCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *create_info) { |
Tobin Ehlis | 4ad9d85 | 2016-10-26 08:04:58 -0600 | [diff] [blame] | 6586 | bool skip = false; |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6587 | IMAGE_STATE *image_state = getImageState(dev_data, create_info->image); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6588 | if (image_state) { |
Tobin Ehlis | 4ad9d85 | 2016-10-26 08:04:58 -0600 | [diff] [blame] | 6589 | skip |= ValidateImageUsageFlags( |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6590 | dev_data, image_state, VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | |
| 6591 | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 6592 | false, -1, "vkCreateImageView()", |
Tony Barbour | 311dcbe | 2016-08-26 13:01:43 -0600 | [diff] [blame] | 6593 | "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT|DEPTH_STENCIL_ATTACHMENT|INPUT_ATTACHMENT]_BIT"); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 6594 | // If this isn't a sparse image, it needs to have memory backing it at CreateImageView time |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 6595 | skip |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCreateImageView()", VALIDATION_ERROR_02524); |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6596 | // Checks imported from image layer |
| 6597 | if (create_info->subresourceRange.baseMipLevel >= image_state->createInfo.mipLevels) { |
| 6598 | std::stringstream ss; |
| 6599 | ss << "vkCreateImageView called with baseMipLevel " << create_info->subresourceRange.baseMipLevel << " for image " |
| 6600 | << create_info->image << " that only has " << image_state->createInfo.mipLevels << " mip levels."; |
| 6601 | skip |= |
| 6602 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6603 | VALIDATION_ERROR_00768, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00768]); |
| 6604 | } |
| 6605 | if (create_info->subresourceRange.baseArrayLayer >= image_state->createInfo.arrayLayers) { |
| 6606 | std::stringstream ss; |
| 6607 | ss << "vkCreateImageView called with baseArrayLayer " << create_info->subresourceRange.baseArrayLayer << " for image " |
| 6608 | << create_info->image << " that only has " << image_state->createInfo.arrayLayers << " array layers."; |
| 6609 | skip |= |
| 6610 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6611 | VALIDATION_ERROR_00769, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00769]); |
| 6612 | } |
| 6613 | // TODO: Need new valid usage language for levelCount == 0 & layerCount == 0 |
| 6614 | if (!create_info->subresourceRange.levelCount) { |
| 6615 | std::stringstream ss; |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6616 | ss << "vkCreateImageView called with 0 in pCreateInfo->subresourceRange.levelCount."; |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6617 | skip |= |
| 6618 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6619 | VALIDATION_ERROR_00768, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00768]); |
| 6620 | } |
| 6621 | if (!create_info->subresourceRange.layerCount) { |
| 6622 | std::stringstream ss; |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6623 | ss << "vkCreateImageView called with 0 in pCreateInfo->subresourceRange.layerCount."; |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6624 | skip |= |
| 6625 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6626 | VALIDATION_ERROR_00769, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00769]); |
| 6627 | } |
| 6628 | |
| 6629 | VkImageCreateFlags image_flags = image_state->createInfo.flags; |
| 6630 | VkFormat image_format = image_state->createInfo.format; |
| 6631 | VkFormat view_format = create_info->format; |
| 6632 | VkImageAspectFlags aspect_mask = create_info->subresourceRange.aspectMask; |
| 6633 | |
| 6634 | // Validate VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT state |
| 6635 | if (image_flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) { |
| 6636 | // Format MUST be compatible (in the same format compatibility class) as the format the image was created with |
| 6637 | if (vk_format_get_compatibility_class(image_format) != vk_format_get_compatibility_class(view_format)) { |
| 6638 | std::stringstream ss; |
| 6639 | ss << "vkCreateImageView(): ImageView format " << string_VkFormat(view_format) |
| 6640 | << " is not in the same format compatibility class as image (" << (uint64_t)create_info->image << ") format " |
| 6641 | << string_VkFormat(image_format) << ". Images created with the VK_IMAGE_CREATE_MUTABLE_FORMAT BIT " |
| 6642 | << "can support ImageViews with differing formats but they must be in the same compatibility class."; |
| 6643 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6644 | VALIDATION_ERROR_02171, "IMAGE", "%s %s", ss.str().c_str(), |
| 6645 | validation_error_map[VALIDATION_ERROR_02171]); |
| 6646 | } |
| 6647 | } else { |
| 6648 | // Format MUST be IDENTICAL to the format the image was created with |
| 6649 | if (image_format != view_format) { |
| 6650 | std::stringstream ss; |
| 6651 | ss << "vkCreateImageView() format " << string_VkFormat(view_format) << " differs from image " |
| 6652 | << (uint64_t)create_info->image << " format " << string_VkFormat(image_format) |
| 6653 | << ". Formats MUST be IDENTICAL unless VK_IMAGE_CREATE_MUTABLE_FORMAT BIT was set on image creation."; |
| 6654 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6655 | VALIDATION_ERROR_02172, "IMAGE", "%s %s", ss.str().c_str(), |
| 6656 | validation_error_map[VALIDATION_ERROR_02172]); |
| 6657 | } |
| 6658 | } |
| 6659 | |
| 6660 | // Validate correct image aspect bits for desired formats and format consistency |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6661 | skip |= ValidateImageAspectMask(dev_data, image_state->image, image_format, aspect_mask, "vkCreateImageView()"); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6662 | } |
Tobin Ehlis | 4ad9d85 | 2016-10-26 08:04:58 -0600 | [diff] [blame] | 6663 | return skip; |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6664 | } |
| 6665 | |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6666 | static inline void PostCallRecordCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *create_info, VkImageView view) { |
| 6667 | dev_data->imageViewMap[view] = unique_ptr<IMAGE_VIEW_STATE>(new IMAGE_VIEW_STATE(view, create_info)); |
| 6668 | ResolveRemainingLevelsLayers(dev_data, &dev_data->imageViewMap[view].get()->create_info.subresourceRange, create_info->image); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6669 | } |
| 6670 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6671 | VKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, |
| 6672 | const VkAllocationCallbacks *pAllocator, VkImageView *pView) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6673 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6674 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4ad9d85 | 2016-10-26 08:04:58 -0600 | [diff] [blame] | 6675 | bool skip = PreCallValidateCreateImageView(dev_data, pCreateInfo); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6676 | lock.unlock(); |
Tobin Ehlis | 4ad9d85 | 2016-10-26 08:04:58 -0600 | [diff] [blame] | 6677 | if (skip) |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6678 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6679 | VkResult result = dev_data->dispatch_table.CreateImageView(device, pCreateInfo, pAllocator, pView); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6680 | if (VK_SUCCESS == result) { |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6681 | lock.lock(); |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 6682 | PostCallRecordCreateImageView(dev_data, pCreateInfo, *pView); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6683 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6684 | } |
Chris Forbes | 86c586a | 2016-05-08 10:19:14 +1200 | [diff] [blame] | 6685 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6686 | return result; |
| 6687 | } |
| 6688 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6689 | VKAPI_ATTR VkResult VKAPI_CALL |
| 6690 | CreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6691 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6692 | VkResult result = dev_data->dispatch_table.CreateFence(device, pCreateInfo, pAllocator, pFence); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6693 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6694 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 6695 | auto &fence_node = dev_data->fenceMap[*pFence]; |
Chris Forbes | bc0b821 | 2016-06-10 15:22:37 +1200 | [diff] [blame] | 6696 | fence_node.fence = *pFence; |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 6697 | fence_node.createInfo = *pCreateInfo; |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 6698 | fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6699 | } |
| 6700 | return result; |
| 6701 | } |
| 6702 | |
| 6703 | // TODO handle pipeline caches |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6704 | VKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, |
| 6705 | const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6706 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6707 | VkResult result = dev_data->dispatch_table.CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6708 | return result; |
| 6709 | } |
| 6710 | |
| 6711 | VKAPI_ATTR void VKAPI_CALL |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6712 | DestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6713 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6714 | dev_data->dispatch_table.DestroyPipelineCache(device, pipelineCache, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6715 | } |
| 6716 | |
| 6717 | VKAPI_ATTR VkResult VKAPI_CALL |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6718 | GetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6719 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6720 | VkResult result = dev_data->dispatch_table.GetPipelineCacheData(device, pipelineCache, pDataSize, pData); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6721 | return result; |
| 6722 | } |
| 6723 | |
| 6724 | VKAPI_ATTR VkResult VKAPI_CALL |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6725 | MergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6726 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6727 | VkResult result = dev_data->dispatch_table.MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6728 | return result; |
| 6729 | } |
| 6730 | |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 6731 | // utility function to set collective state for pipeline |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6732 | void set_pipeline_state(PIPELINE_STATE *pPipe) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 6733 | // If any attachment used by this pipeline has blendEnable, set top-level blendEnable |
| 6734 | if (pPipe->graphicsPipelineCI.pColorBlendState) { |
| 6735 | for (size_t i = 0; i < pPipe->attachments.size(); ++i) { |
| 6736 | if (VK_TRUE == pPipe->attachments[i].blendEnable) { |
| 6737 | if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| 6738 | (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || |
| 6739 | ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| 6740 | (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || |
| 6741 | ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| 6742 | (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || |
| 6743 | ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| 6744 | (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { |
| 6745 | pPipe->blendConstantsEnabled = true; |
| 6746 | } |
| 6747 | } |
| 6748 | } |
| 6749 | } |
| 6750 | } |
| 6751 | |
Mark Lobodzinski | 7f170b3 | 2016-11-16 10:05:30 -0700 | [diff] [blame] | 6752 | static bool PreCallCreateGraphicsPipelines(layer_data *device_data, uint32_t count, |
| 6753 | const VkGraphicsPipelineCreateInfo *create_infos, vector<PIPELINE_STATE *> &pipe_state) { |
| 6754 | bool skip = false; |
Mark Lobodzinski | ca60e14 | 2016-11-16 11:12:30 -0700 | [diff] [blame] | 6755 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(device_data->instance_data->instance), instance_layer_data_map); |
Mark Lobodzinski | 7f170b3 | 2016-11-16 10:05:30 -0700 | [diff] [blame] | 6756 | |
| 6757 | for (uint32_t i = 0; i < count; i++) { |
| 6758 | skip |= verifyPipelineCreateState(device_data, pipe_state, i); |
Mark Lobodzinski | ca60e14 | 2016-11-16 11:12:30 -0700 | [diff] [blame] | 6759 | if (create_infos[i].pVertexInputState != NULL) { |
| 6760 | for (uint32_t j = 0; j < create_infos[i].pVertexInputState->vertexAttributeDescriptionCount; j++) { |
| 6761 | VkFormat format = create_infos[i].pVertexInputState->pVertexAttributeDescriptions[j].format; |
| 6762 | // Internal call to get format info. Still goes through layers, could potentially go directly to ICD. |
| 6763 | VkFormatProperties properties; |
| 6764 | instance_data->dispatch_table.GetPhysicalDeviceFormatProperties(device_data->physical_device, format, &properties); |
| 6765 | if ((properties.bufferFeatures & VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT) == 0) { |
| 6766 | skip |= log_msg( |
| 6767 | device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 6768 | __LINE__, VALIDATION_ERROR_01413, "IMAGE", |
| 6769 | "vkCreateGraphicsPipelines: pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].format " |
| 6770 | "(%s) is not a supported vertex buffer format. %s", |
| 6771 | i, j, string_VkFormat(format), validation_error_map[VALIDATION_ERROR_01413]); |
| 6772 | } |
| 6773 | } |
| 6774 | } |
Mark Lobodzinski | 7f170b3 | 2016-11-16 10:05:30 -0700 | [diff] [blame] | 6775 | } |
| 6776 | return skip; |
| 6777 | } |
| 6778 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6779 | VKAPI_ATTR VkResult VKAPI_CALL |
| 6780 | CreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, |
| 6781 | const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, |
| 6782 | VkPipeline *pPipelines) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6783 | // TODO What to do with pipelineCache? |
| 6784 | // The order of operations here is a little convoluted but gets the job done |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6785 | // 1. Pipeline create state is first shadowed into PIPELINE_STATE struct |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6786 | // 2. Create state is then validated (which uses flags setup during shadowing) |
| 6787 | // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap |
Mark Lobodzinski | 1f34f6f | 2016-11-16 10:11:02 -0700 | [diff] [blame] | 6788 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6789 | // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic |
Mark Lobodzinski | 1f34f6f | 2016-11-16 10:11:02 -0700 | [diff] [blame] | 6790 | vector<PIPELINE_STATE *> pipe_state(count); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6791 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6792 | |
| 6793 | uint32_t i = 0; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6794 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6795 | |
| 6796 | for (i = 0; i < count; i++) { |
Mark Lobodzinski | 1f34f6f | 2016-11-16 10:11:02 -0700 | [diff] [blame] | 6797 | pipe_state[i] = new PIPELINE_STATE; |
| 6798 | pipe_state[i]->initGraphicsPipeline(&pCreateInfos[i]); |
| 6799 | pipe_state[i]->render_pass_ci.initialize(getRenderPassState(dev_data, pCreateInfos[i].renderPass)->createInfo.ptr()); |
| 6800 | pipe_state[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6801 | } |
Mark Lobodzinski | 1f34f6f | 2016-11-16 10:11:02 -0700 | [diff] [blame] | 6802 | skip |= PreCallCreateGraphicsPipelines(dev_data, count, pCreateInfos, pipe_state); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6803 | |
Chris Forbes | 56754e2 | 2016-11-30 14:24:32 +1300 | [diff] [blame] | 6804 | if (skip) { |
| 6805 | for (i = 0; i < count; i++) { |
| 6806 | delete pipe_state[i]; |
Chris Forbes | 83e91ad | 2016-11-30 14:26:50 +1300 | [diff] [blame] | 6807 | pPipelines[i] = VK_NULL_HANDLE; |
Chris Forbes | 56754e2 | 2016-11-30 14:24:32 +1300 | [diff] [blame] | 6808 | } |
Chris Forbes | 78a69c6 | 2016-11-30 14:39:24 +1300 | [diff] [blame] | 6809 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 6810 | } |
| 6811 | |
| 6812 | lock.unlock(); |
| 6813 | auto result = dev_data->dispatch_table.CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); |
| 6814 | lock.lock(); |
| 6815 | for (i = 0; i < count; i++) { |
Chris Forbes | b186edf | 2016-11-30 14:41:35 +1300 | [diff] [blame] | 6816 | if (pPipelines[i] == VK_NULL_HANDLE) { |
| 6817 | delete pipe_state[i]; |
| 6818 | } |
| 6819 | else { |
| 6820 | pipe_state[i]->pipeline = pPipelines[i]; |
| 6821 | dev_data->pipelineMap[pipe_state[i]->pipeline] = pipe_state[i]; |
| 6822 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6823 | } |
Chris Forbes | 56754e2 | 2016-11-30 14:24:32 +1300 | [diff] [blame] | 6824 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6825 | return result; |
| 6826 | } |
| 6827 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6828 | VKAPI_ATTR VkResult VKAPI_CALL |
| 6829 | CreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, |
| 6830 | const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, |
| 6831 | VkPipeline *pPipelines) { |
Chris Forbes | 183f4f9 | 2016-11-30 14:35:52 +1300 | [diff] [blame] | 6832 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6833 | |
| 6834 | // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6835 | vector<PIPELINE_STATE *> pPipeState(count); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6836 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6837 | |
| 6838 | uint32_t i = 0; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6839 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6840 | for (i = 0; i < count; i++) { |
| 6841 | // TODO: Verify compute stage bits |
| 6842 | |
| 6843 | // Create and initialize internal tracking data structure |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6844 | pPipeState[i] = new PIPELINE_STATE; |
| 6845 | pPipeState[i]->initComputePipeline(&pCreateInfos[i]); |
Tobin Ehlis | c1d9be1 | 2016-10-13 10:18:18 -0600 | [diff] [blame] | 6846 | pPipeState[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6847 | |
| 6848 | // TODO: Add Compute Pipeline Verification |
Chris Forbes | 183f4f9 | 2016-11-30 14:35:52 +1300 | [diff] [blame] | 6849 | skip |= !validate_compute_pipeline(dev_data->report_data, pPipeState[i], &dev_data->enabled_features, |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6850 | dev_data->shaderModuleMap); |
Chris Forbes | 183f4f9 | 2016-11-30 14:35:52 +1300 | [diff] [blame] | 6851 | // skip |= verifyPipelineCreateState(dev_data, pPipeState[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6852 | } |
| 6853 | |
Chris Forbes | 78a69c6 | 2016-11-30 14:39:24 +1300 | [diff] [blame] | 6854 | if (skip) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6855 | for (i = 0; i < count; i++) { |
| 6856 | // Clean up any locally allocated data structures |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6857 | delete pPipeState[i]; |
Chris Forbes | 3224f95 | 2016-11-30 14:44:03 +1300 | [diff] [blame] | 6858 | pPipelines[i] = VK_NULL_HANDLE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6859 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6860 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 6861 | } |
Chris Forbes | 78a69c6 | 2016-11-30 14:39:24 +1300 | [diff] [blame] | 6862 | |
| 6863 | lock.unlock(); |
| 6864 | auto result = dev_data->dispatch_table.CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); |
| 6865 | lock.lock(); |
| 6866 | for (i = 0; i < count; i++) { |
Chris Forbes | 3224f95 | 2016-11-30 14:44:03 +1300 | [diff] [blame] | 6867 | if (pPipelines[i] == VK_NULL_HANDLE) { |
| 6868 | delete pPipeState[i]; |
| 6869 | } |
| 6870 | else { |
| 6871 | pPipeState[i]->pipeline = pPipelines[i]; |
| 6872 | dev_data->pipelineMap[pPipeState[i]->pipeline] = pPipeState[i]; |
| 6873 | } |
Chris Forbes | 78a69c6 | 2016-11-30 14:39:24 +1300 | [diff] [blame] | 6874 | } |
| 6875 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6876 | return result; |
| 6877 | } |
| 6878 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6879 | VKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, |
| 6880 | const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6881 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6882 | VkResult result = dev_data->dispatch_table.CreateSampler(device, pCreateInfo, pAllocator, pSampler); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6883 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6884 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 6885 | dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_STATE>(new SAMPLER_STATE(pSampler, pCreateInfo)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6886 | } |
| 6887 | return result; |
| 6888 | } |
| 6889 | |
Tobin Ehlis | 154c269 | 2016-10-25 09:36:53 -0600 | [diff] [blame] | 6890 | static bool PreCallValidateCreateDescriptorSetLayout(layer_data *dev_data, const VkDescriptorSetLayoutCreateInfo *create_info) { |
| 6891 | if (dev_data->instance_data->disabled.create_descriptor_set_layout) |
| 6892 | return false; |
| 6893 | return cvdescriptorset::DescriptorSetLayout::ValidateCreateInfo(dev_data->report_data, create_info); |
| 6894 | } |
| 6895 | |
| 6896 | static void PostCallRecordCreateDescriptorSetLayout(layer_data *dev_data, const VkDescriptorSetLayoutCreateInfo *create_info, |
| 6897 | VkDescriptorSetLayout set_layout) { |
Tobin Ehlis | fdcb63f | 2016-10-25 20:56:47 -0600 | [diff] [blame] | 6898 | // TODO: Convert this to unique_ptr to avoid leaks |
Tobin Ehlis | 154c269 | 2016-10-25 09:36:53 -0600 | [diff] [blame] | 6899 | dev_data->descriptorSetLayoutMap[set_layout] = new cvdescriptorset::DescriptorSetLayout(create_info, set_layout); |
| 6900 | } |
| 6901 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6902 | VKAPI_ATTR VkResult VKAPI_CALL |
| 6903 | CreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, |
| 6904 | const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6905 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 154c269 | 2016-10-25 09:36:53 -0600 | [diff] [blame] | 6906 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| 6907 | std::unique_lock<std::mutex> lock(global_lock); |
| 6908 | bool skip = PreCallValidateCreateDescriptorSetLayout(dev_data, pCreateInfo); |
| 6909 | if (!skip) { |
| 6910 | lock.unlock(); |
| 6911 | result = dev_data->dispatch_table.CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); |
| 6912 | if (VK_SUCCESS == result) { |
| 6913 | lock.lock(); |
| 6914 | PostCallRecordCreateDescriptorSetLayout(dev_data, pCreateInfo, *pSetLayout); |
| 6915 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6916 | } |
| 6917 | return result; |
| 6918 | } |
| 6919 | |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6920 | // Used by CreatePipelineLayout and CmdPushConstants. |
| 6921 | // Note that the index argument is optional and only used by CreatePipelineLayout. |
| 6922 | static bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, |
| 6923 | const char *caller_name, uint32_t index = 0) { |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 6924 | if (dev_data->instance_data->disabled.push_constant_range) |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 6925 | return false; |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6926 | uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6927 | bool skip_call = false; |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6928 | // Check that offset + size don't exceed the max. |
| 6929 | // Prevent arithetic overflow here by avoiding addition and testing in this order. |
| 6930 | if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { |
| 6931 | // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. |
| 6932 | if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { |
Tobin Ehlis | 2765e46 | 2016-11-23 10:47:26 -0700 | [diff] [blame] | 6933 | if (offset >= maxPushConstantsSize) { |
| 6934 | skip_call |= |
| 6935 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6936 | VALIDATION_ERROR_00877, "DS", "%s call has push constants index %u with offset %u that " |
| 6937 | "exceeds this device's maxPushConstantSize of %u. %s", |
| 6938 | caller_name, index, offset, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_00877]); |
| 6939 | } |
| 6940 | if (size > maxPushConstantsSize - offset) { |
| 6941 | skip_call |= |
| 6942 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6943 | VALIDATION_ERROR_00880, "DS", "%s call has push constants index %u with offset %u and size %u that " |
| 6944 | "exceeds this device's maxPushConstantSize of %u. %s", |
| 6945 | caller_name, index, offset, size, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_00880]); |
| 6946 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6947 | } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 6948 | if (offset >= maxPushConstantsSize) { |
| 6949 | skip_call |= |
| 6950 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6951 | VALIDATION_ERROR_00991, "DS", "%s call has push constants index %u with offset %u that " |
| 6952 | "exceeds this device's maxPushConstantSize of %u. %s", |
| 6953 | caller_name, index, offset, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_00991]); |
| 6954 | } |
| 6955 | if (size > maxPushConstantsSize - offset) { |
| 6956 | skip_call |= |
| 6957 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6958 | VALIDATION_ERROR_00992, "DS", "%s call has push constants index %u with offset %u and size %u that " |
| 6959 | "exceeds this device's maxPushConstantSize of %u. %s", |
| 6960 | caller_name, index, offset, size, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_00992]); |
| 6961 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6962 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6963 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6964 | DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6965 | } |
| 6966 | } |
| 6967 | // size needs to be non-zero and a multiple of 4. |
| 6968 | if ((size == 0) || ((size & 0x3) != 0)) { |
| 6969 | if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { |
Tobin Ehlis | fe69954 | 2016-11-23 09:41:12 -0700 | [diff] [blame] | 6970 | if (size == 0) { |
| 6971 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 6972 | __LINE__, VALIDATION_ERROR_00878, "DS", "%s call has push constants index %u with " |
| 6973 | "size %u. Size must be greater than zero. %s", |
| 6974 | caller_name, index, size, validation_error_map[VALIDATION_ERROR_00878]); |
| 6975 | } |
| 6976 | if (size & 0x3) { |
| 6977 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 6978 | __LINE__, VALIDATION_ERROR_00879, "DS", "%s call has push constants index %u with " |
| 6979 | "size %u. Size must be a multiple of 4. %s", |
| 6980 | caller_name, index, size, validation_error_map[VALIDATION_ERROR_00879]); |
| 6981 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6982 | } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 6983 | if (size == 0) { |
| 6984 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 6985 | __LINE__, VALIDATION_ERROR_01000, "DS", "%s call has push constants index %u with " |
| 6986 | "size %u. Size must be greater than zero. %s", |
| 6987 | caller_name, index, size, validation_error_map[VALIDATION_ERROR_01000]); |
| 6988 | } |
| 6989 | if (size & 0x3) { |
| 6990 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 6991 | __LINE__, VALIDATION_ERROR_00990, "DS", "%s call has push constants index %u with " |
| 6992 | "size %u. Size must be a multiple of 4. %s", |
| 6993 | caller_name, index, size, validation_error_map[VALIDATION_ERROR_00990]); |
| 6994 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6995 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6996 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6997 | DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6998 | } |
| 6999 | } |
| 7000 | // offset needs to be a multiple of 4. |
| 7001 | if ((offset & 0x3) != 0) { |
| 7002 | if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7003 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7004 | VALIDATION_ERROR_02521, "DS", "%s call has push constants index %u with " |
| 7005 | "offset %u. Offset must be a multiple of 4. %s", |
| 7006 | caller_name, index, offset, validation_error_map[VALIDATION_ERROR_02521]); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7007 | } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7008 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7009 | VALIDATION_ERROR_00989, "DS", "%s call has push constants with " |
| 7010 | "offset %u. Offset must be a multiple of 4. %s", |
| 7011 | caller_name, offset, validation_error_map[VALIDATION_ERROR_00989]); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7012 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7013 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 7014 | DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7015 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7016 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7017 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7018 | } |
| 7019 | |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7020 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7021 | CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7022 | const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7023 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7024 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 7025 | // TODO : Add checks for VALIDATION_ERRORS 865-871 |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7026 | // Push Constant Range checks |
Karl Schultz | b7c6d0f | 2016-09-13 14:23:19 -0600 | [diff] [blame] | 7027 | uint32_t i, j; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7028 | for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7029 | skip_call |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, |
| 7030 | pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7031 | if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7032 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7033 | VALIDATION_ERROR_00882, "DS", "vkCreatePipelineLayout() call has no stageFlags set. %s", |
| 7034 | validation_error_map[VALIDATION_ERROR_00882]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7035 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7036 | } |
Karl Schultz | b7c6d0f | 2016-09-13 14:23:19 -0600 | [diff] [blame] | 7037 | if (skip_call) |
| 7038 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 7039 | |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7040 | // Each range has been validated. Now check for overlap between ranges (if they are good). |
Karl Schultz | b7c6d0f | 2016-09-13 14:23:19 -0600 | [diff] [blame] | 7041 | // There's no explicit Valid Usage language against this, so issue a warning instead of an error. |
| 7042 | for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { |
| 7043 | for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { |
| 7044 | const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; |
| 7045 | const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; |
| 7046 | const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; |
| 7047 | const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; |
| 7048 | if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { |
| 7049 | skip_call |= |
| 7050 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 7051 | DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " |
| 7052 | "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", |
| 7053 | i, minA, maxA, j, minB, maxB); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7054 | } |
| 7055 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7056 | } |
Chris Forbes | cf7615e | 2016-05-10 16:02:49 +1200 | [diff] [blame] | 7057 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7058 | VkResult result = dev_data->dispatch_table.CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7059 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7060 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7061 | PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 7062 | plNode.layout = *pPipelineLayout; |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 7063 | plNode.set_layouts.resize(pCreateInfo->setLayoutCount); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7064 | for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 7065 | plNode.set_layouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7066 | } |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 7067 | plNode.push_constant_ranges.resize(pCreateInfo->pushConstantRangeCount); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7068 | for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 7069 | plNode.push_constant_ranges[i] = pCreateInfo->pPushConstantRanges[i]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7070 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7071 | } |
| 7072 | return result; |
| 7073 | } |
| 7074 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7075 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7076 | CreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, |
| 7077 | VkDescriptorPool *pDescriptorPool) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7078 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7079 | VkResult result = dev_data->dispatch_table.CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7080 | if (VK_SUCCESS == result) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7081 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7082 | (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7083 | (uint64_t)*pDescriptorPool)) |
| 7084 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 7085 | DESCRIPTOR_POOL_STATE *pNewNode = new DESCRIPTOR_POOL_STATE(*pDescriptorPool, pCreateInfo); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7086 | if (NULL == pNewNode) { |
| 7087 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, |
| 7088 | (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 7089 | "Out of memory while attempting to allocate DESCRIPTOR_POOL_STATE in vkCreateDescriptorPool()")) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7090 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 7091 | } else { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7092 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7093 | dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7094 | } |
| 7095 | } else { |
| 7096 | // Need to do anything if pool create fails? |
| 7097 | } |
| 7098 | return result; |
| 7099 | } |
| 7100 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7101 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7102 | ResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { |
Tobin Ehlis | 75f04ec | 2016-10-06 17:43:11 -0600 | [diff] [blame] | 7103 | // TODO : Add checks for VALIDATION_ERROR_00928 |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7104 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7105 | VkResult result = dev_data->dispatch_table.ResetDescriptorPool(device, descriptorPool, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7106 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7107 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7108 | clearDescriptorPool(dev_data, device, descriptorPool, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7109 | } |
| 7110 | return result; |
| 7111 | } |
Chris Forbes | b3f6006 | 2016-05-23 11:29:51 +1200 | [diff] [blame] | 7112 | // Ensure the pool contains enough descriptors and descriptor sets to satisfy |
Tobin Ehlis | bdb2800 | 2016-06-01 11:56:42 -0600 | [diff] [blame] | 7113 | // an allocation request. Fills common_data with the total number of descriptors of each type required, |
| 7114 | // as well as DescriptorSetLayout ptrs used for later update. |
Tobin Ehlis | 68d0adf | 2016-06-01 11:33:50 -0600 | [diff] [blame] | 7115 | static bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, |
| 7116 | cvdescriptorset::AllocateDescriptorSetsData *common_data) { |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 7117 | if (dev_data->instance_data->disabled.allocate_descriptor_sets) |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 7118 | return false; |
Tobin Ehlis | ee47146 | 2016-05-26 11:21:59 -0600 | [diff] [blame] | 7119 | // All state checks for AllocateDescriptorSets is done in single function |
Tobin Ehlis | 815e813 | 2016-06-02 13:02:17 -0600 | [diff] [blame] | 7120 | return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data->report_data, pAllocateInfo, dev_data, common_data); |
Tobin Ehlis | ee47146 | 2016-05-26 11:21:59 -0600 | [diff] [blame] | 7121 | } |
| 7122 | // Allocation state was good and call down chain was made so update state based on allocating descriptor sets |
| 7123 | static void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, |
Tobin Ehlis | 68d0adf | 2016-06-01 11:33:50 -0600 | [diff] [blame] | 7124 | VkDescriptorSet *pDescriptorSets, |
| 7125 | const cvdescriptorset::AllocateDescriptorSetsData *common_data) { |
Tobin Ehlis | ee47146 | 2016-05-26 11:21:59 -0600 | [diff] [blame] | 7126 | // All the updates are contained in a single cvdescriptorset function |
Tobin Ehlis | d5fb09e | 2016-06-02 10:54:09 -0600 | [diff] [blame] | 7127 | cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 7128 | &dev_data->setMap, dev_data); |
Chris Forbes | b3f6006 | 2016-05-23 11:29:51 +1200 | [diff] [blame] | 7129 | } |
| 7130 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7131 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7132 | AllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7133 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7134 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 68d0adf | 2016-06-01 11:33:50 -0600 | [diff] [blame] | 7135 | cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); |
| 7136 | bool skip_call = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7137 | lock.unlock(); |
Chris Forbes | 70858bb | 2016-05-20 17:12:39 +1200 | [diff] [blame] | 7138 | |
Tobin Ehlis | ee47146 | 2016-05-26 11:21:59 -0600 | [diff] [blame] | 7139 | if (skip_call) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7140 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | 70858bb | 2016-05-20 17:12:39 +1200 | [diff] [blame] | 7141 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7142 | VkResult result = dev_data->dispatch_table.AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); |
Chris Forbes | bc22feb | 2016-05-20 16:34:01 +1200 | [diff] [blame] | 7143 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7144 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7145 | lock.lock(); |
Tobin Ehlis | 68d0adf | 2016-06-01 11:33:50 -0600 | [diff] [blame] | 7146 | PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7147 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7148 | } |
| 7149 | return result; |
| 7150 | } |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7151 | // Verify state before freeing DescriptorSets |
| 7152 | static bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, |
| 7153 | const VkDescriptorSet *descriptor_sets) { |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 7154 | if (dev_data->instance_data->disabled.free_descriptor_sets) |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 7155 | return false; |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7156 | bool skip_call = false; |
| 7157 | // First make sure sets being destroyed are not currently in-use |
| 7158 | for (uint32_t i = 0; i < count; ++i) |
| 7159 | skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); |
| 7160 | |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 7161 | DESCRIPTOR_POOL_STATE *pool_state = getDescriptorPoolState(dev_data, pool); |
| 7162 | if (pool_state && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_state->createInfo.flags)) { |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7163 | // Can't Free from a NON_FREE pool |
| 7164 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 7165 | reinterpret_cast<uint64_t &>(pool), __LINE__, VALIDATION_ERROR_00922, "DS", |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7166 | "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 7167 | "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT. %s", |
| 7168 | validation_error_map[VALIDATION_ERROR_00922]); |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7169 | } |
| 7170 | return skip_call; |
| 7171 | } |
| 7172 | // Sets have been removed from the pool so update underlying state |
| 7173 | static void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, |
| 7174 | const VkDescriptorSet *descriptor_sets) { |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 7175 | DESCRIPTOR_POOL_STATE *pool_state = getDescriptorPoolState(dev_data, pool); |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7176 | // Update available descriptor sets in pool |
| 7177 | pool_state->availableSets += count; |
| 7178 | |
| 7179 | // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap |
| 7180 | for (uint32_t i = 0; i < count; ++i) { |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7181 | auto descriptor_set = dev_data->setMap[descriptor_sets[i]]; |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7182 | uint32_t type_index = 0, descriptor_count = 0; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7183 | for (uint32_t j = 0; j < descriptor_set->GetBindingCount(); ++j) { |
| 7184 | type_index = static_cast<uint32_t>(descriptor_set->GetTypeFromIndex(j)); |
| 7185 | descriptor_count = descriptor_set->GetDescriptorCountFromIndex(j); |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7186 | pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; |
| 7187 | } |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7188 | freeDescriptorSet(dev_data, descriptor_set); |
| 7189 | pool_state->sets.erase(descriptor_set); |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7190 | } |
| 7191 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7192 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7193 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7194 | FreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7195 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 7196 | // Make sure that no sets being destroyed are in-flight |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7197 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7198 | bool skip_call = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7199 | lock.unlock(); |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 7200 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7201 | if (skip_call) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7202 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7203 | VkResult result = dev_data->dispatch_table.FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7204 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7205 | lock.lock(); |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7206 | PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7207 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7208 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7209 | return result; |
| 7210 | } |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7211 | // TODO : This is a Proof-of-concept for core validation architecture |
| 7212 | // Really we'll want to break out these functions to separate files but |
| 7213 | // keeping it all together here to prove out design |
| 7214 | // PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() |
| 7215 | static bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, |
| 7216 | const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, |
| 7217 | const VkCopyDescriptorSet *pDescriptorCopies) { |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 7218 | if (dev_data->instance_data->disabled.update_descriptor_sets) |
Tobin Ehlis | c67108b | 2016-10-10 11:14:52 -0600 | [diff] [blame] | 7219 | return false; |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7220 | // First thing to do is perform map look-ups. |
| 7221 | // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets |
| 7222 | // so we can't just do a single map look-up up-front, but do them individually in functions below |
| 7223 | |
| 7224 | // Now make call(s) that validate state, but don't perform state updates in this function |
| 7225 | // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the |
| 7226 | // namespace which will parse params and make calls into specific class instances |
Tobin Ehlis | 6a72dc7 | 2016-06-01 16:41:17 -0600 | [diff] [blame] | 7227 | return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, |
| 7228 | descriptorCopyCount, pDescriptorCopies); |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7229 | } |
| 7230 | // PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() |
| 7231 | static void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, |
| 7232 | const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, |
| 7233 | const VkCopyDescriptorSet *pDescriptorCopies) { |
Tobin Ehlis | 6a72dc7 | 2016-06-01 16:41:17 -0600 | [diff] [blame] | 7234 | cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7235 | pDescriptorCopies); |
| 7236 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7237 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7238 | VKAPI_ATTR void VKAPI_CALL |
| 7239 | UpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, |
| 7240 | uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7241 | // Only map look-up at top level is for device-level layer_data |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7242 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7243 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7244 | bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
| 7245 | pDescriptorCopies); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7246 | lock.unlock(); |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7247 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7248 | dev_data->dispatch_table.UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
| 7249 | pDescriptorCopies); |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7250 | lock.lock(); |
| 7251 | // Since UpdateDescriptorSets() is void, nothing to check prior to updating state |
| 7252 | PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
| 7253 | pDescriptorCopies); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7254 | } |
| 7255 | } |
| 7256 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7257 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7258 | AllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7259 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7260 | VkResult result = dev_data->dispatch_table.AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7261 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7262 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | c25c845 | 2016-06-21 14:32:00 +1200 | [diff] [blame] | 7263 | auto pPool = getCommandPoolNode(dev_data, pCreateInfo->commandPool); |
| 7264 | |
| 7265 | if (pPool) { |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7266 | for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7267 | // Add command buffer to its commandPool map |
Chris Forbes | c25c845 | 2016-06-21 14:32:00 +1200 | [diff] [blame] | 7268 | pPool->commandBuffers.push_back(pCommandBuffer[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7269 | GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; |
| 7270 | // Add command buffer to map |
| 7271 | dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; |
| 7272 | resetCB(dev_data, pCommandBuffer[i]); |
| 7273 | pCB->createInfo = *pCreateInfo; |
| 7274 | pCB->device = device; |
| 7275 | } |
| 7276 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7277 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7278 | } |
| 7279 | return result; |
| 7280 | } |
| 7281 | |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 7282 | // Add bindings between the given cmd buffer & framebuffer and the framebuffer's children |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 7283 | static void AddFramebufferBinding(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, FRAMEBUFFER_STATE *fb_state) { |
Tobin Ehlis | e5df29e | 2016-10-12 13:18:20 -0600 | [diff] [blame] | 7284 | addCommandBufferBinding(&fb_state->cb_bindings, |
| 7285 | {reinterpret_cast<uint64_t &>(fb_state->framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}, |
| 7286 | cb_state); |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 7287 | for (auto attachment : fb_state->attachments) { |
| 7288 | auto view_state = attachment.view_state; |
| 7289 | if (view_state) { |
Tobin Ehlis | 15b8ea0 | 2016-09-19 14:02:58 -0600 | [diff] [blame] | 7290 | AddCommandBufferBindingImageView(dev_data, cb_state, view_state); |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 7291 | } |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 7292 | auto rp_state = getRenderPassState(dev_data, fb_state->createInfo.renderPass); |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 7293 | if (rp_state) { |
| 7294 | addCommandBufferBinding( |
| 7295 | &rp_state->cb_bindings, |
| 7296 | {reinterpret_cast<uint64_t &>(rp_state->renderPass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}, cb_state); |
| 7297 | } |
| 7298 | } |
| 7299 | } |
| 7300 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7301 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7302 | BeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7303 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7304 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7305 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7306 | // Validate command buffer level |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7307 | GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); |
| 7308 | if (cb_node) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7309 | // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 7310 | if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7311 | skip_call |= |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 7312 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7313 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_00104, "MEM", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7314 | "Calling vkBeginCommandBuffer() on active command buffer 0x%p before it has completed. " |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7315 | "You must check command buffer fence before this call. %s", |
| 7316 | commandBuffer, validation_error_map[VALIDATION_ERROR_00104]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7317 | } |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7318 | clear_cmd_buf_and_mem_references(dev_data, cb_node); |
| 7319 | if (cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7320 | // Secondary Command Buffer |
| 7321 | const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; |
| 7322 | if (!pInfo) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7323 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7324 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7325 | reinterpret_cast<uint64_t>(commandBuffer), __LINE__, VALIDATION_ERROR_00106, "DS", |
| 7326 | "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info. %s", |
| 7327 | commandBuffer, validation_error_map[VALIDATION_ERROR_00106]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7328 | } else { |
| 7329 | if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { |
Tobin Ehlis | 8fc7df2 | 2017-01-04 09:21:17 -0700 | [diff] [blame] | 7330 | // Object_tracker makes sure these objects are valid |
| 7331 | assert(pInfo->renderPass); |
| 7332 | assert(pInfo->framebuffer); |
| 7333 | string errorString = ""; |
| 7334 | auto framebuffer = getFramebufferState(dev_data, pInfo->framebuffer); |
| 7335 | if (framebuffer) { |
| 7336 | if ((framebuffer->createInfo.renderPass != pInfo->renderPass) && |
| 7337 | !verify_renderpass_compatibility(dev_data, framebuffer->renderPassCreateInfo.ptr(), |
| 7338 | getRenderPassState(dev_data, pInfo->renderPass)->createInfo.ptr(), |
| 7339 | errorString)) { |
| 7340 | // renderPass that framebuffer was created with must be compatible with local renderPass |
| 7341 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7342 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 7343 | reinterpret_cast<uint64_t>(commandBuffer), __LINE__, VALIDATION_ERROR_00112, "DS", |
| 7344 | "vkBeginCommandBuffer(): Secondary Command " |
| 7345 | "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " |
| 7346 | "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s. %s", |
| 7347 | commandBuffer, reinterpret_cast<const uint64_t &>(pInfo->renderPass), |
| 7348 | reinterpret_cast<const uint64_t &>(pInfo->framebuffer), |
| 7349 | reinterpret_cast<uint64_t &>(framebuffer->createInfo.renderPass), |
| 7350 | errorString.c_str(), validation_error_map[VALIDATION_ERROR_00112]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7351 | } |
Tobin Ehlis | 8fc7df2 | 2017-01-04 09:21:17 -0700 | [diff] [blame] | 7352 | // Connect this framebuffer and its children to this cmdBuffer |
| 7353 | AddFramebufferBinding(dev_data, cb_node, framebuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7354 | } |
| 7355 | } |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7356 | if ((pInfo->occlusionQueryEnable == VK_FALSE || dev_data->enabled_features.occlusionQueryPrecise == VK_FALSE) && |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7357 | (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7358 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7359 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7360 | __LINE__, VALIDATION_ERROR_00107, "DS", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7361 | "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " |
| 7362 | "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7363 | "support precise occlusion queries. %s", |
| 7364 | commandBuffer, validation_error_map[VALIDATION_ERROR_00107]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7365 | } |
| 7366 | } |
| 7367 | if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 7368 | auto renderPass = getRenderPassState(dev_data, pInfo->renderPass); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 7369 | if (renderPass) { |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 7370 | if (pInfo->subpass >= renderPass->createInfo.subpassCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7371 | skip_call |= log_msg( |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7372 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7373 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 7374 | VALIDATION_ERROR_00111, "DS", |
| 7375 | "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must have a subpass index (%d) " |
| 7376 | "that is less than the number of subpasses (%d). %s", |
| 7377 | commandBuffer, pInfo->subpass, renderPass->createInfo.subpassCount, |
| 7378 | validation_error_map[VALIDATION_ERROR_00111]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7379 | } |
| 7380 | } |
| 7381 | } |
| 7382 | } |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7383 | if (CB_RECORDING == cb_node->state) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7384 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7385 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7386 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_00103, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 7387 | "vkBeginCommandBuffer(): Cannot call Begin on command buffer (0x%p" |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7388 | ") in the RECORDING state. Must first call vkEndCommandBuffer(). %s", |
| 7389 | commandBuffer, validation_error_map[VALIDATION_ERROR_00103]); |
Chris Forbes | e46e0a1 | 2016-12-20 11:33:11 +1300 | [diff] [blame] | 7390 | } else if (CB_RECORDED == cb_node->state || (CB_INVALID == cb_node->state && CMD_END == cb_node->last_cmd)) { |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7391 | VkCommandPool cmdPool = cb_node->createInfo.commandPool; |
Chris Forbes | c25c845 | 2016-06-21 14:32:00 +1200 | [diff] [blame] | 7392 | auto pPool = getCommandPoolNode(dev_data, cmdPool); |
| 7393 | if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7394 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7395 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7396 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_00105, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 7397 | "Call to vkBeginCommandBuffer() on command buffer (0x%p" |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7398 | ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7399 | ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set. %s", |
| 7400 | commandBuffer, (uint64_t)cmdPool, validation_error_map[VALIDATION_ERROR_00105]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7401 | } |
| 7402 | resetCB(dev_data, commandBuffer); |
| 7403 | } |
| 7404 | // Set updated state here in case implicit reset occurs above |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7405 | cb_node->state = CB_RECORDING; |
| 7406 | cb_node->beginInfo = *pBeginInfo; |
| 7407 | if (cb_node->beginInfo.pInheritanceInfo) { |
| 7408 | cb_node->inheritanceInfo = *(cb_node->beginInfo.pInheritanceInfo); |
| 7409 | cb_node->beginInfo.pInheritanceInfo = &cb_node->inheritanceInfo; |
Mark Young | 75c4359 | 2016-05-06 13:48:26 -0600 | [diff] [blame] | 7410 | // If we are a secondary command-buffer and inheriting. Update the items we should inherit. |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7411 | if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && |
| 7412 | (cb_node->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 7413 | cb_node->activeRenderPass = getRenderPassState(dev_data, cb_node->beginInfo.pInheritanceInfo->renderPass); |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7414 | cb_node->activeSubpass = cb_node->beginInfo.pInheritanceInfo->subpass; |
Tobin Ehlis | 3d91631 | 2016-11-03 07:26:28 -0600 | [diff] [blame] | 7415 | cb_node->activeFramebuffer = cb_node->beginInfo.pInheritanceInfo->framebuffer; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7416 | cb_node->framebuffers.insert(cb_node->beginInfo.pInheritanceInfo->framebuffer); |
Mark Young | 75c4359 | 2016-05-06 13:48:26 -0600 | [diff] [blame] | 7417 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7418 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7419 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7420 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7421 | if (skip_call) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7422 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 7423 | } |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7424 | VkResult result = dev_data->dispatch_table.BeginCommandBuffer(commandBuffer, pBeginInfo); |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 7425 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7426 | return result; |
| 7427 | } |
| 7428 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7429 | VKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7430 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7431 | VkResult result = VK_SUCCESS; |
| 7432 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7433 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7434 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7435 | if (pCB) { |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7436 | if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || |
| 7437 | !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { |
Cody Northrop | 3bb4d96 | 2016-05-09 16:15:57 -0600 | [diff] [blame] | 7438 | // This needs spec clarification to update valid usage, see comments in PR: |
| 7439 | // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 7440 | skip_call |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer()", VALIDATION_ERROR_00123); |
Cody Northrop | 3bb4d96 | 2016-05-09 16:15:57 -0600 | [diff] [blame] | 7441 | } |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7442 | skip_call |= ValidateCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); |
| 7443 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_END); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7444 | for (auto query : pCB->activeQueries) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7445 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7446 | VALIDATION_ERROR_00124, "DS", |
| 7447 | "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d. %s", |
| 7448 | (uint64_t)(query.pool), query.index, validation_error_map[VALIDATION_ERROR_00124]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7449 | } |
| 7450 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7451 | if (!skip_call) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7452 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7453 | result = dev_data->dispatch_table.EndCommandBuffer(commandBuffer); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7454 | lock.lock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7455 | if (VK_SUCCESS == result) { |
| 7456 | pCB->state = CB_RECORDED; |
| 7457 | // Reset CB status flags |
| 7458 | pCB->status = 0; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7459 | } |
| 7460 | } else { |
| 7461 | result = VK_ERROR_VALIDATION_FAILED_EXT; |
| 7462 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7463 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7464 | return result; |
| 7465 | } |
| 7466 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7467 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7468 | ResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 7469 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7470 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7471 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7472 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7473 | VkCommandPool cmdPool = pCB->createInfo.commandPool; |
Chris Forbes | c25c845 | 2016-06-21 14:32:00 +1200 | [diff] [blame] | 7474 | auto pPool = getCommandPoolNode(dev_data, cmdPool); |
| 7475 | if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 7476 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7477 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_00093, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 7478 | "Attempt to reset command buffer (0x%p) created from command pool (0x%" PRIxLEAST64 |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7479 | ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set. %s", |
| 7480 | commandBuffer, (uint64_t)cmdPool, validation_error_map[VALIDATION_ERROR_00093]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7481 | } |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 7482 | skip_call |= checkCommandBufferInFlight(dev_data, pCB, "reset", VALIDATION_ERROR_00092); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7483 | lock.unlock(); |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 7484 | if (skip_call) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7485 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7486 | VkResult result = dev_data->dispatch_table.ResetCommandBuffer(commandBuffer, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7487 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7488 | lock.lock(); |
Chris Forbes | e30fb98 | 2016-06-21 12:35:16 +1200 | [diff] [blame] | 7489 | dev_data->globalInFlightCmdBuffers.erase(commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7490 | resetCB(dev_data, commandBuffer); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7491 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7492 | } |
| 7493 | return result; |
| 7494 | } |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 7495 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7496 | VKAPI_ATTR void VKAPI_CALL |
| 7497 | CmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7498 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7499 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7500 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7501 | GLOBAL_CB_NODE *cb_state = getCBNode(dev_data, commandBuffer); |
| 7502 | if (cb_state) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7503 | skip |= ValidateCmd(dev_data, cb_state, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); |
| 7504 | UpdateCmdBufferLastCmd(dev_data, cb_state, CMD_BINDPIPELINE); |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7505 | if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (cb_state->activeRenderPass)) { |
| 7506 | skip |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7507 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| 7508 | (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7509 | "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7510 | (uint64_t)pipeline, (uint64_t)cb_state->activeRenderPass->renderPass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7511 | } |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7512 | // TODO: VALIDATION_ERROR_00594 VALIDATION_ERROR_00596 |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7513 | |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7514 | PIPELINE_STATE *pipe_state = getPipelineState(dev_data, pipeline); |
| 7515 | if (pipe_state) { |
| 7516 | cb_state->lastBound[pipelineBindPoint].pipeline_state = pipe_state; |
| 7517 | set_cb_pso_status(cb_state, pipe_state); |
| 7518 | set_pipeline_state(pipe_state); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7519 | } else { |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7520 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7521 | (uint64_t)pipeline, __LINE__, VALIDATION_ERROR_00600, "DS", |
| 7522 | "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist! %s", (uint64_t)(pipeline), |
| 7523 | validation_error_map[VALIDATION_ERROR_00600]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7524 | } |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7525 | addCommandBufferBinding(&pipe_state->cb_bindings, |
| 7526 | {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}, cb_state); |
| 7527 | if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { |
| 7528 | // Add binding for child renderpass |
| 7529 | auto rp_state = getRenderPassState(dev_data, pipe_state->graphicsPipelineCI.renderPass); |
| 7530 | if (rp_state) { |
| 7531 | addCommandBufferBinding( |
| 7532 | &rp_state->cb_bindings, |
| 7533 | {reinterpret_cast<uint64_t &>(rp_state->renderPass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}, cb_state); |
| 7534 | } |
| 7535 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7536 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7537 | lock.unlock(); |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7538 | if (!skip) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7539 | dev_data->dispatch_table.CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7540 | } |
| 7541 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7542 | VKAPI_ATTR void VKAPI_CALL |
| 7543 | CmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7544 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7545 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7546 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7547 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7548 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7549 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); |
| 7550 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE); |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 7551 | pCB->viewportMask |= ((1u<<viewportCount) - 1u) << firstViewport; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7552 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7553 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7554 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7555 | dev_data->dispatch_table.CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7556 | } |
| 7557 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7558 | VKAPI_ATTR void VKAPI_CALL |
| 7559 | CmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7560 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7561 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7562 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7563 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7564 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7565 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); |
| 7566 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETSCISSORSTATE); |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 7567 | pCB->scissorMask |= ((1u<<scissorCount) - 1u) << firstScissor; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7568 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7569 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7570 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7571 | dev_data->dispatch_table.CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7572 | } |
| 7573 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7574 | VKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 7575 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7576 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7577 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7578 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7579 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7580 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); |
| 7581 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7582 | pCB->status |= CBSTATUS_LINE_WIDTH_SET; |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 7583 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 7584 | PIPELINE_STATE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_state; |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 7585 | if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { |
| 7586 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7587 | reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, VALIDATION_ERROR_01476, "DS", |
baldurk | 209ccda | 2016-05-05 16:31:05 +0200 | [diff] [blame] | 7588 | "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7589 | "flag. This is undefined behavior and could be ignored. %s", |
| 7590 | validation_error_map[VALIDATION_ERROR_01476]); |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 7591 | } else { |
| 7592 | skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); |
| 7593 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7594 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7595 | lock.unlock(); |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 7596 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7597 | dev_data->dispatch_table.CmdSetLineWidth(commandBuffer, lineWidth); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7598 | } |
| 7599 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7600 | VKAPI_ATTR void VKAPI_CALL |
| 7601 | CmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7602 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7603 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7604 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7605 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7606 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7607 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); |
| 7608 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7609 | pCB->status |= CBSTATUS_DEPTH_BIAS_SET; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7610 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7611 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7612 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7613 | dev_data->dispatch_table.CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, depthBiasSlopeFactor); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7614 | } |
| 7615 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7616 | VKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7617 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7618 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7619 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7620 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7621 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7622 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); |
| 7623 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETBLENDSTATE); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 7624 | pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7625 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7626 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7627 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7628 | dev_data->dispatch_table.CmdSetBlendConstants(commandBuffer, blendConstants); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7629 | } |
| 7630 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7631 | VKAPI_ATTR void VKAPI_CALL |
| 7632 | CmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7633 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7634 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7635 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7636 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7637 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7638 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); |
| 7639 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7640 | pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7641 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7642 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7643 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7644 | dev_data->dispatch_table.CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7645 | } |
| 7646 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7647 | VKAPI_ATTR void VKAPI_CALL |
| 7648 | CmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7649 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7650 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7651 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7652 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7653 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7654 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); |
| 7655 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7656 | pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; |
| 7657 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7658 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7659 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7660 | dev_data->dispatch_table.CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7661 | } |
| 7662 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7663 | VKAPI_ATTR void VKAPI_CALL |
| 7664 | CmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7665 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7666 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7667 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7668 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7669 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7670 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); |
| 7671 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7672 | pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; |
| 7673 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7674 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7675 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7676 | dev_data->dispatch_table.CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7677 | } |
| 7678 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7679 | VKAPI_ATTR void VKAPI_CALL |
| 7680 | CmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7681 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7682 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7683 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7684 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7685 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7686 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); |
| 7687 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7688 | pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; |
| 7689 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7690 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7691 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7692 | dev_data->dispatch_table.CmdSetStencilReference(commandBuffer, faceMask, reference); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7693 | } |
| 7694 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7695 | VKAPI_ATTR void VKAPI_CALL |
| 7696 | CmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, |
| 7697 | uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, |
| 7698 | const uint32_t *pDynamicOffsets) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7699 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7700 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7701 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7702 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7703 | if (pCB) { |
| 7704 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7705 | // Track total count of dynamic descriptor types to make sure we have an offset for each one |
| 7706 | uint32_t totalDynamicDescriptors = 0; |
| 7707 | string errorString = ""; |
| 7708 | uint32_t lastSetIndex = firstSet + setCount - 1; |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7709 | if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7710 | pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7711 | pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); |
| 7712 | } |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 7713 | auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; |
Tobin Ehlis | c1d9be1 | 2016-10-13 10:18:18 -0600 | [diff] [blame] | 7714 | auto pipeline_layout = getPipelineLayout(dev_data, layout); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7715 | for (uint32_t i = 0; i < setCount; i++) { |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7716 | cvdescriptorset::DescriptorSet *descriptor_set = getSetNode(dev_data, pDescriptorSets[i]); |
| 7717 | if (descriptor_set) { |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 7718 | pCB->lastBound[pipelineBindPoint].pipeline_layout = *pipeline_layout; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7719 | pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = descriptor_set; |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7720 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, |
| 7721 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7722 | DRAWSTATE_NONE, "DS", "Descriptor Set 0x%" PRIxLEAST64 " bound on pipeline %s", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7723 | (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7724 | if (!descriptor_set->IsUpdated() && (descriptor_set->GetTotalDescriptorCount() != 0)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7725 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 7726 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, |
| 7727 | DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7728 | "Descriptor Set 0x%" PRIxLEAST64 |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7729 | " bound but it was never updated. You may want to either update it or not bind it.", |
| 7730 | (uint64_t)pDescriptorSets[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7731 | } |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7732 | // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7733 | if (!verify_set_layout_compatibility(dev_data, descriptor_set, pipeline_layout, i + firstSet, errorString)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7734 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7735 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7736 | VALIDATION_ERROR_00974, "DS", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7737 | "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7738 | "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s. %s", |
| 7739 | i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str(), |
| 7740 | validation_error_map[VALIDATION_ERROR_00974]); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7741 | } |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7742 | |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7743 | auto setDynamicDescriptorCount = descriptor_set->GetDynamicDescriptorCount(); |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7744 | |
| 7745 | pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); |
| 7746 | |
| 7747 | if (setDynamicDescriptorCount) { |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7748 | // First make sure we won't overstep bounds of pDynamicOffsets array |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7749 | if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7750 | skip_call |= |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7751 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7752 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, |
| 7753 | DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7754 | "descriptorSet #%u (0x%" PRIxLEAST64 |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7755 | ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " |
| 7756 | "array. There must be one dynamic offset for each dynamic descriptor being bound.", |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7757 | i, (uint64_t)pDescriptorSets[i], descriptor_set->GetDynamicDescriptorCount(), |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7758 | (dynamicOffsetCount - totalDynamicDescriptors)); |
| 7759 | } else { // Validate and store dynamic offsets with the set |
| 7760 | // Validate Dynamic Offset Minimums |
| 7761 | uint32_t cur_dyn_offset = totalDynamicDescriptors; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7762 | for (uint32_t d = 0; d < descriptor_set->GetTotalDescriptorCount(); d++) { |
| 7763 | if (descriptor_set->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7764 | if (vk_safe_modulo( |
| 7765 | pDynamicOffsets[cur_dyn_offset], |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 7766 | dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7767 | skip_call |= log_msg( |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7768 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7769 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, VALIDATION_ERROR_00978, |
| 7770 | "DS", "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " |
| 7771 | "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ". %s", |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7772 | cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7773 | dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, |
| 7774 | validation_error_map[VALIDATION_ERROR_00978]); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7775 | } |
| 7776 | cur_dyn_offset++; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7777 | } else if (descriptor_set->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7778 | if (vk_safe_modulo( |
| 7779 | pDynamicOffsets[cur_dyn_offset], |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 7780 | dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7781 | skip_call |= log_msg( |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7782 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7783 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, VALIDATION_ERROR_00978, |
| 7784 | "DS", "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " |
| 7785 | "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ". %s", |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7786 | cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7787 | dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment, |
| 7788 | validation_error_map[VALIDATION_ERROR_00978]); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7789 | } |
| 7790 | cur_dyn_offset++; |
| 7791 | } |
| 7792 | } |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7793 | |
| 7794 | pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = |
| 7795 | std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, |
| 7796 | pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7797 | // Keep running total of dynamic descriptor count to verify at the end |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7798 | totalDynamicDescriptors += setDynamicDescriptorCount; |
| 7799 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7800 | } |
| 7801 | } |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7802 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7803 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7804 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7805 | DRAWSTATE_INVALID_SET, "DS", "Attempt to bind descriptor set 0x%" PRIxLEAST64 |
| 7806 | " that doesn't exist!", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7807 | (uint64_t)pDescriptorSets[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7808 | } |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7809 | skip_call |= ValidateCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); |
| 7810 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS); |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7811 | // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update |
| 7812 | if (firstSet > 0) { // Check set #s below the first bound set |
| 7813 | for (uint32_t i = 0; i < firstSet; ++i) { |
| 7814 | if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 7815 | !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 7816 | pipeline_layout, i, errorString)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7817 | skip_call |= log_msg( |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7818 | dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 7819 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| 7820 | (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7821 | "DescriptorSet 0x%" PRIxLEAST64 |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7822 | " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7823 | (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); |
| 7824 | pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; |
| 7825 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7826 | } |
| 7827 | } |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7828 | // Check if newly last bound set invalidates any remaining bound sets |
| 7829 | if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { |
| 7830 | if (oldFinalBoundSet && |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 7831 | !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, pipeline_layout, lastSetIndex, errorString)) { |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 7832 | auto old_set = oldFinalBoundSet->GetSet(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7833 | skip_call |= |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7834 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 7835 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7836 | DRAWSTATE_NONE, "DS", "DescriptorSet 0x%" PRIxLEAST64 |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7837 | " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7838 | " newly bound as set #%u so set #%u and any subsequent sets were " |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7839 | "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 7840 | reinterpret_cast<uint64_t &>(old_set), lastSetIndex, |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7841 | (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, |
| 7842 | lastSetIndex + 1, (uint64_t)layout); |
| 7843 | pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); |
| 7844 | } |
| 7845 | } |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7846 | } |
| 7847 | // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound |
| 7848 | if (totalDynamicDescriptors != dynamicOffsetCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7849 | skip_call |= |
| 7850 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7851 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_00975, "DS", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7852 | "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7853 | "is %u. It should exactly match the number of dynamic descriptors. %s", |
| 7854 | setCount, totalDynamicDescriptors, dynamicOffsetCount, validation_error_map[VALIDATION_ERROR_00975]); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7855 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7856 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7857 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7858 | } |
| 7859 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7860 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7861 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7862 | dev_data->dispatch_table.CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, |
| 7863 | pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7864 | } |
| 7865 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7866 | VKAPI_ATTR void VKAPI_CALL |
| 7867 | CmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7868 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7869 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 7870 | // TODO : Somewhere need to verify that IBs have correct usage state flagged |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7871 | std::unique_lock<std::mutex> lock(global_lock); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 7872 | |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7873 | auto buffer_state = getBufferState(dev_data, buffer); |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7874 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7875 | if (cb_node && buffer_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 7876 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buffer_state, "vkCmdBindIndexBuffer()", VALIDATION_ERROR_02543); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 7877 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7878 | return ValidateBufferMemoryIsValid(dev_data, buffer_state, "vkCmdBindIndexBuffer()"); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 7879 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7880 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7881 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); |
| 7882 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7883 | VkDeviceSize offset_align = 0; |
| 7884 | switch (indexType) { |
| 7885 | case VK_INDEX_TYPE_UINT16: |
| 7886 | offset_align = 2; |
| 7887 | break; |
| 7888 | case VK_INDEX_TYPE_UINT32: |
| 7889 | offset_align = 4; |
| 7890 | break; |
| 7891 | default: |
| 7892 | // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 |
| 7893 | break; |
| 7894 | } |
| 7895 | if (!offset_align || (offset % offset_align)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7896 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 7897 | DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", |
| 7898 | "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", |
| 7899 | offset, string_VkIndexType(indexType)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7900 | } |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7901 | cb_node->status |= CBSTATUS_INDEX_BUFFER_BOUND; |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 7902 | } else { |
| 7903 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7904 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7905 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7906 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7907 | dev_data->dispatch_table.CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7908 | } |
| 7909 | |
| 7910 | void updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { |
| 7911 | uint32_t end = firstBinding + bindingCount; |
| 7912 | if (pCB->currentDrawData.buffers.size() < end) { |
| 7913 | pCB->currentDrawData.buffers.resize(end); |
| 7914 | } |
| 7915 | for (uint32_t i = 0; i < bindingCount; ++i) { |
| 7916 | pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; |
| 7917 | } |
| 7918 | } |
| 7919 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 7920 | static inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7921 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7922 | VKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, |
| 7923 | uint32_t bindingCount, const VkBuffer *pBuffers, |
| 7924 | const VkDeviceSize *pOffsets) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7925 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7926 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 7927 | // TODO : Somewhere need to verify that VBs have correct usage state flagged |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7928 | std::unique_lock<std::mutex> lock(global_lock); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 7929 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7930 | auto cb_node = getCBNode(dev_data, commandBuffer); |
| 7931 | if (cb_node) { |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 7932 | for (uint32_t i = 0; i < bindingCount; ++i) { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7933 | auto buffer_state = getBufferState(dev_data, pBuffers[i]); |
| 7934 | assert(buffer_state); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 7935 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buffer_state, "vkCmdBindVertexBuffers()", VALIDATION_ERROR_02546); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 7936 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7937 | return ValidateBufferMemoryIsValid(dev_data, buffer_state, "vkCmdBindVertexBuffers()"); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 7938 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7939 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7940 | } |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7941 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); |
| 7942 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFER); |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7943 | updateResourceTracking(cb_node, firstBinding, bindingCount, pBuffers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7944 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7945 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7946 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7947 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7948 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7949 | dev_data->dispatch_table.CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7950 | } |
| 7951 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 7952 | // Expects global_lock to be held by caller |
Tobin Ehlis | 5558ecb | 2016-12-19 15:16:37 -0700 | [diff] [blame] | 7953 | static void MarkStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { |
Tobin Ehlis | 2e319d4 | 2016-03-25 11:49:51 -0600 | [diff] [blame] | 7954 | for (auto imageView : pCB->updateImages) { |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 7955 | auto view_state = getImageViewState(dev_data, imageView); |
| 7956 | if (!view_state) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7957 | continue; |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 7958 | |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 7959 | auto image_state = getImageState(dev_data, view_state->create_info.image); |
| 7960 | assert(image_state); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 7961 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 7962 | SetImageMemoryValid(dev_data, image_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 7963 | return false; |
Tobin Ehlis | 2e319d4 | 2016-03-25 11:49:51 -0600 | [diff] [blame] | 7964 | }; |
| 7965 | pCB->validate_functions.push_back(function); |
| 7966 | } |
| 7967 | for (auto buffer : pCB->updateBuffers) { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7968 | auto buffer_state = getBufferState(dev_data, buffer); |
| 7969 | assert(buffer_state); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 7970 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7971 | SetBufferMemoryValid(dev_data, buffer_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 7972 | return false; |
Tobin Ehlis | 2e319d4 | 2016-03-25 11:49:51 -0600 | [diff] [blame] | 7973 | }; |
| 7974 | pCB->validate_functions.push_back(function); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7975 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7976 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7977 | |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 7978 | // Generic function to handle validation for all CmdDraw* type functions |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 7979 | static bool ValidateCmdDrawType(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, VkPipelineBindPoint bind_point, |
| 7980 | CMD_TYPE cmd_type, GLOBAL_CB_NODE **cb_state, const char *caller, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 7981 | UNIQUE_VALIDATION_ERROR_CODE msg_code, UNIQUE_VALIDATION_ERROR_CODE const dynamic_state_msg_code) { |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 7982 | bool skip = false; |
| 7983 | *cb_state = getCBNode(dev_data, cmd_buffer); |
| 7984 | if (*cb_state) { |
| 7985 | skip |= ValidateCmd(dev_data, *cb_state, cmd_type, caller); |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 7986 | skip |= ValidateDrawState(dev_data, *cb_state, indexed, bind_point, caller, dynamic_state_msg_code); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 7987 | skip |= (VK_PIPELINE_BIND_POINT_GRAPHICS == bind_point) ? outsideRenderPass(dev_data, *cb_state, caller, msg_code) |
| 7988 | : insideRenderPass(dev_data, *cb_state, caller, msg_code); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 7989 | } |
| 7990 | return skip; |
| 7991 | } |
| 7992 | |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 7993 | // Generic function to handle state update for all CmdDraw* and CmdDispatch* type functions |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 7994 | static void UpdateStateCmdDrawDispatchType(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| 7995 | CMD_TYPE cmd_type) { |
| 7996 | UpdateDrawState(dev_data, cb_state, bind_point); |
Tobin Ehlis | 7afd781 | 2016-12-28 14:24:47 -0700 | [diff] [blame] | 7997 | MarkStoreImagesAndBuffersAsWritten(dev_data, cb_state); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 7998 | UpdateCmdBufferLastCmd(dev_data, cb_state, cmd_type); |
| 7999 | } |
| 8000 | |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8001 | // Generic function to handle state update for all CmdDraw* type functions |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8002 | static void UpdateStateCmdDrawType(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| 8003 | CMD_TYPE cmd_type, DRAW_TYPE draw_type) { |
| 8004 | UpdateStateCmdDrawDispatchType(dev_data, cb_state, bind_point, cmd_type); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8005 | updateResourceTrackingOnDraw(cb_state); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8006 | cb_state->drawCount[draw_type]++; |
| 8007 | } |
| 8008 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8009 | static bool PreCallValidateCmdDraw(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, VkPipelineBindPoint bind_point, |
| 8010 | GLOBAL_CB_NODE **cb_state, const char *caller) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8011 | return ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAW, cb_state, caller, VALIDATION_ERROR_01365, |
| 8012 | VALIDATION_ERROR_02203); |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 8013 | } |
| 8014 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8015 | static void PostCallRecordCmdDraw(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| 8016 | UpdateStateCmdDrawType(dev_data, cb_state, bind_point, CMD_DRAW, DRAW); |
Tobin Ehlis | 1813240 | 2016-12-21 07:52:20 -0700 | [diff] [blame] | 8017 | } |
| 8018 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8019 | VKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, |
| 8020 | uint32_t firstVertex, uint32_t firstInstance) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8021 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 8022 | GLOBAL_CB_NODE *cb_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8023 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8024 | bool skip = PreCallValidateCmdDraw(dev_data, commandBuffer, false, VK_PIPELINE_BIND_POINT_GRAPHICS, &cb_state, "vkCmdDraw()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8025 | lock.unlock(); |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 8026 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8027 | dev_data->dispatch_table.CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); |
Tobin Ehlis | 1813240 | 2016-12-21 07:52:20 -0700 | [diff] [blame] | 8028 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8029 | PostCallRecordCmdDraw(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS); |
Tobin Ehlis | 1813240 | 2016-12-21 07:52:20 -0700 | [diff] [blame] | 8030 | lock.unlock(); |
| 8031 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8032 | } |
| 8033 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8034 | static bool PreCallValidateCmdDrawIndexed(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, |
| 8035 | VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, const char *caller) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8036 | return ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAWINDEXED, cb_state, caller, VALIDATION_ERROR_01372, |
| 8037 | VALIDATION_ERROR_02216); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8038 | } |
| 8039 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8040 | static void PostCallRecordCmdDrawIndexed(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| 8041 | UpdateStateCmdDrawType(dev_data, cb_state, bind_point, CMD_DRAWINDEXED, DRAW_INDEXED); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8042 | } |
| 8043 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8044 | VKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, |
| 8045 | uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8046 | uint32_t firstInstance) { |
| 8047 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8048 | GLOBAL_CB_NODE *cb_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8049 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8050 | bool skip = PreCallValidateCmdDrawIndexed(dev_data, commandBuffer, true, VK_PIPELINE_BIND_POINT_GRAPHICS, &cb_state, |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8051 | "vkCmdDrawIndexed()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8052 | lock.unlock(); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8053 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8054 | dev_data->dispatch_table.CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, firstInstance); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8055 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8056 | PostCallRecordCmdDrawIndexed(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8057 | lock.unlock(); |
| 8058 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8059 | } |
| 8060 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8061 | static bool PreCallValidateCmdDrawIndirect(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkBuffer buffer, bool indexed, |
| 8062 | VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, BUFFER_STATE **buffer_state, |
| 8063 | const char *caller) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8064 | bool skip = ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAWINDIRECT, cb_state, caller, |
| 8065 | VALIDATION_ERROR_01381, VALIDATION_ERROR_02234); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8066 | *buffer_state = getBufferState(dev_data, buffer); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8067 | skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_02544); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8068 | return skip; |
| 8069 | } |
| 8070 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8071 | static void PostCallRecordCmdDrawIndirect(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| 8072 | BUFFER_STATE *buffer_state) { |
| 8073 | UpdateStateCmdDrawType(dev_data, cb_state, bind_point, CMD_DRAWINDIRECT, DRAW_INDIRECT); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8074 | AddCommandBufferBindingBuffer(dev_data, cb_state, buffer_state); |
| 8075 | } |
| 8076 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8077 | VKAPI_ATTR void VKAPI_CALL |
| 8078 | CmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8079 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8080 | GLOBAL_CB_NODE *cb_state = nullptr; |
| 8081 | BUFFER_STATE *buffer_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8082 | std::unique_lock<std::mutex> lock(global_lock); |
Tony Barbour | 0725b0d | 2017-01-06 11:52:50 -0700 | [diff] [blame] | 8083 | bool skip = PreCallValidateCmdDrawIndirect(dev_data, commandBuffer, buffer, false, VK_PIPELINE_BIND_POINT_GRAPHICS, &cb_state, |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8084 | &buffer_state, "vkCmdDrawIndirect()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8085 | lock.unlock(); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8086 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8087 | dev_data->dispatch_table.CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8088 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8089 | PostCallRecordCmdDrawIndirect(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS, buffer_state); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8090 | lock.unlock(); |
| 8091 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8092 | } |
| 8093 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8094 | static bool PreCallValidateCmdDrawIndexedIndirect(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkBuffer buffer, bool indexed, |
| 8095 | VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, |
| 8096 | BUFFER_STATE **buffer_state, const char *caller) { |
| 8097 | bool skip = ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAWINDEXEDINDIRECT, cb_state, caller, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8098 | VALIDATION_ERROR_01393, VALIDATION_ERROR_02272); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8099 | *buffer_state = getBufferState(dev_data, buffer); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8100 | skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_02545); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8101 | return skip; |
| 8102 | } |
| 8103 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8104 | static void PostCallRecordCmdDrawIndexedIndirect(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| 8105 | BUFFER_STATE *buffer_state) { |
| 8106 | UpdateStateCmdDrawType(dev_data, cb_state, bind_point, CMD_DRAWINDEXEDINDIRECT, DRAW_INDEXED_INDIRECT); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8107 | AddCommandBufferBindingBuffer(dev_data, cb_state, buffer_state); |
| 8108 | } |
| 8109 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8110 | VKAPI_ATTR void VKAPI_CALL |
| 8111 | CmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8112 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8113 | GLOBAL_CB_NODE *cb_state = nullptr; |
| 8114 | BUFFER_STATE *buffer_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8115 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8116 | bool skip = PreCallValidateCmdDrawIndexedIndirect(dev_data, commandBuffer, buffer, true, VK_PIPELINE_BIND_POINT_GRAPHICS, |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8117 | &cb_state, &buffer_state, "vkCmdDrawIndexedIndirect()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8118 | lock.unlock(); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8119 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8120 | dev_data->dispatch_table.CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8121 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8122 | PostCallRecordCmdDrawIndexedIndirect(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS, buffer_state); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8123 | lock.unlock(); |
| 8124 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8125 | } |
| 8126 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8127 | static bool PreCallValidateCmdDispatch(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, |
| 8128 | VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, const char *caller) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8129 | return ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DISPATCH, cb_state, caller, VALIDATION_ERROR_01562, |
| 8130 | VALIDATION_ERROR_UNDEFINED); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8131 | } |
| 8132 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8133 | static void PostCallRecordCmdDispatch(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| 8134 | UpdateStateCmdDrawDispatchType(dev_data, cb_state, bind_point, CMD_DISPATCH); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8135 | } |
| 8136 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8137 | VKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8138 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8139 | GLOBAL_CB_NODE *cb_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8140 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8141 | bool skip = |
| 8142 | PreCallValidateCmdDispatch(dev_data, commandBuffer, false, VK_PIPELINE_BIND_POINT_COMPUTE, &cb_state, "vkCmdDispatch()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8143 | lock.unlock(); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8144 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8145 | dev_data->dispatch_table.CmdDispatch(commandBuffer, x, y, z); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8146 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8147 | PostCallRecordCmdDispatch(dev_data, cb_state, VK_PIPELINE_BIND_POINT_COMPUTE); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8148 | lock.unlock(); |
| 8149 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8150 | } |
| 8151 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8152 | static bool PreCallValidateCmdDispatchIndirect(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkBuffer buffer, bool indexed, |
| 8153 | VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, |
| 8154 | BUFFER_STATE **buffer_state, const char *caller) { |
| 8155 | bool skip = ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DISPATCHINDIRECT, cb_state, caller, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8156 | VALIDATION_ERROR_01569, VALIDATION_ERROR_UNDEFINED); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8157 | *buffer_state = getBufferState(dev_data, buffer); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8158 | skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_02547); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8159 | return skip; |
| 8160 | } |
| 8161 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8162 | static void PostCallRecordCmdDispatchIndirect(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| 8163 | BUFFER_STATE *buffer_state) { |
| 8164 | UpdateStateCmdDrawDispatchType(dev_data, cb_state, bind_point, CMD_DISPATCHINDIRECT); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8165 | AddCommandBufferBindingBuffer(dev_data, cb_state, buffer_state); |
| 8166 | } |
| 8167 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8168 | VKAPI_ATTR void VKAPI_CALL |
| 8169 | CmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8170 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8171 | GLOBAL_CB_NODE *cb_state = nullptr; |
| 8172 | BUFFER_STATE *buffer_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8173 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 205f003 | 2016-12-29 11:39:10 -0700 | [diff] [blame] | 8174 | bool skip = PreCallValidateCmdDispatchIndirect(dev_data, commandBuffer, buffer, false, VK_PIPELINE_BIND_POINT_COMPUTE, |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8175 | &cb_state, &buffer_state, "vkCmdDispatchIndirect()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8176 | lock.unlock(); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8177 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8178 | dev_data->dispatch_table.CmdDispatchIndirect(commandBuffer, buffer, offset); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8179 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8180 | PostCallRecordCmdDispatchIndirect(dev_data, cb_state, VK_PIPELINE_BIND_POINT_COMPUTE, buffer_state); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8181 | lock.unlock(); |
| 8182 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8183 | } |
| 8184 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8185 | VKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, |
| 8186 | uint32_t regionCount, const VkBufferCopy *pRegions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8187 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8188 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8189 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8190 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8191 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8192 | auto src_buff_state = getBufferState(dev_data, srcBuffer); |
| 8193 | auto dst_buff_state = getBufferState(dev_data, dstBuffer); |
| 8194 | if (cb_node && src_buff_state && dst_buff_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8195 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_state, "vkCmdCopyBuffer()", VALIDATION_ERROR_02531); |
| 8196 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdCopyBuffer()", VALIDATION_ERROR_02532); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8197 | // Update bindings between buffers and cmd buffer |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8198 | AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_state); |
| 8199 | AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8200 | // Validate that SRC & DST buffers have correct usage flags set |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8201 | skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_state, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8202 | VALIDATION_ERROR_01164, "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8203 | skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8204 | VALIDATION_ERROR_01165, "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8205 | |
| 8206 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8207 | return ValidateBufferMemoryIsValid(dev_data, src_buff_state, "vkCmdCopyBuffer()"); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8208 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8209 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8210 | function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8211 | SetBufferMemoryValid(dev_data, dst_buff_state, true); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8212 | return false; |
| 8213 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8214 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8215 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8216 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); |
| 8217 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_COPYBUFFER); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8218 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBuffer()", VALIDATION_ERROR_01172); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8219 | } else { |
| 8220 | // Param_checker will flag errors on invalid objects, just assert here as debugging aid |
| 8221 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8222 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8223 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8224 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8225 | dev_data->dispatch_table.CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8226 | } |
| 8227 | |
Tobin Ehlis | 6788382 | 2016-07-06 11:23:05 -0600 | [diff] [blame] | 8228 | static bool VerifySourceImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage srcImage, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8229 | VkImageSubresourceLayers subLayers, VkImageLayout srcImageLayout, |
| 8230 | UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8231 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8232 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8233 | for (uint32_t i = 0; i < subLayers.layerCount; ++i) { |
| 8234 | uint32_t layer = i + subLayers.baseArrayLayer; |
| 8235 | VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; |
| 8236 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
Tobin Ehlis | 6788382 | 2016-07-06 11:23:05 -0600 | [diff] [blame] | 8237 | if (!FindLayout(cb_node, srcImage, sub, node)) { |
| 8238 | SetLayout(cb_node, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8239 | continue; |
| 8240 | } |
| 8241 | if (node.layout != srcImageLayout) { |
| 8242 | // TODO: Improve log message in the next pass |
| 8243 | skip_call |= |
| 8244 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 8245 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " |
| 8246 | "and doesn't match the current layout %s.", |
| 8247 | string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); |
| 8248 | } |
| 8249 | } |
| 8250 | if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { |
| 8251 | if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { |
Tobin Ehlis | 4d68626 | 2016-07-06 11:32:12 -0600 | [diff] [blame] | 8252 | // TODO : Can we deal with image node from the top of call tree and avoid map look-up here? |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8253 | auto image_state = getImageState(dev_data, srcImage); |
| 8254 | if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { |
Tobin Ehlis | 4d68626 | 2016-07-06 11:32:12 -0600 | [diff] [blame] | 8255 | // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. |
| 8256 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 8257 | (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
| 8258 | "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); |
| 8259 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8260 | } else { |
| 8261 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8262 | msgCode, "DS", "Layout for input image is %s but can only be TRANSFER_SRC_OPTIMAL or GENERAL. %s", |
| 8263 | string_VkImageLayout(srcImageLayout), validation_error_map[msgCode]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8264 | } |
| 8265 | } |
| 8266 | return skip_call; |
| 8267 | } |
| 8268 | |
Tobin Ehlis | 6788382 | 2016-07-06 11:23:05 -0600 | [diff] [blame] | 8269 | static bool VerifyDestImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage destImage, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8270 | VkImageSubresourceLayers subLayers, VkImageLayout destImageLayout, |
| 8271 | UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8272 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8273 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8274 | for (uint32_t i = 0; i < subLayers.layerCount; ++i) { |
| 8275 | uint32_t layer = i + subLayers.baseArrayLayer; |
| 8276 | VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; |
| 8277 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
Tobin Ehlis | 6788382 | 2016-07-06 11:23:05 -0600 | [diff] [blame] | 8278 | if (!FindLayout(cb_node, destImage, sub, node)) { |
| 8279 | SetLayout(cb_node, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8280 | continue; |
| 8281 | } |
| 8282 | if (node.layout != destImageLayout) { |
| 8283 | skip_call |= |
| 8284 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 8285 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " |
| 8286 | "doesn't match the current layout %s.", |
| 8287 | string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); |
| 8288 | } |
| 8289 | } |
| 8290 | if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { |
| 8291 | if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8292 | auto image_state = getImageState(dev_data, destImage); |
| 8293 | if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { |
Tobin Ehlis | 4d68626 | 2016-07-06 11:32:12 -0600 | [diff] [blame] | 8294 | // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. |
| 8295 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 8296 | (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
| 8297 | "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); |
| 8298 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8299 | } else { |
| 8300 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8301 | msgCode, "DS", "Layout for output image is %s but can only be TRANSFER_DST_OPTIMAL or GENERAL. %s", |
| 8302 | string_VkImageLayout(destImageLayout), validation_error_map[msgCode]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8303 | } |
| 8304 | } |
| 8305 | return skip_call; |
| 8306 | } |
| 8307 | |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8308 | static bool VerifyClearImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage image, VkImageSubresourceRange range, |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8309 | VkImageLayout dest_image_layout, const char *func_name) { |
| 8310 | bool skip = false; |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8311 | |
| 8312 | VkImageSubresourceRange resolvedRange = range; |
| 8313 | ResolveRemainingLevelsLayers(dev_data, &resolvedRange, image); |
| 8314 | |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8315 | if (dest_image_layout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { |
| 8316 | if (dest_image_layout == VK_IMAGE_LAYOUT_GENERAL) { |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8317 | auto image_state = getImageState(dev_data, image); |
| 8318 | if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { |
| 8319 | // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8320 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, |
| 8321 | 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
| 8322 | "%s: Layout for cleared image should be TRANSFER_DST_OPTIMAL instead of GENERAL.", func_name); |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8323 | } |
| 8324 | } else { |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8325 | UNIQUE_VALIDATION_ERROR_CODE error_code = VALIDATION_ERROR_01086; |
| 8326 | if (strcmp(func_name, "vkCmdClearDepthStencilImage()") == 0) { |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8327 | error_code = VALIDATION_ERROR_01101; |
| 8328 | } else { |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8329 | assert(strcmp(func_name, "vkCmdClearColorImage()") == 0); |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8330 | } |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8331 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8332 | error_code, "DS", "%s: Layout for cleared image is %s but can only be " |
| 8333 | "TRANSFER_DST_OPTIMAL or GENERAL. %s", |
| 8334 | func_name, string_VkImageLayout(dest_image_layout), validation_error_map[error_code]); |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8335 | } |
| 8336 | } |
| 8337 | |
Karl Schultz | 537d8c2 | 2016-12-09 16:34:16 -0700 | [diff] [blame] | 8338 | for (uint32_t levelIdx = 0; levelIdx < resolvedRange.levelCount; ++levelIdx) { |
| 8339 | uint32_t level = levelIdx + resolvedRange.baseMipLevel; |
| 8340 | for (uint32_t layerIdx = 0; layerIdx < resolvedRange.layerCount; ++layerIdx) { |
| 8341 | uint32_t layer = layerIdx + resolvedRange.baseArrayLayer; |
| 8342 | VkImageSubresource sub = {resolvedRange.aspectMask, level, layer}; |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8343 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
| 8344 | if (!FindLayout(cb_node, image, sub, node)) { |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8345 | SetLayout(cb_node, image, sub, IMAGE_CMD_BUF_LAYOUT_NODE(dest_image_layout, dest_image_layout)); |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8346 | continue; |
| 8347 | } |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8348 | if (node.layout != dest_image_layout) { |
| 8349 | UNIQUE_VALIDATION_ERROR_CODE error_code = VALIDATION_ERROR_01085; |
| 8350 | if (strcmp(func_name, "vkCmdClearDepthStencilImage()") == 0) { |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8351 | error_code = VALIDATION_ERROR_01100; |
| 8352 | } else { |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8353 | assert(strcmp(func_name, "vkCmdClearColorImage()") == 0); |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8354 | } |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8355 | skip |= |
| 8356 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 8357 | __LINE__, error_code, "DS", "%s: Cannot clear an image whose layout is %s and " |
| 8358 | "doesn't match the current layout %s. %s", |
| 8359 | func_name, string_VkImageLayout(dest_image_layout), string_VkImageLayout(node.layout), |
| 8360 | validation_error_map[error_code]); |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8361 | } |
| 8362 | } |
| 8363 | } |
| 8364 | |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8365 | return skip; |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8366 | } |
| 8367 | |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8368 | // Test if two VkExtent3D structs are equivalent |
| 8369 | static inline bool IsExtentEqual(const VkExtent3D *extent, const VkExtent3D *other_extent) { |
| 8370 | bool result = true; |
| 8371 | if ((extent->width != other_extent->width) || (extent->height != other_extent->height) || |
| 8372 | (extent->depth != other_extent->depth)) { |
| 8373 | result = false; |
| 8374 | } |
| 8375 | return result; |
| 8376 | } |
| 8377 | |
| 8378 | // Returns the image extent of a specific subresource. |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8379 | static inline VkExtent3D GetImageSubresourceExtent(const IMAGE_STATE *img, const VkImageSubresourceLayers *subresource) { |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8380 | const uint32_t mip = subresource->mipLevel; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8381 | VkExtent3D extent = img->createInfo.extent; |
Gregory Mitrano | c730223 | 2016-09-18 23:48:29 -0400 | [diff] [blame] | 8382 | extent.width = std::max(1U, extent.width >> mip); |
| 8383 | extent.height = std::max(1U, extent.height >> mip); |
| 8384 | extent.depth = std::max(1U, extent.depth >> mip); |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8385 | return extent; |
| 8386 | } |
| 8387 | |
| 8388 | // Test if the extent argument has all dimensions set to 0. |
| 8389 | static inline bool IsExtentZero(const VkExtent3D *extent) { |
| 8390 | return ((extent->width == 0) && (extent->height == 0) && (extent->depth == 0)); |
| 8391 | } |
| 8392 | |
| 8393 | // Returns the image transfer granularity for a specific image scaled by compressed block size if necessary. |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8394 | static inline VkExtent3D GetScaledItg(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const IMAGE_STATE *img) { |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8395 | // Default to (0, 0, 0) granularity in case we can't find the real granularity for the physical device. |
| 8396 | VkExtent3D granularity = { 0, 0, 0 }; |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8397 | auto pPool = getCommandPoolNode(dev_data, cb_node->createInfo.commandPool); |
| 8398 | if (pPool) { |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8399 | granularity = dev_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].minImageTransferGranularity; |
| 8400 | if (vk_format_is_compressed(img->createInfo.format)) { |
| 8401 | auto block_size = vk_format_compressed_block_size(img->createInfo.format); |
| 8402 | granularity.width *= block_size.width; |
| 8403 | granularity.height *= block_size.height; |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8404 | } |
| 8405 | } |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8406 | return granularity; |
| 8407 | } |
| 8408 | |
| 8409 | // Test elements of a VkExtent3D structure against alignment constraints contained in another VkExtent3D structure |
| 8410 | static inline bool IsExtentAligned(const VkExtent3D *extent, const VkExtent3D *granularity) { |
| 8411 | bool valid = true; |
| 8412 | if ((vk_safe_modulo(extent->depth, granularity->depth) != 0) || (vk_safe_modulo(extent->width, granularity->width) != 0) || |
| 8413 | (vk_safe_modulo(extent->height, granularity->height) != 0)) { |
| 8414 | valid = false; |
| 8415 | } |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8416 | return valid; |
| 8417 | } |
| 8418 | |
| 8419 | // Check elements of a VkOffset3D structure against a queue family's Image Transfer Granularity values |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8420 | static inline bool CheckItgOffset(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkOffset3D *offset, |
| 8421 | const VkExtent3D *granularity, const uint32_t i, const char *function, const char *member) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8422 | bool skip = false; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8423 | VkExtent3D offset_extent = {}; |
| 8424 | offset_extent.width = static_cast<uint32_t>(abs(offset->x)); |
| 8425 | offset_extent.height = static_cast<uint32_t>(abs(offset->y)); |
| 8426 | offset_extent.depth = static_cast<uint32_t>(abs(offset->z)); |
| 8427 | if (IsExtentZero(granularity)) { |
| 8428 | // If the queue family image transfer granularity is (0, 0, 0), then the offset must always be (0, 0, 0) |
| 8429 | if (IsExtentZero(&offset_extent) == false) { |
| 8430 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8431 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
| 8432 | "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) must be (x=0, y=0, z=0) " |
| 8433 | "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", |
| 8434 | function, i, member, offset->x, offset->y, offset->z); |
| 8435 | } |
| 8436 | } else { |
| 8437 | // If the queue family image transfer granularity is not (0, 0, 0), then the offset dimensions must always be even |
| 8438 | // integer multiples of the image transfer granularity. |
| 8439 | if (IsExtentAligned(&offset_extent, granularity) == false) { |
| 8440 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8441 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
| 8442 | "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) dimensions must be even integer " |
| 8443 | "multiples of this command buffer's queue family image transfer granularity (w=%d, h=%d, d=%d).", |
| 8444 | function, i, member, offset->x, offset->y, offset->z, granularity->width, granularity->height, |
| 8445 | granularity->depth); |
| 8446 | } |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8447 | } |
| 8448 | return skip; |
| 8449 | } |
| 8450 | |
| 8451 | // Check elements of a VkExtent3D structure against a queue family's Image Transfer Granularity values |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8452 | static inline bool CheckItgExtent(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkExtent3D *extent, |
| 8453 | const VkOffset3D *offset, const VkExtent3D *granularity, const VkExtent3D *subresource_extent, |
| 8454 | const uint32_t i, const char *function, const char *member) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8455 | bool skip = false; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8456 | if (IsExtentZero(granularity)) { |
| 8457 | // If the queue family image transfer granularity is (0, 0, 0), then the extent must always match the image |
| 8458 | // subresource extent. |
| 8459 | if (IsExtentEqual(extent, subresource_extent) == false) { |
| 8460 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8461 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
| 8462 | "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d) " |
| 8463 | "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", |
| 8464 | function, i, member, extent->width, extent->height, extent->depth, subresource_extent->width, |
| 8465 | subresource_extent->height, subresource_extent->depth); |
| 8466 | } |
| 8467 | } else { |
| 8468 | // If the queue family image transfer granularity is not (0, 0, 0), then the extent dimensions must always be even |
| 8469 | // integer multiples of the image transfer granularity or the offset + extent dimensions must always match the image |
| 8470 | // subresource extent dimensions. |
| 8471 | VkExtent3D offset_extent_sum = {}; |
| 8472 | offset_extent_sum.width = static_cast<uint32_t>(abs(offset->x)) + extent->width; |
| 8473 | offset_extent_sum.height = static_cast<uint32_t>(abs(offset->y)) + extent->height; |
| 8474 | offset_extent_sum.depth = static_cast<uint32_t>(abs(offset->z)) + extent->depth; |
| 8475 | if ((IsExtentAligned(extent, granularity) == false) && (IsExtentEqual(&offset_extent_sum, subresource_extent) == false)) { |
| 8476 | skip |= |
| 8477 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8478 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8479 | "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) dimensions must be even integer multiples of this command buffer's " |
| 8480 | "queue family image transfer granularity (w=%d, h=%d, d=%d) or offset (x=%d, y=%d, z=%d) + " |
| 8481 | "extent (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d).", |
| 8482 | function, i, member, extent->width, extent->height, extent->depth, granularity->width, granularity->height, |
| 8483 | granularity->depth, offset->x, offset->y, offset->z, extent->width, extent->height, extent->depth, |
| 8484 | subresource_extent->width, subresource_extent->height, subresource_extent->depth); |
| 8485 | } |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8486 | } |
| 8487 | return skip; |
| 8488 | } |
| 8489 | |
| 8490 | // Check a uint32_t width or stride value against a queue family's Image Transfer Granularity width value |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8491 | static inline bool CheckItgInt(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const uint32_t value, |
| 8492 | const uint32_t granularity, const uint32_t i, const char *function, const char *member) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8493 | bool skip = false; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8494 | if (vk_safe_modulo(value, granularity) != 0) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8495 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8496 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8497 | "%s: pRegion[%d].%s (%d) must be an even integer multiple of this command buffer's queue family image " |
| 8498 | "transfer granularity width (%d).", |
| 8499 | function, i, member, value, granularity); |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8500 | } |
| 8501 | return skip; |
| 8502 | } |
| 8503 | |
| 8504 | // Check a VkDeviceSize value against a queue family's Image Transfer Granularity width value |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8505 | static inline bool CheckItgSize(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkDeviceSize value, |
| 8506 | const uint32_t granularity, const uint32_t i, const char *function, const char *member) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8507 | bool skip = false; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8508 | if (vk_safe_modulo(value, granularity) != 0) { |
| 8509 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8510 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
| 8511 | "%s: pRegion[%d].%s (%" PRIdLEAST64 |
| 8512 | ") must be an even integer multiple of this command buffer's queue family image transfer " |
| 8513 | "granularity width (%d).", |
| 8514 | function, i, member, value, granularity); |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8515 | } |
| 8516 | return skip; |
| 8517 | } |
| 8518 | |
| 8519 | // Check valid usage Image Tranfer Granularity requirements for elements of a VkImageCopy structure |
| 8520 | static inline bool ValidateCopyImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8521 | const IMAGE_STATE *img, const VkImageCopy *region, |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8522 | const uint32_t i, const char *function) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8523 | bool skip = false; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8524 | VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); |
| 8525 | skip |= CheckItgOffset(dev_data, cb_node, ®ion->srcOffset, &granularity, i, function, "srcOffset"); |
| 8526 | skip |= CheckItgOffset(dev_data, cb_node, ®ion->dstOffset, &granularity, i, function, "dstOffset"); |
| 8527 | VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->dstSubresource); |
| 8528 | skip |= CheckItgExtent(dev_data, cb_node, ®ion->extent, ®ion->dstOffset, &granularity, &subresource_extent, i, function, |
| 8529 | "extent"); |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8530 | return skip; |
| 8531 | } |
| 8532 | |
| 8533 | // Check valid usage Image Tranfer Granularity requirements for elements of a VkBufferImageCopy structure |
| 8534 | static inline bool ValidateCopyBufferImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8535 | const IMAGE_STATE *img, const VkBufferImageCopy *region, |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8536 | const uint32_t i, const char *function) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8537 | bool skip = false; |
Mark Lobodzinski | a493729 | 2016-12-09 11:20:23 -0700 | [diff] [blame] | 8538 | if (vk_format_is_compressed(img->createInfo.format) == true) { |
| 8539 | // TODO: Add granularity checking for compressed formats |
| 8540 | |
| 8541 | // bufferRowLength must be a multiple of the compressed texel block width |
| 8542 | // bufferImageHeight must be a multiple of the compressed texel block height |
| 8543 | // all members of imageOffset must be a multiple of the corresponding dimensions of the compressed texel block |
| 8544 | // bufferOffset must be a multiple of the compressed texel block size in bytes |
| 8545 | // imageExtent.width must be a multiple of the compressed texel block width or (imageExtent.width + imageOffset.x) |
| 8546 | // must equal the image subresource width |
| 8547 | // imageExtent.height must be a multiple of the compressed texel block height or (imageExtent.height + imageOffset.y) |
| 8548 | // must equal the image subresource height |
| 8549 | // imageExtent.depth must be a multiple of the compressed texel block depth or (imageExtent.depth + imageOffset.z) |
| 8550 | // must equal the image subresource depth |
| 8551 | } else { |
| 8552 | VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); |
| 8553 | skip |= CheckItgSize(dev_data, cb_node, region->bufferOffset, granularity.width, i, function, "bufferOffset"); |
| 8554 | skip |= CheckItgInt(dev_data, cb_node, region->bufferRowLength, granularity.width, i, function, "bufferRowLength"); |
| 8555 | skip |= CheckItgInt(dev_data, cb_node, region->bufferImageHeight, granularity.width, i, function, "bufferImageHeight"); |
| 8556 | skip |= CheckItgOffset(dev_data, cb_node, ®ion->imageOffset, &granularity, i, function, "imageOffset"); |
| 8557 | VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->imageSubresource); |
| 8558 | skip |= CheckItgExtent(dev_data, cb_node, ®ion->imageExtent, ®ion->imageOffset, &granularity, &subresource_extent, i, |
| 8559 | function, "imageExtent"); |
| 8560 | } |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8561 | return skip; |
| 8562 | } |
| 8563 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8564 | VKAPI_ATTR void VKAPI_CALL |
| 8565 | CmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, |
| 8566 | VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8567 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8568 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8569 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8570 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8571 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8572 | auto src_image_state = getImageState(dev_data, srcImage); |
| 8573 | auto dst_image_state = getImageState(dev_data, dstImage); |
| 8574 | if (cb_node && src_image_state && dst_image_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8575 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdCopyImage()", VALIDATION_ERROR_02533); |
| 8576 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdCopyImage()", VALIDATION_ERROR_02534); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8577 | // Update bindings between images and cmd buffer |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8578 | AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); |
| 8579 | AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8580 | // Validate that SRC & DST images have correct usage flags set |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8581 | skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, |
| 8582 | VALIDATION_ERROR_01178, "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); |
| 8583 | skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, |
| 8584 | VALIDATION_ERROR_01181, "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8585 | std::function<bool()> function = [=]() { |
| 8586 | return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdCopyImage()"); |
| 8587 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8588 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8589 | function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8590 | SetImageMemoryValid(dev_data, dst_image_state, true); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8591 | return false; |
| 8592 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8593 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8594 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8595 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_COPYIMAGE, "vkCmdCopyImage()"); |
| 8596 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_COPYIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8597 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImage()", VALIDATION_ERROR_01194); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8598 | for (uint32_t i = 0; i < regionCount; ++i) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8599 | skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].srcSubresource, srcImageLayout, |
| 8600 | VALIDATION_ERROR_01180); |
| 8601 | skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].dstSubresource, dstImageLayout, |
| 8602 | VALIDATION_ERROR_01183); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8603 | skip_call |= ValidateCopyImageTransferGranularityRequirements(dev_data, cb_node, dst_image_state, &pRegions[i], i, |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8604 | "vkCmdCopyImage()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8605 | } |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8606 | } else { |
| 8607 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8608 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8609 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8610 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8611 | dev_data->dispatch_table.CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, |
| 8612 | pRegions); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8613 | } |
| 8614 | |
Mark Lobodzinski | 1850d07 | 2016-08-23 15:10:36 -0600 | [diff] [blame] | 8615 | // Validate that an image's sampleCount matches the requirement for a specific API call |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8616 | static inline bool ValidateImageSampleCount(layer_data *dev_data, IMAGE_STATE *image_state, VkSampleCountFlagBits sample_count, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8617 | const char *location, UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Mark Lobodzinski | 1850d07 | 2016-08-23 15:10:36 -0600 | [diff] [blame] | 8618 | bool skip = false; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8619 | if (image_state->createInfo.samples != sample_count) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8620 | skip = |
| 8621 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 8622 | reinterpret_cast<uint64_t &>(image_state->image), 0, msgCode, "DS", |
| 8623 | "%s for image 0x%" PRIxLEAST64 " was created with a sample count of %s but must be %s. %s", location, |
| 8624 | reinterpret_cast<uint64_t &>(image_state->image), string_VkSampleCountFlagBits(image_state->createInfo.samples), |
| 8625 | string_VkSampleCountFlagBits(sample_count), validation_error_map[msgCode]); |
Mark Lobodzinski | 1850d07 | 2016-08-23 15:10:36 -0600 | [diff] [blame] | 8626 | } |
| 8627 | return skip; |
| 8628 | } |
| 8629 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8630 | VKAPI_ATTR void VKAPI_CALL |
| 8631 | CmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, |
| 8632 | VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8633 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8634 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8635 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8636 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8637 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8638 | auto src_image_state = getImageState(dev_data, srcImage); |
| 8639 | auto dst_image_state = getImageState(dev_data, dstImage); |
| 8640 | if (cb_node && src_image_state && dst_image_state) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8641 | skip_call |= ValidateImageSampleCount(dev_data, src_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): srcImage", |
| 8642 | VALIDATION_ERROR_02194); |
| 8643 | skip_call |= ValidateImageSampleCount(dev_data, dst_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): dstImage", |
| 8644 | VALIDATION_ERROR_02195); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8645 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdBlitImage()", VALIDATION_ERROR_02539); |
| 8646 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdBlitImage()", VALIDATION_ERROR_02540); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8647 | // Update bindings between images and cmd buffer |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8648 | AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); |
| 8649 | AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8650 | // Validate that SRC & DST images have correct usage flags set |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8651 | skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, |
| 8652 | VALIDATION_ERROR_02182, "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); |
| 8653 | skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, |
| 8654 | VALIDATION_ERROR_02186, "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8655 | std::function<bool()> function = [=]() { |
| 8656 | return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdBlitImage()"); |
| 8657 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8658 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8659 | function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8660 | SetImageMemoryValid(dev_data, dst_image_state, true); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8661 | return false; |
| 8662 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8663 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8664 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8665 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_BLITIMAGE, "vkCmdBlitImage()"); |
| 8666 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_BLITIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8667 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBlitImage()", VALIDATION_ERROR_01300); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8668 | } else { |
| 8669 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8670 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8671 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8672 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8673 | dev_data->dispatch_table.CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, |
| 8674 | pRegions, filter); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8675 | } |
| 8676 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8677 | VKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, |
| 8678 | VkImage dstImage, VkImageLayout dstImageLayout, |
| 8679 | uint32_t regionCount, const VkBufferImageCopy *pRegions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8680 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8681 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8682 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8683 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8684 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8685 | auto src_buff_state = getBufferState(dev_data, srcBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8686 | auto dst_image_state = getImageState(dev_data, dstImage); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8687 | if (cb_node && src_buff_state && dst_image_state) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8688 | skip_call |= ValidateImageSampleCount(dev_data, dst_image_state, VK_SAMPLE_COUNT_1_BIT, |
| 8689 | "vkCmdCopyBufferToImage(): dstImage", VALIDATION_ERROR_01232); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8690 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_state, "vkCmdCopyBufferToImage()", VALIDATION_ERROR_02535); |
| 8691 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdCopyBufferToImage()", VALIDATION_ERROR_02536); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8692 | AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_state); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8693 | AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8694 | skip_call |= |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8695 | ValidateBufferUsageFlags(dev_data, src_buff_state, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, VALIDATION_ERROR_01230, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8696 | "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8697 | skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8698 | VALIDATION_ERROR_01231, "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8699 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8700 | SetImageMemoryValid(dev_data, dst_image_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8701 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8702 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8703 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8704 | function = [=]() { return ValidateBufferMemoryIsValid(dev_data, src_buff_state, "vkCmdCopyBufferToImage()"); }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8705 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8706 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8707 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); |
| 8708 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_COPYBUFFERTOIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8709 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBufferToImage()", VALIDATION_ERROR_01242); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8710 | for (uint32_t i = 0; i < regionCount; ++i) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8711 | skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].imageSubresource, dstImageLayout, |
| 8712 | VALIDATION_ERROR_01234); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8713 | skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, dst_image_state, &pRegions[i], i, |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8714 | "vkCmdCopyBufferToImage()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8715 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8716 | } else { |
| 8717 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8718 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8719 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8720 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8721 | dev_data->dispatch_table.CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8722 | } |
| 8723 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8724 | VKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, |
| 8725 | VkImageLayout srcImageLayout, VkBuffer dstBuffer, |
| 8726 | uint32_t regionCount, const VkBufferImageCopy *pRegions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8727 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8728 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8729 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8730 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8731 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8732 | auto src_image_state = getImageState(dev_data, srcImage); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8733 | auto dst_buff_state = getBufferState(dev_data, dstBuffer); |
| 8734 | if (cb_node && src_image_state && dst_buff_state) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8735 | skip_call |= ValidateImageSampleCount(dev_data, src_image_state, VK_SAMPLE_COUNT_1_BIT, |
| 8736 | "vkCmdCopyImageToBuffer(): srcImage", VALIDATION_ERROR_01249); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8737 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdCopyImageToBuffer()", VALIDATION_ERROR_02537); |
| 8738 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdCopyImageToBuffer()", VALIDATION_ERROR_02538); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8739 | // Update bindings between buffer/image and cmd buffer |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8740 | AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8741 | AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8742 | // Validate that SRC image & DST buffer have correct usage flags set |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8743 | skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8744 | VALIDATION_ERROR_01248, "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); |
| 8745 | skip_call |= |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8746 | ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, VALIDATION_ERROR_01252, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8747 | "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8748 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8749 | return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdCopyImageToBuffer()"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8750 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8751 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8752 | function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8753 | SetBufferMemoryValid(dev_data, dst_buff_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8754 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8755 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8756 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8757 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8758 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); |
| 8759 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_COPYIMAGETOBUFFER); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8760 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImageToBuffer()", VALIDATION_ERROR_01260); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8761 | for (uint32_t i = 0; i < regionCount; ++i) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8762 | skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].imageSubresource, srcImageLayout, |
| 8763 | VALIDATION_ERROR_01251); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8764 | skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, src_image_state, &pRegions[i], i, |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8765 | "CmdCopyImageToBuffer"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8766 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8767 | } else { |
| 8768 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8769 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8770 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8771 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8772 | dev_data->dispatch_table.CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8773 | } |
| 8774 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8775 | VKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, |
| 8776 | VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8777 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8778 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8779 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8780 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8781 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8782 | auto dst_buff_state = getBufferState(dev_data, dstBuffer); |
| 8783 | if (cb_node && dst_buff_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8784 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdUpdateBuffer()", VALIDATION_ERROR_02530); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8785 | // Update bindings between buffer and cmd buffer |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8786 | AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8787 | // Validate that DST buffer has correct usage flags set |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8788 | skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8789 | VALIDATION_ERROR_01146, "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8790 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8791 | SetBufferMemoryValid(dev_data, dst_buff_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8792 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8793 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8794 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8795 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8796 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); |
| 8797 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_UPDATEBUFFER); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8798 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdUpdateBuffer()", VALIDATION_ERROR_01155); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8799 | } else { |
| 8800 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8801 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8802 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8803 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8804 | dev_data->dispatch_table.CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8805 | } |
| 8806 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8807 | VKAPI_ATTR void VKAPI_CALL |
| 8808 | CmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8809 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8810 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8811 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8812 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8813 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8814 | auto dst_buff_state = getBufferState(dev_data, dstBuffer); |
| 8815 | if (cb_node && dst_buff_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8816 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdFillBuffer()", VALIDATION_ERROR_02529); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8817 | // Update bindings between buffer and cmd buffer |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8818 | AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8819 | // Validate that DST buffer has correct usage flags set |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8820 | skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8821 | VALIDATION_ERROR_01137, "vkCmdFillBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8822 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8823 | SetBufferMemoryValid(dev_data, dst_buff_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8824 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8825 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8826 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8827 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8828 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_FILLBUFFER, "vkCmdFillBuffer()"); |
| 8829 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_FILLBUFFER); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8830 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdFillBuffer()", VALIDATION_ERROR_01142); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8831 | } else { |
| 8832 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8833 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8834 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8835 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8836 | dev_data->dispatch_table.CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8837 | } |
| 8838 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8839 | VKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, |
| 8840 | const VkClearAttachment *pAttachments, uint32_t rectCount, |
| 8841 | const VkClearRect *pRects) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8842 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8843 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8844 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8845 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 8846 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8847 | skip_call |= ValidateCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); |
| 8848 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_CLEARATTACHMENTS); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8849 | // Warn if this is issued prior to Draw Cmd and clearing the entire attachment |
| 8850 | if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && |
| 8851 | (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8852 | // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) |
| 8853 | // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must |
| 8854 | // call CmdClearAttachments |
| 8855 | // Otherwise this seems more like a performance warning. |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8856 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 8857 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(commandBuffer), 0, |
| 8858 | DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", |
| 8859 | "vkCmdClearAttachments() issued on command buffer object 0x%p prior to any Draw Cmds." |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8860 | " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 8861 | commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8862 | } |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8863 | skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments()", VALIDATION_ERROR_01122); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8864 | } |
| 8865 | |
| 8866 | // Validate that attachment is in reference list of active subpass |
| 8867 | if (pCB->activeRenderPass) { |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 8868 | const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->createInfo.ptr(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8869 | const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; |
Chris Forbes | 34a09d4 | 2016-10-26 12:40:31 +1300 | [diff] [blame] | 8870 | auto framebuffer = getFramebufferState(dev_data, pCB->activeFramebuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8871 | |
Chris Forbes | 7f49835 | 2016-10-25 16:32:54 +1300 | [diff] [blame] | 8872 | for (uint32_t i = 0; i < attachmentCount; i++) { |
| 8873 | auto clear_desc = &pAttachments[i]; |
Chris Forbes | 34a09d4 | 2016-10-26 12:40:31 +1300 | [diff] [blame] | 8874 | VkImageView image_view = VK_NULL_HANDLE; |
| 8875 | |
Chris Forbes | 7f49835 | 2016-10-25 16:32:54 +1300 | [diff] [blame] | 8876 | if (clear_desc->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { |
| 8877 | if (clear_desc->colorAttachment >= pSD->colorAttachmentCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8878 | skip_call |= log_msg( |
Chris Forbes | da6ae6f | 2016-09-09 14:36:33 +1200 | [diff] [blame] | 8879 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Chris Forbes | e762945 | 2016-10-27 09:32:34 +1300 | [diff] [blame] | 8880 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_01114, "DS", |
| 8881 | "vkCmdClearAttachments() color attachment index %d out of range for active subpass %d. %s", |
| 8882 | clear_desc->colorAttachment, pCB->activeSubpass, validation_error_map[VALIDATION_ERROR_01114]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8883 | } |
Chris Forbes | 7f49835 | 2016-10-25 16:32:54 +1300 | [diff] [blame] | 8884 | else if (pSD->pColorAttachments[clear_desc->colorAttachment].attachment == VK_ATTACHMENT_UNUSED) { |
Chris Forbes | e9b624e | 2016-09-08 15:30:59 +1200 | [diff] [blame] | 8885 | skip_call |= log_msg( |
Chris Forbes | e762945 | 2016-10-27 09:32:34 +1300 | [diff] [blame] | 8886 | dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Chris Forbes | e9b624e | 2016-09-08 15:30:59 +1200 | [diff] [blame] | 8887 | (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", |
Chris Forbes | e762945 | 2016-10-27 09:32:34 +1300 | [diff] [blame] | 8888 | "vkCmdClearAttachments() color attachment index %d is VK_ATTACHMENT_UNUSED; ignored.", |
Chris Forbes | 7f49835 | 2016-10-25 16:32:54 +1300 | [diff] [blame] | 8889 | clear_desc->colorAttachment); |
Chris Forbes | e9b624e | 2016-09-08 15:30:59 +1200 | [diff] [blame] | 8890 | } |
Chris Forbes | 34a09d4 | 2016-10-26 12:40:31 +1300 | [diff] [blame] | 8891 | else { |
| 8892 | image_view = framebuffer->createInfo.pAttachments[pSD->pColorAttachments[clear_desc->colorAttachment].attachment]; |
| 8893 | } |
Chris Forbes | 7f49835 | 2016-10-25 16:32:54 +1300 | [diff] [blame] | 8894 | } else if (clear_desc->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8895 | if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass |
| 8896 | (pSD->pDepthStencilAttachment->attachment == |
| 8897 | VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass |
| 8898 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8899 | skip_call |= log_msg( |
Chris Forbes | e762945 | 2016-10-27 09:32:34 +1300 | [diff] [blame] | 8900 | dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8901 | (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", |
Chris Forbes | 98198eb | 2016-09-08 15:35:36 +1200 | [diff] [blame] | 8902 | "vkCmdClearAttachments() depth/stencil clear with no depth/stencil attachment in subpass; ignored"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8903 | } |
Chris Forbes | 34a09d4 | 2016-10-26 12:40:31 +1300 | [diff] [blame] | 8904 | else { |
| 8905 | image_view = framebuffer->createInfo.pAttachments[pSD->pDepthStencilAttachment->attachment]; |
| 8906 | } |
| 8907 | } |
| 8908 | |
| 8909 | if (image_view) { |
| 8910 | auto image_view_state = getImageViewState(dev_data, image_view); |
| 8911 | auto aspects_present = image_view_state->create_info.subresourceRange.aspectMask; |
| 8912 | auto extra_aspects = clear_desc->aspectMask & ~aspects_present; |
Tobin Ehlis | 48fbd69 | 2017-01-04 09:17:01 -0700 | [diff] [blame] | 8913 | // TODO: This is a different check than 01125. Need a new valid usage statement for this case, or should kill check. |
Chris Forbes | 34a09d4 | 2016-10-26 12:40:31 +1300 | [diff] [blame] | 8914 | if (extra_aspects) { |
| 8915 | skip_call |= log_msg( |
| 8916 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, |
Chris Forbes | e762945 | 2016-10-27 09:32:34 +1300 | [diff] [blame] | 8917 | reinterpret_cast<uint64_t &>(image_view), __LINE__, VALIDATION_ERROR_01125, "DS", |
| 8918 | "vkCmdClearAttachments() with aspects not present in image view: %s. %s", |
| 8919 | string_VkImageAspectFlagBits((VkImageAspectFlagBits)extra_aspects), |
| 8920 | validation_error_map[VALIDATION_ERROR_01125]); |
Chris Forbes | 34a09d4 | 2016-10-26 12:40:31 +1300 | [diff] [blame] | 8921 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8922 | } |
| 8923 | } |
| 8924 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8925 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8926 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8927 | dev_data->dispatch_table.CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8928 | } |
| 8929 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8930 | VKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, |
| 8931 | VkImageLayout imageLayout, const VkClearColorValue *pColor, |
| 8932 | uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8933 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8934 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8935 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8936 | // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8937 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8938 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8939 | auto image_state = getImageState(dev_data, image); |
| 8940 | if (cb_node && image_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8941 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCmdClearColorImage()", VALIDATION_ERROR_02527); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8942 | AddCommandBufferBindingImage(dev_data, cb_node, image_state); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8943 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8944 | SetImageMemoryValid(dev_data, image_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8945 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8946 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8947 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8948 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8949 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); |
| 8950 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_CLEARCOLORIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8951 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearColorImage()", VALIDATION_ERROR_01096); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8952 | } else { |
| 8953 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8954 | } |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8955 | for (uint32_t i = 0; i < rangeCount; ++i) { |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8956 | skip_call |= VerifyClearImageLayout(dev_data, cb_node, image, pRanges[i], imageLayout, "vkCmdClearColorImage()"); |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8957 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8958 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8959 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8960 | dev_data->dispatch_table.CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8961 | } |
| 8962 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8963 | VKAPI_ATTR void VKAPI_CALL |
| 8964 | CmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| 8965 | const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, |
| 8966 | const VkImageSubresourceRange *pRanges) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8967 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8968 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8969 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8970 | // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8971 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8972 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8973 | auto image_state = getImageState(dev_data, image); |
| 8974 | if (cb_node && image_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8975 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCmdClearDepthStencilImage()", VALIDATION_ERROR_02528); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8976 | AddCommandBufferBindingImage(dev_data, cb_node, image_state); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8977 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8978 | SetImageMemoryValid(dev_data, image_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8979 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8980 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8981 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8982 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8983 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); |
| 8984 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8985 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearDepthStencilImage()", VALIDATION_ERROR_01111); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8986 | } else { |
| 8987 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8988 | } |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8989 | for (uint32_t i = 0; i < rangeCount; ++i) { |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8990 | skip_call |= VerifyClearImageLayout(dev_data, cb_node, image, pRanges[i], imageLayout, "vkCmdClearDepthStencilImage()"); |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8991 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8992 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8993 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8994 | dev_data->dispatch_table.CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, pRanges); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8995 | } |
| 8996 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8997 | VKAPI_ATTR void VKAPI_CALL |
| 8998 | CmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, |
| 8999 | VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9000 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9001 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9002 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 9003 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9004 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9005 | auto src_image_state = getImageState(dev_data, srcImage); |
| 9006 | auto dst_image_state = getImageState(dev_data, dstImage); |
| 9007 | if (cb_node && src_image_state && dst_image_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 9008 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdResolveImage()", VALIDATION_ERROR_02541); |
| 9009 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdResolveImage()", VALIDATION_ERROR_02542); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 9010 | // Update bindings between images and cmd buffer |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9011 | AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); |
| 9012 | AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9013 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9014 | return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdResolveImage()"); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 9015 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9016 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 9017 | function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9018 | SetImageMemoryValid(dev_data, dst_image_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9019 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9020 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9021 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 9022 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9023 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); |
| 9024 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_RESOLVEIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9025 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdResolveImage()", VALIDATION_ERROR_01335); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 9026 | } else { |
| 9027 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9028 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9029 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9030 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9031 | dev_data->dispatch_table.CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, |
| 9032 | pRegions); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9033 | } |
| 9034 | |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9035 | bool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { |
| 9036 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 9037 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9038 | if (pCB) { |
| 9039 | pCB->eventToStageMap[event] = stageMask; |
| 9040 | } |
| 9041 | auto queue_data = dev_data->queueMap.find(queue); |
| 9042 | if (queue_data != dev_data->queueMap.end()) { |
| 9043 | queue_data->second.eventToStageMap[event] = stageMask; |
| 9044 | } |
| 9045 | return false; |
| 9046 | } |
| 9047 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9048 | VKAPI_ATTR void VKAPI_CALL |
| 9049 | CmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9050 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9051 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9052 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9053 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9054 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9055 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); |
| 9056 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETEVENT); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9057 | skip_call |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent()", VALIDATION_ERROR_00238); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 9058 | auto event_state = getEventNode(dev_data, event); |
| 9059 | if (event_state) { |
| 9060 | addCommandBufferBinding(&event_state->cb_bindings, |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9061 | {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 9062 | event_state->cb_bindings.insert(pCB); |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9063 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9064 | pCB->events.push_back(event); |
Michael Lentine | 860b0fe | 2016-05-20 10:14:00 -0500 | [diff] [blame] | 9065 | if (!pCB->waitedEvents.count(event)) { |
| 9066 | pCB->writeEventsBeforeWait.push_back(event); |
| 9067 | } |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9068 | std::function<bool(VkQueue)> eventUpdate = |
| 9069 | std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); |
| 9070 | pCB->eventUpdates.push_back(eventUpdate); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9071 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9072 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9073 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9074 | dev_data->dispatch_table.CmdSetEvent(commandBuffer, event, stageMask); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9075 | } |
| 9076 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9077 | VKAPI_ATTR void VKAPI_CALL |
| 9078 | CmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9079 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9080 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9081 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9082 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9083 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9084 | skip_call |= ValidateCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); |
| 9085 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_RESETEVENT); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9086 | skip_call |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent()", VALIDATION_ERROR_00249); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 9087 | auto event_state = getEventNode(dev_data, event); |
| 9088 | if (event_state) { |
| 9089 | addCommandBufferBinding(&event_state->cb_bindings, |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9090 | {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 9091 | event_state->cb_bindings.insert(pCB); |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9092 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9093 | pCB->events.push_back(event); |
Michael Lentine | 860b0fe | 2016-05-20 10:14:00 -0500 | [diff] [blame] | 9094 | if (!pCB->waitedEvents.count(event)) { |
| 9095 | pCB->writeEventsBeforeWait.push_back(event); |
| 9096 | } |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9097 | std::function<bool(VkQueue)> eventUpdate = |
| 9098 | std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); |
| 9099 | pCB->eventUpdates.push_back(eventUpdate); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9100 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9101 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9102 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9103 | dev_data->dispatch_table.CmdResetEvent(commandBuffer, event, stageMask); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9104 | } |
| 9105 | |
Alex Smith | c4659e4 | 2017-01-10 09:51:22 +0000 | [diff] [blame] | 9106 | static bool TransitionImageAspectLayout(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkImageMemoryBarrier *mem_barrier, |
| 9107 | uint32_t level, uint32_t layer, VkImageAspectFlags aspect) |
| 9108 | { |
| 9109 | if (!(mem_barrier->subresourceRange.aspectMask & aspect)) { |
| 9110 | return false; |
| 9111 | } |
| 9112 | VkImageSubresource sub = {aspect, level, layer}; |
| 9113 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
| 9114 | if (!FindLayout(pCB, mem_barrier->image, sub, node)) { |
| 9115 | SetLayout(pCB, mem_barrier->image, sub, |
| 9116 | IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); |
| 9117 | return false; |
| 9118 | } |
| 9119 | bool skip = false; |
| 9120 | if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { |
| 9121 | // TODO: Set memory invalid which is in mem_tracker currently |
| 9122 | } else if (node.layout != mem_barrier->oldLayout) { |
| 9123 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 9124 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
| 9125 | "You cannot transition the layout of aspect %d from %s when current layout is %s.", |
| 9126 | aspect, string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); |
| 9127 | } |
| 9128 | SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); |
| 9129 | return skip; |
| 9130 | } |
| 9131 | |
Mark Lobodzinski | 0c5e804 | 2016-12-12 08:33:13 -0700 | [diff] [blame] | 9132 | // TODO: Separate validation and layout state updates |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9133 | static bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, |
| 9134 | const VkImageMemoryBarrier *pImgMemBarriers) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9135 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 9136 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9137 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9138 | uint32_t levelCount = 0; |
| 9139 | uint32_t layerCount = 0; |
| 9140 | |
| 9141 | for (uint32_t i = 0; i < memBarrierCount; ++i) { |
| 9142 | auto mem_barrier = &pImgMemBarriers[i]; |
| 9143 | if (!mem_barrier) |
| 9144 | continue; |
| 9145 | // TODO: Do not iterate over every possibility - consolidate where |
| 9146 | // possible |
| 9147 | ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); |
| 9148 | |
| 9149 | for (uint32_t j = 0; j < levelCount; j++) { |
| 9150 | uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; |
| 9151 | for (uint32_t k = 0; k < layerCount; k++) { |
| 9152 | uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; |
Alex Smith | c4659e4 | 2017-01-10 09:51:22 +0000 | [diff] [blame] | 9153 | skip |= TransitionImageAspectLayout(dev_data, pCB, mem_barrier, level, layer, VK_IMAGE_ASPECT_COLOR_BIT); |
| 9154 | skip |= TransitionImageAspectLayout(dev_data, pCB, mem_barrier, level, layer, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 9155 | skip |= TransitionImageAspectLayout(dev_data, pCB, mem_barrier, level, layer, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 9156 | skip |= TransitionImageAspectLayout(dev_data, pCB, mem_barrier, level, layer, VK_IMAGE_ASPECT_METADATA_BIT); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9157 | } |
| 9158 | } |
| 9159 | } |
| 9160 | return skip; |
| 9161 | } |
| 9162 | |
| 9163 | // Print readable FlagBits in FlagMask |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9164 | static std::string string_VkAccessFlags(VkAccessFlags accessMask) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9165 | std::string result; |
| 9166 | std::string separator; |
| 9167 | |
| 9168 | if (accessMask == 0) { |
| 9169 | result = "[None]"; |
| 9170 | } else { |
| 9171 | result = "["; |
| 9172 | for (auto i = 0; i < 32; i++) { |
| 9173 | if (accessMask & (1 << i)) { |
| 9174 | result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); |
| 9175 | separator = " | "; |
| 9176 | } |
| 9177 | } |
| 9178 | result = result + "]"; |
| 9179 | } |
| 9180 | return result; |
| 9181 | } |
| 9182 | |
| 9183 | // AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. |
| 9184 | // If required_bit is zero, accessMask must have at least one of 'optional_bits' set |
| 9185 | // TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9186 | static bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, |
| 9187 | const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, |
| 9188 | const char *type) { |
| 9189 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9190 | |
| 9191 | if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { |
Chris Forbes | 9b21a85 | 2016-05-06 18:07:09 +1200 | [diff] [blame] | 9192 | if (accessMask & ~(required_bit | optional_bits)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9193 | // TODO: Verify against Valid Use |
| 9194 | skip_call |= |
| 9195 | log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | 6fb205c | 2016-05-23 13:45:36 -0600 | [diff] [blame] | 9196 | DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9197 | type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); |
| 9198 | } |
| 9199 | } else { |
| 9200 | if (!required_bit) { |
Michael Lentine | 0250823 | 2016-04-13 17:12:57 -0500 | [diff] [blame] | 9201 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9202 | DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " |
| 9203 | "%s when layout is %s, unless the app has previously added a " |
| 9204 | "barrier for this transition.", |
| 9205 | type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, |
| 9206 | string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); |
| 9207 | } else { |
| 9208 | std::string opt_bits; |
| 9209 | if (optional_bits != 0) { |
| 9210 | std::stringstream ss; |
| 9211 | ss << optional_bits; |
| 9212 | opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); |
| 9213 | } |
Michael Lentine | 0250823 | 2016-04-13 17:12:57 -0500 | [diff] [blame] | 9214 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9215 | DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " |
| 9216 | "layout is %s, unless the app has previously added a barrier for " |
| 9217 | "this transition.", |
| 9218 | type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, |
| 9219 | string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); |
| 9220 | } |
| 9221 | } |
| 9222 | return skip_call; |
| 9223 | } |
| 9224 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9225 | static bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, |
| 9226 | const VkImageLayout &layout, const char *type) { |
| 9227 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9228 | switch (layout) { |
| 9229 | case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { |
| 9230 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, |
Jan-Harald Fredriksen | def6033 | 2016-10-21 15:14:16 +0200 | [diff] [blame] | 9231 | VK_ACCESS_COLOR_ATTACHMENT_READ_BIT | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT, type); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9232 | break; |
| 9233 | } |
| 9234 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { |
| 9235 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, |
Jan-Harald Fredriksen | def6033 | 2016-10-21 15:14:16 +0200 | [diff] [blame] | 9236 | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT, type); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9237 | break; |
| 9238 | } |
| 9239 | case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { |
| 9240 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); |
| 9241 | break; |
| 9242 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9243 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { |
| 9244 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, |
Jan-Harald Fredriksen | def6033 | 2016-10-21 15:14:16 +0200 | [diff] [blame] | 9245 | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | |
| 9246 | VK_ACCESS_SHADER_READ_BIT | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT, type); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9247 | break; |
| 9248 | } |
| 9249 | case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { |
| 9250 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, |
| 9251 | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); |
| 9252 | break; |
| 9253 | } |
| 9254 | case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { |
| 9255 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); |
| 9256 | break; |
| 9257 | } |
Tony Barbour | c0676ef | 2016-09-29 13:41:49 -0600 | [diff] [blame] | 9258 | case VK_IMAGE_LAYOUT_PRESENT_SRC_KHR: { |
| 9259 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_MEMORY_READ_BIT, 0, type); |
| 9260 | break; |
| 9261 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9262 | case VK_IMAGE_LAYOUT_UNDEFINED: { |
| 9263 | if (accessMask != 0) { |
| 9264 | // TODO: Verify against Valid Use section spec |
| 9265 | skip_call |= |
| 9266 | log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | 6fb205c | 2016-05-23 13:45:36 -0600 | [diff] [blame] | 9267 | DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9268 | type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); |
| 9269 | } |
| 9270 | break; |
| 9271 | } |
| 9272 | case VK_IMAGE_LAYOUT_GENERAL: |
| 9273 | default: { break; } |
| 9274 | } |
| 9275 | return skip_call; |
| 9276 | } |
| 9277 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9278 | static bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, |
| 9279 | const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, |
| 9280 | const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, |
| 9281 | const VkImageMemoryBarrier *pImageMemBarriers) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9282 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9283 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 9284 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); |
| 9285 | if (pCB->activeRenderPass && memBarrierCount) { |
Chris Forbes | a4937a7 | 2016-05-06 16:31:14 +1200 | [diff] [blame] | 9286 | if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9287 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9288 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " |
| 9289 | "with no self dependency specified.", |
| 9290 | funcName, pCB->activeSubpass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9291 | } |
| 9292 | } |
| 9293 | for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { |
| 9294 | auto mem_barrier = &pImageMemBarriers[i]; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9295 | auto image_data = getImageState(dev_data, mem_barrier->image); |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 9296 | if (image_data) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9297 | uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; |
| 9298 | uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 9299 | if (image_data->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9300 | // srcQueueFamilyIndex and dstQueueFamilyIndex must both |
| 9301 | // be VK_QUEUE_FAMILY_IGNORED |
| 9302 | if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9303 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 9304 | __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", |
| 9305 | "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " |
| 9306 | "VK_SHARING_MODE_CONCURRENT. Src and dst " |
| 9307 | "queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", |
| 9308 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9309 | } |
| 9310 | } else { |
| 9311 | // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and |
| 9312 | // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, |
| 9313 | // or both be a valid queue family |
| 9314 | if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && |
| 9315 | (src_q_f_index != dst_q_f_index)) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9316 | skip |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9317 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9318 | DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " |
| 9319 | "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " |
| 9320 | "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " |
| 9321 | "must be.", |
| 9322 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); |
| 9323 | } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 9324 | ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || |
| 9325 | (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9326 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 9327 | __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", |
| 9328 | "%s: Image 0x%" PRIx64 " was created with sharingMode " |
| 9329 | "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" |
| 9330 | " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER |
| 9331 | "queueFamilies crated for this device.", |
| 9332 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, dst_q_f_index, |
| 9333 | dev_data->phys_dev_properties.queue_family_properties.size()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9334 | } |
| 9335 | } |
| 9336 | } |
| 9337 | |
| 9338 | if (mem_barrier) { |
Tony Barbour | 14740bb | 2016-10-04 12:03:50 -0600 | [diff] [blame] | 9339 | if (mem_barrier->oldLayout != mem_barrier->newLayout) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9340 | skip |= |
Tony Barbour | 14740bb | 2016-10-04 12:03:50 -0600 | [diff] [blame] | 9341 | ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9342 | skip |= |
Tony Barbour | 14740bb | 2016-10-04 12:03:50 -0600 | [diff] [blame] | 9343 | ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); |
| 9344 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9345 | if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9346 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9347 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " |
| 9348 | "PREINITIALIZED.", |
| 9349 | funcName); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9350 | } |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9351 | auto image_data = getImageState(dev_data, mem_barrier->image); |
Jamie Madill | 2b6b8d5 | 2016-04-04 15:09:51 -0400 | [diff] [blame] | 9352 | VkFormat format = VK_FORMAT_UNDEFINED; |
| 9353 | uint32_t arrayLayers = 0, mipLevels = 0; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9354 | bool imageFound = false; |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 9355 | if (image_data) { |
| 9356 | format = image_data->createInfo.format; |
| 9357 | arrayLayers = image_data->createInfo.arrayLayers; |
| 9358 | mipLevels = image_data->createInfo.mipLevels; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9359 | imageFound = true; |
| 9360 | } else if (dev_data->device_extensions.wsi_enabled) { |
Tobin Ehlis | 969a526 | 2016-06-02 12:13:32 -0600 | [diff] [blame] | 9361 | auto imageswap_data = getSwapchainFromImage(dev_data, mem_barrier->image); |
| 9362 | if (imageswap_data) { |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 9363 | auto swapchain_data = getSwapchainNode(dev_data, imageswap_data); |
| 9364 | if (swapchain_data) { |
| 9365 | format = swapchain_data->createInfo.imageFormat; |
| 9366 | arrayLayers = swapchain_data->createInfo.imageArrayLayers; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9367 | mipLevels = 1; |
| 9368 | imageFound = true; |
| 9369 | } |
| 9370 | } |
| 9371 | } |
| 9372 | if (imageFound) { |
Tobin Ehlis | d7e548b | 2016-07-19 17:39:34 -0600 | [diff] [blame] | 9373 | auto aspect_mask = mem_barrier->subresourceRange.aspectMask; |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9374 | skip |= ValidateImageAspectMask(dev_data, image_data->image, format, aspect_mask, funcName); |
Michael Lentine | 87e44e0 | 2016-03-18 14:49:09 -0500 | [diff] [blame] | 9375 | int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) |
| 9376 | ? 1 |
| 9377 | : mem_barrier->subresourceRange.layerCount; |
| 9378 | if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9379 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 9380 | __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " |
| 9381 | "baseArrayLayer (%d) and layerCount (%d) be less " |
| 9382 | "than or equal to the total number of layers (%d).", |
| 9383 | funcName, mem_barrier->subresourceRange.baseArrayLayer, |
| 9384 | mem_barrier->subresourceRange.layerCount, arrayLayers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9385 | } |
Michael Lentine | 87e44e0 | 2016-03-18 14:49:09 -0500 | [diff] [blame] | 9386 | int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) |
| 9387 | ? 1 |
| 9388 | : mem_barrier->subresourceRange.levelCount; |
| 9389 | if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9390 | skip |= log_msg( |
| 9391 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9392 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " |
| 9393 | "(%d) and levelCount (%d) be less than or equal to " |
| 9394 | "the total number of levels (%d).", |
| 9395 | funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, mipLevels); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9396 | } |
| 9397 | } |
| 9398 | } |
| 9399 | } |
| 9400 | for (uint32_t i = 0; i < bufferBarrierCount; ++i) { |
| 9401 | auto mem_barrier = &pBufferMemBarriers[i]; |
| 9402 | if (pCB->activeRenderPass) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9403 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9404 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9405 | } |
| 9406 | if (!mem_barrier) |
| 9407 | continue; |
| 9408 | |
| 9409 | // Validate buffer barrier queue family indices |
| 9410 | if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 9411 | mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9412 | (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 9413 | mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9414 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9415 | DRAWSTATE_INVALID_QUEUE_INDEX, "DS", |
| 9416 | "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " |
| 9417 | "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", |
| 9418 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), |
| 9419 | dev_data->phys_dev_properties.queue_family_properties.size()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9420 | } |
| 9421 | |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 9422 | auto buffer_state = getBufferState(dev_data, mem_barrier->buffer); |
| 9423 | if (buffer_state) { |
| 9424 | auto buffer_size = buffer_state->requirements.size; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9425 | if (mem_barrier->offset >= buffer_size) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9426 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9427 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 |
| 9428 | " which is not less than total size 0x%" PRIx64 ".", |
| 9429 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), |
| 9430 | reinterpret_cast<const uint64_t &>(mem_barrier->offset), |
| 9431 | reinterpret_cast<const uint64_t &>(buffer_size)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9432 | } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9433 | skip |= log_msg( |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 9434 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 9435 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 |
| 9436 | " whose sum is greater than total size 0x%" PRIx64 ".", |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 9437 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), |
| 9438 | reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), |
| 9439 | reinterpret_cast<const uint64_t &>(buffer_size)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9440 | } |
| 9441 | } |
| 9442 | } |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9443 | return skip; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9444 | } |
| 9445 | |
Chris Forbes | f321eba | 2016-03-31 11:22:37 +1300 | [diff] [blame] | 9446 | bool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9447 | bool skip_call = false; |
| 9448 | VkPipelineStageFlags stageMask = 0; |
| 9449 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
| 9450 | for (uint32_t i = 0; i < eventCount; ++i) { |
Chris Forbes | f321eba | 2016-03-31 11:22:37 +1300 | [diff] [blame] | 9451 | auto event = pCB->events[firstEventIndex + i]; |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9452 | auto queue_data = dev_data->queueMap.find(queue); |
| 9453 | if (queue_data == dev_data->queueMap.end()) |
| 9454 | return false; |
Chris Forbes | f321eba | 2016-03-31 11:22:37 +1300 | [diff] [blame] | 9455 | auto event_data = queue_data->second.eventToStageMap.find(event); |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9456 | if (event_data != queue_data->second.eventToStageMap.end()) { |
| 9457 | stageMask |= event_data->second; |
| 9458 | } else { |
Tobin Ehlis | cab6b7d | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9459 | auto global_event_data = getEventNode(dev_data, event); |
| 9460 | if (!global_event_data) { |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9461 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, |
Chris Forbes | 0fa9221 | 2016-03-31 11:47:29 +1300 | [diff] [blame] | 9462 | reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", |
| 9463 | "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", |
Chris Forbes | f321eba | 2016-03-31 11:22:37 +1300 | [diff] [blame] | 9464 | reinterpret_cast<const uint64_t &>(event)); |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9465 | } else { |
Tobin Ehlis | cab6b7d | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9466 | stageMask |= global_event_data->stageMask; |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9467 | } |
| 9468 | } |
| 9469 | } |
Michael Lentine | 860b0fe | 2016-05-20 10:14:00 -0500 | [diff] [blame] | 9470 | // TODO: Need to validate that host_bit is only set if set event is called |
| 9471 | // but set event can be called at any time. |
| 9472 | if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { |
| 9473 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9474 | VALIDATION_ERROR_00254, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " |
| 9475 | "using srcStageMask 0x%X which must be the bitwise " |
| 9476 | "OR of the stageMask parameters used in calls to " |
| 9477 | "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " |
| 9478 | "used with vkSetEvent but instead is 0x%X. %s", |
| 9479 | sourceStageMask, stageMask, validation_error_map[VALIDATION_ERROR_00254]); |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9480 | } |
| 9481 | return skip_call; |
| 9482 | } |
| 9483 | |
Mark Lobodzinski | e6ce3f6 | 2016-12-10 10:53:34 -0700 | [diff] [blame] | 9484 | // Note that we only check bits that HAVE required queueflags -- don't care entries are skipped |
| 9485 | static std::unordered_map<VkPipelineStageFlags, VkQueueFlags> supported_pipeline_stages_table = { |
| 9486 | {VK_PIPELINE_STAGE_COMMAND_PROCESS_BIT_NVX, VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT}, |
| 9487 | {VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT, VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT}, |
| 9488 | {VK_PIPELINE_STAGE_VERTEX_INPUT_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9489 | {VK_PIPELINE_STAGE_VERTEX_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9490 | {VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9491 | {VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9492 | {VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9493 | {VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9494 | {VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9495 | {VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9496 | {VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9497 | {VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, VK_QUEUE_COMPUTE_BIT}, |
| 9498 | {VK_PIPELINE_STAGE_TRANSFER_BIT, VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT}, |
| 9499 | {VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT, VK_QUEUE_GRAPHICS_BIT}}; |
| 9500 | |
| 9501 | static const VkPipelineStageFlags stage_flag_bit_array[] = {VK_PIPELINE_STAGE_COMMAND_PROCESS_BIT_NVX, |
| 9502 | VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT, |
| 9503 | VK_PIPELINE_STAGE_VERTEX_INPUT_BIT, |
| 9504 | VK_PIPELINE_STAGE_VERTEX_SHADER_BIT, |
| 9505 | VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT, |
| 9506 | VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT, |
| 9507 | VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT, |
| 9508 | VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT, |
| 9509 | VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT, |
| 9510 | VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, |
| 9511 | VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, |
| 9512 | VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, |
| 9513 | VK_PIPELINE_STAGE_TRANSFER_BIT, |
| 9514 | VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT}; |
| 9515 | |
| 9516 | bool CheckStageMaskQueueCompatibility(layer_data *dev_data, VkCommandBuffer command_buffer, VkPipelineStageFlags stage_mask, |
| 9517 | VkQueueFlags queue_flags, const char *function, const char *src_or_dest, |
| 9518 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| 9519 | bool skip = false; |
| 9520 | // Lookup each bit in the stagemask and check for overlap between its table bits and queue_flags |
| 9521 | for (const auto &item : stage_flag_bit_array) { |
| 9522 | if (stage_mask & item) { |
| 9523 | if ((supported_pipeline_stages_table[item] & queue_flags) == 0) { |
| 9524 | skip |= |
| 9525 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 9526 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, error_code, "DL", |
| 9527 | "%s(): %s flag %s is not compatible with the queue family properties of this " |
| 9528 | "command buffer. %s", |
| 9529 | function, src_or_dest, string_VkPipelineStageFlagBits(static_cast<VkPipelineStageFlagBits>(item)), |
| 9530 | validation_error_map[error_code]); |
| 9531 | } |
| 9532 | } |
| 9533 | } |
| 9534 | return skip; |
| 9535 | } |
| 9536 | |
| 9537 | bool ValidateStageMasksAgainstQueueCapabilities(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, |
| 9538 | VkPipelineStageFlags source_stage_mask, VkPipelineStageFlags dest_stage_mask, |
| 9539 | const char *function, UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| 9540 | bool skip = false; |
| 9541 | uint32_t queue_family_index = dev_data->commandPoolMap[cb_state->createInfo.commandPool].queueFamilyIndex; |
| 9542 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(dev_data->physical_device), instance_layer_data_map); |
| 9543 | auto physical_device_state = getPhysicalDeviceState(instance_data, dev_data->physical_device); |
| 9544 | |
| 9545 | // Any pipeline stage included in srcStageMask or dstStageMask must be supported by the capabilities of the queue family |
| 9546 | // specified by the queueFamilyIndex member of the VkCommandPoolCreateInfo structure that was used to create the VkCommandPool |
| 9547 | // that commandBuffer was allocated from, as specified in the table of supported pipeline stages. |
| 9548 | |
| 9549 | if (queue_family_index < physical_device_state->queue_family_properties.size()) { |
| 9550 | VkQueueFlags specified_queue_flags = physical_device_state->queue_family_properties[queue_family_index].queueFlags; |
| 9551 | |
| 9552 | if ((source_stage_mask & VK_PIPELINE_STAGE_ALL_COMMANDS_BIT) == 0) { |
| 9553 | skip |= CheckStageMaskQueueCompatibility(dev_data, cb_state->commandBuffer, source_stage_mask, specified_queue_flags, |
| 9554 | function, "srcStageMask", error_code); |
| 9555 | } |
| 9556 | if ((dest_stage_mask & VK_PIPELINE_STAGE_ALL_COMMANDS_BIT) == 0) { |
| 9557 | skip |= CheckStageMaskQueueCompatibility(dev_data, cb_state->commandBuffer, dest_stage_mask, specified_queue_flags, |
| 9558 | function, "dstStageMask", error_code); |
| 9559 | } |
| 9560 | } |
| 9561 | return skip; |
| 9562 | } |
| 9563 | |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9564 | VKAPI_ATTR void VKAPI_CALL CmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, |
| 9565 | VkPipelineStageFlags sourceStageMask, VkPipelineStageFlags dstStageMask, |
| 9566 | uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, |
| 9567 | uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, |
| 9568 | uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { |
| 9569 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9570 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9571 | std::unique_lock<std::mutex> lock(global_lock); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9572 | GLOBAL_CB_NODE *cb_state = getCBNode(dev_data, commandBuffer); |
| 9573 | if (cb_state) { |
| 9574 | skip |= ValidateStageMasksAgainstQueueCapabilities(dev_data, cb_state, sourceStageMask, dstStageMask, "vkCmdWaitEvents", |
| 9575 | VALIDATION_ERROR_02510); |
| 9576 | auto first_event_index = cb_state->events.size(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9577 | for (uint32_t i = 0; i < eventCount; ++i) { |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 9578 | auto event_state = getEventNode(dev_data, pEvents[i]); |
| 9579 | if (event_state) { |
| 9580 | addCommandBufferBinding(&event_state->cb_bindings, |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9581 | {reinterpret_cast<const uint64_t &>(pEvents[i]), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9582 | cb_state); |
| 9583 | event_state->cb_bindings.insert(cb_state); |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9584 | } |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9585 | cb_state->waitedEvents.insert(pEvents[i]); |
| 9586 | cb_state->events.push_back(pEvents[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9587 | } |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9588 | std::function<bool(VkQueue)> event_update = |
| 9589 | std::bind(validateEventStageMask, std::placeholders::_1, cb_state, eventCount, first_event_index, sourceStageMask); |
| 9590 | cb_state->eventUpdates.push_back(event_update); |
| 9591 | if (cb_state->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9592 | skip |= ValidateCmd(dev_data, cb_state, CMD_WAITEVENTS, "vkCmdWaitEvents()"); |
| 9593 | UpdateCmdBufferLastCmd(dev_data, cb_state, CMD_WAITEVENTS); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9594 | } else { |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9595 | skip |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9596 | } |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9597 | skip |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); |
| 9598 | skip |= ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, |
| 9599 | pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9600 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9601 | lock.unlock(); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9602 | if (!skip) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9603 | dev_data->dispatch_table.CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, |
| 9604 | memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, |
| 9605 | imageMemoryBarrierCount, pImageMemoryBarriers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9606 | } |
| 9607 | |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9608 | VKAPI_ATTR void VKAPI_CALL CmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, |
| 9609 | VkPipelineStageFlags dstStageMask, VkDependencyFlags dependencyFlags, |
| 9610 | uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, |
| 9611 | uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, |
| 9612 | uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { |
| 9613 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9614 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9615 | std::unique_lock<std::mutex> lock(global_lock); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9616 | GLOBAL_CB_NODE *cb_state = getCBNode(dev_data, commandBuffer); |
| 9617 | if (cb_state) { |
| 9618 | skip |= ValidateStageMasksAgainstQueueCapabilities(dev_data, cb_state, srcStageMask, dstStageMask, "vkCmdPipelineBarrier", |
| 9619 | VALIDATION_ERROR_02513); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9620 | skip |= ValidateCmd(dev_data, cb_state, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); |
| 9621 | UpdateCmdBufferLastCmd(dev_data, cb_state, CMD_PIPELINEBARRIER); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9622 | skip |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); |
| 9623 | skip |= ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, |
| 9624 | bufferMemoryBarrierCount, pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9625 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9626 | lock.unlock(); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9627 | if (!skip) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9628 | dev_data->dispatch_table.CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, memoryBarrierCount, |
| 9629 | pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, |
| 9630 | imageMemoryBarrierCount, pImageMemoryBarriers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9631 | } |
| 9632 | |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9633 | bool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { |
| 9634 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 9635 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9636 | if (pCB) { |
| 9637 | pCB->queryToStateMap[object] = value; |
| 9638 | } |
| 9639 | auto queue_data = dev_data->queueMap.find(queue); |
| 9640 | if (queue_data != dev_data->queueMap.end()) { |
| 9641 | queue_data->second.queryToStateMap[object] = value; |
| 9642 | } |
| 9643 | return false; |
| 9644 | } |
| 9645 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9646 | VKAPI_ATTR void VKAPI_CALL |
| 9647 | CmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9648 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9649 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9650 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9651 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9652 | if (pCB) { |
| 9653 | QueryObject query = {queryPool, slot}; |
| 9654 | pCB->activeQueries.insert(query); |
| 9655 | if (!pCB->startedQueries.count(query)) { |
| 9656 | pCB->startedQueries.insert(query); |
| 9657 | } |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9658 | skip_call |= ValidateCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); |
| 9659 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_BEGINQUERY); |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 9660 | addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| 9661 | {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9662 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9663 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9664 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9665 | dev_data->dispatch_table.CmdBeginQuery(commandBuffer, queryPool, slot, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9666 | } |
| 9667 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9668 | VKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9669 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9670 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9671 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9672 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9673 | if (pCB) { |
| 9674 | QueryObject query = {queryPool, slot}; |
| 9675 | if (!pCB->activeQueries.count(query)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9676 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9677 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9678 | VALIDATION_ERROR_01041, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d. %s", |
| 9679 | (uint64_t)(queryPool), slot, validation_error_map[VALIDATION_ERROR_01041]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9680 | } else { |
| 9681 | pCB->activeQueries.erase(query); |
| 9682 | } |
Karl Schultz | 63c1eb5 | 2016-05-24 13:49:59 -0600 | [diff] [blame] | 9683 | std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9684 | pCB->queryUpdates.push_back(queryUpdate); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9685 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9686 | skip_call |= ValidateCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); |
| 9687 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_ENDQUERY); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9688 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9689 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9690 | } |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 9691 | addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| 9692 | {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9693 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9694 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9695 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9696 | dev_data->dispatch_table.CmdEndQuery(commandBuffer, queryPool, slot); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9697 | } |
| 9698 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9699 | VKAPI_ATTR void VKAPI_CALL |
| 9700 | CmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9701 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9702 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9703 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9704 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9705 | if (pCB) { |
| 9706 | for (uint32_t i = 0; i < queryCount; i++) { |
| 9707 | QueryObject query = {queryPool, firstQuery + i}; |
| 9708 | pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; |
Karl Schultz | 63c1eb5 | 2016-05-24 13:49:59 -0600 | [diff] [blame] | 9709 | std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9710 | pCB->queryUpdates.push_back(queryUpdate); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9711 | } |
| 9712 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9713 | skip_call |= ValidateCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); |
| 9714 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_RESETQUERYPOOL); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9715 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9716 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9717 | } |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9718 | skip_call |= insideRenderPass(dev_data, pCB, "vkCmdResetQueryPool()", VALIDATION_ERROR_01025); |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 9719 | addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| 9720 | {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9721 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9722 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9723 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9724 | dev_data->dispatch_table.CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9725 | } |
| 9726 | |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9727 | bool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { |
| 9728 | bool skip_call = false; |
| 9729 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); |
| 9730 | auto queue_data = dev_data->queueMap.find(queue); |
| 9731 | if (queue_data == dev_data->queueMap.end()) |
| 9732 | return false; |
| 9733 | for (uint32_t i = 0; i < queryCount; i++) { |
| 9734 | QueryObject query = {queryPool, firstQuery + i}; |
| 9735 | auto query_data = queue_data->second.queryToStateMap.find(query); |
| 9736 | bool fail = false; |
| 9737 | if (query_data != queue_data->second.queryToStateMap.end()) { |
| 9738 | if (!query_data->second) { |
| 9739 | fail = true; |
| 9740 | } |
| 9741 | } else { |
| 9742 | auto global_query_data = dev_data->queryToStateMap.find(query); |
| 9743 | if (global_query_data != dev_data->queryToStateMap.end()) { |
| 9744 | if (!global_query_data->second) { |
| 9745 | fail = true; |
| 9746 | } |
| 9747 | } else { |
| 9748 | fail = true; |
| 9749 | } |
| 9750 | } |
| 9751 | if (fail) { |
| 9752 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9753 | DRAWSTATE_INVALID_QUERY, "DS", |
| 9754 | "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", |
| 9755 | reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); |
| 9756 | } |
| 9757 | } |
| 9758 | return skip_call; |
| 9759 | } |
| 9760 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9761 | VKAPI_ATTR void VKAPI_CALL |
| 9762 | CmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, |
| 9763 | VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9764 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9765 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9766 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 9767 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9768 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 9769 | auto dst_buff_state = getBufferState(dev_data, dstBuffer); |
| 9770 | if (cb_node && dst_buff_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 9771 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdCopyQueryPoolResults()", VALIDATION_ERROR_02526); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 9772 | // Update bindings between buffer and cmd buffer |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 9773 | AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 9774 | // Validate that DST buffer has correct usage flags set |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 9775 | skip_call |= |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 9776 | ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, VALIDATION_ERROR_01066, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 9777 | "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9778 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 9779 | SetBufferMemoryValid(dev_data, dst_buff_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9780 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9781 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9782 | cb_node->validate_functions.push_back(function); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9783 | std::function<bool(VkQueue)> queryUpdate = |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 9784 | std::bind(validateQuery, std::placeholders::_1, cb_node, queryPool, queryCount, firstQuery); |
| 9785 | cb_node->queryUpdates.push_back(queryUpdate); |
| 9786 | if (cb_node->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9787 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); |
| 9788 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9789 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9790 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9791 | } |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9792 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyQueryPoolResults()", VALIDATION_ERROR_01074); |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 9793 | addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| 9794 | {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, cb_node); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 9795 | } else { |
| 9796 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9797 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9798 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9799 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9800 | dev_data->dispatch_table.CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, dstOffset, |
| 9801 | stride, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9802 | } |
| 9803 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9804 | VKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, |
| 9805 | VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, |
| 9806 | const void *pValues) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9807 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9808 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9809 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9810 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9811 | if (pCB) { |
| 9812 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9813 | skip_call |= ValidateCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); |
| 9814 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_PUSHCONSTANTS); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9815 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9816 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9817 | } |
| 9818 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9819 | skip_call |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 9820 | if (0 == stageFlags) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9821 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9822 | VALIDATION_ERROR_00996, "DS", "vkCmdPushConstants() call has no stageFlags set. %s", |
| 9823 | validation_error_map[VALIDATION_ERROR_00996]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9824 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 9825 | |
Karl Schultz | c81037d | 2016-05-12 08:11:23 -0600 | [diff] [blame] | 9826 | // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. |
Tobin Ehlis | c1d9be1 | 2016-10-13 10:18:18 -0600 | [diff] [blame] | 9827 | auto pipeline_layout = getPipelineLayout(dev_data, layout); |
Tobin Ehlis | fbc847c | 2016-07-18 16:22:03 -0600 | [diff] [blame] | 9828 | // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is |
| 9829 | // contained in the pipeline ranges. |
| 9830 | // Build a {start, end} span list for ranges with matching stage flags. |
| 9831 | const auto &ranges = pipeline_layout->push_constant_ranges; |
| 9832 | struct span { |
| 9833 | uint32_t start; |
| 9834 | uint32_t end; |
| 9835 | }; |
| 9836 | std::vector<span> spans; |
| 9837 | spans.reserve(ranges.size()); |
| 9838 | for (const auto &iter : ranges) { |
| 9839 | if (iter.stageFlags == stageFlags) { |
| 9840 | spans.push_back({iter.offset, iter.offset + iter.size}); |
| 9841 | } |
| 9842 | } |
| 9843 | if (spans.size() == 0) { |
| 9844 | // There were no ranges that matched the stageFlags. |
| 9845 | skip_call |= |
| 9846 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9847 | VALIDATION_ERROR_00988, "DS", "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " |
| 9848 | "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ". %s", |
| 9849 | (uint32_t)stageFlags, (uint64_t)layout, validation_error_map[VALIDATION_ERROR_00988]); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 9850 | } else { |
Tobin Ehlis | fbc847c | 2016-07-18 16:22:03 -0600 | [diff] [blame] | 9851 | // Sort span list by start value. |
| 9852 | struct comparer { |
| 9853 | bool operator()(struct span i, struct span j) { return i.start < j.start; } |
| 9854 | } my_comparer; |
| 9855 | std::sort(spans.begin(), spans.end(), my_comparer); |
| 9856 | |
| 9857 | // Examine two spans at a time. |
| 9858 | std::vector<span>::iterator current = spans.begin(); |
| 9859 | std::vector<span>::iterator next = current + 1; |
| 9860 | while (next != spans.end()) { |
| 9861 | if (current->end < next->start) { |
| 9862 | // There is a gap; cannot coalesce. Move to the next two spans. |
| 9863 | ++current; |
| 9864 | ++next; |
| 9865 | } else { |
| 9866 | // Coalesce the two spans. The start of the next span |
| 9867 | // is within the current span, so pick the larger of |
| 9868 | // the end values to extend the current span. |
| 9869 | // Then delete the next span and set next to the span after it. |
| 9870 | current->end = max(current->end, next->end); |
| 9871 | next = spans.erase(next); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 9872 | } |
| 9873 | } |
Karl Schultz | c81037d | 2016-05-12 08:11:23 -0600 | [diff] [blame] | 9874 | |
Tobin Ehlis | fbc847c | 2016-07-18 16:22:03 -0600 | [diff] [blame] | 9875 | // Now we can check if the incoming range is within any of the spans. |
| 9876 | bool contained_in_a_range = false; |
| 9877 | for (uint32_t i = 0; i < spans.size(); ++i) { |
| 9878 | if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { |
| 9879 | contained_in_a_range = true; |
| 9880 | break; |
Karl Schultz | c81037d | 2016-05-12 08:11:23 -0600 | [diff] [blame] | 9881 | } |
Tobin Ehlis | fbc847c | 2016-07-18 16:22:03 -0600 | [diff] [blame] | 9882 | } |
| 9883 | if (!contained_in_a_range) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9884 | skip_call |= log_msg( |
| 9885 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9886 | VALIDATION_ERROR_00988, "DS", "vkCmdPushConstants() Push constant range [%d, %d) " |
| 9887 | "with stageFlags = 0x%" PRIx32 " " |
| 9888 | "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ". %s", |
| 9889 | offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout, validation_error_map[VALIDATION_ERROR_00988]); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 9890 | } |
| 9891 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9892 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9893 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9894 | dev_data->dispatch_table.CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9895 | } |
| 9896 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9897 | VKAPI_ATTR void VKAPI_CALL |
| 9898 | CmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9899 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9900 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9901 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9902 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9903 | if (pCB) { |
| 9904 | QueryObject query = {queryPool, slot}; |
Karl Schultz | 63c1eb5 | 2016-05-24 13:49:59 -0600 | [diff] [blame] | 9905 | std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9906 | pCB->queryUpdates.push_back(queryUpdate); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9907 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9908 | skip_call |= ValidateCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); |
| 9909 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_WRITETIMESTAMP); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9910 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9911 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9912 | } |
| 9913 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9914 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9915 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9916 | dev_data->dispatch_table.CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9917 | } |
| 9918 | |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 9919 | static bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9920 | const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag, |
| 9921 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 9922 | bool skip_call = false; |
| 9923 | |
| 9924 | for (uint32_t attach = 0; attach < count; attach++) { |
| 9925 | if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { |
| 9926 | // Attachment counts are verified elsewhere, but prevent an invalid access |
| 9927 | if (attachments[attach].attachment < fbci->attachmentCount) { |
| 9928 | const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 9929 | auto view_state = getImageViewState(dev_data, *image_view); |
| 9930 | if (view_state) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9931 | const VkImageCreateInfo *ici = &getImageState(dev_data, view_state->create_info.image)->createInfo; |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 9932 | if (ici != nullptr) { |
| 9933 | if ((ici->usage & usage_flag) == 0) { |
| 9934 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9935 | (VkDebugReportObjectTypeEXT)0, 0, __LINE__, error_code, "DS", |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 9936 | "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9937 | "IMAGE_USAGE flags (%s). %s", |
| 9938 | attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag), |
| 9939 | validation_error_map[error_code]); |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 9940 | } |
| 9941 | } |
| 9942 | } |
| 9943 | } |
| 9944 | } |
| 9945 | } |
| 9946 | return skip_call; |
| 9947 | } |
| 9948 | |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 9949 | // Validate VkFramebufferCreateInfo which includes: |
| 9950 | // 1. attachmentCount equals renderPass attachmentCount |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 9951 | // 2. corresponding framebuffer and renderpass attachments have matching formats |
| 9952 | // 3. corresponding framebuffer and renderpass attachments have matching sample counts |
| 9953 | // 4. fb attachments only have a single mip level |
| 9954 | // 5. fb attachment dimensions are each at least as large as the fb |
| 9955 | // 6. fb attachments use idenity swizzle |
| 9956 | // 7. fb attachments used by renderPass for color/input/ds have correct usage bit set |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 9957 | // 8. fb dimensions are within physical device limits |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 9958 | static bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 9959 | bool skip_call = false; |
| 9960 | |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 9961 | auto rp_state = getRenderPassState(dev_data, pCreateInfo->renderPass); |
| 9962 | if (rp_state) { |
| 9963 | const VkRenderPassCreateInfo *rpci = rp_state->createInfo.ptr(); |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 9964 | if (rpci->attachmentCount != pCreateInfo->attachmentCount) { |
| 9965 | skip_call |= log_msg( |
| 9966 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9967 | reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, VALIDATION_ERROR_00404, "DS", |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 9968 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachmentCount of %u does not match attachmentCount of %u of " |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9969 | "renderPass (0x%" PRIxLEAST64 ") being used to create Framebuffer. %s", |
| 9970 | pCreateInfo->attachmentCount, rpci->attachmentCount, reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), |
| 9971 | validation_error_map[VALIDATION_ERROR_00404]); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 9972 | } else { |
Tobin Ehlis | dae051d | 2016-06-22 14:16:06 -0600 | [diff] [blame] | 9973 | // attachmentCounts match, so make sure corresponding attachment details line up |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 9974 | const VkImageView *image_views = pCreateInfo->pAttachments; |
| 9975 | for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 9976 | auto view_state = getImageViewState(dev_data, image_views[i]); |
Tobin Ehlis | c8ca031 | 2016-09-22 07:30:05 -0600 | [diff] [blame] | 9977 | auto &ivci = view_state->create_info; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 9978 | if (ivci.format != rpci->pAttachments[i].format) { |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 9979 | skip_call |= log_msg( |
| 9980 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9981 | reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, VALIDATION_ERROR_00408, "DS", |
| 9982 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has format of %s that does not match " |
| 9983 | "the format of " |
| 9984 | "%s used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 "). %s", |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 9985 | i, string_VkFormat(ivci.format), string_VkFormat(rpci->pAttachments[i].format), |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9986 | reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), validation_error_map[VALIDATION_ERROR_00408]); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 9987 | } |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9988 | const VkImageCreateInfo *ici = &getImageState(dev_data, ivci.image)->createInfo; |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 9989 | if (ici->samples != rpci->pAttachments[i].samples) { |
Tobin Ehlis | dae051d | 2016-06-22 14:16:06 -0600 | [diff] [blame] | 9990 | skip_call |= log_msg( |
| 9991 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9992 | reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, VALIDATION_ERROR_00409, "DS", |
| 9993 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has %s samples that do not match " |
| 9994 | "the %s samples used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 "). %s", |
Tobin Ehlis | dae051d | 2016-06-22 14:16:06 -0600 | [diff] [blame] | 9995 | i, string_VkSampleCountFlagBits(ici->samples), string_VkSampleCountFlagBits(rpci->pAttachments[i].samples), |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9996 | reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), validation_error_map[VALIDATION_ERROR_00409]); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 9997 | } |
| 9998 | // Verify that view only has a single mip level |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 9999 | if (ivci.subresourceRange.levelCount != 1) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10000 | skip_call |= |
| 10001 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 10002 | VALIDATION_ERROR_00411, "DS", |
| 10003 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has mip levelCount of %u " |
| 10004 | "but only a single mip level (levelCount == 1) is allowed when creating a Framebuffer. %s", |
| 10005 | i, ivci.subresourceRange.levelCount, validation_error_map[VALIDATION_ERROR_00411]); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10006 | } |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10007 | const uint32_t mip_level = ivci.subresourceRange.baseMipLevel; |
Tobin Ehlis | f058eca | 2016-06-22 16:38:29 -0600 | [diff] [blame] | 10008 | uint32_t mip_width = max(1u, ici->extent.width >> mip_level); |
| 10009 | uint32_t mip_height = max(1u, ici->extent.height >> mip_level); |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10010 | if ((ivci.subresourceRange.layerCount < pCreateInfo->layers) || (mip_width < pCreateInfo->width) || |
Tobin Ehlis | f058eca | 2016-06-22 16:38:29 -0600 | [diff] [blame] | 10011 | (mip_height < pCreateInfo->height)) { |
| 10012 | skip_call |= |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10013 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
Tobin Ehlis | f058eca | 2016-06-22 16:38:29 -0600 | [diff] [blame] | 10014 | DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", |
| 10015 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u mip level %u has dimensions smaller " |
| 10016 | "than the corresponding " |
| 10017 | "framebuffer dimensions. Attachment dimensions must be at least as large. Here are the respective " |
| 10018 | "dimensions for " |
| 10019 | "attachment #%u, framebuffer:\n" |
| 10020 | "width: %u, %u\n" |
| 10021 | "height: %u, %u\n" |
| 10022 | "layerCount: %u, %u\n", |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10023 | i, ivci.subresourceRange.baseMipLevel, i, mip_width, pCreateInfo->width, mip_height, |
| 10024 | pCreateInfo->height, ivci.subresourceRange.layerCount, pCreateInfo->layers); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10025 | } |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10026 | if (((ivci.components.r != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.r != VK_COMPONENT_SWIZZLE_R)) || |
| 10027 | ((ivci.components.g != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.g != VK_COMPONENT_SWIZZLE_G)) || |
| 10028 | ((ivci.components.b != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.b != VK_COMPONENT_SWIZZLE_B)) || |
| 10029 | ((ivci.components.a != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.a != VK_COMPONENT_SWIZZLE_A))) { |
Tobin Ehlis | 9e4f16b | 2016-06-23 07:49:12 -0600 | [diff] [blame] | 10030 | skip_call |= log_msg( |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10031 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10032 | VALIDATION_ERROR_00412, "DS", |
Tobin Ehlis | 9e4f16b | 2016-06-23 07:49:12 -0600 | [diff] [blame] | 10033 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has non-identy swizzle. All framebuffer " |
| 10034 | "attachments must have been created with the identity swizzle. Here are the actual swizzle values:\n" |
| 10035 | "r swizzle = %s\n" |
| 10036 | "g swizzle = %s\n" |
| 10037 | "b swizzle = %s\n" |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10038 | "a swizzle = %s\n" |
| 10039 | "%s", |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10040 | i, string_VkComponentSwizzle(ivci.components.r), string_VkComponentSwizzle(ivci.components.g), |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10041 | string_VkComponentSwizzle(ivci.components.b), string_VkComponentSwizzle(ivci.components.a), |
| 10042 | validation_error_map[VALIDATION_ERROR_00412]); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10043 | } |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10044 | } |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 10045 | } |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10046 | // Verify correct attachment usage flags |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10047 | for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { |
| 10048 | // Verify input attachments: |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10049 | skip_call |= |
| 10050 | MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, rpci->pSubpasses[subpass].pInputAttachments, |
| 10051 | pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT, VALIDATION_ERROR_00407); |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10052 | // Verify color attachments: |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10053 | skip_call |= |
| 10054 | MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, rpci->pSubpasses[subpass].pColorAttachments, |
| 10055 | pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, VALIDATION_ERROR_00405); |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10056 | // Verify depth/stencil attachments: |
| 10057 | if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { |
| 10058 | skip_call |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10059 | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, VALIDATION_ERROR_00406); |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10060 | } |
| 10061 | } |
| 10062 | } |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10063 | // Verify FB dimensions are within physical device limits |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10064 | if (pCreateInfo->width > dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth) { |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10065 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10066 | VALIDATION_ERROR_00413, "DS", |
| 10067 | "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo width exceeds physical device limits. " |
| 10068 | "Requested width: %u, device max: %u\n" |
| 10069 | "%s", |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10070 | pCreateInfo->width, dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10071 | validation_error_map[VALIDATION_ERROR_00413]); |
| 10072 | } |
| 10073 | if (pCreateInfo->height > dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight) { |
| 10074 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 10075 | VALIDATION_ERROR_00414, "DS", |
| 10076 | "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo height exceeds physical device limits. " |
| 10077 | "Requested height: %u, device max: %u\n" |
| 10078 | "%s", |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10079 | pCreateInfo->height, dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10080 | validation_error_map[VALIDATION_ERROR_00414]); |
| 10081 | } |
| 10082 | if (pCreateInfo->layers > dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers) { |
| 10083 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 10084 | VALIDATION_ERROR_00415, "DS", |
| 10085 | "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo layers exceeds physical device limits. " |
| 10086 | "Requested layers: %u, device max: %u\n" |
| 10087 | "%s", |
| 10088 | pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers, |
| 10089 | validation_error_map[VALIDATION_ERROR_00415]); |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10090 | } |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10091 | return skip_call; |
| 10092 | } |
| 10093 | |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10094 | // Validate VkFramebufferCreateInfo state prior to calling down chain to create Framebuffer object |
| 10095 | // Return true if an error is encountered and callback returns true to skip call down chain |
| 10096 | // false indicates that call down chain should proceed |
| 10097 | static bool PreCallValidateCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { |
| 10098 | // TODO : Verify that renderPass FB is created with is compatible with FB |
| 10099 | bool skip_call = false; |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 10100 | skip_call |= ValidateFramebufferCreateInfo(dev_data, pCreateInfo); |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10101 | return skip_call; |
| 10102 | } |
| 10103 | |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10104 | // CreateFramebuffer state has been validated and call down chain completed so record new framebuffer object |
| 10105 | static void PostCallRecordCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo, VkFramebuffer fb) { |
| 10106 | // Shadow create info and store in map |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10107 | std::unique_ptr<FRAMEBUFFER_STATE> fb_state( |
| 10108 | new FRAMEBUFFER_STATE(fb, pCreateInfo, dev_data->renderPassMap[pCreateInfo->renderPass]->createInfo.ptr())); |
Tobin Ehlis | 042ec78 | 2016-06-23 14:25:22 -0600 | [diff] [blame] | 10109 | |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10110 | for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
| 10111 | VkImageView view = pCreateInfo->pAttachments[i]; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10112 | auto view_state = getImageViewState(dev_data, view); |
| 10113 | if (!view_state) { |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10114 | continue; |
| 10115 | } |
| 10116 | MT_FB_ATTACHMENT_INFO fb_info; |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 10117 | fb_info.mem = getImageState(dev_data, view_state->create_info.image)->binding.mem; |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 10118 | fb_info.view_state = view_state; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10119 | fb_info.image = view_state->create_info.image; |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10120 | fb_state->attachments.push_back(fb_info); |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10121 | } |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10122 | dev_data->frameBufferMap[fb] = std::move(fb_state); |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10123 | } |
| 10124 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 10125 | VKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, |
| 10126 | const VkAllocationCallbacks *pAllocator, |
| 10127 | VkFramebuffer *pFramebuffer) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10128 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10129 | std::unique_lock<std::mutex> lock(global_lock); |
| 10130 | bool skip_call = PreCallValidateCreateFramebuffer(dev_data, pCreateInfo); |
| 10131 | lock.unlock(); |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10132 | |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10133 | if (skip_call) |
| 10134 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 10135 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 10136 | VkResult result = dev_data->dispatch_table.CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10137 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10138 | if (VK_SUCCESS == result) { |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10139 | lock.lock(); |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10140 | PostCallRecordCreateFramebuffer(dev_data, pCreateInfo, *pFramebuffer); |
| 10141 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10142 | } |
| 10143 | return result; |
| 10144 | } |
| 10145 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10146 | static bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, |
| 10147 | std::unordered_set<uint32_t> &processed_nodes) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10148 | // If we have already checked this node we have not found a dependency path so return false. |
| 10149 | if (processed_nodes.count(index)) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10150 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10151 | processed_nodes.insert(index); |
| 10152 | const DAGNode &node = subpass_to_node[index]; |
| 10153 | // Look for a dependency path. If one exists return true else recurse on the previous nodes. |
| 10154 | if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { |
| 10155 | for (auto elem : node.prev) { |
| 10156 | if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10157 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10158 | } |
| 10159 | } else { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10160 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10161 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10162 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10163 | } |
| 10164 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10165 | static bool CheckDependencyExists(const layer_data *dev_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10166 | const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { |
| 10167 | bool result = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10168 | // Loop through all subpasses that share the same attachment and make sure a dependency exists |
| 10169 | for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { |
Jamie Madill | 2b6b8d5 | 2016-04-04 15:09:51 -0400 | [diff] [blame] | 10170 | if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10171 | continue; |
| 10172 | const DAGNode &node = subpass_to_node[subpass]; |
| 10173 | // Check for a specified dependency between the two nodes. If one exists we are done. |
| 10174 | auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); |
| 10175 | auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); |
| 10176 | if (prev_elem == node.prev.end() && next_elem == node.next.end()) { |
Jan-Harald Fredriksen | 4b47838 | 2016-06-08 14:20:50 +0200 | [diff] [blame] | 10177 | // If no dependency exits an implicit dependency still might. If not, throw an error. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10178 | std::unordered_set<uint32_t> processed_nodes; |
Jan-Harald Fredriksen | 4b47838 | 2016-06-08 14:20:50 +0200 | [diff] [blame] | 10179 | if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || |
| 10180 | FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10181 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10182 | __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", |
| 10183 | "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, |
| 10184 | dependent_subpasses[k]); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10185 | result = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10186 | } |
| 10187 | } |
| 10188 | } |
| 10189 | return result; |
| 10190 | } |
| 10191 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10192 | static bool CheckPreserved(const layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10193 | const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10194 | const DAGNode &node = subpass_to_node[index]; |
| 10195 | // If this node writes to the attachment return true as next nodes need to preserve the attachment. |
| 10196 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; |
| 10197 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 10198 | if (attachment == subpass.pColorAttachments[j].attachment) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10199 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10200 | } |
| 10201 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 10202 | if (attachment == subpass.pDepthStencilAttachment->attachment) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10203 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10204 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10205 | bool result = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10206 | // Loop through previous nodes and see if any of them write to the attachment. |
| 10207 | for (auto elem : node.prev) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10208 | result |= CheckPreserved(dev_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10209 | } |
| 10210 | // If the attachment was written to by a previous node than this node needs to preserve it. |
| 10211 | if (result && depth > 0) { |
| 10212 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10213 | bool has_preserved = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10214 | for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { |
| 10215 | if (subpass.pPreserveAttachments[j] == attachment) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10216 | has_preserved = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10217 | break; |
| 10218 | } |
| 10219 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10220 | if (!has_preserved) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10221 | skip_call |= |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10222 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10223 | DRAWSTATE_INVALID_RENDERPASS, "DS", |
| 10224 | "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); |
| 10225 | } |
| 10226 | } |
| 10227 | return result; |
| 10228 | } |
| 10229 | |
| 10230 | template <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { |
| 10231 | return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || |
| 10232 | ((offset1 > offset2) && (offset1 < (offset2 + size2))); |
| 10233 | } |
| 10234 | |
| 10235 | bool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { |
| 10236 | return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && |
| 10237 | isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); |
| 10238 | } |
| 10239 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10240 | static bool ValidateDependencies(const layer_data *dev_data, FRAMEBUFFER_STATE const *framebuffer, |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10241 | RENDER_PASS_STATE const *renderPass) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10242 | bool skip_call = false; |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10243 | auto const pFramebufferInfo = framebuffer->createInfo.ptr(); |
| 10244 | auto const pCreateInfo = renderPass->createInfo.ptr(); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10245 | auto const & subpass_to_node = renderPass->subpassToNode; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10246 | std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); |
| 10247 | std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); |
| 10248 | std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); |
| 10249 | // Find overlapping attachments |
| 10250 | for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
| 10251 | for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { |
| 10252 | VkImageView viewi = pFramebufferInfo->pAttachments[i]; |
| 10253 | VkImageView viewj = pFramebufferInfo->pAttachments[j]; |
| 10254 | if (viewi == viewj) { |
| 10255 | overlapping_attachments[i].push_back(j); |
| 10256 | overlapping_attachments[j].push_back(i); |
| 10257 | continue; |
| 10258 | } |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10259 | auto view_state_i = getImageViewState(dev_data, viewi); |
| 10260 | auto view_state_j = getImageViewState(dev_data, viewj); |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10261 | if (!view_state_i || !view_state_j) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10262 | continue; |
| 10263 | } |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10264 | auto view_ci_i = view_state_i->create_info; |
| 10265 | auto view_ci_j = view_state_j->create_info; |
| 10266 | if (view_ci_i.image == view_ci_j.image && isRegionOverlapping(view_ci_i.subresourceRange, view_ci_j.subresourceRange)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10267 | overlapping_attachments[i].push_back(j); |
| 10268 | overlapping_attachments[j].push_back(i); |
| 10269 | continue; |
| 10270 | } |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10271 | auto image_data_i = getImageState(dev_data, view_ci_i.image); |
| 10272 | auto image_data_j = getImageState(dev_data, view_ci_j.image); |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 10273 | if (!image_data_i || !image_data_j) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10274 | continue; |
| 10275 | } |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 10276 | if (image_data_i->binding.mem == image_data_j->binding.mem && |
| 10277 | isRangeOverlapping(image_data_i->binding.offset, image_data_i->binding.size, image_data_j->binding.offset, |
| 10278 | image_data_j->binding.size)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10279 | overlapping_attachments[i].push_back(j); |
| 10280 | overlapping_attachments[j].push_back(i); |
| 10281 | } |
| 10282 | } |
| 10283 | } |
| 10284 | for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { |
| 10285 | uint32_t attachment = i; |
| 10286 | for (auto other_attachment : overlapping_attachments[i]) { |
| 10287 | if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10288 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 10289 | __LINE__, VALIDATION_ERROR_00324, "DS", "Attachment %d aliases attachment %d but doesn't " |
| 10290 | "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT. %s", |
| 10291 | attachment, other_attachment, validation_error_map[VALIDATION_ERROR_00324]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10292 | } |
| 10293 | if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10294 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 10295 | __LINE__, VALIDATION_ERROR_00324, "DS", "Attachment %d aliases attachment %d but doesn't " |
| 10296 | "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT. %s", |
| 10297 | other_attachment, attachment, validation_error_map[VALIDATION_ERROR_00324]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10298 | } |
| 10299 | } |
| 10300 | } |
| 10301 | // Find for each attachment the subpasses that use them. |
Mark Young | f5bba55 | 2016-03-30 02:23:18 -0600 | [diff] [blame] | 10302 | unordered_set<uint32_t> attachmentIndices; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10303 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10304 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
Mark Young | f5bba55 | 2016-03-30 02:23:18 -0600 | [diff] [blame] | 10305 | attachmentIndices.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10306 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| 10307 | uint32_t attachment = subpass.pInputAttachments[j].attachment; |
Chris Forbes | ac82518 | 2016-07-01 11:45:49 +1200 | [diff] [blame] | 10308 | if (attachment == VK_ATTACHMENT_UNUSED) |
| 10309 | continue; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10310 | input_attachment_to_subpass[attachment].push_back(i); |
| 10311 | for (auto overlapping_attachment : overlapping_attachments[attachment]) { |
| 10312 | input_attachment_to_subpass[overlapping_attachment].push_back(i); |
| 10313 | } |
| 10314 | } |
| 10315 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 10316 | uint32_t attachment = subpass.pColorAttachments[j].attachment; |
Chris Forbes | ac82518 | 2016-07-01 11:45:49 +1200 | [diff] [blame] | 10317 | if (attachment == VK_ATTACHMENT_UNUSED) |
| 10318 | continue; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10319 | output_attachment_to_subpass[attachment].push_back(i); |
| 10320 | for (auto overlapping_attachment : overlapping_attachments[attachment]) { |
| 10321 | output_attachment_to_subpass[overlapping_attachment].push_back(i); |
| 10322 | } |
Mark Young | f5bba55 | 2016-03-30 02:23:18 -0600 | [diff] [blame] | 10323 | attachmentIndices.insert(attachment); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10324 | } |
| 10325 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 10326 | uint32_t attachment = subpass.pDepthStencilAttachment->attachment; |
| 10327 | output_attachment_to_subpass[attachment].push_back(i); |
| 10328 | for (auto overlapping_attachment : overlapping_attachments[attachment]) { |
| 10329 | output_attachment_to_subpass[overlapping_attachment].push_back(i); |
| 10330 | } |
Mark Young | f5bba55 | 2016-03-30 02:23:18 -0600 | [diff] [blame] | 10331 | |
| 10332 | if (attachmentIndices.count(attachment)) { |
| 10333 | skip_call |= |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10334 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 10335 | DRAWSTATE_INVALID_RENDERPASS, "DS", |
| 10336 | "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", attachment, i); |
Mark Young | f5bba55 | 2016-03-30 02:23:18 -0600 | [diff] [blame] | 10337 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10338 | } |
| 10339 | } |
| 10340 | // If there is a dependency needed make sure one exists |
| 10341 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10342 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| 10343 | // If the attachment is an input then all subpasses that output must have a dependency relationship |
| 10344 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Chris Forbes | ac82518 | 2016-07-01 11:45:49 +1200 | [diff] [blame] | 10345 | uint32_t attachment = subpass.pInputAttachments[j].attachment; |
| 10346 | if (attachment == VK_ATTACHMENT_UNUSED) |
| 10347 | continue; |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10348 | CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10349 | } |
| 10350 | // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship |
| 10351 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
Chris Forbes | ac82518 | 2016-07-01 11:45:49 +1200 | [diff] [blame] | 10352 | uint32_t attachment = subpass.pColorAttachments[j].attachment; |
| 10353 | if (attachment == VK_ATTACHMENT_UNUSED) |
| 10354 | continue; |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10355 | CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
| 10356 | CheckDependencyExists(dev_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10357 | } |
| 10358 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 10359 | const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10360 | CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
| 10361 | CheckDependencyExists(dev_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10362 | } |
| 10363 | } |
| 10364 | // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was |
| 10365 | // written. |
| 10366 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10367 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| 10368 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10369 | CheckPreserved(dev_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10370 | } |
| 10371 | } |
| 10372 | return skip_call; |
| 10373 | } |
Tobin Ehlis | db11af6 | 2016-05-11 10:38:29 -0600 | [diff] [blame] | 10374 | // ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the |
| 10375 | // VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that |
| 10376 | // READ_ONLY layout attachments don't have CLEAR as their loadOp. |
| 10377 | static bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, |
| 10378 | const uint32_t attachment, |
| 10379 | const VkAttachmentDescription &attachment_description) { |
| 10380 | bool skip_call = false; |
| 10381 | // Verify that initial loadOp on READ_ONLY attachments is not CLEAR |
| 10382 | if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { |
| 10383 | if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || |
| 10384 | (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10385 | skip_call |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 10386 | VkDebugReportObjectTypeEXT(0), __LINE__, VALIDATION_ERROR_02351, "DS", |
| 10387 | "Cannot clear attachment %d with invalid first layout %s. %s", attachment, |
| 10388 | string_VkImageLayout(first_layout), validation_error_map[VALIDATION_ERROR_02351]); |
Tobin Ehlis | db11af6 | 2016-05-11 10:38:29 -0600 | [diff] [blame] | 10389 | } |
| 10390 | } |
| 10391 | return skip_call; |
| 10392 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10393 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10394 | static bool ValidateLayouts(const layer_data *dev_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10395 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10396 | |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10397 | // Track when we're observing the first use of an attachment |
| 10398 | std::vector<bool> attach_first_use(pCreateInfo->attachmentCount, true); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10399 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10400 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10401 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 10402 | auto attach_index = subpass.pColorAttachments[j].attachment; |
| 10403 | if (attach_index == VK_ATTACHMENT_UNUSED) |
| 10404 | continue; |
| 10405 | |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10406 | switch (subpass.pColorAttachments[j].layout) { |
| 10407 | case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10408 | // This is ideal. |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10409 | break; |
| 10410 | |
| 10411 | case VK_IMAGE_LAYOUT_GENERAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10412 | // May not be optimal; TODO: reconsider this warning based on other constraints? |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10413 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 10414 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10415 | "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); |
| 10416 | break; |
| 10417 | |
| 10418 | default: |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10419 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 10420 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10421 | "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", |
| 10422 | string_VkImageLayout(subpass.pColorAttachments[j].layout)); |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10423 | } |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10424 | |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10425 | if (attach_first_use[attach_index]) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10426 | skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pColorAttachments[j].layout, |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10427 | attach_index, pCreateInfo->pAttachments[attach_index]); |
| 10428 | } |
| 10429 | attach_first_use[attach_index] = false; |
| 10430 | } |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10431 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
Chris Forbes | c5dd9bc | 2016-08-09 08:17:14 +1200 | [diff] [blame] | 10432 | switch (subpass.pDepthStencilAttachment->layout) { |
| 10433 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: |
| 10434 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10435 | // These are ideal. |
Chris Forbes | c5dd9bc | 2016-08-09 08:17:14 +1200 | [diff] [blame] | 10436 | break; |
| 10437 | |
| 10438 | case VK_IMAGE_LAYOUT_GENERAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10439 | // May not be optimal; TODO: reconsider this warning based on other constraints? GENERAL can be better than doing |
| 10440 | // a bunch of transitions. |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10441 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 10442 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Chris Forbes | c5dd9bc | 2016-08-09 08:17:14 +1200 | [diff] [blame] | 10443 | "GENERAL layout for depth attachment may not give optimal performance."); |
| 10444 | break; |
| 10445 | |
| 10446 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10447 | // No other layouts are acceptable |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10448 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 10449 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Chris Forbes | c5dd9bc | 2016-08-09 08:17:14 +1200 | [diff] [blame] | 10450 | "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL, " |
| 10451 | "DEPTH_STENCIL_READ_ONLY_OPTIMAL or GENERAL.", |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10452 | string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10453 | } |
Chris Forbes | c5dd9bc | 2016-08-09 08:17:14 +1200 | [diff] [blame] | 10454 | |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10455 | auto attach_index = subpass.pDepthStencilAttachment->attachment; |
| 10456 | if (attach_first_use[attach_index]) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10457 | skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pDepthStencilAttachment->layout, |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10458 | attach_index, pCreateInfo->pAttachments[attach_index]); |
| 10459 | } |
| 10460 | attach_first_use[attach_index] = false; |
| 10461 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10462 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Chris Forbes | d9c27ca | 2016-07-01 11:28:00 +1200 | [diff] [blame] | 10463 | auto attach_index = subpass.pInputAttachments[j].attachment; |
| 10464 | if (attach_index == VK_ATTACHMENT_UNUSED) |
| 10465 | continue; |
| 10466 | |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10467 | switch (subpass.pInputAttachments[j].layout) { |
| 10468 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: |
| 10469 | case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10470 | // These are ideal. |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10471 | break; |
| 10472 | |
| 10473 | case VK_IMAGE_LAYOUT_GENERAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10474 | // May not be optimal. TODO: reconsider this warning based on other constraints. |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10475 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 10476 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10477 | "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); |
| 10478 | break; |
| 10479 | |
| 10480 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10481 | // No other layouts are acceptable |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10482 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10483 | DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
| 10484 | "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", |
| 10485 | string_VkImageLayout(subpass.pInputAttachments[j].layout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10486 | } |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10487 | |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10488 | if (attach_first_use[attach_index]) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10489 | skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pInputAttachments[j].layout, |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10490 | attach_index, pCreateInfo->pAttachments[attach_index]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10491 | } |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10492 | attach_first_use[attach_index] = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10493 | } |
| 10494 | } |
| 10495 | return skip; |
| 10496 | } |
| 10497 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10498 | static bool CreatePassDAG(const layer_data *dev_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10499 | std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { |
| 10500 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10501 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10502 | DAGNode &subpass_node = subpass_to_node[i]; |
| 10503 | subpass_node.pass = i; |
| 10504 | } |
| 10505 | for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { |
| 10506 | const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; |
Chris Forbes | 7f075fb | 2016-09-27 10:54:58 +1300 | [diff] [blame] | 10507 | if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL || dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { |
| 10508 | if (dependency.srcSubpass == dependency.dstSubpass) { |
| 10509 | skip_call |= |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10510 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Chris Forbes | 7f075fb | 2016-09-27 10:54:58 +1300 | [diff] [blame] | 10511 | DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); |
| 10512 | } |
Chris Forbes | 7f075fb | 2016-09-27 10:54:58 +1300 | [diff] [blame] | 10513 | } else if (dependency.srcSubpass > dependency.dstSubpass) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10514 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10515 | DRAWSTATE_INVALID_RENDERPASS, "DS", |
| 10516 | "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10517 | } else if (dependency.srcSubpass == dependency.dstSubpass) { |
| 10518 | has_self_dependency[dependency.srcSubpass] = true; |
Chris Forbes | 585a32b | 2016-10-26 15:45:33 +1300 | [diff] [blame] | 10519 | } else { |
| 10520 | subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); |
| 10521 | subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10522 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10523 | } |
| 10524 | return skip_call; |
| 10525 | } |
Chris Forbes | 90da2e9 | 2016-03-18 16:30:03 +1300 | [diff] [blame] | 10526 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10527 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 10528 | VKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, |
| 10529 | const VkAllocationCallbacks *pAllocator, |
| 10530 | VkShaderModule *pShaderModule) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10531 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10532 | bool skip_call = false; |
Chris Forbes | b4afd0f | 2016-04-04 10:48:35 +1200 | [diff] [blame] | 10533 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10534 | // Use SPIRV-Tools validator to try and catch any issues with the module itself |
Chris Forbes | b4afd0f | 2016-04-04 10:48:35 +1200 | [diff] [blame] | 10535 | spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); |
| 10536 | spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; |
| 10537 | spv_diagnostic diag = nullptr; |
| 10538 | |
| 10539 | auto result = spvValidate(ctx, &binary, &diag); |
| 10540 | if (result != SPV_SUCCESS) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10541 | skip_call |= |
| 10542 | log_msg(dev_data->report_data, result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 10543 | VkDebugReportObjectTypeEXT(0), 0, __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", |
| 10544 | "SPIR-V module not valid: %s", diag && diag->error ? diag->error : "(no error text)"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10545 | } |
| 10546 | |
Chris Forbes | b4afd0f | 2016-04-04 10:48:35 +1200 | [diff] [blame] | 10547 | spvDiagnosticDestroy(diag); |
| 10548 | spvContextDestroy(ctx); |
| 10549 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10550 | if (skip_call) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10551 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 10552 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 10553 | VkResult res = dev_data->dispatch_table.CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10554 | |
| 10555 | if (res == VK_SUCCESS) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 10556 | std::lock_guard<std::mutex> lock(global_lock); |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10557 | dev_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10558 | } |
| 10559 | return res; |
| 10560 | } |
| 10561 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10562 | static bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10563 | bool skip_call = false; |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10564 | if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { |
| 10565 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Chris Forbes | 2d9b2a8 | 2016-11-21 10:45:39 +1300 | [diff] [blame] | 10566 | VALIDATION_ERROR_00325, "DS", |
| 10567 | "CreateRenderPass: %s attachment %d must be less than the total number of attachments %d. %s", |
| 10568 | type, attachment, attachment_count, validation_error_map[VALIDATION_ERROR_00325]); |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10569 | } |
| 10570 | return skip_call; |
| 10571 | } |
| 10572 | |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10573 | static bool IsPowerOfTwo(unsigned x) { |
| 10574 | return x && !(x & (x-1)); |
| 10575 | } |
| 10576 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10577 | static bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { |
| 10578 | bool skip_call = false; |
| 10579 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10580 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| 10581 | if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10582 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 10583 | VALIDATION_ERROR_00347, "DS", |
| 10584 | "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS. %s", |
| 10585 | i, validation_error_map[VALIDATION_ERROR_00347]); |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10586 | } |
| 10587 | for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { |
| 10588 | uint32_t attachment = subpass.pPreserveAttachments[j]; |
| 10589 | if (attachment == VK_ATTACHMENT_UNUSED) { |
| 10590 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10591 | __LINE__, VALIDATION_ERROR_00356, "DS", |
| 10592 | "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED. %s", j, |
| 10593 | validation_error_map[VALIDATION_ERROR_00356]); |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10594 | } else { |
| 10595 | skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); |
| 10596 | } |
| 10597 | } |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10598 | |
| 10599 | auto subpass_performs_resolve = subpass.pResolveAttachments && std::any_of( |
| 10600 | subpass.pResolveAttachments, subpass.pResolveAttachments + subpass.colorAttachmentCount, |
| 10601 | [](VkAttachmentReference ref) { return ref.attachment != VK_ATTACHMENT_UNUSED; }); |
| 10602 | |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10603 | unsigned sample_count = 0; |
| 10604 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10605 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 10606 | uint32_t attachment; |
| 10607 | if (subpass.pResolveAttachments) { |
| 10608 | attachment = subpass.pResolveAttachments[j].attachment; |
| 10609 | skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10610 | |
| 10611 | if (!skip_call && attachment != VK_ATTACHMENT_UNUSED && |
| 10612 | pCreateInfo->pAttachments[attachment].samples != VK_SAMPLE_COUNT_1_BIT) { |
| 10613 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10614 | __LINE__, VALIDATION_ERROR_00352, "DS", |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10615 | "CreateRenderPass: Subpass %u requests multisample resolve into attachment %u, " |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10616 | "which must have VK_SAMPLE_COUNT_1_BIT but has %s. %s", |
| 10617 | i, attachment, string_VkSampleCountFlagBits(pCreateInfo->pAttachments[attachment].samples), |
| 10618 | validation_error_map[VALIDATION_ERROR_00352]); |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10619 | } |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10620 | } |
| 10621 | attachment = subpass.pColorAttachments[j].attachment; |
| 10622 | skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10623 | |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10624 | if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { |
| 10625 | sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10626 | |
Chris Forbes | 6655bb3 | 2016-07-01 18:27:30 +1200 | [diff] [blame] | 10627 | if (subpass_performs_resolve && |
| 10628 | pCreateInfo->pAttachments[attachment].samples == VK_SAMPLE_COUNT_1_BIT) { |
| 10629 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10630 | __LINE__, VALIDATION_ERROR_00351, "DS", |
Chris Forbes | 6655bb3 | 2016-07-01 18:27:30 +1200 | [diff] [blame] | 10631 | "CreateRenderPass: Subpass %u requests multisample resolve from attachment %u " |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10632 | "which has VK_SAMPLE_COUNT_1_BIT. %s", |
| 10633 | i, attachment, validation_error_map[VALIDATION_ERROR_00351]); |
Chris Forbes | 6655bb3 | 2016-07-01 18:27:30 +1200 | [diff] [blame] | 10634 | } |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10635 | } |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10636 | } |
Chris Forbes | 6655bb3 | 2016-07-01 18:27:30 +1200 | [diff] [blame] | 10637 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10638 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 10639 | uint32_t attachment = subpass.pDepthStencilAttachment->attachment; |
| 10640 | skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10641 | |
| 10642 | if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { |
| 10643 | sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; |
| 10644 | } |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10645 | } |
Chris Forbes | 6655bb3 | 2016-07-01 18:27:30 +1200 | [diff] [blame] | 10646 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10647 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| 10648 | uint32_t attachment = subpass.pInputAttachments[j].attachment; |
| 10649 | skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); |
Chris Forbes | 3e4d7ac | 2016-05-06 16:11:03 +1200 | [diff] [blame] | 10650 | } |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10651 | |
| 10652 | if (sample_count && !IsPowerOfTwo(sample_count)) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10653 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 10654 | VALIDATION_ERROR_00337, "DS", "CreateRenderPass: Subpass %u attempts to render to " |
| 10655 | "attachments with inconsistent sample counts. %s", |
| 10656 | i, validation_error_map[VALIDATION_ERROR_00337]); |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10657 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10658 | } |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10659 | return skip_call; |
| 10660 | } |
| 10661 | |
| 10662 | VKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, |
| 10663 | const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10664 | bool skip_call = false; |
| 10665 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 10666 | |
| 10667 | std::unique_lock<std::mutex> lock(global_lock); |
| 10668 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10669 | // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with |
| 10670 | // ValidateLayouts. |
| 10671 | skip_call |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); |
Chris Forbes | 7125136 | 2016-11-16 14:30:05 +1300 | [diff] [blame] | 10672 | if (!skip_call) { |
| 10673 | skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); |
| 10674 | } |
Chris Forbes | bf4a772 | 2016-06-21 18:30:46 +1200 | [diff] [blame] | 10675 | lock.unlock(); |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10676 | |
| 10677 | if (skip_call) { |
| 10678 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 10679 | } |
| 10680 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 10681 | VkResult result = dev_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); |
Chris Forbes | bf4a772 | 2016-06-21 18:30:46 +1200 | [diff] [blame] | 10682 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10683 | if (VK_SUCCESS == result) { |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10684 | lock.lock(); |
| 10685 | |
| 10686 | std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); |
| 10687 | std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); |
| 10688 | skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); |
| 10689 | |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10690 | auto render_pass = unique_ptr<RENDER_PASS_STATE>(new RENDER_PASS_STATE(pCreateInfo)); |
Chris Forbes | cad81b8 | 2016-05-06 16:11:29 +1200 | [diff] [blame] | 10691 | render_pass->renderPass = *pRenderPass; |
Chris Forbes | 3e4d7ac | 2016-05-06 16:11:03 +1200 | [diff] [blame] | 10692 | render_pass->hasSelfDependency = has_self_dependency; |
| 10693 | render_pass->subpassToNode = subpass_to_node; |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10694 | |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10695 | // TODO: Maybe fill list and then copy instead of locking |
Chris Forbes | 3e4d7ac | 2016-05-06 16:11:03 +1200 | [diff] [blame] | 10696 | std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10697 | std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = render_pass->attachment_first_layout; |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10698 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10699 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10700 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10701 | uint32_t attachment = subpass.pColorAttachments[j].attachment; |
| 10702 | if (!attachment_first_read.count(attachment)) { |
| 10703 | attachment_first_read.insert(std::make_pair(attachment, false)); |
| 10704 | attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); |
Michael Lentine | 5007eb9 | 2016-04-05 11:38:12 -0500 | [diff] [blame] | 10705 | } |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10706 | } |
| 10707 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 10708 | uint32_t attachment = subpass.pDepthStencilAttachment->attachment; |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10709 | if (!attachment_first_read.count(attachment)) { |
| 10710 | attachment_first_read.insert(std::make_pair(attachment, false)); |
| 10711 | attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); |
Michael Lentine | 9e1290e | 2016-03-31 14:45:20 -0500 | [diff] [blame] | 10712 | } |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10713 | } |
Michael Lentine | 4e8777c | 2016-03-31 13:46:44 -0500 | [diff] [blame] | 10714 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| 10715 | uint32_t attachment = subpass.pInputAttachments[j].attachment; |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10716 | if (!attachment_first_read.count(attachment)) { |
| 10717 | attachment_first_read.insert(std::make_pair(attachment, true)); |
| 10718 | attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); |
Michael Lentine | 9e1290e | 2016-03-31 14:45:20 -0500 | [diff] [blame] | 10719 | } |
Michael Lentine | 4e8777c | 2016-03-31 13:46:44 -0500 | [diff] [blame] | 10720 | } |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10721 | } |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10722 | |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10723 | dev_data->renderPassMap[*pRenderPass] = std::move(render_pass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10724 | } |
| 10725 | return result; |
| 10726 | } |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10727 | |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 10728 | static bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10729 | bool skip_call = false; |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10730 | auto const pRenderPassInfo = getRenderPassState(dev_data, pRenderPassBegin->renderPass)->createInfo.ptr(); |
Chris Forbes | ef27c5b | 2016-09-27 12:03:04 +1300 | [diff] [blame] | 10731 | auto const & framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer]->createInfo; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10732 | if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { |
| 10733 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 10734 | DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " |
| 10735 | "with a different number of attachments."); |
| 10736 | } |
| 10737 | for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { |
| 10738 | const VkImageView &image_view = framebufferInfo.pAttachments[i]; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10739 | auto view_state = getImageViewState(dev_data, image_view); |
| 10740 | assert(view_state); |
| 10741 | const VkImage &image = view_state->create_info.image; |
| 10742 | const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10743 | IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, |
| 10744 | pRenderPassInfo->pAttachments[i].initialLayout}; |
| 10745 | // TODO: Do not iterate over every possibility - consolidate where possible |
| 10746 | for (uint32_t j = 0; j < subRange.levelCount; j++) { |
| 10747 | uint32_t level = subRange.baseMipLevel + j; |
| 10748 | for (uint32_t k = 0; k < subRange.layerCount; k++) { |
| 10749 | uint32_t layer = subRange.baseArrayLayer + k; |
| 10750 | VkImageSubresource sub = {subRange.aspectMask, level, layer}; |
| 10751 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
| 10752 | if (!FindLayout(pCB, image, sub, node)) { |
| 10753 | SetLayout(pCB, image, sub, newNode); |
| 10754 | continue; |
| 10755 | } |
Chris Forbes | e8d0209 | 2016-06-30 12:43:36 +1200 | [diff] [blame] | 10756 | if (newNode.layout != VK_IMAGE_LAYOUT_UNDEFINED && |
| 10757 | newNode.layout != node.layout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10758 | skip_call |= |
| 10759 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Chris Forbes | e8d0209 | 2016-06-30 12:43:36 +1200 | [diff] [blame] | 10760 | DRAWSTATE_INVALID_RENDERPASS, "DS", |
| 10761 | "You cannot start a render pass using attachment %u " |
| 10762 | "where the render pass initial layout is %s and the previous " |
| 10763 | "known layout of the attachment is %s. The layouts must match, or " |
| 10764 | "the render pass initial layout for the attachment must be " |
| 10765 | "VK_IMAGE_LAYOUT_UNDEFINED", |
Michael Lentine | 8f6abe7 | 2016-03-24 21:36:53 -0500 | [diff] [blame] | 10766 | i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10767 | } |
| 10768 | } |
| 10769 | } |
| 10770 | } |
| 10771 | return skip_call; |
| 10772 | } |
| 10773 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10774 | static void TransitionAttachmentRefLayout(layer_data *dev_data, GLOBAL_CB_NODE *pCB, FRAMEBUFFER_STATE *pFramebuffer, |
| 10775 | VkAttachmentReference ref) { |
Chris Forbes | 853022c | 2016-06-30 16:56:15 +1200 | [diff] [blame] | 10776 | if (ref.attachment != VK_ATTACHMENT_UNUSED) { |
| 10777 | auto image_view = pFramebuffer->createInfo.pAttachments[ref.attachment]; |
| 10778 | SetLayout(dev_data, pCB, image_view, ref.layout); |
| 10779 | } |
| 10780 | } |
| 10781 | |
Chris Forbes | 59b3654 | 2016-05-17 15:31:00 +1200 | [diff] [blame] | 10782 | static void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10783 | const int subpass_index) { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10784 | auto renderPass = getRenderPassState(dev_data, pRenderPassBegin->renderPass); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10785 | if (!renderPass) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10786 | return; |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10787 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10788 | auto framebuffer = getFramebufferState(dev_data, pRenderPassBegin->framebuffer); |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 10789 | if (!framebuffer) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10790 | return; |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 10791 | |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10792 | auto const &subpass = renderPass->createInfo.pSubpasses[subpass_index]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10793 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Chris Forbes | 853022c | 2016-06-30 16:56:15 +1200 | [diff] [blame] | 10794 | TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pInputAttachments[j]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10795 | } |
| 10796 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
Chris Forbes | 853022c | 2016-06-30 16:56:15 +1200 | [diff] [blame] | 10797 | TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pColorAttachments[j]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10798 | } |
Chris Forbes | 853022c | 2016-06-30 16:56:15 +1200 | [diff] [blame] | 10799 | if (subpass.pDepthStencilAttachment) { |
| 10800 | TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, *subpass.pDepthStencilAttachment); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10801 | } |
| 10802 | } |
| 10803 | |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10804 | static bool validatePrimaryCommandBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name, |
| 10805 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10806 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10807 | if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10808 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10809 | error_code, "DS", "Cannot execute command %s on a secondary command buffer. %s", cmd_name.c_str(), |
| 10810 | validation_error_map[error_code]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10811 | } |
| 10812 | return skip_call; |
| 10813 | } |
| 10814 | |
Chris Forbes | 05e03b7 | 2016-05-17 15:27:58 +1200 | [diff] [blame] | 10815 | static void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10816 | auto renderPass = getRenderPassState(dev_data, pRenderPassBegin->renderPass); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10817 | if (!renderPass) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10818 | return; |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10819 | |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10820 | const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->createInfo.ptr(); |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10821 | auto framebuffer = getFramebufferState(dev_data, pRenderPassBegin->framebuffer); |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 10822 | if (!framebuffer) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10823 | return; |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 10824 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10825 | for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { |
Chris Forbes | 853022c | 2016-06-30 16:56:15 +1200 | [diff] [blame] | 10826 | auto image_view = framebuffer->createInfo.pAttachments[i]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10827 | SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); |
| 10828 | } |
| 10829 | } |
| 10830 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10831 | static bool VerifyRenderAreaBounds(const layer_data *dev_data, const VkRenderPassBeginInfo *pRenderPassBegin) { |
Michael Lentine | d464881 | 2016-03-24 20:48:59 -0500 | [diff] [blame] | 10832 | bool skip_call = false; |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10833 | const safe_VkFramebufferCreateInfo *pFramebufferInfo = |
| 10834 | &getFramebufferState(dev_data, pRenderPassBegin->framebuffer)->createInfo; |
Michael Lentine | d464881 | 2016-03-24 20:48:59 -0500 | [diff] [blame] | 10835 | if (pRenderPassBegin->renderArea.offset.x < 0 || |
| 10836 | (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || |
| 10837 | pRenderPassBegin->renderArea.offset.y < 0 || |
| 10838 | (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { |
| 10839 | skip_call |= static_cast<bool>(log_msg( |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10840 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Michael Lentine | d464881 | 2016-03-24 20:48:59 -0500 | [diff] [blame] | 10841 | DRAWSTATE_INVALID_RENDER_AREA, "CORE", |
| 10842 | "Cannot execute a render pass with renderArea not within the bound of the " |
| 10843 | "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " |
| 10844 | "height %d.", |
| 10845 | pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, |
| 10846 | pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); |
| 10847 | } |
| 10848 | return skip_call; |
| 10849 | } |
| 10850 | |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10851 | // If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the |
| 10852 | // [load|store]Op flag must be checked |
| 10853 | // TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. |
| 10854 | template <typename T> static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { |
Mark Lobodzinski | 323c6ba | 2016-06-21 10:28:30 -0600 | [diff] [blame] | 10855 | if (color_depth_op != op && stencil_op != op) { |
| 10856 | return false; |
| 10857 | } |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10858 | bool check_color_depth_load_op = !vk_format_is_stencil_only(format); |
| 10859 | bool check_stencil_load_op = vk_format_is_depth_and_stencil(format) || !check_color_depth_load_op; |
Mark Lobodzinski | 323c6ba | 2016-06-21 10:28:30 -0600 | [diff] [blame] | 10860 | |
| 10861 | return (((check_color_depth_load_op == true) && (color_depth_op == op)) || |
| 10862 | ((check_stencil_load_op == true) && (stencil_op == op))); |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10863 | } |
| 10864 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 10865 | VKAPI_ATTR void VKAPI_CALL |
| 10866 | CmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 10867 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10868 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 10869 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10870 | GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10871 | auto renderPass = pRenderPassBegin ? getRenderPassState(dev_data, pRenderPassBegin->renderPass) : nullptr; |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10872 | auto framebuffer = pRenderPassBegin ? getFramebufferState(dev_data, pRenderPassBegin->framebuffer) : nullptr; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10873 | if (cb_node) { |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10874 | if (renderPass) { |
Tobin Ehlis | 7f0416c | 2016-07-15 16:01:13 -0600 | [diff] [blame] | 10875 | uint32_t clear_op_size = 0; // Make sure pClearValues is at least as large as last LOAD_OP_CLEAR |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10876 | cb_node->activeFramebuffer = pRenderPassBegin->framebuffer; |
Mark Lobodzinski | 4dc768c | 2016-10-03 16:01:12 -0600 | [diff] [blame] | 10877 | for (uint32_t i = 0; i < renderPass->createInfo.attachmentCount; ++i) { |
Chris Forbes | 05e03b7 | 2016-05-17 15:27:58 +1200 | [diff] [blame] | 10878 | MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10879 | auto pAttachment = &renderPass->createInfo.pAttachments[i]; |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10880 | if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, |
| 10881 | pAttachment->stencilLoadOp, |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10882 | VK_ATTACHMENT_LOAD_OP_CLEAR)) { |
Mark Lobodzinski | a8bbfde | 2016-07-20 10:02:23 -0600 | [diff] [blame] | 10883 | clear_op_size = static_cast<uint32_t>(i) + 1; |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10884 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10885 | SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), true); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10886 | return false; |
| 10887 | }; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10888 | cb_node->validate_functions.push_back(function); |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10889 | } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, |
| 10890 | pAttachment->stencilLoadOp, |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10891 | VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10892 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10893 | SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), false); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10894 | return false; |
| 10895 | }; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10896 | cb_node->validate_functions.push_back(function); |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10897 | } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, |
| 10898 | pAttachment->stencilLoadOp, |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10899 | VK_ATTACHMENT_LOAD_OP_LOAD)) { |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10900 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10901 | return ValidateImageMemoryIsValid(dev_data, getImageState(dev_data, fb_info.image), |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 10902 | "vkCmdBeginRenderPass()"); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10903 | }; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10904 | cb_node->validate_functions.push_back(function); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10905 | } |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10906 | if (renderPass->attachment_first_read[i]) { |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10907 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10908 | return ValidateImageMemoryIsValid(dev_data, getImageState(dev_data, fb_info.image), |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 10909 | "vkCmdBeginRenderPass()"); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10910 | }; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10911 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10912 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10913 | } |
Tobin Ehlis | 7f0416c | 2016-07-15 16:01:13 -0600 | [diff] [blame] | 10914 | if (clear_op_size > pRenderPassBegin->clearValueCount) { |
Slawomir Cygan | 0808f39 | 2016-11-28 17:53:23 +0100 | [diff] [blame] | 10915 | skip_call |= log_msg( |
| 10916 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| 10917 | reinterpret_cast<uint64_t &>(renderPass), __LINE__, VALIDATION_ERROR_00442, |
| 10918 | "DS", "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but there must " |
| 10919 | "be at least %u entries in pClearValues array to account for the highest index attachment in renderPass " |
| 10920 | "0x%" PRIx64 " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u. Note that the pClearValues array " |
| 10921 | "is indexed by attachment number so even if some pClearValues entries between 0 and %u correspond to " |
| 10922 | "attachments that aren't cleared they will be ignored. %s", |
| 10923 | pRenderPassBegin->clearValueCount, clear_op_size, reinterpret_cast<uint64_t &>(renderPass), clear_op_size, |
| 10924 | clear_op_size - 1, validation_error_map[VALIDATION_ERROR_00442]); |
| 10925 | } |
| 10926 | if (clear_op_size < pRenderPassBegin->clearValueCount) { |
| 10927 | skip_call |= log_msg( |
| 10928 | dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| 10929 | reinterpret_cast<uint64_t &>(renderPass), __LINE__, DRAWSTATE_RENDERPASS_TOO_MANY_CLEAR_VALUES, "DS", |
| 10930 | "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but only first %u " |
| 10931 | "entries in pClearValues array are used. The highest index attachment in renderPass 0x%" PRIx64 |
| 10932 | " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u - other pClearValues are ignored.", |
| 10933 | pRenderPassBegin->clearValueCount, clear_op_size, reinterpret_cast<uint64_t &>(renderPass), clear_op_size); |
Tobin Ehlis | 74aa54a | 2016-05-31 13:06:24 -0600 | [diff] [blame] | 10934 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 10935 | skip_call |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10936 | skip_call |= VerifyFramebufferAndRenderPassLayouts(dev_data, cb_node, pRenderPassBegin); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 10937 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBeginRenderPass()", VALIDATION_ERROR_00440); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 10938 | skip_call |= ValidateDependencies(dev_data, framebuffer, renderPass); |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10939 | skip_call |= validatePrimaryCommandBuffer(dev_data, cb_node, "vkCmdBeginRenderPass", VALIDATION_ERROR_00441); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 10940 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); |
| 10941 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_BEGINRENDERPASS); |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10942 | cb_node->activeRenderPass = renderPass; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10943 | // This is a shallow copy as that is all that is needed for now |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10944 | cb_node->activeRenderPassBeginInfo = *pRenderPassBegin; |
| 10945 | cb_node->activeSubpass = 0; |
| 10946 | cb_node->activeSubpassContents = contents; |
| 10947 | cb_node->framebuffers.insert(pRenderPassBegin->framebuffer); |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 10948 | // Connect this framebuffer and its children to this cmdBuffer |
| 10949 | AddFramebufferBinding(dev_data, cb_node, framebuffer); |
Chris Forbes | fb2aae3 | 2016-06-30 15:42:41 +1200 | [diff] [blame] | 10950 | // transition attachments to the correct layouts for the first subpass |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10951 | TransitionSubpassLayouts(dev_data, cb_node, &cb_node->activeRenderPassBeginInfo, cb_node->activeSubpass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10952 | } |
| 10953 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 10954 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 10955 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 10956 | dev_data->dispatch_table.CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10957 | } |
| 10958 | } |
| 10959 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 10960 | VKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 10961 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10962 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 10963 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10964 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10965 | if (pCB) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10966 | skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass", VALIDATION_ERROR_00459); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 10967 | skip_call |= ValidateCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); |
| 10968 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_NEXTSUBPASS); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 10969 | skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass()", VALIDATION_ERROR_00458); |
Chris Forbes | 0948afa | 2016-09-07 11:44:08 +1200 | [diff] [blame] | 10970 | |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10971 | auto subpassCount = pCB->activeRenderPass->createInfo.subpassCount; |
Chris Forbes | 0948afa | 2016-09-07 11:44:08 +1200 | [diff] [blame] | 10972 | if (pCB->activeSubpass == subpassCount - 1) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10973 | skip_call |= log_msg( |
| 10974 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 10975 | reinterpret_cast<uint64_t>(commandBuffer), __LINE__, VALIDATION_ERROR_00453, "DS", |
| 10976 | "vkCmdNextSubpass(): Attempted to advance beyond final subpass. %s", validation_error_map[VALIDATION_ERROR_00453]); |
Chris Forbes | 0948afa | 2016-09-07 11:44:08 +1200 | [diff] [blame] | 10977 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10978 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 10979 | lock.unlock(); |
Chris Forbes | 2784bcb | 2016-09-07 11:43:52 +1200 | [diff] [blame] | 10980 | |
| 10981 | if (skip_call) |
| 10982 | return; |
| 10983 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 10984 | dev_data->dispatch_table.CmdNextSubpass(commandBuffer, contents); |
Chris Forbes | 2784bcb | 2016-09-07 11:43:52 +1200 | [diff] [blame] | 10985 | |
| 10986 | if (pCB) { |
| 10987 | lock.lock(); |
| 10988 | pCB->activeSubpass++; |
| 10989 | pCB->activeSubpassContents = contents; |
| 10990 | TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); |
| 10991 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10992 | } |
| 10993 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 10994 | VKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 10995 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10996 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 10997 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 10998 | auto pCB = getCBNode(dev_data, commandBuffer); |
| 10999 | if (pCB) { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11000 | RENDER_PASS_STATE *rp_state = pCB->activeRenderPass; |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 11001 | auto framebuffer = getFramebufferState(dev_data, pCB->activeFramebuffer); |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11002 | if (rp_state) { |
| 11003 | if (pCB->activeSubpass != rp_state->createInfo.subpassCount - 1) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11004 | skip_call |= log_msg( |
| 11005 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 11006 | reinterpret_cast<uint64_t>(commandBuffer), __LINE__, VALIDATION_ERROR_00460, "DS", |
| 11007 | "vkCmdEndRenderPass(): Called before reaching final subpass. %s", validation_error_map[VALIDATION_ERROR_00460]); |
Chris Forbes | 85bb400 | 2016-09-07 14:08:31 +1200 | [diff] [blame] | 11008 | } |
| 11009 | |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11010 | for (size_t i = 0; i < rp_state->createInfo.attachmentCount; ++i) { |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 11011 | MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11012 | auto pAttachment = &rp_state->createInfo.pAttachments[i]; |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 11013 | if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, |
| 11014 | pAttachment->stencilStoreOp, VK_ATTACHMENT_STORE_OP_STORE)) { |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11015 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 11016 | SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), true); |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11017 | return false; |
| 11018 | }; |
| 11019 | pCB->validate_functions.push_back(function); |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 11020 | } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, |
| 11021 | pAttachment->stencilStoreOp, |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 11022 | VK_ATTACHMENT_STORE_OP_DONT_CARE)) { |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11023 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 11024 | SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), false); |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11025 | return false; |
| 11026 | }; |
| 11027 | pCB->validate_functions.push_back(function); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11028 | } |
| 11029 | } |
| 11030 | } |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 11031 | skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass()", VALIDATION_ERROR_00464); |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11032 | skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass", VALIDATION_ERROR_00465); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 11033 | skip_call |= ValidateCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); |
| 11034 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_ENDRENDERPASS); |
Chris Forbes | 2886a9e | 2016-09-07 13:52:28 +1200 | [diff] [blame] | 11035 | } |
| 11036 | lock.unlock(); |
| 11037 | |
| 11038 | if (skip_call) |
| 11039 | return; |
| 11040 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11041 | dev_data->dispatch_table.CmdEndRenderPass(commandBuffer); |
Chris Forbes | 2886a9e | 2016-09-07 13:52:28 +1200 | [diff] [blame] | 11042 | |
| 11043 | if (pCB) { |
| 11044 | lock.lock(); |
Chris Forbes | 05e03b7 | 2016-05-17 15:27:58 +1200 | [diff] [blame] | 11045 | TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11046 | pCB->activeRenderPass = nullptr; |
| 11047 | pCB->activeSubpass = 0; |
| 11048 | pCB->activeFramebuffer = VK_NULL_HANDLE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11049 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11050 | } |
| 11051 | |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11052 | static bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, uint32_t primaryAttach, |
| 11053 | uint32_t secondaryAttach, const char *msg) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11054 | return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11055 | VALIDATION_ERROR_02059, "DS", |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11056 | "vkCmdExecuteCommands() called w/ invalid Secondary Cmd Buffer 0x%" PRIx64 " which has a render pass " |
| 11057 | "that is not compatible with the Primary Cmd Buffer current render pass. " |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11058 | "Attachment %u is not compatible with %u: %s. %s", |
| 11059 | reinterpret_cast<uint64_t &>(secondaryBuffer), primaryAttach, secondaryAttach, msg, |
| 11060 | validation_error_map[VALIDATION_ERROR_02059]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11061 | } |
| 11062 | |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11063 | static bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, |
| 11064 | VkRenderPassCreateInfo const *primaryPassCI, uint32_t primaryAttach, |
| 11065 | VkCommandBuffer secondaryBuffer, VkRenderPassCreateInfo const *secondaryPassCI, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11066 | uint32_t secondaryAttach, bool is_multi) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11067 | bool skip_call = false; |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11068 | if (primaryPassCI->attachmentCount <= primaryAttach) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11069 | primaryAttach = VK_ATTACHMENT_UNUSED; |
| 11070 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11071 | if (secondaryPassCI->attachmentCount <= secondaryAttach) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11072 | secondaryAttach = VK_ATTACHMENT_UNUSED; |
| 11073 | } |
| 11074 | if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { |
| 11075 | return skip_call; |
| 11076 | } |
| 11077 | if (primaryAttach == VK_ATTACHMENT_UNUSED) { |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11078 | skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, |
| 11079 | "The first is unused while the second is not."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11080 | return skip_call; |
| 11081 | } |
| 11082 | if (secondaryAttach == VK_ATTACHMENT_UNUSED) { |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11083 | skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, |
| 11084 | "The second is unused while the first is not."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11085 | return skip_call; |
| 11086 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11087 | if (primaryPassCI->pAttachments[primaryAttach].format != secondaryPassCI->pAttachments[secondaryAttach].format) { |
| 11088 | skip_call |= |
| 11089 | logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different formats."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11090 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11091 | if (primaryPassCI->pAttachments[primaryAttach].samples != secondaryPassCI->pAttachments[secondaryAttach].samples) { |
| 11092 | skip_call |= |
| 11093 | logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different samples."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11094 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11095 | if (is_multi && primaryPassCI->pAttachments[primaryAttach].flags != secondaryPassCI->pAttachments[secondaryAttach].flags) { |
| 11096 | skip_call |= |
| 11097 | logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different flags."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11098 | } |
| 11099 | return skip_call; |
| 11100 | } |
| 11101 | |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11102 | static bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, |
| 11103 | VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, |
| 11104 | VkRenderPassCreateInfo const *secondaryPassCI, const int subpass, bool is_multi) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11105 | bool skip_call = false; |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11106 | const VkSubpassDescription &primary_desc = primaryPassCI->pSubpasses[subpass]; |
| 11107 | const VkSubpassDescription &secondary_desc = secondaryPassCI->pSubpasses[subpass]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11108 | uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); |
| 11109 | for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { |
| 11110 | uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; |
| 11111 | if (i < primary_desc.inputAttachmentCount) { |
| 11112 | primary_input_attach = primary_desc.pInputAttachments[i].attachment; |
| 11113 | } |
| 11114 | if (i < secondary_desc.inputAttachmentCount) { |
| 11115 | secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; |
| 11116 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11117 | skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_input_attach, secondaryBuffer, |
| 11118 | secondaryPassCI, secondary_input_attach, is_multi); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11119 | } |
| 11120 | uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); |
| 11121 | for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { |
| 11122 | uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; |
| 11123 | if (i < primary_desc.colorAttachmentCount) { |
| 11124 | primary_color_attach = primary_desc.pColorAttachments[i].attachment; |
| 11125 | } |
| 11126 | if (i < secondary_desc.colorAttachmentCount) { |
| 11127 | secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; |
| 11128 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11129 | skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_color_attach, secondaryBuffer, |
| 11130 | secondaryPassCI, secondary_color_attach, is_multi); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11131 | uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; |
| 11132 | if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { |
| 11133 | primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; |
| 11134 | } |
| 11135 | if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { |
| 11136 | secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; |
| 11137 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11138 | skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_resolve_attach, |
| 11139 | secondaryBuffer, secondaryPassCI, secondary_resolve_attach, is_multi); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11140 | } |
| 11141 | uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; |
| 11142 | if (primary_desc.pDepthStencilAttachment) { |
| 11143 | primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; |
| 11144 | } |
| 11145 | if (secondary_desc.pDepthStencilAttachment) { |
| 11146 | secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; |
| 11147 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11148 | skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_depthstencil_attach, |
| 11149 | secondaryBuffer, secondaryPassCI, secondary_depthstencil_attach, is_multi); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11150 | return skip_call; |
| 11151 | } |
| 11152 | |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11153 | // Verify that given renderPass CreateInfo for primary and secondary command buffers are compatible. |
| 11154 | // This function deals directly with the CreateInfo, there are overloaded versions below that can take the renderPass handle and |
| 11155 | // will then feed into this function |
| 11156 | static bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, |
| 11157 | VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, |
| 11158 | VkRenderPassCreateInfo const *secondaryPassCI) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11159 | bool skip_call = false; |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11160 | |
| 11161 | if (primaryPassCI->subpassCount != secondaryPassCI->subpassCount) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11162 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 11163 | DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11164 | "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 |
| 11165 | " that has a subpassCount of %u that is incompatible with the primary Cmd Buffer 0x%" PRIx64 |
| 11166 | " that has a subpassCount of %u.", |
| 11167 | reinterpret_cast<uint64_t &>(secondaryBuffer), secondaryPassCI->subpassCount, |
| 11168 | reinterpret_cast<uint64_t &>(primaryBuffer), primaryPassCI->subpassCount); |
| 11169 | } else { |
| 11170 | for (uint32_t i = 0; i < primaryPassCI->subpassCount; ++i) { |
| 11171 | skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primaryPassCI, secondaryBuffer, secondaryPassCI, i, |
| 11172 | primaryPassCI->subpassCount > 1); |
| 11173 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11174 | } |
| 11175 | return skip_call; |
| 11176 | } |
| 11177 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11178 | static bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, |
| 11179 | VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11180 | bool skip_call = false; |
| 11181 | if (!pSubCB->beginInfo.pInheritanceInfo) { |
| 11182 | return skip_call; |
| 11183 | } |
Chris Forbes | 89ca84a | 2016-05-13 16:23:58 +1200 | [diff] [blame] | 11184 | VkFramebuffer primary_fb = pCB->activeFramebuffer; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11185 | VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; |
| 11186 | if (secondary_fb != VK_NULL_HANDLE) { |
| 11187 | if (primary_fb != secondary_fb) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11188 | skip_call |= log_msg( |
| 11189 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 11190 | VALIDATION_ERROR_02060, "DS", |
| 11191 | "vkCmdExecuteCommands() called w/ invalid secondary command buffer 0x%" PRIx64 " which has a framebuffer 0x%" PRIx64 |
| 11192 | " that is not the same as the primary command buffer's current active framebuffer 0x%" PRIx64 ". %s", |
| 11193 | reinterpret_cast<uint64_t &>(secondaryBuffer), reinterpret_cast<uint64_t &>(secondary_fb), |
| 11194 | reinterpret_cast<uint64_t &>(primary_fb), validation_error_map[VALIDATION_ERROR_02060]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11195 | } |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 11196 | auto fb = getFramebufferState(dev_data, secondary_fb); |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 11197 | if (!fb) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11198 | skip_call |= |
| 11199 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11200 | DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " |
| 11201 | "which has invalid framebuffer 0x%" PRIx64 ".", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11202 | (void *)secondaryBuffer, (uint64_t)(secondary_fb)); |
| 11203 | return skip_call; |
| 11204 | } |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11205 | auto cb_renderpass = getRenderPassState(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11206 | if (cb_renderpass->renderPass != fb->createInfo.renderPass) { |
| 11207 | skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->renderPassCreateInfo.ptr(), secondaryBuffer, |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 11208 | cb_renderpass->createInfo.ptr()); |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11209 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11210 | } |
| 11211 | return skip_call; |
| 11212 | } |
| 11213 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11214 | static bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11215 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11216 | unordered_set<int> activeTypes; |
| 11217 | for (auto queryObject : pCB->activeQueries) { |
| 11218 | auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); |
| 11219 | if (queryPoolData != dev_data->queryPoolMap.end()) { |
| 11220 | if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && |
| 11221 | pSubCB->beginInfo.pInheritanceInfo) { |
| 11222 | VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; |
| 11223 | if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11224 | skip_call |= |
| 11225 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 11226 | VALIDATION_ERROR_02065, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " |
| 11227 | "which has invalid active query pool 0x%" PRIx64 |
| 11228 | ". Pipeline statistics is being queried so the command " |
| 11229 | "buffer must have all bits set on the queryPool. %s", |
| 11230 | pCB->commandBuffer, reinterpret_cast<const uint64_t &>(queryPoolData->first), |
| 11231 | validation_error_map[VALIDATION_ERROR_02065]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11232 | } |
| 11233 | } |
| 11234 | activeTypes.insert(queryPoolData->second.createInfo.queryType); |
| 11235 | } |
| 11236 | } |
| 11237 | for (auto queryObject : pSubCB->startedQueries) { |
| 11238 | auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); |
| 11239 | if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11240 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11241 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 11242 | DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11243 | "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " |
| 11244 | "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " |
| 11245 | "secondary Cmd Buffer 0x%p.", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11246 | pCB->commandBuffer, reinterpret_cast<const uint64_t &>(queryPoolData->first), |
| 11247 | queryPoolData->second.createInfo.queryType, pSubCB->commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11248 | } |
| 11249 | } |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 11250 | |
| 11251 | auto primary_pool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); |
| 11252 | auto secondary_pool = getCommandPoolNode(dev_data, pSubCB->createInfo.commandPool); |
| 11253 | if (primary_pool && secondary_pool && (primary_pool->queueFamilyIndex != secondary_pool->queueFamilyIndex)) { |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11254 | skip_call |= |
| 11255 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 11256 | reinterpret_cast<uint64_t>(pSubCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", |
| 11257 | "vkCmdExecuteCommands(): Primary command buffer 0x%p" |
| 11258 | " created in queue family %d has secondary command buffer 0x%p created in queue family %d.", |
| 11259 | pCB->commandBuffer, primary_pool->queueFamilyIndex, pSubCB->commandBuffer, secondary_pool->queueFamilyIndex); |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 11260 | } |
| 11261 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11262 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11263 | } |
| 11264 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11265 | VKAPI_ATTR void VKAPI_CALL |
| 11266 | CmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11267 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11268 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11269 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11270 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 11271 | if (pCB) { |
| 11272 | GLOBAL_CB_NODE *pSubCB = NULL; |
| 11273 | for (uint32_t i = 0; i < commandBuffersCount; i++) { |
| 11274 | pSubCB = getCBNode(dev_data, pCommandBuffers[i]); |
Tobin Ehlis | 44ba5fc | 2017-01-03 14:07:17 -0700 | [diff] [blame] | 11275 | assert(pSubCB); |
| 11276 | if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11277 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11278 | __LINE__, VALIDATION_ERROR_00153, "DS", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11279 | "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11280 | "array. All cmd buffers in pCommandBuffers array must be secondary. %s", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11281 | pCommandBuffers[i], i, validation_error_map[VALIDATION_ERROR_00153]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11282 | } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11283 | auto secondary_rp_state = getRenderPassState(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11284 | if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11285 | skip_call |= log_msg( |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11286 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11287 | (uint64_t)pCommandBuffers[i], __LINE__, VALIDATION_ERROR_02057, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11288 | "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11289 | ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set. %s", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11290 | pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass, |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11291 | validation_error_map[VALIDATION_ERROR_02057]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11292 | } else { |
| 11293 | // Make sure render pass is compatible with parent command buffer pass if has continue |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11294 | if (pCB->activeRenderPass->renderPass != secondary_rp_state->renderPass) { |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 11295 | skip_call |= |
| 11296 | validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->createInfo.ptr(), |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11297 | pCommandBuffers[i], secondary_rp_state->createInfo.ptr()); |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11298 | } |
Tobin Ehlis | f77f5cc | 2016-07-19 10:45:24 -0600 | [diff] [blame] | 11299 | // If framebuffer for secondary CB is not NULL, then it must match active FB from primaryCB |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11300 | skip_call |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11301 | } |
| 11302 | string errorString = ""; |
Tobin Ehlis | f77f5cc | 2016-07-19 10:45:24 -0600 | [diff] [blame] | 11303 | // secondaryCB must have been created w/ RP compatible w/ primaryCB active renderpass |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11304 | if ((pCB->activeRenderPass->renderPass != secondary_rp_state->renderPass) && |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 11305 | !verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->createInfo.ptr(), |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11306 | secondary_rp_state->createInfo.ptr(), errorString)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11307 | skip_call |= log_msg( |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11308 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 11309 | (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11310 | "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 |
| 11311 | ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11312 | pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, commandBuffer, |
Chris Forbes | a4937a7 | 2016-05-06 16:31:14 +1200 | [diff] [blame] | 11313 | (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11314 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11315 | } |
| 11316 | // TODO(mlentine): Move more logic into this method |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11317 | skip_call |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); |
Tobin Ehlis | f7cf915 | 2016-09-27 13:10:33 -0600 | [diff] [blame] | 11318 | skip_call |= validateCommandBufferState(dev_data, pSubCB, "vkCmdExecuteCommands()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11319 | // Secondary cmdBuffers are considered pending execution starting w/ |
| 11320 | // being recorded |
| 11321 | if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { |
| 11322 | if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11323 | skip_call |= |
| 11324 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 11325 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)(pCB->commandBuffer), __LINE__, |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11326 | VALIDATION_ERROR_00154, "DS", "Attempt to simultaneously execute command buffer 0x%p" |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11327 | " without VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set! %s", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11328 | pCB->commandBuffer, validation_error_map[VALIDATION_ERROR_00154]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11329 | } |
| 11330 | if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { |
| 11331 | // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11332 | skip_call |= log_msg( |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11333 | dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 11334 | (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11335 | "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) " |
| 11336 | "does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " |
| 11337 | "(0x%p) to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11338 | "set, even though it does.", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11339 | pCommandBuffers[i], pCB->commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11340 | pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; |
| 11341 | } |
| 11342 | } |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 11343 | if (!pCB->activeQueries.empty() && !dev_data->enabled_features.inheritedQueries) { |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11344 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 11345 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(pCommandBuffers[i]), |
| 11346 | __LINE__, VALIDATION_ERROR_02062, "DS", "vkCmdExecuteCommands(): Secondary Command Buffer " |
| 11347 | "(0x%p) cannot be submitted with a query in " |
| 11348 | "flight and inherited queries not " |
| 11349 | "supported on this device. %s", |
| 11350 | pCommandBuffers[i], validation_error_map[VALIDATION_ERROR_02062]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11351 | } |
Tobin Ehlis | d6280b1 | 2016-11-03 10:46:44 -0600 | [diff] [blame] | 11352 | // Propagate layout transitions to the primary cmd buffer |
| 11353 | for (auto ilm_entry : pSubCB->imageLayoutMap) { |
| 11354 | SetLayout(pCB, ilm_entry.first, ilm_entry.second); |
| 11355 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11356 | pSubCB->primaryCommandBuffer = pCB->commandBuffer; |
| 11357 | pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); |
| 11358 | dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); |
Michael Lentine | f01fb38 | 2016-07-21 17:24:56 -0500 | [diff] [blame] | 11359 | for (auto &function : pSubCB->queryUpdates) { |
| 11360 | pCB->queryUpdates.push_back(function); |
| 11361 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11362 | } |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11363 | skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands", VALIDATION_ERROR_00163); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 11364 | skip_call |= ValidateCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); |
| 11365 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_EXECUTECOMMANDS); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11366 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11367 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11368 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11369 | dev_data->dispatch_table.CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11370 | } |
| 11371 | |
Tobin Ehlis | 9e40f0d | 2016-08-04 10:17:19 -0600 | [diff] [blame] | 11372 | // For any image objects that overlap mapped memory, verify that their layouts are PREINIT or GENERAL |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11373 | static bool ValidateMapImageLayouts(VkDevice device, DEVICE_MEM_INFO const *mem_info, VkDeviceSize offset, |
Tobin Ehlis | 0a78ef9 | 2016-08-12 14:12:44 -0600 | [diff] [blame] | 11374 | VkDeviceSize end_offset) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11375 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11376 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11377 | // Iterate over all bound image ranges and verify that for any that overlap the |
| 11378 | // map ranges, the layouts are VK_IMAGE_LAYOUT_PREINITIALIZED or VK_IMAGE_LAYOUT_GENERAL |
| 11379 | // TODO : This can be optimized if we store ranges based on starting address and early exit when we pass our range |
| 11380 | for (auto image_handle : mem_info->bound_images) { |
| 11381 | auto img_it = mem_info->bound_ranges.find(image_handle); |
| 11382 | if (img_it != mem_info->bound_ranges.end()) { |
Tobin Ehlis | 0a78ef9 | 2016-08-12 14:12:44 -0600 | [diff] [blame] | 11383 | if (rangesIntersect(dev_data, &img_it->second, offset, end_offset)) { |
Tobin Ehlis | 9e40f0d | 2016-08-04 10:17:19 -0600 | [diff] [blame] | 11384 | std::vector<VkImageLayout> layouts; |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 11385 | if (FindLayouts(dev_data, VkImage(image_handle), layouts)) { |
Tobin Ehlis | 9e40f0d | 2016-08-04 10:17:19 -0600 | [diff] [blame] | 11386 | for (auto layout : layouts) { |
| 11387 | if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { |
| 11388 | skip_call |= |
| 11389 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 11390 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " |
| 11391 | "GENERAL or PREINITIALIZED are supported.", |
| 11392 | string_VkImageLayout(layout)); |
| 11393 | } |
| 11394 | } |
| 11395 | } |
| 11396 | } |
| 11397 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11398 | } |
| 11399 | return skip_call; |
| 11400 | } |
| 11401 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11402 | VKAPI_ATTR VkResult VKAPI_CALL |
| 11403 | MapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11404 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 11405 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11406 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11407 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11408 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11409 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); |
| 11410 | if (mem_info) { |
Tobin Ehlis | c3e9c7b | 2016-08-10 17:00:51 -0600 | [diff] [blame] | 11411 | // TODO : This could me more fine-grained to track just region that is valid |
| 11412 | mem_info->global_valid = true; |
Tobin Ehlis | 0a78ef9 | 2016-08-12 14:12:44 -0600 | [diff] [blame] | 11413 | auto end_offset = (VK_WHOLE_SIZE == size) ? mem_info->alloc_info.allocationSize - 1 : offset + size - 1; |
| 11414 | skip_call |= ValidateMapImageLayouts(device, mem_info, offset, end_offset); |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11415 | // TODO : Do we need to create new "bound_range" for the mapped range? |
Tobin Ehlis | 0a78ef9 | 2016-08-12 14:12:44 -0600 | [diff] [blame] | 11416 | SetMemRangesValid(dev_data, mem_info, offset, end_offset); |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11417 | if ((dev_data->phys_dev_mem_props.memoryTypes[mem_info->alloc_info.memoryTypeIndex].propertyFlags & |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 11418 | VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11419 | skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 11420 | (uint64_t)mem, __LINE__, VALIDATION_ERROR_00629, "MEM", |
| 11421 | "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64 ". %s", |
| 11422 | (uint64_t)mem, validation_error_map[VALIDATION_ERROR_00629]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11423 | } |
| 11424 | } |
Tobin Ehlis | b495d5f | 2016-08-04 09:33:02 -0600 | [diff] [blame] | 11425 | skip_call |= ValidateMapMemRange(dev_data, mem, offset, size); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11426 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11427 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11428 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11429 | result = dev_data->dispatch_table.MapMemory(device, mem, offset, size, flags, ppData); |
Tobin Ehlis | d094c27 | 2016-05-12 08:31:32 -0600 | [diff] [blame] | 11430 | if (VK_SUCCESS == result) { |
Tobin Ehlis | d094c27 | 2016-05-12 08:31:32 -0600 | [diff] [blame] | 11431 | lock.lock(); |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11432 | // TODO : What's the point of this range? See comment on creating new "bound_range" above, which may replace this |
Tobin Ehlis | d094c27 | 2016-05-12 08:31:32 -0600 | [diff] [blame] | 11433 | storeMemRanges(dev_data, mem, offset, size); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11434 | initializeAndTrackMemory(dev_data, mem, offset, size, ppData); |
Tobin Ehlis | d094c27 | 2016-05-12 08:31:32 -0600 | [diff] [blame] | 11435 | lock.unlock(); |
Tobin Ehlis | d094c27 | 2016-05-12 08:31:32 -0600 | [diff] [blame] | 11436 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11437 | } |
| 11438 | return result; |
| 11439 | } |
| 11440 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11441 | VKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11442 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11443 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11444 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11445 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11446 | skip_call |= deleteMemRanges(dev_data, mem); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11447 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11448 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11449 | dev_data->dispatch_table.UnmapMemory(device, mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11450 | } |
| 11451 | } |
| 11452 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11453 | static bool validateMemoryIsMapped(layer_data *dev_data, const char *funcName, uint32_t memRangeCount, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11454 | const VkMappedMemoryRange *pMemRanges) { |
Mark Lobodzinski | 4a95cfe | 2016-11-15 13:55:22 -0700 | [diff] [blame] | 11455 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11456 | for (uint32_t i = 0; i < memRangeCount; ++i) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11457 | auto mem_info = getMemObjInfo(dev_data, pMemRanges[i].memory); |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 11458 | if (mem_info) { |
Mark Lobodzinski | b3c675e | 2016-11-15 08:56:03 -0700 | [diff] [blame] | 11459 | if (pMemRanges[i].size == VK_WHOLE_SIZE) { |
| 11460 | if (mem_info->mem_range.offset > pMemRanges[i].offset) { |
Mark Lobodzinski | 4a95cfe | 2016-11-15 13:55:22 -0700 | [diff] [blame] | 11461 | skip |= |
Mark Lobodzinski | b3c675e | 2016-11-15 08:56:03 -0700 | [diff] [blame] | 11462 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 11463 | (uint64_t)pMemRanges[i].memory, __LINE__, VALIDATION_ERROR_00643, "MEM", |
| 11464 | "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " |
| 11465 | "(" PRINTF_SIZE_T_SPECIFIER "). %s", |
| 11466 | funcName, static_cast<size_t>(pMemRanges[i].offset), |
| 11467 | static_cast<size_t>(mem_info->mem_range.offset), validation_error_map[VALIDATION_ERROR_00643]); |
| 11468 | } |
| 11469 | } else { |
| 11470 | const uint64_t data_end = (mem_info->mem_range.size == VK_WHOLE_SIZE) |
| 11471 | ? mem_info->alloc_info.allocationSize |
| 11472 | : (mem_info->mem_range.offset + mem_info->mem_range.size); |
| 11473 | if ((mem_info->mem_range.offset > pMemRanges[i].offset) || |
| 11474 | (data_end < (pMemRanges[i].offset + pMemRanges[i].size))) { |
Mark Lobodzinski | 4a95cfe | 2016-11-15 13:55:22 -0700 | [diff] [blame] | 11475 | skip |= |
Mark Lobodzinski | b3c675e | 2016-11-15 08:56:03 -0700 | [diff] [blame] | 11476 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 11477 | (uint64_t)pMemRanges[i].memory, __LINE__, VALIDATION_ERROR_00642, "MEM", |
| 11478 | "%s: Flush/Invalidate size or offset (" PRINTF_SIZE_T_SPECIFIER ", " PRINTF_SIZE_T_SPECIFIER |
| 11479 | ") exceed the Memory Object's upper-bound " |
| 11480 | "(" PRINTF_SIZE_T_SPECIFIER "). %s", |
| 11481 | funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), |
| 11482 | static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(data_end), |
| 11483 | validation_error_map[VALIDATION_ERROR_00642]); |
| 11484 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11485 | } |
| 11486 | } |
| 11487 | } |
Mark Lobodzinski | 4a95cfe | 2016-11-15 13:55:22 -0700 | [diff] [blame] | 11488 | return skip; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11489 | } |
| 11490 | |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11491 | static bool ValidateAndCopyNoncoherentMemoryToDriver(layer_data *dev_data, uint32_t mem_range_count, |
| 11492 | const VkMappedMemoryRange *mem_ranges) { |
| 11493 | bool skip = false; |
| 11494 | for (uint32_t i = 0; i < mem_range_count; ++i) { |
| 11495 | auto mem_info = getMemObjInfo(dev_data, mem_ranges[i].memory); |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 11496 | if (mem_info) { |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11497 | if (mem_info->shadow_copy) { |
| 11498 | VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) |
| 11499 | ? mem_info->mem_range.size |
Tobin Ehlis | 968f5dd | 2016-10-05 07:50:25 -0600 | [diff] [blame] | 11500 | : (mem_info->alloc_info.allocationSize - mem_info->mem_range.offset); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11501 | char *data = static_cast<char *>(mem_info->shadow_copy); |
| 11502 | for (uint64_t j = 0; j < mem_info->shadow_pad_size; ++j) { |
| 11503 | if (data[j] != NoncoherentMemoryFillValue) { |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11504 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 11505 | VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem_ranges[i].memory, __LINE__, |
| 11506 | MEMTRACK_INVALID_MAP, "MEM", "Memory underflow was detected on mem obj 0x%" PRIxLEAST64, |
| 11507 | (uint64_t)mem_ranges[i].memory); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11508 | } |
| 11509 | } |
| 11510 | for (uint64_t j = (size + mem_info->shadow_pad_size); j < (2 * mem_info->shadow_pad_size + size); ++j) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11511 | if (data[j] != NoncoherentMemoryFillValue) { |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11512 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 11513 | VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem_ranges[i].memory, __LINE__, |
| 11514 | MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, |
| 11515 | (uint64_t)mem_ranges[i].memory); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11516 | } |
| 11517 | } |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11518 | memcpy(mem_info->p_driver_data, static_cast<void *>(data + mem_info->shadow_pad_size), (size_t)(size)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11519 | } |
| 11520 | } |
| 11521 | } |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11522 | return skip; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11523 | } |
| 11524 | |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11525 | static void CopyNoncoherentMemoryFromDriver(layer_data *dev_data, uint32_t mem_range_count, const VkMappedMemoryRange *mem_ranges) { |
| 11526 | for (uint32_t i = 0; i < mem_range_count; ++i) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11527 | auto mem_info = getMemObjInfo(dev_data, mem_ranges[i].memory); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11528 | if (mem_info && mem_info->shadow_copy) { |
| 11529 | VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) |
| 11530 | ? mem_info->mem_range.size |
| 11531 | : (mem_info->alloc_info.allocationSize - mem_ranges[i].offset); |
| 11532 | char *data = static_cast<char *>(mem_info->shadow_copy); |
| 11533 | memcpy(data + mem_info->shadow_pad_size, mem_info->p_driver_data, (size_t)(size)); |
Mark Lobodzinski | bc4d620 | 2016-08-16 09:06:15 -0600 | [diff] [blame] | 11534 | } |
| 11535 | } |
| 11536 | } |
| 11537 | |
Mark Lobodzinski | dcefe7f | 2016-11-14 16:28:01 -0700 | [diff] [blame] | 11538 | static bool ValidateMappedMemoryRangeDeviceLimits(layer_data *dev_data, const char *func_name, uint32_t mem_range_count, |
| 11539 | const VkMappedMemoryRange *mem_ranges) { |
| 11540 | bool skip = false; |
| 11541 | for (uint32_t i = 0; i < mem_range_count; ++i) { |
| 11542 | uint64_t atom_size = dev_data->phys_dev_properties.properties.limits.nonCoherentAtomSize; |
| 11543 | if (vk_safe_modulo(mem_ranges[i].offset, atom_size) != 0) { |
| 11544 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 11545 | __LINE__, VALIDATION_ERROR_00644, "MEM", |
| 11546 | "%s: Offset in pMemRanges[%d] is 0x%" PRIxLEAST64 |
| 11547 | ", which is not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (0x%" PRIxLEAST64 "). %s", |
| 11548 | func_name, i, mem_ranges[i].offset, atom_size, validation_error_map[VALIDATION_ERROR_00644]); |
| 11549 | } |
| 11550 | if ((mem_ranges[i].size != VK_WHOLE_SIZE) && (vk_safe_modulo(mem_ranges[i].size, atom_size) != 0)) { |
| 11551 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 11552 | __LINE__, VALIDATION_ERROR_00645, "MEM", |
| 11553 | "%s: Size in pMemRanges[%d] is 0x%" PRIxLEAST64 |
| 11554 | ", which is not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (0x%" PRIxLEAST64 "). %s", |
| 11555 | func_name, i, mem_ranges[i].size, atom_size, validation_error_map[VALIDATION_ERROR_00645]); |
| 11556 | } |
| 11557 | } |
| 11558 | return skip; |
| 11559 | } |
| 11560 | |
Mark Lobodzinski | 16ae440 | 2016-11-15 07:59:58 -0700 | [diff] [blame] | 11561 | static bool PreCallValidateFlushMappedMemoryRanges(layer_data *dev_data, uint32_t mem_range_count, |
| 11562 | const VkMappedMemoryRange *mem_ranges) { |
| 11563 | bool skip = false; |
| 11564 | std::lock_guard<std::mutex> lock(global_lock); |
| 11565 | skip |= ValidateAndCopyNoncoherentMemoryToDriver(dev_data, mem_range_count, mem_ranges); |
| 11566 | skip |= validateMemoryIsMapped(dev_data, "vkFlushMappedMemoryRanges", mem_range_count, mem_ranges); |
| 11567 | return skip; |
| 11568 | } |
| 11569 | |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11570 | VKAPI_ATTR VkResult VKAPI_CALL FlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, |
| 11571 | const VkMappedMemoryRange *pMemRanges) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11572 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11573 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11574 | |
Mark Lobodzinski | 16ae440 | 2016-11-15 07:59:58 -0700 | [diff] [blame] | 11575 | if (!PreCallValidateFlushMappedMemoryRanges(dev_data, memRangeCount, pMemRanges)) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11576 | result = dev_data->dispatch_table.FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11577 | } |
| 11578 | return result; |
| 11579 | } |
| 11580 | |
Mark Lobodzinski | 16ae440 | 2016-11-15 07:59:58 -0700 | [diff] [blame] | 11581 | static bool PreCallValidateInvalidateMappedMemoryRanges(layer_data *dev_data, uint32_t mem_range_count, |
| 11582 | const VkMappedMemoryRange *mem_ranges) { |
| 11583 | bool skip = false; |
| 11584 | std::lock_guard<std::mutex> lock(global_lock); |
| 11585 | skip |= validateMemoryIsMapped(dev_data, "vkInvalidateMappedMemoryRanges", mem_range_count, mem_ranges); |
| 11586 | return skip; |
| 11587 | } |
| 11588 | |
| 11589 | static void PostCallRecordInvalidateMappedMemoryRanges(layer_data *dev_data, uint32_t mem_range_count, |
| 11590 | const VkMappedMemoryRange *mem_ranges) { |
| 11591 | std::lock_guard<std::mutex> lock(global_lock); |
| 11592 | // Update our shadow copy with modified driver data |
| 11593 | CopyNoncoherentMemoryFromDriver(dev_data, mem_range_count, mem_ranges); |
| 11594 | } |
| 11595 | |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11596 | VKAPI_ATTR VkResult VKAPI_CALL InvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, |
| 11597 | const VkMappedMemoryRange *pMemRanges) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11598 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11599 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11600 | |
Mark Lobodzinski | 16ae440 | 2016-11-15 07:59:58 -0700 | [diff] [blame] | 11601 | if (!PreCallValidateInvalidateMappedMemoryRanges(dev_data, memRangeCount, pMemRanges)) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11602 | result = dev_data->dispatch_table.InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); |
Mark Lobodzinski | 16ae440 | 2016-11-15 07:59:58 -0700 | [diff] [blame] | 11603 | if (result == VK_SUCCESS) { |
| 11604 | PostCallRecordInvalidateMappedMemoryRanges(dev_data, memRangeCount, pMemRanges); |
| 11605 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11606 | } |
| 11607 | return result; |
| 11608 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11609 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11610 | VKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11611 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 11612 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11613 | bool skip_call = false; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11614 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 11615 | auto image_state = getImageState(dev_data, image); |
| 11616 | if (image_state) { |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 11617 | // Track objects tied to memory |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 11618 | uint64_t image_handle = reinterpret_cast<uint64_t &>(image); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 11619 | skip_call = SetMemBinding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); |
Tobin Ehlis | 9cb8440 | 2016-11-17 13:51:54 -0700 | [diff] [blame] | 11620 | if (!image_state->memory_requirements_checked) { |
| 11621 | // There's not an explicit requirement in the spec to call vkGetImageMemoryRequirements() prior to calling |
| 11622 | // BindImageMemory but it's implied in that memory being bound must conform with VkMemoryRequirements from |
| 11623 | // vkGetImageMemoryRequirements() |
| 11624 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 11625 | image_handle, __LINE__, DRAWSTATE_INVALID_IMAGE, "DS", |
Mark Lobodzinski | fa57226 | 2016-11-22 15:29:38 -0700 | [diff] [blame] | 11626 | "vkBindImageMemory(): Binding memory to image 0x%" PRIxLEAST64 |
Tobin Ehlis | 9cb8440 | 2016-11-17 13:51:54 -0700 | [diff] [blame] | 11627 | " but vkGetImageMemoryRequirements() has not been called on that image.", |
| 11628 | image_handle); |
| 11629 | // Make the call for them so we can verify the state |
| 11630 | lock.unlock(); |
| 11631 | dev_data->dispatch_table.GetImageMemoryRequirements(device, image, &image_state->requirements); |
| 11632 | lock.lock(); |
| 11633 | } |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 11634 | |
| 11635 | // Track and validate bound memory range information |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 11636 | auto mem_info = getMemObjInfo(dev_data, mem); |
| 11637 | if (mem_info) { |
Tobin Ehlis | 9cb8440 | 2016-11-17 13:51:54 -0700 | [diff] [blame] | 11638 | skip_call |= InsertImageMemoryRange(dev_data, image, mem_info, memoryOffset, image_state->requirements, |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 11639 | image_state->createInfo.tiling == VK_IMAGE_TILING_LINEAR); |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 11640 | skip_call |= ValidateMemoryTypes(dev_data, mem_info, image_state->requirements.memoryTypeBits, "vkBindImageMemory()", |
| 11641 | VALIDATION_ERROR_00806); |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 11642 | } |
| 11643 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11644 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11645 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11646 | result = dev_data->dispatch_table.BindImageMemory(device, image, mem, memoryOffset); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11647 | lock.lock(); |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 11648 | image_state->binding.mem = mem; |
| 11649 | image_state->binding.offset = memoryOffset; |
Tobin Ehlis | 9cb8440 | 2016-11-17 13:51:54 -0700 | [diff] [blame] | 11650 | image_state->binding.size = image_state->requirements.size; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11651 | lock.unlock(); |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 11652 | } |
| 11653 | } else { |
| 11654 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 11655 | reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11656 | "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 11657 | reinterpret_cast<const uint64_t &>(image)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11658 | } |
| 11659 | return result; |
| 11660 | } |
| 11661 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11662 | VKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { |
Tobin Ehlis | 3f9e8f9 | 2016-04-13 16:18:28 -0600 | [diff] [blame] | 11663 | bool skip_call = false; |
| 11664 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11665 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11666 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 11667 | auto event_state = getEventNode(dev_data, event); |
| 11668 | if (event_state) { |
| 11669 | event_state->needsSignaled = false; |
| 11670 | event_state->stageMask = VK_PIPELINE_STAGE_HOST_BIT; |
| 11671 | if (event_state->write_in_use) { |
Tobin Ehlis | 3f9e8f9 | 2016-04-13 16:18:28 -0600 | [diff] [blame] | 11672 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, |
| 11673 | reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11674 | "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", |
Tobin Ehlis | 3f9e8f9 | 2016-04-13 16:18:28 -0600 | [diff] [blame] | 11675 | reinterpret_cast<const uint64_t &>(event)); |
| 11676 | } |
| 11677 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11678 | lock.unlock(); |
Tobin Ehlis | e6ab693 | 2016-04-07 11:35:46 -0600 | [diff] [blame] | 11679 | // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event |
| 11680 | // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the |
| 11681 | // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) |
| 11682 | for (auto queue_data : dev_data->queueMap) { |
| 11683 | auto event_entry = queue_data.second.eventToStageMap.find(event); |
| 11684 | if (event_entry != queue_data.second.eventToStageMap.end()) { |
| 11685 | event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; |
| 11686 | } |
| 11687 | } |
Tobin Ehlis | 3f9e8f9 | 2016-04-13 16:18:28 -0600 | [diff] [blame] | 11688 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11689 | result = dev_data->dispatch_table.SetEvent(device, event); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11690 | return result; |
| 11691 | } |
| 11692 | |
| 11693 | VKAPI_ATTR VkResult VKAPI_CALL |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11694 | QueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11695 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
| 11696 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11697 | bool skip_call = false; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11698 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 11699 | auto pFence = getFenceNode(dev_data, fence); |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 11700 | auto pQueue = getQueueState(dev_data, queue); |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 11701 | |
Tobin Ehlis | b13975e | 2016-04-14 07:02:43 -0600 | [diff] [blame] | 11702 | // First verify that fence is not in use |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 11703 | skip_call |= ValidateFenceForSubmit(dev_data, pFence); |
| 11704 | |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11705 | if (pFence) { |
| 11706 | SubmitFence(pQueue, pFence, bindInfoCount); |
Tobin Ehlis | b13975e | 2016-04-14 07:02:43 -0600 | [diff] [blame] | 11707 | } |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 11708 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11709 | for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { |
| 11710 | const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11711 | // Track objects tied to memory |
| 11712 | for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { |
| 11713 | for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 11714 | auto sparse_binding = bindInfo.pBufferBinds[j].pBinds[k]; |
| 11715 | if (SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, sparse_binding.size}, |
| 11716 | (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 11717 | "vkQueueBindSparse")) |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11718 | skip_call = true; |
| 11719 | } |
| 11720 | } |
| 11721 | for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { |
| 11722 | for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 11723 | auto sparse_binding = bindInfo.pImageOpaqueBinds[j].pBinds[k]; |
| 11724 | if (SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, sparse_binding.size}, |
| 11725 | (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 11726 | "vkQueueBindSparse")) |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11727 | skip_call = true; |
| 11728 | } |
| 11729 | } |
| 11730 | for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { |
| 11731 | for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 11732 | auto sparse_binding = bindInfo.pImageBinds[j].pBinds[k]; |
| 11733 | // TODO: This size is broken for non-opaque bindings, need to update to comprehend full sparse binding data |
| 11734 | VkDeviceSize size = sparse_binding.extent.depth * sparse_binding.extent.height * sparse_binding.extent.width * 4; |
| 11735 | if (SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, size}, |
| 11736 | (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 11737 | "vkQueueBindSparse")) |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11738 | skip_call = true; |
| 11739 | } |
| 11740 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11741 | |
| 11742 | std::vector<SEMAPHORE_WAIT> semaphore_waits; |
| 11743 | std::vector<VkSemaphore> semaphore_signals; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11744 | for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 11745 | VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; |
| 11746 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
| 11747 | if (pSemaphore) { |
| 11748 | if (pSemaphore->signaled) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11749 | if (pSemaphore->signaler.first != VK_NULL_HANDLE) { |
| 11750 | semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); |
| 11751 | pSemaphore->in_use.fetch_add(1); |
| 11752 | } |
| 11753 | pSemaphore->signaler.first = VK_NULL_HANDLE; |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 11754 | pSemaphore->signaled = false; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11755 | } else { |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11756 | skip_call |= log_msg( |
| 11757 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| 11758 | reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| 11759 | "vkQueueBindSparse: Queue 0x%p is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", |
| 11760 | queue, reinterpret_cast<const uint64_t &>(semaphore)); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11761 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11762 | } |
| 11763 | } |
| 11764 | for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 11765 | VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; |
| 11766 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
| 11767 | if (pSemaphore) { |
| 11768 | if (pSemaphore->signaled) { |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11769 | skip_call = |
| 11770 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| 11771 | reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11772 | "vkQueueBindSparse: Queue 0x%p is signaling semaphore 0x%" PRIx64 |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11773 | ", but that semaphore is already signaled.", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11774 | queue, reinterpret_cast<const uint64_t &>(semaphore)); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11775 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11776 | else { |
| 11777 | pSemaphore->signaler.first = queue; |
| 11778 | pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; |
| 11779 | pSemaphore->signaled = true; |
| 11780 | pSemaphore->in_use.fetch_add(1); |
| 11781 | semaphore_signals.push_back(semaphore); |
| 11782 | } |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11783 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11784 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11785 | |
| 11786 | pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), |
| 11787 | semaphore_waits, |
| 11788 | semaphore_signals, |
| 11789 | bindIdx == bindInfoCount - 1 ? fence : VK_NULL_HANDLE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11790 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11791 | |
| 11792 | if (pFence && !bindInfoCount) { |
| 11793 | // No work to do, just dropping a fence in the queue by itself. |
| 11794 | pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), |
| 11795 | std::vector<SEMAPHORE_WAIT>(), |
| 11796 | std::vector<VkSemaphore>(), |
| 11797 | fence); |
| 11798 | } |
| 11799 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11800 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11801 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11802 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11803 | return dev_data->dispatch_table.QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11804 | |
| 11805 | return result; |
| 11806 | } |
| 11807 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11808 | VKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, |
| 11809 | const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11810 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11811 | VkResult result = dev_data->dispatch_table.CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11812 | if (result == VK_SUCCESS) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11813 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11814 | SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11815 | sNode->signaler.first = VK_NULL_HANDLE; |
| 11816 | sNode->signaler.second = 0; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11817 | sNode->signaled = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11818 | } |
| 11819 | return result; |
| 11820 | } |
| 11821 | |
| 11822 | VKAPI_ATTR VkResult VKAPI_CALL |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11823 | CreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11824 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11825 | VkResult result = dev_data->dispatch_table.CreateEvent(device, pCreateInfo, pAllocator, pEvent); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11826 | if (result == VK_SUCCESS) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11827 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11828 | dev_data->eventMap[*pEvent].needsSignaled = false; |
Tony Barbour | 0646537 | 2016-06-06 10:55:04 -0600 | [diff] [blame] | 11829 | dev_data->eventMap[*pEvent].write_in_use = 0; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11830 | dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11831 | } |
| 11832 | return result; |
| 11833 | } |
| 11834 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11835 | static bool PreCallValidateCreateSwapchainKHR(layer_data *dev_data, const char *func_name, |
| 11836 | VkSwapchainCreateInfoKHR const *pCreateInfo, SURFACE_STATE *surface_state, |
| 11837 | SWAPCHAIN_NODE *old_swapchain_state) { |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 11838 | auto most_recent_swapchain = surface_state->swapchain ? surface_state->swapchain : surface_state->old_swapchain; |
| 11839 | |
Chris Forbes | 7be86f8 | 2016-11-25 16:17:28 +1300 | [diff] [blame] | 11840 | // TODO: revisit this. some of these rules are being relaxed. |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 11841 | if (most_recent_swapchain != old_swapchain_state || (surface_state->old_swapchain && surface_state->swapchain)) { |
| 11842 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| 11843 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_ALREADY_EXISTS, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11844 | "%s: surface has an existing swapchain other than oldSwapchain", func_name)) |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 11845 | return true; |
| 11846 | } |
| 11847 | if (old_swapchain_state && old_swapchain_state->createInfo.surface != pCreateInfo->surface) { |
| 11848 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 11849 | reinterpret_cast<uint64_t const &>(pCreateInfo->oldSwapchain), __LINE__, DRAWSTATE_SWAPCHAIN_WRONG_SURFACE, |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11850 | "DS", "%s: pCreateInfo->oldSwapchain's surface is not pCreateInfo->surface", func_name)) |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 11851 | return true; |
| 11852 | } |
Chris Forbes | b52e060 | 2016-10-11 16:21:32 +1300 | [diff] [blame] | 11853 | auto physical_device_state = getPhysicalDeviceState(dev_data->instance_data, dev_data->physical_device); |
| 11854 | if (physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState == UNCALLED) { |
| 11855 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 11856 | reinterpret_cast<uint64_t>(dev_data->physical_device), __LINE__, DRAWSTATE_SWAPCHAIN_CREATE_BEFORE_QUERY, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11857 | "%s: surface capabilities not retrieved for this physical device", func_name)) |
Chris Forbes | b52e060 | 2016-10-11 16:21:32 +1300 | [diff] [blame] | 11858 | return true; |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11859 | } else { // have valid capabilities |
| 11860 | auto &capabilities = physical_device_state->surfaceCapabilities; |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11861 | // Validate pCreateInfo->minImageCount against VkSurfaceCapabilitiesKHR::{min|max}ImageCount: |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11862 | if (pCreateInfo->minImageCount < capabilities.minImageCount) { |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11863 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11864 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02331, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11865 | "%s called with minImageCount = %d, which is outside the bounds returned " |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11866 | "by vkGetPhysicalDeviceSurfaceCapabilitiesKHR() (i.e. minImageCount = %d, maxImageCount = %d). %s", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11867 | func_name, pCreateInfo->minImageCount, capabilities.minImageCount, capabilities.maxImageCount, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11868 | validation_error_map[VALIDATION_ERROR_02331])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11869 | return true; |
| 11870 | } |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11871 | |
| 11872 | if ((capabilities.maxImageCount > 0) && (pCreateInfo->minImageCount > capabilities.maxImageCount)) { |
| 11873 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| 11874 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02332, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11875 | "%s called with minImageCount = %d, which is outside the bounds returned " |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11876 | "by vkGetPhysicalDeviceSurfaceCapabilitiesKHR() (i.e. minImageCount = %d, maxImageCount = %d). %s", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11877 | func_name, pCreateInfo->minImageCount, capabilities.minImageCount, capabilities.maxImageCount, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11878 | validation_error_map[VALIDATION_ERROR_02332])) |
| 11879 | return true; |
| 11880 | } |
| 11881 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11882 | // Validate pCreateInfo->imageExtent against VkSurfaceCapabilitiesKHR::{current|min|max}ImageExtent: |
Jamie Madill | 6069c82 | 2016-12-15 09:35:36 -0500 | [diff] [blame] | 11883 | if ((capabilities.currentExtent.width == kSurfaceSizeFromSwapchain) && |
| 11884 | ((pCreateInfo->imageExtent.width < capabilities.minImageExtent.width) || |
| 11885 | (pCreateInfo->imageExtent.width > capabilities.maxImageExtent.width) || |
| 11886 | (pCreateInfo->imageExtent.height < capabilities.minImageExtent.height) || |
| 11887 | (pCreateInfo->imageExtent.height > capabilities.maxImageExtent.height))) { |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11888 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11889 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02334, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11890 | "%s called with imageExtent = (%d,%d), which is outside the bounds returned by " |
| 11891 | "vkGetPhysicalDeviceSurfaceCapabilitiesKHR(): currentExtent = (%d,%d), minImageExtent = (%d,%d), " |
| 11892 | "maxImageExtent = (%d,%d). %s", |
| 11893 | func_name, pCreateInfo->imageExtent.width, pCreateInfo->imageExtent.height, |
| 11894 | capabilities.currentExtent.width, capabilities.currentExtent.height, capabilities.minImageExtent.width, |
| 11895 | capabilities.minImageExtent.height, capabilities.maxImageExtent.width, capabilities.maxImageExtent.height, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11896 | validation_error_map[VALIDATION_ERROR_02334])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11897 | return true; |
| 11898 | } |
Jamie Madill | 6069c82 | 2016-12-15 09:35:36 -0500 | [diff] [blame] | 11899 | if ((capabilities.currentExtent.width != kSurfaceSizeFromSwapchain) && |
| 11900 | ((pCreateInfo->imageExtent.width != capabilities.currentExtent.width) || |
| 11901 | (pCreateInfo->imageExtent.height != capabilities.currentExtent.height))) { |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11902 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11903 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02334, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11904 | "%s called with imageExtent = (%d,%d), which is not equal to the currentExtent = (%d,%d) returned by " |
| 11905 | "vkGetPhysicalDeviceSurfaceCapabilitiesKHR(). %s", |
| 11906 | func_name, pCreateInfo->imageExtent.width, pCreateInfo->imageExtent.height, |
| 11907 | capabilities.currentExtent.width, capabilities.currentExtent.height, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11908 | validation_error_map[VALIDATION_ERROR_02334])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11909 | return true; |
| 11910 | } |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11911 | // pCreateInfo->preTransform should have exactly one bit set, and that bit must also be set in |
| 11912 | // VkSurfaceCapabilitiesKHR::supportedTransforms. |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11913 | if (!pCreateInfo->preTransform || (pCreateInfo->preTransform & (pCreateInfo->preTransform - 1)) || |
| 11914 | !(pCreateInfo->preTransform & capabilities.supportedTransforms)) { |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11915 | // This is an error situation; one for which we'd like to give the developer a helpful, multi-line error message. Build |
| 11916 | // it up a little at a time, and then log it: |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11917 | std::string errorString = ""; |
| 11918 | char str[1024]; |
| 11919 | // Here's the first part of the message: |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11920 | sprintf(str, "%s called with a non-supported pCreateInfo->preTransform (i.e. %s). Supported values are:\n", func_name, |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11921 | string_VkSurfaceTransformFlagBitsKHR(pCreateInfo->preTransform)); |
| 11922 | errorString += str; |
| 11923 | for (int i = 0; i < 32; i++) { |
| 11924 | // Build up the rest of the message: |
| 11925 | if ((1 << i) & capabilities.supportedTransforms) { |
| 11926 | const char *newStr = string_VkSurfaceTransformFlagBitsKHR((VkSurfaceTransformFlagBitsKHR)(1 << i)); |
| 11927 | sprintf(str, " %s\n", newStr); |
| 11928 | errorString += str; |
| 11929 | } |
| 11930 | } |
| 11931 | // Log the message that we've built up: |
| 11932 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11933 | reinterpret_cast<uint64_t &>(dev_data->device), __LINE__, VALIDATION_ERROR_02339, "DS", "%s. %s", |
| 11934 | errorString.c_str(), validation_error_map[VALIDATION_ERROR_02339])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11935 | return true; |
| 11936 | } |
Chris Forbes | f13f541 | 2016-10-31 17:20:22 +1300 | [diff] [blame] | 11937 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11938 | // pCreateInfo->compositeAlpha should have exactly one bit set, and that bit must also be set in |
| 11939 | // VkSurfaceCapabilitiesKHR::supportedCompositeAlpha |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11940 | if (!pCreateInfo->compositeAlpha || (pCreateInfo->compositeAlpha & (pCreateInfo->compositeAlpha - 1)) || |
| 11941 | !((pCreateInfo->compositeAlpha) & capabilities.supportedCompositeAlpha)) { |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11942 | // This is an error situation; one for which we'd like to give the developer a helpful, multi-line error message. Build |
| 11943 | // it up a little at a time, and then log it: |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11944 | std::string errorString = ""; |
| 11945 | char str[1024]; |
| 11946 | // Here's the first part of the message: |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11947 | sprintf(str, "%s called with a non-supported pCreateInfo->compositeAlpha (i.e. %s). Supported values are:\n", |
| 11948 | func_name, string_VkCompositeAlphaFlagBitsKHR(pCreateInfo->compositeAlpha)); |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11949 | errorString += str; |
| 11950 | for (int i = 0; i < 32; i++) { |
| 11951 | // Build up the rest of the message: |
| 11952 | if ((1 << i) & capabilities.supportedCompositeAlpha) { |
| 11953 | const char *newStr = string_VkCompositeAlphaFlagBitsKHR((VkCompositeAlphaFlagBitsKHR)(1 << i)); |
| 11954 | sprintf(str, " %s\n", newStr); |
| 11955 | errorString += str; |
| 11956 | } |
| 11957 | } |
| 11958 | // Log the message that we've built up: |
| 11959 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11960 | reinterpret_cast<uint64_t &>(dev_data->device), __LINE__, VALIDATION_ERROR_02340, "DS", "%s. %s", |
| 11961 | errorString.c_str(), validation_error_map[VALIDATION_ERROR_02340])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11962 | return true; |
| 11963 | } |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11964 | // Validate pCreateInfo->imageArrayLayers against VkSurfaceCapabilitiesKHR::maxImageArrayLayers: |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11965 | if ((pCreateInfo->imageArrayLayers < 1) || (pCreateInfo->imageArrayLayers > capabilities.maxImageArrayLayers)) { |
| 11966 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11967 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02335, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11968 | "%s called with a non-supported imageArrayLayers (i.e. %d). Minimum value is 1, maximum value is %d. %s", |
| 11969 | func_name, pCreateInfo->imageArrayLayers, capabilities.maxImageArrayLayers, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11970 | validation_error_map[VALIDATION_ERROR_02335])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11971 | return true; |
| 11972 | } |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11973 | // Validate pCreateInfo->imageUsage against VkSurfaceCapabilitiesKHR::supportedUsageFlags: |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11974 | if (pCreateInfo->imageUsage != (pCreateInfo->imageUsage & capabilities.supportedUsageFlags)) { |
| 11975 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11976 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02336, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11977 | "%s called with a non-supported pCreateInfo->imageUsage (i.e. 0x%08x). Supported flag bits are 0x%08x. %s", |
| 11978 | func_name, pCreateInfo->imageUsage, capabilities.supportedUsageFlags, |
| 11979 | validation_error_map[VALIDATION_ERROR_02336])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11980 | return true; |
| 11981 | } |
Chris Forbes | b52e060 | 2016-10-11 16:21:32 +1300 | [diff] [blame] | 11982 | } |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 11983 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11984 | // Validate pCreateInfo values with the results of vkGetPhysicalDeviceSurfaceFormatsKHR(): |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 11985 | if (physical_device_state->vkGetPhysicalDeviceSurfaceFormatsKHRState != QUERY_DETAILS) { |
| 11986 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| 11987 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_CREATE_BEFORE_QUERY, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11988 | "%s called before calling vkGetPhysicalDeviceSurfaceFormatsKHR().", func_name)) |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 11989 | return true; |
| 11990 | } else { |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11991 | // Validate pCreateInfo->imageFormat against VkSurfaceFormatKHR::format: |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 11992 | bool foundFormat = false; |
| 11993 | bool foundColorSpace = false; |
| 11994 | bool foundMatch = false; |
| 11995 | for (auto const &format : physical_device_state->surface_formats) { |
| 11996 | if (pCreateInfo->imageFormat == format.format) { |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11997 | // Validate pCreateInfo->imageColorSpace against VkSurfaceFormatKHR::colorSpace: |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 11998 | foundFormat = true; |
| 11999 | if (pCreateInfo->imageColorSpace == format.colorSpace) { |
| 12000 | foundMatch = true; |
| 12001 | break; |
| 12002 | } |
| 12003 | } else { |
| 12004 | if (pCreateInfo->imageColorSpace == format.colorSpace) { |
| 12005 | foundColorSpace = true; |
| 12006 | } |
| 12007 | } |
| 12008 | } |
| 12009 | if (!foundMatch) { |
| 12010 | if (!foundFormat) { |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 12011 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12012 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02333, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12013 | "%s called with a non-supported pCreateInfo->imageFormat (i.e. %d). %s", |
| 12014 | func_name, pCreateInfo->imageFormat, validation_error_map[VALIDATION_ERROR_02333])) |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12015 | return true; |
| 12016 | } |
| 12017 | if (!foundColorSpace) { |
| 12018 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| 12019 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02333, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12020 | "%s called with a non-supported pCreateInfo->imageColorSpace (i.e. %d). %s", |
| 12021 | func_name, pCreateInfo->imageColorSpace, validation_error_map[VALIDATION_ERROR_02333])) |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 12022 | return true; |
| 12023 | } |
| 12024 | } |
| 12025 | } |
| 12026 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12027 | // Validate pCreateInfo values with the results of vkGetPhysicalDeviceSurfacePresentModesKHR(): |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12028 | if (physical_device_state->vkGetPhysicalDeviceSurfacePresentModesKHRState != QUERY_DETAILS) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 12029 | // FIFO is required to always be supported |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12030 | if (pCreateInfo->presentMode != VK_PRESENT_MODE_FIFO_KHR) { |
| 12031 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12032 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_CREATE_BEFORE_QUERY, "DS", |
| 12033 | "%s called before calling vkGetPhysicalDeviceSurfacePresentModesKHR().", func_name)) |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12034 | return true; |
| 12035 | } |
| 12036 | } else { |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12037 | // Validate pCreateInfo->presentMode against vkGetPhysicalDeviceSurfacePresentModesKHR(): |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12038 | bool foundMatch = std::find(physical_device_state->present_modes.begin(), |
| 12039 | physical_device_state->present_modes.end(), |
| 12040 | pCreateInfo->presentMode) != physical_device_state->present_modes.end(); |
| 12041 | if (!foundMatch) { |
| 12042 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12043 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02341, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12044 | "%s called with a non-supported presentMode (i.e. %s). %s", func_name, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12045 | string_VkPresentModeKHR(pCreateInfo->presentMode), validation_error_map[VALIDATION_ERROR_02341])) |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12046 | return true; |
| 12047 | } |
| 12048 | } |
| 12049 | |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 12050 | return false; |
| 12051 | } |
| 12052 | |
Mark Lobodzinski | d1c3436 | 2017-01-11 12:09:31 -0700 | [diff] [blame] | 12053 | static void PostCallRecordCreateSwapchainKHR(layer_data *dev_data, VkResult result, const VkSwapchainCreateInfoKHR *pCreateInfo, |
| 12054 | VkSwapchainKHR *pSwapchain, SURFACE_STATE *surface_state, |
| 12055 | SWAPCHAIN_NODE *old_swapchain_state) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12056 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12057 | std::lock_guard<std::mutex> lock(global_lock); |
Chris Forbes | c3b0815 | 2016-10-06 13:01:17 +1300 | [diff] [blame] | 12058 | auto swapchain_state = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo, *pSwapchain)); |
| 12059 | surface_state->swapchain = swapchain_state.get(); |
| 12060 | dev_data->device_extensions.swapchainMap[*pSwapchain] = std::move(swapchain_state); |
| 12061 | } else { |
| 12062 | surface_state->swapchain = nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12063 | } |
Chris Forbes | c3b0815 | 2016-10-06 13:01:17 +1300 | [diff] [blame] | 12064 | // Spec requires that even if CreateSwapchainKHR fails, oldSwapchain behaves as replaced. |
Chris Forbes | 8a047d0 | 2016-12-09 10:39:26 +1300 | [diff] [blame] | 12065 | if (old_swapchain_state) { |
| 12066 | old_swapchain_state->replaced = true; |
| 12067 | } |
Chris Forbes | c3b0815 | 2016-10-06 13:01:17 +1300 | [diff] [blame] | 12068 | surface_state->old_swapchain = old_swapchain_state; |
Mark Lobodzinski | d1c3436 | 2017-01-11 12:09:31 -0700 | [diff] [blame] | 12069 | return; |
| 12070 | } |
| 12071 | |
| 12072 | VKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, |
| 12073 | const VkAllocationCallbacks *pAllocator, VkSwapchainKHR *pSwapchain) { |
| 12074 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 12075 | auto surface_state = getSurfaceState(dev_data->instance_data, pCreateInfo->surface); |
| 12076 | auto old_swapchain_state = getSwapchainNode(dev_data, pCreateInfo->oldSwapchain); |
| 12077 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12078 | if (PreCallValidateCreateSwapchainKHR(dev_data, "vkCreateSwapChainKHR()", pCreateInfo, surface_state, old_swapchain_state)) { |
Mark Lobodzinski | d1c3436 | 2017-01-11 12:09:31 -0700 | [diff] [blame] | 12079 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12080 | } |
| 12081 | |
| 12082 | VkResult result = dev_data->dispatch_table.CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); |
| 12083 | |
| 12084 | PostCallRecordCreateSwapchainKHR(dev_data, result, pCreateInfo, pSwapchain, surface_state, old_swapchain_state); |
Chris Forbes | c3b0815 | 2016-10-06 13:01:17 +1300 | [diff] [blame] | 12085 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12086 | return result; |
| 12087 | } |
| 12088 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12089 | VKAPI_ATTR void VKAPI_CALL |
| 12090 | DestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12091 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12092 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12093 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12094 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 12095 | auto swapchain_data = getSwapchainNode(dev_data, swapchain); |
| 12096 | if (swapchain_data) { |
| 12097 | if (swapchain_data->images.size() > 0) { |
| 12098 | for (auto swapchain_image : swapchain_data->images) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12099 | auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); |
| 12100 | if (image_sub != dev_data->imageSubresourceMap.end()) { |
| 12101 | for (auto imgsubpair : image_sub->second) { |
| 12102 | auto image_item = dev_data->imageLayoutMap.find(imgsubpair); |
| 12103 | if (image_item != dev_data->imageLayoutMap.end()) { |
| 12104 | dev_data->imageLayoutMap.erase(image_item); |
| 12105 | } |
| 12106 | } |
| 12107 | dev_data->imageSubresourceMap.erase(image_sub); |
| 12108 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12109 | skip_call = |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 12110 | ClearMemoryObjectBindings(dev_data, (uint64_t)swapchain_image, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 12111 | dev_data->imageMap.erase(swapchain_image); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12112 | } |
| 12113 | } |
Chris Forbes | c3b0815 | 2016-10-06 13:01:17 +1300 | [diff] [blame] | 12114 | |
| 12115 | auto surface_state = getSurfaceState(dev_data->instance_data, swapchain_data->createInfo.surface); |
| 12116 | if (surface_state) { |
| 12117 | if (surface_state->swapchain == swapchain_data) |
| 12118 | surface_state->swapchain = nullptr; |
| 12119 | if (surface_state->old_swapchain == swapchain_data) |
| 12120 | surface_state->old_swapchain = nullptr; |
| 12121 | } |
| 12122 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12123 | dev_data->device_extensions.swapchainMap.erase(swapchain); |
| 12124 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12125 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12126 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12127 | dev_data->dispatch_table.DestroySwapchainKHR(device, swapchain, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12128 | } |
| 12129 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12130 | VKAPI_ATTR VkResult VKAPI_CALL |
| 12131 | GetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12132 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12133 | VkResult result = dev_data->dispatch_table.GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12134 | |
| 12135 | if (result == VK_SUCCESS && pSwapchainImages != NULL) { |
| 12136 | // This should never happen and is checked by param checker. |
| 12137 | if (!pCount) |
| 12138 | return result; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12139 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12140 | const size_t count = *pCount; |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 12141 | auto swapchain_node = getSwapchainNode(dev_data, swapchain); |
| 12142 | if (swapchain_node && !swapchain_node->images.empty()) { |
Tobin Ehlis | 43d7c52 | 2016-03-16 13:52:20 -0600 | [diff] [blame] | 12143 | // TODO : Not sure I like the memcmp here, but it works |
| 12144 | const bool mismatch = (swapchain_node->images.size() != count || |
| 12145 | memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12146 | if (mismatch) { |
| 12147 | // TODO: Verify against Valid Usage section of extension |
| 12148 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12149 | (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 12150 | "vkGetSwapchainInfoKHR(0x%" PRIx64 |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12151 | ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", |
| 12152 | (uint64_t)(swapchain)); |
| 12153 | } |
| 12154 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12155 | for (uint32_t i = 0; i < *pCount; ++i) { |
| 12156 | IMAGE_LAYOUT_NODE image_layout_node; |
| 12157 | image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12158 | image_layout_node.format = swapchain_node->createInfo.imageFormat; |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 12159 | // Add imageMap entries for each swapchain image |
| 12160 | VkImageCreateInfo image_ci = {}; |
| 12161 | image_ci.mipLevels = 1; |
| 12162 | image_ci.arrayLayers = swapchain_node->createInfo.imageArrayLayers; |
| 12163 | image_ci.usage = swapchain_node->createInfo.imageUsage; |
| 12164 | image_ci.format = swapchain_node->createInfo.imageFormat; |
Tobin Ehlis | dae051d | 2016-06-22 14:16:06 -0600 | [diff] [blame] | 12165 | image_ci.samples = VK_SAMPLE_COUNT_1_BIT; |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 12166 | image_ci.extent.width = swapchain_node->createInfo.imageExtent.width; |
| 12167 | image_ci.extent.height = swapchain_node->createInfo.imageExtent.height; |
| 12168 | image_ci.sharingMode = swapchain_node->createInfo.imageSharingMode; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 12169 | dev_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_STATE>(new IMAGE_STATE(pSwapchainImages[i], &image_ci)); |
| 12170 | auto &image_state = dev_data->imageMap[pSwapchainImages[i]]; |
| 12171 | image_state->valid = false; |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 12172 | image_state->binding.mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12173 | swapchain_node->images.push_back(pSwapchainImages[i]); |
| 12174 | ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; |
| 12175 | dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); |
| 12176 | dev_data->imageLayoutMap[subpair] = image_layout_node; |
| 12177 | dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; |
| 12178 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12179 | } |
| 12180 | return result; |
| 12181 | } |
| 12182 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12183 | VKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12184 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12185 | bool skip_call = false; |
| 12186 | |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12187 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 12188 | auto queue_state = getQueueState(dev_data, queue); |
Chris Forbes | b998bf9 | 2016-10-12 10:21:19 +1300 | [diff] [blame] | 12189 | |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12190 | for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { |
| 12191 | auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); |
| 12192 | if (pSemaphore && !pSemaphore->signaled) { |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 12193 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 12194 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, |
| 12195 | "DS", "Queue 0x%p is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", queue, |
| 12196 | reinterpret_cast<const uint64_t &>(pPresentInfo->pWaitSemaphores[i])); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12197 | } |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12198 | } |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 12199 | |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12200 | for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { |
| 12201 | auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); |
Chris Forbes | f6f063d | 2016-09-22 18:34:20 +1200 | [diff] [blame] | 12202 | if (swapchain_data) { |
| 12203 | if (pPresentInfo->pImageIndices[i] >= swapchain_data->images.size()) { |
| 12204 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
Chris Forbes | f54f4c7 | 2016-09-26 15:18:57 +1300 | [diff] [blame] | 12205 | reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_INVALID_IMAGE, |
Chris Forbes | f6f063d | 2016-09-22 18:34:20 +1200 | [diff] [blame] | 12206 | "DS", "vkQueuePresentKHR: Swapchain image index too large (%u). There are only %u images in this swapchain.", |
| 12207 | pPresentInfo->pImageIndices[i], (uint32_t)swapchain_data->images.size()); |
| 12208 | } |
| 12209 | else { |
| 12210 | auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 12211 | auto image_state = getImageState(dev_data, image); |
| 12212 | skip_call |= ValidateImageMemoryIsValid(dev_data, image_state, "vkQueuePresentKHR()"); |
Chris Forbes | f6f063d | 2016-09-22 18:34:20 +1200 | [diff] [blame] | 12213 | |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 12214 | if (!image_state->acquired) { |
Chris Forbes | f6f063d | 2016-09-22 18:34:20 +1200 | [diff] [blame] | 12215 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12216 | reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_IMAGE_NOT_ACQUIRED, |
| 12217 | "DS", "vkQueuePresentKHR: Swapchain image index %u has not been acquired.", |
| 12218 | pPresentInfo->pImageIndices[i]); |
| 12219 | } |
| 12220 | |
| 12221 | vector<VkImageLayout> layouts; |
| 12222 | if (FindLayouts(dev_data, image, layouts)) { |
| 12223 | for (auto layout : layouts) { |
| 12224 | if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { |
| 12225 | skip_call |= |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12226 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, |
| 12227 | reinterpret_cast<uint64_t &>(queue), __LINE__, VALIDATION_ERROR_01964, "DS", |
| 12228 | "Images passed to present must be in layout " |
| 12229 | "VK_IMAGE_LAYOUT_PRESENT_SRC_KHR but is in %s. %s", |
| 12230 | string_VkImageLayout(layout), validation_error_map[VALIDATION_ERROR_01964]); |
Chris Forbes | f6f063d | 2016-09-22 18:34:20 +1200 | [diff] [blame] | 12231 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12232 | } |
| 12233 | } |
| 12234 | } |
Chris Forbes | b998bf9 | 2016-10-12 10:21:19 +1300 | [diff] [blame] | 12235 | |
| 12236 | // All physical devices and queue families are required to be able |
| 12237 | // to present to any native window on Android; require the |
| 12238 | // application to have established support on any other platform. |
| 12239 | if (!dev_data->instance_data->androidSurfaceExtensionEnabled) { |
| 12240 | auto surface_state = getSurfaceState(dev_data->instance_data, swapchain_data->createInfo.surface); |
| 12241 | auto support_it = surface_state->gpu_queue_support.find({dev_data->physical_device, queue_state->queueFamilyIndex}); |
| 12242 | |
| 12243 | if (support_it == surface_state->gpu_queue_support.end()) { |
| 12244 | skip_call |= |
| 12245 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12246 | reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, |
| 12247 | DRAWSTATE_SWAPCHAIN_UNSUPPORTED_QUEUE, "DS", "vkQueuePresentKHR: Presenting image without calling " |
| 12248 | "vkGetPhysicalDeviceSurfaceSupportKHR"); |
| 12249 | } else if (!support_it->second) { |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12250 | skip_call |= |
| 12251 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12252 | reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, VALIDATION_ERROR_01961, |
| 12253 | "DS", "vkQueuePresentKHR: Presenting image on queue that cannot " |
| 12254 | "present to this surface. %s", |
| 12255 | validation_error_map[VALIDATION_ERROR_01961]); |
Chris Forbes | b998bf9 | 2016-10-12 10:21:19 +1300 | [diff] [blame] | 12256 | } |
| 12257 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12258 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12259 | } |
| 12260 | |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12261 | if (skip_call) { |
| 12262 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12263 | } |
| 12264 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12265 | VkResult result = dev_data->dispatch_table.QueuePresentKHR(queue, pPresentInfo); |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12266 | |
| 12267 | if (result != VK_ERROR_VALIDATION_FAILED_EXT) { |
| 12268 | // Semaphore waits occur before error generation, if the call reached |
| 12269 | // the ICD. (Confirm?) |
| 12270 | for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { |
| 12271 | auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 12272 | if (pSemaphore) { |
| 12273 | pSemaphore->signaler.first = VK_NULL_HANDLE; |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12274 | pSemaphore->signaled = false; |
| 12275 | } |
| 12276 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 12277 | |
Chris Forbes | 048399d | 2016-09-22 17:11:06 +1200 | [diff] [blame] | 12278 | for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { |
| 12279 | // Note: this is imperfect, in that we can get confused about what |
| 12280 | // did or didn't succeed-- but if the app does that, it's confused |
| 12281 | // itself just as much. |
| 12282 | auto local_result = pPresentInfo->pResults ? pPresentInfo->pResults[i] : result; |
| 12283 | |
| 12284 | if (local_result != VK_SUCCESS && local_result != VK_SUBOPTIMAL_KHR) |
| 12285 | continue; // this present didn't actually happen. |
| 12286 | |
| 12287 | // Mark the image as having been released to the WSI |
| 12288 | auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); |
| 12289 | auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 12290 | auto image_state = getImageState(dev_data, image); |
| 12291 | image_state->acquired = false; |
Chris Forbes | 048399d | 2016-09-22 17:11:06 +1200 | [diff] [blame] | 12292 | } |
| 12293 | |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 12294 | // Note: even though presentation is directed to a queue, there is no |
| 12295 | // direct ordering between QP and subsequent work, so QP (and its |
| 12296 | // semaphore waits) /never/ participate in any completion proof. |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12297 | } |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 12298 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12299 | return result; |
| 12300 | } |
| 12301 | |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12302 | static bool PreCallValidateCreateSharedSwapchainsKHR(layer_data *dev_data, uint32_t swapchainCount, |
| 12303 | const VkSwapchainCreateInfoKHR *pCreateInfos, VkSwapchainKHR *pSwapchains, |
| 12304 | std::vector<SURFACE_STATE *> &surface_state, |
| 12305 | std::vector<SWAPCHAIN_NODE *> &old_swapchain_state) { |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12306 | if (pCreateInfos) { |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12307 | std::lock_guard<std::mutex> lock(global_lock); |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12308 | for (uint32_t i = 0; i < swapchainCount; i++) { |
| 12309 | surface_state.push_back(getSurfaceState(dev_data->instance_data, pCreateInfos[i].surface)); |
| 12310 | old_swapchain_state.push_back(getSwapchainNode(dev_data, pCreateInfos[i].oldSwapchain)); |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12311 | std::stringstream func_name; |
| 12312 | func_name << "vkCreateSharedSwapchainsKHR[" << swapchainCount << "]"; |
| 12313 | if (PreCallValidateCreateSwapchainKHR(dev_data, func_name.str().c_str(), &pCreateInfos[i], surface_state[i], old_swapchain_state[i])) { |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12314 | return true; |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12315 | } |
| 12316 | } |
| 12317 | } |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12318 | return false; |
| 12319 | } |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12320 | |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12321 | static void PostCallRecordCreateSharedSwapchainsKHR(layer_data *dev_data, VkResult result, uint32_t swapchainCount, |
| 12322 | const VkSwapchainCreateInfoKHR *pCreateInfos, VkSwapchainKHR *pSwapchains, |
| 12323 | std::vector<SURFACE_STATE *> &surface_state, |
| 12324 | std::vector<SWAPCHAIN_NODE *> &old_swapchain_state) { |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12325 | if (VK_SUCCESS == result) { |
| 12326 | for (uint32_t i = 0; i < swapchainCount; i++) { |
| 12327 | auto swapchain_state = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(&pCreateInfos[i], pSwapchains[i])); |
| 12328 | surface_state[i]->swapchain = swapchain_state.get(); |
| 12329 | dev_data->device_extensions.swapchainMap[pSwapchains[i]] = std::move(swapchain_state); |
| 12330 | } |
| 12331 | } else { |
| 12332 | for (uint32_t i = 0; i < swapchainCount; i++) { |
| 12333 | surface_state[i]->swapchain = nullptr; |
| 12334 | } |
| 12335 | } |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12336 | // Spec requires that even if CreateSharedSwapchainKHR fails, oldSwapchain behaves as replaced. |
| 12337 | for (uint32_t i = 0; i < swapchainCount; i++) { |
| 12338 | if (old_swapchain_state[i]) { |
| 12339 | old_swapchain_state[i]->replaced = true; |
| 12340 | } |
| 12341 | surface_state[i]->old_swapchain = old_swapchain_state[i]; |
| 12342 | } |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12343 | return; |
| 12344 | } |
| 12345 | |
| 12346 | VKAPI_ATTR VkResult VKAPI_CALL CreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount, |
| 12347 | const VkSwapchainCreateInfoKHR *pCreateInfos, |
| 12348 | const VkAllocationCallbacks *pAllocator, VkSwapchainKHR *pSwapchains) { |
| 12349 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 12350 | std::vector<SURFACE_STATE *> surface_state; |
| 12351 | std::vector<SWAPCHAIN_NODE *> old_swapchain_state; |
| 12352 | |
| 12353 | if (PreCallValidateCreateSharedSwapchainsKHR(dev_data, swapchainCount, pCreateInfos, pSwapchains, surface_state, |
| 12354 | old_swapchain_state)) { |
| 12355 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12356 | } |
| 12357 | |
| 12358 | VkResult result = |
| 12359 | dev_data->dispatch_table.CreateSharedSwapchainsKHR(device, swapchainCount, pCreateInfos, pAllocator, pSwapchains); |
| 12360 | |
| 12361 | PostCallRecordCreateSharedSwapchainsKHR(dev_data, result, swapchainCount, pCreateInfos, pSwapchains, surface_state, |
| 12362 | old_swapchain_state); |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12363 | |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 12364 | return result; |
| 12365 | } |
| 12366 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12367 | VKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, |
| 12368 | VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12369 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12370 | bool skip_call = false; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 12371 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12372 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | 76fa6c6 | 2016-09-22 16:40:27 +1200 | [diff] [blame] | 12373 | |
| 12374 | if (fence == VK_NULL_HANDLE && semaphore == VK_NULL_HANDLE) { |
| 12375 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Chris Forbes | f54f4c7 | 2016-09-26 15:18:57 +1300 | [diff] [blame] | 12376 | reinterpret_cast<uint64_t &>(device), __LINE__, DRAWSTATE_SWAPCHAIN_NO_SYNC_FOR_ACQUIRE, "DS", |
Chris Forbes | 76fa6c6 | 2016-09-22 16:40:27 +1200 | [diff] [blame] | 12377 | "vkAcquireNextImageKHR: Semaphore and fence cannot both be VK_NULL_HANDLE. There would be no way " |
| 12378 | "to determine the completion of this operation."); |
| 12379 | } |
| 12380 | |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12381 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
| 12382 | if (pSemaphore && pSemaphore->signaled) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12383 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12384 | reinterpret_cast<const uint64_t &>(semaphore), __LINE__, VALIDATION_ERROR_01952, "DS", |
| 12385 | "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state. %s", |
| 12386 | validation_error_map[VALIDATION_ERROR_01952]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12387 | } |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12388 | |
| 12389 | auto pFence = getFenceNode(dev_data, fence); |
| 12390 | if (pFence) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12391 | skip_call |= ValidateFenceForSubmit(dev_data, pFence); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12392 | } |
Chris Forbes | 73de085 | 2016-10-12 13:27:13 +1300 | [diff] [blame] | 12393 | |
| 12394 | auto swapchain_data = getSwapchainNode(dev_data, swapchain); |
Chris Forbes | 9a936d7 | 2016-12-09 11:00:21 +1300 | [diff] [blame] | 12395 | |
| 12396 | if (swapchain_data->replaced) { |
| 12397 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12398 | reinterpret_cast<uint64_t &>(swapchain), __LINE__, DRAWSTATE_SWAPCHAIN_REPLACED, "DS", |
| 12399 | "vkAcquireNextImageKHR: This swapchain has been replaced. The application can still " |
| 12400 | "present any images it has acquired, but cannot acquire any more."); |
| 12401 | } |
| 12402 | |
Chris Forbes | 73de085 | 2016-10-12 13:27:13 +1300 | [diff] [blame] | 12403 | auto physical_device_state = getPhysicalDeviceState(dev_data->instance_data, dev_data->physical_device); |
| 12404 | if (physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState != UNCALLED) { |
Mark Lobodzinski | 9e02344 | 2016-11-23 11:28:30 -0700 | [diff] [blame] | 12405 | uint64_t acquired_images = std::count_if(swapchain_data->images.begin(), swapchain_data->images.end(), |
| 12406 | [=](VkImage image) { return getImageState(dev_data, image)->acquired; }); |
Chris Forbes | 73de085 | 2016-10-12 13:27:13 +1300 | [diff] [blame] | 12407 | if (acquired_images > swapchain_data->images.size() - physical_device_state->surfaceCapabilities.minImageCount) { |
Mark Lobodzinski | 9e02344 | 2016-11-23 11:28:30 -0700 | [diff] [blame] | 12408 | skip_call |= |
| 12409 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12410 | reinterpret_cast<uint64_t const &>(swapchain), __LINE__, DRAWSTATE_SWAPCHAIN_TOO_MANY_IMAGES, "DS", |
| 12411 | "vkAcquireNextImageKHR: Application has already acquired the maximum number of images (0x%" PRIxLEAST64 ")", |
| 12412 | acquired_images); |
Chris Forbes | 73de085 | 2016-10-12 13:27:13 +1300 | [diff] [blame] | 12413 | } |
| 12414 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12415 | lock.unlock(); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 12416 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12417 | if (skip_call) |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12418 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12419 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12420 | VkResult result = dev_data->dispatch_table.AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12421 | |
| 12422 | lock.lock(); |
| 12423 | if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { |
| 12424 | if (pFence) { |
| 12425 | pFence->state = FENCE_INFLIGHT; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 12426 | pFence->signaler.first = VK_NULL_HANDLE; // ANI isn't on a queue, so this can't participate in a completion proof. |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12427 | } |
| 12428 | |
| 12429 | // A successful call to AcquireNextImageKHR counts as a signal operation on semaphore |
| 12430 | if (pSemaphore) { |
| 12431 | pSemaphore->signaled = true; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 12432 | pSemaphore->signaler.first = VK_NULL_HANDLE; |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12433 | } |
Chris Forbes | 048399d | 2016-09-22 17:11:06 +1200 | [diff] [blame] | 12434 | |
| 12435 | // Mark the image as acquired. |
Chris Forbes | 048399d | 2016-09-22 17:11:06 +1200 | [diff] [blame] | 12436 | auto image = swapchain_data->images[*pImageIndex]; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 12437 | auto image_state = getImageState(dev_data, image); |
| 12438 | image_state->acquired = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12439 | } |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12440 | lock.unlock(); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 12441 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12442 | return result; |
| 12443 | } |
| 12444 | |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 12445 | VKAPI_ATTR VkResult VKAPI_CALL EnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount, |
| 12446 | VkPhysicalDevice *pPhysicalDevices) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12447 | bool skip_call = false; |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 12448 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
Tobin Ehlis | 8b0fbe2 | 2017-01-04 07:53:33 -0700 | [diff] [blame] | 12449 | assert(instance_data); |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 12450 | |
Tobin Ehlis | 8b0fbe2 | 2017-01-04 07:53:33 -0700 | [diff] [blame] | 12451 | // For this instance, flag when vkEnumeratePhysicalDevices goes to QUERY_COUNT and then QUERY_DETAILS |
| 12452 | if (NULL == pPhysicalDevices) { |
| 12453 | instance_data->vkEnumeratePhysicalDevicesState = QUERY_COUNT; |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 12454 | } else { |
Tobin Ehlis | 8b0fbe2 | 2017-01-04 07:53:33 -0700 | [diff] [blame] | 12455 | if (UNCALLED == instance_data->vkEnumeratePhysicalDevicesState) { |
| 12456 | // Flag warning here. You can call this without having queried the count, but it may not be |
| 12457 | // robust on platforms with multiple physical devices. |
| 12458 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 12459 | VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", |
| 12460 | "Call sequence has vkEnumeratePhysicalDevices() w/ non-NULL pPhysicalDevices. You should first " |
| 12461 | "call vkEnumeratePhysicalDevices() w/ NULL pPhysicalDevices to query pPhysicalDeviceCount."); |
| 12462 | } // TODO : Could also flag a warning if re-calling this function in QUERY_DETAILS state |
| 12463 | else if (instance_data->physical_devices_count != *pPhysicalDeviceCount) { |
| 12464 | // Having actual count match count from app is not a requirement, so this can be a warning |
| 12465 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 12466 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| 12467 | "Call to vkEnumeratePhysicalDevices() w/ pPhysicalDeviceCount value %u, but actual count " |
| 12468 | "supported by this instance is %u.", |
| 12469 | *pPhysicalDeviceCount, instance_data->physical_devices_count); |
| 12470 | } |
| 12471 | instance_data->vkEnumeratePhysicalDevicesState = QUERY_DETAILS; |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 12472 | } |
Tobin Ehlis | 8b0fbe2 | 2017-01-04 07:53:33 -0700 | [diff] [blame] | 12473 | if (skip_call) { |
| 12474 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12475 | } |
| 12476 | VkResult result = instance_data->dispatch_table.EnumeratePhysicalDevices(instance, pPhysicalDeviceCount, pPhysicalDevices); |
| 12477 | if (NULL == pPhysicalDevices) { |
| 12478 | instance_data->physical_devices_count = *pPhysicalDeviceCount; |
| 12479 | } else if (result == VK_SUCCESS) { // Save physical devices |
| 12480 | for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) { |
| 12481 | auto &phys_device_state = instance_data->physical_device_map[pPhysicalDevices[i]]; |
| 12482 | phys_device_state.phys_device = pPhysicalDevices[i]; |
| 12483 | // Init actual features for each physical device |
| 12484 | instance_data->dispatch_table.GetPhysicalDeviceFeatures(pPhysicalDevices[i], &phys_device_state.features); |
| 12485 | } |
| 12486 | } |
| 12487 | return result; |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 12488 | } |
| 12489 | |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12490 | VKAPI_ATTR void VKAPI_CALL |
| 12491 | GetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, |
| 12492 | VkQueueFamilyProperties *pQueueFamilyProperties) { |
| 12493 | bool skip_call = false; |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 12494 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
Chris Forbes | a88f31b | 2016-10-03 17:57:18 +1300 | [diff] [blame] | 12495 | auto physical_device_state = getPhysicalDeviceState(instance_data, physicalDevice); |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12496 | if (physical_device_state) { |
| 12497 | if (!pQueueFamilyProperties) { |
| 12498 | physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_COUNT; |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12499 | } |
| 12500 | else { |
| 12501 | // Verify that for each physical device, this function is called first with NULL pQueueFamilyProperties ptr in order to |
| 12502 | // get count |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12503 | if (UNCALLED == physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { |
Chris Forbes | a88f31b | 2016-10-03 17:57:18 +1300 | [diff] [blame] | 12504 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12505 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", |
| 12506 | "Call sequence has vkGetPhysicalDeviceQueueFamilyProperties() w/ non-NULL " |
| 12507 | "pQueueFamilyProperties. You should first call vkGetPhysicalDeviceQueueFamilyProperties() w/ " |
| 12508 | "NULL pQueueFamilyProperties to query pCount."); |
| 12509 | } |
| 12510 | // Then verify that pCount that is passed in on second call matches what was returned |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12511 | if (physical_device_state->queueFamilyPropertiesCount != *pCount) { |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12512 | |
| 12513 | // TODO: this is not a requirement of the Valid Usage section for vkGetPhysicalDeviceQueueFamilyProperties, so |
| 12514 | // provide as warning |
Chris Forbes | a88f31b | 2016-10-03 17:57:18 +1300 | [diff] [blame] | 12515 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12516 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| 12517 | "Call to vkGetPhysicalDeviceQueueFamilyProperties() w/ pCount value %u, but actual count " |
| 12518 | "supported by this physicalDevice is %u.", |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12519 | *pCount, physical_device_state->queueFamilyPropertiesCount); |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12520 | } |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12521 | physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_DETAILS; |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12522 | } |
| 12523 | if (skip_call) { |
| 12524 | return; |
| 12525 | } |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 12526 | instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(physicalDevice, pCount, pQueueFamilyProperties); |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12527 | if (!pQueueFamilyProperties) { |
| 12528 | physical_device_state->queueFamilyPropertiesCount = *pCount; |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12529 | } |
| 12530 | else { // Save queue family properties |
Chris Forbes | 8c09adb | 2016-10-03 18:06:20 +1300 | [diff] [blame] | 12531 | if (physical_device_state->queue_family_properties.size() < *pCount) |
| 12532 | physical_device_state->queue_family_properties.resize(*pCount); |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12533 | for (uint32_t i = 0; i < *pCount; i++) { |
Chris Forbes | 8c09adb | 2016-10-03 18:06:20 +1300 | [diff] [blame] | 12534 | physical_device_state->queue_family_properties[i] = pQueueFamilyProperties[i]; |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12535 | } |
| 12536 | } |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12537 | } |
| 12538 | else { |
Chris Forbes | a88f31b | 2016-10-03 17:57:18 +1300 | [diff] [blame] | 12539 | log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12540 | __LINE__, VALIDATION_ERROR_00028, "DL", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 12541 | "Invalid physicalDevice (0x%p) passed into vkGetPhysicalDeviceQueueFamilyProperties(). %s", physicalDevice, |
| 12542 | validation_error_map[VALIDATION_ERROR_00028]); |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12543 | } |
| 12544 | } |
| 12545 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 12546 | template<typename TCreateInfo, typename FPtr> |
| 12547 | static VkResult CreateSurface(VkInstance instance, TCreateInfo const *pCreateInfo, |
| 12548 | VkAllocationCallbacks const *pAllocator, VkSurfaceKHR *pSurface, |
| 12549 | FPtr fptr) |
| 12550 | { |
| 12551 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
| 12552 | |
| 12553 | // Call down the call chain: |
| 12554 | VkResult result = (instance_data->dispatch_table.*fptr)(instance, pCreateInfo, pAllocator, pSurface); |
| 12555 | |
| 12556 | if (result == VK_SUCCESS) { |
| 12557 | std::unique_lock<std::mutex> lock(global_lock); |
| 12558 | instance_data->surface_map[*pSurface] = SURFACE_STATE(*pSurface); |
| 12559 | lock.unlock(); |
| 12560 | } |
| 12561 | |
| 12562 | return result; |
| 12563 | } |
| 12564 | |
| 12565 | VKAPI_ATTR void VKAPI_CALL DestroySurfaceKHR(VkInstance instance, VkSurfaceKHR surface, const VkAllocationCallbacks *pAllocator) { |
| 12566 | bool skip_call = false; |
| 12567 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
| 12568 | std::unique_lock<std::mutex> lock(global_lock); |
| 12569 | auto surface_state = getSurfaceState(instance_data, surface); |
| 12570 | |
| 12571 | if (surface_state) { |
| 12572 | // TODO: track swapchains created from this surface. |
| 12573 | instance_data->surface_map.erase(surface); |
| 12574 | } |
| 12575 | lock.unlock(); |
| 12576 | |
| 12577 | if (!skip_call) { |
| 12578 | // Call down the call chain: |
| 12579 | instance_data->dispatch_table.DestroySurfaceKHR(instance, surface, pAllocator); |
| 12580 | } |
| 12581 | } |
| 12582 | |
Norbert Nopper | 1dec9a5 | 2016-11-25 07:55:13 +0100 | [diff] [blame] | 12583 | VKAPI_ATTR VkResult VKAPI_CALL CreateDisplayPlaneSurfaceKHR(VkInstance instance, const VkDisplaySurfaceCreateInfoKHR *pCreateInfo, |
| 12584 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12585 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateDisplayPlaneSurfaceKHR); |
| 12586 | } |
| 12587 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 12588 | #ifdef VK_USE_PLATFORM_ANDROID_KHR |
| 12589 | VKAPI_ATTR VkResult VKAPI_CALL CreateAndroidSurfaceKHR(VkInstance instance, const VkAndroidSurfaceCreateInfoKHR *pCreateInfo, |
| 12590 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12591 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateAndroidSurfaceKHR); |
| 12592 | } |
| 12593 | #endif // VK_USE_PLATFORM_ANDROID_KHR |
| 12594 | |
| 12595 | #ifdef VK_USE_PLATFORM_MIR_KHR |
| 12596 | VKAPI_ATTR VkResult VKAPI_CALL CreateMirSurfaceKHR(VkInstance instance, const VkMirSurfaceCreateInfoKHR *pCreateInfo, |
| 12597 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12598 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateMirSurfaceKHR); |
| 12599 | } |
| 12600 | #endif // VK_USE_PLATFORM_MIR_KHR |
| 12601 | |
| 12602 | #ifdef VK_USE_PLATFORM_WAYLAND_KHR |
| 12603 | VKAPI_ATTR VkResult VKAPI_CALL CreateWaylandSurfaceKHR(VkInstance instance, const VkWaylandSurfaceCreateInfoKHR *pCreateInfo, |
| 12604 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
Tobin Ehlis | ce0dcd2 | 2016-10-06 09:11:25 -0600 | [diff] [blame] | 12605 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateWaylandSurfaceKHR); |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 12606 | } |
| 12607 | #endif // VK_USE_PLATFORM_WAYLAND_KHR |
| 12608 | |
| 12609 | #ifdef VK_USE_PLATFORM_WIN32_KHR |
| 12610 | VKAPI_ATTR VkResult VKAPI_CALL CreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo, |
| 12611 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12612 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateWin32SurfaceKHR); |
| 12613 | } |
| 12614 | #endif // VK_USE_PLATFORM_WIN32_KHR |
| 12615 | |
| 12616 | #ifdef VK_USE_PLATFORM_XCB_KHR |
| 12617 | VKAPI_ATTR VkResult VKAPI_CALL CreateXcbSurfaceKHR(VkInstance instance, const VkXcbSurfaceCreateInfoKHR *pCreateInfo, |
| 12618 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12619 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateXcbSurfaceKHR); |
| 12620 | } |
| 12621 | #endif // VK_USE_PLATFORM_XCB_KHR |
| 12622 | |
| 12623 | #ifdef VK_USE_PLATFORM_XLIB_KHR |
| 12624 | VKAPI_ATTR VkResult VKAPI_CALL CreateXlibSurfaceKHR(VkInstance instance, const VkXlibSurfaceCreateInfoKHR *pCreateInfo, |
| 12625 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12626 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateXlibSurfaceKHR); |
| 12627 | } |
| 12628 | #endif // VK_USE_PLATFORM_XLIB_KHR |
| 12629 | |
| 12630 | |
Chris Forbes | 6c2bc8f | 2016-10-11 15:57:55 +1300 | [diff] [blame] | 12631 | VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceCapabilitiesKHR(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, |
| 12632 | VkSurfaceCapabilitiesKHR *pSurfaceCapabilities) { |
| 12633 | auto instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| 12634 | |
| 12635 | std::unique_lock<std::mutex> lock(global_lock); |
| 12636 | auto physical_device_state = getPhysicalDeviceState(instance_data, physicalDevice); |
| 12637 | lock.unlock(); |
| 12638 | |
| 12639 | auto result = instance_data->dispatch_table.GetPhysicalDeviceSurfaceCapabilitiesKHR(physicalDevice, surface, |
| 12640 | pSurfaceCapabilities); |
| 12641 | |
| 12642 | if (result == VK_SUCCESS) { |
| 12643 | physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState = QUERY_DETAILS; |
| 12644 | physical_device_state->surfaceCapabilities = *pSurfaceCapabilities; |
| 12645 | } |
| 12646 | |
| 12647 | return result; |
| 12648 | } |
| 12649 | |
Chris Forbes | 97058a6 | 2016-10-12 08:55:03 +1300 | [diff] [blame] | 12650 | |
| 12651 | VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceSupportKHR(VkPhysicalDevice physicalDevice, uint32_t queueFamilyIndex, |
| 12652 | VkSurfaceKHR surface, VkBool32 *pSupported) { |
| 12653 | auto instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| 12654 | std::unique_lock<std::mutex> lock(global_lock); |
| 12655 | auto surface_state = getSurfaceState(instance_data, surface); |
| 12656 | lock.unlock(); |
| 12657 | |
| 12658 | auto result = instance_data->dispatch_table.GetPhysicalDeviceSurfaceSupportKHR(physicalDevice, queueFamilyIndex, surface, |
| 12659 | pSupported); |
| 12660 | |
| 12661 | if (result == VK_SUCCESS) { |
Mark Lobodzinski | 9e02344 | 2016-11-23 11:28:30 -0700 | [diff] [blame] | 12662 | surface_state->gpu_queue_support[{physicalDevice, queueFamilyIndex}] = (*pSupported != 0); |
Chris Forbes | 97058a6 | 2016-10-12 08:55:03 +1300 | [diff] [blame] | 12663 | } |
| 12664 | |
| 12665 | return result; |
| 12666 | } |
| 12667 | |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12668 | |
| 12669 | VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfacePresentModesKHR(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, |
| 12670 | uint32_t *pPresentModeCount, |
| 12671 | VkPresentModeKHR *pPresentModes) { |
| 12672 | bool skip_call = false; |
| 12673 | auto instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| 12674 | std::unique_lock<std::mutex> lock(global_lock); |
| 12675 | // TODO: this isn't quite right. available modes may differ by surface AND physical device. |
| 12676 | auto physical_device_state = getPhysicalDeviceState(instance_data, physicalDevice); |
| 12677 | auto & call_state = physical_device_state->vkGetPhysicalDeviceSurfacePresentModesKHRState; |
| 12678 | |
| 12679 | if (pPresentModes) { |
| 12680 | // Compare the preliminary value of *pPresentModeCount with the value this time: |
| 12681 | auto prev_mode_count = (uint32_t) physical_device_state->present_modes.size(); |
| 12682 | switch (call_state) { |
| 12683 | case UNCALLED: |
| 12684 | skip_call |= log_msg( |
| 12685 | instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 12686 | reinterpret_cast<uint64_t>(physicalDevice), __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", |
| 12687 | "vkGetPhysicalDeviceSurfacePresentModesKHR() called with non-NULL pPresentModeCount; but no prior positive " |
| 12688 | "value has been seen for pPresentModeCount."); |
| 12689 | break; |
| 12690 | default: |
| 12691 | // both query count and query details |
| 12692 | if (*pPresentModeCount != prev_mode_count) { |
| 12693 | skip_call |= log_msg( |
| 12694 | instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 12695 | reinterpret_cast<uint64_t>(physicalDevice), __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| 12696 | "vkGetPhysicalDeviceSurfacePresentModesKHR() called with *pPresentModeCount (%u) that differs from the value " |
| 12697 | "(%u) that was returned when pPresentModes was NULL.", |
| 12698 | *pPresentModeCount, prev_mode_count); |
| 12699 | } |
| 12700 | break; |
| 12701 | } |
| 12702 | } |
| 12703 | lock.unlock(); |
| 12704 | |
| 12705 | if (skip_call) |
| 12706 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12707 | |
| 12708 | auto result = instance_data->dispatch_table.GetPhysicalDeviceSurfacePresentModesKHR(physicalDevice, surface, pPresentModeCount, pPresentModes); |
| 12709 | |
| 12710 | if (result == VK_SUCCESS || result == VK_INCOMPLETE) { |
| 12711 | |
| 12712 | lock.lock(); |
| 12713 | |
| 12714 | if (*pPresentModeCount) { |
| 12715 | if (call_state < QUERY_COUNT) call_state = QUERY_COUNT; |
| 12716 | if (*pPresentModeCount > physical_device_state->present_modes.size()) |
| 12717 | physical_device_state->present_modes.resize(*pPresentModeCount); |
| 12718 | } |
| 12719 | if (pPresentModes) { |
| 12720 | if (call_state < QUERY_DETAILS) call_state = QUERY_DETAILS; |
| 12721 | for (uint32_t i = 0; i < *pPresentModeCount; i++) { |
| 12722 | physical_device_state->present_modes[i] = pPresentModes[i]; |
| 12723 | } |
| 12724 | } |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12725 | } |
| 12726 | |
| 12727 | return result; |
| 12728 | } |
| 12729 | |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 12730 | |
| 12731 | VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceFormatsKHR(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, |
| 12732 | uint32_t *pSurfaceFormatCount, |
| 12733 | VkSurfaceFormatKHR *pSurfaceFormats) { |
| 12734 | bool skip_call = false; |
| 12735 | auto instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| 12736 | std::unique_lock<std::mutex> lock(global_lock); |
| 12737 | auto physical_device_state = getPhysicalDeviceState(instance_data, physicalDevice); |
| 12738 | auto & call_state = physical_device_state->vkGetPhysicalDeviceSurfaceFormatsKHRState; |
| 12739 | |
| 12740 | if (pSurfaceFormats) { |
| 12741 | auto prev_format_count = (uint32_t) physical_device_state->surface_formats.size(); |
| 12742 | |
| 12743 | switch (call_state) { |
| 12744 | case UNCALLED: |
| 12745 | // Since we haven't recorded a preliminary value of *pSurfaceFormatCount, that likely means that the application didn't |
| 12746 | // previously call this function with a NULL value of pSurfaceFormats: |
| 12747 | skip_call |= log_msg( |
| 12748 | instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 12749 | reinterpret_cast<uint64_t>(physicalDevice), __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", |
| 12750 | "vkGetPhysicalDeviceSurfaceFormatsKHR() called with non-NULL pSurfaceFormatCount; but no prior positive " |
| 12751 | "value has been seen for pSurfaceFormats."); |
| 12752 | break; |
| 12753 | default: |
| 12754 | if (prev_format_count != *pSurfaceFormatCount) { |
| 12755 | skip_call |= log_msg( |
| 12756 | instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 12757 | reinterpret_cast<uint64_t>(physicalDevice), __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| 12758 | "vkGetPhysicalDeviceSurfaceFormatsKHR() called with non-NULL pSurfaceFormatCount, and with pSurfaceFormats set to " |
| 12759 | "a value (%u) that is greater than the value (%u) that was returned when pSurfaceFormatCount was NULL.", |
| 12760 | *pSurfaceFormatCount, prev_format_count); |
| 12761 | } |
| 12762 | break; |
| 12763 | } |
| 12764 | } |
| 12765 | lock.unlock(); |
| 12766 | |
| 12767 | if (skip_call) |
| 12768 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12769 | |
| 12770 | // Call down the call chain: |
| 12771 | auto result = instance_data->dispatch_table.GetPhysicalDeviceSurfaceFormatsKHR(physicalDevice, surface, pSurfaceFormatCount, |
| 12772 | pSurfaceFormats); |
| 12773 | |
| 12774 | if (result == VK_SUCCESS || result == VK_INCOMPLETE) { |
| 12775 | |
| 12776 | lock.lock(); |
| 12777 | |
| 12778 | if (*pSurfaceFormatCount) { |
| 12779 | if (call_state < QUERY_COUNT) call_state = QUERY_COUNT; |
| 12780 | if (*pSurfaceFormatCount > physical_device_state->surface_formats.size()) |
| 12781 | physical_device_state->surface_formats.resize(*pSurfaceFormatCount); |
| 12782 | } |
| 12783 | if (pSurfaceFormats) { |
| 12784 | if (call_state < QUERY_DETAILS) call_state = QUERY_DETAILS; |
| 12785 | for (uint32_t i = 0; i < *pSurfaceFormatCount; i++) { |
| 12786 | physical_device_state->surface_formats[i] = pSurfaceFormats[i]; |
| 12787 | } |
| 12788 | } |
| 12789 | } |
| 12790 | return result; |
| 12791 | } |
| 12792 | |
| 12793 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12794 | VKAPI_ATTR VkResult VKAPI_CALL |
| 12795 | CreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, |
| 12796 | const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12797 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 12798 | VkResult res = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12799 | if (VK_SUCCESS == res) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12800 | std::lock_guard<std::mutex> lock(global_lock); |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12801 | res = layer_create_msg_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12802 | } |
| 12803 | return res; |
| 12804 | } |
| 12805 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12806 | VKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, |
| 12807 | VkDebugReportCallbackEXT msgCallback, |
| 12808 | const VkAllocationCallbacks *pAllocator) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12809 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 12810 | instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12811 | std::lock_guard<std::mutex> lock(global_lock); |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12812 | layer_destroy_msg_callback(instance_data->report_data, msgCallback, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12813 | } |
| 12814 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12815 | VKAPI_ATTR void VKAPI_CALL |
| 12816 | DebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, |
| 12817 | size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12818 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 12819 | instance_data->dispatch_table.DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12820 | } |
| 12821 | |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 12822 | VKAPI_ATTR VkResult VKAPI_CALL |
| 12823 | EnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { |
| 12824 | return util_GetLayerProperties(1, &global_layer, pCount, pProperties); |
| 12825 | } |
| 12826 | |
| 12827 | VKAPI_ATTR VkResult VKAPI_CALL |
| 12828 | EnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { |
| 12829 | return util_GetLayerProperties(1, &global_layer, pCount, pProperties); |
| 12830 | } |
| 12831 | |
| 12832 | VKAPI_ATTR VkResult VKAPI_CALL |
| 12833 | EnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { |
| 12834 | if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) |
| 12835 | return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); |
| 12836 | |
| 12837 | return VK_ERROR_LAYER_NOT_PRESENT; |
| 12838 | } |
| 12839 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12840 | VKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, |
| 12841 | const char *pLayerName, uint32_t *pCount, |
| 12842 | VkExtensionProperties *pProperties) { |
Chia-I Wu | 3ee8023 | 2016-05-06 11:38:37 +0800 | [diff] [blame] | 12843 | if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 12844 | return util_GetExtensionProperties(0, NULL, pCount, pProperties); |
Chia-I Wu | 3ee8023 | 2016-05-06 11:38:37 +0800 | [diff] [blame] | 12845 | |
| 12846 | assert(physicalDevice); |
| 12847 | |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 12848 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| 12849 | return instance_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 12850 | } |
| 12851 | |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 12852 | static PFN_vkVoidFunction |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12853 | intercept_core_instance_command(const char *name); |
| 12854 | |
| 12855 | static PFN_vkVoidFunction |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 12856 | intercept_core_device_command(const char *name); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12857 | |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 12858 | static PFN_vkVoidFunction |
| 12859 | intercept_khr_swapchain_command(const char *name, VkDevice dev); |
| 12860 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 12861 | static PFN_vkVoidFunction |
| 12862 | intercept_khr_surface_command(const char *name, VkInstance instance); |
| 12863 | |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 12864 | VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { |
| 12865 | PFN_vkVoidFunction proc = intercept_core_device_command(funcName); |
| 12866 | if (proc) |
| 12867 | return proc; |
| 12868 | |
| 12869 | assert(dev); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12870 | |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 12871 | proc = intercept_khr_swapchain_command(funcName, dev); |
| 12872 | if (proc) |
| 12873 | return proc; |
| 12874 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 12875 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12876 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12877 | auto &table = dev_data->dispatch_table; |
| 12878 | if (!table.GetDeviceProcAddr) |
| 12879 | return nullptr; |
| 12880 | return table.GetDeviceProcAddr(dev, funcName); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12881 | } |
| 12882 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12883 | VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12884 | PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); |
Chia-I Wu | dc6e5a2 | 2016-05-06 12:04:23 +0800 | [diff] [blame] | 12885 | if (!proc) |
| 12886 | proc = intercept_core_device_command(funcName); |
| 12887 | if (!proc) |
| 12888 | proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 12889 | if (!proc) |
| 12890 | proc = intercept_khr_surface_command(funcName, instance); |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12891 | if (proc) |
| 12892 | return proc; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12893 | |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12894 | assert(instance); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12895 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12896 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
| 12897 | proc = debug_report_get_instance_proc_addr(instance_data->report_data, funcName); |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12898 | if (proc) |
| 12899 | return proc; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12900 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12901 | auto &table = instance_data->dispatch_table; |
| 12902 | if (!table.GetInstanceProcAddr) |
| 12903 | return nullptr; |
| 12904 | return table.GetInstanceProcAddr(instance, funcName); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12905 | } |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 12906 | |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 12907 | static PFN_vkVoidFunction |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12908 | intercept_core_instance_command(const char *name) { |
| 12909 | static const struct { |
| 12910 | const char *name; |
| 12911 | PFN_vkVoidFunction proc; |
| 12912 | } core_instance_commands[] = { |
| 12913 | { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, |
| 12914 | { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, |
| 12915 | { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, |
| 12916 | { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 12917 | { "vkEnumeratePhysicalDevices", reinterpret_cast<PFN_vkVoidFunction>(EnumeratePhysicalDevices) }, |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12918 | { "vkGetPhysicalDeviceQueueFamilyProperties", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceQueueFamilyProperties) }, |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12919 | { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 12920 | { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, |
| 12921 | { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, |
| 12922 | { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12923 | { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, |
| 12924 | }; |
| 12925 | |
| 12926 | for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { |
| 12927 | if (!strcmp(core_instance_commands[i].name, name)) |
| 12928 | return core_instance_commands[i].proc; |
| 12929 | } |
| 12930 | |
| 12931 | return nullptr; |
| 12932 | } |
| 12933 | |
| 12934 | static PFN_vkVoidFunction |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 12935 | intercept_core_device_command(const char *name) { |
| 12936 | static const struct { |
| 12937 | const char *name; |
| 12938 | PFN_vkVoidFunction proc; |
| 12939 | } core_device_commands[] = { |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 12940 | {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, |
| 12941 | {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, |
| 12942 | {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, |
| 12943 | {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, |
| 12944 | {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, |
| 12945 | {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, |
| 12946 | {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, |
| 12947 | {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, |
| 12948 | {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, |
| 12949 | {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, |
| 12950 | {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, |
| 12951 | {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, |
| 12952 | {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, |
| 12953 | {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, |
| 12954 | {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, |
| 12955 | {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, |
| 12956 | {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, |
| 12957 | {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, |
| 12958 | {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, |
| 12959 | {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, |
| 12960 | {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, |
| 12961 | {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, |
| 12962 | {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, |
| 12963 | {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, |
| 12964 | {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, |
| 12965 | {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, |
| 12966 | {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, |
| 12967 | {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, |
| 12968 | {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, |
| 12969 | {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, |
| 12970 | {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, |
| 12971 | {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, |
| 12972 | {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, |
| 12973 | {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, |
| 12974 | {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, |
| 12975 | {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, |
| 12976 | {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, |
| 12977 | {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, |
| 12978 | {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, |
| 12979 | {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, |
| 12980 | {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, |
| 12981 | {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, |
| 12982 | {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, |
| 12983 | {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, |
| 12984 | {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, |
| 12985 | {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, |
| 12986 | {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, |
| 12987 | {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, |
| 12988 | {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, |
| 12989 | {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, |
| 12990 | {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, |
| 12991 | {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, |
| 12992 | {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, |
| 12993 | {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, |
| 12994 | {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, |
| 12995 | {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, |
| 12996 | {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, |
| 12997 | {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, |
| 12998 | {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, |
| 12999 | {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, |
| 13000 | {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, |
| 13001 | {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, |
| 13002 | {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, |
| 13003 | {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, |
| 13004 | {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, |
| 13005 | {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, |
| 13006 | {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, |
| 13007 | {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, |
| 13008 | {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, |
| 13009 | {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, |
| 13010 | {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, |
| 13011 | {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, |
| 13012 | {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, |
| 13013 | {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, |
| 13014 | {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, |
| 13015 | {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, |
| 13016 | {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, |
| 13017 | {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, |
| 13018 | {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, |
| 13019 | {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, |
| 13020 | {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, |
| 13021 | {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, |
| 13022 | {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, |
| 13023 | {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, |
| 13024 | {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, |
| 13025 | {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, |
| 13026 | {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, |
| 13027 | {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, |
| 13028 | {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, |
| 13029 | {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, |
| 13030 | {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, |
| 13031 | {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, |
| 13032 | {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, |
| 13033 | {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, |
| 13034 | {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, |
| 13035 | {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, |
| 13036 | {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, |
| 13037 | {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, |
| 13038 | {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, |
| 13039 | {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, |
| 13040 | {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, |
| 13041 | {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, |
| 13042 | {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, |
| 13043 | {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, |
| 13044 | {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, |
| 13045 | {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, |
| 13046 | {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, |
| 13047 | {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, |
| 13048 | {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, |
| 13049 | {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, |
| 13050 | {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, |
| 13051 | {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, |
| 13052 | {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, |
| 13053 | {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, |
| 13054 | {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, |
| 13055 | {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 13056 | }; |
| 13057 | |
| 13058 | for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { |
| 13059 | if (!strcmp(core_device_commands[i].name, name)) |
| 13060 | return core_device_commands[i].proc; |
| 13061 | } |
| 13062 | |
| 13063 | return nullptr; |
| 13064 | } |
| 13065 | |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 13066 | static PFN_vkVoidFunction |
| 13067 | intercept_khr_swapchain_command(const char *name, VkDevice dev) { |
| 13068 | static const struct { |
| 13069 | const char *name; |
| 13070 | PFN_vkVoidFunction proc; |
| 13071 | } khr_swapchain_commands[] = { |
| 13072 | { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, |
| 13073 | { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, |
| 13074 | { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, |
| 13075 | { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, |
| 13076 | { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, |
| 13077 | }; |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 13078 | layer_data *dev_data = nullptr; |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 13079 | |
Chia-I Wu | dc6e5a2 | 2016-05-06 12:04:23 +0800 | [diff] [blame] | 13080 | if (dev) { |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 13081 | dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); |
Chia-I Wu | dc6e5a2 | 2016-05-06 12:04:23 +0800 | [diff] [blame] | 13082 | if (!dev_data->device_extensions.wsi_enabled) |
| 13083 | return nullptr; |
| 13084 | } |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 13085 | |
| 13086 | for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { |
| 13087 | if (!strcmp(khr_swapchain_commands[i].name, name)) |
| 13088 | return khr_swapchain_commands[i].proc; |
| 13089 | } |
| 13090 | |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 13091 | if (dev_data) { |
| 13092 | if (!dev_data->device_extensions.wsi_display_swapchain_enabled) |
| 13093 | return nullptr; |
| 13094 | } |
| 13095 | |
| 13096 | if (!strcmp("vkCreateSharedSwapchainsKHR", name)) |
| 13097 | return reinterpret_cast<PFN_vkVoidFunction>(CreateSharedSwapchainsKHR); |
| 13098 | |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 13099 | return nullptr; |
| 13100 | } |
| 13101 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 13102 | static PFN_vkVoidFunction |
| 13103 | intercept_khr_surface_command(const char *name, VkInstance instance) { |
| 13104 | static const struct { |
| 13105 | const char *name; |
| 13106 | PFN_vkVoidFunction proc; |
| 13107 | bool instance_layer_data::*enable; |
| 13108 | } khr_surface_commands[] = { |
| 13109 | #ifdef VK_USE_PLATFORM_ANDROID_KHR |
| 13110 | {"vkCreateAndroidSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateAndroidSurfaceKHR), |
| 13111 | &instance_layer_data::androidSurfaceExtensionEnabled}, |
| 13112 | #endif // VK_USE_PLATFORM_ANDROID_KHR |
| 13113 | #ifdef VK_USE_PLATFORM_MIR_KHR |
| 13114 | {"vkCreateMirSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateMirSurfaceKHR), |
| 13115 | &instance_layer_data::mirSurfaceExtensionEnabled}, |
| 13116 | #endif // VK_USE_PLATFORM_MIR_KHR |
| 13117 | #ifdef VK_USE_PLATFORM_WAYLAND_KHR |
| 13118 | {"vkCreateWaylandSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateWaylandSurfaceKHR), |
| 13119 | &instance_layer_data::waylandSurfaceExtensionEnabled}, |
| 13120 | #endif // VK_USE_PLATFORM_WAYLAND_KHR |
| 13121 | #ifdef VK_USE_PLATFORM_WIN32_KHR |
| 13122 | {"vkCreateWin32SurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateWin32SurfaceKHR), |
| 13123 | &instance_layer_data::win32SurfaceExtensionEnabled}, |
| 13124 | #endif // VK_USE_PLATFORM_WIN32_KHR |
| 13125 | #ifdef VK_USE_PLATFORM_XCB_KHR |
| 13126 | {"vkCreateXcbSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateXcbSurfaceKHR), |
| 13127 | &instance_layer_data::xcbSurfaceExtensionEnabled}, |
| 13128 | #endif // VK_USE_PLATFORM_XCB_KHR |
| 13129 | #ifdef VK_USE_PLATFORM_XLIB_KHR |
| 13130 | {"vkCreateXlibSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateXlibSurfaceKHR), |
| 13131 | &instance_layer_data::xlibSurfaceExtensionEnabled}, |
| 13132 | #endif // VK_USE_PLATFORM_XLIB_KHR |
Norbert Nopper | 1dec9a5 | 2016-11-25 07:55:13 +0100 | [diff] [blame] | 13133 | { "vkCreateDisplayPlaneSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateDisplayPlaneSurfaceKHR), |
| 13134 | &instance_layer_data::displayExtensionEnabled}, |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 13135 | {"vkDestroySurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySurfaceKHR), |
| 13136 | &instance_layer_data::surfaceExtensionEnabled}, |
Chris Forbes | 6c2bc8f | 2016-10-11 15:57:55 +1300 | [diff] [blame] | 13137 | {"vkGetPhysicalDeviceSurfaceCapabilitiesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceSurfaceCapabilitiesKHR), |
| 13138 | &instance_layer_data::surfaceExtensionEnabled}, |
Chris Forbes | 97058a6 | 2016-10-12 08:55:03 +1300 | [diff] [blame] | 13139 | {"vkGetPhysicalDeviceSurfaceSupportKHR", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceSurfaceSupportKHR), |
| 13140 | &instance_layer_data::surfaceExtensionEnabled}, |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 13141 | {"vkGetPhysicalDeviceSurfacePresentModesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceSurfacePresentModesKHR), |
| 13142 | &instance_layer_data::surfaceExtensionEnabled}, |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 13143 | {"vkGetPhysicalDeviceSurfaceFormatsKHR", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceSurfaceFormatsKHR), |
| 13144 | &instance_layer_data::surfaceExtensionEnabled}, |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 13145 | }; |
| 13146 | |
| 13147 | instance_layer_data *instance_data = nullptr; |
| 13148 | if (instance) { |
| 13149 | instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
| 13150 | } |
| 13151 | |
| 13152 | for (size_t i = 0; i < ARRAY_SIZE(khr_surface_commands); i++) { |
| 13153 | if (!strcmp(khr_surface_commands[i].name, name)) { |
| 13154 | if (instance_data && !(instance_data->*(khr_surface_commands[i].enable))) |
| 13155 | return nullptr; |
| 13156 | return khr_surface_commands[i].proc; |
| 13157 | } |
| 13158 | } |
| 13159 | |
| 13160 | return nullptr; |
| 13161 | } |
| 13162 | |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13163 | } // namespace core_validation |
| 13164 | |
| 13165 | // vk_layer_logging.h expects these to be defined |
| 13166 | |
| 13167 | VKAPI_ATTR VkResult VKAPI_CALL |
| 13168 | vkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, |
| 13169 | const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 13170 | return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13171 | } |
| 13172 | |
| 13173 | VKAPI_ATTR void VKAPI_CALL |
| 13174 | vkDestroyDebugReportCallbackEXT(VkInstance instance, |
| 13175 | VkDebugReportCallbackEXT msgCallback, |
| 13176 | const VkAllocationCallbacks *pAllocator) { |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 13177 | core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13178 | } |
| 13179 | |
| 13180 | VKAPI_ATTR void VKAPI_CALL |
| 13181 | vkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, |
| 13182 | size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 13183 | core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13184 | } |
| 13185 | |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13186 | // loader-layer interface v0, just wrappers since there is only a layer |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13187 | |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 13188 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 13189 | vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13190 | return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 13191 | } |
| 13192 | |
| 13193 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 13194 | vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13195 | return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 13196 | } |
| 13197 | |
| 13198 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 13199 | vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13200 | // the layer command handles VK_NULL_HANDLE just fine internally |
| 13201 | assert(physicalDevice == VK_NULL_HANDLE); |
| 13202 | return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13203 | } |
| 13204 | |
| 13205 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, |
| 13206 | const char *pLayerName, uint32_t *pCount, |
| 13207 | VkExtensionProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13208 | // the layer command handles VK_NULL_HANDLE just fine internally |
| 13209 | assert(physicalDevice == VK_NULL_HANDLE); |
Chia-I Wu | 3ee8023 | 2016-05-06 11:38:37 +0800 | [diff] [blame] | 13210 | return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13211 | } |
| 13212 | |
| 13213 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 13214 | return core_validation::GetDeviceProcAddr(dev, funcName); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13215 | } |
| 13216 | |
| 13217 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 13218 | return core_validation::GetInstanceProcAddr(instance, funcName); |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 13219 | } |