blob: ab98eefcb8a3e81387ddbe3f7ddeeb3cba421050 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900333 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
334 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700335 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700336 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900338}
339
Jiyong Park40782d02020-07-24 19:17:43 +0900340TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
342 const string expected_stderr =
343 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344 CaptureStderr();
345 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900347}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348
Jiyong Park40782d02020-07-24 19:17:43 +0900349TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700350 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900351 const string expected_stderr =
352 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
369 const string expected_stderr =
370 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
371 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800374}
375
Devin Moore2f2077a2020-08-28 11:27:53 -0700376TEST_P(AidlTest, AcceptNullableList) {
377 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
378 const string expected_stderr = "";
379 CaptureStderr();
380 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 const string method = "package a; interface IFoo { void f(int a, int a); }";
386 const string expected_stderr =
387 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
388 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700391}
392
Jeongik Cha13066da2020-08-06 15:43:19 +0900393TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
394 const string method = "package a; parcelable Foo { int a; String a; }";
395 const string expected_stderr =
396 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
397 CaptureStderr();
398 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
400}
401
Jooyung Hand902a972020-10-23 17:32:44 +0900402TEST_P(AidlTest, RejectsRepeatedAnnotations) {
403 const string method = R"(@Hide @Hide parcelable Foo {})";
404 const string expected_stderr =
405 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
406 "Foo.aidl:1.1-6\n";
407 CaptureStderr();
408 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
409 EXPECT_EQ(expected_stderr, GetCapturedStderr());
410}
411
Devin Moore7b8d5c92020-03-17 14:14:08 -0700412TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700413 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
414 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
415 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100418}
419
Devin Moore7b8d5c92020-03-17 14:14:08 -0700420TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700421 AidlError error;
422 const string method = "package a; @nullable interface IFoo { int f(); }";
423 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800424 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900425 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700426 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700427 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700428 EXPECT_EQ(expected_stderr, GetCapturedStderr());
429 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800430}
431
Devin Moore7b8d5c92020-03-17 14:14:08 -0700432TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700433 AidlError error;
434 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
435 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800436 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900437 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700438 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700439 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
441 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800442}
443
Devin Moore7b8d5c92020-03-17 14:14:08 -0700444TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700445 AidlError error;
446 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
447 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000448 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900449 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900450 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700451 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000452 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700453 EXPECT_EQ(expected_stderr, GetCapturedStderr());
454 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800455}
456
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700458 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000459 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700460 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000461 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900462 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDebug, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700463 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700464 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000465 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
467 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800468}
469
Jiyong Park40782d02020-07-24 19:17:43 +0900470TEST_P(AidlTest, ParsesNonNullableAnnotation) {
471 auto parse_result =
472 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
473 ASSERT_NE(nullptr, parse_result);
474 const AidlInterface* interface = parse_result->AsInterface();
475 ASSERT_NE(nullptr, interface);
476 ASSERT_FALSE(interface->GetMethods().empty());
477 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
478}
479
Devin Moore7b8d5c92020-03-17 14:14:08 -0700480TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900481 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
482 typenames_, GetLanguage());
483 ASSERT_NE(nullptr, parse_result);
484 const AidlInterface* interface = parse_result->AsInterface();
485 ASSERT_NE(nullptr, interface);
486 ASSERT_FALSE(interface->GetMethods().empty());
487 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
488}
489
490TEST_P(AidlTest, ParsesNonUtf8Annotations) {
491 auto parse_result =
492 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
493 ASSERT_NE(nullptr, parse_result);
494 const AidlInterface* interface = parse_result->AsInterface();
495 ASSERT_NE(nullptr, interface);
496 ASSERT_FALSE(interface->GetMethods().empty());
497 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800498}
499
Devin Moore7b8d5c92020-03-17 14:14:08 -0700500TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900501 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
502 typenames_, GetLanguage());
503 ASSERT_NE(nullptr, parse_result);
504 const AidlInterface* interface = parse_result->AsInterface();
505 ASSERT_NE(nullptr, interface);
506 ASSERT_FALSE(interface->GetMethods().empty());
507 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800508}
509
Devin Moore7b8d5c92020-03-17 14:14:08 -0700510TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700511 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700512 const string expected_stderr =
513 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
514 "\"vintf\"'\n"
515 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
516 "--structured\n";
517 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700518 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700519 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522}
523
Devin Moore7b8d5c92020-03-17 14:14:08 -0700524TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700526 const string expected_stderr =
527 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
528 "--structured\n";
529 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700530 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700531 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534}
535
Devin Moore7b8d5c92020-03-17 14:14:08 -0700536TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700537 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700538 const string expected_stderr =
539 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
540 "\"vintf\"'\n";
541 CaptureStderr();
542 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700543 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546}
547
Devin Moore7b8d5c92020-03-17 14:14:08 -0700548TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700549 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700550 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
551 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700552 ASSERT_EQ(AidlError::OK, error);
553 ASSERT_NE(nullptr, parse_result);
554 const AidlInterface* interface = parse_result->AsInterface();
555 ASSERT_NE(nullptr, interface);
556 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700557}
558
Jeongik Cha64783ed2019-06-07 18:30:54 +0900559TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
560 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900561 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
562 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900563 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700564 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900565 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900566 "a/Foo.aidl",
567 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900568
569 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900570 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700571 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900572 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700573 "Parcelable must be defined in AIDL directly.\n";
574 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900575 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700577
578 CaptureStderr();
579 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900581}
582
Jiyong Park43113fb2020-07-20 16:26:19 +0900583TEST_F(AidlTest, ParsesJavaDebugAnnotation) {
584 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
585 @JavaDebug parcelable IFoo { int a; float b; })");
586 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
587 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
588
589 string java_out;
590 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
591 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
592
593 // Other backends shouldn't be bothered
594 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
595 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
596
597 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
598 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
599}
600
601TEST_F(AidlTest, RejectsJavaDebugAnnotation) {
602 {
603 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug interface IFoo{}");
604 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
605 CaptureStderr();
606 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
607 const std::string expected_stderr =
608 "ERROR: a/IFoo.aidl:1.22-32: 'JavaDebug' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900609 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
610 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900611 EXPECT_EQ(expected_stderr, GetCapturedStderr());
612 }
613
614 {
615 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug enum IFoo { A=1, }");
616 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
617 CaptureStderr();
618 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
619 const std::string expected_stderr =
620 "ERROR: a/IFoo.aidl:1.27-32: 'JavaDebug' is not a supported annotation for this node. "
621 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
622 EXPECT_EQ(expected_stderr, GetCapturedStderr());
623 }
624}
625
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900626TEST_P(AidlTest, ParseDescriptorAnnotation) {
627 AidlError error;
628 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
629 typenames_, GetLanguage(), &error, {"--structured"});
630 ASSERT_EQ(AidlError::OK, error);
631 ASSERT_NE(nullptr, parse_result);
632 const AidlInterface* interface = parse_result->AsInterface();
633 ASSERT_NE(nullptr, interface);
634 ASSERT_EQ("IBar", interface->GetDescriptor());
635}
636
Jiyong Park40782d02020-07-24 19:17:43 +0900637TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700638 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700639 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900640}
641
642TEST_P(AidlTest, AcceptsOnewayInterface) {
643 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700644 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700645}
Christopher Wileyef140932015-11-03 09:29:19 -0800646
Devin Moore7b8d5c92020-03-17 14:14:08 -0700647TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700648 const string oneway_method =
649 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700650 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100651}
652
Steven Moreland65297cc2020-04-20 20:17:36 -0700653TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
654 const string oneway_method =
655 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
656 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
657 ASSERT_NE(nullptr, defined);
658 const AidlInterface* iface = defined->AsInterface();
659 ASSERT_NE(nullptr, iface);
660
661 const auto& methods = iface->GetMethods();
662 ASSERT_EQ(1u, methods.size());
663 const auto& method = methods[0];
664 const AidlTypeSpecifier& ret_type = method->GetType();
665
666 // TODO(b/151102494): these annotations should be on the method
667 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
668 ASSERT_TRUE(ret_type.IsHide());
669}
670
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100672 string foo_interface =
673 "package a; /* foo */ interface IFoo {"
674 " /* i */ int i();"
675 " /* j */ @nullable String j();"
676 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
677
Devin Moore7b8d5c92020-03-17 14:14:08 -0700678 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100679 EXPECT_NE(nullptr, parse_result);
680 EXPECT_EQ("/* foo */", parse_result->GetComments());
681
682 const AidlInterface* interface = parse_result->AsInterface();
683 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
684 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
685 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
686}
687
Jooyung Han1a551d32020-10-05 15:37:26 +0900688TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
689 io_delegate_.SetFileContents("p/cpp_header.aidl",
690 R"(package p;
691 parcelable cpp_header cpp_header "bar/header";)");
692 import_paths_.emplace("");
693 const string input_path = "p/IFoo.aidl";
694 const string input = R"(package p;
695 import p.cpp_header;
696 interface IFoo {
697 // get bar
698 cpp_header get();
699 })";
700
701 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
702 EXPECT_NE(nullptr, parse_result);
703 const AidlInterface* interface = parse_result->AsInterface();
704 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
705}
706
Christopher Wileyef140932015-11-03 09:29:19 -0800707TEST_F(AidlTest, ParsesPreprocessedFile) {
708 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
709 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700710 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900711 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700712 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
713 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800714}
715
716TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
717 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
718 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900719
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700720 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900721 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700722 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
723 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800724}
725
Devin Moore7b8d5c92020-03-17 14:14:08 -0700726TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800727 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
728 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
729 "interface IBar {}");
730 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900731 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900732 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700733 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800734 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900735
Christopher Wiley41544372015-11-03 14:52:29 -0800736 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700737 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
738 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800739 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700740 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900741 ambiguous_type.Resolve(typenames_);
742 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800743}
744
Jiyong Park8f6ec462020-01-19 20:52:47 +0900745// Special case of PreferImportToPreprocessed. Imported type should be preferred
746// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700747TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900748 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
749 io_delegate_.SetFileContents("one/IBar.aidl",
750 "package one; "
751 "interface IBar {}");
752 preprocessed_files_.push_back("preprocessed");
753 import_paths_.emplace("");
754 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700755 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900756 EXPECT_NE(nullptr, parse_result);
757
758 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700759 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
760 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900761 // But if we request just "IBar" we should get our imported one.
762 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
763 ambiguous_type.Resolve(typenames_);
764 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
765}
766
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800767TEST_F(AidlTest, WritePreprocessedFile) {
768 io_delegate_.SetFileContents("p/Outer.aidl",
769 "package p; parcelable Outer.Inner;");
770 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
771 "interface IBar {}");
772
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900773 vector<string> args {
774 "aidl",
775 "--preprocess",
776 "preprocessed",
777 "p/Outer.aidl",
778 "one/IBar.aidl"};
779 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800780 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
781
782 string output;
783 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
784 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
785}
786
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900787TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100788 io_delegate_.SetFileContents(
789 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800790 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100791 "parcelable Rect {\n"
792 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800793 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100794 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800795 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100796 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100797 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
798 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100799 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900800 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900801 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100802 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900803
804 vector<string> args{"aidl", "Rect.aidl"};
805 Options options = Options::From(args);
806 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
807
808 string output;
809 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900810 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900811}
812
Devin Moore2f2077a2020-08-28 11:27:53 -0700813TEST_F(AidlTest, CppHeaderIncludes) {
814 io_delegate_.SetFileContents("IFoo.aidl",
815 "interface IFoo {\n"
816 " @nullable List<String> foo();\n"
817 "}");
818
819 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
820 Options options = Options::From(args);
821 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
822 std::vector<std::string> empty;
823 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
824 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
825 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
826
827 // Make sure the optional and String16.h includes are added
828 string output;
829 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
830 EXPECT_EQ(kExpectedCppHeaderOutput, output);
831}
832
Devin Moore7b8d5c92020-03-17 14:14:08 -0700833TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700834 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800835 io_delegate_.SetFileContents("p/Outer.aidl",
836 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900837 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700838 CaptureStderr();
839 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
840 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700841 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700842 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800843}
844
Devin Moore7b8d5c92020-03-17 14:14:08 -0700845TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800846 io_delegate_.SetFileContents("preprocessed",
847 "parcelable p.Outer.Inner;");
848 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900849 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700850 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800851 // TODO(wiley): This should actually return nullptr because we require
852 // the outer class name. However, for legacy reasons,
853 // this behavior must be maintained. b/17415692
854 EXPECT_NE(nullptr, parse_result);
855}
856
Christopher Wiley632801d2015-11-05 14:15:49 -0800857TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700858 const string expected_foo_stderr =
859 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
860 "Declared parcelables should be in their own file and/or cannot be used with --structured "
861 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700862 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
863
Christopher Wiley632801d2015-11-05 14:15:49 -0800864 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700865 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700866 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900867 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700868 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900869
Steven Morelande2c64b42018-09-18 15:06:37 -0700870 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900871 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700872 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900873 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700874 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700875
Devin Moore097a3ab2020-03-11 16:08:44 -0700876 const string expected_bar_stderr =
877 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
878 "Declared parcelables should be in their own file and/or cannot be used with --structured "
879 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700880 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
881
Jiyong Parkda8c6932019-08-12 19:56:08 +0900882 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700883 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700884 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900885 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700886 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700887 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700888 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700889 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700890 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800891}
892
Devin Moore7b8d5c92020-03-17 14:14:08 -0700893TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700894 const string expected_stderr =
895 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
896 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700897 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
898 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700899 AidlError error;
900 CaptureStderr();
901 EXPECT_EQ(
902 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700903 Parse("p/IFoo.aidl",
904 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700905 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700906 EXPECT_EQ(expected_stderr, GetCapturedStderr());
907 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700908}
909
Devin Moore7b8d5c92020-03-17 14:14:08 -0700910TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700911 AidlError error;
912 const string expected_stderr =
913 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
914 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900915 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
916 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700917 interface IFoo {
918 const String DUPLICATED = "d";
919 const int DUPLICATED = 1;
920 }
921 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700922 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700923 EXPECT_EQ(expected_stderr, GetCapturedStderr());
924 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700925}
926
Devin Moore7b8d5c92020-03-17 14:14:08 -0700927TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700928 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700929 const string expected_stderr =
930 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700931 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700932 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
933 R"(package p;
934 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700935 parcelable IBar {}
936 parcelable StructuredParcelable {}
937 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900938 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700939 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700941 // Parse success is important for clear error handling even if the cases aren't
942 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700943 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700944}
945
Devin Moore7b8d5c92020-03-17 14:14:08 -0700946TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700947 AidlError error;
948 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
949 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700950 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700951 EXPECT_EQ(expected_stderr, GetCapturedStderr());
952 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700953}
954
Steven Morelandf9e922f2020-07-08 21:15:27 +0000955TEST_P(AidlTest, FailOnEmptyListWithComma) {
956 AidlError error;
957 const string expected_stderr =
958 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
959 CaptureStderr();
960 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
961 typenames_, GetLanguage(), &error));
962 EXPECT_EQ(expected_stderr, GetCapturedStderr());
963 EXPECT_EQ(AidlError::PARSE_ERROR, error);
964}
965
Devin Moore7b8d5c92020-03-17 14:14:08 -0700966TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700967 AidlError error;
968 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -0700969 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700970 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900971 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
972 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700973 interface IFoo {
974 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
975 }
976 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700977 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700978 EXPECT_EQ(expected_stderr, GetCapturedStderr());
979 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -0700980}
981
Jiyong Park18132182020-06-08 20:24:40 +0900982TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
983 AidlError error;
984 const string expected_stderr =
985 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
986 "cpp_header (which can also be used as an identifier)\n";
987 CaptureStderr();
988 // Notice the trailing dot(.) in the name, which isn't a correct name
989 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
990 GetLanguage(), &error));
991 EXPECT_EQ(expected_stderr, GetCapturedStderr());
992 EXPECT_EQ(AidlError::PARSE_ERROR, error);
993}
994
995TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
996 AidlError error;
997 const string expected_stderr =
998 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
999 "cpp_header (which can also be used as an identifier)\n";
1000 CaptureStderr();
1001 // Notice the trailing dot(.) in the package name
1002 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1003 GetLanguage(), &error));
1004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1005 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1006}
1007
Devin Moore7b8d5c92020-03-17 14:14:08 -07001008TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001009 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001010 auto parse_result = Parse("p/IFoo.aidl",
1011 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001012 interface IFoo {
1013 const int POSITIVE_HEX_VALUE = 0xf5;
1014 }
1015 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001016 typenames_, GetLanguage(), &error);
1017 EXPECT_NE(nullptr, parse_result);
1018 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001019 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001020 const auto& cpp_constants = interface->GetConstantDeclarations();
1021 EXPECT_EQ((size_t)1, cpp_constants.size());
1022 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001023 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001024 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001025}
1026
Devin Moore7b8d5c92020-03-17 14:14:08 -07001027TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001028 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001029 auto parse_result = Parse("p/IFoo.aidl",
1030 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001031 interface IFoo {
1032 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1033 }
1034 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001035 typenames_, GetLanguage(), &error);
1036 ASSERT_NE(nullptr, parse_result);
1037 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001038 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001039 const auto& cpp_constants = interface->GetConstantDeclarations();
1040 EXPECT_EQ((size_t)1, cpp_constants.size());
1041 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001042 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001043 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001044}
1045
Devin Moore7b8d5c92020-03-17 14:14:08 -07001046TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001047 io_delegate_.SetFileContents(
1048 "p/Outer.aidl",
1049 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001050 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001051 const string input_path = "p/IFoo.aidl";
1052 const string input = "package p; import p.Outer; interface IFoo"
1053 " { Outer.Inner get(); }";
1054
Devin Moore7b8d5c92020-03-17 14:14:08 -07001055 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1056 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001057
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001058 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001059 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001060 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1061 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001062}
1063
Devin Moore7b8d5c92020-03-17 14:14:08 -07001064TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001065 io_delegate_.SetFileContents(
1066 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001067 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001068 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001069 const string input_path = "p/IFoo.aidl";
1070 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001071 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1072 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001073 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001074 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1075 native_type.Resolve(typenames_);
1076
1077 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1078 // C++ understands C++ specific stuff
1079 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1080 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001081 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001082 EXPECT_EQ(1u, headers.size());
1083 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001084}
1085
Christopher Wileyf8136192016-04-12 14:19:35 -07001086TEST_F(AidlTest, WritesCorrectDependencyFile) {
1087 // While the in tree build system always gives us an output file name,
1088 // other android tools take advantage of our ability to infer the intended
1089 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001090 vector<string> args = {
1091 "aidl",
1092 "-d dep/file/path",
1093 "-o place/for/output",
1094 "p/IFoo.aidl"};
1095 Options options = Options::From(args);
1096 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001097 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001098 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001099 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001100 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1101}
1102
Dan Willemsen93298ee2016-11-10 23:55:55 -08001103TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1104 // While the in tree build system always gives us an output file name,
1105 // other android tools take advantage of our ability to infer the intended
1106 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001107 vector<string> args = {
1108 "aidl",
1109 "-d dep/file/path",
1110 "--ninja",
1111 "-o place/for/output",
1112 "p/IFoo.aidl"};
1113 Options options = Options::From(args);
1114 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001115 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001116 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001117 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001118 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1119}
1120
Jiyong Parkdf202122019-09-30 20:48:35 +09001121TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001122 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1123 // this by calling aidl with every .aidl file it finds, then parsing the
1124 // generated dependency files. Those that reference .java output files are
1125 // for interfaces and those that do not are parcelables. However, for both
1126 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001127 vector<string> args = {
1128 "aidl",
1129 "-o place/for/output",
1130 "-d dep/file/path",
1131 "p/Foo.aidl"};
1132 Options options = Options::From(args);
1133 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001134 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001135 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001136 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001137 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1138}
1139
1140TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1141 vector<string> args = {
1142 "aidl",
1143 "--structured",
1144 "-o place/for/output",
1145 "-d dep/file/path",
1146 "p/Foo.aidl"};
1147 Options options = Options::From(args);
1148 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1149 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1150 string actual_dep_file_contents;
1151 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1152 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001153}
1154
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001155TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1156 vector<string> args = {
1157 "aidl",
1158 "--lang=java",
1159 "-o place/for/output",
1160 "p/Foo.aidl"};
1161 Options options = Options::From(args);
1162 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1163 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1164 string output_file_contents;
1165 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1166}
1167
Jeongik Cha08ca2182019-11-21 14:01:13 +09001168// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001169TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001170 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001171 "package a; interface IFoo {\n"
1172 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001173 string expected_stderr;
1174 switch (GetLanguage()) {
1175 case Options::Language::CPP:
1176 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001177 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001178 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1179 "String and IBinder.\n";
1180 break;
1181 case Options::Language::JAVA:
1182 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001183 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001184 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1185 "String, IBinder, and ParcelFileDescriptor.\n";
1186 break;
1187 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001188 case Options::Language::RUST:
1189 expected_stderr =
1190 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1191 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001192 default:
1193 AIDL_FATAL(AIDL_LOCATION_HERE)
1194 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1195 }
1196 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001197 AidlTypenames tn1;
1198 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001199 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001200
1201 string primitive_parcelable =
1202 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001203 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001204 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001205 AidlTypenames tn2;
1206 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001207 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001208}
1209
Devin Moore21b26772020-08-26 16:37:56 -07001210TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001211 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001212 const string list_array_parcelable =
1213 "package a; parcelable Foo {\n"
1214 " List[] lists; }";
1215 CaptureStderr();
1216 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1217 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1218}
1219
Jiyong Parkf8d53612020-05-04 14:06:13 +09001220TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1221 AidlError error;
1222 string expected_stderr =
1223 "ERROR: a/IFoo.aidl:2.7-11: "
1224 "Encountered an untyped List or Map. The use of untyped List/Map is "
1225 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1226 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1227 if (GetLanguage() != Options::Language::JAVA) {
1228 expected_stderr =
1229 "ERROR: a/IFoo.aidl:2.1-7: "
1230 "Currently, only the Java backend supports non-generic List.\n";
1231 }
1232
1233 const string primitive_interface =
1234 "package a; interface IFoo {\n"
1235 " List foo(); }";
1236 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001237 AidlTypenames tn1;
1238 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001239 {"--structured"}));
1240 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001241
1242 string primitive_parcelable =
1243 "package a; parcelable IFoo {\n"
1244 " List foo;}";
1245 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001246 AidlTypenames tn2;
1247 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001248 {"--structured"}));
1249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1250}
1251
Jeongik Cha225519b2020-08-29 01:55:32 +09001252TEST_P(AidlTest, ExtensionTest) {
1253 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001254 string extendable_parcelable =
1255 "package a; parcelable Data {\n"
1256 " ParcelableHolder extension;\n"
1257 " ParcelableHolder extension2;\n"
1258 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001259 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001260 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1261 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001262 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001263 "yet.\n",
1264 GetCapturedStderr());
1265 } else {
1266 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1267 EXPECT_EQ("", GetCapturedStderr());
1268 }
1269}
1270TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1271 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001272 string parcelableholder_return_interface =
1273 "package a; interface IFoo {\n"
1274 " ParcelableHolder foo();\n"
1275 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001276 EXPECT_EQ(nullptr,
1277 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001278
Jeongik Cha8f02a532020-10-14 00:16:28 +09001279 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001280 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001281 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001282 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001283 "yet.\n",
1284 GetCapturedStderr());
1285 return;
1286 }
1287 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1288 GetCapturedStderr());
1289}
1290
1291TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1292 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001293 string extendable_parcelable_arg_interface =
1294 "package a; interface IFoo {\n"
1295 " void foo(in ParcelableHolder ph);\n"
1296 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001297 EXPECT_EQ(nullptr,
1298 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1299
Jeongik Cha8f02a532020-10-14 00:16:28 +09001300 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001301 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001302 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001303 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001304 "yet.\n",
1305 GetCapturedStderr());
1306 return;
1307 }
1308 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1309 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001310}
1311
Jiyong Park02da7422018-07-16 16:00:26 +09001312TEST_F(AidlTest, ApiDump) {
1313 io_delegate_.SetFileContents(
1314 "foo/bar/IFoo.aidl",
1315 "package foo.bar;\n"
1316 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001317 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001318 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001319 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001320 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1321 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1322 " IFoo foo3(IFoo foo);\n"
1323 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001324 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001325 " const int A = 1;\n"
1326 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001327 "}\n");
1328 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1329 "package foo.bar;\n"
1330 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001331 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001332 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001333 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001334 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001335 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001336 " int y;\n"
1337 " IFoo foo;\n"
1338 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001339 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001340 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001341 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001342 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001343 "}\n");
1344 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001345 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1346 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001347 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001348 bool result = dump_api(options, io_delegate_);
1349 ASSERT_TRUE(result);
1350 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001351 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001352 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001353/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001354interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001355 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001356 int foo(out int[] a, String b, boolean c, inout List<String> d);
1357 int foo2(@utf8InCpp String x, inout List<String> y);
1358 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1359 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001360 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001361 const int A = 1;
1362 const String STR = "Hello";
1363}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001364)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001365
Jiyong Parke59c3682018-09-11 23:10:25 +09001366 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001367 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001368/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001369parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001370 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001371 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001372 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001373 int y;
1374 foo.bar.IFoo foo;
1375 List<foo.bar.IFoo> a;
1376 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001377 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001378 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001379}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001380)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001381}
1382
Jiyong Parked65bf42018-08-28 15:43:27 +09001383TEST_F(AidlTest, ApiDumpWithManualIds) {
1384 io_delegate_.SetFileContents(
1385 "foo/bar/IFoo.aidl",
1386 "package foo.bar;\n"
1387 "interface IFoo {\n"
1388 " int foo() = 1;\n"
1389 " int bar() = 2;\n"
1390 " int baz() = 10;\n"
1391 "}\n");
1392
Jiyong Parke59c3682018-09-11 23:10:25 +09001393 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001394 Options options = Options::From(args);
1395 bool result = dump_api(options, io_delegate_);
1396 ASSERT_TRUE(result);
1397 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001398 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001399 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001400interface IFoo {
1401 int foo() = 1;
1402 int bar() = 2;
1403 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001404}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001405)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001406}
1407
1408TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001409 const string expected_stderr =
1410 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1411 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001412 io_delegate_.SetFileContents(
1413 "foo/bar/IFoo.aidl",
1414 "package foo.bar;\n"
1415 "interface IFoo {\n"
1416 " int foo() = 1;\n"
1417 " int bar();\n"
1418 " int baz() = 10;\n"
1419 "}\n");
1420
Jiyong Parke59c3682018-09-11 23:10:25 +09001421 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001422 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001423 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001424 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001425 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001426}
1427
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001428TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001429 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001430 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1431 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001432 const string expected_map_stderr =
1433 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001434 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1435 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001436 "package p; interface IFoo {"
1437 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001438 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001439 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001440 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001441
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001442 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001443 "package p; interface IFoo {"
1444 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001445 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001446 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001447 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001448}
1449
Jeongik Chae48d9942020-01-02 17:39:00 +09001450TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001451 const string expected_stderr =
1452 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001453 Options options = Options::From("aidl -I p p/IFoo.aidl");
1454 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1455
1456 io_delegate_.SetFileContents("p/IFoo.aidl",
1457 "package p; interface IFoo {"
1458 "Map<String, Bar> foo();}");
1459 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1460
1461 io_delegate_.SetFileContents("p/IFoo.aidl",
1462 "package p; interface IFoo {"
1463 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001464 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001465 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001467
1468 io_delegate_.SetFileContents("p/IFoo.aidl",
1469 "package p; interface IFoo {"
1470 "Map<String, String> foo();}");
1471 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1472
1473 io_delegate_.SetFileContents("p/IFoo.aidl",
1474 "package p; interface IFoo {"
1475 "Map<String, ParcelFileDescriptor> foo();}");
1476 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1477}
1478
Jeongik Chadf76dc72019-11-28 00:08:47 +09001479TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001480 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001481 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1482 io_delegate_.SetFileContents(options.InputFiles().front(),
1483 "package p; interface IFoo {"
1484 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001485 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001486 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001487 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001488}
1489
1490TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1491 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1492 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001493 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001494 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001495 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1496 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001497
1498 Options options = Options::From("aidl -I p p/IFoo.aidl");
1499 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1500 io_delegate_.SetFileContents("p/IFoo.aidl",
1501 "package p; interface IFoo {"
1502 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001503 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001504 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001505 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001506 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001507 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001508 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001509 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1510 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001511 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1512 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1513 io_delegate_.SetFileContents("p/IFoo.aidl",
1514 "package p; interface IFoo {"
1515 "Bar<String, ParcelFileDescriptor> foo();}");
1516 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001517
1518 io_delegate_.SetFileContents("p/IFoo.aidl",
1519 "package p; interface IFoo {"
1520 "Bar<int, long> foo();}");
1521
1522 io_delegate_.SetFileContents("p/IFoo.aidl",
1523 "package p; interface IFoo {"
1524 "Bar<int[], long[]> foo();}");
1525
1526 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001527}
1528
Jeongik Cha0e426012019-07-29 15:57:02 +09001529TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1530 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001531 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1532 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001533 for (const auto& rawOption : rawOptions) {
1534 string expected_stderr =
1535 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001536 Options options = Options::From(rawOption);
1537 io_delegate_.SetFileContents(options.InputFiles().front(),
1538 "package foo.bar;\n"
1539 "interface IFoo1 { int foo(); }\n"
1540 "interface IFoo2 { int foo(); }\n"
1541 "parcelable Data1 { int a; int b;}\n"
1542 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001543 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001544 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001545 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001546
Jeongik Cha0e426012019-07-29 15:57:02 +09001547 io_delegate_.SetFileContents(options.InputFiles().front(),
1548 "package foo.bar;\n"
1549 "interface IFoo1 { int foo(); }\n"
1550 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001551 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001552 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001553 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001554
Devin Moore5de18ed2020-04-02 13:52:29 -07001555 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001556 io_delegate_.SetFileContents(options.InputFiles().front(),
1557 "package foo.bar;\n"
1558 "parcelable Data1 { int a; int b;}\n"
1559 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001560 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001561 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001562 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001563 }
1564}
1565
Devin Moorebdba2a82020-03-31 15:19:02 -07001566TEST_P(AidlTest, FailParseOnEmptyFile) {
1567 const string contents = "";
1568 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1569 CaptureStderr();
1570 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1571 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1572}
1573
Jiyong Parkb034bf02018-07-30 17:44:33 +09001574TEST_F(AidlTest, MultipleInputFiles) {
1575 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001576 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001577
1578 io_delegate_.SetFileContents(options.InputFiles().at(0),
1579 "package foo.bar;\n"
1580 "import foo.bar.Data;\n"
1581 "interface IFoo { Data getData(); }\n");
1582
1583 io_delegate_.SetFileContents(options.InputFiles().at(1),
1584 "package foo.bar;\n"
1585 "import foo.bar.IFoo;\n"
1586 "parcelable Data { IFoo foo; }\n");
1587
1588 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1589
1590 string content;
1591 for (const auto file : {
1592 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1593 content.clear();
1594 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1595 EXPECT_FALSE(content.empty());
1596 }
1597}
1598
1599TEST_F(AidlTest, MultipleInputFilesCpp) {
1600 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001601 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001602
1603 io_delegate_.SetFileContents(options.InputFiles().at(0),
1604 "package foo.bar;\n"
1605 "import foo.bar.Data;\n"
1606 "interface IFoo { Data getData(); }\n");
1607
1608 io_delegate_.SetFileContents(options.InputFiles().at(1),
1609 "package foo.bar;\n"
1610 "import foo.bar.IFoo;\n"
1611 "parcelable Data { IFoo foo; }\n");
1612
1613 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1614
1615 string content;
1616 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001617 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001618 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1619 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1620 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1621 content.clear();
1622 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1623 EXPECT_FALSE(content.empty());
1624 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001625}
1626
Andrei Homescub62afd92020-05-11 19:24:59 -07001627TEST_F(AidlTest, MultipleInputFilesRust) {
1628 Options options =
1629 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1630
1631 io_delegate_.SetFileContents(options.InputFiles().at(0),
1632 "package foo.bar;\n"
1633 "import foo.bar.Data;\n"
1634 "interface IFoo { Data getData(); }\n");
1635
1636 io_delegate_.SetFileContents(options.InputFiles().at(1),
1637 "package foo.bar;\n"
1638 "import foo.bar.IFoo;\n"
1639 "parcelable Data { IFoo foo; }\n");
1640
1641 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1642
1643 string content;
1644 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1645 content.clear();
1646 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1647 EXPECT_FALSE(content.empty());
1648 }
1649}
1650
Devin Moore097a3ab2020-03-11 16:08:44 -07001651TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1652 const string expected_stderr =
1653 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001654 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1655 // int getInterfaceVersion() is one of the meta transactions
1656 io_delegate_.SetFileContents(options.InputFiles().front(),
1657 "package p; interface IFoo {"
1658 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001659 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001660 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001661 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1662}
Jiyong Park309668e2018-07-28 16:55:44 +09001663
Devin Moore097a3ab2020-03-11 16:08:44 -07001664TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1665 // boolean getInterfaceVersion() is not a meta transaction, but should be
1666 // prevented because return type is not part of a method signature
1667 const string expected_stderr =
1668 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1669 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001670 io_delegate_.SetFileContents(options.InputFiles().front(),
1671 "package p; interface IFoo {"
1672 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001673 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001674 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001675 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1676}
Jiyong Park309668e2018-07-28 16:55:44 +09001677
Devin Moore097a3ab2020-03-11 16:08:44 -07001678TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001679 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001680 const string expected_stderr =
1681 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1682 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001683 io_delegate_.SetFileContents(options.InputFiles().front(),
1684 "package p; interface IFoo {"
1685 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001686 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001687 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001688 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001689
1690 // this is not a meta interface method as it differs type arguments
1691 io_delegate_.SetFileContents(options.InputFiles().front(),
1692 "package p; interface IFoo {"
1693 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001694 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001695}
1696
Daniel Norman85aed542019-08-21 12:01:14 -07001697TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001698 Options options = Options::From("aidl --checkapi old new");
1699 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1700 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1701 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1702 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1703
1704 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1705}
1706
Jiyong Park3656c3c2018-08-01 20:02:01 +09001707TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001708 Options options = Options::From("aidl --checkapi old new");
1709 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1710 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001711
1712 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1713}
1714
Daniel Norman85aed542019-08-21 12:01:14 -07001715class AidlTestCompatibleChanges : public AidlTest {
1716 protected:
1717 Options options_ = Options::From("aidl --checkapi old new");
1718};
1719
1720TEST_F(AidlTestCompatibleChanges, NewType) {
1721 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1722 "package p;"
1723 "interface IFoo {"
1724 " void foo(int a);"
1725 "}");
1726 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1727 "package p;"
1728 "interface IFoo {"
1729 " void foo(int a);"
1730 "}");
1731 io_delegate_.SetFileContents("new/p/IBar.aidl",
1732 "package p;"
1733 "interface IBar {"
1734 " void bar();"
1735 "}");
1736 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1737}
1738
1739TEST_F(AidlTestCompatibleChanges, NewMethod) {
1740 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1741 "package p;"
1742 "interface IFoo {"
1743 " void foo(int a);"
1744 "}");
1745 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1746 "package p;"
1747 "interface IFoo {"
1748 " void foo(int a);"
1749 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001750 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001751 "}");
1752 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1753}
1754
1755TEST_F(AidlTestCompatibleChanges, NewField) {
1756 io_delegate_.SetFileContents("old/p/Data.aidl",
1757 "package p;"
1758 "parcelable Data {"
1759 " int foo;"
1760 "}");
1761 io_delegate_.SetFileContents("new/p/Data.aidl",
1762 "package p;"
1763 "parcelable Data {"
1764 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001765 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001766 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001767 "}");
1768 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1769}
1770
1771TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1772 io_delegate_.SetFileContents("old/p/Enum.aidl",
1773 "package p;"
1774 "enum Enum {"
1775 " FOO = 1,"
1776 "}");
1777 io_delegate_.SetFileContents("new/p/Enum.aidl",
1778 "package p;"
1779 "enum Enum {"
1780 " FOO = 1,"
1781 " BAR = 2,"
1782 "}");
1783 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1784}
1785
1786TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1787 io_delegate_.SetFileContents("old/p/Enum.aidl",
1788 "package p;"
1789 "enum Enum {"
1790 " FOO = 1,"
1791 " BAR = 2,"
1792 "}");
1793 io_delegate_.SetFileContents("new/p/Enum.aidl",
1794 "package p;"
1795 "enum Enum {"
1796 " BAR = 2,"
1797 " FOO = 1,"
1798 "}");
1799 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1800}
1801
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001802TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1803 io_delegate_.SetFileContents("old/p/Union.aidl",
1804 "package p;"
1805 "union Union {"
1806 " String foo;"
1807 "}");
1808 io_delegate_.SetFileContents("new/p/Union.aidl",
1809 "package p;"
1810 "union Union {"
1811 " String foo;"
1812 " int num;"
1813 "}");
1814 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1815}
1816
Daniel Norman85aed542019-08-21 12:01:14 -07001817TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001818 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1819 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001820 "interface IFoo {"
1821 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001822 "}");
1823 io_delegate_.SetFileContents("old/p/Data.aidl",
1824 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001825 "parcelable Data {"
1826 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001827 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001828 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1829 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001830 "interface IFoo {"
1831 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001832 "}");
1833 io_delegate_.SetFileContents("new/p/Data.aidl",
1834 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001835 "parcelable Data {"
1836 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001837 "}");
1838 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1839 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001840 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001841 " void foo(int a);"
1842 "}");
1843 io_delegate_.SetFileContents("new/q/Data.aidl",
1844 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001845 "parcelable Data {"
1846 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001847 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001848 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1849}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001850
Daniel Norman85aed542019-08-21 12:01:14 -07001851TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1852 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1853 "package p;"
1854 "interface IFoo {"
1855 " void foo(int a);"
1856 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001857 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1858 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001859 "interface IFoo {"
1860 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001861 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001862 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1863}
Jiyong Parke59c3682018-09-11 23:10:25 +09001864
Daniel Norman85aed542019-08-21 12:01:14 -07001865TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001866 io_delegate_.SetFileContents("old/p/I.aidl",
1867 "package p; interface I {"
1868 "const int A = 1; }");
1869 io_delegate_.SetFileContents("new/p/I.aidl",
1870 "package p ; interface I {"
1871 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001872 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1873}
Jiyong Parka428d212018-08-29 22:26:30 +09001874
Daniel Norman85aed542019-08-21 12:01:14 -07001875TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001876 io_delegate_.SetFileContents("old/p/I.aidl",
1877 "package p; interface I {"
1878 "const int A = 1; const int B = 2;}");
1879 io_delegate_.SetFileContents("new/p/I.aidl",
1880 "package p ; interface I {"
1881 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001882 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001883}
1884
Jooyung Han636fd2f2020-10-22 11:33:45 +09001885TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
1886 io_delegate_.SetFileContents("old/p/Data.aidl",
1887 "package p;"
1888 "parcelable Data {"
1889 " int num;"
1890 "}");
1891 io_delegate_.SetFileContents(
1892 "new/p/Data.aidl",
1893 "package p;"
1894 "parcelable Data {"
1895 " int num;"
1896 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
1897 "}");
1898 io_delegate_.SetFileContents("new/p/Enum.aidl",
1899 "package p;"
1900 "enum Enum {"
1901 " FOO = 0,"
1902 " BAR = 1,"
1903 "}");
1904 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1905}
1906
Daniel Norman85aed542019-08-21 12:01:14 -07001907class AidlTestIncompatibleChanges : public AidlTest {
1908 protected:
1909 Options options_ = Options::From("aidl --checkapi old new");
1910};
1911
1912TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001913 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001914 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1915 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001916 "interface IFoo {"
1917 " void foo(in String[] str);"
1918 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001919 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001920 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001921 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001922 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001923}
1924
1925TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001926 const string expected_stderr =
1927 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001928 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1929 "package p;"
1930 "interface IFoo {"
1931 " void foo(in String[] str);"
1932 " void bar(@utf8InCpp String str);"
1933 "}");
1934 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1935 "package p;"
1936 "interface IFoo {"
1937 " void foo(in String[] str);"
1938 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001939 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001940 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001941 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001942}
1943
Jiyong Parkf8d53612020-05-04 14:06:13 +09001944TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1945 const string expected_stderr =
1946 "ERROR: new/p/IFoo.aidl:1.61-65: "
1947 "Encountered an untyped List or Map. The use of untyped List/Map is "
1948 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1949 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1950 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1951 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1952 "package p;"
1953 "interface IFoo {"
1954 " void foo(in String[] str);"
1955 "}");
1956 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1957 "package p;"
1958 "interface IFoo {"
1959 " void foo(in String[] str);"
1960 " void bar(in List arg);"
1961 "}");
1962 CaptureStderr();
1963 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1964 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1965}
1966
1967TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
1968 const string expected_stderr =
1969 "ERROR: new/p/Data.aidl:1.54-59: "
1970 "Encountered an untyped List or Map. The use of untyped List/Map is "
1971 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1972 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1973 "ERROR: new/p/Data.aidl: Failed to read.\n";
1974 io_delegate_.SetFileContents("old/p/Data.aidl",
1975 "package p;"
1976 "parcelable Data {"
1977 " int foo;"
1978 "}");
1979 io_delegate_.SetFileContents("new/p/Data.aidl",
1980 "package p;"
1981 "parcelable Data {"
1982 " int foo;"
1983 " @nullable List list;"
1984 "}");
1985 CaptureStderr();
1986 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1987 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1988}
1989
Daniel Norman85aed542019-08-21 12:01:14 -07001990TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001991 const string expected_stderr =
1992 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001993 io_delegate_.SetFileContents("old/p/Data.aidl",
1994 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001995 "parcelable Data {"
1996 " int foo;"
1997 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001998 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001999 io_delegate_.SetFileContents("new/p/Data.aidl",
2000 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002001 "parcelable Data {"
2002 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002003 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002004 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002005 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002006 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002007}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002008
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002009TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2010 const string expected_stderr =
2011 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2012 "backends. Please either provide a default value for this field or mark the field as "
2013 "@nullable. This value or a null value will be used automatically when an old version of "
2014 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2015 "order to make sure your code continues to be backwards compatible, make sure the default or "
2016 "null value does not cause a semantic change to this parcelable.\n";
2017 io_delegate_.SetFileContents("old/p/Data.aidl",
2018 "package p;"
2019 "parcelable Data {"
2020 " int num;"
2021 "}");
2022 io_delegate_.SetFileContents("new/p/Data.aidl",
2023 "package p;"
2024 "parcelable Data {"
2025 " int num;"
2026 " String str;"
2027 "}");
2028 CaptureStderr();
2029 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2030 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2031}
2032
Jooyung Han636fd2f2020-10-22 11:33:45 +09002033TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2034 const string expected_stderr =
2035 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2036 "Please make sure 'Enum' has '0' as a valid value.\n";
2037 io_delegate_.SetFileContents("old/p/Data.aidl",
2038 "package p;"
2039 "parcelable Data {"
2040 " int num;"
2041 "}");
2042 io_delegate_.SetFileContents("new/p/Data.aidl",
2043 "package p;"
2044 "parcelable Data {"
2045 " int num;"
2046 " p.Enum e;"
2047 "}");
2048 io_delegate_.SetFileContents("new/p/Enum.aidl",
2049 "package p;"
2050 "enum Enum {"
2051 " FOO = 1,"
2052 " BAR = 2,"
2053 "}");
2054 CaptureStderr();
2055 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2056 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2057}
2058
Daniel Norman85aed542019-08-21 12:01:14 -07002059TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002060 const string expected_stderr =
2061 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002062 io_delegate_.SetFileContents("old/p/Enum.aidl",
2063 "package p;"
2064 "enum Enum {"
2065 " FOO = 1,"
2066 " BAR = 2,"
2067 "}");
2068 io_delegate_.SetFileContents("new/p/Enum.aidl",
2069 "package p;"
2070 "enum Enum {"
2071 " BAR = 2,"
2072 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002073 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002074 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002075 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002076}
2077
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002078TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2079 const string expected_stderr =
2080 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2081 io_delegate_.SetFileContents("old/p/Union.aidl",
2082 "package p;"
2083 "union Union {"
2084 " String str;"
2085 " int num;"
2086 "}");
2087 io_delegate_.SetFileContents("new/p/Union.aidl",
2088 "package p;"
2089 "union Union {"
2090 " String str;"
2091 "}");
2092 CaptureStderr();
2093 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2094 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2095}
2096
Daniel Norman85aed542019-08-21 12:01:14 -07002097TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002098 const string expected_stderr =
2099 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002100 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2101 "package p;"
2102 "interface IFoo {"
2103 " void foo(in String[] str);"
2104 " void bar(@utf8InCpp String str);"
2105 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002106 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2107 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002108 "interface IFoo {"
2109 " void foo(in String[] str);"
2110 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002111 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002112 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002113 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002114 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002115}
2116
Daniel Norman85aed542019-08-21 12:01:14 -07002117TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002118 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002119 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2120 "package p;"
2121 "interface IFoo {"
2122 " void foo(in String[] str);"
2123 " void bar(@utf8InCpp String str);"
2124 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002125 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2126 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002127 "interface IFoo2 {"
2128 " void foo(in String[] str);"
2129 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002130 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002131 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002132 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002133 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002134}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002135
Daniel Norman85aed542019-08-21 12:01:14 -07002136TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002137 const string expected_stderr =
2138 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002139 io_delegate_.SetFileContents("old/p/Enum.aidl",
2140 "package p;"
2141 "enum Enum {"
2142 " FOO = 1,"
2143 " BAR = 2,"
2144 "}");
2145 io_delegate_.SetFileContents("new/p/Enum.aidl",
2146 "package p;"
2147 "enum Enum {"
2148 " FOO = 3,"
2149 " BAR = 2,"
2150 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002151 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002152 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002153 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002154}
2155
2156TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002157 const string expected_stderr =
2158 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2159 "from 0 to 1.\n"
2160 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2161 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002162 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2163 "package p;"
2164 "interface IFoo {"
2165 " void foo(in String[] str);"
2166 " void bar(@utf8InCpp String str);"
2167 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002168 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2169 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002170 "interface IFoo {"
2171 " void bar(@utf8InCpp String str);"
2172 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002173 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002174 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002175 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002176 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002177}
2178
2179TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002180 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002181 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2182 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002183 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002184 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002185 "parcelable Data {"
2186 " int foo;"
2187 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002188 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002189 io_delegate_.SetFileContents("new/p/Data.aidl",
2190 "package p;"
2191 "parcelable Data {"
2192 " int bar;"
2193 " int foo;"
2194 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002195 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002196 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002197 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002198}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002199
Daniel Norman85aed542019-08-21 12:01:14 -07002200TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002201 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002202 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002203 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002204 "interface IFoo {"
2205 " void foo(in String[] str);"
2206 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002207 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002208 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2209 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002210 "interface IFoo {"
2211 " void foo(out String[] str);"
2212 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002213 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002214 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002215 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002216 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002217}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002218
Daniel Norman85aed542019-08-21 12:01:14 -07002219TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002220 const string expected_stderr =
2221 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002222 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2223 "package p;"
2224 "interface IFoo {"
2225 " void foo(in String[] str);"
2226 " void bar(@utf8InCpp String str);"
2227 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002228 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2229 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002230 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002231 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002232 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002233 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002234 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002235 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002236 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002237}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002238
Daniel Norman85aed542019-08-21 12:01:14 -07002239TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002240 const string expected_stderr =
2241 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002242 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2243 "package p;"
2244 "interface IFoo {"
2245 " void foo(in String[] str);"
2246 " void bar(@utf8InCpp String str);"
2247 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002248 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2249 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002250 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002251 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002252 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002253 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002254 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002255 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002257}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002258
Devin Mooredb7ac512020-08-07 11:17:36 -07002259TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2260 const string expected_stderr =
2261 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2262 io_delegate_.SetFileContents("old/p/Foo.aidl",
2263 "package p;"
2264 "parcelable Foo {"
2265 " int A;"
2266 "}");
2267 io_delegate_.SetFileContents("new/p/Foo.aidl",
2268 "package p;"
2269 "@JavaOnlyStableParcelable parcelable Foo {"
2270 " int A;"
2271 "}");
2272 CaptureStderr();
2273 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2274 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2275}
2276
2277TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2278 const string expected_stderr =
2279 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2280 io_delegate_.SetFileContents("old/p/Foo.aidl",
2281 "package p;"
2282 "@JavaOnlyStableParcelable parcelable Foo {"
2283 " int A;"
2284 "}");
2285 io_delegate_.SetFileContents("new/p/Foo.aidl",
2286 "package p;"
2287 "parcelable Foo {"
2288 " int A;"
2289 "}");
2290 CaptureStderr();
2291 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2292 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2293}
2294
Daniel Norman85aed542019-08-21 12:01:14 -07002295TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002296 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002297 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2298 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002299 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002300 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002301 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002302 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002303}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002304
Daniel Norman85aed542019-08-21 12:01:14 -07002305TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002306 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002307 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2308 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002309 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002310 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002311 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002312}
Jiyong Parka428d212018-08-29 22:26:30 +09002313
Daniel Norman85aed542019-08-21 12:01:14 -07002314TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002315 const string expected_stderr =
2316 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002317 io_delegate_.SetFileContents("old/p/I.aidl",
2318 "package p; interface I {"
2319 "const int A = 1; const int B = 2;}");
2320 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002321 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002322 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002324}
Jiyong Parka428d212018-08-29 22:26:30 +09002325
Daniel Norman85aed542019-08-21 12:01:14 -07002326TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002327 const string expected_stderr =
2328 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002329 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2330 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002331 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002332 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002334}
2335
Devin Moorec7e47a32020-08-07 10:55:25 -07002336TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2337 const string expected_stderr =
2338 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2339 "This is an incompatible change for FixedSize types.\n";
2340 io_delegate_.SetFileContents("old/p/Foo.aidl",
2341 "package p; @FixedSize parcelable Foo { int A = 1; }");
2342 io_delegate_.SetFileContents("new/p/Foo.aidl",
2343 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2344 CaptureStderr();
2345 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2347}
2348
2349TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2350 const string expected_stderr =
2351 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2352 io_delegate_.SetFileContents("old/p/Foo.aidl",
2353 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2354 io_delegate_.SetFileContents("new/p/Foo.aidl",
2355 "package p; @FixedSize parcelable Foo { int A = 1; }");
2356 CaptureStderr();
2357 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2358 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2359}
2360
2361TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2362 const string expected_stderr =
2363 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2364 "a.\n"
2365 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2366 "b.\n"
2367 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2368 "c.\n"
2369 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2370 "d.\n"
2371 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2372 "e.\n"
2373 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2374 "f.\n";
2375
2376 io_delegate_.SetFileContents("Foo.aidl",
2377 "@FixedSize parcelable Foo { "
2378 " int[] a;"
2379 " Bar b;"
2380 " String c;"
2381 " ParcelFileDescriptor d;"
2382 " IBinder e;"
2383 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002384 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002385 "}");
2386 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2387 Options options =
2388 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2389
2390 CaptureStderr();
2391 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2393}
2394
2395TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2396 const string expected_stderr = "";
2397
2398 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2399 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2400 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2401 Options options =
2402 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2403
2404 CaptureStderr();
2405 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2406 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2407}
2408
Jiyong Park8c380532018-08-30 14:55:26 +09002409TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002410 const string expected_stderr =
2411 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2412 "dir1/q/IBar.aidl\n"
2413 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002414 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002415 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2416 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2417 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2418 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2419
Devin Moore097a3ab2020-03-11 16:08:44 -07002420 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002421 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002422 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002423}
2424
Jiyong Parked65bf42018-08-28 15:43:27 +09002425TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002426 const string expected_stderr =
2427 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2428 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002429 Options options = Options::From("aidl --checkapi old new");
2430 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2431 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002432
2433 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2434
Jiyong Parke59c3682018-09-11 23:10:25 +09002435 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002436 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002437 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002438 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002439}
2440
Jiyong Parke05195e2018-10-08 18:24:23 +09002441TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2442 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2443 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002444 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002445
2446 // use without import
2447 io_delegate_.SetFileContents("p/IFoo.aidl",
2448 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2449 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2450 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002451 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002452
Devin Moore7b8d5c92020-03-17 14:14:08 -07002453 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002454 io_delegate_.SetFileContents(
2455 "p/IFoo.aidl",
2456 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2457 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2458 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002459 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002460
2461 // use with import (as before)
2462 io_delegate_.SetFileContents("p/IFoo.aidl",
2463 "package p;"
2464 "import android.os.ParcelFileDescriptor;"
2465 "interface IFoo{"
2466 " void foo(in ParcelFileDescriptor fd);"
2467 "}");
2468 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2469 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002470 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002471}
Jiyong Parked65bf42018-08-28 15:43:27 +09002472
Jiyong Park3633b722019-04-11 15:38:26 +09002473TEST_F(AidlTest, ManualIds) {
2474 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2475 io_delegate_.SetFileContents("IFoo.aidl",
2476 "interface IFoo {\n"
2477 " void foo() = 0;\n"
2478 " void bar() = 1;\n"
2479 "}");
2480 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2481}
2482
2483TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2484 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2485 io_delegate_.SetFileContents("IFoo.aidl",
2486 "interface IFoo {\n"
2487 " void foo() = 0;\n"
2488 " void bar() = 1;\n"
2489 "}");
2490 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2491}
2492
2493TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002494 const string expected_stderr =
2495 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002496 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2497 io_delegate_.SetFileContents("IFoo.aidl",
2498 "interface IFoo {\n"
2499 " void foo() = 3;\n"
2500 " void bar() = 3;\n"
2501 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002502 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002503 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002504 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002505}
2506
2507TEST_F(AidlTest, FailOnOutOfRangeIds) {
2508 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002509 const string expected_stderr =
2510 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2511 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002512 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2513 io_delegate_.SetFileContents("IFoo.aidl",
2514 "interface IFoo {\n"
2515 " void foo() = 3;\n"
2516 " void bar() = 16777115;\n"
2517 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002518 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002519 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002521}
2522
2523TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002524 const string expected_stderr =
2525 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002526 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2527 io_delegate_.SetFileContents("IFoo.aidl",
2528 "interface IFoo {\n"
2529 " void foo() = 3;\n"
2530 " void bar();\n"
2531 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002532 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002533 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002534 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002535}
2536
Jiyong Parkc6816252019-07-08 08:12:28 +09002537TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2538 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2539 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2540 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2541 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2542}
2543
2544TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002545 const string expected_stderr =
2546 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2547 "dir/IBar.aidl\n"
2548 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002549 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002550
Jiyong Parkc6816252019-07-08 08:12:28 +09002551 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2552 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2553 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2554 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002555 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002556 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002557 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002558}
2559
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002560TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2561 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2562 "package a.b;\n"
2563 "import a.b.IBar;\n"
2564 "import a.b.IQux;\n"
2565 "interface IFoo { IQux foo(); }\n");
2566 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2567 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2568
2569 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2570 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2571
2572 string output;
2573 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2574 // IBar was imported but wasn't used. include is not expected.
2575 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2576 // IBar was imported and used. include is expected.
2577 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2578}
2579
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002580TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002581 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002582 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002583 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2584 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002585 interface IFoo {
2586 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002587 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002588 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002589 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002590 // JavaPassthrough should work with other types as well (e.g. enum)
2591 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2592 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2593 @JavaPassthrough(annotation="@com.android.AliceTwo")
2594 @Backing(type="byte")
2595 enum MyEnum {
2596 a, b, c
2597 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002598
Jooyung Han4cde01d2020-10-13 11:10:47 +09002599 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002600 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2601
2602 string java_out;
2603 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002604 // type-decl-level annotations with newline at the end
2605 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2606 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2607 // member-decl-level annotations with newline at the end
2608 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2609 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2610 // inline annotations with space at the end
2611 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002612
Jooyung Han4cde01d2020-10-13 11:10:47 +09002613 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2614 // type-decl-level annotations with newline at the end
2615 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2616 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2617
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002618 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002619 Options cpp_options =
2620 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002621 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2622
Jooyung Han4cde01d2020-10-13 11:10:47 +09002623 Options ndk_options =
2624 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002625 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002626
Jooyung Han4cde01d2020-10-13 11:10:47 +09002627 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002628 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002629}
2630
Andrei Homescue61feb52020-08-18 15:44:24 -07002631TEST_F(AidlTest, ParseRustDerive) {
2632 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2633 @RustDerive(Clone=true, Copy=false)
2634 parcelable Foo {
2635 int a;
2636 })");
2637
2638 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2639 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2640
2641 string rust_out;
2642 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2643 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2644
2645 // Other backends shouldn't be bothered
2646 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2647 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2648
2649 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2650 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2651
2652 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2653 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2654}
2655
Jiyong Park56f73d72019-06-11 12:20:28 +09002656class AidlOutputPathTest : public AidlTest {
2657 protected:
2658 void SetUp() override {
2659 AidlTest::SetUp();
2660 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2661 }
2662
2663 void Test(const Options& options, const std::string expected_output_path) {
2664 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2665 // check the existence
2666 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2667 }
2668};
2669
2670TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2671 // <out_dir> / <package_name> / <type_name>.java
2672 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2673}
2674
2675TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2676 // when output file is explicitly set, it is always respected. -o option is
2677 // ignored.
2678 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2679}
2680
2681TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2682 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2683}
2684
2685TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2686 // output is the same as the input file except for the suffix
2687 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2688}
2689
Devin Moore7b8d5c92020-03-17 14:14:08 -07002690TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002691 AidlError error;
2692 const string expected_stderr =
2693 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2694 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002695 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2696 R"(package p;
2697 interface IFoo {
2698 const int int32_max_oob = 2147483650;
2699 }
2700 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002701 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002702 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2703 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002704}
2705
Devin Moore7b8d5c92020-03-17 14:14:08 -07002706TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002707 AidlError error;
2708 const string expected_stderr =
2709 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2710 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002711 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2712 R"(package p;
2713 interface IFoo {
2714 const int int32_min_oob = -2147483650;
2715 }
2716 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002717 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002718 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2719 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002720}
2721
Devin Moore7b8d5c92020-03-17 14:14:08 -07002722TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002723 AidlError error;
2724 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002725 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002726 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002727 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2728 R"(package p;
2729 interface IFoo {
2730 const long int64_max_oob = 21474836509999999999999999;
2731 }
2732 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002733 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002734 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2735 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002736}
2737
Devin Moore7b8d5c92020-03-17 14:14:08 -07002738TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002739 AidlError error;
2740 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002741 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002742 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002743 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2744 R"(package p;
2745 interface IFoo {
2746 const long int64_min_oob = -21474836509999999999999999;
2747 }
2748 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002749 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002750 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2751 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002752}
2753
Devin Moore7b8d5c92020-03-17 14:14:08 -07002754TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002755 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002756 const string expected_stderr =
2757 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2758 "literal: byte\n"
2759 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2760 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002761 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2762 R"(package p;
2763 @Backing(type="byte")
2764 enum TestEnum {
2765 FOO = 127,
2766 BAR,
2767 }
2768 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002769 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002770 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002771 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002772}
2773
Devin Mooredecaf292020-04-30 09:16:40 -07002774TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2775 AidlError error;
2776 const string expected_stderr =
2777 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2778 "be one of: type\n"
2779 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2780 "be one of: type\n";
2781 CaptureStderr();
2782 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2783 R"(package p;
2784 @Backing(foo="byte")
2785 enum TestEnum {
2786 FOO = 1,
2787 BAR,
2788 }
2789 )",
2790 typenames_, GetLanguage(), &error));
2791 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2792 EXPECT_EQ(AidlError::BAD_TYPE, error);
2793}
2794
Jooyung Han66813932020-10-23 13:24:44 +09002795TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002796 io_delegate_.SetFileContents("Foo.aidl",
2797 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2798 "Map<String, Baz> d; Bar[] e; }");
2799 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2800 io_delegate_.SetFileContents("Baz.aidl",
2801 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002802 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2803 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2804}
2805
Jooyung Han66813932020-10-23 13:24:44 +09002806TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002807 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002808 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09002809 string expected_error =
2810 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable parcelable 'Foo' has a non-immutable field "
2811 "named 'bar'.\n";
2812 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002813 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2814 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09002815 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002816}
2817
Jooyung Han66813932020-10-23 13:24:44 +09002818TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002819 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002820 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
2821 string expected_error =
2822 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
2823 "only be an in parameter.\n";
2824 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002825 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2826 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002827 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002828}
2829
Jooyung Han66813932020-10-23 13:24:44 +09002830TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002831 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002832 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
2833 string expected_error =
2834 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
2835 "only be an in parameter.\n";
2836 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002837 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2838 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002839 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002840}
2841
Jooyung Han66813932020-10-23 13:24:44 +09002842TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002843 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002844 Options options = Options::From("aidl --lang=java Foo.aidl");
2845 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002846 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002847 "capitalizing the first letter\n";
2848 CaptureStderr();
2849 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2850 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2851}
Devin Moore53fc99c2020-08-12 08:07:52 -07002852
Jooyung Han1f14ab32020-10-14 13:48:29 +09002853const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2854
2855#include <a/ByteEnum.h>
2856#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09002857#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002858#include <binder/Status.h>
2859#include <cstdint>
Jooyung Han3df81ae2020-10-17 17:59:59 +09002860#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002861#include <utility>
2862#include <variant>
2863#include <vector>
2864
2865namespace a {
2866
2867class Foo : public ::android::Parcelable {
2868public:
Jooyung Han97945de2020-10-15 16:41:38 +09002869 inline bool operator!=(const Foo& rhs) const {
2870 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002871 }
Jooyung Han97945de2020-10-15 16:41:38 +09002872 inline bool operator<(const Foo& rhs) const {
2873 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002874 }
Jooyung Han97945de2020-10-15 16:41:38 +09002875 inline bool operator<=(const Foo& rhs) const {
2876 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002877 }
Jooyung Han97945de2020-10-15 16:41:38 +09002878 inline bool operator==(const Foo& rhs) const {
2879 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002880 }
Jooyung Han97945de2020-10-15 16:41:38 +09002881 inline bool operator>(const Foo& rhs) const {
2882 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002883 }
Jooyung Han97945de2020-10-15 16:41:38 +09002884 inline bool operator>=(const Foo& rhs) const {
2885 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002886 }
Jooyung Han97945de2020-10-15 16:41:38 +09002887
Jooyung Han1f14ab32020-10-14 13:48:29 +09002888 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09002889 ns = 0, // int[] ns;
2890 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002891 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002892 };
Jooyung Han97945de2020-10-15 16:41:38 +09002893
Jooyung Han1f14ab32020-10-14 13:48:29 +09002894 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09002895 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002896
2897 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09002898 Foo(const Foo&) = default;
2899 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002900 Foo& operator=(const Foo&) = default;
2901 Foo& operator=(Foo&&) = default;
2902
Jooyung Han97945de2020-10-15 16:41:38 +09002903 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
2904 constexpr Foo(_Tp&& _arg)
2905 : _value(std::forward<_Tp>(_arg)) {}
2906
2907 template <typename... _Tp>
2908 constexpr explicit Foo(_Tp&&... _args)
2909 : _value(std::forward<_Tp>(_args)...) {}
2910
2911 template <Tag _tag, typename... _Tp>
2912 static Foo make(_Tp&&... _args) {
2913 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002914 }
Jooyung Han97945de2020-10-15 16:41:38 +09002915
2916 template <Tag _tag, typename _Tp, typename... _Up>
2917 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
2918 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002919 }
2920
2921 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002922 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002923 }
2924
Jooyung Han97945de2020-10-15 16:41:38 +09002925 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002926 const auto& get() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002927 if (getTag() != _tag) { abort(); }
2928 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002929 }
2930
Jooyung Han97945de2020-10-15 16:41:38 +09002931 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002932 auto& get() {
Jooyung Han97945de2020-10-15 16:41:38 +09002933 if (getTag() != _tag) { abort(); }
2934 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002935 }
2936
Jooyung Han97945de2020-10-15 16:41:38 +09002937 template <Tag _tag, typename... _Tp>
2938 void set(_Tp&&... _args) {
2939 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002940 }
2941
2942 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
2943 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
2944 static const std::string& getParcelableDescriptor() {
2945 static const std::string DESCIPTOR = "a.Foo";
2946 return DESCIPTOR;
2947 }
2948private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09002949 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002950}; // class Foo
2951
2952} // namespace a
2953)";
2954
2955const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
2956
2957namespace a {
2958
2959::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
2960 ::android::status_t _aidl_ret_status;
2961 int32_t _aidl_tag;
2962 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
2963 switch (_aidl_tag) {
2964 case ns: {
2965 ::std::vector<int32_t> _aidl_value;
2966 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2967 set<ns>(std::move(_aidl_value));
2968 return ::android::OK; }
2969 case e: {
2970 ::a::ByteEnum _aidl_value;
2971 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
2972 set<e>(std::move(_aidl_value));
2973 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09002974 case pfd: {
2975 ::android::os::ParcelFileDescriptor _aidl_value;
2976 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2977 set<pfd>(std::move(_aidl_value));
2978 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09002979 }
2980 return ::android::BAD_VALUE;
2981}
2982
2983::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
2984 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
2985 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
2986 switch (getTag()) {
2987 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
2988 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09002989 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002990 }
2991 abort();
2992}
2993
2994} // namespace a
2995)";
2996
Jooyung Han6beac042020-10-17 21:59:43 +09002997const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
2998#include <android/binder_interface_utils.h>
2999#include <android/binder_parcelable_utils.h>
3000
3001#include <type_traits>
3002#include <utility>
3003#include <variant>
3004#include <cstdint>
3005#include <memory>
3006#include <optional>
3007#include <string>
3008#include <vector>
3009#ifdef BINDER_STABILITY_SUPPORT
3010#include <android/binder_stability.h>
3011#endif // BINDER_STABILITY_SUPPORT
3012#include <aidl/a/ByteEnum.h>
3013namespace aidl {
3014namespace a {
3015class Foo {
3016public:
3017 typedef std::false_type fixed_size;
3018 static const char* descriptor;
3019
3020 enum Tag : int32_t {
3021 ns = 0, // int[] ns;
3022 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003023 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003024 };
3025
3026 template<typename _Tp>
3027 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3028
3029 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3030 Foo(const Foo&) = default;
3031 Foo(Foo&&) = default;
3032 Foo& operator=(const Foo&) = default;
3033 Foo& operator=(Foo&&) = default;
3034
3035 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
3036 constexpr Foo(_Tp&& _arg)
3037 : _value(std::forward<_Tp>(_arg)) {}
3038
3039 template <typename... _Tp>
3040 constexpr explicit Foo(_Tp&&... _args)
3041 : _value(std::forward<_Tp>(_args)...) {}
3042
3043 template <Tag _tag, typename... _Tp>
3044 static Foo make(_Tp&&... _args) {
3045 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3046 }
3047
3048 template <Tag _tag, typename _Tp, typename... _Up>
3049 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3050 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3051 }
3052
3053 Tag getTag() const {
3054 return static_cast<Tag>(_value.index());
3055 }
3056
3057 template <Tag _tag>
3058 const auto& get() const {
3059 if (getTag() != _tag) { abort(); }
3060 return std::get<_tag>(_value);
3061 }
3062
3063 template <Tag _tag>
3064 auto& get() {
3065 if (getTag() != _tag) { abort(); }
3066 return std::get<_tag>(_value);
3067 }
3068
3069 template <Tag _tag, typename... _Tp>
3070 void set(_Tp&&... _args) {
3071 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3072 }
3073
3074 binder_status_t readFromParcel(const AParcel* _parcel);
3075 binder_status_t writeToParcel(AParcel* _parcel) const;
3076 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
3077private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003078 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003079};
3080} // namespace a
3081} // namespace aidl
3082)";
3083
3084const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3085
3086#include <android/binder_parcel_utils.h>
3087
3088namespace aidl {
3089namespace a {
3090const char* Foo::descriptor = "a.Foo";
3091
3092binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3093 binder_status_t _aidl_ret_status;
3094 int32_t _aidl_tag;
3095 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3096 switch (_aidl_tag) {
3097 case ns: {
3098 std::vector<int32_t> _aidl_value;
3099 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3100 set<ns>(std::move(_aidl_value));
3101 return STATUS_OK; }
3102 case e: {
3103 ::aidl::a::ByteEnum _aidl_value;
3104 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
3105 set<e>(std::move(_aidl_value));
3106 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003107 case pfd: {
3108 ::ndk::ScopedFileDescriptor _aidl_value;
3109 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3110 set<pfd>(std::move(_aidl_value));
3111 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003112 }
3113 return STATUS_BAD_VALUE;
3114}
3115binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3116 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3117 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3118 switch (getTag()) {
3119 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3120 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003121 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003122 }
3123 abort();
3124}
3125
3126} // namespace a
3127} // namespace aidl
3128)";
3129
Jooyung Han1f14ab32020-10-14 13:48:29 +09003130const char kUnionExampleExpectedOutputJava[] = R"(/*
3131 * This file is auto-generated. DO NOT MODIFY.
3132 */
3133package a;
3134
3135
3136public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003137 // tags for union fields
3138 public final static int ns = 0; // int[] ns;
3139 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003140 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003141
3142 private int _tag;
3143 private Object _value;
3144
3145 public Foo() {
3146 int[] value = {42};
3147 _set(ns, value);
3148 }
Jooyung Han97945de2020-10-15 16:41:38 +09003149
Jooyung Han1f14ab32020-10-14 13:48:29 +09003150 private Foo(android.os.Parcel _aidl_parcel) {
3151 readFromParcel(_aidl_parcel);
3152 }
Jooyung Han97945de2020-10-15 16:41:38 +09003153
Jooyung Han1f14ab32020-10-14 13:48:29 +09003154 private Foo(int tag, Object value) {
3155 _set(tag, value);
3156 }
3157
3158 public int getTag() {
3159 return _tag;
3160 }
3161
Jooyung Han97945de2020-10-15 16:41:38 +09003162 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003163
3164 public static Foo ns(int[] _value) {
3165 return new Foo(ns, _value);
3166 }
Jooyung Han97945de2020-10-15 16:41:38 +09003167
Jooyung Han1f14ab32020-10-14 13:48:29 +09003168 public int[] getNs() {
3169 _assertTag(ns);
3170 return (int[]) _value;
3171 }
Jooyung Han97945de2020-10-15 16:41:38 +09003172
Jooyung Han1f14ab32020-10-14 13:48:29 +09003173 public void setNs(int[] _value) {
3174 _set(ns, _value);
3175 }
3176
Jooyung Han97945de2020-10-15 16:41:38 +09003177 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003178
3179 public static Foo e(byte _value) {
3180 return new Foo(e, _value);
3181 }
Jooyung Han97945de2020-10-15 16:41:38 +09003182
Jooyung Han1f14ab32020-10-14 13:48:29 +09003183 public byte getE() {
3184 _assertTag(e);
3185 return (byte) _value;
3186 }
Jooyung Han97945de2020-10-15 16:41:38 +09003187
Jooyung Han1f14ab32020-10-14 13:48:29 +09003188 public void setE(byte _value) {
3189 _set(e, _value);
3190 }
3191
Jooyung Hand2fa0232020-10-19 02:51:41 +09003192 // ParcelFileDescriptor pfd;
3193
3194 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3195 return new Foo(pfd, _value);
3196 }
3197
3198 public android.os.ParcelFileDescriptor getPfd() {
3199 _assertTag(pfd);
3200 return (android.os.ParcelFileDescriptor) _value;
3201 }
3202
3203 public void setPfd(android.os.ParcelFileDescriptor _value) {
3204 _set(pfd, _value);
3205 }
3206
Jooyung Han1f14ab32020-10-14 13:48:29 +09003207 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3208 @Override
3209 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003210 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003211 }
3212 @Override
3213 public Foo[] newArray(int _aidl_size) {
3214 return new Foo[_aidl_size];
3215 }
3216 };
Jooyung Han97945de2020-10-15 16:41:38 +09003217
Jooyung Han1f14ab32020-10-14 13:48:29 +09003218 @Override
3219 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3220 _aidl_parcel.writeInt(_tag);
3221 switch (_tag) {
3222 case ns:
3223 _aidl_parcel.writeIntArray(getNs());
3224 break;
3225 case e:
3226 _aidl_parcel.writeByte(getE());
3227 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003228 case pfd:
3229 if ((getPfd()!=null)) {
3230 _aidl_parcel.writeInt(1);
3231 getPfd().writeToParcel(_aidl_parcel, 0);
3232 }
3233 else {
3234 _aidl_parcel.writeInt(0);
3235 }
3236 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003237 }
3238 }
Jooyung Han97945de2020-10-15 16:41:38 +09003239
Jooyung Han1f14ab32020-10-14 13:48:29 +09003240 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3241 int _aidl_tag;
3242 _aidl_tag = _aidl_parcel.readInt();
3243 switch (_aidl_tag) {
3244 case ns: {
3245 int[] _aidl_value;
3246 _aidl_value = _aidl_parcel.createIntArray();
3247 _set(_aidl_tag, _aidl_value);
3248 return; }
3249 case e: {
3250 byte _aidl_value;
3251 _aidl_value = _aidl_parcel.readByte();
3252 _set(_aidl_tag, _aidl_value);
3253 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003254 case pfd: {
3255 android.os.ParcelFileDescriptor _aidl_value;
3256 if ((0!=_aidl_parcel.readInt())) {
3257 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3258 }
3259 else {
3260 _aidl_value = null;
3261 }
3262 _set(_aidl_tag, _aidl_value);
3263 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003264 }
3265 throw new RuntimeException("union: out of range: " + _aidl_tag);
3266 }
Jooyung Han97945de2020-10-15 16:41:38 +09003267
Jooyung Han1f14ab32020-10-14 13:48:29 +09003268 @Override
3269 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003270 int _mask = 0;
3271 switch (getTag()) {
3272 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003273 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003274 break;
3275 }
3276 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003277 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003278 private int describeContents(Object _v) {
3279 if (_v == null) return 0;
3280 if (_v instanceof android.os.Parcelable) {
3281 return ((android.os.Parcelable) _v).describeContents();
3282 }
3283 return 0;
3284 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003285
3286 private void _assertTag(int tag) {
3287 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003288 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003289 }
3290 }
Jooyung Han97945de2020-10-15 16:41:38 +09003291
Jooyung Han1f14ab32020-10-14 13:48:29 +09003292 private String _tagString(int _tag) {
3293 switch (_tag) {
3294 case ns: return "ns";
3295 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003296 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003297 }
3298 throw new IllegalStateException("unknown field: " + _tag);
3299 }
Jooyung Han97945de2020-10-15 16:41:38 +09003300
Jooyung Han1f14ab32020-10-14 13:48:29 +09003301 private void _set(int tag, Object value) {
3302 this._tag = tag;
3303 this._value = value;
3304 }
3305}
3306)";
3307
Jooyung Han97945de2020-10-15 16:41:38 +09003308struct AidlUnionTest : ::testing::Test {
3309 void SetUp() override {
3310 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003311package a;
3312import a.ByteEnum;
3313union Foo {
3314 int[] ns = {42};
3315 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003316 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003317}
3318)");
Jooyung Han97945de2020-10-15 16:41:38 +09003319 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003320package a;
3321@Backing(type="byte")
3322enum ByteEnum {
3323 a, b, c
3324}
3325)");
Jooyung Han97945de2020-10-15 16:41:38 +09003326 }
3327 FakeIoDelegate io_delegate_;
3328 void Compile(string lang) {
3329 string command = "aidl --structured -I. -o out --lang=" + lang;
3330 if (lang == "cpp" || lang == "ndk") {
3331 command += " -h out";
3332 }
3333 command += " a/Foo.aidl";
3334 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003335 CaptureStderr();
3336 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3337 auto err = GetCapturedStderr();
3338 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003339 }
3340 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3341 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003342 string actual;
3343 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3344 EXPECT_EQ(expected, actual);
3345 }
Jooyung Han97945de2020-10-15 16:41:38 +09003346 }
3347};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003348
Jooyung Han97945de2020-10-15 16:41:38 +09003349TEST_F(AidlUnionTest, Example_Cpp) {
3350 Compile("cpp");
3351 EXPECT_COMPILE_OUTPUTS(
3352 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3353 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3354}
3355
Jooyung Han6beac042020-10-17 21:59:43 +09003356TEST_F(AidlUnionTest, Example_Ndk) {
3357 Compile("ndk");
3358 EXPECT_COMPILE_OUTPUTS(
3359 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3360 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3361}
3362
Jooyung Han97945de2020-10-15 16:41:38 +09003363TEST_F(AidlUnionTest, Example_Java) {
3364 Compile("java");
3365 EXPECT_COMPILE_OUTPUTS(
3366 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003367 // TODO(b/170689477) Rust
3368}
3369
Jooyung Hanfe89f122020-10-14 03:49:18 +09003370TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3371 const string method = "package a; union Foo {}";
3372 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3373 CaptureStderr();
3374 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3375 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3376}
3377
3378TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3379 const string method = "package a; union Foo { ParcelableHolder x; }";
3380 const string expected_stderr =
3381 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3382 CaptureStderr();
3383 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3384 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3385}
3386
Devin Moore53fc99c2020-08-12 08:07:52 -07003387TEST_P(AidlTest, GenericStructuredParcelable) {
3388 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3389 Options options =
3390 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3391 const string expected_stderr = "";
3392 CaptureStderr();
3393 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3394 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3395}
3396
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003397TEST_F(AidlTest, NestedTypeArgs) {
3398 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
3399 io_delegate_.SetFileContents(
3400 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<Bar<String>> barss; }");
3401 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3402 const string expected_stderr = "";
3403 CaptureStderr();
3404 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3405 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3406
3407 string code;
3408 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
3409 EXPECT_THAT(code, testing::HasSubstr("a.Bar<a.Bar<java.lang.String>> barss;"));
3410}
3411
Jooyung Han14004ed2020-10-16 03:49:57 +09003412struct GenericAidlTest : ::testing::Test {
3413 FakeIoDelegate io_delegate_;
3414 void Compile(string cmd) {
3415 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux> > x; }");
3416 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3417 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3418 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3419
3420 Options options = Options::From(cmd);
3421 CaptureStderr();
3422 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3423 EXPECT_EQ("", GetCapturedStderr());
3424 }
3425};
3426
3427TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3428 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3429 string code;
3430 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3431 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3432 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3433 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3434}
3435
3436TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3437 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3438 string code;
3439 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3440 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3441 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3442 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3443}
3444
Devin Moore53fc99c2020-08-12 08:07:52 -07003445TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3446 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3447 Options options =
3448 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3449 const string expected_stderr =
3450 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3451 CaptureStderr();
3452 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3453 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3454}
3455
3456TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3457 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3458 Options options =
3459 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3460 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3461 CaptureStderr();
3462 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3463 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3464}
3465
Jooyung Hanea2147c2020-10-21 18:16:56 +09003466constexpr char kDescriptContentsWithUntypedListMapInJava[] = R"(
3467 @Override
3468 public int describeContents() {
3469 int _mask = 0;
3470 _mask |= describeContents(l);
3471 _mask |= describeContents(m);
3472 return _mask;
3473 }
3474 private int describeContents(Object _v) {
3475 if (_v == null) return 0;
3476 Class<?> _clazz = _v.getClass();
3477 if (_clazz.isArray() && _clazz.getComponentType() == Object.class) {
3478 int _mask = 0;
3479 for (Object o : (Object[]) _v) {
3480 _mask |= describeContents(o);
3481 }
3482 return _mask;
3483 }
3484 if (_v instanceof java.io.FileDescriptor) {
3485 return android.os.Parcelable.CONTENTS_FILE_DESCRIPTOR;
3486 }
3487 if (_v instanceof java.util.Collection) {
3488 int _mask = 0;
3489 for (Object o : (java.util.Collection) _v) {
3490 _mask |= describeContents(o);
3491 }
3492 return _mask;
3493 }
3494 if (_v instanceof java.util.Map) {
3495 return describeContents(((java.util.Map) _v).values());
3496 }
3497 if (_v instanceof android.os.Parcelable) {
3498 return ((android.os.Parcelable) _v).describeContents();
3499 }
3500 if (_v instanceof android.util.SparseArray) {
3501 android.util.SparseArray _sa = (android.util.SparseArray) _v;
3502 int _mask = 0;
3503 int _N = _sa.size();
3504 int _i = 0;
3505 while (_i < _N) {
3506 _mask |= describeContents(_sa.valueAt(_i));
3507 _i++;
3508 }
3509 return _mask;
3510 }
3511 return 0;
3512 }
3513)";
3514TEST_F(AidlTest, SupportUntypeListAndMap) {
3515 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3516 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3517 CaptureStderr();
3518 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3519 EXPECT_EQ("", GetCapturedStderr());
3520
3521 string code;
3522 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
3523 EXPECT_THAT(code, testing::HasSubstr(kDescriptContentsWithUntypedListMapInJava));
3524}
3525
Christopher Wiley90be4e32015-10-20 14:55:25 -07003526} // namespace aidl
3527} // namespace android