blob: 0a73b2402cce835e876ae9006d1308e0d4d06653 [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visitICmp and visitFCmp functions.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000015#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000016#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000017#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000018#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000019#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000020#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000021#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000022#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000023#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000024#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000025#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000026#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000027#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000028
Chris Lattner2188e402010-01-04 07:37:31 +000029using namespace llvm;
30using namespace PatternMatch;
31
Chandler Carruth964daaa2014-04-22 02:55:47 +000032#define DEBUG_TYPE "instcombine"
33
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000034// How many times is a select replaced by one of its operands?
35STATISTIC(NumSel, "Number of select opts");
36
Chris Lattner98457102011-02-10 05:23:05 +000037
Sanjay Patel5f0217f2016-06-05 16:46:18 +000038/// Compute Result = In1+In2, returning true if the result overflowed for this
39/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000040static bool addWithOverflow(APInt &Result, const APInt &In1,
41 const APInt &In2, bool IsSigned = false) {
42 bool Overflow;
43 if (IsSigned)
44 Result = In1.sadd_ov(In2, Overflow);
45 else
46 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000047
Craig Topper6e025a32017-10-01 23:53:54 +000048 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000049}
50
Sanjay Patel5f0217f2016-06-05 16:46:18 +000051/// Compute Result = In1-In2, returning true if the result overflowed for this
52/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000053static bool subWithOverflow(APInt &Result, const APInt &In1,
54 const APInt &In2, bool IsSigned = false) {
55 bool Overflow;
56 if (IsSigned)
57 Result = In1.ssub_ov(In2, Overflow);
58 else
59 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000060
Craig Topper6e025a32017-10-01 23:53:54 +000061 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000062}
63
Balaram Makam569eaec2016-05-04 21:32:14 +000064/// Given an icmp instruction, return true if any use of this comparison is a
65/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000066static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000067 for (auto *U : I.users())
68 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000069 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000070 return false;
71}
72
Sanjay Patel5f0217f2016-06-05 16:46:18 +000073/// Given an exploded icmp instruction, return true if the comparison only
74/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
75/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000076static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000077 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000078 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000079 case ICmpInst::ICMP_SLT: // True if LHS s< 0
80 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000081 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000082 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
83 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000084 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000085 case ICmpInst::ICMP_SGT: // True if LHS s> -1
86 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000087 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000088 case ICmpInst::ICMP_UGT:
89 // True if LHS u> RHS and RHS == high-bit-mask - 1
90 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000091 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000092 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000093 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
94 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000095 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000096 default:
97 return false;
98 }
99}
100
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000101/// Returns true if the exploded icmp can be expressed as a signed comparison
102/// to zero and updates the predicate accordingly.
103/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000104/// TODO: Refactor with decomposeBitTestICmp()?
105static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000106 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000107 return false;
108
Craig Topper73ba1c82017-06-07 07:40:37 +0000109 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000110 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000111
Craig Topper73ba1c82017-06-07 07:40:37 +0000112 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000113 if (Pred == ICmpInst::ICMP_SLT) {
114 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000116 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000117 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000118 if (Pred == ICmpInst::ICMP_SGT) {
119 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000121 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000122 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000123
124 return false;
125}
126
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000127/// Given a signed integer type and a set of known zero and one bits, compute
128/// the maximum and minimum values that could have the specified known zero and
129/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000130/// TODO: Move to method on KnownBits struct?
131static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000132 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000133 assert(Known.getBitWidth() == Min.getBitWidth() &&
134 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000135 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000136 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000137
138 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
139 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000140 Min = Known.One;
141 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000142
Chris Lattner2188e402010-01-04 07:37:31 +0000143 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000144 Min.setSignBit();
145 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000146 }
147}
148
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000149/// Given an unsigned integer type and a set of known zero and one bits, compute
150/// the maximum and minimum values that could have the specified known zero and
151/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000152/// TODO: Move to method on KnownBits struct?
153static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000154 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000155 assert(Known.getBitWidth() == Min.getBitWidth() &&
156 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000157 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000158 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000159
Chris Lattner2188e402010-01-04 07:37:31 +0000160 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000161 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000162 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000163 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000164}
165
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000166/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000167/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000168/// where GV is a global variable with a constant initializer. Try to simplify
169/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000170/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
171///
172/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000173/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000174Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
175 GlobalVariable *GV,
176 CmpInst &ICI,
177 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000178 Constant *Init = GV->getInitializer();
179 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000180 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000181
Chris Lattnerfe741762012-01-31 02:55:06 +0000182 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000183 // Don't blow up on huge arrays.
184 if (ArrayElementCount > MaxArraySizeForCombine)
185 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000186
Chris Lattner2188e402010-01-04 07:37:31 +0000187 // There are many forms of this optimization we can handle, for now, just do
188 // the simple index into a single-dimensional array.
189 //
190 // Require: GEP GV, 0, i {{, constant indices}}
191 if (GEP->getNumOperands() < 3 ||
192 !isa<ConstantInt>(GEP->getOperand(1)) ||
193 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
194 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000195 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000196
197 // Check that indices after the variable are constants and in-range for the
198 // type they index. Collect the indices. This is typically for arrays of
199 // structs.
200 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000201
Chris Lattnerfe741762012-01-31 02:55:06 +0000202 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000203 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
204 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000205 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000206
Chris Lattner2188e402010-01-04 07:37:31 +0000207 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000208 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000209
Chris Lattner229907c2011-07-18 04:54:35 +0000210 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000211 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000212 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000213 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000214 EltTy = ATy->getElementType();
215 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000216 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000217 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000218
Chris Lattner2188e402010-01-04 07:37:31 +0000219 LaterIndices.push_back(IdxVal);
220 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000221
Chris Lattner2188e402010-01-04 07:37:31 +0000222 enum { Overdefined = -3, Undefined = -2 };
223
224 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000225
Chris Lattner2188e402010-01-04 07:37:31 +0000226 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
227 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
228 // and 87 is the second (and last) index. FirstTrueElement is -2 when
229 // undefined, otherwise set to the first true element. SecondTrueElement is
230 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
231 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
232
233 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
234 // form "i != 47 & i != 87". Same state transitions as for true elements.
235 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000236
Chris Lattner2188e402010-01-04 07:37:31 +0000237 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
238 /// define a state machine that triggers for ranges of values that the index
239 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
240 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
241 /// index in the range (inclusive). We use -2 for undefined here because we
242 /// use relative comparisons and don't want 0-1 to match -1.
243 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000244
Chris Lattner2188e402010-01-04 07:37:31 +0000245 // MagicBitvector - This is a magic bitvector where we set a bit if the
246 // comparison is true for element 'i'. If there are 64 elements or less in
247 // the array, this will fully represent all the comparison results.
248 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000249
Chris Lattner2188e402010-01-04 07:37:31 +0000250 // Scan the array and see if one of our patterns matches.
251 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000252 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
253 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000254 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000255
Chris Lattner2188e402010-01-04 07:37:31 +0000256 // If this is indexing an array of structures, get the structure element.
257 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000258 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000259
Chris Lattner2188e402010-01-04 07:37:31 +0000260 // If the element is masked, handle it.
261 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000262
Chris Lattner2188e402010-01-04 07:37:31 +0000263 // Find out if the comparison would be true or false for the i'th element.
264 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000265 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000266 // If the result is undef for this element, ignore it.
267 if (isa<UndefValue>(C)) {
268 // Extend range state machines to cover this element in case there is an
269 // undef in the middle of the range.
270 if (TrueRangeEnd == (int)i-1)
271 TrueRangeEnd = i;
272 if (FalseRangeEnd == (int)i-1)
273 FalseRangeEnd = i;
274 continue;
275 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000276
Chris Lattner2188e402010-01-04 07:37:31 +0000277 // If we can't compute the result for any of the elements, we have to give
278 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000279 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000280
Chris Lattner2188e402010-01-04 07:37:31 +0000281 // Otherwise, we know if the comparison is true or false for this element,
282 // update our state machines.
283 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000284
Chris Lattner2188e402010-01-04 07:37:31 +0000285 // State machine for single/double/range index comparison.
286 if (IsTrueForElt) {
287 // Update the TrueElement state machine.
288 if (FirstTrueElement == Undefined)
289 FirstTrueElement = TrueRangeEnd = i; // First true element.
290 else {
291 // Update double-compare state machine.
292 if (SecondTrueElement == Undefined)
293 SecondTrueElement = i;
294 else
295 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000296
Chris Lattner2188e402010-01-04 07:37:31 +0000297 // Update range state machine.
298 if (TrueRangeEnd == (int)i-1)
299 TrueRangeEnd = i;
300 else
301 TrueRangeEnd = Overdefined;
302 }
303 } else {
304 // Update the FalseElement state machine.
305 if (FirstFalseElement == Undefined)
306 FirstFalseElement = FalseRangeEnd = i; // First false element.
307 else {
308 // Update double-compare state machine.
309 if (SecondFalseElement == Undefined)
310 SecondFalseElement = i;
311 else
312 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000313
Chris Lattner2188e402010-01-04 07:37:31 +0000314 // Update range state machine.
315 if (FalseRangeEnd == (int)i-1)
316 FalseRangeEnd = i;
317 else
318 FalseRangeEnd = Overdefined;
319 }
320 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000321
Chris Lattner2188e402010-01-04 07:37:31 +0000322 // If this element is in range, update our magic bitvector.
323 if (i < 64 && IsTrueForElt)
324 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000325
Chris Lattner2188e402010-01-04 07:37:31 +0000326 // If all of our states become overdefined, bail out early. Since the
327 // predicate is expensive, only check it every 8 elements. This is only
328 // really useful for really huge arrays.
329 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
330 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
331 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000332 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000333 }
334
335 // Now that we've scanned the entire array, emit our new comparison(s). We
336 // order the state machines in complexity of the generated code.
337 Value *Idx = GEP->getOperand(2);
338
Matt Arsenault5aeae182013-08-19 21:40:31 +0000339 // If the index is larger than the pointer size of the target, truncate the
340 // index down like the GEP would do implicitly. We don't have to do this for
341 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000342 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000343 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000344 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
345 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000346 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000347 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000348
Chris Lattner2188e402010-01-04 07:37:31 +0000349 // If the comparison is only true for one or two elements, emit direct
350 // comparisons.
351 if (SecondTrueElement != Overdefined) {
352 // None true -> false.
353 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000354 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000355
Chris Lattner2188e402010-01-04 07:37:31 +0000356 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000357
Chris Lattner2188e402010-01-04 07:37:31 +0000358 // True for one element -> 'i == 47'.
359 if (SecondTrueElement == Undefined)
360 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000361
Chris Lattner2188e402010-01-04 07:37:31 +0000362 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000363 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000364 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000365 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000366 return BinaryOperator::CreateOr(C1, C2);
367 }
368
369 // If the comparison is only false for one or two elements, emit direct
370 // comparisons.
371 if (SecondFalseElement != Overdefined) {
372 // None false -> true.
373 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000374 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000375
Chris Lattner2188e402010-01-04 07:37:31 +0000376 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
377
378 // False for one element -> 'i != 47'.
379 if (SecondFalseElement == Undefined)
380 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000381
Chris Lattner2188e402010-01-04 07:37:31 +0000382 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000383 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000384 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000385 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000386 return BinaryOperator::CreateAnd(C1, C2);
387 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000388
Chris Lattner2188e402010-01-04 07:37:31 +0000389 // If the comparison can be replaced with a range comparison for the elements
390 // where it is true, emit the range check.
391 if (TrueRangeEnd != Overdefined) {
392 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000393
Chris Lattner2188e402010-01-04 07:37:31 +0000394 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
395 if (FirstTrueElement) {
396 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000397 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000398 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000399
Chris Lattner2188e402010-01-04 07:37:31 +0000400 Value *End = ConstantInt::get(Idx->getType(),
401 TrueRangeEnd-FirstTrueElement+1);
402 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
403 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000404
Chris Lattner2188e402010-01-04 07:37:31 +0000405 // False range check.
406 if (FalseRangeEnd != Overdefined) {
407 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
408 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
409 if (FirstFalseElement) {
410 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000411 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000412 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000413
Chris Lattner2188e402010-01-04 07:37:31 +0000414 Value *End = ConstantInt::get(Idx->getType(),
415 FalseRangeEnd-FirstFalseElement);
416 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
417 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000418
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000419 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000420 // of this load, replace it with computation that does:
421 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000422 {
Craig Topperf40110f2014-04-25 05:29:35 +0000423 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000424
425 // Look for an appropriate type:
426 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000427 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000428 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
429 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000430 else
431 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000432
Craig Topperf40110f2014-04-25 05:29:35 +0000433 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000434 Value *V = Builder.CreateIntCast(Idx, Ty, false);
435 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
436 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000437 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
438 }
Chris Lattner2188e402010-01-04 07:37:31 +0000439 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000440
Craig Topperf40110f2014-04-25 05:29:35 +0000441 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000442}
443
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000444/// Return a value that can be used to compare the *offset* implied by a GEP to
445/// zero. For example, if we have &A[i], we want to return 'i' for
446/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
447/// are involved. The above expression would also be legal to codegen as
448/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
449/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000450/// to generate the first by knowing that pointer arithmetic doesn't overflow.
451///
452/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000453///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000454static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000455 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000456 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000457
Chris Lattner2188e402010-01-04 07:37:31 +0000458 // Check to see if this gep only has a single variable index. If so, and if
459 // any constant indices are a multiple of its scale, then we can compute this
460 // in terms of the scale of the variable index. For example, if the GEP
461 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
462 // because the expression will cross zero at the same point.
463 unsigned i, e = GEP->getNumOperands();
464 int64_t Offset = 0;
465 for (i = 1; i != e; ++i, ++GTI) {
466 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
467 // Compute the aggregate offset of constant indices.
468 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000469
Chris Lattner2188e402010-01-04 07:37:31 +0000470 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000471 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000472 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000473 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000474 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000475 Offset += Size*CI->getSExtValue();
476 }
477 } else {
478 // Found our variable index.
479 break;
480 }
481 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000482
Chris Lattner2188e402010-01-04 07:37:31 +0000483 // If there are no variable indices, we must have a constant offset, just
484 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000485 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000486
Chris Lattner2188e402010-01-04 07:37:31 +0000487 Value *VariableIdx = GEP->getOperand(i);
488 // Determine the scale factor of the variable element. For example, this is
489 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000490 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000491
Chris Lattner2188e402010-01-04 07:37:31 +0000492 // Verify that there are no other variable indices. If so, emit the hard way.
493 for (++i, ++GTI; i != e; ++i, ++GTI) {
494 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000495 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000496
Chris Lattner2188e402010-01-04 07:37:31 +0000497 // Compute the aggregate offset of constant indices.
498 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000499
Chris Lattner2188e402010-01-04 07:37:31 +0000500 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000501 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000502 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000503 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000504 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000505 Offset += Size*CI->getSExtValue();
506 }
507 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000508
Chris Lattner2188e402010-01-04 07:37:31 +0000509 // Okay, we know we have a single variable index, which must be a
510 // pointer/array/vector index. If there is no offset, life is simple, return
511 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000512 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000513 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000514 if (Offset == 0) {
515 // Cast to intptrty in case a truncation occurs. If an extension is needed,
516 // we don't need to bother extending: the extension won't affect where the
517 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000518 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000519 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000520 }
Chris Lattner2188e402010-01-04 07:37:31 +0000521 return VariableIdx;
522 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000523
Chris Lattner2188e402010-01-04 07:37:31 +0000524 // Otherwise, there is an index. The computation we will do will be modulo
525 // the pointer size, so get it.
526 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 Offset &= PtrSizeMask;
529 VariableScale &= PtrSizeMask;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000530
Chris Lattner2188e402010-01-04 07:37:31 +0000531 // To do this transformation, any constant index must be a multiple of the
532 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
533 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
534 // multiple of the variable scale.
535 int64_t NewOffs = Offset / (int64_t)VariableScale;
536 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000537 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000538
Chris Lattner2188e402010-01-04 07:37:31 +0000539 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000540 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000542 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000543 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000544 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000545}
546
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000547/// Returns true if we can rewrite Start as a GEP with pointer Base
548/// and some integer offset. The nodes that need to be re-written
549/// for this transformation will be added to Explored.
550static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
551 const DataLayout &DL,
552 SetVector<Value *> &Explored) {
553 SmallVector<Value *, 16> WorkList(1, Start);
554 Explored.insert(Base);
555
556 // The following traversal gives us an order which can be used
557 // when doing the final transformation. Since in the final
558 // transformation we create the PHI replacement instructions first,
559 // we don't have to get them in any particular order.
560 //
561 // However, for other instructions we will have to traverse the
562 // operands of an instruction first, which means that we have to
563 // do a post-order traversal.
564 while (!WorkList.empty()) {
565 SetVector<PHINode *> PHIs;
566
567 while (!WorkList.empty()) {
568 if (Explored.size() >= 100)
569 return false;
570
571 Value *V = WorkList.back();
572
573 if (Explored.count(V) != 0) {
574 WorkList.pop_back();
575 continue;
576 }
577
578 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000579 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000580 // We've found some value that we can't explore which is different from
581 // the base. Therefore we can't do this transformation.
582 return false;
583
584 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
585 auto *CI = dyn_cast<CastInst>(V);
586 if (!CI->isNoopCast(DL))
587 return false;
588
589 if (Explored.count(CI->getOperand(0)) == 0)
590 WorkList.push_back(CI->getOperand(0));
591 }
592
593 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
594 // We're limiting the GEP to having one index. This will preserve
595 // the original pointer type. We could handle more cases in the
596 // future.
597 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
598 GEP->getType() != Start->getType())
599 return false;
600
601 if (Explored.count(GEP->getOperand(0)) == 0)
602 WorkList.push_back(GEP->getOperand(0));
603 }
604
605 if (WorkList.back() == V) {
606 WorkList.pop_back();
607 // We've finished visiting this node, mark it as such.
608 Explored.insert(V);
609 }
610
611 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000612 // We cannot transform PHIs on unsplittable basic blocks.
613 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
614 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000615 Explored.insert(PN);
616 PHIs.insert(PN);
617 }
618 }
619
620 // Explore the PHI nodes further.
621 for (auto *PN : PHIs)
622 for (Value *Op : PN->incoming_values())
623 if (Explored.count(Op) == 0)
624 WorkList.push_back(Op);
625 }
626
627 // Make sure that we can do this. Since we can't insert GEPs in a basic
628 // block before a PHI node, we can't easily do this transformation if
629 // we have PHI node users of transformed instructions.
630 for (Value *Val : Explored) {
631 for (Value *Use : Val->uses()) {
632
633 auto *PHI = dyn_cast<PHINode>(Use);
634 auto *Inst = dyn_cast<Instruction>(Val);
635
636 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
637 Explored.count(PHI) == 0)
638 continue;
639
640 if (PHI->getParent() == Inst->getParent())
641 return false;
642 }
643 }
644 return true;
645}
646
647// Sets the appropriate insert point on Builder where we can add
648// a replacement Instruction for V (if that is possible).
649static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
650 bool Before = true) {
651 if (auto *PHI = dyn_cast<PHINode>(V)) {
652 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
653 return;
654 }
655 if (auto *I = dyn_cast<Instruction>(V)) {
656 if (!Before)
657 I = &*std::next(I->getIterator());
658 Builder.SetInsertPoint(I);
659 return;
660 }
661 if (auto *A = dyn_cast<Argument>(V)) {
662 // Set the insertion point in the entry block.
663 BasicBlock &Entry = A->getParent()->getEntryBlock();
664 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
665 return;
666 }
667 // Otherwise, this is a constant and we don't need to set a new
668 // insertion point.
669 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
670}
671
672/// Returns a re-written value of Start as an indexed GEP using Base as a
673/// pointer.
674static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
675 const DataLayout &DL,
676 SetVector<Value *> &Explored) {
677 // Perform all the substitutions. This is a bit tricky because we can
678 // have cycles in our use-def chains.
679 // 1. Create the PHI nodes without any incoming values.
680 // 2. Create all the other values.
681 // 3. Add the edges for the PHI nodes.
682 // 4. Emit GEPs to get the original pointers.
683 // 5. Remove the original instructions.
684 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000685 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000686
687 DenseMap<Value *, Value *> NewInsts;
688 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
689
690 // Create the new PHI nodes, without adding any incoming values.
691 for (Value *Val : Explored) {
692 if (Val == Base)
693 continue;
694 // Create empty phi nodes. This avoids cyclic dependencies when creating
695 // the remaining instructions.
696 if (auto *PHI = dyn_cast<PHINode>(Val))
697 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
698 PHI->getName() + ".idx", PHI);
699 }
700 IRBuilder<> Builder(Base->getContext());
701
702 // Create all the other instructions.
703 for (Value *Val : Explored) {
704
705 if (NewInsts.find(Val) != NewInsts.end())
706 continue;
707
708 if (auto *CI = dyn_cast<CastInst>(Val)) {
709 NewInsts[CI] = NewInsts[CI->getOperand(0)];
710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
835 if (!GEPLHS->hasAllConstantIndices())
836 return nullptr;
837
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000838 // Make sure the pointers have the same type.
839 if (GEPLHS->getType() != RHS->getType())
840 return nullptr;
841
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000842 Value *PtrBase, *Index;
843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
844
845 // The set of nodes that will take part in this transformation.
846 SetVector<Value *> Nodes;
847
848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
849 return nullptr;
850
851 // We know we can re-write this as
852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
853 // Since we've only looked through inbouds GEPs we know that we
854 // can't have overflow on either side. We can therefore re-write
855 // this as:
856 // OFFSET1 cmp OFFSET2
857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
858
859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
861 // offset. Since Index is the offset of LHS to the base pointer, we will now
862 // compare the offsets instead of comparing the pointers.
863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
864}
865
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000866/// Fold comparisons between a GEP instruction and something else. At this point
867/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000868Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000869 ICmpInst::Predicate Cond,
870 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000871 // Don't transform signed compares of GEPs into index compares. Even if the
872 // GEP is inbounds, the final add of the base pointer can have signed overflow
873 // and would change the result of the icmp.
874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000875 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000876 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000877 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000878
Matt Arsenault44f60d02014-06-09 19:20:29 +0000879 // Look through bitcasts and addrspacecasts. We do not however want to remove
880 // 0 GEPs.
881 if (!isa<GetElementPtrInst>(RHS))
882 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000883
884 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000885 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
887 // This transformation (ignoring the base and scales) is valid because we
888 // know pointers can't overflow since the gep is inbounds. See if we can
889 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000891
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000893 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000894 Offset = EmitGEPOffset(GEPLHS);
895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
896 Constant::getNullValue(Offset->getType()));
897 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
898 // If the base pointers are different, but the indices are the same, just
899 // compare the base pointer.
900 if (PtrBase != GEPRHS->getOperand(0)) {
901 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
902 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
903 GEPRHS->getOperand(0)->getType();
904 if (IndicesTheSame)
905 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
906 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
907 IndicesTheSame = false;
908 break;
909 }
910
911 // If all indices are the same, just compare the base pointers.
Jesper Antonssonc954b862018-10-01 14:59:25 +0000912 Type *BaseType = GEPLHS->getOperand(0)->getType();
913 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType())
David Majnemer5953d372013-06-29 10:28:04 +0000914 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000915
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000916 // If we're comparing GEPs with two base pointers that only differ in type
917 // and both GEPs have only constant indices or just one use, then fold
918 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000919 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000920 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
921 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
922 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000923 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000924 Value *LOffset = EmitGEPOffset(GEPLHS);
925 Value *ROffset = EmitGEPOffset(GEPRHS);
926
927 // If we looked through an addrspacecast between different sized address
928 // spaces, the LHS and RHS pointers are different sized
929 // integers. Truncate to the smaller one.
930 Type *LHSIndexTy = LOffset->getType();
931 Type *RHSIndexTy = ROffset->getType();
932 if (LHSIndexTy != RHSIndexTy) {
933 if (LHSIndexTy->getPrimitiveSizeInBits() <
934 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000935 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000936 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000937 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000938 }
939
Craig Topperbb4069e2017-07-07 23:16:26 +0000940 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
941 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000942 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000943 }
944
Chris Lattner2188e402010-01-04 07:37:31 +0000945 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000946 // different. Try convert this to an indexed compare by looking through
947 // PHIs/casts.
948 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000949 }
950
951 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000952 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000953 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000954 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000955
956 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000957 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000958 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000959
Stuart Hastings66a82b92011-05-14 05:55:10 +0000960 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000961 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
962 // If the GEPs only differ by one index, compare it.
963 unsigned NumDifferences = 0; // Keep track of # differences.
964 unsigned DiffOperand = 0; // The operand that differs.
965 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
966 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
967 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
968 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
969 // Irreconcilable differences.
970 NumDifferences = 2;
971 break;
972 } else {
973 if (NumDifferences++) break;
974 DiffOperand = i;
975 }
976 }
977
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +0000978 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +0000979 return replaceInstUsesWith(I, // No comparison is needed here.
Jesper Antonsson719fa052018-09-20 13:37:28 +0000980 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +0000981
Stuart Hastings66a82b92011-05-14 05:55:10 +0000982 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +0000983 Value *LHSV = GEPLHS->getOperand(DiffOperand);
984 Value *RHSV = GEPRHS->getOperand(DiffOperand);
985 // Make sure we do a signed comparison here.
986 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
987 }
988 }
989
990 // Only lower this if the icmp is the only user of the GEP or if we expect
991 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000992 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +0000993 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
994 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
995 Value *L = EmitGEPOffset(GEPLHS);
996 Value *R = EmitGEPOffset(GEPRHS);
997 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
998 }
999 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001000
1001 // Try convert this to an indexed compare by looking through PHIs/casts as a
1002 // last resort.
1003 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001004}
1005
Pete Cooper980a9352016-08-12 17:13:28 +00001006Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1007 const AllocaInst *Alloca,
1008 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001009 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1010
1011 // It would be tempting to fold away comparisons between allocas and any
1012 // pointer not based on that alloca (e.g. an argument). However, even
1013 // though such pointers cannot alias, they can still compare equal.
1014 //
1015 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1016 // doesn't escape we can argue that it's impossible to guess its value, and we
1017 // can therefore act as if any such guesses are wrong.
1018 //
1019 // The code below checks that the alloca doesn't escape, and that it's only
1020 // used in a comparison once (the current instruction). The
1021 // single-comparison-use condition ensures that we're trivially folding all
1022 // comparisons against the alloca consistently, and avoids the risk of
1023 // erroneously folding a comparison of the pointer with itself.
1024
1025 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1026
Pete Cooper980a9352016-08-12 17:13:28 +00001027 SmallVector<const Use *, 32> Worklist;
1028 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001029 if (Worklist.size() >= MaxIter)
1030 return nullptr;
1031 Worklist.push_back(&U);
1032 }
1033
1034 unsigned NumCmps = 0;
1035 while (!Worklist.empty()) {
1036 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001037 const Use *U = Worklist.pop_back_val();
1038 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001039 --MaxIter;
1040
1041 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1042 isa<SelectInst>(V)) {
1043 // Track the uses.
1044 } else if (isa<LoadInst>(V)) {
1045 // Loading from the pointer doesn't escape it.
1046 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001047 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001048 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1049 if (SI->getValueOperand() == U->get())
1050 return nullptr;
1051 continue;
1052 } else if (isa<ICmpInst>(V)) {
1053 if (NumCmps++)
1054 return nullptr; // Found more than one cmp.
1055 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001056 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001057 switch (Intrin->getIntrinsicID()) {
1058 // These intrinsics don't escape or compare the pointer. Memset is safe
1059 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1060 // we don't allow stores, so src cannot point to V.
1061 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001062 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1063 continue;
1064 default:
1065 return nullptr;
1066 }
1067 } else {
1068 return nullptr;
1069 }
Pete Cooper980a9352016-08-12 17:13:28 +00001070 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001071 if (Worklist.size() >= MaxIter)
1072 return nullptr;
1073 Worklist.push_back(&U);
1074 }
1075 }
1076
1077 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001078 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001079 ICI,
1080 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1081}
1082
Craig Topperbee74792018-08-20 23:04:25 +00001083/// Fold "icmp pred (X+C), X".
1084Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001085 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001086 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001087 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001088 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001089 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001090
Chris Lattner8c92b572010-01-08 17:48:19 +00001091 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001092 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1093 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1094 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001095 Constant *R = ConstantInt::get(X->getType(),
1096 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001097 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1098 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001099
Chris Lattner2188e402010-01-04 07:37:31 +00001100 // (X+1) >u X --> X <u (0-1) --> X != 255
1101 // (X+2) >u X --> X <u (0-2) --> X <u 254
1102 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001103 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001104 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1105 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001106
Craig Topperbee74792018-08-20 23:04:25 +00001107 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001108
1109 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1110 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1111 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1112 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1113 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1114 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001115 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001116 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1117 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001118
Chris Lattner2188e402010-01-04 07:37:31 +00001119 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1120 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1121 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1122 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1123 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1124 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001125
Chris Lattner2188e402010-01-04 07:37:31 +00001126 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001127 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1128 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001129}
1130
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001131/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1132/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1133/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1134Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1135 const APInt &AP1,
1136 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001137 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1138
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001139 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1140 if (I.getPredicate() == I.ICMP_NE)
1141 Pred = CmpInst::getInversePredicate(Pred);
1142 return new ICmpInst(Pred, LHS, RHS);
1143 };
1144
David Majnemer2abb8182014-10-25 07:13:13 +00001145 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001146 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001147 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001148
1149 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001150 if (IsAShr) {
1151 if (AP2.isAllOnesValue())
1152 return nullptr;
1153 if (AP2.isNegative() != AP1.isNegative())
1154 return nullptr;
1155 if (AP2.sgt(AP1))
1156 return nullptr;
1157 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001158
David Majnemerd2056022014-10-21 19:51:55 +00001159 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001160 // 'A' must be large enough to shift out the highest set bit.
1161 return getICmp(I.ICMP_UGT, A,
1162 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001163
David Majnemerd2056022014-10-21 19:51:55 +00001164 if (AP1 == AP2)
1165 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001166
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001167 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001168 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001169 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001170 else
David Majnemere5977eb2015-09-19 00:48:26 +00001171 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001172
David Majnemerd2056022014-10-21 19:51:55 +00001173 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001174 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1175 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001176 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001177 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1178 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001179 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001180 } else if (AP1 == AP2.lshr(Shift)) {
1181 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1182 }
David Majnemerd2056022014-10-21 19:51:55 +00001183 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001184
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001185 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001186 // FIXME: This should always be handled by InstSimplify?
1187 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1188 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001189}
Chris Lattner2188e402010-01-04 07:37:31 +00001190
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001191/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1192/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1193Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1194 const APInt &AP1,
1195 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001196 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1197
David Majnemer59939ac2014-10-19 08:23:08 +00001198 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1199 if (I.getPredicate() == I.ICMP_NE)
1200 Pred = CmpInst::getInversePredicate(Pred);
1201 return new ICmpInst(Pred, LHS, RHS);
1202 };
1203
David Majnemer2abb8182014-10-25 07:13:13 +00001204 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001205 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001206 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001207
1208 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1209
1210 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001211 return getICmp(
1212 I.ICMP_UGE, A,
1213 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001214
1215 if (AP1 == AP2)
1216 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1217
1218 // Get the distance between the lowest bits that are set.
1219 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1220
1221 if (Shift > 0 && AP2.shl(Shift) == AP1)
1222 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1223
1224 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001225 // FIXME: This should always be handled by InstSimplify?
1226 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1227 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001228}
1229
Sanjay Patel06b127a2016-09-15 14:37:50 +00001230/// The caller has matched a pattern of the form:
1231/// I = icmp ugt (add (add A, B), CI2), CI1
1232/// If this is of the form:
1233/// sum = a + b
1234/// if (sum+128 >u 255)
1235/// Then replace it with llvm.sadd.with.overflow.i8.
1236///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001237static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001238 ConstantInt *CI2, ConstantInt *CI1,
1239 InstCombiner &IC) {
1240 // The transformation we're trying to do here is to transform this into an
1241 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1242 // with a narrower add, and discard the add-with-constant that is part of the
1243 // range check (if we can't eliminate it, this isn't profitable).
1244
1245 // In order to eliminate the add-with-constant, the compare can be its only
1246 // use.
1247 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1248 if (!AddWithCst->hasOneUse())
1249 return nullptr;
1250
1251 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1252 if (!CI2->getValue().isPowerOf2())
1253 return nullptr;
1254 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1255 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1256 return nullptr;
1257
1258 // The width of the new add formed is 1 more than the bias.
1259 ++NewWidth;
1260
1261 // Check to see that CI1 is an all-ones value with NewWidth bits.
1262 if (CI1->getBitWidth() == NewWidth ||
1263 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1264 return nullptr;
1265
1266 // This is only really a signed overflow check if the inputs have been
1267 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1268 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1269 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1270 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1271 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1272 return nullptr;
1273
1274 // In order to replace the original add with a narrower
1275 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1276 // and truncates that discard the high bits of the add. Verify that this is
1277 // the case.
1278 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1279 for (User *U : OrigAdd->users()) {
1280 if (U == AddWithCst)
1281 continue;
1282
1283 // Only accept truncates for now. We would really like a nice recursive
1284 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1285 // chain to see which bits of a value are actually demanded. If the
1286 // original add had another add which was then immediately truncated, we
1287 // could still do the transformation.
1288 TruncInst *TI = dyn_cast<TruncInst>(U);
1289 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1290 return nullptr;
1291 }
1292
1293 // If the pattern matches, truncate the inputs to the narrower type and
1294 // use the sadd_with_overflow intrinsic to efficiently compute both the
1295 // result and the overflow bit.
1296 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
1297 Value *F = Intrinsic::getDeclaration(I.getModule(),
1298 Intrinsic::sadd_with_overflow, NewType);
1299
Craig Topperbb4069e2017-07-07 23:16:26 +00001300 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001301
1302 // Put the new code above the original add, in case there are any uses of the
1303 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001304 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001305
Craig Topperbb4069e2017-07-07 23:16:26 +00001306 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1307 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1308 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1309 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1310 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001311
1312 // The inner add was the result of the narrow add, zero extended to the
1313 // wider type. Replace it with the result computed by the intrinsic.
1314 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1315
1316 // The original icmp gets replaced with the overflow value.
1317 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1318}
1319
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001320// Handle (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1321Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1322 CmpInst::Predicate Pred = Cmp.getPredicate();
1323 Value *X = Cmp.getOperand(0);
1324
1325 if (match(Cmp.getOperand(1), m_Zero()) && Pred == ICmpInst::ICMP_SGT) {
1326 Value *A, *B;
1327 SelectPatternResult SPR = matchSelectPattern(X, A, B);
1328 if (SPR.Flavor == SPF_SMIN) {
1329 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1330 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1331 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1332 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1333 }
1334 }
1335 return nullptr;
1336}
1337
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001338/// Fold icmp Pred X, C.
1339/// TODO: This code structure does not make much sense. The saturating add fold
1340/// should be moved to some other helper and extended as noted below (it is also
1341/// possible that code has been made unnecessary - no regression test failures).
1342/// The dominating compare fold should not be limited to compare with constant.
Sanjay Patel97459832016-09-15 15:11:12 +00001343Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
Sanjay Patel97459832016-09-15 15:11:12 +00001344 // Match the following pattern, which is a common idiom when writing
1345 // overflow-safe integer arithmetic functions. The source performs an addition
1346 // in wider type and explicitly checks for overflow using comparisons against
1347 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1348 //
1349 // TODO: This could probably be generalized to handle other overflow-safe
1350 // operations if we worked out the formulas to compute the appropriate magic
1351 // constants.
1352 //
1353 // sum = a + b
1354 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001355 CmpInst::Predicate Pred = Cmp.getPredicate();
1356 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1);
1357 Value *A, *B;
1358 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1359 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) &&
1360 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
1361 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this))
1362 return Res;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001363
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001364 if (Instruction *I = foldICmpWithDominatingICmp(Cmp))
1365 return I;
1366
1367 return nullptr;
1368}
1369
1370/// Canonicalize icmp instructions based on dominating conditions.
1371Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) {
1372 CmpInst::Predicate Pred = Cmp.getPredicate();
1373 Value *X = Cmp.getOperand(0);
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001374 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1));
1375 if (!CI)
1376 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001377
Sanjay Patel97459832016-09-15 15:11:12 +00001378 BasicBlock *Parent = Cmp.getParent();
1379 BasicBlock *Dom = Parent->getSinglePredecessor();
1380 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr;
1381 ICmpInst::Predicate Pred2;
1382 BasicBlock *TrueBB, *FalseBB;
1383 ConstantInt *CI2;
1384 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)),
1385 TrueBB, FalseBB)) &&
1386 TrueBB != FalseBB) {
1387 ConstantRange CR =
1388 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue());
1389 ConstantRange DominatingCR =
1390 (Parent == TrueBB)
1391 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue())
1392 : ConstantRange::makeExactICmpRegion(
1393 CmpInst::getInversePredicate(Pred2), CI2->getValue());
1394 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1395 ConstantRange Difference = DominatingCR.difference(CR);
1396 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001397 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001398 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001399 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001400
Sanjay Patel97459832016-09-15 15:11:12 +00001401 // If this is a normal comparison, it demands all bits. If it is a sign
1402 // bit comparison, it only demands the sign bit.
1403 bool UnusedBit;
1404 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit);
1405
1406 // Canonicalizing a sign bit comparison that gets used in a branch,
1407 // pessimizes codegen by generating branch on zero instruction instead
1408 // of a test and branch. So we avoid canonicalizing in such situations
1409 // because test and branch instruction has better branch displacement
1410 // than compare and branch instruction.
Eric Christophera95aac32017-06-30 01:57:48 +00001411 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1412 return nullptr;
1413
1414 if (auto *AI = Intersection.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001415 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*AI));
Eric Christophera95aac32017-06-30 01:57:48 +00001416 if (auto *AD = Difference.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001417 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*AD));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001418 }
1419
1420 return nullptr;
1421}
1422
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001423/// Fold icmp (trunc X, Y), C.
1424Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001425 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001426 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001427 ICmpInst::Predicate Pred = Cmp.getPredicate();
1428 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001429 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001430 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1431 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001432 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001433 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1434 ConstantInt::get(V->getType(), 1));
1435 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001436
1437 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001438 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1439 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001440 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1441 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001442 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001443
1444 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001445 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001446 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001447 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001448 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001449 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001450 }
1451 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001452
Sanjay Patela3f4f082016-08-16 17:54:36 +00001453 return nullptr;
1454}
1455
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001456/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001457Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1458 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001459 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001460 Value *X = Xor->getOperand(0);
1461 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001462 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001463 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001464 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001465
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001466 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1467 // fold the xor.
1468 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001469 bool TrueIfSigned = false;
1470 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001471
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001472 // If the sign bit of the XorCst is not set, there is no change to
1473 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001474 if (!XorC->isNegative()) {
1475 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001476 Worklist.Add(Xor);
1477 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001478 }
1479
Craig Topperdf63b962017-10-03 19:14:23 +00001480 // Emit the opposite comparison.
1481 if (TrueIfSigned)
1482 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1483 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001484 else
Craig Topperdf63b962017-10-03 19:14:23 +00001485 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1486 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001487 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001488
1489 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001490 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1491 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001492 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1493 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001494 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001495 }
1496
Craig Topperbcfd2d12017-04-20 16:56:25 +00001497 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001498 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1499 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1500 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001501 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001502 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001503 }
1504 }
1505
Sanjay Patel26725bd2018-09-11 22:00:15 +00001506 // Mask constant magic can eliminate an 'xor' with unsigned compares.
1507 if (Pred == ICmpInst::ICMP_UGT) {
1508 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2)
1509 if (*XorC == ~C && (C + 1).isPowerOf2())
1510 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
1511 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2)
1512 if (*XorC == C && (C + 1).isPowerOf2())
1513 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
1514 }
1515 if (Pred == ICmpInst::ICMP_ULT) {
1516 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2)
1517 if (*XorC == -C && C.isPowerOf2())
1518 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1519 ConstantInt::get(X->getType(), ~C));
1520 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2)
1521 if (*XorC == C && (-C).isPowerOf2())
1522 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1523 ConstantInt::get(X->getType(), ~C));
1524 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001525 return nullptr;
1526}
1527
Sanjay Patel14e0e182016-08-26 18:28:46 +00001528/// Fold icmp (and (sh X, Y), C2), C1.
1529Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001530 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001531 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1532 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001533 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001534
Sanjay Patelda9c5622016-08-26 17:15:22 +00001535 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1536 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1537 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001538 // This seemingly simple opportunity to fold away a shift turns out to be
1539 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001540 unsigned ShiftOpcode = Shift->getOpcode();
1541 bool IsShl = ShiftOpcode == Instruction::Shl;
1542 const APInt *C3;
1543 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001544 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001545 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001546 // For a left shift, we can fold if the comparison is not signed. We can
1547 // also fold a signed comparison if the mask value and comparison value
1548 // are not negative. These constraints may not be obvious, but we can
1549 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001550 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001551 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001552 } else {
1553 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001554 // For a logical right shift, we can fold if the comparison is not signed.
1555 // We can also fold a signed comparison if the shifted mask value and the
1556 // shifted comparison value are not negative. These constraints may not be
1557 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001558 // For an arithmetic shift right we can do the same, if we ensure
1559 // the And doesn't use any bits being shifted in. Normally these would
1560 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1561 // additional user.
1562 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1563 if (!Cmp.isSigned() ||
1564 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1565 CanFold = true;
1566 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001567 }
1568
Sanjay Patelda9c5622016-08-26 17:15:22 +00001569 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001570 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001571 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001572 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001573 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001574 // If we shifted bits out, the fold is not going to work out. As a
1575 // special case, check to see if this means that the result is always
1576 // true or false now.
1577 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001578 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001579 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001580 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001581 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001582 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001583 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001584 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001585 And->setOperand(0, Shift->getOperand(0));
1586 Worklist.Add(Shift); // Shift is dead.
1587 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001588 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001589 }
1590 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001591
Sanjay Patelda9c5622016-08-26 17:15:22 +00001592 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1593 // preferable because it allows the C2 << Y expression to be hoisted out of a
1594 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001595 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001596 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1597 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001598 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001599 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1600 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001601
Sanjay Patelda9c5622016-08-26 17:15:22 +00001602 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001603 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001604 Cmp.setOperand(0, NewAnd);
1605 return &Cmp;
1606 }
1607
Sanjay Patel14e0e182016-08-26 18:28:46 +00001608 return nullptr;
1609}
1610
1611/// Fold icmp (and X, C2), C1.
1612Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1613 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001614 const APInt &C1) {
Sanjay Patel05aadf82018-10-10 20:47:46 +00001615 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1
1616 // TODO: We canonicalize to the longer form for scalars because we have
1617 // better analysis/folds for icmp, and codegen may be better with icmp.
1618 if (Cmp.getPredicate() == CmpInst::ICMP_NE && Cmp.getType()->isVectorTy() &&
1619 C1.isNullValue() && match(And->getOperand(1), m_One()))
1620 return new TruncInst(And->getOperand(0), Cmp.getType());
1621
Sanjay Patel6b490972016-09-04 14:32:15 +00001622 const APInt *C2;
1623 if (!match(And->getOperand(1), m_APInt(C2)))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001624 return nullptr;
1625
Craig Topper8bf62212017-09-26 18:47:25 +00001626 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001627 return nullptr;
1628
Sanjay Patel6b490972016-09-04 14:32:15 +00001629 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1630 // the input width without changing the value produced, eliminate the cast:
1631 //
1632 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1633 //
1634 // We can do this transformation if the constants do not have their sign bits
1635 // set or if it is an equality comparison. Extending a relational comparison
1636 // when we're checking the sign bit would not work.
1637 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001638 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001639 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001640 // TODO: Is this a good transform for vectors? Wider types may reduce
1641 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001642 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001643 if (!Cmp.getType()->isVectorTy()) {
1644 Type *WideType = W->getType();
1645 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001646 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001647 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001648 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001649 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001650 }
1651 }
1652
Craig Topper8ed1aa92017-10-03 05:31:07 +00001653 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001654 return I;
1655
Sanjay Patelda9c5622016-08-26 17:15:22 +00001656 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001657 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001658 //
1659 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001660 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001661 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001662 Constant *One = cast<Constant>(And->getOperand(1));
1663 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001664 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001665 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1666 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1667 unsigned UsesRemoved = 0;
1668 if (And->hasOneUse())
1669 ++UsesRemoved;
1670 if (Or->hasOneUse())
1671 ++UsesRemoved;
1672 if (LShr->hasOneUse())
1673 ++UsesRemoved;
1674
1675 // Compute A & ((1 << B) | 1)
1676 Value *NewOr = nullptr;
1677 if (auto *C = dyn_cast<Constant>(B)) {
1678 if (UsesRemoved >= 1)
1679 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1680 } else {
1681 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001682 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1683 /*HasNUW=*/true),
1684 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001685 }
1686 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001687 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001688 Cmp.setOperand(0, NewAnd);
1689 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001690 }
1691 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001692 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001693
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001694 return nullptr;
1695}
1696
1697/// Fold icmp (and X, Y), C.
1698Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1699 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001700 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001701 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1702 return I;
1703
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001704 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001705
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001706 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1707 Value *X = And->getOperand(0);
1708 Value *Y = And->getOperand(1);
1709 if (auto *LI = dyn_cast<LoadInst>(X))
1710 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1711 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001712 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001713 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1714 ConstantInt *C2 = cast<ConstantInt>(Y);
1715 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001716 return Res;
1717 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001718
1719 if (!Cmp.isEquality())
1720 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001721
1722 // X & -C == -C -> X > u ~C
1723 // X & -C != -C -> X <= u ~C
1724 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001725 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001726 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1727 : CmpInst::ICMP_ULE;
1728 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1729 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001730
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001731 // (X & C2) == 0 -> (trunc X) >= 0
1732 // (X & C2) != 0 -> (trunc X) < 0
1733 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1734 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001735 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001736 int32_t ExactLogBase2 = C2->exactLogBase2();
1737 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1738 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1739 if (And->getType()->isVectorTy())
1740 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001741 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001742 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1743 : CmpInst::ICMP_SLT;
1744 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001745 }
1746 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001747
Sanjay Patela3f4f082016-08-16 17:54:36 +00001748 return nullptr;
1749}
1750
Sanjay Patel943e92e2016-08-17 16:30:43 +00001751/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001752Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001753 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001754 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001755 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001756 // icmp slt signum(V) 1 --> icmp slt V, 1
1757 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001758 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001759 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1760 ConstantInt::get(V->getType(), 1));
1761 }
1762
Sanjay Patel50c82c42017-04-05 17:57:05 +00001763 // X | C == C --> X <=u C
1764 // X | C != C --> X >u C
1765 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1766 if (Cmp.isEquality() && Cmp.getOperand(1) == Or->getOperand(1) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001767 (C + 1).isPowerOf2()) {
Sanjay Patel50c82c42017-04-05 17:57:05 +00001768 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1769 return new ICmpInst(Pred, Or->getOperand(0), Or->getOperand(1));
1770 }
1771
Craig Topper8ed1aa92017-10-03 05:31:07 +00001772 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001773 return nullptr;
1774
1775 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001776 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001777 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1778 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001779 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001780 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001781 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001782 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001783 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1784 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1785 }
1786
1787 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1788 // a shorter form that has more potential to be folded even further.
1789 Value *X1, *X2, *X3, *X4;
1790 if (match(Or->getOperand(0), m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1791 match(Or->getOperand(1), m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
1792 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1793 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1794 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1795 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1796 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1797 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001798 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001799
Sanjay Patela3f4f082016-08-16 17:54:36 +00001800 return nullptr;
1801}
1802
Sanjay Patel63478072016-08-18 15:44:44 +00001803/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001804Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1805 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001806 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001807 const APInt *MulC;
1808 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001809 return nullptr;
1810
Sanjay Patel63478072016-08-18 15:44:44 +00001811 // If this is a test of the sign bit and the multiply is sign-preserving with
1812 // a constant operand, use the multiply LHS operand instead.
1813 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001814 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001815 if (MulC->isNegative())
1816 Pred = ICmpInst::getSwappedPredicate(Pred);
1817 return new ICmpInst(Pred, Mul->getOperand(0),
1818 Constant::getNullValue(Mul->getType()));
1819 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001820
1821 return nullptr;
1822}
1823
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001824/// Fold icmp (shl 1, Y), C.
1825static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001826 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001827 Value *Y;
1828 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1829 return nullptr;
1830
1831 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001832 unsigned TypeBits = C.getBitWidth();
1833 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001834 ICmpInst::Predicate Pred = Cmp.getPredicate();
1835 if (Cmp.isUnsigned()) {
1836 // (1 << Y) pred C -> Y pred Log2(C)
1837 if (!CIsPowerOf2) {
1838 // (1 << Y) < 30 -> Y <= 4
1839 // (1 << Y) <= 30 -> Y <= 4
1840 // (1 << Y) >= 30 -> Y > 4
1841 // (1 << Y) > 30 -> Y > 4
1842 if (Pred == ICmpInst::ICMP_ULT)
1843 Pred = ICmpInst::ICMP_ULE;
1844 else if (Pred == ICmpInst::ICMP_UGE)
1845 Pred = ICmpInst::ICMP_UGT;
1846 }
1847
1848 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1849 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001850 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001851 if (CLog2 == TypeBits - 1) {
1852 if (Pred == ICmpInst::ICMP_UGE)
1853 Pred = ICmpInst::ICMP_EQ;
1854 else if (Pred == ICmpInst::ICMP_ULT)
1855 Pred = ICmpInst::ICMP_NE;
1856 }
1857 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1858 } else if (Cmp.isSigned()) {
1859 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001860 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001861 // (1 << Y) <= -1 -> Y == 31
1862 if (Pred == ICmpInst::ICMP_SLE)
1863 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1864
1865 // (1 << Y) > -1 -> Y != 31
1866 if (Pred == ICmpInst::ICMP_SGT)
1867 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001868 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001869 // (1 << Y) < 0 -> Y == 31
1870 // (1 << Y) <= 0 -> Y == 31
1871 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1872 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1873
1874 // (1 << Y) >= 0 -> Y != 31
1875 // (1 << Y) > 0 -> Y != 31
1876 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1877 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1878 }
1879 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001880 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001881 }
1882
1883 return nullptr;
1884}
1885
Sanjay Patel38b75062016-08-19 17:20:37 +00001886/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001887Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1888 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001889 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001890 const APInt *ShiftVal;
1891 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001892 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001893
Sanjay Patelfa7de602016-08-19 22:33:26 +00001894 const APInt *ShiftAmt;
1895 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001896 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001897
Sanjay Patel38b75062016-08-19 17:20:37 +00001898 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001899 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001900 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001901 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001902 return nullptr;
1903
Sanjay Patele38e79c2016-08-19 17:34:05 +00001904 ICmpInst::Predicate Pred = Cmp.getPredicate();
1905 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001906 Type *ShType = Shl->getType();
1907
Sanjay Patel291c3d82017-01-19 16:12:10 +00001908 // NSW guarantees that we are only shifting out sign bits from the high bits,
1909 // so we can ASHR the compare constant without needing a mask and eliminate
1910 // the shift.
1911 if (Shl->hasNoSignedWrap()) {
1912 if (Pred == ICmpInst::ICMP_SGT) {
1913 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001914 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001915 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1916 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001917 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1918 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001919 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001920 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1921 }
1922 if (Pred == ICmpInst::ICMP_SLT) {
1923 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
1924 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
1925 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
1926 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00001927 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
1928 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00001929 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1930 }
1931 // If this is a signed comparison to 0 and the shift is sign preserving,
1932 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
1933 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001934 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00001935 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
1936 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001937
Sanjay Patel291c3d82017-01-19 16:12:10 +00001938 // NUW guarantees that we are only shifting out zero bits from the high bits,
1939 // so we can LSHR the compare constant without needing a mask and eliminate
1940 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00001941 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00001942 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00001943 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001944 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001945 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1946 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001947 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1948 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001949 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00001950 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1951 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001952 if (Pred == ICmpInst::ICMP_ULT) {
1953 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
1954 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
1955 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
1956 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00001957 assert(C.ugt(0) && "ult 0 should have been eliminated");
1958 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00001959 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1960 }
1961 }
1962
Sanjay Patel291c3d82017-01-19 16:12:10 +00001963 if (Cmp.isEquality() && Shl->hasOneUse()) {
1964 // Strength-reduce the shift into an 'and'.
1965 Constant *Mask = ConstantInt::get(
1966 ShType,
1967 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00001968 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00001969 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00001970 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001971 }
1972
Sanjay Patela3f4f082016-08-16 17:54:36 +00001973 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
1974 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001975 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00001976 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00001977 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00001978 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00001979 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00001980 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00001981 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00001982 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00001983 }
1984
Sanjay Patel643d21a2016-08-21 17:10:07 +00001985 // Transform (icmp pred iM (shl iM %v, N), C)
1986 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
1987 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00001988 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00001989 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00001990 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00001991 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001992 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00001993 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00001994 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001995 if (ShType->isVectorTy())
1996 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00001997 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00001998 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00001999 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002000 }
2001
2002 return nullptr;
2003}
2004
Sanjay Patela3920492016-08-22 20:45:06 +00002005/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002006Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2007 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002008 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002009 // An exact shr only shifts out zero bits, so:
2010 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002011 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002012 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002013 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00002014 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002015 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002016
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002017 const APInt *ShiftVal;
2018 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002019 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002020
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002021 const APInt *ShiftAmt;
2022 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002023 return nullptr;
2024
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002025 // Check that the shift amount is in range. If not, don't perform undefined
2026 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002027 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002028 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002029 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2030 return nullptr;
2031
Sanjay Pateld64e9882016-08-23 22:05:55 +00002032 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002033 bool IsExact = Shr->isExact();
2034 Type *ShrTy = Shr->getType();
2035 // TODO: If we could guarantee that InstSimplify would handle all of the
2036 // constant-value-based preconditions in the folds below, then we could assert
2037 // those conditions rather than checking them. This is difficult because of
2038 // undef/poison (PR34838).
2039 if (IsAShr) {
2040 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2041 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2042 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2043 APInt ShiftedC = C.shl(ShAmtVal);
2044 if (ShiftedC.ashr(ShAmtVal) == C)
2045 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2046 }
2047 if (Pred == CmpInst::ICMP_SGT) {
2048 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2049 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2050 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2051 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2052 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2053 }
2054 } else {
2055 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2056 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2057 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2058 APInt ShiftedC = C.shl(ShAmtVal);
2059 if (ShiftedC.lshr(ShAmtVal) == C)
2060 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2061 }
2062 if (Pred == CmpInst::ICMP_UGT) {
2063 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2064 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2065 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2066 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2067 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002068 }
2069
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002070 if (!Cmp.isEquality())
2071 return nullptr;
2072
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002073 // Handle equality comparisons of shift-by-constant.
2074
Sanjay Patel8e297742016-08-24 13:55:55 +00002075 // If the comparison constant changes with the shift, the comparison cannot
2076 // succeed (bits of the comparison constant cannot match the shifted value).
2077 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002078 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2079 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002080 "Expected icmp+shr simplify did not occur.");
2081
Sanjay Patel934738a2017-10-15 15:39:15 +00002082 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002083 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002084 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002085 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002086
Sanjay Patel934738a2017-10-15 15:39:15 +00002087 if (Shr->hasOneUse()) {
2088 // Canonicalize the shift into an 'and':
2089 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002090 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002091 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002092 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002093 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002094 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002095
2096 return nullptr;
2097}
2098
Sanjay Patel12a41052016-08-18 17:37:26 +00002099/// Fold icmp (udiv X, Y), C.
2100Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002101 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002102 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002103 const APInt *C2;
2104 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2105 return nullptr;
2106
Craig Topper29c282e2017-06-07 07:40:29 +00002107 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002108
2109 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2110 Value *Y = UDiv->getOperand(1);
2111 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002112 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002113 "icmp ugt X, UINT_MAX should have been simplified already.");
2114 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002115 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002116 }
2117
2118 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2119 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002120 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002121 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002122 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002123 }
2124
2125 return nullptr;
2126}
2127
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002128/// Fold icmp ({su}div X, Y), C.
2129Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2130 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002131 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002132 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002133 // Fold this div into the comparison, producing a range check.
2134 // Determine, based on the divide type, what the range is being
2135 // checked. If there is an overflow on the low or high side, remember
2136 // it, otherwise compute the range [low, hi) bounding the new value.
2137 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002138 const APInt *C2;
2139 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002140 return nullptr;
2141
Sanjay Patel16554142016-08-24 23:03:36 +00002142 // FIXME: If the operand types don't match the type of the divide
2143 // then don't attempt this transform. The code below doesn't have the
2144 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002145 // vice versa). This is because (x /s C2) <s C produces different
2146 // results than (x /s C2) <u C or (x /u C2) <s C or even
2147 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002148 // work. :( The if statement below tests that condition and bails
2149 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002150 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2151 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002152 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002153
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002154 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2155 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2156 // division-by-constant cases should be present, we can not assert that they
2157 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002158 if (C2->isNullValue() || C2->isOneValue() ||
2159 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002160 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002161
Craig Topper6e025a32017-10-01 23:53:54 +00002162 // Compute Prod = C * C2. We are essentially solving an equation of
2163 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002164 // By solving for X, we can turn this into a range check instead of computing
2165 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002166 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002167
Sanjay Patel541aef42016-08-31 21:57:21 +00002168 // Determine if the product overflows by seeing if the product is not equal to
2169 // the divide. Make sure we do the same kind of divide as in the LHS
2170 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002171 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002172
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002173 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002174
2175 // If the division is known to be exact, then there is no remainder from the
2176 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002177 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002178
2179 // Figure out the interval that is being checked. For example, a comparison
2180 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2181 // Compute this interval based on the constants involved and the signedness of
2182 // the compare/divide. This computes a half-open interval, keeping track of
2183 // whether either value in the interval overflows. After analysis each
2184 // overflow variable is set to 0 if it's corresponding bound variable is valid
2185 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2186 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002187 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002188
2189 if (!DivIsSigned) { // udiv
2190 // e.g. X/5 op 3 --> [15, 20)
2191 LoBound = Prod;
2192 HiOverflow = LoOverflow = ProdOV;
2193 if (!HiOverflow) {
2194 // If this is not an exact divide, then many values in the range collapse
2195 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002196 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002197 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002198 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002199 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002200 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002201 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002202 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002203 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002204 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2205 HiOverflow = LoOverflow = ProdOV;
2206 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002207 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002208 } else { // (X / pos) op neg
2209 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002210 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002211 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2212 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002213 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002214 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002215 }
2216 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002217 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002218 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002219 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002220 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002221 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002222 LoBound = RangeSize + 1;
2223 HiBound = -RangeSize;
2224 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002225 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002226 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002227 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002228 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002229 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002230 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002231 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2232 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002233 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002234 } else { // (X / neg) op neg
2235 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2236 LoOverflow = HiOverflow = ProdOV;
2237 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002238 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002239 }
2240
2241 // Dividing by a negative swaps the condition. LT <-> GT
2242 Pred = ICmpInst::getSwappedPredicate(Pred);
2243 }
2244
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002245 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002246 switch (Pred) {
2247 default: llvm_unreachable("Unhandled icmp opcode!");
2248 case ICmpInst::ICMP_EQ:
2249 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002250 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002251 if (HiOverflow)
2252 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002253 ICmpInst::ICMP_UGE, X,
2254 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002255 if (LoOverflow)
2256 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002257 ICmpInst::ICMP_ULT, X,
2258 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002259 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002260 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002261 case ICmpInst::ICMP_NE:
2262 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002263 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002264 if (HiOverflow)
2265 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002266 ICmpInst::ICMP_ULT, X,
2267 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002268 if (LoOverflow)
2269 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002270 ICmpInst::ICMP_UGE, X,
2271 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002272 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002273 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002274 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002275 case ICmpInst::ICMP_ULT:
2276 case ICmpInst::ICMP_SLT:
2277 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002278 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002279 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002280 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002281 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002282 case ICmpInst::ICMP_UGT:
2283 case ICmpInst::ICMP_SGT:
2284 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002285 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002286 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002287 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002288 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002289 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2290 ConstantInt::get(Div->getType(), HiBound));
2291 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2292 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002293 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002294
2295 return nullptr;
2296}
2297
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002298/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002299Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2300 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002301 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002302 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2303 ICmpInst::Predicate Pred = Cmp.getPredicate();
2304
2305 // The following transforms are only worth it if the only user of the subtract
2306 // is the icmp.
2307 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002308 return nullptr;
2309
Sanjay Patel886a5422016-09-15 18:05:17 +00002310 if (Sub->hasNoSignedWrap()) {
2311 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002312 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002313 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002314
Sanjay Patel886a5422016-09-15 18:05:17 +00002315 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002316 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002317 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2318
2319 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002320 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002321 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2322
2323 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002324 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002325 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2326 }
2327
2328 const APInt *C2;
2329 if (!match(X, m_APInt(C2)))
2330 return nullptr;
2331
2332 // C2 - Y <u C -> (Y | (C - 1)) == C2
2333 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002334 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2335 (*C2 & (C - 1)) == (C - 1))
2336 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002337
2338 // C2 - Y >u C -> (Y | C) != C2
2339 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002340 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2341 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002342
2343 return nullptr;
2344}
2345
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002346/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002347Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2348 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002349 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002350 Value *Y = Add->getOperand(1);
2351 const APInt *C2;
2352 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002353 return nullptr;
2354
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002355 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002356 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002357 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002358 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002359
Tim Northover12c1f762018-09-10 14:26:44 +00002360 if (!Add->hasOneUse())
2361 return nullptr;
2362
Sanjay Patel45b7e692017-02-12 16:40:30 +00002363 // If the add does not wrap, we can always adjust the compare by subtracting
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002364 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE
2365 // are canonicalized to SGT/SLT/UGT/ULT.
2366 if ((Add->hasNoSignedWrap() &&
2367 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) ||
2368 (Add->hasNoUnsignedWrap() &&
2369 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) {
Sanjay Patel45b7e692017-02-12 16:40:30 +00002370 bool Overflow;
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002371 APInt NewC =
2372 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002373 // If there is overflow, the result must be true or false.
2374 // TODO: Can we assert there is no overflow because InstSimplify always
2375 // handles those cases?
2376 if (!Overflow)
2377 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2378 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2379 }
2380
Craig Topper8ed1aa92017-10-03 05:31:07 +00002381 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002382 const APInt &Upper = CR.getUpper();
2383 const APInt &Lower = CR.getLower();
2384 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002385 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002386 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002387 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002388 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002389 } else {
2390 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002391 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002392 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002393 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002394 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002395
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002396 // X+C <u C2 -> (X & -C2) == C
2397 // iff C & (C2-1) == 0
2398 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002399 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2400 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002401 ConstantExpr::getNeg(cast<Constant>(Y)));
2402
2403 // X+C >u C2 -> (X & ~C2) != C
2404 // iff C & C2 == 0
2405 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002406 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2407 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002408 ConstantExpr::getNeg(cast<Constant>(Y)));
2409
Sanjay Patela3f4f082016-08-16 17:54:36 +00002410 return nullptr;
2411}
2412
Anna Thomasd67165c2017-06-23 13:41:45 +00002413bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2414 Value *&RHS, ConstantInt *&Less,
2415 ConstantInt *&Equal,
2416 ConstantInt *&Greater) {
2417 // TODO: Generalize this to work with other comparison idioms or ensure
2418 // they get canonicalized into this form.
2419
2420 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2421 // Greater), where Equal, Less and Greater are placeholders for any three
2422 // constants.
2423 ICmpInst::Predicate PredA, PredB;
2424 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2425 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2426 PredA == ICmpInst::ICMP_EQ &&
2427 match(SI->getFalseValue(),
2428 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2429 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2430 PredB == ICmpInst::ICMP_SLT) {
2431 return true;
2432 }
2433 return false;
2434}
2435
2436Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002437 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002438 ConstantInt *C) {
2439
2440 assert(C && "Cmp RHS should be a constant int!");
2441 // If we're testing a constant value against the result of a three way
2442 // comparison, the result can be expressed directly in terms of the
2443 // original values being compared. Note: We could possibly be more
2444 // aggressive here and remove the hasOneUse test. The original select is
2445 // really likely to simplify or sink when we remove a test of the result.
2446 Value *OrigLHS, *OrigRHS;
2447 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2448 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002449 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2450 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002451 assert(C1LessThan && C2Equal && C3GreaterThan);
2452
2453 bool TrueWhenLessThan =
2454 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2455 ->isAllOnesValue();
2456 bool TrueWhenEqual =
2457 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2458 ->isAllOnesValue();
2459 bool TrueWhenGreaterThan =
2460 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2461 ->isAllOnesValue();
2462
2463 // This generates the new instruction that will replace the original Cmp
2464 // Instruction. Instead of enumerating the various combinations when
2465 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2466 // false, we rely on chaining of ORs and future passes of InstCombine to
2467 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2468
2469 // When none of the three constants satisfy the predicate for the RHS (C),
2470 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002471 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002472 if (TrueWhenLessThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002473 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002474 if (TrueWhenEqual)
Craig Topperbb4069e2017-07-07 23:16:26 +00002475 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002476 if (TrueWhenGreaterThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002477 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002478
2479 return replaceInstUsesWith(Cmp, Cond);
2480 }
2481 return nullptr;
2482}
2483
Daniel Neilson901acfa2018-04-03 17:26:20 +00002484Instruction *InstCombiner::foldICmpBitCastConstant(ICmpInst &Cmp,
2485 BitCastInst *Bitcast,
2486 const APInt &C) {
2487 // Folding: icmp <pred> iN X, C
2488 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2489 // and C is a splat of a K-bit pattern
2490 // and SC is a constant vector = <C', C', C', ..., C'>
2491 // Into:
2492 // %E = extractelement <M x iK> %vec, i32 C'
2493 // icmp <pred> iK %E, trunc(C)
2494 if (!Bitcast->getType()->isIntegerTy() ||
2495 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2496 return nullptr;
2497
2498 Value *BCIOp = Bitcast->getOperand(0);
2499 Value *Vec = nullptr; // 1st vector arg of the shufflevector
2500 Constant *Mask = nullptr; // Mask arg of the shufflevector
2501 if (match(BCIOp,
2502 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2503 // Check whether every element of Mask is the same constant
2504 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
2505 auto *VecTy = cast<VectorType>(BCIOp->getType());
2506 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
2507 auto Pred = Cmp.getPredicate();
2508 if (C.isSplat(EltTy->getBitWidth())) {
2509 // Fold the icmp based on the value of C
2510 // If C is M copies of an iK sized bit pattern,
2511 // then:
2512 // => %E = extractelement <N x iK> %vec, i32 Elem
2513 // icmp <pred> iK %SplatVal, <pattern>
2514 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
2515 Value *NewC = ConstantInt::get(EltTy, C.trunc(EltTy->getBitWidth()));
2516 return new ICmpInst(Pred, Extract, NewC);
2517 }
2518 }
2519 }
2520 return nullptr;
2521}
2522
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002523/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2524/// where X is some kind of instruction.
2525Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002526 const APInt *C;
2527 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002528 return nullptr;
2529
Craig Toppera94069f2017-08-23 05:46:08 +00002530 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002531 switch (BO->getOpcode()) {
2532 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002533 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002534 return I;
2535 break;
2536 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002537 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002538 return I;
2539 break;
2540 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002541 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002542 return I;
2543 break;
2544 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002545 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002546 return I;
2547 break;
2548 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002549 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002550 return I;
2551 break;
2552 case Instruction::LShr:
2553 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002554 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002555 return I;
2556 break;
2557 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002558 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002559 return I;
2560 LLVM_FALLTHROUGH;
2561 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002562 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002563 return I;
2564 break;
2565 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002566 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002567 return I;
2568 break;
2569 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002570 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002571 return I;
2572 break;
2573 default:
2574 break;
2575 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002576 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002577 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002578 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002579 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002580
Anna Thomasd67165c2017-06-23 13:41:45 +00002581 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002582
2583 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2584 // For now, we only support constant integers while folding the
2585 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2586 // similar to the cases handled by binary ops above.
2587 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2588 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002589 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002590 }
2591
2592 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002593 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002594 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002595 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002596
Daniel Neilson901acfa2018-04-03 17:26:20 +00002597 if (auto *BCI = dyn_cast<BitCastInst>(Cmp.getOperand(0))) {
2598 if (Instruction *I = foldICmpBitCastConstant(Cmp, BCI, *C))
2599 return I;
2600 }
2601
Craig Topper8ed1aa92017-10-03 05:31:07 +00002602 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002603 return I;
2604
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002605 return nullptr;
2606}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002607
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002608/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2609/// icmp eq/ne BO, C.
2610Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2611 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002612 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002613 // TODO: Some of these folds could work with arbitrary constants, but this
2614 // function is limited to scalar and vector splat constants.
2615 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002616 return nullptr;
2617
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002618 ICmpInst::Predicate Pred = Cmp.getPredicate();
2619 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2620 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002621 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002622
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002623 switch (BO->getOpcode()) {
2624 case Instruction::SRem:
2625 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002626 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002627 const APInt *BOC;
2628 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002629 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002630 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002631 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002632 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002633 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002634 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002635 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002636 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002637 const APInt *BOC;
2638 if (match(BOp1, m_APInt(BOC))) {
2639 if (BO->hasOneUse()) {
2640 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002641 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002642 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002643 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002644 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2645 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002646 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002647 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002648 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002649 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002650 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002651 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002652 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002653 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002654 }
2655 }
2656 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002657 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002658 case Instruction::Xor:
2659 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002660 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002661 // For the xor case, we can xor two constants together, eliminating
2662 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002663 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002664 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002665 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002666 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002667 }
2668 }
2669 break;
2670 case Instruction::Sub:
2671 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002672 const APInt *BOC;
2673 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002674 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002675 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002676 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002677 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002678 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002679 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002680 }
2681 }
2682 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002683 case Instruction::Or: {
2684 const APInt *BOC;
2685 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002686 // Comparing if all bits outside of a constant mask are set?
2687 // Replace (X | C) == -1 with (X & ~C) == ~C.
2688 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002689 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002690 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002691 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002692 }
2693 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002694 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002695 case Instruction::And: {
2696 const APInt *BOC;
2697 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002698 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002699 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002700 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002701 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002702
2703 // Don't perform the following transforms if the AND has multiple uses
2704 if (!BO->hasOneUse())
2705 break;
2706
2707 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0
Craig Topperbcfd2d12017-04-20 16:56:25 +00002708 if (BOC->isSignMask()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002709 Constant *Zero = Constant::getNullValue(BOp0->getType());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002710 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
2711 return new ICmpInst(NewPred, BOp0, Zero);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002712 }
2713
2714 // ((X & ~7) == 0) --> X < 8
Craig Topper8ed1aa92017-10-03 05:31:07 +00002715 if (C.isNullValue() && (~(*BOC) + 1).isPowerOf2()) {
Sanjay Pateld938e882016-08-04 20:05:02 +00002716 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002717 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
2718 return new ICmpInst(NewPred, BOp0, NegBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002719 }
2720 }
2721 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002722 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002723 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002724 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002725 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002726 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002727 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002728 // General case : (mul X, C) != 0 iff X != 0
2729 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002730 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002731 }
2732 }
2733 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002734 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002735 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002736 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002737 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2738 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002739 }
2740 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002741 default:
2742 break;
2743 }
2744 return nullptr;
2745}
2746
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002747/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2748Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002749 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002750 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0));
2751 if (!II || !Cmp.isEquality())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002752 return nullptr;
2753
Sanjay Patelb51e0722017-07-02 16:05:11 +00002754 // Handle icmp {eq|ne} <intrinsic>, Constant.
2755 Type *Ty = II->getType();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002756 switch (II->getIntrinsicID()) {
2757 case Intrinsic::bswap:
2758 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002759 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002760 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002761 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002762
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002763 case Intrinsic::ctlz:
2764 case Intrinsic::cttz:
Amaury Sechet6bea6742016-08-04 05:27:20 +00002765 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002766 if (C == C.getBitWidth()) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002767 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002768 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002769 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002770 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002771 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002772 break;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002773
Amaury Sechet6bea6742016-08-04 05:27:20 +00002774 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002775 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002776 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002777 bool IsZero = C.isNullValue();
2778 if (IsZero || C == C.getBitWidth()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002779 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002780 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002781 auto *NewOp =
2782 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002783 Cmp.setOperand(1, NewOp);
2784 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002785 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002786 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002787 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002788 default:
2789 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002790 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002791
Craig Topperf40110f2014-04-25 05:29:35 +00002792 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002793}
2794
Sanjay Patel10494b22016-09-16 16:10:22 +00002795/// Handle icmp with constant (but not simple integer constant) RHS.
2796Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
2797 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2798 Constant *RHSC = dyn_cast<Constant>(Op1);
2799 Instruction *LHSI = dyn_cast<Instruction>(Op0);
2800 if (!RHSC || !LHSI)
2801 return nullptr;
2802
2803 switch (LHSI->getOpcode()) {
2804 case Instruction::GetElementPtr:
2805 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
2806 if (RHSC->isNullValue() &&
2807 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
2808 return new ICmpInst(
2809 I.getPredicate(), LHSI->getOperand(0),
2810 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2811 break;
2812 case Instruction::PHI:
2813 // Only fold icmp into the PHI if the phi and icmp are in the same
2814 // block. If in the same block, we're encouraging jump threading. If
2815 // not, we are just pessimizing the code by making an i1 phi.
2816 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00002817 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00002818 return NV;
2819 break;
2820 case Instruction::Select: {
2821 // If either operand of the select is a constant, we can fold the
2822 // comparison into the select arms, which will cause one to be
2823 // constant folded and the select turned into a bitwise or.
2824 Value *Op1 = nullptr, *Op2 = nullptr;
2825 ConstantInt *CI = nullptr;
2826 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
2827 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2828 CI = dyn_cast<ConstantInt>(Op1);
2829 }
2830 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
2831 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2832 CI = dyn_cast<ConstantInt>(Op2);
2833 }
2834
2835 // We only want to perform this transformation if it will not lead to
2836 // additional code. This is true if either both sides of the select
2837 // fold to a constant (in which case the icmp is replaced with a select
2838 // which will usually simplify) or this is the only user of the
2839 // select (in which case we are trading a select+icmp for a simpler
2840 // select+icmp) or all uses of the select can be replaced based on
2841 // dominance information ("Global cases").
2842 bool Transform = false;
2843 if (Op1 && Op2)
2844 Transform = true;
2845 else if (Op1 || Op2) {
2846 // Local case
2847 if (LHSI->hasOneUse())
2848 Transform = true;
2849 // Global cases
2850 else if (CI && !CI->isZero())
2851 // When Op1 is constant try replacing select with second operand.
2852 // Otherwise Op2 is constant and try replacing select with first
2853 // operand.
2854 Transform =
2855 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
2856 }
2857 if (Transform) {
2858 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00002859 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
2860 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002861 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00002862 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
2863 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002864 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
2865 }
2866 break;
2867 }
2868 case Instruction::IntToPtr:
2869 // icmp pred inttoptr(X), null -> icmp pred X, 0
2870 if (RHSC->isNullValue() &&
2871 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
2872 return new ICmpInst(
2873 I.getPredicate(), LHSI->getOperand(0),
2874 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2875 break;
2876
2877 case Instruction::Load:
2878 // Try to optimize things like "A[i] > 4" to index computations.
2879 if (GetElementPtrInst *GEP =
2880 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
2881 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
2882 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
2883 !cast<LoadInst>(LHSI)->isVolatile())
2884 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
2885 return Res;
2886 }
2887 break;
2888 }
2889
2890 return nullptr;
2891}
2892
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002893/// Some comparisons can be simplified.
2894/// In this case, we are looking for comparisons that look like
2895/// a check for a lossy truncation.
2896/// Folds:
Roman Lebedev183a4652018-09-19 13:35:27 +00002897/// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask
2898/// Where Mask is some pattern that produces all-ones in low bits:
2899/// (-1 >> y)
Roman Lebedevf50023d2018-09-19 13:35:46 +00002900/// ((-1 << y) >> y) <- non-canonical, has extra uses
Roman Lebedev183a4652018-09-19 13:35:27 +00002901/// ~(-1 << y)
Roman Lebedevca2bdb02018-09-19 13:35:40 +00002902/// ((1 << y) + (-1)) <- non-canonical, has extra uses
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002903/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00002904/// For some predicates, the operands are commutative.
2905/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002906static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
2907 InstCombiner::BuilderTy &Builder) {
2908 ICmpInst::Predicate SrcPred;
Roman Lebedevf50023d2018-09-19 13:35:46 +00002909 Value *X, *M, *Y;
2910 auto m_VariableMask = m_CombineOr(
2911 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())),
2912 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())),
2913 m_CombineOr(m_LShr(m_AllOnes(), m_Value()),
2914 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y))));
Roman Lebedev183a4652018-09-19 13:35:27 +00002915 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask());
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002916 if (!match(&I, m_c_ICmp(SrcPred,
2917 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
2918 m_Deferred(X))))
2919 return nullptr;
2920
2921 ICmpInst::Predicate DstPred;
2922 switch (SrcPred) {
2923 case ICmpInst::Predicate::ICMP_EQ:
2924 // x & (-1 >> y) == x -> x u<= (-1 >> y)
2925 DstPred = ICmpInst::Predicate::ICMP_ULE;
2926 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00002927 case ICmpInst::Predicate::ICMP_NE:
2928 // x & (-1 >> y) != x -> x u> (-1 >> y)
2929 DstPred = ICmpInst::Predicate::ICMP_UGT;
2930 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00002931 case ICmpInst::Predicate::ICMP_UGT:
2932 // x u> x & (-1 >> y) -> x u> (-1 >> y)
2933 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
2934 DstPred = ICmpInst::Predicate::ICMP_UGT;
2935 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00002936 case ICmpInst::Predicate::ICMP_UGE:
2937 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
2938 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
2939 DstPred = ICmpInst::Predicate::ICMP_ULE;
2940 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00002941 case ICmpInst::Predicate::ICMP_ULT:
2942 // x & (-1 >> y) u< x -> x u> (-1 >> y)
2943 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
2944 DstPred = ICmpInst::Predicate::ICMP_UGT;
2945 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00002946 case ICmpInst::Predicate::ICMP_ULE:
2947 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
2948 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
2949 DstPred = ICmpInst::Predicate::ICMP_ULE;
2950 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00002951 case ICmpInst::Predicate::ICMP_SGT:
2952 // x s> x & (-1 >> y) -> x s> (-1 >> y)
2953 if (X != I.getOperand(0)) // X must be on LHS of comparison!
2954 return nullptr; // Ignore the other case.
2955 DstPred = ICmpInst::Predicate::ICMP_SGT;
2956 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00002957 case ICmpInst::Predicate::ICMP_SGE:
2958 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
2959 if (X != I.getOperand(1)) // X must be on RHS of comparison!
2960 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00002961 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
2962 return nullptr;
Roman Lebedevf1442612018-07-14 20:08:37 +00002963 DstPred = ICmpInst::Predicate::ICMP_SLE;
2964 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00002965 case ICmpInst::Predicate::ICMP_SLT:
2966 // x & (-1 >> y) s< x -> x s> (-1 >> y)
2967 if (X != I.getOperand(1)) // X must be on RHS of comparison!
2968 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00002969 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
2970 return nullptr;
Roman Lebedevb972fc32018-07-14 20:08:47 +00002971 DstPred = ICmpInst::Predicate::ICMP_SGT;
2972 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00002973 case ICmpInst::Predicate::ICMP_SLE:
2974 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
2975 if (X != I.getOperand(0)) // X must be on LHS of comparison!
2976 return nullptr; // Ignore the other case.
2977 DstPred = ICmpInst::Predicate::ICMP_SLE;
2978 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002979 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00002980 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002981 }
2982
2983 return Builder.CreateICmp(DstPred, X, M);
2984}
2985
Roman Lebedev3cb87e92018-07-18 10:55:17 +00002986/// Some comparisons can be simplified.
2987/// In this case, we are looking for comparisons that look like
2988/// a check for a lossy signed truncation.
2989/// Folds: (MaskedBits is a constant.)
2990/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
2991/// Into:
2992/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
2993/// Where KeptBits = bitwidth(%x) - MaskedBits
2994static Value *
2995foldICmpWithTruncSignExtendedVal(ICmpInst &I,
2996 InstCombiner::BuilderTy &Builder) {
2997 ICmpInst::Predicate SrcPred;
2998 Value *X;
2999 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
3000 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
3001 if (!match(&I, m_c_ICmp(SrcPred,
3002 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
3003 m_APInt(C1))),
3004 m_Deferred(X))))
3005 return nullptr;
3006
3007 // Potential handling of non-splats: for each element:
3008 // * if both are undef, replace with constant 0.
3009 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
3010 // * if both are not undef, and are different, bailout.
3011 // * else, only one is undef, then pick the non-undef one.
3012
3013 // The shift amount must be equal.
3014 if (*C0 != *C1)
3015 return nullptr;
3016 const APInt &MaskedBits = *C0;
3017 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
3018
3019 ICmpInst::Predicate DstPred;
3020 switch (SrcPred) {
3021 case ICmpInst::Predicate::ICMP_EQ:
3022 // ((%x << MaskedBits) a>> MaskedBits) == %x
3023 // =>
3024 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
3025 DstPred = ICmpInst::Predicate::ICMP_ULT;
3026 break;
3027 case ICmpInst::Predicate::ICMP_NE:
3028 // ((%x << MaskedBits) a>> MaskedBits) != %x
3029 // =>
3030 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
3031 DstPred = ICmpInst::Predicate::ICMP_UGE;
3032 break;
3033 // FIXME: are more folds possible?
3034 default:
3035 return nullptr;
3036 }
3037
3038 auto *XType = X->getType();
3039 const unsigned XBitWidth = XType->getScalarSizeInBits();
3040 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3041 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3042
3043 // KeptBits = bitwidth(%x) - MaskedBits
3044 const APInt KeptBits = BitWidth - MaskedBits;
3045 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3046 // ICmpCst = (1 << KeptBits)
3047 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3048 assert(ICmpCst.isPowerOf2());
3049 // AddCst = (1 << (KeptBits-1))
3050 const APInt AddCst = ICmpCst.lshr(1);
3051 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3052
3053 // T0 = add %x, AddCst
3054 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3055 // T1 = T0 DstPred ICmpCst
3056 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3057
3058 return T1;
3059}
3060
Sanjay Patel10494b22016-09-16 16:10:22 +00003061/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003062/// TODO: A large part of this logic is duplicated in InstSimplify's
3063/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3064/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00003065Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
3066 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3067
3068 // Special logic for binary operators.
3069 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3070 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3071 if (!BO0 && !BO1)
3072 return nullptr;
3073
Sanjay Patel2a062632017-05-08 16:33:42 +00003074 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel1cf07342018-09-11 22:40:20 +00003075 Value *X;
3076
3077 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare.
3078 // (Op1 + X) <u Op1 --> ~Op1 <u X
3079 // Op0 >u (Op0 + X) --> X >u ~Op0
3080 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) &&
3081 Pred == ICmpInst::ICMP_ULT)
3082 return new ICmpInst(Pred, Builder.CreateNot(Op1), X);
3083 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) &&
3084 Pred == ICmpInst::ICMP_UGT)
3085 return new ICmpInst(Pred, X, Builder.CreateNot(Op0));
3086
Sanjay Patel10494b22016-09-16 16:10:22 +00003087 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3088 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3089 NoOp0WrapProblem =
3090 ICmpInst::isEquality(Pred) ||
3091 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3092 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3093 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3094 NoOp1WrapProblem =
3095 ICmpInst::isEquality(Pred) ||
3096 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3097 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3098
3099 // Analyze the case when either Op0 or Op1 is an add instruction.
3100 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3101 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3102 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3103 A = BO0->getOperand(0);
3104 B = BO0->getOperand(1);
3105 }
3106 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3107 C = BO1->getOperand(0);
3108 D = BO1->getOperand(1);
3109 }
3110
Sanjay Patel10494b22016-09-16 16:10:22 +00003111 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
3112 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3113 return new ICmpInst(Pred, A == Op1 ? B : A,
3114 Constant::getNullValue(Op1->getType()));
3115
3116 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
3117 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3118 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3119 C == Op0 ? D : C);
3120
3121 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
3122 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
3123 NoOp1WrapProblem &&
3124 // Try not to increase register pressure.
3125 BO0->hasOneUse() && BO1->hasOneUse()) {
3126 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3127 Value *Y, *Z;
3128 if (A == C) {
3129 // C + B == C + D -> B == D
3130 Y = B;
3131 Z = D;
3132 } else if (A == D) {
3133 // D + B == C + D -> B == C
3134 Y = B;
3135 Z = C;
3136 } else if (B == C) {
3137 // A + C == C + D -> A == D
3138 Y = A;
3139 Z = D;
3140 } else {
3141 assert(B == D);
3142 // A + D == C + D -> A == C
3143 Y = A;
3144 Z = C;
3145 }
3146 return new ICmpInst(Pred, Y, Z);
3147 }
3148
3149 // icmp slt (X + -1), Y -> icmp sle X, Y
3150 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3151 match(B, m_AllOnes()))
3152 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3153
3154 // icmp sge (X + -1), Y -> icmp sgt X, Y
3155 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3156 match(B, m_AllOnes()))
3157 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3158
3159 // icmp sle (X + 1), Y -> icmp slt X, Y
3160 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3161 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3162
3163 // icmp sgt (X + 1), Y -> icmp sge X, Y
3164 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3165 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3166
3167 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3168 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3169 match(D, m_AllOnes()))
3170 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3171
3172 // icmp sle X, (Y + -1) -> icmp slt X, Y
3173 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3174 match(D, m_AllOnes()))
3175 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3176
3177 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3178 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3179 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3180
3181 // icmp slt X, (Y + 1) -> icmp sle X, Y
3182 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3183 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3184
Sanjay Patel40f40172017-01-13 23:25:46 +00003185 // TODO: The subtraction-related identities shown below also hold, but
3186 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3187 // wouldn't happen even if they were implemented.
3188 //
3189 // icmp ult (X - 1), Y -> icmp ule X, Y
3190 // icmp uge (X - 1), Y -> icmp ugt X, Y
3191 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3192 // icmp ule X, (Y - 1) -> icmp ult X, Y
3193
3194 // icmp ule (X + 1), Y -> icmp ult X, Y
3195 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3196 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3197
3198 // icmp ugt (X + 1), Y -> icmp uge X, Y
3199 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3200 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3201
3202 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3203 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3204 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3205
3206 // icmp ult X, (Y + 1) -> icmp ule X, Y
3207 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3208 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3209
Sanjay Patel10494b22016-09-16 16:10:22 +00003210 // if C1 has greater magnitude than C2:
3211 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3212 // s.t. C3 = C1 - C2
3213 //
3214 // if C2 has greater magnitude than C1:
3215 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3216 // s.t. C3 = C2 - C1
3217 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3218 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3219 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3220 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3221 const APInt &AP1 = C1->getValue();
3222 const APInt &AP2 = C2->getValue();
3223 if (AP1.isNegative() == AP2.isNegative()) {
3224 APInt AP1Abs = C1->getValue().abs();
3225 APInt AP2Abs = C2->getValue().abs();
3226 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003227 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3228 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003229 return new ICmpInst(Pred, NewAdd, C);
3230 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003231 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3232 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003233 return new ICmpInst(Pred, A, NewAdd);
3234 }
3235 }
3236 }
3237
3238 // Analyze the case when either Op0 or Op1 is a sub instruction.
3239 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3240 A = nullptr;
3241 B = nullptr;
3242 C = nullptr;
3243 D = nullptr;
3244 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3245 A = BO0->getOperand(0);
3246 B = BO0->getOperand(1);
3247 }
3248 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3249 C = BO1->getOperand(0);
3250 D = BO1->getOperand(1);
3251 }
3252
3253 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3254 if (A == Op1 && NoOp0WrapProblem)
3255 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003256 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3257 if (C == Op0 && NoOp1WrapProblem)
3258 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3259
Sanjay Patelcbb04502018-04-02 20:37:40 +00003260 // (A - B) >u A --> A <u B
3261 if (A == Op1 && Pred == ICmpInst::ICMP_UGT)
3262 return new ICmpInst(ICmpInst::ICMP_ULT, A, B);
3263 // C <u (C - D) --> C <u D
3264 if (C == Op0 && Pred == ICmpInst::ICMP_ULT)
3265 return new ICmpInst(ICmpInst::ICMP_ULT, C, D);
3266
Sanjay Patel10494b22016-09-16 16:10:22 +00003267 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3268 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3269 // Try not to increase register pressure.
3270 BO0->hasOneUse() && BO1->hasOneUse())
3271 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003272 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3273 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3274 // Try not to increase register pressure.
3275 BO0->hasOneUse() && BO1->hasOneUse())
3276 return new ICmpInst(Pred, D, B);
3277
3278 // icmp (0-X) < cst --> x > -cst
3279 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3280 Value *X;
3281 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003282 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3283 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003284 return new ICmpInst(I.getSwappedPredicate(), X,
3285 ConstantExpr::getNeg(RHSC));
3286 }
3287
3288 BinaryOperator *SRem = nullptr;
3289 // icmp (srem X, Y), Y
3290 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3291 SRem = BO0;
3292 // icmp Y, (srem X, Y)
3293 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3294 Op0 == BO1->getOperand(1))
3295 SRem = BO1;
3296 if (SRem) {
3297 // We don't check hasOneUse to avoid increasing register pressure because
3298 // the value we use is the same value this instruction was already using.
3299 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3300 default:
3301 break;
3302 case ICmpInst::ICMP_EQ:
3303 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3304 case ICmpInst::ICMP_NE:
3305 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3306 case ICmpInst::ICMP_SGT:
3307 case ICmpInst::ICMP_SGE:
3308 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3309 Constant::getAllOnesValue(SRem->getType()));
3310 case ICmpInst::ICMP_SLT:
3311 case ICmpInst::ICMP_SLE:
3312 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3313 Constant::getNullValue(SRem->getType()));
3314 }
3315 }
3316
3317 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3318 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3319 switch (BO0->getOpcode()) {
3320 default:
3321 break;
3322 case Instruction::Add:
3323 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003324 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003325 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003326 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003327
3328 const APInt *C;
3329 if (match(BO0->getOperand(1), m_APInt(C))) {
3330 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3331 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003332 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003333 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003334 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003335 }
3336
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003337 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3338 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003339 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003340 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003341 NewPred = I.getSwappedPredicate(NewPred);
3342 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003343 }
3344 }
3345 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003346 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003347 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003348 if (!I.isEquality())
3349 break;
3350
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003351 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003352 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3353 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003354 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3355 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003356 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003357 Constant *Mask = ConstantInt::get(
3358 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003359 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003360 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3361 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003362 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003363 }
Sanjay Patel51506122017-05-25 14:13:57 +00003364 // If there are no trailing zeros in the multiplier, just eliminate
3365 // the multiplies (no masking is needed):
3366 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3367 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003368 }
3369 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003370 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003371 case Instruction::UDiv:
3372 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003373 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003374 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003375 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3376
Sanjay Patel10494b22016-09-16 16:10:22 +00003377 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003378 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3379 break;
3380 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3381
Sanjay Patel10494b22016-09-16 16:10:22 +00003382 case Instruction::AShr:
3383 if (!BO0->isExact() || !BO1->isExact())
3384 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003385 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003386
Sanjay Patel10494b22016-09-16 16:10:22 +00003387 case Instruction::Shl: {
3388 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3389 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3390 if (!NUW && !NSW)
3391 break;
3392 if (!NSW && I.isSigned())
3393 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003394 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003395 }
3396 }
3397 }
3398
3399 if (BO0) {
3400 // Transform A & (L - 1) `ult` L --> L != 0
3401 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003402 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003403
Sanjay Patel2a062632017-05-08 16:33:42 +00003404 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003405 auto *Zero = Constant::getNullValue(BO0->getType());
3406 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3407 }
3408 }
3409
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003410 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3411 return replaceInstUsesWith(I, V);
3412
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003413 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
3414 return replaceInstUsesWith(I, V);
3415
Sanjay Patel10494b22016-09-16 16:10:22 +00003416 return nullptr;
3417}
3418
Sanjay Pateldd46b522016-12-19 17:32:37 +00003419/// Fold icmp Pred min|max(X, Y), X.
3420static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003421 ICmpInst::Predicate Pred = Cmp.getPredicate();
3422 Value *Op0 = Cmp.getOperand(0);
3423 Value *X = Cmp.getOperand(1);
3424
Sanjay Pateldd46b522016-12-19 17:32:37 +00003425 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003426 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003427 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3428 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3429 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003430 std::swap(Op0, X);
3431 Pred = Cmp.getSwappedPredicate();
3432 }
3433
3434 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003435 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003436 // smin(X, Y) == X --> X s<= Y
3437 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003438 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3439 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3440
Sanjay Pateldd46b522016-12-19 17:32:37 +00003441 // smin(X, Y) != X --> X s> Y
3442 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003443 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3444 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3445
3446 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003447 // smin(X, Y) s<= X --> true
3448 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003449 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003450 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003451
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003452 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003453 // smax(X, Y) == X --> X s>= Y
3454 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003455 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3456 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003457
Sanjay Pateldd46b522016-12-19 17:32:37 +00003458 // smax(X, Y) != X --> X s< Y
3459 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003460 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3461 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003462
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003463 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003464 // smax(X, Y) s>= X --> true
3465 // smax(X, Y) s< X --> false
3466 return nullptr;
3467 }
3468
3469 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3470 // umin(X, Y) == X --> X u<= Y
3471 // umin(X, Y) u>= X --> X u<= Y
3472 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3473 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3474
3475 // umin(X, Y) != X --> X u> Y
3476 // umin(X, Y) u< X --> X u> Y
3477 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3478 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3479
3480 // These cases should be handled in InstSimplify:
3481 // umin(X, Y) u<= X --> true
3482 // umin(X, Y) u> X --> false
3483 return nullptr;
3484 }
3485
3486 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3487 // umax(X, Y) == X --> X u>= Y
3488 // umax(X, Y) u<= X --> X u>= Y
3489 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3490 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3491
3492 // umax(X, Y) != X --> X u< Y
3493 // umax(X, Y) u> X --> X u< Y
3494 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3495 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3496
3497 // These cases should be handled in InstSimplify:
3498 // umax(X, Y) u>= X --> true
3499 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003500 return nullptr;
3501 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003502
Sanjay Pateld6406412016-12-15 19:13:37 +00003503 return nullptr;
3504}
3505
Sanjay Patel10494b22016-09-16 16:10:22 +00003506Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3507 if (!I.isEquality())
3508 return nullptr;
3509
3510 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003511 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003512 Value *A, *B, *C, *D;
3513 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3514 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3515 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003516 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003517 }
3518
3519 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3520 // A^c1 == C^c2 --> A == C^(c1^c2)
3521 ConstantInt *C1, *C2;
3522 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3523 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003524 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3525 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003526 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003527 }
3528
3529 // A^B == A^D -> B == D
3530 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003531 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003532 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003533 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003534 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003535 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003536 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003537 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003538 }
3539 }
3540
3541 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3542 // A == (A^B) -> B == 0
3543 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003544 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003545 }
3546
3547 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3548 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3549 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3550 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3551
3552 if (A == C) {
3553 X = B;
3554 Y = D;
3555 Z = A;
3556 } else if (A == D) {
3557 X = B;
3558 Y = C;
3559 Z = A;
3560 } else if (B == C) {
3561 X = A;
3562 Y = D;
3563 Z = B;
3564 } else if (B == D) {
3565 X = A;
3566 Y = C;
3567 Z = B;
3568 }
3569
3570 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003571 Op1 = Builder.CreateXor(X, Y);
3572 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003573 I.setOperand(0, Op1);
3574 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3575 return &I;
3576 }
3577 }
3578
3579 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3580 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3581 ConstantInt *Cst1;
3582 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3583 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3584 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3585 match(Op1, m_ZExt(m_Value(A))))) {
3586 APInt Pow2 = Cst1->getValue() + 1;
3587 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3588 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003589 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003590 }
3591
3592 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3593 // For lshr and ashr pairs.
3594 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3595 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3596 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3597 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3598 unsigned TypeBits = Cst1->getBitWidth();
3599 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3600 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003601 ICmpInst::Predicate NewPred =
3602 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003603 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003604 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003605 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003606 }
3607 }
3608
3609 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3610 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3611 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3612 unsigned TypeBits = Cst1->getBitWidth();
3613 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3614 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003615 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003616 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003617 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003618 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003619 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003620 }
3621 }
3622
3623 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3624 // "icmp (and X, mask), cst"
3625 uint64_t ShAmt = 0;
3626 if (Op0->hasOneUse() &&
3627 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3628 match(Op1, m_ConstantInt(Cst1)) &&
3629 // Only do this when A has multiple uses. This is most important to do
3630 // when it exposes other optimizations.
3631 !A->hasOneUse()) {
3632 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3633
3634 if (ShAmt < ASize) {
3635 APInt MaskV =
3636 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3637 MaskV <<= ShAmt;
3638
3639 APInt CmpV = Cst1->getValue().zext(ASize);
3640 CmpV <<= ShAmt;
3641
Craig Topperbb4069e2017-07-07 23:16:26 +00003642 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
3643 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00003644 }
3645 }
3646
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003647 // If both operands are byte-swapped or bit-reversed, just compare the
3648 // original values.
3649 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
3650 // and handle more intrinsics.
3651 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00003652 (match(Op0, m_BitReverse(m_Value(A))) &&
3653 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003654 return new ICmpInst(Pred, A, B);
3655
Sanjay Patel10494b22016-09-16 16:10:22 +00003656 return nullptr;
3657}
3658
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003659/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3660/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003661Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003662 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003663 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003664 Type *SrcTy = LHSCIOp->getType();
3665 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003666 Value *RHSCIOp;
3667
Jim Grosbach129c52a2011-09-30 18:09:53 +00003668 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003669 // integer type is the same size as the pointer type.
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003670 const auto& CompatibleSizes = [&](Type* SrcTy, Type* DestTy) -> bool {
3671 if (isa<VectorType>(SrcTy)) {
3672 SrcTy = cast<VectorType>(SrcTy)->getElementType();
3673 DestTy = cast<VectorType>(DestTy)->getElementType();
3674 }
3675 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
3676 };
Mehdi Aminia28d91d2015-03-10 02:37:25 +00003677 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003678 CompatibleSizes(SrcTy, DestTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +00003679 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003680 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00003681 Value *RHSCIOp = RHSC->getOperand(0);
3682 if (RHSCIOp->getType()->getPointerAddressSpace() ==
3683 LHSCIOp->getType()->getPointerAddressSpace()) {
3684 RHSOp = RHSC->getOperand(0);
3685 // If the pointer types don't match, insert a bitcast.
3686 if (LHSCIOp->getType() != RHSOp->getType())
Craig Topperbb4069e2017-07-07 23:16:26 +00003687 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType());
Michael Liaod266b922015-02-13 04:51:26 +00003688 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003689 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003690 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003691 }
Chris Lattner2188e402010-01-04 07:37:31 +00003692
3693 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003694 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003695 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003696
Chris Lattner2188e402010-01-04 07:37:31 +00003697 // The code below only handles extension cast instructions, so far.
3698 // Enforce this.
3699 if (LHSCI->getOpcode() != Instruction::ZExt &&
3700 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00003701 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003702
3703 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003704 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00003705
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003706 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003707 // Not an extension from the same type?
3708 RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003709 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00003710 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00003711
Chris Lattner2188e402010-01-04 07:37:31 +00003712 // If the signedness of the two casts doesn't agree (i.e. one is a sext
3713 // and the other is a zext), then we can't handle this.
3714 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00003715 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003716
3717 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003718 if (ICmp.isEquality())
3719 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003720
3721 // A signed comparison of sign extended values simplifies into a
3722 // signed comparison.
3723 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003724 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003725
3726 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003727 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003728 }
3729
Sanjay Patel4c204232016-06-04 20:39:22 +00003730 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003731 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
3732 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00003733 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003734
3735 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003736 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003737 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003738 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00003739
3740 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003741 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00003742 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003743 if (ICmp.isEquality())
3744 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003745
3746 // A signed comparison of sign extended values simplifies into a
3747 // signed comparison.
3748 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003749 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003750
3751 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003752 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003753 }
3754
Sanjay Patel6a333c32016-06-06 16:56:57 +00003755 // The re-extended constant changed, partly changed (in the case of a vector),
3756 // or could not be determined to be equal (in the case of a constant
3757 // expression), so the constant cannot be represented in the shorter type.
3758 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003759 // All the cases that fold to true or false will have already been handled
3760 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00003761
Sanjay Patel6a333c32016-06-06 16:56:57 +00003762 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00003763 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003764
3765 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
3766 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003767
3768 // We're performing an unsigned comp with a sign extended value.
3769 // This is true if the input is >= 0. [aka >s -1]
3770 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Craig Topperbb4069e2017-07-07 23:16:26 +00003771 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00003772
3773 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003774 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
3775 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00003776
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003777 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00003778 return BinaryOperator::CreateNot(Result);
3779}
3780
Sanjoy Dasb0984472015-04-08 04:27:22 +00003781bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS,
3782 Value *RHS, Instruction &OrigI,
3783 Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00003784 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
3785 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003786
3787 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) {
3788 Result = OpResult;
3789 Overflow = OverflowVal;
3790 if (ReuseName)
3791 Result->takeName(&OrigI);
3792 return true;
3793 };
3794
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003795 // If the overflow check was an add followed by a compare, the insertion point
3796 // may be pointing to the compare. We want to insert the new instructions
3797 // before the add in case there are uses of the add between the add and the
3798 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00003799 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003800
Sanjoy Dasb0984472015-04-08 04:27:22 +00003801 switch (OCF) {
3802 case OCF_INVALID:
3803 llvm_unreachable("bad overflow check kind!");
3804
3805 case OCF_UNSIGNED_ADD: {
3806 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI);
3807 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003808 return SetResult(Builder.CreateNUWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003809 true);
3810
3811 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003812 return SetResult(Builder.CreateAdd(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003813
3814 // Fall through uadd into sadd
3815 LLVM_FALLTHROUGH;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003816 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003817 case OCF_SIGNED_ADD: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003818 // X + 0 -> {X, false}
3819 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003820 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003821
3822 // We can strength reduce this signed add into a regular add if we can prove
3823 // that it will never overflow.
3824 if (OCF == OCF_SIGNED_ADD)
Craig Topper2b1fc322017-05-22 06:25:31 +00003825 if (willNotOverflowSignedAdd(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003826 return SetResult(Builder.CreateNSWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003827 true);
Sanjoy Das72cb5e12015-06-05 18:04:42 +00003828 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003829 }
3830
3831 case OCF_UNSIGNED_SUB:
3832 case OCF_SIGNED_SUB: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003833 // X - 0 -> {X, false}
3834 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003835 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003836
3837 if (OCF == OCF_SIGNED_SUB) {
Craig Topper2b1fc322017-05-22 06:25:31 +00003838 if (willNotOverflowSignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003839 return SetResult(Builder.CreateNSWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003840 true);
3841 } else {
Craig Topper2b1fc322017-05-22 06:25:31 +00003842 if (willNotOverflowUnsignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003843 return SetResult(Builder.CreateNUWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003844 true);
3845 }
3846 break;
3847 }
3848
3849 case OCF_UNSIGNED_MUL: {
3850 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI);
3851 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003852 return SetResult(Builder.CreateNUWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003853 true);
3854 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003855 return SetResult(Builder.CreateMul(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003856 LLVM_FALLTHROUGH;
3857 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003858 case OCF_SIGNED_MUL:
3859 // X * undef -> undef
3860 if (isa<UndefValue>(RHS))
Craig Topperbb4069e2017-07-07 23:16:26 +00003861 return SetResult(RHS, UndefValue::get(Builder.getInt1Ty()), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003862
David Majnemer27e89ba2015-05-21 23:04:21 +00003863 // X * 0 -> {0, false}
3864 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003865 return SetResult(RHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003866
David Majnemer27e89ba2015-05-21 23:04:21 +00003867 // X * 1 -> {X, false}
3868 if (match(RHS, m_One()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003869 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003870
3871 if (OCF == OCF_SIGNED_MUL)
Craig Topper2b1fc322017-05-22 06:25:31 +00003872 if (willNotOverflowSignedMul(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003873 return SetResult(Builder.CreateNSWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003874 true);
Sanjoy Dasc80dad62015-06-05 18:04:46 +00003875 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003876 }
3877
3878 return false;
3879}
3880
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00003881/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003882/// overflow.
3883///
3884/// The caller has matched a pattern of the form:
3885/// I = cmp u (mul(zext A, zext B), V
3886/// The function checks if this is a test for overflow and if so replaces
3887/// multiplication with call to 'mul.with.overflow' intrinsic.
3888///
3889/// \param I Compare instruction.
3890/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
3891/// the compare instruction. Must be of integer type.
3892/// \param OtherVal The other argument of compare instruction.
3893/// \returns Instruction which must replace the compare instruction, NULL if no
3894/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003895static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003896 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00003897 // Don't bother doing this transformation for pointers, don't do it for
3898 // vectors.
3899 if (!isa<IntegerType>(MulVal->getType()))
3900 return nullptr;
3901
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003902 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
3903 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00003904 auto *MulInstr = dyn_cast<Instruction>(MulVal);
3905 if (!MulInstr)
3906 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003907 assert(MulInstr->getOpcode() == Instruction::Mul);
3908
David Majnemer634ca232014-11-01 23:46:05 +00003909 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
3910 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003911 assert(LHS->getOpcode() == Instruction::ZExt);
3912 assert(RHS->getOpcode() == Instruction::ZExt);
3913 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
3914
3915 // Calculate type and width of the result produced by mul.with.overflow.
3916 Type *TyA = A->getType(), *TyB = B->getType();
3917 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
3918 WidthB = TyB->getPrimitiveSizeInBits();
3919 unsigned MulWidth;
3920 Type *MulType;
3921 if (WidthB > WidthA) {
3922 MulWidth = WidthB;
3923 MulType = TyB;
3924 } else {
3925 MulWidth = WidthA;
3926 MulType = TyA;
3927 }
3928
3929 // In order to replace the original mul with a narrower mul.with.overflow,
3930 // all uses must ignore upper bits of the product. The number of used low
3931 // bits must be not greater than the width of mul.with.overflow.
3932 if (MulVal->hasNUsesOrMore(2))
3933 for (User *U : MulVal->users()) {
3934 if (U == &I)
3935 continue;
3936 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3937 // Check if truncation ignores bits above MulWidth.
3938 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
3939 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003940 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003941 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3942 // Check if AND ignores bits above MulWidth.
3943 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00003944 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003945 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
3946 const APInt &CVal = CI->getValue();
3947 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003948 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00003949 } else {
3950 // In this case we could have the operand of the binary operation
3951 // being defined in another block, and performing the replacement
3952 // could break the dominance relation.
3953 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003954 }
3955 } else {
3956 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00003957 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003958 }
3959 }
3960
3961 // Recognize patterns
3962 switch (I.getPredicate()) {
3963 case ICmpInst::ICMP_EQ:
3964 case ICmpInst::ICMP_NE:
3965 // Recognize pattern:
3966 // mulval = mul(zext A, zext B)
3967 // cmp eq/neq mulval, zext trunc mulval
3968 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
3969 if (Zext->hasOneUse()) {
3970 Value *ZextArg = Zext->getOperand(0);
3971 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
3972 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
3973 break; //Recognized
3974 }
3975
3976 // Recognize pattern:
3977 // mulval = mul(zext A, zext B)
3978 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
3979 ConstantInt *CI;
3980 Value *ValToMask;
3981 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
3982 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00003983 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003984 const APInt &CVal = CI->getValue() + 1;
3985 if (CVal.isPowerOf2()) {
3986 unsigned MaskWidth = CVal.logBase2();
3987 if (MaskWidth == MulWidth)
3988 break; // Recognized
3989 }
3990 }
Craig Topperf40110f2014-04-25 05:29:35 +00003991 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003992
3993 case ICmpInst::ICMP_UGT:
3994 // Recognize pattern:
3995 // mulval = mul(zext A, zext B)
3996 // cmp ugt mulval, max
3997 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3998 APInt MaxVal = APInt::getMaxValue(MulWidth);
3999 MaxVal = MaxVal.zext(CI->getBitWidth());
4000 if (MaxVal.eq(CI->getValue()))
4001 break; // Recognized
4002 }
Craig Topperf40110f2014-04-25 05:29:35 +00004003 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004004
4005 case ICmpInst::ICMP_UGE:
4006 // Recognize pattern:
4007 // mulval = mul(zext A, zext B)
4008 // cmp uge mulval, max+1
4009 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4010 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
4011 if (MaxVal.eq(CI->getValue()))
4012 break; // Recognized
4013 }
Craig Topperf40110f2014-04-25 05:29:35 +00004014 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004015
4016 case ICmpInst::ICMP_ULE:
4017 // Recognize pattern:
4018 // mulval = mul(zext A, zext B)
4019 // cmp ule mulval, max
4020 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4021 APInt MaxVal = APInt::getMaxValue(MulWidth);
4022 MaxVal = MaxVal.zext(CI->getBitWidth());
4023 if (MaxVal.eq(CI->getValue()))
4024 break; // Recognized
4025 }
Craig Topperf40110f2014-04-25 05:29:35 +00004026 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004027
4028 case ICmpInst::ICMP_ULT:
4029 // Recognize pattern:
4030 // mulval = mul(zext A, zext B)
4031 // cmp ule mulval, max + 1
4032 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004033 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004034 if (MaxVal.eq(CI->getValue()))
4035 break; // Recognized
4036 }
Craig Topperf40110f2014-04-25 05:29:35 +00004037 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004038
4039 default:
Craig Topperf40110f2014-04-25 05:29:35 +00004040 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004041 }
4042
Craig Topperbb4069e2017-07-07 23:16:26 +00004043 InstCombiner::BuilderTy &Builder = IC.Builder;
4044 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004045
4046 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
4047 Value *MulA = A, *MulB = B;
4048 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004049 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004050 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004051 MulB = Builder.CreateZExt(B, MulType);
Sanjay Patelaf674fb2015-12-14 17:24:23 +00004052 Value *F = Intrinsic::getDeclaration(I.getModule(),
4053 Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004054 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004055 IC.Worklist.Add(MulInstr);
4056
4057 // If there are uses of mul result other than the comparison, we know that
4058 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004059 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004060 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004061 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004062 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4063 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004064 if (U == &I || U == OtherVal)
4065 continue;
4066 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4067 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004068 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004069 else
4070 TI->setOperand(0, Mul);
4071 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4072 assert(BO->getOpcode() == Instruction::And);
4073 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004074 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4075 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004076 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004077 Instruction *Zext =
4078 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4079 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004080 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004081 } else {
4082 llvm_unreachable("Unexpected Binary operation");
4083 }
Davide Italiano579064e2017-07-16 18:56:30 +00004084 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004085 }
4086 }
4087 if (isa<Instruction>(OtherVal))
4088 IC.Worklist.Add(cast<Instruction>(OtherVal));
4089
4090 // The original icmp gets replaced with the overflow value, maybe inverted
4091 // depending on predicate.
4092 bool Inverse = false;
4093 switch (I.getPredicate()) {
4094 case ICmpInst::ICMP_NE:
4095 break;
4096 case ICmpInst::ICMP_EQ:
4097 Inverse = true;
4098 break;
4099 case ICmpInst::ICMP_UGT:
4100 case ICmpInst::ICMP_UGE:
4101 if (I.getOperand(0) == MulVal)
4102 break;
4103 Inverse = true;
4104 break;
4105 case ICmpInst::ICMP_ULT:
4106 case ICmpInst::ICMP_ULE:
4107 if (I.getOperand(1) == MulVal)
4108 break;
4109 Inverse = true;
4110 break;
4111 default:
4112 llvm_unreachable("Unexpected predicate");
4113 }
4114 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004115 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004116 return BinaryOperator::CreateNot(Res);
4117 }
4118
4119 return ExtractValueInst::Create(Call, 1);
4120}
4121
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004122/// When performing a comparison against a constant, it is possible that not all
4123/// the bits in the LHS are demanded. This helper method computes the mask that
4124/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004125static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004126 const APInt *RHS;
4127 if (!match(I.getOperand(1), m_APInt(RHS)))
4128 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004129
Craig Topper3edda872017-09-22 18:57:23 +00004130 // If this is a normal comparison, it demands all bits. If it is a sign bit
4131 // comparison, it only demands the sign bit.
4132 bool UnusedBit;
4133 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4134 return APInt::getSignMask(BitWidth);
4135
Owen Andersond490c2d2011-01-11 00:36:45 +00004136 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004137 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004138 // correspond to the trailing ones of the comparand. The value of these
4139 // bits doesn't impact the outcome of the comparison, because any value
4140 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004141 case ICmpInst::ICMP_UGT:
4142 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004143
Owen Andersond490c2d2011-01-11 00:36:45 +00004144 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4145 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004146 case ICmpInst::ICMP_ULT:
4147 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004148
Owen Andersond490c2d2011-01-11 00:36:45 +00004149 default:
4150 return APInt::getAllOnesValue(BitWidth);
4151 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004152}
Chris Lattner2188e402010-01-04 07:37:31 +00004153
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004154/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004155/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004156/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004157/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004158/// The rationale is that several architectures use the same instruction for
4159/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004160/// match.
4161/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004162static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4163 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004164 // FIXME: we may want to go through inttoptrs or bitcasts.
4165 if (Op0->getType()->isPointerTy())
4166 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004167 // If a subtract already has the same operands as a compare, swapping would be
4168 // bad. If a subtract has the same operands as a compare but in reverse order,
4169 // then swapping is good.
4170 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004171 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004172 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4173 GoodToSwap++;
4174 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4175 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004176 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004177 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004178}
4179
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004180/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004181/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004182///
4183/// \param DI Definition
4184/// \param UI Use
4185/// \param DB Block that must dominate all uses of \p DI outside
4186/// the parent block
4187/// \return true when \p UI is the only use of \p DI in the parent block
4188/// and all other uses of \p DI are in blocks dominated by \p DB.
4189///
4190bool InstCombiner::dominatesAllUses(const Instruction *DI,
4191 const Instruction *UI,
4192 const BasicBlock *DB) const {
4193 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004194 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004195 if (!DI->getParent())
4196 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004197 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004198 if (DI->getParent() != UI->getParent())
4199 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004200 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004201 if (DI->getParent() == DB)
4202 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004203 for (const User *U : DI->users()) {
4204 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004205 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004206 return false;
4207 }
4208 return true;
4209}
4210
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004211/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004212static bool isChainSelectCmpBranch(const SelectInst *SI) {
4213 const BasicBlock *BB = SI->getParent();
4214 if (!BB)
4215 return false;
4216 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4217 if (!BI || BI->getNumSuccessors() != 2)
4218 return false;
4219 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4220 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4221 return false;
4222 return true;
4223}
4224
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004225/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004226/// in select-icmp sequence. This will eventually result in the elimination
4227/// of the select.
4228///
4229/// \param SI Select instruction
4230/// \param Icmp Compare instruction
4231/// \param SIOpd Operand that replaces the select
4232///
4233/// Notes:
4234/// - The replacement is global and requires dominator information
4235/// - The caller is responsible for the actual replacement
4236///
4237/// Example:
4238///
4239/// entry:
4240/// %4 = select i1 %3, %C* %0, %C* null
4241/// %5 = icmp eq %C* %4, null
4242/// br i1 %5, label %9, label %7
4243/// ...
4244/// ; <label>:7 ; preds = %entry
4245/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4246/// ...
4247///
4248/// can be transformed to
4249///
4250/// %5 = icmp eq %C* %0, null
4251/// %6 = select i1 %3, i1 %5, i1 true
4252/// br i1 %6, label %9, label %7
4253/// ...
4254/// ; <label>:7 ; preds = %entry
4255/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4256///
4257/// Similar when the first operand of the select is a constant or/and
4258/// the compare is for not equal rather than equal.
4259///
4260/// NOTE: The function is only called when the select and compare constants
4261/// are equal, the optimization can work only for EQ predicates. This is not a
4262/// major restriction since a NE compare should be 'normalized' to an equal
4263/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004264/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004265bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4266 const ICmpInst *Icmp,
4267 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004268 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004269 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4270 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004271 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004272 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004273 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4274 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4275 // replaced can be reached on either path. So the uniqueness check
4276 // guarantees that the path all uses of SI (outside SI's parent) are on
4277 // is disjoint from all other paths out of SI. But that information
4278 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004279 // of compile-time. It should also be noticed that we check for a single
4280 // predecessor and not only uniqueness. This to handle the situation when
4281 // Succ and Succ1 points to the same basic block.
4282 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004283 NumSel++;
4284 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4285 return true;
4286 }
4287 }
4288 return false;
4289}
4290
Sanjay Patel3151dec2016-09-12 15:24:31 +00004291/// Try to fold the comparison based on range information we can get by checking
4292/// whether bits are known to be zero or one in the inputs.
4293Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4294 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4295 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004296 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004297
4298 // Get scalar or pointer size.
4299 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4300 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004301 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004302
4303 if (!BitWidth)
4304 return nullptr;
4305
Craig Topperb45eabc2017-04-26 16:39:58 +00004306 KnownBits Op0Known(BitWidth);
4307 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004308
Craig Topper47596dd2017-03-25 06:52:52 +00004309 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004310 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004311 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004312 return &I;
4313
Craig Topper47596dd2017-03-25 06:52:52 +00004314 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004315 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004316 return &I;
4317
4318 // Given the known and unknown bits, compute a range that the LHS could be
4319 // in. Compute the Min, Max and RHS values based on the known bits. For the
4320 // EQ and NE we use unsigned values.
4321 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4322 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4323 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004324 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4325 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004326 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004327 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4328 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004329 }
4330
Sanjay Patelc63f9012018-01-04 14:31:56 +00004331 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4332 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004333 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004334 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004335 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004336 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004337 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004338
4339 // Based on the range information we know about the LHS, see if we can
4340 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004341 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004342 default:
4343 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004344 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004345 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004346 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4347 return Pred == CmpInst::ICMP_EQ
4348 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4349 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4350 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004351
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004352 // If all bits are known zero except for one, then we know at most one bit
4353 // is set. If the comparison is against zero, then this is a check to see if
4354 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004355 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004356 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004357 // If the LHS is an AND with the same constant, look through it.
4358 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004359 const APInt *LHSC;
4360 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4361 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004362 LHS = Op0;
4363
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004364 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004365 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4366 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004367 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004368 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004369 // ((1 << X) & 8) == 0 -> X != 3
4370 // ((1 << X) & 8) != 0 -> X == 3
4371 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4372 auto NewPred = ICmpInst::getInversePredicate(Pred);
4373 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004374 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004375 // ((1 << X) & 7) == 0 -> X >= 3
4376 // ((1 << X) & 7) != 0 -> X < 3
4377 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4378 auto NewPred =
4379 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4380 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004381 }
4382 }
4383
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004384 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004385 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004386 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004387 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4388 // ((8 >>u X) & 1) == 0 -> X != 3
4389 // ((8 >>u X) & 1) != 0 -> X == 3
4390 unsigned CmpVal = CI->countTrailingZeros();
4391 auto NewPred = ICmpInst::getInversePredicate(Pred);
4392 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4393 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004394 }
4395 break;
4396 }
4397 case ICmpInst::ICMP_ULT: {
4398 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4399 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4400 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4401 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4402 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4403 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4404
Craig Topper0cd25942017-09-27 22:57:18 +00004405 const APInt *CmpC;
4406 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004407 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004408 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004409 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004410 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004411 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4412 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004413 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004414 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4415 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004416 }
4417 break;
4418 }
4419 case ICmpInst::ICMP_UGT: {
4420 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4421 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004422 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4423 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004424 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4425 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4426
Craig Topper0cd25942017-09-27 22:57:18 +00004427 const APInt *CmpC;
4428 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004429 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004430 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004431 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004432 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004433 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4434 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004435 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004436 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4437 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004438 }
4439 break;
4440 }
Craig Topper0cd25942017-09-27 22:57:18 +00004441 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004442 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4443 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4444 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4445 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4446 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4447 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004448 const APInt *CmpC;
4449 if (match(Op1, m_APInt(CmpC))) {
4450 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004451 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004452 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004453 }
4454 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004455 }
4456 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004457 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4458 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4459 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4460 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004461 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4462 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004463 const APInt *CmpC;
4464 if (match(Op1, m_APInt(CmpC))) {
4465 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004466 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004467 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004468 }
4469 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004470 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004471 case ICmpInst::ICMP_SGE:
4472 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4473 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4474 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4475 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4476 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004477 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4478 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004479 break;
4480 case ICmpInst::ICMP_SLE:
4481 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4482 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4483 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4484 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4485 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004486 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4487 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004488 break;
4489 case ICmpInst::ICMP_UGE:
4490 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4491 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4492 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4493 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4494 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004495 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4496 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004497 break;
4498 case ICmpInst::ICMP_ULE:
4499 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4500 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4501 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4502 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4503 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004504 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4505 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004506 break;
4507 }
4508
4509 // Turn a signed comparison into an unsigned one if both operands are known to
4510 // have the same sign.
4511 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004512 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4513 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004514 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4515
4516 return nullptr;
4517}
4518
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004519/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4520/// it into the appropriate icmp lt or icmp gt instruction. This transform
4521/// allows them to be folded in visitICmpInst.
Sanjay Patele9b2c322016-05-17 00:57:57 +00004522static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4523 ICmpInst::Predicate Pred = I.getPredicate();
4524 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE &&
4525 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE)
4526 return nullptr;
4527
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004528 Value *Op0 = I.getOperand(0);
4529 Value *Op1 = I.getOperand(1);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004530 auto *Op1C = dyn_cast<Constant>(Op1);
4531 if (!Op1C)
4532 return nullptr;
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004533
Sanjay Patele9b2c322016-05-17 00:57:57 +00004534 // Check if the constant operand can be safely incremented/decremented without
4535 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled
4536 // the edge cases for us, so we just assert on them. For vectors, we must
4537 // handle the edge cases.
4538 Type *Op1Type = Op1->getType();
4539 bool IsSigned = I.isSigned();
4540 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Sanjay Patel18254932016-05-17 01:12:31 +00004541 auto *CI = dyn_cast<ConstantInt>(Op1C);
4542 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004543 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4544 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
4545 } else if (Op1Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004546 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004547 // are for scalar, we could remove the min/max checks. However, to do that,
4548 // we would have to use insertelement/shufflevector to replace edge values.
4549 unsigned NumElts = Op1Type->getVectorNumElements();
4550 for (unsigned i = 0; i != NumElts; ++i) {
4551 Constant *Elt = Op1C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004552 if (!Elt)
4553 return nullptr;
4554
Sanjay Patele9b2c322016-05-17 00:57:57 +00004555 if (isa<UndefValue>(Elt))
4556 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004557
Sanjay Patele9b2c322016-05-17 00:57:57 +00004558 // Bail out if we can't determine if this constant is min/max or if we
4559 // know that this constant is min/max.
4560 auto *CI = dyn_cast<ConstantInt>(Elt);
4561 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
4562 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004563 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004564 } else {
4565 // ConstantExpr?
4566 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004567 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004568
Sanjay Patele9b2c322016-05-17 00:57:57 +00004569 // Increment or decrement the constant and set the new comparison predicate:
4570 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT
Sanjay Patel22b01fe2016-05-17 20:20:40 +00004571 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004572 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT;
4573 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred;
4574 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne));
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004575}
4576
Sanjay Patele5747e32017-05-17 22:15:07 +00004577/// Integer compare with boolean values can always be turned into bitwise ops.
4578static Instruction *canonicalizeICmpBool(ICmpInst &I,
4579 InstCombiner::BuilderTy &Builder) {
4580 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004581 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004582
Sanjay Patelba212c22017-05-17 22:29:40 +00004583 // A boolean compared to true/false can be simplified to Op0/true/false in
4584 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4585 // Cases not handled by InstSimplify are always 'not' of Op0.
4586 if (match(B, m_Zero())) {
4587 switch (I.getPredicate()) {
4588 case CmpInst::ICMP_EQ: // A == 0 -> !A
4589 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4590 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4591 return BinaryOperator::CreateNot(A);
4592 default:
4593 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4594 }
4595 } else if (match(B, m_One())) {
4596 switch (I.getPredicate()) {
4597 case CmpInst::ICMP_NE: // A != 1 -> !A
4598 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4599 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4600 return BinaryOperator::CreateNot(A);
4601 default:
4602 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4603 }
4604 }
4605
Sanjay Patele5747e32017-05-17 22:15:07 +00004606 switch (I.getPredicate()) {
4607 default:
4608 llvm_unreachable("Invalid icmp instruction!");
4609 case ICmpInst::ICMP_EQ:
4610 // icmp eq i1 A, B -> ~(A ^ B)
4611 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4612
4613 case ICmpInst::ICMP_NE:
4614 // icmp ne i1 A, B -> A ^ B
4615 return BinaryOperator::CreateXor(A, B);
4616
4617 case ICmpInst::ICMP_UGT:
4618 // icmp ugt -> icmp ult
4619 std::swap(A, B);
4620 LLVM_FALLTHROUGH;
4621 case ICmpInst::ICMP_ULT:
4622 // icmp ult i1 A, B -> ~A & B
4623 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4624
4625 case ICmpInst::ICMP_SGT:
4626 // icmp sgt -> icmp slt
4627 std::swap(A, B);
4628 LLVM_FALLTHROUGH;
4629 case ICmpInst::ICMP_SLT:
4630 // icmp slt i1 A, B -> A & ~B
4631 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4632
4633 case ICmpInst::ICMP_UGE:
4634 // icmp uge -> icmp ule
4635 std::swap(A, B);
4636 LLVM_FALLTHROUGH;
4637 case ICmpInst::ICMP_ULE:
4638 // icmp ule i1 A, B -> ~A | B
4639 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4640
4641 case ICmpInst::ICMP_SGE:
4642 // icmp sge -> icmp sle
4643 std::swap(A, B);
4644 LLVM_FALLTHROUGH;
4645 case ICmpInst::ICMP_SLE:
4646 // icmp sle i1 A, B -> A | ~B
4647 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4648 }
4649}
4650
Roman Lebedev75404fb2018-09-12 18:19:43 +00004651// Transform pattern like:
Roman Lebedev1b7fc872018-09-15 12:04:13 +00004652// (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X
4653// (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X
Roman Lebedev75404fb2018-09-12 18:19:43 +00004654// Into:
4655// (X l>> Y) != 0
4656// (X l>> Y) == 0
4657static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp,
4658 InstCombiner::BuilderTy &Builder) {
Roman Lebedev6dc87002018-09-13 20:33:12 +00004659 ICmpInst::Predicate Pred, NewPred;
Roman Lebedev75404fb2018-09-12 18:19:43 +00004660 Value *X, *Y;
Roman Lebedev6dc87002018-09-13 20:33:12 +00004661 if (match(&Cmp,
4662 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) {
4663 // We want X to be the icmp's second operand, so swap predicate if it isn't.
4664 if (Cmp.getOperand(0) == X)
4665 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00004666
Roman Lebedev6dc87002018-09-13 20:33:12 +00004667 switch (Pred) {
4668 case ICmpInst::ICMP_ULE:
4669 NewPred = ICmpInst::ICMP_NE;
4670 break;
4671 case ICmpInst::ICMP_UGT:
4672 NewPred = ICmpInst::ICMP_EQ;
4673 break;
4674 default:
4675 return nullptr;
4676 }
Roman Lebedev1b7fc872018-09-15 12:04:13 +00004677 } else if (match(&Cmp, m_c_ICmp(Pred,
4678 m_OneUse(m_CombineOr(
4679 m_Not(m_Shl(m_AllOnes(), m_Value(Y))),
4680 m_Add(m_Shl(m_One(), m_Value(Y)),
4681 m_AllOnes()))),
4682 m_Value(X)))) {
4683 // The variant with 'add' is not canonical, (the variant with 'not' is)
4684 // we only get it because it has extra uses, and can't be canonicalized,
4685
Roman Lebedev6dc87002018-09-13 20:33:12 +00004686 // We want X to be the icmp's second operand, so swap predicate if it isn't.
4687 if (Cmp.getOperand(0) == X)
4688 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00004689
Roman Lebedev6dc87002018-09-13 20:33:12 +00004690 switch (Pred) {
4691 case ICmpInst::ICMP_ULT:
4692 NewPred = ICmpInst::ICMP_NE;
4693 break;
4694 case ICmpInst::ICMP_UGE:
4695 NewPred = ICmpInst::ICMP_EQ;
4696 break;
4697 default:
4698 return nullptr;
4699 }
4700 } else
Roman Lebedev75404fb2018-09-12 18:19:43 +00004701 return nullptr;
Roman Lebedev75404fb2018-09-12 18:19:43 +00004702
4703 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits");
4704 Constant *Zero = Constant::getNullValue(NewX->getType());
4705 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero);
4706}
4707
Sanjay Patel039f5562018-08-16 12:52:17 +00004708static Instruction *foldVectorCmp(CmpInst &Cmp,
4709 InstCombiner::BuilderTy &Builder) {
4710 // If both arguments of the cmp are shuffles that use the same mask and
4711 // shuffle within a single vector, move the shuffle after the cmp.
4712 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
4713 Value *V1, *V2;
4714 Constant *M;
4715 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
4716 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
4717 V1->getType() == V2->getType() &&
4718 (LHS->hasOneUse() || RHS->hasOneUse())) {
4719 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
4720 CmpInst::Predicate P = Cmp.getPredicate();
4721 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
4722 : Builder.CreateFCmp(P, V1, V2);
4723 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
4724 }
4725 return nullptr;
4726}
4727
Chris Lattner2188e402010-01-04 07:37:31 +00004728Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
4729 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00004730 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00004731 unsigned Op0Cplxity = getComplexity(Op0);
4732 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004733
Chris Lattner2188e402010-01-04 07:37:31 +00004734 /// Orders the operands of the compare so that they are listed from most
4735 /// complex to least complex. This puts constants before unary operators,
4736 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004737 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00004738 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004739 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00004740 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00004741 Changed = true;
4742 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004743
Daniel Berlin2c75c632017-04-26 20:56:07 +00004744 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
4745 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004746 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004747
Uriel Korach18972232017-09-10 08:31:22 +00004748 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00004749 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00004750 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004751 Value *Cond, *SelectTrue, *SelectFalse;
4752 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00004753 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004754 if (Value *V = dyn_castNegVal(SelectTrue)) {
4755 if (V == SelectFalse)
4756 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
4757 }
4758 else if (Value *V = dyn_castNegVal(SelectFalse)) {
4759 if (V == SelectTrue)
4760 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00004761 }
4762 }
4763 }
4764
Craig Topperfde47232017-07-09 07:04:03 +00004765 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00004766 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00004767 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004768
Sanjay Patele9b2c322016-05-17 00:57:57 +00004769 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004770 return NewICmp;
4771
Sanjay Patel06b127a2016-09-15 14:37:50 +00004772 if (Instruction *Res = foldICmpWithConstant(I))
4773 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004774
Max Kazantsev20da7e42018-07-06 04:04:13 +00004775 if (Instruction *Res = foldICmpUsingKnownBits(I))
4776 return Res;
4777
Chris Lattner2188e402010-01-04 07:37:31 +00004778 // Test if the ICmpInst instruction is used exclusively by a select as
4779 // part of a minimum or maximum operation. If so, refrain from doing
4780 // any other folding. This helps out other analyses which understand
4781 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4782 // and CodeGen. And in this case, at least one of the comparison
4783 // operands has at least one user besides the compare (the select),
4784 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00004785 //
4786 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00004787 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00004788 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
4789 Value *A, *B;
4790 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
4791 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00004792 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00004793 }
Chris Lattner2188e402010-01-04 07:37:31 +00004794
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00004795 // Do this after checking for min/max to prevent infinite looping.
4796 if (Instruction *Res = foldICmpWithZero(I))
4797 return Res;
4798
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00004799 // FIXME: We only do this after checking for min/max to prevent infinite
4800 // looping caused by a reverse canonicalization of these patterns for min/max.
4801 // FIXME: The organization of folds is a mess. These would naturally go into
4802 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
4803 // down here after the min/max restriction.
4804 ICmpInst::Predicate Pred = I.getPredicate();
4805 const APInt *C;
4806 if (match(Op1, m_APInt(C))) {
4807 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
4808 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
4809 Constant *Zero = Constant::getNullValue(Op0->getType());
4810 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
4811 }
4812
4813 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
4814 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
4815 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
4816 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
4817 }
4818 }
4819
Sanjay Patelf58f68c2016-09-10 15:03:44 +00004820 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00004821 return Res;
4822
Sanjay Patel10494b22016-09-16 16:10:22 +00004823 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
4824 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004825
4826 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
4827 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00004828 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00004829 return NI;
4830 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004831 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00004832 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
4833 return NI;
4834
Hans Wennborgf1f36512015-10-07 00:20:07 +00004835 // Try to optimize equality comparisons against alloca-based pointers.
4836 if (Op0->getType()->isPointerTy() && I.isEquality()) {
4837 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
4838 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004839 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004840 return New;
4841 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004842 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004843 return New;
4844 }
4845
Sanjay Patel841aac02018-03-25 14:01:42 +00004846 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
Roman Lebedeve6da3062018-03-18 15:53:02 +00004847 Value *X;
Sanjay Patel745a9c62018-03-24 15:45:02 +00004848 if (match(Op0, m_BitCast(m_SIToFP(m_Value(X))))) {
Sanjay Patel841aac02018-03-25 14:01:42 +00004849 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
4850 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
4851 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
4852 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
4853 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
4854 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
4855 match(Op1, m_Zero()))
Sanjay Patel745a9c62018-03-24 15:45:02 +00004856 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patel841aac02018-03-25 14:01:42 +00004857
4858 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
4859 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
4860 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
4861
4862 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
Sanjay Patel745a9c62018-03-24 15:45:02 +00004863 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
4864 return new ICmpInst(Pred, X, ConstantInt::getAllOnesValue(X->getType()));
4865 }
Roman Lebedeve6da3062018-03-18 15:53:02 +00004866
4867 // Zero-equality checks are preserved through unsigned floating-point casts:
4868 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
4869 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
4870 if (match(Op0, m_BitCast(m_UIToFP(m_Value(X)))))
4871 if (I.isEquality() && match(Op1, m_Zero()))
4872 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
4873
Chris Lattner2188e402010-01-04 07:37:31 +00004874 // Test to see if the operands of the icmp are casted versions of other
4875 // values. If the ptr->ptr cast can be stripped off both arguments, we do so
4876 // now.
4877 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004878 if (Op0->getType()->isPointerTy() &&
4879 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004880 // We keep moving the cast from the left operand over to the right
4881 // operand, where it can often be eliminated completely.
4882 Op0 = CI->getOperand(0);
4883
4884 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
4885 // so eliminate it as well.
4886 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1))
4887 Op1 = CI2->getOperand(0);
4888
4889 // If Op1 is a constant, we can fold the cast into the constant.
4890 if (Op0->getType() != Op1->getType()) {
4891 if (Constant *Op1C = dyn_cast<Constant>(Op1)) {
4892 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType());
4893 } else {
4894 // Otherwise, cast the RHS right before the icmp
Craig Topperbb4069e2017-07-07 23:16:26 +00004895 Op1 = Builder.CreateBitCast(Op1, Op0->getType());
Chris Lattner2188e402010-01-04 07:37:31 +00004896 }
4897 }
4898 return new ICmpInst(I.getPredicate(), Op0, Op1);
4899 }
4900 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004901
Chris Lattner2188e402010-01-04 07:37:31 +00004902 if (isa<CastInst>(Op0)) {
4903 // Handle the special case of: icmp (cast bool to X), <cst>
4904 // This comes up when you have code like
4905 // int X = A < B;
4906 // if (X) ...
4907 // For generality, we handle any zero-extension of any operand comparison
4908 // with a constant or another cast from the same type.
4909 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004910 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00004911 return R;
4912 }
Chris Lattner2188e402010-01-04 07:37:31 +00004913
Sanjay Patel10494b22016-09-16 16:10:22 +00004914 if (Instruction *Res = foldICmpBinOp(I))
4915 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00004916
Sanjay Pateldd46b522016-12-19 17:32:37 +00004917 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00004918 return Res;
4919
Sanjay Patel10494b22016-09-16 16:10:22 +00004920 {
4921 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00004922 // Transform (A & ~B) == 0 --> (A & B) != 0
4923 // and (A & ~B) != 0 --> (A & B) == 0
4924 // if A is a power of 2.
4925 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00004926 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00004927 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00004928 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00004929 Op1);
4930
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004931 // ~X < ~Y --> Y < X
4932 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004933 if (match(Op0, m_Not(m_Value(A)))) {
4934 if (match(Op1, m_Not(m_Value(B))))
4935 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004936
Sanjay Patelce241f42017-06-02 16:29:41 +00004937 const APInt *C;
4938 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004939 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00004940 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004941 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00004942
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004943 Instruction *AddI = nullptr;
4944 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
4945 m_Instruction(AddI))) &&
4946 isa<IntegerType>(A->getType())) {
4947 Value *Result;
4948 Constant *Overflow;
4949 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result,
4950 Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00004951 replaceInstUsesWith(*AddI, Result);
4952 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004953 }
4954 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004955
4956 // (zext a) * (zext b) --> llvm.umul.with.overflow.
4957 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004958 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004959 return R;
4960 }
4961 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004962 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004963 return R;
4964 }
Chris Lattner2188e402010-01-04 07:37:31 +00004965 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004966
Sanjay Patel10494b22016-09-16 16:10:22 +00004967 if (Instruction *Res = foldICmpEquality(I))
4968 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004969
David Majnemerc1eca5a2014-11-06 23:23:30 +00004970 // The 'cmpxchg' instruction returns an aggregate containing the old value and
4971 // an i1 which indicates whether or not we successfully did the swap.
4972 //
4973 // Replace comparisons between the old value and the expected value with the
4974 // indicator that 'cmpxchg' returns.
4975 //
4976 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
4977 // spuriously fail. In those cases, the old value may equal the expected
4978 // value but it is possible for the swap to not occur.
4979 if (I.getPredicate() == ICmpInst::ICMP_EQ)
4980 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
4981 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
4982 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
4983 !ACXI->isWeak())
4984 return ExtractValueInst::Create(ACXI, 1);
4985
Chris Lattner2188e402010-01-04 07:37:31 +00004986 {
Craig Topperbee74792018-08-20 23:04:25 +00004987 Value *X;
4988 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00004989 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00004990 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
4991 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004992
4993 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00004994 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
4995 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004996 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00004997
Roman Lebedev75404fb2018-09-12 18:19:43 +00004998 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder))
4999 return Res;
5000
Sanjay Patel039f5562018-08-16 12:52:17 +00005001 if (I.getType()->isVectorTy())
5002 if (Instruction *Res = foldVectorCmp(I, Builder))
5003 return Res;
5004
Craig Topperf40110f2014-04-25 05:29:35 +00005005 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005006}
5007
Sanjay Patel5f0217f2016-06-05 16:46:18 +00005008/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00005009Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00005010 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00005011 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005012 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005013
Chris Lattner2188e402010-01-04 07:37:31 +00005014 // Get the width of the mantissa. We don't want to hack on conversions that
5015 // might lose information from the integer, e.g. "i64 -> float"
5016 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00005017 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005018
Matt Arsenault55e73122015-01-06 15:50:59 +00005019 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
5020
Chris Lattner2188e402010-01-04 07:37:31 +00005021 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005022
Matt Arsenault55e73122015-01-06 15:50:59 +00005023 if (I.isEquality()) {
5024 FCmpInst::Predicate P = I.getPredicate();
5025 bool IsExact = false;
5026 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
5027 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
5028
5029 // If the floating point constant isn't an integer value, we know if we will
5030 // ever compare equal / not equal to it.
5031 if (!IsExact) {
5032 // TODO: Can never be -0.0 and other non-representable values
5033 APFloat RHSRoundInt(RHS);
5034 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
5035 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
5036 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00005037 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00005038
5039 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00005040 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00005041 }
5042 }
5043
5044 // TODO: If the constant is exactly representable, is it always OK to do
5045 // equality compares as integer?
5046 }
5047
Arch D. Robison8ed08542015-09-15 17:51:59 +00005048 // Check to see that the input is converted from an integer type that is small
5049 // enough that preserves all bits. TODO: check here for "known" sign bits.
5050 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
5051 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00005052
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005053 // Following test does NOT adjust InputSize downwards for signed inputs,
5054 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00005055 // to distinguish it from one less than that value.
5056 if ((int)InputSize > MantissaWidth) {
5057 // Conversion would lose accuracy. Check if loss can impact comparison.
5058 int Exp = ilogb(RHS);
5059 if (Exp == APFloat::IEK_Inf) {
5060 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005061 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005062 // Conversion could create infinity.
5063 return nullptr;
5064 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005065 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00005066 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005067 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005068 // Conversion could affect comparison.
5069 return nullptr;
5070 }
5071 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005072
Chris Lattner2188e402010-01-04 07:37:31 +00005073 // Otherwise, we can potentially simplify the comparison. We know that it
5074 // will always come through as an integer value and we know the constant is
5075 // not a NAN (it would have been previously simplified).
5076 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00005077
Chris Lattner2188e402010-01-04 07:37:31 +00005078 ICmpInst::Predicate Pred;
5079 switch (I.getPredicate()) {
5080 default: llvm_unreachable("Unexpected predicate!");
5081 case FCmpInst::FCMP_UEQ:
5082 case FCmpInst::FCMP_OEQ:
5083 Pred = ICmpInst::ICMP_EQ;
5084 break;
5085 case FCmpInst::FCMP_UGT:
5086 case FCmpInst::FCMP_OGT:
5087 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
5088 break;
5089 case FCmpInst::FCMP_UGE:
5090 case FCmpInst::FCMP_OGE:
5091 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
5092 break;
5093 case FCmpInst::FCMP_ULT:
5094 case FCmpInst::FCMP_OLT:
5095 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
5096 break;
5097 case FCmpInst::FCMP_ULE:
5098 case FCmpInst::FCMP_OLE:
5099 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
5100 break;
5101 case FCmpInst::FCMP_UNE:
5102 case FCmpInst::FCMP_ONE:
5103 Pred = ICmpInst::ICMP_NE;
5104 break;
5105 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00005106 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005107 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00005108 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005109 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005110
Chris Lattner2188e402010-01-04 07:37:31 +00005111 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005112
Chris Lattner2188e402010-01-04 07:37:31 +00005113 // See if the FP constant is too large for the integer. For example,
5114 // comparing an i8 to 300.0.
5115 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005116
Chris Lattner2188e402010-01-04 07:37:31 +00005117 if (!LHSUnsigned) {
5118 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5119 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005120 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005121 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5122 APFloat::rmNearestTiesToEven);
5123 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5124 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5125 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005126 return replaceInstUsesWith(I, Builder.getTrue());
5127 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005128 }
5129 } else {
5130 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5131 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005132 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005133 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5134 APFloat::rmNearestTiesToEven);
5135 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5136 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5137 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005138 return replaceInstUsesWith(I, Builder.getTrue());
5139 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005140 }
5141 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005142
Chris Lattner2188e402010-01-04 07:37:31 +00005143 if (!LHSUnsigned) {
5144 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005145 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005146 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5147 APFloat::rmNearestTiesToEven);
5148 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5149 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5150 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005151 return replaceInstUsesWith(I, Builder.getTrue());
5152 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005153 }
Devang Patel698452b2012-02-13 23:05:18 +00005154 } else {
5155 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005156 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005157 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5158 APFloat::rmNearestTiesToEven);
5159 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5160 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5161 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005162 return replaceInstUsesWith(I, Builder.getTrue());
5163 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005164 }
Chris Lattner2188e402010-01-04 07:37:31 +00005165 }
5166
5167 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5168 // [0, UMAX], but it may still be fractional. See if it is fractional by
5169 // casting the FP value to the integer value and back, checking for equality.
5170 // Don't do this for zero, because -0.0 is not fractional.
5171 Constant *RHSInt = LHSUnsigned
5172 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5173 : ConstantExpr::getFPToSI(RHSC, IntTy);
5174 if (!RHS.isZero()) {
5175 bool Equal = LHSUnsigned
5176 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5177 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5178 if (!Equal) {
5179 // If we had a comparison against a fractional value, we have to adjust
5180 // the compare predicate and sometimes the value. RHSC is rounded towards
5181 // zero at this point.
5182 switch (Pred) {
5183 default: llvm_unreachable("Unexpected integer comparison!");
5184 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005185 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005186 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005187 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005188 case ICmpInst::ICMP_ULE:
5189 // (float)int <= 4.4 --> int <= 4
5190 // (float)int <= -4.4 --> false
5191 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005192 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005193 break;
5194 case ICmpInst::ICMP_SLE:
5195 // (float)int <= 4.4 --> int <= 4
5196 // (float)int <= -4.4 --> int < -4
5197 if (RHS.isNegative())
5198 Pred = ICmpInst::ICMP_SLT;
5199 break;
5200 case ICmpInst::ICMP_ULT:
5201 // (float)int < -4.4 --> false
5202 // (float)int < 4.4 --> int <= 4
5203 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005204 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005205 Pred = ICmpInst::ICMP_ULE;
5206 break;
5207 case ICmpInst::ICMP_SLT:
5208 // (float)int < -4.4 --> int < -4
5209 // (float)int < 4.4 --> int <= 4
5210 if (!RHS.isNegative())
5211 Pred = ICmpInst::ICMP_SLE;
5212 break;
5213 case ICmpInst::ICMP_UGT:
5214 // (float)int > 4.4 --> int > 4
5215 // (float)int > -4.4 --> true
5216 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005217 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005218 break;
5219 case ICmpInst::ICMP_SGT:
5220 // (float)int > 4.4 --> int > 4
5221 // (float)int > -4.4 --> int >= -4
5222 if (RHS.isNegative())
5223 Pred = ICmpInst::ICMP_SGE;
5224 break;
5225 case ICmpInst::ICMP_UGE:
5226 // (float)int >= -4.4 --> true
5227 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005228 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005229 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005230 Pred = ICmpInst::ICMP_UGT;
5231 break;
5232 case ICmpInst::ICMP_SGE:
5233 // (float)int >= -4.4 --> int >= -4
5234 // (float)int >= 4.4 --> int > 4
5235 if (!RHS.isNegative())
5236 Pred = ICmpInst::ICMP_SGT;
5237 break;
5238 }
5239 }
5240 }
5241
5242 // Lower this FP comparison into an appropriate integer version of the
5243 // comparison.
5244 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5245}
5246
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005247/// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary.
5248static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI,
5249 Constant *RHSC) {
5250 // When C is not 0.0 and infinities are not allowed:
5251 // (C / X) < 0.0 is a sign-bit test of X
5252 // (C / X) < 0.0 --> X < 0.0 (if C is positive)
5253 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate)
5254 //
5255 // Proof:
5256 // Multiply (C / X) < 0.0 by X * X / C.
5257 // - X is non zero, if it is the flag 'ninf' is violated.
5258 // - C defines the sign of X * X * C. Thus it also defines whether to swap
5259 // the predicate. C is also non zero by definition.
5260 //
5261 // Thus X * X / C is non zero and the transformation is valid. [qed]
5262
5263 FCmpInst::Predicate Pred = I.getPredicate();
5264
5265 // Check that predicates are valid.
5266 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) &&
5267 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE))
5268 return nullptr;
5269
5270 // Check that RHS operand is zero.
5271 if (!match(RHSC, m_AnyZeroFP()))
5272 return nullptr;
5273
5274 // Check fastmath flags ('ninf').
5275 if (!LHSI->hasNoInfs() || !I.hasNoInfs())
5276 return nullptr;
5277
5278 // Check the properties of the dividend. It must not be zero to avoid a
5279 // division by zero (see Proof).
5280 const APFloat *C;
5281 if (!match(LHSI->getOperand(0), m_APFloat(C)))
5282 return nullptr;
5283
5284 if (C->isZero())
5285 return nullptr;
5286
5287 // Get swapped predicate if necessary.
5288 if (C->isNegative())
5289 Pred = I.getSwappedPredicate();
5290
Sanjay Pateld1172a02018-11-07 00:00:42 +00005291 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I);
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005292}
5293
Sanjay Patel1c254c62018-10-31 16:34:43 +00005294/// Optimize fabs(X) compared with zero.
5295static Instruction *foldFabsWithFcmpZero(FCmpInst &I) {
5296 Value *X;
5297 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) ||
5298 !match(I.getOperand(1), m_PosZeroFP()))
5299 return nullptr;
5300
Sanjay Patel57a08b32018-11-07 16:15:01 +00005301 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) {
5302 I->setPredicate(P);
5303 I->setOperand(0, X);
5304 return I;
5305 };
5306
Sanjay Patel1c254c62018-10-31 16:34:43 +00005307 switch (I.getPredicate()) {
5308 case FCmpInst::FCMP_UGE:
5309 case FCmpInst::FCMP_OLT:
5310 // fabs(X) >= 0.0 --> true
5311 // fabs(X) < 0.0 --> false
5312 llvm_unreachable("fcmp should have simplified");
5313
5314 case FCmpInst::FCMP_OGT:
5315 // fabs(X) > 0.0 --> X != 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005316 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005317
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005318 case FCmpInst::FCMP_UGT:
5319 // fabs(X) u> 0.0 --> X u!= 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005320 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005321
Sanjay Patel1c254c62018-10-31 16:34:43 +00005322 case FCmpInst::FCMP_OLE:
5323 // fabs(X) <= 0.0 --> X == 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005324 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005325
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005326 case FCmpInst::FCMP_ULE:
5327 // fabs(X) u<= 0.0 --> X u== 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005328 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005329
Sanjay Patel1c254c62018-10-31 16:34:43 +00005330 case FCmpInst::FCMP_OGE:
5331 // fabs(X) >= 0.0 --> !isnan(X)
5332 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005333 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005334
Sanjay Patel76faf512018-11-07 15:11:32 +00005335 case FCmpInst::FCMP_ULT:
5336 // fabs(X) u< 0.0 --> isnan(X)
5337 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005338 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X);
Sanjay Patel76faf512018-11-07 15:11:32 +00005339
Sanjay Patel1c254c62018-10-31 16:34:43 +00005340 case FCmpInst::FCMP_OEQ:
5341 case FCmpInst::FCMP_UEQ:
5342 case FCmpInst::FCMP_ONE:
5343 case FCmpInst::FCMP_UNE:
Sanjay Patelbb521e62018-11-07 15:44:26 +00005344 case FCmpInst::FCMP_ORD:
5345 case FCmpInst::FCMP_UNO:
5346 // Look through the fabs() because it doesn't change anything but the sign.
5347 // fabs(X) == 0.0 --> X == 0.0,
Sanjay Patel1c254c62018-10-31 16:34:43 +00005348 // fabs(X) != 0.0 --> X != 0.0
Sanjay Patelbb521e62018-11-07 15:44:26 +00005349 // isnan(fabs(X)) --> isnan(X)
5350 // !isnan(fabs(X) --> !isnan(X)
Sanjay Patel57a08b32018-11-07 16:15:01 +00005351 return replacePredAndOp0(&I, I.getPredicate(), X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005352
5353 default:
5354 return nullptr;
5355 }
5356}
5357
Chris Lattner2188e402010-01-04 07:37:31 +00005358Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5359 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005360
Chris Lattner2188e402010-01-04 07:37:31 +00005361 /// Orders the operands of the compare so that they are listed from most
5362 /// complex to least complex. This puts constants before unary operators,
5363 /// before binary operators.
5364 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5365 I.swapOperands();
5366 Changed = true;
5367 }
5368
Sanjay Patel6b139462017-09-02 15:11:55 +00005369 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005370 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005371 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5372 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005373 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005374
5375 // Simplify 'fcmp pred X, X'
5376 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005377 switch (Pred) {
5378 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005379 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5380 case FCmpInst::FCMP_ULT: // True if unordered or less than
5381 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5382 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5383 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5384 I.setPredicate(FCmpInst::FCMP_UNO);
5385 I.setOperand(1, Constant::getNullValue(Op0->getType()));
5386 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005387
Chris Lattner2188e402010-01-04 07:37:31 +00005388 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5389 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5390 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5391 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5392 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5393 I.setPredicate(FCmpInst::FCMP_ORD);
5394 I.setOperand(1, Constant::getNullValue(Op0->getType()));
5395 return &I;
5396 }
5397 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005398
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005399 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5400 // then canonicalize the operand to 0.0.
5401 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005402 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005403 I.setOperand(0, ConstantFP::getNullValue(Op0->getType()));
5404 return &I;
5405 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005406 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005407 I.setOperand(1, ConstantFP::getNullValue(Op0->getType()));
5408 return &I;
5409 }
5410 }
5411
James Molloy2b21a7c2015-05-20 18:41:25 +00005412 // Test if the FCmpInst instruction is used exclusively by a select as
5413 // part of a minimum or maximum operation. If so, refrain from doing
5414 // any other folding. This helps out other analyses which understand
5415 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5416 // and CodeGen. And in this case, at least one of the comparison
5417 // operands has at least one user besides the compare (the select),
5418 // which would often largely negate the benefit of folding anyway.
5419 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005420 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5421 Value *A, *B;
5422 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5423 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005424 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005425 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005426
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005427 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0:
5428 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0
5429 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) {
5430 I.setOperand(1, ConstantFP::getNullValue(Op1->getType()));
5431 return &I;
5432 }
5433
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005434 // Handle fcmp with instruction LHS and constant RHS.
5435 Instruction *LHSI;
5436 Constant *RHSC;
5437 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) {
5438 switch (LHSI->getOpcode()) {
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005439 case Instruction::PHI:
5440 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5441 // block. If in the same block, we're encouraging jump threading. If
5442 // not, we are just pessimizing the code by making an i1 phi.
5443 if (LHSI->getParent() == I.getParent())
5444 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005445 return NV;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005446 break;
5447 case Instruction::SIToFP:
5448 case Instruction::UIToFP:
5449 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
5450 return NV;
5451 break;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005452 case Instruction::FDiv:
5453 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC))
5454 return NV;
5455 break;
5456 case Instruction::Load:
5457 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0)))
5458 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5459 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5460 !cast<LoadInst>(LHSI)->isVolatile())
5461 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
5462 return Res;
5463 break;
Sanjay Patel1c254c62018-10-31 16:34:43 +00005464 }
Chris Lattner2188e402010-01-04 07:37:31 +00005465 }
5466
Sanjay Pateld1172a02018-11-07 00:00:42 +00005467 if (Instruction *R = foldFabsWithFcmpZero(I))
5468 return R;
5469
Benjamin Kramerd159d942011-03-31 10:12:22 +00005470 Value *X, *Y;
Sanjay Patel70282a02018-11-06 15:49:45 +00005471 if (match(Op0, m_FNeg(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005472 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y
5473 if (match(Op1, m_FNeg(m_Value(Y))))
5474 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00005475
Sanjay Pateld1172a02018-11-07 00:00:42 +00005476 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C
Sanjay Patel70282a02018-11-06 15:49:45 +00005477 Constant *C;
5478 if (match(Op1, m_Constant(C))) {
Sanjay Patel70282a02018-11-06 15:49:45 +00005479 Constant *NegC = ConstantExpr::getFNeg(C);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005480 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00005481 }
5482 }
Benjamin Kramerd159d942011-03-31 10:12:22 +00005483
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005484 if (match(Op0, m_FPExt(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005485 // fcmp (fpext X), (fpext Y) -> fcmp X, Y
5486 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType())
5487 return new FCmpInst(Pred, X, Y, "", &I);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005488
Sanjay Pateld1172a02018-11-07 00:00:42 +00005489 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless
Sanjay Patel724014a2018-11-06 17:20:20 +00005490 const APFloat *C;
5491 if (match(Op1, m_APFloat(C))) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005492 const fltSemantics &FPSem =
5493 X->getType()->getScalarType()->getFltSemantics();
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005494 bool Lossy;
Sanjay Patel724014a2018-11-06 17:20:20 +00005495 APFloat TruncC = *C;
5496 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005497
5498 // Avoid lossy conversions and denormals.
5499 // Zero is a special case that's OK to convert.
Sanjay Patel724014a2018-11-06 17:20:20 +00005500 APFloat Fabs = TruncC;
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005501 Fabs.clearSign();
5502 if (!Lossy &&
5503 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) !=
Sanjay Patel46bf3922018-11-06 16:45:27 +00005504 APFloat::cmpLessThan) || Fabs.isZero())) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005505 Constant *NewC = ConstantFP::get(X->getType(), TruncC);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005506 return new FCmpInst(Pred, X, NewC, "", &I);
Sanjay Patel46bf3922018-11-06 16:45:27 +00005507 }
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005508 }
Sanjay Patel1b85f0022018-11-06 16:23:03 +00005509 }
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005510
Sanjay Patel039f5562018-08-16 12:52:17 +00005511 if (I.getType()->isVectorTy())
5512 if (Instruction *Res = foldVectorCmp(I, Builder))
5513 return Res;
5514
Craig Topperf40110f2014-04-25 05:29:35 +00005515 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005516}