blob: bc82e9094d4dbd4cb1469702eed37c7cad2eac69 [file] [log] [blame]
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001//
Geoff Langcec35902014-04-16 10:52:36 -04002// Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved.
Geoff Lange8ebe7f2013-08-05 15:03:13 -04003// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6
7// validationES.h: Validation functions for generic OpenGL ES entry point parameters
8
Geoff Lang2b5420c2014-11-19 14:20:15 -05009#include "libANGLE/validationES.h"
Jamie Madille2e406c2016-06-02 13:04:10 -040010
Geoff Lang2b5420c2014-11-19 14:20:15 -050011#include "libANGLE/Context.h"
Geoff Langa8406172015-07-21 16:53:39 -040012#include "libANGLE/Display.h"
Brandon Jones6cad5662017-06-14 13:25:13 -070013#include "libANGLE/ErrorStrings.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050014#include "libANGLE/Framebuffer.h"
15#include "libANGLE/FramebufferAttachment.h"
Geoff Langa8406172015-07-21 16:53:39 -040016#include "libANGLE/Image.h"
Geoff Lang7dd2e102014-11-10 15:19:26 -050017#include "libANGLE/Program.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040018#include "libANGLE/Query.h"
19#include "libANGLE/Texture.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050020#include "libANGLE/TransformFeedback.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040021#include "libANGLE/Uniform.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050022#include "libANGLE/VertexArray.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040023#include "libANGLE/formatutils.h"
jchen10a99ed552017-09-22 08:10:32 +080024#include "libANGLE/queryconversions.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040025#include "libANGLE/validationES2.h"
26#include "libANGLE/validationES3.h"
Geoff Lange8ebe7f2013-08-05 15:03:13 -040027
28#include "common/mathutil.h"
29#include "common/utilities.h"
30
Jamie Madille2e406c2016-06-02 13:04:10 -040031using namespace angle;
32
Geoff Lange8ebe7f2013-08-05 15:03:13 -040033namespace gl
34{
Jamie Madill1ca74672015-07-21 15:14:11 -040035namespace
36{
jchen10a99ed552017-09-22 08:10:32 +080037
Corentin Wallez92db6942016-12-09 13:10:36 -050038bool ValidateDrawAttribs(ValidationContext *context,
39 GLint primcount,
40 GLint maxVertex,
41 GLint vertexCount)
Jamie Madill1ca74672015-07-21 15:14:11 -040042{
Jamie Madilldfde6ab2016-06-09 07:07:18 -070043 const gl::State &state = context->getGLState();
Jamie Madill1ca74672015-07-21 15:14:11 -040044 const gl::Program *program = state.getProgram();
45
Corentin Wallez327411e2016-12-09 11:09:17 -050046 bool webglCompatibility = context->getExtensions().webglCompatibility;
47
Jamie Madill231c7f52017-04-26 13:45:37 -040048 const VertexArray *vao = state.getVertexArray();
49 const auto &vertexAttribs = vao->getVertexAttributes();
Jiawei-Shao2597fb62016-12-09 16:38:02 +080050 const auto &vertexBindings = vao->getVertexBindings();
Jamie Madill231c7f52017-04-26 13:45:37 -040051 size_t maxEnabledAttrib = vao->getMaxEnabledAttribute();
Jamie Madill1ca74672015-07-21 15:14:11 -040052 for (size_t attributeIndex = 0; attributeIndex < maxEnabledAttrib; ++attributeIndex)
53 {
54 const VertexAttribute &attrib = vertexAttribs[attributeIndex];
Corentin Wallez672f7f32017-06-15 17:42:17 -040055
56 // No need to range check for disabled attribs.
57 if (!attrib.enabled)
Jamie Madill1ca74672015-07-21 15:14:11 -040058 {
Corentin Wallezfd456442016-12-21 17:57:00 -050059 continue;
60 }
Jamie Madill1ca74672015-07-21 15:14:11 -040061
Jamie Madill231c7f52017-04-26 13:45:37 -040062 // If we have no buffer, then we either get an error, or there are no more checks to be
63 // done.
Corentin Wallez672f7f32017-06-15 17:42:17 -040064 const VertexBinding &binding = vertexBindings[attrib.bindingIndex];
65 gl::Buffer *buffer = binding.getBuffer().get();
Corentin Wallezfd456442016-12-21 17:57:00 -050066 if (!buffer)
67 {
Geoff Langfeb8c682017-02-13 16:07:35 -050068 if (webglCompatibility || !state.areClientArraysEnabled())
Corentin Wallez327411e2016-12-09 11:09:17 -050069 {
70 // [WebGL 1.0] Section 6.5 Enabled Vertex Attributes and Range Checking
Corentin Wallezfd456442016-12-21 17:57:00 -050071 // If a vertex attribute is enabled as an array via enableVertexAttribArray but
72 // no buffer is bound to that attribute via bindBuffer and vertexAttribPointer,
73 // then calls to drawArrays or drawElements will generate an INVALID_OPERATION
74 // error.
Brandon Jonesafa75152017-07-21 13:11:29 -070075 ANGLE_VALIDATION_ERR(context, InvalidOperation(), VertexArrayNoBuffer);
Corentin Wallezfd456442016-12-21 17:57:00 -050076 return false;
Corentin Wallez327411e2016-12-09 11:09:17 -050077 }
Corentin Wallezfd456442016-12-21 17:57:00 -050078 else if (attrib.pointer == nullptr)
Jamie Madill1ca74672015-07-21 15:14:11 -040079 {
80 // This is an application error that would normally result in a crash,
81 // but we catch it and return an error
Brandon Jonesafa75152017-07-21 13:11:29 -070082 ANGLE_VALIDATION_ERR(context, InvalidOperation(), VertexArrayNoBufferPointer);
Jamie Madill1ca74672015-07-21 15:14:11 -040083 return false;
84 }
Corentin Wallezfd456442016-12-21 17:57:00 -050085 continue;
86 }
87
Corentin Wallez672f7f32017-06-15 17:42:17 -040088 // This needs to come after the check for client arrays as even unused attributes cannot use
89 // client-side arrays
90 if (!program->isAttribLocationActive(attributeIndex))
91 {
92 continue;
93 }
94
Corentin Wallezfd456442016-12-21 17:57:00 -050095 // If we're drawing zero vertices, we have enough data.
96 if (vertexCount <= 0 || primcount <= 0)
97 {
98 continue;
99 }
100
101 GLint maxVertexElement = 0;
Martin Radevdd5f27e2017-06-07 10:17:09 +0300102 GLuint divisor = binding.getDivisor();
103 if (divisor == 0)
Corentin Wallezfd456442016-12-21 17:57:00 -0500104 {
105 maxVertexElement = maxVertex;
106 }
107 else
108 {
Martin Radevdd5f27e2017-06-07 10:17:09 +0300109 maxVertexElement = (primcount - 1) / divisor;
Corentin Wallezfd456442016-12-21 17:57:00 -0500110 }
111
112 // We do manual overflow checks here instead of using safe_math.h because it was
113 // a bottleneck. Thanks to some properties of GL we know inequalities that can
114 // help us make the overflow checks faster.
115
116 // The max possible attribSize is 16 for a vector of 4 32 bit values.
117 constexpr uint64_t kMaxAttribSize = 16;
118 constexpr uint64_t kIntMax = std::numeric_limits<int>::max();
119 constexpr uint64_t kUint64Max = std::numeric_limits<uint64_t>::max();
120
121 // We know attribStride is given as a GLsizei which is typedefed to int.
122 // We also know an upper bound for attribSize.
123 static_assert(std::is_same<int, GLsizei>::value, "");
Jiawei-Shao2597fb62016-12-09 16:38:02 +0800124 uint64_t attribStride = ComputeVertexAttributeStride(attrib, binding);
Corentin Wallezfd456442016-12-21 17:57:00 -0500125 uint64_t attribSize = ComputeVertexAttributeTypeSize(attrib);
126 ASSERT(attribStride <= kIntMax && attribSize <= kMaxAttribSize);
127
128 // Computing the max offset using uint64_t without attrib.offset is overflow
129 // safe. Note: Last vertex element does not take the full stride!
130 static_assert(kIntMax * kIntMax < kUint64Max - kMaxAttribSize, "");
131 uint64_t attribDataSizeNoOffset = maxVertexElement * attribStride + attribSize;
132
133 // An overflow can happen when adding the offset, check for it.
Jiawei-Shao2597fb62016-12-09 16:38:02 +0800134 uint64_t attribOffset = ComputeVertexAttributeOffset(attrib, binding);
135 if (attribDataSizeNoOffset > kUint64Max - attribOffset)
Corentin Wallezfd456442016-12-21 17:57:00 -0500136 {
Brandon Jonesafa75152017-07-21 13:11:29 -0700137 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallezfd456442016-12-21 17:57:00 -0500138 return false;
139 }
140 uint64_t attribDataSizeWithOffset = attribDataSizeNoOffset + attribOffset;
141
142 // [OpenGL ES 3.0.2] section 2.9.4 page 40:
143 // We can return INVALID_OPERATION if our vertex attribute does not have
144 // enough backing data.
145 if (attribDataSizeWithOffset > static_cast<uint64_t>(buffer->getSize()))
146 {
Brandon Jonesafa75152017-07-21 13:11:29 -0700147 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientVertexBufferSize);
Corentin Wallezfd456442016-12-21 17:57:00 -0500148 return false;
Jamie Madill1ca74672015-07-21 15:14:11 -0400149 }
150 }
151
152 return true;
153}
154
Geoff Lang280ba992017-04-18 16:30:58 -0400155bool ValidReadPixelsTypeEnum(ValidationContext *context, GLenum type)
156{
157 switch (type)
158 {
159 // Types referenced in Table 3.4 of the ES 2.0.25 spec
160 case GL_UNSIGNED_BYTE:
161 case GL_UNSIGNED_SHORT_4_4_4_4:
162 case GL_UNSIGNED_SHORT_5_5_5_1:
163 case GL_UNSIGNED_SHORT_5_6_5:
164 return context->getClientVersion() >= ES_2_0;
165
166 // Types referenced in Table 3.2 of the ES 3.0.5 spec (Except depth stencil)
167 case GL_BYTE:
168 case GL_INT:
169 case GL_SHORT:
170 case GL_UNSIGNED_INT:
171 case GL_UNSIGNED_INT_10F_11F_11F_REV:
172 case GL_UNSIGNED_INT_24_8:
173 case GL_UNSIGNED_INT_2_10_10_10_REV:
174 case GL_UNSIGNED_INT_5_9_9_9_REV:
175 case GL_UNSIGNED_SHORT:
176 case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT:
177 case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT:
178 return context->getClientVersion() >= ES_3_0;
179
180 case GL_FLOAT:
Geoff Lang7d4602f2017-09-13 10:45:09 -0400181 return context->getClientVersion() >= ES_3_0 || context->getExtensions().textureFloat ||
182 context->getExtensions().colorBufferHalfFloat;
Geoff Lang280ba992017-04-18 16:30:58 -0400183
184 case GL_HALF_FLOAT:
185 return context->getClientVersion() >= ES_3_0 ||
186 context->getExtensions().textureHalfFloat;
187
188 case GL_HALF_FLOAT_OES:
189 return context->getExtensions().colorBufferHalfFloat;
190
191 default:
192 return false;
193 }
194}
195
196bool ValidReadPixelsFormatEnum(ValidationContext *context, GLenum format)
197{
198 switch (format)
199 {
200 // Formats referenced in Table 3.4 of the ES 2.0.25 spec (Except luminance)
201 case GL_RGBA:
202 case GL_RGB:
203 case GL_ALPHA:
204 return context->getClientVersion() >= ES_2_0;
205
206 // Formats referenced in Table 3.2 of the ES 3.0.5 spec
207 case GL_RG:
208 case GL_RED:
209 case GL_RGBA_INTEGER:
210 case GL_RGB_INTEGER:
211 case GL_RG_INTEGER:
212 case GL_RED_INTEGER:
213 return context->getClientVersion() >= ES_3_0;
214
215 case GL_SRGB_ALPHA_EXT:
216 case GL_SRGB_EXT:
217 return context->getExtensions().sRGB;
218
219 case GL_BGRA_EXT:
220 return context->getExtensions().readFormatBGRA;
221
222 default:
223 return false;
224 }
225}
226
Geoff Langf607c602016-09-21 11:46:48 -0400227bool ValidReadPixelsFormatType(ValidationContext *context,
228 GLenum framebufferComponentType,
229 GLenum format,
230 GLenum type)
231{
232 switch (framebufferComponentType)
233 {
234 case GL_UNSIGNED_NORMALIZED:
235 // TODO(geofflang): Don't accept BGRA here. Some chrome internals appear to try to use
236 // ReadPixels with BGRA even if the extension is not present
237 return (format == GL_RGBA && type == GL_UNSIGNED_BYTE) ||
238 (context->getExtensions().readFormatBGRA && format == GL_BGRA_EXT &&
239 type == GL_UNSIGNED_BYTE);
240
241 case GL_SIGNED_NORMALIZED:
242 return (format == GL_RGBA && type == GL_UNSIGNED_BYTE);
243
244 case GL_INT:
245 return (format == GL_RGBA_INTEGER && type == GL_INT);
246
247 case GL_UNSIGNED_INT:
248 return (format == GL_RGBA_INTEGER && type == GL_UNSIGNED_INT);
249
250 case GL_FLOAT:
251 return (format == GL_RGBA && type == GL_FLOAT);
252
253 default:
254 UNREACHABLE();
255 return false;
256 }
257}
258
Geoff Langc1984ed2016-10-07 12:41:00 -0400259template <typename ParamType>
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400260bool ValidateTextureWrapModeValue(Context *context, ParamType *params, bool restrictedWrapModes)
Geoff Langc1984ed2016-10-07 12:41:00 -0400261{
262 switch (ConvertToGLenum(params[0]))
263 {
264 case GL_CLAMP_TO_EDGE:
265 break;
266
267 case GL_REPEAT:
268 case GL_MIRRORED_REPEAT:
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400269 if (restrictedWrapModes)
Geoff Langc1984ed2016-10-07 12:41:00 -0400270 {
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400271 // OES_EGL_image_external and ANGLE_texture_rectangle specifies this error.
Brandon Jonesafa75152017-07-21 13:11:29 -0700272 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidWrapModeTexture);
Geoff Langc1984ed2016-10-07 12:41:00 -0400273 return false;
274 }
275 break;
276
277 default:
Brandon Jonesafa75152017-07-21 13:11:29 -0700278 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureWrap);
Geoff Langc1984ed2016-10-07 12:41:00 -0400279 return false;
280 }
281
282 return true;
283}
284
285template <typename ParamType>
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400286bool ValidateTextureMinFilterValue(Context *context, ParamType *params, bool restrictedMinFilter)
Geoff Langc1984ed2016-10-07 12:41:00 -0400287{
288 switch (ConvertToGLenum(params[0]))
289 {
290 case GL_NEAREST:
291 case GL_LINEAR:
292 break;
293
294 case GL_NEAREST_MIPMAP_NEAREST:
295 case GL_LINEAR_MIPMAP_NEAREST:
296 case GL_NEAREST_MIPMAP_LINEAR:
297 case GL_LINEAR_MIPMAP_LINEAR:
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400298 if (restrictedMinFilter)
Geoff Langc1984ed2016-10-07 12:41:00 -0400299 {
300 // OES_EGL_image_external specifies this error.
Brandon Jonesafa75152017-07-21 13:11:29 -0700301 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFilterTexture);
Geoff Langc1984ed2016-10-07 12:41:00 -0400302 return false;
303 }
304 break;
305
306 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700307 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam);
Geoff Langc1984ed2016-10-07 12:41:00 -0400308 return false;
309 }
310
311 return true;
312}
313
314template <typename ParamType>
315bool ValidateTextureMagFilterValue(Context *context, ParamType *params)
316{
317 switch (ConvertToGLenum(params[0]))
318 {
319 case GL_NEAREST:
320 case GL_LINEAR:
321 break;
322
323 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700324 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam);
Geoff Langc1984ed2016-10-07 12:41:00 -0400325 return false;
326 }
327
328 return true;
329}
330
331template <typename ParamType>
332bool ValidateTextureCompareModeValue(Context *context, ParamType *params)
333{
334 // Acceptable mode parameters from GLES 3.0.2 spec, table 3.17
335 switch (ConvertToGLenum(params[0]))
336 {
337 case GL_NONE:
338 case GL_COMPARE_REF_TO_TEXTURE:
339 break;
340
341 default:
Brandon Jonesafa75152017-07-21 13:11:29 -0700342 ANGLE_VALIDATION_ERR(context, InvalidEnum(), UnknownParameter);
Geoff Langc1984ed2016-10-07 12:41:00 -0400343 return false;
344 }
345
346 return true;
347}
348
349template <typename ParamType>
350bool ValidateTextureCompareFuncValue(Context *context, ParamType *params)
351{
352 // Acceptable function parameters from GLES 3.0.2 spec, table 3.17
353 switch (ConvertToGLenum(params[0]))
354 {
355 case GL_LEQUAL:
356 case GL_GEQUAL:
357 case GL_LESS:
358 case GL_GREATER:
359 case GL_EQUAL:
360 case GL_NOTEQUAL:
361 case GL_ALWAYS:
362 case GL_NEVER:
363 break;
364
365 default:
Brandon Jonesafa75152017-07-21 13:11:29 -0700366 ANGLE_VALIDATION_ERR(context, InvalidEnum(), UnknownParameter);
Geoff Langc1984ed2016-10-07 12:41:00 -0400367 return false;
368 }
369
370 return true;
371}
372
373template <typename ParamType>
Geoff Lang81c6b572016-10-19 14:07:52 -0700374bool ValidateTextureSRGBDecodeValue(Context *context, ParamType *params)
375{
376 if (!context->getExtensions().textureSRGBDecode)
377 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700378 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Geoff Lang81c6b572016-10-19 14:07:52 -0700379 return false;
380 }
381
382 switch (ConvertToGLenum(params[0]))
383 {
384 case GL_DECODE_EXT:
385 case GL_SKIP_DECODE_EXT:
386 break;
387
388 default:
Brandon Jonesafa75152017-07-21 13:11:29 -0700389 ANGLE_VALIDATION_ERR(context, InvalidEnum(), UnknownParameter);
Geoff Lang81c6b572016-10-19 14:07:52 -0700390 return false;
391 }
392
393 return true;
394}
395
Jamie Madillc1d770e2017-04-13 17:31:24 -0400396bool ValidateUniformCommonBase(ValidationContext *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500397 gl::Program *program,
398 GLint location,
399 GLsizei count,
400 const LinkedUniform **uniformOut)
401{
402 // TODO(Jiajia): Add image uniform check in future.
403 if (count < 0)
404 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700405 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500406 return false;
407 }
408
Brandon Jones6cad5662017-06-14 13:25:13 -0700409 if (!program)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500410 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700411 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidProgramName);
412 return false;
413 }
414
415 if (!program->isLinked())
416 {
417 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500418 return false;
419 }
420
421 if (location == -1)
422 {
423 // Silently ignore the uniform command
424 return false;
425 }
426
427 const auto &uniformLocations = program->getUniformLocations();
Jamie Madillbe849e42017-05-02 15:49:00 -0400428 size_t castedLocation = static_cast<size_t>(location);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500429 if (castedLocation >= uniformLocations.size())
430 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500431 context->handleError(InvalidOperation() << "Invalid uniform location");
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500432 return false;
433 }
434
435 const auto &uniformLocation = uniformLocations[castedLocation];
436 if (uniformLocation.ignored)
437 {
438 // Silently ignore the uniform command
439 return false;
440 }
441
Jamie Madillfb997ec2017-09-20 15:44:27 -0400442 if (!uniformLocation.used())
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500443 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500444 context->handleError(InvalidOperation());
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500445 return false;
446 }
447
448 const auto &uniform = program->getUniformByIndex(uniformLocation.index);
449
450 // attempting to write an array to a non-array uniform is an INVALID_OPERATION
451 if (!uniform.isArray() && count > 1)
452 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500453 context->handleError(InvalidOperation());
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500454 return false;
455 }
456
457 *uniformOut = &uniform;
458 return true;
459}
460
Frank Henigman999b0fd2017-02-02 21:45:55 -0500461bool ValidateUniform1ivValue(ValidationContext *context,
Frank Henigmana98a6472017-02-02 21:38:32 -0500462 GLenum uniformType,
463 GLsizei count,
464 const GLint *value)
465{
466 // Value type is GL_INT, because we only get here from glUniform1i{v}.
467 // It is compatible with INT or BOOL.
468 // Do these cheap tests first, for a little extra speed.
469 if (GL_INT == uniformType || GL_BOOL == uniformType)
470 {
471 return true;
472 }
473
474 if (IsSamplerType(uniformType))
475 {
Frank Henigman999b0fd2017-02-02 21:45:55 -0500476 // Check that the values are in range.
477 const GLint max = context->getCaps().maxCombinedTextureImageUnits;
478 for (GLsizei i = 0; i < count; ++i)
479 {
480 if (value[i] < 0 || value[i] >= max)
481 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500482 context->handleError(InvalidValue() << "sampler uniform value out of range");
Frank Henigman999b0fd2017-02-02 21:45:55 -0500483 return false;
484 }
485 }
Frank Henigmana98a6472017-02-02 21:38:32 -0500486 return true;
487 }
488
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500489 context->handleError(InvalidOperation() << "wrong type of value for uniform");
Frank Henigmana98a6472017-02-02 21:38:32 -0500490 return false;
491}
492
Jamie Madillc1d770e2017-04-13 17:31:24 -0400493bool ValidateUniformValue(ValidationContext *context, GLenum valueType, GLenum uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500494{
495 // Check that the value type is compatible with uniform type.
Frank Henigmana98a6472017-02-02 21:38:32 -0500496 // Do the cheaper test first, for a little extra speed.
497 if (valueType == uniformType || VariableBoolVectorType(valueType) == uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500498 {
499 return true;
500 }
501
Brandon Jonesafa75152017-07-21 13:11:29 -0700502 ANGLE_VALIDATION_ERR(context, InvalidOperation(), UniformSizeMismatch);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500503 return false;
504}
505
Jamie Madillc1d770e2017-04-13 17:31:24 -0400506bool ValidateUniformMatrixValue(ValidationContext *context, GLenum valueType, GLenum uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500507{
508 // Check that the value type is compatible with uniform type.
509 if (valueType == uniformType)
510 {
511 return true;
512 }
513
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500514 context->handleError(InvalidOperation() << "wrong type of value for uniform");
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500515 return false;
516}
517
Geoff Lange0cff192017-05-30 13:04:56 -0400518bool ValidateFragmentShaderColorBufferTypeMatch(ValidationContext *context)
519{
520 const Program *program = context->getGLState().getProgram();
521 const Framebuffer *framebuffer = context->getGLState().getDrawFramebuffer();
522
523 const auto &programOutputTypes = program->getOutputVariableTypes();
524 for (size_t drawBufferIdx = 0; drawBufferIdx < programOutputTypes.size(); drawBufferIdx++)
525 {
526 GLenum outputType = programOutputTypes[drawBufferIdx];
527 GLenum inputType = framebuffer->getDrawbufferWriteType(drawBufferIdx);
528 if (outputType != GL_NONE && inputType != GL_NONE && inputType != outputType)
529 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500530 context->handleError(InvalidOperation() << "Fragment shader output type does not "
531 "match the bound framebuffer attachment "
532 "type.");
Geoff Lange0cff192017-05-30 13:04:56 -0400533 return false;
534 }
535 }
536
537 return true;
538}
539
Geoff Lang9ab5b822017-05-30 16:19:23 -0400540bool ValidateVertexShaderAttributeTypeMatch(ValidationContext *context)
541{
542 const Program *program = context->getGLState().getProgram();
543 const VertexArray *vao = context->getGLState().getVertexArray();
544
545 for (const auto &shaderAttribute : program->getAttributes())
546 {
Geoff Lang69df2422017-07-05 12:42:31 -0400547 // gl_VertexID and gl_InstanceID are active attributes but don't have a bound attribute.
548 if (shaderAttribute.isBuiltIn())
549 {
550 continue;
551 }
552
Geoff Lang9ab5b822017-05-30 16:19:23 -0400553 GLenum shaderInputType = VariableComponentType(shaderAttribute.type);
554
555 const auto &attrib = vao->getVertexAttribute(shaderAttribute.location);
556 const auto &currentValue =
557 context->getGLState().getVertexAttribCurrentValue(shaderAttribute.location);
558 GLenum vertexType = attrib.enabled ? GetVertexAttributeBaseType(attrib) : currentValue.Type;
559
560 if (shaderInputType != GL_NONE && vertexType != GL_NONE && shaderInputType != vertexType)
561 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500562 context->handleError(InvalidOperation() << "Vertex shader input type does not "
563 "match the type of the bound vertex "
564 "attribute.");
Geoff Lang9ab5b822017-05-30 16:19:23 -0400565 return false;
566 }
567 }
568
569 return true;
570}
571
Geoff Langf41a7152016-09-19 15:11:17 -0400572} // anonymous namespace
573
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500574bool ValidTextureTarget(const ValidationContext *context, GLenum target)
Jamie Madill35d15012013-10-07 10:46:37 -0400575{
Jamie Madilld7460c72014-01-21 16:38:14 -0500576 switch (target)
Jamie Madill35d15012013-10-07 10:46:37 -0400577 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800578 case GL_TEXTURE_2D:
579 case GL_TEXTURE_CUBE_MAP:
580 return true;
Jamie Madill35d15012013-10-07 10:46:37 -0400581
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400582 case GL_TEXTURE_RECTANGLE_ANGLE:
583 return context->getExtensions().textureRectangle;
584
He Yunchaoced53ae2016-11-29 15:00:51 +0800585 case GL_TEXTURE_3D:
586 case GL_TEXTURE_2D_ARRAY:
587 return (context->getClientMajorVersion() >= 3);
Jamie Madilld7460c72014-01-21 16:38:14 -0500588
He Yunchaoced53ae2016-11-29 15:00:51 +0800589 case GL_TEXTURE_2D_MULTISAMPLE:
He Yunchaoced53ae2016-11-29 15:00:51 +0800590 return (context->getClientVersion() >= Version(3, 1));
Geoff Lang3b573612016-10-31 14:08:10 -0400591
He Yunchaoced53ae2016-11-29 15:00:51 +0800592 default:
593 return false;
Jamie Madilld7460c72014-01-21 16:38:14 -0500594 }
Jamie Madill35d15012013-10-07 10:46:37 -0400595}
596
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500597bool ValidTexture2DTarget(const ValidationContext *context, GLenum target)
598{
599 switch (target)
600 {
601 case GL_TEXTURE_2D:
602 case GL_TEXTURE_CUBE_MAP:
603 return true;
604
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400605 case GL_TEXTURE_RECTANGLE_ANGLE:
606 return context->getExtensions().textureRectangle;
607
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500608 default:
609 return false;
610 }
611}
612
613bool ValidTexture3DTarget(const ValidationContext *context, GLenum target)
614{
615 switch (target)
616 {
617 case GL_TEXTURE_3D:
618 case GL_TEXTURE_2D_ARRAY:
Martin Radev1be913c2016-07-11 17:59:16 +0300619 return (context->getClientMajorVersion() >= 3);
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500620
621 default:
622 return false;
623 }
624}
625
Ian Ewellbda75592016-04-18 17:25:54 -0400626// Most texture GL calls are not compatible with external textures, so we have a separate validation
627// function for use in the GL calls that do
628bool ValidTextureExternalTarget(const ValidationContext *context, GLenum target)
629{
630 return (target == GL_TEXTURE_EXTERNAL_OES) &&
631 (context->getExtensions().eglImageExternal ||
632 context->getExtensions().eglStreamConsumerExternal);
633}
634
Shannon Woods4dfed832014-03-17 20:03:39 -0400635// This function differs from ValidTextureTarget in that the target must be
636// usable as the destination of a 2D operation-- so a cube face is valid, but
637// GL_TEXTURE_CUBE_MAP is not.
Jamie Madill560a8d82014-05-21 13:06:20 -0400638// Note: duplicate of IsInternalTextureTarget
Jamie Madillc29968b2016-01-20 11:17:23 -0500639bool ValidTexture2DDestinationTarget(const ValidationContext *context, GLenum target)
Shannon Woods4dfed832014-03-17 20:03:39 -0400640{
641 switch (target)
642 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800643 case GL_TEXTURE_2D:
644 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
645 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
646 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
647 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
648 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
649 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
650 return true;
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400651 case GL_TEXTURE_RECTANGLE_ANGLE:
652 return context->getExtensions().textureRectangle;
He Yunchaoced53ae2016-11-29 15:00:51 +0800653 default:
654 return false;
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500655 }
656}
657
Jamie Madillbe849e42017-05-02 15:49:00 -0400658bool ValidateDrawElementsInstancedBase(ValidationContext *context,
659 GLenum mode,
660 GLsizei count,
661 GLenum type,
662 const GLvoid *indices,
663 GLsizei primcount)
664{
665 if (primcount < 0)
666 {
Brandon Jonesafa75152017-07-21 13:11:29 -0700667 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativePrimcount);
Jamie Madillbe849e42017-05-02 15:49:00 -0400668 return false;
669 }
670
671 if (!ValidateDrawElementsCommon(context, mode, count, type, indices, primcount))
672 {
673 return false;
674 }
675
676 // No-op zero primitive count
677 return (primcount > 0);
678}
679
680bool ValidateDrawArraysInstancedBase(Context *context,
681 GLenum mode,
682 GLint first,
683 GLsizei count,
684 GLsizei primcount)
685{
686 if (primcount < 0)
687 {
Brandon Jonesafa75152017-07-21 13:11:29 -0700688 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativePrimcount);
Jamie Madillbe849e42017-05-02 15:49:00 -0400689 return false;
690 }
691
692 if (!ValidateDrawArraysCommon(context, mode, first, count, primcount))
693 {
694 return false;
695 }
696
697 // No-op if zero primitive count
698 return (primcount > 0);
699}
700
Corentin Wallez0dc97812017-06-22 14:38:44 -0400701bool ValidateDrawInstancedANGLE(ValidationContext *context)
Jamie Madillbe849e42017-05-02 15:49:00 -0400702{
703 // Verify there is at least one active attribute with a divisor of zero
704 const State &state = context->getGLState();
705
706 Program *program = state.getProgram();
707
708 const auto &attribs = state.getVertexArray()->getVertexAttributes();
709 const auto &bindings = state.getVertexArray()->getVertexBindings();
710 for (size_t attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++)
711 {
712 const VertexAttribute &attrib = attribs[attributeIndex];
713 const VertexBinding &binding = bindings[attrib.bindingIndex];
Martin Radevdd5f27e2017-06-07 10:17:09 +0300714 if (program->isAttribLocationActive(attributeIndex) && binding.getDivisor() == 0)
Jamie Madillbe849e42017-05-02 15:49:00 -0400715 {
716 return true;
717 }
718 }
719
Brandon Jonesafa75152017-07-21 13:11:29 -0700720 ANGLE_VALIDATION_ERR(context, InvalidOperation(), NoZeroDivisor);
Jamie Madillbe849e42017-05-02 15:49:00 -0400721 return false;
722}
723
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500724bool ValidTexture3DDestinationTarget(const ValidationContext *context, GLenum target)
725{
726 switch (target)
727 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800728 case GL_TEXTURE_3D:
729 case GL_TEXTURE_2D_ARRAY:
730 return true;
731 default:
732 return false;
Shannon Woods4dfed832014-03-17 20:03:39 -0400733 }
734}
735
He Yunchao11b038b2016-11-22 21:24:04 +0800736bool ValidTexLevelDestinationTarget(const ValidationContext *context, GLenum target)
737{
738 switch (target)
739 {
740 case GL_TEXTURE_2D:
741 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
742 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
743 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
744 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
745 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
746 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
747 case GL_TEXTURE_3D:
748 case GL_TEXTURE_2D_ARRAY:
749 case GL_TEXTURE_2D_MULTISAMPLE:
750 return true;
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400751 case GL_TEXTURE_RECTANGLE_ANGLE:
752 return context->getExtensions().textureRectangle;
He Yunchao11b038b2016-11-22 21:24:04 +0800753 default:
754 return false;
755 }
756}
757
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500758bool ValidFramebufferTarget(GLenum target)
759{
He Yunchaoced53ae2016-11-29 15:00:51 +0800760 static_assert(GL_DRAW_FRAMEBUFFER_ANGLE == GL_DRAW_FRAMEBUFFER &&
761 GL_READ_FRAMEBUFFER_ANGLE == GL_READ_FRAMEBUFFER,
Geoff Langd4475812015-03-18 10:53:05 -0400762 "ANGLE framebuffer enums must equal the ES3 framebuffer enums.");
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500763
764 switch (target)
765 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800766 case GL_FRAMEBUFFER:
767 return true;
768 case GL_READ_FRAMEBUFFER:
769 return true;
770 case GL_DRAW_FRAMEBUFFER:
771 return true;
772 default:
773 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500774 }
775}
776
Jamie Madill29639852016-09-02 15:00:09 -0400777bool ValidBufferTarget(const ValidationContext *context, GLenum target)
Jamie Madill8c96d582014-03-05 15:01:23 -0500778{
779 switch (target)
780 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800781 case GL_ARRAY_BUFFER:
782 case GL_ELEMENT_ARRAY_BUFFER:
783 return true;
Jamie Madill8c96d582014-03-05 15:01:23 -0500784
He Yunchaoced53ae2016-11-29 15:00:51 +0800785 case GL_PIXEL_PACK_BUFFER:
786 case GL_PIXEL_UNPACK_BUFFER:
787 return (context->getExtensions().pixelBufferObject ||
788 context->getClientMajorVersion() >= 3);
Shannon Woods158c4382014-05-06 13:00:07 -0400789
He Yunchaoced53ae2016-11-29 15:00:51 +0800790 case GL_COPY_READ_BUFFER:
791 case GL_COPY_WRITE_BUFFER:
792 case GL_TRANSFORM_FEEDBACK_BUFFER:
793 case GL_UNIFORM_BUFFER:
794 return (context->getClientMajorVersion() >= 3);
Jamie Madill8c96d582014-03-05 15:01:23 -0500795
He Yunchaoced53ae2016-11-29 15:00:51 +0800796 case GL_ATOMIC_COUNTER_BUFFER:
797 case GL_SHADER_STORAGE_BUFFER:
798 case GL_DRAW_INDIRECT_BUFFER:
799 case GL_DISPATCH_INDIRECT_BUFFER:
He Yunchaoced53ae2016-11-29 15:00:51 +0800800 return context->getClientVersion() >= Version(3, 1);
Geoff Lang3b573612016-10-31 14:08:10 -0400801
He Yunchaoced53ae2016-11-29 15:00:51 +0800802 default:
803 return false;
Jamie Madill8c96d582014-03-05 15:01:23 -0500804 }
805}
806
Jamie Madillc29968b2016-01-20 11:17:23 -0500807bool ValidMipLevel(const ValidationContext *context, GLenum target, GLint level)
Geoff Langce635692013-09-24 13:56:32 -0400808{
Jamie Madillc29968b2016-01-20 11:17:23 -0500809 const auto &caps = context->getCaps();
Geoff Langaae65a42014-05-26 12:43:44 -0400810 size_t maxDimension = 0;
Geoff Langce635692013-09-24 13:56:32 -0400811 switch (target)
812 {
Jamie Madillc29968b2016-01-20 11:17:23 -0500813 case GL_TEXTURE_2D:
814 maxDimension = caps.max2DTextureSize;
815 break;
He Yunchaoced53ae2016-11-29 15:00:51 +0800816 case GL_TEXTURE_CUBE_MAP:
817 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
818 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
819 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
820 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
821 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
822 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
823 maxDimension = caps.maxCubeMapTextureSize;
824 break;
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400825 case GL_TEXTURE_RECTANGLE_ANGLE:
826 return level == 0;
He Yunchaoced53ae2016-11-29 15:00:51 +0800827 case GL_TEXTURE_3D:
828 maxDimension = caps.max3DTextureSize;
829 break;
830 case GL_TEXTURE_2D_ARRAY:
831 maxDimension = caps.max2DTextureSize;
832 break;
He Yunchao11b038b2016-11-22 21:24:04 +0800833 case GL_TEXTURE_2D_MULTISAMPLE:
834 maxDimension = caps.max2DTextureSize;
835 break;
He Yunchaoced53ae2016-11-29 15:00:51 +0800836 default:
837 UNREACHABLE();
Geoff Langce635692013-09-24 13:56:32 -0400838 }
839
Brandon Jones6cad5662017-06-14 13:25:13 -0700840 return level <= gl::log2(static_cast<int>(maxDimension)) && level >= 0;
Geoff Langce635692013-09-24 13:56:32 -0400841}
842
Brandon Jones6cad5662017-06-14 13:25:13 -0700843bool ValidImageSizeParameters(ValidationContext *context,
Austin Kinross08528e12015-10-07 16:24:40 -0700844 GLenum target,
845 GLint level,
846 GLsizei width,
847 GLsizei height,
848 GLsizei depth,
849 bool isSubImage)
Geoff Langce635692013-09-24 13:56:32 -0400850{
Brandon Jones6cad5662017-06-14 13:25:13 -0700851 if (width < 0 || height < 0 || depth < 0)
Geoff Langce635692013-09-24 13:56:32 -0400852 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700853 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Geoff Langce635692013-09-24 13:56:32 -0400854 return false;
855 }
Austin Kinross08528e12015-10-07 16:24:40 -0700856 // TexSubImage parameters can be NPOT without textureNPOT extension,
857 // as long as the destination texture is POT.
Geoff Langcc507aa2016-12-12 10:09:52 -0500858 bool hasNPOTSupport =
Geoff Lang5f319a42017-01-09 16:49:19 -0500859 context->getExtensions().textureNPOT || context->getClientVersion() >= Version(3, 0);
Geoff Langcc507aa2016-12-12 10:09:52 -0500860 if (!isSubImage && !hasNPOTSupport &&
Jamie Madill4fd75c12014-06-23 10:53:54 -0400861 (level != 0 && (!gl::isPow2(width) || !gl::isPow2(height) || !gl::isPow2(depth))))
Geoff Langce635692013-09-24 13:56:32 -0400862 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700863 ANGLE_VALIDATION_ERR(context, InvalidValue(), TextureNotPow2);
Geoff Langce635692013-09-24 13:56:32 -0400864 return false;
865 }
866
867 if (!ValidMipLevel(context, target, level))
868 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700869 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Geoff Langce635692013-09-24 13:56:32 -0400870 return false;
871 }
872
873 return true;
874}
875
Geoff Lang0d8b7242015-09-09 14:56:53 -0400876bool CompressedTextureFormatRequiresExactSize(GLenum internalFormat)
877{
878 // List of compressed format that require that the texture size is smaller than or a multiple of
879 // the compressed block size.
880 switch (internalFormat)
881 {
882 case GL_COMPRESSED_RGB_S3TC_DXT1_EXT:
883 case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT:
884 case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE:
885 case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE:
Geoff Langfff7a7d2017-06-02 10:39:17 -0400886 case GL_COMPRESSED_SRGB_S3TC_DXT1_EXT:
887 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT:
888 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT:
889 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT:
Minmin Gonge3939b92015-12-01 15:36:51 -0800890 case GL_ETC1_RGB8_LOSSY_DECODE_ANGLE:
Minmin Gong390208b2017-02-28 18:03:06 -0800891 case GL_COMPRESSED_RGB8_LOSSY_DECODE_ETC2_ANGLE:
892 case GL_COMPRESSED_SRGB8_LOSSY_DECODE_ETC2_ANGLE:
893 case GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE:
894 case GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE:
895 case GL_COMPRESSED_RGBA8_LOSSY_DECODE_ETC2_EAC_ANGLE:
896 case GL_COMPRESSED_SRGB8_ALPHA8_LOSSY_DECODE_ETC2_EAC_ANGLE:
Geoff Lang0d8b7242015-09-09 14:56:53 -0400897 return true;
898
899 default:
900 return false;
901 }
902}
903
Geoff Lang966c9402017-04-18 12:38:27 -0400904bool ValidCompressedDimension(GLsizei size, GLuint blockSize, bool smallerThanBlockSizeAllowed)
905{
906 return (smallerThanBlockSizeAllowed && (size > 0) && (blockSize % size == 0)) ||
907 (size % blockSize == 0);
908}
909
Jamie Madillc29968b2016-01-20 11:17:23 -0500910bool ValidCompressedImageSize(const ValidationContext *context,
911 GLenum internalFormat,
Geoff Lang966c9402017-04-18 12:38:27 -0400912 GLint level,
Jamie Madillc29968b2016-01-20 11:17:23 -0500913 GLsizei width,
914 GLsizei height)
Geoff Langd4f180b2013-09-24 13:57:44 -0400915{
Geoff Langca271392017-04-05 12:30:00 -0400916 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat);
Geoff Lang5d601382014-07-22 15:14:06 -0400917 if (!formatInfo.compressed)
Geoff Langd4f180b2013-09-24 13:57:44 -0400918 {
919 return false;
920 }
921
Geoff Lang966c9402017-04-18 12:38:27 -0400922 if (width < 0 || height < 0)
923 {
924 return false;
925 }
926
927 if (CompressedTextureFormatRequiresExactSize(internalFormat))
928 {
929 // The ANGLE extensions allow specifying compressed textures with sizes smaller than the
930 // block size for level 0 but WebGL disallows this.
931 bool smallerThanBlockSizeAllowed =
932 level > 0 || !context->getExtensions().webglCompatibility;
933
934 if (!ValidCompressedDimension(width, formatInfo.compressedBlockWidth,
935 smallerThanBlockSizeAllowed) ||
936 !ValidCompressedDimension(height, formatInfo.compressedBlockHeight,
937 smallerThanBlockSizeAllowed))
938 {
939 return false;
940 }
941 }
942
943 return true;
944}
945
946bool ValidCompressedSubImageSize(const ValidationContext *context,
947 GLenum internalFormat,
948 GLint xoffset,
949 GLint yoffset,
950 GLsizei width,
951 GLsizei height,
952 size_t textureWidth,
953 size_t textureHeight)
954{
955 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat);
956 if (!formatInfo.compressed)
957 {
958 return false;
959 }
960
Geoff Lang44ff5a72017-02-03 15:15:43 -0500961 if (xoffset < 0 || yoffset < 0 || width < 0 || height < 0)
Geoff Langd4f180b2013-09-24 13:57:44 -0400962 {
963 return false;
964 }
965
Geoff Lang0d8b7242015-09-09 14:56:53 -0400966 if (CompressedTextureFormatRequiresExactSize(internalFormat))
967 {
Geoff Lang44ff5a72017-02-03 15:15:43 -0500968 if (xoffset % formatInfo.compressedBlockWidth != 0 ||
Geoff Lang966c9402017-04-18 12:38:27 -0400969 yoffset % formatInfo.compressedBlockHeight != 0)
970 {
971 return false;
972 }
973
974 // Allowed to either have data that is a multiple of block size or is smaller than the block
975 // size but fills the entire mip
976 bool fillsEntireMip = xoffset == 0 && yoffset == 0 &&
977 static_cast<size_t>(width) == textureWidth &&
978 static_cast<size_t>(height) == textureHeight;
979 bool sizeMultipleOfBlockSize = (width % formatInfo.compressedBlockWidth) == 0 &&
980 (height % formatInfo.compressedBlockHeight) == 0;
981 if (!sizeMultipleOfBlockSize && !fillsEntireMip)
Geoff Lang0d8b7242015-09-09 14:56:53 -0400982 {
983 return false;
984 }
985 }
986
Geoff Langd4f180b2013-09-24 13:57:44 -0400987 return true;
988}
989
Geoff Langff5b2d52016-09-07 11:32:23 -0400990bool ValidImageDataSize(ValidationContext *context,
991 GLenum textureTarget,
992 GLsizei width,
993 GLsizei height,
994 GLsizei depth,
Geoff Langdbcced82017-06-06 15:55:54 -0400995 GLenum format,
Geoff Langff5b2d52016-09-07 11:32:23 -0400996 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -0400997 const void *pixels,
Geoff Langff5b2d52016-09-07 11:32:23 -0400998 GLsizei imageSize)
999{
1000 gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
1001 if (pixelUnpackBuffer == nullptr && imageSize < 0)
1002 {
1003 // Checks are not required
1004 return true;
1005 }
1006
1007 // ...the data would be unpacked from the buffer object such that the memory reads required
1008 // would exceed the data store size.
Geoff Langdbcced82017-06-06 15:55:54 -04001009 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(format, type);
1010 ASSERT(formatInfo.internalFormat != GL_NONE);
Geoff Langff5b2d52016-09-07 11:32:23 -04001011 const gl::Extents size(width, height, depth);
1012 const auto &unpack = context->getGLState().getUnpackState();
1013
1014 bool targetIs3D = textureTarget == GL_TEXTURE_3D || textureTarget == GL_TEXTURE_2D_ARRAY;
1015 auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, unpack, targetIs3D);
1016 if (endByteOrErr.isError())
1017 {
1018 context->handleError(endByteOrErr.getError());
1019 return false;
1020 }
1021
1022 GLuint endByte = endByteOrErr.getResult();
1023
1024 if (pixelUnpackBuffer)
1025 {
1026 CheckedNumeric<size_t> checkedEndByte(endByteOrErr.getResult());
1027 CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels));
1028 checkedEndByte += checkedOffset;
1029
1030 if (!checkedEndByte.IsValid() ||
1031 (checkedEndByte.ValueOrDie() > static_cast<size_t>(pixelUnpackBuffer->getSize())))
1032 {
1033 // Overflow past the end of the buffer
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001034 context->handleError(InvalidOperation());
Geoff Langff5b2d52016-09-07 11:32:23 -04001035 return false;
1036 }
1037 }
1038 else
1039 {
1040 ASSERT(imageSize >= 0);
1041 if (pixels == nullptr && imageSize != 0)
1042 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001043 context->handleError(InvalidOperation()
1044 << "imageSize must be 0 if no texture data is provided.");
Geoff Lang3feb3ff2016-10-26 10:57:45 -04001045 return false;
Geoff Langff5b2d52016-09-07 11:32:23 -04001046 }
1047
Geoff Lang3feb3ff2016-10-26 10:57:45 -04001048 if (pixels != nullptr && endByte > static_cast<GLuint>(imageSize))
Geoff Langff5b2d52016-09-07 11:32:23 -04001049 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001050 context->handleError(InvalidOperation() << "imageSize must be at least " << endByte);
Geoff Langff5b2d52016-09-07 11:32:23 -04001051 return false;
1052 }
1053 }
1054
1055 return true;
1056}
1057
Geoff Lang37dde692014-01-31 16:34:54 -05001058bool ValidQueryType(const Context *context, GLenum queryType)
1059{
He Yunchaoced53ae2016-11-29 15:00:51 +08001060 static_assert(GL_ANY_SAMPLES_PASSED == GL_ANY_SAMPLES_PASSED_EXT,
1061 "GL extension enums not equal.");
1062 static_assert(GL_ANY_SAMPLES_PASSED_CONSERVATIVE == GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
1063 "GL extension enums not equal.");
Geoff Lang37dde692014-01-31 16:34:54 -05001064
1065 switch (queryType)
1066 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001067 case GL_ANY_SAMPLES_PASSED:
1068 case GL_ANY_SAMPLES_PASSED_CONSERVATIVE:
Geoff Lang8c5b31c2017-09-26 18:07:44 -04001069 return context->getClientMajorVersion() >= 3 ||
1070 context->getExtensions().occlusionQueryBoolean;
He Yunchaoced53ae2016-11-29 15:00:51 +08001071 case GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN:
1072 return (context->getClientMajorVersion() >= 3);
1073 case GL_TIME_ELAPSED_EXT:
1074 return context->getExtensions().disjointTimerQuery;
1075 case GL_COMMANDS_COMPLETED_CHROMIUM:
1076 return context->getExtensions().syncQuery;
1077 default:
1078 return false;
Geoff Lang37dde692014-01-31 16:34:54 -05001079 }
1080}
1081
Geoff Lang2d62ab72017-03-23 16:54:40 -04001082bool ValidateWebGLVertexAttribPointer(ValidationContext *context,
1083 GLenum type,
1084 GLboolean normalized,
1085 GLsizei stride,
Jamie Madill876429b2017-04-20 15:46:24 -04001086 const void *ptr,
Geoff Lang2d62ab72017-03-23 16:54:40 -04001087 bool pureInteger)
1088{
1089 ASSERT(context->getExtensions().webglCompatibility);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001090 // WebGL 1.0 [Section 6.11] Vertex Attribute Data Stride
1091 // The WebGL API supports vertex attribute data strides up to 255 bytes. A call to
1092 // vertexAttribPointer will generate an INVALID_VALUE error if the value for the stride
1093 // parameter exceeds 255.
1094 constexpr GLsizei kMaxWebGLStride = 255;
1095 if (stride > kMaxWebGLStride)
1096 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001097 context->handleError(InvalidValue()
1098 << "Stride is over the maximum stride allowed by WebGL.");
Geoff Lang2d62ab72017-03-23 16:54:40 -04001099 return false;
1100 }
1101
1102 // WebGL 1.0 [Section 6.4] Buffer Offset and Stride Requirements
1103 // The offset arguments to drawElements and vertexAttribPointer, and the stride argument to
1104 // vertexAttribPointer, must be a multiple of the size of the data type passed to the call,
1105 // or an INVALID_OPERATION error is generated.
1106 VertexFormatType internalType = GetVertexFormatType(type, normalized, 1, pureInteger);
1107 size_t typeSize = GetVertexFormatTypeSize(internalType);
1108
1109 ASSERT(isPow2(typeSize) && typeSize > 0);
1110 size_t sizeMask = (typeSize - 1);
1111 if ((reinterpret_cast<intptr_t>(ptr) & sizeMask) != 0)
1112 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001113 ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001114 return false;
1115 }
1116
1117 if ((stride & sizeMask) != 0)
1118 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001119 ANGLE_VALIDATION_ERR(context, InvalidOperation(), StrideMustBeMultipleOfType);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001120 return false;
1121 }
1122
1123 return true;
1124}
1125
Jamie Madillef300b12016-10-07 15:12:09 -04001126Program *GetValidProgram(ValidationContext *context, GLuint id)
Geoff Lang48dcae72014-02-05 16:28:24 -05001127{
He Yunchaoced53ae2016-11-29 15:00:51 +08001128 // ES3 spec (section 2.11.1) -- "Commands that accept shader or program object names will
1129 // generate the error INVALID_VALUE if the provided name is not the name of either a shader
1130 // or program object and INVALID_OPERATION if the provided name identifies an object
1131 // that is not the expected type."
Geoff Lang48dcae72014-02-05 16:28:24 -05001132
Dian Xiang769769a2015-09-09 15:20:08 -07001133 Program *validProgram = context->getProgram(id);
1134
1135 if (!validProgram)
Geoff Lang48dcae72014-02-05 16:28:24 -05001136 {
Dian Xiang769769a2015-09-09 15:20:08 -07001137 if (context->getShader(id))
1138 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001139 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedProgramName);
Dian Xiang769769a2015-09-09 15:20:08 -07001140 }
1141 else
1142 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001143 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidProgramName);
Dian Xiang769769a2015-09-09 15:20:08 -07001144 }
Geoff Lang48dcae72014-02-05 16:28:24 -05001145 }
Dian Xiang769769a2015-09-09 15:20:08 -07001146
1147 return validProgram;
1148}
1149
Jamie Madillef300b12016-10-07 15:12:09 -04001150Shader *GetValidShader(ValidationContext *context, GLuint id)
Dian Xiang769769a2015-09-09 15:20:08 -07001151{
1152 // See ValidProgram for spec details.
1153
1154 Shader *validShader = context->getShader(id);
1155
1156 if (!validShader)
Geoff Lang48dcae72014-02-05 16:28:24 -05001157 {
Dian Xiang769769a2015-09-09 15:20:08 -07001158 if (context->getProgram(id))
1159 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001160 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedShaderName);
Dian Xiang769769a2015-09-09 15:20:08 -07001161 }
1162 else
1163 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001164 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidShaderName);
Dian Xiang769769a2015-09-09 15:20:08 -07001165 }
Geoff Lang48dcae72014-02-05 16:28:24 -05001166 }
Dian Xiang769769a2015-09-09 15:20:08 -07001167
1168 return validShader;
Geoff Lang48dcae72014-02-05 16:28:24 -05001169}
1170
Geoff Langb1196682014-07-23 13:47:29 -04001171bool ValidateAttachmentTarget(gl::Context *context, GLenum attachment)
Jamie Madillb4472272014-07-03 10:38:55 -04001172{
1173 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
1174 {
1175 const unsigned int colorAttachment = (attachment - GL_COLOR_ATTACHMENT0_EXT);
1176
Geoff Langaae65a42014-05-26 12:43:44 -04001177 if (colorAttachment >= context->getCaps().maxColorAttachments)
Jamie Madillb4472272014-07-03 10:38:55 -04001178 {
Martin Radevd178aa42017-07-13 14:03:22 +03001179 context->handleError(
1180 InvalidOperation()
1181 << "attachment index cannot be greater or equal to MAX_COLOR_ATTACHMENTS.");
Geoff Langb1196682014-07-23 13:47:29 -04001182 return false;
Jamie Madillb4472272014-07-03 10:38:55 -04001183 }
1184 }
1185 else
1186 {
1187 switch (attachment)
1188 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001189 case GL_DEPTH_ATTACHMENT:
1190 case GL_STENCIL_ATTACHMENT:
1191 break;
Jamie Madillb4472272014-07-03 10:38:55 -04001192
He Yunchaoced53ae2016-11-29 15:00:51 +08001193 case GL_DEPTH_STENCIL_ATTACHMENT:
1194 if (!context->getExtensions().webglCompatibility &&
1195 context->getClientMajorVersion() < 3)
1196 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001197 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
He Yunchaoced53ae2016-11-29 15:00:51 +08001198 return false;
1199 }
1200 break;
Jamie Madillb4472272014-07-03 10:38:55 -04001201
He Yunchaoced53ae2016-11-29 15:00:51 +08001202 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001203 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
He Yunchaoced53ae2016-11-29 15:00:51 +08001204 return false;
Jamie Madillb4472272014-07-03 10:38:55 -04001205 }
1206 }
1207
1208 return true;
1209}
1210
Jamie Madille8fb6402017-02-14 17:56:40 -05001211bool ValidateRenderbufferStorageParametersBase(ValidationContext *context,
He Yunchaoced53ae2016-11-29 15:00:51 +08001212 GLenum target,
1213 GLsizei samples,
1214 GLenum internalformat,
1215 GLsizei width,
1216 GLsizei height)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001217{
1218 switch (target)
1219 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001220 case GL_RENDERBUFFER:
1221 break;
1222 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001223 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
He Yunchaoced53ae2016-11-29 15:00:51 +08001224 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001225 }
1226
1227 if (width < 0 || height < 0 || samples < 0)
1228 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001229 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidRenderbufferWidthHeight);
Geoff Langb1196682014-07-23 13:47:29 -04001230 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001231 }
1232
Jamie Madill4e0e6f82017-02-17 11:06:03 -05001233 // Hack for the special WebGL 1 "DEPTH_STENCIL" internal format.
1234 GLenum convertedInternalFormat = context->getConvertedRenderbufferFormat(internalformat);
1235
1236 const TextureCaps &formatCaps = context->getTextureCaps().get(convertedInternalFormat);
Geoff Langd87878e2014-09-19 15:42:59 -04001237 if (!formatCaps.renderable)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001238 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001239 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04001240 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001241 }
1242
1243 // ANGLE_framebuffer_multisample does not explicitly state that the internal format must be
1244 // sized but it does state that the format must be in the ES2.0 spec table 4.5 which contains
Corentin Walleze0902642014-11-04 12:32:15 -08001245 // only sized internal formats.
Geoff Langca271392017-04-05 12:30:00 -04001246 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(convertedInternalFormat);
1247 if (formatInfo.internalFormat == GL_NONE)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001248 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001249 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferInternalFormat);
Geoff Langb1196682014-07-23 13:47:29 -04001250 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001251 }
1252
Geoff Langaae65a42014-05-26 12:43:44 -04001253 if (static_cast<GLuint>(std::max(width, height)) > context->getCaps().maxRenderbufferSize)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001254 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001255 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04001256 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001257 }
1258
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001259 GLuint handle = context->getGLState().getRenderbufferId();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001260 if (handle == 0)
1261 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001262 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001263 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001264 }
1265
1266 return true;
1267}
1268
He Yunchaoced53ae2016-11-29 15:00:51 +08001269bool ValidateFramebufferRenderbufferParameters(gl::Context *context,
1270 GLenum target,
1271 GLenum attachment,
1272 GLenum renderbuffertarget,
1273 GLuint renderbuffer)
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001274{
Shannon Woods1da3cf62014-06-27 15:32:23 -04001275 if (!ValidFramebufferTarget(target))
1276 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001277 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04001278 return false;
Shannon Woods1da3cf62014-06-27 15:32:23 -04001279 }
1280
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001281 gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001282
Jamie Madill84115c92015-04-23 15:00:07 -04001283 ASSERT(framebuffer);
1284 if (framebuffer->id() == 0)
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001285 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001286 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001287 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001288 }
1289
Jamie Madillb4472272014-07-03 10:38:55 -04001290 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001291 {
Jamie Madillb4472272014-07-03 10:38:55 -04001292 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001293 }
1294
Jamie Madillab9d82c2014-01-21 16:38:14 -05001295 // [OpenGL ES 2.0.25] Section 4.4.3 page 112
1296 // [OpenGL ES 3.0.2] Section 4.4.2 page 201
1297 // 'renderbuffer' must be either zero or the name of an existing renderbuffer object of
1298 // type 'renderbuffertarget', otherwise an INVALID_OPERATION error is generated.
1299 if (renderbuffer != 0)
1300 {
1301 if (!context->getRenderbuffer(renderbuffer))
1302 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001303 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001304 return false;
Jamie Madillab9d82c2014-01-21 16:38:14 -05001305 }
1306 }
1307
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001308 return true;
1309}
1310
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001311bool ValidateBlitFramebufferParameters(ValidationContext *context,
Jamie Madillc29968b2016-01-20 11:17:23 -05001312 GLint srcX0,
1313 GLint srcY0,
1314 GLint srcX1,
1315 GLint srcY1,
1316 GLint dstX0,
1317 GLint dstY0,
1318 GLint dstX1,
1319 GLint dstY1,
1320 GLbitfield mask,
1321 GLenum filter)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001322{
1323 switch (filter)
1324 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001325 case GL_NEAREST:
1326 break;
1327 case GL_LINEAR:
1328 break;
1329 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001330 context->handleError(InvalidEnum());
He Yunchaoced53ae2016-11-29 15:00:51 +08001331 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001332 }
1333
1334 if ((mask & ~(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT | GL_DEPTH_BUFFER_BIT)) != 0)
1335 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001336 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04001337 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001338 }
1339
1340 if (mask == 0)
1341 {
1342 // ES3.0 spec, section 4.3.2 specifies that a mask of zero is valid and no
1343 // buffers are copied.
1344 return false;
1345 }
1346
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001347 // ES3.0 spec, section 4.3.2 states that linear filtering is only available for the
1348 // color buffer, leaving only nearest being unfiltered from above
1349 if ((mask & ~GL_COLOR_BUFFER_BIT) != 0 && filter != GL_NEAREST)
1350 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001351 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001352 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001353 }
1354
Jamie Madill51f40ec2016-06-15 14:06:00 -04001355 const auto &glState = context->getGLState();
1356 gl::Framebuffer *readFramebuffer = glState.getReadFramebuffer();
1357 gl::Framebuffer *drawFramebuffer = glState.getDrawFramebuffer();
Jamie Madill48faf802014-11-06 15:27:22 -05001358
1359 if (!readFramebuffer || !drawFramebuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001360 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001361 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001362 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001363 }
1364
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001365 if (readFramebuffer->id() == drawFramebuffer->id())
1366 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001367 context->handleError(InvalidOperation());
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001368 return false;
1369 }
1370
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001371 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill48faf802014-11-06 15:27:22 -05001372 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001373 context->handleError(InvalidFramebufferOperation());
Jamie Madill48faf802014-11-06 15:27:22 -05001374 return false;
1375 }
1376
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001377 if (drawFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill48faf802014-11-06 15:27:22 -05001378 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001379 context->handleError(InvalidFramebufferOperation());
Jamie Madill48faf802014-11-06 15:27:22 -05001380 return false;
1381 }
1382
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001383 if (drawFramebuffer->getSamples(context) != 0)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001384 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001385 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001386 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001387 }
1388
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001389 bool sameBounds = srcX0 == dstX0 && srcY0 == dstY0 && srcX1 == dstX1 && srcY1 == dstY1;
1390
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001391 if (mask & GL_COLOR_BUFFER_BIT)
1392 {
Jamie Madillb6bda4a2015-04-20 12:53:26 -04001393 const gl::FramebufferAttachment *readColorBuffer = readFramebuffer->getReadColorbuffer();
Jamie Madill6163c752015-12-07 16:32:59 -05001394 const Extensions &extensions = context->getExtensions();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001395
He Yunchao66a41a22016-12-15 16:45:05 +08001396 if (readColorBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001397 {
Jamie Madilla3944d42016-07-22 22:13:26 -04001398 const Format &readFormat = readColorBuffer->getFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001399
Geoff Langa15472a2015-08-11 11:48:03 -04001400 for (size_t drawbufferIdx = 0;
1401 drawbufferIdx < drawFramebuffer->getDrawbufferStateCount(); ++drawbufferIdx)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001402 {
Geoff Langa15472a2015-08-11 11:48:03 -04001403 const FramebufferAttachment *attachment =
1404 drawFramebuffer->getDrawBuffer(drawbufferIdx);
1405 if (attachment)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001406 {
Jamie Madilla3944d42016-07-22 22:13:26 -04001407 const Format &drawFormat = attachment->getFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001408
Geoff Langb2f3d052013-08-13 12:49:27 -04001409 // The GL ES 3.0.2 spec (pg 193) states that:
1410 // 1) If the read buffer is fixed point format, the draw buffer must be as well
He Yunchaoced53ae2016-11-29 15:00:51 +08001411 // 2) If the read buffer is an unsigned integer format, the draw buffer must be
1412 // as well
1413 // 3) If the read buffer is a signed integer format, the draw buffer must be as
1414 // well
Jamie Madill6163c752015-12-07 16:32:59 -05001415 // Changes with EXT_color_buffer_float:
1416 // Case 1) is changed to fixed point OR floating point
Jamie Madilla3944d42016-07-22 22:13:26 -04001417 GLenum readComponentType = readFormat.info->componentType;
1418 GLenum drawComponentType = drawFormat.info->componentType;
He Yunchaoced53ae2016-11-29 15:00:51 +08001419 bool readFixedPoint = (readComponentType == GL_UNSIGNED_NORMALIZED ||
Jamie Madill6163c752015-12-07 16:32:59 -05001420 readComponentType == GL_SIGNED_NORMALIZED);
1421 bool drawFixedPoint = (drawComponentType == GL_UNSIGNED_NORMALIZED ||
1422 drawComponentType == GL_SIGNED_NORMALIZED);
1423
1424 if (extensions.colorBufferFloat)
1425 {
1426 bool readFixedOrFloat = (readFixedPoint || readComponentType == GL_FLOAT);
1427 bool drawFixedOrFloat = (drawFixedPoint || drawComponentType == GL_FLOAT);
1428
1429 if (readFixedOrFloat != drawFixedOrFloat)
1430 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001431 context->handleError(InvalidOperation()
1432 << "If the read buffer contains fixed-point or "
1433 "floating-point values, the draw buffer must "
1434 "as well.");
Jamie Madill6163c752015-12-07 16:32:59 -05001435 return false;
1436 }
1437 }
1438 else if (readFixedPoint != drawFixedPoint)
1439 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001440 context->handleError(InvalidOperation()
1441 << "If the read buffer contains fixed-point values, "
1442 "the draw buffer must as well.");
Jamie Madill6163c752015-12-07 16:32:59 -05001443 return false;
1444 }
1445
1446 if (readComponentType == GL_UNSIGNED_INT &&
1447 drawComponentType != GL_UNSIGNED_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001448 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001449 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001450 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001451 }
1452
Jamie Madill6163c752015-12-07 16:32:59 -05001453 if (readComponentType == GL_INT && drawComponentType != GL_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001454 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001455 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001456 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001457 }
1458
Jamie Madilla3944d42016-07-22 22:13:26 -04001459 if (readColorBuffer->getSamples() > 0 &&
Kenneth Russell69382852017-07-21 16:38:44 -04001460 (!Format::EquivalentForBlit(readFormat, drawFormat) || !sameBounds))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001461 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001462 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001463 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001464 }
Geoff Lange4915782017-04-12 15:19:07 -04001465
1466 if (context->getExtensions().webglCompatibility &&
1467 *readColorBuffer == *attachment)
1468 {
1469 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001470 InvalidOperation()
1471 << "Read and write color attachments cannot be the same image.");
Geoff Lange4915782017-04-12 15:19:07 -04001472 return false;
1473 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001474 }
1475 }
1476
Jamie Madilla3944d42016-07-22 22:13:26 -04001477 if ((readFormat.info->componentType == GL_INT ||
1478 readFormat.info->componentType == GL_UNSIGNED_INT) &&
1479 filter == GL_LINEAR)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001480 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001481 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001482 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001483 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001484 }
He Yunchao66a41a22016-12-15 16:45:05 +08001485 // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment
1486 // In OpenGL ES it is undefined what happens when an operation tries to blit from a missing
1487 // attachment and WebGL defines it to be an error. We do the check unconditionally as the
1488 // situation is an application error that would lead to a crash in ANGLE.
1489 else if (drawFramebuffer->hasEnabledDrawBuffer())
1490 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001491 context->handleError(
1492 InvalidOperation()
1493 << "Attempt to read from a missing color attachment of a complete framebuffer.");
He Yunchao66a41a22016-12-15 16:45:05 +08001494 return false;
1495 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001496 }
1497
He Yunchaoced53ae2016-11-29 15:00:51 +08001498 GLenum masks[] = {GL_DEPTH_BUFFER_BIT, GL_STENCIL_BUFFER_BIT};
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001499 GLenum attachments[] = {GL_DEPTH_ATTACHMENT, GL_STENCIL_ATTACHMENT};
1500 for (size_t i = 0; i < 2; i++)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001501 {
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001502 if (mask & masks[i])
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001503 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001504 const gl::FramebufferAttachment *readBuffer =
1505 readFramebuffer->getAttachment(attachments[i]);
1506 const gl::FramebufferAttachment *drawBuffer =
1507 drawFramebuffer->getAttachment(attachments[i]);
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001508
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001509 if (readBuffer && drawBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001510 {
Kenneth Russell69382852017-07-21 16:38:44 -04001511 if (!Format::EquivalentForBlit(readBuffer->getFormat(), drawBuffer->getFormat()))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001512 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001513 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001514 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001515 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001516
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001517 if (readBuffer->getSamples() > 0 && !sameBounds)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001518 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001519 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001520 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001521 }
Geoff Lange4915782017-04-12 15:19:07 -04001522
1523 if (context->getExtensions().webglCompatibility && *readBuffer == *drawBuffer)
1524 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001525 context->handleError(
1526 InvalidOperation()
1527 << "Read and write depth stencil attachments cannot be the same image.");
Geoff Lange4915782017-04-12 15:19:07 -04001528 return false;
1529 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001530 }
He Yunchao66a41a22016-12-15 16:45:05 +08001531 // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment
1532 else if (drawBuffer)
1533 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001534 context->handleError(InvalidOperation() << "Attempt to read from a missing "
1535 "depth/stencil attachment of a "
1536 "complete framebuffer.");
He Yunchao66a41a22016-12-15 16:45:05 +08001537 return false;
1538 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001539 }
1540 }
1541
Martin Radeva3ed4572017-07-27 18:29:37 +03001542 // ANGLE_multiview, Revision 1:
1543 // Calling BlitFramebuffer will result in an INVALID_FRAMEBUFFER_OPERATION error if the
1544 // multi-view layout of the current draw framebuffer or read framebuffer is not NONE.
1545 if (readFramebuffer->getMultiviewLayout() != GL_NONE)
1546 {
1547 context->handleError(InvalidFramebufferOperation()
1548 << "Attempt to read from a multi-view framebuffer.");
1549 return false;
1550 }
1551 if (drawFramebuffer->getMultiviewLayout() != GL_NONE)
1552 {
1553 context->handleError(InvalidFramebufferOperation()
1554 << "Attempt to write to a multi-view framebuffer.");
1555 return false;
1556 }
1557
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001558 return true;
1559}
1560
Jamie Madill4928b7c2017-06-20 12:57:39 -04001561bool ValidateReadPixelsRobustANGLE(Context *context,
Geoff Lang62fce5b2016-09-30 10:46:35 -04001562 GLint x,
1563 GLint y,
1564 GLsizei width,
1565 GLsizei height,
1566 GLenum format,
1567 GLenum type,
1568 GLsizei bufSize,
1569 GLsizei *length,
Geoff Lange93daba2017-03-30 13:54:40 -04001570 GLsizei *columns,
1571 GLsizei *rows,
Jamie Madill876429b2017-04-20 15:46:24 -04001572 void *pixels)
Geoff Lang62fce5b2016-09-30 10:46:35 -04001573{
1574 if (!ValidateRobustEntryPoint(context, bufSize))
Jamie Madillc29968b2016-01-20 11:17:23 -05001575 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001576 return false;
1577 }
1578
Geoff Lang62fce5b2016-09-30 10:46:35 -04001579 if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length,
Geoff Lange93daba2017-03-30 13:54:40 -04001580 columns, rows, pixels))
Jamie Madill26e91952014-03-05 15:01:27 -05001581 {
Geoff Langb1196682014-07-23 13:47:29 -04001582 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001583 }
1584
Geoff Lang62fce5b2016-09-30 10:46:35 -04001585 if (!ValidateRobustBufferSize(context, bufSize, *length))
Jamie Madill26e91952014-03-05 15:01:27 -05001586 {
Geoff Langb1196682014-07-23 13:47:29 -04001587 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001588 }
1589
Jamie Madillc29968b2016-01-20 11:17:23 -05001590 return true;
1591}
1592
1593bool ValidateReadnPixelsEXT(Context *context,
1594 GLint x,
1595 GLint y,
1596 GLsizei width,
1597 GLsizei height,
1598 GLenum format,
1599 GLenum type,
1600 GLsizei bufSize,
Jamie Madill876429b2017-04-20 15:46:24 -04001601 void *pixels)
Jamie Madillc29968b2016-01-20 11:17:23 -05001602{
1603 if (bufSize < 0)
1604 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001605 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Jamie Madillc29968b2016-01-20 11:17:23 -05001606 return false;
1607 }
1608
Geoff Lang62fce5b2016-09-30 10:46:35 -04001609 return ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, nullptr,
Geoff Lange93daba2017-03-30 13:54:40 -04001610 nullptr, nullptr, pixels);
Geoff Lang62fce5b2016-09-30 10:46:35 -04001611}
Jamie Madill26e91952014-03-05 15:01:27 -05001612
Jamie Madill4928b7c2017-06-20 12:57:39 -04001613bool ValidateReadnPixelsRobustANGLE(Context *context,
Geoff Lang62fce5b2016-09-30 10:46:35 -04001614 GLint x,
1615 GLint y,
1616 GLsizei width,
1617 GLsizei height,
1618 GLenum format,
1619 GLenum type,
1620 GLsizei bufSize,
1621 GLsizei *length,
Geoff Lange93daba2017-03-30 13:54:40 -04001622 GLsizei *columns,
1623 GLsizei *rows,
Jamie Madill876429b2017-04-20 15:46:24 -04001624 void *data)
Geoff Lang62fce5b2016-09-30 10:46:35 -04001625{
1626 if (!ValidateRobustEntryPoint(context, bufSize))
Jamie Madille2e406c2016-06-02 13:04:10 -04001627 {
Jamie Madille2e406c2016-06-02 13:04:10 -04001628 return false;
1629 }
1630
Geoff Lange93daba2017-03-30 13:54:40 -04001631 if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length,
1632 columns, rows, data))
Jamie Madille2e406c2016-06-02 13:04:10 -04001633 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001634 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001635 }
1636
Geoff Lang62fce5b2016-09-30 10:46:35 -04001637 if (!ValidateRobustBufferSize(context, bufSize, *length))
1638 {
1639 return false;
1640 }
1641
1642 return true;
Jamie Madill26e91952014-03-05 15:01:27 -05001643}
1644
Jamie Madillf0e04492017-08-26 15:28:42 -04001645bool ValidateGenQueriesEXT(gl::Context *context, GLsizei n, GLuint *ids)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001646{
1647 if (!context->getExtensions().occlusionQueryBoolean &&
1648 !context->getExtensions().disjointTimerQuery)
1649 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001650 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001651 return false;
1652 }
1653
Olli Etuaho41997e72016-03-10 13:38:39 +02001654 return ValidateGenOrDelete(context, n);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001655}
1656
Jamie Madillf0e04492017-08-26 15:28:42 -04001657bool ValidateDeleteQueriesEXT(gl::Context *context, GLsizei n, const GLuint *ids)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001658{
1659 if (!context->getExtensions().occlusionQueryBoolean &&
1660 !context->getExtensions().disjointTimerQuery)
1661 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001662 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001663 return false;
1664 }
1665
Olli Etuaho41997e72016-03-10 13:38:39 +02001666 return ValidateGenOrDelete(context, n);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001667}
1668
Jamie Madillf0e04492017-08-26 15:28:42 -04001669bool ValidateIsQueryEXT(gl::Context *context, GLuint id)
1670{
1671 if (!context->getExtensions().occlusionQueryBoolean &&
1672 !context->getExtensions().disjointTimerQuery)
1673 {
1674 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled);
1675 return false;
1676 }
1677
1678 return true;
1679}
1680
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001681bool ValidateBeginQueryBase(gl::Context *context, GLenum target, GLuint id)
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001682{
1683 if (!ValidQueryType(context, target))
1684 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001685 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryType);
Geoff Langb1196682014-07-23 13:47:29 -04001686 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001687 }
1688
1689 if (id == 0)
1690 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001691 context->handleError(InvalidOperation() << "Query id is 0");
Geoff Langb1196682014-07-23 13:47:29 -04001692 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001693 }
1694
1695 // From EXT_occlusion_query_boolean: If BeginQueryEXT is called with an <id>
1696 // of zero, if the active query object name for <target> is non-zero (for the
1697 // targets ANY_SAMPLES_PASSED_EXT and ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, if
1698 // the active query for either target is non-zero), if <id> is the name of an
1699 // existing query object whose type does not match <target>, or if <id> is the
1700 // active query object name for any query type, the error INVALID_OPERATION is
1701 // generated.
1702
1703 // Ensure no other queries are active
1704 // NOTE: If other queries than occlusion are supported, we will need to check
1705 // separately that:
1706 // a) The query ID passed is not the current active query for any target/type
1707 // b) There are no active queries for the requested target (and in the case
1708 // of GL_ANY_SAMPLES_PASSED_EXT and GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
1709 // no query may be active for either if glBeginQuery targets either.
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001710
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001711 if (context->getGLState().isQueryActive(target))
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001712 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001713 context->handleError(InvalidOperation() << "Other query is active");
Geoff Langb1196682014-07-23 13:47:29 -04001714 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001715 }
1716
1717 Query *queryObject = context->getQuery(id, true, target);
1718
1719 // check that name was obtained with glGenQueries
1720 if (!queryObject)
1721 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001722 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidQueryId);
Geoff Langb1196682014-07-23 13:47:29 -04001723 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001724 }
1725
1726 // check for type mismatch
1727 if (queryObject->getType() != target)
1728 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001729 context->handleError(InvalidOperation() << "Query type does not match target");
Geoff Langb1196682014-07-23 13:47:29 -04001730 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001731 }
1732
1733 return true;
1734}
1735
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001736bool ValidateBeginQueryEXT(gl::Context *context, GLenum target, GLuint id)
1737{
1738 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001739 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001740 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001741 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001742 return false;
1743 }
1744
1745 return ValidateBeginQueryBase(context, target, id);
1746}
1747
1748bool ValidateEndQueryBase(gl::Context *context, GLenum target)
Jamie Madill45c785d2014-05-13 14:09:34 -04001749{
1750 if (!ValidQueryType(context, target))
1751 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001752 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryType);
Geoff Langb1196682014-07-23 13:47:29 -04001753 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04001754 }
1755
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001756 const Query *queryObject = context->getGLState().getActiveQuery(target);
Jamie Madill45c785d2014-05-13 14:09:34 -04001757
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001758 if (queryObject == nullptr)
Jamie Madill45c785d2014-05-13 14:09:34 -04001759 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001760 context->handleError(InvalidOperation() << "Query target not active");
Geoff Langb1196682014-07-23 13:47:29 -04001761 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04001762 }
1763
Jamie Madill45c785d2014-05-13 14:09:34 -04001764 return true;
1765}
1766
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001767bool ValidateEndQueryEXT(gl::Context *context, GLenum target)
1768{
1769 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001770 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001771 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001772 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001773 return false;
1774 }
1775
1776 return ValidateEndQueryBase(context, target);
1777}
1778
1779bool ValidateQueryCounterEXT(Context *context, GLuint id, GLenum target)
1780{
1781 if (!context->getExtensions().disjointTimerQuery)
1782 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001783 context->handleError(InvalidOperation() << "Disjoint timer query not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001784 return false;
1785 }
1786
1787 if (target != GL_TIMESTAMP_EXT)
1788 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001789 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryTarget);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001790 return false;
1791 }
1792
1793 Query *queryObject = context->getQuery(id, true, target);
1794 if (queryObject == nullptr)
1795 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001796 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidQueryId);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001797 return false;
1798 }
1799
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001800 if (context->getGLState().isQueryActive(queryObject))
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001801 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001802 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryActive);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001803 return false;
1804 }
1805
1806 return true;
1807}
1808
Geoff Lang2186c382016-10-14 10:54:54 -04001809bool ValidateGetQueryivBase(Context *context, GLenum target, GLenum pname, GLsizei *numParams)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001810{
Geoff Lang2186c382016-10-14 10:54:54 -04001811 if (numParams)
1812 {
1813 *numParams = 0;
1814 }
1815
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001816 if (!ValidQueryType(context, target) && target != GL_TIMESTAMP_EXT)
1817 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001818 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryType);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001819 return false;
1820 }
1821
1822 switch (pname)
1823 {
1824 case GL_CURRENT_QUERY_EXT:
1825 if (target == GL_TIMESTAMP_EXT)
1826 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001827 context->handleError(InvalidEnum() << "Cannot use current query for timestamp");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001828 return false;
1829 }
1830 break;
1831 case GL_QUERY_COUNTER_BITS_EXT:
1832 if (!context->getExtensions().disjointTimerQuery ||
1833 (target != GL_TIMESTAMP_EXT && target != GL_TIME_ELAPSED_EXT))
1834 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001835 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidPname);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001836 return false;
1837 }
1838 break;
1839 default:
Brandon Jonesafa75152017-07-21 13:11:29 -07001840 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidPname);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001841 return false;
1842 }
1843
Geoff Lang2186c382016-10-14 10:54:54 -04001844 if (numParams)
1845 {
1846 // All queries return only one value
1847 *numParams = 1;
1848 }
1849
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001850 return true;
1851}
1852
1853bool ValidateGetQueryivEXT(Context *context, GLenum target, GLenum pname, GLint *params)
1854{
1855 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001856 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001857 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001858 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001859 return false;
1860 }
1861
Geoff Lang2186c382016-10-14 10:54:54 -04001862 return ValidateGetQueryivBase(context, target, pname, nullptr);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001863}
1864
Geoff Lang2186c382016-10-14 10:54:54 -04001865bool ValidateGetQueryivRobustANGLE(Context *context,
1866 GLenum target,
1867 GLenum pname,
1868 GLsizei bufSize,
1869 GLsizei *length,
1870 GLint *params)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001871{
Geoff Lang2186c382016-10-14 10:54:54 -04001872 if (!ValidateRobustEntryPoint(context, bufSize))
1873 {
1874 return false;
1875 }
1876
1877 if (!ValidateGetQueryivBase(context, target, pname, length))
1878 {
1879 return false;
1880 }
1881
1882 if (!ValidateRobustBufferSize(context, bufSize, *length))
1883 {
1884 return false;
1885 }
1886
1887 return true;
1888}
1889
1890bool ValidateGetQueryObjectValueBase(Context *context, GLuint id, GLenum pname, GLsizei *numParams)
1891{
1892 if (numParams)
1893 {
1894 *numParams = 0;
1895 }
1896
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001897 Query *queryObject = context->getQuery(id, false, GL_NONE);
1898
1899 if (!queryObject)
1900 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001901 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidQueryId);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001902 return false;
1903 }
1904
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001905 if (context->getGLState().isQueryActive(queryObject))
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001906 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001907 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryActive);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001908 return false;
1909 }
1910
1911 switch (pname)
1912 {
1913 case GL_QUERY_RESULT_EXT:
1914 case GL_QUERY_RESULT_AVAILABLE_EXT:
1915 break;
1916
1917 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001918 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001919 return false;
1920 }
1921
Geoff Lang2186c382016-10-14 10:54:54 -04001922 if (numParams)
1923 {
1924 *numParams = 1;
1925 }
1926
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001927 return true;
1928}
1929
1930bool ValidateGetQueryObjectivEXT(Context *context, GLuint id, GLenum pname, GLint *params)
1931{
1932 if (!context->getExtensions().disjointTimerQuery)
1933 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001934 context->handleError(InvalidOperation() << "Timer query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001935 return false;
1936 }
Geoff Lang2186c382016-10-14 10:54:54 -04001937 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
1938}
1939
1940bool ValidateGetQueryObjectivRobustANGLE(Context *context,
1941 GLuint id,
1942 GLenum pname,
1943 GLsizei bufSize,
1944 GLsizei *length,
1945 GLint *params)
1946{
1947 if (!context->getExtensions().disjointTimerQuery)
1948 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001949 context->handleError(InvalidOperation() << "Timer query extension not enabled");
Geoff Lang2186c382016-10-14 10:54:54 -04001950 return false;
1951 }
1952
1953 if (!ValidateRobustEntryPoint(context, bufSize))
1954 {
1955 return false;
1956 }
1957
1958 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
1959 {
1960 return false;
1961 }
1962
1963 if (!ValidateRobustBufferSize(context, bufSize, *length))
1964 {
1965 return false;
1966 }
1967
1968 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001969}
1970
1971bool ValidateGetQueryObjectuivEXT(Context *context, GLuint id, GLenum pname, GLuint *params)
1972{
1973 if (!context->getExtensions().disjointTimerQuery &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001974 !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001975 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001976 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001977 return false;
1978 }
Geoff Lang2186c382016-10-14 10:54:54 -04001979 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
1980}
1981
1982bool ValidateGetQueryObjectuivRobustANGLE(Context *context,
1983 GLuint id,
1984 GLenum pname,
1985 GLsizei bufSize,
1986 GLsizei *length,
1987 GLuint *params)
1988{
1989 if (!context->getExtensions().disjointTimerQuery &&
1990 !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery)
1991 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001992 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04001993 return false;
1994 }
1995
1996 if (!ValidateRobustEntryPoint(context, bufSize))
1997 {
1998 return false;
1999 }
2000
2001 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2002 {
2003 return false;
2004 }
2005
2006 if (!ValidateRobustBufferSize(context, bufSize, *length))
2007 {
2008 return false;
2009 }
2010
2011 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002012}
2013
2014bool ValidateGetQueryObjecti64vEXT(Context *context, GLuint id, GLenum pname, GLint64 *params)
2015{
2016 if (!context->getExtensions().disjointTimerQuery)
2017 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002018 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002019 return false;
2020 }
Geoff Lang2186c382016-10-14 10:54:54 -04002021 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2022}
2023
2024bool ValidateGetQueryObjecti64vRobustANGLE(Context *context,
2025 GLuint id,
2026 GLenum pname,
2027 GLsizei bufSize,
2028 GLsizei *length,
2029 GLint64 *params)
2030{
2031 if (!context->getExtensions().disjointTimerQuery)
2032 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002033 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002034 return false;
2035 }
2036
2037 if (!ValidateRobustEntryPoint(context, bufSize))
2038 {
2039 return false;
2040 }
2041
2042 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2043 {
2044 return false;
2045 }
2046
2047 if (!ValidateRobustBufferSize(context, bufSize, *length))
2048 {
2049 return false;
2050 }
2051
2052 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002053}
2054
2055bool ValidateGetQueryObjectui64vEXT(Context *context, GLuint id, GLenum pname, GLuint64 *params)
2056{
2057 if (!context->getExtensions().disjointTimerQuery)
2058 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002059 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002060 return false;
2061 }
Geoff Lang2186c382016-10-14 10:54:54 -04002062 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2063}
2064
2065bool ValidateGetQueryObjectui64vRobustANGLE(Context *context,
2066 GLuint id,
2067 GLenum pname,
2068 GLsizei bufSize,
2069 GLsizei *length,
2070 GLuint64 *params)
2071{
2072 if (!context->getExtensions().disjointTimerQuery)
2073 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002074 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002075 return false;
2076 }
2077
2078 if (!ValidateRobustEntryPoint(context, bufSize))
2079 {
2080 return false;
2081 }
2082
2083 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2084 {
2085 return false;
2086 }
2087
2088 if (!ValidateRobustBufferSize(context, bufSize, *length))
2089 {
2090 return false;
2091 }
2092
2093 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002094}
2095
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002096bool ValidateProgramUniform(gl::Context *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002097 GLenum valueType,
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002098 GLuint program,
2099 GLint location,
2100 GLsizei count)
2101{
2102 // Check for ES31 program uniform entry points
2103 if (context->getClientVersion() < Version(3, 1))
2104 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08002105 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES31Required);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002106 return false;
2107 }
2108
2109 const LinkedUniform *uniform = nullptr;
2110 gl::Program *programObject = GetValidProgram(context, program);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002111 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2112 ValidateUniformValue(context, valueType, uniform->type);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002113}
2114
Frank Henigmana98a6472017-02-02 21:38:32 -05002115bool ValidateProgramUniform1iv(gl::Context *context,
2116 GLuint program,
2117 GLint location,
2118 GLsizei count,
2119 const GLint *value)
2120{
2121 // Check for ES31 program uniform entry points
2122 if (context->getClientVersion() < Version(3, 1))
2123 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08002124 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES31Required);
Frank Henigmana98a6472017-02-02 21:38:32 -05002125 return false;
2126 }
2127
2128 const LinkedUniform *uniform = nullptr;
2129 gl::Program *programObject = GetValidProgram(context, program);
2130 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2131 ValidateUniform1ivValue(context, uniform->type, count, value);
2132}
2133
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002134bool ValidateProgramUniformMatrix(gl::Context *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002135 GLenum valueType,
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002136 GLuint program,
2137 GLint location,
2138 GLsizei count,
2139 GLboolean transpose)
2140{
2141 // Check for ES31 program uniform entry points
2142 if (context->getClientVersion() < Version(3, 1))
2143 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08002144 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES31Required);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002145 return false;
2146 }
2147
2148 const LinkedUniform *uniform = nullptr;
2149 gl::Program *programObject = GetValidProgram(context, program);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002150 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2151 ValidateUniformMatrixValue(context, valueType, uniform->type);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002152}
2153
Jamie Madillc1d770e2017-04-13 17:31:24 -04002154bool ValidateUniform(ValidationContext *context, GLenum valueType, GLint location, GLsizei count)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002155{
Jamie Madill62d31cb2015-09-11 13:25:51 -04002156 const LinkedUniform *uniform = nullptr;
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002157 gl::Program *programObject = context->getGLState().getProgram();
2158 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2159 ValidateUniformValue(context, valueType, uniform->type);
Jamie Madillaa981bd2014-05-20 10:55:55 -04002160}
2161
Jamie Madillbe849e42017-05-02 15:49:00 -04002162bool ValidateUniform1iv(ValidationContext *context,
2163 GLint location,
2164 GLsizei count,
2165 const GLint *value)
Frank Henigmana98a6472017-02-02 21:38:32 -05002166{
2167 const LinkedUniform *uniform = nullptr;
2168 gl::Program *programObject = context->getGLState().getProgram();
2169 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2170 ValidateUniform1ivValue(context, uniform->type, count, value);
2171}
2172
Jamie Madillc1d770e2017-04-13 17:31:24 -04002173bool ValidateUniformMatrix(ValidationContext *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002174 GLenum valueType,
He Yunchaoced53ae2016-11-29 15:00:51 +08002175 GLint location,
2176 GLsizei count,
Jamie Madillaa981bd2014-05-20 10:55:55 -04002177 GLboolean transpose)
2178{
Martin Radev1be913c2016-07-11 17:59:16 +03002179 if (transpose != GL_FALSE && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002180 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002181 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002182 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002183 }
2184
Jamie Madill62d31cb2015-09-11 13:25:51 -04002185 const LinkedUniform *uniform = nullptr;
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002186 gl::Program *programObject = context->getGLState().getProgram();
2187 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2188 ValidateUniformMatrixValue(context, valueType, uniform->type);
Jamie Madillaa981bd2014-05-20 10:55:55 -04002189}
2190
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002191bool ValidateStateQuery(ValidationContext *context,
2192 GLenum pname,
2193 GLenum *nativeType,
2194 unsigned int *numParams)
Jamie Madill893ab082014-05-16 16:56:10 -04002195{
2196 if (!context->getQueryParameterInfo(pname, nativeType, numParams))
2197 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002198 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04002199 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002200 }
2201
Jamie Madill0af26e12015-03-05 19:54:33 -05002202 const Caps &caps = context->getCaps();
2203
Jamie Madill893ab082014-05-16 16:56:10 -04002204 if (pname >= GL_DRAW_BUFFER0 && pname <= GL_DRAW_BUFFER15)
2205 {
2206 unsigned int colorAttachment = (pname - GL_DRAW_BUFFER0);
2207
Jamie Madill0af26e12015-03-05 19:54:33 -05002208 if (colorAttachment >= caps.maxDrawBuffers)
Jamie Madill893ab082014-05-16 16:56:10 -04002209 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002210 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002211 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002212 }
2213 }
2214
2215 switch (pname)
2216 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002217 case GL_TEXTURE_BINDING_2D:
2218 case GL_TEXTURE_BINDING_CUBE_MAP:
2219 case GL_TEXTURE_BINDING_3D:
2220 case GL_TEXTURE_BINDING_2D_ARRAY:
JiangYizhou24fe74c2017-07-06 16:56:50 +08002221 case GL_TEXTURE_BINDING_2D_MULTISAMPLE:
He Yunchaoced53ae2016-11-29 15:00:51 +08002222 break;
Corentin Wallez13c0dd42017-07-04 18:27:01 -04002223 case GL_TEXTURE_BINDING_RECTANGLE_ANGLE:
2224 if (!context->getExtensions().textureRectangle)
2225 {
2226 context->handleError(InvalidEnum()
2227 << "ANGLE_texture_rectangle extension not present");
2228 return false;
2229 }
2230 break;
He Yunchaoced53ae2016-11-29 15:00:51 +08002231 case GL_TEXTURE_BINDING_EXTERNAL_OES:
2232 if (!context->getExtensions().eglStreamConsumerExternal &&
2233 !context->getExtensions().eglImageExternal)
2234 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002235 context->handleError(InvalidEnum() << "Neither NV_EGL_stream_consumer_external "
2236 "nor GL_OES_EGL_image_external "
2237 "extensions enabled");
He Yunchaoced53ae2016-11-29 15:00:51 +08002238 return false;
2239 }
2240 break;
Jamie Madill893ab082014-05-16 16:56:10 -04002241
He Yunchaoced53ae2016-11-29 15:00:51 +08002242 case GL_IMPLEMENTATION_COLOR_READ_TYPE:
2243 case GL_IMPLEMENTATION_COLOR_READ_FORMAT:
Jamie Madill893ab082014-05-16 16:56:10 -04002244 {
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002245 if (context->getGLState().getReadFramebuffer()->checkStatus(context) !=
2246 GL_FRAMEBUFFER_COMPLETE)
Jamie Madill893ab082014-05-16 16:56:10 -04002247 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002248 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002249 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002250 }
2251
Jamie Madill51f40ec2016-06-15 14:06:00 -04002252 const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer();
2253 ASSERT(framebuffer);
Martin Radev138064f2016-07-15 12:03:41 +03002254
2255 if (framebuffer->getReadBufferState() == GL_NONE)
2256 {
Brandon Jonesafa75152017-07-21 13:11:29 -07002257 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ReadBufferNone);
Martin Radev138064f2016-07-15 12:03:41 +03002258 return false;
2259 }
2260
Jamie Madillb6bda4a2015-04-20 12:53:26 -04002261 const FramebufferAttachment *attachment = framebuffer->getReadColorbuffer();
Jamie Madill3c7fa222014-06-05 13:08:51 -04002262 if (!attachment)
Jamie Madill893ab082014-05-16 16:56:10 -04002263 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002264 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002265 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002266 }
2267 }
2268 break;
2269
He Yunchaoced53ae2016-11-29 15:00:51 +08002270 default:
2271 break;
Jamie Madill893ab082014-05-16 16:56:10 -04002272 }
2273
2274 // pname is valid, but there are no parameters to return
Geoff Langff5b2d52016-09-07 11:32:23 -04002275 if (*numParams == 0)
2276 {
2277 return false;
2278 }
2279
2280 return true;
2281}
2282
2283bool ValidateRobustStateQuery(ValidationContext *context,
2284 GLenum pname,
2285 GLsizei bufSize,
2286 GLenum *nativeType,
2287 unsigned int *numParams)
2288{
2289 if (!ValidateRobustEntryPoint(context, bufSize))
2290 {
2291 return false;
2292 }
2293
2294 if (!ValidateStateQuery(context, pname, nativeType, numParams))
2295 {
2296 return false;
2297 }
2298
2299 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
Jamie Madill893ab082014-05-16 16:56:10 -04002300 {
2301 return false;
2302 }
2303
2304 return true;
2305}
2306
Jamie Madillc29968b2016-01-20 11:17:23 -05002307bool ValidateCopyTexImageParametersBase(ValidationContext *context,
2308 GLenum target,
2309 GLint level,
2310 GLenum internalformat,
2311 bool isSubImage,
2312 GLint xoffset,
2313 GLint yoffset,
2314 GLint zoffset,
2315 GLint x,
2316 GLint y,
2317 GLsizei width,
2318 GLsizei height,
2319 GLint border,
Jamie Madill0c8abca2016-07-22 20:21:26 -04002320 Format *textureFormatOut)
Jamie Madill560a8d82014-05-21 13:06:20 -04002321{
Brandon Jones6cad5662017-06-14 13:25:13 -07002322 if (xoffset < 0 || yoffset < 0 || zoffset < 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04002323 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002324 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
2325 return false;
2326 }
2327
2328 if (width < 0 || height < 0)
2329 {
2330 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Geoff Langb1196682014-07-23 13:47:29 -04002331 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002332 }
2333
He Yunchaoced53ae2016-11-29 15:00:51 +08002334 if (std::numeric_limits<GLsizei>::max() - xoffset < width ||
2335 std::numeric_limits<GLsizei>::max() - yoffset < height)
Jamie Madill560a8d82014-05-21 13:06:20 -04002336 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002337 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002338 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002339 }
2340
2341 if (border != 0)
2342 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002343 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidBorder);
Geoff Langb1196682014-07-23 13:47:29 -04002344 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002345 }
2346
2347 if (!ValidMipLevel(context, target, level))
2348 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002349 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Geoff Langb1196682014-07-23 13:47:29 -04002350 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002351 }
2352
Jamie Madill51f40ec2016-06-15 14:06:00 -04002353 const auto &state = context->getGLState();
2354 auto readFramebuffer = state.getReadFramebuffer();
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002355 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill560a8d82014-05-21 13:06:20 -04002356 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002357 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002358 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002359 }
2360
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002361 if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04002362 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002363 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002364 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002365 }
2366
Martin Radev138064f2016-07-15 12:03:41 +03002367 if (readFramebuffer->getReadBufferState() == GL_NONE)
2368 {
Brandon Jonesafa75152017-07-21 13:11:29 -07002369 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ReadBufferNone);
Martin Radev138064f2016-07-15 12:03:41 +03002370 return false;
2371 }
2372
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002373 // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment
2374 // In OpenGL ES it is undefined what happens when an operation tries to read from a missing
He Yunchao66a41a22016-12-15 16:45:05 +08002375 // attachment and WebGL defines it to be an error. We do the check unconditionally as the
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002376 // situation is an application error that would lead to a crash in ANGLE.
Martin Radev04e2c3b2017-07-27 16:54:35 +03002377 const FramebufferAttachment *source = readFramebuffer->getReadColorbuffer();
2378 if (source == nullptr)
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002379 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002380 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment);
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002381 return false;
2382 }
2383
Martin Radev04e2c3b2017-07-27 16:54:35 +03002384 // ANGLE_multiview spec, Revision 1:
2385 // Calling CopyTexSubImage3D, CopyTexImage2D, or CopyTexSubImage2D will result in an
2386 // INVALID_FRAMEBUFFER_OPERATION error if the multi-view layout of the current read framebuffer
2387 // is not NONE.
2388 if (source->getMultiviewLayout() != GL_NONE)
2389 {
2390 context->handleError(InvalidFramebufferOperation()
2391 << "The active read framebuffer object has multiview attachments.");
2392 return false;
2393 }
2394
Geoff Langaae65a42014-05-26 12:43:44 -04002395 const gl::Caps &caps = context->getCaps();
2396
Geoff Langaae65a42014-05-26 12:43:44 -04002397 GLuint maxDimension = 0;
Jamie Madill560a8d82014-05-21 13:06:20 -04002398 switch (target)
2399 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002400 case GL_TEXTURE_2D:
2401 maxDimension = caps.max2DTextureSize;
2402 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002403
He Yunchaoced53ae2016-11-29 15:00:51 +08002404 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
2405 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
2406 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
2407 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
2408 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
2409 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
2410 maxDimension = caps.maxCubeMapTextureSize;
2411 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002412
Corentin Wallez13c0dd42017-07-04 18:27:01 -04002413 case GL_TEXTURE_RECTANGLE_ANGLE:
2414 maxDimension = caps.maxRectangleTextureSize;
2415 break;
2416
He Yunchaoced53ae2016-11-29 15:00:51 +08002417 case GL_TEXTURE_2D_ARRAY:
2418 maxDimension = caps.max2DTextureSize;
2419 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002420
He Yunchaoced53ae2016-11-29 15:00:51 +08002421 case GL_TEXTURE_3D:
2422 maxDimension = caps.max3DTextureSize;
2423 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002424
He Yunchaoced53ae2016-11-29 15:00:51 +08002425 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002426 context->handleError(InvalidEnum());
He Yunchaoced53ae2016-11-29 15:00:51 +08002427 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002428 }
2429
Jamie Madillc29968b2016-01-20 11:17:23 -05002430 gl::Texture *texture =
2431 state.getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target);
Jamie Madill560a8d82014-05-21 13:06:20 -04002432 if (!texture)
2433 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002434 ANGLE_VALIDATION_ERR(context, InvalidOperation(), TextureNotBound);
Geoff Langb1196682014-07-23 13:47:29 -04002435 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002436 }
2437
Geoff Lang69cce582015-09-17 13:20:36 -04002438 if (texture->getImmutableFormat() && !isSubImage)
Jamie Madill560a8d82014-05-21 13:06:20 -04002439 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002440 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002441 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002442 }
2443
Geoff Langca271392017-04-05 12:30:00 -04002444 const gl::InternalFormat &formatInfo =
Geoff Lang86f81162017-10-30 15:10:45 -04002445 isSubImage ? *texture->getFormat(target, level).info
2446 : gl::GetInternalFormatInfo(internalformat, GL_UNSIGNED_BYTE);
Geoff Lang5d601382014-07-22 15:14:06 -04002447
Geoff Lang966c9402017-04-18 12:38:27 -04002448 if (formatInfo.depthBits > 0 || formatInfo.compressed)
Jamie Madill560a8d82014-05-21 13:06:20 -04002449 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002450 context->handleError(InvalidOperation());
Geoff Langa9be0dc2014-12-17 12:34:40 -05002451 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002452 }
2453
2454 if (isSubImage)
2455 {
Geoff Langa9be0dc2014-12-17 12:34:40 -05002456 if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) ||
2457 static_cast<size_t>(yoffset + height) > texture->getHeight(target, level) ||
2458 static_cast<size_t>(zoffset) >= texture->getDepth(target, level))
Jamie Madill560a8d82014-05-21 13:06:20 -04002459 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002460 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002461 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002462 }
2463 }
Jamie Madill6f38f822014-06-06 17:12:20 -04002464 else
2465 {
Geoff Lang691e58c2014-12-19 17:03:25 -05002466 if (IsCubeMapTextureTarget(target) && width != height)
Jamie Madill6f38f822014-06-06 17:12:20 -04002467 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002468 ANGLE_VALIDATION_ERR(context, InvalidValue(), CubemapIncomplete);
Geoff Langb1196682014-07-23 13:47:29 -04002469 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002470 }
2471
Geoff Langeb66a6e2016-10-31 13:06:12 -04002472 if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions()))
Jamie Madill6f38f822014-06-06 17:12:20 -04002473 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002474 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langb1196682014-07-23 13:47:29 -04002475 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002476 }
2477
2478 int maxLevelDimension = (maxDimension >> level);
He Yunchaoced53ae2016-11-29 15:00:51 +08002479 if (static_cast<int>(width) > maxLevelDimension ||
2480 static_cast<int>(height) > maxLevelDimension)
Jamie Madill6f38f822014-06-06 17:12:20 -04002481 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002482 ANGLE_VALIDATION_ERR(context, InvalidValue(), ResourceMaxTextureSize);
Geoff Langb1196682014-07-23 13:47:29 -04002483 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002484 }
2485 }
Jamie Madill560a8d82014-05-21 13:06:20 -04002486
Jamie Madill0c8abca2016-07-22 20:21:26 -04002487 if (textureFormatOut)
2488 {
2489 *textureFormatOut = texture->getFormat(target, level);
2490 }
Jamie Madillf695a3a2017-01-11 17:36:35 -05002491
2492 // Detect texture copying feedback loops for WebGL.
2493 if (context->getExtensions().webglCompatibility)
2494 {
Jamie Madillfd3dd432017-02-02 19:59:59 -05002495 if (readFramebuffer->formsCopyingFeedbackLoopWith(texture->id(), level, zoffset))
Jamie Madillf695a3a2017-01-11 17:36:35 -05002496 {
Brandon Jonesafa75152017-07-21 13:11:29 -07002497 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FeedbackLoop);
Jamie Madillf695a3a2017-01-11 17:36:35 -05002498 return false;
2499 }
2500 }
2501
Jamie Madill560a8d82014-05-21 13:06:20 -04002502 return true;
2503}
2504
Jiajia Qind9671222016-11-29 16:30:31 +08002505bool ValidateDrawBase(ValidationContext *context, GLenum mode, GLsizei count)
Jamie Madill250d33f2014-06-06 17:09:03 -04002506{
Jamie Madill1aeb1312014-06-20 13:21:25 -04002507 switch (mode)
2508 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002509 case GL_POINTS:
2510 case GL_LINES:
2511 case GL_LINE_LOOP:
2512 case GL_LINE_STRIP:
2513 case GL_TRIANGLES:
2514 case GL_TRIANGLE_STRIP:
2515 case GL_TRIANGLE_FAN:
2516 break;
2517 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002518 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidDrawMode);
He Yunchaoced53ae2016-11-29 15:00:51 +08002519 return false;
Jamie Madill1aeb1312014-06-20 13:21:25 -04002520 }
2521
Jamie Madill250d33f2014-06-06 17:09:03 -04002522 if (count < 0)
2523 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002524 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Geoff Langb1196682014-07-23 13:47:29 -04002525 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002526 }
2527
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002528 const State &state = context->getGLState();
Geoff Langb1196682014-07-23 13:47:29 -04002529
Jamie Madill250d33f2014-06-06 17:09:03 -04002530 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002531 if (state.hasMappedBuffer(GL_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04002532 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002533 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002534 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002535 }
2536
Jamie Madillcbcde722017-01-06 14:50:00 -05002537 // Note: these separate values are not supported in WebGL, due to D3D's limitations. See
2538 // Section 6.10 of the WebGL 1.0 spec.
Jamie Madill51f40ec2016-06-15 14:06:00 -04002539 Framebuffer *framebuffer = state.getDrawFramebuffer();
Martin Radevffe754b2017-07-31 10:38:07 +03002540 const Extensions &extensions = context->getExtensions();
2541 if (context->getLimitations().noSeparateStencilRefsAndMasks || extensions.webglCompatibility)
Jamie Madillac528012014-06-20 13:21:23 -04002542 {
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002543 const FramebufferAttachment *dsAttachment =
2544 framebuffer->getStencilOrDepthStencilAttachment();
2545 GLuint stencilBits = dsAttachment ? dsAttachment->getStencilSize() : 0;
He Yunchaoced53ae2016-11-29 15:00:51 +08002546 GLuint minimumRequiredStencilMask = (1 << stencilBits) - 1;
Jinyoung Hur85769f02015-10-20 17:08:44 -04002547 const DepthStencilState &depthStencilState = state.getDepthStencilState();
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002548
2549 bool differentRefs = state.getStencilRef() != state.getStencilBackRef();
2550 bool differentWritemasks =
2551 (depthStencilState.stencilWritemask & minimumRequiredStencilMask) !=
2552 (depthStencilState.stencilBackWritemask & minimumRequiredStencilMask);
2553 bool differentMasks = (depthStencilState.stencilMask & minimumRequiredStencilMask) !=
2554 (depthStencilState.stencilBackMask & minimumRequiredStencilMask);
2555
2556 if (differentRefs || differentWritemasks || differentMasks)
Geoff Lang3a86ad32015-09-01 11:47:05 -04002557 {
Martin Radevffe754b2017-07-31 10:38:07 +03002558 if (!extensions.webglCompatibility)
Jamie Madillcbcde722017-01-06 14:50:00 -05002559 {
Yuly Novikovd73f8522017-01-13 17:48:57 -05002560 ERR() << "This ANGLE implementation does not support separate front/back stencil "
2561 "writemasks, reference values, or stencil mask values.";
Jamie Madillcbcde722017-01-06 14:50:00 -05002562 }
Brandon Jones6cad5662017-06-14 13:25:13 -07002563 ANGLE_VALIDATION_ERR(context, InvalidOperation(), StencilReferenceMaskOrMismatch);
Geoff Lang3a86ad32015-09-01 11:47:05 -04002564 return false;
2565 }
Jamie Madillac528012014-06-20 13:21:23 -04002566 }
2567
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002568 if (framebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill13f7d7d2014-06-20 13:21:27 -04002569 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002570 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002571 return false;
Jamie Madill13f7d7d2014-06-20 13:21:27 -04002572 }
2573
Geoff Lang7dd2e102014-11-10 15:19:26 -05002574 gl::Program *program = state.getProgram();
2575 if (!program)
Jamie Madilld4cfa572014-07-08 10:00:32 -04002576 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002577 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotBound);
Geoff Langb1196682014-07-23 13:47:29 -04002578 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04002579 }
2580
Yunchao Hef81ce4a2017-04-24 10:49:17 +08002581 if (!program->validateSamplers(nullptr, context->getCaps()))
Jamie Madilld4cfa572014-07-08 10:00:32 -04002582 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002583 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002584 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04002585 }
2586
Martin Radevffe754b2017-07-31 10:38:07 +03002587 if (extensions.multiview)
Martin Radev7cf61662017-07-26 17:10:53 +03002588 {
Martin Radevda8e2572017-09-12 17:21:16 +03002589 const int programNumViews = program->usesMultiview() ? program->getNumViews() : 1;
Martin Radev7e69f762017-07-27 14:54:13 +03002590 const int framebufferNumViews = framebuffer->getNumViews();
Martin Radevda8e2572017-09-12 17:21:16 +03002591 if (framebufferNumViews != programNumViews)
Martin Radev7cf61662017-07-26 17:10:53 +03002592 {
2593 context->handleError(InvalidOperation() << "The number of views in the active program "
2594 "and draw framebuffer does not match.");
2595 return false;
2596 }
Martin Radev7e69f762017-07-27 14:54:13 +03002597
2598 const TransformFeedback *transformFeedbackObject = state.getCurrentTransformFeedback();
2599 if (transformFeedbackObject != nullptr && transformFeedbackObject->isActive() &&
2600 framebufferNumViews > 1)
2601 {
2602 context->handleError(InvalidOperation()
2603 << "There is an active transform feedback object "
2604 "when the number of views in the active draw "
2605 "framebuffer is greater than 1.");
2606 return false;
2607 }
Martin Radevffe754b2017-07-31 10:38:07 +03002608
2609 if (extensions.disjointTimerQuery && framebufferNumViews > 1 &&
2610 state.isQueryActive(GL_TIME_ELAPSED_EXT))
2611 {
2612 context->handleError(InvalidOperation() << "There is an active query for target "
2613 "GL_TIME_ELAPSED_EXT when the number of "
2614 "views in the active draw framebuffer is "
2615 "greater than 1.");
2616 return false;
2617 }
Martin Radev7cf61662017-07-26 17:10:53 +03002618 }
2619
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002620 // Uniform buffer validation
He Yunchaoced53ae2016-11-29 15:00:51 +08002621 for (unsigned int uniformBlockIndex = 0;
2622 uniformBlockIndex < program->getActiveUniformBlockCount(); uniformBlockIndex++)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002623 {
Jiajia Qin729b2c62017-08-14 09:36:11 +08002624 const gl::InterfaceBlock &uniformBlock = program->getUniformBlockByIndex(uniformBlockIndex);
He Yunchaoced53ae2016-11-29 15:00:51 +08002625 GLuint blockBinding = program->getUniformBlockBinding(uniformBlockIndex);
Geoff Lang5d124a62015-09-15 13:03:27 -04002626 const OffsetBindingPointer<Buffer> &uniformBuffer =
2627 state.getIndexedUniformBuffer(blockBinding);
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002628
Geoff Lang5d124a62015-09-15 13:03:27 -04002629 if (uniformBuffer.get() == nullptr)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002630 {
2631 // undefined behaviour
Jamie Madill437fa652016-05-03 15:13:24 -04002632 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002633 InvalidOperation()
2634 << "It is undefined behaviour to have a used but unbound uniform buffer.");
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002635 return false;
2636 }
2637
Geoff Lang5d124a62015-09-15 13:03:27 -04002638 size_t uniformBufferSize = uniformBuffer.getSize();
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002639 if (uniformBufferSize == 0)
2640 {
2641 // Bind the whole buffer.
Minmin Gong794e0002015-04-07 18:31:54 -07002642 uniformBufferSize = static_cast<size_t>(uniformBuffer->getSize());
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002643 }
2644
Jamie Madill62d31cb2015-09-11 13:25:51 -04002645 if (uniformBufferSize < uniformBlock.dataSize)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002646 {
2647 // undefined behaviour
Jamie Madill437fa652016-05-03 15:13:24 -04002648 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002649 InvalidOperation()
2650 << "It is undefined behaviour to use a uniform buffer that is too small.");
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002651 return false;
2652 }
2653 }
2654
Geoff Lange0cff192017-05-30 13:04:56 -04002655 // Do some additonal WebGL-specific validation
Martin Radevffe754b2017-07-31 10:38:07 +03002656 if (extensions.webglCompatibility)
Jamie Madilla4595b82017-01-11 17:36:34 -05002657 {
Geoff Lange0cff192017-05-30 13:04:56 -04002658 // Detect rendering feedback loops for WebGL.
Jamie Madilla4595b82017-01-11 17:36:34 -05002659 if (framebuffer->formsRenderingFeedbackLoopWith(state))
2660 {
Brandon Jonesafa75152017-07-21 13:11:29 -07002661 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FeedbackLoop);
Jamie Madilla4595b82017-01-11 17:36:34 -05002662 return false;
2663 }
Geoff Lange0cff192017-05-30 13:04:56 -04002664
Geoff Lang9ab5b822017-05-30 16:19:23 -04002665 // Detect that the vertex shader input types match the attribute types
2666 if (!ValidateVertexShaderAttributeTypeMatch(context))
2667 {
2668 return false;
2669 }
2670
Geoff Lange0cff192017-05-30 13:04:56 -04002671 // Detect that the color buffer types match the fragment shader output types
2672 if (!ValidateFragmentShaderColorBufferTypeMatch(context))
2673 {
2674 return false;
2675 }
Jamie Madilla4595b82017-01-11 17:36:34 -05002676 }
2677
Jamie Madill250d33f2014-06-06 17:09:03 -04002678 // No-op if zero count
2679 return (count > 0);
2680}
2681
Jamie Madillc1d770e2017-04-13 17:31:24 -04002682bool ValidateDrawArraysCommon(ValidationContext *context,
2683 GLenum mode,
2684 GLint first,
2685 GLsizei count,
2686 GLsizei primcount)
Jamie Madill250d33f2014-06-06 17:09:03 -04002687{
Jamie Madillfd716582014-06-06 17:09:04 -04002688 if (first < 0)
Jamie Madill250d33f2014-06-06 17:09:03 -04002689 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002690 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeStart);
Geoff Langb1196682014-07-23 13:47:29 -04002691 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002692 }
2693
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002694 const State &state = context->getGLState();
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002695 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
He Yunchaoced53ae2016-11-29 15:00:51 +08002696 if (curTransformFeedback && curTransformFeedback->isActive() &&
2697 !curTransformFeedback->isPaused() && curTransformFeedback->getPrimitiveMode() != mode)
Jamie Madillfd716582014-06-06 17:09:04 -04002698 {
2699 // It is an invalid operation to call DrawArrays or DrawArraysInstanced with a draw mode
He Yunchaoced53ae2016-11-29 15:00:51 +08002700 // that does not match the current transform feedback object's draw mode (if transform
2701 // feedback
Jamie Madillfd716582014-06-06 17:09:04 -04002702 // is active), (3.0.2, section 2.14, pg 86)
Brandon Jones6cad5662017-06-14 13:25:13 -07002703 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidDrawModeTransformFeedback);
Geoff Langb1196682014-07-23 13:47:29 -04002704 return false;
Jamie Madillfd716582014-06-06 17:09:04 -04002705 }
2706
Jiajia Qind9671222016-11-29 16:30:31 +08002707 if (!ValidateDrawBase(context, mode, count))
Corentin Wallez18a2fb32015-08-10 12:58:14 -07002708 {
2709 return false;
2710 }
2711
Corentin Wallez71168a02016-12-19 15:11:18 -08002712 // Check the computation of maxVertex doesn't overflow.
2713 // - first < 0 or count < 0 have been checked as an error condition
2714 // - count > 0 has been checked in ValidateDrawBase as it makes the call a noop
2715 // From this we know maxVertex will be positive, and only need to check if it overflows GLint.
2716 ASSERT(count > 0 && first >= 0);
2717 int64_t maxVertex = static_cast<int64_t>(first) + static_cast<int64_t>(count) - 1;
2718 if (maxVertex > static_cast<int64_t>(std::numeric_limits<GLint>::max()))
Corentin Wallez92db6942016-12-09 13:10:36 -05002719 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002720 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallez92db6942016-12-09 13:10:36 -05002721 return false;
2722 }
2723
Corentin Wallez71168a02016-12-19 15:11:18 -08002724 if (!ValidateDrawAttribs(context, primcount, static_cast<GLint>(maxVertex), count))
Jamie Madillfd716582014-06-06 17:09:04 -04002725 {
2726 return false;
2727 }
2728
2729 return true;
2730}
2731
He Yunchaoced53ae2016-11-29 15:00:51 +08002732bool ValidateDrawArraysInstancedANGLE(Context *context,
2733 GLenum mode,
2734 GLint first,
2735 GLsizei count,
2736 GLsizei primcount)
Geoff Lang87a93302014-09-16 13:29:43 -04002737{
Geoff Lang63c5a592017-09-27 14:08:16 -04002738 if (!context->getExtensions().instancedArrays)
2739 {
2740 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
2741 return false;
2742 }
2743
Corentin Wallez170efbf2017-05-02 13:45:01 -04002744 if (!ValidateDrawArraysInstancedBase(context, mode, first, count, primcount))
Geoff Lang87a93302014-09-16 13:29:43 -04002745 {
2746 return false;
2747 }
2748
Corentin Wallez0dc97812017-06-22 14:38:44 -04002749 return ValidateDrawInstancedANGLE(context);
Geoff Lang87a93302014-09-16 13:29:43 -04002750}
2751
Jiajia Qind9671222016-11-29 16:30:31 +08002752bool ValidateDrawElementsBase(ValidationContext *context, GLenum type)
Jamie Madillfd716582014-06-06 17:09:04 -04002753{
Jamie Madill250d33f2014-06-06 17:09:03 -04002754 switch (type)
2755 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002756 case GL_UNSIGNED_BYTE:
2757 case GL_UNSIGNED_SHORT:
2758 break;
2759 case GL_UNSIGNED_INT:
2760 if (context->getClientMajorVersion() < 3 && !context->getExtensions().elementIndexUint)
2761 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002762 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte);
He Yunchaoced53ae2016-11-29 15:00:51 +08002763 return false;
2764 }
2765 break;
2766 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002767 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte);
He Yunchaoced53ae2016-11-29 15:00:51 +08002768 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002769 }
2770
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002771 const State &state = context->getGLState();
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002772
2773 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
He Yunchaoced53ae2016-11-29 15:00:51 +08002774 if (curTransformFeedback && curTransformFeedback->isActive() &&
2775 !curTransformFeedback->isPaused())
Jamie Madill250d33f2014-06-06 17:09:03 -04002776 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002777 // It is an invalid operation to call DrawElements, DrawRangeElements or
2778 // DrawElementsInstanced
Jamie Madill250d33f2014-06-06 17:09:03 -04002779 // while transform feedback is active, (3.0.2, section 2.14, pg 86)
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002780 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002781 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002782 }
2783
Jiajia Qind9671222016-11-29 16:30:31 +08002784 return true;
2785}
2786
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002787bool ValidateDrawElementsCommon(ValidationContext *context,
2788 GLenum mode,
2789 GLsizei count,
2790 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04002791 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002792 GLsizei primcount)
Jiajia Qind9671222016-11-29 16:30:31 +08002793{
2794 if (!ValidateDrawElementsBase(context, type))
2795 return false;
2796
2797 const State &state = context->getGLState();
2798
Corentin Wallez170efbf2017-05-02 13:45:01 -04002799 if (!ValidateDrawBase(context, mode, count))
2800 {
2801 return false;
2802 }
2803
Jamie Madill250d33f2014-06-06 17:09:03 -04002804 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002805 if (state.hasMappedBuffer(GL_ELEMENT_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04002806 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002807 context->handleError(InvalidOperation() << "Index buffer is mapped.");
Geoff Langb1196682014-07-23 13:47:29 -04002808 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002809 }
2810
He Yunchaoced53ae2016-11-29 15:00:51 +08002811 const gl::VertexArray *vao = state.getVertexArray();
Jamie Madill8e344942015-07-09 14:22:07 -04002812 gl::Buffer *elementArrayBuffer = vao->getElementArrayBuffer().get();
Jamie Madilld4cfa572014-07-08 10:00:32 -04002813
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05002814 GLuint typeBytes = gl::GetTypeInfo(type).bytes;
2815
2816 if (context->getExtensions().webglCompatibility)
2817 {
2818 ASSERT(isPow2(typeBytes) && typeBytes > 0);
2819 if ((reinterpret_cast<uintptr_t>(indices) & static_cast<uintptr_t>(typeBytes - 1)) != 0)
2820 {
2821 // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements
2822 // The offset arguments to drawElements and [...], must be a multiple of the size of the
2823 // data type passed to the call, or an INVALID_OPERATION error is generated.
Brandon Jones6cad5662017-06-14 13:25:13 -07002824 ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType);
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05002825 return false;
2826 }
Corentin Wallezfe9306a2017-02-01 17:41:05 -05002827
2828 // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements
2829 // In addition the offset argument to drawElements must be non-negative or an INVALID_VALUE
2830 // error is generated.
2831 if (reinterpret_cast<intptr_t>(indices) < 0)
2832 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002833 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
Corentin Wallezfe9306a2017-02-01 17:41:05 -05002834 return false;
2835 }
Geoff Langfeb8c682017-02-13 16:07:35 -05002836 }
2837
2838 if (context->getExtensions().webglCompatibility ||
2839 !context->getGLState().areClientArraysEnabled())
2840 {
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05002841 if (!elementArrayBuffer && count > 0)
2842 {
2843 // [WebGL 1.0] Section 6.2 No Client Side Arrays
2844 // If drawElements is called with a count greater than zero, and no WebGLBuffer is bound
2845 // to the ELEMENT_ARRAY_BUFFER binding point, an INVALID_OPERATION error is generated.
Brandon Jones6cad5662017-06-14 13:25:13 -07002846 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MustHaveElementArrayBinding);
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05002847 return false;
2848 }
2849 }
2850
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002851 if (count > 0)
Jamie Madillae3000b2014-08-25 15:47:51 -04002852 {
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002853 if (elementArrayBuffer)
Jamie Madillae3000b2014-08-25 15:47:51 -04002854 {
Corentin Wallezfe9306a2017-02-01 17:41:05 -05002855 // The max possible type size is 8 and count is on 32 bits so doing the multiplication
2856 // in a 64 bit integer is safe. Also we are guaranteed that here count > 0.
2857 static_assert(std::is_same<int, GLsizei>::value, "GLsizei isn't the expected type");
2858 constexpr uint64_t kMaxTypeSize = 8;
2859 constexpr uint64_t kIntMax = std::numeric_limits<int>::max();
2860 constexpr uint64_t kUint64Max = std::numeric_limits<uint64_t>::max();
2861 static_assert(kIntMax < kUint64Max / kMaxTypeSize, "");
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002862
Corentin Wallezfe9306a2017-02-01 17:41:05 -05002863 uint64_t typeSize = typeBytes;
2864 uint64_t elementCount = static_cast<uint64_t>(count);
2865 ASSERT(elementCount > 0 && typeSize <= kMaxTypeSize);
2866
2867 // Doing the multiplication here is overflow-safe
2868 uint64_t elementDataSizeNoOffset = typeSize * elementCount;
2869
2870 // The offset can be any value, check for overflows
2871 uint64_t offset = static_cast<uint64_t>(reinterpret_cast<uintptr_t>(indices));
2872 if (elementDataSizeNoOffset > kUint64Max - offset)
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002873 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002874 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002875 return false;
2876 }
2877
Corentin Wallezfe9306a2017-02-01 17:41:05 -05002878 uint64_t elementDataSizeWithOffset = elementDataSizeNoOffset + offset;
2879 if (elementDataSizeWithOffset > static_cast<uint64_t>(elementArrayBuffer->getSize()))
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002880 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002881 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002882 return false;
2883 }
Brandon Jonesed5b46f2017-07-21 08:39:17 -07002884
Corentin Wallez487653b2017-09-01 17:17:55 -04002885 ASSERT(isPow2(typeSize) && typeSize > 0);
2886 if ((elementArrayBuffer->getSize() & (typeSize - 1)) != 0)
Brandon Jonesed5b46f2017-07-21 08:39:17 -07002887 {
2888 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MismatchedByteCountType);
2889 return false;
2890 }
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002891 }
2892 else if (!indices)
2893 {
2894 // This is an application error that would normally result in a crash,
2895 // but we catch it and return an error
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002896 context->handleError(InvalidOperation() << "No element array buffer and no pointer.");
Geoff Langb1196682014-07-23 13:47:29 -04002897 return false;
Jamie Madillae3000b2014-08-25 15:47:51 -04002898 }
Jamie Madillae3000b2014-08-25 15:47:51 -04002899 }
2900
Jiajia Qin8a7b3a02017-08-25 16:05:48 +08002901 if (context->getExtensions().robustBufferAccessBehavior)
Corentin Wallezc1346fb2017-08-24 16:11:26 +00002902 {
Jiajia Qin8a7b3a02017-08-25 16:05:48 +08002903 // Here we use maxVertex = 0 and vertexCount = 1 to avoid retrieving IndexRange when robust
2904 // access is enabled.
2905 if (!ValidateDrawAttribs(context, primcount, 0, 1))
2906 {
2907 return false;
2908 }
2909 }
2910 else
2911 {
2912 // Use the parameter buffer to retrieve and cache the index range.
2913 const auto &params = context->getParams<HasIndexRange>();
2914 const auto &indexRangeOpt = params.getIndexRange();
2915 if (!indexRangeOpt.valid())
2916 {
2917 // Unexpected error.
2918 return false;
2919 }
2920
2921 // If we use an index greater than our maximum supported index range, return an error.
2922 // The ES3 spec does not specify behaviour here, it is undefined, but ANGLE should always
2923 // return an error if possible here.
2924 if (static_cast<GLuint64>(indexRangeOpt.value().end) >= context->getCaps().maxElementIndex)
2925 {
2926 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExceedsMaxElement);
2927 return false;
2928 }
2929
2930 if (!ValidateDrawAttribs(context, primcount, static_cast<GLint>(indexRangeOpt.value().end),
2931 static_cast<GLint>(indexRangeOpt.value().vertexCount())))
2932 {
2933 return false;
2934 }
2935
2936 // No op if there are no real indices in the index data (all are primitive restart).
2937 return (indexRangeOpt.value().vertexIndexCount > 0);
Corentin Wallezc1346fb2017-08-24 16:11:26 +00002938 }
2939
Jiajia Qin8a7b3a02017-08-25 16:05:48 +08002940 return true;
Jamie Madillfd716582014-06-06 17:09:04 -04002941}
2942
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002943bool ValidateDrawElementsInstancedCommon(ValidationContext *context,
2944 GLenum mode,
2945 GLsizei count,
2946 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04002947 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002948 GLsizei primcount)
Jamie Madillfd716582014-06-06 17:09:04 -04002949{
Corentin Wallez0dc97812017-06-22 14:38:44 -04002950 return ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount);
Jamie Madill250d33f2014-06-06 17:09:03 -04002951}
2952
Geoff Lang3edfe032015-09-04 16:38:24 -04002953bool ValidateDrawElementsInstancedANGLE(Context *context,
2954 GLenum mode,
2955 GLsizei count,
2956 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04002957 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002958 GLsizei primcount)
Geoff Lang87a93302014-09-16 13:29:43 -04002959{
Geoff Lang63c5a592017-09-27 14:08:16 -04002960 if (!context->getExtensions().instancedArrays)
2961 {
2962 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
2963 return false;
2964 }
2965
Corentin Wallez170efbf2017-05-02 13:45:01 -04002966 if (!ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount))
Geoff Lang87a93302014-09-16 13:29:43 -04002967 {
2968 return false;
2969 }
2970
Corentin Wallez0dc97812017-06-22 14:38:44 -04002971 return ValidateDrawInstancedANGLE(context);
Geoff Lang87a93302014-09-16 13:29:43 -04002972}
2973
He Yunchaoced53ae2016-11-29 15:00:51 +08002974bool ValidateFramebufferTextureBase(Context *context,
2975 GLenum target,
2976 GLenum attachment,
2977 GLuint texture,
2978 GLint level)
Jamie Madill570f7c82014-07-03 10:38:54 -04002979{
Jamie Madill55ec3b12014-07-03 10:38:57 -04002980 if (!ValidFramebufferTarget(target))
2981 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002982 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04002983 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04002984 }
2985
2986 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill570f7c82014-07-03 10:38:54 -04002987 {
2988 return false;
2989 }
2990
Jamie Madill55ec3b12014-07-03 10:38:57 -04002991 if (texture != 0)
2992 {
2993 gl::Texture *tex = context->getTexture(texture);
2994
Jamie Madillbe849e42017-05-02 15:49:00 -04002995 if (tex == NULL)
Jamie Madill55ec3b12014-07-03 10:38:57 -04002996 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002997 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002998 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04002999 }
3000
3001 if (level < 0)
3002 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003003 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04003004 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003005 }
3006 }
3007
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003008 const gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
Jamie Madill84115c92015-04-23 15:00:07 -04003009 ASSERT(framebuffer);
Jamie Madill55ec3b12014-07-03 10:38:57 -04003010
Jamie Madill84115c92015-04-23 15:00:07 -04003011 if (framebuffer->id() == 0)
Jamie Madill55ec3b12014-07-03 10:38:57 -04003012 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003013 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04003014 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003015 }
3016
3017 return true;
3018}
3019
Geoff Langb1196682014-07-23 13:47:29 -04003020bool ValidateGetUniformBase(Context *context, GLuint program, GLint location)
Jamie Madill0063c512014-08-25 15:47:53 -04003021{
3022 if (program == 0)
3023 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003024 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04003025 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003026 }
3027
Dian Xiang769769a2015-09-09 15:20:08 -07003028 gl::Program *programObject = GetValidProgram(context, program);
3029 if (!programObject)
Shannon Woods4de4fd62014-11-07 16:22:02 -05003030 {
3031 return false;
3032 }
3033
Jamie Madill0063c512014-08-25 15:47:53 -04003034 if (!programObject || !programObject->isLinked())
3035 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003036 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Geoff Langb1196682014-07-23 13:47:29 -04003037 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003038 }
3039
Geoff Lang7dd2e102014-11-10 15:19:26 -05003040 if (!programObject->isValidUniformLocation(location))
Jamie Madill549c7fd2014-08-25 15:47:56 -04003041 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003042 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04003043 return false;
Jamie Madill549c7fd2014-08-25 15:47:56 -04003044 }
3045
Jamie Madill0063c512014-08-25 15:47:53 -04003046 return true;
3047}
3048
Geoff Langf41d0ee2016-10-07 13:04:23 -04003049static bool ValidateSizedGetUniform(Context *context,
3050 GLuint program,
3051 GLint location,
3052 GLsizei bufSize,
3053 GLsizei *length)
Jamie Madill78f41802014-08-25 15:47:55 -04003054{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003055 if (length)
3056 {
3057 *length = 0;
3058 }
3059
Jamie Madill78f41802014-08-25 15:47:55 -04003060 if (!ValidateGetUniformBase(context, program, location))
Jamie Madill0063c512014-08-25 15:47:53 -04003061 {
Jamie Madill78f41802014-08-25 15:47:55 -04003062 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003063 }
3064
Geoff Langf41d0ee2016-10-07 13:04:23 -04003065 if (bufSize < 0)
3066 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003067 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Geoff Langf41d0ee2016-10-07 13:04:23 -04003068 return false;
3069 }
3070
Jamie Madilla502c742014-08-28 17:19:13 -04003071 gl::Program *programObject = context->getProgram(program);
3072 ASSERT(programObject);
Jamie Madill0063c512014-08-25 15:47:53 -04003073
Jamie Madill78f41802014-08-25 15:47:55 -04003074 // sized queries -- ensure the provided buffer is large enough
Jamie Madill62d31cb2015-09-11 13:25:51 -04003075 const LinkedUniform &uniform = programObject->getUniformByLocation(location);
He Yunchaoced53ae2016-11-29 15:00:51 +08003076 size_t requiredBytes = VariableExternalSize(uniform.type);
Jamie Madill78f41802014-08-25 15:47:55 -04003077 if (static_cast<size_t>(bufSize) < requiredBytes)
Jamie Madill0063c512014-08-25 15:47:53 -04003078 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003079 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Geoff Langb1196682014-07-23 13:47:29 -04003080 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003081 }
3082
Geoff Langf41d0ee2016-10-07 13:04:23 -04003083 if (length)
3084 {
Geoff Lang94177fb2016-11-14 16:12:26 -05003085 *length = VariableComponentCount(uniform.type);
Geoff Langf41d0ee2016-10-07 13:04:23 -04003086 }
3087
Jamie Madill0063c512014-08-25 15:47:53 -04003088 return true;
3089}
3090
He Yunchaoced53ae2016-11-29 15:00:51 +08003091bool ValidateGetnUniformfvEXT(Context *context,
3092 GLuint program,
3093 GLint location,
3094 GLsizei bufSize,
3095 GLfloat *params)
Jamie Madill0063c512014-08-25 15:47:53 -04003096{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003097 return ValidateSizedGetUniform(context, program, location, bufSize, nullptr);
Jamie Madill0063c512014-08-25 15:47:53 -04003098}
3099
He Yunchaoced53ae2016-11-29 15:00:51 +08003100bool ValidateGetnUniformivEXT(Context *context,
3101 GLuint program,
3102 GLint location,
3103 GLsizei bufSize,
3104 GLint *params)
Jamie Madill0063c512014-08-25 15:47:53 -04003105{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003106 return ValidateSizedGetUniform(context, program, location, bufSize, nullptr);
3107}
3108
3109bool ValidateGetUniformfvRobustANGLE(Context *context,
3110 GLuint program,
3111 GLint location,
3112 GLsizei bufSize,
3113 GLsizei *length,
3114 GLfloat *params)
3115{
3116 if (!ValidateRobustEntryPoint(context, bufSize))
3117 {
3118 return false;
3119 }
3120
3121 // bufSize is validated in ValidateSizedGetUniform
3122 return ValidateSizedGetUniform(context, program, location, bufSize, length);
3123}
3124
3125bool ValidateGetUniformivRobustANGLE(Context *context,
3126 GLuint program,
3127 GLint location,
3128 GLsizei bufSize,
3129 GLsizei *length,
3130 GLint *params)
3131{
3132 if (!ValidateRobustEntryPoint(context, bufSize))
3133 {
3134 return false;
3135 }
3136
3137 // bufSize is validated in ValidateSizedGetUniform
3138 return ValidateSizedGetUniform(context, program, location, bufSize, length);
3139}
3140
3141bool ValidateGetUniformuivRobustANGLE(Context *context,
3142 GLuint program,
3143 GLint location,
3144 GLsizei bufSize,
3145 GLsizei *length,
3146 GLuint *params)
3147{
3148 if (!ValidateRobustEntryPoint(context, bufSize))
3149 {
3150 return false;
3151 }
3152
3153 if (context->getClientMajorVersion() < 3)
3154 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08003155 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required);
Geoff Langf41d0ee2016-10-07 13:04:23 -04003156 return false;
3157 }
3158
3159 // bufSize is validated in ValidateSizedGetUniform
3160 return ValidateSizedGetUniform(context, program, location, bufSize, length);
Jamie Madill0063c512014-08-25 15:47:53 -04003161}
3162
He Yunchaoced53ae2016-11-29 15:00:51 +08003163bool ValidateDiscardFramebufferBase(Context *context,
3164 GLenum target,
3165 GLsizei numAttachments,
3166 const GLenum *attachments,
3167 bool defaultFramebuffer)
Austin Kinross08332632015-05-05 13:35:47 -07003168{
3169 if (numAttachments < 0)
3170 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003171 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeAttachments);
Austin Kinross08332632015-05-05 13:35:47 -07003172 return false;
3173 }
3174
3175 for (GLsizei i = 0; i < numAttachments; ++i)
3176 {
Olli Etuaho84c9f592016-03-09 14:37:25 +02003177 if (attachments[i] >= GL_COLOR_ATTACHMENT0 && attachments[i] <= GL_COLOR_ATTACHMENT31)
Austin Kinross08332632015-05-05 13:35:47 -07003178 {
3179 if (defaultFramebuffer)
3180 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003181 ANGLE_VALIDATION_ERR(context, InvalidEnum(), DefaultFramebufferInvalidAttachment);
Austin Kinross08332632015-05-05 13:35:47 -07003182 return false;
3183 }
3184
3185 if (attachments[i] >= GL_COLOR_ATTACHMENT0 + context->getCaps().maxColorAttachments)
3186 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003187 context->handleError(InvalidOperation() << "Requested color attachment is "
3188 "greater than the maximum supported "
3189 "color attachments");
Austin Kinross08332632015-05-05 13:35:47 -07003190 return false;
3191 }
3192 }
3193 else
3194 {
3195 switch (attachments[i])
3196 {
He Yunchaoced53ae2016-11-29 15:00:51 +08003197 case GL_DEPTH_ATTACHMENT:
3198 case GL_STENCIL_ATTACHMENT:
3199 case GL_DEPTH_STENCIL_ATTACHMENT:
3200 if (defaultFramebuffer)
3201 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003202 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
3203 DefaultFramebufferInvalidAttachment);
He Yunchaoced53ae2016-11-29 15:00:51 +08003204 return false;
3205 }
3206 break;
3207 case GL_COLOR:
3208 case GL_DEPTH:
3209 case GL_STENCIL:
3210 if (!defaultFramebuffer)
3211 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003212 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
3213 DefaultFramebufferInvalidAttachment);
He Yunchaoced53ae2016-11-29 15:00:51 +08003214 return false;
3215 }
3216 break;
3217 default:
Brandon Jonesafa75152017-07-21 13:11:29 -07003218 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidAttachment);
Austin Kinross08332632015-05-05 13:35:47 -07003219 return false;
Austin Kinross08332632015-05-05 13:35:47 -07003220 }
3221 }
3222 }
3223
3224 return true;
3225}
3226
Austin Kinross6ee1e782015-05-29 17:05:37 -07003227bool ValidateInsertEventMarkerEXT(Context *context, GLsizei length, const char *marker)
3228{
3229 // Note that debug marker calls must not set error state
3230
3231 if (length < 0)
3232 {
3233 return false;
3234 }
3235
3236 if (marker == nullptr)
3237 {
3238 return false;
3239 }
3240
3241 return true;
3242}
3243
3244bool ValidatePushGroupMarkerEXT(Context *context, GLsizei length, const char *marker)
3245{
3246 // Note that debug marker calls must not set error state
3247
3248 if (length < 0)
3249 {
3250 return false;
3251 }
3252
3253 if (length > 0 && marker == nullptr)
3254 {
3255 return false;
3256 }
3257
3258 return true;
3259}
3260
Geoff Langdcab33b2015-07-21 13:03:16 -04003261bool ValidateEGLImageTargetTexture2DOES(Context *context,
Geoff Langdcab33b2015-07-21 13:03:16 -04003262 GLenum target,
3263 egl::Image *image)
3264{
Geoff Langa8406172015-07-21 16:53:39 -04003265 if (!context->getExtensions().eglImage && !context->getExtensions().eglImageExternal)
3266 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003267 context->handleError(InvalidOperation());
Geoff Langa8406172015-07-21 16:53:39 -04003268 return false;
3269 }
3270
3271 switch (target)
3272 {
3273 case GL_TEXTURE_2D:
Geoff Langb66a9092016-05-16 15:59:14 -04003274 if (!context->getExtensions().eglImage)
3275 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003276 context->handleError(InvalidEnum()
3277 << "GL_TEXTURE_2D texture target requires GL_OES_EGL_image.");
Geoff Langb66a9092016-05-16 15:59:14 -04003278 }
3279 break;
3280
3281 case GL_TEXTURE_EXTERNAL_OES:
3282 if (!context->getExtensions().eglImageExternal)
3283 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003284 context->handleError(InvalidEnum() << "GL_TEXTURE_EXTERNAL_OES texture target "
3285 "requires GL_OES_EGL_image_external.");
Geoff Langb66a9092016-05-16 15:59:14 -04003286 }
Geoff Langa8406172015-07-21 16:53:39 -04003287 break;
3288
3289 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003290 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Geoff Langa8406172015-07-21 16:53:39 -04003291 return false;
3292 }
3293
Jamie Madill61e16b42017-06-19 11:13:23 -04003294 ASSERT(context->getCurrentDisplay());
3295 if (!context->getCurrentDisplay()->isValidImage(image))
Geoff Langa8406172015-07-21 16:53:39 -04003296 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003297 context->handleError(InvalidValue() << "EGL image is not valid.");
Geoff Langa8406172015-07-21 16:53:39 -04003298 return false;
3299 }
3300
3301 if (image->getSamples() > 0)
3302 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003303 context->handleError(InvalidOperation()
3304 << "cannot create a 2D texture from a multisampled EGL image.");
Geoff Langa8406172015-07-21 16:53:39 -04003305 return false;
3306 }
3307
Geoff Langca271392017-04-05 12:30:00 -04003308 const TextureCaps &textureCaps =
3309 context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat);
Geoff Langa8406172015-07-21 16:53:39 -04003310 if (!textureCaps.texturable)
3311 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003312 context->handleError(InvalidOperation()
3313 << "EGL image internal format is not supported as a texture.");
Geoff Langa8406172015-07-21 16:53:39 -04003314 return false;
3315 }
3316
Geoff Langdcab33b2015-07-21 13:03:16 -04003317 return true;
3318}
3319
3320bool ValidateEGLImageTargetRenderbufferStorageOES(Context *context,
Geoff Langdcab33b2015-07-21 13:03:16 -04003321 GLenum target,
3322 egl::Image *image)
3323{
Geoff Langa8406172015-07-21 16:53:39 -04003324 if (!context->getExtensions().eglImage)
3325 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003326 context->handleError(InvalidOperation());
Geoff Langa8406172015-07-21 16:53:39 -04003327 return false;
3328 }
3329
3330 switch (target)
3331 {
3332 case GL_RENDERBUFFER:
3333 break;
3334
3335 default:
Brandon Jonesafa75152017-07-21 13:11:29 -07003336 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
Geoff Langa8406172015-07-21 16:53:39 -04003337 return false;
3338 }
3339
Jamie Madill61e16b42017-06-19 11:13:23 -04003340 ASSERT(context->getCurrentDisplay());
3341 if (!context->getCurrentDisplay()->isValidImage(image))
Geoff Langa8406172015-07-21 16:53:39 -04003342 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003343 context->handleError(InvalidValue() << "EGL image is not valid.");
Geoff Langa8406172015-07-21 16:53:39 -04003344 return false;
3345 }
3346
Geoff Langca271392017-04-05 12:30:00 -04003347 const TextureCaps &textureCaps =
3348 context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat);
Geoff Langa8406172015-07-21 16:53:39 -04003349 if (!textureCaps.renderable)
3350 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003351 context->handleError(InvalidOperation()
3352 << "EGL image internal format is not supported as a renderbuffer.");
Geoff Langa8406172015-07-21 16:53:39 -04003353 return false;
3354 }
3355
Geoff Langdcab33b2015-07-21 13:03:16 -04003356 return true;
3357}
Austin Kinrossbc781f32015-10-26 09:27:38 -07003358
3359bool ValidateBindVertexArrayBase(Context *context, GLuint array)
3360{
Geoff Lang36167ab2015-12-07 10:27:14 -05003361 if (!context->isVertexArrayGenerated(array))
Austin Kinrossbc781f32015-10-26 09:27:38 -07003362 {
3363 // The default VAO should always exist
3364 ASSERT(array != 0);
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003365 context->handleError(InvalidOperation());
Austin Kinrossbc781f32015-10-26 09:27:38 -07003366 return false;
3367 }
3368
3369 return true;
3370}
3371
Geoff Langc5629752015-12-07 16:29:04 -05003372bool ValidateProgramBinaryBase(Context *context,
3373 GLuint program,
3374 GLenum binaryFormat,
3375 const void *binary,
3376 GLint length)
3377{
3378 Program *programObject = GetValidProgram(context, program);
3379 if (programObject == nullptr)
3380 {
3381 return false;
3382 }
3383
3384 const std::vector<GLenum> &programBinaryFormats = context->getCaps().programBinaryFormats;
3385 if (std::find(programBinaryFormats.begin(), programBinaryFormats.end(), binaryFormat) ==
3386 programBinaryFormats.end())
3387 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003388 context->handleError(InvalidEnum() << "Program binary format is not valid.");
Geoff Langc5629752015-12-07 16:29:04 -05003389 return false;
3390 }
3391
Olli Etuahoc3e55a42016-03-09 16:29:18 +02003392 if (context->hasActiveTransformFeedback(program))
3393 {
3394 // ES 3.0.4 section 2.15 page 91
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003395 context->handleError(InvalidOperation() << "Cannot change program binary while program "
3396 "is associated with an active transform "
3397 "feedback object.");
Olli Etuahoc3e55a42016-03-09 16:29:18 +02003398 return false;
3399 }
3400
Geoff Langc5629752015-12-07 16:29:04 -05003401 return true;
3402}
3403
3404bool ValidateGetProgramBinaryBase(Context *context,
3405 GLuint program,
3406 GLsizei bufSize,
3407 GLsizei *length,
3408 GLenum *binaryFormat,
3409 void *binary)
3410{
3411 Program *programObject = GetValidProgram(context, program);
3412 if (programObject == nullptr)
3413 {
3414 return false;
3415 }
3416
3417 if (!programObject->isLinked())
3418 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003419 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Geoff Langc5629752015-12-07 16:29:04 -05003420 return false;
3421 }
3422
Jamie Madilla7d12dc2016-12-13 15:08:19 -05003423 if (context->getCaps().programBinaryFormats.empty())
3424 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003425 context->handleError(InvalidOperation() << "No program binary formats supported.");
Jamie Madilla7d12dc2016-12-13 15:08:19 -05003426 return false;
3427 }
3428
Geoff Langc5629752015-12-07 16:29:04 -05003429 return true;
3430}
Jamie Madillc29968b2016-01-20 11:17:23 -05003431
Jamie Madillc29968b2016-01-20 11:17:23 -05003432bool ValidateDrawBuffersBase(ValidationContext *context, GLsizei n, const GLenum *bufs)
3433{
3434 // INVALID_VALUE is generated if n is negative or greater than value of MAX_DRAW_BUFFERS
Brandon Jonesafa75152017-07-21 13:11:29 -07003435 if (n < 0)
Jamie Madillc29968b2016-01-20 11:17:23 -05003436 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003437 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
3438 return false;
3439 }
3440 if (static_cast<GLuint>(n) > context->getCaps().maxDrawBuffers)
3441 {
3442 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxDrawBuffer);
Jamie Madillc29968b2016-01-20 11:17:23 -05003443 return false;
3444 }
3445
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003446 ASSERT(context->getGLState().getDrawFramebuffer());
3447 GLuint frameBufferId = context->getGLState().getDrawFramebuffer()->id();
Jamie Madillc29968b2016-01-20 11:17:23 -05003448 GLuint maxColorAttachment = GL_COLOR_ATTACHMENT0_EXT + context->getCaps().maxColorAttachments;
3449
3450 // This should come first before the check for the default frame buffer
3451 // because when we switch to ES3.1+, invalid enums will return INVALID_ENUM
3452 // rather than INVALID_OPERATION
3453 for (int colorAttachment = 0; colorAttachment < n; colorAttachment++)
3454 {
3455 const GLenum attachment = GL_COLOR_ATTACHMENT0_EXT + colorAttachment;
3456
3457 if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != GL_BACK &&
Olli Etuaho84c9f592016-03-09 14:37:25 +02003458 (bufs[colorAttachment] < GL_COLOR_ATTACHMENT0 ||
3459 bufs[colorAttachment] > GL_COLOR_ATTACHMENT31))
Jamie Madillc29968b2016-01-20 11:17:23 -05003460 {
3461 // Value in bufs is not NONE, BACK, or GL_COLOR_ATTACHMENTi
Olli Etuaho84c9f592016-03-09 14:37:25 +02003462 // The 3.0.4 spec says to generate GL_INVALID_OPERATION here, but this
3463 // was changed to GL_INVALID_ENUM in 3.1, which dEQP also expects.
3464 // 3.1 is still a bit ambiguous about the error, but future specs are
3465 // expected to clarify that GL_INVALID_ENUM is the correct error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003466 context->handleError(InvalidEnum() << "Invalid buffer value");
Olli Etuaho84c9f592016-03-09 14:37:25 +02003467 return false;
3468 }
3469 else if (bufs[colorAttachment] >= maxColorAttachment)
3470 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003471 context->handleError(InvalidOperation()
3472 << "Buffer value is greater than MAX_DRAW_BUFFERS");
Jamie Madillc29968b2016-01-20 11:17:23 -05003473 return false;
3474 }
3475 else if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != attachment &&
3476 frameBufferId != 0)
3477 {
3478 // INVALID_OPERATION-GL is bound to buffer and ith argument
3479 // is not COLOR_ATTACHMENTi or NONE
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003480 context->handleError(InvalidOperation()
3481 << "Ith value does not match COLOR_ATTACHMENTi or NONE");
Jamie Madillc29968b2016-01-20 11:17:23 -05003482 return false;
3483 }
3484 }
3485
3486 // INVALID_OPERATION is generated if GL is bound to the default framebuffer
3487 // and n is not 1 or bufs is bound to value other than BACK and NONE
3488 if (frameBufferId == 0)
3489 {
3490 if (n != 1)
3491 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003492 context->handleError(InvalidOperation()
3493 << "n must be 1 when GL is bound to the default framebuffer");
Jamie Madillc29968b2016-01-20 11:17:23 -05003494 return false;
3495 }
3496
3497 if (bufs[0] != GL_NONE && bufs[0] != GL_BACK)
3498 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003499 context->handleError(
3500 InvalidOperation()
3501 << "Only NONE or BACK are valid values when drawing to the default framebuffer");
Jamie Madillc29968b2016-01-20 11:17:23 -05003502 return false;
3503 }
3504 }
3505
3506 return true;
3507}
3508
Geoff Lang496c02d2016-10-20 11:38:11 -07003509bool ValidateGetBufferPointervBase(Context *context,
3510 GLenum target,
3511 GLenum pname,
3512 GLsizei *length,
3513 void **params)
Olli Etuaho4f667482016-03-30 15:56:35 +03003514{
Geoff Lang496c02d2016-10-20 11:38:11 -07003515 if (length)
3516 {
3517 *length = 0;
3518 }
3519
3520 if (context->getClientMajorVersion() < 3 && !context->getExtensions().mapBuffer)
3521 {
3522 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003523 InvalidOperation()
3524 << "Context does not support OpenGL ES 3.0 or GL_OES_mapbuffer is not enabled.");
Geoff Lang496c02d2016-10-20 11:38:11 -07003525 return false;
3526 }
3527
Olli Etuaho4f667482016-03-30 15:56:35 +03003528 if (!ValidBufferTarget(context, target))
3529 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003530 context->handleError(InvalidEnum() << "Buffer target not valid: 0x" << std::hex
3531 << std::uppercase << target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003532 return false;
3533 }
3534
Geoff Lang496c02d2016-10-20 11:38:11 -07003535 switch (pname)
Olli Etuaho4f667482016-03-30 15:56:35 +03003536 {
Geoff Lang496c02d2016-10-20 11:38:11 -07003537 case GL_BUFFER_MAP_POINTER:
3538 break;
Olli Etuaho4f667482016-03-30 15:56:35 +03003539
Geoff Lang496c02d2016-10-20 11:38:11 -07003540 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003541 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang496c02d2016-10-20 11:38:11 -07003542 return false;
3543 }
Olli Etuaho4f667482016-03-30 15:56:35 +03003544
3545 // GLES 3.0 section 2.10.1: "Attempts to attempts to modify or query buffer object state for a
3546 // target bound to zero generate an INVALID_OPERATION error."
3547 // GLES 3.1 section 6.6 explicitly specifies this error.
Geoff Lang496c02d2016-10-20 11:38:11 -07003548 if (context->getGLState().getTargetBuffer(target) == nullptr)
Olli Etuaho4f667482016-03-30 15:56:35 +03003549 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003550 context->handleError(InvalidOperation()
3551 << "Can not get pointer for reserved buffer name zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003552 return false;
3553 }
3554
Geoff Lang496c02d2016-10-20 11:38:11 -07003555 if (length)
3556 {
3557 *length = 1;
3558 }
3559
Olli Etuaho4f667482016-03-30 15:56:35 +03003560 return true;
3561}
3562
3563bool ValidateUnmapBufferBase(Context *context, GLenum target)
3564{
3565 if (!ValidBufferTarget(context, target))
3566 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003567 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003568 return false;
3569 }
3570
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003571 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003572
3573 if (buffer == nullptr || !buffer->isMapped())
3574 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003575 context->handleError(InvalidOperation() << "Buffer not mapped.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003576 return false;
3577 }
3578
3579 return true;
3580}
3581
3582bool ValidateMapBufferRangeBase(Context *context,
3583 GLenum target,
3584 GLintptr offset,
3585 GLsizeiptr length,
3586 GLbitfield access)
3587{
3588 if (!ValidBufferTarget(context, target))
3589 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003590 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003591 return false;
3592 }
3593
Brandon Jones6cad5662017-06-14 13:25:13 -07003594 if (offset < 0)
Olli Etuaho4f667482016-03-30 15:56:35 +03003595 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003596 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
3597 return false;
3598 }
3599
3600 if (length < 0)
3601 {
3602 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength);
Olli Etuaho4f667482016-03-30 15:56:35 +03003603 return false;
3604 }
3605
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003606 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003607
3608 if (!buffer)
3609 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003610 context->handleError(InvalidOperation() << "Attempted to map buffer object zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003611 return false;
3612 }
3613
3614 // Check for buffer overflow
Jamie Madille2e406c2016-06-02 13:04:10 -04003615 CheckedNumeric<size_t> checkedOffset(offset);
3616 auto checkedSize = checkedOffset + length;
Olli Etuaho4f667482016-03-30 15:56:35 +03003617
Jamie Madille2e406c2016-06-02 13:04:10 -04003618 if (!checkedSize.IsValid() || checkedSize.ValueOrDie() > static_cast<size_t>(buffer->getSize()))
Olli Etuaho4f667482016-03-30 15:56:35 +03003619 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003620 context->handleError(InvalidValue() << "Mapped range does not fit into buffer dimensions.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003621 return false;
3622 }
3623
3624 // Check for invalid bits in the mask
3625 GLbitfield allAccessBits = GL_MAP_READ_BIT | GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_RANGE_BIT |
3626 GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_FLUSH_EXPLICIT_BIT |
3627 GL_MAP_UNSYNCHRONIZED_BIT;
3628
3629 if (access & ~(allAccessBits))
3630 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003631 context->handleError(InvalidValue()
3632 << "Invalid access bits: 0x" << std::hex << std::uppercase << access);
Olli Etuaho4f667482016-03-30 15:56:35 +03003633 return false;
3634 }
3635
3636 if (length == 0)
3637 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003638 context->handleError(InvalidOperation() << "Buffer mapping length is zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003639 return false;
3640 }
3641
3642 if (buffer->isMapped())
3643 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003644 context->handleError(InvalidOperation() << "Buffer is already mapped.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003645 return false;
3646 }
3647
3648 // Check for invalid bit combinations
3649 if ((access & (GL_MAP_READ_BIT | GL_MAP_WRITE_BIT)) == 0)
3650 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003651 context->handleError(InvalidOperation()
3652 << "Need to map buffer for either reading or writing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003653 return false;
3654 }
3655
3656 GLbitfield writeOnlyBits =
3657 GL_MAP_INVALIDATE_RANGE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_UNSYNCHRONIZED_BIT;
3658
3659 if ((access & GL_MAP_READ_BIT) != 0 && (access & writeOnlyBits) != 0)
3660 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003661 context->handleError(InvalidOperation()
3662 << "Invalid access bits when mapping buffer for reading: 0x"
3663 << std::hex << std::uppercase << access);
Olli Etuaho4f667482016-03-30 15:56:35 +03003664 return false;
3665 }
3666
3667 if ((access & GL_MAP_WRITE_BIT) == 0 && (access & GL_MAP_FLUSH_EXPLICIT_BIT) != 0)
3668 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003669 context->handleError(
3670 InvalidOperation()
3671 << "The explicit flushing bit may only be set if the buffer is mapped for writing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003672 return false;
3673 }
Geoff Lang79f71042017-08-14 16:43:43 -04003674
3675 return ValidateMapBufferBase(context, target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003676}
3677
3678bool ValidateFlushMappedBufferRangeBase(Context *context,
3679 GLenum target,
3680 GLintptr offset,
3681 GLsizeiptr length)
3682{
Brandon Jones6cad5662017-06-14 13:25:13 -07003683 if (offset < 0)
Olli Etuaho4f667482016-03-30 15:56:35 +03003684 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003685 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
3686 return false;
3687 }
3688
3689 if (length < 0)
3690 {
3691 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength);
Olli Etuaho4f667482016-03-30 15:56:35 +03003692 return false;
3693 }
3694
3695 if (!ValidBufferTarget(context, target))
3696 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003697 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003698 return false;
3699 }
3700
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003701 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003702
3703 if (buffer == nullptr)
3704 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003705 context->handleError(InvalidOperation() << "Attempted to flush buffer object zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003706 return false;
3707 }
3708
3709 if (!buffer->isMapped() || (buffer->getAccessFlags() & GL_MAP_FLUSH_EXPLICIT_BIT) == 0)
3710 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003711 context->handleError(InvalidOperation()
3712 << "Attempted to flush a buffer not mapped for explicit flushing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003713 return false;
3714 }
3715
3716 // Check for buffer overflow
Jamie Madille2e406c2016-06-02 13:04:10 -04003717 CheckedNumeric<size_t> checkedOffset(offset);
3718 auto checkedSize = checkedOffset + length;
Olli Etuaho4f667482016-03-30 15:56:35 +03003719
Jamie Madille2e406c2016-06-02 13:04:10 -04003720 if (!checkedSize.IsValid() ||
3721 checkedSize.ValueOrDie() > static_cast<size_t>(buffer->getMapLength()))
Olli Etuaho4f667482016-03-30 15:56:35 +03003722 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003723 context->handleError(InvalidValue()
3724 << "Flushed range does not fit into buffer mapping dimensions.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003725 return false;
3726 }
3727
3728 return true;
3729}
3730
Olli Etuaho41997e72016-03-10 13:38:39 +02003731bool ValidateGenOrDelete(Context *context, GLint n)
3732{
3733 if (n < 0)
3734 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003735 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Olli Etuaho41997e72016-03-10 13:38:39 +02003736 return false;
3737 }
3738 return true;
3739}
3740
Geoff Langff5b2d52016-09-07 11:32:23 -04003741bool ValidateRobustEntryPoint(ValidationContext *context, GLsizei bufSize)
3742{
3743 if (!context->getExtensions().robustClientMemory)
3744 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003745 context->handleError(InvalidOperation()
3746 << "GL_ANGLE_robust_client_memory is not available.");
Geoff Langff5b2d52016-09-07 11:32:23 -04003747 return false;
3748 }
3749
3750 if (bufSize < 0)
3751 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003752 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Geoff Langff5b2d52016-09-07 11:32:23 -04003753 return false;
3754 }
3755
3756 return true;
3757}
3758
Geoff Lang2e43dbb2016-10-14 12:27:35 -04003759bool ValidateRobustBufferSize(ValidationContext *context, GLsizei bufSize, GLsizei numParams)
3760{
3761 if (bufSize < numParams)
3762 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003763 context->handleError(InvalidOperation() << numParams << " parameters are required but "
3764 << bufSize << " were provided.");
Geoff Lang2e43dbb2016-10-14 12:27:35 -04003765 return false;
3766 }
3767
3768 return true;
3769}
3770
Jamie Madillbe849e42017-05-02 15:49:00 -04003771bool ValidateGetFramebufferAttachmentParameterivBase(ValidationContext *context,
3772 GLenum target,
3773 GLenum attachment,
3774 GLenum pname,
3775 GLsizei *numParams)
Geoff Langff5b2d52016-09-07 11:32:23 -04003776{
Geoff Langff5b2d52016-09-07 11:32:23 -04003777 if (!ValidFramebufferTarget(target))
3778 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003779 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003780 return false;
3781 }
3782
3783 int clientVersion = context->getClientMajorVersion();
3784
3785 switch (pname)
3786 {
3787 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
3788 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
3789 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL:
3790 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE:
3791 break;
3792
Martin Radeve5285d22017-07-14 16:23:53 +03003793 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_NUM_VIEWS_ANGLE:
3794 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_MULTIVIEW_LAYOUT_ANGLE:
3795 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_BASE_VIEW_INDEX_ANGLE:
3796 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE:
3797 if (clientVersion < 3 || !context->getExtensions().multiview)
3798 {
3799 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
3800 return false;
3801 }
3802 break;
3803
Geoff Langff5b2d52016-09-07 11:32:23 -04003804 case GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING:
3805 if (clientVersion < 3 && !context->getExtensions().sRGB)
3806 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003807 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003808 return false;
3809 }
3810 break;
3811
3812 case GL_FRAMEBUFFER_ATTACHMENT_RED_SIZE:
3813 case GL_FRAMEBUFFER_ATTACHMENT_GREEN_SIZE:
3814 case GL_FRAMEBUFFER_ATTACHMENT_BLUE_SIZE:
3815 case GL_FRAMEBUFFER_ATTACHMENT_ALPHA_SIZE:
3816 case GL_FRAMEBUFFER_ATTACHMENT_DEPTH_SIZE:
3817 case GL_FRAMEBUFFER_ATTACHMENT_STENCIL_SIZE:
3818 case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:
3819 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:
3820 if (clientVersion < 3)
3821 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003822 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003823 return false;
3824 }
3825 break;
3826
3827 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003828 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003829 return false;
3830 }
3831
3832 // Determine if the attachment is a valid enum
3833 switch (attachment)
3834 {
3835 case GL_BACK:
3836 case GL_FRONT:
3837 case GL_DEPTH:
3838 case GL_STENCIL:
3839 case GL_DEPTH_STENCIL_ATTACHMENT:
3840 if (clientVersion < 3)
3841 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003842 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003843 return false;
3844 }
3845 break;
3846
3847 case GL_DEPTH_ATTACHMENT:
3848 case GL_STENCIL_ATTACHMENT:
3849 break;
3850
3851 default:
3852 if (attachment < GL_COLOR_ATTACHMENT0_EXT ||
3853 (attachment - GL_COLOR_ATTACHMENT0_EXT) >= context->getCaps().maxColorAttachments)
3854 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003855 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003856 return false;
3857 }
3858 break;
3859 }
3860
3861 const Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
3862 ASSERT(framebuffer);
3863
3864 if (framebuffer->id() == 0)
3865 {
3866 if (clientVersion < 3)
3867 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003868 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langff5b2d52016-09-07 11:32:23 -04003869 return false;
3870 }
3871
3872 switch (attachment)
3873 {
3874 case GL_BACK:
3875 case GL_DEPTH:
3876 case GL_STENCIL:
3877 break;
3878
3879 default:
Brandon Jonesafa75152017-07-21 13:11:29 -07003880 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003881 return false;
3882 }
3883 }
3884 else
3885 {
3886 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
3887 {
3888 // Valid attachment query
3889 }
3890 else
3891 {
3892 switch (attachment)
3893 {
3894 case GL_DEPTH_ATTACHMENT:
3895 case GL_STENCIL_ATTACHMENT:
3896 break;
3897
3898 case GL_DEPTH_STENCIL_ATTACHMENT:
3899 if (!framebuffer->hasValidDepthStencil())
3900 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003901 context->handleError(InvalidOperation());
Geoff Langff5b2d52016-09-07 11:32:23 -04003902 return false;
3903 }
3904 break;
3905
3906 default:
Brandon Jonesafa75152017-07-21 13:11:29 -07003907 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003908 return false;
3909 }
3910 }
3911 }
3912
3913 const FramebufferAttachment *attachmentObject = framebuffer->getAttachment(attachment);
3914 if (attachmentObject)
3915 {
3916 ASSERT(attachmentObject->type() == GL_RENDERBUFFER ||
3917 attachmentObject->type() == GL_TEXTURE ||
3918 attachmentObject->type() == GL_FRAMEBUFFER_DEFAULT);
3919
3920 switch (pname)
3921 {
3922 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
3923 if (attachmentObject->type() != GL_RENDERBUFFER &&
3924 attachmentObject->type() != GL_TEXTURE)
3925 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003926 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003927 return false;
3928 }
3929 break;
3930
3931 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL:
3932 if (attachmentObject->type() != GL_TEXTURE)
3933 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003934 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003935 return false;
3936 }
3937 break;
3938
3939 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE:
3940 if (attachmentObject->type() != GL_TEXTURE)
3941 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003942 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003943 return false;
3944 }
3945 break;
3946
3947 case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:
3948 if (attachment == GL_DEPTH_STENCIL_ATTACHMENT)
3949 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003950 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003951 return false;
3952 }
3953 break;
3954
3955 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:
3956 if (attachmentObject->type() != GL_TEXTURE)
3957 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003958 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003959 return false;
3960 }
3961 break;
3962
3963 default:
3964 break;
3965 }
3966 }
3967 else
3968 {
3969 // ES 2.0.25 spec pg 127 states that if the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE
3970 // is NONE, then querying any other pname will generate INVALID_ENUM.
3971
3972 // ES 3.0.2 spec pg 235 states that if the attachment type is none,
3973 // GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME will return zero and be an
3974 // INVALID_OPERATION for all other pnames
3975
3976 switch (pname)
3977 {
3978 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
3979 break;
3980
3981 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
3982 if (clientVersion < 3)
3983 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003984 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
Brandon Jonesafa75152017-07-21 13:11:29 -07003985 InvalidFramebufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04003986 return false;
3987 }
3988 break;
3989
3990 default:
3991 if (clientVersion < 3)
3992 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003993 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
Brandon Jonesafa75152017-07-21 13:11:29 -07003994 InvalidFramebufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04003995 return false;
3996 }
3997 else
3998 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003999 ANGLE_VALIDATION_ERR(context, InvalidOperation(),
Brandon Jonesafa75152017-07-21 13:11:29 -07004000 InvalidFramebufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004001 return false;
4002 }
4003 }
4004 }
4005
Martin Radeve5285d22017-07-14 16:23:53 +03004006 if (numParams)
4007 {
4008 if (pname == GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE)
4009 {
4010 // Only when the viewport offsets are queried we can have a varying number of output
4011 // parameters.
4012 const int numViews = attachmentObject ? attachmentObject->getNumViews() : 1;
4013 *numParams = numViews * 2;
4014 }
4015 else
4016 {
4017 // For all other queries we can have only one output parameter.
4018 *numParams = 1;
4019 }
4020 }
4021
Geoff Langff5b2d52016-09-07 11:32:23 -04004022 return true;
4023}
4024
4025bool ValidateGetFramebufferAttachmentParameterivRobustANGLE(ValidationContext *context,
4026 GLenum target,
4027 GLenum attachment,
4028 GLenum pname,
4029 GLsizei bufSize,
4030 GLsizei *numParams)
4031{
4032 if (!ValidateRobustEntryPoint(context, bufSize))
4033 {
4034 return false;
4035 }
4036
Jamie Madillbe849e42017-05-02 15:49:00 -04004037 if (!ValidateGetFramebufferAttachmentParameterivBase(context, target, attachment, pname,
4038 numParams))
Geoff Langff5b2d52016-09-07 11:32:23 -04004039 {
4040 return false;
4041 }
4042
4043 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
4044 {
4045 return false;
4046 }
4047
4048 return true;
4049}
4050
Geoff Langff5b2d52016-09-07 11:32:23 -04004051bool ValidateGetBufferParameterivRobustANGLE(ValidationContext *context,
4052 GLenum target,
4053 GLenum pname,
4054 GLsizei bufSize,
Geoff Langebebe1c2016-10-14 12:01:31 -04004055 GLsizei *length,
4056 GLint *params)
Geoff Langff5b2d52016-09-07 11:32:23 -04004057{
4058 if (!ValidateRobustEntryPoint(context, bufSize))
4059 {
4060 return false;
4061 }
4062
Geoff Langebebe1c2016-10-14 12:01:31 -04004063 if (!ValidateGetBufferParameterBase(context, target, pname, false, length))
Geoff Langff5b2d52016-09-07 11:32:23 -04004064 {
4065 return false;
4066 }
4067
Geoff Langebebe1c2016-10-14 12:01:31 -04004068 if (!ValidateRobustBufferSize(context, bufSize, *length))
4069 {
4070 return false;
4071 }
4072
4073 return true;
4074}
4075
Geoff Langebebe1c2016-10-14 12:01:31 -04004076bool ValidateGetBufferParameteri64vRobustANGLE(ValidationContext *context,
4077 GLenum target,
4078 GLenum pname,
4079 GLsizei bufSize,
4080 GLsizei *length,
4081 GLint64 *params)
4082{
4083 if (!ValidateRobustEntryPoint(context, bufSize))
4084 {
4085 return false;
4086 }
4087
4088 if (!ValidateGetBufferParameterBase(context, target, pname, false, length))
4089 {
4090 return false;
4091 }
4092
4093 if (!ValidateRobustBufferSize(context, bufSize, *length))
Geoff Langff5b2d52016-09-07 11:32:23 -04004094 {
4095 return false;
4096 }
4097
4098 return true;
4099}
4100
Jamie Madillbe849e42017-05-02 15:49:00 -04004101bool ValidateGetProgramivBase(ValidationContext *context,
4102 GLuint program,
4103 GLenum pname,
4104 GLsizei *numParams)
Geoff Langff5b2d52016-09-07 11:32:23 -04004105{
4106 // Currently, all GetProgramiv queries return 1 parameter
Yunchao He33151a52017-04-13 09:58:17 +08004107 if (numParams)
4108 {
4109 *numParams = 1;
4110 }
Geoff Langff5b2d52016-09-07 11:32:23 -04004111
4112 Program *programObject = GetValidProgram(context, program);
4113 if (!programObject)
4114 {
4115 return false;
4116 }
4117
4118 switch (pname)
4119 {
4120 case GL_DELETE_STATUS:
4121 case GL_LINK_STATUS:
4122 case GL_VALIDATE_STATUS:
4123 case GL_INFO_LOG_LENGTH:
4124 case GL_ATTACHED_SHADERS:
4125 case GL_ACTIVE_ATTRIBUTES:
4126 case GL_ACTIVE_ATTRIBUTE_MAX_LENGTH:
4127 case GL_ACTIVE_UNIFORMS:
4128 case GL_ACTIVE_UNIFORM_MAX_LENGTH:
4129 break;
4130
4131 case GL_PROGRAM_BINARY_LENGTH:
4132 if (context->getClientMajorVersion() < 3 && !context->getExtensions().getProgramBinary)
4133 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004134 context->handleError(InvalidEnum() << "Querying GL_PROGRAM_BINARY_LENGTH "
4135 "requires GL_OES_get_program_binary or "
4136 "ES 3.0.");
Geoff Langff5b2d52016-09-07 11:32:23 -04004137 return false;
4138 }
4139 break;
4140
4141 case GL_ACTIVE_UNIFORM_BLOCKS:
4142 case GL_ACTIVE_UNIFORM_BLOCK_MAX_NAME_LENGTH:
4143 case GL_TRANSFORM_FEEDBACK_BUFFER_MODE:
4144 case GL_TRANSFORM_FEEDBACK_VARYINGS:
4145 case GL_TRANSFORM_FEEDBACK_VARYING_MAX_LENGTH:
4146 case GL_PROGRAM_BINARY_RETRIEVABLE_HINT:
4147 if (context->getClientMajorVersion() < 3)
4148 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08004149 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ES3Required);
Geoff Langff5b2d52016-09-07 11:32:23 -04004150 return false;
4151 }
4152 break;
4153
Yunchao He61afff12017-03-14 15:34:03 +08004154 case GL_PROGRAM_SEPARABLE:
Xinghua Cao971f8502017-10-17 13:01:24 +08004155 case GL_COMPUTE_WORK_GROUP_SIZE:
Yunchao He61afff12017-03-14 15:34:03 +08004156 if (context->getClientVersion() < Version(3, 1))
4157 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08004158 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ES31Required);
Yunchao He61afff12017-03-14 15:34:03 +08004159 return false;
4160 }
4161 break;
4162
Geoff Langff5b2d52016-09-07 11:32:23 -04004163 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004164 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langff5b2d52016-09-07 11:32:23 -04004165 return false;
4166 }
4167
4168 return true;
4169}
4170
4171bool ValidateGetProgramivRobustANGLE(Context *context,
4172 GLuint program,
4173 GLenum pname,
4174 GLsizei bufSize,
4175 GLsizei *numParams)
4176{
4177 if (!ValidateRobustEntryPoint(context, bufSize))
4178 {
4179 return false;
4180 }
4181
Jamie Madillbe849e42017-05-02 15:49:00 -04004182 if (!ValidateGetProgramivBase(context, program, pname, numParams))
Geoff Langff5b2d52016-09-07 11:32:23 -04004183 {
4184 return false;
4185 }
4186
4187 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
4188 {
4189 return false;
4190 }
4191
4192 return true;
4193}
4194
Geoff Lang740d9022016-10-07 11:20:52 -04004195bool ValidateGetRenderbufferParameterivRobustANGLE(Context *context,
4196 GLenum target,
4197 GLenum pname,
4198 GLsizei bufSize,
4199 GLsizei *length,
4200 GLint *params)
4201{
4202 if (!ValidateRobustEntryPoint(context, bufSize))
4203 {
4204 return false;
4205 }
4206
4207 if (!ValidateGetRenderbufferParameterivBase(context, target, pname, length))
4208 {
4209 return false;
4210 }
4211
4212 if (!ValidateRobustBufferSize(context, bufSize, *length))
4213 {
4214 return false;
4215 }
4216
4217 return true;
4218}
4219
Geoff Langd7d0ed32016-10-07 11:33:51 -04004220bool ValidateGetShaderivRobustANGLE(Context *context,
4221 GLuint shader,
4222 GLenum pname,
4223 GLsizei bufSize,
4224 GLsizei *length,
4225 GLint *params)
4226{
4227 if (!ValidateRobustEntryPoint(context, bufSize))
4228 {
4229 return false;
4230 }
4231
4232 if (!ValidateGetShaderivBase(context, shader, pname, length))
4233 {
4234 return false;
4235 }
4236
4237 if (!ValidateRobustBufferSize(context, bufSize, *length))
4238 {
4239 return false;
4240 }
4241
4242 return true;
4243}
4244
Geoff Langc1984ed2016-10-07 12:41:00 -04004245bool ValidateGetTexParameterfvRobustANGLE(Context *context,
4246 GLenum target,
4247 GLenum pname,
4248 GLsizei bufSize,
4249 GLsizei *length,
4250 GLfloat *params)
4251{
4252 if (!ValidateRobustEntryPoint(context, bufSize))
4253 {
4254 return false;
4255 }
4256
4257 if (!ValidateGetTexParameterBase(context, target, pname, length))
4258 {
4259 return false;
4260 }
4261
4262 if (!ValidateRobustBufferSize(context, bufSize, *length))
4263 {
4264 return false;
4265 }
4266
4267 return true;
4268}
4269
Geoff Langc1984ed2016-10-07 12:41:00 -04004270bool ValidateGetTexParameterivRobustANGLE(Context *context,
4271 GLenum target,
4272 GLenum pname,
4273 GLsizei bufSize,
4274 GLsizei *length,
4275 GLint *params)
4276{
4277 if (!ValidateRobustEntryPoint(context, bufSize))
4278 {
4279 return false;
4280 }
4281
4282 if (!ValidateGetTexParameterBase(context, target, pname, length))
4283 {
4284 return false;
4285 }
4286
4287 if (!ValidateRobustBufferSize(context, bufSize, *length))
4288 {
4289 return false;
4290 }
4291
4292 return true;
4293}
4294
Geoff Langc1984ed2016-10-07 12:41:00 -04004295bool ValidateTexParameterfvRobustANGLE(Context *context,
4296 GLenum target,
4297 GLenum pname,
4298 GLsizei bufSize,
4299 const GLfloat *params)
4300{
4301 if (!ValidateRobustEntryPoint(context, bufSize))
4302 {
4303 return false;
4304 }
4305
4306 return ValidateTexParameterBase(context, target, pname, bufSize, params);
4307}
4308
Geoff Langc1984ed2016-10-07 12:41:00 -04004309bool ValidateTexParameterivRobustANGLE(Context *context,
4310 GLenum target,
4311 GLenum pname,
4312 GLsizei bufSize,
4313 const GLint *params)
4314{
4315 if (!ValidateRobustEntryPoint(context, bufSize))
4316 {
4317 return false;
4318 }
4319
4320 return ValidateTexParameterBase(context, target, pname, bufSize, params);
4321}
4322
Geoff Langc1984ed2016-10-07 12:41:00 -04004323bool ValidateGetSamplerParameterfvRobustANGLE(Context *context,
4324 GLuint sampler,
4325 GLenum pname,
4326 GLuint bufSize,
4327 GLsizei *length,
4328 GLfloat *params)
4329{
4330 if (!ValidateRobustEntryPoint(context, bufSize))
4331 {
4332 return false;
4333 }
4334
4335 if (!ValidateGetSamplerParameterBase(context, sampler, pname, length))
4336 {
4337 return false;
4338 }
4339
4340 if (!ValidateRobustBufferSize(context, bufSize, *length))
4341 {
4342 return false;
4343 }
4344
4345 return true;
4346}
4347
Geoff Langc1984ed2016-10-07 12:41:00 -04004348bool ValidateGetSamplerParameterivRobustANGLE(Context *context,
4349 GLuint sampler,
4350 GLenum pname,
4351 GLuint bufSize,
4352 GLsizei *length,
4353 GLint *params)
4354{
4355 if (!ValidateRobustEntryPoint(context, bufSize))
4356 {
4357 return false;
4358 }
4359
4360 if (!ValidateGetSamplerParameterBase(context, sampler, pname, length))
4361 {
4362 return false;
4363 }
4364
4365 if (!ValidateRobustBufferSize(context, bufSize, *length))
4366 {
4367 return false;
4368 }
4369
4370 return true;
4371}
4372
Geoff Langc1984ed2016-10-07 12:41:00 -04004373bool ValidateSamplerParameterfvRobustANGLE(Context *context,
4374 GLuint sampler,
4375 GLenum pname,
4376 GLsizei bufSize,
4377 const GLfloat *params)
4378{
4379 if (!ValidateRobustEntryPoint(context, bufSize))
4380 {
4381 return false;
4382 }
4383
4384 return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params);
4385}
4386
Geoff Langc1984ed2016-10-07 12:41:00 -04004387bool ValidateSamplerParameterivRobustANGLE(Context *context,
4388 GLuint sampler,
4389 GLenum pname,
4390 GLsizei bufSize,
4391 const GLint *params)
4392{
4393 if (!ValidateRobustEntryPoint(context, bufSize))
4394 {
4395 return false;
4396 }
4397
4398 return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params);
4399}
4400
Geoff Lang0b031062016-10-13 14:30:04 -04004401bool ValidateGetVertexAttribfvRobustANGLE(Context *context,
4402 GLuint index,
4403 GLenum pname,
4404 GLsizei bufSize,
4405 GLsizei *length,
4406 GLfloat *params)
4407{
4408 if (!ValidateRobustEntryPoint(context, bufSize))
4409 {
4410 return false;
4411 }
4412
4413 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false))
4414 {
4415 return false;
4416 }
4417
4418 if (!ValidateRobustBufferSize(context, bufSize, *length))
4419 {
4420 return false;
4421 }
4422
4423 return true;
4424}
4425
Geoff Lang0b031062016-10-13 14:30:04 -04004426bool ValidateGetVertexAttribivRobustANGLE(Context *context,
4427 GLuint index,
4428 GLenum pname,
4429 GLsizei bufSize,
4430 GLsizei *length,
4431 GLint *params)
4432{
4433 if (!ValidateRobustEntryPoint(context, bufSize))
4434 {
4435 return false;
4436 }
4437
4438 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false))
4439 {
4440 return false;
4441 }
4442
4443 if (!ValidateRobustBufferSize(context, bufSize, *length))
4444 {
4445 return false;
4446 }
4447
4448 return true;
4449}
4450
Geoff Lang0b031062016-10-13 14:30:04 -04004451bool ValidateGetVertexAttribPointervRobustANGLE(Context *context,
4452 GLuint index,
4453 GLenum pname,
4454 GLsizei bufSize,
4455 GLsizei *length,
4456 void **pointer)
4457{
4458 if (!ValidateRobustEntryPoint(context, bufSize))
4459 {
4460 return false;
4461 }
4462
4463 if (!ValidateGetVertexAttribBase(context, index, pname, length, true, false))
4464 {
4465 return false;
4466 }
4467
4468 if (!ValidateRobustBufferSize(context, bufSize, *length))
4469 {
4470 return false;
4471 }
4472
4473 return true;
4474}
4475
Geoff Lang0b031062016-10-13 14:30:04 -04004476bool ValidateGetVertexAttribIivRobustANGLE(Context *context,
4477 GLuint index,
4478 GLenum pname,
4479 GLsizei bufSize,
4480 GLsizei *length,
4481 GLint *params)
4482{
4483 if (!ValidateRobustEntryPoint(context, bufSize))
4484 {
4485 return false;
4486 }
4487
4488 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true))
4489 {
4490 return false;
4491 }
4492
4493 if (!ValidateRobustBufferSize(context, bufSize, *length))
4494 {
4495 return false;
4496 }
4497
4498 return true;
4499}
4500
Geoff Lang0b031062016-10-13 14:30:04 -04004501bool ValidateGetVertexAttribIuivRobustANGLE(Context *context,
4502 GLuint index,
4503 GLenum pname,
4504 GLsizei bufSize,
4505 GLsizei *length,
4506 GLuint *params)
4507{
4508 if (!ValidateRobustEntryPoint(context, bufSize))
4509 {
4510 return false;
4511 }
4512
4513 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true))
4514 {
4515 return false;
4516 }
4517
4518 if (!ValidateRobustBufferSize(context, bufSize, *length))
4519 {
4520 return false;
4521 }
4522
4523 return true;
4524}
4525
Geoff Lang6899b872016-10-14 11:30:13 -04004526bool ValidateGetActiveUniformBlockivRobustANGLE(Context *context,
4527 GLuint program,
4528 GLuint uniformBlockIndex,
4529 GLenum pname,
4530 GLsizei bufSize,
4531 GLsizei *length,
4532 GLint *params)
4533{
4534 if (!ValidateRobustEntryPoint(context, bufSize))
4535 {
4536 return false;
4537 }
4538
4539 if (!ValidateGetActiveUniformBlockivBase(context, program, uniformBlockIndex, pname, length))
4540 {
4541 return false;
4542 }
4543
4544 if (!ValidateRobustBufferSize(context, bufSize, *length))
4545 {
4546 return false;
4547 }
4548
4549 return true;
4550}
4551
Geoff Lang0a9661f2016-10-20 10:59:20 -07004552bool ValidateGetInternalFormativRobustANGLE(Context *context,
4553 GLenum target,
4554 GLenum internalformat,
4555 GLenum pname,
4556 GLsizei bufSize,
4557 GLsizei *length,
4558 GLint *params)
4559{
4560 if (!ValidateRobustEntryPoint(context, bufSize))
4561 {
4562 return false;
4563 }
4564
4565 if (!ValidateGetInternalFormativBase(context, target, internalformat, pname, bufSize, length))
4566 {
4567 return false;
4568 }
4569
4570 if (!ValidateRobustBufferSize(context, bufSize, *length))
4571 {
4572 return false;
4573 }
4574
4575 return true;
4576}
4577
Shao80957d92017-02-20 21:25:59 +08004578bool ValidateVertexFormatBase(ValidationContext *context,
4579 GLuint attribIndex,
4580 GLint size,
4581 GLenum type,
4582 GLboolean pureInteger)
4583{
4584 const Caps &caps = context->getCaps();
4585 if (attribIndex >= caps.maxVertexAttributes)
4586 {
Brandon Jonesafa75152017-07-21 13:11:29 -07004587 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxVertexAttribute);
Shao80957d92017-02-20 21:25:59 +08004588 return false;
4589 }
4590
4591 if (size < 1 || size > 4)
4592 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004593 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidVertexAttrSize);
Geoff Lang8700a982017-06-13 10:15:13 -04004594 return false;
Shao80957d92017-02-20 21:25:59 +08004595 }
4596
4597 switch (type)
4598 {
4599 case GL_BYTE:
4600 case GL_UNSIGNED_BYTE:
4601 case GL_SHORT:
4602 case GL_UNSIGNED_SHORT:
4603 break;
4604
4605 case GL_INT:
4606 case GL_UNSIGNED_INT:
4607 if (context->getClientMajorVersion() < 3)
4608 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004609 context->handleError(InvalidEnum()
4610 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004611 return false;
4612 }
4613 break;
4614
4615 case GL_FIXED:
4616 case GL_FLOAT:
4617 if (pureInteger)
4618 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004619 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004620 return false;
4621 }
4622 break;
4623
4624 case GL_HALF_FLOAT:
4625 if (context->getClientMajorVersion() < 3)
4626 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004627 context->handleError(InvalidEnum()
4628 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004629 return false;
4630 }
4631 if (pureInteger)
4632 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004633 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004634 return false;
4635 }
4636 break;
4637
4638 case GL_INT_2_10_10_10_REV:
4639 case GL_UNSIGNED_INT_2_10_10_10_REV:
4640 if (context->getClientMajorVersion() < 3)
4641 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004642 context->handleError(InvalidEnum()
4643 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004644 return false;
4645 }
4646 if (pureInteger)
4647 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004648 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004649 return false;
4650 }
4651 if (size != 4)
4652 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004653 context->handleError(InvalidOperation() << "Type is INT_2_10_10_10_REV or "
4654 "UNSIGNED_INT_2_10_10_10_REV and "
4655 "size is not 4.");
Shao80957d92017-02-20 21:25:59 +08004656 return false;
4657 }
4658 break;
4659
4660 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004661 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidType);
Shao80957d92017-02-20 21:25:59 +08004662 return false;
4663 }
4664
4665 return true;
4666}
4667
Geoff Lang76e65652017-03-27 14:58:02 -04004668// Perform validation from WebGL 2 section 5.10 "Invalid Clears":
4669// In the WebGL 2 API, trying to perform a clear when there is a mismatch between the type of the
4670// specified clear value and the type of a buffer that is being cleared generates an
4671// INVALID_OPERATION error instead of producing undefined results
4672bool ValidateWebGLFramebufferAttachmentClearType(ValidationContext *context,
4673 GLint drawbuffer,
4674 const GLenum *validComponentTypes,
4675 size_t validComponentTypeCount)
4676{
4677 const FramebufferAttachment *attachment =
4678 context->getGLState().getDrawFramebuffer()->getDrawBuffer(drawbuffer);
4679 if (attachment)
4680 {
4681 GLenum componentType = attachment->getFormat().info->componentType;
4682 const GLenum *end = validComponentTypes + validComponentTypeCount;
4683 if (std::find(validComponentTypes, end, componentType) == end)
4684 {
4685 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004686 InvalidOperation()
4687 << "No defined conversion between clear value and attachment format.");
Geoff Lang76e65652017-03-27 14:58:02 -04004688 return false;
4689 }
4690 }
4691
4692 return true;
4693}
4694
Corentin Wallezb2931602017-04-11 15:58:57 -04004695bool ValidateRobustCompressedTexImageBase(ValidationContext *context,
4696 GLsizei imageSize,
4697 GLsizei dataSize)
4698{
4699 if (!ValidateRobustEntryPoint(context, dataSize))
4700 {
4701 return false;
4702 }
4703
4704 gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
4705 if (pixelUnpackBuffer == nullptr)
4706 {
4707 if (dataSize < imageSize)
4708 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004709 context->handleError(InvalidOperation() << "dataSize must be at least " << imageSize);
Corentin Wallezb2931602017-04-11 15:58:57 -04004710 }
4711 }
4712 return true;
4713}
4714
Jamie Madillbe849e42017-05-02 15:49:00 -04004715bool ValidateGetBufferParameterBase(ValidationContext *context,
4716 GLenum target,
4717 GLenum pname,
4718 bool pointerVersion,
4719 GLsizei *numParams)
4720{
4721 if (numParams)
4722 {
4723 *numParams = 0;
4724 }
4725
4726 if (!ValidBufferTarget(context, target))
4727 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004728 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Jamie Madillbe849e42017-05-02 15:49:00 -04004729 return false;
4730 }
4731
4732 const Buffer *buffer = context->getGLState().getTargetBuffer(target);
4733 if (!buffer)
4734 {
4735 // A null buffer means that "0" is bound to the requested buffer target
Brandon Jones6cad5662017-06-14 13:25:13 -07004736 ANGLE_VALIDATION_ERR(context, InvalidOperation(), BufferNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04004737 return false;
4738 }
4739
4740 const Extensions &extensions = context->getExtensions();
4741
4742 switch (pname)
4743 {
4744 case GL_BUFFER_USAGE:
4745 case GL_BUFFER_SIZE:
4746 break;
4747
4748 case GL_BUFFER_ACCESS_OES:
4749 if (!extensions.mapBuffer)
4750 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004751 context->handleError(InvalidEnum()
4752 << "pname requires OpenGL ES 3.0 or GL_OES_mapbuffer.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004753 return false;
4754 }
4755 break;
4756
4757 case GL_BUFFER_MAPPED:
4758 static_assert(GL_BUFFER_MAPPED == GL_BUFFER_MAPPED_OES, "GL enums should be equal.");
4759 if (context->getClientMajorVersion() < 3 && !extensions.mapBuffer &&
4760 !extensions.mapBufferRange)
4761 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004762 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0, "
4763 "GL_OES_mapbuffer or "
4764 "GL_EXT_map_buffer_range.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004765 return false;
4766 }
4767 break;
4768
4769 case GL_BUFFER_MAP_POINTER:
4770 if (!pointerVersion)
4771 {
4772 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004773 InvalidEnum()
4774 << "GL_BUFFER_MAP_POINTER can only be queried with GetBufferPointerv.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004775 return false;
4776 }
4777 break;
4778
4779 case GL_BUFFER_ACCESS_FLAGS:
4780 case GL_BUFFER_MAP_OFFSET:
4781 case GL_BUFFER_MAP_LENGTH:
4782 if (context->getClientMajorVersion() < 3 && !extensions.mapBufferRange)
4783 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004784 context->handleError(InvalidEnum()
4785 << "pname requires OpenGL ES 3.0 or GL_EXT_map_buffer_range.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004786 return false;
4787 }
4788 break;
4789
4790 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004791 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04004792 return false;
4793 }
4794
4795 // All buffer parameter queries return one value.
4796 if (numParams)
4797 {
4798 *numParams = 1;
4799 }
4800
4801 return true;
4802}
4803
4804bool ValidateGetRenderbufferParameterivBase(Context *context,
4805 GLenum target,
4806 GLenum pname,
4807 GLsizei *length)
4808{
4809 if (length)
4810 {
4811 *length = 0;
4812 }
4813
4814 if (target != GL_RENDERBUFFER)
4815 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004816 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04004817 return false;
4818 }
4819
4820 Renderbuffer *renderbuffer = context->getGLState().getCurrentRenderbuffer();
4821 if (renderbuffer == nullptr)
4822 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004823 ANGLE_VALIDATION_ERR(context, InvalidOperation(), RenderbufferNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04004824 return false;
4825 }
4826
4827 switch (pname)
4828 {
4829 case GL_RENDERBUFFER_WIDTH:
4830 case GL_RENDERBUFFER_HEIGHT:
4831 case GL_RENDERBUFFER_INTERNAL_FORMAT:
4832 case GL_RENDERBUFFER_RED_SIZE:
4833 case GL_RENDERBUFFER_GREEN_SIZE:
4834 case GL_RENDERBUFFER_BLUE_SIZE:
4835 case GL_RENDERBUFFER_ALPHA_SIZE:
4836 case GL_RENDERBUFFER_DEPTH_SIZE:
4837 case GL_RENDERBUFFER_STENCIL_SIZE:
4838 break;
4839
4840 case GL_RENDERBUFFER_SAMPLES_ANGLE:
4841 if (!context->getExtensions().framebufferMultisample)
4842 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004843 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04004844 return false;
4845 }
4846 break;
4847
4848 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004849 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04004850 return false;
4851 }
4852
4853 if (length)
4854 {
4855 *length = 1;
4856 }
4857 return true;
4858}
4859
4860bool ValidateGetShaderivBase(Context *context, GLuint shader, GLenum pname, GLsizei *length)
4861{
4862 if (length)
4863 {
4864 *length = 0;
4865 }
4866
4867 if (GetValidShader(context, shader) == nullptr)
4868 {
4869 return false;
4870 }
4871
4872 switch (pname)
4873 {
4874 case GL_SHADER_TYPE:
4875 case GL_DELETE_STATUS:
4876 case GL_COMPILE_STATUS:
4877 case GL_INFO_LOG_LENGTH:
4878 case GL_SHADER_SOURCE_LENGTH:
4879 break;
4880
4881 case GL_TRANSLATED_SHADER_SOURCE_LENGTH_ANGLE:
4882 if (!context->getExtensions().translatedShaderSource)
4883 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004884 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04004885 return false;
4886 }
4887 break;
4888
4889 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004890 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04004891 return false;
4892 }
4893
4894 if (length)
4895 {
4896 *length = 1;
4897 }
4898 return true;
4899}
4900
4901bool ValidateGetTexParameterBase(Context *context, GLenum target, GLenum pname, GLsizei *length)
4902{
4903 if (length)
4904 {
4905 *length = 0;
4906 }
4907
4908 if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
4909 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004910 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04004911 return false;
4912 }
4913
4914 if (context->getTargetTexture(target) == nullptr)
4915 {
4916 // Should only be possible for external textures
Brandon Jones6cad5662017-06-14 13:25:13 -07004917 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04004918 return false;
4919 }
4920
4921 switch (pname)
4922 {
4923 case GL_TEXTURE_MAG_FILTER:
4924 case GL_TEXTURE_MIN_FILTER:
4925 case GL_TEXTURE_WRAP_S:
4926 case GL_TEXTURE_WRAP_T:
4927 break;
4928
4929 case GL_TEXTURE_USAGE_ANGLE:
4930 if (!context->getExtensions().textureUsage)
4931 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004932 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04004933 return false;
4934 }
4935 break;
4936
4937 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
4938 if (!context->getExtensions().textureFilterAnisotropic)
4939 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004940 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04004941 return false;
4942 }
4943 break;
4944
4945 case GL_TEXTURE_IMMUTABLE_FORMAT:
4946 if (context->getClientMajorVersion() < 3 && !context->getExtensions().textureStorage)
4947 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004948 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04004949 return false;
4950 }
4951 break;
4952
4953 case GL_TEXTURE_WRAP_R:
4954 case GL_TEXTURE_IMMUTABLE_LEVELS:
4955 case GL_TEXTURE_SWIZZLE_R:
4956 case GL_TEXTURE_SWIZZLE_G:
4957 case GL_TEXTURE_SWIZZLE_B:
4958 case GL_TEXTURE_SWIZZLE_A:
4959 case GL_TEXTURE_BASE_LEVEL:
4960 case GL_TEXTURE_MAX_LEVEL:
4961 case GL_TEXTURE_MIN_LOD:
4962 case GL_TEXTURE_MAX_LOD:
4963 case GL_TEXTURE_COMPARE_MODE:
4964 case GL_TEXTURE_COMPARE_FUNC:
4965 if (context->getClientMajorVersion() < 3)
4966 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004967 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004968 return false;
4969 }
4970 break;
4971
4972 case GL_TEXTURE_SRGB_DECODE_EXT:
4973 if (!context->getExtensions().textureSRGBDecode)
4974 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004975 context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004976 return false;
4977 }
4978 break;
4979
4980 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004981 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04004982 return false;
4983 }
4984
4985 if (length)
4986 {
4987 *length = 1;
4988 }
4989 return true;
4990}
4991
4992bool ValidateGetVertexAttribBase(Context *context,
4993 GLuint index,
4994 GLenum pname,
4995 GLsizei *length,
4996 bool pointer,
4997 bool pureIntegerEntryPoint)
4998{
4999 if (length)
5000 {
5001 *length = 0;
5002 }
5003
5004 if (pureIntegerEntryPoint && context->getClientMajorVersion() < 3)
5005 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005006 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005007 return false;
5008 }
5009
5010 if (index >= context->getCaps().maxVertexAttributes)
5011 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005012 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxVertexAttribute);
Jamie Madillbe849e42017-05-02 15:49:00 -04005013 return false;
5014 }
5015
5016 if (pointer)
5017 {
5018 if (pname != GL_VERTEX_ATTRIB_ARRAY_POINTER)
5019 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005020 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005021 return false;
5022 }
5023 }
5024 else
5025 {
5026 switch (pname)
5027 {
5028 case GL_VERTEX_ATTRIB_ARRAY_ENABLED:
5029 case GL_VERTEX_ATTRIB_ARRAY_SIZE:
5030 case GL_VERTEX_ATTRIB_ARRAY_STRIDE:
5031 case GL_VERTEX_ATTRIB_ARRAY_TYPE:
5032 case GL_VERTEX_ATTRIB_ARRAY_NORMALIZED:
5033 case GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING:
5034 case GL_CURRENT_VERTEX_ATTRIB:
5035 break;
5036
5037 case GL_VERTEX_ATTRIB_ARRAY_DIVISOR:
5038 static_assert(
5039 GL_VERTEX_ATTRIB_ARRAY_DIVISOR == GL_VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE,
5040 "ANGLE extension enums not equal to GL enums.");
5041 if (context->getClientMajorVersion() < 3 &&
5042 !context->getExtensions().instancedArrays)
5043 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005044 context->handleError(InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_DIVISOR "
5045 "requires OpenGL ES 3.0 or "
5046 "GL_ANGLE_instanced_arrays.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005047 return false;
5048 }
5049 break;
5050
5051 case GL_VERTEX_ATTRIB_ARRAY_INTEGER:
5052 if (context->getClientMajorVersion() < 3)
5053 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005054 context->handleError(
5055 InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_INTEGER requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005056 return false;
5057 }
5058 break;
5059
5060 case GL_VERTEX_ATTRIB_BINDING:
5061 case GL_VERTEX_ATTRIB_RELATIVE_OFFSET:
5062 if (context->getClientVersion() < ES_3_1)
5063 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005064 context->handleError(InvalidEnum()
5065 << "Vertex Attrib Bindings require OpenGL ES 3.1.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005066 return false;
5067 }
5068 break;
5069
5070 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005071 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005072 return false;
5073 }
5074 }
5075
5076 if (length)
5077 {
5078 if (pname == GL_CURRENT_VERTEX_ATTRIB)
5079 {
5080 *length = 4;
5081 }
5082 else
5083 {
5084 *length = 1;
5085 }
5086 }
5087
5088 return true;
5089}
5090
Jamie Madill4928b7c2017-06-20 12:57:39 -04005091bool ValidateReadPixelsBase(Context *context,
Jamie Madillbe849e42017-05-02 15:49:00 -04005092 GLint x,
5093 GLint y,
5094 GLsizei width,
5095 GLsizei height,
5096 GLenum format,
5097 GLenum type,
5098 GLsizei bufSize,
5099 GLsizei *length,
5100 GLsizei *columns,
5101 GLsizei *rows,
5102 void *pixels)
5103{
5104 if (length != nullptr)
5105 {
5106 *length = 0;
5107 }
5108 if (rows != nullptr)
5109 {
5110 *rows = 0;
5111 }
5112 if (columns != nullptr)
5113 {
5114 *columns = 0;
5115 }
5116
5117 if (width < 0 || height < 0)
5118 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005119 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005120 return false;
5121 }
5122
5123 auto readFramebuffer = context->getGLState().getReadFramebuffer();
5124
5125 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
5126 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005127 context->handleError(InvalidFramebufferOperation());
Jamie Madillbe849e42017-05-02 15:49:00 -04005128 return false;
5129 }
5130
5131 if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0)
5132 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005133 context->handleError(InvalidOperation());
Jamie Madillbe849e42017-05-02 15:49:00 -04005134 return false;
5135 }
5136
5137 const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer();
5138 ASSERT(framebuffer);
5139
5140 if (framebuffer->getReadBufferState() == GL_NONE)
5141 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005142 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ReadBufferNone);
Jamie Madillbe849e42017-05-02 15:49:00 -04005143 return false;
5144 }
5145
5146 const FramebufferAttachment *readBuffer = framebuffer->getReadColorbuffer();
5147 // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment
5148 // In OpenGL ES it is undefined what happens when an operation tries to read from a missing
5149 // attachment and WebGL defines it to be an error. We do the check unconditionnaly as the
5150 // situation is an application error that would lead to a crash in ANGLE.
5151 if (readBuffer == nullptr)
5152 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005153 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment);
Jamie Madillbe849e42017-05-02 15:49:00 -04005154 return false;
5155 }
5156
Martin Radev28031682017-07-28 14:47:56 +03005157 // ANGLE_multiview, Revision 1:
5158 // ReadPixels generates an INVALID_FRAMEBUFFER_OPERATION error if the multi-view layout of the
5159 // current read framebuffer is not NONE.
5160 if (readBuffer->getMultiviewLayout() != GL_NONE)
5161 {
5162 context->handleError(InvalidFramebufferOperation()
5163 << "Attempting to read from a multi-view framebuffer.");
5164 return false;
5165 }
5166
Geoff Lang280ba992017-04-18 16:30:58 -04005167 if (context->getExtensions().webglCompatibility)
5168 {
5169 // The ES 2.0 spec states that the format must be "among those defined in table 3.4,
5170 // excluding formats LUMINANCE and LUMINANCE_ALPHA.". This requires validating the format
5171 // and type before validating the combination of format and type. However, the
5172 // dEQP-GLES3.functional.negative_api.buffer.read_pixels passes GL_LUMINANCE as a format and
5173 // verifies that GL_INVALID_OPERATION is generated.
5174 // TODO(geofflang): Update this check to be done in all/no cases once this is resolved in
5175 // dEQP/WebGL.
5176 if (!ValidReadPixelsFormatEnum(context, format))
5177 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005178 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFormat);
Geoff Lang280ba992017-04-18 16:30:58 -04005179 return false;
5180 }
5181
5182 if (!ValidReadPixelsTypeEnum(context, type))
5183 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005184 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidType);
Geoff Lang280ba992017-04-18 16:30:58 -04005185 return false;
5186 }
5187 }
5188
Jamie Madill4928b7c2017-06-20 12:57:39 -04005189 GLenum currentFormat = framebuffer->getImplementationColorReadFormat(context);
5190 GLenum currentType = framebuffer->getImplementationColorReadType(context);
Jamie Madillbe849e42017-05-02 15:49:00 -04005191 GLenum currentComponentType = readBuffer->getFormat().info->componentType;
5192
5193 bool validFormatTypeCombination =
5194 ValidReadPixelsFormatType(context, currentComponentType, format, type);
5195
5196 if (!(currentFormat == format && currentType == type) && !validFormatTypeCombination)
5197 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005198 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MismatchedTypeAndFormat);
Jamie Madillbe849e42017-05-02 15:49:00 -04005199 return false;
5200 }
5201
5202 // Check for pixel pack buffer related API errors
5203 gl::Buffer *pixelPackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_PACK_BUFFER);
5204 if (pixelPackBuffer != nullptr && pixelPackBuffer->isMapped())
5205 {
5206 // ...the buffer object's data store is currently mapped.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005207 context->handleError(InvalidOperation() << "Pixel pack buffer is mapped.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005208 return false;
5209 }
5210
5211 // .. the data would be packed to the buffer object such that the memory writes required
5212 // would exceed the data store size.
5213 const InternalFormat &formatInfo = GetInternalFormatInfo(format, type);
5214 const gl::Extents size(width, height, 1);
5215 const auto &pack = context->getGLState().getPackState();
5216
5217 auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, pack, false);
5218 if (endByteOrErr.isError())
5219 {
5220 context->handleError(endByteOrErr.getError());
5221 return false;
5222 }
5223
5224 size_t endByte = endByteOrErr.getResult();
5225 if (bufSize >= 0)
5226 {
5227 if (pixelPackBuffer == nullptr && static_cast<size_t>(bufSize) < endByte)
5228 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005229 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005230 return false;
5231 }
5232 }
5233
5234 if (pixelPackBuffer != nullptr)
5235 {
5236 CheckedNumeric<size_t> checkedEndByte(endByte);
5237 CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels));
5238 checkedEndByte += checkedOffset;
5239
5240 if (checkedEndByte.ValueOrDie() > static_cast<size_t>(pixelPackBuffer->getSize()))
5241 {
5242 // Overflow past the end of the buffer
Brandon Jones6cad5662017-06-14 13:25:13 -07005243 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ParamOverflow);
Jamie Madillbe849e42017-05-02 15:49:00 -04005244 return false;
5245 }
5246 }
5247
5248 if (pixelPackBuffer == nullptr && length != nullptr)
5249 {
5250 if (endByte > static_cast<size_t>(std::numeric_limits<GLsizei>::max()))
5251 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005252 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Jamie Madillbe849e42017-05-02 15:49:00 -04005253 return false;
5254 }
5255
5256 *length = static_cast<GLsizei>(endByte);
5257 }
5258
5259 auto getClippedExtent = [](GLint start, GLsizei length, int bufferSize) {
5260 angle::CheckedNumeric<int> clippedExtent(length);
5261 if (start < 0)
5262 {
5263 // "subtract" the area that is less than 0
5264 clippedExtent += start;
5265 }
5266
5267 const int readExtent = start + length;
5268 if (readExtent > bufferSize)
5269 {
5270 // Subtract the region to the right of the read buffer
5271 clippedExtent -= (readExtent - bufferSize);
5272 }
5273
5274 if (!clippedExtent.IsValid())
5275 {
5276 return 0;
5277 }
5278
5279 return std::max(clippedExtent.ValueOrDie(), 0);
5280 };
5281
5282 if (columns != nullptr)
5283 {
5284 *columns = getClippedExtent(x, width, readBuffer->getSize().width);
5285 }
5286
5287 if (rows != nullptr)
5288 {
5289 *rows = getClippedExtent(y, height, readBuffer->getSize().height);
5290 }
5291
5292 return true;
5293}
5294
5295template <typename ParamType>
5296bool ValidateTexParameterBase(Context *context,
5297 GLenum target,
5298 GLenum pname,
5299 GLsizei bufSize,
5300 const ParamType *params)
5301{
5302 if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
5303 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005304 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005305 return false;
5306 }
5307
5308 if (context->getTargetTexture(target) == nullptr)
5309 {
5310 // Should only be possible for external textures
Brandon Jones6cad5662017-06-14 13:25:13 -07005311 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005312 return false;
5313 }
5314
5315 const GLsizei minBufSize = 1;
5316 if (bufSize >= 0 && bufSize < minBufSize)
5317 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005318 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005319 return false;
5320 }
5321
5322 switch (pname)
5323 {
5324 case GL_TEXTURE_WRAP_R:
5325 case GL_TEXTURE_SWIZZLE_R:
5326 case GL_TEXTURE_SWIZZLE_G:
5327 case GL_TEXTURE_SWIZZLE_B:
5328 case GL_TEXTURE_SWIZZLE_A:
5329 case GL_TEXTURE_BASE_LEVEL:
5330 case GL_TEXTURE_MAX_LEVEL:
5331 case GL_TEXTURE_COMPARE_MODE:
5332 case GL_TEXTURE_COMPARE_FUNC:
5333 case GL_TEXTURE_MIN_LOD:
5334 case GL_TEXTURE_MAX_LOD:
5335 if (context->getClientMajorVersion() < 3)
5336 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005337 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ES3Required);
Jamie Madillbe849e42017-05-02 15:49:00 -04005338 return false;
5339 }
5340 if (target == GL_TEXTURE_EXTERNAL_OES &&
5341 !context->getExtensions().eglImageExternalEssl3)
5342 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005343 context->handleError(InvalidEnum() << "ES3 texture parameters are not "
5344 "available without "
5345 "GL_OES_EGL_image_external_essl3.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005346 return false;
5347 }
5348 break;
5349
5350 default:
5351 break;
5352 }
5353
JiangYizhou4cff8d62017-07-06 14:54:09 +08005354 if (target == GL_TEXTURE_2D_MULTISAMPLE)
5355 {
5356 switch (pname)
5357 {
5358 case GL_TEXTURE_MIN_FILTER:
5359 case GL_TEXTURE_MAG_FILTER:
5360 case GL_TEXTURE_WRAP_S:
5361 case GL_TEXTURE_WRAP_T:
5362 case GL_TEXTURE_WRAP_R:
5363 case GL_TEXTURE_MIN_LOD:
5364 case GL_TEXTURE_MAX_LOD:
5365 case GL_TEXTURE_COMPARE_MODE:
5366 case GL_TEXTURE_COMPARE_FUNC:
5367 context->handleError(InvalidEnum()
5368 << "Invalid parameter for 2D multisampled textures.");
5369 return false;
5370 }
5371 }
5372
Jamie Madillbe849e42017-05-02 15:49:00 -04005373 switch (pname)
5374 {
5375 case GL_TEXTURE_WRAP_S:
5376 case GL_TEXTURE_WRAP_T:
5377 case GL_TEXTURE_WRAP_R:
Jamie Madillbe849e42017-05-02 15:49:00 -04005378 {
Corentin Wallez13c0dd42017-07-04 18:27:01 -04005379 bool restrictedWrapModes =
5380 target == GL_TEXTURE_EXTERNAL_OES || target == GL_TEXTURE_RECTANGLE_ANGLE;
5381 if (!ValidateTextureWrapModeValue(context, params, restrictedWrapModes))
5382 {
5383 return false;
5384 }
Jamie Madillbe849e42017-05-02 15:49:00 -04005385 }
5386 break;
5387
5388 case GL_TEXTURE_MIN_FILTER:
Jamie Madillbe849e42017-05-02 15:49:00 -04005389 {
Corentin Wallez13c0dd42017-07-04 18:27:01 -04005390 bool restrictedMinFilter =
5391 target == GL_TEXTURE_EXTERNAL_OES || target == GL_TEXTURE_RECTANGLE_ANGLE;
5392 if (!ValidateTextureMinFilterValue(context, params, restrictedMinFilter))
5393 {
5394 return false;
5395 }
Jamie Madillbe849e42017-05-02 15:49:00 -04005396 }
5397 break;
5398
5399 case GL_TEXTURE_MAG_FILTER:
5400 if (!ValidateTextureMagFilterValue(context, params))
5401 {
5402 return false;
5403 }
5404 break;
5405
5406 case GL_TEXTURE_USAGE_ANGLE:
Geoff Lang91ab54b2017-10-30 15:12:42 -04005407 if (!context->getExtensions().textureUsage)
5408 {
5409 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
5410 return false;
5411 }
5412
Jamie Madillbe849e42017-05-02 15:49:00 -04005413 switch (ConvertToGLenum(params[0]))
5414 {
5415 case GL_NONE:
5416 case GL_FRAMEBUFFER_ATTACHMENT_ANGLE:
5417 break;
5418
5419 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005420 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005421 return false;
5422 }
5423 break;
5424
5425 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
5426 if (!context->getExtensions().textureFilterAnisotropic)
5427 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005428 context->handleError(InvalidEnum() << "GL_EXT_texture_anisotropic is not enabled.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005429 return false;
5430 }
5431
5432 // we assume the parameter passed to this validation method is truncated, not rounded
5433 if (params[0] < 1)
5434 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005435 context->handleError(InvalidValue() << "Max anisotropy must be at least 1.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005436 return false;
5437 }
5438 break;
5439
5440 case GL_TEXTURE_MIN_LOD:
5441 case GL_TEXTURE_MAX_LOD:
5442 // any value is permissible
5443 break;
5444
5445 case GL_TEXTURE_COMPARE_MODE:
5446 if (!ValidateTextureCompareModeValue(context, params))
5447 {
5448 return false;
5449 }
5450 break;
5451
5452 case GL_TEXTURE_COMPARE_FUNC:
5453 if (!ValidateTextureCompareFuncValue(context, params))
5454 {
5455 return false;
5456 }
5457 break;
5458
5459 case GL_TEXTURE_SWIZZLE_R:
5460 case GL_TEXTURE_SWIZZLE_G:
5461 case GL_TEXTURE_SWIZZLE_B:
5462 case GL_TEXTURE_SWIZZLE_A:
5463 switch (ConvertToGLenum(params[0]))
5464 {
5465 case GL_RED:
5466 case GL_GREEN:
5467 case GL_BLUE:
5468 case GL_ALPHA:
5469 case GL_ZERO:
5470 case GL_ONE:
5471 break;
5472
5473 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005474 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005475 return false;
5476 }
5477 break;
5478
5479 case GL_TEXTURE_BASE_LEVEL:
5480 if (params[0] < 0)
5481 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005482 context->handleError(InvalidValue() << "Base level must be at least 0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005483 return false;
5484 }
5485 if (target == GL_TEXTURE_EXTERNAL_OES && static_cast<GLuint>(params[0]) != 0)
5486 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005487 context->handleError(InvalidOperation()
5488 << "Base level must be 0 for external textures.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005489 return false;
5490 }
JiangYizhou4cff8d62017-07-06 14:54:09 +08005491 if (target == GL_TEXTURE_2D_MULTISAMPLE && static_cast<GLuint>(params[0]) != 0)
5492 {
5493 context->handleError(InvalidOperation()
5494 << "Base level must be 0 for multisampled textures.");
5495 return false;
5496 }
Corentin Wallez13c0dd42017-07-04 18:27:01 -04005497 if (target == GL_TEXTURE_RECTANGLE_ANGLE && static_cast<GLuint>(params[0]) != 0)
5498 {
5499 context->handleError(InvalidOperation()
5500 << "Base level must be 0 for rectangle textures.");
5501 return false;
5502 }
Jamie Madillbe849e42017-05-02 15:49:00 -04005503 break;
5504
5505 case GL_TEXTURE_MAX_LEVEL:
5506 if (params[0] < 0)
5507 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005508 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Jamie Madillbe849e42017-05-02 15:49:00 -04005509 return false;
5510 }
5511 break;
5512
5513 case GL_DEPTH_STENCIL_TEXTURE_MODE:
5514 if (context->getClientVersion() < Version(3, 1))
5515 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005516 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumRequiresGLES31);
Jamie Madillbe849e42017-05-02 15:49:00 -04005517 return false;
5518 }
5519 switch (ConvertToGLenum(params[0]))
5520 {
5521 case GL_DEPTH_COMPONENT:
5522 case GL_STENCIL_INDEX:
5523 break;
5524
5525 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005526 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005527 return false;
5528 }
5529 break;
5530
5531 case GL_TEXTURE_SRGB_DECODE_EXT:
5532 if (!ValidateTextureSRGBDecodeValue(context, params))
5533 {
5534 return false;
5535 }
5536 break;
5537
5538 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005539 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005540 return false;
5541 }
5542
5543 return true;
5544}
5545
5546template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLfloat *);
5547template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLint *);
5548
Jamie Madill12e957f2017-08-26 21:42:26 -04005549bool ValidateVertexAttribIndex(ValidationContext *context, GLuint index)
5550{
5551 if (index >= MAX_VERTEX_ATTRIBS)
5552 {
5553 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxVertexAttribute);
5554 return false;
5555 }
5556
5557 return true;
5558}
5559
5560bool ValidateGetActiveUniformBlockivBase(Context *context,
5561 GLuint program,
5562 GLuint uniformBlockIndex,
5563 GLenum pname,
5564 GLsizei *length)
5565{
5566 if (length)
5567 {
5568 *length = 0;
5569 }
5570
5571 if (context->getClientMajorVersion() < 3)
5572 {
5573 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required);
5574 return false;
5575 }
5576
5577 Program *programObject = GetValidProgram(context, program);
5578 if (!programObject)
5579 {
5580 return false;
5581 }
5582
5583 if (uniformBlockIndex >= programObject->getActiveUniformBlockCount())
5584 {
5585 context->handleError(InvalidValue()
5586 << "uniformBlockIndex exceeds active uniform block count.");
5587 return false;
5588 }
5589
5590 switch (pname)
5591 {
5592 case GL_UNIFORM_BLOCK_BINDING:
5593 case GL_UNIFORM_BLOCK_DATA_SIZE:
5594 case GL_UNIFORM_BLOCK_NAME_LENGTH:
5595 case GL_UNIFORM_BLOCK_ACTIVE_UNIFORMS:
5596 case GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES:
5597 case GL_UNIFORM_BLOCK_REFERENCED_BY_VERTEX_SHADER:
5598 case GL_UNIFORM_BLOCK_REFERENCED_BY_FRAGMENT_SHADER:
5599 break;
5600
5601 default:
5602 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
5603 return false;
5604 }
5605
5606 if (length)
5607 {
5608 if (pname == GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES)
5609 {
Jiajia Qin729b2c62017-08-14 09:36:11 +08005610 const InterfaceBlock &uniformBlock =
Jamie Madill12e957f2017-08-26 21:42:26 -04005611 programObject->getUniformBlockByIndex(uniformBlockIndex);
5612 *length = static_cast<GLsizei>(uniformBlock.memberIndexes.size());
5613 }
5614 else
5615 {
5616 *length = 1;
5617 }
5618 }
5619
5620 return true;
5621}
5622
Jamie Madill9696d072017-08-26 23:19:57 -04005623template <typename ParamType>
5624bool ValidateSamplerParameterBase(Context *context,
5625 GLuint sampler,
5626 GLenum pname,
5627 GLsizei bufSize,
5628 ParamType *params)
5629{
5630 if (context->getClientMajorVersion() < 3)
5631 {
5632 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required);
5633 return false;
5634 }
5635
5636 if (!context->isSampler(sampler))
5637 {
5638 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidSampler);
5639 return false;
5640 }
5641
5642 const GLsizei minBufSize = 1;
5643 if (bufSize >= 0 && bufSize < minBufSize)
5644 {
5645 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
5646 return false;
5647 }
5648
5649 switch (pname)
5650 {
5651 case GL_TEXTURE_WRAP_S:
5652 case GL_TEXTURE_WRAP_T:
5653 case GL_TEXTURE_WRAP_R:
5654 if (!ValidateTextureWrapModeValue(context, params, false))
5655 {
5656 return false;
5657 }
5658 break;
5659
5660 case GL_TEXTURE_MIN_FILTER:
5661 if (!ValidateTextureMinFilterValue(context, params, false))
5662 {
5663 return false;
5664 }
5665 break;
5666
5667 case GL_TEXTURE_MAG_FILTER:
5668 if (!ValidateTextureMagFilterValue(context, params))
5669 {
5670 return false;
5671 }
5672 break;
5673
5674 case GL_TEXTURE_MIN_LOD:
5675 case GL_TEXTURE_MAX_LOD:
5676 // any value is permissible
5677 break;
5678
5679 case GL_TEXTURE_COMPARE_MODE:
5680 if (!ValidateTextureCompareModeValue(context, params))
5681 {
5682 return false;
5683 }
5684 break;
5685
5686 case GL_TEXTURE_COMPARE_FUNC:
5687 if (!ValidateTextureCompareFuncValue(context, params))
5688 {
5689 return false;
5690 }
5691 break;
5692
5693 case GL_TEXTURE_SRGB_DECODE_EXT:
5694 if (!ValidateTextureSRGBDecodeValue(context, params))
5695 {
5696 return false;
5697 }
5698 break;
5699
5700 default:
5701 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
5702 return false;
5703 }
5704
5705 return true;
5706}
5707
5708template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, GLfloat *);
5709template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, GLint *);
5710
5711bool ValidateGetSamplerParameterBase(Context *context,
5712 GLuint sampler,
5713 GLenum pname,
5714 GLsizei *length)
5715{
5716 if (length)
5717 {
5718 *length = 0;
5719 }
5720
5721 if (context->getClientMajorVersion() < 3)
5722 {
5723 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required);
5724 return false;
5725 }
5726
5727 if (!context->isSampler(sampler))
5728 {
5729 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidSampler);
5730 return false;
5731 }
5732
5733 switch (pname)
5734 {
5735 case GL_TEXTURE_WRAP_S:
5736 case GL_TEXTURE_WRAP_T:
5737 case GL_TEXTURE_WRAP_R:
5738 case GL_TEXTURE_MIN_FILTER:
5739 case GL_TEXTURE_MAG_FILTER:
5740 case GL_TEXTURE_MIN_LOD:
5741 case GL_TEXTURE_MAX_LOD:
5742 case GL_TEXTURE_COMPARE_MODE:
5743 case GL_TEXTURE_COMPARE_FUNC:
5744 break;
5745
5746 case GL_TEXTURE_SRGB_DECODE_EXT:
5747 if (!context->getExtensions().textureSRGBDecode)
5748 {
5749 context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled.");
5750 return false;
5751 }
5752 break;
5753
5754 default:
5755 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
5756 return false;
5757 }
5758
5759 if (length)
5760 {
5761 *length = 1;
5762 }
5763 return true;
5764}
5765
5766bool ValidateGetInternalFormativBase(Context *context,
5767 GLenum target,
5768 GLenum internalformat,
5769 GLenum pname,
5770 GLsizei bufSize,
5771 GLsizei *numParams)
5772{
5773 if (numParams)
5774 {
5775 *numParams = 0;
5776 }
5777
5778 if (context->getClientMajorVersion() < 3)
5779 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08005780 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required);
Jamie Madill9696d072017-08-26 23:19:57 -04005781 return false;
5782 }
5783
5784 const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat);
5785 if (!formatCaps.renderable)
5786 {
5787 context->handleError(InvalidEnum() << "Internal format is not renderable.");
5788 return false;
5789 }
5790
5791 switch (target)
5792 {
5793 case GL_RENDERBUFFER:
5794 break;
5795
5796 case GL_TEXTURE_2D_MULTISAMPLE:
5797 if (context->getClientVersion() < ES_3_1)
5798 {
5799 context->handleError(InvalidOperation()
5800 << "Texture target requires at least OpenGL ES 3.1.");
5801 return false;
5802 }
5803 break;
5804
5805 default:
5806 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTarget);
5807 return false;
5808 }
5809
5810 if (bufSize < 0)
5811 {
5812 ANGLE_VALIDATION_ERR(context, InvalidValue(), InsufficientBufferSize);
5813 return false;
5814 }
5815
5816 GLsizei maxWriteParams = 0;
5817 switch (pname)
5818 {
5819 case GL_NUM_SAMPLE_COUNTS:
5820 maxWriteParams = 1;
5821 break;
5822
5823 case GL_SAMPLES:
5824 maxWriteParams = static_cast<GLsizei>(formatCaps.sampleCounts.size());
5825 break;
5826
5827 default:
5828 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
5829 return false;
5830 }
5831
5832 if (numParams)
5833 {
5834 // glGetInternalFormativ will not overflow bufSize
5835 *numParams = std::min(bufSize, maxWriteParams);
5836 }
5837
5838 return true;
5839}
5840
Jamie Madillc29968b2016-01-20 11:17:23 -05005841} // namespace gl