blob: 4a19e9abc663d887851b40a06ec423f6f860c167 [file] [log] [blame]
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001//
Geoff Langcec35902014-04-16 10:52:36 -04002// Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved.
Geoff Lange8ebe7f2013-08-05 15:03:13 -04003// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6
7// validationES.h: Validation functions for generic OpenGL ES entry point parameters
8
Geoff Lang2b5420c2014-11-19 14:20:15 -05009#include "libANGLE/validationES.h"
Jamie Madille2e406c2016-06-02 13:04:10 -040010
Geoff Lang2b5420c2014-11-19 14:20:15 -050011#include "libANGLE/Context.h"
Geoff Langa8406172015-07-21 16:53:39 -040012#include "libANGLE/Display.h"
Brandon Jones6cad5662017-06-14 13:25:13 -070013#include "libANGLE/ErrorStrings.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050014#include "libANGLE/Framebuffer.h"
15#include "libANGLE/FramebufferAttachment.h"
Geoff Langa8406172015-07-21 16:53:39 -040016#include "libANGLE/Image.h"
Geoff Lang7dd2e102014-11-10 15:19:26 -050017#include "libANGLE/Program.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040018#include "libANGLE/Query.h"
19#include "libANGLE/Texture.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050020#include "libANGLE/TransformFeedback.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040021#include "libANGLE/Uniform.h"
Geoff Lang2b5420c2014-11-19 14:20:15 -050022#include "libANGLE/VertexArray.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040023#include "libANGLE/formatutils.h"
jchen10a99ed552017-09-22 08:10:32 +080024#include "libANGLE/queryconversions.h"
Jamie Madill231c7f52017-04-26 13:45:37 -040025#include "libANGLE/validationES2.h"
26#include "libANGLE/validationES3.h"
Geoff Lange8ebe7f2013-08-05 15:03:13 -040027
28#include "common/mathutil.h"
29#include "common/utilities.h"
30
Jamie Madille2e406c2016-06-02 13:04:10 -040031using namespace angle;
32
Geoff Lange8ebe7f2013-08-05 15:03:13 -040033namespace gl
34{
Jamie Madill1ca74672015-07-21 15:14:11 -040035namespace
36{
jchen10a99ed552017-09-22 08:10:32 +080037
Corentin Wallez92db6942016-12-09 13:10:36 -050038bool ValidateDrawAttribs(ValidationContext *context,
39 GLint primcount,
40 GLint maxVertex,
41 GLint vertexCount)
Jamie Madill1ca74672015-07-21 15:14:11 -040042{
Jamie Madilldfde6ab2016-06-09 07:07:18 -070043 const gl::State &state = context->getGLState();
Jamie Madill1ca74672015-07-21 15:14:11 -040044 const gl::Program *program = state.getProgram();
45
Corentin Wallez327411e2016-12-09 11:09:17 -050046 bool webglCompatibility = context->getExtensions().webglCompatibility;
47
Jamie Madill231c7f52017-04-26 13:45:37 -040048 const VertexArray *vao = state.getVertexArray();
49 const auto &vertexAttribs = vao->getVertexAttributes();
Jiawei-Shao2597fb62016-12-09 16:38:02 +080050 const auto &vertexBindings = vao->getVertexBindings();
Jamie Madill231c7f52017-04-26 13:45:37 -040051 size_t maxEnabledAttrib = vao->getMaxEnabledAttribute();
Jamie Madill1ca74672015-07-21 15:14:11 -040052 for (size_t attributeIndex = 0; attributeIndex < maxEnabledAttrib; ++attributeIndex)
53 {
54 const VertexAttribute &attrib = vertexAttribs[attributeIndex];
Corentin Wallez672f7f32017-06-15 17:42:17 -040055
56 // No need to range check for disabled attribs.
57 if (!attrib.enabled)
Jamie Madill1ca74672015-07-21 15:14:11 -040058 {
Corentin Wallezfd456442016-12-21 17:57:00 -050059 continue;
60 }
Jamie Madill1ca74672015-07-21 15:14:11 -040061
Jamie Madill231c7f52017-04-26 13:45:37 -040062 // If we have no buffer, then we either get an error, or there are no more checks to be
63 // done.
Corentin Wallez672f7f32017-06-15 17:42:17 -040064 const VertexBinding &binding = vertexBindings[attrib.bindingIndex];
65 gl::Buffer *buffer = binding.getBuffer().get();
Corentin Wallezfd456442016-12-21 17:57:00 -050066 if (!buffer)
67 {
Geoff Langfeb8c682017-02-13 16:07:35 -050068 if (webglCompatibility || !state.areClientArraysEnabled())
Corentin Wallez327411e2016-12-09 11:09:17 -050069 {
70 // [WebGL 1.0] Section 6.5 Enabled Vertex Attributes and Range Checking
Corentin Wallezfd456442016-12-21 17:57:00 -050071 // If a vertex attribute is enabled as an array via enableVertexAttribArray but
72 // no buffer is bound to that attribute via bindBuffer and vertexAttribPointer,
73 // then calls to drawArrays or drawElements will generate an INVALID_OPERATION
74 // error.
Brandon Jonesafa75152017-07-21 13:11:29 -070075 ANGLE_VALIDATION_ERR(context, InvalidOperation(), VertexArrayNoBuffer);
Corentin Wallezfd456442016-12-21 17:57:00 -050076 return false;
Corentin Wallez327411e2016-12-09 11:09:17 -050077 }
Corentin Wallezfd456442016-12-21 17:57:00 -050078 else if (attrib.pointer == nullptr)
Jamie Madill1ca74672015-07-21 15:14:11 -040079 {
80 // This is an application error that would normally result in a crash,
81 // but we catch it and return an error
Brandon Jonesafa75152017-07-21 13:11:29 -070082 ANGLE_VALIDATION_ERR(context, InvalidOperation(), VertexArrayNoBufferPointer);
Jamie Madill1ca74672015-07-21 15:14:11 -040083 return false;
84 }
Corentin Wallezfd456442016-12-21 17:57:00 -050085 continue;
86 }
87
Corentin Wallez672f7f32017-06-15 17:42:17 -040088 // This needs to come after the check for client arrays as even unused attributes cannot use
89 // client-side arrays
90 if (!program->isAttribLocationActive(attributeIndex))
91 {
92 continue;
93 }
94
Corentin Wallezfd456442016-12-21 17:57:00 -050095 // If we're drawing zero vertices, we have enough data.
96 if (vertexCount <= 0 || primcount <= 0)
97 {
98 continue;
99 }
100
101 GLint maxVertexElement = 0;
Martin Radevdd5f27e2017-06-07 10:17:09 +0300102 GLuint divisor = binding.getDivisor();
103 if (divisor == 0)
Corentin Wallezfd456442016-12-21 17:57:00 -0500104 {
105 maxVertexElement = maxVertex;
106 }
107 else
108 {
Martin Radevdd5f27e2017-06-07 10:17:09 +0300109 maxVertexElement = (primcount - 1) / divisor;
Corentin Wallezfd456442016-12-21 17:57:00 -0500110 }
111
112 // We do manual overflow checks here instead of using safe_math.h because it was
113 // a bottleneck. Thanks to some properties of GL we know inequalities that can
114 // help us make the overflow checks faster.
115
116 // The max possible attribSize is 16 for a vector of 4 32 bit values.
117 constexpr uint64_t kMaxAttribSize = 16;
118 constexpr uint64_t kIntMax = std::numeric_limits<int>::max();
119 constexpr uint64_t kUint64Max = std::numeric_limits<uint64_t>::max();
120
121 // We know attribStride is given as a GLsizei which is typedefed to int.
122 // We also know an upper bound for attribSize.
123 static_assert(std::is_same<int, GLsizei>::value, "");
Jiawei-Shao2597fb62016-12-09 16:38:02 +0800124 uint64_t attribStride = ComputeVertexAttributeStride(attrib, binding);
Corentin Wallezfd456442016-12-21 17:57:00 -0500125 uint64_t attribSize = ComputeVertexAttributeTypeSize(attrib);
126 ASSERT(attribStride <= kIntMax && attribSize <= kMaxAttribSize);
127
128 // Computing the max offset using uint64_t without attrib.offset is overflow
129 // safe. Note: Last vertex element does not take the full stride!
130 static_assert(kIntMax * kIntMax < kUint64Max - kMaxAttribSize, "");
131 uint64_t attribDataSizeNoOffset = maxVertexElement * attribStride + attribSize;
132
133 // An overflow can happen when adding the offset, check for it.
Jiawei-Shao2597fb62016-12-09 16:38:02 +0800134 uint64_t attribOffset = ComputeVertexAttributeOffset(attrib, binding);
135 if (attribDataSizeNoOffset > kUint64Max - attribOffset)
Corentin Wallezfd456442016-12-21 17:57:00 -0500136 {
Brandon Jonesafa75152017-07-21 13:11:29 -0700137 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallezfd456442016-12-21 17:57:00 -0500138 return false;
139 }
140 uint64_t attribDataSizeWithOffset = attribDataSizeNoOffset + attribOffset;
141
142 // [OpenGL ES 3.0.2] section 2.9.4 page 40:
143 // We can return INVALID_OPERATION if our vertex attribute does not have
144 // enough backing data.
145 if (attribDataSizeWithOffset > static_cast<uint64_t>(buffer->getSize()))
146 {
Brandon Jonesafa75152017-07-21 13:11:29 -0700147 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientVertexBufferSize);
Corentin Wallezfd456442016-12-21 17:57:00 -0500148 return false;
Jamie Madill1ca74672015-07-21 15:14:11 -0400149 }
150 }
151
152 return true;
153}
154
Geoff Lang280ba992017-04-18 16:30:58 -0400155bool ValidReadPixelsTypeEnum(ValidationContext *context, GLenum type)
156{
157 switch (type)
158 {
159 // Types referenced in Table 3.4 of the ES 2.0.25 spec
160 case GL_UNSIGNED_BYTE:
161 case GL_UNSIGNED_SHORT_4_4_4_4:
162 case GL_UNSIGNED_SHORT_5_5_5_1:
163 case GL_UNSIGNED_SHORT_5_6_5:
164 return context->getClientVersion() >= ES_2_0;
165
166 // Types referenced in Table 3.2 of the ES 3.0.5 spec (Except depth stencil)
167 case GL_BYTE:
168 case GL_INT:
169 case GL_SHORT:
170 case GL_UNSIGNED_INT:
171 case GL_UNSIGNED_INT_10F_11F_11F_REV:
172 case GL_UNSIGNED_INT_24_8:
173 case GL_UNSIGNED_INT_2_10_10_10_REV:
174 case GL_UNSIGNED_INT_5_9_9_9_REV:
175 case GL_UNSIGNED_SHORT:
176 case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT:
177 case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT:
178 return context->getClientVersion() >= ES_3_0;
179
180 case GL_FLOAT:
Geoff Lang7d4602f2017-09-13 10:45:09 -0400181 return context->getClientVersion() >= ES_3_0 || context->getExtensions().textureFloat ||
182 context->getExtensions().colorBufferHalfFloat;
Geoff Lang280ba992017-04-18 16:30:58 -0400183
184 case GL_HALF_FLOAT:
185 return context->getClientVersion() >= ES_3_0 ||
186 context->getExtensions().textureHalfFloat;
187
188 case GL_HALF_FLOAT_OES:
189 return context->getExtensions().colorBufferHalfFloat;
190
191 default:
192 return false;
193 }
194}
195
196bool ValidReadPixelsFormatEnum(ValidationContext *context, GLenum format)
197{
198 switch (format)
199 {
200 // Formats referenced in Table 3.4 of the ES 2.0.25 spec (Except luminance)
201 case GL_RGBA:
202 case GL_RGB:
203 case GL_ALPHA:
204 return context->getClientVersion() >= ES_2_0;
205
206 // Formats referenced in Table 3.2 of the ES 3.0.5 spec
207 case GL_RG:
208 case GL_RED:
209 case GL_RGBA_INTEGER:
210 case GL_RGB_INTEGER:
211 case GL_RG_INTEGER:
212 case GL_RED_INTEGER:
213 return context->getClientVersion() >= ES_3_0;
214
215 case GL_SRGB_ALPHA_EXT:
216 case GL_SRGB_EXT:
217 return context->getExtensions().sRGB;
218
219 case GL_BGRA_EXT:
220 return context->getExtensions().readFormatBGRA;
221
222 default:
223 return false;
224 }
225}
226
Geoff Langf607c602016-09-21 11:46:48 -0400227bool ValidReadPixelsFormatType(ValidationContext *context,
228 GLenum framebufferComponentType,
229 GLenum format,
230 GLenum type)
231{
232 switch (framebufferComponentType)
233 {
234 case GL_UNSIGNED_NORMALIZED:
235 // TODO(geofflang): Don't accept BGRA here. Some chrome internals appear to try to use
236 // ReadPixels with BGRA even if the extension is not present
237 return (format == GL_RGBA && type == GL_UNSIGNED_BYTE) ||
238 (context->getExtensions().readFormatBGRA && format == GL_BGRA_EXT &&
239 type == GL_UNSIGNED_BYTE);
240
241 case GL_SIGNED_NORMALIZED:
242 return (format == GL_RGBA && type == GL_UNSIGNED_BYTE);
243
244 case GL_INT:
245 return (format == GL_RGBA_INTEGER && type == GL_INT);
246
247 case GL_UNSIGNED_INT:
248 return (format == GL_RGBA_INTEGER && type == GL_UNSIGNED_INT);
249
250 case GL_FLOAT:
251 return (format == GL_RGBA && type == GL_FLOAT);
252
253 default:
254 UNREACHABLE();
255 return false;
256 }
257}
258
Geoff Langc1984ed2016-10-07 12:41:00 -0400259template <typename ParamType>
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400260bool ValidateTextureWrapModeValue(Context *context, ParamType *params, bool restrictedWrapModes)
Geoff Langc1984ed2016-10-07 12:41:00 -0400261{
262 switch (ConvertToGLenum(params[0]))
263 {
264 case GL_CLAMP_TO_EDGE:
265 break;
266
267 case GL_REPEAT:
268 case GL_MIRRORED_REPEAT:
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400269 if (restrictedWrapModes)
Geoff Langc1984ed2016-10-07 12:41:00 -0400270 {
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400271 // OES_EGL_image_external and ANGLE_texture_rectangle specifies this error.
Brandon Jonesafa75152017-07-21 13:11:29 -0700272 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidWrapModeTexture);
Geoff Langc1984ed2016-10-07 12:41:00 -0400273 return false;
274 }
275 break;
276
277 default:
Brandon Jonesafa75152017-07-21 13:11:29 -0700278 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureWrap);
Geoff Langc1984ed2016-10-07 12:41:00 -0400279 return false;
280 }
281
282 return true;
283}
284
285template <typename ParamType>
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400286bool ValidateTextureMinFilterValue(Context *context, ParamType *params, bool restrictedMinFilter)
Geoff Langc1984ed2016-10-07 12:41:00 -0400287{
288 switch (ConvertToGLenum(params[0]))
289 {
290 case GL_NEAREST:
291 case GL_LINEAR:
292 break;
293
294 case GL_NEAREST_MIPMAP_NEAREST:
295 case GL_LINEAR_MIPMAP_NEAREST:
296 case GL_NEAREST_MIPMAP_LINEAR:
297 case GL_LINEAR_MIPMAP_LINEAR:
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400298 if (restrictedMinFilter)
Geoff Langc1984ed2016-10-07 12:41:00 -0400299 {
300 // OES_EGL_image_external specifies this error.
Brandon Jonesafa75152017-07-21 13:11:29 -0700301 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFilterTexture);
Geoff Langc1984ed2016-10-07 12:41:00 -0400302 return false;
303 }
304 break;
305
306 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700307 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam);
Geoff Langc1984ed2016-10-07 12:41:00 -0400308 return false;
309 }
310
311 return true;
312}
313
314template <typename ParamType>
315bool ValidateTextureMagFilterValue(Context *context, ParamType *params)
316{
317 switch (ConvertToGLenum(params[0]))
318 {
319 case GL_NEAREST:
320 case GL_LINEAR:
321 break;
322
323 default:
Brandon Jones6cad5662017-06-14 13:25:13 -0700324 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureFilterParam);
Geoff Langc1984ed2016-10-07 12:41:00 -0400325 return false;
326 }
327
328 return true;
329}
330
331template <typename ParamType>
332bool ValidateTextureCompareModeValue(Context *context, ParamType *params)
333{
334 // Acceptable mode parameters from GLES 3.0.2 spec, table 3.17
335 switch (ConvertToGLenum(params[0]))
336 {
337 case GL_NONE:
338 case GL_COMPARE_REF_TO_TEXTURE:
339 break;
340
341 default:
Brandon Jonesafa75152017-07-21 13:11:29 -0700342 ANGLE_VALIDATION_ERR(context, InvalidEnum(), UnknownParameter);
Geoff Langc1984ed2016-10-07 12:41:00 -0400343 return false;
344 }
345
346 return true;
347}
348
349template <typename ParamType>
350bool ValidateTextureCompareFuncValue(Context *context, ParamType *params)
351{
352 // Acceptable function parameters from GLES 3.0.2 spec, table 3.17
353 switch (ConvertToGLenum(params[0]))
354 {
355 case GL_LEQUAL:
356 case GL_GEQUAL:
357 case GL_LESS:
358 case GL_GREATER:
359 case GL_EQUAL:
360 case GL_NOTEQUAL:
361 case GL_ALWAYS:
362 case GL_NEVER:
363 break;
364
365 default:
Brandon Jonesafa75152017-07-21 13:11:29 -0700366 ANGLE_VALIDATION_ERR(context, InvalidEnum(), UnknownParameter);
Geoff Langc1984ed2016-10-07 12:41:00 -0400367 return false;
368 }
369
370 return true;
371}
372
373template <typename ParamType>
Geoff Lang81c6b572016-10-19 14:07:52 -0700374bool ValidateTextureSRGBDecodeValue(Context *context, ParamType *params)
375{
376 if (!context->getExtensions().textureSRGBDecode)
377 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700378 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Geoff Lang81c6b572016-10-19 14:07:52 -0700379 return false;
380 }
381
382 switch (ConvertToGLenum(params[0]))
383 {
384 case GL_DECODE_EXT:
385 case GL_SKIP_DECODE_EXT:
386 break;
387
388 default:
Brandon Jonesafa75152017-07-21 13:11:29 -0700389 ANGLE_VALIDATION_ERR(context, InvalidEnum(), UnknownParameter);
Geoff Lang81c6b572016-10-19 14:07:52 -0700390 return false;
391 }
392
393 return true;
394}
395
Jamie Madillc1d770e2017-04-13 17:31:24 -0400396bool ValidateUniformCommonBase(ValidationContext *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500397 gl::Program *program,
398 GLint location,
399 GLsizei count,
400 const LinkedUniform **uniformOut)
401{
402 // TODO(Jiajia): Add image uniform check in future.
403 if (count < 0)
404 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700405 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500406 return false;
407 }
408
Brandon Jones6cad5662017-06-14 13:25:13 -0700409 if (!program)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500410 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700411 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidProgramName);
412 return false;
413 }
414
415 if (!program->isLinked())
416 {
417 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500418 return false;
419 }
420
421 if (location == -1)
422 {
423 // Silently ignore the uniform command
424 return false;
425 }
426
427 const auto &uniformLocations = program->getUniformLocations();
Jamie Madillbe849e42017-05-02 15:49:00 -0400428 size_t castedLocation = static_cast<size_t>(location);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500429 if (castedLocation >= uniformLocations.size())
430 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500431 context->handleError(InvalidOperation() << "Invalid uniform location");
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500432 return false;
433 }
434
435 const auto &uniformLocation = uniformLocations[castedLocation];
436 if (uniformLocation.ignored)
437 {
438 // Silently ignore the uniform command
439 return false;
440 }
441
Jamie Madillfb997ec2017-09-20 15:44:27 -0400442 if (!uniformLocation.used())
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500443 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500444 context->handleError(InvalidOperation());
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500445 return false;
446 }
447
448 const auto &uniform = program->getUniformByIndex(uniformLocation.index);
449
450 // attempting to write an array to a non-array uniform is an INVALID_OPERATION
451 if (!uniform.isArray() && count > 1)
452 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500453 context->handleError(InvalidOperation());
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500454 return false;
455 }
456
457 *uniformOut = &uniform;
458 return true;
459}
460
Frank Henigman999b0fd2017-02-02 21:45:55 -0500461bool ValidateUniform1ivValue(ValidationContext *context,
Frank Henigmana98a6472017-02-02 21:38:32 -0500462 GLenum uniformType,
463 GLsizei count,
464 const GLint *value)
465{
466 // Value type is GL_INT, because we only get here from glUniform1i{v}.
467 // It is compatible with INT or BOOL.
468 // Do these cheap tests first, for a little extra speed.
469 if (GL_INT == uniformType || GL_BOOL == uniformType)
470 {
471 return true;
472 }
473
474 if (IsSamplerType(uniformType))
475 {
Frank Henigman999b0fd2017-02-02 21:45:55 -0500476 // Check that the values are in range.
477 const GLint max = context->getCaps().maxCombinedTextureImageUnits;
478 for (GLsizei i = 0; i < count; ++i)
479 {
480 if (value[i] < 0 || value[i] >= max)
481 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500482 context->handleError(InvalidValue() << "sampler uniform value out of range");
Frank Henigman999b0fd2017-02-02 21:45:55 -0500483 return false;
484 }
485 }
Frank Henigmana98a6472017-02-02 21:38:32 -0500486 return true;
487 }
488
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500489 context->handleError(InvalidOperation() << "wrong type of value for uniform");
Frank Henigmana98a6472017-02-02 21:38:32 -0500490 return false;
491}
492
Jamie Madillc1d770e2017-04-13 17:31:24 -0400493bool ValidateUniformValue(ValidationContext *context, GLenum valueType, GLenum uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500494{
495 // Check that the value type is compatible with uniform type.
Frank Henigmana98a6472017-02-02 21:38:32 -0500496 // Do the cheaper test first, for a little extra speed.
497 if (valueType == uniformType || VariableBoolVectorType(valueType) == uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500498 {
499 return true;
500 }
501
Brandon Jonesafa75152017-07-21 13:11:29 -0700502 ANGLE_VALIDATION_ERR(context, InvalidOperation(), UniformSizeMismatch);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500503 return false;
504}
505
Jamie Madillc1d770e2017-04-13 17:31:24 -0400506bool ValidateUniformMatrixValue(ValidationContext *context, GLenum valueType, GLenum uniformType)
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500507{
508 // Check that the value type is compatible with uniform type.
509 if (valueType == uniformType)
510 {
511 return true;
512 }
513
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500514 context->handleError(InvalidOperation() << "wrong type of value for uniform");
Frank Henigmanf5f74ae2017-02-02 21:14:23 -0500515 return false;
516}
517
Geoff Lange0cff192017-05-30 13:04:56 -0400518bool ValidateFragmentShaderColorBufferTypeMatch(ValidationContext *context)
519{
520 const Program *program = context->getGLState().getProgram();
521 const Framebuffer *framebuffer = context->getGLState().getDrawFramebuffer();
522
523 const auto &programOutputTypes = program->getOutputVariableTypes();
524 for (size_t drawBufferIdx = 0; drawBufferIdx < programOutputTypes.size(); drawBufferIdx++)
525 {
526 GLenum outputType = programOutputTypes[drawBufferIdx];
527 GLenum inputType = framebuffer->getDrawbufferWriteType(drawBufferIdx);
528 if (outputType != GL_NONE && inputType != GL_NONE && inputType != outputType)
529 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500530 context->handleError(InvalidOperation() << "Fragment shader output type does not "
531 "match the bound framebuffer attachment "
532 "type.");
Geoff Lange0cff192017-05-30 13:04:56 -0400533 return false;
534 }
535 }
536
537 return true;
538}
539
Geoff Lang9ab5b822017-05-30 16:19:23 -0400540bool ValidateVertexShaderAttributeTypeMatch(ValidationContext *context)
541{
542 const Program *program = context->getGLState().getProgram();
543 const VertexArray *vao = context->getGLState().getVertexArray();
544
545 for (const auto &shaderAttribute : program->getAttributes())
546 {
Geoff Lang69df2422017-07-05 12:42:31 -0400547 // gl_VertexID and gl_InstanceID are active attributes but don't have a bound attribute.
548 if (shaderAttribute.isBuiltIn())
549 {
550 continue;
551 }
552
Geoff Lang9ab5b822017-05-30 16:19:23 -0400553 GLenum shaderInputType = VariableComponentType(shaderAttribute.type);
554
555 const auto &attrib = vao->getVertexAttribute(shaderAttribute.location);
556 const auto &currentValue =
557 context->getGLState().getVertexAttribCurrentValue(shaderAttribute.location);
558 GLenum vertexType = attrib.enabled ? GetVertexAttributeBaseType(attrib) : currentValue.Type;
559
560 if (shaderInputType != GL_NONE && vertexType != GL_NONE && shaderInputType != vertexType)
561 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -0500562 context->handleError(InvalidOperation() << "Vertex shader input type does not "
563 "match the type of the bound vertex "
564 "attribute.");
Geoff Lang9ab5b822017-05-30 16:19:23 -0400565 return false;
566 }
567 }
568
569 return true;
570}
571
Geoff Langf41a7152016-09-19 15:11:17 -0400572} // anonymous namespace
573
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500574bool ValidTextureTarget(const ValidationContext *context, GLenum target)
Jamie Madill35d15012013-10-07 10:46:37 -0400575{
Jamie Madilld7460c72014-01-21 16:38:14 -0500576 switch (target)
Jamie Madill35d15012013-10-07 10:46:37 -0400577 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800578 case GL_TEXTURE_2D:
579 case GL_TEXTURE_CUBE_MAP:
580 return true;
Jamie Madill35d15012013-10-07 10:46:37 -0400581
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400582 case GL_TEXTURE_RECTANGLE_ANGLE:
583 return context->getExtensions().textureRectangle;
584
He Yunchaoced53ae2016-11-29 15:00:51 +0800585 case GL_TEXTURE_3D:
586 case GL_TEXTURE_2D_ARRAY:
587 return (context->getClientMajorVersion() >= 3);
Jamie Madilld7460c72014-01-21 16:38:14 -0500588
He Yunchaoced53ae2016-11-29 15:00:51 +0800589 case GL_TEXTURE_2D_MULTISAMPLE:
He Yunchaoced53ae2016-11-29 15:00:51 +0800590 return (context->getClientVersion() >= Version(3, 1));
Geoff Lang3b573612016-10-31 14:08:10 -0400591
He Yunchaoced53ae2016-11-29 15:00:51 +0800592 default:
593 return false;
Jamie Madilld7460c72014-01-21 16:38:14 -0500594 }
Jamie Madill35d15012013-10-07 10:46:37 -0400595}
596
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500597bool ValidTexture2DTarget(const ValidationContext *context, GLenum target)
598{
599 switch (target)
600 {
601 case GL_TEXTURE_2D:
602 case GL_TEXTURE_CUBE_MAP:
603 return true;
604
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400605 case GL_TEXTURE_RECTANGLE_ANGLE:
606 return context->getExtensions().textureRectangle;
607
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500608 default:
609 return false;
610 }
611}
612
613bool ValidTexture3DTarget(const ValidationContext *context, GLenum target)
614{
615 switch (target)
616 {
617 case GL_TEXTURE_3D:
618 case GL_TEXTURE_2D_ARRAY:
Martin Radev1be913c2016-07-11 17:59:16 +0300619 return (context->getClientMajorVersion() >= 3);
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500620
621 default:
622 return false;
623 }
624}
625
Ian Ewellbda75592016-04-18 17:25:54 -0400626// Most texture GL calls are not compatible with external textures, so we have a separate validation
627// function for use in the GL calls that do
628bool ValidTextureExternalTarget(const ValidationContext *context, GLenum target)
629{
630 return (target == GL_TEXTURE_EXTERNAL_OES) &&
631 (context->getExtensions().eglImageExternal ||
632 context->getExtensions().eglStreamConsumerExternal);
633}
634
Shannon Woods4dfed832014-03-17 20:03:39 -0400635// This function differs from ValidTextureTarget in that the target must be
636// usable as the destination of a 2D operation-- so a cube face is valid, but
637// GL_TEXTURE_CUBE_MAP is not.
Jamie Madill560a8d82014-05-21 13:06:20 -0400638// Note: duplicate of IsInternalTextureTarget
Jamie Madillc29968b2016-01-20 11:17:23 -0500639bool ValidTexture2DDestinationTarget(const ValidationContext *context, GLenum target)
Shannon Woods4dfed832014-03-17 20:03:39 -0400640{
641 switch (target)
642 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800643 case GL_TEXTURE_2D:
644 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
645 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
646 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
647 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
648 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
649 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
650 return true;
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400651 case GL_TEXTURE_RECTANGLE_ANGLE:
652 return context->getExtensions().textureRectangle;
He Yunchaoced53ae2016-11-29 15:00:51 +0800653 default:
654 return false;
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500655 }
656}
657
Jamie Madillbe849e42017-05-02 15:49:00 -0400658bool ValidateDrawElementsInstancedBase(ValidationContext *context,
659 GLenum mode,
660 GLsizei count,
661 GLenum type,
662 const GLvoid *indices,
663 GLsizei primcount)
664{
665 if (primcount < 0)
666 {
Brandon Jonesafa75152017-07-21 13:11:29 -0700667 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativePrimcount);
Jamie Madillbe849e42017-05-02 15:49:00 -0400668 return false;
669 }
670
671 if (!ValidateDrawElementsCommon(context, mode, count, type, indices, primcount))
672 {
673 return false;
674 }
675
676 // No-op zero primitive count
677 return (primcount > 0);
678}
679
680bool ValidateDrawArraysInstancedBase(Context *context,
681 GLenum mode,
682 GLint first,
683 GLsizei count,
684 GLsizei primcount)
685{
686 if (primcount < 0)
687 {
Brandon Jonesafa75152017-07-21 13:11:29 -0700688 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativePrimcount);
Jamie Madillbe849e42017-05-02 15:49:00 -0400689 return false;
690 }
691
692 if (!ValidateDrawArraysCommon(context, mode, first, count, primcount))
693 {
694 return false;
695 }
696
697 // No-op if zero primitive count
698 return (primcount > 0);
699}
700
Corentin Wallez0dc97812017-06-22 14:38:44 -0400701bool ValidateDrawInstancedANGLE(ValidationContext *context)
Jamie Madillbe849e42017-05-02 15:49:00 -0400702{
703 // Verify there is at least one active attribute with a divisor of zero
704 const State &state = context->getGLState();
705
706 Program *program = state.getProgram();
707
708 const auto &attribs = state.getVertexArray()->getVertexAttributes();
709 const auto &bindings = state.getVertexArray()->getVertexBindings();
710 for (size_t attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++)
711 {
712 const VertexAttribute &attrib = attribs[attributeIndex];
713 const VertexBinding &binding = bindings[attrib.bindingIndex];
Martin Radevdd5f27e2017-06-07 10:17:09 +0300714 if (program->isAttribLocationActive(attributeIndex) && binding.getDivisor() == 0)
Jamie Madillbe849e42017-05-02 15:49:00 -0400715 {
716 return true;
717 }
718 }
719
Brandon Jonesafa75152017-07-21 13:11:29 -0700720 ANGLE_VALIDATION_ERR(context, InvalidOperation(), NoZeroDivisor);
Jamie Madillbe849e42017-05-02 15:49:00 -0400721 return false;
722}
723
Ian Ewellfc7cf8e2016-01-20 15:57:46 -0500724bool ValidTexture3DDestinationTarget(const ValidationContext *context, GLenum target)
725{
726 switch (target)
727 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800728 case GL_TEXTURE_3D:
729 case GL_TEXTURE_2D_ARRAY:
730 return true;
731 default:
732 return false;
Shannon Woods4dfed832014-03-17 20:03:39 -0400733 }
734}
735
He Yunchao11b038b2016-11-22 21:24:04 +0800736bool ValidTexLevelDestinationTarget(const ValidationContext *context, GLenum target)
737{
738 switch (target)
739 {
740 case GL_TEXTURE_2D:
741 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
742 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
743 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
744 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
745 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
746 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
747 case GL_TEXTURE_3D:
748 case GL_TEXTURE_2D_ARRAY:
749 case GL_TEXTURE_2D_MULTISAMPLE:
750 return true;
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400751 case GL_TEXTURE_RECTANGLE_ANGLE:
752 return context->getExtensions().textureRectangle;
He Yunchao11b038b2016-11-22 21:24:04 +0800753 default:
754 return false;
755 }
756}
757
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500758bool ValidFramebufferTarget(GLenum target)
759{
He Yunchaoced53ae2016-11-29 15:00:51 +0800760 static_assert(GL_DRAW_FRAMEBUFFER_ANGLE == GL_DRAW_FRAMEBUFFER &&
761 GL_READ_FRAMEBUFFER_ANGLE == GL_READ_FRAMEBUFFER,
Geoff Langd4475812015-03-18 10:53:05 -0400762 "ANGLE framebuffer enums must equal the ES3 framebuffer enums.");
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500763
764 switch (target)
765 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800766 case GL_FRAMEBUFFER:
767 return true;
768 case GL_READ_FRAMEBUFFER:
769 return true;
770 case GL_DRAW_FRAMEBUFFER:
771 return true;
772 default:
773 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -0500774 }
775}
776
Jamie Madill29639852016-09-02 15:00:09 -0400777bool ValidBufferTarget(const ValidationContext *context, GLenum target)
Jamie Madill8c96d582014-03-05 15:01:23 -0500778{
779 switch (target)
780 {
He Yunchaoced53ae2016-11-29 15:00:51 +0800781 case GL_ARRAY_BUFFER:
782 case GL_ELEMENT_ARRAY_BUFFER:
783 return true;
Jamie Madill8c96d582014-03-05 15:01:23 -0500784
He Yunchaoced53ae2016-11-29 15:00:51 +0800785 case GL_PIXEL_PACK_BUFFER:
786 case GL_PIXEL_UNPACK_BUFFER:
787 return (context->getExtensions().pixelBufferObject ||
788 context->getClientMajorVersion() >= 3);
Shannon Woods158c4382014-05-06 13:00:07 -0400789
He Yunchaoced53ae2016-11-29 15:00:51 +0800790 case GL_COPY_READ_BUFFER:
791 case GL_COPY_WRITE_BUFFER:
792 case GL_TRANSFORM_FEEDBACK_BUFFER:
793 case GL_UNIFORM_BUFFER:
794 return (context->getClientMajorVersion() >= 3);
Jamie Madill8c96d582014-03-05 15:01:23 -0500795
He Yunchaoced53ae2016-11-29 15:00:51 +0800796 case GL_ATOMIC_COUNTER_BUFFER:
797 case GL_SHADER_STORAGE_BUFFER:
798 case GL_DRAW_INDIRECT_BUFFER:
799 case GL_DISPATCH_INDIRECT_BUFFER:
He Yunchaoced53ae2016-11-29 15:00:51 +0800800 return context->getClientVersion() >= Version(3, 1);
Geoff Lang3b573612016-10-31 14:08:10 -0400801
He Yunchaoced53ae2016-11-29 15:00:51 +0800802 default:
803 return false;
Jamie Madill8c96d582014-03-05 15:01:23 -0500804 }
805}
806
Jamie Madillc29968b2016-01-20 11:17:23 -0500807bool ValidMipLevel(const ValidationContext *context, GLenum target, GLint level)
Geoff Langce635692013-09-24 13:56:32 -0400808{
Jamie Madillc29968b2016-01-20 11:17:23 -0500809 const auto &caps = context->getCaps();
Geoff Langaae65a42014-05-26 12:43:44 -0400810 size_t maxDimension = 0;
Geoff Langce635692013-09-24 13:56:32 -0400811 switch (target)
812 {
Jamie Madillc29968b2016-01-20 11:17:23 -0500813 case GL_TEXTURE_2D:
814 maxDimension = caps.max2DTextureSize;
815 break;
He Yunchaoced53ae2016-11-29 15:00:51 +0800816 case GL_TEXTURE_CUBE_MAP:
817 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
818 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
819 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
820 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
821 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
822 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
823 maxDimension = caps.maxCubeMapTextureSize;
824 break;
Corentin Wallez13c0dd42017-07-04 18:27:01 -0400825 case GL_TEXTURE_RECTANGLE_ANGLE:
826 return level == 0;
He Yunchaoced53ae2016-11-29 15:00:51 +0800827 case GL_TEXTURE_3D:
828 maxDimension = caps.max3DTextureSize;
829 break;
830 case GL_TEXTURE_2D_ARRAY:
831 maxDimension = caps.max2DTextureSize;
832 break;
He Yunchao11b038b2016-11-22 21:24:04 +0800833 case GL_TEXTURE_2D_MULTISAMPLE:
834 maxDimension = caps.max2DTextureSize;
835 break;
He Yunchaoced53ae2016-11-29 15:00:51 +0800836 default:
837 UNREACHABLE();
Geoff Langce635692013-09-24 13:56:32 -0400838 }
839
Brandon Jones6cad5662017-06-14 13:25:13 -0700840 return level <= gl::log2(static_cast<int>(maxDimension)) && level >= 0;
Geoff Langce635692013-09-24 13:56:32 -0400841}
842
Brandon Jones6cad5662017-06-14 13:25:13 -0700843bool ValidImageSizeParameters(ValidationContext *context,
Austin Kinross08528e12015-10-07 16:24:40 -0700844 GLenum target,
845 GLint level,
846 GLsizei width,
847 GLsizei height,
848 GLsizei depth,
849 bool isSubImage)
Geoff Langce635692013-09-24 13:56:32 -0400850{
Brandon Jones6cad5662017-06-14 13:25:13 -0700851 if (width < 0 || height < 0 || depth < 0)
Geoff Langce635692013-09-24 13:56:32 -0400852 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700853 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Geoff Langce635692013-09-24 13:56:32 -0400854 return false;
855 }
Austin Kinross08528e12015-10-07 16:24:40 -0700856 // TexSubImage parameters can be NPOT without textureNPOT extension,
857 // as long as the destination texture is POT.
Geoff Langcc507aa2016-12-12 10:09:52 -0500858 bool hasNPOTSupport =
Geoff Lang5f319a42017-01-09 16:49:19 -0500859 context->getExtensions().textureNPOT || context->getClientVersion() >= Version(3, 0);
Geoff Langcc507aa2016-12-12 10:09:52 -0500860 if (!isSubImage && !hasNPOTSupport &&
Jamie Madill4fd75c12014-06-23 10:53:54 -0400861 (level != 0 && (!gl::isPow2(width) || !gl::isPow2(height) || !gl::isPow2(depth))))
Geoff Langce635692013-09-24 13:56:32 -0400862 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700863 ANGLE_VALIDATION_ERR(context, InvalidValue(), TextureNotPow2);
Geoff Langce635692013-09-24 13:56:32 -0400864 return false;
865 }
866
867 if (!ValidMipLevel(context, target, level))
868 {
Brandon Jones6cad5662017-06-14 13:25:13 -0700869 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Geoff Langce635692013-09-24 13:56:32 -0400870 return false;
871 }
872
873 return true;
874}
875
Geoff Lang0d8b7242015-09-09 14:56:53 -0400876bool CompressedTextureFormatRequiresExactSize(GLenum internalFormat)
877{
878 // List of compressed format that require that the texture size is smaller than or a multiple of
879 // the compressed block size.
880 switch (internalFormat)
881 {
882 case GL_COMPRESSED_RGB_S3TC_DXT1_EXT:
883 case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT:
884 case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE:
885 case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE:
Geoff Langfff7a7d2017-06-02 10:39:17 -0400886 case GL_COMPRESSED_SRGB_S3TC_DXT1_EXT:
887 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT:
888 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT:
889 case GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT:
Minmin Gonge3939b92015-12-01 15:36:51 -0800890 case GL_ETC1_RGB8_LOSSY_DECODE_ANGLE:
Minmin Gong390208b2017-02-28 18:03:06 -0800891 case GL_COMPRESSED_RGB8_LOSSY_DECODE_ETC2_ANGLE:
892 case GL_COMPRESSED_SRGB8_LOSSY_DECODE_ETC2_ANGLE:
893 case GL_COMPRESSED_RGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE:
894 case GL_COMPRESSED_SRGB8_PUNCHTHROUGH_ALPHA1_LOSSY_DECODE_ETC2_ANGLE:
895 case GL_COMPRESSED_RGBA8_LOSSY_DECODE_ETC2_EAC_ANGLE:
896 case GL_COMPRESSED_SRGB8_ALPHA8_LOSSY_DECODE_ETC2_EAC_ANGLE:
Geoff Lang0d8b7242015-09-09 14:56:53 -0400897 return true;
898
899 default:
900 return false;
901 }
902}
903
Geoff Lang966c9402017-04-18 12:38:27 -0400904bool ValidCompressedDimension(GLsizei size, GLuint blockSize, bool smallerThanBlockSizeAllowed)
905{
906 return (smallerThanBlockSizeAllowed && (size > 0) && (blockSize % size == 0)) ||
907 (size % blockSize == 0);
908}
909
Jamie Madillc29968b2016-01-20 11:17:23 -0500910bool ValidCompressedImageSize(const ValidationContext *context,
911 GLenum internalFormat,
Geoff Lang966c9402017-04-18 12:38:27 -0400912 GLint level,
Jamie Madillc29968b2016-01-20 11:17:23 -0500913 GLsizei width,
914 GLsizei height)
Geoff Langd4f180b2013-09-24 13:57:44 -0400915{
Geoff Langca271392017-04-05 12:30:00 -0400916 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat);
Geoff Lang5d601382014-07-22 15:14:06 -0400917 if (!formatInfo.compressed)
Geoff Langd4f180b2013-09-24 13:57:44 -0400918 {
919 return false;
920 }
921
Geoff Lang966c9402017-04-18 12:38:27 -0400922 if (width < 0 || height < 0)
923 {
924 return false;
925 }
926
927 if (CompressedTextureFormatRequiresExactSize(internalFormat))
928 {
929 // The ANGLE extensions allow specifying compressed textures with sizes smaller than the
930 // block size for level 0 but WebGL disallows this.
931 bool smallerThanBlockSizeAllowed =
932 level > 0 || !context->getExtensions().webglCompatibility;
933
934 if (!ValidCompressedDimension(width, formatInfo.compressedBlockWidth,
935 smallerThanBlockSizeAllowed) ||
936 !ValidCompressedDimension(height, formatInfo.compressedBlockHeight,
937 smallerThanBlockSizeAllowed))
938 {
939 return false;
940 }
941 }
942
943 return true;
944}
945
946bool ValidCompressedSubImageSize(const ValidationContext *context,
947 GLenum internalFormat,
948 GLint xoffset,
949 GLint yoffset,
950 GLsizei width,
951 GLsizei height,
952 size_t textureWidth,
953 size_t textureHeight)
954{
955 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(internalFormat);
956 if (!formatInfo.compressed)
957 {
958 return false;
959 }
960
Geoff Lang44ff5a72017-02-03 15:15:43 -0500961 if (xoffset < 0 || yoffset < 0 || width < 0 || height < 0)
Geoff Langd4f180b2013-09-24 13:57:44 -0400962 {
963 return false;
964 }
965
Geoff Lang0d8b7242015-09-09 14:56:53 -0400966 if (CompressedTextureFormatRequiresExactSize(internalFormat))
967 {
Geoff Lang44ff5a72017-02-03 15:15:43 -0500968 if (xoffset % formatInfo.compressedBlockWidth != 0 ||
Geoff Lang966c9402017-04-18 12:38:27 -0400969 yoffset % formatInfo.compressedBlockHeight != 0)
970 {
971 return false;
972 }
973
974 // Allowed to either have data that is a multiple of block size or is smaller than the block
975 // size but fills the entire mip
976 bool fillsEntireMip = xoffset == 0 && yoffset == 0 &&
977 static_cast<size_t>(width) == textureWidth &&
978 static_cast<size_t>(height) == textureHeight;
979 bool sizeMultipleOfBlockSize = (width % formatInfo.compressedBlockWidth) == 0 &&
980 (height % formatInfo.compressedBlockHeight) == 0;
981 if (!sizeMultipleOfBlockSize && !fillsEntireMip)
Geoff Lang0d8b7242015-09-09 14:56:53 -0400982 {
983 return false;
984 }
985 }
986
Geoff Langd4f180b2013-09-24 13:57:44 -0400987 return true;
988}
989
Geoff Langff5b2d52016-09-07 11:32:23 -0400990bool ValidImageDataSize(ValidationContext *context,
991 GLenum textureTarget,
992 GLsizei width,
993 GLsizei height,
994 GLsizei depth,
Geoff Langdbcced82017-06-06 15:55:54 -0400995 GLenum format,
Geoff Langff5b2d52016-09-07 11:32:23 -0400996 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -0400997 const void *pixels,
Geoff Langff5b2d52016-09-07 11:32:23 -0400998 GLsizei imageSize)
999{
1000 gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
1001 if (pixelUnpackBuffer == nullptr && imageSize < 0)
1002 {
1003 // Checks are not required
1004 return true;
1005 }
1006
1007 // ...the data would be unpacked from the buffer object such that the memory reads required
1008 // would exceed the data store size.
Geoff Langdbcced82017-06-06 15:55:54 -04001009 const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(format, type);
1010 ASSERT(formatInfo.internalFormat != GL_NONE);
Geoff Langff5b2d52016-09-07 11:32:23 -04001011 const gl::Extents size(width, height, depth);
1012 const auto &unpack = context->getGLState().getUnpackState();
1013
1014 bool targetIs3D = textureTarget == GL_TEXTURE_3D || textureTarget == GL_TEXTURE_2D_ARRAY;
1015 auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, unpack, targetIs3D);
1016 if (endByteOrErr.isError())
1017 {
1018 context->handleError(endByteOrErr.getError());
1019 return false;
1020 }
1021
1022 GLuint endByte = endByteOrErr.getResult();
1023
1024 if (pixelUnpackBuffer)
1025 {
1026 CheckedNumeric<size_t> checkedEndByte(endByteOrErr.getResult());
1027 CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels));
1028 checkedEndByte += checkedOffset;
1029
1030 if (!checkedEndByte.IsValid() ||
1031 (checkedEndByte.ValueOrDie() > static_cast<size_t>(pixelUnpackBuffer->getSize())))
1032 {
1033 // Overflow past the end of the buffer
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001034 context->handleError(InvalidOperation());
Geoff Langff5b2d52016-09-07 11:32:23 -04001035 return false;
1036 }
1037 }
1038 else
1039 {
1040 ASSERT(imageSize >= 0);
1041 if (pixels == nullptr && imageSize != 0)
1042 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001043 context->handleError(InvalidOperation()
1044 << "imageSize must be 0 if no texture data is provided.");
Geoff Lang3feb3ff2016-10-26 10:57:45 -04001045 return false;
Geoff Langff5b2d52016-09-07 11:32:23 -04001046 }
1047
Geoff Lang3feb3ff2016-10-26 10:57:45 -04001048 if (pixels != nullptr && endByte > static_cast<GLuint>(imageSize))
Geoff Langff5b2d52016-09-07 11:32:23 -04001049 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001050 context->handleError(InvalidOperation() << "imageSize must be at least " << endByte);
Geoff Langff5b2d52016-09-07 11:32:23 -04001051 return false;
1052 }
1053 }
1054
1055 return true;
1056}
1057
Geoff Lang37dde692014-01-31 16:34:54 -05001058bool ValidQueryType(const Context *context, GLenum queryType)
1059{
He Yunchaoced53ae2016-11-29 15:00:51 +08001060 static_assert(GL_ANY_SAMPLES_PASSED == GL_ANY_SAMPLES_PASSED_EXT,
1061 "GL extension enums not equal.");
1062 static_assert(GL_ANY_SAMPLES_PASSED_CONSERVATIVE == GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
1063 "GL extension enums not equal.");
Geoff Lang37dde692014-01-31 16:34:54 -05001064
1065 switch (queryType)
1066 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001067 case GL_ANY_SAMPLES_PASSED:
1068 case GL_ANY_SAMPLES_PASSED_CONSERVATIVE:
Geoff Lang8c5b31c2017-09-26 18:07:44 -04001069 return context->getClientMajorVersion() >= 3 ||
1070 context->getExtensions().occlusionQueryBoolean;
He Yunchaoced53ae2016-11-29 15:00:51 +08001071 case GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN:
1072 return (context->getClientMajorVersion() >= 3);
1073 case GL_TIME_ELAPSED_EXT:
1074 return context->getExtensions().disjointTimerQuery;
1075 case GL_COMMANDS_COMPLETED_CHROMIUM:
1076 return context->getExtensions().syncQuery;
1077 default:
1078 return false;
Geoff Lang37dde692014-01-31 16:34:54 -05001079 }
1080}
1081
Geoff Lang2d62ab72017-03-23 16:54:40 -04001082bool ValidateWebGLVertexAttribPointer(ValidationContext *context,
1083 GLenum type,
1084 GLboolean normalized,
1085 GLsizei stride,
Jamie Madill876429b2017-04-20 15:46:24 -04001086 const void *ptr,
Geoff Lang2d62ab72017-03-23 16:54:40 -04001087 bool pureInteger)
1088{
1089 ASSERT(context->getExtensions().webglCompatibility);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001090 // WebGL 1.0 [Section 6.11] Vertex Attribute Data Stride
1091 // The WebGL API supports vertex attribute data strides up to 255 bytes. A call to
1092 // vertexAttribPointer will generate an INVALID_VALUE error if the value for the stride
1093 // parameter exceeds 255.
1094 constexpr GLsizei kMaxWebGLStride = 255;
1095 if (stride > kMaxWebGLStride)
1096 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001097 context->handleError(InvalidValue()
1098 << "Stride is over the maximum stride allowed by WebGL.");
Geoff Lang2d62ab72017-03-23 16:54:40 -04001099 return false;
1100 }
1101
1102 // WebGL 1.0 [Section 6.4] Buffer Offset and Stride Requirements
1103 // The offset arguments to drawElements and vertexAttribPointer, and the stride argument to
1104 // vertexAttribPointer, must be a multiple of the size of the data type passed to the call,
1105 // or an INVALID_OPERATION error is generated.
1106 VertexFormatType internalType = GetVertexFormatType(type, normalized, 1, pureInteger);
1107 size_t typeSize = GetVertexFormatTypeSize(internalType);
1108
1109 ASSERT(isPow2(typeSize) && typeSize > 0);
1110 size_t sizeMask = (typeSize - 1);
1111 if ((reinterpret_cast<intptr_t>(ptr) & sizeMask) != 0)
1112 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001113 ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001114 return false;
1115 }
1116
1117 if ((stride & sizeMask) != 0)
1118 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001119 ANGLE_VALIDATION_ERR(context, InvalidOperation(), StrideMustBeMultipleOfType);
Geoff Lang2d62ab72017-03-23 16:54:40 -04001120 return false;
1121 }
1122
1123 return true;
1124}
1125
Jamie Madillef300b12016-10-07 15:12:09 -04001126Program *GetValidProgram(ValidationContext *context, GLuint id)
Geoff Lang48dcae72014-02-05 16:28:24 -05001127{
He Yunchaoced53ae2016-11-29 15:00:51 +08001128 // ES3 spec (section 2.11.1) -- "Commands that accept shader or program object names will
1129 // generate the error INVALID_VALUE if the provided name is not the name of either a shader
1130 // or program object and INVALID_OPERATION if the provided name identifies an object
1131 // that is not the expected type."
Geoff Lang48dcae72014-02-05 16:28:24 -05001132
Dian Xiang769769a2015-09-09 15:20:08 -07001133 Program *validProgram = context->getProgram(id);
1134
1135 if (!validProgram)
Geoff Lang48dcae72014-02-05 16:28:24 -05001136 {
Dian Xiang769769a2015-09-09 15:20:08 -07001137 if (context->getShader(id))
1138 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001139 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedProgramName);
Dian Xiang769769a2015-09-09 15:20:08 -07001140 }
1141 else
1142 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001143 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidProgramName);
Dian Xiang769769a2015-09-09 15:20:08 -07001144 }
Geoff Lang48dcae72014-02-05 16:28:24 -05001145 }
Dian Xiang769769a2015-09-09 15:20:08 -07001146
1147 return validProgram;
1148}
1149
Jamie Madillef300b12016-10-07 15:12:09 -04001150Shader *GetValidShader(ValidationContext *context, GLuint id)
Dian Xiang769769a2015-09-09 15:20:08 -07001151{
1152 // See ValidProgram for spec details.
1153
1154 Shader *validShader = context->getShader(id);
1155
1156 if (!validShader)
Geoff Lang48dcae72014-02-05 16:28:24 -05001157 {
Dian Xiang769769a2015-09-09 15:20:08 -07001158 if (context->getProgram(id))
1159 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001160 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExpectedShaderName);
Dian Xiang769769a2015-09-09 15:20:08 -07001161 }
1162 else
1163 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001164 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidShaderName);
Dian Xiang769769a2015-09-09 15:20:08 -07001165 }
Geoff Lang48dcae72014-02-05 16:28:24 -05001166 }
Dian Xiang769769a2015-09-09 15:20:08 -07001167
1168 return validShader;
Geoff Lang48dcae72014-02-05 16:28:24 -05001169}
1170
Geoff Langb1196682014-07-23 13:47:29 -04001171bool ValidateAttachmentTarget(gl::Context *context, GLenum attachment)
Jamie Madillb4472272014-07-03 10:38:55 -04001172{
1173 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
1174 {
1175 const unsigned int colorAttachment = (attachment - GL_COLOR_ATTACHMENT0_EXT);
1176
Geoff Langaae65a42014-05-26 12:43:44 -04001177 if (colorAttachment >= context->getCaps().maxColorAttachments)
Jamie Madillb4472272014-07-03 10:38:55 -04001178 {
Martin Radevd178aa42017-07-13 14:03:22 +03001179 context->handleError(
1180 InvalidOperation()
1181 << "attachment index cannot be greater or equal to MAX_COLOR_ATTACHMENTS.");
Geoff Langb1196682014-07-23 13:47:29 -04001182 return false;
Jamie Madillb4472272014-07-03 10:38:55 -04001183 }
1184 }
1185 else
1186 {
1187 switch (attachment)
1188 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001189 case GL_DEPTH_ATTACHMENT:
1190 case GL_STENCIL_ATTACHMENT:
1191 break;
Jamie Madillb4472272014-07-03 10:38:55 -04001192
He Yunchaoced53ae2016-11-29 15:00:51 +08001193 case GL_DEPTH_STENCIL_ATTACHMENT:
1194 if (!context->getExtensions().webglCompatibility &&
1195 context->getClientMajorVersion() < 3)
1196 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001197 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
He Yunchaoced53ae2016-11-29 15:00:51 +08001198 return false;
1199 }
1200 break;
Jamie Madillb4472272014-07-03 10:38:55 -04001201
He Yunchaoced53ae2016-11-29 15:00:51 +08001202 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001203 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
He Yunchaoced53ae2016-11-29 15:00:51 +08001204 return false;
Jamie Madillb4472272014-07-03 10:38:55 -04001205 }
1206 }
1207
1208 return true;
1209}
1210
Jamie Madille8fb6402017-02-14 17:56:40 -05001211bool ValidateRenderbufferStorageParametersBase(ValidationContext *context,
He Yunchaoced53ae2016-11-29 15:00:51 +08001212 GLenum target,
1213 GLsizei samples,
1214 GLenum internalformat,
1215 GLsizei width,
1216 GLsizei height)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001217{
1218 switch (target)
1219 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001220 case GL_RENDERBUFFER:
1221 break;
1222 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001223 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
He Yunchaoced53ae2016-11-29 15:00:51 +08001224 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001225 }
1226
1227 if (width < 0 || height < 0 || samples < 0)
1228 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001229 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidRenderbufferWidthHeight);
Geoff Langb1196682014-07-23 13:47:29 -04001230 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001231 }
1232
Jamie Madill4e0e6f82017-02-17 11:06:03 -05001233 // Hack for the special WebGL 1 "DEPTH_STENCIL" internal format.
1234 GLenum convertedInternalFormat = context->getConvertedRenderbufferFormat(internalformat);
1235
1236 const TextureCaps &formatCaps = context->getTextureCaps().get(convertedInternalFormat);
Geoff Langd87878e2014-09-19 15:42:59 -04001237 if (!formatCaps.renderable)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001238 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001239 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04001240 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001241 }
1242
1243 // ANGLE_framebuffer_multisample does not explicitly state that the internal format must be
1244 // sized but it does state that the format must be in the ES2.0 spec table 4.5 which contains
Corentin Walleze0902642014-11-04 12:32:15 -08001245 // only sized internal formats.
Geoff Langca271392017-04-05 12:30:00 -04001246 const gl::InternalFormat &formatInfo = gl::GetSizedInternalFormatInfo(convertedInternalFormat);
1247 if (formatInfo.internalFormat == GL_NONE)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001248 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001249 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferInternalFormat);
Geoff Langb1196682014-07-23 13:47:29 -04001250 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001251 }
1252
Geoff Langaae65a42014-05-26 12:43:44 -04001253 if (static_cast<GLuint>(std::max(width, height)) > context->getCaps().maxRenderbufferSize)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001254 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001255 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04001256 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001257 }
1258
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001259 GLuint handle = context->getGLState().getRenderbufferId();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001260 if (handle == 0)
1261 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001262 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001263 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001264 }
1265
1266 return true;
1267}
1268
He Yunchaoced53ae2016-11-29 15:00:51 +08001269bool ValidateFramebufferRenderbufferParameters(gl::Context *context,
1270 GLenum target,
1271 GLenum attachment,
1272 GLenum renderbuffertarget,
1273 GLuint renderbuffer)
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001274{
Shannon Woods1da3cf62014-06-27 15:32:23 -04001275 if (!ValidFramebufferTarget(target))
1276 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001277 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04001278 return false;
Shannon Woods1da3cf62014-06-27 15:32:23 -04001279 }
1280
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001281 gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001282
Jamie Madill84115c92015-04-23 15:00:07 -04001283 ASSERT(framebuffer);
1284 if (framebuffer->id() == 0)
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001285 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001286 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001287 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001288 }
1289
Jamie Madillb4472272014-07-03 10:38:55 -04001290 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001291 {
Jamie Madillb4472272014-07-03 10:38:55 -04001292 return false;
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001293 }
1294
Jamie Madillab9d82c2014-01-21 16:38:14 -05001295 // [OpenGL ES 2.0.25] Section 4.4.3 page 112
1296 // [OpenGL ES 3.0.2] Section 4.4.2 page 201
1297 // 'renderbuffer' must be either zero or the name of an existing renderbuffer object of
1298 // type 'renderbuffertarget', otherwise an INVALID_OPERATION error is generated.
1299 if (renderbuffer != 0)
1300 {
1301 if (!context->getRenderbuffer(renderbuffer))
1302 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001303 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidRenderbufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04001304 return false;
Jamie Madillab9d82c2014-01-21 16:38:14 -05001305 }
1306 }
1307
Jamie Madill1fc7e2c2014-01-21 16:47:10 -05001308 return true;
1309}
1310
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001311bool ValidateBlitFramebufferParameters(ValidationContext *context,
Jamie Madillc29968b2016-01-20 11:17:23 -05001312 GLint srcX0,
1313 GLint srcY0,
1314 GLint srcX1,
1315 GLint srcY1,
1316 GLint dstX0,
1317 GLint dstY0,
1318 GLint dstX1,
1319 GLint dstY1,
1320 GLbitfield mask,
1321 GLenum filter)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001322{
1323 switch (filter)
1324 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001325 case GL_NEAREST:
1326 break;
1327 case GL_LINEAR:
1328 break;
1329 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001330 context->handleError(InvalidEnum());
He Yunchaoced53ae2016-11-29 15:00:51 +08001331 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001332 }
1333
1334 if ((mask & ~(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT | GL_DEPTH_BUFFER_BIT)) != 0)
1335 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001336 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04001337 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001338 }
1339
1340 if (mask == 0)
1341 {
1342 // ES3.0 spec, section 4.3.2 specifies that a mask of zero is valid and no
1343 // buffers are copied.
1344 return false;
1345 }
1346
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001347 // ES3.0 spec, section 4.3.2 states that linear filtering is only available for the
1348 // color buffer, leaving only nearest being unfiltered from above
1349 if ((mask & ~GL_COLOR_BUFFER_BIT) != 0 && filter != GL_NEAREST)
1350 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001351 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001352 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001353 }
1354
Jamie Madill51f40ec2016-06-15 14:06:00 -04001355 const auto &glState = context->getGLState();
1356 gl::Framebuffer *readFramebuffer = glState.getReadFramebuffer();
1357 gl::Framebuffer *drawFramebuffer = glState.getDrawFramebuffer();
Jamie Madill48faf802014-11-06 15:27:22 -05001358
1359 if (!readFramebuffer || !drawFramebuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001360 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001361 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001362 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001363 }
1364
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001365 if (readFramebuffer->id() == drawFramebuffer->id())
1366 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001367 context->handleError(InvalidOperation());
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001368 return false;
1369 }
1370
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001371 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill48faf802014-11-06 15:27:22 -05001372 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001373 context->handleError(InvalidFramebufferOperation());
Jamie Madill48faf802014-11-06 15:27:22 -05001374 return false;
1375 }
1376
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001377 if (drawFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill48faf802014-11-06 15:27:22 -05001378 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001379 context->handleError(InvalidFramebufferOperation());
Jamie Madill48faf802014-11-06 15:27:22 -05001380 return false;
1381 }
1382
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001383 if (drawFramebuffer->getSamples(context) != 0)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001384 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001385 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001386 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001387 }
1388
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001389 bool sameBounds = srcX0 == dstX0 && srcY0 == dstY0 && srcX1 == dstX1 && srcY1 == dstY1;
1390
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001391 if (mask & GL_COLOR_BUFFER_BIT)
1392 {
Jamie Madillb6bda4a2015-04-20 12:53:26 -04001393 const gl::FramebufferAttachment *readColorBuffer = readFramebuffer->getReadColorbuffer();
Jamie Madill6163c752015-12-07 16:32:59 -05001394 const Extensions &extensions = context->getExtensions();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001395
He Yunchao66a41a22016-12-15 16:45:05 +08001396 if (readColorBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001397 {
Jamie Madilla3944d42016-07-22 22:13:26 -04001398 const Format &readFormat = readColorBuffer->getFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001399
Geoff Langa15472a2015-08-11 11:48:03 -04001400 for (size_t drawbufferIdx = 0;
1401 drawbufferIdx < drawFramebuffer->getDrawbufferStateCount(); ++drawbufferIdx)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001402 {
Geoff Langa15472a2015-08-11 11:48:03 -04001403 const FramebufferAttachment *attachment =
1404 drawFramebuffer->getDrawBuffer(drawbufferIdx);
1405 if (attachment)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001406 {
Jamie Madilla3944d42016-07-22 22:13:26 -04001407 const Format &drawFormat = attachment->getFormat();
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001408
Geoff Langb2f3d052013-08-13 12:49:27 -04001409 // The GL ES 3.0.2 spec (pg 193) states that:
1410 // 1) If the read buffer is fixed point format, the draw buffer must be as well
He Yunchaoced53ae2016-11-29 15:00:51 +08001411 // 2) If the read buffer is an unsigned integer format, the draw buffer must be
1412 // as well
1413 // 3) If the read buffer is a signed integer format, the draw buffer must be as
1414 // well
Jamie Madill6163c752015-12-07 16:32:59 -05001415 // Changes with EXT_color_buffer_float:
1416 // Case 1) is changed to fixed point OR floating point
Jamie Madilla3944d42016-07-22 22:13:26 -04001417 GLenum readComponentType = readFormat.info->componentType;
1418 GLenum drawComponentType = drawFormat.info->componentType;
He Yunchaoced53ae2016-11-29 15:00:51 +08001419 bool readFixedPoint = (readComponentType == GL_UNSIGNED_NORMALIZED ||
Jamie Madill6163c752015-12-07 16:32:59 -05001420 readComponentType == GL_SIGNED_NORMALIZED);
1421 bool drawFixedPoint = (drawComponentType == GL_UNSIGNED_NORMALIZED ||
1422 drawComponentType == GL_SIGNED_NORMALIZED);
1423
1424 if (extensions.colorBufferFloat)
1425 {
1426 bool readFixedOrFloat = (readFixedPoint || readComponentType == GL_FLOAT);
1427 bool drawFixedOrFloat = (drawFixedPoint || drawComponentType == GL_FLOAT);
1428
1429 if (readFixedOrFloat != drawFixedOrFloat)
1430 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001431 context->handleError(InvalidOperation()
1432 << "If the read buffer contains fixed-point or "
1433 "floating-point values, the draw buffer must "
1434 "as well.");
Jamie Madill6163c752015-12-07 16:32:59 -05001435 return false;
1436 }
1437 }
1438 else if (readFixedPoint != drawFixedPoint)
1439 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001440 context->handleError(InvalidOperation()
1441 << "If the read buffer contains fixed-point values, "
1442 "the draw buffer must as well.");
Jamie Madill6163c752015-12-07 16:32:59 -05001443 return false;
1444 }
1445
1446 if (readComponentType == GL_UNSIGNED_INT &&
1447 drawComponentType != GL_UNSIGNED_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001448 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001449 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001450 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001451 }
1452
Jamie Madill6163c752015-12-07 16:32:59 -05001453 if (readComponentType == GL_INT && drawComponentType != GL_INT)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001454 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001455 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001456 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001457 }
1458
Jamie Madilla3944d42016-07-22 22:13:26 -04001459 if (readColorBuffer->getSamples() > 0 &&
Kenneth Russell69382852017-07-21 16:38:44 -04001460 (!Format::EquivalentForBlit(readFormat, drawFormat) || !sameBounds))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001461 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001462 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001463 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001464 }
Geoff Lange4915782017-04-12 15:19:07 -04001465
1466 if (context->getExtensions().webglCompatibility &&
1467 *readColorBuffer == *attachment)
1468 {
1469 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001470 InvalidOperation()
1471 << "Read and write color attachments cannot be the same image.");
Geoff Lange4915782017-04-12 15:19:07 -04001472 return false;
1473 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001474 }
1475 }
1476
Jamie Madilla3944d42016-07-22 22:13:26 -04001477 if ((readFormat.info->componentType == GL_INT ||
1478 readFormat.info->componentType == GL_UNSIGNED_INT) &&
1479 filter == GL_LINEAR)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001480 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001481 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001482 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001483 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001484 }
He Yunchao66a41a22016-12-15 16:45:05 +08001485 // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment
1486 // In OpenGL ES it is undefined what happens when an operation tries to blit from a missing
1487 // attachment and WebGL defines it to be an error. We do the check unconditionally as the
1488 // situation is an application error that would lead to a crash in ANGLE.
1489 else if (drawFramebuffer->hasEnabledDrawBuffer())
1490 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001491 context->handleError(
1492 InvalidOperation()
1493 << "Attempt to read from a missing color attachment of a complete framebuffer.");
He Yunchao66a41a22016-12-15 16:45:05 +08001494 return false;
1495 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001496 }
1497
He Yunchaoced53ae2016-11-29 15:00:51 +08001498 GLenum masks[] = {GL_DEPTH_BUFFER_BIT, GL_STENCIL_BUFFER_BIT};
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001499 GLenum attachments[] = {GL_DEPTH_ATTACHMENT, GL_STENCIL_ATTACHMENT};
1500 for (size_t i = 0; i < 2; i++)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001501 {
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001502 if (mask & masks[i])
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001503 {
He Yunchaoced53ae2016-11-29 15:00:51 +08001504 const gl::FramebufferAttachment *readBuffer =
1505 readFramebuffer->getAttachment(attachments[i]);
1506 const gl::FramebufferAttachment *drawBuffer =
1507 drawFramebuffer->getAttachment(attachments[i]);
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001508
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001509 if (readBuffer && drawBuffer)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001510 {
Kenneth Russell69382852017-07-21 16:38:44 -04001511 if (!Format::EquivalentForBlit(readBuffer->getFormat(), drawBuffer->getFormat()))
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001512 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001513 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001514 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001515 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001516
Dongseong Hwang44b422c2014-12-09 15:42:01 +02001517 if (readBuffer->getSamples() > 0 && !sameBounds)
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001518 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001519 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04001520 return false;
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001521 }
Geoff Lange4915782017-04-12 15:19:07 -04001522
1523 if (context->getExtensions().webglCompatibility && *readBuffer == *drawBuffer)
1524 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001525 context->handleError(
1526 InvalidOperation()
1527 << "Read and write depth stencil attachments cannot be the same image.");
Geoff Lange4915782017-04-12 15:19:07 -04001528 return false;
1529 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001530 }
He Yunchao66a41a22016-12-15 16:45:05 +08001531 // WebGL 2.0 BlitFramebuffer when blitting from a missing attachment
1532 else if (drawBuffer)
1533 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001534 context->handleError(InvalidOperation() << "Attempt to read from a missing "
1535 "depth/stencil attachment of a "
1536 "complete framebuffer.");
He Yunchao66a41a22016-12-15 16:45:05 +08001537 return false;
1538 }
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001539 }
1540 }
1541
Martin Radeva3ed4572017-07-27 18:29:37 +03001542 // ANGLE_multiview, Revision 1:
1543 // Calling BlitFramebuffer will result in an INVALID_FRAMEBUFFER_OPERATION error if the
1544 // multi-view layout of the current draw framebuffer or read framebuffer is not NONE.
1545 if (readFramebuffer->getMultiviewLayout() != GL_NONE)
1546 {
1547 context->handleError(InvalidFramebufferOperation()
1548 << "Attempt to read from a multi-view framebuffer.");
1549 return false;
1550 }
1551 if (drawFramebuffer->getMultiviewLayout() != GL_NONE)
1552 {
1553 context->handleError(InvalidFramebufferOperation()
1554 << "Attempt to write to a multi-view framebuffer.");
1555 return false;
1556 }
1557
Geoff Lange8ebe7f2013-08-05 15:03:13 -04001558 return true;
1559}
1560
Jamie Madill4928b7c2017-06-20 12:57:39 -04001561bool ValidateReadPixelsRobustANGLE(Context *context,
Geoff Lang62fce5b2016-09-30 10:46:35 -04001562 GLint x,
1563 GLint y,
1564 GLsizei width,
1565 GLsizei height,
1566 GLenum format,
1567 GLenum type,
1568 GLsizei bufSize,
1569 GLsizei *length,
Geoff Lange93daba2017-03-30 13:54:40 -04001570 GLsizei *columns,
1571 GLsizei *rows,
Jamie Madill876429b2017-04-20 15:46:24 -04001572 void *pixels)
Geoff Lang62fce5b2016-09-30 10:46:35 -04001573{
1574 if (!ValidateRobustEntryPoint(context, bufSize))
Jamie Madillc29968b2016-01-20 11:17:23 -05001575 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001576 return false;
1577 }
1578
Geoff Lang62fce5b2016-09-30 10:46:35 -04001579 if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length,
Geoff Lange93daba2017-03-30 13:54:40 -04001580 columns, rows, pixels))
Jamie Madill26e91952014-03-05 15:01:27 -05001581 {
Geoff Langb1196682014-07-23 13:47:29 -04001582 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001583 }
1584
Geoff Lang62fce5b2016-09-30 10:46:35 -04001585 if (!ValidateRobustBufferSize(context, bufSize, *length))
Jamie Madill26e91952014-03-05 15:01:27 -05001586 {
Geoff Langb1196682014-07-23 13:47:29 -04001587 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001588 }
1589
Jamie Madillc29968b2016-01-20 11:17:23 -05001590 return true;
1591}
1592
1593bool ValidateReadnPixelsEXT(Context *context,
1594 GLint x,
1595 GLint y,
1596 GLsizei width,
1597 GLsizei height,
1598 GLenum format,
1599 GLenum type,
1600 GLsizei bufSize,
Jamie Madill876429b2017-04-20 15:46:24 -04001601 void *pixels)
Jamie Madillc29968b2016-01-20 11:17:23 -05001602{
1603 if (bufSize < 0)
1604 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001605 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Jamie Madillc29968b2016-01-20 11:17:23 -05001606 return false;
1607 }
1608
Geoff Lang62fce5b2016-09-30 10:46:35 -04001609 return ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, nullptr,
Geoff Lange93daba2017-03-30 13:54:40 -04001610 nullptr, nullptr, pixels);
Geoff Lang62fce5b2016-09-30 10:46:35 -04001611}
Jamie Madill26e91952014-03-05 15:01:27 -05001612
Jamie Madill4928b7c2017-06-20 12:57:39 -04001613bool ValidateReadnPixelsRobustANGLE(Context *context,
Geoff Lang62fce5b2016-09-30 10:46:35 -04001614 GLint x,
1615 GLint y,
1616 GLsizei width,
1617 GLsizei height,
1618 GLenum format,
1619 GLenum type,
1620 GLsizei bufSize,
1621 GLsizei *length,
Geoff Lange93daba2017-03-30 13:54:40 -04001622 GLsizei *columns,
1623 GLsizei *rows,
Jamie Madill876429b2017-04-20 15:46:24 -04001624 void *data)
Geoff Lang62fce5b2016-09-30 10:46:35 -04001625{
1626 if (!ValidateRobustEntryPoint(context, bufSize))
Jamie Madille2e406c2016-06-02 13:04:10 -04001627 {
Jamie Madille2e406c2016-06-02 13:04:10 -04001628 return false;
1629 }
1630
Geoff Lange93daba2017-03-30 13:54:40 -04001631 if (!ValidateReadPixelsBase(context, x, y, width, height, format, type, bufSize, length,
1632 columns, rows, data))
Jamie Madille2e406c2016-06-02 13:04:10 -04001633 {
Jamie Madillc29968b2016-01-20 11:17:23 -05001634 return false;
Jamie Madill26e91952014-03-05 15:01:27 -05001635 }
1636
Geoff Lang62fce5b2016-09-30 10:46:35 -04001637 if (!ValidateRobustBufferSize(context, bufSize, *length))
1638 {
1639 return false;
1640 }
1641
1642 return true;
Jamie Madill26e91952014-03-05 15:01:27 -05001643}
1644
Jamie Madillf0e04492017-08-26 15:28:42 -04001645bool ValidateGenQueriesEXT(gl::Context *context, GLsizei n, GLuint *ids)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001646{
1647 if (!context->getExtensions().occlusionQueryBoolean &&
1648 !context->getExtensions().disjointTimerQuery)
1649 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001650 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001651 return false;
1652 }
1653
Olli Etuaho41997e72016-03-10 13:38:39 +02001654 return ValidateGenOrDelete(context, n);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001655}
1656
Jamie Madillf0e04492017-08-26 15:28:42 -04001657bool ValidateDeleteQueriesEXT(gl::Context *context, GLsizei n, const GLuint *ids)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001658{
1659 if (!context->getExtensions().occlusionQueryBoolean &&
1660 !context->getExtensions().disjointTimerQuery)
1661 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001662 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001663 return false;
1664 }
1665
Olli Etuaho41997e72016-03-10 13:38:39 +02001666 return ValidateGenOrDelete(context, n);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001667}
1668
Jamie Madillf0e04492017-08-26 15:28:42 -04001669bool ValidateIsQueryEXT(gl::Context *context, GLuint id)
1670{
1671 if (!context->getExtensions().occlusionQueryBoolean &&
1672 !context->getExtensions().disjointTimerQuery)
1673 {
1674 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled);
1675 return false;
1676 }
1677
1678 return true;
1679}
1680
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001681bool ValidateBeginQueryBase(gl::Context *context, GLenum target, GLuint id)
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001682{
1683 if (!ValidQueryType(context, target))
1684 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001685 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryType);
Geoff Langb1196682014-07-23 13:47:29 -04001686 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001687 }
1688
1689 if (id == 0)
1690 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001691 context->handleError(InvalidOperation() << "Query id is 0");
Geoff Langb1196682014-07-23 13:47:29 -04001692 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001693 }
1694
1695 // From EXT_occlusion_query_boolean: If BeginQueryEXT is called with an <id>
1696 // of zero, if the active query object name for <target> is non-zero (for the
1697 // targets ANY_SAMPLES_PASSED_EXT and ANY_SAMPLES_PASSED_CONSERVATIVE_EXT, if
1698 // the active query for either target is non-zero), if <id> is the name of an
1699 // existing query object whose type does not match <target>, or if <id> is the
1700 // active query object name for any query type, the error INVALID_OPERATION is
1701 // generated.
1702
1703 // Ensure no other queries are active
1704 // NOTE: If other queries than occlusion are supported, we will need to check
1705 // separately that:
1706 // a) The query ID passed is not the current active query for any target/type
1707 // b) There are no active queries for the requested target (and in the case
1708 // of GL_ANY_SAMPLES_PASSED_EXT and GL_ANY_SAMPLES_PASSED_CONSERVATIVE_EXT,
1709 // no query may be active for either if glBeginQuery targets either.
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001710
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001711 if (context->getGLState().isQueryActive(target))
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001712 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001713 context->handleError(InvalidOperation() << "Other query is active");
Geoff Langb1196682014-07-23 13:47:29 -04001714 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001715 }
1716
1717 Query *queryObject = context->getQuery(id, true, target);
1718
1719 // check that name was obtained with glGenQueries
1720 if (!queryObject)
1721 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001722 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidQueryId);
Geoff Langb1196682014-07-23 13:47:29 -04001723 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001724 }
1725
1726 // check for type mismatch
1727 if (queryObject->getType() != target)
1728 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001729 context->handleError(InvalidOperation() << "Query type does not match target");
Geoff Langb1196682014-07-23 13:47:29 -04001730 return false;
Jamie Madilldb2f14c2014-05-13 13:56:30 -04001731 }
1732
1733 return true;
1734}
1735
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001736bool ValidateBeginQueryEXT(gl::Context *context, GLenum target, GLuint id)
1737{
1738 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001739 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001740 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001741 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001742 return false;
1743 }
1744
1745 return ValidateBeginQueryBase(context, target, id);
1746}
1747
1748bool ValidateEndQueryBase(gl::Context *context, GLenum target)
Jamie Madill45c785d2014-05-13 14:09:34 -04001749{
1750 if (!ValidQueryType(context, target))
1751 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001752 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryType);
Geoff Langb1196682014-07-23 13:47:29 -04001753 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04001754 }
1755
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001756 const Query *queryObject = context->getGLState().getActiveQuery(target);
Jamie Madill45c785d2014-05-13 14:09:34 -04001757
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001758 if (queryObject == nullptr)
Jamie Madill45c785d2014-05-13 14:09:34 -04001759 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001760 context->handleError(InvalidOperation() << "Query target not active");
Geoff Langb1196682014-07-23 13:47:29 -04001761 return false;
Jamie Madill45c785d2014-05-13 14:09:34 -04001762 }
1763
Jamie Madill45c785d2014-05-13 14:09:34 -04001764 return true;
1765}
1766
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001767bool ValidateEndQueryEXT(gl::Context *context, GLenum target)
1768{
1769 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001770 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001771 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001772 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001773 return false;
1774 }
1775
1776 return ValidateEndQueryBase(context, target);
1777}
1778
1779bool ValidateQueryCounterEXT(Context *context, GLuint id, GLenum target)
1780{
1781 if (!context->getExtensions().disjointTimerQuery)
1782 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001783 context->handleError(InvalidOperation() << "Disjoint timer query not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001784 return false;
1785 }
1786
1787 if (target != GL_TIMESTAMP_EXT)
1788 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001789 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryTarget);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001790 return false;
1791 }
1792
1793 Query *queryObject = context->getQuery(id, true, target);
1794 if (queryObject == nullptr)
1795 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001796 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidQueryId);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001797 return false;
1798 }
1799
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001800 if (context->getGLState().isQueryActive(queryObject))
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001801 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001802 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryActive);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001803 return false;
1804 }
1805
1806 return true;
1807}
1808
Geoff Lang2186c382016-10-14 10:54:54 -04001809bool ValidateGetQueryivBase(Context *context, GLenum target, GLenum pname, GLsizei *numParams)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001810{
Geoff Lang2186c382016-10-14 10:54:54 -04001811 if (numParams)
1812 {
1813 *numParams = 0;
1814 }
1815
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001816 if (!ValidQueryType(context, target) && target != GL_TIMESTAMP_EXT)
1817 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001818 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidQueryType);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001819 return false;
1820 }
1821
1822 switch (pname)
1823 {
1824 case GL_CURRENT_QUERY_EXT:
1825 if (target == GL_TIMESTAMP_EXT)
1826 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001827 context->handleError(InvalidEnum() << "Cannot use current query for timestamp");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001828 return false;
1829 }
1830 break;
1831 case GL_QUERY_COUNTER_BITS_EXT:
1832 if (!context->getExtensions().disjointTimerQuery ||
1833 (target != GL_TIMESTAMP_EXT && target != GL_TIME_ELAPSED_EXT))
1834 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001835 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidPname);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001836 return false;
1837 }
1838 break;
1839 default:
Brandon Jonesafa75152017-07-21 13:11:29 -07001840 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidPname);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001841 return false;
1842 }
1843
Geoff Lang2186c382016-10-14 10:54:54 -04001844 if (numParams)
1845 {
1846 // All queries return only one value
1847 *numParams = 1;
1848 }
1849
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001850 return true;
1851}
1852
1853bool ValidateGetQueryivEXT(Context *context, GLenum target, GLenum pname, GLint *params)
1854{
1855 if (!context->getExtensions().occlusionQueryBoolean &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001856 !context->getExtensions().disjointTimerQuery && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001857 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001858 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001859 return false;
1860 }
1861
Geoff Lang2186c382016-10-14 10:54:54 -04001862 return ValidateGetQueryivBase(context, target, pname, nullptr);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001863}
1864
Geoff Lang2186c382016-10-14 10:54:54 -04001865bool ValidateGetQueryivRobustANGLE(Context *context,
1866 GLenum target,
1867 GLenum pname,
1868 GLsizei bufSize,
1869 GLsizei *length,
1870 GLint *params)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001871{
Geoff Lang2186c382016-10-14 10:54:54 -04001872 if (!ValidateRobustEntryPoint(context, bufSize))
1873 {
1874 return false;
1875 }
1876
1877 if (!ValidateGetQueryivBase(context, target, pname, length))
1878 {
1879 return false;
1880 }
1881
1882 if (!ValidateRobustBufferSize(context, bufSize, *length))
1883 {
1884 return false;
1885 }
1886
1887 return true;
1888}
1889
1890bool ValidateGetQueryObjectValueBase(Context *context, GLuint id, GLenum pname, GLsizei *numParams)
1891{
1892 if (numParams)
1893 {
1894 *numParams = 0;
1895 }
1896
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001897 Query *queryObject = context->getQuery(id, false, GL_NONE);
1898
1899 if (!queryObject)
1900 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001901 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidQueryId);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001902 return false;
1903 }
1904
Jamie Madilldfde6ab2016-06-09 07:07:18 -07001905 if (context->getGLState().isQueryActive(queryObject))
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001906 {
Brandon Jonesafa75152017-07-21 13:11:29 -07001907 ANGLE_VALIDATION_ERR(context, InvalidOperation(), QueryActive);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001908 return false;
1909 }
1910
1911 switch (pname)
1912 {
1913 case GL_QUERY_RESULT_EXT:
1914 case GL_QUERY_RESULT_AVAILABLE_EXT:
1915 break;
1916
1917 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07001918 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001919 return false;
1920 }
1921
Geoff Lang2186c382016-10-14 10:54:54 -04001922 if (numParams)
1923 {
1924 *numParams = 1;
1925 }
1926
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001927 return true;
1928}
1929
1930bool ValidateGetQueryObjectivEXT(Context *context, GLuint id, GLenum pname, GLint *params)
1931{
1932 if (!context->getExtensions().disjointTimerQuery)
1933 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001934 context->handleError(InvalidOperation() << "Timer query extension not enabled");
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001935 return false;
1936 }
Geoff Lang2186c382016-10-14 10:54:54 -04001937 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
1938}
1939
1940bool ValidateGetQueryObjectivRobustANGLE(Context *context,
1941 GLuint id,
1942 GLenum pname,
1943 GLsizei bufSize,
1944 GLsizei *length,
1945 GLint *params)
1946{
1947 if (!context->getExtensions().disjointTimerQuery)
1948 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05001949 context->handleError(InvalidOperation() << "Timer query extension not enabled");
Geoff Lang2186c382016-10-14 10:54:54 -04001950 return false;
1951 }
1952
1953 if (!ValidateRobustEntryPoint(context, bufSize))
1954 {
1955 return false;
1956 }
1957
1958 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
1959 {
1960 return false;
1961 }
1962
1963 if (!ValidateRobustBufferSize(context, bufSize, *length))
1964 {
1965 return false;
1966 }
1967
1968 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001969}
1970
1971bool ValidateGetQueryObjectuivEXT(Context *context, GLuint id, GLenum pname, GLuint *params)
1972{
1973 if (!context->getExtensions().disjointTimerQuery &&
Geoff Lang2b4ce802016-04-28 13:34:50 -04001974 !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery)
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001975 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001976 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05001977 return false;
1978 }
Geoff Lang2186c382016-10-14 10:54:54 -04001979 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
1980}
1981
1982bool ValidateGetQueryObjectuivRobustANGLE(Context *context,
1983 GLuint id,
1984 GLenum pname,
1985 GLsizei bufSize,
1986 GLsizei *length,
1987 GLuint *params)
1988{
1989 if (!context->getExtensions().disjointTimerQuery &&
1990 !context->getExtensions().occlusionQueryBoolean && !context->getExtensions().syncQuery)
1991 {
Brandon Jones6cad5662017-06-14 13:25:13 -07001992 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04001993 return false;
1994 }
1995
1996 if (!ValidateRobustEntryPoint(context, bufSize))
1997 {
1998 return false;
1999 }
2000
2001 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2002 {
2003 return false;
2004 }
2005
2006 if (!ValidateRobustBufferSize(context, bufSize, *length))
2007 {
2008 return false;
2009 }
2010
2011 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002012}
2013
2014bool ValidateGetQueryObjecti64vEXT(Context *context, GLuint id, GLenum pname, GLint64 *params)
2015{
2016 if (!context->getExtensions().disjointTimerQuery)
2017 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002018 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002019 return false;
2020 }
Geoff Lang2186c382016-10-14 10:54:54 -04002021 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2022}
2023
2024bool ValidateGetQueryObjecti64vRobustANGLE(Context *context,
2025 GLuint id,
2026 GLenum pname,
2027 GLsizei bufSize,
2028 GLsizei *length,
2029 GLint64 *params)
2030{
2031 if (!context->getExtensions().disjointTimerQuery)
2032 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002033 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002034 return false;
2035 }
2036
2037 if (!ValidateRobustEntryPoint(context, bufSize))
2038 {
2039 return false;
2040 }
2041
2042 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2043 {
2044 return false;
2045 }
2046
2047 if (!ValidateRobustBufferSize(context, bufSize, *length))
2048 {
2049 return false;
2050 }
2051
2052 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002053}
2054
2055bool ValidateGetQueryObjectui64vEXT(Context *context, GLuint id, GLenum pname, GLuint64 *params)
2056{
2057 if (!context->getExtensions().disjointTimerQuery)
2058 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002059 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002060 return false;
2061 }
Geoff Lang2186c382016-10-14 10:54:54 -04002062 return ValidateGetQueryObjectValueBase(context, id, pname, nullptr);
2063}
2064
2065bool ValidateGetQueryObjectui64vRobustANGLE(Context *context,
2066 GLuint id,
2067 GLenum pname,
2068 GLsizei bufSize,
2069 GLsizei *length,
2070 GLuint64 *params)
2071{
2072 if (!context->getExtensions().disjointTimerQuery)
2073 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002074 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
Geoff Lang2186c382016-10-14 10:54:54 -04002075 return false;
2076 }
2077
2078 if (!ValidateRobustEntryPoint(context, bufSize))
2079 {
2080 return false;
2081 }
2082
2083 if (!ValidateGetQueryObjectValueBase(context, id, pname, length))
2084 {
2085 return false;
2086 }
2087
2088 if (!ValidateRobustBufferSize(context, bufSize, *length))
2089 {
2090 return false;
2091 }
2092
2093 return true;
Ian Ewell3ffd78b2016-01-22 16:09:42 -05002094}
2095
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002096bool ValidateProgramUniform(gl::Context *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002097 GLenum valueType,
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002098 GLuint program,
2099 GLint location,
2100 GLsizei count)
2101{
2102 // Check for ES31 program uniform entry points
2103 if (context->getClientVersion() < Version(3, 1))
2104 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08002105 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES31Required);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002106 return false;
2107 }
2108
2109 const LinkedUniform *uniform = nullptr;
2110 gl::Program *programObject = GetValidProgram(context, program);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002111 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2112 ValidateUniformValue(context, valueType, uniform->type);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002113}
2114
Frank Henigmana98a6472017-02-02 21:38:32 -05002115bool ValidateProgramUniform1iv(gl::Context *context,
2116 GLuint program,
2117 GLint location,
2118 GLsizei count,
2119 const GLint *value)
2120{
2121 // Check for ES31 program uniform entry points
2122 if (context->getClientVersion() < Version(3, 1))
2123 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08002124 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES31Required);
Frank Henigmana98a6472017-02-02 21:38:32 -05002125 return false;
2126 }
2127
2128 const LinkedUniform *uniform = nullptr;
2129 gl::Program *programObject = GetValidProgram(context, program);
2130 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2131 ValidateUniform1ivValue(context, uniform->type, count, value);
2132}
2133
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002134bool ValidateProgramUniformMatrix(gl::Context *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002135 GLenum valueType,
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002136 GLuint program,
2137 GLint location,
2138 GLsizei count,
2139 GLboolean transpose)
2140{
2141 // Check for ES31 program uniform entry points
2142 if (context->getClientVersion() < Version(3, 1))
2143 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08002144 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES31Required);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002145 return false;
2146 }
2147
2148 const LinkedUniform *uniform = nullptr;
2149 gl::Program *programObject = GetValidProgram(context, program);
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002150 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2151 ValidateUniformMatrixValue(context, valueType, uniform->type);
Jiajia Qinee9f08c2016-11-16 10:06:10 +08002152}
2153
Jamie Madillc1d770e2017-04-13 17:31:24 -04002154bool ValidateUniform(ValidationContext *context, GLenum valueType, GLint location, GLsizei count)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002155{
Jamie Madill62d31cb2015-09-11 13:25:51 -04002156 const LinkedUniform *uniform = nullptr;
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002157 gl::Program *programObject = context->getGLState().getProgram();
2158 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2159 ValidateUniformValue(context, valueType, uniform->type);
Jamie Madillaa981bd2014-05-20 10:55:55 -04002160}
2161
Jamie Madillbe849e42017-05-02 15:49:00 -04002162bool ValidateUniform1iv(ValidationContext *context,
2163 GLint location,
2164 GLsizei count,
2165 const GLint *value)
Frank Henigmana98a6472017-02-02 21:38:32 -05002166{
2167 const LinkedUniform *uniform = nullptr;
2168 gl::Program *programObject = context->getGLState().getProgram();
2169 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2170 ValidateUniform1ivValue(context, uniform->type, count, value);
2171}
2172
Jamie Madillc1d770e2017-04-13 17:31:24 -04002173bool ValidateUniformMatrix(ValidationContext *context,
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002174 GLenum valueType,
He Yunchaoced53ae2016-11-29 15:00:51 +08002175 GLint location,
2176 GLsizei count,
Jamie Madillaa981bd2014-05-20 10:55:55 -04002177 GLboolean transpose)
2178{
Martin Radev1be913c2016-07-11 17:59:16 +03002179 if (transpose != GL_FALSE && context->getClientMajorVersion() < 3)
Jamie Madillaa981bd2014-05-20 10:55:55 -04002180 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002181 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002182 return false;
Jamie Madillaa981bd2014-05-20 10:55:55 -04002183 }
2184
Jamie Madill62d31cb2015-09-11 13:25:51 -04002185 const LinkedUniform *uniform = nullptr;
Frank Henigmanf5f74ae2017-02-02 21:14:23 -05002186 gl::Program *programObject = context->getGLState().getProgram();
2187 return ValidateUniformCommonBase(context, programObject, location, count, &uniform) &&
2188 ValidateUniformMatrixValue(context, valueType, uniform->type);
Jamie Madillaa981bd2014-05-20 10:55:55 -04002189}
2190
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002191bool ValidateStateQuery(ValidationContext *context,
2192 GLenum pname,
2193 GLenum *nativeType,
2194 unsigned int *numParams)
Jamie Madill893ab082014-05-16 16:56:10 -04002195{
2196 if (!context->getQueryParameterInfo(pname, nativeType, numParams))
2197 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002198 context->handleError(InvalidEnum());
Geoff Langb1196682014-07-23 13:47:29 -04002199 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002200 }
2201
Jamie Madill0af26e12015-03-05 19:54:33 -05002202 const Caps &caps = context->getCaps();
2203
Jamie Madill893ab082014-05-16 16:56:10 -04002204 if (pname >= GL_DRAW_BUFFER0 && pname <= GL_DRAW_BUFFER15)
2205 {
2206 unsigned int colorAttachment = (pname - GL_DRAW_BUFFER0);
2207
Jamie Madill0af26e12015-03-05 19:54:33 -05002208 if (colorAttachment >= caps.maxDrawBuffers)
Jamie Madill893ab082014-05-16 16:56:10 -04002209 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002210 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002211 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002212 }
2213 }
2214
2215 switch (pname)
2216 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002217 case GL_TEXTURE_BINDING_2D:
2218 case GL_TEXTURE_BINDING_CUBE_MAP:
2219 case GL_TEXTURE_BINDING_3D:
2220 case GL_TEXTURE_BINDING_2D_ARRAY:
JiangYizhou24fe74c2017-07-06 16:56:50 +08002221 case GL_TEXTURE_BINDING_2D_MULTISAMPLE:
He Yunchaoced53ae2016-11-29 15:00:51 +08002222 break;
Corentin Wallez13c0dd42017-07-04 18:27:01 -04002223 case GL_TEXTURE_BINDING_RECTANGLE_ANGLE:
2224 if (!context->getExtensions().textureRectangle)
2225 {
2226 context->handleError(InvalidEnum()
2227 << "ANGLE_texture_rectangle extension not present");
2228 return false;
2229 }
2230 break;
He Yunchaoced53ae2016-11-29 15:00:51 +08002231 case GL_TEXTURE_BINDING_EXTERNAL_OES:
2232 if (!context->getExtensions().eglStreamConsumerExternal &&
2233 !context->getExtensions().eglImageExternal)
2234 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002235 context->handleError(InvalidEnum() << "Neither NV_EGL_stream_consumer_external "
2236 "nor GL_OES_EGL_image_external "
2237 "extensions enabled");
He Yunchaoced53ae2016-11-29 15:00:51 +08002238 return false;
2239 }
2240 break;
Jamie Madill893ab082014-05-16 16:56:10 -04002241
He Yunchaoced53ae2016-11-29 15:00:51 +08002242 case GL_IMPLEMENTATION_COLOR_READ_TYPE:
2243 case GL_IMPLEMENTATION_COLOR_READ_FORMAT:
Jamie Madill893ab082014-05-16 16:56:10 -04002244 {
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002245 if (context->getGLState().getReadFramebuffer()->checkStatus(context) !=
2246 GL_FRAMEBUFFER_COMPLETE)
Jamie Madill893ab082014-05-16 16:56:10 -04002247 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002248 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002249 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002250 }
2251
Jamie Madill51f40ec2016-06-15 14:06:00 -04002252 const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer();
2253 ASSERT(framebuffer);
Martin Radev138064f2016-07-15 12:03:41 +03002254
2255 if (framebuffer->getReadBufferState() == GL_NONE)
2256 {
Brandon Jonesafa75152017-07-21 13:11:29 -07002257 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ReadBufferNone);
Martin Radev138064f2016-07-15 12:03:41 +03002258 return false;
2259 }
2260
Jamie Madillb6bda4a2015-04-20 12:53:26 -04002261 const FramebufferAttachment *attachment = framebuffer->getReadColorbuffer();
Jamie Madill3c7fa222014-06-05 13:08:51 -04002262 if (!attachment)
Jamie Madill893ab082014-05-16 16:56:10 -04002263 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002264 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002265 return false;
Jamie Madill893ab082014-05-16 16:56:10 -04002266 }
2267 }
2268 break;
2269
He Yunchaoced53ae2016-11-29 15:00:51 +08002270 default:
2271 break;
Jamie Madill893ab082014-05-16 16:56:10 -04002272 }
2273
2274 // pname is valid, but there are no parameters to return
Geoff Langff5b2d52016-09-07 11:32:23 -04002275 if (*numParams == 0)
2276 {
2277 return false;
2278 }
2279
2280 return true;
2281}
2282
2283bool ValidateRobustStateQuery(ValidationContext *context,
2284 GLenum pname,
2285 GLsizei bufSize,
2286 GLenum *nativeType,
2287 unsigned int *numParams)
2288{
2289 if (!ValidateRobustEntryPoint(context, bufSize))
2290 {
2291 return false;
2292 }
2293
2294 if (!ValidateStateQuery(context, pname, nativeType, numParams))
2295 {
2296 return false;
2297 }
2298
2299 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
Jamie Madill893ab082014-05-16 16:56:10 -04002300 {
2301 return false;
2302 }
2303
2304 return true;
2305}
2306
Jamie Madillc29968b2016-01-20 11:17:23 -05002307bool ValidateCopyTexImageParametersBase(ValidationContext *context,
2308 GLenum target,
2309 GLint level,
2310 GLenum internalformat,
2311 bool isSubImage,
2312 GLint xoffset,
2313 GLint yoffset,
2314 GLint zoffset,
2315 GLint x,
2316 GLint y,
2317 GLsizei width,
2318 GLsizei height,
2319 GLint border,
Jamie Madill0c8abca2016-07-22 20:21:26 -04002320 Format *textureFormatOut)
Jamie Madill560a8d82014-05-21 13:06:20 -04002321{
Brandon Jones6cad5662017-06-14 13:25:13 -07002322 if (xoffset < 0 || yoffset < 0 || zoffset < 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04002323 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002324 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
2325 return false;
2326 }
2327
2328 if (width < 0 || height < 0)
2329 {
2330 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Geoff Langb1196682014-07-23 13:47:29 -04002331 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002332 }
2333
He Yunchaoced53ae2016-11-29 15:00:51 +08002334 if (std::numeric_limits<GLsizei>::max() - xoffset < width ||
2335 std::numeric_limits<GLsizei>::max() - yoffset < height)
Jamie Madill560a8d82014-05-21 13:06:20 -04002336 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002337 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002338 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002339 }
2340
2341 if (border != 0)
2342 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002343 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidBorder);
Geoff Langb1196682014-07-23 13:47:29 -04002344 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002345 }
2346
2347 if (!ValidMipLevel(context, target, level))
2348 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002349 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Geoff Langb1196682014-07-23 13:47:29 -04002350 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002351 }
2352
Jamie Madill51f40ec2016-06-15 14:06:00 -04002353 const auto &state = context->getGLState();
2354 auto readFramebuffer = state.getReadFramebuffer();
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002355 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill560a8d82014-05-21 13:06:20 -04002356 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002357 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002358 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002359 }
2360
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002361 if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0)
Jamie Madill560a8d82014-05-21 13:06:20 -04002362 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002363 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002364 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002365 }
2366
Martin Radev138064f2016-07-15 12:03:41 +03002367 if (readFramebuffer->getReadBufferState() == GL_NONE)
2368 {
Brandon Jonesafa75152017-07-21 13:11:29 -07002369 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ReadBufferNone);
Martin Radev138064f2016-07-15 12:03:41 +03002370 return false;
2371 }
2372
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002373 // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment
2374 // In OpenGL ES it is undefined what happens when an operation tries to read from a missing
He Yunchao66a41a22016-12-15 16:45:05 +08002375 // attachment and WebGL defines it to be an error. We do the check unconditionally as the
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002376 // situation is an application error that would lead to a crash in ANGLE.
Martin Radev04e2c3b2017-07-27 16:54:35 +03002377 const FramebufferAttachment *source = readFramebuffer->getReadColorbuffer();
2378 if (source == nullptr)
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002379 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002380 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment);
Corentin Wallez3c90ed62016-12-16 16:19:28 -05002381 return false;
2382 }
2383
Martin Radev04e2c3b2017-07-27 16:54:35 +03002384 // ANGLE_multiview spec, Revision 1:
2385 // Calling CopyTexSubImage3D, CopyTexImage2D, or CopyTexSubImage2D will result in an
2386 // INVALID_FRAMEBUFFER_OPERATION error if the multi-view layout of the current read framebuffer
2387 // is not NONE.
2388 if (source->getMultiviewLayout() != GL_NONE)
2389 {
2390 context->handleError(InvalidFramebufferOperation()
2391 << "The active read framebuffer object has multiview attachments.");
2392 return false;
2393 }
2394
Geoff Langaae65a42014-05-26 12:43:44 -04002395 const gl::Caps &caps = context->getCaps();
2396
Geoff Langaae65a42014-05-26 12:43:44 -04002397 GLuint maxDimension = 0;
Jamie Madill560a8d82014-05-21 13:06:20 -04002398 switch (target)
2399 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002400 case GL_TEXTURE_2D:
2401 maxDimension = caps.max2DTextureSize;
2402 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002403
He Yunchaoced53ae2016-11-29 15:00:51 +08002404 case GL_TEXTURE_CUBE_MAP_POSITIVE_X:
2405 case GL_TEXTURE_CUBE_MAP_NEGATIVE_X:
2406 case GL_TEXTURE_CUBE_MAP_POSITIVE_Y:
2407 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y:
2408 case GL_TEXTURE_CUBE_MAP_POSITIVE_Z:
2409 case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z:
2410 maxDimension = caps.maxCubeMapTextureSize;
2411 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002412
Corentin Wallez13c0dd42017-07-04 18:27:01 -04002413 case GL_TEXTURE_RECTANGLE_ANGLE:
2414 maxDimension = caps.maxRectangleTextureSize;
2415 break;
2416
He Yunchaoced53ae2016-11-29 15:00:51 +08002417 case GL_TEXTURE_2D_ARRAY:
2418 maxDimension = caps.max2DTextureSize;
2419 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002420
He Yunchaoced53ae2016-11-29 15:00:51 +08002421 case GL_TEXTURE_3D:
2422 maxDimension = caps.max3DTextureSize;
2423 break;
Jamie Madill560a8d82014-05-21 13:06:20 -04002424
He Yunchaoced53ae2016-11-29 15:00:51 +08002425 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002426 context->handleError(InvalidEnum());
He Yunchaoced53ae2016-11-29 15:00:51 +08002427 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002428 }
2429
Jamie Madillc29968b2016-01-20 11:17:23 -05002430 gl::Texture *texture =
2431 state.getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target);
Jamie Madill560a8d82014-05-21 13:06:20 -04002432 if (!texture)
2433 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002434 ANGLE_VALIDATION_ERR(context, InvalidOperation(), TextureNotBound);
Geoff Langb1196682014-07-23 13:47:29 -04002435 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002436 }
2437
Geoff Lang69cce582015-09-17 13:20:36 -04002438 if (texture->getImmutableFormat() && !isSubImage)
Jamie Madill560a8d82014-05-21 13:06:20 -04002439 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002440 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002441 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002442 }
2443
Geoff Langca271392017-04-05 12:30:00 -04002444 const gl::InternalFormat &formatInfo =
2445 gl::GetInternalFormatInfo(internalformat, GL_UNSIGNED_BYTE);
Geoff Lang5d601382014-07-22 15:14:06 -04002446
Geoff Lang966c9402017-04-18 12:38:27 -04002447 if (formatInfo.depthBits > 0 || formatInfo.compressed)
Jamie Madill560a8d82014-05-21 13:06:20 -04002448 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002449 context->handleError(InvalidOperation());
Geoff Langa9be0dc2014-12-17 12:34:40 -05002450 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002451 }
2452
2453 if (isSubImage)
2454 {
Geoff Langa9be0dc2014-12-17 12:34:40 -05002455 if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) ||
2456 static_cast<size_t>(yoffset + height) > texture->getHeight(target, level) ||
2457 static_cast<size_t>(zoffset) >= texture->getDepth(target, level))
Jamie Madill560a8d82014-05-21 13:06:20 -04002458 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002459 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04002460 return false;
Jamie Madill560a8d82014-05-21 13:06:20 -04002461 }
2462 }
Jamie Madill6f38f822014-06-06 17:12:20 -04002463 else
2464 {
Geoff Lang691e58c2014-12-19 17:03:25 -05002465 if (IsCubeMapTextureTarget(target) && width != height)
Jamie Madill6f38f822014-06-06 17:12:20 -04002466 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002467 ANGLE_VALIDATION_ERR(context, InvalidValue(), CubemapIncomplete);
Geoff Langb1196682014-07-23 13:47:29 -04002468 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002469 }
2470
Geoff Langeb66a6e2016-10-31 13:06:12 -04002471 if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions()))
Jamie Madill6f38f822014-06-06 17:12:20 -04002472 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002473 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langb1196682014-07-23 13:47:29 -04002474 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002475 }
2476
2477 int maxLevelDimension = (maxDimension >> level);
He Yunchaoced53ae2016-11-29 15:00:51 +08002478 if (static_cast<int>(width) > maxLevelDimension ||
2479 static_cast<int>(height) > maxLevelDimension)
Jamie Madill6f38f822014-06-06 17:12:20 -04002480 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002481 ANGLE_VALIDATION_ERR(context, InvalidValue(), ResourceMaxTextureSize);
Geoff Langb1196682014-07-23 13:47:29 -04002482 return false;
Jamie Madill6f38f822014-06-06 17:12:20 -04002483 }
2484 }
Jamie Madill560a8d82014-05-21 13:06:20 -04002485
Jamie Madill0c8abca2016-07-22 20:21:26 -04002486 if (textureFormatOut)
2487 {
2488 *textureFormatOut = texture->getFormat(target, level);
2489 }
Jamie Madillf695a3a2017-01-11 17:36:35 -05002490
2491 // Detect texture copying feedback loops for WebGL.
2492 if (context->getExtensions().webglCompatibility)
2493 {
Jamie Madillfd3dd432017-02-02 19:59:59 -05002494 if (readFramebuffer->formsCopyingFeedbackLoopWith(texture->id(), level, zoffset))
Jamie Madillf695a3a2017-01-11 17:36:35 -05002495 {
Brandon Jonesafa75152017-07-21 13:11:29 -07002496 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FeedbackLoop);
Jamie Madillf695a3a2017-01-11 17:36:35 -05002497 return false;
2498 }
2499 }
2500
Jamie Madill560a8d82014-05-21 13:06:20 -04002501 return true;
2502}
2503
Jiajia Qind9671222016-11-29 16:30:31 +08002504bool ValidateDrawBase(ValidationContext *context, GLenum mode, GLsizei count)
Jamie Madill250d33f2014-06-06 17:09:03 -04002505{
Jamie Madill1aeb1312014-06-20 13:21:25 -04002506 switch (mode)
2507 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002508 case GL_POINTS:
2509 case GL_LINES:
2510 case GL_LINE_LOOP:
2511 case GL_LINE_STRIP:
2512 case GL_TRIANGLES:
2513 case GL_TRIANGLE_STRIP:
2514 case GL_TRIANGLE_FAN:
2515 break;
2516 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002517 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidDrawMode);
He Yunchaoced53ae2016-11-29 15:00:51 +08002518 return false;
Jamie Madill1aeb1312014-06-20 13:21:25 -04002519 }
2520
Jamie Madill250d33f2014-06-06 17:09:03 -04002521 if (count < 0)
2522 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002523 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Geoff Langb1196682014-07-23 13:47:29 -04002524 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002525 }
2526
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002527 const State &state = context->getGLState();
Geoff Langb1196682014-07-23 13:47:29 -04002528
Jamie Madill250d33f2014-06-06 17:09:03 -04002529 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002530 if (state.hasMappedBuffer(GL_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04002531 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002532 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002533 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002534 }
2535
Jamie Madillcbcde722017-01-06 14:50:00 -05002536 // Note: these separate values are not supported in WebGL, due to D3D's limitations. See
2537 // Section 6.10 of the WebGL 1.0 spec.
Jamie Madill51f40ec2016-06-15 14:06:00 -04002538 Framebuffer *framebuffer = state.getDrawFramebuffer();
Martin Radevffe754b2017-07-31 10:38:07 +03002539 const Extensions &extensions = context->getExtensions();
2540 if (context->getLimitations().noSeparateStencilRefsAndMasks || extensions.webglCompatibility)
Jamie Madillac528012014-06-20 13:21:23 -04002541 {
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002542 const FramebufferAttachment *dsAttachment =
2543 framebuffer->getStencilOrDepthStencilAttachment();
2544 GLuint stencilBits = dsAttachment ? dsAttachment->getStencilSize() : 0;
He Yunchaoced53ae2016-11-29 15:00:51 +08002545 GLuint minimumRequiredStencilMask = (1 << stencilBits) - 1;
Jinyoung Hur85769f02015-10-20 17:08:44 -04002546 const DepthStencilState &depthStencilState = state.getDepthStencilState();
Corentin Wallezb1d0a2552016-12-19 16:15:54 -05002547
2548 bool differentRefs = state.getStencilRef() != state.getStencilBackRef();
2549 bool differentWritemasks =
2550 (depthStencilState.stencilWritemask & minimumRequiredStencilMask) !=
2551 (depthStencilState.stencilBackWritemask & minimumRequiredStencilMask);
2552 bool differentMasks = (depthStencilState.stencilMask & minimumRequiredStencilMask) !=
2553 (depthStencilState.stencilBackMask & minimumRequiredStencilMask);
2554
2555 if (differentRefs || differentWritemasks || differentMasks)
Geoff Lang3a86ad32015-09-01 11:47:05 -04002556 {
Martin Radevffe754b2017-07-31 10:38:07 +03002557 if (!extensions.webglCompatibility)
Jamie Madillcbcde722017-01-06 14:50:00 -05002558 {
Yuly Novikovd73f8522017-01-13 17:48:57 -05002559 ERR() << "This ANGLE implementation does not support separate front/back stencil "
2560 "writemasks, reference values, or stencil mask values.";
Jamie Madillcbcde722017-01-06 14:50:00 -05002561 }
Brandon Jones6cad5662017-06-14 13:25:13 -07002562 ANGLE_VALIDATION_ERR(context, InvalidOperation(), StencilReferenceMaskOrMismatch);
Geoff Lang3a86ad32015-09-01 11:47:05 -04002563 return false;
2564 }
Jamie Madillac528012014-06-20 13:21:23 -04002565 }
2566
Jamie Madilldd43e6c2017-03-24 14:18:49 -04002567 if (framebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
Jamie Madill13f7d7d2014-06-20 13:21:27 -04002568 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002569 context->handleError(InvalidFramebufferOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002570 return false;
Jamie Madill13f7d7d2014-06-20 13:21:27 -04002571 }
2572
Geoff Lang7dd2e102014-11-10 15:19:26 -05002573 gl::Program *program = state.getProgram();
2574 if (!program)
Jamie Madilld4cfa572014-07-08 10:00:32 -04002575 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002576 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotBound);
Geoff Langb1196682014-07-23 13:47:29 -04002577 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04002578 }
2579
Yunchao Hef81ce4a2017-04-24 10:49:17 +08002580 if (!program->validateSamplers(nullptr, context->getCaps()))
Jamie Madilld4cfa572014-07-08 10:00:32 -04002581 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002582 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002583 return false;
Jamie Madilld4cfa572014-07-08 10:00:32 -04002584 }
2585
Martin Radevffe754b2017-07-31 10:38:07 +03002586 if (extensions.multiview)
Martin Radev7cf61662017-07-26 17:10:53 +03002587 {
Martin Radevda8e2572017-09-12 17:21:16 +03002588 const int programNumViews = program->usesMultiview() ? program->getNumViews() : 1;
Martin Radev7e69f762017-07-27 14:54:13 +03002589 const int framebufferNumViews = framebuffer->getNumViews();
Martin Radevda8e2572017-09-12 17:21:16 +03002590 if (framebufferNumViews != programNumViews)
Martin Radev7cf61662017-07-26 17:10:53 +03002591 {
2592 context->handleError(InvalidOperation() << "The number of views in the active program "
2593 "and draw framebuffer does not match.");
2594 return false;
2595 }
Martin Radev7e69f762017-07-27 14:54:13 +03002596
2597 const TransformFeedback *transformFeedbackObject = state.getCurrentTransformFeedback();
2598 if (transformFeedbackObject != nullptr && transformFeedbackObject->isActive() &&
2599 framebufferNumViews > 1)
2600 {
2601 context->handleError(InvalidOperation()
2602 << "There is an active transform feedback object "
2603 "when the number of views in the active draw "
2604 "framebuffer is greater than 1.");
2605 return false;
2606 }
Martin Radevffe754b2017-07-31 10:38:07 +03002607
2608 if (extensions.disjointTimerQuery && framebufferNumViews > 1 &&
2609 state.isQueryActive(GL_TIME_ELAPSED_EXT))
2610 {
2611 context->handleError(InvalidOperation() << "There is an active query for target "
2612 "GL_TIME_ELAPSED_EXT when the number of "
2613 "views in the active draw framebuffer is "
2614 "greater than 1.");
2615 return false;
2616 }
Martin Radev7cf61662017-07-26 17:10:53 +03002617 }
2618
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002619 // Uniform buffer validation
He Yunchaoced53ae2016-11-29 15:00:51 +08002620 for (unsigned int uniformBlockIndex = 0;
2621 uniformBlockIndex < program->getActiveUniformBlockCount(); uniformBlockIndex++)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002622 {
Jiajia Qin729b2c62017-08-14 09:36:11 +08002623 const gl::InterfaceBlock &uniformBlock = program->getUniformBlockByIndex(uniformBlockIndex);
He Yunchaoced53ae2016-11-29 15:00:51 +08002624 GLuint blockBinding = program->getUniformBlockBinding(uniformBlockIndex);
Geoff Lang5d124a62015-09-15 13:03:27 -04002625 const OffsetBindingPointer<Buffer> &uniformBuffer =
2626 state.getIndexedUniformBuffer(blockBinding);
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002627
Geoff Lang5d124a62015-09-15 13:03:27 -04002628 if (uniformBuffer.get() == nullptr)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002629 {
2630 // undefined behaviour
Jamie Madill437fa652016-05-03 15:13:24 -04002631 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002632 InvalidOperation()
2633 << "It is undefined behaviour to have a used but unbound uniform buffer.");
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002634 return false;
2635 }
2636
Geoff Lang5d124a62015-09-15 13:03:27 -04002637 size_t uniformBufferSize = uniformBuffer.getSize();
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002638 if (uniformBufferSize == 0)
2639 {
2640 // Bind the whole buffer.
Minmin Gong794e0002015-04-07 18:31:54 -07002641 uniformBufferSize = static_cast<size_t>(uniformBuffer->getSize());
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002642 }
2643
Jamie Madill62d31cb2015-09-11 13:25:51 -04002644 if (uniformBufferSize < uniformBlock.dataSize)
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002645 {
2646 // undefined behaviour
Jamie Madill437fa652016-05-03 15:13:24 -04002647 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002648 InvalidOperation()
2649 << "It is undefined behaviour to use a uniform buffer that is too small.");
Gregoire Payen de La Garanderie68694e92015-03-24 14:03:37 +00002650 return false;
2651 }
2652 }
2653
Geoff Lange0cff192017-05-30 13:04:56 -04002654 // Do some additonal WebGL-specific validation
Martin Radevffe754b2017-07-31 10:38:07 +03002655 if (extensions.webglCompatibility)
Jamie Madilla4595b82017-01-11 17:36:34 -05002656 {
Geoff Lange0cff192017-05-30 13:04:56 -04002657 // Detect rendering feedback loops for WebGL.
Jamie Madilla4595b82017-01-11 17:36:34 -05002658 if (framebuffer->formsRenderingFeedbackLoopWith(state))
2659 {
Brandon Jonesafa75152017-07-21 13:11:29 -07002660 ANGLE_VALIDATION_ERR(context, InvalidOperation(), FeedbackLoop);
Jamie Madilla4595b82017-01-11 17:36:34 -05002661 return false;
2662 }
Geoff Lange0cff192017-05-30 13:04:56 -04002663
Geoff Lang9ab5b822017-05-30 16:19:23 -04002664 // Detect that the vertex shader input types match the attribute types
2665 if (!ValidateVertexShaderAttributeTypeMatch(context))
2666 {
2667 return false;
2668 }
2669
Geoff Lange0cff192017-05-30 13:04:56 -04002670 // Detect that the color buffer types match the fragment shader output types
2671 if (!ValidateFragmentShaderColorBufferTypeMatch(context))
2672 {
2673 return false;
2674 }
Jamie Madilla4595b82017-01-11 17:36:34 -05002675 }
2676
Jamie Madill250d33f2014-06-06 17:09:03 -04002677 // No-op if zero count
2678 return (count > 0);
2679}
2680
Jamie Madillc1d770e2017-04-13 17:31:24 -04002681bool ValidateDrawArraysCommon(ValidationContext *context,
2682 GLenum mode,
2683 GLint first,
2684 GLsizei count,
2685 GLsizei primcount)
Jamie Madill250d33f2014-06-06 17:09:03 -04002686{
Jamie Madillfd716582014-06-06 17:09:04 -04002687 if (first < 0)
Jamie Madill250d33f2014-06-06 17:09:03 -04002688 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002689 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeStart);
Geoff Langb1196682014-07-23 13:47:29 -04002690 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002691 }
2692
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002693 const State &state = context->getGLState();
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002694 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
He Yunchaoced53ae2016-11-29 15:00:51 +08002695 if (curTransformFeedback && curTransformFeedback->isActive() &&
2696 !curTransformFeedback->isPaused() && curTransformFeedback->getPrimitiveMode() != mode)
Jamie Madillfd716582014-06-06 17:09:04 -04002697 {
2698 // It is an invalid operation to call DrawArrays or DrawArraysInstanced with a draw mode
He Yunchaoced53ae2016-11-29 15:00:51 +08002699 // that does not match the current transform feedback object's draw mode (if transform
2700 // feedback
Jamie Madillfd716582014-06-06 17:09:04 -04002701 // is active), (3.0.2, section 2.14, pg 86)
Brandon Jones6cad5662017-06-14 13:25:13 -07002702 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidDrawModeTransformFeedback);
Geoff Langb1196682014-07-23 13:47:29 -04002703 return false;
Jamie Madillfd716582014-06-06 17:09:04 -04002704 }
2705
Jiajia Qind9671222016-11-29 16:30:31 +08002706 if (!ValidateDrawBase(context, mode, count))
Corentin Wallez18a2fb32015-08-10 12:58:14 -07002707 {
2708 return false;
2709 }
2710
Corentin Wallez71168a02016-12-19 15:11:18 -08002711 // Check the computation of maxVertex doesn't overflow.
2712 // - first < 0 or count < 0 have been checked as an error condition
2713 // - count > 0 has been checked in ValidateDrawBase as it makes the call a noop
2714 // From this we know maxVertex will be positive, and only need to check if it overflows GLint.
2715 ASSERT(count > 0 && first >= 0);
2716 int64_t maxVertex = static_cast<int64_t>(first) + static_cast<int64_t>(count) - 1;
2717 if (maxVertex > static_cast<int64_t>(std::numeric_limits<GLint>::max()))
Corentin Wallez92db6942016-12-09 13:10:36 -05002718 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002719 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallez92db6942016-12-09 13:10:36 -05002720 return false;
2721 }
2722
Corentin Wallez71168a02016-12-19 15:11:18 -08002723 if (!ValidateDrawAttribs(context, primcount, static_cast<GLint>(maxVertex), count))
Jamie Madillfd716582014-06-06 17:09:04 -04002724 {
2725 return false;
2726 }
2727
2728 return true;
2729}
2730
He Yunchaoced53ae2016-11-29 15:00:51 +08002731bool ValidateDrawArraysInstancedANGLE(Context *context,
2732 GLenum mode,
2733 GLint first,
2734 GLsizei count,
2735 GLsizei primcount)
Geoff Lang87a93302014-09-16 13:29:43 -04002736{
Geoff Lang63c5a592017-09-27 14:08:16 -04002737 if (!context->getExtensions().instancedArrays)
2738 {
2739 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
2740 return false;
2741 }
2742
Corentin Wallez170efbf2017-05-02 13:45:01 -04002743 if (!ValidateDrawArraysInstancedBase(context, mode, first, count, primcount))
Geoff Lang87a93302014-09-16 13:29:43 -04002744 {
2745 return false;
2746 }
2747
Corentin Wallez0dc97812017-06-22 14:38:44 -04002748 return ValidateDrawInstancedANGLE(context);
Geoff Lang87a93302014-09-16 13:29:43 -04002749}
2750
Jiajia Qind9671222016-11-29 16:30:31 +08002751bool ValidateDrawElementsBase(ValidationContext *context, GLenum type)
Jamie Madillfd716582014-06-06 17:09:04 -04002752{
Jamie Madill250d33f2014-06-06 17:09:03 -04002753 switch (type)
2754 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002755 case GL_UNSIGNED_BYTE:
2756 case GL_UNSIGNED_SHORT:
2757 break;
2758 case GL_UNSIGNED_INT:
2759 if (context->getClientMajorVersion() < 3 && !context->getExtensions().elementIndexUint)
2760 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002761 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte);
He Yunchaoced53ae2016-11-29 15:00:51 +08002762 return false;
2763 }
2764 break;
2765 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07002766 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TypeNotUnsignedShortByte);
He Yunchaoced53ae2016-11-29 15:00:51 +08002767 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002768 }
2769
Jamie Madilldfde6ab2016-06-09 07:07:18 -07002770 const State &state = context->getGLState();
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002771
2772 gl::TransformFeedback *curTransformFeedback = state.getCurrentTransformFeedback();
He Yunchaoced53ae2016-11-29 15:00:51 +08002773 if (curTransformFeedback && curTransformFeedback->isActive() &&
2774 !curTransformFeedback->isPaused())
Jamie Madill250d33f2014-06-06 17:09:03 -04002775 {
He Yunchaoced53ae2016-11-29 15:00:51 +08002776 // It is an invalid operation to call DrawElements, DrawRangeElements or
2777 // DrawElementsInstanced
Jamie Madill250d33f2014-06-06 17:09:03 -04002778 // while transform feedback is active, (3.0.2, section 2.14, pg 86)
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002779 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002780 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002781 }
2782
Jiajia Qind9671222016-11-29 16:30:31 +08002783 return true;
2784}
2785
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002786bool ValidateDrawElementsCommon(ValidationContext *context,
2787 GLenum mode,
2788 GLsizei count,
2789 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04002790 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002791 GLsizei primcount)
Jiajia Qind9671222016-11-29 16:30:31 +08002792{
2793 if (!ValidateDrawElementsBase(context, type))
2794 return false;
2795
2796 const State &state = context->getGLState();
2797
Corentin Wallez170efbf2017-05-02 13:45:01 -04002798 if (!ValidateDrawBase(context, mode, count))
2799 {
2800 return false;
2801 }
2802
Jamie Madill250d33f2014-06-06 17:09:03 -04002803 // Check for mapped buffers
Jamie Madilld9ba4f72014-08-04 10:47:59 -04002804 if (state.hasMappedBuffer(GL_ELEMENT_ARRAY_BUFFER))
Jamie Madill250d33f2014-06-06 17:09:03 -04002805 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002806 context->handleError(InvalidOperation() << "Index buffer is mapped.");
Geoff Langb1196682014-07-23 13:47:29 -04002807 return false;
Jamie Madill250d33f2014-06-06 17:09:03 -04002808 }
2809
He Yunchaoced53ae2016-11-29 15:00:51 +08002810 const gl::VertexArray *vao = state.getVertexArray();
Jamie Madill8e344942015-07-09 14:22:07 -04002811 gl::Buffer *elementArrayBuffer = vao->getElementArrayBuffer().get();
Jamie Madilld4cfa572014-07-08 10:00:32 -04002812
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05002813 GLuint typeBytes = gl::GetTypeInfo(type).bytes;
2814
2815 if (context->getExtensions().webglCompatibility)
2816 {
2817 ASSERT(isPow2(typeBytes) && typeBytes > 0);
2818 if ((reinterpret_cast<uintptr_t>(indices) & static_cast<uintptr_t>(typeBytes - 1)) != 0)
2819 {
2820 // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements
2821 // The offset arguments to drawElements and [...], must be a multiple of the size of the
2822 // data type passed to the call, or an INVALID_OPERATION error is generated.
Brandon Jones6cad5662017-06-14 13:25:13 -07002823 ANGLE_VALIDATION_ERR(context, InvalidOperation(), OffsetMustBeMultipleOfType);
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05002824 return false;
2825 }
Corentin Wallezfe9306a2017-02-01 17:41:05 -05002826
2827 // [WebGL 1.0] Section 6.4 Buffer Offset and Stride Requirements
2828 // In addition the offset argument to drawElements must be non-negative or an INVALID_VALUE
2829 // error is generated.
2830 if (reinterpret_cast<intptr_t>(indices) < 0)
2831 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002832 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
Corentin Wallezfe9306a2017-02-01 17:41:05 -05002833 return false;
2834 }
Geoff Langfeb8c682017-02-13 16:07:35 -05002835 }
2836
2837 if (context->getExtensions().webglCompatibility ||
2838 !context->getGLState().areClientArraysEnabled())
2839 {
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05002840 if (!elementArrayBuffer && count > 0)
2841 {
2842 // [WebGL 1.0] Section 6.2 No Client Side Arrays
2843 // If drawElements is called with a count greater than zero, and no WebGLBuffer is bound
2844 // to the ELEMENT_ARRAY_BUFFER binding point, an INVALID_OPERATION error is generated.
Brandon Jones6cad5662017-06-14 13:25:13 -07002845 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MustHaveElementArrayBinding);
Corentin Wallez3f6d4df2017-01-30 18:04:36 -05002846 return false;
2847 }
2848 }
2849
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002850 if (count > 0)
Jamie Madillae3000b2014-08-25 15:47:51 -04002851 {
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002852 if (elementArrayBuffer)
Jamie Madillae3000b2014-08-25 15:47:51 -04002853 {
Corentin Wallezfe9306a2017-02-01 17:41:05 -05002854 // The max possible type size is 8 and count is on 32 bits so doing the multiplication
2855 // in a 64 bit integer is safe. Also we are guaranteed that here count > 0.
2856 static_assert(std::is_same<int, GLsizei>::value, "GLsizei isn't the expected type");
2857 constexpr uint64_t kMaxTypeSize = 8;
2858 constexpr uint64_t kIntMax = std::numeric_limits<int>::max();
2859 constexpr uint64_t kUint64Max = std::numeric_limits<uint64_t>::max();
2860 static_assert(kIntMax < kUint64Max / kMaxTypeSize, "");
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002861
Corentin Wallezfe9306a2017-02-01 17:41:05 -05002862 uint64_t typeSize = typeBytes;
2863 uint64_t elementCount = static_cast<uint64_t>(count);
2864 ASSERT(elementCount > 0 && typeSize <= kMaxTypeSize);
2865
2866 // Doing the multiplication here is overflow-safe
2867 uint64_t elementDataSizeNoOffset = typeSize * elementCount;
2868
2869 // The offset can be any value, check for overflows
2870 uint64_t offset = static_cast<uint64_t>(reinterpret_cast<uintptr_t>(indices));
2871 if (elementDataSizeNoOffset > kUint64Max - offset)
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002872 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002873 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002874 return false;
2875 }
2876
Corentin Wallezfe9306a2017-02-01 17:41:05 -05002877 uint64_t elementDataSizeWithOffset = elementDataSizeNoOffset + offset;
2878 if (elementDataSizeWithOffset > static_cast<uint64_t>(elementArrayBuffer->getSize()))
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002879 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002880 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002881 return false;
2882 }
Brandon Jonesed5b46f2017-07-21 08:39:17 -07002883
Corentin Wallez487653b2017-09-01 17:17:55 -04002884 ASSERT(isPow2(typeSize) && typeSize > 0);
2885 if ((elementArrayBuffer->getSize() & (typeSize - 1)) != 0)
Brandon Jonesed5b46f2017-07-21 08:39:17 -07002886 {
2887 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MismatchedByteCountType);
2888 return false;
2889 }
Corentin Wallez0844f2d2017-01-31 17:02:59 -05002890 }
2891 else if (!indices)
2892 {
2893 // This is an application error that would normally result in a crash,
2894 // but we catch it and return an error
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002895 context->handleError(InvalidOperation() << "No element array buffer and no pointer.");
Geoff Langb1196682014-07-23 13:47:29 -04002896 return false;
Jamie Madillae3000b2014-08-25 15:47:51 -04002897 }
Jamie Madillae3000b2014-08-25 15:47:51 -04002898 }
2899
Jiajia Qin8a7b3a02017-08-25 16:05:48 +08002900 if (context->getExtensions().robustBufferAccessBehavior)
Corentin Wallezc1346fb2017-08-24 16:11:26 +00002901 {
Jiajia Qin8a7b3a02017-08-25 16:05:48 +08002902 // Here we use maxVertex = 0 and vertexCount = 1 to avoid retrieving IndexRange when robust
2903 // access is enabled.
2904 if (!ValidateDrawAttribs(context, primcount, 0, 1))
2905 {
2906 return false;
2907 }
2908 }
2909 else
2910 {
2911 // Use the parameter buffer to retrieve and cache the index range.
2912 const auto &params = context->getParams<HasIndexRange>();
2913 const auto &indexRangeOpt = params.getIndexRange();
2914 if (!indexRangeOpt.valid())
2915 {
2916 // Unexpected error.
2917 return false;
2918 }
2919
2920 // If we use an index greater than our maximum supported index range, return an error.
2921 // The ES3 spec does not specify behaviour here, it is undefined, but ANGLE should always
2922 // return an error if possible here.
2923 if (static_cast<GLuint64>(indexRangeOpt.value().end) >= context->getCaps().maxElementIndex)
2924 {
2925 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExceedsMaxElement);
2926 return false;
2927 }
2928
2929 if (!ValidateDrawAttribs(context, primcount, static_cast<GLint>(indexRangeOpt.value().end),
2930 static_cast<GLint>(indexRangeOpt.value().vertexCount())))
2931 {
2932 return false;
2933 }
2934
2935 // No op if there are no real indices in the index data (all are primitive restart).
2936 return (indexRangeOpt.value().vertexIndexCount > 0);
Corentin Wallezc1346fb2017-08-24 16:11:26 +00002937 }
2938
Jiajia Qin8a7b3a02017-08-25 16:05:48 +08002939 return true;
Jamie Madillfd716582014-06-06 17:09:04 -04002940}
2941
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002942bool ValidateDrawElementsInstancedCommon(ValidationContext *context,
2943 GLenum mode,
2944 GLsizei count,
2945 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04002946 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002947 GLsizei primcount)
Jamie Madillfd716582014-06-06 17:09:04 -04002948{
Corentin Wallez0dc97812017-06-22 14:38:44 -04002949 return ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount);
Jamie Madill250d33f2014-06-06 17:09:03 -04002950}
2951
Geoff Lang3edfe032015-09-04 16:38:24 -04002952bool ValidateDrawElementsInstancedANGLE(Context *context,
2953 GLenum mode,
2954 GLsizei count,
2955 GLenum type,
Jamie Madill876429b2017-04-20 15:46:24 -04002956 const void *indices,
Jamie Madill9c9b40a2017-04-26 16:31:57 -04002957 GLsizei primcount)
Geoff Lang87a93302014-09-16 13:29:43 -04002958{
Geoff Lang63c5a592017-09-27 14:08:16 -04002959 if (!context->getExtensions().instancedArrays)
2960 {
2961 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ExtensionNotEnabled);
2962 return false;
2963 }
2964
Corentin Wallez170efbf2017-05-02 13:45:01 -04002965 if (!ValidateDrawElementsInstancedBase(context, mode, count, type, indices, primcount))
Geoff Lang87a93302014-09-16 13:29:43 -04002966 {
2967 return false;
2968 }
2969
Corentin Wallez0dc97812017-06-22 14:38:44 -04002970 return ValidateDrawInstancedANGLE(context);
Geoff Lang87a93302014-09-16 13:29:43 -04002971}
2972
He Yunchaoced53ae2016-11-29 15:00:51 +08002973bool ValidateFramebufferTextureBase(Context *context,
2974 GLenum target,
2975 GLenum attachment,
2976 GLuint texture,
2977 GLint level)
Jamie Madill570f7c82014-07-03 10:38:54 -04002978{
Jamie Madill55ec3b12014-07-03 10:38:57 -04002979 if (!ValidFramebufferTarget(target))
2980 {
Brandon Jones6cad5662017-06-14 13:25:13 -07002981 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04002982 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04002983 }
2984
2985 if (!ValidateAttachmentTarget(context, attachment))
Jamie Madill570f7c82014-07-03 10:38:54 -04002986 {
2987 return false;
2988 }
2989
Jamie Madill55ec3b12014-07-03 10:38:57 -04002990 if (texture != 0)
2991 {
2992 gl::Texture *tex = context->getTexture(texture);
2993
Jamie Madillbe849e42017-05-02 15:49:00 -04002994 if (tex == NULL)
Jamie Madill55ec3b12014-07-03 10:38:57 -04002995 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05002996 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04002997 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04002998 }
2999
3000 if (level < 0)
3001 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003002 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04003003 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003004 }
3005 }
3006
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003007 const gl::Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
Jamie Madill84115c92015-04-23 15:00:07 -04003008 ASSERT(framebuffer);
Jamie Madill55ec3b12014-07-03 10:38:57 -04003009
Jamie Madill84115c92015-04-23 15:00:07 -04003010 if (framebuffer->id() == 0)
Jamie Madill55ec3b12014-07-03 10:38:57 -04003011 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003012 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langb1196682014-07-23 13:47:29 -04003013 return false;
Jamie Madill55ec3b12014-07-03 10:38:57 -04003014 }
3015
3016 return true;
3017}
3018
Geoff Langb1196682014-07-23 13:47:29 -04003019bool ValidateGetUniformBase(Context *context, GLuint program, GLint location)
Jamie Madill0063c512014-08-25 15:47:53 -04003020{
3021 if (program == 0)
3022 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003023 context->handleError(InvalidValue());
Geoff Langb1196682014-07-23 13:47:29 -04003024 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003025 }
3026
Dian Xiang769769a2015-09-09 15:20:08 -07003027 gl::Program *programObject = GetValidProgram(context, program);
3028 if (!programObject)
Shannon Woods4de4fd62014-11-07 16:22:02 -05003029 {
3030 return false;
3031 }
3032
Jamie Madill0063c512014-08-25 15:47:53 -04003033 if (!programObject || !programObject->isLinked())
3034 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003035 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Geoff Langb1196682014-07-23 13:47:29 -04003036 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003037 }
3038
Geoff Lang7dd2e102014-11-10 15:19:26 -05003039 if (!programObject->isValidUniformLocation(location))
Jamie Madill549c7fd2014-08-25 15:47:56 -04003040 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003041 context->handleError(InvalidOperation());
Geoff Langb1196682014-07-23 13:47:29 -04003042 return false;
Jamie Madill549c7fd2014-08-25 15:47:56 -04003043 }
3044
Jamie Madill0063c512014-08-25 15:47:53 -04003045 return true;
3046}
3047
Geoff Langf41d0ee2016-10-07 13:04:23 -04003048static bool ValidateSizedGetUniform(Context *context,
3049 GLuint program,
3050 GLint location,
3051 GLsizei bufSize,
3052 GLsizei *length)
Jamie Madill78f41802014-08-25 15:47:55 -04003053{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003054 if (length)
3055 {
3056 *length = 0;
3057 }
3058
Jamie Madill78f41802014-08-25 15:47:55 -04003059 if (!ValidateGetUniformBase(context, program, location))
Jamie Madill0063c512014-08-25 15:47:53 -04003060 {
Jamie Madill78f41802014-08-25 15:47:55 -04003061 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003062 }
3063
Geoff Langf41d0ee2016-10-07 13:04:23 -04003064 if (bufSize < 0)
3065 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003066 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Geoff Langf41d0ee2016-10-07 13:04:23 -04003067 return false;
3068 }
3069
Jamie Madilla502c742014-08-28 17:19:13 -04003070 gl::Program *programObject = context->getProgram(program);
3071 ASSERT(programObject);
Jamie Madill0063c512014-08-25 15:47:53 -04003072
Jamie Madill78f41802014-08-25 15:47:55 -04003073 // sized queries -- ensure the provided buffer is large enough
Jamie Madill62d31cb2015-09-11 13:25:51 -04003074 const LinkedUniform &uniform = programObject->getUniformByLocation(location);
He Yunchaoced53ae2016-11-29 15:00:51 +08003075 size_t requiredBytes = VariableExternalSize(uniform.type);
Jamie Madill78f41802014-08-25 15:47:55 -04003076 if (static_cast<size_t>(bufSize) < requiredBytes)
Jamie Madill0063c512014-08-25 15:47:53 -04003077 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003078 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Geoff Langb1196682014-07-23 13:47:29 -04003079 return false;
Jamie Madill0063c512014-08-25 15:47:53 -04003080 }
3081
Geoff Langf41d0ee2016-10-07 13:04:23 -04003082 if (length)
3083 {
Geoff Lang94177fb2016-11-14 16:12:26 -05003084 *length = VariableComponentCount(uniform.type);
Geoff Langf41d0ee2016-10-07 13:04:23 -04003085 }
3086
Jamie Madill0063c512014-08-25 15:47:53 -04003087 return true;
3088}
3089
He Yunchaoced53ae2016-11-29 15:00:51 +08003090bool ValidateGetnUniformfvEXT(Context *context,
3091 GLuint program,
3092 GLint location,
3093 GLsizei bufSize,
3094 GLfloat *params)
Jamie Madill0063c512014-08-25 15:47:53 -04003095{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003096 return ValidateSizedGetUniform(context, program, location, bufSize, nullptr);
Jamie Madill0063c512014-08-25 15:47:53 -04003097}
3098
He Yunchaoced53ae2016-11-29 15:00:51 +08003099bool ValidateGetnUniformivEXT(Context *context,
3100 GLuint program,
3101 GLint location,
3102 GLsizei bufSize,
3103 GLint *params)
Jamie Madill0063c512014-08-25 15:47:53 -04003104{
Geoff Langf41d0ee2016-10-07 13:04:23 -04003105 return ValidateSizedGetUniform(context, program, location, bufSize, nullptr);
3106}
3107
3108bool ValidateGetUniformfvRobustANGLE(Context *context,
3109 GLuint program,
3110 GLint location,
3111 GLsizei bufSize,
3112 GLsizei *length,
3113 GLfloat *params)
3114{
3115 if (!ValidateRobustEntryPoint(context, bufSize))
3116 {
3117 return false;
3118 }
3119
3120 // bufSize is validated in ValidateSizedGetUniform
3121 return ValidateSizedGetUniform(context, program, location, bufSize, length);
3122}
3123
3124bool ValidateGetUniformivRobustANGLE(Context *context,
3125 GLuint program,
3126 GLint location,
3127 GLsizei bufSize,
3128 GLsizei *length,
3129 GLint *params)
3130{
3131 if (!ValidateRobustEntryPoint(context, bufSize))
3132 {
3133 return false;
3134 }
3135
3136 // bufSize is validated in ValidateSizedGetUniform
3137 return ValidateSizedGetUniform(context, program, location, bufSize, length);
3138}
3139
3140bool ValidateGetUniformuivRobustANGLE(Context *context,
3141 GLuint program,
3142 GLint location,
3143 GLsizei bufSize,
3144 GLsizei *length,
3145 GLuint *params)
3146{
3147 if (!ValidateRobustEntryPoint(context, bufSize))
3148 {
3149 return false;
3150 }
3151
3152 if (context->getClientMajorVersion() < 3)
3153 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08003154 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required);
Geoff Langf41d0ee2016-10-07 13:04:23 -04003155 return false;
3156 }
3157
3158 // bufSize is validated in ValidateSizedGetUniform
3159 return ValidateSizedGetUniform(context, program, location, bufSize, length);
Jamie Madill0063c512014-08-25 15:47:53 -04003160}
3161
He Yunchaoced53ae2016-11-29 15:00:51 +08003162bool ValidateDiscardFramebufferBase(Context *context,
3163 GLenum target,
3164 GLsizei numAttachments,
3165 const GLenum *attachments,
3166 bool defaultFramebuffer)
Austin Kinross08332632015-05-05 13:35:47 -07003167{
3168 if (numAttachments < 0)
3169 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003170 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeAttachments);
Austin Kinross08332632015-05-05 13:35:47 -07003171 return false;
3172 }
3173
3174 for (GLsizei i = 0; i < numAttachments; ++i)
3175 {
Olli Etuaho84c9f592016-03-09 14:37:25 +02003176 if (attachments[i] >= GL_COLOR_ATTACHMENT0 && attachments[i] <= GL_COLOR_ATTACHMENT31)
Austin Kinross08332632015-05-05 13:35:47 -07003177 {
3178 if (defaultFramebuffer)
3179 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003180 ANGLE_VALIDATION_ERR(context, InvalidEnum(), DefaultFramebufferInvalidAttachment);
Austin Kinross08332632015-05-05 13:35:47 -07003181 return false;
3182 }
3183
3184 if (attachments[i] >= GL_COLOR_ATTACHMENT0 + context->getCaps().maxColorAttachments)
3185 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003186 context->handleError(InvalidOperation() << "Requested color attachment is "
3187 "greater than the maximum supported "
3188 "color attachments");
Austin Kinross08332632015-05-05 13:35:47 -07003189 return false;
3190 }
3191 }
3192 else
3193 {
3194 switch (attachments[i])
3195 {
He Yunchaoced53ae2016-11-29 15:00:51 +08003196 case GL_DEPTH_ATTACHMENT:
3197 case GL_STENCIL_ATTACHMENT:
3198 case GL_DEPTH_STENCIL_ATTACHMENT:
3199 if (defaultFramebuffer)
3200 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003201 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
3202 DefaultFramebufferInvalidAttachment);
He Yunchaoced53ae2016-11-29 15:00:51 +08003203 return false;
3204 }
3205 break;
3206 case GL_COLOR:
3207 case GL_DEPTH:
3208 case GL_STENCIL:
3209 if (!defaultFramebuffer)
3210 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003211 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
3212 DefaultFramebufferInvalidAttachment);
He Yunchaoced53ae2016-11-29 15:00:51 +08003213 return false;
3214 }
3215 break;
3216 default:
Brandon Jonesafa75152017-07-21 13:11:29 -07003217 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidAttachment);
Austin Kinross08332632015-05-05 13:35:47 -07003218 return false;
Austin Kinross08332632015-05-05 13:35:47 -07003219 }
3220 }
3221 }
3222
3223 return true;
3224}
3225
Austin Kinross6ee1e782015-05-29 17:05:37 -07003226bool ValidateInsertEventMarkerEXT(Context *context, GLsizei length, const char *marker)
3227{
3228 // Note that debug marker calls must not set error state
3229
3230 if (length < 0)
3231 {
3232 return false;
3233 }
3234
3235 if (marker == nullptr)
3236 {
3237 return false;
3238 }
3239
3240 return true;
3241}
3242
3243bool ValidatePushGroupMarkerEXT(Context *context, GLsizei length, const char *marker)
3244{
3245 // Note that debug marker calls must not set error state
3246
3247 if (length < 0)
3248 {
3249 return false;
3250 }
3251
3252 if (length > 0 && marker == nullptr)
3253 {
3254 return false;
3255 }
3256
3257 return true;
3258}
3259
Geoff Langdcab33b2015-07-21 13:03:16 -04003260bool ValidateEGLImageTargetTexture2DOES(Context *context,
Geoff Langdcab33b2015-07-21 13:03:16 -04003261 GLenum target,
3262 egl::Image *image)
3263{
Geoff Langa8406172015-07-21 16:53:39 -04003264 if (!context->getExtensions().eglImage && !context->getExtensions().eglImageExternal)
3265 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003266 context->handleError(InvalidOperation());
Geoff Langa8406172015-07-21 16:53:39 -04003267 return false;
3268 }
3269
3270 switch (target)
3271 {
3272 case GL_TEXTURE_2D:
Geoff Langb66a9092016-05-16 15:59:14 -04003273 if (!context->getExtensions().eglImage)
3274 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003275 context->handleError(InvalidEnum()
3276 << "GL_TEXTURE_2D texture target requires GL_OES_EGL_image.");
Geoff Langb66a9092016-05-16 15:59:14 -04003277 }
3278 break;
3279
3280 case GL_TEXTURE_EXTERNAL_OES:
3281 if (!context->getExtensions().eglImageExternal)
3282 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003283 context->handleError(InvalidEnum() << "GL_TEXTURE_EXTERNAL_OES texture target "
3284 "requires GL_OES_EGL_image_external.");
Geoff Langb66a9092016-05-16 15:59:14 -04003285 }
Geoff Langa8406172015-07-21 16:53:39 -04003286 break;
3287
3288 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003289 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Geoff Langa8406172015-07-21 16:53:39 -04003290 return false;
3291 }
3292
Jamie Madill61e16b42017-06-19 11:13:23 -04003293 ASSERT(context->getCurrentDisplay());
3294 if (!context->getCurrentDisplay()->isValidImage(image))
Geoff Langa8406172015-07-21 16:53:39 -04003295 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003296 context->handleError(InvalidValue() << "EGL image is not valid.");
Geoff Langa8406172015-07-21 16:53:39 -04003297 return false;
3298 }
3299
3300 if (image->getSamples() > 0)
3301 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003302 context->handleError(InvalidOperation()
3303 << "cannot create a 2D texture from a multisampled EGL image.");
Geoff Langa8406172015-07-21 16:53:39 -04003304 return false;
3305 }
3306
Geoff Langca271392017-04-05 12:30:00 -04003307 const TextureCaps &textureCaps =
3308 context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat);
Geoff Langa8406172015-07-21 16:53:39 -04003309 if (!textureCaps.texturable)
3310 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003311 context->handleError(InvalidOperation()
3312 << "EGL image internal format is not supported as a texture.");
Geoff Langa8406172015-07-21 16:53:39 -04003313 return false;
3314 }
3315
Geoff Langdcab33b2015-07-21 13:03:16 -04003316 return true;
3317}
3318
3319bool ValidateEGLImageTargetRenderbufferStorageOES(Context *context,
Geoff Langdcab33b2015-07-21 13:03:16 -04003320 GLenum target,
3321 egl::Image *image)
3322{
Geoff Langa8406172015-07-21 16:53:39 -04003323 if (!context->getExtensions().eglImage)
3324 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003325 context->handleError(InvalidOperation());
Geoff Langa8406172015-07-21 16:53:39 -04003326 return false;
3327 }
3328
3329 switch (target)
3330 {
3331 case GL_RENDERBUFFER:
3332 break;
3333
3334 default:
Brandon Jonesafa75152017-07-21 13:11:29 -07003335 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
Geoff Langa8406172015-07-21 16:53:39 -04003336 return false;
3337 }
3338
Jamie Madill61e16b42017-06-19 11:13:23 -04003339 ASSERT(context->getCurrentDisplay());
3340 if (!context->getCurrentDisplay()->isValidImage(image))
Geoff Langa8406172015-07-21 16:53:39 -04003341 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003342 context->handleError(InvalidValue() << "EGL image is not valid.");
Geoff Langa8406172015-07-21 16:53:39 -04003343 return false;
3344 }
3345
Geoff Langca271392017-04-05 12:30:00 -04003346 const TextureCaps &textureCaps =
3347 context->getTextureCaps().get(image->getFormat().info->sizedInternalFormat);
Geoff Langa8406172015-07-21 16:53:39 -04003348 if (!textureCaps.renderable)
3349 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003350 context->handleError(InvalidOperation()
3351 << "EGL image internal format is not supported as a renderbuffer.");
Geoff Langa8406172015-07-21 16:53:39 -04003352 return false;
3353 }
3354
Geoff Langdcab33b2015-07-21 13:03:16 -04003355 return true;
3356}
Austin Kinrossbc781f32015-10-26 09:27:38 -07003357
3358bool ValidateBindVertexArrayBase(Context *context, GLuint array)
3359{
Geoff Lang36167ab2015-12-07 10:27:14 -05003360 if (!context->isVertexArrayGenerated(array))
Austin Kinrossbc781f32015-10-26 09:27:38 -07003361 {
3362 // The default VAO should always exist
3363 ASSERT(array != 0);
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003364 context->handleError(InvalidOperation());
Austin Kinrossbc781f32015-10-26 09:27:38 -07003365 return false;
3366 }
3367
3368 return true;
3369}
3370
Geoff Langc5629752015-12-07 16:29:04 -05003371bool ValidateProgramBinaryBase(Context *context,
3372 GLuint program,
3373 GLenum binaryFormat,
3374 const void *binary,
3375 GLint length)
3376{
3377 Program *programObject = GetValidProgram(context, program);
3378 if (programObject == nullptr)
3379 {
3380 return false;
3381 }
3382
3383 const std::vector<GLenum> &programBinaryFormats = context->getCaps().programBinaryFormats;
3384 if (std::find(programBinaryFormats.begin(), programBinaryFormats.end(), binaryFormat) ==
3385 programBinaryFormats.end())
3386 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003387 context->handleError(InvalidEnum() << "Program binary format is not valid.");
Geoff Langc5629752015-12-07 16:29:04 -05003388 return false;
3389 }
3390
Olli Etuahoc3e55a42016-03-09 16:29:18 +02003391 if (context->hasActiveTransformFeedback(program))
3392 {
3393 // ES 3.0.4 section 2.15 page 91
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003394 context->handleError(InvalidOperation() << "Cannot change program binary while program "
3395 "is associated with an active transform "
3396 "feedback object.");
Olli Etuahoc3e55a42016-03-09 16:29:18 +02003397 return false;
3398 }
3399
Geoff Langc5629752015-12-07 16:29:04 -05003400 return true;
3401}
3402
3403bool ValidateGetProgramBinaryBase(Context *context,
3404 GLuint program,
3405 GLsizei bufSize,
3406 GLsizei *length,
3407 GLenum *binaryFormat,
3408 void *binary)
3409{
3410 Program *programObject = GetValidProgram(context, program);
3411 if (programObject == nullptr)
3412 {
3413 return false;
3414 }
3415
3416 if (!programObject->isLinked())
3417 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003418 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ProgramNotLinked);
Geoff Langc5629752015-12-07 16:29:04 -05003419 return false;
3420 }
3421
Jamie Madilla7d12dc2016-12-13 15:08:19 -05003422 if (context->getCaps().programBinaryFormats.empty())
3423 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003424 context->handleError(InvalidOperation() << "No program binary formats supported.");
Jamie Madilla7d12dc2016-12-13 15:08:19 -05003425 return false;
3426 }
3427
Geoff Langc5629752015-12-07 16:29:04 -05003428 return true;
3429}
Jamie Madillc29968b2016-01-20 11:17:23 -05003430
Jamie Madillc29968b2016-01-20 11:17:23 -05003431bool ValidateDrawBuffersBase(ValidationContext *context, GLsizei n, const GLenum *bufs)
3432{
3433 // INVALID_VALUE is generated if n is negative or greater than value of MAX_DRAW_BUFFERS
Brandon Jonesafa75152017-07-21 13:11:29 -07003434 if (n < 0)
Jamie Madillc29968b2016-01-20 11:17:23 -05003435 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003436 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
3437 return false;
3438 }
3439 if (static_cast<GLuint>(n) > context->getCaps().maxDrawBuffers)
3440 {
3441 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxDrawBuffer);
Jamie Madillc29968b2016-01-20 11:17:23 -05003442 return false;
3443 }
3444
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003445 ASSERT(context->getGLState().getDrawFramebuffer());
3446 GLuint frameBufferId = context->getGLState().getDrawFramebuffer()->id();
Jamie Madillc29968b2016-01-20 11:17:23 -05003447 GLuint maxColorAttachment = GL_COLOR_ATTACHMENT0_EXT + context->getCaps().maxColorAttachments;
3448
3449 // This should come first before the check for the default frame buffer
3450 // because when we switch to ES3.1+, invalid enums will return INVALID_ENUM
3451 // rather than INVALID_OPERATION
3452 for (int colorAttachment = 0; colorAttachment < n; colorAttachment++)
3453 {
3454 const GLenum attachment = GL_COLOR_ATTACHMENT0_EXT + colorAttachment;
3455
3456 if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != GL_BACK &&
Olli Etuaho84c9f592016-03-09 14:37:25 +02003457 (bufs[colorAttachment] < GL_COLOR_ATTACHMENT0 ||
3458 bufs[colorAttachment] > GL_COLOR_ATTACHMENT31))
Jamie Madillc29968b2016-01-20 11:17:23 -05003459 {
3460 // Value in bufs is not NONE, BACK, or GL_COLOR_ATTACHMENTi
Olli Etuaho84c9f592016-03-09 14:37:25 +02003461 // The 3.0.4 spec says to generate GL_INVALID_OPERATION here, but this
3462 // was changed to GL_INVALID_ENUM in 3.1, which dEQP also expects.
3463 // 3.1 is still a bit ambiguous about the error, but future specs are
3464 // expected to clarify that GL_INVALID_ENUM is the correct error.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003465 context->handleError(InvalidEnum() << "Invalid buffer value");
Olli Etuaho84c9f592016-03-09 14:37:25 +02003466 return false;
3467 }
3468 else if (bufs[colorAttachment] >= maxColorAttachment)
3469 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003470 context->handleError(InvalidOperation()
3471 << "Buffer value is greater than MAX_DRAW_BUFFERS");
Jamie Madillc29968b2016-01-20 11:17:23 -05003472 return false;
3473 }
3474 else if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != attachment &&
3475 frameBufferId != 0)
3476 {
3477 // INVALID_OPERATION-GL is bound to buffer and ith argument
3478 // is not COLOR_ATTACHMENTi or NONE
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003479 context->handleError(InvalidOperation()
3480 << "Ith value does not match COLOR_ATTACHMENTi or NONE");
Jamie Madillc29968b2016-01-20 11:17:23 -05003481 return false;
3482 }
3483 }
3484
3485 // INVALID_OPERATION is generated if GL is bound to the default framebuffer
3486 // and n is not 1 or bufs is bound to value other than BACK and NONE
3487 if (frameBufferId == 0)
3488 {
3489 if (n != 1)
3490 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003491 context->handleError(InvalidOperation()
3492 << "n must be 1 when GL is bound to the default framebuffer");
Jamie Madillc29968b2016-01-20 11:17:23 -05003493 return false;
3494 }
3495
3496 if (bufs[0] != GL_NONE && bufs[0] != GL_BACK)
3497 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003498 context->handleError(
3499 InvalidOperation()
3500 << "Only NONE or BACK are valid values when drawing to the default framebuffer");
Jamie Madillc29968b2016-01-20 11:17:23 -05003501 return false;
3502 }
3503 }
3504
3505 return true;
3506}
3507
Geoff Lang496c02d2016-10-20 11:38:11 -07003508bool ValidateGetBufferPointervBase(Context *context,
3509 GLenum target,
3510 GLenum pname,
3511 GLsizei *length,
3512 void **params)
Olli Etuaho4f667482016-03-30 15:56:35 +03003513{
Geoff Lang496c02d2016-10-20 11:38:11 -07003514 if (length)
3515 {
3516 *length = 0;
3517 }
3518
3519 if (context->getClientMajorVersion() < 3 && !context->getExtensions().mapBuffer)
3520 {
3521 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003522 InvalidOperation()
3523 << "Context does not support OpenGL ES 3.0 or GL_OES_mapbuffer is not enabled.");
Geoff Lang496c02d2016-10-20 11:38:11 -07003524 return false;
3525 }
3526
Olli Etuaho4f667482016-03-30 15:56:35 +03003527 if (!ValidBufferTarget(context, target))
3528 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003529 context->handleError(InvalidEnum() << "Buffer target not valid: 0x" << std::hex
3530 << std::uppercase << target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003531 return false;
3532 }
3533
Geoff Lang496c02d2016-10-20 11:38:11 -07003534 switch (pname)
Olli Etuaho4f667482016-03-30 15:56:35 +03003535 {
Geoff Lang496c02d2016-10-20 11:38:11 -07003536 case GL_BUFFER_MAP_POINTER:
3537 break;
Olli Etuaho4f667482016-03-30 15:56:35 +03003538
Geoff Lang496c02d2016-10-20 11:38:11 -07003539 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07003540 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Lang496c02d2016-10-20 11:38:11 -07003541 return false;
3542 }
Olli Etuaho4f667482016-03-30 15:56:35 +03003543
3544 // GLES 3.0 section 2.10.1: "Attempts to attempts to modify or query buffer object state for a
3545 // target bound to zero generate an INVALID_OPERATION error."
3546 // GLES 3.1 section 6.6 explicitly specifies this error.
Geoff Lang496c02d2016-10-20 11:38:11 -07003547 if (context->getGLState().getTargetBuffer(target) == nullptr)
Olli Etuaho4f667482016-03-30 15:56:35 +03003548 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003549 context->handleError(InvalidOperation()
3550 << "Can not get pointer for reserved buffer name zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003551 return false;
3552 }
3553
Geoff Lang496c02d2016-10-20 11:38:11 -07003554 if (length)
3555 {
3556 *length = 1;
3557 }
3558
Olli Etuaho4f667482016-03-30 15:56:35 +03003559 return true;
3560}
3561
3562bool ValidateUnmapBufferBase(Context *context, GLenum target)
3563{
3564 if (!ValidBufferTarget(context, target))
3565 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003566 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003567 return false;
3568 }
3569
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003570 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003571
3572 if (buffer == nullptr || !buffer->isMapped())
3573 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003574 context->handleError(InvalidOperation() << "Buffer not mapped.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003575 return false;
3576 }
3577
3578 return true;
3579}
3580
3581bool ValidateMapBufferRangeBase(Context *context,
3582 GLenum target,
3583 GLintptr offset,
3584 GLsizeiptr length,
3585 GLbitfield access)
3586{
3587 if (!ValidBufferTarget(context, target))
3588 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003589 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003590 return false;
3591 }
3592
Brandon Jones6cad5662017-06-14 13:25:13 -07003593 if (offset < 0)
Olli Etuaho4f667482016-03-30 15:56:35 +03003594 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003595 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
3596 return false;
3597 }
3598
3599 if (length < 0)
3600 {
3601 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength);
Olli Etuaho4f667482016-03-30 15:56:35 +03003602 return false;
3603 }
3604
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003605 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003606
3607 if (!buffer)
3608 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003609 context->handleError(InvalidOperation() << "Attempted to map buffer object zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003610 return false;
3611 }
3612
3613 // Check for buffer overflow
Jamie Madille2e406c2016-06-02 13:04:10 -04003614 CheckedNumeric<size_t> checkedOffset(offset);
3615 auto checkedSize = checkedOffset + length;
Olli Etuaho4f667482016-03-30 15:56:35 +03003616
Jamie Madille2e406c2016-06-02 13:04:10 -04003617 if (!checkedSize.IsValid() || checkedSize.ValueOrDie() > static_cast<size_t>(buffer->getSize()))
Olli Etuaho4f667482016-03-30 15:56:35 +03003618 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003619 context->handleError(InvalidValue() << "Mapped range does not fit into buffer dimensions.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003620 return false;
3621 }
3622
3623 // Check for invalid bits in the mask
3624 GLbitfield allAccessBits = GL_MAP_READ_BIT | GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_RANGE_BIT |
3625 GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_FLUSH_EXPLICIT_BIT |
3626 GL_MAP_UNSYNCHRONIZED_BIT;
3627
3628 if (access & ~(allAccessBits))
3629 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003630 context->handleError(InvalidValue()
3631 << "Invalid access bits: 0x" << std::hex << std::uppercase << access);
Olli Etuaho4f667482016-03-30 15:56:35 +03003632 return false;
3633 }
3634
3635 if (length == 0)
3636 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003637 context->handleError(InvalidOperation() << "Buffer mapping length is zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003638 return false;
3639 }
3640
3641 if (buffer->isMapped())
3642 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003643 context->handleError(InvalidOperation() << "Buffer is already mapped.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003644 return false;
3645 }
3646
3647 // Check for invalid bit combinations
3648 if ((access & (GL_MAP_READ_BIT | GL_MAP_WRITE_BIT)) == 0)
3649 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003650 context->handleError(InvalidOperation()
3651 << "Need to map buffer for either reading or writing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003652 return false;
3653 }
3654
3655 GLbitfield writeOnlyBits =
3656 GL_MAP_INVALIDATE_RANGE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT | GL_MAP_UNSYNCHRONIZED_BIT;
3657
3658 if ((access & GL_MAP_READ_BIT) != 0 && (access & writeOnlyBits) != 0)
3659 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003660 context->handleError(InvalidOperation()
3661 << "Invalid access bits when mapping buffer for reading: 0x"
3662 << std::hex << std::uppercase << access);
Olli Etuaho4f667482016-03-30 15:56:35 +03003663 return false;
3664 }
3665
3666 if ((access & GL_MAP_WRITE_BIT) == 0 && (access & GL_MAP_FLUSH_EXPLICIT_BIT) != 0)
3667 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003668 context->handleError(
3669 InvalidOperation()
3670 << "The explicit flushing bit may only be set if the buffer is mapped for writing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003671 return false;
3672 }
Geoff Lang79f71042017-08-14 16:43:43 -04003673
3674 return ValidateMapBufferBase(context, target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003675}
3676
3677bool ValidateFlushMappedBufferRangeBase(Context *context,
3678 GLenum target,
3679 GLintptr offset,
3680 GLsizeiptr length)
3681{
Brandon Jones6cad5662017-06-14 13:25:13 -07003682 if (offset < 0)
Olli Etuaho4f667482016-03-30 15:56:35 +03003683 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003684 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeOffset);
3685 return false;
3686 }
3687
3688 if (length < 0)
3689 {
3690 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeLength);
Olli Etuaho4f667482016-03-30 15:56:35 +03003691 return false;
3692 }
3693
3694 if (!ValidBufferTarget(context, target))
3695 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003696 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Olli Etuaho4f667482016-03-30 15:56:35 +03003697 return false;
3698 }
3699
Jamie Madilldfde6ab2016-06-09 07:07:18 -07003700 Buffer *buffer = context->getGLState().getTargetBuffer(target);
Olli Etuaho4f667482016-03-30 15:56:35 +03003701
3702 if (buffer == nullptr)
3703 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003704 context->handleError(InvalidOperation() << "Attempted to flush buffer object zero.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003705 return false;
3706 }
3707
3708 if (!buffer->isMapped() || (buffer->getAccessFlags() & GL_MAP_FLUSH_EXPLICIT_BIT) == 0)
3709 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003710 context->handleError(InvalidOperation()
3711 << "Attempted to flush a buffer not mapped for explicit flushing.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003712 return false;
3713 }
3714
3715 // Check for buffer overflow
Jamie Madille2e406c2016-06-02 13:04:10 -04003716 CheckedNumeric<size_t> checkedOffset(offset);
3717 auto checkedSize = checkedOffset + length;
Olli Etuaho4f667482016-03-30 15:56:35 +03003718
Jamie Madille2e406c2016-06-02 13:04:10 -04003719 if (!checkedSize.IsValid() ||
3720 checkedSize.ValueOrDie() > static_cast<size_t>(buffer->getMapLength()))
Olli Etuaho4f667482016-03-30 15:56:35 +03003721 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003722 context->handleError(InvalidValue()
3723 << "Flushed range does not fit into buffer mapping dimensions.");
Olli Etuaho4f667482016-03-30 15:56:35 +03003724 return false;
3725 }
3726
3727 return true;
3728}
3729
Olli Etuaho41997e72016-03-10 13:38:39 +02003730bool ValidateGenOrDelete(Context *context, GLint n)
3731{
3732 if (n < 0)
3733 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003734 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeCount);
Olli Etuaho41997e72016-03-10 13:38:39 +02003735 return false;
3736 }
3737 return true;
3738}
3739
Geoff Langff5b2d52016-09-07 11:32:23 -04003740bool ValidateRobustEntryPoint(ValidationContext *context, GLsizei bufSize)
3741{
3742 if (!context->getExtensions().robustClientMemory)
3743 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003744 context->handleError(InvalidOperation()
3745 << "GL_ANGLE_robust_client_memory is not available.");
Geoff Langff5b2d52016-09-07 11:32:23 -04003746 return false;
3747 }
3748
3749 if (bufSize < 0)
3750 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003751 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeBufferSize);
Geoff Langff5b2d52016-09-07 11:32:23 -04003752 return false;
3753 }
3754
3755 return true;
3756}
3757
Geoff Lang2e43dbb2016-10-14 12:27:35 -04003758bool ValidateRobustBufferSize(ValidationContext *context, GLsizei bufSize, GLsizei numParams)
3759{
3760 if (bufSize < numParams)
3761 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003762 context->handleError(InvalidOperation() << numParams << " parameters are required but "
3763 << bufSize << " were provided.");
Geoff Lang2e43dbb2016-10-14 12:27:35 -04003764 return false;
3765 }
3766
3767 return true;
3768}
3769
Jamie Madillbe849e42017-05-02 15:49:00 -04003770bool ValidateGetFramebufferAttachmentParameterivBase(ValidationContext *context,
3771 GLenum target,
3772 GLenum attachment,
3773 GLenum pname,
3774 GLsizei *numParams)
Geoff Langff5b2d52016-09-07 11:32:23 -04003775{
Geoff Langff5b2d52016-09-07 11:32:23 -04003776 if (!ValidFramebufferTarget(target))
3777 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003778 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003779 return false;
3780 }
3781
3782 int clientVersion = context->getClientMajorVersion();
3783
3784 switch (pname)
3785 {
3786 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
3787 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
3788 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL:
3789 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE:
3790 break;
3791
Martin Radeve5285d22017-07-14 16:23:53 +03003792 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_NUM_VIEWS_ANGLE:
3793 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_MULTIVIEW_LAYOUT_ANGLE:
3794 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_BASE_VIEW_INDEX_ANGLE:
3795 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE:
3796 if (clientVersion < 3 || !context->getExtensions().multiview)
3797 {
3798 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
3799 return false;
3800 }
3801 break;
3802
Geoff Langff5b2d52016-09-07 11:32:23 -04003803 case GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING:
3804 if (clientVersion < 3 && !context->getExtensions().sRGB)
3805 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003806 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003807 return false;
3808 }
3809 break;
3810
3811 case GL_FRAMEBUFFER_ATTACHMENT_RED_SIZE:
3812 case GL_FRAMEBUFFER_ATTACHMENT_GREEN_SIZE:
3813 case GL_FRAMEBUFFER_ATTACHMENT_BLUE_SIZE:
3814 case GL_FRAMEBUFFER_ATTACHMENT_ALPHA_SIZE:
3815 case GL_FRAMEBUFFER_ATTACHMENT_DEPTH_SIZE:
3816 case GL_FRAMEBUFFER_ATTACHMENT_STENCIL_SIZE:
3817 case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:
3818 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:
3819 if (clientVersion < 3)
3820 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003821 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003822 return false;
3823 }
3824 break;
3825
3826 default:
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003827 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003828 return false;
3829 }
3830
3831 // Determine if the attachment is a valid enum
3832 switch (attachment)
3833 {
3834 case GL_BACK:
3835 case GL_FRONT:
3836 case GL_DEPTH:
3837 case GL_STENCIL:
3838 case GL_DEPTH_STENCIL_ATTACHMENT:
3839 if (clientVersion < 3)
3840 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003841 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003842 return false;
3843 }
3844 break;
3845
3846 case GL_DEPTH_ATTACHMENT:
3847 case GL_STENCIL_ATTACHMENT:
3848 break;
3849
3850 default:
3851 if (attachment < GL_COLOR_ATTACHMENT0_EXT ||
3852 (attachment - GL_COLOR_ATTACHMENT0_EXT) >= context->getCaps().maxColorAttachments)
3853 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003854 context->handleError(InvalidEnum());
Geoff Langff5b2d52016-09-07 11:32:23 -04003855 return false;
3856 }
3857 break;
3858 }
3859
3860 const Framebuffer *framebuffer = context->getGLState().getTargetFramebuffer(target);
3861 ASSERT(framebuffer);
3862
3863 if (framebuffer->id() == 0)
3864 {
3865 if (clientVersion < 3)
3866 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003867 ANGLE_VALIDATION_ERR(context, InvalidOperation(), DefaultFramebufferTarget);
Geoff Langff5b2d52016-09-07 11:32:23 -04003868 return false;
3869 }
3870
3871 switch (attachment)
3872 {
3873 case GL_BACK:
3874 case GL_DEPTH:
3875 case GL_STENCIL:
3876 break;
3877
3878 default:
Brandon Jonesafa75152017-07-21 13:11:29 -07003879 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003880 return false;
3881 }
3882 }
3883 else
3884 {
3885 if (attachment >= GL_COLOR_ATTACHMENT0_EXT && attachment <= GL_COLOR_ATTACHMENT15_EXT)
3886 {
3887 // Valid attachment query
3888 }
3889 else
3890 {
3891 switch (attachment)
3892 {
3893 case GL_DEPTH_ATTACHMENT:
3894 case GL_STENCIL_ATTACHMENT:
3895 break;
3896
3897 case GL_DEPTH_STENCIL_ATTACHMENT:
3898 if (!framebuffer->hasValidDepthStencil())
3899 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05003900 context->handleError(InvalidOperation());
Geoff Langff5b2d52016-09-07 11:32:23 -04003901 return false;
3902 }
3903 break;
3904
3905 default:
Brandon Jonesafa75152017-07-21 13:11:29 -07003906 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003907 return false;
3908 }
3909 }
3910 }
3911
3912 const FramebufferAttachment *attachmentObject = framebuffer->getAttachment(attachment);
3913 if (attachmentObject)
3914 {
3915 ASSERT(attachmentObject->type() == GL_RENDERBUFFER ||
3916 attachmentObject->type() == GL_TEXTURE ||
3917 attachmentObject->type() == GL_FRAMEBUFFER_DEFAULT);
3918
3919 switch (pname)
3920 {
3921 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
3922 if (attachmentObject->type() != GL_RENDERBUFFER &&
3923 attachmentObject->type() != GL_TEXTURE)
3924 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003925 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003926 return false;
3927 }
3928 break;
3929
3930 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL:
3931 if (attachmentObject->type() != GL_TEXTURE)
3932 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003933 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003934 return false;
3935 }
3936 break;
3937
3938 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_CUBE_MAP_FACE:
3939 if (attachmentObject->type() != GL_TEXTURE)
3940 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003941 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003942 return false;
3943 }
3944 break;
3945
3946 case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:
3947 if (attachment == GL_DEPTH_STENCIL_ATTACHMENT)
3948 {
Brandon Jonesafa75152017-07-21 13:11:29 -07003949 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003950 return false;
3951 }
3952 break;
3953
3954 case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:
3955 if (attachmentObject->type() != GL_TEXTURE)
3956 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003957 ANGLE_VALIDATION_ERR(context, InvalidEnum(), FramebufferIncompleteAttachment);
Geoff Langff5b2d52016-09-07 11:32:23 -04003958 return false;
3959 }
3960 break;
3961
3962 default:
3963 break;
3964 }
3965 }
3966 else
3967 {
3968 // ES 2.0.25 spec pg 127 states that if the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE
3969 // is NONE, then querying any other pname will generate INVALID_ENUM.
3970
3971 // ES 3.0.2 spec pg 235 states that if the attachment type is none,
3972 // GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME will return zero and be an
3973 // INVALID_OPERATION for all other pnames
3974
3975 switch (pname)
3976 {
3977 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE:
3978 break;
3979
3980 case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:
3981 if (clientVersion < 3)
3982 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003983 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
Brandon Jonesafa75152017-07-21 13:11:29 -07003984 InvalidFramebufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04003985 return false;
3986 }
3987 break;
3988
3989 default:
3990 if (clientVersion < 3)
3991 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003992 ANGLE_VALIDATION_ERR(context, InvalidEnum(),
Brandon Jonesafa75152017-07-21 13:11:29 -07003993 InvalidFramebufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04003994 return false;
3995 }
3996 else
3997 {
Brandon Jones6cad5662017-06-14 13:25:13 -07003998 ANGLE_VALIDATION_ERR(context, InvalidOperation(),
Brandon Jonesafa75152017-07-21 13:11:29 -07003999 InvalidFramebufferTextureParameter);
Geoff Langff5b2d52016-09-07 11:32:23 -04004000 return false;
4001 }
4002 }
4003 }
4004
Martin Radeve5285d22017-07-14 16:23:53 +03004005 if (numParams)
4006 {
4007 if (pname == GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_VIEWPORT_OFFSETS_ANGLE)
4008 {
4009 // Only when the viewport offsets are queried we can have a varying number of output
4010 // parameters.
4011 const int numViews = attachmentObject ? attachmentObject->getNumViews() : 1;
4012 *numParams = numViews * 2;
4013 }
4014 else
4015 {
4016 // For all other queries we can have only one output parameter.
4017 *numParams = 1;
4018 }
4019 }
4020
Geoff Langff5b2d52016-09-07 11:32:23 -04004021 return true;
4022}
4023
4024bool ValidateGetFramebufferAttachmentParameterivRobustANGLE(ValidationContext *context,
4025 GLenum target,
4026 GLenum attachment,
4027 GLenum pname,
4028 GLsizei bufSize,
4029 GLsizei *numParams)
4030{
4031 if (!ValidateRobustEntryPoint(context, bufSize))
4032 {
4033 return false;
4034 }
4035
Jamie Madillbe849e42017-05-02 15:49:00 -04004036 if (!ValidateGetFramebufferAttachmentParameterivBase(context, target, attachment, pname,
4037 numParams))
Geoff Langff5b2d52016-09-07 11:32:23 -04004038 {
4039 return false;
4040 }
4041
4042 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
4043 {
4044 return false;
4045 }
4046
4047 return true;
4048}
4049
Geoff Langff5b2d52016-09-07 11:32:23 -04004050bool ValidateGetBufferParameterivRobustANGLE(ValidationContext *context,
4051 GLenum target,
4052 GLenum pname,
4053 GLsizei bufSize,
Geoff Langebebe1c2016-10-14 12:01:31 -04004054 GLsizei *length,
4055 GLint *params)
Geoff Langff5b2d52016-09-07 11:32:23 -04004056{
4057 if (!ValidateRobustEntryPoint(context, bufSize))
4058 {
4059 return false;
4060 }
4061
Geoff Langebebe1c2016-10-14 12:01:31 -04004062 if (!ValidateGetBufferParameterBase(context, target, pname, false, length))
Geoff Langff5b2d52016-09-07 11:32:23 -04004063 {
4064 return false;
4065 }
4066
Geoff Langebebe1c2016-10-14 12:01:31 -04004067 if (!ValidateRobustBufferSize(context, bufSize, *length))
4068 {
4069 return false;
4070 }
4071
4072 return true;
4073}
4074
Geoff Langebebe1c2016-10-14 12:01:31 -04004075bool ValidateGetBufferParameteri64vRobustANGLE(ValidationContext *context,
4076 GLenum target,
4077 GLenum pname,
4078 GLsizei bufSize,
4079 GLsizei *length,
4080 GLint64 *params)
4081{
4082 if (!ValidateRobustEntryPoint(context, bufSize))
4083 {
4084 return false;
4085 }
4086
4087 if (!ValidateGetBufferParameterBase(context, target, pname, false, length))
4088 {
4089 return false;
4090 }
4091
4092 if (!ValidateRobustBufferSize(context, bufSize, *length))
Geoff Langff5b2d52016-09-07 11:32:23 -04004093 {
4094 return false;
4095 }
4096
4097 return true;
4098}
4099
Jamie Madillbe849e42017-05-02 15:49:00 -04004100bool ValidateGetProgramivBase(ValidationContext *context,
4101 GLuint program,
4102 GLenum pname,
4103 GLsizei *numParams)
Geoff Langff5b2d52016-09-07 11:32:23 -04004104{
4105 // Currently, all GetProgramiv queries return 1 parameter
Yunchao He33151a52017-04-13 09:58:17 +08004106 if (numParams)
4107 {
4108 *numParams = 1;
4109 }
Geoff Langff5b2d52016-09-07 11:32:23 -04004110
4111 Program *programObject = GetValidProgram(context, program);
4112 if (!programObject)
4113 {
4114 return false;
4115 }
4116
4117 switch (pname)
4118 {
4119 case GL_DELETE_STATUS:
4120 case GL_LINK_STATUS:
4121 case GL_VALIDATE_STATUS:
4122 case GL_INFO_LOG_LENGTH:
4123 case GL_ATTACHED_SHADERS:
4124 case GL_ACTIVE_ATTRIBUTES:
4125 case GL_ACTIVE_ATTRIBUTE_MAX_LENGTH:
4126 case GL_ACTIVE_UNIFORMS:
4127 case GL_ACTIVE_UNIFORM_MAX_LENGTH:
4128 break;
4129
4130 case GL_PROGRAM_BINARY_LENGTH:
4131 if (context->getClientMajorVersion() < 3 && !context->getExtensions().getProgramBinary)
4132 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004133 context->handleError(InvalidEnum() << "Querying GL_PROGRAM_BINARY_LENGTH "
4134 "requires GL_OES_get_program_binary or "
4135 "ES 3.0.");
Geoff Langff5b2d52016-09-07 11:32:23 -04004136 return false;
4137 }
4138 break;
4139
4140 case GL_ACTIVE_UNIFORM_BLOCKS:
4141 case GL_ACTIVE_UNIFORM_BLOCK_MAX_NAME_LENGTH:
4142 case GL_TRANSFORM_FEEDBACK_BUFFER_MODE:
4143 case GL_TRANSFORM_FEEDBACK_VARYINGS:
4144 case GL_TRANSFORM_FEEDBACK_VARYING_MAX_LENGTH:
4145 case GL_PROGRAM_BINARY_RETRIEVABLE_HINT:
4146 if (context->getClientMajorVersion() < 3)
4147 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08004148 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ES3Required);
Geoff Langff5b2d52016-09-07 11:32:23 -04004149 return false;
4150 }
4151 break;
4152
Yunchao He61afff12017-03-14 15:34:03 +08004153 case GL_PROGRAM_SEPARABLE:
Xinghua Cao971f8502017-10-17 13:01:24 +08004154 case GL_COMPUTE_WORK_GROUP_SIZE:
Yunchao He61afff12017-03-14 15:34:03 +08004155 if (context->getClientVersion() < Version(3, 1))
4156 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08004157 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ES31Required);
Yunchao He61afff12017-03-14 15:34:03 +08004158 return false;
4159 }
4160 break;
4161
Geoff Langff5b2d52016-09-07 11:32:23 -04004162 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004163 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Geoff Langff5b2d52016-09-07 11:32:23 -04004164 return false;
4165 }
4166
4167 return true;
4168}
4169
4170bool ValidateGetProgramivRobustANGLE(Context *context,
4171 GLuint program,
4172 GLenum pname,
4173 GLsizei bufSize,
4174 GLsizei *numParams)
4175{
4176 if (!ValidateRobustEntryPoint(context, bufSize))
4177 {
4178 return false;
4179 }
4180
Jamie Madillbe849e42017-05-02 15:49:00 -04004181 if (!ValidateGetProgramivBase(context, program, pname, numParams))
Geoff Langff5b2d52016-09-07 11:32:23 -04004182 {
4183 return false;
4184 }
4185
4186 if (!ValidateRobustBufferSize(context, bufSize, *numParams))
4187 {
4188 return false;
4189 }
4190
4191 return true;
4192}
4193
Geoff Lang740d9022016-10-07 11:20:52 -04004194bool ValidateGetRenderbufferParameterivRobustANGLE(Context *context,
4195 GLenum target,
4196 GLenum pname,
4197 GLsizei bufSize,
4198 GLsizei *length,
4199 GLint *params)
4200{
4201 if (!ValidateRobustEntryPoint(context, bufSize))
4202 {
4203 return false;
4204 }
4205
4206 if (!ValidateGetRenderbufferParameterivBase(context, target, pname, length))
4207 {
4208 return false;
4209 }
4210
4211 if (!ValidateRobustBufferSize(context, bufSize, *length))
4212 {
4213 return false;
4214 }
4215
4216 return true;
4217}
4218
Geoff Langd7d0ed32016-10-07 11:33:51 -04004219bool ValidateGetShaderivRobustANGLE(Context *context,
4220 GLuint shader,
4221 GLenum pname,
4222 GLsizei bufSize,
4223 GLsizei *length,
4224 GLint *params)
4225{
4226 if (!ValidateRobustEntryPoint(context, bufSize))
4227 {
4228 return false;
4229 }
4230
4231 if (!ValidateGetShaderivBase(context, shader, pname, length))
4232 {
4233 return false;
4234 }
4235
4236 if (!ValidateRobustBufferSize(context, bufSize, *length))
4237 {
4238 return false;
4239 }
4240
4241 return true;
4242}
4243
Geoff Langc1984ed2016-10-07 12:41:00 -04004244bool ValidateGetTexParameterfvRobustANGLE(Context *context,
4245 GLenum target,
4246 GLenum pname,
4247 GLsizei bufSize,
4248 GLsizei *length,
4249 GLfloat *params)
4250{
4251 if (!ValidateRobustEntryPoint(context, bufSize))
4252 {
4253 return false;
4254 }
4255
4256 if (!ValidateGetTexParameterBase(context, target, pname, length))
4257 {
4258 return false;
4259 }
4260
4261 if (!ValidateRobustBufferSize(context, bufSize, *length))
4262 {
4263 return false;
4264 }
4265
4266 return true;
4267}
4268
Geoff Langc1984ed2016-10-07 12:41:00 -04004269bool ValidateGetTexParameterivRobustANGLE(Context *context,
4270 GLenum target,
4271 GLenum pname,
4272 GLsizei bufSize,
4273 GLsizei *length,
4274 GLint *params)
4275{
4276 if (!ValidateRobustEntryPoint(context, bufSize))
4277 {
4278 return false;
4279 }
4280
4281 if (!ValidateGetTexParameterBase(context, target, pname, length))
4282 {
4283 return false;
4284 }
4285
4286 if (!ValidateRobustBufferSize(context, bufSize, *length))
4287 {
4288 return false;
4289 }
4290
4291 return true;
4292}
4293
Geoff Langc1984ed2016-10-07 12:41:00 -04004294bool ValidateTexParameterfvRobustANGLE(Context *context,
4295 GLenum target,
4296 GLenum pname,
4297 GLsizei bufSize,
4298 const GLfloat *params)
4299{
4300 if (!ValidateRobustEntryPoint(context, bufSize))
4301 {
4302 return false;
4303 }
4304
4305 return ValidateTexParameterBase(context, target, pname, bufSize, params);
4306}
4307
Geoff Langc1984ed2016-10-07 12:41:00 -04004308bool ValidateTexParameterivRobustANGLE(Context *context,
4309 GLenum target,
4310 GLenum pname,
4311 GLsizei bufSize,
4312 const GLint *params)
4313{
4314 if (!ValidateRobustEntryPoint(context, bufSize))
4315 {
4316 return false;
4317 }
4318
4319 return ValidateTexParameterBase(context, target, pname, bufSize, params);
4320}
4321
Geoff Langc1984ed2016-10-07 12:41:00 -04004322bool ValidateGetSamplerParameterfvRobustANGLE(Context *context,
4323 GLuint sampler,
4324 GLenum pname,
4325 GLuint bufSize,
4326 GLsizei *length,
4327 GLfloat *params)
4328{
4329 if (!ValidateRobustEntryPoint(context, bufSize))
4330 {
4331 return false;
4332 }
4333
4334 if (!ValidateGetSamplerParameterBase(context, sampler, pname, length))
4335 {
4336 return false;
4337 }
4338
4339 if (!ValidateRobustBufferSize(context, bufSize, *length))
4340 {
4341 return false;
4342 }
4343
4344 return true;
4345}
4346
Geoff Langc1984ed2016-10-07 12:41:00 -04004347bool ValidateGetSamplerParameterivRobustANGLE(Context *context,
4348 GLuint sampler,
4349 GLenum pname,
4350 GLuint bufSize,
4351 GLsizei *length,
4352 GLint *params)
4353{
4354 if (!ValidateRobustEntryPoint(context, bufSize))
4355 {
4356 return false;
4357 }
4358
4359 if (!ValidateGetSamplerParameterBase(context, sampler, pname, length))
4360 {
4361 return false;
4362 }
4363
4364 if (!ValidateRobustBufferSize(context, bufSize, *length))
4365 {
4366 return false;
4367 }
4368
4369 return true;
4370}
4371
Geoff Langc1984ed2016-10-07 12:41:00 -04004372bool ValidateSamplerParameterfvRobustANGLE(Context *context,
4373 GLuint sampler,
4374 GLenum pname,
4375 GLsizei bufSize,
4376 const GLfloat *params)
4377{
4378 if (!ValidateRobustEntryPoint(context, bufSize))
4379 {
4380 return false;
4381 }
4382
4383 return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params);
4384}
4385
Geoff Langc1984ed2016-10-07 12:41:00 -04004386bool ValidateSamplerParameterivRobustANGLE(Context *context,
4387 GLuint sampler,
4388 GLenum pname,
4389 GLsizei bufSize,
4390 const GLint *params)
4391{
4392 if (!ValidateRobustEntryPoint(context, bufSize))
4393 {
4394 return false;
4395 }
4396
4397 return ValidateSamplerParameterBase(context, sampler, pname, bufSize, params);
4398}
4399
Geoff Lang0b031062016-10-13 14:30:04 -04004400bool ValidateGetVertexAttribfvRobustANGLE(Context *context,
4401 GLuint index,
4402 GLenum pname,
4403 GLsizei bufSize,
4404 GLsizei *length,
4405 GLfloat *params)
4406{
4407 if (!ValidateRobustEntryPoint(context, bufSize))
4408 {
4409 return false;
4410 }
4411
4412 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false))
4413 {
4414 return false;
4415 }
4416
4417 if (!ValidateRobustBufferSize(context, bufSize, *length))
4418 {
4419 return false;
4420 }
4421
4422 return true;
4423}
4424
Geoff Lang0b031062016-10-13 14:30:04 -04004425bool ValidateGetVertexAttribivRobustANGLE(Context *context,
4426 GLuint index,
4427 GLenum pname,
4428 GLsizei bufSize,
4429 GLsizei *length,
4430 GLint *params)
4431{
4432 if (!ValidateRobustEntryPoint(context, bufSize))
4433 {
4434 return false;
4435 }
4436
4437 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, false))
4438 {
4439 return false;
4440 }
4441
4442 if (!ValidateRobustBufferSize(context, bufSize, *length))
4443 {
4444 return false;
4445 }
4446
4447 return true;
4448}
4449
Geoff Lang0b031062016-10-13 14:30:04 -04004450bool ValidateGetVertexAttribPointervRobustANGLE(Context *context,
4451 GLuint index,
4452 GLenum pname,
4453 GLsizei bufSize,
4454 GLsizei *length,
4455 void **pointer)
4456{
4457 if (!ValidateRobustEntryPoint(context, bufSize))
4458 {
4459 return false;
4460 }
4461
4462 if (!ValidateGetVertexAttribBase(context, index, pname, length, true, false))
4463 {
4464 return false;
4465 }
4466
4467 if (!ValidateRobustBufferSize(context, bufSize, *length))
4468 {
4469 return false;
4470 }
4471
4472 return true;
4473}
4474
Geoff Lang0b031062016-10-13 14:30:04 -04004475bool ValidateGetVertexAttribIivRobustANGLE(Context *context,
4476 GLuint index,
4477 GLenum pname,
4478 GLsizei bufSize,
4479 GLsizei *length,
4480 GLint *params)
4481{
4482 if (!ValidateRobustEntryPoint(context, bufSize))
4483 {
4484 return false;
4485 }
4486
4487 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true))
4488 {
4489 return false;
4490 }
4491
4492 if (!ValidateRobustBufferSize(context, bufSize, *length))
4493 {
4494 return false;
4495 }
4496
4497 return true;
4498}
4499
Geoff Lang0b031062016-10-13 14:30:04 -04004500bool ValidateGetVertexAttribIuivRobustANGLE(Context *context,
4501 GLuint index,
4502 GLenum pname,
4503 GLsizei bufSize,
4504 GLsizei *length,
4505 GLuint *params)
4506{
4507 if (!ValidateRobustEntryPoint(context, bufSize))
4508 {
4509 return false;
4510 }
4511
4512 if (!ValidateGetVertexAttribBase(context, index, pname, length, false, true))
4513 {
4514 return false;
4515 }
4516
4517 if (!ValidateRobustBufferSize(context, bufSize, *length))
4518 {
4519 return false;
4520 }
4521
4522 return true;
4523}
4524
Geoff Lang6899b872016-10-14 11:30:13 -04004525bool ValidateGetActiveUniformBlockivRobustANGLE(Context *context,
4526 GLuint program,
4527 GLuint uniformBlockIndex,
4528 GLenum pname,
4529 GLsizei bufSize,
4530 GLsizei *length,
4531 GLint *params)
4532{
4533 if (!ValidateRobustEntryPoint(context, bufSize))
4534 {
4535 return false;
4536 }
4537
4538 if (!ValidateGetActiveUniformBlockivBase(context, program, uniformBlockIndex, pname, length))
4539 {
4540 return false;
4541 }
4542
4543 if (!ValidateRobustBufferSize(context, bufSize, *length))
4544 {
4545 return false;
4546 }
4547
4548 return true;
4549}
4550
Geoff Lang0a9661f2016-10-20 10:59:20 -07004551bool ValidateGetInternalFormativRobustANGLE(Context *context,
4552 GLenum target,
4553 GLenum internalformat,
4554 GLenum pname,
4555 GLsizei bufSize,
4556 GLsizei *length,
4557 GLint *params)
4558{
4559 if (!ValidateRobustEntryPoint(context, bufSize))
4560 {
4561 return false;
4562 }
4563
4564 if (!ValidateGetInternalFormativBase(context, target, internalformat, pname, bufSize, length))
4565 {
4566 return false;
4567 }
4568
4569 if (!ValidateRobustBufferSize(context, bufSize, *length))
4570 {
4571 return false;
4572 }
4573
4574 return true;
4575}
4576
Shao80957d92017-02-20 21:25:59 +08004577bool ValidateVertexFormatBase(ValidationContext *context,
4578 GLuint attribIndex,
4579 GLint size,
4580 GLenum type,
4581 GLboolean pureInteger)
4582{
4583 const Caps &caps = context->getCaps();
4584 if (attribIndex >= caps.maxVertexAttributes)
4585 {
Brandon Jonesafa75152017-07-21 13:11:29 -07004586 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxVertexAttribute);
Shao80957d92017-02-20 21:25:59 +08004587 return false;
4588 }
4589
4590 if (size < 1 || size > 4)
4591 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004592 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidVertexAttrSize);
Geoff Lang8700a982017-06-13 10:15:13 -04004593 return false;
Shao80957d92017-02-20 21:25:59 +08004594 }
4595
4596 switch (type)
4597 {
4598 case GL_BYTE:
4599 case GL_UNSIGNED_BYTE:
4600 case GL_SHORT:
4601 case GL_UNSIGNED_SHORT:
4602 break;
4603
4604 case GL_INT:
4605 case GL_UNSIGNED_INT:
4606 if (context->getClientMajorVersion() < 3)
4607 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004608 context->handleError(InvalidEnum()
4609 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004610 return false;
4611 }
4612 break;
4613
4614 case GL_FIXED:
4615 case GL_FLOAT:
4616 if (pureInteger)
4617 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004618 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004619 return false;
4620 }
4621 break;
4622
4623 case GL_HALF_FLOAT:
4624 if (context->getClientMajorVersion() < 3)
4625 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004626 context->handleError(InvalidEnum()
4627 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004628 return false;
4629 }
4630 if (pureInteger)
4631 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004632 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004633 return false;
4634 }
4635 break;
4636
4637 case GL_INT_2_10_10_10_REV:
4638 case GL_UNSIGNED_INT_2_10_10_10_REV:
4639 if (context->getClientMajorVersion() < 3)
4640 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004641 context->handleError(InvalidEnum()
4642 << "Vertex type not supported before OpenGL ES 3.0.");
Shao80957d92017-02-20 21:25:59 +08004643 return false;
4644 }
4645 if (pureInteger)
4646 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004647 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTypePureInt);
Shao80957d92017-02-20 21:25:59 +08004648 return false;
4649 }
4650 if (size != 4)
4651 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004652 context->handleError(InvalidOperation() << "Type is INT_2_10_10_10_REV or "
4653 "UNSIGNED_INT_2_10_10_10_REV and "
4654 "size is not 4.");
Shao80957d92017-02-20 21:25:59 +08004655 return false;
4656 }
4657 break;
4658
4659 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004660 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidType);
Shao80957d92017-02-20 21:25:59 +08004661 return false;
4662 }
4663
4664 return true;
4665}
4666
Geoff Lang76e65652017-03-27 14:58:02 -04004667// Perform validation from WebGL 2 section 5.10 "Invalid Clears":
4668// In the WebGL 2 API, trying to perform a clear when there is a mismatch between the type of the
4669// specified clear value and the type of a buffer that is being cleared generates an
4670// INVALID_OPERATION error instead of producing undefined results
4671bool ValidateWebGLFramebufferAttachmentClearType(ValidationContext *context,
4672 GLint drawbuffer,
4673 const GLenum *validComponentTypes,
4674 size_t validComponentTypeCount)
4675{
4676 const FramebufferAttachment *attachment =
4677 context->getGLState().getDrawFramebuffer()->getDrawBuffer(drawbuffer);
4678 if (attachment)
4679 {
4680 GLenum componentType = attachment->getFormat().info->componentType;
4681 const GLenum *end = validComponentTypes + validComponentTypeCount;
4682 if (std::find(validComponentTypes, end, componentType) == end)
4683 {
4684 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004685 InvalidOperation()
4686 << "No defined conversion between clear value and attachment format.");
Geoff Lang76e65652017-03-27 14:58:02 -04004687 return false;
4688 }
4689 }
4690
4691 return true;
4692}
4693
Corentin Wallezb2931602017-04-11 15:58:57 -04004694bool ValidateRobustCompressedTexImageBase(ValidationContext *context,
4695 GLsizei imageSize,
4696 GLsizei dataSize)
4697{
4698 if (!ValidateRobustEntryPoint(context, dataSize))
4699 {
4700 return false;
4701 }
4702
4703 gl::Buffer *pixelUnpackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_UNPACK_BUFFER);
4704 if (pixelUnpackBuffer == nullptr)
4705 {
4706 if (dataSize < imageSize)
4707 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004708 context->handleError(InvalidOperation() << "dataSize must be at least " << imageSize);
Corentin Wallezb2931602017-04-11 15:58:57 -04004709 }
4710 }
4711 return true;
4712}
4713
Jamie Madillbe849e42017-05-02 15:49:00 -04004714bool ValidateGetBufferParameterBase(ValidationContext *context,
4715 GLenum target,
4716 GLenum pname,
4717 bool pointerVersion,
4718 GLsizei *numParams)
4719{
4720 if (numParams)
4721 {
4722 *numParams = 0;
4723 }
4724
4725 if (!ValidBufferTarget(context, target))
4726 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004727 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidBufferTypes);
Jamie Madillbe849e42017-05-02 15:49:00 -04004728 return false;
4729 }
4730
4731 const Buffer *buffer = context->getGLState().getTargetBuffer(target);
4732 if (!buffer)
4733 {
4734 // A null buffer means that "0" is bound to the requested buffer target
Brandon Jones6cad5662017-06-14 13:25:13 -07004735 ANGLE_VALIDATION_ERR(context, InvalidOperation(), BufferNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04004736 return false;
4737 }
4738
4739 const Extensions &extensions = context->getExtensions();
4740
4741 switch (pname)
4742 {
4743 case GL_BUFFER_USAGE:
4744 case GL_BUFFER_SIZE:
4745 break;
4746
4747 case GL_BUFFER_ACCESS_OES:
4748 if (!extensions.mapBuffer)
4749 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004750 context->handleError(InvalidEnum()
4751 << "pname requires OpenGL ES 3.0 or GL_OES_mapbuffer.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004752 return false;
4753 }
4754 break;
4755
4756 case GL_BUFFER_MAPPED:
4757 static_assert(GL_BUFFER_MAPPED == GL_BUFFER_MAPPED_OES, "GL enums should be equal.");
4758 if (context->getClientMajorVersion() < 3 && !extensions.mapBuffer &&
4759 !extensions.mapBufferRange)
4760 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004761 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0, "
4762 "GL_OES_mapbuffer or "
4763 "GL_EXT_map_buffer_range.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004764 return false;
4765 }
4766 break;
4767
4768 case GL_BUFFER_MAP_POINTER:
4769 if (!pointerVersion)
4770 {
4771 context->handleError(
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004772 InvalidEnum()
4773 << "GL_BUFFER_MAP_POINTER can only be queried with GetBufferPointerv.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004774 return false;
4775 }
4776 break;
4777
4778 case GL_BUFFER_ACCESS_FLAGS:
4779 case GL_BUFFER_MAP_OFFSET:
4780 case GL_BUFFER_MAP_LENGTH:
4781 if (context->getClientMajorVersion() < 3 && !extensions.mapBufferRange)
4782 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004783 context->handleError(InvalidEnum()
4784 << "pname requires OpenGL ES 3.0 or GL_EXT_map_buffer_range.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004785 return false;
4786 }
4787 break;
4788
4789 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004790 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04004791 return false;
4792 }
4793
4794 // All buffer parameter queries return one value.
4795 if (numParams)
4796 {
4797 *numParams = 1;
4798 }
4799
4800 return true;
4801}
4802
4803bool ValidateGetRenderbufferParameterivBase(Context *context,
4804 GLenum target,
4805 GLenum pname,
4806 GLsizei *length)
4807{
4808 if (length)
4809 {
4810 *length = 0;
4811 }
4812
4813 if (target != GL_RENDERBUFFER)
4814 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004815 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidRenderbufferTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04004816 return false;
4817 }
4818
4819 Renderbuffer *renderbuffer = context->getGLState().getCurrentRenderbuffer();
4820 if (renderbuffer == nullptr)
4821 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004822 ANGLE_VALIDATION_ERR(context, InvalidOperation(), RenderbufferNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04004823 return false;
4824 }
4825
4826 switch (pname)
4827 {
4828 case GL_RENDERBUFFER_WIDTH:
4829 case GL_RENDERBUFFER_HEIGHT:
4830 case GL_RENDERBUFFER_INTERNAL_FORMAT:
4831 case GL_RENDERBUFFER_RED_SIZE:
4832 case GL_RENDERBUFFER_GREEN_SIZE:
4833 case GL_RENDERBUFFER_BLUE_SIZE:
4834 case GL_RENDERBUFFER_ALPHA_SIZE:
4835 case GL_RENDERBUFFER_DEPTH_SIZE:
4836 case GL_RENDERBUFFER_STENCIL_SIZE:
4837 break;
4838
4839 case GL_RENDERBUFFER_SAMPLES_ANGLE:
4840 if (!context->getExtensions().framebufferMultisample)
4841 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004842 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04004843 return false;
4844 }
4845 break;
4846
4847 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004848 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04004849 return false;
4850 }
4851
4852 if (length)
4853 {
4854 *length = 1;
4855 }
4856 return true;
4857}
4858
4859bool ValidateGetShaderivBase(Context *context, GLuint shader, GLenum pname, GLsizei *length)
4860{
4861 if (length)
4862 {
4863 *length = 0;
4864 }
4865
4866 if (GetValidShader(context, shader) == nullptr)
4867 {
4868 return false;
4869 }
4870
4871 switch (pname)
4872 {
4873 case GL_SHADER_TYPE:
4874 case GL_DELETE_STATUS:
4875 case GL_COMPILE_STATUS:
4876 case GL_INFO_LOG_LENGTH:
4877 case GL_SHADER_SOURCE_LENGTH:
4878 break;
4879
4880 case GL_TRANSLATED_SHADER_SOURCE_LENGTH_ANGLE:
4881 if (!context->getExtensions().translatedShaderSource)
4882 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004883 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04004884 return false;
4885 }
4886 break;
4887
4888 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004889 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04004890 return false;
4891 }
4892
4893 if (length)
4894 {
4895 *length = 1;
4896 }
4897 return true;
4898}
4899
4900bool ValidateGetTexParameterBase(Context *context, GLenum target, GLenum pname, GLsizei *length)
4901{
4902 if (length)
4903 {
4904 *length = 0;
4905 }
4906
4907 if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
4908 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004909 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04004910 return false;
4911 }
4912
4913 if (context->getTargetTexture(target) == nullptr)
4914 {
4915 // Should only be possible for external textures
Brandon Jones6cad5662017-06-14 13:25:13 -07004916 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04004917 return false;
4918 }
4919
4920 switch (pname)
4921 {
4922 case GL_TEXTURE_MAG_FILTER:
4923 case GL_TEXTURE_MIN_FILTER:
4924 case GL_TEXTURE_WRAP_S:
4925 case GL_TEXTURE_WRAP_T:
4926 break;
4927
4928 case GL_TEXTURE_USAGE_ANGLE:
4929 if (!context->getExtensions().textureUsage)
4930 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004931 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04004932 return false;
4933 }
4934 break;
4935
4936 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
4937 if (!context->getExtensions().textureFilterAnisotropic)
4938 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004939 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04004940 return false;
4941 }
4942 break;
4943
4944 case GL_TEXTURE_IMMUTABLE_FORMAT:
4945 if (context->getClientMajorVersion() < 3 && !context->getExtensions().textureStorage)
4946 {
Brandon Jones6cad5662017-06-14 13:25:13 -07004947 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ExtensionNotEnabled);
Jamie Madillbe849e42017-05-02 15:49:00 -04004948 return false;
4949 }
4950 break;
4951
4952 case GL_TEXTURE_WRAP_R:
4953 case GL_TEXTURE_IMMUTABLE_LEVELS:
4954 case GL_TEXTURE_SWIZZLE_R:
4955 case GL_TEXTURE_SWIZZLE_G:
4956 case GL_TEXTURE_SWIZZLE_B:
4957 case GL_TEXTURE_SWIZZLE_A:
4958 case GL_TEXTURE_BASE_LEVEL:
4959 case GL_TEXTURE_MAX_LEVEL:
4960 case GL_TEXTURE_MIN_LOD:
4961 case GL_TEXTURE_MAX_LOD:
4962 case GL_TEXTURE_COMPARE_MODE:
4963 case GL_TEXTURE_COMPARE_FUNC:
4964 if (context->getClientMajorVersion() < 3)
4965 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004966 context->handleError(InvalidEnum() << "pname requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004967 return false;
4968 }
4969 break;
4970
4971 case GL_TEXTURE_SRGB_DECODE_EXT:
4972 if (!context->getExtensions().textureSRGBDecode)
4973 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05004974 context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled.");
Jamie Madillbe849e42017-05-02 15:49:00 -04004975 return false;
4976 }
4977 break;
4978
4979 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07004980 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04004981 return false;
4982 }
4983
4984 if (length)
4985 {
4986 *length = 1;
4987 }
4988 return true;
4989}
4990
4991bool ValidateGetVertexAttribBase(Context *context,
4992 GLuint index,
4993 GLenum pname,
4994 GLsizei *length,
4995 bool pointer,
4996 bool pureIntegerEntryPoint)
4997{
4998 if (length)
4999 {
5000 *length = 0;
5001 }
5002
5003 if (pureIntegerEntryPoint && context->getClientMajorVersion() < 3)
5004 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005005 context->handleError(InvalidOperation() << "Context does not support OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005006 return false;
5007 }
5008
5009 if (index >= context->getCaps().maxVertexAttributes)
5010 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005011 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxVertexAttribute);
Jamie Madillbe849e42017-05-02 15:49:00 -04005012 return false;
5013 }
5014
5015 if (pointer)
5016 {
5017 if (pname != GL_VERTEX_ATTRIB_ARRAY_POINTER)
5018 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005019 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005020 return false;
5021 }
5022 }
5023 else
5024 {
5025 switch (pname)
5026 {
5027 case GL_VERTEX_ATTRIB_ARRAY_ENABLED:
5028 case GL_VERTEX_ATTRIB_ARRAY_SIZE:
5029 case GL_VERTEX_ATTRIB_ARRAY_STRIDE:
5030 case GL_VERTEX_ATTRIB_ARRAY_TYPE:
5031 case GL_VERTEX_ATTRIB_ARRAY_NORMALIZED:
5032 case GL_VERTEX_ATTRIB_ARRAY_BUFFER_BINDING:
5033 case GL_CURRENT_VERTEX_ATTRIB:
5034 break;
5035
5036 case GL_VERTEX_ATTRIB_ARRAY_DIVISOR:
5037 static_assert(
5038 GL_VERTEX_ATTRIB_ARRAY_DIVISOR == GL_VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE,
5039 "ANGLE extension enums not equal to GL enums.");
5040 if (context->getClientMajorVersion() < 3 &&
5041 !context->getExtensions().instancedArrays)
5042 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005043 context->handleError(InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_DIVISOR "
5044 "requires OpenGL ES 3.0 or "
5045 "GL_ANGLE_instanced_arrays.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005046 return false;
5047 }
5048 break;
5049
5050 case GL_VERTEX_ATTRIB_ARRAY_INTEGER:
5051 if (context->getClientMajorVersion() < 3)
5052 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005053 context->handleError(
5054 InvalidEnum() << "GL_VERTEX_ATTRIB_ARRAY_INTEGER requires OpenGL ES 3.0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005055 return false;
5056 }
5057 break;
5058
5059 case GL_VERTEX_ATTRIB_BINDING:
5060 case GL_VERTEX_ATTRIB_RELATIVE_OFFSET:
5061 if (context->getClientVersion() < ES_3_1)
5062 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005063 context->handleError(InvalidEnum()
5064 << "Vertex Attrib Bindings require OpenGL ES 3.1.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005065 return false;
5066 }
5067 break;
5068
5069 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005070 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005071 return false;
5072 }
5073 }
5074
5075 if (length)
5076 {
5077 if (pname == GL_CURRENT_VERTEX_ATTRIB)
5078 {
5079 *length = 4;
5080 }
5081 else
5082 {
5083 *length = 1;
5084 }
5085 }
5086
5087 return true;
5088}
5089
Jamie Madill4928b7c2017-06-20 12:57:39 -04005090bool ValidateReadPixelsBase(Context *context,
Jamie Madillbe849e42017-05-02 15:49:00 -04005091 GLint x,
5092 GLint y,
5093 GLsizei width,
5094 GLsizei height,
5095 GLenum format,
5096 GLenum type,
5097 GLsizei bufSize,
5098 GLsizei *length,
5099 GLsizei *columns,
5100 GLsizei *rows,
5101 void *pixels)
5102{
5103 if (length != nullptr)
5104 {
5105 *length = 0;
5106 }
5107 if (rows != nullptr)
5108 {
5109 *rows = 0;
5110 }
5111 if (columns != nullptr)
5112 {
5113 *columns = 0;
5114 }
5115
5116 if (width < 0 || height < 0)
5117 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005118 ANGLE_VALIDATION_ERR(context, InvalidValue(), NegativeSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005119 return false;
5120 }
5121
5122 auto readFramebuffer = context->getGLState().getReadFramebuffer();
5123
5124 if (readFramebuffer->checkStatus(context) != GL_FRAMEBUFFER_COMPLETE)
5125 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005126 context->handleError(InvalidFramebufferOperation());
Jamie Madillbe849e42017-05-02 15:49:00 -04005127 return false;
5128 }
5129
5130 if (readFramebuffer->id() != 0 && readFramebuffer->getSamples(context) != 0)
5131 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005132 context->handleError(InvalidOperation());
Jamie Madillbe849e42017-05-02 15:49:00 -04005133 return false;
5134 }
5135
5136 const Framebuffer *framebuffer = context->getGLState().getReadFramebuffer();
5137 ASSERT(framebuffer);
5138
5139 if (framebuffer->getReadBufferState() == GL_NONE)
5140 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005141 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ReadBufferNone);
Jamie Madillbe849e42017-05-02 15:49:00 -04005142 return false;
5143 }
5144
5145 const FramebufferAttachment *readBuffer = framebuffer->getReadColorbuffer();
5146 // WebGL 1.0 [Section 6.26] Reading From a Missing Attachment
5147 // In OpenGL ES it is undefined what happens when an operation tries to read from a missing
5148 // attachment and WebGL defines it to be an error. We do the check unconditionnaly as the
5149 // situation is an application error that would lead to a crash in ANGLE.
5150 if (readBuffer == nullptr)
5151 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005152 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MissingReadAttachment);
Jamie Madillbe849e42017-05-02 15:49:00 -04005153 return false;
5154 }
5155
Martin Radev28031682017-07-28 14:47:56 +03005156 // ANGLE_multiview, Revision 1:
5157 // ReadPixels generates an INVALID_FRAMEBUFFER_OPERATION error if the multi-view layout of the
5158 // current read framebuffer is not NONE.
5159 if (readBuffer->getMultiviewLayout() != GL_NONE)
5160 {
5161 context->handleError(InvalidFramebufferOperation()
5162 << "Attempting to read from a multi-view framebuffer.");
5163 return false;
5164 }
5165
Geoff Lang280ba992017-04-18 16:30:58 -04005166 if (context->getExtensions().webglCompatibility)
5167 {
5168 // The ES 2.0 spec states that the format must be "among those defined in table 3.4,
5169 // excluding formats LUMINANCE and LUMINANCE_ALPHA.". This requires validating the format
5170 // and type before validating the combination of format and type. However, the
5171 // dEQP-GLES3.functional.negative_api.buffer.read_pixels passes GL_LUMINANCE as a format and
5172 // verifies that GL_INVALID_OPERATION is generated.
5173 // TODO(geofflang): Update this check to be done in all/no cases once this is resolved in
5174 // dEQP/WebGL.
5175 if (!ValidReadPixelsFormatEnum(context, format))
5176 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005177 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidFormat);
Geoff Lang280ba992017-04-18 16:30:58 -04005178 return false;
5179 }
5180
5181 if (!ValidReadPixelsTypeEnum(context, type))
5182 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005183 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidType);
Geoff Lang280ba992017-04-18 16:30:58 -04005184 return false;
5185 }
5186 }
5187
Jamie Madill4928b7c2017-06-20 12:57:39 -04005188 GLenum currentFormat = framebuffer->getImplementationColorReadFormat(context);
5189 GLenum currentType = framebuffer->getImplementationColorReadType(context);
Jamie Madillbe849e42017-05-02 15:49:00 -04005190 GLenum currentComponentType = readBuffer->getFormat().info->componentType;
5191
5192 bool validFormatTypeCombination =
5193 ValidReadPixelsFormatType(context, currentComponentType, format, type);
5194
5195 if (!(currentFormat == format && currentType == type) && !validFormatTypeCombination)
5196 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005197 ANGLE_VALIDATION_ERR(context, InvalidOperation(), MismatchedTypeAndFormat);
Jamie Madillbe849e42017-05-02 15:49:00 -04005198 return false;
5199 }
5200
5201 // Check for pixel pack buffer related API errors
5202 gl::Buffer *pixelPackBuffer = context->getGLState().getTargetBuffer(GL_PIXEL_PACK_BUFFER);
5203 if (pixelPackBuffer != nullptr && pixelPackBuffer->isMapped())
5204 {
5205 // ...the buffer object's data store is currently mapped.
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005206 context->handleError(InvalidOperation() << "Pixel pack buffer is mapped.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005207 return false;
5208 }
5209
5210 // .. the data would be packed to the buffer object such that the memory writes required
5211 // would exceed the data store size.
5212 const InternalFormat &formatInfo = GetInternalFormatInfo(format, type);
5213 const gl::Extents size(width, height, 1);
5214 const auto &pack = context->getGLState().getPackState();
5215
5216 auto endByteOrErr = formatInfo.computePackUnpackEndByte(type, size, pack, false);
5217 if (endByteOrErr.isError())
5218 {
5219 context->handleError(endByteOrErr.getError());
5220 return false;
5221 }
5222
5223 size_t endByte = endByteOrErr.getResult();
5224 if (bufSize >= 0)
5225 {
5226 if (pixelPackBuffer == nullptr && static_cast<size_t>(bufSize) < endByte)
5227 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005228 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005229 return false;
5230 }
5231 }
5232
5233 if (pixelPackBuffer != nullptr)
5234 {
5235 CheckedNumeric<size_t> checkedEndByte(endByte);
5236 CheckedNumeric<size_t> checkedOffset(reinterpret_cast<size_t>(pixels));
5237 checkedEndByte += checkedOffset;
5238
5239 if (checkedEndByte.ValueOrDie() > static_cast<size_t>(pixelPackBuffer->getSize()))
5240 {
5241 // Overflow past the end of the buffer
Brandon Jones6cad5662017-06-14 13:25:13 -07005242 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ParamOverflow);
Jamie Madillbe849e42017-05-02 15:49:00 -04005243 return false;
5244 }
5245 }
5246
5247 if (pixelPackBuffer == nullptr && length != nullptr)
5248 {
5249 if (endByte > static_cast<size_t>(std::numeric_limits<GLsizei>::max()))
5250 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005251 ANGLE_VALIDATION_ERR(context, InvalidOperation(), IntegerOverflow);
Jamie Madillbe849e42017-05-02 15:49:00 -04005252 return false;
5253 }
5254
5255 *length = static_cast<GLsizei>(endByte);
5256 }
5257
5258 auto getClippedExtent = [](GLint start, GLsizei length, int bufferSize) {
5259 angle::CheckedNumeric<int> clippedExtent(length);
5260 if (start < 0)
5261 {
5262 // "subtract" the area that is less than 0
5263 clippedExtent += start;
5264 }
5265
5266 const int readExtent = start + length;
5267 if (readExtent > bufferSize)
5268 {
5269 // Subtract the region to the right of the read buffer
5270 clippedExtent -= (readExtent - bufferSize);
5271 }
5272
5273 if (!clippedExtent.IsValid())
5274 {
5275 return 0;
5276 }
5277
5278 return std::max(clippedExtent.ValueOrDie(), 0);
5279 };
5280
5281 if (columns != nullptr)
5282 {
5283 *columns = getClippedExtent(x, width, readBuffer->getSize().width);
5284 }
5285
5286 if (rows != nullptr)
5287 {
5288 *rows = getClippedExtent(y, height, readBuffer->getSize().height);
5289 }
5290
5291 return true;
5292}
5293
5294template <typename ParamType>
5295bool ValidateTexParameterBase(Context *context,
5296 GLenum target,
5297 GLenum pname,
5298 GLsizei bufSize,
5299 const ParamType *params)
5300{
5301 if (!ValidTextureTarget(context, target) && !ValidTextureExternalTarget(context, target))
5302 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005303 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTextureTarget);
Jamie Madillbe849e42017-05-02 15:49:00 -04005304 return false;
5305 }
5306
5307 if (context->getTargetTexture(target) == nullptr)
5308 {
5309 // Should only be possible for external textures
Brandon Jones6cad5662017-06-14 13:25:13 -07005310 ANGLE_VALIDATION_ERR(context, InvalidEnum(), TextureNotBound);
Jamie Madillbe849e42017-05-02 15:49:00 -04005311 return false;
5312 }
5313
5314 const GLsizei minBufSize = 1;
5315 if (bufSize >= 0 && bufSize < minBufSize)
5316 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005317 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
Jamie Madillbe849e42017-05-02 15:49:00 -04005318 return false;
5319 }
5320
5321 switch (pname)
5322 {
5323 case GL_TEXTURE_WRAP_R:
5324 case GL_TEXTURE_SWIZZLE_R:
5325 case GL_TEXTURE_SWIZZLE_G:
5326 case GL_TEXTURE_SWIZZLE_B:
5327 case GL_TEXTURE_SWIZZLE_A:
5328 case GL_TEXTURE_BASE_LEVEL:
5329 case GL_TEXTURE_MAX_LEVEL:
5330 case GL_TEXTURE_COMPARE_MODE:
5331 case GL_TEXTURE_COMPARE_FUNC:
5332 case GL_TEXTURE_MIN_LOD:
5333 case GL_TEXTURE_MAX_LOD:
5334 if (context->getClientMajorVersion() < 3)
5335 {
Brandon Jonesafa75152017-07-21 13:11:29 -07005336 ANGLE_VALIDATION_ERR(context, InvalidEnum(), ES3Required);
Jamie Madillbe849e42017-05-02 15:49:00 -04005337 return false;
5338 }
5339 if (target == GL_TEXTURE_EXTERNAL_OES &&
5340 !context->getExtensions().eglImageExternalEssl3)
5341 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005342 context->handleError(InvalidEnum() << "ES3 texture parameters are not "
5343 "available without "
5344 "GL_OES_EGL_image_external_essl3.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005345 return false;
5346 }
5347 break;
5348
5349 default:
5350 break;
5351 }
5352
JiangYizhou4cff8d62017-07-06 14:54:09 +08005353 if (target == GL_TEXTURE_2D_MULTISAMPLE)
5354 {
5355 switch (pname)
5356 {
5357 case GL_TEXTURE_MIN_FILTER:
5358 case GL_TEXTURE_MAG_FILTER:
5359 case GL_TEXTURE_WRAP_S:
5360 case GL_TEXTURE_WRAP_T:
5361 case GL_TEXTURE_WRAP_R:
5362 case GL_TEXTURE_MIN_LOD:
5363 case GL_TEXTURE_MAX_LOD:
5364 case GL_TEXTURE_COMPARE_MODE:
5365 case GL_TEXTURE_COMPARE_FUNC:
5366 context->handleError(InvalidEnum()
5367 << "Invalid parameter for 2D multisampled textures.");
5368 return false;
5369 }
5370 }
5371
Jamie Madillbe849e42017-05-02 15:49:00 -04005372 switch (pname)
5373 {
5374 case GL_TEXTURE_WRAP_S:
5375 case GL_TEXTURE_WRAP_T:
5376 case GL_TEXTURE_WRAP_R:
Jamie Madillbe849e42017-05-02 15:49:00 -04005377 {
Corentin Wallez13c0dd42017-07-04 18:27:01 -04005378 bool restrictedWrapModes =
5379 target == GL_TEXTURE_EXTERNAL_OES || target == GL_TEXTURE_RECTANGLE_ANGLE;
5380 if (!ValidateTextureWrapModeValue(context, params, restrictedWrapModes))
5381 {
5382 return false;
5383 }
Jamie Madillbe849e42017-05-02 15:49:00 -04005384 }
5385 break;
5386
5387 case GL_TEXTURE_MIN_FILTER:
Jamie Madillbe849e42017-05-02 15:49:00 -04005388 {
Corentin Wallez13c0dd42017-07-04 18:27:01 -04005389 bool restrictedMinFilter =
5390 target == GL_TEXTURE_EXTERNAL_OES || target == GL_TEXTURE_RECTANGLE_ANGLE;
5391 if (!ValidateTextureMinFilterValue(context, params, restrictedMinFilter))
5392 {
5393 return false;
5394 }
Jamie Madillbe849e42017-05-02 15:49:00 -04005395 }
5396 break;
5397
5398 case GL_TEXTURE_MAG_FILTER:
5399 if (!ValidateTextureMagFilterValue(context, params))
5400 {
5401 return false;
5402 }
5403 break;
5404
5405 case GL_TEXTURE_USAGE_ANGLE:
5406 switch (ConvertToGLenum(params[0]))
5407 {
5408 case GL_NONE:
5409 case GL_FRAMEBUFFER_ATTACHMENT_ANGLE:
5410 break;
5411
5412 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005413 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005414 return false;
5415 }
5416 break;
5417
5418 case GL_TEXTURE_MAX_ANISOTROPY_EXT:
5419 if (!context->getExtensions().textureFilterAnisotropic)
5420 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005421 context->handleError(InvalidEnum() << "GL_EXT_texture_anisotropic is not enabled.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005422 return false;
5423 }
5424
5425 // we assume the parameter passed to this validation method is truncated, not rounded
5426 if (params[0] < 1)
5427 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005428 context->handleError(InvalidValue() << "Max anisotropy must be at least 1.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005429 return false;
5430 }
5431 break;
5432
5433 case GL_TEXTURE_MIN_LOD:
5434 case GL_TEXTURE_MAX_LOD:
5435 // any value is permissible
5436 break;
5437
5438 case GL_TEXTURE_COMPARE_MODE:
5439 if (!ValidateTextureCompareModeValue(context, params))
5440 {
5441 return false;
5442 }
5443 break;
5444
5445 case GL_TEXTURE_COMPARE_FUNC:
5446 if (!ValidateTextureCompareFuncValue(context, params))
5447 {
5448 return false;
5449 }
5450 break;
5451
5452 case GL_TEXTURE_SWIZZLE_R:
5453 case GL_TEXTURE_SWIZZLE_G:
5454 case GL_TEXTURE_SWIZZLE_B:
5455 case GL_TEXTURE_SWIZZLE_A:
5456 switch (ConvertToGLenum(params[0]))
5457 {
5458 case GL_RED:
5459 case GL_GREEN:
5460 case GL_BLUE:
5461 case GL_ALPHA:
5462 case GL_ZERO:
5463 case GL_ONE:
5464 break;
5465
5466 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005467 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005468 return false;
5469 }
5470 break;
5471
5472 case GL_TEXTURE_BASE_LEVEL:
5473 if (params[0] < 0)
5474 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005475 context->handleError(InvalidValue() << "Base level must be at least 0.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005476 return false;
5477 }
5478 if (target == GL_TEXTURE_EXTERNAL_OES && static_cast<GLuint>(params[0]) != 0)
5479 {
Yuly Novikovc4d18aa2017-03-09 18:45:02 -05005480 context->handleError(InvalidOperation()
5481 << "Base level must be 0 for external textures.");
Jamie Madillbe849e42017-05-02 15:49:00 -04005482 return false;
5483 }
JiangYizhou4cff8d62017-07-06 14:54:09 +08005484 if (target == GL_TEXTURE_2D_MULTISAMPLE && static_cast<GLuint>(params[0]) != 0)
5485 {
5486 context->handleError(InvalidOperation()
5487 << "Base level must be 0 for multisampled textures.");
5488 return false;
5489 }
Corentin Wallez13c0dd42017-07-04 18:27:01 -04005490 if (target == GL_TEXTURE_RECTANGLE_ANGLE && static_cast<GLuint>(params[0]) != 0)
5491 {
5492 context->handleError(InvalidOperation()
5493 << "Base level must be 0 for rectangle textures.");
5494 return false;
5495 }
Jamie Madillbe849e42017-05-02 15:49:00 -04005496 break;
5497
5498 case GL_TEXTURE_MAX_LEVEL:
5499 if (params[0] < 0)
5500 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005501 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
Jamie Madillbe849e42017-05-02 15:49:00 -04005502 return false;
5503 }
5504 break;
5505
5506 case GL_DEPTH_STENCIL_TEXTURE_MODE:
5507 if (context->getClientVersion() < Version(3, 1))
5508 {
Brandon Jones6cad5662017-06-14 13:25:13 -07005509 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumRequiresGLES31);
Jamie Madillbe849e42017-05-02 15:49:00 -04005510 return false;
5511 }
5512 switch (ConvertToGLenum(params[0]))
5513 {
5514 case GL_DEPTH_COMPONENT:
5515 case GL_STENCIL_INDEX:
5516 break;
5517
5518 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005519 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005520 return false;
5521 }
5522 break;
5523
5524 case GL_TEXTURE_SRGB_DECODE_EXT:
5525 if (!ValidateTextureSRGBDecodeValue(context, params))
5526 {
5527 return false;
5528 }
5529 break;
5530
5531 default:
Brandon Jones6cad5662017-06-14 13:25:13 -07005532 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
Jamie Madillbe849e42017-05-02 15:49:00 -04005533 return false;
5534 }
5535
5536 return true;
5537}
5538
5539template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLfloat *);
5540template bool ValidateTexParameterBase(Context *, GLenum, GLenum, GLsizei, const GLint *);
5541
Jamie Madill12e957f2017-08-26 21:42:26 -04005542bool ValidateVertexAttribIndex(ValidationContext *context, GLuint index)
5543{
5544 if (index >= MAX_VERTEX_ATTRIBS)
5545 {
5546 ANGLE_VALIDATION_ERR(context, InvalidValue(), IndexExceedsMaxVertexAttribute);
5547 return false;
5548 }
5549
5550 return true;
5551}
5552
5553bool ValidateGetActiveUniformBlockivBase(Context *context,
5554 GLuint program,
5555 GLuint uniformBlockIndex,
5556 GLenum pname,
5557 GLsizei *length)
5558{
5559 if (length)
5560 {
5561 *length = 0;
5562 }
5563
5564 if (context->getClientMajorVersion() < 3)
5565 {
5566 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required);
5567 return false;
5568 }
5569
5570 Program *programObject = GetValidProgram(context, program);
5571 if (!programObject)
5572 {
5573 return false;
5574 }
5575
5576 if (uniformBlockIndex >= programObject->getActiveUniformBlockCount())
5577 {
5578 context->handleError(InvalidValue()
5579 << "uniformBlockIndex exceeds active uniform block count.");
5580 return false;
5581 }
5582
5583 switch (pname)
5584 {
5585 case GL_UNIFORM_BLOCK_BINDING:
5586 case GL_UNIFORM_BLOCK_DATA_SIZE:
5587 case GL_UNIFORM_BLOCK_NAME_LENGTH:
5588 case GL_UNIFORM_BLOCK_ACTIVE_UNIFORMS:
5589 case GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES:
5590 case GL_UNIFORM_BLOCK_REFERENCED_BY_VERTEX_SHADER:
5591 case GL_UNIFORM_BLOCK_REFERENCED_BY_FRAGMENT_SHADER:
5592 break;
5593
5594 default:
5595 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
5596 return false;
5597 }
5598
5599 if (length)
5600 {
5601 if (pname == GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES)
5602 {
Jiajia Qin729b2c62017-08-14 09:36:11 +08005603 const InterfaceBlock &uniformBlock =
Jamie Madill12e957f2017-08-26 21:42:26 -04005604 programObject->getUniformBlockByIndex(uniformBlockIndex);
5605 *length = static_cast<GLsizei>(uniformBlock.memberIndexes.size());
5606 }
5607 else
5608 {
5609 *length = 1;
5610 }
5611 }
5612
5613 return true;
5614}
5615
Jamie Madill9696d072017-08-26 23:19:57 -04005616template <typename ParamType>
5617bool ValidateSamplerParameterBase(Context *context,
5618 GLuint sampler,
5619 GLenum pname,
5620 GLsizei bufSize,
5621 ParamType *params)
5622{
5623 if (context->getClientMajorVersion() < 3)
5624 {
5625 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required);
5626 return false;
5627 }
5628
5629 if (!context->isSampler(sampler))
5630 {
5631 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidSampler);
5632 return false;
5633 }
5634
5635 const GLsizei minBufSize = 1;
5636 if (bufSize >= 0 && bufSize < minBufSize)
5637 {
5638 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InsufficientBufferSize);
5639 return false;
5640 }
5641
5642 switch (pname)
5643 {
5644 case GL_TEXTURE_WRAP_S:
5645 case GL_TEXTURE_WRAP_T:
5646 case GL_TEXTURE_WRAP_R:
5647 if (!ValidateTextureWrapModeValue(context, params, false))
5648 {
5649 return false;
5650 }
5651 break;
5652
5653 case GL_TEXTURE_MIN_FILTER:
5654 if (!ValidateTextureMinFilterValue(context, params, false))
5655 {
5656 return false;
5657 }
5658 break;
5659
5660 case GL_TEXTURE_MAG_FILTER:
5661 if (!ValidateTextureMagFilterValue(context, params))
5662 {
5663 return false;
5664 }
5665 break;
5666
5667 case GL_TEXTURE_MIN_LOD:
5668 case GL_TEXTURE_MAX_LOD:
5669 // any value is permissible
5670 break;
5671
5672 case GL_TEXTURE_COMPARE_MODE:
5673 if (!ValidateTextureCompareModeValue(context, params))
5674 {
5675 return false;
5676 }
5677 break;
5678
5679 case GL_TEXTURE_COMPARE_FUNC:
5680 if (!ValidateTextureCompareFuncValue(context, params))
5681 {
5682 return false;
5683 }
5684 break;
5685
5686 case GL_TEXTURE_SRGB_DECODE_EXT:
5687 if (!ValidateTextureSRGBDecodeValue(context, params))
5688 {
5689 return false;
5690 }
5691 break;
5692
5693 default:
5694 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
5695 return false;
5696 }
5697
5698 return true;
5699}
5700
5701template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, GLfloat *);
5702template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, GLint *);
5703
5704bool ValidateGetSamplerParameterBase(Context *context,
5705 GLuint sampler,
5706 GLenum pname,
5707 GLsizei *length)
5708{
5709 if (length)
5710 {
5711 *length = 0;
5712 }
5713
5714 if (context->getClientMajorVersion() < 3)
5715 {
5716 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required);
5717 return false;
5718 }
5719
5720 if (!context->isSampler(sampler))
5721 {
5722 ANGLE_VALIDATION_ERR(context, InvalidOperation(), InvalidSampler);
5723 return false;
5724 }
5725
5726 switch (pname)
5727 {
5728 case GL_TEXTURE_WRAP_S:
5729 case GL_TEXTURE_WRAP_T:
5730 case GL_TEXTURE_WRAP_R:
5731 case GL_TEXTURE_MIN_FILTER:
5732 case GL_TEXTURE_MAG_FILTER:
5733 case GL_TEXTURE_MIN_LOD:
5734 case GL_TEXTURE_MAX_LOD:
5735 case GL_TEXTURE_COMPARE_MODE:
5736 case GL_TEXTURE_COMPARE_FUNC:
5737 break;
5738
5739 case GL_TEXTURE_SRGB_DECODE_EXT:
5740 if (!context->getExtensions().textureSRGBDecode)
5741 {
5742 context->handleError(InvalidEnum() << "GL_EXT_texture_sRGB_decode is not enabled.");
5743 return false;
5744 }
5745 break;
5746
5747 default:
5748 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
5749 return false;
5750 }
5751
5752 if (length)
5753 {
5754 *length = 1;
5755 }
5756 return true;
5757}
5758
5759bool ValidateGetInternalFormativBase(Context *context,
5760 GLenum target,
5761 GLenum internalformat,
5762 GLenum pname,
5763 GLsizei bufSize,
5764 GLsizei *numParams)
5765{
5766 if (numParams)
5767 {
5768 *numParams = 0;
5769 }
5770
5771 if (context->getClientMajorVersion() < 3)
5772 {
Yunchao Hef0fd87d2017-09-12 04:55:05 +08005773 ANGLE_VALIDATION_ERR(context, InvalidOperation(), ES3Required);
Jamie Madill9696d072017-08-26 23:19:57 -04005774 return false;
5775 }
5776
5777 const TextureCaps &formatCaps = context->getTextureCaps().get(internalformat);
5778 if (!formatCaps.renderable)
5779 {
5780 context->handleError(InvalidEnum() << "Internal format is not renderable.");
5781 return false;
5782 }
5783
5784 switch (target)
5785 {
5786 case GL_RENDERBUFFER:
5787 break;
5788
5789 case GL_TEXTURE_2D_MULTISAMPLE:
5790 if (context->getClientVersion() < ES_3_1)
5791 {
5792 context->handleError(InvalidOperation()
5793 << "Texture target requires at least OpenGL ES 3.1.");
5794 return false;
5795 }
5796 break;
5797
5798 default:
5799 ANGLE_VALIDATION_ERR(context, InvalidEnum(), InvalidTarget);
5800 return false;
5801 }
5802
5803 if (bufSize < 0)
5804 {
5805 ANGLE_VALIDATION_ERR(context, InvalidValue(), InsufficientBufferSize);
5806 return false;
5807 }
5808
5809 GLsizei maxWriteParams = 0;
5810 switch (pname)
5811 {
5812 case GL_NUM_SAMPLE_COUNTS:
5813 maxWriteParams = 1;
5814 break;
5815
5816 case GL_SAMPLES:
5817 maxWriteParams = static_cast<GLsizei>(formatCaps.sampleCounts.size());
5818 break;
5819
5820 default:
5821 ANGLE_VALIDATION_ERR(context, InvalidEnum(), EnumNotSupported);
5822 return false;
5823 }
5824
5825 if (numParams)
5826 {
5827 // glGetInternalFormativ will not overflow bufSize
5828 *numParams = std::min(bufSize, maxWriteParams);
5829 }
5830
5831 return true;
5832}
5833
Jamie Madillc29968b2016-01-20 11:17:23 -05005834} // namespace gl