Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 1 | /* Copyright (c) 2015-2017 The Khronos Group Inc. |
| 2 | * Copyright (c) 2015-2017 Valve Corporation |
| 3 | * Copyright (c) 2015-2017 LunarG, Inc. |
| 4 | * Copyright (C) 2015-2017 Google Inc. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 6 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 7 | * you may not use this file except in compliance with the License. |
| 8 | * You may obtain a copy of the License at |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 10 | * http://www.apache.org/licenses/LICENSE-2.0 |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11 | * |
Jon Ashburn | 3ebf125 | 2016-04-19 11:30:31 -0600 | [diff] [blame] | 12 | * Unless required by applicable law or agreed to in writing, software |
| 13 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 14 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 15 | * See the License for the specific language governing permissions and |
| 16 | * limitations under the License. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 17 | * |
| 18 | * Author: Cody Northrop <cnorthrop@google.com> |
| 19 | * Author: Michael Lentine <mlentine@google.com> |
| 20 | * Author: Tobin Ehlis <tobine@google.com> |
| 21 | * Author: Chia-I Wu <olv@google.com> |
| 22 | * Author: Chris Forbes <chrisf@ijw.co.nz> |
| 23 | * Author: Mark Lobodzinski <mark@lunarg.com> |
| 24 | * Author: Ian Elliott <ianelliott@google.com> |
Mark Lobodzinski | 9ea3d38 | 2017-01-11 15:25:28 -0700 | [diff] [blame] | 25 | * Author: Dave Houlton <daveh@lunarg.com> |
| 26 | * Author: Dustin Graves <dustin@lunarg.com> |
| 27 | * Author: Jeremy Hayes <jeremy@lunarg.com> |
| 28 | * Author: Jon Ashburn <jon@lunarg.com> |
| 29 | * Author: Karl Schultz <karl@lunarg.com> |
| 30 | * Author: Mark Young <marky@lunarg.com> |
| 31 | * Author: Mike Schuchardt <mikes@lunarg.com> |
| 32 | * Author: Mike Weiblen <mikew@lunarg.com> |
| 33 | * Author: Tony Barbour <tony@LunarG.com> |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 34 | */ |
| 35 | |
| 36 | // Allow use of STL min and max functions in Windows |
| 37 | #define NOMINMAX |
| 38 | |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 39 | #include <SPIRV/spirv.hpp> |
| 40 | #include <algorithm> |
| 41 | #include <assert.h> |
| 42 | #include <iostream> |
| 43 | #include <list> |
| 44 | #include <map> |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 45 | #include <mutex> |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 46 | #include <set> |
Mark Lobodzinski | 9acd2e3 | 2016-12-21 15:22:39 -0700 | [diff] [blame] | 47 | #include <sstream> |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 48 | #include <stdio.h> |
| 49 | #include <stdlib.h> |
| 50 | #include <string.h> |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 51 | #include <string> |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 52 | #include <tuple> |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 53 | |
| 54 | #include "vk_loader_platform.h" |
| 55 | #include "vk_dispatch_table_helper.h" |
Mark Lobodzinski | 9acd2e3 | 2016-12-21 15:22:39 -0700 | [diff] [blame] | 56 | #include "vk_enum_string_helper.h" |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 57 | #if defined(__GNUC__) |
| 58 | #pragma GCC diagnostic ignored "-Wwrite-strings" |
| 59 | #endif |
| 60 | #if defined(__GNUC__) |
| 61 | #pragma GCC diagnostic warning "-Wwrite-strings" |
| 62 | #endif |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 63 | #include "core_validation.h" |
Mark Lobodzinski | 42fe5f7 | 2017-01-11 11:36:16 -0700 | [diff] [blame] | 64 | #include "buffer_validation.h" |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 65 | #include "vk_layer_table.h" |
| 66 | #include "vk_layer_data.h" |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 67 | #include "vk_layer_extension_utils.h" |
| 68 | #include "vk_layer_utils.h" |
Chris Forbes | b4afd0f | 2016-04-04 10:48:35 +1200 | [diff] [blame] | 69 | #include "spirv-tools/libspirv.h" |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 70 | |
| 71 | #if defined __ANDROID__ |
| 72 | #include <android/log.h> |
| 73 | #define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) |
| 74 | #else |
Michael Lentine | 860b0fe | 2016-05-20 10:14:00 -0500 | [diff] [blame] | 75 | #define LOGCONSOLE(...) \ |
| 76 | { \ |
| 77 | printf(__VA_ARGS__); \ |
| 78 | printf("\n"); \ |
| 79 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 80 | #endif |
| 81 | |
Mike Stroyan | b985fca | 2016-11-01 11:50:16 -0600 | [diff] [blame] | 82 | // This intentionally includes a cpp file |
| 83 | #include "vk_safe_struct.cpp" |
| 84 | |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 85 | using namespace std; |
| 86 | |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 87 | namespace core_validation { |
| 88 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 89 | using std::unordered_map; |
| 90 | using std::unordered_set; |
| 91 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 92 | // WSI Image Objects bypass usual Image Object creation methods. A special Memory |
| 93 | // Object value will be used to identify them internally. |
| 94 | static const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 95 | // 2nd special memory handle used to flag object as unbound from memory |
| 96 | static const VkDeviceMemory MEMORY_UNBOUND = VkDeviceMemory(~((uint64_t)(0)) - 1); |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 97 | |
Jamie Madill | 6069c82 | 2016-12-15 09:35:36 -0500 | [diff] [blame] | 98 | // A special value of (0xFFFFFFFF, 0xFFFFFFFF) indicates that the surface size will be determined |
| 99 | // by the extent of a swapchain targeting the surface. |
| 100 | static const uint32_t kSurfaceSizeFromSwapchain = 0xFFFFFFFFu; |
| 101 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 102 | struct devExts { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 103 | bool wsi_enabled; |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 104 | bool wsi_display_swapchain_enabled; |
Tobin Ehlis | 80c9afa | 2016-06-02 12:45:31 -0600 | [diff] [blame] | 105 | unordered_map<VkSwapchainKHR, unique_ptr<SWAPCHAIN_NODE>> swapchainMap; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 106 | unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; |
| 107 | }; |
| 108 | |
| 109 | // fwd decls |
| 110 | struct shader_module; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 111 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 112 | struct instance_layer_data { |
Chris Forbes | 5ce44e3 | 2016-10-03 17:18:42 +1300 | [diff] [blame] | 113 | VkInstance instance = VK_NULL_HANDLE; |
Chris Forbes | 5ce44e3 | 2016-10-03 17:18:42 +1300 | [diff] [blame] | 114 | debug_report_data *report_data = nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 115 | std::vector<VkDebugReportCallbackEXT> logging_callback; |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 116 | VkLayerInstanceDispatchTable dispatch_table; |
| 117 | |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 118 | CALL_STATE vkEnumeratePhysicalDevicesState = UNCALLED; |
| 119 | uint32_t physical_devices_count = 0; |
Mark Young | 3938987 | 2017-01-19 21:10:49 -0700 | [diff] [blame] | 120 | CALL_STATE vkEnumeratePhysicalDeviceGroupsState = UNCALLED; |
| 121 | uint32_t physical_device_groups_count = 0; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 122 | CHECK_DISABLED disabled = {}; |
| 123 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 124 | unordered_map<VkPhysicalDevice, PHYSICAL_DEVICE_STATE> physical_device_map; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 125 | unordered_map<VkSurfaceKHR, SURFACE_STATE> surface_map; |
| 126 | |
| 127 | bool surfaceExtensionEnabled = false; |
| 128 | bool displayExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 129 | bool androidSurfaceExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 130 | bool mirSurfaceExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 131 | bool waylandSurfaceExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 132 | bool win32SurfaceExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 133 | bool xcbSurfaceExtensionEnabled = false; |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 134 | bool xlibSurfaceExtensionEnabled = false; |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 135 | }; |
| 136 | |
| 137 | struct layer_data { |
| 138 | debug_report_data *report_data = nullptr; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 139 | VkLayerDispatchTable dispatch_table; |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 140 | |
Chris Forbes | 5ce44e3 | 2016-10-03 17:18:42 +1300 | [diff] [blame] | 141 | devExts device_extensions = {}; |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 142 | unordered_set<VkQueue> queues; // All queues under given device |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 143 | // Global set of all cmdBuffers that are inFlight on this device |
| 144 | unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; |
| 145 | // Layer specific data |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 146 | unordered_map<VkSampler, unique_ptr<SAMPLER_STATE>> samplerMap; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 147 | unordered_map<VkImageView, unique_ptr<IMAGE_VIEW_STATE>> imageViewMap; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 148 | unordered_map<VkImage, unique_ptr<IMAGE_STATE>> imageMap; |
Tobin Ehlis | 8b87246 | 2016-09-14 08:12:08 -0600 | [diff] [blame] | 149 | unordered_map<VkBufferView, unique_ptr<BUFFER_VIEW_STATE>> bufferViewMap; |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 150 | unordered_map<VkBuffer, unique_ptr<BUFFER_STATE>> bufferMap; |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 151 | unordered_map<VkPipeline, PIPELINE_STATE *> pipelineMap; |
Chris Forbes | 456c07a | 2016-06-21 13:04:18 +1200 | [diff] [blame] | 152 | unordered_map<VkCommandPool, COMMAND_POOL_NODE> commandPoolMap; |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 153 | unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_STATE *> descriptorPoolMap; |
Tobin Ehlis | 05be5df | 2016-05-05 08:25:02 -0600 | [diff] [blame] | 154 | unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; |
Tobin Ehlis | 0a43bde | 2016-05-03 08:31:08 -0600 | [diff] [blame] | 155 | unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 156 | unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 157 | unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 158 | unordered_map<VkFence, FENCE_NODE> fenceMap; |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 159 | unordered_map<VkQueue, QUEUE_STATE> queueMap; |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 160 | unordered_map<VkEvent, EVENT_STATE> eventMap; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 161 | unordered_map<QueryObject, bool> queryToStateMap; |
| 162 | unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; |
| 163 | unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 164 | unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 165 | unordered_map<VkFramebuffer, unique_ptr<FRAMEBUFFER_STATE>> frameBufferMap; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 166 | unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; |
| 167 | unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 168 | unordered_map<VkRenderPass, unique_ptr<RENDER_PASS_STATE>> renderPassMap; |
Chris Forbes | 90da2e9 | 2016-03-18 16:30:03 +1300 | [diff] [blame] | 169 | unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; |
Mark Lobodzinski | e6ce3f6 | 2016-12-10 10:53:34 -0700 | [diff] [blame] | 170 | |
Chris Forbes | 5ce44e3 | 2016-10-03 17:18:42 +1300 | [diff] [blame] | 171 | VkDevice device = VK_NULL_HANDLE; |
Mark Lobodzinski | cf0f7b6 | 2016-11-16 12:12:56 -0700 | [diff] [blame] | 172 | VkPhysicalDevice physical_device = VK_NULL_HANDLE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 173 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 174 | instance_layer_data *instance_data = nullptr; // from device to enclosing instance |
Chris Forbes | 2e6c494 | 2016-10-03 17:44:52 +1300 | [diff] [blame] | 175 | |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 176 | VkPhysicalDeviceFeatures enabled_features = {}; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 177 | // Device specific data |
Chris Forbes | 5ce44e3 | 2016-10-03 17:18:42 +1300 | [diff] [blame] | 178 | PHYS_DEV_PROPERTIES_NODE phys_dev_properties = {}; |
| 179 | VkPhysicalDeviceMemoryProperties phys_dev_mem_props = {}; |
Mark Lobodzinski | f685859 | 2017-01-11 09:34:01 -0700 | [diff] [blame] | 180 | VkPhysicalDeviceProperties phys_dev_props = {}; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 181 | }; |
| 182 | |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 183 | // TODO : Do we need to guard access to layer_data_map w/ lock? |
| 184 | static unordered_map<void *, layer_data *> layer_data_map; |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 185 | static unordered_map<void *, instance_layer_data *> instance_layer_data_map; |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 186 | |
Mark Young | 3938987 | 2017-01-19 21:10:49 -0700 | [diff] [blame] | 187 | static uint32_t loader_layer_if_version = CURRENT_LOADER_LAYER_INTERFACE_VERSION; |
| 188 | |
Chia-I Wu | d199274 | 2016-05-06 11:36:52 +0800 | [diff] [blame] | 189 | static const VkLayerProperties global_layer = { |
Jon Ashburn | dc9111c | 2016-03-22 12:57:13 -0600 | [diff] [blame] | 190 | "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", |
Chia-I Wu | d199274 | 2016-05-06 11:36:52 +0800 | [diff] [blame] | 191 | }; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 192 | |
| 193 | template <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { |
| 194 | bool foundLayer = false; |
| 195 | for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { |
Chia-I Wu | d199274 | 2016-05-06 11:36:52 +0800 | [diff] [blame] | 196 | if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 197 | foundLayer = true; |
| 198 | } |
| 199 | // This has to be logged to console as we don't have a callback at this point. |
| 200 | if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { |
| 201 | LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", |
Chia-I Wu | d199274 | 2016-05-06 11:36:52 +0800 | [diff] [blame] | 202 | global_layer.layerName); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 203 | } |
| 204 | } |
| 205 | } |
| 206 | |
| 207 | // Code imported from shader_checker |
| 208 | static void build_def_index(shader_module *); |
| 209 | |
| 210 | // A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words |
| 211 | // without the caller needing to care too much about the physical SPIRV module layout. |
| 212 | struct spirv_inst_iter { |
| 213 | std::vector<uint32_t>::const_iterator zero; |
| 214 | std::vector<uint32_t>::const_iterator it; |
| 215 | |
Chris Forbes | ce7d7e0 | 2016-05-11 11:44:12 +1200 | [diff] [blame] | 216 | uint32_t len() { |
| 217 | auto result = *it >> 16; |
| 218 | assert(result > 0); |
| 219 | return result; |
| 220 | } |
| 221 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 222 | uint32_t opcode() { return *it & 0x0ffffu; } |
Chris Forbes | ce7d7e0 | 2016-05-11 11:44:12 +1200 | [diff] [blame] | 223 | |
| 224 | uint32_t const &word(unsigned n) { |
| 225 | assert(n < len()); |
| 226 | return it[n]; |
| 227 | } |
| 228 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 229 | uint32_t offset() { return (uint32_t)(it - zero); } |
| 230 | |
| 231 | spirv_inst_iter() {} |
| 232 | |
| 233 | spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} |
| 234 | |
| 235 | bool operator==(spirv_inst_iter const &other) { return it == other.it; } |
| 236 | |
| 237 | bool operator!=(spirv_inst_iter const &other) { return it != other.it; } |
| 238 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 239 | spirv_inst_iter operator++(int) { // x++ |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 240 | spirv_inst_iter ii = *this; |
| 241 | it += len(); |
| 242 | return ii; |
| 243 | } |
| 244 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 245 | spirv_inst_iter operator++() { // ++x; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 246 | it += len(); |
| 247 | return *this; |
| 248 | } |
| 249 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 250 | // The iterator and the value are the same thing. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 251 | spirv_inst_iter &operator*() { return *this; } |
| 252 | spirv_inst_iter const &operator*() const { return *this; } |
| 253 | }; |
| 254 | |
| 255 | struct shader_module { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 256 | // The spirv image itself |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 257 | vector<uint32_t> words; |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 258 | // A mapping of <id> to the first word of its def. this is useful because walking type |
| 259 | // trees, constant expressions, etc requires jumping all over the instruction stream. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 260 | unordered_map<unsigned, unsigned> def_index; |
| 261 | |
| 262 | shader_module(VkShaderModuleCreateInfo const *pCreateInfo) |
| 263 | : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), |
| 264 | def_index() { |
| 265 | |
| 266 | build_def_index(this); |
| 267 | } |
| 268 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 269 | // Expose begin() / end() to enable range-based for |
| 270 | spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } // First insn |
| 271 | spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } // Just past last insn |
| 272 | // Given an offset into the module, produce an iterator there. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 273 | spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } |
| 274 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 275 | // Gets an iterator to the definition of an id |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 276 | spirv_inst_iter get_def(unsigned id) const { |
| 277 | auto it = def_index.find(id); |
| 278 | if (it == def_index.end()) { |
| 279 | return end(); |
| 280 | } |
| 281 | return at(it->second); |
| 282 | } |
| 283 | }; |
| 284 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 285 | // TODO : This can be much smarter, using separate locks for separate global data |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 286 | static std::mutex global_lock; |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 287 | |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 288 | // Return IMAGE_VIEW_STATE ptr for specified imageView or else NULL |
| 289 | IMAGE_VIEW_STATE *getImageViewState(const layer_data *dev_data, VkImageView image_view) { |
Tobin Ehlis | d5fb09e | 2016-06-02 10:54:09 -0600 | [diff] [blame] | 290 | auto iv_it = dev_data->imageViewMap.find(image_view); |
| 291 | if (iv_it == dev_data->imageViewMap.end()) { |
| 292 | return nullptr; |
| 293 | } |
| 294 | return iv_it->second.get(); |
| 295 | } |
Tobin Ehlis | e2f8029 | 2016-06-02 10:08:53 -0600 | [diff] [blame] | 296 | // Return sampler node ptr for specified sampler or else NULL |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 297 | SAMPLER_STATE *getSamplerState(const layer_data *dev_data, VkSampler sampler) { |
Tobin Ehlis | d5fb09e | 2016-06-02 10:54:09 -0600 | [diff] [blame] | 298 | auto sampler_it = dev_data->samplerMap.find(sampler); |
| 299 | if (sampler_it == dev_data->samplerMap.end()) { |
Tobin Ehlis | e2f8029 | 2016-06-02 10:08:53 -0600 | [diff] [blame] | 300 | return nullptr; |
| 301 | } |
| 302 | return sampler_it->second.get(); |
| 303 | } |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 304 | // Return image state ptr for specified image or else NULL |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 305 | IMAGE_STATE *getImageState(const layer_data *dev_data, VkImage image) { |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 306 | auto img_it = dev_data->imageMap.find(image); |
| 307 | if (img_it == dev_data->imageMap.end()) { |
| 308 | return nullptr; |
| 309 | } |
| 310 | return img_it->second.get(); |
| 311 | } |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 312 | // Return buffer state ptr for specified buffer or else NULL |
| 313 | BUFFER_STATE *getBufferState(const layer_data *dev_data, VkBuffer buffer) { |
Tobin Ehlis | d5fb09e | 2016-06-02 10:54:09 -0600 | [diff] [blame] | 314 | auto buff_it = dev_data->bufferMap.find(buffer); |
| 315 | if (buff_it == dev_data->bufferMap.end()) { |
Tobin Ehlis | 94bc5d2 | 2016-06-02 07:46:52 -0600 | [diff] [blame] | 316 | return nullptr; |
| 317 | } |
| 318 | return buff_it->second.get(); |
| 319 | } |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 320 | // Return swapchain node for specified swapchain or else NULL |
Tobin Ehlis | e83a46a | 2016-06-02 12:48:25 -0600 | [diff] [blame] | 321 | SWAPCHAIN_NODE *getSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 322 | auto swp_it = dev_data->device_extensions.swapchainMap.find(swapchain); |
| 323 | if (swp_it == dev_data->device_extensions.swapchainMap.end()) { |
| 324 | return nullptr; |
| 325 | } |
Tobin Ehlis | 80c9afa | 2016-06-02 12:45:31 -0600 | [diff] [blame] | 326 | return swp_it->second.get(); |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 327 | } |
Tobin Ehlis | 969a526 | 2016-06-02 12:13:32 -0600 | [diff] [blame] | 328 | // Return swapchain for specified image or else NULL |
Tobin Ehlis | e83a46a | 2016-06-02 12:48:25 -0600 | [diff] [blame] | 329 | VkSwapchainKHR getSwapchainFromImage(const layer_data *dev_data, VkImage image) { |
Tobin Ehlis | 969a526 | 2016-06-02 12:13:32 -0600 | [diff] [blame] | 330 | auto img_it = dev_data->device_extensions.imageToSwapchainMap.find(image); |
| 331 | if (img_it == dev_data->device_extensions.imageToSwapchainMap.end()) { |
| 332 | return VK_NULL_HANDLE; |
| 333 | } |
| 334 | return img_it->second; |
| 335 | } |
Tobin Ehlis | 424859c | 2016-06-02 09:43:11 -0600 | [diff] [blame] | 336 | // Return buffer node ptr for specified buffer or else NULL |
Tobin Ehlis | 8b87246 | 2016-09-14 08:12:08 -0600 | [diff] [blame] | 337 | BUFFER_VIEW_STATE *getBufferViewState(const layer_data *my_data, VkBufferView buffer_view) { |
Tobin Ehlis | 424859c | 2016-06-02 09:43:11 -0600 | [diff] [blame] | 338 | auto bv_it = my_data->bufferViewMap.find(buffer_view); |
| 339 | if (bv_it == my_data->bufferViewMap.end()) { |
| 340 | return nullptr; |
| 341 | } |
| 342 | return bv_it->second.get(); |
| 343 | } |
Tobin Ehlis | 94bc5d2 | 2016-06-02 07:46:52 -0600 | [diff] [blame] | 344 | |
Chris Forbes | a70b6e1 | 2016-06-10 15:21:43 +1200 | [diff] [blame] | 345 | FENCE_NODE *getFenceNode(layer_data *dev_data, VkFence fence) { |
| 346 | auto it = dev_data->fenceMap.find(fence); |
| 347 | if (it == dev_data->fenceMap.end()) { |
| 348 | return nullptr; |
| 349 | } |
| 350 | return &it->second; |
| 351 | } |
| 352 | |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 353 | EVENT_STATE *getEventNode(layer_data *dev_data, VkEvent event) { |
Tobin Ehlis | cab6b7d | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 354 | auto it = dev_data->eventMap.find(event); |
| 355 | if (it == dev_data->eventMap.end()) { |
| 356 | return nullptr; |
| 357 | } |
| 358 | return &it->second; |
| 359 | } |
| 360 | |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 361 | QUERY_POOL_NODE *getQueryPoolNode(layer_data *dev_data, VkQueryPool query_pool) { |
| 362 | auto it = dev_data->queryPoolMap.find(query_pool); |
| 363 | if (it == dev_data->queryPoolMap.end()) { |
| 364 | return nullptr; |
| 365 | } |
| 366 | return &it->second; |
| 367 | } |
| 368 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 369 | QUEUE_STATE *getQueueState(layer_data *dev_data, VkQueue queue) { |
Chris Forbes | a70b6e1 | 2016-06-10 15:21:43 +1200 | [diff] [blame] | 370 | auto it = dev_data->queueMap.find(queue); |
| 371 | if (it == dev_data->queueMap.end()) { |
| 372 | return nullptr; |
| 373 | } |
| 374 | return &it->second; |
| 375 | } |
| 376 | |
Chris Forbes | 28b668e | 2016-06-16 12:17:09 +1200 | [diff] [blame] | 377 | SEMAPHORE_NODE *getSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { |
| 378 | auto it = dev_data->semaphoreMap.find(semaphore); |
| 379 | if (it == dev_data->semaphoreMap.end()) { |
| 380 | return nullptr; |
| 381 | } |
| 382 | return &it->second; |
| 383 | } |
| 384 | |
Chris Forbes | 456c07a | 2016-06-21 13:04:18 +1200 | [diff] [blame] | 385 | COMMAND_POOL_NODE *getCommandPoolNode(layer_data *dev_data, VkCommandPool pool) { |
| 386 | auto it = dev_data->commandPoolMap.find(pool); |
| 387 | if (it == dev_data->commandPoolMap.end()) { |
| 388 | return nullptr; |
| 389 | } |
| 390 | return &it->second; |
| 391 | } |
Chris Forbes | 8245eba | 2016-10-03 17:36:32 +1300 | [diff] [blame] | 392 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 393 | PHYSICAL_DEVICE_STATE *getPhysicalDeviceState(instance_layer_data *instance_data, VkPhysicalDevice phys) { |
| 394 | auto it = instance_data->physical_device_map.find(phys); |
| 395 | if (it == instance_data->physical_device_map.end()) { |
Chris Forbes | 8245eba | 2016-10-03 17:36:32 +1300 | [diff] [blame] | 396 | return nullptr; |
| 397 | } |
| 398 | return &it->second; |
| 399 | } |
| 400 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 401 | SURFACE_STATE *getSurfaceState(instance_layer_data *instance_data, VkSurfaceKHR surface) { |
| 402 | auto it = instance_data->surface_map.find(surface); |
| 403 | if (it == instance_data->surface_map.end()) { |
| 404 | return nullptr; |
| 405 | } |
| 406 | return &it->second; |
| 407 | } |
| 408 | |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 409 | // Return ptr to memory binding for given handle of specified type |
| 410 | static BINDABLE *GetObjectMemBinding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 411 | switch (type) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 412 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: |
| 413 | return getImageState(my_data, VkImage(handle)); |
| 414 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 415 | return getBufferState(my_data, VkBuffer(handle)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 416 | default: |
| 417 | break; |
| 418 | } |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 419 | return nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 420 | } |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 421 | // prototype |
Chris Forbes | 664ca7f | 2016-05-06 16:55:18 +1200 | [diff] [blame] | 422 | static GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 423 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 424 | // Helper function to validate correct usage bits set for buffers or images |
| 425 | // Verify that (actual & desired) flags != 0 or, |
| 426 | // if strict is true, verify that (actual & desired) flags == desired |
| 427 | // In case of error, report it via dbg callbacks |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 428 | static bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, uint64_t obj_handle, |
| 429 | VkDebugReportObjectTypeEXT obj_type, int32_t const msgCode, char const *ty_str, |
| 430 | char const *func_name, char const *usage_str) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 431 | bool correct_usage = false; |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 432 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 433 | if (strict) |
| 434 | correct_usage = ((actual & desired) == desired); |
| 435 | else |
| 436 | correct_usage = ((actual & desired) != 0); |
| 437 | if (!correct_usage) { |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 438 | if (msgCode == -1) { |
| 439 | // TODO: Fix callers with msgCode == -1 to use correct validation checks. |
| 440 | skip_call = |
| 441 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, |
| 442 | MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 |
| 443 | " used by %s. In this case, %s should have %s set during creation.", |
| 444 | ty_str, obj_handle, func_name, ty_str, usage_str); |
| 445 | } else { |
| 446 | const char *valid_usage = (msgCode == -1) ? "" : validation_error_map[msgCode]; |
| 447 | skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, msgCode, "MEM", |
| 448 | "Invalid usage flag for %s 0x%" PRIxLEAST64 |
| 449 | " used by %s. In this case, %s should have %s set during creation. %s", |
| 450 | ty_str, obj_handle, func_name, ty_str, usage_str, valid_usage); |
| 451 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 452 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 453 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 454 | } |
| 455 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 456 | // Helper function to validate usage flags for buffers |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 457 | // For given buffer_state send actual vs. desired usage off to helper above where |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 458 | // an error will be flagged if usage is not correct |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 459 | static bool ValidateImageUsageFlags(layer_data *dev_data, IMAGE_STATE const *image_state, VkFlags desired, VkBool32 strict, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 460 | int32_t const msgCode, char const *func_name, char const *usage_string) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 461 | return validate_usage_flags(dev_data, image_state->createInfo.usage, desired, strict, |
| 462 | reinterpret_cast<const uint64_t &>(image_state->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 463 | msgCode, "image", func_name, usage_string); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 464 | } |
| 465 | |
| 466 | // Helper function to validate usage flags for buffers |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 467 | // For given buffer_state send actual vs. desired usage off to helper above where |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 468 | // an error will be flagged if usage is not correct |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 469 | static bool ValidateBufferUsageFlags(layer_data *dev_data, BUFFER_STATE const *buffer_state, VkFlags desired, VkBool32 strict, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 470 | int32_t const msgCode, char const *func_name, char const *usage_string) { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 471 | return validate_usage_flags(dev_data, buffer_state->createInfo.usage, desired, strict, |
| 472 | reinterpret_cast<const uint64_t &>(buffer_state->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 473 | msgCode, "buffer", func_name, usage_string); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 474 | } |
| 475 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 476 | // Return ptr to info in map container containing mem, or NULL if not found |
| 477 | // Calls to this function should be wrapped in mutex |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 478 | DEVICE_MEM_INFO *getMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { |
| 479 | auto mem_it = dev_data->memObjMap.find(mem); |
| 480 | if (mem_it == dev_data->memObjMap.end()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 481 | return NULL; |
| 482 | } |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 483 | return mem_it->second.get(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 484 | } |
| 485 | |
| 486 | static void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, |
| 487 | const VkMemoryAllocateInfo *pAllocateInfo) { |
| 488 | assert(object != NULL); |
| 489 | |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 490 | my_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 491 | } |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 492 | |
| 493 | // Helper function to print lowercase string of object type |
| 494 | // TODO: Unify string helper functions, this should really come out of a string helper if not there already |
| 495 | static const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { |
| 496 | switch (type) { |
| 497 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: |
| 498 | return "image"; |
| 499 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: |
| 500 | return "buffer"; |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 501 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: |
| 502 | return "image view"; |
| 503 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: |
| 504 | return "buffer view"; |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 505 | case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: |
| 506 | return "swapchain"; |
| 507 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: |
| 508 | return "descriptor set"; |
| 509 | case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: |
Tobin Ehlis | b0fcdfa | 2016-09-06 20:37:39 -0600 | [diff] [blame] | 510 | return "framebuffer"; |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 511 | case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: |
| 512 | return "event"; |
| 513 | case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: |
| 514 | return "query pool"; |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 515 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: |
| 516 | return "descriptor pool"; |
| 517 | case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: |
| 518 | return "command pool"; |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 519 | case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: |
| 520 | return "pipeline"; |
| 521 | case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: |
| 522 | return "sampler"; |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 523 | case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: |
| 524 | return "renderpass"; |
| 525 | case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: |
| 526 | return "device memory"; |
Tobin Ehlis | 7d1dd14 | 2016-08-18 08:23:30 -0600 | [diff] [blame] | 527 | case VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT: |
| 528 | return "semaphore"; |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 529 | default: |
| 530 | return "unknown"; |
| 531 | } |
| 532 | } |
| 533 | |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 534 | // For given bound_object_handle, bound to given mem allocation, verify that the range for the bound object is valid |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 535 | static bool ValidateMemoryIsValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t bound_object_handle, |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 536 | VkDebugReportObjectTypeEXT type, const char *functionName) { |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 537 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); |
| 538 | if (mem_info) { |
| 539 | if (!mem_info->bound_ranges[bound_object_handle].valid) { |
Karl Schultz | e52f014 | 2016-09-29 16:11:35 -0600 | [diff] [blame] | 540 | return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
Tobin Ehlis | d28978b | 2016-09-06 18:46:55 -0600 | [diff] [blame] | 541 | reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 542 | "%s: Cannot read invalid region of memory allocation 0x%" PRIx64 " for bound %s object 0x%" PRIx64 |
| 543 | ", please fill the memory before using.", |
| 544 | functionName, reinterpret_cast<uint64_t &>(mem), object_type_to_string(type), bound_object_handle); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 545 | } |
| 546 | } |
| 547 | return false; |
| 548 | } |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 549 | // For given image_state |
| 550 | // If mem is special swapchain key, then verify that image_state valid member is true |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 551 | // Else verify that the image's bound memory range is valid |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 552 | static bool ValidateImageMemoryIsValid(layer_data *dev_data, IMAGE_STATE *image_state, const char *functionName) { |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 553 | if (image_state->binding.mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 554 | if (!image_state->valid) { |
Karl Schultz | e52f014 | 2016-09-29 16:11:35 -0600 | [diff] [blame] | 555 | return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 556 | reinterpret_cast<uint64_t &>(image_state->binding.mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 557 | "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 558 | functionName, reinterpret_cast<uint64_t &>(image_state->image)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 559 | } |
| 560 | } else { |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 561 | return ValidateMemoryIsValid(dev_data, image_state->binding.mem, reinterpret_cast<uint64_t &>(image_state->image), |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 562 | VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, functionName); |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 563 | } |
| 564 | return false; |
| 565 | } |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 566 | // For given buffer_state, verify that the range it's bound to is valid |
| 567 | static bool ValidateBufferMemoryIsValid(layer_data *dev_data, BUFFER_STATE *buffer_state, const char *functionName) { |
| 568 | return ValidateMemoryIsValid(dev_data, buffer_state->binding.mem, reinterpret_cast<uint64_t &>(buffer_state->buffer), |
Tobin Ehlis | 7edb0a9 | 2016-09-06 18:12:07 -0600 | [diff] [blame] | 569 | VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, functionName); |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 570 | } |
| 571 | // For the given memory allocation, set the range bound by the given handle object to the valid param value |
| 572 | static void SetMemoryValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, bool valid) { |
| 573 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); |
| 574 | if (mem_info) { |
| 575 | mem_info->bound_ranges[handle].valid = valid; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 576 | } |
| 577 | } |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 578 | // For given image node |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 579 | // If mem is special swapchain key, then set entire image_state to valid param value |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 580 | // Else set the image's bound memory range to valid param value |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 581 | static void SetImageMemoryValid(layer_data *dev_data, IMAGE_STATE *image_state, bool valid) { |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 582 | if (image_state->binding.mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 583 | image_state->valid = valid; |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 584 | } else { |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 585 | SetMemoryValid(dev_data, image_state->binding.mem, reinterpret_cast<uint64_t &>(image_state->image), valid); |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 586 | } |
| 587 | } |
| 588 | // For given buffer node set the buffer's bound memory range to valid param value |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 589 | static void SetBufferMemoryValid(layer_data *dev_data, BUFFER_STATE *buffer_state, bool valid) { |
| 590 | SetMemoryValid(dev_data, buffer_state->binding.mem, reinterpret_cast<uint64_t &>(buffer_state->buffer), valid); |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 591 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 592 | // Find CB Info and add mem reference to list container |
| 593 | // Find Mem Obj Info and add CB reference to list container |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 594 | static bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, |
| 595 | const char *apiName) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 596 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 597 | |
| 598 | // Skip validation if this image was created through WSI |
| 599 | if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
| 600 | |
| 601 | // First update CB binding in MemObj mini CB list |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 602 | DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 603 | if (pMemInfo) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 604 | // Now update CBInfo's Mem reference list |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 605 | GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, cb); |
| 606 | pMemInfo->cb_bindings.insert(cb_node); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 607 | // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 608 | if (cb_node) { |
| 609 | cb_node->memObjs.insert(mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 610 | } |
| 611 | } |
| 612 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 613 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 614 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 615 | |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 616 | // Create binding link between given sampler and command buffer node |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 617 | void AddCommandBufferBindingSampler(GLOBAL_CB_NODE *cb_node, SAMPLER_STATE *sampler_state) { |
| 618 | sampler_state->cb_bindings.insert(cb_node); |
| 619 | cb_node->object_bindings.insert( |
| 620 | {reinterpret_cast<uint64_t &>(sampler_state->sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}); |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 621 | } |
| 622 | |
| 623 | // Create binding link between given image node and command buffer node |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 624 | void AddCommandBufferBindingImage(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_STATE *image_state) { |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 625 | // Skip validation if this image was created through WSI |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 626 | if (image_state->binding.mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 627 | // First update CB binding in MemObj mini CB list |
Tobin Ehlis | 640a81c | 2016-11-15 15:37:18 -0700 | [diff] [blame] | 628 | for (auto mem_binding : image_state->GetBoundMemory()) { |
| 629 | DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem_binding); |
| 630 | if (pMemInfo) { |
| 631 | pMemInfo->cb_bindings.insert(cb_node); |
| 632 | // Now update CBInfo's Mem reference list |
| 633 | cb_node->memObjs.insert(mem_binding); |
| 634 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 635 | } |
Tobin Ehlis | 6fcd6e4 | 2016-09-21 14:28:42 -0600 | [diff] [blame] | 636 | // Now update cb binding for image |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 637 | cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(image_state->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); |
| 638 | image_state->cb_bindings.insert(cb_node); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 639 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 640 | } |
| 641 | |
Tobin Ehlis | 15b8ea0 | 2016-09-19 14:02:58 -0600 | [diff] [blame] | 642 | // Create binding link between given image view node and its image with command buffer node |
| 643 | void AddCommandBufferBindingImageView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_VIEW_STATE *view_state) { |
| 644 | // First add bindings for imageView |
| 645 | view_state->cb_bindings.insert(cb_node); |
Tobin Ehlis | 15b8ea0 | 2016-09-19 14:02:58 -0600 | [diff] [blame] | 646 | cb_node->object_bindings.insert( |
| 647 | {reinterpret_cast<uint64_t &>(view_state->image_view), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT}); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 648 | auto image_state = getImageState(dev_data, view_state->create_info.image); |
Tobin Ehlis | 15b8ea0 | 2016-09-19 14:02:58 -0600 | [diff] [blame] | 649 | // Add bindings for image within imageView |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 650 | if (image_state) { |
| 651 | AddCommandBufferBindingImage(dev_data, cb_node, image_state); |
Tobin Ehlis | 15b8ea0 | 2016-09-19 14:02:58 -0600 | [diff] [blame] | 652 | } |
| 653 | } |
| 654 | |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 655 | // Create binding link between given buffer node and command buffer node |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 656 | void AddCommandBufferBindingBuffer(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_STATE *buffer_state) { |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 657 | // First update CB binding in MemObj mini CB list |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 658 | for (auto mem_binding : buffer_state->GetBoundMemory()) { |
Tobin Ehlis | 640a81c | 2016-11-15 15:37:18 -0700 | [diff] [blame] | 659 | DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem_binding); |
| 660 | if (pMemInfo) { |
| 661 | pMemInfo->cb_bindings.insert(cb_node); |
| 662 | // Now update CBInfo's Mem reference list |
| 663 | cb_node->memObjs.insert(mem_binding); |
| 664 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 665 | } |
| 666 | // Now update cb binding for buffer |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 667 | cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(buffer_state->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); |
| 668 | buffer_state->cb_bindings.insert(cb_node); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 669 | } |
| 670 | |
Tobin Ehlis | 2515c0e | 2016-09-28 07:12:28 -0600 | [diff] [blame] | 671 | // Create binding link between given buffer view node and its buffer with command buffer node |
| 672 | void AddCommandBufferBindingBufferView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_VIEW_STATE *view_state) { |
| 673 | // First add bindings for bufferView |
| 674 | view_state->cb_bindings.insert(cb_node); |
| 675 | cb_node->object_bindings.insert( |
| 676 | {reinterpret_cast<uint64_t &>(view_state->buffer_view), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT}); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 677 | auto buffer_state = getBufferState(dev_data, view_state->create_info.buffer); |
Tobin Ehlis | 2515c0e | 2016-09-28 07:12:28 -0600 | [diff] [blame] | 678 | // Add bindings for buffer within bufferView |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 679 | if (buffer_state) { |
| 680 | AddCommandBufferBindingBuffer(dev_data, cb_node, buffer_state); |
Tobin Ehlis | 2515c0e | 2016-09-28 07:12:28 -0600 | [diff] [blame] | 681 | } |
| 682 | } |
| 683 | |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 684 | // For every mem obj bound to particular CB, free bindings related to that CB |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 685 | static void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { |
| 686 | if (cb_node) { |
| 687 | if (cb_node->memObjs.size() > 0) { |
| 688 | for (auto mem : cb_node->memObjs) { |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 689 | DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 690 | if (pInfo) { |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 691 | pInfo->cb_bindings.erase(cb_node); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 692 | } |
| 693 | } |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 694 | cb_node->memObjs.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 695 | } |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 696 | cb_node->validate_functions.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 697 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 698 | } |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 699 | // Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up |
| 700 | static void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { |
| 701 | clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 702 | } |
| 703 | |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 704 | // Clear a single object binding from given memory object, or report error if binding is missing |
| 705 | static bool ClearMemoryObjectBinding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type, VkDeviceMemory mem) { |
| 706 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); |
| 707 | // This obj is bound to a memory object. Remove the reference to this object in that memory object's list |
Jeremy Hayes | 971ba4c | 2016-12-01 11:39:42 -0700 | [diff] [blame] | 708 | if (mem_info) { |
| 709 | mem_info->obj_bindings.erase({handle, type}); |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 710 | } |
| 711 | return false; |
| 712 | } |
| 713 | |
| 714 | // ClearMemoryObjectBindings clears the binding of objects to memory |
| 715 | // For the given object it pulls the memory bindings and makes sure that the bindings |
| 716 | // no longer refer to the object being cleared. This occurs when objects are destroyed. |
| 717 | static bool ClearMemoryObjectBindings(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { |
| 718 | bool skip = false; |
| 719 | BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); |
| 720 | if (mem_binding) { |
| 721 | if (!mem_binding->sparse) { |
| 722 | skip = ClearMemoryObjectBinding(dev_data, handle, type, mem_binding->binding.mem); |
| 723 | } else { // Sparse, clear all bindings |
| 724 | for (auto& sparse_mem_binding : mem_binding->sparse_bindings) { |
| 725 | skip |= ClearMemoryObjectBinding(dev_data, handle, type, sparse_mem_binding.mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 726 | } |
| 727 | } |
| 728 | } |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 729 | return skip; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 730 | } |
| 731 | |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 732 | // For given mem object, verify that it is not null or UNBOUND, if it is, report error. Return skip value. |
| 733 | bool VerifyBoundMemoryIsValid(const layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, const char *api_name, |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 734 | const char *type_name, UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 735 | bool result = false; |
| 736 | if (VK_NULL_HANDLE == mem) { |
| 737 | result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 738 | __LINE__, error_code, "MEM", |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 739 | "%s: Vk%s object 0x%" PRIxLEAST64 " used with no memory bound. Memory should be bound by calling " |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 740 | "vkBind%sMemory(). %s", |
| 741 | api_name, type_name, handle, type_name, validation_error_map[error_code]); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 742 | } else if (MEMORY_UNBOUND == mem) { |
| 743 | result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 744 | __LINE__, error_code, "MEM", |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 745 | "%s: Vk%s object 0x%" PRIxLEAST64 " used with no memory bound and previously bound memory was freed. " |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 746 | "Memory must not be freed prior to this operation. %s", |
| 747 | api_name, type_name, handle, validation_error_map[error_code]); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 748 | } |
| 749 | return result; |
| 750 | } |
| 751 | |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 752 | // Check to see if memory was ever bound to this image |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 753 | bool ValidateMemoryIsBoundToImage(const layer_data *dev_data, const IMAGE_STATE *image_state, const char *api_name, |
| 754 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 755 | bool result = false; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 756 | if (0 == (static_cast<uint32_t>(image_state->createInfo.flags) & VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 757 | result = VerifyBoundMemoryIsValid(dev_data, image_state->binding.mem, |
| 758 | reinterpret_cast<const uint64_t &>(image_state->image), api_name, "Image", error_code); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 759 | } |
| 760 | return result; |
| 761 | } |
| 762 | |
| 763 | // Check to see if memory was bound to this buffer |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 764 | bool ValidateMemoryIsBoundToBuffer(const layer_data *dev_data, const BUFFER_STATE *buffer_state, const char *api_name, |
| 765 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 766 | bool result = false; |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 767 | if (0 == (static_cast<uint32_t>(buffer_state->createInfo.flags) & VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) { |
| 768 | result = VerifyBoundMemoryIsValid(dev_data, buffer_state->binding.mem, |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 769 | reinterpret_cast<const uint64_t &>(buffer_state->buffer), api_name, "Buffer", error_code); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 770 | } |
| 771 | return result; |
| 772 | } |
| 773 | |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 774 | // SetMemBinding is used to establish immutable, non-sparse binding between a single image/buffer object and memory object |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 775 | // For NULL mem case, output warning |
| 776 | // Make sure given object is in global object map |
| 777 | // IF a previous binding existed, output validation error |
| 778 | // Otherwise, add reference from objectInfo to memoryInfo |
| 779 | // Add reference off of objInfo |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 780 | // TODO: We may need to refactor or pass in multiple valid usage statements to handle multiple valid usage conditions. |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 781 | static bool SetMemBinding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, VkDebugReportObjectTypeEXT type, |
| 782 | const char *apiName) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 783 | bool skip_call = false; |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 784 | // It's an error to bind an object to NULL memory |
Jeremy Hayes | 35fe172 | 2016-12-13 13:09:44 -0700 | [diff] [blame] | 785 | if (mem != VK_NULL_HANDLE) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 786 | BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 787 | assert(mem_binding); |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 788 | // TODO : Add check here to make sure object isn't sparse |
| 789 | // VALIDATION_ERROR_00792 for buffers |
| 790 | // VALIDATION_ERROR_00804 for images |
| 791 | assert(!mem_binding->sparse); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 792 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); |
| 793 | if (mem_info) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 794 | DEVICE_MEM_INFO *prev_binding = getMemObjInfo(dev_data, mem_binding->binding.mem); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 795 | if (prev_binding) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 796 | // TODO: VALIDATION_ERROR_00791 and VALIDATION_ERROR_00803 |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 797 | skip_call |= |
| 798 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 799 | reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", |
| 800 | "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 |
| 801 | ") which has already been bound to mem object 0x%" PRIxLEAST64, |
| 802 | apiName, reinterpret_cast<uint64_t &>(mem), handle, reinterpret_cast<uint64_t &>(prev_binding->mem)); |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 803 | } else if (mem_binding->binding.mem == MEMORY_UNBOUND) { |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 804 | skip_call |= |
| 805 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 806 | reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", |
| 807 | "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 |
| 808 | ") which was previous bound to memory that has since been freed. Memory bindings are immutable in " |
| 809 | "Vulkan so this attempt to bind to new memory is not allowed.", |
| 810 | apiName, reinterpret_cast<uint64_t &>(mem), handle); |
Tobin Ehlis | d5b56ea | 2016-05-11 14:40:44 -0600 | [diff] [blame] | 811 | } else { |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 812 | mem_info->obj_bindings.insert({handle, type}); |
Tobin Ehlis | d5b56ea | 2016-05-11 14:40:44 -0600 | [diff] [blame] | 813 | // For image objects, make sure default memory state is correctly set |
| 814 | // TODO : What's the best/correct way to handle this? |
| 815 | if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 816 | auto const image_state = getImageState(dev_data, VkImage(handle)); |
| 817 | if (image_state) { |
| 818 | VkImageCreateInfo ici = image_state->createInfo; |
Tobin Ehlis | d5b56ea | 2016-05-11 14:40:44 -0600 | [diff] [blame] | 819 | if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { |
| 820 | // TODO:: More memory state transition stuff. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 821 | } |
| 822 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 823 | } |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 824 | mem_binding->binding.mem = mem; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 825 | } |
| 826 | } |
| 827 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 828 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 829 | } |
| 830 | |
| 831 | // For NULL mem case, clear any previous binding Else... |
| 832 | // Make sure given object is in its object map |
| 833 | // IF a previous binding existed, update binding |
| 834 | // Add reference from objectInfo to memoryInfo |
| 835 | // Add reference off of object's binding info |
Chris Forbes | 73b82b1 | 2016-04-06 15:16:26 +1200 | [diff] [blame] | 836 | // Return VK_TRUE if addition is successful, VK_FALSE otherwise |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 837 | static bool SetSparseMemBinding(layer_data *dev_data, MEM_BINDING binding, uint64_t handle, VkDebugReportObjectTypeEXT type, |
| 838 | const char *apiName) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 839 | bool skip_call = VK_FALSE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 840 | // Handle NULL case separately, just clear previous binding & decrement reference |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 841 | if (binding.mem == VK_NULL_HANDLE) { |
| 842 | // TODO : This should cause the range of the resource to be unbound according to spec |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 843 | } else { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 844 | BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); |
| 845 | assert(mem_binding); |
| 846 | assert(mem_binding->sparse); |
| 847 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, binding.mem); |
| 848 | if (mem_info) { |
| 849 | mem_info->obj_bindings.insert({handle, type}); |
Tobin Ehlis | d5b56ea | 2016-05-11 14:40:44 -0600 | [diff] [blame] | 850 | // Need to set mem binding for this object |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 851 | mem_binding->sparse_bindings.insert(binding); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 852 | } |
| 853 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 854 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 855 | } |
| 856 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 857 | // Return a string representation of CMD_TYPE enum |
| 858 | static string cmdTypeToString(CMD_TYPE cmd) { |
| 859 | switch (cmd) { |
| 860 | case CMD_BINDPIPELINE: |
| 861 | return "CMD_BINDPIPELINE"; |
| 862 | case CMD_BINDPIPELINEDELTA: |
| 863 | return "CMD_BINDPIPELINEDELTA"; |
| 864 | case CMD_SETVIEWPORTSTATE: |
| 865 | return "CMD_SETVIEWPORTSTATE"; |
| 866 | case CMD_SETLINEWIDTHSTATE: |
| 867 | return "CMD_SETLINEWIDTHSTATE"; |
| 868 | case CMD_SETDEPTHBIASSTATE: |
| 869 | return "CMD_SETDEPTHBIASSTATE"; |
| 870 | case CMD_SETBLENDSTATE: |
| 871 | return "CMD_SETBLENDSTATE"; |
| 872 | case CMD_SETDEPTHBOUNDSSTATE: |
| 873 | return "CMD_SETDEPTHBOUNDSSTATE"; |
| 874 | case CMD_SETSTENCILREADMASKSTATE: |
| 875 | return "CMD_SETSTENCILREADMASKSTATE"; |
| 876 | case CMD_SETSTENCILWRITEMASKSTATE: |
| 877 | return "CMD_SETSTENCILWRITEMASKSTATE"; |
| 878 | case CMD_SETSTENCILREFERENCESTATE: |
| 879 | return "CMD_SETSTENCILREFERENCESTATE"; |
| 880 | case CMD_BINDDESCRIPTORSETS: |
| 881 | return "CMD_BINDDESCRIPTORSETS"; |
| 882 | case CMD_BINDINDEXBUFFER: |
| 883 | return "CMD_BINDINDEXBUFFER"; |
| 884 | case CMD_BINDVERTEXBUFFER: |
| 885 | return "CMD_BINDVERTEXBUFFER"; |
| 886 | case CMD_DRAW: |
| 887 | return "CMD_DRAW"; |
| 888 | case CMD_DRAWINDEXED: |
| 889 | return "CMD_DRAWINDEXED"; |
| 890 | case CMD_DRAWINDIRECT: |
| 891 | return "CMD_DRAWINDIRECT"; |
| 892 | case CMD_DRAWINDEXEDINDIRECT: |
| 893 | return "CMD_DRAWINDEXEDINDIRECT"; |
| 894 | case CMD_DISPATCH: |
| 895 | return "CMD_DISPATCH"; |
| 896 | case CMD_DISPATCHINDIRECT: |
| 897 | return "CMD_DISPATCHINDIRECT"; |
| 898 | case CMD_COPYBUFFER: |
| 899 | return "CMD_COPYBUFFER"; |
| 900 | case CMD_COPYIMAGE: |
| 901 | return "CMD_COPYIMAGE"; |
| 902 | case CMD_BLITIMAGE: |
| 903 | return "CMD_BLITIMAGE"; |
| 904 | case CMD_COPYBUFFERTOIMAGE: |
| 905 | return "CMD_COPYBUFFERTOIMAGE"; |
| 906 | case CMD_COPYIMAGETOBUFFER: |
| 907 | return "CMD_COPYIMAGETOBUFFER"; |
| 908 | case CMD_CLONEIMAGEDATA: |
| 909 | return "CMD_CLONEIMAGEDATA"; |
| 910 | case CMD_UPDATEBUFFER: |
| 911 | return "CMD_UPDATEBUFFER"; |
| 912 | case CMD_FILLBUFFER: |
| 913 | return "CMD_FILLBUFFER"; |
| 914 | case CMD_CLEARCOLORIMAGE: |
| 915 | return "CMD_CLEARCOLORIMAGE"; |
| 916 | case CMD_CLEARATTACHMENTS: |
| 917 | return "CMD_CLEARCOLORATTACHMENT"; |
| 918 | case CMD_CLEARDEPTHSTENCILIMAGE: |
| 919 | return "CMD_CLEARDEPTHSTENCILIMAGE"; |
| 920 | case CMD_RESOLVEIMAGE: |
| 921 | return "CMD_RESOLVEIMAGE"; |
| 922 | case CMD_SETEVENT: |
| 923 | return "CMD_SETEVENT"; |
| 924 | case CMD_RESETEVENT: |
| 925 | return "CMD_RESETEVENT"; |
| 926 | case CMD_WAITEVENTS: |
| 927 | return "CMD_WAITEVENTS"; |
| 928 | case CMD_PIPELINEBARRIER: |
| 929 | return "CMD_PIPELINEBARRIER"; |
| 930 | case CMD_BEGINQUERY: |
| 931 | return "CMD_BEGINQUERY"; |
| 932 | case CMD_ENDQUERY: |
| 933 | return "CMD_ENDQUERY"; |
| 934 | case CMD_RESETQUERYPOOL: |
| 935 | return "CMD_RESETQUERYPOOL"; |
| 936 | case CMD_COPYQUERYPOOLRESULTS: |
| 937 | return "CMD_COPYQUERYPOOLRESULTS"; |
| 938 | case CMD_WRITETIMESTAMP: |
| 939 | return "CMD_WRITETIMESTAMP"; |
| 940 | case CMD_INITATOMICCOUNTERS: |
| 941 | return "CMD_INITATOMICCOUNTERS"; |
| 942 | case CMD_LOADATOMICCOUNTERS: |
| 943 | return "CMD_LOADATOMICCOUNTERS"; |
| 944 | case CMD_SAVEATOMICCOUNTERS: |
| 945 | return "CMD_SAVEATOMICCOUNTERS"; |
| 946 | case CMD_BEGINRENDERPASS: |
| 947 | return "CMD_BEGINRENDERPASS"; |
| 948 | case CMD_ENDRENDERPASS: |
| 949 | return "CMD_ENDRENDERPASS"; |
| 950 | default: |
| 951 | return "UNKNOWN"; |
| 952 | } |
| 953 | } |
| 954 | |
| 955 | // SPIRV utility functions |
| 956 | static void build_def_index(shader_module *module) { |
| 957 | for (auto insn : *module) { |
| 958 | switch (insn.opcode()) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 959 | // Types |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 960 | case spv::OpTypeVoid: |
| 961 | case spv::OpTypeBool: |
| 962 | case spv::OpTypeInt: |
| 963 | case spv::OpTypeFloat: |
| 964 | case spv::OpTypeVector: |
| 965 | case spv::OpTypeMatrix: |
| 966 | case spv::OpTypeImage: |
| 967 | case spv::OpTypeSampler: |
| 968 | case spv::OpTypeSampledImage: |
| 969 | case spv::OpTypeArray: |
| 970 | case spv::OpTypeRuntimeArray: |
| 971 | case spv::OpTypeStruct: |
| 972 | case spv::OpTypeOpaque: |
| 973 | case spv::OpTypePointer: |
| 974 | case spv::OpTypeFunction: |
| 975 | case spv::OpTypeEvent: |
| 976 | case spv::OpTypeDeviceEvent: |
| 977 | case spv::OpTypeReserveId: |
| 978 | case spv::OpTypeQueue: |
| 979 | case spv::OpTypePipe: |
| 980 | module->def_index[insn.word(1)] = insn.offset(); |
| 981 | break; |
| 982 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 983 | // Fixed constants |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 984 | case spv::OpConstantTrue: |
| 985 | case spv::OpConstantFalse: |
| 986 | case spv::OpConstant: |
| 987 | case spv::OpConstantComposite: |
| 988 | case spv::OpConstantSampler: |
| 989 | case spv::OpConstantNull: |
| 990 | module->def_index[insn.word(2)] = insn.offset(); |
| 991 | break; |
| 992 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 993 | // Specialization constants |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 994 | case spv::OpSpecConstantTrue: |
| 995 | case spv::OpSpecConstantFalse: |
| 996 | case spv::OpSpecConstant: |
| 997 | case spv::OpSpecConstantComposite: |
| 998 | case spv::OpSpecConstantOp: |
| 999 | module->def_index[insn.word(2)] = insn.offset(); |
| 1000 | break; |
| 1001 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1002 | // Variables |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1003 | case spv::OpVariable: |
| 1004 | module->def_index[insn.word(2)] = insn.offset(); |
| 1005 | break; |
| 1006 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1007 | // Functions |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1008 | case spv::OpFunction: |
| 1009 | module->def_index[insn.word(2)] = insn.offset(); |
| 1010 | break; |
| 1011 | |
| 1012 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1013 | // We don't care about any other defs for now. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1014 | break; |
| 1015 | } |
| 1016 | } |
| 1017 | } |
| 1018 | |
| 1019 | static spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { |
| 1020 | for (auto insn : *src) { |
| 1021 | if (insn.opcode() == spv::OpEntryPoint) { |
| 1022 | auto entrypointName = (char const *)&insn.word(3); |
| 1023 | auto entrypointStageBits = 1u << insn.word(1); |
| 1024 | |
| 1025 | if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { |
| 1026 | return insn; |
| 1027 | } |
| 1028 | } |
| 1029 | } |
| 1030 | |
| 1031 | return src->end(); |
| 1032 | } |
| 1033 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1034 | static char const *storage_class_name(unsigned sc) { |
| 1035 | switch (sc) { |
| 1036 | case spv::StorageClassInput: |
| 1037 | return "input"; |
| 1038 | case spv::StorageClassOutput: |
| 1039 | return "output"; |
| 1040 | case spv::StorageClassUniformConstant: |
| 1041 | return "const uniform"; |
| 1042 | case spv::StorageClassUniform: |
| 1043 | return "uniform"; |
| 1044 | case spv::StorageClassWorkgroup: |
| 1045 | return "workgroup local"; |
| 1046 | case spv::StorageClassCrossWorkgroup: |
| 1047 | return "workgroup global"; |
| 1048 | case spv::StorageClassPrivate: |
| 1049 | return "private global"; |
| 1050 | case spv::StorageClassFunction: |
| 1051 | return "function"; |
| 1052 | case spv::StorageClassGeneric: |
| 1053 | return "generic"; |
| 1054 | case spv::StorageClassAtomicCounter: |
| 1055 | return "atomic counter"; |
| 1056 | case spv::StorageClassImage: |
| 1057 | return "image"; |
| 1058 | case spv::StorageClassPushConstant: |
| 1059 | return "push constant"; |
| 1060 | default: |
| 1061 | return "unknown"; |
| 1062 | } |
| 1063 | } |
| 1064 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1065 | // Get the value of an integral constant |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1066 | unsigned get_constant_value(shader_module const *src, unsigned id) { |
| 1067 | auto value = src->get_def(id); |
| 1068 | assert(value != src->end()); |
| 1069 | |
| 1070 | if (value.opcode() != spv::OpConstant) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1071 | // TODO: Either ensure that the specialization transform is already performed on a module we're |
| 1072 | // considering here, OR -- specialize on the fly now. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1073 | return 1; |
| 1074 | } |
| 1075 | |
| 1076 | return value.word(3); |
| 1077 | } |
| 1078 | |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1079 | |
| 1080 | static void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1081 | auto insn = src->get_def(type); |
| 1082 | assert(insn != src->end()); |
| 1083 | |
| 1084 | switch (insn.opcode()) { |
| 1085 | case spv::OpTypeBool: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1086 | ss << "bool"; |
| 1087 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1088 | case spv::OpTypeInt: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1089 | ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); |
| 1090 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1091 | case spv::OpTypeFloat: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1092 | ss << "float" << insn.word(2); |
| 1093 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1094 | case spv::OpTypeVector: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1095 | ss << "vec" << insn.word(3) << " of "; |
| 1096 | describe_type_inner(ss, src, insn.word(2)); |
| 1097 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1098 | case spv::OpTypeMatrix: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1099 | ss << "mat" << insn.word(3) << " of "; |
| 1100 | describe_type_inner(ss, src, insn.word(2)); |
| 1101 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1102 | case spv::OpTypeArray: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1103 | ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; |
| 1104 | describe_type_inner(ss, src, insn.word(2)); |
| 1105 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1106 | case spv::OpTypePointer: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1107 | ss << "ptr to " << storage_class_name(insn.word(2)) << " "; |
| 1108 | describe_type_inner(ss, src, insn.word(3)); |
| 1109 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1110 | case spv::OpTypeStruct: { |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1111 | ss << "struct of ("; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1112 | for (unsigned i = 2; i < insn.len(); i++) { |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1113 | describe_type_inner(ss, src, insn.word(i)); |
| 1114 | if (i == insn.len() - 1) { |
| 1115 | ss << ")"; |
| 1116 | } else { |
| 1117 | ss << ", "; |
| 1118 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1119 | } |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1120 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1121 | } |
| 1122 | case spv::OpTypeSampler: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1123 | ss << "sampler"; |
| 1124 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1125 | case spv::OpTypeSampledImage: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1126 | ss << "sampler+"; |
| 1127 | describe_type_inner(ss, src, insn.word(2)); |
| 1128 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1129 | case spv::OpTypeImage: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1130 | ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; |
| 1131 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1132 | default: |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1133 | ss << "oddtype"; |
| 1134 | break; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1135 | } |
| 1136 | } |
| 1137 | |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1138 | |
| 1139 | static std::string describe_type(shader_module const *src, unsigned type) { |
| 1140 | std::ostringstream ss; |
| 1141 | describe_type_inner(ss, src, type); |
| 1142 | return ss.str(); |
| 1143 | } |
| 1144 | |
| 1145 | |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1146 | static bool is_narrow_numeric_type(spirv_inst_iter type) |
| 1147 | { |
| 1148 | if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) |
| 1149 | return false; |
| 1150 | return type.word(2) < 64; |
| 1151 | } |
| 1152 | |
| 1153 | |
| 1154 | static bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1155 | // Walk two type trees together, and complain about differences |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1156 | auto a_insn = a->get_def(a_type); |
| 1157 | auto b_insn = b->get_def(b_type); |
| 1158 | assert(a_insn != a->end()); |
| 1159 | assert(b_insn != b->end()); |
| 1160 | |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1161 | if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1162 | return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1163 | } |
| 1164 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1165 | if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1166 | // We probably just found the extra level of arrayness in b_type: compare the type inside it to a_type |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1167 | return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); |
| 1168 | } |
| 1169 | |
| 1170 | if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { |
| 1171 | return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1172 | } |
| 1173 | |
| 1174 | if (a_insn.opcode() != b_insn.opcode()) { |
| 1175 | return false; |
| 1176 | } |
| 1177 | |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1178 | if (a_insn.opcode() == spv::OpTypePointer) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1179 | // Match on pointee type. storage class is expected to differ |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1180 | return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1181 | } |
| 1182 | |
| 1183 | if (a_arrayed || b_arrayed) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1184 | // If we havent resolved array-of-verts by here, we're not going to. |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1185 | return false; |
| 1186 | } |
| 1187 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1188 | switch (a_insn.opcode()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1189 | case spv::OpTypeBool: |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1190 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1191 | case spv::OpTypeInt: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1192 | // Match on width, signedness |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1193 | return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1194 | case spv::OpTypeFloat: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1195 | // Match on width |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1196 | return a_insn.word(2) == b_insn.word(2); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1197 | case spv::OpTypeVector: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1198 | // Match on element type, count. |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1199 | if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) |
| 1200 | return false; |
| 1201 | if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { |
| 1202 | return a_insn.word(3) >= b_insn.word(3); |
| 1203 | } |
| 1204 | else { |
| 1205 | return a_insn.word(3) == b_insn.word(3); |
| 1206 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1207 | case spv::OpTypeMatrix: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1208 | // Match on element type, count. |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1209 | return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1210 | case spv::OpTypeArray: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1211 | // Match on element type, count. these all have the same layout. we don't get here if b_arrayed. This differs from |
| 1212 | // vector & matrix types in that the array size is the id of a constant instruction, * not a literal within OpTypeArray |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1213 | return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1214 | get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); |
| 1215 | case spv::OpTypeStruct: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1216 | // Match on all element types |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1217 | { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1218 | if (a_insn.len() != b_insn.len()) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1219 | return false; // Structs cannot match if member counts differ |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1220 | } |
| 1221 | |
| 1222 | for (unsigned i = 2; i < a_insn.len(); i++) { |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1223 | if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1224 | return false; |
| 1225 | } |
| 1226 | } |
| 1227 | |
| 1228 | return true; |
| 1229 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1230 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1231 | // Remaining types are CLisms, or may not appear in the interfaces we are interested in. Just claim no match. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1232 | return false; |
| 1233 | } |
| 1234 | } |
| 1235 | |
| 1236 | static int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { |
| 1237 | auto it = map.find(id); |
| 1238 | if (it == map.end()) |
| 1239 | return def; |
| 1240 | else |
| 1241 | return it->second; |
| 1242 | } |
| 1243 | |
| 1244 | static unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { |
| 1245 | auto insn = src->get_def(type); |
| 1246 | assert(insn != src->end()); |
| 1247 | |
| 1248 | switch (insn.opcode()) { |
| 1249 | case spv::OpTypePointer: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1250 | // See through the ptr -- this is only ever at the toplevel for graphics shaders we're never actually passing |
| 1251 | // pointers around. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1252 | return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); |
| 1253 | case spv::OpTypeArray: |
| 1254 | if (strip_array_level) { |
| 1255 | return get_locations_consumed_by_type(src, insn.word(2), false); |
| 1256 | } else { |
| 1257 | return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); |
| 1258 | } |
| 1259 | case spv::OpTypeMatrix: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1260 | // Num locations is the dimension * element size |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1261 | return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); |
Chris Forbes | b91daf0 | 2016-04-21 14:46:48 +1200 | [diff] [blame] | 1262 | case spv::OpTypeVector: { |
| 1263 | auto scalar_type = src->get_def(insn.word(2)); |
| 1264 | auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? |
| 1265 | scalar_type.word(2) : 32; |
| 1266 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1267 | // Locations are 128-bit wide; 3- and 4-component vectors of 64 bit types require two. |
Chris Forbes | b91daf0 | 2016-04-21 14:46:48 +1200 | [diff] [blame] | 1268 | return (bit_width * insn.word(3) + 127) / 128; |
| 1269 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1270 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1271 | // Everything else is just 1. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1272 | return 1; |
| 1273 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1274 | // TODO: extend to handle 64bit scalar types, whose vectors may need multiple locations. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1275 | } |
| 1276 | } |
| 1277 | |
Chris Forbes | e32b78a | 2016-04-21 15:00:58 +1200 | [diff] [blame] | 1278 | static unsigned get_locations_consumed_by_format(VkFormat format) { |
| 1279 | switch (format) { |
| 1280 | case VK_FORMAT_R64G64B64A64_SFLOAT: |
| 1281 | case VK_FORMAT_R64G64B64A64_SINT: |
| 1282 | case VK_FORMAT_R64G64B64A64_UINT: |
| 1283 | case VK_FORMAT_R64G64B64_SFLOAT: |
| 1284 | case VK_FORMAT_R64G64B64_SINT: |
| 1285 | case VK_FORMAT_R64G64B64_UINT: |
| 1286 | return 2; |
| 1287 | default: |
| 1288 | return 1; |
| 1289 | } |
| 1290 | } |
| 1291 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1292 | typedef std::pair<unsigned, unsigned> location_t; |
| 1293 | typedef std::pair<unsigned, unsigned> descriptor_slot_t; |
| 1294 | |
| 1295 | struct interface_var { |
| 1296 | uint32_t id; |
| 1297 | uint32_t type_id; |
| 1298 | uint32_t offset; |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1299 | bool is_patch; |
Chris Forbes | a0ab815 | 2016-04-20 13:34:27 +1200 | [diff] [blame] | 1300 | bool is_block_member; |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1301 | bool is_relaxed_precision; |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1302 | // TODO: collect the name, too? Isn't required to be present. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1303 | }; |
| 1304 | |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1305 | struct shader_stage_attributes { |
| 1306 | char const *const name; |
| 1307 | bool arrayed_input; |
| 1308 | bool arrayed_output; |
| 1309 | }; |
| 1310 | |
| 1311 | static shader_stage_attributes shader_stage_attribs[] = { |
| 1312 | {"vertex shader", false, false}, |
| 1313 | {"tessellation control shader", true, true}, |
| 1314 | {"tessellation evaluation shader", true, false}, |
| 1315 | {"geometry shader", true, false}, |
| 1316 | {"fragment shader", false, false}, |
| 1317 | }; |
| 1318 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1319 | static spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { |
| 1320 | while (true) { |
| 1321 | |
| 1322 | if (def.opcode() == spv::OpTypePointer) { |
| 1323 | def = src->get_def(def.word(3)); |
| 1324 | } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { |
| 1325 | def = src->get_def(def.word(2)); |
| 1326 | is_array_of_verts = false; |
| 1327 | } else if (def.opcode() == spv::OpTypeStruct) { |
| 1328 | return def; |
| 1329 | } else { |
| 1330 | return src->end(); |
| 1331 | } |
| 1332 | } |
| 1333 | } |
| 1334 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1335 | static void collect_interface_block_members(shader_module const *src, |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1336 | std::map<location_t, interface_var> *out, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1337 | std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1338 | uint32_t id, uint32_t type_id, bool is_patch) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1339 | // Walk down the type_id presented, trying to determine whether it's actually an interface block. |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1340 | auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1341 | if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1342 | // This isn't an interface block. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1343 | return; |
| 1344 | } |
| 1345 | |
| 1346 | std::unordered_map<unsigned, unsigned> member_components; |
Chris Forbes | f929b16 | 2016-11-30 12:55:40 +1300 | [diff] [blame] | 1347 | std::unordered_map<unsigned, unsigned> member_relaxed_precision; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1348 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1349 | // Walk all the OpMemberDecorate for type's result id -- first pass, collect components. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1350 | for (auto insn : *src) { |
| 1351 | if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { |
| 1352 | unsigned member_index = insn.word(2); |
| 1353 | |
| 1354 | if (insn.word(3) == spv::DecorationComponent) { |
| 1355 | unsigned component = insn.word(4); |
| 1356 | member_components[member_index] = component; |
| 1357 | } |
Chris Forbes | f929b16 | 2016-11-30 12:55:40 +1300 | [diff] [blame] | 1358 | |
| 1359 | if (insn.word(3) == spv::DecorationRelaxedPrecision) { |
| 1360 | member_relaxed_precision[member_index] = 1; |
| 1361 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1362 | } |
| 1363 | } |
| 1364 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1365 | // Second pass -- produce the output, from Location decorations |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1366 | for (auto insn : *src) { |
| 1367 | if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { |
| 1368 | unsigned member_index = insn.word(2); |
| 1369 | unsigned member_type_id = type.word(2 + member_index); |
| 1370 | |
| 1371 | if (insn.word(3) == spv::DecorationLocation) { |
| 1372 | unsigned location = insn.word(4); |
| 1373 | unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); |
| 1374 | auto component_it = member_components.find(member_index); |
| 1375 | unsigned component = component_it == member_components.end() ? 0 : component_it->second; |
Chris Forbes | f929b16 | 2016-11-30 12:55:40 +1300 | [diff] [blame] | 1376 | bool is_relaxed_precision = member_relaxed_precision.find(member_index) != member_relaxed_precision.end(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1377 | |
| 1378 | for (unsigned int offset = 0; offset < num_locations; offset++) { |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1379 | interface_var v = {}; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1380 | v.id = id; |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1381 | // TODO: member index in interface_var too? |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1382 | v.type_id = member_type_id; |
| 1383 | v.offset = offset; |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1384 | v.is_patch = is_patch; |
Chris Forbes | a0ab815 | 2016-04-20 13:34:27 +1200 | [diff] [blame] | 1385 | v.is_block_member = true; |
Chris Forbes | f929b16 | 2016-11-30 12:55:40 +1300 | [diff] [blame] | 1386 | v.is_relaxed_precision = is_relaxed_precision; |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1387 | (*out)[std::make_pair(location + offset, component)] = v; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1388 | } |
| 1389 | } |
| 1390 | } |
| 1391 | } |
| 1392 | } |
| 1393 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1394 | static std::map<location_t, interface_var> collect_interface_by_location( |
| 1395 | shader_module const *src, spirv_inst_iter entrypoint, |
| 1396 | spv::StorageClass sinterface, bool is_array_of_verts) { |
| 1397 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1398 | std::unordered_map<unsigned, unsigned> var_locations; |
| 1399 | std::unordered_map<unsigned, unsigned> var_builtins; |
| 1400 | std::unordered_map<unsigned, unsigned> var_components; |
| 1401 | std::unordered_map<unsigned, unsigned> blocks; |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1402 | std::unordered_map<unsigned, unsigned> var_patch; |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1403 | std::unordered_map<unsigned, unsigned> var_relaxed_precision; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1404 | |
| 1405 | for (auto insn : *src) { |
| 1406 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1407 | // We consider two interface models: SSO rendezvous-by-location, and builtins. Complain about anything that |
| 1408 | // fits neither model. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1409 | if (insn.opcode() == spv::OpDecorate) { |
| 1410 | if (insn.word(2) == spv::DecorationLocation) { |
| 1411 | var_locations[insn.word(1)] = insn.word(3); |
| 1412 | } |
| 1413 | |
| 1414 | if (insn.word(2) == spv::DecorationBuiltIn) { |
| 1415 | var_builtins[insn.word(1)] = insn.word(3); |
| 1416 | } |
| 1417 | |
| 1418 | if (insn.word(2) == spv::DecorationComponent) { |
| 1419 | var_components[insn.word(1)] = insn.word(3); |
| 1420 | } |
| 1421 | |
| 1422 | if (insn.word(2) == spv::DecorationBlock) { |
| 1423 | blocks[insn.word(1)] = 1; |
| 1424 | } |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1425 | |
| 1426 | if (insn.word(2) == spv::DecorationPatch) { |
| 1427 | var_patch[insn.word(1)] = 1; |
| 1428 | } |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1429 | |
| 1430 | if (insn.word(2) == spv::DecorationRelaxedPrecision) { |
| 1431 | var_relaxed_precision[insn.word(1)] = 1; |
| 1432 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1433 | } |
| 1434 | } |
| 1435 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1436 | // TODO: handle grouped decorations |
| 1437 | // TODO: handle index=1 dual source outputs from FS -- two vars will have the same location, and we DON'T want to clobber. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1438 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1439 | // Find the end of the entrypoint's name string. additional zero bytes follow the actual null terminator, to fill out the |
| 1440 | // rest of the word - so we only need to look at the last byte in the word to determine which word contains the terminator. |
Michael Mc Donnell | 75ecdb7 | 2016-04-03 14:47:51 -0700 | [diff] [blame] | 1441 | uint32_t word = 3; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1442 | while (entrypoint.word(word) & 0xff000000u) { |
| 1443 | ++word; |
| 1444 | } |
| 1445 | ++word; |
| 1446 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1447 | std::map<location_t, interface_var> out; |
| 1448 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1449 | for (; word < entrypoint.len(); word++) { |
| 1450 | auto insn = src->get_def(entrypoint.word(word)); |
| 1451 | assert(insn != src->end()); |
| 1452 | assert(insn.opcode() == spv::OpVariable); |
| 1453 | |
Jamie Madill | 2b6b8d5 | 2016-04-04 15:09:51 -0400 | [diff] [blame] | 1454 | if (insn.word(3) == static_cast<uint32_t>(sinterface)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1455 | unsigned id = insn.word(2); |
| 1456 | unsigned type = insn.word(1); |
| 1457 | |
| 1458 | int location = value_or_default(var_locations, id, -1); |
| 1459 | int builtin = value_or_default(var_builtins, id, -1); |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1460 | unsigned component = value_or_default(var_components, id, 0); // Unspecified is OK, is 0 |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1461 | bool is_patch = var_patch.find(id) != var_patch.end(); |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1462 | bool is_relaxed_precision = var_relaxed_precision.find(id) != var_relaxed_precision.end(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1463 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1464 | // All variables and interface block members in the Input or Output storage classes must be decorated with either |
| 1465 | // a builtin or an explicit location. |
| 1466 | // |
| 1467 | // TODO: integrate the interface block support here. For now, don't complain -- a valid SPIRV module will only hit |
| 1468 | // this path for the interface block case, as the individual members of the type are decorated, rather than |
| 1469 | // variable declarations. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1470 | |
| 1471 | if (location != -1) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1472 | // A user-defined interface variable, with a location. Where a variable occupied multiple locations, emit |
| 1473 | // one result for each. |
Chris Forbes | 43f01d0 | 2016-03-29 16:38:44 +1300 | [diff] [blame] | 1474 | unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1475 | for (unsigned int offset = 0; offset < num_locations; offset++) { |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1476 | interface_var v = {}; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1477 | v.id = id; |
| 1478 | v.type_id = type; |
| 1479 | v.offset = offset; |
Chris Forbes | 804bae3 | 2016-03-29 16:14:02 +1300 | [diff] [blame] | 1480 | v.is_patch = is_patch; |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1481 | v.is_relaxed_precision = is_relaxed_precision; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1482 | out[std::make_pair(location + offset, component)] = v; |
| 1483 | } |
| 1484 | } else if (builtin == -1) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1485 | // An interface block instance |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1486 | collect_interface_block_members(src, &out, blocks, is_array_of_verts, id, type, is_patch); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1487 | } |
| 1488 | } |
| 1489 | } |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1490 | |
| 1491 | return out; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1492 | } |
| 1493 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1494 | static std::vector<std::pair<uint32_t, interface_var>> collect_interface_by_input_attachment_index( |
| 1495 | debug_report_data *report_data, shader_module const *src, |
| 1496 | std::unordered_set<uint32_t> const &accessible_ids) { |
| 1497 | |
| 1498 | std::vector<std::pair<uint32_t, interface_var>> out; |
Chris Forbes | 07ac1f3 | 2016-08-22 14:58:35 +1200 | [diff] [blame] | 1499 | |
| 1500 | for (auto insn : *src) { |
| 1501 | if (insn.opcode() == spv::OpDecorate) { |
| 1502 | if (insn.word(2) == spv::DecorationInputAttachmentIndex) { |
| 1503 | auto attachment_index = insn.word(3); |
| 1504 | auto id = insn.word(1); |
| 1505 | |
| 1506 | if (accessible_ids.count(id)) { |
| 1507 | auto def = src->get_def(id); |
| 1508 | assert(def != src->end()); |
| 1509 | |
| 1510 | if (def.opcode() == spv::OpVariable && insn.word(3) == spv::StorageClassUniformConstant) { |
Chris Forbes | 56f2845 | 2016-08-22 15:31:18 +1200 | [diff] [blame] | 1511 | auto num_locations = get_locations_consumed_by_type(src, def.word(1), false); |
| 1512 | for (unsigned int offset = 0; offset < num_locations; offset++) { |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1513 | interface_var v = {}; |
Chris Forbes | 56f2845 | 2016-08-22 15:31:18 +1200 | [diff] [blame] | 1514 | v.id = id; |
| 1515 | v.type_id = def.word(1); |
| 1516 | v.offset = offset; |
Chris Forbes | 56f2845 | 2016-08-22 15:31:18 +1200 | [diff] [blame] | 1517 | out.emplace_back(attachment_index + offset, v); |
| 1518 | } |
Chris Forbes | 07ac1f3 | 2016-08-22 14:58:35 +1200 | [diff] [blame] | 1519 | } |
| 1520 | } |
| 1521 | } |
| 1522 | } |
| 1523 | } |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1524 | |
| 1525 | return out; |
Chris Forbes | 07ac1f3 | 2016-08-22 14:58:35 +1200 | [diff] [blame] | 1526 | } |
| 1527 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1528 | static std::vector<std::pair<descriptor_slot_t, interface_var>> collect_interface_by_descriptor_slot( |
| 1529 | debug_report_data *report_data, shader_module const *src, |
| 1530 | std::unordered_set<uint32_t> const &accessible_ids) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1531 | |
| 1532 | std::unordered_map<unsigned, unsigned> var_sets; |
| 1533 | std::unordered_map<unsigned, unsigned> var_bindings; |
| 1534 | |
| 1535 | for (auto insn : *src) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1536 | // All variables in the Uniform or UniformConstant storage classes are required to be decorated with both |
| 1537 | // DecorationDescriptorSet and DecorationBinding. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1538 | if (insn.opcode() == spv::OpDecorate) { |
| 1539 | if (insn.word(2) == spv::DecorationDescriptorSet) { |
| 1540 | var_sets[insn.word(1)] = insn.word(3); |
| 1541 | } |
| 1542 | |
| 1543 | if (insn.word(2) == spv::DecorationBinding) { |
| 1544 | var_bindings[insn.word(1)] = insn.word(3); |
| 1545 | } |
| 1546 | } |
| 1547 | } |
| 1548 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1549 | std::vector<std::pair<descriptor_slot_t, interface_var>> out; |
| 1550 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1551 | for (auto id : accessible_ids) { |
| 1552 | auto insn = src->get_def(id); |
| 1553 | assert(insn != src->end()); |
| 1554 | |
| 1555 | if (insn.opcode() == spv::OpVariable && |
| 1556 | (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { |
| 1557 | unsigned set = value_or_default(var_sets, insn.word(2), 0); |
| 1558 | unsigned binding = value_or_default(var_bindings, insn.word(2), 0); |
| 1559 | |
Chris Forbes | a115276 | 2016-11-30 12:40:54 +1300 | [diff] [blame] | 1560 | interface_var v = {}; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1561 | v.id = insn.word(2); |
| 1562 | v.type_id = insn.word(1); |
Chris Forbes | be8986a | 2016-07-19 15:08:38 +1200 | [diff] [blame] | 1563 | out.emplace_back(std::make_pair(set, binding), v); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1564 | } |
| 1565 | } |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1566 | |
| 1567 | return out; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1568 | } |
| 1569 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1570 | static bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1571 | spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1572 | shader_module const *consumer, spirv_inst_iter consumer_entrypoint, |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1573 | shader_stage_attributes const *consumer_stage) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1574 | bool pass = true; |
| 1575 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1576 | auto outputs = collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, producer_stage->arrayed_output); |
| 1577 | auto inputs = collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, consumer_stage->arrayed_input); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1578 | |
| 1579 | auto a_it = outputs.begin(); |
| 1580 | auto b_it = inputs.begin(); |
| 1581 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1582 | // Maps sorted by key (location); walk them together to find mismatches |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1583 | while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { |
| 1584 | bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); |
| 1585 | bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); |
| 1586 | auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; |
| 1587 | auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; |
| 1588 | |
| 1589 | if (b_at_end || ((!a_at_end) && (a_first < b_first))) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1590 | if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 1591 | __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1592 | "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, |
| 1593 | a_first.second, consumer_stage->name)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1594 | pass = false; |
| 1595 | } |
| 1596 | a_it++; |
| 1597 | } else if (a_at_end || a_first > b_first) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1598 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1599 | __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 1600 | "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, |
| 1601 | producer_stage->name)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1602 | pass = false; |
| 1603 | } |
| 1604 | b_it++; |
| 1605 | } else { |
Chris Forbes | a0ab815 | 2016-04-20 13:34:27 +1200 | [diff] [blame] | 1606 | // subtleties of arrayed interfaces: |
| 1607 | // - if is_patch, then the member is not arrayed, even though the interface may be. |
| 1608 | // - if is_block_member, then the extra array level of an arrayed interface is not |
| 1609 | // expressed in the member type -- it's expressed in the block type. |
Chris Forbes | 218deeb | 2016-03-29 16:57:02 +1300 | [diff] [blame] | 1610 | if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, |
Chris Forbes | a0ab815 | 2016-04-20 13:34:27 +1200 | [diff] [blame] | 1611 | producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, |
| 1612 | consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, |
Chris Forbes | 4ad9cbd | 2016-04-05 17:51:35 +1200 | [diff] [blame] | 1613 | true)) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1614 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1615 | __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1616 | a_first.first, a_first.second, |
| 1617 | describe_type(producer, a_it->second.type_id).c_str(), |
| 1618 | describe_type(consumer, b_it->second.type_id).c_str())) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1619 | pass = false; |
| 1620 | } |
| 1621 | } |
Chris Forbes | 218deeb | 2016-03-29 16:57:02 +1300 | [diff] [blame] | 1622 | if (a_it->second.is_patch != b_it->second.is_patch) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1623 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 0, |
Chris Forbes | 218deeb | 2016-03-29 16:57:02 +1300 | [diff] [blame] | 1624 | __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
Chris Forbes | a0193bc | 2016-04-04 19:19:47 +1200 | [diff] [blame] | 1625 | "Decoration mismatch on location %u.%u: is per-%s in %s stage but " |
Chris Forbes | 218deeb | 2016-03-29 16:57:02 +1300 | [diff] [blame] | 1626 | "per-%s in %s stage", a_first.first, a_first.second, |
| 1627 | a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, |
| 1628 | b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { |
| 1629 | pass = false; |
| 1630 | } |
| 1631 | } |
Chris Forbes | 4420839 | 2016-11-30 12:45:00 +1300 | [diff] [blame] | 1632 | if (a_it->second.is_relaxed_precision != b_it->second.is_relaxed_precision) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1633 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 0, |
Chris Forbes | 4420839 | 2016-11-30 12:45:00 +1300 | [diff] [blame] | 1634 | __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
| 1635 | "Decoration mismatch on location %u.%u: %s and %s stages differ in precision", |
| 1636 | a_first.first, a_first.second, |
| 1637 | producer_stage->name, |
| 1638 | consumer_stage->name)) { |
| 1639 | pass = false; |
| 1640 | } |
| 1641 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1642 | a_it++; |
| 1643 | b_it++; |
| 1644 | } |
| 1645 | } |
| 1646 | |
| 1647 | return pass; |
| 1648 | } |
| 1649 | |
| 1650 | enum FORMAT_TYPE { |
| 1651 | FORMAT_TYPE_UNDEFINED, |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1652 | FORMAT_TYPE_FLOAT, // UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1653 | FORMAT_TYPE_SINT, |
| 1654 | FORMAT_TYPE_UINT, |
| 1655 | }; |
| 1656 | |
| 1657 | static unsigned get_format_type(VkFormat fmt) { |
| 1658 | switch (fmt) { |
| 1659 | case VK_FORMAT_UNDEFINED: |
| 1660 | return FORMAT_TYPE_UNDEFINED; |
| 1661 | case VK_FORMAT_R8_SINT: |
| 1662 | case VK_FORMAT_R8G8_SINT: |
| 1663 | case VK_FORMAT_R8G8B8_SINT: |
| 1664 | case VK_FORMAT_R8G8B8A8_SINT: |
| 1665 | case VK_FORMAT_R16_SINT: |
| 1666 | case VK_FORMAT_R16G16_SINT: |
| 1667 | case VK_FORMAT_R16G16B16_SINT: |
| 1668 | case VK_FORMAT_R16G16B16A16_SINT: |
| 1669 | case VK_FORMAT_R32_SINT: |
| 1670 | case VK_FORMAT_R32G32_SINT: |
| 1671 | case VK_FORMAT_R32G32B32_SINT: |
| 1672 | case VK_FORMAT_R32G32B32A32_SINT: |
Chris Forbes | f57a520 | 2016-04-20 14:22:07 +1200 | [diff] [blame] | 1673 | case VK_FORMAT_R64_SINT: |
| 1674 | case VK_FORMAT_R64G64_SINT: |
| 1675 | case VK_FORMAT_R64G64B64_SINT: |
| 1676 | case VK_FORMAT_R64G64B64A64_SINT: |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1677 | case VK_FORMAT_B8G8R8_SINT: |
| 1678 | case VK_FORMAT_B8G8R8A8_SINT: |
Chris Forbes | e9a21d4 | 2016-04-20 14:16:10 +1200 | [diff] [blame] | 1679 | case VK_FORMAT_A8B8G8R8_SINT_PACK32: |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1680 | case VK_FORMAT_A2B10G10R10_SINT_PACK32: |
| 1681 | case VK_FORMAT_A2R10G10B10_SINT_PACK32: |
| 1682 | return FORMAT_TYPE_SINT; |
| 1683 | case VK_FORMAT_R8_UINT: |
| 1684 | case VK_FORMAT_R8G8_UINT: |
| 1685 | case VK_FORMAT_R8G8B8_UINT: |
| 1686 | case VK_FORMAT_R8G8B8A8_UINT: |
| 1687 | case VK_FORMAT_R16_UINT: |
| 1688 | case VK_FORMAT_R16G16_UINT: |
| 1689 | case VK_FORMAT_R16G16B16_UINT: |
| 1690 | case VK_FORMAT_R16G16B16A16_UINT: |
| 1691 | case VK_FORMAT_R32_UINT: |
| 1692 | case VK_FORMAT_R32G32_UINT: |
| 1693 | case VK_FORMAT_R32G32B32_UINT: |
| 1694 | case VK_FORMAT_R32G32B32A32_UINT: |
Chris Forbes | f57a520 | 2016-04-20 14:22:07 +1200 | [diff] [blame] | 1695 | case VK_FORMAT_R64_UINT: |
| 1696 | case VK_FORMAT_R64G64_UINT: |
| 1697 | case VK_FORMAT_R64G64B64_UINT: |
| 1698 | case VK_FORMAT_R64G64B64A64_UINT: |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1699 | case VK_FORMAT_B8G8R8_UINT: |
| 1700 | case VK_FORMAT_B8G8R8A8_UINT: |
Chris Forbes | e9a21d4 | 2016-04-20 14:16:10 +1200 | [diff] [blame] | 1701 | case VK_FORMAT_A8B8G8R8_UINT_PACK32: |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1702 | case VK_FORMAT_A2B10G10R10_UINT_PACK32: |
| 1703 | case VK_FORMAT_A2R10G10B10_UINT_PACK32: |
| 1704 | return FORMAT_TYPE_UINT; |
| 1705 | default: |
| 1706 | return FORMAT_TYPE_FLOAT; |
| 1707 | } |
| 1708 | } |
| 1709 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1710 | // characterizes a SPIR-V type appearing in an interface to a FF stage, for comparison to a VkFormat's characterization above. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1711 | static unsigned get_fundamental_type(shader_module const *src, unsigned type) { |
| 1712 | auto insn = src->get_def(type); |
| 1713 | assert(insn != src->end()); |
| 1714 | |
| 1715 | switch (insn.opcode()) { |
| 1716 | case spv::OpTypeInt: |
| 1717 | return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; |
| 1718 | case spv::OpTypeFloat: |
| 1719 | return FORMAT_TYPE_FLOAT; |
| 1720 | case spv::OpTypeVector: |
| 1721 | return get_fundamental_type(src, insn.word(2)); |
| 1722 | case spv::OpTypeMatrix: |
| 1723 | return get_fundamental_type(src, insn.word(2)); |
| 1724 | case spv::OpTypeArray: |
| 1725 | return get_fundamental_type(src, insn.word(2)); |
| 1726 | case spv::OpTypePointer: |
| 1727 | return get_fundamental_type(src, insn.word(3)); |
Chris Forbes | 383352e | 2016-08-22 16:36:54 +1200 | [diff] [blame] | 1728 | case spv::OpTypeImage: |
| 1729 | return get_fundamental_type(src, insn.word(2)); |
| 1730 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1731 | default: |
| 1732 | return FORMAT_TYPE_UNDEFINED; |
| 1733 | } |
| 1734 | } |
| 1735 | |
| 1736 | static uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { |
| 1737 | uint32_t bit_pos = u_ffs(stage); |
| 1738 | return bit_pos - 1; |
| 1739 | } |
| 1740 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1741 | static bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1742 | // Walk the binding descriptions, which describe the step rate and stride of each vertex buffer. Each binding should |
| 1743 | // be specified only once. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1744 | std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; |
| 1745 | bool pass = true; |
| 1746 | |
| 1747 | for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { |
| 1748 | auto desc = &vi->pVertexBindingDescriptions[i]; |
| 1749 | auto &binding = bindings[desc->binding]; |
| 1750 | if (binding) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 1751 | // TODO: VALIDATION_ERROR_02105 perhaps? |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1752 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1753 | __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", |
| 1754 | "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { |
| 1755 | pass = false; |
| 1756 | } |
| 1757 | } else { |
| 1758 | binding = desc; |
| 1759 | } |
| 1760 | } |
| 1761 | |
| 1762 | return pass; |
| 1763 | } |
| 1764 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1765 | static bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1766 | shader_module const *vs, spirv_inst_iter entrypoint) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1767 | bool pass = true; |
| 1768 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1769 | auto inputs = collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, false); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1770 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1771 | // Build index by location |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1772 | std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; |
| 1773 | if (vi) { |
Chris Forbes | e32b78a | 2016-04-21 15:00:58 +1200 | [diff] [blame] | 1774 | for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { |
| 1775 | auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); |
| 1776 | for (auto j = 0u; j < num_locations; j++) { |
| 1777 | attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; |
| 1778 | } |
| 1779 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1780 | } |
| 1781 | |
| 1782 | auto it_a = attribs.begin(); |
| 1783 | auto it_b = inputs.begin(); |
Chris Forbes | 22dd5d2 | 2016-07-06 12:18:26 +1200 | [diff] [blame] | 1784 | bool used = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1785 | |
| 1786 | while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { |
| 1787 | bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); |
| 1788 | bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); |
| 1789 | auto a_first = a_at_end ? 0 : it_a->first; |
| 1790 | auto b_first = b_at_end ? 0 : it_b->first.first; |
| 1791 | if (!a_at_end && (b_at_end || a_first < b_first)) { |
Chris Forbes | 22dd5d2 | 2016-07-06 12:18:26 +1200 | [diff] [blame] | 1792 | if (!used && log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 1793 | __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 1794 | "Vertex attribute at location %d not consumed by vertex shader", a_first)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1795 | pass = false; |
| 1796 | } |
Chris Forbes | 22dd5d2 | 2016-07-06 12:18:26 +1200 | [diff] [blame] | 1797 | used = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1798 | it_a++; |
| 1799 | } else if (!b_at_end && (a_at_end || b_first < a_first)) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1800 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 0, |
Mike Weiblen | 15bd38e | 2016-10-03 19:19:41 -0600 | [diff] [blame] | 1801 | __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Vertex shader consumes input at location %d but not provided", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1802 | b_first)) { |
| 1803 | pass = false; |
| 1804 | } |
| 1805 | it_b++; |
| 1806 | } else { |
| 1807 | unsigned attrib_type = get_format_type(it_a->second->format); |
| 1808 | unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); |
| 1809 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1810 | // Type checking |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1811 | if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1812 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1813 | __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
Mike Weiblen | 15bd38e | 2016-10-03 19:19:41 -0600 | [diff] [blame] | 1814 | "Attribute type of `%s` at location %d does not match vertex shader input type of `%s`", |
Chris Forbes | fa86ce3 | 2016-03-18 14:59:39 +1300 | [diff] [blame] | 1815 | string_VkFormat(it_a->second->format), a_first, |
| 1816 | describe_type(vs, it_b->second.type_id).c_str())) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1817 | pass = false; |
| 1818 | } |
| 1819 | } |
| 1820 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1821 | // OK! |
Chris Forbes | 22dd5d2 | 2016-07-06 12:18:26 +1200 | [diff] [blame] | 1822 | used = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1823 | it_b++; |
| 1824 | } |
| 1825 | } |
| 1826 | |
| 1827 | return pass; |
| 1828 | } |
| 1829 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1830 | static bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 1831 | spirv_inst_iter entrypoint, VkRenderPassCreateInfo const *rpci, |
| 1832 | uint32_t subpass_index) { |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1833 | std::map<uint32_t, VkFormat> color_attachments; |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 1834 | auto subpass = rpci->pSubpasses[subpass_index]; |
| 1835 | for (auto i = 0u; i < subpass.colorAttachmentCount; ++i) { |
Tobin Ehlis | 0265618 | 2016-07-01 13:54:41 -0600 | [diff] [blame] | 1836 | uint32_t attachment = subpass.pColorAttachments[i].attachment; |
| 1837 | if (attachment == VK_ATTACHMENT_UNUSED) |
| 1838 | continue; |
| 1839 | if (rpci->pAttachments[attachment].format != VK_FORMAT_UNDEFINED) { |
| 1840 | color_attachments[i] = rpci->pAttachments[attachment].format; |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1841 | } |
| 1842 | } |
| 1843 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1844 | bool pass = true; |
| 1845 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1846 | // TODO: dual source blend index (spv::DecIndex, zero if not provided) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1847 | |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1848 | auto outputs = collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, false); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1849 | |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1850 | auto it_a = outputs.begin(); |
| 1851 | auto it_b = color_attachments.begin(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1852 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1853 | // Walk attachment list and outputs together |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1854 | |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1855 | while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { |
| 1856 | bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); |
| 1857 | bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); |
| 1858 | |
| 1859 | if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1860 | if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1861 | __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 1862 | "fragment shader writes to output location %d with no matching attachment", it_a->first.first)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1863 | pass = false; |
| 1864 | } |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1865 | it_a++; |
| 1866 | } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1867 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 1868 | __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by fragment shader", |
| 1869 | it_b->first)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1870 | pass = false; |
| 1871 | } |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1872 | it_b++; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1873 | } else { |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1874 | unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); |
| 1875 | unsigned att_type = get_format_type(it_b->second); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1876 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1877 | // Type checking |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1878 | if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 1879 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1880 | __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 1881 | "Attachment %d of type `%s` does not match fragment shader output type of `%s`", it_b->first, |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1882 | string_VkFormat(it_b->second), |
| 1883 | describe_type(fs, it_a->second.type_id).c_str())) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1884 | pass = false; |
| 1885 | } |
| 1886 | } |
| 1887 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1888 | // OK! |
Chris Forbes | 7cf00d4 | 2016-04-29 17:33:03 +1200 | [diff] [blame] | 1889 | it_a++; |
| 1890 | it_b++; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1891 | } |
| 1892 | } |
| 1893 | |
| 1894 | return pass; |
| 1895 | } |
| 1896 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1897 | // For some analyses, we need to know about all ids referenced by the static call tree of a particular entrypoint. This is |
| 1898 | // important for identifying the set of shader resources actually used by an entrypoint, for example. |
| 1899 | // Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. |
| 1900 | // - NOT the shader input/output interfaces. |
| 1901 | // |
| 1902 | // TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth |
| 1903 | // converting parts of this to be generated from the machine-readable spec instead. |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 1904 | static std::unordered_set<uint32_t> mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint) { |
| 1905 | std::unordered_set<uint32_t> ids; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1906 | std::unordered_set<uint32_t> worklist; |
| 1907 | worklist.insert(entrypoint.word(2)); |
| 1908 | |
| 1909 | while (!worklist.empty()) { |
| 1910 | auto id_iter = worklist.begin(); |
| 1911 | auto id = *id_iter; |
| 1912 | worklist.erase(id_iter); |
| 1913 | |
| 1914 | auto insn = src->get_def(id); |
| 1915 | if (insn == src->end()) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1916 | // ID is something we didn't collect in build_def_index. that's OK -- we'll stumble across all kinds of things here |
| 1917 | // that we may not care about. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1918 | continue; |
| 1919 | } |
| 1920 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1921 | // Try to add to the output set |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1922 | if (!ids.insert(id).second) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1923 | continue; // If we already saw this id, we don't want to walk it again. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1924 | } |
| 1925 | |
| 1926 | switch (insn.opcode()) { |
| 1927 | case spv::OpFunction: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1928 | // Scan whole body of the function, enlisting anything interesting |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1929 | while (++insn, insn.opcode() != spv::OpFunctionEnd) { |
| 1930 | switch (insn.opcode()) { |
| 1931 | case spv::OpLoad: |
| 1932 | case spv::OpAtomicLoad: |
| 1933 | case spv::OpAtomicExchange: |
| 1934 | case spv::OpAtomicCompareExchange: |
| 1935 | case spv::OpAtomicCompareExchangeWeak: |
| 1936 | case spv::OpAtomicIIncrement: |
| 1937 | case spv::OpAtomicIDecrement: |
| 1938 | case spv::OpAtomicIAdd: |
| 1939 | case spv::OpAtomicISub: |
| 1940 | case spv::OpAtomicSMin: |
| 1941 | case spv::OpAtomicUMin: |
| 1942 | case spv::OpAtomicSMax: |
| 1943 | case spv::OpAtomicUMax: |
| 1944 | case spv::OpAtomicAnd: |
| 1945 | case spv::OpAtomicOr: |
| 1946 | case spv::OpAtomicXor: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1947 | worklist.insert(insn.word(3)); // ptr |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1948 | break; |
| 1949 | case spv::OpStore: |
| 1950 | case spv::OpAtomicStore: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1951 | worklist.insert(insn.word(1)); // ptr |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1952 | break; |
| 1953 | case spv::OpAccessChain: |
| 1954 | case spv::OpInBoundsAccessChain: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1955 | worklist.insert(insn.word(3)); // base ptr |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1956 | break; |
| 1957 | case spv::OpSampledImage: |
| 1958 | case spv::OpImageSampleImplicitLod: |
| 1959 | case spv::OpImageSampleExplicitLod: |
| 1960 | case spv::OpImageSampleDrefImplicitLod: |
| 1961 | case spv::OpImageSampleDrefExplicitLod: |
| 1962 | case spv::OpImageSampleProjImplicitLod: |
| 1963 | case spv::OpImageSampleProjExplicitLod: |
| 1964 | case spv::OpImageSampleProjDrefImplicitLod: |
| 1965 | case spv::OpImageSampleProjDrefExplicitLod: |
| 1966 | case spv::OpImageFetch: |
| 1967 | case spv::OpImageGather: |
| 1968 | case spv::OpImageDrefGather: |
| 1969 | case spv::OpImageRead: |
| 1970 | case spv::OpImage: |
| 1971 | case spv::OpImageQueryFormat: |
| 1972 | case spv::OpImageQueryOrder: |
| 1973 | case spv::OpImageQuerySizeLod: |
| 1974 | case spv::OpImageQuerySize: |
| 1975 | case spv::OpImageQueryLod: |
| 1976 | case spv::OpImageQueryLevels: |
| 1977 | case spv::OpImageQuerySamples: |
| 1978 | case spv::OpImageSparseSampleImplicitLod: |
| 1979 | case spv::OpImageSparseSampleExplicitLod: |
| 1980 | case spv::OpImageSparseSampleDrefImplicitLod: |
| 1981 | case spv::OpImageSparseSampleDrefExplicitLod: |
| 1982 | case spv::OpImageSparseSampleProjImplicitLod: |
| 1983 | case spv::OpImageSparseSampleProjExplicitLod: |
| 1984 | case spv::OpImageSparseSampleProjDrefImplicitLod: |
| 1985 | case spv::OpImageSparseSampleProjDrefExplicitLod: |
| 1986 | case spv::OpImageSparseFetch: |
| 1987 | case spv::OpImageSparseGather: |
| 1988 | case spv::OpImageSparseDrefGather: |
| 1989 | case spv::OpImageTexelPointer: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1990 | worklist.insert(insn.word(3)); // Image or sampled image |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1991 | break; |
| 1992 | case spv::OpImageWrite: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1993 | worklist.insert(insn.word(1)); // Image -- different operand order to above |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1994 | break; |
| 1995 | case spv::OpFunctionCall: |
Michael Mc Donnell | 75ecdb7 | 2016-04-03 14:47:51 -0700 | [diff] [blame] | 1996 | for (uint32_t i = 3; i < insn.len(); i++) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 1997 | worklist.insert(insn.word(i)); // fn itself, and all args |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 1998 | } |
| 1999 | break; |
| 2000 | |
| 2001 | case spv::OpExtInst: |
Michael Mc Donnell | 75ecdb7 | 2016-04-03 14:47:51 -0700 | [diff] [blame] | 2002 | for (uint32_t i = 5; i < insn.len(); i++) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2003 | worklist.insert(insn.word(i)); // Operands to ext inst |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2004 | } |
| 2005 | break; |
| 2006 | } |
| 2007 | } |
| 2008 | break; |
| 2009 | } |
| 2010 | } |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 2011 | |
| 2012 | return ids; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2013 | } |
| 2014 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2015 | static bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2016 | std::vector<VkPushConstantRange> const *push_constant_ranges, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2017 | shader_module const *src, spirv_inst_iter type, |
| 2018 | VkShaderStageFlagBits stage) { |
| 2019 | bool pass = true; |
| 2020 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2021 | // Strip off ptrs etc |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2022 | type = get_struct_type(src, type, false); |
| 2023 | assert(type != src->end()); |
| 2024 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2025 | // Validate directly off the offsets. this isn't quite correct for arrays and matrices, but is a good first step. |
| 2026 | // TODO: arrays, matrices, weird sizes |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2027 | for (auto insn : *src) { |
| 2028 | if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { |
| 2029 | |
| 2030 | if (insn.word(3) == spv::DecorationOffset) { |
| 2031 | unsigned offset = insn.word(4); |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2032 | auto size = 4; // Bytes; TODO: calculate this based on the type |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2033 | |
| 2034 | bool found_range = false; |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2035 | for (auto const &range : *push_constant_ranges) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2036 | if (range.offset <= offset && range.offset + range.size >= offset + size) { |
| 2037 | found_range = true; |
| 2038 | |
| 2039 | if ((range.stageFlags & stage) == 0) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2040 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 2041 | __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2042 | "Push constant range covering variable starting at " |
| 2043 | "offset %u not accessible from stage %s", |
| 2044 | offset, string_VkShaderStageFlagBits(stage))) { |
| 2045 | pass = false; |
| 2046 | } |
| 2047 | } |
| 2048 | |
| 2049 | break; |
| 2050 | } |
| 2051 | } |
| 2052 | |
| 2053 | if (!found_range) { |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2054 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 2055 | __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2056 | "Push constant range covering variable starting at " |
| 2057 | "offset %u not declared in layout", |
| 2058 | offset)) { |
| 2059 | pass = false; |
| 2060 | } |
| 2061 | } |
| 2062 | } |
| 2063 | } |
| 2064 | } |
| 2065 | |
| 2066 | return pass; |
| 2067 | } |
| 2068 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2069 | static bool validate_push_constant_usage(debug_report_data *report_data, |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2070 | std::vector<VkPushConstantRange> const *push_constant_ranges, shader_module const *src, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2071 | std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { |
| 2072 | bool pass = true; |
| 2073 | |
| 2074 | for (auto id : accessible_ids) { |
| 2075 | auto def_insn = src->get_def(id); |
| 2076 | if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2077 | pass &= validate_push_constant_block_against_pipeline(report_data, push_constant_ranges, src, |
| 2078 | src->get_def(def_insn.word(1)), stage); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2079 | } |
| 2080 | } |
| 2081 | |
| 2082 | return pass; |
| 2083 | } |
| 2084 | |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 2085 | // For given pipelineLayout verify that the set_layout_node at slot.first |
| 2086 | // has the requested binding at slot.second and return ptr to that binding |
Chris Forbes | 81d9521 | 2016-05-20 18:27:28 +1200 | [diff] [blame] | 2087 | static VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2088 | |
| 2089 | if (!pipelineLayout) |
Chris Forbes | 4e4191b | 2016-03-18 11:14:27 +1300 | [diff] [blame] | 2090 | return nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2091 | |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2092 | if (slot.first >= pipelineLayout->set_layouts.size()) |
Chris Forbes | 4e4191b | 2016-03-18 11:14:27 +1300 | [diff] [blame] | 2093 | return nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2094 | |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2095 | return pipelineLayout->set_layouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2096 | } |
| 2097 | |
| 2098 | // Block of code at start here for managing/tracking Pipeline state that this layer cares about |
| 2099 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2100 | // TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound |
| 2101 | // Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates |
| 2102 | // to that same cmd buffer by separate thread are not changing state from underneath us |
| 2103 | // Track the last cmd buffer touched by this thread |
| 2104 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2105 | static bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2106 | for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { |
| 2107 | if (pCB->drawCount[i]) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2108 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2109 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2110 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2111 | } |
| 2112 | |
| 2113 | // Check object status for selected flag state |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2114 | static bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2115 | const char *fail_msg, UNIQUE_VALIDATION_ERROR_CODE const msg_code) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2116 | if (!(pNode->status & status_mask)) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2117 | char const *const message = validation_error_map[msg_code]; |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2118 | return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2119 | reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, msg_code, "DS", |
| 2120 | "command buffer object 0x%p: %s. %s.", pNode->commandBuffer, fail_msg, message); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2121 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2122 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2123 | } |
| 2124 | |
| 2125 | // Retrieve pipeline node ptr for given pipeline object |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2126 | static PIPELINE_STATE *getPipelineState(layer_data const *my_data, VkPipeline pipeline) { |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2127 | auto it = my_data->pipelineMap.find(pipeline); |
| 2128 | if (it == my_data->pipelineMap.end()) { |
| 2129 | return nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2130 | } |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2131 | return it->second; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2132 | } |
| 2133 | |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 2134 | static RENDER_PASS_STATE *getRenderPassState(layer_data const *my_data, VkRenderPass renderpass) { |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 2135 | auto it = my_data->renderPassMap.find(renderpass); |
| 2136 | if (it == my_data->renderPassMap.end()) { |
| 2137 | return nullptr; |
| 2138 | } |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 2139 | return it->second.get(); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 2140 | } |
| 2141 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 2142 | static FRAMEBUFFER_STATE *getFramebufferState(const layer_data *my_data, VkFramebuffer framebuffer) { |
Chris Forbes | 05e03b7 | 2016-05-17 15:27:58 +1200 | [diff] [blame] | 2143 | auto it = my_data->frameBufferMap.find(framebuffer); |
| 2144 | if (it == my_data->frameBufferMap.end()) { |
| 2145 | return nullptr; |
| 2146 | } |
Tobin Ehlis | 82d2db3 | 2016-06-22 08:29:24 -0600 | [diff] [blame] | 2147 | return it->second.get(); |
Chris Forbes | 05e03b7 | 2016-05-17 15:27:58 +1200 | [diff] [blame] | 2148 | } |
| 2149 | |
Tobin Ehlis | 815e813 | 2016-06-02 13:02:17 -0600 | [diff] [blame] | 2150 | cvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { |
Chris Forbes | 056d992 | 2016-05-20 17:04:07 +1200 | [diff] [blame] | 2151 | auto it = my_data->descriptorSetLayoutMap.find(dsLayout); |
| 2152 | if (it == my_data->descriptorSetLayoutMap.end()) { |
| 2153 | return nullptr; |
| 2154 | } |
| 2155 | return it->second; |
| 2156 | } |
| 2157 | |
Tobin Ehlis | c1d9be1 | 2016-10-13 10:18:18 -0600 | [diff] [blame] | 2158 | static PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { |
Chris Forbes | 81d9521 | 2016-05-20 18:27:28 +1200 | [diff] [blame] | 2159 | auto it = my_data->pipelineLayoutMap.find(pipeLayout); |
| 2160 | if (it == my_data->pipelineLayoutMap.end()) { |
| 2161 | return nullptr; |
| 2162 | } |
| 2163 | return &it->second; |
| 2164 | } |
| 2165 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2166 | // Return true if for a given PSO, the given state enum is dynamic, else return false |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2167 | static bool isDynamic(const PIPELINE_STATE *pPipeline, const VkDynamicState state) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2168 | if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { |
| 2169 | for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { |
| 2170 | if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2171 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2172 | } |
| 2173 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2174 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2175 | } |
| 2176 | |
| 2177 | // Validate state stored as flags at time of draw call |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2178 | static bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_STATE *pPipe, bool indexed, |
| 2179 | UNIQUE_VALIDATION_ERROR_CODE const msg_code) { |
Chris Forbes | b2ba95b | 2016-09-16 17:11:50 +1200 | [diff] [blame] | 2180 | bool result = false; |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 2181 | if (pPipe->graphicsPipelineCI.pInputAssemblyState && |
| 2182 | ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || |
| 2183 | (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2184 | result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2185 | "Dynamic line width state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2186 | } |
Dustin Graves | bd9c1a9 | 2016-04-05 15:15:40 -0600 | [diff] [blame] | 2187 | if (pPipe->graphicsPipelineCI.pRasterizationState && |
| 2188 | (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2189 | result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2190 | "Dynamic depth bias state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2191 | } |
| 2192 | if (pPipe->blendConstantsEnabled) { |
| 2193 | result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2194 | "Dynamic blend constants state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2195 | } |
Dustin Graves | bd9c1a9 | 2016-04-05 15:15:40 -0600 | [diff] [blame] | 2196 | if (pPipe->graphicsPipelineCI.pDepthStencilState && |
| 2197 | (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2198 | result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2199 | "Dynamic depth bounds state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2200 | } |
Dustin Graves | bd9c1a9 | 2016-04-05 15:15:40 -0600 | [diff] [blame] | 2201 | if (pPipe->graphicsPipelineCI.pDepthStencilState && |
| 2202 | (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2203 | result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2204 | "Dynamic stencil read mask state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2205 | result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2206 | "Dynamic stencil write mask state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2207 | result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2208 | "Dynamic stencil reference state not set for this command buffer", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2209 | } |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 2210 | if (indexed) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2211 | result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2212 | "Index buffer object not bound to this command buffer when Indexed Draw attempted", msg_code); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 2213 | } |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2214 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2215 | return result; |
| 2216 | } |
| 2217 | |
| 2218 | // Verify attachment reference compatibility according to spec |
| 2219 | // If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this |
Mark Lobodzinski | 4c94c28 | 2016-06-20 18:49:25 -0600 | [diff] [blame] | 2220 | // If both AttachmentReference arrays have requested index, check their corresponding AttachmentDescriptions |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2221 | // to make sure that format and samples counts match. |
| 2222 | // If not, they are not compatible. |
| 2223 | static bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, |
| 2224 | const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, |
| 2225 | const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, |
| 2226 | const VkAttachmentDescription *pSecondaryAttachments) { |
Tobin Ehlis | c231aae | 2016-06-10 02:36:25 -0600 | [diff] [blame] | 2227 | // Check potential NULL cases first to avoid nullptr issues later |
| 2228 | if (pPrimary == nullptr) { |
| 2229 | if (pSecondary == nullptr) { |
| 2230 | return true; |
| 2231 | } |
| 2232 | return false; |
| 2233 | } else if (pSecondary == nullptr) { |
| 2234 | return false; |
| 2235 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2236 | if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED |
Mark Young | eeafb15 | 2016-03-24 10:14:35 -0600 | [diff] [blame] | 2237 | if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) |
| 2238 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2239 | } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED |
Mark Young | eeafb15 | 2016-03-24 10:14:35 -0600 | [diff] [blame] | 2240 | if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) |
| 2241 | return true; |
Mark Lobodzinski | 4c94c28 | 2016-06-20 18:49:25 -0600 | [diff] [blame] | 2242 | } else { // Format and sample count must match |
| 2243 | if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) && (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { |
| 2244 | return true; |
| 2245 | } else if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) || (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { |
| 2246 | return false; |
| 2247 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2248 | if ((pPrimaryAttachments[pPrimary[index].attachment].format == |
| 2249 | pSecondaryAttachments[pSecondary[index].attachment].format) && |
| 2250 | (pPrimaryAttachments[pPrimary[index].attachment].samples == |
| 2251 | pSecondaryAttachments[pSecondary[index].attachment].samples)) |
| 2252 | return true; |
| 2253 | } |
| 2254 | // Format and sample counts didn't match |
| 2255 | return false; |
| 2256 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 2257 | // TODO : Scrub verify_renderpass_compatibility() and validateRenderPassCompatibility() and unify them and/or share code |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 2258 | // For given primary RenderPass object and secondry RenderPassCreateInfo, verify that they're compatible |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 2259 | static bool verify_renderpass_compatibility(const layer_data *my_data, const VkRenderPassCreateInfo *primaryRPCI, |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 2260 | const VkRenderPassCreateInfo *secondaryRPCI, string &errorMsg) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2261 | if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2262 | stringstream errorStr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2263 | errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount |
| 2264 | << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; |
| 2265 | errorMsg = errorStr.str(); |
| 2266 | return false; |
| 2267 | } |
| 2268 | uint32_t spIndex = 0; |
| 2269 | for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { |
| 2270 | // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible |
| 2271 | uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; |
| 2272 | uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; |
| 2273 | uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); |
| 2274 | for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { |
| 2275 | if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, |
| 2276 | primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, |
| 2277 | secondaryColorCount, secondaryRPCI->pAttachments)) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2278 | stringstream errorStr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2279 | errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; |
| 2280 | errorMsg = errorStr.str(); |
| 2281 | return false; |
| 2282 | } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, |
| 2283 | primaryColorCount, primaryRPCI->pAttachments, |
| 2284 | secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, |
| 2285 | secondaryColorCount, secondaryRPCI->pAttachments)) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2286 | stringstream errorStr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2287 | errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; |
| 2288 | errorMsg = errorStr.str(); |
| 2289 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2290 | } |
| 2291 | } |
Chris Forbes | b442e56 | 2016-04-11 18:32:23 +1200 | [diff] [blame] | 2292 | |
| 2293 | if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, |
| 2294 | 1, primaryRPCI->pAttachments, |
| 2295 | secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, |
| 2296 | 1, secondaryRPCI->pAttachments)) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2297 | stringstream errorStr; |
Chris Forbes | b442e56 | 2016-04-11 18:32:23 +1200 | [diff] [blame] | 2298 | errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; |
| 2299 | errorMsg = errorStr.str(); |
| 2300 | return false; |
| 2301 | } |
| 2302 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2303 | uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; |
| 2304 | uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; |
| 2305 | uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); |
| 2306 | for (uint32_t i = 0; i < inputMax; ++i) { |
| 2307 | if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, |
| 2308 | primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, |
| 2309 | secondaryColorCount, secondaryRPCI->pAttachments)) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2310 | stringstream errorStr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2311 | errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; |
| 2312 | errorMsg = errorStr.str(); |
| 2313 | return false; |
| 2314 | } |
| 2315 | } |
| 2316 | } |
| 2317 | return true; |
| 2318 | } |
| 2319 | |
Tobin Ehlis | 05be5df | 2016-05-05 08:25:02 -0600 | [diff] [blame] | 2320 | // For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to |
| 2321 | // pipelineLayout[layoutIndex] |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 2322 | static bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *descriptor_set, |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 2323 | PIPELINE_LAYOUT_NODE const *pipeline_layout, const uint32_t layoutIndex, |
| 2324 | string &errorMsg) { |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2325 | auto num_sets = pipeline_layout->set_layouts.size(); |
Tobin Ehlis | a382a95 | 2016-07-07 09:20:13 -0600 | [diff] [blame] | 2326 | if (layoutIndex >= num_sets) { |
Chris Forbes | ba2c466 | 2016-04-14 10:30:01 +1200 | [diff] [blame] | 2327 | stringstream errorStr; |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 2328 | errorStr << "VkPipelineLayout (" << pipeline_layout->layout << ") only contains " << num_sets |
| 2329 | << " setLayouts corresponding to sets 0-" << num_sets - 1 << ", but you're attempting to bind set to index " |
| 2330 | << layoutIndex; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2331 | errorMsg = errorStr.str(); |
| 2332 | return false; |
| 2333 | } |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2334 | auto layout_node = pipeline_layout->set_layouts[layoutIndex]; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 2335 | return descriptor_set->IsCompatible(layout_node, &errorMsg); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2336 | } |
| 2337 | |
| 2338 | // Validate that data for each specialization entry is fully contained within the buffer. |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2339 | static bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2340 | bool pass = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2341 | |
| 2342 | VkSpecializationInfo const *spec = info->pSpecializationInfo; |
| 2343 | |
| 2344 | if (spec) { |
| 2345 | for (auto i = 0u; i < spec->mapEntryCount; i++) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2346 | // TODO: This is a good place for VALIDATION_ERROR_00589. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2347 | if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2348 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 0, __LINE__, |
| 2349 | VALIDATION_ERROR_00590, "SC", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2350 | "Specialization entry %u (for constant id %u) references memory outside provided " |
| 2351 | "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2352 | " bytes provided). %s.", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2353 | i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2354 | spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize, |
| 2355 | validation_error_map[VALIDATION_ERROR_00590])) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2356 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2357 | pass = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2358 | } |
| 2359 | } |
| 2360 | } |
| 2361 | } |
| 2362 | |
| 2363 | return pass; |
| 2364 | } |
| 2365 | |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2366 | static bool descriptor_type_match(shader_module const *module, uint32_t type_id, |
Chris Forbes | b9fb5fc | 2016-03-18 11:21:35 +1300 | [diff] [blame] | 2367 | VkDescriptorType descriptor_type, unsigned &descriptor_count) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2368 | auto type = module->get_def(type_id); |
| 2369 | |
Chris Forbes | b9fb5fc | 2016-03-18 11:21:35 +1300 | [diff] [blame] | 2370 | descriptor_count = 1; |
| 2371 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2372 | // Strip off any array or ptrs. Where we remove array levels, adjust the descriptor count for each dimension. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2373 | while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { |
Chris Forbes | a136109 | 2016-03-18 11:26:06 +1300 | [diff] [blame] | 2374 | if (type.opcode() == spv::OpTypeArray) { |
| 2375 | descriptor_count *= get_constant_value(module, type.word(3)); |
| 2376 | type = module->get_def(type.word(2)); |
| 2377 | } |
| 2378 | else { |
| 2379 | type = module->get_def(type.word(3)); |
| 2380 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2381 | } |
| 2382 | |
| 2383 | switch (type.opcode()) { |
| 2384 | case spv::OpTypeStruct: { |
| 2385 | for (auto insn : *module) { |
| 2386 | if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { |
| 2387 | if (insn.word(2) == spv::DecorationBlock) { |
| 2388 | return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || |
| 2389 | descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; |
| 2390 | } else if (insn.word(2) == spv::DecorationBufferBlock) { |
| 2391 | return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || |
| 2392 | descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; |
| 2393 | } |
| 2394 | } |
| 2395 | } |
| 2396 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2397 | // Invalid |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2398 | return false; |
| 2399 | } |
| 2400 | |
| 2401 | case spv::OpTypeSampler: |
Chris Forbes | b9e3a08 | 2016-07-19 14:50:04 +1200 | [diff] [blame] | 2402 | return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER || |
| 2403 | descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2404 | |
| 2405 | case spv::OpTypeSampledImage: |
Chris Forbes | ccf300b | 2016-03-24 14:14:45 +1300 | [diff] [blame] | 2406 | if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2407 | // Slight relaxation for some GLSL historical madness: samplerBuffer doesn't really have a sampler, and a texel |
| 2408 | // buffer descriptor doesn't really provide one. Allow this slight mismatch. |
Chris Forbes | ccf300b | 2016-03-24 14:14:45 +1300 | [diff] [blame] | 2409 | auto image_type = module->get_def(type.word(2)); |
| 2410 | auto dim = image_type.word(3); |
| 2411 | auto sampled = image_type.word(7); |
| 2412 | return dim == spv::DimBuffer && sampled == 1; |
| 2413 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2414 | return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; |
| 2415 | |
| 2416 | case spv::OpTypeImage: { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2417 | // Many descriptor types backing image types-- depends on dimension and whether the image will be used with a sampler. |
| 2418 | // SPIRV for Vulkan requires that sampled be 1 or 2 -- leaving the decision to runtime is unacceptable. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2419 | auto dim = type.word(3); |
| 2420 | auto sampled = type.word(7); |
| 2421 | |
| 2422 | if (dim == spv::DimSubpassData) { |
| 2423 | return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; |
| 2424 | } else if (dim == spv::DimBuffer) { |
| 2425 | if (sampled == 1) { |
| 2426 | return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; |
| 2427 | } else { |
| 2428 | return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; |
| 2429 | } |
| 2430 | } else if (sampled == 1) { |
Chris Forbes | b9e3a08 | 2016-07-19 14:50:04 +1200 | [diff] [blame] | 2431 | return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE || |
| 2432 | descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2433 | } else { |
| 2434 | return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; |
| 2435 | } |
| 2436 | } |
| 2437 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2438 | // We shouldn't really see any other junk types -- but if we do, they're a mismatch. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2439 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2440 | return false; // Mismatch |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2441 | } |
| 2442 | } |
| 2443 | |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2444 | static bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2445 | if (!feature) { |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2446 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 2447 | __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2448 | "Shader requires VkPhysicalDeviceFeatures::%s but is not " |
| 2449 | "enabled on the device", |
| 2450 | feature_name)) { |
| 2451 | return false; |
| 2452 | } |
| 2453 | } |
| 2454 | |
| 2455 | return true; |
| 2456 | } |
| 2457 | |
Chris Forbes | c9b826c | 2016-05-13 13:17:42 +1200 | [diff] [blame] | 2458 | static bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, |
| 2459 | VkPhysicalDeviceFeatures const *enabledFeatures) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2460 | bool pass = true; |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2461 | |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2462 | |
| 2463 | for (auto insn : *src) { |
| 2464 | if (insn.opcode() == spv::OpCapability) { |
| 2465 | switch (insn.word(1)) { |
| 2466 | case spv::CapabilityMatrix: |
| 2467 | case spv::CapabilityShader: |
| 2468 | case spv::CapabilityInputAttachment: |
| 2469 | case spv::CapabilitySampled1D: |
| 2470 | case spv::CapabilityImage1D: |
| 2471 | case spv::CapabilitySampledBuffer: |
| 2472 | case spv::CapabilityImageBuffer: |
| 2473 | case spv::CapabilityImageQuery: |
| 2474 | case spv::CapabilityDerivativeControl: |
| 2475 | // Always supported by a Vulkan 1.0 implementation -- no feature bits. |
| 2476 | break; |
| 2477 | |
| 2478 | case spv::CapabilityGeometry: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2479 | pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2480 | break; |
| 2481 | |
| 2482 | case spv::CapabilityTessellation: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2483 | pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2484 | break; |
| 2485 | |
| 2486 | case spv::CapabilityFloat64: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2487 | pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2488 | break; |
| 2489 | |
| 2490 | case spv::CapabilityInt64: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2491 | pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2492 | break; |
| 2493 | |
| 2494 | case spv::CapabilityTessellationPointSize: |
| 2495 | case spv::CapabilityGeometryPointSize: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2496 | pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2497 | "shaderTessellationAndGeometryPointSize"); |
| 2498 | break; |
| 2499 | |
| 2500 | case spv::CapabilityImageGatherExtended: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2501 | pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2502 | break; |
| 2503 | |
| 2504 | case spv::CapabilityStorageImageMultisample: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2505 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2506 | break; |
| 2507 | |
| 2508 | case spv::CapabilityUniformBufferArrayDynamicIndexing: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2509 | pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2510 | "shaderUniformBufferArrayDynamicIndexing"); |
| 2511 | break; |
| 2512 | |
| 2513 | case spv::CapabilitySampledImageArrayDynamicIndexing: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2514 | pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2515 | "shaderSampledImageArrayDynamicIndexing"); |
| 2516 | break; |
| 2517 | |
| 2518 | case spv::CapabilityStorageBufferArrayDynamicIndexing: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2519 | pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2520 | "shaderStorageBufferArrayDynamicIndexing"); |
| 2521 | break; |
| 2522 | |
| 2523 | case spv::CapabilityStorageImageArrayDynamicIndexing: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2524 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2525 | "shaderStorageImageArrayDynamicIndexing"); |
| 2526 | break; |
| 2527 | |
| 2528 | case spv::CapabilityClipDistance: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2529 | pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2530 | break; |
| 2531 | |
| 2532 | case spv::CapabilityCullDistance: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2533 | pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2534 | break; |
| 2535 | |
| 2536 | case spv::CapabilityImageCubeArray: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2537 | pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2538 | break; |
| 2539 | |
| 2540 | case spv::CapabilitySampleRateShading: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2541 | pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2542 | break; |
| 2543 | |
| 2544 | case spv::CapabilitySparseResidency: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2545 | pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2546 | break; |
| 2547 | |
| 2548 | case spv::CapabilityMinLod: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2549 | pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2550 | break; |
| 2551 | |
| 2552 | case spv::CapabilitySampledCubeArray: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2553 | pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2554 | break; |
| 2555 | |
| 2556 | case spv::CapabilityImageMSArray: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2557 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2558 | break; |
| 2559 | |
| 2560 | case spv::CapabilityStorageImageExtendedFormats: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2561 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2562 | "shaderStorageImageExtendedFormats"); |
| 2563 | break; |
| 2564 | |
| 2565 | case spv::CapabilityInterpolationFunction: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2566 | pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2567 | break; |
| 2568 | |
| 2569 | case spv::CapabilityStorageImageReadWithoutFormat: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2570 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2571 | "shaderStorageImageReadWithoutFormat"); |
| 2572 | break; |
| 2573 | |
| 2574 | case spv::CapabilityStorageImageWriteWithoutFormat: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2575 | pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2576 | "shaderStorageImageWriteWithoutFormat"); |
| 2577 | break; |
| 2578 | |
| 2579 | case spv::CapabilityMultiViewport: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2580 | pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2581 | break; |
| 2582 | |
| 2583 | default: |
Chris Forbes | 34bbe94 | 2016-05-10 16:47:02 +1200 | [diff] [blame] | 2584 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2585 | __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", |
| 2586 | "Shader declares capability %u, not supported in Vulkan.", |
| 2587 | insn.word(1))) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2588 | pass = false; |
Chris Forbes | c3a1dbc | 2016-03-15 10:12:48 +1300 | [diff] [blame] | 2589 | break; |
| 2590 | } |
| 2591 | } |
| 2592 | } |
| 2593 | |
| 2594 | return pass; |
| 2595 | } |
| 2596 | |
Chris Forbes | c7090a8 | 2016-07-25 18:10:41 +1200 | [diff] [blame] | 2597 | |
| 2598 | static uint32_t descriptor_type_to_reqs(shader_module const *module, uint32_t type_id) { |
Chris Forbes | 0b38947 | 2016-07-25 18:12:05 +1200 | [diff] [blame] | 2599 | auto type = module->get_def(type_id); |
| 2600 | |
| 2601 | while (true) { |
| 2602 | switch (type.opcode()) { |
| 2603 | case spv::OpTypeArray: |
| 2604 | case spv::OpTypeSampledImage: |
| 2605 | type = module->get_def(type.word(2)); |
| 2606 | break; |
| 2607 | case spv::OpTypePointer: |
| 2608 | type = module->get_def(type.word(3)); |
| 2609 | break; |
| 2610 | case spv::OpTypeImage: { |
| 2611 | auto dim = type.word(3); |
| 2612 | auto arrayed = type.word(5); |
| 2613 | auto msaa = type.word(6); |
| 2614 | |
| 2615 | switch (dim) { |
| 2616 | case spv::Dim1D: |
Chris Forbes | 0d250c2 | 2016-08-02 08:08:16 +1200 | [diff] [blame] | 2617 | return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_1D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_1D; |
Chris Forbes | 0b38947 | 2016-07-25 18:12:05 +1200 | [diff] [blame] | 2618 | case spv::Dim2D: |
| 2619 | return (msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE) | |
Chris Forbes | 0d250c2 | 2016-08-02 08:08:16 +1200 | [diff] [blame] | 2620 | (arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_2D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_2D); |
Chris Forbes | 0b38947 | 2016-07-25 18:12:05 +1200 | [diff] [blame] | 2621 | case spv::Dim3D: |
| 2622 | return DESCRIPTOR_REQ_VIEW_TYPE_3D; |
| 2623 | case spv::DimCube: |
Chris Forbes | 0d250c2 | 2016-08-02 08:08:16 +1200 | [diff] [blame] | 2624 | return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_CUBE_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_CUBE; |
Chris Forbes | 48a1b2e | 2016-08-31 11:59:48 -0700 | [diff] [blame] | 2625 | case spv::DimSubpassData: |
| 2626 | return msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE; |
| 2627 | default: // buffer, etc. |
Chris Forbes | 0b38947 | 2016-07-25 18:12:05 +1200 | [diff] [blame] | 2628 | return 0; |
| 2629 | } |
| 2630 | } |
| 2631 | default: |
| 2632 | return 0; |
| 2633 | } |
| 2634 | } |
Chris Forbes | c7090a8 | 2016-07-25 18:10:41 +1200 | [diff] [blame] | 2635 | } |
| 2636 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2637 | static bool |
| 2638 | validate_pipeline_shader_stage(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *pStage, |
| 2639 | PIPELINE_STATE *pipeline, shader_module **out_module, spirv_inst_iter *out_entrypoint, |
| 2640 | VkPhysicalDeviceFeatures const *enabledFeatures, |
| 2641 | std::unordered_map<VkShaderModule, std::unique_ptr<shader_module>> const &shaderModuleMap) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2642 | bool pass = true; |
Chris Forbes | c9b826c | 2016-05-13 13:17:42 +1200 | [diff] [blame] | 2643 | auto module_it = shaderModuleMap.find(pStage->module); |
| 2644 | auto module = *out_module = module_it->second.get(); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2645 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2646 | // Find the entrypoint |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2647 | auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); |
| 2648 | if (entrypoint == module->end()) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 2649 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, VALIDATION_ERROR_00510, |
| 2650 | "SC", "No entrypoint found named `%s` for stage %s. %s.", pStage->pName, |
| 2651 | string_VkShaderStageFlagBits(pStage->stage), validation_error_map[VALIDATION_ERROR_00510])) { |
Chris Forbes | 1a89b3f | 2016-09-09 11:23:39 +1200 | [diff] [blame] | 2652 | return false; // no point continuing beyond here, any analysis is just going to be garbage. |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2653 | } |
| 2654 | } |
| 2655 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2656 | // Validate shader capabilities against enabled device features |
Chris Forbes | 19b6058 | 2016-05-13 13:27:58 +1200 | [diff] [blame] | 2657 | pass &= validate_shader_capabilities(report_data, module, enabledFeatures); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2658 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2659 | // Mark accessible ids |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 2660 | auto accessible_ids = mark_accessible_ids(module, entrypoint); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2661 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2662 | // Validate descriptor set layout against what the entrypoint actually uses |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 2663 | auto descriptor_uses = collect_interface_by_descriptor_slot(report_data, module, accessible_ids); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2664 | |
Tobin Ehlis | 97f401a | 2016-07-07 08:12:03 -0600 | [diff] [blame] | 2665 | auto pipelineLayout = pipeline->pipeline_layout; |
Chris Forbes | 337dbbb | 2016-05-13 13:39:17 +1200 | [diff] [blame] | 2666 | |
Chris Forbes | 1a89b3f | 2016-09-09 11:23:39 +1200 | [diff] [blame] | 2667 | pass &= validate_specialization_offsets(report_data, pStage); |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 2668 | pass &= validate_push_constant_usage(report_data, &pipelineLayout.push_constant_ranges, module, accessible_ids, pStage->stage); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2669 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2670 | // Validate descriptor use |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2671 | for (auto use : descriptor_uses) { |
| 2672 | // While validating shaders capture which slots are used by the pipeline |
Chris Forbes | c7090a8 | 2016-07-25 18:10:41 +1200 | [diff] [blame] | 2673 | auto & reqs = pipeline->active_slots[use.first.first][use.first.second]; |
| 2674 | reqs = descriptor_req(reqs | descriptor_type_to_reqs(module, use.second.type_id)); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2675 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2676 | // Verify given pipelineLayout has requested setLayout with requested binding |
Tobin Ehlis | b73587d | 2016-07-07 08:14:48 -0600 | [diff] [blame] | 2677 | const auto &binding = get_descriptor_binding(&pipelineLayout, use.first); |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2678 | unsigned required_descriptor_count; |
| 2679 | |
| 2680 | if (!binding) { |
Chris Forbes | 19b6058 | 2016-05-13 13:27:58 +1200 | [diff] [blame] | 2681 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Chris Forbes | ce5be90 | 2016-03-30 13:14:22 +1300 | [diff] [blame] | 2682 | __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2683 | "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", |
| 2684 | use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2685 | pass = false; |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2686 | } |
| 2687 | } else if (~binding->stageFlags & pStage->stage) { |
Chris Forbes | 19b6058 | 2016-05-13 13:27:58 +1200 | [diff] [blame] | 2688 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2689 | 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2690 | "Shader uses descriptor slot %u.%u (used " |
| 2691 | "as type `%s`) but descriptor not " |
| 2692 | "accessible from stage %s", |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 2693 | use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2694 | string_VkShaderStageFlagBits(pStage->stage))) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2695 | pass = false; |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2696 | } |
Chris Forbes | 1832a77 | 2016-05-10 15:30:22 +1200 | [diff] [blame] | 2697 | } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2698 | required_descriptor_count)) { |
Chris Forbes | 19b6058 | 2016-05-13 13:27:58 +1200 | [diff] [blame] | 2699 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 2700 | SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " |
| 2701 | "%u.%u (used as type `%s`) but " |
| 2702 | "descriptor of type %s", |
| 2703 | use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2704 | string_VkDescriptorType(binding->descriptorType))) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2705 | pass = false; |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2706 | } |
| 2707 | } else if (binding->descriptorCount < required_descriptor_count) { |
Chris Forbes | 19b6058 | 2016-05-13 13:27:58 +1200 | [diff] [blame] | 2708 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 2709 | SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2710 | "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", |
| 2711 | required_descriptor_count, use.first.first, use.first.second, |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 2712 | describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2713 | pass = false; |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2714 | } |
| 2715 | } |
| 2716 | } |
| 2717 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 2718 | // Validate use of input attachments against subpass structure |
Chris Forbes | 8420fea | 2016-08-22 15:20:11 +1200 | [diff] [blame] | 2719 | if (pStage->stage == VK_SHADER_STAGE_FRAGMENT_BIT) { |
Chris Forbes | d68e320 | 2016-08-23 13:04:34 +1200 | [diff] [blame] | 2720 | auto input_attachment_uses = collect_interface_by_input_attachment_index(report_data, module, accessible_ids); |
Chris Forbes | 8420fea | 2016-08-22 15:20:11 +1200 | [diff] [blame] | 2721 | |
| 2722 | auto rpci = pipeline->render_pass_ci.ptr(); |
| 2723 | auto subpass = pipeline->graphicsPipelineCI.subpass; |
| 2724 | |
| 2725 | for (auto use : input_attachment_uses) { |
| 2726 | auto input_attachments = rpci->pSubpasses[subpass].pInputAttachments; |
| 2727 | auto index = (input_attachments && use.first < rpci->pSubpasses[subpass].inputAttachmentCount) ? |
| 2728 | input_attachments[use.first].attachment : VK_ATTACHMENT_UNUSED; |
| 2729 | |
| 2730 | if (index == VK_ATTACHMENT_UNUSED) { |
| 2731 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 2732 | SHADER_CHECKER_MISSING_INPUT_ATTACHMENT, "SC", |
| 2733 | "Shader consumes input attachment index %d but not provided in subpass", |
| 2734 | use.first)) { |
| 2735 | pass = false; |
| 2736 | } |
| 2737 | } |
Chris Forbes | 74e7bf5 | 2016-08-22 16:11:22 +1200 | [diff] [blame] | 2738 | else if (get_format_type(rpci->pAttachments[index].format) != |
| 2739 | get_fundamental_type(module, use.second.type_id)) { |
| 2740 | if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 2741 | SHADER_CHECKER_INPUT_ATTACHMENT_TYPE_MISMATCH, "SC", |
| 2742 | "Subpass input attachment %u format of %s does not match type used in shader `%s`", |
| 2743 | use.first, string_VkFormat(rpci->pAttachments[index].format), |
| 2744 | describe_type(module, use.second.type_id).c_str())) { |
| 2745 | pass = false; |
| 2746 | } |
| 2747 | } |
Chris Forbes | 8420fea | 2016-08-22 15:20:11 +1200 | [diff] [blame] | 2748 | } |
| 2749 | } |
| 2750 | |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2751 | return pass; |
| 2752 | } |
| 2753 | |
| 2754 | |
Tobin Ehlis | 81e8ca4 | 2016-03-24 09:17:25 -0600 | [diff] [blame] | 2755 | // Validate that the shaders used by the given pipeline and store the active_slots |
| 2756 | // that are actually used by the pipeline into pPipeline->active_slots |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2757 | static bool |
| 2758 | validate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_STATE *pPipeline, |
| 2759 | VkPhysicalDeviceFeatures const *enabledFeatures, |
| 2760 | std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const &shaderModuleMap) { |
Chris Forbes | 6f6844a | 2016-04-27 14:00:44 +1200 | [diff] [blame] | 2761 | auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2762 | int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); |
| 2763 | int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); |
| 2764 | |
| 2765 | shader_module *shaders[5]; |
| 2766 | memset(shaders, 0, sizeof(shaders)); |
| 2767 | spirv_inst_iter entrypoints[5]; |
| 2768 | memset(entrypoints, 0, sizeof(entrypoints)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2769 | VkPipelineVertexInputStateCreateInfo const *vi = 0; |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 2770 | bool pass = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2771 | |
| 2772 | for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { |
Chris Forbes | 6f6844a | 2016-04-27 14:00:44 +1200 | [diff] [blame] | 2773 | auto pStage = &pCreateInfo->pStages[i]; |
Chris Forbes | 961cee7 | 2016-03-30 12:12:01 +1300 | [diff] [blame] | 2774 | auto stage_id = get_shader_stage_id(pStage->stage); |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2775 | pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, |
Chris Forbes | c9b826c | 2016-05-13 13:17:42 +1200 | [diff] [blame] | 2776 | &shaders[stage_id], &entrypoints[stage_id], |
| 2777 | enabledFeatures, shaderModuleMap); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2778 | } |
| 2779 | |
Chris Forbes | e721009 | 2016-09-13 11:22:22 +1200 | [diff] [blame] | 2780 | // if the shader stages are no good individually, cross-stage validation is pointless. |
Chris Forbes | ddb7d71 | 2016-09-09 11:26:20 +1200 | [diff] [blame] | 2781 | if (!pass) |
| 2782 | return false; |
| 2783 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2784 | vi = pCreateInfo->pVertexInputState; |
| 2785 | |
| 2786 | if (vi) { |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2787 | pass &= validate_vi_consistency(report_data, vi); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2788 | } |
| 2789 | |
| 2790 | if (shaders[vertex_stage]) { |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2791 | pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2792 | } |
| 2793 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2794 | int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); |
| 2795 | int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); |
| 2796 | |
| 2797 | while (!shaders[producer] && producer != fragment_stage) { |
| 2798 | producer++; |
| 2799 | consumer++; |
| 2800 | } |
| 2801 | |
| 2802 | for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { |
| 2803 | assert(shaders[producer]); |
| 2804 | if (shaders[consumer]) { |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2805 | pass &= validate_interface_between_stages(report_data, |
Chris Forbes | 23a575d | 2016-03-29 16:41:07 +1300 | [diff] [blame] | 2806 | shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], |
| 2807 | shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2808 | |
| 2809 | producer = consumer; |
| 2810 | } |
| 2811 | } |
| 2812 | |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 2813 | if (shaders[fragment_stage]) { |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2814 | pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], |
Tobin Ehlis | c677a09 | 2016-06-27 12:57:05 -0600 | [diff] [blame] | 2815 | pPipeline->render_pass_ci.ptr(), pCreateInfo->subpass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2816 | } |
| 2817 | |
| 2818 | return pass; |
| 2819 | } |
| 2820 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2821 | static bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_STATE *pPipeline, |
| 2822 | VkPhysicalDeviceFeatures const *enabledFeatures, |
| 2823 | std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const &shaderModuleMap) { |
Chris Forbes | 6f6844a | 2016-04-27 14:00:44 +1200 | [diff] [blame] | 2824 | auto pCreateInfo = pPipeline->computePipelineCI.ptr(); |
Chris Forbes | b029e6f | 2016-03-30 14:04:36 +1300 | [diff] [blame] | 2825 | |
Chris Forbes | b029e6f | 2016-03-30 14:04:36 +1300 | [diff] [blame] | 2826 | shader_module *module; |
| 2827 | spirv_inst_iter entrypoint; |
| 2828 | |
Chris Forbes | 399c734 | 2016-05-13 13:42:12 +1200 | [diff] [blame] | 2829 | return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, |
Chris Forbes | c9b826c | 2016-05-13 13:17:42 +1200 | [diff] [blame] | 2830 | &module, &entrypoint, enabledFeatures, shaderModuleMap); |
Chris Forbes | b029e6f | 2016-03-30 14:04:36 +1300 | [diff] [blame] | 2831 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2832 | // Return Set node ptr for specified set or else NULL |
Tobin Ehlis | e83a46a | 2016-06-02 12:48:25 -0600 | [diff] [blame] | 2833 | cvdescriptorset::DescriptorSet *getSetNode(const layer_data *my_data, VkDescriptorSet set) { |
Tobin Ehlis | 6a72dc7 | 2016-06-01 16:41:17 -0600 | [diff] [blame] | 2834 | auto set_it = my_data->setMap.find(set); |
| 2835 | if (set_it == my_data->setMap.end()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2836 | return NULL; |
| 2837 | } |
Tobin Ehlis | 6a72dc7 | 2016-06-01 16:41:17 -0600 | [diff] [blame] | 2838 | return set_it->second; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2839 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 2840 | |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2841 | // For given pipeline, return number of MSAA samples, or one if MSAA disabled |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2842 | static VkSampleCountFlagBits getNumSamples(PIPELINE_STATE const *pipe) { |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2843 | if (pipe->graphicsPipelineCI.pMultisampleState != NULL && |
| 2844 | VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2845 | return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; |
| 2846 | } |
| 2847 | return VK_SAMPLE_COUNT_1_BIT; |
| 2848 | } |
| 2849 | |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2850 | static void list_bits(std::ostream& s, uint32_t bits) { |
| 2851 | for (int i = 0; i < 32 && bits; i++) { |
| 2852 | if (bits & (1 << i)) { |
| 2853 | s << i; |
| 2854 | bits &= ~(1 << i); |
| 2855 | if (bits) { |
| 2856 | s << ","; |
| 2857 | } |
| 2858 | } |
| 2859 | } |
| 2860 | } |
| 2861 | |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2862 | // Validate draw-time state related to the PSO |
Tobin Ehlis | 288cb7e | 2016-12-21 08:30:22 -0700 | [diff] [blame] | 2863 | static bool ValidatePipelineDrawtimeState(layer_data const *my_data, LAST_BOUND_STATE const &state, const GLOBAL_CB_NODE *pCB, |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2864 | PIPELINE_STATE const *pPipeline) { |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2865 | bool skip_call = false; |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2866 | |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 2867 | // Verify vertex binding |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2868 | if (pPipeline->vertexBindingDescriptions.size() > 0) { |
| 2869 | for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { |
Tobin Ehlis | 9b9fdd3 | 2016-08-03 09:59:17 -0600 | [diff] [blame] | 2870 | auto vertex_binding = pPipeline->vertexBindingDescriptions[i].binding; |
| 2871 | if ((pCB->currentDrawData.buffers.size() < (vertex_binding + 1)) || |
| 2872 | (pCB->currentDrawData.buffers[vertex_binding] == VK_NULL_HANDLE)) { |
| 2873 | skip_call |= log_msg( |
| 2874 | my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 2875 | DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", |
| 2876 | "The Pipeline State Object (0x%" PRIxLEAST64 ") expects that this Command Buffer's vertex binding Index %u " |
| 2877 | "should be set via vkCmdBindVertexBuffers. This is because VkVertexInputBindingDescription struct " |
| 2878 | "at index " PRINTF_SIZE_T_SPECIFIER " of pVertexBindingDescriptions has a binding value of %u.", |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 2879 | (uint64_t)state.pipeline_state->pipeline, vertex_binding, i, vertex_binding); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2880 | } |
| 2881 | } |
| 2882 | } else { |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 2883 | if (!pCB->currentDrawData.buffers.empty() && !pCB->vertex_buffer_used) { |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2884 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, |
Tobin Ehlis | eb00b0d | 2016-08-17 07:55:55 -0600 | [diff] [blame] | 2885 | 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 2886 | "Vertex buffers are bound to command buffer (0x%p" |
Tobin Ehlis | eb00b0d | 2016-08-17 07:55:55 -0600 | [diff] [blame] | 2887 | ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 2888 | pCB->commandBuffer, (uint64_t)state.pipeline_state->pipeline); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2889 | } |
| 2890 | } |
| 2891 | // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. |
| 2892 | // Skip check if rasterization is disabled or there is no viewport. |
| 2893 | if ((!pPipeline->graphicsPipelineCI.pRasterizationState || |
| 2894 | (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && |
| 2895 | pPipeline->graphicsPipelineCI.pViewportState) { |
| 2896 | bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); |
| 2897 | bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2898 | |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2899 | if (dynViewport) { |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2900 | auto requiredViewportsMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->viewportCount) - 1; |
| 2901 | auto missingViewportMask = ~pCB->viewportMask & requiredViewportsMask; |
| 2902 | if (missingViewportMask) { |
| 2903 | std::stringstream ss; |
| 2904 | ss << "Dynamic viewport(s) "; |
| 2905 | list_bits(ss, missingViewportMask); |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 2906 | ss << " are used by pipeline state object, but were not provided via calls to vkCmdSetViewport()."; |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2907 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
| 2908 | __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", |
| 2909 | "%s", ss.str().c_str()); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2910 | } |
| 2911 | } |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2912 | |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2913 | if (dynScissor) { |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2914 | auto requiredScissorMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->scissorCount) - 1; |
| 2915 | auto missingScissorMask = ~pCB->scissorMask & requiredScissorMask; |
| 2916 | if (missingScissorMask) { |
| 2917 | std::stringstream ss; |
| 2918 | ss << "Dynamic scissor(s) "; |
| 2919 | list_bits(ss, missingScissorMask); |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 2920 | ss << " are used by pipeline state object, but were not provided via calls to vkCmdSetScissor()."; |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 2921 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
| 2922 | __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", |
| 2923 | "%s", ss.str().c_str()); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2924 | } |
| 2925 | } |
| 2926 | } |
| 2927 | |
| 2928 | // Verify that any MSAA request in PSO matches sample# in bound FB |
| 2929 | // Skip the check if rasterization is disabled. |
| 2930 | if (!pPipeline->graphicsPipelineCI.pRasterizationState || |
| 2931 | (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { |
| 2932 | VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); |
| 2933 | if (pCB->activeRenderPass) { |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 2934 | auto const render_pass_info = pCB->activeRenderPass->createInfo.ptr(); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2935 | const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2936 | uint32_t i; |
| 2937 | |
| 2938 | const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; |
| 2939 | if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && |
| 2940 | (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { |
| 2941 | skip_call |= |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2942 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2943 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2944 | "Render pass subpass %u mismatch with blending state defined and blend state attachment " |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 2945 | "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2946 | "must be the same at draw-time.", |
| 2947 | pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2948 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2949 | } |
| 2950 | |
Chris Forbes | 3437922 | 2016-06-29 18:15:41 +1200 | [diff] [blame] | 2951 | unsigned subpass_num_samples = 0; |
Chris Forbes | 074ec14 | 2016-06-29 10:50:41 +1200 | [diff] [blame] | 2952 | |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2953 | for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { |
Chris Forbes | 3437922 | 2016-06-29 18:15:41 +1200 | [diff] [blame] | 2954 | auto attachment = subpass_desc->pColorAttachments[i].attachment; |
| 2955 | if (attachment != VK_ATTACHMENT_UNUSED) |
| 2956 | subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2957 | } |
Chris Forbes | 074ec14 | 2016-06-29 10:50:41 +1200 | [diff] [blame] | 2958 | |
Chris Forbes | 3437922 | 2016-06-29 18:15:41 +1200 | [diff] [blame] | 2959 | if (subpass_desc->pDepthStencilAttachment && |
| 2960 | subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 2961 | auto attachment = subpass_desc->pDepthStencilAttachment->attachment; |
| 2962 | subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2963 | } |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2964 | |
Jamie Madill | 5738e27 | 2016-07-06 13:37:33 -0400 | [diff] [blame] | 2965 | if (subpass_num_samples && static_cast<unsigned>(pso_num_samples) != subpass_num_samples) { |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2966 | skip_call |= |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2967 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2968 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 2969 | "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 |
| 2970 | ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", |
Chris Forbes | 4e16d88 | 2016-05-06 15:54:55 +1200 | [diff] [blame] | 2971 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, |
Chris Forbes | a4937a7 | 2016-05-06 16:31:14 +1200 | [diff] [blame] | 2972 | reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2973 | } |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 2974 | } else { |
| 2975 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| 2976 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", |
| 2977 | "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", |
| 2978 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2979 | } |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 2980 | } |
Tobin Ehlis | 09d67d0 | 2016-06-07 06:06:01 -0600 | [diff] [blame] | 2981 | // Verify that PSO creation renderPass is compatible with active renderPass |
| 2982 | if (pCB->activeRenderPass) { |
| 2983 | std::string err_string; |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 2984 | if ((pCB->activeRenderPass->renderPass != pPipeline->graphicsPipelineCI.renderPass) && |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 2985 | !verify_renderpass_compatibility(my_data, pCB->activeRenderPass->createInfo.ptr(), pPipeline->render_pass_ci.ptr(), |
Tobin Ehlis | 09d67d0 | 2016-06-07 06:06:01 -0600 | [diff] [blame] | 2986 | err_string)) { |
| 2987 | // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with |
| 2988 | skip_call |= |
| 2989 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| 2990 | reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", |
| 2991 | "At Draw time the active render pass (0x%" PRIxLEAST64 ") is incompatible w/ gfx pipeline " |
| 2992 | "(0x%" PRIxLEAST64 ") that was created w/ render pass (0x%" PRIxLEAST64 ") due to: %s", |
Chris Forbes | 8249444 | 2016-10-17 15:45:49 +1300 | [diff] [blame] | 2993 | reinterpret_cast<uint64_t &>(pCB->activeRenderPass->renderPass), |
| 2994 | reinterpret_cast<uint64_t const &>(pPipeline->pipeline), |
Tobin Ehlis | 09d67d0 | 2016-06-07 06:06:01 -0600 | [diff] [blame] | 2995 | reinterpret_cast<const uint64_t &>(pPipeline->graphicsPipelineCI.renderPass), err_string.c_str()); |
| 2996 | } |
Chris Forbes | a58c452 | 2016-09-28 15:19:39 +1300 | [diff] [blame] | 2997 | |
| 2998 | if (pPipeline->graphicsPipelineCI.subpass != pCB->activeSubpass) { |
| 2999 | skip_call |= |
| 3000 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| 3001 | reinterpret_cast<uint64_t const &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", |
| 3002 | "Pipeline was built for subpass %u but used in subpass %u", pPipeline->graphicsPipelineCI.subpass, |
| 3003 | pCB->activeSubpass); |
| 3004 | } |
Tobin Ehlis | 09d67d0 | 2016-06-07 06:06:01 -0600 | [diff] [blame] | 3005 | } |
Chris Forbes | dbc6632 | 2016-05-31 16:33:48 +1200 | [diff] [blame] | 3006 | // TODO : Add more checks here |
| 3007 | |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 3008 | return skip_call; |
| 3009 | } |
| 3010 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3011 | // Validate overall state at the time of a draw call |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3012 | static bool ValidateDrawState(layer_data *my_data, GLOBAL_CB_NODE *cb_node, const bool indexed, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 3013 | const VkPipelineBindPoint bind_point, const char *function, |
| 3014 | UNIQUE_VALIDATION_ERROR_CODE const msg_code) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3015 | bool result = false; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3016 | auto const &state = cb_node->lastBound[bind_point]; |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3017 | PIPELINE_STATE *pPipe = state.pipeline_state; |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3018 | if (nullptr == pPipe) { |
| 3019 | result |= log_msg( |
| 3020 | my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 3021 | DRAWSTATE_INVALID_PIPELINE, "DS", |
| 3022 | "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); |
| 3023 | // Early return as any further checks below will be busted w/o a pipeline |
| 3024 | if (result) |
| 3025 | return true; |
| 3026 | } |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 3027 | // First check flag states |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3028 | if (VK_PIPELINE_BIND_POINT_GRAPHICS == bind_point) |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 3029 | result = validate_draw_state_flags(my_data, cb_node, pPipe, indexed, msg_code); |
Tobin Ehlis | 2e319d4 | 2016-03-25 11:49:51 -0600 | [diff] [blame] | 3030 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3031 | // Now complete other state checks |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 3032 | if (VK_NULL_HANDLE != state.pipeline_layout.layout) { |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3033 | string errorString; |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 3034 | auto pipeline_layout = pPipe->pipeline_layout; |
Chris Forbes | e96eb49 | 2016-05-31 16:45:13 +1200 | [diff] [blame] | 3035 | |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3036 | for (const auto &set_binding_pair : pPipe->active_slots) { |
| 3037 | uint32_t setIndex = set_binding_pair.first; |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3038 | // If valid set is not bound throw an error |
| 3039 | if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { |
| 3040 | result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3041 | DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 3042 | "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3043 | setIndex); |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 3044 | } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], &pipeline_layout, setIndex, |
| 3045 | errorString)) { |
| 3046 | // Set is bound but not compatible w/ overlapping pipeline_layout from PSO |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 3047 | VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3048 | result |= |
| 3049 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| 3050 | (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 3051 | "VkDescriptorSet (0x%" PRIxLEAST64 |
| 3052 | ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 3053 | reinterpret_cast<uint64_t &>(setHandle), setIndex, reinterpret_cast<uint64_t &>(pipeline_layout.layout), |
| 3054 | errorString.c_str()); |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3055 | } else { // Valid set is bound and layout compatible, validate that it's updated |
| 3056 | // Pull the set node |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3057 | cvdescriptorset::DescriptorSet *descriptor_set = state.boundDescriptorSets[setIndex]; |
Tobin Ehlis | f951910 | 2016-08-17 09:49:13 -0600 | [diff] [blame] | 3058 | // Gather active bindings |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 3059 | std::unordered_set<uint32_t> active_bindings; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3060 | for (auto binding : set_binding_pair.second) { |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 3061 | active_bindings.insert(binding.first); |
Tobin Ehlis | f951910 | 2016-08-17 09:49:13 -0600 | [diff] [blame] | 3062 | } |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3063 | // Make sure set has been updated if it has no immutable samplers |
| 3064 | // If it has immutable samplers, we'll flag error later as needed depending on binding |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3065 | if (!descriptor_set->IsUpdated()) { |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 3066 | for (auto binding : active_bindings) { |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3067 | if (!descriptor_set->GetImmutableSamplerPtrFromBinding(binding)) { |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3068 | result |= log_msg( |
| 3069 | my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3070 | (uint64_t)descriptor_set->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 3071 | "Descriptor Set 0x%" PRIxLEAST64 " bound but was never updated. It is now being used to draw so " |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3072 | "this will result in undefined behavior.", |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3073 | (uint64_t)descriptor_set->GetSet()); |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3074 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3075 | } |
| 3076 | } |
Tobin Ehlis | 205f003 | 2016-12-29 11:39:10 -0700 | [diff] [blame] | 3077 | // Validate the draw-time state for this descriptor set |
| 3078 | std::string err_str; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3079 | if (!descriptor_set->ValidateDrawState(set_binding_pair.second, state.dynamicOffsets[setIndex], &err_str)) { |
| 3080 | auto set = descriptor_set->GetSet(); |
Tobin Ehlis | 205f003 | 2016-12-29 11:39:10 -0700 | [diff] [blame] | 3081 | result |= |
| 3082 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| 3083 | reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", |
| 3084 | "Descriptor set 0x%" PRIxLEAST64 " encountered the following validation error at %s() time: %s", |
| 3085 | reinterpret_cast<const uint64_t &>(set), function, err_str.c_str()); |
| 3086 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3087 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3088 | } |
Tobin Ehlis | b8b6b27 | 2016-05-02 13:26:06 -0600 | [diff] [blame] | 3089 | } |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 3090 | |
| 3091 | // Check general pipeline state that needs to be validated at drawtime |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3092 | if (VK_PIPELINE_BIND_POINT_GRAPHICS == bind_point) |
Tobin Ehlis | 288cb7e | 2016-12-21 08:30:22 -0700 | [diff] [blame] | 3093 | result |= ValidatePipelineDrawtimeState(my_data, state, cb_node, pPipe); |
Mark Young | 2992748 | 2016-05-04 14:38:51 -0600 | [diff] [blame] | 3094 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3095 | return result; |
| 3096 | } |
| 3097 | |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3098 | static void UpdateDrawState(layer_data *my_data, GLOBAL_CB_NODE *cb_state, const VkPipelineBindPoint bind_point) { |
| 3099 | auto const &state = cb_state->lastBound[bind_point]; |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3100 | PIPELINE_STATE *pPipe = state.pipeline_state; |
| 3101 | if (VK_NULL_HANDLE != state.pipeline_layout.layout) { |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3102 | for (const auto &set_binding_pair : pPipe->active_slots) { |
| 3103 | uint32_t setIndex = set_binding_pair.first; |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3104 | // Pull the set node |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3105 | cvdescriptorset::DescriptorSet *descriptor_set = state.boundDescriptorSets[setIndex]; |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3106 | // Bind this set and its active descriptor resources to the command buffer |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3107 | descriptor_set->BindCommandBuffer(cb_state, set_binding_pair.second); |
Tobin Ehlis | 205f003 | 2016-12-29 11:39:10 -0700 | [diff] [blame] | 3108 | // For given active slots record updated images & buffers |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 3109 | descriptor_set->GetStorageUpdates(set_binding_pair.second, &cb_state->updateBuffers, &cb_state->updateImages); |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3110 | } |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3111 | } |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 3112 | if (pPipe->vertexBindingDescriptions.size() > 0) { |
| 3113 | cb_state->vertex_buffer_used = true; |
| 3114 | } |
Tobin Ehlis | 276d3d3 | 2016-12-21 09:21:06 -0700 | [diff] [blame] | 3115 | } |
| 3116 | |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 3117 | // Validate HW line width capabilities prior to setting requested line width. |
| 3118 | static bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { |
| 3119 | bool skip_call = false; |
| 3120 | |
| 3121 | // First check to see if the physical device supports wide lines. |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 3122 | if ((VK_FALSE == my_data->enabled_features.wideLines) && (1.0f != lineWidth)) { |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 3123 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, |
| 3124 | dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " |
| 3125 | "not supported/enabled so lineWidth must be 1.0f!", |
| 3126 | lineWidth); |
| 3127 | } else { |
| 3128 | // Otherwise, make sure the width falls in the valid range. |
| 3129 | if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || |
| 3130 | (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { |
| 3131 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, |
| 3132 | __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " |
| 3133 | "to between [%f, %f]!", |
| 3134 | lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], |
| 3135 | my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); |
| 3136 | } |
| 3137 | } |
| 3138 | |
| 3139 | return skip_call; |
| 3140 | } |
| 3141 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3142 | // Verify that create state for a pipeline is valid |
Mark Lobodzinski | 44e5999 | 2016-11-16 09:51:44 -0700 | [diff] [blame] | 3143 | static bool verifyPipelineCreateState(layer_data *my_data, std::vector<PIPELINE_STATE *> pPipelines, int pipelineIndex) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3144 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3145 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3146 | PIPELINE_STATE *pPipeline = pPipelines[pipelineIndex]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3147 | |
| 3148 | // If create derivative bit is set, check that we've specified a base |
| 3149 | // pipeline correctly, and that the base pipeline was created to allow |
| 3150 | // derivatives. |
| 3151 | if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3152 | PIPELINE_STATE *pBasePipeline = nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3153 | if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ |
| 3154 | (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3155 | // This check is a superset of VALIDATION_ERROR_00526 and VALIDATION_ERROR_00528 |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3156 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3157 | DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
| 3158 | "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3159 | } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { |
| 3160 | if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3161 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3162 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3163 | VALIDATION_ERROR_00518, "DS", |
| 3164 | "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline. %s", |
| 3165 | validation_error_map[VALIDATION_ERROR_00518]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3166 | } else { |
| 3167 | pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; |
| 3168 | } |
| 3169 | } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3170 | pBasePipeline = getPipelineState(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3171 | } |
| 3172 | |
| 3173 | if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3174 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3175 | DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
| 3176 | "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3177 | } |
| 3178 | } |
| 3179 | |
| 3180 | if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 3181 | if (!my_data->enabled_features.independentBlend) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 3182 | if (pPipeline->attachments.size() > 1) { |
Chris Forbes | 1ae3d40 | 2016-03-24 11:42:09 +1300 | [diff] [blame] | 3183 | VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; |
Mark Lobodzinski | 2f02dc9 | 2016-03-23 14:34:52 -0600 | [diff] [blame] | 3184 | for (size_t i = 1; i < pPipeline->attachments.size(); i++) { |
Mark Mueller | 35d4131 | 2016-07-13 14:49:35 -0600 | [diff] [blame] | 3185 | // Quoting the spec: "If [the independent blend] feature is not enabled, the VkPipelineColorBlendAttachmentState |
| 3186 | // settings for all color attachments must be identical." VkPipelineColorBlendAttachmentState contains |
| 3187 | // only attachment state, so memcmp is best suited for the comparison |
| 3188 | if (memcmp(static_cast<const void *>(pAttachments), static_cast<const void *>(&pAttachments[i]), |
| 3189 | sizeof(pAttachments[0]))) { |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3190 | skip_call |= |
| 3191 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3192 | VALIDATION_ERROR_01532, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " |
| 3193 | "enabled, all elements of pAttachments must be identical. %s", |
| 3194 | validation_error_map[VALIDATION_ERROR_01532]); |
Mark Mueller | 35d4131 | 2016-07-13 14:49:35 -0600 | [diff] [blame] | 3195 | break; |
Mark Lobodzinski | 2f02dc9 | 2016-03-23 14:34:52 -0600 | [diff] [blame] | 3196 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3197 | } |
| 3198 | } |
| 3199 | } |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 3200 | if (!my_data->enabled_features.logicOp && |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3201 | (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3202 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3203 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3204 | VALIDATION_ERROR_01533, "DS", |
| 3205 | "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE. %s", |
| 3206 | validation_error_map[VALIDATION_ERROR_01533]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3207 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3208 | } |
| 3209 | |
Tobin Ehlis | 81e8ca4 | 2016-03-24 09:17:25 -0600 | [diff] [blame] | 3210 | // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3211 | // produces nonsense errors that confuse users. Other layers should already |
| 3212 | // emit errors for renderpass being invalid. |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 3213 | auto renderPass = getRenderPassState(my_data, pPipeline->graphicsPipelineCI.renderPass); |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 3214 | if (renderPass && pPipeline->graphicsPipelineCI.subpass >= renderPass->createInfo.subpassCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3215 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3216 | VALIDATION_ERROR_02122, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " |
| 3217 | "is out of range for this renderpass (0..%u). %s", |
| 3218 | pPipeline->graphicsPipelineCI.subpass, renderPass->createInfo.subpassCount - 1, |
| 3219 | validation_error_map[VALIDATION_ERROR_02122]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3220 | } |
| 3221 | |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 3222 | if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->enabled_features, |
Chris Forbes | c9b826c | 2016-05-13 13:17:42 +1200 | [diff] [blame] | 3223 | my_data->shaderModuleMap)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3224 | skip_call = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3225 | } |
Chris Forbes | 3001c77 | 2016-04-06 11:21:28 +1200 | [diff] [blame] | 3226 | // Each shader's stage must be unique |
| 3227 | if (pPipeline->duplicate_shaders) { |
| 3228 | for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { |
| 3229 | if (pPipeline->duplicate_shaders & stage) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3230 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
| 3231 | __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", |
| 3232 | "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", |
| 3233 | string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); |
Chris Forbes | 3001c77 | 2016-04-06 11:21:28 +1200 | [diff] [blame] | 3234 | } |
| 3235 | } |
| 3236 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3237 | // VS is required |
| 3238 | if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3239 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3240 | VALIDATION_ERROR_00532, "DS", "Invalid Pipeline CreateInfo State: Vertex Shader required. %s", |
| 3241 | validation_error_map[VALIDATION_ERROR_00532]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3242 | } |
| 3243 | // Either both or neither TC/TE shaders should be defined |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3244 | if ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) && |
| 3245 | !(pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3246 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3247 | VALIDATION_ERROR_00534, "DS", |
| 3248 | "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair. %s", |
| 3249 | validation_error_map[VALIDATION_ERROR_00534]); |
| 3250 | } |
| 3251 | if (!(pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) && |
| 3252 | (pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT)) { |
| 3253 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3254 | VALIDATION_ERROR_00535, "DS", |
| 3255 | "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair. %s", |
| 3256 | validation_error_map[VALIDATION_ERROR_00535]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3257 | } |
| 3258 | // Compute shaders should be specified independent of Gfx shaders |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3259 | if (pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3260 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3261 | VALIDATION_ERROR_00533, "DS", |
| 3262 | "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline. %s", |
| 3263 | validation_error_map[VALIDATION_ERROR_00533]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3264 | } |
| 3265 | // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. |
| 3266 | // Mismatching primitive topology and tessellation fails graphics pipeline creation. |
| 3267 | if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 3268 | (!pPipeline->graphicsPipelineCI.pInputAssemblyState || |
| 3269 | pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3270 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3271 | VALIDATION_ERROR_02099, "DS", "Invalid Pipeline CreateInfo State: " |
| 3272 | "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " |
| 3273 | "topology for tessellation pipelines. %s", |
| 3274 | validation_error_map[VALIDATION_ERROR_02099]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3275 | } |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 3276 | if (pPipeline->graphicsPipelineCI.pInputAssemblyState && |
| 3277 | pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3278 | if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3279 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3280 | VALIDATION_ERROR_02100, "DS", "Invalid Pipeline CreateInfo State: " |
| 3281 | "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " |
| 3282 | "topology is only valid for tessellation pipelines. %s", |
| 3283 | validation_error_map[VALIDATION_ERROR_02100]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3284 | } |
| 3285 | } |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3286 | |
| 3287 | if (pPipeline->graphicsPipelineCI.pTessellationState && |
| 3288 | ((pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints == 0) || |
| 3289 | (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > |
| 3290 | my_data->phys_dev_properties.properties.limits.maxTessellationPatchSize))) { |
| 3291 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3292 | VALIDATION_ERROR_01426, "DS", "Invalid Pipeline CreateInfo State: " |
| 3293 | "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " |
| 3294 | "topology used with patchControlPoints value %u." |
| 3295 | " patchControlPoints should be >0 and <=%u. %s", |
| 3296 | pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints, |
| 3297 | my_data->phys_dev_properties.properties.limits.maxTessellationPatchSize, |
| 3298 | validation_error_map[VALIDATION_ERROR_01426]); |
| 3299 | } |
| 3300 | |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 3301 | // If a rasterization state is provided, make sure that the line width conforms to the HW. |
| 3302 | if (pPipeline->graphicsPipelineCI.pRasterizationState) { |
| 3303 | if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { |
Chris Forbes | 8249444 | 2016-10-17 15:45:49 +1300 | [diff] [blame] | 3304 | skip_call |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, |
| 3305 | reinterpret_cast<uint64_t const &>(pPipeline->pipeline), |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3306 | pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 3307 | } |
| 3308 | } |
Chris Forbes | d39376d | 2016-09-08 17:55:54 +1200 | [diff] [blame] | 3309 | |
Mark Lobodzinski | b23aa45 | 2016-12-16 13:06:41 -0700 | [diff] [blame] | 3310 | // If rasterization is not disabled and subpass uses a depth/stencil attachment, pDepthStencilState must be a pointer to a |
| 3311 | // valid structure |
| 3312 | if (pPipeline->graphicsPipelineCI.pRasterizationState && |
| 3313 | (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 3314 | auto subpass_desc = renderPass ? &renderPass->createInfo.pSubpasses[pPipeline->graphicsPipelineCI.subpass] : nullptr; |
Chris Forbes | d39376d | 2016-09-08 17:55:54 +1200 | [diff] [blame] | 3315 | if (subpass_desc && subpass_desc->pDepthStencilAttachment && |
| 3316 | subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 3317 | if (!pPipeline->graphicsPipelineCI.pDepthStencilState) { |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3318 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 3319 | 0, __LINE__, VALIDATION_ERROR_02115, "DS", |
Chris Forbes | d39376d | 2016-09-08 17:55:54 +1200 | [diff] [blame] | 3320 | "Invalid Pipeline CreateInfo State: " |
| 3321 | "pDepthStencilState is NULL when rasterization is enabled and subpass uses a " |
Mike Schuchardt | f9ad3c8 | 2017-01-03 15:21:24 -0700 | [diff] [blame] | 3322 | "depth/stencil attachment. %s", |
| 3323 | validation_error_map[VALIDATION_ERROR_02115]); |
Chris Forbes | d39376d | 2016-09-08 17:55:54 +1200 | [diff] [blame] | 3324 | } |
| 3325 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3326 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3327 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3328 | } |
| 3329 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3330 | // Free the Pipeline nodes |
| 3331 | static void deletePipelines(layer_data *my_data) { |
| 3332 | if (my_data->pipelineMap.size() <= 0) |
| 3333 | return; |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 3334 | for (auto &pipe_map_pair : my_data->pipelineMap) { |
| 3335 | delete pipe_map_pair.second; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3336 | } |
| 3337 | my_data->pipelineMap.clear(); |
| 3338 | } |
| 3339 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3340 | // Block of code at start here specifically for managing/tracking DSs |
| 3341 | |
| 3342 | // Return Pool node ptr for specified pool or else NULL |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 3343 | DESCRIPTOR_POOL_STATE *getDescriptorPoolState(const layer_data *dev_data, const VkDescriptorPool pool) { |
Tobin Ehlis | 71a93d3 | 2016-05-26 13:12:38 -0600 | [diff] [blame] | 3344 | auto pool_it = dev_data->descriptorPoolMap.find(pool); |
| 3345 | if (pool_it == dev_data->descriptorPoolMap.end()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3346 | return NULL; |
| 3347 | } |
Tobin Ehlis | 71a93d3 | 2016-05-26 13:12:38 -0600 | [diff] [blame] | 3348 | return pool_it->second; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3349 | } |
| 3350 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3351 | // Return false if update struct is of valid type, otherwise flag error and return code from callback |
| 3352 | static bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3353 | switch (pUpdateStruct->sType) { |
| 3354 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
| 3355 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3356 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3357 | default: |
| 3358 | return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3359 | DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", |
| 3360 | "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", |
| 3361 | string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); |
| 3362 | } |
| 3363 | } |
| 3364 | |
| 3365 | // Set count for given update struct in the last parameter |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3366 | static uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { |
| 3367 | switch (pUpdateStruct->sType) { |
| 3368 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
| 3369 | return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; |
| 3370 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
| 3371 | // TODO : Need to understand this case better and make sure code is correct |
| 3372 | return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; |
| 3373 | default: |
| 3374 | return 0; |
| 3375 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3376 | } |
| 3377 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3378 | // For given layout and update, return the first overall index of the layout that is updated |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3379 | static uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3380 | const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3381 | return binding_start_index + arrayIndex; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3382 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3383 | // For given layout and update, return the last overall index of the layout that is updated |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3384 | static uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3385 | const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { |
| 3386 | uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3387 | return binding_start_index + arrayIndex + count - 1; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3388 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3389 | // Verify that the descriptor type in the update struct matches what's expected by the layout |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3390 | static bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3391 | const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3392 | // First get actual type of update |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3393 | bool skip_call = false; |
Jamie Madill | 2b6b8d5 | 2016-04-04 15:09:51 -0400 | [diff] [blame] | 3394 | VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3395 | switch (pUpdateStruct->sType) { |
| 3396 | case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: |
| 3397 | actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; |
| 3398 | break; |
| 3399 | case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 3400 | // No need to validate |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3401 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3402 | break; |
| 3403 | default: |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3404 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3405 | DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", |
| 3406 | "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", |
| 3407 | string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3408 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3409 | if (!skip_call) { |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3410 | if (layout_type != actualType) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3411 | skip_call |= log_msg( |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 3412 | my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3413 | DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", |
| 3414 | "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", |
| 3415 | string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3416 | } |
| 3417 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3418 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3419 | } |
Michael Lentine | f7bf684 | 2016-03-30 15:57:52 -0500 | [diff] [blame] | 3420 | //TODO: Consolidate functions |
| 3421 | bool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { |
| 3422 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); |
| 3423 | if (!(imgpair.subresource.aspectMask & aspectMask)) { |
| 3424 | return false; |
| 3425 | } |
| 3426 | VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; |
| 3427 | imgpair.subresource.aspectMask = aspectMask; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3428 | auto imgsubIt = pCB->imageLayoutMap.find(imgpair); |
| 3429 | if (imgsubIt == pCB->imageLayoutMap.end()) { |
Michael Lentine | f7bf684 | 2016-03-30 15:57:52 -0500 | [diff] [blame] | 3430 | return false; |
| 3431 | } |
| 3432 | if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { |
| 3433 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 3434 | reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", |
| 3435 | "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", |
| 3436 | reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); |
| 3437 | } |
| 3438 | if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { |
| 3439 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 3440 | reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", |
| 3441 | "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", |
| 3442 | reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3443 | } |
| 3444 | node = imgsubIt->second; |
| 3445 | return true; |
| 3446 | } |
| 3447 | |
Michael Lentine | f7bf684 | 2016-03-30 15:57:52 -0500 | [diff] [blame] | 3448 | bool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { |
| 3449 | if (!(imgpair.subresource.aspectMask & aspectMask)) { |
| 3450 | return false; |
| 3451 | } |
| 3452 | VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; |
| 3453 | imgpair.subresource.aspectMask = aspectMask; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3454 | auto imgsubIt = my_data->imageLayoutMap.find(imgpair); |
| 3455 | if (imgsubIt == my_data->imageLayoutMap.end()) { |
Michael Lentine | f7bf684 | 2016-03-30 15:57:52 -0500 | [diff] [blame] | 3456 | return false; |
| 3457 | } |
| 3458 | if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { |
| 3459 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 3460 | reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", |
| 3461 | "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", |
| 3462 | reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3463 | } |
| 3464 | layout = imgsubIt->second.layout; |
| 3465 | return true; |
| 3466 | } |
| 3467 | |
Michael Lentine | f7bf684 | 2016-03-30 15:57:52 -0500 | [diff] [blame] | 3468 | // find layout(s) on the cmd buf level |
| 3469 | bool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { |
| 3470 | ImageSubresourcePair imgpair = {image, true, range}; |
| 3471 | node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); |
| 3472 | FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); |
| 3473 | FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 3474 | FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 3475 | FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); |
| 3476 | if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { |
| 3477 | imgpair = {image, false, VkImageSubresource()}; |
| 3478 | auto imgsubIt = pCB->imageLayoutMap.find(imgpair); |
| 3479 | if (imgsubIt == pCB->imageLayoutMap.end()) |
| 3480 | return false; |
| 3481 | node = imgsubIt->second; |
| 3482 | } |
| 3483 | return true; |
| 3484 | } |
| 3485 | |
| 3486 | // find layout(s) on the global level |
| 3487 | bool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { |
| 3488 | layout = VK_IMAGE_LAYOUT_MAX_ENUM; |
| 3489 | FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); |
| 3490 | FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 3491 | FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 3492 | FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); |
| 3493 | if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { |
| 3494 | imgpair = {imgpair.image, false, VkImageSubresource()}; |
| 3495 | auto imgsubIt = my_data->imageLayoutMap.find(imgpair); |
| 3496 | if (imgsubIt == my_data->imageLayoutMap.end()) |
| 3497 | return false; |
| 3498 | layout = imgsubIt->second.layout; |
| 3499 | } |
| 3500 | return true; |
| 3501 | } |
| 3502 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3503 | bool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { |
| 3504 | ImageSubresourcePair imgpair = {image, true, range}; |
| 3505 | return FindLayout(my_data, imgpair, layout); |
| 3506 | } |
| 3507 | |
| 3508 | bool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { |
| 3509 | auto sub_data = my_data->imageSubresourceMap.find(image); |
| 3510 | if (sub_data == my_data->imageSubresourceMap.end()) |
| 3511 | return false; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 3512 | auto image_state = getImageState(my_data, image); |
| 3513 | if (!image_state) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3514 | return false; |
| 3515 | bool ignoreGlobal = false; |
| 3516 | // TODO: Make this robust for >1 aspect mask. Now it will just say ignore |
| 3517 | // potential errors in this case. |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 3518 | if (sub_data->second.size() >= (image_state->createInfo.arrayLayers * image_state->createInfo.mipLevels + 1)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3519 | ignoreGlobal = true; |
| 3520 | } |
| 3521 | for (auto imgsubpair : sub_data->second) { |
| 3522 | if (ignoreGlobal && !imgsubpair.hasSubresource) |
| 3523 | continue; |
| 3524 | auto img_data = my_data->imageLayoutMap.find(imgsubpair); |
| 3525 | if (img_data != my_data->imageLayoutMap.end()) { |
| 3526 | layouts.push_back(img_data->second.layout); |
| 3527 | } |
| 3528 | } |
| 3529 | return true; |
| 3530 | } |
| 3531 | |
| 3532 | // Set the layout on the global level |
| 3533 | void SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { |
| 3534 | VkImage &image = imgpair.image; |
| 3535 | // TODO (mlentine): Maybe set format if new? Not used atm. |
| 3536 | my_data->imageLayoutMap[imgpair].layout = layout; |
| 3537 | // TODO (mlentine): Maybe make vector a set? |
| 3538 | auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); |
| 3539 | if (subresource == my_data->imageSubresourceMap[image].end()) { |
| 3540 | my_data->imageSubresourceMap[image].push_back(imgpair); |
| 3541 | } |
| 3542 | } |
| 3543 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3544 | // Set the layout on the cmdbuf level |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3545 | void SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3546 | pCB->imageLayoutMap[imgpair] = node; |
| 3547 | // TODO (mlentine): Maybe make vector a set? |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3548 | auto subresource = |
| 3549 | std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); |
| 3550 | if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { |
| 3551 | pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3552 | } |
| 3553 | } |
| 3554 | |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3555 | void SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3556 | // TODO (mlentine): Maybe make vector a set? |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3557 | if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != |
| 3558 | pCB->imageSubresourceMap[imgpair.image].end()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3559 | pCB->imageLayoutMap[imgpair].layout = layout; |
| 3560 | } else { |
| 3561 | // TODO (mlentine): Could be expensive and might need to be removed. |
| 3562 | assert(imgpair.hasSubresource); |
| 3563 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
Mark Lobodzinski | 41bfce0 | 2016-03-28 14:34:40 -0600 | [diff] [blame] | 3564 | if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { |
| 3565 | node.initialLayout = layout; |
| 3566 | } |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3567 | SetLayout(pCB, imgpair, {node.initialLayout, layout}); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3568 | } |
| 3569 | } |
| 3570 | |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3571 | template <class OBJECT, class LAYOUT> |
| 3572 | void SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { |
| 3573 | if (imgpair.subresource.aspectMask & aspectMask) { |
| 3574 | imgpair.subresource.aspectMask = aspectMask; |
| 3575 | SetLayout(pObject, imgpair, layout); |
| 3576 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3577 | } |
| 3578 | |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3579 | template <class OBJECT, class LAYOUT> |
| 3580 | void SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3581 | ImageSubresourcePair imgpair = {image, true, range}; |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3582 | SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); |
| 3583 | SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 3584 | SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 3585 | SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3586 | } |
| 3587 | |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3588 | template <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3589 | ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; |
Michael Lentine | 60063c2 | 2016-03-24 15:36:27 -0500 | [diff] [blame] | 3590 | SetLayout(pObject, image, imgpair, layout); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3591 | } |
| 3592 | |
| 3593 | void SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 3594 | auto view_state = getImageViewState(dev_data, imageView); |
| 3595 | assert(view_state); |
Tobin Ehlis | c8ca031 | 2016-09-22 07:30:05 -0600 | [diff] [blame] | 3596 | auto image = view_state->create_info.image; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 3597 | const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3598 | // TODO: Do not iterate over every possibility - consolidate where possible |
| 3599 | for (uint32_t j = 0; j < subRange.levelCount; j++) { |
| 3600 | uint32_t level = subRange.baseMipLevel + j; |
| 3601 | for (uint32_t k = 0; k < subRange.layerCount; k++) { |
| 3602 | uint32_t layer = subRange.baseArrayLayer + k; |
| 3603 | VkImageSubresource sub = {subRange.aspectMask, level, layer}; |
Mark Lobodzinski | 2af8e3f | 2016-08-01 15:51:39 -0600 | [diff] [blame] | 3604 | // TODO: If ImageView was created with depth or stencil, transition both layouts as |
| 3605 | // the aspectMask is ignored and both are used. Verify that the extra implicit layout |
| 3606 | // is OK for descriptor set layout validation |
Mark Lobodzinski | 77a5d6f | 2016-08-05 09:38:18 -0600 | [diff] [blame] | 3607 | if (subRange.aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 3608 | if (vk_format_is_depth_and_stencil(view_state->create_info.format)) { |
Mark Lobodzinski | 77a5d6f | 2016-08-05 09:38:18 -0600 | [diff] [blame] | 3609 | sub.aspectMask |= (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 3610 | } |
| 3611 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3612 | SetLayout(pCB, image, sub, layout); |
| 3613 | } |
| 3614 | } |
| 3615 | } |
| 3616 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3617 | // Validate that given set is valid and that it's not being used by an in-flight CmdBuffer |
| 3618 | // func_str is the name of the calling function |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3619 | // Return false if no errors occur |
| 3620 | // Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 3621 | static bool validateIdleDescriptorSet(const layer_data *dev_data, VkDescriptorSet set, std::string func_str) { |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 3622 | if (dev_data->instance_data->disabled.idle_descriptor_set) |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 3623 | return false; |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3624 | bool skip_call = false; |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 3625 | auto set_node = dev_data->setMap.find(set); |
| 3626 | if (set_node == dev_data->setMap.end()) { |
| 3627 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3628 | (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 3629 | "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3630 | (uint64_t)(set)); |
| 3631 | } else { |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 3632 | // TODO : This covers various error cases so should pass error enum into this function and use passed in enum here |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3633 | if (set_node->second->in_use.load()) { |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 3634 | skip_call |= |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 3635 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 3636 | (uint64_t)(set), __LINE__, VALIDATION_ERROR_00919, "DS", |
| 3637 | "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer. %s", |
| 3638 | func_str.c_str(), (uint64_t)(set), validation_error_map[VALIDATION_ERROR_00919]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3639 | } |
| 3640 | } |
| 3641 | return skip_call; |
| 3642 | } |
Chris Forbes | 367c032 | 2016-05-16 11:19:50 +1200 | [diff] [blame] | 3643 | |
Tobin Ehlis | ffbfe3f | 2016-05-26 13:39:11 -0600 | [diff] [blame] | 3644 | // Remove set from setMap and delete the set |
Tobin Ehlis | e335453 | 2016-05-05 13:49:42 -0600 | [diff] [blame] | 3645 | static void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { |
Tobin Ehlis | e335453 | 2016-05-05 13:49:42 -0600 | [diff] [blame] | 3646 | dev_data->setMap.erase(descriptor_set->GetSet()); |
| 3647 | delete descriptor_set; |
| 3648 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3649 | // Free all DS Pools including their Sets & related sub-structs |
| 3650 | // NOTE : Calls to this function should be wrapped in mutex |
| 3651 | static void deletePools(layer_data *my_data) { |
| 3652 | if (my_data->descriptorPoolMap.size() <= 0) |
| 3653 | return; |
| 3654 | for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { |
Tobin Ehlis | 5789b8f | 2016-05-05 13:18:20 -0600 | [diff] [blame] | 3655 | // Remove this pools' sets from setMap and delete them |
Tobin Ehlis | 0a43bde | 2016-05-03 08:31:08 -0600 | [diff] [blame] | 3656 | for (auto ds : (*ii).second->sets) { |
Tobin Ehlis | e335453 | 2016-05-05 13:49:42 -0600 | [diff] [blame] | 3657 | freeDescriptorSet(my_data, ds); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3658 | } |
Tobin Ehlis | 9bfd449 | 2016-05-05 15:09:11 -0600 | [diff] [blame] | 3659 | (*ii).second->sets.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3660 | } |
| 3661 | my_data->descriptorPoolMap.clear(); |
| 3662 | } |
| 3663 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3664 | static void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, |
| 3665 | VkDescriptorPoolResetFlags flags) { |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 3666 | DESCRIPTOR_POOL_STATE *pPool = getDescriptorPoolState(my_data, pool); |
Tobin Ehlis | 5d749ea | 2016-07-18 13:14:01 -0600 | [diff] [blame] | 3667 | // TODO: validate flags |
| 3668 | // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet |
| 3669 | for (auto ds : pPool->sets) { |
| 3670 | freeDescriptorSet(my_data, ds); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3671 | } |
Tobin Ehlis | 5d749ea | 2016-07-18 13:14:01 -0600 | [diff] [blame] | 3672 | pPool->sets.clear(); |
| 3673 | // Reset available count for each type and available sets for this pool |
| 3674 | for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { |
| 3675 | pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; |
| 3676 | } |
| 3677 | pPool->availableSets = pPool->maxSets; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3678 | } |
| 3679 | |
| 3680 | // For given CB object, fetch associated CB Node from map |
Chris Forbes | 664ca7f | 2016-05-06 16:55:18 +1200 | [diff] [blame] | 3681 | static GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { |
| 3682 | auto it = my_data->commandBufferMap.find(cb); |
| 3683 | if (it == my_data->commandBufferMap.end()) { |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 3684 | log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3685 | reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 3686 | "Attempt to use CommandBuffer 0x%p that doesn't exist!", cb); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3687 | return NULL; |
| 3688 | } |
Chris Forbes | 664ca7f | 2016-05-06 16:55:18 +1200 | [diff] [blame] | 3689 | return it->second; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3690 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3691 | // Free all CB Nodes |
| 3692 | // NOTE : Calls to this function should be wrapped in mutex |
| 3693 | static void deleteCommandBuffers(layer_data *my_data) { |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 3694 | if (my_data->commandBufferMap.empty()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3695 | return; |
| 3696 | } |
| 3697 | for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { |
| 3698 | delete (*ii).second; |
| 3699 | } |
| 3700 | my_data->commandBufferMap.clear(); |
| 3701 | } |
| 3702 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3703 | static bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3704 | return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3705 | (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", |
| 3706 | "You must call vkBeginCommandBuffer() before this call to %s", caller_name); |
| 3707 | } |
| 3708 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 3709 | // If a renderpass is active, verify that the given command type is appropriate for current subpass state |
| 3710 | bool ValidateCmdSubpassState(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3711 | if (!pCB->activeRenderPass) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 3712 | return false; |
| 3713 | bool skip_call = false; |
Tobin Ehlis | f5d1a09 | 2016-05-17 14:50:07 -0600 | [diff] [blame] | 3714 | if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && |
| 3715 | (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3716 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3717 | DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| 3718 | "Commands cannot be called in a subpass using secondary command buffers."); |
| 3719 | } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { |
| 3720 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3721 | DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| 3722 | "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); |
| 3723 | } |
| 3724 | return skip_call; |
| 3725 | } |
| 3726 | |
| 3727 | static bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { |
| 3728 | if (!(flags & VK_QUEUE_GRAPHICS_BIT)) |
| 3729 | return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3730 | DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| 3731 | "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); |
| 3732 | return false; |
| 3733 | } |
| 3734 | |
| 3735 | static bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { |
| 3736 | if (!(flags & VK_QUEUE_COMPUTE_BIT)) |
| 3737 | return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3738 | DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| 3739 | "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); |
| 3740 | return false; |
| 3741 | } |
| 3742 | |
| 3743 | static bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { |
| 3744 | if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) |
| 3745 | return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 3746 | DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
| 3747 | "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); |
| 3748 | return false; |
| 3749 | } |
| 3750 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 3751 | // Validate the given command being added to the specified cmd buffer, flagging errors if CB is not |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3752 | // in the recording state or if there's an issue with the Cmd ordering |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 3753 | static bool ValidateCmd(layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3754 | bool skip_call = false; |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 3755 | auto pPool = getCommandPoolNode(my_data, pCB->createInfo.commandPool); |
| 3756 | if (pPool) { |
| 3757 | VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].queueFlags; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3758 | switch (cmd) { |
| 3759 | case CMD_BINDPIPELINE: |
| 3760 | case CMD_BINDPIPELINEDELTA: |
| 3761 | case CMD_BINDDESCRIPTORSETS: |
| 3762 | case CMD_FILLBUFFER: |
| 3763 | case CMD_CLEARCOLORIMAGE: |
| 3764 | case CMD_SETEVENT: |
| 3765 | case CMD_RESETEVENT: |
| 3766 | case CMD_WAITEVENTS: |
| 3767 | case CMD_BEGINQUERY: |
| 3768 | case CMD_ENDQUERY: |
| 3769 | case CMD_RESETQUERYPOOL: |
| 3770 | case CMD_COPYQUERYPOOLRESULTS: |
| 3771 | case CMD_WRITETIMESTAMP: |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3772 | skip_call |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3773 | break; |
| 3774 | case CMD_SETVIEWPORTSTATE: |
| 3775 | case CMD_SETSCISSORSTATE: |
| 3776 | case CMD_SETLINEWIDTHSTATE: |
| 3777 | case CMD_SETDEPTHBIASSTATE: |
| 3778 | case CMD_SETBLENDSTATE: |
| 3779 | case CMD_SETDEPTHBOUNDSSTATE: |
| 3780 | case CMD_SETSTENCILREADMASKSTATE: |
| 3781 | case CMD_SETSTENCILWRITEMASKSTATE: |
| 3782 | case CMD_SETSTENCILREFERENCESTATE: |
| 3783 | case CMD_BINDINDEXBUFFER: |
| 3784 | case CMD_BINDVERTEXBUFFER: |
| 3785 | case CMD_DRAW: |
| 3786 | case CMD_DRAWINDEXED: |
| 3787 | case CMD_DRAWINDIRECT: |
| 3788 | case CMD_DRAWINDEXEDINDIRECT: |
| 3789 | case CMD_BLITIMAGE: |
| 3790 | case CMD_CLEARATTACHMENTS: |
| 3791 | case CMD_CLEARDEPTHSTENCILIMAGE: |
| 3792 | case CMD_RESOLVEIMAGE: |
| 3793 | case CMD_BEGINRENDERPASS: |
| 3794 | case CMD_NEXTSUBPASS: |
| 3795 | case CMD_ENDRENDERPASS: |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3796 | skip_call |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3797 | break; |
| 3798 | case CMD_DISPATCH: |
| 3799 | case CMD_DISPATCHINDIRECT: |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3800 | skip_call |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3801 | break; |
| 3802 | case CMD_COPYBUFFER: |
| 3803 | case CMD_COPYIMAGE: |
| 3804 | case CMD_COPYBUFFERTOIMAGE: |
| 3805 | case CMD_COPYIMAGETOBUFFER: |
| 3806 | case CMD_CLONEIMAGEDATA: |
| 3807 | case CMD_UPDATEBUFFER: |
| 3808 | case CMD_PIPELINEBARRIER: |
| 3809 | case CMD_EXECUTECOMMANDS: |
Tobin Ehlis | 244fe58 | 2016-05-16 11:23:01 -0600 | [diff] [blame] | 3810 | case CMD_END: |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3811 | break; |
| 3812 | default: |
| 3813 | break; |
| 3814 | } |
| 3815 | } |
| 3816 | if (pCB->state != CB_RECORDING) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3817 | skip_call |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); |
Tobin Ehlis | 244fe58 | 2016-05-16 11:23:01 -0600 | [diff] [blame] | 3818 | } else { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 3819 | skip_call |= ValidateCmdSubpassState(my_data, pCB, cmd); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3820 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 3821 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3822 | } |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 3823 | |
| 3824 | static void UpdateCmdBufferLastCmd(layer_data *my_data, GLOBAL_CB_NODE *cb_state, const CMD_TYPE cmd) { |
| 3825 | if (cb_state->state == CB_RECORDING) { |
| 3826 | cb_state->last_cmd = cmd; |
| 3827 | } |
| 3828 | } |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3829 | // For given object struct return a ptr of BASE_NODE type for its wrapping struct |
| 3830 | BASE_NODE *GetStateStructPtrFromObject(layer_data *dev_data, VK_OBJECT object_struct) { |
| 3831 | BASE_NODE *base_ptr = nullptr; |
| 3832 | switch (object_struct.type) { |
| 3833 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { |
| 3834 | base_ptr = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(object_struct.handle)); |
| 3835 | break; |
| 3836 | } |
| 3837 | case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 3838 | base_ptr = getSamplerState(dev_data, reinterpret_cast<VkSampler &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3839 | break; |
| 3840 | } |
| 3841 | case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { |
| 3842 | base_ptr = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(object_struct.handle)); |
| 3843 | break; |
| 3844 | } |
| 3845 | case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3846 | base_ptr = getPipelineState(dev_data, reinterpret_cast<VkPipeline &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3847 | break; |
| 3848 | } |
| 3849 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 3850 | base_ptr = getBufferState(dev_data, reinterpret_cast<VkBuffer &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3851 | break; |
| 3852 | } |
| 3853 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: { |
| 3854 | base_ptr = getBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(object_struct.handle)); |
| 3855 | break; |
| 3856 | } |
| 3857 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 3858 | base_ptr = getImageState(dev_data, reinterpret_cast<VkImage &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3859 | break; |
| 3860 | } |
| 3861 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: { |
| 3862 | base_ptr = getImageViewState(dev_data, reinterpret_cast<VkImageView &>(object_struct.handle)); |
| 3863 | break; |
| 3864 | } |
| 3865 | case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { |
| 3866 | base_ptr = getEventNode(dev_data, reinterpret_cast<VkEvent &>(object_struct.handle)); |
| 3867 | break; |
| 3868 | } |
| 3869 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: { |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 3870 | base_ptr = getDescriptorPoolState(dev_data, reinterpret_cast<VkDescriptorPool &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3871 | break; |
| 3872 | } |
| 3873 | case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: { |
| 3874 | base_ptr = getCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(object_struct.handle)); |
| 3875 | break; |
| 3876 | } |
| 3877 | case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: { |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 3878 | base_ptr = getFramebufferState(dev_data, reinterpret_cast<VkFramebuffer &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3879 | break; |
| 3880 | } |
| 3881 | case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 3882 | base_ptr = getRenderPassState(dev_data, reinterpret_cast<VkRenderPass &>(object_struct.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3883 | break; |
| 3884 | } |
| 3885 | case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: { |
| 3886 | base_ptr = getMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(object_struct.handle)); |
| 3887 | break; |
| 3888 | } |
| 3889 | default: |
| 3890 | // TODO : Any other objects to be handled here? |
| 3891 | assert(0); |
| 3892 | break; |
| 3893 | } |
| 3894 | return base_ptr; |
| 3895 | } |
| 3896 | |
Tobin Ehlis | bfb8cc3 | 2016-07-08 13:27:48 -0600 | [diff] [blame] | 3897 | // Tie the VK_OBJECT to the cmd buffer which includes: |
| 3898 | // Add object_binding to cmd buffer |
| 3899 | // Add cb_binding to object |
| 3900 | static void addCommandBufferBinding(std::unordered_set<GLOBAL_CB_NODE *> *cb_bindings, VK_OBJECT obj, GLOBAL_CB_NODE *cb_node) { |
| 3901 | cb_bindings->insert(cb_node); |
| 3902 | cb_node->object_bindings.insert(obj); |
| 3903 | } |
Tobin Ehlis | 96f1d60 | 2016-07-08 12:33:45 -0600 | [diff] [blame] | 3904 | // For a given object, if cb_node is in that objects cb_bindings, remove cb_node |
| 3905 | static void removeCommandBufferBinding(layer_data *dev_data, VK_OBJECT const *object, GLOBAL_CB_NODE *cb_node) { |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 3906 | BASE_NODE *base_obj = GetStateStructPtrFromObject(dev_data, *object); |
| 3907 | if (base_obj) |
| 3908 | base_obj->cb_bindings.erase(cb_node); |
Tobin Ehlis | 96f1d60 | 2016-07-08 12:33:45 -0600 | [diff] [blame] | 3909 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3910 | // Reset the command buffer state |
| 3911 | // Maintain the createInfo and set state to CB_NEW, but clear all other state |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 3912 | static void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { |
| 3913 | GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3914 | if (pCB) { |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 3915 | pCB->in_use.store(0); |
Chris Forbes | e46e0a1 | 2016-12-20 11:33:11 +1300 | [diff] [blame] | 3916 | pCB->last_cmd = CMD_NONE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3917 | // Reset CB state (note that createInfo is not cleared) |
| 3918 | pCB->commandBuffer = cb; |
| 3919 | memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); |
| 3920 | memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3921 | pCB->numCmds = 0; |
| 3922 | memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); |
| 3923 | pCB->state = CB_NEW; |
| 3924 | pCB->submitCount = 0; |
| 3925 | pCB->status = 0; |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 3926 | pCB->viewportMask = 0; |
| 3927 | pCB->scissorMask = 0; |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 3928 | |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 3929 | for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 3930 | pCB->lastBound[i].reset(); |
| 3931 | } |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 3932 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3933 | memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); |
Chris Forbes | a4937a7 | 2016-05-06 16:31:14 +1200 | [diff] [blame] | 3934 | pCB->activeRenderPass = nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3935 | pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; |
| 3936 | pCB->activeSubpass = 0; |
Tobin Ehlis | 2556f5b | 2016-06-24 17:22:16 -0600 | [diff] [blame] | 3937 | pCB->broken_bindings.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3938 | pCB->waitedEvents.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3939 | pCB->events.clear(); |
Mark Lobodzinski | c54d24e | 2016-06-13 16:56:26 -0600 | [diff] [blame] | 3940 | pCB->writeEventsBeforeWait.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3941 | pCB->waitedEventsBeforeQueryReset.clear(); |
| 3942 | pCB->queryToStateMap.clear(); |
| 3943 | pCB->activeQueries.clear(); |
| 3944 | pCB->startedQueries.clear(); |
Michael Lentine | 11fe377 | 2016-04-20 11:39:50 -0500 | [diff] [blame] | 3945 | pCB->imageSubresourceMap.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3946 | pCB->imageLayoutMap.clear(); |
| 3947 | pCB->eventToStageMap.clear(); |
| 3948 | pCB->drawData.clear(); |
| 3949 | pCB->currentDrawData.buffers.clear(); |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 3950 | pCB->vertex_buffer_used = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3951 | pCB->primaryCommandBuffer = VK_NULL_HANDLE; |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 3952 | // Make sure any secondaryCommandBuffers are removed from globalInFlight |
| 3953 | for (auto secondary_cb : pCB->secondaryCommandBuffers) { |
| 3954 | dev_data->globalInFlightCmdBuffers.erase(secondary_cb); |
| 3955 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3956 | pCB->secondaryCommandBuffers.clear(); |
Tobin Ehlis | 2e319d4 | 2016-03-25 11:49:51 -0600 | [diff] [blame] | 3957 | pCB->updateImages.clear(); |
| 3958 | pCB->updateBuffers.clear(); |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 3959 | clear_cmd_buf_and_mem_references(dev_data, pCB); |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 3960 | pCB->eventUpdates.clear(); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 3961 | pCB->queryUpdates.clear(); |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 3962 | |
Tobin Ehlis | 96f1d60 | 2016-07-08 12:33:45 -0600 | [diff] [blame] | 3963 | // Remove object bindings |
| 3964 | for (auto obj : pCB->object_bindings) { |
| 3965 | removeCommandBufferBinding(dev_data, &obj, pCB); |
| 3966 | } |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 3967 | pCB->object_bindings.clear(); |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 3968 | // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list |
| 3969 | for (auto framebuffer : pCB->framebuffers) { |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 3970 | auto fb_state = getFramebufferState(dev_data, framebuffer); |
| 3971 | if (fb_state) |
| 3972 | fb_state->cb_bindings.erase(pCB); |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 3973 | } |
| 3974 | pCB->framebuffers.clear(); |
Tobin Ehlis | 51b5f05 | 2016-05-16 08:36:40 -0600 | [diff] [blame] | 3975 | pCB->activeFramebuffer = VK_NULL_HANDLE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3976 | } |
| 3977 | } |
| 3978 | |
| 3979 | // Set PSO-related status bits for CB, including dynamic state set via PSO |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 3980 | static void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_STATE *pPipe) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3981 | // Account for any dynamic state not set via this PSO |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 3982 | if (!pPipe->graphicsPipelineCI.pDynamicState || |
| 3983 | !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static |
Tobin Ehlis | eebcc65 | 2016-10-25 15:23:08 -0600 | [diff] [blame] | 3984 | pCB->status |= CBSTATUS_ALL_STATE_SET; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3985 | } else { |
| 3986 | // First consider all state on |
| 3987 | // Then unset any state that's noted as dynamic in PSO |
| 3988 | // Finally OR that into CB statemask |
Tobin Ehlis | eebcc65 | 2016-10-25 15:23:08 -0600 | [diff] [blame] | 3989 | CBStatusFlags psoDynStateMask = CBSTATUS_ALL_STATE_SET; |
Tobin Ehlis | 5f4cef1 | 2016-04-01 13:51:33 -0600 | [diff] [blame] | 3990 | for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { |
| 3991 | switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 3992 | case VK_DYNAMIC_STATE_LINE_WIDTH: |
| 3993 | psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; |
| 3994 | break; |
| 3995 | case VK_DYNAMIC_STATE_DEPTH_BIAS: |
| 3996 | psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; |
| 3997 | break; |
| 3998 | case VK_DYNAMIC_STATE_BLEND_CONSTANTS: |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 3999 | psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4000 | break; |
| 4001 | case VK_DYNAMIC_STATE_DEPTH_BOUNDS: |
| 4002 | psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; |
| 4003 | break; |
| 4004 | case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: |
| 4005 | psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; |
| 4006 | break; |
| 4007 | case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: |
| 4008 | psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; |
| 4009 | break; |
| 4010 | case VK_DYNAMIC_STATE_STENCIL_REFERENCE: |
| 4011 | psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; |
| 4012 | break; |
| 4013 | default: |
| 4014 | // TODO : Flag error here |
| 4015 | break; |
| 4016 | } |
| 4017 | } |
| 4018 | pCB->status |= psoDynStateMask; |
| 4019 | } |
| 4020 | } |
| 4021 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4022 | // Flags validation error if the associated call is made inside a render pass. The apiName |
| 4023 | // routine should ONLY be called outside a render pass. |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 4024 | static bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName, |
| 4025 | UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 4026 | bool inside = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4027 | if (pCB->activeRenderPass) { |
| 4028 | inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 4029 | (uint64_t)pCB->commandBuffer, __LINE__, msgCode, "DS", |
| 4030 | "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 "). %s", apiName, |
| 4031 | (uint64_t)pCB->activeRenderPass->renderPass, validation_error_map[msgCode]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4032 | } |
| 4033 | return inside; |
| 4034 | } |
| 4035 | |
| 4036 | // Flags validation error if the associated call is made outside a render pass. The apiName |
| 4037 | // routine should ONLY be called inside a render pass. |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 4038 | static bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName, |
| 4039 | UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 4040 | bool outside = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4041 | if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || |
| 4042 | ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && |
| 4043 | !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { |
| 4044 | outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 4045 | (uint64_t)pCB->commandBuffer, __LINE__, msgCode, "DS", |
| 4046 | "%s: This call must be issued inside an active render pass. %s", apiName, validation_error_map[msgCode]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4047 | } |
| 4048 | return outside; |
| 4049 | } |
| 4050 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 4051 | static void init_core_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4052 | |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 4053 | layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4054 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4055 | } |
| 4056 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 4057 | static void checkInstanceRegisterExtensions(const VkInstanceCreateInfo *pCreateInfo, instance_layer_data *instance_data) { |
| 4058 | for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) { |
| 4059 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SURFACE_EXTENSION_NAME)) |
| 4060 | instance_data->surfaceExtensionEnabled = true; |
| 4061 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_DISPLAY_EXTENSION_NAME)) |
| 4062 | instance_data->displayExtensionEnabled = true; |
| 4063 | #ifdef VK_USE_PLATFORM_ANDROID_KHR |
| 4064 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_ANDROID_SURFACE_EXTENSION_NAME)) |
| 4065 | instance_data->androidSurfaceExtensionEnabled = true; |
| 4066 | #endif |
| 4067 | #ifdef VK_USE_PLATFORM_MIR_KHR |
| 4068 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_MIR_SURFACE_EXTENSION_NAME)) |
| 4069 | instance_data->mirSurfaceExtensionEnabled = true; |
| 4070 | #endif |
| 4071 | #ifdef VK_USE_PLATFORM_WAYLAND_KHR |
| 4072 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_WAYLAND_SURFACE_EXTENSION_NAME)) |
| 4073 | instance_data->waylandSurfaceExtensionEnabled = true; |
| 4074 | #endif |
| 4075 | #ifdef VK_USE_PLATFORM_WIN32_KHR |
| 4076 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_WIN32_SURFACE_EXTENSION_NAME)) |
| 4077 | instance_data->win32SurfaceExtensionEnabled = true; |
| 4078 | #endif |
| 4079 | #ifdef VK_USE_PLATFORM_XCB_KHR |
| 4080 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_XCB_SURFACE_EXTENSION_NAME)) |
| 4081 | instance_data->xcbSurfaceExtensionEnabled = true; |
| 4082 | #endif |
| 4083 | #ifdef VK_USE_PLATFORM_XLIB_KHR |
| 4084 | if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_XLIB_SURFACE_EXTENSION_NAME)) |
| 4085 | instance_data->xlibSurfaceExtensionEnabled = true; |
| 4086 | #endif |
| 4087 | } |
| 4088 | } |
| 4089 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 4090 | VKAPI_ATTR VkResult VKAPI_CALL |
| 4091 | CreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4092 | VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); |
| 4093 | |
| 4094 | assert(chain_info->u.pLayerInfo); |
| 4095 | PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; |
| 4096 | PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); |
| 4097 | if (fpCreateInstance == NULL) |
| 4098 | return VK_ERROR_INITIALIZATION_FAILED; |
| 4099 | |
| 4100 | // Advance the link info for the next element on the chain |
| 4101 | chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; |
| 4102 | |
| 4103 | VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); |
| 4104 | if (result != VK_SUCCESS) |
| 4105 | return result; |
| 4106 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 4107 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), instance_layer_data_map); |
Chia-I Wu | b2c32ea | 2016-05-06 12:19:33 +0800 | [diff] [blame] | 4108 | instance_data->instance = *pInstance; |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4109 | layer_init_instance_dispatch_table(*pInstance, &instance_data->dispatch_table, fpGetInstanceProcAddr); |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4110 | instance_data->report_data = debug_report_create_instance( |
| 4111 | &instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, pCreateInfo->ppEnabledExtensionNames); |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 4112 | checkInstanceRegisterExtensions(pCreateInfo, instance_data); |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 4113 | init_core_validation(instance_data, pAllocator); |
Mark Lobodzinski | bbe3d97 | 2016-06-29 10:53:51 -0600 | [diff] [blame] | 4114 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4115 | ValidateLayerOrdering(*pCreateInfo); |
| 4116 | |
| 4117 | return result; |
| 4118 | } |
| 4119 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 4120 | // Hook DestroyInstance to remove tableInstanceMap entry |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 4121 | VKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4122 | // TODOSC : Shouldn't need any customization here |
| 4123 | dispatch_key key = get_dispatch_key(instance); |
| 4124 | // TBD: Need any locking this early, in case this function is called at the |
| 4125 | // same time by more than one thread? |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4126 | instance_layer_data *instance_data = get_my_data_ptr(key, instance_layer_data_map); |
| 4127 | instance_data->dispatch_table.DestroyInstance(instance, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4128 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4129 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4130 | // Clean up logging callback, if any |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4131 | while (instance_data->logging_callback.size() > 0) { |
| 4132 | VkDebugReportCallbackEXT callback = instance_data->logging_callback.back(); |
| 4133 | layer_destroy_msg_callback(instance_data->report_data, callback, pAllocator); |
| 4134 | instance_data->logging_callback.pop_back(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4135 | } |
| 4136 | |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4137 | layer_debug_report_destroy_instance(instance_data->report_data); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4138 | layer_data_map.erase(key); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4139 | } |
| 4140 | |
Mark Young | aa1aa3a | 2016-07-05 16:41:50 -0600 | [diff] [blame] | 4141 | static void checkDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4142 | uint32_t i; |
| 4143 | // TBD: Need any locking, in case this function is called at the same time |
| 4144 | // by more than one thread? |
| 4145 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 4146 | dev_data->device_extensions.wsi_enabled = false; |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 4147 | dev_data->device_extensions.wsi_display_swapchain_enabled = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4148 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4149 | for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { |
| 4150 | if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) |
| 4151 | dev_data->device_extensions.wsi_enabled = true; |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 4152 | if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_DISPLAY_SWAPCHAIN_EXTENSION_NAME) == 0) |
| 4153 | dev_data->device_extensions.wsi_display_swapchain_enabled = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4154 | } |
| 4155 | } |
| 4156 | |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4157 | // Verify that queue family has been properly requested |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 4158 | static bool ValidateRequestedQueueFamilyProperties(instance_layer_data *instance_data, VkPhysicalDevice gpu, |
| 4159 | const VkDeviceCreateInfo *create_info) { |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4160 | bool skip_call = false; |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4161 | auto physical_device_state = getPhysicalDeviceState(instance_data, gpu); |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4162 | // First check is app has actually requested queueFamilyProperties |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4163 | if (!physical_device_state) { |
| 4164 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4165 | 0, __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", |
| 4166 | "Invalid call to vkCreateDevice() w/o first calling vkEnumeratePhysicalDevices()."); |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4167 | } else if (QUERY_DETAILS != physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4168 | // TODO: This is not called out as an invalid use in the spec so make more informative recommendation. |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4169 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4170 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, |
| 4171 | "DL", "Call to vkCreateDevice() w/o first calling vkGetPhysicalDeviceQueueFamilyProperties()."); |
| 4172 | } else { |
| 4173 | // Check that the requested queue properties are valid |
| 4174 | for (uint32_t i = 0; i < create_info->queueCreateInfoCount; i++) { |
| 4175 | uint32_t requestedIndex = create_info->pQueueCreateInfos[i].queueFamilyIndex; |
Chris Forbes | 8c09adb | 2016-10-03 18:06:20 +1300 | [diff] [blame] | 4176 | if (requestedIndex >= physical_device_state->queue_family_properties.size()) { |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4177 | skip_call |= log_msg( |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4178 | instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4179 | __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", |
| 4180 | "Invalid queue create request in vkCreateDevice(). Invalid queueFamilyIndex %u requested.", requestedIndex); |
| 4181 | } else if (create_info->pQueueCreateInfos[i].queueCount > |
Chris Forbes | 8c09adb | 2016-10-03 18:06:20 +1300 | [diff] [blame] | 4182 | physical_device_state->queue_family_properties[requestedIndex].queueCount) { |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4183 | skip_call |= |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4184 | log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4185 | 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", |
| 4186 | "Invalid queue create request in vkCreateDevice(). QueueFamilyIndex %u only has %u queues, but " |
| 4187 | "requested queueCount is %u.", |
Chris Forbes | 8c09adb | 2016-10-03 18:06:20 +1300 | [diff] [blame] | 4188 | requestedIndex, physical_device_state->queue_family_properties[requestedIndex].queueCount, |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4189 | create_info->pQueueCreateInfos[i].queueCount); |
| 4190 | } |
| 4191 | } |
| 4192 | } |
| 4193 | return skip_call; |
| 4194 | } |
| 4195 | |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4196 | // Verify that features have been queried and that they are available |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 4197 | static bool ValidateRequestedFeatures(instance_layer_data *dev_data, VkPhysicalDevice phys, const VkPhysicalDeviceFeatures *requested_features) { |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4198 | bool skip_call = false; |
| 4199 | |
Chris Forbes | 8245eba | 2016-10-03 17:36:32 +1300 | [diff] [blame] | 4200 | auto phys_device_state = getPhysicalDeviceState(dev_data, phys); |
| 4201 | const VkBool32 *actual = reinterpret_cast<VkBool32 *>(&phys_device_state->features); |
Mark Lobodzinski | bbe3d97 | 2016-06-29 10:53:51 -0600 | [diff] [blame] | 4202 | const VkBool32 *requested = reinterpret_cast<const VkBool32 *>(requested_features); |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4203 | // TODO : This is a nice, compact way to loop through struct, but a bad way to report issues |
| 4204 | // Need to provide the struct member name with the issue. To do that seems like we'll |
| 4205 | // have to loop through each struct member which should be done w/ codegen to keep in synch. |
| 4206 | uint32_t errors = 0; |
| 4207 | uint32_t total_bools = sizeof(VkPhysicalDeviceFeatures) / sizeof(VkBool32); |
| 4208 | for (uint32_t i = 0; i < total_bools; i++) { |
| 4209 | if (requested[i] > actual[i]) { |
| 4210 | // TODO: Add index to struct member name helper to be able to include a feature name |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4211 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4212 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, |
| 4213 | "DL", "While calling vkCreateDevice(), requesting feature #%u in VkPhysicalDeviceFeatures struct, " |
| 4214 | "which is not available on this device.", |
| 4215 | i); |
| 4216 | errors++; |
| 4217 | } |
| 4218 | } |
Chris Forbes | 8245eba | 2016-10-03 17:36:32 +1300 | [diff] [blame] | 4219 | if (errors && (UNCALLED == phys_device_state->vkGetPhysicalDeviceFeaturesState)) { |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4220 | // If user didn't request features, notify them that they should |
| 4221 | // TODO: Verify this against the spec. I believe this is an invalid use of the API and should return an error |
Mark Lobodzinski | 9cbcee0 | 2016-06-28 13:58:54 -0600 | [diff] [blame] | 4222 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 4223 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, |
| 4224 | "DL", "You requested features that are unavailable on this device. You should first query feature " |
| 4225 | "availability by calling vkGetPhysicalDeviceFeatures()."); |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4226 | } |
| 4227 | return skip_call; |
| 4228 | } |
| 4229 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 4230 | VKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, |
| 4231 | const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 4232 | instance_layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), instance_layer_data_map); |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4233 | bool skip_call = false; |
| 4234 | |
| 4235 | // Check that any requested features are available |
| 4236 | if (pCreateInfo->pEnabledFeatures) { |
Chris Forbes | 8245eba | 2016-10-03 17:36:32 +1300 | [diff] [blame] | 4237 | skip_call |= ValidateRequestedFeatures(my_instance_data, gpu, pCreateInfo->pEnabledFeatures); |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4238 | } |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 4239 | skip_call |= ValidateRequestedQueueFamilyProperties(my_instance_data, gpu, pCreateInfo); |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 4240 | |
Mark Mueller | 49b3200 | 2016-08-16 09:47:31 -0600 | [diff] [blame] | 4241 | if (skip_call) { |
| 4242 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 4243 | } |
| 4244 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4245 | VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); |
| 4246 | |
| 4247 | assert(chain_info->u.pLayerInfo); |
| 4248 | PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; |
| 4249 | PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; |
Chia-I Wu | b2c32ea | 2016-05-06 12:19:33 +0800 | [diff] [blame] | 4250 | PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4251 | if (fpCreateDevice == NULL) { |
| 4252 | return VK_ERROR_INITIALIZATION_FAILED; |
| 4253 | } |
| 4254 | |
| 4255 | // Advance the link info for the next element on the chain |
| 4256 | chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; |
| 4257 | |
| 4258 | VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); |
| 4259 | if (result != VK_SUCCESS) { |
| 4260 | return result; |
| 4261 | } |
| 4262 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4263 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4264 | layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); |
| 4265 | |
Chris Forbes | 2e6c494 | 2016-10-03 17:44:52 +1300 | [diff] [blame] | 4266 | my_device_data->instance_data = my_instance_data; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4267 | // Setup device dispatch table |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 4268 | layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr); |
Chris Forbes | 1586450 | 2016-03-30 11:35:21 +1300 | [diff] [blame] | 4269 | my_device_data->device = *pDevice; |
Mark Lobodzinski | cf0f7b6 | 2016-11-16 12:12:56 -0700 | [diff] [blame] | 4270 | // Save PhysicalDevice handle |
| 4271 | my_device_data->physical_device = gpu; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4272 | |
| 4273 | my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); |
Mark Young | aa1aa3a | 2016-07-05 16:41:50 -0600 | [diff] [blame] | 4274 | checkDeviceRegisterExtensions(pCreateInfo, *pDevice); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4275 | // Get physical device limits for this device |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4276 | my_instance_data->dispatch_table.GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4277 | uint32_t count; |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4278 | my_instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 4279 | my_device_data->phys_dev_properties.queue_family_properties.resize(count); |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4280 | my_instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties( |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 4281 | gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4282 | // TODO: device limits should make sure these are compatible |
| 4283 | if (pCreateInfo->pEnabledFeatures) { |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 4284 | my_device_data->enabled_features = *pCreateInfo->pEnabledFeatures; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4285 | } else { |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 4286 | memset(&my_device_data->enabled_features, 0, sizeof(VkPhysicalDeviceFeatures)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4287 | } |
Mark Lobodzinski | f685859 | 2017-01-11 09:34:01 -0700 | [diff] [blame] | 4288 | // Store physical device properties and physical device mem limits into device layer_data structs |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 4289 | my_instance_data->dispatch_table.GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); |
Mark Lobodzinski | f685859 | 2017-01-11 09:34:01 -0700 | [diff] [blame] | 4290 | my_instance_data->dispatch_table.GetPhysicalDeviceProperties(gpu, &my_device_data->phys_dev_props); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4291 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4292 | |
| 4293 | ValidateLayerOrdering(*pCreateInfo); |
| 4294 | |
| 4295 | return result; |
| 4296 | } |
| 4297 | |
| 4298 | // prototype |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 4299 | VKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4300 | // TODOSC : Shouldn't need any customization here |
Tobin Ehlis | bdacdd8 | 2016-10-12 07:25:59 -0600 | [diff] [blame] | 4301 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4302 | dispatch_key key = get_dispatch_key(device); |
| 4303 | layer_data *dev_data = get_my_data_ptr(key, layer_data_map); |
| 4304 | // Free all the memory |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4305 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4306 | deletePipelines(dev_data); |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 4307 | dev_data->renderPassMap.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4308 | deleteCommandBuffers(dev_data); |
Tobin Ehlis | 9bfd449 | 2016-05-05 15:09:11 -0600 | [diff] [blame] | 4309 | // This will also delete all sets in the pool & remove them from setMap |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4310 | deletePools(dev_data); |
Tobin Ehlis | 9bfd449 | 2016-05-05 15:09:11 -0600 | [diff] [blame] | 4311 | // All sets should be removed |
| 4312 | assert(dev_data->setMap.empty()); |
Tobin Ehlis | 546326f | 2016-04-26 11:06:05 -0600 | [diff] [blame] | 4313 | for (auto del_layout : dev_data->descriptorSetLayoutMap) { |
| 4314 | delete del_layout.second; |
| 4315 | } |
Tobin Ehlis | 2d9deec | 2016-04-21 14:19:26 -0600 | [diff] [blame] | 4316 | dev_data->descriptorSetLayoutMap.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4317 | dev_data->imageViewMap.clear(); |
| 4318 | dev_data->imageMap.clear(); |
| 4319 | dev_data->imageSubresourceMap.clear(); |
| 4320 | dev_data->imageLayoutMap.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4321 | dev_data->bufferViewMap.clear(); |
| 4322 | dev_data->bufferMap.clear(); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4323 | // Queues persist until device is destroyed |
| 4324 | dev_data->queueMap.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4325 | // Report any memory leaks |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4326 | layer_debug_report_destroy_device(device); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4327 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4328 | |
| 4329 | #if DISPATCH_MAP_DEBUG |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4330 | fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4331 | #endif |
Tobin Ehlis | bdacdd8 | 2016-10-12 07:25:59 -0600 | [diff] [blame] | 4332 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 4333 | dev_data->dispatch_table.DestroyDevice(device, pAllocator); |
Tobin Ehlis | bdacdd8 | 2016-10-12 07:25:59 -0600 | [diff] [blame] | 4334 | layer_data_map.erase(key); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4335 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4336 | } |
| 4337 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4338 | static const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; |
| 4339 | |
Tobin Ehlis | b093da8 | 2017-01-19 12:05:27 -0700 | [diff] [blame] | 4340 | // For given stage mask, if Geometry shader stage is on w/o GS being enabled, report geo_error_id |
| 4341 | // and if Tessellation Control or Evaluation shader stages are on w/o TS being enabled, report tess_error_id |
| 4342 | static bool ValidateStageMaskGsTsEnables(layer_data *dev_data, VkPipelineStageFlags stageMask, const char *caller, |
| 4343 | UNIQUE_VALIDATION_ERROR_CODE geo_error_id, UNIQUE_VALIDATION_ERROR_CODE tess_error_id) { |
| 4344 | bool skip = false; |
| 4345 | if (!dev_data->enabled_features.geometryShader && (stageMask & VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT)) { |
| 4346 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| 4347 | geo_error_id, "DL", "%s call includes a stageMask with VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT bit set when " |
| 4348 | "device does not have geometryShader feature enabled. %s", |
| 4349 | caller, validation_error_map[geo_error_id]); |
| 4350 | } |
| 4351 | if (!dev_data->enabled_features.tessellationShader && |
| 4352 | (stageMask & (VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT | VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT))) { |
| 4353 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, |
| 4354 | tess_error_id, "DL", "%s call includes a stageMask with VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT " |
| 4355 | "and/or VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT bit(s) set when device " |
| 4356 | "does not have tessellationShader feature enabled. %s", |
| 4357 | caller, validation_error_map[tess_error_id]); |
| 4358 | } |
| 4359 | return skip; |
| 4360 | } |
| 4361 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4362 | // This validates that the initial layout specified in the command buffer for |
| 4363 | // the IMAGE is the same |
| 4364 | // as the global IMAGE layout |
Chris Forbes | 3535888 | 2016-05-17 17:42:27 +1200 | [diff] [blame] | 4365 | static bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 4366 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4367 | for (auto cb_image_data : pCB->imageLayoutMap) { |
| 4368 | VkImageLayout imageLayout; |
| 4369 | if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { |
| 4370 | skip_call |= |
| 4371 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4372 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4373 | reinterpret_cast<const uint64_t &>(cb_image_data.first)); |
| 4374 | } else { |
| 4375 | if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { |
| 4376 | // TODO: Set memory invalid which is in mem_tracker currently |
| 4377 | } else if (imageLayout != cb_image_data.second.initialLayout) { |
Mark Young | 000d14d | 2016-04-11 16:53:53 -0600 | [diff] [blame] | 4378 | if (cb_image_data.first.hasSubresource) { |
| 4379 | skip_call |= log_msg( |
| 4380 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Chris Forbes | 3535888 | 2016-05-17 17:42:27 +1200 | [diff] [blame] | 4381 | reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4382 | "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " |
Mark Young | 000d14d | 2016-04-11 16:53:53 -0600 | [diff] [blame] | 4383 | "with layout %s when first use is %s.", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4384 | reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, |
| 4385 | cb_image_data.first.subresource.arrayLayer, |
| 4386 | cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), |
Mark Young | 000d14d | 2016-04-11 16:53:53 -0600 | [diff] [blame] | 4387 | string_VkImageLayout(cb_image_data.second.initialLayout)); |
| 4388 | } else { |
| 4389 | skip_call |= log_msg( |
| 4390 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Chris Forbes | 3535888 | 2016-05-17 17:42:27 +1200 | [diff] [blame] | 4391 | reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4392 | "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " |
Mark Young | 000d14d | 2016-04-11 16:53:53 -0600 | [diff] [blame] | 4393 | "first use is %s.", |
| 4394 | reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), |
| 4395 | string_VkImageLayout(cb_image_data.second.initialLayout)); |
| 4396 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4397 | } |
| 4398 | SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); |
| 4399 | } |
| 4400 | } |
| 4401 | return skip_call; |
| 4402 | } |
Mark Lobodzinski | f7422d9 | 2016-03-25 15:22:33 -0600 | [diff] [blame] | 4403 | |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4404 | // Loop through bound objects and increment their in_use counts |
| 4405 | // For any unknown objects, flag an error |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4406 | static bool ValidateAndIncrementBoundObjects(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4407 | bool skip = false; |
| 4408 | DRAW_STATE_ERROR error_code = DRAWSTATE_NONE; |
| 4409 | BASE_NODE *base_obj = nullptr; |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4410 | for (auto obj : cb_node->object_bindings) { |
| 4411 | switch (obj.type) { |
| 4412 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4413 | base_obj = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(obj.handle)); |
| 4414 | error_code = DRAWSTATE_INVALID_DESCRIPTOR_SET; |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4415 | break; |
| 4416 | } |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 4417 | case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 4418 | base_obj = getSamplerState(dev_data, reinterpret_cast<VkSampler &>(obj.handle)); |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4419 | error_code = DRAWSTATE_INVALID_SAMPLER; |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 4420 | break; |
| 4421 | } |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4422 | case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4423 | base_obj = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(obj.handle)); |
| 4424 | error_code = DRAWSTATE_INVALID_QUERY_POOL; |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4425 | break; |
| 4426 | } |
| 4427 | case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 4428 | base_obj = getPipelineState(dev_data, reinterpret_cast<VkPipeline &>(obj.handle)); |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4429 | error_code = DRAWSTATE_INVALID_PIPELINE; |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4430 | break; |
| 4431 | } |
| 4432 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 4433 | base_obj = getBufferState(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4434 | error_code = DRAWSTATE_INVALID_BUFFER; |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4435 | break; |
| 4436 | } |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4437 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: { |
| 4438 | base_obj = getBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(obj.handle)); |
| 4439 | error_code = DRAWSTATE_INVALID_BUFFER_VIEW; |
| 4440 | break; |
| 4441 | } |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4442 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 4443 | base_obj = getImageState(dev_data, reinterpret_cast<VkImage &>(obj.handle)); |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4444 | error_code = DRAWSTATE_INVALID_IMAGE; |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4445 | break; |
| 4446 | } |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4447 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: { |
| 4448 | base_obj = getImageViewState(dev_data, reinterpret_cast<VkImageView &>(obj.handle)); |
| 4449 | error_code = DRAWSTATE_INVALID_IMAGE_VIEW; |
| 4450 | break; |
| 4451 | } |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4452 | case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4453 | base_obj = getEventNode(dev_data, reinterpret_cast<VkEvent &>(obj.handle)); |
| 4454 | error_code = DRAWSTATE_INVALID_EVENT; |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4455 | break; |
| 4456 | } |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4457 | case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: { |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 4458 | base_obj = getDescriptorPoolState(dev_data, reinterpret_cast<VkDescriptorPool &>(obj.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4459 | error_code = DRAWSTATE_INVALID_DESCRIPTOR_POOL; |
| 4460 | break; |
| 4461 | } |
| 4462 | case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: { |
| 4463 | base_obj = getCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(obj.handle)); |
| 4464 | error_code = DRAWSTATE_INVALID_COMMAND_POOL; |
| 4465 | break; |
| 4466 | } |
| 4467 | case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: { |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 4468 | base_obj = getFramebufferState(dev_data, reinterpret_cast<VkFramebuffer &>(obj.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4469 | error_code = DRAWSTATE_INVALID_FRAMEBUFFER; |
| 4470 | break; |
| 4471 | } |
| 4472 | case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 4473 | base_obj = getRenderPassState(dev_data, reinterpret_cast<VkRenderPass &>(obj.handle)); |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4474 | error_code = DRAWSTATE_INVALID_RENDERPASS; |
| 4475 | break; |
| 4476 | } |
| 4477 | case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: { |
| 4478 | base_obj = getMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(obj.handle)); |
| 4479 | error_code = DRAWSTATE_INVALID_DEVICE_MEMORY; |
| 4480 | break; |
| 4481 | } |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4482 | default: |
| 4483 | // TODO : Merge handling of other objects types into this code |
| 4484 | break; |
| 4485 | } |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4486 | if (!base_obj) { |
| 4487 | skip |= |
| 4488 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj.type, obj.handle, __LINE__, error_code, "DS", |
| 4489 | "Cannot submit cmd buffer using deleted %s 0x%" PRIx64 ".", object_type_to_string(obj.type), obj.handle); |
| 4490 | } else { |
| 4491 | base_obj->in_use.fetch_add(1); |
| 4492 | } |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4493 | } |
Tobin Ehlis | effb4b4 | 2016-09-14 06:55:51 -0600 | [diff] [blame] | 4494 | return skip; |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4495 | } |
| 4496 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4497 | // Track which resources are in-flight by atomically incrementing their "in_use" count |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4498 | static bool validateAndIncrementResources(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 4499 | bool skip_call = false; |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4500 | |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4501 | cb_node->in_use.fetch_add(1); |
| 4502 | dev_data->globalInFlightCmdBuffers.insert(cb_node->commandBuffer); |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4503 | |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4504 | // First Increment for all "generic" objects bound to cmd buffer, followed by special-case objects below |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4505 | skip_call |= ValidateAndIncrementBoundObjects(dev_data, cb_node); |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4506 | // TODO : We should be able to remove the NULL look-up checks from the code below as long as |
| 4507 | // all the corresponding cases are verified to cause CB_INVALID state and the CB_INVALID state |
| 4508 | // should then be flagged prior to calling this function |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4509 | for (auto drawDataElement : cb_node->drawData) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4510 | for (auto buffer : drawDataElement.buffers) { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 4511 | auto buffer_state = getBufferState(dev_data, buffer); |
| 4512 | if (!buffer_state) { |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4513 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4514 | (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4515 | "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4516 | } else { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 4517 | buffer_state->in_use.fetch_add(1); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4518 | } |
| 4519 | } |
| 4520 | } |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4521 | for (auto event : cb_node->writeEventsBeforeWait) { |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 4522 | auto event_state = getEventNode(dev_data, event); |
| 4523 | if (event_state) |
| 4524 | event_state->write_in_use++; |
Michael Lentine | 860b0fe | 2016-05-20 10:14:00 -0500 | [diff] [blame] | 4525 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4526 | return skip_call; |
| 4527 | } |
| 4528 | |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4529 | // Note: This function assumes that the global lock is held by the calling thread. |
| 4530 | // For the given queue, verify the queue state up to the given seq number. |
| 4531 | // Currently the only check is to make sure that if there are events to be waited on prior to |
| 4532 | // a QueryReset, make sure that all such events have been signalled. |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4533 | static bool VerifyQueueStateToSeq(layer_data *dev_data, QUEUE_STATE *queue, uint64_t seq) { |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4534 | bool skip = false; |
| 4535 | auto queue_seq = queue->seq; |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4536 | std::unordered_map<VkQueue, uint64_t> other_queue_seqs; |
| 4537 | auto sub_it = queue->submissions.begin(); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4538 | while (queue_seq < seq) { |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4539 | for (auto &wait : sub_it->waitSemaphores) { |
| 4540 | auto &last_seq = other_queue_seqs[wait.queue]; |
| 4541 | last_seq = std::max(last_seq, wait.seq); |
| 4542 | } |
| 4543 | for (auto cb : sub_it->cbs) { |
| 4544 | auto cb_node = getCBNode(dev_data, cb); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4545 | if (cb_node) { |
| 4546 | for (auto queryEventsPair : cb_node->waitedEventsBeforeQueryReset) { |
| 4547 | for (auto event : queryEventsPair.second) { |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4548 | if (dev_data->eventMap[event].needsSignaled) { |
| 4549 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4550 | VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", |
| 4551 | "Cannot get query results on queryPool 0x%" PRIx64 |
| 4552 | " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", |
| 4553 | (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); |
| 4554 | } |
| 4555 | } |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 4556 | } |
| 4557 | } |
| 4558 | } |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4559 | sub_it++; |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4560 | queue_seq++; |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 4561 | } |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4562 | for (auto qs : other_queue_seqs) { |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4563 | skip |= VerifyQueueStateToSeq(dev_data, getQueueState(dev_data, qs.first), qs.second); |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 4564 | } |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4565 | return skip; |
| 4566 | } |
| 4567 | |
| 4568 | // When the given fence is retired, verify outstanding queue operations through the point of the fence |
| 4569 | static bool VerifyQueueStateToFence(layer_data *dev_data, VkFence fence) { |
| 4570 | auto fence_state = getFenceNode(dev_data, fence); |
| 4571 | if (VK_NULL_HANDLE != fence_state->signaler.first) { |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4572 | return VerifyQueueStateToSeq(dev_data, getQueueState(dev_data, fence_state->signaler.first), fence_state->signaler.second); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 4573 | } |
| 4574 | return false; |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 4575 | } |
Chris Forbes | 5e3bfd6 | 2016-06-24 17:04:54 +1200 | [diff] [blame] | 4576 | |
| 4577 | // TODO: nuke this completely. |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 4578 | // Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers |
| 4579 | static inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { |
| 4580 | // Pull it off of global list initially, but if we find it in any other queue list, add it back in |
| 4581 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); |
| 4582 | pCB->in_use.fetch_sub(1); |
| 4583 | if (!pCB->in_use.load()) { |
| 4584 | dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); |
| 4585 | } |
| 4586 | } |
| 4587 | |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4588 | // Decrement in-use count for objects bound to command buffer |
Tobin Ehlis | ee3af20 | 2016-09-07 11:09:01 -0600 | [diff] [blame] | 4589 | static void DecrementBoundResources(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { |
Tobin Ehlis | 1dc7d5a | 2016-09-14 07:01:11 -0600 | [diff] [blame] | 4590 | BASE_NODE *base_obj = nullptr; |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4591 | for (auto obj : cb_node->object_bindings) { |
Tobin Ehlis | 83e14ca | 2016-09-14 11:21:55 -0600 | [diff] [blame] | 4592 | base_obj = GetStateStructPtrFromObject(dev_data, obj); |
Tobin Ehlis | 1dc7d5a | 2016-09-14 07:01:11 -0600 | [diff] [blame] | 4593 | if (base_obj) { |
| 4594 | base_obj->in_use.fetch_sub(1); |
| 4595 | } |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4596 | } |
| 4597 | } |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4598 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4599 | static void RetireWorkOnQueue(layer_data *dev_data, QUEUE_STATE *pQueue, uint64_t seq) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4600 | std::unordered_map<VkQueue, uint64_t> otherQueueSeqs; |
| 4601 | |
| 4602 | // Roll this queue forward, one submission at a time. |
| 4603 | while (pQueue->seq < seq) { |
| 4604 | auto & submission = pQueue->submissions.front(); |
| 4605 | |
| 4606 | for (auto & wait : submission.waitSemaphores) { |
| 4607 | auto pSemaphore = getSemaphoreNode(dev_data, wait.semaphore); |
Mark Lobodzinski | c3343ae | 2016-11-11 15:27:12 -0700 | [diff] [blame] | 4608 | if (pSemaphore) { |
| 4609 | pSemaphore->in_use.fetch_sub(1); |
| 4610 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4611 | auto & lastSeq = otherQueueSeqs[wait.queue]; |
| 4612 | lastSeq = std::max(lastSeq, wait.seq); |
| 4613 | } |
| 4614 | |
| 4615 | for (auto & semaphore : submission.signalSemaphores) { |
| 4616 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
Mark Lobodzinski | c3343ae | 2016-11-11 15:27:12 -0700 | [diff] [blame] | 4617 | if (pSemaphore) { |
| 4618 | pSemaphore->in_use.fetch_sub(1); |
| 4619 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4620 | } |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 4621 | |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4622 | for (auto cb : submission.cbs) { |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4623 | auto cb_node = getCBNode(dev_data, cb); |
Mark Lobodzinski | c3343ae | 2016-11-11 15:27:12 -0700 | [diff] [blame] | 4624 | if (!cb_node) { |
| 4625 | continue; |
| 4626 | } |
Tobin Ehlis | 9252c2b | 2016-07-21 14:40:22 -0600 | [diff] [blame] | 4627 | // First perform decrement on general case bound objects |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4628 | DecrementBoundResources(dev_data, cb_node); |
| 4629 | for (auto drawDataElement : cb_node->drawData) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4630 | for (auto buffer : drawDataElement.buffers) { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 4631 | auto buffer_state = getBufferState(dev_data, buffer); |
| 4632 | if (buffer_state) { |
| 4633 | buffer_state->in_use.fetch_sub(1); |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4634 | } |
| 4635 | } |
| 4636 | } |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4637 | for (auto event : cb_node->writeEventsBeforeWait) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4638 | auto eventNode = dev_data->eventMap.find(event); |
| 4639 | if (eventNode != dev_data->eventMap.end()) { |
| 4640 | eventNode->second.write_in_use--; |
| 4641 | } |
| 4642 | } |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4643 | for (auto queryStatePair : cb_node->queryToStateMap) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4644 | dev_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; |
| 4645 | } |
Tobin Ehlis | 77416de | 2016-07-21 17:51:22 -0600 | [diff] [blame] | 4646 | for (auto eventStagePair : cb_node->eventToStageMap) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4647 | dev_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; |
| 4648 | } |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 4649 | |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4650 | removeInFlightCmdBuffer(dev_data, cb); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4651 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4652 | |
| 4653 | auto pFence = getFenceNode(dev_data, submission.fence); |
| 4654 | if (pFence) { |
| 4655 | pFence->state = FENCE_RETIRED; |
| 4656 | } |
| 4657 | |
| 4658 | pQueue->submissions.pop_front(); |
| 4659 | pQueue->seq++; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4660 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4661 | |
| 4662 | // Roll other queues forward to the highest seq we saw a wait for |
| 4663 | for (auto qs : otherQueueSeqs) { |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4664 | RetireWorkOnQueue(dev_data, getQueueState(dev_data, qs.first), qs.second); |
Michael Lentine | b48e141 | 2016-04-29 18:37:32 -0500 | [diff] [blame] | 4665 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4666 | } |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4667 | |
| 4668 | |
| 4669 | // Submit a fence to a queue, delimiting previous fences and previous untracked |
| 4670 | // work by it. |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4671 | static void SubmitFence(QUEUE_STATE *pQueue, FENCE_NODE *pFence, uint64_t submitCount) { |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 4672 | pFence->state = FENCE_INFLIGHT; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4673 | pFence->signaler.first = pQueue->queue; |
| 4674 | pFence->signaler.second = pQueue->seq + pQueue->submissions.size() + submitCount; |
Michael Lentine | febf20b | 2016-04-20 23:01:26 -0500 | [diff] [blame] | 4675 | } |
| 4676 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 4677 | static bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4678 | bool skip_call = false; |
| 4679 | if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && |
| 4680 | !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4681 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 4682 | 0, __LINE__, VALIDATION_ERROR_00133, "DS", |
| 4683 | "Command Buffer 0x%p is already in use and is not marked for simultaneous use. %s", pCB->commandBuffer, |
| 4684 | validation_error_map[VALIDATION_ERROR_00133]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4685 | } |
| 4686 | return skip_call; |
| 4687 | } |
| 4688 | |
Tobin Ehlis | f7cf915 | 2016-09-27 13:10:33 -0600 | [diff] [blame] | 4689 | static bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const char *call_source) { |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4690 | bool skip = false; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 4691 | if (dev_data->instance_data->disabled.command_buffer_state) |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4692 | return skip; |
Tobin Ehlis | e5184af | 2016-04-14 15:44:20 -0600 | [diff] [blame] | 4693 | // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once |
| 4694 | if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4695 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 4696 | __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4697 | "Commandbuffer 0x%p was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4698 | "set, but has been submitted 0x%" PRIxLEAST64 " times.", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4699 | pCB->commandBuffer, pCB->submitCount); |
Tobin Ehlis | e5184af | 2016-04-14 15:44:20 -0600 | [diff] [blame] | 4700 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4701 | // Validate that cmd buffers have been updated |
| 4702 | if (CB_RECORDED != pCB->state) { |
| 4703 | if (CB_INVALID == pCB->state) { |
| 4704 | // Inform app of reason CB invalid |
Tobin Ehlis | 2556f5b | 2016-06-24 17:22:16 -0600 | [diff] [blame] | 4705 | for (auto obj : pCB->broken_bindings) { |
| 4706 | const char *type_str = object_type_to_string(obj.type); |
| 4707 | // Descriptor sets are a special case that can be either destroyed or updated to invalidated a CB |
| 4708 | const char *cause_str = |
| 4709 | (obj.type == VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT) ? "destroyed or updated" : "destroyed"; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4710 | |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4711 | skip |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4712 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 4713 | reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4714 | "You are submitting command buffer 0x%p that is invalid because bound %s 0x%" PRIxLEAST64 " was %s.", |
| 4715 | pCB->commandBuffer, type_str, obj.handle, cause_str); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4716 | } |
| 4717 | } else { // Flag error for using CB w/o vkEndCommandBuffer() called |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4718 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 4719 | (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4720 | "You must call vkEndCommandBuffer() on command buffer 0x%p before this call to %s!", pCB->commandBuffer, |
| 4721 | call_source); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4722 | } |
| 4723 | } |
Tobin Ehlis | a003ce8 | 2016-09-27 17:42:58 -0600 | [diff] [blame] | 4724 | return skip; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4725 | } |
| 4726 | |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 4727 | // Validate that queueFamilyIndices of primary command buffers match this queue |
| 4728 | // Secondary command buffers were previously validated in vkCmdExecuteCommands(). |
| 4729 | static bool validateQueueFamilyIndices(layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkQueue queue) { |
| 4730 | bool skip_call = false; |
| 4731 | auto pPool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4732 | auto queue_state = getQueueState(dev_data, queue); |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 4733 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4734 | if (pPool && queue_state && (pPool->queueFamilyIndex != queue_state->queueFamilyIndex)) { |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 4735 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 4736 | reinterpret_cast<uint64_t>(pCB->commandBuffer), __LINE__, VALIDATION_ERROR_00139, "DS", |
| 4737 | "vkQueueSubmit: Primary command buffer 0x%p created in queue family %d is being submitted on queue " |
| 4738 | "0x%p from queue family %d. %s", |
| 4739 | pCB->commandBuffer, pPool->queueFamilyIndex, queue, queue_state->queueFamilyIndex, |
| 4740 | validation_error_map[VALIDATION_ERROR_00139]); |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 4741 | } |
| 4742 | |
| 4743 | return skip_call; |
| 4744 | } |
| 4745 | |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4746 | static bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4747 | // Track in-use for resources off of primary and any secondary CBs |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4748 | bool skip_call = false; |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4749 | |
| 4750 | // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing |
| 4751 | // on device |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4752 | skip_call |= validateCommandBufferSimultaneousUse(dev_data, pCB); |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4753 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4754 | skip_call |= validateAndIncrementResources(dev_data, pCB); |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4755 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4756 | if (!pCB->secondaryCommandBuffers.empty()) { |
| 4757 | for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4758 | GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4759 | skip_call |= validateAndIncrementResources(dev_data, pSubCB); |
Tobin Ehlis | 1857d61 | 2016-05-09 13:22:50 -0600 | [diff] [blame] | 4760 | if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && |
| 4761 | !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 4762 | log_msg( |
| 4763 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 4764 | __LINE__, VALIDATION_ERROR_00135, "DS", |
| 4765 | "Commandbuffer 0x%p was submitted with secondary buffer 0x%p but that buffer has subsequently been bound to " |
| 4766 | "primary cmd buffer 0x%p and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set. %s", |
| 4767 | pCB->commandBuffer, secondaryCmdBuffer, pSubCB->primaryCommandBuffer, |
| 4768 | validation_error_map[VALIDATION_ERROR_00135]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4769 | } |
| 4770 | } |
| 4771 | } |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4772 | |
Tobin Ehlis | f7cf915 | 2016-09-27 13:10:33 -0600 | [diff] [blame] | 4773 | skip_call |= validateCommandBufferState(dev_data, pCB, "vkQueueSubmit()"); |
Chris Forbes | 7775391 | 2016-06-23 10:36:09 +1200 | [diff] [blame] | 4774 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4775 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4776 | } |
| 4777 | |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4778 | static bool |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4779 | ValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4780 | { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4781 | bool skip_call = false; |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4782 | |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4783 | if (pFence) { |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 4784 | if (pFence->state == FENCE_INFLIGHT) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 4785 | // TODO: opportunities for VALIDATION_ERROR_00127, VALIDATION_ERROR_01647, VALIDATION_ERROR_01953 |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4786 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| 4787 | (uint64_t)(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", |
| 4788 | "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(pFence->fence)); |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 4789 | } |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4790 | |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 4791 | else if (pFence->state == FENCE_RETIRED) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 4792 | // TODO: opportunities for VALIDATION_ERROR_00126, VALIDATION_ERROR_01646, VALIDATION_ERROR_01953 |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4793 | skip_call |= |
| 4794 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| 4795 | reinterpret_cast<uint64_t &>(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", |
| 4796 | "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", |
| 4797 | reinterpret_cast<uint64_t &>(pFence->fence)); |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 4798 | } |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4799 | } |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4800 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4801 | return skip_call; |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4802 | } |
| 4803 | |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4804 | |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4805 | VKAPI_ATTR VkResult VKAPI_CALL |
| 4806 | QueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4807 | bool skip_call = false; |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4808 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
| 4809 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| 4810 | std::unique_lock<std::mutex> lock(global_lock); |
| 4811 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 4812 | auto pQueue = getQueueState(dev_data, queue); |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4813 | auto pFence = getFenceNode(dev_data, fence); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4814 | skip_call |= ValidateFenceForSubmit(dev_data, pFence); |
Chris Forbes | fed03c9 | 2016-06-10 10:06:42 +1200 | [diff] [blame] | 4815 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4816 | if (skip_call) { |
Chris Forbes | 40028e2 | 2016-06-13 09:59:34 +1200 | [diff] [blame] | 4817 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 4818 | } |
| 4819 | |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4820 | // Mark the fence in-use. |
| 4821 | if (pFence) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4822 | SubmitFence(pQueue, pFence, std::max(1u, submitCount)); |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4823 | } |
| 4824 | |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4825 | // Now verify each individual submit |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4826 | for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { |
| 4827 | const VkSubmitInfo *submit = &pSubmits[submit_idx]; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4828 | vector<SEMAPHORE_WAIT> semaphore_waits; |
| 4829 | vector<VkSemaphore> semaphore_signals; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4830 | for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { |
Tobin Ehlis | b093da8 | 2017-01-19 12:05:27 -0700 | [diff] [blame] | 4831 | skip_call |= ValidateStageMaskGsTsEnables(dev_data, submit->pWaitDstStageMask[i], "vkQueueSubmit()", |
| 4832 | VALIDATION_ERROR_00142, VALIDATION_ERROR_00143); |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4833 | VkSemaphore semaphore = submit->pWaitSemaphores[i]; |
| 4834 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4835 | if (pSemaphore) { |
| 4836 | if (pSemaphore->signaled) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4837 | if (pSemaphore->signaler.first != VK_NULL_HANDLE) { |
| 4838 | semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); |
| 4839 | pSemaphore->in_use.fetch_add(1); |
| 4840 | } |
| 4841 | pSemaphore->signaler.first = VK_NULL_HANDLE; |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4842 | pSemaphore->signaled = false; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4843 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4844 | skip_call |= |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4845 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| 4846 | reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4847 | "Queue 0x%p is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", queue, |
| 4848 | reinterpret_cast<const uint64_t &>(semaphore)); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4849 | } |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4850 | } |
| 4851 | } |
| 4852 | for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4853 | VkSemaphore semaphore = submit->pSignalSemaphores[i]; |
| 4854 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
| 4855 | if (pSemaphore) { |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4856 | if (pSemaphore->signaled) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4857 | skip_call |= |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4858 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| 4859 | reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4860 | "Queue 0x%p is signaling semaphore 0x%" PRIx64 |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 4861 | " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 4862 | queue, reinterpret_cast<const uint64_t &>(semaphore), |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4863 | reinterpret_cast<uint64_t &>(pSemaphore->signaler.first)); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4864 | } else { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4865 | pSemaphore->signaler.first = queue; |
| 4866 | pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 4867 | pSemaphore->signaled = true; |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4868 | pSemaphore->in_use.fetch_add(1); |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4869 | semaphore_signals.push_back(semaphore); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4870 | } |
| 4871 | } |
| 4872 | } |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4873 | |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4874 | std::vector<VkCommandBuffer> cbs; |
| 4875 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4876 | for (uint32_t i = 0; i < submit->commandBufferCount; i++) { |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4877 | auto cb_node = getCBNode(dev_data, submit->pCommandBuffers[i]); |
| 4878 | skip_call |= ValidateCmdBufImageLayouts(dev_data, cb_node); |
| 4879 | if (cb_node) { |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4880 | cbs.push_back(submit->pCommandBuffers[i]); |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4881 | for (auto secondaryCmdBuffer : cb_node->secondaryCommandBuffers) { |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4882 | cbs.push_back(secondaryCmdBuffer); |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 4883 | } |
| 4884 | |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4885 | cb_node->submitCount++; // increment submit count |
| 4886 | skip_call |= validatePrimaryCommandBufferState(dev_data, cb_node); |
| 4887 | skip_call |= validateQueueFamilyIndices(dev_data, cb_node, queue); |
Tobin Ehlis | 545fae3 | 2016-09-06 20:37:01 -0600 | [diff] [blame] | 4888 | // Potential early exit here as bad object state may crash in delayed function calls |
| 4889 | if (skip_call) |
| 4890 | return result; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 4891 | // Call submit-time functions to validate/update state |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4892 | for (auto &function : cb_node->validate_functions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4893 | skip_call |= function(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4894 | } |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4895 | for (auto &function : cb_node->eventUpdates) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4896 | skip_call |= function(queue); |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 4897 | } |
Tobin Ehlis | c0d3680 | 2016-10-20 10:09:44 -0600 | [diff] [blame] | 4898 | for (auto &function : cb_node->queryUpdates) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4899 | skip_call |= function(queue); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 4900 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4901 | } |
| 4902 | } |
Chris Forbes | c7d3c78 | 2016-06-22 11:57:17 +1200 | [diff] [blame] | 4903 | |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4904 | pQueue->submissions.emplace_back(cbs, semaphore_waits, semaphore_signals, |
| 4905 | submit_idx == submitCount - 1 ? fence : VK_NULL_HANDLE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4906 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 4907 | |
| 4908 | if (pFence && !submitCount) { |
| 4909 | // If no submissions, but just dropping a fence on the end of the queue, |
| 4910 | // record an empty submission with just the fence, so we can determine |
| 4911 | // its completion. |
| 4912 | pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), |
| 4913 | std::vector<SEMAPHORE_WAIT>(), |
| 4914 | std::vector<VkSemaphore>(), |
| 4915 | fence); |
| 4916 | } |
| 4917 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 4918 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 4919 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 4920 | result = dev_data->dispatch_table.QueueSubmit(queue, submitCount, pSubmits, fence); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4921 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4922 | return result; |
| 4923 | } |
| 4924 | |
Karl Schultz | 8e3bccf | 2016-11-11 16:09:47 -0700 | [diff] [blame] | 4925 | static bool PreCallValidateAllocateMemory(layer_data *dev_data) { |
| 4926 | bool skip = false; |
| 4927 | if (dev_data->memObjMap.size() >= dev_data->phys_dev_properties.properties.limits.maxMemoryAllocationCount) { |
| 4928 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| 4929 | reinterpret_cast<const uint64_t &>(dev_data->device), __LINE__, VALIDATION_ERROR_00611, "MEM", |
| 4930 | "Number of currently valid memory objects is not less than the maximum allowed (%u). %s", |
| 4931 | dev_data->phys_dev_properties.properties.limits.maxMemoryAllocationCount, |
| 4932 | validation_error_map[VALIDATION_ERROR_00611]); |
| 4933 | } |
| 4934 | return skip; |
| 4935 | } |
| 4936 | |
| 4937 | static void PostCallRecordAllocateMemory(layer_data *dev_data, const VkMemoryAllocateInfo *pAllocateInfo, VkDeviceMemory *pMemory) { |
| 4938 | add_mem_obj_info(dev_data, dev_data->device, *pMemory, pAllocateInfo); |
Karl Schultz | 8e3bccf | 2016-11-11 16:09:47 -0700 | [diff] [blame] | 4939 | return; |
| 4940 | } |
| 4941 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 4942 | VKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, |
| 4943 | const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { |
Karl Schultz | 8e3bccf | 2016-11-11 16:09:47 -0700 | [diff] [blame] | 4944 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| 4945 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 4946 | std::unique_lock<std::mutex> lock(global_lock); |
| 4947 | bool skip = PreCallValidateAllocateMemory(dev_data); |
| 4948 | if (!skip) { |
| 4949 | lock.unlock(); |
| 4950 | result = dev_data->dispatch_table.AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); |
| 4951 | lock.lock(); |
| 4952 | if (VK_SUCCESS == result) { |
| 4953 | PostCallRecordAllocateMemory(dev_data, pAllocateInfo, pMemory); |
| 4954 | } |
Mark Lobodzinski | 8fbf571 | 2016-11-14 08:18:09 -0700 | [diff] [blame] | 4955 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4956 | return result; |
| 4957 | } |
| 4958 | |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4959 | // For given obj node, if it is use, flag a validation error and return callback result, else return false |
| 4960 | bool ValidateObjectNotInUse(const layer_data *dev_data, BASE_NODE *obj_node, VK_OBJECT obj_struct, |
| 4961 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| 4962 | if (dev_data->instance_data->disabled.object_in_use) |
| 4963 | return false; |
| 4964 | bool skip = false; |
| 4965 | if (obj_node->in_use.load()) { |
| 4966 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_struct.type, obj_struct.handle, __LINE__, |
| 4967 | error_code, "DS", "Cannot delete %s 0x%" PRIx64 " that is currently in use by a command buffer. %s", |
| 4968 | object_type_to_string(obj_struct.type), obj_struct.handle, validation_error_map[error_code]); |
| 4969 | } |
| 4970 | return skip; |
| 4971 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4972 | |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4973 | static bool PreCallValidateFreeMemory(layer_data *dev_data, VkDeviceMemory mem, DEVICE_MEM_INFO **mem_info, VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 4974 | *mem_info = getMemObjInfo(dev_data, mem); |
| 4975 | *obj_struct = {reinterpret_cast<uint64_t &>(mem), VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT}; |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4976 | if (dev_data->instance_data->disabled.free_memory) |
| 4977 | return false; |
| 4978 | bool skip = false; |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4979 | if (*mem_info) { |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4980 | skip |= ValidateObjectNotInUse(dev_data, *mem_info, *obj_struct, VALIDATION_ERROR_00620); |
| 4981 | } |
| 4982 | return skip; |
| 4983 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 4984 | |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4985 | static void PostCallRecordFreeMemory(layer_data *dev_data, VkDeviceMemory mem, DEVICE_MEM_INFO *mem_info, VK_OBJECT obj_struct) { |
| 4986 | // Clear mem binding for any bound objects |
Tobin Ehlis | 5b38d77 | 2016-10-25 22:00:47 -0600 | [diff] [blame] | 4987 | for (auto obj : mem_info->obj_bindings) { |
| 4988 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, MEMTRACK_FREED_MEM_REF, |
| 4989 | "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, obj.handle, |
| 4990 | (uint64_t)mem_info->mem); |
| 4991 | switch (obj.type) { |
| 4992 | case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { |
| 4993 | auto image_state = getImageState(dev_data, reinterpret_cast<VkImage &>(obj.handle)); |
| 4994 | assert(image_state); // Any destroyed images should already be removed from bindings |
| 4995 | image_state->binding.mem = MEMORY_UNBOUND; |
| 4996 | break; |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 4997 | } |
Tobin Ehlis | 5b38d77 | 2016-10-25 22:00:47 -0600 | [diff] [blame] | 4998 | case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 4999 | auto buffer_state = getBufferState(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); |
| 5000 | assert(buffer_state); // Any destroyed buffers should already be removed from bindings |
| 5001 | buffer_state->binding.mem = MEMORY_UNBOUND; |
Tobin Ehlis | 5b38d77 | 2016-10-25 22:00:47 -0600 | [diff] [blame] | 5002 | break; |
| 5003 | } |
| 5004 | default: |
| 5005 | // Should only have buffer or image objects bound to memory |
| 5006 | assert(0); |
| 5007 | } |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 5008 | } |
| 5009 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 5010 | invalidateCommandBuffers(dev_data, mem_info->cb_bindings, obj_struct); |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 5011 | dev_data->memObjMap.erase(mem); |
| 5012 | } |
| 5013 | |
| 5014 | VKAPI_ATTR void VKAPI_CALL FreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { |
| 5015 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5016 | DEVICE_MEM_INFO *mem_info = nullptr; |
| 5017 | VK_OBJECT obj_struct; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5018 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4947f1d | 2016-10-20 11:02:03 -0600 | [diff] [blame] | 5019 | bool skip = PreCallValidateFreeMemory(dev_data, mem, &mem_info, &obj_struct); |
| 5020 | if (!skip) { |
| 5021 | lock.unlock(); |
| 5022 | dev_data->dispatch_table.FreeMemory(device, mem, pAllocator); |
| 5023 | lock.lock(); |
| 5024 | PostCallRecordFreeMemory(dev_data, mem, mem_info, obj_struct); |
Mark Mueller | f377ffb | 2016-07-11 15:03:44 -0600 | [diff] [blame] | 5025 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5026 | } |
| 5027 | |
Tobin Ehlis | b495d5f | 2016-08-04 09:33:02 -0600 | [diff] [blame] | 5028 | // Validate that given Map memory range is valid. This means that the memory should not already be mapped, |
| 5029 | // and that the size of the map range should be: |
| 5030 | // 1. Not zero |
| 5031 | // 2. Within the size of the memory allocation |
| 5032 | static bool ValidateMapMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5033 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5034 | |
| 5035 | if (size == 0) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5036 | skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 5037 | (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", |
| 5038 | "VkMapMemory: Attempting to map memory range of size zero"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5039 | } |
| 5040 | |
| 5041 | auto mem_element = my_data->memObjMap.find(mem); |
| 5042 | if (mem_element != my_data->memObjMap.end()) { |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 5043 | auto mem_info = mem_element->second.get(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5044 | // It is an application error to call VkMapMemory on an object that is already mapped |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5045 | if (mem_info->mem_range.size != 0) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5046 | skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 5047 | (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", |
| 5048 | "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5049 | } |
| 5050 | |
| 5051 | // Validate that offset + size is within object's allocationSize |
| 5052 | if (size == VK_WHOLE_SIZE) { |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5053 | if (offset >= mem_info->alloc_info.allocationSize) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5054 | skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 5055 | VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, |
| 5056 | "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 |
| 5057 | " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5058 | offset, mem_info->alloc_info.allocationSize, mem_info->alloc_info.allocationSize); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5059 | } |
| 5060 | } else { |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5061 | if ((offset + size) > mem_info->alloc_info.allocationSize) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5062 | skip_call = log_msg( |
| 5063 | my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 5064 | (uint64_t)mem, __LINE__, VALIDATION_ERROR_00628, "MEM", |
| 5065 | "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64 ". %s", offset, |
| 5066 | size + offset, mem_info->alloc_info.allocationSize, validation_error_map[VALIDATION_ERROR_00628]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5067 | } |
| 5068 | } |
| 5069 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5070 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5071 | } |
| 5072 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 5073 | static void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 5074 | auto mem_info = getMemObjInfo(my_data, mem); |
| 5075 | if (mem_info) { |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5076 | mem_info->mem_range.offset = offset; |
| 5077 | mem_info->mem_range.size = size; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5078 | } |
| 5079 | } |
| 5080 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 5081 | static bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5082 | bool skip_call = false; |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 5083 | auto mem_info = getMemObjInfo(my_data, mem); |
| 5084 | if (mem_info) { |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5085 | if (!mem_info->mem_range.size) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5086 | // Valid Usage: memory must currently be mapped |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5087 | skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5088 | (uint64_t)mem, __LINE__, VALIDATION_ERROR_00649, "MEM", |
| 5089 | "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64 ". %s", (uint64_t)mem, |
| 5090 | validation_error_map[VALIDATION_ERROR_00649]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5091 | } |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5092 | mem_info->mem_range.size = 0; |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5093 | if (mem_info->shadow_copy) { |
| 5094 | free(mem_info->shadow_copy_base); |
| 5095 | mem_info->shadow_copy_base = 0; |
| 5096 | mem_info->shadow_copy = 0; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5097 | } |
| 5098 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5099 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5100 | } |
| 5101 | |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5102 | // Guard value for pad data |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5103 | static char NoncoherentMemoryFillValue = 0xb; |
| 5104 | |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5105 | static void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, |
| 5106 | void **ppData) { |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 5107 | auto mem_info = getMemObjInfo(dev_data, mem); |
| 5108 | if (mem_info) { |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5109 | mem_info->p_driver_data = *ppData; |
| 5110 | uint32_t index = mem_info->alloc_info.memoryTypeIndex; |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 5111 | if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5112 | mem_info->shadow_copy = 0; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5113 | } else { |
| 5114 | if (size == VK_WHOLE_SIZE) { |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5115 | size = mem_info->alloc_info.allocationSize - offset; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5116 | } |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5117 | mem_info->shadow_pad_size = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; |
| 5118 | assert(vk_safe_modulo(mem_info->shadow_pad_size, |
| 5119 | dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment) == 0); |
| 5120 | // Ensure start of mapped region reflects hardware alignment constraints |
| 5121 | uint64_t map_alignment = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; |
| 5122 | |
| 5123 | // From spec: (ppData - offset) must be aligned to at least limits::minMemoryMapAlignment. |
| 5124 | uint64_t start_offset = offset % map_alignment; |
| 5125 | // Data passed to driver will be wrapped by a guardband of data to detect over- or under-writes. |
Mark Lobodzinski | 4dc768c | 2016-10-03 16:01:12 -0600 | [diff] [blame] | 5126 | mem_info->shadow_copy_base = malloc(static_cast<size_t>(2 * mem_info->shadow_pad_size + size + map_alignment + start_offset)); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5127 | |
| 5128 | mem_info->shadow_copy = |
| 5129 | reinterpret_cast<char *>((reinterpret_cast<uintptr_t>(mem_info->shadow_copy_base) + map_alignment) & |
| 5130 | ~(map_alignment - 1)) + start_offset; |
| 5131 | assert(vk_safe_modulo(reinterpret_cast<uintptr_t>(mem_info->shadow_copy) + mem_info->shadow_pad_size - start_offset, |
| 5132 | map_alignment) == 0); |
| 5133 | |
Mark Lobodzinski | 4dc768c | 2016-10-03 16:01:12 -0600 | [diff] [blame] | 5134 | memset(mem_info->shadow_copy, NoncoherentMemoryFillValue, static_cast<size_t>(2 * mem_info->shadow_pad_size + size)); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5135 | *ppData = static_cast<char *>(mem_info->shadow_copy) + mem_info->shadow_pad_size; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5136 | } |
| 5137 | } |
| 5138 | } |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 5139 | |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 5140 | // Verify that state for fence being waited on is appropriate. That is, |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 5141 | // a fence being waited on should not already be signaled and |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 5142 | // it should have been submitted on a queue or during acquire next image |
Chris Forbes | 5141e92 | 2016-06-15 13:10:28 +1200 | [diff] [blame] | 5143 | static inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5144 | bool skip_call = false; |
Chris Forbes | 53a1736 | 2016-06-15 13:03:31 +1200 | [diff] [blame] | 5145 | |
Chris Forbes | 5141e92 | 2016-06-15 13:10:28 +1200 | [diff] [blame] | 5146 | auto pFence = getFenceNode(dev_data, fence); |
Chris Forbes | 53a1736 | 2016-06-15 13:03:31 +1200 | [diff] [blame] | 5147 | if (pFence) { |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 5148 | if (pFence->state == FENCE_UNSIGNALED) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5149 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
| 5150 | reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", |
| 5151 | "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " |
| 5152 | "acquire next image.", |
| 5153 | apiCall, reinterpret_cast<uint64_t &>(fence)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5154 | } |
| 5155 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5156 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5157 | } |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 5158 | |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5159 | static void RetireFence(layer_data *dev_data, VkFence fence) { |
Chris Forbes | 61e8ff5 | 2016-09-21 11:18:30 +1200 | [diff] [blame] | 5160 | auto pFence = getFenceNode(dev_data, fence); |
| 5161 | if (pFence->signaler.first != VK_NULL_HANDLE) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 5162 | // Fence signaller is a queue -- use this as proof that prior operations on that queue have completed. |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 5163 | RetireWorkOnQueue(dev_data, getQueueState(dev_data, pFence->signaler.first), pFence->signaler.second); |
Chris Forbes | 61e8ff5 | 2016-09-21 11:18:30 +1200 | [diff] [blame] | 5164 | } |
Chris Forbes | 2238406 | 2016-09-21 13:36:19 +1200 | [diff] [blame] | 5165 | else { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 5166 | // Fence signaller is the WSI. We're not tracking what the WSI op actually /was/ in CV yet, but we need to mark |
| 5167 | // the fence as retired. |
Chris Forbes | 2238406 | 2016-09-21 13:36:19 +1200 | [diff] [blame] | 5168 | pFence->state = FENCE_RETIRED; |
Chris Forbes | 2238406 | 2016-09-21 13:36:19 +1200 | [diff] [blame] | 5169 | } |
Chris Forbes | 61e8ff5 | 2016-09-21 11:18:30 +1200 | [diff] [blame] | 5170 | } |
| 5171 | |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5172 | static bool PreCallValidateWaitForFences(layer_data *dev_data, uint32_t fence_count, const VkFence *fences) { |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5173 | if (dev_data->instance_data->disabled.wait_for_fences) |
| 5174 | return false; |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5175 | bool skip = false; |
| 5176 | for (uint32_t i = 0; i < fence_count; i++) { |
| 5177 | skip |= verifyWaitFenceState(dev_data, fences[i], "vkWaitForFences"); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5178 | skip |= VerifyQueueStateToFence(dev_data, fences[i]); |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5179 | } |
| 5180 | return skip; |
| 5181 | } |
| 5182 | |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5183 | static void PostCallRecordWaitForFences(layer_data *dev_data, uint32_t fence_count, const VkFence *fences, VkBool32 wait_all) { |
| 5184 | // When we know that all fences are complete we can clean/remove their CBs |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5185 | if ((VK_TRUE == wait_all) || (1 == fence_count)) { |
| 5186 | for (uint32_t i = 0; i < fence_count; i++) { |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5187 | RetireFence(dev_data, fences[i]); |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5188 | } |
| 5189 | } |
| 5190 | // NOTE : Alternate case not handled here is when some fences have completed. In |
| 5191 | // this case for app to guarantee which fences completed it will have to call |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5192 | // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5193 | } |
| 5194 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5195 | VKAPI_ATTR VkResult VKAPI_CALL |
| 5196 | WaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5197 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5198 | // Verify fence status of submitted fences |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5199 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5200 | bool skip = PreCallValidateWaitForFences(dev_data, fenceCount, pFences); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5201 | lock.unlock(); |
Tobin Ehlis | c1b5cbb | 2016-12-06 07:38:48 -0700 | [diff] [blame] | 5202 | if (skip) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5203 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 5204 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5205 | VkResult result = dev_data->dispatch_table.WaitForFences(device, fenceCount, pFences, waitAll, timeout); |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 5206 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5207 | if (result == VK_SUCCESS) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5208 | lock.lock(); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5209 | PostCallRecordWaitForFences(dev_data, fenceCount, pFences, waitAll); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5210 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5211 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5212 | return result; |
| 5213 | } |
| 5214 | |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5215 | static bool PreCallValidateGetFenceStatus(layer_data *dev_data, VkFence fence) { |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5216 | if (dev_data->instance_data->disabled.get_fence_state) |
| 5217 | return false; |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5218 | return verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); |
| 5219 | } |
| 5220 | |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5221 | static void PostCallRecordGetFenceStatus(layer_data *dev_data, VkFence fence) { RetireFence(dev_data, fence); } |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5222 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5223 | VKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5224 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5225 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5226 | bool skip = PreCallValidateGetFenceStatus(dev_data, fence); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5227 | lock.unlock(); |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5228 | if (skip) |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5229 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 5230 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5231 | VkResult result = dev_data->dispatch_table.GetFenceStatus(device, fence); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5232 | if (result == VK_SUCCESS) { |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5233 | lock.lock(); |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5234 | PostCallRecordGetFenceStatus(dev_data, fence); |
Tobin Ehlis | 2ec4bf8 | 2016-12-06 08:26:05 -0700 | [diff] [blame] | 5235 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5236 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5237 | return result; |
| 5238 | } |
| 5239 | |
Tobin Ehlis | 75fcac7 | 2016-12-15 11:34:33 -0700 | [diff] [blame] | 5240 | static void PostCallRecordGetDeviceQueue(layer_data *dev_data, uint32_t q_family_index, VkQueue queue) { |
| 5241 | // Add queue to tracking set only if it is new |
| 5242 | auto result = dev_data->queues.emplace(queue); |
| 5243 | if (result.second == true) { |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 5244 | QUEUE_STATE *queue_state = &dev_data->queueMap[queue]; |
Tobin Ehlis | 75fcac7 | 2016-12-15 11:34:33 -0700 | [diff] [blame] | 5245 | queue_state->queue = queue; |
| 5246 | queue_state->queueFamilyIndex = q_family_index; |
| 5247 | queue_state->seq = 0; |
| 5248 | } |
| 5249 | } |
| 5250 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5251 | VKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, |
Mark Lobodzinski | 600e93d | 2016-03-29 09:49:15 -0600 | [diff] [blame] | 5252 | VkQueue *pQueue) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5253 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5254 | dev_data->dispatch_table.GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5255 | std::lock_guard<std::mutex> lock(global_lock); |
Mark Lobodzinski | 600e93d | 2016-03-29 09:49:15 -0600 | [diff] [blame] | 5256 | |
Tobin Ehlis | 75fcac7 | 2016-12-15 11:34:33 -0700 | [diff] [blame] | 5257 | PostCallRecordGetDeviceQueue(dev_data, queueFamilyIndex, *pQueue); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5258 | } |
| 5259 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 5260 | static bool PreCallValidateQueueWaitIdle(layer_data *dev_data, VkQueue queue, QUEUE_STATE **queue_state) { |
| 5261 | *queue_state = getQueueState(dev_data, queue); |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5262 | if (dev_data->instance_data->disabled.queue_wait_idle) |
| 5263 | return false; |
| 5264 | return VerifyQueueStateToSeq(dev_data, *queue_state, (*queue_state)->seq + (*queue_state)->submissions.size()); |
Tobin Ehlis | 4d8e6a4 | 2016-12-06 13:20:09 -0700 | [diff] [blame] | 5265 | } |
| 5266 | |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 5267 | static void PostCallRecordQueueWaitIdle(layer_data *dev_data, QUEUE_STATE *queue_state) { |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5268 | RetireWorkOnQueue(dev_data, queue_state, queue_state->seq + queue_state->submissions.size()); |
Tobin Ehlis | 4d8e6a4 | 2016-12-06 13:20:09 -0700 | [diff] [blame] | 5269 | } |
| 5270 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5271 | VKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5272 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 5273 | QUEUE_STATE *queue_state = nullptr; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 5274 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4d8e6a4 | 2016-12-06 13:20:09 -0700 | [diff] [blame] | 5275 | bool skip = PreCallValidateQueueWaitIdle(dev_data, queue, &queue_state); |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 5276 | lock.unlock(); |
Tobin Ehlis | cd8e8c8 | 2016-12-07 11:20:02 -0700 | [diff] [blame] | 5277 | if (skip) |
| 5278 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5279 | VkResult result = dev_data->dispatch_table.QueueWaitIdle(queue); |
Tobin Ehlis | 4d8e6a4 | 2016-12-06 13:20:09 -0700 | [diff] [blame] | 5280 | if (VK_SUCCESS == result) { |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5281 | lock.lock(); |
| 5282 | PostCallRecordQueueWaitIdle(dev_data, queue_state); |
| 5283 | lock.unlock(); |
Tobin Ehlis | 4d8e6a4 | 2016-12-06 13:20:09 -0700 | [diff] [blame] | 5284 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5285 | return result; |
| 5286 | } |
| 5287 | |
Tobin Ehlis | 08aacd9 | 2016-12-06 13:08:18 -0700 | [diff] [blame] | 5288 | static bool PreCallValidateDeviceWaitIdle(layer_data *dev_data) { |
Tobin Ehlis | 5161de3 | 2016-12-06 14:47:52 -0700 | [diff] [blame] | 5289 | if (dev_data->instance_data->disabled.device_wait_idle) |
| 5290 | return false; |
Tobin Ehlis | 08aacd9 | 2016-12-06 13:08:18 -0700 | [diff] [blame] | 5291 | bool skip = false; |
| 5292 | for (auto &queue : dev_data->queueMap) { |
| 5293 | skip |= VerifyQueueStateToSeq(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); |
| 5294 | } |
| 5295 | return skip; |
| 5296 | } |
| 5297 | |
| 5298 | static void PostCallRecordDeviceWaitIdle(layer_data *dev_data) { |
| 5299 | for (auto &queue : dev_data->queueMap) { |
Tobin Ehlis | 829abd0 | 2016-12-06 12:53:43 -0700 | [diff] [blame] | 5300 | RetireWorkOnQueue(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5301 | } |
Tobin Ehlis | 08aacd9 | 2016-12-06 13:08:18 -0700 | [diff] [blame] | 5302 | } |
| 5303 | |
| 5304 | VKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { |
| 5305 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5306 | std::unique_lock<std::mutex> lock(global_lock); |
| 5307 | bool skip = PreCallValidateDeviceWaitIdle(dev_data); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5308 | lock.unlock(); |
Tobin Ehlis | 08aacd9 | 2016-12-06 13:08:18 -0700 | [diff] [blame] | 5309 | if (skip) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5310 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5311 | VkResult result = dev_data->dispatch_table.DeviceWaitIdle(device); |
Tobin Ehlis | 08aacd9 | 2016-12-06 13:08:18 -0700 | [diff] [blame] | 5312 | if (VK_SUCCESS == result) { |
| 5313 | lock.lock(); |
| 5314 | PostCallRecordDeviceWaitIdle(dev_data); |
| 5315 | lock.unlock(); |
| 5316 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5317 | return result; |
| 5318 | } |
| 5319 | |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5320 | static bool PreCallValidateDestroyFence(layer_data *dev_data, VkFence fence, FENCE_NODE **fence_node, VK_OBJECT *obj_struct) { |
| 5321 | *fence_node = getFenceNode(dev_data, fence); |
| 5322 | *obj_struct = {reinterpret_cast<uint64_t &>(fence), VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT}; |
Tobin Ehlis | 653c522 | 2016-12-15 14:35:21 -0700 | [diff] [blame] | 5323 | if (dev_data->instance_data->disabled.destroy_fence) |
| 5324 | return false; |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5325 | bool skip = false; |
| 5326 | if (*fence_node) { |
| 5327 | if ((*fence_node)->state == FENCE_INFLIGHT) { |
| 5328 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
Tobin Ehlis | b093da8 | 2017-01-19 12:05:27 -0700 | [diff] [blame] | 5329 | (uint64_t)(fence), __LINE__, VALIDATION_ERROR_00173, "DS", "Fence 0x%" PRIx64 " is in use. %s", |
| 5330 | (uint64_t)(fence), validation_error_map[VALIDATION_ERROR_00173]); |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5331 | } |
| 5332 | } |
| 5333 | return skip; |
| 5334 | } |
| 5335 | |
| 5336 | static void PostCallRecordDestroyFence(layer_data *dev_data, VkFence fence) { dev_data->fenceMap.erase(fence); } |
| 5337 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5338 | VKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5339 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5340 | // Common data objects used pre & post call |
| 5341 | FENCE_NODE *fence_node = nullptr; |
| 5342 | VK_OBJECT obj_struct; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5343 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5344 | bool skip = PreCallValidateDestroyFence(dev_data, fence, &fence_node, &obj_struct); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 5345 | |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5346 | if (!skip) { |
| 5347 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5348 | dev_data->dispatch_table.DestroyFence(device, fence, pAllocator); |
Tobin Ehlis | af62c4a | 2016-12-15 14:18:39 -0700 | [diff] [blame] | 5349 | lock.lock(); |
| 5350 | PostCallRecordDestroyFence(dev_data, fence); |
| 5351 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5352 | } |
| 5353 | |
Tobin Ehlis | 6ed8e14 | 2016-12-15 14:32:22 -0700 | [diff] [blame] | 5354 | static bool PreCallValidateDestroySemaphore(layer_data *dev_data, VkSemaphore semaphore, SEMAPHORE_NODE **sema_node, |
| 5355 | VK_OBJECT *obj_struct) { |
| 5356 | *sema_node = getSemaphoreNode(dev_data, semaphore); |
| 5357 | *obj_struct = {reinterpret_cast<uint64_t &>(semaphore), VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT}; |
Tobin Ehlis | fdedd1e | 2016-12-15 14:36:56 -0700 | [diff] [blame] | 5358 | if (dev_data->instance_data->disabled.destroy_semaphore) |
| 5359 | return false; |
Tobin Ehlis | 6ed8e14 | 2016-12-15 14:32:22 -0700 | [diff] [blame] | 5360 | bool skip = false; |
| 5361 | if (*sema_node) { |
| 5362 | skip |= ValidateObjectNotInUse(dev_data, *sema_node, *obj_struct, VALIDATION_ERROR_00199); |
| 5363 | } |
| 5364 | return skip; |
| 5365 | } |
| 5366 | |
| 5367 | static void PostCallRecordDestroySemaphore(layer_data *dev_data, VkSemaphore sema) { dev_data->semaphoreMap.erase(sema); } |
| 5368 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5369 | VKAPI_ATTR void VKAPI_CALL |
| 5370 | DestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5371 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 6ed8e14 | 2016-12-15 14:32:22 -0700 | [diff] [blame] | 5372 | SEMAPHORE_NODE *sema_node; |
| 5373 | VK_OBJECT obj_struct; |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 5374 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 6ed8e14 | 2016-12-15 14:32:22 -0700 | [diff] [blame] | 5375 | bool skip = PreCallValidateDestroySemaphore(dev_data, semaphore, &sema_node, &obj_struct); |
Tobin Ehlis | 7d1dd14 | 2016-08-18 08:23:30 -0600 | [diff] [blame] | 5376 | if (!skip) { |
Tobin Ehlis | 7d1dd14 | 2016-08-18 08:23:30 -0600 | [diff] [blame] | 5377 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5378 | dev_data->dispatch_table.DestroySemaphore(device, semaphore, pAllocator); |
Tobin Ehlis | 6ed8e14 | 2016-12-15 14:32:22 -0700 | [diff] [blame] | 5379 | lock.lock(); |
| 5380 | PostCallRecordDestroySemaphore(dev_data, semaphore); |
Mark Mueller | 0782cea | 2016-08-24 10:42:17 -0600 | [diff] [blame] | 5381 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5382 | } |
| 5383 | |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 5384 | static bool PreCallValidateDestroyEvent(layer_data *dev_data, VkEvent event, EVENT_STATE **event_state, VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 5385 | *event_state = getEventNode(dev_data, event); |
| 5386 | *obj_struct = {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}; |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5387 | if (dev_data->instance_data->disabled.destroy_event) |
| 5388 | return false; |
| 5389 | bool skip = false; |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5390 | if (*event_state) { |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5391 | skip |= ValidateObjectNotInUse(dev_data, *event_state, *obj_struct, VALIDATION_ERROR_00213); |
| 5392 | } |
| 5393 | return skip; |
| 5394 | } |
| 5395 | |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 5396 | static void PostCallRecordDestroyEvent(layer_data *dev_data, VkEvent event, EVENT_STATE *event_state, VK_OBJECT obj_struct) { |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 5397 | invalidateCommandBuffers(dev_data, event_state->cb_bindings, obj_struct); |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5398 | dev_data->eventMap.erase(event); |
| 5399 | } |
| 5400 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5401 | VKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5402 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 5403 | EVENT_STATE *event_state = nullptr; |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5404 | VK_OBJECT obj_struct; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5405 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5406 | bool skip = PreCallValidateDestroyEvent(dev_data, event, &event_state, &obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5407 | if (!skip) { |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5408 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5409 | dev_data->dispatch_table.DestroyEvent(device, event, pAllocator); |
Tobin Ehlis | 66aba77 | 2016-10-20 14:13:24 -0600 | [diff] [blame] | 5410 | lock.lock(); |
| 5411 | PostCallRecordDestroyEvent(dev_data, event, event_state, obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5412 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5413 | } |
| 5414 | |
Tobin Ehlis | d8f5535 | 2016-12-16 14:56:41 -0700 | [diff] [blame] | 5415 | static bool PreCallValidateDestroyQueryPool(layer_data *dev_data, VkQueryPool query_pool, QUERY_POOL_NODE **qp_state, |
| 5416 | VK_OBJECT *obj_struct) { |
| 5417 | *qp_state = getQueryPoolNode(dev_data, query_pool); |
| 5418 | *obj_struct = {reinterpret_cast<uint64_t &>(query_pool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}; |
Tobin Ehlis | 4531515 | 2016-12-16 15:02:44 -0700 | [diff] [blame] | 5419 | if (dev_data->instance_data->disabled.destroy_query_pool) |
| 5420 | return false; |
Tobin Ehlis | d8f5535 | 2016-12-16 14:56:41 -0700 | [diff] [blame] | 5421 | bool skip = false; |
| 5422 | if (*qp_state) { |
| 5423 | skip |= ValidateObjectNotInUse(dev_data, *qp_state, *obj_struct, VALIDATION_ERROR_01012); |
| 5424 | } |
| 5425 | return skip; |
| 5426 | } |
| 5427 | |
| 5428 | static void PostCallRecordDestroyQueryPool(layer_data *dev_data, VkQueryPool query_pool, QUERY_POOL_NODE *qp_state, VK_OBJECT obj_struct) { |
| 5429 | invalidateCommandBuffers(dev_data, qp_state->cb_bindings, obj_struct); |
| 5430 | dev_data->queryPoolMap.erase(query_pool); |
| 5431 | } |
| 5432 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5433 | VKAPI_ATTR void VKAPI_CALL |
| 5434 | DestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 5435 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | d8f5535 | 2016-12-16 14:56:41 -0700 | [diff] [blame] | 5436 | QUERY_POOL_NODE *qp_state = nullptr; |
| 5437 | VK_OBJECT obj_struct; |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 5438 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d8f5535 | 2016-12-16 14:56:41 -0700 | [diff] [blame] | 5439 | bool skip = PreCallValidateDestroyQueryPool(dev_data, queryPool, &qp_state, &obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5440 | if (!skip) { |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5441 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5442 | dev_data->dispatch_table.DestroyQueryPool(device, queryPool, pAllocator); |
Tobin Ehlis | d8f5535 | 2016-12-16 14:56:41 -0700 | [diff] [blame] | 5443 | lock.lock(); |
| 5444 | PostCallRecordDestroyQueryPool(dev_data, queryPool, qp_state, obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 5445 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5446 | } |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5447 | static bool PreCallValidateGetQueryPoolResults(layer_data *dev_data, VkQueryPool query_pool, uint32_t first_query, |
| 5448 | uint32_t query_count, VkQueryResultFlags flags, |
| 5449 | unordered_map<QueryObject, vector<VkCommandBuffer>> *queries_in_flight) { |
| 5450 | for (auto cmd_buffer : dev_data->globalInFlightCmdBuffers) { |
| 5451 | auto cb = getCBNode(dev_data, cmd_buffer); |
| 5452 | for (auto query_state_pair : cb->queryToStateMap) { |
| 5453 | (*queries_in_flight)[query_state_pair.first].push_back(cmd_buffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5454 | } |
| 5455 | } |
Tobin Ehlis | 4fbe1c2 | 2016-12-19 10:20:43 -0700 | [diff] [blame] | 5456 | if (dev_data->instance_data->disabled.get_query_pool_results) |
| 5457 | return false; |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5458 | bool skip = false; |
| 5459 | for (uint32_t i = 0; i < query_count; ++i) { |
| 5460 | QueryObject query = {query_pool, first_query + i}; |
| 5461 | auto qif_pair = queries_in_flight->find(query); |
| 5462 | auto query_state_pair = dev_data->queryToStateMap.find(query); |
| 5463 | if (query_state_pair != dev_data->queryToStateMap.end()) { |
Mark Lobodzinski | 6a31218 | 2016-04-01 15:58:32 -0600 | [diff] [blame] | 5464 | // Available and in flight |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5465 | if (qif_pair != queries_in_flight->end() && query_state_pair != dev_data->queryToStateMap.end() && |
| 5466 | query_state_pair->second) { |
| 5467 | for (auto cmd_buffer : qif_pair->second) { |
| 5468 | auto cb = getCBNode(dev_data, cmd_buffer); |
| 5469 | auto query_event_pair = cb->waitedEventsBeforeQueryReset.find(query); |
| 5470 | if (query_event_pair == cb->waitedEventsBeforeQueryReset.end()) { |
| 5471 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 5472 | VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| 5473 | "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", |
| 5474 | (uint64_t)(query_pool), first_query + i); |
| 5475 | } |
| 5476 | } |
| 5477 | // Unavailable and in flight |
| 5478 | } else if (qif_pair != queries_in_flight->end() && query_state_pair != dev_data->queryToStateMap.end() && |
| 5479 | !query_state_pair->second) { |
| 5480 | // TODO : Can there be the same query in use by multiple command buffers in flight? |
| 5481 | bool make_available = false; |
| 5482 | for (auto cmd_buffer : qif_pair->second) { |
| 5483 | auto cb = getCBNode(dev_data, cmd_buffer); |
| 5484 | make_available |= cb->queryToStateMap[query]; |
| 5485 | } |
| 5486 | if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { |
| 5487 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 5488 | VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| 5489 | "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", |
| 5490 | (uint64_t)(query_pool), first_query + i); |
| 5491 | } |
| 5492 | // Unavailable |
| 5493 | } else if (query_state_pair != dev_data->queryToStateMap.end() && !query_state_pair->second) { |
| 5494 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, |
| 5495 | __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| 5496 | "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", |
| 5497 | (uint64_t)(query_pool), first_query + i); |
| 5498 | // Uninitialized |
| 5499 | } else if (query_state_pair == dev_data->queryToStateMap.end()) { |
| 5500 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, |
| 5501 | __LINE__, DRAWSTATE_INVALID_QUERY, "DS", |
| 5502 | "Cannot get query results on queryPool 0x%" PRIx64 |
| 5503 | " with index %d as data has not been collected for this index.", |
| 5504 | (uint64_t)(query_pool), first_query + i); |
| 5505 | } |
| 5506 | } |
| 5507 | } |
| 5508 | return skip; |
| 5509 | } |
| 5510 | |
| 5511 | static void PostCallRecordGetQueryPoolResults(layer_data *dev_data, VkQueryPool query_pool, uint32_t first_query, |
| 5512 | uint32_t query_count, |
| 5513 | unordered_map<QueryObject, vector<VkCommandBuffer>> *queries_in_flight) { |
| 5514 | for (uint32_t i = 0; i < query_count; ++i) { |
| 5515 | QueryObject query = {query_pool, first_query + i}; |
| 5516 | auto qif_pair = queries_in_flight->find(query); |
| 5517 | auto query_state_pair = dev_data->queryToStateMap.find(query); |
| 5518 | if (query_state_pair != dev_data->queryToStateMap.end()) { |
| 5519 | // Available and in flight |
| 5520 | if (qif_pair != queries_in_flight->end() && query_state_pair != dev_data->queryToStateMap.end() && |
| 5521 | query_state_pair->second) { |
| 5522 | for (auto cmd_buffer : qif_pair->second) { |
| 5523 | auto cb = getCBNode(dev_data, cmd_buffer); |
| 5524 | auto query_event_pair = cb->waitedEventsBeforeQueryReset.find(query); |
| 5525 | if (query_event_pair != cb->waitedEventsBeforeQueryReset.end()) { |
| 5526 | for (auto event : query_event_pair->second) { |
Mark Lobodzinski | 6a31218 | 2016-04-01 15:58:32 -0600 | [diff] [blame] | 5527 | dev_data->eventMap[event].needsSignaled = true; |
| 5528 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5529 | } |
| 5530 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5531 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5532 | } |
| 5533 | } |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5534 | } |
| 5535 | |
| 5536 | VKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, |
| 5537 | size_t dataSize, void *pData, VkDeviceSize stride, VkQueryResultFlags flags) { |
| 5538 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5539 | unordered_map<QueryObject, vector<VkCommandBuffer>> queries_in_flight; |
| 5540 | std::unique_lock<std::mutex> lock(global_lock); |
| 5541 | bool skip = PreCallValidateGetQueryPoolResults(dev_data, queryPool, firstQuery, queryCount, flags, &queries_in_flight); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5542 | lock.unlock(); |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5543 | if (skip) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5544 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | 95f045b | 2016-12-19 10:11:50 -0700 | [diff] [blame] | 5545 | VkResult result = |
| 5546 | dev_data->dispatch_table.GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, flags); |
| 5547 | lock.lock(); |
| 5548 | PostCallRecordGetQueryPoolResults(dev_data, queryPool, firstQuery, queryCount, &queries_in_flight); |
| 5549 | lock.unlock(); |
| 5550 | return result; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5551 | } |
| 5552 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 5553 | static bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { |
| 5554 | bool skip_call = false; |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 5555 | auto buffer_state = getBufferState(my_data, buffer); |
| 5556 | if (!buffer_state) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5557 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 5558 | (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 5559 | "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5560 | } else { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 5561 | if (buffer_state->in_use.load()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5562 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5563 | (uint64_t)(buffer), __LINE__, VALIDATION_ERROR_00676, "DS", |
| 5564 | "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer. %s", (uint64_t)(buffer), |
| 5565 | validation_error_map[VALIDATION_ERROR_00676]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5566 | } |
| 5567 | } |
| 5568 | return skip_call; |
| 5569 | } |
| 5570 | |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5571 | // Return true if given ranges intersect, else false |
| 5572 | // Prereq : For both ranges, range->end - range->start > 0. This case should have already resulted |
| 5573 | // in an error so not checking that here |
| 5574 | // pad_ranges bool indicates a linear and non-linear comparison which requires padding |
| 5575 | // In the case where padding is required, if an alias is encountered then a validation error is reported and skip_call |
| 5576 | // may be set by the callback function so caller should merge in skip_call value if padding case is possible. |
Tobin Ehlis | 17b6552 | 2016-08-12 14:26:31 -0600 | [diff] [blame] | 5577 | static bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, MEMORY_RANGE const *range2, bool *skip_call) { |
| 5578 | *skip_call = false; |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5579 | auto r1_start = range1->start; |
| 5580 | auto r1_end = range1->end; |
| 5581 | auto r2_start = range2->start; |
| 5582 | auto r2_end = range2->end; |
| 5583 | VkDeviceSize pad_align = 1; |
| 5584 | if (range1->linear != range2->linear) { |
| 5585 | pad_align = dev_data->phys_dev_properties.properties.limits.bufferImageGranularity; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5586 | } |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5587 | if ((r1_end & ~(pad_align - 1)) < (r2_start & ~(pad_align - 1))) |
| 5588 | return false; |
| 5589 | if ((r1_start & ~(pad_align - 1)) > (r2_end & ~(pad_align - 1))) |
| 5590 | return false; |
| 5591 | |
| 5592 | if (range1->linear != range2->linear) { |
Tobin Ehlis | 951f6ae | 2016-12-13 12:16:58 -0700 | [diff] [blame] | 5593 | // In linear vs. non-linear case, warn of aliasing |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5594 | const char *r1_linear_str = range1->linear ? "Linear" : "Non-linear"; |
| 5595 | const char *r1_type_str = range1->image ? "image" : "buffer"; |
| 5596 | const char *r2_linear_str = range2->linear ? "linear" : "non-linear"; |
| 5597 | const char *r2_type_str = range2->image ? "image" : "buffer"; |
| 5598 | auto obj_type = range1->image ? VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT : VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT; |
Tobin Ehlis | 951f6ae | 2016-12-13 12:16:58 -0700 | [diff] [blame] | 5599 | *skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, obj_type, range1->handle, 0, |
| 5600 | MEMTRACK_INVALID_ALIASING, "MEM", "%s %s 0x%" PRIx64 " is aliased with %s %s 0x%" PRIx64 |
| 5601 | " which may indicate a bug. For further info refer to the " |
| 5602 | "Buffer-Image Granularity section of the Vulkan specification. " |
| 5603 | "(https://www.khronos.org/registry/vulkan/specs/1.0-extensions/" |
| 5604 | "xhtml/vkspec.html#resources-bufferimagegranularity)", |
| 5605 | r1_linear_str, r1_type_str, range1->handle, r2_linear_str, r2_type_str, range2->handle); |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5606 | } |
| 5607 | // Ranges intersect |
| 5608 | return true; |
| 5609 | } |
Tobin Ehlis | 0a78ef9 | 2016-08-12 14:12:44 -0600 | [diff] [blame] | 5610 | // Simplified rangesIntersect that calls above function to check range1 for intersection with offset & end addresses |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 5611 | static bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, VkDeviceSize offset, VkDeviceSize end) { |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5612 | // Create a local MEMORY_RANGE struct to wrap offset/size |
| 5613 | MEMORY_RANGE range_wrap; |
| 5614 | // Synch linear with range1 to avoid padding and potential validation error case |
| 5615 | range_wrap.linear = range1->linear; |
| 5616 | range_wrap.start = offset; |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 5617 | range_wrap.end = end; |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5618 | bool tmp_bool; |
Tobin Ehlis | 17b6552 | 2016-08-12 14:26:31 -0600 | [diff] [blame] | 5619 | return rangesIntersect(dev_data, range1, &range_wrap, &tmp_bool); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5620 | } |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 5621 | // For given mem_info, set all ranges valid that intersect [offset-end] range |
| 5622 | // TODO : For ranges where there is no alias, we may want to create new buffer ranges that are valid |
| 5623 | static void SetMemRangesValid(layer_data const *dev_data, DEVICE_MEM_INFO *mem_info, VkDeviceSize offset, VkDeviceSize end) { |
| 5624 | bool tmp_bool = false; |
Tobin Ehlis | 125fc63 | 2016-12-13 12:39:44 -0700 | [diff] [blame] | 5625 | MEMORY_RANGE map_range = {}; |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 5626 | map_range.linear = true; |
| 5627 | map_range.start = offset; |
| 5628 | map_range.end = end; |
| 5629 | for (auto &handle_range_pair : mem_info->bound_ranges) { |
Tobin Ehlis | 17b6552 | 2016-08-12 14:26:31 -0600 | [diff] [blame] | 5630 | if (rangesIntersect(dev_data, &handle_range_pair.second, &map_range, &tmp_bool)) { |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 5631 | // TODO : WARN here if tmp_bool true? |
| 5632 | handle_range_pair.second.valid = true; |
| 5633 | } |
| 5634 | } |
| 5635 | } |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5636 | // Object with given handle is being bound to memory w/ given mem_info struct. |
| 5637 | // Track the newly bound memory range with given memoryOffset |
| 5638 | // Also scan any previous ranges, track aliased ranges with new range, and flag an error if a linear |
| 5639 | // and non-linear range incorrectly overlap. |
| 5640 | // Return true if an error is flagged and the user callback returns "true", otherwise false |
| 5641 | // is_image indicates an image object, otherwise handle is for a buffer |
| 5642 | // is_linear indicates a buffer or linear image |
| 5643 | static bool InsertMemoryRange(layer_data const *dev_data, uint64_t handle, DEVICE_MEM_INFO *mem_info, VkDeviceSize memoryOffset, |
| 5644 | VkMemoryRequirements memRequirements, bool is_image, bool is_linear) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 5645 | bool skip_call = false; |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5646 | MEMORY_RANGE range; |
Tobin Ehlis | b3593a4 | 2016-03-16 16:00:36 -0600 | [diff] [blame] | 5647 | |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5648 | range.image = is_image; |
| 5649 | range.handle = handle; |
| 5650 | range.linear = is_linear; |
Tobin Ehlis | c3e9c7b | 2016-08-10 17:00:51 -0600 | [diff] [blame] | 5651 | range.valid = mem_info->global_valid; |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5652 | range.memory = mem_info->mem; |
| 5653 | range.start = memoryOffset; |
| 5654 | range.size = memRequirements.size; |
| 5655 | range.end = memoryOffset + memRequirements.size - 1; |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5656 | range.aliases.clear(); |
| 5657 | // Update Memory aliasing |
Tobin Ehlis | 6f3a2d1 | 2016-12-13 12:26:44 -0700 | [diff] [blame] | 5658 | // Save aliased ranges so we can copy into final map entry below. Can't do it in loop b/c we don't yet have final ptr. If we |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5659 | // inserted into map before loop to get the final ptr, then we may enter loop when not needed & we check range against itself |
| 5660 | std::unordered_set<MEMORY_RANGE *> tmp_alias_ranges; |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5661 | for (auto &obj_range_pair : mem_info->bound_ranges) { |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5662 | auto check_range = &obj_range_pair.second; |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5663 | bool intersection_error = false; |
Tobin Ehlis | 17b6552 | 2016-08-12 14:26:31 -0600 | [diff] [blame] | 5664 | if (rangesIntersect(dev_data, &range, check_range, &intersection_error)) { |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5665 | skip_call |= intersection_error; |
| 5666 | range.aliases.insert(check_range); |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5667 | tmp_alias_ranges.insert(check_range); |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5668 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5669 | } |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5670 | mem_info->bound_ranges[handle] = std::move(range); |
| 5671 | for (auto tmp_range : tmp_alias_ranges) { |
| 5672 | tmp_range->aliases.insert(&mem_info->bound_ranges[handle]); |
| 5673 | } |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5674 | if (is_image) |
| 5675 | mem_info->bound_images.insert(handle); |
| 5676 | else |
| 5677 | mem_info->bound_buffers.insert(handle); |
| 5678 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5679 | return skip_call; |
| 5680 | } |
| 5681 | |
Tobin Ehlis | e20d21f | 2016-08-10 18:01:27 -0600 | [diff] [blame] | 5682 | static bool InsertImageMemoryRange(layer_data const *dev_data, VkImage image, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5683 | VkMemoryRequirements mem_reqs, bool is_linear) { |
Tobin Ehlis | e20d21f | 2016-08-10 18:01:27 -0600 | [diff] [blame] | 5684 | return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(image), mem_info, mem_offset, mem_reqs, true, is_linear); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5685 | } |
| 5686 | |
Tobin Ehlis | e20d21f | 2016-08-10 18:01:27 -0600 | [diff] [blame] | 5687 | static bool InsertBufferMemoryRange(layer_data const *dev_data, VkBuffer buffer, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5688 | VkMemoryRequirements mem_reqs) { |
Tobin Ehlis | e20d21f | 2016-08-10 18:01:27 -0600 | [diff] [blame] | 5689 | return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(buffer), mem_info, mem_offset, mem_reqs, false, true); |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5690 | } |
| 5691 | |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5692 | // Remove MEMORY_RANGE struct for give handle from bound_ranges of mem_info |
| 5693 | // is_image indicates if handle is for image or buffer |
| 5694 | // This function will also remove the handle-to-index mapping from the appropriate |
| 5695 | // map and clean up any aliases for range being removed. |
| 5696 | static void RemoveMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info, bool is_image) { |
| 5697 | auto erase_range = &mem_info->bound_ranges[handle]; |
| 5698 | for (auto alias_range : erase_range->aliases) { |
| 5699 | alias_range->aliases.erase(erase_range); |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5700 | } |
Tobin Ehlis | 32fe220 | 2016-08-10 09:55:59 -0600 | [diff] [blame] | 5701 | erase_range->aliases.clear(); |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5702 | mem_info->bound_ranges.erase(handle); |
Tobin Ehlis | fed999f | 2016-09-21 15:09:45 -0600 | [diff] [blame] | 5703 | if (is_image) { |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5704 | mem_info->bound_images.erase(handle); |
Tobin Ehlis | fed999f | 2016-09-21 15:09:45 -0600 | [diff] [blame] | 5705 | } else { |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5706 | mem_info->bound_buffers.erase(handle); |
Tobin Ehlis | fed999f | 2016-09-21 15:09:45 -0600 | [diff] [blame] | 5707 | } |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 5708 | } |
| 5709 | |
| 5710 | static void RemoveBufferMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, false); } |
| 5711 | |
| 5712 | static void RemoveImageMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, true); } |
| 5713 | |
Tobin Ehlis | 4f94a0c | 2016-12-19 10:53:58 -0700 | [diff] [blame] | 5714 | static bool PreCallValidateDestroyBuffer(layer_data *dev_data, VkBuffer buffer, BUFFER_STATE **buffer_state, |
| 5715 | VK_OBJECT *obj_struct) { |
| 5716 | *buffer_state = getBufferState(dev_data, buffer); |
| 5717 | *obj_struct = {reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}; |
Tobin Ehlis | 98a94f1 | 2016-12-19 10:57:29 -0700 | [diff] [blame] | 5718 | if (dev_data->instance_data->disabled.destroy_buffer) |
| 5719 | return false; |
Tobin Ehlis | 4f94a0c | 2016-12-19 10:53:58 -0700 | [diff] [blame] | 5720 | bool skip = false; |
| 5721 | if (*buffer_state) { |
| 5722 | skip |= validateIdleBuffer(dev_data, buffer); |
| 5723 | } |
| 5724 | return skip; |
| 5725 | } |
| 5726 | |
| 5727 | static void PostCallRecordDestroyBuffer(layer_data *dev_data, VkBuffer buffer, BUFFER_STATE *buffer_state, VK_OBJECT obj_struct) { |
| 5728 | invalidateCommandBuffers(dev_data, buffer_state->cb_bindings, obj_struct); |
| 5729 | for (auto mem_binding : buffer_state->GetBoundMemory()) { |
| 5730 | auto mem_info = getMemObjInfo(dev_data, mem_binding); |
| 5731 | if (mem_info) { |
| 5732 | RemoveBufferMemoryRange(reinterpret_cast<uint64_t &>(buffer), mem_info); |
| 5733 | } |
| 5734 | } |
| 5735 | ClearMemoryObjectBindings(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); |
| 5736 | dev_data->bufferMap.erase(buffer_state->buffer); |
| 5737 | } |
| 5738 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5739 | VKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, |
| 5740 | const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5741 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 4f94a0c | 2016-12-19 10:53:58 -0700 | [diff] [blame] | 5742 | BUFFER_STATE *buffer_state = nullptr; |
| 5743 | VK_OBJECT obj_struct; |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5744 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4f94a0c | 2016-12-19 10:53:58 -0700 | [diff] [blame] | 5745 | bool skip = PreCallValidateDestroyBuffer(dev_data, buffer, &buffer_state, &obj_struct); |
| 5746 | if (!skip) { |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5747 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5748 | dev_data->dispatch_table.DestroyBuffer(device, buffer, pAllocator); |
Tobin Ehlis | 4f94a0c | 2016-12-19 10:53:58 -0700 | [diff] [blame] | 5749 | lock.lock(); |
| 5750 | PostCallRecordDestroyBuffer(dev_data, buffer, buffer_state, obj_struct); |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5751 | } |
| 5752 | } |
| 5753 | |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5754 | static bool PreCallValidateDestroyBufferView(layer_data *dev_data, VkBufferView buffer_view, BUFFER_VIEW_STATE **buffer_view_state, |
| 5755 | VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 5756 | *buffer_view_state = getBufferViewState(dev_data, buffer_view); |
| 5757 | *obj_struct = {reinterpret_cast<uint64_t &>(buffer_view), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 5758 | if (dev_data->instance_data->disabled.destroy_buffer_view) |
Tobin Ehlis | b1c2e76 | 2016-09-28 14:25:44 -0600 | [diff] [blame] | 5759 | return false; |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5760 | bool skip = false; |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5761 | if (*buffer_view_state) { |
Tobin Ehlis | 4a98a71 | 2016-10-12 09:58:35 -0600 | [diff] [blame] | 5762 | skip |= ValidateObjectNotInUse(dev_data, *buffer_view_state, *obj_struct, VALIDATION_ERROR_00701); |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5763 | } |
| 5764 | return skip; |
| 5765 | } |
| 5766 | |
| 5767 | static void PostCallRecordDestroyBufferView(layer_data *dev_data, VkBufferView buffer_view, BUFFER_VIEW_STATE *buffer_view_state, |
| 5768 | VK_OBJECT obj_struct) { |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5769 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 5770 | invalidateCommandBuffers(dev_data, buffer_view_state->cb_bindings, obj_struct); |
Tobin Ehlis | 7fa33f4 | 2016-10-05 21:50:14 -0600 | [diff] [blame] | 5771 | dev_data->bufferViewMap.erase(buffer_view); |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5772 | } |
| 5773 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5774 | VKAPI_ATTR void VKAPI_CALL |
| 5775 | DestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5776 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5777 | // Common data objects used pre & post call |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5778 | BUFFER_VIEW_STATE *buffer_view_state = nullptr; |
| 5779 | VK_OBJECT obj_struct; |
Tobin Ehlis | d4aef97 | 2016-10-12 08:53:27 -0600 | [diff] [blame] | 5780 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5781 | // Validate state before calling down chain, update common data if we'll be calling down chain |
| 5782 | bool skip = PreCallValidateDestroyBufferView(dev_data, bufferView, &buffer_view_state, &obj_struct); |
Tobin Ehlis | d79532b | 2016-09-26 17:38:00 -0600 | [diff] [blame] | 5783 | if (!skip) { |
Tobin Ehlis | d79532b | 2016-09-26 17:38:00 -0600 | [diff] [blame] | 5784 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5785 | dev_data->dispatch_table.DestroyBufferView(device, bufferView, pAllocator); |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5786 | lock.lock(); |
Tobin Ehlis | 4f451da | 2016-09-28 14:01:13 -0600 | [diff] [blame] | 5787 | PostCallRecordDestroyBufferView(dev_data, bufferView, buffer_view_state, obj_struct); |
Tobin Ehlis | d79532b | 2016-09-26 17:38:00 -0600 | [diff] [blame] | 5788 | } |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5789 | } |
| 5790 | |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 5791 | static bool PreCallValidateDestroyImage(layer_data *dev_data, VkImage image, IMAGE_STATE **image_state, VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 5792 | *image_state = getImageState(dev_data, image); |
| 5793 | *obj_struct = {reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 5794 | if (dev_data->instance_data->disabled.destroy_image) |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5795 | return false; |
| 5796 | bool skip = false; |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5797 | if (*image_state) { |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5798 | skip |= ValidateObjectNotInUse(dev_data, *image_state, *obj_struct, VALIDATION_ERROR_00743); |
| 5799 | } |
| 5800 | return skip; |
| 5801 | } |
| 5802 | |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 5803 | static void PostCallRecordDestroyImage(layer_data *dev_data, VkImage image, IMAGE_STATE *image_state, VK_OBJECT obj_struct) { |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 5804 | invalidateCommandBuffers(dev_data, image_state->cb_bindings, obj_struct); |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5805 | // Clean up memory mapping, bindings and range references for image |
Tobin Ehlis | 640a81c | 2016-11-15 15:37:18 -0700 | [diff] [blame] | 5806 | for (auto mem_binding : image_state->GetBoundMemory()) { |
| 5807 | auto mem_info = getMemObjInfo(dev_data, mem_binding); |
| 5808 | if (mem_info) { |
| 5809 | RemoveImageMemoryRange(obj_struct.handle, mem_info); |
| 5810 | } |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5811 | } |
Tobin Ehlis | 2fca09c | 2016-10-11 18:46:21 -0600 | [diff] [blame] | 5812 | ClearMemoryObjectBindings(dev_data, obj_struct.handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5813 | // Remove image from imageMap |
| 5814 | dev_data->imageMap.erase(image); |
| 5815 | |
| 5816 | const auto &sub_entry = dev_data->imageSubresourceMap.find(image); |
| 5817 | if (sub_entry != dev_data->imageSubresourceMap.end()) { |
| 5818 | for (const auto &pair : sub_entry->second) { |
| 5819 | dev_data->imageLayoutMap.erase(pair); |
| 5820 | } |
| 5821 | dev_data->imageSubresourceMap.erase(sub_entry); |
| 5822 | } |
| 5823 | } |
| 5824 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5825 | VKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5826 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 5827 | IMAGE_STATE *image_state = nullptr; |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5828 | VK_OBJECT obj_struct; |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 5829 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5830 | bool skip = PreCallValidateDestroyImage(dev_data, image, &image_state, &obj_struct); |
Tobin Ehlis | 6fcd6e4 | 2016-09-21 14:28:42 -0600 | [diff] [blame] | 5831 | if (!skip) { |
Tobin Ehlis | 6fcd6e4 | 2016-09-21 14:28:42 -0600 | [diff] [blame] | 5832 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5833 | dev_data->dispatch_table.DestroyImage(device, image, pAllocator); |
Tobin Ehlis | cd9008e | 2016-10-12 17:14:02 -0600 | [diff] [blame] | 5834 | lock.lock(); |
| 5835 | PostCallRecordDestroyImage(dev_data, image, image_state, obj_struct); |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5836 | } |
| 5837 | } |
| 5838 | |
Mark Lobodzinski | b5563d3 | 2016-06-14 12:11:29 -0600 | [diff] [blame] | 5839 | static bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5840 | const char *funcName, UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Mark Lobodzinski | b5563d3 | 2016-06-14 12:11:29 -0600 | [diff] [blame] | 5841 | bool skip_call = false; |
Tobin Ehlis | 06d54a1 | 2016-08-04 08:03:32 -0600 | [diff] [blame] | 5842 | if (((1 << mem_info->alloc_info.memoryTypeIndex) & memory_type_bits) == 0) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5843 | skip_call = |
| 5844 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 5845 | reinterpret_cast<const uint64_t &>(mem_info->mem), __LINE__, msgCode, "MT", |
| 5846 | "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " |
| 5847 | "type (0x%X) of this memory object 0x%" PRIx64 ". %s", |
| 5848 | funcName, memory_type_bits, mem_info->alloc_info.memoryTypeIndex, |
| 5849 | reinterpret_cast<const uint64_t &>(mem_info->mem), validation_error_map[msgCode]); |
Mark Lobodzinski | b5563d3 | 2016-06-14 12:11:29 -0600 | [diff] [blame] | 5850 | } |
| 5851 | return skip_call; |
| 5852 | } |
| 5853 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5854 | VKAPI_ATTR VkResult VKAPI_CALL |
| 5855 | BindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { |
Tobin Ehlis | b3593a4 | 2016-03-16 16:00:36 -0600 | [diff] [blame] | 5856 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5857 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5858 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5859 | // Track objects tied to memory |
Tobin Ehlis | e20d21f | 2016-08-10 18:01:27 -0600 | [diff] [blame] | 5860 | uint64_t buffer_handle = reinterpret_cast<uint64_t &>(buffer); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 5861 | bool skip_call = SetMemBinding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 5862 | auto buffer_state = getBufferState(dev_data, buffer); |
| 5863 | if (buffer_state) { |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5864 | if (!buffer_state->memory_requirements_checked) { |
| 5865 | // There's not an explicit requirement in the spec to call vkGetBufferMemoryRequirements() prior to calling |
| 5866 | // BindBufferMemory but it's implied in that memory being bound must conform with VkMemoryRequirements from |
| 5867 | // vkGetBufferMemoryRequirements() |
| 5868 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 5869 | buffer_handle, __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", |
| 5870 | "vkBindBufferMemory(): Binding memory to buffer 0x%" PRIxLEAST64 |
| 5871 | " but vkGetBufferMemoryRequirements() has not been called on that buffer.", |
| 5872 | buffer_handle); |
| 5873 | // Make the call for them so we can verify the state |
| 5874 | lock.unlock(); |
| 5875 | dev_data->dispatch_table.GetBufferMemoryRequirements(device, buffer, &buffer_state->requirements); |
| 5876 | lock.lock(); |
| 5877 | } |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 5878 | buffer_state->binding.mem = mem; |
| 5879 | buffer_state->binding.offset = memoryOffset; |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5880 | buffer_state->binding.size = buffer_state->requirements.size; |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5881 | |
| 5882 | // Track and validate bound memory range information |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 5883 | auto mem_info = getMemObjInfo(dev_data, mem); |
| 5884 | if (mem_info) { |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5885 | skip_call |= InsertBufferMemoryRange(dev_data, buffer, mem_info, memoryOffset, buffer_state->requirements); |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5886 | skip_call |= ValidateMemoryTypes(dev_data, mem_info, buffer_state->requirements.memoryTypeBits, "vkBindBufferMemory()", |
| 5887 | VALIDATION_ERROR_00797); |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 5888 | } |
| 5889 | |
Dustin Graves | a97c394 | 2016-03-31 18:01:37 -0600 | [diff] [blame] | 5890 | // Validate memory requirements alignment |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5891 | if (vk_safe_modulo(memoryOffset, buffer_state->requirements.alignment) != 0) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5892 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 5893 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, VALIDATION_ERROR_02174, "DS", |
| 5894 | "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " |
| 5895 | "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 |
| 5896 | ", returned from a call to vkGetBufferMemoryRequirements with buffer. %s", |
| 5897 | memoryOffset, buffer_state->requirements.alignment, validation_error_map[VALIDATION_ERROR_02174]); |
Dustin Graves | a97c394 | 2016-03-31 18:01:37 -0600 | [diff] [blame] | 5898 | } |
Mark Mueller | ec0bafe | 2016-07-07 11:57:59 -0600 | [diff] [blame] | 5899 | |
Dustin Graves | a97c394 | 2016-03-31 18:01:37 -0600 | [diff] [blame] | 5900 | // Validate device limits alignments |
Mark Mueller | ec0bafe | 2016-07-07 11:57:59 -0600 | [diff] [blame] | 5901 | static const VkBufferUsageFlagBits usage_list[3] = { |
| 5902 | static_cast<VkBufferUsageFlagBits>(VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT), |
| 5903 | VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, |
| 5904 | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT}; |
| 5905 | static const char *memory_type[3] = {"texel", |
| 5906 | "uniform", |
| 5907 | "storage"}; |
| 5908 | static const char *offset_name[3] = { |
| 5909 | "minTexelBufferOffsetAlignment", |
| 5910 | "minUniformBufferOffsetAlignment", |
| 5911 | "minStorageBufferOffsetAlignment" |
| 5912 | }; |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5913 | static const UNIQUE_VALIDATION_ERROR_CODE msgCode[3] = { |
| 5914 | VALIDATION_ERROR_00794, |
| 5915 | VALIDATION_ERROR_00795, |
| 5916 | VALIDATION_ERROR_00796 |
| 5917 | }; |
Mark Mueller | ec0bafe | 2016-07-07 11:57:59 -0600 | [diff] [blame] | 5918 | |
| 5919 | // Keep this one fresh! |
| 5920 | const VkDeviceSize offset_requirement[3] = { |
| 5921 | dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment, |
| 5922 | dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, |
| 5923 | dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment |
| 5924 | }; |
Tobin Ehlis | 94bc5d2 | 2016-06-02 07:46:52 -0600 | [diff] [blame] | 5925 | VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; |
Mark Mueller | ec0bafe | 2016-07-07 11:57:59 -0600 | [diff] [blame] | 5926 | |
| 5927 | for (int i = 0; i < 3; i++) { |
| 5928 | if (usage & usage_list[i]) { |
| 5929 | if (vk_safe_modulo(memoryOffset, offset_requirement[i]) != 0) { |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 5930 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 5931 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, msgCode[i], "DS", |
| 5932 | "vkBindBufferMemory(): %s memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " |
| 5933 | "device limit %s 0x%" PRIxLEAST64 ". %s", |
| 5934 | memory_type[i], memoryOffset, offset_name[i], offset_requirement[i], |
| 5935 | validation_error_map[msgCode[i]]); |
Mark Mueller | ec0bafe | 2016-07-07 11:57:59 -0600 | [diff] [blame] | 5936 | } |
Dustin Graves | a97c394 | 2016-03-31 18:01:37 -0600 | [diff] [blame] | 5937 | } |
| 5938 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5939 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 5940 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 5941 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5942 | result = dev_data->dispatch_table.BindBufferMemory(device, buffer, mem, memoryOffset); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5943 | } |
| 5944 | return result; |
| 5945 | } |
| 5946 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5947 | VKAPI_ATTR void VKAPI_CALL |
| 5948 | GetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { |
Tobin Ehlis | 530bb0a | 2016-11-16 08:57:22 -0700 | [diff] [blame] | 5949 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5950 | dev_data->dispatch_table.GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 5951 | auto buffer_state = getBufferState(dev_data, buffer); |
Tobin Ehlis | 530bb0a | 2016-11-16 08:57:22 -0700 | [diff] [blame] | 5952 | if (buffer_state) { |
| 5953 | buffer_state->requirements = *pMemoryRequirements; |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5954 | buffer_state->memory_requirements_checked = true; |
Tobin Ehlis | 530bb0a | 2016-11-16 08:57:22 -0700 | [diff] [blame] | 5955 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5956 | } |
| 5957 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5958 | VKAPI_ATTR void VKAPI_CALL |
| 5959 | GetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { |
Tobin Ehlis | 530bb0a | 2016-11-16 08:57:22 -0700 | [diff] [blame] | 5960 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 5961 | dev_data->dispatch_table.GetImageMemoryRequirements(device, image, pMemoryRequirements); |
| 5962 | auto image_state = getImageState(dev_data, image); |
| 5963 | if (image_state) { |
| 5964 | image_state->requirements = *pMemoryRequirements; |
Tobin Ehlis | 8c18970 | 2016-11-17 13:39:57 -0700 | [diff] [blame] | 5965 | image_state->memory_requirements_checked = true; |
Tobin Ehlis | 530bb0a | 2016-11-16 08:57:22 -0700 | [diff] [blame] | 5966 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 5967 | } |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 5968 | |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5969 | static bool PreCallValidateDestroyImageView(layer_data *dev_data, VkImageView image_view, IMAGE_VIEW_STATE **image_view_state, |
| 5970 | VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 5971 | *image_view_state = getImageViewState(dev_data, image_view); |
| 5972 | *obj_struct = {reinterpret_cast<uint64_t &>(image_view), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 5973 | if (dev_data->instance_data->disabled.destroy_image_view) |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5974 | return false; |
| 5975 | bool skip = false; |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5976 | if (*image_view_state) { |
Tobin Ehlis | 4a98a71 | 2016-10-12 09:58:35 -0600 | [diff] [blame] | 5977 | skip |= ValidateObjectNotInUse(dev_data, *image_view_state, *obj_struct, VALIDATION_ERROR_00776); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5978 | } |
| 5979 | return skip; |
| 5980 | } |
| 5981 | |
| 5982 | static void PostCallRecordDestroyImageView(layer_data *dev_data, VkImageView image_view, IMAGE_VIEW_STATE *image_view_state, |
| 5983 | VK_OBJECT obj_struct) { |
| 5984 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 5985 | invalidateCommandBuffers(dev_data, image_view_state->cb_bindings, obj_struct); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5986 | dev_data->imageViewMap.erase(image_view); |
| 5987 | } |
| 5988 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 5989 | VKAPI_ATTR void VKAPI_CALL |
| 5990 | DestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | dd9830a | 2016-09-19 13:10:37 -0600 | [diff] [blame] | 5991 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5992 | // Common data objects used pre & post call |
| 5993 | IMAGE_VIEW_STATE *image_view_state = nullptr; |
| 5994 | VK_OBJECT obj_struct; |
Tobin Ehlis | d4aef97 | 2016-10-12 08:53:27 -0600 | [diff] [blame] | 5995 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 5996 | bool skip = PreCallValidateDestroyImageView(dev_data, imageView, &image_view_state, &obj_struct); |
Tobin Ehlis | dd9830a | 2016-09-19 13:10:37 -0600 | [diff] [blame] | 5997 | if (!skip) { |
Tobin Ehlis | dd9830a | 2016-09-19 13:10:37 -0600 | [diff] [blame] | 5998 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 5999 | dev_data->dispatch_table.DestroyImageView(device, imageView, pAllocator); |
Tobin Ehlis | e1bb80c | 2016-10-12 08:27:08 -0600 | [diff] [blame] | 6000 | lock.lock(); |
| 6001 | PostCallRecordDestroyImageView(dev_data, imageView, image_view_state, obj_struct); |
Tobin Ehlis | dd9830a | 2016-09-19 13:10:37 -0600 | [diff] [blame] | 6002 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6003 | } |
| 6004 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6005 | VKAPI_ATTR void VKAPI_CALL |
| 6006 | DestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { |
Chris Forbes | 90da2e9 | 2016-03-18 16:30:03 +1300 | [diff] [blame] | 6007 | layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6008 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6009 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | 90da2e9 | 2016-03-18 16:30:03 +1300 | [diff] [blame] | 6010 | my_data->shaderModuleMap.erase(shaderModule); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6011 | lock.unlock(); |
Chris Forbes | 90da2e9 | 2016-03-18 16:30:03 +1300 | [diff] [blame] | 6012 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6013 | my_data->dispatch_table.DestroyShaderModule(device, shaderModule, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6014 | } |
| 6015 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6016 | static bool PreCallValidateDestroyPipeline(layer_data *dev_data, VkPipeline pipeline, PIPELINE_STATE **pipeline_state, |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6017 | VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6018 | *pipeline_state = getPipelineState(dev_data, pipeline); |
| 6019 | *obj_struct = {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 6020 | if (dev_data->instance_data->disabled.destroy_pipeline) |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6021 | return false; |
| 6022 | bool skip = false; |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6023 | if (*pipeline_state) { |
Tobin Ehlis | 4a98a71 | 2016-10-12 09:58:35 -0600 | [diff] [blame] | 6024 | skip |= ValidateObjectNotInUse(dev_data, *pipeline_state, *obj_struct, VALIDATION_ERROR_00555); |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6025 | } |
| 6026 | return skip; |
| 6027 | } |
| 6028 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6029 | static void PostCallRecordDestroyPipeline(layer_data *dev_data, VkPipeline pipeline, PIPELINE_STATE *pipeline_state, |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6030 | VK_OBJECT obj_struct) { |
| 6031 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6032 | invalidateCommandBuffers(dev_data, pipeline_state->cb_bindings, obj_struct); |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6033 | dev_data->pipelineMap.erase(pipeline); |
| 6034 | } |
| 6035 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6036 | VKAPI_ATTR void VKAPI_CALL |
| 6037 | DestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | aa0bc16 | 2016-07-08 15:42:38 -0600 | [diff] [blame] | 6038 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6039 | PIPELINE_STATE *pipeline_state = nullptr; |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6040 | VK_OBJECT obj_struct; |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 6041 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6042 | bool skip = PreCallValidateDestroyPipeline(dev_data, pipeline, &pipeline_state, &obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6043 | if (!skip) { |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6044 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6045 | dev_data->dispatch_table.DestroyPipeline(device, pipeline, pAllocator); |
Tobin Ehlis | be45ef2 | 2016-10-12 08:51:35 -0600 | [diff] [blame] | 6046 | lock.lock(); |
| 6047 | PostCallRecordDestroyPipeline(dev_data, pipeline, pipeline_state, obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6048 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6049 | } |
| 6050 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6051 | VKAPI_ATTR void VKAPI_CALL |
| 6052 | DestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | 7e5b375 | 2016-07-07 12:04:20 -0600 | [diff] [blame] | 6053 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 3b4926e | 2016-07-07 13:40:29 -0600 | [diff] [blame] | 6054 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 7e5b375 | 2016-07-07 12:04:20 -0600 | [diff] [blame] | 6055 | dev_data->pipelineLayoutMap.erase(pipelineLayout); |
Tobin Ehlis | 3b4926e | 2016-07-07 13:40:29 -0600 | [diff] [blame] | 6056 | lock.unlock(); |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 6057 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6058 | dev_data->dispatch_table.DestroyPipelineLayout(device, pipelineLayout, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6059 | } |
| 6060 | |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 6061 | static bool PreCallValidateDestroySampler(layer_data *dev_data, VkSampler sampler, SAMPLER_STATE **sampler_state, |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6062 | VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6063 | *sampler_state = getSamplerState(dev_data, sampler); |
| 6064 | *obj_struct = {reinterpret_cast<uint64_t &>(sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}; |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6065 | if (dev_data->instance_data->disabled.destroy_sampler) |
| 6066 | return false; |
| 6067 | bool skip = false; |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6068 | if (*sampler_state) { |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6069 | skip |= ValidateObjectNotInUse(dev_data, *sampler_state, *obj_struct, VALIDATION_ERROR_00837); |
| 6070 | } |
| 6071 | return skip; |
| 6072 | } |
| 6073 | |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 6074 | static void PostCallRecordDestroySampler(layer_data *dev_data, VkSampler sampler, SAMPLER_STATE *sampler_state, |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6075 | VK_OBJECT obj_struct) { |
| 6076 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6077 | if (sampler_state) |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6078 | invalidateCommandBuffers(dev_data, sampler_state->cb_bindings, obj_struct); |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6079 | dev_data->samplerMap.erase(sampler); |
| 6080 | } |
| 6081 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6082 | VKAPI_ATTR void VKAPI_CALL |
| 6083 | DestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 6084 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 6085 | SAMPLER_STATE *sampler_state = nullptr; |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6086 | VK_OBJECT obj_struct; |
Tobin Ehlis | 8020eea | 2016-08-17 11:10:41 -0600 | [diff] [blame] | 6087 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6088 | bool skip = PreCallValidateDestroySampler(dev_data, sampler, &sampler_state, &obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6089 | if (!skip) { |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6090 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6091 | dev_data->dispatch_table.DestroySampler(device, sampler, pAllocator); |
Tobin Ehlis | e030b10 | 2016-10-20 06:35:39 -0600 | [diff] [blame] | 6092 | lock.lock(); |
| 6093 | PostCallRecordDestroySampler(dev_data, sampler, sampler_state, obj_struct); |
Tobin Ehlis | 1afd0f5 | 2016-08-26 17:09:24 -0600 | [diff] [blame] | 6094 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6095 | } |
| 6096 | |
Tobin Ehlis | 2c140ae | 2016-12-19 11:16:14 -0700 | [diff] [blame] | 6097 | static void PostCallRecordDestroyDescriptorSetLayout(layer_data *dev_data, VkDescriptorSetLayout ds_layout) { |
| 6098 | dev_data->descriptorSetLayoutMap.erase(ds_layout); |
| 6099 | } |
| 6100 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6101 | VKAPI_ATTR void VKAPI_CALL |
| 6102 | DestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | 2c140ae | 2016-12-19 11:16:14 -0700 | [diff] [blame] | 6103 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6104 | dev_data->dispatch_table.DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); |
| 6105 | std::unique_lock<std::mutex> lock(global_lock); |
| 6106 | PostCallRecordDestroyDescriptorSetLayout(dev_data, descriptorSetLayout); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6107 | } |
| 6108 | |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6109 | static bool PreCallValidateDestroyDescriptorPool(layer_data *dev_data, VkDescriptorPool pool, |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 6110 | DESCRIPTOR_POOL_STATE **desc_pool_state, VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6111 | *desc_pool_state = getDescriptorPoolState(dev_data, pool); |
| 6112 | *obj_struct = {reinterpret_cast<uint64_t &>(pool), VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 6113 | if (dev_data->instance_data->disabled.destroy_descriptor_pool) |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6114 | return false; |
| 6115 | bool skip = false; |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6116 | if (*desc_pool_state) { |
Tobin Ehlis | 4a98a71 | 2016-10-12 09:58:35 -0600 | [diff] [blame] | 6117 | skip |= ValidateObjectNotInUse(dev_data, *desc_pool_state, *obj_struct, VALIDATION_ERROR_00901); |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6118 | } |
| 6119 | return skip; |
| 6120 | } |
| 6121 | |
| 6122 | static void PostCallRecordDestroyDescriptorPool(layer_data *dev_data, VkDescriptorPool descriptorPool, |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 6123 | DESCRIPTOR_POOL_STATE *desc_pool_state, VK_OBJECT obj_struct) { |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6124 | // Any bound cmd buffers are now invalid |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6125 | invalidateCommandBuffers(dev_data, desc_pool_state->cb_bindings, obj_struct); |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6126 | // Free sets that were in this pool |
| 6127 | for (auto ds : desc_pool_state->sets) { |
| 6128 | freeDescriptorSet(dev_data, ds); |
| 6129 | } |
| 6130 | dev_data->descriptorPoolMap.erase(descriptorPool); |
| 6131 | } |
| 6132 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6133 | VKAPI_ATTR void VKAPI_CALL |
| 6134 | DestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6135 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 6136 | DESCRIPTOR_POOL_STATE *desc_pool_state = nullptr; |
Tobin Ehlis | b69d693 | 2016-10-12 09:29:26 -0600 | [diff] [blame] | 6137 | VK_OBJECT obj_struct; |
| 6138 | std::unique_lock<std::mutex> lock(global_lock); |
| 6139 | bool skip = PreCallValidateDestroyDescriptorPool(dev_data, descriptorPool, &desc_pool_state, &obj_struct); |
| 6140 | if (!skip) { |
| 6141 | lock.unlock(); |
| 6142 | dev_data->dispatch_table.DestroyDescriptorPool(device, descriptorPool, pAllocator); |
| 6143 | lock.lock(); |
| 6144 | PostCallRecordDestroyDescriptorPool(dev_data, descriptorPool, desc_pool_state, obj_struct); |
| 6145 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6146 | } |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6147 | // Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result |
| 6148 | // If this is a secondary command buffer, then make sure its primary is also in-flight |
| 6149 | // If primary is not in-flight, then remove secondary from global in-flight set |
| 6150 | // This function is only valid at a point when cmdBuffer is being reset or freed |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6151 | static bool checkCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action, |
| 6152 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6153 | bool skip_call = false; |
| 6154 | if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { |
| 6155 | // Primary CB or secondary where primary is also in-flight is an error |
| 6156 | if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || |
| 6157 | (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6158 | skip_call |= |
| 6159 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 6160 | reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, error_code, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 6161 | "Attempt to %s command buffer (0x%p) which is in use. %s", action, cb_node->commandBuffer, |
| 6162 | validation_error_map[error_code]); |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6163 | } |
| 6164 | } |
| 6165 | return skip_call; |
| 6166 | } |
Chris Forbes | e30fb98 | 2016-06-21 12:35:16 +1200 | [diff] [blame] | 6167 | |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6168 | // Iterate over all cmdBuffers in given commandPool and verify that each is not in use |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6169 | static bool checkCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool, const char *action, |
| 6170 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6171 | bool skip_call = false; |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6172 | for (auto cmd_buffer : pPool->commandBuffers) { |
| 6173 | if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6174 | skip_call |= checkCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action, error_code); |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 6175 | } |
| 6176 | } |
| 6177 | return skip_call; |
| 6178 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6179 | |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6180 | static void clearCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool) { |
| 6181 | for (auto cmd_buffer : pPool->commandBuffers) { |
| 6182 | dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); |
Chris Forbes | e30fb98 | 2016-06-21 12:35:16 +1200 | [diff] [blame] | 6183 | } |
| 6184 | } |
| 6185 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6186 | VKAPI_ATTR void VKAPI_CALL |
| 6187 | FreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6188 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6189 | bool skip_call = false; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6190 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6191 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6192 | for (uint32_t i = 0; i < commandBufferCount; i++) { |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6193 | auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6194 | // Delete CB information structure, and remove from commandBufferMap |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6195 | if (cb_node) { |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6196 | skip_call |= checkCommandBufferInFlight(dev_data, cb_node, "free", VALIDATION_ERROR_00096); |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6197 | } |
| 6198 | } |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6199 | |
| 6200 | if (skip_call) |
| 6201 | return; |
| 6202 | |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6203 | auto pPool = getCommandPoolNode(dev_data, commandPool); |
| 6204 | for (uint32_t i = 0; i < commandBufferCount; i++) { |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6205 | auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6206 | // Delete CB information structure, and remove from commandBufferMap |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6207 | if (cb_node) { |
| 6208 | dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6209 | // reset prior to delete for data clean-up |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6210 | resetCB(dev_data, cb_node->commandBuffer); |
| 6211 | dev_data->commandBufferMap.erase(cb_node->commandBuffer); |
| 6212 | delete cb_node; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6213 | } |
| 6214 | |
| 6215 | // Remove commandBuffer reference from commandPoolMap |
Chris Forbes | 4e355d0 | 2016-06-21 13:24:04 +1200 | [diff] [blame] | 6216 | pPool->commandBuffers.remove(pCommandBuffers[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6217 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6218 | lock.unlock(); |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 6219 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6220 | dev_data->dispatch_table.FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6221 | } |
| 6222 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6223 | VKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, |
| 6224 | const VkAllocationCallbacks *pAllocator, |
| 6225 | VkCommandPool *pCommandPool) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6226 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6227 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6228 | VkResult result = dev_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6229 | |
| 6230 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6231 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6232 | dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; |
| 6233 | dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6234 | } |
| 6235 | return result; |
| 6236 | } |
| 6237 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6238 | VKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, |
| 6239 | const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6240 | |
| 6241 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 8a7519b | 2016-11-21 12:30:06 -0700 | [diff] [blame] | 6242 | bool skip = false; |
| 6243 | if (pCreateInfo && pCreateInfo->queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS) { |
| 6244 | if (!dev_data->enabled_features.pipelineStatisticsQuery) { |
| 6245 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, |
| 6246 | __LINE__, VALIDATION_ERROR_01006, "DS", |
| 6247 | "Query pool with type VK_QUERY_TYPE_PIPELINE_STATISTICS created on a device " |
| 6248 | "with VkDeviceCreateInfo.pEnabledFeatures.pipelineStatisticsQuery == VK_FALSE. %s", |
| 6249 | validation_error_map[VALIDATION_ERROR_01006]); |
| 6250 | } |
| 6251 | } |
| 6252 | |
| 6253 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| 6254 | if (!skip) { |
| 6255 | result = dev_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); |
| 6256 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6257 | if (result == VK_SUCCESS) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6258 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | 7d1dd14 | 2016-08-18 08:23:30 -0600 | [diff] [blame] | 6259 | QUERY_POOL_NODE *qp_node = &dev_data->queryPoolMap[*pQueryPool]; |
| 6260 | qp_node->createInfo = *pCreateInfo; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6261 | } |
| 6262 | return result; |
| 6263 | } |
| 6264 | |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6265 | static bool PreCallValidateDestroyCommandPool(layer_data *dev_data, VkCommandPool pool, COMMAND_POOL_NODE **cp_state) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6266 | *cp_state = getCommandPoolNode(dev_data, pool); |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6267 | if (dev_data->instance_data->disabled.destroy_command_pool) |
| 6268 | return false; |
| 6269 | bool skip = false; |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6270 | if (*cp_state) { |
| 6271 | // Verify that command buffers in pool are complete (not in-flight) |
| 6272 | skip |= checkCommandBuffersInFlight(dev_data, *cp_state, "destroy command pool with", VALIDATION_ERROR_00077); |
| 6273 | } |
| 6274 | return skip; |
| 6275 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6276 | |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6277 | static void PostCallRecordDestroyCommandPool(layer_data *dev_data, VkCommandPool pool, COMMAND_POOL_NODE *cp_state) { |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6278 | // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandBufferMap |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6279 | clearCommandBuffersInFlight(dev_data, cp_state); |
| 6280 | for (auto cb : cp_state->commandBuffers) { |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6281 | clear_cmd_buf_and_mem_references(dev_data, cb); |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6282 | auto cb_node = getCBNode(dev_data, cb); |
Tobin Ehlis | 1589d54 | 2016-07-22 16:55:19 -0600 | [diff] [blame] | 6283 | // Remove references to this cb_node prior to delete |
| 6284 | // TODO : Need better solution here, resetCB? |
Mark Lobodzinski | 3c9a384 | 2016-07-15 13:53:44 -0600 | [diff] [blame] | 6285 | for (auto obj : cb_node->object_bindings) { |
| 6286 | removeCommandBufferBinding(dev_data, &obj, cb_node); |
| 6287 | } |
Tobin Ehlis | 1589d54 | 2016-07-22 16:55:19 -0600 | [diff] [blame] | 6288 | for (auto framebuffer : cb_node->framebuffers) { |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 6289 | auto fb_state = getFramebufferState(dev_data, framebuffer); |
| 6290 | if (fb_state) |
| 6291 | fb_state->cb_bindings.erase(cb_node); |
Tobin Ehlis | 1589d54 | 2016-07-22 16:55:19 -0600 | [diff] [blame] | 6292 | } |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 6293 | dev_data->commandBufferMap.erase(cb); // Remove this command buffer |
| 6294 | delete cb_node; // delete CB info structure |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6295 | } |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6296 | dev_data->commandPoolMap.erase(pool); |
| 6297 | } |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 6298 | |
Tobin Ehlis | a4b4ce2 | 2016-10-20 09:40:35 -0600 | [diff] [blame] | 6299 | // Destroy commandPool along with all of the commandBuffers allocated from that pool |
| 6300 | VKAPI_ATTR void VKAPI_CALL DestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { |
| 6301 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6302 | COMMAND_POOL_NODE *cp_state = nullptr; |
| 6303 | std::unique_lock<std::mutex> lock(global_lock); |
| 6304 | bool skip = PreCallValidateDestroyCommandPool(dev_data, commandPool, &cp_state); |
| 6305 | if (!skip) { |
| 6306 | lock.unlock(); |
| 6307 | dev_data->dispatch_table.DestroyCommandPool(device, commandPool, pAllocator); |
| 6308 | lock.lock(); |
| 6309 | PostCallRecordDestroyCommandPool(dev_data, commandPool, cp_state); |
| 6310 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6311 | } |
| 6312 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6313 | VKAPI_ATTR VkResult VKAPI_CALL |
| 6314 | ResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6315 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6316 | bool skip_call = false; |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 6317 | |
Chris Forbes | 6be1b5a | 2016-06-21 18:17:41 +1200 | [diff] [blame] | 6318 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6319 | auto pPool = getCommandPoolNode(dev_data, commandPool); |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 6320 | skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "reset command pool with", VALIDATION_ERROR_00072); |
Chris Forbes | 6be1b5a | 2016-06-21 18:17:41 +1200 | [diff] [blame] | 6321 | lock.unlock(); |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6322 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6323 | if (skip_call) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6324 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 6325 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6326 | VkResult result = dev_data->dispatch_table.ResetCommandPool(device, commandPool, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6327 | |
| 6328 | // Reset all of the CBs allocated from this pool |
| 6329 | if (VK_SUCCESS == result) { |
Chris Forbes | 6be1b5a | 2016-06-21 18:17:41 +1200 | [diff] [blame] | 6330 | lock.lock(); |
Chris Forbes | 07811fa | 2016-06-21 13:18:44 +1200 | [diff] [blame] | 6331 | clearCommandBuffersInFlight(dev_data, pPool); |
| 6332 | for (auto cmdBuffer : pPool->commandBuffers) { |
| 6333 | resetCB(dev_data, cmdBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6334 | } |
Chris Forbes | 6be1b5a | 2016-06-21 18:17:41 +1200 | [diff] [blame] | 6335 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6336 | } |
| 6337 | return result; |
| 6338 | } |
| 6339 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6340 | VKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6341 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6342 | bool skip_call = false; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6343 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6344 | for (uint32_t i = 0; i < fenceCount; ++i) { |
Chris Forbes | 0111ee6 | 2016-06-15 15:48:52 +1200 | [diff] [blame] | 6345 | auto pFence = getFenceNode(dev_data, pFences[i]); |
Chris Forbes | 9c457b9 | 2016-06-21 18:10:47 +1200 | [diff] [blame] | 6346 | if (pFence && pFence->state == FENCE_INFLIGHT) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6347 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 6348 | reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, VALIDATION_ERROR_00183, "DS", |
| 6349 | "Fence 0x%" PRIx64 " is in use. %s", reinterpret_cast<const uint64_t &>(pFences[i]), |
| 6350 | validation_error_map[VALIDATION_ERROR_00183]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6351 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6352 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6353 | lock.unlock(); |
Chris Forbes | 9c457b9 | 2016-06-21 18:10:47 +1200 | [diff] [blame] | 6354 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6355 | if (skip_call) |
Chris Forbes | 9c457b9 | 2016-06-21 18:10:47 +1200 | [diff] [blame] | 6356 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 6357 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6358 | VkResult result = dev_data->dispatch_table.ResetFences(device, fenceCount, pFences); |
Chris Forbes | 9c457b9 | 2016-06-21 18:10:47 +1200 | [diff] [blame] | 6359 | |
| 6360 | if (result == VK_SUCCESS) { |
| 6361 | lock.lock(); |
| 6362 | for (uint32_t i = 0; i < fenceCount; ++i) { |
| 6363 | auto pFence = getFenceNode(dev_data, pFences[i]); |
| 6364 | if (pFence) { |
| 6365 | pFence->state = FENCE_UNSIGNALED; |
Chris Forbes | 9c457b9 | 2016-06-21 18:10:47 +1200 | [diff] [blame] | 6366 | } |
| 6367 | } |
| 6368 | lock.unlock(); |
| 6369 | } |
| 6370 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6371 | return result; |
| 6372 | } |
| 6373 | |
Tobin Ehlis | 2556f5b | 2016-06-24 17:22:16 -0600 | [diff] [blame] | 6374 | // For given cb_nodes, invalidate them and track object causing invalidation |
Tobin Ehlis | ab294d8 | 2016-11-21 15:23:51 -0700 | [diff] [blame] | 6375 | void invalidateCommandBuffers(const layer_data *dev_data, std::unordered_set<GLOBAL_CB_NODE *> const &cb_nodes, VK_OBJECT obj) { |
Tobin Ehlis | 2556f5b | 2016-06-24 17:22:16 -0600 | [diff] [blame] | 6376 | for (auto cb_node : cb_nodes) { |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6377 | if (cb_node->state == CB_RECORDING) { |
| 6378 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Tobin Ehlis | fda58e2 | 2016-11-21 15:15:52 -0700 | [diff] [blame] | 6379 | (uint64_t)(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 6380 | "Invalidating a command buffer that's currently being recorded: 0x%p.", cb_node->commandBuffer); |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6381 | } |
Tobin Ehlis | 2556f5b | 2016-06-24 17:22:16 -0600 | [diff] [blame] | 6382 | cb_node->state = CB_INVALID; |
| 6383 | cb_node->broken_bindings.push_back(obj); |
| 6384 | } |
| 6385 | } |
| 6386 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 6387 | static bool PreCallValidateDestroyFramebuffer(layer_data *dev_data, VkFramebuffer framebuffer, |
| 6388 | FRAMEBUFFER_STATE **framebuffer_state, VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6389 | *framebuffer_state = getFramebufferState(dev_data, framebuffer); |
| 6390 | *obj_struct = {reinterpret_cast<uint64_t &>(framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 6391 | if (dev_data->instance_data->disabled.destroy_framebuffer) |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6392 | return false; |
| 6393 | bool skip = false; |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6394 | if (*framebuffer_state) { |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6395 | skip |= ValidateObjectNotInUse(dev_data, *framebuffer_state, *obj_struct, VALIDATION_ERROR_00422); |
| 6396 | } |
| 6397 | return skip; |
| 6398 | } |
| 6399 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 6400 | static void PostCallRecordDestroyFramebuffer(layer_data *dev_data, VkFramebuffer framebuffer, FRAMEBUFFER_STATE *framebuffer_state, |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6401 | VK_OBJECT obj_struct) { |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6402 | invalidateCommandBuffers(dev_data, framebuffer_state->cb_bindings, obj_struct); |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6403 | dev_data->frameBufferMap.erase(framebuffer); |
| 6404 | } |
| 6405 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6406 | VKAPI_ATTR void VKAPI_CALL |
| 6407 | DestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6408 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 6409 | FRAMEBUFFER_STATE *framebuffer_state = nullptr; |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6410 | VK_OBJECT obj_struct; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6411 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 53332f0 | 2016-10-12 11:48:21 -0600 | [diff] [blame] | 6412 | bool skip = PreCallValidateDestroyFramebuffer(dev_data, framebuffer, &framebuffer_state, &obj_struct); |
| 6413 | if (!skip) { |
| 6414 | lock.unlock(); |
| 6415 | dev_data->dispatch_table.DestroyFramebuffer(device, framebuffer, pAllocator); |
| 6416 | lock.lock(); |
| 6417 | PostCallRecordDestroyFramebuffer(dev_data, framebuffer, framebuffer_state, obj_struct); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6418 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6419 | } |
| 6420 | |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6421 | static bool PreCallValidateDestroyRenderPass(layer_data *dev_data, VkRenderPass render_pass, RENDER_PASS_STATE **rp_state, |
| 6422 | VK_OBJECT *obj_struct) { |
Tobin Ehlis | d319087 | 2016-10-25 21:47:46 -0600 | [diff] [blame] | 6423 | *rp_state = getRenderPassState(dev_data, render_pass); |
| 6424 | *obj_struct = {reinterpret_cast<uint64_t &>(render_pass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}; |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 6425 | if (dev_data->instance_data->disabled.destroy_renderpass) |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6426 | return false; |
| 6427 | bool skip = false; |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6428 | if (*rp_state) { |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6429 | skip |= ValidateObjectNotInUse(dev_data, *rp_state, *obj_struct, VALIDATION_ERROR_00393); |
| 6430 | } |
| 6431 | return skip; |
| 6432 | } |
| 6433 | |
| 6434 | static void PostCallRecordDestroyRenderPass(layer_data *dev_data, VkRenderPass render_pass, RENDER_PASS_STATE *rp_state, |
| 6435 | VK_OBJECT obj_struct) { |
Tobin Ehlis | fe5731a | 2016-11-21 08:31:01 -0700 | [diff] [blame] | 6436 | invalidateCommandBuffers(dev_data, rp_state->cb_bindings, obj_struct); |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6437 | dev_data->renderPassMap.erase(render_pass); |
| 6438 | } |
| 6439 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6440 | VKAPI_ATTR void VKAPI_CALL |
| 6441 | DestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6442 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6443 | RENDER_PASS_STATE *rp_state = nullptr; |
| 6444 | VK_OBJECT obj_struct; |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 6445 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6446 | bool skip = PreCallValidateDestroyRenderPass(dev_data, renderPass, &rp_state, &obj_struct); |
Tobin Ehlis | a549524 | 2016-09-19 14:20:37 -0600 | [diff] [blame] | 6447 | if (!skip) { |
Tobin Ehlis | a549524 | 2016-09-19 14:20:37 -0600 | [diff] [blame] | 6448 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6449 | dev_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator); |
Tobin Ehlis | 062595b | 2016-10-12 16:58:54 -0600 | [diff] [blame] | 6450 | lock.lock(); |
| 6451 | PostCallRecordDestroyRenderPass(dev_data, renderPass, rp_state, obj_struct); |
Tobin Ehlis | a549524 | 2016-09-19 14:20:37 -0600 | [diff] [blame] | 6452 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6453 | } |
| 6454 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6455 | VKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, |
| 6456 | const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6457 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Karl Schultz | a9ef1e5 | 2016-10-06 17:53:48 -0600 | [diff] [blame] | 6458 | // TODO: Add check for VALIDATION_ERROR_00658 |
| 6459 | // TODO: Add check for VALIDATION_ERROR_00666 |
| 6460 | // TODO: Add check for VALIDATION_ERROR_00667 |
| 6461 | // TODO: Add check for VALIDATION_ERROR_00668 |
| 6462 | // TODO: Add check for VALIDATION_ERROR_00669 |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6463 | VkResult result = dev_data->dispatch_table.CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6464 | |
| 6465 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6466 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6467 | // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 6468 | dev_data->bufferMap.insert(std::make_pair(*pBuffer, unique_ptr<BUFFER_STATE>(new BUFFER_STATE(*pBuffer, pCreateInfo)))); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6469 | } |
| 6470 | return result; |
| 6471 | } |
| 6472 | |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6473 | static bool PreCallValidateCreateBufferView(layer_data *dev_data, const VkBufferViewCreateInfo *pCreateInfo) { |
| 6474 | bool skip_call = false; |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 6475 | BUFFER_STATE *buffer_state = getBufferState(dev_data, pCreateInfo->buffer); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6476 | // If this isn't a sparse buffer, it needs to have memory backing it at CreateBufferView time |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 6477 | if (buffer_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 6478 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buffer_state, "vkCreateBufferView()", VALIDATION_ERROR_02522); |
Tobin Ehlis | 18bca09 | 2016-06-29 09:07:52 -0600 | [diff] [blame] | 6479 | // In order to create a valid buffer view, the buffer must have been created with at least one of the |
| 6480 | // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 6481 | skip_call |= ValidateBufferUsageFlags( |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 6482 | dev_data, buffer_state, VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 6483 | VALIDATION_ERROR_00694, "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 6484 | } |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6485 | return skip_call; |
| 6486 | } |
| 6487 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6488 | VKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, |
| 6489 | const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6490 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6491 | std::unique_lock<std::mutex> lock(global_lock); |
| 6492 | bool skip_call = PreCallValidateCreateBufferView(dev_data, pCreateInfo); |
| 6493 | lock.unlock(); |
| 6494 | if (skip_call) |
| 6495 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6496 | VkResult result = dev_data->dispatch_table.CreateBufferView(device, pCreateInfo, pAllocator, pView); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6497 | if (VK_SUCCESS == result) { |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6498 | lock.lock(); |
Tobin Ehlis | 8b87246 | 2016-09-14 08:12:08 -0600 | [diff] [blame] | 6499 | dev_data->bufferViewMap[*pView] = unique_ptr<BUFFER_VIEW_STATE>(new BUFFER_VIEW_STATE(*pView, pCreateInfo)); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6500 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6501 | } |
| 6502 | return result; |
| 6503 | } |
| 6504 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6505 | VKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, |
| 6506 | const VkAllocationCallbacks *pAllocator, VkImage *pImage) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6507 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | f20f094 | 2016-03-22 10:07:26 -0600 | [diff] [blame] | 6508 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6509 | VkResult result = dev_data->dispatch_table.CreateImage(device, pCreateInfo, pAllocator, pImage); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6510 | |
| 6511 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6512 | std::lock_guard<std::mutex> lock(global_lock); |
Mark Lobodzinski | bf93db7 | 2017-01-17 16:24:29 -0700 | [diff] [blame] | 6513 | PostCallRecordCreateImage(&dev_data->imageMap, &dev_data->imageSubresourceMap, &dev_data->imageLayoutMap, pCreateInfo, |
| 6514 | pImage); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6515 | } |
| 6516 | return result; |
| 6517 | } |
| 6518 | |
| 6519 | static void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 6520 | // Expects global_lock to be held by caller |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6521 | |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6522 | auto image_state = getImageState(dev_data, image); |
| 6523 | if (image_state) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 6524 | // If the caller used the special values VK_REMAINING_MIP_LEVELS and VK_REMAINING_ARRAY_LAYERS, resolve them now in our |
| 6525 | // internal state to the actual values. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6526 | if (range->levelCount == VK_REMAINING_MIP_LEVELS) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6527 | range->levelCount = image_state->createInfo.mipLevels - range->baseMipLevel; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6528 | } |
| 6529 | |
| 6530 | if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6531 | range->layerCount = image_state->createInfo.arrayLayers - range->baseArrayLayer; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6532 | } |
| 6533 | } |
| 6534 | } |
| 6535 | |
| 6536 | // Return the correct layer/level counts if the caller used the special |
| 6537 | // values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. |
| 6538 | static void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, |
| 6539 | VkImage image) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 6540 | // Expects global_lock to be held by caller |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6541 | |
| 6542 | *levels = range.levelCount; |
| 6543 | *layers = range.layerCount; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6544 | auto image_state = getImageState(dev_data, image); |
| 6545 | if (image_state) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6546 | if (range.levelCount == VK_REMAINING_MIP_LEVELS) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6547 | *levels = image_state->createInfo.mipLevels - range.baseMipLevel; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6548 | } |
| 6549 | if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6550 | *layers = image_state->createInfo.arrayLayers - range.baseArrayLayer; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6551 | } |
| 6552 | } |
| 6553 | } |
| 6554 | |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6555 | // For the given format verify that the aspect masks make sense |
| 6556 | static bool ValidateImageAspectMask(layer_data *dev_data, VkImage image, VkFormat format, VkImageAspectFlags aspect_mask, |
| 6557 | const char *func_name) { |
| 6558 | bool skip = false; |
| 6559 | if (vk_format_is_color(format)) { |
| 6560 | if ((aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { |
| 6561 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6562 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6563 | "%s: Color image formats must have the VK_IMAGE_ASPECT_COLOR_BIT set. %s", func_name, |
| 6564 | validation_error_map[VALIDATION_ERROR_00741]); |
Tobin Ehlis | a4306ef | 2017-01-02 10:04:56 -0700 | [diff] [blame] | 6565 | } else if ((aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) != aspect_mask) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6566 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6567 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6568 | "%s: Color image formats must have ONLY the VK_IMAGE_ASPECT_COLOR_BIT set. %s", func_name, |
| 6569 | validation_error_map[VALIDATION_ERROR_00741]); |
| 6570 | } |
| 6571 | } else if (vk_format_is_depth_and_stencil(format)) { |
| 6572 | if ((aspect_mask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) == 0) { |
| 6573 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6574 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", "%s: Depth/stencil image formats must have " |
| 6575 | "at least one of VK_IMAGE_ASPECT_DEPTH_BIT " |
| 6576 | "and VK_IMAGE_ASPECT_STENCIL_BIT set. %s", |
| 6577 | func_name, validation_error_map[VALIDATION_ERROR_00741]); |
Tobin Ehlis | a4306ef | 2017-01-02 10:04:56 -0700 | [diff] [blame] | 6578 | } else if ((aspect_mask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) != aspect_mask) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6579 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6580 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6581 | "%s: Combination depth/stencil image formats can have only the VK_IMAGE_ASPECT_DEPTH_BIT and " |
| 6582 | "VK_IMAGE_ASPECT_STENCIL_BIT set. %s", |
| 6583 | func_name, validation_error_map[VALIDATION_ERROR_00741]); |
| 6584 | } |
| 6585 | } else if (vk_format_is_depth_only(format)) { |
| 6586 | if ((aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) != VK_IMAGE_ASPECT_DEPTH_BIT) { |
| 6587 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6588 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6589 | "%s: Depth-only image formats must have the VK_IMAGE_ASPECT_DEPTH_BIT set. %s", func_name, |
| 6590 | validation_error_map[VALIDATION_ERROR_00741]); |
Tobin Ehlis | a4306ef | 2017-01-02 10:04:56 -0700 | [diff] [blame] | 6591 | } else if ((aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) != aspect_mask) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6592 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6593 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6594 | "%s: Depth-only image formats can have only the VK_IMAGE_ASPECT_DEPTH_BIT set. %s", func_name, |
| 6595 | validation_error_map[VALIDATION_ERROR_00741]); |
| 6596 | } |
| 6597 | } else if (vk_format_is_stencil_only(format)) { |
| 6598 | if ((aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) != VK_IMAGE_ASPECT_STENCIL_BIT) { |
| 6599 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6600 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6601 | "%s: Stencil-only image formats must have the VK_IMAGE_ASPECT_STENCIL_BIT set. %s", func_name, |
| 6602 | validation_error_map[VALIDATION_ERROR_00741]); |
Tobin Ehlis | a4306ef | 2017-01-02 10:04:56 -0700 | [diff] [blame] | 6603 | } else if ((aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) != aspect_mask) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6604 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 6605 | (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", |
| 6606 | "%s: Stencil-only image formats can have only the VK_IMAGE_ASPECT_STENCIL_BIT set. %s", func_name, |
| 6607 | validation_error_map[VALIDATION_ERROR_00741]); |
| 6608 | } |
| 6609 | } |
| 6610 | return skip; |
| 6611 | } |
| 6612 | |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6613 | static bool PreCallValidateCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *create_info) { |
Tobin Ehlis | 4ad9d85 | 2016-10-26 08:04:58 -0600 | [diff] [blame] | 6614 | bool skip = false; |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6615 | IMAGE_STATE *image_state = getImageState(dev_data, create_info->image); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6616 | if (image_state) { |
Tobin Ehlis | 4ad9d85 | 2016-10-26 08:04:58 -0600 | [diff] [blame] | 6617 | skip |= ValidateImageUsageFlags( |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 6618 | dev_data, image_state, VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | |
| 6619 | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 6620 | false, -1, "vkCreateImageView()", |
Tony Barbour | 311dcbe | 2016-08-26 13:01:43 -0600 | [diff] [blame] | 6621 | "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT|DEPTH_STENCIL_ATTACHMENT|INPUT_ATTACHMENT]_BIT"); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 6622 | // If this isn't a sparse image, it needs to have memory backing it at CreateImageView time |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 6623 | skip |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCreateImageView()", VALIDATION_ERROR_02524); |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6624 | // Checks imported from image layer |
| 6625 | if (create_info->subresourceRange.baseMipLevel >= image_state->createInfo.mipLevels) { |
| 6626 | std::stringstream ss; |
| 6627 | ss << "vkCreateImageView called with baseMipLevel " << create_info->subresourceRange.baseMipLevel << " for image " |
| 6628 | << create_info->image << " that only has " << image_state->createInfo.mipLevels << " mip levels."; |
| 6629 | skip |= |
| 6630 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6631 | VALIDATION_ERROR_00768, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00768]); |
| 6632 | } |
| 6633 | if (create_info->subresourceRange.baseArrayLayer >= image_state->createInfo.arrayLayers) { |
| 6634 | std::stringstream ss; |
| 6635 | ss << "vkCreateImageView called with baseArrayLayer " << create_info->subresourceRange.baseArrayLayer << " for image " |
| 6636 | << create_info->image << " that only has " << image_state->createInfo.arrayLayers << " array layers."; |
| 6637 | skip |= |
| 6638 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6639 | VALIDATION_ERROR_00769, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00769]); |
| 6640 | } |
| 6641 | // TODO: Need new valid usage language for levelCount == 0 & layerCount == 0 |
| 6642 | if (!create_info->subresourceRange.levelCount) { |
| 6643 | std::stringstream ss; |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6644 | ss << "vkCreateImageView called with 0 in pCreateInfo->subresourceRange.levelCount."; |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6645 | skip |= |
| 6646 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6647 | VALIDATION_ERROR_00768, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00768]); |
| 6648 | } |
| 6649 | if (!create_info->subresourceRange.layerCount) { |
| 6650 | std::stringstream ss; |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6651 | ss << "vkCreateImageView called with 0 in pCreateInfo->subresourceRange.layerCount."; |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6652 | skip |= |
| 6653 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6654 | VALIDATION_ERROR_00769, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00769]); |
| 6655 | } |
| 6656 | |
| 6657 | VkImageCreateFlags image_flags = image_state->createInfo.flags; |
| 6658 | VkFormat image_format = image_state->createInfo.format; |
| 6659 | VkFormat view_format = create_info->format; |
| 6660 | VkImageAspectFlags aspect_mask = create_info->subresourceRange.aspectMask; |
| 6661 | |
| 6662 | // Validate VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT state |
| 6663 | if (image_flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) { |
| 6664 | // Format MUST be compatible (in the same format compatibility class) as the format the image was created with |
| 6665 | if (vk_format_get_compatibility_class(image_format) != vk_format_get_compatibility_class(view_format)) { |
| 6666 | std::stringstream ss; |
| 6667 | ss << "vkCreateImageView(): ImageView format " << string_VkFormat(view_format) |
| 6668 | << " is not in the same format compatibility class as image (" << (uint64_t)create_info->image << ") format " |
| 6669 | << string_VkFormat(image_format) << ". Images created with the VK_IMAGE_CREATE_MUTABLE_FORMAT BIT " |
| 6670 | << "can support ImageViews with differing formats but they must be in the same compatibility class."; |
| 6671 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6672 | VALIDATION_ERROR_02171, "IMAGE", "%s %s", ss.str().c_str(), |
| 6673 | validation_error_map[VALIDATION_ERROR_02171]); |
| 6674 | } |
| 6675 | } else { |
| 6676 | // Format MUST be IDENTICAL to the format the image was created with |
| 6677 | if (image_format != view_format) { |
| 6678 | std::stringstream ss; |
| 6679 | ss << "vkCreateImageView() format " << string_VkFormat(view_format) << " differs from image " |
| 6680 | << (uint64_t)create_info->image << " format " << string_VkFormat(image_format) |
| 6681 | << ". Formats MUST be IDENTICAL unless VK_IMAGE_CREATE_MUTABLE_FORMAT BIT was set on image creation."; |
| 6682 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6683 | VALIDATION_ERROR_02172, "IMAGE", "%s %s", ss.str().c_str(), |
| 6684 | validation_error_map[VALIDATION_ERROR_02172]); |
| 6685 | } |
| 6686 | } |
| 6687 | |
| 6688 | // Validate correct image aspect bits for desired formats and format consistency |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 6689 | skip |= ValidateImageAspectMask(dev_data, image_state->image, image_format, aspect_mask, "vkCreateImageView()"); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6690 | } |
Tobin Ehlis | 4ad9d85 | 2016-10-26 08:04:58 -0600 | [diff] [blame] | 6691 | return skip; |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6692 | } |
| 6693 | |
Tobin Ehlis | 1623987 | 2016-10-26 10:42:49 -0600 | [diff] [blame] | 6694 | static inline void PostCallRecordCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *create_info, VkImageView view) { |
| 6695 | dev_data->imageViewMap[view] = unique_ptr<IMAGE_VIEW_STATE>(new IMAGE_VIEW_STATE(view, create_info)); |
| 6696 | ResolveRemainingLevelsLayers(dev_data, &dev_data->imageViewMap[view].get()->create_info.subresourceRange, create_info->image); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6697 | } |
| 6698 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6699 | VKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, |
| 6700 | const VkAllocationCallbacks *pAllocator, VkImageView *pView) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6701 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6702 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4ad9d85 | 2016-10-26 08:04:58 -0600 | [diff] [blame] | 6703 | bool skip = PreCallValidateCreateImageView(dev_data, pCreateInfo); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6704 | lock.unlock(); |
Tobin Ehlis | 4ad9d85 | 2016-10-26 08:04:58 -0600 | [diff] [blame] | 6705 | if (skip) |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6706 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6707 | VkResult result = dev_data->dispatch_table.CreateImageView(device, pCreateInfo, pAllocator, pView); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6708 | if (VK_SUCCESS == result) { |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6709 | lock.lock(); |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 6710 | PostCallRecordCreateImageView(dev_data, pCreateInfo, *pView); |
Mark Young | d339ba3 | 2016-05-30 13:28:35 -0600 | [diff] [blame] | 6711 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6712 | } |
Chris Forbes | 86c586a | 2016-05-08 10:19:14 +1200 | [diff] [blame] | 6713 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6714 | return result; |
| 6715 | } |
| 6716 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6717 | VKAPI_ATTR VkResult VKAPI_CALL |
| 6718 | CreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6719 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6720 | VkResult result = dev_data->dispatch_table.CreateFence(device, pCreateInfo, pAllocator, pFence); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6721 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6722 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 6723 | auto &fence_node = dev_data->fenceMap[*pFence]; |
Chris Forbes | bc0b821 | 2016-06-10 15:22:37 +1200 | [diff] [blame] | 6724 | fence_node.fence = *pFence; |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 6725 | fence_node.createInfo = *pCreateInfo; |
Chris Forbes | ff96dcd | 2016-06-16 11:47:24 +1200 | [diff] [blame] | 6726 | fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6727 | } |
| 6728 | return result; |
| 6729 | } |
| 6730 | |
| 6731 | // TODO handle pipeline caches |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6732 | VKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, |
| 6733 | const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6734 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6735 | VkResult result = dev_data->dispatch_table.CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6736 | return result; |
| 6737 | } |
| 6738 | |
| 6739 | VKAPI_ATTR void VKAPI_CALL |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6740 | DestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6741 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6742 | dev_data->dispatch_table.DestroyPipelineCache(device, pipelineCache, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6743 | } |
| 6744 | |
| 6745 | VKAPI_ATTR VkResult VKAPI_CALL |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6746 | GetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6747 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6748 | VkResult result = dev_data->dispatch_table.GetPipelineCacheData(device, pipelineCache, pDataSize, pData); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6749 | return result; |
| 6750 | } |
| 6751 | |
| 6752 | VKAPI_ATTR VkResult VKAPI_CALL |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6753 | MergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6754 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6755 | VkResult result = dev_data->dispatch_table.MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6756 | return result; |
| 6757 | } |
| 6758 | |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 6759 | // utility function to set collective state for pipeline |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6760 | void set_pipeline_state(PIPELINE_STATE *pPipe) { |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 6761 | // If any attachment used by this pipeline has blendEnable, set top-level blendEnable |
| 6762 | if (pPipe->graphicsPipelineCI.pColorBlendState) { |
| 6763 | for (size_t i = 0; i < pPipe->attachments.size(); ++i) { |
| 6764 | if (VK_TRUE == pPipe->attachments[i].blendEnable) { |
| 6765 | if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| 6766 | (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || |
| 6767 | ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| 6768 | (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || |
| 6769 | ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| 6770 | (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || |
| 6771 | ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && |
| 6772 | (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { |
| 6773 | pPipe->blendConstantsEnabled = true; |
| 6774 | } |
| 6775 | } |
| 6776 | } |
| 6777 | } |
| 6778 | } |
| 6779 | |
Mark Lobodzinski | 7f170b3 | 2016-11-16 10:05:30 -0700 | [diff] [blame] | 6780 | static bool PreCallCreateGraphicsPipelines(layer_data *device_data, uint32_t count, |
| 6781 | const VkGraphicsPipelineCreateInfo *create_infos, vector<PIPELINE_STATE *> &pipe_state) { |
| 6782 | bool skip = false; |
Mark Lobodzinski | ca60e14 | 2016-11-16 11:12:30 -0700 | [diff] [blame] | 6783 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(device_data->instance_data->instance), instance_layer_data_map); |
Mark Lobodzinski | 7f170b3 | 2016-11-16 10:05:30 -0700 | [diff] [blame] | 6784 | |
| 6785 | for (uint32_t i = 0; i < count; i++) { |
| 6786 | skip |= verifyPipelineCreateState(device_data, pipe_state, i); |
Mark Lobodzinski | ca60e14 | 2016-11-16 11:12:30 -0700 | [diff] [blame] | 6787 | if (create_infos[i].pVertexInputState != NULL) { |
| 6788 | for (uint32_t j = 0; j < create_infos[i].pVertexInputState->vertexAttributeDescriptionCount; j++) { |
| 6789 | VkFormat format = create_infos[i].pVertexInputState->pVertexAttributeDescriptions[j].format; |
| 6790 | // Internal call to get format info. Still goes through layers, could potentially go directly to ICD. |
| 6791 | VkFormatProperties properties; |
| 6792 | instance_data->dispatch_table.GetPhysicalDeviceFormatProperties(device_data->physical_device, format, &properties); |
| 6793 | if ((properties.bufferFeatures & VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT) == 0) { |
| 6794 | skip |= log_msg( |
| 6795 | device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 6796 | __LINE__, VALIDATION_ERROR_01413, "IMAGE", |
| 6797 | "vkCreateGraphicsPipelines: pCreateInfo[%d].pVertexInputState->vertexAttributeDescriptions[%d].format " |
| 6798 | "(%s) is not a supported vertex buffer format. %s", |
| 6799 | i, j, string_VkFormat(format), validation_error_map[VALIDATION_ERROR_01413]); |
| 6800 | } |
| 6801 | } |
| 6802 | } |
Mark Lobodzinski | 7f170b3 | 2016-11-16 10:05:30 -0700 | [diff] [blame] | 6803 | } |
| 6804 | return skip; |
| 6805 | } |
| 6806 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6807 | VKAPI_ATTR VkResult VKAPI_CALL |
| 6808 | CreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, |
| 6809 | const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, |
| 6810 | VkPipeline *pPipelines) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6811 | // TODO What to do with pipelineCache? |
| 6812 | // The order of operations here is a little convoluted but gets the job done |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6813 | // 1. Pipeline create state is first shadowed into PIPELINE_STATE struct |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6814 | // 2. Create state is then validated (which uses flags setup during shadowing) |
| 6815 | // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap |
Mark Lobodzinski | 1f34f6f | 2016-11-16 10:11:02 -0700 | [diff] [blame] | 6816 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6817 | // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic |
Mark Lobodzinski | 1f34f6f | 2016-11-16 10:11:02 -0700 | [diff] [blame] | 6818 | vector<PIPELINE_STATE *> pipe_state(count); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6819 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6820 | |
| 6821 | uint32_t i = 0; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6822 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6823 | |
| 6824 | for (i = 0; i < count; i++) { |
Mark Lobodzinski | 1f34f6f | 2016-11-16 10:11:02 -0700 | [diff] [blame] | 6825 | pipe_state[i] = new PIPELINE_STATE; |
| 6826 | pipe_state[i]->initGraphicsPipeline(&pCreateInfos[i]); |
| 6827 | pipe_state[i]->render_pass_ci.initialize(getRenderPassState(dev_data, pCreateInfos[i].renderPass)->createInfo.ptr()); |
| 6828 | pipe_state[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6829 | } |
Mark Lobodzinski | 1f34f6f | 2016-11-16 10:11:02 -0700 | [diff] [blame] | 6830 | skip |= PreCallCreateGraphicsPipelines(dev_data, count, pCreateInfos, pipe_state); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6831 | |
Chris Forbes | 56754e2 | 2016-11-30 14:24:32 +1300 | [diff] [blame] | 6832 | if (skip) { |
| 6833 | for (i = 0; i < count; i++) { |
| 6834 | delete pipe_state[i]; |
Chris Forbes | 83e91ad | 2016-11-30 14:26:50 +1300 | [diff] [blame] | 6835 | pPipelines[i] = VK_NULL_HANDLE; |
Chris Forbes | 56754e2 | 2016-11-30 14:24:32 +1300 | [diff] [blame] | 6836 | } |
Chris Forbes | 78a69c6 | 2016-11-30 14:39:24 +1300 | [diff] [blame] | 6837 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 6838 | } |
| 6839 | |
| 6840 | lock.unlock(); |
| 6841 | auto result = dev_data->dispatch_table.CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); |
| 6842 | lock.lock(); |
| 6843 | for (i = 0; i < count; i++) { |
Chris Forbes | b186edf | 2016-11-30 14:41:35 +1300 | [diff] [blame] | 6844 | if (pPipelines[i] == VK_NULL_HANDLE) { |
| 6845 | delete pipe_state[i]; |
| 6846 | } |
| 6847 | else { |
| 6848 | pipe_state[i]->pipeline = pPipelines[i]; |
| 6849 | dev_data->pipelineMap[pipe_state[i]->pipeline] = pipe_state[i]; |
| 6850 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6851 | } |
Chris Forbes | 56754e2 | 2016-11-30 14:24:32 +1300 | [diff] [blame] | 6852 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6853 | return result; |
| 6854 | } |
| 6855 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6856 | VKAPI_ATTR VkResult VKAPI_CALL |
| 6857 | CreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, |
| 6858 | const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, |
| 6859 | VkPipeline *pPipelines) { |
Chris Forbes | 183f4f9 | 2016-11-30 14:35:52 +1300 | [diff] [blame] | 6860 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6861 | |
| 6862 | // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6863 | vector<PIPELINE_STATE *> pPipeState(count); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6864 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 6865 | |
| 6866 | uint32_t i = 0; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6867 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6868 | for (i = 0; i < count; i++) { |
| 6869 | // TODO: Verify compute stage bits |
| 6870 | |
| 6871 | // Create and initialize internal tracking data structure |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6872 | pPipeState[i] = new PIPELINE_STATE; |
| 6873 | pPipeState[i]->initComputePipeline(&pCreateInfos[i]); |
Tobin Ehlis | c1d9be1 | 2016-10-13 10:18:18 -0600 | [diff] [blame] | 6874 | pPipeState[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6875 | |
| 6876 | // TODO: Add Compute Pipeline Verification |
Chris Forbes | 183f4f9 | 2016-11-30 14:35:52 +1300 | [diff] [blame] | 6877 | skip |= !validate_compute_pipeline(dev_data->report_data, pPipeState[i], &dev_data->enabled_features, |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6878 | dev_data->shaderModuleMap); |
Chris Forbes | 183f4f9 | 2016-11-30 14:35:52 +1300 | [diff] [blame] | 6879 | // skip |= verifyPipelineCreateState(dev_data, pPipeState[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6880 | } |
| 6881 | |
Chris Forbes | 78a69c6 | 2016-11-30 14:39:24 +1300 | [diff] [blame] | 6882 | if (skip) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6883 | for (i = 0; i < count; i++) { |
| 6884 | // Clean up any locally allocated data structures |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 6885 | delete pPipeState[i]; |
Chris Forbes | 3224f95 | 2016-11-30 14:44:03 +1300 | [diff] [blame] | 6886 | pPipelines[i] = VK_NULL_HANDLE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6887 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6888 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 6889 | } |
Chris Forbes | 78a69c6 | 2016-11-30 14:39:24 +1300 | [diff] [blame] | 6890 | |
| 6891 | lock.unlock(); |
| 6892 | auto result = dev_data->dispatch_table.CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); |
| 6893 | lock.lock(); |
| 6894 | for (i = 0; i < count; i++) { |
Chris Forbes | 3224f95 | 2016-11-30 14:44:03 +1300 | [diff] [blame] | 6895 | if (pPipelines[i] == VK_NULL_HANDLE) { |
| 6896 | delete pPipeState[i]; |
| 6897 | } |
| 6898 | else { |
| 6899 | pPipeState[i]->pipeline = pPipelines[i]; |
| 6900 | dev_data->pipelineMap[pPipeState[i]->pipeline] = pPipeState[i]; |
| 6901 | } |
Chris Forbes | 78a69c6 | 2016-11-30 14:39:24 +1300 | [diff] [blame] | 6902 | } |
| 6903 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6904 | return result; |
| 6905 | } |
| 6906 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6907 | VKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, |
| 6908 | const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6909 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 6910 | VkResult result = dev_data->dispatch_table.CreateSampler(device, pCreateInfo, pAllocator, pSampler); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6911 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 6912 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | fad7adf | 2016-10-20 06:50:37 -0600 | [diff] [blame] | 6913 | dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_STATE>(new SAMPLER_STATE(pSampler, pCreateInfo)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6914 | } |
| 6915 | return result; |
| 6916 | } |
| 6917 | |
Tobin Ehlis | 154c269 | 2016-10-25 09:36:53 -0600 | [diff] [blame] | 6918 | static bool PreCallValidateCreateDescriptorSetLayout(layer_data *dev_data, const VkDescriptorSetLayoutCreateInfo *create_info) { |
| 6919 | if (dev_data->instance_data->disabled.create_descriptor_set_layout) |
| 6920 | return false; |
| 6921 | return cvdescriptorset::DescriptorSetLayout::ValidateCreateInfo(dev_data->report_data, create_info); |
| 6922 | } |
| 6923 | |
| 6924 | static void PostCallRecordCreateDescriptorSetLayout(layer_data *dev_data, const VkDescriptorSetLayoutCreateInfo *create_info, |
| 6925 | VkDescriptorSetLayout set_layout) { |
Tobin Ehlis | fdcb63f | 2016-10-25 20:56:47 -0600 | [diff] [blame] | 6926 | // TODO: Convert this to unique_ptr to avoid leaks |
Tobin Ehlis | 154c269 | 2016-10-25 09:36:53 -0600 | [diff] [blame] | 6927 | dev_data->descriptorSetLayoutMap[set_layout] = new cvdescriptorset::DescriptorSetLayout(create_info, set_layout); |
| 6928 | } |
| 6929 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 6930 | VKAPI_ATTR VkResult VKAPI_CALL |
| 6931 | CreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, |
| 6932 | const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6933 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 154c269 | 2016-10-25 09:36:53 -0600 | [diff] [blame] | 6934 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
| 6935 | std::unique_lock<std::mutex> lock(global_lock); |
| 6936 | bool skip = PreCallValidateCreateDescriptorSetLayout(dev_data, pCreateInfo); |
| 6937 | if (!skip) { |
| 6938 | lock.unlock(); |
| 6939 | result = dev_data->dispatch_table.CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); |
| 6940 | if (VK_SUCCESS == result) { |
| 6941 | lock.lock(); |
| 6942 | PostCallRecordCreateDescriptorSetLayout(dev_data, pCreateInfo, *pSetLayout); |
| 6943 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 6944 | } |
| 6945 | return result; |
| 6946 | } |
| 6947 | |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6948 | // Used by CreatePipelineLayout and CmdPushConstants. |
| 6949 | // Note that the index argument is optional and only used by CreatePipelineLayout. |
| 6950 | static bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, |
| 6951 | const char *caller_name, uint32_t index = 0) { |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 6952 | if (dev_data->instance_data->disabled.push_constant_range) |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 6953 | return false; |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6954 | uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6955 | bool skip_call = false; |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6956 | // Check that offset + size don't exceed the max. |
| 6957 | // Prevent arithetic overflow here by avoiding addition and testing in this order. |
| 6958 | if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { |
| 6959 | // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. |
| 6960 | if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { |
Tobin Ehlis | 2765e46 | 2016-11-23 10:47:26 -0700 | [diff] [blame] | 6961 | if (offset >= maxPushConstantsSize) { |
| 6962 | skip_call |= |
| 6963 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6964 | VALIDATION_ERROR_00877, "DS", "%s call has push constants index %u with offset %u that " |
| 6965 | "exceeds this device's maxPushConstantSize of %u. %s", |
| 6966 | caller_name, index, offset, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_00877]); |
| 6967 | } |
| 6968 | if (size > maxPushConstantsSize - offset) { |
| 6969 | skip_call |= |
| 6970 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6971 | VALIDATION_ERROR_00880, "DS", "%s call has push constants index %u with offset %u and size %u that " |
| 6972 | "exceeds this device's maxPushConstantSize of %u. %s", |
| 6973 | caller_name, index, offset, size, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_00880]); |
| 6974 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6975 | } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 6976 | if (offset >= maxPushConstantsSize) { |
| 6977 | skip_call |= |
| 6978 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6979 | VALIDATION_ERROR_00991, "DS", "%s call has push constants index %u with offset %u that " |
| 6980 | "exceeds this device's maxPushConstantSize of %u. %s", |
| 6981 | caller_name, index, offset, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_00991]); |
| 6982 | } |
| 6983 | if (size > maxPushConstantsSize - offset) { |
| 6984 | skip_call |= |
| 6985 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6986 | VALIDATION_ERROR_00992, "DS", "%s call has push constants index %u with offset %u and size %u that " |
| 6987 | "exceeds this device's maxPushConstantSize of %u. %s", |
| 6988 | caller_name, index, offset, size, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_00992]); |
| 6989 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6990 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 6991 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 6992 | DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 6993 | } |
| 6994 | } |
| 6995 | // size needs to be non-zero and a multiple of 4. |
| 6996 | if ((size == 0) || ((size & 0x3) != 0)) { |
| 6997 | if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { |
Tobin Ehlis | fe69954 | 2016-11-23 09:41:12 -0700 | [diff] [blame] | 6998 | if (size == 0) { |
| 6999 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 7000 | __LINE__, VALIDATION_ERROR_00878, "DS", "%s call has push constants index %u with " |
| 7001 | "size %u. Size must be greater than zero. %s", |
| 7002 | caller_name, index, size, validation_error_map[VALIDATION_ERROR_00878]); |
| 7003 | } |
| 7004 | if (size & 0x3) { |
| 7005 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 7006 | __LINE__, VALIDATION_ERROR_00879, "DS", "%s call has push constants index %u with " |
| 7007 | "size %u. Size must be a multiple of 4. %s", |
| 7008 | caller_name, index, size, validation_error_map[VALIDATION_ERROR_00879]); |
| 7009 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7010 | } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7011 | if (size == 0) { |
| 7012 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 7013 | __LINE__, VALIDATION_ERROR_01000, "DS", "%s call has push constants index %u with " |
| 7014 | "size %u. Size must be greater than zero. %s", |
| 7015 | caller_name, index, size, validation_error_map[VALIDATION_ERROR_01000]); |
| 7016 | } |
| 7017 | if (size & 0x3) { |
| 7018 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 7019 | __LINE__, VALIDATION_ERROR_00990, "DS", "%s call has push constants index %u with " |
| 7020 | "size %u. Size must be a multiple of 4. %s", |
| 7021 | caller_name, index, size, validation_error_map[VALIDATION_ERROR_00990]); |
| 7022 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7023 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7024 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 7025 | DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7026 | } |
| 7027 | } |
| 7028 | // offset needs to be a multiple of 4. |
| 7029 | if ((offset & 0x3) != 0) { |
| 7030 | if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7031 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7032 | VALIDATION_ERROR_02521, "DS", "%s call has push constants index %u with " |
| 7033 | "offset %u. Offset must be a multiple of 4. %s", |
| 7034 | caller_name, index, offset, validation_error_map[VALIDATION_ERROR_02521]); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7035 | } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7036 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7037 | VALIDATION_ERROR_00989, "DS", "%s call has push constants with " |
| 7038 | "offset %u. Offset must be a multiple of 4. %s", |
| 7039 | caller_name, offset, validation_error_map[VALIDATION_ERROR_00989]); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7040 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7041 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 7042 | DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7043 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7044 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7045 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7046 | } |
| 7047 | |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7048 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7049 | CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7050 | const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7051 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7052 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 7053 | // TODO : Add checks for VALIDATION_ERRORS 865-871 |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7054 | // Push Constant Range checks |
Karl Schultz | b7c6d0f | 2016-09-13 14:23:19 -0600 | [diff] [blame] | 7055 | uint32_t i, j; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7056 | for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7057 | skip_call |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, |
| 7058 | pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7059 | if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7060 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7061 | VALIDATION_ERROR_00882, "DS", "vkCreatePipelineLayout() call has no stageFlags set. %s", |
| 7062 | validation_error_map[VALIDATION_ERROR_00882]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7063 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7064 | } |
Karl Schultz | b7c6d0f | 2016-09-13 14:23:19 -0600 | [diff] [blame] | 7065 | if (skip_call) |
| 7066 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 7067 | |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7068 | // Each range has been validated. Now check for overlap between ranges (if they are good). |
Karl Schultz | b7c6d0f | 2016-09-13 14:23:19 -0600 | [diff] [blame] | 7069 | // There's no explicit Valid Usage language against this, so issue a warning instead of an error. |
| 7070 | for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { |
| 7071 | for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { |
| 7072 | const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; |
| 7073 | const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; |
| 7074 | const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; |
| 7075 | const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; |
| 7076 | if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { |
| 7077 | skip_call |= |
| 7078 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 7079 | DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " |
| 7080 | "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", |
| 7081 | i, minA, maxA, j, minB, maxB); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 7082 | } |
| 7083 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7084 | } |
Chris Forbes | cf7615e | 2016-05-10 16:02:49 +1200 | [diff] [blame] | 7085 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7086 | VkResult result = dev_data->dispatch_table.CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7087 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7088 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7089 | PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 7090 | plNode.layout = *pPipelineLayout; |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 7091 | plNode.set_layouts.resize(pCreateInfo->setLayoutCount); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7092 | for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 7093 | plNode.set_layouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7094 | } |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 7095 | plNode.push_constant_ranges.resize(pCreateInfo->pushConstantRangeCount); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7096 | for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { |
Tobin Ehlis | 3df4129 | 2016-07-07 09:23:38 -0600 | [diff] [blame] | 7097 | plNode.push_constant_ranges[i] = pCreateInfo->pPushConstantRanges[i]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7098 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7099 | } |
| 7100 | return result; |
| 7101 | } |
| 7102 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7103 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7104 | CreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, |
| 7105 | VkDescriptorPool *pDescriptorPool) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7106 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7107 | VkResult result = dev_data->dispatch_table.CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7108 | if (VK_SUCCESS == result) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7109 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7110 | (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7111 | (uint64_t)*pDescriptorPool)) |
| 7112 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 7113 | DESCRIPTOR_POOL_STATE *pNewNode = new DESCRIPTOR_POOL_STATE(*pDescriptorPool, pCreateInfo); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7114 | if (NULL == pNewNode) { |
| 7115 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, |
| 7116 | (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 7117 | "Out of memory while attempting to allocate DESCRIPTOR_POOL_STATE in vkCreateDescriptorPool()")) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7118 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 7119 | } else { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7120 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7121 | dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7122 | } |
| 7123 | } else { |
| 7124 | // Need to do anything if pool create fails? |
| 7125 | } |
| 7126 | return result; |
| 7127 | } |
| 7128 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7129 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7130 | ResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { |
Tobin Ehlis | 75f04ec | 2016-10-06 17:43:11 -0600 | [diff] [blame] | 7131 | // TODO : Add checks for VALIDATION_ERROR_00928 |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7132 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7133 | VkResult result = dev_data->dispatch_table.ResetDescriptorPool(device, descriptorPool, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7134 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7135 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7136 | clearDescriptorPool(dev_data, device, descriptorPool, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7137 | } |
| 7138 | return result; |
| 7139 | } |
Chris Forbes | b3f6006 | 2016-05-23 11:29:51 +1200 | [diff] [blame] | 7140 | // Ensure the pool contains enough descriptors and descriptor sets to satisfy |
Tobin Ehlis | bdb2800 | 2016-06-01 11:56:42 -0600 | [diff] [blame] | 7141 | // an allocation request. Fills common_data with the total number of descriptors of each type required, |
| 7142 | // as well as DescriptorSetLayout ptrs used for later update. |
Tobin Ehlis | 68d0adf | 2016-06-01 11:33:50 -0600 | [diff] [blame] | 7143 | static bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, |
| 7144 | cvdescriptorset::AllocateDescriptorSetsData *common_data) { |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 7145 | if (dev_data->instance_data->disabled.allocate_descriptor_sets) |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 7146 | return false; |
Tobin Ehlis | ee47146 | 2016-05-26 11:21:59 -0600 | [diff] [blame] | 7147 | // All state checks for AllocateDescriptorSets is done in single function |
Tobin Ehlis | 815e813 | 2016-06-02 13:02:17 -0600 | [diff] [blame] | 7148 | return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data->report_data, pAllocateInfo, dev_data, common_data); |
Tobin Ehlis | ee47146 | 2016-05-26 11:21:59 -0600 | [diff] [blame] | 7149 | } |
| 7150 | // Allocation state was good and call down chain was made so update state based on allocating descriptor sets |
| 7151 | static void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, |
Tobin Ehlis | 68d0adf | 2016-06-01 11:33:50 -0600 | [diff] [blame] | 7152 | VkDescriptorSet *pDescriptorSets, |
| 7153 | const cvdescriptorset::AllocateDescriptorSetsData *common_data) { |
Tobin Ehlis | ee47146 | 2016-05-26 11:21:59 -0600 | [diff] [blame] | 7154 | // All the updates are contained in a single cvdescriptorset function |
Tobin Ehlis | d5fb09e | 2016-06-02 10:54:09 -0600 | [diff] [blame] | 7155 | cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 7156 | &dev_data->setMap, dev_data); |
Chris Forbes | b3f6006 | 2016-05-23 11:29:51 +1200 | [diff] [blame] | 7157 | } |
| 7158 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7159 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7160 | AllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7161 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7162 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 68d0adf | 2016-06-01 11:33:50 -0600 | [diff] [blame] | 7163 | cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); |
| 7164 | bool skip_call = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7165 | lock.unlock(); |
Chris Forbes | 70858bb | 2016-05-20 17:12:39 +1200 | [diff] [blame] | 7166 | |
Tobin Ehlis | ee47146 | 2016-05-26 11:21:59 -0600 | [diff] [blame] | 7167 | if (skip_call) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7168 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | 70858bb | 2016-05-20 17:12:39 +1200 | [diff] [blame] | 7169 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7170 | VkResult result = dev_data->dispatch_table.AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); |
Chris Forbes | bc22feb | 2016-05-20 16:34:01 +1200 | [diff] [blame] | 7171 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7172 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7173 | lock.lock(); |
Tobin Ehlis | 68d0adf | 2016-06-01 11:33:50 -0600 | [diff] [blame] | 7174 | PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7175 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7176 | } |
| 7177 | return result; |
| 7178 | } |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7179 | // Verify state before freeing DescriptorSets |
| 7180 | static bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, |
| 7181 | const VkDescriptorSet *descriptor_sets) { |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 7182 | if (dev_data->instance_data->disabled.free_descriptor_sets) |
Tobin Ehlis | f0e83a3 | 2016-10-06 14:16:14 -0600 | [diff] [blame] | 7183 | return false; |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7184 | bool skip_call = false; |
| 7185 | // First make sure sets being destroyed are not currently in-use |
| 7186 | for (uint32_t i = 0; i < count; ++i) |
| 7187 | skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); |
| 7188 | |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 7189 | DESCRIPTOR_POOL_STATE *pool_state = getDescriptorPoolState(dev_data, pool); |
| 7190 | if (pool_state && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_state->createInfo.flags)) { |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7191 | // Can't Free from a NON_FREE pool |
| 7192 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 7193 | reinterpret_cast<uint64_t &>(pool), __LINE__, VALIDATION_ERROR_00922, "DS", |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7194 | "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " |
Tobin Ehlis | bf98b69 | 2016-10-06 12:58:06 -0600 | [diff] [blame] | 7195 | "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT. %s", |
| 7196 | validation_error_map[VALIDATION_ERROR_00922]); |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7197 | } |
| 7198 | return skip_call; |
| 7199 | } |
| 7200 | // Sets have been removed from the pool so update underlying state |
| 7201 | static void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, |
| 7202 | const VkDescriptorSet *descriptor_sets) { |
Tobin Ehlis | bd711bd | 2016-10-12 14:27:30 -0600 | [diff] [blame] | 7203 | DESCRIPTOR_POOL_STATE *pool_state = getDescriptorPoolState(dev_data, pool); |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7204 | // Update available descriptor sets in pool |
| 7205 | pool_state->availableSets += count; |
| 7206 | |
| 7207 | // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap |
| 7208 | for (uint32_t i = 0; i < count; ++i) { |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7209 | auto descriptor_set = dev_data->setMap[descriptor_sets[i]]; |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7210 | uint32_t type_index = 0, descriptor_count = 0; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7211 | for (uint32_t j = 0; j < descriptor_set->GetBindingCount(); ++j) { |
| 7212 | type_index = static_cast<uint32_t>(descriptor_set->GetTypeFromIndex(j)); |
| 7213 | descriptor_count = descriptor_set->GetDescriptorCountFromIndex(j); |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7214 | pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; |
| 7215 | } |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7216 | freeDescriptorSet(dev_data, descriptor_set); |
| 7217 | pool_state->sets.erase(descriptor_set); |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7218 | } |
| 7219 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7220 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7221 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7222 | FreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7223 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 7224 | // Make sure that no sets being destroyed are in-flight |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7225 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7226 | bool skip_call = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7227 | lock.unlock(); |
Tobin Ehlis | 25e27ab | 2016-07-13 09:41:09 -0600 | [diff] [blame] | 7228 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7229 | if (skip_call) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7230 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7231 | VkResult result = dev_data->dispatch_table.FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7232 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7233 | lock.lock(); |
Tobin Ehlis | 2c76330 | 2016-05-26 13:30:45 -0600 | [diff] [blame] | 7234 | PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7235 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7236 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7237 | return result; |
| 7238 | } |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7239 | // TODO : This is a Proof-of-concept for core validation architecture |
| 7240 | // Really we'll want to break out these functions to separate files but |
| 7241 | // keeping it all together here to prove out design |
| 7242 | // PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() |
| 7243 | static bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, |
| 7244 | const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, |
| 7245 | const VkCopyDescriptorSet *pDescriptorCopies) { |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 7246 | if (dev_data->instance_data->disabled.update_descriptor_sets) |
Tobin Ehlis | c67108b | 2016-10-10 11:14:52 -0600 | [diff] [blame] | 7247 | return false; |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7248 | // First thing to do is perform map look-ups. |
| 7249 | // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets |
| 7250 | // so we can't just do a single map look-up up-front, but do them individually in functions below |
| 7251 | |
| 7252 | // Now make call(s) that validate state, but don't perform state updates in this function |
| 7253 | // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the |
| 7254 | // namespace which will parse params and make calls into specific class instances |
Tobin Ehlis | 6a72dc7 | 2016-06-01 16:41:17 -0600 | [diff] [blame] | 7255 | return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, |
| 7256 | descriptorCopyCount, pDescriptorCopies); |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7257 | } |
| 7258 | // PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() |
| 7259 | static void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, |
| 7260 | const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, |
| 7261 | const VkCopyDescriptorSet *pDescriptorCopies) { |
Tobin Ehlis | 6a72dc7 | 2016-06-01 16:41:17 -0600 | [diff] [blame] | 7262 | cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7263 | pDescriptorCopies); |
| 7264 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7265 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7266 | VKAPI_ATTR void VKAPI_CALL |
| 7267 | UpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, |
| 7268 | uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7269 | // Only map look-up at top level is for device-level layer_data |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7270 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7271 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7272 | bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
| 7273 | pDescriptorCopies); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7274 | lock.unlock(); |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7275 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7276 | dev_data->dispatch_table.UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
| 7277 | pDescriptorCopies); |
Tobin Ehlis | 300888c | 2016-05-18 13:43:26 -0600 | [diff] [blame] | 7278 | lock.lock(); |
| 7279 | // Since UpdateDescriptorSets() is void, nothing to check prior to updating state |
| 7280 | PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, |
| 7281 | pDescriptorCopies); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7282 | } |
| 7283 | } |
| 7284 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7285 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7286 | AllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7287 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7288 | VkResult result = dev_data->dispatch_table.AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7289 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7290 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | c25c845 | 2016-06-21 14:32:00 +1200 | [diff] [blame] | 7291 | auto pPool = getCommandPoolNode(dev_data, pCreateInfo->commandPool); |
| 7292 | |
| 7293 | if (pPool) { |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7294 | for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7295 | // Add command buffer to its commandPool map |
Chris Forbes | c25c845 | 2016-06-21 14:32:00 +1200 | [diff] [blame] | 7296 | pPool->commandBuffers.push_back(pCommandBuffer[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7297 | GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; |
| 7298 | // Add command buffer to map |
| 7299 | dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; |
| 7300 | resetCB(dev_data, pCommandBuffer[i]); |
| 7301 | pCB->createInfo = *pCreateInfo; |
| 7302 | pCB->device = device; |
| 7303 | } |
| 7304 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7305 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7306 | } |
| 7307 | return result; |
| 7308 | } |
| 7309 | |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 7310 | // Add bindings between the given cmd buffer & framebuffer and the framebuffer's children |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 7311 | static void AddFramebufferBinding(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, FRAMEBUFFER_STATE *fb_state) { |
Tobin Ehlis | e5df29e | 2016-10-12 13:18:20 -0600 | [diff] [blame] | 7312 | addCommandBufferBinding(&fb_state->cb_bindings, |
| 7313 | {reinterpret_cast<uint64_t &>(fb_state->framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}, |
| 7314 | cb_state); |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 7315 | for (auto attachment : fb_state->attachments) { |
| 7316 | auto view_state = attachment.view_state; |
| 7317 | if (view_state) { |
Tobin Ehlis | 15b8ea0 | 2016-09-19 14:02:58 -0600 | [diff] [blame] | 7318 | AddCommandBufferBindingImageView(dev_data, cb_state, view_state); |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 7319 | } |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 7320 | auto rp_state = getRenderPassState(dev_data, fb_state->createInfo.renderPass); |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 7321 | if (rp_state) { |
| 7322 | addCommandBufferBinding( |
| 7323 | &rp_state->cb_bindings, |
| 7324 | {reinterpret_cast<uint64_t &>(rp_state->renderPass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}, cb_state); |
| 7325 | } |
| 7326 | } |
| 7327 | } |
| 7328 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7329 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7330 | BeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7331 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7332 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7333 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7334 | // Validate command buffer level |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7335 | GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); |
| 7336 | if (cb_node) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7337 | // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 7338 | if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7339 | skip_call |= |
Tobin Ehlis | aff7ae9 | 2016-04-18 15:45:20 -0600 | [diff] [blame] | 7340 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7341 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_00104, "MEM", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7342 | "Calling vkBeginCommandBuffer() on active command buffer 0x%p before it has completed. " |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7343 | "You must check command buffer fence before this call. %s", |
| 7344 | commandBuffer, validation_error_map[VALIDATION_ERROR_00104]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7345 | } |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7346 | clear_cmd_buf_and_mem_references(dev_data, cb_node); |
| 7347 | if (cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7348 | // Secondary Command Buffer |
| 7349 | const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; |
| 7350 | if (!pInfo) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7351 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7352 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7353 | reinterpret_cast<uint64_t>(commandBuffer), __LINE__, VALIDATION_ERROR_00106, "DS", |
| 7354 | "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info. %s", |
| 7355 | commandBuffer, validation_error_map[VALIDATION_ERROR_00106]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7356 | } else { |
| 7357 | if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { |
Tobin Ehlis | 8fc7df2 | 2017-01-04 09:21:17 -0700 | [diff] [blame] | 7358 | // Object_tracker makes sure these objects are valid |
| 7359 | assert(pInfo->renderPass); |
| 7360 | assert(pInfo->framebuffer); |
| 7361 | string errorString = ""; |
| 7362 | auto framebuffer = getFramebufferState(dev_data, pInfo->framebuffer); |
| 7363 | if (framebuffer) { |
| 7364 | if ((framebuffer->createInfo.renderPass != pInfo->renderPass) && |
| 7365 | !verify_renderpass_compatibility(dev_data, framebuffer->renderPassCreateInfo.ptr(), |
| 7366 | getRenderPassState(dev_data, pInfo->renderPass)->createInfo.ptr(), |
| 7367 | errorString)) { |
| 7368 | // renderPass that framebuffer was created with must be compatible with local renderPass |
| 7369 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7370 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 7371 | reinterpret_cast<uint64_t>(commandBuffer), __LINE__, VALIDATION_ERROR_00112, "DS", |
| 7372 | "vkBeginCommandBuffer(): Secondary Command " |
| 7373 | "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " |
| 7374 | "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s. %s", |
| 7375 | commandBuffer, reinterpret_cast<const uint64_t &>(pInfo->renderPass), |
| 7376 | reinterpret_cast<const uint64_t &>(pInfo->framebuffer), |
| 7377 | reinterpret_cast<uint64_t &>(framebuffer->createInfo.renderPass), |
| 7378 | errorString.c_str(), validation_error_map[VALIDATION_ERROR_00112]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7379 | } |
Tobin Ehlis | 8fc7df2 | 2017-01-04 09:21:17 -0700 | [diff] [blame] | 7380 | // Connect this framebuffer and its children to this cmdBuffer |
| 7381 | AddFramebufferBinding(dev_data, cb_node, framebuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7382 | } |
| 7383 | } |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7384 | if ((pInfo->occlusionQueryEnable == VK_FALSE || dev_data->enabled_features.occlusionQueryPrecise == VK_FALSE) && |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7385 | (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7386 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7387 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7388 | __LINE__, VALIDATION_ERROR_00107, "DS", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7389 | "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " |
| 7390 | "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7391 | "support precise occlusion queries. %s", |
| 7392 | commandBuffer, validation_error_map[VALIDATION_ERROR_00107]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7393 | } |
| 7394 | } |
| 7395 | if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 7396 | auto renderPass = getRenderPassState(dev_data, pInfo->renderPass); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 7397 | if (renderPass) { |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 7398 | if (pInfo->subpass >= renderPass->createInfo.subpassCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7399 | skip_call |= log_msg( |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7400 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7401 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 7402 | VALIDATION_ERROR_00111, "DS", |
| 7403 | "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must have a subpass index (%d) " |
| 7404 | "that is less than the number of subpasses (%d). %s", |
| 7405 | commandBuffer, pInfo->subpass, renderPass->createInfo.subpassCount, |
| 7406 | validation_error_map[VALIDATION_ERROR_00111]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7407 | } |
| 7408 | } |
| 7409 | } |
| 7410 | } |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7411 | if (CB_RECORDING == cb_node->state) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7412 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7413 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7414 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_00103, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 7415 | "vkBeginCommandBuffer(): Cannot call Begin on command buffer (0x%p" |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7416 | ") in the RECORDING state. Must first call vkEndCommandBuffer(). %s", |
| 7417 | commandBuffer, validation_error_map[VALIDATION_ERROR_00103]); |
Chris Forbes | e46e0a1 | 2016-12-20 11:33:11 +1300 | [diff] [blame] | 7418 | } else if (CB_RECORDED == cb_node->state || (CB_INVALID == cb_node->state && CMD_END == cb_node->last_cmd)) { |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7419 | VkCommandPool cmdPool = cb_node->createInfo.commandPool; |
Chris Forbes | c25c845 | 2016-06-21 14:32:00 +1200 | [diff] [blame] | 7420 | auto pPool = getCommandPoolNode(dev_data, cmdPool); |
| 7421 | if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7422 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7423 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7424 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_00105, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 7425 | "Call to vkBeginCommandBuffer() on command buffer (0x%p" |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7426 | ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7427 | ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set. %s", |
| 7428 | commandBuffer, (uint64_t)cmdPool, validation_error_map[VALIDATION_ERROR_00105]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7429 | } |
| 7430 | resetCB(dev_data, commandBuffer); |
| 7431 | } |
| 7432 | // Set updated state here in case implicit reset occurs above |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7433 | cb_node->state = CB_RECORDING; |
| 7434 | cb_node->beginInfo = *pBeginInfo; |
| 7435 | if (cb_node->beginInfo.pInheritanceInfo) { |
| 7436 | cb_node->inheritanceInfo = *(cb_node->beginInfo.pInheritanceInfo); |
| 7437 | cb_node->beginInfo.pInheritanceInfo = &cb_node->inheritanceInfo; |
Mark Young | 75c4359 | 2016-05-06 13:48:26 -0600 | [diff] [blame] | 7438 | // If we are a secondary command-buffer and inheriting. Update the items we should inherit. |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7439 | if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && |
| 7440 | (cb_node->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 7441 | cb_node->activeRenderPass = getRenderPassState(dev_data, cb_node->beginInfo.pInheritanceInfo->renderPass); |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7442 | cb_node->activeSubpass = cb_node->beginInfo.pInheritanceInfo->subpass; |
Tobin Ehlis | 3d91631 | 2016-11-03 07:26:28 -0600 | [diff] [blame] | 7443 | cb_node->activeFramebuffer = cb_node->beginInfo.pInheritanceInfo->framebuffer; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 7444 | cb_node->framebuffers.insert(cb_node->beginInfo.pInheritanceInfo->framebuffer); |
Mark Young | 75c4359 | 2016-05-06 13:48:26 -0600 | [diff] [blame] | 7445 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7446 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7447 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7448 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7449 | if (skip_call) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7450 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 7451 | } |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7452 | VkResult result = dev_data->dispatch_table.BeginCommandBuffer(commandBuffer, pBeginInfo); |
Tobin Ehlis | 4c52232 | 2016-04-11 16:39:29 -0600 | [diff] [blame] | 7453 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7454 | return result; |
| 7455 | } |
| 7456 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7457 | VKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7458 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7459 | VkResult result = VK_SUCCESS; |
| 7460 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7461 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7462 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7463 | if (pCB) { |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7464 | if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || |
| 7465 | !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { |
Cody Northrop | 3bb4d96 | 2016-05-09 16:15:57 -0600 | [diff] [blame] | 7466 | // This needs spec clarification to update valid usage, see comments in PR: |
| 7467 | // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 7468 | skip_call |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer()", VALIDATION_ERROR_00123); |
Cody Northrop | 3bb4d96 | 2016-05-09 16:15:57 -0600 | [diff] [blame] | 7469 | } |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7470 | skip_call |= ValidateCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); |
| 7471 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_END); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7472 | for (auto query : pCB->activeQueries) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7473 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7474 | VALIDATION_ERROR_00124, "DS", |
| 7475 | "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d. %s", |
| 7476 | (uint64_t)(query.pool), query.index, validation_error_map[VALIDATION_ERROR_00124]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7477 | } |
| 7478 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7479 | if (!skip_call) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7480 | lock.unlock(); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7481 | result = dev_data->dispatch_table.EndCommandBuffer(commandBuffer); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7482 | lock.lock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7483 | if (VK_SUCCESS == result) { |
| 7484 | pCB->state = CB_RECORDED; |
| 7485 | // Reset CB status flags |
| 7486 | pCB->status = 0; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7487 | } |
| 7488 | } else { |
| 7489 | result = VK_ERROR_VALIDATION_FAILED_EXT; |
| 7490 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7491 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7492 | return result; |
| 7493 | } |
| 7494 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7495 | VKAPI_ATTR VkResult VKAPI_CALL |
| 7496 | ResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 7497 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7498 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7499 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7500 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7501 | VkCommandPool cmdPool = pCB->createInfo.commandPool; |
Chris Forbes | c25c845 | 2016-06-21 14:32:00 +1200 | [diff] [blame] | 7502 | auto pPool = getCommandPoolNode(dev_data, cmdPool); |
| 7503 | if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 7504 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7505 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_00093, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 7506 | "Attempt to reset command buffer (0x%p) created from command pool (0x%" PRIxLEAST64 |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7507 | ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set. %s", |
| 7508 | commandBuffer, (uint64_t)cmdPool, validation_error_map[VALIDATION_ERROR_00093]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7509 | } |
Tobin Ehlis | 9a9f7a2 | 2016-10-20 07:43:15 -0600 | [diff] [blame] | 7510 | skip_call |= checkCommandBufferInFlight(dev_data, pCB, "reset", VALIDATION_ERROR_00092); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7511 | lock.unlock(); |
Tobin Ehlis | 739d62a | 2016-04-14 12:22:03 -0600 | [diff] [blame] | 7512 | if (skip_call) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7513 | return VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7514 | VkResult result = dev_data->dispatch_table.ResetCommandBuffer(commandBuffer, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7515 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7516 | lock.lock(); |
Chris Forbes | e30fb98 | 2016-06-21 12:35:16 +1200 | [diff] [blame] | 7517 | dev_data->globalInFlightCmdBuffers.erase(commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7518 | resetCB(dev_data, commandBuffer); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7519 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7520 | } |
| 7521 | return result; |
| 7522 | } |
Mark Lobodzinski | 188b230 | 2016-04-12 10:41:59 -0600 | [diff] [blame] | 7523 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7524 | VKAPI_ATTR void VKAPI_CALL |
| 7525 | CmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7526 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7527 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7528 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7529 | GLOBAL_CB_NODE *cb_state = getCBNode(dev_data, commandBuffer); |
| 7530 | if (cb_state) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7531 | skip |= ValidateCmd(dev_data, cb_state, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); |
| 7532 | UpdateCmdBufferLastCmd(dev_data, cb_state, CMD_BINDPIPELINE); |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7533 | if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (cb_state->activeRenderPass)) { |
| 7534 | skip |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7535 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
| 7536 | (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7537 | "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7538 | (uint64_t)pipeline, (uint64_t)cb_state->activeRenderPass->renderPass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7539 | } |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7540 | // TODO: VALIDATION_ERROR_00594 VALIDATION_ERROR_00596 |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7541 | |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7542 | PIPELINE_STATE *pipe_state = getPipelineState(dev_data, pipeline); |
| 7543 | if (pipe_state) { |
| 7544 | cb_state->lastBound[pipelineBindPoint].pipeline_state = pipe_state; |
| 7545 | set_cb_pso_status(cb_state, pipe_state); |
| 7546 | set_pipeline_state(pipe_state); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7547 | } else { |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7548 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, |
Dave Houlton | 197211a | 2016-12-23 15:26:29 -0700 | [diff] [blame] | 7549 | (uint64_t)pipeline, __LINE__, VALIDATION_ERROR_00600, "DS", |
| 7550 | "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist! %s", (uint64_t)(pipeline), |
| 7551 | validation_error_map[VALIDATION_ERROR_00600]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7552 | } |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7553 | addCommandBufferBinding(&pipe_state->cb_bindings, |
| 7554 | {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}, cb_state); |
| 7555 | if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { |
| 7556 | // Add binding for child renderpass |
| 7557 | auto rp_state = getRenderPassState(dev_data, pipe_state->graphicsPipelineCI.renderPass); |
| 7558 | if (rp_state) { |
| 7559 | addCommandBufferBinding( |
| 7560 | &rp_state->cb_bindings, |
| 7561 | {reinterpret_cast<uint64_t &>(rp_state->renderPass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}, cb_state); |
| 7562 | } |
| 7563 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7564 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7565 | lock.unlock(); |
Tobin Ehlis | d3d0746 | 2016-10-26 14:30:06 -0600 | [diff] [blame] | 7566 | if (!skip) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7567 | dev_data->dispatch_table.CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7568 | } |
| 7569 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7570 | VKAPI_ATTR void VKAPI_CALL |
| 7571 | CmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7572 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7573 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7574 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7575 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7576 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7577 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); |
| 7578 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE); |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 7579 | pCB->viewportMask |= ((1u<<viewportCount) - 1u) << firstViewport; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7580 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7581 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7582 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7583 | dev_data->dispatch_table.CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7584 | } |
| 7585 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7586 | VKAPI_ATTR void VKAPI_CALL |
| 7587 | CmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7588 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7589 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7590 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7591 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7592 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7593 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); |
| 7594 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETSCISSORSTATE); |
Chris Forbes | 5fc7783 | 2016-07-28 14:15:38 +1200 | [diff] [blame] | 7595 | pCB->scissorMask |= ((1u<<scissorCount) - 1u) << firstScissor; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7596 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7597 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7598 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7599 | dev_data->dispatch_table.CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7600 | } |
| 7601 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7602 | VKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 7603 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7604 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7605 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7606 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7607 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7608 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); |
| 7609 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7610 | pCB->status |= CBSTATUS_LINE_WIDTH_SET; |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 7611 | |
Tobin Ehlis | 52c76a3 | 2016-10-12 09:05:51 -0600 | [diff] [blame] | 7612 | PIPELINE_STATE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_state; |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 7613 | if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { |
| 7614 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7615 | reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, VALIDATION_ERROR_01476, "DS", |
baldurk | 209ccda | 2016-05-05 16:31:05 +0200 | [diff] [blame] | 7616 | "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7617 | "flag. This is undefined behavior and could be ignored. %s", |
| 7618 | validation_error_map[VALIDATION_ERROR_01476]); |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 7619 | } else { |
| 7620 | skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); |
| 7621 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7622 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7623 | lock.unlock(); |
Mark Young | 7394fdd | 2016-03-31 14:56:43 -0600 | [diff] [blame] | 7624 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7625 | dev_data->dispatch_table.CmdSetLineWidth(commandBuffer, lineWidth); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7626 | } |
| 7627 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7628 | VKAPI_ATTR void VKAPI_CALL |
| 7629 | CmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7630 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7631 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7632 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7633 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7634 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7635 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); |
| 7636 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7637 | pCB->status |= CBSTATUS_DEPTH_BIAS_SET; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7638 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7639 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7640 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7641 | dev_data->dispatch_table.CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, depthBiasSlopeFactor); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7642 | } |
| 7643 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7644 | VKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7645 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7646 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7647 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7648 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7649 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7650 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); |
| 7651 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETBLENDSTATE); |
Tobin Ehlis | 7a1d235 | 2016-03-28 11:18:19 -0600 | [diff] [blame] | 7652 | pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7653 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7654 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7655 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7656 | dev_data->dispatch_table.CmdSetBlendConstants(commandBuffer, blendConstants); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7657 | } |
| 7658 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7659 | VKAPI_ATTR void VKAPI_CALL |
| 7660 | CmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7661 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7662 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7663 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7664 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7665 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7666 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); |
| 7667 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7668 | pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7669 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7670 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7671 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7672 | dev_data->dispatch_table.CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7673 | } |
| 7674 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7675 | VKAPI_ATTR void VKAPI_CALL |
| 7676 | CmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7677 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7678 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7679 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7680 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7681 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7682 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); |
| 7683 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7684 | pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; |
| 7685 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7686 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7687 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7688 | dev_data->dispatch_table.CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7689 | } |
| 7690 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7691 | VKAPI_ATTR void VKAPI_CALL |
| 7692 | CmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7693 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7694 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7695 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7696 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7697 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7698 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); |
| 7699 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7700 | pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; |
| 7701 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7702 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7703 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7704 | dev_data->dispatch_table.CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7705 | } |
| 7706 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7707 | VKAPI_ATTR void VKAPI_CALL |
| 7708 | CmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7709 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7710 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7711 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7712 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7713 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7714 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); |
| 7715 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7716 | pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; |
| 7717 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7718 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7719 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7720 | dev_data->dispatch_table.CmdSetStencilReference(commandBuffer, faceMask, reference); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7721 | } |
| 7722 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7723 | VKAPI_ATTR void VKAPI_CALL |
| 7724 | CmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, |
| 7725 | uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, |
| 7726 | const uint32_t *pDynamicOffsets) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7727 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7728 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7729 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7730 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 7731 | if (pCB) { |
| 7732 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7733 | // Track total count of dynamic descriptor types to make sure we have an offset for each one |
| 7734 | uint32_t totalDynamicDescriptors = 0; |
| 7735 | string errorString = ""; |
| 7736 | uint32_t lastSetIndex = firstSet + setCount - 1; |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7737 | if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7738 | pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7739 | pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); |
| 7740 | } |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 7741 | auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; |
Tobin Ehlis | c1d9be1 | 2016-10-13 10:18:18 -0600 | [diff] [blame] | 7742 | auto pipeline_layout = getPipelineLayout(dev_data, layout); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7743 | for (uint32_t i = 0; i < setCount; i++) { |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7744 | cvdescriptorset::DescriptorSet *descriptor_set = getSetNode(dev_data, pDescriptorSets[i]); |
| 7745 | if (descriptor_set) { |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 7746 | pCB->lastBound[pipelineBindPoint].pipeline_layout = *pipeline_layout; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7747 | pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = descriptor_set; |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7748 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, |
| 7749 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7750 | DRAWSTATE_NONE, "DS", "Descriptor Set 0x%" PRIxLEAST64 " bound on pipeline %s", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7751 | (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7752 | if (!descriptor_set->IsUpdated() && (descriptor_set->GetTotalDescriptorCount() != 0)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7753 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 7754 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, |
| 7755 | DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7756 | "Descriptor Set 0x%" PRIxLEAST64 |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7757 | " bound but it was never updated. You may want to either update it or not bind it.", |
| 7758 | (uint64_t)pDescriptorSets[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7759 | } |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7760 | // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7761 | if (!verify_set_layout_compatibility(dev_data, descriptor_set, pipeline_layout, i + firstSet, errorString)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7762 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7763 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7764 | VALIDATION_ERROR_00974, "DS", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7765 | "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7766 | "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s. %s", |
| 7767 | i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str(), |
| 7768 | validation_error_map[VALIDATION_ERROR_00974]); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7769 | } |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7770 | |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7771 | auto setDynamicDescriptorCount = descriptor_set->GetDynamicDescriptorCount(); |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7772 | |
| 7773 | pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); |
| 7774 | |
| 7775 | if (setDynamicDescriptorCount) { |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7776 | // First make sure we won't overstep bounds of pDynamicOffsets array |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7777 | if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7778 | skip_call |= |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7779 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7780 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, |
| 7781 | DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7782 | "descriptorSet #%u (0x%" PRIxLEAST64 |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7783 | ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " |
| 7784 | "array. There must be one dynamic offset for each dynamic descriptor being bound.", |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7785 | i, (uint64_t)pDescriptorSets[i], descriptor_set->GetDynamicDescriptorCount(), |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7786 | (dynamicOffsetCount - totalDynamicDescriptors)); |
| 7787 | } else { // Validate and store dynamic offsets with the set |
| 7788 | // Validate Dynamic Offset Minimums |
| 7789 | uint32_t cur_dyn_offset = totalDynamicDescriptors; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7790 | for (uint32_t d = 0; d < descriptor_set->GetTotalDescriptorCount(); d++) { |
| 7791 | if (descriptor_set->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7792 | if (vk_safe_modulo( |
| 7793 | pDynamicOffsets[cur_dyn_offset], |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 7794 | dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7795 | skip_call |= log_msg( |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7796 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7797 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, VALIDATION_ERROR_00978, |
| 7798 | "DS", "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " |
| 7799 | "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64 ". %s", |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7800 | cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7801 | dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, |
| 7802 | validation_error_map[VALIDATION_ERROR_00978]); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7803 | } |
| 7804 | cur_dyn_offset++; |
Tobin Ehlis | 1a0afbf | 2016-12-29 12:40:16 -0700 | [diff] [blame] | 7805 | } else if (descriptor_set->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7806 | if (vk_safe_modulo( |
| 7807 | pDynamicOffsets[cur_dyn_offset], |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 7808 | dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7809 | skip_call |= log_msg( |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7810 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7811 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, VALIDATION_ERROR_00978, |
| 7812 | "DS", "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " |
| 7813 | "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64 ". %s", |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7814 | cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7815 | dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment, |
| 7816 | validation_error_map[VALIDATION_ERROR_00978]); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7817 | } |
| 7818 | cur_dyn_offset++; |
| 7819 | } |
| 7820 | } |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7821 | |
| 7822 | pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = |
| 7823 | std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, |
| 7824 | pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7825 | // Keep running total of dynamic descriptor count to verify at the end |
Chris Forbes | 0b03b93 | 2016-05-16 14:09:35 +1200 | [diff] [blame] | 7826 | totalDynamicDescriptors += setDynamicDescriptorCount; |
| 7827 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7828 | } |
| 7829 | } |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7830 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7831 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 7832 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7833 | DRAWSTATE_INVALID_SET, "DS", "Attempt to bind descriptor set 0x%" PRIxLEAST64 |
| 7834 | " that doesn't exist!", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7835 | (uint64_t)pDescriptorSets[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7836 | } |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7837 | skip_call |= ValidateCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); |
| 7838 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS); |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7839 | // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update |
| 7840 | if (firstSet > 0) { // Check set #s below the first bound set |
| 7841 | for (uint32_t i = 0; i < firstSet; ++i) { |
| 7842 | if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 7843 | !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 7844 | pipeline_layout, i, errorString)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7845 | skip_call |= log_msg( |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7846 | dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 7847 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, |
| 7848 | (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7849 | "DescriptorSet 0x%" PRIxLEAST64 |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7850 | " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7851 | (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); |
| 7852 | pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; |
| 7853 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7854 | } |
| 7855 | } |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7856 | // Check if newly last bound set invalidates any remaining bound sets |
| 7857 | if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { |
| 7858 | if (oldFinalBoundSet && |
Tobin Ehlis | 0fc8567 | 2016-07-07 11:06:26 -0600 | [diff] [blame] | 7859 | !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, pipeline_layout, lastSetIndex, errorString)) { |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 7860 | auto old_set = oldFinalBoundSet->GetSet(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7861 | skip_call |= |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7862 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 7863 | VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, |
Mike Weiblen | cce7ec7 | 2016-10-17 19:33:05 -0600 | [diff] [blame] | 7864 | DRAWSTATE_NONE, "DS", "DescriptorSet 0x%" PRIxLEAST64 |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7865 | " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7866 | " newly bound as set #%u so set #%u and any subsequent sets were " |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 7867 | "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", |
Tobin Ehlis | 09d1671 | 2016-05-17 10:41:55 -0600 | [diff] [blame] | 7868 | reinterpret_cast<uint64_t &>(old_set), lastSetIndex, |
Tobin Ehlis | 223b01e | 2016-03-21 14:14:44 -0600 | [diff] [blame] | 7869 | (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, |
| 7870 | lastSetIndex + 1, (uint64_t)layout); |
| 7871 | pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); |
| 7872 | } |
| 7873 | } |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7874 | } |
| 7875 | // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound |
| 7876 | if (totalDynamicDescriptors != dynamicOffsetCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7877 | skip_call |= |
| 7878 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7879 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_00975, "DS", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7880 | "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 7881 | "is %u. It should exactly match the number of dynamic descriptors. %s", |
| 7882 | setCount, totalDynamicDescriptors, dynamicOffsetCount, validation_error_map[VALIDATION_ERROR_00975]); |
Tobin Ehlis | 285a828 | 2016-03-17 13:37:40 -0600 | [diff] [blame] | 7883 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7884 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7885 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7886 | } |
| 7887 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7888 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7889 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7890 | dev_data->dispatch_table.CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, |
| 7891 | pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7892 | } |
| 7893 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7894 | VKAPI_ATTR void VKAPI_CALL |
| 7895 | CmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7896 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7897 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 7898 | // TODO : Somewhere need to verify that IBs have correct usage state flagged |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7899 | std::unique_lock<std::mutex> lock(global_lock); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 7900 | |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7901 | auto buffer_state = getBufferState(dev_data, buffer); |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7902 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7903 | if (cb_node && buffer_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 7904 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buffer_state, "vkCmdBindIndexBuffer()", VALIDATION_ERROR_02543); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 7905 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7906 | return ValidateBufferMemoryIsValid(dev_data, buffer_state, "vkCmdBindIndexBuffer()"); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 7907 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7908 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7909 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); |
| 7910 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7911 | VkDeviceSize offset_align = 0; |
| 7912 | switch (indexType) { |
| 7913 | case VK_INDEX_TYPE_UINT16: |
| 7914 | offset_align = 2; |
| 7915 | break; |
| 7916 | case VK_INDEX_TYPE_UINT32: |
| 7917 | offset_align = 4; |
| 7918 | break; |
| 7919 | default: |
| 7920 | // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 |
| 7921 | break; |
| 7922 | } |
| 7923 | if (!offset_align || (offset % offset_align)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7924 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 7925 | DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", |
| 7926 | "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", |
| 7927 | offset, string_VkIndexType(indexType)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7928 | } |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7929 | cb_node->status |= CBSTATUS_INDEX_BUFFER_BOUND; |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 7930 | } else { |
| 7931 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7932 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7933 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7934 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7935 | dev_data->dispatch_table.CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7936 | } |
| 7937 | |
| 7938 | void updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { |
| 7939 | uint32_t end = firstBinding + bindingCount; |
| 7940 | if (pCB->currentDrawData.buffers.size() < end) { |
| 7941 | pCB->currentDrawData.buffers.resize(end); |
| 7942 | } |
| 7943 | for (uint32_t i = 0; i < bindingCount; ++i) { |
| 7944 | pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; |
| 7945 | } |
| 7946 | } |
| 7947 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 7948 | static inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7949 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 7950 | VKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, |
| 7951 | uint32_t bindingCount, const VkBuffer *pBuffers, |
| 7952 | const VkDeviceSize *pOffsets) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7953 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7954 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 7955 | // TODO : Somewhere need to verify that VBs have correct usage state flagged |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7956 | std::unique_lock<std::mutex> lock(global_lock); |
Mark Lobodzinski | 0dcf272 | 2016-07-14 09:54:11 -0600 | [diff] [blame] | 7957 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7958 | auto cb_node = getCBNode(dev_data, commandBuffer); |
| 7959 | if (cb_node) { |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 7960 | for (uint32_t i = 0; i < bindingCount; ++i) { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7961 | auto buffer_state = getBufferState(dev_data, pBuffers[i]); |
| 7962 | assert(buffer_state); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 7963 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buffer_state, "vkCmdBindVertexBuffers()", VALIDATION_ERROR_02546); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 7964 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7965 | return ValidateBufferMemoryIsValid(dev_data, buffer_state, "vkCmdBindVertexBuffers()"); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 7966 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7967 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7968 | } |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 7969 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); |
| 7970 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFER); |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 7971 | updateResourceTracking(cb_node, firstBinding, bindingCount, pBuffers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7972 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7973 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7974 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 7975 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 7976 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 7977 | dev_data->dispatch_table.CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7978 | } |
| 7979 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 7980 | // Expects global_lock to be held by caller |
Tobin Ehlis | 5558ecb | 2016-12-19 15:16:37 -0700 | [diff] [blame] | 7981 | static void MarkStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { |
Tobin Ehlis | 2e319d4 | 2016-03-25 11:49:51 -0600 | [diff] [blame] | 7982 | for (auto imageView : pCB->updateImages) { |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 7983 | auto view_state = getImageViewState(dev_data, imageView); |
| 7984 | if (!view_state) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 7985 | continue; |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 7986 | |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 7987 | auto image_state = getImageState(dev_data, view_state->create_info.image); |
| 7988 | assert(image_state); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 7989 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 7990 | SetImageMemoryValid(dev_data, image_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 7991 | return false; |
Tobin Ehlis | 2e319d4 | 2016-03-25 11:49:51 -0600 | [diff] [blame] | 7992 | }; |
| 7993 | pCB->validate_functions.push_back(function); |
| 7994 | } |
| 7995 | for (auto buffer : pCB->updateBuffers) { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7996 | auto buffer_state = getBufferState(dev_data, buffer); |
| 7997 | assert(buffer_state); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 7998 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 7999 | SetBufferMemoryValid(dev_data, buffer_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8000 | return false; |
Tobin Ehlis | 2e319d4 | 2016-03-25 11:49:51 -0600 | [diff] [blame] | 8001 | }; |
| 8002 | pCB->validate_functions.push_back(function); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8003 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8004 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8005 | |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8006 | // Generic function to handle validation for all CmdDraw* type functions |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8007 | static bool ValidateCmdDrawType(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, VkPipelineBindPoint bind_point, |
| 8008 | CMD_TYPE cmd_type, GLOBAL_CB_NODE **cb_state, const char *caller, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8009 | UNIQUE_VALIDATION_ERROR_CODE msg_code, UNIQUE_VALIDATION_ERROR_CODE const dynamic_state_msg_code) { |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8010 | bool skip = false; |
| 8011 | *cb_state = getCBNode(dev_data, cmd_buffer); |
| 8012 | if (*cb_state) { |
| 8013 | skip |= ValidateCmd(dev_data, *cb_state, cmd_type, caller); |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8014 | skip |= ValidateDrawState(dev_data, *cb_state, indexed, bind_point, caller, dynamic_state_msg_code); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8015 | skip |= (VK_PIPELINE_BIND_POINT_GRAPHICS == bind_point) ? outsideRenderPass(dev_data, *cb_state, caller, msg_code) |
| 8016 | : insideRenderPass(dev_data, *cb_state, caller, msg_code); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8017 | } |
| 8018 | return skip; |
| 8019 | } |
| 8020 | |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8021 | // Generic function to handle state update for all CmdDraw* and CmdDispatch* type functions |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8022 | static void UpdateStateCmdDrawDispatchType(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| 8023 | CMD_TYPE cmd_type) { |
| 8024 | UpdateDrawState(dev_data, cb_state, bind_point); |
Tobin Ehlis | 7afd781 | 2016-12-28 14:24:47 -0700 | [diff] [blame] | 8025 | MarkStoreImagesAndBuffersAsWritten(dev_data, cb_state); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8026 | UpdateCmdBufferLastCmd(dev_data, cb_state, cmd_type); |
| 8027 | } |
| 8028 | |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8029 | // Generic function to handle state update for all CmdDraw* type functions |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8030 | static void UpdateStateCmdDrawType(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| 8031 | CMD_TYPE cmd_type, DRAW_TYPE draw_type) { |
| 8032 | UpdateStateCmdDrawDispatchType(dev_data, cb_state, bind_point, cmd_type); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8033 | updateResourceTrackingOnDraw(cb_state); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8034 | cb_state->drawCount[draw_type]++; |
| 8035 | } |
| 8036 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8037 | static bool PreCallValidateCmdDraw(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, VkPipelineBindPoint bind_point, |
| 8038 | GLOBAL_CB_NODE **cb_state, const char *caller) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8039 | return ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAW, cb_state, caller, VALIDATION_ERROR_01365, |
| 8040 | VALIDATION_ERROR_02203); |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 8041 | } |
| 8042 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8043 | static void PostCallRecordCmdDraw(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| 8044 | UpdateStateCmdDrawType(dev_data, cb_state, bind_point, CMD_DRAW, DRAW); |
Tobin Ehlis | 1813240 | 2016-12-21 07:52:20 -0700 | [diff] [blame] | 8045 | } |
| 8046 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8047 | VKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, |
| 8048 | uint32_t firstVertex, uint32_t firstInstance) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8049 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 8050 | GLOBAL_CB_NODE *cb_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8051 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8052 | bool skip = PreCallValidateCmdDraw(dev_data, commandBuffer, false, VK_PIPELINE_BIND_POINT_GRAPHICS, &cb_state, "vkCmdDraw()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8053 | lock.unlock(); |
Tobin Ehlis | 232017e | 2016-12-21 10:28:54 -0700 | [diff] [blame] | 8054 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8055 | dev_data->dispatch_table.CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); |
Tobin Ehlis | 1813240 | 2016-12-21 07:52:20 -0700 | [diff] [blame] | 8056 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8057 | PostCallRecordCmdDraw(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS); |
Tobin Ehlis | 1813240 | 2016-12-21 07:52:20 -0700 | [diff] [blame] | 8058 | lock.unlock(); |
| 8059 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8060 | } |
| 8061 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8062 | static bool PreCallValidateCmdDrawIndexed(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, |
| 8063 | VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, const char *caller) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8064 | return ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAWINDEXED, cb_state, caller, VALIDATION_ERROR_01372, |
| 8065 | VALIDATION_ERROR_02216); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8066 | } |
| 8067 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8068 | static void PostCallRecordCmdDrawIndexed(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| 8069 | UpdateStateCmdDrawType(dev_data, cb_state, bind_point, CMD_DRAWINDEXED, DRAW_INDEXED); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8070 | } |
| 8071 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8072 | VKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, |
| 8073 | uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8074 | uint32_t firstInstance) { |
| 8075 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8076 | GLOBAL_CB_NODE *cb_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8077 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8078 | bool skip = PreCallValidateCmdDrawIndexed(dev_data, commandBuffer, true, VK_PIPELINE_BIND_POINT_GRAPHICS, &cb_state, |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8079 | "vkCmdDrawIndexed()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8080 | lock.unlock(); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8081 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8082 | dev_data->dispatch_table.CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, firstInstance); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8083 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8084 | PostCallRecordCmdDrawIndexed(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS); |
Tobin Ehlis | 3f826bf | 2016-12-21 11:04:13 -0700 | [diff] [blame] | 8085 | lock.unlock(); |
| 8086 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8087 | } |
| 8088 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8089 | static bool PreCallValidateCmdDrawIndirect(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkBuffer buffer, bool indexed, |
| 8090 | VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, BUFFER_STATE **buffer_state, |
| 8091 | const char *caller) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8092 | bool skip = ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAWINDIRECT, cb_state, caller, |
| 8093 | VALIDATION_ERROR_01381, VALIDATION_ERROR_02234); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8094 | *buffer_state = getBufferState(dev_data, buffer); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8095 | skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_02544); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8096 | return skip; |
| 8097 | } |
| 8098 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8099 | static void PostCallRecordCmdDrawIndirect(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| 8100 | BUFFER_STATE *buffer_state) { |
| 8101 | UpdateStateCmdDrawType(dev_data, cb_state, bind_point, CMD_DRAWINDIRECT, DRAW_INDIRECT); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8102 | AddCommandBufferBindingBuffer(dev_data, cb_state, buffer_state); |
| 8103 | } |
| 8104 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8105 | VKAPI_ATTR void VKAPI_CALL |
| 8106 | CmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8107 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8108 | GLOBAL_CB_NODE *cb_state = nullptr; |
| 8109 | BUFFER_STATE *buffer_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8110 | std::unique_lock<std::mutex> lock(global_lock); |
Tony Barbour | 0725b0d | 2017-01-06 11:52:50 -0700 | [diff] [blame] | 8111 | bool skip = PreCallValidateCmdDrawIndirect(dev_data, commandBuffer, buffer, false, VK_PIPELINE_BIND_POINT_GRAPHICS, &cb_state, |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8112 | &buffer_state, "vkCmdDrawIndirect()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8113 | lock.unlock(); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8114 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8115 | dev_data->dispatch_table.CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8116 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8117 | PostCallRecordCmdDrawIndirect(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS, buffer_state); |
Tobin Ehlis | 52179ad | 2016-12-21 11:21:36 -0700 | [diff] [blame] | 8118 | lock.unlock(); |
| 8119 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8120 | } |
| 8121 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8122 | static bool PreCallValidateCmdDrawIndexedIndirect(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkBuffer buffer, bool indexed, |
| 8123 | VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, |
| 8124 | BUFFER_STATE **buffer_state, const char *caller) { |
| 8125 | bool skip = ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DRAWINDEXEDINDIRECT, cb_state, caller, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8126 | VALIDATION_ERROR_01393, VALIDATION_ERROR_02272); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8127 | *buffer_state = getBufferState(dev_data, buffer); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8128 | skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_02545); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8129 | return skip; |
| 8130 | } |
| 8131 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8132 | static void PostCallRecordCmdDrawIndexedIndirect(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| 8133 | BUFFER_STATE *buffer_state) { |
| 8134 | UpdateStateCmdDrawType(dev_data, cb_state, bind_point, CMD_DRAWINDEXEDINDIRECT, DRAW_INDEXED_INDIRECT); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8135 | AddCommandBufferBindingBuffer(dev_data, cb_state, buffer_state); |
| 8136 | } |
| 8137 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8138 | VKAPI_ATTR void VKAPI_CALL |
| 8139 | CmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8140 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8141 | GLOBAL_CB_NODE *cb_state = nullptr; |
| 8142 | BUFFER_STATE *buffer_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8143 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8144 | bool skip = PreCallValidateCmdDrawIndexedIndirect(dev_data, commandBuffer, buffer, true, VK_PIPELINE_BIND_POINT_GRAPHICS, |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8145 | &cb_state, &buffer_state, "vkCmdDrawIndexedIndirect()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8146 | lock.unlock(); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8147 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8148 | dev_data->dispatch_table.CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8149 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8150 | PostCallRecordCmdDrawIndexedIndirect(dev_data, cb_state, VK_PIPELINE_BIND_POINT_GRAPHICS, buffer_state); |
Tobin Ehlis | 4613263 | 2016-12-21 12:22:11 -0700 | [diff] [blame] | 8151 | lock.unlock(); |
| 8152 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8153 | } |
| 8154 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8155 | static bool PreCallValidateCmdDispatch(layer_data *dev_data, VkCommandBuffer cmd_buffer, bool indexed, |
| 8156 | VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, const char *caller) { |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8157 | return ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DISPATCH, cb_state, caller, VALIDATION_ERROR_01562, |
| 8158 | VALIDATION_ERROR_UNDEFINED); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8159 | } |
| 8160 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8161 | static void PostCallRecordCmdDispatch(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point) { |
| 8162 | UpdateStateCmdDrawDispatchType(dev_data, cb_state, bind_point, CMD_DISPATCH); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8163 | } |
| 8164 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8165 | VKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8166 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8167 | GLOBAL_CB_NODE *cb_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8168 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8169 | bool skip = |
| 8170 | PreCallValidateCmdDispatch(dev_data, commandBuffer, false, VK_PIPELINE_BIND_POINT_COMPUTE, &cb_state, "vkCmdDispatch()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8171 | lock.unlock(); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8172 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8173 | dev_data->dispatch_table.CmdDispatch(commandBuffer, x, y, z); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8174 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8175 | PostCallRecordCmdDispatch(dev_data, cb_state, VK_PIPELINE_BIND_POINT_COMPUTE); |
Tobin Ehlis | 2b82df8 | 2016-12-21 12:26:38 -0700 | [diff] [blame] | 8176 | lock.unlock(); |
| 8177 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8178 | } |
| 8179 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8180 | static bool PreCallValidateCmdDispatchIndirect(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkBuffer buffer, bool indexed, |
| 8181 | VkPipelineBindPoint bind_point, GLOBAL_CB_NODE **cb_state, |
| 8182 | BUFFER_STATE **buffer_state, const char *caller) { |
| 8183 | bool skip = ValidateCmdDrawType(dev_data, cmd_buffer, indexed, bind_point, CMD_DISPATCHINDIRECT, cb_state, caller, |
Jeremy Hayes | e258305 | 2016-12-12 11:01:28 -0700 | [diff] [blame] | 8184 | VALIDATION_ERROR_01569, VALIDATION_ERROR_UNDEFINED); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8185 | *buffer_state = getBufferState(dev_data, buffer); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8186 | skip |= ValidateMemoryIsBoundToBuffer(dev_data, *buffer_state, caller, VALIDATION_ERROR_02547); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8187 | return skip; |
| 8188 | } |
| 8189 | |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8190 | static void PostCallRecordCmdDispatchIndirect(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, VkPipelineBindPoint bind_point, |
| 8191 | BUFFER_STATE *buffer_state) { |
| 8192 | UpdateStateCmdDrawDispatchType(dev_data, cb_state, bind_point, CMD_DISPATCHINDIRECT); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8193 | AddCommandBufferBindingBuffer(dev_data, cb_state, buffer_state); |
| 8194 | } |
| 8195 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8196 | VKAPI_ATTR void VKAPI_CALL |
| 8197 | CmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8198 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8199 | GLOBAL_CB_NODE *cb_state = nullptr; |
| 8200 | BUFFER_STATE *buffer_state = nullptr; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8201 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 205f003 | 2016-12-29 11:39:10 -0700 | [diff] [blame] | 8202 | bool skip = PreCallValidateCmdDispatchIndirect(dev_data, commandBuffer, buffer, false, VK_PIPELINE_BIND_POINT_COMPUTE, |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8203 | &cb_state, &buffer_state, "vkCmdDispatchIndirect()"); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8204 | lock.unlock(); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8205 | if (!skip) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8206 | dev_data->dispatch_table.CmdDispatchIndirect(commandBuffer, buffer, offset); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8207 | lock.lock(); |
Tobin Ehlis | 022528b | 2016-12-29 12:22:32 -0700 | [diff] [blame] | 8208 | PostCallRecordCmdDispatchIndirect(dev_data, cb_state, VK_PIPELINE_BIND_POINT_COMPUTE, buffer_state); |
Tobin Ehlis | 4c54bde | 2016-12-21 12:37:16 -0700 | [diff] [blame] | 8209 | lock.unlock(); |
| 8210 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8211 | } |
| 8212 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8213 | VKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, |
| 8214 | uint32_t regionCount, const VkBufferCopy *pRegions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8215 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8216 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8217 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8218 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8219 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8220 | auto src_buff_state = getBufferState(dev_data, srcBuffer); |
| 8221 | auto dst_buff_state = getBufferState(dev_data, dstBuffer); |
| 8222 | if (cb_node && src_buff_state && dst_buff_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8223 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_state, "vkCmdCopyBuffer()", VALIDATION_ERROR_02531); |
| 8224 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdCopyBuffer()", VALIDATION_ERROR_02532); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8225 | // Update bindings between buffers and cmd buffer |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8226 | AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_state); |
| 8227 | AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8228 | // Validate that SRC & DST buffers have correct usage flags set |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8229 | skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_state, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8230 | VALIDATION_ERROR_01164, "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8231 | skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8232 | VALIDATION_ERROR_01165, "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8233 | |
| 8234 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8235 | return ValidateBufferMemoryIsValid(dev_data, src_buff_state, "vkCmdCopyBuffer()"); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8236 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8237 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8238 | function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8239 | SetBufferMemoryValid(dev_data, dst_buff_state, true); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8240 | return false; |
| 8241 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8242 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8243 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8244 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); |
| 8245 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_COPYBUFFER); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8246 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBuffer()", VALIDATION_ERROR_01172); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8247 | } else { |
| 8248 | // Param_checker will flag errors on invalid objects, just assert here as debugging aid |
| 8249 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8250 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8251 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8252 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8253 | dev_data->dispatch_table.CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8254 | } |
| 8255 | |
Tobin Ehlis | 6788382 | 2016-07-06 11:23:05 -0600 | [diff] [blame] | 8256 | static bool VerifySourceImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage srcImage, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8257 | VkImageSubresourceLayers subLayers, VkImageLayout srcImageLayout, |
| 8258 | UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8259 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8260 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8261 | for (uint32_t i = 0; i < subLayers.layerCount; ++i) { |
| 8262 | uint32_t layer = i + subLayers.baseArrayLayer; |
| 8263 | VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; |
| 8264 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
Tobin Ehlis | 6788382 | 2016-07-06 11:23:05 -0600 | [diff] [blame] | 8265 | if (!FindLayout(cb_node, srcImage, sub, node)) { |
| 8266 | SetLayout(cb_node, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8267 | continue; |
| 8268 | } |
| 8269 | if (node.layout != srcImageLayout) { |
| 8270 | // TODO: Improve log message in the next pass |
| 8271 | skip_call |= |
| 8272 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 8273 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " |
| 8274 | "and doesn't match the current layout %s.", |
| 8275 | string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); |
| 8276 | } |
| 8277 | } |
| 8278 | if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { |
| 8279 | if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { |
Tobin Ehlis | 4d68626 | 2016-07-06 11:32:12 -0600 | [diff] [blame] | 8280 | // TODO : Can we deal with image node from the top of call tree and avoid map look-up here? |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8281 | auto image_state = getImageState(dev_data, srcImage); |
| 8282 | if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { |
Tobin Ehlis | 4d68626 | 2016-07-06 11:32:12 -0600 | [diff] [blame] | 8283 | // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. |
| 8284 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 8285 | (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
| 8286 | "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); |
| 8287 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8288 | } else { |
| 8289 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8290 | msgCode, "DS", "Layout for input image is %s but can only be TRANSFER_SRC_OPTIMAL or GENERAL. %s", |
| 8291 | string_VkImageLayout(srcImageLayout), validation_error_map[msgCode]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8292 | } |
| 8293 | } |
| 8294 | return skip_call; |
| 8295 | } |
| 8296 | |
Tobin Ehlis | 6788382 | 2016-07-06 11:23:05 -0600 | [diff] [blame] | 8297 | static bool VerifyDestImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage destImage, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8298 | VkImageSubresourceLayers subLayers, VkImageLayout destImageLayout, |
| 8299 | UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8300 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8301 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8302 | for (uint32_t i = 0; i < subLayers.layerCount; ++i) { |
| 8303 | uint32_t layer = i + subLayers.baseArrayLayer; |
| 8304 | VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; |
| 8305 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
Tobin Ehlis | 6788382 | 2016-07-06 11:23:05 -0600 | [diff] [blame] | 8306 | if (!FindLayout(cb_node, destImage, sub, node)) { |
| 8307 | SetLayout(cb_node, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8308 | continue; |
| 8309 | } |
| 8310 | if (node.layout != destImageLayout) { |
| 8311 | skip_call |= |
| 8312 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 8313 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " |
| 8314 | "doesn't match the current layout %s.", |
| 8315 | string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); |
| 8316 | } |
| 8317 | } |
| 8318 | if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { |
| 8319 | if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8320 | auto image_state = getImageState(dev_data, destImage); |
| 8321 | if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { |
Tobin Ehlis | 4d68626 | 2016-07-06 11:32:12 -0600 | [diff] [blame] | 8322 | // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. |
| 8323 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 8324 | (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
| 8325 | "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); |
| 8326 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8327 | } else { |
| 8328 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8329 | msgCode, "DS", "Layout for output image is %s but can only be TRANSFER_DST_OPTIMAL or GENERAL. %s", |
| 8330 | string_VkImageLayout(destImageLayout), validation_error_map[msgCode]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8331 | } |
| 8332 | } |
| 8333 | return skip_call; |
| 8334 | } |
| 8335 | |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8336 | static bool VerifyClearImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage image, VkImageSubresourceRange range, |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8337 | VkImageLayout dest_image_layout, const char *func_name) { |
| 8338 | bool skip = false; |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8339 | |
| 8340 | VkImageSubresourceRange resolvedRange = range; |
| 8341 | ResolveRemainingLevelsLayers(dev_data, &resolvedRange, image); |
| 8342 | |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8343 | if (dest_image_layout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { |
| 8344 | if (dest_image_layout == VK_IMAGE_LAYOUT_GENERAL) { |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8345 | auto image_state = getImageState(dev_data, image); |
| 8346 | if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { |
| 8347 | // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8348 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, |
| 8349 | 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
| 8350 | "%s: Layout for cleared image should be TRANSFER_DST_OPTIMAL instead of GENERAL.", func_name); |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8351 | } |
| 8352 | } else { |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8353 | UNIQUE_VALIDATION_ERROR_CODE error_code = VALIDATION_ERROR_01086; |
| 8354 | if (strcmp(func_name, "vkCmdClearDepthStencilImage()") == 0) { |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8355 | error_code = VALIDATION_ERROR_01101; |
| 8356 | } else { |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8357 | assert(strcmp(func_name, "vkCmdClearColorImage()") == 0); |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8358 | } |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8359 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8360 | error_code, "DS", "%s: Layout for cleared image is %s but can only be " |
| 8361 | "TRANSFER_DST_OPTIMAL or GENERAL. %s", |
| 8362 | func_name, string_VkImageLayout(dest_image_layout), validation_error_map[error_code]); |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8363 | } |
| 8364 | } |
| 8365 | |
Karl Schultz | 537d8c2 | 2016-12-09 16:34:16 -0700 | [diff] [blame] | 8366 | for (uint32_t levelIdx = 0; levelIdx < resolvedRange.levelCount; ++levelIdx) { |
| 8367 | uint32_t level = levelIdx + resolvedRange.baseMipLevel; |
| 8368 | for (uint32_t layerIdx = 0; layerIdx < resolvedRange.layerCount; ++layerIdx) { |
| 8369 | uint32_t layer = layerIdx + resolvedRange.baseArrayLayer; |
| 8370 | VkImageSubresource sub = {resolvedRange.aspectMask, level, layer}; |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8371 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
| 8372 | if (!FindLayout(cb_node, image, sub, node)) { |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8373 | SetLayout(cb_node, image, sub, IMAGE_CMD_BUF_LAYOUT_NODE(dest_image_layout, dest_image_layout)); |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8374 | continue; |
| 8375 | } |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8376 | if (node.layout != dest_image_layout) { |
| 8377 | UNIQUE_VALIDATION_ERROR_CODE error_code = VALIDATION_ERROR_01085; |
| 8378 | if (strcmp(func_name, "vkCmdClearDepthStencilImage()") == 0) { |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8379 | error_code = VALIDATION_ERROR_01100; |
| 8380 | } else { |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8381 | assert(strcmp(func_name, "vkCmdClearColorImage()") == 0); |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 8382 | } |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8383 | skip |= |
| 8384 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 8385 | __LINE__, error_code, "DS", "%s: Cannot clear an image whose layout is %s and " |
| 8386 | "doesn't match the current layout %s. %s", |
| 8387 | func_name, string_VkImageLayout(dest_image_layout), string_VkImageLayout(node.layout), |
| 8388 | validation_error_map[error_code]); |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8389 | } |
| 8390 | } |
| 8391 | } |
| 8392 | |
Cort | 0ebd108 | 2016-12-08 09:59:43 -0800 | [diff] [blame] | 8393 | return skip; |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 8394 | } |
| 8395 | |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8396 | // Test if two VkExtent3D structs are equivalent |
| 8397 | static inline bool IsExtentEqual(const VkExtent3D *extent, const VkExtent3D *other_extent) { |
| 8398 | bool result = true; |
| 8399 | if ((extent->width != other_extent->width) || (extent->height != other_extent->height) || |
| 8400 | (extent->depth != other_extent->depth)) { |
| 8401 | result = false; |
| 8402 | } |
| 8403 | return result; |
| 8404 | } |
| 8405 | |
| 8406 | // Returns the image extent of a specific subresource. |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8407 | static inline VkExtent3D GetImageSubresourceExtent(const IMAGE_STATE *img, const VkImageSubresourceLayers *subresource) { |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8408 | const uint32_t mip = subresource->mipLevel; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8409 | VkExtent3D extent = img->createInfo.extent; |
Gregory Mitrano | c730223 | 2016-09-18 23:48:29 -0400 | [diff] [blame] | 8410 | extent.width = std::max(1U, extent.width >> mip); |
| 8411 | extent.height = std::max(1U, extent.height >> mip); |
| 8412 | extent.depth = std::max(1U, extent.depth >> mip); |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8413 | return extent; |
| 8414 | } |
| 8415 | |
| 8416 | // Test if the extent argument has all dimensions set to 0. |
| 8417 | static inline bool IsExtentZero(const VkExtent3D *extent) { |
| 8418 | return ((extent->width == 0) && (extent->height == 0) && (extent->depth == 0)); |
| 8419 | } |
| 8420 | |
| 8421 | // Returns the image transfer granularity for a specific image scaled by compressed block size if necessary. |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8422 | static inline VkExtent3D GetScaledItg(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const IMAGE_STATE *img) { |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8423 | // Default to (0, 0, 0) granularity in case we can't find the real granularity for the physical device. |
| 8424 | VkExtent3D granularity = { 0, 0, 0 }; |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8425 | auto pPool = getCommandPoolNode(dev_data, cb_node->createInfo.commandPool); |
| 8426 | if (pPool) { |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8427 | granularity = dev_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].minImageTransferGranularity; |
| 8428 | if (vk_format_is_compressed(img->createInfo.format)) { |
| 8429 | auto block_size = vk_format_compressed_block_size(img->createInfo.format); |
| 8430 | granularity.width *= block_size.width; |
| 8431 | granularity.height *= block_size.height; |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8432 | } |
| 8433 | } |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8434 | return granularity; |
| 8435 | } |
| 8436 | |
| 8437 | // Test elements of a VkExtent3D structure against alignment constraints contained in another VkExtent3D structure |
| 8438 | static inline bool IsExtentAligned(const VkExtent3D *extent, const VkExtent3D *granularity) { |
| 8439 | bool valid = true; |
| 8440 | if ((vk_safe_modulo(extent->depth, granularity->depth) != 0) || (vk_safe_modulo(extent->width, granularity->width) != 0) || |
| 8441 | (vk_safe_modulo(extent->height, granularity->height) != 0)) { |
| 8442 | valid = false; |
| 8443 | } |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8444 | return valid; |
| 8445 | } |
| 8446 | |
| 8447 | // Check elements of a VkOffset3D structure against a queue family's Image Transfer Granularity values |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8448 | static inline bool CheckItgOffset(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkOffset3D *offset, |
| 8449 | const VkExtent3D *granularity, const uint32_t i, const char *function, const char *member) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8450 | bool skip = false; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8451 | VkExtent3D offset_extent = {}; |
| 8452 | offset_extent.width = static_cast<uint32_t>(abs(offset->x)); |
| 8453 | offset_extent.height = static_cast<uint32_t>(abs(offset->y)); |
| 8454 | offset_extent.depth = static_cast<uint32_t>(abs(offset->z)); |
| 8455 | if (IsExtentZero(granularity)) { |
| 8456 | // If the queue family image transfer granularity is (0, 0, 0), then the offset must always be (0, 0, 0) |
| 8457 | if (IsExtentZero(&offset_extent) == false) { |
| 8458 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8459 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
| 8460 | "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) must be (x=0, y=0, z=0) " |
| 8461 | "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", |
| 8462 | function, i, member, offset->x, offset->y, offset->z); |
| 8463 | } |
| 8464 | } else { |
| 8465 | // If the queue family image transfer granularity is not (0, 0, 0), then the offset dimensions must always be even |
| 8466 | // integer multiples of the image transfer granularity. |
| 8467 | if (IsExtentAligned(&offset_extent, granularity) == false) { |
| 8468 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8469 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
| 8470 | "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) dimensions must be even integer " |
| 8471 | "multiples of this command buffer's queue family image transfer granularity (w=%d, h=%d, d=%d).", |
| 8472 | function, i, member, offset->x, offset->y, offset->z, granularity->width, granularity->height, |
| 8473 | granularity->depth); |
| 8474 | } |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8475 | } |
| 8476 | return skip; |
| 8477 | } |
| 8478 | |
| 8479 | // Check elements of a VkExtent3D structure against a queue family's Image Transfer Granularity values |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8480 | static inline bool CheckItgExtent(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkExtent3D *extent, |
| 8481 | const VkOffset3D *offset, const VkExtent3D *granularity, const VkExtent3D *subresource_extent, |
| 8482 | const uint32_t i, const char *function, const char *member) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8483 | bool skip = false; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8484 | if (IsExtentZero(granularity)) { |
| 8485 | // If the queue family image transfer granularity is (0, 0, 0), then the extent must always match the image |
| 8486 | // subresource extent. |
| 8487 | if (IsExtentEqual(extent, subresource_extent) == false) { |
| 8488 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8489 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
| 8490 | "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d) " |
| 8491 | "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", |
| 8492 | function, i, member, extent->width, extent->height, extent->depth, subresource_extent->width, |
| 8493 | subresource_extent->height, subresource_extent->depth); |
| 8494 | } |
| 8495 | } else { |
| 8496 | // If the queue family image transfer granularity is not (0, 0, 0), then the extent dimensions must always be even |
| 8497 | // integer multiples of the image transfer granularity or the offset + extent dimensions must always match the image |
| 8498 | // subresource extent dimensions. |
| 8499 | VkExtent3D offset_extent_sum = {}; |
| 8500 | offset_extent_sum.width = static_cast<uint32_t>(abs(offset->x)) + extent->width; |
| 8501 | offset_extent_sum.height = static_cast<uint32_t>(abs(offset->y)) + extent->height; |
| 8502 | offset_extent_sum.depth = static_cast<uint32_t>(abs(offset->z)) + extent->depth; |
| 8503 | if ((IsExtentAligned(extent, granularity) == false) && (IsExtentEqual(&offset_extent_sum, subresource_extent) == false)) { |
| 8504 | skip |= |
| 8505 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8506 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8507 | "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) dimensions must be even integer multiples of this command buffer's " |
| 8508 | "queue family image transfer granularity (w=%d, h=%d, d=%d) or offset (x=%d, y=%d, z=%d) + " |
| 8509 | "extent (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d).", |
| 8510 | function, i, member, extent->width, extent->height, extent->depth, granularity->width, granularity->height, |
| 8511 | granularity->depth, offset->x, offset->y, offset->z, extent->width, extent->height, extent->depth, |
| 8512 | subresource_extent->width, subresource_extent->height, subresource_extent->depth); |
| 8513 | } |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8514 | } |
| 8515 | return skip; |
| 8516 | } |
| 8517 | |
| 8518 | // Check a uint32_t width or stride value against a queue family's Image Transfer Granularity width value |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8519 | static inline bool CheckItgInt(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const uint32_t value, |
| 8520 | const uint32_t granularity, const uint32_t i, const char *function, const char *member) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8521 | bool skip = false; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8522 | if (vk_safe_modulo(value, granularity) != 0) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8523 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8524 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8525 | "%s: pRegion[%d].%s (%d) must be an even integer multiple of this command buffer's queue family image " |
| 8526 | "transfer granularity width (%d).", |
| 8527 | function, i, member, value, granularity); |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8528 | } |
| 8529 | return skip; |
| 8530 | } |
| 8531 | |
| 8532 | // Check a VkDeviceSize value against a queue family's Image Transfer Granularity width value |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8533 | static inline bool CheckItgSize(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkDeviceSize value, |
| 8534 | const uint32_t granularity, const uint32_t i, const char *function, const char *member) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8535 | bool skip = false; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8536 | if (vk_safe_modulo(value, granularity) != 0) { |
| 8537 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 8538 | DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", |
| 8539 | "%s: pRegion[%d].%s (%" PRIdLEAST64 |
| 8540 | ") must be an even integer multiple of this command buffer's queue family image transfer " |
| 8541 | "granularity width (%d).", |
| 8542 | function, i, member, value, granularity); |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8543 | } |
| 8544 | return skip; |
| 8545 | } |
| 8546 | |
| 8547 | // Check valid usage Image Tranfer Granularity requirements for elements of a VkImageCopy structure |
| 8548 | static inline bool ValidateCopyImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8549 | const IMAGE_STATE *img, const VkImageCopy *region, |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8550 | const uint32_t i, const char *function) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8551 | bool skip = false; |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8552 | VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); |
| 8553 | skip |= CheckItgOffset(dev_data, cb_node, ®ion->srcOffset, &granularity, i, function, "srcOffset"); |
| 8554 | skip |= CheckItgOffset(dev_data, cb_node, ®ion->dstOffset, &granularity, i, function, "dstOffset"); |
| 8555 | VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->dstSubresource); |
| 8556 | skip |= CheckItgExtent(dev_data, cb_node, ®ion->extent, ®ion->dstOffset, &granularity, &subresource_extent, i, function, |
| 8557 | "extent"); |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8558 | return skip; |
| 8559 | } |
| 8560 | |
| 8561 | // Check valid usage Image Tranfer Granularity requirements for elements of a VkBufferImageCopy structure |
| 8562 | static inline bool ValidateCopyBufferImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8563 | const IMAGE_STATE *img, const VkBufferImageCopy *region, |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8564 | const uint32_t i, const char *function) { |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8565 | bool skip = false; |
Mark Lobodzinski | a493729 | 2016-12-09 11:20:23 -0700 | [diff] [blame] | 8566 | if (vk_format_is_compressed(img->createInfo.format) == true) { |
| 8567 | // TODO: Add granularity checking for compressed formats |
| 8568 | |
| 8569 | // bufferRowLength must be a multiple of the compressed texel block width |
| 8570 | // bufferImageHeight must be a multiple of the compressed texel block height |
| 8571 | // all members of imageOffset must be a multiple of the corresponding dimensions of the compressed texel block |
| 8572 | // bufferOffset must be a multiple of the compressed texel block size in bytes |
| 8573 | // imageExtent.width must be a multiple of the compressed texel block width or (imageExtent.width + imageOffset.x) |
| 8574 | // must equal the image subresource width |
| 8575 | // imageExtent.height must be a multiple of the compressed texel block height or (imageExtent.height + imageOffset.y) |
| 8576 | // must equal the image subresource height |
| 8577 | // imageExtent.depth must be a multiple of the compressed texel block depth or (imageExtent.depth + imageOffset.z) |
| 8578 | // must equal the image subresource depth |
| 8579 | } else { |
| 8580 | VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); |
| 8581 | skip |= CheckItgSize(dev_data, cb_node, region->bufferOffset, granularity.width, i, function, "bufferOffset"); |
| 8582 | skip |= CheckItgInt(dev_data, cb_node, region->bufferRowLength, granularity.width, i, function, "bufferRowLength"); |
| 8583 | skip |= CheckItgInt(dev_data, cb_node, region->bufferImageHeight, granularity.width, i, function, "bufferImageHeight"); |
| 8584 | skip |= CheckItgOffset(dev_data, cb_node, ®ion->imageOffset, &granularity, i, function, "imageOffset"); |
| 8585 | VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->imageSubresource); |
| 8586 | skip |= CheckItgExtent(dev_data, cb_node, ®ion->imageExtent, ®ion->imageOffset, &granularity, &subresource_extent, i, |
| 8587 | function, "imageExtent"); |
| 8588 | } |
Mark Lobodzinski | 5b6d39e | 2016-08-22 09:21:03 -0600 | [diff] [blame] | 8589 | return skip; |
| 8590 | } |
| 8591 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8592 | VKAPI_ATTR void VKAPI_CALL |
| 8593 | CmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, |
| 8594 | VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8595 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8596 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8597 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8598 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8599 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8600 | auto src_image_state = getImageState(dev_data, srcImage); |
| 8601 | auto dst_image_state = getImageState(dev_data, dstImage); |
| 8602 | if (cb_node && src_image_state && dst_image_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8603 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdCopyImage()", VALIDATION_ERROR_02533); |
| 8604 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdCopyImage()", VALIDATION_ERROR_02534); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8605 | // Update bindings between images and cmd buffer |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8606 | AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); |
| 8607 | AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8608 | // Validate that SRC & DST images have correct usage flags set |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8609 | skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, |
| 8610 | VALIDATION_ERROR_01178, "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); |
| 8611 | skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, |
| 8612 | VALIDATION_ERROR_01181, "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8613 | std::function<bool()> function = [=]() { |
| 8614 | return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdCopyImage()"); |
| 8615 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8616 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8617 | function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8618 | SetImageMemoryValid(dev_data, dst_image_state, true); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8619 | return false; |
| 8620 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8621 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8622 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8623 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_COPYIMAGE, "vkCmdCopyImage()"); |
| 8624 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_COPYIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8625 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImage()", VALIDATION_ERROR_01194); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8626 | for (uint32_t i = 0; i < regionCount; ++i) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8627 | skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].srcSubresource, srcImageLayout, |
| 8628 | VALIDATION_ERROR_01180); |
| 8629 | skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].dstSubresource, dstImageLayout, |
| 8630 | VALIDATION_ERROR_01183); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8631 | skip_call |= ValidateCopyImageTransferGranularityRequirements(dev_data, cb_node, dst_image_state, &pRegions[i], i, |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8632 | "vkCmdCopyImage()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8633 | } |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8634 | } else { |
| 8635 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8636 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8637 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8638 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8639 | dev_data->dispatch_table.CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, |
| 8640 | pRegions); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8641 | } |
| 8642 | |
Mark Lobodzinski | 1850d07 | 2016-08-23 15:10:36 -0600 | [diff] [blame] | 8643 | // Validate that an image's sampleCount matches the requirement for a specific API call |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8644 | static inline bool ValidateImageSampleCount(layer_data *dev_data, IMAGE_STATE *image_state, VkSampleCountFlagBits sample_count, |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8645 | const char *location, UNIQUE_VALIDATION_ERROR_CODE msgCode) { |
Mark Lobodzinski | 1850d07 | 2016-08-23 15:10:36 -0600 | [diff] [blame] | 8646 | bool skip = false; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8647 | if (image_state->createInfo.samples != sample_count) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8648 | skip = |
| 8649 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 8650 | reinterpret_cast<uint64_t &>(image_state->image), 0, msgCode, "DS", |
| 8651 | "%s for image 0x%" PRIxLEAST64 " was created with a sample count of %s but must be %s. %s", location, |
| 8652 | reinterpret_cast<uint64_t &>(image_state->image), string_VkSampleCountFlagBits(image_state->createInfo.samples), |
| 8653 | string_VkSampleCountFlagBits(sample_count), validation_error_map[msgCode]); |
Mark Lobodzinski | 1850d07 | 2016-08-23 15:10:36 -0600 | [diff] [blame] | 8654 | } |
| 8655 | return skip; |
| 8656 | } |
| 8657 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8658 | VKAPI_ATTR void VKAPI_CALL |
| 8659 | CmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, |
| 8660 | VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8661 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8662 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8663 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8664 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8665 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8666 | auto src_image_state = getImageState(dev_data, srcImage); |
| 8667 | auto dst_image_state = getImageState(dev_data, dstImage); |
| 8668 | if (cb_node && src_image_state && dst_image_state) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8669 | skip_call |= ValidateImageSampleCount(dev_data, src_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): srcImage", |
| 8670 | VALIDATION_ERROR_02194); |
| 8671 | skip_call |= ValidateImageSampleCount(dev_data, dst_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): dstImage", |
| 8672 | VALIDATION_ERROR_02195); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8673 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdBlitImage()", VALIDATION_ERROR_02539); |
| 8674 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdBlitImage()", VALIDATION_ERROR_02540); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8675 | // Update bindings between images and cmd buffer |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8676 | AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); |
| 8677 | AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8678 | // Validate that SRC & DST images have correct usage flags set |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8679 | skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, |
| 8680 | VALIDATION_ERROR_02182, "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); |
| 8681 | skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, |
| 8682 | VALIDATION_ERROR_02186, "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8683 | std::function<bool()> function = [=]() { |
| 8684 | return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdBlitImage()"); |
| 8685 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8686 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8687 | function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8688 | SetImageMemoryValid(dev_data, dst_image_state, true); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8689 | return false; |
| 8690 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8691 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8692 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8693 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_BLITIMAGE, "vkCmdBlitImage()"); |
| 8694 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_BLITIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8695 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBlitImage()", VALIDATION_ERROR_01300); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8696 | } else { |
| 8697 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8698 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8699 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8700 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8701 | dev_data->dispatch_table.CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, |
| 8702 | pRegions, filter); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8703 | } |
| 8704 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8705 | VKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, |
| 8706 | VkImage dstImage, VkImageLayout dstImageLayout, |
| 8707 | uint32_t regionCount, const VkBufferImageCopy *pRegions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8708 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8709 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8710 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8711 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8712 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8713 | auto src_buff_state = getBufferState(dev_data, srcBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8714 | auto dst_image_state = getImageState(dev_data, dstImage); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8715 | if (cb_node && src_buff_state && dst_image_state) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8716 | skip_call |= ValidateImageSampleCount(dev_data, dst_image_state, VK_SAMPLE_COUNT_1_BIT, |
| 8717 | "vkCmdCopyBufferToImage(): dstImage", VALIDATION_ERROR_01232); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8718 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_state, "vkCmdCopyBufferToImage()", VALIDATION_ERROR_02535); |
| 8719 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdCopyBufferToImage()", VALIDATION_ERROR_02536); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8720 | AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_state); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8721 | AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8722 | skip_call |= |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8723 | ValidateBufferUsageFlags(dev_data, src_buff_state, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, VALIDATION_ERROR_01230, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8724 | "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8725 | skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8726 | VALIDATION_ERROR_01231, "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8727 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8728 | SetImageMemoryValid(dev_data, dst_image_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8729 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8730 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8731 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8732 | function = [=]() { return ValidateBufferMemoryIsValid(dev_data, src_buff_state, "vkCmdCopyBufferToImage()"); }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8733 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8734 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8735 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); |
| 8736 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_COPYBUFFERTOIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8737 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBufferToImage()", VALIDATION_ERROR_01242); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8738 | for (uint32_t i = 0; i < regionCount; ++i) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8739 | skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].imageSubresource, dstImageLayout, |
| 8740 | VALIDATION_ERROR_01234); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8741 | skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, dst_image_state, &pRegions[i], i, |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8742 | "vkCmdCopyBufferToImage()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8743 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8744 | } else { |
| 8745 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8746 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8747 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8748 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8749 | dev_data->dispatch_table.CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8750 | } |
| 8751 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8752 | VKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, |
| 8753 | VkImageLayout srcImageLayout, VkBuffer dstBuffer, |
| 8754 | uint32_t regionCount, const VkBufferImageCopy *pRegions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8755 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8756 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8757 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8758 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8759 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8760 | auto src_image_state = getImageState(dev_data, srcImage); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8761 | auto dst_buff_state = getBufferState(dev_data, dstBuffer); |
| 8762 | if (cb_node && src_image_state && dst_buff_state) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8763 | skip_call |= ValidateImageSampleCount(dev_data, src_image_state, VK_SAMPLE_COUNT_1_BIT, |
| 8764 | "vkCmdCopyImageToBuffer(): srcImage", VALIDATION_ERROR_01249); |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8765 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdCopyImageToBuffer()", VALIDATION_ERROR_02537); |
| 8766 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdCopyImageToBuffer()", VALIDATION_ERROR_02538); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8767 | // Update bindings between buffer/image and cmd buffer |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8768 | AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8769 | AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8770 | // Validate that SRC image & DST buffer have correct usage flags set |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8771 | skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8772 | VALIDATION_ERROR_01248, "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); |
| 8773 | skip_call |= |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8774 | ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, VALIDATION_ERROR_01252, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8775 | "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8776 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8777 | return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdCopyImageToBuffer()"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8778 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8779 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8780 | function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8781 | SetBufferMemoryValid(dev_data, dst_buff_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8782 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8783 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8784 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8785 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8786 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); |
| 8787 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_COPYIMAGETOBUFFER); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8788 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImageToBuffer()", VALIDATION_ERROR_01260); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8789 | for (uint32_t i = 0; i < regionCount; ++i) { |
Mike Weiblen | 1dae96f | 2016-12-23 14:00:22 -0700 | [diff] [blame] | 8790 | skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].imageSubresource, srcImageLayout, |
| 8791 | VALIDATION_ERROR_01251); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8792 | skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, src_image_state, &pRegions[i], i, |
Gregory Mitrano | ceb36d9 | 2016-09-18 21:54:49 -0400 | [diff] [blame] | 8793 | "CmdCopyImageToBuffer"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8794 | } |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8795 | } else { |
| 8796 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8797 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8798 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8799 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8800 | dev_data->dispatch_table.CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8801 | } |
| 8802 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8803 | VKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, |
| 8804 | VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8805 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8806 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8807 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8808 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8809 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8810 | auto dst_buff_state = getBufferState(dev_data, dstBuffer); |
| 8811 | if (cb_node && dst_buff_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8812 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdUpdateBuffer()", VALIDATION_ERROR_02530); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8813 | // Update bindings between buffer and cmd buffer |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8814 | AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8815 | // Validate that DST buffer has correct usage flags set |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8816 | skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8817 | VALIDATION_ERROR_01146, "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8818 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8819 | SetBufferMemoryValid(dev_data, dst_buff_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8820 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8821 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8822 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8823 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8824 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); |
| 8825 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_UPDATEBUFFER); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8826 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdUpdateBuffer()", VALIDATION_ERROR_01155); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8827 | } else { |
| 8828 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8829 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8830 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8831 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8832 | dev_data->dispatch_table.CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8833 | } |
| 8834 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8835 | VKAPI_ATTR void VKAPI_CALL |
| 8836 | CmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8837 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8838 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8839 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8840 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8841 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8842 | auto dst_buff_state = getBufferState(dev_data, dstBuffer); |
| 8843 | if (cb_node && dst_buff_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8844 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdFillBuffer()", VALIDATION_ERROR_02529); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8845 | // Update bindings between buffer and cmd buffer |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8846 | AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8847 | // Validate that DST buffer has correct usage flags set |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8848 | skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 8849 | VALIDATION_ERROR_01137, "vkCmdFillBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8850 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 8851 | SetBufferMemoryValid(dev_data, dst_buff_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8852 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8853 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8854 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 8855 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 8856 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_FILLBUFFER, "vkCmdFillBuffer()"); |
| 8857 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_FILLBUFFER); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 8858 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdFillBuffer()", VALIDATION_ERROR_01142); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 8859 | } else { |
| 8860 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8861 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8862 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8863 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8864 | dev_data->dispatch_table.CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8865 | } |
| 8866 | |
Mark Lobodzinski | a501de3 | 2017-01-12 11:14:35 -0700 | [diff] [blame] | 8867 | // Returns true if sub_rect is entirely contained within rect |
| 8868 | static inline bool ContainsRect(VkRect2D rect, VkRect2D sub_rect) { |
| 8869 | if ((sub_rect.offset.x < rect.offset.x) || |
| 8870 | (sub_rect.offset.x + sub_rect.extent.width > rect.offset.x + rect.extent.width) || |
| 8871 | (sub_rect.offset.y < rect.offset.y) || |
| 8872 | (sub_rect.offset.y + sub_rect.extent.height > rect.offset.y + rect.extent.height)) |
| 8873 | return false; |
| 8874 | return true; |
| 8875 | } |
| 8876 | |
Mark Lobodzinski | 3513bec | 2017-01-18 15:14:29 -0700 | [diff] [blame] | 8877 | bool PreCallValidateCmdClearAttachments(layer_data *dev_data, VkCommandBuffer commandBuffer, uint32_t attachmentCount, |
| 8878 | const VkClearAttachment *pAttachments, uint32_t rectCount, const VkClearRect *pRects) { |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8879 | GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); |
Mark Lobodzinski | 3513bec | 2017-01-18 15:14:29 -0700 | [diff] [blame] | 8880 | bool skip = false; |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8881 | if (cb_node) { |
| 8882 | skip |= ValidateCmd(dev_data, cb_node, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); |
| 8883 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_CLEARATTACHMENTS); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8884 | // Warn if this is issued prior to Draw Cmd and clearing the entire attachment |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8885 | if (!hasDrawCmd(cb_node) && (cb_node->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && |
| 8886 | (cb_node->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8887 | // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) |
| 8888 | // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8889 | // call CmdClearAttachments. Otherwise this seems more like a performance warning. |
| 8890 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 8891 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(commandBuffer), 0, |
| 8892 | DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", |
| 8893 | "vkCmdClearAttachments() issued on command buffer object 0x%p prior to any Draw Cmds." |
| 8894 | " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", |
| 8895 | commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8896 | } |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8897 | skip |= outsideRenderPass(dev_data, cb_node, "vkCmdClearAttachments()", VALIDATION_ERROR_01122); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8898 | } |
| 8899 | |
| 8900 | // Validate that attachment is in reference list of active subpass |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8901 | if (cb_node->activeRenderPass) { |
| 8902 | const VkRenderPassCreateInfo *renderpass_create_info = cb_node->activeRenderPass->createInfo.ptr(); |
| 8903 | const VkSubpassDescription *subpass_desc = &renderpass_create_info->pSubpasses[cb_node->activeSubpass]; |
| 8904 | auto framebuffer = getFramebufferState(dev_data, cb_node->activeFramebuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8905 | |
Chris Forbes | 7f49835 | 2016-10-25 16:32:54 +1300 | [diff] [blame] | 8906 | for (uint32_t i = 0; i < attachmentCount; i++) { |
| 8907 | auto clear_desc = &pAttachments[i]; |
Chris Forbes | 34a09d4 | 2016-10-26 12:40:31 +1300 | [diff] [blame] | 8908 | VkImageView image_view = VK_NULL_HANDLE; |
| 8909 | |
Chris Forbes | 7f49835 | 2016-10-25 16:32:54 +1300 | [diff] [blame] | 8910 | if (clear_desc->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8911 | if (clear_desc->colorAttachment >= subpass_desc->colorAttachmentCount) { |
| 8912 | skip |= log_msg( |
Chris Forbes | da6ae6f | 2016-09-09 14:36:33 +1200 | [diff] [blame] | 8913 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Chris Forbes | e762945 | 2016-10-27 09:32:34 +1300 | [diff] [blame] | 8914 | (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_01114, "DS", |
| 8915 | "vkCmdClearAttachments() color attachment index %d out of range for active subpass %d. %s", |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8916 | clear_desc->colorAttachment, cb_node->activeSubpass, validation_error_map[VALIDATION_ERROR_01114]); |
| 8917 | } else if (subpass_desc->pColorAttachments[clear_desc->colorAttachment].attachment == VK_ATTACHMENT_UNUSED) { |
| 8918 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 8919 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 8920 | DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", |
| 8921 | "vkCmdClearAttachments() color attachment index %d is VK_ATTACHMENT_UNUSED; ignored.", |
| 8922 | clear_desc->colorAttachment); |
Mark Lobodzinski | a501de3 | 2017-01-12 11:14:35 -0700 | [diff] [blame] | 8923 | } else { |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8924 | image_view = framebuffer->createInfo |
| 8925 | .pAttachments[subpass_desc->pColorAttachments[clear_desc->colorAttachment].attachment]; |
Chris Forbes | 34a09d4 | 2016-10-26 12:40:31 +1300 | [diff] [blame] | 8926 | } |
Chris Forbes | 7f49835 | 2016-10-25 16:32:54 +1300 | [diff] [blame] | 8927 | } else if (clear_desc->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8928 | if (!subpass_desc->pDepthStencilAttachment || // Says no DS will be used in active subpass |
| 8929 | (subpass_desc->pDepthStencilAttachment->attachment == |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8930 | VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass |
| 8931 | |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8932 | skip |= |
Mark Lobodzinski | a501de3 | 2017-01-12 11:14:35 -0700 | [diff] [blame] | 8933 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 8934 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, |
| 8935 | DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", |
| 8936 | "vkCmdClearAttachments() depth/stencil clear with no depth/stencil attachment in subpass; ignored"); |
| 8937 | } else { |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8938 | image_view = framebuffer->createInfo.pAttachments[subpass_desc->pDepthStencilAttachment->attachment]; |
Chris Forbes | 34a09d4 | 2016-10-26 12:40:31 +1300 | [diff] [blame] | 8939 | } |
| 8940 | } |
| 8941 | |
| 8942 | if (image_view) { |
| 8943 | auto image_view_state = getImageViewState(dev_data, image_view); |
Mark Lobodzinski | a501de3 | 2017-01-12 11:14:35 -0700 | [diff] [blame] | 8944 | for (uint32_t j = 0; j < rectCount; j++) { |
| 8945 | // The rectangular region specified by a given element of pRects must be contained within the render area of the |
| 8946 | // current render pass instance |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8947 | if (false == ContainsRect(cb_node->activeRenderPassBeginInfo.renderArea, pRects[j].rect)) { |
| 8948 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 8949 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, VALIDATION_ERROR_01115, "DS", |
| 8950 | "vkCmdClearAttachments(): The area defined by pRects[%d] is not contained in the area of " |
| 8951 | "the current render pass instance. %s", |
| 8952 | j, validation_error_map[VALIDATION_ERROR_01115]); |
Mark Lobodzinski | a501de3 | 2017-01-12 11:14:35 -0700 | [diff] [blame] | 8953 | } |
| 8954 | // The layers specified by a given element of pRects must be contained within every attachment that |
| 8955 | // pAttachments refers to |
| 8956 | auto attachment_base_array_layer = image_view_state->create_info.subresourceRange.baseArrayLayer; |
| 8957 | auto attachment_layer_count = image_view_state->create_info.subresourceRange.layerCount; |
| 8958 | if ((pRects[j].baseArrayLayer < attachment_base_array_layer) || pRects[j].layerCount > attachment_layer_count) { |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8959 | skip |= |
Mark Lobodzinski | a501de3 | 2017-01-12 11:14:35 -0700 | [diff] [blame] | 8960 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 8961 | 0, __LINE__, VALIDATION_ERROR_01116, "DS", |
| 8962 | "vkCmdClearAttachments(): The layers defined in pRects[%d] are not contained in the layers of " |
| 8963 | "pAttachment[%d]. %s", |
| 8964 | j, i, validation_error_map[VALIDATION_ERROR_01116]); |
| 8965 | } |
Chris Forbes | 34a09d4 | 2016-10-26 12:40:31 +1300 | [diff] [blame] | 8966 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8967 | } |
| 8968 | } |
| 8969 | } |
Mark Lobodzinski | 3513bec | 2017-01-18 15:14:29 -0700 | [diff] [blame] | 8970 | return skip; |
| 8971 | } |
| 8972 | |
| 8973 | VKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, |
| 8974 | const VkClearAttachment *pAttachments, uint32_t rectCount, |
| 8975 | const VkClearRect *pRects) { |
| 8976 | bool skip = false; |
| 8977 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 8978 | { |
| 8979 | std::lock_guard<std::mutex> lock(global_lock); |
| 8980 | skip = PreCallValidateCmdClearAttachments(dev_data, commandBuffer, attachmentCount, pAttachments, rectCount, pRects); |
| 8981 | } |
Mark Lobodzinski | 63bd305 | 2017-01-18 14:55:58 -0700 | [diff] [blame] | 8982 | if (!skip) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 8983 | dev_data->dispatch_table.CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8984 | } |
| 8985 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 8986 | VKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, |
| 8987 | VkImageLayout imageLayout, const VkClearColorValue *pColor, |
| 8988 | uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 8989 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8990 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 8991 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 8992 | // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 8993 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 8994 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8995 | auto image_state = getImageState(dev_data, image); |
| 8996 | if (cb_node && image_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 8997 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCmdClearColorImage()", VALIDATION_ERROR_02527); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 8998 | AddCommandBufferBindingImage(dev_data, cb_node, image_state); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 8999 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9000 | SetImageMemoryValid(dev_data, image_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9001 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9002 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9003 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 9004 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9005 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); |
| 9006 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_CLEARCOLORIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9007 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearColorImage()", VALIDATION_ERROR_01096); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 9008 | } else { |
| 9009 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9010 | } |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 9011 | for (uint32_t i = 0; i < rangeCount; ++i) { |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 9012 | skip_call |= VerifyClearImageLayout(dev_data, cb_node, image, pRanges[i], imageLayout, "vkCmdClearColorImage()"); |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 9013 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9014 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9015 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9016 | dev_data->dispatch_table.CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9017 | } |
| 9018 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9019 | VKAPI_ATTR void VKAPI_CALL |
| 9020 | CmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| 9021 | const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, |
| 9022 | const VkImageSubresourceRange *pRanges) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9023 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9024 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9025 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9026 | // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 9027 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9028 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9029 | auto image_state = getImageState(dev_data, image); |
| 9030 | if (cb_node && image_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 9031 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCmdClearDepthStencilImage()", VALIDATION_ERROR_02528); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9032 | AddCommandBufferBindingImage(dev_data, cb_node, image_state); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9033 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9034 | SetImageMemoryValid(dev_data, image_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9035 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9036 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9037 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 9038 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9039 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); |
| 9040 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9041 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearDepthStencilImage()", VALIDATION_ERROR_01111); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 9042 | } else { |
| 9043 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9044 | } |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 9045 | for (uint32_t i = 0; i < rangeCount; ++i) { |
Cort | 830c7c1 | 2016-12-05 17:33:49 -0800 | [diff] [blame] | 9046 | skip_call |= VerifyClearImageLayout(dev_data, cb_node, image, pRanges[i], imageLayout, "vkCmdClearDepthStencilImage()"); |
Slawomir Cygan | 4f73b7f | 2016-11-28 19:17:38 +0100 | [diff] [blame] | 9047 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9048 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9049 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9050 | dev_data->dispatch_table.CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, pRanges); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9051 | } |
| 9052 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9053 | VKAPI_ATTR void VKAPI_CALL |
| 9054 | CmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, |
| 9055 | VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9056 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9057 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9058 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 9059 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9060 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9061 | auto src_image_state = getImageState(dev_data, srcImage); |
| 9062 | auto dst_image_state = getImageState(dev_data, dstImage); |
| 9063 | if (cb_node && src_image_state && dst_image_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 9064 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdResolveImage()", VALIDATION_ERROR_02541); |
| 9065 | skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdResolveImage()", VALIDATION_ERROR_02542); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 9066 | // Update bindings between images and cmd buffer |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9067 | AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); |
| 9068 | AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9069 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9070 | return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdResolveImage()"); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 9071 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9072 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 9073 | function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9074 | SetImageMemoryValid(dev_data, dst_image_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9075 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9076 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9077 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 9078 | |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9079 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); |
| 9080 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_RESOLVEIMAGE); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9081 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdResolveImage()", VALIDATION_ERROR_01335); |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 9082 | } else { |
| 9083 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9084 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9085 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9086 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9087 | dev_data->dispatch_table.CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, |
| 9088 | pRegions); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9089 | } |
| 9090 | |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9091 | bool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { |
| 9092 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 9093 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9094 | if (pCB) { |
| 9095 | pCB->eventToStageMap[event] = stageMask; |
| 9096 | } |
| 9097 | auto queue_data = dev_data->queueMap.find(queue); |
| 9098 | if (queue_data != dev_data->queueMap.end()) { |
| 9099 | queue_data->second.eventToStageMap[event] = stageMask; |
| 9100 | } |
| 9101 | return false; |
| 9102 | } |
| 9103 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9104 | VKAPI_ATTR void VKAPI_CALL |
| 9105 | CmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9106 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9107 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9108 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9109 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9110 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9111 | skip_call |= ValidateCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); |
| 9112 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_SETEVENT); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9113 | skip_call |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent()", VALIDATION_ERROR_00238); |
Tobin Ehlis | b093da8 | 2017-01-19 12:05:27 -0700 | [diff] [blame] | 9114 | skip_call |= |
| 9115 | ValidateStageMaskGsTsEnables(dev_data, stageMask, "vkCmdSetEvent()", VALIDATION_ERROR_00230, VALIDATION_ERROR_00231); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 9116 | auto event_state = getEventNode(dev_data, event); |
| 9117 | if (event_state) { |
| 9118 | addCommandBufferBinding(&event_state->cb_bindings, |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9119 | {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 9120 | event_state->cb_bindings.insert(pCB); |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9121 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9122 | pCB->events.push_back(event); |
Michael Lentine | 860b0fe | 2016-05-20 10:14:00 -0500 | [diff] [blame] | 9123 | if (!pCB->waitedEvents.count(event)) { |
| 9124 | pCB->writeEventsBeforeWait.push_back(event); |
| 9125 | } |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9126 | std::function<bool(VkQueue)> eventUpdate = |
| 9127 | std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); |
| 9128 | pCB->eventUpdates.push_back(eventUpdate); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9129 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9130 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9131 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9132 | dev_data->dispatch_table.CmdSetEvent(commandBuffer, event, stageMask); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9133 | } |
| 9134 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9135 | VKAPI_ATTR void VKAPI_CALL |
| 9136 | CmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9137 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9138 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9139 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9140 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9141 | if (pCB) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9142 | skip_call |= ValidateCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); |
| 9143 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_RESETEVENT); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9144 | skip_call |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent()", VALIDATION_ERROR_00249); |
Tobin Ehlis | b093da8 | 2017-01-19 12:05:27 -0700 | [diff] [blame] | 9145 | skip_call |= |
| 9146 | ValidateStageMaskGsTsEnables(dev_data, stageMask, "vkCmdResetEvent()", VALIDATION_ERROR_00240, VALIDATION_ERROR_00241); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 9147 | auto event_state = getEventNode(dev_data, event); |
| 9148 | if (event_state) { |
| 9149 | addCommandBufferBinding(&event_state->cb_bindings, |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9150 | {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 9151 | event_state->cb_bindings.insert(pCB); |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9152 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9153 | pCB->events.push_back(event); |
Michael Lentine | 860b0fe | 2016-05-20 10:14:00 -0500 | [diff] [blame] | 9154 | if (!pCB->waitedEvents.count(event)) { |
| 9155 | pCB->writeEventsBeforeWait.push_back(event); |
| 9156 | } |
Tobin Ehlis | b093da8 | 2017-01-19 12:05:27 -0700 | [diff] [blame] | 9157 | // TODO : Add check for VALIDATION_ERROR_00226 |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9158 | std::function<bool(VkQueue)> eventUpdate = |
| 9159 | std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); |
| 9160 | pCB->eventUpdates.push_back(eventUpdate); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9161 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9162 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9163 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9164 | dev_data->dispatch_table.CmdResetEvent(commandBuffer, event, stageMask); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9165 | } |
| 9166 | |
Alex Smith | c4659e4 | 2017-01-10 09:51:22 +0000 | [diff] [blame] | 9167 | static bool TransitionImageAspectLayout(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkImageMemoryBarrier *mem_barrier, |
| 9168 | uint32_t level, uint32_t layer, VkImageAspectFlags aspect) |
| 9169 | { |
| 9170 | if (!(mem_barrier->subresourceRange.aspectMask & aspect)) { |
| 9171 | return false; |
| 9172 | } |
| 9173 | VkImageSubresource sub = {aspect, level, layer}; |
| 9174 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
| 9175 | if (!FindLayout(pCB, mem_barrier->image, sub, node)) { |
| 9176 | SetLayout(pCB, mem_barrier->image, sub, |
| 9177 | IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); |
| 9178 | return false; |
| 9179 | } |
| 9180 | bool skip = false; |
| 9181 | if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { |
| 9182 | // TODO: Set memory invalid which is in mem_tracker currently |
| 9183 | } else if (node.layout != mem_barrier->oldLayout) { |
| 9184 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 9185 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
| 9186 | "You cannot transition the layout of aspect %d from %s when current layout is %s.", |
| 9187 | aspect, string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); |
| 9188 | } |
| 9189 | SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); |
| 9190 | return skip; |
| 9191 | } |
| 9192 | |
Mark Lobodzinski | 0c5e804 | 2016-12-12 08:33:13 -0700 | [diff] [blame] | 9193 | // TODO: Separate validation and layout state updates |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9194 | static bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, |
| 9195 | const VkImageMemoryBarrier *pImgMemBarriers) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9196 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 9197 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9198 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9199 | uint32_t levelCount = 0; |
| 9200 | uint32_t layerCount = 0; |
| 9201 | |
| 9202 | for (uint32_t i = 0; i < memBarrierCount; ++i) { |
| 9203 | auto mem_barrier = &pImgMemBarriers[i]; |
| 9204 | if (!mem_barrier) |
| 9205 | continue; |
| 9206 | // TODO: Do not iterate over every possibility - consolidate where |
| 9207 | // possible |
| 9208 | ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); |
| 9209 | |
| 9210 | for (uint32_t j = 0; j < levelCount; j++) { |
| 9211 | uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; |
| 9212 | for (uint32_t k = 0; k < layerCount; k++) { |
| 9213 | uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; |
Alex Smith | c4659e4 | 2017-01-10 09:51:22 +0000 | [diff] [blame] | 9214 | skip |= TransitionImageAspectLayout(dev_data, pCB, mem_barrier, level, layer, VK_IMAGE_ASPECT_COLOR_BIT); |
| 9215 | skip |= TransitionImageAspectLayout(dev_data, pCB, mem_barrier, level, layer, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 9216 | skip |= TransitionImageAspectLayout(dev_data, pCB, mem_barrier, level, layer, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 9217 | skip |= TransitionImageAspectLayout(dev_data, pCB, mem_barrier, level, layer, VK_IMAGE_ASPECT_METADATA_BIT); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9218 | } |
| 9219 | } |
| 9220 | } |
| 9221 | return skip; |
| 9222 | } |
| 9223 | |
| 9224 | // Print readable FlagBits in FlagMask |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9225 | static std::string string_VkAccessFlags(VkAccessFlags accessMask) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9226 | std::string result; |
| 9227 | std::string separator; |
| 9228 | |
| 9229 | if (accessMask == 0) { |
| 9230 | result = "[None]"; |
| 9231 | } else { |
| 9232 | result = "["; |
| 9233 | for (auto i = 0; i < 32; i++) { |
| 9234 | if (accessMask & (1 << i)) { |
| 9235 | result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); |
| 9236 | separator = " | "; |
| 9237 | } |
| 9238 | } |
| 9239 | result = result + "]"; |
| 9240 | } |
| 9241 | return result; |
| 9242 | } |
| 9243 | |
| 9244 | // AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. |
| 9245 | // If required_bit is zero, accessMask must have at least one of 'optional_bits' set |
| 9246 | // TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9247 | static bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, |
| 9248 | const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, |
| 9249 | const char *type) { |
| 9250 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9251 | |
| 9252 | if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { |
Chris Forbes | 9b21a85 | 2016-05-06 18:07:09 +1200 | [diff] [blame] | 9253 | if (accessMask & ~(required_bit | optional_bits)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9254 | // TODO: Verify against Valid Use |
| 9255 | skip_call |= |
| 9256 | log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | 6fb205c | 2016-05-23 13:45:36 -0600 | [diff] [blame] | 9257 | DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9258 | type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); |
| 9259 | } |
| 9260 | } else { |
| 9261 | if (!required_bit) { |
Michael Lentine | 0250823 | 2016-04-13 17:12:57 -0500 | [diff] [blame] | 9262 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9263 | DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " |
| 9264 | "%s when layout is %s, unless the app has previously added a " |
| 9265 | "barrier for this transition.", |
| 9266 | type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, |
| 9267 | string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); |
| 9268 | } else { |
| 9269 | std::string opt_bits; |
| 9270 | if (optional_bits != 0) { |
| 9271 | std::stringstream ss; |
| 9272 | ss << optional_bits; |
| 9273 | opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); |
| 9274 | } |
Michael Lentine | 0250823 | 2016-04-13 17:12:57 -0500 | [diff] [blame] | 9275 | skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9276 | DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " |
| 9277 | "layout is %s, unless the app has previously added a barrier for " |
| 9278 | "this transition.", |
| 9279 | type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, |
| 9280 | string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); |
| 9281 | } |
| 9282 | } |
| 9283 | return skip_call; |
| 9284 | } |
| 9285 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9286 | static bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, |
| 9287 | const VkImageLayout &layout, const char *type) { |
| 9288 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9289 | switch (layout) { |
| 9290 | case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { |
| 9291 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, |
Jan-Harald Fredriksen | def6033 | 2016-10-21 15:14:16 +0200 | [diff] [blame] | 9292 | VK_ACCESS_COLOR_ATTACHMENT_READ_BIT | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT, type); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9293 | break; |
| 9294 | } |
| 9295 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { |
| 9296 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, |
Jan-Harald Fredriksen | def6033 | 2016-10-21 15:14:16 +0200 | [diff] [blame] | 9297 | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT, type); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9298 | break; |
| 9299 | } |
| 9300 | case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { |
| 9301 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); |
| 9302 | break; |
| 9303 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9304 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { |
| 9305 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, |
Jan-Harald Fredriksen | def6033 | 2016-10-21 15:14:16 +0200 | [diff] [blame] | 9306 | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | |
| 9307 | VK_ACCESS_SHADER_READ_BIT | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT, type); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9308 | break; |
| 9309 | } |
| 9310 | case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { |
| 9311 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, |
| 9312 | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); |
| 9313 | break; |
| 9314 | } |
| 9315 | case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { |
| 9316 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); |
| 9317 | break; |
| 9318 | } |
Tony Barbour | c0676ef | 2016-09-29 13:41:49 -0600 | [diff] [blame] | 9319 | case VK_IMAGE_LAYOUT_PRESENT_SRC_KHR: { |
| 9320 | skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_MEMORY_READ_BIT, 0, type); |
| 9321 | break; |
| 9322 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9323 | case VK_IMAGE_LAYOUT_UNDEFINED: { |
| 9324 | if (accessMask != 0) { |
| 9325 | // TODO: Verify against Valid Use section spec |
| 9326 | skip_call |= |
| 9327 | log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | 6fb205c | 2016-05-23 13:45:36 -0600 | [diff] [blame] | 9328 | DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9329 | type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); |
| 9330 | } |
| 9331 | break; |
| 9332 | } |
| 9333 | case VK_IMAGE_LAYOUT_GENERAL: |
| 9334 | default: { break; } |
| 9335 | } |
| 9336 | return skip_call; |
| 9337 | } |
| 9338 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9339 | static bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, |
| 9340 | const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, |
| 9341 | const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, |
| 9342 | const VkImageMemoryBarrier *pImageMemBarriers) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9343 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9344 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); |
| 9345 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); |
| 9346 | if (pCB->activeRenderPass && memBarrierCount) { |
Chris Forbes | a4937a7 | 2016-05-06 16:31:14 +1200 | [diff] [blame] | 9347 | if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9348 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9349 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " |
| 9350 | "with no self dependency specified.", |
| 9351 | funcName, pCB->activeSubpass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9352 | } |
| 9353 | } |
| 9354 | for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { |
| 9355 | auto mem_barrier = &pImageMemBarriers[i]; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9356 | auto image_data = getImageState(dev_data, mem_barrier->image); |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 9357 | if (image_data) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9358 | uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; |
| 9359 | uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 9360 | if (image_data->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9361 | // srcQueueFamilyIndex and dstQueueFamilyIndex must both |
| 9362 | // be VK_QUEUE_FAMILY_IGNORED |
| 9363 | if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9364 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 9365 | __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", |
| 9366 | "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " |
| 9367 | "VK_SHARING_MODE_CONCURRENT. Src and dst " |
| 9368 | "queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", |
| 9369 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9370 | } |
| 9371 | } else { |
| 9372 | // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and |
| 9373 | // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, |
| 9374 | // or both be a valid queue family |
| 9375 | if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && |
| 9376 | (src_q_f_index != dst_q_f_index)) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9377 | skip |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9378 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9379 | DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " |
| 9380 | "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " |
| 9381 | "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " |
| 9382 | "must be.", |
| 9383 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); |
| 9384 | } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 9385 | ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || |
| 9386 | (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9387 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 9388 | __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", |
| 9389 | "%s: Image 0x%" PRIx64 " was created with sharingMode " |
| 9390 | "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" |
| 9391 | " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER |
| 9392 | "queueFamilies crated for this device.", |
| 9393 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, dst_q_f_index, |
| 9394 | dev_data->phys_dev_properties.queue_family_properties.size()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9395 | } |
| 9396 | } |
| 9397 | } |
| 9398 | |
| 9399 | if (mem_barrier) { |
Tony Barbour | 14740bb | 2016-10-04 12:03:50 -0600 | [diff] [blame] | 9400 | if (mem_barrier->oldLayout != mem_barrier->newLayout) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9401 | skip |= |
Tony Barbour | 14740bb | 2016-10-04 12:03:50 -0600 | [diff] [blame] | 9402 | ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9403 | skip |= |
Tony Barbour | 14740bb | 2016-10-04 12:03:50 -0600 | [diff] [blame] | 9404 | ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); |
| 9405 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9406 | if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9407 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9408 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " |
| 9409 | "PREINITIALIZED.", |
| 9410 | funcName); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9411 | } |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 9412 | auto image_data = getImageState(dev_data, mem_barrier->image); |
Jamie Madill | 2b6b8d5 | 2016-04-04 15:09:51 -0400 | [diff] [blame] | 9413 | VkFormat format = VK_FORMAT_UNDEFINED; |
| 9414 | uint32_t arrayLayers = 0, mipLevels = 0; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9415 | bool imageFound = false; |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 9416 | if (image_data) { |
| 9417 | format = image_data->createInfo.format; |
| 9418 | arrayLayers = image_data->createInfo.arrayLayers; |
| 9419 | mipLevels = image_data->createInfo.mipLevels; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9420 | imageFound = true; |
| 9421 | } else if (dev_data->device_extensions.wsi_enabled) { |
Tobin Ehlis | 969a526 | 2016-06-02 12:13:32 -0600 | [diff] [blame] | 9422 | auto imageswap_data = getSwapchainFromImage(dev_data, mem_barrier->image); |
| 9423 | if (imageswap_data) { |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 9424 | auto swapchain_data = getSwapchainNode(dev_data, imageswap_data); |
| 9425 | if (swapchain_data) { |
| 9426 | format = swapchain_data->createInfo.imageFormat; |
| 9427 | arrayLayers = swapchain_data->createInfo.imageArrayLayers; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9428 | mipLevels = 1; |
| 9429 | imageFound = true; |
| 9430 | } |
| 9431 | } |
| 9432 | } |
| 9433 | if (imageFound) { |
Tobin Ehlis | d7e548b | 2016-07-19 17:39:34 -0600 | [diff] [blame] | 9434 | auto aspect_mask = mem_barrier->subresourceRange.aspectMask; |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9435 | skip |= ValidateImageAspectMask(dev_data, image_data->image, format, aspect_mask, funcName); |
Michael Lentine | 87e44e0 | 2016-03-18 14:49:09 -0500 | [diff] [blame] | 9436 | int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) |
| 9437 | ? 1 |
| 9438 | : mem_barrier->subresourceRange.layerCount; |
| 9439 | if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9440 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 9441 | __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " |
| 9442 | "baseArrayLayer (%d) and layerCount (%d) be less " |
| 9443 | "than or equal to the total number of layers (%d).", |
| 9444 | funcName, mem_barrier->subresourceRange.baseArrayLayer, |
| 9445 | mem_barrier->subresourceRange.layerCount, arrayLayers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9446 | } |
Michael Lentine | 87e44e0 | 2016-03-18 14:49:09 -0500 | [diff] [blame] | 9447 | int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) |
| 9448 | ? 1 |
| 9449 | : mem_barrier->subresourceRange.levelCount; |
| 9450 | if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9451 | skip |= log_msg( |
| 9452 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9453 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " |
| 9454 | "(%d) and levelCount (%d) be less than or equal to " |
| 9455 | "the total number of levels (%d).", |
| 9456 | funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, mipLevels); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9457 | } |
| 9458 | } |
| 9459 | } |
| 9460 | } |
| 9461 | for (uint32_t i = 0; i < bufferBarrierCount; ++i) { |
| 9462 | auto mem_barrier = &pBufferMemBarriers[i]; |
| 9463 | if (pCB->activeRenderPass) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9464 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9465 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9466 | } |
| 9467 | if (!mem_barrier) |
| 9468 | continue; |
| 9469 | |
| 9470 | // Validate buffer barrier queue family indices |
| 9471 | if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 9472 | mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9473 | (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 9474 | mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9475 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9476 | DRAWSTATE_INVALID_QUEUE_INDEX, "DS", |
| 9477 | "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " |
| 9478 | "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", |
| 9479 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), |
| 9480 | dev_data->phys_dev_properties.queue_family_properties.size()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9481 | } |
| 9482 | |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 9483 | auto buffer_state = getBufferState(dev_data, mem_barrier->buffer); |
| 9484 | if (buffer_state) { |
| 9485 | auto buffer_size = buffer_state->requirements.size; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9486 | if (mem_barrier->offset >= buffer_size) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9487 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9488 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 |
| 9489 | " which is not less than total size 0x%" PRIx64 ".", |
| 9490 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), |
| 9491 | reinterpret_cast<const uint64_t &>(mem_barrier->offset), |
| 9492 | reinterpret_cast<const uint64_t &>(buffer_size)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9493 | } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9494 | skip |= log_msg( |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 9495 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 9496 | DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 |
| 9497 | " whose sum is greater than total size 0x%" PRIx64 ".", |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 9498 | funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), |
| 9499 | reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), |
| 9500 | reinterpret_cast<const uint64_t &>(buffer_size)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9501 | } |
| 9502 | } |
| 9503 | } |
Tobin Ehlis | 8d79b2e | 2016-10-26 14:13:46 -0600 | [diff] [blame] | 9504 | return skip; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9505 | } |
| 9506 | |
Chris Forbes | f321eba | 2016-03-31 11:22:37 +1300 | [diff] [blame] | 9507 | bool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9508 | bool skip_call = false; |
| 9509 | VkPipelineStageFlags stageMask = 0; |
| 9510 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
| 9511 | for (uint32_t i = 0; i < eventCount; ++i) { |
Chris Forbes | f321eba | 2016-03-31 11:22:37 +1300 | [diff] [blame] | 9512 | auto event = pCB->events[firstEventIndex + i]; |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9513 | auto queue_data = dev_data->queueMap.find(queue); |
| 9514 | if (queue_data == dev_data->queueMap.end()) |
| 9515 | return false; |
Chris Forbes | f321eba | 2016-03-31 11:22:37 +1300 | [diff] [blame] | 9516 | auto event_data = queue_data->second.eventToStageMap.find(event); |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9517 | if (event_data != queue_data->second.eventToStageMap.end()) { |
| 9518 | stageMask |= event_data->second; |
| 9519 | } else { |
Tobin Ehlis | cab6b7d | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9520 | auto global_event_data = getEventNode(dev_data, event); |
| 9521 | if (!global_event_data) { |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9522 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, |
Chris Forbes | 0fa9221 | 2016-03-31 11:47:29 +1300 | [diff] [blame] | 9523 | reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", |
| 9524 | "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", |
Chris Forbes | f321eba | 2016-03-31 11:22:37 +1300 | [diff] [blame] | 9525 | reinterpret_cast<const uint64_t &>(event)); |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9526 | } else { |
Tobin Ehlis | cab6b7d | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9527 | stageMask |= global_event_data->stageMask; |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9528 | } |
| 9529 | } |
| 9530 | } |
Michael Lentine | 860b0fe | 2016-05-20 10:14:00 -0500 | [diff] [blame] | 9531 | // TODO: Need to validate that host_bit is only set if set event is called |
| 9532 | // but set event can be called at any time. |
| 9533 | if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { |
| 9534 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9535 | VALIDATION_ERROR_00254, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " |
| 9536 | "using srcStageMask 0x%X which must be the bitwise " |
| 9537 | "OR of the stageMask parameters used in calls to " |
| 9538 | "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " |
| 9539 | "used with vkSetEvent but instead is 0x%X. %s", |
| 9540 | sourceStageMask, stageMask, validation_error_map[VALIDATION_ERROR_00254]); |
Michael Lentine | b653eb2 | 2016-03-18 14:11:44 -0500 | [diff] [blame] | 9541 | } |
| 9542 | return skip_call; |
| 9543 | } |
| 9544 | |
Mark Lobodzinski | e6ce3f6 | 2016-12-10 10:53:34 -0700 | [diff] [blame] | 9545 | // Note that we only check bits that HAVE required queueflags -- don't care entries are skipped |
| 9546 | static std::unordered_map<VkPipelineStageFlags, VkQueueFlags> supported_pipeline_stages_table = { |
| 9547 | {VK_PIPELINE_STAGE_COMMAND_PROCESS_BIT_NVX, VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT}, |
| 9548 | {VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT, VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT}, |
| 9549 | {VK_PIPELINE_STAGE_VERTEX_INPUT_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9550 | {VK_PIPELINE_STAGE_VERTEX_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9551 | {VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9552 | {VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9553 | {VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9554 | {VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9555 | {VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9556 | {VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9557 | {VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, VK_QUEUE_GRAPHICS_BIT}, |
| 9558 | {VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, VK_QUEUE_COMPUTE_BIT}, |
| 9559 | {VK_PIPELINE_STAGE_TRANSFER_BIT, VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT}, |
| 9560 | {VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT, VK_QUEUE_GRAPHICS_BIT}}; |
| 9561 | |
| 9562 | static const VkPipelineStageFlags stage_flag_bit_array[] = {VK_PIPELINE_STAGE_COMMAND_PROCESS_BIT_NVX, |
| 9563 | VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT, |
| 9564 | VK_PIPELINE_STAGE_VERTEX_INPUT_BIT, |
| 9565 | VK_PIPELINE_STAGE_VERTEX_SHADER_BIT, |
| 9566 | VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT, |
| 9567 | VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT, |
| 9568 | VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT, |
| 9569 | VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT, |
| 9570 | VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT, |
| 9571 | VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, |
| 9572 | VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, |
| 9573 | VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, |
| 9574 | VK_PIPELINE_STAGE_TRANSFER_BIT, |
| 9575 | VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT}; |
| 9576 | |
| 9577 | bool CheckStageMaskQueueCompatibility(layer_data *dev_data, VkCommandBuffer command_buffer, VkPipelineStageFlags stage_mask, |
| 9578 | VkQueueFlags queue_flags, const char *function, const char *src_or_dest, |
| 9579 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| 9580 | bool skip = false; |
| 9581 | // Lookup each bit in the stagemask and check for overlap between its table bits and queue_flags |
| 9582 | for (const auto &item : stage_flag_bit_array) { |
| 9583 | if (stage_mask & item) { |
| 9584 | if ((supported_pipeline_stages_table[item] & queue_flags) == 0) { |
| 9585 | skip |= |
| 9586 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 9587 | reinterpret_cast<uint64_t &>(command_buffer), __LINE__, error_code, "DL", |
| 9588 | "%s(): %s flag %s is not compatible with the queue family properties of this " |
| 9589 | "command buffer. %s", |
| 9590 | function, src_or_dest, string_VkPipelineStageFlagBits(static_cast<VkPipelineStageFlagBits>(item)), |
| 9591 | validation_error_map[error_code]); |
| 9592 | } |
| 9593 | } |
| 9594 | } |
| 9595 | return skip; |
| 9596 | } |
| 9597 | |
| 9598 | bool ValidateStageMasksAgainstQueueCapabilities(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, |
| 9599 | VkPipelineStageFlags source_stage_mask, VkPipelineStageFlags dest_stage_mask, |
| 9600 | const char *function, UNIQUE_VALIDATION_ERROR_CODE error_code) { |
| 9601 | bool skip = false; |
| 9602 | uint32_t queue_family_index = dev_data->commandPoolMap[cb_state->createInfo.commandPool].queueFamilyIndex; |
| 9603 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(dev_data->physical_device), instance_layer_data_map); |
| 9604 | auto physical_device_state = getPhysicalDeviceState(instance_data, dev_data->physical_device); |
| 9605 | |
| 9606 | // Any pipeline stage included in srcStageMask or dstStageMask must be supported by the capabilities of the queue family |
| 9607 | // specified by the queueFamilyIndex member of the VkCommandPoolCreateInfo structure that was used to create the VkCommandPool |
| 9608 | // that commandBuffer was allocated from, as specified in the table of supported pipeline stages. |
| 9609 | |
| 9610 | if (queue_family_index < physical_device_state->queue_family_properties.size()) { |
| 9611 | VkQueueFlags specified_queue_flags = physical_device_state->queue_family_properties[queue_family_index].queueFlags; |
| 9612 | |
| 9613 | if ((source_stage_mask & VK_PIPELINE_STAGE_ALL_COMMANDS_BIT) == 0) { |
| 9614 | skip |= CheckStageMaskQueueCompatibility(dev_data, cb_state->commandBuffer, source_stage_mask, specified_queue_flags, |
| 9615 | function, "srcStageMask", error_code); |
| 9616 | } |
| 9617 | if ((dest_stage_mask & VK_PIPELINE_STAGE_ALL_COMMANDS_BIT) == 0) { |
| 9618 | skip |= CheckStageMaskQueueCompatibility(dev_data, cb_state->commandBuffer, dest_stage_mask, specified_queue_flags, |
| 9619 | function, "dstStageMask", error_code); |
| 9620 | } |
| 9621 | } |
| 9622 | return skip; |
| 9623 | } |
| 9624 | |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9625 | VKAPI_ATTR void VKAPI_CALL CmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, |
| 9626 | VkPipelineStageFlags sourceStageMask, VkPipelineStageFlags dstStageMask, |
| 9627 | uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, |
| 9628 | uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, |
| 9629 | uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { |
| 9630 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9631 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9632 | std::unique_lock<std::mutex> lock(global_lock); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9633 | GLOBAL_CB_NODE *cb_state = getCBNode(dev_data, commandBuffer); |
| 9634 | if (cb_state) { |
| 9635 | skip |= ValidateStageMasksAgainstQueueCapabilities(dev_data, cb_state, sourceStageMask, dstStageMask, "vkCmdWaitEvents", |
| 9636 | VALIDATION_ERROR_02510); |
Tobin Ehlis | b093da8 | 2017-01-19 12:05:27 -0700 | [diff] [blame] | 9637 | skip |= ValidateStageMaskGsTsEnables(dev_data, sourceStageMask, "vkCmdWaitEvents()", VALIDATION_ERROR_02067, |
| 9638 | VALIDATION_ERROR_02069); |
| 9639 | skip |= ValidateStageMaskGsTsEnables(dev_data, dstStageMask, "vkCmdWaitEvents()", VALIDATION_ERROR_02068, |
| 9640 | VALIDATION_ERROR_02070); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9641 | auto first_event_index = cb_state->events.size(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9642 | for (uint32_t i = 0; i < eventCount; ++i) { |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 9643 | auto event_state = getEventNode(dev_data, pEvents[i]); |
| 9644 | if (event_state) { |
| 9645 | addCommandBufferBinding(&event_state->cb_bindings, |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9646 | {reinterpret_cast<const uint64_t &>(pEvents[i]), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9647 | cb_state); |
| 9648 | event_state->cb_bindings.insert(cb_state); |
Tobin Ehlis | b073d99 | 2016-07-07 16:47:10 -0600 | [diff] [blame] | 9649 | } |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9650 | cb_state->waitedEvents.insert(pEvents[i]); |
| 9651 | cb_state->events.push_back(pEvents[i]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9652 | } |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9653 | std::function<bool(VkQueue)> event_update = |
| 9654 | std::bind(validateEventStageMask, std::placeholders::_1, cb_state, eventCount, first_event_index, sourceStageMask); |
| 9655 | cb_state->eventUpdates.push_back(event_update); |
| 9656 | if (cb_state->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9657 | skip |= ValidateCmd(dev_data, cb_state, CMD_WAITEVENTS, "vkCmdWaitEvents()"); |
| 9658 | UpdateCmdBufferLastCmd(dev_data, cb_state, CMD_WAITEVENTS); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9659 | } else { |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9660 | skip |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9661 | } |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9662 | skip |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); |
| 9663 | skip |= ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, |
| 9664 | pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9665 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9666 | lock.unlock(); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9667 | if (!skip) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9668 | dev_data->dispatch_table.CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, |
| 9669 | memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, |
| 9670 | imageMemoryBarrierCount, pImageMemoryBarriers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9671 | } |
| 9672 | |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9673 | VKAPI_ATTR void VKAPI_CALL CmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, |
| 9674 | VkPipelineStageFlags dstStageMask, VkDependencyFlags dependencyFlags, |
| 9675 | uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, |
| 9676 | uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, |
| 9677 | uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { |
| 9678 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9679 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9680 | std::unique_lock<std::mutex> lock(global_lock); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9681 | GLOBAL_CB_NODE *cb_state = getCBNode(dev_data, commandBuffer); |
| 9682 | if (cb_state) { |
| 9683 | skip |= ValidateStageMasksAgainstQueueCapabilities(dev_data, cb_state, srcStageMask, dstStageMask, "vkCmdPipelineBarrier", |
| 9684 | VALIDATION_ERROR_02513); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9685 | skip |= ValidateCmd(dev_data, cb_state, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); |
Tobin Ehlis | b093da8 | 2017-01-19 12:05:27 -0700 | [diff] [blame] | 9686 | skip |= ValidateStageMaskGsTsEnables(dev_data, srcStageMask, "vkCmdPipelineBarrier()", VALIDATION_ERROR_00265, |
| 9687 | VALIDATION_ERROR_00267); |
| 9688 | skip |= ValidateStageMaskGsTsEnables(dev_data, dstStageMask, "vkCmdPipelineBarrier()", VALIDATION_ERROR_00266, |
| 9689 | VALIDATION_ERROR_00268); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9690 | UpdateCmdBufferLastCmd(dev_data, cb_state, CMD_PIPELINEBARRIER); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9691 | skip |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); |
| 9692 | skip |= ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, |
| 9693 | bufferMemoryBarrierCount, pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9694 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9695 | lock.unlock(); |
Mark Lobodzinski | 45f4492 | 2016-12-12 08:27:42 -0700 | [diff] [blame] | 9696 | if (!skip) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9697 | dev_data->dispatch_table.CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, memoryBarrierCount, |
| 9698 | pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, |
| 9699 | imageMemoryBarrierCount, pImageMemoryBarriers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9700 | } |
| 9701 | |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9702 | bool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { |
| 9703 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
| 9704 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9705 | if (pCB) { |
| 9706 | pCB->queryToStateMap[object] = value; |
| 9707 | } |
| 9708 | auto queue_data = dev_data->queueMap.find(queue); |
| 9709 | if (queue_data != dev_data->queueMap.end()) { |
| 9710 | queue_data->second.queryToStateMap[object] = value; |
| 9711 | } |
| 9712 | return false; |
| 9713 | } |
| 9714 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9715 | VKAPI_ATTR void VKAPI_CALL |
| 9716 | CmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9717 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9718 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9719 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9720 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9721 | if (pCB) { |
| 9722 | QueryObject query = {queryPool, slot}; |
| 9723 | pCB->activeQueries.insert(query); |
| 9724 | if (!pCB->startedQueries.count(query)) { |
| 9725 | pCB->startedQueries.insert(query); |
| 9726 | } |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9727 | skip_call |= ValidateCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); |
| 9728 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_BEGINQUERY); |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 9729 | addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| 9730 | {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9731 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9732 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9733 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9734 | dev_data->dispatch_table.CmdBeginQuery(commandBuffer, queryPool, slot, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9735 | } |
| 9736 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9737 | VKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9738 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9739 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9740 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9741 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9742 | if (pCB) { |
| 9743 | QueryObject query = {queryPool, slot}; |
| 9744 | if (!pCB->activeQueries.count(query)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9745 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9746 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9747 | VALIDATION_ERROR_01041, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d. %s", |
| 9748 | (uint64_t)(queryPool), slot, validation_error_map[VALIDATION_ERROR_01041]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9749 | } else { |
| 9750 | pCB->activeQueries.erase(query); |
| 9751 | } |
Karl Schultz | 63c1eb5 | 2016-05-24 13:49:59 -0600 | [diff] [blame] | 9752 | std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9753 | pCB->queryUpdates.push_back(queryUpdate); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9754 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9755 | skip_call |= ValidateCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); |
| 9756 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_ENDQUERY); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9757 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9758 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9759 | } |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 9760 | addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| 9761 | {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9762 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9763 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9764 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9765 | dev_data->dispatch_table.CmdEndQuery(commandBuffer, queryPool, slot); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9766 | } |
| 9767 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9768 | VKAPI_ATTR void VKAPI_CALL |
| 9769 | CmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9770 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9771 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9772 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9773 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9774 | if (pCB) { |
| 9775 | for (uint32_t i = 0; i < queryCount; i++) { |
| 9776 | QueryObject query = {queryPool, firstQuery + i}; |
| 9777 | pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; |
Karl Schultz | 63c1eb5 | 2016-05-24 13:49:59 -0600 | [diff] [blame] | 9778 | std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9779 | pCB->queryUpdates.push_back(queryUpdate); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9780 | } |
| 9781 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9782 | skip_call |= ValidateCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); |
| 9783 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_RESETQUERYPOOL); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9784 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9785 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9786 | } |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9787 | skip_call |= insideRenderPass(dev_data, pCB, "vkCmdResetQueryPool()", VALIDATION_ERROR_01025); |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 9788 | addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| 9789 | {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9790 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9791 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9792 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9793 | dev_data->dispatch_table.CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9794 | } |
| 9795 | |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9796 | bool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { |
| 9797 | bool skip_call = false; |
| 9798 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); |
| 9799 | auto queue_data = dev_data->queueMap.find(queue); |
| 9800 | if (queue_data == dev_data->queueMap.end()) |
| 9801 | return false; |
| 9802 | for (uint32_t i = 0; i < queryCount; i++) { |
| 9803 | QueryObject query = {queryPool, firstQuery + i}; |
| 9804 | auto query_data = queue_data->second.queryToStateMap.find(query); |
| 9805 | bool fail = false; |
| 9806 | if (query_data != queue_data->second.queryToStateMap.end()) { |
| 9807 | if (!query_data->second) { |
| 9808 | fail = true; |
| 9809 | } |
| 9810 | } else { |
| 9811 | auto global_query_data = dev_data->queryToStateMap.find(query); |
| 9812 | if (global_query_data != dev_data->queryToStateMap.end()) { |
| 9813 | if (!global_query_data->second) { |
| 9814 | fail = true; |
| 9815 | } |
| 9816 | } else { |
| 9817 | fail = true; |
| 9818 | } |
| 9819 | } |
| 9820 | if (fail) { |
| 9821 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9822 | DRAWSTATE_INVALID_QUERY, "DS", |
| 9823 | "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", |
| 9824 | reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); |
| 9825 | } |
| 9826 | } |
| 9827 | return skip_call; |
| 9828 | } |
| 9829 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9830 | VKAPI_ATTR void VKAPI_CALL |
| 9831 | CmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, |
| 9832 | VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9833 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9834 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9835 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 9836 | |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9837 | auto cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 9838 | auto dst_buff_state = getBufferState(dev_data, dstBuffer); |
| 9839 | if (cb_node && dst_buff_state) { |
Tobin Ehlis | e1995fc | 2016-12-22 12:45:09 -0700 | [diff] [blame] | 9840 | skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_state, "vkCmdCopyQueryPoolResults()", VALIDATION_ERROR_02526); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 9841 | // Update bindings between buffer and cmd buffer |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 9842 | AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_state); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 9843 | // Validate that DST buffer has correct usage flags set |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 9844 | skip_call |= |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 9845 | ValidateBufferUsageFlags(dev_data, dst_buff_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, VALIDATION_ERROR_01066, |
Jeremy Hayes | c5a60b0 | 2016-11-15 15:41:47 -0700 | [diff] [blame] | 9846 | "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9847 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 4668dce | 2016-11-16 09:30:23 -0700 | [diff] [blame] | 9848 | SetBufferMemoryValid(dev_data, dst_buff_state, true); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 9849 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9850 | }; |
Tobin Ehlis | 6dd053f | 2016-06-24 12:31:29 -0600 | [diff] [blame] | 9851 | cb_node->validate_functions.push_back(function); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9852 | std::function<bool(VkQueue)> queryUpdate = |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 9853 | std::bind(validateQuery, std::placeholders::_1, cb_node, queryPool, queryCount, firstQuery); |
| 9854 | cb_node->queryUpdates.push_back(queryUpdate); |
| 9855 | if (cb_node->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9856 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); |
| 9857 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9858 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9859 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9860 | } |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 9861 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyQueryPoolResults()", VALIDATION_ERROR_01074); |
Tobin Ehlis | 2e8f532 | 2016-07-08 14:22:01 -0600 | [diff] [blame] | 9862 | addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, |
| 9863 | {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, cb_node); |
Tobin Ehlis | 3ddfa5b | 2016-06-28 14:04:54 -0600 | [diff] [blame] | 9864 | } else { |
| 9865 | assert(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9866 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9867 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9868 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9869 | dev_data->dispatch_table.CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, dstOffset, |
| 9870 | stride, flags); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9871 | } |
| 9872 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9873 | VKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, |
| 9874 | VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, |
| 9875 | const void *pValues) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9876 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9877 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9878 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9879 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9880 | if (pCB) { |
| 9881 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9882 | skip_call |= ValidateCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); |
| 9883 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_PUSHCONSTANTS); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9884 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9885 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9886 | } |
| 9887 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9888 | skip_call |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 9889 | if (0 == stageFlags) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9890 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9891 | VALIDATION_ERROR_00996, "DS", "vkCmdPushConstants() call has no stageFlags set. %s", |
| 9892 | validation_error_map[VALIDATION_ERROR_00996]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9893 | } |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 9894 | |
Karl Schultz | c81037d | 2016-05-12 08:11:23 -0600 | [diff] [blame] | 9895 | // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. |
Tobin Ehlis | c1d9be1 | 2016-10-13 10:18:18 -0600 | [diff] [blame] | 9896 | auto pipeline_layout = getPipelineLayout(dev_data, layout); |
Tobin Ehlis | fbc847c | 2016-07-18 16:22:03 -0600 | [diff] [blame] | 9897 | // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is |
| 9898 | // contained in the pipeline ranges. |
| 9899 | // Build a {start, end} span list for ranges with matching stage flags. |
| 9900 | const auto &ranges = pipeline_layout->push_constant_ranges; |
| 9901 | struct span { |
| 9902 | uint32_t start; |
| 9903 | uint32_t end; |
| 9904 | }; |
| 9905 | std::vector<span> spans; |
| 9906 | spans.reserve(ranges.size()); |
| 9907 | for (const auto &iter : ranges) { |
| 9908 | if (iter.stageFlags == stageFlags) { |
| 9909 | spans.push_back({iter.offset, iter.offset + iter.size}); |
| 9910 | } |
| 9911 | } |
| 9912 | if (spans.size() == 0) { |
| 9913 | // There were no ranges that matched the stageFlags. |
| 9914 | skip_call |= |
| 9915 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9916 | VALIDATION_ERROR_00988, "DS", "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " |
| 9917 | "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ". %s", |
| 9918 | (uint32_t)stageFlags, (uint64_t)layout, validation_error_map[VALIDATION_ERROR_00988]); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 9919 | } else { |
Tobin Ehlis | fbc847c | 2016-07-18 16:22:03 -0600 | [diff] [blame] | 9920 | // Sort span list by start value. |
| 9921 | struct comparer { |
| 9922 | bool operator()(struct span i, struct span j) { return i.start < j.start; } |
| 9923 | } my_comparer; |
| 9924 | std::sort(spans.begin(), spans.end(), my_comparer); |
| 9925 | |
| 9926 | // Examine two spans at a time. |
| 9927 | std::vector<span>::iterator current = spans.begin(); |
| 9928 | std::vector<span>::iterator next = current + 1; |
| 9929 | while (next != spans.end()) { |
| 9930 | if (current->end < next->start) { |
| 9931 | // There is a gap; cannot coalesce. Move to the next two spans. |
| 9932 | ++current; |
| 9933 | ++next; |
| 9934 | } else { |
| 9935 | // Coalesce the two spans. The start of the next span |
| 9936 | // is within the current span, so pick the larger of |
| 9937 | // the end values to extend the current span. |
| 9938 | // Then delete the next span and set next to the span after it. |
| 9939 | current->end = max(current->end, next->end); |
| 9940 | next = spans.erase(next); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 9941 | } |
| 9942 | } |
Karl Schultz | c81037d | 2016-05-12 08:11:23 -0600 | [diff] [blame] | 9943 | |
Tobin Ehlis | fbc847c | 2016-07-18 16:22:03 -0600 | [diff] [blame] | 9944 | // Now we can check if the incoming range is within any of the spans. |
| 9945 | bool contained_in_a_range = false; |
| 9946 | for (uint32_t i = 0; i < spans.size(); ++i) { |
| 9947 | if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { |
| 9948 | contained_in_a_range = true; |
| 9949 | break; |
Karl Schultz | c81037d | 2016-05-12 08:11:23 -0600 | [diff] [blame] | 9950 | } |
Tobin Ehlis | fbc847c | 2016-07-18 16:22:03 -0600 | [diff] [blame] | 9951 | } |
| 9952 | if (!contained_in_a_range) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9953 | skip_call |= log_msg( |
| 9954 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 9955 | VALIDATION_ERROR_00988, "DS", "vkCmdPushConstants() Push constant range [%d, %d) " |
| 9956 | "with stageFlags = 0x%" PRIx32 " " |
| 9957 | "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ". %s", |
| 9958 | offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout, validation_error_map[VALIDATION_ERROR_00988]); |
Karl Schultz | fc8eaf1 | 2016-05-06 13:56:42 -0600 | [diff] [blame] | 9959 | } |
| 9960 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9961 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9962 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9963 | dev_data->dispatch_table.CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9964 | } |
| 9965 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 9966 | VKAPI_ATTR void VKAPI_CALL |
| 9967 | CmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9968 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9969 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9970 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9971 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 9972 | if (pCB) { |
| 9973 | QueryObject query = {queryPool, slot}; |
Karl Schultz | 63c1eb5 | 2016-05-24 13:49:59 -0600 | [diff] [blame] | 9974 | std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); |
Michael Lentine | 5627e69 | 2016-05-20 17:45:02 -0500 | [diff] [blame] | 9975 | pCB->queryUpdates.push_back(queryUpdate); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9976 | if (pCB->state == CB_RECORDING) { |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 9977 | skip_call |= ValidateCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); |
| 9978 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_WRITETIMESTAMP); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9979 | } else { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9980 | skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9981 | } |
| 9982 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 9983 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 9984 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 9985 | dev_data->dispatch_table.CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 9986 | } |
| 9987 | |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 9988 | static bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 9989 | const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag, |
| 9990 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 9991 | bool skip_call = false; |
| 9992 | |
| 9993 | for (uint32_t attach = 0; attach < count; attach++) { |
| 9994 | if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { |
| 9995 | // Attachment counts are verified elsewhere, but prevent an invalid access |
| 9996 | if (attachments[attach].attachment < fbci->attachmentCount) { |
| 9997 | const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 9998 | auto view_state = getImageViewState(dev_data, *image_view); |
| 9999 | if (view_state) { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10000 | const VkImageCreateInfo *ici = &getImageState(dev_data, view_state->create_info.image)->createInfo; |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10001 | if (ici != nullptr) { |
| 10002 | if ((ici->usage & usage_flag) == 0) { |
| 10003 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10004 | (VkDebugReportObjectTypeEXT)0, 0, __LINE__, error_code, "DS", |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10005 | "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10006 | "IMAGE_USAGE flags (%s). %s", |
| 10007 | attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag), |
| 10008 | validation_error_map[error_code]); |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10009 | } |
| 10010 | } |
| 10011 | } |
| 10012 | } |
| 10013 | } |
| 10014 | } |
| 10015 | return skip_call; |
| 10016 | } |
| 10017 | |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 10018 | // Validate VkFramebufferCreateInfo which includes: |
| 10019 | // 1. attachmentCount equals renderPass attachmentCount |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10020 | // 2. corresponding framebuffer and renderpass attachments have matching formats |
| 10021 | // 3. corresponding framebuffer and renderpass attachments have matching sample counts |
| 10022 | // 4. fb attachments only have a single mip level |
| 10023 | // 5. fb attachment dimensions are each at least as large as the fb |
| 10024 | // 6. fb attachments use idenity swizzle |
| 10025 | // 7. fb attachments used by renderPass for color/input/ds have correct usage bit set |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10026 | // 8. fb dimensions are within physical device limits |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 10027 | static bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10028 | bool skip_call = false; |
| 10029 | |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10030 | auto rp_state = getRenderPassState(dev_data, pCreateInfo->renderPass); |
| 10031 | if (rp_state) { |
| 10032 | const VkRenderPassCreateInfo *rpci = rp_state->createInfo.ptr(); |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 10033 | if (rpci->attachmentCount != pCreateInfo->attachmentCount) { |
| 10034 | skip_call |= log_msg( |
| 10035 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10036 | reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, VALIDATION_ERROR_00404, "DS", |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 10037 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachmentCount of %u does not match attachmentCount of %u of " |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10038 | "renderPass (0x%" PRIxLEAST64 ") being used to create Framebuffer. %s", |
| 10039 | pCreateInfo->attachmentCount, rpci->attachmentCount, reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), |
| 10040 | validation_error_map[VALIDATION_ERROR_00404]); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10041 | } else { |
Tobin Ehlis | dae051d | 2016-06-22 14:16:06 -0600 | [diff] [blame] | 10042 | // attachmentCounts match, so make sure corresponding attachment details line up |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10043 | const VkImageView *image_views = pCreateInfo->pAttachments; |
| 10044 | for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10045 | auto view_state = getImageViewState(dev_data, image_views[i]); |
Tobin Ehlis | c8ca031 | 2016-09-22 07:30:05 -0600 | [diff] [blame] | 10046 | auto &ivci = view_state->create_info; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10047 | if (ivci.format != rpci->pAttachments[i].format) { |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10048 | skip_call |= log_msg( |
| 10049 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10050 | reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, VALIDATION_ERROR_00408, "DS", |
| 10051 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has format of %s that does not match " |
| 10052 | "the format of " |
| 10053 | "%s used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 "). %s", |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10054 | i, string_VkFormat(ivci.format), string_VkFormat(rpci->pAttachments[i].format), |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10055 | reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), validation_error_map[VALIDATION_ERROR_00408]); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10056 | } |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10057 | const VkImageCreateInfo *ici = &getImageState(dev_data, ivci.image)->createInfo; |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10058 | if (ici->samples != rpci->pAttachments[i].samples) { |
Tobin Ehlis | dae051d | 2016-06-22 14:16:06 -0600 | [diff] [blame] | 10059 | skip_call |= log_msg( |
| 10060 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10061 | reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, VALIDATION_ERROR_00409, "DS", |
| 10062 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has %s samples that do not match " |
| 10063 | "the %s samples used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 "). %s", |
Tobin Ehlis | dae051d | 2016-06-22 14:16:06 -0600 | [diff] [blame] | 10064 | i, string_VkSampleCountFlagBits(ici->samples), string_VkSampleCountFlagBits(rpci->pAttachments[i].samples), |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10065 | reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), validation_error_map[VALIDATION_ERROR_00409]); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10066 | } |
| 10067 | // Verify that view only has a single mip level |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10068 | if (ivci.subresourceRange.levelCount != 1) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10069 | skip_call |= |
| 10070 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 10071 | VALIDATION_ERROR_00411, "DS", |
| 10072 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has mip levelCount of %u " |
| 10073 | "but only a single mip level (levelCount == 1) is allowed when creating a Framebuffer. %s", |
| 10074 | i, ivci.subresourceRange.levelCount, validation_error_map[VALIDATION_ERROR_00411]); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10075 | } |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10076 | const uint32_t mip_level = ivci.subresourceRange.baseMipLevel; |
Tobin Ehlis | f058eca | 2016-06-22 16:38:29 -0600 | [diff] [blame] | 10077 | uint32_t mip_width = max(1u, ici->extent.width >> mip_level); |
| 10078 | uint32_t mip_height = max(1u, ici->extent.height >> mip_level); |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10079 | if ((ivci.subresourceRange.layerCount < pCreateInfo->layers) || (mip_width < pCreateInfo->width) || |
Tobin Ehlis | f058eca | 2016-06-22 16:38:29 -0600 | [diff] [blame] | 10080 | (mip_height < pCreateInfo->height)) { |
| 10081 | skip_call |= |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10082 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
Tobin Ehlis | f058eca | 2016-06-22 16:38:29 -0600 | [diff] [blame] | 10083 | DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", |
| 10084 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u mip level %u has dimensions smaller " |
| 10085 | "than the corresponding " |
| 10086 | "framebuffer dimensions. Attachment dimensions must be at least as large. Here are the respective " |
| 10087 | "dimensions for " |
| 10088 | "attachment #%u, framebuffer:\n" |
| 10089 | "width: %u, %u\n" |
| 10090 | "height: %u, %u\n" |
| 10091 | "layerCount: %u, %u\n", |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10092 | i, ivci.subresourceRange.baseMipLevel, i, mip_width, pCreateInfo->width, mip_height, |
| 10093 | pCreateInfo->height, ivci.subresourceRange.layerCount, pCreateInfo->layers); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10094 | } |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10095 | if (((ivci.components.r != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.r != VK_COMPONENT_SWIZZLE_R)) || |
| 10096 | ((ivci.components.g != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.g != VK_COMPONENT_SWIZZLE_G)) || |
| 10097 | ((ivci.components.b != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.b != VK_COMPONENT_SWIZZLE_B)) || |
| 10098 | ((ivci.components.a != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.a != VK_COMPONENT_SWIZZLE_A))) { |
Tobin Ehlis | 9e4f16b | 2016-06-23 07:49:12 -0600 | [diff] [blame] | 10099 | skip_call |= log_msg( |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10100 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10101 | VALIDATION_ERROR_00412, "DS", |
Tobin Ehlis | 9e4f16b | 2016-06-23 07:49:12 -0600 | [diff] [blame] | 10102 | "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has non-identy swizzle. All framebuffer " |
| 10103 | "attachments must have been created with the identity swizzle. Here are the actual swizzle values:\n" |
| 10104 | "r swizzle = %s\n" |
| 10105 | "g swizzle = %s\n" |
| 10106 | "b swizzle = %s\n" |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10107 | "a swizzle = %s\n" |
| 10108 | "%s", |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10109 | i, string_VkComponentSwizzle(ivci.components.r), string_VkComponentSwizzle(ivci.components.g), |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10110 | string_VkComponentSwizzle(ivci.components.b), string_VkComponentSwizzle(ivci.components.a), |
| 10111 | validation_error_map[VALIDATION_ERROR_00412]); |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10112 | } |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10113 | } |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 10114 | } |
Tobin Ehlis | fd00538 | 2016-06-22 13:32:23 -0600 | [diff] [blame] | 10115 | // Verify correct attachment usage flags |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10116 | for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { |
| 10117 | // Verify input attachments: |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10118 | skip_call |= |
| 10119 | MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, rpci->pSubpasses[subpass].pInputAttachments, |
| 10120 | pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT, VALIDATION_ERROR_00407); |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10121 | // Verify color attachments: |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10122 | skip_call |= |
| 10123 | MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, rpci->pSubpasses[subpass].pColorAttachments, |
| 10124 | pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, VALIDATION_ERROR_00405); |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10125 | // Verify depth/stencil attachments: |
| 10126 | if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { |
| 10127 | skip_call |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10128 | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, VALIDATION_ERROR_00406); |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10129 | } |
| 10130 | } |
| 10131 | } |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10132 | // Verify FB dimensions are within physical device limits |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10133 | if (pCreateInfo->width > dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth) { |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10134 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10135 | VALIDATION_ERROR_00413, "DS", |
| 10136 | "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo width exceeds physical device limits. " |
| 10137 | "Requested width: %u, device max: %u\n" |
| 10138 | "%s", |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10139 | pCreateInfo->width, dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10140 | validation_error_map[VALIDATION_ERROR_00413]); |
| 10141 | } |
| 10142 | if (pCreateInfo->height > dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight) { |
| 10143 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 10144 | VALIDATION_ERROR_00414, "DS", |
| 10145 | "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo height exceeds physical device limits. " |
| 10146 | "Requested height: %u, device max: %u\n" |
| 10147 | "%s", |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10148 | pCreateInfo->height, dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10149 | validation_error_map[VALIDATION_ERROR_00414]); |
| 10150 | } |
| 10151 | if (pCreateInfo->layers > dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers) { |
| 10152 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 10153 | VALIDATION_ERROR_00415, "DS", |
| 10154 | "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo layers exceeds physical device limits. " |
| 10155 | "Requested layers: %u, device max: %u\n" |
| 10156 | "%s", |
| 10157 | pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers, |
| 10158 | validation_error_map[VALIDATION_ERROR_00415]); |
Tobin Ehlis | a60950f | 2016-06-23 08:23:25 -0600 | [diff] [blame] | 10159 | } |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10160 | return skip_call; |
| 10161 | } |
| 10162 | |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10163 | // Validate VkFramebufferCreateInfo state prior to calling down chain to create Framebuffer object |
| 10164 | // Return true if an error is encountered and callback returns true to skip call down chain |
| 10165 | // false indicates that call down chain should proceed |
| 10166 | static bool PreCallValidateCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { |
| 10167 | // TODO : Verify that renderPass FB is created with is compatible with FB |
| 10168 | bool skip_call = false; |
Tobin Ehlis | d094523 | 2016-06-22 10:02:02 -0600 | [diff] [blame] | 10169 | skip_call |= ValidateFramebufferCreateInfo(dev_data, pCreateInfo); |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10170 | return skip_call; |
| 10171 | } |
| 10172 | |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10173 | // CreateFramebuffer state has been validated and call down chain completed so record new framebuffer object |
| 10174 | static void PostCallRecordCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo, VkFramebuffer fb) { |
| 10175 | // Shadow create info and store in map |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10176 | std::unique_ptr<FRAMEBUFFER_STATE> fb_state( |
| 10177 | new FRAMEBUFFER_STATE(fb, pCreateInfo, dev_data->renderPassMap[pCreateInfo->renderPass]->createInfo.ptr())); |
Tobin Ehlis | 042ec78 | 2016-06-23 14:25:22 -0600 | [diff] [blame] | 10178 | |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10179 | for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
| 10180 | VkImageView view = pCreateInfo->pAttachments[i]; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10181 | auto view_state = getImageViewState(dev_data, view); |
| 10182 | if (!view_state) { |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10183 | continue; |
| 10184 | } |
| 10185 | MT_FB_ATTACHMENT_INFO fb_info; |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 10186 | fb_info.mem = getImageState(dev_data, view_state->create_info.image)->binding.mem; |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 10187 | fb_info.view_state = view_state; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10188 | fb_info.image = view_state->create_info.image; |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10189 | fb_state->attachments.push_back(fb_info); |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10190 | } |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10191 | dev_data->frameBufferMap[fb] = std::move(fb_state); |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10192 | } |
| 10193 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 10194 | VKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, |
| 10195 | const VkAllocationCallbacks *pAllocator, |
| 10196 | VkFramebuffer *pFramebuffer) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10197 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10198 | std::unique_lock<std::mutex> lock(global_lock); |
| 10199 | bool skip_call = PreCallValidateCreateFramebuffer(dev_data, pCreateInfo); |
| 10200 | lock.unlock(); |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10201 | |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10202 | if (skip_call) |
| 10203 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 10204 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 10205 | VkResult result = dev_data->dispatch_table.CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10206 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10207 | if (VK_SUCCESS == result) { |
Tobin Ehlis | 7fad84d | 2016-06-22 09:06:48 -0600 | [diff] [blame] | 10208 | lock.lock(); |
Tobin Ehlis | b3d2681 | 2016-06-22 09:20:42 -0600 | [diff] [blame] | 10209 | PostCallRecordCreateFramebuffer(dev_data, pCreateInfo, *pFramebuffer); |
| 10210 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10211 | } |
| 10212 | return result; |
| 10213 | } |
| 10214 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10215 | static bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, |
| 10216 | std::unordered_set<uint32_t> &processed_nodes) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10217 | // If we have already checked this node we have not found a dependency path so return false. |
| 10218 | if (processed_nodes.count(index)) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10219 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10220 | processed_nodes.insert(index); |
| 10221 | const DAGNode &node = subpass_to_node[index]; |
| 10222 | // Look for a dependency path. If one exists return true else recurse on the previous nodes. |
Bruce Dawson | b86c3a1 | 2017-01-23 21:48:04 -0800 | [diff] [blame^] | 10223 | if (std::find(node.prev.begin(), node.prev.end(), static_cast<uint32_t>(dependent)) == node.prev.end()) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10224 | for (auto elem : node.prev) { |
| 10225 | if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10226 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10227 | } |
| 10228 | } else { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10229 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10230 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10231 | return false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10232 | } |
| 10233 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10234 | static bool CheckDependencyExists(const layer_data *dev_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10235 | const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { |
| 10236 | bool result = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10237 | // Loop through all subpasses that share the same attachment and make sure a dependency exists |
| 10238 | for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { |
Jamie Madill | 2b6b8d5 | 2016-04-04 15:09:51 -0400 | [diff] [blame] | 10239 | if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10240 | continue; |
| 10241 | const DAGNode &node = subpass_to_node[subpass]; |
| 10242 | // Check for a specified dependency between the two nodes. If one exists we are done. |
| 10243 | auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); |
| 10244 | auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); |
| 10245 | if (prev_elem == node.prev.end() && next_elem == node.next.end()) { |
Jan-Harald Fredriksen | 4b47838 | 2016-06-08 14:20:50 +0200 | [diff] [blame] | 10246 | // If no dependency exits an implicit dependency still might. If not, throw an error. |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10247 | std::unordered_set<uint32_t> processed_nodes; |
Jan-Harald Fredriksen | 4b47838 | 2016-06-08 14:20:50 +0200 | [diff] [blame] | 10248 | if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || |
| 10249 | FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10250 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10251 | __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", |
| 10252 | "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, |
| 10253 | dependent_subpasses[k]); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10254 | result = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10255 | } |
| 10256 | } |
| 10257 | } |
| 10258 | return result; |
| 10259 | } |
| 10260 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10261 | static bool CheckPreserved(const layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10262 | const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10263 | const DAGNode &node = subpass_to_node[index]; |
| 10264 | // If this node writes to the attachment return true as next nodes need to preserve the attachment. |
| 10265 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; |
| 10266 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 10267 | if (attachment == subpass.pColorAttachments[j].attachment) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10268 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10269 | } |
| 10270 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 10271 | if (attachment == subpass.pDepthStencilAttachment->attachment) |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10272 | return true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10273 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10274 | bool result = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10275 | // Loop through previous nodes and see if any of them write to the attachment. |
| 10276 | for (auto elem : node.prev) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10277 | result |= CheckPreserved(dev_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10278 | } |
| 10279 | // If the attachment was written to by a previous node than this node needs to preserve it. |
| 10280 | if (result && depth > 0) { |
| 10281 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10282 | bool has_preserved = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10283 | for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { |
| 10284 | if (subpass.pPreserveAttachments[j] == attachment) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10285 | has_preserved = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10286 | break; |
| 10287 | } |
| 10288 | } |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10289 | if (!has_preserved) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10290 | skip_call |= |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10291 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10292 | DRAWSTATE_INVALID_RENDERPASS, "DS", |
| 10293 | "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); |
| 10294 | } |
| 10295 | } |
| 10296 | return result; |
| 10297 | } |
| 10298 | |
| 10299 | template <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { |
| 10300 | return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || |
| 10301 | ((offset1 > offset2) && (offset1 < (offset2 + size2))); |
| 10302 | } |
| 10303 | |
| 10304 | bool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { |
| 10305 | return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && |
| 10306 | isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); |
| 10307 | } |
| 10308 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10309 | static bool ValidateDependencies(const layer_data *dev_data, FRAMEBUFFER_STATE const *framebuffer, |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10310 | RENDER_PASS_STATE const *renderPass) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10311 | bool skip_call = false; |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10312 | auto const pFramebufferInfo = framebuffer->createInfo.ptr(); |
| 10313 | auto const pCreateInfo = renderPass->createInfo.ptr(); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10314 | auto const & subpass_to_node = renderPass->subpassToNode; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10315 | std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); |
| 10316 | std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); |
| 10317 | std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); |
| 10318 | // Find overlapping attachments |
| 10319 | for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
| 10320 | for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { |
| 10321 | VkImageView viewi = pFramebufferInfo->pAttachments[i]; |
| 10322 | VkImageView viewj = pFramebufferInfo->pAttachments[j]; |
| 10323 | if (viewi == viewj) { |
| 10324 | overlapping_attachments[i].push_back(j); |
| 10325 | overlapping_attachments[j].push_back(i); |
| 10326 | continue; |
| 10327 | } |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10328 | auto view_state_i = getImageViewState(dev_data, viewi); |
| 10329 | auto view_state_j = getImageViewState(dev_data, viewj); |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10330 | if (!view_state_i || !view_state_j) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10331 | continue; |
| 10332 | } |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10333 | auto view_ci_i = view_state_i->create_info; |
| 10334 | auto view_ci_j = view_state_j->create_info; |
| 10335 | if (view_ci_i.image == view_ci_j.image && isRegionOverlapping(view_ci_i.subresourceRange, view_ci_j.subresourceRange)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10336 | overlapping_attachments[i].push_back(j); |
| 10337 | overlapping_attachments[j].push_back(i); |
| 10338 | continue; |
| 10339 | } |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10340 | auto image_data_i = getImageState(dev_data, view_ci_i.image); |
| 10341 | auto image_data_j = getImageState(dev_data, view_ci_j.image); |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 10342 | if (!image_data_i || !image_data_j) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10343 | continue; |
| 10344 | } |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 10345 | if (image_data_i->binding.mem == image_data_j->binding.mem && |
| 10346 | isRangeOverlapping(image_data_i->binding.offset, image_data_i->binding.size, image_data_j->binding.offset, |
| 10347 | image_data_j->binding.size)) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10348 | overlapping_attachments[i].push_back(j); |
| 10349 | overlapping_attachments[j].push_back(i); |
| 10350 | } |
| 10351 | } |
| 10352 | } |
| 10353 | for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { |
| 10354 | uint32_t attachment = i; |
| 10355 | for (auto other_attachment : overlapping_attachments[i]) { |
| 10356 | if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10357 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 10358 | __LINE__, VALIDATION_ERROR_00324, "DS", "Attachment %d aliases attachment %d but doesn't " |
| 10359 | "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT. %s", |
| 10360 | attachment, other_attachment, validation_error_map[VALIDATION_ERROR_00324]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10361 | } |
| 10362 | if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10363 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 10364 | __LINE__, VALIDATION_ERROR_00324, "DS", "Attachment %d aliases attachment %d but doesn't " |
| 10365 | "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT. %s", |
| 10366 | other_attachment, attachment, validation_error_map[VALIDATION_ERROR_00324]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10367 | } |
| 10368 | } |
| 10369 | } |
| 10370 | // Find for each attachment the subpasses that use them. |
Mark Young | f5bba55 | 2016-03-30 02:23:18 -0600 | [diff] [blame] | 10371 | unordered_set<uint32_t> attachmentIndices; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10372 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10373 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
Mark Young | f5bba55 | 2016-03-30 02:23:18 -0600 | [diff] [blame] | 10374 | attachmentIndices.clear(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10375 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| 10376 | uint32_t attachment = subpass.pInputAttachments[j].attachment; |
Chris Forbes | ac82518 | 2016-07-01 11:45:49 +1200 | [diff] [blame] | 10377 | if (attachment == VK_ATTACHMENT_UNUSED) |
| 10378 | continue; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10379 | input_attachment_to_subpass[attachment].push_back(i); |
| 10380 | for (auto overlapping_attachment : overlapping_attachments[attachment]) { |
| 10381 | input_attachment_to_subpass[overlapping_attachment].push_back(i); |
| 10382 | } |
| 10383 | } |
| 10384 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 10385 | uint32_t attachment = subpass.pColorAttachments[j].attachment; |
Chris Forbes | ac82518 | 2016-07-01 11:45:49 +1200 | [diff] [blame] | 10386 | if (attachment == VK_ATTACHMENT_UNUSED) |
| 10387 | continue; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10388 | output_attachment_to_subpass[attachment].push_back(i); |
| 10389 | for (auto overlapping_attachment : overlapping_attachments[attachment]) { |
| 10390 | output_attachment_to_subpass[overlapping_attachment].push_back(i); |
| 10391 | } |
Mark Young | f5bba55 | 2016-03-30 02:23:18 -0600 | [diff] [blame] | 10392 | attachmentIndices.insert(attachment); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10393 | } |
| 10394 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 10395 | uint32_t attachment = subpass.pDepthStencilAttachment->attachment; |
| 10396 | output_attachment_to_subpass[attachment].push_back(i); |
| 10397 | for (auto overlapping_attachment : overlapping_attachments[attachment]) { |
| 10398 | output_attachment_to_subpass[overlapping_attachment].push_back(i); |
| 10399 | } |
Mark Young | f5bba55 | 2016-03-30 02:23:18 -0600 | [diff] [blame] | 10400 | |
| 10401 | if (attachmentIndices.count(attachment)) { |
| 10402 | skip_call |= |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10403 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 10404 | DRAWSTATE_INVALID_RENDERPASS, "DS", |
| 10405 | "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", attachment, i); |
Mark Young | f5bba55 | 2016-03-30 02:23:18 -0600 | [diff] [blame] | 10406 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10407 | } |
| 10408 | } |
| 10409 | // If there is a dependency needed make sure one exists |
| 10410 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10411 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| 10412 | // If the attachment is an input then all subpasses that output must have a dependency relationship |
| 10413 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Chris Forbes | ac82518 | 2016-07-01 11:45:49 +1200 | [diff] [blame] | 10414 | uint32_t attachment = subpass.pInputAttachments[j].attachment; |
| 10415 | if (attachment == VK_ATTACHMENT_UNUSED) |
| 10416 | continue; |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10417 | CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10418 | } |
| 10419 | // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship |
| 10420 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
Chris Forbes | ac82518 | 2016-07-01 11:45:49 +1200 | [diff] [blame] | 10421 | uint32_t attachment = subpass.pColorAttachments[j].attachment; |
| 10422 | if (attachment == VK_ATTACHMENT_UNUSED) |
| 10423 | continue; |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10424 | CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
| 10425 | CheckDependencyExists(dev_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10426 | } |
| 10427 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 10428 | const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10429 | CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
| 10430 | CheckDependencyExists(dev_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10431 | } |
| 10432 | } |
| 10433 | // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was |
| 10434 | // written. |
| 10435 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10436 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| 10437 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10438 | CheckPreserved(dev_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10439 | } |
| 10440 | } |
| 10441 | return skip_call; |
| 10442 | } |
Tobin Ehlis | db11af6 | 2016-05-11 10:38:29 -0600 | [diff] [blame] | 10443 | // ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the |
| 10444 | // VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that |
| 10445 | // READ_ONLY layout attachments don't have CLEAR as their loadOp. |
| 10446 | static bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, |
| 10447 | const uint32_t attachment, |
| 10448 | const VkAttachmentDescription &attachment_description) { |
| 10449 | bool skip_call = false; |
| 10450 | // Verify that initial loadOp on READ_ONLY attachments is not CLEAR |
| 10451 | if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { |
| 10452 | if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || |
| 10453 | (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10454 | skip_call |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, |
| 10455 | VkDebugReportObjectTypeEXT(0), __LINE__, VALIDATION_ERROR_02351, "DS", |
| 10456 | "Cannot clear attachment %d with invalid first layout %s. %s", attachment, |
| 10457 | string_VkImageLayout(first_layout), validation_error_map[VALIDATION_ERROR_02351]); |
Tobin Ehlis | db11af6 | 2016-05-11 10:38:29 -0600 | [diff] [blame] | 10458 | } |
| 10459 | } |
| 10460 | return skip_call; |
| 10461 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10462 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10463 | static bool ValidateLayouts(const layer_data *dev_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10464 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10465 | |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10466 | // Track when we're observing the first use of an attachment |
| 10467 | std::vector<bool> attach_first_use(pCreateInfo->attachmentCount, true); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10468 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10469 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10470 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 10471 | auto attach_index = subpass.pColorAttachments[j].attachment; |
| 10472 | if (attach_index == VK_ATTACHMENT_UNUSED) |
| 10473 | continue; |
| 10474 | |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10475 | switch (subpass.pColorAttachments[j].layout) { |
| 10476 | case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10477 | // This is ideal. |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10478 | break; |
| 10479 | |
| 10480 | case VK_IMAGE_LAYOUT_GENERAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10481 | // May not be optimal; TODO: reconsider this warning based on other constraints? |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10482 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 10483 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10484 | "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); |
| 10485 | break; |
| 10486 | |
| 10487 | default: |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10488 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 10489 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10490 | "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", |
| 10491 | string_VkImageLayout(subpass.pColorAttachments[j].layout)); |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10492 | } |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10493 | |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10494 | if (attach_first_use[attach_index]) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10495 | skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pColorAttachments[j].layout, |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10496 | attach_index, pCreateInfo->pAttachments[attach_index]); |
| 10497 | } |
| 10498 | attach_first_use[attach_index] = false; |
| 10499 | } |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10500 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
Chris Forbes | c5dd9bc | 2016-08-09 08:17:14 +1200 | [diff] [blame] | 10501 | switch (subpass.pDepthStencilAttachment->layout) { |
| 10502 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: |
| 10503 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10504 | // These are ideal. |
Chris Forbes | c5dd9bc | 2016-08-09 08:17:14 +1200 | [diff] [blame] | 10505 | break; |
| 10506 | |
| 10507 | case VK_IMAGE_LAYOUT_GENERAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10508 | // May not be optimal; TODO: reconsider this warning based on other constraints? GENERAL can be better than doing |
| 10509 | // a bunch of transitions. |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10510 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 10511 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Chris Forbes | c5dd9bc | 2016-08-09 08:17:14 +1200 | [diff] [blame] | 10512 | "GENERAL layout for depth attachment may not give optimal performance."); |
| 10513 | break; |
| 10514 | |
| 10515 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10516 | // No other layouts are acceptable |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10517 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 10518 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Chris Forbes | c5dd9bc | 2016-08-09 08:17:14 +1200 | [diff] [blame] | 10519 | "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL, " |
| 10520 | "DEPTH_STENCIL_READ_ONLY_OPTIMAL or GENERAL.", |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10521 | string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10522 | } |
Chris Forbes | c5dd9bc | 2016-08-09 08:17:14 +1200 | [diff] [blame] | 10523 | |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10524 | auto attach_index = subpass.pDepthStencilAttachment->attachment; |
| 10525 | if (attach_first_use[attach_index]) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10526 | skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pDepthStencilAttachment->layout, |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10527 | attach_index, pCreateInfo->pAttachments[attach_index]); |
| 10528 | } |
| 10529 | attach_first_use[attach_index] = false; |
| 10530 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10531 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Chris Forbes | d9c27ca | 2016-07-01 11:28:00 +1200 | [diff] [blame] | 10532 | auto attach_index = subpass.pInputAttachments[j].attachment; |
| 10533 | if (attach_index == VK_ATTACHMENT_UNUSED) |
| 10534 | continue; |
| 10535 | |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10536 | switch (subpass.pInputAttachments[j].layout) { |
| 10537 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: |
| 10538 | case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10539 | // These are ideal. |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10540 | break; |
| 10541 | |
| 10542 | case VK_IMAGE_LAYOUT_GENERAL: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10543 | // May not be optimal. TODO: reconsider this warning based on other constraints. |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10544 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
| 10545 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10546 | "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); |
| 10547 | break; |
| 10548 | |
| 10549 | default: |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10550 | // No other layouts are acceptable |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10551 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10552 | DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", |
| 10553 | "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", |
| 10554 | string_VkImageLayout(subpass.pInputAttachments[j].layout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10555 | } |
Chris Forbes | f02c174 | 2016-08-10 10:41:27 +1200 | [diff] [blame] | 10556 | |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10557 | if (attach_first_use[attach_index]) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10558 | skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pInputAttachments[j].layout, |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10559 | attach_index, pCreateInfo->pAttachments[attach_index]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10560 | } |
Tobin Ehlis | e2843ff | 2016-07-18 19:01:43 -0600 | [diff] [blame] | 10561 | attach_first_use[attach_index] = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10562 | } |
| 10563 | } |
| 10564 | return skip; |
| 10565 | } |
| 10566 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10567 | static bool CreatePassDAG(const layer_data *dev_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10568 | std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { |
| 10569 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10570 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10571 | DAGNode &subpass_node = subpass_to_node[i]; |
| 10572 | subpass_node.pass = i; |
| 10573 | } |
| 10574 | for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { |
| 10575 | const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; |
Chris Forbes | 7f075fb | 2016-09-27 10:54:58 +1300 | [diff] [blame] | 10576 | if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL || dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { |
| 10577 | if (dependency.srcSubpass == dependency.dstSubpass) { |
| 10578 | skip_call |= |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10579 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Chris Forbes | 7f075fb | 2016-09-27 10:54:58 +1300 | [diff] [blame] | 10580 | DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); |
| 10581 | } |
Chris Forbes | 7f075fb | 2016-09-27 10:54:58 +1300 | [diff] [blame] | 10582 | } else if (dependency.srcSubpass > dependency.dstSubpass) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10583 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10584 | DRAWSTATE_INVALID_RENDERPASS, "DS", |
| 10585 | "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10586 | } else if (dependency.srcSubpass == dependency.dstSubpass) { |
| 10587 | has_self_dependency[dependency.srcSubpass] = true; |
Chris Forbes | 585a32b | 2016-10-26 15:45:33 +1300 | [diff] [blame] | 10588 | } else { |
| 10589 | subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); |
| 10590 | subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10591 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10592 | } |
| 10593 | return skip_call; |
| 10594 | } |
Chris Forbes | 90da2e9 | 2016-03-18 16:30:03 +1300 | [diff] [blame] | 10595 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10596 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 10597 | VKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, |
| 10598 | const VkAllocationCallbacks *pAllocator, |
| 10599 | VkShaderModule *pShaderModule) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10600 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10601 | bool skip_call = false; |
Chris Forbes | b4afd0f | 2016-04-04 10:48:35 +1200 | [diff] [blame] | 10602 | |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 10603 | // Use SPIRV-Tools validator to try and catch any issues with the module itself |
Chris Forbes | b4afd0f | 2016-04-04 10:48:35 +1200 | [diff] [blame] | 10604 | spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); |
| 10605 | spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; |
| 10606 | spv_diagnostic diag = nullptr; |
| 10607 | |
| 10608 | auto result = spvValidate(ctx, &binary, &diag); |
| 10609 | if (result != SPV_SUCCESS) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10610 | skip_call |= |
| 10611 | log_msg(dev_data->report_data, result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 10612 | VkDebugReportObjectTypeEXT(0), 0, __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", |
| 10613 | "SPIR-V module not valid: %s", diag && diag->error ? diag->error : "(no error text)"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10614 | } |
| 10615 | |
Chris Forbes | b4afd0f | 2016-04-04 10:48:35 +1200 | [diff] [blame] | 10616 | spvDiagnosticDestroy(diag); |
| 10617 | spvContextDestroy(ctx); |
| 10618 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10619 | if (skip_call) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10620 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 10621 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 10622 | VkResult res = dev_data->dispatch_table.CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10623 | |
| 10624 | if (res == VK_SUCCESS) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 10625 | std::lock_guard<std::mutex> lock(global_lock); |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10626 | dev_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10627 | } |
| 10628 | return res; |
| 10629 | } |
| 10630 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10631 | static bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10632 | bool skip_call = false; |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10633 | if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { |
| 10634 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Chris Forbes | 2d9b2a8 | 2016-11-21 10:45:39 +1300 | [diff] [blame] | 10635 | VALIDATION_ERROR_00325, "DS", |
| 10636 | "CreateRenderPass: %s attachment %d must be less than the total number of attachments %d. %s", |
| 10637 | type, attachment, attachment_count, validation_error_map[VALIDATION_ERROR_00325]); |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10638 | } |
| 10639 | return skip_call; |
| 10640 | } |
| 10641 | |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10642 | static bool IsPowerOfTwo(unsigned x) { |
| 10643 | return x && !(x & (x-1)); |
| 10644 | } |
| 10645 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10646 | static bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { |
| 10647 | bool skip_call = false; |
| 10648 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10649 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
| 10650 | if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10651 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 10652 | VALIDATION_ERROR_00347, "DS", |
| 10653 | "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS. %s", |
| 10654 | i, validation_error_map[VALIDATION_ERROR_00347]); |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10655 | } |
| 10656 | for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { |
| 10657 | uint32_t attachment = subpass.pPreserveAttachments[j]; |
| 10658 | if (attachment == VK_ATTACHMENT_UNUSED) { |
| 10659 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10660 | __LINE__, VALIDATION_ERROR_00356, "DS", |
| 10661 | "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED. %s", j, |
| 10662 | validation_error_map[VALIDATION_ERROR_00356]); |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10663 | } else { |
| 10664 | skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); |
| 10665 | } |
| 10666 | } |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10667 | |
| 10668 | auto subpass_performs_resolve = subpass.pResolveAttachments && std::any_of( |
| 10669 | subpass.pResolveAttachments, subpass.pResolveAttachments + subpass.colorAttachmentCount, |
| 10670 | [](VkAttachmentReference ref) { return ref.attachment != VK_ATTACHMENT_UNUSED; }); |
| 10671 | |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10672 | unsigned sample_count = 0; |
| 10673 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10674 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 10675 | uint32_t attachment; |
| 10676 | if (subpass.pResolveAttachments) { |
| 10677 | attachment = subpass.pResolveAttachments[j].attachment; |
| 10678 | skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10679 | |
| 10680 | if (!skip_call && attachment != VK_ATTACHMENT_UNUSED && |
| 10681 | pCreateInfo->pAttachments[attachment].samples != VK_SAMPLE_COUNT_1_BIT) { |
| 10682 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10683 | __LINE__, VALIDATION_ERROR_00352, "DS", |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10684 | "CreateRenderPass: Subpass %u requests multisample resolve into attachment %u, " |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10685 | "which must have VK_SAMPLE_COUNT_1_BIT but has %s. %s", |
| 10686 | i, attachment, string_VkSampleCountFlagBits(pCreateInfo->pAttachments[attachment].samples), |
| 10687 | validation_error_map[VALIDATION_ERROR_00352]); |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10688 | } |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10689 | } |
| 10690 | attachment = subpass.pColorAttachments[j].attachment; |
| 10691 | skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10692 | |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10693 | if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { |
| 10694 | sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10695 | |
Chris Forbes | 6655bb3 | 2016-07-01 18:27:30 +1200 | [diff] [blame] | 10696 | if (subpass_performs_resolve && |
| 10697 | pCreateInfo->pAttachments[attachment].samples == VK_SAMPLE_COUNT_1_BIT) { |
| 10698 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10699 | __LINE__, VALIDATION_ERROR_00351, "DS", |
Chris Forbes | 6655bb3 | 2016-07-01 18:27:30 +1200 | [diff] [blame] | 10700 | "CreateRenderPass: Subpass %u requests multisample resolve from attachment %u " |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10701 | "which has VK_SAMPLE_COUNT_1_BIT. %s", |
| 10702 | i, attachment, validation_error_map[VALIDATION_ERROR_00351]); |
Chris Forbes | 6655bb3 | 2016-07-01 18:27:30 +1200 | [diff] [blame] | 10703 | } |
Chris Forbes | d59af1e | 2016-06-29 11:50:31 +1200 | [diff] [blame] | 10704 | } |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10705 | } |
Chris Forbes | 6655bb3 | 2016-07-01 18:27:30 +1200 | [diff] [blame] | 10706 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10707 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 10708 | uint32_t attachment = subpass.pDepthStencilAttachment->attachment; |
| 10709 | skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10710 | |
| 10711 | if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { |
| 10712 | sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; |
| 10713 | } |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10714 | } |
Chris Forbes | 6655bb3 | 2016-07-01 18:27:30 +1200 | [diff] [blame] | 10715 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10716 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| 10717 | uint32_t attachment = subpass.pInputAttachments[j].attachment; |
| 10718 | skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); |
Chris Forbes | 3e4d7ac | 2016-05-06 16:11:03 +1200 | [diff] [blame] | 10719 | } |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10720 | |
| 10721 | if (sample_count && !IsPowerOfTwo(sample_count)) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10722 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, |
| 10723 | VALIDATION_ERROR_00337, "DS", "CreateRenderPass: Subpass %u attempts to render to " |
| 10724 | "attachments with inconsistent sample counts. %s", |
| 10725 | i, validation_error_map[VALIDATION_ERROR_00337]); |
Chris Forbes | 689010b | 2016-06-29 15:12:29 +1200 | [diff] [blame] | 10726 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10727 | } |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10728 | return skip_call; |
| 10729 | } |
| 10730 | |
| 10731 | VKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, |
| 10732 | const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10733 | bool skip_call = false; |
| 10734 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 10735 | |
| 10736 | std::unique_lock<std::mutex> lock(global_lock); |
| 10737 | |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10738 | // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with |
| 10739 | // ValidateLayouts. |
| 10740 | skip_call |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); |
Tobin Ehlis | b093da8 | 2017-01-19 12:05:27 -0700 | [diff] [blame] | 10741 | for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { |
| 10742 | skip_call |= ValidateStageMaskGsTsEnables(dev_data, pCreateInfo->pDependencies[i].srcStageMask, "vkCreateRenderPass()", |
| 10743 | VALIDATION_ERROR_00368, VALIDATION_ERROR_00370); |
| 10744 | skip_call |= ValidateStageMaskGsTsEnables(dev_data, pCreateInfo->pDependencies[i].dstStageMask, "vkCreateRenderPass()", |
| 10745 | VALIDATION_ERROR_00369, VALIDATION_ERROR_00371); |
| 10746 | } |
Chris Forbes | 7125136 | 2016-11-16 14:30:05 +1300 | [diff] [blame] | 10747 | if (!skip_call) { |
| 10748 | skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); |
| 10749 | } |
Chris Forbes | bf4a772 | 2016-06-21 18:30:46 +1200 | [diff] [blame] | 10750 | lock.unlock(); |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10751 | |
| 10752 | if (skip_call) { |
| 10753 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 10754 | } |
| 10755 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 10756 | VkResult result = dev_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); |
Chris Forbes | bf4a772 | 2016-06-21 18:30:46 +1200 | [diff] [blame] | 10757 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10758 | if (VK_SUCCESS == result) { |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10759 | lock.lock(); |
| 10760 | |
| 10761 | std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); |
| 10762 | std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); |
| 10763 | skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); |
| 10764 | |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10765 | auto render_pass = unique_ptr<RENDER_PASS_STATE>(new RENDER_PASS_STATE(pCreateInfo)); |
Chris Forbes | cad81b8 | 2016-05-06 16:11:29 +1200 | [diff] [blame] | 10766 | render_pass->renderPass = *pRenderPass; |
Chris Forbes | 3e4d7ac | 2016-05-06 16:11:03 +1200 | [diff] [blame] | 10767 | render_pass->hasSelfDependency = has_self_dependency; |
| 10768 | render_pass->subpassToNode = subpass_to_node; |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10769 | |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10770 | // TODO: Maybe fill list and then copy instead of locking |
Chris Forbes | 3e4d7ac | 2016-05-06 16:11:03 +1200 | [diff] [blame] | 10771 | std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; |
Mark Lobodzinski | 6753374 | 2016-06-16 13:23:02 -0600 | [diff] [blame] | 10772 | std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = render_pass->attachment_first_layout; |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10773 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
| 10774 | const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10775 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10776 | uint32_t attachment = subpass.pColorAttachments[j].attachment; |
| 10777 | if (!attachment_first_read.count(attachment)) { |
| 10778 | attachment_first_read.insert(std::make_pair(attachment, false)); |
| 10779 | attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); |
Michael Lentine | 5007eb9 | 2016-04-05 11:38:12 -0500 | [diff] [blame] | 10780 | } |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10781 | } |
| 10782 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 10783 | uint32_t attachment = subpass.pDepthStencilAttachment->attachment; |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10784 | if (!attachment_first_read.count(attachment)) { |
| 10785 | attachment_first_read.insert(std::make_pair(attachment, false)); |
| 10786 | attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); |
Michael Lentine | 9e1290e | 2016-03-31 14:45:20 -0500 | [diff] [blame] | 10787 | } |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10788 | } |
Michael Lentine | 4e8777c | 2016-03-31 13:46:44 -0500 | [diff] [blame] | 10789 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| 10790 | uint32_t attachment = subpass.pInputAttachments[j].attachment; |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10791 | if (!attachment_first_read.count(attachment)) { |
| 10792 | attachment_first_read.insert(std::make_pair(attachment, true)); |
| 10793 | attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); |
Michael Lentine | 9e1290e | 2016-03-31 14:45:20 -0500 | [diff] [blame] | 10794 | } |
Michael Lentine | 4e8777c | 2016-03-31 13:46:44 -0500 | [diff] [blame] | 10795 | } |
Tobin Ehlis | 5494852 | 2016-03-22 13:50:21 -0600 | [diff] [blame] | 10796 | } |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10797 | |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10798 | dev_data->renderPassMap[*pRenderPass] = std::move(render_pass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10799 | } |
| 10800 | return result; |
| 10801 | } |
Mark Lobodzinski | 9781070 | 2016-06-17 15:24:01 -0600 | [diff] [blame] | 10802 | |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 10803 | static bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10804 | bool skip_call = false; |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10805 | auto const pRenderPassInfo = getRenderPassState(dev_data, pRenderPassBegin->renderPass)->createInfo.ptr(); |
Chris Forbes | ef27c5b | 2016-09-27 12:03:04 +1300 | [diff] [blame] | 10806 | auto const & framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer]->createInfo; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10807 | if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { |
| 10808 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 10809 | DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " |
| 10810 | "with a different number of attachments."); |
| 10811 | } |
| 10812 | for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { |
| 10813 | const VkImageView &image_view = framebufferInfo.pAttachments[i]; |
Tobin Ehlis | 8b26a38 | 2016-09-14 08:02:49 -0600 | [diff] [blame] | 10814 | auto view_state = getImageViewState(dev_data, image_view); |
| 10815 | assert(view_state); |
| 10816 | const VkImage &image = view_state->create_info.image; |
| 10817 | const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10818 | IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, |
| 10819 | pRenderPassInfo->pAttachments[i].initialLayout}; |
| 10820 | // TODO: Do not iterate over every possibility - consolidate where possible |
| 10821 | for (uint32_t j = 0; j < subRange.levelCount; j++) { |
| 10822 | uint32_t level = subRange.baseMipLevel + j; |
| 10823 | for (uint32_t k = 0; k < subRange.layerCount; k++) { |
| 10824 | uint32_t layer = subRange.baseArrayLayer + k; |
| 10825 | VkImageSubresource sub = {subRange.aspectMask, level, layer}; |
| 10826 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
| 10827 | if (!FindLayout(pCB, image, sub, node)) { |
| 10828 | SetLayout(pCB, image, sub, newNode); |
| 10829 | continue; |
| 10830 | } |
Chris Forbes | e8d0209 | 2016-06-30 12:43:36 +1200 | [diff] [blame] | 10831 | if (newNode.layout != VK_IMAGE_LAYOUT_UNDEFINED && |
| 10832 | newNode.layout != node.layout) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10833 | skip_call |= |
| 10834 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Chris Forbes | e8d0209 | 2016-06-30 12:43:36 +1200 | [diff] [blame] | 10835 | DRAWSTATE_INVALID_RENDERPASS, "DS", |
| 10836 | "You cannot start a render pass using attachment %u " |
| 10837 | "where the render pass initial layout is %s and the previous " |
| 10838 | "known layout of the attachment is %s. The layouts must match, or " |
| 10839 | "the render pass initial layout for the attachment must be " |
| 10840 | "VK_IMAGE_LAYOUT_UNDEFINED", |
Michael Lentine | 8f6abe7 | 2016-03-24 21:36:53 -0500 | [diff] [blame] | 10841 | i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10842 | } |
| 10843 | } |
| 10844 | } |
| 10845 | } |
| 10846 | return skip_call; |
| 10847 | } |
| 10848 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10849 | static void TransitionAttachmentRefLayout(layer_data *dev_data, GLOBAL_CB_NODE *pCB, FRAMEBUFFER_STATE *pFramebuffer, |
| 10850 | VkAttachmentReference ref) { |
Chris Forbes | 853022c | 2016-06-30 16:56:15 +1200 | [diff] [blame] | 10851 | if (ref.attachment != VK_ATTACHMENT_UNUSED) { |
| 10852 | auto image_view = pFramebuffer->createInfo.pAttachments[ref.attachment]; |
| 10853 | SetLayout(dev_data, pCB, image_view, ref.layout); |
| 10854 | } |
| 10855 | } |
| 10856 | |
Chris Forbes | 59b3654 | 2016-05-17 15:31:00 +1200 | [diff] [blame] | 10857 | static void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10858 | const int subpass_index) { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10859 | auto renderPass = getRenderPassState(dev_data, pRenderPassBegin->renderPass); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10860 | if (!renderPass) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10861 | return; |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10862 | |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10863 | auto framebuffer = getFramebufferState(dev_data, pRenderPassBegin->framebuffer); |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 10864 | if (!framebuffer) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10865 | return; |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 10866 | |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10867 | auto const &subpass = renderPass->createInfo.pSubpasses[subpass_index]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10868 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
Chris Forbes | 853022c | 2016-06-30 16:56:15 +1200 | [diff] [blame] | 10869 | TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pInputAttachments[j]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10870 | } |
| 10871 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
Chris Forbes | 853022c | 2016-06-30 16:56:15 +1200 | [diff] [blame] | 10872 | TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pColorAttachments[j]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10873 | } |
Chris Forbes | 853022c | 2016-06-30 16:56:15 +1200 | [diff] [blame] | 10874 | if (subpass.pDepthStencilAttachment) { |
| 10875 | TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, *subpass.pDepthStencilAttachment); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10876 | } |
| 10877 | } |
| 10878 | |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10879 | static bool validatePrimaryCommandBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name, |
| 10880 | UNIQUE_VALIDATION_ERROR_CODE error_code) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 10881 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10882 | if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10883 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 10884 | error_code, "DS", "Cannot execute command %s on a secondary command buffer. %s", cmd_name.c_str(), |
| 10885 | validation_error_map[error_code]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10886 | } |
| 10887 | return skip_call; |
| 10888 | } |
| 10889 | |
Chris Forbes | 05e03b7 | 2016-05-17 15:27:58 +1200 | [diff] [blame] | 10890 | static void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10891 | auto renderPass = getRenderPassState(dev_data, pRenderPassBegin->renderPass); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10892 | if (!renderPass) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10893 | return; |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10894 | |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10895 | const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->createInfo.ptr(); |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10896 | auto framebuffer = getFramebufferState(dev_data, pRenderPassBegin->framebuffer); |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 10897 | if (!framebuffer) |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10898 | return; |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 10899 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10900 | for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { |
Chris Forbes | 853022c | 2016-06-30 16:56:15 +1200 | [diff] [blame] | 10901 | auto image_view = framebuffer->createInfo.pAttachments[i]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10902 | SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); |
| 10903 | } |
| 10904 | } |
| 10905 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10906 | static bool VerifyRenderAreaBounds(const layer_data *dev_data, const VkRenderPassBeginInfo *pRenderPassBegin) { |
Michael Lentine | d464881 | 2016-03-24 20:48:59 -0500 | [diff] [blame] | 10907 | bool skip_call = false; |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10908 | const safe_VkFramebufferCreateInfo *pFramebufferInfo = |
| 10909 | &getFramebufferState(dev_data, pRenderPassBegin->framebuffer)->createInfo; |
Michael Lentine | d464881 | 2016-03-24 20:48:59 -0500 | [diff] [blame] | 10910 | if (pRenderPassBegin->renderArea.offset.x < 0 || |
| 10911 | (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || |
| 10912 | pRenderPassBegin->renderArea.offset.y < 0 || |
| 10913 | (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { |
| 10914 | skip_call |= static_cast<bool>(log_msg( |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 10915 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Michael Lentine | d464881 | 2016-03-24 20:48:59 -0500 | [diff] [blame] | 10916 | DRAWSTATE_INVALID_RENDER_AREA, "CORE", |
| 10917 | "Cannot execute a render pass with renderArea not within the bound of the " |
| 10918 | "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " |
| 10919 | "height %d.", |
| 10920 | pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, |
| 10921 | pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); |
| 10922 | } |
| 10923 | return skip_call; |
| 10924 | } |
| 10925 | |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10926 | // If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the |
| 10927 | // [load|store]Op flag must be checked |
| 10928 | // TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. |
| 10929 | template <typename T> static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { |
Mark Lobodzinski | 323c6ba | 2016-06-21 10:28:30 -0600 | [diff] [blame] | 10930 | if (color_depth_op != op && stencil_op != op) { |
| 10931 | return false; |
| 10932 | } |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10933 | bool check_color_depth_load_op = !vk_format_is_stencil_only(format); |
| 10934 | bool check_stencil_load_op = vk_format_is_depth_and_stencil(format) || !check_color_depth_load_op; |
Mark Lobodzinski | 323c6ba | 2016-06-21 10:28:30 -0600 | [diff] [blame] | 10935 | |
| 10936 | return (((check_color_depth_load_op == true) && (color_depth_op == op)) || |
| 10937 | ((check_stencil_load_op == true) && (stencil_op == op))); |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10938 | } |
| 10939 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 10940 | VKAPI_ATTR void VKAPI_CALL |
| 10941 | CmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 10942 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10943 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 10944 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10945 | GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 10946 | auto renderPass = pRenderPassBegin ? getRenderPassState(dev_data, pRenderPassBegin->renderPass) : nullptr; |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 10947 | auto framebuffer = pRenderPassBegin ? getFramebufferState(dev_data, pRenderPassBegin->framebuffer) : nullptr; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10948 | if (cb_node) { |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10949 | if (renderPass) { |
Tobin Ehlis | 7f0416c | 2016-07-15 16:01:13 -0600 | [diff] [blame] | 10950 | uint32_t clear_op_size = 0; // Make sure pClearValues is at least as large as last LOAD_OP_CLEAR |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10951 | cb_node->activeFramebuffer = pRenderPassBegin->framebuffer; |
Mark Lobodzinski | 4dc768c | 2016-10-03 16:01:12 -0600 | [diff] [blame] | 10952 | for (uint32_t i = 0; i < renderPass->createInfo.attachmentCount; ++i) { |
Chris Forbes | 05e03b7 | 2016-05-17 15:27:58 +1200 | [diff] [blame] | 10953 | MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 10954 | auto pAttachment = &renderPass->createInfo.pAttachments[i]; |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10955 | if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, |
| 10956 | pAttachment->stencilLoadOp, |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10957 | VK_ATTACHMENT_LOAD_OP_CLEAR)) { |
Mark Lobodzinski | a8bbfde | 2016-07-20 10:02:23 -0600 | [diff] [blame] | 10958 | clear_op_size = static_cast<uint32_t>(i) + 1; |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10959 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10960 | SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), true); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10961 | return false; |
| 10962 | }; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10963 | cb_node->validate_functions.push_back(function); |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10964 | } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, |
| 10965 | pAttachment->stencilLoadOp, |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10966 | VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10967 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10968 | SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), false); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10969 | return false; |
| 10970 | }; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10971 | cb_node->validate_functions.push_back(function); |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10972 | } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, |
| 10973 | pAttachment->stencilLoadOp, |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 10974 | VK_ATTACHMENT_LOAD_OP_LOAD)) { |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10975 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10976 | return ValidateImageMemoryIsValid(dev_data, getImageState(dev_data, fb_info.image), |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 10977 | "vkCmdBeginRenderPass()"); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10978 | }; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10979 | cb_node->validate_functions.push_back(function); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10980 | } |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 10981 | if (renderPass->attachment_first_read[i]) { |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10982 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 10983 | return ValidateImageMemoryIsValid(dev_data, getImageState(dev_data, fb_info.image), |
Tobin Ehlis | 5d46115 | 2016-08-10 19:11:54 -0600 | [diff] [blame] | 10984 | "vkCmdBeginRenderPass()"); |
Chris Forbes | 967c468 | 2016-05-17 11:36:23 +1200 | [diff] [blame] | 10985 | }; |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 10986 | cb_node->validate_functions.push_back(function); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10987 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 10988 | } |
Tobin Ehlis | 7f0416c | 2016-07-15 16:01:13 -0600 | [diff] [blame] | 10989 | if (clear_op_size > pRenderPassBegin->clearValueCount) { |
Slawomir Cygan | 0808f39 | 2016-11-28 17:53:23 +0100 | [diff] [blame] | 10990 | skip_call |= log_msg( |
| 10991 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| 10992 | reinterpret_cast<uint64_t &>(renderPass), __LINE__, VALIDATION_ERROR_00442, |
| 10993 | "DS", "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but there must " |
| 10994 | "be at least %u entries in pClearValues array to account for the highest index attachment in renderPass " |
| 10995 | "0x%" PRIx64 " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u. Note that the pClearValues array " |
| 10996 | "is indexed by attachment number so even if some pClearValues entries between 0 and %u correspond to " |
| 10997 | "attachments that aren't cleared they will be ignored. %s", |
| 10998 | pRenderPassBegin->clearValueCount, clear_op_size, reinterpret_cast<uint64_t &>(renderPass), clear_op_size, |
| 10999 | clear_op_size - 1, validation_error_map[VALIDATION_ERROR_00442]); |
| 11000 | } |
| 11001 | if (clear_op_size < pRenderPassBegin->clearValueCount) { |
| 11002 | skip_call |= log_msg( |
| 11003 | dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| 11004 | reinterpret_cast<uint64_t &>(renderPass), __LINE__, DRAWSTATE_RENDERPASS_TOO_MANY_CLEAR_VALUES, "DS", |
| 11005 | "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but only first %u " |
| 11006 | "entries in pClearValues array are used. The highest index attachment in renderPass 0x%" PRIx64 |
| 11007 | " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u - other pClearValues are ignored.", |
| 11008 | pRenderPassBegin->clearValueCount, clear_op_size, reinterpret_cast<uint64_t &>(renderPass), clear_op_size); |
Tobin Ehlis | 74aa54a | 2016-05-31 13:06:24 -0600 | [diff] [blame] | 11009 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11010 | skip_call |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 11011 | skip_call |= VerifyFramebufferAndRenderPassLayouts(dev_data, cb_node, pRenderPassBegin); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 11012 | skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBeginRenderPass()", VALIDATION_ERROR_00440); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11013 | skip_call |= ValidateDependencies(dev_data, framebuffer, renderPass); |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11014 | skip_call |= validatePrimaryCommandBuffer(dev_data, cb_node, "vkCmdBeginRenderPass", VALIDATION_ERROR_00441); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 11015 | skip_call |= ValidateCmd(dev_data, cb_node, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); |
| 11016 | UpdateCmdBufferLastCmd(dev_data, cb_node, CMD_BEGINRENDERPASS); |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 11017 | cb_node->activeRenderPass = renderPass; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11018 | // This is a shallow copy as that is all that is needed for now |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 11019 | cb_node->activeRenderPassBeginInfo = *pRenderPassBegin; |
| 11020 | cb_node->activeSubpass = 0; |
| 11021 | cb_node->activeSubpassContents = contents; |
| 11022 | cb_node->framebuffers.insert(pRenderPassBegin->framebuffer); |
Tobin Ehlis | 9fc34aa | 2016-09-14 15:26:09 -0600 | [diff] [blame] | 11023 | // Connect this framebuffer and its children to this cmdBuffer |
| 11024 | AddFramebufferBinding(dev_data, cb_node, framebuffer); |
Chris Forbes | fb2aae3 | 2016-06-30 15:42:41 +1200 | [diff] [blame] | 11025 | // transition attachments to the correct layouts for the first subpass |
Tobin Ehlis | c7d4ff1 | 2016-09-06 20:40:29 -0600 | [diff] [blame] | 11026 | TransitionSubpassLayouts(dev_data, cb_node, &cb_node->activeRenderPassBeginInfo, cb_node->activeSubpass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11027 | } |
| 11028 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11029 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11030 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11031 | dev_data->dispatch_table.CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11032 | } |
| 11033 | } |
| 11034 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11035 | VKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11036 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11037 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11038 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11039 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11040 | if (pCB) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11041 | skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass", VALIDATION_ERROR_00459); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 11042 | skip_call |= ValidateCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); |
| 11043 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_NEXTSUBPASS); |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 11044 | skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass()", VALIDATION_ERROR_00458); |
Chris Forbes | 0948afa | 2016-09-07 11:44:08 +1200 | [diff] [blame] | 11045 | |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 11046 | auto subpassCount = pCB->activeRenderPass->createInfo.subpassCount; |
Chris Forbes | 0948afa | 2016-09-07 11:44:08 +1200 | [diff] [blame] | 11047 | if (pCB->activeSubpass == subpassCount - 1) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11048 | skip_call |= log_msg( |
| 11049 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 11050 | reinterpret_cast<uint64_t>(commandBuffer), __LINE__, VALIDATION_ERROR_00453, "DS", |
| 11051 | "vkCmdNextSubpass(): Attempted to advance beyond final subpass. %s", validation_error_map[VALIDATION_ERROR_00453]); |
Chris Forbes | 0948afa | 2016-09-07 11:44:08 +1200 | [diff] [blame] | 11052 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11053 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11054 | lock.unlock(); |
Chris Forbes | 2784bcb | 2016-09-07 11:43:52 +1200 | [diff] [blame] | 11055 | |
| 11056 | if (skip_call) |
| 11057 | return; |
| 11058 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11059 | dev_data->dispatch_table.CmdNextSubpass(commandBuffer, contents); |
Chris Forbes | 2784bcb | 2016-09-07 11:43:52 +1200 | [diff] [blame] | 11060 | |
| 11061 | if (pCB) { |
| 11062 | lock.lock(); |
| 11063 | pCB->activeSubpass++; |
| 11064 | pCB->activeSubpassContents = contents; |
| 11065 | TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); |
| 11066 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11067 | } |
| 11068 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11069 | VKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11070 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11071 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11072 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11073 | auto pCB = getCBNode(dev_data, commandBuffer); |
| 11074 | if (pCB) { |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11075 | RENDER_PASS_STATE *rp_state = pCB->activeRenderPass; |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 11076 | auto framebuffer = getFramebufferState(dev_data, pCB->activeFramebuffer); |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11077 | if (rp_state) { |
| 11078 | if (pCB->activeSubpass != rp_state->createInfo.subpassCount - 1) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11079 | skip_call |= log_msg( |
| 11080 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 11081 | reinterpret_cast<uint64_t>(commandBuffer), __LINE__, VALIDATION_ERROR_00460, "DS", |
| 11082 | "vkCmdEndRenderPass(): Called before reaching final subpass. %s", validation_error_map[VALIDATION_ERROR_00460]); |
Chris Forbes | 85bb400 | 2016-09-07 14:08:31 +1200 | [diff] [blame] | 11083 | } |
| 11084 | |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11085 | for (size_t i = 0; i < rp_state->createInfo.attachmentCount; ++i) { |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 11086 | MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11087 | auto pAttachment = &rp_state->createInfo.pAttachments[i]; |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 11088 | if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, |
| 11089 | pAttachment->stencilStoreOp, VK_ATTACHMENT_STORE_OP_STORE)) { |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11090 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 11091 | SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), true); |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11092 | return false; |
| 11093 | }; |
| 11094 | pCB->validate_functions.push_back(function); |
Chris Forbes | cc836ab | 2016-09-26 17:04:41 +1300 | [diff] [blame] | 11095 | } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, |
| 11096 | pAttachment->stencilStoreOp, |
Mark Lobodzinski | 7b58e69 | 2016-06-10 15:28:17 -0600 | [diff] [blame] | 11097 | VK_ATTACHMENT_STORE_OP_DONT_CARE)) { |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11098 | std::function<bool()> function = [=]() { |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 11099 | SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), false); |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11100 | return false; |
| 11101 | }; |
| 11102 | pCB->validate_functions.push_back(function); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11103 | } |
| 11104 | } |
| 11105 | } |
Mike Weiblen | 6daea5b | 2016-12-19 20:41:58 -0700 | [diff] [blame] | 11106 | skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass()", VALIDATION_ERROR_00464); |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11107 | skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass", VALIDATION_ERROR_00465); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 11108 | skip_call |= ValidateCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); |
| 11109 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_ENDRENDERPASS); |
Chris Forbes | 2886a9e | 2016-09-07 13:52:28 +1200 | [diff] [blame] | 11110 | } |
| 11111 | lock.unlock(); |
| 11112 | |
| 11113 | if (skip_call) |
| 11114 | return; |
| 11115 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11116 | dev_data->dispatch_table.CmdEndRenderPass(commandBuffer); |
Chris Forbes | 2886a9e | 2016-09-07 13:52:28 +1200 | [diff] [blame] | 11117 | |
| 11118 | if (pCB) { |
| 11119 | lock.lock(); |
Chris Forbes | 05e03b7 | 2016-05-17 15:27:58 +1200 | [diff] [blame] | 11120 | TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); |
Chris Forbes | c785a10 | 2016-05-17 14:59:22 +1200 | [diff] [blame] | 11121 | pCB->activeRenderPass = nullptr; |
| 11122 | pCB->activeSubpass = 0; |
| 11123 | pCB->activeFramebuffer = VK_NULL_HANDLE; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11124 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11125 | } |
| 11126 | |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11127 | static bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, uint32_t primaryAttach, |
| 11128 | uint32_t secondaryAttach, const char *msg) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11129 | return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11130 | VALIDATION_ERROR_02059, "DS", |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11131 | "vkCmdExecuteCommands() called w/ invalid Secondary Cmd Buffer 0x%" PRIx64 " which has a render pass " |
| 11132 | "that is not compatible with the Primary Cmd Buffer current render pass. " |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11133 | "Attachment %u is not compatible with %u: %s. %s", |
| 11134 | reinterpret_cast<uint64_t &>(secondaryBuffer), primaryAttach, secondaryAttach, msg, |
| 11135 | validation_error_map[VALIDATION_ERROR_02059]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11136 | } |
| 11137 | |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11138 | static bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, |
| 11139 | VkRenderPassCreateInfo const *primaryPassCI, uint32_t primaryAttach, |
| 11140 | VkCommandBuffer secondaryBuffer, VkRenderPassCreateInfo const *secondaryPassCI, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11141 | uint32_t secondaryAttach, bool is_multi) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11142 | bool skip_call = false; |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11143 | if (primaryPassCI->attachmentCount <= primaryAttach) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11144 | primaryAttach = VK_ATTACHMENT_UNUSED; |
| 11145 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11146 | if (secondaryPassCI->attachmentCount <= secondaryAttach) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11147 | secondaryAttach = VK_ATTACHMENT_UNUSED; |
| 11148 | } |
| 11149 | if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { |
| 11150 | return skip_call; |
| 11151 | } |
| 11152 | if (primaryAttach == VK_ATTACHMENT_UNUSED) { |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11153 | skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, |
| 11154 | "The first is unused while the second is not."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11155 | return skip_call; |
| 11156 | } |
| 11157 | if (secondaryAttach == VK_ATTACHMENT_UNUSED) { |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11158 | skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, |
| 11159 | "The second is unused while the first is not."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11160 | return skip_call; |
| 11161 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11162 | if (primaryPassCI->pAttachments[primaryAttach].format != secondaryPassCI->pAttachments[secondaryAttach].format) { |
| 11163 | skip_call |= |
| 11164 | logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different formats."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11165 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11166 | if (primaryPassCI->pAttachments[primaryAttach].samples != secondaryPassCI->pAttachments[secondaryAttach].samples) { |
| 11167 | skip_call |= |
| 11168 | logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different samples."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11169 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11170 | if (is_multi && primaryPassCI->pAttachments[primaryAttach].flags != secondaryPassCI->pAttachments[secondaryAttach].flags) { |
| 11171 | skip_call |= |
| 11172 | logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different flags."); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11173 | } |
| 11174 | return skip_call; |
| 11175 | } |
| 11176 | |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11177 | static bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, |
| 11178 | VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, |
| 11179 | VkRenderPassCreateInfo const *secondaryPassCI, const int subpass, bool is_multi) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11180 | bool skip_call = false; |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11181 | const VkSubpassDescription &primary_desc = primaryPassCI->pSubpasses[subpass]; |
| 11182 | const VkSubpassDescription &secondary_desc = secondaryPassCI->pSubpasses[subpass]; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11183 | uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); |
| 11184 | for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { |
| 11185 | uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; |
| 11186 | if (i < primary_desc.inputAttachmentCount) { |
| 11187 | primary_input_attach = primary_desc.pInputAttachments[i].attachment; |
| 11188 | } |
| 11189 | if (i < secondary_desc.inputAttachmentCount) { |
| 11190 | secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; |
| 11191 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11192 | skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_input_attach, secondaryBuffer, |
| 11193 | secondaryPassCI, secondary_input_attach, is_multi); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11194 | } |
| 11195 | uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); |
| 11196 | for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { |
| 11197 | uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; |
| 11198 | if (i < primary_desc.colorAttachmentCount) { |
| 11199 | primary_color_attach = primary_desc.pColorAttachments[i].attachment; |
| 11200 | } |
| 11201 | if (i < secondary_desc.colorAttachmentCount) { |
| 11202 | secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; |
| 11203 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11204 | skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_color_attach, secondaryBuffer, |
| 11205 | secondaryPassCI, secondary_color_attach, is_multi); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11206 | uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; |
| 11207 | if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { |
| 11208 | primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; |
| 11209 | } |
| 11210 | if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { |
| 11211 | secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; |
| 11212 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11213 | skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_resolve_attach, |
| 11214 | secondaryBuffer, secondaryPassCI, secondary_resolve_attach, is_multi); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11215 | } |
| 11216 | uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; |
| 11217 | if (primary_desc.pDepthStencilAttachment) { |
| 11218 | primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; |
| 11219 | } |
| 11220 | if (secondary_desc.pDepthStencilAttachment) { |
| 11221 | secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; |
| 11222 | } |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11223 | skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_depthstencil_attach, |
| 11224 | secondaryBuffer, secondaryPassCI, secondary_depthstencil_attach, is_multi); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11225 | return skip_call; |
| 11226 | } |
| 11227 | |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11228 | // Verify that given renderPass CreateInfo for primary and secondary command buffers are compatible. |
| 11229 | // This function deals directly with the CreateInfo, there are overloaded versions below that can take the renderPass handle and |
| 11230 | // will then feed into this function |
| 11231 | static bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, |
| 11232 | VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, |
| 11233 | VkRenderPassCreateInfo const *secondaryPassCI) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11234 | bool skip_call = false; |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11235 | |
| 11236 | if (primaryPassCI->subpassCount != secondaryPassCI->subpassCount) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11237 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 11238 | DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11239 | "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 |
| 11240 | " that has a subpassCount of %u that is incompatible with the primary Cmd Buffer 0x%" PRIx64 |
| 11241 | " that has a subpassCount of %u.", |
| 11242 | reinterpret_cast<uint64_t &>(secondaryBuffer), secondaryPassCI->subpassCount, |
| 11243 | reinterpret_cast<uint64_t &>(primaryBuffer), primaryPassCI->subpassCount); |
| 11244 | } else { |
| 11245 | for (uint32_t i = 0; i < primaryPassCI->subpassCount; ++i) { |
| 11246 | skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primaryPassCI, secondaryBuffer, secondaryPassCI, i, |
| 11247 | primaryPassCI->subpassCount > 1); |
| 11248 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11249 | } |
| 11250 | return skip_call; |
| 11251 | } |
| 11252 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11253 | static bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, |
| 11254 | VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11255 | bool skip_call = false; |
| 11256 | if (!pSubCB->beginInfo.pInheritanceInfo) { |
| 11257 | return skip_call; |
| 11258 | } |
Chris Forbes | 89ca84a | 2016-05-13 16:23:58 +1200 | [diff] [blame] | 11259 | VkFramebuffer primary_fb = pCB->activeFramebuffer; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11260 | VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; |
| 11261 | if (secondary_fb != VK_NULL_HANDLE) { |
| 11262 | if (primary_fb != secondary_fb) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11263 | skip_call |= log_msg( |
| 11264 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 11265 | VALIDATION_ERROR_02060, "DS", |
| 11266 | "vkCmdExecuteCommands() called w/ invalid secondary command buffer 0x%" PRIx64 " which has a framebuffer 0x%" PRIx64 |
| 11267 | " that is not the same as the primary command buffer's current active framebuffer 0x%" PRIx64 ". %s", |
| 11268 | reinterpret_cast<uint64_t &>(secondaryBuffer), reinterpret_cast<uint64_t &>(secondary_fb), |
| 11269 | reinterpret_cast<uint64_t &>(primary_fb), validation_error_map[VALIDATION_ERROR_02060]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11270 | } |
Tobin Ehlis | 04c0427 | 2016-10-12 11:54:09 -0600 | [diff] [blame] | 11271 | auto fb = getFramebufferState(dev_data, secondary_fb); |
Chris Forbes | b065df0 | 2016-05-17 15:45:31 +1200 | [diff] [blame] | 11272 | if (!fb) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11273 | skip_call |= |
| 11274 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11275 | DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " |
| 11276 | "which has invalid framebuffer 0x%" PRIx64 ".", |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11277 | (void *)secondaryBuffer, (uint64_t)(secondary_fb)); |
| 11278 | return skip_call; |
| 11279 | } |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11280 | auto cb_renderpass = getRenderPassState(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11281 | if (cb_renderpass->renderPass != fb->createInfo.renderPass) { |
| 11282 | skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->renderPassCreateInfo.ptr(), secondaryBuffer, |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 11283 | cb_renderpass->createInfo.ptr()); |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11284 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11285 | } |
| 11286 | return skip_call; |
| 11287 | } |
| 11288 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11289 | static bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11290 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11291 | unordered_set<int> activeTypes; |
| 11292 | for (auto queryObject : pCB->activeQueries) { |
| 11293 | auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); |
| 11294 | if (queryPoolData != dev_data->queryPoolMap.end()) { |
| 11295 | if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && |
| 11296 | pSubCB->beginInfo.pInheritanceInfo) { |
| 11297 | VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; |
| 11298 | if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11299 | skip_call |= |
| 11300 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 11301 | VALIDATION_ERROR_02065, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " |
| 11302 | "which has invalid active query pool 0x%" PRIx64 |
| 11303 | ". Pipeline statistics is being queried so the command " |
| 11304 | "buffer must have all bits set on the queryPool. %s", |
| 11305 | pCB->commandBuffer, reinterpret_cast<const uint64_t &>(queryPoolData->first), |
| 11306 | validation_error_map[VALIDATION_ERROR_02065]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11307 | } |
| 11308 | } |
| 11309 | activeTypes.insert(queryPoolData->second.createInfo.queryType); |
| 11310 | } |
| 11311 | } |
| 11312 | for (auto queryObject : pSubCB->startedQueries) { |
| 11313 | auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); |
| 11314 | if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11315 | skip_call |= |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11316 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, |
| 11317 | DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11318 | "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " |
| 11319 | "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " |
| 11320 | "secondary Cmd Buffer 0x%p.", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11321 | pCB->commandBuffer, reinterpret_cast<const uint64_t &>(queryPoolData->first), |
| 11322 | queryPoolData->second.createInfo.queryType, pSubCB->commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11323 | } |
| 11324 | } |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 11325 | |
| 11326 | auto primary_pool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); |
| 11327 | auto secondary_pool = getCommandPoolNode(dev_data, pSubCB->createInfo.commandPool); |
| 11328 | if (primary_pool && secondary_pool && (primary_pool->queueFamilyIndex != secondary_pool->queueFamilyIndex)) { |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11329 | skip_call |= |
| 11330 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 11331 | reinterpret_cast<uint64_t>(pSubCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", |
| 11332 | "vkCmdExecuteCommands(): Primary command buffer 0x%p" |
| 11333 | " created in queue family %d has secondary command buffer 0x%p created in queue family %d.", |
| 11334 | pCB->commandBuffer, primary_pool->queueFamilyIndex, pSubCB->commandBuffer, secondary_pool->queueFamilyIndex); |
Mark Lobodzinski | eb30fd7 | 2016-08-09 16:42:24 -0600 | [diff] [blame] | 11335 | } |
| 11336 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11337 | return skip_call; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11338 | } |
| 11339 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11340 | VKAPI_ATTR void VKAPI_CALL |
| 11341 | CmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11342 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11343 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11344 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11345 | GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); |
| 11346 | if (pCB) { |
| 11347 | GLOBAL_CB_NODE *pSubCB = NULL; |
| 11348 | for (uint32_t i = 0; i < commandBuffersCount; i++) { |
| 11349 | pSubCB = getCBNode(dev_data, pCommandBuffers[i]); |
Tobin Ehlis | 44ba5fc | 2017-01-03 14:07:17 -0700 | [diff] [blame] | 11350 | assert(pSubCB); |
| 11351 | if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11352 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11353 | __LINE__, VALIDATION_ERROR_00153, "DS", |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11354 | "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11355 | "array. All cmd buffers in pCommandBuffers array must be secondary. %s", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11356 | pCommandBuffers[i], i, validation_error_map[VALIDATION_ERROR_00153]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11357 | } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11358 | auto secondary_rp_state = getRenderPassState(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11359 | if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11360 | skip_call |= log_msg( |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11361 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11362 | (uint64_t)pCommandBuffers[i], __LINE__, VALIDATION_ERROR_02057, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11363 | "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11364 | ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set. %s", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11365 | pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass, |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11366 | validation_error_map[VALIDATION_ERROR_02057]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11367 | } else { |
| 11368 | // Make sure render pass is compatible with parent command buffer pass if has continue |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11369 | if (pCB->activeRenderPass->renderPass != secondary_rp_state->renderPass) { |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 11370 | skip_call |= |
| 11371 | validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->createInfo.ptr(), |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11372 | pCommandBuffers[i], secondary_rp_state->createInfo.ptr()); |
Tobin Ehlis | 4ca15c7 | 2016-06-30 09:29:18 -0600 | [diff] [blame] | 11373 | } |
Tobin Ehlis | f77f5cc | 2016-07-19 10:45:24 -0600 | [diff] [blame] | 11374 | // If framebuffer for secondary CB is not NULL, then it must match active FB from primaryCB |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11375 | skip_call |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11376 | } |
| 11377 | string errorString = ""; |
Tobin Ehlis | f77f5cc | 2016-07-19 10:45:24 -0600 | [diff] [blame] | 11378 | // secondaryCB must have been created w/ RP compatible w/ primaryCB active renderpass |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11379 | if ((pCB->activeRenderPass->renderPass != secondary_rp_state->renderPass) && |
Chris Forbes | ef73046 | 2016-09-27 12:03:31 +1300 | [diff] [blame] | 11380 | !verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->createInfo.ptr(), |
Tobin Ehlis | 95ccf3e | 2016-10-12 15:24:03 -0600 | [diff] [blame] | 11381 | secondary_rp_state->createInfo.ptr(), errorString)) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11382 | skip_call |= log_msg( |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11383 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 11384 | (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11385 | "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 |
| 11386 | ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11387 | pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, commandBuffer, |
Chris Forbes | a4937a7 | 2016-05-06 16:31:14 +1200 | [diff] [blame] | 11388 | (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11389 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11390 | } |
| 11391 | // TODO(mlentine): Move more logic into this method |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11392 | skip_call |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); |
Tobin Ehlis | f7cf915 | 2016-09-27 13:10:33 -0600 | [diff] [blame] | 11393 | skip_call |= validateCommandBufferState(dev_data, pSubCB, "vkCmdExecuteCommands()"); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11394 | // Secondary cmdBuffers are considered pending execution starting w/ |
| 11395 | // being recorded |
| 11396 | if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { |
| 11397 | if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11398 | skip_call |= |
| 11399 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 11400 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)(pCB->commandBuffer), __LINE__, |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11401 | VALIDATION_ERROR_00154, "DS", "Attempt to simultaneously execute command buffer 0x%p" |
Mike Weiblen | 25c9082 | 2016-12-06 17:10:22 -0700 | [diff] [blame] | 11402 | " without VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set! %s", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11403 | pCB->commandBuffer, validation_error_map[VALIDATION_ERROR_00154]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11404 | } |
| 11405 | if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { |
| 11406 | // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11407 | skip_call |= log_msg( |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11408 | dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 11409 | (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11410 | "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) " |
| 11411 | "does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " |
| 11412 | "(0x%p) to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11413 | "set, even though it does.", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11414 | pCommandBuffers[i], pCB->commandBuffer); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11415 | pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; |
| 11416 | } |
| 11417 | } |
Chris Forbes | 94c5f53 | 2016-10-03 17:42:38 +1300 | [diff] [blame] | 11418 | if (!pCB->activeQueries.empty() && !dev_data->enabled_features.inheritedQueries) { |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11419 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 11420 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(pCommandBuffers[i]), |
| 11421 | __LINE__, VALIDATION_ERROR_02062, "DS", "vkCmdExecuteCommands(): Secondary Command Buffer " |
| 11422 | "(0x%p) cannot be submitted with a query in " |
| 11423 | "flight and inherited queries not " |
| 11424 | "supported on this device. %s", |
| 11425 | pCommandBuffers[i], validation_error_map[VALIDATION_ERROR_02062]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11426 | } |
Tobin Ehlis | d6280b1 | 2016-11-03 10:46:44 -0600 | [diff] [blame] | 11427 | // Propagate layout transitions to the primary cmd buffer |
| 11428 | for (auto ilm_entry : pSubCB->imageLayoutMap) { |
| 11429 | SetLayout(pCB, ilm_entry.first, ilm_entry.second); |
| 11430 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11431 | pSubCB->primaryCommandBuffer = pCB->commandBuffer; |
| 11432 | pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); |
| 11433 | dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); |
Michael Lentine | f01fb38 | 2016-07-21 17:24:56 -0500 | [diff] [blame] | 11434 | for (auto &function : pSubCB->queryUpdates) { |
| 11435 | pCB->queryUpdates.push_back(function); |
| 11436 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11437 | } |
Mike Schuchardt | 8fb3806 | 2016-12-08 15:36:24 -0700 | [diff] [blame] | 11438 | skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands", VALIDATION_ERROR_00163); |
Tobin Ehlis | 1c883a0 | 2016-12-19 15:59:16 -0700 | [diff] [blame] | 11439 | skip_call |= ValidateCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); |
| 11440 | UpdateCmdBufferLastCmd(dev_data, pCB, CMD_EXECUTECOMMANDS); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11441 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11442 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11443 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11444 | dev_data->dispatch_table.CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11445 | } |
| 11446 | |
Tobin Ehlis | 9e40f0d | 2016-08-04 10:17:19 -0600 | [diff] [blame] | 11447 | // For any image objects that overlap mapped memory, verify that their layouts are PREINIT or GENERAL |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11448 | static bool ValidateMapImageLayouts(VkDevice device, DEVICE_MEM_INFO const *mem_info, VkDeviceSize offset, |
Tobin Ehlis | 0a78ef9 | 2016-08-12 14:12:44 -0600 | [diff] [blame] | 11449 | VkDeviceSize end_offset) { |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11450 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11451 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11452 | // Iterate over all bound image ranges and verify that for any that overlap the |
| 11453 | // map ranges, the layouts are VK_IMAGE_LAYOUT_PREINITIALIZED or VK_IMAGE_LAYOUT_GENERAL |
| 11454 | // TODO : This can be optimized if we store ranges based on starting address and early exit when we pass our range |
| 11455 | for (auto image_handle : mem_info->bound_images) { |
| 11456 | auto img_it = mem_info->bound_ranges.find(image_handle); |
| 11457 | if (img_it != mem_info->bound_ranges.end()) { |
Tobin Ehlis | 0a78ef9 | 2016-08-12 14:12:44 -0600 | [diff] [blame] | 11458 | if (rangesIntersect(dev_data, &img_it->second, offset, end_offset)) { |
Tobin Ehlis | 9e40f0d | 2016-08-04 10:17:19 -0600 | [diff] [blame] | 11459 | std::vector<VkImageLayout> layouts; |
Tobin Ehlis | 12a4b5e | 2016-08-08 12:33:11 -0600 | [diff] [blame] | 11460 | if (FindLayouts(dev_data, VkImage(image_handle), layouts)) { |
Tobin Ehlis | 9e40f0d | 2016-08-04 10:17:19 -0600 | [diff] [blame] | 11461 | for (auto layout : layouts) { |
| 11462 | if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { |
| 11463 | skip_call |= |
| 11464 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, |
| 11465 | __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " |
| 11466 | "GENERAL or PREINITIALIZED are supported.", |
| 11467 | string_VkImageLayout(layout)); |
| 11468 | } |
| 11469 | } |
| 11470 | } |
| 11471 | } |
| 11472 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11473 | } |
| 11474 | return skip_call; |
| 11475 | } |
| 11476 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11477 | VKAPI_ATTR VkResult VKAPI_CALL |
| 11478 | MapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11479 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 11480 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11481 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11482 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11483 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11484 | DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); |
| 11485 | if (mem_info) { |
Tobin Ehlis | c3e9c7b | 2016-08-10 17:00:51 -0600 | [diff] [blame] | 11486 | // TODO : This could me more fine-grained to track just region that is valid |
| 11487 | mem_info->global_valid = true; |
Tobin Ehlis | 0a78ef9 | 2016-08-12 14:12:44 -0600 | [diff] [blame] | 11488 | auto end_offset = (VK_WHOLE_SIZE == size) ? mem_info->alloc_info.allocationSize - 1 : offset + size - 1; |
| 11489 | skip_call |= ValidateMapImageLayouts(device, mem_info, offset, end_offset); |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11490 | // TODO : Do we need to create new "bound_range" for the mapped range? |
Tobin Ehlis | 0a78ef9 | 2016-08-12 14:12:44 -0600 | [diff] [blame] | 11491 | SetMemRangesValid(dev_data, mem_info, offset, end_offset); |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11492 | if ((dev_data->phys_dev_mem_props.memoryTypes[mem_info->alloc_info.memoryTypeIndex].propertyFlags & |
Tobin Ehlis | e54be7b | 2016-04-11 14:49:55 -0600 | [diff] [blame] | 11493 | VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11494 | skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 11495 | (uint64_t)mem, __LINE__, VALIDATION_ERROR_00629, "MEM", |
| 11496 | "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64 ". %s", |
| 11497 | (uint64_t)mem, validation_error_map[VALIDATION_ERROR_00629]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11498 | } |
| 11499 | } |
Tobin Ehlis | b495d5f | 2016-08-04 09:33:02 -0600 | [diff] [blame] | 11500 | skip_call |= ValidateMapMemRange(dev_data, mem, offset, size); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11501 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11502 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11503 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11504 | result = dev_data->dispatch_table.MapMemory(device, mem, offset, size, flags, ppData); |
Tobin Ehlis | d094c27 | 2016-05-12 08:31:32 -0600 | [diff] [blame] | 11505 | if (VK_SUCCESS == result) { |
Tobin Ehlis | d094c27 | 2016-05-12 08:31:32 -0600 | [diff] [blame] | 11506 | lock.lock(); |
Tobin Ehlis | 3d2c316 | 2016-08-10 16:08:00 -0600 | [diff] [blame] | 11507 | // TODO : What's the point of this range? See comment on creating new "bound_range" above, which may replace this |
Tobin Ehlis | d094c27 | 2016-05-12 08:31:32 -0600 | [diff] [blame] | 11508 | storeMemRanges(dev_data, mem, offset, size); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11509 | initializeAndTrackMemory(dev_data, mem, offset, size, ppData); |
Tobin Ehlis | d094c27 | 2016-05-12 08:31:32 -0600 | [diff] [blame] | 11510 | lock.unlock(); |
Tobin Ehlis | d094c27 | 2016-05-12 08:31:32 -0600 | [diff] [blame] | 11511 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11512 | } |
| 11513 | return result; |
| 11514 | } |
| 11515 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11516 | VKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11517 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11518 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11519 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11520 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11521 | skip_call |= deleteMemRanges(dev_data, mem); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11522 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11523 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11524 | dev_data->dispatch_table.UnmapMemory(device, mem); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11525 | } |
| 11526 | } |
| 11527 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11528 | static bool validateMemoryIsMapped(layer_data *dev_data, const char *funcName, uint32_t memRangeCount, |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11529 | const VkMappedMemoryRange *pMemRanges) { |
Mark Lobodzinski | 4a95cfe | 2016-11-15 13:55:22 -0700 | [diff] [blame] | 11530 | bool skip = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11531 | for (uint32_t i = 0; i < memRangeCount; ++i) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11532 | auto mem_info = getMemObjInfo(dev_data, pMemRanges[i].memory); |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 11533 | if (mem_info) { |
Mark Lobodzinski | b3c675e | 2016-11-15 08:56:03 -0700 | [diff] [blame] | 11534 | if (pMemRanges[i].size == VK_WHOLE_SIZE) { |
| 11535 | if (mem_info->mem_range.offset > pMemRanges[i].offset) { |
Mark Lobodzinski | 4a95cfe | 2016-11-15 13:55:22 -0700 | [diff] [blame] | 11536 | skip |= |
Mark Lobodzinski | b3c675e | 2016-11-15 08:56:03 -0700 | [diff] [blame] | 11537 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 11538 | (uint64_t)pMemRanges[i].memory, __LINE__, VALIDATION_ERROR_00643, "MEM", |
| 11539 | "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " |
| 11540 | "(" PRINTF_SIZE_T_SPECIFIER "). %s", |
| 11541 | funcName, static_cast<size_t>(pMemRanges[i].offset), |
| 11542 | static_cast<size_t>(mem_info->mem_range.offset), validation_error_map[VALIDATION_ERROR_00643]); |
| 11543 | } |
| 11544 | } else { |
| 11545 | const uint64_t data_end = (mem_info->mem_range.size == VK_WHOLE_SIZE) |
| 11546 | ? mem_info->alloc_info.allocationSize |
| 11547 | : (mem_info->mem_range.offset + mem_info->mem_range.size); |
| 11548 | if ((mem_info->mem_range.offset > pMemRanges[i].offset) || |
| 11549 | (data_end < (pMemRanges[i].offset + pMemRanges[i].size))) { |
Mark Lobodzinski | 4a95cfe | 2016-11-15 13:55:22 -0700 | [diff] [blame] | 11550 | skip |= |
Mark Lobodzinski | b3c675e | 2016-11-15 08:56:03 -0700 | [diff] [blame] | 11551 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 11552 | (uint64_t)pMemRanges[i].memory, __LINE__, VALIDATION_ERROR_00642, "MEM", |
| 11553 | "%s: Flush/Invalidate size or offset (" PRINTF_SIZE_T_SPECIFIER ", " PRINTF_SIZE_T_SPECIFIER |
| 11554 | ") exceed the Memory Object's upper-bound " |
| 11555 | "(" PRINTF_SIZE_T_SPECIFIER "). %s", |
| 11556 | funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), |
| 11557 | static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(data_end), |
| 11558 | validation_error_map[VALIDATION_ERROR_00642]); |
| 11559 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11560 | } |
| 11561 | } |
| 11562 | } |
Mark Lobodzinski | 4a95cfe | 2016-11-15 13:55:22 -0700 | [diff] [blame] | 11563 | return skip; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11564 | } |
| 11565 | |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11566 | static bool ValidateAndCopyNoncoherentMemoryToDriver(layer_data *dev_data, uint32_t mem_range_count, |
| 11567 | const VkMappedMemoryRange *mem_ranges) { |
| 11568 | bool skip = false; |
| 11569 | for (uint32_t i = 0; i < mem_range_count; ++i) { |
| 11570 | auto mem_info = getMemObjInfo(dev_data, mem_ranges[i].memory); |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 11571 | if (mem_info) { |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11572 | if (mem_info->shadow_copy) { |
| 11573 | VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) |
| 11574 | ? mem_info->mem_range.size |
Tobin Ehlis | 968f5dd | 2016-10-05 07:50:25 -0600 | [diff] [blame] | 11575 | : (mem_info->alloc_info.allocationSize - mem_info->mem_range.offset); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11576 | char *data = static_cast<char *>(mem_info->shadow_copy); |
| 11577 | for (uint64_t j = 0; j < mem_info->shadow_pad_size; ++j) { |
| 11578 | if (data[j] != NoncoherentMemoryFillValue) { |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11579 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 11580 | VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem_ranges[i].memory, __LINE__, |
| 11581 | MEMTRACK_INVALID_MAP, "MEM", "Memory underflow was detected on mem obj 0x%" PRIxLEAST64, |
| 11582 | (uint64_t)mem_ranges[i].memory); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11583 | } |
| 11584 | } |
| 11585 | for (uint64_t j = (size + mem_info->shadow_pad_size); j < (2 * mem_info->shadow_pad_size + size); ++j) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11586 | if (data[j] != NoncoherentMemoryFillValue) { |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11587 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 11588 | VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem_ranges[i].memory, __LINE__, |
| 11589 | MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, |
| 11590 | (uint64_t)mem_ranges[i].memory); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11591 | } |
| 11592 | } |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11593 | memcpy(mem_info->p_driver_data, static_cast<void *>(data + mem_info->shadow_pad_size), (size_t)(size)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11594 | } |
| 11595 | } |
| 11596 | } |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11597 | return skip; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11598 | } |
| 11599 | |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11600 | static void CopyNoncoherentMemoryFromDriver(layer_data *dev_data, uint32_t mem_range_count, const VkMappedMemoryRange *mem_ranges) { |
| 11601 | for (uint32_t i = 0; i < mem_range_count; ++i) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11602 | auto mem_info = getMemObjInfo(dev_data, mem_ranges[i].memory); |
Mark Lobodzinski | 066b842 | 2016-08-15 14:27:26 -0600 | [diff] [blame] | 11603 | if (mem_info && mem_info->shadow_copy) { |
| 11604 | VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) |
| 11605 | ? mem_info->mem_range.size |
| 11606 | : (mem_info->alloc_info.allocationSize - mem_ranges[i].offset); |
| 11607 | char *data = static_cast<char *>(mem_info->shadow_copy); |
| 11608 | memcpy(data + mem_info->shadow_pad_size, mem_info->p_driver_data, (size_t)(size)); |
Mark Lobodzinski | bc4d620 | 2016-08-16 09:06:15 -0600 | [diff] [blame] | 11609 | } |
| 11610 | } |
| 11611 | } |
| 11612 | |
Mark Lobodzinski | dcefe7f | 2016-11-14 16:28:01 -0700 | [diff] [blame] | 11613 | static bool ValidateMappedMemoryRangeDeviceLimits(layer_data *dev_data, const char *func_name, uint32_t mem_range_count, |
| 11614 | const VkMappedMemoryRange *mem_ranges) { |
| 11615 | bool skip = false; |
| 11616 | for (uint32_t i = 0; i < mem_range_count; ++i) { |
| 11617 | uint64_t atom_size = dev_data->phys_dev_properties.properties.limits.nonCoherentAtomSize; |
| 11618 | if (vk_safe_modulo(mem_ranges[i].offset, atom_size) != 0) { |
| 11619 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 11620 | __LINE__, VALIDATION_ERROR_00644, "MEM", |
| 11621 | "%s: Offset in pMemRanges[%d] is 0x%" PRIxLEAST64 |
| 11622 | ", which is not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (0x%" PRIxLEAST64 "). %s", |
| 11623 | func_name, i, mem_ranges[i].offset, atom_size, validation_error_map[VALIDATION_ERROR_00644]); |
| 11624 | } |
| 11625 | if ((mem_ranges[i].size != VK_WHOLE_SIZE) && (vk_safe_modulo(mem_ranges[i].size, atom_size) != 0)) { |
| 11626 | skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 11627 | __LINE__, VALIDATION_ERROR_00645, "MEM", |
| 11628 | "%s: Size in pMemRanges[%d] is 0x%" PRIxLEAST64 |
| 11629 | ", which is not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (0x%" PRIxLEAST64 "). %s", |
| 11630 | func_name, i, mem_ranges[i].size, atom_size, validation_error_map[VALIDATION_ERROR_00645]); |
| 11631 | } |
| 11632 | } |
| 11633 | return skip; |
| 11634 | } |
| 11635 | |
Mark Lobodzinski | 16ae440 | 2016-11-15 07:59:58 -0700 | [diff] [blame] | 11636 | static bool PreCallValidateFlushMappedMemoryRanges(layer_data *dev_data, uint32_t mem_range_count, |
| 11637 | const VkMappedMemoryRange *mem_ranges) { |
| 11638 | bool skip = false; |
| 11639 | std::lock_guard<std::mutex> lock(global_lock); |
| 11640 | skip |= ValidateAndCopyNoncoherentMemoryToDriver(dev_data, mem_range_count, mem_ranges); |
| 11641 | skip |= validateMemoryIsMapped(dev_data, "vkFlushMappedMemoryRanges", mem_range_count, mem_ranges); |
| 11642 | return skip; |
| 11643 | } |
| 11644 | |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11645 | VKAPI_ATTR VkResult VKAPI_CALL FlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, |
| 11646 | const VkMappedMemoryRange *pMemRanges) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11647 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11648 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11649 | |
Mark Lobodzinski | 16ae440 | 2016-11-15 07:59:58 -0700 | [diff] [blame] | 11650 | if (!PreCallValidateFlushMappedMemoryRanges(dev_data, memRangeCount, pMemRanges)) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11651 | result = dev_data->dispatch_table.FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11652 | } |
| 11653 | return result; |
| 11654 | } |
| 11655 | |
Mark Lobodzinski | 16ae440 | 2016-11-15 07:59:58 -0700 | [diff] [blame] | 11656 | static bool PreCallValidateInvalidateMappedMemoryRanges(layer_data *dev_data, uint32_t mem_range_count, |
| 11657 | const VkMappedMemoryRange *mem_ranges) { |
| 11658 | bool skip = false; |
| 11659 | std::lock_guard<std::mutex> lock(global_lock); |
| 11660 | skip |= validateMemoryIsMapped(dev_data, "vkInvalidateMappedMemoryRanges", mem_range_count, mem_ranges); |
| 11661 | return skip; |
| 11662 | } |
| 11663 | |
| 11664 | static void PostCallRecordInvalidateMappedMemoryRanges(layer_data *dev_data, uint32_t mem_range_count, |
| 11665 | const VkMappedMemoryRange *mem_ranges) { |
| 11666 | std::lock_guard<std::mutex> lock(global_lock); |
| 11667 | // Update our shadow copy with modified driver data |
| 11668 | CopyNoncoherentMemoryFromDriver(dev_data, mem_range_count, mem_ranges); |
| 11669 | } |
| 11670 | |
Mark Lobodzinski | 945c687 | 2016-11-15 07:48:49 -0700 | [diff] [blame] | 11671 | VKAPI_ATTR VkResult VKAPI_CALL InvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, |
| 11672 | const VkMappedMemoryRange *pMemRanges) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11673 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 11674 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11675 | |
Mark Lobodzinski | 16ae440 | 2016-11-15 07:59:58 -0700 | [diff] [blame] | 11676 | if (!PreCallValidateInvalidateMappedMemoryRanges(dev_data, memRangeCount, pMemRanges)) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11677 | result = dev_data->dispatch_table.InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); |
Mark Lobodzinski | 16ae440 | 2016-11-15 07:59:58 -0700 | [diff] [blame] | 11678 | if (result == VK_SUCCESS) { |
| 11679 | PostCallRecordInvalidateMappedMemoryRanges(dev_data, memRangeCount, pMemRanges); |
| 11680 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11681 | } |
| 11682 | return result; |
| 11683 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11684 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11685 | VKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11686 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 11687 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11688 | bool skip_call = false; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11689 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 11690 | auto image_state = getImageState(dev_data, image); |
| 11691 | if (image_state) { |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 11692 | // Track objects tied to memory |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 11693 | uint64_t image_handle = reinterpret_cast<uint64_t &>(image); |
Tobin Ehlis | 4ff5817 | 2016-09-22 10:52:00 -0600 | [diff] [blame] | 11694 | skip_call = SetMemBinding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); |
Tobin Ehlis | 9cb8440 | 2016-11-17 13:51:54 -0700 | [diff] [blame] | 11695 | if (!image_state->memory_requirements_checked) { |
| 11696 | // There's not an explicit requirement in the spec to call vkGetImageMemoryRequirements() prior to calling |
| 11697 | // BindImageMemory but it's implied in that memory being bound must conform with VkMemoryRequirements from |
| 11698 | // vkGetImageMemoryRequirements() |
| 11699 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 11700 | image_handle, __LINE__, DRAWSTATE_INVALID_IMAGE, "DS", |
Mark Lobodzinski | fa57226 | 2016-11-22 15:29:38 -0700 | [diff] [blame] | 11701 | "vkBindImageMemory(): Binding memory to image 0x%" PRIxLEAST64 |
Tobin Ehlis | 9cb8440 | 2016-11-17 13:51:54 -0700 | [diff] [blame] | 11702 | " but vkGetImageMemoryRequirements() has not been called on that image.", |
| 11703 | image_handle); |
| 11704 | // Make the call for them so we can verify the state |
| 11705 | lock.unlock(); |
| 11706 | dev_data->dispatch_table.GetImageMemoryRequirements(device, image, &image_state->requirements); |
| 11707 | lock.lock(); |
| 11708 | } |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 11709 | |
| 11710 | // Track and validate bound memory range information |
Tobin Ehlis | 997b258 | 2016-06-02 08:43:37 -0600 | [diff] [blame] | 11711 | auto mem_info = getMemObjInfo(dev_data, mem); |
| 11712 | if (mem_info) { |
Tobin Ehlis | 9cb8440 | 2016-11-17 13:51:54 -0700 | [diff] [blame] | 11713 | skip_call |= InsertImageMemoryRange(dev_data, image, mem_info, memoryOffset, image_state->requirements, |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 11714 | image_state->createInfo.tiling == VK_IMAGE_TILING_LINEAR); |
Mike Weiblen | dcca859 | 2016-12-15 12:24:24 -0700 | [diff] [blame] | 11715 | skip_call |= ValidateMemoryTypes(dev_data, mem_info, image_state->requirements.memoryTypeBits, "vkBindImageMemory()", |
| 11716 | VALIDATION_ERROR_00806); |
Mark Lobodzinski | f2904db | 2016-05-03 15:31:26 -0600 | [diff] [blame] | 11717 | } |
| 11718 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11719 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 11720 | if (!skip_call) { |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11721 | result = dev_data->dispatch_table.BindImageMemory(device, image, mem, memoryOffset); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11722 | lock.lock(); |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 11723 | image_state->binding.mem = mem; |
| 11724 | image_state->binding.offset = memoryOffset; |
Tobin Ehlis | 9cb8440 | 2016-11-17 13:51:54 -0700 | [diff] [blame] | 11725 | image_state->binding.size = image_state->requirements.size; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11726 | lock.unlock(); |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 11727 | } |
| 11728 | } else { |
| 11729 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
| 11730 | reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11731 | "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 11732 | reinterpret_cast<const uint64_t &>(image)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11733 | } |
| 11734 | return result; |
| 11735 | } |
| 11736 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11737 | VKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { |
Tobin Ehlis | 3f9e8f9 | 2016-04-13 16:18:28 -0600 | [diff] [blame] | 11738 | bool skip_call = false; |
| 11739 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11740 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11741 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 1af1713 | 2016-10-20 14:17:21 -0600 | [diff] [blame] | 11742 | auto event_state = getEventNode(dev_data, event); |
| 11743 | if (event_state) { |
| 11744 | event_state->needsSignaled = false; |
| 11745 | event_state->stageMask = VK_PIPELINE_STAGE_HOST_BIT; |
| 11746 | if (event_state->write_in_use) { |
Tobin Ehlis | 3f9e8f9 | 2016-04-13 16:18:28 -0600 | [diff] [blame] | 11747 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, |
| 11748 | reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 11749 | "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", |
Tobin Ehlis | 3f9e8f9 | 2016-04-13 16:18:28 -0600 | [diff] [blame] | 11750 | reinterpret_cast<const uint64_t &>(event)); |
| 11751 | } |
| 11752 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11753 | lock.unlock(); |
Tobin Ehlis | e6ab693 | 2016-04-07 11:35:46 -0600 | [diff] [blame] | 11754 | // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event |
| 11755 | // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the |
| 11756 | // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) |
| 11757 | for (auto queue_data : dev_data->queueMap) { |
| 11758 | auto event_entry = queue_data.second.eventToStageMap.find(event); |
| 11759 | if (event_entry != queue_data.second.eventToStageMap.end()) { |
| 11760 | event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; |
| 11761 | } |
| 11762 | } |
Tobin Ehlis | 3f9e8f9 | 2016-04-13 16:18:28 -0600 | [diff] [blame] | 11763 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11764 | result = dev_data->dispatch_table.SetEvent(device, event); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11765 | return result; |
| 11766 | } |
| 11767 | |
| 11768 | VKAPI_ATTR VkResult VKAPI_CALL |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11769 | QueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11770 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
| 11771 | VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11772 | bool skip_call = false; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11773 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 11774 | auto pFence = getFenceNode(dev_data, fence); |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 11775 | auto pQueue = getQueueState(dev_data, queue); |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 11776 | |
Tobin Ehlis | b13975e | 2016-04-14 07:02:43 -0600 | [diff] [blame] | 11777 | // First verify that fence is not in use |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 11778 | skip_call |= ValidateFenceForSubmit(dev_data, pFence); |
| 11779 | |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11780 | if (pFence) { |
| 11781 | SubmitFence(pQueue, pFence, bindInfoCount); |
Tobin Ehlis | b13975e | 2016-04-14 07:02:43 -0600 | [diff] [blame] | 11782 | } |
Chris Forbes | d73299b | 2016-06-10 15:25:45 +1200 | [diff] [blame] | 11783 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11784 | for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { |
| 11785 | const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11786 | // Track objects tied to memory |
| 11787 | for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { |
| 11788 | for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 11789 | auto sparse_binding = bindInfo.pBufferBinds[j].pBinds[k]; |
| 11790 | if (SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, sparse_binding.size}, |
| 11791 | (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 11792 | "vkQueueBindSparse")) |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11793 | skip_call = true; |
| 11794 | } |
| 11795 | } |
| 11796 | for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { |
| 11797 | for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 11798 | auto sparse_binding = bindInfo.pImageOpaqueBinds[j].pBinds[k]; |
| 11799 | if (SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, sparse_binding.size}, |
| 11800 | (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 11801 | "vkQueueBindSparse")) |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11802 | skip_call = true; |
| 11803 | } |
| 11804 | } |
| 11805 | for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { |
| 11806 | for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 11807 | auto sparse_binding = bindInfo.pImageBinds[j].pBinds[k]; |
| 11808 | // TODO: This size is broken for non-opaque bindings, need to update to comprehend full sparse binding data |
| 11809 | VkDeviceSize size = sparse_binding.extent.depth * sparse_binding.extent.height * sparse_binding.extent.width * 4; |
| 11810 | if (SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, size}, |
| 11811 | (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 11812 | "vkQueueBindSparse")) |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11813 | skip_call = true; |
| 11814 | } |
| 11815 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11816 | |
| 11817 | std::vector<SEMAPHORE_WAIT> semaphore_waits; |
| 11818 | std::vector<VkSemaphore> semaphore_signals; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11819 | for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 11820 | VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; |
| 11821 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
| 11822 | if (pSemaphore) { |
| 11823 | if (pSemaphore->signaled) { |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11824 | if (pSemaphore->signaler.first != VK_NULL_HANDLE) { |
| 11825 | semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); |
| 11826 | pSemaphore->in_use.fetch_add(1); |
| 11827 | } |
| 11828 | pSemaphore->signaler.first = VK_NULL_HANDLE; |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 11829 | pSemaphore->signaled = false; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11830 | } else { |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11831 | skip_call |= log_msg( |
| 11832 | dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| 11833 | reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
| 11834 | "vkQueueBindSparse: Queue 0x%p is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", |
| 11835 | queue, reinterpret_cast<const uint64_t &>(semaphore)); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11836 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11837 | } |
| 11838 | } |
| 11839 | for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { |
Chris Forbes | 220fd47 | 2016-06-21 18:59:28 +1200 | [diff] [blame] | 11840 | VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; |
| 11841 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
| 11842 | if (pSemaphore) { |
| 11843 | if (pSemaphore->signaled) { |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11844 | skip_call = |
| 11845 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
| 11846 | reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11847 | "vkQueueBindSparse: Queue 0x%p is signaling semaphore 0x%" PRIx64 |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11848 | ", but that semaphore is already signaled.", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 11849 | queue, reinterpret_cast<const uint64_t &>(semaphore)); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11850 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11851 | else { |
| 11852 | pSemaphore->signaler.first = queue; |
| 11853 | pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; |
| 11854 | pSemaphore->signaled = true; |
| 11855 | pSemaphore->in_use.fetch_add(1); |
| 11856 | semaphore_signals.push_back(semaphore); |
| 11857 | } |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11858 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11859 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11860 | |
| 11861 | pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), |
| 11862 | semaphore_waits, |
| 11863 | semaphore_signals, |
| 11864 | bindIdx == bindInfoCount - 1 ? fence : VK_NULL_HANDLE); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11865 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11866 | |
| 11867 | if (pFence && !bindInfoCount) { |
| 11868 | // No work to do, just dropping a fence in the queue by itself. |
| 11869 | pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), |
| 11870 | std::vector<SEMAPHORE_WAIT>(), |
| 11871 | std::vector<VkSemaphore>(), |
| 11872 | fence); |
| 11873 | } |
| 11874 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11875 | lock.unlock(); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11876 | |
Dustin Graves | 8f1eab9 | 2016-04-05 09:41:17 -0600 | [diff] [blame] | 11877 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11878 | return dev_data->dispatch_table.QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11879 | |
| 11880 | return result; |
| 11881 | } |
| 11882 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11883 | VKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, |
| 11884 | const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11885 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11886 | VkResult result = dev_data->dispatch_table.CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11887 | if (result == VK_SUCCESS) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11888 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11889 | SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 11890 | sNode->signaler.first = VK_NULL_HANDLE; |
| 11891 | sNode->signaler.second = 0; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 11892 | sNode->signaled = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11893 | } |
| 11894 | return result; |
| 11895 | } |
| 11896 | |
| 11897 | VKAPI_ATTR VkResult VKAPI_CALL |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 11898 | CreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11899 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 11900 | VkResult result = dev_data->dispatch_table.CreateEvent(device, pCreateInfo, pAllocator, pEvent); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11901 | if (result == VK_SUCCESS) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 11902 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11903 | dev_data->eventMap[*pEvent].needsSignaled = false; |
Tony Barbour | 0646537 | 2016-06-06 10:55:04 -0600 | [diff] [blame] | 11904 | dev_data->eventMap[*pEvent].write_in_use = 0; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11905 | dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 11906 | } |
| 11907 | return result; |
| 11908 | } |
| 11909 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11910 | static bool PreCallValidateCreateSwapchainKHR(layer_data *dev_data, const char *func_name, |
| 11911 | VkSwapchainCreateInfoKHR const *pCreateInfo, SURFACE_STATE *surface_state, |
| 11912 | SWAPCHAIN_NODE *old_swapchain_state) { |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 11913 | auto most_recent_swapchain = surface_state->swapchain ? surface_state->swapchain : surface_state->old_swapchain; |
| 11914 | |
Chris Forbes | 7be86f8 | 2016-11-25 16:17:28 +1300 | [diff] [blame] | 11915 | // TODO: revisit this. some of these rules are being relaxed. |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 11916 | if (most_recent_swapchain != old_swapchain_state || (surface_state->old_swapchain && surface_state->swapchain)) { |
| 11917 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| 11918 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_ALREADY_EXISTS, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11919 | "%s: surface has an existing swapchain other than oldSwapchain", func_name)) |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 11920 | return true; |
| 11921 | } |
| 11922 | if (old_swapchain_state && old_swapchain_state->createInfo.surface != pCreateInfo->surface) { |
| 11923 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 11924 | reinterpret_cast<uint64_t const &>(pCreateInfo->oldSwapchain), __LINE__, DRAWSTATE_SWAPCHAIN_WRONG_SURFACE, |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11925 | "DS", "%s: pCreateInfo->oldSwapchain's surface is not pCreateInfo->surface", func_name)) |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 11926 | return true; |
| 11927 | } |
Chris Forbes | b52e060 | 2016-10-11 16:21:32 +1300 | [diff] [blame] | 11928 | auto physical_device_state = getPhysicalDeviceState(dev_data->instance_data, dev_data->physical_device); |
| 11929 | if (physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState == UNCALLED) { |
| 11930 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 11931 | reinterpret_cast<uint64_t>(dev_data->physical_device), __LINE__, DRAWSTATE_SWAPCHAIN_CREATE_BEFORE_QUERY, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11932 | "%s: surface capabilities not retrieved for this physical device", func_name)) |
Chris Forbes | b52e060 | 2016-10-11 16:21:32 +1300 | [diff] [blame] | 11933 | return true; |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11934 | } else { // have valid capabilities |
| 11935 | auto &capabilities = physical_device_state->surfaceCapabilities; |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11936 | // Validate pCreateInfo->minImageCount against VkSurfaceCapabilitiesKHR::{min|max}ImageCount: |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11937 | if (pCreateInfo->minImageCount < capabilities.minImageCount) { |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11938 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11939 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02331, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11940 | "%s called with minImageCount = %d, which is outside the bounds returned " |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11941 | "by vkGetPhysicalDeviceSurfaceCapabilitiesKHR() (i.e. minImageCount = %d, maxImageCount = %d). %s", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11942 | func_name, pCreateInfo->minImageCount, capabilities.minImageCount, capabilities.maxImageCount, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11943 | validation_error_map[VALIDATION_ERROR_02331])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11944 | return true; |
| 11945 | } |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11946 | |
| 11947 | if ((capabilities.maxImageCount > 0) && (pCreateInfo->minImageCount > capabilities.maxImageCount)) { |
| 11948 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| 11949 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02332, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11950 | "%s called with minImageCount = %d, which is outside the bounds returned " |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11951 | "by vkGetPhysicalDeviceSurfaceCapabilitiesKHR() (i.e. minImageCount = %d, maxImageCount = %d). %s", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11952 | func_name, pCreateInfo->minImageCount, capabilities.minImageCount, capabilities.maxImageCount, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11953 | validation_error_map[VALIDATION_ERROR_02332])) |
| 11954 | return true; |
| 11955 | } |
| 11956 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11957 | // Validate pCreateInfo->imageExtent against VkSurfaceCapabilitiesKHR::{current|min|max}ImageExtent: |
Jamie Madill | 6069c82 | 2016-12-15 09:35:36 -0500 | [diff] [blame] | 11958 | if ((capabilities.currentExtent.width == kSurfaceSizeFromSwapchain) && |
| 11959 | ((pCreateInfo->imageExtent.width < capabilities.minImageExtent.width) || |
| 11960 | (pCreateInfo->imageExtent.width > capabilities.maxImageExtent.width) || |
| 11961 | (pCreateInfo->imageExtent.height < capabilities.minImageExtent.height) || |
| 11962 | (pCreateInfo->imageExtent.height > capabilities.maxImageExtent.height))) { |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11963 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11964 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02334, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11965 | "%s called with imageExtent = (%d,%d), which is outside the bounds returned by " |
| 11966 | "vkGetPhysicalDeviceSurfaceCapabilitiesKHR(): currentExtent = (%d,%d), minImageExtent = (%d,%d), " |
| 11967 | "maxImageExtent = (%d,%d). %s", |
| 11968 | func_name, pCreateInfo->imageExtent.width, pCreateInfo->imageExtent.height, |
| 11969 | capabilities.currentExtent.width, capabilities.currentExtent.height, capabilities.minImageExtent.width, |
| 11970 | capabilities.minImageExtent.height, capabilities.maxImageExtent.width, capabilities.maxImageExtent.height, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11971 | validation_error_map[VALIDATION_ERROR_02334])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11972 | return true; |
| 11973 | } |
Jamie Madill | 6069c82 | 2016-12-15 09:35:36 -0500 | [diff] [blame] | 11974 | if ((capabilities.currentExtent.width != kSurfaceSizeFromSwapchain) && |
| 11975 | ((pCreateInfo->imageExtent.width != capabilities.currentExtent.width) || |
| 11976 | (pCreateInfo->imageExtent.height != capabilities.currentExtent.height))) { |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11977 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11978 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02334, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11979 | "%s called with imageExtent = (%d,%d), which is not equal to the currentExtent = (%d,%d) returned by " |
| 11980 | "vkGetPhysicalDeviceSurfaceCapabilitiesKHR(). %s", |
| 11981 | func_name, pCreateInfo->imageExtent.width, pCreateInfo->imageExtent.height, |
| 11982 | capabilities.currentExtent.width, capabilities.currentExtent.height, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 11983 | validation_error_map[VALIDATION_ERROR_02334])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11984 | return true; |
| 11985 | } |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11986 | // pCreateInfo->preTransform should have exactly one bit set, and that bit must also be set in |
| 11987 | // VkSurfaceCapabilitiesKHR::supportedTransforms. |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11988 | if (!pCreateInfo->preTransform || (pCreateInfo->preTransform & (pCreateInfo->preTransform - 1)) || |
| 11989 | !(pCreateInfo->preTransform & capabilities.supportedTransforms)) { |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11990 | // This is an error situation; one for which we'd like to give the developer a helpful, multi-line error message. Build |
| 11991 | // it up a little at a time, and then log it: |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11992 | std::string errorString = ""; |
| 11993 | char str[1024]; |
| 11994 | // Here's the first part of the message: |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 11995 | sprintf(str, "%s called with a non-supported pCreateInfo->preTransform (i.e. %s). Supported values are:\n", func_name, |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 11996 | string_VkSurfaceTransformFlagBitsKHR(pCreateInfo->preTransform)); |
| 11997 | errorString += str; |
| 11998 | for (int i = 0; i < 32; i++) { |
| 11999 | // Build up the rest of the message: |
| 12000 | if ((1 << i) & capabilities.supportedTransforms) { |
| 12001 | const char *newStr = string_VkSurfaceTransformFlagBitsKHR((VkSurfaceTransformFlagBitsKHR)(1 << i)); |
| 12002 | sprintf(str, " %s\n", newStr); |
| 12003 | errorString += str; |
| 12004 | } |
| 12005 | } |
| 12006 | // Log the message that we've built up: |
| 12007 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12008 | reinterpret_cast<uint64_t &>(dev_data->device), __LINE__, VALIDATION_ERROR_02339, "DS", "%s. %s", |
| 12009 | errorString.c_str(), validation_error_map[VALIDATION_ERROR_02339])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 12010 | return true; |
| 12011 | } |
Chris Forbes | f13f541 | 2016-10-31 17:20:22 +1300 | [diff] [blame] | 12012 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12013 | // pCreateInfo->compositeAlpha should have exactly one bit set, and that bit must also be set in |
| 12014 | // VkSurfaceCapabilitiesKHR::supportedCompositeAlpha |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 12015 | if (!pCreateInfo->compositeAlpha || (pCreateInfo->compositeAlpha & (pCreateInfo->compositeAlpha - 1)) || |
| 12016 | !((pCreateInfo->compositeAlpha) & capabilities.supportedCompositeAlpha)) { |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12017 | // This is an error situation; one for which we'd like to give the developer a helpful, multi-line error message. Build |
| 12018 | // it up a little at a time, and then log it: |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 12019 | std::string errorString = ""; |
| 12020 | char str[1024]; |
| 12021 | // Here's the first part of the message: |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12022 | sprintf(str, "%s called with a non-supported pCreateInfo->compositeAlpha (i.e. %s). Supported values are:\n", |
| 12023 | func_name, string_VkCompositeAlphaFlagBitsKHR(pCreateInfo->compositeAlpha)); |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 12024 | errorString += str; |
| 12025 | for (int i = 0; i < 32; i++) { |
| 12026 | // Build up the rest of the message: |
| 12027 | if ((1 << i) & capabilities.supportedCompositeAlpha) { |
| 12028 | const char *newStr = string_VkCompositeAlphaFlagBitsKHR((VkCompositeAlphaFlagBitsKHR)(1 << i)); |
| 12029 | sprintf(str, " %s\n", newStr); |
| 12030 | errorString += str; |
| 12031 | } |
| 12032 | } |
| 12033 | // Log the message that we've built up: |
| 12034 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12035 | reinterpret_cast<uint64_t &>(dev_data->device), __LINE__, VALIDATION_ERROR_02340, "DS", "%s. %s", |
| 12036 | errorString.c_str(), validation_error_map[VALIDATION_ERROR_02340])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 12037 | return true; |
| 12038 | } |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12039 | // Validate pCreateInfo->imageArrayLayers against VkSurfaceCapabilitiesKHR::maxImageArrayLayers: |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 12040 | if ((pCreateInfo->imageArrayLayers < 1) || (pCreateInfo->imageArrayLayers > capabilities.maxImageArrayLayers)) { |
| 12041 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12042 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02335, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12043 | "%s called with a non-supported imageArrayLayers (i.e. %d). Minimum value is 1, maximum value is %d. %s", |
| 12044 | func_name, pCreateInfo->imageArrayLayers, capabilities.maxImageArrayLayers, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12045 | validation_error_map[VALIDATION_ERROR_02335])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 12046 | return true; |
| 12047 | } |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12048 | // Validate pCreateInfo->imageUsage against VkSurfaceCapabilitiesKHR::supportedUsageFlags: |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 12049 | if (pCreateInfo->imageUsage != (pCreateInfo->imageUsage & capabilities.supportedUsageFlags)) { |
| 12050 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12051 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02336, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12052 | "%s called with a non-supported pCreateInfo->imageUsage (i.e. 0x%08x). Supported flag bits are 0x%08x. %s", |
| 12053 | func_name, pCreateInfo->imageUsage, capabilities.supportedUsageFlags, |
| 12054 | validation_error_map[VALIDATION_ERROR_02336])) |
Chris Forbes | fc77bbe | 2016-10-12 12:24:44 +1300 | [diff] [blame] | 12055 | return true; |
| 12056 | } |
Chris Forbes | b52e060 | 2016-10-11 16:21:32 +1300 | [diff] [blame] | 12057 | } |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 12058 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12059 | // Validate pCreateInfo values with the results of vkGetPhysicalDeviceSurfaceFormatsKHR(): |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 12060 | if (physical_device_state->vkGetPhysicalDeviceSurfaceFormatsKHRState != QUERY_DETAILS) { |
| 12061 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| 12062 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_CREATE_BEFORE_QUERY, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12063 | "%s called before calling vkGetPhysicalDeviceSurfaceFormatsKHR().", func_name)) |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 12064 | return true; |
| 12065 | } else { |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12066 | // Validate pCreateInfo->imageFormat against VkSurfaceFormatKHR::format: |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 12067 | bool foundFormat = false; |
| 12068 | bool foundColorSpace = false; |
| 12069 | bool foundMatch = false; |
| 12070 | for (auto const &format : physical_device_state->surface_formats) { |
| 12071 | if (pCreateInfo->imageFormat == format.format) { |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12072 | // Validate pCreateInfo->imageColorSpace against VkSurfaceFormatKHR::colorSpace: |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 12073 | foundFormat = true; |
| 12074 | if (pCreateInfo->imageColorSpace == format.colorSpace) { |
| 12075 | foundMatch = true; |
| 12076 | break; |
| 12077 | } |
| 12078 | } else { |
| 12079 | if (pCreateInfo->imageColorSpace == format.colorSpace) { |
| 12080 | foundColorSpace = true; |
| 12081 | } |
| 12082 | } |
| 12083 | } |
| 12084 | if (!foundMatch) { |
| 12085 | if (!foundFormat) { |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 12086 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12087 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02333, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12088 | "%s called with a non-supported pCreateInfo->imageFormat (i.e. %d). %s", |
| 12089 | func_name, pCreateInfo->imageFormat, validation_error_map[VALIDATION_ERROR_02333])) |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12090 | return true; |
| 12091 | } |
| 12092 | if (!foundColorSpace) { |
| 12093 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
| 12094 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02333, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12095 | "%s called with a non-supported pCreateInfo->imageColorSpace (i.e. %d). %s", |
| 12096 | func_name, pCreateInfo->imageColorSpace, validation_error_map[VALIDATION_ERROR_02333])) |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 12097 | return true; |
| 12098 | } |
| 12099 | } |
| 12100 | } |
| 12101 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12102 | // Validate pCreateInfo values with the results of vkGetPhysicalDeviceSurfacePresentModesKHR(): |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12103 | if (physical_device_state->vkGetPhysicalDeviceSurfacePresentModesKHRState != QUERY_DETAILS) { |
Mark Lobodzinski | ba3fe52 | 2016-12-27 16:42:06 -0700 | [diff] [blame] | 12104 | // FIFO is required to always be supported |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12105 | if (pCreateInfo->presentMode != VK_PRESENT_MODE_FIFO_KHR) { |
| 12106 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12107 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_CREATE_BEFORE_QUERY, "DS", |
| 12108 | "%s called before calling vkGetPhysicalDeviceSurfacePresentModesKHR().", func_name)) |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12109 | return true; |
| 12110 | } |
| 12111 | } else { |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12112 | // Validate pCreateInfo->presentMode against vkGetPhysicalDeviceSurfacePresentModesKHR(): |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12113 | bool foundMatch = std::find(physical_device_state->present_modes.begin(), |
| 12114 | physical_device_state->present_modes.end(), |
| 12115 | pCreateInfo->presentMode) != physical_device_state->present_modes.end(); |
| 12116 | if (!foundMatch) { |
| 12117 | if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12118 | reinterpret_cast<uint64_t>(dev_data->device), __LINE__, VALIDATION_ERROR_02341, "DS", |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12119 | "%s called with a non-supported presentMode (i.e. %s). %s", func_name, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12120 | string_VkPresentModeKHR(pCreateInfo->presentMode), validation_error_map[VALIDATION_ERROR_02341])) |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12121 | return true; |
| 12122 | } |
| 12123 | } |
| 12124 | |
Chris Forbes | bc19b5c | 2016-10-06 13:01:33 +1300 | [diff] [blame] | 12125 | return false; |
| 12126 | } |
| 12127 | |
Mark Lobodzinski | d1c3436 | 2017-01-11 12:09:31 -0700 | [diff] [blame] | 12128 | static void PostCallRecordCreateSwapchainKHR(layer_data *dev_data, VkResult result, const VkSwapchainCreateInfoKHR *pCreateInfo, |
| 12129 | VkSwapchainKHR *pSwapchain, SURFACE_STATE *surface_state, |
| 12130 | SWAPCHAIN_NODE *old_swapchain_state) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12131 | if (VK_SUCCESS == result) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12132 | std::lock_guard<std::mutex> lock(global_lock); |
Chris Forbes | c3b0815 | 2016-10-06 13:01:17 +1300 | [diff] [blame] | 12133 | auto swapchain_state = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo, *pSwapchain)); |
| 12134 | surface_state->swapchain = swapchain_state.get(); |
| 12135 | dev_data->device_extensions.swapchainMap[*pSwapchain] = std::move(swapchain_state); |
| 12136 | } else { |
| 12137 | surface_state->swapchain = nullptr; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12138 | } |
Chris Forbes | c3b0815 | 2016-10-06 13:01:17 +1300 | [diff] [blame] | 12139 | // Spec requires that even if CreateSwapchainKHR fails, oldSwapchain behaves as replaced. |
Chris Forbes | 8a047d0 | 2016-12-09 10:39:26 +1300 | [diff] [blame] | 12140 | if (old_swapchain_state) { |
| 12141 | old_swapchain_state->replaced = true; |
| 12142 | } |
Chris Forbes | c3b0815 | 2016-10-06 13:01:17 +1300 | [diff] [blame] | 12143 | surface_state->old_swapchain = old_swapchain_state; |
Mark Lobodzinski | d1c3436 | 2017-01-11 12:09:31 -0700 | [diff] [blame] | 12144 | return; |
| 12145 | } |
| 12146 | |
| 12147 | VKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, |
| 12148 | const VkAllocationCallbacks *pAllocator, VkSwapchainKHR *pSwapchain) { |
| 12149 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 12150 | auto surface_state = getSurfaceState(dev_data->instance_data, pCreateInfo->surface); |
| 12151 | auto old_swapchain_state = getSwapchainNode(dev_data, pCreateInfo->oldSwapchain); |
| 12152 | |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12153 | if (PreCallValidateCreateSwapchainKHR(dev_data, "vkCreateSwapChainKHR()", pCreateInfo, surface_state, old_swapchain_state)) { |
Mark Lobodzinski | d1c3436 | 2017-01-11 12:09:31 -0700 | [diff] [blame] | 12154 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12155 | } |
| 12156 | |
| 12157 | VkResult result = dev_data->dispatch_table.CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); |
| 12158 | |
| 12159 | PostCallRecordCreateSwapchainKHR(dev_data, result, pCreateInfo, pSwapchain, surface_state, old_swapchain_state); |
Chris Forbes | c3b0815 | 2016-10-06 13:01:17 +1300 | [diff] [blame] | 12160 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12161 | return result; |
| 12162 | } |
| 12163 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12164 | VKAPI_ATTR void VKAPI_CALL |
| 12165 | DestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12166 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12167 | bool skip_call = false; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12168 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12169 | std::unique_lock<std::mutex> lock(global_lock); |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 12170 | auto swapchain_data = getSwapchainNode(dev_data, swapchain); |
| 12171 | if (swapchain_data) { |
| 12172 | if (swapchain_data->images.size() > 0) { |
| 12173 | for (auto swapchain_image : swapchain_data->images) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12174 | auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); |
| 12175 | if (image_sub != dev_data->imageSubresourceMap.end()) { |
| 12176 | for (auto imgsubpair : image_sub->second) { |
| 12177 | auto image_item = dev_data->imageLayoutMap.find(imgsubpair); |
| 12178 | if (image_item != dev_data->imageLayoutMap.end()) { |
| 12179 | dev_data->imageLayoutMap.erase(image_item); |
| 12180 | } |
| 12181 | } |
| 12182 | dev_data->imageSubresourceMap.erase(image_sub); |
| 12183 | } |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12184 | skip_call = |
Tobin Ehlis | e89829a | 2016-10-11 17:29:32 -0600 | [diff] [blame] | 12185 | ClearMemoryObjectBindings(dev_data, (uint64_t)swapchain_image, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); |
Tobin Ehlis | f263ba4 | 2016-04-05 13:33:00 -0600 | [diff] [blame] | 12186 | dev_data->imageMap.erase(swapchain_image); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12187 | } |
| 12188 | } |
Chris Forbes | c3b0815 | 2016-10-06 13:01:17 +1300 | [diff] [blame] | 12189 | |
| 12190 | auto surface_state = getSurfaceState(dev_data->instance_data, swapchain_data->createInfo.surface); |
| 12191 | if (surface_state) { |
| 12192 | if (surface_state->swapchain == swapchain_data) |
| 12193 | surface_state->swapchain = nullptr; |
| 12194 | if (surface_state->old_swapchain == swapchain_data) |
| 12195 | surface_state->old_swapchain = nullptr; |
| 12196 | } |
| 12197 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12198 | dev_data->device_extensions.swapchainMap.erase(swapchain); |
| 12199 | } |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12200 | lock.unlock(); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12201 | if (!skip_call) |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12202 | dev_data->dispatch_table.DestroySwapchainKHR(device, swapchain, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12203 | } |
| 12204 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12205 | VKAPI_ATTR VkResult VKAPI_CALL |
| 12206 | GetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12207 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12208 | VkResult result = dev_data->dispatch_table.GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12209 | |
| 12210 | if (result == VK_SUCCESS && pSwapchainImages != NULL) { |
| 12211 | // This should never happen and is checked by param checker. |
| 12212 | if (!pCount) |
| 12213 | return result; |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12214 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12215 | const size_t count = *pCount; |
Tobin Ehlis | 4e38059 | 2016-06-02 12:41:47 -0600 | [diff] [blame] | 12216 | auto swapchain_node = getSwapchainNode(dev_data, swapchain); |
| 12217 | if (swapchain_node && !swapchain_node->images.empty()) { |
Tobin Ehlis | 43d7c52 | 2016-03-16 13:52:20 -0600 | [diff] [blame] | 12218 | // TODO : Not sure I like the memcmp here, but it works |
| 12219 | const bool mismatch = (swapchain_node->images.size() != count || |
| 12220 | memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12221 | if (mismatch) { |
| 12222 | // TODO: Verify against Valid Usage section of extension |
| 12223 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12224 | (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", |
Mark Mueller | aab3650 | 2016-05-03 13:17:29 -0600 | [diff] [blame] | 12225 | "vkGetSwapchainInfoKHR(0x%" PRIx64 |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12226 | ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", |
| 12227 | (uint64_t)(swapchain)); |
| 12228 | } |
| 12229 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12230 | for (uint32_t i = 0; i < *pCount; ++i) { |
| 12231 | IMAGE_LAYOUT_NODE image_layout_node; |
| 12232 | image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12233 | image_layout_node.format = swapchain_node->createInfo.imageFormat; |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 12234 | // Add imageMap entries for each swapchain image |
| 12235 | VkImageCreateInfo image_ci = {}; |
| 12236 | image_ci.mipLevels = 1; |
| 12237 | image_ci.arrayLayers = swapchain_node->createInfo.imageArrayLayers; |
| 12238 | image_ci.usage = swapchain_node->createInfo.imageUsage; |
| 12239 | image_ci.format = swapchain_node->createInfo.imageFormat; |
Tobin Ehlis | dae051d | 2016-06-22 14:16:06 -0600 | [diff] [blame] | 12240 | image_ci.samples = VK_SAMPLE_COUNT_1_BIT; |
Tobin Ehlis | 1c9c55f | 2016-06-02 11:49:22 -0600 | [diff] [blame] | 12241 | image_ci.extent.width = swapchain_node->createInfo.imageExtent.width; |
| 12242 | image_ci.extent.height = swapchain_node->createInfo.imageExtent.height; |
| 12243 | image_ci.sharingMode = swapchain_node->createInfo.imageSharingMode; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 12244 | dev_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_STATE>(new IMAGE_STATE(pSwapchainImages[i], &image_ci)); |
| 12245 | auto &image_state = dev_data->imageMap[pSwapchainImages[i]]; |
| 12246 | image_state->valid = false; |
Tobin Ehlis | 5410827 | 2016-10-11 14:26:49 -0600 | [diff] [blame] | 12247 | image_state->binding.mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12248 | swapchain_node->images.push_back(pSwapchainImages[i]); |
| 12249 | ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; |
| 12250 | dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); |
| 12251 | dev_data->imageLayoutMap[subpair] = image_layout_node; |
| 12252 | dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; |
| 12253 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12254 | } |
| 12255 | return result; |
| 12256 | } |
| 12257 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12258 | VKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12259 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12260 | bool skip_call = false; |
| 12261 | |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12262 | std::lock_guard<std::mutex> lock(global_lock); |
Tobin Ehlis | 3cd97ff | 2016-12-15 11:37:02 -0700 | [diff] [blame] | 12263 | auto queue_state = getQueueState(dev_data, queue); |
Chris Forbes | b998bf9 | 2016-10-12 10:21:19 +1300 | [diff] [blame] | 12264 | |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12265 | for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { |
| 12266 | auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); |
| 12267 | if (pSemaphore && !pSemaphore->signaled) { |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 12268 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, |
| 12269 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, |
| 12270 | "DS", "Queue 0x%p is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", queue, |
| 12271 | reinterpret_cast<const uint64_t &>(pPresentInfo->pWaitSemaphores[i])); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12272 | } |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12273 | } |
Tobin Ehlis | 5611e92 | 2016-06-28 15:52:55 -0600 | [diff] [blame] | 12274 | |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12275 | for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { |
| 12276 | auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); |
Chris Forbes | f6f063d | 2016-09-22 18:34:20 +1200 | [diff] [blame] | 12277 | if (swapchain_data) { |
| 12278 | if (pPresentInfo->pImageIndices[i] >= swapchain_data->images.size()) { |
| 12279 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
Chris Forbes | f54f4c7 | 2016-09-26 15:18:57 +1300 | [diff] [blame] | 12280 | reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_INVALID_IMAGE, |
Chris Forbes | f6f063d | 2016-09-22 18:34:20 +1200 | [diff] [blame] | 12281 | "DS", "vkQueuePresentKHR: Swapchain image index too large (%u). There are only %u images in this swapchain.", |
| 12282 | pPresentInfo->pImageIndices[i], (uint32_t)swapchain_data->images.size()); |
| 12283 | } |
| 12284 | else { |
| 12285 | auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 12286 | auto image_state = getImageState(dev_data, image); |
| 12287 | skip_call |= ValidateImageMemoryIsValid(dev_data, image_state, "vkQueuePresentKHR()"); |
Chris Forbes | f6f063d | 2016-09-22 18:34:20 +1200 | [diff] [blame] | 12288 | |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 12289 | if (!image_state->acquired) { |
Chris Forbes | f6f063d | 2016-09-22 18:34:20 +1200 | [diff] [blame] | 12290 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12291 | reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_IMAGE_NOT_ACQUIRED, |
| 12292 | "DS", "vkQueuePresentKHR: Swapchain image index %u has not been acquired.", |
| 12293 | pPresentInfo->pImageIndices[i]); |
| 12294 | } |
| 12295 | |
| 12296 | vector<VkImageLayout> layouts; |
| 12297 | if (FindLayouts(dev_data, image, layouts)) { |
| 12298 | for (auto layout : layouts) { |
| 12299 | if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { |
| 12300 | skip_call |= |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12301 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, |
| 12302 | reinterpret_cast<uint64_t &>(queue), __LINE__, VALIDATION_ERROR_01964, "DS", |
| 12303 | "Images passed to present must be in layout " |
| 12304 | "VK_IMAGE_LAYOUT_PRESENT_SRC_KHR but is in %s. %s", |
| 12305 | string_VkImageLayout(layout), validation_error_map[VALIDATION_ERROR_01964]); |
Chris Forbes | f6f063d | 2016-09-22 18:34:20 +1200 | [diff] [blame] | 12306 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12307 | } |
| 12308 | } |
| 12309 | } |
Chris Forbes | b998bf9 | 2016-10-12 10:21:19 +1300 | [diff] [blame] | 12310 | |
| 12311 | // All physical devices and queue families are required to be able |
| 12312 | // to present to any native window on Android; require the |
| 12313 | // application to have established support on any other platform. |
| 12314 | if (!dev_data->instance_data->androidSurfaceExtensionEnabled) { |
| 12315 | auto surface_state = getSurfaceState(dev_data->instance_data, swapchain_data->createInfo.surface); |
| 12316 | auto support_it = surface_state->gpu_queue_support.find({dev_data->physical_device, queue_state->queueFamilyIndex}); |
| 12317 | |
| 12318 | if (support_it == surface_state->gpu_queue_support.end()) { |
| 12319 | skip_call |= |
| 12320 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12321 | reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, |
| 12322 | DRAWSTATE_SWAPCHAIN_UNSUPPORTED_QUEUE, "DS", "vkQueuePresentKHR: Presenting image without calling " |
| 12323 | "vkGetPhysicalDeviceSurfaceSupportKHR"); |
| 12324 | } else if (!support_it->second) { |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12325 | skip_call |= |
| 12326 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12327 | reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, VALIDATION_ERROR_01961, |
| 12328 | "DS", "vkQueuePresentKHR: Presenting image on queue that cannot " |
| 12329 | "present to this surface. %s", |
| 12330 | validation_error_map[VALIDATION_ERROR_01961]); |
Chris Forbes | b998bf9 | 2016-10-12 10:21:19 +1300 | [diff] [blame] | 12331 | } |
| 12332 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12333 | } |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12334 | } |
| 12335 | |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12336 | if (skip_call) { |
| 12337 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12338 | } |
| 12339 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12340 | VkResult result = dev_data->dispatch_table.QueuePresentKHR(queue, pPresentInfo); |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12341 | |
| 12342 | if (result != VK_ERROR_VALIDATION_FAILED_EXT) { |
| 12343 | // Semaphore waits occur before error generation, if the call reached |
| 12344 | // the ICD. (Confirm?) |
| 12345 | for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { |
| 12346 | auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 12347 | if (pSemaphore) { |
| 12348 | pSemaphore->signaler.first = VK_NULL_HANDLE; |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12349 | pSemaphore->signaled = false; |
| 12350 | } |
| 12351 | } |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 12352 | |
Chris Forbes | 048399d | 2016-09-22 17:11:06 +1200 | [diff] [blame] | 12353 | for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { |
| 12354 | // Note: this is imperfect, in that we can get confused about what |
| 12355 | // did or didn't succeed-- but if the app does that, it's confused |
| 12356 | // itself just as much. |
| 12357 | auto local_result = pPresentInfo->pResults ? pPresentInfo->pResults[i] : result; |
| 12358 | |
| 12359 | if (local_result != VK_SUCCESS && local_result != VK_SUBOPTIMAL_KHR) |
| 12360 | continue; // this present didn't actually happen. |
| 12361 | |
| 12362 | // Mark the image as having been released to the WSI |
| 12363 | auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); |
| 12364 | auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 12365 | auto image_state = getImageState(dev_data, image); |
| 12366 | image_state->acquired = false; |
Chris Forbes | 048399d | 2016-09-22 17:11:06 +1200 | [diff] [blame] | 12367 | } |
| 12368 | |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 12369 | // Note: even though presentation is directed to a queue, there is no |
| 12370 | // direct ordering between QP and subsequent work, so QP (and its |
| 12371 | // semaphore waits) /never/ participate in any completion proof. |
Chris Forbes | 95b4fa3 | 2016-06-16 17:14:34 +1200 | [diff] [blame] | 12372 | } |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 12373 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12374 | return result; |
| 12375 | } |
| 12376 | |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12377 | static bool PreCallValidateCreateSharedSwapchainsKHR(layer_data *dev_data, uint32_t swapchainCount, |
| 12378 | const VkSwapchainCreateInfoKHR *pCreateInfos, VkSwapchainKHR *pSwapchains, |
| 12379 | std::vector<SURFACE_STATE *> &surface_state, |
| 12380 | std::vector<SWAPCHAIN_NODE *> &old_swapchain_state) { |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12381 | if (pCreateInfos) { |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12382 | std::lock_guard<std::mutex> lock(global_lock); |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12383 | for (uint32_t i = 0; i < swapchainCount; i++) { |
| 12384 | surface_state.push_back(getSurfaceState(dev_data->instance_data, pCreateInfos[i].surface)); |
| 12385 | old_swapchain_state.push_back(getSwapchainNode(dev_data, pCreateInfos[i].oldSwapchain)); |
Mark Lobodzinski | ec3cf78 | 2017-01-11 13:54:09 -0700 | [diff] [blame] | 12386 | std::stringstream func_name; |
| 12387 | func_name << "vkCreateSharedSwapchainsKHR[" << swapchainCount << "]"; |
| 12388 | if (PreCallValidateCreateSwapchainKHR(dev_data, func_name.str().c_str(), &pCreateInfos[i], surface_state[i], old_swapchain_state[i])) { |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12389 | return true; |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12390 | } |
| 12391 | } |
| 12392 | } |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12393 | return false; |
| 12394 | } |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12395 | |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12396 | static void PostCallRecordCreateSharedSwapchainsKHR(layer_data *dev_data, VkResult result, uint32_t swapchainCount, |
| 12397 | const VkSwapchainCreateInfoKHR *pCreateInfos, VkSwapchainKHR *pSwapchains, |
| 12398 | std::vector<SURFACE_STATE *> &surface_state, |
| 12399 | std::vector<SWAPCHAIN_NODE *> &old_swapchain_state) { |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12400 | if (VK_SUCCESS == result) { |
| 12401 | for (uint32_t i = 0; i < swapchainCount; i++) { |
| 12402 | auto swapchain_state = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(&pCreateInfos[i], pSwapchains[i])); |
| 12403 | surface_state[i]->swapchain = swapchain_state.get(); |
| 12404 | dev_data->device_extensions.swapchainMap[pSwapchains[i]] = std::move(swapchain_state); |
| 12405 | } |
| 12406 | } else { |
| 12407 | for (uint32_t i = 0; i < swapchainCount; i++) { |
| 12408 | surface_state[i]->swapchain = nullptr; |
| 12409 | } |
| 12410 | } |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12411 | // Spec requires that even if CreateSharedSwapchainKHR fails, oldSwapchain behaves as replaced. |
| 12412 | for (uint32_t i = 0; i < swapchainCount; i++) { |
| 12413 | if (old_swapchain_state[i]) { |
| 12414 | old_swapchain_state[i]->replaced = true; |
| 12415 | } |
| 12416 | surface_state[i]->old_swapchain = old_swapchain_state[i]; |
| 12417 | } |
Mark Lobodzinski | 8ba5e25 | 2017-01-11 13:14:36 -0700 | [diff] [blame] | 12418 | return; |
| 12419 | } |
| 12420 | |
| 12421 | VKAPI_ATTR VkResult VKAPI_CALL CreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount, |
| 12422 | const VkSwapchainCreateInfoKHR *pCreateInfos, |
| 12423 | const VkAllocationCallbacks *pAllocator, VkSwapchainKHR *pSwapchains) { |
| 12424 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
| 12425 | std::vector<SURFACE_STATE *> surface_state; |
| 12426 | std::vector<SWAPCHAIN_NODE *> old_swapchain_state; |
| 12427 | |
| 12428 | if (PreCallValidateCreateSharedSwapchainsKHR(dev_data, swapchainCount, pCreateInfos, pSwapchains, surface_state, |
| 12429 | old_swapchain_state)) { |
| 12430 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12431 | } |
| 12432 | |
| 12433 | VkResult result = |
| 12434 | dev_data->dispatch_table.CreateSharedSwapchainsKHR(device, swapchainCount, pCreateInfos, pAllocator, pSwapchains); |
| 12435 | |
| 12436 | PostCallRecordCreateSharedSwapchainsKHR(dev_data, result, swapchainCount, pCreateInfos, pSwapchains, surface_state, |
| 12437 | old_swapchain_state); |
Mark Lobodzinski | f4d069f | 2017-01-10 18:10:03 -0700 | [diff] [blame] | 12438 | |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 12439 | return result; |
| 12440 | } |
| 12441 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12442 | VKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, |
| 12443 | VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12444 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12445 | bool skip_call = false; |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 12446 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12447 | std::unique_lock<std::mutex> lock(global_lock); |
Chris Forbes | 76fa6c6 | 2016-09-22 16:40:27 +1200 | [diff] [blame] | 12448 | |
| 12449 | if (fence == VK_NULL_HANDLE && semaphore == VK_NULL_HANDLE) { |
| 12450 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, |
Chris Forbes | f54f4c7 | 2016-09-26 15:18:57 +1300 | [diff] [blame] | 12451 | reinterpret_cast<uint64_t &>(device), __LINE__, DRAWSTATE_SWAPCHAIN_NO_SYNC_FOR_ACQUIRE, "DS", |
Chris Forbes | 76fa6c6 | 2016-09-22 16:40:27 +1200 | [diff] [blame] | 12452 | "vkAcquireNextImageKHR: Semaphore and fence cannot both be VK_NULL_HANDLE. There would be no way " |
| 12453 | "to determine the completion of this operation."); |
| 12454 | } |
| 12455 | |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12456 | auto pSemaphore = getSemaphoreNode(dev_data, semaphore); |
| 12457 | if (pSemaphore && pSemaphore->signaled) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12458 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12459 | reinterpret_cast<const uint64_t &>(semaphore), __LINE__, VALIDATION_ERROR_01952, "DS", |
| 12460 | "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state. %s", |
| 12461 | validation_error_map[VALIDATION_ERROR_01952]); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12462 | } |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12463 | |
| 12464 | auto pFence = getFenceNode(dev_data, fence); |
| 12465 | if (pFence) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12466 | skip_call |= ValidateFenceForSubmit(dev_data, pFence); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12467 | } |
Chris Forbes | 73de085 | 2016-10-12 13:27:13 +1300 | [diff] [blame] | 12468 | |
| 12469 | auto swapchain_data = getSwapchainNode(dev_data, swapchain); |
Chris Forbes | 9a936d7 | 2016-12-09 11:00:21 +1300 | [diff] [blame] | 12470 | |
| 12471 | if (swapchain_data->replaced) { |
| 12472 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12473 | reinterpret_cast<uint64_t &>(swapchain), __LINE__, DRAWSTATE_SWAPCHAIN_REPLACED, "DS", |
| 12474 | "vkAcquireNextImageKHR: This swapchain has been replaced. The application can still " |
| 12475 | "present any images it has acquired, but cannot acquire any more."); |
| 12476 | } |
| 12477 | |
Chris Forbes | 73de085 | 2016-10-12 13:27:13 +1300 | [diff] [blame] | 12478 | auto physical_device_state = getPhysicalDeviceState(dev_data->instance_data, dev_data->physical_device); |
| 12479 | if (physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState != UNCALLED) { |
Mark Lobodzinski | 9e02344 | 2016-11-23 11:28:30 -0700 | [diff] [blame] | 12480 | uint64_t acquired_images = std::count_if(swapchain_data->images.begin(), swapchain_data->images.end(), |
| 12481 | [=](VkImage image) { return getImageState(dev_data, image)->acquired; }); |
Chris Forbes | 73de085 | 2016-10-12 13:27:13 +1300 | [diff] [blame] | 12482 | if (acquired_images > swapchain_data->images.size() - physical_device_state->surfaceCapabilities.minImageCount) { |
Mark Lobodzinski | 9e02344 | 2016-11-23 11:28:30 -0700 | [diff] [blame] | 12483 | skip_call |= |
| 12484 | log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12485 | reinterpret_cast<uint64_t const &>(swapchain), __LINE__, DRAWSTATE_SWAPCHAIN_TOO_MANY_IMAGES, "DS", |
| 12486 | "vkAcquireNextImageKHR: Application has already acquired the maximum number of images (0x%" PRIxLEAST64 ")", |
| 12487 | acquired_images); |
Chris Forbes | 73de085 | 2016-10-12 13:27:13 +1300 | [diff] [blame] | 12488 | } |
| 12489 | } |
Thomas Louis | 628139e | 2017-01-11 00:17:08 +0100 | [diff] [blame] | 12490 | |
| 12491 | if (swapchain_data->images.size() == 0) { |
| 12492 | skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, |
| 12493 | reinterpret_cast<uint64_t const &>(swapchain), __LINE__, DRAWSTATE_SWAPCHAIN_IMAGES_NOT_FOUND, "DS", |
| 12494 | "vkAcquireNextImageKHR: No images found to acquire from. Application probably did not call " |
| 12495 | "vkGetSwapchainImagesKHR after swapchain creation."); |
| 12496 | } |
| 12497 | |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12498 | lock.unlock(); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 12499 | |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12500 | if (skip_call) |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12501 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12502 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12503 | VkResult result = dev_data->dispatch_table.AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12504 | |
| 12505 | lock.lock(); |
| 12506 | if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { |
| 12507 | if (pFence) { |
| 12508 | pFence->state = FENCE_INFLIGHT; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 12509 | pFence->signaler.first = VK_NULL_HANDLE; // ANI isn't on a queue, so this can't participate in a completion proof. |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12510 | } |
| 12511 | |
| 12512 | // A successful call to AcquireNextImageKHR counts as a signal operation on semaphore |
| 12513 | if (pSemaphore) { |
| 12514 | pSemaphore->signaled = true; |
Chris Forbes | 8320a8d | 2016-08-01 15:15:30 +1200 | [diff] [blame] | 12515 | pSemaphore->signaler.first = VK_NULL_HANDLE; |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12516 | } |
Chris Forbes | 048399d | 2016-09-22 17:11:06 +1200 | [diff] [blame] | 12517 | |
| 12518 | // Mark the image as acquired. |
Chris Forbes | 048399d | 2016-09-22 17:11:06 +1200 | [diff] [blame] | 12519 | auto image = swapchain_data->images[*pImageIndex]; |
Tobin Ehlis | 30df15c | 2016-10-12 17:17:57 -0600 | [diff] [blame] | 12520 | auto image_state = getImageState(dev_data, image); |
| 12521 | image_state->acquired = true; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12522 | } |
Chris Forbes | 8784e95 | 2016-06-16 12:20:32 +1200 | [diff] [blame] | 12523 | lock.unlock(); |
Tobin Ehlis | 9984f1e | 2016-04-12 10:49:41 -0600 | [diff] [blame] | 12524 | |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12525 | return result; |
| 12526 | } |
| 12527 | |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 12528 | VKAPI_ATTR VkResult VKAPI_CALL EnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount, |
| 12529 | VkPhysicalDevice *pPhysicalDevices) { |
Tobin Ehlis | fe87128 | 2016-06-28 10:28:02 -0600 | [diff] [blame] | 12530 | bool skip_call = false; |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 12531 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
Tobin Ehlis | 8b0fbe2 | 2017-01-04 07:53:33 -0700 | [diff] [blame] | 12532 | assert(instance_data); |
Chris Forbes | a13fe52 | 2016-10-13 15:34:59 +1300 | [diff] [blame] | 12533 | |
Tobin Ehlis | 8b0fbe2 | 2017-01-04 07:53:33 -0700 | [diff] [blame] | 12534 | // For this instance, flag when vkEnumeratePhysicalDevices goes to QUERY_COUNT and then QUERY_DETAILS |
| 12535 | if (NULL == pPhysicalDevices) { |
| 12536 | instance_data->vkEnumeratePhysicalDevicesState = QUERY_COUNT; |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 12537 | } else { |
Tobin Ehlis | 8b0fbe2 | 2017-01-04 07:53:33 -0700 | [diff] [blame] | 12538 | if (UNCALLED == instance_data->vkEnumeratePhysicalDevicesState) { |
| 12539 | // Flag warning here. You can call this without having queried the count, but it may not be |
| 12540 | // robust on platforms with multiple physical devices. |
| 12541 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 12542 | VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", |
| 12543 | "Call sequence has vkEnumeratePhysicalDevices() w/ non-NULL pPhysicalDevices. You should first " |
| 12544 | "call vkEnumeratePhysicalDevices() w/ NULL pPhysicalDevices to query pPhysicalDeviceCount."); |
| 12545 | } // TODO : Could also flag a warning if re-calling this function in QUERY_DETAILS state |
| 12546 | else if (instance_data->physical_devices_count != *pPhysicalDeviceCount) { |
| 12547 | // Having actual count match count from app is not a requirement, so this can be a warning |
| 12548 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
| 12549 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| 12550 | "Call to vkEnumeratePhysicalDevices() w/ pPhysicalDeviceCount value %u, but actual count " |
| 12551 | "supported by this instance is %u.", |
| 12552 | *pPhysicalDeviceCount, instance_data->physical_devices_count); |
| 12553 | } |
| 12554 | instance_data->vkEnumeratePhysicalDevicesState = QUERY_DETAILS; |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 12555 | } |
Tobin Ehlis | 8b0fbe2 | 2017-01-04 07:53:33 -0700 | [diff] [blame] | 12556 | if (skip_call) { |
| 12557 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12558 | } |
| 12559 | VkResult result = instance_data->dispatch_table.EnumeratePhysicalDevices(instance, pPhysicalDeviceCount, pPhysicalDevices); |
| 12560 | if (NULL == pPhysicalDevices) { |
| 12561 | instance_data->physical_devices_count = *pPhysicalDeviceCount; |
| 12562 | } else if (result == VK_SUCCESS) { // Save physical devices |
| 12563 | for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) { |
| 12564 | auto &phys_device_state = instance_data->physical_device_map[pPhysicalDevices[i]]; |
| 12565 | phys_device_state.phys_device = pPhysicalDevices[i]; |
| 12566 | // Init actual features for each physical device |
| 12567 | instance_data->dispatch_table.GetPhysicalDeviceFeatures(pPhysicalDevices[i], &phys_device_state.features); |
| 12568 | } |
| 12569 | } |
| 12570 | return result; |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 12571 | } |
| 12572 | |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12573 | VKAPI_ATTR void VKAPI_CALL |
| 12574 | GetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, |
| 12575 | VkQueueFamilyProperties *pQueueFamilyProperties) { |
| 12576 | bool skip_call = false; |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 12577 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
Chris Forbes | a88f31b | 2016-10-03 17:57:18 +1300 | [diff] [blame] | 12578 | auto physical_device_state = getPhysicalDeviceState(instance_data, physicalDevice); |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12579 | if (physical_device_state) { |
| 12580 | if (!pQueueFamilyProperties) { |
| 12581 | physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_COUNT; |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12582 | } |
| 12583 | else { |
| 12584 | // Verify that for each physical device, this function is called first with NULL pQueueFamilyProperties ptr in order to |
| 12585 | // get count |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12586 | if (UNCALLED == physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { |
Chris Forbes | a88f31b | 2016-10-03 17:57:18 +1300 | [diff] [blame] | 12587 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12588 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", |
| 12589 | "Call sequence has vkGetPhysicalDeviceQueueFamilyProperties() w/ non-NULL " |
| 12590 | "pQueueFamilyProperties. You should first call vkGetPhysicalDeviceQueueFamilyProperties() w/ " |
| 12591 | "NULL pQueueFamilyProperties to query pCount."); |
| 12592 | } |
| 12593 | // Then verify that pCount that is passed in on second call matches what was returned |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12594 | if (physical_device_state->queueFamilyPropertiesCount != *pCount) { |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12595 | |
| 12596 | // TODO: this is not a requirement of the Valid Usage section for vkGetPhysicalDeviceQueueFamilyProperties, so |
| 12597 | // provide as warning |
Chris Forbes | a88f31b | 2016-10-03 17:57:18 +1300 | [diff] [blame] | 12598 | skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12599 | VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| 12600 | "Call to vkGetPhysicalDeviceQueueFamilyProperties() w/ pCount value %u, but actual count " |
| 12601 | "supported by this physicalDevice is %u.", |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12602 | *pCount, physical_device_state->queueFamilyPropertiesCount); |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12603 | } |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12604 | physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_DETAILS; |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12605 | } |
| 12606 | if (skip_call) { |
| 12607 | return; |
| 12608 | } |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 12609 | instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(physicalDevice, pCount, pQueueFamilyProperties); |
Chris Forbes | 7ff421e | 2016-10-03 17:55:48 +1300 | [diff] [blame] | 12610 | if (!pQueueFamilyProperties) { |
| 12611 | physical_device_state->queueFamilyPropertiesCount = *pCount; |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12612 | } |
| 12613 | else { // Save queue family properties |
Chris Forbes | 8c09adb | 2016-10-03 18:06:20 +1300 | [diff] [blame] | 12614 | if (physical_device_state->queue_family_properties.size() < *pCount) |
| 12615 | physical_device_state->queue_family_properties.resize(*pCount); |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12616 | for (uint32_t i = 0; i < *pCount; i++) { |
Chris Forbes | 8c09adb | 2016-10-03 18:06:20 +1300 | [diff] [blame] | 12617 | physical_device_state->queue_family_properties[i] = pQueueFamilyProperties[i]; |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12618 | } |
| 12619 | } |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12620 | } |
| 12621 | else { |
Chris Forbes | a88f31b | 2016-10-03 17:57:18 +1300 | [diff] [blame] | 12622 | log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, |
Mike Weiblen | d3fb313 | 2016-12-06 10:28:00 -0700 | [diff] [blame] | 12623 | __LINE__, VALIDATION_ERROR_00028, "DL", |
Tobin Ehlis | 50b6c17 | 2016-12-22 10:42:36 -0700 | [diff] [blame] | 12624 | "Invalid physicalDevice (0x%p) passed into vkGetPhysicalDeviceQueueFamilyProperties(). %s", physicalDevice, |
| 12625 | validation_error_map[VALIDATION_ERROR_00028]); |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 12626 | } |
| 12627 | } |
| 12628 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 12629 | template<typename TCreateInfo, typename FPtr> |
| 12630 | static VkResult CreateSurface(VkInstance instance, TCreateInfo const *pCreateInfo, |
| 12631 | VkAllocationCallbacks const *pAllocator, VkSurfaceKHR *pSurface, |
| 12632 | FPtr fptr) |
| 12633 | { |
| 12634 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
| 12635 | |
| 12636 | // Call down the call chain: |
| 12637 | VkResult result = (instance_data->dispatch_table.*fptr)(instance, pCreateInfo, pAllocator, pSurface); |
| 12638 | |
| 12639 | if (result == VK_SUCCESS) { |
| 12640 | std::unique_lock<std::mutex> lock(global_lock); |
| 12641 | instance_data->surface_map[*pSurface] = SURFACE_STATE(*pSurface); |
| 12642 | lock.unlock(); |
| 12643 | } |
| 12644 | |
| 12645 | return result; |
| 12646 | } |
| 12647 | |
| 12648 | VKAPI_ATTR void VKAPI_CALL DestroySurfaceKHR(VkInstance instance, VkSurfaceKHR surface, const VkAllocationCallbacks *pAllocator) { |
| 12649 | bool skip_call = false; |
| 12650 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
| 12651 | std::unique_lock<std::mutex> lock(global_lock); |
| 12652 | auto surface_state = getSurfaceState(instance_data, surface); |
| 12653 | |
| 12654 | if (surface_state) { |
| 12655 | // TODO: track swapchains created from this surface. |
| 12656 | instance_data->surface_map.erase(surface); |
| 12657 | } |
| 12658 | lock.unlock(); |
| 12659 | |
| 12660 | if (!skip_call) { |
| 12661 | // Call down the call chain: |
| 12662 | instance_data->dispatch_table.DestroySurfaceKHR(instance, surface, pAllocator); |
| 12663 | } |
| 12664 | } |
| 12665 | |
Norbert Nopper | 1dec9a5 | 2016-11-25 07:55:13 +0100 | [diff] [blame] | 12666 | VKAPI_ATTR VkResult VKAPI_CALL CreateDisplayPlaneSurfaceKHR(VkInstance instance, const VkDisplaySurfaceCreateInfoKHR *pCreateInfo, |
| 12667 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12668 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateDisplayPlaneSurfaceKHR); |
| 12669 | } |
| 12670 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 12671 | #ifdef VK_USE_PLATFORM_ANDROID_KHR |
| 12672 | VKAPI_ATTR VkResult VKAPI_CALL CreateAndroidSurfaceKHR(VkInstance instance, const VkAndroidSurfaceCreateInfoKHR *pCreateInfo, |
| 12673 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12674 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateAndroidSurfaceKHR); |
| 12675 | } |
| 12676 | #endif // VK_USE_PLATFORM_ANDROID_KHR |
| 12677 | |
| 12678 | #ifdef VK_USE_PLATFORM_MIR_KHR |
| 12679 | VKAPI_ATTR VkResult VKAPI_CALL CreateMirSurfaceKHR(VkInstance instance, const VkMirSurfaceCreateInfoKHR *pCreateInfo, |
| 12680 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12681 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateMirSurfaceKHR); |
| 12682 | } |
| 12683 | #endif // VK_USE_PLATFORM_MIR_KHR |
| 12684 | |
| 12685 | #ifdef VK_USE_PLATFORM_WAYLAND_KHR |
| 12686 | VKAPI_ATTR VkResult VKAPI_CALL CreateWaylandSurfaceKHR(VkInstance instance, const VkWaylandSurfaceCreateInfoKHR *pCreateInfo, |
| 12687 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
Tobin Ehlis | ce0dcd2 | 2016-10-06 09:11:25 -0600 | [diff] [blame] | 12688 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateWaylandSurfaceKHR); |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 12689 | } |
| 12690 | #endif // VK_USE_PLATFORM_WAYLAND_KHR |
| 12691 | |
| 12692 | #ifdef VK_USE_PLATFORM_WIN32_KHR |
| 12693 | VKAPI_ATTR VkResult VKAPI_CALL CreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo, |
| 12694 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12695 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateWin32SurfaceKHR); |
| 12696 | } |
| 12697 | #endif // VK_USE_PLATFORM_WIN32_KHR |
| 12698 | |
| 12699 | #ifdef VK_USE_PLATFORM_XCB_KHR |
| 12700 | VKAPI_ATTR VkResult VKAPI_CALL CreateXcbSurfaceKHR(VkInstance instance, const VkXcbSurfaceCreateInfoKHR *pCreateInfo, |
| 12701 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12702 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateXcbSurfaceKHR); |
| 12703 | } |
| 12704 | #endif // VK_USE_PLATFORM_XCB_KHR |
| 12705 | |
| 12706 | #ifdef VK_USE_PLATFORM_XLIB_KHR |
| 12707 | VKAPI_ATTR VkResult VKAPI_CALL CreateXlibSurfaceKHR(VkInstance instance, const VkXlibSurfaceCreateInfoKHR *pCreateInfo, |
| 12708 | const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { |
| 12709 | return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateXlibSurfaceKHR); |
| 12710 | } |
| 12711 | #endif // VK_USE_PLATFORM_XLIB_KHR |
| 12712 | |
| 12713 | |
Chris Forbes | 6c2bc8f | 2016-10-11 15:57:55 +1300 | [diff] [blame] | 12714 | VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceCapabilitiesKHR(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, |
| 12715 | VkSurfaceCapabilitiesKHR *pSurfaceCapabilities) { |
| 12716 | auto instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| 12717 | |
| 12718 | std::unique_lock<std::mutex> lock(global_lock); |
| 12719 | auto physical_device_state = getPhysicalDeviceState(instance_data, physicalDevice); |
| 12720 | lock.unlock(); |
| 12721 | |
| 12722 | auto result = instance_data->dispatch_table.GetPhysicalDeviceSurfaceCapabilitiesKHR(physicalDevice, surface, |
| 12723 | pSurfaceCapabilities); |
| 12724 | |
| 12725 | if (result == VK_SUCCESS) { |
| 12726 | physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState = QUERY_DETAILS; |
| 12727 | physical_device_state->surfaceCapabilities = *pSurfaceCapabilities; |
| 12728 | } |
| 12729 | |
| 12730 | return result; |
| 12731 | } |
| 12732 | |
Chris Forbes | 97058a6 | 2016-10-12 08:55:03 +1300 | [diff] [blame] | 12733 | |
| 12734 | VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceSupportKHR(VkPhysicalDevice physicalDevice, uint32_t queueFamilyIndex, |
| 12735 | VkSurfaceKHR surface, VkBool32 *pSupported) { |
| 12736 | auto instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| 12737 | std::unique_lock<std::mutex> lock(global_lock); |
| 12738 | auto surface_state = getSurfaceState(instance_data, surface); |
| 12739 | lock.unlock(); |
| 12740 | |
| 12741 | auto result = instance_data->dispatch_table.GetPhysicalDeviceSurfaceSupportKHR(physicalDevice, queueFamilyIndex, surface, |
| 12742 | pSupported); |
| 12743 | |
| 12744 | if (result == VK_SUCCESS) { |
Mark Lobodzinski | 9e02344 | 2016-11-23 11:28:30 -0700 | [diff] [blame] | 12745 | surface_state->gpu_queue_support[{physicalDevice, queueFamilyIndex}] = (*pSupported != 0); |
Chris Forbes | 97058a6 | 2016-10-12 08:55:03 +1300 | [diff] [blame] | 12746 | } |
| 12747 | |
| 12748 | return result; |
| 12749 | } |
| 12750 | |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12751 | |
| 12752 | VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfacePresentModesKHR(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, |
| 12753 | uint32_t *pPresentModeCount, |
| 12754 | VkPresentModeKHR *pPresentModes) { |
| 12755 | bool skip_call = false; |
| 12756 | auto instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| 12757 | std::unique_lock<std::mutex> lock(global_lock); |
| 12758 | // TODO: this isn't quite right. available modes may differ by surface AND physical device. |
| 12759 | auto physical_device_state = getPhysicalDeviceState(instance_data, physicalDevice); |
| 12760 | auto & call_state = physical_device_state->vkGetPhysicalDeviceSurfacePresentModesKHRState; |
| 12761 | |
| 12762 | if (pPresentModes) { |
| 12763 | // Compare the preliminary value of *pPresentModeCount with the value this time: |
| 12764 | auto prev_mode_count = (uint32_t) physical_device_state->present_modes.size(); |
| 12765 | switch (call_state) { |
| 12766 | case UNCALLED: |
| 12767 | skip_call |= log_msg( |
| 12768 | instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 12769 | reinterpret_cast<uint64_t>(physicalDevice), __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", |
| 12770 | "vkGetPhysicalDeviceSurfacePresentModesKHR() called with non-NULL pPresentModeCount; but no prior positive " |
| 12771 | "value has been seen for pPresentModeCount."); |
| 12772 | break; |
| 12773 | default: |
| 12774 | // both query count and query details |
| 12775 | if (*pPresentModeCount != prev_mode_count) { |
| 12776 | skip_call |= log_msg( |
| 12777 | instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 12778 | reinterpret_cast<uint64_t>(physicalDevice), __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| 12779 | "vkGetPhysicalDeviceSurfacePresentModesKHR() called with *pPresentModeCount (%u) that differs from the value " |
| 12780 | "(%u) that was returned when pPresentModes was NULL.", |
| 12781 | *pPresentModeCount, prev_mode_count); |
| 12782 | } |
| 12783 | break; |
| 12784 | } |
| 12785 | } |
| 12786 | lock.unlock(); |
| 12787 | |
| 12788 | if (skip_call) |
| 12789 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12790 | |
| 12791 | auto result = instance_data->dispatch_table.GetPhysicalDeviceSurfacePresentModesKHR(physicalDevice, surface, pPresentModeCount, pPresentModes); |
| 12792 | |
| 12793 | if (result == VK_SUCCESS || result == VK_INCOMPLETE) { |
| 12794 | |
| 12795 | lock.lock(); |
| 12796 | |
| 12797 | if (*pPresentModeCount) { |
| 12798 | if (call_state < QUERY_COUNT) call_state = QUERY_COUNT; |
| 12799 | if (*pPresentModeCount > physical_device_state->present_modes.size()) |
| 12800 | physical_device_state->present_modes.resize(*pPresentModeCount); |
| 12801 | } |
| 12802 | if (pPresentModes) { |
| 12803 | if (call_state < QUERY_DETAILS) call_state = QUERY_DETAILS; |
| 12804 | for (uint32_t i = 0; i < *pPresentModeCount; i++) { |
| 12805 | physical_device_state->present_modes[i] = pPresentModes[i]; |
| 12806 | } |
| 12807 | } |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 12808 | } |
| 12809 | |
| 12810 | return result; |
| 12811 | } |
| 12812 | |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 12813 | |
| 12814 | VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceSurfaceFormatsKHR(VkPhysicalDevice physicalDevice, VkSurfaceKHR surface, |
| 12815 | uint32_t *pSurfaceFormatCount, |
| 12816 | VkSurfaceFormatKHR *pSurfaceFormats) { |
| 12817 | bool skip_call = false; |
| 12818 | auto instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| 12819 | std::unique_lock<std::mutex> lock(global_lock); |
| 12820 | auto physical_device_state = getPhysicalDeviceState(instance_data, physicalDevice); |
| 12821 | auto & call_state = physical_device_state->vkGetPhysicalDeviceSurfaceFormatsKHRState; |
| 12822 | |
| 12823 | if (pSurfaceFormats) { |
| 12824 | auto prev_format_count = (uint32_t) physical_device_state->surface_formats.size(); |
| 12825 | |
| 12826 | switch (call_state) { |
| 12827 | case UNCALLED: |
| 12828 | // Since we haven't recorded a preliminary value of *pSurfaceFormatCount, that likely means that the application didn't |
| 12829 | // previously call this function with a NULL value of pSurfaceFormats: |
| 12830 | skip_call |= log_msg( |
| 12831 | instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 12832 | reinterpret_cast<uint64_t>(physicalDevice), __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", |
| 12833 | "vkGetPhysicalDeviceSurfaceFormatsKHR() called with non-NULL pSurfaceFormatCount; but no prior positive " |
| 12834 | "value has been seen for pSurfaceFormats."); |
| 12835 | break; |
| 12836 | default: |
| 12837 | if (prev_format_count != *pSurfaceFormatCount) { |
| 12838 | skip_call |= log_msg( |
| 12839 | instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, |
| 12840 | reinterpret_cast<uint64_t>(physicalDevice), __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", |
| 12841 | "vkGetPhysicalDeviceSurfaceFormatsKHR() called with non-NULL pSurfaceFormatCount, and with pSurfaceFormats set to " |
| 12842 | "a value (%u) that is greater than the value (%u) that was returned when pSurfaceFormatCount was NULL.", |
| 12843 | *pSurfaceFormatCount, prev_format_count); |
| 12844 | } |
| 12845 | break; |
| 12846 | } |
| 12847 | } |
| 12848 | lock.unlock(); |
| 12849 | |
| 12850 | if (skip_call) |
| 12851 | return VK_ERROR_VALIDATION_FAILED_EXT; |
| 12852 | |
| 12853 | // Call down the call chain: |
| 12854 | auto result = instance_data->dispatch_table.GetPhysicalDeviceSurfaceFormatsKHR(physicalDevice, surface, pSurfaceFormatCount, |
| 12855 | pSurfaceFormats); |
| 12856 | |
| 12857 | if (result == VK_SUCCESS || result == VK_INCOMPLETE) { |
| 12858 | |
| 12859 | lock.lock(); |
| 12860 | |
| 12861 | if (*pSurfaceFormatCount) { |
| 12862 | if (call_state < QUERY_COUNT) call_state = QUERY_COUNT; |
| 12863 | if (*pSurfaceFormatCount > physical_device_state->surface_formats.size()) |
| 12864 | physical_device_state->surface_formats.resize(*pSurfaceFormatCount); |
| 12865 | } |
| 12866 | if (pSurfaceFormats) { |
| 12867 | if (call_state < QUERY_DETAILS) call_state = QUERY_DETAILS; |
| 12868 | for (uint32_t i = 0; i < *pSurfaceFormatCount; i++) { |
| 12869 | physical_device_state->surface_formats[i] = pSurfaceFormats[i]; |
| 12870 | } |
| 12871 | } |
| 12872 | } |
| 12873 | return result; |
| 12874 | } |
| 12875 | |
| 12876 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12877 | VKAPI_ATTR VkResult VKAPI_CALL |
| 12878 | CreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, |
| 12879 | const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12880 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 12881 | VkResult res = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12882 | if (VK_SUCCESS == res) { |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12883 | std::lock_guard<std::mutex> lock(global_lock); |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12884 | res = layer_create_msg_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12885 | } |
| 12886 | return res; |
| 12887 | } |
| 12888 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12889 | VKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, |
| 12890 | VkDebugReportCallbackEXT msgCallback, |
| 12891 | const VkAllocationCallbacks *pAllocator) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12892 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 12893 | instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); |
Jeremy Hayes | da8797f | 2016-04-13 16:20:24 -0600 | [diff] [blame] | 12894 | std::lock_guard<std::mutex> lock(global_lock); |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12895 | layer_destroy_msg_callback(instance_data->report_data, msgCallback, pAllocator); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12896 | } |
| 12897 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12898 | VKAPI_ATTR void VKAPI_CALL |
| 12899 | DebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, |
| 12900 | size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12901 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 12902 | instance_data->dispatch_table.DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12903 | } |
| 12904 | |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 12905 | VKAPI_ATTR VkResult VKAPI_CALL |
| 12906 | EnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { |
| 12907 | return util_GetLayerProperties(1, &global_layer, pCount, pProperties); |
| 12908 | } |
| 12909 | |
| 12910 | VKAPI_ATTR VkResult VKAPI_CALL |
| 12911 | EnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { |
| 12912 | return util_GetLayerProperties(1, &global_layer, pCount, pProperties); |
| 12913 | } |
| 12914 | |
| 12915 | VKAPI_ATTR VkResult VKAPI_CALL |
| 12916 | EnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { |
| 12917 | if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) |
| 12918 | return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); |
| 12919 | |
| 12920 | return VK_ERROR_LAYER_NOT_PRESENT; |
| 12921 | } |
| 12922 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12923 | VKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, |
| 12924 | const char *pLayerName, uint32_t *pCount, |
| 12925 | VkExtensionProperties *pProperties) { |
Chia-I Wu | 3ee8023 | 2016-05-06 11:38:37 +0800 | [diff] [blame] | 12926 | if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 12927 | return util_GetExtensionProperties(0, NULL, pCount, pProperties); |
Chia-I Wu | 3ee8023 | 2016-05-06 11:38:37 +0800 | [diff] [blame] | 12928 | |
| 12929 | assert(physicalDevice); |
| 12930 | |
Chris Forbes | 6572485 | 2016-10-03 19:54:31 +1300 | [diff] [blame] | 12931 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); |
| 12932 | return instance_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 12933 | } |
| 12934 | |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 12935 | static PFN_vkVoidFunction |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12936 | intercept_core_instance_command(const char *name); |
| 12937 | |
| 12938 | static PFN_vkVoidFunction |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 12939 | intercept_core_device_command(const char *name); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12940 | |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 12941 | static PFN_vkVoidFunction |
| 12942 | intercept_khr_swapchain_command(const char *name, VkDevice dev); |
| 12943 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 12944 | static PFN_vkVoidFunction |
| 12945 | intercept_khr_surface_command(const char *name, VkInstance instance); |
| 12946 | |
Mark Young | 3938987 | 2017-01-19 21:10:49 -0700 | [diff] [blame] | 12947 | static PFN_vkVoidFunction |
| 12948 | intercept_extension_instance_commands(const char *name, VkInstance instance); |
| 12949 | |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 12950 | VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { |
| 12951 | PFN_vkVoidFunction proc = intercept_core_device_command(funcName); |
| 12952 | if (proc) |
| 12953 | return proc; |
| 12954 | |
| 12955 | assert(dev); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12956 | |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 12957 | proc = intercept_khr_swapchain_command(funcName, dev); |
| 12958 | if (proc) |
| 12959 | return proc; |
| 12960 | |
Chris Forbes | fb06dd6 | 2016-10-03 19:14:25 +1300 | [diff] [blame] | 12961 | layer_data *dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12962 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12963 | auto &table = dev_data->dispatch_table; |
| 12964 | if (!table.GetDeviceProcAddr) |
| 12965 | return nullptr; |
| 12966 | return table.GetDeviceProcAddr(dev, funcName); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12967 | } |
| 12968 | |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 12969 | VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12970 | PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); |
Chia-I Wu | dc6e5a2 | 2016-05-06 12:04:23 +0800 | [diff] [blame] | 12971 | if (!proc) |
| 12972 | proc = intercept_core_device_command(funcName); |
| 12973 | if (!proc) |
| 12974 | proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 12975 | if (!proc) |
| 12976 | proc = intercept_khr_surface_command(funcName, instance); |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12977 | if (proc) |
| 12978 | return proc; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12979 | |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12980 | assert(instance); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12981 | |
Chris Forbes | 3dd8374 | 2016-10-03 19:35:49 +1300 | [diff] [blame] | 12982 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
| 12983 | proc = debug_report_get_instance_proc_addr(instance_data->report_data, funcName); |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 12984 | if (proc) |
| 12985 | return proc; |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12986 | |
Mark Young | 3938987 | 2017-01-19 21:10:49 -0700 | [diff] [blame] | 12987 | proc = intercept_extension_instance_commands(funcName, instance); |
| 12988 | if (proc) |
| 12989 | return proc; |
| 12990 | |
Chris Forbes | aaa9c28 | 2016-10-03 20:01:14 +1300 | [diff] [blame] | 12991 | auto &table = instance_data->dispatch_table; |
| 12992 | if (!table.GetInstanceProcAddr) |
| 12993 | return nullptr; |
| 12994 | return table.GetInstanceProcAddr(instance, funcName); |
Tobin Ehlis | c96f806 | 2016-03-09 16:12:48 -0700 | [diff] [blame] | 12995 | } |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 12996 | |
Mark Young | 3938987 | 2017-01-19 21:10:49 -0700 | [diff] [blame] | 12997 | VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) { |
| 12998 | assert(instance); |
| 12999 | |
| 13000 | instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
| 13001 | |
| 13002 | auto &table = instance_data->dispatch_table; |
| 13003 | if (!table.GetPhysicalDeviceProcAddr) |
| 13004 | return nullptr; |
| 13005 | return table.GetPhysicalDeviceProcAddr(instance, funcName); |
| 13006 | } |
| 13007 | |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 13008 | static PFN_vkVoidFunction |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 13009 | intercept_core_instance_command(const char *name) { |
| 13010 | static const struct { |
| 13011 | const char *name; |
| 13012 | PFN_vkVoidFunction proc; |
| 13013 | } core_instance_commands[] = { |
| 13014 | { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, |
Mark Young | 3938987 | 2017-01-19 21:10:49 -0700 | [diff] [blame] | 13015 | { "vk_layerGetPhysicalDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceProcAddr) }, |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 13016 | { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, |
| 13017 | { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, |
| 13018 | { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, |
Mark Lobodzinski | 5169543 | 2016-06-27 16:47:24 -0600 | [diff] [blame] | 13019 | { "vkEnumeratePhysicalDevices", reinterpret_cast<PFN_vkVoidFunction>(EnumeratePhysicalDevices) }, |
Mark Lobodzinski | 9b79d7a | 2016-06-28 10:04:01 -0600 | [diff] [blame] | 13020 | { "vkGetPhysicalDeviceQueueFamilyProperties", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceQueueFamilyProperties) }, |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 13021 | { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13022 | { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, |
| 13023 | { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, |
| 13024 | { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, |
Chia-I Wu | 8be4b3b | 2016-05-06 11:55:53 +0800 | [diff] [blame] | 13025 | { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, |
| 13026 | }; |
| 13027 | |
| 13028 | for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { |
| 13029 | if (!strcmp(core_instance_commands[i].name, name)) |
| 13030 | return core_instance_commands[i].proc; |
| 13031 | } |
| 13032 | |
| 13033 | return nullptr; |
| 13034 | } |
| 13035 | |
| 13036 | static PFN_vkVoidFunction |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 13037 | intercept_core_device_command(const char *name) { |
| 13038 | static const struct { |
| 13039 | const char *name; |
| 13040 | PFN_vkVoidFunction proc; |
| 13041 | } core_device_commands[] = { |
Tobin Ehlis | d9867fc | 2016-05-12 16:57:14 -0600 | [diff] [blame] | 13042 | {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, |
| 13043 | {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, |
| 13044 | {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, |
| 13045 | {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, |
| 13046 | {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, |
| 13047 | {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, |
| 13048 | {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, |
| 13049 | {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, |
| 13050 | {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, |
| 13051 | {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, |
| 13052 | {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, |
| 13053 | {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, |
| 13054 | {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, |
| 13055 | {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, |
| 13056 | {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, |
| 13057 | {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, |
| 13058 | {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, |
| 13059 | {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, |
| 13060 | {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, |
| 13061 | {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, |
| 13062 | {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, |
| 13063 | {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, |
| 13064 | {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, |
| 13065 | {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, |
| 13066 | {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, |
| 13067 | {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, |
| 13068 | {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, |
| 13069 | {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, |
| 13070 | {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, |
| 13071 | {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, |
| 13072 | {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, |
| 13073 | {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, |
| 13074 | {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, |
| 13075 | {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, |
| 13076 | {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, |
| 13077 | {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, |
| 13078 | {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, |
| 13079 | {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, |
| 13080 | {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, |
| 13081 | {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, |
| 13082 | {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, |
| 13083 | {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, |
| 13084 | {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, |
| 13085 | {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, |
| 13086 | {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, |
| 13087 | {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, |
| 13088 | {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, |
| 13089 | {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, |
| 13090 | {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, |
| 13091 | {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, |
| 13092 | {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, |
| 13093 | {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, |
| 13094 | {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, |
| 13095 | {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, |
| 13096 | {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, |
| 13097 | {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, |
| 13098 | {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, |
| 13099 | {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, |
| 13100 | {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, |
| 13101 | {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, |
| 13102 | {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, |
| 13103 | {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, |
| 13104 | {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, |
| 13105 | {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, |
| 13106 | {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, |
| 13107 | {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, |
| 13108 | {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, |
| 13109 | {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, |
| 13110 | {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, |
| 13111 | {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, |
| 13112 | {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, |
| 13113 | {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, |
| 13114 | {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, |
| 13115 | {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, |
| 13116 | {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, |
| 13117 | {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, |
| 13118 | {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, |
| 13119 | {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, |
| 13120 | {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, |
| 13121 | {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, |
| 13122 | {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, |
| 13123 | {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, |
| 13124 | {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, |
| 13125 | {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, |
| 13126 | {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, |
| 13127 | {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, |
| 13128 | {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, |
| 13129 | {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, |
| 13130 | {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, |
| 13131 | {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, |
| 13132 | {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, |
| 13133 | {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, |
| 13134 | {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, |
| 13135 | {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, |
| 13136 | {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, |
| 13137 | {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, |
| 13138 | {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, |
| 13139 | {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, |
| 13140 | {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, |
| 13141 | {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, |
| 13142 | {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, |
| 13143 | {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, |
| 13144 | {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, |
| 13145 | {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, |
| 13146 | {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, |
| 13147 | {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, |
| 13148 | {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, |
| 13149 | {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, |
| 13150 | {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, |
| 13151 | {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, |
| 13152 | {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, |
| 13153 | {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, |
| 13154 | {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, |
| 13155 | {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, |
| 13156 | {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, |
| 13157 | {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, |
Chia-I Wu | d518623 | 2016-05-06 11:44:32 +0800 | [diff] [blame] | 13158 | }; |
| 13159 | |
| 13160 | for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { |
| 13161 | if (!strcmp(core_device_commands[i].name, name)) |
| 13162 | return core_device_commands[i].proc; |
| 13163 | } |
| 13164 | |
| 13165 | return nullptr; |
| 13166 | } |
| 13167 | |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 13168 | static PFN_vkVoidFunction |
| 13169 | intercept_khr_swapchain_command(const char *name, VkDevice dev) { |
| 13170 | static const struct { |
| 13171 | const char *name; |
| 13172 | PFN_vkVoidFunction proc; |
| 13173 | } khr_swapchain_commands[] = { |
| 13174 | { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, |
| 13175 | { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, |
| 13176 | { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, |
| 13177 | { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, |
| 13178 | { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, |
| 13179 | }; |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 13180 | layer_data *dev_data = nullptr; |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 13181 | |
Chia-I Wu | dc6e5a2 | 2016-05-06 12:04:23 +0800 | [diff] [blame] | 13182 | if (dev) { |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 13183 | dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); |
Chia-I Wu | dc6e5a2 | 2016-05-06 12:04:23 +0800 | [diff] [blame] | 13184 | if (!dev_data->device_extensions.wsi_enabled) |
| 13185 | return nullptr; |
| 13186 | } |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 13187 | |
| 13188 | for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { |
| 13189 | if (!strcmp(khr_swapchain_commands[i].name, name)) |
| 13190 | return khr_swapchain_commands[i].proc; |
| 13191 | } |
| 13192 | |
Mark Young | 1a86744 | 2016-07-01 15:18:27 -0600 | [diff] [blame] | 13193 | if (dev_data) { |
| 13194 | if (!dev_data->device_extensions.wsi_display_swapchain_enabled) |
| 13195 | return nullptr; |
| 13196 | } |
| 13197 | |
| 13198 | if (!strcmp("vkCreateSharedSwapchainsKHR", name)) |
| 13199 | return reinterpret_cast<PFN_vkVoidFunction>(CreateSharedSwapchainsKHR); |
| 13200 | |
Chia-I Wu | 0730d52 | 2016-05-06 11:51:11 +0800 | [diff] [blame] | 13201 | return nullptr; |
| 13202 | } |
| 13203 | |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 13204 | static PFN_vkVoidFunction |
| 13205 | intercept_khr_surface_command(const char *name, VkInstance instance) { |
| 13206 | static const struct { |
| 13207 | const char *name; |
| 13208 | PFN_vkVoidFunction proc; |
| 13209 | bool instance_layer_data::*enable; |
| 13210 | } khr_surface_commands[] = { |
| 13211 | #ifdef VK_USE_PLATFORM_ANDROID_KHR |
| 13212 | {"vkCreateAndroidSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateAndroidSurfaceKHR), |
| 13213 | &instance_layer_data::androidSurfaceExtensionEnabled}, |
| 13214 | #endif // VK_USE_PLATFORM_ANDROID_KHR |
| 13215 | #ifdef VK_USE_PLATFORM_MIR_KHR |
| 13216 | {"vkCreateMirSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateMirSurfaceKHR), |
| 13217 | &instance_layer_data::mirSurfaceExtensionEnabled}, |
| 13218 | #endif // VK_USE_PLATFORM_MIR_KHR |
| 13219 | #ifdef VK_USE_PLATFORM_WAYLAND_KHR |
| 13220 | {"vkCreateWaylandSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateWaylandSurfaceKHR), |
| 13221 | &instance_layer_data::waylandSurfaceExtensionEnabled}, |
| 13222 | #endif // VK_USE_PLATFORM_WAYLAND_KHR |
| 13223 | #ifdef VK_USE_PLATFORM_WIN32_KHR |
| 13224 | {"vkCreateWin32SurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateWin32SurfaceKHR), |
| 13225 | &instance_layer_data::win32SurfaceExtensionEnabled}, |
| 13226 | #endif // VK_USE_PLATFORM_WIN32_KHR |
| 13227 | #ifdef VK_USE_PLATFORM_XCB_KHR |
| 13228 | {"vkCreateXcbSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateXcbSurfaceKHR), |
| 13229 | &instance_layer_data::xcbSurfaceExtensionEnabled}, |
| 13230 | #endif // VK_USE_PLATFORM_XCB_KHR |
| 13231 | #ifdef VK_USE_PLATFORM_XLIB_KHR |
| 13232 | {"vkCreateXlibSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateXlibSurfaceKHR), |
| 13233 | &instance_layer_data::xlibSurfaceExtensionEnabled}, |
| 13234 | #endif // VK_USE_PLATFORM_XLIB_KHR |
Norbert Nopper | 1dec9a5 | 2016-11-25 07:55:13 +0100 | [diff] [blame] | 13235 | { "vkCreateDisplayPlaneSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateDisplayPlaneSurfaceKHR), |
| 13236 | &instance_layer_data::displayExtensionEnabled}, |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 13237 | {"vkDestroySurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySurfaceKHR), |
| 13238 | &instance_layer_data::surfaceExtensionEnabled}, |
Chris Forbes | 6c2bc8f | 2016-10-11 15:57:55 +1300 | [diff] [blame] | 13239 | {"vkGetPhysicalDeviceSurfaceCapabilitiesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceSurfaceCapabilitiesKHR), |
| 13240 | &instance_layer_data::surfaceExtensionEnabled}, |
Chris Forbes | 97058a6 | 2016-10-12 08:55:03 +1300 | [diff] [blame] | 13241 | {"vkGetPhysicalDeviceSurfaceSupportKHR", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceSurfaceSupportKHR), |
| 13242 | &instance_layer_data::surfaceExtensionEnabled}, |
Chris Forbes | ad22fc3 | 2016-11-25 13:17:36 +1300 | [diff] [blame] | 13243 | {"vkGetPhysicalDeviceSurfacePresentModesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceSurfacePresentModesKHR), |
| 13244 | &instance_layer_data::surfaceExtensionEnabled}, |
Chris Forbes | 11ab171 | 2016-11-25 16:37:41 +1300 | [diff] [blame] | 13245 | {"vkGetPhysicalDeviceSurfaceFormatsKHR", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceSurfaceFormatsKHR), |
| 13246 | &instance_layer_data::surfaceExtensionEnabled}, |
Chris Forbes | f9f8783 | 2016-10-04 17:42:54 +1300 | [diff] [blame] | 13247 | }; |
| 13248 | |
| 13249 | instance_layer_data *instance_data = nullptr; |
| 13250 | if (instance) { |
| 13251 | instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); |
| 13252 | } |
| 13253 | |
| 13254 | for (size_t i = 0; i < ARRAY_SIZE(khr_surface_commands); i++) { |
| 13255 | if (!strcmp(khr_surface_commands[i].name, name)) { |
| 13256 | if (instance_data && !(instance_data->*(khr_surface_commands[i].enable))) |
| 13257 | return nullptr; |
| 13258 | return khr_surface_commands[i].proc; |
| 13259 | } |
| 13260 | } |
| 13261 | |
| 13262 | return nullptr; |
| 13263 | } |
| 13264 | |
Mark Young | 3938987 | 2017-01-19 21:10:49 -0700 | [diff] [blame] | 13265 | static PFN_vkVoidFunction |
| 13266 | intercept_extension_instance_commands(const char *name, VkInstance instance) { |
| 13267 | return NULL; |
| 13268 | } |
| 13269 | |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13270 | } // namespace core_validation |
| 13271 | |
| 13272 | // vk_layer_logging.h expects these to be defined |
| 13273 | |
| 13274 | VKAPI_ATTR VkResult VKAPI_CALL |
| 13275 | vkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, |
| 13276 | const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 13277 | return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13278 | } |
| 13279 | |
| 13280 | VKAPI_ATTR void VKAPI_CALL |
| 13281 | vkDestroyDebugReportCallbackEXT(VkInstance instance, |
| 13282 | VkDebugReportCallbackEXT msgCallback, |
| 13283 | const VkAllocationCallbacks *pAllocator) { |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 13284 | core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13285 | } |
| 13286 | |
| 13287 | VKAPI_ATTR void VKAPI_CALL |
| 13288 | vkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, |
| 13289 | size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 13290 | core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13291 | } |
| 13292 | |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13293 | // loader-layer interface v0, just wrappers since there is only a layer |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13294 | |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 13295 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 13296 | vkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13297 | return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 13298 | } |
| 13299 | |
| 13300 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 13301 | vkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13302 | return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 13303 | } |
| 13304 | |
| 13305 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL |
| 13306 | vkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13307 | // the layer command handles VK_NULL_HANDLE just fine internally |
| 13308 | assert(physicalDevice == VK_NULL_HANDLE); |
| 13309 | return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13310 | } |
| 13311 | |
| 13312 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, |
| 13313 | const char *pLayerName, uint32_t *pCount, |
| 13314 | VkExtensionProperties *pProperties) { |
Chia-I Wu | b02600c | 2016-05-20 07:11:22 +0800 | [diff] [blame] | 13315 | // the layer command handles VK_NULL_HANDLE just fine internally |
| 13316 | assert(physicalDevice == VK_NULL_HANDLE); |
Chia-I Wu | 3ee8023 | 2016-05-06 11:38:37 +0800 | [diff] [blame] | 13317 | return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13318 | } |
| 13319 | |
| 13320 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 13321 | return core_validation::GetDeviceProcAddr(dev, funcName); |
Chia-I Wu | a67f684 | 2016-05-06 11:20:20 +0800 | [diff] [blame] | 13322 | } |
| 13323 | |
| 13324 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { |
Chia-I Wu | 629d7cd | 2016-05-06 11:32:54 +0800 | [diff] [blame] | 13325 | return core_validation::GetInstanceProcAddr(instance, funcName); |
Chia-I Wu | dbe5424 | 2016-05-06 11:17:16 +0800 | [diff] [blame] | 13326 | } |
Mark Young | 3938987 | 2017-01-19 21:10:49 -0700 | [diff] [blame] | 13327 | |
| 13328 | VK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vk_layerGetPhysicalDeviceProcAddr(VkInstance instance, const char *funcName) { |
| 13329 | return core_validation::GetPhysicalDeviceProcAddr(instance, funcName); |
| 13330 | } |
| 13331 | |
| 13332 | VK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkNegotiateLoaderLayerInterfaceVersion(VkNegotiateLayerInterface *pVersionStruct) { |
| 13333 | assert(pVersionStruct != NULL); |
| 13334 | assert(pVersionStruct->sType == LAYER_NEGOTIATE_INTERFACE_STRUCT); |
| 13335 | |
| 13336 | // Fill in the function pointers if our version is at least capable of having the structure contain them. |
| 13337 | if (pVersionStruct->loaderLayerInterfaceVersion >= 2) { |
| 13338 | pVersionStruct->pfnGetInstanceProcAddr = vkGetInstanceProcAddr; |
| 13339 | pVersionStruct->pfnGetDeviceProcAddr = vkGetDeviceProcAddr; |
| 13340 | pVersionStruct->pfnGetPhysicalDeviceProcAddr = vk_layerGetPhysicalDeviceProcAddr; |
| 13341 | } |
| 13342 | |
| 13343 | if (pVersionStruct->loaderLayerInterfaceVersion < CURRENT_LOADER_LAYER_INTERFACE_VERSION) { |
| 13344 | core_validation::loader_layer_if_version = pVersionStruct->loaderLayerInterfaceVersion; |
| 13345 | } else if (pVersionStruct->loaderLayerInterfaceVersion > CURRENT_LOADER_LAYER_INTERFACE_VERSION) { |
| 13346 | pVersionStruct->loaderLayerInterfaceVersion = CURRENT_LOADER_LAYER_INTERFACE_VERSION; |
| 13347 | } |
| 13348 | |
| 13349 | return VK_SUCCESS; |
| 13350 | } |
| 13351 | |