blob: a734b774bc47f71bb8496591be07146309a2a3a2 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900333 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
334 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700335 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700336 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900338}
339
Jiyong Park40782d02020-07-24 19:17:43 +0900340TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
342 const string expected_stderr =
343 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344 CaptureStderr();
345 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900347}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348
Jiyong Park40782d02020-07-24 19:17:43 +0900349TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700350 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900351 const string expected_stderr =
352 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
369 const string expected_stderr =
370 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
371 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800374}
375
Devin Moore2f2077a2020-08-28 11:27:53 -0700376TEST_P(AidlTest, AcceptNullableList) {
377 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
378 const string expected_stderr = "";
379 CaptureStderr();
380 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 const string method = "package a; interface IFoo { void f(int a, int a); }";
386 const string expected_stderr =
387 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
388 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700391}
392
Jeongik Cha13066da2020-08-06 15:43:19 +0900393TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
394 const string method = "package a; parcelable Foo { int a; String a; }";
395 const string expected_stderr =
396 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
397 CaptureStderr();
398 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
400}
401
Jooyung Hand902a972020-10-23 17:32:44 +0900402TEST_P(AidlTest, RejectsRepeatedAnnotations) {
403 const string method = R"(@Hide @Hide parcelable Foo {})";
404 const string expected_stderr =
405 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
406 "Foo.aidl:1.1-6\n";
407 CaptureStderr();
408 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
409 EXPECT_EQ(expected_stderr, GetCapturedStderr());
410}
411
Devin Moore7b8d5c92020-03-17 14:14:08 -0700412TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700413 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
414 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
415 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100418}
419
Devin Moore7b8d5c92020-03-17 14:14:08 -0700420TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700421 AidlError error;
422 const string method = "package a; @nullable interface IFoo { int f(); }";
423 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800424 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900425 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700426 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700427 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700428 EXPECT_EQ(expected_stderr, GetCapturedStderr());
429 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800430}
431
Devin Moore7b8d5c92020-03-17 14:14:08 -0700432TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700433 AidlError error;
434 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
435 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800436 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900437 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700438 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700439 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
441 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800442}
443
Devin Moore7b8d5c92020-03-17 14:14:08 -0700444TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700445 AidlError error;
446 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
447 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000448 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900449 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900450 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700451 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000452 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700453 EXPECT_EQ(expected_stderr, GetCapturedStderr());
454 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800455}
456
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700458 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000459 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700460 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000461 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900462 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700463 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700464 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000465 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
467 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800468}
469
Jiyong Park40782d02020-07-24 19:17:43 +0900470TEST_P(AidlTest, ParsesNonNullableAnnotation) {
471 auto parse_result =
472 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
473 ASSERT_NE(nullptr, parse_result);
474 const AidlInterface* interface = parse_result->AsInterface();
475 ASSERT_NE(nullptr, interface);
476 ASSERT_FALSE(interface->GetMethods().empty());
477 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
478}
479
Devin Moore7b8d5c92020-03-17 14:14:08 -0700480TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900481 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
482 typenames_, GetLanguage());
483 ASSERT_NE(nullptr, parse_result);
484 const AidlInterface* interface = parse_result->AsInterface();
485 ASSERT_NE(nullptr, interface);
486 ASSERT_FALSE(interface->GetMethods().empty());
487 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
488}
489
490TEST_P(AidlTest, ParsesNonUtf8Annotations) {
491 auto parse_result =
492 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
493 ASSERT_NE(nullptr, parse_result);
494 const AidlInterface* interface = parse_result->AsInterface();
495 ASSERT_NE(nullptr, interface);
496 ASSERT_FALSE(interface->GetMethods().empty());
497 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800498}
499
Devin Moore7b8d5c92020-03-17 14:14:08 -0700500TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900501 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
502 typenames_, GetLanguage());
503 ASSERT_NE(nullptr, parse_result);
504 const AidlInterface* interface = parse_result->AsInterface();
505 ASSERT_NE(nullptr, interface);
506 ASSERT_FALSE(interface->GetMethods().empty());
507 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800508}
509
Devin Moore7b8d5c92020-03-17 14:14:08 -0700510TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700511 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700512 const string expected_stderr =
513 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
514 "\"vintf\"'\n"
515 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
516 "--structured\n";
517 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700518 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700519 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522}
523
Devin Moore7b8d5c92020-03-17 14:14:08 -0700524TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700526 const string expected_stderr =
527 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
528 "--structured\n";
529 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700530 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700531 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534}
535
Devin Moore7b8d5c92020-03-17 14:14:08 -0700536TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700537 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700538 const string expected_stderr =
539 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
540 "\"vintf\"'\n";
541 CaptureStderr();
542 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700543 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546}
547
Devin Moore7b8d5c92020-03-17 14:14:08 -0700548TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700549 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700550 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
551 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700552 ASSERT_EQ(AidlError::OK, error);
553 ASSERT_NE(nullptr, parse_result);
554 const AidlInterface* interface = parse_result->AsInterface();
555 ASSERT_NE(nullptr, interface);
556 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700557}
558
Jeongik Cha64783ed2019-06-07 18:30:54 +0900559TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
560 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900561 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
562 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900563 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700564 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900565 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900566 "a/Foo.aidl",
567 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900568
569 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900570 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700571 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900572 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700573 "Parcelable must be defined in AIDL directly.\n";
574 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900575 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700577
578 CaptureStderr();
579 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900581}
582
Jooyung Han90345002020-10-23 15:28:53 +0900583TEST_F(AidlTest, ParsesJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900584 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
Jooyung Han90345002020-10-23 15:28:53 +0900585 @JavaDerive(toString=true) parcelable IFoo { int a; float b; })");
Jiyong Park43113fb2020-07-20 16:26:19 +0900586 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
587 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
588
589 string java_out;
590 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
591 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
592
593 // Other backends shouldn't be bothered
594 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
595 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
596
597 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
598 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
599}
600
Jooyung Han90345002020-10-23 15:28:53 +0900601TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900602 {
Jooyung Han90345002020-10-23 15:28:53 +0900603 io_delegate_.SetFileContents("a/Foo.aidl",
604 "package a; @JavaDerive(blah=true) parcelable Foo{}");
605 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
606 CaptureStderr();
607 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
608 const std::string expected_stderr =
609 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
610 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
611 }
612
613 {
614 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900615 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
616 CaptureStderr();
617 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
618 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900619 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900620 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
621 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900622 EXPECT_EQ(expected_stderr, GetCapturedStderr());
623 }
624
625 {
Jooyung Han90345002020-10-23 15:28:53 +0900626 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900627 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
628 CaptureStderr();
629 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
630 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900631 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900632 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
633 EXPECT_EQ(expected_stderr, GetCapturedStderr());
634 }
635}
636
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900637TEST_P(AidlTest, ParseDescriptorAnnotation) {
638 AidlError error;
639 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
640 typenames_, GetLanguage(), &error, {"--structured"});
641 ASSERT_EQ(AidlError::OK, error);
642 ASSERT_NE(nullptr, parse_result);
643 const AidlInterface* interface = parse_result->AsInterface();
644 ASSERT_NE(nullptr, interface);
645 ASSERT_EQ("IBar", interface->GetDescriptor());
646}
647
Jiyong Park40782d02020-07-24 19:17:43 +0900648TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700649 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700650 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900651}
652
653TEST_P(AidlTest, AcceptsOnewayInterface) {
654 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700655 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700656}
Christopher Wileyef140932015-11-03 09:29:19 -0800657
Devin Moore7b8d5c92020-03-17 14:14:08 -0700658TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700659 const string oneway_method =
660 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700661 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100662}
663
Steven Moreland65297cc2020-04-20 20:17:36 -0700664TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
665 const string oneway_method =
666 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
667 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
668 ASSERT_NE(nullptr, defined);
669 const AidlInterface* iface = defined->AsInterface();
670 ASSERT_NE(nullptr, iface);
671
672 const auto& methods = iface->GetMethods();
673 ASSERT_EQ(1u, methods.size());
674 const auto& method = methods[0];
675 const AidlTypeSpecifier& ret_type = method->GetType();
676
677 // TODO(b/151102494): these annotations should be on the method
678 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
679 ASSERT_TRUE(ret_type.IsHide());
680}
681
Devin Moore7b8d5c92020-03-17 14:14:08 -0700682TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100683 string foo_interface =
684 "package a; /* foo */ interface IFoo {"
685 " /* i */ int i();"
686 " /* j */ @nullable String j();"
687 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
688
Devin Moore7b8d5c92020-03-17 14:14:08 -0700689 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100690 EXPECT_NE(nullptr, parse_result);
691 EXPECT_EQ("/* foo */", parse_result->GetComments());
692
693 const AidlInterface* interface = parse_result->AsInterface();
694 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
695 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
696 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
697}
698
Jooyung Han1a551d32020-10-05 15:37:26 +0900699TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
700 io_delegate_.SetFileContents("p/cpp_header.aidl",
701 R"(package p;
702 parcelable cpp_header cpp_header "bar/header";)");
703 import_paths_.emplace("");
704 const string input_path = "p/IFoo.aidl";
705 const string input = R"(package p;
706 import p.cpp_header;
707 interface IFoo {
708 // get bar
709 cpp_header get();
710 })";
711
712 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
713 EXPECT_NE(nullptr, parse_result);
714 const AidlInterface* interface = parse_result->AsInterface();
715 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
716}
717
Christopher Wileyef140932015-11-03 09:29:19 -0800718TEST_F(AidlTest, ParsesPreprocessedFile) {
719 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
720 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700721 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900722 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700723 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
724 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800725}
726
727TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
728 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
729 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900730
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700731 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900732 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700733 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
734 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800735}
736
Devin Moore7b8d5c92020-03-17 14:14:08 -0700737TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800738 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
739 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
740 "interface IBar {}");
741 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900742 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900743 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700744 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800745 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900746
Christopher Wiley41544372015-11-03 14:52:29 -0800747 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700748 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
749 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800750 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700751 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900752 ambiguous_type.Resolve(typenames_);
753 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800754}
755
Jiyong Park8f6ec462020-01-19 20:52:47 +0900756// Special case of PreferImportToPreprocessed. Imported type should be preferred
757// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700758TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900759 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
760 io_delegate_.SetFileContents("one/IBar.aidl",
761 "package one; "
762 "interface IBar {}");
763 preprocessed_files_.push_back("preprocessed");
764 import_paths_.emplace("");
765 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700766 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900767 EXPECT_NE(nullptr, parse_result);
768
769 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700770 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
771 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900772 // But if we request just "IBar" we should get our imported one.
773 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
774 ambiguous_type.Resolve(typenames_);
775 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
776}
777
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800778TEST_F(AidlTest, WritePreprocessedFile) {
779 io_delegate_.SetFileContents("p/Outer.aidl",
780 "package p; parcelable Outer.Inner;");
781 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
782 "interface IBar {}");
783
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900784 vector<string> args {
785 "aidl",
786 "--preprocess",
787 "preprocessed",
788 "p/Outer.aidl",
789 "one/IBar.aidl"};
790 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800791 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
792
793 string output;
794 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
795 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
796}
797
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900798TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100799 io_delegate_.SetFileContents(
800 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800801 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100802 "parcelable Rect {\n"
803 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800804 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100805 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800806 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100807 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100808 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
809 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100810 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900811 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900812 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100813 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900814
815 vector<string> args{"aidl", "Rect.aidl"};
816 Options options = Options::From(args);
817 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
818
819 string output;
820 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900821 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900822}
823
Devin Moore2f2077a2020-08-28 11:27:53 -0700824TEST_F(AidlTest, CppHeaderIncludes) {
825 io_delegate_.SetFileContents("IFoo.aidl",
826 "interface IFoo {\n"
827 " @nullable List<String> foo();\n"
828 "}");
829
830 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
831 Options options = Options::From(args);
832 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
833 std::vector<std::string> empty;
834 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
835 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
836 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
837
838 // Make sure the optional and String16.h includes are added
839 string output;
840 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
841 EXPECT_EQ(kExpectedCppHeaderOutput, output);
842}
843
Devin Moore7b8d5c92020-03-17 14:14:08 -0700844TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700845 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800846 io_delegate_.SetFileContents("p/Outer.aidl",
847 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900848 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700849 CaptureStderr();
850 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
851 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700852 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700853 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800854}
855
Devin Moore7b8d5c92020-03-17 14:14:08 -0700856TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800857 io_delegate_.SetFileContents("preprocessed",
858 "parcelable p.Outer.Inner;");
859 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900860 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700861 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800862 // TODO(wiley): This should actually return nullptr because we require
863 // the outer class name. However, for legacy reasons,
864 // this behavior must be maintained. b/17415692
865 EXPECT_NE(nullptr, parse_result);
866}
867
Christopher Wiley632801d2015-11-05 14:15:49 -0800868TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700869 const string expected_foo_stderr =
870 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
871 "Declared parcelables should be in their own file and/or cannot be used with --structured "
872 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700873 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
874
Christopher Wiley632801d2015-11-05 14:15:49 -0800875 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700876 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700877 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900878 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700879 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900880
Steven Morelande2c64b42018-09-18 15:06:37 -0700881 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900882 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700883 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900884 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700885 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700886
Devin Moore097a3ab2020-03-11 16:08:44 -0700887 const string expected_bar_stderr =
888 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
889 "Declared parcelables should be in their own file and/or cannot be used with --structured "
890 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700891 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
892
Jiyong Parkda8c6932019-08-12 19:56:08 +0900893 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700894 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700895 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900896 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700897 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700898 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700899 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700900 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700901 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800902}
903
Devin Moore7b8d5c92020-03-17 14:14:08 -0700904TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700905 const string expected_stderr =
906 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
907 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700908 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
909 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700910 AidlError error;
911 CaptureStderr();
912 EXPECT_EQ(
913 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700914 Parse("p/IFoo.aidl",
915 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700916 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700917 EXPECT_EQ(expected_stderr, GetCapturedStderr());
918 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700919}
920
Devin Moore7b8d5c92020-03-17 14:14:08 -0700921TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 AidlError error;
923 const string expected_stderr =
924 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
925 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900926 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
927 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700928 interface IFoo {
929 const String DUPLICATED = "d";
930 const int DUPLICATED = 1;
931 }
932 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700933 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700934 EXPECT_EQ(expected_stderr, GetCapturedStderr());
935 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700936}
937
Devin Moore7b8d5c92020-03-17 14:14:08 -0700938TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700939 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700940 const string expected_stderr =
941 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700942 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700943 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
944 R"(package p;
945 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700946 parcelable IBar {}
947 parcelable StructuredParcelable {}
948 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900949 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700950 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700951 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700952 // Parse success is important for clear error handling even if the cases aren't
953 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700954 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700955}
956
Devin Moore7b8d5c92020-03-17 14:14:08 -0700957TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700958 AidlError error;
959 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
960 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700961 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700962 EXPECT_EQ(expected_stderr, GetCapturedStderr());
963 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700964}
965
Steven Morelandf9e922f2020-07-08 21:15:27 +0000966TEST_P(AidlTest, FailOnEmptyListWithComma) {
967 AidlError error;
968 const string expected_stderr =
969 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
970 CaptureStderr();
971 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
972 typenames_, GetLanguage(), &error));
973 EXPECT_EQ(expected_stderr, GetCapturedStderr());
974 EXPECT_EQ(AidlError::PARSE_ERROR, error);
975}
976
Devin Moore7b8d5c92020-03-17 14:14:08 -0700977TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700978 AidlError error;
979 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -0700980 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700981 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900982 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
983 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700984 interface IFoo {
985 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
986 }
987 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700988 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700989 EXPECT_EQ(expected_stderr, GetCapturedStderr());
990 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -0700991}
992
Jiyong Park18132182020-06-08 20:24:40 +0900993TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
994 AidlError error;
995 const string expected_stderr =
996 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
997 "cpp_header (which can also be used as an identifier)\n";
998 CaptureStderr();
999 // Notice the trailing dot(.) in the name, which isn't a correct name
1000 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1001 GetLanguage(), &error));
1002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1003 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1004}
1005
1006TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1007 AidlError error;
1008 const string expected_stderr =
1009 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1010 "cpp_header (which can also be used as an identifier)\n";
1011 CaptureStderr();
1012 // Notice the trailing dot(.) in the package name
1013 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1014 GetLanguage(), &error));
1015 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1016 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1017}
1018
Devin Moore7b8d5c92020-03-17 14:14:08 -07001019TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001020 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001021 auto parse_result = Parse("p/IFoo.aidl",
1022 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001023 interface IFoo {
1024 const int POSITIVE_HEX_VALUE = 0xf5;
1025 }
1026 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001027 typenames_, GetLanguage(), &error);
1028 EXPECT_NE(nullptr, parse_result);
1029 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001030 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001031 const auto& cpp_constants = interface->GetConstantDeclarations();
1032 EXPECT_EQ((size_t)1, cpp_constants.size());
1033 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001034 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001035 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001036}
1037
Devin Moore7b8d5c92020-03-17 14:14:08 -07001038TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001039 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001040 auto parse_result = Parse("p/IFoo.aidl",
1041 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001042 interface IFoo {
1043 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1044 }
1045 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001046 typenames_, GetLanguage(), &error);
1047 ASSERT_NE(nullptr, parse_result);
1048 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001049 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001050 const auto& cpp_constants = interface->GetConstantDeclarations();
1051 EXPECT_EQ((size_t)1, cpp_constants.size());
1052 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001053 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001054 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001055}
1056
Devin Moore7b8d5c92020-03-17 14:14:08 -07001057TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001058 io_delegate_.SetFileContents(
1059 "p/Outer.aidl",
1060 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001061 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001062 const string input_path = "p/IFoo.aidl";
1063 const string input = "package p; import p.Outer; interface IFoo"
1064 " { Outer.Inner get(); }";
1065
Devin Moore7b8d5c92020-03-17 14:14:08 -07001066 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1067 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001068
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001069 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001070 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001071 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1072 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001073}
1074
Devin Moore7b8d5c92020-03-17 14:14:08 -07001075TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001076 io_delegate_.SetFileContents(
1077 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001078 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001079 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001080 const string input_path = "p/IFoo.aidl";
1081 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001082 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1083 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001084 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001085 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1086 native_type.Resolve(typenames_);
1087
1088 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1089 // C++ understands C++ specific stuff
1090 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1091 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001092 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001093 EXPECT_EQ(1u, headers.size());
1094 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001095}
1096
Christopher Wileyf8136192016-04-12 14:19:35 -07001097TEST_F(AidlTest, WritesCorrectDependencyFile) {
1098 // While the in tree build system always gives us an output file name,
1099 // other android tools take advantage of our ability to infer the intended
1100 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001101 vector<string> args = {
1102 "aidl",
1103 "-d dep/file/path",
1104 "-o place/for/output",
1105 "p/IFoo.aidl"};
1106 Options options = Options::From(args);
1107 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001108 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001109 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001110 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001111 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1112}
1113
Dan Willemsen93298ee2016-11-10 23:55:55 -08001114TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1115 // While the in tree build system always gives us an output file name,
1116 // other android tools take advantage of our ability to infer the intended
1117 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001118 vector<string> args = {
1119 "aidl",
1120 "-d dep/file/path",
1121 "--ninja",
1122 "-o place/for/output",
1123 "p/IFoo.aidl"};
1124 Options options = Options::From(args);
1125 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001126 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001127 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001128 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001129 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1130}
1131
Jiyong Parkdf202122019-09-30 20:48:35 +09001132TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001133 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1134 // this by calling aidl with every .aidl file it finds, then parsing the
1135 // generated dependency files. Those that reference .java output files are
1136 // for interfaces and those that do not are parcelables. However, for both
1137 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001138 vector<string> args = {
1139 "aidl",
1140 "-o place/for/output",
1141 "-d dep/file/path",
1142 "p/Foo.aidl"};
1143 Options options = Options::From(args);
1144 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001145 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001146 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001147 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001148 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1149}
1150
1151TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1152 vector<string> args = {
1153 "aidl",
1154 "--structured",
1155 "-o place/for/output",
1156 "-d dep/file/path",
1157 "p/Foo.aidl"};
1158 Options options = Options::From(args);
1159 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1160 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1161 string actual_dep_file_contents;
1162 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1163 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001164}
1165
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001166TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1167 vector<string> args = {
1168 "aidl",
1169 "--lang=java",
1170 "-o place/for/output",
1171 "p/Foo.aidl"};
1172 Options options = Options::From(args);
1173 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1174 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1175 string output_file_contents;
1176 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1177}
1178
Jeongik Cha08ca2182019-11-21 14:01:13 +09001179// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001180TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001181 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001182 "package a; interface IFoo {\n"
1183 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001184 string expected_stderr;
1185 switch (GetLanguage()) {
1186 case Options::Language::CPP:
1187 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001188 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001189 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1190 "String and IBinder.\n";
1191 break;
1192 case Options::Language::JAVA:
1193 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001194 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001195 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1196 "String, IBinder, and ParcelFileDescriptor.\n";
1197 break;
1198 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001199 case Options::Language::RUST:
1200 expected_stderr =
1201 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1202 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001203 default:
1204 AIDL_FATAL(AIDL_LOCATION_HERE)
1205 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1206 }
1207 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001208 AidlTypenames tn1;
1209 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001210 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001211
1212 string primitive_parcelable =
1213 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001214 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001215 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001216 AidlTypenames tn2;
1217 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001218 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001219}
1220
Devin Moore21b26772020-08-26 16:37:56 -07001221TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001222 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001223 const string list_array_parcelable =
1224 "package a; parcelable Foo {\n"
1225 " List[] lists; }";
1226 CaptureStderr();
1227 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1229}
1230
Jiyong Parkf8d53612020-05-04 14:06:13 +09001231TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1232 AidlError error;
1233 string expected_stderr =
1234 "ERROR: a/IFoo.aidl:2.7-11: "
1235 "Encountered an untyped List or Map. The use of untyped List/Map is "
1236 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1237 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1238 if (GetLanguage() != Options::Language::JAVA) {
1239 expected_stderr =
1240 "ERROR: a/IFoo.aidl:2.1-7: "
1241 "Currently, only the Java backend supports non-generic List.\n";
1242 }
1243
1244 const string primitive_interface =
1245 "package a; interface IFoo {\n"
1246 " List foo(); }";
1247 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001248 AidlTypenames tn1;
1249 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001250 {"--structured"}));
1251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001252
1253 string primitive_parcelable =
1254 "package a; parcelable IFoo {\n"
1255 " List foo;}";
1256 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001257 AidlTypenames tn2;
1258 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001259 {"--structured"}));
1260 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1261}
1262
Jeongik Cha225519b2020-08-29 01:55:32 +09001263TEST_P(AidlTest, ExtensionTest) {
1264 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001265 string extendable_parcelable =
1266 "package a; parcelable Data {\n"
1267 " ParcelableHolder extension;\n"
1268 " ParcelableHolder extension2;\n"
1269 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001270 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001271 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1272 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001273 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001274 "yet.\n",
1275 GetCapturedStderr());
1276 } else {
1277 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1278 EXPECT_EQ("", GetCapturedStderr());
1279 }
1280}
1281TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1282 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001283 string parcelableholder_return_interface =
1284 "package a; interface IFoo {\n"
1285 " ParcelableHolder foo();\n"
1286 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001287 EXPECT_EQ(nullptr,
1288 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001289
Jeongik Cha8f02a532020-10-14 00:16:28 +09001290 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001291 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001292 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001293 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001294 "yet.\n",
1295 GetCapturedStderr());
1296 return;
1297 }
1298 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1299 GetCapturedStderr());
1300}
1301
1302TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1303 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001304 string extendable_parcelable_arg_interface =
1305 "package a; interface IFoo {\n"
1306 " void foo(in ParcelableHolder ph);\n"
1307 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001308 EXPECT_EQ(nullptr,
1309 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1310
Jeongik Cha8f02a532020-10-14 00:16:28 +09001311 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001312 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001313 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001314 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001315 "yet.\n",
1316 GetCapturedStderr());
1317 return;
1318 }
1319 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1320 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001321}
1322
Jiyong Park02da7422018-07-16 16:00:26 +09001323TEST_F(AidlTest, ApiDump) {
1324 io_delegate_.SetFileContents(
1325 "foo/bar/IFoo.aidl",
1326 "package foo.bar;\n"
1327 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001328 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001329 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001330 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001331 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1332 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1333 " IFoo foo3(IFoo foo);\n"
1334 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001335 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001336 " const int A = 1;\n"
1337 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001338 "}\n");
1339 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1340 "package foo.bar;\n"
1341 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001342 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001343 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001344 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001345 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001346 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001347 " int y;\n"
1348 " IFoo foo;\n"
1349 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001350 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001351 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001352 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001353 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001354 "}\n");
1355 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001356 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1357 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001358 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001359 bool result = dump_api(options, io_delegate_);
1360 ASSERT_TRUE(result);
1361 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001362 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001363 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001364/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001365interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001366 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001367 int foo(out int[] a, String b, boolean c, inout List<String> d);
1368 int foo2(@utf8InCpp String x, inout List<String> y);
1369 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1370 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001371 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001372 const int A = 1;
1373 const String STR = "Hello";
1374}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001375)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001376
Jiyong Parke59c3682018-09-11 23:10:25 +09001377 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001378 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001379/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001380parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001381 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001382 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001383 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001384 int y;
1385 foo.bar.IFoo foo;
1386 List<foo.bar.IFoo> a;
1387 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001388 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001389 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001390}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001391)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001392}
1393
Jiyong Parked65bf42018-08-28 15:43:27 +09001394TEST_F(AidlTest, ApiDumpWithManualIds) {
1395 io_delegate_.SetFileContents(
1396 "foo/bar/IFoo.aidl",
1397 "package foo.bar;\n"
1398 "interface IFoo {\n"
1399 " int foo() = 1;\n"
1400 " int bar() = 2;\n"
1401 " int baz() = 10;\n"
1402 "}\n");
1403
Jiyong Parke59c3682018-09-11 23:10:25 +09001404 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001405 Options options = Options::From(args);
1406 bool result = dump_api(options, io_delegate_);
1407 ASSERT_TRUE(result);
1408 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001409 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001410 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001411interface IFoo {
1412 int foo() = 1;
1413 int bar() = 2;
1414 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001415}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001416)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001417}
1418
1419TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001420 const string expected_stderr =
1421 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1422 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001423 io_delegate_.SetFileContents(
1424 "foo/bar/IFoo.aidl",
1425 "package foo.bar;\n"
1426 "interface IFoo {\n"
1427 " int foo() = 1;\n"
1428 " int bar();\n"
1429 " int baz() = 10;\n"
1430 "}\n");
1431
Jiyong Parke59c3682018-09-11 23:10:25 +09001432 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001433 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001434 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001435 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001436 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001437}
1438
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001439TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001440 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001441 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1442 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001443 const string expected_map_stderr =
1444 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001445 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1446 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001447 "package p; interface IFoo {"
1448 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001449 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001450 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001451 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001452
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001453 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001454 "package p; interface IFoo {"
1455 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001456 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001457 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001458 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001459}
1460
Jeongik Chae48d9942020-01-02 17:39:00 +09001461TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001462 const string expected_stderr =
1463 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001464 Options options = Options::From("aidl -I p p/IFoo.aidl");
1465 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1466
1467 io_delegate_.SetFileContents("p/IFoo.aidl",
1468 "package p; interface IFoo {"
1469 "Map<String, Bar> foo();}");
1470 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1471
1472 io_delegate_.SetFileContents("p/IFoo.aidl",
1473 "package p; interface IFoo {"
1474 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001475 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001476 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001477 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001478
1479 io_delegate_.SetFileContents("p/IFoo.aidl",
1480 "package p; interface IFoo {"
1481 "Map<String, String> foo();}");
1482 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1483
1484 io_delegate_.SetFileContents("p/IFoo.aidl",
1485 "package p; interface IFoo {"
1486 "Map<String, ParcelFileDescriptor> foo();}");
1487 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1488}
1489
Jeongik Chadf76dc72019-11-28 00:08:47 +09001490TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001491 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001492 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1493 io_delegate_.SetFileContents(options.InputFiles().front(),
1494 "package p; interface IFoo {"
1495 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001496 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001497 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001498 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001499}
1500
1501TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1502 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1503 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001504 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001505 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001506 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1507 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001508
1509 Options options = Options::From("aidl -I p p/IFoo.aidl");
1510 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1511 io_delegate_.SetFileContents("p/IFoo.aidl",
1512 "package p; interface IFoo {"
1513 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001514 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001515 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001516 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001517 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001518 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001519 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001520 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1521 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001522 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1523 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1524 io_delegate_.SetFileContents("p/IFoo.aidl",
1525 "package p; interface IFoo {"
1526 "Bar<String, ParcelFileDescriptor> foo();}");
1527 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001528
1529 io_delegate_.SetFileContents("p/IFoo.aidl",
1530 "package p; interface IFoo {"
1531 "Bar<int, long> foo();}");
1532
1533 io_delegate_.SetFileContents("p/IFoo.aidl",
1534 "package p; interface IFoo {"
1535 "Bar<int[], long[]> foo();}");
1536
1537 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001538}
1539
Jeongik Cha0e426012019-07-29 15:57:02 +09001540TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1541 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001542 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1543 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001544 for (const auto& rawOption : rawOptions) {
1545 string expected_stderr =
1546 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001547 Options options = Options::From(rawOption);
1548 io_delegate_.SetFileContents(options.InputFiles().front(),
1549 "package foo.bar;\n"
1550 "interface IFoo1 { int foo(); }\n"
1551 "interface IFoo2 { int foo(); }\n"
1552 "parcelable Data1 { int a; int b;}\n"
1553 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001554 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001555 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001556 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001557
Jeongik Cha0e426012019-07-29 15:57:02 +09001558 io_delegate_.SetFileContents(options.InputFiles().front(),
1559 "package foo.bar;\n"
1560 "interface IFoo1 { int foo(); }\n"
1561 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001562 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001563 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001564 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001565
Devin Moore5de18ed2020-04-02 13:52:29 -07001566 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001567 io_delegate_.SetFileContents(options.InputFiles().front(),
1568 "package foo.bar;\n"
1569 "parcelable Data1 { int a; int b;}\n"
1570 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001571 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001572 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001573 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001574 }
1575}
1576
Devin Moorebdba2a82020-03-31 15:19:02 -07001577TEST_P(AidlTest, FailParseOnEmptyFile) {
1578 const string contents = "";
1579 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1580 CaptureStderr();
1581 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1582 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1583}
1584
Jiyong Parkb034bf02018-07-30 17:44:33 +09001585TEST_F(AidlTest, MultipleInputFiles) {
1586 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001587 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001588
1589 io_delegate_.SetFileContents(options.InputFiles().at(0),
1590 "package foo.bar;\n"
1591 "import foo.bar.Data;\n"
1592 "interface IFoo { Data getData(); }\n");
1593
1594 io_delegate_.SetFileContents(options.InputFiles().at(1),
1595 "package foo.bar;\n"
1596 "import foo.bar.IFoo;\n"
1597 "parcelable Data { IFoo foo; }\n");
1598
1599 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1600
1601 string content;
1602 for (const auto file : {
1603 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1604 content.clear();
1605 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1606 EXPECT_FALSE(content.empty());
1607 }
1608}
1609
1610TEST_F(AidlTest, MultipleInputFilesCpp) {
1611 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001612 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001613
1614 io_delegate_.SetFileContents(options.InputFiles().at(0),
1615 "package foo.bar;\n"
1616 "import foo.bar.Data;\n"
1617 "interface IFoo { Data getData(); }\n");
1618
1619 io_delegate_.SetFileContents(options.InputFiles().at(1),
1620 "package foo.bar;\n"
1621 "import foo.bar.IFoo;\n"
1622 "parcelable Data { IFoo foo; }\n");
1623
1624 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1625
1626 string content;
1627 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001628 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001629 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1630 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1631 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1632 content.clear();
1633 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1634 EXPECT_FALSE(content.empty());
1635 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001636}
1637
Andrei Homescub62afd92020-05-11 19:24:59 -07001638TEST_F(AidlTest, MultipleInputFilesRust) {
1639 Options options =
1640 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1641
1642 io_delegate_.SetFileContents(options.InputFiles().at(0),
1643 "package foo.bar;\n"
1644 "import foo.bar.Data;\n"
1645 "interface IFoo { Data getData(); }\n");
1646
1647 io_delegate_.SetFileContents(options.InputFiles().at(1),
1648 "package foo.bar;\n"
1649 "import foo.bar.IFoo;\n"
1650 "parcelable Data { IFoo foo; }\n");
1651
1652 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1653
1654 string content;
1655 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1656 content.clear();
1657 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1658 EXPECT_FALSE(content.empty());
1659 }
1660}
1661
Devin Moore097a3ab2020-03-11 16:08:44 -07001662TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1663 const string expected_stderr =
1664 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001665 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1666 // int getInterfaceVersion() is one of the meta transactions
1667 io_delegate_.SetFileContents(options.InputFiles().front(),
1668 "package p; interface IFoo {"
1669 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001670 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001671 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001672 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1673}
Jiyong Park309668e2018-07-28 16:55:44 +09001674
Devin Moore097a3ab2020-03-11 16:08:44 -07001675TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1676 // boolean getInterfaceVersion() is not a meta transaction, but should be
1677 // prevented because return type is not part of a method signature
1678 const string expected_stderr =
1679 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1680 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001681 io_delegate_.SetFileContents(options.InputFiles().front(),
1682 "package p; interface IFoo {"
1683 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001684 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001685 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001686 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1687}
Jiyong Park309668e2018-07-28 16:55:44 +09001688
Devin Moore097a3ab2020-03-11 16:08:44 -07001689TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001690 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001691 const string expected_stderr =
1692 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1693 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001694 io_delegate_.SetFileContents(options.InputFiles().front(),
1695 "package p; interface IFoo {"
1696 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001697 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001698 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001699 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001700
1701 // this is not a meta interface method as it differs type arguments
1702 io_delegate_.SetFileContents(options.InputFiles().front(),
1703 "package p; interface IFoo {"
1704 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001705 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001706}
1707
Daniel Norman85aed542019-08-21 12:01:14 -07001708TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001709 Options options = Options::From("aidl --checkapi old new");
1710 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1711 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1712 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1713 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1714
1715 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1716}
1717
Jiyong Park3656c3c2018-08-01 20:02:01 +09001718TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001719 Options options = Options::From("aidl --checkapi old new");
1720 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1721 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001722
1723 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1724}
1725
Daniel Norman85aed542019-08-21 12:01:14 -07001726class AidlTestCompatibleChanges : public AidlTest {
1727 protected:
1728 Options options_ = Options::From("aidl --checkapi old new");
1729};
1730
1731TEST_F(AidlTestCompatibleChanges, NewType) {
1732 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1733 "package p;"
1734 "interface IFoo {"
1735 " void foo(int a);"
1736 "}");
1737 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1738 "package p;"
1739 "interface IFoo {"
1740 " void foo(int a);"
1741 "}");
1742 io_delegate_.SetFileContents("new/p/IBar.aidl",
1743 "package p;"
1744 "interface IBar {"
1745 " void bar();"
1746 "}");
1747 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1748}
1749
1750TEST_F(AidlTestCompatibleChanges, NewMethod) {
1751 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1752 "package p;"
1753 "interface IFoo {"
1754 " void foo(int a);"
1755 "}");
1756 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1757 "package p;"
1758 "interface IFoo {"
1759 " void foo(int a);"
1760 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001761 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001762 "}");
1763 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1764}
1765
1766TEST_F(AidlTestCompatibleChanges, NewField) {
1767 io_delegate_.SetFileContents("old/p/Data.aidl",
1768 "package p;"
1769 "parcelable Data {"
1770 " int foo;"
1771 "}");
1772 io_delegate_.SetFileContents("new/p/Data.aidl",
1773 "package p;"
1774 "parcelable Data {"
1775 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001776 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001777 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001778 "}");
1779 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1780}
1781
1782TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1783 io_delegate_.SetFileContents("old/p/Enum.aidl",
1784 "package p;"
1785 "enum Enum {"
1786 " FOO = 1,"
1787 "}");
1788 io_delegate_.SetFileContents("new/p/Enum.aidl",
1789 "package p;"
1790 "enum Enum {"
1791 " FOO = 1,"
1792 " BAR = 2,"
1793 "}");
1794 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1795}
1796
1797TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1798 io_delegate_.SetFileContents("old/p/Enum.aidl",
1799 "package p;"
1800 "enum Enum {"
1801 " FOO = 1,"
1802 " BAR = 2,"
1803 "}");
1804 io_delegate_.SetFileContents("new/p/Enum.aidl",
1805 "package p;"
1806 "enum Enum {"
1807 " BAR = 2,"
1808 " FOO = 1,"
1809 "}");
1810 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1811}
1812
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001813TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1814 io_delegate_.SetFileContents("old/p/Union.aidl",
1815 "package p;"
1816 "union Union {"
1817 " String foo;"
1818 "}");
1819 io_delegate_.SetFileContents("new/p/Union.aidl",
1820 "package p;"
1821 "union Union {"
1822 " String foo;"
1823 " int num;"
1824 "}");
1825 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1826}
1827
Daniel Norman85aed542019-08-21 12:01:14 -07001828TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001829 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1830 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001831 "interface IFoo {"
1832 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001833 "}");
1834 io_delegate_.SetFileContents("old/p/Data.aidl",
1835 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001836 "parcelable Data {"
1837 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001838 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001839 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1840 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001841 "interface IFoo {"
1842 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001843 "}");
1844 io_delegate_.SetFileContents("new/p/Data.aidl",
1845 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001846 "parcelable Data {"
1847 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001848 "}");
1849 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1850 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001851 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001852 " void foo(int a);"
1853 "}");
1854 io_delegate_.SetFileContents("new/q/Data.aidl",
1855 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001856 "parcelable Data {"
1857 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001858 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001859 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1860}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001861
Daniel Norman85aed542019-08-21 12:01:14 -07001862TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1863 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1864 "package p;"
1865 "interface IFoo {"
1866 " void foo(int a);"
1867 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001868 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1869 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001870 "interface IFoo {"
1871 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001872 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001873 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1874}
Jiyong Parke59c3682018-09-11 23:10:25 +09001875
Daniel Norman85aed542019-08-21 12:01:14 -07001876TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001877 io_delegate_.SetFileContents("old/p/I.aidl",
1878 "package p; interface I {"
1879 "const int A = 1; }");
1880 io_delegate_.SetFileContents("new/p/I.aidl",
1881 "package p ; interface I {"
1882 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001883 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1884}
Jiyong Parka428d212018-08-29 22:26:30 +09001885
Daniel Norman85aed542019-08-21 12:01:14 -07001886TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001887 io_delegate_.SetFileContents("old/p/I.aidl",
1888 "package p; interface I {"
1889 "const int A = 1; const int B = 2;}");
1890 io_delegate_.SetFileContents("new/p/I.aidl",
1891 "package p ; interface I {"
1892 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001893 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001894}
1895
Jooyung Han636fd2f2020-10-22 11:33:45 +09001896TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
1897 io_delegate_.SetFileContents("old/p/Data.aidl",
1898 "package p;"
1899 "parcelable Data {"
1900 " int num;"
1901 "}");
1902 io_delegate_.SetFileContents(
1903 "new/p/Data.aidl",
1904 "package p;"
1905 "parcelable Data {"
1906 " int num;"
1907 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
1908 "}");
1909 io_delegate_.SetFileContents("new/p/Enum.aidl",
1910 "package p;"
1911 "enum Enum {"
1912 " FOO = 0,"
1913 " BAR = 1,"
1914 "}");
1915 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1916}
1917
Daniel Norman85aed542019-08-21 12:01:14 -07001918class AidlTestIncompatibleChanges : public AidlTest {
1919 protected:
1920 Options options_ = Options::From("aidl --checkapi old new");
1921};
1922
1923TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001924 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001925 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1926 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001927 "interface IFoo {"
1928 " void foo(in String[] str);"
1929 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001930 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001931 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001932 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001933 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001934}
1935
1936TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001937 const string expected_stderr =
1938 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001939 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1940 "package p;"
1941 "interface IFoo {"
1942 " void foo(in String[] str);"
1943 " void bar(@utf8InCpp String str);"
1944 "}");
1945 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1946 "package p;"
1947 "interface IFoo {"
1948 " void foo(in String[] str);"
1949 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001950 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001951 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001952 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001953}
1954
Jiyong Parkf8d53612020-05-04 14:06:13 +09001955TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1956 const string expected_stderr =
1957 "ERROR: new/p/IFoo.aidl:1.61-65: "
1958 "Encountered an untyped List or Map. The use of untyped List/Map is "
1959 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1960 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1961 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1962 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1963 "package p;"
1964 "interface IFoo {"
1965 " void foo(in String[] str);"
1966 "}");
1967 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1968 "package p;"
1969 "interface IFoo {"
1970 " void foo(in String[] str);"
1971 " void bar(in List arg);"
1972 "}");
1973 CaptureStderr();
1974 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1975 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1976}
1977
1978TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
1979 const string expected_stderr =
1980 "ERROR: new/p/Data.aidl:1.54-59: "
1981 "Encountered an untyped List or Map. The use of untyped List/Map is "
1982 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1983 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1984 "ERROR: new/p/Data.aidl: Failed to read.\n";
1985 io_delegate_.SetFileContents("old/p/Data.aidl",
1986 "package p;"
1987 "parcelable Data {"
1988 " int foo;"
1989 "}");
1990 io_delegate_.SetFileContents("new/p/Data.aidl",
1991 "package p;"
1992 "parcelable Data {"
1993 " int foo;"
1994 " @nullable List list;"
1995 "}");
1996 CaptureStderr();
1997 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1998 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1999}
2000
Daniel Norman85aed542019-08-21 12:01:14 -07002001TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002002 const string expected_stderr =
2003 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002004 io_delegate_.SetFileContents("old/p/Data.aidl",
2005 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002006 "parcelable Data {"
2007 " int foo;"
2008 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002009 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002010 io_delegate_.SetFileContents("new/p/Data.aidl",
2011 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002012 "parcelable Data {"
2013 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002014 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002015 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002016 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002017 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002018}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002019
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002020TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2021 const string expected_stderr =
2022 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2023 "backends. Please either provide a default value for this field or mark the field as "
2024 "@nullable. This value or a null value will be used automatically when an old version of "
2025 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2026 "order to make sure your code continues to be backwards compatible, make sure the default or "
2027 "null value does not cause a semantic change to this parcelable.\n";
2028 io_delegate_.SetFileContents("old/p/Data.aidl",
2029 "package p;"
2030 "parcelable Data {"
2031 " int num;"
2032 "}");
2033 io_delegate_.SetFileContents("new/p/Data.aidl",
2034 "package p;"
2035 "parcelable Data {"
2036 " int num;"
2037 " String str;"
2038 "}");
2039 CaptureStderr();
2040 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2041 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2042}
2043
Jooyung Han636fd2f2020-10-22 11:33:45 +09002044TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2045 const string expected_stderr =
2046 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2047 "Please make sure 'Enum' has '0' as a valid value.\n";
2048 io_delegate_.SetFileContents("old/p/Data.aidl",
2049 "package p;"
2050 "parcelable Data {"
2051 " int num;"
2052 "}");
2053 io_delegate_.SetFileContents("new/p/Data.aidl",
2054 "package p;"
2055 "parcelable Data {"
2056 " int num;"
2057 " p.Enum e;"
2058 "}");
2059 io_delegate_.SetFileContents("new/p/Enum.aidl",
2060 "package p;"
2061 "enum Enum {"
2062 " FOO = 1,"
2063 " BAR = 2,"
2064 "}");
2065 CaptureStderr();
2066 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2067 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2068}
2069
Daniel Norman85aed542019-08-21 12:01:14 -07002070TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002071 const string expected_stderr =
2072 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002073 io_delegate_.SetFileContents("old/p/Enum.aidl",
2074 "package p;"
2075 "enum Enum {"
2076 " FOO = 1,"
2077 " BAR = 2,"
2078 "}");
2079 io_delegate_.SetFileContents("new/p/Enum.aidl",
2080 "package p;"
2081 "enum Enum {"
2082 " BAR = 2,"
2083 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002084 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002085 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002086 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002087}
2088
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002089TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2090 const string expected_stderr =
2091 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2092 io_delegate_.SetFileContents("old/p/Union.aidl",
2093 "package p;"
2094 "union Union {"
2095 " String str;"
2096 " int num;"
2097 "}");
2098 io_delegate_.SetFileContents("new/p/Union.aidl",
2099 "package p;"
2100 "union Union {"
2101 " String str;"
2102 "}");
2103 CaptureStderr();
2104 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2105 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2106}
2107
Daniel Norman85aed542019-08-21 12:01:14 -07002108TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002109 const string expected_stderr =
2110 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002111 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2112 "package p;"
2113 "interface IFoo {"
2114 " void foo(in String[] str);"
2115 " void bar(@utf8InCpp String str);"
2116 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002117 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2118 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002119 "interface IFoo {"
2120 " void foo(in String[] str);"
2121 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002122 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002123 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002124 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002125 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002126}
2127
Daniel Norman85aed542019-08-21 12:01:14 -07002128TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002129 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002130 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2131 "package p;"
2132 "interface IFoo {"
2133 " void foo(in String[] str);"
2134 " void bar(@utf8InCpp String str);"
2135 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002136 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2137 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002138 "interface IFoo2 {"
2139 " void foo(in String[] str);"
2140 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002141 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002142 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002143 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002144 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002145}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002146
Daniel Norman85aed542019-08-21 12:01:14 -07002147TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002148 const string expected_stderr =
2149 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002150 io_delegate_.SetFileContents("old/p/Enum.aidl",
2151 "package p;"
2152 "enum Enum {"
2153 " FOO = 1,"
2154 " BAR = 2,"
2155 "}");
2156 io_delegate_.SetFileContents("new/p/Enum.aidl",
2157 "package p;"
2158 "enum Enum {"
2159 " FOO = 3,"
2160 " BAR = 2,"
2161 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002162 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002163 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002164 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002165}
2166
2167TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002168 const string expected_stderr =
2169 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2170 "from 0 to 1.\n"
2171 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2172 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002173 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2174 "package p;"
2175 "interface IFoo {"
2176 " void foo(in String[] str);"
2177 " void bar(@utf8InCpp String str);"
2178 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002179 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2180 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002181 "interface IFoo {"
2182 " void bar(@utf8InCpp String str);"
2183 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002184 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002185 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002186 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002187 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002188}
2189
2190TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002191 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002192 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2193 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002194 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002195 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002196 "parcelable Data {"
2197 " int foo;"
2198 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002199 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002200 io_delegate_.SetFileContents("new/p/Data.aidl",
2201 "package p;"
2202 "parcelable Data {"
2203 " int bar;"
2204 " int foo;"
2205 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002206 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002207 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002208 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002209}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002210
Daniel Norman85aed542019-08-21 12:01:14 -07002211TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002212 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002213 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002214 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002215 "interface IFoo {"
2216 " void foo(in String[] str);"
2217 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002218 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002219 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2220 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002221 "interface IFoo {"
2222 " void foo(out String[] str);"
2223 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002224 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002225 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002226 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002227 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002228}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002229
Daniel Norman85aed542019-08-21 12:01:14 -07002230TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002231 const string expected_stderr =
2232 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002233 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2234 "package p;"
2235 "interface IFoo {"
2236 " void foo(in String[] str);"
2237 " void bar(@utf8InCpp String str);"
2238 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002239 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2240 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002241 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002242 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002243 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002244 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002245 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002246 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002247 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002248}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002249
Daniel Norman85aed542019-08-21 12:01:14 -07002250TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002251 const string expected_stderr =
2252 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002253 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2254 "package p;"
2255 "interface IFoo {"
2256 " void foo(in String[] str);"
2257 " void bar(@utf8InCpp String str);"
2258 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002259 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2260 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002261 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002262 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002263 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002264 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002265 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002266 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002267 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002268}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002269
Devin Mooredb7ac512020-08-07 11:17:36 -07002270TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2271 const string expected_stderr =
2272 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2273 io_delegate_.SetFileContents("old/p/Foo.aidl",
2274 "package p;"
2275 "parcelable Foo {"
2276 " int A;"
2277 "}");
2278 io_delegate_.SetFileContents("new/p/Foo.aidl",
2279 "package p;"
2280 "@JavaOnlyStableParcelable parcelable Foo {"
2281 " int A;"
2282 "}");
2283 CaptureStderr();
2284 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2285 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2286}
2287
2288TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2289 const string expected_stderr =
2290 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2291 io_delegate_.SetFileContents("old/p/Foo.aidl",
2292 "package p;"
2293 "@JavaOnlyStableParcelable parcelable Foo {"
2294 " int A;"
2295 "}");
2296 io_delegate_.SetFileContents("new/p/Foo.aidl",
2297 "package p;"
2298 "parcelable Foo {"
2299 " int A;"
2300 "}");
2301 CaptureStderr();
2302 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2303 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2304}
2305
Daniel Norman85aed542019-08-21 12:01:14 -07002306TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002307 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002308 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2309 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002310 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002311 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002312 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002314}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002315
Daniel Norman85aed542019-08-21 12:01:14 -07002316TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002317 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002318 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2319 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002320 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002321 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002323}
Jiyong Parka428d212018-08-29 22:26:30 +09002324
Daniel Norman85aed542019-08-21 12:01:14 -07002325TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002326 const string expected_stderr =
2327 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002328 io_delegate_.SetFileContents("old/p/I.aidl",
2329 "package p; interface I {"
2330 "const int A = 1; const int B = 2;}");
2331 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002332 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002333 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002334 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002335}
Jiyong Parka428d212018-08-29 22:26:30 +09002336
Daniel Norman85aed542019-08-21 12:01:14 -07002337TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002338 const string expected_stderr =
2339 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002340 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2341 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002342 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002343 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002344 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002345}
2346
Devin Moorec7e47a32020-08-07 10:55:25 -07002347TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2348 const string expected_stderr =
2349 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2350 "This is an incompatible change for FixedSize types.\n";
2351 io_delegate_.SetFileContents("old/p/Foo.aidl",
2352 "package p; @FixedSize parcelable Foo { int A = 1; }");
2353 io_delegate_.SetFileContents("new/p/Foo.aidl",
2354 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2355 CaptureStderr();
2356 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2357 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2358}
2359
2360TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2361 const string expected_stderr =
2362 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2363 io_delegate_.SetFileContents("old/p/Foo.aidl",
2364 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2365 io_delegate_.SetFileContents("new/p/Foo.aidl",
2366 "package p; @FixedSize parcelable Foo { int A = 1; }");
2367 CaptureStderr();
2368 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2369 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2370}
2371
2372TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2373 const string expected_stderr =
2374 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2375 "a.\n"
2376 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2377 "b.\n"
2378 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2379 "c.\n"
2380 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2381 "d.\n"
2382 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2383 "e.\n"
2384 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2385 "f.\n";
2386
2387 io_delegate_.SetFileContents("Foo.aidl",
2388 "@FixedSize parcelable Foo { "
2389 " int[] a;"
2390 " Bar b;"
2391 " String c;"
2392 " ParcelFileDescriptor d;"
2393 " IBinder e;"
2394 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002395 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002396 "}");
2397 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2398 Options options =
2399 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2400
2401 CaptureStderr();
2402 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2403 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2404}
2405
2406TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2407 const string expected_stderr = "";
2408
2409 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2410 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2411 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2412 Options options =
2413 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2414
2415 CaptureStderr();
2416 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2418}
2419
Jiyong Park8c380532018-08-30 14:55:26 +09002420TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002421 const string expected_stderr =
2422 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2423 "dir1/q/IBar.aidl\n"
2424 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002425 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002426 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2427 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2428 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2429 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2430
Devin Moore097a3ab2020-03-11 16:08:44 -07002431 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002432 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002433 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002434}
2435
Jiyong Parked65bf42018-08-28 15:43:27 +09002436TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002437 const string expected_stderr =
2438 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2439 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002440 Options options = Options::From("aidl --checkapi old new");
2441 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2442 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002443
2444 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2445
Jiyong Parke59c3682018-09-11 23:10:25 +09002446 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002447 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002448 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002449 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002450}
2451
Jiyong Parke05195e2018-10-08 18:24:23 +09002452TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2453 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2454 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002455 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002456
2457 // use without import
2458 io_delegate_.SetFileContents("p/IFoo.aidl",
2459 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2460 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2461 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002462 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002463
Devin Moore7b8d5c92020-03-17 14:14:08 -07002464 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002465 io_delegate_.SetFileContents(
2466 "p/IFoo.aidl",
2467 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2468 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2469 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002470 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002471
2472 // use with import (as before)
2473 io_delegate_.SetFileContents("p/IFoo.aidl",
2474 "package p;"
2475 "import android.os.ParcelFileDescriptor;"
2476 "interface IFoo{"
2477 " void foo(in ParcelFileDescriptor fd);"
2478 "}");
2479 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2480 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002481 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002482}
Jiyong Parked65bf42018-08-28 15:43:27 +09002483
Jiyong Park3633b722019-04-11 15:38:26 +09002484TEST_F(AidlTest, ManualIds) {
2485 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2486 io_delegate_.SetFileContents("IFoo.aidl",
2487 "interface IFoo {\n"
2488 " void foo() = 0;\n"
2489 " void bar() = 1;\n"
2490 "}");
2491 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2492}
2493
2494TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2495 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2496 io_delegate_.SetFileContents("IFoo.aidl",
2497 "interface IFoo {\n"
2498 " void foo() = 0;\n"
2499 " void bar() = 1;\n"
2500 "}");
2501 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2502}
2503
2504TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002505 const string expected_stderr =
2506 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002507 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2508 io_delegate_.SetFileContents("IFoo.aidl",
2509 "interface IFoo {\n"
2510 " void foo() = 3;\n"
2511 " void bar() = 3;\n"
2512 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002513 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002514 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002515 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002516}
2517
2518TEST_F(AidlTest, FailOnOutOfRangeIds) {
2519 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002520 const string expected_stderr =
2521 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2522 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002523 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2524 io_delegate_.SetFileContents("IFoo.aidl",
2525 "interface IFoo {\n"
2526 " void foo() = 3;\n"
2527 " void bar() = 16777115;\n"
2528 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002529 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002530 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002531 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002532}
2533
2534TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002535 const string expected_stderr =
2536 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002537 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2538 io_delegate_.SetFileContents("IFoo.aidl",
2539 "interface IFoo {\n"
2540 " void foo() = 3;\n"
2541 " void bar();\n"
2542 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002543 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002544 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002545 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002546}
2547
Jiyong Parkc6816252019-07-08 08:12:28 +09002548TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2549 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2550 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2551 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2552 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2553}
2554
2555TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002556 const string expected_stderr =
2557 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2558 "dir/IBar.aidl\n"
2559 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002560 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002561
Jiyong Parkc6816252019-07-08 08:12:28 +09002562 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2563 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2564 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2565 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002566 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002567 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002568 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002569}
2570
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002571TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2572 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2573 "package a.b;\n"
2574 "import a.b.IBar;\n"
2575 "import a.b.IQux;\n"
2576 "interface IFoo { IQux foo(); }\n");
2577 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2578 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2579
2580 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2581 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2582
2583 string output;
2584 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2585 // IBar was imported but wasn't used. include is not expected.
2586 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2587 // IBar was imported and used. include is expected.
2588 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2589}
2590
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002591TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002592 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002593 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002594 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2595 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002596 interface IFoo {
2597 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002598 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002599 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002600 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002601 // JavaPassthrough should work with other types as well (e.g. enum)
2602 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2603 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2604 @JavaPassthrough(annotation="@com.android.AliceTwo")
2605 @Backing(type="byte")
2606 enum MyEnum {
2607 a, b, c
2608 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002609
Jooyung Han4cde01d2020-10-13 11:10:47 +09002610 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002611 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2612
2613 string java_out;
2614 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002615 // type-decl-level annotations with newline at the end
2616 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2617 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2618 // member-decl-level annotations with newline at the end
2619 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2620 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2621 // inline annotations with space at the end
2622 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002623
Jooyung Han4cde01d2020-10-13 11:10:47 +09002624 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2625 // type-decl-level annotations with newline at the end
2626 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2627 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2628
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002629 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002630 Options cpp_options =
2631 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002632 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2633
Jooyung Han4cde01d2020-10-13 11:10:47 +09002634 Options ndk_options =
2635 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002636 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002637
Jooyung Han4cde01d2020-10-13 11:10:47 +09002638 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002639 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002640}
2641
Andrei Homescue61feb52020-08-18 15:44:24 -07002642TEST_F(AidlTest, ParseRustDerive) {
2643 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2644 @RustDerive(Clone=true, Copy=false)
2645 parcelable Foo {
2646 int a;
2647 })");
2648
2649 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2650 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2651
2652 string rust_out;
2653 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2654 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2655
2656 // Other backends shouldn't be bothered
2657 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2658 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2659
2660 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2661 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2662
2663 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2664 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2665}
2666
Jiyong Park56f73d72019-06-11 12:20:28 +09002667class AidlOutputPathTest : public AidlTest {
2668 protected:
2669 void SetUp() override {
2670 AidlTest::SetUp();
2671 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2672 }
2673
2674 void Test(const Options& options, const std::string expected_output_path) {
2675 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2676 // check the existence
2677 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2678 }
2679};
2680
2681TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2682 // <out_dir> / <package_name> / <type_name>.java
2683 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2684}
2685
2686TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2687 // when output file is explicitly set, it is always respected. -o option is
2688 // ignored.
2689 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2690}
2691
2692TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2693 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2694}
2695
2696TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2697 // output is the same as the input file except for the suffix
2698 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2699}
2700
Devin Moore7b8d5c92020-03-17 14:14:08 -07002701TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002702 AidlError error;
2703 const string expected_stderr =
2704 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2705 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002706 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2707 R"(package p;
2708 interface IFoo {
2709 const int int32_max_oob = 2147483650;
2710 }
2711 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002712 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002713 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2714 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002715}
2716
Devin Moore7b8d5c92020-03-17 14:14:08 -07002717TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002718 AidlError error;
2719 const string expected_stderr =
2720 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2721 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002722 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2723 R"(package p;
2724 interface IFoo {
2725 const int int32_min_oob = -2147483650;
2726 }
2727 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002728 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002729 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2730 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002731}
2732
Devin Moore7b8d5c92020-03-17 14:14:08 -07002733TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002734 AidlError error;
2735 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002736 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002737 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002738 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2739 R"(package p;
2740 interface IFoo {
2741 const long int64_max_oob = 21474836509999999999999999;
2742 }
2743 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002744 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002745 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2746 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002747}
2748
Devin Moore7b8d5c92020-03-17 14:14:08 -07002749TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002750 AidlError error;
2751 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002752 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002753 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002754 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2755 R"(package p;
2756 interface IFoo {
2757 const long int64_min_oob = -21474836509999999999999999;
2758 }
2759 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002760 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002761 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2762 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002763}
2764
Devin Moore7b8d5c92020-03-17 14:14:08 -07002765TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002766 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002767 const string expected_stderr =
2768 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2769 "literal: byte\n"
2770 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2771 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002772 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2773 R"(package p;
2774 @Backing(type="byte")
2775 enum TestEnum {
2776 FOO = 127,
2777 BAR,
2778 }
2779 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002780 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002781 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002782 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002783}
2784
Devin Mooredecaf292020-04-30 09:16:40 -07002785TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2786 AidlError error;
2787 const string expected_stderr =
2788 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2789 "be one of: type\n"
2790 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2791 "be one of: type\n";
2792 CaptureStderr();
2793 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2794 R"(package p;
2795 @Backing(foo="byte")
2796 enum TestEnum {
2797 FOO = 1,
2798 BAR,
2799 }
2800 )",
2801 typenames_, GetLanguage(), &error));
2802 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2803 EXPECT_EQ(AidlError::BAD_TYPE, error);
2804}
2805
Jooyung Han66813932020-10-23 13:24:44 +09002806TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002807 io_delegate_.SetFileContents("Foo.aidl",
2808 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2809 "Map<String, Baz> d; Bar[] e; }");
2810 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2811 io_delegate_.SetFileContents("Baz.aidl",
2812 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002813 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2814 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2815}
2816
Jooyung Han66813932020-10-23 13:24:44 +09002817TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002818 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002819 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09002820 string expected_error =
2821 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable parcelable 'Foo' has a non-immutable field "
2822 "named 'bar'.\n";
2823 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002824 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2825 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09002826 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002827}
2828
Jooyung Han66813932020-10-23 13:24:44 +09002829TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002830 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002831 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
2832 string expected_error =
2833 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
2834 "only be an in parameter.\n";
2835 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002836 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2837 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002838 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002839}
2840
Jooyung Han66813932020-10-23 13:24:44 +09002841TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002842 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002843 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
2844 string expected_error =
2845 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
2846 "only be an in parameter.\n";
2847 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002848 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2849 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002850 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002851}
2852
Jooyung Han66813932020-10-23 13:24:44 +09002853TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002854 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002855 Options options = Options::From("aidl --lang=java Foo.aidl");
2856 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002857 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002858 "capitalizing the first letter\n";
2859 CaptureStderr();
2860 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2861 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2862}
Devin Moore53fc99c2020-08-12 08:07:52 -07002863
Jooyung Han1f14ab32020-10-14 13:48:29 +09002864const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2865
2866#include <a/ByteEnum.h>
2867#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09002868#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002869#include <binder/Status.h>
2870#include <cstdint>
Jooyung Han3df81ae2020-10-17 17:59:59 +09002871#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002872#include <utility>
2873#include <variant>
2874#include <vector>
2875
2876namespace a {
2877
2878class Foo : public ::android::Parcelable {
2879public:
Jooyung Han97945de2020-10-15 16:41:38 +09002880 inline bool operator!=(const Foo& rhs) const {
2881 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002882 }
Jooyung Han97945de2020-10-15 16:41:38 +09002883 inline bool operator<(const Foo& rhs) const {
2884 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002885 }
Jooyung Han97945de2020-10-15 16:41:38 +09002886 inline bool operator<=(const Foo& rhs) const {
2887 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002888 }
Jooyung Han97945de2020-10-15 16:41:38 +09002889 inline bool operator==(const Foo& rhs) const {
2890 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002891 }
Jooyung Han97945de2020-10-15 16:41:38 +09002892 inline bool operator>(const Foo& rhs) const {
2893 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002894 }
Jooyung Han97945de2020-10-15 16:41:38 +09002895 inline bool operator>=(const Foo& rhs) const {
2896 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002897 }
Jooyung Han97945de2020-10-15 16:41:38 +09002898
Jooyung Han1f14ab32020-10-14 13:48:29 +09002899 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09002900 ns = 0, // int[] ns;
2901 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002902 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002903 };
Jooyung Han97945de2020-10-15 16:41:38 +09002904
Jooyung Han1f14ab32020-10-14 13:48:29 +09002905 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09002906 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002907
2908 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09002909 Foo(const Foo&) = default;
2910 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002911 Foo& operator=(const Foo&) = default;
2912 Foo& operator=(Foo&&) = default;
2913
Jooyung Han97945de2020-10-15 16:41:38 +09002914 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
2915 constexpr Foo(_Tp&& _arg)
2916 : _value(std::forward<_Tp>(_arg)) {}
2917
2918 template <typename... _Tp>
2919 constexpr explicit Foo(_Tp&&... _args)
2920 : _value(std::forward<_Tp>(_args)...) {}
2921
2922 template <Tag _tag, typename... _Tp>
2923 static Foo make(_Tp&&... _args) {
2924 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002925 }
Jooyung Han97945de2020-10-15 16:41:38 +09002926
2927 template <Tag _tag, typename _Tp, typename... _Up>
2928 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
2929 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002930 }
2931
2932 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002933 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002934 }
2935
Jooyung Han97945de2020-10-15 16:41:38 +09002936 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002937 const auto& get() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002938 if (getTag() != _tag) { abort(); }
2939 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002940 }
2941
Jooyung Han97945de2020-10-15 16:41:38 +09002942 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002943 auto& get() {
Jooyung Han97945de2020-10-15 16:41:38 +09002944 if (getTag() != _tag) { abort(); }
2945 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002946 }
2947
Jooyung Han97945de2020-10-15 16:41:38 +09002948 template <Tag _tag, typename... _Tp>
2949 void set(_Tp&&... _args) {
2950 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002951 }
2952
2953 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
2954 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
2955 static const std::string& getParcelableDescriptor() {
2956 static const std::string DESCIPTOR = "a.Foo";
2957 return DESCIPTOR;
2958 }
2959private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09002960 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002961}; // class Foo
2962
2963} // namespace a
2964)";
2965
2966const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
2967
2968namespace a {
2969
2970::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
2971 ::android::status_t _aidl_ret_status;
2972 int32_t _aidl_tag;
2973 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
2974 switch (_aidl_tag) {
2975 case ns: {
2976 ::std::vector<int32_t> _aidl_value;
2977 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2978 set<ns>(std::move(_aidl_value));
2979 return ::android::OK; }
2980 case e: {
2981 ::a::ByteEnum _aidl_value;
2982 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
2983 set<e>(std::move(_aidl_value));
2984 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09002985 case pfd: {
2986 ::android::os::ParcelFileDescriptor _aidl_value;
2987 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
2988 set<pfd>(std::move(_aidl_value));
2989 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09002990 }
2991 return ::android::BAD_VALUE;
2992}
2993
2994::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
2995 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
2996 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
2997 switch (getTag()) {
2998 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
2999 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003000 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003001 }
3002 abort();
3003}
3004
3005} // namespace a
3006)";
3007
Jooyung Han6beac042020-10-17 21:59:43 +09003008const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3009#include <android/binder_interface_utils.h>
3010#include <android/binder_parcelable_utils.h>
3011
3012#include <type_traits>
3013#include <utility>
3014#include <variant>
3015#include <cstdint>
3016#include <memory>
3017#include <optional>
3018#include <string>
3019#include <vector>
3020#ifdef BINDER_STABILITY_SUPPORT
3021#include <android/binder_stability.h>
3022#endif // BINDER_STABILITY_SUPPORT
3023#include <aidl/a/ByteEnum.h>
3024namespace aidl {
3025namespace a {
3026class Foo {
3027public:
3028 typedef std::false_type fixed_size;
3029 static const char* descriptor;
3030
3031 enum Tag : int32_t {
3032 ns = 0, // int[] ns;
3033 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003034 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003035 };
3036
3037 template<typename _Tp>
3038 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3039
3040 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3041 Foo(const Foo&) = default;
3042 Foo(Foo&&) = default;
3043 Foo& operator=(const Foo&) = default;
3044 Foo& operator=(Foo&&) = default;
3045
3046 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
3047 constexpr Foo(_Tp&& _arg)
3048 : _value(std::forward<_Tp>(_arg)) {}
3049
3050 template <typename... _Tp>
3051 constexpr explicit Foo(_Tp&&... _args)
3052 : _value(std::forward<_Tp>(_args)...) {}
3053
3054 template <Tag _tag, typename... _Tp>
3055 static Foo make(_Tp&&... _args) {
3056 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3057 }
3058
3059 template <Tag _tag, typename _Tp, typename... _Up>
3060 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3061 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3062 }
3063
3064 Tag getTag() const {
3065 return static_cast<Tag>(_value.index());
3066 }
3067
3068 template <Tag _tag>
3069 const auto& get() const {
3070 if (getTag() != _tag) { abort(); }
3071 return std::get<_tag>(_value);
3072 }
3073
3074 template <Tag _tag>
3075 auto& get() {
3076 if (getTag() != _tag) { abort(); }
3077 return std::get<_tag>(_value);
3078 }
3079
3080 template <Tag _tag, typename... _Tp>
3081 void set(_Tp&&... _args) {
3082 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3083 }
3084
3085 binder_status_t readFromParcel(const AParcel* _parcel);
3086 binder_status_t writeToParcel(AParcel* _parcel) const;
3087 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
3088private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003089 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003090};
3091} // namespace a
3092} // namespace aidl
3093)";
3094
3095const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3096
3097#include <android/binder_parcel_utils.h>
3098
3099namespace aidl {
3100namespace a {
3101const char* Foo::descriptor = "a.Foo";
3102
3103binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3104 binder_status_t _aidl_ret_status;
3105 int32_t _aidl_tag;
3106 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3107 switch (_aidl_tag) {
3108 case ns: {
3109 std::vector<int32_t> _aidl_value;
3110 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3111 set<ns>(std::move(_aidl_value));
3112 return STATUS_OK; }
3113 case e: {
3114 ::aidl::a::ByteEnum _aidl_value;
3115 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
3116 set<e>(std::move(_aidl_value));
3117 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003118 case pfd: {
3119 ::ndk::ScopedFileDescriptor _aidl_value;
3120 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3121 set<pfd>(std::move(_aidl_value));
3122 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003123 }
3124 return STATUS_BAD_VALUE;
3125}
3126binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3127 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3128 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3129 switch (getTag()) {
3130 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3131 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003132 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003133 }
3134 abort();
3135}
3136
3137} // namespace a
3138} // namespace aidl
3139)";
3140
Jooyung Han1f14ab32020-10-14 13:48:29 +09003141const char kUnionExampleExpectedOutputJava[] = R"(/*
3142 * This file is auto-generated. DO NOT MODIFY.
3143 */
3144package a;
3145
3146
3147public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003148 // tags for union fields
3149 public final static int ns = 0; // int[] ns;
3150 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003151 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003152
3153 private int _tag;
3154 private Object _value;
3155
3156 public Foo() {
3157 int[] value = {42};
3158 _set(ns, value);
3159 }
Jooyung Han97945de2020-10-15 16:41:38 +09003160
Jooyung Han1f14ab32020-10-14 13:48:29 +09003161 private Foo(android.os.Parcel _aidl_parcel) {
3162 readFromParcel(_aidl_parcel);
3163 }
Jooyung Han97945de2020-10-15 16:41:38 +09003164
Jooyung Han1f14ab32020-10-14 13:48:29 +09003165 private Foo(int tag, Object value) {
3166 _set(tag, value);
3167 }
3168
3169 public int getTag() {
3170 return _tag;
3171 }
3172
Jooyung Han97945de2020-10-15 16:41:38 +09003173 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003174
3175 public static Foo ns(int[] _value) {
3176 return new Foo(ns, _value);
3177 }
Jooyung Han97945de2020-10-15 16:41:38 +09003178
Jooyung Han1f14ab32020-10-14 13:48:29 +09003179 public int[] getNs() {
3180 _assertTag(ns);
3181 return (int[]) _value;
3182 }
Jooyung Han97945de2020-10-15 16:41:38 +09003183
Jooyung Han1f14ab32020-10-14 13:48:29 +09003184 public void setNs(int[] _value) {
3185 _set(ns, _value);
3186 }
3187
Jooyung Han97945de2020-10-15 16:41:38 +09003188 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003189
3190 public static Foo e(byte _value) {
3191 return new Foo(e, _value);
3192 }
Jooyung Han97945de2020-10-15 16:41:38 +09003193
Jooyung Han1f14ab32020-10-14 13:48:29 +09003194 public byte getE() {
3195 _assertTag(e);
3196 return (byte) _value;
3197 }
Jooyung Han97945de2020-10-15 16:41:38 +09003198
Jooyung Han1f14ab32020-10-14 13:48:29 +09003199 public void setE(byte _value) {
3200 _set(e, _value);
3201 }
3202
Jooyung Hand2fa0232020-10-19 02:51:41 +09003203 // ParcelFileDescriptor pfd;
3204
3205 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3206 return new Foo(pfd, _value);
3207 }
3208
3209 public android.os.ParcelFileDescriptor getPfd() {
3210 _assertTag(pfd);
3211 return (android.os.ParcelFileDescriptor) _value;
3212 }
3213
3214 public void setPfd(android.os.ParcelFileDescriptor _value) {
3215 _set(pfd, _value);
3216 }
3217
Jooyung Han1f14ab32020-10-14 13:48:29 +09003218 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3219 @Override
3220 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003221 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003222 }
3223 @Override
3224 public Foo[] newArray(int _aidl_size) {
3225 return new Foo[_aidl_size];
3226 }
3227 };
Jooyung Han97945de2020-10-15 16:41:38 +09003228
Jooyung Han1f14ab32020-10-14 13:48:29 +09003229 @Override
3230 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3231 _aidl_parcel.writeInt(_tag);
3232 switch (_tag) {
3233 case ns:
3234 _aidl_parcel.writeIntArray(getNs());
3235 break;
3236 case e:
3237 _aidl_parcel.writeByte(getE());
3238 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003239 case pfd:
3240 if ((getPfd()!=null)) {
3241 _aidl_parcel.writeInt(1);
3242 getPfd().writeToParcel(_aidl_parcel, 0);
3243 }
3244 else {
3245 _aidl_parcel.writeInt(0);
3246 }
3247 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003248 }
3249 }
Jooyung Han97945de2020-10-15 16:41:38 +09003250
Jooyung Han1f14ab32020-10-14 13:48:29 +09003251 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3252 int _aidl_tag;
3253 _aidl_tag = _aidl_parcel.readInt();
3254 switch (_aidl_tag) {
3255 case ns: {
3256 int[] _aidl_value;
3257 _aidl_value = _aidl_parcel.createIntArray();
3258 _set(_aidl_tag, _aidl_value);
3259 return; }
3260 case e: {
3261 byte _aidl_value;
3262 _aidl_value = _aidl_parcel.readByte();
3263 _set(_aidl_tag, _aidl_value);
3264 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003265 case pfd: {
3266 android.os.ParcelFileDescriptor _aidl_value;
3267 if ((0!=_aidl_parcel.readInt())) {
3268 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3269 }
3270 else {
3271 _aidl_value = null;
3272 }
3273 _set(_aidl_tag, _aidl_value);
3274 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003275 }
3276 throw new RuntimeException("union: out of range: " + _aidl_tag);
3277 }
Jooyung Han97945de2020-10-15 16:41:38 +09003278
Jooyung Han1f14ab32020-10-14 13:48:29 +09003279 @Override
3280 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003281 int _mask = 0;
3282 switch (getTag()) {
3283 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003284 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003285 break;
3286 }
3287 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003288 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003289 private int describeContents(Object _v) {
3290 if (_v == null) return 0;
3291 if (_v instanceof android.os.Parcelable) {
3292 return ((android.os.Parcelable) _v).describeContents();
3293 }
3294 return 0;
3295 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003296
3297 private void _assertTag(int tag) {
3298 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003299 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003300 }
3301 }
Jooyung Han97945de2020-10-15 16:41:38 +09003302
Jooyung Han1f14ab32020-10-14 13:48:29 +09003303 private String _tagString(int _tag) {
3304 switch (_tag) {
3305 case ns: return "ns";
3306 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003307 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003308 }
3309 throw new IllegalStateException("unknown field: " + _tag);
3310 }
Jooyung Han97945de2020-10-15 16:41:38 +09003311
Jooyung Han1f14ab32020-10-14 13:48:29 +09003312 private void _set(int tag, Object value) {
3313 this._tag = tag;
3314 this._value = value;
3315 }
3316}
3317)";
3318
Jooyung Han97945de2020-10-15 16:41:38 +09003319struct AidlUnionTest : ::testing::Test {
3320 void SetUp() override {
3321 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003322package a;
3323import a.ByteEnum;
3324union Foo {
3325 int[] ns = {42};
3326 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003327 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003328}
3329)");
Jooyung Han97945de2020-10-15 16:41:38 +09003330 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003331package a;
3332@Backing(type="byte")
3333enum ByteEnum {
3334 a, b, c
3335}
3336)");
Jooyung Han97945de2020-10-15 16:41:38 +09003337 }
3338 FakeIoDelegate io_delegate_;
3339 void Compile(string lang) {
3340 string command = "aidl --structured -I. -o out --lang=" + lang;
3341 if (lang == "cpp" || lang == "ndk") {
3342 command += " -h out";
3343 }
3344 command += " a/Foo.aidl";
3345 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003346 CaptureStderr();
3347 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3348 auto err = GetCapturedStderr();
3349 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003350 }
3351 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3352 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003353 string actual;
3354 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3355 EXPECT_EQ(expected, actual);
3356 }
Jooyung Han97945de2020-10-15 16:41:38 +09003357 }
3358};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003359
Jooyung Han97945de2020-10-15 16:41:38 +09003360TEST_F(AidlUnionTest, Example_Cpp) {
3361 Compile("cpp");
3362 EXPECT_COMPILE_OUTPUTS(
3363 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3364 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3365}
3366
Jooyung Han6beac042020-10-17 21:59:43 +09003367TEST_F(AidlUnionTest, Example_Ndk) {
3368 Compile("ndk");
3369 EXPECT_COMPILE_OUTPUTS(
3370 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3371 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3372}
3373
Jooyung Han97945de2020-10-15 16:41:38 +09003374TEST_F(AidlUnionTest, Example_Java) {
3375 Compile("java");
3376 EXPECT_COMPILE_OUTPUTS(
3377 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003378 // TODO(b/170689477) Rust
3379}
3380
Jooyung Hanfe89f122020-10-14 03:49:18 +09003381TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3382 const string method = "package a; union Foo {}";
3383 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3384 CaptureStderr();
3385 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3386 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3387}
3388
3389TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3390 const string method = "package a; union Foo { ParcelableHolder x; }";
3391 const string expected_stderr =
3392 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3393 CaptureStderr();
3394 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3395 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3396}
3397
Devin Moore53fc99c2020-08-12 08:07:52 -07003398TEST_P(AidlTest, GenericStructuredParcelable) {
3399 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3400 Options options =
3401 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3402 const string expected_stderr = "";
3403 CaptureStderr();
3404 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3405 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3406}
3407
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003408TEST_F(AidlTest, NestedTypeArgs) {
3409 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
3410 io_delegate_.SetFileContents(
3411 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<Bar<String>> barss; }");
3412 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3413 const string expected_stderr = "";
3414 CaptureStderr();
3415 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3416 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3417
3418 string code;
3419 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
3420 EXPECT_THAT(code, testing::HasSubstr("a.Bar<a.Bar<java.lang.String>> barss;"));
3421}
3422
Jooyung Han14004ed2020-10-16 03:49:57 +09003423struct GenericAidlTest : ::testing::Test {
3424 FakeIoDelegate io_delegate_;
3425 void Compile(string cmd) {
3426 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux> > x; }");
3427 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3428 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3429 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3430
3431 Options options = Options::From(cmd);
3432 CaptureStderr();
3433 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3434 EXPECT_EQ("", GetCapturedStderr());
3435 }
3436};
3437
3438TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3439 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3440 string code;
3441 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3442 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3443 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3444 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3445}
3446
3447TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3448 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3449 string code;
3450 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3451 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3452 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3453 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3454}
3455
Devin Moore53fc99c2020-08-12 08:07:52 -07003456TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3457 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3458 Options options =
3459 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3460 const string expected_stderr =
3461 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3462 CaptureStderr();
3463 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3464 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3465}
3466
3467TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3468 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3469 Options options =
3470 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3471 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3472 CaptureStderr();
3473 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3474 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3475}
3476
Jooyung Hanea2147c2020-10-21 18:16:56 +09003477constexpr char kDescriptContentsWithUntypedListMapInJava[] = R"(
3478 @Override
3479 public int describeContents() {
3480 int _mask = 0;
3481 _mask |= describeContents(l);
3482 _mask |= describeContents(m);
3483 return _mask;
3484 }
3485 private int describeContents(Object _v) {
3486 if (_v == null) return 0;
3487 Class<?> _clazz = _v.getClass();
3488 if (_clazz.isArray() && _clazz.getComponentType() == Object.class) {
3489 int _mask = 0;
3490 for (Object o : (Object[]) _v) {
3491 _mask |= describeContents(o);
3492 }
3493 return _mask;
3494 }
3495 if (_v instanceof java.io.FileDescriptor) {
3496 return android.os.Parcelable.CONTENTS_FILE_DESCRIPTOR;
3497 }
3498 if (_v instanceof java.util.Collection) {
3499 int _mask = 0;
3500 for (Object o : (java.util.Collection) _v) {
3501 _mask |= describeContents(o);
3502 }
3503 return _mask;
3504 }
3505 if (_v instanceof java.util.Map) {
3506 return describeContents(((java.util.Map) _v).values());
3507 }
3508 if (_v instanceof android.os.Parcelable) {
3509 return ((android.os.Parcelable) _v).describeContents();
3510 }
3511 if (_v instanceof android.util.SparseArray) {
3512 android.util.SparseArray _sa = (android.util.SparseArray) _v;
3513 int _mask = 0;
3514 int _N = _sa.size();
3515 int _i = 0;
3516 while (_i < _N) {
3517 _mask |= describeContents(_sa.valueAt(_i));
3518 _i++;
3519 }
3520 return _mask;
3521 }
3522 return 0;
3523 }
3524)";
3525TEST_F(AidlTest, SupportUntypeListAndMap) {
3526 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3527 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3528 CaptureStderr();
3529 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3530 EXPECT_EQ("", GetCapturedStderr());
3531
3532 string code;
3533 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
3534 EXPECT_THAT(code, testing::HasSubstr(kDescriptContentsWithUntypedListMapInJava));
3535}
3536
Christopher Wiley90be4e32015-10-20 14:55:25 -07003537} // namespace aidl
3538} // namespace android