blob: 2bc21292b137e25bc804363af6b24835cc43728c [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Chris Lattner2188e402010-01-04 07:37:31 +00006//
7//===----------------------------------------------------------------------===//
8//
9// This file implements the visitICmp and visitFCmp functions.
10//
11//===----------------------------------------------------------------------===//
12
Chandler Carrutha9174582015-01-22 05:25:13 +000013#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000014#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000015#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000016#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000017#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000018#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000019#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000020#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000021#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000022#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000023#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000024#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000025#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000026#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000027
Chris Lattner2188e402010-01-04 07:37:31 +000028using namespace llvm;
29using namespace PatternMatch;
30
Chandler Carruth964daaa2014-04-22 02:55:47 +000031#define DEBUG_TYPE "instcombine"
32
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000033// How many times is a select replaced by one of its operands?
34STATISTIC(NumSel, "Number of select opts");
35
Chris Lattner98457102011-02-10 05:23:05 +000036
Sanjay Patel5f0217f2016-06-05 16:46:18 +000037/// Compute Result = In1+In2, returning true if the result overflowed for this
38/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000039static bool addWithOverflow(APInt &Result, const APInt &In1,
40 const APInt &In2, bool IsSigned = false) {
41 bool Overflow;
42 if (IsSigned)
43 Result = In1.sadd_ov(In2, Overflow);
44 else
45 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000046
Craig Topper6e025a32017-10-01 23:53:54 +000047 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000048}
49
Sanjay Patel5f0217f2016-06-05 16:46:18 +000050/// Compute Result = In1-In2, returning true if the result overflowed for this
51/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000052static bool subWithOverflow(APInt &Result, const APInt &In1,
53 const APInt &In2, bool IsSigned = false) {
54 bool Overflow;
55 if (IsSigned)
56 Result = In1.ssub_ov(In2, Overflow);
57 else
58 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000059
Craig Topper6e025a32017-10-01 23:53:54 +000060 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000061}
62
Balaram Makam569eaec2016-05-04 21:32:14 +000063/// Given an icmp instruction, return true if any use of this comparison is a
64/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000065static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000066 for (auto *U : I.users())
67 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000068 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000069 return false;
70}
71
Sanjay Patel5f0217f2016-06-05 16:46:18 +000072/// Given an exploded icmp instruction, return true if the comparison only
73/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
74/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000075static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000076 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000077 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000078 case ICmpInst::ICMP_SLT: // True if LHS s< 0
79 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000080 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000081 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
82 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000083 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000084 case ICmpInst::ICMP_SGT: // True if LHS s> -1
85 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000086 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000087 case ICmpInst::ICMP_UGT:
88 // True if LHS u> RHS and RHS == high-bit-mask - 1
89 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000090 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000091 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000092 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
93 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000094 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000095 default:
96 return false;
97 }
98}
99
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000100/// Returns true if the exploded icmp can be expressed as a signed comparison
101/// to zero and updates the predicate accordingly.
102/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000103/// TODO: Refactor with decomposeBitTestICmp()?
104static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000105 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000106 return false;
107
Craig Topper73ba1c82017-06-07 07:40:37 +0000108 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000109 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000110
Craig Topper73ba1c82017-06-07 07:40:37 +0000111 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000112 if (Pred == ICmpInst::ICMP_SLT) {
113 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000114 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000116 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000117 if (Pred == ICmpInst::ICMP_SGT) {
118 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000119 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000121 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000122
123 return false;
124}
125
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000126/// Given a signed integer type and a set of known zero and one bits, compute
127/// the maximum and minimum values that could have the specified known zero and
128/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000129/// TODO: Move to method on KnownBits struct?
130static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000131 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000132 assert(Known.getBitWidth() == Min.getBitWidth() &&
133 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000134 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000135 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000136
137 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
138 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000139 Min = Known.One;
140 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000141
Chris Lattner2188e402010-01-04 07:37:31 +0000142 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000143 Min.setSignBit();
144 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000145 }
146}
147
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000148/// Given an unsigned integer type and a set of known zero and one bits, compute
149/// the maximum and minimum values that could have the specified known zero and
150/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000151/// TODO: Move to method on KnownBits struct?
152static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000153 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000154 assert(Known.getBitWidth() == Min.getBitWidth() &&
155 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000156 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000157 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000158
Chris Lattner2188e402010-01-04 07:37:31 +0000159 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000160 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000161 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000162 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000163}
164
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000165/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000166/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000167/// where GV is a global variable with a constant initializer. Try to simplify
168/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000169/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
170///
171/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000172/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000173Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
174 GlobalVariable *GV,
175 CmpInst &ICI,
176 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000177 Constant *Init = GV->getInitializer();
178 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000179 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000180
Chris Lattnerfe741762012-01-31 02:55:06 +0000181 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000182 // Don't blow up on huge arrays.
183 if (ArrayElementCount > MaxArraySizeForCombine)
184 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000185
Chris Lattner2188e402010-01-04 07:37:31 +0000186 // There are many forms of this optimization we can handle, for now, just do
187 // the simple index into a single-dimensional array.
188 //
189 // Require: GEP GV, 0, i {{, constant indices}}
190 if (GEP->getNumOperands() < 3 ||
191 !isa<ConstantInt>(GEP->getOperand(1)) ||
192 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
193 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000194 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000195
196 // Check that indices after the variable are constants and in-range for the
197 // type they index. Collect the indices. This is typically for arrays of
198 // structs.
199 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000200
Chris Lattnerfe741762012-01-31 02:55:06 +0000201 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000202 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
203 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000204 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000205
Chris Lattner2188e402010-01-04 07:37:31 +0000206 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000207 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner229907c2011-07-18 04:54:35 +0000209 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000210 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000211 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000212 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000213 EltTy = ATy->getElementType();
214 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000215 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000216 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000217
Chris Lattner2188e402010-01-04 07:37:31 +0000218 LaterIndices.push_back(IdxVal);
219 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000220
Chris Lattner2188e402010-01-04 07:37:31 +0000221 enum { Overdefined = -3, Undefined = -2 };
222
223 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000224
Chris Lattner2188e402010-01-04 07:37:31 +0000225 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
226 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
227 // and 87 is the second (and last) index. FirstTrueElement is -2 when
228 // undefined, otherwise set to the first true element. SecondTrueElement is
229 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
230 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
231
232 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
233 // form "i != 47 & i != 87". Same state transitions as for true elements.
234 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000235
Chris Lattner2188e402010-01-04 07:37:31 +0000236 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
237 /// define a state machine that triggers for ranges of values that the index
238 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
239 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
240 /// index in the range (inclusive). We use -2 for undefined here because we
241 /// use relative comparisons and don't want 0-1 to match -1.
242 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000243
Chris Lattner2188e402010-01-04 07:37:31 +0000244 // MagicBitvector - This is a magic bitvector where we set a bit if the
245 // comparison is true for element 'i'. If there are 64 elements or less in
246 // the array, this will fully represent all the comparison results.
247 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000248
Chris Lattner2188e402010-01-04 07:37:31 +0000249 // Scan the array and see if one of our patterns matches.
250 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000251 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
252 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000253 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000254
Chris Lattner2188e402010-01-04 07:37:31 +0000255 // If this is indexing an array of structures, get the structure element.
256 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000257 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000258
Chris Lattner2188e402010-01-04 07:37:31 +0000259 // If the element is masked, handle it.
260 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000261
Chris Lattner2188e402010-01-04 07:37:31 +0000262 // Find out if the comparison would be true or false for the i'th element.
263 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000264 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000265 // If the result is undef for this element, ignore it.
266 if (isa<UndefValue>(C)) {
267 // Extend range state machines to cover this element in case there is an
268 // undef in the middle of the range.
269 if (TrueRangeEnd == (int)i-1)
270 TrueRangeEnd = i;
271 if (FalseRangeEnd == (int)i-1)
272 FalseRangeEnd = i;
273 continue;
274 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000275
Chris Lattner2188e402010-01-04 07:37:31 +0000276 // If we can't compute the result for any of the elements, we have to give
277 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000278 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000279
Chris Lattner2188e402010-01-04 07:37:31 +0000280 // Otherwise, we know if the comparison is true or false for this element,
281 // update our state machines.
282 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000283
Chris Lattner2188e402010-01-04 07:37:31 +0000284 // State machine for single/double/range index comparison.
285 if (IsTrueForElt) {
286 // Update the TrueElement state machine.
287 if (FirstTrueElement == Undefined)
288 FirstTrueElement = TrueRangeEnd = i; // First true element.
289 else {
290 // Update double-compare state machine.
291 if (SecondTrueElement == Undefined)
292 SecondTrueElement = i;
293 else
294 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000295
Chris Lattner2188e402010-01-04 07:37:31 +0000296 // Update range state machine.
297 if (TrueRangeEnd == (int)i-1)
298 TrueRangeEnd = i;
299 else
300 TrueRangeEnd = Overdefined;
301 }
302 } else {
303 // Update the FalseElement state machine.
304 if (FirstFalseElement == Undefined)
305 FirstFalseElement = FalseRangeEnd = i; // First false element.
306 else {
307 // Update double-compare state machine.
308 if (SecondFalseElement == Undefined)
309 SecondFalseElement = i;
310 else
311 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000312
Chris Lattner2188e402010-01-04 07:37:31 +0000313 // Update range state machine.
314 if (FalseRangeEnd == (int)i-1)
315 FalseRangeEnd = i;
316 else
317 FalseRangeEnd = Overdefined;
318 }
319 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000320
Chris Lattner2188e402010-01-04 07:37:31 +0000321 // If this element is in range, update our magic bitvector.
322 if (i < 64 && IsTrueForElt)
323 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000324
Chris Lattner2188e402010-01-04 07:37:31 +0000325 // If all of our states become overdefined, bail out early. Since the
326 // predicate is expensive, only check it every 8 elements. This is only
327 // really useful for really huge arrays.
328 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
329 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
330 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000331 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000332 }
333
334 // Now that we've scanned the entire array, emit our new comparison(s). We
335 // order the state machines in complexity of the generated code.
336 Value *Idx = GEP->getOperand(2);
337
Matt Arsenault5aeae182013-08-19 21:40:31 +0000338 // If the index is larger than the pointer size of the target, truncate the
339 // index down like the GEP would do implicitly. We don't have to do this for
340 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000341 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000342 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000343 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
344 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000345 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000346 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000347
Chris Lattner2188e402010-01-04 07:37:31 +0000348 // If the comparison is only true for one or two elements, emit direct
349 // comparisons.
350 if (SecondTrueElement != Overdefined) {
351 // None true -> false.
352 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000353 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000354
Chris Lattner2188e402010-01-04 07:37:31 +0000355 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000356
Chris Lattner2188e402010-01-04 07:37:31 +0000357 // True for one element -> 'i == 47'.
358 if (SecondTrueElement == Undefined)
359 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000360
Chris Lattner2188e402010-01-04 07:37:31 +0000361 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000362 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000363 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000364 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000365 return BinaryOperator::CreateOr(C1, C2);
366 }
367
368 // If the comparison is only false for one or two elements, emit direct
369 // comparisons.
370 if (SecondFalseElement != Overdefined) {
371 // None false -> true.
372 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000373 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000374
Chris Lattner2188e402010-01-04 07:37:31 +0000375 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
376
377 // False for one element -> 'i != 47'.
378 if (SecondFalseElement == Undefined)
379 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000380
Chris Lattner2188e402010-01-04 07:37:31 +0000381 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000382 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000383 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000384 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000385 return BinaryOperator::CreateAnd(C1, C2);
386 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000387
Chris Lattner2188e402010-01-04 07:37:31 +0000388 // If the comparison can be replaced with a range comparison for the elements
389 // where it is true, emit the range check.
390 if (TrueRangeEnd != Overdefined) {
391 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000392
Chris Lattner2188e402010-01-04 07:37:31 +0000393 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
394 if (FirstTrueElement) {
395 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000396 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000397 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000398
Chris Lattner2188e402010-01-04 07:37:31 +0000399 Value *End = ConstantInt::get(Idx->getType(),
400 TrueRangeEnd-FirstTrueElement+1);
401 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
402 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000403
Chris Lattner2188e402010-01-04 07:37:31 +0000404 // False range check.
405 if (FalseRangeEnd != Overdefined) {
406 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
407 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
408 if (FirstFalseElement) {
409 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000410 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000411 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000412
Chris Lattner2188e402010-01-04 07:37:31 +0000413 Value *End = ConstantInt::get(Idx->getType(),
414 FalseRangeEnd-FirstFalseElement);
415 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
416 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000417
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000418 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000419 // of this load, replace it with computation that does:
420 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000421 {
Craig Topperf40110f2014-04-25 05:29:35 +0000422 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000423
424 // Look for an appropriate type:
425 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000426 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000427 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
428 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000429 else
430 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000431
Craig Topperf40110f2014-04-25 05:29:35 +0000432 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000433 Value *V = Builder.CreateIntCast(Idx, Ty, false);
434 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
435 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000436 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
437 }
Chris Lattner2188e402010-01-04 07:37:31 +0000438 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000439
Craig Topperf40110f2014-04-25 05:29:35 +0000440 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000441}
442
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000443/// Return a value that can be used to compare the *offset* implied by a GEP to
444/// zero. For example, if we have &A[i], we want to return 'i' for
445/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
446/// are involved. The above expression would also be legal to codegen as
447/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
448/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000449/// to generate the first by knowing that pointer arithmetic doesn't overflow.
450///
451/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000452///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000453static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000454 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000455 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000456
Chris Lattner2188e402010-01-04 07:37:31 +0000457 // Check to see if this gep only has a single variable index. If so, and if
458 // any constant indices are a multiple of its scale, then we can compute this
459 // in terms of the scale of the variable index. For example, if the GEP
460 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
461 // because the expression will cross zero at the same point.
462 unsigned i, e = GEP->getNumOperands();
463 int64_t Offset = 0;
464 for (i = 1; i != e; ++i, ++GTI) {
465 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
466 // Compute the aggregate offset of constant indices.
467 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000468
Chris Lattner2188e402010-01-04 07:37:31 +0000469 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000470 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000471 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000472 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000473 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000474 Offset += Size*CI->getSExtValue();
475 }
476 } else {
477 // Found our variable index.
478 break;
479 }
480 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000481
Chris Lattner2188e402010-01-04 07:37:31 +0000482 // If there are no variable indices, we must have a constant offset, just
483 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000484 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000485
Chris Lattner2188e402010-01-04 07:37:31 +0000486 Value *VariableIdx = GEP->getOperand(i);
487 // Determine the scale factor of the variable element. For example, this is
488 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000489 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000490
Chris Lattner2188e402010-01-04 07:37:31 +0000491 // Verify that there are no other variable indices. If so, emit the hard way.
492 for (++i, ++GTI; i != e; ++i, ++GTI) {
493 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000494 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000495
Chris Lattner2188e402010-01-04 07:37:31 +0000496 // Compute the aggregate offset of constant indices.
497 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000498
Chris Lattner2188e402010-01-04 07:37:31 +0000499 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000500 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000501 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000502 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000503 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000504 Offset += Size*CI->getSExtValue();
505 }
506 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000507
Chris Lattner2188e402010-01-04 07:37:31 +0000508 // Okay, we know we have a single variable index, which must be a
509 // pointer/array/vector index. If there is no offset, life is simple, return
510 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000511 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000512 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000513 if (Offset == 0) {
514 // Cast to intptrty in case a truncation occurs. If an extension is needed,
515 // we don't need to bother extending: the extension won't affect where the
516 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000517 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000518 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000519 }
Chris Lattner2188e402010-01-04 07:37:31 +0000520 return VariableIdx;
521 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000522
Chris Lattner2188e402010-01-04 07:37:31 +0000523 // Otherwise, there is an index. The computation we will do will be modulo
Nikita Popov36e03ac2018-12-12 23:19:03 +0000524 // the pointer size.
525 Offset = SignExtend64(Offset, IntPtrWidth);
526 VariableScale = SignExtend64(VariableScale, IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 // To do this transformation, any constant index must be a multiple of the
529 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
530 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
531 // multiple of the variable scale.
532 int64_t NewOffs = Offset / (int64_t)VariableScale;
533 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000534 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000535
Chris Lattner2188e402010-01-04 07:37:31 +0000536 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000537 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000538 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000539 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000540 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000542}
543
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000544/// Returns true if we can rewrite Start as a GEP with pointer Base
545/// and some integer offset. The nodes that need to be re-written
546/// for this transformation will be added to Explored.
547static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
548 const DataLayout &DL,
549 SetVector<Value *> &Explored) {
550 SmallVector<Value *, 16> WorkList(1, Start);
551 Explored.insert(Base);
552
553 // The following traversal gives us an order which can be used
554 // when doing the final transformation. Since in the final
555 // transformation we create the PHI replacement instructions first,
556 // we don't have to get them in any particular order.
557 //
558 // However, for other instructions we will have to traverse the
559 // operands of an instruction first, which means that we have to
560 // do a post-order traversal.
561 while (!WorkList.empty()) {
562 SetVector<PHINode *> PHIs;
563
564 while (!WorkList.empty()) {
565 if (Explored.size() >= 100)
566 return false;
567
568 Value *V = WorkList.back();
569
570 if (Explored.count(V) != 0) {
571 WorkList.pop_back();
572 continue;
573 }
574
575 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000576 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000577 // We've found some value that we can't explore which is different from
578 // the base. Therefore we can't do this transformation.
579 return false;
580
581 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
582 auto *CI = dyn_cast<CastInst>(V);
583 if (!CI->isNoopCast(DL))
584 return false;
585
586 if (Explored.count(CI->getOperand(0)) == 0)
587 WorkList.push_back(CI->getOperand(0));
588 }
589
590 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
591 // We're limiting the GEP to having one index. This will preserve
592 // the original pointer type. We could handle more cases in the
593 // future.
594 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
595 GEP->getType() != Start->getType())
596 return false;
597
598 if (Explored.count(GEP->getOperand(0)) == 0)
599 WorkList.push_back(GEP->getOperand(0));
600 }
601
602 if (WorkList.back() == V) {
603 WorkList.pop_back();
604 // We've finished visiting this node, mark it as such.
605 Explored.insert(V);
606 }
607
608 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000609 // We cannot transform PHIs on unsplittable basic blocks.
610 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
611 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000612 Explored.insert(PN);
613 PHIs.insert(PN);
614 }
615 }
616
617 // Explore the PHI nodes further.
618 for (auto *PN : PHIs)
619 for (Value *Op : PN->incoming_values())
620 if (Explored.count(Op) == 0)
621 WorkList.push_back(Op);
622 }
623
624 // Make sure that we can do this. Since we can't insert GEPs in a basic
625 // block before a PHI node, we can't easily do this transformation if
626 // we have PHI node users of transformed instructions.
627 for (Value *Val : Explored) {
628 for (Value *Use : Val->uses()) {
629
630 auto *PHI = dyn_cast<PHINode>(Use);
631 auto *Inst = dyn_cast<Instruction>(Val);
632
633 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
634 Explored.count(PHI) == 0)
635 continue;
636
637 if (PHI->getParent() == Inst->getParent())
638 return false;
639 }
640 }
641 return true;
642}
643
644// Sets the appropriate insert point on Builder where we can add
645// a replacement Instruction for V (if that is possible).
646static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
647 bool Before = true) {
648 if (auto *PHI = dyn_cast<PHINode>(V)) {
649 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
650 return;
651 }
652 if (auto *I = dyn_cast<Instruction>(V)) {
653 if (!Before)
654 I = &*std::next(I->getIterator());
655 Builder.SetInsertPoint(I);
656 return;
657 }
658 if (auto *A = dyn_cast<Argument>(V)) {
659 // Set the insertion point in the entry block.
660 BasicBlock &Entry = A->getParent()->getEntryBlock();
661 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
662 return;
663 }
664 // Otherwise, this is a constant and we don't need to set a new
665 // insertion point.
666 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
667}
668
669/// Returns a re-written value of Start as an indexed GEP using Base as a
670/// pointer.
671static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
672 const DataLayout &DL,
673 SetVector<Value *> &Explored) {
674 // Perform all the substitutions. This is a bit tricky because we can
675 // have cycles in our use-def chains.
676 // 1. Create the PHI nodes without any incoming values.
677 // 2. Create all the other values.
678 // 3. Add the edges for the PHI nodes.
679 // 4. Emit GEPs to get the original pointers.
680 // 5. Remove the original instructions.
681 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000682 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000683
684 DenseMap<Value *, Value *> NewInsts;
685 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
686
687 // Create the new PHI nodes, without adding any incoming values.
688 for (Value *Val : Explored) {
689 if (Val == Base)
690 continue;
691 // Create empty phi nodes. This avoids cyclic dependencies when creating
692 // the remaining instructions.
693 if (auto *PHI = dyn_cast<PHINode>(Val))
694 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
695 PHI->getName() + ".idx", PHI);
696 }
697 IRBuilder<> Builder(Base->getContext());
698
699 // Create all the other instructions.
700 for (Value *Val : Explored) {
701
702 if (NewInsts.find(Val) != NewInsts.end())
703 continue;
704
705 if (auto *CI = dyn_cast<CastInst>(Val)) {
Martin Storsjo0fe645c2019-05-30 20:53:21 +0000706 // Don't get rid of the intermediate variable here; the store can grow
707 // the map which will invalidate the reference to the input value.
708 Value *V = NewInsts[CI->getOperand(0)];
709 NewInsts[CI] = V;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
835 if (!GEPLHS->hasAllConstantIndices())
836 return nullptr;
837
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000838 // Make sure the pointers have the same type.
839 if (GEPLHS->getType() != RHS->getType())
840 return nullptr;
841
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000842 Value *PtrBase, *Index;
843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
844
845 // The set of nodes that will take part in this transformation.
846 SetVector<Value *> Nodes;
847
848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
849 return nullptr;
850
851 // We know we can re-write this as
852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
853 // Since we've only looked through inbouds GEPs we know that we
854 // can't have overflow on either side. We can therefore re-write
855 // this as:
856 // OFFSET1 cmp OFFSET2
857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
858
859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
861 // offset. Since Index is the offset of LHS to the base pointer, we will now
862 // compare the offsets instead of comparing the pointers.
863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
864}
865
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000866/// Fold comparisons between a GEP instruction and something else. At this point
867/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000868Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000869 ICmpInst::Predicate Cond,
870 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000871 // Don't transform signed compares of GEPs into index compares. Even if the
872 // GEP is inbounds, the final add of the base pointer can have signed overflow
873 // and would change the result of the icmp.
874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000875 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000876 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000877 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000878
Matt Arsenault44f60d02014-06-09 19:20:29 +0000879 // Look through bitcasts and addrspacecasts. We do not however want to remove
880 // 0 GEPs.
881 if (!isa<GetElementPtrInst>(RHS))
882 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000883
884 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000885 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
887 // This transformation (ignoring the base and scales) is valid because we
888 // know pointers can't overflow since the gep is inbounds. See if we can
889 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000891
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000893 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000894 Offset = EmitGEPOffset(GEPLHS);
895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
896 Constant::getNullValue(Offset->getType()));
Philip Reames5b02cfa2019-08-23 17:58:58 +0000897 } else if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) &&
898 GEPLHS->getType()->isPointerTy() && // TODO: extend to vector geps
899 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() &&
900 !NullPointerIsDefined(I.getFunction(),
901 RHS->getType()->getPointerAddressSpace())) {
902 // For most address spaces, an allocation can't be placed at null, but null
903 // itself is treated as a 0 size allocation in the in bounds rules. Thus,
904 // the only valid inbounds address derived from null, is null itself.
905 // Thus, we have four cases to consider:
906 // 1) Base == nullptr, Offset == 0 -> inbounds, null
907 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds
908 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations)
909 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison)
910 //
911 // (Note if we're indexing a type of size 0, that simply collapses into one
912 // of the buckets above.)
913 //
914 // In general, we're allowed to make values less poison (i.e. remove
915 // sources of full UB), so in this case, we just select between the two
916 // non-poison cases (1 and 4 above).
917 return new ICmpInst(Cond, GEPLHS->getPointerOperand(), RHS);
Chris Lattner2188e402010-01-04 07:37:31 +0000918 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
919 // If the base pointers are different, but the indices are the same, just
920 // compare the base pointer.
921 if (PtrBase != GEPRHS->getOperand(0)) {
922 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
923 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
924 GEPRHS->getOperand(0)->getType();
925 if (IndicesTheSame)
926 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
927 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
928 IndicesTheSame = false;
929 break;
930 }
931
932 // If all indices are the same, just compare the base pointers.
Jesper Antonssonc954b862018-10-01 14:59:25 +0000933 Type *BaseType = GEPLHS->getOperand(0)->getType();
934 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType())
David Majnemer5953d372013-06-29 10:28:04 +0000935 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000936
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000937 // If we're comparing GEPs with two base pointers that only differ in type
938 // and both GEPs have only constant indices or just one use, then fold
939 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000940 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000941 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
942 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
943 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000944 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000945 Value *LOffset = EmitGEPOffset(GEPLHS);
946 Value *ROffset = EmitGEPOffset(GEPRHS);
947
948 // If we looked through an addrspacecast between different sized address
949 // spaces, the LHS and RHS pointers are different sized
950 // integers. Truncate to the smaller one.
951 Type *LHSIndexTy = LOffset->getType();
952 Type *RHSIndexTy = ROffset->getType();
953 if (LHSIndexTy != RHSIndexTy) {
954 if (LHSIndexTy->getPrimitiveSizeInBits() <
955 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000956 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000957 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000958 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000959 }
960
Craig Topperbb4069e2017-07-07 23:16:26 +0000961 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
962 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000963 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000964 }
965
Chris Lattner2188e402010-01-04 07:37:31 +0000966 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000967 // different. Try convert this to an indexed compare by looking through
968 // PHIs/casts.
969 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000970 }
971
972 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000973 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000974 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000975 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000976
977 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000978 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000979 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000980
Stuart Hastings66a82b92011-05-14 05:55:10 +0000981 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000982 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
983 // If the GEPs only differ by one index, compare it.
984 unsigned NumDifferences = 0; // Keep track of # differences.
985 unsigned DiffOperand = 0; // The operand that differs.
986 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
987 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
988 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
989 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
990 // Irreconcilable differences.
991 NumDifferences = 2;
992 break;
993 } else {
994 if (NumDifferences++) break;
995 DiffOperand = i;
996 }
997 }
998
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +0000999 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +00001000 return replaceInstUsesWith(I, // No comparison is needed here.
Jesper Antonsson719fa052018-09-20 13:37:28 +00001001 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +00001002
Stuart Hastings66a82b92011-05-14 05:55:10 +00001003 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +00001004 Value *LHSV = GEPLHS->getOperand(DiffOperand);
1005 Value *RHSV = GEPRHS->getOperand(DiffOperand);
1006 // Make sure we do a signed comparison here.
1007 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
1008 }
1009 }
1010
1011 // Only lower this if the icmp is the only user of the GEP or if we expect
1012 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001013 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +00001014 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
1015 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
1016 Value *L = EmitGEPOffset(GEPLHS);
1017 Value *R = EmitGEPOffset(GEPRHS);
1018 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
1019 }
1020 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001021
1022 // Try convert this to an indexed compare by looking through PHIs/casts as a
1023 // last resort.
1024 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001025}
1026
Pete Cooper980a9352016-08-12 17:13:28 +00001027Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1028 const AllocaInst *Alloca,
1029 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001030 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1031
1032 // It would be tempting to fold away comparisons between allocas and any
1033 // pointer not based on that alloca (e.g. an argument). However, even
1034 // though such pointers cannot alias, they can still compare equal.
1035 //
1036 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1037 // doesn't escape we can argue that it's impossible to guess its value, and we
1038 // can therefore act as if any such guesses are wrong.
1039 //
1040 // The code below checks that the alloca doesn't escape, and that it's only
1041 // used in a comparison once (the current instruction). The
1042 // single-comparison-use condition ensures that we're trivially folding all
1043 // comparisons against the alloca consistently, and avoids the risk of
1044 // erroneously folding a comparison of the pointer with itself.
1045
1046 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1047
Pete Cooper980a9352016-08-12 17:13:28 +00001048 SmallVector<const Use *, 32> Worklist;
1049 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001050 if (Worklist.size() >= MaxIter)
1051 return nullptr;
1052 Worklist.push_back(&U);
1053 }
1054
1055 unsigned NumCmps = 0;
1056 while (!Worklist.empty()) {
1057 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001058 const Use *U = Worklist.pop_back_val();
1059 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001060 --MaxIter;
1061
1062 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1063 isa<SelectInst>(V)) {
1064 // Track the uses.
1065 } else if (isa<LoadInst>(V)) {
1066 // Loading from the pointer doesn't escape it.
1067 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001068 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001069 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1070 if (SI->getValueOperand() == U->get())
1071 return nullptr;
1072 continue;
1073 } else if (isa<ICmpInst>(V)) {
1074 if (NumCmps++)
1075 return nullptr; // Found more than one cmp.
1076 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001077 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001078 switch (Intrin->getIntrinsicID()) {
1079 // These intrinsics don't escape or compare the pointer. Memset is safe
1080 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1081 // we don't allow stores, so src cannot point to V.
1082 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001083 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1084 continue;
1085 default:
1086 return nullptr;
1087 }
1088 } else {
1089 return nullptr;
1090 }
Pete Cooper980a9352016-08-12 17:13:28 +00001091 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001092 if (Worklist.size() >= MaxIter)
1093 return nullptr;
1094 Worklist.push_back(&U);
1095 }
1096 }
1097
1098 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001099 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001100 ICI,
1101 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1102}
1103
Craig Topperbee74792018-08-20 23:04:25 +00001104/// Fold "icmp pred (X+C), X".
1105Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001106 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001107 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001108 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001109 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001110 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001111
Chris Lattner8c92b572010-01-08 17:48:19 +00001112 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001113 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1114 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1115 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001116 Constant *R = ConstantInt::get(X->getType(),
1117 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001118 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1119 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001120
Chris Lattner2188e402010-01-04 07:37:31 +00001121 // (X+1) >u X --> X <u (0-1) --> X != 255
1122 // (X+2) >u X --> X <u (0-2) --> X <u 254
1123 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001124 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001125 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1126 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001127
Craig Topperbee74792018-08-20 23:04:25 +00001128 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001129
1130 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1131 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1132 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1133 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1134 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1135 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001136 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001137 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1138 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001139
Chris Lattner2188e402010-01-04 07:37:31 +00001140 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1141 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1142 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1143 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1144 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1145 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001146
Chris Lattner2188e402010-01-04 07:37:31 +00001147 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001148 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1149 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001150}
1151
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001152/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1153/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1154/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1155Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1156 const APInt &AP1,
1157 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001158 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1159
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001160 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1161 if (I.getPredicate() == I.ICMP_NE)
1162 Pred = CmpInst::getInversePredicate(Pred);
1163 return new ICmpInst(Pred, LHS, RHS);
1164 };
1165
David Majnemer2abb8182014-10-25 07:13:13 +00001166 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001167 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001168 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001169
1170 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001171 if (IsAShr) {
1172 if (AP2.isAllOnesValue())
1173 return nullptr;
1174 if (AP2.isNegative() != AP1.isNegative())
1175 return nullptr;
1176 if (AP2.sgt(AP1))
1177 return nullptr;
1178 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001179
David Majnemerd2056022014-10-21 19:51:55 +00001180 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001181 // 'A' must be large enough to shift out the highest set bit.
1182 return getICmp(I.ICMP_UGT, A,
1183 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001184
David Majnemerd2056022014-10-21 19:51:55 +00001185 if (AP1 == AP2)
1186 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001187
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001188 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001189 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001190 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001191 else
David Majnemere5977eb2015-09-19 00:48:26 +00001192 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001193
David Majnemerd2056022014-10-21 19:51:55 +00001194 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001195 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1196 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001197 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001198 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1199 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001200 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001201 } else if (AP1 == AP2.lshr(Shift)) {
1202 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1203 }
David Majnemerd2056022014-10-21 19:51:55 +00001204 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001205
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001206 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001207 // FIXME: This should always be handled by InstSimplify?
1208 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1209 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001210}
Chris Lattner2188e402010-01-04 07:37:31 +00001211
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001212/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1213/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1214Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1215 const APInt &AP1,
1216 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001217 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1218
David Majnemer59939ac2014-10-19 08:23:08 +00001219 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1220 if (I.getPredicate() == I.ICMP_NE)
1221 Pred = CmpInst::getInversePredicate(Pred);
1222 return new ICmpInst(Pred, LHS, RHS);
1223 };
1224
David Majnemer2abb8182014-10-25 07:13:13 +00001225 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001226 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001227 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001228
1229 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1230
1231 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001232 return getICmp(
1233 I.ICMP_UGE, A,
1234 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001235
1236 if (AP1 == AP2)
1237 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1238
1239 // Get the distance between the lowest bits that are set.
1240 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1241
1242 if (Shift > 0 && AP2.shl(Shift) == AP1)
1243 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1244
1245 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001246 // FIXME: This should always be handled by InstSimplify?
1247 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1248 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001249}
1250
Sanjay Patel06b127a2016-09-15 14:37:50 +00001251/// The caller has matched a pattern of the form:
1252/// I = icmp ugt (add (add A, B), CI2), CI1
1253/// If this is of the form:
1254/// sum = a + b
1255/// if (sum+128 >u 255)
1256/// Then replace it with llvm.sadd.with.overflow.i8.
1257///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001258static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001259 ConstantInt *CI2, ConstantInt *CI1,
1260 InstCombiner &IC) {
1261 // The transformation we're trying to do here is to transform this into an
1262 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1263 // with a narrower add, and discard the add-with-constant that is part of the
1264 // range check (if we can't eliminate it, this isn't profitable).
1265
1266 // In order to eliminate the add-with-constant, the compare can be its only
1267 // use.
1268 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1269 if (!AddWithCst->hasOneUse())
1270 return nullptr;
1271
1272 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1273 if (!CI2->getValue().isPowerOf2())
1274 return nullptr;
1275 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1276 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1277 return nullptr;
1278
1279 // The width of the new add formed is 1 more than the bias.
1280 ++NewWidth;
1281
1282 // Check to see that CI1 is an all-ones value with NewWidth bits.
1283 if (CI1->getBitWidth() == NewWidth ||
1284 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1285 return nullptr;
1286
1287 // This is only really a signed overflow check if the inputs have been
1288 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1289 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1290 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1291 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1292 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1293 return nullptr;
1294
1295 // In order to replace the original add with a narrower
1296 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1297 // and truncates that discard the high bits of the add. Verify that this is
1298 // the case.
1299 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1300 for (User *U : OrigAdd->users()) {
1301 if (U == AddWithCst)
1302 continue;
1303
1304 // Only accept truncates for now. We would really like a nice recursive
1305 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1306 // chain to see which bits of a value are actually demanded. If the
1307 // original add had another add which was then immediately truncated, we
1308 // could still do the transformation.
1309 TruncInst *TI = dyn_cast<TruncInst>(U);
1310 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1311 return nullptr;
1312 }
1313
1314 // If the pattern matches, truncate the inputs to the narrower type and
1315 // use the sadd_with_overflow intrinsic to efficiently compute both the
1316 // result and the overflow bit.
1317 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
James Y Knight7976eb52019-02-01 20:43:25 +00001318 Function *F = Intrinsic::getDeclaration(
1319 I.getModule(), Intrinsic::sadd_with_overflow, NewType);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001320
Craig Topperbb4069e2017-07-07 23:16:26 +00001321 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001322
1323 // Put the new code above the original add, in case there are any uses of the
1324 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001325 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001326
Craig Topperbb4069e2017-07-07 23:16:26 +00001327 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1328 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1329 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1330 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1331 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001332
1333 // The inner add was the result of the narrow add, zero extended to the
1334 // wider type. Replace it with the result computed by the intrinsic.
1335 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1336
1337 // The original icmp gets replaced with the overflow value.
1338 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1339}
1340
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001341/// If we have:
1342/// icmp eq/ne (urem/srem %x, %y), 0
1343/// iff %y is a power-of-two, we can replace this with a bit test:
1344/// icmp eq/ne (and %x, (add %y, -1)), 0
1345Instruction *InstCombiner::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) {
1346 // This fold is only valid for equality predicates.
1347 if (!I.isEquality())
1348 return nullptr;
1349 ICmpInst::Predicate Pred;
1350 Value *X, *Y, *Zero;
1351 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))),
1352 m_CombineAnd(m_Zero(), m_Value(Zero)))))
1353 return nullptr;
1354 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I))
1355 return nullptr;
1356 // This may increase instruction count, we don't enforce that Y is a constant.
1357 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType()));
1358 Value *Masked = Builder.CreateAnd(X, Mask);
1359 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero);
1360}
1361
Roman Lebedevf55818e2019-07-01 09:41:43 +00001362// Handle icmp pred X, 0
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001363Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1364 CmpInst::Predicate Pred = Cmp.getPredicate();
Roman Lebedevf55818e2019-07-01 09:41:43 +00001365 if (!match(Cmp.getOperand(1), m_Zero()))
1366 return nullptr;
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001367
Roman Lebedevf55818e2019-07-01 09:41:43 +00001368 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1369 if (Pred == ICmpInst::ICMP_SGT) {
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001370 Value *A, *B;
Roman Lebedevf55818e2019-07-01 09:41:43 +00001371 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B);
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001372 if (SPR.Flavor == SPF_SMIN) {
1373 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1374 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1375 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1376 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1377 }
1378 }
Roman Lebedevf55818e2019-07-01 09:41:43 +00001379
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001380 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp))
1381 return New;
1382
Roman Lebedevf55818e2019-07-01 09:41:43 +00001383 // Given:
1384 // icmp eq/ne (urem %x, %y), 0
1385 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem':
1386 // icmp eq/ne %x, 0
1387 Value *X, *Y;
1388 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) &&
1389 ICmpInst::isEquality(Pred)) {
1390 KnownBits XKnown = computeKnownBits(X, 0, &Cmp);
1391 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp);
1392 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2)
1393 return new ICmpInst(Pred, X, Cmp.getOperand(1));
1394 }
1395
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001396 return nullptr;
1397}
1398
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001399/// Fold icmp Pred X, C.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001400/// TODO: This code structure does not make sense. The saturating add fold
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001401/// should be moved to some other helper and extended as noted below (it is also
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001402/// possible that code has been made unnecessary - do we canonicalize IR to
1403/// overflow/saturating intrinsics or not?).
Sanjay Patel97459832016-09-15 15:11:12 +00001404Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
Sanjay Patel97459832016-09-15 15:11:12 +00001405 // Match the following pattern, which is a common idiom when writing
1406 // overflow-safe integer arithmetic functions. The source performs an addition
1407 // in wider type and explicitly checks for overflow using comparisons against
1408 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1409 //
1410 // TODO: This could probably be generalized to handle other overflow-safe
1411 // operations if we worked out the formulas to compute the appropriate magic
1412 // constants.
1413 //
1414 // sum = a + b
1415 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001416 CmpInst::Predicate Pred = Cmp.getPredicate();
1417 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1);
1418 Value *A, *B;
1419 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1420 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) &&
1421 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
1422 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this))
1423 return Res;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001424
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001425 return nullptr;
1426}
1427
1428/// Canonicalize icmp instructions based on dominating conditions.
1429Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) {
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001430 // This is a cheap/incomplete check for dominance - just match a single
1431 // predecessor with a conditional branch.
1432 BasicBlock *CmpBB = Cmp.getParent();
1433 BasicBlock *DomBB = CmpBB->getSinglePredecessor();
1434 if (!DomBB)
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001435 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001436
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001437 Value *DomCond;
Sanjay Patel97459832016-09-15 15:11:12 +00001438 BasicBlock *TrueBB, *FalseBB;
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001439 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB)))
1440 return nullptr;
1441
1442 assert((TrueBB == CmpBB || FalseBB == CmpBB) &&
1443 "Predecessor block does not point to successor?");
1444
1445 // The branch should get simplified. Don't bother simplifying this condition.
1446 if (TrueBB == FalseBB)
1447 return nullptr;
1448
Sanjay Patelbaffae92018-12-05 15:04:00 +00001449 // Try to simplify this compare to T/F based on the dominating condition.
1450 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB);
1451 if (Imp)
1452 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp));
1453
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001454 CmpInst::Predicate Pred = Cmp.getPredicate();
1455 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1);
1456 ICmpInst::Predicate DomPred;
1457 const APInt *C, *DomC;
1458 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) &&
1459 match(Y, m_APInt(C))) {
1460 // We have 2 compares of a variable with constants. Calculate the constant
1461 // ranges of those compares to see if we can transform the 2nd compare:
1462 // DomBB:
1463 // DomCond = icmp DomPred X, DomC
1464 // br DomCond, CmpBB, FalseBB
1465 // CmpBB:
1466 // Cmp = icmp Pred X, C
1467 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C);
Sanjay Patel97459832016-09-15 15:11:12 +00001468 ConstantRange DominatingCR =
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001469 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC)
1470 : ConstantRange::makeExactICmpRegion(
1471 CmpInst::getInversePredicate(DomPred), *DomC);
Sanjay Patel97459832016-09-15 15:11:12 +00001472 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1473 ConstantRange Difference = DominatingCR.difference(CR);
1474 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001475 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001476 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001477 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001478
Sanjay Patel97459832016-09-15 15:11:12 +00001479 // Canonicalizing a sign bit comparison that gets used in a branch,
1480 // pessimizes codegen by generating branch on zero instruction instead
1481 // of a test and branch. So we avoid canonicalizing in such situations
1482 // because test and branch instruction has better branch displacement
1483 // than compare and branch instruction.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001484 bool UnusedBit;
1485 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit);
Eric Christophera95aac32017-06-30 01:57:48 +00001486 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1487 return nullptr;
1488
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001489 if (const APInt *EqC = Intersection.getSingleElement())
1490 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC));
1491 if (const APInt *NeC = Difference.getSingleElement())
1492 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001493 }
1494
1495 return nullptr;
1496}
1497
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001498/// Fold icmp (trunc X, Y), C.
1499Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001500 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001501 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001502 ICmpInst::Predicate Pred = Cmp.getPredicate();
1503 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001504 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001505 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1506 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001507 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001508 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1509 ConstantInt::get(V->getType(), 1));
1510 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001511
1512 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001513 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1514 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001515 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1516 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001517 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001518
1519 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001520 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001521 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001522 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001523 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001524 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001525 }
1526 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001527
Sanjay Patela3f4f082016-08-16 17:54:36 +00001528 return nullptr;
1529}
1530
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001531/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001532Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1533 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001534 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001535 Value *X = Xor->getOperand(0);
1536 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001537 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001538 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001539 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001540
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001541 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1542 // fold the xor.
1543 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001544 bool TrueIfSigned = false;
1545 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001546
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001547 // If the sign bit of the XorCst is not set, there is no change to
1548 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001549 if (!XorC->isNegative()) {
1550 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001551 Worklist.Add(Xor);
1552 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001553 }
1554
Craig Topperdf63b962017-10-03 19:14:23 +00001555 // Emit the opposite comparison.
1556 if (TrueIfSigned)
1557 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1558 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001559 else
Craig Topperdf63b962017-10-03 19:14:23 +00001560 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1561 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001562 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001563
1564 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001565 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1566 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001567 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1568 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001569 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001570 }
1571
Craig Topperbcfd2d12017-04-20 16:56:25 +00001572 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001573 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1574 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1575 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001576 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001577 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001578 }
1579 }
1580
Sanjay Patel26725bd2018-09-11 22:00:15 +00001581 // Mask constant magic can eliminate an 'xor' with unsigned compares.
1582 if (Pred == ICmpInst::ICMP_UGT) {
1583 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2)
1584 if (*XorC == ~C && (C + 1).isPowerOf2())
1585 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
1586 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2)
1587 if (*XorC == C && (C + 1).isPowerOf2())
1588 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
1589 }
1590 if (Pred == ICmpInst::ICMP_ULT) {
1591 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2)
1592 if (*XorC == -C && C.isPowerOf2())
1593 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1594 ConstantInt::get(X->getType(), ~C));
1595 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2)
1596 if (*XorC == C && (-C).isPowerOf2())
1597 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1598 ConstantInt::get(X->getType(), ~C));
1599 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001600 return nullptr;
1601}
1602
Sanjay Patel14e0e182016-08-26 18:28:46 +00001603/// Fold icmp (and (sh X, Y), C2), C1.
1604Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001605 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001606 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1607 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001608 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001609
Sanjay Patelda9c5622016-08-26 17:15:22 +00001610 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1611 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1612 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001613 // This seemingly simple opportunity to fold away a shift turns out to be
1614 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001615 unsigned ShiftOpcode = Shift->getOpcode();
1616 bool IsShl = ShiftOpcode == Instruction::Shl;
1617 const APInt *C3;
1618 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001619 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001620 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001621 // For a left shift, we can fold if the comparison is not signed. We can
1622 // also fold a signed comparison if the mask value and comparison value
1623 // are not negative. These constraints may not be obvious, but we can
1624 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001625 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001626 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001627 } else {
1628 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001629 // For a logical right shift, we can fold if the comparison is not signed.
1630 // We can also fold a signed comparison if the shifted mask value and the
1631 // shifted comparison value are not negative. These constraints may not be
1632 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001633 // For an arithmetic shift right we can do the same, if we ensure
1634 // the And doesn't use any bits being shifted in. Normally these would
1635 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1636 // additional user.
1637 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1638 if (!Cmp.isSigned() ||
1639 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1640 CanFold = true;
1641 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001642 }
1643
Sanjay Patelda9c5622016-08-26 17:15:22 +00001644 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001645 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001646 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001647 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001648 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001649 // If we shifted bits out, the fold is not going to work out. As a
1650 // special case, check to see if this means that the result is always
1651 // true or false now.
1652 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001653 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001654 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001655 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001656 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001657 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001658 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001659 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001660 And->setOperand(0, Shift->getOperand(0));
1661 Worklist.Add(Shift); // Shift is dead.
1662 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001663 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001664 }
1665 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001666
Sanjay Patelda9c5622016-08-26 17:15:22 +00001667 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1668 // preferable because it allows the C2 << Y expression to be hoisted out of a
1669 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001670 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001671 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1672 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001673 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001674 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1675 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001676
Sanjay Patelda9c5622016-08-26 17:15:22 +00001677 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001678 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001679 Cmp.setOperand(0, NewAnd);
1680 return &Cmp;
1681 }
1682
Sanjay Patel14e0e182016-08-26 18:28:46 +00001683 return nullptr;
1684}
1685
1686/// Fold icmp (and X, C2), C1.
1687Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1688 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001689 const APInt &C1) {
Huihui Zhang670778c2019-06-19 17:31:39 +00001690 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE;
1691
Sanjay Patel05aadf82018-10-10 20:47:46 +00001692 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1
1693 // TODO: We canonicalize to the longer form for scalars because we have
1694 // better analysis/folds for icmp, and codegen may be better with icmp.
Huihui Zhang670778c2019-06-19 17:31:39 +00001695 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isNullValue() &&
1696 match(And->getOperand(1), m_One()))
Sanjay Patel05aadf82018-10-10 20:47:46 +00001697 return new TruncInst(And->getOperand(0), Cmp.getType());
1698
Sanjay Patel6b490972016-09-04 14:32:15 +00001699 const APInt *C2;
Huihui Zhang670778c2019-06-19 17:31:39 +00001700 Value *X;
1701 if (!match(And, m_And(m_Value(X), m_APInt(C2))))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001702 return nullptr;
1703
Huihui Zhang670778c2019-06-19 17:31:39 +00001704 // Don't perform the following transforms if the AND has multiple uses
Craig Topper8bf62212017-09-26 18:47:25 +00001705 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001706 return nullptr;
1707
Huihui Zhang670778c2019-06-19 17:31:39 +00001708 if (Cmp.isEquality() && C1.isNullValue()) {
1709 // Restrict this fold to single-use 'and' (PR10267).
1710 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0
1711 if (C2->isSignMask()) {
1712 Constant *Zero = Constant::getNullValue(X->getType());
1713 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
1714 return new ICmpInst(NewPred, X, Zero);
1715 }
Huihui Zhang46266132019-06-25 00:09:10 +00001716
1717 // Restrict this fold only for single-use 'and' (PR10267).
1718 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two.
1719 if ((~(*C2) + 1).isPowerOf2()) {
1720 Constant *NegBOC =
1721 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1)));
1722 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
1723 return new ICmpInst(NewPred, X, NegBOC);
1724 }
Huihui Zhang670778c2019-06-19 17:31:39 +00001725 }
1726
Sanjay Patel6b490972016-09-04 14:32:15 +00001727 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1728 // the input width without changing the value produced, eliminate the cast:
1729 //
1730 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1731 //
1732 // We can do this transformation if the constants do not have their sign bits
1733 // set or if it is an equality comparison. Extending a relational comparison
1734 // when we're checking the sign bit would not work.
1735 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001736 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001737 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001738 // TODO: Is this a good transform for vectors? Wider types may reduce
1739 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001740 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001741 if (!Cmp.getType()->isVectorTy()) {
1742 Type *WideType = W->getType();
1743 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001744 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001745 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001746 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001747 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001748 }
1749 }
1750
Craig Topper8ed1aa92017-10-03 05:31:07 +00001751 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001752 return I;
1753
Sanjay Patelda9c5622016-08-26 17:15:22 +00001754 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001755 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001756 //
1757 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001758 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001759 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001760 Constant *One = cast<Constant>(And->getOperand(1));
1761 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001762 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001763 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1764 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1765 unsigned UsesRemoved = 0;
1766 if (And->hasOneUse())
1767 ++UsesRemoved;
1768 if (Or->hasOneUse())
1769 ++UsesRemoved;
1770 if (LShr->hasOneUse())
1771 ++UsesRemoved;
1772
1773 // Compute A & ((1 << B) | 1)
1774 Value *NewOr = nullptr;
1775 if (auto *C = dyn_cast<Constant>(B)) {
1776 if (UsesRemoved >= 1)
1777 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1778 } else {
1779 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001780 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1781 /*HasNUW=*/true),
1782 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001783 }
1784 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001785 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001786 Cmp.setOperand(0, NewAnd);
1787 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001788 }
1789 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001790 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001791
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001792 return nullptr;
1793}
1794
1795/// Fold icmp (and X, Y), C.
1796Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1797 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001798 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001799 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1800 return I;
1801
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001802 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001803
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001804 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1805 Value *X = And->getOperand(0);
1806 Value *Y = And->getOperand(1);
1807 if (auto *LI = dyn_cast<LoadInst>(X))
1808 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1809 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001810 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001811 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1812 ConstantInt *C2 = cast<ConstantInt>(Y);
1813 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001814 return Res;
1815 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001816
1817 if (!Cmp.isEquality())
1818 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001819
1820 // X & -C == -C -> X > u ~C
1821 // X & -C != -C -> X <= u ~C
1822 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001823 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001824 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1825 : CmpInst::ICMP_ULE;
1826 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1827 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001828
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001829 // (X & C2) == 0 -> (trunc X) >= 0
1830 // (X & C2) != 0 -> (trunc X) < 0
1831 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1832 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001833 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001834 int32_t ExactLogBase2 = C2->exactLogBase2();
1835 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1836 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1837 if (And->getType()->isVectorTy())
1838 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001839 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001840 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1841 : CmpInst::ICMP_SLT;
1842 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001843 }
1844 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001845
Sanjay Patela3f4f082016-08-16 17:54:36 +00001846 return nullptr;
1847}
1848
Sanjay Patel943e92e2016-08-17 16:30:43 +00001849/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001850Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001851 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001852 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001853 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001854 // icmp slt signum(V) 1 --> icmp slt V, 1
1855 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001856 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001857 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1858 ConstantInt::get(V->getType(), 1));
1859 }
1860
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001861 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1);
1862 if (Cmp.isEquality() && Cmp.getOperand(1) == OrOp1) {
1863 // X | C == C --> X <=u C
1864 // X | C != C --> X >u C
1865 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1866 if ((C + 1).isPowerOf2()) {
1867 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1868 return new ICmpInst(Pred, OrOp0, OrOp1);
1869 }
1870 // More general: are all bits outside of a mask constant set or not set?
1871 // X | C == C --> (X & ~C) == 0
1872 // X | C != C --> (X & ~C) != 0
1873 if (Or->hasOneUse()) {
1874 Value *A = Builder.CreateAnd(OrOp0, ~C);
1875 return new ICmpInst(Pred, A, ConstantInt::getNullValue(OrOp0->getType()));
1876 }
Sanjay Patel50c82c42017-04-05 17:57:05 +00001877 }
1878
Craig Topper8ed1aa92017-10-03 05:31:07 +00001879 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001880 return nullptr;
1881
1882 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001883 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001884 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1885 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001886 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001887 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001888 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001889 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001890 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1891 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1892 }
1893
1894 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1895 // a shorter form that has more potential to be folded even further.
1896 Value *X1, *X2, *X3, *X4;
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001897 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1898 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001899 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1900 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1901 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1902 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1903 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1904 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001905 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001906
Sanjay Patela3f4f082016-08-16 17:54:36 +00001907 return nullptr;
1908}
1909
Sanjay Patel63478072016-08-18 15:44:44 +00001910/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001911Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1912 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001913 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001914 const APInt *MulC;
1915 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001916 return nullptr;
1917
Sanjay Patel63478072016-08-18 15:44:44 +00001918 // If this is a test of the sign bit and the multiply is sign-preserving with
1919 // a constant operand, use the multiply LHS operand instead.
1920 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001921 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001922 if (MulC->isNegative())
1923 Pred = ICmpInst::getSwappedPredicate(Pred);
1924 return new ICmpInst(Pred, Mul->getOperand(0),
1925 Constant::getNullValue(Mul->getType()));
1926 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001927
1928 return nullptr;
1929}
1930
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001931/// Fold icmp (shl 1, Y), C.
1932static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001933 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001934 Value *Y;
1935 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1936 return nullptr;
1937
1938 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001939 unsigned TypeBits = C.getBitWidth();
1940 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001941 ICmpInst::Predicate Pred = Cmp.getPredicate();
1942 if (Cmp.isUnsigned()) {
1943 // (1 << Y) pred C -> Y pred Log2(C)
1944 if (!CIsPowerOf2) {
1945 // (1 << Y) < 30 -> Y <= 4
1946 // (1 << Y) <= 30 -> Y <= 4
1947 // (1 << Y) >= 30 -> Y > 4
1948 // (1 << Y) > 30 -> Y > 4
1949 if (Pred == ICmpInst::ICMP_ULT)
1950 Pred = ICmpInst::ICMP_ULE;
1951 else if (Pred == ICmpInst::ICMP_UGE)
1952 Pred = ICmpInst::ICMP_UGT;
1953 }
1954
1955 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1956 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001957 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001958 if (CLog2 == TypeBits - 1) {
1959 if (Pred == ICmpInst::ICMP_UGE)
1960 Pred = ICmpInst::ICMP_EQ;
1961 else if (Pred == ICmpInst::ICMP_ULT)
1962 Pred = ICmpInst::ICMP_NE;
1963 }
1964 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1965 } else if (Cmp.isSigned()) {
1966 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001967 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001968 // (1 << Y) <= -1 -> Y == 31
1969 if (Pred == ICmpInst::ICMP_SLE)
1970 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1971
1972 // (1 << Y) > -1 -> Y != 31
1973 if (Pred == ICmpInst::ICMP_SGT)
1974 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001975 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001976 // (1 << Y) < 0 -> Y == 31
1977 // (1 << Y) <= 0 -> Y == 31
1978 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1979 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1980
1981 // (1 << Y) >= 0 -> Y != 31
1982 // (1 << Y) > 0 -> Y != 31
1983 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1984 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1985 }
1986 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001987 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001988 }
1989
1990 return nullptr;
1991}
1992
Sanjay Patel38b75062016-08-19 17:20:37 +00001993/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001994Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1995 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001996 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001997 const APInt *ShiftVal;
1998 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001999 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002000
Sanjay Patelfa7de602016-08-19 22:33:26 +00002001 const APInt *ShiftAmt;
2002 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00002003 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00002004
Sanjay Patel38b75062016-08-19 17:20:37 +00002005 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00002006 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002007 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00002008 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002009 return nullptr;
2010
Sanjay Patele38e79c2016-08-19 17:34:05 +00002011 ICmpInst::Predicate Pred = Cmp.getPredicate();
2012 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00002013 Type *ShType = Shl->getType();
2014
Sanjay Patel291c3d82017-01-19 16:12:10 +00002015 // NSW guarantees that we are only shifting out sign bits from the high bits,
2016 // so we can ASHR the compare constant without needing a mask and eliminate
2017 // the shift.
2018 if (Shl->hasNoSignedWrap()) {
2019 if (Pred == ICmpInst::ICMP_SGT) {
2020 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002021 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002022 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2023 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002024 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2025 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002026 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002027 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2028 }
2029 if (Pred == ICmpInst::ICMP_SLT) {
2030 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
2031 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
2032 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
2033 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00002034 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
2035 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00002036 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2037 }
2038 // If this is a signed comparison to 0 and the shift is sign preserving,
2039 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
2040 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002041 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00002042 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
2043 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002044
Sanjay Patel291c3d82017-01-19 16:12:10 +00002045 // NUW guarantees that we are only shifting out zero bits from the high bits,
2046 // so we can LSHR the compare constant without needing a mask and eliminate
2047 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00002048 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00002049 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00002050 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002051 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002052 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2053 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002054 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2055 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002056 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00002057 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2058 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002059 if (Pred == ICmpInst::ICMP_ULT) {
2060 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
2061 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
2062 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
2063 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00002064 assert(C.ugt(0) && "ult 0 should have been eliminated");
2065 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00002066 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2067 }
2068 }
2069
Sanjay Patel291c3d82017-01-19 16:12:10 +00002070 if (Cmp.isEquality() && Shl->hasOneUse()) {
2071 // Strength-reduce the shift into an 'and'.
2072 Constant *Mask = ConstantInt::get(
2073 ShType,
2074 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00002075 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00002076 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00002077 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002078 }
2079
Sanjay Patela3f4f082016-08-16 17:54:36 +00002080 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
2081 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002082 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00002083 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00002084 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00002085 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00002086 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002087 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00002088 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00002089 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00002090 }
2091
Huihui Zhangb90cb572019-06-25 20:44:52 +00002092 // Simplify 'shl' inequality test into 'and' equality test.
2093 if (Cmp.isUnsigned() && Shl->hasOneUse()) {
2094 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0
2095 if ((C + 1).isPowerOf2() &&
2096 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) {
2097 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue()));
2098 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ
2099 : ICmpInst::ICMP_NE,
2100 And, Constant::getNullValue(ShType));
2101 }
2102 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0
2103 if (C.isPowerOf2() &&
2104 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) {
2105 Value *And =
2106 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue()));
2107 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ
2108 : ICmpInst::ICMP_NE,
2109 And, Constant::getNullValue(ShType));
2110 }
2111 }
2112
Sanjay Patel643d21a2016-08-21 17:10:07 +00002113 // Transform (icmp pred iM (shl iM %v, N), C)
2114 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2115 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002116 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002117 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002118 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002119 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002120 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00002121 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002122 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002123 if (ShType->isVectorTy())
2124 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002125 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00002126 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00002127 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002128 }
2129
2130 return nullptr;
2131}
2132
Sanjay Patela3920492016-08-22 20:45:06 +00002133/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002134Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2135 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002136 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002137 // An exact shr only shifts out zero bits, so:
2138 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002139 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002140 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002141 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00002142 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002143 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002144
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002145 const APInt *ShiftVal;
2146 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002147 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002148
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002149 const APInt *ShiftAmt;
2150 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002151 return nullptr;
2152
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002153 // Check that the shift amount is in range. If not, don't perform undefined
2154 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002155 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002156 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002157 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2158 return nullptr;
2159
Sanjay Pateld64e9882016-08-23 22:05:55 +00002160 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002161 bool IsExact = Shr->isExact();
2162 Type *ShrTy = Shr->getType();
2163 // TODO: If we could guarantee that InstSimplify would handle all of the
2164 // constant-value-based preconditions in the folds below, then we could assert
2165 // those conditions rather than checking them. This is difficult because of
2166 // undef/poison (PR34838).
2167 if (IsAShr) {
2168 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2169 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2170 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2171 APInt ShiftedC = C.shl(ShAmtVal);
2172 if (ShiftedC.ashr(ShAmtVal) == C)
2173 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2174 }
2175 if (Pred == CmpInst::ICMP_SGT) {
2176 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2177 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2178 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2179 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2180 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2181 }
2182 } else {
2183 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2184 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2185 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2186 APInt ShiftedC = C.shl(ShAmtVal);
2187 if (ShiftedC.lshr(ShAmtVal) == C)
2188 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2189 }
2190 if (Pred == CmpInst::ICMP_UGT) {
2191 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2192 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2193 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2194 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2195 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002196 }
2197
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002198 if (!Cmp.isEquality())
2199 return nullptr;
2200
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002201 // Handle equality comparisons of shift-by-constant.
2202
Sanjay Patel8e297742016-08-24 13:55:55 +00002203 // If the comparison constant changes with the shift, the comparison cannot
2204 // succeed (bits of the comparison constant cannot match the shifted value).
2205 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002206 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2207 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002208 "Expected icmp+shr simplify did not occur.");
2209
Sanjay Patel934738a2017-10-15 15:39:15 +00002210 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002211 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002212 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002213 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002214
Sanjay Patel934738a2017-10-15 15:39:15 +00002215 if (Shr->hasOneUse()) {
2216 // Canonicalize the shift into an 'and':
2217 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002218 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002219 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002220 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002221 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002222 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002223
2224 return nullptr;
2225}
2226
Sanjay Patel12a41052016-08-18 17:37:26 +00002227/// Fold icmp (udiv X, Y), C.
2228Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002229 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002230 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002231 const APInt *C2;
2232 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2233 return nullptr;
2234
Craig Topper29c282e2017-06-07 07:40:29 +00002235 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002236
2237 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2238 Value *Y = UDiv->getOperand(1);
2239 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002240 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002241 "icmp ugt X, UINT_MAX should have been simplified already.");
2242 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002243 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002244 }
2245
2246 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2247 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002248 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002249 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002250 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002251 }
2252
2253 return nullptr;
2254}
2255
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002256/// Fold icmp ({su}div X, Y), C.
2257Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2258 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002259 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002260 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002261 // Fold this div into the comparison, producing a range check.
2262 // Determine, based on the divide type, what the range is being
2263 // checked. If there is an overflow on the low or high side, remember
2264 // it, otherwise compute the range [low, hi) bounding the new value.
2265 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002266 const APInt *C2;
2267 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002268 return nullptr;
2269
Sanjay Patel16554142016-08-24 23:03:36 +00002270 // FIXME: If the operand types don't match the type of the divide
2271 // then don't attempt this transform. The code below doesn't have the
2272 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002273 // vice versa). This is because (x /s C2) <s C produces different
2274 // results than (x /s C2) <u C or (x /u C2) <s C or even
2275 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002276 // work. :( The if statement below tests that condition and bails
2277 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002278 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2279 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002280 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002281
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002282 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2283 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2284 // division-by-constant cases should be present, we can not assert that they
2285 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002286 if (C2->isNullValue() || C2->isOneValue() ||
2287 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002288 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002289
Craig Topper6e025a32017-10-01 23:53:54 +00002290 // Compute Prod = C * C2. We are essentially solving an equation of
2291 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002292 // By solving for X, we can turn this into a range check instead of computing
2293 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002294 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002295
Sanjay Patel541aef42016-08-31 21:57:21 +00002296 // Determine if the product overflows by seeing if the product is not equal to
2297 // the divide. Make sure we do the same kind of divide as in the LHS
2298 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002299 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002300
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002301 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002302
2303 // If the division is known to be exact, then there is no remainder from the
2304 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002305 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002306
2307 // Figure out the interval that is being checked. For example, a comparison
2308 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2309 // Compute this interval based on the constants involved and the signedness of
2310 // the compare/divide. This computes a half-open interval, keeping track of
2311 // whether either value in the interval overflows. After analysis each
2312 // overflow variable is set to 0 if it's corresponding bound variable is valid
2313 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2314 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002315 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002316
2317 if (!DivIsSigned) { // udiv
2318 // e.g. X/5 op 3 --> [15, 20)
2319 LoBound = Prod;
2320 HiOverflow = LoOverflow = ProdOV;
2321 if (!HiOverflow) {
2322 // If this is not an exact divide, then many values in the range collapse
2323 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002324 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002325 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002326 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002327 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002328 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002329 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002330 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002331 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002332 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2333 HiOverflow = LoOverflow = ProdOV;
2334 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002335 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002336 } else { // (X / pos) op neg
2337 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002338 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002339 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2340 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002341 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002342 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002343 }
2344 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002345 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002346 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002347 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002348 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002349 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002350 LoBound = RangeSize + 1;
2351 HiBound = -RangeSize;
2352 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002353 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002354 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002355 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002356 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002357 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002358 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002359 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2360 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002361 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002362 } else { // (X / neg) op neg
2363 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2364 LoOverflow = HiOverflow = ProdOV;
2365 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002366 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002367 }
2368
2369 // Dividing by a negative swaps the condition. LT <-> GT
2370 Pred = ICmpInst::getSwappedPredicate(Pred);
2371 }
2372
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002373 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002374 switch (Pred) {
2375 default: llvm_unreachable("Unhandled icmp opcode!");
2376 case ICmpInst::ICMP_EQ:
2377 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002378 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002379 if (HiOverflow)
2380 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002381 ICmpInst::ICMP_UGE, X,
2382 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002383 if (LoOverflow)
2384 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002385 ICmpInst::ICMP_ULT, X,
2386 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002387 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002388 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002389 case ICmpInst::ICMP_NE:
2390 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002391 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002392 if (HiOverflow)
2393 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002394 ICmpInst::ICMP_ULT, X,
2395 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002396 if (LoOverflow)
2397 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002398 ICmpInst::ICMP_UGE, X,
2399 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002400 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002401 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002402 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002403 case ICmpInst::ICMP_ULT:
2404 case ICmpInst::ICMP_SLT:
2405 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002406 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002407 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002408 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002409 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002410 case ICmpInst::ICMP_UGT:
2411 case ICmpInst::ICMP_SGT:
2412 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002413 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002414 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002415 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002416 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002417 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2418 ConstantInt::get(Div->getType(), HiBound));
2419 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2420 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002421 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002422
2423 return nullptr;
2424}
2425
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002426/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002427Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2428 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002429 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002430 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2431 ICmpInst::Predicate Pred = Cmp.getPredicate();
Luqman Aden8911c5b2019-04-04 07:08:30 +00002432 const APInt *C2;
2433 APInt SubResult;
2434
Philip Reames764b0fd2019-08-21 15:51:57 +00002435 // icmp eq/ne (sub C, Y), C -> icmp eq/ne Y, 0
2436 if (match(X, m_APInt(C2)) && *C2 == C && Cmp.isEquality())
2437 return new ICmpInst(Cmp.getPredicate(), Y,
2438 ConstantInt::get(Y->getType(), 0));
2439
Luqman Aden8911c5b2019-04-04 07:08:30 +00002440 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C)
2441 if (match(X, m_APInt(C2)) &&
2442 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) ||
2443 (Cmp.isSigned() && Sub->hasNoSignedWrap())) &&
2444 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned()))
2445 return new ICmpInst(Cmp.getSwappedPredicate(), Y,
2446 ConstantInt::get(Y->getType(), SubResult));
Sanjay Patel886a5422016-09-15 18:05:17 +00002447
2448 // The following transforms are only worth it if the only user of the subtract
2449 // is the icmp.
2450 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002451 return nullptr;
2452
Sanjay Patel886a5422016-09-15 18:05:17 +00002453 if (Sub->hasNoSignedWrap()) {
2454 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002455 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002456 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002457
Sanjay Patel886a5422016-09-15 18:05:17 +00002458 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002459 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002460 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2461
2462 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002463 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002464 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2465
2466 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002467 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002468 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2469 }
2470
Sanjay Patel886a5422016-09-15 18:05:17 +00002471 if (!match(X, m_APInt(C2)))
2472 return nullptr;
2473
2474 // C2 - Y <u C -> (Y | (C - 1)) == C2
2475 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002476 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2477 (*C2 & (C - 1)) == (C - 1))
2478 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002479
2480 // C2 - Y >u C -> (Y | C) != C2
2481 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002482 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2483 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002484
2485 return nullptr;
2486}
2487
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002488/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002489Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2490 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002491 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002492 Value *Y = Add->getOperand(1);
2493 const APInt *C2;
2494 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002495 return nullptr;
2496
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002497 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002498 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002499 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002500 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002501
Tim Northover12c1f762018-09-10 14:26:44 +00002502 if (!Add->hasOneUse())
2503 return nullptr;
2504
Sanjay Patel45b7e692017-02-12 16:40:30 +00002505 // If the add does not wrap, we can always adjust the compare by subtracting
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002506 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE
2507 // are canonicalized to SGT/SLT/UGT/ULT.
2508 if ((Add->hasNoSignedWrap() &&
2509 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) ||
2510 (Add->hasNoUnsignedWrap() &&
2511 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) {
Sanjay Patel45b7e692017-02-12 16:40:30 +00002512 bool Overflow;
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002513 APInt NewC =
2514 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002515 // If there is overflow, the result must be true or false.
2516 // TODO: Can we assert there is no overflow because InstSimplify always
2517 // handles those cases?
2518 if (!Overflow)
2519 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2520 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2521 }
2522
Craig Topper8ed1aa92017-10-03 05:31:07 +00002523 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002524 const APInt &Upper = CR.getUpper();
2525 const APInt &Lower = CR.getLower();
2526 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002527 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002528 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002529 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002530 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002531 } else {
2532 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002533 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002534 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002535 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002536 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002537
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002538 // X+C <u C2 -> (X & -C2) == C
2539 // iff C & (C2-1) == 0
2540 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002541 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2542 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002543 ConstantExpr::getNeg(cast<Constant>(Y)));
2544
2545 // X+C >u C2 -> (X & ~C2) != C
2546 // iff C & C2 == 0
2547 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002548 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2549 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002550 ConstantExpr::getNeg(cast<Constant>(Y)));
2551
Sanjay Patela3f4f082016-08-16 17:54:36 +00002552 return nullptr;
2553}
2554
Anna Thomasd67165c2017-06-23 13:41:45 +00002555bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2556 Value *&RHS, ConstantInt *&Less,
2557 ConstantInt *&Equal,
2558 ConstantInt *&Greater) {
2559 // TODO: Generalize this to work with other comparison idioms or ensure
2560 // they get canonicalized into this form.
2561
2562 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2563 // Greater), where Equal, Less and Greater are placeholders for any three
2564 // constants.
2565 ICmpInst::Predicate PredA, PredB;
2566 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2567 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2568 PredA == ICmpInst::ICMP_EQ &&
2569 match(SI->getFalseValue(),
2570 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2571 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2572 PredB == ICmpInst::ICMP_SLT) {
2573 return true;
2574 }
2575 return false;
2576}
2577
2578Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002579 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002580 ConstantInt *C) {
2581
2582 assert(C && "Cmp RHS should be a constant int!");
2583 // If we're testing a constant value against the result of a three way
2584 // comparison, the result can be expressed directly in terms of the
2585 // original values being compared. Note: We could possibly be more
2586 // aggressive here and remove the hasOneUse test. The original select is
2587 // really likely to simplify or sink when we remove a test of the result.
2588 Value *OrigLHS, *OrigRHS;
2589 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2590 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002591 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2592 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002593 assert(C1LessThan && C2Equal && C3GreaterThan);
2594
2595 bool TrueWhenLessThan =
2596 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2597 ->isAllOnesValue();
2598 bool TrueWhenEqual =
2599 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2600 ->isAllOnesValue();
2601 bool TrueWhenGreaterThan =
2602 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2603 ->isAllOnesValue();
2604
2605 // This generates the new instruction that will replace the original Cmp
2606 // Instruction. Instead of enumerating the various combinations when
2607 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2608 // false, we rely on chaining of ORs and future passes of InstCombine to
2609 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2610
2611 // When none of the three constants satisfy the predicate for the RHS (C),
2612 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002613 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002614 if (TrueWhenLessThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002615 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT,
2616 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002617 if (TrueWhenEqual)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002618 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ,
2619 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002620 if (TrueWhenGreaterThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002621 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT,
2622 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002623
2624 return replaceInstUsesWith(Cmp, Cond);
2625 }
2626 return nullptr;
2627}
2628
Sanjay Patele7f46c32019-02-07 20:54:09 +00002629static Instruction *foldICmpBitCast(ICmpInst &Cmp,
2630 InstCombiner::BuilderTy &Builder) {
2631 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0));
2632 if (!Bitcast)
2633 return nullptr;
2634
Sanjay Patele7f46c32019-02-07 20:54:09 +00002635 ICmpInst::Predicate Pred = Cmp.getPredicate();
2636 Value *Op1 = Cmp.getOperand(1);
2637 Value *BCSrcOp = Bitcast->getOperand(0);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002638
Sanjay Patel781d8832019-02-07 21:12:01 +00002639 // Make sure the bitcast doesn't change the number of vector elements.
2640 if (Bitcast->getSrcTy()->getScalarSizeInBits() ==
2641 Bitcast->getDestTy()->getScalarSizeInBits()) {
2642 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
2643 Value *X;
2644 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) {
2645 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
2646 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
2647 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
2648 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
2649 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
2650 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
2651 match(Op1, m_Zero()))
2652 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002653
Sanjay Patel781d8832019-02-07 21:12:01 +00002654 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
2655 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
2656 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
2657
2658 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
2659 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
2660 return new ICmpInst(Pred, X,
2661 ConstantInt::getAllOnesValue(X->getType()));
2662 }
2663
2664 // Zero-equality checks are preserved through unsigned floating-point casts:
2665 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
2666 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
2667 if (match(BCSrcOp, m_UIToFP(m_Value(X))))
2668 if (Cmp.isEquality() && match(Op1, m_Zero()))
2669 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002670 }
2671
Sanjay Patele7f46c32019-02-07 20:54:09 +00002672 // Test to see if the operands of the icmp are casted versions of other
2673 // values. If the ptr->ptr cast can be stripped off both arguments, do so.
2674 if (Bitcast->getType()->isPointerTy() &&
2675 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
2676 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
2677 // so eliminate it as well.
2678 if (auto *BC2 = dyn_cast<BitCastInst>(Op1))
2679 Op1 = BC2->getOperand(0);
2680
2681 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType());
2682 return new ICmpInst(Pred, BCSrcOp, Op1);
2683 }
2684
Daniel Neilson901acfa2018-04-03 17:26:20 +00002685 // Folding: icmp <pred> iN X, C
2686 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2687 // and C is a splat of a K-bit pattern
2688 // and SC is a constant vector = <C', C', C', ..., C'>
2689 // Into:
2690 // %E = extractelement <M x iK> %vec, i32 C'
2691 // icmp <pred> iK %E, trunc(C)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002692 const APInt *C;
2693 if (!match(Cmp.getOperand(1), m_APInt(C)) ||
2694 !Bitcast->getType()->isIntegerTy() ||
Daniel Neilson901acfa2018-04-03 17:26:20 +00002695 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2696 return nullptr;
2697
Sanjay Patele7f46c32019-02-07 20:54:09 +00002698 Value *Vec;
2699 Constant *Mask;
2700 if (match(BCSrcOp,
Daniel Neilson901acfa2018-04-03 17:26:20 +00002701 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2702 // Check whether every element of Mask is the same constant
2703 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
Sanjay Patele7f46c32019-02-07 20:54:09 +00002704 auto *VecTy = cast<VectorType>(BCSrcOp->getType());
Daniel Neilson901acfa2018-04-03 17:26:20 +00002705 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
Sanjay Patele7f46c32019-02-07 20:54:09 +00002706 if (C->isSplat(EltTy->getBitWidth())) {
Daniel Neilson901acfa2018-04-03 17:26:20 +00002707 // Fold the icmp based on the value of C
2708 // If C is M copies of an iK sized bit pattern,
2709 // then:
2710 // => %E = extractelement <N x iK> %vec, i32 Elem
2711 // icmp <pred> iK %SplatVal, <pattern>
2712 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002713 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth()));
Daniel Neilson901acfa2018-04-03 17:26:20 +00002714 return new ICmpInst(Pred, Extract, NewC);
2715 }
2716 }
2717 }
2718 return nullptr;
2719}
2720
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002721/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2722/// where X is some kind of instruction.
2723Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002724 const APInt *C;
2725 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002726 return nullptr;
2727
Craig Toppera94069f2017-08-23 05:46:08 +00002728 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002729 switch (BO->getOpcode()) {
2730 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002731 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002732 return I;
2733 break;
2734 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002735 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002736 return I;
2737 break;
2738 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002739 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002740 return I;
2741 break;
2742 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002743 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002744 return I;
2745 break;
2746 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002747 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002748 return I;
2749 break;
2750 case Instruction::LShr:
2751 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002752 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002753 return I;
2754 break;
2755 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002756 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002757 return I;
2758 LLVM_FALLTHROUGH;
2759 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002760 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002761 return I;
2762 break;
2763 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002764 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002765 return I;
2766 break;
2767 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002768 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002769 return I;
2770 break;
2771 default:
2772 break;
2773 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002774 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002775 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002776 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002777 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002778
Anna Thomasd67165c2017-06-23 13:41:45 +00002779 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002780
2781 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2782 // For now, we only support constant integers while folding the
2783 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2784 // similar to the cases handled by binary ops above.
2785 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2786 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002787 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002788 }
2789
2790 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002791 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002792 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002793 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002794
Nikita Popov6515db22019-01-19 09:56:01 +00002795 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0)))
2796 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C))
2797 return I;
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002798
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002799 return nullptr;
2800}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002801
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002802/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2803/// icmp eq/ne BO, C.
2804Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2805 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002806 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002807 // TODO: Some of these folds could work with arbitrary constants, but this
2808 // function is limited to scalar and vector splat constants.
2809 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002810 return nullptr;
2811
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002812 ICmpInst::Predicate Pred = Cmp.getPredicate();
2813 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2814 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002815 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002816
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002817 switch (BO->getOpcode()) {
2818 case Instruction::SRem:
2819 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002820 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002821 const APInt *BOC;
2822 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002823 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002824 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002825 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002826 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002827 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002828 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002829 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002830 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002831 const APInt *BOC;
2832 if (match(BOp1, m_APInt(BOC))) {
2833 if (BO->hasOneUse()) {
2834 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002835 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002836 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002837 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002838 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2839 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002840 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002841 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002842 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002843 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002844 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002845 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002846 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002847 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002848 }
2849 }
2850 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002851 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002852 case Instruction::Xor:
2853 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002854 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002855 // For the xor case, we can xor two constants together, eliminating
2856 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002857 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002858 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002859 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002860 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002861 }
2862 }
2863 break;
2864 case Instruction::Sub:
2865 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002866 const APInt *BOC;
2867 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002868 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002869 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002870 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002871 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002872 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002873 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002874 }
2875 }
2876 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002877 case Instruction::Or: {
2878 const APInt *BOC;
2879 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002880 // Comparing if all bits outside of a constant mask are set?
2881 // Replace (X | C) == -1 with (X & ~C) == ~C.
2882 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002883 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002884 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002885 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002886 }
2887 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002888 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002889 case Instruction::And: {
2890 const APInt *BOC;
2891 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002892 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002893 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002894 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002895 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002896 }
2897 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002898 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002899 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002900 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002901 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002902 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002903 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002904 // General case : (mul X, C) != 0 iff X != 0
2905 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002906 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002907 }
2908 }
2909 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002910 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002911 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002912 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002913 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2914 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002915 }
2916 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002917 default:
2918 break;
2919 }
2920 return nullptr;
2921}
2922
Nikita Popov6515db22019-01-19 09:56:01 +00002923/// Fold an equality icmp with LLVM intrinsic and constant operand.
2924Instruction *InstCombiner::foldICmpEqIntrinsicWithConstant(ICmpInst &Cmp,
2925 IntrinsicInst *II,
2926 const APInt &C) {
Sanjay Patelb51e0722017-07-02 16:05:11 +00002927 Type *Ty = II->getType();
Nikita Popov20853a72018-12-18 19:59:50 +00002928 unsigned BitWidth = C.getBitWidth();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002929 switch (II->getIntrinsicID()) {
2930 case Intrinsic::bswap:
2931 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002932 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002933 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002934 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002935
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002936 case Intrinsic::ctlz:
Nikita Popov20853a72018-12-18 19:59:50 +00002937 case Intrinsic::cttz: {
Amaury Sechet6bea6742016-08-04 05:27:20 +00002938 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Nikita Popov20853a72018-12-18 19:59:50 +00002939 if (C == BitWidth) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002940 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002941 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002942 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002943 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002944 }
Nikita Popov20853a72018-12-18 19:59:50 +00002945
2946 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set
2947 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits.
2948 // Limit to one use to ensure we don't increase instruction count.
2949 unsigned Num = C.getLimitedValue(BitWidth);
2950 if (Num != BitWidth && II->hasOneUse()) {
2951 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz;
2952 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1)
2953 : APInt::getHighBitsSet(BitWidth, Num + 1);
2954 APInt Mask2 = IsTrailing
2955 ? APInt::getOneBitSet(BitWidth, Num)
2956 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
2957 Cmp.setOperand(0, Builder.CreateAnd(II->getArgOperand(0), Mask1));
2958 Cmp.setOperand(1, ConstantInt::get(Ty, Mask2));
2959 Worklist.Add(II);
2960 return &Cmp;
2961 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002962 break;
Nikita Popov20853a72018-12-18 19:59:50 +00002963 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002964
Amaury Sechet6bea6742016-08-04 05:27:20 +00002965 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002966 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002967 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002968 bool IsZero = C.isNullValue();
Nikita Popov20853a72018-12-18 19:59:50 +00002969 if (IsZero || C == BitWidth) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002970 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002971 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002972 auto *NewOp =
2973 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002974 Cmp.setOperand(1, NewOp);
2975 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002976 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002977 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002978 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002979 default:
2980 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002981 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002982
Craig Topperf40110f2014-04-25 05:29:35 +00002983 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002984}
2985
Nikita Popov6515db22019-01-19 09:56:01 +00002986/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2987Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
2988 IntrinsicInst *II,
2989 const APInt &C) {
2990 if (Cmp.isEquality())
2991 return foldICmpEqIntrinsicWithConstant(Cmp, II, C);
2992
2993 Type *Ty = II->getType();
2994 unsigned BitWidth = C.getBitWidth();
2995 switch (II->getIntrinsicID()) {
2996 case Intrinsic::ctlz: {
2997 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000
2998 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
2999 unsigned Num = C.getLimitedValue();
3000 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
3001 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT,
3002 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
3003 }
3004
3005 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111
3006 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3007 C.uge(1) && C.ule(BitWidth)) {
3008 unsigned Num = C.getLimitedValue();
3009 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num);
3010 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT,
3011 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
3012 }
3013 break;
3014 }
3015 case Intrinsic::cttz: {
3016 // Limit to one use to ensure we don't increase instruction count.
3017 if (!II->hasOneUse())
3018 return nullptr;
3019
3020 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0
3021 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
3022 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1);
3023 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ,
3024 Builder.CreateAnd(II->getArgOperand(0), Mask),
3025 ConstantInt::getNullValue(Ty));
3026 }
3027
3028 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0
3029 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3030 C.uge(1) && C.ule(BitWidth)) {
3031 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue());
3032 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE,
3033 Builder.CreateAnd(II->getArgOperand(0), Mask),
3034 ConstantInt::getNullValue(Ty));
3035 }
3036 break;
3037 }
3038 default:
3039 break;
3040 }
3041
3042 return nullptr;
3043}
3044
Sanjay Patel10494b22016-09-16 16:10:22 +00003045/// Handle icmp with constant (but not simple integer constant) RHS.
3046Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
3047 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3048 Constant *RHSC = dyn_cast<Constant>(Op1);
3049 Instruction *LHSI = dyn_cast<Instruction>(Op0);
3050 if (!RHSC || !LHSI)
3051 return nullptr;
3052
3053 switch (LHSI->getOpcode()) {
3054 case Instruction::GetElementPtr:
3055 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
3056 if (RHSC->isNullValue() &&
3057 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
3058 return new ICmpInst(
3059 I.getPredicate(), LHSI->getOperand(0),
3060 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3061 break;
3062 case Instruction::PHI:
3063 // Only fold icmp into the PHI if the phi and icmp are in the same
3064 // block. If in the same block, we're encouraging jump threading. If
3065 // not, we are just pessimizing the code by making an i1 phi.
3066 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00003067 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00003068 return NV;
3069 break;
3070 case Instruction::Select: {
3071 // If either operand of the select is a constant, we can fold the
3072 // comparison into the select arms, which will cause one to be
3073 // constant folded and the select turned into a bitwise or.
3074 Value *Op1 = nullptr, *Op2 = nullptr;
3075 ConstantInt *CI = nullptr;
3076 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
3077 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3078 CI = dyn_cast<ConstantInt>(Op1);
3079 }
3080 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
3081 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3082 CI = dyn_cast<ConstantInt>(Op2);
3083 }
3084
3085 // We only want to perform this transformation if it will not lead to
3086 // additional code. This is true if either both sides of the select
3087 // fold to a constant (in which case the icmp is replaced with a select
3088 // which will usually simplify) or this is the only user of the
3089 // select (in which case we are trading a select+icmp for a simpler
3090 // select+icmp) or all uses of the select can be replaced based on
3091 // dominance information ("Global cases").
3092 bool Transform = false;
3093 if (Op1 && Op2)
3094 Transform = true;
3095 else if (Op1 || Op2) {
3096 // Local case
3097 if (LHSI->hasOneUse())
3098 Transform = true;
3099 // Global cases
3100 else if (CI && !CI->isZero())
3101 // When Op1 is constant try replacing select with second operand.
3102 // Otherwise Op2 is constant and try replacing select with first
3103 // operand.
3104 Transform =
3105 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
3106 }
3107 if (Transform) {
3108 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00003109 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
3110 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003111 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00003112 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
3113 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003114 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
3115 }
3116 break;
3117 }
3118 case Instruction::IntToPtr:
3119 // icmp pred inttoptr(X), null -> icmp pred X, 0
3120 if (RHSC->isNullValue() &&
3121 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
3122 return new ICmpInst(
3123 I.getPredicate(), LHSI->getOperand(0),
3124 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3125 break;
3126
3127 case Instruction::Load:
3128 // Try to optimize things like "A[i] > 4" to index computations.
3129 if (GetElementPtrInst *GEP =
3130 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
3131 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
3132 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
3133 !cast<LoadInst>(LHSI)->isVolatile())
3134 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
3135 return Res;
3136 }
3137 break;
3138 }
3139
3140 return nullptr;
3141}
3142
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003143/// Some comparisons can be simplified.
3144/// In this case, we are looking for comparisons that look like
3145/// a check for a lossy truncation.
3146/// Folds:
Roman Lebedev183a4652018-09-19 13:35:27 +00003147/// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask
3148/// Where Mask is some pattern that produces all-ones in low bits:
3149/// (-1 >> y)
Roman Lebedevf50023d2018-09-19 13:35:46 +00003150/// ((-1 << y) >> y) <- non-canonical, has extra uses
Roman Lebedev183a4652018-09-19 13:35:27 +00003151/// ~(-1 << y)
Roman Lebedevca2bdb02018-09-19 13:35:40 +00003152/// ((1 << y) + (-1)) <- non-canonical, has extra uses
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003153/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003154/// For some predicates, the operands are commutative.
3155/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003156static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
3157 InstCombiner::BuilderTy &Builder) {
3158 ICmpInst::Predicate SrcPred;
Roman Lebedevf50023d2018-09-19 13:35:46 +00003159 Value *X, *M, *Y;
3160 auto m_VariableMask = m_CombineOr(
3161 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())),
3162 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())),
3163 m_CombineOr(m_LShr(m_AllOnes(), m_Value()),
3164 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y))));
Roman Lebedev183a4652018-09-19 13:35:27 +00003165 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask());
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003166 if (!match(&I, m_c_ICmp(SrcPred,
3167 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
3168 m_Deferred(X))))
3169 return nullptr;
3170
3171 ICmpInst::Predicate DstPred;
3172 switch (SrcPred) {
3173 case ICmpInst::Predicate::ICMP_EQ:
3174 // x & (-1 >> y) == x -> x u<= (-1 >> y)
3175 DstPred = ICmpInst::Predicate::ICMP_ULE;
3176 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00003177 case ICmpInst::Predicate::ICMP_NE:
3178 // x & (-1 >> y) != x -> x u> (-1 >> y)
3179 DstPred = ICmpInst::Predicate::ICMP_UGT;
3180 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00003181 case ICmpInst::Predicate::ICMP_UGT:
3182 // x u> x & (-1 >> y) -> x u> (-1 >> y)
3183 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3184 DstPred = ICmpInst::Predicate::ICMP_UGT;
3185 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00003186 case ICmpInst::Predicate::ICMP_UGE:
3187 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
3188 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3189 DstPred = ICmpInst::Predicate::ICMP_ULE;
3190 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00003191 case ICmpInst::Predicate::ICMP_ULT:
3192 // x & (-1 >> y) u< x -> x u> (-1 >> y)
3193 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3194 DstPred = ICmpInst::Predicate::ICMP_UGT;
3195 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00003196 case ICmpInst::Predicate::ICMP_ULE:
3197 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
3198 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3199 DstPred = ICmpInst::Predicate::ICMP_ULE;
3200 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003201 case ICmpInst::Predicate::ICMP_SGT:
3202 // x s> x & (-1 >> y) -> x s> (-1 >> y)
3203 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3204 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003205 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3206 return nullptr;
3207 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3208 return nullptr;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003209 DstPred = ICmpInst::Predicate::ICMP_SGT;
3210 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00003211 case ICmpInst::Predicate::ICMP_SGE:
3212 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
3213 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3214 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003215 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3216 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003217 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3218 return nullptr;
Roman Lebedevf1442612018-07-14 20:08:37 +00003219 DstPred = ICmpInst::Predicate::ICMP_SLE;
3220 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003221 case ICmpInst::Predicate::ICMP_SLT:
3222 // x & (-1 >> y) s< x -> x s> (-1 >> y)
3223 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3224 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003225 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3226 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003227 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3228 return nullptr;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003229 DstPred = ICmpInst::Predicate::ICMP_SGT;
3230 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003231 case ICmpInst::Predicate::ICMP_SLE:
3232 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
3233 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3234 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003235 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3236 return nullptr;
3237 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3238 return nullptr;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003239 DstPred = ICmpInst::Predicate::ICMP_SLE;
3240 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003241 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003242 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003243 }
3244
3245 return Builder.CreateICmp(DstPred, X, M);
3246}
3247
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003248/// Some comparisons can be simplified.
3249/// In this case, we are looking for comparisons that look like
3250/// a check for a lossy signed truncation.
3251/// Folds: (MaskedBits is a constant.)
3252/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
3253/// Into:
3254/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
3255/// Where KeptBits = bitwidth(%x) - MaskedBits
3256static Value *
3257foldICmpWithTruncSignExtendedVal(ICmpInst &I,
3258 InstCombiner::BuilderTy &Builder) {
3259 ICmpInst::Predicate SrcPred;
3260 Value *X;
3261 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
3262 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
3263 if (!match(&I, m_c_ICmp(SrcPred,
3264 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
3265 m_APInt(C1))),
3266 m_Deferred(X))))
3267 return nullptr;
3268
3269 // Potential handling of non-splats: for each element:
3270 // * if both are undef, replace with constant 0.
3271 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
3272 // * if both are not undef, and are different, bailout.
3273 // * else, only one is undef, then pick the non-undef one.
3274
3275 // The shift amount must be equal.
3276 if (*C0 != *C1)
3277 return nullptr;
3278 const APInt &MaskedBits = *C0;
3279 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
3280
3281 ICmpInst::Predicate DstPred;
3282 switch (SrcPred) {
3283 case ICmpInst::Predicate::ICMP_EQ:
3284 // ((%x << MaskedBits) a>> MaskedBits) == %x
3285 // =>
3286 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
3287 DstPred = ICmpInst::Predicate::ICMP_ULT;
3288 break;
3289 case ICmpInst::Predicate::ICMP_NE:
3290 // ((%x << MaskedBits) a>> MaskedBits) != %x
3291 // =>
3292 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
3293 DstPred = ICmpInst::Predicate::ICMP_UGE;
3294 break;
3295 // FIXME: are more folds possible?
3296 default:
3297 return nullptr;
3298 }
3299
3300 auto *XType = X->getType();
3301 const unsigned XBitWidth = XType->getScalarSizeInBits();
3302 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3303 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3304
3305 // KeptBits = bitwidth(%x) - MaskedBits
3306 const APInt KeptBits = BitWidth - MaskedBits;
3307 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3308 // ICmpCst = (1 << KeptBits)
3309 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3310 assert(ICmpCst.isPowerOf2());
3311 // AddCst = (1 << (KeptBits-1))
3312 const APInt AddCst = ICmpCst.lshr(1);
3313 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3314
3315 // T0 = add %x, AddCst
3316 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3317 // T1 = T0 DstPred ICmpCst
3318 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3319
3320 return T1;
3321}
3322
Roman Lebedev72b8d412019-07-01 15:55:15 +00003323// Given pattern:
3324// icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0
3325// we should move shifts to the same hand of 'and', i.e. rewrite as
3326// icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x)
3327// We are only interested in opposite logical shifts here.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003328// One of the shifts can be truncated. For now, it can only be 'shl'.
Roman Lebedev72b8d412019-07-01 15:55:15 +00003329// If we can, we want to end up creating 'lshr' shift.
3330static Value *
3331foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ,
3332 InstCombiner::BuilderTy &Builder) {
3333 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) ||
3334 !I.getOperand(0)->hasOneUse())
3335 return nullptr;
3336
3337 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value());
Roman Lebedev72b8d412019-07-01 15:55:15 +00003338
Roman Lebedev16244fc2019-08-16 15:10:41 +00003339 // Look for an 'and' of two logical shifts, one of which may be truncated.
3340 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case.
3341 Instruction *XShift, *MaybeTruncation, *YShift;
3342 if (!match(
3343 I.getOperand(0),
3344 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)),
3345 m_CombineAnd(m_TruncOrSelf(m_CombineAnd(
3346 m_AnyLogicalShift, m_Instruction(YShift))),
3347 m_Instruction(MaybeTruncation)))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003348 return nullptr;
3349
Roman Lebedev16244fc2019-08-16 15:10:41 +00003350 // We potentially looked past 'trunc', but only when matching YShift,
3351 // therefore YShift must have the widest type.
Roman Lebedev9b957d32019-08-18 12:26:33 +00003352 Instruction *WidestShift = YShift;
3353 // Therefore XShift must have the shallowest type.
3354 // Or they both have identical types if there was no truncation.
3355 Instruction *NarrowestShift = XShift;
3356
3357 Type *WidestTy = WidestShift->getType();
3358 assert(NarrowestShift->getType() == I.getOperand(0)->getType() &&
Roman Lebedev16244fc2019-08-16 15:10:41 +00003359 "We did not look past any shifts while matching XShift though.");
3360 bool HadTrunc = WidestTy != I.getOperand(0)->getType();
3361
3362 if (HadTrunc) {
3363 // We did indeed have a truncation. For now, let's only proceed if the 'shl'
3364 // was truncated, since that does not require any extra legality checks.
3365 // FIXME: trunc-of-lshr.
3366 if (!match(YShift, m_Shl(m_Value(), m_Value())))
3367 return nullptr;
3368 }
3369
Roman Lebedev64fe8062019-08-10 19:28:44 +00003370 // If YShift is a 'lshr', swap the shifts around.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003371 if (match(YShift, m_LShr(m_Value(), m_Value())))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003372 std::swap(XShift, YShift);
3373
3374 // The shifts must be in opposite directions.
Roman Lebedevccdad6e2019-08-12 11:28:02 +00003375 auto XShiftOpcode = XShift->getOpcode();
3376 if (XShiftOpcode == YShift->getOpcode())
Roman Lebedev72b8d412019-07-01 15:55:15 +00003377 return nullptr; // Do not care about same-direction shifts here.
3378
3379 Value *X, *XShAmt, *Y, *YShAmt;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003380 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt))));
3381 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt))));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003382
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003383 // If one of the values being shifted is a constant, then we will end with
Roman Lebedev16244fc2019-08-16 15:10:41 +00003384 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not,
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003385 // however, we will need to ensure that we won't increase instruction count.
3386 if (!isa<Constant>(X) && !isa<Constant>(Y)) {
3387 // At least one of the hands of the 'and' should be one-use shift.
3388 if (!match(I.getOperand(0),
3389 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value())))
3390 return nullptr;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003391 if (HadTrunc) {
3392 // Due to the 'trunc', we will need to widen X. For that either the old
3393 // 'trunc' or the shift amt in the non-truncated shift should be one-use.
3394 if (!MaybeTruncation->hasOneUse() &&
Roman Lebedev9b957d32019-08-18 12:26:33 +00003395 !NarrowestShift->getOperand(1)->hasOneUse())
Roman Lebedev16244fc2019-08-16 15:10:41 +00003396 return nullptr;
3397 }
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003398 }
3399
Roman Lebedev16244fc2019-08-16 15:10:41 +00003400 // We have two shift amounts from two different shifts. The types of those
3401 // shift amounts may not match. If that's the case let's bailout now.
3402 if (XShAmt->getType() != YShAmt->getType())
3403 return nullptr;
3404
Roman Lebedev72b8d412019-07-01 15:55:15 +00003405 // Can we fold (XShAmt+YShAmt) ?
Roman Lebedev16244fc2019-08-16 15:10:41 +00003406 auto *NewShAmt = dyn_cast_or_null<Constant>(
3407 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false,
3408 /*isNUW=*/false, SQ.getWithInstruction(&I)));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003409 if (!NewShAmt)
3410 return nullptr;
3411 // Is the new shift amount smaller than the bit width?
3412 // FIXME: could also rely on ConstantRange.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003413 if (!match(NewShAmt, m_SpecificInt_ICMP(
3414 ICmpInst::Predicate::ICMP_ULT,
3415 APInt(NewShAmt->getType()->getScalarSizeInBits(),
3416 WidestTy->getScalarSizeInBits()))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003417 return nullptr;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003418 // All good, we can do this fold.
3419 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy);
3420 X = Builder.CreateZExt(X, WidestTy);
3421 // The shift is the same that was for X.
Roman Lebedev72b8d412019-07-01 15:55:15 +00003422 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr
3423 ? Builder.CreateLShr(X, NewShAmt)
3424 : Builder.CreateShl(X, NewShAmt);
3425 Value *T1 = Builder.CreateAnd(T0, Y);
3426 return Builder.CreateICmp(I.getPredicate(), T1,
Roman Lebedev16244fc2019-08-16 15:10:41 +00003427 Constant::getNullValue(WidestTy));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003428}
3429
Sanjay Patel10494b22016-09-16 16:10:22 +00003430/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003431/// TODO: A large part of this logic is duplicated in InstSimplify's
3432/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3433/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00003434Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
3435 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3436
3437 // Special logic for binary operators.
3438 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3439 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3440 if (!BO0 && !BO1)
3441 return nullptr;
3442
Sanjay Patel2a062632017-05-08 16:33:42 +00003443 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel1cf07342018-09-11 22:40:20 +00003444 Value *X;
3445
3446 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare.
3447 // (Op1 + X) <u Op1 --> ~Op1 <u X
3448 // Op0 >u (Op0 + X) --> X >u ~Op0
3449 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) &&
3450 Pred == ICmpInst::ICMP_ULT)
3451 return new ICmpInst(Pred, Builder.CreateNot(Op1), X);
3452 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) &&
3453 Pred == ICmpInst::ICMP_UGT)
3454 return new ICmpInst(Pred, X, Builder.CreateNot(Op0));
3455
Sanjay Patel10494b22016-09-16 16:10:22 +00003456 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3457 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3458 NoOp0WrapProblem =
3459 ICmpInst::isEquality(Pred) ||
3460 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3461 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3462 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3463 NoOp1WrapProblem =
3464 ICmpInst::isEquality(Pred) ||
3465 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3466 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3467
3468 // Analyze the case when either Op0 or Op1 is an add instruction.
3469 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3470 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3471 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3472 A = BO0->getOperand(0);
3473 B = BO0->getOperand(1);
3474 }
3475 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3476 C = BO1->getOperand(0);
3477 D = BO1->getOperand(1);
3478 }
3479
Sanjay Patel10494b22016-09-16 16:10:22 +00003480 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
3481 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3482 return new ICmpInst(Pred, A == Op1 ? B : A,
3483 Constant::getNullValue(Op1->getType()));
3484
3485 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
3486 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3487 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3488 C == Op0 ? D : C);
3489
3490 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
3491 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
3492 NoOp1WrapProblem &&
3493 // Try not to increase register pressure.
3494 BO0->hasOneUse() && BO1->hasOneUse()) {
3495 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3496 Value *Y, *Z;
3497 if (A == C) {
3498 // C + B == C + D -> B == D
3499 Y = B;
3500 Z = D;
3501 } else if (A == D) {
3502 // D + B == C + D -> B == C
3503 Y = B;
3504 Z = C;
3505 } else if (B == C) {
3506 // A + C == C + D -> A == D
3507 Y = A;
3508 Z = D;
3509 } else {
3510 assert(B == D);
3511 // A + D == C + D -> A == C
3512 Y = A;
3513 Z = C;
3514 }
3515 return new ICmpInst(Pred, Y, Z);
3516 }
3517
3518 // icmp slt (X + -1), Y -> icmp sle X, Y
3519 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3520 match(B, m_AllOnes()))
3521 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3522
3523 // icmp sge (X + -1), Y -> icmp sgt X, Y
3524 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3525 match(B, m_AllOnes()))
3526 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3527
3528 // icmp sle (X + 1), Y -> icmp slt X, Y
3529 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3530 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3531
3532 // icmp sgt (X + 1), Y -> icmp sge X, Y
3533 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3534 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3535
3536 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3537 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3538 match(D, m_AllOnes()))
3539 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3540
3541 // icmp sle X, (Y + -1) -> icmp slt X, Y
3542 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3543 match(D, m_AllOnes()))
3544 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3545
3546 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3547 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3548 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3549
3550 // icmp slt X, (Y + 1) -> icmp sle X, Y
3551 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3552 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3553
Sanjay Patel40f40172017-01-13 23:25:46 +00003554 // TODO: The subtraction-related identities shown below also hold, but
3555 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3556 // wouldn't happen even if they were implemented.
3557 //
3558 // icmp ult (X - 1), Y -> icmp ule X, Y
3559 // icmp uge (X - 1), Y -> icmp ugt X, Y
3560 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3561 // icmp ule X, (Y - 1) -> icmp ult X, Y
3562
3563 // icmp ule (X + 1), Y -> icmp ult X, Y
3564 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3565 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3566
3567 // icmp ugt (X + 1), Y -> icmp uge X, Y
3568 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3569 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3570
3571 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3572 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3573 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3574
3575 // icmp ult X, (Y + 1) -> icmp ule X, Y
3576 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3577 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3578
Sanjay Patel10494b22016-09-16 16:10:22 +00003579 // if C1 has greater magnitude than C2:
3580 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3581 // s.t. C3 = C1 - C2
3582 //
3583 // if C2 has greater magnitude than C1:
3584 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3585 // s.t. C3 = C2 - C1
3586 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3587 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3588 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3589 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3590 const APInt &AP1 = C1->getValue();
3591 const APInt &AP2 = C2->getValue();
3592 if (AP1.isNegative() == AP2.isNegative()) {
3593 APInt AP1Abs = C1->getValue().abs();
3594 APInt AP2Abs = C2->getValue().abs();
3595 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003596 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3597 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003598 return new ICmpInst(Pred, NewAdd, C);
3599 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003600 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3601 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003602 return new ICmpInst(Pred, A, NewAdd);
3603 }
3604 }
3605 }
3606
3607 // Analyze the case when either Op0 or Op1 is a sub instruction.
3608 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3609 A = nullptr;
3610 B = nullptr;
3611 C = nullptr;
3612 D = nullptr;
3613 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3614 A = BO0->getOperand(0);
3615 B = BO0->getOperand(1);
3616 }
3617 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3618 C = BO1->getOperand(0);
3619 D = BO1->getOperand(1);
3620 }
3621
3622 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3623 if (A == Op1 && NoOp0WrapProblem)
3624 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003625 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3626 if (C == Op0 && NoOp1WrapProblem)
3627 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3628
Sanjay Patelcbb04502018-04-02 20:37:40 +00003629 // (A - B) >u A --> A <u B
3630 if (A == Op1 && Pred == ICmpInst::ICMP_UGT)
3631 return new ICmpInst(ICmpInst::ICMP_ULT, A, B);
3632 // C <u (C - D) --> C <u D
3633 if (C == Op0 && Pred == ICmpInst::ICMP_ULT)
3634 return new ICmpInst(ICmpInst::ICMP_ULT, C, D);
3635
Sanjay Patel10494b22016-09-16 16:10:22 +00003636 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3637 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3638 // Try not to increase register pressure.
3639 BO0->hasOneUse() && BO1->hasOneUse())
3640 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003641 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3642 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3643 // Try not to increase register pressure.
3644 BO0->hasOneUse() && BO1->hasOneUse())
3645 return new ICmpInst(Pred, D, B);
3646
3647 // icmp (0-X) < cst --> x > -cst
3648 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3649 Value *X;
3650 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003651 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3652 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003653 return new ICmpInst(I.getSwappedPredicate(), X,
3654 ConstantExpr::getNeg(RHSC));
3655 }
3656
3657 BinaryOperator *SRem = nullptr;
3658 // icmp (srem X, Y), Y
3659 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3660 SRem = BO0;
3661 // icmp Y, (srem X, Y)
3662 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3663 Op0 == BO1->getOperand(1))
3664 SRem = BO1;
3665 if (SRem) {
3666 // We don't check hasOneUse to avoid increasing register pressure because
3667 // the value we use is the same value this instruction was already using.
3668 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3669 default:
3670 break;
3671 case ICmpInst::ICMP_EQ:
3672 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3673 case ICmpInst::ICMP_NE:
3674 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3675 case ICmpInst::ICMP_SGT:
3676 case ICmpInst::ICMP_SGE:
3677 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3678 Constant::getAllOnesValue(SRem->getType()));
3679 case ICmpInst::ICMP_SLT:
3680 case ICmpInst::ICMP_SLE:
3681 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3682 Constant::getNullValue(SRem->getType()));
3683 }
3684 }
3685
3686 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3687 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3688 switch (BO0->getOpcode()) {
3689 default:
3690 break;
3691 case Instruction::Add:
3692 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003693 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003694 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003695 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003696
3697 const APInt *C;
3698 if (match(BO0->getOperand(1), m_APInt(C))) {
3699 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3700 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003701 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003702 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003703 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003704 }
3705
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003706 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3707 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003708 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003709 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003710 NewPred = I.getSwappedPredicate(NewPred);
3711 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003712 }
3713 }
3714 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003715 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003716 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003717 if (!I.isEquality())
3718 break;
3719
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003720 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003721 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3722 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003723 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3724 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003725 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003726 Constant *Mask = ConstantInt::get(
3727 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003728 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003729 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3730 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003731 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003732 }
Sanjay Patel51506122017-05-25 14:13:57 +00003733 // If there are no trailing zeros in the multiplier, just eliminate
3734 // the multiplies (no masking is needed):
3735 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3736 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003737 }
3738 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003739 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003740 case Instruction::UDiv:
3741 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003742 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003743 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003744 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3745
Sanjay Patel10494b22016-09-16 16:10:22 +00003746 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003747 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3748 break;
3749 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3750
Sanjay Patel10494b22016-09-16 16:10:22 +00003751 case Instruction::AShr:
3752 if (!BO0->isExact() || !BO1->isExact())
3753 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003754 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003755
Sanjay Patel10494b22016-09-16 16:10:22 +00003756 case Instruction::Shl: {
3757 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3758 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3759 if (!NUW && !NSW)
3760 break;
3761 if (!NSW && I.isSigned())
3762 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003763 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003764 }
3765 }
3766 }
3767
3768 if (BO0) {
3769 // Transform A & (L - 1) `ult` L --> L != 0
3770 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003771 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003772
Sanjay Patel2a062632017-05-08 16:33:42 +00003773 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003774 auto *Zero = Constant::getNullValue(BO0->getType());
3775 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3776 }
3777 }
3778
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003779 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3780 return replaceInstUsesWith(I, V);
3781
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003782 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
3783 return replaceInstUsesWith(I, V);
3784
Roman Lebedev72b8d412019-07-01 15:55:15 +00003785 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder))
3786 return replaceInstUsesWith(I, V);
3787
Sanjay Patel10494b22016-09-16 16:10:22 +00003788 return nullptr;
3789}
3790
Sanjay Pateldd46b522016-12-19 17:32:37 +00003791/// Fold icmp Pred min|max(X, Y), X.
3792static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003793 ICmpInst::Predicate Pred = Cmp.getPredicate();
3794 Value *Op0 = Cmp.getOperand(0);
3795 Value *X = Cmp.getOperand(1);
3796
Sanjay Pateldd46b522016-12-19 17:32:37 +00003797 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003798 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003799 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3800 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3801 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003802 std::swap(Op0, X);
3803 Pred = Cmp.getSwappedPredicate();
3804 }
3805
3806 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003807 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003808 // smin(X, Y) == X --> X s<= Y
3809 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003810 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3811 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3812
Sanjay Pateldd46b522016-12-19 17:32:37 +00003813 // smin(X, Y) != X --> X s> Y
3814 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003815 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3816 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3817
3818 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003819 // smin(X, Y) s<= X --> true
3820 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003821 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003822 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003823
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003824 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003825 // smax(X, Y) == X --> X s>= Y
3826 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003827 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3828 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003829
Sanjay Pateldd46b522016-12-19 17:32:37 +00003830 // smax(X, Y) != X --> X s< Y
3831 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003832 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3833 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003834
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003835 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003836 // smax(X, Y) s>= X --> true
3837 // smax(X, Y) s< X --> false
3838 return nullptr;
3839 }
3840
3841 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3842 // umin(X, Y) == X --> X u<= Y
3843 // umin(X, Y) u>= X --> X u<= Y
3844 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3845 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3846
3847 // umin(X, Y) != X --> X u> Y
3848 // umin(X, Y) u< X --> X u> Y
3849 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3850 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3851
3852 // These cases should be handled in InstSimplify:
3853 // umin(X, Y) u<= X --> true
3854 // umin(X, Y) u> X --> false
3855 return nullptr;
3856 }
3857
3858 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3859 // umax(X, Y) == X --> X u>= Y
3860 // umax(X, Y) u<= X --> X u>= Y
3861 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3862 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3863
3864 // umax(X, Y) != X --> X u< Y
3865 // umax(X, Y) u> X --> X u< Y
3866 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3867 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3868
3869 // These cases should be handled in InstSimplify:
3870 // umax(X, Y) u>= X --> true
3871 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003872 return nullptr;
3873 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003874
Sanjay Pateld6406412016-12-15 19:13:37 +00003875 return nullptr;
3876}
3877
Sanjay Patel10494b22016-09-16 16:10:22 +00003878Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3879 if (!I.isEquality())
3880 return nullptr;
3881
3882 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003883 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003884 Value *A, *B, *C, *D;
3885 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3886 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3887 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003888 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003889 }
3890
3891 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3892 // A^c1 == C^c2 --> A == C^(c1^c2)
3893 ConstantInt *C1, *C2;
3894 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3895 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003896 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3897 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003898 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003899 }
3900
3901 // A^B == A^D -> B == D
3902 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003903 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003904 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003905 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003906 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003907 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003908 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003909 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003910 }
3911 }
3912
3913 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3914 // A == (A^B) -> B == 0
3915 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003916 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003917 }
3918
3919 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3920 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3921 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3922 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3923
3924 if (A == C) {
3925 X = B;
3926 Y = D;
3927 Z = A;
3928 } else if (A == D) {
3929 X = B;
3930 Y = C;
3931 Z = A;
3932 } else if (B == C) {
3933 X = A;
3934 Y = D;
3935 Z = B;
3936 } else if (B == D) {
3937 X = A;
3938 Y = C;
3939 Z = B;
3940 }
3941
3942 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003943 Op1 = Builder.CreateXor(X, Y);
3944 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003945 I.setOperand(0, Op1);
3946 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3947 return &I;
3948 }
3949 }
3950
3951 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3952 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3953 ConstantInt *Cst1;
3954 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3955 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3956 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3957 match(Op1, m_ZExt(m_Value(A))))) {
3958 APInt Pow2 = Cst1->getValue() + 1;
3959 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3960 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003961 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003962 }
3963
3964 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3965 // For lshr and ashr pairs.
3966 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3967 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3968 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3969 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3970 unsigned TypeBits = Cst1->getBitWidth();
3971 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3972 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003973 ICmpInst::Predicate NewPred =
3974 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003975 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003976 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003977 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003978 }
3979 }
3980
3981 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3982 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3983 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3984 unsigned TypeBits = Cst1->getBitWidth();
3985 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3986 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003987 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003988 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003989 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003990 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003991 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003992 }
3993 }
3994
3995 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3996 // "icmp (and X, mask), cst"
3997 uint64_t ShAmt = 0;
3998 if (Op0->hasOneUse() &&
3999 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
4000 match(Op1, m_ConstantInt(Cst1)) &&
4001 // Only do this when A has multiple uses. This is most important to do
4002 // when it exposes other optimizations.
4003 !A->hasOneUse()) {
4004 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
4005
4006 if (ShAmt < ASize) {
4007 APInt MaskV =
4008 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
4009 MaskV <<= ShAmt;
4010
4011 APInt CmpV = Cst1->getValue().zext(ASize);
4012 CmpV <<= ShAmt;
4013
Craig Topperbb4069e2017-07-07 23:16:26 +00004014 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
4015 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00004016 }
4017 }
4018
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00004019 // If both operands are byte-swapped or bit-reversed, just compare the
4020 // original values.
4021 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
4022 // and handle more intrinsics.
4023 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00004024 (match(Op0, m_BitReverse(m_Value(A))) &&
4025 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00004026 return new ICmpInst(Pred, A, B);
4027
Sanjay Patel63311bf2019-06-20 17:41:15 +00004028 // Canonicalize checking for a power-of-2-or-zero value:
Sanjay Patelddc1b402019-07-01 22:00:00 +00004029 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants)
4030 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants)
4031 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()),
4032 m_Deferred(A)))) ||
4033 !match(Op1, m_ZeroInt()))
4034 A = nullptr;
4035
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004036 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants)
4037 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants)
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004038 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00004039 A = Op1;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004040 else if (match(Op1,
4041 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00004042 A = Op0;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004043
Sanjay Patel63311bf2019-06-20 17:41:15 +00004044 if (A) {
4045 Type *Ty = A->getType();
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004046 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A);
4047 return Pred == ICmpInst::ICMP_EQ
4048 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2))
4049 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1));
Sanjay Patel63311bf2019-06-20 17:41:15 +00004050 }
4051
Sanjay Patel10494b22016-09-16 16:10:22 +00004052 return nullptr;
4053}
4054
Sanjay Patele7282592019-08-21 11:56:08 +00004055static Instruction *foldICmpWithZextOrSext(ICmpInst &ICmp,
4056 InstCombiner::BuilderTy &Builder) {
Sanjay Patel292b1082019-08-20 18:15:17 +00004057 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0");
4058 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0));
4059 Value *X;
4060 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X))))
4061 return nullptr;
4062
4063 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt;
4064 bool IsSignedCmp = ICmp.isSigned();
4065 if (auto *CastOp1 = dyn_cast<CastInst>(ICmp.getOperand(1))) {
4066 // If the signedness of the two casts doesn't agree (i.e. one is a sext
4067 // and the other is a zext), then we can't handle this.
Sanjay Patele7282592019-08-21 11:56:08 +00004068 // TODO: This is too strict. We can handle some predicates (equality?).
Sanjay Patel292b1082019-08-20 18:15:17 +00004069 if (CastOp0->getOpcode() != CastOp1->getOpcode())
4070 return nullptr;
4071
4072 // Not an extension from the same type?
Sanjay Patel292b1082019-08-20 18:15:17 +00004073 Value *Y = CastOp1->getOperand(0);
Sanjay Patele7282592019-08-21 11:56:08 +00004074 Type *XTy = X->getType(), *YTy = Y->getType();
4075 if (XTy != YTy) {
4076 // One of the casts must have one use because we are creating a new cast.
4077 if (!CastOp0->hasOneUse() && !CastOp1->hasOneUse())
4078 return nullptr;
4079 // Extend the narrower operand to the type of the wider operand.
4080 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits())
4081 X = Builder.CreateCast(CastOp0->getOpcode(), X, YTy);
4082 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits())
4083 Y = Builder.CreateCast(CastOp0->getOpcode(), Y, XTy);
4084 else
4085 return nullptr;
4086 }
Sanjay Patel292b1082019-08-20 18:15:17 +00004087
4088 // (zext X) == (zext Y) --> X == Y
4089 // (sext X) == (sext Y) --> X == Y
4090 if (ICmp.isEquality())
4091 return new ICmpInst(ICmp.getPredicate(), X, Y);
4092
4093 // A signed comparison of sign extended values simplifies into a
4094 // signed comparison.
4095 if (IsSignedCmp && IsSignedExt)
4096 return new ICmpInst(ICmp.getPredicate(), X, Y);
4097
4098 // The other three cases all fold into an unsigned comparison.
4099 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y);
4100 }
4101
4102 // Below here, we are only folding a compare with constant.
4103 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
4104 if (!C)
4105 return nullptr;
4106
4107 // Compute the constant that would happen if we truncated to SrcTy then
4108 // re-extended to DestTy.
4109 Type *SrcTy = CastOp0->getSrcTy();
4110 Type *DestTy = CastOp0->getDestTy();
4111 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
4112 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy);
4113
4114 // If the re-extended constant didn't change...
4115 if (Res2 == C) {
4116 if (ICmp.isEquality())
4117 return new ICmpInst(ICmp.getPredicate(), X, Res1);
4118
4119 // A signed comparison of sign extended values simplifies into a
4120 // signed comparison.
4121 if (IsSignedExt && IsSignedCmp)
4122 return new ICmpInst(ICmp.getPredicate(), X, Res1);
4123
4124 // The other three cases all fold into an unsigned comparison.
4125 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1);
4126 }
4127
4128 // The re-extended constant changed, partly changed (in the case of a vector),
4129 // or could not be determined to be equal (in the case of a constant
4130 // expression), so the constant cannot be represented in the shorter type.
4131 // All the cases that fold to true or false will have already been handled
4132 // by SimplifyICmpInst, so only deal with the tricky case.
4133 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C))
4134 return nullptr;
4135
4136 // Is source op positive?
4137 // icmp ult (sext X), C --> icmp sgt X, -1
4138 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
4139 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy));
4140
4141 // Is source op negative?
4142 // icmp ugt (sext X), C --> icmp slt X, 0
4143 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
4144 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy));
4145}
4146
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004147/// Handle icmp (cast x), (cast or constant).
4148Instruction *InstCombiner::foldICmpWithCastOp(ICmpInst &ICmp) {
4149 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0));
4150 if (!CastOp0)
4151 return nullptr;
4152 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1)))
4153 return nullptr;
4154
4155 Value *Op0Src = CastOp0->getOperand(0);
4156 Type *SrcTy = CastOp0->getSrcTy();
4157 Type *DestTy = CastOp0->getDestTy();
Chris Lattner2188e402010-01-04 07:37:31 +00004158
Jim Grosbach129c52a2011-09-30 18:09:53 +00004159 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00004160 // integer type is the same size as the pointer type.
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004161 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) {
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004162 if (isa<VectorType>(SrcTy)) {
4163 SrcTy = cast<VectorType>(SrcTy)->getElementType();
4164 DestTy = cast<VectorType>(DestTy)->getElementType();
4165 }
4166 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
4167 };
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004168 if (CastOp0->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004169 CompatibleSizes(SrcTy, DestTy)) {
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004170 Value *NewOp1 = nullptr;
4171 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
4172 Value *PtrSrc = PtrToIntOp1->getOperand(0);
4173 if (PtrSrc->getType()->getPointerAddressSpace() ==
4174 Op0Src->getType()->getPointerAddressSpace()) {
4175 NewOp1 = PtrToIntOp1->getOperand(0);
Michael Liaod266b922015-02-13 04:51:26 +00004176 // If the pointer types don't match, insert a bitcast.
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004177 if (Op0Src->getType() != NewOp1->getType())
4178 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType());
Michael Liaod266b922015-02-13 04:51:26 +00004179 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004180 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004181 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004182 }
Chris Lattner2188e402010-01-04 07:37:31 +00004183
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004184 if (NewOp1)
4185 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1);
Chris Lattner2188e402010-01-04 07:37:31 +00004186 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004187
Sanjay Patele7282592019-08-21 11:56:08 +00004188 return foldICmpWithZextOrSext(ICmp, Builder);
Chris Lattner2188e402010-01-04 07:37:31 +00004189}
4190
Nikita Popov39f2beb2019-05-26 11:43:37 +00004191static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) {
4192 switch (BinaryOp) {
4193 default:
4194 llvm_unreachable("Unsupported binary op");
4195 case Instruction::Add:
4196 case Instruction::Sub:
4197 return match(RHS, m_Zero());
4198 case Instruction::Mul:
4199 return match(RHS, m_One());
4200 }
4201}
4202
4203OverflowResult InstCombiner::computeOverflow(
4204 Instruction::BinaryOps BinaryOp, bool IsSigned,
4205 Value *LHS, Value *RHS, Instruction *CxtI) const {
4206 switch (BinaryOp) {
4207 default:
4208 llvm_unreachable("Unsupported binary op");
4209 case Instruction::Add:
4210 if (IsSigned)
4211 return computeOverflowForSignedAdd(LHS, RHS, CxtI);
4212 else
4213 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI);
4214 case Instruction::Sub:
4215 if (IsSigned)
4216 return computeOverflowForSignedSub(LHS, RHS, CxtI);
4217 else
4218 return computeOverflowForUnsignedSub(LHS, RHS, CxtI);
4219 case Instruction::Mul:
4220 if (IsSigned)
4221 return computeOverflowForSignedMul(LHS, RHS, CxtI);
4222 else
4223 return computeOverflowForUnsignedMul(LHS, RHS, CxtI);
4224 }
4225}
4226
Nikita Popov352f5982019-05-26 11:43:31 +00004227bool InstCombiner::OptimizeOverflowCheck(
4228 Instruction::BinaryOps BinaryOp, bool IsSigned, Value *LHS, Value *RHS,
4229 Instruction &OrigI, Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00004230 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
4231 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00004232
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004233 // If the overflow check was an add followed by a compare, the insertion point
4234 // may be pointing to the compare. We want to insert the new instructions
4235 // before the add in case there are uses of the add between the add and the
4236 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00004237 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004238
Nikita Popov39f2beb2019-05-26 11:43:37 +00004239 if (isNeutralValue(BinaryOp, RHS)) {
4240 Result = LHS;
4241 Overflow = Builder.getFalse();
4242 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004243 }
4244
Nikita Popov39f2beb2019-05-26 11:43:37 +00004245 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) {
4246 case OverflowResult::MayOverflow:
4247 return false;
Nikita Popov332c1002019-05-28 18:08:31 +00004248 case OverflowResult::AlwaysOverflowsLow:
4249 case OverflowResult::AlwaysOverflowsHigh:
Nikita Popov39f2beb2019-05-26 11:43:37 +00004250 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4251 Result->takeName(&OrigI);
4252 Overflow = Builder.getTrue();
4253 return true;
4254 case OverflowResult::NeverOverflows:
4255 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4256 Result->takeName(&OrigI);
4257 Overflow = Builder.getFalse();
4258 if (auto *Inst = dyn_cast<Instruction>(Result)) {
4259 if (IsSigned)
4260 Inst->setHasNoSignedWrap();
4261 else
4262 Inst->setHasNoUnsignedWrap();
4263 }
4264 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004265 }
4266
Nikita Popov39f2beb2019-05-26 11:43:37 +00004267 llvm_unreachable("Unexpected overflow result");
Sanjoy Dasb0984472015-04-08 04:27:22 +00004268}
4269
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004270/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004271/// overflow.
4272///
4273/// The caller has matched a pattern of the form:
4274/// I = cmp u (mul(zext A, zext B), V
4275/// The function checks if this is a test for overflow and if so replaces
4276/// multiplication with call to 'mul.with.overflow' intrinsic.
4277///
4278/// \param I Compare instruction.
4279/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
4280/// the compare instruction. Must be of integer type.
4281/// \param OtherVal The other argument of compare instruction.
4282/// \returns Instruction which must replace the compare instruction, NULL if no
4283/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004284static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004285 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00004286 // Don't bother doing this transformation for pointers, don't do it for
4287 // vectors.
4288 if (!isa<IntegerType>(MulVal->getType()))
4289 return nullptr;
4290
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004291 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
4292 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00004293 auto *MulInstr = dyn_cast<Instruction>(MulVal);
4294 if (!MulInstr)
4295 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004296 assert(MulInstr->getOpcode() == Instruction::Mul);
4297
David Majnemer634ca232014-11-01 23:46:05 +00004298 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
4299 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004300 assert(LHS->getOpcode() == Instruction::ZExt);
4301 assert(RHS->getOpcode() == Instruction::ZExt);
4302 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
4303
4304 // Calculate type and width of the result produced by mul.with.overflow.
4305 Type *TyA = A->getType(), *TyB = B->getType();
4306 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
4307 WidthB = TyB->getPrimitiveSizeInBits();
4308 unsigned MulWidth;
4309 Type *MulType;
4310 if (WidthB > WidthA) {
4311 MulWidth = WidthB;
4312 MulType = TyB;
4313 } else {
4314 MulWidth = WidthA;
4315 MulType = TyA;
4316 }
4317
4318 // In order to replace the original mul with a narrower mul.with.overflow,
4319 // all uses must ignore upper bits of the product. The number of used low
4320 // bits must be not greater than the width of mul.with.overflow.
4321 if (MulVal->hasNUsesOrMore(2))
4322 for (User *U : MulVal->users()) {
4323 if (U == &I)
4324 continue;
4325 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4326 // Check if truncation ignores bits above MulWidth.
4327 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
4328 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004329 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004330 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4331 // Check if AND ignores bits above MulWidth.
4332 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00004333 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004334 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
4335 const APInt &CVal = CI->getValue();
4336 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004337 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00004338 } else {
4339 // In this case we could have the operand of the binary operation
4340 // being defined in another block, and performing the replacement
4341 // could break the dominance relation.
4342 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004343 }
4344 } else {
4345 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00004346 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004347 }
4348 }
4349
4350 // Recognize patterns
4351 switch (I.getPredicate()) {
4352 case ICmpInst::ICMP_EQ:
4353 case ICmpInst::ICMP_NE:
4354 // Recognize pattern:
4355 // mulval = mul(zext A, zext B)
4356 // cmp eq/neq mulval, zext trunc mulval
4357 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
4358 if (Zext->hasOneUse()) {
4359 Value *ZextArg = Zext->getOperand(0);
4360 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
4361 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
4362 break; //Recognized
4363 }
4364
4365 // Recognize pattern:
4366 // mulval = mul(zext A, zext B)
4367 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
4368 ConstantInt *CI;
4369 Value *ValToMask;
4370 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
4371 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00004372 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004373 const APInt &CVal = CI->getValue() + 1;
4374 if (CVal.isPowerOf2()) {
4375 unsigned MaskWidth = CVal.logBase2();
4376 if (MaskWidth == MulWidth)
4377 break; // Recognized
4378 }
4379 }
Craig Topperf40110f2014-04-25 05:29:35 +00004380 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004381
4382 case ICmpInst::ICMP_UGT:
4383 // Recognize pattern:
4384 // mulval = mul(zext A, zext B)
4385 // cmp ugt mulval, max
4386 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4387 APInt MaxVal = APInt::getMaxValue(MulWidth);
4388 MaxVal = MaxVal.zext(CI->getBitWidth());
4389 if (MaxVal.eq(CI->getValue()))
4390 break; // Recognized
4391 }
Craig Topperf40110f2014-04-25 05:29:35 +00004392 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004393
4394 case ICmpInst::ICMP_UGE:
4395 // Recognize pattern:
4396 // mulval = mul(zext A, zext B)
4397 // cmp uge mulval, max+1
4398 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4399 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
4400 if (MaxVal.eq(CI->getValue()))
4401 break; // Recognized
4402 }
Craig Topperf40110f2014-04-25 05:29:35 +00004403 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004404
4405 case ICmpInst::ICMP_ULE:
4406 // Recognize pattern:
4407 // mulval = mul(zext A, zext B)
4408 // cmp ule mulval, max
4409 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4410 APInt MaxVal = APInt::getMaxValue(MulWidth);
4411 MaxVal = MaxVal.zext(CI->getBitWidth());
4412 if (MaxVal.eq(CI->getValue()))
4413 break; // Recognized
4414 }
Craig Topperf40110f2014-04-25 05:29:35 +00004415 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004416
4417 case ICmpInst::ICMP_ULT:
4418 // Recognize pattern:
4419 // mulval = mul(zext A, zext B)
4420 // cmp ule mulval, max + 1
4421 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004422 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004423 if (MaxVal.eq(CI->getValue()))
4424 break; // Recognized
4425 }
Craig Topperf40110f2014-04-25 05:29:35 +00004426 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004427
4428 default:
Craig Topperf40110f2014-04-25 05:29:35 +00004429 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004430 }
4431
Craig Topperbb4069e2017-07-07 23:16:26 +00004432 InstCombiner::BuilderTy &Builder = IC.Builder;
4433 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004434
4435 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
4436 Value *MulA = A, *MulB = B;
4437 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004438 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004439 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004440 MulB = Builder.CreateZExt(B, MulType);
James Y Knight7976eb52019-02-01 20:43:25 +00004441 Function *F = Intrinsic::getDeclaration(
4442 I.getModule(), Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004443 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004444 IC.Worklist.Add(MulInstr);
4445
4446 // If there are uses of mul result other than the comparison, we know that
4447 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004448 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004449 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004450 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004451 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4452 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004453 if (U == &I || U == OtherVal)
4454 continue;
4455 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4456 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004457 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004458 else
4459 TI->setOperand(0, Mul);
4460 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4461 assert(BO->getOpcode() == Instruction::And);
4462 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004463 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4464 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004465 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004466 Instruction *Zext =
4467 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4468 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004469 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004470 } else {
4471 llvm_unreachable("Unexpected Binary operation");
4472 }
Davide Italiano579064e2017-07-16 18:56:30 +00004473 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004474 }
4475 }
4476 if (isa<Instruction>(OtherVal))
4477 IC.Worklist.Add(cast<Instruction>(OtherVal));
4478
4479 // The original icmp gets replaced with the overflow value, maybe inverted
4480 // depending on predicate.
4481 bool Inverse = false;
4482 switch (I.getPredicate()) {
4483 case ICmpInst::ICMP_NE:
4484 break;
4485 case ICmpInst::ICMP_EQ:
4486 Inverse = true;
4487 break;
4488 case ICmpInst::ICMP_UGT:
4489 case ICmpInst::ICMP_UGE:
4490 if (I.getOperand(0) == MulVal)
4491 break;
4492 Inverse = true;
4493 break;
4494 case ICmpInst::ICMP_ULT:
4495 case ICmpInst::ICMP_ULE:
4496 if (I.getOperand(1) == MulVal)
4497 break;
4498 Inverse = true;
4499 break;
4500 default:
4501 llvm_unreachable("Unexpected predicate");
4502 }
4503 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004504 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004505 return BinaryOperator::CreateNot(Res);
4506 }
4507
4508 return ExtractValueInst::Create(Call, 1);
4509}
4510
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004511/// When performing a comparison against a constant, it is possible that not all
4512/// the bits in the LHS are demanded. This helper method computes the mask that
4513/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004514static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004515 const APInt *RHS;
4516 if (!match(I.getOperand(1), m_APInt(RHS)))
4517 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004518
Craig Topper3edda872017-09-22 18:57:23 +00004519 // If this is a normal comparison, it demands all bits. If it is a sign bit
4520 // comparison, it only demands the sign bit.
4521 bool UnusedBit;
4522 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4523 return APInt::getSignMask(BitWidth);
4524
Owen Andersond490c2d2011-01-11 00:36:45 +00004525 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004526 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004527 // correspond to the trailing ones of the comparand. The value of these
4528 // bits doesn't impact the outcome of the comparison, because any value
4529 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004530 case ICmpInst::ICMP_UGT:
4531 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004532
Owen Andersond490c2d2011-01-11 00:36:45 +00004533 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4534 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004535 case ICmpInst::ICMP_ULT:
4536 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004537
Owen Andersond490c2d2011-01-11 00:36:45 +00004538 default:
4539 return APInt::getAllOnesValue(BitWidth);
4540 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004541}
Chris Lattner2188e402010-01-04 07:37:31 +00004542
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004543/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004544/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004545/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004546/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004547/// The rationale is that several architectures use the same instruction for
4548/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004549/// match.
4550/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004551static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4552 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004553 // FIXME: we may want to go through inttoptrs or bitcasts.
4554 if (Op0->getType()->isPointerTy())
4555 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004556 // If a subtract already has the same operands as a compare, swapping would be
4557 // bad. If a subtract has the same operands as a compare but in reverse order,
4558 // then swapping is good.
4559 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004560 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004561 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4562 GoodToSwap++;
4563 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4564 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004565 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004566 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004567}
4568
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004569/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004570/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004571///
4572/// \param DI Definition
4573/// \param UI Use
4574/// \param DB Block that must dominate all uses of \p DI outside
4575/// the parent block
4576/// \return true when \p UI is the only use of \p DI in the parent block
4577/// and all other uses of \p DI are in blocks dominated by \p DB.
4578///
4579bool InstCombiner::dominatesAllUses(const Instruction *DI,
4580 const Instruction *UI,
4581 const BasicBlock *DB) const {
4582 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004583 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004584 if (!DI->getParent())
4585 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004586 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004587 if (DI->getParent() != UI->getParent())
4588 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004589 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004590 if (DI->getParent() == DB)
4591 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004592 for (const User *U : DI->users()) {
4593 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004594 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004595 return false;
4596 }
4597 return true;
4598}
4599
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004600/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004601static bool isChainSelectCmpBranch(const SelectInst *SI) {
4602 const BasicBlock *BB = SI->getParent();
4603 if (!BB)
4604 return false;
4605 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4606 if (!BI || BI->getNumSuccessors() != 2)
4607 return false;
4608 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4609 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4610 return false;
4611 return true;
4612}
4613
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004614/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004615/// in select-icmp sequence. This will eventually result in the elimination
4616/// of the select.
4617///
4618/// \param SI Select instruction
4619/// \param Icmp Compare instruction
4620/// \param SIOpd Operand that replaces the select
4621///
4622/// Notes:
4623/// - The replacement is global and requires dominator information
4624/// - The caller is responsible for the actual replacement
4625///
4626/// Example:
4627///
4628/// entry:
4629/// %4 = select i1 %3, %C* %0, %C* null
4630/// %5 = icmp eq %C* %4, null
4631/// br i1 %5, label %9, label %7
4632/// ...
4633/// ; <label>:7 ; preds = %entry
4634/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4635/// ...
4636///
4637/// can be transformed to
4638///
4639/// %5 = icmp eq %C* %0, null
4640/// %6 = select i1 %3, i1 %5, i1 true
4641/// br i1 %6, label %9, label %7
4642/// ...
4643/// ; <label>:7 ; preds = %entry
4644/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4645///
4646/// Similar when the first operand of the select is a constant or/and
4647/// the compare is for not equal rather than equal.
4648///
4649/// NOTE: The function is only called when the select and compare constants
4650/// are equal, the optimization can work only for EQ predicates. This is not a
4651/// major restriction since a NE compare should be 'normalized' to an equal
4652/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004653/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004654bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4655 const ICmpInst *Icmp,
4656 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004657 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004658 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4659 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004660 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004661 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004662 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4663 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4664 // replaced can be reached on either path. So the uniqueness check
4665 // guarantees that the path all uses of SI (outside SI's parent) are on
4666 // is disjoint from all other paths out of SI. But that information
4667 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004668 // of compile-time. It should also be noticed that we check for a single
4669 // predecessor and not only uniqueness. This to handle the situation when
4670 // Succ and Succ1 points to the same basic block.
4671 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004672 NumSel++;
4673 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4674 return true;
4675 }
4676 }
4677 return false;
4678}
4679
Sanjay Patel3151dec2016-09-12 15:24:31 +00004680/// Try to fold the comparison based on range information we can get by checking
4681/// whether bits are known to be zero or one in the inputs.
4682Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4683 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4684 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004685 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004686
4687 // Get scalar or pointer size.
4688 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4689 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004690 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004691
4692 if (!BitWidth)
4693 return nullptr;
4694
Craig Topperb45eabc2017-04-26 16:39:58 +00004695 KnownBits Op0Known(BitWidth);
4696 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004697
Craig Topper47596dd2017-03-25 06:52:52 +00004698 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004699 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004700 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004701 return &I;
4702
Craig Topper47596dd2017-03-25 06:52:52 +00004703 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004704 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004705 return &I;
4706
4707 // Given the known and unknown bits, compute a range that the LHS could be
4708 // in. Compute the Min, Max and RHS values based on the known bits. For the
4709 // EQ and NE we use unsigned values.
4710 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4711 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4712 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004713 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4714 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004715 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004716 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4717 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004718 }
4719
Sanjay Patelc63f9012018-01-04 14:31:56 +00004720 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4721 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004722 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004723 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004724 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004725 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004726 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004727
4728 // Based on the range information we know about the LHS, see if we can
4729 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004730 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004731 default:
4732 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004733 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004734 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004735 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4736 return Pred == CmpInst::ICMP_EQ
4737 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4738 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4739 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004740
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004741 // If all bits are known zero except for one, then we know at most one bit
4742 // is set. If the comparison is against zero, then this is a check to see if
4743 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004744 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004745 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004746 // If the LHS is an AND with the same constant, look through it.
4747 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004748 const APInt *LHSC;
4749 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4750 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004751 LHS = Op0;
4752
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004753 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004754 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4755 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004756 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004757 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004758 // ((1 << X) & 8) == 0 -> X != 3
4759 // ((1 << X) & 8) != 0 -> X == 3
4760 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4761 auto NewPred = ICmpInst::getInversePredicate(Pred);
4762 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004763 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004764 // ((1 << X) & 7) == 0 -> X >= 3
4765 // ((1 << X) & 7) != 0 -> X < 3
4766 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4767 auto NewPred =
4768 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4769 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004770 }
4771 }
4772
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004773 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004774 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004775 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004776 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4777 // ((8 >>u X) & 1) == 0 -> X != 3
4778 // ((8 >>u X) & 1) != 0 -> X == 3
4779 unsigned CmpVal = CI->countTrailingZeros();
4780 auto NewPred = ICmpInst::getInversePredicate(Pred);
4781 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4782 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004783 }
4784 break;
4785 }
4786 case ICmpInst::ICMP_ULT: {
4787 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4788 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4789 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4790 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4791 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4792 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4793
Craig Topper0cd25942017-09-27 22:57:18 +00004794 const APInt *CmpC;
4795 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004796 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004797 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004798 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004799 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004800 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4801 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004802 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004803 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4804 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004805 }
4806 break;
4807 }
4808 case ICmpInst::ICMP_UGT: {
4809 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4810 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004811 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4812 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004813 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4814 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4815
Craig Topper0cd25942017-09-27 22:57:18 +00004816 const APInt *CmpC;
4817 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004818 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004819 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004820 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004821 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004822 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4823 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004824 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004825 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4826 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004827 }
4828 break;
4829 }
Craig Topper0cd25942017-09-27 22:57:18 +00004830 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004831 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4832 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4833 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4834 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4835 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4836 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004837 const APInt *CmpC;
4838 if (match(Op1, m_APInt(CmpC))) {
4839 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004840 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004841 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004842 }
4843 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004844 }
4845 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004846 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4847 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4848 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4849 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004850 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4851 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004852 const APInt *CmpC;
4853 if (match(Op1, m_APInt(CmpC))) {
4854 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004855 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004856 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004857 }
4858 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004859 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004860 case ICmpInst::ICMP_SGE:
4861 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4862 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4863 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4864 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4865 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004866 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4867 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004868 break;
4869 case ICmpInst::ICMP_SLE:
4870 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4871 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4872 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4873 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4874 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004875 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4876 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004877 break;
4878 case ICmpInst::ICMP_UGE:
4879 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4880 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4881 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4882 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4883 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004884 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4885 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004886 break;
4887 case ICmpInst::ICMP_ULE:
4888 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4889 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4890 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4891 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4892 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004893 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4894 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004895 break;
4896 }
4897
4898 // Turn a signed comparison into an unsigned one if both operands are known to
4899 // have the same sign.
4900 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004901 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4902 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004903 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4904
4905 return nullptr;
4906}
4907
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004908llvm::Optional<std::pair<CmpInst::Predicate, Constant *>>
4909llvm::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred,
4910 Constant *C) {
4911 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) &&
4912 !isCanonicalPredicate(Pred) &&
4913 "Only for non-canonical relational integer predicates.");
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004914
Sanjay Patele9b2c322016-05-17 00:57:57 +00004915 // Check if the constant operand can be safely incremented/decremented without
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004916 // overflowing/underflowing. For scalars, SimplifyICmpInst should have already
4917 // handled the edge cases for us, so we just assert on them.
4918 // For vectors, we must handle the edge cases.
4919 Type *Type = C->getType();
4920 bool IsSigned = ICmpInst::isSigned(Pred);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004921 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004922 auto *CI = dyn_cast<ConstantInt>(C);
Sanjay Patel18254932016-05-17 01:12:31 +00004923 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004924 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4925 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004926 } else if (Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004927 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004928 // are for scalar, we could remove the min/max checks. However, to do that,
4929 // we would have to use insertelement/shufflevector to replace edge values.
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004930 unsigned NumElts = Type->getVectorNumElements();
Sanjay Patele9b2c322016-05-17 00:57:57 +00004931 for (unsigned i = 0; i != NumElts; ++i) {
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004932 Constant *Elt = C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004933 if (!Elt)
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004934 return llvm::None;
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004935
Sanjay Patele9b2c322016-05-17 00:57:57 +00004936 if (isa<UndefValue>(Elt))
4937 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004938
Sanjay Patele9b2c322016-05-17 00:57:57 +00004939 // Bail out if we can't determine if this constant is min/max or if we
4940 // know that this constant is min/max.
4941 auto *CI = dyn_cast<ConstantInt>(Elt);
4942 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004943 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004944 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004945 } else {
4946 // ConstantExpr?
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004947 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004948 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004949
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004950 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred);
4951
4952 // Increment or decrement the constant.
4953 Constant *OneOrNegOne = ConstantInt::get(Type, IsLE ? 1 : -1, true);
4954 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne);
4955
4956 return std::make_pair(NewPred, NewC);
4957}
4958
4959/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4960/// it into the appropriate icmp lt or icmp gt instruction. This transform
4961/// allows them to be folded in visitICmpInst.
4962static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4963 ICmpInst::Predicate Pred = I.getPredicate();
4964 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) ||
4965 isCanonicalPredicate(Pred))
4966 return nullptr;
4967
4968 Value *Op0 = I.getOperand(0);
4969 Value *Op1 = I.getOperand(1);
4970 auto *Op1C = dyn_cast<Constant>(Op1);
4971 if (!Op1C)
4972 return nullptr;
4973
4974 auto FlippedStrictness = getFlippedStrictnessPredicateAndConstant(Pred, Op1C);
4975 if (!FlippedStrictness)
4976 return nullptr;
4977
4978 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second);
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004979}
4980
Sanjay Patele5747e32017-05-17 22:15:07 +00004981/// Integer compare with boolean values can always be turned into bitwise ops.
4982static Instruction *canonicalizeICmpBool(ICmpInst &I,
4983 InstCombiner::BuilderTy &Builder) {
4984 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004985 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004986
Sanjay Patelba212c22017-05-17 22:29:40 +00004987 // A boolean compared to true/false can be simplified to Op0/true/false in
4988 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4989 // Cases not handled by InstSimplify are always 'not' of Op0.
4990 if (match(B, m_Zero())) {
4991 switch (I.getPredicate()) {
4992 case CmpInst::ICMP_EQ: // A == 0 -> !A
4993 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4994 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4995 return BinaryOperator::CreateNot(A);
4996 default:
4997 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4998 }
4999 } else if (match(B, m_One())) {
5000 switch (I.getPredicate()) {
5001 case CmpInst::ICMP_NE: // A != 1 -> !A
5002 case CmpInst::ICMP_ULT: // A <u 1 -> !A
5003 case CmpInst::ICMP_SGT: // A >s -1 -> !A
5004 return BinaryOperator::CreateNot(A);
5005 default:
5006 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
5007 }
5008 }
5009
Sanjay Patele5747e32017-05-17 22:15:07 +00005010 switch (I.getPredicate()) {
5011 default:
5012 llvm_unreachable("Invalid icmp instruction!");
5013 case ICmpInst::ICMP_EQ:
5014 // icmp eq i1 A, B -> ~(A ^ B)
5015 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
5016
5017 case ICmpInst::ICMP_NE:
5018 // icmp ne i1 A, B -> A ^ B
5019 return BinaryOperator::CreateXor(A, B);
5020
5021 case ICmpInst::ICMP_UGT:
5022 // icmp ugt -> icmp ult
5023 std::swap(A, B);
5024 LLVM_FALLTHROUGH;
5025 case ICmpInst::ICMP_ULT:
5026 // icmp ult i1 A, B -> ~A & B
5027 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
5028
5029 case ICmpInst::ICMP_SGT:
5030 // icmp sgt -> icmp slt
5031 std::swap(A, B);
5032 LLVM_FALLTHROUGH;
5033 case ICmpInst::ICMP_SLT:
5034 // icmp slt i1 A, B -> A & ~B
5035 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
5036
5037 case ICmpInst::ICMP_UGE:
5038 // icmp uge -> icmp ule
5039 std::swap(A, B);
5040 LLVM_FALLTHROUGH;
5041 case ICmpInst::ICMP_ULE:
5042 // icmp ule i1 A, B -> ~A | B
5043 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
5044
5045 case ICmpInst::ICMP_SGE:
5046 // icmp sge -> icmp sle
5047 std::swap(A, B);
5048 LLVM_FALLTHROUGH;
5049 case ICmpInst::ICMP_SLE:
5050 // icmp sle i1 A, B -> A | ~B
5051 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
5052 }
5053}
5054
Roman Lebedev75404fb2018-09-12 18:19:43 +00005055// Transform pattern like:
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005056// (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X
5057// (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X
Roman Lebedev75404fb2018-09-12 18:19:43 +00005058// Into:
5059// (X l>> Y) != 0
5060// (X l>> Y) == 0
5061static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp,
5062 InstCombiner::BuilderTy &Builder) {
Roman Lebedev6dc87002018-09-13 20:33:12 +00005063 ICmpInst::Predicate Pred, NewPred;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005064 Value *X, *Y;
Roman Lebedev6dc87002018-09-13 20:33:12 +00005065 if (match(&Cmp,
5066 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) {
5067 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5068 if (Cmp.getOperand(0) == X)
5069 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005070
Roman Lebedev6dc87002018-09-13 20:33:12 +00005071 switch (Pred) {
5072 case ICmpInst::ICMP_ULE:
5073 NewPred = ICmpInst::ICMP_NE;
5074 break;
5075 case ICmpInst::ICMP_UGT:
5076 NewPred = ICmpInst::ICMP_EQ;
5077 break;
5078 default:
5079 return nullptr;
5080 }
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005081 } else if (match(&Cmp, m_c_ICmp(Pred,
5082 m_OneUse(m_CombineOr(
5083 m_Not(m_Shl(m_AllOnes(), m_Value(Y))),
5084 m_Add(m_Shl(m_One(), m_Value(Y)),
5085 m_AllOnes()))),
5086 m_Value(X)))) {
5087 // The variant with 'add' is not canonical, (the variant with 'not' is)
5088 // we only get it because it has extra uses, and can't be canonicalized,
5089
Roman Lebedev6dc87002018-09-13 20:33:12 +00005090 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5091 if (Cmp.getOperand(0) == X)
5092 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005093
Roman Lebedev6dc87002018-09-13 20:33:12 +00005094 switch (Pred) {
5095 case ICmpInst::ICMP_ULT:
5096 NewPred = ICmpInst::ICMP_NE;
5097 break;
5098 case ICmpInst::ICMP_UGE:
5099 NewPred = ICmpInst::ICMP_EQ;
5100 break;
5101 default:
5102 return nullptr;
5103 }
5104 } else
Roman Lebedev75404fb2018-09-12 18:19:43 +00005105 return nullptr;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005106
5107 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits");
5108 Constant *Zero = Constant::getNullValue(NewX->getType());
5109 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero);
5110}
5111
Sanjay Patel039f5562018-08-16 12:52:17 +00005112static Instruction *foldVectorCmp(CmpInst &Cmp,
5113 InstCombiner::BuilderTy &Builder) {
5114 // If both arguments of the cmp are shuffles that use the same mask and
5115 // shuffle within a single vector, move the shuffle after the cmp.
5116 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
5117 Value *V1, *V2;
5118 Constant *M;
5119 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
5120 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
5121 V1->getType() == V2->getType() &&
5122 (LHS->hasOneUse() || RHS->hasOneUse())) {
5123 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
5124 CmpInst::Predicate P = Cmp.getPredicate();
5125 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
5126 : Builder.CreateFCmp(P, V1, V2);
5127 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
5128 }
5129 return nullptr;
5130}
5131
Chris Lattner2188e402010-01-04 07:37:31 +00005132Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
5133 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00005134 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00005135 unsigned Op0Cplxity = getComplexity(Op0);
5136 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005137
Chris Lattner2188e402010-01-04 07:37:31 +00005138 /// Orders the operands of the compare so that they are listed from most
5139 /// complex to least complex. This puts constants before unary operators,
5140 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00005141 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00005142 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00005143 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00005144 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00005145 Changed = true;
5146 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005147
Daniel Berlin2c75c632017-04-26 20:56:07 +00005148 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
5149 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005150 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005151
Uriel Korach18972232017-09-10 08:31:22 +00005152 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00005153 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00005154 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005155 Value *Cond, *SelectTrue, *SelectFalse;
5156 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00005157 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005158 if (Value *V = dyn_castNegVal(SelectTrue)) {
5159 if (V == SelectFalse)
5160 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
5161 }
5162 else if (Value *V = dyn_castNegVal(SelectFalse)) {
5163 if (V == SelectTrue)
5164 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00005165 }
5166 }
5167 }
5168
Craig Topperfde47232017-07-09 07:04:03 +00005169 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00005170 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00005171 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005172
Sanjay Patele9b2c322016-05-17 00:57:57 +00005173 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005174 return NewICmp;
5175
Sanjay Patel06b127a2016-09-15 14:37:50 +00005176 if (Instruction *Res = foldICmpWithConstant(I))
5177 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005178
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00005179 if (Instruction *Res = foldICmpWithDominatingICmp(I))
5180 return Res;
5181
Max Kazantsev20da7e42018-07-06 04:04:13 +00005182 if (Instruction *Res = foldICmpUsingKnownBits(I))
5183 return Res;
5184
Chris Lattner2188e402010-01-04 07:37:31 +00005185 // Test if the ICmpInst instruction is used exclusively by a select as
5186 // part of a minimum or maximum operation. If so, refrain from doing
5187 // any other folding. This helps out other analyses which understand
5188 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5189 // and CodeGen. And in this case, at least one of the comparison
5190 // operands has at least one user besides the compare (the select),
5191 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00005192 //
5193 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00005194 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005195 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5196 Value *A, *B;
5197 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5198 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00005199 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005200 }
Chris Lattner2188e402010-01-04 07:37:31 +00005201
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00005202 // Do this after checking for min/max to prevent infinite looping.
5203 if (Instruction *Res = foldICmpWithZero(I))
5204 return Res;
5205
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00005206 // FIXME: We only do this after checking for min/max to prevent infinite
5207 // looping caused by a reverse canonicalization of these patterns for min/max.
5208 // FIXME: The organization of folds is a mess. These would naturally go into
5209 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
5210 // down here after the min/max restriction.
5211 ICmpInst::Predicate Pred = I.getPredicate();
5212 const APInt *C;
5213 if (match(Op1, m_APInt(C))) {
5214 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
5215 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
5216 Constant *Zero = Constant::getNullValue(Op0->getType());
5217 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
5218 }
5219
5220 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
5221 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
5222 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
5223 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
5224 }
5225 }
5226
Sanjay Patelf58f68c2016-09-10 15:03:44 +00005227 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00005228 return Res;
5229
Sanjay Patel10494b22016-09-16 16:10:22 +00005230 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
5231 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005232
5233 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
5234 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00005235 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00005236 return NI;
5237 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00005238 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00005239 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
5240 return NI;
5241
Hans Wennborgf1f36512015-10-07 00:20:07 +00005242 // Try to optimize equality comparisons against alloca-based pointers.
5243 if (Op0->getType()->isPointerTy() && I.isEquality()) {
5244 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
5245 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005246 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005247 return New;
5248 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005249 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005250 return New;
5251 }
5252
Sanjay Patele7f46c32019-02-07 20:54:09 +00005253 if (Instruction *Res = foldICmpBitCast(I, Builder))
5254 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005255
Sanjay Patela90ee0e2019-08-20 14:56:44 +00005256 if (Instruction *R = foldICmpWithCastOp(I))
5257 return R;
Chris Lattner2188e402010-01-04 07:37:31 +00005258
Sanjay Patel10494b22016-09-16 16:10:22 +00005259 if (Instruction *Res = foldICmpBinOp(I))
5260 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00005261
Sanjay Pateldd46b522016-12-19 17:32:37 +00005262 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00005263 return Res;
5264
Sanjay Patel10494b22016-09-16 16:10:22 +00005265 {
5266 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00005267 // Transform (A & ~B) == 0 --> (A & B) != 0
5268 // and (A & ~B) != 0 --> (A & B) == 0
5269 // if A is a power of 2.
5270 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00005271 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00005272 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00005273 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00005274 Op1);
5275
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005276 // ~X < ~Y --> Y < X
5277 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005278 if (match(Op0, m_Not(m_Value(A)))) {
5279 if (match(Op1, m_Not(m_Value(B))))
5280 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005281
Sanjay Patelce241f42017-06-02 16:29:41 +00005282 const APInt *C;
5283 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005284 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00005285 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005286 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00005287
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005288 Instruction *AddI = nullptr;
5289 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
5290 m_Instruction(AddI))) &&
5291 isa<IntegerType>(A->getType())) {
5292 Value *Result;
5293 Constant *Overflow;
Nikita Popov352f5982019-05-26 11:43:31 +00005294 if (OptimizeOverflowCheck(Instruction::Add, /*Signed*/false, A, B,
5295 *AddI, Result, Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00005296 replaceInstUsesWith(*AddI, Result);
5297 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005298 }
5299 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005300
5301 // (zext a) * (zext b) --> llvm.umul.with.overflow.
5302 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005303 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005304 return R;
5305 }
5306 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005307 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005308 return R;
5309 }
Chris Lattner2188e402010-01-04 07:37:31 +00005310 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005311
Sanjay Patel10494b22016-09-16 16:10:22 +00005312 if (Instruction *Res = foldICmpEquality(I))
5313 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005314
David Majnemerc1eca5a2014-11-06 23:23:30 +00005315 // The 'cmpxchg' instruction returns an aggregate containing the old value and
5316 // an i1 which indicates whether or not we successfully did the swap.
5317 //
5318 // Replace comparisons between the old value and the expected value with the
5319 // indicator that 'cmpxchg' returns.
5320 //
5321 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
5322 // spuriously fail. In those cases, the old value may equal the expected
5323 // value but it is possible for the swap to not occur.
5324 if (I.getPredicate() == ICmpInst::ICMP_EQ)
5325 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
5326 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
5327 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
5328 !ACXI->isWeak())
5329 return ExtractValueInst::Create(ACXI, 1);
5330
Chris Lattner2188e402010-01-04 07:37:31 +00005331 {
Craig Topperbee74792018-08-20 23:04:25 +00005332 Value *X;
5333 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00005334 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00005335 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
5336 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005337
5338 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00005339 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
5340 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005341 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00005342
Roman Lebedev75404fb2018-09-12 18:19:43 +00005343 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder))
5344 return Res;
5345
Sanjay Patel039f5562018-08-16 12:52:17 +00005346 if (I.getType()->isVectorTy())
5347 if (Instruction *Res = foldVectorCmp(I, Builder))
5348 return Res;
5349
Craig Topperf40110f2014-04-25 05:29:35 +00005350 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005351}
5352
Sanjay Patel5f0217f2016-06-05 16:46:18 +00005353/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00005354Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00005355 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00005356 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005357 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005358
Chris Lattner2188e402010-01-04 07:37:31 +00005359 // Get the width of the mantissa. We don't want to hack on conversions that
5360 // might lose information from the integer, e.g. "i64 -> float"
5361 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00005362 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005363
Matt Arsenault55e73122015-01-06 15:50:59 +00005364 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
5365
Chris Lattner2188e402010-01-04 07:37:31 +00005366 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005367
Matt Arsenault55e73122015-01-06 15:50:59 +00005368 if (I.isEquality()) {
5369 FCmpInst::Predicate P = I.getPredicate();
5370 bool IsExact = false;
5371 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
5372 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
5373
5374 // If the floating point constant isn't an integer value, we know if we will
5375 // ever compare equal / not equal to it.
5376 if (!IsExact) {
5377 // TODO: Can never be -0.0 and other non-representable values
5378 APFloat RHSRoundInt(RHS);
5379 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
5380 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
5381 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00005382 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00005383
5384 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00005385 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00005386 }
5387 }
5388
5389 // TODO: If the constant is exactly representable, is it always OK to do
5390 // equality compares as integer?
5391 }
5392
Arch D. Robison8ed08542015-09-15 17:51:59 +00005393 // Check to see that the input is converted from an integer type that is small
5394 // enough that preserves all bits. TODO: check here for "known" sign bits.
5395 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
5396 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00005397
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005398 // Following test does NOT adjust InputSize downwards for signed inputs,
5399 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00005400 // to distinguish it from one less than that value.
5401 if ((int)InputSize > MantissaWidth) {
5402 // Conversion would lose accuracy. Check if loss can impact comparison.
5403 int Exp = ilogb(RHS);
5404 if (Exp == APFloat::IEK_Inf) {
5405 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005406 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005407 // Conversion could create infinity.
5408 return nullptr;
5409 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005410 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00005411 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005412 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005413 // Conversion could affect comparison.
5414 return nullptr;
5415 }
5416 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005417
Chris Lattner2188e402010-01-04 07:37:31 +00005418 // Otherwise, we can potentially simplify the comparison. We know that it
5419 // will always come through as an integer value and we know the constant is
5420 // not a NAN (it would have been previously simplified).
5421 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00005422
Chris Lattner2188e402010-01-04 07:37:31 +00005423 ICmpInst::Predicate Pred;
5424 switch (I.getPredicate()) {
5425 default: llvm_unreachable("Unexpected predicate!");
5426 case FCmpInst::FCMP_UEQ:
5427 case FCmpInst::FCMP_OEQ:
5428 Pred = ICmpInst::ICMP_EQ;
5429 break;
5430 case FCmpInst::FCMP_UGT:
5431 case FCmpInst::FCMP_OGT:
5432 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
5433 break;
5434 case FCmpInst::FCMP_UGE:
5435 case FCmpInst::FCMP_OGE:
5436 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
5437 break;
5438 case FCmpInst::FCMP_ULT:
5439 case FCmpInst::FCMP_OLT:
5440 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
5441 break;
5442 case FCmpInst::FCMP_ULE:
5443 case FCmpInst::FCMP_OLE:
5444 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
5445 break;
5446 case FCmpInst::FCMP_UNE:
5447 case FCmpInst::FCMP_ONE:
5448 Pred = ICmpInst::ICMP_NE;
5449 break;
5450 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00005451 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005452 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00005453 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005454 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005455
Chris Lattner2188e402010-01-04 07:37:31 +00005456 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005457
Chris Lattner2188e402010-01-04 07:37:31 +00005458 // See if the FP constant is too large for the integer. For example,
5459 // comparing an i8 to 300.0.
5460 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005461
Chris Lattner2188e402010-01-04 07:37:31 +00005462 if (!LHSUnsigned) {
5463 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5464 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005465 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005466 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5467 APFloat::rmNearestTiesToEven);
5468 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5469 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5470 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005471 return replaceInstUsesWith(I, Builder.getTrue());
5472 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005473 }
5474 } else {
5475 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5476 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005477 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005478 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5479 APFloat::rmNearestTiesToEven);
5480 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5481 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5482 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005483 return replaceInstUsesWith(I, Builder.getTrue());
5484 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005485 }
5486 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005487
Chris Lattner2188e402010-01-04 07:37:31 +00005488 if (!LHSUnsigned) {
5489 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005490 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005491 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5492 APFloat::rmNearestTiesToEven);
5493 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5494 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5495 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005496 return replaceInstUsesWith(I, Builder.getTrue());
5497 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005498 }
Devang Patel698452b2012-02-13 23:05:18 +00005499 } else {
5500 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005501 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005502 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5503 APFloat::rmNearestTiesToEven);
5504 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5505 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5506 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005507 return replaceInstUsesWith(I, Builder.getTrue());
5508 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005509 }
Chris Lattner2188e402010-01-04 07:37:31 +00005510 }
5511
5512 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5513 // [0, UMAX], but it may still be fractional. See if it is fractional by
5514 // casting the FP value to the integer value and back, checking for equality.
5515 // Don't do this for zero, because -0.0 is not fractional.
5516 Constant *RHSInt = LHSUnsigned
5517 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5518 : ConstantExpr::getFPToSI(RHSC, IntTy);
5519 if (!RHS.isZero()) {
5520 bool Equal = LHSUnsigned
5521 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5522 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5523 if (!Equal) {
5524 // If we had a comparison against a fractional value, we have to adjust
5525 // the compare predicate and sometimes the value. RHSC is rounded towards
5526 // zero at this point.
5527 switch (Pred) {
5528 default: llvm_unreachable("Unexpected integer comparison!");
5529 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005530 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005531 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005532 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005533 case ICmpInst::ICMP_ULE:
5534 // (float)int <= 4.4 --> int <= 4
5535 // (float)int <= -4.4 --> false
5536 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005537 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005538 break;
5539 case ICmpInst::ICMP_SLE:
5540 // (float)int <= 4.4 --> int <= 4
5541 // (float)int <= -4.4 --> int < -4
5542 if (RHS.isNegative())
5543 Pred = ICmpInst::ICMP_SLT;
5544 break;
5545 case ICmpInst::ICMP_ULT:
5546 // (float)int < -4.4 --> false
5547 // (float)int < 4.4 --> int <= 4
5548 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005549 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005550 Pred = ICmpInst::ICMP_ULE;
5551 break;
5552 case ICmpInst::ICMP_SLT:
5553 // (float)int < -4.4 --> int < -4
5554 // (float)int < 4.4 --> int <= 4
5555 if (!RHS.isNegative())
5556 Pred = ICmpInst::ICMP_SLE;
5557 break;
5558 case ICmpInst::ICMP_UGT:
5559 // (float)int > 4.4 --> int > 4
5560 // (float)int > -4.4 --> true
5561 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005562 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005563 break;
5564 case ICmpInst::ICMP_SGT:
5565 // (float)int > 4.4 --> int > 4
5566 // (float)int > -4.4 --> int >= -4
5567 if (RHS.isNegative())
5568 Pred = ICmpInst::ICMP_SGE;
5569 break;
5570 case ICmpInst::ICMP_UGE:
5571 // (float)int >= -4.4 --> true
5572 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005573 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005574 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005575 Pred = ICmpInst::ICMP_UGT;
5576 break;
5577 case ICmpInst::ICMP_SGE:
5578 // (float)int >= -4.4 --> int >= -4
5579 // (float)int >= 4.4 --> int > 4
5580 if (!RHS.isNegative())
5581 Pred = ICmpInst::ICMP_SGT;
5582 break;
5583 }
5584 }
5585 }
5586
5587 // Lower this FP comparison into an appropriate integer version of the
5588 // comparison.
5589 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5590}
5591
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005592/// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary.
5593static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI,
5594 Constant *RHSC) {
5595 // When C is not 0.0 and infinities are not allowed:
5596 // (C / X) < 0.0 is a sign-bit test of X
5597 // (C / X) < 0.0 --> X < 0.0 (if C is positive)
5598 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate)
5599 //
5600 // Proof:
5601 // Multiply (C / X) < 0.0 by X * X / C.
5602 // - X is non zero, if it is the flag 'ninf' is violated.
5603 // - C defines the sign of X * X * C. Thus it also defines whether to swap
5604 // the predicate. C is also non zero by definition.
5605 //
5606 // Thus X * X / C is non zero and the transformation is valid. [qed]
5607
5608 FCmpInst::Predicate Pred = I.getPredicate();
5609
5610 // Check that predicates are valid.
5611 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) &&
5612 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE))
5613 return nullptr;
5614
5615 // Check that RHS operand is zero.
5616 if (!match(RHSC, m_AnyZeroFP()))
5617 return nullptr;
5618
5619 // Check fastmath flags ('ninf').
5620 if (!LHSI->hasNoInfs() || !I.hasNoInfs())
5621 return nullptr;
5622
5623 // Check the properties of the dividend. It must not be zero to avoid a
5624 // division by zero (see Proof).
5625 const APFloat *C;
5626 if (!match(LHSI->getOperand(0), m_APFloat(C)))
5627 return nullptr;
5628
5629 if (C->isZero())
5630 return nullptr;
5631
5632 // Get swapped predicate if necessary.
5633 if (C->isNegative())
5634 Pred = I.getSwappedPredicate();
5635
Sanjay Pateld1172a02018-11-07 00:00:42 +00005636 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I);
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005637}
5638
Sanjay Patel1c254c62018-10-31 16:34:43 +00005639/// Optimize fabs(X) compared with zero.
5640static Instruction *foldFabsWithFcmpZero(FCmpInst &I) {
5641 Value *X;
5642 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) ||
5643 !match(I.getOperand(1), m_PosZeroFP()))
5644 return nullptr;
5645
Sanjay Patel57a08b32018-11-07 16:15:01 +00005646 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) {
5647 I->setPredicate(P);
5648 I->setOperand(0, X);
5649 return I;
5650 };
5651
Sanjay Patel1c254c62018-10-31 16:34:43 +00005652 switch (I.getPredicate()) {
5653 case FCmpInst::FCMP_UGE:
5654 case FCmpInst::FCMP_OLT:
5655 // fabs(X) >= 0.0 --> true
5656 // fabs(X) < 0.0 --> false
5657 llvm_unreachable("fcmp should have simplified");
5658
5659 case FCmpInst::FCMP_OGT:
5660 // fabs(X) > 0.0 --> X != 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005661 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005662
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005663 case FCmpInst::FCMP_UGT:
5664 // fabs(X) u> 0.0 --> X u!= 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005665 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005666
Sanjay Patel1c254c62018-10-31 16:34:43 +00005667 case FCmpInst::FCMP_OLE:
5668 // fabs(X) <= 0.0 --> X == 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005669 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005670
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005671 case FCmpInst::FCMP_ULE:
5672 // fabs(X) u<= 0.0 --> X u== 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005673 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005674
Sanjay Patel1c254c62018-10-31 16:34:43 +00005675 case FCmpInst::FCMP_OGE:
5676 // fabs(X) >= 0.0 --> !isnan(X)
5677 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005678 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005679
Sanjay Patel76faf512018-11-07 15:11:32 +00005680 case FCmpInst::FCMP_ULT:
5681 // fabs(X) u< 0.0 --> isnan(X)
5682 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005683 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X);
Sanjay Patel76faf512018-11-07 15:11:32 +00005684
Sanjay Patel1c254c62018-10-31 16:34:43 +00005685 case FCmpInst::FCMP_OEQ:
5686 case FCmpInst::FCMP_UEQ:
5687 case FCmpInst::FCMP_ONE:
5688 case FCmpInst::FCMP_UNE:
Sanjay Patelbb521e62018-11-07 15:44:26 +00005689 case FCmpInst::FCMP_ORD:
5690 case FCmpInst::FCMP_UNO:
5691 // Look through the fabs() because it doesn't change anything but the sign.
5692 // fabs(X) == 0.0 --> X == 0.0,
Sanjay Patel1c254c62018-10-31 16:34:43 +00005693 // fabs(X) != 0.0 --> X != 0.0
Sanjay Patelbb521e62018-11-07 15:44:26 +00005694 // isnan(fabs(X)) --> isnan(X)
5695 // !isnan(fabs(X) --> !isnan(X)
Sanjay Patel57a08b32018-11-07 16:15:01 +00005696 return replacePredAndOp0(&I, I.getPredicate(), X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005697
5698 default:
5699 return nullptr;
5700 }
5701}
5702
Chris Lattner2188e402010-01-04 07:37:31 +00005703Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5704 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005705
Chris Lattner2188e402010-01-04 07:37:31 +00005706 /// Orders the operands of the compare so that they are listed from most
5707 /// complex to least complex. This puts constants before unary operators,
5708 /// before binary operators.
5709 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5710 I.swapOperands();
5711 Changed = true;
5712 }
5713
Sanjay Patel6b139462017-09-02 15:11:55 +00005714 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005715 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005716 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5717 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005718 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005719
5720 // Simplify 'fcmp pred X, X'
Sanjay Patela706b9a2019-04-29 19:23:44 +00005721 Type *OpType = Op0->getType();
5722 assert(OpType == Op1->getType() && "fcmp with different-typed operands?");
Chris Lattner2188e402010-01-04 07:37:31 +00005723 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005724 switch (Pred) {
5725 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005726 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5727 case FCmpInst::FCMP_ULT: // True if unordered or less than
5728 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5729 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5730 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5731 I.setPredicate(FCmpInst::FCMP_UNO);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005732 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005733 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005734
Chris Lattner2188e402010-01-04 07:37:31 +00005735 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5736 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5737 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5738 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5739 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5740 I.setPredicate(FCmpInst::FCMP_ORD);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005741 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005742 return &I;
5743 }
5744 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005745
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005746 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5747 // then canonicalize the operand to 0.0.
5748 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005749 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005750 I.setOperand(0, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005751 return &I;
5752 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005753 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005754 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005755 return &I;
5756 }
5757 }
5758
Sanjay Patel6a281a72019-05-07 18:58:07 +00005759 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y
5760 Value *X, *Y;
5761 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
5762 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I);
5763
James Molloy2b21a7c2015-05-20 18:41:25 +00005764 // Test if the FCmpInst instruction is used exclusively by a select as
5765 // part of a minimum or maximum operation. If so, refrain from doing
5766 // any other folding. This helps out other analyses which understand
5767 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5768 // and CodeGen. And in this case, at least one of the comparison
5769 // operands has at least one user besides the compare (the select),
5770 // which would often largely negate the benefit of folding anyway.
5771 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005772 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5773 Value *A, *B;
5774 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5775 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005776 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005777 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005778
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005779 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0:
5780 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0
5781 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005782 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005783 return &I;
5784 }
5785
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005786 // Handle fcmp with instruction LHS and constant RHS.
5787 Instruction *LHSI;
5788 Constant *RHSC;
5789 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) {
5790 switch (LHSI->getOpcode()) {
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005791 case Instruction::PHI:
5792 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5793 // block. If in the same block, we're encouraging jump threading. If
5794 // not, we are just pessimizing the code by making an i1 phi.
5795 if (LHSI->getParent() == I.getParent())
5796 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005797 return NV;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005798 break;
5799 case Instruction::SIToFP:
5800 case Instruction::UIToFP:
5801 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
5802 return NV;
5803 break;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005804 case Instruction::FDiv:
5805 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC))
5806 return NV;
5807 break;
5808 case Instruction::Load:
5809 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0)))
5810 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5811 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5812 !cast<LoadInst>(LHSI)->isVolatile())
5813 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
5814 return Res;
5815 break;
Sanjay Patel1c254c62018-10-31 16:34:43 +00005816 }
Chris Lattner2188e402010-01-04 07:37:31 +00005817 }
5818
Sanjay Pateld1172a02018-11-07 00:00:42 +00005819 if (Instruction *R = foldFabsWithFcmpZero(I))
5820 return R;
5821
Sanjay Patel70282a02018-11-06 15:49:45 +00005822 if (match(Op0, m_FNeg(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005823 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C
Sanjay Patel70282a02018-11-06 15:49:45 +00005824 Constant *C;
5825 if (match(Op1, m_Constant(C))) {
Sanjay Patel70282a02018-11-06 15:49:45 +00005826 Constant *NegC = ConstantExpr::getFNeg(C);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005827 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00005828 }
5829 }
Benjamin Kramerd159d942011-03-31 10:12:22 +00005830
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005831 if (match(Op0, m_FPExt(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005832 // fcmp (fpext X), (fpext Y) -> fcmp X, Y
5833 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType())
5834 return new FCmpInst(Pred, X, Y, "", &I);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005835
Sanjay Pateld1172a02018-11-07 00:00:42 +00005836 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless
Sanjay Patel724014a2018-11-06 17:20:20 +00005837 const APFloat *C;
5838 if (match(Op1, m_APFloat(C))) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005839 const fltSemantics &FPSem =
5840 X->getType()->getScalarType()->getFltSemantics();
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005841 bool Lossy;
Sanjay Patel724014a2018-11-06 17:20:20 +00005842 APFloat TruncC = *C;
5843 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005844
5845 // Avoid lossy conversions and denormals.
5846 // Zero is a special case that's OK to convert.
Sanjay Patel724014a2018-11-06 17:20:20 +00005847 APFloat Fabs = TruncC;
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005848 Fabs.clearSign();
5849 if (!Lossy &&
5850 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) !=
Sanjay Patel46bf3922018-11-06 16:45:27 +00005851 APFloat::cmpLessThan) || Fabs.isZero())) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005852 Constant *NewC = ConstantFP::get(X->getType(), TruncC);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005853 return new FCmpInst(Pred, X, NewC, "", &I);
Sanjay Patel46bf3922018-11-06 16:45:27 +00005854 }
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005855 }
Sanjay Patel1b85f0022018-11-06 16:23:03 +00005856 }
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005857
Sanjay Patel039f5562018-08-16 12:52:17 +00005858 if (I.getType()->isVectorTy())
5859 if (Instruction *Res = foldVectorCmp(I, Builder))
5860 return Res;
5861
Craig Topperf40110f2014-04-25 05:29:35 +00005862 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005863}