blob: a04e56916f8ef2b17c3d349f3209abc62e7a2354 [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Chris Lattner2188e402010-01-04 07:37:31 +00006//
7//===----------------------------------------------------------------------===//
8//
9// This file implements the visitICmp and visitFCmp functions.
10//
11//===----------------------------------------------------------------------===//
12
Chandler Carrutha9174582015-01-22 05:25:13 +000013#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000014#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000015#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000016#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000017#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000018#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000019#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000020#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000021#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000022#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000023#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000024#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000025#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000026#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000027
Chris Lattner2188e402010-01-04 07:37:31 +000028using namespace llvm;
29using namespace PatternMatch;
30
Chandler Carruth964daaa2014-04-22 02:55:47 +000031#define DEBUG_TYPE "instcombine"
32
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000033// How many times is a select replaced by one of its operands?
34STATISTIC(NumSel, "Number of select opts");
35
Chris Lattner98457102011-02-10 05:23:05 +000036
Sanjay Patel5f0217f2016-06-05 16:46:18 +000037/// Compute Result = In1+In2, returning true if the result overflowed for this
38/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000039static bool addWithOverflow(APInt &Result, const APInt &In1,
40 const APInt &In2, bool IsSigned = false) {
41 bool Overflow;
42 if (IsSigned)
43 Result = In1.sadd_ov(In2, Overflow);
44 else
45 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000046
Craig Topper6e025a32017-10-01 23:53:54 +000047 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000048}
49
Sanjay Patel5f0217f2016-06-05 16:46:18 +000050/// Compute Result = In1-In2, returning true if the result overflowed for this
51/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000052static bool subWithOverflow(APInt &Result, const APInt &In1,
53 const APInt &In2, bool IsSigned = false) {
54 bool Overflow;
55 if (IsSigned)
56 Result = In1.ssub_ov(In2, Overflow);
57 else
58 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000059
Craig Topper6e025a32017-10-01 23:53:54 +000060 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000061}
62
Balaram Makam569eaec2016-05-04 21:32:14 +000063/// Given an icmp instruction, return true if any use of this comparison is a
64/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000065static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000066 for (auto *U : I.users())
67 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000068 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000069 return false;
70}
71
Sanjay Patel5f0217f2016-06-05 16:46:18 +000072/// Given an exploded icmp instruction, return true if the comparison only
73/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
74/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000075static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000076 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000077 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000078 case ICmpInst::ICMP_SLT: // True if LHS s< 0
79 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000080 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000081 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
82 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000083 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000084 case ICmpInst::ICMP_SGT: // True if LHS s> -1
85 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000086 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000087 case ICmpInst::ICMP_UGT:
88 // True if LHS u> RHS and RHS == high-bit-mask - 1
89 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000090 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000091 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000092 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
93 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000094 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000095 default:
96 return false;
97 }
98}
99
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000100/// Returns true if the exploded icmp can be expressed as a signed comparison
101/// to zero and updates the predicate accordingly.
102/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000103/// TODO: Refactor with decomposeBitTestICmp()?
104static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000105 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000106 return false;
107
Craig Topper73ba1c82017-06-07 07:40:37 +0000108 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000109 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000110
Craig Topper73ba1c82017-06-07 07:40:37 +0000111 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000112 if (Pred == ICmpInst::ICMP_SLT) {
113 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000114 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000116 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000117 if (Pred == ICmpInst::ICMP_SGT) {
118 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000119 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000121 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000122
123 return false;
124}
125
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000126/// Given a signed integer type and a set of known zero and one bits, compute
127/// the maximum and minimum values that could have the specified known zero and
128/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000129/// TODO: Move to method on KnownBits struct?
130static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000131 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000132 assert(Known.getBitWidth() == Min.getBitWidth() &&
133 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000134 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000135 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000136
137 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
138 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000139 Min = Known.One;
140 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000141
Chris Lattner2188e402010-01-04 07:37:31 +0000142 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000143 Min.setSignBit();
144 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000145 }
146}
147
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000148/// Given an unsigned integer type and a set of known zero and one bits, compute
149/// the maximum and minimum values that could have the specified known zero and
150/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000151/// TODO: Move to method on KnownBits struct?
152static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000153 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000154 assert(Known.getBitWidth() == Min.getBitWidth() &&
155 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000156 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000157 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000158
Chris Lattner2188e402010-01-04 07:37:31 +0000159 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000160 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000161 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000162 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000163}
164
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000165/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000166/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000167/// where GV is a global variable with a constant initializer. Try to simplify
168/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000169/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
170///
171/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000172/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000173Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
174 GlobalVariable *GV,
175 CmpInst &ICI,
176 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000177 Constant *Init = GV->getInitializer();
178 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000179 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000180
Chris Lattnerfe741762012-01-31 02:55:06 +0000181 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000182 // Don't blow up on huge arrays.
183 if (ArrayElementCount > MaxArraySizeForCombine)
184 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000185
Chris Lattner2188e402010-01-04 07:37:31 +0000186 // There are many forms of this optimization we can handle, for now, just do
187 // the simple index into a single-dimensional array.
188 //
189 // Require: GEP GV, 0, i {{, constant indices}}
190 if (GEP->getNumOperands() < 3 ||
191 !isa<ConstantInt>(GEP->getOperand(1)) ||
192 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
193 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000194 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000195
196 // Check that indices after the variable are constants and in-range for the
197 // type they index. Collect the indices. This is typically for arrays of
198 // structs.
199 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000200
Chris Lattnerfe741762012-01-31 02:55:06 +0000201 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000202 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
203 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000204 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000205
Chris Lattner2188e402010-01-04 07:37:31 +0000206 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000207 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner229907c2011-07-18 04:54:35 +0000209 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000210 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000211 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000212 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000213 EltTy = ATy->getElementType();
214 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000215 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000216 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000217
Chris Lattner2188e402010-01-04 07:37:31 +0000218 LaterIndices.push_back(IdxVal);
219 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000220
Chris Lattner2188e402010-01-04 07:37:31 +0000221 enum { Overdefined = -3, Undefined = -2 };
222
223 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000224
Chris Lattner2188e402010-01-04 07:37:31 +0000225 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
226 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
227 // and 87 is the second (and last) index. FirstTrueElement is -2 when
228 // undefined, otherwise set to the first true element. SecondTrueElement is
229 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
230 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
231
232 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
233 // form "i != 47 & i != 87". Same state transitions as for true elements.
234 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000235
Chris Lattner2188e402010-01-04 07:37:31 +0000236 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
237 /// define a state machine that triggers for ranges of values that the index
238 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
239 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
240 /// index in the range (inclusive). We use -2 for undefined here because we
241 /// use relative comparisons and don't want 0-1 to match -1.
242 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000243
Chris Lattner2188e402010-01-04 07:37:31 +0000244 // MagicBitvector - This is a magic bitvector where we set a bit if the
245 // comparison is true for element 'i'. If there are 64 elements or less in
246 // the array, this will fully represent all the comparison results.
247 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000248
Chris Lattner2188e402010-01-04 07:37:31 +0000249 // Scan the array and see if one of our patterns matches.
250 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000251 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
252 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000253 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000254
Chris Lattner2188e402010-01-04 07:37:31 +0000255 // If this is indexing an array of structures, get the structure element.
256 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000257 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000258
Chris Lattner2188e402010-01-04 07:37:31 +0000259 // If the element is masked, handle it.
260 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000261
Chris Lattner2188e402010-01-04 07:37:31 +0000262 // Find out if the comparison would be true or false for the i'th element.
263 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000264 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000265 // If the result is undef for this element, ignore it.
266 if (isa<UndefValue>(C)) {
267 // Extend range state machines to cover this element in case there is an
268 // undef in the middle of the range.
269 if (TrueRangeEnd == (int)i-1)
270 TrueRangeEnd = i;
271 if (FalseRangeEnd == (int)i-1)
272 FalseRangeEnd = i;
273 continue;
274 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000275
Chris Lattner2188e402010-01-04 07:37:31 +0000276 // If we can't compute the result for any of the elements, we have to give
277 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000278 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000279
Chris Lattner2188e402010-01-04 07:37:31 +0000280 // Otherwise, we know if the comparison is true or false for this element,
281 // update our state machines.
282 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000283
Chris Lattner2188e402010-01-04 07:37:31 +0000284 // State machine for single/double/range index comparison.
285 if (IsTrueForElt) {
286 // Update the TrueElement state machine.
287 if (FirstTrueElement == Undefined)
288 FirstTrueElement = TrueRangeEnd = i; // First true element.
289 else {
290 // Update double-compare state machine.
291 if (SecondTrueElement == Undefined)
292 SecondTrueElement = i;
293 else
294 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000295
Chris Lattner2188e402010-01-04 07:37:31 +0000296 // Update range state machine.
297 if (TrueRangeEnd == (int)i-1)
298 TrueRangeEnd = i;
299 else
300 TrueRangeEnd = Overdefined;
301 }
302 } else {
303 // Update the FalseElement state machine.
304 if (FirstFalseElement == Undefined)
305 FirstFalseElement = FalseRangeEnd = i; // First false element.
306 else {
307 // Update double-compare state machine.
308 if (SecondFalseElement == Undefined)
309 SecondFalseElement = i;
310 else
311 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000312
Chris Lattner2188e402010-01-04 07:37:31 +0000313 // Update range state machine.
314 if (FalseRangeEnd == (int)i-1)
315 FalseRangeEnd = i;
316 else
317 FalseRangeEnd = Overdefined;
318 }
319 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000320
Chris Lattner2188e402010-01-04 07:37:31 +0000321 // If this element is in range, update our magic bitvector.
322 if (i < 64 && IsTrueForElt)
323 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000324
Chris Lattner2188e402010-01-04 07:37:31 +0000325 // If all of our states become overdefined, bail out early. Since the
326 // predicate is expensive, only check it every 8 elements. This is only
327 // really useful for really huge arrays.
328 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
329 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
330 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000331 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000332 }
333
334 // Now that we've scanned the entire array, emit our new comparison(s). We
335 // order the state machines in complexity of the generated code.
336 Value *Idx = GEP->getOperand(2);
337
Matt Arsenault5aeae182013-08-19 21:40:31 +0000338 // If the index is larger than the pointer size of the target, truncate the
339 // index down like the GEP would do implicitly. We don't have to do this for
340 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000341 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000342 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000343 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
344 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000345 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000346 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000347
Chris Lattner2188e402010-01-04 07:37:31 +0000348 // If the comparison is only true for one or two elements, emit direct
349 // comparisons.
350 if (SecondTrueElement != Overdefined) {
351 // None true -> false.
352 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000353 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000354
Chris Lattner2188e402010-01-04 07:37:31 +0000355 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000356
Chris Lattner2188e402010-01-04 07:37:31 +0000357 // True for one element -> 'i == 47'.
358 if (SecondTrueElement == Undefined)
359 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000360
Chris Lattner2188e402010-01-04 07:37:31 +0000361 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000362 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000363 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000364 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000365 return BinaryOperator::CreateOr(C1, C2);
366 }
367
368 // If the comparison is only false for one or two elements, emit direct
369 // comparisons.
370 if (SecondFalseElement != Overdefined) {
371 // None false -> true.
372 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000373 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000374
Chris Lattner2188e402010-01-04 07:37:31 +0000375 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
376
377 // False for one element -> 'i != 47'.
378 if (SecondFalseElement == Undefined)
379 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000380
Chris Lattner2188e402010-01-04 07:37:31 +0000381 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000382 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000383 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000384 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000385 return BinaryOperator::CreateAnd(C1, C2);
386 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000387
Chris Lattner2188e402010-01-04 07:37:31 +0000388 // If the comparison can be replaced with a range comparison for the elements
389 // where it is true, emit the range check.
390 if (TrueRangeEnd != Overdefined) {
391 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000392
Chris Lattner2188e402010-01-04 07:37:31 +0000393 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
394 if (FirstTrueElement) {
395 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000396 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000397 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000398
Chris Lattner2188e402010-01-04 07:37:31 +0000399 Value *End = ConstantInt::get(Idx->getType(),
400 TrueRangeEnd-FirstTrueElement+1);
401 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
402 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000403
Chris Lattner2188e402010-01-04 07:37:31 +0000404 // False range check.
405 if (FalseRangeEnd != Overdefined) {
406 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
407 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
408 if (FirstFalseElement) {
409 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000410 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000411 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000412
Chris Lattner2188e402010-01-04 07:37:31 +0000413 Value *End = ConstantInt::get(Idx->getType(),
414 FalseRangeEnd-FirstFalseElement);
415 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
416 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000417
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000418 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000419 // of this load, replace it with computation that does:
420 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000421 {
Craig Topperf40110f2014-04-25 05:29:35 +0000422 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000423
424 // Look for an appropriate type:
425 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000426 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000427 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
428 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000429 else
430 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000431
Craig Topperf40110f2014-04-25 05:29:35 +0000432 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000433 Value *V = Builder.CreateIntCast(Idx, Ty, false);
434 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
435 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000436 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
437 }
Chris Lattner2188e402010-01-04 07:37:31 +0000438 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000439
Craig Topperf40110f2014-04-25 05:29:35 +0000440 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000441}
442
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000443/// Return a value that can be used to compare the *offset* implied by a GEP to
444/// zero. For example, if we have &A[i], we want to return 'i' for
445/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
446/// are involved. The above expression would also be legal to codegen as
447/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
448/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000449/// to generate the first by knowing that pointer arithmetic doesn't overflow.
450///
451/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000452///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000453static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000454 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000455 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000456
Chris Lattner2188e402010-01-04 07:37:31 +0000457 // Check to see if this gep only has a single variable index. If so, and if
458 // any constant indices are a multiple of its scale, then we can compute this
459 // in terms of the scale of the variable index. For example, if the GEP
460 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
461 // because the expression will cross zero at the same point.
462 unsigned i, e = GEP->getNumOperands();
463 int64_t Offset = 0;
464 for (i = 1; i != e; ++i, ++GTI) {
465 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
466 // Compute the aggregate offset of constant indices.
467 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000468
Chris Lattner2188e402010-01-04 07:37:31 +0000469 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000470 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000471 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000472 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000473 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000474 Offset += Size*CI->getSExtValue();
475 }
476 } else {
477 // Found our variable index.
478 break;
479 }
480 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000481
Chris Lattner2188e402010-01-04 07:37:31 +0000482 // If there are no variable indices, we must have a constant offset, just
483 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000484 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000485
Chris Lattner2188e402010-01-04 07:37:31 +0000486 Value *VariableIdx = GEP->getOperand(i);
487 // Determine the scale factor of the variable element. For example, this is
488 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000489 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000490
Chris Lattner2188e402010-01-04 07:37:31 +0000491 // Verify that there are no other variable indices. If so, emit the hard way.
492 for (++i, ++GTI; i != e; ++i, ++GTI) {
493 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000494 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000495
Chris Lattner2188e402010-01-04 07:37:31 +0000496 // Compute the aggregate offset of constant indices.
497 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000498
Chris Lattner2188e402010-01-04 07:37:31 +0000499 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000500 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000501 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000502 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000503 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000504 Offset += Size*CI->getSExtValue();
505 }
506 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000507
Chris Lattner2188e402010-01-04 07:37:31 +0000508 // Okay, we know we have a single variable index, which must be a
509 // pointer/array/vector index. If there is no offset, life is simple, return
510 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000511 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000512 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000513 if (Offset == 0) {
514 // Cast to intptrty in case a truncation occurs. If an extension is needed,
515 // we don't need to bother extending: the extension won't affect where the
516 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000517 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000518 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000519 }
Chris Lattner2188e402010-01-04 07:37:31 +0000520 return VariableIdx;
521 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000522
Chris Lattner2188e402010-01-04 07:37:31 +0000523 // Otherwise, there is an index. The computation we will do will be modulo
Nikita Popov36e03ac2018-12-12 23:19:03 +0000524 // the pointer size.
525 Offset = SignExtend64(Offset, IntPtrWidth);
526 VariableScale = SignExtend64(VariableScale, IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 // To do this transformation, any constant index must be a multiple of the
529 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
530 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
531 // multiple of the variable scale.
532 int64_t NewOffs = Offset / (int64_t)VariableScale;
533 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000534 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000535
Chris Lattner2188e402010-01-04 07:37:31 +0000536 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000537 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000538 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000539 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000540 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000542}
543
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000544/// Returns true if we can rewrite Start as a GEP with pointer Base
545/// and some integer offset. The nodes that need to be re-written
546/// for this transformation will be added to Explored.
547static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
548 const DataLayout &DL,
549 SetVector<Value *> &Explored) {
550 SmallVector<Value *, 16> WorkList(1, Start);
551 Explored.insert(Base);
552
553 // The following traversal gives us an order which can be used
554 // when doing the final transformation. Since in the final
555 // transformation we create the PHI replacement instructions first,
556 // we don't have to get them in any particular order.
557 //
558 // However, for other instructions we will have to traverse the
559 // operands of an instruction first, which means that we have to
560 // do a post-order traversal.
561 while (!WorkList.empty()) {
562 SetVector<PHINode *> PHIs;
563
564 while (!WorkList.empty()) {
565 if (Explored.size() >= 100)
566 return false;
567
568 Value *V = WorkList.back();
569
570 if (Explored.count(V) != 0) {
571 WorkList.pop_back();
572 continue;
573 }
574
575 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000576 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000577 // We've found some value that we can't explore which is different from
578 // the base. Therefore we can't do this transformation.
579 return false;
580
581 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
582 auto *CI = dyn_cast<CastInst>(V);
583 if (!CI->isNoopCast(DL))
584 return false;
585
586 if (Explored.count(CI->getOperand(0)) == 0)
587 WorkList.push_back(CI->getOperand(0));
588 }
589
590 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
591 // We're limiting the GEP to having one index. This will preserve
592 // the original pointer type. We could handle more cases in the
593 // future.
594 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
595 GEP->getType() != Start->getType())
596 return false;
597
598 if (Explored.count(GEP->getOperand(0)) == 0)
599 WorkList.push_back(GEP->getOperand(0));
600 }
601
602 if (WorkList.back() == V) {
603 WorkList.pop_back();
604 // We've finished visiting this node, mark it as such.
605 Explored.insert(V);
606 }
607
608 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000609 // We cannot transform PHIs on unsplittable basic blocks.
610 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
611 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000612 Explored.insert(PN);
613 PHIs.insert(PN);
614 }
615 }
616
617 // Explore the PHI nodes further.
618 for (auto *PN : PHIs)
619 for (Value *Op : PN->incoming_values())
620 if (Explored.count(Op) == 0)
621 WorkList.push_back(Op);
622 }
623
624 // Make sure that we can do this. Since we can't insert GEPs in a basic
625 // block before a PHI node, we can't easily do this transformation if
626 // we have PHI node users of transformed instructions.
627 for (Value *Val : Explored) {
628 for (Value *Use : Val->uses()) {
629
630 auto *PHI = dyn_cast<PHINode>(Use);
631 auto *Inst = dyn_cast<Instruction>(Val);
632
633 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
634 Explored.count(PHI) == 0)
635 continue;
636
637 if (PHI->getParent() == Inst->getParent())
638 return false;
639 }
640 }
641 return true;
642}
643
644// Sets the appropriate insert point on Builder where we can add
645// a replacement Instruction for V (if that is possible).
646static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
647 bool Before = true) {
648 if (auto *PHI = dyn_cast<PHINode>(V)) {
649 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
650 return;
651 }
652 if (auto *I = dyn_cast<Instruction>(V)) {
653 if (!Before)
654 I = &*std::next(I->getIterator());
655 Builder.SetInsertPoint(I);
656 return;
657 }
658 if (auto *A = dyn_cast<Argument>(V)) {
659 // Set the insertion point in the entry block.
660 BasicBlock &Entry = A->getParent()->getEntryBlock();
661 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
662 return;
663 }
664 // Otherwise, this is a constant and we don't need to set a new
665 // insertion point.
666 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
667}
668
669/// Returns a re-written value of Start as an indexed GEP using Base as a
670/// pointer.
671static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
672 const DataLayout &DL,
673 SetVector<Value *> &Explored) {
674 // Perform all the substitutions. This is a bit tricky because we can
675 // have cycles in our use-def chains.
676 // 1. Create the PHI nodes without any incoming values.
677 // 2. Create all the other values.
678 // 3. Add the edges for the PHI nodes.
679 // 4. Emit GEPs to get the original pointers.
680 // 5. Remove the original instructions.
681 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000682 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000683
684 DenseMap<Value *, Value *> NewInsts;
685 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
686
687 // Create the new PHI nodes, without adding any incoming values.
688 for (Value *Val : Explored) {
689 if (Val == Base)
690 continue;
691 // Create empty phi nodes. This avoids cyclic dependencies when creating
692 // the remaining instructions.
693 if (auto *PHI = dyn_cast<PHINode>(Val))
694 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
695 PHI->getName() + ".idx", PHI);
696 }
697 IRBuilder<> Builder(Base->getContext());
698
699 // Create all the other instructions.
700 for (Value *Val : Explored) {
701
702 if (NewInsts.find(Val) != NewInsts.end())
703 continue;
704
705 if (auto *CI = dyn_cast<CastInst>(Val)) {
Martin Storsjo0fe645c2019-05-30 20:53:21 +0000706 // Don't get rid of the intermediate variable here; the store can grow
707 // the map which will invalidate the reference to the input value.
708 Value *V = NewInsts[CI->getOperand(0)];
709 NewInsts[CI] = V;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
835 if (!GEPLHS->hasAllConstantIndices())
836 return nullptr;
837
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000838 // Make sure the pointers have the same type.
839 if (GEPLHS->getType() != RHS->getType())
840 return nullptr;
841
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000842 Value *PtrBase, *Index;
843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
844
845 // The set of nodes that will take part in this transformation.
846 SetVector<Value *> Nodes;
847
848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
849 return nullptr;
850
851 // We know we can re-write this as
852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
853 // Since we've only looked through inbouds GEPs we know that we
854 // can't have overflow on either side. We can therefore re-write
855 // this as:
856 // OFFSET1 cmp OFFSET2
857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
858
859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
861 // offset. Since Index is the offset of LHS to the base pointer, we will now
862 // compare the offsets instead of comparing the pointers.
863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
864}
865
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000866/// Fold comparisons between a GEP instruction and something else. At this point
867/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000868Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000869 ICmpInst::Predicate Cond,
870 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000871 // Don't transform signed compares of GEPs into index compares. Even if the
872 // GEP is inbounds, the final add of the base pointer can have signed overflow
873 // and would change the result of the icmp.
874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000875 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000876 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000877 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000878
Matt Arsenault44f60d02014-06-09 19:20:29 +0000879 // Look through bitcasts and addrspacecasts. We do not however want to remove
880 // 0 GEPs.
881 if (!isa<GetElementPtrInst>(RHS))
882 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000883
884 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000885 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
887 // This transformation (ignoring the base and scales) is valid because we
888 // know pointers can't overflow since the gep is inbounds. See if we can
889 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000891
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000893 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000894 Offset = EmitGEPOffset(GEPLHS);
895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
896 Constant::getNullValue(Offset->getType()));
897 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
898 // If the base pointers are different, but the indices are the same, just
899 // compare the base pointer.
900 if (PtrBase != GEPRHS->getOperand(0)) {
901 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
902 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
903 GEPRHS->getOperand(0)->getType();
904 if (IndicesTheSame)
905 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
906 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
907 IndicesTheSame = false;
908 break;
909 }
910
911 // If all indices are the same, just compare the base pointers.
Jesper Antonssonc954b862018-10-01 14:59:25 +0000912 Type *BaseType = GEPLHS->getOperand(0)->getType();
913 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType())
David Majnemer5953d372013-06-29 10:28:04 +0000914 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000915
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000916 // If we're comparing GEPs with two base pointers that only differ in type
917 // and both GEPs have only constant indices or just one use, then fold
918 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000919 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000920 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
921 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
922 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000923 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000924 Value *LOffset = EmitGEPOffset(GEPLHS);
925 Value *ROffset = EmitGEPOffset(GEPRHS);
926
927 // If we looked through an addrspacecast between different sized address
928 // spaces, the LHS and RHS pointers are different sized
929 // integers. Truncate to the smaller one.
930 Type *LHSIndexTy = LOffset->getType();
931 Type *RHSIndexTy = ROffset->getType();
932 if (LHSIndexTy != RHSIndexTy) {
933 if (LHSIndexTy->getPrimitiveSizeInBits() <
934 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000935 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000936 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000937 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000938 }
939
Craig Topperbb4069e2017-07-07 23:16:26 +0000940 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
941 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000942 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000943 }
944
Chris Lattner2188e402010-01-04 07:37:31 +0000945 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000946 // different. Try convert this to an indexed compare by looking through
947 // PHIs/casts.
948 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000949 }
950
951 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000952 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000953 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000954 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000955
956 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000957 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000958 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000959
Stuart Hastings66a82b92011-05-14 05:55:10 +0000960 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000961 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
962 // If the GEPs only differ by one index, compare it.
963 unsigned NumDifferences = 0; // Keep track of # differences.
964 unsigned DiffOperand = 0; // The operand that differs.
965 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
966 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
967 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
968 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
969 // Irreconcilable differences.
970 NumDifferences = 2;
971 break;
972 } else {
973 if (NumDifferences++) break;
974 DiffOperand = i;
975 }
976 }
977
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +0000978 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +0000979 return replaceInstUsesWith(I, // No comparison is needed here.
Jesper Antonsson719fa052018-09-20 13:37:28 +0000980 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +0000981
Stuart Hastings66a82b92011-05-14 05:55:10 +0000982 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +0000983 Value *LHSV = GEPLHS->getOperand(DiffOperand);
984 Value *RHSV = GEPRHS->getOperand(DiffOperand);
985 // Make sure we do a signed comparison here.
986 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
987 }
988 }
989
990 // Only lower this if the icmp is the only user of the GEP or if we expect
991 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000992 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +0000993 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
994 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
995 Value *L = EmitGEPOffset(GEPLHS);
996 Value *R = EmitGEPOffset(GEPRHS);
997 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
998 }
999 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001000
1001 // Try convert this to an indexed compare by looking through PHIs/casts as a
1002 // last resort.
1003 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001004}
1005
Pete Cooper980a9352016-08-12 17:13:28 +00001006Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1007 const AllocaInst *Alloca,
1008 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001009 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1010
1011 // It would be tempting to fold away comparisons between allocas and any
1012 // pointer not based on that alloca (e.g. an argument). However, even
1013 // though such pointers cannot alias, they can still compare equal.
1014 //
1015 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1016 // doesn't escape we can argue that it's impossible to guess its value, and we
1017 // can therefore act as if any such guesses are wrong.
1018 //
1019 // The code below checks that the alloca doesn't escape, and that it's only
1020 // used in a comparison once (the current instruction). The
1021 // single-comparison-use condition ensures that we're trivially folding all
1022 // comparisons against the alloca consistently, and avoids the risk of
1023 // erroneously folding a comparison of the pointer with itself.
1024
1025 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1026
Pete Cooper980a9352016-08-12 17:13:28 +00001027 SmallVector<const Use *, 32> Worklist;
1028 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001029 if (Worklist.size() >= MaxIter)
1030 return nullptr;
1031 Worklist.push_back(&U);
1032 }
1033
1034 unsigned NumCmps = 0;
1035 while (!Worklist.empty()) {
1036 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001037 const Use *U = Worklist.pop_back_val();
1038 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001039 --MaxIter;
1040
1041 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1042 isa<SelectInst>(V)) {
1043 // Track the uses.
1044 } else if (isa<LoadInst>(V)) {
1045 // Loading from the pointer doesn't escape it.
1046 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001047 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001048 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1049 if (SI->getValueOperand() == U->get())
1050 return nullptr;
1051 continue;
1052 } else if (isa<ICmpInst>(V)) {
1053 if (NumCmps++)
1054 return nullptr; // Found more than one cmp.
1055 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001056 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001057 switch (Intrin->getIntrinsicID()) {
1058 // These intrinsics don't escape or compare the pointer. Memset is safe
1059 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1060 // we don't allow stores, so src cannot point to V.
1061 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001062 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1063 continue;
1064 default:
1065 return nullptr;
1066 }
1067 } else {
1068 return nullptr;
1069 }
Pete Cooper980a9352016-08-12 17:13:28 +00001070 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001071 if (Worklist.size() >= MaxIter)
1072 return nullptr;
1073 Worklist.push_back(&U);
1074 }
1075 }
1076
1077 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001078 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001079 ICI,
1080 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1081}
1082
Craig Topperbee74792018-08-20 23:04:25 +00001083/// Fold "icmp pred (X+C), X".
1084Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001085 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001086 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001087 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001088 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001089 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001090
Chris Lattner8c92b572010-01-08 17:48:19 +00001091 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001092 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1093 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1094 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001095 Constant *R = ConstantInt::get(X->getType(),
1096 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001097 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1098 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001099
Chris Lattner2188e402010-01-04 07:37:31 +00001100 // (X+1) >u X --> X <u (0-1) --> X != 255
1101 // (X+2) >u X --> X <u (0-2) --> X <u 254
1102 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001103 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001104 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1105 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001106
Craig Topperbee74792018-08-20 23:04:25 +00001107 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001108
1109 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1110 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1111 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1112 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1113 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1114 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001115 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001116 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1117 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001118
Chris Lattner2188e402010-01-04 07:37:31 +00001119 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1120 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1121 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1122 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1123 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1124 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001125
Chris Lattner2188e402010-01-04 07:37:31 +00001126 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001127 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1128 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001129}
1130
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001131/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1132/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1133/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1134Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1135 const APInt &AP1,
1136 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001137 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1138
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001139 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1140 if (I.getPredicate() == I.ICMP_NE)
1141 Pred = CmpInst::getInversePredicate(Pred);
1142 return new ICmpInst(Pred, LHS, RHS);
1143 };
1144
David Majnemer2abb8182014-10-25 07:13:13 +00001145 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001146 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001147 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001148
1149 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001150 if (IsAShr) {
1151 if (AP2.isAllOnesValue())
1152 return nullptr;
1153 if (AP2.isNegative() != AP1.isNegative())
1154 return nullptr;
1155 if (AP2.sgt(AP1))
1156 return nullptr;
1157 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001158
David Majnemerd2056022014-10-21 19:51:55 +00001159 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001160 // 'A' must be large enough to shift out the highest set bit.
1161 return getICmp(I.ICMP_UGT, A,
1162 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001163
David Majnemerd2056022014-10-21 19:51:55 +00001164 if (AP1 == AP2)
1165 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001166
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001167 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001168 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001169 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001170 else
David Majnemere5977eb2015-09-19 00:48:26 +00001171 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001172
David Majnemerd2056022014-10-21 19:51:55 +00001173 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001174 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1175 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001176 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001177 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1178 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001179 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001180 } else if (AP1 == AP2.lshr(Shift)) {
1181 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1182 }
David Majnemerd2056022014-10-21 19:51:55 +00001183 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001184
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001185 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001186 // FIXME: This should always be handled by InstSimplify?
1187 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1188 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001189}
Chris Lattner2188e402010-01-04 07:37:31 +00001190
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001191/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1192/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1193Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1194 const APInt &AP1,
1195 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001196 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1197
David Majnemer59939ac2014-10-19 08:23:08 +00001198 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1199 if (I.getPredicate() == I.ICMP_NE)
1200 Pred = CmpInst::getInversePredicate(Pred);
1201 return new ICmpInst(Pred, LHS, RHS);
1202 };
1203
David Majnemer2abb8182014-10-25 07:13:13 +00001204 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001205 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001206 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001207
1208 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1209
1210 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001211 return getICmp(
1212 I.ICMP_UGE, A,
1213 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001214
1215 if (AP1 == AP2)
1216 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1217
1218 // Get the distance between the lowest bits that are set.
1219 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1220
1221 if (Shift > 0 && AP2.shl(Shift) == AP1)
1222 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1223
1224 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001225 // FIXME: This should always be handled by InstSimplify?
1226 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1227 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001228}
1229
Sanjay Patel06b127a2016-09-15 14:37:50 +00001230/// The caller has matched a pattern of the form:
1231/// I = icmp ugt (add (add A, B), CI2), CI1
1232/// If this is of the form:
1233/// sum = a + b
1234/// if (sum+128 >u 255)
1235/// Then replace it with llvm.sadd.with.overflow.i8.
1236///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001237static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001238 ConstantInt *CI2, ConstantInt *CI1,
1239 InstCombiner &IC) {
1240 // The transformation we're trying to do here is to transform this into an
1241 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1242 // with a narrower add, and discard the add-with-constant that is part of the
1243 // range check (if we can't eliminate it, this isn't profitable).
1244
1245 // In order to eliminate the add-with-constant, the compare can be its only
1246 // use.
1247 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1248 if (!AddWithCst->hasOneUse())
1249 return nullptr;
1250
1251 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1252 if (!CI2->getValue().isPowerOf2())
1253 return nullptr;
1254 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1255 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1256 return nullptr;
1257
1258 // The width of the new add formed is 1 more than the bias.
1259 ++NewWidth;
1260
1261 // Check to see that CI1 is an all-ones value with NewWidth bits.
1262 if (CI1->getBitWidth() == NewWidth ||
1263 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1264 return nullptr;
1265
1266 // This is only really a signed overflow check if the inputs have been
1267 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1268 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1269 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1270 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1271 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1272 return nullptr;
1273
1274 // In order to replace the original add with a narrower
1275 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1276 // and truncates that discard the high bits of the add. Verify that this is
1277 // the case.
1278 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1279 for (User *U : OrigAdd->users()) {
1280 if (U == AddWithCst)
1281 continue;
1282
1283 // Only accept truncates for now. We would really like a nice recursive
1284 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1285 // chain to see which bits of a value are actually demanded. If the
1286 // original add had another add which was then immediately truncated, we
1287 // could still do the transformation.
1288 TruncInst *TI = dyn_cast<TruncInst>(U);
1289 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1290 return nullptr;
1291 }
1292
1293 // If the pattern matches, truncate the inputs to the narrower type and
1294 // use the sadd_with_overflow intrinsic to efficiently compute both the
1295 // result and the overflow bit.
1296 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
James Y Knight7976eb52019-02-01 20:43:25 +00001297 Function *F = Intrinsic::getDeclaration(
1298 I.getModule(), Intrinsic::sadd_with_overflow, NewType);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001299
Craig Topperbb4069e2017-07-07 23:16:26 +00001300 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001301
1302 // Put the new code above the original add, in case there are any uses of the
1303 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001304 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001305
Craig Topperbb4069e2017-07-07 23:16:26 +00001306 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1307 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1308 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1309 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1310 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001311
1312 // The inner add was the result of the narrow add, zero extended to the
1313 // wider type. Replace it with the result computed by the intrinsic.
1314 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1315
1316 // The original icmp gets replaced with the overflow value.
1317 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1318}
1319
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001320// Handle (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1321Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1322 CmpInst::Predicate Pred = Cmp.getPredicate();
1323 Value *X = Cmp.getOperand(0);
1324
1325 if (match(Cmp.getOperand(1), m_Zero()) && Pred == ICmpInst::ICMP_SGT) {
1326 Value *A, *B;
1327 SelectPatternResult SPR = matchSelectPattern(X, A, B);
1328 if (SPR.Flavor == SPF_SMIN) {
1329 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1330 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1331 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1332 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1333 }
1334 }
1335 return nullptr;
1336}
1337
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001338/// Fold icmp Pred X, C.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001339/// TODO: This code structure does not make sense. The saturating add fold
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001340/// should be moved to some other helper and extended as noted below (it is also
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001341/// possible that code has been made unnecessary - do we canonicalize IR to
1342/// overflow/saturating intrinsics or not?).
Sanjay Patel97459832016-09-15 15:11:12 +00001343Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
Sanjay Patel97459832016-09-15 15:11:12 +00001344 // Match the following pattern, which is a common idiom when writing
1345 // overflow-safe integer arithmetic functions. The source performs an addition
1346 // in wider type and explicitly checks for overflow using comparisons against
1347 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1348 //
1349 // TODO: This could probably be generalized to handle other overflow-safe
1350 // operations if we worked out the formulas to compute the appropriate magic
1351 // constants.
1352 //
1353 // sum = a + b
1354 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001355 CmpInst::Predicate Pred = Cmp.getPredicate();
1356 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1);
1357 Value *A, *B;
1358 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1359 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) &&
1360 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
1361 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this))
1362 return Res;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001363
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001364 return nullptr;
1365}
1366
1367/// Canonicalize icmp instructions based on dominating conditions.
1368Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) {
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001369 // This is a cheap/incomplete check for dominance - just match a single
1370 // predecessor with a conditional branch.
1371 BasicBlock *CmpBB = Cmp.getParent();
1372 BasicBlock *DomBB = CmpBB->getSinglePredecessor();
1373 if (!DomBB)
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001374 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001375
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001376 Value *DomCond;
Sanjay Patel97459832016-09-15 15:11:12 +00001377 BasicBlock *TrueBB, *FalseBB;
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001378 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB)))
1379 return nullptr;
1380
1381 assert((TrueBB == CmpBB || FalseBB == CmpBB) &&
1382 "Predecessor block does not point to successor?");
1383
1384 // The branch should get simplified. Don't bother simplifying this condition.
1385 if (TrueBB == FalseBB)
1386 return nullptr;
1387
Sanjay Patelbaffae92018-12-05 15:04:00 +00001388 // Try to simplify this compare to T/F based on the dominating condition.
1389 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB);
1390 if (Imp)
1391 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp));
1392
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001393 CmpInst::Predicate Pred = Cmp.getPredicate();
1394 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1);
1395 ICmpInst::Predicate DomPred;
1396 const APInt *C, *DomC;
1397 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) &&
1398 match(Y, m_APInt(C))) {
1399 // We have 2 compares of a variable with constants. Calculate the constant
1400 // ranges of those compares to see if we can transform the 2nd compare:
1401 // DomBB:
1402 // DomCond = icmp DomPred X, DomC
1403 // br DomCond, CmpBB, FalseBB
1404 // CmpBB:
1405 // Cmp = icmp Pred X, C
1406 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C);
Sanjay Patel97459832016-09-15 15:11:12 +00001407 ConstantRange DominatingCR =
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001408 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC)
1409 : ConstantRange::makeExactICmpRegion(
1410 CmpInst::getInversePredicate(DomPred), *DomC);
Sanjay Patel97459832016-09-15 15:11:12 +00001411 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1412 ConstantRange Difference = DominatingCR.difference(CR);
1413 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001414 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001415 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001416 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001417
Sanjay Patel97459832016-09-15 15:11:12 +00001418 // Canonicalizing a sign bit comparison that gets used in a branch,
1419 // pessimizes codegen by generating branch on zero instruction instead
1420 // of a test and branch. So we avoid canonicalizing in such situations
1421 // because test and branch instruction has better branch displacement
1422 // than compare and branch instruction.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001423 bool UnusedBit;
1424 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit);
Eric Christophera95aac32017-06-30 01:57:48 +00001425 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1426 return nullptr;
1427
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001428 if (const APInt *EqC = Intersection.getSingleElement())
1429 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC));
1430 if (const APInt *NeC = Difference.getSingleElement())
1431 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001432 }
1433
1434 return nullptr;
1435}
1436
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001437/// Fold icmp (trunc X, Y), C.
1438Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001439 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001440 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001441 ICmpInst::Predicate Pred = Cmp.getPredicate();
1442 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001443 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001444 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1445 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001446 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001447 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1448 ConstantInt::get(V->getType(), 1));
1449 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001450
1451 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001452 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1453 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001454 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1455 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001456 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001457
1458 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001459 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001460 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001461 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001462 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001463 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001464 }
1465 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001466
Sanjay Patela3f4f082016-08-16 17:54:36 +00001467 return nullptr;
1468}
1469
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001470/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001471Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1472 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001473 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001474 Value *X = Xor->getOperand(0);
1475 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001476 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001477 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001478 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001479
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001480 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1481 // fold the xor.
1482 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001483 bool TrueIfSigned = false;
1484 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001485
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001486 // If the sign bit of the XorCst is not set, there is no change to
1487 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001488 if (!XorC->isNegative()) {
1489 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001490 Worklist.Add(Xor);
1491 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001492 }
1493
Craig Topperdf63b962017-10-03 19:14:23 +00001494 // Emit the opposite comparison.
1495 if (TrueIfSigned)
1496 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1497 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001498 else
Craig Topperdf63b962017-10-03 19:14:23 +00001499 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1500 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001501 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001502
1503 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001504 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1505 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001506 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1507 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001508 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001509 }
1510
Craig Topperbcfd2d12017-04-20 16:56:25 +00001511 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001512 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1513 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1514 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001515 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001516 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001517 }
1518 }
1519
Sanjay Patel26725bd2018-09-11 22:00:15 +00001520 // Mask constant magic can eliminate an 'xor' with unsigned compares.
1521 if (Pred == ICmpInst::ICMP_UGT) {
1522 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2)
1523 if (*XorC == ~C && (C + 1).isPowerOf2())
1524 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
1525 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2)
1526 if (*XorC == C && (C + 1).isPowerOf2())
1527 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
1528 }
1529 if (Pred == ICmpInst::ICMP_ULT) {
1530 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2)
1531 if (*XorC == -C && C.isPowerOf2())
1532 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1533 ConstantInt::get(X->getType(), ~C));
1534 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2)
1535 if (*XorC == C && (-C).isPowerOf2())
1536 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1537 ConstantInt::get(X->getType(), ~C));
1538 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001539 return nullptr;
1540}
1541
Sanjay Patel14e0e182016-08-26 18:28:46 +00001542/// Fold icmp (and (sh X, Y), C2), C1.
1543Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001544 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001545 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1546 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001547 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001548
Sanjay Patelda9c5622016-08-26 17:15:22 +00001549 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1550 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1551 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001552 // This seemingly simple opportunity to fold away a shift turns out to be
1553 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001554 unsigned ShiftOpcode = Shift->getOpcode();
1555 bool IsShl = ShiftOpcode == Instruction::Shl;
1556 const APInt *C3;
1557 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001558 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001559 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001560 // For a left shift, we can fold if the comparison is not signed. We can
1561 // also fold a signed comparison if the mask value and comparison value
1562 // are not negative. These constraints may not be obvious, but we can
1563 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001564 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001565 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001566 } else {
1567 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001568 // For a logical right shift, we can fold if the comparison is not signed.
1569 // We can also fold a signed comparison if the shifted mask value and the
1570 // shifted comparison value are not negative. These constraints may not be
1571 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001572 // For an arithmetic shift right we can do the same, if we ensure
1573 // the And doesn't use any bits being shifted in. Normally these would
1574 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1575 // additional user.
1576 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1577 if (!Cmp.isSigned() ||
1578 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1579 CanFold = true;
1580 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001581 }
1582
Sanjay Patelda9c5622016-08-26 17:15:22 +00001583 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001584 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001585 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001586 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001587 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001588 // If we shifted bits out, the fold is not going to work out. As a
1589 // special case, check to see if this means that the result is always
1590 // true or false now.
1591 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001592 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001593 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001594 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001595 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001596 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001597 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001598 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001599 And->setOperand(0, Shift->getOperand(0));
1600 Worklist.Add(Shift); // Shift is dead.
1601 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001602 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001603 }
1604 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001605
Sanjay Patelda9c5622016-08-26 17:15:22 +00001606 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1607 // preferable because it allows the C2 << Y expression to be hoisted out of a
1608 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001609 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001610 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1611 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001612 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001613 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1614 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001615
Sanjay Patelda9c5622016-08-26 17:15:22 +00001616 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001617 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001618 Cmp.setOperand(0, NewAnd);
1619 return &Cmp;
1620 }
1621
Sanjay Patel14e0e182016-08-26 18:28:46 +00001622 return nullptr;
1623}
1624
1625/// Fold icmp (and X, C2), C1.
1626Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1627 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001628 const APInt &C1) {
Sanjay Patel05aadf82018-10-10 20:47:46 +00001629 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1
1630 // TODO: We canonicalize to the longer form for scalars because we have
1631 // better analysis/folds for icmp, and codegen may be better with icmp.
1632 if (Cmp.getPredicate() == CmpInst::ICMP_NE && Cmp.getType()->isVectorTy() &&
1633 C1.isNullValue() && match(And->getOperand(1), m_One()))
1634 return new TruncInst(And->getOperand(0), Cmp.getType());
1635
Sanjay Patel6b490972016-09-04 14:32:15 +00001636 const APInt *C2;
1637 if (!match(And->getOperand(1), m_APInt(C2)))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001638 return nullptr;
1639
Craig Topper8bf62212017-09-26 18:47:25 +00001640 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001641 return nullptr;
1642
Sanjay Patel6b490972016-09-04 14:32:15 +00001643 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1644 // the input width without changing the value produced, eliminate the cast:
1645 //
1646 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1647 //
1648 // We can do this transformation if the constants do not have their sign bits
1649 // set or if it is an equality comparison. Extending a relational comparison
1650 // when we're checking the sign bit would not work.
1651 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001652 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001653 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001654 // TODO: Is this a good transform for vectors? Wider types may reduce
1655 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001656 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001657 if (!Cmp.getType()->isVectorTy()) {
1658 Type *WideType = W->getType();
1659 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001660 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001661 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001662 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001663 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001664 }
1665 }
1666
Craig Topper8ed1aa92017-10-03 05:31:07 +00001667 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001668 return I;
1669
Sanjay Patelda9c5622016-08-26 17:15:22 +00001670 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001671 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001672 //
1673 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001674 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001675 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001676 Constant *One = cast<Constant>(And->getOperand(1));
1677 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001678 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001679 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1680 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1681 unsigned UsesRemoved = 0;
1682 if (And->hasOneUse())
1683 ++UsesRemoved;
1684 if (Or->hasOneUse())
1685 ++UsesRemoved;
1686 if (LShr->hasOneUse())
1687 ++UsesRemoved;
1688
1689 // Compute A & ((1 << B) | 1)
1690 Value *NewOr = nullptr;
1691 if (auto *C = dyn_cast<Constant>(B)) {
1692 if (UsesRemoved >= 1)
1693 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1694 } else {
1695 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001696 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1697 /*HasNUW=*/true),
1698 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001699 }
1700 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001701 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001702 Cmp.setOperand(0, NewAnd);
1703 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001704 }
1705 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001706 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001707
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001708 return nullptr;
1709}
1710
1711/// Fold icmp (and X, Y), C.
1712Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1713 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001714 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001715 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1716 return I;
1717
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001718 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001719
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001720 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1721 Value *X = And->getOperand(0);
1722 Value *Y = And->getOperand(1);
1723 if (auto *LI = dyn_cast<LoadInst>(X))
1724 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1725 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001726 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001727 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1728 ConstantInt *C2 = cast<ConstantInt>(Y);
1729 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001730 return Res;
1731 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001732
1733 if (!Cmp.isEquality())
1734 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001735
1736 // X & -C == -C -> X > u ~C
1737 // X & -C != -C -> X <= u ~C
1738 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001739 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001740 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1741 : CmpInst::ICMP_ULE;
1742 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1743 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001744
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001745 // (X & C2) == 0 -> (trunc X) >= 0
1746 // (X & C2) != 0 -> (trunc X) < 0
1747 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1748 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001749 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001750 int32_t ExactLogBase2 = C2->exactLogBase2();
1751 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1752 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1753 if (And->getType()->isVectorTy())
1754 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001755 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001756 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1757 : CmpInst::ICMP_SLT;
1758 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001759 }
1760 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001761
Sanjay Patela3f4f082016-08-16 17:54:36 +00001762 return nullptr;
1763}
1764
Sanjay Patel943e92e2016-08-17 16:30:43 +00001765/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001766Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001767 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001768 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001769 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001770 // icmp slt signum(V) 1 --> icmp slt V, 1
1771 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001772 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001773 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1774 ConstantInt::get(V->getType(), 1));
1775 }
1776
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001777 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1);
1778 if (Cmp.isEquality() && Cmp.getOperand(1) == OrOp1) {
1779 // X | C == C --> X <=u C
1780 // X | C != C --> X >u C
1781 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1782 if ((C + 1).isPowerOf2()) {
1783 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1784 return new ICmpInst(Pred, OrOp0, OrOp1);
1785 }
1786 // More general: are all bits outside of a mask constant set or not set?
1787 // X | C == C --> (X & ~C) == 0
1788 // X | C != C --> (X & ~C) != 0
1789 if (Or->hasOneUse()) {
1790 Value *A = Builder.CreateAnd(OrOp0, ~C);
1791 return new ICmpInst(Pred, A, ConstantInt::getNullValue(OrOp0->getType()));
1792 }
Sanjay Patel50c82c42017-04-05 17:57:05 +00001793 }
1794
Craig Topper8ed1aa92017-10-03 05:31:07 +00001795 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001796 return nullptr;
1797
1798 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001799 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001800 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1801 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001802 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001803 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001804 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001805 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001806 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1807 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1808 }
1809
1810 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1811 // a shorter form that has more potential to be folded even further.
1812 Value *X1, *X2, *X3, *X4;
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001813 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1814 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001815 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1816 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1817 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1818 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1819 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1820 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001821 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001822
Sanjay Patela3f4f082016-08-16 17:54:36 +00001823 return nullptr;
1824}
1825
Sanjay Patel63478072016-08-18 15:44:44 +00001826/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001827Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1828 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001829 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001830 const APInt *MulC;
1831 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001832 return nullptr;
1833
Sanjay Patel63478072016-08-18 15:44:44 +00001834 // If this is a test of the sign bit and the multiply is sign-preserving with
1835 // a constant operand, use the multiply LHS operand instead.
1836 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001837 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001838 if (MulC->isNegative())
1839 Pred = ICmpInst::getSwappedPredicate(Pred);
1840 return new ICmpInst(Pred, Mul->getOperand(0),
1841 Constant::getNullValue(Mul->getType()));
1842 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001843
1844 return nullptr;
1845}
1846
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001847/// Fold icmp (shl 1, Y), C.
1848static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001849 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001850 Value *Y;
1851 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1852 return nullptr;
1853
1854 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001855 unsigned TypeBits = C.getBitWidth();
1856 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001857 ICmpInst::Predicate Pred = Cmp.getPredicate();
1858 if (Cmp.isUnsigned()) {
1859 // (1 << Y) pred C -> Y pred Log2(C)
1860 if (!CIsPowerOf2) {
1861 // (1 << Y) < 30 -> Y <= 4
1862 // (1 << Y) <= 30 -> Y <= 4
1863 // (1 << Y) >= 30 -> Y > 4
1864 // (1 << Y) > 30 -> Y > 4
1865 if (Pred == ICmpInst::ICMP_ULT)
1866 Pred = ICmpInst::ICMP_ULE;
1867 else if (Pred == ICmpInst::ICMP_UGE)
1868 Pred = ICmpInst::ICMP_UGT;
1869 }
1870
1871 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1872 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001873 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001874 if (CLog2 == TypeBits - 1) {
1875 if (Pred == ICmpInst::ICMP_UGE)
1876 Pred = ICmpInst::ICMP_EQ;
1877 else if (Pred == ICmpInst::ICMP_ULT)
1878 Pred = ICmpInst::ICMP_NE;
1879 }
1880 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1881 } else if (Cmp.isSigned()) {
1882 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001883 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001884 // (1 << Y) <= -1 -> Y == 31
1885 if (Pred == ICmpInst::ICMP_SLE)
1886 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1887
1888 // (1 << Y) > -1 -> Y != 31
1889 if (Pred == ICmpInst::ICMP_SGT)
1890 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001891 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001892 // (1 << Y) < 0 -> Y == 31
1893 // (1 << Y) <= 0 -> Y == 31
1894 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1895 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1896
1897 // (1 << Y) >= 0 -> Y != 31
1898 // (1 << Y) > 0 -> Y != 31
1899 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1900 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1901 }
1902 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001903 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001904 }
1905
1906 return nullptr;
1907}
1908
Sanjay Patel38b75062016-08-19 17:20:37 +00001909/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001910Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1911 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001912 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001913 const APInt *ShiftVal;
1914 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001915 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001916
Sanjay Patelfa7de602016-08-19 22:33:26 +00001917 const APInt *ShiftAmt;
1918 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001919 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001920
Sanjay Patel38b75062016-08-19 17:20:37 +00001921 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001922 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001923 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001924 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001925 return nullptr;
1926
Sanjay Patele38e79c2016-08-19 17:34:05 +00001927 ICmpInst::Predicate Pred = Cmp.getPredicate();
1928 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001929 Type *ShType = Shl->getType();
1930
Sanjay Patel291c3d82017-01-19 16:12:10 +00001931 // NSW guarantees that we are only shifting out sign bits from the high bits,
1932 // so we can ASHR the compare constant without needing a mask and eliminate
1933 // the shift.
1934 if (Shl->hasNoSignedWrap()) {
1935 if (Pred == ICmpInst::ICMP_SGT) {
1936 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001937 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001938 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1939 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001940 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1941 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001942 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001943 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1944 }
1945 if (Pred == ICmpInst::ICMP_SLT) {
1946 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
1947 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
1948 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
1949 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00001950 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
1951 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00001952 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1953 }
1954 // If this is a signed comparison to 0 and the shift is sign preserving,
1955 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
1956 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001957 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00001958 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
1959 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001960
Sanjay Patel291c3d82017-01-19 16:12:10 +00001961 // NUW guarantees that we are only shifting out zero bits from the high bits,
1962 // so we can LSHR the compare constant without needing a mask and eliminate
1963 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00001964 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00001965 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00001966 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001967 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001968 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1969 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001970 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1971 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001972 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00001973 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1974 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001975 if (Pred == ICmpInst::ICMP_ULT) {
1976 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
1977 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
1978 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
1979 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00001980 assert(C.ugt(0) && "ult 0 should have been eliminated");
1981 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00001982 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1983 }
1984 }
1985
Sanjay Patel291c3d82017-01-19 16:12:10 +00001986 if (Cmp.isEquality() && Shl->hasOneUse()) {
1987 // Strength-reduce the shift into an 'and'.
1988 Constant *Mask = ConstantInt::get(
1989 ShType,
1990 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00001991 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00001992 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00001993 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001994 }
1995
Sanjay Patela3f4f082016-08-16 17:54:36 +00001996 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
1997 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001998 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00001999 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00002000 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00002001 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00002002 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002003 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00002004 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00002005 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00002006 }
2007
Sanjay Patel643d21a2016-08-21 17:10:07 +00002008 // Transform (icmp pred iM (shl iM %v, N), C)
2009 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2010 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002011 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002012 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002013 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002014 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002015 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00002016 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002017 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002018 if (ShType->isVectorTy())
2019 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002020 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00002021 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00002022 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002023 }
2024
2025 return nullptr;
2026}
2027
Sanjay Patela3920492016-08-22 20:45:06 +00002028/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002029Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2030 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002031 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002032 // An exact shr only shifts out zero bits, so:
2033 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002034 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002035 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002036 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00002037 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002038 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002039
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002040 const APInt *ShiftVal;
2041 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002042 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002043
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002044 const APInt *ShiftAmt;
2045 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002046 return nullptr;
2047
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002048 // Check that the shift amount is in range. If not, don't perform undefined
2049 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002050 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002051 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002052 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2053 return nullptr;
2054
Sanjay Pateld64e9882016-08-23 22:05:55 +00002055 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002056 bool IsExact = Shr->isExact();
2057 Type *ShrTy = Shr->getType();
2058 // TODO: If we could guarantee that InstSimplify would handle all of the
2059 // constant-value-based preconditions in the folds below, then we could assert
2060 // those conditions rather than checking them. This is difficult because of
2061 // undef/poison (PR34838).
2062 if (IsAShr) {
2063 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2064 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2065 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2066 APInt ShiftedC = C.shl(ShAmtVal);
2067 if (ShiftedC.ashr(ShAmtVal) == C)
2068 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2069 }
2070 if (Pred == CmpInst::ICMP_SGT) {
2071 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2072 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2073 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2074 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2075 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2076 }
2077 } else {
2078 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2079 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2080 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2081 APInt ShiftedC = C.shl(ShAmtVal);
2082 if (ShiftedC.lshr(ShAmtVal) == C)
2083 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2084 }
2085 if (Pred == CmpInst::ICMP_UGT) {
2086 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2087 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2088 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2089 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2090 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002091 }
2092
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002093 if (!Cmp.isEquality())
2094 return nullptr;
2095
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002096 // Handle equality comparisons of shift-by-constant.
2097
Sanjay Patel8e297742016-08-24 13:55:55 +00002098 // If the comparison constant changes with the shift, the comparison cannot
2099 // succeed (bits of the comparison constant cannot match the shifted value).
2100 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002101 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2102 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002103 "Expected icmp+shr simplify did not occur.");
2104
Sanjay Patel934738a2017-10-15 15:39:15 +00002105 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002106 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002107 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002108 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002109
Sanjay Patel934738a2017-10-15 15:39:15 +00002110 if (Shr->hasOneUse()) {
2111 // Canonicalize the shift into an 'and':
2112 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002113 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002114 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002115 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002116 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002117 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002118
2119 return nullptr;
2120}
2121
Sanjay Patel12a41052016-08-18 17:37:26 +00002122/// Fold icmp (udiv X, Y), C.
2123Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002124 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002125 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002126 const APInt *C2;
2127 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2128 return nullptr;
2129
Craig Topper29c282e2017-06-07 07:40:29 +00002130 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002131
2132 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2133 Value *Y = UDiv->getOperand(1);
2134 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002135 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002136 "icmp ugt X, UINT_MAX should have been simplified already.");
2137 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002138 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002139 }
2140
2141 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2142 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002143 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002144 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002145 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002146 }
2147
2148 return nullptr;
2149}
2150
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002151/// Fold icmp ({su}div X, Y), C.
2152Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2153 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002154 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002155 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002156 // Fold this div into the comparison, producing a range check.
2157 // Determine, based on the divide type, what the range is being
2158 // checked. If there is an overflow on the low or high side, remember
2159 // it, otherwise compute the range [low, hi) bounding the new value.
2160 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002161 const APInt *C2;
2162 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002163 return nullptr;
2164
Sanjay Patel16554142016-08-24 23:03:36 +00002165 // FIXME: If the operand types don't match the type of the divide
2166 // then don't attempt this transform. The code below doesn't have the
2167 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002168 // vice versa). This is because (x /s C2) <s C produces different
2169 // results than (x /s C2) <u C or (x /u C2) <s C or even
2170 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002171 // work. :( The if statement below tests that condition and bails
2172 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002173 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2174 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002175 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002176
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002177 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2178 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2179 // division-by-constant cases should be present, we can not assert that they
2180 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002181 if (C2->isNullValue() || C2->isOneValue() ||
2182 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002183 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002184
Craig Topper6e025a32017-10-01 23:53:54 +00002185 // Compute Prod = C * C2. We are essentially solving an equation of
2186 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002187 // By solving for X, we can turn this into a range check instead of computing
2188 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002189 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002190
Sanjay Patel541aef42016-08-31 21:57:21 +00002191 // Determine if the product overflows by seeing if the product is not equal to
2192 // the divide. Make sure we do the same kind of divide as in the LHS
2193 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002194 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002195
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002196 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002197
2198 // If the division is known to be exact, then there is no remainder from the
2199 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002200 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002201
2202 // Figure out the interval that is being checked. For example, a comparison
2203 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2204 // Compute this interval based on the constants involved and the signedness of
2205 // the compare/divide. This computes a half-open interval, keeping track of
2206 // whether either value in the interval overflows. After analysis each
2207 // overflow variable is set to 0 if it's corresponding bound variable is valid
2208 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2209 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002210 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002211
2212 if (!DivIsSigned) { // udiv
2213 // e.g. X/5 op 3 --> [15, 20)
2214 LoBound = Prod;
2215 HiOverflow = LoOverflow = ProdOV;
2216 if (!HiOverflow) {
2217 // If this is not an exact divide, then many values in the range collapse
2218 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002219 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002220 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002221 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002222 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002223 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002224 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002225 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002226 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002227 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2228 HiOverflow = LoOverflow = ProdOV;
2229 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002230 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002231 } else { // (X / pos) op neg
2232 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002233 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002234 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2235 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002236 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002237 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002238 }
2239 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002240 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002241 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002242 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002243 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002244 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002245 LoBound = RangeSize + 1;
2246 HiBound = -RangeSize;
2247 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002248 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002249 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002250 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002251 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002252 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002253 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002254 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2255 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002256 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002257 } else { // (X / neg) op neg
2258 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2259 LoOverflow = HiOverflow = ProdOV;
2260 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002261 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002262 }
2263
2264 // Dividing by a negative swaps the condition. LT <-> GT
2265 Pred = ICmpInst::getSwappedPredicate(Pred);
2266 }
2267
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002268 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002269 switch (Pred) {
2270 default: llvm_unreachable("Unhandled icmp opcode!");
2271 case ICmpInst::ICMP_EQ:
2272 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002273 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002274 if (HiOverflow)
2275 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002276 ICmpInst::ICMP_UGE, X,
2277 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002278 if (LoOverflow)
2279 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002280 ICmpInst::ICMP_ULT, X,
2281 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002282 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002283 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002284 case ICmpInst::ICMP_NE:
2285 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002286 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002287 if (HiOverflow)
2288 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002289 ICmpInst::ICMP_ULT, X,
2290 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002291 if (LoOverflow)
2292 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002293 ICmpInst::ICMP_UGE, X,
2294 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002295 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002296 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002297 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002298 case ICmpInst::ICMP_ULT:
2299 case ICmpInst::ICMP_SLT:
2300 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002301 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002302 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002303 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002304 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002305 case ICmpInst::ICMP_UGT:
2306 case ICmpInst::ICMP_SGT:
2307 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002308 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002309 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002310 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002311 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002312 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2313 ConstantInt::get(Div->getType(), HiBound));
2314 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2315 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002316 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002317
2318 return nullptr;
2319}
2320
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002321/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002322Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2323 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002324 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002325 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2326 ICmpInst::Predicate Pred = Cmp.getPredicate();
Luqman Aden8911c5b2019-04-04 07:08:30 +00002327 const APInt *C2;
2328 APInt SubResult;
2329
2330 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C)
2331 if (match(X, m_APInt(C2)) &&
2332 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) ||
2333 (Cmp.isSigned() && Sub->hasNoSignedWrap())) &&
2334 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned()))
2335 return new ICmpInst(Cmp.getSwappedPredicate(), Y,
2336 ConstantInt::get(Y->getType(), SubResult));
Sanjay Patel886a5422016-09-15 18:05:17 +00002337
2338 // The following transforms are only worth it if the only user of the subtract
2339 // is the icmp.
2340 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002341 return nullptr;
2342
Sanjay Patel886a5422016-09-15 18:05:17 +00002343 if (Sub->hasNoSignedWrap()) {
2344 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002345 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002346 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002347
Sanjay Patel886a5422016-09-15 18:05:17 +00002348 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002349 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002350 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2351
2352 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002353 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002354 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2355
2356 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002357 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002358 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2359 }
2360
Sanjay Patel886a5422016-09-15 18:05:17 +00002361 if (!match(X, m_APInt(C2)))
2362 return nullptr;
2363
2364 // C2 - Y <u C -> (Y | (C - 1)) == C2
2365 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002366 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2367 (*C2 & (C - 1)) == (C - 1))
2368 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002369
2370 // C2 - Y >u C -> (Y | C) != C2
2371 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002372 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2373 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002374
2375 return nullptr;
2376}
2377
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002378/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002379Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2380 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002381 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002382 Value *Y = Add->getOperand(1);
2383 const APInt *C2;
2384 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002385 return nullptr;
2386
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002387 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002388 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002389 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002390 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002391
Tim Northover12c1f762018-09-10 14:26:44 +00002392 if (!Add->hasOneUse())
2393 return nullptr;
2394
Sanjay Patel45b7e692017-02-12 16:40:30 +00002395 // If the add does not wrap, we can always adjust the compare by subtracting
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002396 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE
2397 // are canonicalized to SGT/SLT/UGT/ULT.
2398 if ((Add->hasNoSignedWrap() &&
2399 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) ||
2400 (Add->hasNoUnsignedWrap() &&
2401 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) {
Sanjay Patel45b7e692017-02-12 16:40:30 +00002402 bool Overflow;
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002403 APInt NewC =
2404 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002405 // If there is overflow, the result must be true or false.
2406 // TODO: Can we assert there is no overflow because InstSimplify always
2407 // handles those cases?
2408 if (!Overflow)
2409 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2410 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2411 }
2412
Craig Topper8ed1aa92017-10-03 05:31:07 +00002413 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002414 const APInt &Upper = CR.getUpper();
2415 const APInt &Lower = CR.getLower();
2416 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002417 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002418 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002419 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002420 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002421 } else {
2422 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002423 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002424 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002425 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002426 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002427
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002428 // X+C <u C2 -> (X & -C2) == C
2429 // iff C & (C2-1) == 0
2430 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002431 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2432 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002433 ConstantExpr::getNeg(cast<Constant>(Y)));
2434
2435 // X+C >u C2 -> (X & ~C2) != C
2436 // iff C & C2 == 0
2437 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002438 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2439 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002440 ConstantExpr::getNeg(cast<Constant>(Y)));
2441
Sanjay Patela3f4f082016-08-16 17:54:36 +00002442 return nullptr;
2443}
2444
Anna Thomasd67165c2017-06-23 13:41:45 +00002445bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2446 Value *&RHS, ConstantInt *&Less,
2447 ConstantInt *&Equal,
2448 ConstantInt *&Greater) {
2449 // TODO: Generalize this to work with other comparison idioms or ensure
2450 // they get canonicalized into this form.
2451
2452 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2453 // Greater), where Equal, Less and Greater are placeholders for any three
2454 // constants.
2455 ICmpInst::Predicate PredA, PredB;
2456 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2457 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2458 PredA == ICmpInst::ICMP_EQ &&
2459 match(SI->getFalseValue(),
2460 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2461 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2462 PredB == ICmpInst::ICMP_SLT) {
2463 return true;
2464 }
2465 return false;
2466}
2467
2468Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002469 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002470 ConstantInt *C) {
2471
2472 assert(C && "Cmp RHS should be a constant int!");
2473 // If we're testing a constant value against the result of a three way
2474 // comparison, the result can be expressed directly in terms of the
2475 // original values being compared. Note: We could possibly be more
2476 // aggressive here and remove the hasOneUse test. The original select is
2477 // really likely to simplify or sink when we remove a test of the result.
2478 Value *OrigLHS, *OrigRHS;
2479 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2480 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002481 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2482 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002483 assert(C1LessThan && C2Equal && C3GreaterThan);
2484
2485 bool TrueWhenLessThan =
2486 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2487 ->isAllOnesValue();
2488 bool TrueWhenEqual =
2489 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2490 ->isAllOnesValue();
2491 bool TrueWhenGreaterThan =
2492 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2493 ->isAllOnesValue();
2494
2495 // This generates the new instruction that will replace the original Cmp
2496 // Instruction. Instead of enumerating the various combinations when
2497 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2498 // false, we rely on chaining of ORs and future passes of InstCombine to
2499 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2500
2501 // When none of the three constants satisfy the predicate for the RHS (C),
2502 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002503 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002504 if (TrueWhenLessThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002505 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT,
2506 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002507 if (TrueWhenEqual)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002508 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ,
2509 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002510 if (TrueWhenGreaterThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002511 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT,
2512 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002513
2514 return replaceInstUsesWith(Cmp, Cond);
2515 }
2516 return nullptr;
2517}
2518
Sanjay Patele7f46c32019-02-07 20:54:09 +00002519static Instruction *foldICmpBitCast(ICmpInst &Cmp,
2520 InstCombiner::BuilderTy &Builder) {
2521 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0));
2522 if (!Bitcast)
2523 return nullptr;
2524
Sanjay Patele7f46c32019-02-07 20:54:09 +00002525 ICmpInst::Predicate Pred = Cmp.getPredicate();
2526 Value *Op1 = Cmp.getOperand(1);
2527 Value *BCSrcOp = Bitcast->getOperand(0);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002528
Sanjay Patel781d8832019-02-07 21:12:01 +00002529 // Make sure the bitcast doesn't change the number of vector elements.
2530 if (Bitcast->getSrcTy()->getScalarSizeInBits() ==
2531 Bitcast->getDestTy()->getScalarSizeInBits()) {
2532 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
2533 Value *X;
2534 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) {
2535 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
2536 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
2537 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
2538 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
2539 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
2540 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
2541 match(Op1, m_Zero()))
2542 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002543
Sanjay Patel781d8832019-02-07 21:12:01 +00002544 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
2545 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
2546 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
2547
2548 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
2549 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
2550 return new ICmpInst(Pred, X,
2551 ConstantInt::getAllOnesValue(X->getType()));
2552 }
2553
2554 // Zero-equality checks are preserved through unsigned floating-point casts:
2555 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
2556 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
2557 if (match(BCSrcOp, m_UIToFP(m_Value(X))))
2558 if (Cmp.isEquality() && match(Op1, m_Zero()))
2559 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002560 }
2561
Sanjay Patele7f46c32019-02-07 20:54:09 +00002562 // Test to see if the operands of the icmp are casted versions of other
2563 // values. If the ptr->ptr cast can be stripped off both arguments, do so.
2564 if (Bitcast->getType()->isPointerTy() &&
2565 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
2566 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
2567 // so eliminate it as well.
2568 if (auto *BC2 = dyn_cast<BitCastInst>(Op1))
2569 Op1 = BC2->getOperand(0);
2570
2571 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType());
2572 return new ICmpInst(Pred, BCSrcOp, Op1);
2573 }
2574
Daniel Neilson901acfa2018-04-03 17:26:20 +00002575 // Folding: icmp <pred> iN X, C
2576 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2577 // and C is a splat of a K-bit pattern
2578 // and SC is a constant vector = <C', C', C', ..., C'>
2579 // Into:
2580 // %E = extractelement <M x iK> %vec, i32 C'
2581 // icmp <pred> iK %E, trunc(C)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002582 const APInt *C;
2583 if (!match(Cmp.getOperand(1), m_APInt(C)) ||
2584 !Bitcast->getType()->isIntegerTy() ||
Daniel Neilson901acfa2018-04-03 17:26:20 +00002585 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2586 return nullptr;
2587
Sanjay Patele7f46c32019-02-07 20:54:09 +00002588 Value *Vec;
2589 Constant *Mask;
2590 if (match(BCSrcOp,
Daniel Neilson901acfa2018-04-03 17:26:20 +00002591 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2592 // Check whether every element of Mask is the same constant
2593 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
Sanjay Patele7f46c32019-02-07 20:54:09 +00002594 auto *VecTy = cast<VectorType>(BCSrcOp->getType());
Daniel Neilson901acfa2018-04-03 17:26:20 +00002595 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
Sanjay Patele7f46c32019-02-07 20:54:09 +00002596 if (C->isSplat(EltTy->getBitWidth())) {
Daniel Neilson901acfa2018-04-03 17:26:20 +00002597 // Fold the icmp based on the value of C
2598 // If C is M copies of an iK sized bit pattern,
2599 // then:
2600 // => %E = extractelement <N x iK> %vec, i32 Elem
2601 // icmp <pred> iK %SplatVal, <pattern>
2602 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002603 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth()));
Daniel Neilson901acfa2018-04-03 17:26:20 +00002604 return new ICmpInst(Pred, Extract, NewC);
2605 }
2606 }
2607 }
2608 return nullptr;
2609}
2610
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002611/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2612/// where X is some kind of instruction.
2613Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002614 const APInt *C;
2615 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002616 return nullptr;
2617
Craig Toppera94069f2017-08-23 05:46:08 +00002618 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002619 switch (BO->getOpcode()) {
2620 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002621 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002622 return I;
2623 break;
2624 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002625 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002626 return I;
2627 break;
2628 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002629 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002630 return I;
2631 break;
2632 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002633 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002634 return I;
2635 break;
2636 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002637 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002638 return I;
2639 break;
2640 case Instruction::LShr:
2641 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002642 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002643 return I;
2644 break;
2645 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002646 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002647 return I;
2648 LLVM_FALLTHROUGH;
2649 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002650 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002651 return I;
2652 break;
2653 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002654 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002655 return I;
2656 break;
2657 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002658 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002659 return I;
2660 break;
2661 default:
2662 break;
2663 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002664 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002665 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002666 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002667 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002668
Anna Thomasd67165c2017-06-23 13:41:45 +00002669 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002670
2671 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2672 // For now, we only support constant integers while folding the
2673 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2674 // similar to the cases handled by binary ops above.
2675 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2676 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002677 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002678 }
2679
2680 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002681 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002682 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002683 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002684
Nikita Popov6515db22019-01-19 09:56:01 +00002685 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0)))
2686 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C))
2687 return I;
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002688
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002689 return nullptr;
2690}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002691
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002692/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2693/// icmp eq/ne BO, C.
2694Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2695 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002696 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002697 // TODO: Some of these folds could work with arbitrary constants, but this
2698 // function is limited to scalar and vector splat constants.
2699 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002700 return nullptr;
2701
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002702 ICmpInst::Predicate Pred = Cmp.getPredicate();
2703 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2704 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002705 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002706
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002707 switch (BO->getOpcode()) {
2708 case Instruction::SRem:
2709 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002710 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002711 const APInt *BOC;
2712 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002713 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002714 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002715 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002716 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002717 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002718 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002719 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002720 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002721 const APInt *BOC;
2722 if (match(BOp1, m_APInt(BOC))) {
2723 if (BO->hasOneUse()) {
2724 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002725 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002726 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002727 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002728 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2729 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002730 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002731 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002732 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002733 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002734 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002735 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002736 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002737 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002738 }
2739 }
2740 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002741 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002742 case Instruction::Xor:
2743 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002744 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002745 // For the xor case, we can xor two constants together, eliminating
2746 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002747 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002748 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002749 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002750 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002751 }
2752 }
2753 break;
2754 case Instruction::Sub:
2755 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002756 const APInt *BOC;
2757 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002758 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002759 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002760 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002761 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002762 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002763 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002764 }
2765 }
2766 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002767 case Instruction::Or: {
2768 const APInt *BOC;
2769 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002770 // Comparing if all bits outside of a constant mask are set?
2771 // Replace (X | C) == -1 with (X & ~C) == ~C.
2772 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002773 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002774 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002775 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002776 }
2777 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002778 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002779 case Instruction::And: {
2780 const APInt *BOC;
2781 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002782 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002783 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002784 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002785 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002786
2787 // Don't perform the following transforms if the AND has multiple uses
2788 if (!BO->hasOneUse())
2789 break;
2790
2791 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0
Craig Topperbcfd2d12017-04-20 16:56:25 +00002792 if (BOC->isSignMask()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002793 Constant *Zero = Constant::getNullValue(BOp0->getType());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002794 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
2795 return new ICmpInst(NewPred, BOp0, Zero);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002796 }
2797
2798 // ((X & ~7) == 0) --> X < 8
Craig Topper8ed1aa92017-10-03 05:31:07 +00002799 if (C.isNullValue() && (~(*BOC) + 1).isPowerOf2()) {
Sanjay Pateld938e882016-08-04 20:05:02 +00002800 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002801 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
2802 return new ICmpInst(NewPred, BOp0, NegBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002803 }
2804 }
2805 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002806 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002807 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002808 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002809 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002810 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002811 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002812 // General case : (mul X, C) != 0 iff X != 0
2813 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002814 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002815 }
2816 }
2817 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002818 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002819 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002820 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002821 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2822 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002823 }
2824 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002825 default:
2826 break;
2827 }
2828 return nullptr;
2829}
2830
Nikita Popov6515db22019-01-19 09:56:01 +00002831/// Fold an equality icmp with LLVM intrinsic and constant operand.
2832Instruction *InstCombiner::foldICmpEqIntrinsicWithConstant(ICmpInst &Cmp,
2833 IntrinsicInst *II,
2834 const APInt &C) {
Sanjay Patelb51e0722017-07-02 16:05:11 +00002835 Type *Ty = II->getType();
Nikita Popov20853a72018-12-18 19:59:50 +00002836 unsigned BitWidth = C.getBitWidth();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002837 switch (II->getIntrinsicID()) {
2838 case Intrinsic::bswap:
2839 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002840 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002841 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002842 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002843
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002844 case Intrinsic::ctlz:
Nikita Popov20853a72018-12-18 19:59:50 +00002845 case Intrinsic::cttz: {
Amaury Sechet6bea6742016-08-04 05:27:20 +00002846 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Nikita Popov20853a72018-12-18 19:59:50 +00002847 if (C == BitWidth) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002848 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002849 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002850 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002851 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002852 }
Nikita Popov20853a72018-12-18 19:59:50 +00002853
2854 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set
2855 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits.
2856 // Limit to one use to ensure we don't increase instruction count.
2857 unsigned Num = C.getLimitedValue(BitWidth);
2858 if (Num != BitWidth && II->hasOneUse()) {
2859 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz;
2860 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1)
2861 : APInt::getHighBitsSet(BitWidth, Num + 1);
2862 APInt Mask2 = IsTrailing
2863 ? APInt::getOneBitSet(BitWidth, Num)
2864 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
2865 Cmp.setOperand(0, Builder.CreateAnd(II->getArgOperand(0), Mask1));
2866 Cmp.setOperand(1, ConstantInt::get(Ty, Mask2));
2867 Worklist.Add(II);
2868 return &Cmp;
2869 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002870 break;
Nikita Popov20853a72018-12-18 19:59:50 +00002871 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002872
Amaury Sechet6bea6742016-08-04 05:27:20 +00002873 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002874 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002875 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002876 bool IsZero = C.isNullValue();
Nikita Popov20853a72018-12-18 19:59:50 +00002877 if (IsZero || C == BitWidth) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002878 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002879 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002880 auto *NewOp =
2881 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002882 Cmp.setOperand(1, NewOp);
2883 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002884 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002885 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002886 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002887 default:
2888 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002889 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002890
Craig Topperf40110f2014-04-25 05:29:35 +00002891 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002892}
2893
Nikita Popov6515db22019-01-19 09:56:01 +00002894/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2895Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
2896 IntrinsicInst *II,
2897 const APInt &C) {
2898 if (Cmp.isEquality())
2899 return foldICmpEqIntrinsicWithConstant(Cmp, II, C);
2900
2901 Type *Ty = II->getType();
2902 unsigned BitWidth = C.getBitWidth();
2903 switch (II->getIntrinsicID()) {
2904 case Intrinsic::ctlz: {
2905 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000
2906 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
2907 unsigned Num = C.getLimitedValue();
2908 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
2909 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT,
2910 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
2911 }
2912
2913 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111
2914 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
2915 C.uge(1) && C.ule(BitWidth)) {
2916 unsigned Num = C.getLimitedValue();
2917 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num);
2918 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT,
2919 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
2920 }
2921 break;
2922 }
2923 case Intrinsic::cttz: {
2924 // Limit to one use to ensure we don't increase instruction count.
2925 if (!II->hasOneUse())
2926 return nullptr;
2927
2928 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0
2929 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
2930 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1);
2931 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ,
2932 Builder.CreateAnd(II->getArgOperand(0), Mask),
2933 ConstantInt::getNullValue(Ty));
2934 }
2935
2936 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0
2937 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
2938 C.uge(1) && C.ule(BitWidth)) {
2939 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue());
2940 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE,
2941 Builder.CreateAnd(II->getArgOperand(0), Mask),
2942 ConstantInt::getNullValue(Ty));
2943 }
2944 break;
2945 }
2946 default:
2947 break;
2948 }
2949
2950 return nullptr;
2951}
2952
Sanjay Patel10494b22016-09-16 16:10:22 +00002953/// Handle icmp with constant (but not simple integer constant) RHS.
2954Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
2955 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2956 Constant *RHSC = dyn_cast<Constant>(Op1);
2957 Instruction *LHSI = dyn_cast<Instruction>(Op0);
2958 if (!RHSC || !LHSI)
2959 return nullptr;
2960
2961 switch (LHSI->getOpcode()) {
2962 case Instruction::GetElementPtr:
2963 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
2964 if (RHSC->isNullValue() &&
2965 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
2966 return new ICmpInst(
2967 I.getPredicate(), LHSI->getOperand(0),
2968 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2969 break;
2970 case Instruction::PHI:
2971 // Only fold icmp into the PHI if the phi and icmp are in the same
2972 // block. If in the same block, we're encouraging jump threading. If
2973 // not, we are just pessimizing the code by making an i1 phi.
2974 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00002975 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00002976 return NV;
2977 break;
2978 case Instruction::Select: {
2979 // If either operand of the select is a constant, we can fold the
2980 // comparison into the select arms, which will cause one to be
2981 // constant folded and the select turned into a bitwise or.
2982 Value *Op1 = nullptr, *Op2 = nullptr;
2983 ConstantInt *CI = nullptr;
2984 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
2985 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2986 CI = dyn_cast<ConstantInt>(Op1);
2987 }
2988 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
2989 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2990 CI = dyn_cast<ConstantInt>(Op2);
2991 }
2992
2993 // We only want to perform this transformation if it will not lead to
2994 // additional code. This is true if either both sides of the select
2995 // fold to a constant (in which case the icmp is replaced with a select
2996 // which will usually simplify) or this is the only user of the
2997 // select (in which case we are trading a select+icmp for a simpler
2998 // select+icmp) or all uses of the select can be replaced based on
2999 // dominance information ("Global cases").
3000 bool Transform = false;
3001 if (Op1 && Op2)
3002 Transform = true;
3003 else if (Op1 || Op2) {
3004 // Local case
3005 if (LHSI->hasOneUse())
3006 Transform = true;
3007 // Global cases
3008 else if (CI && !CI->isZero())
3009 // When Op1 is constant try replacing select with second operand.
3010 // Otherwise Op2 is constant and try replacing select with first
3011 // operand.
3012 Transform =
3013 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
3014 }
3015 if (Transform) {
3016 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00003017 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
3018 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003019 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00003020 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
3021 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003022 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
3023 }
3024 break;
3025 }
3026 case Instruction::IntToPtr:
3027 // icmp pred inttoptr(X), null -> icmp pred X, 0
3028 if (RHSC->isNullValue() &&
3029 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
3030 return new ICmpInst(
3031 I.getPredicate(), LHSI->getOperand(0),
3032 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3033 break;
3034
3035 case Instruction::Load:
3036 // Try to optimize things like "A[i] > 4" to index computations.
3037 if (GetElementPtrInst *GEP =
3038 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
3039 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
3040 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
3041 !cast<LoadInst>(LHSI)->isVolatile())
3042 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
3043 return Res;
3044 }
3045 break;
3046 }
3047
3048 return nullptr;
3049}
3050
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003051/// Some comparisons can be simplified.
3052/// In this case, we are looking for comparisons that look like
3053/// a check for a lossy truncation.
3054/// Folds:
Roman Lebedev183a4652018-09-19 13:35:27 +00003055/// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask
3056/// Where Mask is some pattern that produces all-ones in low bits:
3057/// (-1 >> y)
Roman Lebedevf50023d2018-09-19 13:35:46 +00003058/// ((-1 << y) >> y) <- non-canonical, has extra uses
Roman Lebedev183a4652018-09-19 13:35:27 +00003059/// ~(-1 << y)
Roman Lebedevca2bdb02018-09-19 13:35:40 +00003060/// ((1 << y) + (-1)) <- non-canonical, has extra uses
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003061/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003062/// For some predicates, the operands are commutative.
3063/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003064static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
3065 InstCombiner::BuilderTy &Builder) {
3066 ICmpInst::Predicate SrcPred;
Roman Lebedevf50023d2018-09-19 13:35:46 +00003067 Value *X, *M, *Y;
3068 auto m_VariableMask = m_CombineOr(
3069 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())),
3070 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())),
3071 m_CombineOr(m_LShr(m_AllOnes(), m_Value()),
3072 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y))));
Roman Lebedev183a4652018-09-19 13:35:27 +00003073 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask());
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003074 if (!match(&I, m_c_ICmp(SrcPred,
3075 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
3076 m_Deferred(X))))
3077 return nullptr;
3078
3079 ICmpInst::Predicate DstPred;
3080 switch (SrcPred) {
3081 case ICmpInst::Predicate::ICMP_EQ:
3082 // x & (-1 >> y) == x -> x u<= (-1 >> y)
3083 DstPred = ICmpInst::Predicate::ICMP_ULE;
3084 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00003085 case ICmpInst::Predicate::ICMP_NE:
3086 // x & (-1 >> y) != x -> x u> (-1 >> y)
3087 DstPred = ICmpInst::Predicate::ICMP_UGT;
3088 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00003089 case ICmpInst::Predicate::ICMP_UGT:
3090 // x u> x & (-1 >> y) -> x u> (-1 >> y)
3091 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3092 DstPred = ICmpInst::Predicate::ICMP_UGT;
3093 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00003094 case ICmpInst::Predicate::ICMP_UGE:
3095 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
3096 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3097 DstPred = ICmpInst::Predicate::ICMP_ULE;
3098 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00003099 case ICmpInst::Predicate::ICMP_ULT:
3100 // x & (-1 >> y) u< x -> x u> (-1 >> y)
3101 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3102 DstPred = ICmpInst::Predicate::ICMP_UGT;
3103 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00003104 case ICmpInst::Predicate::ICMP_ULE:
3105 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
3106 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3107 DstPred = ICmpInst::Predicate::ICMP_ULE;
3108 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003109 case ICmpInst::Predicate::ICMP_SGT:
3110 // x s> x & (-1 >> y) -> x s> (-1 >> y)
3111 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3112 return nullptr; // Ignore the other case.
3113 DstPred = ICmpInst::Predicate::ICMP_SGT;
3114 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00003115 case ICmpInst::Predicate::ICMP_SGE:
3116 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
3117 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3118 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003119 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3120 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003121 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3122 return nullptr;
Roman Lebedevf1442612018-07-14 20:08:37 +00003123 DstPred = ICmpInst::Predicate::ICMP_SLE;
3124 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003125 case ICmpInst::Predicate::ICMP_SLT:
3126 // x & (-1 >> y) s< x -> x s> (-1 >> y)
3127 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3128 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003129 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3130 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003131 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3132 return nullptr;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003133 DstPred = ICmpInst::Predicate::ICMP_SGT;
3134 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003135 case ICmpInst::Predicate::ICMP_SLE:
3136 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
3137 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3138 return nullptr; // Ignore the other case.
3139 DstPred = ICmpInst::Predicate::ICMP_SLE;
3140 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003141 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003142 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003143 }
3144
3145 return Builder.CreateICmp(DstPred, X, M);
3146}
3147
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003148/// Some comparisons can be simplified.
3149/// In this case, we are looking for comparisons that look like
3150/// a check for a lossy signed truncation.
3151/// Folds: (MaskedBits is a constant.)
3152/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
3153/// Into:
3154/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
3155/// Where KeptBits = bitwidth(%x) - MaskedBits
3156static Value *
3157foldICmpWithTruncSignExtendedVal(ICmpInst &I,
3158 InstCombiner::BuilderTy &Builder) {
3159 ICmpInst::Predicate SrcPred;
3160 Value *X;
3161 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
3162 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
3163 if (!match(&I, m_c_ICmp(SrcPred,
3164 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
3165 m_APInt(C1))),
3166 m_Deferred(X))))
3167 return nullptr;
3168
3169 // Potential handling of non-splats: for each element:
3170 // * if both are undef, replace with constant 0.
3171 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
3172 // * if both are not undef, and are different, bailout.
3173 // * else, only one is undef, then pick the non-undef one.
3174
3175 // The shift amount must be equal.
3176 if (*C0 != *C1)
3177 return nullptr;
3178 const APInt &MaskedBits = *C0;
3179 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
3180
3181 ICmpInst::Predicate DstPred;
3182 switch (SrcPred) {
3183 case ICmpInst::Predicate::ICMP_EQ:
3184 // ((%x << MaskedBits) a>> MaskedBits) == %x
3185 // =>
3186 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
3187 DstPred = ICmpInst::Predicate::ICMP_ULT;
3188 break;
3189 case ICmpInst::Predicate::ICMP_NE:
3190 // ((%x << MaskedBits) a>> MaskedBits) != %x
3191 // =>
3192 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
3193 DstPred = ICmpInst::Predicate::ICMP_UGE;
3194 break;
3195 // FIXME: are more folds possible?
3196 default:
3197 return nullptr;
3198 }
3199
3200 auto *XType = X->getType();
3201 const unsigned XBitWidth = XType->getScalarSizeInBits();
3202 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3203 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3204
3205 // KeptBits = bitwidth(%x) - MaskedBits
3206 const APInt KeptBits = BitWidth - MaskedBits;
3207 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3208 // ICmpCst = (1 << KeptBits)
3209 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3210 assert(ICmpCst.isPowerOf2());
3211 // AddCst = (1 << (KeptBits-1))
3212 const APInt AddCst = ICmpCst.lshr(1);
3213 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3214
3215 // T0 = add %x, AddCst
3216 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3217 // T1 = T0 DstPred ICmpCst
3218 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3219
3220 return T1;
3221}
3222
Sanjay Patel10494b22016-09-16 16:10:22 +00003223/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003224/// TODO: A large part of this logic is duplicated in InstSimplify's
3225/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3226/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00003227Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
3228 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3229
3230 // Special logic for binary operators.
3231 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3232 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3233 if (!BO0 && !BO1)
3234 return nullptr;
3235
Sanjay Patel2a062632017-05-08 16:33:42 +00003236 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel1cf07342018-09-11 22:40:20 +00003237 Value *X;
3238
3239 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare.
3240 // (Op1 + X) <u Op1 --> ~Op1 <u X
3241 // Op0 >u (Op0 + X) --> X >u ~Op0
3242 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) &&
3243 Pred == ICmpInst::ICMP_ULT)
3244 return new ICmpInst(Pred, Builder.CreateNot(Op1), X);
3245 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) &&
3246 Pred == ICmpInst::ICMP_UGT)
3247 return new ICmpInst(Pred, X, Builder.CreateNot(Op0));
3248
Sanjay Patel10494b22016-09-16 16:10:22 +00003249 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3250 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3251 NoOp0WrapProblem =
3252 ICmpInst::isEquality(Pred) ||
3253 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3254 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3255 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3256 NoOp1WrapProblem =
3257 ICmpInst::isEquality(Pred) ||
3258 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3259 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3260
3261 // Analyze the case when either Op0 or Op1 is an add instruction.
3262 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3263 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3264 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3265 A = BO0->getOperand(0);
3266 B = BO0->getOperand(1);
3267 }
3268 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3269 C = BO1->getOperand(0);
3270 D = BO1->getOperand(1);
3271 }
3272
Sanjay Patel10494b22016-09-16 16:10:22 +00003273 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
3274 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3275 return new ICmpInst(Pred, A == Op1 ? B : A,
3276 Constant::getNullValue(Op1->getType()));
3277
3278 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
3279 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3280 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3281 C == Op0 ? D : C);
3282
3283 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
3284 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
3285 NoOp1WrapProblem &&
3286 // Try not to increase register pressure.
3287 BO0->hasOneUse() && BO1->hasOneUse()) {
3288 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3289 Value *Y, *Z;
3290 if (A == C) {
3291 // C + B == C + D -> B == D
3292 Y = B;
3293 Z = D;
3294 } else if (A == D) {
3295 // D + B == C + D -> B == C
3296 Y = B;
3297 Z = C;
3298 } else if (B == C) {
3299 // A + C == C + D -> A == D
3300 Y = A;
3301 Z = D;
3302 } else {
3303 assert(B == D);
3304 // A + D == C + D -> A == C
3305 Y = A;
3306 Z = C;
3307 }
3308 return new ICmpInst(Pred, Y, Z);
3309 }
3310
3311 // icmp slt (X + -1), Y -> icmp sle X, Y
3312 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3313 match(B, m_AllOnes()))
3314 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3315
3316 // icmp sge (X + -1), Y -> icmp sgt X, Y
3317 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3318 match(B, m_AllOnes()))
3319 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3320
3321 // icmp sle (X + 1), Y -> icmp slt X, Y
3322 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3323 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3324
3325 // icmp sgt (X + 1), Y -> icmp sge X, Y
3326 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3327 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3328
3329 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3330 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3331 match(D, m_AllOnes()))
3332 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3333
3334 // icmp sle X, (Y + -1) -> icmp slt X, Y
3335 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3336 match(D, m_AllOnes()))
3337 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3338
3339 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3340 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3341 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3342
3343 // icmp slt X, (Y + 1) -> icmp sle X, Y
3344 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3345 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3346
Sanjay Patel40f40172017-01-13 23:25:46 +00003347 // TODO: The subtraction-related identities shown below also hold, but
3348 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3349 // wouldn't happen even if they were implemented.
3350 //
3351 // icmp ult (X - 1), Y -> icmp ule X, Y
3352 // icmp uge (X - 1), Y -> icmp ugt X, Y
3353 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3354 // icmp ule X, (Y - 1) -> icmp ult X, Y
3355
3356 // icmp ule (X + 1), Y -> icmp ult X, Y
3357 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3358 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3359
3360 // icmp ugt (X + 1), Y -> icmp uge X, Y
3361 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3362 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3363
3364 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3365 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3366 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3367
3368 // icmp ult X, (Y + 1) -> icmp ule X, Y
3369 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3370 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3371
Sanjay Patel10494b22016-09-16 16:10:22 +00003372 // if C1 has greater magnitude than C2:
3373 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3374 // s.t. C3 = C1 - C2
3375 //
3376 // if C2 has greater magnitude than C1:
3377 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3378 // s.t. C3 = C2 - C1
3379 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3380 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3381 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3382 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3383 const APInt &AP1 = C1->getValue();
3384 const APInt &AP2 = C2->getValue();
3385 if (AP1.isNegative() == AP2.isNegative()) {
3386 APInt AP1Abs = C1->getValue().abs();
3387 APInt AP2Abs = C2->getValue().abs();
3388 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003389 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3390 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003391 return new ICmpInst(Pred, NewAdd, C);
3392 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003393 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3394 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003395 return new ICmpInst(Pred, A, NewAdd);
3396 }
3397 }
3398 }
3399
3400 // Analyze the case when either Op0 or Op1 is a sub instruction.
3401 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3402 A = nullptr;
3403 B = nullptr;
3404 C = nullptr;
3405 D = nullptr;
3406 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3407 A = BO0->getOperand(0);
3408 B = BO0->getOperand(1);
3409 }
3410 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3411 C = BO1->getOperand(0);
3412 D = BO1->getOperand(1);
3413 }
3414
3415 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3416 if (A == Op1 && NoOp0WrapProblem)
3417 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003418 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3419 if (C == Op0 && NoOp1WrapProblem)
3420 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3421
Sanjay Patelcbb04502018-04-02 20:37:40 +00003422 // (A - B) >u A --> A <u B
3423 if (A == Op1 && Pred == ICmpInst::ICMP_UGT)
3424 return new ICmpInst(ICmpInst::ICMP_ULT, A, B);
3425 // C <u (C - D) --> C <u D
3426 if (C == Op0 && Pred == ICmpInst::ICMP_ULT)
3427 return new ICmpInst(ICmpInst::ICMP_ULT, C, D);
3428
Sanjay Patel10494b22016-09-16 16:10:22 +00003429 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3430 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3431 // Try not to increase register pressure.
3432 BO0->hasOneUse() && BO1->hasOneUse())
3433 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003434 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3435 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3436 // Try not to increase register pressure.
3437 BO0->hasOneUse() && BO1->hasOneUse())
3438 return new ICmpInst(Pred, D, B);
3439
3440 // icmp (0-X) < cst --> x > -cst
3441 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3442 Value *X;
3443 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003444 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3445 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003446 return new ICmpInst(I.getSwappedPredicate(), X,
3447 ConstantExpr::getNeg(RHSC));
3448 }
3449
3450 BinaryOperator *SRem = nullptr;
3451 // icmp (srem X, Y), Y
3452 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3453 SRem = BO0;
3454 // icmp Y, (srem X, Y)
3455 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3456 Op0 == BO1->getOperand(1))
3457 SRem = BO1;
3458 if (SRem) {
3459 // We don't check hasOneUse to avoid increasing register pressure because
3460 // the value we use is the same value this instruction was already using.
3461 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3462 default:
3463 break;
3464 case ICmpInst::ICMP_EQ:
3465 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3466 case ICmpInst::ICMP_NE:
3467 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3468 case ICmpInst::ICMP_SGT:
3469 case ICmpInst::ICMP_SGE:
3470 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3471 Constant::getAllOnesValue(SRem->getType()));
3472 case ICmpInst::ICMP_SLT:
3473 case ICmpInst::ICMP_SLE:
3474 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3475 Constant::getNullValue(SRem->getType()));
3476 }
3477 }
3478
3479 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3480 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3481 switch (BO0->getOpcode()) {
3482 default:
3483 break;
3484 case Instruction::Add:
3485 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003486 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003487 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003488 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003489
3490 const APInt *C;
3491 if (match(BO0->getOperand(1), m_APInt(C))) {
3492 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3493 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003494 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003495 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003496 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003497 }
3498
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003499 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3500 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003501 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003502 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003503 NewPred = I.getSwappedPredicate(NewPred);
3504 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003505 }
3506 }
3507 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003508 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003509 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003510 if (!I.isEquality())
3511 break;
3512
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003513 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003514 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3515 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003516 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3517 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003518 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003519 Constant *Mask = ConstantInt::get(
3520 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003521 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003522 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3523 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003524 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003525 }
Sanjay Patel51506122017-05-25 14:13:57 +00003526 // If there are no trailing zeros in the multiplier, just eliminate
3527 // the multiplies (no masking is needed):
3528 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3529 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003530 }
3531 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003532 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003533 case Instruction::UDiv:
3534 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003535 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003536 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003537 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3538
Sanjay Patel10494b22016-09-16 16:10:22 +00003539 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003540 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3541 break;
3542 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3543
Sanjay Patel10494b22016-09-16 16:10:22 +00003544 case Instruction::AShr:
3545 if (!BO0->isExact() || !BO1->isExact())
3546 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003547 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003548
Sanjay Patel10494b22016-09-16 16:10:22 +00003549 case Instruction::Shl: {
3550 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3551 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3552 if (!NUW && !NSW)
3553 break;
3554 if (!NSW && I.isSigned())
3555 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003556 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003557 }
3558 }
3559 }
3560
3561 if (BO0) {
3562 // Transform A & (L - 1) `ult` L --> L != 0
3563 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003564 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003565
Sanjay Patel2a062632017-05-08 16:33:42 +00003566 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003567 auto *Zero = Constant::getNullValue(BO0->getType());
3568 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3569 }
3570 }
3571
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003572 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3573 return replaceInstUsesWith(I, V);
3574
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003575 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
3576 return replaceInstUsesWith(I, V);
3577
Sanjay Patel10494b22016-09-16 16:10:22 +00003578 return nullptr;
3579}
3580
Sanjay Pateldd46b522016-12-19 17:32:37 +00003581/// Fold icmp Pred min|max(X, Y), X.
3582static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003583 ICmpInst::Predicate Pred = Cmp.getPredicate();
3584 Value *Op0 = Cmp.getOperand(0);
3585 Value *X = Cmp.getOperand(1);
3586
Sanjay Pateldd46b522016-12-19 17:32:37 +00003587 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003588 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003589 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3590 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3591 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003592 std::swap(Op0, X);
3593 Pred = Cmp.getSwappedPredicate();
3594 }
3595
3596 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003597 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003598 // smin(X, Y) == X --> X s<= Y
3599 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003600 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3601 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3602
Sanjay Pateldd46b522016-12-19 17:32:37 +00003603 // smin(X, Y) != X --> X s> Y
3604 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003605 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3606 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3607
3608 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003609 // smin(X, Y) s<= X --> true
3610 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003611 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003612 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003613
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003614 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003615 // smax(X, Y) == X --> X s>= Y
3616 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003617 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3618 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003619
Sanjay Pateldd46b522016-12-19 17:32:37 +00003620 // smax(X, Y) != X --> X s< Y
3621 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003622 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3623 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003624
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003625 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003626 // smax(X, Y) s>= X --> true
3627 // smax(X, Y) s< X --> false
3628 return nullptr;
3629 }
3630
3631 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3632 // umin(X, Y) == X --> X u<= Y
3633 // umin(X, Y) u>= X --> X u<= Y
3634 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3635 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3636
3637 // umin(X, Y) != X --> X u> Y
3638 // umin(X, Y) u< X --> X u> Y
3639 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3640 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3641
3642 // These cases should be handled in InstSimplify:
3643 // umin(X, Y) u<= X --> true
3644 // umin(X, Y) u> X --> false
3645 return nullptr;
3646 }
3647
3648 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3649 // umax(X, Y) == X --> X u>= Y
3650 // umax(X, Y) u<= X --> X u>= Y
3651 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3652 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3653
3654 // umax(X, Y) != X --> X u< Y
3655 // umax(X, Y) u> X --> X u< Y
3656 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3657 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3658
3659 // These cases should be handled in InstSimplify:
3660 // umax(X, Y) u>= X --> true
3661 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003662 return nullptr;
3663 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003664
Sanjay Pateld6406412016-12-15 19:13:37 +00003665 return nullptr;
3666}
3667
Sanjay Patel10494b22016-09-16 16:10:22 +00003668Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3669 if (!I.isEquality())
3670 return nullptr;
3671
3672 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003673 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003674 Value *A, *B, *C, *D;
3675 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3676 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3677 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003678 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003679 }
3680
3681 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3682 // A^c1 == C^c2 --> A == C^(c1^c2)
3683 ConstantInt *C1, *C2;
3684 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3685 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003686 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3687 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003688 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003689 }
3690
3691 // A^B == A^D -> B == D
3692 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003693 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003694 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003695 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003696 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003697 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003698 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003699 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003700 }
3701 }
3702
3703 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3704 // A == (A^B) -> B == 0
3705 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003706 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003707 }
3708
3709 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3710 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3711 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3712 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3713
3714 if (A == C) {
3715 X = B;
3716 Y = D;
3717 Z = A;
3718 } else if (A == D) {
3719 X = B;
3720 Y = C;
3721 Z = A;
3722 } else if (B == C) {
3723 X = A;
3724 Y = D;
3725 Z = B;
3726 } else if (B == D) {
3727 X = A;
3728 Y = C;
3729 Z = B;
3730 }
3731
3732 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003733 Op1 = Builder.CreateXor(X, Y);
3734 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003735 I.setOperand(0, Op1);
3736 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3737 return &I;
3738 }
3739 }
3740
3741 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3742 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3743 ConstantInt *Cst1;
3744 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3745 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3746 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3747 match(Op1, m_ZExt(m_Value(A))))) {
3748 APInt Pow2 = Cst1->getValue() + 1;
3749 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3750 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003751 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003752 }
3753
3754 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3755 // For lshr and ashr pairs.
3756 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3757 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3758 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3759 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3760 unsigned TypeBits = Cst1->getBitWidth();
3761 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3762 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003763 ICmpInst::Predicate NewPred =
3764 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003765 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003766 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003767 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003768 }
3769 }
3770
3771 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3772 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3773 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3774 unsigned TypeBits = Cst1->getBitWidth();
3775 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3776 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003777 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003778 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003779 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003780 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003781 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003782 }
3783 }
3784
3785 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3786 // "icmp (and X, mask), cst"
3787 uint64_t ShAmt = 0;
3788 if (Op0->hasOneUse() &&
3789 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3790 match(Op1, m_ConstantInt(Cst1)) &&
3791 // Only do this when A has multiple uses. This is most important to do
3792 // when it exposes other optimizations.
3793 !A->hasOneUse()) {
3794 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3795
3796 if (ShAmt < ASize) {
3797 APInt MaskV =
3798 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3799 MaskV <<= ShAmt;
3800
3801 APInt CmpV = Cst1->getValue().zext(ASize);
3802 CmpV <<= ShAmt;
3803
Craig Topperbb4069e2017-07-07 23:16:26 +00003804 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
3805 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00003806 }
3807 }
3808
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003809 // If both operands are byte-swapped or bit-reversed, just compare the
3810 // original values.
3811 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
3812 // and handle more intrinsics.
3813 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00003814 (match(Op0, m_BitReverse(m_Value(A))) &&
3815 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003816 return new ICmpInst(Pred, A, B);
3817
Sanjay Patel10494b22016-09-16 16:10:22 +00003818 return nullptr;
3819}
3820
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003821/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3822/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003823Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003824 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003825 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003826 Type *SrcTy = LHSCIOp->getType();
3827 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003828
Jim Grosbach129c52a2011-09-30 18:09:53 +00003829 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003830 // integer type is the same size as the pointer type.
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003831 const auto& CompatibleSizes = [&](Type* SrcTy, Type* DestTy) -> bool {
3832 if (isa<VectorType>(SrcTy)) {
3833 SrcTy = cast<VectorType>(SrcTy)->getElementType();
3834 DestTy = cast<VectorType>(DestTy)->getElementType();
3835 }
3836 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
3837 };
Mehdi Aminia28d91d2015-03-10 02:37:25 +00003838 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003839 CompatibleSizes(SrcTy, DestTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +00003840 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003841 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00003842 Value *RHSCIOp = RHSC->getOperand(0);
3843 if (RHSCIOp->getType()->getPointerAddressSpace() ==
3844 LHSCIOp->getType()->getPointerAddressSpace()) {
3845 RHSOp = RHSC->getOperand(0);
3846 // If the pointer types don't match, insert a bitcast.
3847 if (LHSCIOp->getType() != RHSOp->getType())
Craig Topperbb4069e2017-07-07 23:16:26 +00003848 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType());
Michael Liaod266b922015-02-13 04:51:26 +00003849 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003850 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003851 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003852 }
Chris Lattner2188e402010-01-04 07:37:31 +00003853
3854 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003855 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003856 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003857
Chris Lattner2188e402010-01-04 07:37:31 +00003858 // The code below only handles extension cast instructions, so far.
3859 // Enforce this.
3860 if (LHSCI->getOpcode() != Instruction::ZExt &&
3861 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00003862 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003863
3864 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003865 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00003866
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003867 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003868 // Not an extension from the same type?
Simon Pilgrim7a2e8552019-05-05 10:27:45 +00003869 Value *RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003870 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00003871 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00003872
Chris Lattner2188e402010-01-04 07:37:31 +00003873 // If the signedness of the two casts doesn't agree (i.e. one is a sext
3874 // and the other is a zext), then we can't handle this.
3875 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00003876 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003877
3878 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003879 if (ICmp.isEquality())
3880 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003881
3882 // A signed comparison of sign extended values simplifies into a
3883 // signed comparison.
3884 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003885 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003886
3887 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003888 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003889 }
3890
Sanjay Patel4c204232016-06-04 20:39:22 +00003891 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003892 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
3893 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00003894 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003895
3896 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003897 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003898 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003899 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00003900
3901 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003902 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00003903 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003904 if (ICmp.isEquality())
3905 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003906
3907 // A signed comparison of sign extended values simplifies into a
3908 // signed comparison.
3909 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003910 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003911
3912 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003913 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003914 }
3915
Sanjay Patel6a333c32016-06-06 16:56:57 +00003916 // The re-extended constant changed, partly changed (in the case of a vector),
3917 // or could not be determined to be equal (in the case of a constant
3918 // expression), so the constant cannot be represented in the shorter type.
3919 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003920 // All the cases that fold to true or false will have already been handled
3921 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00003922
Sanjay Patel6a333c32016-06-06 16:56:57 +00003923 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00003924 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003925
3926 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
3927 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003928
3929 // We're performing an unsigned comp with a sign extended value.
3930 // This is true if the input is >= 0. [aka >s -1]
3931 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Craig Topperbb4069e2017-07-07 23:16:26 +00003932 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00003933
3934 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003935 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
3936 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00003937
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003938 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00003939 return BinaryOperator::CreateNot(Result);
3940}
3941
Nikita Popov39f2beb2019-05-26 11:43:37 +00003942static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) {
3943 switch (BinaryOp) {
3944 default:
3945 llvm_unreachable("Unsupported binary op");
3946 case Instruction::Add:
3947 case Instruction::Sub:
3948 return match(RHS, m_Zero());
3949 case Instruction::Mul:
3950 return match(RHS, m_One());
3951 }
3952}
3953
3954OverflowResult InstCombiner::computeOverflow(
3955 Instruction::BinaryOps BinaryOp, bool IsSigned,
3956 Value *LHS, Value *RHS, Instruction *CxtI) const {
3957 switch (BinaryOp) {
3958 default:
3959 llvm_unreachable("Unsupported binary op");
3960 case Instruction::Add:
3961 if (IsSigned)
3962 return computeOverflowForSignedAdd(LHS, RHS, CxtI);
3963 else
3964 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI);
3965 case Instruction::Sub:
3966 if (IsSigned)
3967 return computeOverflowForSignedSub(LHS, RHS, CxtI);
3968 else
3969 return computeOverflowForUnsignedSub(LHS, RHS, CxtI);
3970 case Instruction::Mul:
3971 if (IsSigned)
3972 return computeOverflowForSignedMul(LHS, RHS, CxtI);
3973 else
3974 return computeOverflowForUnsignedMul(LHS, RHS, CxtI);
3975 }
3976}
3977
Nikita Popov352f5982019-05-26 11:43:31 +00003978bool InstCombiner::OptimizeOverflowCheck(
3979 Instruction::BinaryOps BinaryOp, bool IsSigned, Value *LHS, Value *RHS,
3980 Instruction &OrigI, Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00003981 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
3982 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003983
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003984 // If the overflow check was an add followed by a compare, the insertion point
3985 // may be pointing to the compare. We want to insert the new instructions
3986 // before the add in case there are uses of the add between the add and the
3987 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00003988 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003989
Nikita Popov39f2beb2019-05-26 11:43:37 +00003990 if (isNeutralValue(BinaryOp, RHS)) {
3991 Result = LHS;
3992 Overflow = Builder.getFalse();
3993 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003994 }
3995
Nikita Popov39f2beb2019-05-26 11:43:37 +00003996 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) {
3997 case OverflowResult::MayOverflow:
3998 return false;
Nikita Popov332c1002019-05-28 18:08:31 +00003999 case OverflowResult::AlwaysOverflowsLow:
4000 case OverflowResult::AlwaysOverflowsHigh:
Nikita Popov39f2beb2019-05-26 11:43:37 +00004001 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4002 Result->takeName(&OrigI);
4003 Overflow = Builder.getTrue();
4004 return true;
4005 case OverflowResult::NeverOverflows:
4006 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4007 Result->takeName(&OrigI);
4008 Overflow = Builder.getFalse();
4009 if (auto *Inst = dyn_cast<Instruction>(Result)) {
4010 if (IsSigned)
4011 Inst->setHasNoSignedWrap();
4012 else
4013 Inst->setHasNoUnsignedWrap();
4014 }
4015 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004016 }
4017
Nikita Popov39f2beb2019-05-26 11:43:37 +00004018 llvm_unreachable("Unexpected overflow result");
Sanjoy Dasb0984472015-04-08 04:27:22 +00004019}
4020
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004021/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004022/// overflow.
4023///
4024/// The caller has matched a pattern of the form:
4025/// I = cmp u (mul(zext A, zext B), V
4026/// The function checks if this is a test for overflow and if so replaces
4027/// multiplication with call to 'mul.with.overflow' intrinsic.
4028///
4029/// \param I Compare instruction.
4030/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
4031/// the compare instruction. Must be of integer type.
4032/// \param OtherVal The other argument of compare instruction.
4033/// \returns Instruction which must replace the compare instruction, NULL if no
4034/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004035static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004036 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00004037 // Don't bother doing this transformation for pointers, don't do it for
4038 // vectors.
4039 if (!isa<IntegerType>(MulVal->getType()))
4040 return nullptr;
4041
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004042 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
4043 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00004044 auto *MulInstr = dyn_cast<Instruction>(MulVal);
4045 if (!MulInstr)
4046 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004047 assert(MulInstr->getOpcode() == Instruction::Mul);
4048
David Majnemer634ca232014-11-01 23:46:05 +00004049 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
4050 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004051 assert(LHS->getOpcode() == Instruction::ZExt);
4052 assert(RHS->getOpcode() == Instruction::ZExt);
4053 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
4054
4055 // Calculate type and width of the result produced by mul.with.overflow.
4056 Type *TyA = A->getType(), *TyB = B->getType();
4057 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
4058 WidthB = TyB->getPrimitiveSizeInBits();
4059 unsigned MulWidth;
4060 Type *MulType;
4061 if (WidthB > WidthA) {
4062 MulWidth = WidthB;
4063 MulType = TyB;
4064 } else {
4065 MulWidth = WidthA;
4066 MulType = TyA;
4067 }
4068
4069 // In order to replace the original mul with a narrower mul.with.overflow,
4070 // all uses must ignore upper bits of the product. The number of used low
4071 // bits must be not greater than the width of mul.with.overflow.
4072 if (MulVal->hasNUsesOrMore(2))
4073 for (User *U : MulVal->users()) {
4074 if (U == &I)
4075 continue;
4076 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4077 // Check if truncation ignores bits above MulWidth.
4078 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
4079 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004080 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004081 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4082 // Check if AND ignores bits above MulWidth.
4083 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00004084 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004085 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
4086 const APInt &CVal = CI->getValue();
4087 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004088 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00004089 } else {
4090 // In this case we could have the operand of the binary operation
4091 // being defined in another block, and performing the replacement
4092 // could break the dominance relation.
4093 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004094 }
4095 } else {
4096 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00004097 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004098 }
4099 }
4100
4101 // Recognize patterns
4102 switch (I.getPredicate()) {
4103 case ICmpInst::ICMP_EQ:
4104 case ICmpInst::ICMP_NE:
4105 // Recognize pattern:
4106 // mulval = mul(zext A, zext B)
4107 // cmp eq/neq mulval, zext trunc mulval
4108 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
4109 if (Zext->hasOneUse()) {
4110 Value *ZextArg = Zext->getOperand(0);
4111 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
4112 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
4113 break; //Recognized
4114 }
4115
4116 // Recognize pattern:
4117 // mulval = mul(zext A, zext B)
4118 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
4119 ConstantInt *CI;
4120 Value *ValToMask;
4121 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
4122 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00004123 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004124 const APInt &CVal = CI->getValue() + 1;
4125 if (CVal.isPowerOf2()) {
4126 unsigned MaskWidth = CVal.logBase2();
4127 if (MaskWidth == MulWidth)
4128 break; // Recognized
4129 }
4130 }
Craig Topperf40110f2014-04-25 05:29:35 +00004131 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004132
4133 case ICmpInst::ICMP_UGT:
4134 // Recognize pattern:
4135 // mulval = mul(zext A, zext B)
4136 // cmp ugt mulval, max
4137 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4138 APInt MaxVal = APInt::getMaxValue(MulWidth);
4139 MaxVal = MaxVal.zext(CI->getBitWidth());
4140 if (MaxVal.eq(CI->getValue()))
4141 break; // Recognized
4142 }
Craig Topperf40110f2014-04-25 05:29:35 +00004143 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004144
4145 case ICmpInst::ICMP_UGE:
4146 // Recognize pattern:
4147 // mulval = mul(zext A, zext B)
4148 // cmp uge mulval, max+1
4149 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4150 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
4151 if (MaxVal.eq(CI->getValue()))
4152 break; // Recognized
4153 }
Craig Topperf40110f2014-04-25 05:29:35 +00004154 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004155
4156 case ICmpInst::ICMP_ULE:
4157 // Recognize pattern:
4158 // mulval = mul(zext A, zext B)
4159 // cmp ule mulval, max
4160 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4161 APInt MaxVal = APInt::getMaxValue(MulWidth);
4162 MaxVal = MaxVal.zext(CI->getBitWidth());
4163 if (MaxVal.eq(CI->getValue()))
4164 break; // Recognized
4165 }
Craig Topperf40110f2014-04-25 05:29:35 +00004166 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004167
4168 case ICmpInst::ICMP_ULT:
4169 // Recognize pattern:
4170 // mulval = mul(zext A, zext B)
4171 // cmp ule mulval, max + 1
4172 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004173 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004174 if (MaxVal.eq(CI->getValue()))
4175 break; // Recognized
4176 }
Craig Topperf40110f2014-04-25 05:29:35 +00004177 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004178
4179 default:
Craig Topperf40110f2014-04-25 05:29:35 +00004180 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004181 }
4182
Craig Topperbb4069e2017-07-07 23:16:26 +00004183 InstCombiner::BuilderTy &Builder = IC.Builder;
4184 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004185
4186 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
4187 Value *MulA = A, *MulB = B;
4188 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004189 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004190 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004191 MulB = Builder.CreateZExt(B, MulType);
James Y Knight7976eb52019-02-01 20:43:25 +00004192 Function *F = Intrinsic::getDeclaration(
4193 I.getModule(), Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004194 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004195 IC.Worklist.Add(MulInstr);
4196
4197 // If there are uses of mul result other than the comparison, we know that
4198 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004199 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004200 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004201 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004202 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4203 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004204 if (U == &I || U == OtherVal)
4205 continue;
4206 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4207 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004208 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004209 else
4210 TI->setOperand(0, Mul);
4211 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4212 assert(BO->getOpcode() == Instruction::And);
4213 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004214 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4215 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004216 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004217 Instruction *Zext =
4218 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4219 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004220 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004221 } else {
4222 llvm_unreachable("Unexpected Binary operation");
4223 }
Davide Italiano579064e2017-07-16 18:56:30 +00004224 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004225 }
4226 }
4227 if (isa<Instruction>(OtherVal))
4228 IC.Worklist.Add(cast<Instruction>(OtherVal));
4229
4230 // The original icmp gets replaced with the overflow value, maybe inverted
4231 // depending on predicate.
4232 bool Inverse = false;
4233 switch (I.getPredicate()) {
4234 case ICmpInst::ICMP_NE:
4235 break;
4236 case ICmpInst::ICMP_EQ:
4237 Inverse = true;
4238 break;
4239 case ICmpInst::ICMP_UGT:
4240 case ICmpInst::ICMP_UGE:
4241 if (I.getOperand(0) == MulVal)
4242 break;
4243 Inverse = true;
4244 break;
4245 case ICmpInst::ICMP_ULT:
4246 case ICmpInst::ICMP_ULE:
4247 if (I.getOperand(1) == MulVal)
4248 break;
4249 Inverse = true;
4250 break;
4251 default:
4252 llvm_unreachable("Unexpected predicate");
4253 }
4254 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004255 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004256 return BinaryOperator::CreateNot(Res);
4257 }
4258
4259 return ExtractValueInst::Create(Call, 1);
4260}
4261
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004262/// When performing a comparison against a constant, it is possible that not all
4263/// the bits in the LHS are demanded. This helper method computes the mask that
4264/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004265static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004266 const APInt *RHS;
4267 if (!match(I.getOperand(1), m_APInt(RHS)))
4268 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004269
Craig Topper3edda872017-09-22 18:57:23 +00004270 // If this is a normal comparison, it demands all bits. If it is a sign bit
4271 // comparison, it only demands the sign bit.
4272 bool UnusedBit;
4273 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4274 return APInt::getSignMask(BitWidth);
4275
Owen Andersond490c2d2011-01-11 00:36:45 +00004276 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004277 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004278 // correspond to the trailing ones of the comparand. The value of these
4279 // bits doesn't impact the outcome of the comparison, because any value
4280 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004281 case ICmpInst::ICMP_UGT:
4282 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004283
Owen Andersond490c2d2011-01-11 00:36:45 +00004284 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4285 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004286 case ICmpInst::ICMP_ULT:
4287 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004288
Owen Andersond490c2d2011-01-11 00:36:45 +00004289 default:
4290 return APInt::getAllOnesValue(BitWidth);
4291 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004292}
Chris Lattner2188e402010-01-04 07:37:31 +00004293
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004294/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004295/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004296/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004297/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004298/// The rationale is that several architectures use the same instruction for
4299/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004300/// match.
4301/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004302static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4303 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004304 // FIXME: we may want to go through inttoptrs or bitcasts.
4305 if (Op0->getType()->isPointerTy())
4306 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004307 // If a subtract already has the same operands as a compare, swapping would be
4308 // bad. If a subtract has the same operands as a compare but in reverse order,
4309 // then swapping is good.
4310 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004311 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004312 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4313 GoodToSwap++;
4314 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4315 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004316 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004317 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004318}
4319
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004320/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004321/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004322///
4323/// \param DI Definition
4324/// \param UI Use
4325/// \param DB Block that must dominate all uses of \p DI outside
4326/// the parent block
4327/// \return true when \p UI is the only use of \p DI in the parent block
4328/// and all other uses of \p DI are in blocks dominated by \p DB.
4329///
4330bool InstCombiner::dominatesAllUses(const Instruction *DI,
4331 const Instruction *UI,
4332 const BasicBlock *DB) const {
4333 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004334 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004335 if (!DI->getParent())
4336 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004337 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004338 if (DI->getParent() != UI->getParent())
4339 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004340 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004341 if (DI->getParent() == DB)
4342 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004343 for (const User *U : DI->users()) {
4344 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004345 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004346 return false;
4347 }
4348 return true;
4349}
4350
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004351/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004352static bool isChainSelectCmpBranch(const SelectInst *SI) {
4353 const BasicBlock *BB = SI->getParent();
4354 if (!BB)
4355 return false;
4356 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4357 if (!BI || BI->getNumSuccessors() != 2)
4358 return false;
4359 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4360 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4361 return false;
4362 return true;
4363}
4364
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004365/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004366/// in select-icmp sequence. This will eventually result in the elimination
4367/// of the select.
4368///
4369/// \param SI Select instruction
4370/// \param Icmp Compare instruction
4371/// \param SIOpd Operand that replaces the select
4372///
4373/// Notes:
4374/// - The replacement is global and requires dominator information
4375/// - The caller is responsible for the actual replacement
4376///
4377/// Example:
4378///
4379/// entry:
4380/// %4 = select i1 %3, %C* %0, %C* null
4381/// %5 = icmp eq %C* %4, null
4382/// br i1 %5, label %9, label %7
4383/// ...
4384/// ; <label>:7 ; preds = %entry
4385/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4386/// ...
4387///
4388/// can be transformed to
4389///
4390/// %5 = icmp eq %C* %0, null
4391/// %6 = select i1 %3, i1 %5, i1 true
4392/// br i1 %6, label %9, label %7
4393/// ...
4394/// ; <label>:7 ; preds = %entry
4395/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4396///
4397/// Similar when the first operand of the select is a constant or/and
4398/// the compare is for not equal rather than equal.
4399///
4400/// NOTE: The function is only called when the select and compare constants
4401/// are equal, the optimization can work only for EQ predicates. This is not a
4402/// major restriction since a NE compare should be 'normalized' to an equal
4403/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004404/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004405bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4406 const ICmpInst *Icmp,
4407 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004408 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004409 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4410 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004411 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004412 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004413 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4414 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4415 // replaced can be reached on either path. So the uniqueness check
4416 // guarantees that the path all uses of SI (outside SI's parent) are on
4417 // is disjoint from all other paths out of SI. But that information
4418 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004419 // of compile-time. It should also be noticed that we check for a single
4420 // predecessor and not only uniqueness. This to handle the situation when
4421 // Succ and Succ1 points to the same basic block.
4422 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004423 NumSel++;
4424 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4425 return true;
4426 }
4427 }
4428 return false;
4429}
4430
Sanjay Patel3151dec2016-09-12 15:24:31 +00004431/// Try to fold the comparison based on range information we can get by checking
4432/// whether bits are known to be zero or one in the inputs.
4433Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4434 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4435 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004436 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004437
4438 // Get scalar or pointer size.
4439 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4440 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004441 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004442
4443 if (!BitWidth)
4444 return nullptr;
4445
Craig Topperb45eabc2017-04-26 16:39:58 +00004446 KnownBits Op0Known(BitWidth);
4447 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004448
Craig Topper47596dd2017-03-25 06:52:52 +00004449 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004450 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004451 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004452 return &I;
4453
Craig Topper47596dd2017-03-25 06:52:52 +00004454 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004455 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004456 return &I;
4457
4458 // Given the known and unknown bits, compute a range that the LHS could be
4459 // in. Compute the Min, Max and RHS values based on the known bits. For the
4460 // EQ and NE we use unsigned values.
4461 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4462 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4463 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004464 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4465 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004466 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004467 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4468 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004469 }
4470
Sanjay Patelc63f9012018-01-04 14:31:56 +00004471 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4472 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004473 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004474 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004475 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004476 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004477 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004478
4479 // Based on the range information we know about the LHS, see if we can
4480 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004481 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004482 default:
4483 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004484 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004485 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004486 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4487 return Pred == CmpInst::ICMP_EQ
4488 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4489 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4490 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004491
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004492 // If all bits are known zero except for one, then we know at most one bit
4493 // is set. If the comparison is against zero, then this is a check to see if
4494 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004495 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004496 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004497 // If the LHS is an AND with the same constant, look through it.
4498 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004499 const APInt *LHSC;
4500 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4501 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004502 LHS = Op0;
4503
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004504 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004505 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4506 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004507 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004508 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004509 // ((1 << X) & 8) == 0 -> X != 3
4510 // ((1 << X) & 8) != 0 -> X == 3
4511 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4512 auto NewPred = ICmpInst::getInversePredicate(Pred);
4513 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004514 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004515 // ((1 << X) & 7) == 0 -> X >= 3
4516 // ((1 << X) & 7) != 0 -> X < 3
4517 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4518 auto NewPred =
4519 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4520 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004521 }
4522 }
4523
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004524 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004525 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004526 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004527 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4528 // ((8 >>u X) & 1) == 0 -> X != 3
4529 // ((8 >>u X) & 1) != 0 -> X == 3
4530 unsigned CmpVal = CI->countTrailingZeros();
4531 auto NewPred = ICmpInst::getInversePredicate(Pred);
4532 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4533 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004534 }
4535 break;
4536 }
4537 case ICmpInst::ICMP_ULT: {
4538 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4539 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4540 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4541 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4542 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4543 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4544
Craig Topper0cd25942017-09-27 22:57:18 +00004545 const APInt *CmpC;
4546 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004547 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004548 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004549 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004550 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004551 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4552 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004553 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004554 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4555 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004556 }
4557 break;
4558 }
4559 case ICmpInst::ICMP_UGT: {
4560 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4561 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004562 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4563 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004564 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4565 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4566
Craig Topper0cd25942017-09-27 22:57:18 +00004567 const APInt *CmpC;
4568 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004569 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004570 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004571 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004572 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004573 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4574 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004575 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004576 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4577 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004578 }
4579 break;
4580 }
Craig Topper0cd25942017-09-27 22:57:18 +00004581 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004582 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4583 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4584 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4585 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4586 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4587 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004588 const APInt *CmpC;
4589 if (match(Op1, m_APInt(CmpC))) {
4590 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004591 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004592 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004593 }
4594 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004595 }
4596 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004597 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4598 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4599 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4600 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004601 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4602 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004603 const APInt *CmpC;
4604 if (match(Op1, m_APInt(CmpC))) {
4605 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004606 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004607 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004608 }
4609 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004610 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004611 case ICmpInst::ICMP_SGE:
4612 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4613 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4614 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4615 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4616 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004617 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4618 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004619 break;
4620 case ICmpInst::ICMP_SLE:
4621 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4622 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4623 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4624 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4625 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004626 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4627 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004628 break;
4629 case ICmpInst::ICMP_UGE:
4630 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4631 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4632 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4633 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4634 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004635 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4636 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004637 break;
4638 case ICmpInst::ICMP_ULE:
4639 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4640 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4641 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4642 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4643 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004644 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4645 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004646 break;
4647 }
4648
4649 // Turn a signed comparison into an unsigned one if both operands are known to
4650 // have the same sign.
4651 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004652 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4653 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004654 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4655
4656 return nullptr;
4657}
4658
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004659/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4660/// it into the appropriate icmp lt or icmp gt instruction. This transform
4661/// allows them to be folded in visitICmpInst.
Sanjay Patele9b2c322016-05-17 00:57:57 +00004662static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4663 ICmpInst::Predicate Pred = I.getPredicate();
4664 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE &&
4665 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE)
4666 return nullptr;
4667
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004668 Value *Op0 = I.getOperand(0);
4669 Value *Op1 = I.getOperand(1);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004670 auto *Op1C = dyn_cast<Constant>(Op1);
4671 if (!Op1C)
4672 return nullptr;
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004673
Sanjay Patele9b2c322016-05-17 00:57:57 +00004674 // Check if the constant operand can be safely incremented/decremented without
4675 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled
4676 // the edge cases for us, so we just assert on them. For vectors, we must
4677 // handle the edge cases.
4678 Type *Op1Type = Op1->getType();
4679 bool IsSigned = I.isSigned();
4680 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Sanjay Patel18254932016-05-17 01:12:31 +00004681 auto *CI = dyn_cast<ConstantInt>(Op1C);
4682 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004683 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4684 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
4685 } else if (Op1Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004686 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004687 // are for scalar, we could remove the min/max checks. However, to do that,
4688 // we would have to use insertelement/shufflevector to replace edge values.
4689 unsigned NumElts = Op1Type->getVectorNumElements();
4690 for (unsigned i = 0; i != NumElts; ++i) {
4691 Constant *Elt = Op1C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004692 if (!Elt)
4693 return nullptr;
4694
Sanjay Patele9b2c322016-05-17 00:57:57 +00004695 if (isa<UndefValue>(Elt))
4696 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004697
Sanjay Patele9b2c322016-05-17 00:57:57 +00004698 // Bail out if we can't determine if this constant is min/max or if we
4699 // know that this constant is min/max.
4700 auto *CI = dyn_cast<ConstantInt>(Elt);
4701 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
4702 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004703 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004704 } else {
4705 // ConstantExpr?
4706 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004707 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004708
Sanjay Patele9b2c322016-05-17 00:57:57 +00004709 // Increment or decrement the constant and set the new comparison predicate:
4710 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT
Sanjay Patel22b01fe2016-05-17 20:20:40 +00004711 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004712 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT;
4713 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred;
4714 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne));
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004715}
4716
Sanjay Patele5747e32017-05-17 22:15:07 +00004717/// Integer compare with boolean values can always be turned into bitwise ops.
4718static Instruction *canonicalizeICmpBool(ICmpInst &I,
4719 InstCombiner::BuilderTy &Builder) {
4720 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004721 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004722
Sanjay Patelba212c22017-05-17 22:29:40 +00004723 // A boolean compared to true/false can be simplified to Op0/true/false in
4724 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4725 // Cases not handled by InstSimplify are always 'not' of Op0.
4726 if (match(B, m_Zero())) {
4727 switch (I.getPredicate()) {
4728 case CmpInst::ICMP_EQ: // A == 0 -> !A
4729 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4730 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4731 return BinaryOperator::CreateNot(A);
4732 default:
4733 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4734 }
4735 } else if (match(B, m_One())) {
4736 switch (I.getPredicate()) {
4737 case CmpInst::ICMP_NE: // A != 1 -> !A
4738 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4739 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4740 return BinaryOperator::CreateNot(A);
4741 default:
4742 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4743 }
4744 }
4745
Sanjay Patele5747e32017-05-17 22:15:07 +00004746 switch (I.getPredicate()) {
4747 default:
4748 llvm_unreachable("Invalid icmp instruction!");
4749 case ICmpInst::ICMP_EQ:
4750 // icmp eq i1 A, B -> ~(A ^ B)
4751 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4752
4753 case ICmpInst::ICMP_NE:
4754 // icmp ne i1 A, B -> A ^ B
4755 return BinaryOperator::CreateXor(A, B);
4756
4757 case ICmpInst::ICMP_UGT:
4758 // icmp ugt -> icmp ult
4759 std::swap(A, B);
4760 LLVM_FALLTHROUGH;
4761 case ICmpInst::ICMP_ULT:
4762 // icmp ult i1 A, B -> ~A & B
4763 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4764
4765 case ICmpInst::ICMP_SGT:
4766 // icmp sgt -> icmp slt
4767 std::swap(A, B);
4768 LLVM_FALLTHROUGH;
4769 case ICmpInst::ICMP_SLT:
4770 // icmp slt i1 A, B -> A & ~B
4771 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4772
4773 case ICmpInst::ICMP_UGE:
4774 // icmp uge -> icmp ule
4775 std::swap(A, B);
4776 LLVM_FALLTHROUGH;
4777 case ICmpInst::ICMP_ULE:
4778 // icmp ule i1 A, B -> ~A | B
4779 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4780
4781 case ICmpInst::ICMP_SGE:
4782 // icmp sge -> icmp sle
4783 std::swap(A, B);
4784 LLVM_FALLTHROUGH;
4785 case ICmpInst::ICMP_SLE:
4786 // icmp sle i1 A, B -> A | ~B
4787 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4788 }
4789}
4790
Roman Lebedev75404fb2018-09-12 18:19:43 +00004791// Transform pattern like:
Roman Lebedev1b7fc872018-09-15 12:04:13 +00004792// (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X
4793// (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X
Roman Lebedev75404fb2018-09-12 18:19:43 +00004794// Into:
4795// (X l>> Y) != 0
4796// (X l>> Y) == 0
4797static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp,
4798 InstCombiner::BuilderTy &Builder) {
Roman Lebedev6dc87002018-09-13 20:33:12 +00004799 ICmpInst::Predicate Pred, NewPred;
Roman Lebedev75404fb2018-09-12 18:19:43 +00004800 Value *X, *Y;
Roman Lebedev6dc87002018-09-13 20:33:12 +00004801 if (match(&Cmp,
4802 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) {
4803 // We want X to be the icmp's second operand, so swap predicate if it isn't.
4804 if (Cmp.getOperand(0) == X)
4805 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00004806
Roman Lebedev6dc87002018-09-13 20:33:12 +00004807 switch (Pred) {
4808 case ICmpInst::ICMP_ULE:
4809 NewPred = ICmpInst::ICMP_NE;
4810 break;
4811 case ICmpInst::ICMP_UGT:
4812 NewPred = ICmpInst::ICMP_EQ;
4813 break;
4814 default:
4815 return nullptr;
4816 }
Roman Lebedev1b7fc872018-09-15 12:04:13 +00004817 } else if (match(&Cmp, m_c_ICmp(Pred,
4818 m_OneUse(m_CombineOr(
4819 m_Not(m_Shl(m_AllOnes(), m_Value(Y))),
4820 m_Add(m_Shl(m_One(), m_Value(Y)),
4821 m_AllOnes()))),
4822 m_Value(X)))) {
4823 // The variant with 'add' is not canonical, (the variant with 'not' is)
4824 // we only get it because it has extra uses, and can't be canonicalized,
4825
Roman Lebedev6dc87002018-09-13 20:33:12 +00004826 // We want X to be the icmp's second operand, so swap predicate if it isn't.
4827 if (Cmp.getOperand(0) == X)
4828 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00004829
Roman Lebedev6dc87002018-09-13 20:33:12 +00004830 switch (Pred) {
4831 case ICmpInst::ICMP_ULT:
4832 NewPred = ICmpInst::ICMP_NE;
4833 break;
4834 case ICmpInst::ICMP_UGE:
4835 NewPred = ICmpInst::ICMP_EQ;
4836 break;
4837 default:
4838 return nullptr;
4839 }
4840 } else
Roman Lebedev75404fb2018-09-12 18:19:43 +00004841 return nullptr;
Roman Lebedev75404fb2018-09-12 18:19:43 +00004842
4843 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits");
4844 Constant *Zero = Constant::getNullValue(NewX->getType());
4845 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero);
4846}
4847
Sanjay Patel039f5562018-08-16 12:52:17 +00004848static Instruction *foldVectorCmp(CmpInst &Cmp,
4849 InstCombiner::BuilderTy &Builder) {
4850 // If both arguments of the cmp are shuffles that use the same mask and
4851 // shuffle within a single vector, move the shuffle after the cmp.
4852 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
4853 Value *V1, *V2;
4854 Constant *M;
4855 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
4856 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
4857 V1->getType() == V2->getType() &&
4858 (LHS->hasOneUse() || RHS->hasOneUse())) {
4859 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
4860 CmpInst::Predicate P = Cmp.getPredicate();
4861 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
4862 : Builder.CreateFCmp(P, V1, V2);
4863 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
4864 }
4865 return nullptr;
4866}
4867
Chris Lattner2188e402010-01-04 07:37:31 +00004868Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
4869 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00004870 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00004871 unsigned Op0Cplxity = getComplexity(Op0);
4872 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004873
Chris Lattner2188e402010-01-04 07:37:31 +00004874 /// Orders the operands of the compare so that they are listed from most
4875 /// complex to least complex. This puts constants before unary operators,
4876 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004877 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00004878 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004879 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00004880 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00004881 Changed = true;
4882 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004883
Daniel Berlin2c75c632017-04-26 20:56:07 +00004884 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
4885 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004886 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004887
Uriel Korach18972232017-09-10 08:31:22 +00004888 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00004889 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00004890 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004891 Value *Cond, *SelectTrue, *SelectFalse;
4892 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00004893 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004894 if (Value *V = dyn_castNegVal(SelectTrue)) {
4895 if (V == SelectFalse)
4896 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
4897 }
4898 else if (Value *V = dyn_castNegVal(SelectFalse)) {
4899 if (V == SelectTrue)
4900 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00004901 }
4902 }
4903 }
4904
Craig Topperfde47232017-07-09 07:04:03 +00004905 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00004906 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00004907 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004908
Sanjay Patele9b2c322016-05-17 00:57:57 +00004909 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004910 return NewICmp;
4911
Sanjay Patel06b127a2016-09-15 14:37:50 +00004912 if (Instruction *Res = foldICmpWithConstant(I))
4913 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004914
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00004915 if (Instruction *Res = foldICmpWithDominatingICmp(I))
4916 return Res;
4917
Max Kazantsev20da7e42018-07-06 04:04:13 +00004918 if (Instruction *Res = foldICmpUsingKnownBits(I))
4919 return Res;
4920
Chris Lattner2188e402010-01-04 07:37:31 +00004921 // Test if the ICmpInst instruction is used exclusively by a select as
4922 // part of a minimum or maximum operation. If so, refrain from doing
4923 // any other folding. This helps out other analyses which understand
4924 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4925 // and CodeGen. And in this case, at least one of the comparison
4926 // operands has at least one user besides the compare (the select),
4927 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00004928 //
4929 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00004930 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00004931 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
4932 Value *A, *B;
4933 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
4934 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00004935 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00004936 }
Chris Lattner2188e402010-01-04 07:37:31 +00004937
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00004938 // Do this after checking for min/max to prevent infinite looping.
4939 if (Instruction *Res = foldICmpWithZero(I))
4940 return Res;
4941
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00004942 // FIXME: We only do this after checking for min/max to prevent infinite
4943 // looping caused by a reverse canonicalization of these patterns for min/max.
4944 // FIXME: The organization of folds is a mess. These would naturally go into
4945 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
4946 // down here after the min/max restriction.
4947 ICmpInst::Predicate Pred = I.getPredicate();
4948 const APInt *C;
4949 if (match(Op1, m_APInt(C))) {
4950 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
4951 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
4952 Constant *Zero = Constant::getNullValue(Op0->getType());
4953 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
4954 }
4955
4956 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
4957 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
4958 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
4959 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
4960 }
4961 }
4962
Sanjay Patelf58f68c2016-09-10 15:03:44 +00004963 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00004964 return Res;
4965
Sanjay Patel10494b22016-09-16 16:10:22 +00004966 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
4967 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004968
4969 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
4970 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00004971 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00004972 return NI;
4973 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004974 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00004975 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
4976 return NI;
4977
Hans Wennborgf1f36512015-10-07 00:20:07 +00004978 // Try to optimize equality comparisons against alloca-based pointers.
4979 if (Op0->getType()->isPointerTy() && I.isEquality()) {
4980 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
4981 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004982 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004983 return New;
4984 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004985 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004986 return New;
4987 }
4988
Sanjay Patele7f46c32019-02-07 20:54:09 +00004989 if (Instruction *Res = foldICmpBitCast(I, Builder))
4990 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004991
Chris Lattner2188e402010-01-04 07:37:31 +00004992 if (isa<CastInst>(Op0)) {
4993 // Handle the special case of: icmp (cast bool to X), <cst>
4994 // This comes up when you have code like
4995 // int X = A < B;
4996 // if (X) ...
4997 // For generality, we handle any zero-extension of any operand comparison
4998 // with a constant or another cast from the same type.
4999 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00005000 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00005001 return R;
5002 }
Chris Lattner2188e402010-01-04 07:37:31 +00005003
Sanjay Patel10494b22016-09-16 16:10:22 +00005004 if (Instruction *Res = foldICmpBinOp(I))
5005 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00005006
Sanjay Pateldd46b522016-12-19 17:32:37 +00005007 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00005008 return Res;
5009
Sanjay Patel10494b22016-09-16 16:10:22 +00005010 {
5011 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00005012 // Transform (A & ~B) == 0 --> (A & B) != 0
5013 // and (A & ~B) != 0 --> (A & B) == 0
5014 // if A is a power of 2.
5015 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00005016 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00005017 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00005018 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00005019 Op1);
5020
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005021 // ~X < ~Y --> Y < X
5022 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005023 if (match(Op0, m_Not(m_Value(A)))) {
5024 if (match(Op1, m_Not(m_Value(B))))
5025 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005026
Sanjay Patelce241f42017-06-02 16:29:41 +00005027 const APInt *C;
5028 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005029 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00005030 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005031 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00005032
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005033 Instruction *AddI = nullptr;
5034 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
5035 m_Instruction(AddI))) &&
5036 isa<IntegerType>(A->getType())) {
5037 Value *Result;
5038 Constant *Overflow;
Nikita Popov352f5982019-05-26 11:43:31 +00005039 if (OptimizeOverflowCheck(Instruction::Add, /*Signed*/false, A, B,
5040 *AddI, Result, Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00005041 replaceInstUsesWith(*AddI, Result);
5042 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005043 }
5044 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005045
5046 // (zext a) * (zext b) --> llvm.umul.with.overflow.
5047 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005048 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005049 return R;
5050 }
5051 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005052 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005053 return R;
5054 }
Chris Lattner2188e402010-01-04 07:37:31 +00005055 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005056
Sanjay Patel10494b22016-09-16 16:10:22 +00005057 if (Instruction *Res = foldICmpEquality(I))
5058 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005059
David Majnemerc1eca5a2014-11-06 23:23:30 +00005060 // The 'cmpxchg' instruction returns an aggregate containing the old value and
5061 // an i1 which indicates whether or not we successfully did the swap.
5062 //
5063 // Replace comparisons between the old value and the expected value with the
5064 // indicator that 'cmpxchg' returns.
5065 //
5066 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
5067 // spuriously fail. In those cases, the old value may equal the expected
5068 // value but it is possible for the swap to not occur.
5069 if (I.getPredicate() == ICmpInst::ICMP_EQ)
5070 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
5071 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
5072 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
5073 !ACXI->isWeak())
5074 return ExtractValueInst::Create(ACXI, 1);
5075
Chris Lattner2188e402010-01-04 07:37:31 +00005076 {
Craig Topperbee74792018-08-20 23:04:25 +00005077 Value *X;
5078 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00005079 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00005080 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
5081 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005082
5083 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00005084 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
5085 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005086 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00005087
Roman Lebedev75404fb2018-09-12 18:19:43 +00005088 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder))
5089 return Res;
5090
Sanjay Patel039f5562018-08-16 12:52:17 +00005091 if (I.getType()->isVectorTy())
5092 if (Instruction *Res = foldVectorCmp(I, Builder))
5093 return Res;
5094
Craig Topperf40110f2014-04-25 05:29:35 +00005095 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005096}
5097
Sanjay Patel5f0217f2016-06-05 16:46:18 +00005098/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00005099Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00005100 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00005101 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005102 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005103
Chris Lattner2188e402010-01-04 07:37:31 +00005104 // Get the width of the mantissa. We don't want to hack on conversions that
5105 // might lose information from the integer, e.g. "i64 -> float"
5106 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00005107 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005108
Matt Arsenault55e73122015-01-06 15:50:59 +00005109 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
5110
Chris Lattner2188e402010-01-04 07:37:31 +00005111 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005112
Matt Arsenault55e73122015-01-06 15:50:59 +00005113 if (I.isEquality()) {
5114 FCmpInst::Predicate P = I.getPredicate();
5115 bool IsExact = false;
5116 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
5117 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
5118
5119 // If the floating point constant isn't an integer value, we know if we will
5120 // ever compare equal / not equal to it.
5121 if (!IsExact) {
5122 // TODO: Can never be -0.0 and other non-representable values
5123 APFloat RHSRoundInt(RHS);
5124 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
5125 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
5126 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00005127 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00005128
5129 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00005130 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00005131 }
5132 }
5133
5134 // TODO: If the constant is exactly representable, is it always OK to do
5135 // equality compares as integer?
5136 }
5137
Arch D. Robison8ed08542015-09-15 17:51:59 +00005138 // Check to see that the input is converted from an integer type that is small
5139 // enough that preserves all bits. TODO: check here for "known" sign bits.
5140 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
5141 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00005142
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005143 // Following test does NOT adjust InputSize downwards for signed inputs,
5144 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00005145 // to distinguish it from one less than that value.
5146 if ((int)InputSize > MantissaWidth) {
5147 // Conversion would lose accuracy. Check if loss can impact comparison.
5148 int Exp = ilogb(RHS);
5149 if (Exp == APFloat::IEK_Inf) {
5150 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005151 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005152 // Conversion could create infinity.
5153 return nullptr;
5154 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005155 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00005156 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005157 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005158 // Conversion could affect comparison.
5159 return nullptr;
5160 }
5161 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005162
Chris Lattner2188e402010-01-04 07:37:31 +00005163 // Otherwise, we can potentially simplify the comparison. We know that it
5164 // will always come through as an integer value and we know the constant is
5165 // not a NAN (it would have been previously simplified).
5166 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00005167
Chris Lattner2188e402010-01-04 07:37:31 +00005168 ICmpInst::Predicate Pred;
5169 switch (I.getPredicate()) {
5170 default: llvm_unreachable("Unexpected predicate!");
5171 case FCmpInst::FCMP_UEQ:
5172 case FCmpInst::FCMP_OEQ:
5173 Pred = ICmpInst::ICMP_EQ;
5174 break;
5175 case FCmpInst::FCMP_UGT:
5176 case FCmpInst::FCMP_OGT:
5177 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
5178 break;
5179 case FCmpInst::FCMP_UGE:
5180 case FCmpInst::FCMP_OGE:
5181 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
5182 break;
5183 case FCmpInst::FCMP_ULT:
5184 case FCmpInst::FCMP_OLT:
5185 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
5186 break;
5187 case FCmpInst::FCMP_ULE:
5188 case FCmpInst::FCMP_OLE:
5189 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
5190 break;
5191 case FCmpInst::FCMP_UNE:
5192 case FCmpInst::FCMP_ONE:
5193 Pred = ICmpInst::ICMP_NE;
5194 break;
5195 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00005196 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005197 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00005198 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005199 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005200
Chris Lattner2188e402010-01-04 07:37:31 +00005201 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005202
Chris Lattner2188e402010-01-04 07:37:31 +00005203 // See if the FP constant is too large for the integer. For example,
5204 // comparing an i8 to 300.0.
5205 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005206
Chris Lattner2188e402010-01-04 07:37:31 +00005207 if (!LHSUnsigned) {
5208 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5209 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005210 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005211 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5212 APFloat::rmNearestTiesToEven);
5213 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5214 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5215 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005216 return replaceInstUsesWith(I, Builder.getTrue());
5217 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005218 }
5219 } else {
5220 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5221 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005222 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005223 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5224 APFloat::rmNearestTiesToEven);
5225 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5226 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5227 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005228 return replaceInstUsesWith(I, Builder.getTrue());
5229 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005230 }
5231 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005232
Chris Lattner2188e402010-01-04 07:37:31 +00005233 if (!LHSUnsigned) {
5234 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005235 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005236 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5237 APFloat::rmNearestTiesToEven);
5238 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5239 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5240 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005241 return replaceInstUsesWith(I, Builder.getTrue());
5242 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005243 }
Devang Patel698452b2012-02-13 23:05:18 +00005244 } else {
5245 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005246 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005247 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5248 APFloat::rmNearestTiesToEven);
5249 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5250 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5251 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005252 return replaceInstUsesWith(I, Builder.getTrue());
5253 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005254 }
Chris Lattner2188e402010-01-04 07:37:31 +00005255 }
5256
5257 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5258 // [0, UMAX], but it may still be fractional. See if it is fractional by
5259 // casting the FP value to the integer value and back, checking for equality.
5260 // Don't do this for zero, because -0.0 is not fractional.
5261 Constant *RHSInt = LHSUnsigned
5262 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5263 : ConstantExpr::getFPToSI(RHSC, IntTy);
5264 if (!RHS.isZero()) {
5265 bool Equal = LHSUnsigned
5266 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5267 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5268 if (!Equal) {
5269 // If we had a comparison against a fractional value, we have to adjust
5270 // the compare predicate and sometimes the value. RHSC is rounded towards
5271 // zero at this point.
5272 switch (Pred) {
5273 default: llvm_unreachable("Unexpected integer comparison!");
5274 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005275 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005276 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005277 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005278 case ICmpInst::ICMP_ULE:
5279 // (float)int <= 4.4 --> int <= 4
5280 // (float)int <= -4.4 --> false
5281 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005282 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005283 break;
5284 case ICmpInst::ICMP_SLE:
5285 // (float)int <= 4.4 --> int <= 4
5286 // (float)int <= -4.4 --> int < -4
5287 if (RHS.isNegative())
5288 Pred = ICmpInst::ICMP_SLT;
5289 break;
5290 case ICmpInst::ICMP_ULT:
5291 // (float)int < -4.4 --> false
5292 // (float)int < 4.4 --> int <= 4
5293 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005294 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005295 Pred = ICmpInst::ICMP_ULE;
5296 break;
5297 case ICmpInst::ICMP_SLT:
5298 // (float)int < -4.4 --> int < -4
5299 // (float)int < 4.4 --> int <= 4
5300 if (!RHS.isNegative())
5301 Pred = ICmpInst::ICMP_SLE;
5302 break;
5303 case ICmpInst::ICMP_UGT:
5304 // (float)int > 4.4 --> int > 4
5305 // (float)int > -4.4 --> true
5306 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005307 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005308 break;
5309 case ICmpInst::ICMP_SGT:
5310 // (float)int > 4.4 --> int > 4
5311 // (float)int > -4.4 --> int >= -4
5312 if (RHS.isNegative())
5313 Pred = ICmpInst::ICMP_SGE;
5314 break;
5315 case ICmpInst::ICMP_UGE:
5316 // (float)int >= -4.4 --> true
5317 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005318 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005319 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005320 Pred = ICmpInst::ICMP_UGT;
5321 break;
5322 case ICmpInst::ICMP_SGE:
5323 // (float)int >= -4.4 --> int >= -4
5324 // (float)int >= 4.4 --> int > 4
5325 if (!RHS.isNegative())
5326 Pred = ICmpInst::ICMP_SGT;
5327 break;
5328 }
5329 }
5330 }
5331
5332 // Lower this FP comparison into an appropriate integer version of the
5333 // comparison.
5334 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5335}
5336
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005337/// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary.
5338static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI,
5339 Constant *RHSC) {
5340 // When C is not 0.0 and infinities are not allowed:
5341 // (C / X) < 0.0 is a sign-bit test of X
5342 // (C / X) < 0.0 --> X < 0.0 (if C is positive)
5343 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate)
5344 //
5345 // Proof:
5346 // Multiply (C / X) < 0.0 by X * X / C.
5347 // - X is non zero, if it is the flag 'ninf' is violated.
5348 // - C defines the sign of X * X * C. Thus it also defines whether to swap
5349 // the predicate. C is also non zero by definition.
5350 //
5351 // Thus X * X / C is non zero and the transformation is valid. [qed]
5352
5353 FCmpInst::Predicate Pred = I.getPredicate();
5354
5355 // Check that predicates are valid.
5356 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) &&
5357 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE))
5358 return nullptr;
5359
5360 // Check that RHS operand is zero.
5361 if (!match(RHSC, m_AnyZeroFP()))
5362 return nullptr;
5363
5364 // Check fastmath flags ('ninf').
5365 if (!LHSI->hasNoInfs() || !I.hasNoInfs())
5366 return nullptr;
5367
5368 // Check the properties of the dividend. It must not be zero to avoid a
5369 // division by zero (see Proof).
5370 const APFloat *C;
5371 if (!match(LHSI->getOperand(0), m_APFloat(C)))
5372 return nullptr;
5373
5374 if (C->isZero())
5375 return nullptr;
5376
5377 // Get swapped predicate if necessary.
5378 if (C->isNegative())
5379 Pred = I.getSwappedPredicate();
5380
Sanjay Pateld1172a02018-11-07 00:00:42 +00005381 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I);
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005382}
5383
Sanjay Patel1c254c62018-10-31 16:34:43 +00005384/// Optimize fabs(X) compared with zero.
5385static Instruction *foldFabsWithFcmpZero(FCmpInst &I) {
5386 Value *X;
5387 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) ||
5388 !match(I.getOperand(1), m_PosZeroFP()))
5389 return nullptr;
5390
Sanjay Patel57a08b32018-11-07 16:15:01 +00005391 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) {
5392 I->setPredicate(P);
5393 I->setOperand(0, X);
5394 return I;
5395 };
5396
Sanjay Patel1c254c62018-10-31 16:34:43 +00005397 switch (I.getPredicate()) {
5398 case FCmpInst::FCMP_UGE:
5399 case FCmpInst::FCMP_OLT:
5400 // fabs(X) >= 0.0 --> true
5401 // fabs(X) < 0.0 --> false
5402 llvm_unreachable("fcmp should have simplified");
5403
5404 case FCmpInst::FCMP_OGT:
5405 // fabs(X) > 0.0 --> X != 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005406 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005407
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005408 case FCmpInst::FCMP_UGT:
5409 // fabs(X) u> 0.0 --> X u!= 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005410 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005411
Sanjay Patel1c254c62018-10-31 16:34:43 +00005412 case FCmpInst::FCMP_OLE:
5413 // fabs(X) <= 0.0 --> X == 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005414 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005415
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005416 case FCmpInst::FCMP_ULE:
5417 // fabs(X) u<= 0.0 --> X u== 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005418 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005419
Sanjay Patel1c254c62018-10-31 16:34:43 +00005420 case FCmpInst::FCMP_OGE:
5421 // fabs(X) >= 0.0 --> !isnan(X)
5422 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005423 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005424
Sanjay Patel76faf512018-11-07 15:11:32 +00005425 case FCmpInst::FCMP_ULT:
5426 // fabs(X) u< 0.0 --> isnan(X)
5427 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005428 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X);
Sanjay Patel76faf512018-11-07 15:11:32 +00005429
Sanjay Patel1c254c62018-10-31 16:34:43 +00005430 case FCmpInst::FCMP_OEQ:
5431 case FCmpInst::FCMP_UEQ:
5432 case FCmpInst::FCMP_ONE:
5433 case FCmpInst::FCMP_UNE:
Sanjay Patelbb521e62018-11-07 15:44:26 +00005434 case FCmpInst::FCMP_ORD:
5435 case FCmpInst::FCMP_UNO:
5436 // Look through the fabs() because it doesn't change anything but the sign.
5437 // fabs(X) == 0.0 --> X == 0.0,
Sanjay Patel1c254c62018-10-31 16:34:43 +00005438 // fabs(X) != 0.0 --> X != 0.0
Sanjay Patelbb521e62018-11-07 15:44:26 +00005439 // isnan(fabs(X)) --> isnan(X)
5440 // !isnan(fabs(X) --> !isnan(X)
Sanjay Patel57a08b32018-11-07 16:15:01 +00005441 return replacePredAndOp0(&I, I.getPredicate(), X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005442
5443 default:
5444 return nullptr;
5445 }
5446}
5447
Chris Lattner2188e402010-01-04 07:37:31 +00005448Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5449 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005450
Chris Lattner2188e402010-01-04 07:37:31 +00005451 /// Orders the operands of the compare so that they are listed from most
5452 /// complex to least complex. This puts constants before unary operators,
5453 /// before binary operators.
5454 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5455 I.swapOperands();
5456 Changed = true;
5457 }
5458
Sanjay Patel6b139462017-09-02 15:11:55 +00005459 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005460 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005461 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5462 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005463 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005464
5465 // Simplify 'fcmp pred X, X'
Sanjay Patela706b9a2019-04-29 19:23:44 +00005466 Type *OpType = Op0->getType();
5467 assert(OpType == Op1->getType() && "fcmp with different-typed operands?");
Chris Lattner2188e402010-01-04 07:37:31 +00005468 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005469 switch (Pred) {
5470 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005471 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5472 case FCmpInst::FCMP_ULT: // True if unordered or less than
5473 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5474 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5475 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5476 I.setPredicate(FCmpInst::FCMP_UNO);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005477 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005478 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005479
Chris Lattner2188e402010-01-04 07:37:31 +00005480 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5481 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5482 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5483 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5484 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5485 I.setPredicate(FCmpInst::FCMP_ORD);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005486 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005487 return &I;
5488 }
5489 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005490
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005491 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5492 // then canonicalize the operand to 0.0.
5493 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005494 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005495 I.setOperand(0, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005496 return &I;
5497 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005498 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005499 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005500 return &I;
5501 }
5502 }
5503
Sanjay Patel6a281a72019-05-07 18:58:07 +00005504 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y
5505 Value *X, *Y;
5506 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
5507 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I);
5508
James Molloy2b21a7c2015-05-20 18:41:25 +00005509 // Test if the FCmpInst instruction is used exclusively by a select as
5510 // part of a minimum or maximum operation. If so, refrain from doing
5511 // any other folding. This helps out other analyses which understand
5512 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5513 // and CodeGen. And in this case, at least one of the comparison
5514 // operands has at least one user besides the compare (the select),
5515 // which would often largely negate the benefit of folding anyway.
5516 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005517 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5518 Value *A, *B;
5519 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5520 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005521 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005522 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005523
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005524 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0:
5525 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0
5526 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005527 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005528 return &I;
5529 }
5530
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005531 // Handle fcmp with instruction LHS and constant RHS.
5532 Instruction *LHSI;
5533 Constant *RHSC;
5534 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) {
5535 switch (LHSI->getOpcode()) {
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005536 case Instruction::PHI:
5537 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5538 // block. If in the same block, we're encouraging jump threading. If
5539 // not, we are just pessimizing the code by making an i1 phi.
5540 if (LHSI->getParent() == I.getParent())
5541 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005542 return NV;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005543 break;
5544 case Instruction::SIToFP:
5545 case Instruction::UIToFP:
5546 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
5547 return NV;
5548 break;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005549 case Instruction::FDiv:
5550 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC))
5551 return NV;
5552 break;
5553 case Instruction::Load:
5554 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0)))
5555 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5556 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5557 !cast<LoadInst>(LHSI)->isVolatile())
5558 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
5559 return Res;
5560 break;
Sanjay Patel1c254c62018-10-31 16:34:43 +00005561 }
Chris Lattner2188e402010-01-04 07:37:31 +00005562 }
5563
Sanjay Pateld1172a02018-11-07 00:00:42 +00005564 if (Instruction *R = foldFabsWithFcmpZero(I))
5565 return R;
5566
Sanjay Patel70282a02018-11-06 15:49:45 +00005567 if (match(Op0, m_FNeg(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005568 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C
Sanjay Patel70282a02018-11-06 15:49:45 +00005569 Constant *C;
5570 if (match(Op1, m_Constant(C))) {
Sanjay Patel70282a02018-11-06 15:49:45 +00005571 Constant *NegC = ConstantExpr::getFNeg(C);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005572 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00005573 }
5574 }
Benjamin Kramerd159d942011-03-31 10:12:22 +00005575
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005576 if (match(Op0, m_FPExt(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005577 // fcmp (fpext X), (fpext Y) -> fcmp X, Y
5578 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType())
5579 return new FCmpInst(Pred, X, Y, "", &I);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005580
Sanjay Pateld1172a02018-11-07 00:00:42 +00005581 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless
Sanjay Patel724014a2018-11-06 17:20:20 +00005582 const APFloat *C;
5583 if (match(Op1, m_APFloat(C))) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005584 const fltSemantics &FPSem =
5585 X->getType()->getScalarType()->getFltSemantics();
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005586 bool Lossy;
Sanjay Patel724014a2018-11-06 17:20:20 +00005587 APFloat TruncC = *C;
5588 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005589
5590 // Avoid lossy conversions and denormals.
5591 // Zero is a special case that's OK to convert.
Sanjay Patel724014a2018-11-06 17:20:20 +00005592 APFloat Fabs = TruncC;
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005593 Fabs.clearSign();
5594 if (!Lossy &&
5595 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) !=
Sanjay Patel46bf3922018-11-06 16:45:27 +00005596 APFloat::cmpLessThan) || Fabs.isZero())) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005597 Constant *NewC = ConstantFP::get(X->getType(), TruncC);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005598 return new FCmpInst(Pred, X, NewC, "", &I);
Sanjay Patel46bf3922018-11-06 16:45:27 +00005599 }
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005600 }
Sanjay Patel1b85f0022018-11-06 16:23:03 +00005601 }
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005602
Sanjay Patel039f5562018-08-16 12:52:17 +00005603 if (I.getType()->isVectorTy())
5604 if (Instruction *Res = foldVectorCmp(I, Builder))
5605 return Res;
5606
Craig Topperf40110f2014-04-25 05:29:35 +00005607 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005608}