blob: 0b3edddaf93a112de593975c0e2f6c467368f24b [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Chris Lattner2188e402010-01-04 07:37:31 +00006//
7//===----------------------------------------------------------------------===//
8//
9// This file implements the visitICmp and visitFCmp functions.
10//
11//===----------------------------------------------------------------------===//
12
Chandler Carrutha9174582015-01-22 05:25:13 +000013#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000014#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000015#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000016#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000017#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000018#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000019#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000020#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000021#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000022#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000023#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000024#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000025#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000026#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000027
Chris Lattner2188e402010-01-04 07:37:31 +000028using namespace llvm;
29using namespace PatternMatch;
30
Chandler Carruth964daaa2014-04-22 02:55:47 +000031#define DEBUG_TYPE "instcombine"
32
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000033// How many times is a select replaced by one of its operands?
34STATISTIC(NumSel, "Number of select opts");
35
Chris Lattner98457102011-02-10 05:23:05 +000036
Sanjay Patel5f0217f2016-06-05 16:46:18 +000037/// Compute Result = In1+In2, returning true if the result overflowed for this
38/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000039static bool addWithOverflow(APInt &Result, const APInt &In1,
40 const APInt &In2, bool IsSigned = false) {
41 bool Overflow;
42 if (IsSigned)
43 Result = In1.sadd_ov(In2, Overflow);
44 else
45 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000046
Craig Topper6e025a32017-10-01 23:53:54 +000047 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000048}
49
Sanjay Patel5f0217f2016-06-05 16:46:18 +000050/// Compute Result = In1-In2, returning true if the result overflowed for this
51/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000052static bool subWithOverflow(APInt &Result, const APInt &In1,
53 const APInt &In2, bool IsSigned = false) {
54 bool Overflow;
55 if (IsSigned)
56 Result = In1.ssub_ov(In2, Overflow);
57 else
58 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000059
Craig Topper6e025a32017-10-01 23:53:54 +000060 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000061}
62
Balaram Makam569eaec2016-05-04 21:32:14 +000063/// Given an icmp instruction, return true if any use of this comparison is a
64/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000065static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000066 for (auto *U : I.users())
67 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000068 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000069 return false;
70}
71
Sanjay Patel5f0217f2016-06-05 16:46:18 +000072/// Given an exploded icmp instruction, return true if the comparison only
73/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
74/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000075static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000076 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000077 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000078 case ICmpInst::ICMP_SLT: // True if LHS s< 0
79 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000080 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000081 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
82 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000083 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000084 case ICmpInst::ICMP_SGT: // True if LHS s> -1
85 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000086 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000087 case ICmpInst::ICMP_UGT:
88 // True if LHS u> RHS and RHS == high-bit-mask - 1
89 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000090 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000091 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000092 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
93 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000094 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000095 default:
96 return false;
97 }
98}
99
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000100/// Returns true if the exploded icmp can be expressed as a signed comparison
101/// to zero and updates the predicate accordingly.
102/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000103/// TODO: Refactor with decomposeBitTestICmp()?
104static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000105 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000106 return false;
107
Craig Topper73ba1c82017-06-07 07:40:37 +0000108 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000109 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000110
Craig Topper73ba1c82017-06-07 07:40:37 +0000111 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000112 if (Pred == ICmpInst::ICMP_SLT) {
113 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000114 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000116 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000117 if (Pred == ICmpInst::ICMP_SGT) {
118 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000119 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000121 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000122
123 return false;
124}
125
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000126/// Given a signed integer type and a set of known zero and one bits, compute
127/// the maximum and minimum values that could have the specified known zero and
128/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000129/// TODO: Move to method on KnownBits struct?
130static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000131 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000132 assert(Known.getBitWidth() == Min.getBitWidth() &&
133 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000134 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000135 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000136
137 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
138 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000139 Min = Known.One;
140 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000141
Chris Lattner2188e402010-01-04 07:37:31 +0000142 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000143 Min.setSignBit();
144 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000145 }
146}
147
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000148/// Given an unsigned integer type and a set of known zero and one bits, compute
149/// the maximum and minimum values that could have the specified known zero and
150/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000151/// TODO: Move to method on KnownBits struct?
152static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000153 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000154 assert(Known.getBitWidth() == Min.getBitWidth() &&
155 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000156 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000157 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000158
Chris Lattner2188e402010-01-04 07:37:31 +0000159 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000160 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000161 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000162 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000163}
164
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000165/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000166/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000167/// where GV is a global variable with a constant initializer. Try to simplify
168/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000169/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
170///
171/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000172/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000173Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
174 GlobalVariable *GV,
175 CmpInst &ICI,
176 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000177 Constant *Init = GV->getInitializer();
178 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000179 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000180
Chris Lattnerfe741762012-01-31 02:55:06 +0000181 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000182 // Don't blow up on huge arrays.
183 if (ArrayElementCount > MaxArraySizeForCombine)
184 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000185
Chris Lattner2188e402010-01-04 07:37:31 +0000186 // There are many forms of this optimization we can handle, for now, just do
187 // the simple index into a single-dimensional array.
188 //
189 // Require: GEP GV, 0, i {{, constant indices}}
190 if (GEP->getNumOperands() < 3 ||
191 !isa<ConstantInt>(GEP->getOperand(1)) ||
192 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
193 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000194 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000195
196 // Check that indices after the variable are constants and in-range for the
197 // type they index. Collect the indices. This is typically for arrays of
198 // structs.
199 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000200
Chris Lattnerfe741762012-01-31 02:55:06 +0000201 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000202 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
203 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000204 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000205
Chris Lattner2188e402010-01-04 07:37:31 +0000206 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000207 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner229907c2011-07-18 04:54:35 +0000209 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000210 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000211 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000212 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000213 EltTy = ATy->getElementType();
214 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000215 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000216 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000217
Chris Lattner2188e402010-01-04 07:37:31 +0000218 LaterIndices.push_back(IdxVal);
219 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000220
Chris Lattner2188e402010-01-04 07:37:31 +0000221 enum { Overdefined = -3, Undefined = -2 };
222
223 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000224
Chris Lattner2188e402010-01-04 07:37:31 +0000225 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
226 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
227 // and 87 is the second (and last) index. FirstTrueElement is -2 when
228 // undefined, otherwise set to the first true element. SecondTrueElement is
229 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
230 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
231
232 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
233 // form "i != 47 & i != 87". Same state transitions as for true elements.
234 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000235
Chris Lattner2188e402010-01-04 07:37:31 +0000236 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
237 /// define a state machine that triggers for ranges of values that the index
238 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
239 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
240 /// index in the range (inclusive). We use -2 for undefined here because we
241 /// use relative comparisons and don't want 0-1 to match -1.
242 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000243
Chris Lattner2188e402010-01-04 07:37:31 +0000244 // MagicBitvector - This is a magic bitvector where we set a bit if the
245 // comparison is true for element 'i'. If there are 64 elements or less in
246 // the array, this will fully represent all the comparison results.
247 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000248
Chris Lattner2188e402010-01-04 07:37:31 +0000249 // Scan the array and see if one of our patterns matches.
250 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000251 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
252 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000253 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000254
Chris Lattner2188e402010-01-04 07:37:31 +0000255 // If this is indexing an array of structures, get the structure element.
256 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000257 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000258
Chris Lattner2188e402010-01-04 07:37:31 +0000259 // If the element is masked, handle it.
260 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000261
Chris Lattner2188e402010-01-04 07:37:31 +0000262 // Find out if the comparison would be true or false for the i'th element.
263 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000264 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000265 // If the result is undef for this element, ignore it.
266 if (isa<UndefValue>(C)) {
267 // Extend range state machines to cover this element in case there is an
268 // undef in the middle of the range.
269 if (TrueRangeEnd == (int)i-1)
270 TrueRangeEnd = i;
271 if (FalseRangeEnd == (int)i-1)
272 FalseRangeEnd = i;
273 continue;
274 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000275
Chris Lattner2188e402010-01-04 07:37:31 +0000276 // If we can't compute the result for any of the elements, we have to give
277 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000278 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000279
Chris Lattner2188e402010-01-04 07:37:31 +0000280 // Otherwise, we know if the comparison is true or false for this element,
281 // update our state machines.
282 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000283
Chris Lattner2188e402010-01-04 07:37:31 +0000284 // State machine for single/double/range index comparison.
285 if (IsTrueForElt) {
286 // Update the TrueElement state machine.
287 if (FirstTrueElement == Undefined)
288 FirstTrueElement = TrueRangeEnd = i; // First true element.
289 else {
290 // Update double-compare state machine.
291 if (SecondTrueElement == Undefined)
292 SecondTrueElement = i;
293 else
294 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000295
Chris Lattner2188e402010-01-04 07:37:31 +0000296 // Update range state machine.
297 if (TrueRangeEnd == (int)i-1)
298 TrueRangeEnd = i;
299 else
300 TrueRangeEnd = Overdefined;
301 }
302 } else {
303 // Update the FalseElement state machine.
304 if (FirstFalseElement == Undefined)
305 FirstFalseElement = FalseRangeEnd = i; // First false element.
306 else {
307 // Update double-compare state machine.
308 if (SecondFalseElement == Undefined)
309 SecondFalseElement = i;
310 else
311 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000312
Chris Lattner2188e402010-01-04 07:37:31 +0000313 // Update range state machine.
314 if (FalseRangeEnd == (int)i-1)
315 FalseRangeEnd = i;
316 else
317 FalseRangeEnd = Overdefined;
318 }
319 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000320
Chris Lattner2188e402010-01-04 07:37:31 +0000321 // If this element is in range, update our magic bitvector.
322 if (i < 64 && IsTrueForElt)
323 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000324
Chris Lattner2188e402010-01-04 07:37:31 +0000325 // If all of our states become overdefined, bail out early. Since the
326 // predicate is expensive, only check it every 8 elements. This is only
327 // really useful for really huge arrays.
328 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
329 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
330 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000331 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000332 }
333
334 // Now that we've scanned the entire array, emit our new comparison(s). We
335 // order the state machines in complexity of the generated code.
336 Value *Idx = GEP->getOperand(2);
337
Matt Arsenault5aeae182013-08-19 21:40:31 +0000338 // If the index is larger than the pointer size of the target, truncate the
339 // index down like the GEP would do implicitly. We don't have to do this for
340 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000341 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000342 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000343 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
344 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000345 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000346 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000347
Chris Lattner2188e402010-01-04 07:37:31 +0000348 // If the comparison is only true for one or two elements, emit direct
349 // comparisons.
350 if (SecondTrueElement != Overdefined) {
351 // None true -> false.
352 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000353 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000354
Chris Lattner2188e402010-01-04 07:37:31 +0000355 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000356
Chris Lattner2188e402010-01-04 07:37:31 +0000357 // True for one element -> 'i == 47'.
358 if (SecondTrueElement == Undefined)
359 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000360
Chris Lattner2188e402010-01-04 07:37:31 +0000361 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000362 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000363 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000364 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000365 return BinaryOperator::CreateOr(C1, C2);
366 }
367
368 // If the comparison is only false for one or two elements, emit direct
369 // comparisons.
370 if (SecondFalseElement != Overdefined) {
371 // None false -> true.
372 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000373 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000374
Chris Lattner2188e402010-01-04 07:37:31 +0000375 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
376
377 // False for one element -> 'i != 47'.
378 if (SecondFalseElement == Undefined)
379 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000380
Chris Lattner2188e402010-01-04 07:37:31 +0000381 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000382 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000383 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000384 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000385 return BinaryOperator::CreateAnd(C1, C2);
386 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000387
Chris Lattner2188e402010-01-04 07:37:31 +0000388 // If the comparison can be replaced with a range comparison for the elements
389 // where it is true, emit the range check.
390 if (TrueRangeEnd != Overdefined) {
391 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000392
Chris Lattner2188e402010-01-04 07:37:31 +0000393 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
394 if (FirstTrueElement) {
395 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000396 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000397 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000398
Chris Lattner2188e402010-01-04 07:37:31 +0000399 Value *End = ConstantInt::get(Idx->getType(),
400 TrueRangeEnd-FirstTrueElement+1);
401 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
402 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000403
Chris Lattner2188e402010-01-04 07:37:31 +0000404 // False range check.
405 if (FalseRangeEnd != Overdefined) {
406 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
407 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
408 if (FirstFalseElement) {
409 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000410 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000411 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000412
Chris Lattner2188e402010-01-04 07:37:31 +0000413 Value *End = ConstantInt::get(Idx->getType(),
414 FalseRangeEnd-FirstFalseElement);
415 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
416 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000417
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000418 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000419 // of this load, replace it with computation that does:
420 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000421 {
Craig Topperf40110f2014-04-25 05:29:35 +0000422 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000423
424 // Look for an appropriate type:
425 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000426 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000427 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
428 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000429 else
430 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000431
Craig Topperf40110f2014-04-25 05:29:35 +0000432 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000433 Value *V = Builder.CreateIntCast(Idx, Ty, false);
434 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
435 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000436 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
437 }
Chris Lattner2188e402010-01-04 07:37:31 +0000438 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000439
Craig Topperf40110f2014-04-25 05:29:35 +0000440 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000441}
442
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000443/// Return a value that can be used to compare the *offset* implied by a GEP to
444/// zero. For example, if we have &A[i], we want to return 'i' for
445/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
446/// are involved. The above expression would also be legal to codegen as
447/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
448/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000449/// to generate the first by knowing that pointer arithmetic doesn't overflow.
450///
451/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000452///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000453static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000454 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000455 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000456
Chris Lattner2188e402010-01-04 07:37:31 +0000457 // Check to see if this gep only has a single variable index. If so, and if
458 // any constant indices are a multiple of its scale, then we can compute this
459 // in terms of the scale of the variable index. For example, if the GEP
460 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
461 // because the expression will cross zero at the same point.
462 unsigned i, e = GEP->getNumOperands();
463 int64_t Offset = 0;
464 for (i = 1; i != e; ++i, ++GTI) {
465 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
466 // Compute the aggregate offset of constant indices.
467 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000468
Chris Lattner2188e402010-01-04 07:37:31 +0000469 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000470 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000471 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000472 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000473 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000474 Offset += Size*CI->getSExtValue();
475 }
476 } else {
477 // Found our variable index.
478 break;
479 }
480 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000481
Chris Lattner2188e402010-01-04 07:37:31 +0000482 // If there are no variable indices, we must have a constant offset, just
483 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000484 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000485
Chris Lattner2188e402010-01-04 07:37:31 +0000486 Value *VariableIdx = GEP->getOperand(i);
487 // Determine the scale factor of the variable element. For example, this is
488 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000489 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000490
Chris Lattner2188e402010-01-04 07:37:31 +0000491 // Verify that there are no other variable indices. If so, emit the hard way.
492 for (++i, ++GTI; i != e; ++i, ++GTI) {
493 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000494 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000495
Chris Lattner2188e402010-01-04 07:37:31 +0000496 // Compute the aggregate offset of constant indices.
497 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000498
Chris Lattner2188e402010-01-04 07:37:31 +0000499 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000500 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000501 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000502 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000503 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000504 Offset += Size*CI->getSExtValue();
505 }
506 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000507
Chris Lattner2188e402010-01-04 07:37:31 +0000508 // Okay, we know we have a single variable index, which must be a
509 // pointer/array/vector index. If there is no offset, life is simple, return
510 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000511 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000512 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000513 if (Offset == 0) {
514 // Cast to intptrty in case a truncation occurs. If an extension is needed,
515 // we don't need to bother extending: the extension won't affect where the
516 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000517 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000518 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000519 }
Chris Lattner2188e402010-01-04 07:37:31 +0000520 return VariableIdx;
521 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000522
Chris Lattner2188e402010-01-04 07:37:31 +0000523 // Otherwise, there is an index. The computation we will do will be modulo
Nikita Popov36e03ac2018-12-12 23:19:03 +0000524 // the pointer size.
525 Offset = SignExtend64(Offset, IntPtrWidth);
526 VariableScale = SignExtend64(VariableScale, IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 // To do this transformation, any constant index must be a multiple of the
529 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
530 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
531 // multiple of the variable scale.
532 int64_t NewOffs = Offset / (int64_t)VariableScale;
533 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000534 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000535
Chris Lattner2188e402010-01-04 07:37:31 +0000536 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000537 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000538 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000539 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000540 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000542}
543
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000544/// Returns true if we can rewrite Start as a GEP with pointer Base
545/// and some integer offset. The nodes that need to be re-written
546/// for this transformation will be added to Explored.
547static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
548 const DataLayout &DL,
549 SetVector<Value *> &Explored) {
550 SmallVector<Value *, 16> WorkList(1, Start);
551 Explored.insert(Base);
552
553 // The following traversal gives us an order which can be used
554 // when doing the final transformation. Since in the final
555 // transformation we create the PHI replacement instructions first,
556 // we don't have to get them in any particular order.
557 //
558 // However, for other instructions we will have to traverse the
559 // operands of an instruction first, which means that we have to
560 // do a post-order traversal.
561 while (!WorkList.empty()) {
562 SetVector<PHINode *> PHIs;
563
564 while (!WorkList.empty()) {
565 if (Explored.size() >= 100)
566 return false;
567
568 Value *V = WorkList.back();
569
570 if (Explored.count(V) != 0) {
571 WorkList.pop_back();
572 continue;
573 }
574
575 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000576 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000577 // We've found some value that we can't explore which is different from
578 // the base. Therefore we can't do this transformation.
579 return false;
580
581 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
582 auto *CI = dyn_cast<CastInst>(V);
583 if (!CI->isNoopCast(DL))
584 return false;
585
586 if (Explored.count(CI->getOperand(0)) == 0)
587 WorkList.push_back(CI->getOperand(0));
588 }
589
590 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
591 // We're limiting the GEP to having one index. This will preserve
592 // the original pointer type. We could handle more cases in the
593 // future.
594 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
595 GEP->getType() != Start->getType())
596 return false;
597
598 if (Explored.count(GEP->getOperand(0)) == 0)
599 WorkList.push_back(GEP->getOperand(0));
600 }
601
602 if (WorkList.back() == V) {
603 WorkList.pop_back();
604 // We've finished visiting this node, mark it as such.
605 Explored.insert(V);
606 }
607
608 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000609 // We cannot transform PHIs on unsplittable basic blocks.
610 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
611 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000612 Explored.insert(PN);
613 PHIs.insert(PN);
614 }
615 }
616
617 // Explore the PHI nodes further.
618 for (auto *PN : PHIs)
619 for (Value *Op : PN->incoming_values())
620 if (Explored.count(Op) == 0)
621 WorkList.push_back(Op);
622 }
623
624 // Make sure that we can do this. Since we can't insert GEPs in a basic
625 // block before a PHI node, we can't easily do this transformation if
626 // we have PHI node users of transformed instructions.
627 for (Value *Val : Explored) {
628 for (Value *Use : Val->uses()) {
629
630 auto *PHI = dyn_cast<PHINode>(Use);
631 auto *Inst = dyn_cast<Instruction>(Val);
632
633 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
634 Explored.count(PHI) == 0)
635 continue;
636
637 if (PHI->getParent() == Inst->getParent())
638 return false;
639 }
640 }
641 return true;
642}
643
644// Sets the appropriate insert point on Builder where we can add
645// a replacement Instruction for V (if that is possible).
646static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
647 bool Before = true) {
648 if (auto *PHI = dyn_cast<PHINode>(V)) {
649 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
650 return;
651 }
652 if (auto *I = dyn_cast<Instruction>(V)) {
653 if (!Before)
654 I = &*std::next(I->getIterator());
655 Builder.SetInsertPoint(I);
656 return;
657 }
658 if (auto *A = dyn_cast<Argument>(V)) {
659 // Set the insertion point in the entry block.
660 BasicBlock &Entry = A->getParent()->getEntryBlock();
661 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
662 return;
663 }
664 // Otherwise, this is a constant and we don't need to set a new
665 // insertion point.
666 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
667}
668
669/// Returns a re-written value of Start as an indexed GEP using Base as a
670/// pointer.
671static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
672 const DataLayout &DL,
673 SetVector<Value *> &Explored) {
674 // Perform all the substitutions. This is a bit tricky because we can
675 // have cycles in our use-def chains.
676 // 1. Create the PHI nodes without any incoming values.
677 // 2. Create all the other values.
678 // 3. Add the edges for the PHI nodes.
679 // 4. Emit GEPs to get the original pointers.
680 // 5. Remove the original instructions.
681 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000682 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000683
684 DenseMap<Value *, Value *> NewInsts;
685 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
686
687 // Create the new PHI nodes, without adding any incoming values.
688 for (Value *Val : Explored) {
689 if (Val == Base)
690 continue;
691 // Create empty phi nodes. This avoids cyclic dependencies when creating
692 // the remaining instructions.
693 if (auto *PHI = dyn_cast<PHINode>(Val))
694 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
695 PHI->getName() + ".idx", PHI);
696 }
697 IRBuilder<> Builder(Base->getContext());
698
699 // Create all the other instructions.
700 for (Value *Val : Explored) {
701
702 if (NewInsts.find(Val) != NewInsts.end())
703 continue;
704
705 if (auto *CI = dyn_cast<CastInst>(Val)) {
Martin Storsjo0fe645c2019-05-30 20:53:21 +0000706 // Don't get rid of the intermediate variable here; the store can grow
707 // the map which will invalidate the reference to the input value.
708 Value *V = NewInsts[CI->getOperand(0)];
709 NewInsts[CI] = V;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
835 if (!GEPLHS->hasAllConstantIndices())
836 return nullptr;
837
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000838 // Make sure the pointers have the same type.
839 if (GEPLHS->getType() != RHS->getType())
840 return nullptr;
841
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000842 Value *PtrBase, *Index;
843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
844
845 // The set of nodes that will take part in this transformation.
846 SetVector<Value *> Nodes;
847
848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
849 return nullptr;
850
851 // We know we can re-write this as
852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
853 // Since we've only looked through inbouds GEPs we know that we
854 // can't have overflow on either side. We can therefore re-write
855 // this as:
856 // OFFSET1 cmp OFFSET2
857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
858
859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
861 // offset. Since Index is the offset of LHS to the base pointer, we will now
862 // compare the offsets instead of comparing the pointers.
863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
864}
865
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000866/// Fold comparisons between a GEP instruction and something else. At this point
867/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000868Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000869 ICmpInst::Predicate Cond,
870 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000871 // Don't transform signed compares of GEPs into index compares. Even if the
872 // GEP is inbounds, the final add of the base pointer can have signed overflow
873 // and would change the result of the icmp.
874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000875 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000876 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000877 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000878
Matt Arsenault44f60d02014-06-09 19:20:29 +0000879 // Look through bitcasts and addrspacecasts. We do not however want to remove
880 // 0 GEPs.
881 if (!isa<GetElementPtrInst>(RHS))
882 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000883
884 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000885 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
887 // This transformation (ignoring the base and scales) is valid because we
888 // know pointers can't overflow since the gep is inbounds. See if we can
889 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000891
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000893 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000894 Offset = EmitGEPOffset(GEPLHS);
895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
896 Constant::getNullValue(Offset->getType()));
Philip Reames5b02cfa2019-08-23 17:58:58 +0000897 } else if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) &&
898 GEPLHS->getType()->isPointerTy() && // TODO: extend to vector geps
899 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() &&
900 !NullPointerIsDefined(I.getFunction(),
901 RHS->getType()->getPointerAddressSpace())) {
902 // For most address spaces, an allocation can't be placed at null, but null
903 // itself is treated as a 0 size allocation in the in bounds rules. Thus,
904 // the only valid inbounds address derived from null, is null itself.
905 // Thus, we have four cases to consider:
906 // 1) Base == nullptr, Offset == 0 -> inbounds, null
907 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds
908 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations)
909 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison)
910 //
911 // (Note if we're indexing a type of size 0, that simply collapses into one
912 // of the buckets above.)
913 //
914 // In general, we're allowed to make values less poison (i.e. remove
915 // sources of full UB), so in this case, we just select between the two
916 // non-poison cases (1 and 4 above).
Philip Reames9cb059f2019-08-23 18:27:57 +0000917 auto *Base = GEPLHS->getPointerOperand();
918 return new ICmpInst(Cond, Base,
919 ConstantExpr::getBitCast(cast<Constant>(RHS),
920 Base->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +0000921 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
922 // If the base pointers are different, but the indices are the same, just
923 // compare the base pointer.
924 if (PtrBase != GEPRHS->getOperand(0)) {
925 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
926 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
927 GEPRHS->getOperand(0)->getType();
928 if (IndicesTheSame)
929 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
930 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
931 IndicesTheSame = false;
932 break;
933 }
934
935 // If all indices are the same, just compare the base pointers.
Jesper Antonssonc954b862018-10-01 14:59:25 +0000936 Type *BaseType = GEPLHS->getOperand(0)->getType();
937 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType())
David Majnemer5953d372013-06-29 10:28:04 +0000938 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000939
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000940 // If we're comparing GEPs with two base pointers that only differ in type
941 // and both GEPs have only constant indices or just one use, then fold
942 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000943 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000944 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
945 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
946 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000947 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000948 Value *LOffset = EmitGEPOffset(GEPLHS);
949 Value *ROffset = EmitGEPOffset(GEPRHS);
950
951 // If we looked through an addrspacecast between different sized address
952 // spaces, the LHS and RHS pointers are different sized
953 // integers. Truncate to the smaller one.
954 Type *LHSIndexTy = LOffset->getType();
955 Type *RHSIndexTy = ROffset->getType();
956 if (LHSIndexTy != RHSIndexTy) {
957 if (LHSIndexTy->getPrimitiveSizeInBits() <
958 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000959 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000960 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000961 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000962 }
963
Craig Topperbb4069e2017-07-07 23:16:26 +0000964 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
965 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000966 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000967 }
968
Chris Lattner2188e402010-01-04 07:37:31 +0000969 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000970 // different. Try convert this to an indexed compare by looking through
971 // PHIs/casts.
972 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000973 }
974
975 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000976 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000977 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000978 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000979
980 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000981 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000982 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000983
Stuart Hastings66a82b92011-05-14 05:55:10 +0000984 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000985 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
986 // If the GEPs only differ by one index, compare it.
987 unsigned NumDifferences = 0; // Keep track of # differences.
988 unsigned DiffOperand = 0; // The operand that differs.
989 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
990 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
991 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
992 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
993 // Irreconcilable differences.
994 NumDifferences = 2;
995 break;
996 } else {
997 if (NumDifferences++) break;
998 DiffOperand = i;
999 }
1000 }
1001
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +00001002 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +00001003 return replaceInstUsesWith(I, // No comparison is needed here.
Jesper Antonsson719fa052018-09-20 13:37:28 +00001004 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +00001005
Stuart Hastings66a82b92011-05-14 05:55:10 +00001006 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +00001007 Value *LHSV = GEPLHS->getOperand(DiffOperand);
1008 Value *RHSV = GEPRHS->getOperand(DiffOperand);
1009 // Make sure we do a signed comparison here.
1010 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
1011 }
1012 }
1013
1014 // Only lower this if the icmp is the only user of the GEP or if we expect
1015 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001016 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +00001017 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
1018 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
1019 Value *L = EmitGEPOffset(GEPLHS);
1020 Value *R = EmitGEPOffset(GEPRHS);
1021 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
1022 }
1023 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001024
1025 // Try convert this to an indexed compare by looking through PHIs/casts as a
1026 // last resort.
1027 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001028}
1029
Pete Cooper980a9352016-08-12 17:13:28 +00001030Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1031 const AllocaInst *Alloca,
1032 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001033 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1034
1035 // It would be tempting to fold away comparisons between allocas and any
1036 // pointer not based on that alloca (e.g. an argument). However, even
1037 // though such pointers cannot alias, they can still compare equal.
1038 //
1039 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1040 // doesn't escape we can argue that it's impossible to guess its value, and we
1041 // can therefore act as if any such guesses are wrong.
1042 //
1043 // The code below checks that the alloca doesn't escape, and that it's only
1044 // used in a comparison once (the current instruction). The
1045 // single-comparison-use condition ensures that we're trivially folding all
1046 // comparisons against the alloca consistently, and avoids the risk of
1047 // erroneously folding a comparison of the pointer with itself.
1048
1049 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1050
Pete Cooper980a9352016-08-12 17:13:28 +00001051 SmallVector<const Use *, 32> Worklist;
1052 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001053 if (Worklist.size() >= MaxIter)
1054 return nullptr;
1055 Worklist.push_back(&U);
1056 }
1057
1058 unsigned NumCmps = 0;
1059 while (!Worklist.empty()) {
1060 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001061 const Use *U = Worklist.pop_back_val();
1062 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001063 --MaxIter;
1064
1065 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1066 isa<SelectInst>(V)) {
1067 // Track the uses.
1068 } else if (isa<LoadInst>(V)) {
1069 // Loading from the pointer doesn't escape it.
1070 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001071 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001072 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1073 if (SI->getValueOperand() == U->get())
1074 return nullptr;
1075 continue;
1076 } else if (isa<ICmpInst>(V)) {
1077 if (NumCmps++)
1078 return nullptr; // Found more than one cmp.
1079 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001080 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001081 switch (Intrin->getIntrinsicID()) {
1082 // These intrinsics don't escape or compare the pointer. Memset is safe
1083 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1084 // we don't allow stores, so src cannot point to V.
1085 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001086 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1087 continue;
1088 default:
1089 return nullptr;
1090 }
1091 } else {
1092 return nullptr;
1093 }
Pete Cooper980a9352016-08-12 17:13:28 +00001094 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001095 if (Worklist.size() >= MaxIter)
1096 return nullptr;
1097 Worklist.push_back(&U);
1098 }
1099 }
1100
1101 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001102 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001103 ICI,
1104 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1105}
1106
Craig Topperbee74792018-08-20 23:04:25 +00001107/// Fold "icmp pred (X+C), X".
1108Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001109 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001110 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001111 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001112 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001113 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001114
Chris Lattner8c92b572010-01-08 17:48:19 +00001115 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001116 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1117 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1118 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001119 Constant *R = ConstantInt::get(X->getType(),
1120 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001121 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1122 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001123
Chris Lattner2188e402010-01-04 07:37:31 +00001124 // (X+1) >u X --> X <u (0-1) --> X != 255
1125 // (X+2) >u X --> X <u (0-2) --> X <u 254
1126 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001127 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001128 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1129 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001130
Craig Topperbee74792018-08-20 23:04:25 +00001131 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001132
1133 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1134 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1135 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1136 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1137 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1138 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001139 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001140 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1141 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001142
Chris Lattner2188e402010-01-04 07:37:31 +00001143 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1144 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1145 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1146 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1147 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1148 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001149
Chris Lattner2188e402010-01-04 07:37:31 +00001150 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001151 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1152 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001153}
1154
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001155/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1156/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1157/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1158Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1159 const APInt &AP1,
1160 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001161 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1162
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001163 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1164 if (I.getPredicate() == I.ICMP_NE)
1165 Pred = CmpInst::getInversePredicate(Pred);
1166 return new ICmpInst(Pred, LHS, RHS);
1167 };
1168
David Majnemer2abb8182014-10-25 07:13:13 +00001169 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001170 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001171 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001172
1173 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001174 if (IsAShr) {
1175 if (AP2.isAllOnesValue())
1176 return nullptr;
1177 if (AP2.isNegative() != AP1.isNegative())
1178 return nullptr;
1179 if (AP2.sgt(AP1))
1180 return nullptr;
1181 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001182
David Majnemerd2056022014-10-21 19:51:55 +00001183 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001184 // 'A' must be large enough to shift out the highest set bit.
1185 return getICmp(I.ICMP_UGT, A,
1186 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001187
David Majnemerd2056022014-10-21 19:51:55 +00001188 if (AP1 == AP2)
1189 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001190
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001191 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001192 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001193 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001194 else
David Majnemere5977eb2015-09-19 00:48:26 +00001195 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001196
David Majnemerd2056022014-10-21 19:51:55 +00001197 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001198 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1199 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001200 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001201 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1202 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001203 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001204 } else if (AP1 == AP2.lshr(Shift)) {
1205 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1206 }
David Majnemerd2056022014-10-21 19:51:55 +00001207 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001208
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001209 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001210 // FIXME: This should always be handled by InstSimplify?
1211 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1212 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001213}
Chris Lattner2188e402010-01-04 07:37:31 +00001214
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001215/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1216/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1217Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1218 const APInt &AP1,
1219 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001220 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1221
David Majnemer59939ac2014-10-19 08:23:08 +00001222 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1223 if (I.getPredicate() == I.ICMP_NE)
1224 Pred = CmpInst::getInversePredicate(Pred);
1225 return new ICmpInst(Pred, LHS, RHS);
1226 };
1227
David Majnemer2abb8182014-10-25 07:13:13 +00001228 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001229 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001230 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001231
1232 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1233
1234 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001235 return getICmp(
1236 I.ICMP_UGE, A,
1237 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001238
1239 if (AP1 == AP2)
1240 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1241
1242 // Get the distance between the lowest bits that are set.
1243 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1244
1245 if (Shift > 0 && AP2.shl(Shift) == AP1)
1246 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1247
1248 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001249 // FIXME: This should always be handled by InstSimplify?
1250 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1251 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001252}
1253
Sanjay Patel06b127a2016-09-15 14:37:50 +00001254/// The caller has matched a pattern of the form:
1255/// I = icmp ugt (add (add A, B), CI2), CI1
1256/// If this is of the form:
1257/// sum = a + b
1258/// if (sum+128 >u 255)
1259/// Then replace it with llvm.sadd.with.overflow.i8.
1260///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001261static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001262 ConstantInt *CI2, ConstantInt *CI1,
1263 InstCombiner &IC) {
1264 // The transformation we're trying to do here is to transform this into an
1265 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1266 // with a narrower add, and discard the add-with-constant that is part of the
1267 // range check (if we can't eliminate it, this isn't profitable).
1268
1269 // In order to eliminate the add-with-constant, the compare can be its only
1270 // use.
1271 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1272 if (!AddWithCst->hasOneUse())
1273 return nullptr;
1274
1275 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1276 if (!CI2->getValue().isPowerOf2())
1277 return nullptr;
1278 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1279 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1280 return nullptr;
1281
1282 // The width of the new add formed is 1 more than the bias.
1283 ++NewWidth;
1284
1285 // Check to see that CI1 is an all-ones value with NewWidth bits.
1286 if (CI1->getBitWidth() == NewWidth ||
1287 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1288 return nullptr;
1289
1290 // This is only really a signed overflow check if the inputs have been
1291 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1292 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1293 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1294 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1295 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1296 return nullptr;
1297
1298 // In order to replace the original add with a narrower
1299 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1300 // and truncates that discard the high bits of the add. Verify that this is
1301 // the case.
1302 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1303 for (User *U : OrigAdd->users()) {
1304 if (U == AddWithCst)
1305 continue;
1306
1307 // Only accept truncates for now. We would really like a nice recursive
1308 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1309 // chain to see which bits of a value are actually demanded. If the
1310 // original add had another add which was then immediately truncated, we
1311 // could still do the transformation.
1312 TruncInst *TI = dyn_cast<TruncInst>(U);
1313 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1314 return nullptr;
1315 }
1316
1317 // If the pattern matches, truncate the inputs to the narrower type and
1318 // use the sadd_with_overflow intrinsic to efficiently compute both the
1319 // result and the overflow bit.
1320 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
James Y Knight7976eb52019-02-01 20:43:25 +00001321 Function *F = Intrinsic::getDeclaration(
1322 I.getModule(), Intrinsic::sadd_with_overflow, NewType);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001323
Craig Topperbb4069e2017-07-07 23:16:26 +00001324 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001325
1326 // Put the new code above the original add, in case there are any uses of the
1327 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001328 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001329
Craig Topperbb4069e2017-07-07 23:16:26 +00001330 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1331 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1332 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1333 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1334 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001335
1336 // The inner add was the result of the narrow add, zero extended to the
1337 // wider type. Replace it with the result computed by the intrinsic.
1338 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1339
1340 // The original icmp gets replaced with the overflow value.
1341 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1342}
1343
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001344/// If we have:
1345/// icmp eq/ne (urem/srem %x, %y), 0
1346/// iff %y is a power-of-two, we can replace this with a bit test:
1347/// icmp eq/ne (and %x, (add %y, -1)), 0
1348Instruction *InstCombiner::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) {
1349 // This fold is only valid for equality predicates.
1350 if (!I.isEquality())
1351 return nullptr;
1352 ICmpInst::Predicate Pred;
1353 Value *X, *Y, *Zero;
1354 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))),
1355 m_CombineAnd(m_Zero(), m_Value(Zero)))))
1356 return nullptr;
1357 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I))
1358 return nullptr;
1359 // This may increase instruction count, we don't enforce that Y is a constant.
1360 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType()));
1361 Value *Masked = Builder.CreateAnd(X, Mask);
1362 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero);
1363}
1364
Roman Lebedevf55818e2019-07-01 09:41:43 +00001365// Handle icmp pred X, 0
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001366Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1367 CmpInst::Predicate Pred = Cmp.getPredicate();
Roman Lebedevf55818e2019-07-01 09:41:43 +00001368 if (!match(Cmp.getOperand(1), m_Zero()))
1369 return nullptr;
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001370
Roman Lebedevf55818e2019-07-01 09:41:43 +00001371 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1372 if (Pred == ICmpInst::ICMP_SGT) {
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001373 Value *A, *B;
Roman Lebedevf55818e2019-07-01 09:41:43 +00001374 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B);
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001375 if (SPR.Flavor == SPF_SMIN) {
1376 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1377 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1378 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1379 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1380 }
1381 }
Roman Lebedevf55818e2019-07-01 09:41:43 +00001382
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001383 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp))
1384 return New;
1385
Roman Lebedevf55818e2019-07-01 09:41:43 +00001386 // Given:
1387 // icmp eq/ne (urem %x, %y), 0
1388 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem':
1389 // icmp eq/ne %x, 0
1390 Value *X, *Y;
1391 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) &&
1392 ICmpInst::isEquality(Pred)) {
1393 KnownBits XKnown = computeKnownBits(X, 0, &Cmp);
1394 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp);
1395 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2)
1396 return new ICmpInst(Pred, X, Cmp.getOperand(1));
1397 }
1398
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001399 return nullptr;
1400}
1401
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001402/// Fold icmp Pred X, C.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001403/// TODO: This code structure does not make sense. The saturating add fold
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001404/// should be moved to some other helper and extended as noted below (it is also
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001405/// possible that code has been made unnecessary - do we canonicalize IR to
1406/// overflow/saturating intrinsics or not?).
Sanjay Patel97459832016-09-15 15:11:12 +00001407Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
Sanjay Patel97459832016-09-15 15:11:12 +00001408 // Match the following pattern, which is a common idiom when writing
1409 // overflow-safe integer arithmetic functions. The source performs an addition
1410 // in wider type and explicitly checks for overflow using comparisons against
1411 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1412 //
1413 // TODO: This could probably be generalized to handle other overflow-safe
1414 // operations if we worked out the formulas to compute the appropriate magic
1415 // constants.
1416 //
1417 // sum = a + b
1418 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001419 CmpInst::Predicate Pred = Cmp.getPredicate();
1420 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1);
1421 Value *A, *B;
1422 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1423 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) &&
1424 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
1425 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this))
1426 return Res;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001427
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001428 return nullptr;
1429}
1430
1431/// Canonicalize icmp instructions based on dominating conditions.
1432Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) {
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001433 // This is a cheap/incomplete check for dominance - just match a single
1434 // predecessor with a conditional branch.
1435 BasicBlock *CmpBB = Cmp.getParent();
1436 BasicBlock *DomBB = CmpBB->getSinglePredecessor();
1437 if (!DomBB)
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001438 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001439
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001440 Value *DomCond;
Sanjay Patel97459832016-09-15 15:11:12 +00001441 BasicBlock *TrueBB, *FalseBB;
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001442 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB)))
1443 return nullptr;
1444
1445 assert((TrueBB == CmpBB || FalseBB == CmpBB) &&
1446 "Predecessor block does not point to successor?");
1447
1448 // The branch should get simplified. Don't bother simplifying this condition.
1449 if (TrueBB == FalseBB)
1450 return nullptr;
1451
Sanjay Patelbaffae92018-12-05 15:04:00 +00001452 // Try to simplify this compare to T/F based on the dominating condition.
1453 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB);
1454 if (Imp)
1455 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp));
1456
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001457 CmpInst::Predicate Pred = Cmp.getPredicate();
1458 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1);
1459 ICmpInst::Predicate DomPred;
1460 const APInt *C, *DomC;
1461 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) &&
1462 match(Y, m_APInt(C))) {
1463 // We have 2 compares of a variable with constants. Calculate the constant
1464 // ranges of those compares to see if we can transform the 2nd compare:
1465 // DomBB:
1466 // DomCond = icmp DomPred X, DomC
1467 // br DomCond, CmpBB, FalseBB
1468 // CmpBB:
1469 // Cmp = icmp Pred X, C
1470 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C);
Sanjay Patel97459832016-09-15 15:11:12 +00001471 ConstantRange DominatingCR =
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001472 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC)
1473 : ConstantRange::makeExactICmpRegion(
1474 CmpInst::getInversePredicate(DomPred), *DomC);
Sanjay Patel97459832016-09-15 15:11:12 +00001475 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1476 ConstantRange Difference = DominatingCR.difference(CR);
1477 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001478 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001479 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001480 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001481
Sanjay Patel97459832016-09-15 15:11:12 +00001482 // Canonicalizing a sign bit comparison that gets used in a branch,
1483 // pessimizes codegen by generating branch on zero instruction instead
1484 // of a test and branch. So we avoid canonicalizing in such situations
1485 // because test and branch instruction has better branch displacement
1486 // than compare and branch instruction.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001487 bool UnusedBit;
1488 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit);
Eric Christophera95aac32017-06-30 01:57:48 +00001489 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1490 return nullptr;
1491
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001492 if (const APInt *EqC = Intersection.getSingleElement())
1493 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC));
1494 if (const APInt *NeC = Difference.getSingleElement())
1495 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001496 }
1497
1498 return nullptr;
1499}
1500
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001501/// Fold icmp (trunc X, Y), C.
1502Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001503 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001504 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001505 ICmpInst::Predicate Pred = Cmp.getPredicate();
1506 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001507 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001508 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1509 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001510 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001511 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1512 ConstantInt::get(V->getType(), 1));
1513 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001514
1515 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001516 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1517 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001518 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1519 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001520 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001521
1522 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001523 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001524 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001525 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001526 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001527 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001528 }
1529 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001530
Sanjay Patela3f4f082016-08-16 17:54:36 +00001531 return nullptr;
1532}
1533
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001534/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001535Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1536 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001537 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001538 Value *X = Xor->getOperand(0);
1539 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001540 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001541 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001542 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001543
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001544 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1545 // fold the xor.
1546 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001547 bool TrueIfSigned = false;
1548 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001549
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001550 // If the sign bit of the XorCst is not set, there is no change to
1551 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001552 if (!XorC->isNegative()) {
1553 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001554 Worklist.Add(Xor);
1555 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001556 }
1557
Craig Topperdf63b962017-10-03 19:14:23 +00001558 // Emit the opposite comparison.
1559 if (TrueIfSigned)
1560 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1561 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001562 else
Craig Topperdf63b962017-10-03 19:14:23 +00001563 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1564 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001565 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001566
1567 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001568 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1569 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001570 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1571 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001572 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001573 }
1574
Craig Topperbcfd2d12017-04-20 16:56:25 +00001575 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001576 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1577 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1578 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001579 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001580 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001581 }
1582 }
1583
Sanjay Patel26725bd2018-09-11 22:00:15 +00001584 // Mask constant magic can eliminate an 'xor' with unsigned compares.
1585 if (Pred == ICmpInst::ICMP_UGT) {
1586 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2)
1587 if (*XorC == ~C && (C + 1).isPowerOf2())
1588 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
1589 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2)
1590 if (*XorC == C && (C + 1).isPowerOf2())
1591 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
1592 }
1593 if (Pred == ICmpInst::ICMP_ULT) {
1594 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2)
1595 if (*XorC == -C && C.isPowerOf2())
1596 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1597 ConstantInt::get(X->getType(), ~C));
1598 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2)
1599 if (*XorC == C && (-C).isPowerOf2())
1600 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1601 ConstantInt::get(X->getType(), ~C));
1602 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001603 return nullptr;
1604}
1605
Sanjay Patel14e0e182016-08-26 18:28:46 +00001606/// Fold icmp (and (sh X, Y), C2), C1.
1607Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001608 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001609 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1610 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001611 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001612
Sanjay Patelda9c5622016-08-26 17:15:22 +00001613 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1614 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1615 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001616 // This seemingly simple opportunity to fold away a shift turns out to be
1617 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001618 unsigned ShiftOpcode = Shift->getOpcode();
1619 bool IsShl = ShiftOpcode == Instruction::Shl;
1620 const APInt *C3;
1621 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001622 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001623 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001624 // For a left shift, we can fold if the comparison is not signed. We can
1625 // also fold a signed comparison if the mask value and comparison value
1626 // are not negative. These constraints may not be obvious, but we can
1627 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001628 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001629 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001630 } else {
1631 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001632 // For a logical right shift, we can fold if the comparison is not signed.
1633 // We can also fold a signed comparison if the shifted mask value and the
1634 // shifted comparison value are not negative. These constraints may not be
1635 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001636 // For an arithmetic shift right we can do the same, if we ensure
1637 // the And doesn't use any bits being shifted in. Normally these would
1638 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1639 // additional user.
1640 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1641 if (!Cmp.isSigned() ||
1642 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1643 CanFold = true;
1644 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001645 }
1646
Sanjay Patelda9c5622016-08-26 17:15:22 +00001647 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001648 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001649 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001650 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001651 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001652 // If we shifted bits out, the fold is not going to work out. As a
1653 // special case, check to see if this means that the result is always
1654 // true or false now.
1655 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001656 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001657 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001658 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001659 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001660 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001661 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001662 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001663 And->setOperand(0, Shift->getOperand(0));
1664 Worklist.Add(Shift); // Shift is dead.
1665 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001666 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001667 }
1668 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001669
Sanjay Patelda9c5622016-08-26 17:15:22 +00001670 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1671 // preferable because it allows the C2 << Y expression to be hoisted out of a
1672 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001673 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001674 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1675 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001676 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001677 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1678 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001679
Sanjay Patelda9c5622016-08-26 17:15:22 +00001680 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001681 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001682 Cmp.setOperand(0, NewAnd);
1683 return &Cmp;
1684 }
1685
Sanjay Patel14e0e182016-08-26 18:28:46 +00001686 return nullptr;
1687}
1688
1689/// Fold icmp (and X, C2), C1.
1690Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1691 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001692 const APInt &C1) {
Huihui Zhang670778c2019-06-19 17:31:39 +00001693 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE;
1694
Sanjay Patel05aadf82018-10-10 20:47:46 +00001695 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1
1696 // TODO: We canonicalize to the longer form for scalars because we have
1697 // better analysis/folds for icmp, and codegen may be better with icmp.
Huihui Zhang670778c2019-06-19 17:31:39 +00001698 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isNullValue() &&
1699 match(And->getOperand(1), m_One()))
Sanjay Patel05aadf82018-10-10 20:47:46 +00001700 return new TruncInst(And->getOperand(0), Cmp.getType());
1701
Sanjay Patel6b490972016-09-04 14:32:15 +00001702 const APInt *C2;
Huihui Zhang670778c2019-06-19 17:31:39 +00001703 Value *X;
1704 if (!match(And, m_And(m_Value(X), m_APInt(C2))))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001705 return nullptr;
1706
Huihui Zhang670778c2019-06-19 17:31:39 +00001707 // Don't perform the following transforms if the AND has multiple uses
Craig Topper8bf62212017-09-26 18:47:25 +00001708 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001709 return nullptr;
1710
Huihui Zhang670778c2019-06-19 17:31:39 +00001711 if (Cmp.isEquality() && C1.isNullValue()) {
1712 // Restrict this fold to single-use 'and' (PR10267).
1713 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0
1714 if (C2->isSignMask()) {
1715 Constant *Zero = Constant::getNullValue(X->getType());
1716 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
1717 return new ICmpInst(NewPred, X, Zero);
1718 }
Huihui Zhang46266132019-06-25 00:09:10 +00001719
1720 // Restrict this fold only for single-use 'and' (PR10267).
1721 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two.
1722 if ((~(*C2) + 1).isPowerOf2()) {
1723 Constant *NegBOC =
1724 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1)));
1725 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
1726 return new ICmpInst(NewPred, X, NegBOC);
1727 }
Huihui Zhang670778c2019-06-19 17:31:39 +00001728 }
1729
Sanjay Patel6b490972016-09-04 14:32:15 +00001730 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1731 // the input width without changing the value produced, eliminate the cast:
1732 //
1733 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1734 //
1735 // We can do this transformation if the constants do not have their sign bits
1736 // set or if it is an equality comparison. Extending a relational comparison
1737 // when we're checking the sign bit would not work.
1738 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001739 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001740 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001741 // TODO: Is this a good transform for vectors? Wider types may reduce
1742 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001743 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001744 if (!Cmp.getType()->isVectorTy()) {
1745 Type *WideType = W->getType();
1746 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001747 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001748 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001749 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001750 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001751 }
1752 }
1753
Craig Topper8ed1aa92017-10-03 05:31:07 +00001754 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001755 return I;
1756
Sanjay Patelda9c5622016-08-26 17:15:22 +00001757 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001758 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001759 //
1760 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001761 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001762 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001763 Constant *One = cast<Constant>(And->getOperand(1));
1764 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001765 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001766 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1767 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1768 unsigned UsesRemoved = 0;
1769 if (And->hasOneUse())
1770 ++UsesRemoved;
1771 if (Or->hasOneUse())
1772 ++UsesRemoved;
1773 if (LShr->hasOneUse())
1774 ++UsesRemoved;
1775
1776 // Compute A & ((1 << B) | 1)
1777 Value *NewOr = nullptr;
1778 if (auto *C = dyn_cast<Constant>(B)) {
1779 if (UsesRemoved >= 1)
1780 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1781 } else {
1782 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001783 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1784 /*HasNUW=*/true),
1785 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001786 }
1787 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001788 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001789 Cmp.setOperand(0, NewAnd);
1790 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001791 }
1792 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001793 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001794
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001795 return nullptr;
1796}
1797
1798/// Fold icmp (and X, Y), C.
1799Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1800 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001801 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001802 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1803 return I;
1804
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001805 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001806
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001807 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1808 Value *X = And->getOperand(0);
1809 Value *Y = And->getOperand(1);
1810 if (auto *LI = dyn_cast<LoadInst>(X))
1811 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1812 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001813 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001814 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1815 ConstantInt *C2 = cast<ConstantInt>(Y);
1816 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001817 return Res;
1818 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001819
1820 if (!Cmp.isEquality())
1821 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001822
1823 // X & -C == -C -> X > u ~C
1824 // X & -C != -C -> X <= u ~C
1825 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001826 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001827 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1828 : CmpInst::ICMP_ULE;
1829 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1830 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001831
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001832 // (X & C2) == 0 -> (trunc X) >= 0
1833 // (X & C2) != 0 -> (trunc X) < 0
1834 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1835 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001836 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001837 int32_t ExactLogBase2 = C2->exactLogBase2();
1838 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1839 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1840 if (And->getType()->isVectorTy())
1841 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001842 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001843 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1844 : CmpInst::ICMP_SLT;
1845 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001846 }
1847 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001848
Sanjay Patela3f4f082016-08-16 17:54:36 +00001849 return nullptr;
1850}
1851
Sanjay Patel943e92e2016-08-17 16:30:43 +00001852/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001853Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001854 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001855 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001856 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001857 // icmp slt signum(V) 1 --> icmp slt V, 1
1858 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001859 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001860 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1861 ConstantInt::get(V->getType(), 1));
1862 }
1863
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001864 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1);
1865 if (Cmp.isEquality() && Cmp.getOperand(1) == OrOp1) {
1866 // X | C == C --> X <=u C
1867 // X | C != C --> X >u C
1868 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1869 if ((C + 1).isPowerOf2()) {
1870 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1871 return new ICmpInst(Pred, OrOp0, OrOp1);
1872 }
1873 // More general: are all bits outside of a mask constant set or not set?
1874 // X | C == C --> (X & ~C) == 0
1875 // X | C != C --> (X & ~C) != 0
1876 if (Or->hasOneUse()) {
1877 Value *A = Builder.CreateAnd(OrOp0, ~C);
1878 return new ICmpInst(Pred, A, ConstantInt::getNullValue(OrOp0->getType()));
1879 }
Sanjay Patel50c82c42017-04-05 17:57:05 +00001880 }
1881
Craig Topper8ed1aa92017-10-03 05:31:07 +00001882 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001883 return nullptr;
1884
1885 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001886 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001887 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1888 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001889 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001890 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001891 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001892 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001893 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1894 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1895 }
1896
1897 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1898 // a shorter form that has more potential to be folded even further.
1899 Value *X1, *X2, *X3, *X4;
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001900 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1901 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001902 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1903 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1904 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1905 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1906 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1907 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001908 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001909
Sanjay Patela3f4f082016-08-16 17:54:36 +00001910 return nullptr;
1911}
1912
Sanjay Patel63478072016-08-18 15:44:44 +00001913/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001914Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1915 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001916 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001917 const APInt *MulC;
1918 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001919 return nullptr;
1920
Sanjay Patel63478072016-08-18 15:44:44 +00001921 // If this is a test of the sign bit and the multiply is sign-preserving with
1922 // a constant operand, use the multiply LHS operand instead.
1923 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001924 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001925 if (MulC->isNegative())
1926 Pred = ICmpInst::getSwappedPredicate(Pred);
1927 return new ICmpInst(Pred, Mul->getOperand(0),
1928 Constant::getNullValue(Mul->getType()));
1929 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001930
1931 return nullptr;
1932}
1933
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001934/// Fold icmp (shl 1, Y), C.
1935static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001936 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001937 Value *Y;
1938 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1939 return nullptr;
1940
1941 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001942 unsigned TypeBits = C.getBitWidth();
1943 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001944 ICmpInst::Predicate Pred = Cmp.getPredicate();
1945 if (Cmp.isUnsigned()) {
1946 // (1 << Y) pred C -> Y pred Log2(C)
1947 if (!CIsPowerOf2) {
1948 // (1 << Y) < 30 -> Y <= 4
1949 // (1 << Y) <= 30 -> Y <= 4
1950 // (1 << Y) >= 30 -> Y > 4
1951 // (1 << Y) > 30 -> Y > 4
1952 if (Pred == ICmpInst::ICMP_ULT)
1953 Pred = ICmpInst::ICMP_ULE;
1954 else if (Pred == ICmpInst::ICMP_UGE)
1955 Pred = ICmpInst::ICMP_UGT;
1956 }
1957
1958 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1959 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001960 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001961 if (CLog2 == TypeBits - 1) {
1962 if (Pred == ICmpInst::ICMP_UGE)
1963 Pred = ICmpInst::ICMP_EQ;
1964 else if (Pred == ICmpInst::ICMP_ULT)
1965 Pred = ICmpInst::ICMP_NE;
1966 }
1967 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1968 } else if (Cmp.isSigned()) {
1969 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001970 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001971 // (1 << Y) <= -1 -> Y == 31
1972 if (Pred == ICmpInst::ICMP_SLE)
1973 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1974
1975 // (1 << Y) > -1 -> Y != 31
1976 if (Pred == ICmpInst::ICMP_SGT)
1977 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001978 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001979 // (1 << Y) < 0 -> Y == 31
1980 // (1 << Y) <= 0 -> Y == 31
1981 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1982 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1983
1984 // (1 << Y) >= 0 -> Y != 31
1985 // (1 << Y) > 0 -> Y != 31
1986 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1987 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1988 }
1989 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001990 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001991 }
1992
1993 return nullptr;
1994}
1995
Sanjay Patel38b75062016-08-19 17:20:37 +00001996/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001997Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1998 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001999 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002000 const APInt *ShiftVal;
2001 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002002 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002003
Sanjay Patelfa7de602016-08-19 22:33:26 +00002004 const APInt *ShiftAmt;
2005 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00002006 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00002007
Sanjay Patel38b75062016-08-19 17:20:37 +00002008 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00002009 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002010 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00002011 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002012 return nullptr;
2013
Sanjay Patele38e79c2016-08-19 17:34:05 +00002014 ICmpInst::Predicate Pred = Cmp.getPredicate();
2015 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00002016 Type *ShType = Shl->getType();
2017
Sanjay Patel291c3d82017-01-19 16:12:10 +00002018 // NSW guarantees that we are only shifting out sign bits from the high bits,
2019 // so we can ASHR the compare constant without needing a mask and eliminate
2020 // the shift.
2021 if (Shl->hasNoSignedWrap()) {
2022 if (Pred == ICmpInst::ICMP_SGT) {
2023 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002024 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002025 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2026 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002027 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2028 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002029 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002030 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2031 }
2032 if (Pred == ICmpInst::ICMP_SLT) {
2033 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
2034 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
2035 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
2036 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00002037 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
2038 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00002039 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2040 }
2041 // If this is a signed comparison to 0 and the shift is sign preserving,
2042 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
2043 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002044 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00002045 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
2046 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002047
Sanjay Patel291c3d82017-01-19 16:12:10 +00002048 // NUW guarantees that we are only shifting out zero bits from the high bits,
2049 // so we can LSHR the compare constant without needing a mask and eliminate
2050 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00002051 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00002052 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00002053 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002054 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002055 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2056 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002057 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2058 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002059 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00002060 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2061 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002062 if (Pred == ICmpInst::ICMP_ULT) {
2063 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
2064 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
2065 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
2066 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00002067 assert(C.ugt(0) && "ult 0 should have been eliminated");
2068 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00002069 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2070 }
2071 }
2072
Sanjay Patel291c3d82017-01-19 16:12:10 +00002073 if (Cmp.isEquality() && Shl->hasOneUse()) {
2074 // Strength-reduce the shift into an 'and'.
2075 Constant *Mask = ConstantInt::get(
2076 ShType,
2077 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00002078 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00002079 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00002080 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002081 }
2082
Sanjay Patela3f4f082016-08-16 17:54:36 +00002083 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
2084 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002085 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00002086 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00002087 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00002088 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00002089 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002090 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00002091 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00002092 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00002093 }
2094
Huihui Zhangb90cb572019-06-25 20:44:52 +00002095 // Simplify 'shl' inequality test into 'and' equality test.
2096 if (Cmp.isUnsigned() && Shl->hasOneUse()) {
2097 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0
2098 if ((C + 1).isPowerOf2() &&
2099 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) {
2100 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue()));
2101 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ
2102 : ICmpInst::ICMP_NE,
2103 And, Constant::getNullValue(ShType));
2104 }
2105 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0
2106 if (C.isPowerOf2() &&
2107 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) {
2108 Value *And =
2109 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue()));
2110 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ
2111 : ICmpInst::ICMP_NE,
2112 And, Constant::getNullValue(ShType));
2113 }
2114 }
2115
Sanjay Patel643d21a2016-08-21 17:10:07 +00002116 // Transform (icmp pred iM (shl iM %v, N), C)
2117 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2118 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002119 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002120 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002121 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002122 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002123 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00002124 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002125 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002126 if (ShType->isVectorTy())
2127 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002128 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00002129 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00002130 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002131 }
2132
2133 return nullptr;
2134}
2135
Sanjay Patela3920492016-08-22 20:45:06 +00002136/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002137Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2138 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002139 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002140 // An exact shr only shifts out zero bits, so:
2141 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002142 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002143 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002144 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00002145 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002146 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002147
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002148 const APInt *ShiftVal;
2149 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002150 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002151
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002152 const APInt *ShiftAmt;
2153 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002154 return nullptr;
2155
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002156 // Check that the shift amount is in range. If not, don't perform undefined
2157 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002158 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002159 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002160 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2161 return nullptr;
2162
Sanjay Pateld64e9882016-08-23 22:05:55 +00002163 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002164 bool IsExact = Shr->isExact();
2165 Type *ShrTy = Shr->getType();
2166 // TODO: If we could guarantee that InstSimplify would handle all of the
2167 // constant-value-based preconditions in the folds below, then we could assert
2168 // those conditions rather than checking them. This is difficult because of
2169 // undef/poison (PR34838).
2170 if (IsAShr) {
2171 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2172 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2173 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2174 APInt ShiftedC = C.shl(ShAmtVal);
2175 if (ShiftedC.ashr(ShAmtVal) == C)
2176 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2177 }
2178 if (Pred == CmpInst::ICMP_SGT) {
2179 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2180 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2181 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2182 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2183 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2184 }
2185 } else {
2186 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2187 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2188 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2189 APInt ShiftedC = C.shl(ShAmtVal);
2190 if (ShiftedC.lshr(ShAmtVal) == C)
2191 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2192 }
2193 if (Pred == CmpInst::ICMP_UGT) {
2194 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2195 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2196 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2197 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2198 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002199 }
2200
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002201 if (!Cmp.isEquality())
2202 return nullptr;
2203
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002204 // Handle equality comparisons of shift-by-constant.
2205
Sanjay Patel8e297742016-08-24 13:55:55 +00002206 // If the comparison constant changes with the shift, the comparison cannot
2207 // succeed (bits of the comparison constant cannot match the shifted value).
2208 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002209 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2210 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002211 "Expected icmp+shr simplify did not occur.");
2212
Sanjay Patel934738a2017-10-15 15:39:15 +00002213 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002214 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002215 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002216 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002217
Sanjay Patel934738a2017-10-15 15:39:15 +00002218 if (Shr->hasOneUse()) {
2219 // Canonicalize the shift into an 'and':
2220 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002221 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002222 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002223 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002224 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002225 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002226
2227 return nullptr;
2228}
2229
Sanjay Patel12a41052016-08-18 17:37:26 +00002230/// Fold icmp (udiv X, Y), C.
2231Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002232 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002233 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002234 const APInt *C2;
2235 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2236 return nullptr;
2237
Craig Topper29c282e2017-06-07 07:40:29 +00002238 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002239
2240 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2241 Value *Y = UDiv->getOperand(1);
2242 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002243 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002244 "icmp ugt X, UINT_MAX should have been simplified already.");
2245 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002246 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002247 }
2248
2249 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2250 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002251 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002252 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002253 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002254 }
2255
2256 return nullptr;
2257}
2258
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002259/// Fold icmp ({su}div X, Y), C.
2260Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2261 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002262 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002263 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002264 // Fold this div into the comparison, producing a range check.
2265 // Determine, based on the divide type, what the range is being
2266 // checked. If there is an overflow on the low or high side, remember
2267 // it, otherwise compute the range [low, hi) bounding the new value.
2268 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002269 const APInt *C2;
2270 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002271 return nullptr;
2272
Sanjay Patel16554142016-08-24 23:03:36 +00002273 // FIXME: If the operand types don't match the type of the divide
2274 // then don't attempt this transform. The code below doesn't have the
2275 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002276 // vice versa). This is because (x /s C2) <s C produces different
2277 // results than (x /s C2) <u C or (x /u C2) <s C or even
2278 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002279 // work. :( The if statement below tests that condition and bails
2280 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002281 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2282 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002283 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002284
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002285 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2286 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2287 // division-by-constant cases should be present, we can not assert that they
2288 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002289 if (C2->isNullValue() || C2->isOneValue() ||
2290 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002291 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002292
Craig Topper6e025a32017-10-01 23:53:54 +00002293 // Compute Prod = C * C2. We are essentially solving an equation of
2294 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002295 // By solving for X, we can turn this into a range check instead of computing
2296 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002297 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002298
Sanjay Patel541aef42016-08-31 21:57:21 +00002299 // Determine if the product overflows by seeing if the product is not equal to
2300 // the divide. Make sure we do the same kind of divide as in the LHS
2301 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002302 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002303
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002304 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002305
2306 // If the division is known to be exact, then there is no remainder from the
2307 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002308 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002309
2310 // Figure out the interval that is being checked. For example, a comparison
2311 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2312 // Compute this interval based on the constants involved and the signedness of
2313 // the compare/divide. This computes a half-open interval, keeping track of
2314 // whether either value in the interval overflows. After analysis each
2315 // overflow variable is set to 0 if it's corresponding bound variable is valid
2316 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2317 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002318 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002319
2320 if (!DivIsSigned) { // udiv
2321 // e.g. X/5 op 3 --> [15, 20)
2322 LoBound = Prod;
2323 HiOverflow = LoOverflow = ProdOV;
2324 if (!HiOverflow) {
2325 // If this is not an exact divide, then many values in the range collapse
2326 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002327 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002328 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002329 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002330 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002331 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002332 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002333 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002334 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002335 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2336 HiOverflow = LoOverflow = ProdOV;
2337 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002338 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002339 } else { // (X / pos) op neg
2340 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002341 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002342 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2343 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002344 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002345 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002346 }
2347 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002348 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002349 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002350 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002351 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002352 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002353 LoBound = RangeSize + 1;
2354 HiBound = -RangeSize;
2355 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002356 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002357 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002358 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002359 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002360 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002361 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002362 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2363 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002364 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002365 } else { // (X / neg) op neg
2366 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2367 LoOverflow = HiOverflow = ProdOV;
2368 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002369 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002370 }
2371
2372 // Dividing by a negative swaps the condition. LT <-> GT
2373 Pred = ICmpInst::getSwappedPredicate(Pred);
2374 }
2375
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002376 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002377 switch (Pred) {
2378 default: llvm_unreachable("Unhandled icmp opcode!");
2379 case ICmpInst::ICMP_EQ:
2380 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002381 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002382 if (HiOverflow)
2383 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002384 ICmpInst::ICMP_UGE, X,
2385 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002386 if (LoOverflow)
2387 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002388 ICmpInst::ICMP_ULT, X,
2389 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002390 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002391 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002392 case ICmpInst::ICMP_NE:
2393 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002394 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002395 if (HiOverflow)
2396 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002397 ICmpInst::ICMP_ULT, X,
2398 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002399 if (LoOverflow)
2400 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002401 ICmpInst::ICMP_UGE, X,
2402 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002403 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002404 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002405 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002406 case ICmpInst::ICMP_ULT:
2407 case ICmpInst::ICMP_SLT:
2408 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002409 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002410 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002411 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002412 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002413 case ICmpInst::ICMP_UGT:
2414 case ICmpInst::ICMP_SGT:
2415 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002416 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002417 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002418 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002419 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002420 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2421 ConstantInt::get(Div->getType(), HiBound));
2422 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2423 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002424 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002425
2426 return nullptr;
2427}
2428
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002429/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002430Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2431 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002432 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002433 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2434 ICmpInst::Predicate Pred = Cmp.getPredicate();
Luqman Aden8911c5b2019-04-04 07:08:30 +00002435 const APInt *C2;
2436 APInt SubResult;
2437
Philip Reames764b0fd2019-08-21 15:51:57 +00002438 // icmp eq/ne (sub C, Y), C -> icmp eq/ne Y, 0
2439 if (match(X, m_APInt(C2)) && *C2 == C && Cmp.isEquality())
2440 return new ICmpInst(Cmp.getPredicate(), Y,
2441 ConstantInt::get(Y->getType(), 0));
2442
Luqman Aden8911c5b2019-04-04 07:08:30 +00002443 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C)
2444 if (match(X, m_APInt(C2)) &&
2445 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) ||
2446 (Cmp.isSigned() && Sub->hasNoSignedWrap())) &&
2447 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned()))
2448 return new ICmpInst(Cmp.getSwappedPredicate(), Y,
2449 ConstantInt::get(Y->getType(), SubResult));
Sanjay Patel886a5422016-09-15 18:05:17 +00002450
2451 // The following transforms are only worth it if the only user of the subtract
2452 // is the icmp.
2453 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002454 return nullptr;
2455
Sanjay Patel886a5422016-09-15 18:05:17 +00002456 if (Sub->hasNoSignedWrap()) {
2457 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002458 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002459 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002460
Sanjay Patel886a5422016-09-15 18:05:17 +00002461 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002462 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002463 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2464
2465 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002466 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002467 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2468
2469 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002470 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002471 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2472 }
2473
Sanjay Patel886a5422016-09-15 18:05:17 +00002474 if (!match(X, m_APInt(C2)))
2475 return nullptr;
2476
2477 // C2 - Y <u C -> (Y | (C - 1)) == C2
2478 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002479 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2480 (*C2 & (C - 1)) == (C - 1))
2481 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002482
2483 // C2 - Y >u C -> (Y | C) != C2
2484 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002485 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2486 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002487
2488 return nullptr;
2489}
2490
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002491/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002492Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2493 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002494 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002495 Value *Y = Add->getOperand(1);
2496 const APInt *C2;
2497 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002498 return nullptr;
2499
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002500 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002501 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002502 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002503 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002504
Tim Northover12c1f762018-09-10 14:26:44 +00002505 if (!Add->hasOneUse())
2506 return nullptr;
2507
Sanjay Patel45b7e692017-02-12 16:40:30 +00002508 // If the add does not wrap, we can always adjust the compare by subtracting
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002509 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE
2510 // are canonicalized to SGT/SLT/UGT/ULT.
2511 if ((Add->hasNoSignedWrap() &&
2512 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) ||
2513 (Add->hasNoUnsignedWrap() &&
2514 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) {
Sanjay Patel45b7e692017-02-12 16:40:30 +00002515 bool Overflow;
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002516 APInt NewC =
2517 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002518 // If there is overflow, the result must be true or false.
2519 // TODO: Can we assert there is no overflow because InstSimplify always
2520 // handles those cases?
2521 if (!Overflow)
2522 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2523 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2524 }
2525
Craig Topper8ed1aa92017-10-03 05:31:07 +00002526 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002527 const APInt &Upper = CR.getUpper();
2528 const APInt &Lower = CR.getLower();
2529 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002530 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002531 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002532 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002533 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002534 } else {
2535 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002536 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002537 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002538 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002539 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002540
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002541 // X+C <u C2 -> (X & -C2) == C
2542 // iff C & (C2-1) == 0
2543 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002544 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2545 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002546 ConstantExpr::getNeg(cast<Constant>(Y)));
2547
2548 // X+C >u C2 -> (X & ~C2) != C
2549 // iff C & C2 == 0
2550 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002551 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2552 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002553 ConstantExpr::getNeg(cast<Constant>(Y)));
2554
Sanjay Patela3f4f082016-08-16 17:54:36 +00002555 return nullptr;
2556}
2557
Anna Thomasd67165c2017-06-23 13:41:45 +00002558bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2559 Value *&RHS, ConstantInt *&Less,
2560 ConstantInt *&Equal,
2561 ConstantInt *&Greater) {
2562 // TODO: Generalize this to work with other comparison idioms or ensure
2563 // they get canonicalized into this form.
2564
2565 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2566 // Greater), where Equal, Less and Greater are placeholders for any three
2567 // constants.
2568 ICmpInst::Predicate PredA, PredB;
2569 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2570 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2571 PredA == ICmpInst::ICMP_EQ &&
2572 match(SI->getFalseValue(),
2573 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2574 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2575 PredB == ICmpInst::ICMP_SLT) {
2576 return true;
2577 }
2578 return false;
2579}
2580
2581Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002582 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002583 ConstantInt *C) {
2584
2585 assert(C && "Cmp RHS should be a constant int!");
2586 // If we're testing a constant value against the result of a three way
2587 // comparison, the result can be expressed directly in terms of the
2588 // original values being compared. Note: We could possibly be more
2589 // aggressive here and remove the hasOneUse test. The original select is
2590 // really likely to simplify or sink when we remove a test of the result.
2591 Value *OrigLHS, *OrigRHS;
2592 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2593 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002594 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2595 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002596 assert(C1LessThan && C2Equal && C3GreaterThan);
2597
2598 bool TrueWhenLessThan =
2599 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2600 ->isAllOnesValue();
2601 bool TrueWhenEqual =
2602 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2603 ->isAllOnesValue();
2604 bool TrueWhenGreaterThan =
2605 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2606 ->isAllOnesValue();
2607
2608 // This generates the new instruction that will replace the original Cmp
2609 // Instruction. Instead of enumerating the various combinations when
2610 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2611 // false, we rely on chaining of ORs and future passes of InstCombine to
2612 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2613
2614 // When none of the three constants satisfy the predicate for the RHS (C),
2615 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002616 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002617 if (TrueWhenLessThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002618 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT,
2619 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002620 if (TrueWhenEqual)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002621 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ,
2622 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002623 if (TrueWhenGreaterThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002624 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT,
2625 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002626
2627 return replaceInstUsesWith(Cmp, Cond);
2628 }
2629 return nullptr;
2630}
2631
Sanjay Patele7f46c32019-02-07 20:54:09 +00002632static Instruction *foldICmpBitCast(ICmpInst &Cmp,
2633 InstCombiner::BuilderTy &Builder) {
2634 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0));
2635 if (!Bitcast)
2636 return nullptr;
2637
Sanjay Patele7f46c32019-02-07 20:54:09 +00002638 ICmpInst::Predicate Pred = Cmp.getPredicate();
2639 Value *Op1 = Cmp.getOperand(1);
2640 Value *BCSrcOp = Bitcast->getOperand(0);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002641
Sanjay Patel781d8832019-02-07 21:12:01 +00002642 // Make sure the bitcast doesn't change the number of vector elements.
2643 if (Bitcast->getSrcTy()->getScalarSizeInBits() ==
2644 Bitcast->getDestTy()->getScalarSizeInBits()) {
2645 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
2646 Value *X;
2647 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) {
2648 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
2649 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
2650 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
2651 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
2652 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
2653 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
2654 match(Op1, m_Zero()))
2655 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002656
Sanjay Patel781d8832019-02-07 21:12:01 +00002657 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
2658 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
2659 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
2660
2661 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
2662 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
2663 return new ICmpInst(Pred, X,
2664 ConstantInt::getAllOnesValue(X->getType()));
2665 }
2666
2667 // Zero-equality checks are preserved through unsigned floating-point casts:
2668 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
2669 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
2670 if (match(BCSrcOp, m_UIToFP(m_Value(X))))
2671 if (Cmp.isEquality() && match(Op1, m_Zero()))
2672 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002673 }
2674
Sanjay Patele7f46c32019-02-07 20:54:09 +00002675 // Test to see if the operands of the icmp are casted versions of other
2676 // values. If the ptr->ptr cast can be stripped off both arguments, do so.
2677 if (Bitcast->getType()->isPointerTy() &&
2678 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
2679 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
2680 // so eliminate it as well.
2681 if (auto *BC2 = dyn_cast<BitCastInst>(Op1))
2682 Op1 = BC2->getOperand(0);
2683
2684 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType());
2685 return new ICmpInst(Pred, BCSrcOp, Op1);
2686 }
2687
Daniel Neilson901acfa2018-04-03 17:26:20 +00002688 // Folding: icmp <pred> iN X, C
2689 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2690 // and C is a splat of a K-bit pattern
2691 // and SC is a constant vector = <C', C', C', ..., C'>
2692 // Into:
2693 // %E = extractelement <M x iK> %vec, i32 C'
2694 // icmp <pred> iK %E, trunc(C)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002695 const APInt *C;
2696 if (!match(Cmp.getOperand(1), m_APInt(C)) ||
2697 !Bitcast->getType()->isIntegerTy() ||
Daniel Neilson901acfa2018-04-03 17:26:20 +00002698 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2699 return nullptr;
2700
Sanjay Patele7f46c32019-02-07 20:54:09 +00002701 Value *Vec;
2702 Constant *Mask;
2703 if (match(BCSrcOp,
Daniel Neilson901acfa2018-04-03 17:26:20 +00002704 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2705 // Check whether every element of Mask is the same constant
2706 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
Sanjay Patele7f46c32019-02-07 20:54:09 +00002707 auto *VecTy = cast<VectorType>(BCSrcOp->getType());
Daniel Neilson901acfa2018-04-03 17:26:20 +00002708 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
Sanjay Patele7f46c32019-02-07 20:54:09 +00002709 if (C->isSplat(EltTy->getBitWidth())) {
Daniel Neilson901acfa2018-04-03 17:26:20 +00002710 // Fold the icmp based on the value of C
2711 // If C is M copies of an iK sized bit pattern,
2712 // then:
2713 // => %E = extractelement <N x iK> %vec, i32 Elem
2714 // icmp <pred> iK %SplatVal, <pattern>
2715 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002716 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth()));
Daniel Neilson901acfa2018-04-03 17:26:20 +00002717 return new ICmpInst(Pred, Extract, NewC);
2718 }
2719 }
2720 }
2721 return nullptr;
2722}
2723
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002724/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2725/// where X is some kind of instruction.
2726Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002727 const APInt *C;
2728 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002729 return nullptr;
2730
Craig Toppera94069f2017-08-23 05:46:08 +00002731 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002732 switch (BO->getOpcode()) {
2733 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002734 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002735 return I;
2736 break;
2737 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002738 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002739 return I;
2740 break;
2741 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002742 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002743 return I;
2744 break;
2745 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002746 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002747 return I;
2748 break;
2749 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002750 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002751 return I;
2752 break;
2753 case Instruction::LShr:
2754 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002755 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002756 return I;
2757 break;
2758 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002759 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002760 return I;
2761 LLVM_FALLTHROUGH;
2762 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002763 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002764 return I;
2765 break;
2766 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002767 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002768 return I;
2769 break;
2770 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002771 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002772 return I;
2773 break;
2774 default:
2775 break;
2776 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002777 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002778 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002779 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002780 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002781
Anna Thomasd67165c2017-06-23 13:41:45 +00002782 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002783
2784 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2785 // For now, we only support constant integers while folding the
2786 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2787 // similar to the cases handled by binary ops above.
2788 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2789 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002790 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002791 }
2792
2793 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002794 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002795 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002796 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002797
Nikita Popov6515db22019-01-19 09:56:01 +00002798 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0)))
2799 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C))
2800 return I;
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002801
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002802 return nullptr;
2803}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002804
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002805/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2806/// icmp eq/ne BO, C.
2807Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2808 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002809 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002810 // TODO: Some of these folds could work with arbitrary constants, but this
2811 // function is limited to scalar and vector splat constants.
2812 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002813 return nullptr;
2814
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002815 ICmpInst::Predicate Pred = Cmp.getPredicate();
2816 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2817 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002818 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002819
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002820 switch (BO->getOpcode()) {
2821 case Instruction::SRem:
2822 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002823 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002824 const APInt *BOC;
2825 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002826 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002827 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002828 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002829 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002830 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002831 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002832 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002833 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002834 const APInt *BOC;
2835 if (match(BOp1, m_APInt(BOC))) {
2836 if (BO->hasOneUse()) {
2837 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002838 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002839 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002840 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002841 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2842 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002843 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002844 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002845 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002846 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002847 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002848 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002849 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002850 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002851 }
2852 }
2853 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002854 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002855 case Instruction::Xor:
2856 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002857 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002858 // For the xor case, we can xor two constants together, eliminating
2859 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002860 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002861 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002862 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002863 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002864 }
2865 }
2866 break;
2867 case Instruction::Sub:
2868 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002869 const APInt *BOC;
2870 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002871 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002872 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002873 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002874 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002875 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002876 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002877 }
2878 }
2879 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002880 case Instruction::Or: {
2881 const APInt *BOC;
2882 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002883 // Comparing if all bits outside of a constant mask are set?
2884 // Replace (X | C) == -1 with (X & ~C) == ~C.
2885 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002886 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002887 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002888 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002889 }
2890 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002891 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002892 case Instruction::And: {
2893 const APInt *BOC;
2894 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002895 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002896 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002897 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002898 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002899 }
2900 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002901 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002902 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002903 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002904 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002905 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002906 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002907 // General case : (mul X, C) != 0 iff X != 0
2908 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002909 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002910 }
2911 }
2912 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002913 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002914 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002915 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002916 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2917 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002918 }
2919 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002920 default:
2921 break;
2922 }
2923 return nullptr;
2924}
2925
Nikita Popov6515db22019-01-19 09:56:01 +00002926/// Fold an equality icmp with LLVM intrinsic and constant operand.
2927Instruction *InstCombiner::foldICmpEqIntrinsicWithConstant(ICmpInst &Cmp,
2928 IntrinsicInst *II,
2929 const APInt &C) {
Sanjay Patelb51e0722017-07-02 16:05:11 +00002930 Type *Ty = II->getType();
Nikita Popov20853a72018-12-18 19:59:50 +00002931 unsigned BitWidth = C.getBitWidth();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002932 switch (II->getIntrinsicID()) {
2933 case Intrinsic::bswap:
2934 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002935 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002936 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002937 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002938
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002939 case Intrinsic::ctlz:
Nikita Popov20853a72018-12-18 19:59:50 +00002940 case Intrinsic::cttz: {
Amaury Sechet6bea6742016-08-04 05:27:20 +00002941 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Nikita Popov20853a72018-12-18 19:59:50 +00002942 if (C == BitWidth) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002943 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002944 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002945 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002946 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002947 }
Nikita Popov20853a72018-12-18 19:59:50 +00002948
2949 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set
2950 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits.
2951 // Limit to one use to ensure we don't increase instruction count.
2952 unsigned Num = C.getLimitedValue(BitWidth);
2953 if (Num != BitWidth && II->hasOneUse()) {
2954 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz;
2955 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1)
2956 : APInt::getHighBitsSet(BitWidth, Num + 1);
2957 APInt Mask2 = IsTrailing
2958 ? APInt::getOneBitSet(BitWidth, Num)
2959 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
2960 Cmp.setOperand(0, Builder.CreateAnd(II->getArgOperand(0), Mask1));
2961 Cmp.setOperand(1, ConstantInt::get(Ty, Mask2));
2962 Worklist.Add(II);
2963 return &Cmp;
2964 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002965 break;
Nikita Popov20853a72018-12-18 19:59:50 +00002966 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002967
Amaury Sechet6bea6742016-08-04 05:27:20 +00002968 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002969 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002970 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002971 bool IsZero = C.isNullValue();
Nikita Popov20853a72018-12-18 19:59:50 +00002972 if (IsZero || C == BitWidth) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002973 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002974 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002975 auto *NewOp =
2976 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002977 Cmp.setOperand(1, NewOp);
2978 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002979 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002980 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002981 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002982 default:
2983 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002984 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002985
Craig Topperf40110f2014-04-25 05:29:35 +00002986 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002987}
2988
Nikita Popov6515db22019-01-19 09:56:01 +00002989/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2990Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
2991 IntrinsicInst *II,
2992 const APInt &C) {
2993 if (Cmp.isEquality())
2994 return foldICmpEqIntrinsicWithConstant(Cmp, II, C);
2995
2996 Type *Ty = II->getType();
2997 unsigned BitWidth = C.getBitWidth();
2998 switch (II->getIntrinsicID()) {
2999 case Intrinsic::ctlz: {
3000 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000
3001 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
3002 unsigned Num = C.getLimitedValue();
3003 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
3004 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT,
3005 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
3006 }
3007
3008 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111
3009 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3010 C.uge(1) && C.ule(BitWidth)) {
3011 unsigned Num = C.getLimitedValue();
3012 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num);
3013 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT,
3014 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
3015 }
3016 break;
3017 }
3018 case Intrinsic::cttz: {
3019 // Limit to one use to ensure we don't increase instruction count.
3020 if (!II->hasOneUse())
3021 return nullptr;
3022
3023 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0
3024 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
3025 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1);
3026 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ,
3027 Builder.CreateAnd(II->getArgOperand(0), Mask),
3028 ConstantInt::getNullValue(Ty));
3029 }
3030
3031 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0
3032 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3033 C.uge(1) && C.ule(BitWidth)) {
3034 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue());
3035 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE,
3036 Builder.CreateAnd(II->getArgOperand(0), Mask),
3037 ConstantInt::getNullValue(Ty));
3038 }
3039 break;
3040 }
3041 default:
3042 break;
3043 }
3044
3045 return nullptr;
3046}
3047
Sanjay Patel10494b22016-09-16 16:10:22 +00003048/// Handle icmp with constant (but not simple integer constant) RHS.
3049Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
3050 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3051 Constant *RHSC = dyn_cast<Constant>(Op1);
3052 Instruction *LHSI = dyn_cast<Instruction>(Op0);
3053 if (!RHSC || !LHSI)
3054 return nullptr;
3055
3056 switch (LHSI->getOpcode()) {
3057 case Instruction::GetElementPtr:
3058 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
3059 if (RHSC->isNullValue() &&
3060 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
3061 return new ICmpInst(
3062 I.getPredicate(), LHSI->getOperand(0),
3063 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3064 break;
3065 case Instruction::PHI:
3066 // Only fold icmp into the PHI if the phi and icmp are in the same
3067 // block. If in the same block, we're encouraging jump threading. If
3068 // not, we are just pessimizing the code by making an i1 phi.
3069 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00003070 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00003071 return NV;
3072 break;
3073 case Instruction::Select: {
3074 // If either operand of the select is a constant, we can fold the
3075 // comparison into the select arms, which will cause one to be
3076 // constant folded and the select turned into a bitwise or.
3077 Value *Op1 = nullptr, *Op2 = nullptr;
3078 ConstantInt *CI = nullptr;
3079 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
3080 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3081 CI = dyn_cast<ConstantInt>(Op1);
3082 }
3083 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
3084 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3085 CI = dyn_cast<ConstantInt>(Op2);
3086 }
3087
3088 // We only want to perform this transformation if it will not lead to
3089 // additional code. This is true if either both sides of the select
3090 // fold to a constant (in which case the icmp is replaced with a select
3091 // which will usually simplify) or this is the only user of the
3092 // select (in which case we are trading a select+icmp for a simpler
3093 // select+icmp) or all uses of the select can be replaced based on
3094 // dominance information ("Global cases").
3095 bool Transform = false;
3096 if (Op1 && Op2)
3097 Transform = true;
3098 else if (Op1 || Op2) {
3099 // Local case
3100 if (LHSI->hasOneUse())
3101 Transform = true;
3102 // Global cases
3103 else if (CI && !CI->isZero())
3104 // When Op1 is constant try replacing select with second operand.
3105 // Otherwise Op2 is constant and try replacing select with first
3106 // operand.
3107 Transform =
3108 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
3109 }
3110 if (Transform) {
3111 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00003112 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
3113 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003114 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00003115 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
3116 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003117 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
3118 }
3119 break;
3120 }
3121 case Instruction::IntToPtr:
3122 // icmp pred inttoptr(X), null -> icmp pred X, 0
3123 if (RHSC->isNullValue() &&
3124 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
3125 return new ICmpInst(
3126 I.getPredicate(), LHSI->getOperand(0),
3127 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3128 break;
3129
3130 case Instruction::Load:
3131 // Try to optimize things like "A[i] > 4" to index computations.
3132 if (GetElementPtrInst *GEP =
3133 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
3134 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
3135 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
3136 !cast<LoadInst>(LHSI)->isVolatile())
3137 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
3138 return Res;
3139 }
3140 break;
3141 }
3142
3143 return nullptr;
3144}
3145
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003146/// Some comparisons can be simplified.
3147/// In this case, we are looking for comparisons that look like
3148/// a check for a lossy truncation.
3149/// Folds:
Roman Lebedev183a4652018-09-19 13:35:27 +00003150/// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask
3151/// Where Mask is some pattern that produces all-ones in low bits:
3152/// (-1 >> y)
Roman Lebedevf50023d2018-09-19 13:35:46 +00003153/// ((-1 << y) >> y) <- non-canonical, has extra uses
Roman Lebedev183a4652018-09-19 13:35:27 +00003154/// ~(-1 << y)
Roman Lebedevca2bdb02018-09-19 13:35:40 +00003155/// ((1 << y) + (-1)) <- non-canonical, has extra uses
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003156/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003157/// For some predicates, the operands are commutative.
3158/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003159static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
3160 InstCombiner::BuilderTy &Builder) {
3161 ICmpInst::Predicate SrcPred;
Roman Lebedevf50023d2018-09-19 13:35:46 +00003162 Value *X, *M, *Y;
3163 auto m_VariableMask = m_CombineOr(
3164 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())),
3165 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())),
3166 m_CombineOr(m_LShr(m_AllOnes(), m_Value()),
3167 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y))));
Roman Lebedev183a4652018-09-19 13:35:27 +00003168 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask());
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003169 if (!match(&I, m_c_ICmp(SrcPred,
3170 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
3171 m_Deferred(X))))
3172 return nullptr;
3173
3174 ICmpInst::Predicate DstPred;
3175 switch (SrcPred) {
3176 case ICmpInst::Predicate::ICMP_EQ:
3177 // x & (-1 >> y) == x -> x u<= (-1 >> y)
3178 DstPred = ICmpInst::Predicate::ICMP_ULE;
3179 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00003180 case ICmpInst::Predicate::ICMP_NE:
3181 // x & (-1 >> y) != x -> x u> (-1 >> y)
3182 DstPred = ICmpInst::Predicate::ICMP_UGT;
3183 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00003184 case ICmpInst::Predicate::ICMP_UGT:
3185 // x u> x & (-1 >> y) -> x u> (-1 >> y)
3186 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3187 DstPred = ICmpInst::Predicate::ICMP_UGT;
3188 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00003189 case ICmpInst::Predicate::ICMP_UGE:
3190 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
3191 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3192 DstPred = ICmpInst::Predicate::ICMP_ULE;
3193 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00003194 case ICmpInst::Predicate::ICMP_ULT:
3195 // x & (-1 >> y) u< x -> x u> (-1 >> y)
3196 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3197 DstPred = ICmpInst::Predicate::ICMP_UGT;
3198 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00003199 case ICmpInst::Predicate::ICMP_ULE:
3200 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
3201 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3202 DstPred = ICmpInst::Predicate::ICMP_ULE;
3203 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003204 case ICmpInst::Predicate::ICMP_SGT:
3205 // x s> x & (-1 >> y) -> x s> (-1 >> y)
3206 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3207 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003208 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3209 return nullptr;
3210 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3211 return nullptr;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003212 DstPred = ICmpInst::Predicate::ICMP_SGT;
3213 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00003214 case ICmpInst::Predicate::ICMP_SGE:
3215 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
3216 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3217 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003218 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3219 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003220 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3221 return nullptr;
Roman Lebedevf1442612018-07-14 20:08:37 +00003222 DstPred = ICmpInst::Predicate::ICMP_SLE;
3223 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003224 case ICmpInst::Predicate::ICMP_SLT:
3225 // x & (-1 >> y) s< x -> x s> (-1 >> y)
3226 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3227 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003228 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3229 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003230 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3231 return nullptr;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003232 DstPred = ICmpInst::Predicate::ICMP_SGT;
3233 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003234 case ICmpInst::Predicate::ICMP_SLE:
3235 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
3236 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3237 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003238 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3239 return nullptr;
3240 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3241 return nullptr;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003242 DstPred = ICmpInst::Predicate::ICMP_SLE;
3243 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003244 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003245 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003246 }
3247
3248 return Builder.CreateICmp(DstPred, X, M);
3249}
3250
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003251/// Some comparisons can be simplified.
3252/// In this case, we are looking for comparisons that look like
3253/// a check for a lossy signed truncation.
3254/// Folds: (MaskedBits is a constant.)
3255/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
3256/// Into:
3257/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
3258/// Where KeptBits = bitwidth(%x) - MaskedBits
3259static Value *
3260foldICmpWithTruncSignExtendedVal(ICmpInst &I,
3261 InstCombiner::BuilderTy &Builder) {
3262 ICmpInst::Predicate SrcPred;
3263 Value *X;
3264 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
3265 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
3266 if (!match(&I, m_c_ICmp(SrcPred,
3267 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
3268 m_APInt(C1))),
3269 m_Deferred(X))))
3270 return nullptr;
3271
3272 // Potential handling of non-splats: for each element:
3273 // * if both are undef, replace with constant 0.
3274 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
3275 // * if both are not undef, and are different, bailout.
3276 // * else, only one is undef, then pick the non-undef one.
3277
3278 // The shift amount must be equal.
3279 if (*C0 != *C1)
3280 return nullptr;
3281 const APInt &MaskedBits = *C0;
3282 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
3283
3284 ICmpInst::Predicate DstPred;
3285 switch (SrcPred) {
3286 case ICmpInst::Predicate::ICMP_EQ:
3287 // ((%x << MaskedBits) a>> MaskedBits) == %x
3288 // =>
3289 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
3290 DstPred = ICmpInst::Predicate::ICMP_ULT;
3291 break;
3292 case ICmpInst::Predicate::ICMP_NE:
3293 // ((%x << MaskedBits) a>> MaskedBits) != %x
3294 // =>
3295 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
3296 DstPred = ICmpInst::Predicate::ICMP_UGE;
3297 break;
3298 // FIXME: are more folds possible?
3299 default:
3300 return nullptr;
3301 }
3302
3303 auto *XType = X->getType();
3304 const unsigned XBitWidth = XType->getScalarSizeInBits();
3305 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3306 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3307
3308 // KeptBits = bitwidth(%x) - MaskedBits
3309 const APInt KeptBits = BitWidth - MaskedBits;
3310 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3311 // ICmpCst = (1 << KeptBits)
3312 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3313 assert(ICmpCst.isPowerOf2());
3314 // AddCst = (1 << (KeptBits-1))
3315 const APInt AddCst = ICmpCst.lshr(1);
3316 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3317
3318 // T0 = add %x, AddCst
3319 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3320 // T1 = T0 DstPred ICmpCst
3321 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3322
3323 return T1;
3324}
3325
Roman Lebedev72b8d412019-07-01 15:55:15 +00003326// Given pattern:
3327// icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0
3328// we should move shifts to the same hand of 'and', i.e. rewrite as
3329// icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x)
3330// We are only interested in opposite logical shifts here.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003331// One of the shifts can be truncated. For now, it can only be 'shl'.
Roman Lebedev72b8d412019-07-01 15:55:15 +00003332// If we can, we want to end up creating 'lshr' shift.
3333static Value *
3334foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ,
3335 InstCombiner::BuilderTy &Builder) {
3336 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) ||
3337 !I.getOperand(0)->hasOneUse())
3338 return nullptr;
3339
3340 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value());
Roman Lebedev72b8d412019-07-01 15:55:15 +00003341
Roman Lebedev16244fc2019-08-16 15:10:41 +00003342 // Look for an 'and' of two logical shifts, one of which may be truncated.
3343 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case.
3344 Instruction *XShift, *MaybeTruncation, *YShift;
3345 if (!match(
3346 I.getOperand(0),
3347 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)),
3348 m_CombineAnd(m_TruncOrSelf(m_CombineAnd(
3349 m_AnyLogicalShift, m_Instruction(YShift))),
3350 m_Instruction(MaybeTruncation)))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003351 return nullptr;
3352
Roman Lebedev16244fc2019-08-16 15:10:41 +00003353 // We potentially looked past 'trunc', but only when matching YShift,
3354 // therefore YShift must have the widest type.
Roman Lebedev9b957d32019-08-18 12:26:33 +00003355 Instruction *WidestShift = YShift;
3356 // Therefore XShift must have the shallowest type.
3357 // Or they both have identical types if there was no truncation.
3358 Instruction *NarrowestShift = XShift;
3359
3360 Type *WidestTy = WidestShift->getType();
3361 assert(NarrowestShift->getType() == I.getOperand(0)->getType() &&
Roman Lebedev16244fc2019-08-16 15:10:41 +00003362 "We did not look past any shifts while matching XShift though.");
3363 bool HadTrunc = WidestTy != I.getOperand(0)->getType();
3364
3365 if (HadTrunc) {
3366 // We did indeed have a truncation. For now, let's only proceed if the 'shl'
3367 // was truncated, since that does not require any extra legality checks.
3368 // FIXME: trunc-of-lshr.
3369 if (!match(YShift, m_Shl(m_Value(), m_Value())))
3370 return nullptr;
3371 }
3372
Roman Lebedev64fe8062019-08-10 19:28:44 +00003373 // If YShift is a 'lshr', swap the shifts around.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003374 if (match(YShift, m_LShr(m_Value(), m_Value())))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003375 std::swap(XShift, YShift);
3376
3377 // The shifts must be in opposite directions.
Roman Lebedevccdad6e2019-08-12 11:28:02 +00003378 auto XShiftOpcode = XShift->getOpcode();
3379 if (XShiftOpcode == YShift->getOpcode())
Roman Lebedev72b8d412019-07-01 15:55:15 +00003380 return nullptr; // Do not care about same-direction shifts here.
3381
3382 Value *X, *XShAmt, *Y, *YShAmt;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003383 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt))));
3384 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt))));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003385
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003386 // If one of the values being shifted is a constant, then we will end with
Roman Lebedev16244fc2019-08-16 15:10:41 +00003387 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not,
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003388 // however, we will need to ensure that we won't increase instruction count.
3389 if (!isa<Constant>(X) && !isa<Constant>(Y)) {
3390 // At least one of the hands of the 'and' should be one-use shift.
3391 if (!match(I.getOperand(0),
3392 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value())))
3393 return nullptr;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003394 if (HadTrunc) {
3395 // Due to the 'trunc', we will need to widen X. For that either the old
3396 // 'trunc' or the shift amt in the non-truncated shift should be one-use.
3397 if (!MaybeTruncation->hasOneUse() &&
Roman Lebedev9b957d32019-08-18 12:26:33 +00003398 !NarrowestShift->getOperand(1)->hasOneUse())
Roman Lebedev16244fc2019-08-16 15:10:41 +00003399 return nullptr;
3400 }
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003401 }
3402
Roman Lebedev16244fc2019-08-16 15:10:41 +00003403 // We have two shift amounts from two different shifts. The types of those
3404 // shift amounts may not match. If that's the case let's bailout now.
3405 if (XShAmt->getType() != YShAmt->getType())
3406 return nullptr;
3407
Roman Lebedev72b8d412019-07-01 15:55:15 +00003408 // Can we fold (XShAmt+YShAmt) ?
Roman Lebedev16244fc2019-08-16 15:10:41 +00003409 auto *NewShAmt = dyn_cast_or_null<Constant>(
3410 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false,
3411 /*isNUW=*/false, SQ.getWithInstruction(&I)));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003412 if (!NewShAmt)
3413 return nullptr;
3414 // Is the new shift amount smaller than the bit width?
3415 // FIXME: could also rely on ConstantRange.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003416 if (!match(NewShAmt, m_SpecificInt_ICMP(
3417 ICmpInst::Predicate::ICMP_ULT,
3418 APInt(NewShAmt->getType()->getScalarSizeInBits(),
3419 WidestTy->getScalarSizeInBits()))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003420 return nullptr;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003421 // All good, we can do this fold.
3422 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy);
3423 X = Builder.CreateZExt(X, WidestTy);
3424 // The shift is the same that was for X.
Roman Lebedev72b8d412019-07-01 15:55:15 +00003425 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr
3426 ? Builder.CreateLShr(X, NewShAmt)
3427 : Builder.CreateShl(X, NewShAmt);
3428 Value *T1 = Builder.CreateAnd(T0, Y);
3429 return Builder.CreateICmp(I.getPredicate(), T1,
Roman Lebedev16244fc2019-08-16 15:10:41 +00003430 Constant::getNullValue(WidestTy));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003431}
3432
Sanjay Patel10494b22016-09-16 16:10:22 +00003433/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003434/// TODO: A large part of this logic is duplicated in InstSimplify's
3435/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3436/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00003437Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
3438 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3439
3440 // Special logic for binary operators.
3441 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3442 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3443 if (!BO0 && !BO1)
3444 return nullptr;
3445
Sanjay Patel2a062632017-05-08 16:33:42 +00003446 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel1cf07342018-09-11 22:40:20 +00003447 Value *X;
3448
3449 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare.
3450 // (Op1 + X) <u Op1 --> ~Op1 <u X
3451 // Op0 >u (Op0 + X) --> X >u ~Op0
3452 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) &&
3453 Pred == ICmpInst::ICMP_ULT)
3454 return new ICmpInst(Pred, Builder.CreateNot(Op1), X);
3455 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) &&
3456 Pred == ICmpInst::ICMP_UGT)
3457 return new ICmpInst(Pred, X, Builder.CreateNot(Op0));
3458
Sanjay Patel10494b22016-09-16 16:10:22 +00003459 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3460 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3461 NoOp0WrapProblem =
3462 ICmpInst::isEquality(Pred) ||
3463 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3464 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3465 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3466 NoOp1WrapProblem =
3467 ICmpInst::isEquality(Pred) ||
3468 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3469 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3470
3471 // Analyze the case when either Op0 or Op1 is an add instruction.
3472 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3473 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3474 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3475 A = BO0->getOperand(0);
3476 B = BO0->getOperand(1);
3477 }
3478 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3479 C = BO1->getOperand(0);
3480 D = BO1->getOperand(1);
3481 }
3482
Sanjay Patel10494b22016-09-16 16:10:22 +00003483 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
3484 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3485 return new ICmpInst(Pred, A == Op1 ? B : A,
3486 Constant::getNullValue(Op1->getType()));
3487
3488 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
3489 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3490 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3491 C == Op0 ? D : C);
3492
3493 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
3494 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
3495 NoOp1WrapProblem &&
3496 // Try not to increase register pressure.
3497 BO0->hasOneUse() && BO1->hasOneUse()) {
3498 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3499 Value *Y, *Z;
3500 if (A == C) {
3501 // C + B == C + D -> B == D
3502 Y = B;
3503 Z = D;
3504 } else if (A == D) {
3505 // D + B == C + D -> B == C
3506 Y = B;
3507 Z = C;
3508 } else if (B == C) {
3509 // A + C == C + D -> A == D
3510 Y = A;
3511 Z = D;
3512 } else {
3513 assert(B == D);
3514 // A + D == C + D -> A == C
3515 Y = A;
3516 Z = C;
3517 }
3518 return new ICmpInst(Pred, Y, Z);
3519 }
3520
3521 // icmp slt (X + -1), Y -> icmp sle X, Y
3522 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3523 match(B, m_AllOnes()))
3524 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3525
3526 // icmp sge (X + -1), Y -> icmp sgt X, Y
3527 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3528 match(B, m_AllOnes()))
3529 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3530
3531 // icmp sle (X + 1), Y -> icmp slt X, Y
3532 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3533 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3534
3535 // icmp sgt (X + 1), Y -> icmp sge X, Y
3536 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3537 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3538
3539 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3540 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3541 match(D, m_AllOnes()))
3542 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3543
3544 // icmp sle X, (Y + -1) -> icmp slt X, Y
3545 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3546 match(D, m_AllOnes()))
3547 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3548
3549 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3550 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3551 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3552
3553 // icmp slt X, (Y + 1) -> icmp sle X, Y
3554 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3555 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3556
Sanjay Patel40f40172017-01-13 23:25:46 +00003557 // TODO: The subtraction-related identities shown below also hold, but
3558 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3559 // wouldn't happen even if they were implemented.
3560 //
3561 // icmp ult (X - 1), Y -> icmp ule X, Y
3562 // icmp uge (X - 1), Y -> icmp ugt X, Y
3563 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3564 // icmp ule X, (Y - 1) -> icmp ult X, Y
3565
3566 // icmp ule (X + 1), Y -> icmp ult X, Y
3567 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3568 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3569
3570 // icmp ugt (X + 1), Y -> icmp uge X, Y
3571 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3572 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3573
3574 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3575 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3576 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3577
3578 // icmp ult X, (Y + 1) -> icmp ule X, Y
3579 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3580 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3581
Sanjay Patel10494b22016-09-16 16:10:22 +00003582 // if C1 has greater magnitude than C2:
3583 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3584 // s.t. C3 = C1 - C2
3585 //
3586 // if C2 has greater magnitude than C1:
3587 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3588 // s.t. C3 = C2 - C1
3589 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3590 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3591 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3592 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3593 const APInt &AP1 = C1->getValue();
3594 const APInt &AP2 = C2->getValue();
3595 if (AP1.isNegative() == AP2.isNegative()) {
3596 APInt AP1Abs = C1->getValue().abs();
3597 APInt AP2Abs = C2->getValue().abs();
3598 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003599 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3600 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003601 return new ICmpInst(Pred, NewAdd, C);
3602 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003603 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3604 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003605 return new ICmpInst(Pred, A, NewAdd);
3606 }
3607 }
3608 }
3609
3610 // Analyze the case when either Op0 or Op1 is a sub instruction.
3611 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3612 A = nullptr;
3613 B = nullptr;
3614 C = nullptr;
3615 D = nullptr;
3616 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3617 A = BO0->getOperand(0);
3618 B = BO0->getOperand(1);
3619 }
3620 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3621 C = BO1->getOperand(0);
3622 D = BO1->getOperand(1);
3623 }
3624
3625 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3626 if (A == Op1 && NoOp0WrapProblem)
3627 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003628 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3629 if (C == Op0 && NoOp1WrapProblem)
3630 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3631
Sanjay Patelcbb04502018-04-02 20:37:40 +00003632 // (A - B) >u A --> A <u B
3633 if (A == Op1 && Pred == ICmpInst::ICMP_UGT)
3634 return new ICmpInst(ICmpInst::ICMP_ULT, A, B);
3635 // C <u (C - D) --> C <u D
3636 if (C == Op0 && Pred == ICmpInst::ICMP_ULT)
3637 return new ICmpInst(ICmpInst::ICMP_ULT, C, D);
3638
Sanjay Patel10494b22016-09-16 16:10:22 +00003639 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3640 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3641 // Try not to increase register pressure.
3642 BO0->hasOneUse() && BO1->hasOneUse())
3643 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003644 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3645 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3646 // Try not to increase register pressure.
3647 BO0->hasOneUse() && BO1->hasOneUse())
3648 return new ICmpInst(Pred, D, B);
3649
3650 // icmp (0-X) < cst --> x > -cst
3651 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3652 Value *X;
3653 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003654 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3655 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003656 return new ICmpInst(I.getSwappedPredicate(), X,
3657 ConstantExpr::getNeg(RHSC));
3658 }
3659
3660 BinaryOperator *SRem = nullptr;
3661 // icmp (srem X, Y), Y
3662 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3663 SRem = BO0;
3664 // icmp Y, (srem X, Y)
3665 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3666 Op0 == BO1->getOperand(1))
3667 SRem = BO1;
3668 if (SRem) {
3669 // We don't check hasOneUse to avoid increasing register pressure because
3670 // the value we use is the same value this instruction was already using.
3671 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3672 default:
3673 break;
3674 case ICmpInst::ICMP_EQ:
3675 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3676 case ICmpInst::ICMP_NE:
3677 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3678 case ICmpInst::ICMP_SGT:
3679 case ICmpInst::ICMP_SGE:
3680 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3681 Constant::getAllOnesValue(SRem->getType()));
3682 case ICmpInst::ICMP_SLT:
3683 case ICmpInst::ICMP_SLE:
3684 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3685 Constant::getNullValue(SRem->getType()));
3686 }
3687 }
3688
3689 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3690 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3691 switch (BO0->getOpcode()) {
3692 default:
3693 break;
3694 case Instruction::Add:
3695 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003696 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003697 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003698 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003699
3700 const APInt *C;
3701 if (match(BO0->getOperand(1), m_APInt(C))) {
3702 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3703 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003704 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003705 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003706 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003707 }
3708
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003709 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3710 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003711 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003712 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003713 NewPred = I.getSwappedPredicate(NewPred);
3714 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003715 }
3716 }
3717 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003718 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003719 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003720 if (!I.isEquality())
3721 break;
3722
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003723 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003724 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3725 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003726 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3727 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003728 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003729 Constant *Mask = ConstantInt::get(
3730 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003731 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003732 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3733 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003734 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003735 }
Sanjay Patel51506122017-05-25 14:13:57 +00003736 // If there are no trailing zeros in the multiplier, just eliminate
3737 // the multiplies (no masking is needed):
3738 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3739 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003740 }
3741 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003742 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003743 case Instruction::UDiv:
3744 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003745 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003746 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003747 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3748
Sanjay Patel10494b22016-09-16 16:10:22 +00003749 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003750 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3751 break;
3752 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3753
Sanjay Patel10494b22016-09-16 16:10:22 +00003754 case Instruction::AShr:
3755 if (!BO0->isExact() || !BO1->isExact())
3756 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003757 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003758
Sanjay Patel10494b22016-09-16 16:10:22 +00003759 case Instruction::Shl: {
3760 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3761 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3762 if (!NUW && !NSW)
3763 break;
3764 if (!NSW && I.isSigned())
3765 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003766 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003767 }
3768 }
3769 }
3770
3771 if (BO0) {
3772 // Transform A & (L - 1) `ult` L --> L != 0
3773 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003774 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003775
Sanjay Patel2a062632017-05-08 16:33:42 +00003776 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003777 auto *Zero = Constant::getNullValue(BO0->getType());
3778 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3779 }
3780 }
3781
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003782 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3783 return replaceInstUsesWith(I, V);
3784
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003785 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
3786 return replaceInstUsesWith(I, V);
3787
Roman Lebedev72b8d412019-07-01 15:55:15 +00003788 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder))
3789 return replaceInstUsesWith(I, V);
3790
Sanjay Patel10494b22016-09-16 16:10:22 +00003791 return nullptr;
3792}
3793
Sanjay Pateldd46b522016-12-19 17:32:37 +00003794/// Fold icmp Pred min|max(X, Y), X.
3795static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003796 ICmpInst::Predicate Pred = Cmp.getPredicate();
3797 Value *Op0 = Cmp.getOperand(0);
3798 Value *X = Cmp.getOperand(1);
3799
Sanjay Pateldd46b522016-12-19 17:32:37 +00003800 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003801 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003802 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3803 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3804 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003805 std::swap(Op0, X);
3806 Pred = Cmp.getSwappedPredicate();
3807 }
3808
3809 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003810 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003811 // smin(X, Y) == X --> X s<= Y
3812 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003813 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3814 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3815
Sanjay Pateldd46b522016-12-19 17:32:37 +00003816 // smin(X, Y) != X --> X s> Y
3817 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003818 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3819 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3820
3821 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003822 // smin(X, Y) s<= X --> true
3823 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003824 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003825 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003826
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003827 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003828 // smax(X, Y) == X --> X s>= Y
3829 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003830 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3831 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003832
Sanjay Pateldd46b522016-12-19 17:32:37 +00003833 // smax(X, Y) != X --> X s< Y
3834 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003835 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3836 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003837
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003838 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003839 // smax(X, Y) s>= X --> true
3840 // smax(X, Y) s< X --> false
3841 return nullptr;
3842 }
3843
3844 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3845 // umin(X, Y) == X --> X u<= Y
3846 // umin(X, Y) u>= X --> X u<= Y
3847 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3848 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3849
3850 // umin(X, Y) != X --> X u> Y
3851 // umin(X, Y) u< X --> X u> Y
3852 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3853 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3854
3855 // These cases should be handled in InstSimplify:
3856 // umin(X, Y) u<= X --> true
3857 // umin(X, Y) u> X --> false
3858 return nullptr;
3859 }
3860
3861 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3862 // umax(X, Y) == X --> X u>= Y
3863 // umax(X, Y) u<= X --> X u>= Y
3864 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3865 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3866
3867 // umax(X, Y) != X --> X u< Y
3868 // umax(X, Y) u> X --> X u< Y
3869 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3870 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3871
3872 // These cases should be handled in InstSimplify:
3873 // umax(X, Y) u>= X --> true
3874 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003875 return nullptr;
3876 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003877
Sanjay Pateld6406412016-12-15 19:13:37 +00003878 return nullptr;
3879}
3880
Sanjay Patel10494b22016-09-16 16:10:22 +00003881Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3882 if (!I.isEquality())
3883 return nullptr;
3884
3885 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003886 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003887 Value *A, *B, *C, *D;
3888 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3889 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3890 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003891 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003892 }
3893
3894 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3895 // A^c1 == C^c2 --> A == C^(c1^c2)
3896 ConstantInt *C1, *C2;
3897 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3898 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003899 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3900 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003901 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003902 }
3903
3904 // A^B == A^D -> B == D
3905 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003906 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003907 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003908 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003909 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003910 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003911 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003912 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003913 }
3914 }
3915
3916 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3917 // A == (A^B) -> B == 0
3918 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003919 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003920 }
3921
3922 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3923 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3924 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3925 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3926
3927 if (A == C) {
3928 X = B;
3929 Y = D;
3930 Z = A;
3931 } else if (A == D) {
3932 X = B;
3933 Y = C;
3934 Z = A;
3935 } else if (B == C) {
3936 X = A;
3937 Y = D;
3938 Z = B;
3939 } else if (B == D) {
3940 X = A;
3941 Y = C;
3942 Z = B;
3943 }
3944
3945 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003946 Op1 = Builder.CreateXor(X, Y);
3947 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003948 I.setOperand(0, Op1);
3949 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3950 return &I;
3951 }
3952 }
3953
3954 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3955 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3956 ConstantInt *Cst1;
3957 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3958 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3959 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3960 match(Op1, m_ZExt(m_Value(A))))) {
3961 APInt Pow2 = Cst1->getValue() + 1;
3962 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3963 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003964 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003965 }
3966
3967 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3968 // For lshr and ashr pairs.
3969 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3970 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3971 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3972 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3973 unsigned TypeBits = Cst1->getBitWidth();
3974 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3975 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003976 ICmpInst::Predicate NewPred =
3977 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003978 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003979 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003980 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003981 }
3982 }
3983
3984 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3985 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3986 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3987 unsigned TypeBits = Cst1->getBitWidth();
3988 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3989 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003990 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003991 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003992 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003993 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003994 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003995 }
3996 }
3997
3998 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3999 // "icmp (and X, mask), cst"
4000 uint64_t ShAmt = 0;
4001 if (Op0->hasOneUse() &&
4002 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
4003 match(Op1, m_ConstantInt(Cst1)) &&
4004 // Only do this when A has multiple uses. This is most important to do
4005 // when it exposes other optimizations.
4006 !A->hasOneUse()) {
4007 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
4008
4009 if (ShAmt < ASize) {
4010 APInt MaskV =
4011 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
4012 MaskV <<= ShAmt;
4013
4014 APInt CmpV = Cst1->getValue().zext(ASize);
4015 CmpV <<= ShAmt;
4016
Craig Topperbb4069e2017-07-07 23:16:26 +00004017 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
4018 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00004019 }
4020 }
4021
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00004022 // If both operands are byte-swapped or bit-reversed, just compare the
4023 // original values.
4024 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
4025 // and handle more intrinsics.
4026 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00004027 (match(Op0, m_BitReverse(m_Value(A))) &&
4028 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00004029 return new ICmpInst(Pred, A, B);
4030
Sanjay Patel63311bf2019-06-20 17:41:15 +00004031 // Canonicalize checking for a power-of-2-or-zero value:
Sanjay Patelddc1b402019-07-01 22:00:00 +00004032 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants)
4033 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants)
4034 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()),
4035 m_Deferred(A)))) ||
4036 !match(Op1, m_ZeroInt()))
4037 A = nullptr;
4038
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004039 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants)
4040 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants)
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004041 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00004042 A = Op1;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004043 else if (match(Op1,
4044 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00004045 A = Op0;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004046
Sanjay Patel63311bf2019-06-20 17:41:15 +00004047 if (A) {
4048 Type *Ty = A->getType();
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004049 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A);
4050 return Pred == ICmpInst::ICMP_EQ
4051 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2))
4052 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1));
Sanjay Patel63311bf2019-06-20 17:41:15 +00004053 }
4054
Sanjay Patel10494b22016-09-16 16:10:22 +00004055 return nullptr;
4056}
4057
Sanjay Patele7282592019-08-21 11:56:08 +00004058static Instruction *foldICmpWithZextOrSext(ICmpInst &ICmp,
4059 InstCombiner::BuilderTy &Builder) {
Sanjay Patel292b1082019-08-20 18:15:17 +00004060 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0");
4061 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0));
4062 Value *X;
4063 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X))))
4064 return nullptr;
4065
4066 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt;
4067 bool IsSignedCmp = ICmp.isSigned();
4068 if (auto *CastOp1 = dyn_cast<CastInst>(ICmp.getOperand(1))) {
4069 // If the signedness of the two casts doesn't agree (i.e. one is a sext
4070 // and the other is a zext), then we can't handle this.
Sanjay Patele7282592019-08-21 11:56:08 +00004071 // TODO: This is too strict. We can handle some predicates (equality?).
Sanjay Patel292b1082019-08-20 18:15:17 +00004072 if (CastOp0->getOpcode() != CastOp1->getOpcode())
4073 return nullptr;
4074
4075 // Not an extension from the same type?
Sanjay Patel292b1082019-08-20 18:15:17 +00004076 Value *Y = CastOp1->getOperand(0);
Sanjay Patele7282592019-08-21 11:56:08 +00004077 Type *XTy = X->getType(), *YTy = Y->getType();
4078 if (XTy != YTy) {
4079 // One of the casts must have one use because we are creating a new cast.
4080 if (!CastOp0->hasOneUse() && !CastOp1->hasOneUse())
4081 return nullptr;
4082 // Extend the narrower operand to the type of the wider operand.
4083 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits())
4084 X = Builder.CreateCast(CastOp0->getOpcode(), X, YTy);
4085 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits())
4086 Y = Builder.CreateCast(CastOp0->getOpcode(), Y, XTy);
4087 else
4088 return nullptr;
4089 }
Sanjay Patel292b1082019-08-20 18:15:17 +00004090
4091 // (zext X) == (zext Y) --> X == Y
4092 // (sext X) == (sext Y) --> X == Y
4093 if (ICmp.isEquality())
4094 return new ICmpInst(ICmp.getPredicate(), X, Y);
4095
4096 // A signed comparison of sign extended values simplifies into a
4097 // signed comparison.
4098 if (IsSignedCmp && IsSignedExt)
4099 return new ICmpInst(ICmp.getPredicate(), X, Y);
4100
4101 // The other three cases all fold into an unsigned comparison.
4102 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y);
4103 }
4104
4105 // Below here, we are only folding a compare with constant.
4106 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
4107 if (!C)
4108 return nullptr;
4109
4110 // Compute the constant that would happen if we truncated to SrcTy then
4111 // re-extended to DestTy.
4112 Type *SrcTy = CastOp0->getSrcTy();
4113 Type *DestTy = CastOp0->getDestTy();
4114 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
4115 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy);
4116
4117 // If the re-extended constant didn't change...
4118 if (Res2 == C) {
4119 if (ICmp.isEquality())
4120 return new ICmpInst(ICmp.getPredicate(), X, Res1);
4121
4122 // A signed comparison of sign extended values simplifies into a
4123 // signed comparison.
4124 if (IsSignedExt && IsSignedCmp)
4125 return new ICmpInst(ICmp.getPredicate(), X, Res1);
4126
4127 // The other three cases all fold into an unsigned comparison.
4128 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1);
4129 }
4130
4131 // The re-extended constant changed, partly changed (in the case of a vector),
4132 // or could not be determined to be equal (in the case of a constant
4133 // expression), so the constant cannot be represented in the shorter type.
4134 // All the cases that fold to true or false will have already been handled
4135 // by SimplifyICmpInst, so only deal with the tricky case.
4136 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C))
4137 return nullptr;
4138
4139 // Is source op positive?
4140 // icmp ult (sext X), C --> icmp sgt X, -1
4141 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
4142 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy));
4143
4144 // Is source op negative?
4145 // icmp ugt (sext X), C --> icmp slt X, 0
4146 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
4147 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy));
4148}
4149
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004150/// Handle icmp (cast x), (cast or constant).
4151Instruction *InstCombiner::foldICmpWithCastOp(ICmpInst &ICmp) {
4152 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0));
4153 if (!CastOp0)
4154 return nullptr;
4155 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1)))
4156 return nullptr;
4157
4158 Value *Op0Src = CastOp0->getOperand(0);
4159 Type *SrcTy = CastOp0->getSrcTy();
4160 Type *DestTy = CastOp0->getDestTy();
Chris Lattner2188e402010-01-04 07:37:31 +00004161
Jim Grosbach129c52a2011-09-30 18:09:53 +00004162 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00004163 // integer type is the same size as the pointer type.
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004164 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) {
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004165 if (isa<VectorType>(SrcTy)) {
4166 SrcTy = cast<VectorType>(SrcTy)->getElementType();
4167 DestTy = cast<VectorType>(DestTy)->getElementType();
4168 }
4169 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
4170 };
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004171 if (CastOp0->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004172 CompatibleSizes(SrcTy, DestTy)) {
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004173 Value *NewOp1 = nullptr;
4174 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
4175 Value *PtrSrc = PtrToIntOp1->getOperand(0);
4176 if (PtrSrc->getType()->getPointerAddressSpace() ==
4177 Op0Src->getType()->getPointerAddressSpace()) {
4178 NewOp1 = PtrToIntOp1->getOperand(0);
Michael Liaod266b922015-02-13 04:51:26 +00004179 // If the pointer types don't match, insert a bitcast.
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004180 if (Op0Src->getType() != NewOp1->getType())
4181 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType());
Michael Liaod266b922015-02-13 04:51:26 +00004182 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004183 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004184 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004185 }
Chris Lattner2188e402010-01-04 07:37:31 +00004186
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004187 if (NewOp1)
4188 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1);
Chris Lattner2188e402010-01-04 07:37:31 +00004189 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004190
Sanjay Patele7282592019-08-21 11:56:08 +00004191 return foldICmpWithZextOrSext(ICmp, Builder);
Chris Lattner2188e402010-01-04 07:37:31 +00004192}
4193
Nikita Popov39f2beb2019-05-26 11:43:37 +00004194static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) {
4195 switch (BinaryOp) {
4196 default:
4197 llvm_unreachable("Unsupported binary op");
4198 case Instruction::Add:
4199 case Instruction::Sub:
4200 return match(RHS, m_Zero());
4201 case Instruction::Mul:
4202 return match(RHS, m_One());
4203 }
4204}
4205
4206OverflowResult InstCombiner::computeOverflow(
4207 Instruction::BinaryOps BinaryOp, bool IsSigned,
4208 Value *LHS, Value *RHS, Instruction *CxtI) const {
4209 switch (BinaryOp) {
4210 default:
4211 llvm_unreachable("Unsupported binary op");
4212 case Instruction::Add:
4213 if (IsSigned)
4214 return computeOverflowForSignedAdd(LHS, RHS, CxtI);
4215 else
4216 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI);
4217 case Instruction::Sub:
4218 if (IsSigned)
4219 return computeOverflowForSignedSub(LHS, RHS, CxtI);
4220 else
4221 return computeOverflowForUnsignedSub(LHS, RHS, CxtI);
4222 case Instruction::Mul:
4223 if (IsSigned)
4224 return computeOverflowForSignedMul(LHS, RHS, CxtI);
4225 else
4226 return computeOverflowForUnsignedMul(LHS, RHS, CxtI);
4227 }
4228}
4229
Nikita Popov352f5982019-05-26 11:43:31 +00004230bool InstCombiner::OptimizeOverflowCheck(
4231 Instruction::BinaryOps BinaryOp, bool IsSigned, Value *LHS, Value *RHS,
4232 Instruction &OrigI, Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00004233 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
4234 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00004235
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004236 // If the overflow check was an add followed by a compare, the insertion point
4237 // may be pointing to the compare. We want to insert the new instructions
4238 // before the add in case there are uses of the add between the add and the
4239 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00004240 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004241
Nikita Popov39f2beb2019-05-26 11:43:37 +00004242 if (isNeutralValue(BinaryOp, RHS)) {
4243 Result = LHS;
4244 Overflow = Builder.getFalse();
4245 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004246 }
4247
Nikita Popov39f2beb2019-05-26 11:43:37 +00004248 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) {
4249 case OverflowResult::MayOverflow:
4250 return false;
Nikita Popov332c1002019-05-28 18:08:31 +00004251 case OverflowResult::AlwaysOverflowsLow:
4252 case OverflowResult::AlwaysOverflowsHigh:
Nikita Popov39f2beb2019-05-26 11:43:37 +00004253 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4254 Result->takeName(&OrigI);
4255 Overflow = Builder.getTrue();
4256 return true;
4257 case OverflowResult::NeverOverflows:
4258 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4259 Result->takeName(&OrigI);
4260 Overflow = Builder.getFalse();
4261 if (auto *Inst = dyn_cast<Instruction>(Result)) {
4262 if (IsSigned)
4263 Inst->setHasNoSignedWrap();
4264 else
4265 Inst->setHasNoUnsignedWrap();
4266 }
4267 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004268 }
4269
Nikita Popov39f2beb2019-05-26 11:43:37 +00004270 llvm_unreachable("Unexpected overflow result");
Sanjoy Dasb0984472015-04-08 04:27:22 +00004271}
4272
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004273/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004274/// overflow.
4275///
4276/// The caller has matched a pattern of the form:
4277/// I = cmp u (mul(zext A, zext B), V
4278/// The function checks if this is a test for overflow and if so replaces
4279/// multiplication with call to 'mul.with.overflow' intrinsic.
4280///
4281/// \param I Compare instruction.
4282/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
4283/// the compare instruction. Must be of integer type.
4284/// \param OtherVal The other argument of compare instruction.
4285/// \returns Instruction which must replace the compare instruction, NULL if no
4286/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004287static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004288 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00004289 // Don't bother doing this transformation for pointers, don't do it for
4290 // vectors.
4291 if (!isa<IntegerType>(MulVal->getType()))
4292 return nullptr;
4293
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004294 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
4295 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00004296 auto *MulInstr = dyn_cast<Instruction>(MulVal);
4297 if (!MulInstr)
4298 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004299 assert(MulInstr->getOpcode() == Instruction::Mul);
4300
David Majnemer634ca232014-11-01 23:46:05 +00004301 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
4302 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004303 assert(LHS->getOpcode() == Instruction::ZExt);
4304 assert(RHS->getOpcode() == Instruction::ZExt);
4305 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
4306
4307 // Calculate type and width of the result produced by mul.with.overflow.
4308 Type *TyA = A->getType(), *TyB = B->getType();
4309 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
4310 WidthB = TyB->getPrimitiveSizeInBits();
4311 unsigned MulWidth;
4312 Type *MulType;
4313 if (WidthB > WidthA) {
4314 MulWidth = WidthB;
4315 MulType = TyB;
4316 } else {
4317 MulWidth = WidthA;
4318 MulType = TyA;
4319 }
4320
4321 // In order to replace the original mul with a narrower mul.with.overflow,
4322 // all uses must ignore upper bits of the product. The number of used low
4323 // bits must be not greater than the width of mul.with.overflow.
4324 if (MulVal->hasNUsesOrMore(2))
4325 for (User *U : MulVal->users()) {
4326 if (U == &I)
4327 continue;
4328 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4329 // Check if truncation ignores bits above MulWidth.
4330 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
4331 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004332 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004333 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4334 // Check if AND ignores bits above MulWidth.
4335 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00004336 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004337 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
4338 const APInt &CVal = CI->getValue();
4339 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004340 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00004341 } else {
4342 // In this case we could have the operand of the binary operation
4343 // being defined in another block, and performing the replacement
4344 // could break the dominance relation.
4345 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004346 }
4347 } else {
4348 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00004349 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004350 }
4351 }
4352
4353 // Recognize patterns
4354 switch (I.getPredicate()) {
4355 case ICmpInst::ICMP_EQ:
4356 case ICmpInst::ICMP_NE:
4357 // Recognize pattern:
4358 // mulval = mul(zext A, zext B)
4359 // cmp eq/neq mulval, zext trunc mulval
4360 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
4361 if (Zext->hasOneUse()) {
4362 Value *ZextArg = Zext->getOperand(0);
4363 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
4364 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
4365 break; //Recognized
4366 }
4367
4368 // Recognize pattern:
4369 // mulval = mul(zext A, zext B)
4370 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
4371 ConstantInt *CI;
4372 Value *ValToMask;
4373 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
4374 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00004375 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004376 const APInt &CVal = CI->getValue() + 1;
4377 if (CVal.isPowerOf2()) {
4378 unsigned MaskWidth = CVal.logBase2();
4379 if (MaskWidth == MulWidth)
4380 break; // Recognized
4381 }
4382 }
Craig Topperf40110f2014-04-25 05:29:35 +00004383 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004384
4385 case ICmpInst::ICMP_UGT:
4386 // Recognize pattern:
4387 // mulval = mul(zext A, zext B)
4388 // cmp ugt mulval, max
4389 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4390 APInt MaxVal = APInt::getMaxValue(MulWidth);
4391 MaxVal = MaxVal.zext(CI->getBitWidth());
4392 if (MaxVal.eq(CI->getValue()))
4393 break; // Recognized
4394 }
Craig Topperf40110f2014-04-25 05:29:35 +00004395 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004396
4397 case ICmpInst::ICMP_UGE:
4398 // Recognize pattern:
4399 // mulval = mul(zext A, zext B)
4400 // cmp uge mulval, max+1
4401 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4402 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
4403 if (MaxVal.eq(CI->getValue()))
4404 break; // Recognized
4405 }
Craig Topperf40110f2014-04-25 05:29:35 +00004406 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004407
4408 case ICmpInst::ICMP_ULE:
4409 // Recognize pattern:
4410 // mulval = mul(zext A, zext B)
4411 // cmp ule mulval, max
4412 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4413 APInt MaxVal = APInt::getMaxValue(MulWidth);
4414 MaxVal = MaxVal.zext(CI->getBitWidth());
4415 if (MaxVal.eq(CI->getValue()))
4416 break; // Recognized
4417 }
Craig Topperf40110f2014-04-25 05:29:35 +00004418 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004419
4420 case ICmpInst::ICMP_ULT:
4421 // Recognize pattern:
4422 // mulval = mul(zext A, zext B)
4423 // cmp ule mulval, max + 1
4424 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004425 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004426 if (MaxVal.eq(CI->getValue()))
4427 break; // Recognized
4428 }
Craig Topperf40110f2014-04-25 05:29:35 +00004429 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004430
4431 default:
Craig Topperf40110f2014-04-25 05:29:35 +00004432 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004433 }
4434
Craig Topperbb4069e2017-07-07 23:16:26 +00004435 InstCombiner::BuilderTy &Builder = IC.Builder;
4436 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004437
4438 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
4439 Value *MulA = A, *MulB = B;
4440 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004441 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004442 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004443 MulB = Builder.CreateZExt(B, MulType);
James Y Knight7976eb52019-02-01 20:43:25 +00004444 Function *F = Intrinsic::getDeclaration(
4445 I.getModule(), Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004446 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004447 IC.Worklist.Add(MulInstr);
4448
4449 // If there are uses of mul result other than the comparison, we know that
4450 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004451 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004452 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004453 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004454 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4455 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004456 if (U == &I || U == OtherVal)
4457 continue;
4458 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4459 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004460 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004461 else
4462 TI->setOperand(0, Mul);
4463 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4464 assert(BO->getOpcode() == Instruction::And);
4465 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004466 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4467 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004468 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004469 Instruction *Zext =
4470 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4471 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004472 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004473 } else {
4474 llvm_unreachable("Unexpected Binary operation");
4475 }
Davide Italiano579064e2017-07-16 18:56:30 +00004476 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004477 }
4478 }
4479 if (isa<Instruction>(OtherVal))
4480 IC.Worklist.Add(cast<Instruction>(OtherVal));
4481
4482 // The original icmp gets replaced with the overflow value, maybe inverted
4483 // depending on predicate.
4484 bool Inverse = false;
4485 switch (I.getPredicate()) {
4486 case ICmpInst::ICMP_NE:
4487 break;
4488 case ICmpInst::ICMP_EQ:
4489 Inverse = true;
4490 break;
4491 case ICmpInst::ICMP_UGT:
4492 case ICmpInst::ICMP_UGE:
4493 if (I.getOperand(0) == MulVal)
4494 break;
4495 Inverse = true;
4496 break;
4497 case ICmpInst::ICMP_ULT:
4498 case ICmpInst::ICMP_ULE:
4499 if (I.getOperand(1) == MulVal)
4500 break;
4501 Inverse = true;
4502 break;
4503 default:
4504 llvm_unreachable("Unexpected predicate");
4505 }
4506 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004507 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004508 return BinaryOperator::CreateNot(Res);
4509 }
4510
4511 return ExtractValueInst::Create(Call, 1);
4512}
4513
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004514/// When performing a comparison against a constant, it is possible that not all
4515/// the bits in the LHS are demanded. This helper method computes the mask that
4516/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004517static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004518 const APInt *RHS;
4519 if (!match(I.getOperand(1), m_APInt(RHS)))
4520 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004521
Craig Topper3edda872017-09-22 18:57:23 +00004522 // If this is a normal comparison, it demands all bits. If it is a sign bit
4523 // comparison, it only demands the sign bit.
4524 bool UnusedBit;
4525 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4526 return APInt::getSignMask(BitWidth);
4527
Owen Andersond490c2d2011-01-11 00:36:45 +00004528 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004529 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004530 // correspond to the trailing ones of the comparand. The value of these
4531 // bits doesn't impact the outcome of the comparison, because any value
4532 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004533 case ICmpInst::ICMP_UGT:
4534 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004535
Owen Andersond490c2d2011-01-11 00:36:45 +00004536 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4537 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004538 case ICmpInst::ICMP_ULT:
4539 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004540
Owen Andersond490c2d2011-01-11 00:36:45 +00004541 default:
4542 return APInt::getAllOnesValue(BitWidth);
4543 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004544}
Chris Lattner2188e402010-01-04 07:37:31 +00004545
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004546/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004547/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004548/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004549/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004550/// The rationale is that several architectures use the same instruction for
4551/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004552/// match.
4553/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004554static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4555 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004556 // FIXME: we may want to go through inttoptrs or bitcasts.
4557 if (Op0->getType()->isPointerTy())
4558 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004559 // If a subtract already has the same operands as a compare, swapping would be
4560 // bad. If a subtract has the same operands as a compare but in reverse order,
4561 // then swapping is good.
4562 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004563 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004564 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4565 GoodToSwap++;
4566 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4567 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004568 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004569 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004570}
4571
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004572/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004573/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004574///
4575/// \param DI Definition
4576/// \param UI Use
4577/// \param DB Block that must dominate all uses of \p DI outside
4578/// the parent block
4579/// \return true when \p UI is the only use of \p DI in the parent block
4580/// and all other uses of \p DI are in blocks dominated by \p DB.
4581///
4582bool InstCombiner::dominatesAllUses(const Instruction *DI,
4583 const Instruction *UI,
4584 const BasicBlock *DB) const {
4585 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004586 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004587 if (!DI->getParent())
4588 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004589 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004590 if (DI->getParent() != UI->getParent())
4591 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004592 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004593 if (DI->getParent() == DB)
4594 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004595 for (const User *U : DI->users()) {
4596 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004597 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004598 return false;
4599 }
4600 return true;
4601}
4602
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004603/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004604static bool isChainSelectCmpBranch(const SelectInst *SI) {
4605 const BasicBlock *BB = SI->getParent();
4606 if (!BB)
4607 return false;
4608 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4609 if (!BI || BI->getNumSuccessors() != 2)
4610 return false;
4611 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4612 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4613 return false;
4614 return true;
4615}
4616
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004617/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004618/// in select-icmp sequence. This will eventually result in the elimination
4619/// of the select.
4620///
4621/// \param SI Select instruction
4622/// \param Icmp Compare instruction
4623/// \param SIOpd Operand that replaces the select
4624///
4625/// Notes:
4626/// - The replacement is global and requires dominator information
4627/// - The caller is responsible for the actual replacement
4628///
4629/// Example:
4630///
4631/// entry:
4632/// %4 = select i1 %3, %C* %0, %C* null
4633/// %5 = icmp eq %C* %4, null
4634/// br i1 %5, label %9, label %7
4635/// ...
4636/// ; <label>:7 ; preds = %entry
4637/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4638/// ...
4639///
4640/// can be transformed to
4641///
4642/// %5 = icmp eq %C* %0, null
4643/// %6 = select i1 %3, i1 %5, i1 true
4644/// br i1 %6, label %9, label %7
4645/// ...
4646/// ; <label>:7 ; preds = %entry
4647/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4648///
4649/// Similar when the first operand of the select is a constant or/and
4650/// the compare is for not equal rather than equal.
4651///
4652/// NOTE: The function is only called when the select and compare constants
4653/// are equal, the optimization can work only for EQ predicates. This is not a
4654/// major restriction since a NE compare should be 'normalized' to an equal
4655/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004656/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004657bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4658 const ICmpInst *Icmp,
4659 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004660 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004661 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4662 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004663 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004664 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004665 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4666 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4667 // replaced can be reached on either path. So the uniqueness check
4668 // guarantees that the path all uses of SI (outside SI's parent) are on
4669 // is disjoint from all other paths out of SI. But that information
4670 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004671 // of compile-time. It should also be noticed that we check for a single
4672 // predecessor and not only uniqueness. This to handle the situation when
4673 // Succ and Succ1 points to the same basic block.
4674 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004675 NumSel++;
4676 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4677 return true;
4678 }
4679 }
4680 return false;
4681}
4682
Sanjay Patel3151dec2016-09-12 15:24:31 +00004683/// Try to fold the comparison based on range information we can get by checking
4684/// whether bits are known to be zero or one in the inputs.
4685Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4686 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4687 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004688 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004689
4690 // Get scalar or pointer size.
4691 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4692 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004693 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004694
4695 if (!BitWidth)
4696 return nullptr;
4697
Craig Topperb45eabc2017-04-26 16:39:58 +00004698 KnownBits Op0Known(BitWidth);
4699 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004700
Craig Topper47596dd2017-03-25 06:52:52 +00004701 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004702 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004703 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004704 return &I;
4705
Craig Topper47596dd2017-03-25 06:52:52 +00004706 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004707 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004708 return &I;
4709
4710 // Given the known and unknown bits, compute a range that the LHS could be
4711 // in. Compute the Min, Max and RHS values based on the known bits. For the
4712 // EQ and NE we use unsigned values.
4713 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4714 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4715 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004716 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4717 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004718 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004719 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4720 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004721 }
4722
Sanjay Patelc63f9012018-01-04 14:31:56 +00004723 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4724 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004725 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004726 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004727 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004728 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004729 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004730
4731 // Based on the range information we know about the LHS, see if we can
4732 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004733 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004734 default:
4735 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004736 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004737 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004738 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4739 return Pred == CmpInst::ICMP_EQ
4740 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4741 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4742 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004743
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004744 // If all bits are known zero except for one, then we know at most one bit
4745 // is set. If the comparison is against zero, then this is a check to see if
4746 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004747 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004748 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004749 // If the LHS is an AND with the same constant, look through it.
4750 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004751 const APInt *LHSC;
4752 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4753 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004754 LHS = Op0;
4755
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004756 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004757 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4758 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004759 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004760 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004761 // ((1 << X) & 8) == 0 -> X != 3
4762 // ((1 << X) & 8) != 0 -> X == 3
4763 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4764 auto NewPred = ICmpInst::getInversePredicate(Pred);
4765 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004766 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004767 // ((1 << X) & 7) == 0 -> X >= 3
4768 // ((1 << X) & 7) != 0 -> X < 3
4769 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4770 auto NewPred =
4771 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4772 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004773 }
4774 }
4775
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004776 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004777 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004778 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004779 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4780 // ((8 >>u X) & 1) == 0 -> X != 3
4781 // ((8 >>u X) & 1) != 0 -> X == 3
4782 unsigned CmpVal = CI->countTrailingZeros();
4783 auto NewPred = ICmpInst::getInversePredicate(Pred);
4784 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4785 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004786 }
4787 break;
4788 }
4789 case ICmpInst::ICMP_ULT: {
4790 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4791 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4792 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4793 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4794 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4795 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4796
Craig Topper0cd25942017-09-27 22:57:18 +00004797 const APInt *CmpC;
4798 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004799 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004800 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004801 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004802 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004803 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4804 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004805 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004806 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4807 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004808 }
4809 break;
4810 }
4811 case ICmpInst::ICMP_UGT: {
4812 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4813 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004814 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4815 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004816 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4817 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4818
Craig Topper0cd25942017-09-27 22:57:18 +00004819 const APInt *CmpC;
4820 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004821 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004822 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004823 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004824 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004825 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4826 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004827 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004828 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4829 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004830 }
4831 break;
4832 }
Craig Topper0cd25942017-09-27 22:57:18 +00004833 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004834 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4835 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4836 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4837 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4838 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4839 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004840 const APInt *CmpC;
4841 if (match(Op1, m_APInt(CmpC))) {
4842 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004843 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004844 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004845 }
4846 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004847 }
4848 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004849 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4850 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4851 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4852 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004853 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4854 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004855 const APInt *CmpC;
4856 if (match(Op1, m_APInt(CmpC))) {
4857 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004858 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004859 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004860 }
4861 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004862 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004863 case ICmpInst::ICMP_SGE:
4864 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4865 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4866 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4867 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4868 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004869 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4870 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004871 break;
4872 case ICmpInst::ICMP_SLE:
4873 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4874 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4875 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4876 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4877 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004878 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4879 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004880 break;
4881 case ICmpInst::ICMP_UGE:
4882 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4883 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4884 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4885 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4886 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004887 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4888 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004889 break;
4890 case ICmpInst::ICMP_ULE:
4891 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4892 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4893 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4894 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4895 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004896 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4897 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004898 break;
4899 }
4900
4901 // Turn a signed comparison into an unsigned one if both operands are known to
4902 // have the same sign.
4903 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004904 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4905 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004906 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4907
4908 return nullptr;
4909}
4910
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004911llvm::Optional<std::pair<CmpInst::Predicate, Constant *>>
4912llvm::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred,
4913 Constant *C) {
4914 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) &&
Roman Lebedev2c75fe72019-08-24 06:49:25 +00004915 "Only for relational integer predicates.");
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004916
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004917 Type *Type = C->getType();
4918 bool IsSigned = ICmpInst::isSigned(Pred);
Roman Lebedev2c75fe72019-08-24 06:49:25 +00004919
4920 CmpInst::Predicate UnsignedPred = ICmpInst::getUnsignedPredicate(Pred);
4921 bool WillIncrement =
4922 UnsignedPred == ICmpInst::ICMP_ULE || UnsignedPred == ICmpInst::ICMP_UGT;
4923
4924 // Check if the constant operand can be safely incremented/decremented
4925 // without overflowing/underflowing.
4926 auto ConstantIsOk = [WillIncrement, IsSigned](ConstantInt *C) {
4927 return WillIncrement ? !C->isMaxValue(IsSigned) : !C->isMinValue(IsSigned);
4928 };
4929
4930 // For scalars, SimplifyICmpInst should have already handled
4931 // the edge cases for us, so we just assert on them.
4932 // For vectors, we must handle the edge cases.
4933 if (auto *CI = dyn_cast<ConstantInt>(C)) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004934 // A <= MAX -> TRUE ; A >= MIN -> TRUE
Roman Lebedev2c75fe72019-08-24 06:49:25 +00004935 assert(ConstantIsOk(CI));
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004936 } else if (Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004937 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004938 // are for scalar, we could remove the min/max checks. However, to do that,
4939 // we would have to use insertelement/shufflevector to replace edge values.
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004940 unsigned NumElts = Type->getVectorNumElements();
Sanjay Patele9b2c322016-05-17 00:57:57 +00004941 for (unsigned i = 0; i != NumElts; ++i) {
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004942 Constant *Elt = C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004943 if (!Elt)
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004944 return llvm::None;
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004945
Sanjay Patele9b2c322016-05-17 00:57:57 +00004946 if (isa<UndefValue>(Elt))
4947 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004948
Sanjay Patele9b2c322016-05-17 00:57:57 +00004949 // Bail out if we can't determine if this constant is min/max or if we
4950 // know that this constant is min/max.
4951 auto *CI = dyn_cast<ConstantInt>(Elt);
Roman Lebedev2c75fe72019-08-24 06:49:25 +00004952 if (!CI || !ConstantIsOk(CI))
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004953 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004954 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004955 } else {
4956 // ConstantExpr?
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004957 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004958 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004959
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004960 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred);
4961
4962 // Increment or decrement the constant.
Roman Lebedev2c75fe72019-08-24 06:49:25 +00004963 Constant *OneOrNegOne = ConstantInt::get(Type, WillIncrement ? 1 : -1, true);
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004964 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne);
4965
4966 return std::make_pair(NewPred, NewC);
4967}
4968
4969/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4970/// it into the appropriate icmp lt or icmp gt instruction. This transform
4971/// allows them to be folded in visitICmpInst.
4972static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4973 ICmpInst::Predicate Pred = I.getPredicate();
4974 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) ||
4975 isCanonicalPredicate(Pred))
4976 return nullptr;
4977
4978 Value *Op0 = I.getOperand(0);
4979 Value *Op1 = I.getOperand(1);
4980 auto *Op1C = dyn_cast<Constant>(Op1);
4981 if (!Op1C)
4982 return nullptr;
4983
4984 auto FlippedStrictness = getFlippedStrictnessPredicateAndConstant(Pred, Op1C);
4985 if (!FlippedStrictness)
4986 return nullptr;
4987
4988 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second);
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004989}
4990
Sanjay Patele5747e32017-05-17 22:15:07 +00004991/// Integer compare with boolean values can always be turned into bitwise ops.
4992static Instruction *canonicalizeICmpBool(ICmpInst &I,
4993 InstCombiner::BuilderTy &Builder) {
4994 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004995 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004996
Sanjay Patelba212c22017-05-17 22:29:40 +00004997 // A boolean compared to true/false can be simplified to Op0/true/false in
4998 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4999 // Cases not handled by InstSimplify are always 'not' of Op0.
5000 if (match(B, m_Zero())) {
5001 switch (I.getPredicate()) {
5002 case CmpInst::ICMP_EQ: // A == 0 -> !A
5003 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
5004 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
5005 return BinaryOperator::CreateNot(A);
5006 default:
5007 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
5008 }
5009 } else if (match(B, m_One())) {
5010 switch (I.getPredicate()) {
5011 case CmpInst::ICMP_NE: // A != 1 -> !A
5012 case CmpInst::ICMP_ULT: // A <u 1 -> !A
5013 case CmpInst::ICMP_SGT: // A >s -1 -> !A
5014 return BinaryOperator::CreateNot(A);
5015 default:
5016 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
5017 }
5018 }
5019
Sanjay Patele5747e32017-05-17 22:15:07 +00005020 switch (I.getPredicate()) {
5021 default:
5022 llvm_unreachable("Invalid icmp instruction!");
5023 case ICmpInst::ICMP_EQ:
5024 // icmp eq i1 A, B -> ~(A ^ B)
5025 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
5026
5027 case ICmpInst::ICMP_NE:
5028 // icmp ne i1 A, B -> A ^ B
5029 return BinaryOperator::CreateXor(A, B);
5030
5031 case ICmpInst::ICMP_UGT:
5032 // icmp ugt -> icmp ult
5033 std::swap(A, B);
5034 LLVM_FALLTHROUGH;
5035 case ICmpInst::ICMP_ULT:
5036 // icmp ult i1 A, B -> ~A & B
5037 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
5038
5039 case ICmpInst::ICMP_SGT:
5040 // icmp sgt -> icmp slt
5041 std::swap(A, B);
5042 LLVM_FALLTHROUGH;
5043 case ICmpInst::ICMP_SLT:
5044 // icmp slt i1 A, B -> A & ~B
5045 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
5046
5047 case ICmpInst::ICMP_UGE:
5048 // icmp uge -> icmp ule
5049 std::swap(A, B);
5050 LLVM_FALLTHROUGH;
5051 case ICmpInst::ICMP_ULE:
5052 // icmp ule i1 A, B -> ~A | B
5053 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
5054
5055 case ICmpInst::ICMP_SGE:
5056 // icmp sge -> icmp sle
5057 std::swap(A, B);
5058 LLVM_FALLTHROUGH;
5059 case ICmpInst::ICMP_SLE:
5060 // icmp sle i1 A, B -> A | ~B
5061 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
5062 }
5063}
5064
Roman Lebedev75404fb2018-09-12 18:19:43 +00005065// Transform pattern like:
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005066// (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X
5067// (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X
Roman Lebedev75404fb2018-09-12 18:19:43 +00005068// Into:
5069// (X l>> Y) != 0
5070// (X l>> Y) == 0
5071static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp,
5072 InstCombiner::BuilderTy &Builder) {
Roman Lebedev6dc87002018-09-13 20:33:12 +00005073 ICmpInst::Predicate Pred, NewPred;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005074 Value *X, *Y;
Roman Lebedev6dc87002018-09-13 20:33:12 +00005075 if (match(&Cmp,
5076 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) {
5077 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5078 if (Cmp.getOperand(0) == X)
5079 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005080
Roman Lebedev6dc87002018-09-13 20:33:12 +00005081 switch (Pred) {
5082 case ICmpInst::ICMP_ULE:
5083 NewPred = ICmpInst::ICMP_NE;
5084 break;
5085 case ICmpInst::ICMP_UGT:
5086 NewPred = ICmpInst::ICMP_EQ;
5087 break;
5088 default:
5089 return nullptr;
5090 }
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005091 } else if (match(&Cmp, m_c_ICmp(Pred,
5092 m_OneUse(m_CombineOr(
5093 m_Not(m_Shl(m_AllOnes(), m_Value(Y))),
5094 m_Add(m_Shl(m_One(), m_Value(Y)),
5095 m_AllOnes()))),
5096 m_Value(X)))) {
5097 // The variant with 'add' is not canonical, (the variant with 'not' is)
5098 // we only get it because it has extra uses, and can't be canonicalized,
5099
Roman Lebedev6dc87002018-09-13 20:33:12 +00005100 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5101 if (Cmp.getOperand(0) == X)
5102 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005103
Roman Lebedev6dc87002018-09-13 20:33:12 +00005104 switch (Pred) {
5105 case ICmpInst::ICMP_ULT:
5106 NewPred = ICmpInst::ICMP_NE;
5107 break;
5108 case ICmpInst::ICMP_UGE:
5109 NewPred = ICmpInst::ICMP_EQ;
5110 break;
5111 default:
5112 return nullptr;
5113 }
5114 } else
Roman Lebedev75404fb2018-09-12 18:19:43 +00005115 return nullptr;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005116
5117 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits");
5118 Constant *Zero = Constant::getNullValue(NewX->getType());
5119 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero);
5120}
5121
Sanjay Patel039f5562018-08-16 12:52:17 +00005122static Instruction *foldVectorCmp(CmpInst &Cmp,
5123 InstCombiner::BuilderTy &Builder) {
5124 // If both arguments of the cmp are shuffles that use the same mask and
5125 // shuffle within a single vector, move the shuffle after the cmp.
5126 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
5127 Value *V1, *V2;
5128 Constant *M;
5129 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
5130 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
5131 V1->getType() == V2->getType() &&
5132 (LHS->hasOneUse() || RHS->hasOneUse())) {
5133 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
5134 CmpInst::Predicate P = Cmp.getPredicate();
5135 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
5136 : Builder.CreateFCmp(P, V1, V2);
5137 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
5138 }
5139 return nullptr;
5140}
5141
Chris Lattner2188e402010-01-04 07:37:31 +00005142Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
5143 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00005144 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00005145 unsigned Op0Cplxity = getComplexity(Op0);
5146 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005147
Chris Lattner2188e402010-01-04 07:37:31 +00005148 /// Orders the operands of the compare so that they are listed from most
5149 /// complex to least complex. This puts constants before unary operators,
5150 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00005151 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00005152 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00005153 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00005154 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00005155 Changed = true;
5156 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005157
Daniel Berlin2c75c632017-04-26 20:56:07 +00005158 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
5159 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005160 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005161
Uriel Korach18972232017-09-10 08:31:22 +00005162 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00005163 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00005164 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005165 Value *Cond, *SelectTrue, *SelectFalse;
5166 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00005167 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005168 if (Value *V = dyn_castNegVal(SelectTrue)) {
5169 if (V == SelectFalse)
5170 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
5171 }
5172 else if (Value *V = dyn_castNegVal(SelectFalse)) {
5173 if (V == SelectTrue)
5174 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00005175 }
5176 }
5177 }
5178
Craig Topperfde47232017-07-09 07:04:03 +00005179 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00005180 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00005181 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005182
Sanjay Patele9b2c322016-05-17 00:57:57 +00005183 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005184 return NewICmp;
5185
Sanjay Patel06b127a2016-09-15 14:37:50 +00005186 if (Instruction *Res = foldICmpWithConstant(I))
5187 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005188
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00005189 if (Instruction *Res = foldICmpWithDominatingICmp(I))
5190 return Res;
5191
Max Kazantsev20da7e42018-07-06 04:04:13 +00005192 if (Instruction *Res = foldICmpUsingKnownBits(I))
5193 return Res;
5194
Chris Lattner2188e402010-01-04 07:37:31 +00005195 // Test if the ICmpInst instruction is used exclusively by a select as
5196 // part of a minimum or maximum operation. If so, refrain from doing
5197 // any other folding. This helps out other analyses which understand
5198 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5199 // and CodeGen. And in this case, at least one of the comparison
5200 // operands has at least one user besides the compare (the select),
5201 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00005202 //
5203 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00005204 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005205 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5206 Value *A, *B;
5207 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5208 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00005209 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005210 }
Chris Lattner2188e402010-01-04 07:37:31 +00005211
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00005212 // Do this after checking for min/max to prevent infinite looping.
5213 if (Instruction *Res = foldICmpWithZero(I))
5214 return Res;
5215
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00005216 // FIXME: We only do this after checking for min/max to prevent infinite
5217 // looping caused by a reverse canonicalization of these patterns for min/max.
5218 // FIXME: The organization of folds is a mess. These would naturally go into
5219 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
5220 // down here after the min/max restriction.
5221 ICmpInst::Predicate Pred = I.getPredicate();
5222 const APInt *C;
5223 if (match(Op1, m_APInt(C))) {
5224 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
5225 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
5226 Constant *Zero = Constant::getNullValue(Op0->getType());
5227 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
5228 }
5229
5230 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
5231 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
5232 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
5233 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
5234 }
5235 }
5236
Sanjay Patelf58f68c2016-09-10 15:03:44 +00005237 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00005238 return Res;
5239
Sanjay Patel10494b22016-09-16 16:10:22 +00005240 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
5241 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005242
5243 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
5244 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00005245 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00005246 return NI;
5247 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00005248 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00005249 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
5250 return NI;
5251
Hans Wennborgf1f36512015-10-07 00:20:07 +00005252 // Try to optimize equality comparisons against alloca-based pointers.
5253 if (Op0->getType()->isPointerTy() && I.isEquality()) {
5254 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
5255 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005256 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005257 return New;
5258 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005259 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005260 return New;
5261 }
5262
Sanjay Patele7f46c32019-02-07 20:54:09 +00005263 if (Instruction *Res = foldICmpBitCast(I, Builder))
5264 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005265
Sanjay Patela90ee0e2019-08-20 14:56:44 +00005266 if (Instruction *R = foldICmpWithCastOp(I))
5267 return R;
Chris Lattner2188e402010-01-04 07:37:31 +00005268
Sanjay Patel10494b22016-09-16 16:10:22 +00005269 if (Instruction *Res = foldICmpBinOp(I))
5270 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00005271
Sanjay Pateldd46b522016-12-19 17:32:37 +00005272 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00005273 return Res;
5274
Sanjay Patel10494b22016-09-16 16:10:22 +00005275 {
5276 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00005277 // Transform (A & ~B) == 0 --> (A & B) != 0
5278 // and (A & ~B) != 0 --> (A & B) == 0
5279 // if A is a power of 2.
5280 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00005281 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00005282 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00005283 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00005284 Op1);
5285
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005286 // ~X < ~Y --> Y < X
5287 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005288 if (match(Op0, m_Not(m_Value(A)))) {
5289 if (match(Op1, m_Not(m_Value(B))))
5290 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005291
Sanjay Patelce241f42017-06-02 16:29:41 +00005292 const APInt *C;
5293 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005294 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00005295 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005296 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00005297
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005298 Instruction *AddI = nullptr;
5299 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
5300 m_Instruction(AddI))) &&
5301 isa<IntegerType>(A->getType())) {
5302 Value *Result;
5303 Constant *Overflow;
Nikita Popov352f5982019-05-26 11:43:31 +00005304 if (OptimizeOverflowCheck(Instruction::Add, /*Signed*/false, A, B,
5305 *AddI, Result, Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00005306 replaceInstUsesWith(*AddI, Result);
5307 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005308 }
5309 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005310
5311 // (zext a) * (zext b) --> llvm.umul.with.overflow.
5312 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005313 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005314 return R;
5315 }
5316 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005317 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005318 return R;
5319 }
Chris Lattner2188e402010-01-04 07:37:31 +00005320 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005321
Sanjay Patel10494b22016-09-16 16:10:22 +00005322 if (Instruction *Res = foldICmpEquality(I))
5323 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005324
David Majnemerc1eca5a2014-11-06 23:23:30 +00005325 // The 'cmpxchg' instruction returns an aggregate containing the old value and
5326 // an i1 which indicates whether or not we successfully did the swap.
5327 //
5328 // Replace comparisons between the old value and the expected value with the
5329 // indicator that 'cmpxchg' returns.
5330 //
5331 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
5332 // spuriously fail. In those cases, the old value may equal the expected
5333 // value but it is possible for the swap to not occur.
5334 if (I.getPredicate() == ICmpInst::ICMP_EQ)
5335 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
5336 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
5337 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
5338 !ACXI->isWeak())
5339 return ExtractValueInst::Create(ACXI, 1);
5340
Chris Lattner2188e402010-01-04 07:37:31 +00005341 {
Craig Topperbee74792018-08-20 23:04:25 +00005342 Value *X;
5343 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00005344 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00005345 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
5346 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005347
5348 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00005349 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
5350 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005351 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00005352
Roman Lebedev75404fb2018-09-12 18:19:43 +00005353 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder))
5354 return Res;
5355
Sanjay Patel039f5562018-08-16 12:52:17 +00005356 if (I.getType()->isVectorTy())
5357 if (Instruction *Res = foldVectorCmp(I, Builder))
5358 return Res;
5359
Craig Topperf40110f2014-04-25 05:29:35 +00005360 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005361}
5362
Sanjay Patel5f0217f2016-06-05 16:46:18 +00005363/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00005364Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00005365 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00005366 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005367 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005368
Chris Lattner2188e402010-01-04 07:37:31 +00005369 // Get the width of the mantissa. We don't want to hack on conversions that
5370 // might lose information from the integer, e.g. "i64 -> float"
5371 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00005372 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005373
Matt Arsenault55e73122015-01-06 15:50:59 +00005374 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
5375
Chris Lattner2188e402010-01-04 07:37:31 +00005376 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005377
Matt Arsenault55e73122015-01-06 15:50:59 +00005378 if (I.isEquality()) {
5379 FCmpInst::Predicate P = I.getPredicate();
5380 bool IsExact = false;
5381 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
5382 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
5383
5384 // If the floating point constant isn't an integer value, we know if we will
5385 // ever compare equal / not equal to it.
5386 if (!IsExact) {
5387 // TODO: Can never be -0.0 and other non-representable values
5388 APFloat RHSRoundInt(RHS);
5389 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
5390 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
5391 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00005392 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00005393
5394 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00005395 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00005396 }
5397 }
5398
5399 // TODO: If the constant is exactly representable, is it always OK to do
5400 // equality compares as integer?
5401 }
5402
Arch D. Robison8ed08542015-09-15 17:51:59 +00005403 // Check to see that the input is converted from an integer type that is small
5404 // enough that preserves all bits. TODO: check here for "known" sign bits.
5405 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
5406 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00005407
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005408 // Following test does NOT adjust InputSize downwards for signed inputs,
5409 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00005410 // to distinguish it from one less than that value.
5411 if ((int)InputSize > MantissaWidth) {
5412 // Conversion would lose accuracy. Check if loss can impact comparison.
5413 int Exp = ilogb(RHS);
5414 if (Exp == APFloat::IEK_Inf) {
5415 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005416 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005417 // Conversion could create infinity.
5418 return nullptr;
5419 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005420 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00005421 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005422 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005423 // Conversion could affect comparison.
5424 return nullptr;
5425 }
5426 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005427
Chris Lattner2188e402010-01-04 07:37:31 +00005428 // Otherwise, we can potentially simplify the comparison. We know that it
5429 // will always come through as an integer value and we know the constant is
5430 // not a NAN (it would have been previously simplified).
5431 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00005432
Chris Lattner2188e402010-01-04 07:37:31 +00005433 ICmpInst::Predicate Pred;
5434 switch (I.getPredicate()) {
5435 default: llvm_unreachable("Unexpected predicate!");
5436 case FCmpInst::FCMP_UEQ:
5437 case FCmpInst::FCMP_OEQ:
5438 Pred = ICmpInst::ICMP_EQ;
5439 break;
5440 case FCmpInst::FCMP_UGT:
5441 case FCmpInst::FCMP_OGT:
5442 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
5443 break;
5444 case FCmpInst::FCMP_UGE:
5445 case FCmpInst::FCMP_OGE:
5446 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
5447 break;
5448 case FCmpInst::FCMP_ULT:
5449 case FCmpInst::FCMP_OLT:
5450 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
5451 break;
5452 case FCmpInst::FCMP_ULE:
5453 case FCmpInst::FCMP_OLE:
5454 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
5455 break;
5456 case FCmpInst::FCMP_UNE:
5457 case FCmpInst::FCMP_ONE:
5458 Pred = ICmpInst::ICMP_NE;
5459 break;
5460 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00005461 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005462 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00005463 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005464 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005465
Chris Lattner2188e402010-01-04 07:37:31 +00005466 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005467
Chris Lattner2188e402010-01-04 07:37:31 +00005468 // See if the FP constant is too large for the integer. For example,
5469 // comparing an i8 to 300.0.
5470 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005471
Chris Lattner2188e402010-01-04 07:37:31 +00005472 if (!LHSUnsigned) {
5473 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5474 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005475 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005476 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5477 APFloat::rmNearestTiesToEven);
5478 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5479 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5480 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005481 return replaceInstUsesWith(I, Builder.getTrue());
5482 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005483 }
5484 } else {
5485 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5486 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005487 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005488 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5489 APFloat::rmNearestTiesToEven);
5490 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5491 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5492 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005493 return replaceInstUsesWith(I, Builder.getTrue());
5494 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005495 }
5496 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005497
Chris Lattner2188e402010-01-04 07:37:31 +00005498 if (!LHSUnsigned) {
5499 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005500 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005501 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5502 APFloat::rmNearestTiesToEven);
5503 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5504 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5505 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005506 return replaceInstUsesWith(I, Builder.getTrue());
5507 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005508 }
Devang Patel698452b2012-02-13 23:05:18 +00005509 } else {
5510 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005511 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005512 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5513 APFloat::rmNearestTiesToEven);
5514 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5515 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5516 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005517 return replaceInstUsesWith(I, Builder.getTrue());
5518 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005519 }
Chris Lattner2188e402010-01-04 07:37:31 +00005520 }
5521
5522 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5523 // [0, UMAX], but it may still be fractional. See if it is fractional by
5524 // casting the FP value to the integer value and back, checking for equality.
5525 // Don't do this for zero, because -0.0 is not fractional.
5526 Constant *RHSInt = LHSUnsigned
5527 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5528 : ConstantExpr::getFPToSI(RHSC, IntTy);
5529 if (!RHS.isZero()) {
5530 bool Equal = LHSUnsigned
5531 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5532 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5533 if (!Equal) {
5534 // If we had a comparison against a fractional value, we have to adjust
5535 // the compare predicate and sometimes the value. RHSC is rounded towards
5536 // zero at this point.
5537 switch (Pred) {
5538 default: llvm_unreachable("Unexpected integer comparison!");
5539 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005540 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005541 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005542 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005543 case ICmpInst::ICMP_ULE:
5544 // (float)int <= 4.4 --> int <= 4
5545 // (float)int <= -4.4 --> false
5546 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005547 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005548 break;
5549 case ICmpInst::ICMP_SLE:
5550 // (float)int <= 4.4 --> int <= 4
5551 // (float)int <= -4.4 --> int < -4
5552 if (RHS.isNegative())
5553 Pred = ICmpInst::ICMP_SLT;
5554 break;
5555 case ICmpInst::ICMP_ULT:
5556 // (float)int < -4.4 --> false
5557 // (float)int < 4.4 --> int <= 4
5558 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005559 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005560 Pred = ICmpInst::ICMP_ULE;
5561 break;
5562 case ICmpInst::ICMP_SLT:
5563 // (float)int < -4.4 --> int < -4
5564 // (float)int < 4.4 --> int <= 4
5565 if (!RHS.isNegative())
5566 Pred = ICmpInst::ICMP_SLE;
5567 break;
5568 case ICmpInst::ICMP_UGT:
5569 // (float)int > 4.4 --> int > 4
5570 // (float)int > -4.4 --> true
5571 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005572 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005573 break;
5574 case ICmpInst::ICMP_SGT:
5575 // (float)int > 4.4 --> int > 4
5576 // (float)int > -4.4 --> int >= -4
5577 if (RHS.isNegative())
5578 Pred = ICmpInst::ICMP_SGE;
5579 break;
5580 case ICmpInst::ICMP_UGE:
5581 // (float)int >= -4.4 --> true
5582 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005583 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005584 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005585 Pred = ICmpInst::ICMP_UGT;
5586 break;
5587 case ICmpInst::ICMP_SGE:
5588 // (float)int >= -4.4 --> int >= -4
5589 // (float)int >= 4.4 --> int > 4
5590 if (!RHS.isNegative())
5591 Pred = ICmpInst::ICMP_SGT;
5592 break;
5593 }
5594 }
5595 }
5596
5597 // Lower this FP comparison into an appropriate integer version of the
5598 // comparison.
5599 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5600}
5601
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005602/// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary.
5603static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI,
5604 Constant *RHSC) {
5605 // When C is not 0.0 and infinities are not allowed:
5606 // (C / X) < 0.0 is a sign-bit test of X
5607 // (C / X) < 0.0 --> X < 0.0 (if C is positive)
5608 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate)
5609 //
5610 // Proof:
5611 // Multiply (C / X) < 0.0 by X * X / C.
5612 // - X is non zero, if it is the flag 'ninf' is violated.
5613 // - C defines the sign of X * X * C. Thus it also defines whether to swap
5614 // the predicate. C is also non zero by definition.
5615 //
5616 // Thus X * X / C is non zero and the transformation is valid. [qed]
5617
5618 FCmpInst::Predicate Pred = I.getPredicate();
5619
5620 // Check that predicates are valid.
5621 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) &&
5622 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE))
5623 return nullptr;
5624
5625 // Check that RHS operand is zero.
5626 if (!match(RHSC, m_AnyZeroFP()))
5627 return nullptr;
5628
5629 // Check fastmath flags ('ninf').
5630 if (!LHSI->hasNoInfs() || !I.hasNoInfs())
5631 return nullptr;
5632
5633 // Check the properties of the dividend. It must not be zero to avoid a
5634 // division by zero (see Proof).
5635 const APFloat *C;
5636 if (!match(LHSI->getOperand(0), m_APFloat(C)))
5637 return nullptr;
5638
5639 if (C->isZero())
5640 return nullptr;
5641
5642 // Get swapped predicate if necessary.
5643 if (C->isNegative())
5644 Pred = I.getSwappedPredicate();
5645
Sanjay Pateld1172a02018-11-07 00:00:42 +00005646 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I);
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005647}
5648
Sanjay Patel1c254c62018-10-31 16:34:43 +00005649/// Optimize fabs(X) compared with zero.
5650static Instruction *foldFabsWithFcmpZero(FCmpInst &I) {
5651 Value *X;
5652 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) ||
5653 !match(I.getOperand(1), m_PosZeroFP()))
5654 return nullptr;
5655
Sanjay Patel57a08b32018-11-07 16:15:01 +00005656 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) {
5657 I->setPredicate(P);
5658 I->setOperand(0, X);
5659 return I;
5660 };
5661
Sanjay Patel1c254c62018-10-31 16:34:43 +00005662 switch (I.getPredicate()) {
5663 case FCmpInst::FCMP_UGE:
5664 case FCmpInst::FCMP_OLT:
5665 // fabs(X) >= 0.0 --> true
5666 // fabs(X) < 0.0 --> false
5667 llvm_unreachable("fcmp should have simplified");
5668
5669 case FCmpInst::FCMP_OGT:
5670 // fabs(X) > 0.0 --> X != 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005671 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005672
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005673 case FCmpInst::FCMP_UGT:
5674 // fabs(X) u> 0.0 --> X u!= 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005675 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005676
Sanjay Patel1c254c62018-10-31 16:34:43 +00005677 case FCmpInst::FCMP_OLE:
5678 // fabs(X) <= 0.0 --> X == 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005679 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005680
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005681 case FCmpInst::FCMP_ULE:
5682 // fabs(X) u<= 0.0 --> X u== 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005683 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005684
Sanjay Patel1c254c62018-10-31 16:34:43 +00005685 case FCmpInst::FCMP_OGE:
5686 // fabs(X) >= 0.0 --> !isnan(X)
5687 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005688 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005689
Sanjay Patel76faf512018-11-07 15:11:32 +00005690 case FCmpInst::FCMP_ULT:
5691 // fabs(X) u< 0.0 --> isnan(X)
5692 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005693 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X);
Sanjay Patel76faf512018-11-07 15:11:32 +00005694
Sanjay Patel1c254c62018-10-31 16:34:43 +00005695 case FCmpInst::FCMP_OEQ:
5696 case FCmpInst::FCMP_UEQ:
5697 case FCmpInst::FCMP_ONE:
5698 case FCmpInst::FCMP_UNE:
Sanjay Patelbb521e62018-11-07 15:44:26 +00005699 case FCmpInst::FCMP_ORD:
5700 case FCmpInst::FCMP_UNO:
5701 // Look through the fabs() because it doesn't change anything but the sign.
5702 // fabs(X) == 0.0 --> X == 0.0,
Sanjay Patel1c254c62018-10-31 16:34:43 +00005703 // fabs(X) != 0.0 --> X != 0.0
Sanjay Patelbb521e62018-11-07 15:44:26 +00005704 // isnan(fabs(X)) --> isnan(X)
5705 // !isnan(fabs(X) --> !isnan(X)
Sanjay Patel57a08b32018-11-07 16:15:01 +00005706 return replacePredAndOp0(&I, I.getPredicate(), X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005707
5708 default:
5709 return nullptr;
5710 }
5711}
5712
Chris Lattner2188e402010-01-04 07:37:31 +00005713Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5714 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005715
Chris Lattner2188e402010-01-04 07:37:31 +00005716 /// Orders the operands of the compare so that they are listed from most
5717 /// complex to least complex. This puts constants before unary operators,
5718 /// before binary operators.
5719 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5720 I.swapOperands();
5721 Changed = true;
5722 }
5723
Sanjay Patel6b139462017-09-02 15:11:55 +00005724 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005725 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005726 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5727 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005728 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005729
5730 // Simplify 'fcmp pred X, X'
Sanjay Patela706b9a2019-04-29 19:23:44 +00005731 Type *OpType = Op0->getType();
5732 assert(OpType == Op1->getType() && "fcmp with different-typed operands?");
Chris Lattner2188e402010-01-04 07:37:31 +00005733 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005734 switch (Pred) {
5735 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005736 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5737 case FCmpInst::FCMP_ULT: // True if unordered or less than
5738 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5739 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5740 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5741 I.setPredicate(FCmpInst::FCMP_UNO);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005742 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005743 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005744
Chris Lattner2188e402010-01-04 07:37:31 +00005745 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5746 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5747 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5748 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5749 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5750 I.setPredicate(FCmpInst::FCMP_ORD);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005751 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005752 return &I;
5753 }
5754 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005755
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005756 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5757 // then canonicalize the operand to 0.0.
5758 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005759 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005760 I.setOperand(0, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005761 return &I;
5762 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005763 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005764 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005765 return &I;
5766 }
5767 }
5768
Sanjay Patel6a281a72019-05-07 18:58:07 +00005769 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y
5770 Value *X, *Y;
5771 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
5772 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I);
5773
James Molloy2b21a7c2015-05-20 18:41:25 +00005774 // Test if the FCmpInst instruction is used exclusively by a select as
5775 // part of a minimum or maximum operation. If so, refrain from doing
5776 // any other folding. This helps out other analyses which understand
5777 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5778 // and CodeGen. And in this case, at least one of the comparison
5779 // operands has at least one user besides the compare (the select),
5780 // which would often largely negate the benefit of folding anyway.
5781 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005782 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5783 Value *A, *B;
5784 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5785 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005786 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005787 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005788
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005789 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0:
5790 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0
5791 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005792 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005793 return &I;
5794 }
5795
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005796 // Handle fcmp with instruction LHS and constant RHS.
5797 Instruction *LHSI;
5798 Constant *RHSC;
5799 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) {
5800 switch (LHSI->getOpcode()) {
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005801 case Instruction::PHI:
5802 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5803 // block. If in the same block, we're encouraging jump threading. If
5804 // not, we are just pessimizing the code by making an i1 phi.
5805 if (LHSI->getParent() == I.getParent())
5806 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005807 return NV;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005808 break;
5809 case Instruction::SIToFP:
5810 case Instruction::UIToFP:
5811 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
5812 return NV;
5813 break;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005814 case Instruction::FDiv:
5815 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC))
5816 return NV;
5817 break;
5818 case Instruction::Load:
5819 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0)))
5820 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5821 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5822 !cast<LoadInst>(LHSI)->isVolatile())
5823 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
5824 return Res;
5825 break;
Sanjay Patel1c254c62018-10-31 16:34:43 +00005826 }
Chris Lattner2188e402010-01-04 07:37:31 +00005827 }
5828
Sanjay Pateld1172a02018-11-07 00:00:42 +00005829 if (Instruction *R = foldFabsWithFcmpZero(I))
5830 return R;
5831
Sanjay Patel70282a02018-11-06 15:49:45 +00005832 if (match(Op0, m_FNeg(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005833 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C
Sanjay Patel70282a02018-11-06 15:49:45 +00005834 Constant *C;
5835 if (match(Op1, m_Constant(C))) {
Sanjay Patel70282a02018-11-06 15:49:45 +00005836 Constant *NegC = ConstantExpr::getFNeg(C);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005837 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00005838 }
5839 }
Benjamin Kramerd159d942011-03-31 10:12:22 +00005840
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005841 if (match(Op0, m_FPExt(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005842 // fcmp (fpext X), (fpext Y) -> fcmp X, Y
5843 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType())
5844 return new FCmpInst(Pred, X, Y, "", &I);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005845
Sanjay Pateld1172a02018-11-07 00:00:42 +00005846 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless
Sanjay Patel724014a2018-11-06 17:20:20 +00005847 const APFloat *C;
5848 if (match(Op1, m_APFloat(C))) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005849 const fltSemantics &FPSem =
5850 X->getType()->getScalarType()->getFltSemantics();
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005851 bool Lossy;
Sanjay Patel724014a2018-11-06 17:20:20 +00005852 APFloat TruncC = *C;
5853 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005854
5855 // Avoid lossy conversions and denormals.
5856 // Zero is a special case that's OK to convert.
Sanjay Patel724014a2018-11-06 17:20:20 +00005857 APFloat Fabs = TruncC;
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005858 Fabs.clearSign();
5859 if (!Lossy &&
5860 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) !=
Sanjay Patel46bf3922018-11-06 16:45:27 +00005861 APFloat::cmpLessThan) || Fabs.isZero())) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005862 Constant *NewC = ConstantFP::get(X->getType(), TruncC);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005863 return new FCmpInst(Pred, X, NewC, "", &I);
Sanjay Patel46bf3922018-11-06 16:45:27 +00005864 }
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005865 }
Sanjay Patel1b85f0022018-11-06 16:23:03 +00005866 }
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005867
Sanjay Patel039f5562018-08-16 12:52:17 +00005868 if (I.getType()->isVectorTy())
5869 if (Instruction *Res = foldVectorCmp(I, Builder))
5870 return Res;
5871
Craig Topperf40110f2014-04-25 05:29:35 +00005872 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005873}