Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2015 Google Inc. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license that can be |
| 5 | * found in the LICENSE file. |
| 6 | */ |
| 7 | |
| 8 | #include "GrVkCaps.h" |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 9 | #include "GrBackendSurface.h" |
Robert Phillips | bf25d43 | 2017-04-07 10:08:53 -0400 | [diff] [blame] | 10 | #include "GrRenderTargetProxy.h" |
Brian Salomon | 3d86a19 | 2018-02-27 16:46:11 -0500 | [diff] [blame] | 11 | #include "GrRenderTarget.h" |
Brian Salomon | 94efbf5 | 2016-11-29 13:43:05 -0500 | [diff] [blame] | 12 | #include "GrShaderCaps.h" |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 13 | #include "GrVkUtil.h" |
jvanverth | fd7bd45 | 2016-03-25 06:29:52 -0700 | [diff] [blame] | 14 | #include "vk/GrVkBackendContext.h" |
Brian Salomon | 467921e | 2017-03-06 16:17:12 -0500 | [diff] [blame] | 15 | #include "vk/GrVkInterface.h" |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 16 | |
| 17 | GrVkCaps::GrVkCaps(const GrContextOptions& contextOptions, const GrVkInterface* vkInterface, |
egdaniel | c5ec140 | 2016-03-28 12:14:42 -0700 | [diff] [blame] | 18 | VkPhysicalDevice physDev, uint32_t featureFlags, uint32_t extensionFlags) |
| 19 | : INHERITED(contextOptions) { |
| 20 | fCanUseGLSLForShaderModule = false; |
egdaniel | 6fa0a91 | 2016-09-12 11:51:29 -0700 | [diff] [blame] | 21 | fMustDoCopiesFromOrigin = false; |
Greg Daniel | 691f5e7 | 2018-02-28 14:21:34 -0500 | [diff] [blame^] | 22 | fSupportsCopiesAsDraws = true; |
egdaniel | fd016d7 | 2016-09-27 12:13:05 -0700 | [diff] [blame] | 23 | fMustSubmitCommandsBeforeCopyOp = false; |
Greg Daniel | 80a08dd | 2017-01-20 10:45:49 -0500 | [diff] [blame] | 24 | fMustSleepOnTearDown = false; |
Greg Daniel | e3cd691 | 2017-05-17 11:15:55 -0400 | [diff] [blame] | 25 | fNewCBOnPipelineChange = false; |
Greg Daniel | 8385a8a | 2018-02-26 13:29:37 -0500 | [diff] [blame] | 26 | fCanUseWholeSizeOnFlushMappedMemory = true; |
egdaniel | c5ec140 | 2016-03-28 12:14:42 -0700 | [diff] [blame] | 27 | |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 28 | /************************************************************************** |
| 29 | * GrDrawTargetCaps fields |
| 30 | **************************************************************************/ |
jvanverth | 6234006 | 2016-04-26 08:01:44 -0700 | [diff] [blame] | 31 | fMipMapSupport = true; // always available in Vulkan |
brianosman | f05ab1b | 2016-05-12 11:01:10 -0700 | [diff] [blame] | 32 | fSRGBSupport = true; // always available in Vulkan |
Brian Osman | 57bc3ea | 2017-07-27 09:58:11 -0400 | [diff] [blame] | 33 | fSRGBDecodeDisableSupport = true; // always available in Vulkan |
brianosman | 8879186 | 2016-05-23 10:15:27 -0700 | [diff] [blame] | 34 | fNPOTTextureTileSupport = true; // always available in Vulkan |
egdaniel | 37535c9 | 2016-06-30 08:23:30 -0700 | [diff] [blame] | 35 | fDiscardRenderTargetSupport = true; |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 36 | fReuseScratchTextures = true; //TODO: figure this out |
| 37 | fGpuTracingSupport = false; //TODO: figure this out |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 38 | fOversizedStencilSupport = false; //TODO: figure this out |
Chris Dalton | 1d61635 | 2017-05-31 12:51:23 -0600 | [diff] [blame] | 39 | fInstanceAttribSupport = true; |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 40 | |
Chris Dalton | e4679fa | 2017-09-29 13:58:26 -0600 | [diff] [blame] | 41 | fBlacklistCoverageCounting = true; // blacklisting ccpr until we work through a few issues. |
jvanverth | 84741b3 | 2016-09-30 08:39:02 -0700 | [diff] [blame] | 42 | fFenceSyncSupport = true; // always available in Vulkan |
Greg Daniel | 691f5e7 | 2018-02-28 14:21:34 -0500 | [diff] [blame^] | 43 | fCrossContextTextureSupport = true; |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 44 | |
| 45 | fMapBufferFlags = kNone_MapFlags; //TODO: figure this out |
cdalton | 397536c | 2016-03-25 12:15:03 -0700 | [diff] [blame] | 46 | fBufferMapThreshold = SK_MaxS32; //TODO: figure this out |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 47 | |
| 48 | fMaxRenderTargetSize = 4096; // minimum required by spec |
| 49 | fMaxTextureSize = 4096; // minimum required by spec |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 50 | |
Brian Salomon | 94efbf5 | 2016-11-29 13:43:05 -0500 | [diff] [blame] | 51 | fShaderCaps.reset(new GrShaderCaps(contextOptions)); |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 52 | |
egdaniel | c5ec140 | 2016-03-28 12:14:42 -0700 | [diff] [blame] | 53 | this->init(contextOptions, vkInterface, physDev, featureFlags, extensionFlags); |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 54 | } |
| 55 | |
Robert Phillips | bf25d43 | 2017-04-07 10:08:53 -0400 | [diff] [blame] | 56 | bool GrVkCaps::initDescForDstCopy(const GrRenderTargetProxy* src, GrSurfaceDesc* desc, |
Eric Karl | 7448088 | 2017-04-03 14:49:05 -0700 | [diff] [blame] | 57 | bool* rectsMustMatch, bool* disallowSubrect) const { |
| 58 | // Vk doesn't use rectsMustMatch or disallowSubrect. Always return false. |
| 59 | *rectsMustMatch = false; |
| 60 | *disallowSubrect = false; |
| 61 | |
Brian Salomon | 467921e | 2017-03-06 16:17:12 -0500 | [diff] [blame] | 62 | // We can always succeed here with either a CopyImage (none msaa src) or ResolveImage (msaa). |
| 63 | // For CopyImage we can make a simple texture, for ResolveImage we require the dst to be a |
| 64 | // render target as well. |
| 65 | desc->fOrigin = src->origin(); |
| 66 | desc->fConfig = src->config(); |
Robert Phillips | bf25d43 | 2017-04-07 10:08:53 -0400 | [diff] [blame] | 67 | if (src->numColorSamples() > 1 || (src->asTextureProxy() && this->supportsCopiesAsDraws())) { |
Brian Salomon | 467921e | 2017-03-06 16:17:12 -0500 | [diff] [blame] | 68 | desc->fFlags = kRenderTarget_GrSurfaceFlag; |
| 69 | } else { |
| 70 | // Just going to use CopyImage here |
| 71 | desc->fFlags = kNone_GrSurfaceFlags; |
| 72 | } |
| 73 | |
| 74 | return true; |
| 75 | } |
| 76 | |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 77 | void GrVkCaps::init(const GrContextOptions& contextOptions, const GrVkInterface* vkInterface, |
egdaniel | c5ec140 | 2016-03-28 12:14:42 -0700 | [diff] [blame] | 78 | VkPhysicalDevice physDev, uint32_t featureFlags, uint32_t extensionFlags) { |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 79 | |
Jim Van Verth | 6a40abc | 2017-11-02 16:56:09 +0000 | [diff] [blame] | 80 | VkPhysicalDeviceProperties properties; |
| 81 | GR_VK_CALL(vkInterface, GetPhysicalDeviceProperties(physDev, &properties)); |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 82 | |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 83 | VkPhysicalDeviceMemoryProperties memoryProperties; |
| 84 | GR_VK_CALL(vkInterface, GetPhysicalDeviceMemoryProperties(physDev, &memoryProperties)); |
| 85 | |
jvanverth | fd7bd45 | 2016-03-25 06:29:52 -0700 | [diff] [blame] | 86 | this->initGrCaps(properties, memoryProperties, featureFlags); |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 87 | this->initShaderCaps(properties, featureFlags); |
Greg Daniel | 2bb6ecc | 2017-07-20 13:11:14 +0000 | [diff] [blame] | 88 | this->initConfigTable(vkInterface, physDev, properties); |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 89 | this->initStencilFormat(vkInterface, physDev); |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 90 | |
Greg Daniel | 691f5e7 | 2018-02-28 14:21:34 -0500 | [diff] [blame^] | 91 | if (!contextOptions.fDisableDriverCorrectnessWorkarounds) { |
| 92 | this->applyDriverCorrectnessWorkarounds(properties); |
egdaniel | c5ec140 | 2016-03-28 12:14:42 -0700 | [diff] [blame] | 93 | } |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 94 | |
Greg Daniel | 691f5e7 | 2018-02-28 14:21:34 -0500 | [diff] [blame^] | 95 | this->applyOptionsOverrides(contextOptions); |
| 96 | fShaderCaps->applyOptionsOverrides(contextOptions); |
| 97 | } |
| 98 | |
| 99 | void GrVkCaps::applyDriverCorrectnessWorkarounds(const VkPhysicalDeviceProperties& properties) { |
egdaniel | 6fa0a91 | 2016-09-12 11:51:29 -0700 | [diff] [blame] | 100 | if (kQualcomm_VkVendor == properties.vendorID) { |
| 101 | fMustDoCopiesFromOrigin = true; |
| 102 | } |
| 103 | |
egdaniel | fd016d7 | 2016-09-27 12:13:05 -0700 | [diff] [blame] | 104 | if (kNvidia_VkVendor == properties.vendorID) { |
egdaniel | fd016d7 | 2016-09-27 12:13:05 -0700 | [diff] [blame] | 105 | fMustSubmitCommandsBeforeCopyOp = true; |
| 106 | } |
| 107 | |
Greg Daniel | 691f5e7 | 2018-02-28 14:21:34 -0500 | [diff] [blame^] | 108 | if (kQualcomm_VkVendor == properties.vendorID || |
| 109 | kARM_VkVendor == properties.vendorID) { |
| 110 | fSupportsCopiesAsDraws = false; |
| 111 | // We require copies as draws to support cross context textures. |
| 112 | fCrossContextTextureSupport = false; |
Greg Daniel | a63e7ab | 2017-05-16 14:38:54 -0400 | [diff] [blame] | 113 | } |
| 114 | |
Greg Daniel | 5ba448c | 2018-02-26 13:30:47 -0500 | [diff] [blame] | 115 | if (kARM_VkVendor == properties.vendorID) { |
| 116 | fInstanceAttribSupport = false; |
| 117 | } |
| 118 | |
Greg Daniel | 80a08dd | 2017-01-20 10:45:49 -0500 | [diff] [blame] | 119 | #if defined(SK_BUILD_FOR_WIN) |
| 120 | if (kNvidia_VkVendor == properties.vendorID) { |
| 121 | fMustSleepOnTearDown = true; |
| 122 | } |
| 123 | #elif defined(SK_BUILD_FOR_ANDROID) |
| 124 | if (kImagination_VkVendor == properties.vendorID) { |
| 125 | fMustSleepOnTearDown = true; |
| 126 | } |
| 127 | #endif |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 128 | } |
| 129 | |
| 130 | int get_max_sample_count(VkSampleCountFlags flags) { |
| 131 | SkASSERT(flags & VK_SAMPLE_COUNT_1_BIT); |
| 132 | if (!(flags & VK_SAMPLE_COUNT_2_BIT)) { |
| 133 | return 0; |
| 134 | } |
| 135 | if (!(flags & VK_SAMPLE_COUNT_4_BIT)) { |
| 136 | return 2; |
| 137 | } |
| 138 | if (!(flags & VK_SAMPLE_COUNT_8_BIT)) { |
| 139 | return 4; |
| 140 | } |
| 141 | if (!(flags & VK_SAMPLE_COUNT_16_BIT)) { |
| 142 | return 8; |
| 143 | } |
| 144 | if (!(flags & VK_SAMPLE_COUNT_32_BIT)) { |
| 145 | return 16; |
| 146 | } |
| 147 | if (!(flags & VK_SAMPLE_COUNT_64_BIT)) { |
| 148 | return 32; |
| 149 | } |
| 150 | return 64; |
| 151 | } |
| 152 | |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 153 | void GrVkCaps::initGrCaps(const VkPhysicalDeviceProperties& properties, |
jvanverth | fd7bd45 | 2016-03-25 06:29:52 -0700 | [diff] [blame] | 154 | const VkPhysicalDeviceMemoryProperties& memoryProperties, |
| 155 | uint32_t featureFlags) { |
Greg Daniel | c5cc2de | 2017-03-20 11:40:58 -0400 | [diff] [blame] | 156 | // So GPUs, like AMD, are reporting MAX_INT support vertex attributes. In general, there is no |
| 157 | // need for us ever to support that amount, and it makes tests which tests all the vertex |
| 158 | // attribs timeout looping over that many. For now, we'll cap this at 64 max and can raise it if |
| 159 | // we ever find that need. |
| 160 | static const uint32_t kMaxVertexAttributes = 64; |
| 161 | fMaxVertexAttributes = SkTMin(properties.limits.maxVertexInputAttributes, kMaxVertexAttributes); |
| 162 | // AMD advertises support for MAX_UINT vertex input attributes, but in reality only supports 32. |
| 163 | if (kAMD_VkVendor == properties.vendorID) { |
| 164 | fMaxVertexAttributes = SkTMin(fMaxVertexAttributes, 32); |
| 165 | } |
| 166 | |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 167 | // We could actually query and get a max size for each config, however maxImageDimension2D will |
| 168 | // give the minimum max size across all configs. So for simplicity we will use that for now. |
jvanverth | e78d487 | 2016-09-27 03:33:05 -0700 | [diff] [blame] | 169 | fMaxRenderTargetSize = SkTMin(properties.limits.maxImageDimension2D, (uint32_t)INT_MAX); |
| 170 | fMaxTextureSize = SkTMin(properties.limits.maxImageDimension2D, (uint32_t)INT_MAX); |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 171 | |
Chris Dalton | 2612bae | 2018-02-22 13:41:37 -0700 | [diff] [blame] | 172 | // TODO: check if RT's larger than 4k incur a performance cost on ARM. |
| 173 | fMaxPreferredRenderTargetSize = fMaxRenderTargetSize; |
| 174 | |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 175 | // Assuming since we will always map in the end to upload the data we might as well just map |
| 176 | // from the get go. There is no hard data to suggest this is faster or slower. |
cdalton | 397536c | 2016-03-25 12:15:03 -0700 | [diff] [blame] | 177 | fBufferMapThreshold = 0; |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 178 | |
| 179 | fMapBufferFlags = kCanMap_MapFlag | kSubset_MapFlag; |
| 180 | |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 181 | fOversizedStencilSupport = true; |
ethannicholas | 28ef445 | 2016-03-25 09:26:03 -0700 | [diff] [blame] | 182 | fSampleShadingSupport = SkToBool(featureFlags & kSampleRateShading_GrVkFeatureFlag); |
Greg Daniel | 22bc865 | 2017-03-22 15:45:43 -0400 | [diff] [blame] | 183 | |
| 184 | // AMD seems to have issues binding new VkPipelines inside a secondary command buffer. |
| 185 | // Current workaround is to use a different secondary command buffer for each new VkPipeline. |
| 186 | if (kAMD_VkVendor == properties.vendorID) { |
Greg Daniel | e3cd691 | 2017-05-17 11:15:55 -0400 | [diff] [blame] | 187 | fNewCBOnPipelineChange = true; |
Greg Daniel | 22bc865 | 2017-03-22 15:45:43 -0400 | [diff] [blame] | 188 | } |
Greg Daniel | 0190787 | 2017-05-23 15:21:02 -0400 | [diff] [blame] | 189 | |
Greg Daniel | 8385a8a | 2018-02-26 13:29:37 -0500 | [diff] [blame] | 190 | if (kIntel_VkVendor == properties.vendorID) { |
| 191 | fCanUseWholeSizeOnFlushMappedMemory = false; |
| 192 | } |
| 193 | |
Greg Daniel | 0190787 | 2017-05-23 15:21:02 -0400 | [diff] [blame] | 194 | #if defined(SK_CPU_X86) |
| 195 | if (kImagination_VkVendor == properties.vendorID) { |
| 196 | fSRGBSupport = false; |
| 197 | } |
| 198 | #endif |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 199 | } |
| 200 | |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 201 | void GrVkCaps::initShaderCaps(const VkPhysicalDeviceProperties& properties, uint32_t featureFlags) { |
| 202 | GrShaderCaps* shaderCaps = fShaderCaps.get(); |
| 203 | shaderCaps->fVersionDeclString = "#version 330\n"; |
egdaniel | 3a15fd4 | 2016-04-05 11:00:29 -0700 | [diff] [blame] | 204 | |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 205 | |
| 206 | // fConfigOutputSwizzle will default to RGBA so we only need to set it for alpha only config. |
| 207 | for (int i = 0; i < kGrPixelConfigCnt; ++i) { |
| 208 | GrPixelConfig config = static_cast<GrPixelConfig>(i); |
Greg Daniel | ef59d87 | 2017-11-17 16:47:21 -0500 | [diff] [blame] | 209 | // Vulkan doesn't support a single channel format stored in alpha. |
| 210 | if (GrPixelConfigIsAlphaOnly(config) && |
| 211 | kAlpha_8_as_Alpha_GrPixelConfig != config) { |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 212 | shaderCaps->fConfigTextureSwizzle[i] = GrSwizzle::RRRR(); |
| 213 | shaderCaps->fConfigOutputSwizzle[i] = GrSwizzle::AAAA(); |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 214 | } else { |
Greg Daniel | 7af060a | 2017-12-05 16:27:11 -0500 | [diff] [blame] | 215 | if (kGray_8_GrPixelConfig == config || |
| 216 | kGray_8_as_Red_GrPixelConfig == config) { |
Brian Osman | 986563b | 2017-01-10 14:20:02 -0500 | [diff] [blame] | 217 | shaderCaps->fConfigTextureSwizzle[i] = GrSwizzle::RRRA(); |
| 218 | } else if (kRGBA_4444_GrPixelConfig == config) { |
egdaniel | 3fe0327 | 2016-08-15 10:59:17 -0700 | [diff] [blame] | 219 | // The vulkan spec does not require R4G4B4A4 to be supported for texturing so we |
| 220 | // store the data in a B4G4R4A4 texture and then swizzle it when doing texture reads |
| 221 | // or writing to outputs. Since we're not actually changing the data at all, the |
| 222 | // only extra work is the swizzle in the shader for all operations. |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 223 | shaderCaps->fConfigTextureSwizzle[i] = GrSwizzle::BGRA(); |
| 224 | shaderCaps->fConfigOutputSwizzle[i] = GrSwizzle::BGRA(); |
egdaniel | 3fe0327 | 2016-08-15 10:59:17 -0700 | [diff] [blame] | 225 | } else { |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 226 | shaderCaps->fConfigTextureSwizzle[i] = GrSwizzle::RGBA(); |
egdaniel | 3fe0327 | 2016-08-15 10:59:17 -0700 | [diff] [blame] | 227 | } |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 228 | } |
| 229 | } |
egdaniel | 67acb83 | 2016-02-26 08:32:20 -0800 | [diff] [blame] | 230 | |
Greg Daniel | 80a08dd | 2017-01-20 10:45:49 -0500 | [diff] [blame] | 231 | if (kImagination_VkVendor == properties.vendorID) { |
| 232 | shaderCaps->fAtan2ImplementedAsAtanYOverX = true; |
| 233 | } |
| 234 | |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 235 | // Vulkan is based off ES 3.0 so the following should all be supported |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 236 | shaderCaps->fUsesPrecisionModifiers = true; |
| 237 | shaderCaps->fFlatInterpolationSupport = true; |
Brian Salomon | 4127456 | 2017-09-15 09:40:03 -0700 | [diff] [blame] | 238 | // Flat interpolation appears to be slow on Qualcomm GPUs. This was tested in GL and is assumed |
| 239 | // to be true with Vulkan as well. |
| 240 | shaderCaps->fPreferFlatInterpolation = kQualcomm_VkVendor != properties.vendorID; |
egdaniel | d5e3b9e | 2016-03-08 12:19:54 -0800 | [diff] [blame] | 241 | |
| 242 | // GrShaderCaps |
| 243 | |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 244 | shaderCaps->fShaderDerivativeSupport = true; |
Chris Dalton | f1b47bb | 2017-10-06 11:57:51 -0600 | [diff] [blame] | 245 | |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 246 | shaderCaps->fGeometryShaderSupport = SkToBool(featureFlags & kGeometryShader_GrVkFeatureFlag); |
Chris Dalton | f1b47bb | 2017-10-06 11:57:51 -0600 | [diff] [blame] | 247 | shaderCaps->fGSInvocationsSupport = shaderCaps->fGeometryShaderSupport; |
egdaniel | d632bb4 | 2016-03-30 12:06:48 -0700 | [diff] [blame] | 248 | |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 249 | shaderCaps->fDualSourceBlendingSupport = SkToBool(featureFlags & kDualSrcBlend_GrVkFeatureFlag); |
Greg Daniel | 84cff13 | 2017-03-22 16:25:53 -0400 | [diff] [blame] | 250 | if (kAMD_VkVendor == properties.vendorID) { |
| 251 | // Currently DualSourceBlending is not working on AMD. vkCreateGraphicsPipeline fails when |
| 252 | // using a draw with dual source. Looking into whether it is driver bug or issue with our |
| 253 | // SPIR-V. Bug skia:6405 |
| 254 | shaderCaps->fDualSourceBlendingSupport = false; |
| 255 | } |
egdaniel | d632bb4 | 2016-03-30 12:06:48 -0700 | [diff] [blame] | 256 | |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 257 | shaderCaps->fIntegerSupport = true; |
Chris Dalton | 6b65b98 | 2017-07-06 11:04:00 -0600 | [diff] [blame] | 258 | shaderCaps->fTexelBufferSupport = true; |
| 259 | shaderCaps->fTexelFetchSupport = true; |
Chris Dalton | 1d61635 | 2017-05-31 12:51:23 -0600 | [diff] [blame] | 260 | shaderCaps->fVertexIDSupport = true; |
cdalton | 9c3f143 | 2016-03-11 10:07:37 -0800 | [diff] [blame] | 261 | |
cdalton | a6b92ad | 2016-04-11 12:03:08 -0700 | [diff] [blame] | 262 | // Assume the minimum precisions mandated by the SPIR-V spec. |
Chris Dalton | 47c8ed3 | 2017-11-15 18:27:09 -0700 | [diff] [blame] | 263 | shaderCaps->fFloatIs32Bits = true; |
| 264 | shaderCaps->fHalfIs32Bits = false; |
cdalton | a6b92ad | 2016-04-11 12:03:08 -0700 | [diff] [blame] | 265 | |
Brian Salomon | 1edc5b9 | 2016-11-29 13:43:46 -0500 | [diff] [blame] | 266 | shaderCaps->fMaxVertexSamplers = |
| 267 | shaderCaps->fMaxGeometrySamplers = |
| 268 | shaderCaps->fMaxFragmentSamplers = SkTMin( |
| 269 | SkTMin(properties.limits.maxPerStageDescriptorSampledImages, |
| 270 | properties.limits.maxPerStageDescriptorSamplers), |
| 271 | (uint32_t)INT_MAX); |
| 272 | shaderCaps->fMaxCombinedSamplers = SkTMin( |
| 273 | SkTMin(properties.limits.maxDescriptorSetSampledImages, |
| 274 | properties.limits.maxDescriptorSetSamplers), |
| 275 | (uint32_t)INT_MAX); |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 276 | } |
| 277 | |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 278 | bool stencil_format_supported(const GrVkInterface* interface, |
| 279 | VkPhysicalDevice physDev, |
| 280 | VkFormat format) { |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 281 | VkFormatProperties props; |
| 282 | memset(&props, 0, sizeof(VkFormatProperties)); |
| 283 | GR_VK_CALL(interface, GetPhysicalDeviceFormatProperties(physDev, format, &props)); |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 284 | return SkToBool(VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT & props.optimalTilingFeatures); |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 285 | } |
| 286 | |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 287 | void GrVkCaps::initStencilFormat(const GrVkInterface* interface, VkPhysicalDevice physDev) { |
| 288 | // List of legal stencil formats (though perhaps not supported on |
| 289 | // the particular gpu/driver) from most preferred to least. We are guaranteed to have either |
jvanverth | a4b0fed | 2016-04-27 11:42:21 -0700 | [diff] [blame] | 290 | // VK_FORMAT_D24_UNORM_S8_UINT or VK_FORMAT_D32_SFLOAT_S8_UINT. VK_FORMAT_D32_SFLOAT_S8_UINT |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 291 | // can optionally have 24 unused bits at the end so we assume the total bits is 64. |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 292 | static const StencilFormat |
| 293 | // internal Format stencil bits total bits packed? |
| 294 | gS8 = { VK_FORMAT_S8_UINT, 8, 8, false }, |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 295 | gD24S8 = { VK_FORMAT_D24_UNORM_S8_UINT, 8, 32, true }, |
| 296 | gD32S8 = { VK_FORMAT_D32_SFLOAT_S8_UINT, 8, 64, true }; |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 297 | |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 298 | if (stencil_format_supported(interface, physDev, VK_FORMAT_S8_UINT)) { |
| 299 | fPreferedStencilFormat = gS8; |
| 300 | } else if (stencil_format_supported(interface, physDev, VK_FORMAT_D24_UNORM_S8_UINT)) { |
| 301 | fPreferedStencilFormat = gD24S8; |
| 302 | } else { |
| 303 | SkASSERT(stencil_format_supported(interface, physDev, VK_FORMAT_D32_SFLOAT_S8_UINT)); |
| 304 | fPreferedStencilFormat = gD32S8; |
| 305 | } |
| 306 | } |
| 307 | |
Greg Daniel | 2bb6ecc | 2017-07-20 13:11:14 +0000 | [diff] [blame] | 308 | void GrVkCaps::initConfigTable(const GrVkInterface* interface, VkPhysicalDevice physDev, |
| 309 | const VkPhysicalDeviceProperties& properties) { |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 310 | for (int i = 0; i < kGrPixelConfigCnt; ++i) { |
| 311 | VkFormat format; |
| 312 | if (GrPixelConfigToVkFormat(static_cast<GrPixelConfig>(i), &format)) { |
Greg Daniel | 0190787 | 2017-05-23 15:21:02 -0400 | [diff] [blame] | 313 | if (!GrPixelConfigIsSRGB(static_cast<GrPixelConfig>(i)) || fSRGBSupport) { |
Greg Daniel | 2bb6ecc | 2017-07-20 13:11:14 +0000 | [diff] [blame] | 314 | fConfigTable[i].init(interface, physDev, properties, format); |
Greg Daniel | 0190787 | 2017-05-23 15:21:02 -0400 | [diff] [blame] | 315 | } |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 316 | } |
| 317 | } |
| 318 | } |
| 319 | |
| 320 | void GrVkCaps::ConfigInfo::InitConfigFlags(VkFormatFeatureFlags vkFlags, uint16_t* flags) { |
| 321 | if (SkToBool(VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT & vkFlags) && |
| 322 | SkToBool(VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT & vkFlags)) { |
| 323 | *flags = *flags | kTextureable_Flag; |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 324 | |
Robert Phillips | b7b7e5f | 2017-05-22 13:23:19 -0400 | [diff] [blame] | 325 | // Ganesh assumes that all renderable surfaces are also texturable |
| 326 | if (SkToBool(VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT & vkFlags)) { |
| 327 | *flags = *flags | kRenderable_Flag; |
| 328 | } |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 329 | } |
| 330 | |
| 331 | if (SkToBool(VK_FORMAT_FEATURE_BLIT_SRC_BIT & vkFlags)) { |
| 332 | *flags = *flags | kBlitSrc_Flag; |
| 333 | } |
| 334 | |
| 335 | if (SkToBool(VK_FORMAT_FEATURE_BLIT_DST_BIT & vkFlags)) { |
| 336 | *flags = *flags | kBlitDst_Flag; |
| 337 | } |
| 338 | } |
| 339 | |
Greg Daniel | 81e7bf8 | 2017-07-19 14:47:42 -0400 | [diff] [blame] | 340 | void GrVkCaps::ConfigInfo::initSampleCounts(const GrVkInterface* interface, |
| 341 | VkPhysicalDevice physDev, |
Greg Daniel | 2bb6ecc | 2017-07-20 13:11:14 +0000 | [diff] [blame] | 342 | const VkPhysicalDeviceProperties& physProps, |
Greg Daniel | 81e7bf8 | 2017-07-19 14:47:42 -0400 | [diff] [blame] | 343 | VkFormat format) { |
| 344 | VkImageUsageFlags usage = VK_IMAGE_USAGE_TRANSFER_SRC_BIT | |
| 345 | VK_IMAGE_USAGE_TRANSFER_DST_BIT | |
| 346 | VK_IMAGE_USAGE_SAMPLED_BIT | |
| 347 | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; |
| 348 | VkImageCreateFlags createFlags = GrVkFormatIsSRGB(format, nullptr) |
| 349 | ? VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT : 0; |
| 350 | VkImageFormatProperties properties; |
| 351 | GR_VK_CALL(interface, GetPhysicalDeviceImageFormatProperties(physDev, |
| 352 | format, |
| 353 | VK_IMAGE_TYPE_2D, |
| 354 | VK_IMAGE_TILING_OPTIMAL, |
| 355 | usage, |
| 356 | createFlags, |
| 357 | &properties)); |
| 358 | VkSampleCountFlags flags = properties.sampleCounts; |
| 359 | if (flags & VK_SAMPLE_COUNT_1_BIT) { |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 360 | fColorSampleCounts.push(1); |
Greg Daniel | 81e7bf8 | 2017-07-19 14:47:42 -0400 | [diff] [blame] | 361 | } |
Greg Daniel | 2bb6ecc | 2017-07-20 13:11:14 +0000 | [diff] [blame] | 362 | if (kImagination_VkVendor == physProps.vendorID) { |
| 363 | // MSAA does not work on imagination |
| 364 | return; |
| 365 | } |
Greg Daniel | 81e7bf8 | 2017-07-19 14:47:42 -0400 | [diff] [blame] | 366 | if (flags & VK_SAMPLE_COUNT_2_BIT) { |
| 367 | fColorSampleCounts.push(2); |
| 368 | } |
| 369 | if (flags & VK_SAMPLE_COUNT_4_BIT) { |
| 370 | fColorSampleCounts.push(4); |
| 371 | } |
| 372 | if (flags & VK_SAMPLE_COUNT_8_BIT) { |
| 373 | fColorSampleCounts.push(8); |
| 374 | } |
| 375 | if (flags & VK_SAMPLE_COUNT_16_BIT) { |
| 376 | fColorSampleCounts.push(16); |
| 377 | } |
| 378 | if (flags & VK_SAMPLE_COUNT_32_BIT) { |
| 379 | fColorSampleCounts.push(32); |
| 380 | } |
| 381 | if (flags & VK_SAMPLE_COUNT_64_BIT) { |
| 382 | fColorSampleCounts.push(64); |
| 383 | } |
| 384 | } |
| 385 | |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 386 | void GrVkCaps::ConfigInfo::init(const GrVkInterface* interface, |
| 387 | VkPhysicalDevice physDev, |
Greg Daniel | 2bb6ecc | 2017-07-20 13:11:14 +0000 | [diff] [blame] | 388 | const VkPhysicalDeviceProperties& properties, |
egdaniel | 8f1dcaa | 2016-04-01 10:10:45 -0700 | [diff] [blame] | 389 | VkFormat format) { |
| 390 | VkFormatProperties props; |
| 391 | memset(&props, 0, sizeof(VkFormatProperties)); |
| 392 | GR_VK_CALL(interface, GetPhysicalDeviceFormatProperties(physDev, format, &props)); |
| 393 | InitConfigFlags(props.linearTilingFeatures, &fLinearFlags); |
| 394 | InitConfigFlags(props.optimalTilingFeatures, &fOptimalFlags); |
Greg Daniel | 81e7bf8 | 2017-07-19 14:47:42 -0400 | [diff] [blame] | 395 | if (fOptimalFlags & kRenderable_Flag) { |
Greg Daniel | 2bb6ecc | 2017-07-20 13:11:14 +0000 | [diff] [blame] | 396 | this->initSampleCounts(interface, physDev, properties, format); |
Greg Daniel | 81e7bf8 | 2017-07-19 14:47:42 -0400 | [diff] [blame] | 397 | } |
Greg Daniel | 164a9f0 | 2016-02-22 09:56:40 -0500 | [diff] [blame] | 398 | } |
Greg Daniel | 81e7bf8 | 2017-07-19 14:47:42 -0400 | [diff] [blame] | 399 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 400 | int GrVkCaps::getRenderTargetSampleCount(int requestedCount, GrPixelConfig config) const { |
| 401 | requestedCount = SkTMax(1, requestedCount); |
Greg Daniel | 81e7bf8 | 2017-07-19 14:47:42 -0400 | [diff] [blame] | 402 | int count = fConfigTable[config].fColorSampleCounts.count(); |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 403 | |
| 404 | if (!count) { |
Greg Daniel | 81e7bf8 | 2017-07-19 14:47:42 -0400 | [diff] [blame] | 405 | return 0; |
| 406 | } |
| 407 | |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 408 | if (1 == requestedCount) { |
| 409 | SkASSERT(fConfigTable[config].fColorSampleCounts.count() && |
| 410 | fConfigTable[config].fColorSampleCounts[0] == 1); |
| 411 | return 1; |
| 412 | } |
| 413 | |
Greg Daniel | 81e7bf8 | 2017-07-19 14:47:42 -0400 | [diff] [blame] | 414 | for (int i = 0; i < count; ++i) { |
| 415 | if (fConfigTable[config].fColorSampleCounts[i] >= requestedCount) { |
| 416 | return fConfigTable[config].fColorSampleCounts[i]; |
| 417 | } |
| 418 | } |
Brian Salomon | bdecacf | 2018-02-02 20:32:49 -0500 | [diff] [blame] | 419 | return 0; |
| 420 | } |
| 421 | |
| 422 | int GrVkCaps::maxRenderTargetSampleCount(GrPixelConfig config) const { |
| 423 | const auto& table = fConfigTable[config].fColorSampleCounts; |
| 424 | if (!table.count()) { |
| 425 | return 0; |
| 426 | } |
| 427 | return table[table.count() - 1]; |
Brian Salomon | d653cac | 2018-02-01 13:58:00 -0500 | [diff] [blame] | 428 | } |
| 429 | |
Brian Salomon | 3d86a19 | 2018-02-27 16:46:11 -0500 | [diff] [blame] | 430 | bool GrVkCaps::surfaceSupportsWritePixels(const GrSurface* surface) const { |
| 431 | if (auto rt = surface->asRenderTarget()) { |
| 432 | return rt->numColorSamples() <= 1 && SkToBool(surface->asTexture()); |
| 433 | } |
| 434 | return true; |
| 435 | } |
| 436 | |
Robert Phillips | fc711a2 | 2018-02-13 17:03:00 -0500 | [diff] [blame] | 437 | bool validate_image_info(VkFormat format, SkColorType ct, GrPixelConfig* config) { |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 438 | *config = kUnknown_GrPixelConfig; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 439 | |
| 440 | switch (ct) { |
| 441 | case kUnknown_SkColorType: |
| 442 | return false; |
| 443 | case kAlpha_8_SkColorType: |
| 444 | if (VK_FORMAT_R8_UNORM == format) { |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 445 | *config = kAlpha_8_as_Red_GrPixelConfig; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 446 | } |
| 447 | break; |
| 448 | case kRGB_565_SkColorType: |
| 449 | if (VK_FORMAT_R5G6B5_UNORM_PACK16 == format) { |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 450 | *config = kRGB_565_GrPixelConfig; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 451 | } |
| 452 | break; |
| 453 | case kARGB_4444_SkColorType: |
| 454 | if (VK_FORMAT_B4G4R4A4_UNORM_PACK16 == format) { |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 455 | *config = kRGBA_4444_GrPixelConfig; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 456 | } |
| 457 | break; |
| 458 | case kRGBA_8888_SkColorType: |
| 459 | if (VK_FORMAT_R8G8B8A8_UNORM == format) { |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 460 | *config = kRGBA_8888_GrPixelConfig; |
Greg Daniel | 7b219ac | 2017-12-18 14:49:04 -0500 | [diff] [blame] | 461 | } else if (VK_FORMAT_R8G8B8A8_SRGB == format) { |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 462 | *config = kSRGBA_8888_GrPixelConfig; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 463 | } |
| 464 | break; |
Brian Salomon | e41e176 | 2018-01-25 14:07:47 -0500 | [diff] [blame] | 465 | case kRGB_888x_SkColorType: |
| 466 | return false; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 467 | case kBGRA_8888_SkColorType: |
| 468 | if (VK_FORMAT_B8G8R8A8_UNORM == format) { |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 469 | *config = kBGRA_8888_GrPixelConfig; |
Greg Daniel | 7b219ac | 2017-12-18 14:49:04 -0500 | [diff] [blame] | 470 | } else if (VK_FORMAT_B8G8R8A8_SRGB == format) { |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 471 | *config = kSBGRA_8888_GrPixelConfig; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 472 | } |
| 473 | break; |
Brian Salomon | e41e176 | 2018-01-25 14:07:47 -0500 | [diff] [blame] | 474 | case kRGBA_1010102_SkColorType: |
| 475 | return false; |
| 476 | case kRGB_101010x_SkColorType: |
| 477 | return false; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 478 | case kGray_8_SkColorType: |
| 479 | if (VK_FORMAT_R8_UNORM == format) { |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 480 | *config = kGray_8_as_Red_GrPixelConfig; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 481 | } |
| 482 | break; |
| 483 | case kRGBA_F16_SkColorType: |
| 484 | if (VK_FORMAT_R16G16B16A16_SFLOAT == format) { |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 485 | *config = kRGBA_half_GrPixelConfig; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 486 | } |
| 487 | break; |
| 488 | } |
| 489 | |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 490 | return kUnknown_GrPixelConfig != *config; |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 491 | } |
| 492 | |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 493 | bool GrVkCaps::validateBackendTexture(const GrBackendTexture& tex, SkColorType ct, |
| 494 | GrPixelConfig* config) const { |
Robert Phillips | fc711a2 | 2018-02-13 17:03:00 -0500 | [diff] [blame] | 495 | const GrVkImageInfo* imageInfo = tex.getVkImageInfo(); |
| 496 | if (!imageInfo) { |
| 497 | return false; |
| 498 | } |
| 499 | |
| 500 | return validate_image_info(imageInfo->fFormat, ct, config); |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 501 | } |
| 502 | |
| 503 | bool GrVkCaps::validateBackendRenderTarget(const GrBackendRenderTarget& rt, SkColorType ct, |
| 504 | GrPixelConfig* config) const { |
Robert Phillips | fc711a2 | 2018-02-13 17:03:00 -0500 | [diff] [blame] | 505 | const GrVkImageInfo* imageInfo = rt.getVkImageInfo(); |
| 506 | if (!imageInfo) { |
| 507 | return false; |
| 508 | } |
| 509 | |
| 510 | return validate_image_info(imageInfo->fFormat, ct, config); |
| 511 | } |
| 512 | |
| 513 | bool GrVkCaps::getConfigFromBackendFormat(const GrBackendFormat& format, SkColorType ct, |
| 514 | GrPixelConfig* config) const { |
| 515 | const VkFormat* vkFormat = format.getVkFormat(); |
| 516 | if (!vkFormat) { |
| 517 | return false; |
| 518 | } |
| 519 | return validate_image_info(*vkFormat, ct, config); |
Greg Daniel | faa095e | 2017-12-19 13:15:02 -0500 | [diff] [blame] | 520 | } |
Greg Daniel | f5d8758 | 2017-12-18 14:48:15 -0500 | [diff] [blame] | 521 | |