blob: 78035217d5ede7bf48cb012c352474446c689c33 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900333 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
334 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700335 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700336 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900338}
339
Jiyong Park40782d02020-07-24 19:17:43 +0900340TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
342 const string expected_stderr =
343 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344 CaptureStderr();
345 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900347}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348
Jiyong Park40782d02020-07-24 19:17:43 +0900349TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700350 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900351 const string expected_stderr =
352 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
369 const string expected_stderr =
370 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
371 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800374}
375
Devin Moore2f2077a2020-08-28 11:27:53 -0700376TEST_P(AidlTest, AcceptNullableList) {
377 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
378 const string expected_stderr = "";
379 CaptureStderr();
380 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 const string method = "package a; interface IFoo { void f(int a, int a); }";
386 const string expected_stderr =
387 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
388 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700391}
392
Jeongik Cha13066da2020-08-06 15:43:19 +0900393TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
394 const string method = "package a; parcelable Foo { int a; String a; }";
395 const string expected_stderr =
396 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
397 CaptureStderr();
398 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
400}
401
Jooyung Hand902a972020-10-23 17:32:44 +0900402TEST_P(AidlTest, RejectsRepeatedAnnotations) {
403 const string method = R"(@Hide @Hide parcelable Foo {})";
404 const string expected_stderr =
405 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
406 "Foo.aidl:1.1-6\n";
407 CaptureStderr();
408 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
409 EXPECT_EQ(expected_stderr, GetCapturedStderr());
410}
411
Devin Moore7b8d5c92020-03-17 14:14:08 -0700412TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700413 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
414 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
415 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100418}
419
Devin Moore7b8d5c92020-03-17 14:14:08 -0700420TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700421 AidlError error;
422 const string method = "package a; @nullable interface IFoo { int f(); }";
423 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800424 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900425 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700426 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700427 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700428 EXPECT_EQ(expected_stderr, GetCapturedStderr());
429 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800430}
431
Devin Moore7b8d5c92020-03-17 14:14:08 -0700432TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700433 AidlError error;
434 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
435 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800436 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900437 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700438 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700439 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
441 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800442}
443
Devin Moore7b8d5c92020-03-17 14:14:08 -0700444TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700445 AidlError error;
446 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
447 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000448 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900449 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900450 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700451 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000452 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700453 EXPECT_EQ(expected_stderr, GetCapturedStderr());
454 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800455}
456
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700458 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000459 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700460 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000461 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900462 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700463 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700464 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000465 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
467 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800468}
469
Jiyong Park40782d02020-07-24 19:17:43 +0900470TEST_P(AidlTest, ParsesNonNullableAnnotation) {
471 auto parse_result =
472 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
473 ASSERT_NE(nullptr, parse_result);
474 const AidlInterface* interface = parse_result->AsInterface();
475 ASSERT_NE(nullptr, interface);
476 ASSERT_FALSE(interface->GetMethods().empty());
477 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
478}
479
Devin Moore7b8d5c92020-03-17 14:14:08 -0700480TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900481 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
482 typenames_, GetLanguage());
483 ASSERT_NE(nullptr, parse_result);
484 const AidlInterface* interface = parse_result->AsInterface();
485 ASSERT_NE(nullptr, interface);
486 ASSERT_FALSE(interface->GetMethods().empty());
487 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
488}
489
490TEST_P(AidlTest, ParsesNonUtf8Annotations) {
491 auto parse_result =
492 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
493 ASSERT_NE(nullptr, parse_result);
494 const AidlInterface* interface = parse_result->AsInterface();
495 ASSERT_NE(nullptr, interface);
496 ASSERT_FALSE(interface->GetMethods().empty());
497 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800498}
499
Devin Moore7b8d5c92020-03-17 14:14:08 -0700500TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900501 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
502 typenames_, GetLanguage());
503 ASSERT_NE(nullptr, parse_result);
504 const AidlInterface* interface = parse_result->AsInterface();
505 ASSERT_NE(nullptr, interface);
506 ASSERT_FALSE(interface->GetMethods().empty());
507 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800508}
509
Devin Moore7b8d5c92020-03-17 14:14:08 -0700510TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700511 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700512 const string expected_stderr =
513 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
514 "\"vintf\"'\n"
515 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
516 "--structured\n";
517 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700518 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700519 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522}
523
Devin Moore7b8d5c92020-03-17 14:14:08 -0700524TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700526 const string expected_stderr =
527 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
528 "--structured\n";
529 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700530 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700531 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534}
535
Devin Moore7b8d5c92020-03-17 14:14:08 -0700536TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700537 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700538 const string expected_stderr =
539 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
540 "\"vintf\"'\n";
541 CaptureStderr();
542 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700543 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546}
547
Devin Moore7b8d5c92020-03-17 14:14:08 -0700548TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700549 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700550 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
551 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700552 ASSERT_EQ(AidlError::OK, error);
553 ASSERT_NE(nullptr, parse_result);
554 const AidlInterface* interface = parse_result->AsInterface();
555 ASSERT_NE(nullptr, interface);
556 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700557}
558
Jeongik Cha64783ed2019-06-07 18:30:54 +0900559TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
560 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900561 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
562 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900563 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700564 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900565 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900566 "a/Foo.aidl",
567 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900568
569 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900570 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700571 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900572 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700573 "Parcelable must be defined in AIDL directly.\n";
574 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900575 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700577
578 CaptureStderr();
579 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900581}
582
Jooyung Han1cbc4962020-10-25 10:07:15 +0900583TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
584 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
585 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
586 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900587 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
588
589 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900590 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900591 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
592
593 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900594 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900595 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
596
Jooyung Han1cbc4962020-10-25 10:07:15 +0900597 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900598 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
599}
600
Jooyung Han1cbc4962020-10-25 10:07:15 +0900601TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
602 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
603 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
604 CaptureStderr();
605 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
606 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
607 EXPECT_EQ("", GetCapturedStderr());
608
609 const string expected_to_string_method = R"--(
610 @Override
611 public String toString() {
612 switch (_tag) {
613 case a: return "a.Foo.a(" + (getA()) + ")";
614 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
615 }
616 throw new IllegalStateException("unknown field: " + _tag);
617 }
618)--";
619
620 string java_out;
621 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
622 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
623}
624
Jooyung Han90345002020-10-23 15:28:53 +0900625TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 {
Jooyung Han90345002020-10-23 15:28:53 +0900627 io_delegate_.SetFileContents("a/Foo.aidl",
628 "package a; @JavaDerive(blah=true) parcelable Foo{}");
629 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
630 CaptureStderr();
631 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
632 const std::string expected_stderr =
633 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
634 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
635 }
636
637 {
638 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900639 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
640 CaptureStderr();
641 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
642 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900643 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900644 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
645 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900646 EXPECT_EQ(expected_stderr, GetCapturedStderr());
647 }
648
649 {
Jooyung Han90345002020-10-23 15:28:53 +0900650 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900651 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
652 CaptureStderr();
653 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
654 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900655 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900656 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
657 EXPECT_EQ(expected_stderr, GetCapturedStderr());
658 }
659}
660
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900661TEST_P(AidlTest, ParseDescriptorAnnotation) {
662 AidlError error;
663 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
664 typenames_, GetLanguage(), &error, {"--structured"});
665 ASSERT_EQ(AidlError::OK, error);
666 ASSERT_NE(nullptr, parse_result);
667 const AidlInterface* interface = parse_result->AsInterface();
668 ASSERT_NE(nullptr, interface);
669 ASSERT_EQ("IBar", interface->GetDescriptor());
670}
671
Jiyong Park40782d02020-07-24 19:17:43 +0900672TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700673 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900675}
676
677TEST_P(AidlTest, AcceptsOnewayInterface) {
678 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700679 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700680}
Christopher Wileyef140932015-11-03 09:29:19 -0800681
Devin Moore7b8d5c92020-03-17 14:14:08 -0700682TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700683 const string oneway_method =
684 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700685 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100686}
687
Steven Moreland65297cc2020-04-20 20:17:36 -0700688TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
689 const string oneway_method =
690 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
691 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
692 ASSERT_NE(nullptr, defined);
693 const AidlInterface* iface = defined->AsInterface();
694 ASSERT_NE(nullptr, iface);
695
696 const auto& methods = iface->GetMethods();
697 ASSERT_EQ(1u, methods.size());
698 const auto& method = methods[0];
699 const AidlTypeSpecifier& ret_type = method->GetType();
700
701 // TODO(b/151102494): these annotations should be on the method
702 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
703 ASSERT_TRUE(ret_type.IsHide());
704}
705
Devin Moore7b8d5c92020-03-17 14:14:08 -0700706TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100707 string foo_interface =
708 "package a; /* foo */ interface IFoo {"
709 " /* i */ int i();"
710 " /* j */ @nullable String j();"
711 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
712
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
715 EXPECT_EQ("/* foo */", parse_result->GetComments());
716
717 const AidlInterface* interface = parse_result->AsInterface();
718 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
719 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
720 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
721}
722
Jooyung Han1a551d32020-10-05 15:37:26 +0900723TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
724 io_delegate_.SetFileContents("p/cpp_header.aidl",
725 R"(package p;
726 parcelable cpp_header cpp_header "bar/header";)");
727 import_paths_.emplace("");
728 const string input_path = "p/IFoo.aidl";
729 const string input = R"(package p;
730 import p.cpp_header;
731 interface IFoo {
732 // get bar
733 cpp_header get();
734 })";
735
736 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
737 EXPECT_NE(nullptr, parse_result);
738 const AidlInterface* interface = parse_result->AsInterface();
739 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
740}
741
Christopher Wileyef140932015-11-03 09:29:19 -0800742TEST_F(AidlTest, ParsesPreprocessedFile) {
743 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
744 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700745 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900746 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700747 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
748 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800749}
750
751TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
752 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
753 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900754
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700755 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900756 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700757 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
758 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800759}
760
Devin Moore7b8d5c92020-03-17 14:14:08 -0700761TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800762 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
763 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
764 "interface IBar {}");
765 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900766 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900767 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700768 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800769 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900770
Christopher Wiley41544372015-11-03 14:52:29 -0800771 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700772 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
773 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800774 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700775 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900776 ambiguous_type.Resolve(typenames_);
777 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800778}
779
Jiyong Park8f6ec462020-01-19 20:52:47 +0900780// Special case of PreferImportToPreprocessed. Imported type should be preferred
781// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700782TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900783 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
784 io_delegate_.SetFileContents("one/IBar.aidl",
785 "package one; "
786 "interface IBar {}");
787 preprocessed_files_.push_back("preprocessed");
788 import_paths_.emplace("");
789 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700790 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900791 EXPECT_NE(nullptr, parse_result);
792
793 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700794 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
795 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900796 // But if we request just "IBar" we should get our imported one.
797 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
798 ambiguous_type.Resolve(typenames_);
799 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
800}
801
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800802TEST_F(AidlTest, WritePreprocessedFile) {
803 io_delegate_.SetFileContents("p/Outer.aidl",
804 "package p; parcelable Outer.Inner;");
805 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
806 "interface IBar {}");
807
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900808 vector<string> args {
809 "aidl",
810 "--preprocess",
811 "preprocessed",
812 "p/Outer.aidl",
813 "one/IBar.aidl"};
814 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800815 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
816
817 string output;
818 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
819 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
820}
821
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900822TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100823 io_delegate_.SetFileContents(
824 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800825 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100826 "parcelable Rect {\n"
827 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800828 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100829 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800830 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100831 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100832 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
833 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100834 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900835 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900836 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100837 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900838
839 vector<string> args{"aidl", "Rect.aidl"};
840 Options options = Options::From(args);
841 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
842
843 string output;
844 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900845 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900846}
847
Devin Moore2f2077a2020-08-28 11:27:53 -0700848TEST_F(AidlTest, CppHeaderIncludes) {
849 io_delegate_.SetFileContents("IFoo.aidl",
850 "interface IFoo {\n"
851 " @nullable List<String> foo();\n"
852 "}");
853
854 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
855 Options options = Options::From(args);
856 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
857 std::vector<std::string> empty;
858 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
859 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
860 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
861
862 // Make sure the optional and String16.h includes are added
863 string output;
864 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
865 EXPECT_EQ(kExpectedCppHeaderOutput, output);
866}
867
Devin Moore7b8d5c92020-03-17 14:14:08 -0700868TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700869 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800870 io_delegate_.SetFileContents("p/Outer.aidl",
871 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900872 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700873 CaptureStderr();
874 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
875 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700876 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700877 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800878}
879
Devin Moore7b8d5c92020-03-17 14:14:08 -0700880TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800881 io_delegate_.SetFileContents("preprocessed",
882 "parcelable p.Outer.Inner;");
883 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900884 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700885 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800886 // TODO(wiley): This should actually return nullptr because we require
887 // the outer class name. However, for legacy reasons,
888 // this behavior must be maintained. b/17415692
889 EXPECT_NE(nullptr, parse_result);
890}
891
Christopher Wiley632801d2015-11-05 14:15:49 -0800892TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700893 const string expected_foo_stderr =
894 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
895 "Declared parcelables should be in their own file and/or cannot be used with --structured "
896 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700897 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
898
Christopher Wiley632801d2015-11-05 14:15:49 -0800899 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700900 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700901 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900902 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700903 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900904
Steven Morelande2c64b42018-09-18 15:06:37 -0700905 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900906 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700907 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900908 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700909 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700910
Devin Moore097a3ab2020-03-11 16:08:44 -0700911 const string expected_bar_stderr =
912 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
913 "Declared parcelables should be in their own file and/or cannot be used with --structured "
914 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700915 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
916
Jiyong Parkda8c6932019-08-12 19:56:08 +0900917 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700918 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700919 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900920 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700921 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700922 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700923 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700924 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700925 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800926}
927
Devin Moore7b8d5c92020-03-17 14:14:08 -0700928TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700929 const string expected_stderr =
930 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
931 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700932 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
933 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700934 AidlError error;
935 CaptureStderr();
936 EXPECT_EQ(
937 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700938 Parse("p/IFoo.aidl",
939 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700940 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700941 EXPECT_EQ(expected_stderr, GetCapturedStderr());
942 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700943}
944
Devin Moore7b8d5c92020-03-17 14:14:08 -0700945TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700946 AidlError error;
947 const string expected_stderr =
948 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
949 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900950 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
951 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700952 interface IFoo {
953 const String DUPLICATED = "d";
954 const int DUPLICATED = 1;
955 }
956 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700957 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700958 EXPECT_EQ(expected_stderr, GetCapturedStderr());
959 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700960}
961
Devin Moore7b8d5c92020-03-17 14:14:08 -0700962TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700963 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700964 const string expected_stderr =
965 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700966 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700967 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
968 R"(package p;
969 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700970 parcelable IBar {}
971 parcelable StructuredParcelable {}
972 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900973 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700974 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700975 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700976 // Parse success is important for clear error handling even if the cases aren't
977 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700978 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700979}
980
Devin Moore7b8d5c92020-03-17 14:14:08 -0700981TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700982 AidlError error;
983 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
984 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700985 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700986 EXPECT_EQ(expected_stderr, GetCapturedStderr());
987 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700988}
989
Steven Morelandf9e922f2020-07-08 21:15:27 +0000990TEST_P(AidlTest, FailOnEmptyListWithComma) {
991 AidlError error;
992 const string expected_stderr =
993 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
994 CaptureStderr();
995 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
996 typenames_, GetLanguage(), &error));
997 EXPECT_EQ(expected_stderr, GetCapturedStderr());
998 EXPECT_EQ(AidlError::PARSE_ERROR, error);
999}
1000
Devin Moore7b8d5c92020-03-17 14:14:08 -07001001TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001002 AidlError error;
1003 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001004 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001005 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001006 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1007 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001008 interface IFoo {
1009 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1010 }
1011 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001012 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001013 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1014 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001015}
1016
Jiyong Park18132182020-06-08 20:24:40 +09001017TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1018 AidlError error;
1019 const string expected_stderr =
1020 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1021 "cpp_header (which can also be used as an identifier)\n";
1022 CaptureStderr();
1023 // Notice the trailing dot(.) in the name, which isn't a correct name
1024 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1025 GetLanguage(), &error));
1026 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1027 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1028}
1029
1030TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1031 AidlError error;
1032 const string expected_stderr =
1033 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1034 "cpp_header (which can also be used as an identifier)\n";
1035 CaptureStderr();
1036 // Notice the trailing dot(.) in the package name
1037 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1038 GetLanguage(), &error));
1039 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1040 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1041}
1042
Devin Moore7b8d5c92020-03-17 14:14:08 -07001043TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001044 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001045 auto parse_result = Parse("p/IFoo.aidl",
1046 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001047 interface IFoo {
1048 const int POSITIVE_HEX_VALUE = 0xf5;
1049 }
1050 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001051 typenames_, GetLanguage(), &error);
1052 EXPECT_NE(nullptr, parse_result);
1053 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001054 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001055 const auto& cpp_constants = interface->GetConstantDeclarations();
1056 EXPECT_EQ((size_t)1, cpp_constants.size());
1057 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001058 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001059 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001060}
1061
Devin Moore7b8d5c92020-03-17 14:14:08 -07001062TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001063 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001064 auto parse_result = Parse("p/IFoo.aidl",
1065 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001066 interface IFoo {
1067 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1068 }
1069 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001070 typenames_, GetLanguage(), &error);
1071 ASSERT_NE(nullptr, parse_result);
1072 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001073 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001074 const auto& cpp_constants = interface->GetConstantDeclarations();
1075 EXPECT_EQ((size_t)1, cpp_constants.size());
1076 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001077 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001078 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001079}
1080
Devin Moore7b8d5c92020-03-17 14:14:08 -07001081TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001082 io_delegate_.SetFileContents(
1083 "p/Outer.aidl",
1084 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001085 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001086 const string input_path = "p/IFoo.aidl";
1087 const string input = "package p; import p.Outer; interface IFoo"
1088 " { Outer.Inner get(); }";
1089
Devin Moore7b8d5c92020-03-17 14:14:08 -07001090 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1091 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001092
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001093 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001094 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001095 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1096 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001097}
1098
Devin Moore7b8d5c92020-03-17 14:14:08 -07001099TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001100 io_delegate_.SetFileContents(
1101 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001102 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001103 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001104 const string input_path = "p/IFoo.aidl";
1105 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001106 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1107 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001108 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001109 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1110 native_type.Resolve(typenames_);
1111
1112 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1113 // C++ understands C++ specific stuff
1114 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1115 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001116 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001117 EXPECT_EQ(1u, headers.size());
1118 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001119}
1120
Christopher Wileyf8136192016-04-12 14:19:35 -07001121TEST_F(AidlTest, WritesCorrectDependencyFile) {
1122 // While the in tree build system always gives us an output file name,
1123 // other android tools take advantage of our ability to infer the intended
1124 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001125 vector<string> args = {
1126 "aidl",
1127 "-d dep/file/path",
1128 "-o place/for/output",
1129 "p/IFoo.aidl"};
1130 Options options = Options::From(args);
1131 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001132 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001133 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001134 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001135 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1136}
1137
Dan Willemsen93298ee2016-11-10 23:55:55 -08001138TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1139 // While the in tree build system always gives us an output file name,
1140 // other android tools take advantage of our ability to infer the intended
1141 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001142 vector<string> args = {
1143 "aidl",
1144 "-d dep/file/path",
1145 "--ninja",
1146 "-o place/for/output",
1147 "p/IFoo.aidl"};
1148 Options options = Options::From(args);
1149 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001150 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001151 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001152 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001153 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1154}
1155
Jiyong Parkdf202122019-09-30 20:48:35 +09001156TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001157 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1158 // this by calling aidl with every .aidl file it finds, then parsing the
1159 // generated dependency files. Those that reference .java output files are
1160 // for interfaces and those that do not are parcelables. However, for both
1161 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001162 vector<string> args = {
1163 "aidl",
1164 "-o place/for/output",
1165 "-d dep/file/path",
1166 "p/Foo.aidl"};
1167 Options options = Options::From(args);
1168 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001169 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001170 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001171 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001172 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1173}
1174
1175TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1176 vector<string> args = {
1177 "aidl",
1178 "--structured",
1179 "-o place/for/output",
1180 "-d dep/file/path",
1181 "p/Foo.aidl"};
1182 Options options = Options::From(args);
1183 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1184 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1185 string actual_dep_file_contents;
1186 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1187 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001188}
1189
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001190TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1191 vector<string> args = {
1192 "aidl",
1193 "--lang=java",
1194 "-o place/for/output",
1195 "p/Foo.aidl"};
1196 Options options = Options::From(args);
1197 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1198 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1199 string output_file_contents;
1200 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1201}
1202
Jeongik Cha08ca2182019-11-21 14:01:13 +09001203// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001204TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001205 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001206 "package a; interface IFoo {\n"
1207 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001208 string expected_stderr;
1209 switch (GetLanguage()) {
1210 case Options::Language::CPP:
1211 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001212 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001213 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1214 "String and IBinder.\n";
1215 break;
1216 case Options::Language::JAVA:
1217 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001218 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001219 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1220 "String, IBinder, and ParcelFileDescriptor.\n";
1221 break;
1222 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001223 case Options::Language::RUST:
1224 expected_stderr =
1225 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1226 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001227 default:
1228 AIDL_FATAL(AIDL_LOCATION_HERE)
1229 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1230 }
1231 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001232 AidlTypenames tn1;
1233 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001235
1236 string primitive_parcelable =
1237 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001238 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001239 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001240 AidlTypenames tn2;
1241 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001242 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001243}
1244
Devin Moore21b26772020-08-26 16:37:56 -07001245TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001246 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001247 const string list_array_parcelable =
1248 "package a; parcelable Foo {\n"
1249 " List[] lists; }";
1250 CaptureStderr();
1251 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1252 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1253}
1254
Jiyong Parkf8d53612020-05-04 14:06:13 +09001255TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1256 AidlError error;
1257 string expected_stderr =
1258 "ERROR: a/IFoo.aidl:2.7-11: "
1259 "Encountered an untyped List or Map. The use of untyped List/Map is "
1260 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1261 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1262 if (GetLanguage() != Options::Language::JAVA) {
1263 expected_stderr =
1264 "ERROR: a/IFoo.aidl:2.1-7: "
1265 "Currently, only the Java backend supports non-generic List.\n";
1266 }
1267
1268 const string primitive_interface =
1269 "package a; interface IFoo {\n"
1270 " List foo(); }";
1271 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001272 AidlTypenames tn1;
1273 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001274 {"--structured"}));
1275 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001276
1277 string primitive_parcelable =
1278 "package a; parcelable IFoo {\n"
1279 " List foo;}";
1280 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001281 AidlTypenames tn2;
1282 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001283 {"--structured"}));
1284 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1285}
1286
Jeongik Cha225519b2020-08-29 01:55:32 +09001287TEST_P(AidlTest, ExtensionTest) {
1288 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001289 string extendable_parcelable =
1290 "package a; parcelable Data {\n"
1291 " ParcelableHolder extension;\n"
1292 " ParcelableHolder extension2;\n"
1293 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001294 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001295 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1296 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001297 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001298 "yet.\n",
1299 GetCapturedStderr());
1300 } else {
1301 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1302 EXPECT_EQ("", GetCapturedStderr());
1303 }
1304}
1305TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1306 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001307 string parcelableholder_return_interface =
1308 "package a; interface IFoo {\n"
1309 " ParcelableHolder foo();\n"
1310 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001311 EXPECT_EQ(nullptr,
1312 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001313
Jeongik Cha8f02a532020-10-14 00:16:28 +09001314 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001315 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001316 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001317 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001318 "yet.\n",
1319 GetCapturedStderr());
1320 return;
1321 }
1322 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1323 GetCapturedStderr());
1324}
1325
1326TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1327 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001328 string extendable_parcelable_arg_interface =
1329 "package a; interface IFoo {\n"
1330 " void foo(in ParcelableHolder ph);\n"
1331 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001332 EXPECT_EQ(nullptr,
1333 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1334
Jeongik Cha8f02a532020-10-14 00:16:28 +09001335 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001336 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001337 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001338 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001339 "yet.\n",
1340 GetCapturedStderr());
1341 return;
1342 }
1343 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1344 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001345}
1346
Jiyong Park02da7422018-07-16 16:00:26 +09001347TEST_F(AidlTest, ApiDump) {
1348 io_delegate_.SetFileContents(
1349 "foo/bar/IFoo.aidl",
1350 "package foo.bar;\n"
1351 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001352 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001353 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001354 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001355 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1356 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1357 " IFoo foo3(IFoo foo);\n"
1358 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001359 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001360 " const int A = 1;\n"
1361 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001362 "}\n");
1363 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1364 "package foo.bar;\n"
1365 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001366 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001367 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001368 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001369 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001370 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001371 " int y;\n"
1372 " IFoo foo;\n"
1373 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001374 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001375 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001376 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001377 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001378 "}\n");
1379 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001380 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1381 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001382 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001383 bool result = dump_api(options, io_delegate_);
1384 ASSERT_TRUE(result);
1385 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001386 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001387 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001388/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001389interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001390 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001391 int foo(out int[] a, String b, boolean c, inout List<String> d);
1392 int foo2(@utf8InCpp String x, inout List<String> y);
1393 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1394 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001395 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001396 const int A = 1;
1397 const String STR = "Hello";
1398}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001399)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001400
Jiyong Parke59c3682018-09-11 23:10:25 +09001401 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001402 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001403/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001404parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001405 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001406 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001407 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001408 int y;
1409 foo.bar.IFoo foo;
1410 List<foo.bar.IFoo> a;
1411 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001412 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001413 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001414}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001415)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001416}
1417
Jiyong Parked65bf42018-08-28 15:43:27 +09001418TEST_F(AidlTest, ApiDumpWithManualIds) {
1419 io_delegate_.SetFileContents(
1420 "foo/bar/IFoo.aidl",
1421 "package foo.bar;\n"
1422 "interface IFoo {\n"
1423 " int foo() = 1;\n"
1424 " int bar() = 2;\n"
1425 " int baz() = 10;\n"
1426 "}\n");
1427
Jiyong Parke59c3682018-09-11 23:10:25 +09001428 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001429 Options options = Options::From(args);
1430 bool result = dump_api(options, io_delegate_);
1431 ASSERT_TRUE(result);
1432 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001433 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001434 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001435interface IFoo {
1436 int foo() = 1;
1437 int bar() = 2;
1438 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001439}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001440)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001441}
1442
1443TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001444 const string expected_stderr =
1445 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1446 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001447 io_delegate_.SetFileContents(
1448 "foo/bar/IFoo.aidl",
1449 "package foo.bar;\n"
1450 "interface IFoo {\n"
1451 " int foo() = 1;\n"
1452 " int bar();\n"
1453 " int baz() = 10;\n"
1454 "}\n");
1455
Jiyong Parke59c3682018-09-11 23:10:25 +09001456 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001457 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001458 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001459 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001460 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001461}
1462
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001463TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001464 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001465 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1466 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001467 const string expected_map_stderr =
1468 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001469 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1470 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001471 "package p; interface IFoo {"
1472 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001473 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001474 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001475 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001476
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001477 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001478 "package p; interface IFoo {"
1479 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001480 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001481 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001482 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001483}
1484
Jeongik Chae48d9942020-01-02 17:39:00 +09001485TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001486 const string expected_stderr =
1487 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001488 Options options = Options::From("aidl -I p p/IFoo.aidl");
1489 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1490
1491 io_delegate_.SetFileContents("p/IFoo.aidl",
1492 "package p; interface IFoo {"
1493 "Map<String, Bar> foo();}");
1494 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1495
1496 io_delegate_.SetFileContents("p/IFoo.aidl",
1497 "package p; interface IFoo {"
1498 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001499 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001500 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001501 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001502
1503 io_delegate_.SetFileContents("p/IFoo.aidl",
1504 "package p; interface IFoo {"
1505 "Map<String, String> foo();}");
1506 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1507
1508 io_delegate_.SetFileContents("p/IFoo.aidl",
1509 "package p; interface IFoo {"
1510 "Map<String, ParcelFileDescriptor> foo();}");
1511 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1512}
1513
Jeongik Chadf76dc72019-11-28 00:08:47 +09001514TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001515 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001516 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1517 io_delegate_.SetFileContents(options.InputFiles().front(),
1518 "package p; interface IFoo {"
1519 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001520 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001521 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001522 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001523}
1524
1525TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1526 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1527 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001528 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001529 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001530 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1531 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001532
1533 Options options = Options::From("aidl -I p p/IFoo.aidl");
1534 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1535 io_delegate_.SetFileContents("p/IFoo.aidl",
1536 "package p; interface IFoo {"
1537 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001538 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001539 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001540 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001541 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001542 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001543 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001544 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1545 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001546 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1547 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1548 io_delegate_.SetFileContents("p/IFoo.aidl",
1549 "package p; interface IFoo {"
1550 "Bar<String, ParcelFileDescriptor> foo();}");
1551 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001552
1553 io_delegate_.SetFileContents("p/IFoo.aidl",
1554 "package p; interface IFoo {"
1555 "Bar<int, long> foo();}");
1556
1557 io_delegate_.SetFileContents("p/IFoo.aidl",
1558 "package p; interface IFoo {"
1559 "Bar<int[], long[]> foo();}");
1560
1561 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001562}
1563
Jeongik Cha0e426012019-07-29 15:57:02 +09001564TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1565 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001566 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1567 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001568 for (const auto& rawOption : rawOptions) {
1569 string expected_stderr =
1570 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001571 Options options = Options::From(rawOption);
1572 io_delegate_.SetFileContents(options.InputFiles().front(),
1573 "package foo.bar;\n"
1574 "interface IFoo1 { int foo(); }\n"
1575 "interface IFoo2 { int foo(); }\n"
1576 "parcelable Data1 { int a; int b;}\n"
1577 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001578 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001579 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001581
Jeongik Cha0e426012019-07-29 15:57:02 +09001582 io_delegate_.SetFileContents(options.InputFiles().front(),
1583 "package foo.bar;\n"
1584 "interface IFoo1 { int foo(); }\n"
1585 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001586 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001587 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001588 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001589
Devin Moore5de18ed2020-04-02 13:52:29 -07001590 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001591 io_delegate_.SetFileContents(options.InputFiles().front(),
1592 "package foo.bar;\n"
1593 "parcelable Data1 { int a; int b;}\n"
1594 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001595 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001596 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001597 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001598 }
1599}
1600
Devin Moorebdba2a82020-03-31 15:19:02 -07001601TEST_P(AidlTest, FailParseOnEmptyFile) {
1602 const string contents = "";
1603 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1604 CaptureStderr();
1605 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1606 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1607}
1608
Jiyong Parkb034bf02018-07-30 17:44:33 +09001609TEST_F(AidlTest, MultipleInputFiles) {
1610 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001611 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001612
1613 io_delegate_.SetFileContents(options.InputFiles().at(0),
1614 "package foo.bar;\n"
1615 "import foo.bar.Data;\n"
1616 "interface IFoo { Data getData(); }\n");
1617
1618 io_delegate_.SetFileContents(options.InputFiles().at(1),
1619 "package foo.bar;\n"
1620 "import foo.bar.IFoo;\n"
1621 "parcelable Data { IFoo foo; }\n");
1622
1623 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1624
1625 string content;
1626 for (const auto file : {
1627 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1628 content.clear();
1629 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1630 EXPECT_FALSE(content.empty());
1631 }
1632}
1633
1634TEST_F(AidlTest, MultipleInputFilesCpp) {
1635 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001636 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001637
1638 io_delegate_.SetFileContents(options.InputFiles().at(0),
1639 "package foo.bar;\n"
1640 "import foo.bar.Data;\n"
1641 "interface IFoo { Data getData(); }\n");
1642
1643 io_delegate_.SetFileContents(options.InputFiles().at(1),
1644 "package foo.bar;\n"
1645 "import foo.bar.IFoo;\n"
1646 "parcelable Data { IFoo foo; }\n");
1647
1648 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1649
1650 string content;
1651 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001652 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001653 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1654 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1655 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1656 content.clear();
1657 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1658 EXPECT_FALSE(content.empty());
1659 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001660}
1661
Andrei Homescub62afd92020-05-11 19:24:59 -07001662TEST_F(AidlTest, MultipleInputFilesRust) {
1663 Options options =
1664 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1665
1666 io_delegate_.SetFileContents(options.InputFiles().at(0),
1667 "package foo.bar;\n"
1668 "import foo.bar.Data;\n"
1669 "interface IFoo { Data getData(); }\n");
1670
1671 io_delegate_.SetFileContents(options.InputFiles().at(1),
1672 "package foo.bar;\n"
1673 "import foo.bar.IFoo;\n"
1674 "parcelable Data { IFoo foo; }\n");
1675
1676 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1677
1678 string content;
1679 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1680 content.clear();
1681 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1682 EXPECT_FALSE(content.empty());
1683 }
1684}
1685
Devin Moore097a3ab2020-03-11 16:08:44 -07001686TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1687 const string expected_stderr =
1688 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001689 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1690 // int getInterfaceVersion() is one of the meta transactions
1691 io_delegate_.SetFileContents(options.InputFiles().front(),
1692 "package p; interface IFoo {"
1693 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001694 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001695 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001696 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1697}
Jiyong Park309668e2018-07-28 16:55:44 +09001698
Devin Moore097a3ab2020-03-11 16:08:44 -07001699TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1700 // boolean getInterfaceVersion() is not a meta transaction, but should be
1701 // prevented because return type is not part of a method signature
1702 const string expected_stderr =
1703 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1704 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001705 io_delegate_.SetFileContents(options.InputFiles().front(),
1706 "package p; interface IFoo {"
1707 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001708 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001709 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001710 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1711}
Jiyong Park309668e2018-07-28 16:55:44 +09001712
Devin Moore097a3ab2020-03-11 16:08:44 -07001713TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001714 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001715 const string expected_stderr =
1716 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1717 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001718 io_delegate_.SetFileContents(options.InputFiles().front(),
1719 "package p; interface IFoo {"
1720 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001721 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001722 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001723 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001724
1725 // this is not a meta interface method as it differs type arguments
1726 io_delegate_.SetFileContents(options.InputFiles().front(),
1727 "package p; interface IFoo {"
1728 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001729 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001730}
1731
Daniel Norman85aed542019-08-21 12:01:14 -07001732TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001733 Options options = Options::From("aidl --checkapi old new");
1734 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1735 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1736 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1737 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1738
1739 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1740}
1741
Jiyong Park3656c3c2018-08-01 20:02:01 +09001742TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001743 Options options = Options::From("aidl --checkapi old new");
1744 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1745 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001746
1747 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1748}
1749
Daniel Norman85aed542019-08-21 12:01:14 -07001750class AidlTestCompatibleChanges : public AidlTest {
1751 protected:
1752 Options options_ = Options::From("aidl --checkapi old new");
1753};
1754
1755TEST_F(AidlTestCompatibleChanges, NewType) {
1756 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1757 "package p;"
1758 "interface IFoo {"
1759 " void foo(int a);"
1760 "}");
1761 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1762 "package p;"
1763 "interface IFoo {"
1764 " void foo(int a);"
1765 "}");
1766 io_delegate_.SetFileContents("new/p/IBar.aidl",
1767 "package p;"
1768 "interface IBar {"
1769 " void bar();"
1770 "}");
1771 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1772}
1773
1774TEST_F(AidlTestCompatibleChanges, NewMethod) {
1775 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1776 "package p;"
1777 "interface IFoo {"
1778 " void foo(int a);"
1779 "}");
1780 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1781 "package p;"
1782 "interface IFoo {"
1783 " void foo(int a);"
1784 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001785 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001786 "}");
1787 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1788}
1789
1790TEST_F(AidlTestCompatibleChanges, NewField) {
1791 io_delegate_.SetFileContents("old/p/Data.aidl",
1792 "package p;"
1793 "parcelable Data {"
1794 " int foo;"
1795 "}");
1796 io_delegate_.SetFileContents("new/p/Data.aidl",
1797 "package p;"
1798 "parcelable Data {"
1799 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001800 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001801 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001802 "}");
1803 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1804}
1805
1806TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1807 io_delegate_.SetFileContents("old/p/Enum.aidl",
1808 "package p;"
1809 "enum Enum {"
1810 " FOO = 1,"
1811 "}");
1812 io_delegate_.SetFileContents("new/p/Enum.aidl",
1813 "package p;"
1814 "enum Enum {"
1815 " FOO = 1,"
1816 " BAR = 2,"
1817 "}");
1818 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1819}
1820
1821TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1822 io_delegate_.SetFileContents("old/p/Enum.aidl",
1823 "package p;"
1824 "enum Enum {"
1825 " FOO = 1,"
1826 " BAR = 2,"
1827 "}");
1828 io_delegate_.SetFileContents("new/p/Enum.aidl",
1829 "package p;"
1830 "enum Enum {"
1831 " BAR = 2,"
1832 " FOO = 1,"
1833 "}");
1834 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1835}
1836
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001837TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1838 io_delegate_.SetFileContents("old/p/Union.aidl",
1839 "package p;"
1840 "union Union {"
1841 " String foo;"
1842 "}");
1843 io_delegate_.SetFileContents("new/p/Union.aidl",
1844 "package p;"
1845 "union Union {"
1846 " String foo;"
1847 " int num;"
1848 "}");
1849 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1850}
1851
Daniel Norman85aed542019-08-21 12:01:14 -07001852TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001853 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1854 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001855 "interface IFoo {"
1856 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001857 "}");
1858 io_delegate_.SetFileContents("old/p/Data.aidl",
1859 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001860 "parcelable Data {"
1861 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001862 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001863 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1864 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001865 "interface IFoo {"
1866 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001867 "}");
1868 io_delegate_.SetFileContents("new/p/Data.aidl",
1869 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001870 "parcelable Data {"
1871 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001872 "}");
1873 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1874 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001875 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001876 " void foo(int a);"
1877 "}");
1878 io_delegate_.SetFileContents("new/q/Data.aidl",
1879 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001880 "parcelable Data {"
1881 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001882 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001883 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1884}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001885
Daniel Norman85aed542019-08-21 12:01:14 -07001886TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1887 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1888 "package p;"
1889 "interface IFoo {"
1890 " void foo(int a);"
1891 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001892 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1893 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001894 "interface IFoo {"
1895 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001896 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001897 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1898}
Jiyong Parke59c3682018-09-11 23:10:25 +09001899
Daniel Norman85aed542019-08-21 12:01:14 -07001900TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001901 io_delegate_.SetFileContents("old/p/I.aidl",
1902 "package p; interface I {"
1903 "const int A = 1; }");
1904 io_delegate_.SetFileContents("new/p/I.aidl",
1905 "package p ; interface I {"
1906 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001907 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1908}
Jiyong Parka428d212018-08-29 22:26:30 +09001909
Daniel Norman85aed542019-08-21 12:01:14 -07001910TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001911 io_delegate_.SetFileContents("old/p/I.aidl",
1912 "package p; interface I {"
1913 "const int A = 1; const int B = 2;}");
1914 io_delegate_.SetFileContents("new/p/I.aidl",
1915 "package p ; interface I {"
1916 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001917 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001918}
1919
Jooyung Han636fd2f2020-10-22 11:33:45 +09001920TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
1921 io_delegate_.SetFileContents("old/p/Data.aidl",
1922 "package p;"
1923 "parcelable Data {"
1924 " int num;"
1925 "}");
1926 io_delegate_.SetFileContents(
1927 "new/p/Data.aidl",
1928 "package p;"
1929 "parcelable Data {"
1930 " int num;"
1931 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
1932 "}");
1933 io_delegate_.SetFileContents("new/p/Enum.aidl",
1934 "package p;"
1935 "enum Enum {"
1936 " FOO = 0,"
1937 " BAR = 1,"
1938 "}");
1939 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1940}
1941
Daniel Norman85aed542019-08-21 12:01:14 -07001942class AidlTestIncompatibleChanges : public AidlTest {
1943 protected:
1944 Options options_ = Options::From("aidl --checkapi old new");
1945};
1946
1947TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001948 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001949 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1950 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001951 "interface IFoo {"
1952 " void foo(in String[] str);"
1953 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001954 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001955 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001956 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001957 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001958}
1959
1960TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001961 const string expected_stderr =
1962 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001963 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1964 "package p;"
1965 "interface IFoo {"
1966 " void foo(in String[] str);"
1967 " void bar(@utf8InCpp String str);"
1968 "}");
1969 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1970 "package p;"
1971 "interface IFoo {"
1972 " void foo(in String[] str);"
1973 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001974 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001975 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001976 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001977}
1978
Jiyong Parkf8d53612020-05-04 14:06:13 +09001979TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1980 const string expected_stderr =
1981 "ERROR: new/p/IFoo.aidl:1.61-65: "
1982 "Encountered an untyped List or Map. The use of untyped List/Map is "
1983 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1984 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1985 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1986 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1987 "package p;"
1988 "interface IFoo {"
1989 " void foo(in String[] str);"
1990 "}");
1991 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1992 "package p;"
1993 "interface IFoo {"
1994 " void foo(in String[] str);"
1995 " void bar(in List arg);"
1996 "}");
1997 CaptureStderr();
1998 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1999 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2000}
2001
2002TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2003 const string expected_stderr =
2004 "ERROR: new/p/Data.aidl:1.54-59: "
2005 "Encountered an untyped List or Map. The use of untyped List/Map is "
2006 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2007 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2008 "ERROR: new/p/Data.aidl: Failed to read.\n";
2009 io_delegate_.SetFileContents("old/p/Data.aidl",
2010 "package p;"
2011 "parcelable Data {"
2012 " int foo;"
2013 "}");
2014 io_delegate_.SetFileContents("new/p/Data.aidl",
2015 "package p;"
2016 "parcelable Data {"
2017 " int foo;"
2018 " @nullable List list;"
2019 "}");
2020 CaptureStderr();
2021 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2022 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2023}
2024
Daniel Norman85aed542019-08-21 12:01:14 -07002025TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002026 const string expected_stderr =
2027 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002028 io_delegate_.SetFileContents("old/p/Data.aidl",
2029 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002030 "parcelable Data {"
2031 " int foo;"
2032 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002033 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002034 io_delegate_.SetFileContents("new/p/Data.aidl",
2035 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002036 "parcelable Data {"
2037 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002038 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002039 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002040 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002041 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002042}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002043
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002044TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2045 const string expected_stderr =
2046 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2047 "backends. Please either provide a default value for this field or mark the field as "
2048 "@nullable. This value or a null value will be used automatically when an old version of "
2049 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2050 "order to make sure your code continues to be backwards compatible, make sure the default or "
2051 "null value does not cause a semantic change to this parcelable.\n";
2052 io_delegate_.SetFileContents("old/p/Data.aidl",
2053 "package p;"
2054 "parcelable Data {"
2055 " int num;"
2056 "}");
2057 io_delegate_.SetFileContents("new/p/Data.aidl",
2058 "package p;"
2059 "parcelable Data {"
2060 " int num;"
2061 " String str;"
2062 "}");
2063 CaptureStderr();
2064 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2065 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2066}
2067
Jooyung Han636fd2f2020-10-22 11:33:45 +09002068TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2069 const string expected_stderr =
2070 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2071 "Please make sure 'Enum' has '0' as a valid value.\n";
2072 io_delegate_.SetFileContents("old/p/Data.aidl",
2073 "package p;"
2074 "parcelable Data {"
2075 " int num;"
2076 "}");
2077 io_delegate_.SetFileContents("new/p/Data.aidl",
2078 "package p;"
2079 "parcelable Data {"
2080 " int num;"
2081 " p.Enum e;"
2082 "}");
2083 io_delegate_.SetFileContents("new/p/Enum.aidl",
2084 "package p;"
2085 "enum Enum {"
2086 " FOO = 1,"
2087 " BAR = 2,"
2088 "}");
2089 CaptureStderr();
2090 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2091 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2092}
2093
Daniel Norman85aed542019-08-21 12:01:14 -07002094TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002095 const string expected_stderr =
2096 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002097 io_delegate_.SetFileContents("old/p/Enum.aidl",
2098 "package p;"
2099 "enum Enum {"
2100 " FOO = 1,"
2101 " BAR = 2,"
2102 "}");
2103 io_delegate_.SetFileContents("new/p/Enum.aidl",
2104 "package p;"
2105 "enum Enum {"
2106 " BAR = 2,"
2107 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002108 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002109 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002110 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002111}
2112
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002113TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2114 const string expected_stderr =
2115 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2116 io_delegate_.SetFileContents("old/p/Union.aidl",
2117 "package p;"
2118 "union Union {"
2119 " String str;"
2120 " int num;"
2121 "}");
2122 io_delegate_.SetFileContents("new/p/Union.aidl",
2123 "package p;"
2124 "union Union {"
2125 " String str;"
2126 "}");
2127 CaptureStderr();
2128 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2129 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2130}
2131
Daniel Norman85aed542019-08-21 12:01:14 -07002132TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002133 const string expected_stderr =
2134 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002135 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2136 "package p;"
2137 "interface IFoo {"
2138 " void foo(in String[] str);"
2139 " void bar(@utf8InCpp String str);"
2140 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002141 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2142 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002143 "interface IFoo {"
2144 " void foo(in String[] str);"
2145 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002146 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002147 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002148 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002149 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002150}
2151
Daniel Norman85aed542019-08-21 12:01:14 -07002152TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002153 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002154 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2155 "package p;"
2156 "interface IFoo {"
2157 " void foo(in String[] str);"
2158 " void bar(@utf8InCpp String str);"
2159 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002160 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2161 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002162 "interface IFoo2 {"
2163 " void foo(in String[] str);"
2164 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002165 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002166 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002167 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002168 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002169}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002170
Daniel Norman85aed542019-08-21 12:01:14 -07002171TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002172 const string expected_stderr =
2173 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002174 io_delegate_.SetFileContents("old/p/Enum.aidl",
2175 "package p;"
2176 "enum Enum {"
2177 " FOO = 1,"
2178 " BAR = 2,"
2179 "}");
2180 io_delegate_.SetFileContents("new/p/Enum.aidl",
2181 "package p;"
2182 "enum Enum {"
2183 " FOO = 3,"
2184 " BAR = 2,"
2185 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002186 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002187 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002188 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002189}
2190
2191TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002192 const string expected_stderr =
2193 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2194 "from 0 to 1.\n"
2195 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2196 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002197 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2198 "package p;"
2199 "interface IFoo {"
2200 " void foo(in String[] str);"
2201 " void bar(@utf8InCpp String str);"
2202 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002203 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2204 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002205 "interface IFoo {"
2206 " void bar(@utf8InCpp String str);"
2207 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002208 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002209 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002210 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002211 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002212}
2213
2214TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002215 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002216 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2217 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002218 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002219 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002220 "parcelable Data {"
2221 " int foo;"
2222 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002223 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002224 io_delegate_.SetFileContents("new/p/Data.aidl",
2225 "package p;"
2226 "parcelable Data {"
2227 " int bar;"
2228 " int foo;"
2229 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002230 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002231 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002232 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002233}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002234
Daniel Norman85aed542019-08-21 12:01:14 -07002235TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002236 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002237 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002238 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002239 "interface IFoo {"
2240 " void foo(in String[] str);"
2241 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002242 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002243 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2244 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002245 "interface IFoo {"
2246 " void foo(out String[] str);"
2247 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002248 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002249 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002250 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002251 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002252}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002253
Daniel Norman85aed542019-08-21 12:01:14 -07002254TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002255 const string expected_stderr =
2256 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002257 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2258 "package p;"
2259 "interface IFoo {"
2260 " void foo(in String[] str);"
2261 " void bar(@utf8InCpp String str);"
2262 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002263 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2264 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002265 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002266 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002267 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002268 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002269 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002270 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002271 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002272}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002273
Daniel Norman85aed542019-08-21 12:01:14 -07002274TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002275 const string expected_stderr =
2276 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002277 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2278 "package p;"
2279 "interface IFoo {"
2280 " void foo(in String[] str);"
2281 " void bar(@utf8InCpp String str);"
2282 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002283 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2284 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002285 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002286 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002287 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002288 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002289 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002290 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002292}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002293
Devin Mooredb7ac512020-08-07 11:17:36 -07002294TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2295 const string expected_stderr =
2296 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2297 io_delegate_.SetFileContents("old/p/Foo.aidl",
2298 "package p;"
2299 "parcelable Foo {"
2300 " int A;"
2301 "}");
2302 io_delegate_.SetFileContents("new/p/Foo.aidl",
2303 "package p;"
2304 "@JavaOnlyStableParcelable parcelable Foo {"
2305 " int A;"
2306 "}");
2307 CaptureStderr();
2308 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2309 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2310}
2311
2312TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2313 const string expected_stderr =
2314 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2315 io_delegate_.SetFileContents("old/p/Foo.aidl",
2316 "package p;"
2317 "@JavaOnlyStableParcelable parcelable Foo {"
2318 " int A;"
2319 "}");
2320 io_delegate_.SetFileContents("new/p/Foo.aidl",
2321 "package p;"
2322 "parcelable Foo {"
2323 " int A;"
2324 "}");
2325 CaptureStderr();
2326 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2327 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2328}
2329
Daniel Norman85aed542019-08-21 12:01:14 -07002330TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002331 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002332 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2333 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002334 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002335 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002336 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002337 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002338}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002339
Daniel Norman85aed542019-08-21 12:01:14 -07002340TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002341 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002342 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2343 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002344 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002345 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002347}
Jiyong Parka428d212018-08-29 22:26:30 +09002348
Daniel Norman85aed542019-08-21 12:01:14 -07002349TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002350 const string expected_stderr =
2351 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002352 io_delegate_.SetFileContents("old/p/I.aidl",
2353 "package p; interface I {"
2354 "const int A = 1; const int B = 2;}");
2355 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002356 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002357 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002358 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002359}
Jiyong Parka428d212018-08-29 22:26:30 +09002360
Daniel Norman85aed542019-08-21 12:01:14 -07002361TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002362 const string expected_stderr =
2363 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002364 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2365 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002366 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002367 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002368 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002369}
2370
Devin Moorec7e47a32020-08-07 10:55:25 -07002371TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2372 const string expected_stderr =
2373 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2374 "This is an incompatible change for FixedSize types.\n";
2375 io_delegate_.SetFileContents("old/p/Foo.aidl",
2376 "package p; @FixedSize parcelable Foo { int A = 1; }");
2377 io_delegate_.SetFileContents("new/p/Foo.aidl",
2378 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2379 CaptureStderr();
2380 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2382}
2383
2384TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2385 const string expected_stderr =
2386 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2387 io_delegate_.SetFileContents("old/p/Foo.aidl",
2388 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2389 io_delegate_.SetFileContents("new/p/Foo.aidl",
2390 "package p; @FixedSize parcelable Foo { int A = 1; }");
2391 CaptureStderr();
2392 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2393 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2394}
2395
2396TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2397 const string expected_stderr =
2398 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2399 "a.\n"
2400 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2401 "b.\n"
2402 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2403 "c.\n"
2404 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2405 "d.\n"
2406 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2407 "e.\n"
2408 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2409 "f.\n";
2410
2411 io_delegate_.SetFileContents("Foo.aidl",
2412 "@FixedSize parcelable Foo { "
2413 " int[] a;"
2414 " Bar b;"
2415 " String c;"
2416 " ParcelFileDescriptor d;"
2417 " IBinder e;"
2418 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002419 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002420 "}");
2421 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2422 Options options =
2423 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2424
2425 CaptureStderr();
2426 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2427 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2428}
2429
2430TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2431 const string expected_stderr = "";
2432
2433 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2434 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2435 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2436 Options options =
2437 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2438
2439 CaptureStderr();
2440 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2442}
2443
Jiyong Park8c380532018-08-30 14:55:26 +09002444TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002445 const string expected_stderr =
2446 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2447 "dir1/q/IBar.aidl\n"
2448 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002449 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002450 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2451 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2452 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2453 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2454
Devin Moore097a3ab2020-03-11 16:08:44 -07002455 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002456 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002457 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002458}
2459
Jiyong Parked65bf42018-08-28 15:43:27 +09002460TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002461 const string expected_stderr =
2462 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2463 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002464 Options options = Options::From("aidl --checkapi old new");
2465 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2466 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002467
2468 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2469
Jiyong Parke59c3682018-09-11 23:10:25 +09002470 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002471 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002472 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002473 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002474}
2475
Jiyong Parke05195e2018-10-08 18:24:23 +09002476TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2477 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2478 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002479 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002480
2481 // use without import
2482 io_delegate_.SetFileContents("p/IFoo.aidl",
2483 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2484 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2485 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002486 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002487
Devin Moore7b8d5c92020-03-17 14:14:08 -07002488 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002489 io_delegate_.SetFileContents(
2490 "p/IFoo.aidl",
2491 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2492 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2493 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002494 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002495
2496 // use with import (as before)
2497 io_delegate_.SetFileContents("p/IFoo.aidl",
2498 "package p;"
2499 "import android.os.ParcelFileDescriptor;"
2500 "interface IFoo{"
2501 " void foo(in ParcelFileDescriptor fd);"
2502 "}");
2503 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2504 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002505 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002506}
Jiyong Parked65bf42018-08-28 15:43:27 +09002507
Jiyong Park3633b722019-04-11 15:38:26 +09002508TEST_F(AidlTest, ManualIds) {
2509 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2510 io_delegate_.SetFileContents("IFoo.aidl",
2511 "interface IFoo {\n"
2512 " void foo() = 0;\n"
2513 " void bar() = 1;\n"
2514 "}");
2515 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2516}
2517
2518TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2519 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2520 io_delegate_.SetFileContents("IFoo.aidl",
2521 "interface IFoo {\n"
2522 " void foo() = 0;\n"
2523 " void bar() = 1;\n"
2524 "}");
2525 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2526}
2527
2528TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002529 const string expected_stderr =
2530 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002531 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2532 io_delegate_.SetFileContents("IFoo.aidl",
2533 "interface IFoo {\n"
2534 " void foo() = 3;\n"
2535 " void bar() = 3;\n"
2536 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002537 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002538 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002539 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002540}
2541
2542TEST_F(AidlTest, FailOnOutOfRangeIds) {
2543 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002544 const string expected_stderr =
2545 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2546 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002547 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2548 io_delegate_.SetFileContents("IFoo.aidl",
2549 "interface IFoo {\n"
2550 " void foo() = 3;\n"
2551 " void bar() = 16777115;\n"
2552 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002553 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002554 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002555 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002556}
2557
2558TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002559 const string expected_stderr =
2560 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002561 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2562 io_delegate_.SetFileContents("IFoo.aidl",
2563 "interface IFoo {\n"
2564 " void foo() = 3;\n"
2565 " void bar();\n"
2566 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002567 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002568 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002569 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002570}
2571
Jiyong Parkc6816252019-07-08 08:12:28 +09002572TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2573 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2574 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2575 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2576 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2577}
2578
2579TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002580 const string expected_stderr =
2581 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2582 "dir/IBar.aidl\n"
2583 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002584 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002585
Jiyong Parkc6816252019-07-08 08:12:28 +09002586 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2587 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2588 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2589 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002590 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002591 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002592 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002593}
2594
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002595TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2596 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2597 "package a.b;\n"
2598 "import a.b.IBar;\n"
2599 "import a.b.IQux;\n"
2600 "interface IFoo { IQux foo(); }\n");
2601 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2602 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2603
2604 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2605 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2606
2607 string output;
2608 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2609 // IBar was imported but wasn't used. include is not expected.
2610 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2611 // IBar was imported and used. include is expected.
2612 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2613}
2614
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002615TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002616 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002617 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002618 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2619 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002620 interface IFoo {
2621 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002622 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002623 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002624 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002625 // JavaPassthrough should work with other types as well (e.g. enum)
2626 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2627 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2628 @JavaPassthrough(annotation="@com.android.AliceTwo")
2629 @Backing(type="byte")
2630 enum MyEnum {
2631 a, b, c
2632 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002633
Jooyung Han4cde01d2020-10-13 11:10:47 +09002634 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002635 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2636
2637 string java_out;
2638 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002639 // type-decl-level annotations with newline at the end
2640 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2641 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2642 // member-decl-level annotations with newline at the end
2643 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2644 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2645 // inline annotations with space at the end
2646 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002647
Jooyung Han4cde01d2020-10-13 11:10:47 +09002648 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2649 // type-decl-level annotations with newline at the end
2650 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2651 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2652
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002653 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002654 Options cpp_options =
2655 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002656 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2657
Jooyung Han4cde01d2020-10-13 11:10:47 +09002658 Options ndk_options =
2659 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002660 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002661
Jooyung Han4cde01d2020-10-13 11:10:47 +09002662 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002663 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002664}
2665
Andrei Homescue61feb52020-08-18 15:44:24 -07002666TEST_F(AidlTest, ParseRustDerive) {
2667 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2668 @RustDerive(Clone=true, Copy=false)
2669 parcelable Foo {
2670 int a;
2671 })");
2672
2673 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2674 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2675
2676 string rust_out;
2677 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2678 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2679
2680 // Other backends shouldn't be bothered
2681 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2682 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2683
2684 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2685 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2686
2687 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2688 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2689}
2690
Jiyong Park56f73d72019-06-11 12:20:28 +09002691class AidlOutputPathTest : public AidlTest {
2692 protected:
2693 void SetUp() override {
2694 AidlTest::SetUp();
2695 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2696 }
2697
2698 void Test(const Options& options, const std::string expected_output_path) {
2699 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2700 // check the existence
2701 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2702 }
2703};
2704
2705TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2706 // <out_dir> / <package_name> / <type_name>.java
2707 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2708}
2709
2710TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2711 // when output file is explicitly set, it is always respected. -o option is
2712 // ignored.
2713 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2714}
2715
2716TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2717 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2718}
2719
2720TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2721 // output is the same as the input file except for the suffix
2722 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2723}
2724
Devin Moore7b8d5c92020-03-17 14:14:08 -07002725TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002726 AidlError error;
2727 const string expected_stderr =
2728 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2729 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002730 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2731 R"(package p;
2732 interface IFoo {
2733 const int int32_max_oob = 2147483650;
2734 }
2735 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002736 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002737 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2738 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002739}
2740
Devin Moore7b8d5c92020-03-17 14:14:08 -07002741TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002742 AidlError error;
2743 const string expected_stderr =
2744 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2745 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002746 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2747 R"(package p;
2748 interface IFoo {
2749 const int int32_min_oob = -2147483650;
2750 }
2751 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002752 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002753 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2754 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002755}
2756
Devin Moore7b8d5c92020-03-17 14:14:08 -07002757TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002758 AidlError error;
2759 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002760 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002761 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002762 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2763 R"(package p;
2764 interface IFoo {
2765 const long int64_max_oob = 21474836509999999999999999;
2766 }
2767 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002768 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002769 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2770 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002771}
2772
Devin Moore7b8d5c92020-03-17 14:14:08 -07002773TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002774 AidlError error;
2775 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002776 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002777 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002778 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2779 R"(package p;
2780 interface IFoo {
2781 const long int64_min_oob = -21474836509999999999999999;
2782 }
2783 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002784 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002785 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2786 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002787}
2788
Devin Moore7b8d5c92020-03-17 14:14:08 -07002789TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002790 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002791 const string expected_stderr =
2792 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2793 "literal: byte\n"
2794 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2795 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002796 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2797 R"(package p;
2798 @Backing(type="byte")
2799 enum TestEnum {
2800 FOO = 127,
2801 BAR,
2802 }
2803 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002804 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002805 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002806 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002807}
2808
Devin Mooredecaf292020-04-30 09:16:40 -07002809TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2810 AidlError error;
2811 const string expected_stderr =
2812 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2813 "be one of: type\n"
2814 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2815 "be one of: type\n";
2816 CaptureStderr();
2817 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2818 R"(package p;
2819 @Backing(foo="byte")
2820 enum TestEnum {
2821 FOO = 1,
2822 BAR,
2823 }
2824 )",
2825 typenames_, GetLanguage(), &error));
2826 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2827 EXPECT_EQ(AidlError::BAD_TYPE, error);
2828}
2829
Jooyung Han66813932020-10-23 13:24:44 +09002830TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002831 io_delegate_.SetFileContents("Foo.aidl",
2832 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2833 "Map<String, Baz> d; Bar[] e; }");
2834 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2835 io_delegate_.SetFileContents("Baz.aidl",
2836 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002837 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2838 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2839}
2840
Jooyung Han66813932020-10-23 13:24:44 +09002841TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002842 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002843 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09002844 string expected_error =
2845 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable parcelable 'Foo' has a non-immutable field "
2846 "named 'bar'.\n";
2847 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002848 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2849 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09002850 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002851}
2852
Jooyung Han66813932020-10-23 13:24:44 +09002853TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002854 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002855 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
2856 string expected_error =
2857 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
2858 "only be an in parameter.\n";
2859 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002860 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2861 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002862 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002863}
2864
Jooyung Han66813932020-10-23 13:24:44 +09002865TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002866 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002867 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
2868 string expected_error =
2869 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
2870 "only be an in parameter.\n";
2871 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002872 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2873 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002874 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002875}
2876
Jooyung Han66813932020-10-23 13:24:44 +09002877TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002878 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002879 Options options = Options::From("aidl --lang=java Foo.aidl");
2880 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002881 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002882 "capitalizing the first letter\n";
2883 CaptureStderr();
2884 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2885 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2886}
Devin Moore53fc99c2020-08-12 08:07:52 -07002887
Jooyung Han1f14ab32020-10-14 13:48:29 +09002888const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2889
2890#include <a/ByteEnum.h>
2891#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09002892#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002893#include <binder/Status.h>
2894#include <cstdint>
Jooyung Han3df81ae2020-10-17 17:59:59 +09002895#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002896#include <utility>
2897#include <variant>
2898#include <vector>
2899
2900namespace a {
2901
2902class Foo : public ::android::Parcelable {
2903public:
Jooyung Han97945de2020-10-15 16:41:38 +09002904 inline bool operator!=(const Foo& rhs) const {
2905 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002906 }
Jooyung Han97945de2020-10-15 16:41:38 +09002907 inline bool operator<(const Foo& rhs) const {
2908 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002909 }
Jooyung Han97945de2020-10-15 16:41:38 +09002910 inline bool operator<=(const Foo& rhs) const {
2911 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002912 }
Jooyung Han97945de2020-10-15 16:41:38 +09002913 inline bool operator==(const Foo& rhs) const {
2914 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002915 }
Jooyung Han97945de2020-10-15 16:41:38 +09002916 inline bool operator>(const Foo& rhs) const {
2917 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002918 }
Jooyung Han97945de2020-10-15 16:41:38 +09002919 inline bool operator>=(const Foo& rhs) const {
2920 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002921 }
Jooyung Han97945de2020-10-15 16:41:38 +09002922
Jooyung Han1f14ab32020-10-14 13:48:29 +09002923 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09002924 ns = 0, // int[] ns;
2925 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09002926 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002927 };
Jooyung Han97945de2020-10-15 16:41:38 +09002928
Jooyung Han1f14ab32020-10-14 13:48:29 +09002929 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09002930 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002931
2932 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09002933 Foo(const Foo&) = default;
2934 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002935 Foo& operator=(const Foo&) = default;
2936 Foo& operator=(Foo&&) = default;
2937
Jooyung Han97945de2020-10-15 16:41:38 +09002938 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
2939 constexpr Foo(_Tp&& _arg)
2940 : _value(std::forward<_Tp>(_arg)) {}
2941
2942 template <typename... _Tp>
2943 constexpr explicit Foo(_Tp&&... _args)
2944 : _value(std::forward<_Tp>(_args)...) {}
2945
2946 template <Tag _tag, typename... _Tp>
2947 static Foo make(_Tp&&... _args) {
2948 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002949 }
Jooyung Han97945de2020-10-15 16:41:38 +09002950
2951 template <Tag _tag, typename _Tp, typename... _Up>
2952 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
2953 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002954 }
2955
2956 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002957 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09002958 }
2959
Jooyung Han97945de2020-10-15 16:41:38 +09002960 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002961 const auto& get() const {
Jooyung Han97945de2020-10-15 16:41:38 +09002962 if (getTag() != _tag) { abort(); }
2963 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002964 }
2965
Jooyung Han97945de2020-10-15 16:41:38 +09002966 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002967 auto& get() {
Jooyung Han97945de2020-10-15 16:41:38 +09002968 if (getTag() != _tag) { abort(); }
2969 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002970 }
2971
Jooyung Han97945de2020-10-15 16:41:38 +09002972 template <Tag _tag, typename... _Tp>
2973 void set(_Tp&&... _args) {
2974 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09002975 }
2976
2977 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
2978 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
2979 static const std::string& getParcelableDescriptor() {
2980 static const std::string DESCIPTOR = "a.Foo";
2981 return DESCIPTOR;
2982 }
2983private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09002984 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09002985}; // class Foo
2986
2987} // namespace a
2988)";
2989
2990const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
2991
2992namespace a {
2993
2994::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
2995 ::android::status_t _aidl_ret_status;
2996 int32_t _aidl_tag;
2997 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
2998 switch (_aidl_tag) {
2999 case ns: {
3000 ::std::vector<int32_t> _aidl_value;
3001 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
3002 set<ns>(std::move(_aidl_value));
3003 return ::android::OK; }
3004 case e: {
3005 ::a::ByteEnum _aidl_value;
3006 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
3007 set<e>(std::move(_aidl_value));
3008 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003009 case pfd: {
3010 ::android::os::ParcelFileDescriptor _aidl_value;
3011 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
3012 set<pfd>(std::move(_aidl_value));
3013 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003014 }
3015 return ::android::BAD_VALUE;
3016}
3017
3018::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3019 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3020 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3021 switch (getTag()) {
3022 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3023 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003024 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003025 }
3026 abort();
3027}
3028
3029} // namespace a
3030)";
3031
Jooyung Han6beac042020-10-17 21:59:43 +09003032const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3033#include <android/binder_interface_utils.h>
3034#include <android/binder_parcelable_utils.h>
3035
3036#include <type_traits>
3037#include <utility>
3038#include <variant>
3039#include <cstdint>
3040#include <memory>
3041#include <optional>
3042#include <string>
3043#include <vector>
3044#ifdef BINDER_STABILITY_SUPPORT
3045#include <android/binder_stability.h>
3046#endif // BINDER_STABILITY_SUPPORT
3047#include <aidl/a/ByteEnum.h>
3048namespace aidl {
3049namespace a {
3050class Foo {
3051public:
3052 typedef std::false_type fixed_size;
3053 static const char* descriptor;
3054
3055 enum Tag : int32_t {
3056 ns = 0, // int[] ns;
3057 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003058 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003059 };
3060
3061 template<typename _Tp>
3062 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3063
3064 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3065 Foo(const Foo&) = default;
3066 Foo(Foo&&) = default;
3067 Foo& operator=(const Foo&) = default;
3068 Foo& operator=(Foo&&) = default;
3069
3070 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
3071 constexpr Foo(_Tp&& _arg)
3072 : _value(std::forward<_Tp>(_arg)) {}
3073
3074 template <typename... _Tp>
3075 constexpr explicit Foo(_Tp&&... _args)
3076 : _value(std::forward<_Tp>(_args)...) {}
3077
3078 template <Tag _tag, typename... _Tp>
3079 static Foo make(_Tp&&... _args) {
3080 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3081 }
3082
3083 template <Tag _tag, typename _Tp, typename... _Up>
3084 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3085 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3086 }
3087
3088 Tag getTag() const {
3089 return static_cast<Tag>(_value.index());
3090 }
3091
3092 template <Tag _tag>
3093 const auto& get() const {
3094 if (getTag() != _tag) { abort(); }
3095 return std::get<_tag>(_value);
3096 }
3097
3098 template <Tag _tag>
3099 auto& get() {
3100 if (getTag() != _tag) { abort(); }
3101 return std::get<_tag>(_value);
3102 }
3103
3104 template <Tag _tag, typename... _Tp>
3105 void set(_Tp&&... _args) {
3106 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3107 }
3108
3109 binder_status_t readFromParcel(const AParcel* _parcel);
3110 binder_status_t writeToParcel(AParcel* _parcel) const;
3111 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
3112private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003113 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003114};
3115} // namespace a
3116} // namespace aidl
3117)";
3118
3119const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3120
3121#include <android/binder_parcel_utils.h>
3122
3123namespace aidl {
3124namespace a {
3125const char* Foo::descriptor = "a.Foo";
3126
3127binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3128 binder_status_t _aidl_ret_status;
3129 int32_t _aidl_tag;
3130 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3131 switch (_aidl_tag) {
3132 case ns: {
3133 std::vector<int32_t> _aidl_value;
3134 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3135 set<ns>(std::move(_aidl_value));
3136 return STATUS_OK; }
3137 case e: {
3138 ::aidl::a::ByteEnum _aidl_value;
3139 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
3140 set<e>(std::move(_aidl_value));
3141 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003142 case pfd: {
3143 ::ndk::ScopedFileDescriptor _aidl_value;
3144 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3145 set<pfd>(std::move(_aidl_value));
3146 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003147 }
3148 return STATUS_BAD_VALUE;
3149}
3150binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3151 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3152 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3153 switch (getTag()) {
3154 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3155 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003156 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003157 }
3158 abort();
3159}
3160
3161} // namespace a
3162} // namespace aidl
3163)";
3164
Jooyung Han1f14ab32020-10-14 13:48:29 +09003165const char kUnionExampleExpectedOutputJava[] = R"(/*
3166 * This file is auto-generated. DO NOT MODIFY.
3167 */
3168package a;
3169
3170
3171public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003172 // tags for union fields
3173 public final static int ns = 0; // int[] ns;
3174 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003175 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003176
3177 private int _tag;
3178 private Object _value;
3179
3180 public Foo() {
3181 int[] value = {42};
3182 _set(ns, value);
3183 }
Jooyung Han97945de2020-10-15 16:41:38 +09003184
Jooyung Han1f14ab32020-10-14 13:48:29 +09003185 private Foo(android.os.Parcel _aidl_parcel) {
3186 readFromParcel(_aidl_parcel);
3187 }
Jooyung Han97945de2020-10-15 16:41:38 +09003188
Jooyung Han1f14ab32020-10-14 13:48:29 +09003189 private Foo(int tag, Object value) {
3190 _set(tag, value);
3191 }
3192
3193 public int getTag() {
3194 return _tag;
3195 }
3196
Jooyung Han97945de2020-10-15 16:41:38 +09003197 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003198
3199 public static Foo ns(int[] _value) {
3200 return new Foo(ns, _value);
3201 }
Jooyung Han97945de2020-10-15 16:41:38 +09003202
Jooyung Han1f14ab32020-10-14 13:48:29 +09003203 public int[] getNs() {
3204 _assertTag(ns);
3205 return (int[]) _value;
3206 }
Jooyung Han97945de2020-10-15 16:41:38 +09003207
Jooyung Han1f14ab32020-10-14 13:48:29 +09003208 public void setNs(int[] _value) {
3209 _set(ns, _value);
3210 }
3211
Jooyung Han97945de2020-10-15 16:41:38 +09003212 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003213
3214 public static Foo e(byte _value) {
3215 return new Foo(e, _value);
3216 }
Jooyung Han97945de2020-10-15 16:41:38 +09003217
Jooyung Han1f14ab32020-10-14 13:48:29 +09003218 public byte getE() {
3219 _assertTag(e);
3220 return (byte) _value;
3221 }
Jooyung Han97945de2020-10-15 16:41:38 +09003222
Jooyung Han1f14ab32020-10-14 13:48:29 +09003223 public void setE(byte _value) {
3224 _set(e, _value);
3225 }
3226
Jooyung Hand2fa0232020-10-19 02:51:41 +09003227 // ParcelFileDescriptor pfd;
3228
3229 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3230 return new Foo(pfd, _value);
3231 }
3232
3233 public android.os.ParcelFileDescriptor getPfd() {
3234 _assertTag(pfd);
3235 return (android.os.ParcelFileDescriptor) _value;
3236 }
3237
3238 public void setPfd(android.os.ParcelFileDescriptor _value) {
3239 _set(pfd, _value);
3240 }
3241
Jooyung Han1f14ab32020-10-14 13:48:29 +09003242 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3243 @Override
3244 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003245 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003246 }
3247 @Override
3248 public Foo[] newArray(int _aidl_size) {
3249 return new Foo[_aidl_size];
3250 }
3251 };
Jooyung Han97945de2020-10-15 16:41:38 +09003252
Jooyung Han1f14ab32020-10-14 13:48:29 +09003253 @Override
3254 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3255 _aidl_parcel.writeInt(_tag);
3256 switch (_tag) {
3257 case ns:
3258 _aidl_parcel.writeIntArray(getNs());
3259 break;
3260 case e:
3261 _aidl_parcel.writeByte(getE());
3262 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003263 case pfd:
3264 if ((getPfd()!=null)) {
3265 _aidl_parcel.writeInt(1);
3266 getPfd().writeToParcel(_aidl_parcel, 0);
3267 }
3268 else {
3269 _aidl_parcel.writeInt(0);
3270 }
3271 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003272 }
3273 }
Jooyung Han97945de2020-10-15 16:41:38 +09003274
Jooyung Han1f14ab32020-10-14 13:48:29 +09003275 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3276 int _aidl_tag;
3277 _aidl_tag = _aidl_parcel.readInt();
3278 switch (_aidl_tag) {
3279 case ns: {
3280 int[] _aidl_value;
3281 _aidl_value = _aidl_parcel.createIntArray();
3282 _set(_aidl_tag, _aidl_value);
3283 return; }
3284 case e: {
3285 byte _aidl_value;
3286 _aidl_value = _aidl_parcel.readByte();
3287 _set(_aidl_tag, _aidl_value);
3288 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003289 case pfd: {
3290 android.os.ParcelFileDescriptor _aidl_value;
3291 if ((0!=_aidl_parcel.readInt())) {
3292 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3293 }
3294 else {
3295 _aidl_value = null;
3296 }
3297 _set(_aidl_tag, _aidl_value);
3298 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003299 }
3300 throw new RuntimeException("union: out of range: " + _aidl_tag);
3301 }
Jooyung Han97945de2020-10-15 16:41:38 +09003302
Jooyung Han1f14ab32020-10-14 13:48:29 +09003303 @Override
3304 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003305 int _mask = 0;
3306 switch (getTag()) {
3307 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003308 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003309 break;
3310 }
3311 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003312 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003313 private int describeContents(Object _v) {
3314 if (_v == null) return 0;
3315 if (_v instanceof android.os.Parcelable) {
3316 return ((android.os.Parcelable) _v).describeContents();
3317 }
3318 return 0;
3319 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003320
3321 private void _assertTag(int tag) {
3322 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003323 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003324 }
3325 }
Jooyung Han97945de2020-10-15 16:41:38 +09003326
Jooyung Han1f14ab32020-10-14 13:48:29 +09003327 private String _tagString(int _tag) {
3328 switch (_tag) {
3329 case ns: return "ns";
3330 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003331 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003332 }
3333 throw new IllegalStateException("unknown field: " + _tag);
3334 }
Jooyung Han97945de2020-10-15 16:41:38 +09003335
Jooyung Han1f14ab32020-10-14 13:48:29 +09003336 private void _set(int tag, Object value) {
3337 this._tag = tag;
3338 this._value = value;
3339 }
3340}
3341)";
3342
Jooyung Han97945de2020-10-15 16:41:38 +09003343struct AidlUnionTest : ::testing::Test {
3344 void SetUp() override {
3345 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003346package a;
3347import a.ByteEnum;
3348union Foo {
3349 int[] ns = {42};
3350 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003351 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003352}
3353)");
Jooyung Han97945de2020-10-15 16:41:38 +09003354 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003355package a;
3356@Backing(type="byte")
3357enum ByteEnum {
3358 a, b, c
3359}
3360)");
Jooyung Han97945de2020-10-15 16:41:38 +09003361 }
3362 FakeIoDelegate io_delegate_;
3363 void Compile(string lang) {
3364 string command = "aidl --structured -I. -o out --lang=" + lang;
3365 if (lang == "cpp" || lang == "ndk") {
3366 command += " -h out";
3367 }
3368 command += " a/Foo.aidl";
3369 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003370 CaptureStderr();
3371 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3372 auto err = GetCapturedStderr();
3373 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003374 }
3375 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3376 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003377 string actual;
3378 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3379 EXPECT_EQ(expected, actual);
3380 }
Jooyung Han97945de2020-10-15 16:41:38 +09003381 }
3382};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003383
Jooyung Han97945de2020-10-15 16:41:38 +09003384TEST_F(AidlUnionTest, Example_Cpp) {
3385 Compile("cpp");
3386 EXPECT_COMPILE_OUTPUTS(
3387 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3388 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3389}
3390
Jooyung Han6beac042020-10-17 21:59:43 +09003391TEST_F(AidlUnionTest, Example_Ndk) {
3392 Compile("ndk");
3393 EXPECT_COMPILE_OUTPUTS(
3394 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3395 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3396}
3397
Jooyung Han97945de2020-10-15 16:41:38 +09003398TEST_F(AidlUnionTest, Example_Java) {
3399 Compile("java");
3400 EXPECT_COMPILE_OUTPUTS(
3401 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003402 // TODO(b/170689477) Rust
3403}
3404
Jooyung Hanfe89f122020-10-14 03:49:18 +09003405TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3406 const string method = "package a; union Foo {}";
3407 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3408 CaptureStderr();
3409 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3410 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3411}
3412
3413TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3414 const string method = "package a; union Foo { ParcelableHolder x; }";
3415 const string expected_stderr =
3416 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3417 CaptureStderr();
3418 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3419 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3420}
3421
Devin Moore53fc99c2020-08-12 08:07:52 -07003422TEST_P(AidlTest, GenericStructuredParcelable) {
3423 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3424 Options options =
3425 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3426 const string expected_stderr = "";
3427 CaptureStderr();
3428 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3429 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3430}
3431
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003432TEST_F(AidlTest, NestedTypeArgs) {
3433 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
3434 io_delegate_.SetFileContents(
3435 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<Bar<String>> barss; }");
3436 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3437 const string expected_stderr = "";
3438 CaptureStderr();
3439 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3441
3442 string code;
3443 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
3444 EXPECT_THAT(code, testing::HasSubstr("a.Bar<a.Bar<java.lang.String>> barss;"));
3445}
3446
Jooyung Han14004ed2020-10-16 03:49:57 +09003447struct GenericAidlTest : ::testing::Test {
3448 FakeIoDelegate io_delegate_;
3449 void Compile(string cmd) {
3450 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux> > x; }");
3451 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3452 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3453 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3454
3455 Options options = Options::From(cmd);
3456 CaptureStderr();
3457 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3458 EXPECT_EQ("", GetCapturedStderr());
3459 }
3460};
3461
3462TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3463 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3464 string code;
3465 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3466 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3467 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3468 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3469}
3470
3471TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3472 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3473 string code;
3474 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3475 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3476 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3477 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3478}
3479
Devin Moore53fc99c2020-08-12 08:07:52 -07003480TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3481 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3482 Options options =
3483 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3484 const string expected_stderr =
3485 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3486 CaptureStderr();
3487 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3488 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3489}
3490
3491TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3492 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3493 Options options =
3494 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3495 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3496 CaptureStderr();
3497 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3498 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3499}
3500
Jooyung Hanea2147c2020-10-21 18:16:56 +09003501constexpr char kDescriptContentsWithUntypedListMapInJava[] = R"(
3502 @Override
3503 public int describeContents() {
3504 int _mask = 0;
3505 _mask |= describeContents(l);
3506 _mask |= describeContents(m);
3507 return _mask;
3508 }
3509 private int describeContents(Object _v) {
3510 if (_v == null) return 0;
3511 Class<?> _clazz = _v.getClass();
3512 if (_clazz.isArray() && _clazz.getComponentType() == Object.class) {
3513 int _mask = 0;
3514 for (Object o : (Object[]) _v) {
3515 _mask |= describeContents(o);
3516 }
3517 return _mask;
3518 }
3519 if (_v instanceof java.io.FileDescriptor) {
3520 return android.os.Parcelable.CONTENTS_FILE_DESCRIPTOR;
3521 }
3522 if (_v instanceof java.util.Collection) {
3523 int _mask = 0;
3524 for (Object o : (java.util.Collection) _v) {
3525 _mask |= describeContents(o);
3526 }
3527 return _mask;
3528 }
3529 if (_v instanceof java.util.Map) {
3530 return describeContents(((java.util.Map) _v).values());
3531 }
3532 if (_v instanceof android.os.Parcelable) {
3533 return ((android.os.Parcelable) _v).describeContents();
3534 }
3535 if (_v instanceof android.util.SparseArray) {
3536 android.util.SparseArray _sa = (android.util.SparseArray) _v;
3537 int _mask = 0;
3538 int _N = _sa.size();
3539 int _i = 0;
3540 while (_i < _N) {
3541 _mask |= describeContents(_sa.valueAt(_i));
3542 _i++;
3543 }
3544 return _mask;
3545 }
3546 return 0;
3547 }
3548)";
3549TEST_F(AidlTest, SupportUntypeListAndMap) {
3550 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3551 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3552 CaptureStderr();
3553 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3554 EXPECT_EQ("", GetCapturedStderr());
3555
3556 string code;
3557 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
3558 EXPECT_THAT(code, testing::HasSubstr(kDescriptContentsWithUntypedListMapInJava));
3559}
3560
Christopher Wiley90be4e32015-10-20 14:55:25 -07003561} // namespace aidl
3562} // namespace android