blob: 9b899d149a793818a967206fccca5c0d389346ec [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900333 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
334 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700335 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700336 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900338}
339
Jiyong Park40782d02020-07-24 19:17:43 +0900340TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
342 const string expected_stderr =
343 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344 CaptureStderr();
345 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900347}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348
Jiyong Park40782d02020-07-24 19:17:43 +0900349TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700350 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900351 const string expected_stderr =
352 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
369 const string expected_stderr =
370 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
371 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800374}
375
Devin Moore2f2077a2020-08-28 11:27:53 -0700376TEST_P(AidlTest, AcceptNullableList) {
377 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
378 const string expected_stderr = "";
379 CaptureStderr();
380 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 const string method = "package a; interface IFoo { void f(int a, int a); }";
386 const string expected_stderr =
387 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
388 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700391}
392
Jeongik Cha13066da2020-08-06 15:43:19 +0900393TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
394 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900395 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900396 CaptureStderr();
397 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
399}
400
Jooyung Hand902a972020-10-23 17:32:44 +0900401TEST_P(AidlTest, RejectsRepeatedAnnotations) {
402 const string method = R"(@Hide @Hide parcelable Foo {})";
403 const string expected_stderr =
404 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
405 "Foo.aidl:1.1-6\n";
406 CaptureStderr();
407 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
408 EXPECT_EQ(expected_stderr, GetCapturedStderr());
409}
410
Devin Moore7b8d5c92020-03-17 14:14:08 -0700411TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700412 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
413 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
414 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700415 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700416 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100417}
418
Devin Moore7b8d5c92020-03-17 14:14:08 -0700419TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700420 AidlError error;
421 const string method = "package a; @nullable interface IFoo { int f(); }";
422 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800423 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900424 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700425 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700426 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700427 EXPECT_EQ(expected_stderr, GetCapturedStderr());
428 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800429}
430
Devin Moore7b8d5c92020-03-17 14:14:08 -0700431TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700432 AidlError error;
433 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
434 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800435 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900436 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700437 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700438 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700439 EXPECT_EQ(expected_stderr, GetCapturedStderr());
440 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800441}
442
Devin Moore7b8d5c92020-03-17 14:14:08 -0700443TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700444 AidlError error;
445 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
446 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000447 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900448 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900449 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700450 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000451 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700452 EXPECT_EQ(expected_stderr, GetCapturedStderr());
453 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800454}
455
Devin Moore7b8d5c92020-03-17 14:14:08 -0700456TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700457 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000458 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700459 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000460 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900461 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700462 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700463 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000464 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700465 EXPECT_EQ(expected_stderr, GetCapturedStderr());
466 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800467}
468
Jiyong Park40782d02020-07-24 19:17:43 +0900469TEST_P(AidlTest, ParsesNonNullableAnnotation) {
470 auto parse_result =
471 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
472 ASSERT_NE(nullptr, parse_result);
473 const AidlInterface* interface = parse_result->AsInterface();
474 ASSERT_NE(nullptr, interface);
475 ASSERT_FALSE(interface->GetMethods().empty());
476 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
477}
478
Devin Moore7b8d5c92020-03-17 14:14:08 -0700479TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900480 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
481 typenames_, GetLanguage());
482 ASSERT_NE(nullptr, parse_result);
483 const AidlInterface* interface = parse_result->AsInterface();
484 ASSERT_NE(nullptr, interface);
485 ASSERT_FALSE(interface->GetMethods().empty());
486 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
487}
488
489TEST_P(AidlTest, ParsesNonUtf8Annotations) {
490 auto parse_result =
491 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
492 ASSERT_NE(nullptr, parse_result);
493 const AidlInterface* interface = parse_result->AsInterface();
494 ASSERT_NE(nullptr, interface);
495 ASSERT_FALSE(interface->GetMethods().empty());
496 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800497}
498
Devin Moore7b8d5c92020-03-17 14:14:08 -0700499TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900500 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
501 typenames_, GetLanguage());
502 ASSERT_NE(nullptr, parse_result);
503 const AidlInterface* interface = parse_result->AsInterface();
504 ASSERT_NE(nullptr, interface);
505 ASSERT_FALSE(interface->GetMethods().empty());
506 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800507}
508
Devin Moore7b8d5c92020-03-17 14:14:08 -0700509TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700510 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700511 const string expected_stderr =
512 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
513 "\"vintf\"'\n"
514 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
515 "--structured\n";
516 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700517 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700518 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700519 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700520 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521}
522
Devin Moore7b8d5c92020-03-17 14:14:08 -0700523TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700524 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700525 const string expected_stderr =
526 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
527 "--structured\n";
528 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700529 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700530 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700531 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700532 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533}
534
Devin Moore7b8d5c92020-03-17 14:14:08 -0700535TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700536 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700537 const string expected_stderr =
538 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
539 "\"vintf\"'\n";
540 CaptureStderr();
541 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700542 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700543 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700544 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545}
546
Devin Moore7b8d5c92020-03-17 14:14:08 -0700547TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700548 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700549 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
550 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700551 ASSERT_EQ(AidlError::OK, error);
552 ASSERT_NE(nullptr, parse_result);
553 const AidlInterface* interface = parse_result->AsInterface();
554 ASSERT_NE(nullptr, interface);
555 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700556}
557
Jeongik Cha64783ed2019-06-07 18:30:54 +0900558TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
559 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900560 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
561 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900562 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700563 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900564 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900565 "a/Foo.aidl",
566 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900567
568 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900569 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700570 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900571 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700572 "Parcelable must be defined in AIDL directly.\n";
573 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900574 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700575 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700576
577 CaptureStderr();
578 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
579 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900580}
581
Jooyung Han1cbc4962020-10-25 10:07:15 +0900582TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
583 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
584 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
585 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900586 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
587
588 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900589 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900590 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
591
592 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900593 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900594 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
595
Jooyung Han1cbc4962020-10-25 10:07:15 +0900596 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900597 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
598}
599
Jooyung Han1cbc4962020-10-25 10:07:15 +0900600TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
601 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
602 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
603 CaptureStderr();
604 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
605 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
606 EXPECT_EQ("", GetCapturedStderr());
607
608 const string expected_to_string_method = R"--(
609 @Override
610 public String toString() {
611 switch (_tag) {
612 case a: return "a.Foo.a(" + (getA()) + ")";
613 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
614 }
615 throw new IllegalStateException("unknown field: " + _tag);
616 }
617)--";
618
619 string java_out;
620 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
621 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
622}
623
Jooyung Han90345002020-10-23 15:28:53 +0900624TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900625 {
Jooyung Han90345002020-10-23 15:28:53 +0900626 io_delegate_.SetFileContents("a/Foo.aidl",
627 "package a; @JavaDerive(blah=true) parcelable Foo{}");
628 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
629 CaptureStderr();
630 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
631 const std::string expected_stderr =
632 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
633 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
634 }
635
636 {
637 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900638 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
639 CaptureStderr();
640 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
641 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900642 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900643 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
644 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900645 EXPECT_EQ(expected_stderr, GetCapturedStderr());
646 }
647
648 {
Jooyung Han90345002020-10-23 15:28:53 +0900649 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900650 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
651 CaptureStderr();
652 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
653 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900654 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900655 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
656 EXPECT_EQ(expected_stderr, GetCapturedStderr());
657 }
658}
659
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900660TEST_P(AidlTest, ParseDescriptorAnnotation) {
661 AidlError error;
662 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
663 typenames_, GetLanguage(), &error, {"--structured"});
664 ASSERT_EQ(AidlError::OK, error);
665 ASSERT_NE(nullptr, parse_result);
666 const AidlInterface* interface = parse_result->AsInterface();
667 ASSERT_NE(nullptr, interface);
668 ASSERT_EQ("IBar", interface->GetDescriptor());
669}
670
Jiyong Park40782d02020-07-24 19:17:43 +0900671TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700672 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700673 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900674}
675
676TEST_P(AidlTest, AcceptsOnewayInterface) {
677 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700678 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700679}
Christopher Wileyef140932015-11-03 09:29:19 -0800680
Devin Moore7b8d5c92020-03-17 14:14:08 -0700681TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700682 const string oneway_method =
683 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700684 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100685}
686
Steven Moreland65297cc2020-04-20 20:17:36 -0700687TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
688 const string oneway_method =
689 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
690 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
691 ASSERT_NE(nullptr, defined);
692 const AidlInterface* iface = defined->AsInterface();
693 ASSERT_NE(nullptr, iface);
694
695 const auto& methods = iface->GetMethods();
696 ASSERT_EQ(1u, methods.size());
697 const auto& method = methods[0];
698 const AidlTypeSpecifier& ret_type = method->GetType();
699
700 // TODO(b/151102494): these annotations should be on the method
701 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
702 ASSERT_TRUE(ret_type.IsHide());
703}
704
Devin Moore7b8d5c92020-03-17 14:14:08 -0700705TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100706 string foo_interface =
707 "package a; /* foo */ interface IFoo {"
708 " /* i */ int i();"
709 " /* j */ @nullable String j();"
710 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
711
Devin Moore7b8d5c92020-03-17 14:14:08 -0700712 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100713 EXPECT_NE(nullptr, parse_result);
714 EXPECT_EQ("/* foo */", parse_result->GetComments());
715
716 const AidlInterface* interface = parse_result->AsInterface();
717 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
718 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
719 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
720}
721
Jooyung Han1a551d32020-10-05 15:37:26 +0900722TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
723 io_delegate_.SetFileContents("p/cpp_header.aidl",
724 R"(package p;
725 parcelable cpp_header cpp_header "bar/header";)");
726 import_paths_.emplace("");
727 const string input_path = "p/IFoo.aidl";
728 const string input = R"(package p;
729 import p.cpp_header;
730 interface IFoo {
731 // get bar
732 cpp_header get();
733 })";
734
735 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
736 EXPECT_NE(nullptr, parse_result);
737 const AidlInterface* interface = parse_result->AsInterface();
738 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
739}
740
Christopher Wileyef140932015-11-03 09:29:19 -0800741TEST_F(AidlTest, ParsesPreprocessedFile) {
742 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
743 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700744 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900745 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700746 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
747 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800748}
749
750TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
751 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
752 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900753
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700754 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900755 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700756 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
757 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800758}
759
Devin Moore7b8d5c92020-03-17 14:14:08 -0700760TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800761 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
762 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
763 "interface IBar {}");
764 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900765 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900766 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700767 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800768 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900769
Christopher Wiley41544372015-11-03 14:52:29 -0800770 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700771 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
772 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800773 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700774 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900775 ambiguous_type.Resolve(typenames_);
776 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800777}
778
Jiyong Park8f6ec462020-01-19 20:52:47 +0900779// Special case of PreferImportToPreprocessed. Imported type should be preferred
780// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700781TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900782 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
783 io_delegate_.SetFileContents("one/IBar.aidl",
784 "package one; "
785 "interface IBar {}");
786 preprocessed_files_.push_back("preprocessed");
787 import_paths_.emplace("");
788 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700789 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900790 EXPECT_NE(nullptr, parse_result);
791
792 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700793 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
794 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900795 // But if we request just "IBar" we should get our imported one.
796 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
797 ambiguous_type.Resolve(typenames_);
798 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
799}
800
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800801TEST_F(AidlTest, WritePreprocessedFile) {
802 io_delegate_.SetFileContents("p/Outer.aidl",
803 "package p; parcelable Outer.Inner;");
804 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
805 "interface IBar {}");
806
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900807 vector<string> args {
808 "aidl",
809 "--preprocess",
810 "preprocessed",
811 "p/Outer.aidl",
812 "one/IBar.aidl"};
813 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800814 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
815
816 string output;
817 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
818 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
819}
820
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900821TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100822 io_delegate_.SetFileContents(
823 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800824 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100825 "parcelable Rect {\n"
826 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800827 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100828 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800829 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100830 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100831 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
832 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100833 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900834 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900835 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100836 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900837
838 vector<string> args{"aidl", "Rect.aidl"};
839 Options options = Options::From(args);
840 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
841
842 string output;
843 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900844 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900845}
846
Devin Moore2f2077a2020-08-28 11:27:53 -0700847TEST_F(AidlTest, CppHeaderIncludes) {
848 io_delegate_.SetFileContents("IFoo.aidl",
849 "interface IFoo {\n"
850 " @nullable List<String> foo();\n"
851 "}");
852
853 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
854 Options options = Options::From(args);
855 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
856 std::vector<std::string> empty;
857 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
858 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
859 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
860
861 // Make sure the optional and String16.h includes are added
862 string output;
863 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
864 EXPECT_EQ(kExpectedCppHeaderOutput, output);
865}
866
Devin Moore7b8d5c92020-03-17 14:14:08 -0700867TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700868 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800869 io_delegate_.SetFileContents("p/Outer.aidl",
870 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900871 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700872 CaptureStderr();
873 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
874 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700875 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700876 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800877}
878
Devin Moore7b8d5c92020-03-17 14:14:08 -0700879TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800880 io_delegate_.SetFileContents("preprocessed",
881 "parcelable p.Outer.Inner;");
882 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900883 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700884 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800885 // TODO(wiley): This should actually return nullptr because we require
886 // the outer class name. However, for legacy reasons,
887 // this behavior must be maintained. b/17415692
888 EXPECT_NE(nullptr, parse_result);
889}
890
Christopher Wiley632801d2015-11-05 14:15:49 -0800891TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700892 const string expected_foo_stderr =
893 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
894 "Declared parcelables should be in their own file and/or cannot be used with --structured "
895 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700896 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
897
Christopher Wiley632801d2015-11-05 14:15:49 -0800898 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700899 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700900 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900901 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700902 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900903
Steven Morelande2c64b42018-09-18 15:06:37 -0700904 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900905 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700906 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900907 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700908 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700909
Devin Moore097a3ab2020-03-11 16:08:44 -0700910 const string expected_bar_stderr =
911 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
912 "Declared parcelables should be in their own file and/or cannot be used with --structured "
913 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700914 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
915
Jiyong Parkda8c6932019-08-12 19:56:08 +0900916 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700917 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700918 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900919 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700920 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700921 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700923 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700924 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800925}
926
Devin Moore7b8d5c92020-03-17 14:14:08 -0700927TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700928 const string expected_stderr =
929 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
930 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700931 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
932 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700933 AidlError error;
934 CaptureStderr();
935 EXPECT_EQ(
936 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700937 Parse("p/IFoo.aidl",
938 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700939 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
941 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700942}
943
Devin Moore7b8d5c92020-03-17 14:14:08 -0700944TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700945 AidlError error;
946 const string expected_stderr =
947 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
948 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900949 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
950 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700951 interface IFoo {
952 const String DUPLICATED = "d";
953 const int DUPLICATED = 1;
954 }
955 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700956 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700957 EXPECT_EQ(expected_stderr, GetCapturedStderr());
958 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700959}
960
Steven Morelande689da22020-11-10 02:06:30 +0000961TEST_P(AidlTest, FailOnTooBigConstant) {
962 AidlError error;
963 const string expected_stderr =
964 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
965 CaptureStderr();
966 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
967 R"(package p;
968 interface IFoo {
969 const byte type2small = 256;
970 }
971 )",
972 typenames_, GetLanguage(), &error));
973 EXPECT_EQ(expected_stderr, GetCapturedStderr());
974 EXPECT_EQ(AidlError::BAD_TYPE, error);
975}
976
Devin Moore7b8d5c92020-03-17 14:14:08 -0700977TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700978 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700979 const string expected_stderr =
980 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700981 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700982 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
983 R"(package p;
984 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700985 parcelable IBar {}
986 parcelable StructuredParcelable {}
987 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900988 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700989 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700990 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700991 // Parse success is important for clear error handling even if the cases aren't
992 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700993 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700994}
995
Devin Moore7b8d5c92020-03-17 14:14:08 -0700996TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700997 AidlError error;
998 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
999 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001000 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001001 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1002 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001003}
1004
Steven Morelandf9e922f2020-07-08 21:15:27 +00001005TEST_P(AidlTest, FailOnEmptyListWithComma) {
1006 AidlError error;
1007 const string expected_stderr =
1008 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1009 CaptureStderr();
1010 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1011 typenames_, GetLanguage(), &error));
1012 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1013 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1014}
1015
Devin Moore7b8d5c92020-03-17 14:14:08 -07001016TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001017 AidlError error;
1018 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001019 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001020 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001021 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1022 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001023 interface IFoo {
1024 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1025 }
1026 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001027 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001028 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1029 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001030}
1031
Jiyong Park18132182020-06-08 20:24:40 +09001032TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1033 AidlError error;
1034 const string expected_stderr =
1035 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1036 "cpp_header (which can also be used as an identifier)\n";
1037 CaptureStderr();
1038 // Notice the trailing dot(.) in the name, which isn't a correct name
1039 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1040 GetLanguage(), &error));
1041 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1042 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1043}
1044
1045TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1046 AidlError error;
1047 const string expected_stderr =
1048 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1049 "cpp_header (which can also be used as an identifier)\n";
1050 CaptureStderr();
1051 // Notice the trailing dot(.) in the package name
1052 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1053 GetLanguage(), &error));
1054 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1055 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1056}
1057
Devin Moore7b8d5c92020-03-17 14:14:08 -07001058TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001059 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001060 auto parse_result = Parse("p/IFoo.aidl",
1061 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001062 interface IFoo {
1063 const int POSITIVE_HEX_VALUE = 0xf5;
1064 }
1065 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001066 typenames_, GetLanguage(), &error);
1067 EXPECT_NE(nullptr, parse_result);
1068 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001069 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001070 const auto& cpp_constants = interface->GetConstantDeclarations();
1071 EXPECT_EQ((size_t)1, cpp_constants.size());
1072 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001073 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001074 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001075}
1076
Devin Moore7b8d5c92020-03-17 14:14:08 -07001077TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001078 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001079 auto parse_result = Parse("p/IFoo.aidl",
1080 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001081 interface IFoo {
1082 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1083 }
1084 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001085 typenames_, GetLanguage(), &error);
1086 ASSERT_NE(nullptr, parse_result);
1087 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001088 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001089 const auto& cpp_constants = interface->GetConstantDeclarations();
1090 EXPECT_EQ((size_t)1, cpp_constants.size());
1091 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001092 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001093 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001094}
1095
Devin Moore7b8d5c92020-03-17 14:14:08 -07001096TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001097 io_delegate_.SetFileContents(
1098 "p/Outer.aidl",
1099 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001100 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001101 const string input_path = "p/IFoo.aidl";
1102 const string input = "package p; import p.Outer; interface IFoo"
1103 " { Outer.Inner get(); }";
1104
Devin Moore7b8d5c92020-03-17 14:14:08 -07001105 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1106 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001107
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001108 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001109 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001110 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1111 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001112}
1113
Devin Moore7b8d5c92020-03-17 14:14:08 -07001114TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001115 io_delegate_.SetFileContents(
1116 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001117 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001118 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001119 const string input_path = "p/IFoo.aidl";
1120 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001121 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1122 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001123 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001124 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1125 native_type.Resolve(typenames_);
1126
1127 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1128 // C++ understands C++ specific stuff
1129 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1130 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001131 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001132 EXPECT_EQ(1u, headers.size());
1133 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001134}
1135
Christopher Wileyf8136192016-04-12 14:19:35 -07001136TEST_F(AidlTest, WritesCorrectDependencyFile) {
1137 // While the in tree build system always gives us an output file name,
1138 // other android tools take advantage of our ability to infer the intended
1139 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001140 vector<string> args = {
1141 "aidl",
1142 "-d dep/file/path",
1143 "-o place/for/output",
1144 "p/IFoo.aidl"};
1145 Options options = Options::From(args);
1146 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001147 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001148 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001149 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001150 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1151}
1152
Dan Willemsen93298ee2016-11-10 23:55:55 -08001153TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1154 // While the in tree build system always gives us an output file name,
1155 // other android tools take advantage of our ability to infer the intended
1156 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001157 vector<string> args = {
1158 "aidl",
1159 "-d dep/file/path",
1160 "--ninja",
1161 "-o place/for/output",
1162 "p/IFoo.aidl"};
1163 Options options = Options::From(args);
1164 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001165 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001166 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001167 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001168 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1169}
1170
Jiyong Parkdf202122019-09-30 20:48:35 +09001171TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001172 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1173 // this by calling aidl with every .aidl file it finds, then parsing the
1174 // generated dependency files. Those that reference .java output files are
1175 // for interfaces and those that do not are parcelables. However, for both
1176 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001177 vector<string> args = {
1178 "aidl",
1179 "-o place/for/output",
1180 "-d dep/file/path",
1181 "p/Foo.aidl"};
1182 Options options = Options::From(args);
1183 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001184 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001185 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001186 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001187 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1188}
1189
1190TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1191 vector<string> args = {
1192 "aidl",
1193 "--structured",
1194 "-o place/for/output",
1195 "-d dep/file/path",
1196 "p/Foo.aidl"};
1197 Options options = Options::From(args);
1198 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1199 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1200 string actual_dep_file_contents;
1201 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1202 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001203}
1204
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001205TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1206 vector<string> args = {
1207 "aidl",
1208 "--lang=java",
1209 "-o place/for/output",
1210 "p/Foo.aidl"};
1211 Options options = Options::From(args);
1212 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1213 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1214 string output_file_contents;
1215 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1216}
1217
Jeongik Cha08ca2182019-11-21 14:01:13 +09001218// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001219TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001220 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001221 "package a; interface IFoo {\n"
1222 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001223 string expected_stderr;
1224 switch (GetLanguage()) {
1225 case Options::Language::CPP:
1226 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001227 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001228 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1229 "String and IBinder.\n";
1230 break;
1231 case Options::Language::JAVA:
1232 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001233 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001234 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1235 "String, IBinder, and ParcelFileDescriptor.\n";
1236 break;
1237 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001238 case Options::Language::RUST:
1239 expected_stderr =
1240 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1241 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001242 default:
1243 AIDL_FATAL(AIDL_LOCATION_HERE)
1244 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1245 }
1246 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001247 AidlTypenames tn1;
1248 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001250
1251 string primitive_parcelable =
1252 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001253 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001254 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001255 AidlTypenames tn2;
1256 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001257 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001258}
1259
Devin Moore21b26772020-08-26 16:37:56 -07001260TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001261 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001262 const string list_array_parcelable =
1263 "package a; parcelable Foo {\n"
1264 " List[] lists; }";
1265 CaptureStderr();
1266 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1267 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1268}
1269
Jiyong Parkf8d53612020-05-04 14:06:13 +09001270TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1271 AidlError error;
1272 string expected_stderr =
1273 "ERROR: a/IFoo.aidl:2.7-11: "
1274 "Encountered an untyped List or Map. The use of untyped List/Map is "
1275 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1276 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1277 if (GetLanguage() != Options::Language::JAVA) {
1278 expected_stderr =
1279 "ERROR: a/IFoo.aidl:2.1-7: "
1280 "Currently, only the Java backend supports non-generic List.\n";
1281 }
1282
1283 const string primitive_interface =
1284 "package a; interface IFoo {\n"
1285 " List foo(); }";
1286 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001287 AidlTypenames tn1;
1288 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001289 {"--structured"}));
1290 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001291
1292 string primitive_parcelable =
1293 "package a; parcelable IFoo {\n"
1294 " List foo;}";
1295 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001296 AidlTypenames tn2;
1297 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001298 {"--structured"}));
1299 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1300}
1301
Jeongik Cha225519b2020-08-29 01:55:32 +09001302TEST_P(AidlTest, ExtensionTest) {
1303 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001304 string extendable_parcelable =
1305 "package a; parcelable Data {\n"
1306 " ParcelableHolder extension;\n"
1307 " ParcelableHolder extension2;\n"
1308 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001309 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001310 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1311 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001312 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001313 "yet.\n",
1314 GetCapturedStderr());
1315 } else {
1316 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1317 EXPECT_EQ("", GetCapturedStderr());
1318 }
1319}
1320TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1321 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001322 string parcelableholder_return_interface =
1323 "package a; interface IFoo {\n"
1324 " ParcelableHolder foo();\n"
1325 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001326 EXPECT_EQ(nullptr,
1327 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001328
Jeongik Cha8f02a532020-10-14 00:16:28 +09001329 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001330 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001331 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001332 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001333 "yet.\n",
1334 GetCapturedStderr());
1335 return;
1336 }
1337 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1338 GetCapturedStderr());
1339}
1340
1341TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1342 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001343 string extendable_parcelable_arg_interface =
1344 "package a; interface IFoo {\n"
1345 " void foo(in ParcelableHolder ph);\n"
1346 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001347 EXPECT_EQ(nullptr,
1348 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1349
Jeongik Cha8f02a532020-10-14 00:16:28 +09001350 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001351 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001352 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001353 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001354 "yet.\n",
1355 GetCapturedStderr());
1356 return;
1357 }
1358 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1359 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001360}
1361
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001362TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1363 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1364 Options options =
1365 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1366 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1367 CaptureStderr();
1368 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1369 if (GetLanguage() == Options::Language::RUST) {
1370 EXPECT_EQ(
1371 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1372 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1373 "yet.\n",
1374 GetCapturedStderr());
1375 return;
1376 }
1377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1378}
1379
Jiyong Park02da7422018-07-16 16:00:26 +09001380TEST_F(AidlTest, ApiDump) {
1381 io_delegate_.SetFileContents(
1382 "foo/bar/IFoo.aidl",
1383 "package foo.bar;\n"
1384 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001385 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001386 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001387 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001388 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1389 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1390 " IFoo foo3(IFoo foo);\n"
1391 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001392 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001393 " const int A = 1;\n"
1394 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001395 "}\n");
1396 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1397 "package foo.bar;\n"
1398 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001399 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001400 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001401 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001402 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001403 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001404 " int y;\n"
1405 " IFoo foo;\n"
1406 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001407 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001408 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001409 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001410 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001411 "}\n");
1412 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001413 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1414 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001415 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001416 bool result = dump_api(options, io_delegate_);
1417 ASSERT_TRUE(result);
1418 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001419 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001420 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001421/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001422interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001423 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001424 int foo(out int[] a, String b, boolean c, inout List<String> d);
1425 int foo2(@utf8InCpp String x, inout List<String> y);
1426 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1427 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001428 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001429 const int A = 1;
1430 const String STR = "Hello";
1431}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001432)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001433
Jiyong Parke59c3682018-09-11 23:10:25 +09001434 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001435 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001436/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001437parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001438 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001439 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001440 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001441 int y;
1442 foo.bar.IFoo foo;
1443 List<foo.bar.IFoo> a;
1444 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001445 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001446 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001447}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001448)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001449}
1450
Jiyong Parked65bf42018-08-28 15:43:27 +09001451TEST_F(AidlTest, ApiDumpWithManualIds) {
1452 io_delegate_.SetFileContents(
1453 "foo/bar/IFoo.aidl",
1454 "package foo.bar;\n"
1455 "interface IFoo {\n"
1456 " int foo() = 1;\n"
1457 " int bar() = 2;\n"
1458 " int baz() = 10;\n"
1459 "}\n");
1460
Jiyong Parke59c3682018-09-11 23:10:25 +09001461 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001462 Options options = Options::From(args);
1463 bool result = dump_api(options, io_delegate_);
1464 ASSERT_TRUE(result);
1465 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001466 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001467 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001468interface IFoo {
1469 int foo() = 1;
1470 int bar() = 2;
1471 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001472}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001473)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001474}
1475
1476TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001477 const string expected_stderr =
1478 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1479 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001480 io_delegate_.SetFileContents(
1481 "foo/bar/IFoo.aidl",
1482 "package foo.bar;\n"
1483 "interface IFoo {\n"
1484 " int foo() = 1;\n"
1485 " int bar();\n"
1486 " int baz() = 10;\n"
1487 "}\n");
1488
Jiyong Parke59c3682018-09-11 23:10:25 +09001489 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001490 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001491 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001492 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001493 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001494}
1495
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001496TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001497 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001498 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1499 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001500 const string expected_map_stderr =
1501 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001502 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1503 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001504 "package p; interface IFoo {"
1505 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001506 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001507 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001508 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001509
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001510 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001511 "package p; interface IFoo {"
1512 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001513 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001514 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001515 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001516}
1517
Jeongik Chae48d9942020-01-02 17:39:00 +09001518TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001519 const string expected_stderr =
1520 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001521 Options options = Options::From("aidl -I p p/IFoo.aidl");
1522 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1523
1524 io_delegate_.SetFileContents("p/IFoo.aidl",
1525 "package p; interface IFoo {"
1526 "Map<String, Bar> foo();}");
1527 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1528
1529 io_delegate_.SetFileContents("p/IFoo.aidl",
1530 "package p; interface IFoo {"
1531 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001532 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001533 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001534 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001535
1536 io_delegate_.SetFileContents("p/IFoo.aidl",
1537 "package p; interface IFoo {"
1538 "Map<String, String> foo();}");
1539 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1540
1541 io_delegate_.SetFileContents("p/IFoo.aidl",
1542 "package p; interface IFoo {"
1543 "Map<String, ParcelFileDescriptor> foo();}");
1544 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1545}
1546
Jeongik Chadf76dc72019-11-28 00:08:47 +09001547TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001548 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001549 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1550 io_delegate_.SetFileContents(options.InputFiles().front(),
1551 "package p; interface IFoo {"
1552 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001553 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001554 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001555 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001556}
1557
1558TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1559 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1560 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001561 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001562 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001563 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1564 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001565
1566 Options options = Options::From("aidl -I p p/IFoo.aidl");
1567 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1568 io_delegate_.SetFileContents("p/IFoo.aidl",
1569 "package p; interface IFoo {"
1570 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001571 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001572 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001573 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001574 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001575 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001576 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001577 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1578 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001579 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1580 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1581 io_delegate_.SetFileContents("p/IFoo.aidl",
1582 "package p; interface IFoo {"
1583 "Bar<String, ParcelFileDescriptor> foo();}");
1584 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001585
1586 io_delegate_.SetFileContents("p/IFoo.aidl",
1587 "package p; interface IFoo {"
1588 "Bar<int, long> foo();}");
1589
1590 io_delegate_.SetFileContents("p/IFoo.aidl",
1591 "package p; interface IFoo {"
1592 "Bar<int[], long[]> foo();}");
1593
1594 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001595}
1596
Jeongik Cha0e426012019-07-29 15:57:02 +09001597TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1598 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001599 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1600 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001601 for (const auto& rawOption : rawOptions) {
1602 string expected_stderr =
1603 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001604 Options options = Options::From(rawOption);
1605 io_delegate_.SetFileContents(options.InputFiles().front(),
1606 "package foo.bar;\n"
1607 "interface IFoo1 { int foo(); }\n"
1608 "interface IFoo2 { int foo(); }\n"
1609 "parcelable Data1 { int a; int b;}\n"
1610 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001611 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001612 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001613 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001614
Jeongik Cha0e426012019-07-29 15:57:02 +09001615 io_delegate_.SetFileContents(options.InputFiles().front(),
1616 "package foo.bar;\n"
1617 "interface IFoo1 { int foo(); }\n"
1618 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001619 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001620 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001621 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001622
Devin Moore5de18ed2020-04-02 13:52:29 -07001623 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001624 io_delegate_.SetFileContents(options.InputFiles().front(),
1625 "package foo.bar;\n"
1626 "parcelable Data1 { int a; int b;}\n"
1627 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001628 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001629 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001630 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001631 }
1632}
1633
Devin Moorebdba2a82020-03-31 15:19:02 -07001634TEST_P(AidlTest, FailParseOnEmptyFile) {
1635 const string contents = "";
1636 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1637 CaptureStderr();
1638 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1639 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1640}
1641
Jiyong Parkb034bf02018-07-30 17:44:33 +09001642TEST_F(AidlTest, MultipleInputFiles) {
1643 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001644 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001645
1646 io_delegate_.SetFileContents(options.InputFiles().at(0),
1647 "package foo.bar;\n"
1648 "import foo.bar.Data;\n"
1649 "interface IFoo { Data getData(); }\n");
1650
1651 io_delegate_.SetFileContents(options.InputFiles().at(1),
1652 "package foo.bar;\n"
1653 "import foo.bar.IFoo;\n"
1654 "parcelable Data { IFoo foo; }\n");
1655
1656 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1657
1658 string content;
1659 for (const auto file : {
1660 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1661 content.clear();
1662 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1663 EXPECT_FALSE(content.empty());
1664 }
1665}
1666
1667TEST_F(AidlTest, MultipleInputFilesCpp) {
1668 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001669 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001670
1671 io_delegate_.SetFileContents(options.InputFiles().at(0),
1672 "package foo.bar;\n"
1673 "import foo.bar.Data;\n"
1674 "interface IFoo { Data getData(); }\n");
1675
1676 io_delegate_.SetFileContents(options.InputFiles().at(1),
1677 "package foo.bar;\n"
1678 "import foo.bar.IFoo;\n"
1679 "parcelable Data { IFoo foo; }\n");
1680
1681 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1682
1683 string content;
1684 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001685 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001686 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1687 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1688 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1689 content.clear();
1690 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1691 EXPECT_FALSE(content.empty());
1692 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001693}
1694
Andrei Homescub62afd92020-05-11 19:24:59 -07001695TEST_F(AidlTest, MultipleInputFilesRust) {
1696 Options options =
1697 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1698
1699 io_delegate_.SetFileContents(options.InputFiles().at(0),
1700 "package foo.bar;\n"
1701 "import foo.bar.Data;\n"
1702 "interface IFoo { Data getData(); }\n");
1703
1704 io_delegate_.SetFileContents(options.InputFiles().at(1),
1705 "package foo.bar;\n"
1706 "import foo.bar.IFoo;\n"
1707 "parcelable Data { IFoo foo; }\n");
1708
1709 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1710
1711 string content;
1712 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1713 content.clear();
1714 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1715 EXPECT_FALSE(content.empty());
1716 }
1717}
1718
Devin Moore097a3ab2020-03-11 16:08:44 -07001719TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1720 const string expected_stderr =
1721 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001722 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1723 // int getInterfaceVersion() is one of the meta transactions
1724 io_delegate_.SetFileContents(options.InputFiles().front(),
1725 "package p; interface IFoo {"
1726 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001727 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001728 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001729 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1730}
Jiyong Park309668e2018-07-28 16:55:44 +09001731
Devin Moore097a3ab2020-03-11 16:08:44 -07001732TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1733 // boolean getInterfaceVersion() is not a meta transaction, but should be
1734 // prevented because return type is not part of a method signature
1735 const string expected_stderr =
1736 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1737 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001738 io_delegate_.SetFileContents(options.InputFiles().front(),
1739 "package p; interface IFoo {"
1740 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001741 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001742 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001743 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1744}
Jiyong Park309668e2018-07-28 16:55:44 +09001745
Devin Moore097a3ab2020-03-11 16:08:44 -07001746TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001747 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001748 const string expected_stderr =
1749 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1750 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001751 io_delegate_.SetFileContents(options.InputFiles().front(),
1752 "package p; interface IFoo {"
1753 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001754 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001755 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001756 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001757
1758 // this is not a meta interface method as it differs type arguments
1759 io_delegate_.SetFileContents(options.InputFiles().front(),
1760 "package p; interface IFoo {"
1761 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001762 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001763}
1764
Daniel Norman85aed542019-08-21 12:01:14 -07001765TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001766 Options options = Options::From("aidl --checkapi old new");
1767 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1768 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1769 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1770 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1771
1772 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1773}
1774
Jiyong Park3656c3c2018-08-01 20:02:01 +09001775TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001776 Options options = Options::From("aidl --checkapi old new");
1777 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1778 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001779
1780 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1781}
1782
Daniel Norman85aed542019-08-21 12:01:14 -07001783class AidlTestCompatibleChanges : public AidlTest {
1784 protected:
1785 Options options_ = Options::From("aidl --checkapi old new");
1786};
1787
1788TEST_F(AidlTestCompatibleChanges, NewType) {
1789 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1790 "package p;"
1791 "interface IFoo {"
1792 " void foo(int a);"
1793 "}");
1794 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1795 "package p;"
1796 "interface IFoo {"
1797 " void foo(int a);"
1798 "}");
1799 io_delegate_.SetFileContents("new/p/IBar.aidl",
1800 "package p;"
1801 "interface IBar {"
1802 " void bar();"
1803 "}");
1804 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1805}
1806
1807TEST_F(AidlTestCompatibleChanges, NewMethod) {
1808 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1809 "package p;"
1810 "interface IFoo {"
1811 " void foo(int a);"
1812 "}");
1813 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1814 "package p;"
1815 "interface IFoo {"
1816 " void foo(int a);"
1817 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001818 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001819 "}");
1820 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1821}
1822
1823TEST_F(AidlTestCompatibleChanges, NewField) {
1824 io_delegate_.SetFileContents("old/p/Data.aidl",
1825 "package p;"
1826 "parcelable Data {"
1827 " int foo;"
1828 "}");
1829 io_delegate_.SetFileContents("new/p/Data.aidl",
1830 "package p;"
1831 "parcelable Data {"
1832 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001833 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001834 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001835 "}");
1836 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1837}
1838
1839TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1840 io_delegate_.SetFileContents("old/p/Enum.aidl",
1841 "package p;"
1842 "enum Enum {"
1843 " FOO = 1,"
1844 "}");
1845 io_delegate_.SetFileContents("new/p/Enum.aidl",
1846 "package p;"
1847 "enum Enum {"
1848 " FOO = 1,"
1849 " BAR = 2,"
1850 "}");
1851 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1852}
1853
1854TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1855 io_delegate_.SetFileContents("old/p/Enum.aidl",
1856 "package p;"
1857 "enum Enum {"
1858 " FOO = 1,"
1859 " BAR = 2,"
1860 "}");
1861 io_delegate_.SetFileContents("new/p/Enum.aidl",
1862 "package p;"
1863 "enum Enum {"
1864 " BAR = 2,"
1865 " FOO = 1,"
1866 "}");
1867 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1868}
1869
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001870TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1871 io_delegate_.SetFileContents("old/p/Union.aidl",
1872 "package p;"
1873 "union Union {"
1874 " String foo;"
1875 "}");
1876 io_delegate_.SetFileContents("new/p/Union.aidl",
1877 "package p;"
1878 "union Union {"
1879 " String foo;"
1880 " int num;"
1881 "}");
1882 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1883}
1884
Daniel Norman85aed542019-08-21 12:01:14 -07001885TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001886 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1887 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001888 "interface IFoo {"
1889 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001890 "}");
1891 io_delegate_.SetFileContents("old/p/Data.aidl",
1892 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001893 "parcelable Data {"
1894 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001895 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001896 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1897 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001898 "interface IFoo {"
1899 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001900 "}");
1901 io_delegate_.SetFileContents("new/p/Data.aidl",
1902 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001903 "parcelable Data {"
1904 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001905 "}");
1906 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1907 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001908 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001909 " void foo(int a);"
1910 "}");
1911 io_delegate_.SetFileContents("new/q/Data.aidl",
1912 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001913 "parcelable Data {"
1914 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001915 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001916 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1917}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001918
Daniel Norman85aed542019-08-21 12:01:14 -07001919TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1920 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1921 "package p;"
1922 "interface IFoo {"
1923 " void foo(int a);"
1924 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001925 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1926 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001927 "interface IFoo {"
1928 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001929 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001930 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1931}
Jiyong Parke59c3682018-09-11 23:10:25 +09001932
Daniel Norman85aed542019-08-21 12:01:14 -07001933TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001934 io_delegate_.SetFileContents("old/p/I.aidl",
1935 "package p; interface I {"
1936 "const int A = 1; }");
1937 io_delegate_.SetFileContents("new/p/I.aidl",
1938 "package p ; interface I {"
1939 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001940 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1941}
Jiyong Parka428d212018-08-29 22:26:30 +09001942
Daniel Norman85aed542019-08-21 12:01:14 -07001943TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001944 io_delegate_.SetFileContents("old/p/I.aidl",
1945 "package p; interface I {"
1946 "const int A = 1; const int B = 2;}");
1947 io_delegate_.SetFileContents("new/p/I.aidl",
1948 "package p ; interface I {"
1949 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001950 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001951}
1952
Jooyung Han69ea4ba2020-10-29 15:33:37 +09001953TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
1954 io_delegate_.SetFileContents("old/p/Foo.aidl",
1955 "package p;"
1956 "@JavaPassthrough(annotation=\"Alice\")"
1957 "@JavaPassthrough(annotation=\"Bob\")"
1958 "parcelable Foo {}");
1959 io_delegate_.SetFileContents("new/p/Foo.aidl",
1960 "package p;"
1961 "@JavaPassthrough(annotation=\"Bob\")"
1962 "@JavaPassthrough(annotation=\"Alice\")"
1963 "parcelable Foo {}");
1964 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1965}
1966
Jooyung Han636fd2f2020-10-22 11:33:45 +09001967TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
1968 io_delegate_.SetFileContents("old/p/Data.aidl",
1969 "package p;"
1970 "parcelable Data {"
1971 " int num;"
1972 "}");
1973 io_delegate_.SetFileContents(
1974 "new/p/Data.aidl",
1975 "package p;"
1976 "parcelable Data {"
1977 " int num;"
1978 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
1979 "}");
1980 io_delegate_.SetFileContents("new/p/Enum.aidl",
1981 "package p;"
1982 "enum Enum {"
1983 " FOO = 0,"
1984 " BAR = 1,"
1985 "}");
1986 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1987}
1988
Daniel Norman85aed542019-08-21 12:01:14 -07001989class AidlTestIncompatibleChanges : public AidlTest {
1990 protected:
1991 Options options_ = Options::From("aidl --checkapi old new");
1992};
1993
1994TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001995 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001996 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1997 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001998 "interface IFoo {"
1999 " void foo(in String[] str);"
2000 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002001 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002002 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002003 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002005}
2006
2007TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002008 const string expected_stderr =
2009 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002010 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2011 "package p;"
2012 "interface IFoo {"
2013 " void foo(in String[] str);"
2014 " void bar(@utf8InCpp String str);"
2015 "}");
2016 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2017 "package p;"
2018 "interface IFoo {"
2019 " void foo(in String[] str);"
2020 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002021 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002022 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002023 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002024}
2025
Jiyong Parkf8d53612020-05-04 14:06:13 +09002026TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2027 const string expected_stderr =
2028 "ERROR: new/p/IFoo.aidl:1.61-65: "
2029 "Encountered an untyped List or Map. The use of untyped List/Map is "
2030 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2031 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2032 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2033 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2034 "package p;"
2035 "interface IFoo {"
2036 " void foo(in String[] str);"
2037 "}");
2038 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2039 "package p;"
2040 "interface IFoo {"
2041 " void foo(in String[] str);"
2042 " void bar(in List arg);"
2043 "}");
2044 CaptureStderr();
2045 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2046 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2047}
2048
2049TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2050 const string expected_stderr =
2051 "ERROR: new/p/Data.aidl:1.54-59: "
2052 "Encountered an untyped List or Map. The use of untyped List/Map is "
2053 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2054 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2055 "ERROR: new/p/Data.aidl: Failed to read.\n";
2056 io_delegate_.SetFileContents("old/p/Data.aidl",
2057 "package p;"
2058 "parcelable Data {"
2059 " int foo;"
2060 "}");
2061 io_delegate_.SetFileContents("new/p/Data.aidl",
2062 "package p;"
2063 "parcelable Data {"
2064 " int foo;"
2065 " @nullable List list;"
2066 "}");
2067 CaptureStderr();
2068 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2069 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2070}
2071
Daniel Norman85aed542019-08-21 12:01:14 -07002072TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002073 const string expected_stderr =
2074 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002075 io_delegate_.SetFileContents("old/p/Data.aidl",
2076 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002077 "parcelable Data {"
2078 " int foo;"
2079 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002080 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002081 io_delegate_.SetFileContents("new/p/Data.aidl",
2082 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002083 "parcelable Data {"
2084 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002085 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002086 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002087 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002088 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002089}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002090
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002091TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2092 const string expected_stderr =
2093 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2094 "backends. Please either provide a default value for this field or mark the field as "
2095 "@nullable. This value or a null value will be used automatically when an old version of "
2096 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2097 "order to make sure your code continues to be backwards compatible, make sure the default or "
2098 "null value does not cause a semantic change to this parcelable.\n";
2099 io_delegate_.SetFileContents("old/p/Data.aidl",
2100 "package p;"
2101 "parcelable Data {"
2102 " int num;"
2103 "}");
2104 io_delegate_.SetFileContents("new/p/Data.aidl",
2105 "package p;"
2106 "parcelable Data {"
2107 " int num;"
2108 " String str;"
2109 "}");
2110 CaptureStderr();
2111 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2112 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2113}
2114
Jooyung Han636fd2f2020-10-22 11:33:45 +09002115TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2116 const string expected_stderr =
2117 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2118 "Please make sure 'Enum' has '0' as a valid value.\n";
2119 io_delegate_.SetFileContents("old/p/Data.aidl",
2120 "package p;"
2121 "parcelable Data {"
2122 " int num;"
2123 "}");
2124 io_delegate_.SetFileContents("new/p/Data.aidl",
2125 "package p;"
2126 "parcelable Data {"
2127 " int num;"
2128 " p.Enum e;"
2129 "}");
2130 io_delegate_.SetFileContents("new/p/Enum.aidl",
2131 "package p;"
2132 "enum Enum {"
2133 " FOO = 1,"
2134 " BAR = 2,"
2135 "}");
2136 CaptureStderr();
2137 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2138 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2139}
2140
Daniel Norman85aed542019-08-21 12:01:14 -07002141TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002142 const string expected_stderr =
2143 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002144 io_delegate_.SetFileContents("old/p/Enum.aidl",
2145 "package p;"
2146 "enum Enum {"
2147 " FOO = 1,"
2148 " BAR = 2,"
2149 "}");
2150 io_delegate_.SetFileContents("new/p/Enum.aidl",
2151 "package p;"
2152 "enum Enum {"
2153 " BAR = 2,"
2154 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002155 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002156 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002157 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002158}
2159
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002160TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2161 const string expected_stderr =
2162 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2163 io_delegate_.SetFileContents("old/p/Union.aidl",
2164 "package p;"
2165 "union Union {"
2166 " String str;"
2167 " int num;"
2168 "}");
2169 io_delegate_.SetFileContents("new/p/Union.aidl",
2170 "package p;"
2171 "union Union {"
2172 " String str;"
2173 "}");
2174 CaptureStderr();
2175 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2176 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2177}
2178
Daniel Norman85aed542019-08-21 12:01:14 -07002179TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002180 const string expected_stderr =
2181 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002182 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2183 "package p;"
2184 "interface IFoo {"
2185 " void foo(in String[] str);"
2186 " void bar(@utf8InCpp String str);"
2187 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002188 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2189 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002190 "interface IFoo {"
2191 " void foo(in String[] str);"
2192 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002193 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002194 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002195 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002196 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002197}
2198
Daniel Norman85aed542019-08-21 12:01:14 -07002199TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002200 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002201 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2202 "package p;"
2203 "interface IFoo {"
2204 " void foo(in String[] str);"
2205 " void bar(@utf8InCpp String str);"
2206 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002207 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2208 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002209 "interface IFoo2 {"
2210 " void foo(in String[] str);"
2211 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002212 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002213 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002214 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002215 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002216}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002217
Daniel Norman85aed542019-08-21 12:01:14 -07002218TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002219 const string expected_stderr =
2220 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002221 io_delegate_.SetFileContents("old/p/Enum.aidl",
2222 "package p;"
2223 "enum Enum {"
2224 " FOO = 1,"
2225 " BAR = 2,"
2226 "}");
2227 io_delegate_.SetFileContents("new/p/Enum.aidl",
2228 "package p;"
2229 "enum Enum {"
2230 " FOO = 3,"
2231 " BAR = 2,"
2232 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002233 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002234 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002235 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002236}
2237
2238TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002239 const string expected_stderr =
2240 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2241 "from 0 to 1.\n"
2242 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2243 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002244 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2245 "package p;"
2246 "interface IFoo {"
2247 " void foo(in String[] str);"
2248 " void bar(@utf8InCpp String str);"
2249 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002250 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2251 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002252 "interface IFoo {"
2253 " void bar(@utf8InCpp String str);"
2254 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002255 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002256 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002257 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002258 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002259}
2260
2261TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002262 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002263 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2264 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002265 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002266 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002267 "parcelable Data {"
2268 " int foo;"
2269 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002270 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002271 io_delegate_.SetFileContents("new/p/Data.aidl",
2272 "package p;"
2273 "parcelable Data {"
2274 " int bar;"
2275 " int foo;"
2276 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002277 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002278 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002279 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002280}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002281
Daniel Norman85aed542019-08-21 12:01:14 -07002282TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002283 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002284 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002285 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002286 "interface IFoo {"
2287 " void foo(in String[] str);"
2288 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002289 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002290 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2291 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002292 "interface IFoo {"
2293 " void foo(out String[] str);"
2294 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002295 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002296 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002297 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002298 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002299}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002300
Daniel Norman85aed542019-08-21 12:01:14 -07002301TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002302 const string expected_stderr =
2303 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002304 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2305 "package p;"
2306 "interface IFoo {"
2307 " void foo(in String[] str);"
2308 " void bar(@utf8InCpp String str);"
2309 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002310 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2311 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002312 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002313 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002314 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002315 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002316 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002317 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002318 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002319}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002320
Daniel Norman85aed542019-08-21 12:01:14 -07002321TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002322 const string expected_stderr =
2323 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002324 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2325 "package p;"
2326 "interface IFoo {"
2327 " void foo(in String[] str);"
2328 " void bar(@utf8InCpp String str);"
2329 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002330 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2331 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002332 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002333 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002334 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002335 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002336 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002337 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002338 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002339}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002340
Jooyung Han60b2fde2020-10-29 15:12:40 +09002341TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2342 const string expected_stderr =
2343 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2344 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2345 io_delegate_.SetFileContents("old/p/Foo.aidl",
2346 "package p;"
2347 "@Backing(type=\"byte\")"
2348 "enum Foo {"
2349 " FOO, BAR,"
2350 "}");
2351 io_delegate_.SetFileContents("new/p/Foo.aidl",
2352 "package p;"
2353 "@Backing(type=\"long\")"
2354 "enum Foo {"
2355 " FOO, BAR,"
2356 "}");
2357 CaptureStderr();
2358 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2359 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2360}
2361
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002362TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2363 const string expected_stderr =
2364 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2365 "to @JavaPassthrough(annotation=\"Bob\")\n";
2366 io_delegate_.SetFileContents("old/p/Foo.aidl",
2367 "package p;"
2368 "@JavaPassthrough(annotation=\"Alice\")"
2369 "parcelable Foo {}");
2370 io_delegate_.SetFileContents("new/p/Foo.aidl",
2371 "package p;"
2372 "@JavaPassthrough(annotation=\"Bob\")"
2373 "parcelable Foo {}");
2374
2375 CaptureStderr();
2376 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2378}
2379
Devin Mooredb7ac512020-08-07 11:17:36 -07002380TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2381 const string expected_stderr =
2382 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2383 io_delegate_.SetFileContents("old/p/Foo.aidl",
2384 "package p;"
2385 "parcelable Foo {"
2386 " int A;"
2387 "}");
2388 io_delegate_.SetFileContents("new/p/Foo.aidl",
2389 "package p;"
2390 "@JavaOnlyStableParcelable parcelable Foo {"
2391 " int A;"
2392 "}");
2393 CaptureStderr();
2394 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2395 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2396}
2397
2398TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2399 const string expected_stderr =
2400 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2401 io_delegate_.SetFileContents("old/p/Foo.aidl",
2402 "package p;"
2403 "@JavaOnlyStableParcelable parcelable Foo {"
2404 " int A;"
2405 "}");
2406 io_delegate_.SetFileContents("new/p/Foo.aidl",
2407 "package p;"
2408 "parcelable Foo {"
2409 " int A;"
2410 "}");
2411 CaptureStderr();
2412 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2413 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2414}
2415
Daniel Norman85aed542019-08-21 12:01:14 -07002416TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002417 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002418 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2419 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002420 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002421 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002422 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002423 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002424}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002425
Daniel Norman85aed542019-08-21 12:01:14 -07002426TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002427 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002428 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2429 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002430 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002431 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002432 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002433}
Jiyong Parka428d212018-08-29 22:26:30 +09002434
Daniel Norman85aed542019-08-21 12:01:14 -07002435TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002436 const string expected_stderr =
2437 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002438 io_delegate_.SetFileContents("old/p/I.aidl",
2439 "package p; interface I {"
2440 "const int A = 1; const int B = 2;}");
2441 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002442 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002443 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002444 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002445}
Jiyong Parka428d212018-08-29 22:26:30 +09002446
Daniel Norman85aed542019-08-21 12:01:14 -07002447TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002448 const string expected_stderr =
2449 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002450 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2451 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002452 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002453 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002454 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002455}
2456
Devin Moorec7e47a32020-08-07 10:55:25 -07002457TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2458 const string expected_stderr =
2459 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2460 "This is an incompatible change for FixedSize types.\n";
2461 io_delegate_.SetFileContents("old/p/Foo.aidl",
2462 "package p; @FixedSize parcelable Foo { int A = 1; }");
2463 io_delegate_.SetFileContents("new/p/Foo.aidl",
2464 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2465 CaptureStderr();
2466 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2468}
2469
2470TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2471 const string expected_stderr =
2472 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2473 io_delegate_.SetFileContents("old/p/Foo.aidl",
2474 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2475 io_delegate_.SetFileContents("new/p/Foo.aidl",
2476 "package p; @FixedSize parcelable Foo { int A = 1; }");
2477 CaptureStderr();
2478 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2479 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2480}
2481
2482TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2483 const string expected_stderr =
2484 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2485 "a.\n"
2486 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2487 "b.\n"
2488 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2489 "c.\n"
2490 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2491 "d.\n"
2492 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2493 "e.\n"
2494 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2495 "f.\n";
2496
2497 io_delegate_.SetFileContents("Foo.aidl",
2498 "@FixedSize parcelable Foo { "
2499 " int[] a;"
2500 " Bar b;"
2501 " String c;"
2502 " ParcelFileDescriptor d;"
2503 " IBinder e;"
2504 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002505 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002506 "}");
2507 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2508 Options options =
2509 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2510
2511 CaptureStderr();
2512 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2513 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2514}
2515
2516TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2517 const string expected_stderr = "";
2518
2519 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2520 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2521 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2522 Options options =
2523 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2524
2525 CaptureStderr();
2526 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2527 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2528}
2529
Jiyong Park8c380532018-08-30 14:55:26 +09002530TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002531 const string expected_stderr =
2532 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2533 "dir1/q/IBar.aidl\n"
2534 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002535 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002536 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2537 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2538 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2539 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2540
Devin Moore097a3ab2020-03-11 16:08:44 -07002541 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002542 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002543 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002544}
2545
Jiyong Parked65bf42018-08-28 15:43:27 +09002546TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002547 const string expected_stderr =
2548 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2549 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002550 Options options = Options::From("aidl --checkapi old new");
2551 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2552 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002553
2554 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2555
Jiyong Parke59c3682018-09-11 23:10:25 +09002556 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002557 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002558 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002559 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002560}
2561
Jiyong Parke05195e2018-10-08 18:24:23 +09002562TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2563 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2564 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002565 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002566
2567 // use without import
2568 io_delegate_.SetFileContents("p/IFoo.aidl",
2569 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2570 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2571 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002572 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002573
Devin Moore7b8d5c92020-03-17 14:14:08 -07002574 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002575 io_delegate_.SetFileContents(
2576 "p/IFoo.aidl",
2577 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2578 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2579 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002580 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002581
2582 // use with import (as before)
2583 io_delegate_.SetFileContents("p/IFoo.aidl",
2584 "package p;"
2585 "import android.os.ParcelFileDescriptor;"
2586 "interface IFoo{"
2587 " void foo(in ParcelFileDescriptor fd);"
2588 "}");
2589 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2590 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002591 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002592}
Jiyong Parked65bf42018-08-28 15:43:27 +09002593
Jiyong Park3633b722019-04-11 15:38:26 +09002594TEST_F(AidlTest, ManualIds) {
2595 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2596 io_delegate_.SetFileContents("IFoo.aidl",
2597 "interface IFoo {\n"
2598 " void foo() = 0;\n"
2599 " void bar() = 1;\n"
2600 "}");
2601 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2602}
2603
2604TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2605 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2606 io_delegate_.SetFileContents("IFoo.aidl",
2607 "interface IFoo {\n"
2608 " void foo() = 0;\n"
2609 " void bar() = 1;\n"
2610 "}");
2611 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2612}
2613
2614TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002615 const string expected_stderr =
2616 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002617 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2618 io_delegate_.SetFileContents("IFoo.aidl",
2619 "interface IFoo {\n"
2620 " void foo() = 3;\n"
2621 " void bar() = 3;\n"
2622 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002623 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002624 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002625 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002626}
2627
2628TEST_F(AidlTest, FailOnOutOfRangeIds) {
2629 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002630 const string expected_stderr =
2631 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2632 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002633 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2634 io_delegate_.SetFileContents("IFoo.aidl",
2635 "interface IFoo {\n"
2636 " void foo() = 3;\n"
2637 " void bar() = 16777115;\n"
2638 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002639 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002640 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002641 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002642}
2643
2644TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002645 const string expected_stderr =
2646 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002647 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2648 io_delegate_.SetFileContents("IFoo.aidl",
2649 "interface IFoo {\n"
2650 " void foo() = 3;\n"
2651 " void bar();\n"
2652 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002653 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002654 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002655 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002656}
2657
Jiyong Parkc6816252019-07-08 08:12:28 +09002658TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2659 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2660 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2661 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2662 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2663}
2664
2665TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002666 const string expected_stderr =
2667 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2668 "dir/IBar.aidl\n"
2669 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002670 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002671
Jiyong Parkc6816252019-07-08 08:12:28 +09002672 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2673 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2674 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2675 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002676 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002677 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002678 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002679}
2680
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002681TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2682 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2683 "package a.b;\n"
2684 "import a.b.IBar;\n"
2685 "import a.b.IQux;\n"
2686 "interface IFoo { IQux foo(); }\n");
2687 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2688 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2689
2690 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2691 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2692
2693 string output;
2694 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2695 // IBar was imported but wasn't used. include is not expected.
2696 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2697 // IBar was imported and used. include is expected.
2698 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2699}
2700
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002701TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002702 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002703 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002704 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2705 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002706 interface IFoo {
2707 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002708 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002709 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002710 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002711 // JavaPassthrough should work with other types as well (e.g. enum)
2712 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2713 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2714 @JavaPassthrough(annotation="@com.android.AliceTwo")
2715 @Backing(type="byte")
2716 enum MyEnum {
2717 a, b, c
2718 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002719
Jooyung Han4cde01d2020-10-13 11:10:47 +09002720 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002721 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2722
2723 string java_out;
2724 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002725 // type-decl-level annotations with newline at the end
2726 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2727 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2728 // member-decl-level annotations with newline at the end
2729 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2730 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2731 // inline annotations with space at the end
2732 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002733
Jooyung Han4cde01d2020-10-13 11:10:47 +09002734 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2735 // type-decl-level annotations with newline at the end
2736 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2737 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2738
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002739 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002740 Options cpp_options =
2741 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002742 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2743
Jooyung Han4cde01d2020-10-13 11:10:47 +09002744 Options ndk_options =
2745 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002746 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002747
Jooyung Han4cde01d2020-10-13 11:10:47 +09002748 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002749 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002750}
2751
Andrei Homescue61feb52020-08-18 15:44:24 -07002752TEST_F(AidlTest, ParseRustDerive) {
2753 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2754 @RustDerive(Clone=true, Copy=false)
2755 parcelable Foo {
2756 int a;
2757 })");
2758
2759 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2760 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2761
2762 string rust_out;
2763 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2764 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2765
2766 // Other backends shouldn't be bothered
2767 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2768 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2769
2770 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2771 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2772
2773 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2774 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2775}
2776
Jiyong Park56f73d72019-06-11 12:20:28 +09002777class AidlOutputPathTest : public AidlTest {
2778 protected:
2779 void SetUp() override {
2780 AidlTest::SetUp();
2781 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2782 }
2783
2784 void Test(const Options& options, const std::string expected_output_path) {
2785 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2786 // check the existence
2787 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2788 }
2789};
2790
2791TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2792 // <out_dir> / <package_name> / <type_name>.java
2793 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2794}
2795
2796TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2797 // when output file is explicitly set, it is always respected. -o option is
2798 // ignored.
2799 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2800}
2801
2802TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2803 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2804}
2805
2806TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2807 // output is the same as the input file except for the suffix
2808 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2809}
2810
Devin Moore7b8d5c92020-03-17 14:14:08 -07002811TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002812 AidlError error;
2813 const string expected_stderr =
2814 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2815 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002816 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2817 R"(package p;
2818 interface IFoo {
2819 const int int32_max_oob = 2147483650;
2820 }
2821 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002822 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002823 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2824 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002825}
2826
Devin Moore7b8d5c92020-03-17 14:14:08 -07002827TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002828 AidlError error;
2829 const string expected_stderr =
2830 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2831 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002832 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2833 R"(package p;
2834 interface IFoo {
2835 const int int32_min_oob = -2147483650;
2836 }
2837 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002838 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002839 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2840 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002841}
2842
Devin Moore7b8d5c92020-03-17 14:14:08 -07002843TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002844 AidlError error;
2845 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002846 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002847 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002848 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2849 R"(package p;
2850 interface IFoo {
2851 const long int64_max_oob = 21474836509999999999999999;
2852 }
2853 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002854 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002855 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2856 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002857}
2858
Devin Moore7b8d5c92020-03-17 14:14:08 -07002859TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002860 AidlError error;
2861 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002862 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002863 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002864 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2865 R"(package p;
2866 interface IFoo {
2867 const long int64_min_oob = -21474836509999999999999999;
2868 }
2869 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002870 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002871 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2872 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002873}
2874
Devin Moore7b8d5c92020-03-17 14:14:08 -07002875TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002876 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002877 const string expected_stderr =
2878 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2879 "literal: byte\n"
2880 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2881 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002882 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2883 R"(package p;
2884 @Backing(type="byte")
2885 enum TestEnum {
2886 FOO = 127,
2887 BAR,
2888 }
2889 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002890 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002891 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002892 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002893}
2894
Devin Mooredecaf292020-04-30 09:16:40 -07002895TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2896 AidlError error;
2897 const string expected_stderr =
2898 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2899 "be one of: type\n"
2900 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2901 "be one of: type\n";
2902 CaptureStderr();
2903 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2904 R"(package p;
2905 @Backing(foo="byte")
2906 enum TestEnum {
2907 FOO = 1,
2908 BAR,
2909 }
2910 )",
2911 typenames_, GetLanguage(), &error));
2912 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2913 EXPECT_EQ(AidlError::BAD_TYPE, error);
2914}
2915
Jooyung Han66813932020-10-23 13:24:44 +09002916TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002917 io_delegate_.SetFileContents("Foo.aidl",
2918 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2919 "Map<String, Baz> d; Bar[] e; }");
2920 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2921 io_delegate_.SetFileContents("Baz.aidl",
2922 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002923 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2924 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2925}
2926
Jooyung Han66813932020-10-23 13:24:44 +09002927TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002928 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002929 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09002930 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09002931 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
2932 "named 'bar'.\n";
2933 CaptureStderr();
2934 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2935 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2936 EXPECT_EQ(expected_error, GetCapturedStderr());
2937}
2938
2939TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
2940 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
2941 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2942 string expected_error =
2943 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09002944 "named 'bar'.\n";
2945 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002946 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2947 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09002948 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002949}
2950
Jooyung Han66813932020-10-23 13:24:44 +09002951TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002952 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002953 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
2954 string expected_error =
2955 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
2956 "only be an in parameter.\n";
2957 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002958 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2959 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002960 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002961}
2962
Jooyung Han66813932020-10-23 13:24:44 +09002963TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002964 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09002965 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
2966 string expected_error =
2967 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
2968 "only be an in parameter.\n";
2969 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09002970 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2971 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09002972 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09002973}
2974
Jooyung Han66813932020-10-23 13:24:44 +09002975TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002976 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002977 Options options = Options::From("aidl --lang=java Foo.aidl");
2978 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09002979 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
2980 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09002981 CaptureStderr();
2982 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2983 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2984}
Devin Moore53fc99c2020-08-12 08:07:52 -07002985
Jooyung Han1f14ab32020-10-14 13:48:29 +09002986const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
2987
2988#include <a/ByteEnum.h>
2989#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09002990#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002991#include <binder/Status.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09002992#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002993#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09002994#include <locale>
2995#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09002996#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09002997#include <utility>
2998#include <variant>
2999#include <vector>
3000
3001namespace a {
3002
3003class Foo : public ::android::Parcelable {
3004public:
Jooyung Han97945de2020-10-15 16:41:38 +09003005 inline bool operator!=(const Foo& rhs) const {
3006 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003007 }
Jooyung Han97945de2020-10-15 16:41:38 +09003008 inline bool operator<(const Foo& rhs) const {
3009 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003010 }
Jooyung Han97945de2020-10-15 16:41:38 +09003011 inline bool operator<=(const Foo& rhs) const {
3012 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003013 }
Jooyung Han97945de2020-10-15 16:41:38 +09003014 inline bool operator==(const Foo& rhs) const {
3015 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003016 }
Jooyung Han97945de2020-10-15 16:41:38 +09003017 inline bool operator>(const Foo& rhs) const {
3018 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003019 }
Jooyung Han97945de2020-10-15 16:41:38 +09003020 inline bool operator>=(const Foo& rhs) const {
3021 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003022 }
Jooyung Han97945de2020-10-15 16:41:38 +09003023
Jooyung Han1f14ab32020-10-14 13:48:29 +09003024 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003025 ns = 0, // int[] ns;
3026 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003027 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003028 };
Jooyung Han97945de2020-10-15 16:41:38 +09003029
Jooyung Han1f14ab32020-10-14 13:48:29 +09003030 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003031 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003032
3033 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003034 Foo(const Foo&) = default;
3035 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003036 Foo& operator=(const Foo&) = default;
3037 Foo& operator=(Foo&&) = default;
3038
Jooyung Han97945de2020-10-15 16:41:38 +09003039 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
3040 constexpr Foo(_Tp&& _arg)
3041 : _value(std::forward<_Tp>(_arg)) {}
3042
3043 template <typename... _Tp>
3044 constexpr explicit Foo(_Tp&&... _args)
3045 : _value(std::forward<_Tp>(_args)...) {}
3046
3047 template <Tag _tag, typename... _Tp>
3048 static Foo make(_Tp&&... _args) {
3049 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003050 }
Jooyung Han97945de2020-10-15 16:41:38 +09003051
3052 template <Tag _tag, typename _Tp, typename... _Up>
3053 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3054 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003055 }
3056
3057 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003058 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003059 }
3060
Jooyung Han97945de2020-10-15 16:41:38 +09003061 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003062 const auto& get() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003063 if (getTag() != _tag) { abort(); }
3064 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003065 }
3066
Jooyung Han97945de2020-10-15 16:41:38 +09003067 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003068 auto& get() {
Jooyung Han97945de2020-10-15 16:41:38 +09003069 if (getTag() != _tag) { abort(); }
3070 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003071 }
3072
Jooyung Han97945de2020-10-15 16:41:38 +09003073 template <Tag _tag, typename... _Tp>
3074 void set(_Tp&&... _args) {
3075 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003076 }
3077
3078 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3079 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3080 static const std::string& getParcelableDescriptor() {
3081 static const std::string DESCIPTOR = "a.Foo";
3082 return DESCIPTOR;
3083 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003084 template <typename _T> class _has_toString {
3085 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3086 template <typename _U> static std::false_type __has_toString(...);
3087 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3088 };
3089 template <typename _T> inline static std::string _call_toString(const _T& t) {
3090 if constexpr (_has_toString<_T>::value) return t.toString();
3091 return "{no toString() implemented}";
3092 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003093 inline std::string toString() const {
3094 std::ostringstream os;
3095 os << "Foo{";
3096 switch (getTag()) {
3097 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3098 case e: os << "e: " << a::toString(get<e>()); break;
3099 case pfd: os << "pfd: " << ""; break;
3100 }
3101 os << "}";
3102 return os.str();
3103 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003104private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003105 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003106}; // class Foo
3107
3108} // namespace a
3109)";
3110
3111const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3112
3113namespace a {
3114
3115::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3116 ::android::status_t _aidl_ret_status;
3117 int32_t _aidl_tag;
3118 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3119 switch (_aidl_tag) {
3120 case ns: {
3121 ::std::vector<int32_t> _aidl_value;
3122 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
3123 set<ns>(std::move(_aidl_value));
3124 return ::android::OK; }
3125 case e: {
3126 ::a::ByteEnum _aidl_value;
3127 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
3128 set<e>(std::move(_aidl_value));
3129 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003130 case pfd: {
3131 ::android::os::ParcelFileDescriptor _aidl_value;
3132 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
3133 set<pfd>(std::move(_aidl_value));
3134 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003135 }
3136 return ::android::BAD_VALUE;
3137}
3138
3139::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3140 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3141 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3142 switch (getTag()) {
3143 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3144 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003145 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003146 }
3147 abort();
3148}
3149
3150} // namespace a
3151)";
3152
Jooyung Han6beac042020-10-17 21:59:43 +09003153const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3154#include <android/binder_interface_utils.h>
3155#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003156#include <codecvt>
3157#include <locale>
3158#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003159
3160#include <type_traits>
3161#include <utility>
3162#include <variant>
3163#include <cstdint>
3164#include <memory>
3165#include <optional>
3166#include <string>
3167#include <vector>
3168#ifdef BINDER_STABILITY_SUPPORT
3169#include <android/binder_stability.h>
3170#endif // BINDER_STABILITY_SUPPORT
3171#include <aidl/a/ByteEnum.h>
3172namespace aidl {
3173namespace a {
3174class Foo {
3175public:
3176 typedef std::false_type fixed_size;
3177 static const char* descriptor;
3178
3179 enum Tag : int32_t {
3180 ns = 0, // int[] ns;
3181 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003182 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003183 };
3184
3185 template<typename _Tp>
3186 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3187
3188 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3189 Foo(const Foo&) = default;
3190 Foo(Foo&&) = default;
3191 Foo& operator=(const Foo&) = default;
3192 Foo& operator=(Foo&&) = default;
3193
3194 template <typename _Tp, std::enable_if_t<_not_self<_Tp>, int> = 0>
3195 constexpr Foo(_Tp&& _arg)
3196 : _value(std::forward<_Tp>(_arg)) {}
3197
3198 template <typename... _Tp>
3199 constexpr explicit Foo(_Tp&&... _args)
3200 : _value(std::forward<_Tp>(_args)...) {}
3201
3202 template <Tag _tag, typename... _Tp>
3203 static Foo make(_Tp&&... _args) {
3204 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3205 }
3206
3207 template <Tag _tag, typename _Tp, typename... _Up>
3208 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3209 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3210 }
3211
3212 Tag getTag() const {
3213 return static_cast<Tag>(_value.index());
3214 }
3215
3216 template <Tag _tag>
3217 const auto& get() const {
3218 if (getTag() != _tag) { abort(); }
3219 return std::get<_tag>(_value);
3220 }
3221
3222 template <Tag _tag>
3223 auto& get() {
3224 if (getTag() != _tag) { abort(); }
3225 return std::get<_tag>(_value);
3226 }
3227
3228 template <Tag _tag, typename... _Tp>
3229 void set(_Tp&&... _args) {
3230 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3231 }
3232
3233 binder_status_t readFromParcel(const AParcel* _parcel);
3234 binder_status_t writeToParcel(AParcel* _parcel) const;
3235 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003236 template <typename _T> class _has_toString {
3237 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3238 template <typename _U> static std::false_type __has_toString(...);
3239 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3240 };
3241 template <typename _T> inline static std::string _call_toString(const _T& t) {
3242 if constexpr (_has_toString<_T>::value) return t.toString();
3243 return "{no toString() implemented}";
3244 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003245 inline std::string toString() const {
3246 std::ostringstream os;
3247 os << "Foo{";
3248 switch (getTag()) {
3249 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3250 case e: os << "e: " << a::toString(get<e>()); break;
3251 case pfd: os << "pfd: " << ""; break;
3252 }
3253 os << "}";
3254 return os.str();
3255 }
Jooyung Han6beac042020-10-17 21:59:43 +09003256private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003257 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003258};
3259} // namespace a
3260} // namespace aidl
3261)";
3262
3263const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3264
3265#include <android/binder_parcel_utils.h>
3266
3267namespace aidl {
3268namespace a {
3269const char* Foo::descriptor = "a.Foo";
3270
3271binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3272 binder_status_t _aidl_ret_status;
3273 int32_t _aidl_tag;
3274 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3275 switch (_aidl_tag) {
3276 case ns: {
3277 std::vector<int32_t> _aidl_value;
3278 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3279 set<ns>(std::move(_aidl_value));
3280 return STATUS_OK; }
3281 case e: {
3282 ::aidl::a::ByteEnum _aidl_value;
3283 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
3284 set<e>(std::move(_aidl_value));
3285 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003286 case pfd: {
3287 ::ndk::ScopedFileDescriptor _aidl_value;
3288 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
3289 set<pfd>(std::move(_aidl_value));
3290 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003291 }
3292 return STATUS_BAD_VALUE;
3293}
3294binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3295 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3296 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3297 switch (getTag()) {
3298 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3299 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003300 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003301 }
3302 abort();
3303}
3304
3305} // namespace a
3306} // namespace aidl
3307)";
3308
Jooyung Han1f14ab32020-10-14 13:48:29 +09003309const char kUnionExampleExpectedOutputJava[] = R"(/*
3310 * This file is auto-generated. DO NOT MODIFY.
3311 */
3312package a;
3313
3314
3315public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003316 // tags for union fields
3317 public final static int ns = 0; // int[] ns;
3318 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003319 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003320
3321 private int _tag;
3322 private Object _value;
3323
3324 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003325 int[] _value = {42};
3326 this._tag = ns;
3327 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003328 }
Jooyung Han97945de2020-10-15 16:41:38 +09003329
Jooyung Han1f14ab32020-10-14 13:48:29 +09003330 private Foo(android.os.Parcel _aidl_parcel) {
3331 readFromParcel(_aidl_parcel);
3332 }
Jooyung Han97945de2020-10-15 16:41:38 +09003333
Jooyung Hance62f932020-10-25 10:21:49 +09003334 private Foo(int _tag, Object _value) {
3335 this._tag = _tag;
3336 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003337 }
3338
3339 public int getTag() {
3340 return _tag;
3341 }
3342
Jooyung Han97945de2020-10-15 16:41:38 +09003343 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003344
3345 public static Foo ns(int[] _value) {
3346 return new Foo(ns, _value);
3347 }
Jooyung Han97945de2020-10-15 16:41:38 +09003348
Jooyung Han1f14ab32020-10-14 13:48:29 +09003349 public int[] getNs() {
3350 _assertTag(ns);
3351 return (int[]) _value;
3352 }
Jooyung Han97945de2020-10-15 16:41:38 +09003353
Jooyung Han1f14ab32020-10-14 13:48:29 +09003354 public void setNs(int[] _value) {
3355 _set(ns, _value);
3356 }
3357
Jooyung Han97945de2020-10-15 16:41:38 +09003358 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003359
3360 public static Foo e(byte _value) {
3361 return new Foo(e, _value);
3362 }
Jooyung Han97945de2020-10-15 16:41:38 +09003363
Jooyung Han1f14ab32020-10-14 13:48:29 +09003364 public byte getE() {
3365 _assertTag(e);
3366 return (byte) _value;
3367 }
Jooyung Han97945de2020-10-15 16:41:38 +09003368
Jooyung Han1f14ab32020-10-14 13:48:29 +09003369 public void setE(byte _value) {
3370 _set(e, _value);
3371 }
3372
Jooyung Hand2fa0232020-10-19 02:51:41 +09003373 // ParcelFileDescriptor pfd;
3374
3375 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3376 return new Foo(pfd, _value);
3377 }
3378
3379 public android.os.ParcelFileDescriptor getPfd() {
3380 _assertTag(pfd);
3381 return (android.os.ParcelFileDescriptor) _value;
3382 }
3383
3384 public void setPfd(android.os.ParcelFileDescriptor _value) {
3385 _set(pfd, _value);
3386 }
3387
Jooyung Han1f14ab32020-10-14 13:48:29 +09003388 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3389 @Override
3390 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003391 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003392 }
3393 @Override
3394 public Foo[] newArray(int _aidl_size) {
3395 return new Foo[_aidl_size];
3396 }
3397 };
Jooyung Han97945de2020-10-15 16:41:38 +09003398
Jooyung Han1f14ab32020-10-14 13:48:29 +09003399 @Override
3400 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3401 _aidl_parcel.writeInt(_tag);
3402 switch (_tag) {
3403 case ns:
3404 _aidl_parcel.writeIntArray(getNs());
3405 break;
3406 case e:
3407 _aidl_parcel.writeByte(getE());
3408 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003409 case pfd:
3410 if ((getPfd()!=null)) {
3411 _aidl_parcel.writeInt(1);
3412 getPfd().writeToParcel(_aidl_parcel, 0);
3413 }
3414 else {
3415 _aidl_parcel.writeInt(0);
3416 }
3417 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003418 }
3419 }
Jooyung Han97945de2020-10-15 16:41:38 +09003420
Jooyung Han1f14ab32020-10-14 13:48:29 +09003421 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3422 int _aidl_tag;
3423 _aidl_tag = _aidl_parcel.readInt();
3424 switch (_aidl_tag) {
3425 case ns: {
3426 int[] _aidl_value;
3427 _aidl_value = _aidl_parcel.createIntArray();
3428 _set(_aidl_tag, _aidl_value);
3429 return; }
3430 case e: {
3431 byte _aidl_value;
3432 _aidl_value = _aidl_parcel.readByte();
3433 _set(_aidl_tag, _aidl_value);
3434 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003435 case pfd: {
3436 android.os.ParcelFileDescriptor _aidl_value;
3437 if ((0!=_aidl_parcel.readInt())) {
3438 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3439 }
3440 else {
3441 _aidl_value = null;
3442 }
3443 _set(_aidl_tag, _aidl_value);
3444 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003445 }
3446 throw new RuntimeException("union: out of range: " + _aidl_tag);
3447 }
Jooyung Han97945de2020-10-15 16:41:38 +09003448
Jooyung Han1f14ab32020-10-14 13:48:29 +09003449 @Override
3450 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003451 int _mask = 0;
3452 switch (getTag()) {
3453 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003454 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003455 break;
3456 }
3457 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003458 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003459 private int describeContents(Object _v) {
3460 if (_v == null) return 0;
3461 if (_v instanceof android.os.Parcelable) {
3462 return ((android.os.Parcelable) _v).describeContents();
3463 }
3464 return 0;
3465 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003466
3467 private void _assertTag(int tag) {
3468 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003469 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003470 }
3471 }
Jooyung Han97945de2020-10-15 16:41:38 +09003472
Jooyung Han1f14ab32020-10-14 13:48:29 +09003473 private String _tagString(int _tag) {
3474 switch (_tag) {
3475 case ns: return "ns";
3476 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003477 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003478 }
3479 throw new IllegalStateException("unknown field: " + _tag);
3480 }
Jooyung Han97945de2020-10-15 16:41:38 +09003481
Jooyung Hance62f932020-10-25 10:21:49 +09003482 private void _set(int _tag, Object _value) {
3483 this._tag = _tag;
3484 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003485 }
3486}
3487)";
3488
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003489const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3490pub enum Foo {
3491 Ns(Vec<i32>),
3492 E(crate::mangled::_1_a_8_ByteEnum),
3493 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3494}
3495pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3496impl Default for Foo {
3497 fn default() -> Self {
3498 Self::Ns(vec!{42})
3499 }
3500}
3501impl binder::parcel::Serialize for Foo {
3502 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3503 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3504 }
3505}
3506impl binder::parcel::SerializeArray for Foo {}
3507impl binder::parcel::SerializeOption for Foo {
3508 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3509 let this = if let Some(this) = this {
3510 parcel.write(&1i32)?;
3511 this
3512 } else {
3513 return parcel.write(&0i32);
3514 };
3515 match this {
3516 Self::Ns(v) => {
3517 parcel.write(&0i32)?;
3518 parcel.write(v)
3519 }
3520 Self::E(v) => {
3521 parcel.write(&1i32)?;
3522 parcel.write(v)
3523 }
3524 Self::Pfd(v) => {
3525 parcel.write(&2i32)?;
3526 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3527 parcel.write(__field_ref)
3528 }
3529 }
3530 }
3531}
3532impl binder::parcel::Deserialize for Foo {
3533 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3534 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3535 .transpose()
3536 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3537 }
3538}
3539impl binder::parcel::DeserializeArray for Foo {}
3540impl binder::parcel::DeserializeOption for Foo {
3541 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3542 let status: i32 = parcel.read()?;
3543 if status == 0 { return Ok(None); }
3544 let tag: i32 = parcel.read()?;
3545 match tag {
3546 0 => {
3547 let value: Vec<i32> = parcel.read()?;
3548 Ok(Some(Self::Ns(value)))
3549 }
3550 1 => {
3551 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3552 Ok(Some(Self::E(value)))
3553 }
3554 2 => {
3555 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3556 Ok(Some(Self::Pfd(value)))
3557 }
3558 _ => {
3559 Err(binder::StatusCode::BAD_VALUE)
3560 }
3561 }
3562 }
3563}
3564)";
3565
Jooyung Han97945de2020-10-15 16:41:38 +09003566struct AidlUnionTest : ::testing::Test {
3567 void SetUp() override {
3568 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003569package a;
3570import a.ByteEnum;
3571union Foo {
3572 int[] ns = {42};
3573 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003574 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003575}
3576)");
Jooyung Han97945de2020-10-15 16:41:38 +09003577 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003578package a;
3579@Backing(type="byte")
3580enum ByteEnum {
3581 a, b, c
3582}
3583)");
Jooyung Han97945de2020-10-15 16:41:38 +09003584 }
3585 FakeIoDelegate io_delegate_;
3586 void Compile(string lang) {
3587 string command = "aidl --structured -I. -o out --lang=" + lang;
3588 if (lang == "cpp" || lang == "ndk") {
3589 command += " -h out";
3590 }
3591 command += " a/Foo.aidl";
3592 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003593 CaptureStderr();
3594 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3595 auto err = GetCapturedStderr();
3596 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003597 }
3598 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3599 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003600 string actual;
3601 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3602 EXPECT_EQ(expected, actual);
3603 }
Jooyung Han97945de2020-10-15 16:41:38 +09003604 }
3605};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003606
Jooyung Han97945de2020-10-15 16:41:38 +09003607TEST_F(AidlUnionTest, Example_Cpp) {
3608 Compile("cpp");
3609 EXPECT_COMPILE_OUTPUTS(
3610 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3611 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3612}
3613
Jooyung Han6beac042020-10-17 21:59:43 +09003614TEST_F(AidlUnionTest, Example_Ndk) {
3615 Compile("ndk");
3616 EXPECT_COMPILE_OUTPUTS(
3617 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3618 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3619}
3620
Jooyung Han97945de2020-10-15 16:41:38 +09003621TEST_F(AidlUnionTest, Example_Java) {
3622 Compile("java");
3623 EXPECT_COMPILE_OUTPUTS(
3624 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003625}
3626
3627TEST_F(AidlUnionTest, Example_Rust) {
3628 Compile("rust");
3629 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003630}
3631
Jooyung Hanfe89f122020-10-14 03:49:18 +09003632TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3633 const string method = "package a; union Foo {}";
3634 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3635 CaptureStderr();
3636 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3637 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3638}
3639
3640TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3641 const string method = "package a; union Foo { ParcelableHolder x; }";
3642 const string expected_stderr =
3643 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3644 CaptureStderr();
3645 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3646 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3647}
3648
Devin Moore53fc99c2020-08-12 08:07:52 -07003649TEST_P(AidlTest, GenericStructuredParcelable) {
3650 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3651 Options options =
3652 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3653 const string expected_stderr = "";
3654 CaptureStderr();
3655 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3656 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3657}
3658
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003659TEST_F(AidlTest, NestedTypeArgs) {
3660 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003661 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3662
3663 io_delegate_.SetFileContents("a/Foo.aidl",
3664 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3665 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003666 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3667 const string expected_stderr = "";
3668 CaptureStderr();
3669 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3670 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3671
3672 string code;
3673 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003674 EXPECT_THAT(code,
3675 testing::HasSubstr(
3676 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3677}
3678
3679TEST_F(AidlTest, DoubleArrayError) {
3680 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3681
3682 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3683 const string expected_stderr =
3684 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3685 CaptureStderr();
3686 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3687 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3688}
3689
3690TEST_F(AidlTest, DoubleGenericError) {
3691 io_delegate_.SetFileContents("a/Bar.aidl",
3692 "package a; parcelable Bar { List<String><String> a; }");
3693
3694 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3695 const string expected_stderr =
3696 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3697 CaptureStderr();
3698 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3699 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3700}
3701
3702TEST_F(AidlTest, ArrayBeforeGenericError) {
3703 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3704
3705 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3706 const string expected_stderr =
3707 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3708 CaptureStderr();
3709 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3710 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003711}
3712
Jooyung Han14004ed2020-10-16 03:49:57 +09003713struct GenericAidlTest : ::testing::Test {
3714 FakeIoDelegate io_delegate_;
3715 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003716 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003717 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3718 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3719 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3720
3721 Options options = Options::From(cmd);
3722 CaptureStderr();
3723 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3724 EXPECT_EQ("", GetCapturedStderr());
3725 }
3726};
3727
3728TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3729 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3730 string code;
3731 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3732 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3733 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3734 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3735}
3736
3737TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3738 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3739 string code;
3740 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3741 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3742 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3743 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3744}
3745
Devin Moore53fc99c2020-08-12 08:07:52 -07003746TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3747 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3748 Options options =
3749 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3750 const string expected_stderr =
3751 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3752 CaptureStderr();
3753 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3754 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3755}
3756
3757TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3758 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3759 Options options =
3760 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3761 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3762 CaptureStderr();
3763 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3764 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3765}
3766
Jooyung Han7a308842020-10-27 19:06:49 +09003767TEST_P(AidlTest, LongCommentWithinConstExpression) {
3768 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
3769 Options options =
3770 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3771 CaptureStderr();
3772 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3773 EXPECT_EQ("", GetCapturedStderr());
3774}
3775
Jeongik Chaef44e622020-10-23 16:00:52 +09003776TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3777 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3778 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3779 std::string expectedErr =
3780 "ERROR: a/Foo.aidl:1.28-30: "
3781 "Encountered an untyped List or Map. The use of untyped List/Map is "
3782 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3783 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3784 "ERROR: a/Foo.aidl:1.35-37: "
3785 "Encountered an untyped List or Map. The use of untyped List/Map is "
3786 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3787 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3788 CaptureStderr();
3789 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3790 EXPECT_EQ(expectedErr, GetCapturedStderr());
3791}
3792
3793TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003794 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3795 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003796 std::string expectedErr =
3797 "ERROR: a/Foo.aidl:1.33-35: "
3798 "Encountered an untyped List or Map. The use of untyped List/Map is "
3799 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3800 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3801 "ERROR: a/Foo.aidl:1.40-42: "
3802 "Encountered an untyped List or Map. The use of untyped List/Map is "
3803 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3804 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003805 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003806 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3807 EXPECT_EQ(expectedErr, GetCapturedStderr());
3808}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003809
Jeongik Chaef44e622020-10-23 16:00:52 +09003810TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3811 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3812 io_delegate_.SetFileContents(
3813 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3814 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3815 std::string expectedErr =
3816 "ERROR: a/Foo.aidl:1.52-54: "
3817 "Encountered an untyped List or Map. The use of untyped List/Map is "
3818 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3819 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3820 "ERROR: a/Foo.aidl:1.64-66: "
3821 "Encountered an untyped List or Map. The use of untyped List/Map is "
3822 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3823 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3824 CaptureStderr();
3825 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3826 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003827}
3828
Christopher Wiley90be4e32015-10-20 14:55:25 -07003829} // namespace aidl
3830} // namespace android