Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015, The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 17 | #include "aidl.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 18 | |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 19 | #include <android-base/stringprintf.h> |
Jiyong Park | f1f5c80 | 2020-05-19 17:33:00 +0900 | [diff] [blame] | 20 | #include <gmock/gmock.h> |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 21 | #include <gtest/gtest.h> |
| 22 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 23 | #include <map> |
| 24 | #include <memory> |
| 25 | #include <set> |
| 26 | #include <string> |
| 27 | #include <vector> |
| 28 | |
Steven Moreland | 4958524 | 2019-12-18 16:06:49 -0800 | [diff] [blame] | 29 | #include "aidl_checkapi.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 30 | #include "aidl_language.h" |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 31 | #include "aidl_to_cpp.h" |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 32 | #include "aidl_to_java.h" |
Jiyong Park | 2a7c92b | 2020-07-22 19:12:36 +0900 | [diff] [blame] | 33 | #include "logging.h" |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 34 | #include "options.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 35 | #include "tests/fake_io_delegate.h" |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 36 | |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 37 | using android::aidl::internals::parse_preprocessed_file; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 38 | using android::aidl::test::FakeIoDelegate; |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 39 | using android::base::StringPrintf; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 40 | using std::map; |
Christopher Wiley | 12e894a | 2016-01-29 11:55:07 -0800 | [diff] [blame] | 41 | using std::set; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 42 | using std::string; |
| 43 | using std::unique_ptr; |
Christopher Wiley | 12e894a | 2016-01-29 11:55:07 -0800 | [diff] [blame] | 44 | using std::vector; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 45 | using testing::TestParamInfo; |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 46 | using testing::internal::CaptureStderr; |
| 47 | using testing::internal::GetCapturedStderr; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 48 | |
| 49 | namespace android { |
| 50 | namespace aidl { |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 51 | namespace { |
| 52 | |
| 53 | const char kExpectedDepFileContents[] = |
| 54 | R"(place/for/output/p/IFoo.java : \ |
| 55 | p/IFoo.aidl |
| 56 | |
| 57 | p/IFoo.aidl : |
| 58 | )"; |
| 59 | |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 60 | const char kExpectedNinjaDepFileContents[] = |
| 61 | R"(place/for/output/p/IFoo.java : \ |
| 62 | p/IFoo.aidl |
| 63 | )"; |
| 64 | |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 65 | const char kExpectedParcelableDeclarationDepFileContents[] = |
| 66 | R"( : \ |
| 67 | p/Foo.aidl |
| 68 | |
| 69 | p/Foo.aidl : |
| 70 | )"; |
| 71 | |
| 72 | const char kExpectedStructuredParcelableDepFileContents[] = |
Steven Moreland | 2a9a7d6 | 2019-02-05 16:11:54 -0800 | [diff] [blame] | 73 | R"(place/for/output/p/Foo.java : \ |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 74 | p/Foo.aidl |
| 75 | |
| 76 | p/Foo.aidl : |
| 77 | )"; |
| 78 | |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 79 | const char kExpectedJavaParcelableOutputContents[] = |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 80 | R"(/* |
| 81 | * This file is auto-generated. DO NOT MODIFY. |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 82 | */ |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 83 | @android.annotation.Hide |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 84 | public class Rect implements android.os.Parcelable |
| 85 | { |
| 86 | // Comment |
| 87 | |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 88 | @android.annotation.Hide |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 89 | public int x = 5; |
| 90 | |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 91 | @android.annotation.Hide |
| 92 | @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14") |
Steven Moreland | 541788d | 2020-05-21 22:05:52 +0000 | [diff] [blame] | 93 | public int y = 0; |
Jiyong Park | d4e73c8 | 2019-07-24 21:39:15 +0900 | [diff] [blame] | 94 | |
| 95 | public android.os.ParcelFileDescriptor fd; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 96 | |
| 97 | public java.util.List<android.os.ParcelFileDescriptor> fds; |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 98 | public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() { |
| 99 | @Override |
| 100 | public Rect createFromParcel(android.os.Parcel _aidl_source) { |
| 101 | Rect _aidl_out = new Rect(); |
| 102 | _aidl_out.readFromParcel(_aidl_source); |
| 103 | return _aidl_out; |
| 104 | } |
| 105 | @Override |
| 106 | public Rect[] newArray(int _aidl_size) { |
| 107 | return new Rect[_aidl_size]; |
| 108 | } |
| 109 | }; |
| 110 | @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) |
| 111 | { |
| 112 | int _aidl_start_pos = _aidl_parcel.dataPosition(); |
| 113 | _aidl_parcel.writeInt(0); |
| 114 | _aidl_parcel.writeInt(x); |
| 115 | _aidl_parcel.writeInt(y); |
Jiyong Park | d4e73c8 | 2019-07-24 21:39:15 +0900 | [diff] [blame] | 116 | if ((fd!=null)) { |
| 117 | _aidl_parcel.writeInt(1); |
| 118 | fd.writeToParcel(_aidl_parcel, 0); |
| 119 | } |
| 120 | else { |
| 121 | _aidl_parcel.writeInt(0); |
| 122 | } |
Jooyung Han | a61aa23 | 2020-10-20 04:00:08 +0900 | [diff] [blame] | 123 | _aidl_parcel.writeTypedList(fds); |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 124 | int _aidl_end_pos = _aidl_parcel.dataPosition(); |
| 125 | _aidl_parcel.setDataPosition(_aidl_start_pos); |
| 126 | _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos); |
| 127 | _aidl_parcel.setDataPosition(_aidl_end_pos); |
| 128 | } |
| 129 | public final void readFromParcel(android.os.Parcel _aidl_parcel) |
| 130 | { |
| 131 | int _aidl_start_pos = _aidl_parcel.dataPosition(); |
| 132 | int _aidl_parcelable_size = _aidl_parcel.readInt(); |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 133 | try { |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 134 | if (_aidl_parcelable_size < 0) return; |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 135 | x = _aidl_parcel.readInt(); |
| 136 | if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return; |
| 137 | y = _aidl_parcel.readInt(); |
| 138 | if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return; |
Jiyong Park | d4e73c8 | 2019-07-24 21:39:15 +0900 | [diff] [blame] | 139 | if ((0!=_aidl_parcel.readInt())) { |
| 140 | fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel); |
| 141 | } |
| 142 | else { |
| 143 | fd = null; |
| 144 | } |
| 145 | if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return; |
Jooyung Han | a61aa23 | 2020-10-20 04:00:08 +0900 | [diff] [blame] | 146 | fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 147 | if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return; |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 148 | } finally { |
Jeongik Cha | 8b32998 | 2020-09-01 20:59:36 +0900 | [diff] [blame] | 149 | if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) { |
| 150 | throw new android.os.BadParcelableException("Overflow in the size of parcelable"); |
| 151 | } |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 152 | _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size); |
| 153 | } |
| 154 | } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 155 | @Override |
| 156 | public int describeContents() { |
| 157 | int _mask = 0; |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 158 | _mask |= describeContents(fd); |
| 159 | _mask |= describeContents(fds); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 160 | return _mask; |
Jeongik Cha | 372a8c8 | 2018-12-12 16:31:11 +0900 | [diff] [blame] | 161 | } |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 162 | private int describeContents(Object _v) { |
| 163 | if (_v == null) return 0; |
| 164 | if (_v instanceof java.util.Collection) { |
| 165 | int _mask = 0; |
| 166 | for (Object o : (java.util.Collection) _v) { |
| 167 | _mask |= describeContents(o); |
| 168 | } |
| 169 | return _mask; |
| 170 | } |
| 171 | if (_v instanceof android.os.Parcelable) { |
| 172 | return ((android.os.Parcelable) _v).describeContents(); |
| 173 | } |
| 174 | return 0; |
| 175 | } |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 176 | } |
| 177 | )"; |
| 178 | |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 179 | // clang-format off |
| 180 | const char kExpectedCppHeaderOutput[] = |
| 181 | R"(#pragma once |
| 182 | |
| 183 | #include <binder/IBinder.h> |
| 184 | #include <binder/IInterface.h> |
| 185 | #include <binder/Status.h> |
| 186 | #include <optional> |
| 187 | #include <utils/String16.h> |
| 188 | #include <utils/StrongPointer.h> |
| 189 | #include <vector> |
| 190 | |
| 191 | class IFoo : public ::android::IInterface { |
| 192 | public: |
| 193 | DECLARE_META_INTERFACE(Foo) |
| 194 | virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0; |
| 195 | }; // class IFoo |
| 196 | class IFooDefault : public IFoo { |
| 197 | public: |
| 198 | ::android::IBinder* onAsBinder() override { |
| 199 | return nullptr; |
| 200 | } |
| 201 | ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override { |
| 202 | return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION); |
| 203 | } |
| 204 | }; // class IFooDefault |
| 205 | )"; |
| 206 | // clang-format on |
| 207 | |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 208 | } // namespace |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 209 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 210 | class AidlTest : public ::testing::TestWithParam<Options::Language> { |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 211 | protected: |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 212 | AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_, |
| 213 | Options::Language lang, AidlError* error = nullptr, |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 214 | const vector<string> additional_arguments = {}) { |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 215 | io_delegate_.SetFileContents(path, contents); |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 216 | vector<string> args; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 217 | args.emplace_back("aidl"); |
| 218 | args.emplace_back("--lang=" + Options::LanguageToString(lang)); |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 219 | for (const string& s : additional_arguments) { |
| 220 | args.emplace_back(s); |
| 221 | } |
| 222 | for (const string& f : preprocessed_files_) { |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 223 | args.emplace_back("--preprocessed=" + f); |
| 224 | } |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 225 | for (const string& i : import_paths_) { |
Jiyong Park | fbbfa93 | 2018-07-30 21:44:10 +0900 | [diff] [blame] | 226 | args.emplace_back("--include=" + i); |
| 227 | } |
| 228 | args.emplace_back(path); |
| 229 | Options options = Options::From(args); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 230 | vector<string> imported_files; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 231 | ImportResolver import_resolver{io_delegate_, path, import_paths_, {}}; |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 232 | AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl( |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 233 | path, options, io_delegate_, &typenames_, &imported_files); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 234 | |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 235 | if (error != nullptr) { |
| 236 | *error = actual_error; |
| 237 | } |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 238 | |
| 239 | if (actual_error != AidlError::OK) { |
| 240 | return nullptr; |
| 241 | } |
| 242 | |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 243 | const auto& defined_types = typenames_.MainDocument().DefinedTypes(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 244 | EXPECT_EQ(1ul, defined_types.size()); |
| 245 | |
Jiyong Park | 8e79b7f | 2020-07-20 20:52:38 +0900 | [diff] [blame] | 246 | return defined_types.front().get(); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 247 | } |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 248 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 249 | Options::Language GetLanguage() { return GetParam(); } |
| 250 | |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 251 | FakeIoDelegate io_delegate_; |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 252 | vector<string> preprocessed_files_; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 253 | set<string> import_paths_; |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 254 | AidlTypenames typenames_; |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 255 | }; |
| 256 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 257 | // Instantiate the AidlTest parameterized suite, calling all of the TEST_P |
| 258 | // tests with each of the supported languages as a parameter. |
| 259 | INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest, |
| 260 | testing::Values(Options::Language::CPP, Options::Language::JAVA, |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 261 | Options::Language::NDK, Options::Language::RUST), |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 262 | [](const testing::TestParamInfo<Options::Language>& info) { |
| 263 | return Options::LanguageToString(info.param); |
| 264 | }); |
| 265 | |
| 266 | TEST_P(AidlTest, AcceptMissingPackage) { |
| 267 | EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage())); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 268 | } |
| 269 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 270 | TEST_P(AidlTest, EndsInSingleLineComment) { |
| 271 | EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage())); |
Steven Moreland | 9c2988f | 2019-07-17 17:49:10 -0700 | [diff] [blame] | 272 | } |
| 273 | |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 274 | TEST_P(AidlTest, InterfaceRequiresCorrectPath) { |
| 275 | const string expected_stderr = |
| 276 | "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n"; |
| 277 | const std::string file_contents = "package a; interface IBar {}"; |
| 278 | CaptureStderr(); |
| 279 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 280 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 281 | } |
| 282 | |
| 283 | TEST_P(AidlTest, ParcelableRequiresCorrectPath) { |
| 284 | const string expected_stderr = |
| 285 | "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n"; |
| 286 | const std::string file_contents = "package a; interface Bar {}"; |
| 287 | CaptureStderr(); |
| 288 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 289 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 290 | } |
| 291 | |
| 292 | TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) { |
| 293 | const string expected_stderr = |
| 294 | "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n"; |
| 295 | const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";"; |
| 296 | CaptureStderr(); |
| 297 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 298 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 299 | } |
| 300 | |
| 301 | TEST_P(AidlTest, EnumRequiresCorrectPath) { |
| 302 | const string expected_stderr = |
| 303 | "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n"; |
| 304 | const std::string file_contents = "package a; enum Bar { A, }"; |
| 305 | CaptureStderr(); |
| 306 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage())); |
| 307 | EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents; |
| 308 | } |
| 309 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 310 | TEST_P(AidlTest, RejectsArraysOfBinders) { |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 311 | import_paths_.emplace(""); |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 312 | io_delegate_.SetFileContents("bar/IBar.aidl", |
| 313 | "package bar; interface IBar {}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 314 | const string path = "foo/IFoo.aidl"; |
| 315 | const string contents = |
| 316 | "package foo;\n" |
| 317 | "import bar.IBar;\n" |
| 318 | "interface IFoo { void f(in IBar[] input); }"; |
| 319 | const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n"; |
| 320 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 321 | EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 322 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 0522cd5 | 2015-10-28 15:39:44 -0700 | [diff] [blame] | 323 | } |
| 324 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 325 | TEST_P(AidlTest, SupportOnlyOutParameters) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 326 | const string interface_list = "package a; interface IBar { void f(out List<String> bar); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 327 | EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage())); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 328 | } |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 329 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 330 | TEST_P(AidlTest, RejectOutParametersForIBinder) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 331 | const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }"; |
| 332 | const string expected_ibinder_stderr = |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 333 | "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an " |
| 334 | "in parameter.\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 335 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 336 | EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 337 | EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr()); |
Jeongik Cha | a2080bf | 2019-06-18 16:44:29 +0900 | [diff] [blame] | 338 | } |
| 339 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 340 | TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 341 | const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }"; |
| 342 | const string expected_stderr = |
| 343 | "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 344 | CaptureStderr(); |
| 345 | EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage())); |
| 346 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 347 | } |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 348 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 349 | TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 350 | const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }"; |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 351 | const string expected_stderr = |
| 352 | "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 353 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 354 | EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 355 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 356 | } |
| 357 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 358 | TEST_P(AidlTest, RejectsOnewayNonVoidReturn) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 359 | const string oneway_method = "package a; interface IFoo { oneway int f(); }"; |
| 360 | const string expected_stderr = |
| 361 | "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n"; |
| 362 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 363 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 364 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 365 | } |
| 366 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 367 | TEST_P(AidlTest, RejectsNullablePrimitive) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 368 | const string oneway_method = "package a; interface IFoo { @nullable int f(); }"; |
| 369 | const string expected_stderr = |
| 370 | "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n"; |
| 371 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 372 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 373 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Casey Dahlin | 57dbe24 | 2015-12-04 11:44:02 -0800 | [diff] [blame] | 374 | } |
| 375 | |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 376 | TEST_P(AidlTest, AcceptNullableList) { |
| 377 | const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }"; |
| 378 | const string expected_stderr = ""; |
| 379 | CaptureStderr(); |
| 380 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
| 381 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 382 | } |
| 383 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 384 | TEST_P(AidlTest, RejectsDuplicatedArgumentNames) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 385 | const string method = "package a; interface IFoo { void f(int a, int a); }"; |
| 386 | const string expected_stderr = |
| 387 | "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n"; |
| 388 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 389 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 390 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | b3cd3c7 | 2018-10-11 12:37:45 -0700 | [diff] [blame] | 391 | } |
| 392 | |
Jeongik Cha | 13066da | 2020-08-06 15:43:19 +0900 | [diff] [blame] | 393 | TEST_P(AidlTest, RejectsDuplicatedFieldNames) { |
| 394 | const string method = "package a; parcelable Foo { int a; String a; }"; |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 395 | const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n"; |
Jeongik Cha | 13066da | 2020-08-06 15:43:19 +0900 | [diff] [blame] | 396 | CaptureStderr(); |
| 397 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 398 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 399 | } |
| 400 | |
Jooyung Han | d902a97 | 2020-10-23 17:32:44 +0900 | [diff] [blame] | 401 | TEST_P(AidlTest, RejectsRepeatedAnnotations) { |
| 402 | const string method = R"(@Hide @Hide parcelable Foo {})"; |
| 403 | const string expected_stderr = |
| 404 | "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: " |
| 405 | "Foo.aidl:1.1-6\n"; |
| 406 | CaptureStderr(); |
| 407 | EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage())); |
| 408 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 409 | } |
| 410 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 411 | TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 412 | const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }"; |
| 413 | const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n"; |
| 414 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 415 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 416 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 417 | } |
| 418 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 419 | TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 420 | AidlError error; |
| 421 | const string method = "package a; @nullable interface IFoo { int f(); }"; |
| 422 | const string expected_stderr = |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 423 | "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. " |
Steven Moreland | a7764e5 | 2020-10-27 17:29:29 +0000 | [diff] [blame] | 424 | "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, " |
| 425 | "JavaPassthrough, Descriptor\n"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 426 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 427 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 428 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 429 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 430 | } |
| 431 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 432 | TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 433 | AidlError error; |
| 434 | const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }"; |
| 435 | const string expected_stderr = |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 436 | "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation " |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 437 | "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 438 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 439 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 440 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 441 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 442 | } |
| 443 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 444 | TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 445 | AidlError error; |
| 446 | const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";"; |
| 447 | const string expected_stderr = |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 448 | "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. " |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 449 | "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, " |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 450 | "JavaPassthrough, JavaOnlyImmutable\n"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 451 | CaptureStderr(); |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 452 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 453 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 454 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 455 | } |
| 456 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 457 | TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 458 | AidlError error; |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 459 | const string method = "package a; @nullable parcelable IFoo { String a; String b; }"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 460 | const string expected_stderr = |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 461 | "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. " |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 462 | "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, " |
Andrei Homescu | e61feb5 | 2020-08-18 15:44:24 -0700 | [diff] [blame] | 463 | "JavaOnlyImmutable, FixedSize, RustDerive\n"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 464 | CaptureStderr(); |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 465 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 466 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 467 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Devin Moore | 24f6857 | 2020-02-26 13:20:59 -0800 | [diff] [blame] | 468 | } |
| 469 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 470 | TEST_P(AidlTest, ParsesNonNullableAnnotation) { |
| 471 | auto parse_result = |
| 472 | Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage()); |
| 473 | ASSERT_NE(nullptr, parse_result); |
| 474 | const AidlInterface* interface = parse_result->AsInterface(); |
| 475 | ASSERT_NE(nullptr, interface); |
| 476 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 477 | EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable()); |
| 478 | } |
| 479 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 480 | TEST_P(AidlTest, ParsesNullableAnnotation) { |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 481 | auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }", |
| 482 | typenames_, GetLanguage()); |
| 483 | ASSERT_NE(nullptr, parse_result); |
| 484 | const AidlInterface* interface = parse_result->AsInterface(); |
| 485 | ASSERT_NE(nullptr, interface); |
| 486 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 487 | EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable()); |
| 488 | } |
| 489 | |
| 490 | TEST_P(AidlTest, ParsesNonUtf8Annotations) { |
| 491 | auto parse_result = |
| 492 | Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage()); |
| 493 | ASSERT_NE(nullptr, parse_result); |
| 494 | const AidlInterface* interface = parse_result->AsInterface(); |
| 495 | ASSERT_NE(nullptr, interface); |
| 496 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 497 | EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp()); |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 498 | } |
| 499 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 500 | TEST_P(AidlTest, ParsesUtf8Annotations) { |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 501 | auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }", |
| 502 | typenames_, GetLanguage()); |
| 503 | ASSERT_NE(nullptr, parse_result); |
| 504 | const AidlInterface* interface = parse_result->AsInterface(); |
| 505 | ASSERT_NE(nullptr, interface); |
| 506 | ASSERT_FALSE(interface->GetMethods().empty()); |
| 507 | EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp()); |
Christopher Wiley | ec31a05 | 2016-01-25 07:28:51 -0800 | [diff] [blame] | 508 | } |
| 509 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 510 | TEST_P(AidlTest, VintfRequiresStructuredAndStability) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 511 | AidlError error; |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 512 | const string expected_stderr = |
| 513 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: " |
| 514 | "\"vintf\"'\n" |
| 515 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface " |
| 516 | "--structured\n"; |
| 517 | CaptureStderr(); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 518 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 519 | GetLanguage(), &error)); |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 520 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 521 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 522 | } |
| 523 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 524 | TEST_P(AidlTest, VintfRequiresStructured) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 525 | AidlError error; |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 526 | const string expected_stderr = |
| 527 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface " |
| 528 | "--structured\n"; |
| 529 | CaptureStderr(); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 530 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 531 | GetLanguage(), &error, {"--stability", "vintf"})); |
Devin Moore | 0d0e3f6 | 2020-03-30 17:45:39 -0700 | [diff] [blame] | 532 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 533 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 534 | } |
| 535 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 536 | TEST_P(AidlTest, VintfRequiresSpecifiedStability) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 537 | AidlError error; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 538 | const string expected_stderr = |
| 539 | "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: " |
| 540 | "\"vintf\"'\n"; |
| 541 | CaptureStderr(); |
| 542 | ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 543 | GetLanguage(), &error, {"--structured"})); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 544 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 545 | ASSERT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 546 | } |
| 547 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 548 | TEST_P(AidlTest, ParsesStabilityAnnotations) { |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 549 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 550 | auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_, |
| 551 | GetLanguage(), &error, {"--structured", "--stability", "vintf"}); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 552 | ASSERT_EQ(AidlError::OK, error); |
| 553 | ASSERT_NE(nullptr, parse_result); |
| 554 | const AidlInterface* interface = parse_result->AsInterface(); |
| 555 | ASSERT_NE(nullptr, interface); |
| 556 | ASSERT_TRUE(interface->IsVintfStability()); |
Steven Moreland | a57d0a6 | 2019-07-30 09:41:14 -0700 | [diff] [blame] | 557 | } |
| 558 | |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 559 | TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) { |
| 560 | Options java_options = Options::From("aidl -o out --structured a/Foo.aidl"); |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 561 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl"); |
| 562 | Options cpp_structured_options = |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 563 | Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl"); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 564 | Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl"); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 565 | io_delegate_.SetFileContents( |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 566 | "a/Foo.aidl", |
| 567 | StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;")); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 568 | |
| 569 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 570 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 571 | const string expected_stderr = |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 572 | "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. " |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 573 | "Parcelable must be defined in AIDL directly.\n"; |
| 574 | CaptureStderr(); |
Jeongik Cha | 88f95a8 | 2020-01-15 13:02:16 +0900 | [diff] [blame] | 575 | EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 576 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 577 | |
| 578 | CaptureStderr(); |
| 579 | EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_)); |
| 580 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | 64783ed | 2019-06-07 18:30:54 +0900 | [diff] [blame] | 581 | } |
| 582 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 583 | TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) { |
| 584 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 585 | @JavaDerive(toString=true) parcelable Foo { int a; float b; })"); |
| 586 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 587 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 588 | |
| 589 | string java_out; |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 590 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 591 | EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {")); |
| 592 | |
| 593 | // Other backends shouldn't be bothered |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 594 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 595 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
| 596 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 597 | Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 598 | EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_)); |
| 599 | } |
| 600 | |
Jooyung Han | 1cbc496 | 2020-10-25 10:07:15 +0900 | [diff] [blame] | 601 | TEST_F(AidlTest, UnionSupportJavaDeriveToString) { |
| 602 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 603 | @JavaDerive(toString=true) union Foo { int a; int[] b; })"); |
| 604 | CaptureStderr(); |
| 605 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 606 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 607 | EXPECT_EQ("", GetCapturedStderr()); |
| 608 | |
| 609 | const string expected_to_string_method = R"--( |
| 610 | @Override |
| 611 | public String toString() { |
| 612 | switch (_tag) { |
| 613 | case a: return "a.Foo.a(" + (getA()) + ")"; |
| 614 | case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")"; |
| 615 | } |
| 616 | throw new IllegalStateException("unknown field: " + _tag); |
| 617 | } |
| 618 | )--"; |
| 619 | |
| 620 | string java_out; |
| 621 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out)); |
| 622 | EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method)); |
| 623 | } |
| 624 | |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 625 | TEST_F(AidlTest, RejectsJavaDeriveAnnotation) { |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 626 | { |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 627 | io_delegate_.SetFileContents("a/Foo.aidl", |
| 628 | "package a; @JavaDerive(blah=true) parcelable Foo{}"); |
| 629 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 630 | CaptureStderr(); |
| 631 | EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 632 | const std::string expected_stderr = |
| 633 | "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive."; |
| 634 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr)); |
| 635 | } |
| 636 | |
| 637 | { |
| 638 | io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 639 | Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl"); |
| 640 | CaptureStderr(); |
| 641 | EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 642 | const std::string expected_stderr = |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 643 | "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. " |
Steven Moreland | a7764e5 | 2020-10-27 17:29:29 +0000 | [diff] [blame] | 644 | "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, " |
| 645 | "JavaPassthrough, Descriptor\n"; |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 646 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 647 | } |
| 648 | |
| 649 | { |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 650 | io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }"); |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 651 | Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl"); |
| 652 | CaptureStderr(); |
| 653 | EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 654 | const std::string expected_stderr = |
Jooyung Han | 9034500 | 2020-10-23 15:28:53 +0900 | [diff] [blame] | 655 | "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. " |
Jiyong Park | 43113fb | 2020-07-20 16:26:19 +0900 | [diff] [blame] | 656 | "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n"; |
| 657 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 658 | } |
| 659 | } |
| 660 | |
Jiyong Park | 27fd7fd | 2020-08-27 16:25:09 +0900 | [diff] [blame] | 661 | TEST_P(AidlTest, ParseDescriptorAnnotation) { |
| 662 | AidlError error; |
| 663 | auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})", |
| 664 | typenames_, GetLanguage(), &error, {"--structured"}); |
| 665 | ASSERT_EQ(AidlError::OK, error); |
| 666 | ASSERT_NE(nullptr, parse_result); |
| 667 | const AidlInterface* interface = parse_result->AsInterface(); |
| 668 | ASSERT_NE(nullptr, interface); |
| 669 | ASSERT_EQ("IBar", interface->GetDescriptor()); |
| 670 | } |
| 671 | |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 672 | TEST_P(AidlTest, AcceptsOnewayMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 673 | const string oneway_method = "package a; interface IFoo { oneway void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 674 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 675 | } |
| 676 | |
| 677 | TEST_P(AidlTest, AcceptsOnewayInterface) { |
| 678 | const string oneway_interface = "package a; oneway interface IBar { void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 679 | EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage())); |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 680 | } |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 681 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 682 | TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 683 | const string oneway_method = |
| 684 | "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 685 | EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage())); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 686 | } |
| 687 | |
Steven Moreland | 65297cc | 2020-04-20 20:17:36 -0700 | [diff] [blame] | 688 | TEST_P(AidlTest, AnnotationsInMultiplePlaces) { |
| 689 | const string oneway_method = |
| 690 | "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }"; |
| 691 | const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()); |
| 692 | ASSERT_NE(nullptr, defined); |
| 693 | const AidlInterface* iface = defined->AsInterface(); |
| 694 | ASSERT_NE(nullptr, iface); |
| 695 | |
| 696 | const auto& methods = iface->GetMethods(); |
| 697 | ASSERT_EQ(1u, methods.size()); |
| 698 | const auto& method = methods[0]; |
| 699 | const AidlTypeSpecifier& ret_type = method->GetType(); |
| 700 | |
| 701 | // TODO(b/151102494): these annotations should be on the method |
| 702 | ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage()); |
| 703 | ASSERT_TRUE(ret_type.IsHide()); |
| 704 | } |
| 705 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 706 | TEST_P(AidlTest, WritesComments) { |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 707 | string foo_interface = |
| 708 | "package a; /* foo */ interface IFoo {" |
| 709 | " /* i */ int i();" |
| 710 | " /* j */ @nullable String j();" |
| 711 | " /* k */ @UnsupportedAppUsage oneway void k(int a); }"; |
| 712 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 713 | auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage()); |
Artur Satayev | 91fe871 | 2019-07-29 13:06:01 +0100 | [diff] [blame] | 714 | EXPECT_NE(nullptr, parse_result); |
| 715 | EXPECT_EQ("/* foo */", parse_result->GetComments()); |
| 716 | |
| 717 | const AidlInterface* interface = parse_result->AsInterface(); |
| 718 | EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments()); |
| 719 | EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments()); |
| 720 | EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments()); |
| 721 | } |
| 722 | |
Jooyung Han | 1a551d3 | 2020-10-05 15:37:26 +0900 | [diff] [blame] | 723 | TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) { |
| 724 | io_delegate_.SetFileContents("p/cpp_header.aidl", |
| 725 | R"(package p; |
| 726 | parcelable cpp_header cpp_header "bar/header";)"); |
| 727 | import_paths_.emplace(""); |
| 728 | const string input_path = "p/IFoo.aidl"; |
| 729 | const string input = R"(package p; |
| 730 | import p.cpp_header; |
| 731 | interface IFoo { |
| 732 | // get bar |
| 733 | cpp_header get(); |
| 734 | })"; |
| 735 | |
| 736 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 737 | EXPECT_NE(nullptr, parse_result); |
| 738 | const AidlInterface* interface = parse_result->AsInterface(); |
| 739 | EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments()); |
| 740 | } |
| 741 | |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 742 | TEST_F(AidlTest, ParsesPreprocessedFile) { |
| 743 | string simple_content = "parcelable a.Foo;\ninterface b.IBar;"; |
| 744 | io_delegate_.SetFileContents("path", simple_content); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 745 | EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 746 | EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_)); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 747 | EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved); |
| 748 | EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved); |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 749 | } |
| 750 | |
| 751 | TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) { |
| 752 | string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t"; |
| 753 | io_delegate_.SetFileContents("path", simple_content); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 754 | |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 755 | EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 756 | EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_)); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 757 | EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved); |
| 758 | EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved); |
Christopher Wiley | ef14093 | 2015-11-03 09:29:19 -0800 | [diff] [blame] | 759 | } |
| 760 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 761 | TEST_P(AidlTest, PreferImportToPreprocessed) { |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 762 | io_delegate_.SetFileContents("preprocessed", "interface another.IBar;"); |
| 763 | io_delegate_.SetFileContents("one/IBar.aidl", "package one; " |
| 764 | "interface IBar {}"); |
| 765 | preprocessed_files_.push_back("preprocessed"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 766 | import_paths_.emplace(""); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 767 | auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 768 | typenames_, GetLanguage()); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 769 | EXPECT_NE(nullptr, parse_result); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 770 | |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 771 | // We expect to know about both kinds of IBar |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 772 | EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved); |
| 773 | EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 774 | // But if we request just "IBar" we should get our imported one. |
Steven Moreland | 02e012e | 2018-08-02 14:58:10 -0700 | [diff] [blame] | 775 | AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, ""); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 776 | ambiguous_type.Resolve(typenames_); |
| 777 | EXPECT_EQ("one.IBar", ambiguous_type.GetName()); |
Christopher Wiley | 4154437 | 2015-11-03 14:52:29 -0800 | [diff] [blame] | 778 | } |
| 779 | |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 780 | // Special case of PreferImportToPreprocessed. Imported type should be preferred |
| 781 | // even when the preprocessed file already has the same type. |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 782 | TEST_P(AidlTest, B147918827) { |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 783 | io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;"); |
| 784 | io_delegate_.SetFileContents("one/IBar.aidl", |
| 785 | "package one; " |
| 786 | "interface IBar {}"); |
| 787 | preprocessed_files_.push_back("preprocessed"); |
| 788 | import_paths_.emplace(""); |
| 789 | auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 790 | typenames_, GetLanguage()); |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 791 | EXPECT_NE(nullptr, parse_result); |
| 792 | |
| 793 | // We expect to know about both kinds of IBar |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 794 | EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved); |
| 795 | EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved); |
Jiyong Park | 8f6ec46 | 2020-01-19 20:52:47 +0900 | [diff] [blame] | 796 | // But if we request just "IBar" we should get our imported one. |
| 797 | AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, ""); |
| 798 | ambiguous_type.Resolve(typenames_); |
| 799 | EXPECT_EQ("one.IBar", ambiguous_type.GetName()); |
| 800 | } |
| 801 | |
Casey Dahlin | c1f39b4 | 2015-11-24 10:34:34 -0800 | [diff] [blame] | 802 | TEST_F(AidlTest, WritePreprocessedFile) { |
| 803 | io_delegate_.SetFileContents("p/Outer.aidl", |
| 804 | "package p; parcelable Outer.Inner;"); |
| 805 | io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;" |
| 806 | "interface IBar {}"); |
| 807 | |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 808 | vector<string> args { |
| 809 | "aidl", |
| 810 | "--preprocess", |
| 811 | "preprocessed", |
| 812 | "p/Outer.aidl", |
| 813 | "one/IBar.aidl"}; |
| 814 | Options options = Options::From(args); |
Casey Dahlin | c1f39b4 | 2015-11-24 10:34:34 -0800 | [diff] [blame] | 815 | EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_)); |
| 816 | |
| 817 | string output; |
| 818 | EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output)); |
| 819 | EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output); |
| 820 | } |
| 821 | |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 822 | TEST_F(AidlTest, JavaParcelableOutput) { |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 823 | io_delegate_.SetFileContents( |
| 824 | "Rect.aidl", |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 825 | "@Hide\n" |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 826 | "parcelable Rect {\n" |
| 827 | " // Comment\n" |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 828 | " @Hide\n" |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 829 | " int x=5;\n" |
Makoto Onuki | 78a1c1c | 2020-03-04 16:57:23 -0800 | [diff] [blame] | 830 | " @Hide\n" |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 831 | " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", " |
Andrei Onea | 07fa3e0 | 2019-07-04 17:55:19 +0100 | [diff] [blame] | 832 | "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" " |
| 833 | "+ \"y\")\n" |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 834 | " int y;\n" |
Jiyong Park | d4e73c8 | 2019-07-24 21:39:15 +0900 | [diff] [blame] | 835 | " ParcelFileDescriptor fd;\n" |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 836 | " List<ParcelFileDescriptor> fds;\n" |
Andrei Onea | 9445fc6 | 2019-06-27 18:11:59 +0100 | [diff] [blame] | 837 | "}"); |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 838 | |
| 839 | vector<string> args{"aidl", "Rect.aidl"}; |
| 840 | Options options = Options::From(args); |
| 841 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 842 | |
| 843 | string output; |
| 844 | EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output)); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 845 | EXPECT_EQ(kExpectedJavaParcelableOutputContents, output); |
Jeongik Cha | a755c2a | 2018-12-12 16:28:23 +0900 | [diff] [blame] | 846 | } |
| 847 | |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 848 | TEST_F(AidlTest, CppHeaderIncludes) { |
| 849 | io_delegate_.SetFileContents("IFoo.aidl", |
| 850 | "interface IFoo {\n" |
| 851 | " @nullable List<String> foo();\n" |
| 852 | "}"); |
| 853 | |
| 854 | vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"}; |
| 855 | Options options = Options::From(args); |
| 856 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 857 | std::vector<std::string> empty; |
| 858 | EXPECT_EQ(empty, io_delegate_.ListFiles("")); |
| 859 | EXPECT_EQ(empty, io_delegate_.ListFiles("/")); |
| 860 | EXPECT_EQ(empty, io_delegate_.ListFiles("out")); |
| 861 | |
| 862 | // Make sure the optional and String16.h includes are added |
| 863 | string output; |
| 864 | EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output)); |
| 865 | EXPECT_EQ(kExpectedCppHeaderOutput, output); |
| 866 | } |
| 867 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 868 | TEST_P(AidlTest, RequireOuterClass) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 869 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n"; |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 870 | io_delegate_.SetFileContents("p/Outer.aidl", |
| 871 | "package p; parcelable Outer.Inner;"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 872 | import_paths_.emplace(""); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 873 | CaptureStderr(); |
| 874 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 875 | "package p; import p.Outer; interface IFoo { void f(in Inner c); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 876 | typenames_, GetLanguage())); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 877 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 878 | } |
| 879 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 880 | TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) { |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 881 | io_delegate_.SetFileContents("preprocessed", |
| 882 | "parcelable p.Outer.Inner;"); |
| 883 | preprocessed_files_.push_back("preprocessed"); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 884 | auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 885 | typenames_, GetLanguage()); |
Christopher Wiley | 63bce2a | 2015-11-03 14:55:03 -0800 | [diff] [blame] | 886 | // TODO(wiley): This should actually return nullptr because we require |
| 887 | // the outer class name. However, for legacy reasons, |
| 888 | // this behavior must be maintained. b/17415692 |
| 889 | EXPECT_NE(nullptr, parse_result); |
| 890 | } |
| 891 | |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 892 | TEST_F(AidlTest, FailOnParcelable) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 893 | const string expected_foo_stderr = |
| 894 | "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. " |
| 895 | "Declared parcelables should be in their own file and/or cannot be used with --structured " |
| 896 | "interfaces.\n"; |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 897 | io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;"); |
| 898 | |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 899 | // By default, we shouldn't fail on parcelable. |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 900 | Options options1 = Options::From("aidl p/IFoo.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 901 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 902 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 903 | EXPECT_EQ("", GetCapturedStderr()); |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 904 | |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 905 | // -b considers this an error |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 906 | Options options2 = Options::From("aidl -b p/IFoo.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 907 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 908 | EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 909 | EXPECT_EQ(expected_foo_stderr, GetCapturedStderr()); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 910 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 911 | const string expected_bar_stderr = |
| 912 | "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. " |
| 913 | "Declared parcelables should be in their own file and/or cannot be used with --structured " |
| 914 | "interfaces.\n"; |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 915 | io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}"); |
| 916 | |
Jiyong Park | da8c693 | 2019-08-12 19:56:08 +0900 | [diff] [blame] | 917 | // With '-b' option, a parcelable and an interface should fail. |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 918 | Options options3 = Options::From("aidl p/IBar.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 919 | CaptureStderr(); |
Jiyong Park | da8c693 | 2019-08-12 19:56:08 +0900 | [diff] [blame] | 920 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 921 | EXPECT_EQ("", GetCapturedStderr()); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 922 | Options options4 = Options::From("aidl -b p/IBar.aidl"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 923 | CaptureStderr(); |
Steven Moreland | e2c64b4 | 2018-09-18 15:06:37 -0700 | [diff] [blame] | 924 | EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 925 | EXPECT_EQ(expected_bar_stderr, GetCapturedStderr()); |
Christopher Wiley | 632801d | 2015-11-05 14:15:49 -0800 | [diff] [blame] | 926 | } |
| 927 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 928 | TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 929 | const string expected_stderr = |
| 930 | "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a " |
| 931 | "structured interface.\n"; |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 932 | io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;"); |
| 933 | import_paths_.emplace(""); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 934 | AidlError error; |
| 935 | CaptureStderr(); |
| 936 | EXPECT_EQ( |
| 937 | nullptr, |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 938 | Parse("p/IFoo.aidl", |
| 939 | "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 940 | typenames_, GetLanguage(), &error, {"--structured"})); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 941 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 942 | EXPECT_EQ(AidlError::NOT_STRUCTURED, error); |
Steven Moreland | 1eac5fa | 2018-08-27 19:35:05 -0700 | [diff] [blame] | 943 | } |
| 944 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 945 | TEST_P(AidlTest, FailOnDuplicateConstantNames) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 946 | AidlError error; |
| 947 | const string expected_stderr = |
| 948 | "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n"; |
| 949 | CaptureStderr(); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 950 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 951 | R"(package p; |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 952 | interface IFoo { |
| 953 | const String DUPLICATED = "d"; |
| 954 | const int DUPLICATED = 1; |
| 955 | } |
| 956 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 957 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 958 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 959 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Christopher Wiley | 69b44cf | 2016-05-03 13:43:33 -0700 | [diff] [blame] | 960 | } |
| 961 | |
Steven Moreland | e689da2 | 2020-11-10 02:06:30 +0000 | [diff] [blame] | 962 | TEST_P(AidlTest, FailOnTooBigConstant) { |
| 963 | AidlError error; |
| 964 | const string expected_stderr = |
| 965 | "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n"; |
| 966 | CaptureStderr(); |
| 967 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 968 | R"(package p; |
| 969 | interface IFoo { |
| 970 | const byte type2small = 256; |
| 971 | } |
| 972 | )", |
| 973 | typenames_, GetLanguage(), &error)); |
| 974 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 975 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
| 976 | } |
| 977 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 978 | TEST_P(AidlTest, FailOnManyDefinedTypes) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 979 | AidlError error; |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 980 | const string expected_stderr = |
| 981 | "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n"; |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 982 | CaptureStderr(); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 983 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 984 | R"(package p; |
| 985 | interface IFoo {} |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 986 | parcelable IBar {} |
| 987 | parcelable StructuredParcelable {} |
| 988 | interface IBaz {} |
Jeongik Cha | 2a5b4d8 | 2019-08-06 19:37:59 +0900 | [diff] [blame] | 989 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 990 | typenames_, GetLanguage(), &error)); |
Devin Moore | c054bf8 | 2020-03-10 16:31:48 -0700 | [diff] [blame] | 991 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 992 | // Parse success is important for clear error handling even if the cases aren't |
| 993 | // actually supported in code generation. |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 994 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 995 | } |
| 996 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 997 | TEST_P(AidlTest, FailOnNoDefinedTypes) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 998 | AidlError error; |
| 999 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n"; |
| 1000 | CaptureStderr(); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1001 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1002 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1003 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Steven Moreland | c258abc | 2018-07-10 14:03:38 -0700 | [diff] [blame] | 1004 | } |
| 1005 | |
Steven Moreland | f9e922f | 2020-07-08 21:15:27 +0000 | [diff] [blame] | 1006 | TEST_P(AidlTest, FailOnEmptyListWithComma) { |
| 1007 | AidlError error; |
| 1008 | const string expected_stderr = |
| 1009 | "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n"; |
| 1010 | CaptureStderr(); |
| 1011 | EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })", |
| 1012 | typenames_, GetLanguage(), &error)); |
| 1013 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1014 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1015 | } |
| 1016 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1017 | TEST_P(AidlTest, FailOnMalformedConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1018 | AidlError error; |
| 1019 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 1020 | "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1021 | CaptureStderr(); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1022 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 1023 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1024 | interface IFoo { |
| 1025 | const int BAD_HEX_VALUE = 0xffffffffffffffffff; |
| 1026 | } |
| 1027 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1028 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1029 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1030 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1031 | } |
| 1032 | |
Jiyong Park | 1813218 | 2020-06-08 20:24:40 +0900 | [diff] [blame] | 1033 | TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) { |
| 1034 | AidlError error; |
| 1035 | const string expected_stderr = |
| 1036 | "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or " |
| 1037 | "cpp_header (which can also be used as an identifier)\n"; |
| 1038 | CaptureStderr(); |
| 1039 | // Notice the trailing dot(.) in the name, which isn't a correct name |
| 1040 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_, |
| 1041 | GetLanguage(), &error)); |
| 1042 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1043 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1044 | } |
| 1045 | |
| 1046 | TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) { |
| 1047 | AidlError error; |
| 1048 | const string expected_stderr = |
| 1049 | "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or " |
| 1050 | "cpp_header (which can also be used as an identifier)\n"; |
| 1051 | CaptureStderr(); |
| 1052 | // Notice the trailing dot(.) in the package name |
| 1053 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_, |
| 1054 | GetLanguage(), &error)); |
| 1055 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1056 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
| 1057 | } |
| 1058 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1059 | TEST_P(AidlTest, ParsePositiveConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1060 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1061 | auto parse_result = Parse("p/IFoo.aidl", |
| 1062 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1063 | interface IFoo { |
| 1064 | const int POSITIVE_HEX_VALUE = 0xf5; |
| 1065 | } |
| 1066 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1067 | typenames_, GetLanguage(), &error); |
| 1068 | EXPECT_NE(nullptr, parse_result); |
| 1069 | const AidlInterface* interface = parse_result->AsInterface(); |
Steven Moreland | 5557f1c | 2018-07-02 13:50:23 -0700 | [diff] [blame] | 1070 | ASSERT_NE(nullptr, interface); |
Steven Moreland | 693640b | 2018-07-19 13:46:27 -0700 | [diff] [blame] | 1071 | const auto& cpp_constants = interface->GetConstantDeclarations(); |
| 1072 | EXPECT_EQ((size_t)1, cpp_constants.size()); |
| 1073 | EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName()); |
Will McVicker | d7d18df | 2019-09-12 13:40:50 -0700 | [diff] [blame] | 1074 | EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_)); |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 1075 | EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator)); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1076 | } |
| 1077 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1078 | TEST_P(AidlTest, ParseNegativeConstHexValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1079 | AidlError error; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1080 | auto parse_result = Parse("p/IFoo.aidl", |
| 1081 | R"(package p; |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1082 | interface IFoo { |
| 1083 | const int NEGATIVE_HEX_VALUE = 0xffffffff; |
| 1084 | } |
| 1085 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1086 | typenames_, GetLanguage(), &error); |
| 1087 | ASSERT_NE(nullptr, parse_result); |
| 1088 | const AidlInterface* interface = parse_result->AsInterface(); |
Steven Moreland | 5557f1c | 2018-07-02 13:50:23 -0700 | [diff] [blame] | 1089 | ASSERT_NE(nullptr, interface); |
Steven Moreland | 693640b | 2018-07-19 13:46:27 -0700 | [diff] [blame] | 1090 | const auto& cpp_constants = interface->GetConstantDeclarations(); |
| 1091 | EXPECT_EQ((size_t)1, cpp_constants.size()); |
| 1092 | EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName()); |
Will McVicker | d7d18df | 2019-09-12 13:40:50 -0700 | [diff] [blame] | 1093 | EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_)); |
Steven Moreland | 860b194 | 2018-08-16 14:59:28 -0700 | [diff] [blame] | 1094 | EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator)); |
Roshan Pius | 3b2203d | 2016-07-22 16:13:20 -0700 | [diff] [blame] | 1095 | } |
| 1096 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1097 | TEST_P(AidlTest, UnderstandsNestedParcelables) { |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1098 | io_delegate_.SetFileContents( |
| 1099 | "p/Outer.aidl", |
| 1100 | "package p; parcelable Outer.Inner cpp_header \"baz/header\";"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 1101 | import_paths_.emplace(""); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1102 | const string input_path = "p/IFoo.aidl"; |
| 1103 | const string input = "package p; import p.Outer; interface IFoo" |
| 1104 | " { Outer.Inner get(); }"; |
| 1105 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1106 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 1107 | EXPECT_NE(nullptr, parse_result); |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1108 | |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 1109 | EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1110 | // C++ uses "::" instead of "." to refer to a inner class. |
Jeongik Cha | 047c5ee | 2019-08-07 23:16:49 +0900 | [diff] [blame] | 1111 | AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, ""); |
| 1112 | EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_)); |
Ningyuan Wang | d17c58b | 2016-09-29 14:33:14 -0700 | [diff] [blame] | 1113 | } |
| 1114 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1115 | TEST_P(AidlTest, UnderstandsNativeParcelables) { |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1116 | io_delegate_.SetFileContents( |
| 1117 | "p/Bar.aidl", |
Casey Dahlin | cd63921 | 2015-12-15 12:51:04 -0800 | [diff] [blame] | 1118 | "package p; parcelable Bar cpp_header \"baz/header\";"); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 1119 | import_paths_.emplace(""); |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1120 | const string input_path = "p/IFoo.aidl"; |
| 1121 | const string input = "package p; import p.Bar; interface IFoo { }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1122 | auto parse_result = Parse(input_path, input, typenames_, GetLanguage()); |
| 1123 | EXPECT_NE(nullptr, parse_result); |
Steven Moreland | cb1bcd7 | 2020-04-29 16:30:35 -0700 | [diff] [blame] | 1124 | EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1125 | AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, ""); |
| 1126 | native_type.Resolve(typenames_); |
| 1127 | |
| 1128 | EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_)); |
| 1129 | // C++ understands C++ specific stuff |
| 1130 | EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_)); |
| 1131 | set<string> headers; |
Devin Moore | 2f2077a | 2020-08-28 11:27:53 -0700 | [diff] [blame] | 1132 | cpp::AddHeaders(native_type, typenames_, &headers); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1133 | EXPECT_EQ(1u, headers.size()); |
| 1134 | EXPECT_EQ(1u, headers.count("baz/header")); |
Christopher Wiley | 9078d72 | 2015-11-17 10:23:49 -0800 | [diff] [blame] | 1135 | } |
| 1136 | |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1137 | TEST_F(AidlTest, WritesCorrectDependencyFile) { |
| 1138 | // While the in tree build system always gives us an output file name, |
| 1139 | // other android tools take advantage of our ability to infer the intended |
| 1140 | // file name. This test makes sure we handle this correctly. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1141 | vector<string> args = { |
| 1142 | "aidl", |
| 1143 | "-d dep/file/path", |
| 1144 | "-o place/for/output", |
| 1145 | "p/IFoo.aidl"}; |
| 1146 | Options options = Options::From(args); |
| 1147 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1148 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1149 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1150 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Christopher Wiley | f813619 | 2016-04-12 14:19:35 -0700 | [diff] [blame] | 1151 | EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents); |
| 1152 | } |
| 1153 | |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1154 | TEST_F(AidlTest, WritesCorrectDependencyFileNinja) { |
| 1155 | // While the in tree build system always gives us an output file name, |
| 1156 | // other android tools take advantage of our ability to infer the intended |
| 1157 | // file name. This test makes sure we handle this correctly. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1158 | vector<string> args = { |
| 1159 | "aidl", |
| 1160 | "-d dep/file/path", |
| 1161 | "--ninja", |
| 1162 | "-o place/for/output", |
| 1163 | "p/IFoo.aidl"}; |
| 1164 | Options options = Options::From(args); |
| 1165 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1166 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1167 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1168 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Dan Willemsen | 93298ee | 2016-11-10 23:55:55 -0800 | [diff] [blame] | 1169 | EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents); |
| 1170 | } |
| 1171 | |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 1172 | TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) { |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1173 | // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does |
| 1174 | // this by calling aidl with every .aidl file it finds, then parsing the |
| 1175 | // generated dependency files. Those that reference .java output files are |
| 1176 | // for interfaces and those that do not are parcelables. However, for both |
| 1177 | // parcelables and interfaces, we *must* generate a non-empty dependency file. |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1178 | vector<string> args = { |
| 1179 | "aidl", |
| 1180 | "-o place/for/output", |
| 1181 | "-d dep/file/path", |
| 1182 | "p/Foo.aidl"}; |
| 1183 | Options options = Options::From(args); |
| 1184 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1185 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1186 | string actual_dep_file_contents; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1187 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
Jiyong Park | df20212 | 2019-09-30 20:48:35 +0900 | [diff] [blame] | 1188 | EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents); |
| 1189 | } |
| 1190 | |
| 1191 | TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) { |
| 1192 | vector<string> args = { |
| 1193 | "aidl", |
| 1194 | "--structured", |
| 1195 | "-o place/for/output", |
| 1196 | "-d dep/file/path", |
| 1197 | "p/Foo.aidl"}; |
| 1198 | Options options = Options::From(args); |
| 1199 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}"); |
| 1200 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1201 | string actual_dep_file_contents; |
| 1202 | EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents)); |
| 1203 | EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents); |
Christopher Wiley | b1bbdf8 | 2016-04-21 11:43:45 -0700 | [diff] [blame] | 1204 | } |
| 1205 | |
Jiyong Park | 9ca5c7e | 2019-10-17 15:01:14 +0900 | [diff] [blame] | 1206 | TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) { |
| 1207 | vector<string> args = { |
| 1208 | "aidl", |
| 1209 | "--lang=java", |
| 1210 | "-o place/for/output", |
| 1211 | "p/Foo.aidl"}; |
| 1212 | Options options = Options::From(args); |
| 1213 | io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;"); |
| 1214 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1215 | string output_file_contents; |
| 1216 | EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents)); |
| 1217 | } |
| 1218 | |
Jeongik Cha | 08ca218 | 2019-11-21 14:01:13 +0900 | [diff] [blame] | 1219 | // TODO(b/136048684) |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1220 | TEST_P(AidlTest, PrimitiveList) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1221 | const string primitive_interface = |
Jeongik Cha | 08ca218 | 2019-11-21 14:01:13 +0900 | [diff] [blame] | 1222 | "package a; interface IFoo {\n" |
| 1223 | " List<int> foo(); }"; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1224 | string expected_stderr; |
| 1225 | switch (GetLanguage()) { |
| 1226 | case Options::Language::CPP: |
| 1227 | expected_stderr = |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1228 | "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n" |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1229 | "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only " |
| 1230 | "String and IBinder.\n"; |
| 1231 | break; |
| 1232 | case Options::Language::JAVA: |
| 1233 | expected_stderr = |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1234 | "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n" |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1235 | "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only " |
| 1236 | "String, IBinder, and ParcelFileDescriptor.\n"; |
| 1237 | break; |
| 1238 | case Options::Language::NDK: |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 1239 | case Options::Language::RUST: |
| 1240 | expected_stderr = |
| 1241 | "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"; |
| 1242 | break; |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1243 | default: |
| 1244 | AIDL_FATAL(AIDL_LOCATION_HERE) |
| 1245 | << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage()); |
| 1246 | } |
| 1247 | CaptureStderr(); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 1248 | AidlTypenames tn1; |
| 1249 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage())); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1250 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1251 | |
| 1252 | string primitive_parcelable = |
| 1253 | "package a; parcelable IFoo {\n" |
Jeongik Cha | 08ca218 | 2019-11-21 14:01:13 +0900 | [diff] [blame] | 1254 | " List<int> foo;}"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1255 | CaptureStderr(); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 1256 | AidlTypenames tn2; |
| 1257 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage())); |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 1258 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | 08ca218 | 2019-11-21 14:01:13 +0900 | [diff] [blame] | 1259 | } |
| 1260 | |
Devin Moore | 21b2677 | 2020-08-26 16:37:56 -0700 | [diff] [blame] | 1261 | TEST_P(AidlTest, RejectsListArray) { |
Devin Moore | 6a01ca1 | 2020-08-28 10:24:19 -0700 | [diff] [blame] | 1262 | const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n"; |
Devin Moore | 21b2677 | 2020-08-26 16:37:56 -0700 | [diff] [blame] | 1263 | const string list_array_parcelable = |
| 1264 | "package a; parcelable Foo {\n" |
| 1265 | " List[] lists; }"; |
| 1266 | CaptureStderr(); |
| 1267 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage())); |
| 1268 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1269 | } |
| 1270 | |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1271 | TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) { |
| 1272 | AidlError error; |
| 1273 | string expected_stderr = |
| 1274 | "ERROR: a/IFoo.aidl:2.7-11: " |
| 1275 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 1276 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 1277 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 1278 | if (GetLanguage() != Options::Language::JAVA) { |
| 1279 | expected_stderr = |
| 1280 | "ERROR: a/IFoo.aidl:2.1-7: " |
| 1281 | "Currently, only the Java backend supports non-generic List.\n"; |
| 1282 | } |
| 1283 | |
| 1284 | const string primitive_interface = |
| 1285 | "package a; interface IFoo {\n" |
| 1286 | " List foo(); }"; |
| 1287 | CaptureStderr(); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 1288 | AidlTypenames tn1; |
| 1289 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error, |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1290 | {"--structured"})); |
| 1291 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1292 | |
| 1293 | string primitive_parcelable = |
| 1294 | "package a; parcelable IFoo {\n" |
| 1295 | " List foo;}"; |
| 1296 | CaptureStderr(); |
Jiyong Park | 40782d0 | 2020-07-24 19:17:43 +0900 | [diff] [blame] | 1297 | AidlTypenames tn2; |
| 1298 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error, |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1299 | {"--structured"})); |
| 1300 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1301 | } |
| 1302 | |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1303 | TEST_P(AidlTest, ExtensionTest) { |
| 1304 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1305 | string extendable_parcelable = |
| 1306 | "package a; parcelable Data {\n" |
| 1307 | " ParcelableHolder extension;\n" |
| 1308 | " ParcelableHolder extension2;\n" |
| 1309 | "}"; |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1310 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1311 | EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage())); |
| 1312 | EXPECT_EQ( |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1313 | "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1314 | "yet.\n", |
| 1315 | GetCapturedStderr()); |
| 1316 | } else { |
| 1317 | EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage())); |
| 1318 | EXPECT_EQ("", GetCapturedStderr()); |
| 1319 | } |
| 1320 | } |
| 1321 | TEST_P(AidlTest, ParcelableHolderAsReturnType) { |
| 1322 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1323 | string parcelableholder_return_interface = |
| 1324 | "package a; interface IFoo {\n" |
| 1325 | " ParcelableHolder foo();\n" |
| 1326 | "}"; |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1327 | EXPECT_EQ(nullptr, |
| 1328 | Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage())); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1329 | |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1330 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1331 | EXPECT_EQ( |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1332 | "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n" |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1333 | "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1334 | "yet.\n", |
| 1335 | GetCapturedStderr()); |
| 1336 | return; |
| 1337 | } |
| 1338 | EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n", |
| 1339 | GetCapturedStderr()); |
| 1340 | } |
| 1341 | |
| 1342 | TEST_P(AidlTest, ParcelableHolderAsArgumentType) { |
| 1343 | CaptureStderr(); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1344 | string extendable_parcelable_arg_interface = |
| 1345 | "package a; interface IFoo {\n" |
| 1346 | " void foo(in ParcelableHolder ph);\n" |
| 1347 | "}"; |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1348 | EXPECT_EQ(nullptr, |
| 1349 | Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage())); |
| 1350 | |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1351 | if (GetLanguage() == Options::Language::RUST) { |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1352 | EXPECT_EQ( |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1353 | "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n" |
Jeongik Cha | 8f02a53 | 2020-10-14 00:16:28 +0900 | [diff] [blame] | 1354 | "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder " |
Jeongik Cha | 225519b | 2020-08-29 01:55:32 +0900 | [diff] [blame] | 1355 | "yet.\n", |
| 1356 | GetCapturedStderr()); |
| 1357 | return; |
| 1358 | } |
| 1359 | EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n", |
| 1360 | GetCapturedStderr()); |
Jeongik Cha | 649e8a7 | 2020-03-27 17:47:40 +0900 | [diff] [blame] | 1361 | } |
| 1362 | |
Jeongik Cha | f6ec898 | 2020-10-15 00:10:30 +0900 | [diff] [blame] | 1363 | TEST_P(AidlTest, RejectNullableParcelableHolderField) { |
| 1364 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }"); |
| 1365 | Options options = |
| 1366 | Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage())); |
| 1367 | const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"; |
| 1368 | CaptureStderr(); |
| 1369 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1370 | if (GetLanguage() == Options::Language::RUST) { |
| 1371 | EXPECT_EQ( |
| 1372 | "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n" |
| 1373 | "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder " |
| 1374 | "yet.\n", |
| 1375 | GetCapturedStderr()); |
| 1376 | return; |
| 1377 | } |
| 1378 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1379 | } |
| 1380 | |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1381 | TEST_F(AidlTest, ApiDump) { |
| 1382 | io_delegate_.SetFileContents( |
| 1383 | "foo/bar/IFoo.aidl", |
| 1384 | "package foo.bar;\n" |
| 1385 | "import foo.bar.Data;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1386 | "// comment @hide\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1387 | "interface IFoo {\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1388 | " /* @hide */\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1389 | " int foo(out int[] a, String b, boolean c, inout List<String> d);\n" |
| 1390 | " int foo2(@utf8InCpp String x, inout List<String> y);\n" |
| 1391 | " IFoo foo3(IFoo foo);\n" |
| 1392 | " Data getData();\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1393 | " // @hide\n" |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 1394 | " const int A = 1;\n" |
| 1395 | " const String STR = \"Hello\";\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1396 | "}\n"); |
| 1397 | io_delegate_.SetFileContents("foo/bar/Data.aidl", |
| 1398 | "package foo.bar;\n" |
| 1399 | "import foo.bar.IFoo;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1400 | "/* @hide*/\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1401 | "parcelable Data {\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1402 | " // @hide\n" |
Jiyong Park | a468e2a | 2018-08-29 21:25:18 +0900 | [diff] [blame] | 1403 | " int x = 10;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1404 | " // @hide\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1405 | " int y;\n" |
| 1406 | " IFoo foo;\n" |
| 1407 | " List<IFoo> a;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1408 | " /*@hide2*/\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1409 | " List<foo.bar.IFoo> b;\n" |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1410 | " // It should be @hide property\n" |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 1411 | " @nullable String[] c;\n" |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1412 | "}\n"); |
| 1413 | io_delegate_.SetFileContents("api.aidl", ""); |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 1414 | vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.", |
| 1415 | "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"}; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1416 | Options options = Options::From(args); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1417 | bool result = dump_api(options, io_delegate_); |
| 1418 | ASSERT_TRUE(result); |
| 1419 | string actual; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1420 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1421 | EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar; |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1422 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1423 | interface IFoo { |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1424 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1425 | int foo(out int[] a, String b, boolean c, inout List<String> d); |
| 1426 | int foo2(@utf8InCpp String x, inout List<String> y); |
| 1427 | foo.bar.IFoo foo3(foo.bar.IFoo foo); |
| 1428 | foo.bar.Data getData(); |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1429 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1430 | const int A = 1; |
| 1431 | const String STR = "Hello"; |
| 1432 | } |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1433 | )")); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1434 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1435 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual)); |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1436 | EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar; |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1437 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1438 | parcelable Data { |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1439 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1440 | int x = 10; |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1441 | /* @hide */ |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1442 | int y; |
| 1443 | foo.bar.IFoo foo; |
| 1444 | List<foo.bar.IFoo> a; |
| 1445 | List<foo.bar.IFoo> b; |
Jeongik Cha | 997281d | 2020-01-16 15:23:59 +0900 | [diff] [blame] | 1446 | /* @hide */ |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 1447 | @nullable String[] c; |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1448 | } |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1449 | )")); |
Jiyong Park | 02da742 | 2018-07-16 16:00:26 +0900 | [diff] [blame] | 1450 | } |
| 1451 | |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1452 | TEST_F(AidlTest, ApiDumpWithManualIds) { |
| 1453 | io_delegate_.SetFileContents( |
| 1454 | "foo/bar/IFoo.aidl", |
| 1455 | "package foo.bar;\n" |
| 1456 | "interface IFoo {\n" |
| 1457 | " int foo() = 1;\n" |
| 1458 | " int bar() = 2;\n" |
| 1459 | " int baz() = 10;\n" |
| 1460 | "}\n"); |
| 1461 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1462 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1463 | Options options = Options::From(args); |
| 1464 | bool result = dump_api(options, io_delegate_); |
| 1465 | ASSERT_TRUE(result); |
| 1466 | string actual; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1467 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1468 | EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1469 | interface IFoo { |
| 1470 | int foo() = 1; |
| 1471 | int bar() = 2; |
| 1472 | int baz() = 10; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1473 | } |
Paul Trautrim | b01451d | 2020-02-27 13:10:16 +0900 | [diff] [blame] | 1474 | )")); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1475 | } |
| 1476 | |
| 1477 | TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1478 | const string expected_stderr = |
| 1479 | "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of " |
| 1480 | "them.\n"; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1481 | io_delegate_.SetFileContents( |
| 1482 | "foo/bar/IFoo.aidl", |
| 1483 | "package foo.bar;\n" |
| 1484 | "interface IFoo {\n" |
| 1485 | " int foo() = 1;\n" |
| 1486 | " int bar();\n" |
| 1487 | " int baz() = 10;\n" |
| 1488 | "}\n"); |
| 1489 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1490 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1491 | Options options = Options::From(args); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1492 | CaptureStderr(); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1493 | EXPECT_FALSE(dump_api(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1494 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 1495 | } |
| 1496 | |
Jooyung Han | 965e31d | 2020-11-27 12:30:16 +0900 | [diff] [blame^] | 1497 | TEST_F(AidlTest, ApiDumpConstWithAnnotation) { |
| 1498 | io_delegate_.SetFileContents("foo/bar/IFoo.aidl", |
| 1499 | "package foo.bar;\n" |
| 1500 | "interface IFoo {\n" |
| 1501 | " @utf8InCpp String foo();\n" |
| 1502 | " const @utf8InCpp String bar = \"bar\";\n" |
| 1503 | "}\n"); |
| 1504 | |
| 1505 | vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"}; |
| 1506 | Options options = Options::From(args); |
| 1507 | CaptureStderr(); |
| 1508 | EXPECT_TRUE(dump_api(options, io_delegate_)); |
| 1509 | EXPECT_EQ("", GetCapturedStderr()); |
| 1510 | string actual; |
| 1511 | EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual)); |
| 1512 | // TODO(b/174327111) dump const with annotations |
| 1513 | EXPECT_EQ(string(kPreamble).append(R"(package foo.bar; |
| 1514 | interface IFoo { |
| 1515 | @utf8InCpp String foo(); |
| 1516 | const String bar = "bar"; |
| 1517 | } |
| 1518 | )"), |
| 1519 | actual); |
| 1520 | } |
| 1521 | |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1522 | TEST_F(AidlTest, CheckNumGenericTypeSecifier) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1523 | const string expected_list_stderr = |
Steven Moreland | ebc3c5d | 2020-09-30 23:40:33 +0000 | [diff] [blame] | 1524 | "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: " |
| 1525 | "'List<String,String>'\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1526 | const string expected_map_stderr = |
| 1527 | "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n"; |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1528 | Options options = Options::From("aidl p/IFoo.aidl IFoo.java"); |
| 1529 | io_delegate_.SetFileContents(options.InputFiles().front(), |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1530 | "package p; interface IFoo {" |
| 1531 | "void foo(List<String, String> a);}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1532 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1533 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1534 | EXPECT_EQ(expected_list_stderr, GetCapturedStderr()); |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1535 | |
Jiyong Park | 6f77e0c | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1536 | io_delegate_.SetFileContents(options.InputFiles().front(), |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1537 | "package p; interface IFoo {" |
| 1538 | "void foo(Map<String> a);}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1539 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1540 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1541 | EXPECT_EQ(expected_map_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1542 | } |
| 1543 | |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1544 | TEST_F(AidlTest, CheckTypeParameterInMapType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1545 | const string expected_stderr = |
| 1546 | "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n"; |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1547 | Options options = Options::From("aidl -I p p/IFoo.aidl"); |
| 1548 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }"); |
| 1549 | |
| 1550 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1551 | "package p; interface IFoo {" |
| 1552 | "Map<String, Bar> foo();}"); |
| 1553 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1554 | |
| 1555 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1556 | "package p; interface IFoo {" |
| 1557 | "Map<Bar, Bar> foo();}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1558 | CaptureStderr(); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1559 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1560 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | e48d994 | 2020-01-02 17:39:00 +0900 | [diff] [blame] | 1561 | |
| 1562 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1563 | "package p; interface IFoo {" |
| 1564 | "Map<String, String> foo();}"); |
| 1565 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1566 | |
| 1567 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1568 | "package p; interface IFoo {" |
| 1569 | "Map<String, ParcelFileDescriptor> foo();}"); |
| 1570 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1571 | } |
| 1572 | |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1573 | TEST_F(AidlTest, WrongGenericType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1574 | const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n"; |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1575 | Options options = Options::From("aidl p/IFoo.aidl IFoo.java"); |
| 1576 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1577 | "package p; interface IFoo {" |
| 1578 | "String<String> foo(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1579 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1580 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1581 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1582 | } |
| 1583 | |
| 1584 | TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) { |
| 1585 | Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl"); |
| 1586 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1587 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1588 | EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1589 | EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n", |
| 1590 | GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1591 | |
| 1592 | Options options = Options::From("aidl -I p p/IFoo.aidl"); |
| 1593 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;"); |
| 1594 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1595 | "package p; interface IFoo {" |
| 1596 | "Bar<String, String> foo();}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1597 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1598 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1599 | EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1600 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1601 | CaptureStderr(); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1602 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1603 | EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n", |
| 1604 | GetCapturedStderr()); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1605 | io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;"); |
| 1606 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1607 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1608 | "package p; interface IFoo {" |
| 1609 | "Bar<String, ParcelFileDescriptor> foo();}"); |
| 1610 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jeongik Cha | e74c86d | 2019-12-12 16:54:03 +0900 | [diff] [blame] | 1611 | |
| 1612 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1613 | "package p; interface IFoo {" |
| 1614 | "Bar<int, long> foo();}"); |
| 1615 | |
| 1616 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 1617 | "package p; interface IFoo {" |
| 1618 | "Bar<int[], long[]> foo();}"); |
| 1619 | |
| 1620 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jeongik Cha | df76dc7 | 2019-11-28 00:08:47 +0900 | [diff] [blame] | 1621 | } |
| 1622 | |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1623 | TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) { |
| 1624 | std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl", |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 1625 | "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl", |
| 1626 | "aidl --lang=rust -o out foo/bar/Foo.aidl"}; |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 1627 | for (const auto& rawOption : rawOptions) { |
| 1628 | string expected_stderr = |
| 1629 | "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n"; |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1630 | Options options = Options::From(rawOption); |
| 1631 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1632 | "package foo.bar;\n" |
| 1633 | "interface IFoo1 { int foo(); }\n" |
| 1634 | "interface IFoo2 { int foo(); }\n" |
| 1635 | "parcelable Data1 { int a; int b;}\n" |
| 1636 | "parcelable Data2 { int a; int b;}\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1637 | CaptureStderr(); |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1638 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1639 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1640 | |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1641 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1642 | "package foo.bar;\n" |
| 1643 | "interface IFoo1 { int foo(); }\n" |
| 1644 | "interface IFoo2 { int foo(); }\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1645 | CaptureStderr(); |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1646 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1647 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1648 | |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 1649 | expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n"; |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1650 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1651 | "package foo.bar;\n" |
| 1652 | "parcelable Data1 { int a; int b;}\n" |
| 1653 | "parcelable Data2 { int a; int b;}\n"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1654 | CaptureStderr(); |
Jeongik Cha | 0e42601 | 2019-07-29 15:57:02 +0900 | [diff] [blame] | 1655 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1656 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1657 | } |
| 1658 | } |
| 1659 | |
Devin Moore | bdba2a8 | 2020-03-31 15:19:02 -0700 | [diff] [blame] | 1660 | TEST_P(AidlTest, FailParseOnEmptyFile) { |
| 1661 | const string contents = ""; |
| 1662 | const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n"; |
| 1663 | CaptureStderr(); |
| 1664 | EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage())); |
| 1665 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1666 | } |
| 1667 | |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1668 | TEST_F(AidlTest, MultipleInputFiles) { |
| 1669 | Options options = Options::From( |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 1670 | "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1671 | |
| 1672 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 1673 | "package foo.bar;\n" |
| 1674 | "import foo.bar.Data;\n" |
| 1675 | "interface IFoo { Data getData(); }\n"); |
| 1676 | |
| 1677 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 1678 | "package foo.bar;\n" |
| 1679 | "import foo.bar.IFoo;\n" |
| 1680 | "parcelable Data { IFoo foo; }\n"); |
| 1681 | |
| 1682 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1683 | |
| 1684 | string content; |
| 1685 | for (const auto file : { |
| 1686 | "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) { |
| 1687 | content.clear(); |
| 1688 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 1689 | EXPECT_FALSE(content.empty()); |
| 1690 | } |
| 1691 | } |
| 1692 | |
| 1693 | TEST_F(AidlTest, MultipleInputFilesCpp) { |
| 1694 | Options options = Options::From("aidl --lang=cpp -o out -h out/include " |
Jiyong Park | 633246c | 2019-11-25 10:50:05 +0900 | [diff] [blame] | 1695 | "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1696 | |
| 1697 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 1698 | "package foo.bar;\n" |
| 1699 | "import foo.bar.Data;\n" |
| 1700 | "interface IFoo { Data getData(); }\n"); |
| 1701 | |
| 1702 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 1703 | "package foo.bar;\n" |
| 1704 | "import foo.bar.IFoo;\n" |
| 1705 | "parcelable Data { IFoo foo; }\n"); |
| 1706 | |
| 1707 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1708 | |
| 1709 | string content; |
| 1710 | for (const auto file : { |
Jiyong Park | b03551f | 2018-08-06 19:20:51 +0900 | [diff] [blame] | 1711 | "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp", |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1712 | "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h", |
| 1713 | "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h", |
| 1714 | "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) { |
| 1715 | content.clear(); |
| 1716 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 1717 | EXPECT_FALSE(content.empty()); |
| 1718 | } |
Jiyong Park | 1d2df7d | 2018-07-23 15:22:50 +0900 | [diff] [blame] | 1719 | } |
| 1720 | |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 1721 | TEST_F(AidlTest, MultipleInputFilesRust) { |
| 1722 | Options options = |
| 1723 | Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl"); |
| 1724 | |
| 1725 | io_delegate_.SetFileContents(options.InputFiles().at(0), |
| 1726 | "package foo.bar;\n" |
| 1727 | "import foo.bar.Data;\n" |
| 1728 | "interface IFoo { Data getData(); }\n"); |
| 1729 | |
| 1730 | io_delegate_.SetFileContents(options.InputFiles().at(1), |
| 1731 | "package foo.bar;\n" |
| 1732 | "import foo.bar.IFoo;\n" |
| 1733 | "parcelable Data { IFoo foo; }\n"); |
| 1734 | |
| 1735 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 1736 | |
| 1737 | string content; |
| 1738 | for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) { |
| 1739 | content.clear(); |
| 1740 | EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content)); |
| 1741 | EXPECT_FALSE(content.empty()); |
| 1742 | } |
| 1743 | } |
| 1744 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1745 | TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) { |
| 1746 | const string expected_stderr = |
| 1747 | "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n"; |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1748 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
| 1749 | // int getInterfaceVersion() is one of the meta transactions |
| 1750 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1751 | "package p; interface IFoo {" |
| 1752 | "int getInterfaceVersion(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1753 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1754 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1755 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1756 | } |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1757 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1758 | TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) { |
| 1759 | // boolean getInterfaceVersion() is not a meta transaction, but should be |
| 1760 | // prevented because return type is not part of a method signature |
| 1761 | const string expected_stderr = |
| 1762 | "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n"; |
| 1763 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1764 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1765 | "package p; interface IFoo {" |
| 1766 | "boolean getInterfaceVersion(); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1767 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1768 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1769 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 1770 | } |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1771 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1772 | TEST_F(AidlTest, ConflictWithMetaTransactionGetName) { |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1773 | // this is another reserved name |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1774 | const string expected_stderr = |
| 1775 | "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n"; |
| 1776 | Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl"); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1777 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1778 | "package p; interface IFoo {" |
| 1779 | "String getTransactionName(int code); }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1780 | CaptureStderr(); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1781 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 1782 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1783 | |
| 1784 | // this is not a meta interface method as it differs type arguments |
| 1785 | io_delegate_.SetFileContents(options.InputFiles().front(), |
| 1786 | "package p; interface IFoo {" |
| 1787 | "String getTransactionName(); }"); |
Jiyong Park | b034bf0 | 2018-07-30 17:44:33 +0900 | [diff] [blame] | 1788 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jiyong Park | 309668e | 2018-07-28 16:55:44 +0900 | [diff] [blame] | 1789 | } |
| 1790 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1791 | TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) { |
Jeongik Cha | 3271ffa | 2018-12-04 15:19:20 +0900 | [diff] [blame] | 1792 | Options options = Options::From("aidl --checkapi old new"); |
| 1793 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 1794 | "package p; interface IFoo{ @utf8InCpp @nullable String foo();}"); |
| 1795 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 1796 | "package p; interface IFoo{ @nullable @utf8InCpp String foo();}"); |
| 1797 | |
| 1798 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 1799 | } |
| 1800 | |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1801 | TEST_F(AidlTest, SuccessOnIdenticalApiDumps) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1802 | Options options = Options::From("aidl --checkapi old new"); |
| 1803 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}"); |
| 1804 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}"); |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1805 | |
| 1806 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 1807 | } |
| 1808 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1809 | class AidlTestCompatibleChanges : public AidlTest { |
| 1810 | protected: |
| 1811 | Options options_ = Options::From("aidl --checkapi old new"); |
| 1812 | }; |
| 1813 | |
| 1814 | TEST_F(AidlTestCompatibleChanges, NewType) { |
| 1815 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 1816 | "package p;" |
| 1817 | "interface IFoo {" |
| 1818 | " void foo(int a);" |
| 1819 | "}"); |
| 1820 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 1821 | "package p;" |
| 1822 | "interface IFoo {" |
| 1823 | " void foo(int a);" |
| 1824 | "}"); |
| 1825 | io_delegate_.SetFileContents("new/p/IBar.aidl", |
| 1826 | "package p;" |
| 1827 | "interface IBar {" |
| 1828 | " void bar();" |
| 1829 | "}"); |
| 1830 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1831 | } |
| 1832 | |
| 1833 | TEST_F(AidlTestCompatibleChanges, NewMethod) { |
| 1834 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 1835 | "package p;" |
| 1836 | "interface IFoo {" |
| 1837 | " void foo(int a);" |
| 1838 | "}"); |
| 1839 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 1840 | "package p;" |
| 1841 | "interface IFoo {" |
| 1842 | " void foo(int a);" |
| 1843 | " void bar();" |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1844 | " void baz(in List<IFoo> arg);" |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1845 | "}"); |
| 1846 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1847 | } |
| 1848 | |
| 1849 | TEST_F(AidlTestCompatibleChanges, NewField) { |
| 1850 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 1851 | "package p;" |
| 1852 | "parcelable Data {" |
| 1853 | " int foo;" |
| 1854 | "}"); |
| 1855 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 1856 | "package p;" |
| 1857 | "parcelable Data {" |
| 1858 | " int foo;" |
Steven Moreland | 370ed34 | 2020-04-28 18:14:39 -0700 | [diff] [blame] | 1859 | " int bar = 0;" |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 1860 | " @nullable List<Data> list;" |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1861 | "}"); |
| 1862 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1863 | } |
| 1864 | |
| 1865 | TEST_F(AidlTestCompatibleChanges, NewEnumerator) { |
| 1866 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 1867 | "package p;" |
| 1868 | "enum Enum {" |
| 1869 | " FOO = 1," |
| 1870 | "}"); |
| 1871 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 1872 | "package p;" |
| 1873 | "enum Enum {" |
| 1874 | " FOO = 1," |
| 1875 | " BAR = 2," |
| 1876 | "}"); |
| 1877 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1878 | } |
| 1879 | |
| 1880 | TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) { |
| 1881 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 1882 | "package p;" |
| 1883 | "enum Enum {" |
| 1884 | " FOO = 1," |
| 1885 | " BAR = 2," |
| 1886 | "}"); |
| 1887 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 1888 | "package p;" |
| 1889 | "enum Enum {" |
| 1890 | " BAR = 2," |
| 1891 | " FOO = 1," |
| 1892 | "}"); |
| 1893 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1894 | } |
| 1895 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 1896 | TEST_F(AidlTestCompatibleChanges, NewUnionField) { |
| 1897 | io_delegate_.SetFileContents("old/p/Union.aidl", |
| 1898 | "package p;" |
| 1899 | "union Union {" |
| 1900 | " String foo;" |
| 1901 | "}"); |
| 1902 | io_delegate_.SetFileContents("new/p/Union.aidl", |
| 1903 | "package p;" |
| 1904 | "union Union {" |
| 1905 | " String foo;" |
| 1906 | " int num;" |
| 1907 | "}"); |
| 1908 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1909 | } |
| 1910 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1911 | TEST_F(AidlTestCompatibleChanges, NewPackage) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1912 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 1913 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1914 | "interface IFoo {" |
| 1915 | " void foo(int a);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1916 | "}"); |
| 1917 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 1918 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1919 | "parcelable Data {" |
| 1920 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1921 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1922 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 1923 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1924 | "interface IFoo {" |
| 1925 | " void foo(int a);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1926 | "}"); |
| 1927 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 1928 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1929 | "parcelable Data {" |
| 1930 | " int foo;" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1931 | "}"); |
| 1932 | io_delegate_.SetFileContents("new/q/IFoo.aidl", |
| 1933 | "package q;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1934 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1935 | " void foo(int a);" |
| 1936 | "}"); |
| 1937 | io_delegate_.SetFileContents("new/q/Data.aidl", |
| 1938 | "package q;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1939 | "parcelable Data {" |
| 1940 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1941 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1942 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1943 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1944 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1945 | TEST_F(AidlTestCompatibleChanges, ArgNameChange) { |
| 1946 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 1947 | "package p;" |
| 1948 | "interface IFoo {" |
| 1949 | " void foo(int a);" |
| 1950 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1951 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 1952 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1953 | "interface IFoo {" |
| 1954 | " void foo(int b);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1955 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1956 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1957 | } |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1958 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1959 | TEST_F(AidlTestCompatibleChanges, AddedConstValue) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1960 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 1961 | "package p; interface I {" |
| 1962 | "const int A = 1; }"); |
| 1963 | io_delegate_.SetFileContents("new/p/I.aidl", |
| 1964 | "package p ; interface I {" |
| 1965 | "const int A = 1; const int B = 2;}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1966 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1967 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 1968 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1969 | TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) { |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 1970 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 1971 | "package p; interface I {" |
| 1972 | "const int A = 1; const int B = 2;}"); |
| 1973 | io_delegate_.SetFileContents("new/p/I.aidl", |
| 1974 | "package p ; interface I {" |
| 1975 | "const int B = 2; const int A = 1;}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 1976 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 1977 | } |
| 1978 | |
Jooyung Han | 69ea4ba | 2020-10-29 15:33:37 +0900 | [diff] [blame] | 1979 | TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) { |
| 1980 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 1981 | "package p;" |
| 1982 | "@JavaPassthrough(annotation=\"Alice\")" |
| 1983 | "@JavaPassthrough(annotation=\"Bob\")" |
| 1984 | "parcelable Foo {}"); |
| 1985 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 1986 | "package p;" |
| 1987 | "@JavaPassthrough(annotation=\"Bob\")" |
| 1988 | "@JavaPassthrough(annotation=\"Alice\")" |
| 1989 | "parcelable Foo {}"); |
| 1990 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 1991 | } |
| 1992 | |
Jooyung Han | 636fd2f | 2020-10-22 11:33:45 +0900 | [diff] [blame] | 1993 | TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) { |
| 1994 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 1995 | "package p;" |
| 1996 | "parcelable Data {" |
| 1997 | " int num;" |
| 1998 | "}"); |
| 1999 | io_delegate_.SetFileContents( |
| 2000 | "new/p/Data.aidl", |
| 2001 | "package p;" |
| 2002 | "parcelable Data {" |
| 2003 | " int num;" |
| 2004 | " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type |
| 2005 | "}"); |
| 2006 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2007 | "package p;" |
| 2008 | "enum Enum {" |
| 2009 | " FOO = 0," |
| 2010 | " BAR = 1," |
| 2011 | "}"); |
| 2012 | EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_)); |
| 2013 | } |
| 2014 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2015 | class AidlTestIncompatibleChanges : public AidlTest { |
| 2016 | protected: |
| 2017 | Options options_ = Options::From("aidl --checkapi old new"); |
| 2018 | }; |
| 2019 | |
| 2020 | TEST_F(AidlTestIncompatibleChanges, RemovedType) { |
Jiyong Park | 0cf03b1 | 2020-07-22 19:36:34 +0900 | [diff] [blame] | 2021 | const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2022 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2023 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2024 | "interface IFoo {" |
| 2025 | " void foo(in String[] str);" |
| 2026 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2027 | "}"); |
Devin Moore | d131d5e | 2020-03-31 10:39:10 -0700 | [diff] [blame] | 2028 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2029 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | d131d5e | 2020-03-31 10:39:10 -0700 | [diff] [blame] | 2030 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2031 | } |
| 2032 | |
| 2033 | TEST_F(AidlTestIncompatibleChanges, RemovedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2034 | const string expected_stderr = |
| 2035 | "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2036 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2037 | "package p;" |
| 2038 | "interface IFoo {" |
| 2039 | " void foo(in String[] str);" |
| 2040 | " void bar(@utf8InCpp String str);" |
| 2041 | "}"); |
| 2042 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2043 | "package p;" |
| 2044 | "interface IFoo {" |
| 2045 | " void foo(in String[] str);" |
| 2046 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2047 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2048 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2049 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2050 | } |
| 2051 | |
Jiyong Park | f8d5361 | 2020-05-04 14:06:13 +0900 | [diff] [blame] | 2052 | TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) { |
| 2053 | const string expected_stderr = |
| 2054 | "ERROR: new/p/IFoo.aidl:1.61-65: " |
| 2055 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 2056 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 2057 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 2058 | "ERROR: new/p/IFoo.aidl: Failed to read.\n"; |
| 2059 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2060 | "package p;" |
| 2061 | "interface IFoo {" |
| 2062 | " void foo(in String[] str);" |
| 2063 | "}"); |
| 2064 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2065 | "package p;" |
| 2066 | "interface IFoo {" |
| 2067 | " void foo(in String[] str);" |
| 2068 | " void bar(in List arg);" |
| 2069 | "}"); |
| 2070 | CaptureStderr(); |
| 2071 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2072 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2073 | } |
| 2074 | |
| 2075 | TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) { |
| 2076 | const string expected_stderr = |
| 2077 | "ERROR: new/p/Data.aidl:1.54-59: " |
| 2078 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 2079 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 2080 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 2081 | "ERROR: new/p/Data.aidl: Failed to read.\n"; |
| 2082 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2083 | "package p;" |
| 2084 | "parcelable Data {" |
| 2085 | " int foo;" |
| 2086 | "}"); |
| 2087 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2088 | "package p;" |
| 2089 | "parcelable Data {" |
| 2090 | " int foo;" |
| 2091 | " @nullable List list;" |
| 2092 | "}"); |
| 2093 | CaptureStderr(); |
| 2094 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2095 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2096 | } |
| 2097 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2098 | TEST_F(AidlTestIncompatibleChanges, RemovedField) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2099 | const string expected_stderr = |
| 2100 | "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2101 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2102 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2103 | "parcelable Data {" |
| 2104 | " int foo;" |
| 2105 | " int bar;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2106 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2107 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2108 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2109 | "parcelable Data {" |
| 2110 | " int foo;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2111 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2112 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2113 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2114 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2115 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2116 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2117 | TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) { |
| 2118 | const string expected_stderr = |
| 2119 | "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some " |
| 2120 | "backends. Please either provide a default value for this field or mark the field as " |
| 2121 | "@nullable. This value or a null value will be used automatically when an old version of " |
| 2122 | "this parcelable is sent to a process which understands a new version of this parcelable. In " |
| 2123 | "order to make sure your code continues to be backwards compatible, make sure the default or " |
| 2124 | "null value does not cause a semantic change to this parcelable.\n"; |
| 2125 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2126 | "package p;" |
| 2127 | "parcelable Data {" |
| 2128 | " int num;" |
| 2129 | "}"); |
| 2130 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2131 | "package p;" |
| 2132 | "parcelable Data {" |
| 2133 | " int num;" |
| 2134 | " String str;" |
| 2135 | "}"); |
| 2136 | CaptureStderr(); |
| 2137 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2138 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2139 | } |
| 2140 | |
Jooyung Han | 636fd2f | 2020-10-22 11:33:45 +0900 | [diff] [blame] | 2141 | TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) { |
| 2142 | const string expected_stderr = |
| 2143 | "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. " |
| 2144 | "Please make sure 'Enum' has '0' as a valid value.\n"; |
| 2145 | io_delegate_.SetFileContents("old/p/Data.aidl", |
| 2146 | "package p;" |
| 2147 | "parcelable Data {" |
| 2148 | " int num;" |
| 2149 | "}"); |
| 2150 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2151 | "package p;" |
| 2152 | "parcelable Data {" |
| 2153 | " int num;" |
| 2154 | " p.Enum e;" |
| 2155 | "}"); |
| 2156 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2157 | "package p;" |
| 2158 | "enum Enum {" |
| 2159 | " FOO = 1," |
| 2160 | " BAR = 2," |
| 2161 | "}"); |
| 2162 | CaptureStderr(); |
| 2163 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2164 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2165 | } |
| 2166 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2167 | TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2168 | const string expected_stderr = |
| 2169 | "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2170 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2171 | "package p;" |
| 2172 | "enum Enum {" |
| 2173 | " FOO = 1," |
| 2174 | " BAR = 2," |
| 2175 | "}"); |
| 2176 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2177 | "package p;" |
| 2178 | "enum Enum {" |
| 2179 | " BAR = 2," |
| 2180 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2181 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2182 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2183 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2184 | } |
| 2185 | |
Jooyung Han | b5c55cd | 2020-10-22 07:59:01 +0900 | [diff] [blame] | 2186 | TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) { |
| 2187 | const string expected_stderr = |
| 2188 | "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n"; |
| 2189 | io_delegate_.SetFileContents("old/p/Union.aidl", |
| 2190 | "package p;" |
| 2191 | "union Union {" |
| 2192 | " String str;" |
| 2193 | " int num;" |
| 2194 | "}"); |
| 2195 | io_delegate_.SetFileContents("new/p/Union.aidl", |
| 2196 | "package p;" |
| 2197 | "union Union {" |
| 2198 | " String str;" |
| 2199 | "}"); |
| 2200 | CaptureStderr(); |
| 2201 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2202 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2203 | } |
| 2204 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2205 | TEST_F(AidlTestIncompatibleChanges, RenamedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2206 | const string expected_stderr = |
| 2207 | "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2208 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2209 | "package p;" |
| 2210 | "interface IFoo {" |
| 2211 | " void foo(in String[] str);" |
| 2212 | " void bar(@utf8InCpp String str);" |
| 2213 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2214 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2215 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2216 | "interface IFoo {" |
| 2217 | " void foo(in String[] str);" |
| 2218 | " void bar2(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2219 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2220 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2221 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2222 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2223 | } |
| 2224 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2225 | TEST_F(AidlTestIncompatibleChanges, RenamedType) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2226 | const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2227 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2228 | "package p;" |
| 2229 | "interface IFoo {" |
| 2230 | " void foo(in String[] str);" |
| 2231 | " void bar(@utf8InCpp String str);" |
| 2232 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2233 | io_delegate_.SetFileContents("new/p/IFoo2.aidl", |
| 2234 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2235 | "interface IFoo2 {" |
| 2236 | " void foo(in String[] str);" |
| 2237 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2238 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2239 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2240 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2241 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2242 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2243 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2244 | TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2245 | const string expected_stderr = |
| 2246 | "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2247 | io_delegate_.SetFileContents("old/p/Enum.aidl", |
| 2248 | "package p;" |
| 2249 | "enum Enum {" |
| 2250 | " FOO = 1," |
| 2251 | " BAR = 2," |
| 2252 | "}"); |
| 2253 | io_delegate_.SetFileContents("new/p/Enum.aidl", |
| 2254 | "package p;" |
| 2255 | "enum Enum {" |
| 2256 | " FOO = 3," |
| 2257 | " BAR = 2," |
| 2258 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2259 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2260 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2261 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2262 | } |
| 2263 | |
| 2264 | TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2265 | const string expected_stderr = |
| 2266 | "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed " |
| 2267 | "from 0 to 1.\n" |
| 2268 | "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from " |
| 2269 | "1 to 0.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2270 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2271 | "package p;" |
| 2272 | "interface IFoo {" |
| 2273 | " void foo(in String[] str);" |
| 2274 | " void bar(@utf8InCpp String str);" |
| 2275 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2276 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2277 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2278 | "interface IFoo {" |
| 2279 | " void bar(@utf8InCpp String str);" |
| 2280 | " void foo(in String[] str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2281 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2282 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2283 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2284 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2285 | } |
| 2286 | |
| 2287 | TEST_F(AidlTestIncompatibleChanges, ReorderedField) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2288 | const string expected_stderr = |
Jiyong Park | b07d993 | 2020-05-15 12:56:54 +0900 | [diff] [blame] | 2289 | "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n" |
| 2290 | "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2291 | io_delegate_.SetFileContents("old/p/Data.aidl", |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2292 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2293 | "parcelable Data {" |
| 2294 | " int foo;" |
| 2295 | " int bar;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2296 | "}"); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2297 | io_delegate_.SetFileContents("new/p/Data.aidl", |
| 2298 | "package p;" |
| 2299 | "parcelable Data {" |
| 2300 | " int bar;" |
| 2301 | " int foo;" |
| 2302 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2303 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2304 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2305 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2306 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2307 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2308 | TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) { |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2309 | const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2310 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2311 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2312 | "interface IFoo {" |
| 2313 | " void foo(in String[] str);" |
| 2314 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2315 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2316 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2317 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2318 | "interface IFoo {" |
| 2319 | " void foo(out String[] str);" |
| 2320 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2321 | "}"); |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2322 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2323 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | eccdb90 | 2020-03-24 16:22:40 -0700 | [diff] [blame] | 2324 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2325 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2326 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2327 | TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2328 | const string expected_stderr = |
| 2329 | "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2330 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2331 | "package p;" |
| 2332 | "interface IFoo {" |
| 2333 | " void foo(in String[] str);" |
| 2334 | " void bar(@utf8InCpp String str);" |
| 2335 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2336 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2337 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2338 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2339 | " void foo(in @utf8InCpp String[] str);" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2340 | " void bar(@utf8InCpp String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2341 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2342 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2343 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2344 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2345 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2346 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2347 | TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2348 | const string expected_stderr = |
| 2349 | "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n"; |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2350 | io_delegate_.SetFileContents("old/p/IFoo.aidl", |
| 2351 | "package p;" |
| 2352 | "interface IFoo {" |
| 2353 | " void foo(in String[] str);" |
| 2354 | " void bar(@utf8InCpp String str);" |
| 2355 | "}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2356 | io_delegate_.SetFileContents("new/p/IFoo.aidl", |
| 2357 | "package p;" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2358 | "interface IFoo {" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2359 | " void foo(in String[] str);" |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2360 | " void bar(String str);" |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2361 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2362 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2363 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2364 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2365 | } |
Jiyong Park | 3656c3c | 2018-08-01 20:02:01 +0900 | [diff] [blame] | 2366 | |
Jooyung Han | 60b2fde | 2020-10-29 15:12:40 +0900 | [diff] [blame] | 2367 | TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) { |
| 2368 | const string expected_stderr = |
| 2369 | "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n" |
| 2370 | "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n"; |
| 2371 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2372 | "package p;" |
| 2373 | "@Backing(type=\"byte\")" |
| 2374 | "enum Foo {" |
| 2375 | " FOO, BAR," |
| 2376 | "}"); |
| 2377 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2378 | "package p;" |
| 2379 | "@Backing(type=\"long\")" |
| 2380 | "enum Foo {" |
| 2381 | " FOO, BAR," |
| 2382 | "}"); |
| 2383 | CaptureStderr(); |
| 2384 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2385 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2386 | } |
| 2387 | |
Jooyung Han | 69ea4ba | 2020-10-29 15:33:37 +0900 | [diff] [blame] | 2388 | TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) { |
| 2389 | const string expected_stderr = |
| 2390 | "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") " |
| 2391 | "to @JavaPassthrough(annotation=\"Bob\")\n"; |
| 2392 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2393 | "package p;" |
| 2394 | "@JavaPassthrough(annotation=\"Alice\")" |
| 2395 | "parcelable Foo {}"); |
| 2396 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2397 | "package p;" |
| 2398 | "@JavaPassthrough(annotation=\"Bob\")" |
| 2399 | "parcelable Foo {}"); |
| 2400 | |
| 2401 | CaptureStderr(); |
| 2402 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2403 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2404 | } |
| 2405 | |
Devin Moore | db7ac51 | 2020-08-07 11:17:36 -0700 | [diff] [blame] | 2406 | TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) { |
| 2407 | const string expected_stderr = |
| 2408 | "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n"; |
| 2409 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2410 | "package p;" |
| 2411 | "parcelable Foo {" |
| 2412 | " int A;" |
| 2413 | "}"); |
| 2414 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2415 | "package p;" |
| 2416 | "@JavaOnlyStableParcelable parcelable Foo {" |
| 2417 | " int A;" |
| 2418 | "}"); |
| 2419 | CaptureStderr(); |
| 2420 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2421 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2422 | } |
| 2423 | |
| 2424 | TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) { |
| 2425 | const string expected_stderr = |
| 2426 | "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n"; |
| 2427 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2428 | "package p;" |
| 2429 | "@JavaOnlyStableParcelable parcelable Foo {" |
| 2430 | " int A;" |
| 2431 | "}"); |
| 2432 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2433 | "package p;" |
| 2434 | "parcelable Foo {" |
| 2435 | " int A;" |
| 2436 | "}"); |
| 2437 | CaptureStderr(); |
| 2438 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2439 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2440 | } |
| 2441 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2442 | TEST_F(AidlTestIncompatibleChanges, RemovedPackage) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2443 | const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2444 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}"); |
| 2445 | io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}"); |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2446 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2447 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2448 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2449 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2450 | } |
Jiyong Park | a468e2a | 2018-08-29 21:25:18 +0900 | [diff] [blame] | 2451 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2452 | TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) { |
Steven Moreland | 370ed34 | 2020-04-28 18:14:39 -0700 | [diff] [blame] | 2453 | const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2454 | io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }"); |
| 2455 | io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2456 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2457 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2458 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2459 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 2460 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2461 | TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2462 | const string expected_stderr = |
| 2463 | "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2464 | io_delegate_.SetFileContents("old/p/I.aidl", |
| 2465 | "package p; interface I {" |
| 2466 | "const int A = 1; const int B = 2;}"); |
| 2467 | io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2468 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2469 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2470 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2471 | } |
Jiyong Park | a428d21 | 2018-08-29 22:26:30 +0900 | [diff] [blame] | 2472 | |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2473 | TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2474 | const string expected_stderr = |
| 2475 | "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2476 | io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }"); |
| 2477 | io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2478 | CaptureStderr(); |
Daniel Norman | 85aed54 | 2019-08-21 12:01:14 -0700 | [diff] [blame] | 2479 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2480 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3c35e39 | 2018-08-30 13:10:30 +0900 | [diff] [blame] | 2481 | } |
| 2482 | |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 2483 | TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) { |
| 2484 | const string expected_stderr = |
| 2485 | "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. " |
| 2486 | "This is an incompatible change for FixedSize types.\n"; |
| 2487 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2488 | "package p; @FixedSize parcelable Foo { int A = 1; }"); |
| 2489 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2490 | "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }"); |
| 2491 | CaptureStderr(); |
| 2492 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2493 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2494 | } |
| 2495 | |
| 2496 | TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) { |
| 2497 | const string expected_stderr = |
| 2498 | "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n"; |
| 2499 | io_delegate_.SetFileContents("old/p/Foo.aidl", |
| 2500 | "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }"); |
| 2501 | io_delegate_.SetFileContents("new/p/Foo.aidl", |
| 2502 | "package p; @FixedSize parcelable Foo { int A = 1; }"); |
| 2503 | CaptureStderr(); |
| 2504 | EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_)); |
| 2505 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2506 | } |
| 2507 | |
| 2508 | TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) { |
| 2509 | const string expected_stderr = |
| 2510 | "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2511 | "a.\n" |
| 2512 | "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2513 | "b.\n" |
| 2514 | "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2515 | "c.\n" |
| 2516 | "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2517 | "d.\n" |
| 2518 | "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2519 | "e.\n" |
| 2520 | "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named " |
| 2521 | "f.\n"; |
| 2522 | |
| 2523 | io_delegate_.SetFileContents("Foo.aidl", |
| 2524 | "@FixedSize parcelable Foo { " |
| 2525 | " int[] a;" |
| 2526 | " Bar b;" |
| 2527 | " String c;" |
| 2528 | " ParcelFileDescriptor d;" |
| 2529 | " IBinder e;" |
| 2530 | " List<String> f;" |
Steven Moreland | 265f3d4 | 2020-09-24 19:06:54 +0000 | [diff] [blame] | 2531 | " int isFixedSize;" |
Devin Moore | c7e47a3 | 2020-08-07 10:55:25 -0700 | [diff] [blame] | 2532 | "}"); |
| 2533 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }"); |
| 2534 | Options options = |
| 2535 | Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage())); |
| 2536 | |
| 2537 | CaptureStderr(); |
| 2538 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2539 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2540 | } |
| 2541 | |
| 2542 | TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) { |
| 2543 | const string expected_stderr = ""; |
| 2544 | |
| 2545 | io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }"); |
| 2546 | io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }"); |
| 2547 | io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }"); |
| 2548 | Options options = |
| 2549 | Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage())); |
| 2550 | |
| 2551 | CaptureStderr(); |
| 2552 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2553 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2554 | } |
| 2555 | |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2556 | TEST_F(AidlTest, RejectAmbiguousImports) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2557 | const string expected_stderr = |
| 2558 | "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n" |
| 2559 | "dir1/q/IBar.aidl\n" |
| 2560 | "dir2/q/IBar.aidl\n" |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 2561 | "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n"; |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2562 | Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl"); |
| 2563 | io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}"); |
| 2564 | io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}"); |
| 2565 | io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}"); |
| 2566 | |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2567 | CaptureStderr(); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2568 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2569 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 8c38053 | 2018-08-30 14:55:26 +0900 | [diff] [blame] | 2570 | } |
| 2571 | |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2572 | TEST_F(AidlTest, HandleManualIdAssignments) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2573 | const string expected_stderr = |
| 2574 | "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to " |
| 2575 | "11.\n"; |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2576 | Options options = Options::From("aidl --checkapi old new"); |
| 2577 | io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}"); |
| 2578 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}"); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2579 | |
| 2580 | EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_)); |
| 2581 | |
Jiyong Park | e59c368 | 2018-09-11 23:10:25 +0900 | [diff] [blame] | 2582 | io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2583 | CaptureStderr(); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2584 | EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2585 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2586 | } |
| 2587 | |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2588 | TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) { |
| 2589 | Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl"); |
| 2590 | Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl"); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2591 | Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl"); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2592 | |
| 2593 | // use without import |
| 2594 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2595 | "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}"); |
| 2596 | EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_)); |
| 2597 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2598 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_)); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2599 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2600 | // use without import but with full name |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2601 | io_delegate_.SetFileContents( |
| 2602 | "p/IFoo.aidl", |
| 2603 | "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}"); |
| 2604 | EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_)); |
| 2605 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2606 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_)); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2607 | |
| 2608 | // use with import (as before) |
| 2609 | io_delegate_.SetFileContents("p/IFoo.aidl", |
| 2610 | "package p;" |
| 2611 | "import android.os.ParcelFileDescriptor;" |
| 2612 | "interface IFoo{" |
| 2613 | " void foo(in ParcelFileDescriptor fd);" |
| 2614 | "}"); |
| 2615 | EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_)); |
| 2616 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2617 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_)); |
Jiyong Park | e05195e | 2018-10-08 18:24:23 +0900 | [diff] [blame] | 2618 | } |
Jiyong Park | ed65bf4 | 2018-08-28 15:43:27 +0900 | [diff] [blame] | 2619 | |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2620 | TEST_F(AidlTest, ManualIds) { |
| 2621 | Options options = Options::From("aidl --lang=java -o out IFoo.aidl"); |
| 2622 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2623 | "interface IFoo {\n" |
| 2624 | " void foo() = 0;\n" |
| 2625 | " void bar() = 1;\n" |
| 2626 | "}"); |
| 2627 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2628 | } |
| 2629 | |
| 2630 | TEST_F(AidlTest, ManualIdsWithMetaTransactions) { |
| 2631 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2632 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2633 | "interface IFoo {\n" |
| 2634 | " void foo() = 0;\n" |
| 2635 | " void bar() = 1;\n" |
| 2636 | "}"); |
| 2637 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2638 | } |
| 2639 | |
| 2640 | TEST_F(AidlTest, FailOnDuplicatedIds) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2641 | const string expected_stderr = |
| 2642 | "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2643 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2644 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2645 | "interface IFoo {\n" |
| 2646 | " void foo() = 3;\n" |
| 2647 | " void bar() = 3;\n" |
| 2648 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2649 | CaptureStderr(); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2650 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2651 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2652 | } |
| 2653 | |
| 2654 | TEST_F(AidlTest, FailOnOutOfRangeIds) { |
| 2655 | // 16777115 is kLastMetaMethodId + 1 |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2656 | const string expected_stderr = |
| 2657 | "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. " |
| 2658 | "Value for id must be between 0 and 16777114 inclusive.\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2659 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2660 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2661 | "interface IFoo {\n" |
| 2662 | " void foo() = 3;\n" |
| 2663 | " void bar() = 16777115;\n" |
| 2664 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2665 | CaptureStderr(); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2666 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2667 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2668 | } |
| 2669 | |
| 2670 | TEST_F(AidlTest, FailOnPartiallyAssignedIds) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2671 | const string expected_stderr = |
| 2672 | "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n"; |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2673 | Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl"); |
| 2674 | io_delegate_.SetFileContents("IFoo.aidl", |
| 2675 | "interface IFoo {\n" |
| 2676 | " void foo() = 3;\n" |
| 2677 | " void bar();\n" |
| 2678 | "}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2679 | CaptureStderr(); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2680 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2681 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | 3633b72 | 2019-04-11 15:38:26 +0900 | [diff] [blame] | 2682 | } |
| 2683 | |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2684 | TEST_F(AidlTest, AllowDuplicatedImportPaths) { |
| 2685 | Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl"); |
| 2686 | io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}"); |
| 2687 | io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}"); |
| 2688 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2689 | } |
| 2690 | |
| 2691 | TEST_F(AidlTest, FailOnAmbiguousImports) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2692 | const string expected_stderr = |
| 2693 | "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n" |
| 2694 | "dir/IBar.aidl\n" |
| 2695 | "dir2/IBar.aidl\n" |
Devin Moore | 5de18ed | 2020-04-02 13:52:29 -0700 | [diff] [blame] | 2696 | "ERROR: IFoo.aidl: Couldn't find import for class IBar\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2697 | |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2698 | Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl"); |
| 2699 | io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}"); |
| 2700 | io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}"); |
| 2701 | io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}"); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2702 | CaptureStderr(); |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2703 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2704 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jiyong Park | c681625 | 2019-07-08 08:12:28 +0900 | [diff] [blame] | 2705 | } |
| 2706 | |
Jiyong Park | f1f5c80 | 2020-05-19 17:33:00 +0900 | [diff] [blame] | 2707 | TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) { |
| 2708 | io_delegate_.SetFileContents("a/b/IFoo.aidl", |
| 2709 | "package a.b;\n" |
| 2710 | "import a.b.IBar;\n" |
| 2711 | "import a.b.IQux;\n" |
| 2712 | "interface IFoo { IQux foo(); }\n"); |
| 2713 | io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }"); |
| 2714 | io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }"); |
| 2715 | |
| 2716 | Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include"); |
| 2717 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2718 | |
| 2719 | string output; |
| 2720 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output)); |
| 2721 | // IBar was imported but wasn't used. include is not expected. |
| 2722 | EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>"))); |
| 2723 | // IBar was imported and used. include is expected. |
| 2724 | EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>"))); |
| 2725 | } |
| 2726 | |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2727 | TEST_F(AidlTest, ParseJavaPassthroughAnnotation) { |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2728 | io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a; |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2729 | import a.MyEnum; |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2730 | @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)") |
| 2731 | @JavaPassthrough(annotation="@com.android.AliceTwo") |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2732 | interface IFoo { |
| 2733 | @JavaPassthrough(annotation="@com.android.Bob") |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2734 | void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y); |
Jiyong Park | 7c3b0e4 | 2020-08-04 16:08:32 +0900 | [diff] [blame] | 2735 | const @JavaPassthrough(annotation="@com.android.David") int A = 3; |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2736 | })--"); |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2737 | // JavaPassthrough should work with other types as well (e.g. enum) |
| 2738 | io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a; |
| 2739 | @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)") |
| 2740 | @JavaPassthrough(annotation="@com.android.AliceTwo") |
| 2741 | @Backing(type="byte") |
| 2742 | enum MyEnum { |
| 2743 | a, b, c |
| 2744 | })--"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2745 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2746 | Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2747 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 2748 | |
| 2749 | string java_out; |
| 2750 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out)); |
Jooyung Han | e6bc5e1 | 2020-10-13 10:57:10 +0900 | [diff] [blame] | 2751 | // type-decl-level annotations with newline at the end |
| 2752 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n")); |
| 2753 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n")); |
| 2754 | // member-decl-level annotations with newline at the end |
| 2755 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n")); |
| 2756 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n")); |
| 2757 | // inline annotations with space at the end |
| 2758 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat ")); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2759 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2760 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out)); |
| 2761 | // type-decl-level annotations with newline at the end |
| 2762 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n")); |
| 2763 | EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n")); |
| 2764 | |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2765 | // Other backends shouldn't be bothered |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2766 | Options cpp_options = |
| 2767 | Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2768 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
| 2769 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2770 | Options ndk_options = |
| 2771 | Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl"); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2772 | EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_)); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2773 | |
Jooyung Han | 4cde01d | 2020-10-13 11:10:47 +0900 | [diff] [blame] | 2774 | Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl"); |
Andrei Homescu | b62afd9 | 2020-05-11 19:24:59 -0700 | [diff] [blame] | 2775 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_)); |
Jiyong Park | bf5fd5c | 2020-06-05 19:48:05 +0900 | [diff] [blame] | 2776 | } |
| 2777 | |
Andrei Homescu | e61feb5 | 2020-08-18 15:44:24 -0700 | [diff] [blame] | 2778 | TEST_F(AidlTest, ParseRustDerive) { |
| 2779 | io_delegate_.SetFileContents("a/Foo.aidl", R"(package a; |
| 2780 | @RustDerive(Clone=true, Copy=false) |
| 2781 | parcelable Foo { |
| 2782 | int a; |
| 2783 | })"); |
| 2784 | |
| 2785 | Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl"); |
| 2786 | EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_)); |
| 2787 | |
| 2788 | string rust_out; |
| 2789 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out)); |
| 2790 | EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]")); |
| 2791 | |
| 2792 | // Other backends shouldn't be bothered |
| 2793 | Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl"); |
| 2794 | EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_)); |
| 2795 | |
| 2796 | Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl"); |
| 2797 | EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_)); |
| 2798 | |
| 2799 | Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl"); |
| 2800 | EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_)); |
| 2801 | } |
| 2802 | |
Jiyong Park | 56f73d7 | 2019-06-11 12:20:28 +0900 | [diff] [blame] | 2803 | class AidlOutputPathTest : public AidlTest { |
| 2804 | protected: |
| 2805 | void SetUp() override { |
| 2806 | AidlTest::SetUp(); |
| 2807 | io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}"); |
| 2808 | } |
| 2809 | |
| 2810 | void Test(const Options& options, const std::string expected_output_path) { |
| 2811 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2812 | // check the existence |
| 2813 | EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr)); |
| 2814 | } |
| 2815 | }; |
| 2816 | |
| 2817 | TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) { |
| 2818 | // <out_dir> / <package_name> / <type_name>.java |
| 2819 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java"); |
| 2820 | } |
| 2821 | |
| 2822 | TEST_F(AidlOutputPathTest, OutDirWithOutputFile) { |
| 2823 | // when output file is explicitly set, it is always respected. -o option is |
| 2824 | // ignored. |
| 2825 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java"); |
| 2826 | } |
| 2827 | |
| 2828 | TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) { |
| 2829 | Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java"); |
| 2830 | } |
| 2831 | |
| 2832 | TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) { |
| 2833 | // output is the same as the input file except for the suffix |
| 2834 | Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java"); |
| 2835 | } |
| 2836 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2837 | TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2838 | AidlError error; |
| 2839 | const string expected_stderr = |
| 2840 | "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n"; |
| 2841 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 2842 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 2843 | R"(package p; |
| 2844 | interface IFoo { |
| 2845 | const int int32_max_oob = 2147483650; |
| 2846 | } |
| 2847 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2848 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2849 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2850 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 2851 | } |
| 2852 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2853 | TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2854 | AidlError error; |
| 2855 | const string expected_stderr = |
| 2856 | "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n"; |
| 2857 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 2858 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 2859 | R"(package p; |
| 2860 | interface IFoo { |
| 2861 | const int int32_min_oob = -2147483650; |
| 2862 | } |
| 2863 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2864 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2865 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2866 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 2867 | } |
| 2868 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2869 | TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2870 | AidlError error; |
| 2871 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 2872 | "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2873 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 2874 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 2875 | R"(package p; |
| 2876 | interface IFoo { |
| 2877 | const long int64_max_oob = 21474836509999999999999999; |
| 2878 | } |
| 2879 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2880 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2881 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2882 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 2883 | } |
| 2884 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2885 | TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2886 | AidlError error; |
| 2887 | const string expected_stderr = |
Devin Moore | 2a08890 | 2020-09-17 10:51:19 -0700 | [diff] [blame] | 2888 | "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n"; |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2889 | CaptureStderr(); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 2890 | EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", |
| 2891 | R"(package p; |
| 2892 | interface IFoo { |
| 2893 | const long int64_min_oob = -21474836509999999999999999; |
| 2894 | } |
| 2895 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2896 | typenames_, GetLanguage(), &error)); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2897 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2898 | EXPECT_EQ(AidlError::PARSE_ERROR, error); |
Will McVicker | a4e5b13 | 2019-10-03 13:52:21 -0700 | [diff] [blame] | 2899 | } |
| 2900 | |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2901 | TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) { |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2902 | AidlError error; |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 2903 | const string expected_stderr = |
| 2904 | "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 " |
| 2905 | "literal: byte\n" |
| 2906 | "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n"; |
| 2907 | CaptureStderr(); |
Daniel Norman | b28684e | 2019-10-17 15:31:39 -0700 | [diff] [blame] | 2908 | EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl", |
| 2909 | R"(package p; |
| 2910 | @Backing(type="byte") |
| 2911 | enum TestEnum { |
| 2912 | FOO = 127, |
| 2913 | BAR, |
| 2914 | } |
| 2915 | )", |
Devin Moore | 7b8d5c9 | 2020-03-17 14:14:08 -0700 | [diff] [blame] | 2916 | typenames_, GetLanguage(), &error)); |
Devin Moore | df93ebb | 2020-03-25 14:03:35 -0700 | [diff] [blame] | 2917 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Devin Moore | 097a3ab | 2020-03-11 16:08:44 -0700 | [diff] [blame] | 2918 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
Daniel Norman | b28684e | 2019-10-17 15:31:39 -0700 | [diff] [blame] | 2919 | } |
| 2920 | |
Devin Moore | decaf29 | 2020-04-30 09:16:40 -0700 | [diff] [blame] | 2921 | TEST_P(AidlTest, UnsupportedBackingAnnotationParam) { |
| 2922 | AidlError error; |
| 2923 | const string expected_stderr = |
| 2924 | "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must " |
| 2925 | "be one of: type\n" |
| 2926 | "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must " |
| 2927 | "be one of: type\n"; |
| 2928 | CaptureStderr(); |
| 2929 | EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl", |
| 2930 | R"(package p; |
| 2931 | @Backing(foo="byte") |
| 2932 | enum TestEnum { |
| 2933 | FOO = 1, |
| 2934 | BAR, |
| 2935 | } |
| 2936 | )", |
| 2937 | typenames_, GetLanguage(), &error)); |
| 2938 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 2939 | EXPECT_EQ(AidlError::BAD_TYPE, error); |
| 2940 | } |
| 2941 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 2942 | TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 2943 | io_delegate_.SetFileContents("Foo.aidl", |
| 2944 | "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; " |
| 2945 | "Map<String, Baz> d; Bar[] e; }"); |
| 2946 | io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }"); |
| 2947 | io_delegate_.SetFileContents("Baz.aidl", |
| 2948 | "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;"); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 2949 | Options options = Options::From("aidl --lang=java -I . Foo.aidl"); |
| 2950 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2951 | } |
| 2952 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 2953 | TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 2954 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }"); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 2955 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }"); |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 2956 | string expected_error = |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 2957 | "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field " |
| 2958 | "named 'bar'.\n"; |
| 2959 | CaptureStderr(); |
| 2960 | Options options = Options::From("aidl --lang=java Foo.aidl -I ."); |
| 2961 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 2962 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
| 2963 | } |
| 2964 | |
| 2965 | TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) { |
| 2966 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }"); |
| 2967 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }"); |
| 2968 | string expected_error = |
| 2969 | "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field " |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 2970 | "named 'bar'.\n"; |
| 2971 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 2972 | Options options = Options::From("aidl --lang=java Foo.aidl -I ."); |
| 2973 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | d4057c4 | 2020-10-23 13:28:22 +0900 | [diff] [blame] | 2974 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 2975 | } |
| 2976 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 2977 | TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 2978 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }"); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 2979 | io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }"); |
| 2980 | string expected_error = |
| 2981 | "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can " |
| 2982 | "only be an in parameter.\n"; |
| 2983 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 2984 | Options options = Options::From("aidl --lang=java IBar.aidl -I ."); |
| 2985 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 2986 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 2987 | } |
| 2988 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 2989 | TEST_F(AidlTest, ImmutableParcelableCannotBeOut) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 2990 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }"); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 2991 | io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }"); |
| 2992 | string expected_error = |
| 2993 | "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can " |
| 2994 | "only be an in parameter.\n"; |
| 2995 | CaptureStderr(); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 2996 | Options options = Options::From("aidl --lang=java IBar.aidl -I ."); |
| 2997 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
Jooyung Han | 15fd6c6 | 2020-10-23 13:54:46 +0900 | [diff] [blame] | 2998 | EXPECT_EQ(expected_error, GetCapturedStderr()); |
Jeongik Cha | 36f76c3 | 2020-07-28 00:25:52 +0900 | [diff] [blame] | 2999 | } |
| 3000 | |
Jooyung Han | 6681393 | 2020-10-23 13:24:44 +0900 | [diff] [blame] | 3001 | TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) { |
Jeongik Cha | d0a1027 | 2020-08-06 16:33:36 +0900 | [diff] [blame] | 3002 | io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }"); |
Jeongik Cha | 9118025 | 2020-07-31 15:43:11 +0900 | [diff] [blame] | 3003 | Options options = Options::From("aidl --lang=java Foo.aidl"); |
| 3004 | const string expected_stderr = |
Jooyung Han | 59af9cc | 2020-10-25 21:44:14 +0900 | [diff] [blame] | 3005 | "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first " |
| 3006 | "letter\n"; |
Jeongik Cha | 9118025 | 2020-07-31 15:43:11 +0900 | [diff] [blame] | 3007 | CaptureStderr(); |
| 3008 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3009 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3010 | } |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3011 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3012 | const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once |
| 3013 | |
| 3014 | #include <a/ByteEnum.h> |
| 3015 | #include <binder/Parcel.h> |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3016 | #include <binder/ParcelFileDescriptor.h> |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3017 | #include <binder/Status.h> |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3018 | #include <cassert> |
Jooyung Han | 74b1dd4 | 2020-11-01 22:17:16 +0900 | [diff] [blame] | 3019 | #include <codecvt> |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3020 | #include <cstdint> |
Jooyung Han | 74b1dd4 | 2020-11-01 22:17:16 +0900 | [diff] [blame] | 3021 | #include <locale> |
| 3022 | #include <sstream> |
Jooyung Han | 3df81ae | 2020-10-17 17:59:59 +0900 | [diff] [blame] | 3023 | #include <type_traits> |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3024 | #include <utility> |
| 3025 | #include <variant> |
| 3026 | #include <vector> |
| 3027 | |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3028 | #ifndef __BIONIC__ |
| 3029 | #define __assert2(a,b,c,d) ((void)0) |
| 3030 | #endif |
| 3031 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3032 | namespace a { |
| 3033 | |
| 3034 | class Foo : public ::android::Parcelable { |
| 3035 | public: |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3036 | inline bool operator!=(const Foo& rhs) const { |
| 3037 | return _value != rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3038 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3039 | inline bool operator<(const Foo& rhs) const { |
| 3040 | return _value < rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3041 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3042 | inline bool operator<=(const Foo& rhs) const { |
| 3043 | return _value <= rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3044 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3045 | inline bool operator==(const Foo& rhs) const { |
| 3046 | return _value == rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3047 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3048 | inline bool operator>(const Foo& rhs) const { |
| 3049 | return _value > rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3050 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3051 | inline bool operator>=(const Foo& rhs) const { |
| 3052 | return _value >= rhs._value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3053 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3054 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3055 | enum Tag : int32_t { |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3056 | ns = 0, // int[] ns; |
| 3057 | e, // a.ByteEnum e; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3058 | pfd, // ParcelFileDescriptor pfd; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3059 | }; |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3060 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3061 | template<typename _Tp> |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3062 | static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3063 | |
| 3064 | Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3065 | Foo(const Foo&) = default; |
| 3066 | Foo(Foo&&) = default; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3067 | Foo& operator=(const Foo&) = default; |
| 3068 | Foo& operator=(Foo&&) = default; |
| 3069 | |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3070 | template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>> |
| 3071 | // NOLINTNEXTLINE(google-explicit-constructor) |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3072 | constexpr Foo(_Tp&& _arg) |
| 3073 | : _value(std::forward<_Tp>(_arg)) {} |
| 3074 | |
| 3075 | template <typename... _Tp> |
| 3076 | constexpr explicit Foo(_Tp&&... _args) |
| 3077 | : _value(std::forward<_Tp>(_args)...) {} |
| 3078 | |
| 3079 | template <Tag _tag, typename... _Tp> |
| 3080 | static Foo make(_Tp&&... _args) { |
| 3081 | return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3082 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3083 | |
| 3084 | template <Tag _tag, typename _Tp, typename... _Up> |
| 3085 | static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) { |
| 3086 | return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3087 | } |
| 3088 | |
| 3089 | Tag getTag() const { |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3090 | return static_cast<Tag>(_value.index()); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3091 | } |
| 3092 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3093 | template <Tag _tag> |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3094 | const auto& get() const { |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3095 | if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3096 | return std::get<_tag>(_value); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3097 | } |
| 3098 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3099 | template <Tag _tag> |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3100 | auto& get() { |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3101 | if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3102 | return std::get<_tag>(_value); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3103 | } |
| 3104 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3105 | template <Tag _tag, typename... _Tp> |
| 3106 | void set(_Tp&&... _args) { |
| 3107 | _value.emplace<_tag>(std::forward<_Tp>(_args)...); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3108 | } |
| 3109 | |
| 3110 | ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final; |
| 3111 | ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final; |
| 3112 | static const std::string& getParcelableDescriptor() { |
| 3113 | static const std::string DESCIPTOR = "a.Foo"; |
| 3114 | return DESCIPTOR; |
| 3115 | } |
Jooyung Han | b8e01b9 | 2020-11-01 16:49:13 +0900 | [diff] [blame] | 3116 | template <typename _T> class _has_toString { |
| 3117 | template <typename _U> static std::true_type __has_toString(decltype(&_U::toString)); |
| 3118 | template <typename _U> static std::false_type __has_toString(...); |
| 3119 | public: enum { value = decltype(__has_toString<_T>(nullptr))::value }; |
| 3120 | }; |
| 3121 | template <typename _T> inline static std::string _call_toString(const _T& t) { |
| 3122 | if constexpr (_has_toString<_T>::value) return t.toString(); |
| 3123 | return "{no toString() implemented}"; |
| 3124 | } |
Jooyung Han | 74b1dd4 | 2020-11-01 22:17:16 +0900 | [diff] [blame] | 3125 | inline std::string toString() const { |
| 3126 | std::ostringstream os; |
| 3127 | os << "Foo{"; |
| 3128 | switch (getTag()) { |
| 3129 | case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break; |
| 3130 | case e: os << "e: " << a::toString(get<e>()); break; |
| 3131 | case pfd: os << "pfd: " << ""; break; |
| 3132 | } |
| 3133 | os << "}"; |
| 3134 | return os.str(); |
| 3135 | } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3136 | private: |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3137 | std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3138 | }; // class Foo |
| 3139 | |
| 3140 | } // namespace a |
| 3141 | )"; |
| 3142 | |
| 3143 | const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h> |
| 3144 | |
| 3145 | namespace a { |
| 3146 | |
| 3147 | ::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) { |
| 3148 | ::android::status_t _aidl_ret_status; |
| 3149 | int32_t _aidl_tag; |
| 3150 | if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status; |
| 3151 | switch (_aidl_tag) { |
| 3152 | case ns: { |
| 3153 | ::std::vector<int32_t> _aidl_value; |
| 3154 | if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3155 | if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) { |
| 3156 | set<ns>(_aidl_value); |
| 3157 | } else { |
| 3158 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3159 | set<ns>(std::move(_aidl_value)); |
| 3160 | } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3161 | return ::android::OK; } |
| 3162 | case e: { |
| 3163 | ::a::ByteEnum _aidl_value; |
| 3164 | if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3165 | if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) { |
| 3166 | set<e>(_aidl_value); |
| 3167 | } else { |
| 3168 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3169 | set<e>(std::move(_aidl_value)); |
| 3170 | } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3171 | return ::android::OK; } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3172 | case pfd: { |
| 3173 | ::android::os::ParcelFileDescriptor _aidl_value; |
| 3174 | if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3175 | if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) { |
| 3176 | set<pfd>(_aidl_value); |
| 3177 | } else { |
| 3178 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3179 | set<pfd>(std::move(_aidl_value)); |
| 3180 | } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3181 | return ::android::OK; } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3182 | } |
| 3183 | return ::android::BAD_VALUE; |
| 3184 | } |
| 3185 | |
| 3186 | ::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const { |
| 3187 | ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag()); |
| 3188 | if (_aidl_ret_status != ::android::OK) return _aidl_ret_status; |
| 3189 | switch (getTag()) { |
| 3190 | case ns: return _aidl_parcel->writeInt32Vector(get<ns>()); |
| 3191 | case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>())); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3192 | case pfd: return _aidl_parcel->writeParcelable(get<pfd>()); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3193 | } |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3194 | __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here"); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3195 | } |
| 3196 | |
| 3197 | } // namespace a |
| 3198 | )"; |
| 3199 | |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3200 | const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once |
| 3201 | #include <android/binder_interface_utils.h> |
| 3202 | #include <android/binder_parcelable_utils.h> |
Jooyung Han | 74b1dd4 | 2020-11-01 22:17:16 +0900 | [diff] [blame] | 3203 | #include <codecvt> |
| 3204 | #include <locale> |
| 3205 | #include <sstream> |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3206 | |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3207 | #include <cassert> |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3208 | #include <type_traits> |
| 3209 | #include <utility> |
| 3210 | #include <variant> |
| 3211 | #include <cstdint> |
| 3212 | #include <memory> |
| 3213 | #include <optional> |
| 3214 | #include <string> |
| 3215 | #include <vector> |
| 3216 | #ifdef BINDER_STABILITY_SUPPORT |
| 3217 | #include <android/binder_stability.h> |
| 3218 | #endif // BINDER_STABILITY_SUPPORT |
| 3219 | #include <aidl/a/ByteEnum.h> |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3220 | |
| 3221 | #ifndef __BIONIC__ |
| 3222 | #define __assert2(a,b,c,d) ((void)0) |
| 3223 | #endif |
| 3224 | |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3225 | namespace aidl { |
| 3226 | namespace a { |
| 3227 | class Foo { |
| 3228 | public: |
| 3229 | typedef std::false_type fixed_size; |
| 3230 | static const char* descriptor; |
| 3231 | |
| 3232 | enum Tag : int32_t { |
| 3233 | ns = 0, // int[] ns; |
| 3234 | e, // a.ByteEnum e; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3235 | pfd, // ParcelFileDescriptor pfd; |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3236 | }; |
| 3237 | |
| 3238 | template<typename _Tp> |
| 3239 | static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>; |
| 3240 | |
| 3241 | Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { } |
| 3242 | Foo(const Foo&) = default; |
| 3243 | Foo(Foo&&) = default; |
| 3244 | Foo& operator=(const Foo&) = default; |
| 3245 | Foo& operator=(Foo&&) = default; |
| 3246 | |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3247 | template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>> |
| 3248 | // NOLINTNEXTLINE(google-explicit-constructor) |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3249 | constexpr Foo(_Tp&& _arg) |
| 3250 | : _value(std::forward<_Tp>(_arg)) {} |
| 3251 | |
| 3252 | template <typename... _Tp> |
| 3253 | constexpr explicit Foo(_Tp&&... _args) |
| 3254 | : _value(std::forward<_Tp>(_args)...) {} |
| 3255 | |
| 3256 | template <Tag _tag, typename... _Tp> |
| 3257 | static Foo make(_Tp&&... _args) { |
| 3258 | return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...); |
| 3259 | } |
| 3260 | |
| 3261 | template <Tag _tag, typename _Tp, typename... _Up> |
| 3262 | static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) { |
| 3263 | return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...); |
| 3264 | } |
| 3265 | |
| 3266 | Tag getTag() const { |
| 3267 | return static_cast<Tag>(_value.index()); |
| 3268 | } |
| 3269 | |
| 3270 | template <Tag _tag> |
| 3271 | const auto& get() const { |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3272 | if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3273 | return std::get<_tag>(_value); |
| 3274 | } |
| 3275 | |
| 3276 | template <Tag _tag> |
| 3277 | auto& get() { |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3278 | if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3279 | return std::get<_tag>(_value); |
| 3280 | } |
| 3281 | |
| 3282 | template <Tag _tag, typename... _Tp> |
| 3283 | void set(_Tp&&... _args) { |
| 3284 | _value.emplace<_tag>(std::forward<_Tp>(_args)...); |
| 3285 | } |
| 3286 | |
| 3287 | binder_status_t readFromParcel(const AParcel* _parcel); |
| 3288 | binder_status_t writeToParcel(AParcel* _parcel) const; |
| 3289 | static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL; |
Jooyung Han | b8e01b9 | 2020-11-01 16:49:13 +0900 | [diff] [blame] | 3290 | template <typename _T> class _has_toString { |
| 3291 | template <typename _U> static std::true_type __has_toString(decltype(&_U::toString)); |
| 3292 | template <typename _U> static std::false_type __has_toString(...); |
| 3293 | public: enum { value = decltype(__has_toString<_T>(nullptr))::value }; |
| 3294 | }; |
| 3295 | template <typename _T> inline static std::string _call_toString(const _T& t) { |
| 3296 | if constexpr (_has_toString<_T>::value) return t.toString(); |
| 3297 | return "{no toString() implemented}"; |
| 3298 | } |
Jooyung Han | 74b1dd4 | 2020-11-01 22:17:16 +0900 | [diff] [blame] | 3299 | inline std::string toString() const { |
| 3300 | std::ostringstream os; |
| 3301 | os << "Foo{"; |
| 3302 | switch (getTag()) { |
| 3303 | case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break; |
| 3304 | case e: os << "e: " << a::toString(get<e>()); break; |
| 3305 | case pfd: os << "pfd: " << ""; break; |
| 3306 | } |
| 3307 | os << "}"; |
| 3308 | return os.str(); |
| 3309 | } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3310 | private: |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3311 | std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value; |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3312 | }; |
| 3313 | } // namespace a |
| 3314 | } // namespace aidl |
| 3315 | )"; |
| 3316 | |
| 3317 | const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h" |
| 3318 | |
| 3319 | #include <android/binder_parcel_utils.h> |
| 3320 | |
| 3321 | namespace aidl { |
| 3322 | namespace a { |
| 3323 | const char* Foo::descriptor = "a.Foo"; |
| 3324 | |
| 3325 | binder_status_t Foo::readFromParcel(const AParcel* _parcel) { |
| 3326 | binder_status_t _aidl_ret_status; |
| 3327 | int32_t _aidl_tag; |
| 3328 | if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status; |
| 3329 | switch (_aidl_tag) { |
| 3330 | case ns: { |
| 3331 | std::vector<int32_t> _aidl_value; |
| 3332 | if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3333 | if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) { |
| 3334 | set<ns>(_aidl_value); |
| 3335 | } else { |
| 3336 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3337 | set<ns>(std::move(_aidl_value)); |
| 3338 | } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3339 | return STATUS_OK; } |
| 3340 | case e: { |
| 3341 | ::aidl::a::ByteEnum _aidl_value; |
| 3342 | if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3343 | if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) { |
| 3344 | set<e>(_aidl_value); |
| 3345 | } else { |
| 3346 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3347 | set<e>(std::move(_aidl_value)); |
| 3348 | } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3349 | return STATUS_OK; } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3350 | case pfd: { |
| 3351 | ::ndk::ScopedFileDescriptor _aidl_value; |
| 3352 | if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status; |
Jiyong Park | dd57f1a | 2020-11-16 20:19:55 +0900 | [diff] [blame] | 3353 | if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) { |
| 3354 | set<pfd>(_aidl_value); |
| 3355 | } else { |
| 3356 | // NOLINTNEXTLINE(performance-move-const-arg) |
| 3357 | set<pfd>(std::move(_aidl_value)); |
| 3358 | } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3359 | return STATUS_OK; } |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3360 | } |
| 3361 | return STATUS_BAD_VALUE; |
| 3362 | } |
| 3363 | binder_status_t Foo::writeToParcel(AParcel* _parcel) const { |
| 3364 | binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag()); |
| 3365 | if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status; |
| 3366 | switch (getTag()) { |
| 3367 | case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>()); |
| 3368 | case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>())); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3369 | case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>()); |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3370 | } |
Jooyung Han | df39e19 | 2020-11-23 15:59:46 +0900 | [diff] [blame] | 3371 | __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here"); |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3372 | } |
| 3373 | |
| 3374 | } // namespace a |
| 3375 | } // namespace aidl |
| 3376 | )"; |
| 3377 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3378 | const char kUnionExampleExpectedOutputJava[] = R"(/* |
| 3379 | * This file is auto-generated. DO NOT MODIFY. |
| 3380 | */ |
| 3381 | package a; |
| 3382 | |
| 3383 | |
| 3384 | public final class Foo implements android.os.Parcelable { |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3385 | // tags for union fields |
| 3386 | public final static int ns = 0; // int[] ns; |
| 3387 | public final static int e = 1; // a.ByteEnum e; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3388 | public final static int pfd = 2; // ParcelFileDescriptor pfd; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3389 | |
| 3390 | private int _tag; |
| 3391 | private Object _value; |
| 3392 | |
| 3393 | public Foo() { |
Jooyung Han | ce62f93 | 2020-10-25 10:21:49 +0900 | [diff] [blame] | 3394 | int[] _value = {42}; |
| 3395 | this._tag = ns; |
| 3396 | this._value = _value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3397 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3398 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3399 | private Foo(android.os.Parcel _aidl_parcel) { |
| 3400 | readFromParcel(_aidl_parcel); |
| 3401 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3402 | |
Jooyung Han | ce62f93 | 2020-10-25 10:21:49 +0900 | [diff] [blame] | 3403 | private Foo(int _tag, Object _value) { |
| 3404 | this._tag = _tag; |
| 3405 | this._value = _value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3406 | } |
| 3407 | |
| 3408 | public int getTag() { |
| 3409 | return _tag; |
| 3410 | } |
| 3411 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3412 | // int[] ns; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3413 | |
| 3414 | public static Foo ns(int[] _value) { |
| 3415 | return new Foo(ns, _value); |
| 3416 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3417 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3418 | public int[] getNs() { |
| 3419 | _assertTag(ns); |
| 3420 | return (int[]) _value; |
| 3421 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3422 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3423 | public void setNs(int[] _value) { |
| 3424 | _set(ns, _value); |
| 3425 | } |
| 3426 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3427 | // a.ByteEnum e; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3428 | |
| 3429 | public static Foo e(byte _value) { |
| 3430 | return new Foo(e, _value); |
| 3431 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3432 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3433 | public byte getE() { |
| 3434 | _assertTag(e); |
| 3435 | return (byte) _value; |
| 3436 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3437 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3438 | public void setE(byte _value) { |
| 3439 | _set(e, _value); |
| 3440 | } |
| 3441 | |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3442 | // ParcelFileDescriptor pfd; |
| 3443 | |
| 3444 | public static Foo pfd(android.os.ParcelFileDescriptor _value) { |
| 3445 | return new Foo(pfd, _value); |
| 3446 | } |
| 3447 | |
| 3448 | public android.os.ParcelFileDescriptor getPfd() { |
| 3449 | _assertTag(pfd); |
| 3450 | return (android.os.ParcelFileDescriptor) _value; |
| 3451 | } |
| 3452 | |
| 3453 | public void setPfd(android.os.ParcelFileDescriptor _value) { |
| 3454 | _set(pfd, _value); |
| 3455 | } |
| 3456 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3457 | public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() { |
| 3458 | @Override |
| 3459 | public Foo createFromParcel(android.os.Parcel _aidl_source) { |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3460 | return new Foo(_aidl_source); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3461 | } |
| 3462 | @Override |
| 3463 | public Foo[] newArray(int _aidl_size) { |
| 3464 | return new Foo[_aidl_size]; |
| 3465 | } |
| 3466 | }; |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3467 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3468 | @Override |
| 3469 | public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) { |
| 3470 | _aidl_parcel.writeInt(_tag); |
| 3471 | switch (_tag) { |
| 3472 | case ns: |
| 3473 | _aidl_parcel.writeIntArray(getNs()); |
| 3474 | break; |
| 3475 | case e: |
| 3476 | _aidl_parcel.writeByte(getE()); |
| 3477 | break; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3478 | case pfd: |
| 3479 | if ((getPfd()!=null)) { |
| 3480 | _aidl_parcel.writeInt(1); |
| 3481 | getPfd().writeToParcel(_aidl_parcel, 0); |
| 3482 | } |
| 3483 | else { |
| 3484 | _aidl_parcel.writeInt(0); |
| 3485 | } |
| 3486 | break; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3487 | } |
| 3488 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3489 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3490 | public void readFromParcel(android.os.Parcel _aidl_parcel) { |
| 3491 | int _aidl_tag; |
| 3492 | _aidl_tag = _aidl_parcel.readInt(); |
| 3493 | switch (_aidl_tag) { |
| 3494 | case ns: { |
| 3495 | int[] _aidl_value; |
| 3496 | _aidl_value = _aidl_parcel.createIntArray(); |
| 3497 | _set(_aidl_tag, _aidl_value); |
| 3498 | return; } |
| 3499 | case e: { |
| 3500 | byte _aidl_value; |
| 3501 | _aidl_value = _aidl_parcel.readByte(); |
| 3502 | _set(_aidl_tag, _aidl_value); |
| 3503 | return; } |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3504 | case pfd: { |
| 3505 | android.os.ParcelFileDescriptor _aidl_value; |
| 3506 | if ((0!=_aidl_parcel.readInt())) { |
| 3507 | _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel); |
| 3508 | } |
| 3509 | else { |
| 3510 | _aidl_value = null; |
| 3511 | } |
| 3512 | _set(_aidl_tag, _aidl_value); |
| 3513 | return; } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3514 | } |
Jooyung Han | c453bea | 2020-11-21 01:00:22 +0900 | [diff] [blame] | 3515 | throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3516 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3517 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3518 | @Override |
| 3519 | public int describeContents() { |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3520 | int _mask = 0; |
| 3521 | switch (getTag()) { |
| 3522 | case pfd: |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3523 | _mask |= describeContents(getPfd()); |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3524 | break; |
| 3525 | } |
| 3526 | return _mask; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3527 | } |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3528 | private int describeContents(Object _v) { |
| 3529 | if (_v == null) return 0; |
| 3530 | if (_v instanceof android.os.Parcelable) { |
| 3531 | return ((android.os.Parcelable) _v).describeContents(); |
| 3532 | } |
| 3533 | return 0; |
| 3534 | } |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3535 | |
| 3536 | private void _assertTag(int tag) { |
| 3537 | if (getTag() != tag) { |
Jooyung Han | ef9b0f6 | 2020-10-14 21:52:55 +0900 | [diff] [blame] | 3538 | throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available."); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3539 | } |
| 3540 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3541 | |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3542 | private String _tagString(int _tag) { |
| 3543 | switch (_tag) { |
| 3544 | case ns: return "ns"; |
| 3545 | case e: return "e"; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3546 | case pfd: return "pfd"; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3547 | } |
| 3548 | throw new IllegalStateException("unknown field: " + _tag); |
| 3549 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3550 | |
Jooyung Han | ce62f93 | 2020-10-25 10:21:49 +0900 | [diff] [blame] | 3551 | private void _set(int _tag, Object _value) { |
| 3552 | this._tag = _tag; |
| 3553 | this._value = _value; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3554 | } |
| 3555 | } |
| 3556 | )"; |
| 3557 | |
Jooyung Han | f93b5bd | 2020-10-28 15:12:08 +0900 | [diff] [blame] | 3558 | const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)] |
| 3559 | pub enum Foo { |
| 3560 | Ns(Vec<i32>), |
| 3561 | E(crate::mangled::_1_a_8_ByteEnum), |
| 3562 | Pfd(Option<binder::parcel::ParcelFileDescriptor>), |
| 3563 | } |
| 3564 | pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; } |
| 3565 | impl Default for Foo { |
| 3566 | fn default() -> Self { |
| 3567 | Self::Ns(vec!{42}) |
| 3568 | } |
| 3569 | } |
| 3570 | impl binder::parcel::Serialize for Foo { |
| 3571 | fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> { |
| 3572 | <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel) |
| 3573 | } |
| 3574 | } |
| 3575 | impl binder::parcel::SerializeArray for Foo {} |
| 3576 | impl binder::parcel::SerializeOption for Foo { |
| 3577 | fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> { |
| 3578 | let this = if let Some(this) = this { |
| 3579 | parcel.write(&1i32)?; |
| 3580 | this |
| 3581 | } else { |
| 3582 | return parcel.write(&0i32); |
| 3583 | }; |
| 3584 | match this { |
| 3585 | Self::Ns(v) => { |
| 3586 | parcel.write(&0i32)?; |
| 3587 | parcel.write(v) |
| 3588 | } |
| 3589 | Self::E(v) => { |
| 3590 | parcel.write(&1i32)?; |
| 3591 | parcel.write(v) |
| 3592 | } |
| 3593 | Self::Pfd(v) => { |
| 3594 | parcel.write(&2i32)?; |
| 3595 | let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?; |
| 3596 | parcel.write(__field_ref) |
| 3597 | } |
| 3598 | } |
| 3599 | } |
| 3600 | } |
| 3601 | impl binder::parcel::Deserialize for Foo { |
| 3602 | fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> { |
| 3603 | <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel) |
| 3604 | .transpose() |
| 3605 | .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL)) |
| 3606 | } |
| 3607 | } |
| 3608 | impl binder::parcel::DeserializeArray for Foo {} |
| 3609 | impl binder::parcel::DeserializeOption for Foo { |
| 3610 | fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> { |
| 3611 | let status: i32 = parcel.read()?; |
| 3612 | if status == 0 { return Ok(None); } |
| 3613 | let tag: i32 = parcel.read()?; |
| 3614 | match tag { |
| 3615 | 0 => { |
| 3616 | let value: Vec<i32> = parcel.read()?; |
| 3617 | Ok(Some(Self::Ns(value))) |
| 3618 | } |
| 3619 | 1 => { |
| 3620 | let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?; |
| 3621 | Ok(Some(Self::E(value))) |
| 3622 | } |
| 3623 | 2 => { |
| 3624 | let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?); |
| 3625 | Ok(Some(Self::Pfd(value))) |
| 3626 | } |
| 3627 | _ => { |
| 3628 | Err(binder::StatusCode::BAD_VALUE) |
| 3629 | } |
| 3630 | } |
| 3631 | } |
| 3632 | } |
| 3633 | )"; |
| 3634 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3635 | struct AidlUnionTest : ::testing::Test { |
| 3636 | void SetUp() override { |
| 3637 | io_delegate_.SetFileContents("a/Foo.aidl", R"( |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3638 | package a; |
| 3639 | import a.ByteEnum; |
| 3640 | union Foo { |
| 3641 | int[] ns = {42}; |
| 3642 | ByteEnum e; |
Jooyung Han | d2fa023 | 2020-10-19 02:51:41 +0900 | [diff] [blame] | 3643 | ParcelFileDescriptor pfd; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3644 | } |
| 3645 | )"); |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3646 | io_delegate_.SetFileContents("a/ByteEnum.aidl", R"( |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3647 | package a; |
| 3648 | @Backing(type="byte") |
| 3649 | enum ByteEnum { |
| 3650 | a, b, c |
| 3651 | } |
| 3652 | )"); |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3653 | } |
| 3654 | FakeIoDelegate io_delegate_; |
| 3655 | void Compile(string lang) { |
| 3656 | string command = "aidl --structured -I. -o out --lang=" + lang; |
| 3657 | if (lang == "cpp" || lang == "ndk") { |
| 3658 | command += " -h out"; |
| 3659 | } |
| 3660 | command += " a/Foo.aidl"; |
| 3661 | auto opts = Options::From(command); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3662 | CaptureStderr(); |
| 3663 | auto ret = ::android::aidl::compile_aidl(opts, io_delegate_); |
| 3664 | auto err = GetCapturedStderr(); |
| 3665 | EXPECT_EQ(0, ret) << err; |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3666 | } |
| 3667 | void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) { |
| 3668 | for (const auto& [path, expected] : outputs) { |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3669 | string actual; |
| 3670 | EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found."; |
| 3671 | EXPECT_EQ(expected, actual); |
| 3672 | } |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3673 | } |
| 3674 | }; |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3675 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3676 | TEST_F(AidlUnionTest, Example_Cpp) { |
| 3677 | Compile("cpp"); |
| 3678 | EXPECT_COMPILE_OUTPUTS( |
| 3679 | map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource}, |
| 3680 | {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}})); |
| 3681 | } |
| 3682 | |
Jooyung Han | 6beac04 | 2020-10-17 21:59:43 +0900 | [diff] [blame] | 3683 | TEST_F(AidlUnionTest, Example_Ndk) { |
| 3684 | Compile("ndk"); |
| 3685 | EXPECT_COMPILE_OUTPUTS( |
| 3686 | map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource}, |
| 3687 | {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}})); |
| 3688 | } |
| 3689 | |
Jooyung Han | 97945de | 2020-10-15 16:41:38 +0900 | [diff] [blame] | 3690 | TEST_F(AidlUnionTest, Example_Java) { |
| 3691 | Compile("java"); |
| 3692 | EXPECT_COMPILE_OUTPUTS( |
| 3693 | map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}})); |
Jooyung Han | f93b5bd | 2020-10-28 15:12:08 +0900 | [diff] [blame] | 3694 | } |
| 3695 | |
| 3696 | TEST_F(AidlUnionTest, Example_Rust) { |
| 3697 | Compile("rust"); |
| 3698 | EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}})); |
Jooyung Han | 1f14ab3 | 2020-10-14 13:48:29 +0900 | [diff] [blame] | 3699 | } |
| 3700 | |
Jooyung Han | fe89f12 | 2020-10-14 03:49:18 +0900 | [diff] [blame] | 3701 | TEST_P(AidlTest, UnionRejectsEmptyDecl) { |
| 3702 | const string method = "package a; union Foo {}"; |
| 3703 | const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n"; |
| 3704 | CaptureStderr(); |
| 3705 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 3706 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr)); |
| 3707 | } |
| 3708 | |
| 3709 | TEST_P(AidlTest, UnionRejectsParcelableHolder) { |
| 3710 | const string method = "package a; union Foo { ParcelableHolder x; }"; |
| 3711 | const string expected_stderr = |
| 3712 | "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n"; |
| 3713 | CaptureStderr(); |
| 3714 | EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage())); |
| 3715 | EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr)); |
| 3716 | } |
| 3717 | |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3718 | TEST_P(AidlTest, GenericStructuredParcelable) { |
| 3719 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }"); |
| 3720 | Options options = |
| 3721 | Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage())); |
| 3722 | const string expected_stderr = ""; |
| 3723 | CaptureStderr(); |
| 3724 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3725 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3726 | } |
| 3727 | |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 3728 | TEST_F(AidlTest, NestedTypeArgs) { |
| 3729 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }"); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3730 | io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }"); |
| 3731 | |
| 3732 | io_delegate_.SetFileContents("a/Foo.aidl", |
| 3733 | "package a; import a.Bar; import a.Baz; parcelable Foo { " |
| 3734 | "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }"); |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 3735 | Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java"); |
| 3736 | const string expected_stderr = ""; |
| 3737 | CaptureStderr(); |
| 3738 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3739 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3740 | |
| 3741 | string code; |
| 3742 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code)); |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3743 | EXPECT_THAT(code, |
| 3744 | testing::HasSubstr( |
| 3745 | "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;")); |
| 3746 | } |
| 3747 | |
| 3748 | TEST_F(AidlTest, DoubleArrayError) { |
| 3749 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }"); |
| 3750 | |
| 3751 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3752 | const string expected_stderr = |
| 3753 | "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n"; |
| 3754 | CaptureStderr(); |
| 3755 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3756 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3757 | } |
| 3758 | |
| 3759 | TEST_F(AidlTest, DoubleGenericError) { |
| 3760 | io_delegate_.SetFileContents("a/Bar.aidl", |
| 3761 | "package a; parcelable Bar { List<String><String> a; }"); |
| 3762 | |
| 3763 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3764 | const string expected_stderr = |
| 3765 | "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n"; |
| 3766 | CaptureStderr(); |
| 3767 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3768 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3769 | } |
| 3770 | |
| 3771 | TEST_F(AidlTest, ArrayBeforeGenericError) { |
| 3772 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }"); |
| 3773 | |
| 3774 | Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java"); |
| 3775 | const string expected_stderr = |
| 3776 | "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n"; |
| 3777 | CaptureStderr(); |
| 3778 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3779 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
Jooyung Han | 8c9a4e1 | 2020-10-26 15:39:54 +0900 | [diff] [blame] | 3780 | } |
| 3781 | |
Jooyung Han | 14004ed | 2020-10-16 03:49:57 +0900 | [diff] [blame] | 3782 | struct GenericAidlTest : ::testing::Test { |
| 3783 | FakeIoDelegate io_delegate_; |
| 3784 | void Compile(string cmd) { |
Steven Moreland | 6c07b83 | 2020-10-29 23:39:53 +0000 | [diff] [blame] | 3785 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }"); |
Jooyung Han | 14004ed | 2020-10-16 03:49:57 +0900 | [diff] [blame] | 3786 | io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }"); |
| 3787 | io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }"); |
| 3788 | io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }"); |
| 3789 | |
| 3790 | Options options = Options::From(cmd); |
| 3791 | CaptureStderr(); |
| 3792 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3793 | EXPECT_EQ("", GetCapturedStderr()); |
| 3794 | } |
| 3795 | }; |
| 3796 | |
| 3797 | TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) { |
| 3798 | Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out"); |
| 3799 | string code; |
| 3800 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code)); |
| 3801 | EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>")); |
| 3802 | EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>")); |
| 3803 | EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>")); |
| 3804 | } |
| 3805 | |
| 3806 | TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) { |
| 3807 | Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out"); |
| 3808 | string code; |
| 3809 | EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code)); |
| 3810 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>")); |
| 3811 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>")); |
| 3812 | EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>")); |
| 3813 | } |
| 3814 | |
Devin Moore | 53fc99c | 2020-08-12 08:07:52 -0700 | [diff] [blame] | 3815 | TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) { |
| 3816 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }"); |
| 3817 | Options options = |
| 3818 | Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage())); |
| 3819 | const string expected_stderr = |
| 3820 | "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n"; |
| 3821 | CaptureStderr(); |
| 3822 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3823 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3824 | } |
| 3825 | |
| 3826 | TEST_P(AidlTest, RejectGenericStructuredParcelableField) { |
| 3827 | io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }"); |
| 3828 | Options options = |
| 3829 | Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage())); |
| 3830 | const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n"; |
| 3831 | CaptureStderr(); |
| 3832 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3833 | EXPECT_EQ(expected_stderr, GetCapturedStderr()); |
| 3834 | } |
| 3835 | |
Jooyung Han | 7a30884 | 2020-10-27 19:06:49 +0900 | [diff] [blame] | 3836 | TEST_P(AidlTest, LongCommentWithinConstExpression) { |
| 3837 | io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }"); |
| 3838 | Options options = |
| 3839 | Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage())); |
| 3840 | CaptureStderr(); |
| 3841 | EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3842 | EXPECT_EQ("", GetCapturedStderr()); |
| 3843 | } |
| 3844 | |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3845 | TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) { |
| 3846 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }"); |
| 3847 | Options options = Options::From("aidl a/Foo.aidl --lang=java -o out"); |
| 3848 | std::string expectedErr = |
| 3849 | "ERROR: a/Foo.aidl:1.28-30: " |
| 3850 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3851 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3852 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 3853 | "ERROR: a/Foo.aidl:1.35-37: " |
| 3854 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3855 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3856 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 3857 | CaptureStderr(); |
| 3858 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3859 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
| 3860 | } |
| 3861 | |
| 3862 | TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) { |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3863 | io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }"); |
| 3864 | Options options = Options::From("aidl a/Foo.aidl --lang=java -o out"); |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3865 | std::string expectedErr = |
| 3866 | "ERROR: a/Foo.aidl:1.33-35: " |
| 3867 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3868 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3869 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 3870 | "ERROR: a/Foo.aidl:1.40-42: " |
| 3871 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3872 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3873 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3874 | CaptureStderr(); |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3875 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3876 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
| 3877 | } |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3878 | |
Jeongik Cha | ef44e62 | 2020-10-23 16:00:52 +0900 | [diff] [blame] | 3879 | TEST_F(AidlTest, RejectNestedUntypedListAndMap) { |
| 3880 | io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;"); |
| 3881 | io_delegate_.SetFileContents( |
| 3882 | "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }"); |
| 3883 | Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out"); |
| 3884 | std::string expectedErr = |
| 3885 | "ERROR: a/Foo.aidl:1.52-54: " |
| 3886 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3887 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3888 | "the receiving side. Consider switching to an array or a generic List/Map.\n" |
| 3889 | "ERROR: a/Foo.aidl:1.64-66: " |
| 3890 | "Encountered an untyped List or Map. The use of untyped List/Map is " |
| 3891 | "prohibited because it is not guaranteed that the objects in the list are recognizable in " |
| 3892 | "the receiving side. Consider switching to an array or a generic List/Map.\n"; |
| 3893 | CaptureStderr(); |
| 3894 | EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_)); |
| 3895 | EXPECT_EQ(expectedErr, GetCapturedStderr()); |
Jooyung Han | ea2147c | 2020-10-21 18:16:56 +0900 | [diff] [blame] | 3896 | } |
| 3897 | |
Christopher Wiley | 90be4e3 | 2015-10-20 14:55:25 -0700 | [diff] [blame] | 3898 | } // namespace aidl |
| 3899 | } // namespace android |