blob: 0c69d395db07c72090350690b5b0bf538a1b1125 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900333 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
334 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700335 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700336 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900338}
339
Jiyong Park40782d02020-07-24 19:17:43 +0900340TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
342 const string expected_stderr =
343 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344 CaptureStderr();
345 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900347}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348
Jiyong Park40782d02020-07-24 19:17:43 +0900349TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700350 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900351 const string expected_stderr =
352 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
369 const string expected_stderr =
370 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
371 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800374}
375
Devin Moore2f2077a2020-08-28 11:27:53 -0700376TEST_P(AidlTest, AcceptNullableList) {
377 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
378 const string expected_stderr = "";
379 CaptureStderr();
380 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 const string method = "package a; interface IFoo { void f(int a, int a); }";
386 const string expected_stderr =
387 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
388 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700391}
392
Jeongik Cha13066da2020-08-06 15:43:19 +0900393TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
394 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900395 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900396 CaptureStderr();
397 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
399}
400
Jooyung Hand902a972020-10-23 17:32:44 +0900401TEST_P(AidlTest, RejectsRepeatedAnnotations) {
402 const string method = R"(@Hide @Hide parcelable Foo {})";
403 const string expected_stderr =
404 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
405 "Foo.aidl:1.1-6\n";
406 CaptureStderr();
407 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
408 EXPECT_EQ(expected_stderr, GetCapturedStderr());
409}
410
Devin Moore7b8d5c92020-03-17 14:14:08 -0700411TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700412 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
413 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
414 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700415 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700416 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100417}
418
Devin Moore7b8d5c92020-03-17 14:14:08 -0700419TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700420 AidlError error;
421 const string method = "package a; @nullable interface IFoo { int f(); }";
422 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800423 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000424 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
425 "JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700426 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700427 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700428 EXPECT_EQ(expected_stderr, GetCapturedStderr());
429 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800430}
431
Devin Moore7b8d5c92020-03-17 14:14:08 -0700432TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700433 AidlError error;
434 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
435 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800436 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900437 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700438 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700439 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
441 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800442}
443
Devin Moore7b8d5c92020-03-17 14:14:08 -0700444TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700445 AidlError error;
446 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
447 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000448 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900449 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900450 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700451 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000452 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700453 EXPECT_EQ(expected_stderr, GetCapturedStderr());
454 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800455}
456
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700458 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000459 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700460 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000461 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900462 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700463 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700464 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000465 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
467 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800468}
469
Jiyong Park40782d02020-07-24 19:17:43 +0900470TEST_P(AidlTest, ParsesNonNullableAnnotation) {
471 auto parse_result =
472 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
473 ASSERT_NE(nullptr, parse_result);
474 const AidlInterface* interface = parse_result->AsInterface();
475 ASSERT_NE(nullptr, interface);
476 ASSERT_FALSE(interface->GetMethods().empty());
477 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
478}
479
Devin Moore7b8d5c92020-03-17 14:14:08 -0700480TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900481 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
482 typenames_, GetLanguage());
483 ASSERT_NE(nullptr, parse_result);
484 const AidlInterface* interface = parse_result->AsInterface();
485 ASSERT_NE(nullptr, interface);
486 ASSERT_FALSE(interface->GetMethods().empty());
487 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
488}
489
490TEST_P(AidlTest, ParsesNonUtf8Annotations) {
491 auto parse_result =
492 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
493 ASSERT_NE(nullptr, parse_result);
494 const AidlInterface* interface = parse_result->AsInterface();
495 ASSERT_NE(nullptr, interface);
496 ASSERT_FALSE(interface->GetMethods().empty());
497 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800498}
499
Devin Moore7b8d5c92020-03-17 14:14:08 -0700500TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900501 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
502 typenames_, GetLanguage());
503 ASSERT_NE(nullptr, parse_result);
504 const AidlInterface* interface = parse_result->AsInterface();
505 ASSERT_NE(nullptr, interface);
506 ASSERT_FALSE(interface->GetMethods().empty());
507 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800508}
509
Devin Moore7b8d5c92020-03-17 14:14:08 -0700510TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700511 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700512 const string expected_stderr =
513 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
514 "\"vintf\"'\n"
515 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
516 "--structured\n";
517 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700518 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700519 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522}
523
Devin Moore7b8d5c92020-03-17 14:14:08 -0700524TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700526 const string expected_stderr =
527 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
528 "--structured\n";
529 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700530 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700531 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534}
535
Devin Moore7b8d5c92020-03-17 14:14:08 -0700536TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700537 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700538 const string expected_stderr =
539 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
540 "\"vintf\"'\n";
541 CaptureStderr();
542 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700543 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546}
547
Devin Moore7b8d5c92020-03-17 14:14:08 -0700548TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700549 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700550 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
551 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700552 ASSERT_EQ(AidlError::OK, error);
553 ASSERT_NE(nullptr, parse_result);
554 const AidlInterface* interface = parse_result->AsInterface();
555 ASSERT_NE(nullptr, interface);
556 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700557}
558
Jeongik Cha64783ed2019-06-07 18:30:54 +0900559TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
560 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900561 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
562 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900563 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700564 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900565 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900566 "a/Foo.aidl",
567 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900568
569 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900570 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700571 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900572 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700573 "Parcelable must be defined in AIDL directly.\n";
574 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900575 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700577
578 CaptureStderr();
579 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900581}
582
Jooyung Han1cbc4962020-10-25 10:07:15 +0900583TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
584 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
585 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
586 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900587 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
588
589 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900590 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900591 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
592
593 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900594 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900595 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
596
Jooyung Han1cbc4962020-10-25 10:07:15 +0900597 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900598 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
599}
600
Jooyung Han1cbc4962020-10-25 10:07:15 +0900601TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
602 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
603 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
604 CaptureStderr();
605 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
606 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
607 EXPECT_EQ("", GetCapturedStderr());
608
609 const string expected_to_string_method = R"--(
610 @Override
611 public String toString() {
612 switch (_tag) {
613 case a: return "a.Foo.a(" + (getA()) + ")";
614 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
615 }
616 throw new IllegalStateException("unknown field: " + _tag);
617 }
618)--";
619
620 string java_out;
621 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
622 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
623}
624
Jooyung Han90345002020-10-23 15:28:53 +0900625TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900626 {
Jooyung Han90345002020-10-23 15:28:53 +0900627 io_delegate_.SetFileContents("a/Foo.aidl",
628 "package a; @JavaDerive(blah=true) parcelable Foo{}");
629 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
630 CaptureStderr();
631 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
632 const std::string expected_stderr =
633 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
634 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
635 }
636
637 {
638 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900639 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
640 CaptureStderr();
641 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
642 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900643 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000644 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
645 "JavaPassthrough, Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900646 EXPECT_EQ(expected_stderr, GetCapturedStderr());
647 }
648
649 {
Jooyung Han90345002020-10-23 15:28:53 +0900650 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900651 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
652 CaptureStderr();
653 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
654 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900655 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900656 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
657 EXPECT_EQ(expected_stderr, GetCapturedStderr());
658 }
659}
660
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900661TEST_P(AidlTest, ParseDescriptorAnnotation) {
662 AidlError error;
663 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
664 typenames_, GetLanguage(), &error, {"--structured"});
665 ASSERT_EQ(AidlError::OK, error);
666 ASSERT_NE(nullptr, parse_result);
667 const AidlInterface* interface = parse_result->AsInterface();
668 ASSERT_NE(nullptr, interface);
669 ASSERT_EQ("IBar", interface->GetDescriptor());
670}
671
Jiyong Park40782d02020-07-24 19:17:43 +0900672TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700673 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700674 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900675}
676
677TEST_P(AidlTest, AcceptsOnewayInterface) {
678 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700679 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700680}
Christopher Wileyef140932015-11-03 09:29:19 -0800681
Devin Moore7b8d5c92020-03-17 14:14:08 -0700682TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700683 const string oneway_method =
684 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700685 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100686}
687
Steven Moreland65297cc2020-04-20 20:17:36 -0700688TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
689 const string oneway_method =
690 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
691 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
692 ASSERT_NE(nullptr, defined);
693 const AidlInterface* iface = defined->AsInterface();
694 ASSERT_NE(nullptr, iface);
695
696 const auto& methods = iface->GetMethods();
697 ASSERT_EQ(1u, methods.size());
698 const auto& method = methods[0];
699 const AidlTypeSpecifier& ret_type = method->GetType();
700
701 // TODO(b/151102494): these annotations should be on the method
702 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
703 ASSERT_TRUE(ret_type.IsHide());
704}
705
Devin Moore7b8d5c92020-03-17 14:14:08 -0700706TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100707 string foo_interface =
708 "package a; /* foo */ interface IFoo {"
709 " /* i */ int i();"
710 " /* j */ @nullable String j();"
711 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
712
Devin Moore7b8d5c92020-03-17 14:14:08 -0700713 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100714 EXPECT_NE(nullptr, parse_result);
715 EXPECT_EQ("/* foo */", parse_result->GetComments());
716
717 const AidlInterface* interface = parse_result->AsInterface();
718 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
719 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
720 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
721}
722
Jooyung Han1a551d32020-10-05 15:37:26 +0900723TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
724 io_delegate_.SetFileContents("p/cpp_header.aidl",
725 R"(package p;
726 parcelable cpp_header cpp_header "bar/header";)");
727 import_paths_.emplace("");
728 const string input_path = "p/IFoo.aidl";
729 const string input = R"(package p;
730 import p.cpp_header;
731 interface IFoo {
732 // get bar
733 cpp_header get();
734 })";
735
736 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
737 EXPECT_NE(nullptr, parse_result);
738 const AidlInterface* interface = parse_result->AsInterface();
739 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
740}
741
Christopher Wileyef140932015-11-03 09:29:19 -0800742TEST_F(AidlTest, ParsesPreprocessedFile) {
743 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
744 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700745 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900746 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700747 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
748 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800749}
750
751TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
752 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
753 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900754
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700755 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900756 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700757 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
758 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800759}
760
Devin Moore7b8d5c92020-03-17 14:14:08 -0700761TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800762 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
763 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
764 "interface IBar {}");
765 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900766 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900767 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700768 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800769 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900770
Christopher Wiley41544372015-11-03 14:52:29 -0800771 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700772 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
773 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800774 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700775 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900776 ambiguous_type.Resolve(typenames_);
777 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800778}
779
Jiyong Park8f6ec462020-01-19 20:52:47 +0900780// Special case of PreferImportToPreprocessed. Imported type should be preferred
781// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700782TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900783 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
784 io_delegate_.SetFileContents("one/IBar.aidl",
785 "package one; "
786 "interface IBar {}");
787 preprocessed_files_.push_back("preprocessed");
788 import_paths_.emplace("");
789 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700790 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900791 EXPECT_NE(nullptr, parse_result);
792
793 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700794 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
795 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900796 // But if we request just "IBar" we should get our imported one.
797 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
798 ambiguous_type.Resolve(typenames_);
799 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
800}
801
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800802TEST_F(AidlTest, WritePreprocessedFile) {
803 io_delegate_.SetFileContents("p/Outer.aidl",
804 "package p; parcelable Outer.Inner;");
805 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
806 "interface IBar {}");
807
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900808 vector<string> args {
809 "aidl",
810 "--preprocess",
811 "preprocessed",
812 "p/Outer.aidl",
813 "one/IBar.aidl"};
814 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800815 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
816
817 string output;
818 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
819 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
820}
821
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900822TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100823 io_delegate_.SetFileContents(
824 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800825 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100826 "parcelable Rect {\n"
827 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800828 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100829 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800830 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100831 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100832 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
833 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100834 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900835 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900836 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100837 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900838
839 vector<string> args{"aidl", "Rect.aidl"};
840 Options options = Options::From(args);
841 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
842
843 string output;
844 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900845 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900846}
847
Devin Moore2f2077a2020-08-28 11:27:53 -0700848TEST_F(AidlTest, CppHeaderIncludes) {
849 io_delegate_.SetFileContents("IFoo.aidl",
850 "interface IFoo {\n"
851 " @nullable List<String> foo();\n"
852 "}");
853
854 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
855 Options options = Options::From(args);
856 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
857 std::vector<std::string> empty;
858 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
859 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
860 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
861
862 // Make sure the optional and String16.h includes are added
863 string output;
864 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
865 EXPECT_EQ(kExpectedCppHeaderOutput, output);
866}
867
Devin Moore7b8d5c92020-03-17 14:14:08 -0700868TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700869 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800870 io_delegate_.SetFileContents("p/Outer.aidl",
871 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900872 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700873 CaptureStderr();
874 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
875 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700876 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700877 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800878}
879
Devin Moore7b8d5c92020-03-17 14:14:08 -0700880TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800881 io_delegate_.SetFileContents("preprocessed",
882 "parcelable p.Outer.Inner;");
883 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900884 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700885 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800886 // TODO(wiley): This should actually return nullptr because we require
887 // the outer class name. However, for legacy reasons,
888 // this behavior must be maintained. b/17415692
889 EXPECT_NE(nullptr, parse_result);
890}
891
Christopher Wiley632801d2015-11-05 14:15:49 -0800892TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700893 const string expected_foo_stderr =
894 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
895 "Declared parcelables should be in their own file and/or cannot be used with --structured "
896 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700897 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
898
Christopher Wiley632801d2015-11-05 14:15:49 -0800899 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700900 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700901 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900902 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700903 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900904
Steven Morelande2c64b42018-09-18 15:06:37 -0700905 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900906 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700907 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900908 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700909 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700910
Devin Moore097a3ab2020-03-11 16:08:44 -0700911 const string expected_bar_stderr =
912 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
913 "Declared parcelables should be in their own file and/or cannot be used with --structured "
914 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700915 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
916
Jiyong Parkda8c6932019-08-12 19:56:08 +0900917 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700918 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700919 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900920 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700921 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700922 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700923 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700924 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700925 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800926}
927
Devin Moore7b8d5c92020-03-17 14:14:08 -0700928TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700929 const string expected_stderr =
930 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
931 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700932 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
933 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700934 AidlError error;
935 CaptureStderr();
936 EXPECT_EQ(
937 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700938 Parse("p/IFoo.aidl",
939 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700940 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700941 EXPECT_EQ(expected_stderr, GetCapturedStderr());
942 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700943}
944
Devin Moore7b8d5c92020-03-17 14:14:08 -0700945TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700946 AidlError error;
947 const string expected_stderr =
948 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
949 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900950 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
951 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700952 interface IFoo {
953 const String DUPLICATED = "d";
954 const int DUPLICATED = 1;
955 }
956 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700957 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700958 EXPECT_EQ(expected_stderr, GetCapturedStderr());
959 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700960}
961
Steven Morelande689da22020-11-10 02:06:30 +0000962TEST_P(AidlTest, FailOnTooBigConstant) {
963 AidlError error;
964 const string expected_stderr =
965 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
966 CaptureStderr();
967 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
968 R"(package p;
969 interface IFoo {
970 const byte type2small = 256;
971 }
972 )",
973 typenames_, GetLanguage(), &error));
974 EXPECT_EQ(expected_stderr, GetCapturedStderr());
975 EXPECT_EQ(AidlError::BAD_TYPE, error);
976}
977
Devin Moore7b8d5c92020-03-17 14:14:08 -0700978TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700979 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700980 const string expected_stderr =
981 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700982 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700983 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
984 R"(package p;
985 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700986 parcelable IBar {}
987 parcelable StructuredParcelable {}
988 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900989 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700990 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700991 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700992 // Parse success is important for clear error handling even if the cases aren't
993 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700994 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700995}
996
Devin Moore7b8d5c92020-03-17 14:14:08 -0700997TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700998 AidlError error;
999 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1000 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001001 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1003 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001004}
1005
Steven Morelandf9e922f2020-07-08 21:15:27 +00001006TEST_P(AidlTest, FailOnEmptyListWithComma) {
1007 AidlError error;
1008 const string expected_stderr =
1009 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1010 CaptureStderr();
1011 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1012 typenames_, GetLanguage(), &error));
1013 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1014 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1015}
1016
Devin Moore7b8d5c92020-03-17 14:14:08 -07001017TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001018 AidlError error;
1019 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001020 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001021 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001022 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1023 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001024 interface IFoo {
1025 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1026 }
1027 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001028 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001029 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1030 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001031}
1032
Jiyong Park18132182020-06-08 20:24:40 +09001033TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1034 AidlError error;
1035 const string expected_stderr =
1036 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1037 "cpp_header (which can also be used as an identifier)\n";
1038 CaptureStderr();
1039 // Notice the trailing dot(.) in the name, which isn't a correct name
1040 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1041 GetLanguage(), &error));
1042 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1043 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1044}
1045
1046TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1047 AidlError error;
1048 const string expected_stderr =
1049 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1050 "cpp_header (which can also be used as an identifier)\n";
1051 CaptureStderr();
1052 // Notice the trailing dot(.) in the package name
1053 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1054 GetLanguage(), &error));
1055 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1056 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1057}
1058
Devin Moore7b8d5c92020-03-17 14:14:08 -07001059TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001060 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001061 auto parse_result = Parse("p/IFoo.aidl",
1062 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001063 interface IFoo {
1064 const int POSITIVE_HEX_VALUE = 0xf5;
1065 }
1066 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001067 typenames_, GetLanguage(), &error);
1068 EXPECT_NE(nullptr, parse_result);
1069 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001070 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001071 const auto& cpp_constants = interface->GetConstantDeclarations();
1072 EXPECT_EQ((size_t)1, cpp_constants.size());
1073 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001074 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001075 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001076}
1077
Devin Moore7b8d5c92020-03-17 14:14:08 -07001078TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001079 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001080 auto parse_result = Parse("p/IFoo.aidl",
1081 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001082 interface IFoo {
1083 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1084 }
1085 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001086 typenames_, GetLanguage(), &error);
1087 ASSERT_NE(nullptr, parse_result);
1088 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001089 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001090 const auto& cpp_constants = interface->GetConstantDeclarations();
1091 EXPECT_EQ((size_t)1, cpp_constants.size());
1092 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001093 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001094 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001095}
1096
Devin Moore7b8d5c92020-03-17 14:14:08 -07001097TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001098 io_delegate_.SetFileContents(
1099 "p/Outer.aidl",
1100 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001101 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001102 const string input_path = "p/IFoo.aidl";
1103 const string input = "package p; import p.Outer; interface IFoo"
1104 " { Outer.Inner get(); }";
1105
Devin Moore7b8d5c92020-03-17 14:14:08 -07001106 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1107 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001108
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001109 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001110 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001111 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1112 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001113}
1114
Devin Moore7b8d5c92020-03-17 14:14:08 -07001115TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001116 io_delegate_.SetFileContents(
1117 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001118 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001119 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001120 const string input_path = "p/IFoo.aidl";
1121 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001122 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1123 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001124 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001125 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1126 native_type.Resolve(typenames_);
1127
1128 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1129 // C++ understands C++ specific stuff
1130 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1131 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001132 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001133 EXPECT_EQ(1u, headers.size());
1134 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001135}
1136
Christopher Wileyf8136192016-04-12 14:19:35 -07001137TEST_F(AidlTest, WritesCorrectDependencyFile) {
1138 // While the in tree build system always gives us an output file name,
1139 // other android tools take advantage of our ability to infer the intended
1140 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001141 vector<string> args = {
1142 "aidl",
1143 "-d dep/file/path",
1144 "-o place/for/output",
1145 "p/IFoo.aidl"};
1146 Options options = Options::From(args);
1147 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001148 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001149 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001150 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001151 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1152}
1153
Dan Willemsen93298ee2016-11-10 23:55:55 -08001154TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1155 // While the in tree build system always gives us an output file name,
1156 // other android tools take advantage of our ability to infer the intended
1157 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001158 vector<string> args = {
1159 "aidl",
1160 "-d dep/file/path",
1161 "--ninja",
1162 "-o place/for/output",
1163 "p/IFoo.aidl"};
1164 Options options = Options::From(args);
1165 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001166 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001167 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001168 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001169 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1170}
1171
Jiyong Parkdf202122019-09-30 20:48:35 +09001172TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001173 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1174 // this by calling aidl with every .aidl file it finds, then parsing the
1175 // generated dependency files. Those that reference .java output files are
1176 // for interfaces and those that do not are parcelables. However, for both
1177 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001178 vector<string> args = {
1179 "aidl",
1180 "-o place/for/output",
1181 "-d dep/file/path",
1182 "p/Foo.aidl"};
1183 Options options = Options::From(args);
1184 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001185 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001186 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001187 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001188 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1189}
1190
1191TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1192 vector<string> args = {
1193 "aidl",
1194 "--structured",
1195 "-o place/for/output",
1196 "-d dep/file/path",
1197 "p/Foo.aidl"};
1198 Options options = Options::From(args);
1199 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1200 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1201 string actual_dep_file_contents;
1202 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1203 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001204}
1205
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001206TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1207 vector<string> args = {
1208 "aidl",
1209 "--lang=java",
1210 "-o place/for/output",
1211 "p/Foo.aidl"};
1212 Options options = Options::From(args);
1213 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1214 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1215 string output_file_contents;
1216 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1217}
1218
Jeongik Cha08ca2182019-11-21 14:01:13 +09001219// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001220TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001221 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001222 "package a; interface IFoo {\n"
1223 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001224 string expected_stderr;
1225 switch (GetLanguage()) {
1226 case Options::Language::CPP:
1227 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001228 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001229 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1230 "String and IBinder.\n";
1231 break;
1232 case Options::Language::JAVA:
1233 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001234 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001235 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1236 "String, IBinder, and ParcelFileDescriptor.\n";
1237 break;
1238 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001239 case Options::Language::RUST:
1240 expected_stderr =
1241 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1242 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001243 default:
1244 AIDL_FATAL(AIDL_LOCATION_HERE)
1245 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1246 }
1247 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001248 AidlTypenames tn1;
1249 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001250 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001251
1252 string primitive_parcelable =
1253 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001254 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001255 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001256 AidlTypenames tn2;
1257 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001258 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001259}
1260
Devin Moore21b26772020-08-26 16:37:56 -07001261TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001262 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001263 const string list_array_parcelable =
1264 "package a; parcelable Foo {\n"
1265 " List[] lists; }";
1266 CaptureStderr();
1267 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1268 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1269}
1270
Jiyong Parkf8d53612020-05-04 14:06:13 +09001271TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1272 AidlError error;
1273 string expected_stderr =
1274 "ERROR: a/IFoo.aidl:2.7-11: "
1275 "Encountered an untyped List or Map. The use of untyped List/Map is "
1276 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1277 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1278 if (GetLanguage() != Options::Language::JAVA) {
1279 expected_stderr =
1280 "ERROR: a/IFoo.aidl:2.1-7: "
1281 "Currently, only the Java backend supports non-generic List.\n";
1282 }
1283
1284 const string primitive_interface =
1285 "package a; interface IFoo {\n"
1286 " List foo(); }";
1287 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001288 AidlTypenames tn1;
1289 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001290 {"--structured"}));
1291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001292
1293 string primitive_parcelable =
1294 "package a; parcelable IFoo {\n"
1295 " List foo;}";
1296 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001297 AidlTypenames tn2;
1298 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001299 {"--structured"}));
1300 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1301}
1302
Jeongik Cha225519b2020-08-29 01:55:32 +09001303TEST_P(AidlTest, ExtensionTest) {
1304 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001305 string extendable_parcelable =
1306 "package a; parcelable Data {\n"
1307 " ParcelableHolder extension;\n"
1308 " ParcelableHolder extension2;\n"
1309 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001310 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001311 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1312 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001313 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001314 "yet.\n",
1315 GetCapturedStderr());
1316 } else {
1317 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1318 EXPECT_EQ("", GetCapturedStderr());
1319 }
1320}
1321TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1322 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001323 string parcelableholder_return_interface =
1324 "package a; interface IFoo {\n"
1325 " ParcelableHolder foo();\n"
1326 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001327 EXPECT_EQ(nullptr,
1328 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001329
Jeongik Cha8f02a532020-10-14 00:16:28 +09001330 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001331 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001332 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001333 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001334 "yet.\n",
1335 GetCapturedStderr());
1336 return;
1337 }
1338 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1339 GetCapturedStderr());
1340}
1341
1342TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1343 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001344 string extendable_parcelable_arg_interface =
1345 "package a; interface IFoo {\n"
1346 " void foo(in ParcelableHolder ph);\n"
1347 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001348 EXPECT_EQ(nullptr,
1349 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1350
Jeongik Cha8f02a532020-10-14 00:16:28 +09001351 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001352 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001353 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001354 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001355 "yet.\n",
1356 GetCapturedStderr());
1357 return;
1358 }
1359 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1360 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001361}
1362
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001363TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1364 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1365 Options options =
1366 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1367 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1368 CaptureStderr();
1369 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1370 if (GetLanguage() == Options::Language::RUST) {
1371 EXPECT_EQ(
1372 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1373 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1374 "yet.\n",
1375 GetCapturedStderr());
1376 return;
1377 }
1378 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1379}
1380
Jooyung Han3f347ca2020-12-01 12:41:50 +09001381TEST_P(AidlTest, ParcelablesWithConstants) {
1382 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
1383 Options options =
1384 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1385 CaptureStderr();
1386 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1387 EXPECT_EQ("", GetCapturedStderr());
1388}
1389
1390TEST_P(AidlTest, UnionWithConstants) {
1391 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
1392 Options options =
1393 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1394 CaptureStderr();
1395 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1396 EXPECT_EQ("", GetCapturedStderr());
1397}
1398
Jiyong Park02da7422018-07-16 16:00:26 +09001399TEST_F(AidlTest, ApiDump) {
1400 io_delegate_.SetFileContents(
1401 "foo/bar/IFoo.aidl",
1402 "package foo.bar;\n"
1403 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001404 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001405 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001406 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001407 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1408 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1409 " IFoo foo3(IFoo foo);\n"
1410 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001411 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001412 " const int A = 1;\n"
1413 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001414 "}\n");
1415 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1416 "package foo.bar;\n"
1417 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001418 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001419 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001420 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001421 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001422 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001423 " int y;\n"
1424 " IFoo foo;\n"
1425 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001426 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001427 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001428 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001429 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001430 "}\n");
1431 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001432 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1433 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001434 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001435 bool result = dump_api(options, io_delegate_);
1436 ASSERT_TRUE(result);
1437 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001438 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001439 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001440/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001441interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001442 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001443 int foo(out int[] a, String b, boolean c, inout List<String> d);
1444 int foo2(@utf8InCpp String x, inout List<String> y);
1445 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1446 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001447 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001448 const int A = 1;
1449 const String STR = "Hello";
1450}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001451)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001452
Jiyong Parke59c3682018-09-11 23:10:25 +09001453 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001454 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001455/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001456parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001457 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001458 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001459 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001460 int y;
1461 foo.bar.IFoo foo;
1462 List<foo.bar.IFoo> a;
1463 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001464 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001465 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001466}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001467)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001468}
1469
Jiyong Parked65bf42018-08-28 15:43:27 +09001470TEST_F(AidlTest, ApiDumpWithManualIds) {
1471 io_delegate_.SetFileContents(
1472 "foo/bar/IFoo.aidl",
1473 "package foo.bar;\n"
1474 "interface IFoo {\n"
1475 " int foo() = 1;\n"
1476 " int bar() = 2;\n"
1477 " int baz() = 10;\n"
1478 "}\n");
1479
Jiyong Parke59c3682018-09-11 23:10:25 +09001480 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001481 Options options = Options::From(args);
1482 bool result = dump_api(options, io_delegate_);
1483 ASSERT_TRUE(result);
1484 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001485 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001486 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001487interface IFoo {
1488 int foo() = 1;
1489 int bar() = 2;
1490 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001491}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001492)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001493}
1494
1495TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001496 const string expected_stderr =
1497 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1498 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001499 io_delegate_.SetFileContents(
1500 "foo/bar/IFoo.aidl",
1501 "package foo.bar;\n"
1502 "interface IFoo {\n"
1503 " int foo() = 1;\n"
1504 " int bar();\n"
1505 " int baz() = 10;\n"
1506 "}\n");
1507
Jiyong Parke59c3682018-09-11 23:10:25 +09001508 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001509 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001510 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001511 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001512 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001513}
1514
Jooyung Han965e31d2020-11-27 12:30:16 +09001515TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1516 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1517 "package foo.bar;\n"
1518 "interface IFoo {\n"
1519 " @utf8InCpp String foo();\n"
1520 " const @utf8InCpp String bar = \"bar\";\n"
1521 "}\n");
1522
1523 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1524 Options options = Options::From(args);
1525 CaptureStderr();
1526 EXPECT_TRUE(dump_api(options, io_delegate_));
1527 EXPECT_EQ("", GetCapturedStderr());
1528 string actual;
1529 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001530 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1531interface IFoo {
1532 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001533 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001534}
1535)"),
1536 actual);
1537}
1538
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001539TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001540 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001541 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1542 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001543 const string expected_map_stderr =
1544 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001545 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1546 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001547 "package p; interface IFoo {"
1548 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001549 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001550 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001551 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001552
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001553 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001554 "package p; interface IFoo {"
1555 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001556 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001557 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001558 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001559}
1560
Jeongik Chae48d9942020-01-02 17:39:00 +09001561TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001562 const string expected_stderr =
1563 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001564 Options options = Options::From("aidl -I p p/IFoo.aidl");
1565 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1566
1567 io_delegate_.SetFileContents("p/IFoo.aidl",
1568 "package p; interface IFoo {"
1569 "Map<String, Bar> foo();}");
1570 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1571
1572 io_delegate_.SetFileContents("p/IFoo.aidl",
1573 "package p; interface IFoo {"
1574 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001575 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001576 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001577 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001578
1579 io_delegate_.SetFileContents("p/IFoo.aidl",
1580 "package p; interface IFoo {"
1581 "Map<String, String> foo();}");
1582 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1583
1584 io_delegate_.SetFileContents("p/IFoo.aidl",
1585 "package p; interface IFoo {"
1586 "Map<String, ParcelFileDescriptor> foo();}");
1587 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1588}
1589
Jeongik Chadf76dc72019-11-28 00:08:47 +09001590TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001591 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001592 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1593 io_delegate_.SetFileContents(options.InputFiles().front(),
1594 "package p; interface IFoo {"
1595 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001596 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001597 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001598 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001599}
1600
1601TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1602 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1603 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001604 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001605 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001606 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1607 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001608
1609 Options options = Options::From("aidl -I p p/IFoo.aidl");
1610 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1611 io_delegate_.SetFileContents("p/IFoo.aidl",
1612 "package p; interface IFoo {"
1613 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001614 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001615 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001616 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001617 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001618 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001619 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001620 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1621 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001622 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1623 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1624 io_delegate_.SetFileContents("p/IFoo.aidl",
1625 "package p; interface IFoo {"
1626 "Bar<String, ParcelFileDescriptor> foo();}");
1627 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001628
1629 io_delegate_.SetFileContents("p/IFoo.aidl",
1630 "package p; interface IFoo {"
1631 "Bar<int, long> foo();}");
1632
1633 io_delegate_.SetFileContents("p/IFoo.aidl",
1634 "package p; interface IFoo {"
1635 "Bar<int[], long[]> foo();}");
1636
1637 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001638}
1639
Jeongik Cha0e426012019-07-29 15:57:02 +09001640TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1641 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001642 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1643 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001644 for (const auto& rawOption : rawOptions) {
1645 string expected_stderr =
1646 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001647 Options options = Options::From(rawOption);
1648 io_delegate_.SetFileContents(options.InputFiles().front(),
1649 "package foo.bar;\n"
1650 "interface IFoo1 { int foo(); }\n"
1651 "interface IFoo2 { int foo(); }\n"
1652 "parcelable Data1 { int a; int b;}\n"
1653 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001654 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001655 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001656 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001657
Jeongik Cha0e426012019-07-29 15:57:02 +09001658 io_delegate_.SetFileContents(options.InputFiles().front(),
1659 "package foo.bar;\n"
1660 "interface IFoo1 { int foo(); }\n"
1661 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001662 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001663 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001664 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001665
Devin Moore5de18ed2020-04-02 13:52:29 -07001666 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001667 io_delegate_.SetFileContents(options.InputFiles().front(),
1668 "package foo.bar;\n"
1669 "parcelable Data1 { int a; int b;}\n"
1670 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001671 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001672 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001673 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001674 }
1675}
1676
Devin Moorebdba2a82020-03-31 15:19:02 -07001677TEST_P(AidlTest, FailParseOnEmptyFile) {
1678 const string contents = "";
1679 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1680 CaptureStderr();
1681 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1682 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1683}
1684
Jiyong Parkb034bf02018-07-30 17:44:33 +09001685TEST_F(AidlTest, MultipleInputFiles) {
1686 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001687 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001688
1689 io_delegate_.SetFileContents(options.InputFiles().at(0),
1690 "package foo.bar;\n"
1691 "import foo.bar.Data;\n"
1692 "interface IFoo { Data getData(); }\n");
1693
1694 io_delegate_.SetFileContents(options.InputFiles().at(1),
1695 "package foo.bar;\n"
1696 "import foo.bar.IFoo;\n"
1697 "parcelable Data { IFoo foo; }\n");
1698
1699 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1700
1701 string content;
1702 for (const auto file : {
1703 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1704 content.clear();
1705 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1706 EXPECT_FALSE(content.empty());
1707 }
1708}
1709
1710TEST_F(AidlTest, MultipleInputFilesCpp) {
1711 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001712 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001713
1714 io_delegate_.SetFileContents(options.InputFiles().at(0),
1715 "package foo.bar;\n"
1716 "import foo.bar.Data;\n"
1717 "interface IFoo { Data getData(); }\n");
1718
1719 io_delegate_.SetFileContents(options.InputFiles().at(1),
1720 "package foo.bar;\n"
1721 "import foo.bar.IFoo;\n"
1722 "parcelable Data { IFoo foo; }\n");
1723
1724 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1725
1726 string content;
1727 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001728 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001729 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1730 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1731 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1732 content.clear();
1733 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1734 EXPECT_FALSE(content.empty());
1735 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001736}
1737
Andrei Homescub62afd92020-05-11 19:24:59 -07001738TEST_F(AidlTest, MultipleInputFilesRust) {
1739 Options options =
1740 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1741
1742 io_delegate_.SetFileContents(options.InputFiles().at(0),
1743 "package foo.bar;\n"
1744 "import foo.bar.Data;\n"
1745 "interface IFoo { Data getData(); }\n");
1746
1747 io_delegate_.SetFileContents(options.InputFiles().at(1),
1748 "package foo.bar;\n"
1749 "import foo.bar.IFoo;\n"
1750 "parcelable Data { IFoo foo; }\n");
1751
1752 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1753
1754 string content;
1755 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1756 content.clear();
1757 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1758 EXPECT_FALSE(content.empty());
1759 }
1760}
1761
Devin Moore097a3ab2020-03-11 16:08:44 -07001762TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1763 const string expected_stderr =
1764 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001765 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1766 // int getInterfaceVersion() is one of the meta transactions
1767 io_delegate_.SetFileContents(options.InputFiles().front(),
1768 "package p; interface IFoo {"
1769 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001770 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001771 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001772 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1773}
Jiyong Park309668e2018-07-28 16:55:44 +09001774
Devin Moore097a3ab2020-03-11 16:08:44 -07001775TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1776 // boolean getInterfaceVersion() is not a meta transaction, but should be
1777 // prevented because return type is not part of a method signature
1778 const string expected_stderr =
1779 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1780 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001781 io_delegate_.SetFileContents(options.InputFiles().front(),
1782 "package p; interface IFoo {"
1783 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001784 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001785 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001786 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1787}
Jiyong Park309668e2018-07-28 16:55:44 +09001788
Devin Moore097a3ab2020-03-11 16:08:44 -07001789TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001790 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001791 const string expected_stderr =
1792 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1793 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001794 io_delegate_.SetFileContents(options.InputFiles().front(),
1795 "package p; interface IFoo {"
1796 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001797 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001798 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001799 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001800
1801 // this is not a meta interface method as it differs type arguments
1802 io_delegate_.SetFileContents(options.InputFiles().front(),
1803 "package p; interface IFoo {"
1804 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001805 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001806}
1807
Daniel Norman85aed542019-08-21 12:01:14 -07001808TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001809 Options options = Options::From("aidl --checkapi old new");
1810 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1811 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1812 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1813 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1814
1815 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1816}
1817
Jiyong Park3656c3c2018-08-01 20:02:01 +09001818TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001819 Options options = Options::From("aidl --checkapi old new");
1820 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1821 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001822
1823 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1824}
1825
Daniel Norman85aed542019-08-21 12:01:14 -07001826class AidlTestCompatibleChanges : public AidlTest {
1827 protected:
1828 Options options_ = Options::From("aidl --checkapi old new");
1829};
1830
1831TEST_F(AidlTestCompatibleChanges, NewType) {
1832 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1833 "package p;"
1834 "interface IFoo {"
1835 " void foo(int a);"
1836 "}");
1837 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1838 "package p;"
1839 "interface IFoo {"
1840 " void foo(int a);"
1841 "}");
1842 io_delegate_.SetFileContents("new/p/IBar.aidl",
1843 "package p;"
1844 "interface IBar {"
1845 " void bar();"
1846 "}");
1847 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1848}
1849
1850TEST_F(AidlTestCompatibleChanges, NewMethod) {
1851 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1852 "package p;"
1853 "interface IFoo {"
1854 " void foo(int a);"
1855 "}");
1856 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1857 "package p;"
1858 "interface IFoo {"
1859 " void foo(int a);"
1860 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001861 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001862 "}");
1863 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1864}
1865
1866TEST_F(AidlTestCompatibleChanges, NewField) {
1867 io_delegate_.SetFileContents("old/p/Data.aidl",
1868 "package p;"
1869 "parcelable Data {"
1870 " int foo;"
1871 "}");
1872 io_delegate_.SetFileContents("new/p/Data.aidl",
1873 "package p;"
1874 "parcelable Data {"
1875 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001876 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001877 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001878 "}");
1879 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1880}
1881
1882TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1883 io_delegate_.SetFileContents("old/p/Enum.aidl",
1884 "package p;"
1885 "enum Enum {"
1886 " FOO = 1,"
1887 "}");
1888 io_delegate_.SetFileContents("new/p/Enum.aidl",
1889 "package p;"
1890 "enum Enum {"
1891 " FOO = 1,"
1892 " BAR = 2,"
1893 "}");
1894 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1895}
1896
1897TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1898 io_delegate_.SetFileContents("old/p/Enum.aidl",
1899 "package p;"
1900 "enum Enum {"
1901 " FOO = 1,"
1902 " BAR = 2,"
1903 "}");
1904 io_delegate_.SetFileContents("new/p/Enum.aidl",
1905 "package p;"
1906 "enum Enum {"
1907 " BAR = 2,"
1908 " FOO = 1,"
1909 "}");
1910 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1911}
1912
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001913TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1914 io_delegate_.SetFileContents("old/p/Union.aidl",
1915 "package p;"
1916 "union Union {"
1917 " String foo;"
1918 "}");
1919 io_delegate_.SetFileContents("new/p/Union.aidl",
1920 "package p;"
1921 "union Union {"
1922 " String foo;"
1923 " int num;"
1924 "}");
1925 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1926}
1927
Daniel Norman85aed542019-08-21 12:01:14 -07001928TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001929 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1930 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001931 "interface IFoo {"
1932 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001933 "}");
1934 io_delegate_.SetFileContents("old/p/Data.aidl",
1935 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001936 "parcelable Data {"
1937 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001938 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001939 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1940 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001941 "interface IFoo {"
1942 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001943 "}");
1944 io_delegate_.SetFileContents("new/p/Data.aidl",
1945 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001946 "parcelable Data {"
1947 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001948 "}");
1949 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1950 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001951 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001952 " void foo(int a);"
1953 "}");
1954 io_delegate_.SetFileContents("new/q/Data.aidl",
1955 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001956 "parcelable Data {"
1957 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001958 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001959 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1960}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001961
Daniel Norman85aed542019-08-21 12:01:14 -07001962TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1963 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1964 "package p;"
1965 "interface IFoo {"
1966 " void foo(int a);"
1967 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001968 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1969 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001970 "interface IFoo {"
1971 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001972 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001973 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1974}
Jiyong Parke59c3682018-09-11 23:10:25 +09001975
Daniel Norman85aed542019-08-21 12:01:14 -07001976TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001977 io_delegate_.SetFileContents("old/p/I.aidl",
1978 "package p; interface I {"
1979 "const int A = 1; }");
1980 io_delegate_.SetFileContents("new/p/I.aidl",
1981 "package p ; interface I {"
1982 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001983 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1984}
Jiyong Parka428d212018-08-29 22:26:30 +09001985
Daniel Norman85aed542019-08-21 12:01:14 -07001986TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001987 io_delegate_.SetFileContents("old/p/I.aidl",
1988 "package p; interface I {"
1989 "const int A = 1; const int B = 2;}");
1990 io_delegate_.SetFileContents("new/p/I.aidl",
1991 "package p ; interface I {"
1992 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001993 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001994}
1995
Jooyung Han69ea4ba2020-10-29 15:33:37 +09001996TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
1997 io_delegate_.SetFileContents("old/p/Foo.aidl",
1998 "package p;"
1999 "@JavaPassthrough(annotation=\"Alice\")"
2000 "@JavaPassthrough(annotation=\"Bob\")"
2001 "parcelable Foo {}");
2002 io_delegate_.SetFileContents("new/p/Foo.aidl",
2003 "package p;"
2004 "@JavaPassthrough(annotation=\"Bob\")"
2005 "@JavaPassthrough(annotation=\"Alice\")"
2006 "parcelable Foo {}");
2007 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2008}
2009
Jooyung Han00073272020-11-27 14:20:20 +09002010TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2011 io_delegate_.SetFileContents("old/p/Foo.aidl",
2012 "package p;"
2013 "parcelable Foo {}");
2014 io_delegate_.SetFileContents("new/p/Foo.aidl",
2015 "package p;"
2016 "@JavaPassthrough(annotation=\"@Deprecated\")"
2017 "parcelable Foo {}");
2018 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2019}
2020
Jooyung Han636fd2f2020-10-22 11:33:45 +09002021TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2022 io_delegate_.SetFileContents("old/p/Data.aidl",
2023 "package p;"
2024 "parcelable Data {"
2025 " int num;"
2026 "}");
2027 io_delegate_.SetFileContents(
2028 "new/p/Data.aidl",
2029 "package p;"
2030 "parcelable Data {"
2031 " int num;"
2032 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2033 "}");
2034 io_delegate_.SetFileContents("new/p/Enum.aidl",
2035 "package p;"
2036 "enum Enum {"
2037 " FOO = 0,"
2038 " BAR = 1,"
2039 "}");
2040 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2041}
2042
Daniel Norman85aed542019-08-21 12:01:14 -07002043class AidlTestIncompatibleChanges : public AidlTest {
2044 protected:
2045 Options options_ = Options::From("aidl --checkapi old new");
2046};
2047
2048TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002049 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002050 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2051 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002052 "interface IFoo {"
2053 " void foo(in String[] str);"
2054 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002055 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002056 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002057 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002058 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002059}
2060
2061TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002062 const string expected_stderr =
2063 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002064 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2065 "package p;"
2066 "interface IFoo {"
2067 " void foo(in String[] str);"
2068 " void bar(@utf8InCpp String str);"
2069 "}");
2070 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2071 "package p;"
2072 "interface IFoo {"
2073 " void foo(in String[] str);"
2074 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002075 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002076 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002077 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002078}
2079
Jiyong Parkf8d53612020-05-04 14:06:13 +09002080TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2081 const string expected_stderr =
2082 "ERROR: new/p/IFoo.aidl:1.61-65: "
2083 "Encountered an untyped List or Map. The use of untyped List/Map is "
2084 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2085 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2086 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2087 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2088 "package p;"
2089 "interface IFoo {"
2090 " void foo(in String[] str);"
2091 "}");
2092 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2093 "package p;"
2094 "interface IFoo {"
2095 " void foo(in String[] str);"
2096 " void bar(in List arg);"
2097 "}");
2098 CaptureStderr();
2099 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2100 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2101}
2102
2103TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2104 const string expected_stderr =
2105 "ERROR: new/p/Data.aidl:1.54-59: "
2106 "Encountered an untyped List or Map. The use of untyped List/Map is "
2107 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2108 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2109 "ERROR: new/p/Data.aidl: Failed to read.\n";
2110 io_delegate_.SetFileContents("old/p/Data.aidl",
2111 "package p;"
2112 "parcelable Data {"
2113 " int foo;"
2114 "}");
2115 io_delegate_.SetFileContents("new/p/Data.aidl",
2116 "package p;"
2117 "parcelable Data {"
2118 " int foo;"
2119 " @nullable List list;"
2120 "}");
2121 CaptureStderr();
2122 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2123 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2124}
2125
Daniel Norman85aed542019-08-21 12:01:14 -07002126TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002127 const string expected_stderr =
2128 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002129 io_delegate_.SetFileContents("old/p/Data.aidl",
2130 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002131 "parcelable Data {"
2132 " int foo;"
2133 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002134 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002135 io_delegate_.SetFileContents("new/p/Data.aidl",
2136 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002137 "parcelable Data {"
2138 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002139 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002140 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002141 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002142 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002143}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002144
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002145TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2146 const string expected_stderr =
2147 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2148 "backends. Please either provide a default value for this field or mark the field as "
2149 "@nullable. This value or a null value will be used automatically when an old version of "
2150 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2151 "order to make sure your code continues to be backwards compatible, make sure the default or "
2152 "null value does not cause a semantic change to this parcelable.\n";
2153 io_delegate_.SetFileContents("old/p/Data.aidl",
2154 "package p;"
2155 "parcelable Data {"
2156 " int num;"
2157 "}");
2158 io_delegate_.SetFileContents("new/p/Data.aidl",
2159 "package p;"
2160 "parcelable Data {"
2161 " int num;"
2162 " String str;"
2163 "}");
2164 CaptureStderr();
2165 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2166 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2167}
2168
Jooyung Han636fd2f2020-10-22 11:33:45 +09002169TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2170 const string expected_stderr =
2171 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2172 "Please make sure 'Enum' has '0' as a valid value.\n";
2173 io_delegate_.SetFileContents("old/p/Data.aidl",
2174 "package p;"
2175 "parcelable Data {"
2176 " int num;"
2177 "}");
2178 io_delegate_.SetFileContents("new/p/Data.aidl",
2179 "package p;"
2180 "parcelable Data {"
2181 " int num;"
2182 " p.Enum e;"
2183 "}");
2184 io_delegate_.SetFileContents("new/p/Enum.aidl",
2185 "package p;"
2186 "enum Enum {"
2187 " FOO = 1,"
2188 " BAR = 2,"
2189 "}");
2190 CaptureStderr();
2191 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2192 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2193}
2194
Daniel Norman85aed542019-08-21 12:01:14 -07002195TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002196 const string expected_stderr =
2197 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002198 io_delegate_.SetFileContents("old/p/Enum.aidl",
2199 "package p;"
2200 "enum Enum {"
2201 " FOO = 1,"
2202 " BAR = 2,"
2203 "}");
2204 io_delegate_.SetFileContents("new/p/Enum.aidl",
2205 "package p;"
2206 "enum Enum {"
2207 " BAR = 2,"
2208 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002209 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002210 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002211 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002212}
2213
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002214TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2215 const string expected_stderr =
2216 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2217 io_delegate_.SetFileContents("old/p/Union.aidl",
2218 "package p;"
2219 "union Union {"
2220 " String str;"
2221 " int num;"
2222 "}");
2223 io_delegate_.SetFileContents("new/p/Union.aidl",
2224 "package p;"
2225 "union Union {"
2226 " String str;"
2227 "}");
2228 CaptureStderr();
2229 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2231}
2232
Daniel Norman85aed542019-08-21 12:01:14 -07002233TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002234 const string expected_stderr =
2235 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002236 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2237 "package p;"
2238 "interface IFoo {"
2239 " void foo(in String[] str);"
2240 " void bar(@utf8InCpp String str);"
2241 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002242 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2243 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002244 "interface IFoo {"
2245 " void foo(in String[] str);"
2246 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002247 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002248 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002249 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002250 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002251}
2252
Daniel Norman85aed542019-08-21 12:01:14 -07002253TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002254 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002255 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2256 "package p;"
2257 "interface IFoo {"
2258 " void foo(in String[] str);"
2259 " void bar(@utf8InCpp String str);"
2260 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002261 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2262 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002263 "interface IFoo2 {"
2264 " void foo(in String[] str);"
2265 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002266 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002267 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002268 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002269 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002270}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002271
Daniel Norman85aed542019-08-21 12:01:14 -07002272TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002273 const string expected_stderr =
2274 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002275 io_delegate_.SetFileContents("old/p/Enum.aidl",
2276 "package p;"
2277 "enum Enum {"
2278 " FOO = 1,"
2279 " BAR = 2,"
2280 "}");
2281 io_delegate_.SetFileContents("new/p/Enum.aidl",
2282 "package p;"
2283 "enum Enum {"
2284 " FOO = 3,"
2285 " BAR = 2,"
2286 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002287 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002288 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002289 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002290}
2291
2292TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002293 const string expected_stderr =
2294 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2295 "from 0 to 1.\n"
2296 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2297 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002298 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2299 "package p;"
2300 "interface IFoo {"
2301 " void foo(in String[] str);"
2302 " void bar(@utf8InCpp String str);"
2303 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002304 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2305 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002306 "interface IFoo {"
2307 " void bar(@utf8InCpp String str);"
2308 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002309 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002310 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002311 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002312 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002313}
2314
2315TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002316 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002317 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2318 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002319 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002320 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002321 "parcelable Data {"
2322 " int foo;"
2323 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002324 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002325 io_delegate_.SetFileContents("new/p/Data.aidl",
2326 "package p;"
2327 "parcelable Data {"
2328 " int bar;"
2329 " int foo;"
2330 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002331 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002332 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002333 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002334}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002335
Daniel Norman85aed542019-08-21 12:01:14 -07002336TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002337 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002338 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002339 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002340 "interface IFoo {"
2341 " void foo(in String[] str);"
2342 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002343 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002344 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2345 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002346 "interface IFoo {"
2347 " void foo(out String[] str);"
2348 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002349 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002350 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002351 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002352 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002353}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002354
Daniel Norman85aed542019-08-21 12:01:14 -07002355TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002356 const string expected_stderr =
2357 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002358 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2359 "package p;"
2360 "interface IFoo {"
2361 " void foo(in String[] str);"
2362 " void bar(@utf8InCpp String str);"
2363 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002364 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2365 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002366 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002367 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002368 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002369 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002370 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002371 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002372 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002373}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002374
Daniel Norman85aed542019-08-21 12:01:14 -07002375TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002376 const string expected_stderr =
2377 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002378 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2379 "package p;"
2380 "interface IFoo {"
2381 " void foo(in String[] str);"
2382 " void bar(@utf8InCpp String str);"
2383 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002384 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2385 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002386 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002387 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002388 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002389 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002390 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002391 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002393}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002394
Jooyung Han60b2fde2020-10-29 15:12:40 +09002395TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2396 const string expected_stderr =
2397 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2398 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2399 io_delegate_.SetFileContents("old/p/Foo.aidl",
2400 "package p;"
2401 "@Backing(type=\"byte\")"
2402 "enum Foo {"
2403 " FOO, BAR,"
2404 "}");
2405 io_delegate_.SetFileContents("new/p/Foo.aidl",
2406 "package p;"
2407 "@Backing(type=\"long\")"
2408 "enum Foo {"
2409 " FOO, BAR,"
2410 "}");
2411 CaptureStderr();
2412 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2413 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2414}
2415
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002416TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2417 const string expected_stderr =
2418 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2419 "to @JavaPassthrough(annotation=\"Bob\")\n";
2420 io_delegate_.SetFileContents("old/p/Foo.aidl",
2421 "package p;"
2422 "@JavaPassthrough(annotation=\"Alice\")"
2423 "parcelable Foo {}");
2424 io_delegate_.SetFileContents("new/p/Foo.aidl",
2425 "package p;"
2426 "@JavaPassthrough(annotation=\"Bob\")"
2427 "parcelable Foo {}");
2428
2429 CaptureStderr();
2430 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2431 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2432}
2433
Devin Mooredb7ac512020-08-07 11:17:36 -07002434TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2435 const string expected_stderr =
2436 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2437 io_delegate_.SetFileContents("old/p/Foo.aidl",
2438 "package p;"
2439 "parcelable Foo {"
2440 " int A;"
2441 "}");
2442 io_delegate_.SetFileContents("new/p/Foo.aidl",
2443 "package p;"
2444 "@JavaOnlyStableParcelable parcelable Foo {"
2445 " int A;"
2446 "}");
2447 CaptureStderr();
2448 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2449 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2450}
2451
2452TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2453 const string expected_stderr =
2454 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2455 io_delegate_.SetFileContents("old/p/Foo.aidl",
2456 "package p;"
2457 "@JavaOnlyStableParcelable parcelable Foo {"
2458 " int A;"
2459 "}");
2460 io_delegate_.SetFileContents("new/p/Foo.aidl",
2461 "package p;"
2462 "parcelable Foo {"
2463 " int A;"
2464 "}");
2465 CaptureStderr();
2466 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2468}
2469
Daniel Norman85aed542019-08-21 12:01:14 -07002470TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002471 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002472 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2473 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002474 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002475 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002476 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002477 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002478}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002479
Daniel Norman85aed542019-08-21 12:01:14 -07002480TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002481 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002482 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2483 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002484 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002485 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002486 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002487}
Jiyong Parka428d212018-08-29 22:26:30 +09002488
Daniel Norman85aed542019-08-21 12:01:14 -07002489TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002490 const string expected_stderr =
2491 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002492 io_delegate_.SetFileContents("old/p/I.aidl",
2493 "package p; interface I {"
2494 "const int A = 1; const int B = 2;}");
2495 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002496 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002497 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002498 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002499}
Jiyong Parka428d212018-08-29 22:26:30 +09002500
Daniel Norman85aed542019-08-21 12:01:14 -07002501TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002502 const string expected_stderr =
2503 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002504 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2505 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002506 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002507 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002508 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002509}
2510
Devin Moorec7e47a32020-08-07 10:55:25 -07002511TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2512 const string expected_stderr =
2513 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2514 "This is an incompatible change for FixedSize types.\n";
2515 io_delegate_.SetFileContents("old/p/Foo.aidl",
2516 "package p; @FixedSize parcelable Foo { int A = 1; }");
2517 io_delegate_.SetFileContents("new/p/Foo.aidl",
2518 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2519 CaptureStderr();
2520 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2521 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2522}
2523
2524TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2525 const string expected_stderr =
2526 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2527 io_delegate_.SetFileContents("old/p/Foo.aidl",
2528 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2529 io_delegate_.SetFileContents("new/p/Foo.aidl",
2530 "package p; @FixedSize parcelable Foo { int A = 1; }");
2531 CaptureStderr();
2532 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2533 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2534}
2535
2536TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2537 const string expected_stderr =
2538 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2539 "a.\n"
2540 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2541 "b.\n"
2542 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2543 "c.\n"
2544 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2545 "d.\n"
2546 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2547 "e.\n"
2548 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2549 "f.\n";
2550
2551 io_delegate_.SetFileContents("Foo.aidl",
2552 "@FixedSize parcelable Foo { "
2553 " int[] a;"
2554 " Bar b;"
2555 " String c;"
2556 " ParcelFileDescriptor d;"
2557 " IBinder e;"
2558 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002559 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002560 "}");
2561 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2562 Options options =
2563 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2564
2565 CaptureStderr();
2566 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2567 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2568}
2569
2570TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2571 const string expected_stderr = "";
2572
2573 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2574 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2575 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2576 Options options =
2577 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2578
2579 CaptureStderr();
2580 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2581 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2582}
2583
Jiyong Park8c380532018-08-30 14:55:26 +09002584TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002585 const string expected_stderr =
2586 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2587 "dir1/q/IBar.aidl\n"
2588 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002589 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002590 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2591 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2592 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2593 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2594
Devin Moore097a3ab2020-03-11 16:08:44 -07002595 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002596 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002597 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002598}
2599
Jiyong Parked65bf42018-08-28 15:43:27 +09002600TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002601 const string expected_stderr =
2602 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2603 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002604 Options options = Options::From("aidl --checkapi old new");
2605 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2606 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002607
2608 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2609
Jiyong Parke59c3682018-09-11 23:10:25 +09002610 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002611 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002612 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002613 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002614}
2615
Jiyong Parke05195e2018-10-08 18:24:23 +09002616TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2617 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2618 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002619 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002620
2621 // use without import
2622 io_delegate_.SetFileContents("p/IFoo.aidl",
2623 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2624 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2625 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002626 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002627
Devin Moore7b8d5c92020-03-17 14:14:08 -07002628 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002629 io_delegate_.SetFileContents(
2630 "p/IFoo.aidl",
2631 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2632 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2633 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002634 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002635
2636 // use with import (as before)
2637 io_delegate_.SetFileContents("p/IFoo.aidl",
2638 "package p;"
2639 "import android.os.ParcelFileDescriptor;"
2640 "interface IFoo{"
2641 " void foo(in ParcelFileDescriptor fd);"
2642 "}");
2643 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2644 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002645 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002646}
Jiyong Parked65bf42018-08-28 15:43:27 +09002647
Jiyong Park3633b722019-04-11 15:38:26 +09002648TEST_F(AidlTest, ManualIds) {
2649 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2650 io_delegate_.SetFileContents("IFoo.aidl",
2651 "interface IFoo {\n"
2652 " void foo() = 0;\n"
2653 " void bar() = 1;\n"
2654 "}");
2655 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2656}
2657
2658TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2659 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2660 io_delegate_.SetFileContents("IFoo.aidl",
2661 "interface IFoo {\n"
2662 " void foo() = 0;\n"
2663 " void bar() = 1;\n"
2664 "}");
2665 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2666}
2667
2668TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002669 const string expected_stderr =
2670 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002671 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2672 io_delegate_.SetFileContents("IFoo.aidl",
2673 "interface IFoo {\n"
2674 " void foo() = 3;\n"
2675 " void bar() = 3;\n"
2676 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002677 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002678 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002679 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002680}
2681
2682TEST_F(AidlTest, FailOnOutOfRangeIds) {
2683 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002684 const string expected_stderr =
2685 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2686 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002687 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2688 io_delegate_.SetFileContents("IFoo.aidl",
2689 "interface IFoo {\n"
2690 " void foo() = 3;\n"
2691 " void bar() = 16777115;\n"
2692 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002693 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002694 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002695 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002696}
2697
2698TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002699 const string expected_stderr =
2700 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002701 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2702 io_delegate_.SetFileContents("IFoo.aidl",
2703 "interface IFoo {\n"
2704 " void foo() = 3;\n"
2705 " void bar();\n"
2706 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002707 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002708 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002709 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002710}
2711
Jiyong Parkc6816252019-07-08 08:12:28 +09002712TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2713 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2714 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2715 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2716 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2717}
2718
2719TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002720 const string expected_stderr =
2721 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2722 "dir/IBar.aidl\n"
2723 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002724 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002725
Jiyong Parkc6816252019-07-08 08:12:28 +09002726 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2727 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2728 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2729 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002730 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002731 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002732 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002733}
2734
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002735TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2736 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2737 "package a.b;\n"
2738 "import a.b.IBar;\n"
2739 "import a.b.IQux;\n"
2740 "interface IFoo { IQux foo(); }\n");
2741 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2742 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2743
2744 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2745 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2746
2747 string output;
2748 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2749 // IBar was imported but wasn't used. include is not expected.
2750 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2751 // IBar was imported and used. include is expected.
2752 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2753}
2754
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002755TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002756 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002757 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002758 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2759 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002760 interface IFoo {
2761 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002762 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002763 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002764 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002765 // JavaPassthrough should work with other types as well (e.g. enum)
2766 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2767 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2768 @JavaPassthrough(annotation="@com.android.AliceTwo")
2769 @Backing(type="byte")
2770 enum MyEnum {
2771 a, b, c
2772 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002773
Jooyung Han4cde01d2020-10-13 11:10:47 +09002774 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002775 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2776
2777 string java_out;
2778 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002779 // type-decl-level annotations with newline at the end
2780 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2781 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2782 // member-decl-level annotations with newline at the end
2783 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2784 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2785 // inline annotations with space at the end
2786 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002787
Jooyung Han4cde01d2020-10-13 11:10:47 +09002788 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2789 // type-decl-level annotations with newline at the end
2790 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2791 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2792
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002793 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002794 Options cpp_options =
2795 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002796 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2797
Jooyung Han4cde01d2020-10-13 11:10:47 +09002798 Options ndk_options =
2799 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002800 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002801
Jooyung Han4cde01d2020-10-13 11:10:47 +09002802 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002803 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002804}
2805
Andrei Homescue61feb52020-08-18 15:44:24 -07002806TEST_F(AidlTest, ParseRustDerive) {
2807 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2808 @RustDerive(Clone=true, Copy=false)
2809 parcelable Foo {
2810 int a;
2811 })");
2812
2813 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2814 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2815
2816 string rust_out;
2817 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2818 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2819
2820 // Other backends shouldn't be bothered
2821 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2822 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2823
2824 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2825 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2826
2827 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2828 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2829}
2830
Jiyong Park56f73d72019-06-11 12:20:28 +09002831class AidlOutputPathTest : public AidlTest {
2832 protected:
2833 void SetUp() override {
2834 AidlTest::SetUp();
2835 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2836 }
2837
2838 void Test(const Options& options, const std::string expected_output_path) {
2839 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2840 // check the existence
2841 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2842 }
2843};
2844
2845TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2846 // <out_dir> / <package_name> / <type_name>.java
2847 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2848}
2849
2850TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2851 // when output file is explicitly set, it is always respected. -o option is
2852 // ignored.
2853 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2854}
2855
2856TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2857 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2858}
2859
2860TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2861 // output is the same as the input file except for the suffix
2862 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2863}
2864
Devin Moore7b8d5c92020-03-17 14:14:08 -07002865TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002866 AidlError error;
2867 const string expected_stderr =
2868 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2869 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002870 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2871 R"(package p;
2872 interface IFoo {
2873 const int int32_max_oob = 2147483650;
2874 }
2875 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002876 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002877 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2878 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002879}
2880
Devin Moore7b8d5c92020-03-17 14:14:08 -07002881TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002882 AidlError error;
2883 const string expected_stderr =
2884 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2885 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002886 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2887 R"(package p;
2888 interface IFoo {
2889 const int int32_min_oob = -2147483650;
2890 }
2891 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002892 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002893 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2894 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002895}
2896
Devin Moore7b8d5c92020-03-17 14:14:08 -07002897TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002898 AidlError error;
2899 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002900 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002901 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002902 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2903 R"(package p;
2904 interface IFoo {
2905 const long int64_max_oob = 21474836509999999999999999;
2906 }
2907 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002908 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002909 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2910 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002911}
2912
Devin Moore7b8d5c92020-03-17 14:14:08 -07002913TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002914 AidlError error;
2915 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002916 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002917 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002918 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2919 R"(package p;
2920 interface IFoo {
2921 const long int64_min_oob = -21474836509999999999999999;
2922 }
2923 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002924 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002925 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2926 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002927}
2928
Devin Moore7b8d5c92020-03-17 14:14:08 -07002929TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002930 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002931 const string expected_stderr =
2932 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2933 "literal: byte\n"
2934 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2935 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002936 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2937 R"(package p;
2938 @Backing(type="byte")
2939 enum TestEnum {
2940 FOO = 127,
2941 BAR,
2942 }
2943 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002944 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002945 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002946 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002947}
2948
Devin Mooredecaf292020-04-30 09:16:40 -07002949TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2950 AidlError error;
2951 const string expected_stderr =
2952 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2953 "be one of: type\n"
2954 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2955 "be one of: type\n";
2956 CaptureStderr();
2957 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2958 R"(package p;
2959 @Backing(foo="byte")
2960 enum TestEnum {
2961 FOO = 1,
2962 BAR,
2963 }
2964 )",
2965 typenames_, GetLanguage(), &error));
2966 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2967 EXPECT_EQ(AidlError::BAD_TYPE, error);
2968}
2969
Jooyung Han66813932020-10-23 13:24:44 +09002970TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002971 io_delegate_.SetFileContents("Foo.aidl",
2972 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2973 "Map<String, Baz> d; Bar[] e; }");
2974 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2975 io_delegate_.SetFileContents("Baz.aidl",
2976 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002977 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2978 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2979}
2980
Jooyung Han66813932020-10-23 13:24:44 +09002981TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002982 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002983 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09002984 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09002985 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
2986 "named 'bar'.\n";
2987 CaptureStderr();
2988 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2989 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2990 EXPECT_EQ(expected_error, GetCapturedStderr());
2991}
2992
2993TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
2994 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
2995 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2996 string expected_error =
2997 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09002998 "named 'bar'.\n";
2999 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003000 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3001 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003002 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003003}
3004
Jooyung Han66813932020-10-23 13:24:44 +09003005TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003006 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003007 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3008 string expected_error =
3009 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3010 "only be an in parameter.\n";
3011 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003012 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3013 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003014 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003015}
3016
Jooyung Han66813932020-10-23 13:24:44 +09003017TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003018 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003019 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3020 string expected_error =
3021 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3022 "only be an in parameter.\n";
3023 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003024 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3025 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003026 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003027}
3028
Jooyung Han66813932020-10-23 13:24:44 +09003029TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003030 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003031 Options options = Options::From("aidl --lang=java Foo.aidl");
3032 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003033 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3034 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003035 CaptureStderr();
3036 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3037 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3038}
Devin Moore53fc99c2020-08-12 08:07:52 -07003039
Jooyung Han1f14ab32020-10-14 13:48:29 +09003040const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3041
3042#include <a/ByteEnum.h>
3043#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003044#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003045#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003046#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003047#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003048#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003049#include <locale>
3050#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003051#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003052#include <utility>
3053#include <variant>
3054#include <vector>
3055
Jooyung Handf39e192020-11-23 15:59:46 +09003056#ifndef __BIONIC__
3057#define __assert2(a,b,c,d) ((void)0)
3058#endif
3059
Jooyung Han1f14ab32020-10-14 13:48:29 +09003060namespace a {
3061
3062class Foo : public ::android::Parcelable {
3063public:
Jooyung Han97945de2020-10-15 16:41:38 +09003064 inline bool operator!=(const Foo& rhs) const {
3065 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003066 }
Jooyung Han97945de2020-10-15 16:41:38 +09003067 inline bool operator<(const Foo& rhs) const {
3068 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003069 }
Jooyung Han97945de2020-10-15 16:41:38 +09003070 inline bool operator<=(const Foo& rhs) const {
3071 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003072 }
Jooyung Han97945de2020-10-15 16:41:38 +09003073 inline bool operator==(const Foo& rhs) const {
3074 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003075 }
Jooyung Han97945de2020-10-15 16:41:38 +09003076 inline bool operator>(const Foo& rhs) const {
3077 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003078 }
Jooyung Han97945de2020-10-15 16:41:38 +09003079 inline bool operator>=(const Foo& rhs) const {
3080 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003081 }
Jooyung Han97945de2020-10-15 16:41:38 +09003082
Jooyung Han1f14ab32020-10-14 13:48:29 +09003083 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003084 ns = 0, // int[] ns;
3085 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003086 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003087 };
Jooyung Han97945de2020-10-15 16:41:38 +09003088
Jooyung Han1f14ab32020-10-14 13:48:29 +09003089 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003090 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003091
3092 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003093 Foo(const Foo&) = default;
3094 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003095 Foo& operator=(const Foo&) = default;
3096 Foo& operator=(Foo&&) = default;
3097
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003098 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3099 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003100 constexpr Foo(_Tp&& _arg)
3101 : _value(std::forward<_Tp>(_arg)) {}
3102
3103 template <typename... _Tp>
3104 constexpr explicit Foo(_Tp&&... _args)
3105 : _value(std::forward<_Tp>(_args)...) {}
3106
3107 template <Tag _tag, typename... _Tp>
3108 static Foo make(_Tp&&... _args) {
3109 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003110 }
Jooyung Han97945de2020-10-15 16:41:38 +09003111
3112 template <Tag _tag, typename _Tp, typename... _Up>
3113 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3114 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003115 }
3116
3117 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003118 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003119 }
3120
Jooyung Han97945de2020-10-15 16:41:38 +09003121 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003122 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003123 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003124 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003125 }
3126
Jooyung Han97945de2020-10-15 16:41:38 +09003127 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003128 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003129 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003130 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003131 }
3132
Jooyung Han97945de2020-10-15 16:41:38 +09003133 template <Tag _tag, typename... _Tp>
3134 void set(_Tp&&... _args) {
3135 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003136 }
3137
3138 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3139 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3140 static const std::string& getParcelableDescriptor() {
3141 static const std::string DESCIPTOR = "a.Foo";
3142 return DESCIPTOR;
3143 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003144 template <typename _T> class _has_toString {
3145 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3146 template <typename _U> static std::false_type __has_toString(...);
3147 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3148 };
3149 template <typename _T> inline static std::string _call_toString(const _T& t) {
3150 if constexpr (_has_toString<_T>::value) return t.toString();
3151 return "{no toString() implemented}";
3152 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003153 inline std::string toString() const {
3154 std::ostringstream os;
3155 os << "Foo{";
3156 switch (getTag()) {
3157 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3158 case e: os << "e: " << a::toString(get<e>()); break;
3159 case pfd: os << "pfd: " << ""; break;
3160 }
3161 os << "}";
3162 return os.str();
3163 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003164private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003165 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003166}; // class Foo
3167
3168} // namespace a
3169)";
3170
3171const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3172
3173namespace a {
3174
3175::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3176 ::android::status_t _aidl_ret_status;
3177 int32_t _aidl_tag;
3178 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3179 switch (_aidl_tag) {
3180 case ns: {
3181 ::std::vector<int32_t> _aidl_value;
3182 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003183 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3184 set<ns>(_aidl_value);
3185 } else {
3186 // NOLINTNEXTLINE(performance-move-const-arg)
3187 set<ns>(std::move(_aidl_value));
3188 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003189 return ::android::OK; }
3190 case e: {
3191 ::a::ByteEnum _aidl_value;
3192 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003193 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3194 set<e>(_aidl_value);
3195 } else {
3196 // NOLINTNEXTLINE(performance-move-const-arg)
3197 set<e>(std::move(_aidl_value));
3198 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003199 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003200 case pfd: {
3201 ::android::os::ParcelFileDescriptor _aidl_value;
3202 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003203 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3204 set<pfd>(_aidl_value);
3205 } else {
3206 // NOLINTNEXTLINE(performance-move-const-arg)
3207 set<pfd>(std::move(_aidl_value));
3208 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003209 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003210 }
3211 return ::android::BAD_VALUE;
3212}
3213
3214::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3215 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3216 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3217 switch (getTag()) {
3218 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3219 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003220 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003221 }
Jooyung Handf39e192020-11-23 15:59:46 +09003222 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003223}
3224
3225} // namespace a
3226)";
3227
Jooyung Han6beac042020-10-17 21:59:43 +09003228const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3229#include <android/binder_interface_utils.h>
3230#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003231#include <codecvt>
3232#include <locale>
3233#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003234
Jooyung Handf39e192020-11-23 15:59:46 +09003235#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003236#include <type_traits>
3237#include <utility>
3238#include <variant>
3239#include <cstdint>
3240#include <memory>
3241#include <optional>
3242#include <string>
3243#include <vector>
3244#ifdef BINDER_STABILITY_SUPPORT
3245#include <android/binder_stability.h>
3246#endif // BINDER_STABILITY_SUPPORT
3247#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003248
3249#ifndef __BIONIC__
3250#define __assert2(a,b,c,d) ((void)0)
3251#endif
3252
Jooyung Han6beac042020-10-17 21:59:43 +09003253namespace aidl {
3254namespace a {
3255class Foo {
3256public:
3257 typedef std::false_type fixed_size;
3258 static const char* descriptor;
3259
3260 enum Tag : int32_t {
3261 ns = 0, // int[] ns;
3262 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003263 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003264 };
3265
3266 template<typename _Tp>
3267 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3268
3269 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3270 Foo(const Foo&) = default;
3271 Foo(Foo&&) = default;
3272 Foo& operator=(const Foo&) = default;
3273 Foo& operator=(Foo&&) = default;
3274
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003275 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3276 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003277 constexpr Foo(_Tp&& _arg)
3278 : _value(std::forward<_Tp>(_arg)) {}
3279
3280 template <typename... _Tp>
3281 constexpr explicit Foo(_Tp&&... _args)
3282 : _value(std::forward<_Tp>(_args)...) {}
3283
3284 template <Tag _tag, typename... _Tp>
3285 static Foo make(_Tp&&... _args) {
3286 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3287 }
3288
3289 template <Tag _tag, typename _Tp, typename... _Up>
3290 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3291 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3292 }
3293
3294 Tag getTag() const {
3295 return static_cast<Tag>(_value.index());
3296 }
3297
3298 template <Tag _tag>
3299 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003300 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003301 return std::get<_tag>(_value);
3302 }
3303
3304 template <Tag _tag>
3305 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003306 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003307 return std::get<_tag>(_value);
3308 }
3309
3310 template <Tag _tag, typename... _Tp>
3311 void set(_Tp&&... _args) {
3312 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3313 }
3314
3315 binder_status_t readFromParcel(const AParcel* _parcel);
3316 binder_status_t writeToParcel(AParcel* _parcel) const;
3317 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003318 template <typename _T> class _has_toString {
3319 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3320 template <typename _U> static std::false_type __has_toString(...);
3321 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3322 };
3323 template <typename _T> inline static std::string _call_toString(const _T& t) {
3324 if constexpr (_has_toString<_T>::value) return t.toString();
3325 return "{no toString() implemented}";
3326 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003327 inline std::string toString() const {
3328 std::ostringstream os;
3329 os << "Foo{";
3330 switch (getTag()) {
3331 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3332 case e: os << "e: " << a::toString(get<e>()); break;
3333 case pfd: os << "pfd: " << ""; break;
3334 }
3335 os << "}";
3336 return os.str();
3337 }
Jooyung Han6beac042020-10-17 21:59:43 +09003338private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003339 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003340};
3341} // namespace a
3342} // namespace aidl
3343)";
3344
3345const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3346
3347#include <android/binder_parcel_utils.h>
3348
3349namespace aidl {
3350namespace a {
3351const char* Foo::descriptor = "a.Foo";
3352
3353binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3354 binder_status_t _aidl_ret_status;
3355 int32_t _aidl_tag;
3356 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3357 switch (_aidl_tag) {
3358 case ns: {
3359 std::vector<int32_t> _aidl_value;
3360 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003361 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3362 set<ns>(_aidl_value);
3363 } else {
3364 // NOLINTNEXTLINE(performance-move-const-arg)
3365 set<ns>(std::move(_aidl_value));
3366 }
Jooyung Han6beac042020-10-17 21:59:43 +09003367 return STATUS_OK; }
3368 case e: {
3369 ::aidl::a::ByteEnum _aidl_value;
3370 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003371 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3372 set<e>(_aidl_value);
3373 } else {
3374 // NOLINTNEXTLINE(performance-move-const-arg)
3375 set<e>(std::move(_aidl_value));
3376 }
Jooyung Han6beac042020-10-17 21:59:43 +09003377 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003378 case pfd: {
3379 ::ndk::ScopedFileDescriptor _aidl_value;
3380 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003381 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3382 set<pfd>(_aidl_value);
3383 } else {
3384 // NOLINTNEXTLINE(performance-move-const-arg)
3385 set<pfd>(std::move(_aidl_value));
3386 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003387 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003388 }
3389 return STATUS_BAD_VALUE;
3390}
3391binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3392 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3393 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3394 switch (getTag()) {
3395 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3396 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003397 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003398 }
Jooyung Handf39e192020-11-23 15:59:46 +09003399 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003400}
3401
3402} // namespace a
3403} // namespace aidl
3404)";
3405
Jooyung Han1f14ab32020-10-14 13:48:29 +09003406const char kUnionExampleExpectedOutputJava[] = R"(/*
3407 * This file is auto-generated. DO NOT MODIFY.
3408 */
3409package a;
3410
3411
3412public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003413 // tags for union fields
3414 public final static int ns = 0; // int[] ns;
3415 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003416 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003417
3418 private int _tag;
3419 private Object _value;
3420
3421 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003422 int[] _value = {42};
3423 this._tag = ns;
3424 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003425 }
Jooyung Han97945de2020-10-15 16:41:38 +09003426
Jooyung Han1f14ab32020-10-14 13:48:29 +09003427 private Foo(android.os.Parcel _aidl_parcel) {
3428 readFromParcel(_aidl_parcel);
3429 }
Jooyung Han97945de2020-10-15 16:41:38 +09003430
Jooyung Hance62f932020-10-25 10:21:49 +09003431 private Foo(int _tag, Object _value) {
3432 this._tag = _tag;
3433 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003434 }
3435
3436 public int getTag() {
3437 return _tag;
3438 }
3439
Jooyung Han97945de2020-10-15 16:41:38 +09003440 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003441
3442 public static Foo ns(int[] _value) {
3443 return new Foo(ns, _value);
3444 }
Jooyung Han97945de2020-10-15 16:41:38 +09003445
Jooyung Han1f14ab32020-10-14 13:48:29 +09003446 public int[] getNs() {
3447 _assertTag(ns);
3448 return (int[]) _value;
3449 }
Jooyung Han97945de2020-10-15 16:41:38 +09003450
Jooyung Han1f14ab32020-10-14 13:48:29 +09003451 public void setNs(int[] _value) {
3452 _set(ns, _value);
3453 }
3454
Jooyung Han97945de2020-10-15 16:41:38 +09003455 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003456
3457 public static Foo e(byte _value) {
3458 return new Foo(e, _value);
3459 }
Jooyung Han97945de2020-10-15 16:41:38 +09003460
Jooyung Han1f14ab32020-10-14 13:48:29 +09003461 public byte getE() {
3462 _assertTag(e);
3463 return (byte) _value;
3464 }
Jooyung Han97945de2020-10-15 16:41:38 +09003465
Jooyung Han1f14ab32020-10-14 13:48:29 +09003466 public void setE(byte _value) {
3467 _set(e, _value);
3468 }
3469
Jooyung Hand2fa0232020-10-19 02:51:41 +09003470 // ParcelFileDescriptor pfd;
3471
3472 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3473 return new Foo(pfd, _value);
3474 }
3475
3476 public android.os.ParcelFileDescriptor getPfd() {
3477 _assertTag(pfd);
3478 return (android.os.ParcelFileDescriptor) _value;
3479 }
3480
3481 public void setPfd(android.os.ParcelFileDescriptor _value) {
3482 _set(pfd, _value);
3483 }
3484
Jooyung Han1f14ab32020-10-14 13:48:29 +09003485 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3486 @Override
3487 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003488 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003489 }
3490 @Override
3491 public Foo[] newArray(int _aidl_size) {
3492 return new Foo[_aidl_size];
3493 }
3494 };
Jooyung Han97945de2020-10-15 16:41:38 +09003495
Jooyung Han1f14ab32020-10-14 13:48:29 +09003496 @Override
3497 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3498 _aidl_parcel.writeInt(_tag);
3499 switch (_tag) {
3500 case ns:
3501 _aidl_parcel.writeIntArray(getNs());
3502 break;
3503 case e:
3504 _aidl_parcel.writeByte(getE());
3505 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003506 case pfd:
3507 if ((getPfd()!=null)) {
3508 _aidl_parcel.writeInt(1);
3509 getPfd().writeToParcel(_aidl_parcel, 0);
3510 }
3511 else {
3512 _aidl_parcel.writeInt(0);
3513 }
3514 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003515 }
3516 }
Jooyung Han97945de2020-10-15 16:41:38 +09003517
Jooyung Han1f14ab32020-10-14 13:48:29 +09003518 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3519 int _aidl_tag;
3520 _aidl_tag = _aidl_parcel.readInt();
3521 switch (_aidl_tag) {
3522 case ns: {
3523 int[] _aidl_value;
3524 _aidl_value = _aidl_parcel.createIntArray();
3525 _set(_aidl_tag, _aidl_value);
3526 return; }
3527 case e: {
3528 byte _aidl_value;
3529 _aidl_value = _aidl_parcel.readByte();
3530 _set(_aidl_tag, _aidl_value);
3531 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003532 case pfd: {
3533 android.os.ParcelFileDescriptor _aidl_value;
3534 if ((0!=_aidl_parcel.readInt())) {
3535 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3536 }
3537 else {
3538 _aidl_value = null;
3539 }
3540 _set(_aidl_tag, _aidl_value);
3541 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003542 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003543 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003544 }
Jooyung Han97945de2020-10-15 16:41:38 +09003545
Jooyung Han1f14ab32020-10-14 13:48:29 +09003546 @Override
3547 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003548 int _mask = 0;
3549 switch (getTag()) {
3550 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003551 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003552 break;
3553 }
3554 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003555 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003556 private int describeContents(Object _v) {
3557 if (_v == null) return 0;
3558 if (_v instanceof android.os.Parcelable) {
3559 return ((android.os.Parcelable) _v).describeContents();
3560 }
3561 return 0;
3562 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003563
3564 private void _assertTag(int tag) {
3565 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003566 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003567 }
3568 }
Jooyung Han97945de2020-10-15 16:41:38 +09003569
Jooyung Han1f14ab32020-10-14 13:48:29 +09003570 private String _tagString(int _tag) {
3571 switch (_tag) {
3572 case ns: return "ns";
3573 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003574 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003575 }
3576 throw new IllegalStateException("unknown field: " + _tag);
3577 }
Jooyung Han97945de2020-10-15 16:41:38 +09003578
Jooyung Hance62f932020-10-25 10:21:49 +09003579 private void _set(int _tag, Object _value) {
3580 this._tag = _tag;
3581 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003582 }
3583}
3584)";
3585
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003586const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3587pub enum Foo {
3588 Ns(Vec<i32>),
3589 E(crate::mangled::_1_a_8_ByteEnum),
3590 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3591}
3592pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3593impl Default for Foo {
3594 fn default() -> Self {
3595 Self::Ns(vec!{42})
3596 }
3597}
3598impl binder::parcel::Serialize for Foo {
3599 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3600 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3601 }
3602}
3603impl binder::parcel::SerializeArray for Foo {}
3604impl binder::parcel::SerializeOption for Foo {
3605 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3606 let this = if let Some(this) = this {
3607 parcel.write(&1i32)?;
3608 this
3609 } else {
3610 return parcel.write(&0i32);
3611 };
3612 match this {
3613 Self::Ns(v) => {
3614 parcel.write(&0i32)?;
3615 parcel.write(v)
3616 }
3617 Self::E(v) => {
3618 parcel.write(&1i32)?;
3619 parcel.write(v)
3620 }
3621 Self::Pfd(v) => {
3622 parcel.write(&2i32)?;
3623 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3624 parcel.write(__field_ref)
3625 }
3626 }
3627 }
3628}
3629impl binder::parcel::Deserialize for Foo {
3630 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3631 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3632 .transpose()
3633 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3634 }
3635}
3636impl binder::parcel::DeserializeArray for Foo {}
3637impl binder::parcel::DeserializeOption for Foo {
3638 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3639 let status: i32 = parcel.read()?;
3640 if status == 0 { return Ok(None); }
3641 let tag: i32 = parcel.read()?;
3642 match tag {
3643 0 => {
3644 let value: Vec<i32> = parcel.read()?;
3645 Ok(Some(Self::Ns(value)))
3646 }
3647 1 => {
3648 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3649 Ok(Some(Self::E(value)))
3650 }
3651 2 => {
3652 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3653 Ok(Some(Self::Pfd(value)))
3654 }
3655 _ => {
3656 Err(binder::StatusCode::BAD_VALUE)
3657 }
3658 }
3659 }
3660}
3661)";
3662
Jooyung Han97945de2020-10-15 16:41:38 +09003663struct AidlUnionTest : ::testing::Test {
3664 void SetUp() override {
3665 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003666package a;
3667import a.ByteEnum;
3668union Foo {
3669 int[] ns = {42};
3670 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003671 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003672}
3673)");
Jooyung Han97945de2020-10-15 16:41:38 +09003674 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003675package a;
3676@Backing(type="byte")
3677enum ByteEnum {
3678 a, b, c
3679}
3680)");
Jooyung Han97945de2020-10-15 16:41:38 +09003681 }
3682 FakeIoDelegate io_delegate_;
3683 void Compile(string lang) {
3684 string command = "aidl --structured -I. -o out --lang=" + lang;
3685 if (lang == "cpp" || lang == "ndk") {
3686 command += " -h out";
3687 }
3688 command += " a/Foo.aidl";
3689 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003690 CaptureStderr();
3691 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3692 auto err = GetCapturedStderr();
3693 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003694 }
3695 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3696 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003697 string actual;
3698 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3699 EXPECT_EQ(expected, actual);
3700 }
Jooyung Han97945de2020-10-15 16:41:38 +09003701 }
3702};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003703
Jooyung Han97945de2020-10-15 16:41:38 +09003704TEST_F(AidlUnionTest, Example_Cpp) {
3705 Compile("cpp");
3706 EXPECT_COMPILE_OUTPUTS(
3707 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3708 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3709}
3710
Jooyung Han6beac042020-10-17 21:59:43 +09003711TEST_F(AidlUnionTest, Example_Ndk) {
3712 Compile("ndk");
3713 EXPECT_COMPILE_OUTPUTS(
3714 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3715 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3716}
3717
Jooyung Han97945de2020-10-15 16:41:38 +09003718TEST_F(AidlUnionTest, Example_Java) {
3719 Compile("java");
3720 EXPECT_COMPILE_OUTPUTS(
3721 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003722}
3723
3724TEST_F(AidlUnionTest, Example_Rust) {
3725 Compile("rust");
3726 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003727}
3728
Jooyung Hanfe89f122020-10-14 03:49:18 +09003729TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3730 const string method = "package a; union Foo {}";
3731 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3732 CaptureStderr();
3733 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3734 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3735}
3736
3737TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3738 const string method = "package a; union Foo { ParcelableHolder x; }";
3739 const string expected_stderr =
3740 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3741 CaptureStderr();
3742 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3743 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3744}
3745
Devin Moore53fc99c2020-08-12 08:07:52 -07003746TEST_P(AidlTest, GenericStructuredParcelable) {
3747 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3748 Options options =
3749 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3750 const string expected_stderr = "";
3751 CaptureStderr();
3752 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3753 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3754}
3755
Jooyung Han3f347ca2020-12-01 12:41:50 +09003756TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3757 io_delegate_.SetFileContents("Foo.aidl",
3758 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3759 Options options =
3760 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::CPP) +
3761 " -o out -h out");
3762 const string expected_stderr = "";
3763 CaptureStderr();
3764 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3765 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3766
3767 string code;
3768 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3769 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3770const ::android::String16& Foo<T,U>::s() {
3771 static const ::android::String16 value(::android::String16(""));
3772 return value;
3773})--"));
3774}
3775
3776TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3777 io_delegate_.SetFileContents("Foo.aidl",
3778 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3779 Options options =
3780 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::NDK) +
3781 " -o out -h out");
3782 const string expected_stderr = "";
3783 CaptureStderr();
3784 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3785 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3786
3787 string code;
3788 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3789 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3790const char* Foo<T, U>::s = "";
3791)--"));
3792}
3793
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003794TEST_F(AidlTest, NestedTypeArgs) {
3795 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003796 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3797
3798 io_delegate_.SetFileContents("a/Foo.aidl",
3799 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3800 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003801 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3802 const string expected_stderr = "";
3803 CaptureStderr();
3804 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3805 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3806
3807 string code;
3808 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003809 EXPECT_THAT(code,
3810 testing::HasSubstr(
3811 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3812}
3813
3814TEST_F(AidlTest, DoubleArrayError) {
3815 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3816
3817 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3818 const string expected_stderr =
3819 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3820 CaptureStderr();
3821 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3822 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3823}
3824
3825TEST_F(AidlTest, DoubleGenericError) {
3826 io_delegate_.SetFileContents("a/Bar.aidl",
3827 "package a; parcelable Bar { List<String><String> a; }");
3828
3829 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3830 const string expected_stderr =
3831 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3832 CaptureStderr();
3833 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3834 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3835}
3836
3837TEST_F(AidlTest, ArrayBeforeGenericError) {
3838 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3839
3840 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3841 const string expected_stderr =
3842 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3843 CaptureStderr();
3844 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3845 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003846}
3847
Jooyung Han14004ed2020-10-16 03:49:57 +09003848struct GenericAidlTest : ::testing::Test {
3849 FakeIoDelegate io_delegate_;
3850 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003851 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003852 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3853 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3854 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3855
3856 Options options = Options::From(cmd);
3857 CaptureStderr();
3858 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3859 EXPECT_EQ("", GetCapturedStderr());
3860 }
3861};
3862
3863TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3864 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3865 string code;
3866 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3867 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3868 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3869 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3870}
3871
3872TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3873 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3874 string code;
3875 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3876 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3877 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3878 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3879}
3880
Devin Moore53fc99c2020-08-12 08:07:52 -07003881TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3882 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3883 Options options =
3884 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3885 const string expected_stderr =
3886 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3887 CaptureStderr();
3888 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3889 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3890}
3891
3892TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3893 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3894 Options options =
3895 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3896 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3897 CaptureStderr();
3898 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3899 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3900}
3901
Jooyung Han7a308842020-10-27 19:06:49 +09003902TEST_P(AidlTest, LongCommentWithinConstExpression) {
3903 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
3904 Options options =
3905 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3906 CaptureStderr();
3907 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3908 EXPECT_EQ("", GetCapturedStderr());
3909}
3910
Jeongik Chaef44e622020-10-23 16:00:52 +09003911TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3912 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3913 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3914 std::string expectedErr =
3915 "ERROR: a/Foo.aidl:1.28-30: "
3916 "Encountered an untyped List or Map. The use of untyped List/Map is "
3917 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3918 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3919 "ERROR: a/Foo.aidl:1.35-37: "
3920 "Encountered an untyped List or Map. The use of untyped List/Map is "
3921 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3922 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3923 CaptureStderr();
3924 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3925 EXPECT_EQ(expectedErr, GetCapturedStderr());
3926}
3927
3928TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003929 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3930 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003931 std::string expectedErr =
3932 "ERROR: a/Foo.aidl:1.33-35: "
3933 "Encountered an untyped List or Map. The use of untyped List/Map is "
3934 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3935 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3936 "ERROR: a/Foo.aidl:1.40-42: "
3937 "Encountered an untyped List or Map. The use of untyped List/Map is "
3938 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3939 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09003940 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09003941 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3942 EXPECT_EQ(expectedErr, GetCapturedStderr());
3943}
Jooyung Hanea2147c2020-10-21 18:16:56 +09003944
Jeongik Chaef44e622020-10-23 16:00:52 +09003945TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
3946 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
3947 io_delegate_.SetFileContents(
3948 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
3949 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
3950 std::string expectedErr =
3951 "ERROR: a/Foo.aidl:1.52-54: "
3952 "Encountered an untyped List or Map. The use of untyped List/Map is "
3953 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3954 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3955 "ERROR: a/Foo.aidl:1.64-66: "
3956 "Encountered an untyped List or Map. The use of untyped List/Map is "
3957 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3958 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3959 CaptureStderr();
3960 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3961 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09003962}
3963
Jooyung Han690f5842020-12-04 13:02:04 +09003964TEST_F(AidlTest, EnumWithDefaults_Java) {
3965 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3966 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3967package p;
3968import p.Enum;
3969parcelable Foo {
3970 Enum e = Enum.BAR;
3971})");
3972 CaptureStderr();
3973 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
3974 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3975 auto err = GetCapturedStderr();
3976 EXPECT_EQ("", err);
3977
3978 string code;
3979 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
3980 EXPECT_THAT(code, testing::HasSubstr("byte e = Enum.BAR"));
3981}
3982
3983TEST_F(AidlTest, EnumWithDefaults_Cpp) {
3984 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
3985 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
3986package p;
3987import p.Enum;
3988parcelable Foo {
3989 Enum e = Enum.BAR;
3990})");
3991 CaptureStderr();
3992 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
3993 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
3994 auto err = GetCapturedStderr();
3995 EXPECT_EQ("", err);
3996
3997 string code;
3998 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
3999 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4000}
4001
4002TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4003 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4004 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4005package p;
4006import p.Enum;
4007parcelable Foo {
4008 Enum e = Enum.BAR;
4009})");
4010 CaptureStderr();
4011 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4012 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4013 auto err = GetCapturedStderr();
4014 EXPECT_EQ("", err);
4015
4016 string code;
4017 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4018 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4019}
4020
4021TEST_F(AidlTest, EnumWithDefaults_Rust) {
4022 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4023 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4024package p;
4025import p.Enum;
4026parcelable Foo {
4027 int n = 42;
4028 Enum e = Enum.BAR;
4029})");
4030 CaptureStderr();
4031 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
4032 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4033 auto err = GetCapturedStderr();
4034 EXPECT_EQ("", err);
4035
4036 string code;
4037 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4038 EXPECT_THAT(code, testing::HasSubstr(R"(
4039 fn default() -> Self {
4040 Self {
4041 n: 42,
4042 e: crate::mangled::_1_p_4_Enum::BAR,
4043 }
4044 })"));
4045}
4046
4047TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4048 import_paths_.insert("a");
4049 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4050 CaptureStderr();
4051 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4052package p;
4053import p.Enum;
4054parcelable Foo {
4055 int e = Enum.FOO | Enum.BAR;
4056})",
4057 typenames_, GetLanguage());
4058 auto err = GetCapturedStderr();
4059 EXPECT_EQ("", err);
4060 EXPECT_TRUE(type);
4061 const auto& fields = type->AsStructuredParcelable()->GetFields();
4062 EXPECT_EQ("int e = 3", fields[0]->ToString());
4063}
4064
4065TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4066 CaptureStderr();
4067 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4068@Backing(type="int")
4069enum Foo {
4070 STANDARD_SHIFT = 16,
4071 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4072 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4073}
4074)",
4075 typenames_, GetLanguage());
4076 auto err = GetCapturedStderr();
4077 EXPECT_EQ("", err);
4078 EXPECT_TRUE(type);
4079 const auto& enum_type = type->AsEnumDeclaration();
4080 string code;
4081 enum_type->Dump(CodeWriter::ForString(&code).get());
4082 EXPECT_EQ(R"--(@Backing(type="int")
4083enum Foo {
4084 STANDARD_SHIFT = 16,
4085 STANDARD_BT709 = 65536,
4086 STANDARD_BT601_625 = 131072,
4087}
4088)--",
4089 code);
4090}
4091
4092TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4093 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4094 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4095package p;
4096import p.Enum;
4097parcelable Foo {
4098 Enum e = Enum.FOO | Enum.BAR;
4099})");
4100 CaptureStderr();
4101 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
4102 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4103 auto err = GetCapturedStderr();
4104 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4105 err);
4106}
4107
4108TEST_P(AidlTest, DefaultWithEmptyArray) {
4109 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4110 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4111 CaptureStderr();
4112 auto options = Options::From("aidl -I a --lang " + Options::LanguageToString(GetLanguage()) +
4113 " -o out -h out a/p/Foo.aidl");
4114 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4115 auto err = GetCapturedStderr();
4116 EXPECT_EQ("", err);
4117}
4118
4119TEST_P(AidlTest, RejectRefsInAnnotation) {
4120 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4121 "package p; interface IFoo {\n"
4122 " const String ANNOTATION = \"@Annotation\";\n"
4123 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4124 "}");
4125 CaptureStderr();
4126 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4127 " -o out -h out a/p/IFoo.aidl");
4128 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4129 auto err = GetCapturedStderr();
4130 EXPECT_EQ(
4131 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4132 "ANNOTATION.\n",
4133 err);
4134}
4135
4136TEST_F(AidlTest, DefaultWithEnumValues) {
4137 io_delegate_.SetFileContents(
4138 "a/p/Foo.aidl",
4139 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4140 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4141 CaptureStderr();
4142 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4143 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4144 auto err = GetCapturedStderr();
4145 EXPECT_EQ("", err);
4146 string code;
4147 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4148 EXPECT_THAT(
4149 code, testing::HasSubstr(
4150 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4151}
4152
Jooyung Han14259392020-12-07 10:00:08 +09004153TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4154 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4155 CaptureStderr();
4156 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4157 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4158 auto err = GetCapturedStderr();
4159 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Failed to parse expression as integer: B\n", err);
4160}
4161
4162TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4163 io_delegate_.SetFileContents("a/p/Foo.aidl",
4164 "package p; parcelable Foo { const int A = A + 1; }");
4165 CaptureStderr();
4166 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4167 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4168 auto err = GetCapturedStderr();
4169 EXPECT_EQ(
4170 "ERROR: a/p/Foo.aidl:1.42-44: Can't evaluate the circular reference (A)\n"
4171 "ERROR: a/p/Foo.aidl:1.42-44: Invalid left operand in binary expression: A+1\n",
4172 err);
4173}
4174
Christopher Wiley90be4e32015-10-20 14:55:25 -07004175} // namespace aidl
4176} // namespace android