blob: 35d5edd6705af582c1c7d4fb1d91ee8ff909fa10 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Christopher Wileyec31a052016-01-25 07:28:51 -080019#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090020#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070021#include <gtest/gtest.h>
22
Jooyung Han1f14ab32020-10-14 13:48:29 +090023#include <map>
24#include <memory>
25#include <set>
26#include <string>
27#include <vector>
28
Steven Moreland49585242019-12-18 16:06:49 -080029#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070030#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070031#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090033#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090034#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070035#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090037using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070038using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080039using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090040using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070042using std::string;
43using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080044using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070045using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090046using testing::internal::CaptureStderr;
47using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070048
49namespace android {
50namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070051namespace {
52
53const char kExpectedDepFileContents[] =
54R"(place/for/output/p/IFoo.java : \
55 p/IFoo.aidl
56
57p/IFoo.aidl :
58)";
59
Dan Willemsen93298ee2016-11-10 23:55:55 -080060const char kExpectedNinjaDepFileContents[] =
61R"(place/for/output/p/IFoo.java : \
62 p/IFoo.aidl
63)";
64
Jiyong Parkdf202122019-09-30 20:48:35 +090065const char kExpectedParcelableDeclarationDepFileContents[] =
66 R"( : \
67 p/Foo.aidl
68
69p/Foo.aidl :
70)";
71
72const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080073 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070074 p/Foo.aidl
75
76p/Foo.aidl :
77)";
78
Jooyung Hand2fa0232020-10-19 02:51:41 +090079const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090080 R"(/*
81 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090082 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080083@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090084public class Rect implements android.os.Parcelable
85{
86 // Comment
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090089 public int x = 5;
90
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080091 @android.annotation.Hide
92 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000093 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090094
95 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090096
97 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090098 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
99 @Override
100 public Rect createFromParcel(android.os.Parcel _aidl_source) {
101 Rect _aidl_out = new Rect();
102 _aidl_out.readFromParcel(_aidl_source);
103 return _aidl_out;
104 }
105 @Override
106 public Rect[] newArray(int _aidl_size) {
107 return new Rect[_aidl_size];
108 }
109 };
110 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
111 {
112 int _aidl_start_pos = _aidl_parcel.dataPosition();
113 _aidl_parcel.writeInt(0);
114 _aidl_parcel.writeInt(x);
115 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900116 if ((fd!=null)) {
117 _aidl_parcel.writeInt(1);
118 fd.writeToParcel(_aidl_parcel, 0);
119 }
120 else {
121 _aidl_parcel.writeInt(0);
122 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900123 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900124 int _aidl_end_pos = _aidl_parcel.dataPosition();
125 _aidl_parcel.setDataPosition(_aidl_start_pos);
126 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
127 _aidl_parcel.setDataPosition(_aidl_end_pos);
128 }
129 public final void readFromParcel(android.os.Parcel _aidl_parcel)
130 {
131 int _aidl_start_pos = _aidl_parcel.dataPosition();
132 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900133 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900134 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900135 x = _aidl_parcel.readInt();
136 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
137 y = _aidl_parcel.readInt();
138 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900139 if ((0!=_aidl_parcel.readInt())) {
140 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
141 }
142 else {
143 fd = null;
144 }
145 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900146 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900147 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900148 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900149 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
150 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
151 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900152 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
153 }
154 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900155 @Override
156 public int describeContents() {
157 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900158 _mask |= describeContents(fd);
159 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900160 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900161 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900162 private int describeContents(Object _v) {
163 if (_v == null) return 0;
164 if (_v instanceof java.util.Collection) {
165 int _mask = 0;
166 for (Object o : (java.util.Collection) _v) {
167 _mask |= describeContents(o);
168 }
169 return _mask;
170 }
171 if (_v instanceof android.os.Parcelable) {
172 return ((android.os.Parcelable) _v).describeContents();
173 }
174 return 0;
175 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900176}
177)";
178
Devin Moore2f2077a2020-08-28 11:27:53 -0700179// clang-format off
180const char kExpectedCppHeaderOutput[] =
181 R"(#pragma once
182
183#include <binder/IBinder.h>
184#include <binder/IInterface.h>
185#include <binder/Status.h>
186#include <optional>
187#include <utils/String16.h>
188#include <utils/StrongPointer.h>
189#include <vector>
190
191class IFoo : public ::android::IInterface {
192public:
193 DECLARE_META_INTERFACE(Foo)
194 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
195}; // class IFoo
196class IFooDefault : public IFoo {
197public:
198 ::android::IBinder* onAsBinder() override {
199 return nullptr;
200 }
201 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
202 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
203 }
204}; // class IFooDefault
205)";
206// clang-format on
207
Christopher Wileyf8136192016-04-12 14:19:35 -0700208} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700209
Devin Moore7b8d5c92020-03-17 14:14:08 -0700210class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700211 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900212 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
213 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700214 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700215 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900216 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700217 args.emplace_back("aidl");
218 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700219 for (const string& s : additional_arguments) {
220 args.emplace_back(s);
221 }
222 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900223 args.emplace_back("--preprocessed=" + f);
224 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700225 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900226 args.emplace_back("--include=" + i);
227 }
228 args.emplace_back(path);
229 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900230 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900231 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700232 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900233 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900234
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700235 if (error != nullptr) {
236 *error = actual_error;
237 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900238
239 if (actual_error != AidlError::OK) {
240 return nullptr;
241 }
242
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900243 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900244 EXPECT_EQ(1ul, defined_types.size());
245
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900246 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700247 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700248
Devin Moore7b8d5c92020-03-17 14:14:08 -0700249 Options::Language GetLanguage() { return GetParam(); }
250
Christopher Wiley0522cd52015-10-28 15:39:44 -0700251 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800252 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900253 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900254 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700255};
256
Devin Moore7b8d5c92020-03-17 14:14:08 -0700257// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
258// tests with each of the supported languages as a parameter.
259INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
260 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700261 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700262 [](const testing::TestParamInfo<Options::Language>& info) {
263 return Options::LanguageToString(info.param);
264 });
265
266TEST_P(AidlTest, AcceptMissingPackage) {
267 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700268}
269
Devin Moore7b8d5c92020-03-17 14:14:08 -0700270TEST_P(AidlTest, EndsInSingleLineComment) {
271 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700272}
273
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000274TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
275 const string expected_stderr =
276 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
277 const std::string file_contents = "package a; interface IBar {}";
278 CaptureStderr();
279 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
280 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
281}
282
283TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
284 const string expected_stderr =
285 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
286 const std::string file_contents = "package a; interface Bar {}";
287 CaptureStderr();
288 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
289 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
290}
291
292TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
293 const string expected_stderr =
294 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
295 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
296 CaptureStderr();
297 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
298 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
299}
300
301TEST_P(AidlTest, EnumRequiresCorrectPath) {
302 const string expected_stderr =
303 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
304 const std::string file_contents = "package a; enum Bar { A, }";
305 CaptureStderr();
306 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
307 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
308}
309
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900311 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700312 io_delegate_.SetFileContents("bar/IBar.aidl",
313 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700314 const string path = "foo/IFoo.aidl";
315 const string contents =
316 "package foo;\n"
317 "import bar.IBar;\n"
318 "interface IFoo { void f(in IBar[] input); }";
319 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
320 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700321 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700322 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700323}
324
Devin Moore7b8d5c92020-03-17 14:14:08 -0700325TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700326 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700327 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900328}
Devin Moore097a3ab2020-03-11 16:08:44 -0700329
Jiyong Park40782d02020-07-24 19:17:43 +0900330TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700331 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
332 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900333 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
334 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700335 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700336 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700337 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900338}
339
Jiyong Park40782d02020-07-24 19:17:43 +0900340TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700341 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
342 const string expected_stderr =
343 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700344 CaptureStderr();
345 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
346 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900347}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700348
Jiyong Park40782d02020-07-24 19:17:43 +0900349TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700350 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900351 const string expected_stderr =
352 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700353 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700354 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700365}
366
Devin Moore7b8d5c92020-03-17 14:14:08 -0700367TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700368 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
369 const string expected_stderr =
370 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
371 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800374}
375
Devin Moore2f2077a2020-08-28 11:27:53 -0700376TEST_P(AidlTest, AcceptNullableList) {
377 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
378 const string expected_stderr = "";
379 CaptureStderr();
380 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 const string method = "package a; interface IFoo { void f(int a, int a); }";
386 const string expected_stderr =
387 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
388 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700389 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700390 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700391}
392
Jeongik Cha13066da2020-08-06 15:43:19 +0900393TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
394 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900395 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900396 CaptureStderr();
397 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
398 EXPECT_EQ(expected_stderr, GetCapturedStderr());
399}
400
Jooyung Hand902a972020-10-23 17:32:44 +0900401TEST_P(AidlTest, RejectsRepeatedAnnotations) {
402 const string method = R"(@Hide @Hide parcelable Foo {})";
403 const string expected_stderr =
404 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
405 "Foo.aidl:1.1-6\n";
406 CaptureStderr();
407 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
408 EXPECT_EQ(expected_stderr, GetCapturedStderr());
409}
410
Devin Moore7b8d5c92020-03-17 14:14:08 -0700411TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700412 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
413 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
414 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700415 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700416 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100417}
418
Devin Moore7b8d5c92020-03-17 14:14:08 -0700419TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700420 AidlError error;
421 const string method = "package a; @nullable interface IFoo { int f(); }";
422 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800423 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000424 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
425 "JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700426 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700427 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700428 EXPECT_EQ(expected_stderr, GetCapturedStderr());
429 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800430}
431
Devin Moore7b8d5c92020-03-17 14:14:08 -0700432TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700433 AidlError error;
434 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
435 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800436 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900437 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700438 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700439 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
441 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800442}
443
Devin Moore7b8d5c92020-03-17 14:14:08 -0700444TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700445 AidlError error;
446 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
447 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000448 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900449 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900450 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700451 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000452 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700453 EXPECT_EQ(expected_stderr, GetCapturedStderr());
454 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800455}
456
Devin Moore7b8d5c92020-03-17 14:14:08 -0700457TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700458 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000459 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700460 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000461 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900462 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700463 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700464 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000465 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700466 EXPECT_EQ(expected_stderr, GetCapturedStderr());
467 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800468}
469
Jiyong Park40782d02020-07-24 19:17:43 +0900470TEST_P(AidlTest, ParsesNonNullableAnnotation) {
471 auto parse_result =
472 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
473 ASSERT_NE(nullptr, parse_result);
474 const AidlInterface* interface = parse_result->AsInterface();
475 ASSERT_NE(nullptr, interface);
476 ASSERT_FALSE(interface->GetMethods().empty());
477 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
478}
479
Devin Moore7b8d5c92020-03-17 14:14:08 -0700480TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900481 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
482 typenames_, GetLanguage());
483 ASSERT_NE(nullptr, parse_result);
484 const AidlInterface* interface = parse_result->AsInterface();
485 ASSERT_NE(nullptr, interface);
486 ASSERT_FALSE(interface->GetMethods().empty());
487 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
488}
489
490TEST_P(AidlTest, ParsesNonUtf8Annotations) {
491 auto parse_result =
492 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
493 ASSERT_NE(nullptr, parse_result);
494 const AidlInterface* interface = parse_result->AsInterface();
495 ASSERT_NE(nullptr, interface);
496 ASSERT_FALSE(interface->GetMethods().empty());
497 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800498}
499
Devin Moore7b8d5c92020-03-17 14:14:08 -0700500TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900501 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
502 typenames_, GetLanguage());
503 ASSERT_NE(nullptr, parse_result);
504 const AidlInterface* interface = parse_result->AsInterface();
505 ASSERT_NE(nullptr, interface);
506 ASSERT_FALSE(interface->GetMethods().empty());
507 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800508}
509
Devin Moore7b8d5c92020-03-17 14:14:08 -0700510TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700511 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700512 const string expected_stderr =
513 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
514 "\"vintf\"'\n"
515 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
516 "--structured\n";
517 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700518 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700519 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700520 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522}
523
Devin Moore7b8d5c92020-03-17 14:14:08 -0700524TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700525 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700526 const string expected_stderr =
527 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
528 "--structured\n";
529 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700530 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700531 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700532 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700533 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534}
535
Devin Moore7b8d5c92020-03-17 14:14:08 -0700536TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700537 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700538 const string expected_stderr =
539 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
540 "\"vintf\"'\n";
541 CaptureStderr();
542 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700543 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700545 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546}
547
Devin Moore7b8d5c92020-03-17 14:14:08 -0700548TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700549 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700550 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
551 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700552 ASSERT_EQ(AidlError::OK, error);
553 ASSERT_NE(nullptr, parse_result);
554 const AidlInterface* interface = parse_result->AsInterface();
555 ASSERT_NE(nullptr, interface);
556 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700557}
558
Jeongik Cha64783ed2019-06-07 18:30:54 +0900559TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
560 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900561 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
562 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900563 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700564 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900565 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900566 "a/Foo.aidl",
567 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900568
569 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900570 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700571 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900572 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700573 "Parcelable must be defined in AIDL directly.\n";
574 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900575 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700577
578 CaptureStderr();
579 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
580 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900581}
582
Jooyung Han1cbc4962020-10-25 10:07:15 +0900583TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
584 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
585 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
586 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900587 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
588
589 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900590 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900591 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
592
593 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900594 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900595 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
596
Jooyung Han1cbc4962020-10-25 10:07:15 +0900597 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900598 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
599}
600
Jooyung Han1cbc4962020-10-25 10:07:15 +0900601TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
602 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
603 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
604 CaptureStderr();
605 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
606 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
607 EXPECT_EQ("", GetCapturedStderr());
608
609 const string expected_to_string_method = R"--(
610 @Override
611 public String toString() {
612 switch (_tag) {
613 case a: return "a.Foo.a(" + (getA()) + ")";
614 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
615 }
616 throw new IllegalStateException("unknown field: " + _tag);
617 }
618)--";
619
620 string java_out;
621 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
622 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
623}
624
Jiyong Park9aa3d042020-12-04 23:30:02 +0900625TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
626 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
627 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
628 CaptureStderr();
629 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
630 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
631 EXPECT_EQ("", GetCapturedStderr());
632
633 const std::string expected = R"--(
634 @Override
635 public boolean equals(Object other) {
636 if (this == other) return true;
637 if (other == null) return false;
638 if (!(other instanceof Foo)) return false;
639 Foo that = (Foo)other;
640 if (!java.util.Objects.deepEquals(a, that.a)) return false;
641 if (!java.util.Objects.deepEquals(b, that.b)) return false;
642 return true;
643 }
644
645 @Override
646 public int hashCode() {
647 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
648 }
649)--";
650
651 string java_out;
652 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
653 EXPECT_THAT(java_out, testing::HasSubstr(expected));
654}
655
656TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
657 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
658 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
659 CaptureStderr();
660 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
661 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
662 EXPECT_EQ("", GetCapturedStderr());
663
664 const std::string expected = R"--(
665 @Override
666 public boolean equals(Object other) {
667 if (this == other) return true;
668 if (other == null) return false;
669 if (!(other instanceof Foo)) return false;
670 Foo that = (Foo)other;
671 if (_tag != that._tag) return false;
672 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
673 return true;
674 }
675
676 @Override
677 public int hashCode() {
678 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
679 }
680)--";
681
682 string java_out;
683 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
684 EXPECT_THAT(java_out, testing::HasSubstr(expected));
685}
686
Jooyung Han90345002020-10-23 15:28:53 +0900687TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900688 {
Jooyung Han90345002020-10-23 15:28:53 +0900689 io_delegate_.SetFileContents("a/Foo.aidl",
690 "package a; @JavaDerive(blah=true) parcelable Foo{}");
691 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
692 CaptureStderr();
693 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
694 const std::string expected_stderr =
695 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
696 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
697 }
698
699 {
700 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900701 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
702 CaptureStderr();
703 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
704 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900705 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000706 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
707 "JavaPassthrough, Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900708 EXPECT_EQ(expected_stderr, GetCapturedStderr());
709 }
710
711 {
Jooyung Han90345002020-10-23 15:28:53 +0900712 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900713 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
714 CaptureStderr();
715 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
716 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900717 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900718 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
719 EXPECT_EQ(expected_stderr, GetCapturedStderr());
720 }
721}
722
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900723TEST_P(AidlTest, ParseDescriptorAnnotation) {
724 AidlError error;
725 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
726 typenames_, GetLanguage(), &error, {"--structured"});
727 ASSERT_EQ(AidlError::OK, error);
728 ASSERT_NE(nullptr, parse_result);
729 const AidlInterface* interface = parse_result->AsInterface();
730 ASSERT_NE(nullptr, interface);
731 ASSERT_EQ("IBar", interface->GetDescriptor());
732}
733
Jiyong Park40782d02020-07-24 19:17:43 +0900734TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700735 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700736 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900737}
738
739TEST_P(AidlTest, AcceptsOnewayInterface) {
740 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700741 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700742}
Christopher Wileyef140932015-11-03 09:29:19 -0800743
Devin Moore7b8d5c92020-03-17 14:14:08 -0700744TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700745 const string oneway_method =
746 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700747 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100748}
749
Steven Moreland65297cc2020-04-20 20:17:36 -0700750TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
751 const string oneway_method =
752 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
753 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
754 ASSERT_NE(nullptr, defined);
755 const AidlInterface* iface = defined->AsInterface();
756 ASSERT_NE(nullptr, iface);
757
758 const auto& methods = iface->GetMethods();
759 ASSERT_EQ(1u, methods.size());
760 const auto& method = methods[0];
761 const AidlTypeSpecifier& ret_type = method->GetType();
762
763 // TODO(b/151102494): these annotations should be on the method
764 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
765 ASSERT_TRUE(ret_type.IsHide());
766}
767
Devin Moore7b8d5c92020-03-17 14:14:08 -0700768TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100769 string foo_interface =
770 "package a; /* foo */ interface IFoo {"
771 " /* i */ int i();"
772 " /* j */ @nullable String j();"
773 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
774
Devin Moore7b8d5c92020-03-17 14:14:08 -0700775 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100776 EXPECT_NE(nullptr, parse_result);
777 EXPECT_EQ("/* foo */", parse_result->GetComments());
778
779 const AidlInterface* interface = parse_result->AsInterface();
780 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
781 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
782 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
783}
784
Jooyung Han1a551d32020-10-05 15:37:26 +0900785TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
786 io_delegate_.SetFileContents("p/cpp_header.aidl",
787 R"(package p;
788 parcelable cpp_header cpp_header "bar/header";)");
789 import_paths_.emplace("");
790 const string input_path = "p/IFoo.aidl";
791 const string input = R"(package p;
792 import p.cpp_header;
793 interface IFoo {
794 // get bar
795 cpp_header get();
796 })";
797
798 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
799 EXPECT_NE(nullptr, parse_result);
800 const AidlInterface* interface = parse_result->AsInterface();
801 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
802}
803
Christopher Wileyef140932015-11-03 09:29:19 -0800804TEST_F(AidlTest, ParsesPreprocessedFile) {
805 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
806 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700807 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900808 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700809 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
810 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800811}
812
813TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
814 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
815 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900816
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700817 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900818 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700819 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
820 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800821}
822
Devin Moore7b8d5c92020-03-17 14:14:08 -0700823TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800824 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
825 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
826 "interface IBar {}");
827 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900828 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900829 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700830 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800831 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900832
Christopher Wiley41544372015-11-03 14:52:29 -0800833 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700834 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
835 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800836 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700837 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900838 ambiguous_type.Resolve(typenames_);
839 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800840}
841
Jiyong Park8f6ec462020-01-19 20:52:47 +0900842// Special case of PreferImportToPreprocessed. Imported type should be preferred
843// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700844TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900845 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
846 io_delegate_.SetFileContents("one/IBar.aidl",
847 "package one; "
848 "interface IBar {}");
849 preprocessed_files_.push_back("preprocessed");
850 import_paths_.emplace("");
851 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700852 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900853 EXPECT_NE(nullptr, parse_result);
854
855 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700856 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
857 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900858 // But if we request just "IBar" we should get our imported one.
859 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
860 ambiguous_type.Resolve(typenames_);
861 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
862}
863
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800864TEST_F(AidlTest, WritePreprocessedFile) {
865 io_delegate_.SetFileContents("p/Outer.aidl",
866 "package p; parcelable Outer.Inner;");
867 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
868 "interface IBar {}");
869
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900870 vector<string> args {
871 "aidl",
872 "--preprocess",
873 "preprocessed",
874 "p/Outer.aidl",
875 "one/IBar.aidl"};
876 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800877 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
878
879 string output;
880 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
881 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
882}
883
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900884TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100885 io_delegate_.SetFileContents(
886 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800887 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100888 "parcelable Rect {\n"
889 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800890 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100891 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800892 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100893 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100894 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
895 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100896 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900897 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900898 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100899 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900900
901 vector<string> args{"aidl", "Rect.aidl"};
902 Options options = Options::From(args);
903 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
904
905 string output;
906 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900907 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900908}
909
Devin Moore2f2077a2020-08-28 11:27:53 -0700910TEST_F(AidlTest, CppHeaderIncludes) {
911 io_delegate_.SetFileContents("IFoo.aidl",
912 "interface IFoo {\n"
913 " @nullable List<String> foo();\n"
914 "}");
915
916 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
917 Options options = Options::From(args);
918 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
919 std::vector<std::string> empty;
920 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
921 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
922 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
923
924 // Make sure the optional and String16.h includes are added
925 string output;
926 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
927 EXPECT_EQ(kExpectedCppHeaderOutput, output);
928}
929
Devin Moore7b8d5c92020-03-17 14:14:08 -0700930TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700931 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800932 io_delegate_.SetFileContents("p/Outer.aidl",
933 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900934 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700935 CaptureStderr();
936 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
937 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700938 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700939 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800940}
941
Devin Moore7b8d5c92020-03-17 14:14:08 -0700942TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800943 io_delegate_.SetFileContents("preprocessed",
944 "parcelable p.Outer.Inner;");
945 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900946 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700947 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800948 // TODO(wiley): This should actually return nullptr because we require
949 // the outer class name. However, for legacy reasons,
950 // this behavior must be maintained. b/17415692
951 EXPECT_NE(nullptr, parse_result);
952}
953
Christopher Wiley632801d2015-11-05 14:15:49 -0800954TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700955 const string expected_foo_stderr =
956 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
957 "Declared parcelables should be in their own file and/or cannot be used with --structured "
958 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700959 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
960
Christopher Wiley632801d2015-11-05 14:15:49 -0800961 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700962 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700963 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900964 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700965 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900966
Steven Morelande2c64b42018-09-18 15:06:37 -0700967 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900968 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700969 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900970 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700971 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700972
Devin Moore097a3ab2020-03-11 16:08:44 -0700973 const string expected_bar_stderr =
974 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
975 "Declared parcelables should be in their own file and/or cannot be used with --structured "
976 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700977 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
978
Jiyong Parkda8c6932019-08-12 19:56:08 +0900979 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700980 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700981 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900982 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700983 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700984 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700985 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700986 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700987 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800988}
989
Devin Moore7b8d5c92020-03-17 14:14:08 -0700990TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700991 const string expected_stderr =
992 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
993 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700994 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
995 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700996 AidlError error;
997 CaptureStderr();
998 EXPECT_EQ(
999 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001000 Parse("p/IFoo.aidl",
1001 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001002 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001003 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1004 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001005}
1006
Devin Moore7b8d5c92020-03-17 14:14:08 -07001007TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001008 AidlError error;
1009 const string expected_stderr =
1010 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1011 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001012 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1013 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001014 interface IFoo {
1015 const String DUPLICATED = "d";
1016 const int DUPLICATED = 1;
1017 }
1018 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001019 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001020 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1021 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001022}
1023
Steven Morelande689da22020-11-10 02:06:30 +00001024TEST_P(AidlTest, FailOnTooBigConstant) {
1025 AidlError error;
1026 const string expected_stderr =
1027 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1028 CaptureStderr();
1029 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1030 R"(package p;
1031 interface IFoo {
1032 const byte type2small = 256;
1033 }
1034 )",
1035 typenames_, GetLanguage(), &error));
1036 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1037 EXPECT_EQ(AidlError::BAD_TYPE, error);
1038}
1039
Devin Moore7b8d5c92020-03-17 14:14:08 -07001040TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001041 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001042 const string expected_stderr =
1043 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001044 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001045 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1046 R"(package p;
1047 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001048 parcelable IBar {}
1049 parcelable StructuredParcelable {}
1050 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001051 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001052 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001053 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001054 // Parse success is important for clear error handling even if the cases aren't
1055 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001056 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001057}
1058
Devin Moore7b8d5c92020-03-17 14:14:08 -07001059TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001060 AidlError error;
1061 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1062 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001063 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001064 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1065 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001066}
1067
Steven Morelandf9e922f2020-07-08 21:15:27 +00001068TEST_P(AidlTest, FailOnEmptyListWithComma) {
1069 AidlError error;
1070 const string expected_stderr =
1071 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1072 CaptureStderr();
1073 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1074 typenames_, GetLanguage(), &error));
1075 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1076 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1077}
1078
Devin Moore7b8d5c92020-03-17 14:14:08 -07001079TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001080 AidlError error;
1081 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001082 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001083 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001084 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1085 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001086 interface IFoo {
1087 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1088 }
1089 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001090 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001091 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1092 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001093}
1094
Jiyong Park18132182020-06-08 20:24:40 +09001095TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1096 AidlError error;
1097 const string expected_stderr =
1098 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1099 "cpp_header (which can also be used as an identifier)\n";
1100 CaptureStderr();
1101 // Notice the trailing dot(.) in the name, which isn't a correct name
1102 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1103 GetLanguage(), &error));
1104 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1105 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1106}
1107
1108TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1109 AidlError error;
1110 const string expected_stderr =
1111 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1112 "cpp_header (which can also be used as an identifier)\n";
1113 CaptureStderr();
1114 // Notice the trailing dot(.) in the package name
1115 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1116 GetLanguage(), &error));
1117 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1118 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1119}
1120
Devin Moore7b8d5c92020-03-17 14:14:08 -07001121TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001122 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001123 auto parse_result = Parse("p/IFoo.aidl",
1124 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001125 interface IFoo {
1126 const int POSITIVE_HEX_VALUE = 0xf5;
1127 }
1128 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001129 typenames_, GetLanguage(), &error);
1130 EXPECT_NE(nullptr, parse_result);
1131 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001132 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001133 const auto& cpp_constants = interface->GetConstantDeclarations();
1134 EXPECT_EQ((size_t)1, cpp_constants.size());
1135 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001136 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001137 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001138}
1139
Devin Moore7b8d5c92020-03-17 14:14:08 -07001140TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001141 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001142 auto parse_result = Parse("p/IFoo.aidl",
1143 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001144 interface IFoo {
1145 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1146 }
1147 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001148 typenames_, GetLanguage(), &error);
1149 ASSERT_NE(nullptr, parse_result);
1150 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001151 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001152 const auto& cpp_constants = interface->GetConstantDeclarations();
1153 EXPECT_EQ((size_t)1, cpp_constants.size());
1154 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001155 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001156 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001157}
1158
Devin Moore7b8d5c92020-03-17 14:14:08 -07001159TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001160 io_delegate_.SetFileContents(
1161 "p/Outer.aidl",
1162 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001163 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001164 const string input_path = "p/IFoo.aidl";
1165 const string input = "package p; import p.Outer; interface IFoo"
1166 " { Outer.Inner get(); }";
1167
Devin Moore7b8d5c92020-03-17 14:14:08 -07001168 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1169 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001170
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001171 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001172 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001173 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1174 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001175}
1176
Devin Moore7b8d5c92020-03-17 14:14:08 -07001177TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001178 io_delegate_.SetFileContents(
1179 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001180 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001181 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001182 const string input_path = "p/IFoo.aidl";
1183 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001184 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1185 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001186 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001187 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1188 native_type.Resolve(typenames_);
1189
1190 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1191 // C++ understands C++ specific stuff
1192 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1193 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001194 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001195 EXPECT_EQ(1u, headers.size());
1196 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001197}
1198
Christopher Wileyf8136192016-04-12 14:19:35 -07001199TEST_F(AidlTest, WritesCorrectDependencyFile) {
1200 // While the in tree build system always gives us an output file name,
1201 // other android tools take advantage of our ability to infer the intended
1202 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001203 vector<string> args = {
1204 "aidl",
1205 "-d dep/file/path",
1206 "-o place/for/output",
1207 "p/IFoo.aidl"};
1208 Options options = Options::From(args);
1209 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001210 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001211 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001212 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001213 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1214}
1215
Dan Willemsen93298ee2016-11-10 23:55:55 -08001216TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1217 // While the in tree build system always gives us an output file name,
1218 // other android tools take advantage of our ability to infer the intended
1219 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001220 vector<string> args = {
1221 "aidl",
1222 "-d dep/file/path",
1223 "--ninja",
1224 "-o place/for/output",
1225 "p/IFoo.aidl"};
1226 Options options = Options::From(args);
1227 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001228 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001229 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001230 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001231 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1232}
1233
Jiyong Parkdf202122019-09-30 20:48:35 +09001234TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001235 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1236 // this by calling aidl with every .aidl file it finds, then parsing the
1237 // generated dependency files. Those that reference .java output files are
1238 // for interfaces and those that do not are parcelables. However, for both
1239 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001240 vector<string> args = {
1241 "aidl",
1242 "-o place/for/output",
1243 "-d dep/file/path",
1244 "p/Foo.aidl"};
1245 Options options = Options::From(args);
1246 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001247 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001248 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001249 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001250 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1251}
1252
1253TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1254 vector<string> args = {
1255 "aidl",
1256 "--structured",
1257 "-o place/for/output",
1258 "-d dep/file/path",
1259 "p/Foo.aidl"};
1260 Options options = Options::From(args);
1261 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1262 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1263 string actual_dep_file_contents;
1264 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1265 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001266}
1267
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001268TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1269 vector<string> args = {
1270 "aidl",
1271 "--lang=java",
1272 "-o place/for/output",
1273 "p/Foo.aidl"};
1274 Options options = Options::From(args);
1275 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1276 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1277 string output_file_contents;
1278 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1279}
1280
Jeongik Cha08ca2182019-11-21 14:01:13 +09001281// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001282TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001283 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001284 "package a; interface IFoo {\n"
1285 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001286 string expected_stderr;
1287 switch (GetLanguage()) {
1288 case Options::Language::CPP:
1289 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001290 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001291 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1292 "String and IBinder.\n";
1293 break;
1294 case Options::Language::JAVA:
1295 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001296 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001297 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1298 "String, IBinder, and ParcelFileDescriptor.\n";
1299 break;
1300 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001301 case Options::Language::RUST:
1302 expected_stderr =
1303 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1304 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001305 default:
1306 AIDL_FATAL(AIDL_LOCATION_HERE)
1307 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1308 }
1309 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001310 AidlTypenames tn1;
1311 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001312 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001313
1314 string primitive_parcelable =
1315 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001316 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001317 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001318 AidlTypenames tn2;
1319 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001320 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001321}
1322
Devin Moore21b26772020-08-26 16:37:56 -07001323TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001324 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001325 const string list_array_parcelable =
1326 "package a; parcelable Foo {\n"
1327 " List[] lists; }";
1328 CaptureStderr();
1329 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1330 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1331}
1332
Jiyong Parkf8d53612020-05-04 14:06:13 +09001333TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1334 AidlError error;
1335 string expected_stderr =
1336 "ERROR: a/IFoo.aidl:2.7-11: "
1337 "Encountered an untyped List or Map. The use of untyped List/Map is "
1338 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1339 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1340 if (GetLanguage() != Options::Language::JAVA) {
1341 expected_stderr =
1342 "ERROR: a/IFoo.aidl:2.1-7: "
1343 "Currently, only the Java backend supports non-generic List.\n";
1344 }
1345
1346 const string primitive_interface =
1347 "package a; interface IFoo {\n"
1348 " List foo(); }";
1349 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001350 AidlTypenames tn1;
1351 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001352 {"--structured"}));
1353 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001354
1355 string primitive_parcelable =
1356 "package a; parcelable IFoo {\n"
1357 " List foo;}";
1358 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001359 AidlTypenames tn2;
1360 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001361 {"--structured"}));
1362 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1363}
1364
Jeongik Cha225519b2020-08-29 01:55:32 +09001365TEST_P(AidlTest, ExtensionTest) {
1366 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001367 string extendable_parcelable =
1368 "package a; parcelable Data {\n"
1369 " ParcelableHolder extension;\n"
1370 " ParcelableHolder extension2;\n"
1371 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001372 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001373 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1374 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001375 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001376 "yet.\n",
1377 GetCapturedStderr());
1378 } else {
1379 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1380 EXPECT_EQ("", GetCapturedStderr());
1381 }
1382}
1383TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1384 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001385 string parcelableholder_return_interface =
1386 "package a; interface IFoo {\n"
1387 " ParcelableHolder foo();\n"
1388 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001389 EXPECT_EQ(nullptr,
1390 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001391
Jeongik Cha8f02a532020-10-14 00:16:28 +09001392 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001393 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001394 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001395 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001396 "yet.\n",
1397 GetCapturedStderr());
1398 return;
1399 }
1400 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1401 GetCapturedStderr());
1402}
1403
1404TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1405 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001406 string extendable_parcelable_arg_interface =
1407 "package a; interface IFoo {\n"
1408 " void foo(in ParcelableHolder ph);\n"
1409 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001410 EXPECT_EQ(nullptr,
1411 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1412
Jeongik Cha8f02a532020-10-14 00:16:28 +09001413 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001414 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001415 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001416 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001417 "yet.\n",
1418 GetCapturedStderr());
1419 return;
1420 }
1421 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1422 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001423}
1424
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001425TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1426 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1427 Options options =
1428 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1429 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1430 CaptureStderr();
1431 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1432 if (GetLanguage() == Options::Language::RUST) {
1433 EXPECT_EQ(
1434 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1435 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1436 "yet.\n",
1437 GetCapturedStderr());
1438 return;
1439 }
1440 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1441}
1442
Jooyung Han3f347ca2020-12-01 12:41:50 +09001443TEST_P(AidlTest, ParcelablesWithConstants) {
1444 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
1445 Options options =
1446 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1447 CaptureStderr();
1448 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1449 EXPECT_EQ("", GetCapturedStderr());
1450}
1451
1452TEST_P(AidlTest, UnionWithConstants) {
1453 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
1454 Options options =
1455 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1456 CaptureStderr();
1457 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1458 EXPECT_EQ("", GetCapturedStderr());
1459}
1460
Jiyong Park02da7422018-07-16 16:00:26 +09001461TEST_F(AidlTest, ApiDump) {
1462 io_delegate_.SetFileContents(
1463 "foo/bar/IFoo.aidl",
1464 "package foo.bar;\n"
1465 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001466 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001467 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001468 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001469 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1470 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1471 " IFoo foo3(IFoo foo);\n"
1472 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001473 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001474 " const int A = 1;\n"
1475 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001476 "}\n");
1477 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1478 "package foo.bar;\n"
1479 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001480 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001481 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001482 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001483 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001484 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001485 " int y;\n"
1486 " IFoo foo;\n"
1487 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001488 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001489 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001490 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001491 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001492 "}\n");
1493 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001494 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1495 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001496 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001497 bool result = dump_api(options, io_delegate_);
1498 ASSERT_TRUE(result);
1499 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001500 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001501 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001502/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001503interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001504 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001505 int foo(out int[] a, String b, boolean c, inout List<String> d);
1506 int foo2(@utf8InCpp String x, inout List<String> y);
1507 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1508 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001509 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001510 const int A = 1;
1511 const String STR = "Hello";
1512}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001513)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001514
Jiyong Parke59c3682018-09-11 23:10:25 +09001515 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001516 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001517/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001518parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001519 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001520 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001521 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001522 int y;
1523 foo.bar.IFoo foo;
1524 List<foo.bar.IFoo> a;
1525 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001526 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001527 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001528}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001529)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001530}
1531
Jiyong Parked65bf42018-08-28 15:43:27 +09001532TEST_F(AidlTest, ApiDumpWithManualIds) {
1533 io_delegate_.SetFileContents(
1534 "foo/bar/IFoo.aidl",
1535 "package foo.bar;\n"
1536 "interface IFoo {\n"
1537 " int foo() = 1;\n"
1538 " int bar() = 2;\n"
1539 " int baz() = 10;\n"
1540 "}\n");
1541
Jiyong Parke59c3682018-09-11 23:10:25 +09001542 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001543 Options options = Options::From(args);
1544 bool result = dump_api(options, io_delegate_);
1545 ASSERT_TRUE(result);
1546 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001547 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001548 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001549interface IFoo {
1550 int foo() = 1;
1551 int bar() = 2;
1552 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001553}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001554)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001555}
1556
1557TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001558 const string expected_stderr =
1559 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1560 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001561 io_delegate_.SetFileContents(
1562 "foo/bar/IFoo.aidl",
1563 "package foo.bar;\n"
1564 "interface IFoo {\n"
1565 " int foo() = 1;\n"
1566 " int bar();\n"
1567 " int baz() = 10;\n"
1568 "}\n");
1569
Jiyong Parke59c3682018-09-11 23:10:25 +09001570 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001571 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001572 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001573 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001574 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001575}
1576
Jooyung Han965e31d2020-11-27 12:30:16 +09001577TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1578 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1579 "package foo.bar;\n"
1580 "interface IFoo {\n"
1581 " @utf8InCpp String foo();\n"
1582 " const @utf8InCpp String bar = \"bar\";\n"
1583 "}\n");
1584
1585 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1586 Options options = Options::From(args);
1587 CaptureStderr();
1588 EXPECT_TRUE(dump_api(options, io_delegate_));
1589 EXPECT_EQ("", GetCapturedStderr());
1590 string actual;
1591 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001592 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1593interface IFoo {
1594 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001595 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001596}
1597)"),
1598 actual);
1599}
1600
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001601TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001602 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001603 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1604 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001605 const string expected_map_stderr =
1606 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001607 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1608 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001609 "package p; interface IFoo {"
1610 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001611 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001612 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001613 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001614
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001615 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001616 "package p; interface IFoo {"
1617 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001618 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001619 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001620 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001621}
1622
Jeongik Chae48d9942020-01-02 17:39:00 +09001623TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001624 const string expected_stderr =
1625 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001626 Options options = Options::From("aidl -I p p/IFoo.aidl");
1627 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1628
1629 io_delegate_.SetFileContents("p/IFoo.aidl",
1630 "package p; interface IFoo {"
1631 "Map<String, Bar> foo();}");
1632 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1633
1634 io_delegate_.SetFileContents("p/IFoo.aidl",
1635 "package p; interface IFoo {"
1636 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001637 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001638 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001639 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001640
1641 io_delegate_.SetFileContents("p/IFoo.aidl",
1642 "package p; interface IFoo {"
1643 "Map<String, String> foo();}");
1644 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1645
1646 io_delegate_.SetFileContents("p/IFoo.aidl",
1647 "package p; interface IFoo {"
1648 "Map<String, ParcelFileDescriptor> foo();}");
1649 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1650}
1651
Jeongik Chadf76dc72019-11-28 00:08:47 +09001652TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001653 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001654 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1655 io_delegate_.SetFileContents(options.InputFiles().front(),
1656 "package p; interface IFoo {"
1657 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001658 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001659 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001660 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001661}
1662
1663TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1664 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1665 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001666 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001667 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001668 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1669 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001670
1671 Options options = Options::From("aidl -I p p/IFoo.aidl");
1672 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1673 io_delegate_.SetFileContents("p/IFoo.aidl",
1674 "package p; interface IFoo {"
1675 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001676 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001677 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001678 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001679 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001680 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001681 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001682 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1683 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001684 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1685 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1686 io_delegate_.SetFileContents("p/IFoo.aidl",
1687 "package p; interface IFoo {"
1688 "Bar<String, ParcelFileDescriptor> foo();}");
1689 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001690
1691 io_delegate_.SetFileContents("p/IFoo.aidl",
1692 "package p; interface IFoo {"
1693 "Bar<int, long> foo();}");
1694
1695 io_delegate_.SetFileContents("p/IFoo.aidl",
1696 "package p; interface IFoo {"
1697 "Bar<int[], long[]> foo();}");
1698
1699 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001700}
1701
Jeongik Cha0e426012019-07-29 15:57:02 +09001702TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1703 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001704 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1705 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001706 for (const auto& rawOption : rawOptions) {
1707 string expected_stderr =
1708 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001709 Options options = Options::From(rawOption);
1710 io_delegate_.SetFileContents(options.InputFiles().front(),
1711 "package foo.bar;\n"
1712 "interface IFoo1 { int foo(); }\n"
1713 "interface IFoo2 { int foo(); }\n"
1714 "parcelable Data1 { int a; int b;}\n"
1715 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001716 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001717 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001718 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001719
Jeongik Cha0e426012019-07-29 15:57:02 +09001720 io_delegate_.SetFileContents(options.InputFiles().front(),
1721 "package foo.bar;\n"
1722 "interface IFoo1 { int foo(); }\n"
1723 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001724 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001725 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001726 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001727
Devin Moore5de18ed2020-04-02 13:52:29 -07001728 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001729 io_delegate_.SetFileContents(options.InputFiles().front(),
1730 "package foo.bar;\n"
1731 "parcelable Data1 { int a; int b;}\n"
1732 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001733 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001734 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001735 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001736 }
1737}
1738
Devin Moorebdba2a82020-03-31 15:19:02 -07001739TEST_P(AidlTest, FailParseOnEmptyFile) {
1740 const string contents = "";
1741 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1742 CaptureStderr();
1743 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1744 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1745}
1746
Jiyong Parkb034bf02018-07-30 17:44:33 +09001747TEST_F(AidlTest, MultipleInputFiles) {
1748 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001749 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001750
1751 io_delegate_.SetFileContents(options.InputFiles().at(0),
1752 "package foo.bar;\n"
1753 "import foo.bar.Data;\n"
1754 "interface IFoo { Data getData(); }\n");
1755
1756 io_delegate_.SetFileContents(options.InputFiles().at(1),
1757 "package foo.bar;\n"
1758 "import foo.bar.IFoo;\n"
1759 "parcelable Data { IFoo foo; }\n");
1760
1761 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1762
1763 string content;
1764 for (const auto file : {
1765 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1766 content.clear();
1767 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1768 EXPECT_FALSE(content.empty());
1769 }
1770}
1771
1772TEST_F(AidlTest, MultipleInputFilesCpp) {
1773 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001774 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001775
1776 io_delegate_.SetFileContents(options.InputFiles().at(0),
1777 "package foo.bar;\n"
1778 "import foo.bar.Data;\n"
1779 "interface IFoo { Data getData(); }\n");
1780
1781 io_delegate_.SetFileContents(options.InputFiles().at(1),
1782 "package foo.bar;\n"
1783 "import foo.bar.IFoo;\n"
1784 "parcelable Data { IFoo foo; }\n");
1785
1786 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1787
1788 string content;
1789 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001790 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001791 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1792 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1793 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1794 content.clear();
1795 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1796 EXPECT_FALSE(content.empty());
1797 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001798}
1799
Andrei Homescub62afd92020-05-11 19:24:59 -07001800TEST_F(AidlTest, MultipleInputFilesRust) {
1801 Options options =
1802 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1803
1804 io_delegate_.SetFileContents(options.InputFiles().at(0),
1805 "package foo.bar;\n"
1806 "import foo.bar.Data;\n"
1807 "interface IFoo { Data getData(); }\n");
1808
1809 io_delegate_.SetFileContents(options.InputFiles().at(1),
1810 "package foo.bar;\n"
1811 "import foo.bar.IFoo;\n"
1812 "parcelable Data { IFoo foo; }\n");
1813
1814 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1815
1816 string content;
1817 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1818 content.clear();
1819 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1820 EXPECT_FALSE(content.empty());
1821 }
1822}
1823
Devin Moore097a3ab2020-03-11 16:08:44 -07001824TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1825 const string expected_stderr =
1826 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001827 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1828 // int getInterfaceVersion() is one of the meta transactions
1829 io_delegate_.SetFileContents(options.InputFiles().front(),
1830 "package p; interface IFoo {"
1831 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001832 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001833 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001834 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1835}
Jiyong Park309668e2018-07-28 16:55:44 +09001836
Devin Moore097a3ab2020-03-11 16:08:44 -07001837TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1838 // boolean getInterfaceVersion() is not a meta transaction, but should be
1839 // prevented because return type is not part of a method signature
1840 const string expected_stderr =
1841 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1842 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001843 io_delegate_.SetFileContents(options.InputFiles().front(),
1844 "package p; interface IFoo {"
1845 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001846 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001847 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001848 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1849}
Jiyong Park309668e2018-07-28 16:55:44 +09001850
Devin Moore097a3ab2020-03-11 16:08:44 -07001851TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001852 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001853 const string expected_stderr =
1854 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1855 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001856 io_delegate_.SetFileContents(options.InputFiles().front(),
1857 "package p; interface IFoo {"
1858 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001859 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001860 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001861 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001862
1863 // this is not a meta interface method as it differs type arguments
1864 io_delegate_.SetFileContents(options.InputFiles().front(),
1865 "package p; interface IFoo {"
1866 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001867 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001868}
1869
Daniel Norman85aed542019-08-21 12:01:14 -07001870TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001871 Options options = Options::From("aidl --checkapi old new");
1872 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1873 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1874 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1875 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1876
1877 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1878}
1879
Jiyong Park3656c3c2018-08-01 20:02:01 +09001880TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001881 Options options = Options::From("aidl --checkapi old new");
1882 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1883 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001884
1885 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1886}
1887
Daniel Norman85aed542019-08-21 12:01:14 -07001888class AidlTestCompatibleChanges : public AidlTest {
1889 protected:
1890 Options options_ = Options::From("aidl --checkapi old new");
1891};
1892
1893TEST_F(AidlTestCompatibleChanges, NewType) {
1894 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1895 "package p;"
1896 "interface IFoo {"
1897 " void foo(int a);"
1898 "}");
1899 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1900 "package p;"
1901 "interface IFoo {"
1902 " void foo(int a);"
1903 "}");
1904 io_delegate_.SetFileContents("new/p/IBar.aidl",
1905 "package p;"
1906 "interface IBar {"
1907 " void bar();"
1908 "}");
1909 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1910}
1911
1912TEST_F(AidlTestCompatibleChanges, NewMethod) {
1913 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1914 "package p;"
1915 "interface IFoo {"
1916 " void foo(int a);"
1917 "}");
1918 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1919 "package p;"
1920 "interface IFoo {"
1921 " void foo(int a);"
1922 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001923 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001924 "}");
1925 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1926}
1927
1928TEST_F(AidlTestCompatibleChanges, NewField) {
1929 io_delegate_.SetFileContents("old/p/Data.aidl",
1930 "package p;"
1931 "parcelable Data {"
1932 " int foo;"
1933 "}");
1934 io_delegate_.SetFileContents("new/p/Data.aidl",
1935 "package p;"
1936 "parcelable Data {"
1937 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001938 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001939 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001940 "}");
1941 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1942}
1943
1944TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1945 io_delegate_.SetFileContents("old/p/Enum.aidl",
1946 "package p;"
1947 "enum Enum {"
1948 " FOO = 1,"
1949 "}");
1950 io_delegate_.SetFileContents("new/p/Enum.aidl",
1951 "package p;"
1952 "enum Enum {"
1953 " FOO = 1,"
1954 " BAR = 2,"
1955 "}");
1956 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1957}
1958
1959TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1960 io_delegate_.SetFileContents("old/p/Enum.aidl",
1961 "package p;"
1962 "enum Enum {"
1963 " FOO = 1,"
1964 " BAR = 2,"
1965 "}");
1966 io_delegate_.SetFileContents("new/p/Enum.aidl",
1967 "package p;"
1968 "enum Enum {"
1969 " BAR = 2,"
1970 " FOO = 1,"
1971 "}");
1972 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1973}
1974
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001975TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1976 io_delegate_.SetFileContents("old/p/Union.aidl",
1977 "package p;"
1978 "union Union {"
1979 " String foo;"
1980 "}");
1981 io_delegate_.SetFileContents("new/p/Union.aidl",
1982 "package p;"
1983 "union Union {"
1984 " String foo;"
1985 " int num;"
1986 "}");
1987 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1988}
1989
Daniel Norman85aed542019-08-21 12:01:14 -07001990TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001991 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1992 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001993 "interface IFoo {"
1994 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001995 "}");
1996 io_delegate_.SetFileContents("old/p/Data.aidl",
1997 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001998 "parcelable Data {"
1999 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002000 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002001 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2002 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002003 "interface IFoo {"
2004 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002005 "}");
2006 io_delegate_.SetFileContents("new/p/Data.aidl",
2007 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002008 "parcelable Data {"
2009 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002010 "}");
2011 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2012 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002013 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002014 " void foo(int a);"
2015 "}");
2016 io_delegate_.SetFileContents("new/q/Data.aidl",
2017 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002018 "parcelable Data {"
2019 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002020 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002021 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2022}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002023
Daniel Norman85aed542019-08-21 12:01:14 -07002024TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2025 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2026 "package p;"
2027 "interface IFoo {"
2028 " void foo(int a);"
2029 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002030 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2031 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002032 "interface IFoo {"
2033 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002034 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002035 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2036}
Jiyong Parke59c3682018-09-11 23:10:25 +09002037
Daniel Norman85aed542019-08-21 12:01:14 -07002038TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002039 io_delegate_.SetFileContents("old/p/I.aidl",
2040 "package p; interface I {"
2041 "const int A = 1; }");
2042 io_delegate_.SetFileContents("new/p/I.aidl",
2043 "package p ; interface I {"
2044 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002045 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2046}
Jiyong Parka428d212018-08-29 22:26:30 +09002047
Daniel Norman85aed542019-08-21 12:01:14 -07002048TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002049 io_delegate_.SetFileContents("old/p/I.aidl",
2050 "package p; interface I {"
2051 "const int A = 1; const int B = 2;}");
2052 io_delegate_.SetFileContents("new/p/I.aidl",
2053 "package p ; interface I {"
2054 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002055 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002056}
2057
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002058TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2059 io_delegate_.SetFileContents("old/p/Foo.aidl",
2060 "package p;"
2061 "@JavaPassthrough(annotation=\"Alice\")"
2062 "@JavaPassthrough(annotation=\"Bob\")"
2063 "parcelable Foo {}");
2064 io_delegate_.SetFileContents("new/p/Foo.aidl",
2065 "package p;"
2066 "@JavaPassthrough(annotation=\"Bob\")"
2067 "@JavaPassthrough(annotation=\"Alice\")"
2068 "parcelable Foo {}");
2069 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2070}
2071
Jooyung Han00073272020-11-27 14:20:20 +09002072TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2073 io_delegate_.SetFileContents("old/p/Foo.aidl",
2074 "package p;"
2075 "parcelable Foo {}");
2076 io_delegate_.SetFileContents("new/p/Foo.aidl",
2077 "package p;"
2078 "@JavaPassthrough(annotation=\"@Deprecated\")"
2079 "parcelable Foo {}");
2080 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2081}
2082
Jooyung Han636fd2f2020-10-22 11:33:45 +09002083TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2084 io_delegate_.SetFileContents("old/p/Data.aidl",
2085 "package p;"
2086 "parcelable Data {"
2087 " int num;"
2088 "}");
2089 io_delegate_.SetFileContents(
2090 "new/p/Data.aidl",
2091 "package p;"
2092 "parcelable Data {"
2093 " int num;"
2094 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2095 "}");
2096 io_delegate_.SetFileContents("new/p/Enum.aidl",
2097 "package p;"
2098 "enum Enum {"
2099 " FOO = 0,"
2100 " BAR = 1,"
2101 "}");
2102 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2103}
2104
Daniel Norman85aed542019-08-21 12:01:14 -07002105class AidlTestIncompatibleChanges : public AidlTest {
2106 protected:
2107 Options options_ = Options::From("aidl --checkapi old new");
2108};
2109
2110TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002111 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002112 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2113 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002114 "interface IFoo {"
2115 " void foo(in String[] str);"
2116 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002117 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002118 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002119 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002120 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002121}
2122
2123TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002124 const string expected_stderr =
2125 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002126 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2127 "package p;"
2128 "interface IFoo {"
2129 " void foo(in String[] str);"
2130 " void bar(@utf8InCpp String str);"
2131 "}");
2132 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2133 "package p;"
2134 "interface IFoo {"
2135 " void foo(in String[] str);"
2136 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002137 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002138 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002139 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002140}
2141
Jiyong Parkf8d53612020-05-04 14:06:13 +09002142TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2143 const string expected_stderr =
2144 "ERROR: new/p/IFoo.aidl:1.61-65: "
2145 "Encountered an untyped List or Map. The use of untyped List/Map is "
2146 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2147 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2148 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2149 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2150 "package p;"
2151 "interface IFoo {"
2152 " void foo(in String[] str);"
2153 "}");
2154 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2155 "package p;"
2156 "interface IFoo {"
2157 " void foo(in String[] str);"
2158 " void bar(in List arg);"
2159 "}");
2160 CaptureStderr();
2161 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2162 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2163}
2164
2165TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2166 const string expected_stderr =
2167 "ERROR: new/p/Data.aidl:1.54-59: "
2168 "Encountered an untyped List or Map. The use of untyped List/Map is "
2169 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2170 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2171 "ERROR: new/p/Data.aidl: Failed to read.\n";
2172 io_delegate_.SetFileContents("old/p/Data.aidl",
2173 "package p;"
2174 "parcelable Data {"
2175 " int foo;"
2176 "}");
2177 io_delegate_.SetFileContents("new/p/Data.aidl",
2178 "package p;"
2179 "parcelable Data {"
2180 " int foo;"
2181 " @nullable List list;"
2182 "}");
2183 CaptureStderr();
2184 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2185 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2186}
2187
Daniel Norman85aed542019-08-21 12:01:14 -07002188TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002189 const string expected_stderr =
2190 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002191 io_delegate_.SetFileContents("old/p/Data.aidl",
2192 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002193 "parcelable Data {"
2194 " int foo;"
2195 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002196 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002197 io_delegate_.SetFileContents("new/p/Data.aidl",
2198 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002199 "parcelable Data {"
2200 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002201 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002202 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002203 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002204 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002205}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002206
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002207TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2208 const string expected_stderr =
2209 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2210 "backends. Please either provide a default value for this field or mark the field as "
2211 "@nullable. This value or a null value will be used automatically when an old version of "
2212 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2213 "order to make sure your code continues to be backwards compatible, make sure the default or "
2214 "null value does not cause a semantic change to this parcelable.\n";
2215 io_delegate_.SetFileContents("old/p/Data.aidl",
2216 "package p;"
2217 "parcelable Data {"
2218 " int num;"
2219 "}");
2220 io_delegate_.SetFileContents("new/p/Data.aidl",
2221 "package p;"
2222 "parcelable Data {"
2223 " int num;"
2224 " String str;"
2225 "}");
2226 CaptureStderr();
2227 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2228 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2229}
2230
Jooyung Han636fd2f2020-10-22 11:33:45 +09002231TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2232 const string expected_stderr =
2233 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2234 "Please make sure 'Enum' has '0' as a valid value.\n";
2235 io_delegate_.SetFileContents("old/p/Data.aidl",
2236 "package p;"
2237 "parcelable Data {"
2238 " int num;"
2239 "}");
2240 io_delegate_.SetFileContents("new/p/Data.aidl",
2241 "package p;"
2242 "parcelable Data {"
2243 " int num;"
2244 " p.Enum e;"
2245 "}");
2246 io_delegate_.SetFileContents("new/p/Enum.aidl",
2247 "package p;"
2248 "enum Enum {"
2249 " FOO = 1,"
2250 " BAR = 2,"
2251 "}");
2252 CaptureStderr();
2253 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2254 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2255}
2256
Daniel Norman85aed542019-08-21 12:01:14 -07002257TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002258 const string expected_stderr =
2259 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002260 io_delegate_.SetFileContents("old/p/Enum.aidl",
2261 "package p;"
2262 "enum Enum {"
2263 " FOO = 1,"
2264 " BAR = 2,"
2265 "}");
2266 io_delegate_.SetFileContents("new/p/Enum.aidl",
2267 "package p;"
2268 "enum Enum {"
2269 " BAR = 2,"
2270 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002271 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002272 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002273 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002274}
2275
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002276TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2277 const string expected_stderr =
2278 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2279 io_delegate_.SetFileContents("old/p/Union.aidl",
2280 "package p;"
2281 "union Union {"
2282 " String str;"
2283 " int num;"
2284 "}");
2285 io_delegate_.SetFileContents("new/p/Union.aidl",
2286 "package p;"
2287 "union Union {"
2288 " String str;"
2289 "}");
2290 CaptureStderr();
2291 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2292 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2293}
2294
Daniel Norman85aed542019-08-21 12:01:14 -07002295TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002296 const string expected_stderr =
2297 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002298 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2299 "package p;"
2300 "interface IFoo {"
2301 " void foo(in String[] str);"
2302 " void bar(@utf8InCpp String str);"
2303 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002304 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2305 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002306 "interface IFoo {"
2307 " void foo(in String[] str);"
2308 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002309 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002310 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002311 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002312 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002313}
2314
Daniel Norman85aed542019-08-21 12:01:14 -07002315TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002316 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002317 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2318 "package p;"
2319 "interface IFoo {"
2320 " void foo(in String[] str);"
2321 " void bar(@utf8InCpp String str);"
2322 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002323 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2324 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002325 "interface IFoo2 {"
2326 " void foo(in String[] str);"
2327 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002328 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002329 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002330 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002331 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002332}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002333
Daniel Norman85aed542019-08-21 12:01:14 -07002334TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002335 const string expected_stderr =
2336 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002337 io_delegate_.SetFileContents("old/p/Enum.aidl",
2338 "package p;"
2339 "enum Enum {"
2340 " FOO = 1,"
2341 " BAR = 2,"
2342 "}");
2343 io_delegate_.SetFileContents("new/p/Enum.aidl",
2344 "package p;"
2345 "enum Enum {"
2346 " FOO = 3,"
2347 " BAR = 2,"
2348 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002349 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002350 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002351 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002352}
2353
2354TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002355 const string expected_stderr =
2356 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2357 "from 0 to 1.\n"
2358 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2359 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002360 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2361 "package p;"
2362 "interface IFoo {"
2363 " void foo(in String[] str);"
2364 " void bar(@utf8InCpp String str);"
2365 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002366 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2367 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002368 "interface IFoo {"
2369 " void bar(@utf8InCpp String str);"
2370 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002371 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002372 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002373 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002374 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002375}
2376
2377TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002378 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002379 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2380 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002381 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002382 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002383 "parcelable Data {"
2384 " int foo;"
2385 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002386 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002387 io_delegate_.SetFileContents("new/p/Data.aidl",
2388 "package p;"
2389 "parcelable Data {"
2390 " int bar;"
2391 " int foo;"
2392 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002393 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002394 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002395 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002396}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002397
Daniel Norman85aed542019-08-21 12:01:14 -07002398TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002399 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002400 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002401 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002402 "interface IFoo {"
2403 " void foo(in String[] str);"
2404 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002405 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002406 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2407 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002408 "interface IFoo {"
2409 " void foo(out String[] str);"
2410 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002411 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002412 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002413 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002414 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002415}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002416
Daniel Norman85aed542019-08-21 12:01:14 -07002417TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002418 const string expected_stderr =
2419 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002420 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2421 "package p;"
2422 "interface IFoo {"
2423 " void foo(in String[] str);"
2424 " void bar(@utf8InCpp String str);"
2425 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002426 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2427 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002428 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002429 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002430 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002431 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002432 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002433 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002434 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002435}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002436
Daniel Norman85aed542019-08-21 12:01:14 -07002437TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002438 const string expected_stderr =
2439 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002440 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2441 "package p;"
2442 "interface IFoo {"
2443 " void foo(in String[] str);"
2444 " void bar(@utf8InCpp String str);"
2445 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002446 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2447 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002448 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002449 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002450 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002451 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002452 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002453 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002454 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002455}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002456
Jooyung Han60b2fde2020-10-29 15:12:40 +09002457TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2458 const string expected_stderr =
2459 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2460 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2461 io_delegate_.SetFileContents("old/p/Foo.aidl",
2462 "package p;"
2463 "@Backing(type=\"byte\")"
2464 "enum Foo {"
2465 " FOO, BAR,"
2466 "}");
2467 io_delegate_.SetFileContents("new/p/Foo.aidl",
2468 "package p;"
2469 "@Backing(type=\"long\")"
2470 "enum Foo {"
2471 " FOO, BAR,"
2472 "}");
2473 CaptureStderr();
2474 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2475 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2476}
2477
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002478TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2479 const string expected_stderr =
2480 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2481 "to @JavaPassthrough(annotation=\"Bob\")\n";
2482 io_delegate_.SetFileContents("old/p/Foo.aidl",
2483 "package p;"
2484 "@JavaPassthrough(annotation=\"Alice\")"
2485 "parcelable Foo {}");
2486 io_delegate_.SetFileContents("new/p/Foo.aidl",
2487 "package p;"
2488 "@JavaPassthrough(annotation=\"Bob\")"
2489 "parcelable Foo {}");
2490
2491 CaptureStderr();
2492 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2493 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2494}
2495
Devin Mooredb7ac512020-08-07 11:17:36 -07002496TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2497 const string expected_stderr =
2498 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2499 io_delegate_.SetFileContents("old/p/Foo.aidl",
2500 "package p;"
2501 "parcelable Foo {"
2502 " int A;"
2503 "}");
2504 io_delegate_.SetFileContents("new/p/Foo.aidl",
2505 "package p;"
2506 "@JavaOnlyStableParcelable parcelable Foo {"
2507 " int A;"
2508 "}");
2509 CaptureStderr();
2510 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2511 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2512}
2513
2514TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2515 const string expected_stderr =
2516 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2517 io_delegate_.SetFileContents("old/p/Foo.aidl",
2518 "package p;"
2519 "@JavaOnlyStableParcelable parcelable Foo {"
2520 " int A;"
2521 "}");
2522 io_delegate_.SetFileContents("new/p/Foo.aidl",
2523 "package p;"
2524 "parcelable Foo {"
2525 " int A;"
2526 "}");
2527 CaptureStderr();
2528 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2529 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2530}
2531
Daniel Norman85aed542019-08-21 12:01:14 -07002532TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002533 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002534 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2535 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002536 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002537 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002538 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002539 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002540}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002541
Daniel Norman85aed542019-08-21 12:01:14 -07002542TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002543 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002544 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2545 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002546 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002547 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002548 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002549}
Jiyong Parka428d212018-08-29 22:26:30 +09002550
Daniel Norman85aed542019-08-21 12:01:14 -07002551TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002552 const string expected_stderr =
2553 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002554 io_delegate_.SetFileContents("old/p/I.aidl",
2555 "package p; interface I {"
2556 "const int A = 1; const int B = 2;}");
2557 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002558 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002559 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002560 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002561}
Jiyong Parka428d212018-08-29 22:26:30 +09002562
Daniel Norman85aed542019-08-21 12:01:14 -07002563TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002564 const string expected_stderr =
2565 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002566 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2567 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002568 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002569 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002570 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002571}
2572
Devin Moorec7e47a32020-08-07 10:55:25 -07002573TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2574 const string expected_stderr =
2575 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2576 "This is an incompatible change for FixedSize types.\n";
2577 io_delegate_.SetFileContents("old/p/Foo.aidl",
2578 "package p; @FixedSize parcelable Foo { int A = 1; }");
2579 io_delegate_.SetFileContents("new/p/Foo.aidl",
2580 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2581 CaptureStderr();
2582 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2583 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2584}
2585
2586TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2587 const string expected_stderr =
2588 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2589 io_delegate_.SetFileContents("old/p/Foo.aidl",
2590 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2591 io_delegate_.SetFileContents("new/p/Foo.aidl",
2592 "package p; @FixedSize parcelable Foo { int A = 1; }");
2593 CaptureStderr();
2594 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2595 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2596}
2597
2598TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2599 const string expected_stderr =
2600 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2601 "a.\n"
2602 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2603 "b.\n"
2604 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2605 "c.\n"
2606 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2607 "d.\n"
2608 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2609 "e.\n"
2610 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2611 "f.\n";
2612
2613 io_delegate_.SetFileContents("Foo.aidl",
2614 "@FixedSize parcelable Foo { "
2615 " int[] a;"
2616 " Bar b;"
2617 " String c;"
2618 " ParcelFileDescriptor d;"
2619 " IBinder e;"
2620 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002621 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002622 "}");
2623 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2624 Options options =
2625 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2626
2627 CaptureStderr();
2628 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2629 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2630}
2631
2632TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2633 const string expected_stderr = "";
2634
2635 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2636 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2637 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2638 Options options =
2639 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2640
2641 CaptureStderr();
2642 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2643 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2644}
2645
Jiyong Park8c380532018-08-30 14:55:26 +09002646TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002647 const string expected_stderr =
2648 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2649 "dir1/q/IBar.aidl\n"
2650 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002651 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002652 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2653 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2654 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2655 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2656
Devin Moore097a3ab2020-03-11 16:08:44 -07002657 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002658 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002659 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002660}
2661
Jiyong Parked65bf42018-08-28 15:43:27 +09002662TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002663 const string expected_stderr =
2664 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2665 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002666 Options options = Options::From("aidl --checkapi old new");
2667 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2668 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002669
2670 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2671
Jiyong Parke59c3682018-09-11 23:10:25 +09002672 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002673 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002674 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002675 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002676}
2677
Jiyong Parke05195e2018-10-08 18:24:23 +09002678TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2679 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2680 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002681 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002682
2683 // use without import
2684 io_delegate_.SetFileContents("p/IFoo.aidl",
2685 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2686 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2687 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002688 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002689
Devin Moore7b8d5c92020-03-17 14:14:08 -07002690 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002691 io_delegate_.SetFileContents(
2692 "p/IFoo.aidl",
2693 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2694 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2695 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002696 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002697
2698 // use with import (as before)
2699 io_delegate_.SetFileContents("p/IFoo.aidl",
2700 "package p;"
2701 "import android.os.ParcelFileDescriptor;"
2702 "interface IFoo{"
2703 " void foo(in ParcelFileDescriptor fd);"
2704 "}");
2705 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2706 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002707 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002708}
Jiyong Parked65bf42018-08-28 15:43:27 +09002709
Jiyong Park3633b722019-04-11 15:38:26 +09002710TEST_F(AidlTest, ManualIds) {
2711 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2712 io_delegate_.SetFileContents("IFoo.aidl",
2713 "interface IFoo {\n"
2714 " void foo() = 0;\n"
2715 " void bar() = 1;\n"
2716 "}");
2717 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2718}
2719
2720TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2721 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2722 io_delegate_.SetFileContents("IFoo.aidl",
2723 "interface IFoo {\n"
2724 " void foo() = 0;\n"
2725 " void bar() = 1;\n"
2726 "}");
2727 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2728}
2729
2730TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002731 const string expected_stderr =
2732 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002733 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2734 io_delegate_.SetFileContents("IFoo.aidl",
2735 "interface IFoo {\n"
2736 " void foo() = 3;\n"
2737 " void bar() = 3;\n"
2738 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002739 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002740 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002741 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002742}
2743
2744TEST_F(AidlTest, FailOnOutOfRangeIds) {
2745 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002746 const string expected_stderr =
2747 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2748 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002749 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2750 io_delegate_.SetFileContents("IFoo.aidl",
2751 "interface IFoo {\n"
2752 " void foo() = 3;\n"
2753 " void bar() = 16777115;\n"
2754 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002755 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002756 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002757 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002758}
2759
2760TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002761 const string expected_stderr =
2762 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002763 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2764 io_delegate_.SetFileContents("IFoo.aidl",
2765 "interface IFoo {\n"
2766 " void foo() = 3;\n"
2767 " void bar();\n"
2768 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002769 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002770 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002771 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002772}
2773
Jiyong Parkc6816252019-07-08 08:12:28 +09002774TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2775 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2776 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2777 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2778 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2779}
2780
2781TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002782 const string expected_stderr =
2783 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2784 "dir/IBar.aidl\n"
2785 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002786 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002787
Jiyong Parkc6816252019-07-08 08:12:28 +09002788 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2789 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2790 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2791 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002792 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002793 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002794 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002795}
2796
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002797TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2798 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2799 "package a.b;\n"
2800 "import a.b.IBar;\n"
2801 "import a.b.IQux;\n"
2802 "interface IFoo { IQux foo(); }\n");
2803 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2804 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2805
2806 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2807 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2808
2809 string output;
2810 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2811 // IBar was imported but wasn't used. include is not expected.
2812 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2813 // IBar was imported and used. include is expected.
2814 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2815}
2816
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002817TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002818 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002819 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002820 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2821 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002822 interface IFoo {
2823 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002824 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002825 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002826 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002827 // JavaPassthrough should work with other types as well (e.g. enum)
2828 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2829 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2830 @JavaPassthrough(annotation="@com.android.AliceTwo")
2831 @Backing(type="byte")
2832 enum MyEnum {
2833 a, b, c
2834 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002835
Jooyung Han4cde01d2020-10-13 11:10:47 +09002836 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002837 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2838
2839 string java_out;
2840 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002841 // type-decl-level annotations with newline at the end
2842 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2843 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2844 // member-decl-level annotations with newline at the end
2845 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2846 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2847 // inline annotations with space at the end
2848 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002849
Jooyung Han4cde01d2020-10-13 11:10:47 +09002850 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2851 // type-decl-level annotations with newline at the end
2852 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2853 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2854
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002855 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002856 Options cpp_options =
2857 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002858 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2859
Jooyung Han4cde01d2020-10-13 11:10:47 +09002860 Options ndk_options =
2861 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002862 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002863
Jooyung Han4cde01d2020-10-13 11:10:47 +09002864 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002865 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002866}
2867
Andrei Homescue61feb52020-08-18 15:44:24 -07002868TEST_F(AidlTest, ParseRustDerive) {
2869 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2870 @RustDerive(Clone=true, Copy=false)
2871 parcelable Foo {
2872 int a;
2873 })");
2874
2875 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2876 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2877
2878 string rust_out;
2879 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2880 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2881
2882 // Other backends shouldn't be bothered
2883 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2884 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2885
2886 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2887 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2888
2889 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2890 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2891}
2892
Jiyong Park56f73d72019-06-11 12:20:28 +09002893class AidlOutputPathTest : public AidlTest {
2894 protected:
2895 void SetUp() override {
2896 AidlTest::SetUp();
2897 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2898 }
2899
2900 void Test(const Options& options, const std::string expected_output_path) {
2901 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2902 // check the existence
2903 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2904 }
2905};
2906
2907TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2908 // <out_dir> / <package_name> / <type_name>.java
2909 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2910}
2911
2912TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2913 // when output file is explicitly set, it is always respected. -o option is
2914 // ignored.
2915 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2916}
2917
2918TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2919 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2920}
2921
2922TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2923 // output is the same as the input file except for the suffix
2924 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2925}
2926
Devin Moore7b8d5c92020-03-17 14:14:08 -07002927TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002928 AidlError error;
2929 const string expected_stderr =
2930 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2931 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002932 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2933 R"(package p;
2934 interface IFoo {
2935 const int int32_max_oob = 2147483650;
2936 }
2937 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002938 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002939 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2940 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002941}
2942
Devin Moore7b8d5c92020-03-17 14:14:08 -07002943TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002944 AidlError error;
2945 const string expected_stderr =
2946 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2947 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002948 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2949 R"(package p;
2950 interface IFoo {
2951 const int int32_min_oob = -2147483650;
2952 }
2953 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002954 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002955 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2956 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002957}
2958
Devin Moore7b8d5c92020-03-17 14:14:08 -07002959TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002960 AidlError error;
2961 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002962 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002963 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002964 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2965 R"(package p;
2966 interface IFoo {
2967 const long int64_max_oob = 21474836509999999999999999;
2968 }
2969 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002970 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002971 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2972 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002973}
2974
Devin Moore7b8d5c92020-03-17 14:14:08 -07002975TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002976 AidlError error;
2977 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002978 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002979 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002980 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2981 R"(package p;
2982 interface IFoo {
2983 const long int64_min_oob = -21474836509999999999999999;
2984 }
2985 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002986 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002987 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2988 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002989}
2990
Devin Moore7b8d5c92020-03-17 14:14:08 -07002991TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002992 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002993 const string expected_stderr =
2994 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2995 "literal: byte\n"
2996 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2997 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002998 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2999 R"(package p;
3000 @Backing(type="byte")
3001 enum TestEnum {
3002 FOO = 127,
3003 BAR,
3004 }
3005 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003006 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003007 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003008 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003009}
3010
Devin Mooredecaf292020-04-30 09:16:40 -07003011TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3012 AidlError error;
3013 const string expected_stderr =
3014 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
3015 "be one of: type\n"
3016 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
3017 "be one of: type\n";
3018 CaptureStderr();
3019 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3020 R"(package p;
3021 @Backing(foo="byte")
3022 enum TestEnum {
3023 FOO = 1,
3024 BAR,
3025 }
3026 )",
3027 typenames_, GetLanguage(), &error));
3028 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3029 EXPECT_EQ(AidlError::BAD_TYPE, error);
3030}
3031
Jooyung Han66813932020-10-23 13:24:44 +09003032TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003033 io_delegate_.SetFileContents("Foo.aidl",
3034 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3035 "Map<String, Baz> d; Bar[] e; }");
3036 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3037 io_delegate_.SetFileContents("Baz.aidl",
3038 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003039 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3040 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3041}
3042
Jooyung Han66813932020-10-23 13:24:44 +09003043TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003044 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003045 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003046 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003047 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3048 "named 'bar'.\n";
3049 CaptureStderr();
3050 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3051 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3052 EXPECT_EQ(expected_error, GetCapturedStderr());
3053}
3054
3055TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3056 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3057 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3058 string expected_error =
3059 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003060 "named 'bar'.\n";
3061 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003062 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3063 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003064 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003065}
3066
Jooyung Han66813932020-10-23 13:24:44 +09003067TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003068 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003069 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3070 string expected_error =
3071 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3072 "only be an in parameter.\n";
3073 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003074 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3075 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003076 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003077}
3078
Jooyung Han66813932020-10-23 13:24:44 +09003079TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003080 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003081 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3082 string expected_error =
3083 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3084 "only be an in parameter.\n";
3085 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003086 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3087 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003088 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003089}
3090
Jooyung Han66813932020-10-23 13:24:44 +09003091TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003092 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003093 Options options = Options::From("aidl --lang=java Foo.aidl");
3094 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003095 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3096 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003097 CaptureStderr();
3098 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3099 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3100}
Devin Moore53fc99c2020-08-12 08:07:52 -07003101
Jooyung Han1f14ab32020-10-14 13:48:29 +09003102const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3103
3104#include <a/ByteEnum.h>
3105#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003106#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003107#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003108#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003109#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003110#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003111#include <locale>
3112#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003113#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003114#include <utility>
3115#include <variant>
3116#include <vector>
3117
Jooyung Handf39e192020-11-23 15:59:46 +09003118#ifndef __BIONIC__
3119#define __assert2(a,b,c,d) ((void)0)
3120#endif
3121
Jooyung Han1f14ab32020-10-14 13:48:29 +09003122namespace a {
3123
3124class Foo : public ::android::Parcelable {
3125public:
Jooyung Han97945de2020-10-15 16:41:38 +09003126 inline bool operator!=(const Foo& rhs) const {
3127 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003128 }
Jooyung Han97945de2020-10-15 16:41:38 +09003129 inline bool operator<(const Foo& rhs) const {
3130 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003131 }
Jooyung Han97945de2020-10-15 16:41:38 +09003132 inline bool operator<=(const Foo& rhs) const {
3133 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003134 }
Jooyung Han97945de2020-10-15 16:41:38 +09003135 inline bool operator==(const Foo& rhs) const {
3136 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003137 }
Jooyung Han97945de2020-10-15 16:41:38 +09003138 inline bool operator>(const Foo& rhs) const {
3139 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003140 }
Jooyung Han97945de2020-10-15 16:41:38 +09003141 inline bool operator>=(const Foo& rhs) const {
3142 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003143 }
Jooyung Han97945de2020-10-15 16:41:38 +09003144
Jooyung Han1f14ab32020-10-14 13:48:29 +09003145 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003146 ns = 0, // int[] ns;
3147 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003148 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003149 };
Jooyung Han97945de2020-10-15 16:41:38 +09003150
Jooyung Han1f14ab32020-10-14 13:48:29 +09003151 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003152 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003153
3154 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003155 Foo(const Foo&) = default;
3156 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003157 Foo& operator=(const Foo&) = default;
3158 Foo& operator=(Foo&&) = default;
3159
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003160 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3161 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003162 constexpr Foo(_Tp&& _arg)
3163 : _value(std::forward<_Tp>(_arg)) {}
3164
3165 template <typename... _Tp>
3166 constexpr explicit Foo(_Tp&&... _args)
3167 : _value(std::forward<_Tp>(_args)...) {}
3168
3169 template <Tag _tag, typename... _Tp>
3170 static Foo make(_Tp&&... _args) {
3171 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003172 }
Jooyung Han97945de2020-10-15 16:41:38 +09003173
3174 template <Tag _tag, typename _Tp, typename... _Up>
3175 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3176 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003177 }
3178
3179 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003180 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003181 }
3182
Jooyung Han97945de2020-10-15 16:41:38 +09003183 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003184 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003185 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003186 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003187 }
3188
Jooyung Han97945de2020-10-15 16:41:38 +09003189 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003190 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003191 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003192 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003193 }
3194
Jooyung Han97945de2020-10-15 16:41:38 +09003195 template <Tag _tag, typename... _Tp>
3196 void set(_Tp&&... _args) {
3197 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003198 }
3199
3200 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3201 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3202 static const std::string& getParcelableDescriptor() {
3203 static const std::string DESCIPTOR = "a.Foo";
3204 return DESCIPTOR;
3205 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003206 template <typename _T> class _has_toString {
3207 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3208 template <typename _U> static std::false_type __has_toString(...);
3209 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3210 };
3211 template <typename _T> inline static std::string _call_toString(const _T& t) {
3212 if constexpr (_has_toString<_T>::value) return t.toString();
3213 return "{no toString() implemented}";
3214 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003215 inline std::string toString() const {
3216 std::ostringstream os;
3217 os << "Foo{";
3218 switch (getTag()) {
3219 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3220 case e: os << "e: " << a::toString(get<e>()); break;
3221 case pfd: os << "pfd: " << ""; break;
3222 }
3223 os << "}";
3224 return os.str();
3225 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003226private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003227 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003228}; // class Foo
3229
3230} // namespace a
3231)";
3232
3233const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3234
3235namespace a {
3236
3237::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3238 ::android::status_t _aidl_ret_status;
3239 int32_t _aidl_tag;
3240 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3241 switch (_aidl_tag) {
3242 case ns: {
3243 ::std::vector<int32_t> _aidl_value;
3244 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003245 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3246 set<ns>(_aidl_value);
3247 } else {
3248 // NOLINTNEXTLINE(performance-move-const-arg)
3249 set<ns>(std::move(_aidl_value));
3250 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003251 return ::android::OK; }
3252 case e: {
3253 ::a::ByteEnum _aidl_value;
3254 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003255 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3256 set<e>(_aidl_value);
3257 } else {
3258 // NOLINTNEXTLINE(performance-move-const-arg)
3259 set<e>(std::move(_aidl_value));
3260 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003261 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003262 case pfd: {
3263 ::android::os::ParcelFileDescriptor _aidl_value;
3264 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003265 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3266 set<pfd>(_aidl_value);
3267 } else {
3268 // NOLINTNEXTLINE(performance-move-const-arg)
3269 set<pfd>(std::move(_aidl_value));
3270 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003271 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003272 }
3273 return ::android::BAD_VALUE;
3274}
3275
3276::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3277 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3278 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3279 switch (getTag()) {
3280 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3281 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003282 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003283 }
Jooyung Handf39e192020-11-23 15:59:46 +09003284 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003285}
3286
3287} // namespace a
3288)";
3289
Jooyung Han6beac042020-10-17 21:59:43 +09003290const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3291#include <android/binder_interface_utils.h>
3292#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003293#include <codecvt>
3294#include <locale>
3295#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003296
Jooyung Handf39e192020-11-23 15:59:46 +09003297#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003298#include <type_traits>
3299#include <utility>
3300#include <variant>
3301#include <cstdint>
3302#include <memory>
3303#include <optional>
3304#include <string>
3305#include <vector>
3306#ifdef BINDER_STABILITY_SUPPORT
3307#include <android/binder_stability.h>
3308#endif // BINDER_STABILITY_SUPPORT
3309#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003310
3311#ifndef __BIONIC__
3312#define __assert2(a,b,c,d) ((void)0)
3313#endif
3314
Jooyung Han6beac042020-10-17 21:59:43 +09003315namespace aidl {
3316namespace a {
3317class Foo {
3318public:
3319 typedef std::false_type fixed_size;
3320 static const char* descriptor;
3321
3322 enum Tag : int32_t {
3323 ns = 0, // int[] ns;
3324 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003325 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003326 };
3327
3328 template<typename _Tp>
3329 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3330
3331 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3332 Foo(const Foo&) = default;
3333 Foo(Foo&&) = default;
3334 Foo& operator=(const Foo&) = default;
3335 Foo& operator=(Foo&&) = default;
3336
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003337 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3338 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003339 constexpr Foo(_Tp&& _arg)
3340 : _value(std::forward<_Tp>(_arg)) {}
3341
3342 template <typename... _Tp>
3343 constexpr explicit Foo(_Tp&&... _args)
3344 : _value(std::forward<_Tp>(_args)...) {}
3345
3346 template <Tag _tag, typename... _Tp>
3347 static Foo make(_Tp&&... _args) {
3348 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3349 }
3350
3351 template <Tag _tag, typename _Tp, typename... _Up>
3352 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3353 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3354 }
3355
3356 Tag getTag() const {
3357 return static_cast<Tag>(_value.index());
3358 }
3359
3360 template <Tag _tag>
3361 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003362 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003363 return std::get<_tag>(_value);
3364 }
3365
3366 template <Tag _tag>
3367 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003368 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003369 return std::get<_tag>(_value);
3370 }
3371
3372 template <Tag _tag, typename... _Tp>
3373 void set(_Tp&&... _args) {
3374 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3375 }
3376
3377 binder_status_t readFromParcel(const AParcel* _parcel);
3378 binder_status_t writeToParcel(AParcel* _parcel) const;
3379 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003380 template <typename _T> class _has_toString {
3381 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3382 template <typename _U> static std::false_type __has_toString(...);
3383 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3384 };
3385 template <typename _T> inline static std::string _call_toString(const _T& t) {
3386 if constexpr (_has_toString<_T>::value) return t.toString();
3387 return "{no toString() implemented}";
3388 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003389 inline std::string toString() const {
3390 std::ostringstream os;
3391 os << "Foo{";
3392 switch (getTag()) {
3393 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3394 case e: os << "e: " << a::toString(get<e>()); break;
3395 case pfd: os << "pfd: " << ""; break;
3396 }
3397 os << "}";
3398 return os.str();
3399 }
Jooyung Han6beac042020-10-17 21:59:43 +09003400private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003401 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003402};
3403} // namespace a
3404} // namespace aidl
3405)";
3406
3407const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3408
3409#include <android/binder_parcel_utils.h>
3410
3411namespace aidl {
3412namespace a {
3413const char* Foo::descriptor = "a.Foo";
3414
3415binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3416 binder_status_t _aidl_ret_status;
3417 int32_t _aidl_tag;
3418 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3419 switch (_aidl_tag) {
3420 case ns: {
3421 std::vector<int32_t> _aidl_value;
3422 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003423 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3424 set<ns>(_aidl_value);
3425 } else {
3426 // NOLINTNEXTLINE(performance-move-const-arg)
3427 set<ns>(std::move(_aidl_value));
3428 }
Jooyung Han6beac042020-10-17 21:59:43 +09003429 return STATUS_OK; }
3430 case e: {
3431 ::aidl::a::ByteEnum _aidl_value;
3432 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003433 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3434 set<e>(_aidl_value);
3435 } else {
3436 // NOLINTNEXTLINE(performance-move-const-arg)
3437 set<e>(std::move(_aidl_value));
3438 }
Jooyung Han6beac042020-10-17 21:59:43 +09003439 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003440 case pfd: {
3441 ::ndk::ScopedFileDescriptor _aidl_value;
3442 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003443 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3444 set<pfd>(_aidl_value);
3445 } else {
3446 // NOLINTNEXTLINE(performance-move-const-arg)
3447 set<pfd>(std::move(_aidl_value));
3448 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003449 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003450 }
3451 return STATUS_BAD_VALUE;
3452}
3453binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3454 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3455 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3456 switch (getTag()) {
3457 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3458 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003459 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003460 }
Jooyung Handf39e192020-11-23 15:59:46 +09003461 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003462}
3463
3464} // namespace a
3465} // namespace aidl
3466)";
3467
Jooyung Han1f14ab32020-10-14 13:48:29 +09003468const char kUnionExampleExpectedOutputJava[] = R"(/*
3469 * This file is auto-generated. DO NOT MODIFY.
3470 */
3471package a;
3472
3473
3474public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003475 // tags for union fields
3476 public final static int ns = 0; // int[] ns;
3477 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003478 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003479
3480 private int _tag;
3481 private Object _value;
3482
3483 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003484 int[] _value = {42};
3485 this._tag = ns;
3486 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003487 }
Jooyung Han97945de2020-10-15 16:41:38 +09003488
Jooyung Han1f14ab32020-10-14 13:48:29 +09003489 private Foo(android.os.Parcel _aidl_parcel) {
3490 readFromParcel(_aidl_parcel);
3491 }
Jooyung Han97945de2020-10-15 16:41:38 +09003492
Jooyung Hance62f932020-10-25 10:21:49 +09003493 private Foo(int _tag, Object _value) {
3494 this._tag = _tag;
3495 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003496 }
3497
3498 public int getTag() {
3499 return _tag;
3500 }
3501
Jooyung Han97945de2020-10-15 16:41:38 +09003502 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003503
3504 public static Foo ns(int[] _value) {
3505 return new Foo(ns, _value);
3506 }
Jooyung Han97945de2020-10-15 16:41:38 +09003507
Jooyung Han1f14ab32020-10-14 13:48:29 +09003508 public int[] getNs() {
3509 _assertTag(ns);
3510 return (int[]) _value;
3511 }
Jooyung Han97945de2020-10-15 16:41:38 +09003512
Jooyung Han1f14ab32020-10-14 13:48:29 +09003513 public void setNs(int[] _value) {
3514 _set(ns, _value);
3515 }
3516
Jooyung Han97945de2020-10-15 16:41:38 +09003517 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003518
3519 public static Foo e(byte _value) {
3520 return new Foo(e, _value);
3521 }
Jooyung Han97945de2020-10-15 16:41:38 +09003522
Jooyung Han1f14ab32020-10-14 13:48:29 +09003523 public byte getE() {
3524 _assertTag(e);
3525 return (byte) _value;
3526 }
Jooyung Han97945de2020-10-15 16:41:38 +09003527
Jooyung Han1f14ab32020-10-14 13:48:29 +09003528 public void setE(byte _value) {
3529 _set(e, _value);
3530 }
3531
Jooyung Hand2fa0232020-10-19 02:51:41 +09003532 // ParcelFileDescriptor pfd;
3533
3534 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3535 return new Foo(pfd, _value);
3536 }
3537
3538 public android.os.ParcelFileDescriptor getPfd() {
3539 _assertTag(pfd);
3540 return (android.os.ParcelFileDescriptor) _value;
3541 }
3542
3543 public void setPfd(android.os.ParcelFileDescriptor _value) {
3544 _set(pfd, _value);
3545 }
3546
Jooyung Han1f14ab32020-10-14 13:48:29 +09003547 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3548 @Override
3549 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003550 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003551 }
3552 @Override
3553 public Foo[] newArray(int _aidl_size) {
3554 return new Foo[_aidl_size];
3555 }
3556 };
Jooyung Han97945de2020-10-15 16:41:38 +09003557
Jooyung Han1f14ab32020-10-14 13:48:29 +09003558 @Override
3559 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3560 _aidl_parcel.writeInt(_tag);
3561 switch (_tag) {
3562 case ns:
3563 _aidl_parcel.writeIntArray(getNs());
3564 break;
3565 case e:
3566 _aidl_parcel.writeByte(getE());
3567 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003568 case pfd:
3569 if ((getPfd()!=null)) {
3570 _aidl_parcel.writeInt(1);
3571 getPfd().writeToParcel(_aidl_parcel, 0);
3572 }
3573 else {
3574 _aidl_parcel.writeInt(0);
3575 }
3576 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003577 }
3578 }
Jooyung Han97945de2020-10-15 16:41:38 +09003579
Jooyung Han1f14ab32020-10-14 13:48:29 +09003580 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3581 int _aidl_tag;
3582 _aidl_tag = _aidl_parcel.readInt();
3583 switch (_aidl_tag) {
3584 case ns: {
3585 int[] _aidl_value;
3586 _aidl_value = _aidl_parcel.createIntArray();
3587 _set(_aidl_tag, _aidl_value);
3588 return; }
3589 case e: {
3590 byte _aidl_value;
3591 _aidl_value = _aidl_parcel.readByte();
3592 _set(_aidl_tag, _aidl_value);
3593 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003594 case pfd: {
3595 android.os.ParcelFileDescriptor _aidl_value;
3596 if ((0!=_aidl_parcel.readInt())) {
3597 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3598 }
3599 else {
3600 _aidl_value = null;
3601 }
3602 _set(_aidl_tag, _aidl_value);
3603 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003604 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003605 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003606 }
Jooyung Han97945de2020-10-15 16:41:38 +09003607
Jooyung Han1f14ab32020-10-14 13:48:29 +09003608 @Override
3609 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003610 int _mask = 0;
3611 switch (getTag()) {
3612 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003613 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003614 break;
3615 }
3616 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003617 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003618 private int describeContents(Object _v) {
3619 if (_v == null) return 0;
3620 if (_v instanceof android.os.Parcelable) {
3621 return ((android.os.Parcelable) _v).describeContents();
3622 }
3623 return 0;
3624 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003625
3626 private void _assertTag(int tag) {
3627 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003628 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003629 }
3630 }
Jooyung Han97945de2020-10-15 16:41:38 +09003631
Jooyung Han1f14ab32020-10-14 13:48:29 +09003632 private String _tagString(int _tag) {
3633 switch (_tag) {
3634 case ns: return "ns";
3635 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003636 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003637 }
3638 throw new IllegalStateException("unknown field: " + _tag);
3639 }
Jooyung Han97945de2020-10-15 16:41:38 +09003640
Jooyung Hance62f932020-10-25 10:21:49 +09003641 private void _set(int _tag, Object _value) {
3642 this._tag = _tag;
3643 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003644 }
3645}
3646)";
3647
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003648const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3649pub enum Foo {
3650 Ns(Vec<i32>),
3651 E(crate::mangled::_1_a_8_ByteEnum),
3652 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3653}
3654pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3655impl Default for Foo {
3656 fn default() -> Self {
3657 Self::Ns(vec!{42})
3658 }
3659}
3660impl binder::parcel::Serialize for Foo {
3661 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3662 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3663 }
3664}
3665impl binder::parcel::SerializeArray for Foo {}
3666impl binder::parcel::SerializeOption for Foo {
3667 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3668 let this = if let Some(this) = this {
3669 parcel.write(&1i32)?;
3670 this
3671 } else {
3672 return parcel.write(&0i32);
3673 };
3674 match this {
3675 Self::Ns(v) => {
3676 parcel.write(&0i32)?;
3677 parcel.write(v)
3678 }
3679 Self::E(v) => {
3680 parcel.write(&1i32)?;
3681 parcel.write(v)
3682 }
3683 Self::Pfd(v) => {
3684 parcel.write(&2i32)?;
3685 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3686 parcel.write(__field_ref)
3687 }
3688 }
3689 }
3690}
3691impl binder::parcel::Deserialize for Foo {
3692 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3693 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3694 .transpose()
3695 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3696 }
3697}
3698impl binder::parcel::DeserializeArray for Foo {}
3699impl binder::parcel::DeserializeOption for Foo {
3700 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3701 let status: i32 = parcel.read()?;
3702 if status == 0 { return Ok(None); }
3703 let tag: i32 = parcel.read()?;
3704 match tag {
3705 0 => {
3706 let value: Vec<i32> = parcel.read()?;
3707 Ok(Some(Self::Ns(value)))
3708 }
3709 1 => {
3710 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3711 Ok(Some(Self::E(value)))
3712 }
3713 2 => {
3714 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3715 Ok(Some(Self::Pfd(value)))
3716 }
3717 _ => {
3718 Err(binder::StatusCode::BAD_VALUE)
3719 }
3720 }
3721 }
3722}
3723)";
3724
Jooyung Han97945de2020-10-15 16:41:38 +09003725struct AidlUnionTest : ::testing::Test {
3726 void SetUp() override {
3727 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003728package a;
3729import a.ByteEnum;
3730union Foo {
3731 int[] ns = {42};
3732 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003733 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003734}
3735)");
Jooyung Han97945de2020-10-15 16:41:38 +09003736 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003737package a;
3738@Backing(type="byte")
3739enum ByteEnum {
3740 a, b, c
3741}
3742)");
Jooyung Han97945de2020-10-15 16:41:38 +09003743 }
3744 FakeIoDelegate io_delegate_;
3745 void Compile(string lang) {
3746 string command = "aidl --structured -I. -o out --lang=" + lang;
3747 if (lang == "cpp" || lang == "ndk") {
3748 command += " -h out";
3749 }
3750 command += " a/Foo.aidl";
3751 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003752 CaptureStderr();
3753 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3754 auto err = GetCapturedStderr();
3755 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003756 }
3757 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3758 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003759 string actual;
3760 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3761 EXPECT_EQ(expected, actual);
3762 }
Jooyung Han97945de2020-10-15 16:41:38 +09003763 }
3764};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003765
Jooyung Han97945de2020-10-15 16:41:38 +09003766TEST_F(AidlUnionTest, Example_Cpp) {
3767 Compile("cpp");
3768 EXPECT_COMPILE_OUTPUTS(
3769 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3770 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3771}
3772
Jooyung Han6beac042020-10-17 21:59:43 +09003773TEST_F(AidlUnionTest, Example_Ndk) {
3774 Compile("ndk");
3775 EXPECT_COMPILE_OUTPUTS(
3776 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3777 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3778}
3779
Jooyung Han97945de2020-10-15 16:41:38 +09003780TEST_F(AidlUnionTest, Example_Java) {
3781 Compile("java");
3782 EXPECT_COMPILE_OUTPUTS(
3783 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003784}
3785
3786TEST_F(AidlUnionTest, Example_Rust) {
3787 Compile("rust");
3788 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003789}
3790
Jooyung Hanfe89f122020-10-14 03:49:18 +09003791TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3792 const string method = "package a; union Foo {}";
3793 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3794 CaptureStderr();
3795 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3796 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3797}
3798
3799TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3800 const string method = "package a; union Foo { ParcelableHolder x; }";
3801 const string expected_stderr =
3802 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3803 CaptureStderr();
3804 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3805 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3806}
3807
Devin Moore53fc99c2020-08-12 08:07:52 -07003808TEST_P(AidlTest, GenericStructuredParcelable) {
3809 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3810 Options options =
3811 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3812 const string expected_stderr = "";
3813 CaptureStderr();
3814 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3815 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3816}
3817
Jooyung Han3f347ca2020-12-01 12:41:50 +09003818TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3819 io_delegate_.SetFileContents("Foo.aidl",
3820 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3821 Options options =
3822 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::CPP) +
3823 " -o out -h out");
3824 const string expected_stderr = "";
3825 CaptureStderr();
3826 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3827 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3828
3829 string code;
3830 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3831 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3832const ::android::String16& Foo<T,U>::s() {
3833 static const ::android::String16 value(::android::String16(""));
3834 return value;
3835})--"));
3836}
3837
3838TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3839 io_delegate_.SetFileContents("Foo.aidl",
3840 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3841 Options options =
3842 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::NDK) +
3843 " -o out -h out");
3844 const string expected_stderr = "";
3845 CaptureStderr();
3846 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3847 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3848
3849 string code;
3850 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3851 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3852const char* Foo<T, U>::s = "";
3853)--"));
3854}
3855
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003856TEST_F(AidlTest, NestedTypeArgs) {
3857 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003858 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3859
3860 io_delegate_.SetFileContents("a/Foo.aidl",
3861 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3862 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003863 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3864 const string expected_stderr = "";
3865 CaptureStderr();
3866 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3867 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3868
3869 string code;
3870 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003871 EXPECT_THAT(code,
3872 testing::HasSubstr(
3873 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3874}
3875
3876TEST_F(AidlTest, DoubleArrayError) {
3877 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3878
3879 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3880 const string expected_stderr =
3881 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3882 CaptureStderr();
3883 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3884 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3885}
3886
3887TEST_F(AidlTest, DoubleGenericError) {
3888 io_delegate_.SetFileContents("a/Bar.aidl",
3889 "package a; parcelable Bar { List<String><String> a; }");
3890
3891 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3892 const string expected_stderr =
3893 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3894 CaptureStderr();
3895 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3896 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3897}
3898
3899TEST_F(AidlTest, ArrayBeforeGenericError) {
3900 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3901
3902 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3903 const string expected_stderr =
3904 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3905 CaptureStderr();
3906 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3907 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003908}
3909
Jooyung Han14004ed2020-10-16 03:49:57 +09003910struct GenericAidlTest : ::testing::Test {
3911 FakeIoDelegate io_delegate_;
3912 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003913 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003914 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3915 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3916 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3917
3918 Options options = Options::From(cmd);
3919 CaptureStderr();
3920 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3921 EXPECT_EQ("", GetCapturedStderr());
3922 }
3923};
3924
3925TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3926 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3927 string code;
3928 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3929 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3930 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3931 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3932}
3933
3934TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3935 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3936 string code;
3937 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3938 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3939 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3940 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3941}
3942
Devin Moore53fc99c2020-08-12 08:07:52 -07003943TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3944 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3945 Options options =
3946 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3947 const string expected_stderr =
3948 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3949 CaptureStderr();
3950 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3951 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3952}
3953
3954TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3955 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3956 Options options =
3957 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3958 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3959 CaptureStderr();
3960 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3961 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3962}
3963
Jooyung Han7a308842020-10-27 19:06:49 +09003964TEST_P(AidlTest, LongCommentWithinConstExpression) {
3965 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
3966 Options options =
3967 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3968 CaptureStderr();
3969 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3970 EXPECT_EQ("", GetCapturedStderr());
3971}
3972
Jeongik Chaef44e622020-10-23 16:00:52 +09003973TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3974 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3975 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3976 std::string expectedErr =
3977 "ERROR: a/Foo.aidl:1.28-30: "
3978 "Encountered an untyped List or Map. The use of untyped List/Map is "
3979 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3980 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3981 "ERROR: a/Foo.aidl:1.35-37: "
3982 "Encountered an untyped List or Map. The use of untyped List/Map is "
3983 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3984 "the receiving side. Consider switching to an array or a generic List/Map.\n";
3985 CaptureStderr();
3986 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3987 EXPECT_EQ(expectedErr, GetCapturedStderr());
3988}
3989
3990TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09003991 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
3992 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09003993 std::string expectedErr =
3994 "ERROR: a/Foo.aidl:1.33-35: "
3995 "Encountered an untyped List or Map. The use of untyped List/Map is "
3996 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
3997 "the receiving side. Consider switching to an array or a generic List/Map.\n"
3998 "ERROR: a/Foo.aidl:1.40-42: "
3999 "Encountered an untyped List or Map. The use of untyped List/Map is "
4000 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4001 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004002 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09004003 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4004 EXPECT_EQ(expectedErr, GetCapturedStderr());
4005}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004006
Jeongik Chaef44e622020-10-23 16:00:52 +09004007TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4008 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4009 io_delegate_.SetFileContents(
4010 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4011 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4012 std::string expectedErr =
4013 "ERROR: a/Foo.aidl:1.52-54: "
4014 "Encountered an untyped List or Map. The use of untyped List/Map is "
4015 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4016 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4017 "ERROR: a/Foo.aidl:1.64-66: "
4018 "Encountered an untyped List or Map. The use of untyped List/Map is "
4019 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4020 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4021 CaptureStderr();
4022 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4023 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004024}
4025
Jooyung Han690f5842020-12-04 13:02:04 +09004026TEST_F(AidlTest, EnumWithDefaults_Java) {
4027 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4028 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4029package p;
4030import p.Enum;
4031parcelable Foo {
4032 Enum e = Enum.BAR;
4033})");
4034 CaptureStderr();
4035 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
4036 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4037 auto err = GetCapturedStderr();
4038 EXPECT_EQ("", err);
4039
4040 string code;
4041 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
4042 EXPECT_THAT(code, testing::HasSubstr("byte e = Enum.BAR"));
4043}
4044
4045TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4046 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4047 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4048package p;
4049import p.Enum;
4050parcelable Foo {
4051 Enum e = Enum.BAR;
4052})");
4053 CaptureStderr();
4054 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
4055 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4056 auto err = GetCapturedStderr();
4057 EXPECT_EQ("", err);
4058
4059 string code;
4060 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4061 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4062}
4063
4064TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4065 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4066 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4067package p;
4068import p.Enum;
4069parcelable Foo {
4070 Enum e = Enum.BAR;
4071})");
4072 CaptureStderr();
4073 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4074 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4075 auto err = GetCapturedStderr();
4076 EXPECT_EQ("", err);
4077
4078 string code;
4079 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4080 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4081}
4082
4083TEST_F(AidlTest, EnumWithDefaults_Rust) {
4084 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4085 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4086package p;
4087import p.Enum;
4088parcelable Foo {
4089 int n = 42;
4090 Enum e = Enum.BAR;
4091})");
4092 CaptureStderr();
4093 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
4094 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4095 auto err = GetCapturedStderr();
4096 EXPECT_EQ("", err);
4097
4098 string code;
4099 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4100 EXPECT_THAT(code, testing::HasSubstr(R"(
4101 fn default() -> Self {
4102 Self {
4103 n: 42,
4104 e: crate::mangled::_1_p_4_Enum::BAR,
4105 }
4106 })"));
4107}
4108
4109TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4110 import_paths_.insert("a");
4111 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4112 CaptureStderr();
4113 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4114package p;
4115import p.Enum;
4116parcelable Foo {
4117 int e = Enum.FOO | Enum.BAR;
4118})",
4119 typenames_, GetLanguage());
4120 auto err = GetCapturedStderr();
4121 EXPECT_EQ("", err);
4122 EXPECT_TRUE(type);
4123 const auto& fields = type->AsStructuredParcelable()->GetFields();
4124 EXPECT_EQ("int e = 3", fields[0]->ToString());
4125}
4126
4127TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4128 CaptureStderr();
4129 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4130@Backing(type="int")
4131enum Foo {
4132 STANDARD_SHIFT = 16,
4133 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4134 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4135}
4136)",
4137 typenames_, GetLanguage());
4138 auto err = GetCapturedStderr();
4139 EXPECT_EQ("", err);
4140 EXPECT_TRUE(type);
4141 const auto& enum_type = type->AsEnumDeclaration();
4142 string code;
4143 enum_type->Dump(CodeWriter::ForString(&code).get());
4144 EXPECT_EQ(R"--(@Backing(type="int")
4145enum Foo {
4146 STANDARD_SHIFT = 16,
4147 STANDARD_BT709 = 65536,
4148 STANDARD_BT601_625 = 131072,
4149}
4150)--",
4151 code);
4152}
4153
4154TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4155 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4156 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4157package p;
4158import p.Enum;
4159parcelable Foo {
4160 Enum e = Enum.FOO | Enum.BAR;
4161})");
4162 CaptureStderr();
4163 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
4164 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4165 auto err = GetCapturedStderr();
4166 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4167 err);
4168}
4169
4170TEST_P(AidlTest, DefaultWithEmptyArray) {
4171 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4172 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4173 CaptureStderr();
4174 auto options = Options::From("aidl -I a --lang " + Options::LanguageToString(GetLanguage()) +
4175 " -o out -h out a/p/Foo.aidl");
4176 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4177 auto err = GetCapturedStderr();
4178 EXPECT_EQ("", err);
4179}
4180
4181TEST_P(AidlTest, RejectRefsInAnnotation) {
4182 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4183 "package p; interface IFoo {\n"
4184 " const String ANNOTATION = \"@Annotation\";\n"
4185 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4186 "}");
4187 CaptureStderr();
4188 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4189 " -o out -h out a/p/IFoo.aidl");
4190 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4191 auto err = GetCapturedStderr();
4192 EXPECT_EQ(
4193 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4194 "ANNOTATION.\n",
4195 err);
4196}
4197
4198TEST_F(AidlTest, DefaultWithEnumValues) {
4199 io_delegate_.SetFileContents(
4200 "a/p/Foo.aidl",
4201 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4202 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4203 CaptureStderr();
4204 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4205 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4206 auto err = GetCapturedStderr();
4207 EXPECT_EQ("", err);
4208 string code;
4209 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4210 EXPECT_THAT(
4211 code, testing::HasSubstr(
4212 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4213}
4214
Jooyung Han14259392020-12-07 10:00:08 +09004215TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4216 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4217 CaptureStderr();
4218 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4219 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4220 auto err = GetCapturedStderr();
4221 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.26-28: Failed to parse expression as integer: B\n", err);
4222}
4223
4224TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4225 io_delegate_.SetFileContents("a/p/Foo.aidl",
4226 "package p; parcelable Foo { const int A = A + 1; }");
4227 CaptureStderr();
4228 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4229 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4230 auto err = GetCapturedStderr();
4231 EXPECT_EQ(
4232 "ERROR: a/p/Foo.aidl:1.42-44: Can't evaluate the circular reference (A)\n"
4233 "ERROR: a/p/Foo.aidl:1.42-44: Invalid left operand in binary expression: A+1\n",
4234 err);
4235}
4236
Christopher Wiley90be4e32015-10-20 14:55:25 -07004237} // namespace aidl
4238} // namespace android