blob: 4d6ee2eda2ecdbf2329f0927a1088d5ffbe88b74 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070046using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090047using testing::internal::CaptureStderr;
48using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070049
50namespace android {
51namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070052namespace {
53
54const char kExpectedDepFileContents[] =
55R"(place/for/output/p/IFoo.java : \
56 p/IFoo.aidl
57
58p/IFoo.aidl :
59)";
60
Dan Willemsen93298ee2016-11-10 23:55:55 -080061const char kExpectedNinjaDepFileContents[] =
62R"(place/for/output/p/IFoo.java : \
63 p/IFoo.aidl
64)";
65
Jiyong Parkdf202122019-09-30 20:48:35 +090066const char kExpectedParcelableDeclarationDepFileContents[] =
67 R"( : \
68 p/Foo.aidl
69
70p/Foo.aidl :
71)";
72
73const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080074 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070075 p/Foo.aidl
76
77p/Foo.aidl :
78)";
79
Jooyung Hand2fa0232020-10-19 02:51:41 +090080const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090081 R"(/*
82 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090083 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080084@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090085public class Rect implements android.os.Parcelable
86{
87 // Comment
88
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080089 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090090 public int x = 5;
91
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080092 @android.annotation.Hide
93 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000094 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090095
96 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090097
98 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090099 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
100 @Override
101 public Rect createFromParcel(android.os.Parcel _aidl_source) {
102 Rect _aidl_out = new Rect();
103 _aidl_out.readFromParcel(_aidl_source);
104 return _aidl_out;
105 }
106 @Override
107 public Rect[] newArray(int _aidl_size) {
108 return new Rect[_aidl_size];
109 }
110 };
111 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
112 {
113 int _aidl_start_pos = _aidl_parcel.dataPosition();
114 _aidl_parcel.writeInt(0);
115 _aidl_parcel.writeInt(x);
116 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900117 if ((fd!=null)) {
118 _aidl_parcel.writeInt(1);
119 fd.writeToParcel(_aidl_parcel, 0);
120 }
121 else {
122 _aidl_parcel.writeInt(0);
123 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900124 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900125 int _aidl_end_pos = _aidl_parcel.dataPosition();
126 _aidl_parcel.setDataPosition(_aidl_start_pos);
127 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
128 _aidl_parcel.setDataPosition(_aidl_end_pos);
129 }
130 public final void readFromParcel(android.os.Parcel _aidl_parcel)
131 {
132 int _aidl_start_pos = _aidl_parcel.dataPosition();
133 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900134 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900135 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900136 x = _aidl_parcel.readInt();
137 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
138 y = _aidl_parcel.readInt();
139 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900140 if ((0!=_aidl_parcel.readInt())) {
141 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
142 }
143 else {
144 fd = null;
145 }
146 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900147 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900148 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900149 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900150 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
151 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
152 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900153 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
154 }
155 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900156 @Override
157 public int describeContents() {
158 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900159 _mask |= describeContents(fd);
160 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900161 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900162 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900163 private int describeContents(Object _v) {
164 if (_v == null) return 0;
165 if (_v instanceof java.util.Collection) {
166 int _mask = 0;
167 for (Object o : (java.util.Collection) _v) {
168 _mask |= describeContents(o);
169 }
170 return _mask;
171 }
172 if (_v instanceof android.os.Parcelable) {
173 return ((android.os.Parcelable) _v).describeContents();
174 }
175 return 0;
176 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900177}
178)";
179
Devin Moore2f2077a2020-08-28 11:27:53 -0700180// clang-format off
181const char kExpectedCppHeaderOutput[] =
182 R"(#pragma once
183
184#include <binder/IBinder.h>
185#include <binder/IInterface.h>
186#include <binder/Status.h>
187#include <optional>
188#include <utils/String16.h>
189#include <utils/StrongPointer.h>
190#include <vector>
191
192class IFoo : public ::android::IInterface {
193public:
194 DECLARE_META_INTERFACE(Foo)
195 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
196}; // class IFoo
197class IFooDefault : public IFoo {
198public:
199 ::android::IBinder* onAsBinder() override {
200 return nullptr;
201 }
202 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
203 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
204 }
205}; // class IFooDefault
206)";
207// clang-format on
208
Christopher Wileyf8136192016-04-12 14:19:35 -0700209} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700210
Devin Moore7b8d5c92020-03-17 14:14:08 -0700211class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700212 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900213 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
214 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700215 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700216 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900217 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700218 args.emplace_back("aidl");
219 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700220 for (const string& s : additional_arguments) {
221 args.emplace_back(s);
222 }
223 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900224 args.emplace_back("--preprocessed=" + f);
225 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700226 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900227 args.emplace_back("--include=" + i);
228 }
229 args.emplace_back(path);
230 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900231 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900232 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700233 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900234 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900235
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700236 if (error != nullptr) {
237 *error = actual_error;
238 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900239
240 if (actual_error != AidlError::OK) {
241 return nullptr;
242 }
243
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900244 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900245 EXPECT_EQ(1ul, defined_types.size());
246
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900247 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700248 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700249
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 Options::Language GetLanguage() { return GetParam(); }
251
Christopher Wiley0522cd52015-10-28 15:39:44 -0700252 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800253 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900254 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900255 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700256};
257
Devin Moore7b8d5c92020-03-17 14:14:08 -0700258// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
259// tests with each of the supported languages as a parameter.
260INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
261 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700262 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700263 [](const testing::TestParamInfo<Options::Language>& info) {
264 return Options::LanguageToString(info.param);
265 });
266
267TEST_P(AidlTest, AcceptMissingPackage) {
268 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700269}
270
Devin Moore7b8d5c92020-03-17 14:14:08 -0700271TEST_P(AidlTest, EndsInSingleLineComment) {
272 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700273}
274
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000275TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
276 const string expected_stderr =
277 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
278 const std::string file_contents = "package a; interface IBar {}";
279 CaptureStderr();
280 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
281 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
282}
283
284TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
285 const string expected_stderr =
286 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
287 const std::string file_contents = "package a; interface Bar {}";
288 CaptureStderr();
289 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
290 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
291}
292
293TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
294 const string expected_stderr =
295 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
296 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
297 CaptureStderr();
298 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
299 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
300}
301
302TEST_P(AidlTest, EnumRequiresCorrectPath) {
303 const string expected_stderr =
304 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
305 const std::string file_contents = "package a; enum Bar { A, }";
306 CaptureStderr();
307 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
308 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
309}
310
Devin Moore7b8d5c92020-03-17 14:14:08 -0700311TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900312 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700313 io_delegate_.SetFileContents("bar/IBar.aidl",
314 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700315 const string path = "foo/IFoo.aidl";
316 const string contents =
317 "package foo;\n"
318 "import bar.IBar;\n"
319 "interface IFoo { void f(in IBar[] input); }";
320 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
321 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700324}
325
Devin Moore7b8d5c92020-03-17 14:14:08 -0700326TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700327 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700328 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900329}
Devin Moore097a3ab2020-03-11 16:08:44 -0700330
Jiyong Park40782d02020-07-24 19:17:43 +0900331TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700332 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
333 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900334 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
335 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700336 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700337 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700338 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900339}
340
Jiyong Park40782d02020-07-24 19:17:43 +0900341TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700342 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
343 const string expected_stderr =
344 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700345 CaptureStderr();
346 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900348}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700349
Jiyong Park40782d02020-07-24 19:17:43 +0900350TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700351 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900352 const string expected_stderr =
353 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700354 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700355 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700357}
358
Devin Moore7b8d5c92020-03-17 14:14:08 -0700359TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700360 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
361 const string expected_stderr =
362 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700365 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700366}
367
Devin Moore7b8d5c92020-03-17 14:14:08 -0700368TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700369 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
370 const string expected_stderr =
371 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700374 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800375}
376
Devin Moore2f2077a2020-08-28 11:27:53 -0700377TEST_P(AidlTest, AcceptNullableList) {
378 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
379 const string expected_stderr = "";
380 CaptureStderr();
381 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
382 EXPECT_EQ(expected_stderr, GetCapturedStderr());
383}
384
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700386 const string method = "package a; interface IFoo { void f(int a, int a); }";
387 const string expected_stderr =
388 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
389 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700390 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700391 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700392}
393
Jeongik Cha13066da2020-08-06 15:43:19 +0900394TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
395 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900396 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900397 CaptureStderr();
398 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
400}
401
Jooyung Hand902a972020-10-23 17:32:44 +0900402TEST_P(AidlTest, RejectsRepeatedAnnotations) {
403 const string method = R"(@Hide @Hide parcelable Foo {})";
404 const string expected_stderr =
405 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
406 "Foo.aidl:1.1-6\n";
407 CaptureStderr();
408 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
409 EXPECT_EQ(expected_stderr, GetCapturedStderr());
410}
411
Devin Moore7b8d5c92020-03-17 14:14:08 -0700412TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700413 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
414 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
415 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100418}
419
Devin Moore7b8d5c92020-03-17 14:14:08 -0700420TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700421 AidlError error;
422 const string method = "package a; @nullable interface IFoo { int f(); }";
423 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800424 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000425 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
426 "JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700427 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700428 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700429 EXPECT_EQ(expected_stderr, GetCapturedStderr());
430 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800431}
432
Devin Moore7b8d5c92020-03-17 14:14:08 -0700433TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700434 AidlError error;
435 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
436 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800437 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900438 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700439 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700440 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
442 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800443}
444
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700446 AidlError error;
447 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
448 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000449 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900450 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900451 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700452 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000453 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700454 EXPECT_EQ(expected_stderr, GetCapturedStderr());
455 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800456}
457
Devin Moore7b8d5c92020-03-17 14:14:08 -0700458TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700459 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000460 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700461 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000462 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900463 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700464 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700465 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000466 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
468 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800469}
470
Jiyong Park40782d02020-07-24 19:17:43 +0900471TEST_P(AidlTest, ParsesNonNullableAnnotation) {
472 auto parse_result =
473 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
474 ASSERT_NE(nullptr, parse_result);
475 const AidlInterface* interface = parse_result->AsInterface();
476 ASSERT_NE(nullptr, interface);
477 ASSERT_FALSE(interface->GetMethods().empty());
478 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
479}
480
Devin Moore7b8d5c92020-03-17 14:14:08 -0700481TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900482 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
483 typenames_, GetLanguage());
484 ASSERT_NE(nullptr, parse_result);
485 const AidlInterface* interface = parse_result->AsInterface();
486 ASSERT_NE(nullptr, interface);
487 ASSERT_FALSE(interface->GetMethods().empty());
488 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
489}
490
491TEST_P(AidlTest, ParsesNonUtf8Annotations) {
492 auto parse_result =
493 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
494 ASSERT_NE(nullptr, parse_result);
495 const AidlInterface* interface = parse_result->AsInterface();
496 ASSERT_NE(nullptr, interface);
497 ASSERT_FALSE(interface->GetMethods().empty());
498 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800499}
500
Devin Moore7b8d5c92020-03-17 14:14:08 -0700501TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900502 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
503 typenames_, GetLanguage());
504 ASSERT_NE(nullptr, parse_result);
505 const AidlInterface* interface = parse_result->AsInterface();
506 ASSERT_NE(nullptr, interface);
507 ASSERT_FALSE(interface->GetMethods().empty());
508 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800509}
510
Devin Moore7b8d5c92020-03-17 14:14:08 -0700511TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700512 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700513 const string expected_stderr =
514 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
515 "\"vintf\"'\n"
516 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
517 "--structured\n";
518 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700519 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700520 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700521 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700523}
524
Devin Moore7b8d5c92020-03-17 14:14:08 -0700525TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700526 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700527 const string expected_stderr =
528 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
529 "--structured\n";
530 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700531 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700532 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700533 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700535}
536
Devin Moore7b8d5c92020-03-17 14:14:08 -0700537TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700538 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700539 const string expected_stderr =
540 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
541 "\"vintf\"'\n";
542 CaptureStderr();
543 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700544 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700545 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700547}
548
Devin Moore7b8d5c92020-03-17 14:14:08 -0700549TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700550 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700551 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
552 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700553 ASSERT_EQ(AidlError::OK, error);
554 ASSERT_NE(nullptr, parse_result);
555 const AidlInterface* interface = parse_result->AsInterface();
556 ASSERT_NE(nullptr, interface);
557 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700558}
559
Jeongik Cha64783ed2019-06-07 18:30:54 +0900560TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
561 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900562 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
563 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900564 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700565 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900566 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900567 "a/Foo.aidl",
568 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900569
570 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900571 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700572 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900573 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700574 "Parcelable must be defined in AIDL directly.\n";
575 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900576 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700577 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700578
579 CaptureStderr();
580 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
581 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900582}
583
Jooyung Han1cbc4962020-10-25 10:07:15 +0900584TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
585 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
586 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
587 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900588 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
589
590 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900591 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900592 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
593
594 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900595 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900596 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
597
Jooyung Han1cbc4962020-10-25 10:07:15 +0900598 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900599 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
600}
601
Jooyung Han1cbc4962020-10-25 10:07:15 +0900602TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
603 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
604 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
605 CaptureStderr();
606 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
607 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
608 EXPECT_EQ("", GetCapturedStderr());
609
610 const string expected_to_string_method = R"--(
611 @Override
612 public String toString() {
613 switch (_tag) {
614 case a: return "a.Foo.a(" + (getA()) + ")";
615 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
616 }
617 throw new IllegalStateException("unknown field: " + _tag);
618 }
619)--";
620
621 string java_out;
622 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
623 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
624}
625
Jiyong Park9aa3d042020-12-04 23:30:02 +0900626TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
627 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
628 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
629 CaptureStderr();
630 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
631 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
632 EXPECT_EQ("", GetCapturedStderr());
633
634 const std::string expected = R"--(
635 @Override
636 public boolean equals(Object other) {
637 if (this == other) return true;
638 if (other == null) return false;
639 if (!(other instanceof Foo)) return false;
640 Foo that = (Foo)other;
641 if (!java.util.Objects.deepEquals(a, that.a)) return false;
642 if (!java.util.Objects.deepEquals(b, that.b)) return false;
643 return true;
644 }
645
646 @Override
647 public int hashCode() {
648 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
649 }
650)--";
651
652 string java_out;
653 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
654 EXPECT_THAT(java_out, testing::HasSubstr(expected));
655}
656
657TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
658 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
659 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
660 CaptureStderr();
661 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
662 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
663 EXPECT_EQ("", GetCapturedStderr());
664
665 const std::string expected = R"--(
666 @Override
667 public boolean equals(Object other) {
668 if (this == other) return true;
669 if (other == null) return false;
670 if (!(other instanceof Foo)) return false;
671 Foo that = (Foo)other;
672 if (_tag != that._tag) return false;
673 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
674 return true;
675 }
676
677 @Override
678 public int hashCode() {
679 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
680 }
681)--";
682
683 string java_out;
684 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
685 EXPECT_THAT(java_out, testing::HasSubstr(expected));
686}
687
Jooyung Han90345002020-10-23 15:28:53 +0900688TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900689 {
Jooyung Han90345002020-10-23 15:28:53 +0900690 io_delegate_.SetFileContents("a/Foo.aidl",
691 "package a; @JavaDerive(blah=true) parcelable Foo{}");
692 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
693 CaptureStderr();
694 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
695 const std::string expected_stderr =
696 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
697 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
698 }
699
700 {
701 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900702 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
703 CaptureStderr();
704 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
705 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900706 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000707 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
708 "JavaPassthrough, Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900709 EXPECT_EQ(expected_stderr, GetCapturedStderr());
710 }
711
712 {
Jooyung Han90345002020-10-23 15:28:53 +0900713 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900714 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
715 CaptureStderr();
716 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
717 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900718 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900719 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
720 EXPECT_EQ(expected_stderr, GetCapturedStderr());
721 }
722}
723
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900724TEST_P(AidlTest, ParseDescriptorAnnotation) {
725 AidlError error;
726 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
727 typenames_, GetLanguage(), &error, {"--structured"});
728 ASSERT_EQ(AidlError::OK, error);
729 ASSERT_NE(nullptr, parse_result);
730 const AidlInterface* interface = parse_result->AsInterface();
731 ASSERT_NE(nullptr, interface);
732 ASSERT_EQ("IBar", interface->GetDescriptor());
733}
734
Jiyong Park40782d02020-07-24 19:17:43 +0900735TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700736 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700737 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900738}
739
740TEST_P(AidlTest, AcceptsOnewayInterface) {
741 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700742 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700743}
Christopher Wileyef140932015-11-03 09:29:19 -0800744
Devin Moore7b8d5c92020-03-17 14:14:08 -0700745TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700746 const string oneway_method =
747 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700748 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100749}
750
Steven Moreland65297cc2020-04-20 20:17:36 -0700751TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
752 const string oneway_method =
753 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
754 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
755 ASSERT_NE(nullptr, defined);
756 const AidlInterface* iface = defined->AsInterface();
757 ASSERT_NE(nullptr, iface);
758
759 const auto& methods = iface->GetMethods();
760 ASSERT_EQ(1u, methods.size());
761 const auto& method = methods[0];
762 const AidlTypeSpecifier& ret_type = method->GetType();
763
764 // TODO(b/151102494): these annotations should be on the method
765 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
766 ASSERT_TRUE(ret_type.IsHide());
767}
768
Devin Moore7b8d5c92020-03-17 14:14:08 -0700769TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100770 string foo_interface =
771 "package a; /* foo */ interface IFoo {"
772 " /* i */ int i();"
773 " /* j */ @nullable String j();"
774 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
775
Devin Moore7b8d5c92020-03-17 14:14:08 -0700776 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100777 EXPECT_NE(nullptr, parse_result);
778 EXPECT_EQ("/* foo */", parse_result->GetComments());
779
780 const AidlInterface* interface = parse_result->AsInterface();
781 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
782 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
783 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
784}
785
Jooyung Han1a551d32020-10-05 15:37:26 +0900786TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
787 io_delegate_.SetFileContents("p/cpp_header.aidl",
788 R"(package p;
789 parcelable cpp_header cpp_header "bar/header";)");
790 import_paths_.emplace("");
791 const string input_path = "p/IFoo.aidl";
792 const string input = R"(package p;
793 import p.cpp_header;
794 interface IFoo {
795 // get bar
796 cpp_header get();
797 })";
798
799 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
800 EXPECT_NE(nullptr, parse_result);
801 const AidlInterface* interface = parse_result->AsInterface();
802 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
803}
804
Christopher Wileyef140932015-11-03 09:29:19 -0800805TEST_F(AidlTest, ParsesPreprocessedFile) {
806 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
807 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700808 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900809 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700810 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
811 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800812}
813
814TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
815 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
816 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900817
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700818 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900819 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700820 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
821 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800822}
823
Devin Moore7b8d5c92020-03-17 14:14:08 -0700824TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800825 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
826 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
827 "interface IBar {}");
828 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900829 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900830 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700831 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800832 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900833
Christopher Wiley41544372015-11-03 14:52:29 -0800834 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700835 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
836 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800837 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700838 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900839 ambiguous_type.Resolve(typenames_);
840 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800841}
842
Jiyong Park8f6ec462020-01-19 20:52:47 +0900843// Special case of PreferImportToPreprocessed. Imported type should be preferred
844// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700845TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900846 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
847 io_delegate_.SetFileContents("one/IBar.aidl",
848 "package one; "
849 "interface IBar {}");
850 preprocessed_files_.push_back("preprocessed");
851 import_paths_.emplace("");
852 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700853 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900854 EXPECT_NE(nullptr, parse_result);
855
856 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700857 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
858 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900859 // But if we request just "IBar" we should get our imported one.
860 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
861 ambiguous_type.Resolve(typenames_);
862 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
863}
864
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800865TEST_F(AidlTest, WritePreprocessedFile) {
866 io_delegate_.SetFileContents("p/Outer.aidl",
867 "package p; parcelable Outer.Inner;");
868 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
869 "interface IBar {}");
870
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900871 vector<string> args {
872 "aidl",
873 "--preprocess",
874 "preprocessed",
875 "p/Outer.aidl",
876 "one/IBar.aidl"};
877 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800878 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
879
880 string output;
881 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
882 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
883}
884
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900885TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100886 io_delegate_.SetFileContents(
887 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800888 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100889 "parcelable Rect {\n"
890 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800891 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100892 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800893 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100894 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100895 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
896 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100897 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900898 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900899 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100900 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900901
902 vector<string> args{"aidl", "Rect.aidl"};
903 Options options = Options::From(args);
904 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
905
906 string output;
907 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900908 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900909}
910
Devin Moore2f2077a2020-08-28 11:27:53 -0700911TEST_F(AidlTest, CppHeaderIncludes) {
912 io_delegate_.SetFileContents("IFoo.aidl",
913 "interface IFoo {\n"
914 " @nullable List<String> foo();\n"
915 "}");
916
917 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
918 Options options = Options::From(args);
919 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
920 std::vector<std::string> empty;
921 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
922 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
923 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
924
925 // Make sure the optional and String16.h includes are added
926 string output;
927 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
928 EXPECT_EQ(kExpectedCppHeaderOutput, output);
929}
930
Devin Moore7b8d5c92020-03-17 14:14:08 -0700931TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700932 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800933 io_delegate_.SetFileContents("p/Outer.aidl",
934 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900935 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
937 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
938 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700939 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800941}
942
Devin Moore7b8d5c92020-03-17 14:14:08 -0700943TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800944 io_delegate_.SetFileContents("preprocessed",
945 "parcelable p.Outer.Inner;");
946 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900947 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700948 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800949 // TODO(wiley): This should actually return nullptr because we require
950 // the outer class name. However, for legacy reasons,
951 // this behavior must be maintained. b/17415692
952 EXPECT_NE(nullptr, parse_result);
953}
954
Christopher Wiley632801d2015-11-05 14:15:49 -0800955TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700956 const string expected_foo_stderr =
957 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
958 "Declared parcelables should be in their own file and/or cannot be used with --structured "
959 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700960 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
961
Christopher Wiley632801d2015-11-05 14:15:49 -0800962 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700963 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700964 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900965 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700966 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900967
Steven Morelande2c64b42018-09-18 15:06:37 -0700968 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900969 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700970 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900971 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700972 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700973
Devin Moore097a3ab2020-03-11 16:08:44 -0700974 const string expected_bar_stderr =
975 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
976 "Declared parcelables should be in their own file and/or cannot be used with --structured "
977 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700978 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
979
Jiyong Parkda8c6932019-08-12 19:56:08 +0900980 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700981 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700982 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900983 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700984 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700985 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700986 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700987 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700988 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800989}
990
Devin Moore7b8d5c92020-03-17 14:14:08 -0700991TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700992 const string expected_stderr =
993 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
994 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700995 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
996 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700997 AidlError error;
998 CaptureStderr();
999 EXPECT_EQ(
1000 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001001 Parse("p/IFoo.aidl",
1002 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001003 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1005 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001006}
1007
Devin Moore7b8d5c92020-03-17 14:14:08 -07001008TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001009 AidlError error;
1010 const string expected_stderr =
1011 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1012 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001013 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1014 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001015 interface IFoo {
1016 const String DUPLICATED = "d";
1017 const int DUPLICATED = 1;
1018 }
1019 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001020 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001021 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1022 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001023}
1024
Steven Morelande689da22020-11-10 02:06:30 +00001025TEST_P(AidlTest, FailOnTooBigConstant) {
1026 AidlError error;
1027 const string expected_stderr =
1028 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1029 CaptureStderr();
1030 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1031 R"(package p;
1032 interface IFoo {
1033 const byte type2small = 256;
1034 }
1035 )",
1036 typenames_, GetLanguage(), &error));
1037 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1038 EXPECT_EQ(AidlError::BAD_TYPE, error);
1039}
1040
Devin Moore7b8d5c92020-03-17 14:14:08 -07001041TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001042 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001043 const string expected_stderr =
1044 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001045 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001046 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1047 R"(package p;
1048 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001049 parcelable IBar {}
1050 parcelable StructuredParcelable {}
1051 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001052 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001053 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001054 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001055 // Parse success is important for clear error handling even if the cases aren't
1056 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001057 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001058}
1059
Devin Moore7b8d5c92020-03-17 14:14:08 -07001060TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001061 AidlError error;
1062 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1063 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001064 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001065 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1066 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001067}
1068
Steven Morelandf9e922f2020-07-08 21:15:27 +00001069TEST_P(AidlTest, FailOnEmptyListWithComma) {
1070 AidlError error;
1071 const string expected_stderr =
1072 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1073 CaptureStderr();
1074 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1075 typenames_, GetLanguage(), &error));
1076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1077 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1078}
1079
Devin Moore7b8d5c92020-03-17 14:14:08 -07001080TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001081 AidlError error;
1082 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001083 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001084 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001085 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1086 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001087 interface IFoo {
1088 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1089 }
1090 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001091 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001092 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1093 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001094}
1095
Jiyong Park18132182020-06-08 20:24:40 +09001096TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1097 AidlError error;
1098 const string expected_stderr =
1099 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1100 "cpp_header (which can also be used as an identifier)\n";
1101 CaptureStderr();
1102 // Notice the trailing dot(.) in the name, which isn't a correct name
1103 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1104 GetLanguage(), &error));
1105 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1106 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1107}
1108
1109TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1110 AidlError error;
1111 const string expected_stderr =
1112 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1113 "cpp_header (which can also be used as an identifier)\n";
1114 CaptureStderr();
1115 // Notice the trailing dot(.) in the package name
1116 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1117 GetLanguage(), &error));
1118 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1119 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1120}
1121
Devin Moore7b8d5c92020-03-17 14:14:08 -07001122TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001123 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001124 auto parse_result = Parse("p/IFoo.aidl",
1125 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001126 interface IFoo {
1127 const int POSITIVE_HEX_VALUE = 0xf5;
1128 }
1129 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001130 typenames_, GetLanguage(), &error);
1131 EXPECT_NE(nullptr, parse_result);
1132 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001133 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001134 const auto& cpp_constants = interface->GetConstantDeclarations();
1135 EXPECT_EQ((size_t)1, cpp_constants.size());
1136 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001137 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001138 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001139}
1140
Devin Moore7b8d5c92020-03-17 14:14:08 -07001141TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001143 auto parse_result = Parse("p/IFoo.aidl",
1144 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001145 interface IFoo {
1146 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1147 }
1148 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149 typenames_, GetLanguage(), &error);
1150 ASSERT_NE(nullptr, parse_result);
1151 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001152 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001153 const auto& cpp_constants = interface->GetConstantDeclarations();
1154 EXPECT_EQ((size_t)1, cpp_constants.size());
1155 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001156 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001157 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001158}
1159
Devin Moore7b8d5c92020-03-17 14:14:08 -07001160TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001161 io_delegate_.SetFileContents(
1162 "p/Outer.aidl",
1163 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001164 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001165 const string input_path = "p/IFoo.aidl";
1166 const string input = "package p; import p.Outer; interface IFoo"
1167 " { Outer.Inner get(); }";
1168
Devin Moore7b8d5c92020-03-17 14:14:08 -07001169 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1170 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001171
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001172 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001173 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001174 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1175 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001176}
1177
Devin Moore7b8d5c92020-03-17 14:14:08 -07001178TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001179 io_delegate_.SetFileContents(
1180 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001181 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001182 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001183 const string input_path = "p/IFoo.aidl";
1184 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001185 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1186 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001187 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001188 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1189 native_type.Resolve(typenames_);
1190
1191 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1192 // C++ understands C++ specific stuff
1193 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1194 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001195 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001196 EXPECT_EQ(1u, headers.size());
1197 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001198}
1199
Christopher Wileyf8136192016-04-12 14:19:35 -07001200TEST_F(AidlTest, WritesCorrectDependencyFile) {
1201 // While the in tree build system always gives us an output file name,
1202 // other android tools take advantage of our ability to infer the intended
1203 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001204 vector<string> args = {
1205 "aidl",
1206 "-d dep/file/path",
1207 "-o place/for/output",
1208 "p/IFoo.aidl"};
1209 Options options = Options::From(args);
1210 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001211 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001212 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001213 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001214 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1215}
1216
Dan Willemsen93298ee2016-11-10 23:55:55 -08001217TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1218 // While the in tree build system always gives us an output file name,
1219 // other android tools take advantage of our ability to infer the intended
1220 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001221 vector<string> args = {
1222 "aidl",
1223 "-d dep/file/path",
1224 "--ninja",
1225 "-o place/for/output",
1226 "p/IFoo.aidl"};
1227 Options options = Options::From(args);
1228 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001229 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001230 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001231 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001232 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1233}
1234
Jiyong Parkdf202122019-09-30 20:48:35 +09001235TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001236 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1237 // this by calling aidl with every .aidl file it finds, then parsing the
1238 // generated dependency files. Those that reference .java output files are
1239 // for interfaces and those that do not are parcelables. However, for both
1240 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001241 vector<string> args = {
1242 "aidl",
1243 "-o place/for/output",
1244 "-d dep/file/path",
1245 "p/Foo.aidl"};
1246 Options options = Options::From(args);
1247 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001248 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001249 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001250 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001251 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1252}
1253
1254TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1255 vector<string> args = {
1256 "aidl",
1257 "--structured",
1258 "-o place/for/output",
1259 "-d dep/file/path",
1260 "p/Foo.aidl"};
1261 Options options = Options::From(args);
1262 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1263 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1264 string actual_dep_file_contents;
1265 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1266 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001267}
1268
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001269TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1270 vector<string> args = {
1271 "aidl",
1272 "--lang=java",
1273 "-o place/for/output",
1274 "p/Foo.aidl"};
1275 Options options = Options::From(args);
1276 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1277 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1278 string output_file_contents;
1279 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1280}
1281
Jeongik Cha08ca2182019-11-21 14:01:13 +09001282// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001283TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001284 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001285 "package a; interface IFoo {\n"
1286 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001287 string expected_stderr;
1288 switch (GetLanguage()) {
1289 case Options::Language::CPP:
1290 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001291 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001292 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1293 "String and IBinder.\n";
1294 break;
1295 case Options::Language::JAVA:
1296 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001297 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001298 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1299 "String, IBinder, and ParcelFileDescriptor.\n";
1300 break;
1301 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001302 case Options::Language::RUST:
1303 expected_stderr =
1304 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1305 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001306 default:
1307 AIDL_FATAL(AIDL_LOCATION_HERE)
1308 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1309 }
1310 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001311 AidlTypenames tn1;
1312 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001314
1315 string primitive_parcelable =
1316 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001317 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001318 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001319 AidlTypenames tn2;
1320 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001321 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001322}
1323
Devin Moore21b26772020-08-26 16:37:56 -07001324TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001325 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001326 const string list_array_parcelable =
1327 "package a; parcelable Foo {\n"
1328 " List[] lists; }";
1329 CaptureStderr();
1330 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1331 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1332}
1333
Jiyong Parkf8d53612020-05-04 14:06:13 +09001334TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1335 AidlError error;
1336 string expected_stderr =
1337 "ERROR: a/IFoo.aidl:2.7-11: "
1338 "Encountered an untyped List or Map. The use of untyped List/Map is "
1339 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1340 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1341 if (GetLanguage() != Options::Language::JAVA) {
1342 expected_stderr =
1343 "ERROR: a/IFoo.aidl:2.1-7: "
1344 "Currently, only the Java backend supports non-generic List.\n";
1345 }
1346
1347 const string primitive_interface =
1348 "package a; interface IFoo {\n"
1349 " List foo(); }";
1350 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001351 AidlTypenames tn1;
1352 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001353 {"--structured"}));
1354 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001355
1356 string primitive_parcelable =
1357 "package a; parcelable IFoo {\n"
1358 " List foo;}";
1359 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001360 AidlTypenames tn2;
1361 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001362 {"--structured"}));
1363 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1364}
1365
Jeongik Cha225519b2020-08-29 01:55:32 +09001366TEST_P(AidlTest, ExtensionTest) {
1367 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001368 string extendable_parcelable =
1369 "package a; parcelable Data {\n"
1370 " ParcelableHolder extension;\n"
1371 " ParcelableHolder extension2;\n"
1372 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001373 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001374 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1375 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001376 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001377 "yet.\n",
1378 GetCapturedStderr());
1379 } else {
1380 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1381 EXPECT_EQ("", GetCapturedStderr());
1382 }
1383}
1384TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1385 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001386 string parcelableholder_return_interface =
1387 "package a; interface IFoo {\n"
1388 " ParcelableHolder foo();\n"
1389 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001390 EXPECT_EQ(nullptr,
1391 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001392
Jeongik Cha8f02a532020-10-14 00:16:28 +09001393 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001394 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001395 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001396 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001397 "yet.\n",
1398 GetCapturedStderr());
1399 return;
1400 }
1401 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1402 GetCapturedStderr());
1403}
1404
1405TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1406 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001407 string extendable_parcelable_arg_interface =
1408 "package a; interface IFoo {\n"
1409 " void foo(in ParcelableHolder ph);\n"
1410 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001411 EXPECT_EQ(nullptr,
1412 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1413
Jeongik Cha8f02a532020-10-14 00:16:28 +09001414 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001415 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001416 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001417 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001418 "yet.\n",
1419 GetCapturedStderr());
1420 return;
1421 }
1422 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1423 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001424}
1425
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001426TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1427 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1428 Options options =
1429 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1430 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1431 CaptureStderr();
1432 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1433 if (GetLanguage() == Options::Language::RUST) {
1434 EXPECT_EQ(
1435 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1436 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1437 "yet.\n",
1438 GetCapturedStderr());
1439 return;
1440 }
1441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1442}
1443
Jooyung Han3f347ca2020-12-01 12:41:50 +09001444TEST_P(AidlTest, ParcelablesWithConstants) {
1445 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
1446 Options options =
1447 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1448 CaptureStderr();
1449 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1450 EXPECT_EQ("", GetCapturedStderr());
1451}
1452
1453TEST_P(AidlTest, UnionWithConstants) {
1454 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
1455 Options options =
1456 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1457 CaptureStderr();
1458 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1459 EXPECT_EQ("", GetCapturedStderr());
1460}
1461
Jiyong Park02da7422018-07-16 16:00:26 +09001462TEST_F(AidlTest, ApiDump) {
1463 io_delegate_.SetFileContents(
1464 "foo/bar/IFoo.aidl",
1465 "package foo.bar;\n"
1466 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001467 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001468 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001469 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001470 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1471 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1472 " IFoo foo3(IFoo foo);\n"
1473 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001474 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001475 " const int A = 1;\n"
1476 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001477 "}\n");
1478 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1479 "package foo.bar;\n"
1480 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001481 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001482 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001483 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001484 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001485 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001486 " int y;\n"
1487 " IFoo foo;\n"
1488 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001489 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001490 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001491 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001492 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001493 "}\n");
1494 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001495 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1496 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001497 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001498 bool result = dump_api(options, io_delegate_);
1499 ASSERT_TRUE(result);
1500 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001501 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001502 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001503/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001504interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001505 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001506 int foo(out int[] a, String b, boolean c, inout List<String> d);
1507 int foo2(@utf8InCpp String x, inout List<String> y);
1508 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1509 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001510 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001511 const int A = 1;
1512 const String STR = "Hello";
1513}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001514)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001515
Jiyong Parke59c3682018-09-11 23:10:25 +09001516 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001517 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001518/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001519parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001520 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001521 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001522 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001523 int y;
1524 foo.bar.IFoo foo;
1525 List<foo.bar.IFoo> a;
1526 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001527 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001528 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001529}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001530)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001531}
1532
Jiyong Parked65bf42018-08-28 15:43:27 +09001533TEST_F(AidlTest, ApiDumpWithManualIds) {
1534 io_delegate_.SetFileContents(
1535 "foo/bar/IFoo.aidl",
1536 "package foo.bar;\n"
1537 "interface IFoo {\n"
1538 " int foo() = 1;\n"
1539 " int bar() = 2;\n"
1540 " int baz() = 10;\n"
1541 "}\n");
1542
Jiyong Parke59c3682018-09-11 23:10:25 +09001543 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001544 Options options = Options::From(args);
1545 bool result = dump_api(options, io_delegate_);
1546 ASSERT_TRUE(result);
1547 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001548 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001549 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001550interface IFoo {
1551 int foo() = 1;
1552 int bar() = 2;
1553 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001554}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001555)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001556}
1557
1558TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001559 const string expected_stderr =
1560 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1561 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001562 io_delegate_.SetFileContents(
1563 "foo/bar/IFoo.aidl",
1564 "package foo.bar;\n"
1565 "interface IFoo {\n"
1566 " int foo() = 1;\n"
1567 " int bar();\n"
1568 " int baz() = 10;\n"
1569 "}\n");
1570
Jiyong Parke59c3682018-09-11 23:10:25 +09001571 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001572 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001573 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001574 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001575 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001576}
1577
Jooyung Han965e31d2020-11-27 12:30:16 +09001578TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1579 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1580 "package foo.bar;\n"
1581 "interface IFoo {\n"
1582 " @utf8InCpp String foo();\n"
1583 " const @utf8InCpp String bar = \"bar\";\n"
1584 "}\n");
1585
1586 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1587 Options options = Options::From(args);
1588 CaptureStderr();
1589 EXPECT_TRUE(dump_api(options, io_delegate_));
1590 EXPECT_EQ("", GetCapturedStderr());
1591 string actual;
1592 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001593 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1594interface IFoo {
1595 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001596 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001597}
1598)"),
1599 actual);
1600}
1601
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001602TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001603 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001604 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1605 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001606 const string expected_map_stderr =
1607 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001608 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1609 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001610 "package p; interface IFoo {"
1611 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001612 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001613 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001614 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001615
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001616 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001617 "package p; interface IFoo {"
1618 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001619 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001620 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001621 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001622}
1623
Jeongik Chae48d9942020-01-02 17:39:00 +09001624TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001625 const string expected_stderr =
1626 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001627 Options options = Options::From("aidl -I p p/IFoo.aidl");
1628 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1629
1630 io_delegate_.SetFileContents("p/IFoo.aidl",
1631 "package p; interface IFoo {"
1632 "Map<String, Bar> foo();}");
1633 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1634
1635 io_delegate_.SetFileContents("p/IFoo.aidl",
1636 "package p; interface IFoo {"
1637 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001638 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001639 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001640 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001641
1642 io_delegate_.SetFileContents("p/IFoo.aidl",
1643 "package p; interface IFoo {"
1644 "Map<String, String> foo();}");
1645 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1646
1647 io_delegate_.SetFileContents("p/IFoo.aidl",
1648 "package p; interface IFoo {"
1649 "Map<String, ParcelFileDescriptor> foo();}");
1650 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1651}
1652
Jeongik Chadf76dc72019-11-28 00:08:47 +09001653TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001654 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001655 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1656 io_delegate_.SetFileContents(options.InputFiles().front(),
1657 "package p; interface IFoo {"
1658 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001659 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001660 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001661 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001662}
1663
1664TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1665 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1666 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001667 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001668 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001669 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1670 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001671
1672 Options options = Options::From("aidl -I p p/IFoo.aidl");
1673 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1674 io_delegate_.SetFileContents("p/IFoo.aidl",
1675 "package p; interface IFoo {"
1676 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001677 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001678 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001679 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001680 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001681 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001682 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001683 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1684 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001685 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1686 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1687 io_delegate_.SetFileContents("p/IFoo.aidl",
1688 "package p; interface IFoo {"
1689 "Bar<String, ParcelFileDescriptor> foo();}");
1690 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001691
1692 io_delegate_.SetFileContents("p/IFoo.aidl",
1693 "package p; interface IFoo {"
1694 "Bar<int, long> foo();}");
1695
1696 io_delegate_.SetFileContents("p/IFoo.aidl",
1697 "package p; interface IFoo {"
1698 "Bar<int[], long[]> foo();}");
1699
1700 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001701}
1702
Jeongik Cha0e426012019-07-29 15:57:02 +09001703TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1704 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001705 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1706 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001707 for (const auto& rawOption : rawOptions) {
1708 string expected_stderr =
1709 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001710 Options options = Options::From(rawOption);
1711 io_delegate_.SetFileContents(options.InputFiles().front(),
1712 "package foo.bar;\n"
1713 "interface IFoo1 { int foo(); }\n"
1714 "interface IFoo2 { int foo(); }\n"
1715 "parcelable Data1 { int a; int b;}\n"
1716 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001717 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001718 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001719 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001720
Jeongik Cha0e426012019-07-29 15:57:02 +09001721 io_delegate_.SetFileContents(options.InputFiles().front(),
1722 "package foo.bar;\n"
1723 "interface IFoo1 { int foo(); }\n"
1724 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001725 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001726 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001727 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001728
Devin Moore5de18ed2020-04-02 13:52:29 -07001729 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001730 io_delegate_.SetFileContents(options.InputFiles().front(),
1731 "package foo.bar;\n"
1732 "parcelable Data1 { int a; int b;}\n"
1733 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001734 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001735 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001736 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001737 }
1738}
1739
Devin Moorebdba2a82020-03-31 15:19:02 -07001740TEST_P(AidlTest, FailParseOnEmptyFile) {
1741 const string contents = "";
1742 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1743 CaptureStderr();
1744 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1745 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1746}
1747
Jiyong Parkb034bf02018-07-30 17:44:33 +09001748TEST_F(AidlTest, MultipleInputFiles) {
1749 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001750 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001751
1752 io_delegate_.SetFileContents(options.InputFiles().at(0),
1753 "package foo.bar;\n"
1754 "import foo.bar.Data;\n"
1755 "interface IFoo { Data getData(); }\n");
1756
1757 io_delegate_.SetFileContents(options.InputFiles().at(1),
1758 "package foo.bar;\n"
1759 "import foo.bar.IFoo;\n"
1760 "parcelable Data { IFoo foo; }\n");
1761
1762 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1763
1764 string content;
1765 for (const auto file : {
1766 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1767 content.clear();
1768 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1769 EXPECT_FALSE(content.empty());
1770 }
1771}
1772
1773TEST_F(AidlTest, MultipleInputFilesCpp) {
1774 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001775 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001776
1777 io_delegate_.SetFileContents(options.InputFiles().at(0),
1778 "package foo.bar;\n"
1779 "import foo.bar.Data;\n"
1780 "interface IFoo { Data getData(); }\n");
1781
1782 io_delegate_.SetFileContents(options.InputFiles().at(1),
1783 "package foo.bar;\n"
1784 "import foo.bar.IFoo;\n"
1785 "parcelable Data { IFoo foo; }\n");
1786
1787 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1788
1789 string content;
1790 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001791 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001792 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1793 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1794 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1795 content.clear();
1796 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1797 EXPECT_FALSE(content.empty());
1798 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001799}
1800
Andrei Homescub62afd92020-05-11 19:24:59 -07001801TEST_F(AidlTest, MultipleInputFilesRust) {
1802 Options options =
1803 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1804
1805 io_delegate_.SetFileContents(options.InputFiles().at(0),
1806 "package foo.bar;\n"
1807 "import foo.bar.Data;\n"
1808 "interface IFoo { Data getData(); }\n");
1809
1810 io_delegate_.SetFileContents(options.InputFiles().at(1),
1811 "package foo.bar;\n"
1812 "import foo.bar.IFoo;\n"
1813 "parcelable Data { IFoo foo; }\n");
1814
1815 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1816
1817 string content;
1818 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1819 content.clear();
1820 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1821 EXPECT_FALSE(content.empty());
1822 }
1823}
1824
Devin Moore097a3ab2020-03-11 16:08:44 -07001825TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1826 const string expected_stderr =
1827 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001828 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1829 // int getInterfaceVersion() is one of the meta transactions
1830 io_delegate_.SetFileContents(options.InputFiles().front(),
1831 "package p; interface IFoo {"
1832 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001833 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001834 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001835 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1836}
Jiyong Park309668e2018-07-28 16:55:44 +09001837
Devin Moore097a3ab2020-03-11 16:08:44 -07001838TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1839 // boolean getInterfaceVersion() is not a meta transaction, but should be
1840 // prevented because return type is not part of a method signature
1841 const string expected_stderr =
1842 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1843 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001844 io_delegate_.SetFileContents(options.InputFiles().front(),
1845 "package p; interface IFoo {"
1846 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001847 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001848 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001849 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1850}
Jiyong Park309668e2018-07-28 16:55:44 +09001851
Devin Moore097a3ab2020-03-11 16:08:44 -07001852TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001853 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001854 const string expected_stderr =
1855 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1856 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001857 io_delegate_.SetFileContents(options.InputFiles().front(),
1858 "package p; interface IFoo {"
1859 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001860 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001861 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001862 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001863
1864 // this is not a meta interface method as it differs type arguments
1865 io_delegate_.SetFileContents(options.InputFiles().front(),
1866 "package p; interface IFoo {"
1867 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001868 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001869}
1870
Daniel Norman85aed542019-08-21 12:01:14 -07001871TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001872 Options options = Options::From("aidl --checkapi old new");
1873 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1874 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1875 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1876 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1877
1878 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1879}
1880
Jiyong Park3656c3c2018-08-01 20:02:01 +09001881TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001882 Options options = Options::From("aidl --checkapi old new");
1883 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1884 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001885
1886 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1887}
1888
Daniel Norman85aed542019-08-21 12:01:14 -07001889class AidlTestCompatibleChanges : public AidlTest {
1890 protected:
1891 Options options_ = Options::From("aidl --checkapi old new");
1892};
1893
1894TEST_F(AidlTestCompatibleChanges, NewType) {
1895 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1896 "package p;"
1897 "interface IFoo {"
1898 " void foo(int a);"
1899 "}");
1900 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1901 "package p;"
1902 "interface IFoo {"
1903 " void foo(int a);"
1904 "}");
1905 io_delegate_.SetFileContents("new/p/IBar.aidl",
1906 "package p;"
1907 "interface IBar {"
1908 " void bar();"
1909 "}");
1910 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1911}
1912
1913TEST_F(AidlTestCompatibleChanges, NewMethod) {
1914 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1915 "package p;"
1916 "interface IFoo {"
1917 " void foo(int a);"
1918 "}");
1919 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1920 "package p;"
1921 "interface IFoo {"
1922 " void foo(int a);"
1923 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001924 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001925 "}");
1926 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1927}
1928
1929TEST_F(AidlTestCompatibleChanges, NewField) {
1930 io_delegate_.SetFileContents("old/p/Data.aidl",
1931 "package p;"
1932 "parcelable Data {"
1933 " int foo;"
1934 "}");
1935 io_delegate_.SetFileContents("new/p/Data.aidl",
1936 "package p;"
1937 "parcelable Data {"
1938 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001939 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001940 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001941 "}");
1942 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1943}
1944
1945TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1946 io_delegate_.SetFileContents("old/p/Enum.aidl",
1947 "package p;"
1948 "enum Enum {"
1949 " FOO = 1,"
1950 "}");
1951 io_delegate_.SetFileContents("new/p/Enum.aidl",
1952 "package p;"
1953 "enum Enum {"
1954 " FOO = 1,"
1955 " BAR = 2,"
1956 "}");
1957 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1958}
1959
1960TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1961 io_delegate_.SetFileContents("old/p/Enum.aidl",
1962 "package p;"
1963 "enum Enum {"
1964 " FOO = 1,"
1965 " BAR = 2,"
1966 "}");
1967 io_delegate_.SetFileContents("new/p/Enum.aidl",
1968 "package p;"
1969 "enum Enum {"
1970 " BAR = 2,"
1971 " FOO = 1,"
1972 "}");
1973 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1974}
1975
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09001976TEST_F(AidlTestCompatibleChanges, NewUnionField) {
1977 io_delegate_.SetFileContents("old/p/Union.aidl",
1978 "package p;"
1979 "union Union {"
1980 " String foo;"
1981 "}");
1982 io_delegate_.SetFileContents("new/p/Union.aidl",
1983 "package p;"
1984 "union Union {"
1985 " String foo;"
1986 " int num;"
1987 "}");
1988 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1989}
1990
Daniel Norman85aed542019-08-21 12:01:14 -07001991TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001992 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1993 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001994 "interface IFoo {"
1995 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001996 "}");
1997 io_delegate_.SetFileContents("old/p/Data.aidl",
1998 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001999 "parcelable Data {"
2000 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002001 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002002 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2003 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002004 "interface IFoo {"
2005 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002006 "}");
2007 io_delegate_.SetFileContents("new/p/Data.aidl",
2008 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002009 "parcelable Data {"
2010 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002011 "}");
2012 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2013 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002014 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002015 " void foo(int a);"
2016 "}");
2017 io_delegate_.SetFileContents("new/q/Data.aidl",
2018 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002019 "parcelable Data {"
2020 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002021 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002022 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2023}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002024
Daniel Norman85aed542019-08-21 12:01:14 -07002025TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2026 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2027 "package p;"
2028 "interface IFoo {"
2029 " void foo(int a);"
2030 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002031 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2032 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002033 "interface IFoo {"
2034 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002035 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002036 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2037}
Jiyong Parke59c3682018-09-11 23:10:25 +09002038
Daniel Norman85aed542019-08-21 12:01:14 -07002039TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002040 io_delegate_.SetFileContents("old/p/I.aidl",
2041 "package p; interface I {"
2042 "const int A = 1; }");
2043 io_delegate_.SetFileContents("new/p/I.aidl",
2044 "package p ; interface I {"
2045 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002046 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2047}
Jiyong Parka428d212018-08-29 22:26:30 +09002048
Daniel Norman85aed542019-08-21 12:01:14 -07002049TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002050 io_delegate_.SetFileContents("old/p/I.aidl",
2051 "package p; interface I {"
2052 "const int A = 1; const int B = 2;}");
2053 io_delegate_.SetFileContents("new/p/I.aidl",
2054 "package p ; interface I {"
2055 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002056 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002057}
2058
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002059TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2060 io_delegate_.SetFileContents("old/p/Foo.aidl",
2061 "package p;"
2062 "@JavaPassthrough(annotation=\"Alice\")"
2063 "@JavaPassthrough(annotation=\"Bob\")"
2064 "parcelable Foo {}");
2065 io_delegate_.SetFileContents("new/p/Foo.aidl",
2066 "package p;"
2067 "@JavaPassthrough(annotation=\"Bob\")"
2068 "@JavaPassthrough(annotation=\"Alice\")"
2069 "parcelable Foo {}");
2070 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2071}
2072
Jooyung Han00073272020-11-27 14:20:20 +09002073TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2074 io_delegate_.SetFileContents("old/p/Foo.aidl",
2075 "package p;"
2076 "parcelable Foo {}");
2077 io_delegate_.SetFileContents("new/p/Foo.aidl",
2078 "package p;"
2079 "@JavaPassthrough(annotation=\"@Deprecated\")"
2080 "parcelable Foo {}");
2081 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2082}
2083
Jooyung Han636fd2f2020-10-22 11:33:45 +09002084TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2085 io_delegate_.SetFileContents("old/p/Data.aidl",
2086 "package p;"
2087 "parcelable Data {"
2088 " int num;"
2089 "}");
2090 io_delegate_.SetFileContents(
2091 "new/p/Data.aidl",
2092 "package p;"
2093 "parcelable Data {"
2094 " int num;"
2095 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2096 "}");
2097 io_delegate_.SetFileContents("new/p/Enum.aidl",
2098 "package p;"
2099 "enum Enum {"
2100 " FOO = 0,"
2101 " BAR = 1,"
2102 "}");
2103 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2104}
2105
Daniel Norman85aed542019-08-21 12:01:14 -07002106class AidlTestIncompatibleChanges : public AidlTest {
2107 protected:
2108 Options options_ = Options::From("aidl --checkapi old new");
2109};
2110
2111TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002112 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002113 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2114 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002115 "interface IFoo {"
2116 " void foo(in String[] str);"
2117 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002118 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002119 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002120 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002121 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002122}
2123
2124TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002125 const string expected_stderr =
2126 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002127 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2128 "package p;"
2129 "interface IFoo {"
2130 " void foo(in String[] str);"
2131 " void bar(@utf8InCpp String str);"
2132 "}");
2133 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2134 "package p;"
2135 "interface IFoo {"
2136 " void foo(in String[] str);"
2137 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002138 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002139 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002140 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002141}
2142
Jiyong Parkf8d53612020-05-04 14:06:13 +09002143TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2144 const string expected_stderr =
2145 "ERROR: new/p/IFoo.aidl:1.61-65: "
2146 "Encountered an untyped List or Map. The use of untyped List/Map is "
2147 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2148 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2149 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2150 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2151 "package p;"
2152 "interface IFoo {"
2153 " void foo(in String[] str);"
2154 "}");
2155 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2156 "package p;"
2157 "interface IFoo {"
2158 " void foo(in String[] str);"
2159 " void bar(in List arg);"
2160 "}");
2161 CaptureStderr();
2162 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2163 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2164}
2165
2166TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2167 const string expected_stderr =
2168 "ERROR: new/p/Data.aidl:1.54-59: "
2169 "Encountered an untyped List or Map. The use of untyped List/Map is "
2170 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2171 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2172 "ERROR: new/p/Data.aidl: Failed to read.\n";
2173 io_delegate_.SetFileContents("old/p/Data.aidl",
2174 "package p;"
2175 "parcelable Data {"
2176 " int foo;"
2177 "}");
2178 io_delegate_.SetFileContents("new/p/Data.aidl",
2179 "package p;"
2180 "parcelable Data {"
2181 " int foo;"
2182 " @nullable List list;"
2183 "}");
2184 CaptureStderr();
2185 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2186 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2187}
2188
Daniel Norman85aed542019-08-21 12:01:14 -07002189TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002190 const string expected_stderr =
2191 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002192 io_delegate_.SetFileContents("old/p/Data.aidl",
2193 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002194 "parcelable Data {"
2195 " int foo;"
2196 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002197 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002198 io_delegate_.SetFileContents("new/p/Data.aidl",
2199 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002200 "parcelable Data {"
2201 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002202 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002203 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002204 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002205 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002206}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002207
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002208TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2209 const string expected_stderr =
2210 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2211 "backends. Please either provide a default value for this field or mark the field as "
2212 "@nullable. This value or a null value will be used automatically when an old version of "
2213 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2214 "order to make sure your code continues to be backwards compatible, make sure the default or "
2215 "null value does not cause a semantic change to this parcelable.\n";
2216 io_delegate_.SetFileContents("old/p/Data.aidl",
2217 "package p;"
2218 "parcelable Data {"
2219 " int num;"
2220 "}");
2221 io_delegate_.SetFileContents("new/p/Data.aidl",
2222 "package p;"
2223 "parcelable Data {"
2224 " int num;"
2225 " String str;"
2226 "}");
2227 CaptureStderr();
2228 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2229 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2230}
2231
Jooyung Han636fd2f2020-10-22 11:33:45 +09002232TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2233 const string expected_stderr =
2234 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2235 "Please make sure 'Enum' has '0' as a valid value.\n";
2236 io_delegate_.SetFileContents("old/p/Data.aidl",
2237 "package p;"
2238 "parcelable Data {"
2239 " int num;"
2240 "}");
2241 io_delegate_.SetFileContents("new/p/Data.aidl",
2242 "package p;"
2243 "parcelable Data {"
2244 " int num;"
2245 " p.Enum e;"
2246 "}");
2247 io_delegate_.SetFileContents("new/p/Enum.aidl",
2248 "package p;"
2249 "enum Enum {"
2250 " FOO = 1,"
2251 " BAR = 2,"
2252 "}");
2253 CaptureStderr();
2254 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2255 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2256}
2257
Daniel Norman85aed542019-08-21 12:01:14 -07002258TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002259 const string expected_stderr =
2260 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002261 io_delegate_.SetFileContents("old/p/Enum.aidl",
2262 "package p;"
2263 "enum Enum {"
2264 " FOO = 1,"
2265 " BAR = 2,"
2266 "}");
2267 io_delegate_.SetFileContents("new/p/Enum.aidl",
2268 "package p;"
2269 "enum Enum {"
2270 " BAR = 2,"
2271 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002272 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002273 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002274 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002275}
2276
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002277TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2278 const string expected_stderr =
2279 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2280 io_delegate_.SetFileContents("old/p/Union.aidl",
2281 "package p;"
2282 "union Union {"
2283 " String str;"
2284 " int num;"
2285 "}");
2286 io_delegate_.SetFileContents("new/p/Union.aidl",
2287 "package p;"
2288 "union Union {"
2289 " String str;"
2290 "}");
2291 CaptureStderr();
2292 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2293 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2294}
2295
Daniel Norman85aed542019-08-21 12:01:14 -07002296TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002297 const string expected_stderr =
2298 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002299 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2300 "package p;"
2301 "interface IFoo {"
2302 " void foo(in String[] str);"
2303 " void bar(@utf8InCpp String str);"
2304 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002305 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2306 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002307 "interface IFoo {"
2308 " void foo(in String[] str);"
2309 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002310 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002311 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002312 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002314}
2315
Daniel Norman85aed542019-08-21 12:01:14 -07002316TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002317 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002318 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2319 "package p;"
2320 "interface IFoo {"
2321 " void foo(in String[] str);"
2322 " void bar(@utf8InCpp String str);"
2323 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002324 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2325 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002326 "interface IFoo2 {"
2327 " void foo(in String[] str);"
2328 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002329 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002330 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002331 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002332 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002333}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002334
Daniel Norman85aed542019-08-21 12:01:14 -07002335TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002336 const string expected_stderr =
2337 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002338 io_delegate_.SetFileContents("old/p/Enum.aidl",
2339 "package p;"
2340 "enum Enum {"
2341 " FOO = 1,"
2342 " BAR = 2,"
2343 "}");
2344 io_delegate_.SetFileContents("new/p/Enum.aidl",
2345 "package p;"
2346 "enum Enum {"
2347 " FOO = 3,"
2348 " BAR = 2,"
2349 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002350 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002351 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002352 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002353}
2354
2355TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002356 const string expected_stderr =
2357 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2358 "from 0 to 1.\n"
2359 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2360 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002361 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2362 "package p;"
2363 "interface IFoo {"
2364 " void foo(in String[] str);"
2365 " void bar(@utf8InCpp String str);"
2366 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002367 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2368 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002369 "interface IFoo {"
2370 " void bar(@utf8InCpp String str);"
2371 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002372 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002373 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002374 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002375 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002376}
2377
2378TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002379 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002380 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2381 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002382 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002383 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002384 "parcelable Data {"
2385 " int foo;"
2386 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002387 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002388 io_delegate_.SetFileContents("new/p/Data.aidl",
2389 "package p;"
2390 "parcelable Data {"
2391 " int bar;"
2392 " int foo;"
2393 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002394 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002395 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002396 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002397}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002398
Daniel Norman85aed542019-08-21 12:01:14 -07002399TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002400 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002401 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002402 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002403 "interface IFoo {"
2404 " void foo(in String[] str);"
2405 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002406 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002407 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2408 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002409 "interface IFoo {"
2410 " void foo(out String[] str);"
2411 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002412 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002413 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002414 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002415 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002416}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002417
Daniel Norman85aed542019-08-21 12:01:14 -07002418TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002419 const string expected_stderr =
2420 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002421 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2422 "package p;"
2423 "interface IFoo {"
2424 " void foo(in String[] str);"
2425 " void bar(@utf8InCpp String str);"
2426 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002427 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2428 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002429 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002430 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002431 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002432 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002433 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002434 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002435 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002436}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002437
Daniel Norman85aed542019-08-21 12:01:14 -07002438TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002439 const string expected_stderr =
2440 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002441 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2442 "package p;"
2443 "interface IFoo {"
2444 " void foo(in String[] str);"
2445 " void bar(@utf8InCpp String str);"
2446 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002447 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2448 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002449 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002450 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002451 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002452 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002453 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002454 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002455 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002456}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002457
Jooyung Han60b2fde2020-10-29 15:12:40 +09002458TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2459 const string expected_stderr =
2460 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2461 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2462 io_delegate_.SetFileContents("old/p/Foo.aidl",
2463 "package p;"
2464 "@Backing(type=\"byte\")"
2465 "enum Foo {"
2466 " FOO, BAR,"
2467 "}");
2468 io_delegate_.SetFileContents("new/p/Foo.aidl",
2469 "package p;"
2470 "@Backing(type=\"long\")"
2471 "enum Foo {"
2472 " FOO, BAR,"
2473 "}");
2474 CaptureStderr();
2475 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2476 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2477}
2478
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002479TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2480 const string expected_stderr =
2481 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2482 "to @JavaPassthrough(annotation=\"Bob\")\n";
2483 io_delegate_.SetFileContents("old/p/Foo.aidl",
2484 "package p;"
2485 "@JavaPassthrough(annotation=\"Alice\")"
2486 "parcelable Foo {}");
2487 io_delegate_.SetFileContents("new/p/Foo.aidl",
2488 "package p;"
2489 "@JavaPassthrough(annotation=\"Bob\")"
2490 "parcelable Foo {}");
2491
2492 CaptureStderr();
2493 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2494 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2495}
2496
Devin Mooredb7ac512020-08-07 11:17:36 -07002497TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2498 const string expected_stderr =
2499 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2500 io_delegate_.SetFileContents("old/p/Foo.aidl",
2501 "package p;"
2502 "parcelable Foo {"
2503 " int A;"
2504 "}");
2505 io_delegate_.SetFileContents("new/p/Foo.aidl",
2506 "package p;"
2507 "@JavaOnlyStableParcelable parcelable Foo {"
2508 " int A;"
2509 "}");
2510 CaptureStderr();
2511 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2512 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2513}
2514
2515TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2516 const string expected_stderr =
2517 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2518 io_delegate_.SetFileContents("old/p/Foo.aidl",
2519 "package p;"
2520 "@JavaOnlyStableParcelable parcelable Foo {"
2521 " int A;"
2522 "}");
2523 io_delegate_.SetFileContents("new/p/Foo.aidl",
2524 "package p;"
2525 "parcelable Foo {"
2526 " int A;"
2527 "}");
2528 CaptureStderr();
2529 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2530 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2531}
2532
Daniel Norman85aed542019-08-21 12:01:14 -07002533TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002534 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002535 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2536 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002537 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002538 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002539 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002540 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002541}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002542
Daniel Norman85aed542019-08-21 12:01:14 -07002543TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002544 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002545 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2546 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002547 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002548 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002549 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002550}
Jiyong Parka428d212018-08-29 22:26:30 +09002551
Daniel Norman85aed542019-08-21 12:01:14 -07002552TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002553 const string expected_stderr =
2554 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002555 io_delegate_.SetFileContents("old/p/I.aidl",
2556 "package p; interface I {"
2557 "const int A = 1; const int B = 2;}");
2558 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002559 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002560 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002561 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002562}
Jiyong Parka428d212018-08-29 22:26:30 +09002563
Daniel Norman85aed542019-08-21 12:01:14 -07002564TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002565 const string expected_stderr =
2566 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002567 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2568 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002569 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002570 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002571 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002572}
2573
Devin Moorec7e47a32020-08-07 10:55:25 -07002574TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2575 const string expected_stderr =
2576 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2577 "This is an incompatible change for FixedSize types.\n";
2578 io_delegate_.SetFileContents("old/p/Foo.aidl",
2579 "package p; @FixedSize parcelable Foo { int A = 1; }");
2580 io_delegate_.SetFileContents("new/p/Foo.aidl",
2581 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2582 CaptureStderr();
2583 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2584 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2585}
2586
2587TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2588 const string expected_stderr =
2589 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2590 io_delegate_.SetFileContents("old/p/Foo.aidl",
2591 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2592 io_delegate_.SetFileContents("new/p/Foo.aidl",
2593 "package p; @FixedSize parcelable Foo { int A = 1; }");
2594 CaptureStderr();
2595 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2596 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2597}
2598
2599TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2600 const string expected_stderr =
2601 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2602 "a.\n"
2603 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2604 "b.\n"
2605 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2606 "c.\n"
2607 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2608 "d.\n"
2609 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2610 "e.\n"
2611 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2612 "f.\n";
2613
2614 io_delegate_.SetFileContents("Foo.aidl",
2615 "@FixedSize parcelable Foo { "
2616 " int[] a;"
2617 " Bar b;"
2618 " String c;"
2619 " ParcelFileDescriptor d;"
2620 " IBinder e;"
2621 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002622 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002623 "}");
2624 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2625 Options options =
2626 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2627
2628 CaptureStderr();
2629 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2630 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2631}
2632
2633TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2634 const string expected_stderr = "";
2635
2636 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2637 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2638 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2639 Options options =
2640 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2641
2642 CaptureStderr();
2643 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2644 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2645}
2646
Jiyong Park8c380532018-08-30 14:55:26 +09002647TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002648 const string expected_stderr =
2649 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2650 "dir1/q/IBar.aidl\n"
2651 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002652 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002653 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2654 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2655 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2656 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2657
Devin Moore097a3ab2020-03-11 16:08:44 -07002658 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002659 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002660 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002661}
2662
Jiyong Parked65bf42018-08-28 15:43:27 +09002663TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002664 const string expected_stderr =
2665 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2666 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002667 Options options = Options::From("aidl --checkapi old new");
2668 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2669 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002670
2671 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2672
Jiyong Parke59c3682018-09-11 23:10:25 +09002673 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002674 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002675 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002676 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002677}
2678
Jiyong Parke05195e2018-10-08 18:24:23 +09002679TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2680 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2681 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002682 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002683
2684 // use without import
2685 io_delegate_.SetFileContents("p/IFoo.aidl",
2686 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2687 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2688 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002689 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002690
Devin Moore7b8d5c92020-03-17 14:14:08 -07002691 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002692 io_delegate_.SetFileContents(
2693 "p/IFoo.aidl",
2694 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2695 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2696 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002697 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002698
2699 // use with import (as before)
2700 io_delegate_.SetFileContents("p/IFoo.aidl",
2701 "package p;"
2702 "import android.os.ParcelFileDescriptor;"
2703 "interface IFoo{"
2704 " void foo(in ParcelFileDescriptor fd);"
2705 "}");
2706 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2707 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002708 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002709}
Jiyong Parked65bf42018-08-28 15:43:27 +09002710
Jiyong Park3633b722019-04-11 15:38:26 +09002711TEST_F(AidlTest, ManualIds) {
2712 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2713 io_delegate_.SetFileContents("IFoo.aidl",
2714 "interface IFoo {\n"
2715 " void foo() = 0;\n"
2716 " void bar() = 1;\n"
2717 "}");
2718 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2719}
2720
2721TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2722 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2723 io_delegate_.SetFileContents("IFoo.aidl",
2724 "interface IFoo {\n"
2725 " void foo() = 0;\n"
2726 " void bar() = 1;\n"
2727 "}");
2728 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2729}
2730
2731TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002732 const string expected_stderr =
2733 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002734 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2735 io_delegate_.SetFileContents("IFoo.aidl",
2736 "interface IFoo {\n"
2737 " void foo() = 3;\n"
2738 " void bar() = 3;\n"
2739 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002740 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002741 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002742 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002743}
2744
2745TEST_F(AidlTest, FailOnOutOfRangeIds) {
2746 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002747 const string expected_stderr =
2748 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2749 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002750 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2751 io_delegate_.SetFileContents("IFoo.aidl",
2752 "interface IFoo {\n"
2753 " void foo() = 3;\n"
2754 " void bar() = 16777115;\n"
2755 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002756 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002757 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002758 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002759}
2760
2761TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002762 const string expected_stderr =
2763 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002764 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2765 io_delegate_.SetFileContents("IFoo.aidl",
2766 "interface IFoo {\n"
2767 " void foo() = 3;\n"
2768 " void bar();\n"
2769 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002770 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002771 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002772 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002773}
2774
Jiyong Parkc6816252019-07-08 08:12:28 +09002775TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2776 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2777 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2778 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2779 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2780}
2781
2782TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002783 const string expected_stderr =
2784 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2785 "dir/IBar.aidl\n"
2786 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002787 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002788
Jiyong Parkc6816252019-07-08 08:12:28 +09002789 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2790 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2791 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2792 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002793 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002794 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002795 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002796}
2797
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002798TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2799 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2800 "package a.b;\n"
2801 "import a.b.IBar;\n"
2802 "import a.b.IQux;\n"
2803 "interface IFoo { IQux foo(); }\n");
2804 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2805 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2806
2807 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2808 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2809
2810 string output;
2811 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2812 // IBar was imported but wasn't used. include is not expected.
2813 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2814 // IBar was imported and used. include is expected.
2815 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2816}
2817
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002818TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002819 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002820 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002821 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2822 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002823 interface IFoo {
2824 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002825 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002826 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002827 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002828 // JavaPassthrough should work with other types as well (e.g. enum)
2829 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2830 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2831 @JavaPassthrough(annotation="@com.android.AliceTwo")
2832 @Backing(type="byte")
2833 enum MyEnum {
2834 a, b, c
2835 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002836
Jooyung Han4cde01d2020-10-13 11:10:47 +09002837 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002838 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2839
2840 string java_out;
2841 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002842 // type-decl-level annotations with newline at the end
2843 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2844 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2845 // member-decl-level annotations with newline at the end
2846 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2847 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2848 // inline annotations with space at the end
2849 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002850
Jooyung Han4cde01d2020-10-13 11:10:47 +09002851 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2852 // type-decl-level annotations with newline at the end
2853 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2854 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2855
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002856 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002857 Options cpp_options =
2858 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002859 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2860
Jooyung Han4cde01d2020-10-13 11:10:47 +09002861 Options ndk_options =
2862 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002863 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002864
Jooyung Han4cde01d2020-10-13 11:10:47 +09002865 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002866 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002867}
2868
Andrei Homescue61feb52020-08-18 15:44:24 -07002869TEST_F(AidlTest, ParseRustDerive) {
2870 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2871 @RustDerive(Clone=true, Copy=false)
2872 parcelable Foo {
2873 int a;
2874 })");
2875
2876 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2877 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2878
2879 string rust_out;
2880 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2881 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2882
2883 // Other backends shouldn't be bothered
2884 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2885 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2886
2887 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2888 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2889
2890 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2891 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2892}
2893
Jiyong Park56f73d72019-06-11 12:20:28 +09002894class AidlOutputPathTest : public AidlTest {
2895 protected:
2896 void SetUp() override {
2897 AidlTest::SetUp();
2898 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2899 }
2900
2901 void Test(const Options& options, const std::string expected_output_path) {
2902 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2903 // check the existence
2904 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2905 }
2906};
2907
2908TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2909 // <out_dir> / <package_name> / <type_name>.java
2910 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2911}
2912
2913TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2914 // when output file is explicitly set, it is always respected. -o option is
2915 // ignored.
2916 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2917}
2918
2919TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2920 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2921}
2922
2923TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2924 // output is the same as the input file except for the suffix
2925 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2926}
2927
Devin Moore7b8d5c92020-03-17 14:14:08 -07002928TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002929 AidlError error;
2930 const string expected_stderr =
2931 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2932 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002933 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2934 R"(package p;
2935 interface IFoo {
2936 const int int32_max_oob = 2147483650;
2937 }
2938 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002939 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2941 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002942}
2943
Devin Moore7b8d5c92020-03-17 14:14:08 -07002944TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002945 AidlError error;
2946 const string expected_stderr =
2947 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2948 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002949 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2950 R"(package p;
2951 interface IFoo {
2952 const int int32_min_oob = -2147483650;
2953 }
2954 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002955 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002956 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2957 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002958}
2959
Devin Moore7b8d5c92020-03-17 14:14:08 -07002960TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002961 AidlError error;
2962 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002963 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002964 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002965 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2966 R"(package p;
2967 interface IFoo {
2968 const long int64_max_oob = 21474836509999999999999999;
2969 }
2970 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002971 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002972 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2973 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002974}
2975
Devin Moore7b8d5c92020-03-17 14:14:08 -07002976TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002977 AidlError error;
2978 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002979 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002980 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002981 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2982 R"(package p;
2983 interface IFoo {
2984 const long int64_min_oob = -21474836509999999999999999;
2985 }
2986 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002987 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002988 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2989 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002990}
2991
Devin Moore7b8d5c92020-03-17 14:14:08 -07002992TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002993 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002994 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09002995 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07002996 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2997 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002998 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2999 R"(package p;
3000 @Backing(type="byte")
3001 enum TestEnum {
3002 FOO = 127,
3003 BAR,
3004 }
3005 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003006 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003007 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003008 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003009}
3010
Devin Mooredecaf292020-04-30 09:16:40 -07003011TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3012 AidlError error;
3013 const string expected_stderr =
3014 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
3015 "be one of: type\n"
3016 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
3017 "be one of: type\n";
3018 CaptureStderr();
3019 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3020 R"(package p;
3021 @Backing(foo="byte")
3022 enum TestEnum {
3023 FOO = 1,
3024 BAR,
3025 }
3026 )",
3027 typenames_, GetLanguage(), &error));
3028 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3029 EXPECT_EQ(AidlError::BAD_TYPE, error);
3030}
3031
Jooyung Han66813932020-10-23 13:24:44 +09003032TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003033 io_delegate_.SetFileContents("Foo.aidl",
3034 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3035 "Map<String, Baz> d; Bar[] e; }");
3036 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3037 io_delegate_.SetFileContents("Baz.aidl",
3038 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003039 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3040 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3041}
3042
Jooyung Han66813932020-10-23 13:24:44 +09003043TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003044 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003045 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003046 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003047 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3048 "named 'bar'.\n";
3049 CaptureStderr();
3050 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3051 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3052 EXPECT_EQ(expected_error, GetCapturedStderr());
3053}
3054
3055TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3056 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3057 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3058 string expected_error =
3059 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003060 "named 'bar'.\n";
3061 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003062 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3063 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003064 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003065}
3066
Jooyung Han66813932020-10-23 13:24:44 +09003067TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003068 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003069 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3070 string expected_error =
3071 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3072 "only be an in parameter.\n";
3073 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003074 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3075 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003076 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003077}
3078
Jooyung Han66813932020-10-23 13:24:44 +09003079TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003080 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003081 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3082 string expected_error =
3083 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3084 "only be an in parameter.\n";
3085 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003086 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3087 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003088 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003089}
3090
Jooyung Han66813932020-10-23 13:24:44 +09003091TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003092 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003093 Options options = Options::From("aidl --lang=java Foo.aidl");
3094 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003095 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3096 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003097 CaptureStderr();
3098 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3099 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3100}
Devin Moore53fc99c2020-08-12 08:07:52 -07003101
Jooyung Han1f14ab32020-10-14 13:48:29 +09003102const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3103
3104#include <a/ByteEnum.h>
3105#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003106#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003107#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003108#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003109#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003110#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003111#include <locale>
3112#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003113#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003114#include <utility>
3115#include <variant>
3116#include <vector>
3117
Jooyung Handf39e192020-11-23 15:59:46 +09003118#ifndef __BIONIC__
3119#define __assert2(a,b,c,d) ((void)0)
3120#endif
3121
Jooyung Han1f14ab32020-10-14 13:48:29 +09003122namespace a {
3123
3124class Foo : public ::android::Parcelable {
3125public:
Jooyung Han97945de2020-10-15 16:41:38 +09003126 inline bool operator!=(const Foo& rhs) const {
3127 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003128 }
Jooyung Han97945de2020-10-15 16:41:38 +09003129 inline bool operator<(const Foo& rhs) const {
3130 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003131 }
Jooyung Han97945de2020-10-15 16:41:38 +09003132 inline bool operator<=(const Foo& rhs) const {
3133 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003134 }
Jooyung Han97945de2020-10-15 16:41:38 +09003135 inline bool operator==(const Foo& rhs) const {
3136 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003137 }
Jooyung Han97945de2020-10-15 16:41:38 +09003138 inline bool operator>(const Foo& rhs) const {
3139 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003140 }
Jooyung Han97945de2020-10-15 16:41:38 +09003141 inline bool operator>=(const Foo& rhs) const {
3142 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003143 }
Jooyung Han97945de2020-10-15 16:41:38 +09003144
Jooyung Han1f14ab32020-10-14 13:48:29 +09003145 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003146 ns = 0, // int[] ns;
3147 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003148 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003149 };
Jooyung Han97945de2020-10-15 16:41:38 +09003150
Jooyung Han1f14ab32020-10-14 13:48:29 +09003151 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003152 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003153
3154 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003155 Foo(const Foo&) = default;
3156 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003157 Foo& operator=(const Foo&) = default;
3158 Foo& operator=(Foo&&) = default;
3159
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003160 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3161 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003162 constexpr Foo(_Tp&& _arg)
3163 : _value(std::forward<_Tp>(_arg)) {}
3164
3165 template <typename... _Tp>
3166 constexpr explicit Foo(_Tp&&... _args)
3167 : _value(std::forward<_Tp>(_args)...) {}
3168
3169 template <Tag _tag, typename... _Tp>
3170 static Foo make(_Tp&&... _args) {
3171 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003172 }
Jooyung Han97945de2020-10-15 16:41:38 +09003173
3174 template <Tag _tag, typename _Tp, typename... _Up>
3175 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3176 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003177 }
3178
3179 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003180 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003181 }
3182
Jooyung Han97945de2020-10-15 16:41:38 +09003183 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003184 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003185 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003186 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003187 }
3188
Jooyung Han97945de2020-10-15 16:41:38 +09003189 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003190 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003191 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003192 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003193 }
3194
Jooyung Han97945de2020-10-15 16:41:38 +09003195 template <Tag _tag, typename... _Tp>
3196 void set(_Tp&&... _args) {
3197 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003198 }
3199
3200 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3201 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3202 static const std::string& getParcelableDescriptor() {
3203 static const std::string DESCIPTOR = "a.Foo";
3204 return DESCIPTOR;
3205 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003206 template <typename _T> class _has_toString {
3207 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3208 template <typename _U> static std::false_type __has_toString(...);
3209 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3210 };
3211 template <typename _T> inline static std::string _call_toString(const _T& t) {
3212 if constexpr (_has_toString<_T>::value) return t.toString();
3213 return "{no toString() implemented}";
3214 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003215 inline std::string toString() const {
3216 std::ostringstream os;
3217 os << "Foo{";
3218 switch (getTag()) {
3219 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3220 case e: os << "e: " << a::toString(get<e>()); break;
3221 case pfd: os << "pfd: " << ""; break;
3222 }
3223 os << "}";
3224 return os.str();
3225 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003226private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003227 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003228}; // class Foo
3229
3230} // namespace a
3231)";
3232
3233const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3234
3235namespace a {
3236
3237::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3238 ::android::status_t _aidl_ret_status;
3239 int32_t _aidl_tag;
3240 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3241 switch (_aidl_tag) {
3242 case ns: {
3243 ::std::vector<int32_t> _aidl_value;
3244 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003245 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3246 set<ns>(_aidl_value);
3247 } else {
3248 // NOLINTNEXTLINE(performance-move-const-arg)
3249 set<ns>(std::move(_aidl_value));
3250 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003251 return ::android::OK; }
3252 case e: {
3253 ::a::ByteEnum _aidl_value;
3254 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003255 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3256 set<e>(_aidl_value);
3257 } else {
3258 // NOLINTNEXTLINE(performance-move-const-arg)
3259 set<e>(std::move(_aidl_value));
3260 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003261 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003262 case pfd: {
3263 ::android::os::ParcelFileDescriptor _aidl_value;
3264 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003265 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3266 set<pfd>(_aidl_value);
3267 } else {
3268 // NOLINTNEXTLINE(performance-move-const-arg)
3269 set<pfd>(std::move(_aidl_value));
3270 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003271 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003272 }
3273 return ::android::BAD_VALUE;
3274}
3275
3276::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3277 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3278 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3279 switch (getTag()) {
3280 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3281 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003282 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003283 }
Jooyung Handf39e192020-11-23 15:59:46 +09003284 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003285}
3286
3287} // namespace a
3288)";
3289
Jooyung Han6beac042020-10-17 21:59:43 +09003290const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3291#include <android/binder_interface_utils.h>
3292#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003293#include <codecvt>
3294#include <locale>
3295#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003296
Jooyung Handf39e192020-11-23 15:59:46 +09003297#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003298#include <type_traits>
3299#include <utility>
3300#include <variant>
3301#include <cstdint>
3302#include <memory>
3303#include <optional>
3304#include <string>
3305#include <vector>
3306#ifdef BINDER_STABILITY_SUPPORT
3307#include <android/binder_stability.h>
3308#endif // BINDER_STABILITY_SUPPORT
3309#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003310
3311#ifndef __BIONIC__
3312#define __assert2(a,b,c,d) ((void)0)
3313#endif
3314
Jooyung Han6beac042020-10-17 21:59:43 +09003315namespace aidl {
3316namespace a {
3317class Foo {
3318public:
3319 typedef std::false_type fixed_size;
3320 static const char* descriptor;
3321
3322 enum Tag : int32_t {
3323 ns = 0, // int[] ns;
3324 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003325 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003326 };
3327
3328 template<typename _Tp>
3329 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3330
3331 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3332 Foo(const Foo&) = default;
3333 Foo(Foo&&) = default;
3334 Foo& operator=(const Foo&) = default;
3335 Foo& operator=(Foo&&) = default;
3336
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003337 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3338 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003339 constexpr Foo(_Tp&& _arg)
3340 : _value(std::forward<_Tp>(_arg)) {}
3341
3342 template <typename... _Tp>
3343 constexpr explicit Foo(_Tp&&... _args)
3344 : _value(std::forward<_Tp>(_args)...) {}
3345
3346 template <Tag _tag, typename... _Tp>
3347 static Foo make(_Tp&&... _args) {
3348 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3349 }
3350
3351 template <Tag _tag, typename _Tp, typename... _Up>
3352 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3353 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3354 }
3355
3356 Tag getTag() const {
3357 return static_cast<Tag>(_value.index());
3358 }
3359
3360 template <Tag _tag>
3361 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003362 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003363 return std::get<_tag>(_value);
3364 }
3365
3366 template <Tag _tag>
3367 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003368 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003369 return std::get<_tag>(_value);
3370 }
3371
3372 template <Tag _tag, typename... _Tp>
3373 void set(_Tp&&... _args) {
3374 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3375 }
3376
3377 binder_status_t readFromParcel(const AParcel* _parcel);
3378 binder_status_t writeToParcel(AParcel* _parcel) const;
Steven Morelandf58804a2020-12-07 18:12:15 +00003379
3380 inline bool operator!=(const Foo& rhs) const {
3381 return _value != rhs._value;
3382 }
3383 inline bool operator<(const Foo& rhs) const {
3384 return _value < rhs._value;
3385 }
3386 inline bool operator<=(const Foo& rhs) const {
3387 return _value <= rhs._value;
3388 }
3389 inline bool operator==(const Foo& rhs) const {
3390 return _value == rhs._value;
3391 }
3392 inline bool operator>(const Foo& rhs) const {
3393 return _value > rhs._value;
3394 }
3395 inline bool operator>=(const Foo& rhs) const {
3396 return _value >= rhs._value;
3397 }
3398
Jooyung Han6beac042020-10-17 21:59:43 +09003399 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003400 template <typename _T> class _has_toString {
3401 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3402 template <typename _U> static std::false_type __has_toString(...);
3403 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3404 };
3405 template <typename _T> inline static std::string _call_toString(const _T& t) {
3406 if constexpr (_has_toString<_T>::value) return t.toString();
3407 return "{no toString() implemented}";
3408 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003409 inline std::string toString() const {
3410 std::ostringstream os;
3411 os << "Foo{";
3412 switch (getTag()) {
3413 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3414 case e: os << "e: " << a::toString(get<e>()); break;
3415 case pfd: os << "pfd: " << ""; break;
3416 }
3417 os << "}";
3418 return os.str();
3419 }
Jooyung Han6beac042020-10-17 21:59:43 +09003420private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003421 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003422};
3423} // namespace a
3424} // namespace aidl
3425)";
3426
3427const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3428
3429#include <android/binder_parcel_utils.h>
3430
3431namespace aidl {
3432namespace a {
3433const char* Foo::descriptor = "a.Foo";
3434
3435binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3436 binder_status_t _aidl_ret_status;
3437 int32_t _aidl_tag;
3438 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3439 switch (_aidl_tag) {
3440 case ns: {
3441 std::vector<int32_t> _aidl_value;
3442 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003443 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3444 set<ns>(_aidl_value);
3445 } else {
3446 // NOLINTNEXTLINE(performance-move-const-arg)
3447 set<ns>(std::move(_aidl_value));
3448 }
Jooyung Han6beac042020-10-17 21:59:43 +09003449 return STATUS_OK; }
3450 case e: {
3451 ::aidl::a::ByteEnum _aidl_value;
3452 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003453 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3454 set<e>(_aidl_value);
3455 } else {
3456 // NOLINTNEXTLINE(performance-move-const-arg)
3457 set<e>(std::move(_aidl_value));
3458 }
Jooyung Han6beac042020-10-17 21:59:43 +09003459 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003460 case pfd: {
3461 ::ndk::ScopedFileDescriptor _aidl_value;
3462 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003463 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3464 set<pfd>(_aidl_value);
3465 } else {
3466 // NOLINTNEXTLINE(performance-move-const-arg)
3467 set<pfd>(std::move(_aidl_value));
3468 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003469 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003470 }
3471 return STATUS_BAD_VALUE;
3472}
3473binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3474 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3475 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3476 switch (getTag()) {
3477 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3478 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003479 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003480 }
Jooyung Handf39e192020-11-23 15:59:46 +09003481 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003482}
3483
3484} // namespace a
3485} // namespace aidl
3486)";
3487
Jooyung Han1f14ab32020-10-14 13:48:29 +09003488const char kUnionExampleExpectedOutputJava[] = R"(/*
3489 * This file is auto-generated. DO NOT MODIFY.
3490 */
3491package a;
3492
3493
3494public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003495 // tags for union fields
3496 public final static int ns = 0; // int[] ns;
3497 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003498 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003499
3500 private int _tag;
3501 private Object _value;
3502
3503 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003504 int[] _value = {42};
3505 this._tag = ns;
3506 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003507 }
Jooyung Han97945de2020-10-15 16:41:38 +09003508
Jooyung Han1f14ab32020-10-14 13:48:29 +09003509 private Foo(android.os.Parcel _aidl_parcel) {
3510 readFromParcel(_aidl_parcel);
3511 }
Jooyung Han97945de2020-10-15 16:41:38 +09003512
Jooyung Hance62f932020-10-25 10:21:49 +09003513 private Foo(int _tag, Object _value) {
3514 this._tag = _tag;
3515 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003516 }
3517
3518 public int getTag() {
3519 return _tag;
3520 }
3521
Jooyung Han97945de2020-10-15 16:41:38 +09003522 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003523
3524 public static Foo ns(int[] _value) {
3525 return new Foo(ns, _value);
3526 }
Jooyung Han97945de2020-10-15 16:41:38 +09003527
Jooyung Han1f14ab32020-10-14 13:48:29 +09003528 public int[] getNs() {
3529 _assertTag(ns);
3530 return (int[]) _value;
3531 }
Jooyung Han97945de2020-10-15 16:41:38 +09003532
Jooyung Han1f14ab32020-10-14 13:48:29 +09003533 public void setNs(int[] _value) {
3534 _set(ns, _value);
3535 }
3536
Jooyung Han97945de2020-10-15 16:41:38 +09003537 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003538
3539 public static Foo e(byte _value) {
3540 return new Foo(e, _value);
3541 }
Jooyung Han97945de2020-10-15 16:41:38 +09003542
Jooyung Han1f14ab32020-10-14 13:48:29 +09003543 public byte getE() {
3544 _assertTag(e);
3545 return (byte) _value;
3546 }
Jooyung Han97945de2020-10-15 16:41:38 +09003547
Jooyung Han1f14ab32020-10-14 13:48:29 +09003548 public void setE(byte _value) {
3549 _set(e, _value);
3550 }
3551
Jooyung Hand2fa0232020-10-19 02:51:41 +09003552 // ParcelFileDescriptor pfd;
3553
3554 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3555 return new Foo(pfd, _value);
3556 }
3557
3558 public android.os.ParcelFileDescriptor getPfd() {
3559 _assertTag(pfd);
3560 return (android.os.ParcelFileDescriptor) _value;
3561 }
3562
3563 public void setPfd(android.os.ParcelFileDescriptor _value) {
3564 _set(pfd, _value);
3565 }
3566
Jooyung Han1f14ab32020-10-14 13:48:29 +09003567 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3568 @Override
3569 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003570 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003571 }
3572 @Override
3573 public Foo[] newArray(int _aidl_size) {
3574 return new Foo[_aidl_size];
3575 }
3576 };
Jooyung Han97945de2020-10-15 16:41:38 +09003577
Jooyung Han1f14ab32020-10-14 13:48:29 +09003578 @Override
3579 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3580 _aidl_parcel.writeInt(_tag);
3581 switch (_tag) {
3582 case ns:
3583 _aidl_parcel.writeIntArray(getNs());
3584 break;
3585 case e:
3586 _aidl_parcel.writeByte(getE());
3587 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003588 case pfd:
3589 if ((getPfd()!=null)) {
3590 _aidl_parcel.writeInt(1);
3591 getPfd().writeToParcel(_aidl_parcel, 0);
3592 }
3593 else {
3594 _aidl_parcel.writeInt(0);
3595 }
3596 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003597 }
3598 }
Jooyung Han97945de2020-10-15 16:41:38 +09003599
Jooyung Han1f14ab32020-10-14 13:48:29 +09003600 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3601 int _aidl_tag;
3602 _aidl_tag = _aidl_parcel.readInt();
3603 switch (_aidl_tag) {
3604 case ns: {
3605 int[] _aidl_value;
3606 _aidl_value = _aidl_parcel.createIntArray();
3607 _set(_aidl_tag, _aidl_value);
3608 return; }
3609 case e: {
3610 byte _aidl_value;
3611 _aidl_value = _aidl_parcel.readByte();
3612 _set(_aidl_tag, _aidl_value);
3613 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003614 case pfd: {
3615 android.os.ParcelFileDescriptor _aidl_value;
3616 if ((0!=_aidl_parcel.readInt())) {
3617 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3618 }
3619 else {
3620 _aidl_value = null;
3621 }
3622 _set(_aidl_tag, _aidl_value);
3623 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003624 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003625 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003626 }
Jooyung Han97945de2020-10-15 16:41:38 +09003627
Jooyung Han1f14ab32020-10-14 13:48:29 +09003628 @Override
3629 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003630 int _mask = 0;
3631 switch (getTag()) {
3632 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003633 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003634 break;
3635 }
3636 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003637 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003638 private int describeContents(Object _v) {
3639 if (_v == null) return 0;
3640 if (_v instanceof android.os.Parcelable) {
3641 return ((android.os.Parcelable) _v).describeContents();
3642 }
3643 return 0;
3644 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003645
3646 private void _assertTag(int tag) {
3647 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003648 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003649 }
3650 }
Jooyung Han97945de2020-10-15 16:41:38 +09003651
Jooyung Han1f14ab32020-10-14 13:48:29 +09003652 private String _tagString(int _tag) {
3653 switch (_tag) {
3654 case ns: return "ns";
3655 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003656 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003657 }
3658 throw new IllegalStateException("unknown field: " + _tag);
3659 }
Jooyung Han97945de2020-10-15 16:41:38 +09003660
Jooyung Hance62f932020-10-25 10:21:49 +09003661 private void _set(int _tag, Object _value) {
3662 this._tag = _tag;
3663 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003664 }
3665}
3666)";
3667
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003668const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3669pub enum Foo {
3670 Ns(Vec<i32>),
3671 E(crate::mangled::_1_a_8_ByteEnum),
3672 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3673}
3674pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3675impl Default for Foo {
3676 fn default() -> Self {
3677 Self::Ns(vec!{42})
3678 }
3679}
3680impl binder::parcel::Serialize for Foo {
3681 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3682 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3683 }
3684}
3685impl binder::parcel::SerializeArray for Foo {}
3686impl binder::parcel::SerializeOption for Foo {
3687 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3688 let this = if let Some(this) = this {
3689 parcel.write(&1i32)?;
3690 this
3691 } else {
3692 return parcel.write(&0i32);
3693 };
3694 match this {
3695 Self::Ns(v) => {
3696 parcel.write(&0i32)?;
3697 parcel.write(v)
3698 }
3699 Self::E(v) => {
3700 parcel.write(&1i32)?;
3701 parcel.write(v)
3702 }
3703 Self::Pfd(v) => {
3704 parcel.write(&2i32)?;
3705 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3706 parcel.write(__field_ref)
3707 }
3708 }
3709 }
3710}
3711impl binder::parcel::Deserialize for Foo {
3712 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3713 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3714 .transpose()
3715 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3716 }
3717}
3718impl binder::parcel::DeserializeArray for Foo {}
3719impl binder::parcel::DeserializeOption for Foo {
3720 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3721 let status: i32 = parcel.read()?;
3722 if status == 0 { return Ok(None); }
3723 let tag: i32 = parcel.read()?;
3724 match tag {
3725 0 => {
3726 let value: Vec<i32> = parcel.read()?;
3727 Ok(Some(Self::Ns(value)))
3728 }
3729 1 => {
3730 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3731 Ok(Some(Self::E(value)))
3732 }
3733 2 => {
3734 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3735 Ok(Some(Self::Pfd(value)))
3736 }
3737 _ => {
3738 Err(binder::StatusCode::BAD_VALUE)
3739 }
3740 }
3741 }
3742}
3743)";
3744
Jooyung Han97945de2020-10-15 16:41:38 +09003745struct AidlUnionTest : ::testing::Test {
3746 void SetUp() override {
3747 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003748package a;
3749import a.ByteEnum;
3750union Foo {
3751 int[] ns = {42};
3752 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003753 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003754}
3755)");
Jooyung Han97945de2020-10-15 16:41:38 +09003756 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003757package a;
3758@Backing(type="byte")
3759enum ByteEnum {
3760 a, b, c
3761}
3762)");
Jooyung Han97945de2020-10-15 16:41:38 +09003763 }
3764 FakeIoDelegate io_delegate_;
3765 void Compile(string lang) {
3766 string command = "aidl --structured -I. -o out --lang=" + lang;
3767 if (lang == "cpp" || lang == "ndk") {
3768 command += " -h out";
3769 }
3770 command += " a/Foo.aidl";
3771 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003772 CaptureStderr();
3773 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3774 auto err = GetCapturedStderr();
3775 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003776 }
3777 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3778 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003779 string actual;
3780 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3781 EXPECT_EQ(expected, actual);
3782 }
Jooyung Han97945de2020-10-15 16:41:38 +09003783 }
3784};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003785
Jooyung Han97945de2020-10-15 16:41:38 +09003786TEST_F(AidlUnionTest, Example_Cpp) {
3787 Compile("cpp");
3788 EXPECT_COMPILE_OUTPUTS(
3789 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3790 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3791}
3792
Jooyung Han6beac042020-10-17 21:59:43 +09003793TEST_F(AidlUnionTest, Example_Ndk) {
3794 Compile("ndk");
3795 EXPECT_COMPILE_OUTPUTS(
3796 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3797 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3798}
3799
Jooyung Han97945de2020-10-15 16:41:38 +09003800TEST_F(AidlUnionTest, Example_Java) {
3801 Compile("java");
3802 EXPECT_COMPILE_OUTPUTS(
3803 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003804}
3805
3806TEST_F(AidlUnionTest, Example_Rust) {
3807 Compile("rust");
3808 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003809}
3810
Jooyung Hanfe89f122020-10-14 03:49:18 +09003811TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3812 const string method = "package a; union Foo {}";
3813 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3814 CaptureStderr();
3815 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3816 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3817}
3818
3819TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3820 const string method = "package a; union Foo { ParcelableHolder x; }";
3821 const string expected_stderr =
3822 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3823 CaptureStderr();
3824 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3825 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3826}
3827
Devin Moore53fc99c2020-08-12 08:07:52 -07003828TEST_P(AidlTest, GenericStructuredParcelable) {
3829 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3830 Options options =
3831 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3832 const string expected_stderr = "";
3833 CaptureStderr();
3834 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3835 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3836}
3837
Jooyung Han3f347ca2020-12-01 12:41:50 +09003838TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3839 io_delegate_.SetFileContents("Foo.aidl",
3840 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3841 Options options =
3842 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::CPP) +
3843 " -o out -h out");
3844 const string expected_stderr = "";
3845 CaptureStderr();
3846 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3847 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3848
3849 string code;
3850 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3851 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3852const ::android::String16& Foo<T,U>::s() {
3853 static const ::android::String16 value(::android::String16(""));
3854 return value;
3855})--"));
3856}
3857
3858TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3859 io_delegate_.SetFileContents("Foo.aidl",
3860 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3861 Options options =
3862 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::NDK) +
3863 " -o out -h out");
3864 const string expected_stderr = "";
3865 CaptureStderr();
3866 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3867 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3868
3869 string code;
3870 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3871 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3872const char* Foo<T, U>::s = "";
3873)--"));
3874}
3875
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003876TEST_F(AidlTest, NestedTypeArgs) {
3877 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003878 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3879
3880 io_delegate_.SetFileContents("a/Foo.aidl",
3881 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3882 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003883 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3884 const string expected_stderr = "";
3885 CaptureStderr();
3886 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3887 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3888
3889 string code;
3890 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003891 EXPECT_THAT(code,
3892 testing::HasSubstr(
3893 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3894}
3895
3896TEST_F(AidlTest, DoubleArrayError) {
3897 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3898
3899 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3900 const string expected_stderr =
3901 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3902 CaptureStderr();
3903 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3904 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3905}
3906
3907TEST_F(AidlTest, DoubleGenericError) {
3908 io_delegate_.SetFileContents("a/Bar.aidl",
3909 "package a; parcelable Bar { List<String><String> a; }");
3910
3911 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3912 const string expected_stderr =
3913 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3914 CaptureStderr();
3915 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3916 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3917}
3918
3919TEST_F(AidlTest, ArrayBeforeGenericError) {
3920 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3921
3922 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3923 const string expected_stderr =
3924 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3925 CaptureStderr();
3926 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3927 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003928}
3929
Jooyung Han14004ed2020-10-16 03:49:57 +09003930struct GenericAidlTest : ::testing::Test {
3931 FakeIoDelegate io_delegate_;
3932 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003933 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003934 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3935 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3936 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3937
3938 Options options = Options::From(cmd);
3939 CaptureStderr();
3940 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3941 EXPECT_EQ("", GetCapturedStderr());
3942 }
3943};
3944
3945TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3946 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3947 string code;
3948 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3949 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3950 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3951 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3952}
3953
3954TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3955 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3956 string code;
3957 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3958 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3959 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3960 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3961}
3962
Devin Moore53fc99c2020-08-12 08:07:52 -07003963TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
3964 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
3965 Options options =
3966 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3967 const string expected_stderr =
3968 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
3969 CaptureStderr();
3970 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3971 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3972}
3973
3974TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
3975 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
3976 Options options =
3977 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3978 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
3979 CaptureStderr();
3980 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3981 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3982}
3983
Jooyung Han7a308842020-10-27 19:06:49 +09003984TEST_P(AidlTest, LongCommentWithinConstExpression) {
3985 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
3986 Options options =
3987 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3988 CaptureStderr();
3989 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3990 EXPECT_EQ("", GetCapturedStderr());
3991}
3992
Jeongik Chaef44e622020-10-23 16:00:52 +09003993TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
3994 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
3995 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
3996 std::string expectedErr =
3997 "ERROR: a/Foo.aidl:1.28-30: "
3998 "Encountered an untyped List or Map. The use of untyped List/Map is "
3999 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4000 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4001 "ERROR: a/Foo.aidl:1.35-37: "
4002 "Encountered an untyped List or Map. The use of untyped List/Map is "
4003 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4004 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4005 CaptureStderr();
4006 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4007 EXPECT_EQ(expectedErr, GetCapturedStderr());
4008}
4009
4010TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004011 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4012 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004013 std::string expectedErr =
4014 "ERROR: a/Foo.aidl:1.33-35: "
4015 "Encountered an untyped List or Map. The use of untyped List/Map is "
4016 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4017 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4018 "ERROR: a/Foo.aidl:1.40-42: "
4019 "Encountered an untyped List or Map. The use of untyped List/Map is "
4020 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4021 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004022 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09004023 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4024 EXPECT_EQ(expectedErr, GetCapturedStderr());
4025}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004026
Jeongik Chaef44e622020-10-23 16:00:52 +09004027TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4028 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4029 io_delegate_.SetFileContents(
4030 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4031 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4032 std::string expectedErr =
4033 "ERROR: a/Foo.aidl:1.52-54: "
4034 "Encountered an untyped List or Map. The use of untyped List/Map is "
4035 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4036 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4037 "ERROR: a/Foo.aidl:1.64-66: "
4038 "Encountered an untyped List or Map. The use of untyped List/Map is "
4039 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4040 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4041 CaptureStderr();
4042 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4043 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004044}
4045
Jooyung Han690f5842020-12-04 13:02:04 +09004046TEST_F(AidlTest, EnumWithDefaults_Java) {
4047 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4048 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4049package p;
4050import p.Enum;
4051parcelable Foo {
4052 Enum e = Enum.BAR;
4053})");
4054 CaptureStderr();
4055 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
4056 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4057 auto err = GetCapturedStderr();
4058 EXPECT_EQ("", err);
4059
4060 string code;
4061 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
4062 EXPECT_THAT(code, testing::HasSubstr("byte e = Enum.BAR"));
4063}
4064
4065TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4066 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4067 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4068package p;
4069import p.Enum;
4070parcelable Foo {
4071 Enum e = Enum.BAR;
4072})");
4073 CaptureStderr();
4074 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
4075 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4076 auto err = GetCapturedStderr();
4077 EXPECT_EQ("", err);
4078
4079 string code;
4080 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4081 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4082}
4083
4084TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4085 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4086 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4087package p;
4088import p.Enum;
4089parcelable Foo {
4090 Enum e = Enum.BAR;
4091})");
4092 CaptureStderr();
4093 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4094 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4095 auto err = GetCapturedStderr();
4096 EXPECT_EQ("", err);
4097
4098 string code;
4099 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4100 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4101}
4102
4103TEST_F(AidlTest, EnumWithDefaults_Rust) {
4104 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4105 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4106package p;
4107import p.Enum;
4108parcelable Foo {
4109 int n = 42;
4110 Enum e = Enum.BAR;
4111})");
4112 CaptureStderr();
4113 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
4114 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4115 auto err = GetCapturedStderr();
4116 EXPECT_EQ("", err);
4117
4118 string code;
4119 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4120 EXPECT_THAT(code, testing::HasSubstr(R"(
4121 fn default() -> Self {
4122 Self {
4123 n: 42,
4124 e: crate::mangled::_1_p_4_Enum::BAR,
4125 }
4126 })"));
4127}
4128
4129TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4130 import_paths_.insert("a");
4131 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4132 CaptureStderr();
4133 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4134package p;
4135import p.Enum;
4136parcelable Foo {
4137 int e = Enum.FOO | Enum.BAR;
4138})",
4139 typenames_, GetLanguage());
4140 auto err = GetCapturedStderr();
4141 EXPECT_EQ("", err);
4142 EXPECT_TRUE(type);
4143 const auto& fields = type->AsStructuredParcelable()->GetFields();
4144 EXPECT_EQ("int e = 3", fields[0]->ToString());
4145}
4146
4147TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4148 CaptureStderr();
4149 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4150@Backing(type="int")
4151enum Foo {
4152 STANDARD_SHIFT = 16,
4153 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4154 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4155}
4156)",
4157 typenames_, GetLanguage());
4158 auto err = GetCapturedStderr();
4159 EXPECT_EQ("", err);
4160 EXPECT_TRUE(type);
4161 const auto& enum_type = type->AsEnumDeclaration();
4162 string code;
4163 enum_type->Dump(CodeWriter::ForString(&code).get());
4164 EXPECT_EQ(R"--(@Backing(type="int")
4165enum Foo {
4166 STANDARD_SHIFT = 16,
4167 STANDARD_BT709 = 65536,
4168 STANDARD_BT601_625 = 131072,
4169}
4170)--",
4171 code);
4172}
4173
4174TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4175 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4176 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4177package p;
4178import p.Enum;
4179parcelable Foo {
4180 Enum e = Enum.FOO | Enum.BAR;
4181})");
4182 CaptureStderr();
4183 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
4184 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4185 auto err = GetCapturedStderr();
4186 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4187 err);
4188}
4189
4190TEST_P(AidlTest, DefaultWithEmptyArray) {
4191 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4192 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4193 CaptureStderr();
4194 auto options = Options::From("aidl -I a --lang " + Options::LanguageToString(GetLanguage()) +
4195 " -o out -h out a/p/Foo.aidl");
4196 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4197 auto err = GetCapturedStderr();
4198 EXPECT_EQ("", err);
4199}
4200
4201TEST_P(AidlTest, RejectRefsInAnnotation) {
4202 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4203 "package p; interface IFoo {\n"
4204 " const String ANNOTATION = \"@Annotation\";\n"
4205 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4206 "}");
4207 CaptureStderr();
4208 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4209 " -o out -h out a/p/IFoo.aidl");
4210 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4211 auto err = GetCapturedStderr();
4212 EXPECT_EQ(
4213 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4214 "ANNOTATION.\n",
4215 err);
4216}
4217
4218TEST_F(AidlTest, DefaultWithEnumValues) {
4219 io_delegate_.SetFileContents(
4220 "a/p/Foo.aidl",
4221 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4222 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4223 CaptureStderr();
4224 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4225 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4226 auto err = GetCapturedStderr();
4227 EXPECT_EQ("", err);
4228 string code;
4229 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4230 EXPECT_THAT(
4231 code, testing::HasSubstr(
4232 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4233}
4234
Jooyung Han14259392020-12-07 10:00:08 +09004235TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4236 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4237 CaptureStderr();
4238 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4239 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4240 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004241 EXPECT_EQ(
4242 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
4243 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
4244 err);
Jooyung Han14259392020-12-07 10:00:08 +09004245}
4246
4247TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4248 io_delegate_.SetFileContents("a/p/Foo.aidl",
4249 "package p; parcelable Foo { const int A = A + 1; }");
4250 CaptureStderr();
4251 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4252 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4253 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004254 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4255}
4256
4257TEST_F(AidlTest, RecursiveReferences) {
4258 io_delegate_.SetFileContents("a/p/Foo.aidl",
4259 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4260 io_delegate_.SetFileContents("a/p/Bar.aidl",
4261 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4262 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4263 CaptureStderr();
4264 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4265 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4266 EXPECT_EQ("", GetCapturedStderr());
4267}
4268
4269TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4270 string contents = R"(
4271import android.os.IBinder;
4272import android.os.IInterface;
4273interface IFoo {}
4274 )";
4275 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004276}
4277
Jooyung Hane87cdd02020-12-11 16:47:35 +09004278struct ListTypeParam {
4279 string kind;
4280 string literal;
4281};
4282
4283const ListTypeParam kListTypeParams[] = {
4284 {"primitive", "int"}, {"String", "String"},
4285 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4286 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4287 {"union", "a.Union"}, {"interface", "a.IBar"},
4288};
4289
4290const std::map<std::string, std::string> kListSupportExpectations = {
4291 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4292 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4293 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4294 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
4295 {"cpp_String", ""},
4296 {"java_String", ""},
4297 {"ndk_String", ""},
4298 {"rust_String", ""},
4299 {"cpp_IBinder", ""},
4300 {"java_IBinder", ""},
4301 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4302 {"rust_IBinder", ""},
4303 {"cpp_ParcelFileDescriptor", "List<ParcelFileDescriptor> is not supported."},
4304 {"java_ParcelFileDescriptor", ""},
4305 {"ndk_ParcelFileDescriptor", ""},
4306 {"rust_ParcelFileDescriptor", ""},
4307 {"cpp_interface",
4308 "List<a.IBar> is not supported. List in cpp supports only String and IBinder."},
4309 {"java_interface",
4310 "List<a.IBar> is not supported. List in Java supports only String, IBinder, and "
4311 "ParcelFileDescriptor."},
4312 {"ndk_interface", "List<a.IBar> is not supported. List in NDK doesn't support interface."},
4313 {"rust_interface", ""},
4314 {"cpp_parcelable",
4315 "List<a.Foo> is not supported. List in cpp supports only String and IBinder."},
4316 {"java_parcelable", ""},
4317 {"ndk_parcelable", ""},
4318 {"rust_parcelable", ""},
4319 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4320 {"java_enum", "A generic type cannot have any primitive type parameters."},
4321 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4322 {"rust_enum", "A generic type cannot have any primitive type parameters."},
4323 {"cpp_union", "List<a.Union> is not supported. List in cpp supports only String and IBinder."},
4324 {"java_union", ""},
4325 {"ndk_union", ""},
4326 {"rust_union", ""},
4327};
4328
4329using AidlListTestParam = std::tuple<Options::Language, ListTypeParam>;
4330
4331class AidlListTest : public testing::TestWithParam<AidlListTestParam> {
4332 public:
4333 void SetUp() override {
4334 const auto& param = GetParam();
4335 const auto& lang = Options::LanguageToString(std::get<0>(param));
4336 const auto& kind = std::get<1>(param).kind;
4337
4338 FakeIoDelegate io;
4339 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4340 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4341 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
4342 io.SetFileContents("a/Foo.aidl", fmt::format(R"(
4343 package a;
4344 parcelable Foo {{
4345 List<{}> list;
4346 }})",
4347 std::get<1>(param).literal));
4348
4349 const auto options =
4350 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4351 CaptureStderr();
4352 compile_aidl(options, io);
4353 auto it = kListSupportExpectations.find(lang + "_" + kind);
4354 EXPECT_TRUE(it != kListSupportExpectations.end());
4355 const string err = GetCapturedStderr();
4356 if (it->second.empty()) {
4357 EXPECT_EQ("", err);
4358 } else {
4359 EXPECT_THAT(err, testing::HasSubstr(it->second));
4360 }
4361 }
4362};
4363
4364INSTANTIATE_TEST_SUITE_P(
4365 AidlTestSuite, AidlListTest,
4366 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4367 Options::Language::NDK, Options::Language::RUST),
4368 testing::ValuesIn(kListTypeParams)),
4369 [](const testing::TestParamInfo<AidlListTestParam>& info) {
4370 return Options::LanguageToString(std::get<0>(info.param)) + "_" +
4371 std::get<1>(info.param).kind;
4372 });
4373
4374TEST_P(AidlListTest, SupportedTypes) {}
4375
Christopher Wiley90be4e32015-10-20 14:55:25 -07004376} // namespace aidl
4377} // namespace android