blob: d30a63e7259d0a6f1c69cc85d819db3e792ec67d [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070046using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090047using testing::internal::CaptureStderr;
48using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070049
50namespace android {
51namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070052namespace {
53
54const char kExpectedDepFileContents[] =
55R"(place/for/output/p/IFoo.java : \
56 p/IFoo.aidl
57
58p/IFoo.aidl :
59)";
60
Dan Willemsen93298ee2016-11-10 23:55:55 -080061const char kExpectedNinjaDepFileContents[] =
62R"(place/for/output/p/IFoo.java : \
63 p/IFoo.aidl
64)";
65
Jiyong Parkdf202122019-09-30 20:48:35 +090066const char kExpectedParcelableDeclarationDepFileContents[] =
67 R"( : \
68 p/Foo.aidl
69
70p/Foo.aidl :
71)";
72
73const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080074 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070075 p/Foo.aidl
76
77p/Foo.aidl :
78)";
79
Jooyung Hand2fa0232020-10-19 02:51:41 +090080const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090081 R"(/*
82 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090083 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080084@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090085public class Rect implements android.os.Parcelable
86{
87 // Comment
88
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080089 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090090 public int x = 5;
91
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080092 @android.annotation.Hide
93 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000094 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090095
96 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090097
98 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090099 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
100 @Override
101 public Rect createFromParcel(android.os.Parcel _aidl_source) {
102 Rect _aidl_out = new Rect();
103 _aidl_out.readFromParcel(_aidl_source);
104 return _aidl_out;
105 }
106 @Override
107 public Rect[] newArray(int _aidl_size) {
108 return new Rect[_aidl_size];
109 }
110 };
111 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
112 {
113 int _aidl_start_pos = _aidl_parcel.dataPosition();
114 _aidl_parcel.writeInt(0);
115 _aidl_parcel.writeInt(x);
116 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900117 if ((fd!=null)) {
118 _aidl_parcel.writeInt(1);
119 fd.writeToParcel(_aidl_parcel, 0);
120 }
121 else {
122 _aidl_parcel.writeInt(0);
123 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900124 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900125 int _aidl_end_pos = _aidl_parcel.dataPosition();
126 _aidl_parcel.setDataPosition(_aidl_start_pos);
127 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
128 _aidl_parcel.setDataPosition(_aidl_end_pos);
129 }
130 public final void readFromParcel(android.os.Parcel _aidl_parcel)
131 {
132 int _aidl_start_pos = _aidl_parcel.dataPosition();
133 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900134 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900135 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900136 x = _aidl_parcel.readInt();
137 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
138 y = _aidl_parcel.readInt();
139 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900140 if ((0!=_aidl_parcel.readInt())) {
141 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
142 }
143 else {
144 fd = null;
145 }
146 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900147 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900148 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900149 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900150 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
151 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
152 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900153 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
154 }
155 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900156 @Override
157 public int describeContents() {
158 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900159 _mask |= describeContents(fd);
160 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900161 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900162 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900163 private int describeContents(Object _v) {
164 if (_v == null) return 0;
165 if (_v instanceof java.util.Collection) {
166 int _mask = 0;
167 for (Object o : (java.util.Collection) _v) {
168 _mask |= describeContents(o);
169 }
170 return _mask;
171 }
172 if (_v instanceof android.os.Parcelable) {
173 return ((android.os.Parcelable) _v).describeContents();
174 }
175 return 0;
176 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900177}
178)";
179
Devin Moore2f2077a2020-08-28 11:27:53 -0700180// clang-format off
181const char kExpectedCppHeaderOutput[] =
182 R"(#pragma once
183
184#include <binder/IBinder.h>
185#include <binder/IInterface.h>
186#include <binder/Status.h>
187#include <optional>
188#include <utils/String16.h>
189#include <utils/StrongPointer.h>
190#include <vector>
191
192class IFoo : public ::android::IInterface {
193public:
194 DECLARE_META_INTERFACE(Foo)
195 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
196}; // class IFoo
197class IFooDefault : public IFoo {
198public:
199 ::android::IBinder* onAsBinder() override {
200 return nullptr;
201 }
202 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
203 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
204 }
205}; // class IFooDefault
206)";
207// clang-format on
208
Christopher Wileyf8136192016-04-12 14:19:35 -0700209} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700210
Devin Moore7b8d5c92020-03-17 14:14:08 -0700211class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700212 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900213 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
214 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700215 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700216 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900217 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700218 args.emplace_back("aidl");
219 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700220 for (const string& s : additional_arguments) {
221 args.emplace_back(s);
222 }
223 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900224 args.emplace_back("--preprocessed=" + f);
225 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700226 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900227 args.emplace_back("--include=" + i);
228 }
229 args.emplace_back(path);
230 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900231 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900232 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700233 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900234 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900235
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700236 if (error != nullptr) {
237 *error = actual_error;
238 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900239
240 if (actual_error != AidlError::OK) {
241 return nullptr;
242 }
243
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900244 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900245 EXPECT_EQ(1ul, defined_types.size());
246
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900247 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700248 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700249
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 Options::Language GetLanguage() { return GetParam(); }
251
Christopher Wiley0522cd52015-10-28 15:39:44 -0700252 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800253 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900254 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900255 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700256};
257
Devin Moore7b8d5c92020-03-17 14:14:08 -0700258// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
259// tests with each of the supported languages as a parameter.
260INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
261 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700262 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700263 [](const testing::TestParamInfo<Options::Language>& info) {
264 return Options::LanguageToString(info.param);
265 });
266
267TEST_P(AidlTest, AcceptMissingPackage) {
268 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700269}
270
Devin Moore7b8d5c92020-03-17 14:14:08 -0700271TEST_P(AidlTest, EndsInSingleLineComment) {
272 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700273}
274
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000275TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
276 const string expected_stderr =
277 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
278 const std::string file_contents = "package a; interface IBar {}";
279 CaptureStderr();
280 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
281 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
282}
283
284TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
285 const string expected_stderr =
286 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
287 const std::string file_contents = "package a; interface Bar {}";
288 CaptureStderr();
289 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
290 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
291}
292
293TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
294 const string expected_stderr =
295 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
296 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
297 CaptureStderr();
298 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
299 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
300}
301
302TEST_P(AidlTest, EnumRequiresCorrectPath) {
303 const string expected_stderr =
304 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
305 const std::string file_contents = "package a; enum Bar { A, }";
306 CaptureStderr();
307 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
308 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
309}
310
Devin Moore7b8d5c92020-03-17 14:14:08 -0700311TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900312 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700313 io_delegate_.SetFileContents("bar/IBar.aidl",
314 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700315 const string path = "foo/IFoo.aidl";
316 const string contents =
317 "package foo;\n"
318 "import bar.IBar;\n"
319 "interface IFoo { void f(in IBar[] input); }";
320 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
321 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700324}
325
Devin Moore7b8d5c92020-03-17 14:14:08 -0700326TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700327 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700328 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900329}
Devin Moore097a3ab2020-03-11 16:08:44 -0700330
Jiyong Park40782d02020-07-24 19:17:43 +0900331TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700332 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
333 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900334 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
335 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700336 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700337 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700338 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900339}
340
Jiyong Park40782d02020-07-24 19:17:43 +0900341TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700342 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
343 const string expected_stderr =
344 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700345 CaptureStderr();
346 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900348}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700349
Jiyong Park40782d02020-07-24 19:17:43 +0900350TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700351 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900352 const string expected_stderr =
353 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700354 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700355 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700357}
358
Devin Moore7b8d5c92020-03-17 14:14:08 -0700359TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700360 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
361 const string expected_stderr =
362 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700365 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700366}
367
Devin Moore7b8d5c92020-03-17 14:14:08 -0700368TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700369 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
370 const string expected_stderr =
371 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700374 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800375}
376
Devin Moore2f2077a2020-08-28 11:27:53 -0700377TEST_P(AidlTest, AcceptNullableList) {
378 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
379 const string expected_stderr = "";
380 CaptureStderr();
381 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
382 EXPECT_EQ(expected_stderr, GetCapturedStderr());
383}
384
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700386 const string method = "package a; interface IFoo { void f(int a, int a); }";
387 const string expected_stderr =
388 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
389 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700390 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700391 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700392}
393
Jeongik Cha13066da2020-08-06 15:43:19 +0900394TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
395 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900396 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900397 CaptureStderr();
398 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
400}
401
Jooyung Hand902a972020-10-23 17:32:44 +0900402TEST_P(AidlTest, RejectsRepeatedAnnotations) {
403 const string method = R"(@Hide @Hide parcelable Foo {})";
404 const string expected_stderr =
405 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
406 "Foo.aidl:1.1-6\n";
407 CaptureStderr();
408 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
409 EXPECT_EQ(expected_stderr, GetCapturedStderr());
410}
411
Devin Moore7b8d5c92020-03-17 14:14:08 -0700412TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700413 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
414 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
415 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100418}
419
Devin Moore7b8d5c92020-03-17 14:14:08 -0700420TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700421 AidlError error;
422 const string method = "package a; @nullable interface IFoo { int f(); }";
423 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800424 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000425 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
426 "JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700427 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700428 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700429 EXPECT_EQ(expected_stderr, GetCapturedStderr());
430 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800431}
432
Devin Moore7b8d5c92020-03-17 14:14:08 -0700433TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700434 AidlError error;
435 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
436 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800437 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900438 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700439 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700440 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
442 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800443}
444
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700446 AidlError error;
447 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
448 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000449 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900450 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900451 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700452 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000453 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700454 EXPECT_EQ(expected_stderr, GetCapturedStderr());
455 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800456}
457
Devin Moore7b8d5c92020-03-17 14:14:08 -0700458TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700459 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000460 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700461 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000462 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900463 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700464 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700465 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000466 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
468 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800469}
470
Jiyong Park40782d02020-07-24 19:17:43 +0900471TEST_P(AidlTest, ParsesNonNullableAnnotation) {
472 auto parse_result =
473 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
474 ASSERT_NE(nullptr, parse_result);
475 const AidlInterface* interface = parse_result->AsInterface();
476 ASSERT_NE(nullptr, interface);
477 ASSERT_FALSE(interface->GetMethods().empty());
478 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
479}
480
Devin Moore7b8d5c92020-03-17 14:14:08 -0700481TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900482 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
483 typenames_, GetLanguage());
484 ASSERT_NE(nullptr, parse_result);
485 const AidlInterface* interface = parse_result->AsInterface();
486 ASSERT_NE(nullptr, interface);
487 ASSERT_FALSE(interface->GetMethods().empty());
488 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
489}
490
491TEST_P(AidlTest, ParsesNonUtf8Annotations) {
492 auto parse_result =
493 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
494 ASSERT_NE(nullptr, parse_result);
495 const AidlInterface* interface = parse_result->AsInterface();
496 ASSERT_NE(nullptr, interface);
497 ASSERT_FALSE(interface->GetMethods().empty());
498 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800499}
500
Devin Moore7b8d5c92020-03-17 14:14:08 -0700501TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900502 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
503 typenames_, GetLanguage());
504 ASSERT_NE(nullptr, parse_result);
505 const AidlInterface* interface = parse_result->AsInterface();
506 ASSERT_NE(nullptr, interface);
507 ASSERT_FALSE(interface->GetMethods().empty());
508 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800509}
510
Devin Moore7b8d5c92020-03-17 14:14:08 -0700511TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700512 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700513 const string expected_stderr =
514 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
515 "\"vintf\"'\n"
516 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
517 "--structured\n";
518 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700519 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700520 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700521 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700523}
524
Devin Moore7b8d5c92020-03-17 14:14:08 -0700525TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700526 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700527 const string expected_stderr =
528 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
529 "--structured\n";
530 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700531 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700532 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700533 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700535}
536
Devin Moore7b8d5c92020-03-17 14:14:08 -0700537TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700538 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700539 const string expected_stderr =
540 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
541 "\"vintf\"'\n";
542 CaptureStderr();
543 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700544 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700545 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700547}
548
Devin Moore7b8d5c92020-03-17 14:14:08 -0700549TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700550 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700551 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
552 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700553 ASSERT_EQ(AidlError::OK, error);
554 ASSERT_NE(nullptr, parse_result);
555 const AidlInterface* interface = parse_result->AsInterface();
556 ASSERT_NE(nullptr, interface);
557 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700558}
559
Jeongik Cha64783ed2019-06-07 18:30:54 +0900560TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
561 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900562 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
563 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900564 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700565 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900566 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900567 "a/Foo.aidl",
568 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900569
570 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900571 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700572 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900573 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700574 "Parcelable must be defined in AIDL directly.\n";
575 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900576 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700577 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700578
579 CaptureStderr();
580 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
581 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900582}
583
Jooyung Han1cbc4962020-10-25 10:07:15 +0900584TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
585 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
586 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
587 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900588 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
589
590 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900591 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900592 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
593
594 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900595 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900596 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
597
Jooyung Han1cbc4962020-10-25 10:07:15 +0900598 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900599 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
600}
601
Jooyung Han1cbc4962020-10-25 10:07:15 +0900602TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
603 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
604 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
605 CaptureStderr();
606 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
607 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
608 EXPECT_EQ("", GetCapturedStderr());
609
610 const string expected_to_string_method = R"--(
611 @Override
612 public String toString() {
613 switch (_tag) {
614 case a: return "a.Foo.a(" + (getA()) + ")";
615 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
616 }
617 throw new IllegalStateException("unknown field: " + _tag);
618 }
619)--";
620
621 string java_out;
622 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
623 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
624}
625
Jiyong Park9aa3d042020-12-04 23:30:02 +0900626TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
627 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
628 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
629 CaptureStderr();
630 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
631 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
632 EXPECT_EQ("", GetCapturedStderr());
633
634 const std::string expected = R"--(
635 @Override
636 public boolean equals(Object other) {
637 if (this == other) return true;
638 if (other == null) return false;
639 if (!(other instanceof Foo)) return false;
640 Foo that = (Foo)other;
641 if (!java.util.Objects.deepEquals(a, that.a)) return false;
642 if (!java.util.Objects.deepEquals(b, that.b)) return false;
643 return true;
644 }
645
646 @Override
647 public int hashCode() {
648 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
649 }
650)--";
651
652 string java_out;
653 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
654 EXPECT_THAT(java_out, testing::HasSubstr(expected));
655}
656
657TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
658 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
659 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
660 CaptureStderr();
661 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
662 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
663 EXPECT_EQ("", GetCapturedStderr());
664
665 const std::string expected = R"--(
666 @Override
667 public boolean equals(Object other) {
668 if (this == other) return true;
669 if (other == null) return false;
670 if (!(other instanceof Foo)) return false;
671 Foo that = (Foo)other;
672 if (_tag != that._tag) return false;
673 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
674 return true;
675 }
676
677 @Override
678 public int hashCode() {
679 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
680 }
681)--";
682
683 string java_out;
684 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
685 EXPECT_THAT(java_out, testing::HasSubstr(expected));
686}
687
Jooyung Han90345002020-10-23 15:28:53 +0900688TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900689 {
Jooyung Han90345002020-10-23 15:28:53 +0900690 io_delegate_.SetFileContents("a/Foo.aidl",
691 "package a; @JavaDerive(blah=true) parcelable Foo{}");
692 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
693 CaptureStderr();
694 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
695 const std::string expected_stderr =
696 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
697 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
698 }
699
700 {
701 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900702 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
703 CaptureStderr();
704 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
705 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900706 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000707 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
708 "JavaPassthrough, Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900709 EXPECT_EQ(expected_stderr, GetCapturedStderr());
710 }
711
712 {
Jooyung Han90345002020-10-23 15:28:53 +0900713 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900714 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
715 CaptureStderr();
716 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
717 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900718 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900719 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
720 EXPECT_EQ(expected_stderr, GetCapturedStderr());
721 }
722}
723
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900724TEST_P(AidlTest, ParseDescriptorAnnotation) {
725 AidlError error;
726 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
727 typenames_, GetLanguage(), &error, {"--structured"});
728 ASSERT_EQ(AidlError::OK, error);
729 ASSERT_NE(nullptr, parse_result);
730 const AidlInterface* interface = parse_result->AsInterface();
731 ASSERT_NE(nullptr, interface);
732 ASSERT_EQ("IBar", interface->GetDescriptor());
733}
734
Jiyong Park40782d02020-07-24 19:17:43 +0900735TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700736 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700737 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900738}
739
740TEST_P(AidlTest, AcceptsOnewayInterface) {
741 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700742 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700743}
Christopher Wileyef140932015-11-03 09:29:19 -0800744
Devin Moore7b8d5c92020-03-17 14:14:08 -0700745TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700746 const string oneway_method =
747 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700748 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100749}
750
Steven Moreland65297cc2020-04-20 20:17:36 -0700751TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
752 const string oneway_method =
753 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
754 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
755 ASSERT_NE(nullptr, defined);
756 const AidlInterface* iface = defined->AsInterface();
757 ASSERT_NE(nullptr, iface);
758
759 const auto& methods = iface->GetMethods();
760 ASSERT_EQ(1u, methods.size());
761 const auto& method = methods[0];
762 const AidlTypeSpecifier& ret_type = method->GetType();
763
764 // TODO(b/151102494): these annotations should be on the method
765 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
766 ASSERT_TRUE(ret_type.IsHide());
767}
768
Devin Moore7b8d5c92020-03-17 14:14:08 -0700769TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100770 string foo_interface =
771 "package a; /* foo */ interface IFoo {"
772 " /* i */ int i();"
773 " /* j */ @nullable String j();"
774 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
775
Devin Moore7b8d5c92020-03-17 14:14:08 -0700776 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100777 EXPECT_NE(nullptr, parse_result);
778 EXPECT_EQ("/* foo */", parse_result->GetComments());
779
780 const AidlInterface* interface = parse_result->AsInterface();
781 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
782 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
783 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
784}
785
Jooyung Han1a551d32020-10-05 15:37:26 +0900786TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
787 io_delegate_.SetFileContents("p/cpp_header.aidl",
788 R"(package p;
789 parcelable cpp_header cpp_header "bar/header";)");
790 import_paths_.emplace("");
791 const string input_path = "p/IFoo.aidl";
792 const string input = R"(package p;
793 import p.cpp_header;
794 interface IFoo {
795 // get bar
796 cpp_header get();
797 })";
798
799 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
800 EXPECT_NE(nullptr, parse_result);
801 const AidlInterface* interface = parse_result->AsInterface();
802 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
803}
804
Christopher Wileyef140932015-11-03 09:29:19 -0800805TEST_F(AidlTest, ParsesPreprocessedFile) {
806 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
807 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700808 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900809 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700810 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
811 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800812}
813
814TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
815 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
816 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900817
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700818 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900819 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700820 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
821 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800822}
823
Devin Moore7b8d5c92020-03-17 14:14:08 -0700824TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800825 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
826 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
827 "interface IBar {}");
828 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900829 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900830 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700831 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800832 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900833
Christopher Wiley41544372015-11-03 14:52:29 -0800834 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700835 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
836 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800837 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700838 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900839 ambiguous_type.Resolve(typenames_);
840 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800841}
842
Jiyong Park8f6ec462020-01-19 20:52:47 +0900843// Special case of PreferImportToPreprocessed. Imported type should be preferred
844// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700845TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900846 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
847 io_delegate_.SetFileContents("one/IBar.aidl",
848 "package one; "
849 "interface IBar {}");
850 preprocessed_files_.push_back("preprocessed");
851 import_paths_.emplace("");
852 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700853 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900854 EXPECT_NE(nullptr, parse_result);
855
856 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700857 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
858 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900859 // But if we request just "IBar" we should get our imported one.
860 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
861 ambiguous_type.Resolve(typenames_);
862 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
863}
864
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800865TEST_F(AidlTest, WritePreprocessedFile) {
866 io_delegate_.SetFileContents("p/Outer.aidl",
867 "package p; parcelable Outer.Inner;");
868 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
869 "interface IBar {}");
870
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900871 vector<string> args {
872 "aidl",
873 "--preprocess",
874 "preprocessed",
875 "p/Outer.aidl",
876 "one/IBar.aidl"};
877 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800878 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
879
880 string output;
881 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
882 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
883}
884
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900885TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100886 io_delegate_.SetFileContents(
887 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800888 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100889 "parcelable Rect {\n"
890 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800891 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100892 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800893 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100894 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100895 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
896 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100897 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900898 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900899 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100900 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900901
902 vector<string> args{"aidl", "Rect.aidl"};
903 Options options = Options::From(args);
904 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
905
906 string output;
907 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900908 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900909}
910
Devin Moore2f2077a2020-08-28 11:27:53 -0700911TEST_F(AidlTest, CppHeaderIncludes) {
912 io_delegate_.SetFileContents("IFoo.aidl",
913 "interface IFoo {\n"
914 " @nullable List<String> foo();\n"
915 "}");
916
917 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
918 Options options = Options::From(args);
919 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
920 std::vector<std::string> empty;
921 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
922 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
923 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
924
925 // Make sure the optional and String16.h includes are added
926 string output;
927 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
928 EXPECT_EQ(kExpectedCppHeaderOutput, output);
929}
930
Devin Moore7b8d5c92020-03-17 14:14:08 -0700931TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700932 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800933 io_delegate_.SetFileContents("p/Outer.aidl",
934 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900935 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
937 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
938 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700939 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800941}
942
Devin Moore7b8d5c92020-03-17 14:14:08 -0700943TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800944 io_delegate_.SetFileContents("preprocessed",
945 "parcelable p.Outer.Inner;");
946 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900947 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700948 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800949 // TODO(wiley): This should actually return nullptr because we require
950 // the outer class name. However, for legacy reasons,
951 // this behavior must be maintained. b/17415692
952 EXPECT_NE(nullptr, parse_result);
953}
954
Christopher Wiley632801d2015-11-05 14:15:49 -0800955TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700956 const string expected_foo_stderr =
957 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
958 "Declared parcelables should be in their own file and/or cannot be used with --structured "
959 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700960 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
961
Christopher Wiley632801d2015-11-05 14:15:49 -0800962 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700963 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700964 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900965 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700966 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900967
Steven Morelande2c64b42018-09-18 15:06:37 -0700968 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900969 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700970 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900971 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700972 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700973
Devin Moore097a3ab2020-03-11 16:08:44 -0700974 const string expected_bar_stderr =
975 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
976 "Declared parcelables should be in their own file and/or cannot be used with --structured "
977 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700978 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
979
Jiyong Parkda8c6932019-08-12 19:56:08 +0900980 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700981 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700982 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900983 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700984 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700985 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700986 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700987 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700988 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800989}
990
Devin Moore7b8d5c92020-03-17 14:14:08 -0700991TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700992 const string expected_stderr =
993 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
994 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700995 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
996 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700997 AidlError error;
998 CaptureStderr();
999 EXPECT_EQ(
1000 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001001 Parse("p/IFoo.aidl",
1002 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001003 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1005 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001006}
1007
Devin Moore7b8d5c92020-03-17 14:14:08 -07001008TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001009 AidlError error;
1010 const string expected_stderr =
1011 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1012 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001013 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1014 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001015 interface IFoo {
1016 const String DUPLICATED = "d";
1017 const int DUPLICATED = 1;
1018 }
1019 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001020 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001021 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1022 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001023}
1024
Steven Morelande689da22020-11-10 02:06:30 +00001025TEST_P(AidlTest, FailOnTooBigConstant) {
1026 AidlError error;
1027 const string expected_stderr =
1028 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1029 CaptureStderr();
1030 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1031 R"(package p;
1032 interface IFoo {
1033 const byte type2small = 256;
1034 }
1035 )",
1036 typenames_, GetLanguage(), &error));
1037 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1038 EXPECT_EQ(AidlError::BAD_TYPE, error);
1039}
1040
Devin Moore7b8d5c92020-03-17 14:14:08 -07001041TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001042 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001043 const string expected_stderr =
1044 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001045 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001046 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1047 R"(package p;
1048 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001049 parcelable IBar {}
1050 parcelable StructuredParcelable {}
1051 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001052 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001053 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001054 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001055 // Parse success is important for clear error handling even if the cases aren't
1056 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001057 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001058}
1059
Devin Moore7b8d5c92020-03-17 14:14:08 -07001060TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001061 AidlError error;
1062 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1063 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001064 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001065 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1066 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001067}
1068
Steven Morelandf9e922f2020-07-08 21:15:27 +00001069TEST_P(AidlTest, FailOnEmptyListWithComma) {
1070 AidlError error;
1071 const string expected_stderr =
1072 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1073 CaptureStderr();
1074 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1075 typenames_, GetLanguage(), &error));
1076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1077 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1078}
1079
Devin Moore7b8d5c92020-03-17 14:14:08 -07001080TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001081 AidlError error;
1082 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001083 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001084 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001085 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1086 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001087 interface IFoo {
1088 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1089 }
1090 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001091 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001092 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1093 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001094}
1095
Jiyong Park18132182020-06-08 20:24:40 +09001096TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1097 AidlError error;
1098 const string expected_stderr =
1099 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1100 "cpp_header (which can also be used as an identifier)\n";
1101 CaptureStderr();
1102 // Notice the trailing dot(.) in the name, which isn't a correct name
1103 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1104 GetLanguage(), &error));
1105 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1106 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1107}
1108
1109TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1110 AidlError error;
1111 const string expected_stderr =
1112 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1113 "cpp_header (which can also be used as an identifier)\n";
1114 CaptureStderr();
1115 // Notice the trailing dot(.) in the package name
1116 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1117 GetLanguage(), &error));
1118 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1119 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1120}
1121
Devin Moore7b8d5c92020-03-17 14:14:08 -07001122TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001123 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001124 auto parse_result = Parse("p/IFoo.aidl",
1125 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001126 interface IFoo {
1127 const int POSITIVE_HEX_VALUE = 0xf5;
1128 }
1129 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001130 typenames_, GetLanguage(), &error);
1131 EXPECT_NE(nullptr, parse_result);
1132 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001133 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001134 const auto& cpp_constants = interface->GetConstantDeclarations();
1135 EXPECT_EQ((size_t)1, cpp_constants.size());
1136 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001137 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001138 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001139}
1140
Devin Moore7b8d5c92020-03-17 14:14:08 -07001141TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001142 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001143 auto parse_result = Parse("p/IFoo.aidl",
1144 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001145 interface IFoo {
1146 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1147 }
1148 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001149 typenames_, GetLanguage(), &error);
1150 ASSERT_NE(nullptr, parse_result);
1151 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001152 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001153 const auto& cpp_constants = interface->GetConstantDeclarations();
1154 EXPECT_EQ((size_t)1, cpp_constants.size());
1155 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001156 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001157 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001158}
1159
Devin Moore7b8d5c92020-03-17 14:14:08 -07001160TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001161 io_delegate_.SetFileContents(
1162 "p/Outer.aidl",
1163 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001164 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001165 const string input_path = "p/IFoo.aidl";
1166 const string input = "package p; import p.Outer; interface IFoo"
1167 " { Outer.Inner get(); }";
1168
Devin Moore7b8d5c92020-03-17 14:14:08 -07001169 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1170 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001171
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001172 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001173 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001174 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1175 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001176}
1177
Devin Moore7b8d5c92020-03-17 14:14:08 -07001178TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001179 io_delegate_.SetFileContents(
1180 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001181 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001182 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001183 const string input_path = "p/IFoo.aidl";
1184 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001185 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1186 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001187 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001188 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1189 native_type.Resolve(typenames_);
1190
1191 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1192 // C++ understands C++ specific stuff
1193 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1194 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001195 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001196 EXPECT_EQ(1u, headers.size());
1197 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001198}
1199
Christopher Wileyf8136192016-04-12 14:19:35 -07001200TEST_F(AidlTest, WritesCorrectDependencyFile) {
1201 // While the in tree build system always gives us an output file name,
1202 // other android tools take advantage of our ability to infer the intended
1203 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001204 vector<string> args = {
1205 "aidl",
1206 "-d dep/file/path",
1207 "-o place/for/output",
1208 "p/IFoo.aidl"};
1209 Options options = Options::From(args);
1210 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001211 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001212 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001213 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001214 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1215}
1216
Dan Willemsen93298ee2016-11-10 23:55:55 -08001217TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1218 // While the in tree build system always gives us an output file name,
1219 // other android tools take advantage of our ability to infer the intended
1220 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001221 vector<string> args = {
1222 "aidl",
1223 "-d dep/file/path",
1224 "--ninja",
1225 "-o place/for/output",
1226 "p/IFoo.aidl"};
1227 Options options = Options::From(args);
1228 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001229 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001230 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001231 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001232 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1233}
1234
Jiyong Parkdf202122019-09-30 20:48:35 +09001235TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001236 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1237 // this by calling aidl with every .aidl file it finds, then parsing the
1238 // generated dependency files. Those that reference .java output files are
1239 // for interfaces and those that do not are parcelables. However, for both
1240 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001241 vector<string> args = {
1242 "aidl",
1243 "-o place/for/output",
1244 "-d dep/file/path",
1245 "p/Foo.aidl"};
1246 Options options = Options::From(args);
1247 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001248 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001249 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001250 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001251 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1252}
1253
1254TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1255 vector<string> args = {
1256 "aidl",
1257 "--structured",
1258 "-o place/for/output",
1259 "-d dep/file/path",
1260 "p/Foo.aidl"};
1261 Options options = Options::From(args);
1262 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1263 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1264 string actual_dep_file_contents;
1265 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1266 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001267}
1268
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001269TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1270 vector<string> args = {
1271 "aidl",
1272 "--lang=java",
1273 "-o place/for/output",
1274 "p/Foo.aidl"};
1275 Options options = Options::From(args);
1276 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1277 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1278 string output_file_contents;
1279 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1280}
1281
Jeongik Cha08ca2182019-11-21 14:01:13 +09001282// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001283TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001284 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001285 "package a; interface IFoo {\n"
1286 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001287 string expected_stderr;
1288 switch (GetLanguage()) {
1289 case Options::Language::CPP:
1290 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001291 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001292 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1293 "String and IBinder.\n";
1294 break;
1295 case Options::Language::JAVA:
1296 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001297 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001298 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1299 "String, IBinder, and ParcelFileDescriptor.\n";
1300 break;
1301 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001302 case Options::Language::RUST:
1303 expected_stderr =
1304 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1305 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001306 default:
1307 AIDL_FATAL(AIDL_LOCATION_HERE)
1308 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1309 }
1310 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001311 AidlTypenames tn1;
1312 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001313 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001314
1315 string primitive_parcelable =
1316 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001317 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001318 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001319 AidlTypenames tn2;
1320 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001321 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001322}
1323
Devin Moore21b26772020-08-26 16:37:56 -07001324TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001325 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001326 const string list_array_parcelable =
1327 "package a; parcelable Foo {\n"
1328 " List[] lists; }";
1329 CaptureStderr();
1330 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1331 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1332}
1333
Jiyong Parkf8d53612020-05-04 14:06:13 +09001334TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1335 AidlError error;
1336 string expected_stderr =
1337 "ERROR: a/IFoo.aidl:2.7-11: "
1338 "Encountered an untyped List or Map. The use of untyped List/Map is "
1339 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1340 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1341 if (GetLanguage() != Options::Language::JAVA) {
1342 expected_stderr =
1343 "ERROR: a/IFoo.aidl:2.1-7: "
1344 "Currently, only the Java backend supports non-generic List.\n";
1345 }
1346
1347 const string primitive_interface =
1348 "package a; interface IFoo {\n"
1349 " List foo(); }";
1350 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001351 AidlTypenames tn1;
1352 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001353 {"--structured"}));
1354 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001355
1356 string primitive_parcelable =
1357 "package a; parcelable IFoo {\n"
1358 " List foo;}";
1359 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001360 AidlTypenames tn2;
1361 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001362 {"--structured"}));
1363 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1364}
1365
Jeongik Cha225519b2020-08-29 01:55:32 +09001366TEST_P(AidlTest, ExtensionTest) {
1367 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001368 string extendable_parcelable =
1369 "package a; parcelable Data {\n"
1370 " ParcelableHolder extension;\n"
1371 " ParcelableHolder extension2;\n"
1372 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001373 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001374 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1375 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001376 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001377 "yet.\n",
1378 GetCapturedStderr());
1379 } else {
1380 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1381 EXPECT_EQ("", GetCapturedStderr());
1382 }
1383}
1384TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1385 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001386 string parcelableholder_return_interface =
1387 "package a; interface IFoo {\n"
1388 " ParcelableHolder foo();\n"
1389 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001390 EXPECT_EQ(nullptr,
1391 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001392
Jeongik Cha8f02a532020-10-14 00:16:28 +09001393 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001394 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001395 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001396 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001397 "yet.\n",
1398 GetCapturedStderr());
1399 return;
1400 }
1401 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1402 GetCapturedStderr());
1403}
1404
1405TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1406 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001407 string extendable_parcelable_arg_interface =
1408 "package a; interface IFoo {\n"
1409 " void foo(in ParcelableHolder ph);\n"
1410 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001411 EXPECT_EQ(nullptr,
1412 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1413
Jeongik Cha8f02a532020-10-14 00:16:28 +09001414 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001415 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001416 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001417 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001418 "yet.\n",
1419 GetCapturedStderr());
1420 return;
1421 }
1422 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1423 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001424}
1425
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001426TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1427 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1428 Options options =
1429 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1430 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1431 CaptureStderr();
1432 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1433 if (GetLanguage() == Options::Language::RUST) {
1434 EXPECT_EQ(
1435 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1436 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1437 "yet.\n",
1438 GetCapturedStderr());
1439 return;
1440 }
1441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1442}
1443
Jooyung Han3f347ca2020-12-01 12:41:50 +09001444TEST_P(AidlTest, ParcelablesWithConstants) {
1445 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
1446 Options options =
1447 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1448 CaptureStderr();
1449 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1450 EXPECT_EQ("", GetCapturedStderr());
1451}
1452
1453TEST_P(AidlTest, UnionWithConstants) {
1454 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
1455 Options options =
1456 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1457 CaptureStderr();
1458 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1459 EXPECT_EQ("", GetCapturedStderr());
1460}
1461
Jiyong Park02da7422018-07-16 16:00:26 +09001462TEST_F(AidlTest, ApiDump) {
1463 io_delegate_.SetFileContents(
1464 "foo/bar/IFoo.aidl",
1465 "package foo.bar;\n"
1466 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001467 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001468 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001469 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001470 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1471 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1472 " IFoo foo3(IFoo foo);\n"
1473 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001474 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001475 " const int A = 1;\n"
1476 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001477 "}\n");
1478 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1479 "package foo.bar;\n"
1480 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001481 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001482 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001483 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001484 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001485 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001486 " int y;\n"
1487 " IFoo foo;\n"
1488 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001489 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001490 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001491 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001492 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001493 "}\n");
1494 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001495 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1496 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001497 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001498 bool result = dump_api(options, io_delegate_);
1499 ASSERT_TRUE(result);
1500 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001501 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001502 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001503/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001504interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001505 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001506 int foo(out int[] a, String b, boolean c, inout List<String> d);
1507 int foo2(@utf8InCpp String x, inout List<String> y);
1508 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1509 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001510 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001511 const int A = 1;
1512 const String STR = "Hello";
1513}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001514)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001515
Jiyong Parke59c3682018-09-11 23:10:25 +09001516 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001517 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001518/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001519parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001520 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001521 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001522 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001523 int y;
1524 foo.bar.IFoo foo;
1525 List<foo.bar.IFoo> a;
1526 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001527 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001528 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001529}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001530)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001531}
1532
Jiyong Parked65bf42018-08-28 15:43:27 +09001533TEST_F(AidlTest, ApiDumpWithManualIds) {
1534 io_delegate_.SetFileContents(
1535 "foo/bar/IFoo.aidl",
1536 "package foo.bar;\n"
1537 "interface IFoo {\n"
1538 " int foo() = 1;\n"
1539 " int bar() = 2;\n"
1540 " int baz() = 10;\n"
1541 "}\n");
1542
Jiyong Parke59c3682018-09-11 23:10:25 +09001543 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001544 Options options = Options::From(args);
1545 bool result = dump_api(options, io_delegate_);
1546 ASSERT_TRUE(result);
1547 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001548 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001549 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001550interface IFoo {
1551 int foo() = 1;
1552 int bar() = 2;
1553 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001554}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001555)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001556}
1557
1558TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001559 const string expected_stderr =
1560 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1561 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001562 io_delegate_.SetFileContents(
1563 "foo/bar/IFoo.aidl",
1564 "package foo.bar;\n"
1565 "interface IFoo {\n"
1566 " int foo() = 1;\n"
1567 " int bar();\n"
1568 " int baz() = 10;\n"
1569 "}\n");
1570
Jiyong Parke59c3682018-09-11 23:10:25 +09001571 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001572 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001573 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001574 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001575 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001576}
1577
Jooyung Han965e31d2020-11-27 12:30:16 +09001578TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1579 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1580 "package foo.bar;\n"
1581 "interface IFoo {\n"
1582 " @utf8InCpp String foo();\n"
1583 " const @utf8InCpp String bar = \"bar\";\n"
1584 "}\n");
1585
1586 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1587 Options options = Options::From(args);
1588 CaptureStderr();
1589 EXPECT_TRUE(dump_api(options, io_delegate_));
1590 EXPECT_EQ("", GetCapturedStderr());
1591 string actual;
1592 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001593 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1594interface IFoo {
1595 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001596 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001597}
1598)"),
1599 actual);
1600}
1601
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001602TEST_F(AidlTest, ApiDumpWithEnums) {
1603 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1604 "package foo.bar;\n"
1605 "enum Enum {\n"
1606 " FOO,\n"
1607 " BAR = FOO + 1,\n"
1608 "}\n");
1609
1610 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1611 Options options = Options::From(args);
1612 CaptureStderr();
1613 EXPECT_TRUE(dump_api(options, io_delegate_));
1614 EXPECT_EQ("", GetCapturedStderr());
1615 string actual;
1616 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1617 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1618 "enum Enum {\n"
1619 " FOO = 0,\n"
1620 " BAR = 1,\n"
1621 "}\n"),
1622 actual);
1623}
1624
1625TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1626 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1627 "package foo.bar;\n"
1628 "enum Enum {\n"
1629 " FOO,\n"
1630 "}\n");
1631 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1632 "package foo.bar;\n"
1633 "import foo.bar.Enum;\n"
1634 "parcelable Foo {\n"
1635 " Enum e = Enum.FOO;\n"
1636 "}\n");
1637
1638 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1639 Options options = Options::From(args);
1640 CaptureStderr();
1641 EXPECT_TRUE(dump_api(options, io_delegate_));
1642 EXPECT_EQ("", GetCapturedStderr());
1643 string actual;
1644 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1645 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1646 "parcelable Foo {\n"
1647 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1648 "}\n"),
1649 actual);
1650}
1651
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001652TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001653 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001654 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1655 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001656 const string expected_map_stderr =
1657 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001658 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1659 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001660 "package p; interface IFoo {"
1661 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001662 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001663 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001664 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001665
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001666 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001667 "package p; interface IFoo {"
1668 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001669 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001670 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001671 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001672}
1673
Jeongik Chae48d9942020-01-02 17:39:00 +09001674TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001675 const string expected_stderr =
1676 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001677 Options options = Options::From("aidl -I p p/IFoo.aidl");
1678 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1679
1680 io_delegate_.SetFileContents("p/IFoo.aidl",
1681 "package p; interface IFoo {"
1682 "Map<String, Bar> foo();}");
1683 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1684
1685 io_delegate_.SetFileContents("p/IFoo.aidl",
1686 "package p; interface IFoo {"
1687 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001688 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001689 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001690 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001691
1692 io_delegate_.SetFileContents("p/IFoo.aidl",
1693 "package p; interface IFoo {"
1694 "Map<String, String> foo();}");
1695 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1696
1697 io_delegate_.SetFileContents("p/IFoo.aidl",
1698 "package p; interface IFoo {"
1699 "Map<String, ParcelFileDescriptor> foo();}");
1700 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1701}
1702
Jeongik Chadf76dc72019-11-28 00:08:47 +09001703TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001704 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001705 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1706 io_delegate_.SetFileContents(options.InputFiles().front(),
1707 "package p; interface IFoo {"
1708 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001709 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001710 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001711 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001712}
1713
1714TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1715 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1716 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001717 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001718 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001719 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1720 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001721
1722 Options options = Options::From("aidl -I p p/IFoo.aidl");
1723 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1724 io_delegate_.SetFileContents("p/IFoo.aidl",
1725 "package p; interface IFoo {"
1726 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001727 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001728 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001729 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001730 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001731 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001732 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001733 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1734 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001735 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1736 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1737 io_delegate_.SetFileContents("p/IFoo.aidl",
1738 "package p; interface IFoo {"
1739 "Bar<String, ParcelFileDescriptor> foo();}");
1740 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001741
1742 io_delegate_.SetFileContents("p/IFoo.aidl",
1743 "package p; interface IFoo {"
1744 "Bar<int, long> foo();}");
1745
1746 io_delegate_.SetFileContents("p/IFoo.aidl",
1747 "package p; interface IFoo {"
1748 "Bar<int[], long[]> foo();}");
1749
1750 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001751}
1752
Jeongik Cha0e426012019-07-29 15:57:02 +09001753TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1754 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001755 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1756 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001757 for (const auto& rawOption : rawOptions) {
1758 string expected_stderr =
1759 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001760 Options options = Options::From(rawOption);
1761 io_delegate_.SetFileContents(options.InputFiles().front(),
1762 "package foo.bar;\n"
1763 "interface IFoo1 { int foo(); }\n"
1764 "interface IFoo2 { int foo(); }\n"
1765 "parcelable Data1 { int a; int b;}\n"
1766 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001767 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001768 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001769 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001770
Jeongik Cha0e426012019-07-29 15:57:02 +09001771 io_delegate_.SetFileContents(options.InputFiles().front(),
1772 "package foo.bar;\n"
1773 "interface IFoo1 { int foo(); }\n"
1774 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001775 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001776 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001777 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001778
Devin Moore5de18ed2020-04-02 13:52:29 -07001779 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001780 io_delegate_.SetFileContents(options.InputFiles().front(),
1781 "package foo.bar;\n"
1782 "parcelable Data1 { int a; int b;}\n"
1783 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001784 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001785 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001786 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001787 }
1788}
1789
Devin Moorebdba2a82020-03-31 15:19:02 -07001790TEST_P(AidlTest, FailParseOnEmptyFile) {
1791 const string contents = "";
1792 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1793 CaptureStderr();
1794 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1795 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1796}
1797
Jiyong Parkb034bf02018-07-30 17:44:33 +09001798TEST_F(AidlTest, MultipleInputFiles) {
1799 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001800 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001801
1802 io_delegate_.SetFileContents(options.InputFiles().at(0),
1803 "package foo.bar;\n"
1804 "import foo.bar.Data;\n"
1805 "interface IFoo { Data getData(); }\n");
1806
1807 io_delegate_.SetFileContents(options.InputFiles().at(1),
1808 "package foo.bar;\n"
1809 "import foo.bar.IFoo;\n"
1810 "parcelable Data { IFoo foo; }\n");
1811
1812 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1813
1814 string content;
1815 for (const auto file : {
1816 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1817 content.clear();
1818 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1819 EXPECT_FALSE(content.empty());
1820 }
1821}
1822
1823TEST_F(AidlTest, MultipleInputFilesCpp) {
1824 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001825 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001826
1827 io_delegate_.SetFileContents(options.InputFiles().at(0),
1828 "package foo.bar;\n"
1829 "import foo.bar.Data;\n"
1830 "interface IFoo { Data getData(); }\n");
1831
1832 io_delegate_.SetFileContents(options.InputFiles().at(1),
1833 "package foo.bar;\n"
1834 "import foo.bar.IFoo;\n"
1835 "parcelable Data { IFoo foo; }\n");
1836
1837 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1838
1839 string content;
1840 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001841 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001842 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1843 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1844 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1845 content.clear();
1846 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1847 EXPECT_FALSE(content.empty());
1848 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001849}
1850
Andrei Homescub62afd92020-05-11 19:24:59 -07001851TEST_F(AidlTest, MultipleInputFilesRust) {
1852 Options options =
1853 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1854
1855 io_delegate_.SetFileContents(options.InputFiles().at(0),
1856 "package foo.bar;\n"
1857 "import foo.bar.Data;\n"
1858 "interface IFoo { Data getData(); }\n");
1859
1860 io_delegate_.SetFileContents(options.InputFiles().at(1),
1861 "package foo.bar;\n"
1862 "import foo.bar.IFoo;\n"
1863 "parcelable Data { IFoo foo; }\n");
1864
1865 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1866
1867 string content;
1868 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1869 content.clear();
1870 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1871 EXPECT_FALSE(content.empty());
1872 }
1873}
1874
Devin Moore097a3ab2020-03-11 16:08:44 -07001875TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1876 const string expected_stderr =
1877 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001878 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1879 // int getInterfaceVersion() is one of the meta transactions
1880 io_delegate_.SetFileContents(options.InputFiles().front(),
1881 "package p; interface IFoo {"
1882 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001883 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001884 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001885 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1886}
Jiyong Park309668e2018-07-28 16:55:44 +09001887
Devin Moore097a3ab2020-03-11 16:08:44 -07001888TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1889 // boolean getInterfaceVersion() is not a meta transaction, but should be
1890 // prevented because return type is not part of a method signature
1891 const string expected_stderr =
1892 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1893 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001894 io_delegate_.SetFileContents(options.InputFiles().front(),
1895 "package p; interface IFoo {"
1896 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001897 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001898 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001899 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1900}
Jiyong Park309668e2018-07-28 16:55:44 +09001901
Devin Moore097a3ab2020-03-11 16:08:44 -07001902TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001903 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001904 const string expected_stderr =
1905 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1906 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001907 io_delegate_.SetFileContents(options.InputFiles().front(),
1908 "package p; interface IFoo {"
1909 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001910 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001911 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001912 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001913
1914 // this is not a meta interface method as it differs type arguments
1915 io_delegate_.SetFileContents(options.InputFiles().front(),
1916 "package p; interface IFoo {"
1917 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001918 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001919}
1920
Daniel Norman85aed542019-08-21 12:01:14 -07001921TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001922 Options options = Options::From("aidl --checkapi old new");
1923 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1924 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1925 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1926 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1927
1928 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1929}
1930
Jiyong Park3656c3c2018-08-01 20:02:01 +09001931TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001932 Options options = Options::From("aidl --checkapi old new");
1933 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1934 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001935
1936 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1937}
1938
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001939TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1940 Options options = Options::From("aidl --checkapi old new");
1941 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1942 const string enum_definition = "package p; enum Enum { FOO }";
1943 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1944 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1945 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1946 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1947
1948 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1949}
1950
Daniel Norman85aed542019-08-21 12:01:14 -07001951class AidlTestCompatibleChanges : public AidlTest {
1952 protected:
1953 Options options_ = Options::From("aidl --checkapi old new");
1954};
1955
1956TEST_F(AidlTestCompatibleChanges, NewType) {
1957 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1958 "package p;"
1959 "interface IFoo {"
1960 " void foo(int a);"
1961 "}");
1962 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1963 "package p;"
1964 "interface IFoo {"
1965 " void foo(int a);"
1966 "}");
1967 io_delegate_.SetFileContents("new/p/IBar.aidl",
1968 "package p;"
1969 "interface IBar {"
1970 " void bar();"
1971 "}");
1972 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1973}
1974
1975TEST_F(AidlTestCompatibleChanges, NewMethod) {
1976 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1977 "package p;"
1978 "interface IFoo {"
1979 " void foo(int a);"
1980 "}");
1981 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1982 "package p;"
1983 "interface IFoo {"
1984 " void foo(int a);"
1985 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001986 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001987 "}");
1988 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1989}
1990
1991TEST_F(AidlTestCompatibleChanges, NewField) {
1992 io_delegate_.SetFileContents("old/p/Data.aidl",
1993 "package p;"
1994 "parcelable Data {"
1995 " int foo;"
1996 "}");
1997 io_delegate_.SetFileContents("new/p/Data.aidl",
1998 "package p;"
1999 "parcelable Data {"
2000 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002001 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002002 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002003 "}");
2004 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2005}
2006
2007TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2008 io_delegate_.SetFileContents("old/p/Enum.aidl",
2009 "package p;"
2010 "enum Enum {"
2011 " FOO = 1,"
2012 "}");
2013 io_delegate_.SetFileContents("new/p/Enum.aidl",
2014 "package p;"
2015 "enum Enum {"
2016 " FOO = 1,"
2017 " BAR = 2,"
2018 "}");
2019 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2020}
2021
2022TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2023 io_delegate_.SetFileContents("old/p/Enum.aidl",
2024 "package p;"
2025 "enum Enum {"
2026 " FOO = 1,"
2027 " BAR = 2,"
2028 "}");
2029 io_delegate_.SetFileContents("new/p/Enum.aidl",
2030 "package p;"
2031 "enum Enum {"
2032 " BAR = 2,"
2033 " FOO = 1,"
2034 "}");
2035 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2036}
2037
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002038TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2039 io_delegate_.SetFileContents("old/p/Union.aidl",
2040 "package p;"
2041 "union Union {"
2042 " String foo;"
2043 "}");
2044 io_delegate_.SetFileContents("new/p/Union.aidl",
2045 "package p;"
2046 "union Union {"
2047 " String foo;"
2048 " int num;"
2049 "}");
2050 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2051}
2052
Daniel Norman85aed542019-08-21 12:01:14 -07002053TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002054 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2055 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002056 "interface IFoo {"
2057 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002058 "}");
2059 io_delegate_.SetFileContents("old/p/Data.aidl",
2060 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002061 "parcelable Data {"
2062 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002063 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002064 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2065 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002066 "interface IFoo {"
2067 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002068 "}");
2069 io_delegate_.SetFileContents("new/p/Data.aidl",
2070 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002071 "parcelable Data {"
2072 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002073 "}");
2074 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2075 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002076 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002077 " void foo(int a);"
2078 "}");
2079 io_delegate_.SetFileContents("new/q/Data.aidl",
2080 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002081 "parcelable Data {"
2082 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002083 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002084 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2085}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002086
Daniel Norman85aed542019-08-21 12:01:14 -07002087TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2088 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2089 "package p;"
2090 "interface IFoo {"
2091 " void foo(int a);"
2092 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002093 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2094 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002095 "interface IFoo {"
2096 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002097 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002098 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2099}
Jiyong Parke59c3682018-09-11 23:10:25 +09002100
Daniel Norman85aed542019-08-21 12:01:14 -07002101TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002102 io_delegate_.SetFileContents("old/p/I.aidl",
2103 "package p; interface I {"
2104 "const int A = 1; }");
2105 io_delegate_.SetFileContents("new/p/I.aidl",
2106 "package p ; interface I {"
2107 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002108 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2109}
Jiyong Parka428d212018-08-29 22:26:30 +09002110
Daniel Norman85aed542019-08-21 12:01:14 -07002111TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002112 io_delegate_.SetFileContents("old/p/I.aidl",
2113 "package p; interface I {"
2114 "const int A = 1; const int B = 2;}");
2115 io_delegate_.SetFileContents("new/p/I.aidl",
2116 "package p ; interface I {"
2117 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002118 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002119}
2120
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002121TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2122 io_delegate_.SetFileContents("old/p/Foo.aidl",
2123 "package p;"
2124 "@JavaPassthrough(annotation=\"Alice\")"
2125 "@JavaPassthrough(annotation=\"Bob\")"
2126 "parcelable Foo {}");
2127 io_delegate_.SetFileContents("new/p/Foo.aidl",
2128 "package p;"
2129 "@JavaPassthrough(annotation=\"Bob\")"
2130 "@JavaPassthrough(annotation=\"Alice\")"
2131 "parcelable Foo {}");
2132 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2133}
2134
Jooyung Han00073272020-11-27 14:20:20 +09002135TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2136 io_delegate_.SetFileContents("old/p/Foo.aidl",
2137 "package p;"
2138 "parcelable Foo {}");
2139 io_delegate_.SetFileContents("new/p/Foo.aidl",
2140 "package p;"
2141 "@JavaPassthrough(annotation=\"@Deprecated\")"
2142 "parcelable Foo {}");
2143 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2144}
2145
Jooyung Han636fd2f2020-10-22 11:33:45 +09002146TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2147 io_delegate_.SetFileContents("old/p/Data.aidl",
2148 "package p;"
2149 "parcelable Data {"
2150 " int num;"
2151 "}");
2152 io_delegate_.SetFileContents(
2153 "new/p/Data.aidl",
2154 "package p;"
2155 "parcelable Data {"
2156 " int num;"
2157 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2158 "}");
2159 io_delegate_.SetFileContents("new/p/Enum.aidl",
2160 "package p;"
2161 "enum Enum {"
2162 " FOO = 0,"
2163 " BAR = 1,"
2164 "}");
2165 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2166}
2167
Daniel Norman85aed542019-08-21 12:01:14 -07002168class AidlTestIncompatibleChanges : public AidlTest {
2169 protected:
2170 Options options_ = Options::From("aidl --checkapi old new");
2171};
2172
2173TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002174 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002175 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2176 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002177 "interface IFoo {"
2178 " void foo(in String[] str);"
2179 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002180 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002181 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002182 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002183 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002184}
2185
2186TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002187 const string expected_stderr =
2188 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002189 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2190 "package p;"
2191 "interface IFoo {"
2192 " void foo(in String[] str);"
2193 " void bar(@utf8InCpp String str);"
2194 "}");
2195 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2196 "package p;"
2197 "interface IFoo {"
2198 " void foo(in String[] str);"
2199 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002200 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002201 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002202 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002203}
2204
Jiyong Parkf8d53612020-05-04 14:06:13 +09002205TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2206 const string expected_stderr =
2207 "ERROR: new/p/IFoo.aidl:1.61-65: "
2208 "Encountered an untyped List or Map. The use of untyped List/Map is "
2209 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2210 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2211 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2212 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2213 "package p;"
2214 "interface IFoo {"
2215 " void foo(in String[] str);"
2216 "}");
2217 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2218 "package p;"
2219 "interface IFoo {"
2220 " void foo(in String[] str);"
2221 " void bar(in List arg);"
2222 "}");
2223 CaptureStderr();
2224 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2225 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2226}
2227
2228TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2229 const string expected_stderr =
2230 "ERROR: new/p/Data.aidl:1.54-59: "
2231 "Encountered an untyped List or Map. The use of untyped List/Map is "
2232 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2233 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2234 "ERROR: new/p/Data.aidl: Failed to read.\n";
2235 io_delegate_.SetFileContents("old/p/Data.aidl",
2236 "package p;"
2237 "parcelable Data {"
2238 " int foo;"
2239 "}");
2240 io_delegate_.SetFileContents("new/p/Data.aidl",
2241 "package p;"
2242 "parcelable Data {"
2243 " int foo;"
2244 " @nullable List list;"
2245 "}");
2246 CaptureStderr();
2247 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2248 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2249}
2250
Daniel Norman85aed542019-08-21 12:01:14 -07002251TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002252 const string expected_stderr =
2253 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002254 io_delegate_.SetFileContents("old/p/Data.aidl",
2255 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002256 "parcelable Data {"
2257 " int foo;"
2258 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002259 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002260 io_delegate_.SetFileContents("new/p/Data.aidl",
2261 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002262 "parcelable Data {"
2263 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002264 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002265 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002266 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002267 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002268}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002269
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002270TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2271 const string expected_stderr =
2272 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2273 "backends. Please either provide a default value for this field or mark the field as "
2274 "@nullable. This value or a null value will be used automatically when an old version of "
2275 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2276 "order to make sure your code continues to be backwards compatible, make sure the default or "
2277 "null value does not cause a semantic change to this parcelable.\n";
2278 io_delegate_.SetFileContents("old/p/Data.aidl",
2279 "package p;"
2280 "parcelable Data {"
2281 " int num;"
2282 "}");
2283 io_delegate_.SetFileContents("new/p/Data.aidl",
2284 "package p;"
2285 "parcelable Data {"
2286 " int num;"
2287 " String str;"
2288 "}");
2289 CaptureStderr();
2290 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2291 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2292}
2293
Jooyung Han636fd2f2020-10-22 11:33:45 +09002294TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2295 const string expected_stderr =
2296 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2297 "Please make sure 'Enum' has '0' as a valid value.\n";
2298 io_delegate_.SetFileContents("old/p/Data.aidl",
2299 "package p;"
2300 "parcelable Data {"
2301 " int num;"
2302 "}");
2303 io_delegate_.SetFileContents("new/p/Data.aidl",
2304 "package p;"
2305 "parcelable Data {"
2306 " int num;"
2307 " p.Enum e;"
2308 "}");
2309 io_delegate_.SetFileContents("new/p/Enum.aidl",
2310 "package p;"
2311 "enum Enum {"
2312 " FOO = 1,"
2313 " BAR = 2,"
2314 "}");
2315 CaptureStderr();
2316 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2317 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2318}
2319
Daniel Norman85aed542019-08-21 12:01:14 -07002320TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002321 const string expected_stderr =
2322 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002323 io_delegate_.SetFileContents("old/p/Enum.aidl",
2324 "package p;"
2325 "enum Enum {"
2326 " FOO = 1,"
2327 " BAR = 2,"
2328 "}");
2329 io_delegate_.SetFileContents("new/p/Enum.aidl",
2330 "package p;"
2331 "enum Enum {"
2332 " BAR = 2,"
2333 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002334 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002335 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002336 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002337}
2338
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002339TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2340 const string expected_stderr =
2341 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2342 io_delegate_.SetFileContents("old/p/Union.aidl",
2343 "package p;"
2344 "union Union {"
2345 " String str;"
2346 " int num;"
2347 "}");
2348 io_delegate_.SetFileContents("new/p/Union.aidl",
2349 "package p;"
2350 "union Union {"
2351 " String str;"
2352 "}");
2353 CaptureStderr();
2354 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2356}
2357
Daniel Norman85aed542019-08-21 12:01:14 -07002358TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002359 const string expected_stderr =
2360 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002361 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2362 "package p;"
2363 "interface IFoo {"
2364 " void foo(in String[] str);"
2365 " void bar(@utf8InCpp String str);"
2366 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002367 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2368 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002369 "interface IFoo {"
2370 " void foo(in String[] str);"
2371 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002372 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002373 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002374 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002375 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002376}
2377
Daniel Norman85aed542019-08-21 12:01:14 -07002378TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002379 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002380 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2381 "package p;"
2382 "interface IFoo {"
2383 " void foo(in String[] str);"
2384 " void bar(@utf8InCpp String str);"
2385 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002386 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2387 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002388 "interface IFoo2 {"
2389 " void foo(in String[] str);"
2390 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002391 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002392 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002393 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002394 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002395}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002396
Daniel Norman85aed542019-08-21 12:01:14 -07002397TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002398 const string expected_stderr =
2399 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002400 io_delegate_.SetFileContents("old/p/Enum.aidl",
2401 "package p;"
2402 "enum Enum {"
2403 " FOO = 1,"
2404 " BAR = 2,"
2405 "}");
2406 io_delegate_.SetFileContents("new/p/Enum.aidl",
2407 "package p;"
2408 "enum Enum {"
2409 " FOO = 3,"
2410 " BAR = 2,"
2411 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002412 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002413 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002414 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002415}
2416
2417TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002418 const string expected_stderr =
2419 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2420 "from 0 to 1.\n"
2421 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2422 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002423 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2424 "package p;"
2425 "interface IFoo {"
2426 " void foo(in String[] str);"
2427 " void bar(@utf8InCpp String str);"
2428 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002429 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2430 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002431 "interface IFoo {"
2432 " void bar(@utf8InCpp String str);"
2433 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002434 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002435 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002436 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002437 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002438}
2439
2440TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002441 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002442 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2443 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002444 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002445 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002446 "parcelable Data {"
2447 " int foo;"
2448 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002449 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002450 io_delegate_.SetFileContents("new/p/Data.aidl",
2451 "package p;"
2452 "parcelable Data {"
2453 " int bar;"
2454 " int foo;"
2455 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002456 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002457 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002458 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002459}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002460
Daniel Norman85aed542019-08-21 12:01:14 -07002461TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002462 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002463 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002464 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002465 "interface IFoo {"
2466 " void foo(in String[] str);"
2467 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002468 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002469 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2470 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002471 "interface IFoo {"
2472 " void foo(out String[] str);"
2473 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002474 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002475 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002476 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002477 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002478}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002479
Daniel Norman85aed542019-08-21 12:01:14 -07002480TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002481 const string expected_stderr =
2482 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002483 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2484 "package p;"
2485 "interface IFoo {"
2486 " void foo(in String[] str);"
2487 " void bar(@utf8InCpp String str);"
2488 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002489 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2490 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002491 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002492 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002493 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002494 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002495 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002496 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002497 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002498}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002499
Daniel Norman85aed542019-08-21 12:01:14 -07002500TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002501 const string expected_stderr =
2502 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002503 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2504 "package p;"
2505 "interface IFoo {"
2506 " void foo(in String[] str);"
2507 " void bar(@utf8InCpp String str);"
2508 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002509 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2510 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002511 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002512 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002513 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002514 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002515 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002516 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002517 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002518}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002519
Jooyung Han60b2fde2020-10-29 15:12:40 +09002520TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2521 const string expected_stderr =
2522 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2523 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2524 io_delegate_.SetFileContents("old/p/Foo.aidl",
2525 "package p;"
2526 "@Backing(type=\"byte\")"
2527 "enum Foo {"
2528 " FOO, BAR,"
2529 "}");
2530 io_delegate_.SetFileContents("new/p/Foo.aidl",
2531 "package p;"
2532 "@Backing(type=\"long\")"
2533 "enum Foo {"
2534 " FOO, BAR,"
2535 "}");
2536 CaptureStderr();
2537 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2538 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2539}
2540
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002541TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2542 const string expected_stderr =
2543 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2544 "to @JavaPassthrough(annotation=\"Bob\")\n";
2545 io_delegate_.SetFileContents("old/p/Foo.aidl",
2546 "package p;"
2547 "@JavaPassthrough(annotation=\"Alice\")"
2548 "parcelable Foo {}");
2549 io_delegate_.SetFileContents("new/p/Foo.aidl",
2550 "package p;"
2551 "@JavaPassthrough(annotation=\"Bob\")"
2552 "parcelable Foo {}");
2553
2554 CaptureStderr();
2555 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2556 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2557}
2558
Devin Mooredb7ac512020-08-07 11:17:36 -07002559TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2560 const string expected_stderr =
2561 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2562 io_delegate_.SetFileContents("old/p/Foo.aidl",
2563 "package p;"
2564 "parcelable Foo {"
2565 " int A;"
2566 "}");
2567 io_delegate_.SetFileContents("new/p/Foo.aidl",
2568 "package p;"
2569 "@JavaOnlyStableParcelable parcelable Foo {"
2570 " int A;"
2571 "}");
2572 CaptureStderr();
2573 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2574 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2575}
2576
2577TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2578 const string expected_stderr =
2579 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2580 io_delegate_.SetFileContents("old/p/Foo.aidl",
2581 "package p;"
2582 "@JavaOnlyStableParcelable parcelable Foo {"
2583 " int A;"
2584 "}");
2585 io_delegate_.SetFileContents("new/p/Foo.aidl",
2586 "package p;"
2587 "parcelable Foo {"
2588 " int A;"
2589 "}");
2590 CaptureStderr();
2591 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2592 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2593}
2594
Daniel Norman85aed542019-08-21 12:01:14 -07002595TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002596 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002597 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2598 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002599 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002600 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002601 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002602 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002603}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002604
Daniel Norman85aed542019-08-21 12:01:14 -07002605TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002606 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002607 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2608 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002609 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002610 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002611 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002612}
Jiyong Parka428d212018-08-29 22:26:30 +09002613
Daniel Norman85aed542019-08-21 12:01:14 -07002614TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002615 const string expected_stderr =
2616 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002617 io_delegate_.SetFileContents("old/p/I.aidl",
2618 "package p; interface I {"
2619 "const int A = 1; const int B = 2;}");
2620 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002621 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002622 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002623 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002624}
Jiyong Parka428d212018-08-29 22:26:30 +09002625
Daniel Norman85aed542019-08-21 12:01:14 -07002626TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002627 const string expected_stderr =
2628 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002629 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2630 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002631 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002632 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002633 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002634}
2635
Devin Moorec7e47a32020-08-07 10:55:25 -07002636TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2637 const string expected_stderr =
2638 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2639 "This is an incompatible change for FixedSize types.\n";
2640 io_delegate_.SetFileContents("old/p/Foo.aidl",
2641 "package p; @FixedSize parcelable Foo { int A = 1; }");
2642 io_delegate_.SetFileContents("new/p/Foo.aidl",
2643 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2644 CaptureStderr();
2645 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2646 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2647}
2648
2649TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2650 const string expected_stderr =
2651 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2652 io_delegate_.SetFileContents("old/p/Foo.aidl",
2653 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2654 io_delegate_.SetFileContents("new/p/Foo.aidl",
2655 "package p; @FixedSize parcelable Foo { int A = 1; }");
2656 CaptureStderr();
2657 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2658 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2659}
2660
2661TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2662 const string expected_stderr =
2663 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2664 "a.\n"
2665 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2666 "b.\n"
2667 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2668 "c.\n"
2669 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2670 "d.\n"
2671 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2672 "e.\n"
2673 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2674 "f.\n";
2675
2676 io_delegate_.SetFileContents("Foo.aidl",
2677 "@FixedSize parcelable Foo { "
2678 " int[] a;"
2679 " Bar b;"
2680 " String c;"
2681 " ParcelFileDescriptor d;"
2682 " IBinder e;"
2683 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002684 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002685 "}");
2686 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2687 Options options =
2688 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2689
2690 CaptureStderr();
2691 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2692 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2693}
2694
2695TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2696 const string expected_stderr = "";
2697
2698 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2699 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2700 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2701 Options options =
2702 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2703
2704 CaptureStderr();
2705 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2706 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2707}
2708
Jiyong Park8c380532018-08-30 14:55:26 +09002709TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002710 const string expected_stderr =
2711 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2712 "dir1/q/IBar.aidl\n"
2713 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002714 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002715 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2716 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2717 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2718 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2719
Devin Moore097a3ab2020-03-11 16:08:44 -07002720 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002721 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002722 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002723}
2724
Jiyong Parked65bf42018-08-28 15:43:27 +09002725TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002726 const string expected_stderr =
2727 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2728 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002729 Options options = Options::From("aidl --checkapi old new");
2730 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2731 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002732
2733 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2734
Jiyong Parke59c3682018-09-11 23:10:25 +09002735 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002736 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002737 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002738 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002739}
2740
Jiyong Parke05195e2018-10-08 18:24:23 +09002741TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2742 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2743 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002744 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002745
2746 // use without import
2747 io_delegate_.SetFileContents("p/IFoo.aidl",
2748 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2749 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2750 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002751 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002752
Devin Moore7b8d5c92020-03-17 14:14:08 -07002753 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002754 io_delegate_.SetFileContents(
2755 "p/IFoo.aidl",
2756 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2757 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2758 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002759 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002760
2761 // use with import (as before)
2762 io_delegate_.SetFileContents("p/IFoo.aidl",
2763 "package p;"
2764 "import android.os.ParcelFileDescriptor;"
2765 "interface IFoo{"
2766 " void foo(in ParcelFileDescriptor fd);"
2767 "}");
2768 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2769 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002770 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002771}
Jiyong Parked65bf42018-08-28 15:43:27 +09002772
Jiyong Park3633b722019-04-11 15:38:26 +09002773TEST_F(AidlTest, ManualIds) {
2774 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2775 io_delegate_.SetFileContents("IFoo.aidl",
2776 "interface IFoo {\n"
2777 " void foo() = 0;\n"
2778 " void bar() = 1;\n"
2779 "}");
2780 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2781}
2782
2783TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2784 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2785 io_delegate_.SetFileContents("IFoo.aidl",
2786 "interface IFoo {\n"
2787 " void foo() = 0;\n"
2788 " void bar() = 1;\n"
2789 "}");
2790 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2791}
2792
2793TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002794 const string expected_stderr =
2795 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002796 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2797 io_delegate_.SetFileContents("IFoo.aidl",
2798 "interface IFoo {\n"
2799 " void foo() = 3;\n"
2800 " void bar() = 3;\n"
2801 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002802 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002803 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002804 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002805}
2806
2807TEST_F(AidlTest, FailOnOutOfRangeIds) {
2808 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002809 const string expected_stderr =
2810 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2811 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002812 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2813 io_delegate_.SetFileContents("IFoo.aidl",
2814 "interface IFoo {\n"
2815 " void foo() = 3;\n"
2816 " void bar() = 16777115;\n"
2817 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002818 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002819 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002820 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002821}
2822
2823TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002824 const string expected_stderr =
2825 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002826 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2827 io_delegate_.SetFileContents("IFoo.aidl",
2828 "interface IFoo {\n"
2829 " void foo() = 3;\n"
2830 " void bar();\n"
2831 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002832 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002833 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002834 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002835}
2836
Jiyong Parkc6816252019-07-08 08:12:28 +09002837TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2838 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2839 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2840 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2841 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2842}
2843
2844TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002845 const string expected_stderr =
2846 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2847 "dir/IBar.aidl\n"
2848 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002849 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002850
Jiyong Parkc6816252019-07-08 08:12:28 +09002851 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2852 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2853 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2854 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002855 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002856 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002857 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002858}
2859
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002860TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2861 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2862 "package a.b;\n"
2863 "import a.b.IBar;\n"
2864 "import a.b.IQux;\n"
2865 "interface IFoo { IQux foo(); }\n");
2866 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2867 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2868
2869 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2870 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2871
2872 string output;
2873 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2874 // IBar was imported but wasn't used. include is not expected.
2875 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2876 // IBar was imported and used. include is expected.
2877 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2878}
2879
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002880TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002881 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002882 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002883 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2884 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002885 interface IFoo {
2886 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002887 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002888 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002889 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002890 // JavaPassthrough should work with other types as well (e.g. enum)
2891 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2892 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2893 @JavaPassthrough(annotation="@com.android.AliceTwo")
2894 @Backing(type="byte")
2895 enum MyEnum {
2896 a, b, c
2897 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002898
Jooyung Han4cde01d2020-10-13 11:10:47 +09002899 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002900 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2901
2902 string java_out;
2903 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002904 // type-decl-level annotations with newline at the end
2905 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2906 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2907 // member-decl-level annotations with newline at the end
2908 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2909 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2910 // inline annotations with space at the end
2911 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002912
Jooyung Han4cde01d2020-10-13 11:10:47 +09002913 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2914 // type-decl-level annotations with newline at the end
2915 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2916 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2917
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002918 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002919 Options cpp_options =
2920 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002921 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2922
Jooyung Han4cde01d2020-10-13 11:10:47 +09002923 Options ndk_options =
2924 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002925 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002926
Jooyung Han4cde01d2020-10-13 11:10:47 +09002927 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002928 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002929}
2930
Andrei Homescue61feb52020-08-18 15:44:24 -07002931TEST_F(AidlTest, ParseRustDerive) {
2932 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2933 @RustDerive(Clone=true, Copy=false)
2934 parcelable Foo {
2935 int a;
2936 })");
2937
2938 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2939 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2940
2941 string rust_out;
2942 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2943 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2944
2945 // Other backends shouldn't be bothered
2946 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2947 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2948
2949 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2950 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2951
2952 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2953 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2954}
2955
Jiyong Park56f73d72019-06-11 12:20:28 +09002956class AidlOutputPathTest : public AidlTest {
2957 protected:
2958 void SetUp() override {
2959 AidlTest::SetUp();
2960 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2961 }
2962
2963 void Test(const Options& options, const std::string expected_output_path) {
2964 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2965 // check the existence
2966 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2967 }
2968};
2969
2970TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2971 // <out_dir> / <package_name> / <type_name>.java
2972 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2973}
2974
2975TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2976 // when output file is explicitly set, it is always respected. -o option is
2977 // ignored.
2978 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2979}
2980
2981TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2982 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2983}
2984
2985TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2986 // output is the same as the input file except for the suffix
2987 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2988}
2989
Devin Moore7b8d5c92020-03-17 14:14:08 -07002990TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002991 AidlError error;
2992 const string expected_stderr =
2993 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2994 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002995 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2996 R"(package p;
2997 interface IFoo {
2998 const int int32_max_oob = 2147483650;
2999 }
3000 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003001 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003002 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3003 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003004}
3005
Devin Moore7b8d5c92020-03-17 14:14:08 -07003006TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003007 AidlError error;
3008 const string expected_stderr =
3009 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3010 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003011 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3012 R"(package p;
3013 interface IFoo {
3014 const int int32_min_oob = -2147483650;
3015 }
3016 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003017 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003018 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3019 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003020}
3021
Devin Moore7b8d5c92020-03-17 14:14:08 -07003022TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003023 AidlError error;
3024 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003025 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003026 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003027 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3028 R"(package p;
3029 interface IFoo {
3030 const long int64_max_oob = 21474836509999999999999999;
3031 }
3032 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003033 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003034 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3035 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003036}
3037
Devin Moore7b8d5c92020-03-17 14:14:08 -07003038TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003039 AidlError error;
3040 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003041 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003042 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003043 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3044 R"(package p;
3045 interface IFoo {
3046 const long int64_min_oob = -21474836509999999999999999;
3047 }
3048 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003049 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003050 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3051 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003052}
3053
Devin Moore7b8d5c92020-03-17 14:14:08 -07003054TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003055 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003056 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003057 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003058 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3059 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003060 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3061 R"(package p;
3062 @Backing(type="byte")
3063 enum TestEnum {
3064 FOO = 127,
3065 BAR,
3066 }
3067 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003068 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003069 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003070 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003071}
3072
Devin Mooredecaf292020-04-30 09:16:40 -07003073TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3074 AidlError error;
3075 const string expected_stderr =
3076 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
3077 "be one of: type\n"
3078 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
3079 "be one of: type\n";
3080 CaptureStderr();
3081 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3082 R"(package p;
3083 @Backing(foo="byte")
3084 enum TestEnum {
3085 FOO = 1,
3086 BAR,
3087 }
3088 )",
3089 typenames_, GetLanguage(), &error));
3090 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3091 EXPECT_EQ(AidlError::BAD_TYPE, error);
3092}
3093
Jooyung Han66813932020-10-23 13:24:44 +09003094TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003095 io_delegate_.SetFileContents("Foo.aidl",
3096 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3097 "Map<String, Baz> d; Bar[] e; }");
3098 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3099 io_delegate_.SetFileContents("Baz.aidl",
3100 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003101 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3102 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3103}
3104
Jooyung Han66813932020-10-23 13:24:44 +09003105TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003106 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003107 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003108 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003109 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3110 "named 'bar'.\n";
3111 CaptureStderr();
3112 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3113 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3114 EXPECT_EQ(expected_error, GetCapturedStderr());
3115}
3116
3117TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3118 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3119 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3120 string expected_error =
3121 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003122 "named 'bar'.\n";
3123 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003124 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3125 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003126 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003127}
3128
Jooyung Han66813932020-10-23 13:24:44 +09003129TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003130 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003131 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3132 string expected_error =
3133 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3134 "only be an in parameter.\n";
3135 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003136 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3137 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003138 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003139}
3140
Jooyung Han66813932020-10-23 13:24:44 +09003141TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003142 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003143 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3144 string expected_error =
3145 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3146 "only be an in parameter.\n";
3147 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003148 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3149 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003150 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003151}
3152
Jooyung Han66813932020-10-23 13:24:44 +09003153TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003154 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003155 Options options = Options::From("aidl --lang=java Foo.aidl");
3156 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003157 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3158 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003159 CaptureStderr();
3160 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3161 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3162}
Devin Moore53fc99c2020-08-12 08:07:52 -07003163
Jooyung Han1f14ab32020-10-14 13:48:29 +09003164const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3165
3166#include <a/ByteEnum.h>
3167#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003168#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003169#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003170#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003171#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003172#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003173#include <locale>
3174#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003175#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003176#include <utility>
3177#include <variant>
3178#include <vector>
3179
Jooyung Handf39e192020-11-23 15:59:46 +09003180#ifndef __BIONIC__
3181#define __assert2(a,b,c,d) ((void)0)
3182#endif
3183
Jooyung Han1f14ab32020-10-14 13:48:29 +09003184namespace a {
3185
3186class Foo : public ::android::Parcelable {
3187public:
Jooyung Han97945de2020-10-15 16:41:38 +09003188 inline bool operator!=(const Foo& rhs) const {
3189 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003190 }
Jooyung Han97945de2020-10-15 16:41:38 +09003191 inline bool operator<(const Foo& rhs) const {
3192 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003193 }
Jooyung Han97945de2020-10-15 16:41:38 +09003194 inline bool operator<=(const Foo& rhs) const {
3195 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003196 }
Jooyung Han97945de2020-10-15 16:41:38 +09003197 inline bool operator==(const Foo& rhs) const {
3198 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003199 }
Jooyung Han97945de2020-10-15 16:41:38 +09003200 inline bool operator>(const Foo& rhs) const {
3201 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003202 }
Jooyung Han97945de2020-10-15 16:41:38 +09003203 inline bool operator>=(const Foo& rhs) const {
3204 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003205 }
Jooyung Han97945de2020-10-15 16:41:38 +09003206
Jooyung Han1f14ab32020-10-14 13:48:29 +09003207 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003208 ns = 0, // int[] ns;
3209 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003210 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003211 };
Jooyung Han97945de2020-10-15 16:41:38 +09003212
Jooyung Han1f14ab32020-10-14 13:48:29 +09003213 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003214 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003215
3216 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003217 Foo(const Foo&) = default;
3218 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003219 Foo& operator=(const Foo&) = default;
3220 Foo& operator=(Foo&&) = default;
3221
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003222 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3223 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003224 constexpr Foo(_Tp&& _arg)
3225 : _value(std::forward<_Tp>(_arg)) {}
3226
3227 template <typename... _Tp>
3228 constexpr explicit Foo(_Tp&&... _args)
3229 : _value(std::forward<_Tp>(_args)...) {}
3230
3231 template <Tag _tag, typename... _Tp>
3232 static Foo make(_Tp&&... _args) {
3233 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003234 }
Jooyung Han97945de2020-10-15 16:41:38 +09003235
3236 template <Tag _tag, typename _Tp, typename... _Up>
3237 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3238 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003239 }
3240
3241 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003242 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003243 }
3244
Jooyung Han97945de2020-10-15 16:41:38 +09003245 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003246 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003247 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003248 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003249 }
3250
Jooyung Han97945de2020-10-15 16:41:38 +09003251 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003252 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003253 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003254 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003255 }
3256
Jooyung Han97945de2020-10-15 16:41:38 +09003257 template <Tag _tag, typename... _Tp>
3258 void set(_Tp&&... _args) {
3259 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003260 }
3261
3262 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3263 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3264 static const std::string& getParcelableDescriptor() {
3265 static const std::string DESCIPTOR = "a.Foo";
3266 return DESCIPTOR;
3267 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003268 template <typename _T> class _has_toString {
3269 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3270 template <typename _U> static std::false_type __has_toString(...);
3271 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3272 };
3273 template <typename _T> inline static std::string _call_toString(const _T& t) {
3274 if constexpr (_has_toString<_T>::value) return t.toString();
3275 return "{no toString() implemented}";
3276 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003277 inline std::string toString() const {
3278 std::ostringstream os;
3279 os << "Foo{";
3280 switch (getTag()) {
3281 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3282 case e: os << "e: " << a::toString(get<e>()); break;
3283 case pfd: os << "pfd: " << ""; break;
3284 }
3285 os << "}";
3286 return os.str();
3287 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003288private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003289 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003290}; // class Foo
3291
3292} // namespace a
3293)";
3294
3295const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3296
3297namespace a {
3298
3299::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3300 ::android::status_t _aidl_ret_status;
3301 int32_t _aidl_tag;
3302 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3303 switch (_aidl_tag) {
3304 case ns: {
3305 ::std::vector<int32_t> _aidl_value;
3306 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003307 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3308 set<ns>(_aidl_value);
3309 } else {
3310 // NOLINTNEXTLINE(performance-move-const-arg)
3311 set<ns>(std::move(_aidl_value));
3312 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003313 return ::android::OK; }
3314 case e: {
3315 ::a::ByteEnum _aidl_value;
3316 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003317 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3318 set<e>(_aidl_value);
3319 } else {
3320 // NOLINTNEXTLINE(performance-move-const-arg)
3321 set<e>(std::move(_aidl_value));
3322 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003323 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003324 case pfd: {
3325 ::android::os::ParcelFileDescriptor _aidl_value;
3326 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003327 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3328 set<pfd>(_aidl_value);
3329 } else {
3330 // NOLINTNEXTLINE(performance-move-const-arg)
3331 set<pfd>(std::move(_aidl_value));
3332 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003333 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003334 }
3335 return ::android::BAD_VALUE;
3336}
3337
3338::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3339 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3340 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3341 switch (getTag()) {
3342 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3343 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003344 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003345 }
Jooyung Handf39e192020-11-23 15:59:46 +09003346 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003347}
3348
3349} // namespace a
3350)";
3351
Jooyung Han6beac042020-10-17 21:59:43 +09003352const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3353#include <android/binder_interface_utils.h>
3354#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003355#include <codecvt>
3356#include <locale>
3357#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003358
Jooyung Handf39e192020-11-23 15:59:46 +09003359#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003360#include <type_traits>
3361#include <utility>
3362#include <variant>
3363#include <cstdint>
3364#include <memory>
3365#include <optional>
3366#include <string>
3367#include <vector>
3368#ifdef BINDER_STABILITY_SUPPORT
3369#include <android/binder_stability.h>
3370#endif // BINDER_STABILITY_SUPPORT
3371#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003372
3373#ifndef __BIONIC__
3374#define __assert2(a,b,c,d) ((void)0)
3375#endif
3376
Jooyung Han6beac042020-10-17 21:59:43 +09003377namespace aidl {
3378namespace a {
3379class Foo {
3380public:
3381 typedef std::false_type fixed_size;
3382 static const char* descriptor;
3383
3384 enum Tag : int32_t {
3385 ns = 0, // int[] ns;
3386 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003387 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003388 };
3389
3390 template<typename _Tp>
3391 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3392
3393 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3394 Foo(const Foo&) = default;
3395 Foo(Foo&&) = default;
3396 Foo& operator=(const Foo&) = default;
3397 Foo& operator=(Foo&&) = default;
3398
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003399 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3400 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003401 constexpr Foo(_Tp&& _arg)
3402 : _value(std::forward<_Tp>(_arg)) {}
3403
3404 template <typename... _Tp>
3405 constexpr explicit Foo(_Tp&&... _args)
3406 : _value(std::forward<_Tp>(_args)...) {}
3407
3408 template <Tag _tag, typename... _Tp>
3409 static Foo make(_Tp&&... _args) {
3410 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3411 }
3412
3413 template <Tag _tag, typename _Tp, typename... _Up>
3414 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3415 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3416 }
3417
3418 Tag getTag() const {
3419 return static_cast<Tag>(_value.index());
3420 }
3421
3422 template <Tag _tag>
3423 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003424 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003425 return std::get<_tag>(_value);
3426 }
3427
3428 template <Tag _tag>
3429 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003430 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003431 return std::get<_tag>(_value);
3432 }
3433
3434 template <Tag _tag, typename... _Tp>
3435 void set(_Tp&&... _args) {
3436 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3437 }
3438
3439 binder_status_t readFromParcel(const AParcel* _parcel);
3440 binder_status_t writeToParcel(AParcel* _parcel) const;
Steven Morelandf58804a2020-12-07 18:12:15 +00003441
3442 inline bool operator!=(const Foo& rhs) const {
3443 return _value != rhs._value;
3444 }
3445 inline bool operator<(const Foo& rhs) const {
3446 return _value < rhs._value;
3447 }
3448 inline bool operator<=(const Foo& rhs) const {
3449 return _value <= rhs._value;
3450 }
3451 inline bool operator==(const Foo& rhs) const {
3452 return _value == rhs._value;
3453 }
3454 inline bool operator>(const Foo& rhs) const {
3455 return _value > rhs._value;
3456 }
3457 inline bool operator>=(const Foo& rhs) const {
3458 return _value >= rhs._value;
3459 }
3460
Jooyung Han6beac042020-10-17 21:59:43 +09003461 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003462 template <typename _T> class _has_toString {
3463 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3464 template <typename _U> static std::false_type __has_toString(...);
3465 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3466 };
3467 template <typename _T> inline static std::string _call_toString(const _T& t) {
3468 if constexpr (_has_toString<_T>::value) return t.toString();
3469 return "{no toString() implemented}";
3470 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003471 inline std::string toString() const {
3472 std::ostringstream os;
3473 os << "Foo{";
3474 switch (getTag()) {
3475 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3476 case e: os << "e: " << a::toString(get<e>()); break;
3477 case pfd: os << "pfd: " << ""; break;
3478 }
3479 os << "}";
3480 return os.str();
3481 }
Jooyung Han6beac042020-10-17 21:59:43 +09003482private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003483 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003484};
3485} // namespace a
3486} // namespace aidl
3487)";
3488
3489const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3490
3491#include <android/binder_parcel_utils.h>
3492
3493namespace aidl {
3494namespace a {
3495const char* Foo::descriptor = "a.Foo";
3496
3497binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3498 binder_status_t _aidl_ret_status;
3499 int32_t _aidl_tag;
3500 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3501 switch (_aidl_tag) {
3502 case ns: {
3503 std::vector<int32_t> _aidl_value;
3504 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003505 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3506 set<ns>(_aidl_value);
3507 } else {
3508 // NOLINTNEXTLINE(performance-move-const-arg)
3509 set<ns>(std::move(_aidl_value));
3510 }
Jooyung Han6beac042020-10-17 21:59:43 +09003511 return STATUS_OK; }
3512 case e: {
3513 ::aidl::a::ByteEnum _aidl_value;
3514 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003515 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3516 set<e>(_aidl_value);
3517 } else {
3518 // NOLINTNEXTLINE(performance-move-const-arg)
3519 set<e>(std::move(_aidl_value));
3520 }
Jooyung Han6beac042020-10-17 21:59:43 +09003521 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003522 case pfd: {
3523 ::ndk::ScopedFileDescriptor _aidl_value;
3524 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003525 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3526 set<pfd>(_aidl_value);
3527 } else {
3528 // NOLINTNEXTLINE(performance-move-const-arg)
3529 set<pfd>(std::move(_aidl_value));
3530 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003531 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003532 }
3533 return STATUS_BAD_VALUE;
3534}
3535binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3536 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3537 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3538 switch (getTag()) {
3539 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3540 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003541 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003542 }
Jooyung Handf39e192020-11-23 15:59:46 +09003543 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003544}
3545
3546} // namespace a
3547} // namespace aidl
3548)";
3549
Jooyung Han1f14ab32020-10-14 13:48:29 +09003550const char kUnionExampleExpectedOutputJava[] = R"(/*
3551 * This file is auto-generated. DO NOT MODIFY.
3552 */
3553package a;
3554
3555
3556public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003557 // tags for union fields
3558 public final static int ns = 0; // int[] ns;
3559 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003560 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003561
3562 private int _tag;
3563 private Object _value;
3564
3565 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003566 int[] _value = {42};
3567 this._tag = ns;
3568 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003569 }
Jooyung Han97945de2020-10-15 16:41:38 +09003570
Jooyung Han1f14ab32020-10-14 13:48:29 +09003571 private Foo(android.os.Parcel _aidl_parcel) {
3572 readFromParcel(_aidl_parcel);
3573 }
Jooyung Han97945de2020-10-15 16:41:38 +09003574
Jooyung Hance62f932020-10-25 10:21:49 +09003575 private Foo(int _tag, Object _value) {
3576 this._tag = _tag;
3577 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003578 }
3579
3580 public int getTag() {
3581 return _tag;
3582 }
3583
Jooyung Han97945de2020-10-15 16:41:38 +09003584 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003585
3586 public static Foo ns(int[] _value) {
3587 return new Foo(ns, _value);
3588 }
Jooyung Han97945de2020-10-15 16:41:38 +09003589
Jooyung Han1f14ab32020-10-14 13:48:29 +09003590 public int[] getNs() {
3591 _assertTag(ns);
3592 return (int[]) _value;
3593 }
Jooyung Han97945de2020-10-15 16:41:38 +09003594
Jooyung Han1f14ab32020-10-14 13:48:29 +09003595 public void setNs(int[] _value) {
3596 _set(ns, _value);
3597 }
3598
Jooyung Han97945de2020-10-15 16:41:38 +09003599 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003600
3601 public static Foo e(byte _value) {
3602 return new Foo(e, _value);
3603 }
Jooyung Han97945de2020-10-15 16:41:38 +09003604
Jooyung Han1f14ab32020-10-14 13:48:29 +09003605 public byte getE() {
3606 _assertTag(e);
3607 return (byte) _value;
3608 }
Jooyung Han97945de2020-10-15 16:41:38 +09003609
Jooyung Han1f14ab32020-10-14 13:48:29 +09003610 public void setE(byte _value) {
3611 _set(e, _value);
3612 }
3613
Jooyung Hand2fa0232020-10-19 02:51:41 +09003614 // ParcelFileDescriptor pfd;
3615
3616 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3617 return new Foo(pfd, _value);
3618 }
3619
3620 public android.os.ParcelFileDescriptor getPfd() {
3621 _assertTag(pfd);
3622 return (android.os.ParcelFileDescriptor) _value;
3623 }
3624
3625 public void setPfd(android.os.ParcelFileDescriptor _value) {
3626 _set(pfd, _value);
3627 }
3628
Jooyung Han1f14ab32020-10-14 13:48:29 +09003629 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3630 @Override
3631 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003632 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003633 }
3634 @Override
3635 public Foo[] newArray(int _aidl_size) {
3636 return new Foo[_aidl_size];
3637 }
3638 };
Jooyung Han97945de2020-10-15 16:41:38 +09003639
Jooyung Han1f14ab32020-10-14 13:48:29 +09003640 @Override
3641 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3642 _aidl_parcel.writeInt(_tag);
3643 switch (_tag) {
3644 case ns:
3645 _aidl_parcel.writeIntArray(getNs());
3646 break;
3647 case e:
3648 _aidl_parcel.writeByte(getE());
3649 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003650 case pfd:
3651 if ((getPfd()!=null)) {
3652 _aidl_parcel.writeInt(1);
3653 getPfd().writeToParcel(_aidl_parcel, 0);
3654 }
3655 else {
3656 _aidl_parcel.writeInt(0);
3657 }
3658 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003659 }
3660 }
Jooyung Han97945de2020-10-15 16:41:38 +09003661
Jooyung Han1f14ab32020-10-14 13:48:29 +09003662 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3663 int _aidl_tag;
3664 _aidl_tag = _aidl_parcel.readInt();
3665 switch (_aidl_tag) {
3666 case ns: {
3667 int[] _aidl_value;
3668 _aidl_value = _aidl_parcel.createIntArray();
3669 _set(_aidl_tag, _aidl_value);
3670 return; }
3671 case e: {
3672 byte _aidl_value;
3673 _aidl_value = _aidl_parcel.readByte();
3674 _set(_aidl_tag, _aidl_value);
3675 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003676 case pfd: {
3677 android.os.ParcelFileDescriptor _aidl_value;
3678 if ((0!=_aidl_parcel.readInt())) {
3679 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3680 }
3681 else {
3682 _aidl_value = null;
3683 }
3684 _set(_aidl_tag, _aidl_value);
3685 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003686 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003687 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003688 }
Jooyung Han97945de2020-10-15 16:41:38 +09003689
Jooyung Han1f14ab32020-10-14 13:48:29 +09003690 @Override
3691 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003692 int _mask = 0;
3693 switch (getTag()) {
3694 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003695 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003696 break;
3697 }
3698 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003699 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003700 private int describeContents(Object _v) {
3701 if (_v == null) return 0;
3702 if (_v instanceof android.os.Parcelable) {
3703 return ((android.os.Parcelable) _v).describeContents();
3704 }
3705 return 0;
3706 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003707
3708 private void _assertTag(int tag) {
3709 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003710 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003711 }
3712 }
Jooyung Han97945de2020-10-15 16:41:38 +09003713
Jooyung Han1f14ab32020-10-14 13:48:29 +09003714 private String _tagString(int _tag) {
3715 switch (_tag) {
3716 case ns: return "ns";
3717 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003718 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003719 }
3720 throw new IllegalStateException("unknown field: " + _tag);
3721 }
Jooyung Han97945de2020-10-15 16:41:38 +09003722
Jooyung Hance62f932020-10-25 10:21:49 +09003723 private void _set(int _tag, Object _value) {
3724 this._tag = _tag;
3725 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003726 }
3727}
3728)";
3729
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003730const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3731pub enum Foo {
3732 Ns(Vec<i32>),
3733 E(crate::mangled::_1_a_8_ByteEnum),
3734 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3735}
3736pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3737impl Default for Foo {
3738 fn default() -> Self {
3739 Self::Ns(vec!{42})
3740 }
3741}
3742impl binder::parcel::Serialize for Foo {
3743 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3744 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3745 }
3746}
3747impl binder::parcel::SerializeArray for Foo {}
3748impl binder::parcel::SerializeOption for Foo {
3749 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3750 let this = if let Some(this) = this {
3751 parcel.write(&1i32)?;
3752 this
3753 } else {
3754 return parcel.write(&0i32);
3755 };
3756 match this {
3757 Self::Ns(v) => {
3758 parcel.write(&0i32)?;
3759 parcel.write(v)
3760 }
3761 Self::E(v) => {
3762 parcel.write(&1i32)?;
3763 parcel.write(v)
3764 }
3765 Self::Pfd(v) => {
3766 parcel.write(&2i32)?;
3767 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3768 parcel.write(__field_ref)
3769 }
3770 }
3771 }
3772}
3773impl binder::parcel::Deserialize for Foo {
3774 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3775 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3776 .transpose()
3777 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3778 }
3779}
3780impl binder::parcel::DeserializeArray for Foo {}
3781impl binder::parcel::DeserializeOption for Foo {
3782 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3783 let status: i32 = parcel.read()?;
3784 if status == 0 { return Ok(None); }
3785 let tag: i32 = parcel.read()?;
3786 match tag {
3787 0 => {
3788 let value: Vec<i32> = parcel.read()?;
3789 Ok(Some(Self::Ns(value)))
3790 }
3791 1 => {
3792 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3793 Ok(Some(Self::E(value)))
3794 }
3795 2 => {
3796 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3797 Ok(Some(Self::Pfd(value)))
3798 }
3799 _ => {
3800 Err(binder::StatusCode::BAD_VALUE)
3801 }
3802 }
3803 }
3804}
3805)";
3806
Jooyung Han97945de2020-10-15 16:41:38 +09003807struct AidlUnionTest : ::testing::Test {
3808 void SetUp() override {
3809 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003810package a;
3811import a.ByteEnum;
3812union Foo {
3813 int[] ns = {42};
3814 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003815 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003816}
3817)");
Jooyung Han97945de2020-10-15 16:41:38 +09003818 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003819package a;
3820@Backing(type="byte")
3821enum ByteEnum {
3822 a, b, c
3823}
3824)");
Jooyung Han97945de2020-10-15 16:41:38 +09003825 }
3826 FakeIoDelegate io_delegate_;
3827 void Compile(string lang) {
3828 string command = "aidl --structured -I. -o out --lang=" + lang;
3829 if (lang == "cpp" || lang == "ndk") {
3830 command += " -h out";
3831 }
3832 command += " a/Foo.aidl";
3833 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003834 CaptureStderr();
3835 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3836 auto err = GetCapturedStderr();
3837 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003838 }
3839 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3840 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003841 string actual;
3842 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3843 EXPECT_EQ(expected, actual);
3844 }
Jooyung Han97945de2020-10-15 16:41:38 +09003845 }
3846};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003847
Jooyung Han97945de2020-10-15 16:41:38 +09003848TEST_F(AidlUnionTest, Example_Cpp) {
3849 Compile("cpp");
3850 EXPECT_COMPILE_OUTPUTS(
3851 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3852 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3853}
3854
Jooyung Han6beac042020-10-17 21:59:43 +09003855TEST_F(AidlUnionTest, Example_Ndk) {
3856 Compile("ndk");
3857 EXPECT_COMPILE_OUTPUTS(
3858 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3859 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3860}
3861
Jooyung Han97945de2020-10-15 16:41:38 +09003862TEST_F(AidlUnionTest, Example_Java) {
3863 Compile("java");
3864 EXPECT_COMPILE_OUTPUTS(
3865 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003866}
3867
3868TEST_F(AidlUnionTest, Example_Rust) {
3869 Compile("rust");
3870 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003871}
3872
Jooyung Hanfe89f122020-10-14 03:49:18 +09003873TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3874 const string method = "package a; union Foo {}";
3875 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3876 CaptureStderr();
3877 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3878 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3879}
3880
3881TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3882 const string method = "package a; union Foo { ParcelableHolder x; }";
3883 const string expected_stderr =
3884 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3885 CaptureStderr();
3886 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3887 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3888}
3889
Devin Moore53fc99c2020-08-12 08:07:52 -07003890TEST_P(AidlTest, GenericStructuredParcelable) {
3891 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3892 Options options =
3893 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3894 const string expected_stderr = "";
3895 CaptureStderr();
3896 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3897 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3898}
3899
Jooyung Han3f347ca2020-12-01 12:41:50 +09003900TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3901 io_delegate_.SetFileContents("Foo.aidl",
3902 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3903 Options options =
3904 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::CPP) +
3905 " -o out -h out");
3906 const string expected_stderr = "";
3907 CaptureStderr();
3908 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3909 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3910
3911 string code;
3912 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3913 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3914const ::android::String16& Foo<T,U>::s() {
3915 static const ::android::String16 value(::android::String16(""));
3916 return value;
3917})--"));
3918}
3919
3920TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3921 io_delegate_.SetFileContents("Foo.aidl",
3922 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3923 Options options =
3924 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::NDK) +
3925 " -o out -h out");
3926 const string expected_stderr = "";
3927 CaptureStderr();
3928 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3929 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3930
3931 string code;
3932 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3933 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3934const char* Foo<T, U>::s = "";
3935)--"));
3936}
3937
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003938TEST_F(AidlTest, NestedTypeArgs) {
3939 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003940 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3941
3942 io_delegate_.SetFileContents("a/Foo.aidl",
3943 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3944 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003945 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3946 const string expected_stderr = "";
3947 CaptureStderr();
3948 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3949 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3950
3951 string code;
3952 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003953 EXPECT_THAT(code,
3954 testing::HasSubstr(
3955 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3956}
3957
3958TEST_F(AidlTest, DoubleArrayError) {
3959 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3960
3961 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3962 const string expected_stderr =
3963 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3964 CaptureStderr();
3965 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3966 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3967}
3968
3969TEST_F(AidlTest, DoubleGenericError) {
3970 io_delegate_.SetFileContents("a/Bar.aidl",
3971 "package a; parcelable Bar { List<String><String> a; }");
3972
3973 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3974 const string expected_stderr =
3975 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3976 CaptureStderr();
3977 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3978 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3979}
3980
3981TEST_F(AidlTest, ArrayBeforeGenericError) {
3982 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3983
3984 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3985 const string expected_stderr =
3986 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3987 CaptureStderr();
3988 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3989 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003990}
3991
Jooyung Han14004ed2020-10-16 03:49:57 +09003992struct GenericAidlTest : ::testing::Test {
3993 FakeIoDelegate io_delegate_;
3994 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003995 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003996 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3997 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3998 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3999
4000 Options options = Options::From(cmd);
4001 CaptureStderr();
4002 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
4003 EXPECT_EQ("", GetCapturedStderr());
4004 }
4005};
4006
4007TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4008 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4009 string code;
4010 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4011 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4012 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4013 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4014}
4015
4016TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4017 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4018 string code;
4019 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4020 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4021 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4022 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4023}
4024
Devin Moore53fc99c2020-08-12 08:07:52 -07004025TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4026 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
4027 Options options =
4028 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4029 const string expected_stderr =
4030 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4031 CaptureStderr();
4032 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4033 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4034}
4035
4036TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4037 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
4038 Options options =
4039 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4040 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4041 CaptureStderr();
4042 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4043 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4044}
4045
Jooyung Han7a308842020-10-27 19:06:49 +09004046TEST_P(AidlTest, LongCommentWithinConstExpression) {
4047 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
4048 Options options =
4049 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4050 CaptureStderr();
4051 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
4052 EXPECT_EQ("", GetCapturedStderr());
4053}
4054
Jeongik Chaef44e622020-10-23 16:00:52 +09004055TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4056 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4057 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4058 std::string expectedErr =
4059 "ERROR: a/Foo.aidl:1.28-30: "
4060 "Encountered an untyped List or Map. The use of untyped List/Map is "
4061 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4062 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4063 "ERROR: a/Foo.aidl:1.35-37: "
4064 "Encountered an untyped List or Map. The use of untyped List/Map is "
4065 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4066 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4067 CaptureStderr();
4068 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4069 EXPECT_EQ(expectedErr, GetCapturedStderr());
4070}
4071
4072TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004073 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4074 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004075 std::string expectedErr =
4076 "ERROR: a/Foo.aidl:1.33-35: "
4077 "Encountered an untyped List or Map. The use of untyped List/Map is "
4078 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4079 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4080 "ERROR: a/Foo.aidl:1.40-42: "
4081 "Encountered an untyped List or Map. The use of untyped List/Map is "
4082 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4083 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004084 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09004085 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4086 EXPECT_EQ(expectedErr, GetCapturedStderr());
4087}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004088
Jeongik Chaef44e622020-10-23 16:00:52 +09004089TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4090 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4091 io_delegate_.SetFileContents(
4092 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4093 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4094 std::string expectedErr =
4095 "ERROR: a/Foo.aidl:1.52-54: "
4096 "Encountered an untyped List or Map. The use of untyped List/Map is "
4097 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4098 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4099 "ERROR: a/Foo.aidl:1.64-66: "
4100 "Encountered an untyped List or Map. The use of untyped List/Map is "
4101 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4102 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4103 CaptureStderr();
4104 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4105 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004106}
4107
Jooyung Han690f5842020-12-04 13:02:04 +09004108TEST_F(AidlTest, EnumWithDefaults_Java) {
4109 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4110 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4111package p;
4112import p.Enum;
4113parcelable Foo {
4114 Enum e = Enum.BAR;
4115})");
4116 CaptureStderr();
4117 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
4118 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4119 auto err = GetCapturedStderr();
4120 EXPECT_EQ("", err);
4121
4122 string code;
4123 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
4124 EXPECT_THAT(code, testing::HasSubstr("byte e = Enum.BAR"));
4125}
4126
4127TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4128 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4129 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4130package p;
4131import p.Enum;
4132parcelable Foo {
4133 Enum e = Enum.BAR;
4134})");
4135 CaptureStderr();
4136 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
4137 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4138 auto err = GetCapturedStderr();
4139 EXPECT_EQ("", err);
4140
4141 string code;
4142 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4143 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4144}
4145
4146TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4147 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4148 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4149package p;
4150import p.Enum;
4151parcelable Foo {
4152 Enum e = Enum.BAR;
4153})");
4154 CaptureStderr();
4155 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4156 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4157 auto err = GetCapturedStderr();
4158 EXPECT_EQ("", err);
4159
4160 string code;
4161 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4162 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4163}
4164
4165TEST_F(AidlTest, EnumWithDefaults_Rust) {
4166 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4167 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4168package p;
4169import p.Enum;
4170parcelable Foo {
4171 int n = 42;
4172 Enum e = Enum.BAR;
4173})");
4174 CaptureStderr();
4175 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
4176 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4177 auto err = GetCapturedStderr();
4178 EXPECT_EQ("", err);
4179
4180 string code;
4181 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4182 EXPECT_THAT(code, testing::HasSubstr(R"(
4183 fn default() -> Self {
4184 Self {
4185 n: 42,
4186 e: crate::mangled::_1_p_4_Enum::BAR,
4187 }
4188 })"));
4189}
4190
4191TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4192 import_paths_.insert("a");
4193 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4194 CaptureStderr();
4195 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4196package p;
4197import p.Enum;
4198parcelable Foo {
4199 int e = Enum.FOO | Enum.BAR;
4200})",
4201 typenames_, GetLanguage());
4202 auto err = GetCapturedStderr();
4203 EXPECT_EQ("", err);
4204 EXPECT_TRUE(type);
4205 const auto& fields = type->AsStructuredParcelable()->GetFields();
4206 EXPECT_EQ("int e = 3", fields[0]->ToString());
4207}
4208
4209TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4210 CaptureStderr();
4211 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4212@Backing(type="int")
4213enum Foo {
4214 STANDARD_SHIFT = 16,
4215 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4216 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4217}
4218)",
4219 typenames_, GetLanguage());
4220 auto err = GetCapturedStderr();
4221 EXPECT_EQ("", err);
4222 EXPECT_TRUE(type);
4223 const auto& enum_type = type->AsEnumDeclaration();
4224 string code;
4225 enum_type->Dump(CodeWriter::ForString(&code).get());
4226 EXPECT_EQ(R"--(@Backing(type="int")
4227enum Foo {
4228 STANDARD_SHIFT = 16,
4229 STANDARD_BT709 = 65536,
4230 STANDARD_BT601_625 = 131072,
4231}
4232)--",
4233 code);
4234}
4235
4236TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4237 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4238 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4239package p;
4240import p.Enum;
4241parcelable Foo {
4242 Enum e = Enum.FOO | Enum.BAR;
4243})");
4244 CaptureStderr();
4245 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
4246 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4247 auto err = GetCapturedStderr();
4248 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4249 err);
4250}
4251
4252TEST_P(AidlTest, DefaultWithEmptyArray) {
4253 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4254 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4255 CaptureStderr();
4256 auto options = Options::From("aidl -I a --lang " + Options::LanguageToString(GetLanguage()) +
4257 " -o out -h out a/p/Foo.aidl");
4258 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4259 auto err = GetCapturedStderr();
4260 EXPECT_EQ("", err);
4261}
4262
4263TEST_P(AidlTest, RejectRefsInAnnotation) {
4264 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4265 "package p; interface IFoo {\n"
4266 " const String ANNOTATION = \"@Annotation\";\n"
4267 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4268 "}");
4269 CaptureStderr();
4270 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4271 " -o out -h out a/p/IFoo.aidl");
4272 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4273 auto err = GetCapturedStderr();
4274 EXPECT_EQ(
4275 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4276 "ANNOTATION.\n",
4277 err);
4278}
4279
4280TEST_F(AidlTest, DefaultWithEnumValues) {
4281 io_delegate_.SetFileContents(
4282 "a/p/Foo.aidl",
4283 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4284 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4285 CaptureStderr();
4286 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4287 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4288 auto err = GetCapturedStderr();
4289 EXPECT_EQ("", err);
4290 string code;
4291 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4292 EXPECT_THAT(
4293 code, testing::HasSubstr(
4294 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4295}
4296
Jooyung Han14259392020-12-07 10:00:08 +09004297TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4298 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4299 CaptureStderr();
4300 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4301 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4302 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004303 EXPECT_EQ(
4304 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
4305 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
4306 err);
Jooyung Han14259392020-12-07 10:00:08 +09004307}
4308
4309TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4310 io_delegate_.SetFileContents("a/p/Foo.aidl",
4311 "package p; parcelable Foo { const int A = A + 1; }");
4312 CaptureStderr();
4313 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4314 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4315 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004316 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4317}
4318
4319TEST_F(AidlTest, RecursiveReferences) {
4320 io_delegate_.SetFileContents("a/p/Foo.aidl",
4321 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4322 io_delegate_.SetFileContents("a/p/Bar.aidl",
4323 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4324 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4325 CaptureStderr();
4326 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4327 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4328 EXPECT_EQ("", GetCapturedStderr());
4329}
4330
4331TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4332 string contents = R"(
4333import android.os.IBinder;
4334import android.os.IInterface;
4335interface IFoo {}
4336 )";
4337 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004338}
4339
Jooyung Hane87cdd02020-12-11 16:47:35 +09004340struct ListTypeParam {
4341 string kind;
4342 string literal;
4343};
4344
4345const ListTypeParam kListTypeParams[] = {
4346 {"primitive", "int"}, {"String", "String"},
4347 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4348 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4349 {"union", "a.Union"}, {"interface", "a.IBar"},
4350};
4351
4352const std::map<std::string, std::string> kListSupportExpectations = {
4353 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4354 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4355 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4356 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
4357 {"cpp_String", ""},
4358 {"java_String", ""},
4359 {"ndk_String", ""},
4360 {"rust_String", ""},
4361 {"cpp_IBinder", ""},
4362 {"java_IBinder", ""},
4363 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4364 {"rust_IBinder", ""},
4365 {"cpp_ParcelFileDescriptor", "List<ParcelFileDescriptor> is not supported."},
4366 {"java_ParcelFileDescriptor", ""},
4367 {"ndk_ParcelFileDescriptor", ""},
4368 {"rust_ParcelFileDescriptor", ""},
4369 {"cpp_interface",
4370 "List<a.IBar> is not supported. List in cpp supports only String and IBinder."},
4371 {"java_interface",
4372 "List<a.IBar> is not supported. List in Java supports only String, IBinder, and "
4373 "ParcelFileDescriptor."},
4374 {"ndk_interface", "List<a.IBar> is not supported. List in NDK doesn't support interface."},
4375 {"rust_interface", ""},
4376 {"cpp_parcelable",
4377 "List<a.Foo> is not supported. List in cpp supports only String and IBinder."},
4378 {"java_parcelable", ""},
4379 {"ndk_parcelable", ""},
4380 {"rust_parcelable", ""},
4381 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4382 {"java_enum", "A generic type cannot have any primitive type parameters."},
4383 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4384 {"rust_enum", "A generic type cannot have any primitive type parameters."},
4385 {"cpp_union", "List<a.Union> is not supported. List in cpp supports only String and IBinder."},
4386 {"java_union", ""},
4387 {"ndk_union", ""},
4388 {"rust_union", ""},
4389};
4390
4391using AidlListTestParam = std::tuple<Options::Language, ListTypeParam>;
4392
4393class AidlListTest : public testing::TestWithParam<AidlListTestParam> {
4394 public:
4395 void SetUp() override {
4396 const auto& param = GetParam();
4397 const auto& lang = Options::LanguageToString(std::get<0>(param));
4398 const auto& kind = std::get<1>(param).kind;
4399
4400 FakeIoDelegate io;
4401 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4402 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4403 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
4404 io.SetFileContents("a/Foo.aidl", fmt::format(R"(
4405 package a;
4406 parcelable Foo {{
4407 List<{}> list;
4408 }})",
4409 std::get<1>(param).literal));
4410
4411 const auto options =
4412 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4413 CaptureStderr();
4414 compile_aidl(options, io);
4415 auto it = kListSupportExpectations.find(lang + "_" + kind);
4416 EXPECT_TRUE(it != kListSupportExpectations.end());
4417 const string err = GetCapturedStderr();
4418 if (it->second.empty()) {
4419 EXPECT_EQ("", err);
4420 } else {
4421 EXPECT_THAT(err, testing::HasSubstr(it->second));
4422 }
4423 }
4424};
4425
4426INSTANTIATE_TEST_SUITE_P(
4427 AidlTestSuite, AidlListTest,
4428 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4429 Options::Language::NDK, Options::Language::RUST),
4430 testing::ValuesIn(kListTypeParams)),
4431 [](const testing::TestParamInfo<AidlListTestParam>& info) {
4432 return Options::LanguageToString(std::get<0>(info.param)) + "_" +
4433 std::get<1>(info.param).kind;
4434 });
4435
4436TEST_P(AidlListTest, SupportedTypes) {}
4437
Christopher Wiley90be4e32015-10-20 14:55:25 -07004438} // namespace aidl
4439} // namespace android