blob: 5079296037517afda2531885c6b493c3f8f55297 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070046using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090047using testing::internal::CaptureStderr;
48using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070049
50namespace android {
51namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070052namespace {
53
54const char kExpectedDepFileContents[] =
55R"(place/for/output/p/IFoo.java : \
56 p/IFoo.aidl
57
58p/IFoo.aidl :
59)";
60
Dan Willemsen93298ee2016-11-10 23:55:55 -080061const char kExpectedNinjaDepFileContents[] =
62R"(place/for/output/p/IFoo.java : \
63 p/IFoo.aidl
64)";
65
Jiyong Parkdf202122019-09-30 20:48:35 +090066const char kExpectedParcelableDeclarationDepFileContents[] =
67 R"( : \
68 p/Foo.aidl
69
70p/Foo.aidl :
71)";
72
73const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080074 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070075 p/Foo.aidl
76
77p/Foo.aidl :
78)";
79
Jooyung Hand2fa0232020-10-19 02:51:41 +090080const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090081 R"(/*
82 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090083 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080084@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090085public class Rect implements android.os.Parcelable
86{
87 // Comment
88
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080089 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090090 public int x = 5;
91
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080092 @android.annotation.Hide
93 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000094 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090095
96 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090097
98 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090099 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
100 @Override
101 public Rect createFromParcel(android.os.Parcel _aidl_source) {
102 Rect _aidl_out = new Rect();
103 _aidl_out.readFromParcel(_aidl_source);
104 return _aidl_out;
105 }
106 @Override
107 public Rect[] newArray(int _aidl_size) {
108 return new Rect[_aidl_size];
109 }
110 };
111 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
112 {
113 int _aidl_start_pos = _aidl_parcel.dataPosition();
114 _aidl_parcel.writeInt(0);
115 _aidl_parcel.writeInt(x);
116 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900117 if ((fd!=null)) {
118 _aidl_parcel.writeInt(1);
119 fd.writeToParcel(_aidl_parcel, 0);
120 }
121 else {
122 _aidl_parcel.writeInt(0);
123 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900124 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900125 int _aidl_end_pos = _aidl_parcel.dataPosition();
126 _aidl_parcel.setDataPosition(_aidl_start_pos);
127 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
128 _aidl_parcel.setDataPosition(_aidl_end_pos);
129 }
130 public final void readFromParcel(android.os.Parcel _aidl_parcel)
131 {
132 int _aidl_start_pos = _aidl_parcel.dataPosition();
133 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900134 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900135 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900136 x = _aidl_parcel.readInt();
137 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
138 y = _aidl_parcel.readInt();
139 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900140 if ((0!=_aidl_parcel.readInt())) {
141 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
142 }
143 else {
144 fd = null;
145 }
146 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900147 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900148 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900149 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900150 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
151 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
152 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900153 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
154 }
155 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900156 @Override
157 public int describeContents() {
158 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900159 _mask |= describeContents(fd);
160 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900161 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900162 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900163 private int describeContents(Object _v) {
164 if (_v == null) return 0;
165 if (_v instanceof java.util.Collection) {
166 int _mask = 0;
167 for (Object o : (java.util.Collection) _v) {
168 _mask |= describeContents(o);
169 }
170 return _mask;
171 }
172 if (_v instanceof android.os.Parcelable) {
173 return ((android.os.Parcelable) _v).describeContents();
174 }
175 return 0;
176 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900177}
178)";
179
Devin Moore2f2077a2020-08-28 11:27:53 -0700180// clang-format off
181const char kExpectedCppHeaderOutput[] =
182 R"(#pragma once
183
184#include <binder/IBinder.h>
185#include <binder/IInterface.h>
186#include <binder/Status.h>
187#include <optional>
188#include <utils/String16.h>
189#include <utils/StrongPointer.h>
190#include <vector>
191
192class IFoo : public ::android::IInterface {
193public:
194 DECLARE_META_INTERFACE(Foo)
195 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
196}; // class IFoo
197class IFooDefault : public IFoo {
198public:
199 ::android::IBinder* onAsBinder() override {
200 return nullptr;
201 }
202 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
203 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
204 }
205}; // class IFooDefault
206)";
207// clang-format on
208
Christopher Wileyf8136192016-04-12 14:19:35 -0700209} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700210
Devin Moore7b8d5c92020-03-17 14:14:08 -0700211class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700212 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900213 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
214 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700215 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700216 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900217 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700218 args.emplace_back("aidl");
219 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700220 for (const string& s : additional_arguments) {
221 args.emplace_back(s);
222 }
223 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900224 args.emplace_back("--preprocessed=" + f);
225 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700226 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900227 args.emplace_back("--include=" + i);
228 }
229 args.emplace_back(path);
230 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900231 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900232 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700233 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900234 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900235
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700236 if (error != nullptr) {
237 *error = actual_error;
238 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900239
240 if (actual_error != AidlError::OK) {
241 return nullptr;
242 }
243
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900244 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900245 EXPECT_EQ(1ul, defined_types.size());
246
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900247 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700248 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700249
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 Options::Language GetLanguage() { return GetParam(); }
251
Christopher Wiley0522cd52015-10-28 15:39:44 -0700252 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800253 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900254 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900255 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700256};
257
Devin Moore7b8d5c92020-03-17 14:14:08 -0700258// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
259// tests with each of the supported languages as a parameter.
260INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
261 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700262 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700263 [](const testing::TestParamInfo<Options::Language>& info) {
264 return Options::LanguageToString(info.param);
265 });
266
267TEST_P(AidlTest, AcceptMissingPackage) {
268 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700269}
270
Devin Moore7b8d5c92020-03-17 14:14:08 -0700271TEST_P(AidlTest, EndsInSingleLineComment) {
272 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700273}
274
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000275TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
276 const string expected_stderr =
277 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
278 const std::string file_contents = "package a; interface IBar {}";
279 CaptureStderr();
280 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
281 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
282}
283
284TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
285 const string expected_stderr =
286 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
287 const std::string file_contents = "package a; interface Bar {}";
288 CaptureStderr();
289 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
290 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
291}
292
293TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
294 const string expected_stderr =
295 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
296 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
297 CaptureStderr();
298 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
299 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
300}
301
302TEST_P(AidlTest, EnumRequiresCorrectPath) {
303 const string expected_stderr =
304 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
305 const std::string file_contents = "package a; enum Bar { A, }";
306 CaptureStderr();
307 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
308 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
309}
310
Devin Moore7b8d5c92020-03-17 14:14:08 -0700311TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900312 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700313 io_delegate_.SetFileContents("bar/IBar.aidl",
314 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700315 const string path = "foo/IFoo.aidl";
316 const string contents =
317 "package foo;\n"
318 "import bar.IBar;\n"
319 "interface IFoo { void f(in IBar[] input); }";
320 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
321 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700324}
325
Devin Moore7b8d5c92020-03-17 14:14:08 -0700326TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700327 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700328 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900329}
Devin Moore097a3ab2020-03-11 16:08:44 -0700330
Jiyong Park40782d02020-07-24 19:17:43 +0900331TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700332 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
333 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900334 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
335 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700336 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700337 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700338 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900339}
340
Jiyong Park40782d02020-07-24 19:17:43 +0900341TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700342 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
343 const string expected_stderr =
344 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700345 CaptureStderr();
346 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900348}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700349
Jiyong Park40782d02020-07-24 19:17:43 +0900350TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700351 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900352 const string expected_stderr =
353 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700354 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700355 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700357}
358
Devin Moore7b8d5c92020-03-17 14:14:08 -0700359TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700360 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
361 const string expected_stderr =
362 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700365 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700366}
367
Devin Moore7b8d5c92020-03-17 14:14:08 -0700368TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700369 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
370 const string expected_stderr =
371 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700374 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800375}
376
Devin Moore2f2077a2020-08-28 11:27:53 -0700377TEST_P(AidlTest, AcceptNullableList) {
378 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
379 const string expected_stderr = "";
380 CaptureStderr();
381 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
382 EXPECT_EQ(expected_stderr, GetCapturedStderr());
383}
384
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700386 const string method = "package a; interface IFoo { void f(int a, int a); }";
387 const string expected_stderr =
388 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
389 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700390 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700391 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700392}
393
Jeongik Cha13066da2020-08-06 15:43:19 +0900394TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
395 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900396 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900397 CaptureStderr();
398 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
400}
401
Jooyung Hand902a972020-10-23 17:32:44 +0900402TEST_P(AidlTest, RejectsRepeatedAnnotations) {
403 const string method = R"(@Hide @Hide parcelable Foo {})";
404 const string expected_stderr =
405 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
406 "Foo.aidl:1.1-6\n";
407 CaptureStderr();
408 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
409 EXPECT_EQ(expected_stderr, GetCapturedStderr());
410}
411
Devin Moore7b8d5c92020-03-17 14:14:08 -0700412TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700413 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
414 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
415 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100418}
419
Devin Moore7b8d5c92020-03-17 14:14:08 -0700420TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700421 AidlError error;
422 const string method = "package a; @nullable interface IFoo { int f(); }";
423 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800424 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000425 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
426 "JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700427 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700428 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700429 EXPECT_EQ(expected_stderr, GetCapturedStderr());
430 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800431}
432
Devin Moore7b8d5c92020-03-17 14:14:08 -0700433TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700434 AidlError error;
435 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
436 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800437 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900438 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700439 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700440 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
442 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800443}
444
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700446 AidlError error;
447 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
448 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000449 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900450 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900451 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700452 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000453 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700454 EXPECT_EQ(expected_stderr, GetCapturedStderr());
455 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800456}
457
Devin Moore7b8d5c92020-03-17 14:14:08 -0700458TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700459 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000460 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700461 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000462 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900463 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700464 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700465 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000466 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
468 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800469}
470
Jiyong Park40782d02020-07-24 19:17:43 +0900471TEST_P(AidlTest, ParsesNonNullableAnnotation) {
472 auto parse_result =
473 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
474 ASSERT_NE(nullptr, parse_result);
475 const AidlInterface* interface = parse_result->AsInterface();
476 ASSERT_NE(nullptr, interface);
477 ASSERT_FALSE(interface->GetMethods().empty());
478 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
479}
480
Devin Moore7b8d5c92020-03-17 14:14:08 -0700481TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900482 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
483 typenames_, GetLanguage());
484 ASSERT_NE(nullptr, parse_result);
485 const AidlInterface* interface = parse_result->AsInterface();
486 ASSERT_NE(nullptr, interface);
487 ASSERT_FALSE(interface->GetMethods().empty());
488 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
489}
490
491TEST_P(AidlTest, ParsesNonUtf8Annotations) {
492 auto parse_result =
493 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
494 ASSERT_NE(nullptr, parse_result);
495 const AidlInterface* interface = parse_result->AsInterface();
496 ASSERT_NE(nullptr, interface);
497 ASSERT_FALSE(interface->GetMethods().empty());
498 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800499}
500
Devin Moore7b8d5c92020-03-17 14:14:08 -0700501TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900502 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
503 typenames_, GetLanguage());
504 ASSERT_NE(nullptr, parse_result);
505 const AidlInterface* interface = parse_result->AsInterface();
506 ASSERT_NE(nullptr, interface);
507 ASSERT_FALSE(interface->GetMethods().empty());
508 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800509}
510
Devin Moore7b8d5c92020-03-17 14:14:08 -0700511TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700512 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700513 const string expected_stderr =
514 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
515 "\"vintf\"'\n"
516 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
517 "--structured\n";
518 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700519 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700520 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700521 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700523}
524
Devin Moore7b8d5c92020-03-17 14:14:08 -0700525TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700526 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700527 const string expected_stderr =
528 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
529 "--structured\n";
530 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700531 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700532 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700533 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700535}
536
Devin Moore7b8d5c92020-03-17 14:14:08 -0700537TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700538 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700539 const string expected_stderr =
540 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
541 "\"vintf\"'\n";
542 CaptureStderr();
543 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700544 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700545 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700547}
548
Devin Moore7b8d5c92020-03-17 14:14:08 -0700549TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700550 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700551 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
552 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700553 ASSERT_EQ(AidlError::OK, error);
554 ASSERT_NE(nullptr, parse_result);
555 const AidlInterface* interface = parse_result->AsInterface();
556 ASSERT_NE(nullptr, interface);
557 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700558}
559
Jeongik Cha64783ed2019-06-07 18:30:54 +0900560TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
561 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900562 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
563 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900564 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700565 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900566 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900567 "a/Foo.aidl",
568 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900569
570 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900571 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700572 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900573 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700574 "Parcelable must be defined in AIDL directly.\n";
575 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900576 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700577 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700578
579 CaptureStderr();
580 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
581 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900582}
583
Jooyung Han1cbc4962020-10-25 10:07:15 +0900584TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
585 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
586 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
587 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900588 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
589
590 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900591 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900592 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
593
594 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900595 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900596 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
597
Jooyung Han1cbc4962020-10-25 10:07:15 +0900598 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900599 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
600}
601
Jooyung Han1cbc4962020-10-25 10:07:15 +0900602TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
603 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
604 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
605 CaptureStderr();
606 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
607 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
608 EXPECT_EQ("", GetCapturedStderr());
609
610 const string expected_to_string_method = R"--(
611 @Override
612 public String toString() {
613 switch (_tag) {
614 case a: return "a.Foo.a(" + (getA()) + ")";
615 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
616 }
617 throw new IllegalStateException("unknown field: " + _tag);
618 }
619)--";
620
621 string java_out;
622 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
623 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
624}
625
Jiyong Park9aa3d042020-12-04 23:30:02 +0900626TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
627 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
628 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
629 CaptureStderr();
630 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
631 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
632 EXPECT_EQ("", GetCapturedStderr());
633
634 const std::string expected = R"--(
635 @Override
636 public boolean equals(Object other) {
637 if (this == other) return true;
638 if (other == null) return false;
639 if (!(other instanceof Foo)) return false;
640 Foo that = (Foo)other;
641 if (!java.util.Objects.deepEquals(a, that.a)) return false;
642 if (!java.util.Objects.deepEquals(b, that.b)) return false;
643 return true;
644 }
645
646 @Override
647 public int hashCode() {
648 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
649 }
650)--";
651
652 string java_out;
653 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
654 EXPECT_THAT(java_out, testing::HasSubstr(expected));
655}
656
657TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
658 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
659 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
660 CaptureStderr();
661 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
662 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
663 EXPECT_EQ("", GetCapturedStderr());
664
665 const std::string expected = R"--(
666 @Override
667 public boolean equals(Object other) {
668 if (this == other) return true;
669 if (other == null) return false;
670 if (!(other instanceof Foo)) return false;
671 Foo that = (Foo)other;
672 if (_tag != that._tag) return false;
673 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
674 return true;
675 }
676
677 @Override
678 public int hashCode() {
679 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
680 }
681)--";
682
683 string java_out;
684 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
685 EXPECT_THAT(java_out, testing::HasSubstr(expected));
686}
687
Jooyung Han90345002020-10-23 15:28:53 +0900688TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900689 {
Jooyung Han90345002020-10-23 15:28:53 +0900690 io_delegate_.SetFileContents("a/Foo.aidl",
691 "package a; @JavaDerive(blah=true) parcelable Foo{}");
692 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
693 CaptureStderr();
694 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
695 const std::string expected_stderr =
696 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
697 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
698 }
699
700 {
701 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900702 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
703 CaptureStderr();
704 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
705 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900706 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000707 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
708 "JavaPassthrough, Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900709 EXPECT_EQ(expected_stderr, GetCapturedStderr());
710 }
711
712 {
Jooyung Han90345002020-10-23 15:28:53 +0900713 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900714 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
715 CaptureStderr();
716 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
717 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900718 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900719 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
720 EXPECT_EQ(expected_stderr, GetCapturedStderr());
721 }
722}
723
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900724TEST_P(AidlTest, ParseDescriptorAnnotation) {
725 AidlError error;
726 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
727 typenames_, GetLanguage(), &error, {"--structured"});
728 ASSERT_EQ(AidlError::OK, error);
729 ASSERT_NE(nullptr, parse_result);
730 const AidlInterface* interface = parse_result->AsInterface();
731 ASSERT_NE(nullptr, interface);
732 ASSERT_EQ("IBar", interface->GetDescriptor());
733}
734
Jiyong Park40782d02020-07-24 19:17:43 +0900735TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700736 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700737 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900738}
739
740TEST_P(AidlTest, AcceptsOnewayInterface) {
741 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700742 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700743}
Christopher Wileyef140932015-11-03 09:29:19 -0800744
Devin Moore7b8d5c92020-03-17 14:14:08 -0700745TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700746 const string oneway_method =
747 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700748 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100749}
750
Steven Moreland65297cc2020-04-20 20:17:36 -0700751TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
752 const string oneway_method =
753 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
754 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
755 ASSERT_NE(nullptr, defined);
756 const AidlInterface* iface = defined->AsInterface();
757 ASSERT_NE(nullptr, iface);
758
759 const auto& methods = iface->GetMethods();
760 ASSERT_EQ(1u, methods.size());
761 const auto& method = methods[0];
762 const AidlTypeSpecifier& ret_type = method->GetType();
763
764 // TODO(b/151102494): these annotations should be on the method
765 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
766 ASSERT_TRUE(ret_type.IsHide());
767}
768
Devin Moore7b8d5c92020-03-17 14:14:08 -0700769TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100770 string foo_interface =
771 "package a; /* foo */ interface IFoo {"
772 " /* i */ int i();"
773 " /* j */ @nullable String j();"
774 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
775
Devin Moore7b8d5c92020-03-17 14:14:08 -0700776 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100777 EXPECT_NE(nullptr, parse_result);
778 EXPECT_EQ("/* foo */", parse_result->GetComments());
779
780 const AidlInterface* interface = parse_result->AsInterface();
781 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
782 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
783 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
784}
785
Jooyung Han1a551d32020-10-05 15:37:26 +0900786TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
787 io_delegate_.SetFileContents("p/cpp_header.aidl",
788 R"(package p;
789 parcelable cpp_header cpp_header "bar/header";)");
790 import_paths_.emplace("");
791 const string input_path = "p/IFoo.aidl";
792 const string input = R"(package p;
793 import p.cpp_header;
794 interface IFoo {
795 // get bar
796 cpp_header get();
797 })";
798
799 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
800 EXPECT_NE(nullptr, parse_result);
801 const AidlInterface* interface = parse_result->AsInterface();
802 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
803}
804
Christopher Wileyef140932015-11-03 09:29:19 -0800805TEST_F(AidlTest, ParsesPreprocessedFile) {
806 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
807 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700808 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900809 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700810 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
811 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800812}
813
814TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
815 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
816 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900817
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700818 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900819 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700820 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
821 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800822}
823
Devin Moore7b8d5c92020-03-17 14:14:08 -0700824TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800825 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
826 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
827 "interface IBar {}");
828 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900829 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900830 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700831 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800832 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900833
Christopher Wiley41544372015-11-03 14:52:29 -0800834 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700835 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
836 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800837 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700838 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900839 ambiguous_type.Resolve(typenames_);
840 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800841}
842
Jiyong Park8f6ec462020-01-19 20:52:47 +0900843// Special case of PreferImportToPreprocessed. Imported type should be preferred
844// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700845TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900846 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
847 io_delegate_.SetFileContents("one/IBar.aidl",
848 "package one; "
849 "interface IBar {}");
850 preprocessed_files_.push_back("preprocessed");
851 import_paths_.emplace("");
852 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700853 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900854 EXPECT_NE(nullptr, parse_result);
855
856 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700857 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
858 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900859 // But if we request just "IBar" we should get our imported one.
860 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
861 ambiguous_type.Resolve(typenames_);
862 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
863}
864
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800865TEST_F(AidlTest, WritePreprocessedFile) {
866 io_delegate_.SetFileContents("p/Outer.aidl",
867 "package p; parcelable Outer.Inner;");
868 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
869 "interface IBar {}");
870
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900871 vector<string> args {
872 "aidl",
873 "--preprocess",
874 "preprocessed",
875 "p/Outer.aidl",
876 "one/IBar.aidl"};
877 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800878 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
879
880 string output;
881 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
882 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
883}
884
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900885TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100886 io_delegate_.SetFileContents(
887 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800888 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100889 "parcelable Rect {\n"
890 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800891 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100892 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800893 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100894 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100895 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
896 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100897 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900898 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900899 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100900 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900901
902 vector<string> args{"aidl", "Rect.aidl"};
903 Options options = Options::From(args);
904 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
905
906 string output;
907 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900908 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900909}
910
Devin Moore2f2077a2020-08-28 11:27:53 -0700911TEST_F(AidlTest, CppHeaderIncludes) {
912 io_delegate_.SetFileContents("IFoo.aidl",
913 "interface IFoo {\n"
914 " @nullable List<String> foo();\n"
915 "}");
916
917 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
918 Options options = Options::From(args);
919 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
920 std::vector<std::string> empty;
921 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
922 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
923 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
924
925 // Make sure the optional and String16.h includes are added
926 string output;
927 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
928 EXPECT_EQ(kExpectedCppHeaderOutput, output);
929}
930
Devin Moore7b8d5c92020-03-17 14:14:08 -0700931TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700932 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800933 io_delegate_.SetFileContents("p/Outer.aidl",
934 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900935 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
937 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
938 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700939 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800941}
942
Devin Moore7b8d5c92020-03-17 14:14:08 -0700943TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800944 io_delegate_.SetFileContents("preprocessed",
945 "parcelable p.Outer.Inner;");
946 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900947 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700948 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800949 // TODO(wiley): This should actually return nullptr because we require
950 // the outer class name. However, for legacy reasons,
951 // this behavior must be maintained. b/17415692
952 EXPECT_NE(nullptr, parse_result);
953}
954
Christopher Wiley632801d2015-11-05 14:15:49 -0800955TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700956 const string expected_foo_stderr =
957 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
958 "Declared parcelables should be in their own file and/or cannot be used with --structured "
959 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700960 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
961
Christopher Wiley632801d2015-11-05 14:15:49 -0800962 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700963 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700964 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900965 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700966 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900967
Steven Morelande2c64b42018-09-18 15:06:37 -0700968 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900969 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700970 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900971 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700972 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700973
Devin Moore097a3ab2020-03-11 16:08:44 -0700974 const string expected_bar_stderr =
975 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
976 "Declared parcelables should be in their own file and/or cannot be used with --structured "
977 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700978 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
979
Jiyong Parkda8c6932019-08-12 19:56:08 +0900980 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700981 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700982 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900983 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700984 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700985 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700986 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700987 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700988 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800989}
990
Devin Moore7b8d5c92020-03-17 14:14:08 -0700991TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700992 const string expected_stderr =
993 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
994 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700995 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
996 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700997 AidlError error;
998 CaptureStderr();
999 EXPECT_EQ(
1000 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001001 Parse("p/IFoo.aidl",
1002 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001003 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1005 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001006}
1007
Devin Moore7b8d5c92020-03-17 14:14:08 -07001008TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001009 AidlError error;
1010 const string expected_stderr =
1011 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1012 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001013 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1014 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001015 interface IFoo {
1016 const String DUPLICATED = "d";
1017 const int DUPLICATED = 1;
1018 }
1019 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001020 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001021 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1022 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001023}
1024
Steven Morelande689da22020-11-10 02:06:30 +00001025TEST_P(AidlTest, FailOnTooBigConstant) {
1026 AidlError error;
1027 const string expected_stderr =
1028 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1029 CaptureStderr();
1030 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1031 R"(package p;
1032 interface IFoo {
1033 const byte type2small = 256;
1034 }
1035 )",
1036 typenames_, GetLanguage(), &error));
1037 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1038 EXPECT_EQ(AidlError::BAD_TYPE, error);
1039}
1040
Jooyung Han30f64ad2020-12-15 08:16:31 +09001041TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1042 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1043 CaptureStderr();
1044 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1045 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1046 EXPECT_EQ("", GetCapturedStderr());
1047 string code;
1048 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1049 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1050}
1051
Devin Moore7b8d5c92020-03-17 14:14:08 -07001052TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001053 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001054 const string expected_stderr =
1055 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001056 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001057 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1058 R"(package p;
1059 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001060 parcelable IBar {}
1061 parcelable StructuredParcelable {}
1062 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001063 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001064 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001065 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001066 // Parse success is important for clear error handling even if the cases aren't
1067 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001068 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001069}
1070
Devin Moore7b8d5c92020-03-17 14:14:08 -07001071TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001072 AidlError error;
1073 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1074 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001075 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1077 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001078}
1079
Steven Morelandf9e922f2020-07-08 21:15:27 +00001080TEST_P(AidlTest, FailOnEmptyListWithComma) {
1081 AidlError error;
1082 const string expected_stderr =
1083 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1084 CaptureStderr();
1085 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1086 typenames_, GetLanguage(), &error));
1087 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1088 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1089}
1090
Devin Moore7b8d5c92020-03-17 14:14:08 -07001091TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001092 AidlError error;
1093 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001094 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001095 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001096 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1097 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001098 interface IFoo {
1099 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1100 }
1101 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001102 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001103 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1104 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001105}
1106
Jiyong Park18132182020-06-08 20:24:40 +09001107TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1108 AidlError error;
1109 const string expected_stderr =
1110 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1111 "cpp_header (which can also be used as an identifier)\n";
1112 CaptureStderr();
1113 // Notice the trailing dot(.) in the name, which isn't a correct name
1114 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1115 GetLanguage(), &error));
1116 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1117 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1118}
1119
1120TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1121 AidlError error;
1122 const string expected_stderr =
1123 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1124 "cpp_header (which can also be used as an identifier)\n";
1125 CaptureStderr();
1126 // Notice the trailing dot(.) in the package name
1127 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1128 GetLanguage(), &error));
1129 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1130 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1131}
1132
Devin Moore7b8d5c92020-03-17 14:14:08 -07001133TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001134 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001135 auto parse_result = Parse("p/IFoo.aidl",
1136 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001137 interface IFoo {
1138 const int POSITIVE_HEX_VALUE = 0xf5;
1139 }
1140 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001141 typenames_, GetLanguage(), &error);
1142 EXPECT_NE(nullptr, parse_result);
1143 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001144 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001145 const auto& cpp_constants = interface->GetConstantDeclarations();
1146 EXPECT_EQ((size_t)1, cpp_constants.size());
1147 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001148 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001149 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001150}
1151
Devin Moore7b8d5c92020-03-17 14:14:08 -07001152TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001153 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001154 auto parse_result = Parse("p/IFoo.aidl",
1155 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001156 interface IFoo {
1157 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1158 }
1159 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001160 typenames_, GetLanguage(), &error);
1161 ASSERT_NE(nullptr, parse_result);
1162 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001163 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001164 const auto& cpp_constants = interface->GetConstantDeclarations();
1165 EXPECT_EQ((size_t)1, cpp_constants.size());
1166 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001167 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001168 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001169}
1170
Devin Moore7b8d5c92020-03-17 14:14:08 -07001171TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001172 io_delegate_.SetFileContents(
1173 "p/Outer.aidl",
1174 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001175 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001176 const string input_path = "p/IFoo.aidl";
1177 const string input = "package p; import p.Outer; interface IFoo"
1178 " { Outer.Inner get(); }";
1179
Devin Moore7b8d5c92020-03-17 14:14:08 -07001180 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1181 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001182
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001183 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001184 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001185 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1186 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001187}
1188
Devin Moore7b8d5c92020-03-17 14:14:08 -07001189TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001190 io_delegate_.SetFileContents(
1191 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001192 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001193 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001194 const string input_path = "p/IFoo.aidl";
1195 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001196 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1197 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001198 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001199 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1200 native_type.Resolve(typenames_);
1201
1202 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1203 // C++ understands C++ specific stuff
1204 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1205 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001206 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001207 EXPECT_EQ(1u, headers.size());
1208 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001209}
1210
Christopher Wileyf8136192016-04-12 14:19:35 -07001211TEST_F(AidlTest, WritesCorrectDependencyFile) {
1212 // While the in tree build system always gives us an output file name,
1213 // other android tools take advantage of our ability to infer the intended
1214 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001215 vector<string> args = {
1216 "aidl",
1217 "-d dep/file/path",
1218 "-o place/for/output",
1219 "p/IFoo.aidl"};
1220 Options options = Options::From(args);
1221 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001222 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001223 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001224 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001225 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1226}
1227
Dan Willemsen93298ee2016-11-10 23:55:55 -08001228TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1229 // While the in tree build system always gives us an output file name,
1230 // other android tools take advantage of our ability to infer the intended
1231 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001232 vector<string> args = {
1233 "aidl",
1234 "-d dep/file/path",
1235 "--ninja",
1236 "-o place/for/output",
1237 "p/IFoo.aidl"};
1238 Options options = Options::From(args);
1239 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001240 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001241 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001242 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001243 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1244}
1245
Jiyong Parkdf202122019-09-30 20:48:35 +09001246TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001247 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1248 // this by calling aidl with every .aidl file it finds, then parsing the
1249 // generated dependency files. Those that reference .java output files are
1250 // for interfaces and those that do not are parcelables. However, for both
1251 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001252 vector<string> args = {
1253 "aidl",
1254 "-o place/for/output",
1255 "-d dep/file/path",
1256 "p/Foo.aidl"};
1257 Options options = Options::From(args);
1258 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001259 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001260 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001261 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001262 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1263}
1264
1265TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1266 vector<string> args = {
1267 "aidl",
1268 "--structured",
1269 "-o place/for/output",
1270 "-d dep/file/path",
1271 "p/Foo.aidl"};
1272 Options options = Options::From(args);
1273 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1274 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1275 string actual_dep_file_contents;
1276 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1277 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001278}
1279
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001280TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1281 vector<string> args = {
1282 "aidl",
1283 "--lang=java",
1284 "-o place/for/output",
1285 "p/Foo.aidl"};
1286 Options options = Options::From(args);
1287 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1288 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1289 string output_file_contents;
1290 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1291}
1292
Jeongik Cha08ca2182019-11-21 14:01:13 +09001293// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001294TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001295 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001296 "package a; interface IFoo {\n"
1297 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001298 string expected_stderr;
1299 switch (GetLanguage()) {
1300 case Options::Language::CPP:
1301 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001302 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001303 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1304 "String and IBinder.\n";
1305 break;
1306 case Options::Language::JAVA:
1307 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001308 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001309 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1310 "String, IBinder, and ParcelFileDescriptor.\n";
1311 break;
1312 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001313 case Options::Language::RUST:
1314 expected_stderr =
1315 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1316 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001317 default:
1318 AIDL_FATAL(AIDL_LOCATION_HERE)
1319 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1320 }
1321 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001322 AidlTypenames tn1;
1323 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001324 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001325
1326 string primitive_parcelable =
1327 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001328 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001329 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001330 AidlTypenames tn2;
1331 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001332 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001333}
1334
Devin Moore21b26772020-08-26 16:37:56 -07001335TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001336 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001337 const string list_array_parcelable =
1338 "package a; parcelable Foo {\n"
1339 " List[] lists; }";
1340 CaptureStderr();
1341 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1342 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1343}
1344
Jiyong Parkf8d53612020-05-04 14:06:13 +09001345TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1346 AidlError error;
1347 string expected_stderr =
1348 "ERROR: a/IFoo.aidl:2.7-11: "
1349 "Encountered an untyped List or Map. The use of untyped List/Map is "
1350 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1351 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1352 if (GetLanguage() != Options::Language::JAVA) {
1353 expected_stderr =
1354 "ERROR: a/IFoo.aidl:2.1-7: "
1355 "Currently, only the Java backend supports non-generic List.\n";
1356 }
1357
1358 const string primitive_interface =
1359 "package a; interface IFoo {\n"
1360 " List foo(); }";
1361 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001362 AidlTypenames tn1;
1363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001364 {"--structured"}));
1365 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001366
1367 string primitive_parcelable =
1368 "package a; parcelable IFoo {\n"
1369 " List foo;}";
1370 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001371 AidlTypenames tn2;
1372 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001373 {"--structured"}));
1374 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1375}
1376
Jeongik Cha225519b2020-08-29 01:55:32 +09001377TEST_P(AidlTest, ExtensionTest) {
1378 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001379 string extendable_parcelable =
1380 "package a; parcelable Data {\n"
1381 " ParcelableHolder extension;\n"
1382 " ParcelableHolder extension2;\n"
1383 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001384 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001385 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1386 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001387 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001388 "yet.\n",
1389 GetCapturedStderr());
1390 } else {
1391 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1392 EXPECT_EQ("", GetCapturedStderr());
1393 }
1394}
1395TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1396 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001397 string parcelableholder_return_interface =
1398 "package a; interface IFoo {\n"
1399 " ParcelableHolder foo();\n"
1400 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001401 EXPECT_EQ(nullptr,
1402 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001403
Jeongik Cha8f02a532020-10-14 00:16:28 +09001404 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001405 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001406 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001407 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001408 "yet.\n",
1409 GetCapturedStderr());
1410 return;
1411 }
1412 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1413 GetCapturedStderr());
1414}
1415
1416TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1417 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001418 string extendable_parcelable_arg_interface =
1419 "package a; interface IFoo {\n"
1420 " void foo(in ParcelableHolder ph);\n"
1421 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001422 EXPECT_EQ(nullptr,
1423 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1424
Jeongik Cha8f02a532020-10-14 00:16:28 +09001425 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001426 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001427 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001428 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001429 "yet.\n",
1430 GetCapturedStderr());
1431 return;
1432 }
1433 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1434 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001435}
1436
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001437TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1438 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1439 Options options =
1440 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1441 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1442 CaptureStderr();
1443 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1444 if (GetLanguage() == Options::Language::RUST) {
1445 EXPECT_EQ(
1446 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1447 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1448 "yet.\n",
1449 GetCapturedStderr());
1450 return;
1451 }
1452 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1453}
1454
Jooyung Han3f347ca2020-12-01 12:41:50 +09001455TEST_P(AidlTest, ParcelablesWithConstants) {
1456 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
1457 Options options =
1458 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1459 CaptureStderr();
1460 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1461 EXPECT_EQ("", GetCapturedStderr());
1462}
1463
1464TEST_P(AidlTest, UnionWithConstants) {
1465 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
1466 Options options =
1467 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1468 CaptureStderr();
1469 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1470 EXPECT_EQ("", GetCapturedStderr());
1471}
1472
Jiyong Park02da7422018-07-16 16:00:26 +09001473TEST_F(AidlTest, ApiDump) {
1474 io_delegate_.SetFileContents(
1475 "foo/bar/IFoo.aidl",
1476 "package foo.bar;\n"
1477 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001478 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001479 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001480 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001481 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1482 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1483 " IFoo foo3(IFoo foo);\n"
1484 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001485 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001486 " const int A = 1;\n"
1487 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001488 "}\n");
1489 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1490 "package foo.bar;\n"
1491 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001492 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001493 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001494 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001495 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001496 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001497 " int y;\n"
1498 " IFoo foo;\n"
1499 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001500 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001501 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001502 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001503 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001504 "}\n");
1505 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001506 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1507 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001508 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001509 bool result = dump_api(options, io_delegate_);
1510 ASSERT_TRUE(result);
1511 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001512 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001513 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001514/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001515interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001516 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001517 int foo(out int[] a, String b, boolean c, inout List<String> d);
1518 int foo2(@utf8InCpp String x, inout List<String> y);
1519 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1520 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001521 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001522 const int A = 1;
1523 const String STR = "Hello";
1524}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001525)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001526
Jiyong Parke59c3682018-09-11 23:10:25 +09001527 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001528 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001529/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001530parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001531 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001532 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001533 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001534 int y;
1535 foo.bar.IFoo foo;
1536 List<foo.bar.IFoo> a;
1537 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001538 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001539 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001540}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001541)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001542}
1543
Jiyong Parked65bf42018-08-28 15:43:27 +09001544TEST_F(AidlTest, ApiDumpWithManualIds) {
1545 io_delegate_.SetFileContents(
1546 "foo/bar/IFoo.aidl",
1547 "package foo.bar;\n"
1548 "interface IFoo {\n"
1549 " int foo() = 1;\n"
1550 " int bar() = 2;\n"
1551 " int baz() = 10;\n"
1552 "}\n");
1553
Jiyong Parke59c3682018-09-11 23:10:25 +09001554 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001555 Options options = Options::From(args);
1556 bool result = dump_api(options, io_delegate_);
1557 ASSERT_TRUE(result);
1558 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001559 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001560 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001561interface IFoo {
1562 int foo() = 1;
1563 int bar() = 2;
1564 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001565}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001566)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001567}
1568
1569TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001570 const string expected_stderr =
1571 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1572 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001573 io_delegate_.SetFileContents(
1574 "foo/bar/IFoo.aidl",
1575 "package foo.bar;\n"
1576 "interface IFoo {\n"
1577 " int foo() = 1;\n"
1578 " int bar();\n"
1579 " int baz() = 10;\n"
1580 "}\n");
1581
Jiyong Parke59c3682018-09-11 23:10:25 +09001582 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001583 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001584 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001585 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001586 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001587}
1588
Jooyung Han965e31d2020-11-27 12:30:16 +09001589TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1590 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1591 "package foo.bar;\n"
1592 "interface IFoo {\n"
1593 " @utf8InCpp String foo();\n"
1594 " const @utf8InCpp String bar = \"bar\";\n"
1595 "}\n");
1596
1597 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1598 Options options = Options::From(args);
1599 CaptureStderr();
1600 EXPECT_TRUE(dump_api(options, io_delegate_));
1601 EXPECT_EQ("", GetCapturedStderr());
1602 string actual;
1603 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001604 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1605interface IFoo {
1606 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001607 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001608}
1609)"),
1610 actual);
1611}
1612
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001613TEST_F(AidlTest, ApiDumpWithEnums) {
1614 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1615 "package foo.bar;\n"
1616 "enum Enum {\n"
1617 " FOO,\n"
1618 " BAR = FOO + 1,\n"
1619 "}\n");
1620
1621 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1622 Options options = Options::From(args);
1623 CaptureStderr();
1624 EXPECT_TRUE(dump_api(options, io_delegate_));
1625 EXPECT_EQ("", GetCapturedStderr());
1626 string actual;
1627 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1628 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1629 "enum Enum {\n"
1630 " FOO = 0,\n"
1631 " BAR = 1,\n"
1632 "}\n"),
1633 actual);
1634}
1635
1636TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1637 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1638 "package foo.bar;\n"
1639 "enum Enum {\n"
1640 " FOO,\n"
1641 "}\n");
1642 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1643 "package foo.bar;\n"
1644 "import foo.bar.Enum;\n"
1645 "parcelable Foo {\n"
1646 " Enum e = Enum.FOO;\n"
1647 "}\n");
1648
1649 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1650 Options options = Options::From(args);
1651 CaptureStderr();
1652 EXPECT_TRUE(dump_api(options, io_delegate_));
1653 EXPECT_EQ("", GetCapturedStderr());
1654 string actual;
1655 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1656 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1657 "parcelable Foo {\n"
1658 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1659 "}\n"),
1660 actual);
1661}
1662
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001663TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001664 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001665 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1666 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001667 const string expected_map_stderr =
1668 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001669 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1670 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001671 "package p; interface IFoo {"
1672 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001673 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001674 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001675 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001676
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001677 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001678 "package p; interface IFoo {"
1679 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001680 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001681 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001682 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001683}
1684
Jeongik Chae48d9942020-01-02 17:39:00 +09001685TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001686 const string expected_stderr =
1687 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001688 Options options = Options::From("aidl -I p p/IFoo.aidl");
1689 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1690
1691 io_delegate_.SetFileContents("p/IFoo.aidl",
1692 "package p; interface IFoo {"
1693 "Map<String, Bar> foo();}");
1694 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1695
1696 io_delegate_.SetFileContents("p/IFoo.aidl",
1697 "package p; interface IFoo {"
1698 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001699 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001700 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001701 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001702
1703 io_delegate_.SetFileContents("p/IFoo.aidl",
1704 "package p; interface IFoo {"
1705 "Map<String, String> foo();}");
1706 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1707
1708 io_delegate_.SetFileContents("p/IFoo.aidl",
1709 "package p; interface IFoo {"
1710 "Map<String, ParcelFileDescriptor> foo();}");
1711 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1712}
1713
Jeongik Chadf76dc72019-11-28 00:08:47 +09001714TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001715 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001716 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1717 io_delegate_.SetFileContents(options.InputFiles().front(),
1718 "package p; interface IFoo {"
1719 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001720 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001721 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001722 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001723}
1724
1725TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1726 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1727 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001728 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001729 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001730 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1731 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001732
1733 Options options = Options::From("aidl -I p p/IFoo.aidl");
1734 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1735 io_delegate_.SetFileContents("p/IFoo.aidl",
1736 "package p; interface IFoo {"
1737 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001738 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001739 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001740 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001741 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001742 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001743 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001744 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1745 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001746 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1747 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1748 io_delegate_.SetFileContents("p/IFoo.aidl",
1749 "package p; interface IFoo {"
1750 "Bar<String, ParcelFileDescriptor> foo();}");
1751 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001752
1753 io_delegate_.SetFileContents("p/IFoo.aidl",
1754 "package p; interface IFoo {"
1755 "Bar<int, long> foo();}");
1756
1757 io_delegate_.SetFileContents("p/IFoo.aidl",
1758 "package p; interface IFoo {"
1759 "Bar<int[], long[]> foo();}");
1760
1761 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001762}
1763
Jeongik Cha0e426012019-07-29 15:57:02 +09001764TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1765 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001766 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1767 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001768 for (const auto& rawOption : rawOptions) {
1769 string expected_stderr =
1770 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001771 Options options = Options::From(rawOption);
1772 io_delegate_.SetFileContents(options.InputFiles().front(),
1773 "package foo.bar;\n"
1774 "interface IFoo1 { int foo(); }\n"
1775 "interface IFoo2 { int foo(); }\n"
1776 "parcelable Data1 { int a; int b;}\n"
1777 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001778 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001779 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001780 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001781
Jeongik Cha0e426012019-07-29 15:57:02 +09001782 io_delegate_.SetFileContents(options.InputFiles().front(),
1783 "package foo.bar;\n"
1784 "interface IFoo1 { int foo(); }\n"
1785 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001786 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001787 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001788 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001789
Devin Moore5de18ed2020-04-02 13:52:29 -07001790 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001791 io_delegate_.SetFileContents(options.InputFiles().front(),
1792 "package foo.bar;\n"
1793 "parcelable Data1 { int a; int b;}\n"
1794 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001795 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001796 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001797 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001798 }
1799}
1800
Devin Moorebdba2a82020-03-31 15:19:02 -07001801TEST_P(AidlTest, FailParseOnEmptyFile) {
1802 const string contents = "";
1803 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1804 CaptureStderr();
1805 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1806 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1807}
1808
Jiyong Parkb034bf02018-07-30 17:44:33 +09001809TEST_F(AidlTest, MultipleInputFiles) {
1810 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001811 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001812
1813 io_delegate_.SetFileContents(options.InputFiles().at(0),
1814 "package foo.bar;\n"
1815 "import foo.bar.Data;\n"
1816 "interface IFoo { Data getData(); }\n");
1817
1818 io_delegate_.SetFileContents(options.InputFiles().at(1),
1819 "package foo.bar;\n"
1820 "import foo.bar.IFoo;\n"
1821 "parcelable Data { IFoo foo; }\n");
1822
1823 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1824
1825 string content;
1826 for (const auto file : {
1827 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1828 content.clear();
1829 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1830 EXPECT_FALSE(content.empty());
1831 }
1832}
1833
1834TEST_F(AidlTest, MultipleInputFilesCpp) {
1835 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001836 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001837
1838 io_delegate_.SetFileContents(options.InputFiles().at(0),
1839 "package foo.bar;\n"
1840 "import foo.bar.Data;\n"
1841 "interface IFoo { Data getData(); }\n");
1842
1843 io_delegate_.SetFileContents(options.InputFiles().at(1),
1844 "package foo.bar;\n"
1845 "import foo.bar.IFoo;\n"
1846 "parcelable Data { IFoo foo; }\n");
1847
1848 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1849
1850 string content;
1851 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001852 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001853 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1854 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1855 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1856 content.clear();
1857 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1858 EXPECT_FALSE(content.empty());
1859 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001860}
1861
Andrei Homescub62afd92020-05-11 19:24:59 -07001862TEST_F(AidlTest, MultipleInputFilesRust) {
1863 Options options =
1864 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1865
1866 io_delegate_.SetFileContents(options.InputFiles().at(0),
1867 "package foo.bar;\n"
1868 "import foo.bar.Data;\n"
1869 "interface IFoo { Data getData(); }\n");
1870
1871 io_delegate_.SetFileContents(options.InputFiles().at(1),
1872 "package foo.bar;\n"
1873 "import foo.bar.IFoo;\n"
1874 "parcelable Data { IFoo foo; }\n");
1875
1876 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1877
1878 string content;
1879 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1880 content.clear();
1881 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1882 EXPECT_FALSE(content.empty());
1883 }
1884}
1885
Devin Moore097a3ab2020-03-11 16:08:44 -07001886TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1887 const string expected_stderr =
1888 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001889 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1890 // int getInterfaceVersion() is one of the meta transactions
1891 io_delegate_.SetFileContents(options.InputFiles().front(),
1892 "package p; interface IFoo {"
1893 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001894 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001895 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001896 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1897}
Jiyong Park309668e2018-07-28 16:55:44 +09001898
Devin Moore097a3ab2020-03-11 16:08:44 -07001899TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1900 // boolean getInterfaceVersion() is not a meta transaction, but should be
1901 // prevented because return type is not part of a method signature
1902 const string expected_stderr =
1903 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1904 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001905 io_delegate_.SetFileContents(options.InputFiles().front(),
1906 "package p; interface IFoo {"
1907 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001908 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001909 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001910 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1911}
Jiyong Park309668e2018-07-28 16:55:44 +09001912
Devin Moore097a3ab2020-03-11 16:08:44 -07001913TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001914 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001915 const string expected_stderr =
1916 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1917 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001918 io_delegate_.SetFileContents(options.InputFiles().front(),
1919 "package p; interface IFoo {"
1920 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001921 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001922 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001923 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001924
1925 // this is not a meta interface method as it differs type arguments
1926 io_delegate_.SetFileContents(options.InputFiles().front(),
1927 "package p; interface IFoo {"
1928 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001929 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001930}
1931
Daniel Norman85aed542019-08-21 12:01:14 -07001932TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001933 Options options = Options::From("aidl --checkapi old new");
1934 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1935 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1936 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1937 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1938
1939 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1940}
1941
Jiyong Park3656c3c2018-08-01 20:02:01 +09001942TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001943 Options options = Options::From("aidl --checkapi old new");
1944 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1945 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001946
1947 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1948}
1949
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001950TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1951 Options options = Options::From("aidl --checkapi old new");
1952 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1953 const string enum_definition = "package p; enum Enum { FOO }";
1954 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1955 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1956 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1957 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1958
1959 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1960}
1961
Daniel Norman85aed542019-08-21 12:01:14 -07001962class AidlTestCompatibleChanges : public AidlTest {
1963 protected:
1964 Options options_ = Options::From("aidl --checkapi old new");
1965};
1966
1967TEST_F(AidlTestCompatibleChanges, NewType) {
1968 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1969 "package p;"
1970 "interface IFoo {"
1971 " void foo(int a);"
1972 "}");
1973 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1974 "package p;"
1975 "interface IFoo {"
1976 " void foo(int a);"
1977 "}");
1978 io_delegate_.SetFileContents("new/p/IBar.aidl",
1979 "package p;"
1980 "interface IBar {"
1981 " void bar();"
1982 "}");
1983 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1984}
1985
1986TEST_F(AidlTestCompatibleChanges, NewMethod) {
1987 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1988 "package p;"
1989 "interface IFoo {"
1990 " void foo(int a);"
1991 "}");
1992 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1993 "package p;"
1994 "interface IFoo {"
1995 " void foo(int a);"
1996 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001997 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001998 "}");
1999 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2000}
2001
2002TEST_F(AidlTestCompatibleChanges, NewField) {
2003 io_delegate_.SetFileContents("old/p/Data.aidl",
2004 "package p;"
2005 "parcelable Data {"
2006 " int foo;"
2007 "}");
2008 io_delegate_.SetFileContents("new/p/Data.aidl",
2009 "package p;"
2010 "parcelable Data {"
2011 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07002012 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09002013 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07002014 "}");
2015 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2016}
2017
2018TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
2019 io_delegate_.SetFileContents("old/p/Enum.aidl",
2020 "package p;"
2021 "enum Enum {"
2022 " FOO = 1,"
2023 "}");
2024 io_delegate_.SetFileContents("new/p/Enum.aidl",
2025 "package p;"
2026 "enum Enum {"
2027 " FOO = 1,"
2028 " BAR = 2,"
2029 "}");
2030 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2031}
2032
2033TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
2034 io_delegate_.SetFileContents("old/p/Enum.aidl",
2035 "package p;"
2036 "enum Enum {"
2037 " FOO = 1,"
2038 " BAR = 2,"
2039 "}");
2040 io_delegate_.SetFileContents("new/p/Enum.aidl",
2041 "package p;"
2042 "enum Enum {"
2043 " BAR = 2,"
2044 " FOO = 1,"
2045 "}");
2046 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2047}
2048
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002049TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2050 io_delegate_.SetFileContents("old/p/Union.aidl",
2051 "package p;"
2052 "union Union {"
2053 " String foo;"
2054 "}");
2055 io_delegate_.SetFileContents("new/p/Union.aidl",
2056 "package p;"
2057 "union Union {"
2058 " String foo;"
2059 " int num;"
2060 "}");
2061 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2062}
2063
Daniel Norman85aed542019-08-21 12:01:14 -07002064TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002065 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2066 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002067 "interface IFoo {"
2068 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002069 "}");
2070 io_delegate_.SetFileContents("old/p/Data.aidl",
2071 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002072 "parcelable Data {"
2073 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002074 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002075 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2076 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002077 "interface IFoo {"
2078 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002079 "}");
2080 io_delegate_.SetFileContents("new/p/Data.aidl",
2081 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002082 "parcelable Data {"
2083 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002084 "}");
2085 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2086 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002087 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002088 " void foo(int a);"
2089 "}");
2090 io_delegate_.SetFileContents("new/q/Data.aidl",
2091 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002092 "parcelable Data {"
2093 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002094 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002095 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2096}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002097
Daniel Norman85aed542019-08-21 12:01:14 -07002098TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2099 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2100 "package p;"
2101 "interface IFoo {"
2102 " void foo(int a);"
2103 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002104 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2105 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002106 "interface IFoo {"
2107 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002108 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002109 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2110}
Jiyong Parke59c3682018-09-11 23:10:25 +09002111
Daniel Norman85aed542019-08-21 12:01:14 -07002112TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002113 io_delegate_.SetFileContents("old/p/I.aidl",
2114 "package p; interface I {"
2115 "const int A = 1; }");
2116 io_delegate_.SetFileContents("new/p/I.aidl",
2117 "package p ; interface I {"
2118 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002119 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2120}
Jiyong Parka428d212018-08-29 22:26:30 +09002121
Daniel Norman85aed542019-08-21 12:01:14 -07002122TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002123 io_delegate_.SetFileContents("old/p/I.aidl",
2124 "package p; interface I {"
2125 "const int A = 1; const int B = 2;}");
2126 io_delegate_.SetFileContents("new/p/I.aidl",
2127 "package p ; interface I {"
2128 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002129 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002130}
2131
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002132TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2133 io_delegate_.SetFileContents("old/p/Foo.aidl",
2134 "package p;"
2135 "@JavaPassthrough(annotation=\"Alice\")"
2136 "@JavaPassthrough(annotation=\"Bob\")"
2137 "parcelable Foo {}");
2138 io_delegate_.SetFileContents("new/p/Foo.aidl",
2139 "package p;"
2140 "@JavaPassthrough(annotation=\"Bob\")"
2141 "@JavaPassthrough(annotation=\"Alice\")"
2142 "parcelable Foo {}");
2143 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2144}
2145
Jooyung Han00073272020-11-27 14:20:20 +09002146TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2147 io_delegate_.SetFileContents("old/p/Foo.aidl",
2148 "package p;"
2149 "parcelable Foo {}");
2150 io_delegate_.SetFileContents("new/p/Foo.aidl",
2151 "package p;"
2152 "@JavaPassthrough(annotation=\"@Deprecated\")"
2153 "parcelable Foo {}");
2154 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2155}
2156
Jooyung Han636fd2f2020-10-22 11:33:45 +09002157TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2158 io_delegate_.SetFileContents("old/p/Data.aidl",
2159 "package p;"
2160 "parcelable Data {"
2161 " int num;"
2162 "}");
2163 io_delegate_.SetFileContents(
2164 "new/p/Data.aidl",
2165 "package p;"
2166 "parcelable Data {"
2167 " int num;"
2168 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2169 "}");
2170 io_delegate_.SetFileContents("new/p/Enum.aidl",
2171 "package p;"
2172 "enum Enum {"
2173 " FOO = 0,"
2174 " BAR = 1,"
2175 "}");
2176 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2177}
2178
Daniel Norman85aed542019-08-21 12:01:14 -07002179class AidlTestIncompatibleChanges : public AidlTest {
2180 protected:
2181 Options options_ = Options::From("aidl --checkapi old new");
2182};
2183
2184TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002185 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002186 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2187 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002188 "interface IFoo {"
2189 " void foo(in String[] str);"
2190 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002191 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002192 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002193 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002194 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002195}
2196
2197TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002198 const string expected_stderr =
2199 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002200 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2201 "package p;"
2202 "interface IFoo {"
2203 " void foo(in String[] str);"
2204 " void bar(@utf8InCpp String str);"
2205 "}");
2206 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2207 "package p;"
2208 "interface IFoo {"
2209 " void foo(in String[] str);"
2210 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002211 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002212 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002213 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002214}
2215
Jiyong Parkf8d53612020-05-04 14:06:13 +09002216TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2217 const string expected_stderr =
2218 "ERROR: new/p/IFoo.aidl:1.61-65: "
2219 "Encountered an untyped List or Map. The use of untyped List/Map is "
2220 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2221 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2222 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2223 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2224 "package p;"
2225 "interface IFoo {"
2226 " void foo(in String[] str);"
2227 "}");
2228 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2229 "package p;"
2230 "interface IFoo {"
2231 " void foo(in String[] str);"
2232 " void bar(in List arg);"
2233 "}");
2234 CaptureStderr();
2235 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2236 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2237}
2238
2239TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2240 const string expected_stderr =
2241 "ERROR: new/p/Data.aidl:1.54-59: "
2242 "Encountered an untyped List or Map. The use of untyped List/Map is "
2243 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2244 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2245 "ERROR: new/p/Data.aidl: Failed to read.\n";
2246 io_delegate_.SetFileContents("old/p/Data.aidl",
2247 "package p;"
2248 "parcelable Data {"
2249 " int foo;"
2250 "}");
2251 io_delegate_.SetFileContents("new/p/Data.aidl",
2252 "package p;"
2253 "parcelable Data {"
2254 " int foo;"
2255 " @nullable List list;"
2256 "}");
2257 CaptureStderr();
2258 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2259 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2260}
2261
Daniel Norman85aed542019-08-21 12:01:14 -07002262TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002263 const string expected_stderr =
2264 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002265 io_delegate_.SetFileContents("old/p/Data.aidl",
2266 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002267 "parcelable Data {"
2268 " int foo;"
2269 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002270 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002271 io_delegate_.SetFileContents("new/p/Data.aidl",
2272 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002273 "parcelable Data {"
2274 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002275 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002276 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002277 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002278 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002279}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002280
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002281TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2282 const string expected_stderr =
2283 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2284 "backends. Please either provide a default value for this field or mark the field as "
2285 "@nullable. This value or a null value will be used automatically when an old version of "
2286 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2287 "order to make sure your code continues to be backwards compatible, make sure the default or "
2288 "null value does not cause a semantic change to this parcelable.\n";
2289 io_delegate_.SetFileContents("old/p/Data.aidl",
2290 "package p;"
2291 "parcelable Data {"
2292 " int num;"
2293 "}");
2294 io_delegate_.SetFileContents("new/p/Data.aidl",
2295 "package p;"
2296 "parcelable Data {"
2297 " int num;"
2298 " String str;"
2299 "}");
2300 CaptureStderr();
2301 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2302 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2303}
2304
Jooyung Han636fd2f2020-10-22 11:33:45 +09002305TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2306 const string expected_stderr =
2307 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2308 "Please make sure 'Enum' has '0' as a valid value.\n";
2309 io_delegate_.SetFileContents("old/p/Data.aidl",
2310 "package p;"
2311 "parcelable Data {"
2312 " int num;"
2313 "}");
2314 io_delegate_.SetFileContents("new/p/Data.aidl",
2315 "package p;"
2316 "parcelable Data {"
2317 " int num;"
2318 " p.Enum e;"
2319 "}");
2320 io_delegate_.SetFileContents("new/p/Enum.aidl",
2321 "package p;"
2322 "enum Enum {"
2323 " FOO = 1,"
2324 " BAR = 2,"
2325 "}");
2326 CaptureStderr();
2327 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2328 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2329}
2330
Daniel Norman85aed542019-08-21 12:01:14 -07002331TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002332 const string expected_stderr =
2333 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002334 io_delegate_.SetFileContents("old/p/Enum.aidl",
2335 "package p;"
2336 "enum Enum {"
2337 " FOO = 1,"
2338 " BAR = 2,"
2339 "}");
2340 io_delegate_.SetFileContents("new/p/Enum.aidl",
2341 "package p;"
2342 "enum Enum {"
2343 " BAR = 2,"
2344 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002345 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002346 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002348}
2349
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002350TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2351 const string expected_stderr =
2352 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2353 io_delegate_.SetFileContents("old/p/Union.aidl",
2354 "package p;"
2355 "union Union {"
2356 " String str;"
2357 " int num;"
2358 "}");
2359 io_delegate_.SetFileContents("new/p/Union.aidl",
2360 "package p;"
2361 "union Union {"
2362 " String str;"
2363 "}");
2364 CaptureStderr();
2365 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2366 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2367}
2368
Daniel Norman85aed542019-08-21 12:01:14 -07002369TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002370 const string expected_stderr =
2371 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002372 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2373 "package p;"
2374 "interface IFoo {"
2375 " void foo(in String[] str);"
2376 " void bar(@utf8InCpp String str);"
2377 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002378 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2379 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002380 "interface IFoo {"
2381 " void foo(in String[] str);"
2382 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002383 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002384 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002385 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002386 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002387}
2388
Daniel Norman85aed542019-08-21 12:01:14 -07002389TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002390 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002391 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2392 "package p;"
2393 "interface IFoo {"
2394 " void foo(in String[] str);"
2395 " void bar(@utf8InCpp String str);"
2396 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002397 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2398 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002399 "interface IFoo2 {"
2400 " void foo(in String[] str);"
2401 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002402 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002403 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002404 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002405 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002406}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002407
Daniel Norman85aed542019-08-21 12:01:14 -07002408TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002409 const string expected_stderr =
2410 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002411 io_delegate_.SetFileContents("old/p/Enum.aidl",
2412 "package p;"
2413 "enum Enum {"
2414 " FOO = 1,"
2415 " BAR = 2,"
2416 "}");
2417 io_delegate_.SetFileContents("new/p/Enum.aidl",
2418 "package p;"
2419 "enum Enum {"
2420 " FOO = 3,"
2421 " BAR = 2,"
2422 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002423 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002424 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002425 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002426}
2427
2428TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002429 const string expected_stderr =
2430 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2431 "from 0 to 1.\n"
2432 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2433 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002434 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2435 "package p;"
2436 "interface IFoo {"
2437 " void foo(in String[] str);"
2438 " void bar(@utf8InCpp String str);"
2439 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002440 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2441 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002442 "interface IFoo {"
2443 " void bar(@utf8InCpp String str);"
2444 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002445 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002446 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002447 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002448 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002449}
2450
2451TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002452 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002453 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2454 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002455 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002456 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002457 "parcelable Data {"
2458 " int foo;"
2459 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002460 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002461 io_delegate_.SetFileContents("new/p/Data.aidl",
2462 "package p;"
2463 "parcelable Data {"
2464 " int bar;"
2465 " int foo;"
2466 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002467 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002468 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002469 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002470}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002471
Daniel Norman85aed542019-08-21 12:01:14 -07002472TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002473 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002474 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002475 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002476 "interface IFoo {"
2477 " void foo(in String[] str);"
2478 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002479 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002480 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2481 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002482 "interface IFoo {"
2483 " void foo(out String[] str);"
2484 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002485 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002486 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002487 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002488 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002489}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002490
Daniel Norman85aed542019-08-21 12:01:14 -07002491TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002492 const string expected_stderr =
2493 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002494 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2495 "package p;"
2496 "interface IFoo {"
2497 " void foo(in String[] str);"
2498 " void bar(@utf8InCpp String str);"
2499 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002500 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2501 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002502 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002503 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002504 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002505 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002506 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002507 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002508 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002509}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002510
Daniel Norman85aed542019-08-21 12:01:14 -07002511TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002512 const string expected_stderr =
2513 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002514 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2515 "package p;"
2516 "interface IFoo {"
2517 " void foo(in String[] str);"
2518 " void bar(@utf8InCpp String str);"
2519 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002520 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2521 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002522 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002523 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002524 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002525 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002526 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002527 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002528 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002529}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002530
Jooyung Han60b2fde2020-10-29 15:12:40 +09002531TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2532 const string expected_stderr =
2533 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2534 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2535 io_delegate_.SetFileContents("old/p/Foo.aidl",
2536 "package p;"
2537 "@Backing(type=\"byte\")"
2538 "enum Foo {"
2539 " FOO, BAR,"
2540 "}");
2541 io_delegate_.SetFileContents("new/p/Foo.aidl",
2542 "package p;"
2543 "@Backing(type=\"long\")"
2544 "enum Foo {"
2545 " FOO, BAR,"
2546 "}");
2547 CaptureStderr();
2548 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2549 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2550}
2551
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002552TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2553 const string expected_stderr =
2554 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2555 "to @JavaPassthrough(annotation=\"Bob\")\n";
2556 io_delegate_.SetFileContents("old/p/Foo.aidl",
2557 "package p;"
2558 "@JavaPassthrough(annotation=\"Alice\")"
2559 "parcelable Foo {}");
2560 io_delegate_.SetFileContents("new/p/Foo.aidl",
2561 "package p;"
2562 "@JavaPassthrough(annotation=\"Bob\")"
2563 "parcelable Foo {}");
2564
2565 CaptureStderr();
2566 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2567 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2568}
2569
Devin Mooredb7ac512020-08-07 11:17:36 -07002570TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2571 const string expected_stderr =
2572 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2573 io_delegate_.SetFileContents("old/p/Foo.aidl",
2574 "package p;"
2575 "parcelable Foo {"
2576 " int A;"
2577 "}");
2578 io_delegate_.SetFileContents("new/p/Foo.aidl",
2579 "package p;"
2580 "@JavaOnlyStableParcelable parcelable Foo {"
2581 " int A;"
2582 "}");
2583 CaptureStderr();
2584 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2585 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2586}
2587
2588TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2589 const string expected_stderr =
2590 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2591 io_delegate_.SetFileContents("old/p/Foo.aidl",
2592 "package p;"
2593 "@JavaOnlyStableParcelable parcelable Foo {"
2594 " int A;"
2595 "}");
2596 io_delegate_.SetFileContents("new/p/Foo.aidl",
2597 "package p;"
2598 "parcelable Foo {"
2599 " int A;"
2600 "}");
2601 CaptureStderr();
2602 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2603 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2604}
2605
Daniel Norman85aed542019-08-21 12:01:14 -07002606TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002607 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002608 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2609 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002610 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002611 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002612 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002613 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002614}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002615
Daniel Norman85aed542019-08-21 12:01:14 -07002616TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002617 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002618 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2619 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002620 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002621 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002622 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002623}
Jiyong Parka428d212018-08-29 22:26:30 +09002624
Daniel Norman85aed542019-08-21 12:01:14 -07002625TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002626 const string expected_stderr =
2627 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002628 io_delegate_.SetFileContents("old/p/I.aidl",
2629 "package p; interface I {"
2630 "const int A = 1; const int B = 2;}");
2631 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002632 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002633 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002634 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002635}
Jiyong Parka428d212018-08-29 22:26:30 +09002636
Daniel Norman85aed542019-08-21 12:01:14 -07002637TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002638 const string expected_stderr =
2639 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002640 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2641 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002642 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002643 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002644 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002645}
2646
Devin Moorec7e47a32020-08-07 10:55:25 -07002647TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2648 const string expected_stderr =
2649 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2650 "This is an incompatible change for FixedSize types.\n";
2651 io_delegate_.SetFileContents("old/p/Foo.aidl",
2652 "package p; @FixedSize parcelable Foo { int A = 1; }");
2653 io_delegate_.SetFileContents("new/p/Foo.aidl",
2654 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2655 CaptureStderr();
2656 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2657 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2658}
2659
2660TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2661 const string expected_stderr =
2662 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2663 io_delegate_.SetFileContents("old/p/Foo.aidl",
2664 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2665 io_delegate_.SetFileContents("new/p/Foo.aidl",
2666 "package p; @FixedSize parcelable Foo { int A = 1; }");
2667 CaptureStderr();
2668 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2669 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2670}
2671
2672TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2673 const string expected_stderr =
2674 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2675 "a.\n"
2676 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2677 "b.\n"
2678 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2679 "c.\n"
2680 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2681 "d.\n"
2682 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2683 "e.\n"
2684 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2685 "f.\n";
2686
2687 io_delegate_.SetFileContents("Foo.aidl",
2688 "@FixedSize parcelable Foo { "
2689 " int[] a;"
2690 " Bar b;"
2691 " String c;"
2692 " ParcelFileDescriptor d;"
2693 " IBinder e;"
2694 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002695 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002696 "}");
2697 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2698 Options options =
2699 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2700
2701 CaptureStderr();
2702 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2703 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2704}
2705
2706TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2707 const string expected_stderr = "";
2708
2709 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2710 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2711 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2712 Options options =
2713 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2714
2715 CaptureStderr();
2716 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2717 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2718}
2719
Jiyong Park8c380532018-08-30 14:55:26 +09002720TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002721 const string expected_stderr =
2722 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2723 "dir1/q/IBar.aidl\n"
2724 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002725 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002726 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2727 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2728 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2729 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2730
Devin Moore097a3ab2020-03-11 16:08:44 -07002731 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002732 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002733 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002734}
2735
Jiyong Parked65bf42018-08-28 15:43:27 +09002736TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002737 const string expected_stderr =
2738 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2739 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002740 Options options = Options::From("aidl --checkapi old new");
2741 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2742 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002743
2744 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2745
Jiyong Parke59c3682018-09-11 23:10:25 +09002746 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002747 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002748 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002749 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002750}
2751
Jiyong Parke05195e2018-10-08 18:24:23 +09002752TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2753 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2754 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002755 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002756
2757 // use without import
2758 io_delegate_.SetFileContents("p/IFoo.aidl",
2759 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2760 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2761 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002762 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002763
Devin Moore7b8d5c92020-03-17 14:14:08 -07002764 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002765 io_delegate_.SetFileContents(
2766 "p/IFoo.aidl",
2767 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2768 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2769 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002770 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002771
2772 // use with import (as before)
2773 io_delegate_.SetFileContents("p/IFoo.aidl",
2774 "package p;"
2775 "import android.os.ParcelFileDescriptor;"
2776 "interface IFoo{"
2777 " void foo(in ParcelFileDescriptor fd);"
2778 "}");
2779 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2780 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002781 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002782}
Jiyong Parked65bf42018-08-28 15:43:27 +09002783
Jiyong Park3633b722019-04-11 15:38:26 +09002784TEST_F(AidlTest, ManualIds) {
2785 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2786 io_delegate_.SetFileContents("IFoo.aidl",
2787 "interface IFoo {\n"
2788 " void foo() = 0;\n"
2789 " void bar() = 1;\n"
2790 "}");
2791 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2792}
2793
2794TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2795 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2796 io_delegate_.SetFileContents("IFoo.aidl",
2797 "interface IFoo {\n"
2798 " void foo() = 0;\n"
2799 " void bar() = 1;\n"
2800 "}");
2801 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2802}
2803
2804TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002805 const string expected_stderr =
2806 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002807 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2808 io_delegate_.SetFileContents("IFoo.aidl",
2809 "interface IFoo {\n"
2810 " void foo() = 3;\n"
2811 " void bar() = 3;\n"
2812 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002813 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002814 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002815 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002816}
2817
2818TEST_F(AidlTest, FailOnOutOfRangeIds) {
2819 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002820 const string expected_stderr =
2821 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2822 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002823 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2824 io_delegate_.SetFileContents("IFoo.aidl",
2825 "interface IFoo {\n"
2826 " void foo() = 3;\n"
2827 " void bar() = 16777115;\n"
2828 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002829 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002830 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002831 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002832}
2833
2834TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002835 const string expected_stderr =
2836 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002837 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2838 io_delegate_.SetFileContents("IFoo.aidl",
2839 "interface IFoo {\n"
2840 " void foo() = 3;\n"
2841 " void bar();\n"
2842 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002843 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002844 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002845 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002846}
2847
Jiyong Parkc6816252019-07-08 08:12:28 +09002848TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2849 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2850 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2851 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2852 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2853}
2854
2855TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002856 const string expected_stderr =
2857 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2858 "dir/IBar.aidl\n"
2859 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002860 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002861
Jiyong Parkc6816252019-07-08 08:12:28 +09002862 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2863 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2864 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2865 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002866 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002867 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002868 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002869}
2870
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002871TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2872 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2873 "package a.b;\n"
2874 "import a.b.IBar;\n"
2875 "import a.b.IQux;\n"
2876 "interface IFoo { IQux foo(); }\n");
2877 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2878 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2879
2880 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2881 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2882
2883 string output;
2884 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2885 // IBar was imported but wasn't used. include is not expected.
2886 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2887 // IBar was imported and used. include is expected.
2888 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2889}
2890
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002891TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002892 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002893 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002894 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2895 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002896 interface IFoo {
2897 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002898 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002899 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002900 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002901 // JavaPassthrough should work with other types as well (e.g. enum)
2902 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2903 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2904 @JavaPassthrough(annotation="@com.android.AliceTwo")
2905 @Backing(type="byte")
2906 enum MyEnum {
2907 a, b, c
2908 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002909
Jooyung Han4cde01d2020-10-13 11:10:47 +09002910 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002911 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2912
2913 string java_out;
2914 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002915 // type-decl-level annotations with newline at the end
2916 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2917 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2918 // member-decl-level annotations with newline at the end
2919 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2920 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2921 // inline annotations with space at the end
2922 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002923
Jooyung Han4cde01d2020-10-13 11:10:47 +09002924 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2925 // type-decl-level annotations with newline at the end
2926 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2927 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2928
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002929 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002930 Options cpp_options =
2931 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002932 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2933
Jooyung Han4cde01d2020-10-13 11:10:47 +09002934 Options ndk_options =
2935 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002936 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002937
Jooyung Han4cde01d2020-10-13 11:10:47 +09002938 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002939 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002940}
2941
Andrei Homescue61feb52020-08-18 15:44:24 -07002942TEST_F(AidlTest, ParseRustDerive) {
2943 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2944 @RustDerive(Clone=true, Copy=false)
2945 parcelable Foo {
2946 int a;
2947 })");
2948
2949 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2950 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2951
2952 string rust_out;
2953 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2954 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2955
2956 // Other backends shouldn't be bothered
2957 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2958 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2959
2960 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2961 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2962
2963 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2964 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2965}
2966
Jiyong Park56f73d72019-06-11 12:20:28 +09002967class AidlOutputPathTest : public AidlTest {
2968 protected:
2969 void SetUp() override {
2970 AidlTest::SetUp();
2971 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2972 }
2973
2974 void Test(const Options& options, const std::string expected_output_path) {
2975 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2976 // check the existence
2977 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2978 }
2979};
2980
2981TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2982 // <out_dir> / <package_name> / <type_name>.java
2983 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2984}
2985
2986TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2987 // when output file is explicitly set, it is always respected. -o option is
2988 // ignored.
2989 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2990}
2991
2992TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2993 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2994}
2995
2996TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2997 // output is the same as the input file except for the suffix
2998 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2999}
3000
Devin Moore7b8d5c92020-03-17 14:14:08 -07003001TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003002 AidlError error;
3003 const string expected_stderr =
3004 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
3005 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003006 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3007 R"(package p;
3008 interface IFoo {
3009 const int int32_max_oob = 2147483650;
3010 }
3011 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003012 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003013 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3014 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003015}
3016
Devin Moore7b8d5c92020-03-17 14:14:08 -07003017TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003018 AidlError error;
3019 const string expected_stderr =
3020 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
3021 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003022 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3023 R"(package p;
3024 interface IFoo {
3025 const int int32_min_oob = -2147483650;
3026 }
3027 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003028 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003029 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3030 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003031}
3032
Devin Moore7b8d5c92020-03-17 14:14:08 -07003033TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003034 AidlError error;
3035 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003036 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003037 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003038 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3039 R"(package p;
3040 interface IFoo {
3041 const long int64_max_oob = 21474836509999999999999999;
3042 }
3043 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003044 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003045 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3046 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003047}
3048
Devin Moore7b8d5c92020-03-17 14:14:08 -07003049TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003050 AidlError error;
3051 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003052 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003053 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003054 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3055 R"(package p;
3056 interface IFoo {
3057 const long int64_min_oob = -21474836509999999999999999;
3058 }
3059 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003060 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003061 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3062 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003063}
3064
Devin Moore7b8d5c92020-03-17 14:14:08 -07003065TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003066 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003067 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003068 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003069 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3070 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003071 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3072 R"(package p;
3073 @Backing(type="byte")
3074 enum TestEnum {
3075 FOO = 127,
3076 BAR,
3077 }
3078 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003079 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003080 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003081 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003082}
3083
Devin Mooredecaf292020-04-30 09:16:40 -07003084TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3085 AidlError error;
3086 const string expected_stderr =
3087 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
3088 "be one of: type\n"
3089 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
3090 "be one of: type\n";
3091 CaptureStderr();
3092 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3093 R"(package p;
3094 @Backing(foo="byte")
3095 enum TestEnum {
3096 FOO = 1,
3097 BAR,
3098 }
3099 )",
3100 typenames_, GetLanguage(), &error));
3101 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3102 EXPECT_EQ(AidlError::BAD_TYPE, error);
3103}
3104
Jooyung Han66813932020-10-23 13:24:44 +09003105TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003106 io_delegate_.SetFileContents("Foo.aidl",
3107 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3108 "Map<String, Baz> d; Bar[] e; }");
3109 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3110 io_delegate_.SetFileContents("Baz.aidl",
3111 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003112 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3113 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3114}
3115
Jooyung Han66813932020-10-23 13:24:44 +09003116TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003117 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003118 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003119 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003120 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3121 "named 'bar'.\n";
3122 CaptureStderr();
3123 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3124 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3125 EXPECT_EQ(expected_error, GetCapturedStderr());
3126}
3127
3128TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3129 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3130 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3131 string expected_error =
3132 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003133 "named 'bar'.\n";
3134 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003135 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3136 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003137 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003138}
3139
Jooyung Han66813932020-10-23 13:24:44 +09003140TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003141 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003142 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3143 string expected_error =
3144 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3145 "only be an in parameter.\n";
3146 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003147 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3148 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003149 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003150}
3151
Jooyung Han66813932020-10-23 13:24:44 +09003152TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003153 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003154 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3155 string expected_error =
3156 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3157 "only be an in parameter.\n";
3158 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003159 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3160 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003161 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003162}
3163
Jooyung Han66813932020-10-23 13:24:44 +09003164TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003165 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003166 Options options = Options::From("aidl --lang=java Foo.aidl");
3167 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003168 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3169 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003170 CaptureStderr();
3171 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3172 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3173}
Devin Moore53fc99c2020-08-12 08:07:52 -07003174
Jooyung Han1f14ab32020-10-14 13:48:29 +09003175const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3176
3177#include <a/ByteEnum.h>
3178#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003179#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003180#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003181#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003182#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003183#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003184#include <locale>
3185#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003186#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003187#include <utility>
3188#include <variant>
3189#include <vector>
3190
Jooyung Handf39e192020-11-23 15:59:46 +09003191#ifndef __BIONIC__
3192#define __assert2(a,b,c,d) ((void)0)
3193#endif
3194
Jooyung Han1f14ab32020-10-14 13:48:29 +09003195namespace a {
3196
3197class Foo : public ::android::Parcelable {
3198public:
Jooyung Han97945de2020-10-15 16:41:38 +09003199 inline bool operator!=(const Foo& rhs) const {
3200 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003201 }
Jooyung Han97945de2020-10-15 16:41:38 +09003202 inline bool operator<(const Foo& rhs) const {
3203 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003204 }
Jooyung Han97945de2020-10-15 16:41:38 +09003205 inline bool operator<=(const Foo& rhs) const {
3206 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003207 }
Jooyung Han97945de2020-10-15 16:41:38 +09003208 inline bool operator==(const Foo& rhs) const {
3209 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003210 }
Jooyung Han97945de2020-10-15 16:41:38 +09003211 inline bool operator>(const Foo& rhs) const {
3212 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003213 }
Jooyung Han97945de2020-10-15 16:41:38 +09003214 inline bool operator>=(const Foo& rhs) const {
3215 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003216 }
Jooyung Han97945de2020-10-15 16:41:38 +09003217
Jooyung Han1f14ab32020-10-14 13:48:29 +09003218 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003219 ns = 0, // int[] ns;
3220 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003221 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003222 };
Jooyung Han97945de2020-10-15 16:41:38 +09003223
Jooyung Han1f14ab32020-10-14 13:48:29 +09003224 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003225 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003226
3227 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003228 Foo(const Foo&) = default;
3229 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003230 Foo& operator=(const Foo&) = default;
3231 Foo& operator=(Foo&&) = default;
3232
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003233 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3234 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003235 constexpr Foo(_Tp&& _arg)
3236 : _value(std::forward<_Tp>(_arg)) {}
3237
3238 template <typename... _Tp>
3239 constexpr explicit Foo(_Tp&&... _args)
3240 : _value(std::forward<_Tp>(_args)...) {}
3241
3242 template <Tag _tag, typename... _Tp>
3243 static Foo make(_Tp&&... _args) {
3244 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003245 }
Jooyung Han97945de2020-10-15 16:41:38 +09003246
3247 template <Tag _tag, typename _Tp, typename... _Up>
3248 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3249 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003250 }
3251
3252 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003253 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003254 }
3255
Jooyung Han97945de2020-10-15 16:41:38 +09003256 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003257 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003258 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003259 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003260 }
3261
Jooyung Han97945de2020-10-15 16:41:38 +09003262 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003263 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003264 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003265 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003266 }
3267
Jooyung Han97945de2020-10-15 16:41:38 +09003268 template <Tag _tag, typename... _Tp>
3269 void set(_Tp&&... _args) {
3270 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003271 }
3272
3273 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3274 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3275 static const std::string& getParcelableDescriptor() {
3276 static const std::string DESCIPTOR = "a.Foo";
3277 return DESCIPTOR;
3278 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003279 template <typename _T> class _has_toString {
3280 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3281 template <typename _U> static std::false_type __has_toString(...);
3282 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3283 };
3284 template <typename _T> inline static std::string _call_toString(const _T& t) {
3285 if constexpr (_has_toString<_T>::value) return t.toString();
3286 return "{no toString() implemented}";
3287 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003288 inline std::string toString() const {
3289 std::ostringstream os;
3290 os << "Foo{";
3291 switch (getTag()) {
3292 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3293 case e: os << "e: " << a::toString(get<e>()); break;
3294 case pfd: os << "pfd: " << ""; break;
3295 }
3296 os << "}";
3297 return os.str();
3298 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003299private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003300 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003301}; // class Foo
3302
3303} // namespace a
3304)";
3305
3306const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3307
3308namespace a {
3309
3310::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3311 ::android::status_t _aidl_ret_status;
3312 int32_t _aidl_tag;
3313 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3314 switch (_aidl_tag) {
3315 case ns: {
3316 ::std::vector<int32_t> _aidl_value;
3317 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003318 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3319 set<ns>(_aidl_value);
3320 } else {
3321 // NOLINTNEXTLINE(performance-move-const-arg)
3322 set<ns>(std::move(_aidl_value));
3323 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003324 return ::android::OK; }
3325 case e: {
3326 ::a::ByteEnum _aidl_value;
3327 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003328 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3329 set<e>(_aidl_value);
3330 } else {
3331 // NOLINTNEXTLINE(performance-move-const-arg)
3332 set<e>(std::move(_aidl_value));
3333 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003334 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003335 case pfd: {
3336 ::android::os::ParcelFileDescriptor _aidl_value;
3337 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003338 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3339 set<pfd>(_aidl_value);
3340 } else {
3341 // NOLINTNEXTLINE(performance-move-const-arg)
3342 set<pfd>(std::move(_aidl_value));
3343 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003344 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003345 }
3346 return ::android::BAD_VALUE;
3347}
3348
3349::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3350 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3351 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3352 switch (getTag()) {
3353 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3354 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003355 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003356 }
Jooyung Handf39e192020-11-23 15:59:46 +09003357 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003358}
3359
3360} // namespace a
3361)";
3362
Jooyung Han6beac042020-10-17 21:59:43 +09003363const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3364#include <android/binder_interface_utils.h>
3365#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003366#include <codecvt>
3367#include <locale>
3368#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003369
Jooyung Handf39e192020-11-23 15:59:46 +09003370#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003371#include <type_traits>
3372#include <utility>
3373#include <variant>
3374#include <cstdint>
3375#include <memory>
3376#include <optional>
3377#include <string>
3378#include <vector>
3379#ifdef BINDER_STABILITY_SUPPORT
3380#include <android/binder_stability.h>
3381#endif // BINDER_STABILITY_SUPPORT
3382#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003383
3384#ifndef __BIONIC__
3385#define __assert2(a,b,c,d) ((void)0)
3386#endif
3387
Jooyung Han6beac042020-10-17 21:59:43 +09003388namespace aidl {
3389namespace a {
3390class Foo {
3391public:
3392 typedef std::false_type fixed_size;
3393 static const char* descriptor;
3394
3395 enum Tag : int32_t {
3396 ns = 0, // int[] ns;
3397 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003398 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003399 };
3400
3401 template<typename _Tp>
3402 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3403
3404 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3405 Foo(const Foo&) = default;
3406 Foo(Foo&&) = default;
3407 Foo& operator=(const Foo&) = default;
3408 Foo& operator=(Foo&&) = default;
3409
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003410 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3411 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003412 constexpr Foo(_Tp&& _arg)
3413 : _value(std::forward<_Tp>(_arg)) {}
3414
3415 template <typename... _Tp>
3416 constexpr explicit Foo(_Tp&&... _args)
3417 : _value(std::forward<_Tp>(_args)...) {}
3418
3419 template <Tag _tag, typename... _Tp>
3420 static Foo make(_Tp&&... _args) {
3421 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3422 }
3423
3424 template <Tag _tag, typename _Tp, typename... _Up>
3425 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3426 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3427 }
3428
3429 Tag getTag() const {
3430 return static_cast<Tag>(_value.index());
3431 }
3432
3433 template <Tag _tag>
3434 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003435 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003436 return std::get<_tag>(_value);
3437 }
3438
3439 template <Tag _tag>
3440 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003441 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003442 return std::get<_tag>(_value);
3443 }
3444
3445 template <Tag _tag, typename... _Tp>
3446 void set(_Tp&&... _args) {
3447 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3448 }
3449
3450 binder_status_t readFromParcel(const AParcel* _parcel);
3451 binder_status_t writeToParcel(AParcel* _parcel) const;
Steven Morelandf58804a2020-12-07 18:12:15 +00003452
3453 inline bool operator!=(const Foo& rhs) const {
3454 return _value != rhs._value;
3455 }
3456 inline bool operator<(const Foo& rhs) const {
3457 return _value < rhs._value;
3458 }
3459 inline bool operator<=(const Foo& rhs) const {
3460 return _value <= rhs._value;
3461 }
3462 inline bool operator==(const Foo& rhs) const {
3463 return _value == rhs._value;
3464 }
3465 inline bool operator>(const Foo& rhs) const {
3466 return _value > rhs._value;
3467 }
3468 inline bool operator>=(const Foo& rhs) const {
3469 return _value >= rhs._value;
3470 }
3471
Jooyung Han6beac042020-10-17 21:59:43 +09003472 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003473 template <typename _T> class _has_toString {
3474 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3475 template <typename _U> static std::false_type __has_toString(...);
3476 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3477 };
3478 template <typename _T> inline static std::string _call_toString(const _T& t) {
3479 if constexpr (_has_toString<_T>::value) return t.toString();
3480 return "{no toString() implemented}";
3481 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003482 inline std::string toString() const {
3483 std::ostringstream os;
3484 os << "Foo{";
3485 switch (getTag()) {
3486 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3487 case e: os << "e: " << a::toString(get<e>()); break;
3488 case pfd: os << "pfd: " << ""; break;
3489 }
3490 os << "}";
3491 return os.str();
3492 }
Jooyung Han6beac042020-10-17 21:59:43 +09003493private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003494 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003495};
3496} // namespace a
3497} // namespace aidl
3498)";
3499
3500const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3501
3502#include <android/binder_parcel_utils.h>
3503
3504namespace aidl {
3505namespace a {
3506const char* Foo::descriptor = "a.Foo";
3507
3508binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3509 binder_status_t _aidl_ret_status;
3510 int32_t _aidl_tag;
3511 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3512 switch (_aidl_tag) {
3513 case ns: {
3514 std::vector<int32_t> _aidl_value;
3515 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003516 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3517 set<ns>(_aidl_value);
3518 } else {
3519 // NOLINTNEXTLINE(performance-move-const-arg)
3520 set<ns>(std::move(_aidl_value));
3521 }
Jooyung Han6beac042020-10-17 21:59:43 +09003522 return STATUS_OK; }
3523 case e: {
3524 ::aidl::a::ByteEnum _aidl_value;
3525 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003526 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3527 set<e>(_aidl_value);
3528 } else {
3529 // NOLINTNEXTLINE(performance-move-const-arg)
3530 set<e>(std::move(_aidl_value));
3531 }
Jooyung Han6beac042020-10-17 21:59:43 +09003532 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003533 case pfd: {
3534 ::ndk::ScopedFileDescriptor _aidl_value;
3535 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003536 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3537 set<pfd>(_aidl_value);
3538 } else {
3539 // NOLINTNEXTLINE(performance-move-const-arg)
3540 set<pfd>(std::move(_aidl_value));
3541 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003542 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003543 }
3544 return STATUS_BAD_VALUE;
3545}
3546binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3547 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3548 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3549 switch (getTag()) {
3550 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3551 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003552 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003553 }
Jooyung Handf39e192020-11-23 15:59:46 +09003554 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003555}
3556
3557} // namespace a
3558} // namespace aidl
3559)";
3560
Jooyung Han1f14ab32020-10-14 13:48:29 +09003561const char kUnionExampleExpectedOutputJava[] = R"(/*
3562 * This file is auto-generated. DO NOT MODIFY.
3563 */
3564package a;
3565
3566
3567public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003568 // tags for union fields
3569 public final static int ns = 0; // int[] ns;
3570 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003571 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003572
3573 private int _tag;
3574 private Object _value;
3575
3576 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003577 int[] _value = {42};
3578 this._tag = ns;
3579 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003580 }
Jooyung Han97945de2020-10-15 16:41:38 +09003581
Jooyung Han1f14ab32020-10-14 13:48:29 +09003582 private Foo(android.os.Parcel _aidl_parcel) {
3583 readFromParcel(_aidl_parcel);
3584 }
Jooyung Han97945de2020-10-15 16:41:38 +09003585
Jooyung Hance62f932020-10-25 10:21:49 +09003586 private Foo(int _tag, Object _value) {
3587 this._tag = _tag;
3588 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003589 }
3590
3591 public int getTag() {
3592 return _tag;
3593 }
3594
Jooyung Han97945de2020-10-15 16:41:38 +09003595 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003596
3597 public static Foo ns(int[] _value) {
3598 return new Foo(ns, _value);
3599 }
Jooyung Han97945de2020-10-15 16:41:38 +09003600
Jooyung Han1f14ab32020-10-14 13:48:29 +09003601 public int[] getNs() {
3602 _assertTag(ns);
3603 return (int[]) _value;
3604 }
Jooyung Han97945de2020-10-15 16:41:38 +09003605
Jooyung Han1f14ab32020-10-14 13:48:29 +09003606 public void setNs(int[] _value) {
3607 _set(ns, _value);
3608 }
3609
Jooyung Han97945de2020-10-15 16:41:38 +09003610 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003611
3612 public static Foo e(byte _value) {
3613 return new Foo(e, _value);
3614 }
Jooyung Han97945de2020-10-15 16:41:38 +09003615
Jooyung Han1f14ab32020-10-14 13:48:29 +09003616 public byte getE() {
3617 _assertTag(e);
3618 return (byte) _value;
3619 }
Jooyung Han97945de2020-10-15 16:41:38 +09003620
Jooyung Han1f14ab32020-10-14 13:48:29 +09003621 public void setE(byte _value) {
3622 _set(e, _value);
3623 }
3624
Jooyung Hand2fa0232020-10-19 02:51:41 +09003625 // ParcelFileDescriptor pfd;
3626
3627 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3628 return new Foo(pfd, _value);
3629 }
3630
3631 public android.os.ParcelFileDescriptor getPfd() {
3632 _assertTag(pfd);
3633 return (android.os.ParcelFileDescriptor) _value;
3634 }
3635
3636 public void setPfd(android.os.ParcelFileDescriptor _value) {
3637 _set(pfd, _value);
3638 }
3639
Jooyung Han1f14ab32020-10-14 13:48:29 +09003640 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3641 @Override
3642 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003643 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003644 }
3645 @Override
3646 public Foo[] newArray(int _aidl_size) {
3647 return new Foo[_aidl_size];
3648 }
3649 };
Jooyung Han97945de2020-10-15 16:41:38 +09003650
Jooyung Han1f14ab32020-10-14 13:48:29 +09003651 @Override
3652 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3653 _aidl_parcel.writeInt(_tag);
3654 switch (_tag) {
3655 case ns:
3656 _aidl_parcel.writeIntArray(getNs());
3657 break;
3658 case e:
3659 _aidl_parcel.writeByte(getE());
3660 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003661 case pfd:
3662 if ((getPfd()!=null)) {
3663 _aidl_parcel.writeInt(1);
3664 getPfd().writeToParcel(_aidl_parcel, 0);
3665 }
3666 else {
3667 _aidl_parcel.writeInt(0);
3668 }
3669 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003670 }
3671 }
Jooyung Han97945de2020-10-15 16:41:38 +09003672
Jooyung Han1f14ab32020-10-14 13:48:29 +09003673 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3674 int _aidl_tag;
3675 _aidl_tag = _aidl_parcel.readInt();
3676 switch (_aidl_tag) {
3677 case ns: {
3678 int[] _aidl_value;
3679 _aidl_value = _aidl_parcel.createIntArray();
3680 _set(_aidl_tag, _aidl_value);
3681 return; }
3682 case e: {
3683 byte _aidl_value;
3684 _aidl_value = _aidl_parcel.readByte();
3685 _set(_aidl_tag, _aidl_value);
3686 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003687 case pfd: {
3688 android.os.ParcelFileDescriptor _aidl_value;
3689 if ((0!=_aidl_parcel.readInt())) {
3690 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3691 }
3692 else {
3693 _aidl_value = null;
3694 }
3695 _set(_aidl_tag, _aidl_value);
3696 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003697 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003698 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003699 }
Jooyung Han97945de2020-10-15 16:41:38 +09003700
Jooyung Han1f14ab32020-10-14 13:48:29 +09003701 @Override
3702 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003703 int _mask = 0;
3704 switch (getTag()) {
3705 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003706 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003707 break;
3708 }
3709 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003710 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003711 private int describeContents(Object _v) {
3712 if (_v == null) return 0;
3713 if (_v instanceof android.os.Parcelable) {
3714 return ((android.os.Parcelable) _v).describeContents();
3715 }
3716 return 0;
3717 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003718
3719 private void _assertTag(int tag) {
3720 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003721 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003722 }
3723 }
Jooyung Han97945de2020-10-15 16:41:38 +09003724
Jooyung Han1f14ab32020-10-14 13:48:29 +09003725 private String _tagString(int _tag) {
3726 switch (_tag) {
3727 case ns: return "ns";
3728 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003729 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003730 }
3731 throw new IllegalStateException("unknown field: " + _tag);
3732 }
Jooyung Han97945de2020-10-15 16:41:38 +09003733
Jooyung Hance62f932020-10-25 10:21:49 +09003734 private void _set(int _tag, Object _value) {
3735 this._tag = _tag;
3736 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003737 }
3738}
3739)";
3740
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003741const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3742pub enum Foo {
3743 Ns(Vec<i32>),
3744 E(crate::mangled::_1_a_8_ByteEnum),
3745 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3746}
3747pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3748impl Default for Foo {
3749 fn default() -> Self {
3750 Self::Ns(vec!{42})
3751 }
3752}
3753impl binder::parcel::Serialize for Foo {
3754 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3755 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3756 }
3757}
3758impl binder::parcel::SerializeArray for Foo {}
3759impl binder::parcel::SerializeOption for Foo {
3760 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3761 let this = if let Some(this) = this {
3762 parcel.write(&1i32)?;
3763 this
3764 } else {
3765 return parcel.write(&0i32);
3766 };
3767 match this {
3768 Self::Ns(v) => {
3769 parcel.write(&0i32)?;
3770 parcel.write(v)
3771 }
3772 Self::E(v) => {
3773 parcel.write(&1i32)?;
3774 parcel.write(v)
3775 }
3776 Self::Pfd(v) => {
3777 parcel.write(&2i32)?;
3778 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3779 parcel.write(__field_ref)
3780 }
3781 }
3782 }
3783}
3784impl binder::parcel::Deserialize for Foo {
3785 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3786 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3787 .transpose()
3788 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3789 }
3790}
3791impl binder::parcel::DeserializeArray for Foo {}
3792impl binder::parcel::DeserializeOption for Foo {
3793 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3794 let status: i32 = parcel.read()?;
3795 if status == 0 { return Ok(None); }
3796 let tag: i32 = parcel.read()?;
3797 match tag {
3798 0 => {
3799 let value: Vec<i32> = parcel.read()?;
3800 Ok(Some(Self::Ns(value)))
3801 }
3802 1 => {
3803 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3804 Ok(Some(Self::E(value)))
3805 }
3806 2 => {
3807 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3808 Ok(Some(Self::Pfd(value)))
3809 }
3810 _ => {
3811 Err(binder::StatusCode::BAD_VALUE)
3812 }
3813 }
3814 }
3815}
3816)";
3817
Jooyung Han97945de2020-10-15 16:41:38 +09003818struct AidlUnionTest : ::testing::Test {
3819 void SetUp() override {
3820 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003821package a;
3822import a.ByteEnum;
3823union Foo {
3824 int[] ns = {42};
3825 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003826 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003827}
3828)");
Jooyung Han97945de2020-10-15 16:41:38 +09003829 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003830package a;
3831@Backing(type="byte")
3832enum ByteEnum {
3833 a, b, c
3834}
3835)");
Jooyung Han97945de2020-10-15 16:41:38 +09003836 }
3837 FakeIoDelegate io_delegate_;
3838 void Compile(string lang) {
3839 string command = "aidl --structured -I. -o out --lang=" + lang;
3840 if (lang == "cpp" || lang == "ndk") {
3841 command += " -h out";
3842 }
3843 command += " a/Foo.aidl";
3844 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003845 CaptureStderr();
3846 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3847 auto err = GetCapturedStderr();
3848 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003849 }
3850 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3851 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003852 string actual;
3853 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3854 EXPECT_EQ(expected, actual);
3855 }
Jooyung Han97945de2020-10-15 16:41:38 +09003856 }
3857};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003858
Jooyung Han97945de2020-10-15 16:41:38 +09003859TEST_F(AidlUnionTest, Example_Cpp) {
3860 Compile("cpp");
3861 EXPECT_COMPILE_OUTPUTS(
3862 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3863 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3864}
3865
Jooyung Han6beac042020-10-17 21:59:43 +09003866TEST_F(AidlUnionTest, Example_Ndk) {
3867 Compile("ndk");
3868 EXPECT_COMPILE_OUTPUTS(
3869 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3870 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3871}
3872
Jooyung Han97945de2020-10-15 16:41:38 +09003873TEST_F(AidlUnionTest, Example_Java) {
3874 Compile("java");
3875 EXPECT_COMPILE_OUTPUTS(
3876 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003877}
3878
3879TEST_F(AidlUnionTest, Example_Rust) {
3880 Compile("rust");
3881 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003882}
3883
Jooyung Hanfe89f122020-10-14 03:49:18 +09003884TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3885 const string method = "package a; union Foo {}";
3886 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3887 CaptureStderr();
3888 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3889 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3890}
3891
3892TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3893 const string method = "package a; union Foo { ParcelableHolder x; }";
3894 const string expected_stderr =
3895 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3896 CaptureStderr();
3897 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3898 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3899}
3900
Devin Moore53fc99c2020-08-12 08:07:52 -07003901TEST_P(AidlTest, GenericStructuredParcelable) {
3902 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3903 Options options =
3904 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3905 const string expected_stderr = "";
3906 CaptureStderr();
3907 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3908 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3909}
3910
Jooyung Han3f347ca2020-12-01 12:41:50 +09003911TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3912 io_delegate_.SetFileContents("Foo.aidl",
3913 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3914 Options options =
3915 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::CPP) +
3916 " -o out -h out");
3917 const string expected_stderr = "";
3918 CaptureStderr();
3919 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3920 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3921
3922 string code;
3923 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3924 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3925const ::android::String16& Foo<T,U>::s() {
3926 static const ::android::String16 value(::android::String16(""));
3927 return value;
3928})--"));
3929}
3930
3931TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3932 io_delegate_.SetFileContents("Foo.aidl",
3933 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3934 Options options =
3935 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::NDK) +
3936 " -o out -h out");
3937 const string expected_stderr = "";
3938 CaptureStderr();
3939 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3941
3942 string code;
3943 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3944 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3945const char* Foo<T, U>::s = "";
3946)--"));
3947}
3948
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003949TEST_F(AidlTest, NestedTypeArgs) {
3950 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003951 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3952
3953 io_delegate_.SetFileContents("a/Foo.aidl",
3954 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3955 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003956 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3957 const string expected_stderr = "";
3958 CaptureStderr();
3959 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3960 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3961
3962 string code;
3963 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003964 EXPECT_THAT(code,
3965 testing::HasSubstr(
3966 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3967}
3968
3969TEST_F(AidlTest, DoubleArrayError) {
3970 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3971
3972 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3973 const string expected_stderr =
3974 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3975 CaptureStderr();
3976 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3977 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3978}
3979
3980TEST_F(AidlTest, DoubleGenericError) {
3981 io_delegate_.SetFileContents("a/Bar.aidl",
3982 "package a; parcelable Bar { List<String><String> a; }");
3983
3984 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3985 const string expected_stderr =
3986 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3987 CaptureStderr();
3988 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3989 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3990}
3991
3992TEST_F(AidlTest, ArrayBeforeGenericError) {
3993 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3994
3995 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3996 const string expected_stderr =
3997 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3998 CaptureStderr();
3999 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4000 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09004001}
4002
Jooyung Han14004ed2020-10-16 03:49:57 +09004003struct GenericAidlTest : ::testing::Test {
4004 FakeIoDelegate io_delegate_;
4005 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00004006 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09004007 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
4008 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
4009 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
4010
4011 Options options = Options::From(cmd);
4012 CaptureStderr();
4013 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
4014 EXPECT_EQ("", GetCapturedStderr());
4015 }
4016};
4017
4018TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
4019 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
4020 string code;
4021 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
4022 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
4023 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
4024 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
4025}
4026
4027TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
4028 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
4029 string code;
4030 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
4031 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
4032 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
4033 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
4034}
4035
Devin Moore53fc99c2020-08-12 08:07:52 -07004036TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4037 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
4038 Options options =
4039 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4040 const string expected_stderr =
4041 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4042 CaptureStderr();
4043 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4044 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4045}
4046
4047TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4048 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
4049 Options options =
4050 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4051 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4052 CaptureStderr();
4053 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4054 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4055}
4056
Jooyung Han7a308842020-10-27 19:06:49 +09004057TEST_P(AidlTest, LongCommentWithinConstExpression) {
4058 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
4059 Options options =
4060 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4061 CaptureStderr();
4062 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
4063 EXPECT_EQ("", GetCapturedStderr());
4064}
4065
Jeongik Chaef44e622020-10-23 16:00:52 +09004066TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4067 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4068 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4069 std::string expectedErr =
4070 "ERROR: a/Foo.aidl:1.28-30: "
4071 "Encountered an untyped List or Map. The use of untyped List/Map is "
4072 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4073 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4074 "ERROR: a/Foo.aidl:1.35-37: "
4075 "Encountered an untyped List or Map. The use of untyped List/Map is "
4076 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4077 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4078 CaptureStderr();
4079 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4080 EXPECT_EQ(expectedErr, GetCapturedStderr());
4081}
4082
4083TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004084 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4085 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004086 std::string expectedErr =
4087 "ERROR: a/Foo.aidl:1.33-35: "
4088 "Encountered an untyped List or Map. The use of untyped List/Map is "
4089 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4090 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4091 "ERROR: a/Foo.aidl:1.40-42: "
4092 "Encountered an untyped List or Map. The use of untyped List/Map is "
4093 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4094 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004095 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09004096 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4097 EXPECT_EQ(expectedErr, GetCapturedStderr());
4098}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004099
Jeongik Chaef44e622020-10-23 16:00:52 +09004100TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4101 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4102 io_delegate_.SetFileContents(
4103 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4104 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4105 std::string expectedErr =
4106 "ERROR: a/Foo.aidl:1.52-54: "
4107 "Encountered an untyped List or Map. The use of untyped List/Map is "
4108 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4109 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4110 "ERROR: a/Foo.aidl:1.64-66: "
4111 "Encountered an untyped List or Map. The use of untyped List/Map is "
4112 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4113 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4114 CaptureStderr();
4115 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4116 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004117}
4118
Jooyung Han690f5842020-12-04 13:02:04 +09004119TEST_F(AidlTest, EnumWithDefaults_Java) {
4120 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4121 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4122package p;
4123import p.Enum;
4124parcelable Foo {
4125 Enum e = Enum.BAR;
4126})");
4127 CaptureStderr();
4128 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
4129 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4130 auto err = GetCapturedStderr();
4131 EXPECT_EQ("", err);
4132
4133 string code;
4134 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
4135 EXPECT_THAT(code, testing::HasSubstr("byte e = Enum.BAR"));
4136}
4137
4138TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4139 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4140 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4141package p;
4142import p.Enum;
4143parcelable Foo {
4144 Enum e = Enum.BAR;
4145})");
4146 CaptureStderr();
4147 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
4148 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4149 auto err = GetCapturedStderr();
4150 EXPECT_EQ("", err);
4151
4152 string code;
4153 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4154 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4155}
4156
4157TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4158 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4159 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4160package p;
4161import p.Enum;
4162parcelable Foo {
4163 Enum e = Enum.BAR;
4164})");
4165 CaptureStderr();
4166 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4167 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4168 auto err = GetCapturedStderr();
4169 EXPECT_EQ("", err);
4170
4171 string code;
4172 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4173 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4174}
4175
4176TEST_F(AidlTest, EnumWithDefaults_Rust) {
4177 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4178 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4179package p;
4180import p.Enum;
4181parcelable Foo {
4182 int n = 42;
4183 Enum e = Enum.BAR;
4184})");
4185 CaptureStderr();
4186 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
4187 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4188 auto err = GetCapturedStderr();
4189 EXPECT_EQ("", err);
4190
4191 string code;
4192 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4193 EXPECT_THAT(code, testing::HasSubstr(R"(
4194 fn default() -> Self {
4195 Self {
4196 n: 42,
4197 e: crate::mangled::_1_p_4_Enum::BAR,
4198 }
4199 })"));
4200}
4201
4202TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4203 import_paths_.insert("a");
4204 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4205 CaptureStderr();
4206 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4207package p;
4208import p.Enum;
4209parcelable Foo {
4210 int e = Enum.FOO | Enum.BAR;
4211})",
4212 typenames_, GetLanguage());
4213 auto err = GetCapturedStderr();
4214 EXPECT_EQ("", err);
4215 EXPECT_TRUE(type);
4216 const auto& fields = type->AsStructuredParcelable()->GetFields();
4217 EXPECT_EQ("int e = 3", fields[0]->ToString());
4218}
4219
4220TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4221 CaptureStderr();
4222 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4223@Backing(type="int")
4224enum Foo {
4225 STANDARD_SHIFT = 16,
4226 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4227 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4228}
4229)",
4230 typenames_, GetLanguage());
4231 auto err = GetCapturedStderr();
4232 EXPECT_EQ("", err);
4233 EXPECT_TRUE(type);
4234 const auto& enum_type = type->AsEnumDeclaration();
4235 string code;
4236 enum_type->Dump(CodeWriter::ForString(&code).get());
4237 EXPECT_EQ(R"--(@Backing(type="int")
4238enum Foo {
4239 STANDARD_SHIFT = 16,
4240 STANDARD_BT709 = 65536,
4241 STANDARD_BT601_625 = 131072,
4242}
4243)--",
4244 code);
4245}
4246
4247TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4248 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4249 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4250package p;
4251import p.Enum;
4252parcelable Foo {
4253 Enum e = Enum.FOO | Enum.BAR;
4254})");
4255 CaptureStderr();
4256 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
4257 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4258 auto err = GetCapturedStderr();
4259 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4260 err);
4261}
4262
4263TEST_P(AidlTest, DefaultWithEmptyArray) {
4264 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4265 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4266 CaptureStderr();
4267 auto options = Options::From("aidl -I a --lang " + Options::LanguageToString(GetLanguage()) +
4268 " -o out -h out a/p/Foo.aidl");
4269 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4270 auto err = GetCapturedStderr();
4271 EXPECT_EQ("", err);
4272}
4273
4274TEST_P(AidlTest, RejectRefsInAnnotation) {
4275 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4276 "package p; interface IFoo {\n"
4277 " const String ANNOTATION = \"@Annotation\";\n"
4278 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4279 "}");
4280 CaptureStderr();
4281 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4282 " -o out -h out a/p/IFoo.aidl");
4283 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4284 auto err = GetCapturedStderr();
4285 EXPECT_EQ(
4286 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4287 "ANNOTATION.\n",
4288 err);
4289}
4290
4291TEST_F(AidlTest, DefaultWithEnumValues) {
4292 io_delegate_.SetFileContents(
4293 "a/p/Foo.aidl",
4294 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4295 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4296 CaptureStderr();
4297 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4298 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4299 auto err = GetCapturedStderr();
4300 EXPECT_EQ("", err);
4301 string code;
4302 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4303 EXPECT_THAT(
4304 code, testing::HasSubstr(
4305 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4306}
4307
Jooyung Han14259392020-12-07 10:00:08 +09004308TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4309 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4310 CaptureStderr();
4311 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4312 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4313 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004314 EXPECT_EQ(
4315 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
4316 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
4317 err);
Jooyung Han14259392020-12-07 10:00:08 +09004318}
4319
4320TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4321 io_delegate_.SetFileContents("a/p/Foo.aidl",
4322 "package p; parcelable Foo { const int A = A + 1; }");
4323 CaptureStderr();
4324 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4325 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4326 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004327 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4328}
4329
4330TEST_F(AidlTest, RecursiveReferences) {
4331 io_delegate_.SetFileContents("a/p/Foo.aidl",
4332 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4333 io_delegate_.SetFileContents("a/p/Bar.aidl",
4334 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4335 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4336 CaptureStderr();
4337 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4338 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4339 EXPECT_EQ("", GetCapturedStderr());
4340}
4341
4342TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4343 string contents = R"(
4344import android.os.IBinder;
4345import android.os.IInterface;
4346interface IFoo {}
4347 )";
4348 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004349}
4350
Jooyung Hanfd3be322020-12-13 09:11:06 +09004351struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004352 string kind;
4353 string literal;
4354};
4355
Jooyung Hanfd3be322020-12-13 09:11:06 +09004356const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004357 {"primitive", "int"}, {"String", "String"},
4358 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4359 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4360 {"union", "a.Union"}, {"interface", "a.IBar"},
4361};
4362
4363const std::map<std::string, std::string> kListSupportExpectations = {
4364 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4365 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4366 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4367 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
4368 {"cpp_String", ""},
4369 {"java_String", ""},
4370 {"ndk_String", ""},
4371 {"rust_String", ""},
4372 {"cpp_IBinder", ""},
4373 {"java_IBinder", ""},
4374 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4375 {"rust_IBinder", ""},
4376 {"cpp_ParcelFileDescriptor", "List<ParcelFileDescriptor> is not supported."},
4377 {"java_ParcelFileDescriptor", ""},
4378 {"ndk_ParcelFileDescriptor", ""},
4379 {"rust_ParcelFileDescriptor", ""},
4380 {"cpp_interface",
4381 "List<a.IBar> is not supported. List in cpp supports only String and IBinder."},
4382 {"java_interface",
4383 "List<a.IBar> is not supported. List in Java supports only String, IBinder, and "
4384 "ParcelFileDescriptor."},
4385 {"ndk_interface", "List<a.IBar> is not supported. List in NDK doesn't support interface."},
4386 {"rust_interface", ""},
4387 {"cpp_parcelable",
4388 "List<a.Foo> is not supported. List in cpp supports only String and IBinder."},
4389 {"java_parcelable", ""},
4390 {"ndk_parcelable", ""},
4391 {"rust_parcelable", ""},
4392 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4393 {"java_enum", "A generic type cannot have any primitive type parameters."},
4394 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4395 {"rust_enum", "A generic type cannot have any primitive type parameters."},
4396 {"cpp_union", "List<a.Union> is not supported. List in cpp supports only String and IBinder."},
4397 {"java_union", ""},
4398 {"ndk_union", ""},
4399 {"rust_union", ""},
4400};
4401
Jooyung Hand236e552020-12-13 09:21:27 +09004402const std::map<std::string, std::string> kArraySupportExpectations = {
4403 {"cpp_primitive", ""},
4404 {"java_primitive", ""},
4405 {"ndk_primitive", ""},
4406 {"rust_primitive", ""},
4407 {"cpp_String", ""},
4408 {"java_String", ""},
4409 {"ndk_String", ""},
4410 {"rust_String", ""},
4411 {"cpp_IBinder", ""},
4412 {"java_IBinder", ""},
4413 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4414 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4415 {"cpp_ParcelFileDescriptor", ""},
4416 {"java_ParcelFileDescriptor", ""},
4417 {"ndk_ParcelFileDescriptor", ""},
4418 {"rust_ParcelFileDescriptor", ""},
4419 {"cpp_interface", "Binder type cannot be an array"},
4420 {"java_interface", "Binder type cannot be an array"},
4421 {"ndk_interface", "Binder type cannot be an array"},
4422 {"rust_interface", "Binder type cannot be an array"},
4423 {"cpp_parcelable", ""},
4424 {"java_parcelable", ""},
4425 {"ndk_parcelable", ""},
4426 {"rust_parcelable", ""},
4427 {"cpp_enum", ""},
4428 {"java_enum", ""},
4429 {"ndk_enum", ""},
4430 {"rust_enum", ""},
4431 {"cpp_union", ""},
4432 {"java_union", ""},
4433 {"ndk_union", ""},
4434 {"rust_union", ""},
4435};
4436
Jooyung Hanfd3be322020-12-13 09:11:06 +09004437class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004438 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004439 void Run(const std::string& generic_type_decl,
4440 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004441 const auto& param = GetParam();
4442 const auto& lang = Options::LanguageToString(std::get<0>(param));
4443 const auto& kind = std::get<1>(param).kind;
4444
4445 FakeIoDelegate io;
4446 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4447 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4448 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004449 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4450 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004451
4452 const auto options =
4453 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4454 CaptureStderr();
4455 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004456 auto it = expectations.find(lang + "_" + kind);
4457 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004458 const string err = GetCapturedStderr();
4459 if (it->second.empty()) {
4460 EXPECT_EQ("", err);
4461 } else {
4462 EXPECT_THAT(err, testing::HasSubstr(it->second));
4463 }
4464 }
4465};
4466
4467INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004468 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004469 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4470 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004471 testing::ValuesIn(kTypeParams)),
4472 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004473 return Options::LanguageToString(std::get<0>(info.param)) + "_" +
4474 std::get<1>(info.param).kind;
4475 });
4476
Jooyung Hanfd3be322020-12-13 09:11:06 +09004477TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4478 Run("List<{}>", kListSupportExpectations);
4479}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004480
Jooyung Hand236e552020-12-13 09:21:27 +09004481TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4482 Run("{}[]", kArraySupportExpectations);
4483}
4484
Christopher Wiley90be4e32015-10-20 14:55:25 -07004485} // namespace aidl
4486} // namespace android