blob: 347b45bc89e61e4ce6391db40ff1023f067c6b0c [file] [log] [blame]
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001//
2// Copyright 2016 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6// FramebufferVk.cpp:
7// Implements the class methods for FramebufferVk.
8//
9
10#include "libANGLE/renderer/vulkan/FramebufferVk.h"
11
Jamie Madill7b57b9d2017-01-13 09:33:38 -050012#include <vulkan/vulkan.h>
Jamie Madill231c7f52017-04-26 13:45:37 -040013#include <array>
Jamie Madill7b57b9d2017-01-13 09:33:38 -050014
Jamie Madill9e54b5a2016-05-25 12:57:39 -040015#include "common/debug.h"
Jamie Madillc564c072017-06-01 12:45:42 -040016#include "libANGLE/Context.h"
17#include "libANGLE/Display.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050018#include "libANGLE/formatutils.h"
19#include "libANGLE/renderer/renderer_utils.h"
Jamie Madill1f46bc12018-02-20 16:09:43 -050020#include "libANGLE/renderer/vulkan/CommandGraph.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050021#include "libANGLE/renderer/vulkan/ContextVk.h"
Jamie Madill5deea722017-02-16 10:44:46 -050022#include "libANGLE/renderer/vulkan/DisplayVk.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050023#include "libANGLE/renderer/vulkan/RenderTargetVk.h"
24#include "libANGLE/renderer/vulkan/RendererVk.h"
25#include "libANGLE/renderer/vulkan/SurfaceVk.h"
Jamie Madill3c424b42018-01-19 12:35:09 -050026#include "libANGLE/renderer/vulkan/vk_format_utils.h"
Tobin Ehlis4a419142019-02-05 08:50:30 -070027#include "third_party/trace_event/trace_event.h"
Jamie Madill9e54b5a2016-05-25 12:57:39 -040028
29namespace rx
30{
31
Jamie Madill7b57b9d2017-01-13 09:33:38 -050032namespace
33{
Luc Ferron534b00d2018-05-18 08:16:53 -040034constexpr size_t kMinReadPixelsBufferSize = 128000;
35
Jamie Madill66546be2018-03-08 09:47:20 -050036const gl::InternalFormat &GetReadAttachmentInfo(const gl::Context *context,
37 RenderTargetVk *renderTarget)
Jamie Madill7b57b9d2017-01-13 09:33:38 -050038{
Jamie Madillbc543422018-03-30 10:43:19 -040039 GLenum implFormat =
Jamie Madillbcf467f2018-05-23 09:46:00 -040040 renderTarget->getImageFormat().textureFormat().fboImplementationInternalFormat;
Jamie Madill66546be2018-03-08 09:47:20 -050041 return gl::GetSizedInternalFormatInfo(implFormat);
Jamie Madill7b57b9d2017-01-13 09:33:38 -050042}
Luc Ferron26581112018-06-21 09:43:08 -040043
Jamie Madilld754eb52018-07-19 14:55:03 -040044bool ClipToRenderTarget(const gl::Rectangle &area,
45 RenderTargetVk *renderTarget,
46 gl::Rectangle *rectOut)
47{
Shahbaz Youssefi68549402019-03-25 23:30:49 -040048 const gl::Extents renderTargetExtents = renderTarget->getExtents();
Jamie Madilld754eb52018-07-19 14:55:03 -040049 gl::Rectangle renderTargetRect(0, 0, renderTargetExtents.width, renderTargetExtents.height);
50 return ClipRectangle(area, renderTargetRect, rectOut);
51}
52
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050053bool HasSrcAndDstBlitProperties(RendererVk *renderer,
Luc Ferron26581112018-06-21 09:43:08 -040054 RenderTargetVk *srcRenderTarget,
55 RenderTargetVk *dstRenderTarget)
56{
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050057 const VkFormat srcFormat = srcRenderTarget->getImageFormat().vkTextureFormat;
58 const VkFormat dstFormat = dstRenderTarget->getImageFormat().vkTextureFormat;
Luc Ferron26581112018-06-21 09:43:08 -040059
60 // Verifies if the draw and read images have the necessary prerequisites for blitting.
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050061 return renderer->hasTextureFormatFeatureBits(srcFormat, VK_FORMAT_FEATURE_BLIT_SRC_BIT) &&
62 renderer->hasTextureFormatFeatureBits(dstFormat, VK_FORMAT_FEATURE_BLIT_DST_BIT);
Luc Ferron26581112018-06-21 09:43:08 -040063}
Jamie Madillb436aac2018-07-18 17:23:48 -040064
65// Special rules apply to VkBufferImageCopy with depth/stencil. The components are tightly packed
66// into a depth or stencil section of the destination buffer. See the spec:
67// https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkBufferImageCopy.html
68const angle::Format &GetDepthStencilImageToBufferFormat(const angle::Format &imageFormat,
69 VkImageAspectFlagBits copyAspect)
70{
71 if (copyAspect == VK_IMAGE_ASPECT_STENCIL_BIT)
72 {
73 ASSERT(imageFormat.id == angle::FormatID::D24_UNORM_S8_UINT ||
74 imageFormat.id == angle::FormatID::D32_FLOAT_S8X24_UINT ||
75 imageFormat.id == angle::FormatID::S8_UINT);
76 return angle::Format::Get(angle::FormatID::S8_UINT);
77 }
78
79 ASSERT(copyAspect == VK_IMAGE_ASPECT_DEPTH_BIT);
80
81 switch (imageFormat.id)
82 {
83 case angle::FormatID::D16_UNORM:
84 return imageFormat;
85 case angle::FormatID::D24_UNORM_X8_UINT:
86 return imageFormat;
87 case angle::FormatID::D24_UNORM_S8_UINT:
88 return angle::Format::Get(angle::FormatID::D24_UNORM_X8_UINT);
89 case angle::FormatID::D32_FLOAT:
90 return imageFormat;
91 case angle::FormatID::D32_FLOAT_S8X24_UINT:
92 return angle::Format::Get(angle::FormatID::D32_FLOAT);
93 default:
94 UNREACHABLE();
95 return imageFormat;
96 }
97}
Jamie Madillbcf467f2018-05-23 09:46:00 -040098} // anonymous namespace
Jamie Madill7b57b9d2017-01-13 09:33:38 -050099
100// static
Jamie Madill639bc902018-07-18 17:08:27 -0400101FramebufferVk *FramebufferVk::CreateUserFBO(RendererVk *renderer, const gl::FramebufferState &state)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500102{
Jamie Madill639bc902018-07-18 17:08:27 -0400103 return new FramebufferVk(renderer, state, nullptr);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500104}
105
106// static
Jamie Madill639bc902018-07-18 17:08:27 -0400107FramebufferVk *FramebufferVk::CreateDefaultFBO(RendererVk *renderer,
108 const gl::FramebufferState &state,
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500109 WindowSurfaceVk *backbuffer)
110{
Jamie Madill639bc902018-07-18 17:08:27 -0400111 return new FramebufferVk(renderer, state, backbuffer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500112}
113
Jamie Madill639bc902018-07-18 17:08:27 -0400114FramebufferVk::FramebufferVk(RendererVk *renderer,
115 const gl::FramebufferState &state,
116 WindowSurfaceVk *backbuffer)
Jamie Madill9aef3672018-04-27 11:45:06 -0400117 : FramebufferImpl(state),
118 mBackbuffer(backbuffer),
Jamie Madill9aef3672018-04-27 11:45:06 -0400119 mActiveColorComponents(0),
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -0500120 mReadPixelBuffer(VK_BUFFER_USAGE_TRANSFER_DST_BIT, kMinReadPixelsBufferSize, true),
121 mBlitPixelBuffer(VK_BUFFER_USAGE_TRANSFER_SRC_BIT, kMinReadPixelsBufferSize, true)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500122{
Jamie Madill639bc902018-07-18 17:08:27 -0400123 mBlitPixelBuffer.init(1, renderer);
Frank Henigman49b0f6e2018-10-03 23:15:29 -0400124 mReadPixelBuffer.init(4, renderer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500125}
126
Jamie Madill58675012018-05-22 14:54:07 -0400127FramebufferVk::~FramebufferVk() = default;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400128
Jamie Madillc564c072017-06-01 12:45:42 -0400129void FramebufferVk::destroy(const gl::Context *context)
Jamie Madill5deea722017-02-16 10:44:46 -0500130{
Luc Ferron534b00d2018-05-18 08:16:53 -0400131 ContextVk *contextVk = vk::GetImpl(context);
132 RendererVk *renderer = contextVk->getRenderer();
Jamie Madille8dd0792018-09-27 15:04:27 -0400133 mFramebuffer.release(renderer);
Luc Ferron534b00d2018-05-18 08:16:53 -0400134
Shahbaz Youssefifca8fd62018-11-13 13:55:48 -0500135 mReadPixelBuffer.release(renderer);
136 mBlitPixelBuffer.release(renderer);
Jamie Madill5deea722017-02-16 10:44:46 -0500137}
138
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400139angle::Result FramebufferVk::discard(const gl::Context *context,
140 size_t count,
141 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400142{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400143 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500144 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400145}
146
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400147angle::Result FramebufferVk::invalidate(const gl::Context *context,
148 size_t count,
149 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400150{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400151 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500152 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400153}
154
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400155angle::Result FramebufferVk::invalidateSub(const gl::Context *context,
156 size_t count,
157 const GLenum *attachments,
158 const gl::Rectangle &area)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400159{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400160 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500161 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400162}
163
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400164angle::Result FramebufferVk::clear(const gl::Context *context, GLbitfield mask)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400165{
Jamie Madill0cec82a2018-03-14 09:21:07 -0400166 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500167
Jamie Madill0cec82a2018-03-14 09:21:07 -0400168 // This command buffer is only started once.
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400169 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500170
Jamie Madill0cec82a2018-03-14 09:21:07 -0400171 const gl::FramebufferAttachment *depthAttachment = mState.getDepthAttachment();
172 bool clearDepth = (depthAttachment && (mask & GL_DEPTH_BUFFER_BIT) != 0);
173 ASSERT(!clearDepth || depthAttachment->isAttached());
174
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -0400175 // If depth write is disabled, pretend that GL_DEPTH_BUFFER_BIT is not specified altogether.
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500176 clearDepth = clearDepth && contextVk->getState().getDepthStencilState().depthMask;
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -0400177
Jamie Madill0cec82a2018-03-14 09:21:07 -0400178 const gl::FramebufferAttachment *stencilAttachment = mState.getStencilAttachment();
179 bool clearStencil = (stencilAttachment && (mask & GL_STENCIL_BUFFER_BIT) != 0);
180 ASSERT(!clearStencil || stencilAttachment->isAttached());
181
Luc Ferrona8af3a62018-03-29 14:44:24 -0400182 bool clearColor = IsMaskFlagSet(static_cast<int>(mask), GL_COLOR_BUFFER_BIT);
183
Shahbaz Youssefi02a579e2019-03-27 14:21:20 -0400184 // If the only thing to be cleared was depth and it's masked, there's nothing to do.
185 if (!clearColor && !clearDepth && !clearStencil)
186 {
187 return angle::Result::Continue;
188 }
189
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500190 const gl::State &glState = context->getState();
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400191
192 VkClearDepthStencilValue clearDepthStencilValue =
193 contextVk->getClearDepthStencilValue().depthStencil;
194
195 // Apply the stencil mask to the clear value.
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500196 clearDepthStencilValue.stencil &= contextVk->getState().getDepthStencilState().stencilWritemask;
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400197
198 // If the depth or stencil is being cleared, and the image was originally requested to have a
199 // single aspect, but it's emulated with a depth/stencil format, clear both aspects, setting the
200 // other aspect to 0.
201 if (clearStencil || clearDepth)
202 {
203 RenderTargetVk *depthStencil = mRenderTargetCache.getDepthStencil();
204 const vk::Format &format = depthStencil->getImageFormat();
205
206 // GL_DEPTH_COMPONENT24 is always emulated with a format that has stencil.
207 if (format.angleFormat().stencilBits == 0)
208 {
209 clearStencil = true;
210 clearDepthStencilValue.stencil = 0;
211 }
212 // GL_STENCIL_INDEX8 may or may not be emulated.
213 else if (format.angleFormat().depthBits == 0 && format.vkTextureFormat != VK_FORMAT_S8_UINT)
214 {
215 clearDepth = true;
216 clearDepthStencilValue.depth = 0;
217 }
218 }
Luc Ferron8836f632018-04-05 07:26:53 -0400219
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400220 // If scissor is enabled, but covers the whole of framebuffer, it can be considered disabled for
221 // the sake of clear.
222 const gl::Rectangle &scissorRect = glState.getScissor();
223 const gl::Rectangle renderArea(0, 0, mState.getDimensions().width,
224 mState.getDimensions().height);
225 bool isScissorTestEffectivelyEnabled =
226 glState.isScissorTestEnabled() && scissorRect != renderArea;
227
228 // We can use render pass load ops if clearing depth/stencil or unmasked color. If there's a
229 // depth mask, depth clearing is disabled. If there's a stencil mask, the clear value is
230 // already masked. There is no depth/stencil condition prohibiting the use of render pass
231 // loadOp.
232 VkColorComponentFlags colorMaskFlags = contextVk->getClearColorMask();
233 bool maskedClearColor =
234 clearColor && (mActiveColorComponents & colorMaskFlags) != mActiveColorComponents;
235
236 if (!maskedClearColor && !isScissorTestEffectivelyEnabled &&
237 !contextVk->getRenderer()->getFeatures().disableClearWithRenderPassLoadOp)
238 {
239 // Note(syoussefi): A possible optimization could be to allow depth/stencil clear in
240 // presence of color mask, and leave the color clear to the following steps, i.e. start a
241 // render pass with depth/stencil = Clear and have a subsequent draw call within the render
242 // pass to clear the color. That could render some of the depth/stencil clear paths below
243 // unnecessary.
244 return clearWithRenderPassOp(contextVk, clearColor, clearDepth, clearStencil,
245 contextVk->getClearColorValue().color, clearDepthStencilValue);
246 }
247
Jamie Madill9aef3672018-04-27 11:45:06 -0400248 // The most costly clear mode is when we need to mask out specific color channels. This can
249 // only be done with a draw call. The scissor region however can easily be integrated with
250 // this method. Similarly for depth/stencil clear.
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400251 if (maskedClearColor)
Jamie Madill9aef3672018-04-27 11:45:06 -0400252 {
Jamie Madill21061022018-07-12 23:56:30 -0400253 ANGLE_TRY(clearWithDraw(contextVk, colorMaskFlags));
Jamie Madill78cd9402018-05-10 16:49:58 -0400254
255 // Stencil clears must be handled separately. The only way to write out a stencil value from
256 // a fragment shader in Vulkan is with VK_EXT_shader_stencil_export. Support for this
257 // extension is sparse. Hence, we call into the RenderPass clear path. We similarly clear
258 // depth to keep the code simple, but depth clears could be combined with the masked color
259 // clears as an optimization.
260
261 if (clearDepth || clearStencil)
262 {
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400263 ANGLE_TRY(clearWithClearAttachments(contextVk, false, clearDepth, clearStencil,
264 clearDepthStencilValue));
Jamie Madill78cd9402018-05-10 16:49:58 -0400265 }
Jamie Madill7c985f52018-11-29 18:16:17 -0500266 return angle::Result::Continue;
Jamie Madill9aef3672018-04-27 11:45:06 -0400267 }
268
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400269 if (isScissorTestEffectivelyEnabled)
Luc Ferrona8af3a62018-03-29 14:44:24 -0400270 {
271 // With scissor test enabled, we clear very differently and we don't need to access
272 // the image inside each attachment we can just use clearCmdAttachments with our
273 // scissor region instead.
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400274 ANGLE_TRY(clearWithClearAttachments(contextVk, clearColor, clearDepth, clearStencil,
275 clearDepthStencilValue));
Jamie Madill7c985f52018-11-29 18:16:17 -0500276 return angle::Result::Continue;
Luc Ferrona8af3a62018-03-29 14:44:24 -0400277 }
278
279 // Standard Depth/stencil clear without scissor.
Jamie Madill0cec82a2018-03-14 09:21:07 -0400280 if (clearDepth || clearStencil)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500281 {
Jamie Madille8dd0792018-09-27 15:04:27 -0400282 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Jamie Madill0cec82a2018-03-14 09:21:07 -0400283
Luc Ferron26581112018-06-21 09:43:08 -0400284 RenderTargetVk *renderTarget = mRenderTargetCache.getDepthStencil();
Luc Ferron5bdf8bd2018-06-20 09:51:37 -0400285 const angle::Format &format = renderTarget->getImageFormat().textureFormat();
286 const VkImageAspectFlags aspectFlags = vk::GetDepthStencilAspectFlags(format);
287
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400288 VkImageAspectFlags clearAspects = aspectFlags;
289 if (!clearDepth)
290 {
291 clearAspects &= ~VK_IMAGE_ASPECT_DEPTH_BIT;
292 }
293 if (!clearStencil)
294 {
295 clearAspects &= ~VK_IMAGE_ASPECT_STENCIL_BIT;
296 }
297
Jamie Madille8dd0792018-09-27 15:04:27 -0400298 vk::ImageHelper *image = renderTarget->getImageForWrite(&mFramebuffer);
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400299 image->clearDepthStencil(aspectFlags, clearAspects, clearDepthStencilValue, commandBuffer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500300 }
301
Luc Ferrond3ab3072018-06-19 09:55:04 -0400302 if (!clearColor)
303 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500304 return angle::Result::Continue;
Luc Ferrond3ab3072018-06-19 09:55:04 -0400305 }
306
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500307 const auto *attachment = mState.getFirstNonNullAttachment();
308 ASSERT(attachment && attachment->isAttached());
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500309
Jamie Madill0cec82a2018-03-14 09:21:07 -0400310 if (!commandBuffer)
311 {
Jamie Madille8dd0792018-09-27 15:04:27 -0400312 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Jamie Madill0cec82a2018-03-14 09:21:07 -0400313 }
Jamie Madillefb5a5c2018-01-29 15:56:59 -0500314
Jamie Madill66546be2018-03-08 09:47:20 -0500315 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
Jamie Madill50cf2be2018-06-15 09:46:57 -0400316 const auto &colorRenderTargets = mRenderTargetCache.getColors();
Jamie Madill9aef3672018-04-27 11:45:06 -0400317 const VkClearColorValue &clearColorValue = contextVk->getClearColorValue().color;
Jamie Madill66546be2018-03-08 09:47:20 -0500318 for (size_t colorIndex : mState.getEnabledDrawBuffers())
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500319 {
Luc Ferron5fd36932018-06-19 14:55:50 -0400320 VkClearColorValue modifiedClearColorValue = clearColorValue;
Luc Ferron26581112018-06-21 09:43:08 -0400321 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
Luc Ferron5fd36932018-06-19 14:55:50 -0400322
Shahbaz Youssefie3219402018-12-08 16:54:14 +0100323 // It's possible we're clearing a render target that has no alpha channel but we represent
324 // it with a texture that has one. We must not affect its alpha channel no matter what the
Luc Ferron5fd36932018-06-19 14:55:50 -0400325 // clear value is in that case.
326 if (mEmulatedAlphaAttachmentMask[colorIndex])
327 {
328 modifiedClearColorValue.float32[3] = 1.0;
329 }
330
Jamie Madill66546be2018-03-08 09:47:20 -0500331 ASSERT(colorRenderTarget);
Jamie Madille8dd0792018-09-27 15:04:27 -0400332 vk::ImageHelper *image = colorRenderTarget->getImageForWrite(&mFramebuffer);
Jamie Madill3f3b3582018-09-14 10:38:44 -0400333
334 // If we're clearing a cube map face ensure we only clear the selected layer.
Geoff Lang4a298702019-01-18 10:49:36 -0500335 image->clearColorLayer(modifiedClearColorValue, colorRenderTarget->getLevelIndex(), 1,
Jamie Madill3f3b3582018-09-14 10:38:44 -0400336 colorRenderTarget->getLayerIndex(), 1, commandBuffer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500337 }
338
Jamie Madill7c985f52018-11-29 18:16:17 -0500339 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400340}
341
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400342angle::Result FramebufferVk::clearBufferfv(const gl::Context *context,
343 GLenum buffer,
344 GLint drawbuffer,
345 const GLfloat *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400346{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400347 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500348 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400349}
350
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400351angle::Result FramebufferVk::clearBufferuiv(const gl::Context *context,
352 GLenum buffer,
353 GLint drawbuffer,
354 const GLuint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400355{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400356 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500357 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400358}
359
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400360angle::Result FramebufferVk::clearBufferiv(const gl::Context *context,
361 GLenum buffer,
362 GLint drawbuffer,
363 const GLint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400364{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400365 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500366 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400367}
368
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400369angle::Result FramebufferVk::clearBufferfi(const gl::Context *context,
370 GLenum buffer,
371 GLint drawbuffer,
372 GLfloat depth,
373 GLint stencil)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400374{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400375 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500376 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400377}
378
Jamie Madill4928b7c2017-06-20 12:57:39 -0400379GLenum FramebufferVk::getImplementationColorReadFormat(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400380{
Jamie Madill66546be2018-03-08 09:47:20 -0500381 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).format;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400382}
383
Jamie Madill4928b7c2017-06-20 12:57:39 -0400384GLenum FramebufferVk::getImplementationColorReadType(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400385{
Jamie Madill66546be2018-03-08 09:47:20 -0500386 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).type;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400387}
388
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400389angle::Result FramebufferVk::readPixels(const gl::Context *context,
390 const gl::Rectangle &area,
391 GLenum format,
392 GLenum type,
393 void *pixels)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400394{
Luc Ferrona1c72422018-05-14 15:58:28 -0400395 // Clip read area to framebuffer.
396 const gl::Extents &fbSize = getState().getReadAttachment()->getSize();
397 const gl::Rectangle fbRect(0, 0, fbSize.width, fbSize.height);
Luc Ferronbf6dc372018-06-28 15:24:19 -0400398 ContextVk *contextVk = vk::GetImpl(context);
399 RendererVk *renderer = contextVk->getRenderer();
400
Luc Ferrona1c72422018-05-14 15:58:28 -0400401 gl::Rectangle clippedArea;
402 if (!ClipRectangle(area, fbRect, &clippedArea))
403 {
404 // nothing to read
Jamie Madill7c985f52018-11-29 18:16:17 -0500405 return angle::Result::Continue;
Luc Ferrona1c72422018-05-14 15:58:28 -0400406 }
Luc Ferronbf6dc372018-06-28 15:24:19 -0400407 gl::Rectangle flippedArea = clippedArea;
Geoff Lange076a232018-07-16 15:34:05 -0400408 if (contextVk->isViewportFlipEnabledForReadFBO())
Luc Ferronbf6dc372018-06-28 15:24:19 -0400409 {
410 flippedArea.y = fbRect.height - flippedArea.y - flippedArea.height;
411 }
Luc Ferrona1c72422018-05-14 15:58:28 -0400412
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500413 const gl::State &glState = context->getState();
Frank Henigman1ffad842018-09-24 23:40:45 -0400414 const gl::PixelPackState &packState = glState.getPackState();
Luc Ferronbf6dc372018-06-28 15:24:19 -0400415
Luc Ferrona1c72422018-05-14 15:58:28 -0400416 const gl::InternalFormat &sizedFormatInfo = gl::GetInternalFormatInfo(format, type);
417
418 GLuint outputPitch = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400419 ANGLE_VK_CHECK_MATH(contextVk,
420 sizedFormatInfo.computeRowPitch(type, area.width, packState.alignment,
421 packState.rowLength, &outputPitch));
Luc Ferrona1c72422018-05-14 15:58:28 -0400422 GLuint outputSkipBytes = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400423 ANGLE_VK_CHECK_MATH(contextVk, sizedFormatInfo.computeSkipBytes(type, outputPitch, 0, packState,
424 false, &outputSkipBytes));
Luc Ferrona1c72422018-05-14 15:58:28 -0400425
426 outputSkipBytes += (clippedArea.x - area.x) * sizedFormatInfo.pixelBytes +
427 (clippedArea.y - area.y) * outputPitch;
Luc Ferron60284222018-03-20 16:01:44 -0400428
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400429 const angle::Format &angleFormat = GetFormatFromFormatType(format, type);
430
Frank Henigman1ffad842018-09-24 23:40:45 -0400431 PackPixelsParams params(flippedArea, angleFormat, outputPitch, packState.reverseRowOrder,
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400432 glState.getTargetBuffer(gl::BufferBinding::PixelPack), 0);
Frank Henigman1ffad842018-09-24 23:40:45 -0400433 if (contextVk->isViewportFlipEnabledForReadFBO())
434 {
435 params.reverseRowOrder = !params.reverseRowOrder;
436 }
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500437
Jamie Madill21061022018-07-12 23:56:30 -0400438 ANGLE_TRY(readPixelsImpl(contextVk, flippedArea, params, VK_IMAGE_ASPECT_COLOR_BIT,
Luc Ferron1617e692018-07-11 11:08:19 -0400439 getColorReadRenderTarget(),
Rafael Cintron05a449a2018-06-20 18:08:04 -0700440 static_cast<uint8_t *>(pixels) + outputSkipBytes));
Jamie Madilld754eb52018-07-19 14:55:03 -0400441 mReadPixelBuffer.releaseRetainedBuffers(renderer);
Jamie Madill7c985f52018-11-29 18:16:17 -0500442 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -0400443}
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500444
Luc Ferron26581112018-06-21 09:43:08 -0400445RenderTargetVk *FramebufferVk::getDepthStencilRenderTarget() const
446{
447 return mRenderTargetCache.getDepthStencil();
448}
449
Jamie Madill16c20142018-10-01 13:58:19 -0400450angle::Result FramebufferVk::blitWithCopy(ContextVk *contextVk,
451 const gl::Rectangle &copyArea,
452 RenderTargetVk *readRenderTarget,
453 RenderTargetVk *drawRenderTarget,
454 bool blitDepthBuffer,
455 bool blitStencilBuffer)
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400456{
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500457 VkImageAspectFlags aspectMask =
458 vk::GetDepthStencilAspectFlagsForCopy(blitDepthBuffer, blitStencilBuffer);
Jamie Madill16c20142018-10-01 13:58:19 -0400459
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400460 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400461 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
462
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500463 vk::ImageHelper *writeImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
464 writeImage->changeLayout(writeImage->getAspectFlags(), vk::ImageLayout::TransferDst,
465 commandBuffer);
466
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400467 vk::ImageHelper *readImage = readRenderTarget->getImageForRead(
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500468 &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400469
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500470 VkImageSubresourceLayers readSubresource = {};
471 readSubresource.aspectMask = aspectMask;
472 readSubresource.mipLevel = 0;
473 readSubresource.baseArrayLayer = 0;
474 readSubresource.layerCount = 1;
475
476 VkImageSubresourceLayers writeSubresource = readSubresource;
477
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400478 vk::ImageHelper::Copy(readImage, writeImage, gl::Offset(), gl::Offset(),
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500479 gl::Extents(copyArea.width, copyArea.height, 1), readSubresource,
480 writeSubresource, commandBuffer);
Jamie Madill7c985f52018-11-29 18:16:17 -0500481 return angle::Result::Continue;
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400482}
483
Jamie Madill58675012018-05-22 14:54:07 -0400484RenderTargetVk *FramebufferVk::getColorReadRenderTarget() const
Luc Ferron018709f2018-05-10 13:53:11 -0400485{
486 RenderTargetVk *renderTarget = mRenderTargetCache.getColorRead(mState);
Jamie Madillbcf467f2018-05-23 09:46:00 -0400487 ASSERT(renderTarget && renderTarget->getImage().valid());
Luc Ferron018709f2018-05-10 13:53:11 -0400488 return renderTarget;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400489}
490
Jamie Madill21061022018-07-12 23:56:30 -0400491angle::Result FramebufferVk::blitWithReadback(ContextVk *contextVk,
Jamie Madilld754eb52018-07-19 14:55:03 -0400492 const gl::Rectangle &copyArea,
Jamie Madillb436aac2018-07-18 17:23:48 -0400493 VkImageAspectFlagBits aspect,
Jamie Madill21061022018-07-12 23:56:30 -0400494 RenderTargetVk *readRenderTarget,
495 RenderTargetVk *drawRenderTarget)
Luc Ferron1617e692018-07-11 11:08:19 -0400496{
Jamie Madillb436aac2018-07-18 17:23:48 -0400497 RendererVk *renderer = contextVk->getRenderer();
498 const angle::Format &readFormat = readRenderTarget->getImageFormat().textureFormat();
Luc Ferron1617e692018-07-11 11:08:19 -0400499
Jamie Madillb436aac2018-07-18 17:23:48 -0400500 ASSERT(aspect == VK_IMAGE_ASPECT_DEPTH_BIT || aspect == VK_IMAGE_ASPECT_STENCIL_BIT);
Luc Ferron1617e692018-07-11 11:08:19 -0400501
Jamie Madillb436aac2018-07-18 17:23:48 -0400502 // This path is only currently used for y-flipping depth/stencil blits.
Luc Ferron1617e692018-07-11 11:08:19 -0400503 PackPixelsParams packPixelsParams;
Jamie Madillb980c562018-11-27 11:34:27 -0500504 packPixelsParams.reverseRowOrder = true;
505 packPixelsParams.area.width = copyArea.width;
506 packPixelsParams.area.height = copyArea.height;
507 packPixelsParams.area.x = copyArea.x;
508 packPixelsParams.area.y = copyArea.y;
Luc Ferron1617e692018-07-11 11:08:19 -0400509
Jamie Madillb436aac2018-07-18 17:23:48 -0400510 // Read back depth values into the destination buffer.
511 const angle::Format &copyFormat = GetDepthStencilImageToBufferFormat(readFormat, aspect);
512 packPixelsParams.destFormat = &copyFormat;
513 packPixelsParams.outputPitch = copyFormat.pixelBytes * copyArea.width;
Luc Ferron1617e692018-07-11 11:08:19 -0400514
Jamie Madillb436aac2018-07-18 17:23:48 -0400515 // Allocate a space in the destination buffer to write to.
516 size_t blitAllocationSize = copyFormat.pixelBytes * copyArea.width * copyArea.height;
517 uint8_t *destPtr = nullptr;
518 VkBuffer destBufferHandle = VK_NULL_HANDLE;
Jamie Madill4c310832018-08-29 13:43:17 -0400519 VkDeviceSize destOffset = 0;
Jamie Madillb436aac2018-07-18 17:23:48 -0400520 ANGLE_TRY(mBlitPixelBuffer.allocate(contextVk, blitAllocationSize, &destPtr, &destBufferHandle,
521 &destOffset, nullptr));
Luc Ferron1617e692018-07-11 11:08:19 -0400522
Jamie Madillb436aac2018-07-18 17:23:48 -0400523 ANGLE_TRY(
524 readPixelsImpl(contextVk, copyArea, packPixelsParams, aspect, readRenderTarget, destPtr));
Luc Ferron1617e692018-07-11 11:08:19 -0400525
Shahbaz Youssefi06270c92018-10-03 17:00:25 -0400526 VkBufferImageCopy copyRegion = {};
Jamie Madillb436aac2018-07-18 17:23:48 -0400527 copyRegion.bufferOffset = destOffset;
528 copyRegion.bufferImageHeight = copyArea.height;
529 copyRegion.bufferRowLength = copyArea.width;
530 copyRegion.imageExtent.width = copyArea.width;
531 copyRegion.imageExtent.height = copyArea.height;
532 copyRegion.imageExtent.depth = 1;
533 copyRegion.imageSubresource.mipLevel = 0;
534 copyRegion.imageSubresource.aspectMask = aspect;
535 copyRegion.imageSubresource.baseArrayLayer = 0;
536 copyRegion.imageSubresource.layerCount = 1;
537 copyRegion.imageOffset.x = copyArea.x;
538 copyRegion.imageOffset.y = copyArea.y;
539 copyRegion.imageOffset.z = 0;
540
Jamie Madill21061022018-07-12 23:56:30 -0400541 ANGLE_TRY(mBlitPixelBuffer.flush(contextVk));
Luc Ferron1617e692018-07-11 11:08:19 -0400542
543 // Reinitialize the commandBuffer after a read pixels because it calls
544 // renderer->finish which makes command buffers obsolete.
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400545 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -0400546 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Luc Ferron1617e692018-07-11 11:08:19 -0400547
548 // We read the bytes of the image in a buffer, now we have to copy them into the
549 // destination target.
Jamie Madille8dd0792018-09-27 15:04:27 -0400550 vk::ImageHelper *imageForWrite = drawRenderTarget->getImageForWrite(&mFramebuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400551
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500552 imageForWrite->changeLayout(imageForWrite->getAspectFlags(), vk::ImageLayout::TransferDst,
553 commandBuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400554
Jamie Madillb436aac2018-07-18 17:23:48 -0400555 commandBuffer->copyBufferToImage(destBufferHandle, imageForWrite->getImage(),
556 VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &copyRegion);
Luc Ferron1617e692018-07-11 11:08:19 -0400557
558 mBlitPixelBuffer.releaseRetainedBuffers(renderer);
Jamie Madillb436aac2018-07-18 17:23:48 -0400559
Jamie Madill7c985f52018-11-29 18:16:17 -0500560 return angle::Result::Continue;
Luc Ferron1617e692018-07-11 11:08:19 -0400561}
562
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400563angle::Result FramebufferVk::blit(const gl::Context *context,
564 const gl::Rectangle &sourceArea,
565 const gl::Rectangle &destArea,
566 GLbitfield mask,
567 GLenum filter)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400568{
Luc Ferron26581112018-06-21 09:43:08 -0400569 ContextVk *contextVk = vk::GetImpl(context);
570 RendererVk *renderer = contextVk->getRenderer();
571
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500572 const gl::State &glState = context->getState();
Luc Ferron26581112018-06-21 09:43:08 -0400573 const gl::Framebuffer *sourceFramebuffer = glState.getReadFramebuffer();
Jamie Madillba365932018-07-18 17:23:46 -0400574 bool blitColorBuffer = (mask & GL_COLOR_BUFFER_BIT) != 0;
575 bool blitDepthBuffer = (mask & GL_DEPTH_BUFFER_BIT) != 0;
576 bool blitStencilBuffer = (mask & GL_STENCIL_BUFFER_BIT) != 0;
Luc Ferron26581112018-06-21 09:43:08 -0400577
Luc Ferron26581112018-06-21 09:43:08 -0400578 FramebufferVk *sourceFramebufferVk = vk::GetImpl(sourceFramebuffer);
Luc Ferron82eda932018-07-09 15:10:22 -0400579 bool flipSource = contextVk->isViewportFlipEnabledForReadFBO();
580 bool flipDest = contextVk->isViewportFlipEnabledForDrawFBO();
581
Jamie Madilld754eb52018-07-19 14:55:03 -0400582 gl::Rectangle readRect = sourceArea;
583 gl::Rectangle drawRect = destArea;
584
585 if (glState.isScissorTestEnabled())
586 {
587 const gl::Rectangle scissorRect = glState.getScissor();
588 if (!ClipRectangle(sourceArea, scissorRect, &readRect))
589 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500590 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400591 }
592
593 if (!ClipRectangle(destArea, scissorRect, &drawRect))
594 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500595 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400596 }
597 }
598
599 // After cropping for the scissor, we also want to crop for the size of the buffers.
600
Luc Ferron26581112018-06-21 09:43:08 -0400601 if (blitColorBuffer)
602 {
603 RenderTargetVk *readRenderTarget = sourceFramebufferVk->getColorReadRenderTarget();
604
Jamie Madilld754eb52018-07-19 14:55:03 -0400605 gl::Rectangle readRenderTargetRect;
606 if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect))
607 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500608 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400609 }
610
Luc Ferron26581112018-06-21 09:43:08 -0400611 for (size_t colorAttachment : mState.getEnabledDrawBuffers())
612 {
613 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorAttachment];
614 ASSERT(drawRenderTarget);
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -0500615 ASSERT(HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget));
Jamie Madilld754eb52018-07-19 14:55:03 -0400616
617 gl::Rectangle drawRenderTargetRect;
618 if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect))
619 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500620 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400621 }
622
Jamie Madill16c20142018-10-01 13:58:19 -0400623 ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect,
624 readRenderTarget, drawRenderTarget, filter, true, false,
625 false, flipSource, flipDest));
Luc Ferron26581112018-06-21 09:43:08 -0400626 }
627 }
628
629 if (blitDepthBuffer || blitStencilBuffer)
630 {
631 RenderTargetVk *readRenderTarget = sourceFramebufferVk->getDepthStencilRenderTarget();
632 ASSERT(readRenderTarget);
633
Jamie Madilld754eb52018-07-19 14:55:03 -0400634 gl::Rectangle readRenderTargetRect;
635 if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect))
636 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500637 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400638 }
639
Luc Ferron26581112018-06-21 09:43:08 -0400640 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getDepthStencil();
Jamie Madilld754eb52018-07-19 14:55:03 -0400641 ASSERT(drawRenderTarget);
642
643 gl::Rectangle drawRenderTargetRect;
644 if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect))
645 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500646 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400647 }
648
649 ASSERT(readRenderTargetRect == drawRenderTargetRect);
650 ASSERT(filter == GL_NEAREST);
Luc Ferron26581112018-06-21 09:43:08 -0400651
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -0500652 if (HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget))
Luc Ferron26581112018-06-21 09:43:08 -0400653 {
Jamie Madill16c20142018-10-01 13:58:19 -0400654 ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect,
655 readRenderTarget, drawRenderTarget, filter, false,
656 blitDepthBuffer, blitStencilBuffer, flipSource, flipDest));
Luc Ferron26581112018-06-21 09:43:08 -0400657 }
658 else
659 {
Luc Ferron1617e692018-07-11 11:08:19 -0400660 if (flipSource || flipDest)
661 {
Jamie Madillb436aac2018-07-18 17:23:48 -0400662 if (blitDepthBuffer)
663 {
664 ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect,
Jamie Madill16c20142018-10-01 13:58:19 -0400665 VK_IMAGE_ASPECT_DEPTH_BIT, readRenderTarget,
666 drawRenderTarget));
Jamie Madillb436aac2018-07-18 17:23:48 -0400667 }
668 if (blitStencilBuffer)
669 {
670 ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect,
Jamie Madill16c20142018-10-01 13:58:19 -0400671 VK_IMAGE_ASPECT_STENCIL_BIT, readRenderTarget,
672 drawRenderTarget));
Jamie Madillb436aac2018-07-18 17:23:48 -0400673 }
Luc Ferron1617e692018-07-11 11:08:19 -0400674 }
675 else
676 {
Jamie Madill16c20142018-10-01 13:58:19 -0400677 ANGLE_TRY(blitWithCopy(contextVk, readRenderTargetRect, readRenderTarget,
678 drawRenderTarget, blitDepthBuffer, blitStencilBuffer));
Luc Ferron1617e692018-07-11 11:08:19 -0400679 }
Luc Ferron26581112018-06-21 09:43:08 -0400680 }
681 }
682
Jamie Madill7c985f52018-11-29 18:16:17 -0500683 return angle::Result::Continue;
Luc Ferron26581112018-06-21 09:43:08 -0400684}
685
Jamie Madill16c20142018-10-01 13:58:19 -0400686angle::Result FramebufferVk::blitWithCommand(ContextVk *contextVk,
687 const gl::Rectangle &readRectIn,
688 const gl::Rectangle &drawRectIn,
689 RenderTargetVk *readRenderTarget,
690 RenderTargetVk *drawRenderTarget,
691 GLenum filter,
692 bool colorBlit,
693 bool depthBlit,
694 bool stencilBlit,
695 bool flipSource,
696 bool flipDest)
Luc Ferron26581112018-06-21 09:43:08 -0400697{
698 // Since blitRenderbufferRect is called for each render buffer that needs to be blitted,
699 // it should never be the case that both color and depth/stencil need to be blitted at
700 // at the same time.
701 ASSERT(colorBlit != (depthBlit || stencilBlit));
702
Jamie Madill16c20142018-10-01 13:58:19 -0400703 vk::ImageHelper *dstImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
704
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400705 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400706 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
707
Luc Ferron26581112018-06-21 09:43:08 -0400708 const vk::Format &readImageFormat = readRenderTarget->getImageFormat();
709 VkImageAspectFlags aspectMask =
710 colorBlit ? VK_IMAGE_ASPECT_COLOR_BIT
711 : vk::GetDepthStencilAspectFlags(readImageFormat.textureFormat());
712 vk::ImageHelper *srcImage = readRenderTarget->getImageForRead(
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500713 &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Luc Ferron26581112018-06-21 09:43:08 -0400714
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400715 const gl::Extents sourceFrameBufferExtents = readRenderTarget->getExtents();
Jamie Madilld754eb52018-07-19 14:55:03 -0400716 gl::Rectangle readRect = readRectIn;
717
Luc Ferron82eda932018-07-09 15:10:22 -0400718 if (flipSource)
719 {
Jamie Madilld754eb52018-07-19 14:55:03 -0400720 readRect.y = sourceFrameBufferExtents.height - readRect.y - readRect.height;
Luc Ferron82eda932018-07-09 15:10:22 -0400721 }
722
Jamie Madillba365932018-07-18 17:23:46 -0400723 VkImageBlit blit = {};
724 blit.srcOffsets[0] = {readRect.x0(), flipSource ? readRect.y1() : readRect.y0(), 0};
725 blit.srcOffsets[1] = {readRect.x1(), flipSource ? readRect.y0() : readRect.y1(), 1};
726 blit.srcSubresource.aspectMask = aspectMask;
727 blit.srcSubresource.mipLevel = 0;
Luc Ferron26581112018-06-21 09:43:08 -0400728 blit.srcSubresource.baseArrayLayer = 0;
729 blit.srcSubresource.layerCount = 1;
730 blit.dstSubresource.aspectMask = aspectMask;
731 blit.dstSubresource.mipLevel = 0;
732 blit.dstSubresource.baseArrayLayer = 0;
733 blit.dstSubresource.layerCount = 1;
734
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400735 const gl::Extents drawFrameBufferExtents = drawRenderTarget->getExtents();
736 gl::Rectangle drawRect = drawRectIn;
Luc Ferron26581112018-06-21 09:43:08 -0400737
Luc Ferron82eda932018-07-09 15:10:22 -0400738 if (flipDest)
739 {
Jamie Madilld754eb52018-07-19 14:55:03 -0400740 drawRect.y = drawFrameBufferExtents.height - drawRect.y - drawRect.height;
Luc Ferron82eda932018-07-09 15:10:22 -0400741 }
742
Jamie Madilld754eb52018-07-19 14:55:03 -0400743 blit.dstOffsets[0] = {drawRect.x0(), flipDest ? drawRect.y1() : drawRect.y0(), 0};
744 blit.dstOffsets[1] = {drawRect.x1(), flipDest ? drawRect.y0() : drawRect.y1(), 1};
Luc Ferron26581112018-06-21 09:43:08 -0400745
Luc Ferron26581112018-06-21 09:43:08 -0400746 // Requirement of the copyImageToBuffer, the dst image must be in
747 // VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout.
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500748 dstImage->changeLayout(aspectMask, vk::ImageLayout::TransferDst, commandBuffer);
Luc Ferron26581112018-06-21 09:43:08 -0400749
750 commandBuffer->blitImage(srcImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL,
751 dstImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &blit,
752 gl_vk::GetFilter(filter));
Jamie Madill16c20142018-10-01 13:58:19 -0400753
Jamie Madill7c985f52018-11-29 18:16:17 -0500754 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400755}
756
Kenneth Russellce8602a2017-10-03 18:23:08 -0700757bool FramebufferVk::checkStatus(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400758{
Luc Ferron5bdf8bd2018-06-20 09:51:37 -0400759 // if we have both a depth and stencil buffer, they must refer to the same object
760 // since we only support packed_depth_stencil and not separate depth and stencil
761 if (mState.hasSeparateDepthAndStencilAttachments())
762 {
763 return false;
764 }
765
Jamie Madillb79e7bb2017-10-24 13:55:50 -0400766 return true;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400767}
768
Jamie Madill6f755b22018-10-09 12:48:54 -0400769angle::Result FramebufferVk::syncState(const gl::Context *context,
770 const gl::Framebuffer::DirtyBits &dirtyBits)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400771{
Jamie Madille1f3ad42017-10-28 23:00:42 -0400772 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madill7bd16662017-10-28 19:40:50 -0400773 RendererVk *renderer = contextVk->getRenderer();
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400774
775 ASSERT(dirtyBits.any());
Jamie Madill57d9cbb2018-04-27 11:45:04 -0400776 for (size_t dirtyBit : dirtyBits)
777 {
778 switch (dirtyBit)
779 {
780 case gl::Framebuffer::DIRTY_BIT_DEPTH_ATTACHMENT:
781 case gl::Framebuffer::DIRTY_BIT_STENCIL_ATTACHMENT:
782 ANGLE_TRY(mRenderTargetCache.updateDepthStencilRenderTarget(context, mState));
783 break;
784 case gl::Framebuffer::DIRTY_BIT_DRAW_BUFFERS:
785 case gl::Framebuffer::DIRTY_BIT_READ_BUFFER:
786 case gl::Framebuffer::DIRTY_BIT_DEFAULT_WIDTH:
787 case gl::Framebuffer::DIRTY_BIT_DEFAULT_HEIGHT:
788 case gl::Framebuffer::DIRTY_BIT_DEFAULT_SAMPLES:
789 case gl::Framebuffer::DIRTY_BIT_DEFAULT_FIXED_SAMPLE_LOCATIONS:
790 break;
791 default:
792 {
793 ASSERT(gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0 == 0 &&
794 dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_MAX);
795 size_t colorIndex =
796 static_cast<size_t>(dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0);
797 ANGLE_TRY(mRenderTargetCache.updateColorRenderTarget(context, mState, colorIndex));
Jamie Madill9aef3672018-04-27 11:45:06 -0400798
799 // Update cached masks for masked clears.
800 RenderTargetVk *renderTarget = mRenderTargetCache.getColors()[colorIndex];
801 if (renderTarget)
802 {
Luc Ferron5fd36932018-06-19 14:55:50 -0400803 const angle::Format &emulatedFormat =
804 renderTarget->getImageFormat().textureFormat();
805 updateActiveColorMasks(
806 colorIndex, emulatedFormat.redBits > 0, emulatedFormat.greenBits > 0,
807 emulatedFormat.blueBits > 0, emulatedFormat.alphaBits > 0);
808
Luc Ferron5fd36932018-06-19 14:55:50 -0400809 const angle::Format &sourceFormat =
810 renderTarget->getImageFormat().angleFormat();
811 mEmulatedAlphaAttachmentMask.set(
812 colorIndex, sourceFormat.alphaBits == 0 && emulatedFormat.alphaBits > 0);
Luc Ferron0bb940a2018-06-22 09:59:34 -0400813
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500814 contextVk->updateColorMask(context->getState().getBlendState());
Jamie Madill9aef3672018-04-27 11:45:06 -0400815 }
816 else
817 {
Jamie Madill58675012018-05-22 14:54:07 -0400818 updateActiveColorMasks(colorIndex, false, false, false, false);
Jamie Madill9aef3672018-04-27 11:45:06 -0400819 }
Jamie Madill57d9cbb2018-04-27 11:45:04 -0400820 break;
821 }
822 }
823 }
Jamie Madill66546be2018-03-08 09:47:20 -0500824
Jamie Madill9aef3672018-04-27 11:45:06 -0400825 mActiveColorComponents = gl_vk::GetColorComponentFlags(
Luc Ferron5fd36932018-06-19 14:55:50 -0400826 mActiveColorComponentMasksForClear[0].any(), mActiveColorComponentMasksForClear[1].any(),
827 mActiveColorComponentMasksForClear[2].any(), mActiveColorComponentMasksForClear[3].any());
Jamie Madill9aef3672018-04-27 11:45:06 -0400828
Jamie Madille8dd0792018-09-27 15:04:27 -0400829 mFramebuffer.release(renderer);
Jamie Madill49ac74b2017-12-21 14:42:33 -0500830
Jamie Madill316c6062018-05-29 10:49:45 -0400831 // Will freeze the current set of dependencies on this FBO. The next time we render we will
Jamie Madilla5e06072018-05-18 14:36:05 -0400832 // create a new entry in the command graph.
Jamie Madille8dd0792018-09-27 15:04:27 -0400833 mFramebuffer.finishCurrentCommands(renderer);
Jamie Madill72106562017-03-24 14:18:50 -0400834
Jamie Madilldbc605c2019-01-04 16:39:14 -0500835 // Notify the ContextVk to update the pipeline desc.
836 updateRenderPassDesc();
837 contextVk->onFramebufferChange(mRenderPassDesc);
Jamie Madill19fa1c62018-03-08 09:47:21 -0500838
Jamie Madill7c985f52018-11-29 18:16:17 -0500839 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500840}
841
Jamie Madilldbc605c2019-01-04 16:39:14 -0500842void FramebufferVk::updateRenderPassDesc()
Jamie Madillab9f9c32017-01-17 17:47:34 -0500843{
Jamie Madilldbc605c2019-01-04 16:39:14 -0500844 mRenderPassDesc = {};
845 mRenderPassDesc.setSamples(getSamples());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500846
Jamie Madill66546be2018-03-08 09:47:20 -0500847 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
848 const auto &colorRenderTargets = mRenderTargetCache.getColors();
849 for (size_t colorIndex : mState.getEnabledDrawBuffers())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500850 {
Jamie Madill66546be2018-03-08 09:47:20 -0500851 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
852 ASSERT(colorRenderTarget);
Jamie Madilldbc605c2019-01-04 16:39:14 -0500853 mRenderPassDesc.packAttachment(colorRenderTarget->getImage().getFormat());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500854 }
855
Jamie Madill66546be2018-03-08 09:47:20 -0500856 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
857 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500858 {
Jamie Madilldbc605c2019-01-04 16:39:14 -0500859 mRenderPassDesc.packAttachment(depthStencilRenderTarget->getImage().getFormat());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500860 }
Jamie Madillab9f9c32017-01-17 17:47:34 -0500861}
862
Jamie Madill21061022018-07-12 23:56:30 -0400863angle::Result FramebufferVk::getFramebuffer(ContextVk *contextVk, vk::Framebuffer **framebufferOut)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500864{
865 // If we've already created our cached Framebuffer, return it.
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400866 if (mFramebuffer.valid())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500867 {
Jamie Madille8dd0792018-09-27 15:04:27 -0400868 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -0500869 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500870 }
871
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400872 vk::RenderPass *compatibleRenderPass = nullptr;
873 ANGLE_TRY(contextVk->getRenderer()->getCompatibleRenderPass(contextVk, mRenderPassDesc,
874 &compatibleRenderPass));
Jamie Madillab9f9c32017-01-17 17:47:34 -0500875
876 // If we've a Framebuffer provided by a Surface (default FBO/backbuffer), query it.
877 if (mBackbuffer)
878 {
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400879 return mBackbuffer->getCurrentFramebuffer(contextVk, *compatibleRenderPass, framebufferOut);
Jamie Madillab9f9c32017-01-17 17:47:34 -0500880 }
881
882 // Gather VkImageViews over all FBO attachments, also size of attached region.
883 std::vector<VkImageView> attachments;
884 gl::Extents attachmentsSize;
885
Jamie Madill66546be2018-03-08 09:47:20 -0500886 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
887 const auto &colorRenderTargets = mRenderTargetCache.getColors();
888 for (size_t colorIndex : mState.getEnabledDrawBuffers())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500889 {
Jamie Madill66546be2018-03-08 09:47:20 -0500890 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
891 ASSERT(colorRenderTarget);
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +0100892 attachments.push_back(colorRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500893
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400894 ASSERT(attachmentsSize.empty() || attachmentsSize == colorRenderTarget->getExtents());
895 attachmentsSize = colorRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500896 }
897
Jamie Madill66546be2018-03-08 09:47:20 -0500898 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
899 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500900 {
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +0100901 attachments.push_back(depthStencilRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500902
Jamie Madillbc543422018-03-30 10:43:19 -0400903 ASSERT(attachmentsSize.empty() ||
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400904 attachmentsSize == depthStencilRenderTarget->getExtents());
905 attachmentsSize = depthStencilRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500906 }
907
908 ASSERT(!attachments.empty());
909
Shahbaz Youssefi06270c92018-10-03 17:00:25 -0400910 VkFramebufferCreateInfo framebufferInfo = {};
Jamie Madillab9f9c32017-01-17 17:47:34 -0500911
912 framebufferInfo.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500913 framebufferInfo.flags = 0;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400914 framebufferInfo.renderPass = compatibleRenderPass->getHandle();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500915 framebufferInfo.attachmentCount = static_cast<uint32_t>(attachments.size());
916 framebufferInfo.pAttachments = attachments.data();
917 framebufferInfo.width = static_cast<uint32_t>(attachmentsSize.width);
918 framebufferInfo.height = static_cast<uint32_t>(attachmentsSize.height);
919 framebufferInfo.layers = 1;
920
Jamie Madill21061022018-07-12 23:56:30 -0400921 ANGLE_TRY(mFramebuffer.init(contextVk, framebufferInfo));
Jamie Madill5deea722017-02-16 10:44:46 -0500922
Jamie Madille8dd0792018-09-27 15:04:27 -0400923 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -0500924 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400925}
926
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400927angle::Result FramebufferVk::clearWithRenderPassOp(
928 ContextVk *contextVk,
929 bool clearColor,
930 bool clearDepth,
931 bool clearStencil,
932 const VkClearColorValue &clearColorValue,
933 const VkClearDepthStencilValue &clearDepthStencilValue)
934{
935 vk::CommandBuffer *commandBuffer;
936 return startNewRenderPassImpl(contextVk, clearColor, clearDepth, clearStencil, clearColorValue,
937 clearDepthStencilValue, &commandBuffer);
938}
939
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400940angle::Result FramebufferVk::clearWithClearAttachments(
941 ContextVk *contextVk,
942 bool clearColor,
943 bool clearDepth,
944 bool clearStencil,
945 const VkClearDepthStencilValue &clearDepthStencilValue)
Luc Ferron5242d5b2018-02-15 07:14:35 -0500946{
Jamie Madill316c6062018-05-29 10:49:45 -0400947 // Trigger a new command node to ensure overlapping writes happen sequentially.
Jamie Madille8dd0792018-09-27 15:04:27 -0400948 mFramebuffer.finishCurrentCommands(contextVk->getRenderer());
Jamie Madill9aef3672018-04-27 11:45:06 -0400949
Luc Ferron5242d5b2018-02-15 07:14:35 -0500950 // This command can only happen inside a render pass, so obtain one if its already happening
951 // or create a new one if not.
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400952 vk::CommandBuffer *commandBuffer = nullptr;
953 vk::RecordingMode mode = vk::RecordingMode::Start;
Jamie Madill316c6062018-05-29 10:49:45 -0400954 ANGLE_TRY(getCommandBufferForDraw(contextVk, &commandBuffer, &mode));
Luc Ferron5242d5b2018-02-15 07:14:35 -0500955
Jamie Madill3f3b3582018-09-14 10:38:44 -0400956 // The array layer is offset by the ImageView. So we shouldn't need to set a base array layer.
Shahbaz Youssefi06270c92018-10-03 17:00:25 -0400957 VkClearRect clearRect = {};
Luc Ferrone4c38be2018-04-17 11:09:16 -0400958 clearRect.baseArrayLayer = 0;
959 clearRect.layerCount = 1;
960
961 // When clearing, the scissor region must be clipped to the renderArea per the validation rules
962 // in Vulkan.
963 gl::Rectangle intersection;
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500964 if (!gl::ClipRectangle(contextVk->getState().getScissor(),
Jamie Madille8dd0792018-09-27 15:04:27 -0400965 mFramebuffer.getRenderPassRenderArea(), &intersection))
Luc Ferrone4c38be2018-04-17 11:09:16 -0400966 {
967 // There is nothing to clear since the scissor is outside of the render area.
Jamie Madill7c985f52018-11-29 18:16:17 -0500968 return angle::Result::Continue;
Luc Ferrone4c38be2018-04-17 11:09:16 -0400969 }
Luc Ferron1a135ad2018-07-04 10:35:31 -0400970
Luc Ferrone4c38be2018-04-17 11:09:16 -0400971 clearRect.rect = gl_vk::GetRect(intersection);
972
Luc Ferron82eda932018-07-09 15:10:22 -0400973 if (contextVk->isViewportFlipEnabledForDrawFBO())
Luc Ferron1a135ad2018-07-04 10:35:31 -0400974 {
Jamie Madille8dd0792018-09-27 15:04:27 -0400975 clearRect.rect.offset.y = mFramebuffer.getRenderPassRenderArea().height -
976 clearRect.rect.offset.y - clearRect.rect.extent.height;
Luc Ferron1a135ad2018-07-04 10:35:31 -0400977 }
978
Luc Ferron5242d5b2018-02-15 07:14:35 -0500979 gl::AttachmentArray<VkClearAttachment> clearAttachments;
980 int clearAttachmentIndex = 0;
Luc Ferrona8af3a62018-03-29 14:44:24 -0400981
982 if (clearColor)
Luc Ferron5242d5b2018-02-15 07:14:35 -0500983 {
Luc Ferronf6e160f2018-06-12 10:13:57 -0400984 RenderTargetVk *renderTarget = getColorReadRenderTarget();
985 const vk::Format &format = renderTarget->getImageFormat();
986 VkClearValue modifiedClear = contextVk->getClearColorValue();
987
988 // We need to make sure we are not clearing the alpha channel if we are using a buffer
989 // format that doesn't have an alpha channel.
990 if (format.angleFormat().alphaBits == 0)
991 {
992 modifiedClear.color.float32[3] = 1.0;
993 }
994
Luc Ferrona8af3a62018-03-29 14:44:24 -0400995 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
996 for (size_t colorIndex : mState.getEnabledDrawBuffers())
997 {
998 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
999 clearAttachment.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
1000 clearAttachment.colorAttachment = static_cast<uint32_t>(colorIndex);
Luc Ferronf6e160f2018-06-12 10:13:57 -04001001 clearAttachment.clearValue = modifiedClear;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001002 ++clearAttachmentIndex;
1003 }
1004 }
1005
Shahbaz Youssefid856ca42018-10-31 16:55:12 -04001006 VkClearValue depthStencilClearValue = {};
1007 depthStencilClearValue.depthStencil = clearDepthStencilValue;
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -04001008
Luc Ferrona8af3a62018-03-29 14:44:24 -04001009 if (clearDepth && clearStencil && mState.getDepthStencilAttachment() != nullptr)
1010 {
1011 // When we have a packed depth/stencil attachment we can do 1 clear for both when it
1012 // applies.
Luc Ferron5242d5b2018-02-15 07:14:35 -05001013 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
Luc Ferrona8af3a62018-03-29 14:44:24 -04001014 clearAttachment.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT;
1015 clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED;
Jamie Madill7c985f52018-11-29 18:16:17 -05001016 clearAttachment.clearValue = depthStencilClearValue;
Luc Ferron5242d5b2018-02-15 07:14:35 -05001017 ++clearAttachmentIndex;
1018 }
Luc Ferrona8af3a62018-03-29 14:44:24 -04001019 else
1020 {
1021 if (clearDepth)
1022 {
1023 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
1024 clearAttachment.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT;
1025 clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED;
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -04001026 clearAttachment.clearValue = depthStencilClearValue;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001027 ++clearAttachmentIndex;
1028 }
1029
1030 if (clearStencil)
1031 {
1032 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
1033 clearAttachment.aspectMask = VK_IMAGE_ASPECT_STENCIL_BIT;
1034 clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED;
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -04001035 clearAttachment.clearValue = depthStencilClearValue;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001036 ++clearAttachmentIndex;
1037 }
1038 }
Luc Ferron5242d5b2018-02-15 07:14:35 -05001039
Luc Ferrona8af3a62018-03-29 14:44:24 -04001040 commandBuffer->clearAttachments(static_cast<uint32_t>(clearAttachmentIndex),
Luc Ferron5242d5b2018-02-15 07:14:35 -05001041 clearAttachments.data(), 1, &clearRect);
Jamie Madill7c985f52018-11-29 18:16:17 -05001042 return angle::Result::Continue;
Luc Ferron5242d5b2018-02-15 07:14:35 -05001043}
1044
Jamie Madill21061022018-07-12 23:56:30 -04001045angle::Result FramebufferVk::clearWithDraw(ContextVk *contextVk,
1046 VkColorComponentFlags colorMaskFlags)
Jamie Madill9aef3672018-04-27 11:45:06 -04001047{
Jamie Madilldc65c5b2018-11-21 11:07:26 -05001048 RendererVk *renderer = contextVk->getRenderer();
1049
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001050 // If the format of the framebuffer does not have an alpha channel, we need to make sure we do
Luc Ferron66c2f4a2018-06-19 10:27:57 -04001051 // not affect the alpha channel of the type we're using to emulate the format.
1052 // TODO(jmadill): Implement EXT_draw_buffers http://anglebug.com/2394
1053 RenderTargetVk *renderTarget = mRenderTargetCache.getColors()[0];
1054 ASSERT(renderTarget);
1055
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001056 UtilsVk::ClearImageParameters params = {};
1057 params.colorMaskFlags = colorMaskFlags;
1058 params.alphaMask = &getEmulatedAlphaAttachmentMask();
1059 params.renderPassDesc = &getRenderPassDesc();
1060
1061 const vk::Format &imageFormat = renderTarget->getImageFormat();
1062 params.clearValue = contextVk->getClearColorValue().color;
Luc Ferron66c2f4a2018-06-19 10:27:57 -04001063 bool overrideAlphaWithOne =
1064 imageFormat.textureFormat().alphaBits > 0 && imageFormat.angleFormat().alphaBits == 0;
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001065 params.clearValue.float32[3] = overrideAlphaWithOne ? 1.0f : params.clearValue.float32[3];
Luc Ferron66c2f4a2018-06-19 10:27:57 -04001066
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001067 params.renderAreaHeight = mState.getDimensions().height;
Jamie Madill9aef3672018-04-27 11:45:06 -04001068
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001069 return renderer->getUtils().clearImage(contextVk, this, params);
Jamie Madill9aef3672018-04-27 11:45:06 -04001070}
1071
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001072angle::Result FramebufferVk::getSamplePosition(const gl::Context *context,
1073 size_t index,
1074 GLfloat *xy) const
JiangYizhoubddc46b2016-12-09 09:50:51 +08001075{
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001076 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -05001077 return angle::Result::Stop;
JiangYizhoubddc46b2016-12-09 09:50:51 +08001078}
1079
Jamie Madill21061022018-07-12 23:56:30 -04001080angle::Result FramebufferVk::getCommandBufferForDraw(ContextVk *contextVk,
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001081 vk::CommandBuffer **commandBufferOut,
Jamie Madill21061022018-07-12 23:56:30 -04001082 vk::RecordingMode *modeOut)
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001083{
Jamie Madill49ac74b2017-12-21 14:42:33 -05001084 RendererVk *renderer = contextVk->getRenderer();
Jamie Madillbef918c2017-12-13 13:11:30 -05001085
Jamie Madill316c6062018-05-29 10:49:45 -04001086 // This will clear the current write operation if it is complete.
Jamie Madillc759b8b2019-01-03 15:16:50 -05001087 if (appendToStartedRenderPass(renderer->getCurrentQueueSerial(), commandBufferOut))
Jamie Madill4c26fc22017-02-24 11:04:10 -05001088 {
Jamie Madill316c6062018-05-29 10:49:45 -04001089 *modeOut = vk::RecordingMode::Append;
Jamie Madill7c985f52018-11-29 18:16:17 -05001090 return angle::Result::Continue;
Jamie Madill9cceac42018-03-31 14:19:16 -04001091 }
Jamie Madill4c26fc22017-02-24 11:04:10 -05001092
Jamie Madilld1249de2018-08-28 16:58:53 -04001093 return startNewRenderPass(contextVk, commandBufferOut);
1094}
1095
1096angle::Result FramebufferVk::startNewRenderPass(ContextVk *contextVk,
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001097 vk::CommandBuffer **commandBufferOut)
Jamie Madilld1249de2018-08-28 16:58:53 -04001098{
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001099 VkClearColorValue unusedColor = {};
1100 VkClearDepthStencilValue unusedDepthStencil = {};
1101
1102 return startNewRenderPassImpl(contextVk, false, false, false, unusedColor, unusedDepthStencil,
1103 commandBufferOut);
1104}
1105
1106angle::Result FramebufferVk::startNewRenderPassImpl(
1107 ContextVk *contextVk,
1108 bool clearColor,
1109 bool clearDepth,
1110 bool clearStencil,
1111 const VkClearColorValue &clearColorValue,
1112 const VkClearDepthStencilValue &clearDepthStencilValue,
1113 vk::CommandBuffer **commandBufferOut)
1114{
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001115 vk::Framebuffer *framebuffer = nullptr;
Jamie Madill21061022018-07-12 23:56:30 -04001116 ANGLE_TRY(getFramebuffer(contextVk, &framebuffer));
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001117
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001118 vk::AttachmentOpsArray renderPassAttachmentOps;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001119 std::vector<VkClearValue> attachmentClearValues;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001120
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001121 vk::CommandBuffer *writeCommands = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001122 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &writeCommands));
Jamie Madille4c5a232018-03-02 21:00:31 -05001123
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001124 VkClearValue clearValue;
1125 clearValue.color = clearColorValue;
1126
Jamie Madillbcf467f2018-05-23 09:46:00 -04001127 vk::RenderPassDesc renderPassDesc;
1128
Jamie Madill49ac74b2017-12-21 14:42:33 -05001129 // Initialize RenderPass info.
Jamie Madill66546be2018-03-08 09:47:20 -05001130 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
1131 const auto &colorRenderTargets = mRenderTargetCache.getColors();
1132 for (size_t colorIndex : mState.getEnabledDrawBuffers())
Jamie Madill4c26fc22017-02-24 11:04:10 -05001133 {
Jamie Madill66546be2018-03-08 09:47:20 -05001134 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
1135 ASSERT(colorRenderTarget);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001136
Jamie Madille8dd0792018-09-27 15:04:27 -04001137 colorRenderTarget->onColorDraw(&mFramebuffer, writeCommands, &renderPassDesc);
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001138
1139 VkAttachmentLoadOp colorLoadOp =
1140 clearColor ? VK_ATTACHMENT_LOAD_OP_CLEAR : VK_ATTACHMENT_LOAD_OP_LOAD;
1141
1142 renderPassAttachmentOps.setLayout(attachmentClearValues.size(),
1143 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
1144 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL);
1145 renderPassAttachmentOps.setLoadOp(attachmentClearValues.size(), colorLoadOp,
1146 VK_ATTACHMENT_LOAD_OP_DONT_CARE);
1147 renderPassAttachmentOps.setStoreOp(attachmentClearValues.size(),
1148 VK_ATTACHMENT_STORE_OP_STORE,
1149 VK_ATTACHMENT_STORE_OP_DONT_CARE);
1150
1151 // If the render target doesn't have alpha, but its emulated format has it, clear the alpha
1152 // to 1.
1153 VkClearValue value = clearValue;
1154 if (mEmulatedAlphaAttachmentMask[colorIndex])
1155 {
1156 value.color.float32[3] = 1.0;
1157 }
1158
1159 attachmentClearValues.emplace_back(value);
Jamie Madill66546be2018-03-08 09:47:20 -05001160 }
1161
1162 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1163 if (depthStencilRenderTarget)
1164 {
Jamie Madille8dd0792018-09-27 15:04:27 -04001165 depthStencilRenderTarget->onDepthStencilDraw(&mFramebuffer, writeCommands, &renderPassDesc);
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001166
1167 VkAttachmentLoadOp depthLoadOp =
1168 clearDepth ? VK_ATTACHMENT_LOAD_OP_CLEAR : VK_ATTACHMENT_LOAD_OP_LOAD;
1169 VkAttachmentLoadOp stencilLoadOp =
1170 clearStencil ? VK_ATTACHMENT_LOAD_OP_CLEAR : VK_ATTACHMENT_LOAD_OP_LOAD;
1171
1172 renderPassAttachmentOps.setLayout(attachmentClearValues.size(),
1173 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL,
1174 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
1175 renderPassAttachmentOps.setLoadOp(attachmentClearValues.size(), depthLoadOp, stencilLoadOp);
1176 renderPassAttachmentOps.setStoreOp(attachmentClearValues.size(),
1177 VK_ATTACHMENT_STORE_OP_STORE,
1178 VK_ATTACHMENT_STORE_OP_STORE);
1179
1180 clearValue.depthStencil = clearDepthStencilValue;
1181 attachmentClearValues.emplace_back(clearValue);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001182 }
1183
Luc Ferrond17bdfe2018-04-05 13:50:10 -04001184 gl::Rectangle renderArea =
1185 gl::Rectangle(0, 0, mState.getDimensions().width, mState.getDimensions().height);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001186
Jamie Madilldbc605c2019-01-04 16:39:14 -05001187 return mFramebuffer.beginRenderPass(contextVk, *framebuffer, renderArea, mRenderPassDesc,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001188 renderPassAttachmentOps, attachmentClearValues,
1189 commandBufferOut);
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001190}
1191
Jamie Madill9aef3672018-04-27 11:45:06 -04001192void FramebufferVk::updateActiveColorMasks(size_t colorIndex, bool r, bool g, bool b, bool a)
1193{
Luc Ferron5fd36932018-06-19 14:55:50 -04001194 mActiveColorComponentMasksForClear[0].set(colorIndex, r);
1195 mActiveColorComponentMasksForClear[1].set(colorIndex, g);
1196 mActiveColorComponentMasksForClear[2].set(colorIndex, b);
1197 mActiveColorComponentMasksForClear[3].set(colorIndex, a);
1198}
1199
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001200const gl::DrawBufferMask &FramebufferVk::getEmulatedAlphaAttachmentMask() const
Luc Ferron5fd36932018-06-19 14:55:50 -04001201{
1202 return mEmulatedAlphaAttachmentMask;
Jamie Madill9aef3672018-04-27 11:45:06 -04001203}
Luc Ferron018709f2018-05-10 13:53:11 -04001204
Jamie Madill21061022018-07-12 23:56:30 -04001205angle::Result FramebufferVk::readPixelsImpl(ContextVk *contextVk,
1206 const gl::Rectangle &area,
1207 const PackPixelsParams &packPixelsParams,
Jamie Madillb436aac2018-07-18 17:23:48 -04001208 VkImageAspectFlagBits copyAspectFlags,
Jamie Madill21061022018-07-12 23:56:30 -04001209 RenderTargetVk *renderTarget,
1210 void *pixels)
Luc Ferron018709f2018-05-10 13:53:11 -04001211{
Tobin Ehlis4a419142019-02-05 08:50:30 -07001212 TRACE_EVENT0("gpu.angle", "FramebufferVk::readPixelsImpl");
Jamie Madill58675012018-05-22 14:54:07 -04001213 RendererVk *renderer = contextVk->getRenderer();
1214
Shahbaz Youssefi29b49412019-01-07 14:03:06 -05001215 ANGLE_TRY(renderTarget->ensureImageInitialized(contextVk));
1216
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001217 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001218 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Jamie Madill58675012018-05-22 14:54:07 -04001219
Jamie Madillbcf467f2018-05-23 09:46:00 -04001220 // Note that although we're reading from the image, we need to update the layout below.
Luc Ferron1617e692018-07-11 11:08:19 -04001221
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -05001222 vk::ImageHelper *srcImage =
1223 renderTarget->getImageForRead(&mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Jamie Madillbcf467f2018-05-23 09:46:00 -04001224
Jamie Madillb436aac2018-07-18 17:23:48 -04001225 const angle::Format *readFormat = &srcImage->getFormat().textureFormat();
Luc Ferron1617e692018-07-11 11:08:19 -04001226
Jamie Madillb436aac2018-07-18 17:23:48 -04001227 if (copyAspectFlags != VK_IMAGE_ASPECT_COLOR_BIT)
Luc Ferron1617e692018-07-11 11:08:19 -04001228 {
Jamie Madillb436aac2018-07-18 17:23:48 -04001229 readFormat = &GetDepthStencilImageToBufferFormat(*readFormat, copyAspectFlags);
Luc Ferron1617e692018-07-11 11:08:19 -04001230 }
1231
Jamie Madillb980c562018-11-27 11:34:27 -05001232 VkBuffer bufferHandle = VK_NULL_HANDLE;
1233 uint8_t *readPixelBuffer = nullptr;
Jamie Madill4c310832018-08-29 13:43:17 -04001234 VkDeviceSize stagingOffset = 0;
Jamie Madillb980c562018-11-27 11:34:27 -05001235 size_t allocationSize = readFormat->pixelBytes * area.width * area.height;
Luc Ferron018709f2018-05-10 13:53:11 -04001236
Jamie Madilld754eb52018-07-19 14:55:03 -04001237 ANGLE_TRY(mReadPixelBuffer.allocate(contextVk, allocationSize, &readPixelBuffer, &bufferHandle,
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -05001238 &stagingOffset, nullptr));
Luc Ferron018709f2018-05-10 13:53:11 -04001239
Shahbaz Youssefi06270c92018-10-03 17:00:25 -04001240 VkBufferImageCopy region = {};
Luc Ferron534b00d2018-05-18 08:16:53 -04001241 region.bufferImageHeight = area.height;
Jamie Madill4c310832018-08-29 13:43:17 -04001242 region.bufferOffset = stagingOffset;
Luc Ferron534b00d2018-05-18 08:16:53 -04001243 region.bufferRowLength = area.width;
1244 region.imageExtent.width = area.width;
1245 region.imageExtent.height = area.height;
1246 region.imageExtent.depth = 1;
1247 region.imageOffset.x = area.x;
1248 region.imageOffset.y = area.y;
1249 region.imageOffset.z = 0;
Luc Ferron1617e692018-07-11 11:08:19 -04001250 region.imageSubresource.aspectMask = copyAspectFlags;
Jamie Madill3f3b3582018-09-14 10:38:44 -04001251 region.imageSubresource.baseArrayLayer = renderTarget->getLayerIndex();
Luc Ferron534b00d2018-05-18 08:16:53 -04001252 region.imageSubresource.layerCount = 1;
Geoff Lang4a298702019-01-18 10:49:36 -05001253 region.imageSubresource.mipLevel = renderTarget->getLevelIndex();
Luc Ferron534b00d2018-05-18 08:16:53 -04001254
Jamie Madillbcf467f2018-05-23 09:46:00 -04001255 commandBuffer->copyImageToBuffer(srcImage->getImage(), srcImage->getCurrentLayout(),
1256 bufferHandle, 1, &region);
Luc Ferron018709f2018-05-10 13:53:11 -04001257
1258 // Triggers a full finish.
1259 // TODO(jmadill): Don't block on asynchronous readback.
Jamie Madill21061022018-07-12 23:56:30 -04001260 ANGLE_TRY(renderer->finish(contextVk));
Luc Ferron018709f2018-05-10 13:53:11 -04001261
Luc Ferron534b00d2018-05-18 08:16:53 -04001262 // The buffer we copied to needs to be invalidated before we read from it because its not been
1263 // created with the host coherent bit.
Jamie Madilld754eb52018-07-19 14:55:03 -04001264 ANGLE_TRY(mReadPixelBuffer.invalidate(contextVk));
Yuly Novikov6c6c76c2018-05-17 18:45:06 +00001265
Jamie Madillb436aac2018-07-18 17:23:48 -04001266 PackPixels(packPixelsParams, *readFormat, area.width * readFormat->pixelBytes, readPixelBuffer,
Rafael Cintron05a449a2018-06-20 18:08:04 -07001267 static_cast<uint8_t *>(pixels));
Luc Ferron018709f2018-05-10 13:53:11 -04001268
Jamie Madill7c985f52018-11-29 18:16:17 -05001269 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -04001270}
Jamie Madill58675012018-05-22 14:54:07 -04001271
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001272gl::Extents FramebufferVk::getReadImageExtents() const
Jamie Madill58675012018-05-22 14:54:07 -04001273{
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001274 return getColorReadRenderTarget()->getExtents();
Jamie Madill58675012018-05-22 14:54:07 -04001275}
Jamie Madill502d2e22018-11-01 11:06:23 -04001276
1277RenderTargetVk *FramebufferVk::getFirstRenderTarget() const
1278{
1279 for (auto *renderTarget : mRenderTargetCache.getColors())
1280 {
1281 if (renderTarget)
1282 {
1283 return renderTarget;
1284 }
1285 }
1286
1287 return mRenderTargetCache.getDepthStencil();
1288}
1289
1290GLint FramebufferVk::getSamples() const
1291{
1292 RenderTargetVk *firstRT = getFirstRenderTarget();
1293 return firstRT ? firstRT->getImage().getSamples() : 0;
1294}
1295
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001296} // namespace rx