blob: b5630241841becbdfd96d119d63e5cd98239e689 [file] [log] [blame]
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001//
2// Copyright 2016 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6// FramebufferVk.cpp:
7// Implements the class methods for FramebufferVk.
8//
9
10#include "libANGLE/renderer/vulkan/FramebufferVk.h"
11
Jamie Madill7b57b9d2017-01-13 09:33:38 -050012#include <vulkan/vulkan.h>
Jamie Madill231c7f52017-04-26 13:45:37 -040013#include <array>
Jamie Madill7b57b9d2017-01-13 09:33:38 -050014
Jamie Madill9e54b5a2016-05-25 12:57:39 -040015#include "common/debug.h"
Jamie Madillc564c072017-06-01 12:45:42 -040016#include "libANGLE/Context.h"
17#include "libANGLE/Display.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050018#include "libANGLE/formatutils.h"
19#include "libANGLE/renderer/renderer_utils.h"
Jamie Madill1f46bc12018-02-20 16:09:43 -050020#include "libANGLE/renderer/vulkan/CommandGraph.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050021#include "libANGLE/renderer/vulkan/ContextVk.h"
Jamie Madill5deea722017-02-16 10:44:46 -050022#include "libANGLE/renderer/vulkan/DisplayVk.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050023#include "libANGLE/renderer/vulkan/RenderTargetVk.h"
24#include "libANGLE/renderer/vulkan/RendererVk.h"
25#include "libANGLE/renderer/vulkan/SurfaceVk.h"
Jamie Madill3c424b42018-01-19 12:35:09 -050026#include "libANGLE/renderer/vulkan/vk_format_utils.h"
Tobin Ehlis4a419142019-02-05 08:50:30 -070027#include "third_party/trace_event/trace_event.h"
Jamie Madill9e54b5a2016-05-25 12:57:39 -040028
29namespace rx
30{
31
Jamie Madill7b57b9d2017-01-13 09:33:38 -050032namespace
33{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -040034// The value to assign an alpha channel that's emulated. The type is unsigned int, though it will
35// automatically convert to the actual data type.
36constexpr unsigned int kEmulatedAlphaValue = 1;
37
Luc Ferron534b00d2018-05-18 08:16:53 -040038constexpr size_t kMinReadPixelsBufferSize = 128000;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -040039// Clear values are only used when loadOp=Clear is set in clearWithRenderPassOp. When starting a
40// new render pass, the clear value is set to an unlikely value (bright pink) to stand out better
41// in case of a bug.
42constexpr VkClearValue kUninitializedClearValue = {{{0.95, 0.05, 0.95, 0.95}}};
Luc Ferron534b00d2018-05-18 08:16:53 -040043
Jamie Madill66546be2018-03-08 09:47:20 -050044const gl::InternalFormat &GetReadAttachmentInfo(const gl::Context *context,
45 RenderTargetVk *renderTarget)
Jamie Madill7b57b9d2017-01-13 09:33:38 -050046{
Jamie Madillbc543422018-03-30 10:43:19 -040047 GLenum implFormat =
Jamie Madill0631e192019-04-18 16:09:12 -040048 renderTarget->getImageFormat().imageFormat().fboImplementationInternalFormat;
Jamie Madill66546be2018-03-08 09:47:20 -050049 return gl::GetSizedInternalFormatInfo(implFormat);
Jamie Madill7b57b9d2017-01-13 09:33:38 -050050}
Luc Ferron26581112018-06-21 09:43:08 -040051
Jamie Madilld754eb52018-07-19 14:55:03 -040052bool ClipToRenderTarget(const gl::Rectangle &area,
53 RenderTargetVk *renderTarget,
54 gl::Rectangle *rectOut)
55{
Shahbaz Youssefi68549402019-03-25 23:30:49 -040056 const gl::Extents renderTargetExtents = renderTarget->getExtents();
Jamie Madilld754eb52018-07-19 14:55:03 -040057 gl::Rectangle renderTargetRect(0, 0, renderTargetExtents.width, renderTargetExtents.height);
58 return ClipRectangle(area, renderTargetRect, rectOut);
59}
60
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050061bool HasSrcAndDstBlitProperties(RendererVk *renderer,
Luc Ferron26581112018-06-21 09:43:08 -040062 RenderTargetVk *srcRenderTarget,
63 RenderTargetVk *dstRenderTarget)
64{
Jamie Madill0631e192019-04-18 16:09:12 -040065 const VkFormat srcFormat = srcRenderTarget->getImageFormat().vkImageFormat;
66 const VkFormat dstFormat = dstRenderTarget->getImageFormat().vkImageFormat;
Luc Ferron26581112018-06-21 09:43:08 -040067
68 // Verifies if the draw and read images have the necessary prerequisites for blitting.
Jamie Madill0631e192019-04-18 16:09:12 -040069 return renderer->hasImageFormatFeatureBits(srcFormat, VK_FORMAT_FEATURE_BLIT_SRC_BIT) &&
70 renderer->hasImageFormatFeatureBits(dstFormat, VK_FORMAT_FEATURE_BLIT_DST_BIT);
Luc Ferron26581112018-06-21 09:43:08 -040071}
Jamie Madillb436aac2018-07-18 17:23:48 -040072
73// Special rules apply to VkBufferImageCopy with depth/stencil. The components are tightly packed
74// into a depth or stencil section of the destination buffer. See the spec:
75// https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkBufferImageCopy.html
76const angle::Format &GetDepthStencilImageToBufferFormat(const angle::Format &imageFormat,
77 VkImageAspectFlagBits copyAspect)
78{
79 if (copyAspect == VK_IMAGE_ASPECT_STENCIL_BIT)
80 {
81 ASSERT(imageFormat.id == angle::FormatID::D24_UNORM_S8_UINT ||
82 imageFormat.id == angle::FormatID::D32_FLOAT_S8X24_UINT ||
83 imageFormat.id == angle::FormatID::S8_UINT);
84 return angle::Format::Get(angle::FormatID::S8_UINT);
85 }
86
87 ASSERT(copyAspect == VK_IMAGE_ASPECT_DEPTH_BIT);
88
89 switch (imageFormat.id)
90 {
91 case angle::FormatID::D16_UNORM:
92 return imageFormat;
93 case angle::FormatID::D24_UNORM_X8_UINT:
94 return imageFormat;
95 case angle::FormatID::D24_UNORM_S8_UINT:
96 return angle::Format::Get(angle::FormatID::D24_UNORM_X8_UINT);
97 case angle::FormatID::D32_FLOAT:
98 return imageFormat;
99 case angle::FormatID::D32_FLOAT_S8X24_UINT:
100 return angle::Format::Get(angle::FormatID::D32_FLOAT);
101 default:
102 UNREACHABLE();
103 return imageFormat;
104 }
105}
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400106
107void SetEmulatedAlphaValue(const vk::Format &format, VkClearColorValue *value)
108{
109 if (format.vkFormatIsInt)
110 {
111 if (format.vkFormatIsUnsigned)
112 {
113 value->uint32[3] = kEmulatedAlphaValue;
114 }
115 else
116 {
117 value->int32[3] = kEmulatedAlphaValue;
118 }
119 }
120 else
121 {
122 value->float32[3] = kEmulatedAlphaValue;
123 }
124}
Jamie Madillbcf467f2018-05-23 09:46:00 -0400125} // anonymous namespace
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500126
127// static
Jamie Madill639bc902018-07-18 17:08:27 -0400128FramebufferVk *FramebufferVk::CreateUserFBO(RendererVk *renderer, const gl::FramebufferState &state)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500129{
Jamie Madill639bc902018-07-18 17:08:27 -0400130 return new FramebufferVk(renderer, state, nullptr);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500131}
132
133// static
Jamie Madill639bc902018-07-18 17:08:27 -0400134FramebufferVk *FramebufferVk::CreateDefaultFBO(RendererVk *renderer,
135 const gl::FramebufferState &state,
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500136 WindowSurfaceVk *backbuffer)
137{
Jamie Madill639bc902018-07-18 17:08:27 -0400138 return new FramebufferVk(renderer, state, backbuffer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500139}
140
Jamie Madill639bc902018-07-18 17:08:27 -0400141FramebufferVk::FramebufferVk(RendererVk *renderer,
142 const gl::FramebufferState &state,
143 WindowSurfaceVk *backbuffer)
Jamie Madill9aef3672018-04-27 11:45:06 -0400144 : FramebufferImpl(state),
145 mBackbuffer(backbuffer),
Jamie Madill9aef3672018-04-27 11:45:06 -0400146 mActiveColorComponents(0),
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -0500147 mReadPixelBuffer(VK_BUFFER_USAGE_TRANSFER_DST_BIT, kMinReadPixelsBufferSize, true),
148 mBlitPixelBuffer(VK_BUFFER_USAGE_TRANSFER_SRC_BIT, kMinReadPixelsBufferSize, true)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500149{
Jamie Madill639bc902018-07-18 17:08:27 -0400150 mBlitPixelBuffer.init(1, renderer);
Frank Henigman49b0f6e2018-10-03 23:15:29 -0400151 mReadPixelBuffer.init(4, renderer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500152}
153
Jamie Madill58675012018-05-22 14:54:07 -0400154FramebufferVk::~FramebufferVk() = default;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400155
Jamie Madillc564c072017-06-01 12:45:42 -0400156void FramebufferVk::destroy(const gl::Context *context)
Jamie Madill5deea722017-02-16 10:44:46 -0500157{
Luc Ferron534b00d2018-05-18 08:16:53 -0400158 ContextVk *contextVk = vk::GetImpl(context);
159 RendererVk *renderer = contextVk->getRenderer();
Jamie Madille8dd0792018-09-27 15:04:27 -0400160 mFramebuffer.release(renderer);
Luc Ferron534b00d2018-05-18 08:16:53 -0400161
Shahbaz Youssefifca8fd62018-11-13 13:55:48 -0500162 mReadPixelBuffer.release(renderer);
163 mBlitPixelBuffer.release(renderer);
Jamie Madill5deea722017-02-16 10:44:46 -0500164}
165
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400166angle::Result FramebufferVk::discard(const gl::Context *context,
167 size_t count,
168 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400169{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400170 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500171 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400172}
173
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400174angle::Result FramebufferVk::invalidate(const gl::Context *context,
175 size_t count,
176 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400177{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400178 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500179 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400180}
181
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400182angle::Result FramebufferVk::invalidateSub(const gl::Context *context,
183 size_t count,
184 const GLenum *attachments,
185 const gl::Rectangle &area)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400186{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400187 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500188 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400189}
190
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400191angle::Result FramebufferVk::clear(const gl::Context *context, GLbitfield mask)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400192{
Jamie Madill0cec82a2018-03-14 09:21:07 -0400193 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500194
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400195 bool clearColor = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_COLOR_BUFFER_BIT));
196 bool clearDepth = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_DEPTH_BUFFER_BIT));
197 bool clearStencil = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_STENCIL_BUFFER_BIT));
198 gl::DrawBufferMask clearColorBuffers;
199 if (clearColor)
200 {
201 clearColorBuffers = mState.getEnabledDrawBuffers();
202 }
203
204 const VkClearColorValue &clearColorValue = contextVk->getClearColorValue().color;
205 const VkClearDepthStencilValue &clearDepthStencilValue =
206 contextVk->getClearDepthStencilValue().depthStencil;
207
208 return clearImpl(context, clearColorBuffers, clearDepth, clearStencil, clearColorValue,
209 clearDepthStencilValue);
210}
211
212angle::Result FramebufferVk::clearImpl(const gl::Context *context,
213 gl::DrawBufferMask clearColorBuffers,
214 bool clearDepth,
215 bool clearStencil,
216 const VkClearColorValue &clearColorValue,
217 const VkClearDepthStencilValue &clearDepthStencilValue)
218{
219 ContextVk *contextVk = vk::GetImpl(context);
220
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400221 const gl::Rectangle scissoredRenderArea = getScissoredRenderArea(contextVk);
222
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400223 // Discard clear altogether if scissor has 0 width or height.
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400224 if (scissoredRenderArea.width == 0 || scissoredRenderArea.height == 0)
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400225 {
226 return angle::Result::Continue;
227 }
228
229 mFramebuffer.updateQueueSerial(contextVk->getRenderer()->getCurrentQueueSerial());
230
231 // This function assumes that only enabled attachments are asked to be cleared.
232 ASSERT((clearColorBuffers & mState.getEnabledDrawBuffers()) == clearColorBuffers);
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400233
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400234 // Adjust clear behavior based on whether the respective attachments are present; if asked to
235 // clear a non-existent attachment, don't attempt to clear it.
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400236
237 VkColorComponentFlags colorMaskFlags = contextVk->getClearColorMask();
238 bool clearColor = clearColorBuffers.any();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400239
Jamie Madill0cec82a2018-03-14 09:21:07 -0400240 const gl::FramebufferAttachment *depthAttachment = mState.getDepthAttachment();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400241 clearDepth = clearDepth && depthAttachment;
Jamie Madill0cec82a2018-03-14 09:21:07 -0400242 ASSERT(!clearDepth || depthAttachment->isAttached());
243
244 const gl::FramebufferAttachment *stencilAttachment = mState.getStencilAttachment();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400245 clearStencil = clearStencil && stencilAttachment;
Jamie Madill0cec82a2018-03-14 09:21:07 -0400246 ASSERT(!clearStencil || stencilAttachment->isAttached());
247
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400248 uint8_t stencilMask =
249 static_cast<uint8_t>(contextVk->getState().getDepthStencilState().stencilWritemask);
250
251 // The front-end should ensure we don't attempt to clear color if all channels are masked.
252 ASSERT(!clearColor || colorMaskFlags != 0);
253 // The front-end should ensure we don't attempt to clear depth if depth write is disabled.
254 ASSERT(!clearDepth || contextVk->getState().getDepthStencilState().depthMask);
255 // The front-end should ensure we don't attempt to clear stencil if all bits are masked.
256 ASSERT(!clearStencil || stencilMask != 0);
257
258 // If there is nothing to clear, return right away (for example, if asked to clear depth, but
259 // there is no depth attachment).
Shahbaz Youssefi02a579e2019-03-27 14:21:20 -0400260 if (!clearColor && !clearDepth && !clearStencil)
261 {
262 return angle::Result::Continue;
263 }
264
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400265 VkClearDepthStencilValue modifiedDepthStencilValue = clearDepthStencilValue;
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400266
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400267 // We can use render pass load ops if clearing depth, unmasked color or unmasked stencil. If
268 // there's a depth mask, depth clearing is already disabled.
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400269 bool maskedClearColor =
270 clearColor && (mActiveColorComponents & colorMaskFlags) != mActiveColorComponents;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400271 bool maskedClearStencil = stencilMask != 0xFF;
272
273 bool clearColorWithRenderPassLoadOp = clearColor && !maskedClearColor;
274 bool clearStencilWithRenderPassLoadOp = clearStencil && !maskedClearStencil;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400275
276 // At least one of color, depth or stencil should be clearable with render pass loadOp for us
277 // to use this clear path.
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400278 bool clearAnyWithRenderPassLoadOp =
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400279 clearColorWithRenderPassLoadOp || clearDepth || clearStencilWithRenderPassLoadOp;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400280
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400281 if (clearAnyWithRenderPassLoadOp)
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400282 {
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400283 // Clearing color is indicated by the set bits in this mask. If not clearing colors with
284 // render pass loadOp, the default value of all-zeros means the clear is not done in
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400285 // clearWithRenderPassOp below. In that case, only clear depth/stencil with render pass
286 // loadOp.
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400287 gl::DrawBufferMask clearBuffersWithRenderPassLoadOp;
288 if (clearColorWithRenderPassLoadOp)
289 {
290 clearBuffersWithRenderPassLoadOp = clearColorBuffers;
291 }
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400292 ANGLE_TRY(clearWithRenderPassOp(
293 contextVk, scissoredRenderArea, clearBuffersWithRenderPassLoadOp, clearDepth,
294 clearStencilWithRenderPassLoadOp, clearColorValue, modifiedDepthStencilValue));
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400295
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400296 // On some hardware, having inline commands at this point results in corrupted output. In
297 // that case, end the render pass immediately. http://anglebug.com/2361
Jonah Ryan-Davis776694c2019-05-08 10:28:55 -0400298 if (contextVk->getRenderer()->getFeatures().restartRenderPassAfterLoadOpClear.enabled)
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400299 {
300 mFramebuffer.finishCurrentCommands(contextVk->getRenderer());
301 }
302
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400303 // Fallback to other methods for whatever isn't cleared here.
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400304 clearDepth = false;
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400305 if (clearColorWithRenderPassLoadOp)
306 {
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400307 clearColorBuffers.reset();
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400308 clearColor = false;
309 }
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400310 if (clearStencilWithRenderPassLoadOp)
311 {
312 clearStencil = false;
313 }
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400314
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400315 // If nothing left to clear, early out.
316 if (!clearColor && !clearStencil)
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400317 {
318 return angle::Result::Continue;
319 }
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400320 }
321
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -0400322 // Note: depth clear is always done through render pass loadOp.
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400323 ASSERT(clearDepth == false);
324
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400325 // The most costly clear mode is when we need to mask out specific color channels or stencil
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -0400326 // bits. This can only be done with a draw call.
327 return clearWithDraw(contextVk, scissoredRenderArea, clearColorBuffers, clearStencil,
328 colorMaskFlags, stencilMask, clearColorValue,
329 static_cast<uint8_t>(modifiedDepthStencilValue.stencil));
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400330}
331
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400332angle::Result FramebufferVk::clearBufferfv(const gl::Context *context,
333 GLenum buffer,
334 GLint drawbuffer,
335 const GLfloat *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400336{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400337 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400338
339 bool clearDepth = false;
340 gl::DrawBufferMask clearColorBuffers;
341
342 if (buffer == GL_DEPTH)
343 {
344 clearDepth = true;
345 clearValue.depthStencil.depth = values[0];
346 }
347 else
348 {
349 clearColorBuffers.set(drawbuffer);
350 clearValue.color.float32[0] = values[0];
351 clearValue.color.float32[1] = values[1];
352 clearValue.color.float32[2] = values[2];
353 clearValue.color.float32[3] = values[3];
354 }
355
356 return clearImpl(context, clearColorBuffers, clearDepth, false, clearValue.color,
357 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400358}
359
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400360angle::Result FramebufferVk::clearBufferuiv(const gl::Context *context,
361 GLenum buffer,
362 GLint drawbuffer,
363 const GLuint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400364{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400365 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400366
367 gl::DrawBufferMask clearColorBuffers;
368 clearColorBuffers.set(drawbuffer);
369
370 clearValue.color.uint32[0] = values[0];
371 clearValue.color.uint32[1] = values[1];
372 clearValue.color.uint32[2] = values[2];
373 clearValue.color.uint32[3] = values[3];
374
375 return clearImpl(context, clearColorBuffers, false, false, clearValue.color,
376 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400377}
378
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400379angle::Result FramebufferVk::clearBufferiv(const gl::Context *context,
380 GLenum buffer,
381 GLint drawbuffer,
382 const GLint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400383{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400384 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400385
386 bool clearStencil = false;
387 gl::DrawBufferMask clearColorBuffers;
388
389 if (buffer == GL_STENCIL)
390 {
391 clearStencil = true;
392 clearValue.depthStencil.stencil =
393 gl::clamp(values[0], 0, std::numeric_limits<uint8_t>::max());
394 }
395 else
396 {
397 clearColorBuffers.set(drawbuffer);
398 clearValue.color.int32[0] = values[0];
399 clearValue.color.int32[1] = values[1];
400 clearValue.color.int32[2] = values[2];
401 clearValue.color.int32[3] = values[3];
402 }
403
404 return clearImpl(context, clearColorBuffers, false, clearStencil, clearValue.color,
405 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400406}
407
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400408angle::Result FramebufferVk::clearBufferfi(const gl::Context *context,
409 GLenum buffer,
410 GLint drawbuffer,
411 GLfloat depth,
412 GLint stencil)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400413{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400414 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400415
416 clearValue.depthStencil.depth = depth;
417 clearValue.depthStencil.stencil = gl::clamp(stencil, 0, std::numeric_limits<uint8_t>::max());
418
419 return clearImpl(context, gl::DrawBufferMask(), true, true, clearValue.color,
420 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400421}
422
Jamie Madill4928b7c2017-06-20 12:57:39 -0400423GLenum FramebufferVk::getImplementationColorReadFormat(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400424{
Jamie Madill66546be2018-03-08 09:47:20 -0500425 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).format;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400426}
427
Jamie Madill4928b7c2017-06-20 12:57:39 -0400428GLenum FramebufferVk::getImplementationColorReadType(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400429{
Jamie Madill66546be2018-03-08 09:47:20 -0500430 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).type;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400431}
432
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400433angle::Result FramebufferVk::readPixels(const gl::Context *context,
434 const gl::Rectangle &area,
435 GLenum format,
436 GLenum type,
437 void *pixels)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400438{
Luc Ferrona1c72422018-05-14 15:58:28 -0400439 // Clip read area to framebuffer.
440 const gl::Extents &fbSize = getState().getReadAttachment()->getSize();
441 const gl::Rectangle fbRect(0, 0, fbSize.width, fbSize.height);
Luc Ferronbf6dc372018-06-28 15:24:19 -0400442 ContextVk *contextVk = vk::GetImpl(context);
443 RendererVk *renderer = contextVk->getRenderer();
444
Luc Ferrona1c72422018-05-14 15:58:28 -0400445 gl::Rectangle clippedArea;
446 if (!ClipRectangle(area, fbRect, &clippedArea))
447 {
448 // nothing to read
Jamie Madill7c985f52018-11-29 18:16:17 -0500449 return angle::Result::Continue;
Luc Ferrona1c72422018-05-14 15:58:28 -0400450 }
Luc Ferronbf6dc372018-06-28 15:24:19 -0400451 gl::Rectangle flippedArea = clippedArea;
Geoff Lange076a232018-07-16 15:34:05 -0400452 if (contextVk->isViewportFlipEnabledForReadFBO())
Luc Ferronbf6dc372018-06-28 15:24:19 -0400453 {
454 flippedArea.y = fbRect.height - flippedArea.y - flippedArea.height;
455 }
Luc Ferrona1c72422018-05-14 15:58:28 -0400456
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500457 const gl::State &glState = context->getState();
Frank Henigman1ffad842018-09-24 23:40:45 -0400458 const gl::PixelPackState &packState = glState.getPackState();
Luc Ferronbf6dc372018-06-28 15:24:19 -0400459
Luc Ferrona1c72422018-05-14 15:58:28 -0400460 const gl::InternalFormat &sizedFormatInfo = gl::GetInternalFormatInfo(format, type);
461
462 GLuint outputPitch = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400463 ANGLE_VK_CHECK_MATH(contextVk,
464 sizedFormatInfo.computeRowPitch(type, area.width, packState.alignment,
465 packState.rowLength, &outputPitch));
Luc Ferrona1c72422018-05-14 15:58:28 -0400466 GLuint outputSkipBytes = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400467 ANGLE_VK_CHECK_MATH(contextVk, sizedFormatInfo.computeSkipBytes(type, outputPitch, 0, packState,
468 false, &outputSkipBytes));
Luc Ferrona1c72422018-05-14 15:58:28 -0400469
470 outputSkipBytes += (clippedArea.x - area.x) * sizedFormatInfo.pixelBytes +
471 (clippedArea.y - area.y) * outputPitch;
Luc Ferron60284222018-03-20 16:01:44 -0400472
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400473 const angle::Format &angleFormat = GetFormatFromFormatType(format, type);
474
Frank Henigman1ffad842018-09-24 23:40:45 -0400475 PackPixelsParams params(flippedArea, angleFormat, outputPitch, packState.reverseRowOrder,
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400476 glState.getTargetBuffer(gl::BufferBinding::PixelPack), 0);
Frank Henigman1ffad842018-09-24 23:40:45 -0400477 if (contextVk->isViewportFlipEnabledForReadFBO())
478 {
479 params.reverseRowOrder = !params.reverseRowOrder;
480 }
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500481
Jamie Madill21061022018-07-12 23:56:30 -0400482 ANGLE_TRY(readPixelsImpl(contextVk, flippedArea, params, VK_IMAGE_ASPECT_COLOR_BIT,
Luc Ferron1617e692018-07-11 11:08:19 -0400483 getColorReadRenderTarget(),
Rafael Cintron05a449a2018-06-20 18:08:04 -0700484 static_cast<uint8_t *>(pixels) + outputSkipBytes));
Jamie Madilld754eb52018-07-19 14:55:03 -0400485 mReadPixelBuffer.releaseRetainedBuffers(renderer);
Jamie Madill7c985f52018-11-29 18:16:17 -0500486 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -0400487}
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500488
Luc Ferron26581112018-06-21 09:43:08 -0400489RenderTargetVk *FramebufferVk::getDepthStencilRenderTarget() const
490{
491 return mRenderTargetCache.getDepthStencil();
492}
493
Jamie Madill16c20142018-10-01 13:58:19 -0400494angle::Result FramebufferVk::blitWithCopy(ContextVk *contextVk,
495 const gl::Rectangle &copyArea,
496 RenderTargetVk *readRenderTarget,
497 RenderTargetVk *drawRenderTarget,
498 bool blitDepthBuffer,
499 bool blitStencilBuffer)
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400500{
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500501 VkImageAspectFlags aspectMask =
502 vk::GetDepthStencilAspectFlagsForCopy(blitDepthBuffer, blitStencilBuffer);
Jamie Madill16c20142018-10-01 13:58:19 -0400503
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400504 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400505 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
506
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500507 vk::ImageHelper *writeImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
508 writeImage->changeLayout(writeImage->getAspectFlags(), vk::ImageLayout::TransferDst,
509 commandBuffer);
510
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400511 vk::ImageHelper *readImage = readRenderTarget->getImageForRead(
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500512 &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400513
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500514 VkImageSubresourceLayers readSubresource = {};
515 readSubresource.aspectMask = aspectMask;
516 readSubresource.mipLevel = 0;
517 readSubresource.baseArrayLayer = 0;
518 readSubresource.layerCount = 1;
519
520 VkImageSubresourceLayers writeSubresource = readSubresource;
521
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400522 vk::ImageHelper::Copy(readImage, writeImage, gl::Offset(), gl::Offset(),
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500523 gl::Extents(copyArea.width, copyArea.height, 1), readSubresource,
524 writeSubresource, commandBuffer);
Jamie Madill7c985f52018-11-29 18:16:17 -0500525 return angle::Result::Continue;
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400526}
527
Jamie Madill58675012018-05-22 14:54:07 -0400528RenderTargetVk *FramebufferVk::getColorReadRenderTarget() const
Luc Ferron018709f2018-05-10 13:53:11 -0400529{
530 RenderTargetVk *renderTarget = mRenderTargetCache.getColorRead(mState);
Jamie Madillbcf467f2018-05-23 09:46:00 -0400531 ASSERT(renderTarget && renderTarget->getImage().valid());
Luc Ferron018709f2018-05-10 13:53:11 -0400532 return renderTarget;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400533}
534
Jamie Madill21061022018-07-12 23:56:30 -0400535angle::Result FramebufferVk::blitWithReadback(ContextVk *contextVk,
Jamie Madilld754eb52018-07-19 14:55:03 -0400536 const gl::Rectangle &copyArea,
Jamie Madillb436aac2018-07-18 17:23:48 -0400537 VkImageAspectFlagBits aspect,
Jamie Madill21061022018-07-12 23:56:30 -0400538 RenderTargetVk *readRenderTarget,
539 RenderTargetVk *drawRenderTarget)
Luc Ferron1617e692018-07-11 11:08:19 -0400540{
Jamie Madillb436aac2018-07-18 17:23:48 -0400541 RendererVk *renderer = contextVk->getRenderer();
Jamie Madill0631e192019-04-18 16:09:12 -0400542 const angle::Format &readFormat = readRenderTarget->getImageFormat().imageFormat();
Luc Ferron1617e692018-07-11 11:08:19 -0400543
Jamie Madillb436aac2018-07-18 17:23:48 -0400544 ASSERT(aspect == VK_IMAGE_ASPECT_DEPTH_BIT || aspect == VK_IMAGE_ASPECT_STENCIL_BIT);
Luc Ferron1617e692018-07-11 11:08:19 -0400545
Jamie Madillb436aac2018-07-18 17:23:48 -0400546 // This path is only currently used for y-flipping depth/stencil blits.
Luc Ferron1617e692018-07-11 11:08:19 -0400547 PackPixelsParams packPixelsParams;
Jamie Madillb980c562018-11-27 11:34:27 -0500548 packPixelsParams.reverseRowOrder = true;
549 packPixelsParams.area.width = copyArea.width;
550 packPixelsParams.area.height = copyArea.height;
551 packPixelsParams.area.x = copyArea.x;
552 packPixelsParams.area.y = copyArea.y;
Luc Ferron1617e692018-07-11 11:08:19 -0400553
Jamie Madillb436aac2018-07-18 17:23:48 -0400554 // Read back depth values into the destination buffer.
555 const angle::Format &copyFormat = GetDepthStencilImageToBufferFormat(readFormat, aspect);
556 packPixelsParams.destFormat = &copyFormat;
557 packPixelsParams.outputPitch = copyFormat.pixelBytes * copyArea.width;
Luc Ferron1617e692018-07-11 11:08:19 -0400558
Jamie Madillb436aac2018-07-18 17:23:48 -0400559 // Allocate a space in the destination buffer to write to.
560 size_t blitAllocationSize = copyFormat.pixelBytes * copyArea.width * copyArea.height;
561 uint8_t *destPtr = nullptr;
562 VkBuffer destBufferHandle = VK_NULL_HANDLE;
Jamie Madill4c310832018-08-29 13:43:17 -0400563 VkDeviceSize destOffset = 0;
Jamie Madillb436aac2018-07-18 17:23:48 -0400564 ANGLE_TRY(mBlitPixelBuffer.allocate(contextVk, blitAllocationSize, &destPtr, &destBufferHandle,
565 &destOffset, nullptr));
Luc Ferron1617e692018-07-11 11:08:19 -0400566
Jamie Madillb436aac2018-07-18 17:23:48 -0400567 ANGLE_TRY(
568 readPixelsImpl(contextVk, copyArea, packPixelsParams, aspect, readRenderTarget, destPtr));
Luc Ferron1617e692018-07-11 11:08:19 -0400569
Shahbaz Youssefi06270c92018-10-03 17:00:25 -0400570 VkBufferImageCopy copyRegion = {};
Jamie Madillb436aac2018-07-18 17:23:48 -0400571 copyRegion.bufferOffset = destOffset;
572 copyRegion.bufferImageHeight = copyArea.height;
573 copyRegion.bufferRowLength = copyArea.width;
574 copyRegion.imageExtent.width = copyArea.width;
575 copyRegion.imageExtent.height = copyArea.height;
576 copyRegion.imageExtent.depth = 1;
577 copyRegion.imageSubresource.mipLevel = 0;
578 copyRegion.imageSubresource.aspectMask = aspect;
579 copyRegion.imageSubresource.baseArrayLayer = 0;
580 copyRegion.imageSubresource.layerCount = 1;
581 copyRegion.imageOffset.x = copyArea.x;
582 copyRegion.imageOffset.y = copyArea.y;
583 copyRegion.imageOffset.z = 0;
584
Jamie Madill21061022018-07-12 23:56:30 -0400585 ANGLE_TRY(mBlitPixelBuffer.flush(contextVk));
Luc Ferron1617e692018-07-11 11:08:19 -0400586
587 // Reinitialize the commandBuffer after a read pixels because it calls
588 // renderer->finish which makes command buffers obsolete.
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400589 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -0400590 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Luc Ferron1617e692018-07-11 11:08:19 -0400591
592 // We read the bytes of the image in a buffer, now we have to copy them into the
593 // destination target.
Jamie Madille8dd0792018-09-27 15:04:27 -0400594 vk::ImageHelper *imageForWrite = drawRenderTarget->getImageForWrite(&mFramebuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400595
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500596 imageForWrite->changeLayout(imageForWrite->getAspectFlags(), vk::ImageLayout::TransferDst,
597 commandBuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400598
Jamie Madillb436aac2018-07-18 17:23:48 -0400599 commandBuffer->copyBufferToImage(destBufferHandle, imageForWrite->getImage(),
600 VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &copyRegion);
Luc Ferron1617e692018-07-11 11:08:19 -0400601
602 mBlitPixelBuffer.releaseRetainedBuffers(renderer);
Jamie Madillb436aac2018-07-18 17:23:48 -0400603
Jamie Madill7c985f52018-11-29 18:16:17 -0500604 return angle::Result::Continue;
Luc Ferron1617e692018-07-11 11:08:19 -0400605}
606
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400607angle::Result FramebufferVk::blit(const gl::Context *context,
608 const gl::Rectangle &sourceArea,
609 const gl::Rectangle &destArea,
610 GLbitfield mask,
611 GLenum filter)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400612{
Luc Ferron26581112018-06-21 09:43:08 -0400613 ContextVk *contextVk = vk::GetImpl(context);
614 RendererVk *renderer = contextVk->getRenderer();
615
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500616 const gl::State &glState = context->getState();
Luc Ferron26581112018-06-21 09:43:08 -0400617 const gl::Framebuffer *sourceFramebuffer = glState.getReadFramebuffer();
Jamie Madillba365932018-07-18 17:23:46 -0400618 bool blitColorBuffer = (mask & GL_COLOR_BUFFER_BIT) != 0;
619 bool blitDepthBuffer = (mask & GL_DEPTH_BUFFER_BIT) != 0;
620 bool blitStencilBuffer = (mask & GL_STENCIL_BUFFER_BIT) != 0;
Luc Ferron26581112018-06-21 09:43:08 -0400621
Luc Ferron26581112018-06-21 09:43:08 -0400622 FramebufferVk *sourceFramebufferVk = vk::GetImpl(sourceFramebuffer);
Luc Ferron82eda932018-07-09 15:10:22 -0400623 bool flipSource = contextVk->isViewportFlipEnabledForReadFBO();
624 bool flipDest = contextVk->isViewportFlipEnabledForDrawFBO();
625
Jamie Madilld754eb52018-07-19 14:55:03 -0400626 gl::Rectangle readRect = sourceArea;
627 gl::Rectangle drawRect = destArea;
628
629 if (glState.isScissorTestEnabled())
630 {
631 const gl::Rectangle scissorRect = glState.getScissor();
632 if (!ClipRectangle(sourceArea, scissorRect, &readRect))
633 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500634 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400635 }
636
637 if (!ClipRectangle(destArea, scissorRect, &drawRect))
638 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500639 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400640 }
641 }
642
643 // After cropping for the scissor, we also want to crop for the size of the buffers.
644
Luc Ferron26581112018-06-21 09:43:08 -0400645 if (blitColorBuffer)
646 {
647 RenderTargetVk *readRenderTarget = sourceFramebufferVk->getColorReadRenderTarget();
648
Jamie Madilld754eb52018-07-19 14:55:03 -0400649 gl::Rectangle readRenderTargetRect;
650 if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect))
651 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500652 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400653 }
654
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400655 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Luc Ferron26581112018-06-21 09:43:08 -0400656 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400657 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorIndexGL];
Luc Ferron26581112018-06-21 09:43:08 -0400658 ASSERT(drawRenderTarget);
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -0500659 ASSERT(HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget));
Jamie Madilld754eb52018-07-19 14:55:03 -0400660
661 gl::Rectangle drawRenderTargetRect;
662 if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect))
663 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500664 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400665 }
666
Jamie Madill16c20142018-10-01 13:58:19 -0400667 ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect,
668 readRenderTarget, drawRenderTarget, filter, true, false,
669 false, flipSource, flipDest));
Luc Ferron26581112018-06-21 09:43:08 -0400670 }
671 }
672
673 if (blitDepthBuffer || blitStencilBuffer)
674 {
675 RenderTargetVk *readRenderTarget = sourceFramebufferVk->getDepthStencilRenderTarget();
676 ASSERT(readRenderTarget);
677
Jamie Madilld754eb52018-07-19 14:55:03 -0400678 gl::Rectangle readRenderTargetRect;
679 if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect))
680 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500681 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400682 }
683
Luc Ferron26581112018-06-21 09:43:08 -0400684 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getDepthStencil();
Jamie Madilld754eb52018-07-19 14:55:03 -0400685 ASSERT(drawRenderTarget);
686
687 gl::Rectangle drawRenderTargetRect;
688 if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect))
689 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500690 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400691 }
692
693 ASSERT(readRenderTargetRect == drawRenderTargetRect);
694 ASSERT(filter == GL_NEAREST);
Luc Ferron26581112018-06-21 09:43:08 -0400695
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -0500696 if (HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget))
Luc Ferron26581112018-06-21 09:43:08 -0400697 {
Jamie Madill16c20142018-10-01 13:58:19 -0400698 ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect,
699 readRenderTarget, drawRenderTarget, filter, false,
700 blitDepthBuffer, blitStencilBuffer, flipSource, flipDest));
Luc Ferron26581112018-06-21 09:43:08 -0400701 }
702 else
703 {
Luc Ferron1617e692018-07-11 11:08:19 -0400704 if (flipSource || flipDest)
705 {
Jamie Madillb436aac2018-07-18 17:23:48 -0400706 if (blitDepthBuffer)
707 {
708 ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect,
Jamie Madill16c20142018-10-01 13:58:19 -0400709 VK_IMAGE_ASPECT_DEPTH_BIT, readRenderTarget,
710 drawRenderTarget));
Jamie Madillb436aac2018-07-18 17:23:48 -0400711 }
712 if (blitStencilBuffer)
713 {
714 ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect,
Jamie Madill16c20142018-10-01 13:58:19 -0400715 VK_IMAGE_ASPECT_STENCIL_BIT, readRenderTarget,
716 drawRenderTarget));
Jamie Madillb436aac2018-07-18 17:23:48 -0400717 }
Luc Ferron1617e692018-07-11 11:08:19 -0400718 }
719 else
720 {
Jamie Madill16c20142018-10-01 13:58:19 -0400721 ANGLE_TRY(blitWithCopy(contextVk, readRenderTargetRect, readRenderTarget,
722 drawRenderTarget, blitDepthBuffer, blitStencilBuffer));
Luc Ferron1617e692018-07-11 11:08:19 -0400723 }
Luc Ferron26581112018-06-21 09:43:08 -0400724 }
725 }
726
Jamie Madill7c985f52018-11-29 18:16:17 -0500727 return angle::Result::Continue;
Luc Ferron26581112018-06-21 09:43:08 -0400728}
729
Jamie Madill16c20142018-10-01 13:58:19 -0400730angle::Result FramebufferVk::blitWithCommand(ContextVk *contextVk,
731 const gl::Rectangle &readRectIn,
732 const gl::Rectangle &drawRectIn,
733 RenderTargetVk *readRenderTarget,
734 RenderTargetVk *drawRenderTarget,
735 GLenum filter,
736 bool colorBlit,
737 bool depthBlit,
738 bool stencilBlit,
739 bool flipSource,
740 bool flipDest)
Luc Ferron26581112018-06-21 09:43:08 -0400741{
742 // Since blitRenderbufferRect is called for each render buffer that needs to be blitted,
743 // it should never be the case that both color and depth/stencil need to be blitted at
744 // at the same time.
745 ASSERT(colorBlit != (depthBlit || stencilBlit));
746
Jamie Madill16c20142018-10-01 13:58:19 -0400747 vk::ImageHelper *dstImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
748
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400749 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400750 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
751
Luc Ferron26581112018-06-21 09:43:08 -0400752 const vk::Format &readImageFormat = readRenderTarget->getImageFormat();
753 VkImageAspectFlags aspectMask =
754 colorBlit ? VK_IMAGE_ASPECT_COLOR_BIT
Jamie Madill0631e192019-04-18 16:09:12 -0400755 : vk::GetDepthStencilAspectFlags(readImageFormat.imageFormat());
Luc Ferron26581112018-06-21 09:43:08 -0400756 vk::ImageHelper *srcImage = readRenderTarget->getImageForRead(
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500757 &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Luc Ferron26581112018-06-21 09:43:08 -0400758
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400759 const gl::Extents sourceFrameBufferExtents = readRenderTarget->getExtents();
Jamie Madilld754eb52018-07-19 14:55:03 -0400760 gl::Rectangle readRect = readRectIn;
761
Luc Ferron82eda932018-07-09 15:10:22 -0400762 if (flipSource)
763 {
Jamie Madilld754eb52018-07-19 14:55:03 -0400764 readRect.y = sourceFrameBufferExtents.height - readRect.y - readRect.height;
Luc Ferron82eda932018-07-09 15:10:22 -0400765 }
766
Jamie Madillba365932018-07-18 17:23:46 -0400767 VkImageBlit blit = {};
768 blit.srcOffsets[0] = {readRect.x0(), flipSource ? readRect.y1() : readRect.y0(), 0};
769 blit.srcOffsets[1] = {readRect.x1(), flipSource ? readRect.y0() : readRect.y1(), 1};
770 blit.srcSubresource.aspectMask = aspectMask;
771 blit.srcSubresource.mipLevel = 0;
Luc Ferron26581112018-06-21 09:43:08 -0400772 blit.srcSubresource.baseArrayLayer = 0;
773 blit.srcSubresource.layerCount = 1;
774 blit.dstSubresource.aspectMask = aspectMask;
775 blit.dstSubresource.mipLevel = 0;
776 blit.dstSubresource.baseArrayLayer = 0;
777 blit.dstSubresource.layerCount = 1;
778
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400779 const gl::Extents drawFrameBufferExtents = drawRenderTarget->getExtents();
780 gl::Rectangle drawRect = drawRectIn;
Luc Ferron26581112018-06-21 09:43:08 -0400781
Luc Ferron82eda932018-07-09 15:10:22 -0400782 if (flipDest)
783 {
Jamie Madilld754eb52018-07-19 14:55:03 -0400784 drawRect.y = drawFrameBufferExtents.height - drawRect.y - drawRect.height;
Luc Ferron82eda932018-07-09 15:10:22 -0400785 }
786
Jamie Madilld754eb52018-07-19 14:55:03 -0400787 blit.dstOffsets[0] = {drawRect.x0(), flipDest ? drawRect.y1() : drawRect.y0(), 0};
788 blit.dstOffsets[1] = {drawRect.x1(), flipDest ? drawRect.y0() : drawRect.y1(), 1};
Luc Ferron26581112018-06-21 09:43:08 -0400789
Luc Ferron26581112018-06-21 09:43:08 -0400790 // Requirement of the copyImageToBuffer, the dst image must be in
791 // VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout.
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500792 dstImage->changeLayout(aspectMask, vk::ImageLayout::TransferDst, commandBuffer);
Luc Ferron26581112018-06-21 09:43:08 -0400793
794 commandBuffer->blitImage(srcImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL,
795 dstImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &blit,
796 gl_vk::GetFilter(filter));
Jamie Madill16c20142018-10-01 13:58:19 -0400797
Jamie Madill7c985f52018-11-29 18:16:17 -0500798 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400799}
800
Kenneth Russellce8602a2017-10-03 18:23:08 -0700801bool FramebufferVk::checkStatus(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400802{
Luc Ferron5bdf8bd2018-06-20 09:51:37 -0400803 // if we have both a depth and stencil buffer, they must refer to the same object
804 // since we only support packed_depth_stencil and not separate depth and stencil
805 if (mState.hasSeparateDepthAndStencilAttachments())
806 {
807 return false;
808 }
809
Jamie Madillb79e7bb2017-10-24 13:55:50 -0400810 return true;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400811}
812
Jamie Madill6f755b22018-10-09 12:48:54 -0400813angle::Result FramebufferVk::syncState(const gl::Context *context,
814 const gl::Framebuffer::DirtyBits &dirtyBits)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400815{
Jamie Madille1f3ad42017-10-28 23:00:42 -0400816 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madill7bd16662017-10-28 19:40:50 -0400817 RendererVk *renderer = contextVk->getRenderer();
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400818
819 ASSERT(dirtyBits.any());
Jamie Madill57d9cbb2018-04-27 11:45:04 -0400820 for (size_t dirtyBit : dirtyBits)
821 {
822 switch (dirtyBit)
823 {
824 case gl::Framebuffer::DIRTY_BIT_DEPTH_ATTACHMENT:
825 case gl::Framebuffer::DIRTY_BIT_STENCIL_ATTACHMENT:
826 ANGLE_TRY(mRenderTargetCache.updateDepthStencilRenderTarget(context, mState));
827 break;
828 case gl::Framebuffer::DIRTY_BIT_DRAW_BUFFERS:
829 case gl::Framebuffer::DIRTY_BIT_READ_BUFFER:
830 case gl::Framebuffer::DIRTY_BIT_DEFAULT_WIDTH:
831 case gl::Framebuffer::DIRTY_BIT_DEFAULT_HEIGHT:
832 case gl::Framebuffer::DIRTY_BIT_DEFAULT_SAMPLES:
833 case gl::Framebuffer::DIRTY_BIT_DEFAULT_FIXED_SAMPLE_LOCATIONS:
834 break;
835 default:
836 {
837 ASSERT(gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0 == 0 &&
838 dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_MAX);
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400839 size_t colorIndexGL =
Jamie Madill57d9cbb2018-04-27 11:45:04 -0400840 static_cast<size_t>(dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0);
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400841 ANGLE_TRY(
842 mRenderTargetCache.updateColorRenderTarget(context, mState, colorIndexGL));
Jamie Madill9aef3672018-04-27 11:45:06 -0400843
844 // Update cached masks for masked clears.
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400845 RenderTargetVk *renderTarget = mRenderTargetCache.getColors()[colorIndexGL];
Jamie Madill9aef3672018-04-27 11:45:06 -0400846 if (renderTarget)
847 {
Luc Ferron5fd36932018-06-19 14:55:50 -0400848 const angle::Format &emulatedFormat =
Jamie Madill0631e192019-04-18 16:09:12 -0400849 renderTarget->getImageFormat().imageFormat();
Luc Ferron5fd36932018-06-19 14:55:50 -0400850 updateActiveColorMasks(
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400851 colorIndexGL, emulatedFormat.redBits > 0, emulatedFormat.greenBits > 0,
Luc Ferron5fd36932018-06-19 14:55:50 -0400852 emulatedFormat.blueBits > 0, emulatedFormat.alphaBits > 0);
853
Luc Ferron5fd36932018-06-19 14:55:50 -0400854 const angle::Format &sourceFormat =
855 renderTarget->getImageFormat().angleFormat();
856 mEmulatedAlphaAttachmentMask.set(
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400857 colorIndexGL, sourceFormat.alphaBits == 0 && emulatedFormat.alphaBits > 0);
Luc Ferron0bb940a2018-06-22 09:59:34 -0400858
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500859 contextVk->updateColorMask(context->getState().getBlendState());
Jamie Madill9aef3672018-04-27 11:45:06 -0400860 }
861 else
862 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400863 updateActiveColorMasks(colorIndexGL, false, false, false, false);
Jamie Madill9aef3672018-04-27 11:45:06 -0400864 }
Jamie Madill57d9cbb2018-04-27 11:45:04 -0400865 break;
866 }
867 }
868 }
Jamie Madill66546be2018-03-08 09:47:20 -0500869
Jamie Madill9aef3672018-04-27 11:45:06 -0400870 mActiveColorComponents = gl_vk::GetColorComponentFlags(
Luc Ferron5fd36932018-06-19 14:55:50 -0400871 mActiveColorComponentMasksForClear[0].any(), mActiveColorComponentMasksForClear[1].any(),
872 mActiveColorComponentMasksForClear[2].any(), mActiveColorComponentMasksForClear[3].any());
Jamie Madill9aef3672018-04-27 11:45:06 -0400873
Jamie Madille8dd0792018-09-27 15:04:27 -0400874 mFramebuffer.release(renderer);
Jamie Madill49ac74b2017-12-21 14:42:33 -0500875
Jamie Madill316c6062018-05-29 10:49:45 -0400876 // Will freeze the current set of dependencies on this FBO. The next time we render we will
Jamie Madilla5e06072018-05-18 14:36:05 -0400877 // create a new entry in the command graph.
Jamie Madille8dd0792018-09-27 15:04:27 -0400878 mFramebuffer.finishCurrentCommands(renderer);
Jamie Madill72106562017-03-24 14:18:50 -0400879
Jamie Madilldbc605c2019-01-04 16:39:14 -0500880 // Notify the ContextVk to update the pipeline desc.
881 updateRenderPassDesc();
882 contextVk->onFramebufferChange(mRenderPassDesc);
Jamie Madill19fa1c62018-03-08 09:47:21 -0500883
Jamie Madill7c985f52018-11-29 18:16:17 -0500884 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500885}
886
Jamie Madilldbc605c2019-01-04 16:39:14 -0500887void FramebufferVk::updateRenderPassDesc()
Jamie Madillab9f9c32017-01-17 17:47:34 -0500888{
Jamie Madilldbc605c2019-01-04 16:39:14 -0500889 mRenderPassDesc = {};
890 mRenderPassDesc.setSamples(getSamples());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500891
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400892 const auto &colorRenderTargets = mRenderTargetCache.getColors();
893 const gl::DrawBufferMask enabledDrawBuffers = mState.getEnabledDrawBuffers();
894 for (size_t colorIndexGL = 0; colorIndexGL < enabledDrawBuffers.size(); ++colorIndexGL)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500895 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400896 if (enabledDrawBuffers[colorIndexGL])
897 {
898 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
899 ASSERT(colorRenderTarget);
900 mRenderPassDesc.packColorAttachment(
901 colorIndexGL, colorRenderTarget->getImage().getFormat().angleFormatID);
902 }
903 else
904 {
905 mRenderPassDesc.packColorAttachmentGap(colorIndexGL);
906 }
Jamie Madillab9f9c32017-01-17 17:47:34 -0500907 }
908
Jamie Madill66546be2018-03-08 09:47:20 -0500909 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
910 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500911 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400912 mRenderPassDesc.packDepthStencilAttachment(
913 depthStencilRenderTarget->getImage().getFormat().angleFormatID);
Jamie Madillab9f9c32017-01-17 17:47:34 -0500914 }
Jamie Madillab9f9c32017-01-17 17:47:34 -0500915}
916
Jamie Madill21061022018-07-12 23:56:30 -0400917angle::Result FramebufferVk::getFramebuffer(ContextVk *contextVk, vk::Framebuffer **framebufferOut)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500918{
919 // If we've already created our cached Framebuffer, return it.
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400920 if (mFramebuffer.valid())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500921 {
Jamie Madille8dd0792018-09-27 15:04:27 -0400922 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -0500923 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500924 }
925
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400926 vk::RenderPass *compatibleRenderPass = nullptr;
927 ANGLE_TRY(contextVk->getRenderer()->getCompatibleRenderPass(contextVk, mRenderPassDesc,
928 &compatibleRenderPass));
Jamie Madillab9f9c32017-01-17 17:47:34 -0500929
930 // If we've a Framebuffer provided by a Surface (default FBO/backbuffer), query it.
931 if (mBackbuffer)
932 {
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400933 return mBackbuffer->getCurrentFramebuffer(contextVk, *compatibleRenderPass, framebufferOut);
Jamie Madillab9f9c32017-01-17 17:47:34 -0500934 }
935
936 // Gather VkImageViews over all FBO attachments, also size of attached region.
937 std::vector<VkImageView> attachments;
938 gl::Extents attachmentsSize;
939
Jamie Madill66546be2018-03-08 09:47:20 -0500940 const auto &colorRenderTargets = mRenderTargetCache.getColors();
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400941 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500942 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400943 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
Jamie Madill66546be2018-03-08 09:47:20 -0500944 ASSERT(colorRenderTarget);
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +0100945 attachments.push_back(colorRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500946
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400947 ASSERT(attachmentsSize.empty() || attachmentsSize == colorRenderTarget->getExtents());
948 attachmentsSize = colorRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500949 }
950
Jamie Madill66546be2018-03-08 09:47:20 -0500951 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
952 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500953 {
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +0100954 attachments.push_back(depthStencilRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500955
Jamie Madillbc543422018-03-30 10:43:19 -0400956 ASSERT(attachmentsSize.empty() ||
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400957 attachmentsSize == depthStencilRenderTarget->getExtents());
958 attachmentsSize = depthStencilRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500959 }
960
Shahbaz Youssefi06270c92018-10-03 17:00:25 -0400961 VkFramebufferCreateInfo framebufferInfo = {};
Jamie Madillab9f9c32017-01-17 17:47:34 -0500962
963 framebufferInfo.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500964 framebufferInfo.flags = 0;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400965 framebufferInfo.renderPass = compatibleRenderPass->getHandle();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500966 framebufferInfo.attachmentCount = static_cast<uint32_t>(attachments.size());
967 framebufferInfo.pAttachments = attachments.data();
968 framebufferInfo.width = static_cast<uint32_t>(attachmentsSize.width);
969 framebufferInfo.height = static_cast<uint32_t>(attachmentsSize.height);
970 framebufferInfo.layers = 1;
971
Jamie Madill21061022018-07-12 23:56:30 -0400972 ANGLE_TRY(mFramebuffer.init(contextVk, framebufferInfo));
Jamie Madill5deea722017-02-16 10:44:46 -0500973
Jamie Madille8dd0792018-09-27 15:04:27 -0400974 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -0500975 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400976}
977
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400978angle::Result FramebufferVk::clearWithRenderPassOp(
979 ContextVk *contextVk,
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400980 const gl::Rectangle &clearArea,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400981 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400982 bool clearDepth,
983 bool clearStencil,
984 const VkClearColorValue &clearColorValue,
985 const VkClearDepthStencilValue &clearDepthStencilValue)
986{
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400987 // Start a new render pass if:
988 //
989 // - no render pass has started,
990 // - there is a render pass started but it contains commands; we cannot modify its ops, so new
991 // render pass is needed,
992 // - the current render area doesn't match the clear area. We need the render area to be
993 // exactly as specified by the scissor for the loadOp to clear only that area. See
994 // onScissorChange for more information.
995
996 if (!mFramebuffer.valid() || !mFramebuffer.renderPassStartedButEmpty() ||
997 mFramebuffer.getRenderPassRenderArea() != clearArea)
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400998 {
999 vk::CommandBuffer *commandBuffer;
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001000 ANGLE_TRY(startNewRenderPass(contextVk, clearArea, &commandBuffer));
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001001 }
1002
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001003 size_t attachmentIndexVk = 0;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001004
1005 // Go through clearColorBuffers and set the appropriate loadOp and clear values.
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001006 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001007 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001008 if (clearColorBuffers.test(colorIndexGL))
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001009 {
1010 RenderTargetVk *renderTarget = getColorReadRenderTarget();
1011
1012 // If the render target doesn't have alpha, but its emulated format has it, clear the
1013 // alpha to 1.
1014 VkClearColorValue value = clearColorValue;
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001015 if (mEmulatedAlphaAttachmentMask[colorIndexGL])
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001016 {
1017 SetEmulatedAlphaValue(renderTarget->getImageFormat(), &value);
1018 }
1019
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001020 mFramebuffer.clearRenderPassColorAttachment(attachmentIndexVk, value);
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001021 }
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001022 ++attachmentIndexVk;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001023 }
1024
1025 // Set the appropriate loadOp and clear values for depth and stencil.
1026 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1027 if (depthStencilRenderTarget)
1028 {
1029 if (clearDepth)
1030 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001031 mFramebuffer.clearRenderPassDepthAttachment(attachmentIndexVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001032 clearDepthStencilValue.depth);
1033 }
1034
1035 if (clearStencil)
1036 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001037 mFramebuffer.clearRenderPassStencilAttachment(attachmentIndexVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001038 clearDepthStencilValue.stencil);
1039 }
1040 }
1041
1042 return angle::Result::Continue;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001043}
1044
Jamie Madill21061022018-07-12 23:56:30 -04001045angle::Result FramebufferVk::clearWithDraw(ContextVk *contextVk,
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001046 const gl::Rectangle &clearArea,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001047 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001048 bool clearStencil,
1049 VkColorComponentFlags colorMaskFlags,
1050 uint8_t stencilMask,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001051 const VkClearColorValue &clearColorValue,
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001052 uint8_t clearStencilValue)
Jamie Madill9aef3672018-04-27 11:45:06 -04001053{
Jamie Madilldc65c5b2018-11-21 11:07:26 -05001054 RendererVk *renderer = contextVk->getRenderer();
1055
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001056 UtilsVk::ClearFramebufferParameters params = {};
1057 params.renderPassDesc = &getRenderPassDesc();
1058 params.renderAreaHeight = mState.getDimensions().height;
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001059 params.clearArea = clearArea;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001060 params.colorClearValue = clearColorValue;
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001061 params.stencilClearValue = clearStencilValue;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001062 params.stencilMask = stencilMask;
1063
1064 params.clearColor = true;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001065 params.clearStencil = clearStencil;
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001066
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001067 const auto &colorRenderTargets = mRenderTargetCache.getColors();
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001068 for (size_t colorIndexGL : clearColorBuffers)
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001069 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001070 const RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001071 ASSERT(colorRenderTarget);
1072
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001073 params.colorFormat = &colorRenderTarget->getImage().getFormat().imageFormat();
1074 params.colorAttachmentIndexGL = colorIndexGL;
1075 params.colorMaskFlags = colorMaskFlags;
1076 if (mEmulatedAlphaAttachmentMask[colorIndexGL])
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001077 {
1078 params.colorMaskFlags &= ~VK_COLOR_COMPONENT_A_BIT;
1079 }
1080
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001081 ANGLE_TRY(renderer->getUtils().clearFramebuffer(contextVk, this, params));
1082
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001083 // Clear stencil only once!
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001084 params.clearStencil = false;
1085 }
1086
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001087 // If there was no color clear, clear stencil alone.
1088 if (params.clearStencil)
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001089 {
1090 params.clearColor = false;
1091 ANGLE_TRY(renderer->getUtils().clearFramebuffer(contextVk, this, params));
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001092 }
1093
1094 return angle::Result::Continue;
Jamie Madill9aef3672018-04-27 11:45:06 -04001095}
1096
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001097angle::Result FramebufferVk::getSamplePosition(const gl::Context *context,
1098 size_t index,
1099 GLfloat *xy) const
JiangYizhoubddc46b2016-12-09 09:50:51 +08001100{
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001101 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -05001102 return angle::Result::Stop;
JiangYizhoubddc46b2016-12-09 09:50:51 +08001103}
1104
Jamie Madilld1249de2018-08-28 16:58:53 -04001105angle::Result FramebufferVk::startNewRenderPass(ContextVk *contextVk,
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001106 const gl::Rectangle &renderArea,
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001107 vk::CommandBuffer **commandBufferOut)
Jamie Madilld1249de2018-08-28 16:58:53 -04001108{
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001109 vk::Framebuffer *framebuffer = nullptr;
Jamie Madill21061022018-07-12 23:56:30 -04001110 ANGLE_TRY(getFramebuffer(contextVk, &framebuffer));
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001111
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001112 vk::AttachmentOpsArray renderPassAttachmentOps;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001113 std::vector<VkClearValue> attachmentClearValues;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001114
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001115 vk::CommandBuffer *writeCommands = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001116 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &writeCommands));
Jamie Madille4c5a232018-03-02 21:00:31 -05001117
Jamie Madill49ac74b2017-12-21 14:42:33 -05001118 // Initialize RenderPass info.
Jamie Madill66546be2018-03-08 09:47:20 -05001119 const auto &colorRenderTargets = mRenderTargetCache.getColors();
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001120 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Jamie Madill4c26fc22017-02-24 11:04:10 -05001121 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001122 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
Jamie Madill66546be2018-03-08 09:47:20 -05001123 ASSERT(colorRenderTarget);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001124
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001125 ANGLE_TRY(colorRenderTarget->onColorDraw(contextVk, &mFramebuffer, writeCommands));
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001126
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001127 renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(),
1128 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
1129 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL);
1130 attachmentClearValues.emplace_back(kUninitializedClearValue);
Jamie Madill66546be2018-03-08 09:47:20 -05001131 }
1132
1133 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1134 if (depthStencilRenderTarget)
1135 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001136 ANGLE_TRY(
1137 depthStencilRenderTarget->onDepthStencilDraw(contextVk, &mFramebuffer, writeCommands));
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001138
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001139 renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(),
1140 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL,
1141 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
1142 attachmentClearValues.emplace_back(kUninitializedClearValue);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001143 }
1144
Jamie Madilldbc605c2019-01-04 16:39:14 -05001145 return mFramebuffer.beginRenderPass(contextVk, *framebuffer, renderArea, mRenderPassDesc,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001146 renderPassAttachmentOps, attachmentClearValues,
1147 commandBufferOut);
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001148}
1149
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001150void FramebufferVk::updateActiveColorMasks(size_t colorIndexGL, bool r, bool g, bool b, bool a)
Jamie Madill9aef3672018-04-27 11:45:06 -04001151{
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001152 mActiveColorComponentMasksForClear[0].set(colorIndexGL, r);
1153 mActiveColorComponentMasksForClear[1].set(colorIndexGL, g);
1154 mActiveColorComponentMasksForClear[2].set(colorIndexGL, b);
1155 mActiveColorComponentMasksForClear[3].set(colorIndexGL, a);
Luc Ferron5fd36932018-06-19 14:55:50 -04001156}
1157
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001158const gl::DrawBufferMask &FramebufferVk::getEmulatedAlphaAttachmentMask() const
Luc Ferron5fd36932018-06-19 14:55:50 -04001159{
1160 return mEmulatedAlphaAttachmentMask;
Jamie Madill9aef3672018-04-27 11:45:06 -04001161}
Luc Ferron018709f2018-05-10 13:53:11 -04001162
Jamie Madill21061022018-07-12 23:56:30 -04001163angle::Result FramebufferVk::readPixelsImpl(ContextVk *contextVk,
1164 const gl::Rectangle &area,
1165 const PackPixelsParams &packPixelsParams,
Jamie Madillb436aac2018-07-18 17:23:48 -04001166 VkImageAspectFlagBits copyAspectFlags,
Jamie Madill21061022018-07-12 23:56:30 -04001167 RenderTargetVk *renderTarget,
1168 void *pixels)
Luc Ferron018709f2018-05-10 13:53:11 -04001169{
Tobin Ehlis4a419142019-02-05 08:50:30 -07001170 TRACE_EVENT0("gpu.angle", "FramebufferVk::readPixelsImpl");
Jamie Madill58675012018-05-22 14:54:07 -04001171
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001172 RendererVk *renderer = contextVk->getRenderer();
1173
Shahbaz Youssefi29b49412019-01-07 14:03:06 -05001174 ANGLE_TRY(renderTarget->ensureImageInitialized(contextVk));
1175
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001176 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001177 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Jamie Madill58675012018-05-22 14:54:07 -04001178
Jamie Madillbcf467f2018-05-23 09:46:00 -04001179 // Note that although we're reading from the image, we need to update the layout below.
Luc Ferron1617e692018-07-11 11:08:19 -04001180
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -05001181 vk::ImageHelper *srcImage =
1182 renderTarget->getImageForRead(&mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Jamie Madillbcf467f2018-05-23 09:46:00 -04001183
Jamie Madill0631e192019-04-18 16:09:12 -04001184 const angle::Format *readFormat = &srcImage->getFormat().imageFormat();
Luc Ferron1617e692018-07-11 11:08:19 -04001185
Jamie Madillb436aac2018-07-18 17:23:48 -04001186 if (copyAspectFlags != VK_IMAGE_ASPECT_COLOR_BIT)
Luc Ferron1617e692018-07-11 11:08:19 -04001187 {
Jamie Madillb436aac2018-07-18 17:23:48 -04001188 readFormat = &GetDepthStencilImageToBufferFormat(*readFormat, copyAspectFlags);
Luc Ferron1617e692018-07-11 11:08:19 -04001189 }
1190
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001191 size_t level = renderTarget->getLevelIndex();
1192 size_t layer = renderTarget->getLayerIndex();
1193 VkOffset3D srcOffset = {area.x, area.y, 0};
1194 VkExtent3D srcExtent = {static_cast<uint32_t>(area.width), static_cast<uint32_t>(area.height),
1195 1};
1196
1197 // If the source image is multisampled, we need to resolve it into a temporary image before
1198 // performing a readback.
1199 bool isMultisampled = srcImage->getSamples() > 1;
1200 vk::Scoped<vk::ImageHelper> resolvedImage(contextVk->getDevice());
1201 if (isMultisampled)
1202 {
1203 ANGLE_TRY(resolvedImage.get().init2DStaging(
1204 contextVk, renderer->getMemoryProperties(), gl::Extents(area.width, area.height, 1),
1205 srcImage->getFormat(),
1206 VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT, 1));
1207 resolvedImage.get().updateQueueSerial(renderer->getCurrentQueueSerial());
1208
1209 // TODO(syoussefi): resolve only works on color images (not depth/stencil). If readback
1210 // on multisampled depth/stencil image is done, we would need a different path. One
1211 // possible solution would be a compute shader that directly reads from the multisampled
1212 // image, performs the resolve and outputs to the buffer in one go.
1213 // http://anglebug.com/3200
1214 ASSERT(copyAspectFlags == VK_IMAGE_ASPECT_COLOR_BIT);
1215
1216 VkImageResolve resolveRegion = {};
1217 resolveRegion.srcSubresource.aspectMask = copyAspectFlags;
1218 resolveRegion.srcSubresource.mipLevel = level;
1219 resolveRegion.srcSubresource.baseArrayLayer = layer;
1220 resolveRegion.srcSubresource.layerCount = 1;
1221 resolveRegion.srcOffset = srcOffset;
1222 resolveRegion.dstSubresource.aspectMask = copyAspectFlags;
1223 resolveRegion.dstSubresource.mipLevel = 0;
1224 resolveRegion.dstSubresource.baseArrayLayer = 0;
1225 resolveRegion.dstSubresource.layerCount = 1;
1226 resolveRegion.dstOffset = {};
1227 resolveRegion.extent = srcExtent;
1228
1229 srcImage->resolve(&resolvedImage.get(), resolveRegion, commandBuffer);
1230
1231 resolvedImage.get().changeLayout(copyAspectFlags, vk::ImageLayout::TransferSrc,
1232 commandBuffer);
1233
1234 // Make the resolved image the target of buffer copy.
1235 srcImage = &resolvedImage.get();
1236 level = 0;
1237 layer = 0;
1238 srcOffset = {0, 0, 0};
1239 }
1240
Jamie Madillb980c562018-11-27 11:34:27 -05001241 VkBuffer bufferHandle = VK_NULL_HANDLE;
1242 uint8_t *readPixelBuffer = nullptr;
Jamie Madill4c310832018-08-29 13:43:17 -04001243 VkDeviceSize stagingOffset = 0;
Jamie Madillb980c562018-11-27 11:34:27 -05001244 size_t allocationSize = readFormat->pixelBytes * area.width * area.height;
Luc Ferron018709f2018-05-10 13:53:11 -04001245
Jamie Madilld754eb52018-07-19 14:55:03 -04001246 ANGLE_TRY(mReadPixelBuffer.allocate(contextVk, allocationSize, &readPixelBuffer, &bufferHandle,
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -05001247 &stagingOffset, nullptr));
Luc Ferron018709f2018-05-10 13:53:11 -04001248
Shahbaz Youssefi06270c92018-10-03 17:00:25 -04001249 VkBufferImageCopy region = {};
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001250 region.bufferImageHeight = srcExtent.height;
Jamie Madill4c310832018-08-29 13:43:17 -04001251 region.bufferOffset = stagingOffset;
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001252 region.bufferRowLength = srcExtent.width;
1253 region.imageExtent = srcExtent;
1254 region.imageOffset = srcOffset;
Luc Ferron1617e692018-07-11 11:08:19 -04001255 region.imageSubresource.aspectMask = copyAspectFlags;
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001256 region.imageSubresource.baseArrayLayer = layer;
Luc Ferron534b00d2018-05-18 08:16:53 -04001257 region.imageSubresource.layerCount = 1;
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001258 region.imageSubresource.mipLevel = level;
Luc Ferron534b00d2018-05-18 08:16:53 -04001259
Jamie Madillbcf467f2018-05-23 09:46:00 -04001260 commandBuffer->copyImageToBuffer(srcImage->getImage(), srcImage->getCurrentLayout(),
1261 bufferHandle, 1, &region);
Luc Ferron018709f2018-05-10 13:53:11 -04001262
1263 // Triggers a full finish.
1264 // TODO(jmadill): Don't block on asynchronous readback.
Geoff Lang892d1802019-03-27 14:21:34 -04001265 ANGLE_TRY(contextVk->finishImpl());
Luc Ferron018709f2018-05-10 13:53:11 -04001266
Luc Ferron534b00d2018-05-18 08:16:53 -04001267 // The buffer we copied to needs to be invalidated before we read from it because its not been
1268 // created with the host coherent bit.
Jamie Madilld754eb52018-07-19 14:55:03 -04001269 ANGLE_TRY(mReadPixelBuffer.invalidate(contextVk));
Yuly Novikov6c6c76c2018-05-17 18:45:06 +00001270
Jamie Madillb436aac2018-07-18 17:23:48 -04001271 PackPixels(packPixelsParams, *readFormat, area.width * readFormat->pixelBytes, readPixelBuffer,
Rafael Cintron05a449a2018-06-20 18:08:04 -07001272 static_cast<uint8_t *>(pixels));
Luc Ferron018709f2018-05-10 13:53:11 -04001273
Jamie Madill7c985f52018-11-29 18:16:17 -05001274 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -04001275}
Jamie Madill58675012018-05-22 14:54:07 -04001276
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001277gl::Extents FramebufferVk::getReadImageExtents() const
Jamie Madill58675012018-05-22 14:54:07 -04001278{
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001279 ASSERT(getColorReadRenderTarget()->getExtents().width == mState.getDimensions().width);
1280 ASSERT(getColorReadRenderTarget()->getExtents().height == mState.getDimensions().height);
1281
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001282 return getColorReadRenderTarget()->getExtents();
Jamie Madill58675012018-05-22 14:54:07 -04001283}
Jamie Madill502d2e22018-11-01 11:06:23 -04001284
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001285gl::Rectangle FramebufferVk::getCompleteRenderArea() const
1286{
1287 return gl::Rectangle(0, 0, mState.getDimensions().width, mState.getDimensions().height);
1288}
1289
1290gl::Rectangle FramebufferVk::getScissoredRenderArea(ContextVk *contextVk) const
1291{
1292 const gl::Rectangle renderArea(0, 0, mState.getDimensions().width,
1293 mState.getDimensions().height);
1294 bool invertViewport = contextVk->isViewportFlipEnabledForDrawFBO();
1295
1296 return ClipRectToScissor(contextVk->getState(), renderArea, invertViewport);
1297}
1298
1299void FramebufferVk::onScissorChange(ContextVk *contextVk)
1300{
1301 gl::Rectangle scissoredRenderArea = getScissoredRenderArea(contextVk);
1302
1303 // If the scissor has grown beyond the previous scissoredRenderArea, make sure the render pass
1304 // is restarted. Otherwise, we can continue using the same renderpass area.
1305 //
1306 // Without a scissor, the render pass area covers the whole of the framebuffer. With a
1307 // scissored clear, the render pass area could be smaller than the framebuffer size. When the
1308 // scissor changes, if the scissor area is completely encompassed by the render pass area, it's
1309 // possible to continue using the same render pass. However, if the current render pass area
1310 // is too small, we need to start a new one. The latter can happen if a scissored clear starts
1311 // a render pass, the scissor is disabled and a draw call is issued to affect the whole
1312 // framebuffer.
1313 mFramebuffer.updateQueueSerial(contextVk->getRenderer()->getCurrentQueueSerial());
1314 if (mFramebuffer.hasStartedRenderPass() &&
1315 !mFramebuffer.getRenderPassRenderArea().encloses(scissoredRenderArea))
1316 {
1317 mFramebuffer.finishCurrentCommands(contextVk->getRenderer());
1318 }
1319}
1320
Jamie Madill502d2e22018-11-01 11:06:23 -04001321RenderTargetVk *FramebufferVk::getFirstRenderTarget() const
1322{
1323 for (auto *renderTarget : mRenderTargetCache.getColors())
1324 {
1325 if (renderTarget)
1326 {
1327 return renderTarget;
1328 }
1329 }
1330
1331 return mRenderTargetCache.getDepthStencil();
1332}
1333
1334GLint FramebufferVk::getSamples() const
1335{
1336 RenderTargetVk *firstRT = getFirstRenderTarget();
1337 return firstRT ? firstRT->getImage().getSamples() : 0;
1338}
1339
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001340} // namespace rx