blob: 23afd1d301547cb214014ba1fe5c6903ba0a5b70 [file] [log] [blame]
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001//
2// Copyright 2016 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6// FramebufferVk.cpp:
7// Implements the class methods for FramebufferVk.
8//
9
10#include "libANGLE/renderer/vulkan/FramebufferVk.h"
11
Jamie Madill7b57b9d2017-01-13 09:33:38 -050012#include <vulkan/vulkan.h>
Jamie Madill231c7f52017-04-26 13:45:37 -040013#include <array>
Jamie Madill7b57b9d2017-01-13 09:33:38 -050014
Jamie Madill9e54b5a2016-05-25 12:57:39 -040015#include "common/debug.h"
Jamie Madillc564c072017-06-01 12:45:42 -040016#include "libANGLE/Context.h"
17#include "libANGLE/Display.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050018#include "libANGLE/formatutils.h"
19#include "libANGLE/renderer/renderer_utils.h"
Jamie Madill1f46bc12018-02-20 16:09:43 -050020#include "libANGLE/renderer/vulkan/CommandGraph.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050021#include "libANGLE/renderer/vulkan/ContextVk.h"
Jamie Madill5deea722017-02-16 10:44:46 -050022#include "libANGLE/renderer/vulkan/DisplayVk.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050023#include "libANGLE/renderer/vulkan/RenderTargetVk.h"
24#include "libANGLE/renderer/vulkan/RendererVk.h"
25#include "libANGLE/renderer/vulkan/SurfaceVk.h"
Jamie Madill3c424b42018-01-19 12:35:09 -050026#include "libANGLE/renderer/vulkan/vk_format_utils.h"
Tobin Ehlis4a419142019-02-05 08:50:30 -070027#include "third_party/trace_event/trace_event.h"
Jamie Madill9e54b5a2016-05-25 12:57:39 -040028
29namespace rx
30{
31
Jamie Madill7b57b9d2017-01-13 09:33:38 -050032namespace
33{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -040034// The value to assign an alpha channel that's emulated. The type is unsigned int, though it will
35// automatically convert to the actual data type.
36constexpr unsigned int kEmulatedAlphaValue = 1;
37
Luc Ferron534b00d2018-05-18 08:16:53 -040038constexpr size_t kMinReadPixelsBufferSize = 128000;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -040039// Clear values are only used when loadOp=Clear is set in clearWithRenderPassOp. When starting a
40// new render pass, the clear value is set to an unlikely value (bright pink) to stand out better
41// in case of a bug.
42constexpr VkClearValue kUninitializedClearValue = {{{0.95, 0.05, 0.95, 0.95}}};
Luc Ferron534b00d2018-05-18 08:16:53 -040043
Jamie Madill66546be2018-03-08 09:47:20 -050044const gl::InternalFormat &GetReadAttachmentInfo(const gl::Context *context,
45 RenderTargetVk *renderTarget)
Jamie Madill7b57b9d2017-01-13 09:33:38 -050046{
Jamie Madillbc543422018-03-30 10:43:19 -040047 GLenum implFormat =
Jamie Madillbcf467f2018-05-23 09:46:00 -040048 renderTarget->getImageFormat().textureFormat().fboImplementationInternalFormat;
Jamie Madill66546be2018-03-08 09:47:20 -050049 return gl::GetSizedInternalFormatInfo(implFormat);
Jamie Madill7b57b9d2017-01-13 09:33:38 -050050}
Luc Ferron26581112018-06-21 09:43:08 -040051
Jamie Madilld754eb52018-07-19 14:55:03 -040052bool ClipToRenderTarget(const gl::Rectangle &area,
53 RenderTargetVk *renderTarget,
54 gl::Rectangle *rectOut)
55{
Shahbaz Youssefi68549402019-03-25 23:30:49 -040056 const gl::Extents renderTargetExtents = renderTarget->getExtents();
Jamie Madilld754eb52018-07-19 14:55:03 -040057 gl::Rectangle renderTargetRect(0, 0, renderTargetExtents.width, renderTargetExtents.height);
58 return ClipRectangle(area, renderTargetRect, rectOut);
59}
60
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050061bool HasSrcAndDstBlitProperties(RendererVk *renderer,
Luc Ferron26581112018-06-21 09:43:08 -040062 RenderTargetVk *srcRenderTarget,
63 RenderTargetVk *dstRenderTarget)
64{
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050065 const VkFormat srcFormat = srcRenderTarget->getImageFormat().vkTextureFormat;
66 const VkFormat dstFormat = dstRenderTarget->getImageFormat().vkTextureFormat;
Luc Ferron26581112018-06-21 09:43:08 -040067
68 // Verifies if the draw and read images have the necessary prerequisites for blitting.
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050069 return renderer->hasTextureFormatFeatureBits(srcFormat, VK_FORMAT_FEATURE_BLIT_SRC_BIT) &&
70 renderer->hasTextureFormatFeatureBits(dstFormat, VK_FORMAT_FEATURE_BLIT_DST_BIT);
Luc Ferron26581112018-06-21 09:43:08 -040071}
Jamie Madillb436aac2018-07-18 17:23:48 -040072
73// Special rules apply to VkBufferImageCopy with depth/stencil. The components are tightly packed
74// into a depth or stencil section of the destination buffer. See the spec:
75// https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkBufferImageCopy.html
76const angle::Format &GetDepthStencilImageToBufferFormat(const angle::Format &imageFormat,
77 VkImageAspectFlagBits copyAspect)
78{
79 if (copyAspect == VK_IMAGE_ASPECT_STENCIL_BIT)
80 {
81 ASSERT(imageFormat.id == angle::FormatID::D24_UNORM_S8_UINT ||
82 imageFormat.id == angle::FormatID::D32_FLOAT_S8X24_UINT ||
83 imageFormat.id == angle::FormatID::S8_UINT);
84 return angle::Format::Get(angle::FormatID::S8_UINT);
85 }
86
87 ASSERT(copyAspect == VK_IMAGE_ASPECT_DEPTH_BIT);
88
89 switch (imageFormat.id)
90 {
91 case angle::FormatID::D16_UNORM:
92 return imageFormat;
93 case angle::FormatID::D24_UNORM_X8_UINT:
94 return imageFormat;
95 case angle::FormatID::D24_UNORM_S8_UINT:
96 return angle::Format::Get(angle::FormatID::D24_UNORM_X8_UINT);
97 case angle::FormatID::D32_FLOAT:
98 return imageFormat;
99 case angle::FormatID::D32_FLOAT_S8X24_UINT:
100 return angle::Format::Get(angle::FormatID::D32_FLOAT);
101 default:
102 UNREACHABLE();
103 return imageFormat;
104 }
105}
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400106
107void SetEmulatedAlphaValue(const vk::Format &format, VkClearColorValue *value)
108{
109 if (format.vkFormatIsInt)
110 {
111 if (format.vkFormatIsUnsigned)
112 {
113 value->uint32[3] = kEmulatedAlphaValue;
114 }
115 else
116 {
117 value->int32[3] = kEmulatedAlphaValue;
118 }
119 }
120 else
121 {
122 value->float32[3] = kEmulatedAlphaValue;
123 }
124}
Jamie Madillbcf467f2018-05-23 09:46:00 -0400125} // anonymous namespace
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500126
127// static
Jamie Madill639bc902018-07-18 17:08:27 -0400128FramebufferVk *FramebufferVk::CreateUserFBO(RendererVk *renderer, const gl::FramebufferState &state)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500129{
Jamie Madill639bc902018-07-18 17:08:27 -0400130 return new FramebufferVk(renderer, state, nullptr);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500131}
132
133// static
Jamie Madill639bc902018-07-18 17:08:27 -0400134FramebufferVk *FramebufferVk::CreateDefaultFBO(RendererVk *renderer,
135 const gl::FramebufferState &state,
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500136 WindowSurfaceVk *backbuffer)
137{
Jamie Madill639bc902018-07-18 17:08:27 -0400138 return new FramebufferVk(renderer, state, backbuffer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500139}
140
Jamie Madill639bc902018-07-18 17:08:27 -0400141FramebufferVk::FramebufferVk(RendererVk *renderer,
142 const gl::FramebufferState &state,
143 WindowSurfaceVk *backbuffer)
Jamie Madill9aef3672018-04-27 11:45:06 -0400144 : FramebufferImpl(state),
145 mBackbuffer(backbuffer),
Jamie Madill9aef3672018-04-27 11:45:06 -0400146 mActiveColorComponents(0),
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -0500147 mReadPixelBuffer(VK_BUFFER_USAGE_TRANSFER_DST_BIT, kMinReadPixelsBufferSize, true),
148 mBlitPixelBuffer(VK_BUFFER_USAGE_TRANSFER_SRC_BIT, kMinReadPixelsBufferSize, true)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500149{
Jamie Madill639bc902018-07-18 17:08:27 -0400150 mBlitPixelBuffer.init(1, renderer);
Frank Henigman49b0f6e2018-10-03 23:15:29 -0400151 mReadPixelBuffer.init(4, renderer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500152}
153
Jamie Madill58675012018-05-22 14:54:07 -0400154FramebufferVk::~FramebufferVk() = default;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400155
Jamie Madillc564c072017-06-01 12:45:42 -0400156void FramebufferVk::destroy(const gl::Context *context)
Jamie Madill5deea722017-02-16 10:44:46 -0500157{
Luc Ferron534b00d2018-05-18 08:16:53 -0400158 ContextVk *contextVk = vk::GetImpl(context);
159 RendererVk *renderer = contextVk->getRenderer();
Jamie Madille8dd0792018-09-27 15:04:27 -0400160 mFramebuffer.release(renderer);
Luc Ferron534b00d2018-05-18 08:16:53 -0400161
Shahbaz Youssefifca8fd62018-11-13 13:55:48 -0500162 mReadPixelBuffer.release(renderer);
163 mBlitPixelBuffer.release(renderer);
Jamie Madill5deea722017-02-16 10:44:46 -0500164}
165
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400166angle::Result FramebufferVk::discard(const gl::Context *context,
167 size_t count,
168 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400169{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400170 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500171 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400172}
173
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400174angle::Result FramebufferVk::invalidate(const gl::Context *context,
175 size_t count,
176 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400177{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400178 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500179 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400180}
181
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400182angle::Result FramebufferVk::invalidateSub(const gl::Context *context,
183 size_t count,
184 const GLenum *attachments,
185 const gl::Rectangle &area)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400186{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400187 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500188 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400189}
190
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400191angle::Result FramebufferVk::clear(const gl::Context *context, GLbitfield mask)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400192{
Jamie Madill0cec82a2018-03-14 09:21:07 -0400193 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500194
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400195 bool clearColor = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_COLOR_BUFFER_BIT));
196 bool clearDepth = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_DEPTH_BUFFER_BIT));
197 bool clearStencil = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_STENCIL_BUFFER_BIT));
198 gl::DrawBufferMask clearColorBuffers;
199 if (clearColor)
200 {
201 clearColorBuffers = mState.getEnabledDrawBuffers();
202 }
203
204 const VkClearColorValue &clearColorValue = contextVk->getClearColorValue().color;
205 const VkClearDepthStencilValue &clearDepthStencilValue =
206 contextVk->getClearDepthStencilValue().depthStencil;
207
208 return clearImpl(context, clearColorBuffers, clearDepth, clearStencil, clearColorValue,
209 clearDepthStencilValue);
210}
211
212angle::Result FramebufferVk::clearImpl(const gl::Context *context,
213 gl::DrawBufferMask clearColorBuffers,
214 bool clearDepth,
215 bool clearStencil,
216 const VkClearColorValue &clearColorValue,
217 const VkClearDepthStencilValue &clearDepthStencilValue)
218{
219 ContextVk *contextVk = vk::GetImpl(context);
220
221 const gl::State &glState = context->getState();
222 const gl::Rectangle &scissor = glState.getScissor();
223 const gl::Rectangle renderArea(0, 0, mState.getDimensions().width,
224 mState.getDimensions().height);
225 gl::Rectangle scissorRenderAreaIntersection;
226 // Discard clear altogether if scissor has 0 width or height.
227 if (glState.isScissorTestEnabled() &&
228 !gl::ClipRectangle(scissor, renderArea, &scissorRenderAreaIntersection))
229 {
230 return angle::Result::Continue;
231 }
232
233 mFramebuffer.updateQueueSerial(contextVk->getRenderer()->getCurrentQueueSerial());
234
235 // This function assumes that only enabled attachments are asked to be cleared.
236 ASSERT((clearColorBuffers & mState.getEnabledDrawBuffers()) == clearColorBuffers);
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400237
238 // Adjust clear behavior based on whether:
239 //
240 // - the respective attachments are present: if asked to clear a non-existent attachment, don't
241 // attempt to clear it.
242 // - extra clear is necessary: if depth- or stencil-only attachments are emulated with a format
243 // that has both aspects, clear the emulated aspect.
244
245 VkColorComponentFlags colorMaskFlags = contextVk->getClearColorMask();
246 bool clearColor = clearColorBuffers.any();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400247
Jamie Madill0cec82a2018-03-14 09:21:07 -0400248 const gl::FramebufferAttachment *depthAttachment = mState.getDepthAttachment();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400249 clearDepth = clearDepth && depthAttachment;
Jamie Madill0cec82a2018-03-14 09:21:07 -0400250 ASSERT(!clearDepth || depthAttachment->isAttached());
251
252 const gl::FramebufferAttachment *stencilAttachment = mState.getStencilAttachment();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400253 clearStencil = clearStencil && stencilAttachment;
Jamie Madill0cec82a2018-03-14 09:21:07 -0400254 ASSERT(!clearStencil || stencilAttachment->isAttached());
255
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400256 uint8_t stencilMask =
257 static_cast<uint8_t>(contextVk->getState().getDepthStencilState().stencilWritemask);
258
259 // The front-end should ensure we don't attempt to clear color if all channels are masked.
260 ASSERT(!clearColor || colorMaskFlags != 0);
261 // The front-end should ensure we don't attempt to clear depth if depth write is disabled.
262 ASSERT(!clearDepth || contextVk->getState().getDepthStencilState().depthMask);
263 // The front-end should ensure we don't attempt to clear stencil if all bits are masked.
264 ASSERT(!clearStencil || stencilMask != 0);
265
266 // If there is nothing to clear, return right away (for example, if asked to clear depth, but
267 // there is no depth attachment).
Shahbaz Youssefi02a579e2019-03-27 14:21:20 -0400268 if (!clearColor && !clearDepth && !clearStencil)
269 {
270 return angle::Result::Continue;
271 }
272
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400273 VkClearDepthStencilValue modifiedDepthStencilValue = clearDepthStencilValue;
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400274
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400275 // If the depth or stencil is being cleared, and the image was originally requested to have a
276 // single aspect, but it's emulated with a depth/stencil format, clear both aspects, setting the
277 // other aspect to 0.
278 if (clearStencil || clearDepth)
279 {
280 RenderTargetVk *depthStencil = mRenderTargetCache.getDepthStencil();
281 const vk::Format &format = depthStencil->getImageFormat();
282
283 // GL_DEPTH_COMPONENT24 is always emulated with a format that has stencil.
284 if (format.angleFormat().stencilBits == 0)
285 {
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400286 clearStencil = true;
287 modifiedDepthStencilValue.stencil = 0;
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400288 }
289 // GL_STENCIL_INDEX8 may or may not be emulated.
290 else if (format.angleFormat().depthBits == 0 && format.vkTextureFormat != VK_FORMAT_S8_UINT)
291 {
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400292 clearDepth = true;
293 modifiedDepthStencilValue.depth = 0;
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400294 }
295 }
Luc Ferron8836f632018-04-05 07:26:53 -0400296
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400297 // If scissor is enabled, but covers the whole of framebuffer, it can be considered disabled for
298 // the sake of clear.
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400299 bool isScissorTestEffectivelyEnabled =
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400300 glState.isScissorTestEnabled() && scissorRenderAreaIntersection != renderArea;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400301
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400302 // We can use render pass load ops if clearing depth, unmasked color or unmasked stencil. If
303 // there's a depth mask, depth clearing is already disabled.
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400304 bool maskedClearColor =
305 clearColor && (mActiveColorComponents & colorMaskFlags) != mActiveColorComponents;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400306 bool maskedClearStencil = stencilMask != 0xFF;
307
308 bool clearColorWithRenderPassLoadOp = clearColor && !maskedClearColor;
309 bool clearStencilWithRenderPassLoadOp = clearStencil && !maskedClearStencil;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400310
311 // At least one of color, depth or stencil should be clearable with render pass loadOp for us
312 // to use this clear path.
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400313 bool clearAnyWithRenderPassLoadOp =
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400314 clearColorWithRenderPassLoadOp || clearDepth || clearStencilWithRenderPassLoadOp;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400315
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400316 if (clearAnyWithRenderPassLoadOp && !isScissorTestEffectivelyEnabled)
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400317 {
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400318 // Clearing color is indicated by the set bits in this mask. If not clearing colors with
319 // render pass loadOp, the default value of all-zeros means the clear is not done in
320 // clearWithRenderPassOp below.
321 gl::DrawBufferMask clearBuffersWithRenderPassLoadOp;
322 if (clearColorWithRenderPassLoadOp)
323 {
324 clearBuffersWithRenderPassLoadOp = clearColorBuffers;
325 }
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400326 // If there's a color mask, only clear depth/stencil with render pass loadOp.
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400327 ANGLE_TRY(clearWithRenderPassOp(contextVk, clearBuffersWithRenderPassLoadOp, clearDepth,
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400328 clearStencilWithRenderPassLoadOp, clearColorValue,
329 modifiedDepthStencilValue));
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400330
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400331 // On some hardware, having inline commands at this point results in corrupted output. In
332 // that case, end the render pass immediately. http://anglebug.com/2361
333 if (contextVk->getRenderer()->getFeatures().restartRenderPassAfterLoadOpClear)
334 {
335 mFramebuffer.finishCurrentCommands(contextVk->getRenderer());
336 }
337
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400338 // Fallback to other methods for whatever isn't cleared here.
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400339 clearDepth = false;
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400340 if (clearColorWithRenderPassLoadOp)
341 {
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400342 clearColorBuffers.reset();
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400343 clearColor = false;
344 }
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400345 if (clearStencilWithRenderPassLoadOp)
346 {
347 clearStencil = false;
348 }
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400349
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400350 // If nothing left to clear, early out.
351 if (!clearColor && !clearStencil)
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400352 {
353 return angle::Result::Continue;
354 }
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400355 }
356
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400357 // The most costly clear mode is when we need to mask out specific color channels or stencil
358 // bits. This can only be done with a draw call. The scissor region however can easily be
359 // integrated with this method.
360 //
361 // Since we have to have a draw call for the sake of masked color or stencil, we can make sure
362 // everything else is cleared with the draw call at the same time as well.
363 if (maskedClearColor || maskedClearStencil)
Jamie Madill9aef3672018-04-27 11:45:06 -0400364 {
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400365 return clearWithDraw(contextVk, clearColorBuffers, clearDepth, clearStencil, colorMaskFlags,
366 stencilMask, clearColorValue, modifiedDepthStencilValue);
Jamie Madill9aef3672018-04-27 11:45:06 -0400367 }
368
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400369 ASSERT(isScissorTestEffectivelyEnabled);
Luc Ferrona8af3a62018-03-29 14:44:24 -0400370
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400371 // With scissor test enabled, we clear very differently and we don't need to access
372 // the image inside each attachment we can just use clearCmdAttachments with our
373 // scissor region instead.
374 return clearWithClearAttachments(contextVk, clearColorBuffers, clearDepth, clearStencil,
375 clearColorValue, modifiedDepthStencilValue);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400376}
377
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400378angle::Result FramebufferVk::clearBufferfv(const gl::Context *context,
379 GLenum buffer,
380 GLint drawbuffer,
381 const GLfloat *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400382{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400383 VkClearValue clearValue;
384
385 bool clearDepth = false;
386 gl::DrawBufferMask clearColorBuffers;
387
388 if (buffer == GL_DEPTH)
389 {
390 clearDepth = true;
391 clearValue.depthStencil.depth = values[0];
392 }
393 else
394 {
395 clearColorBuffers.set(drawbuffer);
396 clearValue.color.float32[0] = values[0];
397 clearValue.color.float32[1] = values[1];
398 clearValue.color.float32[2] = values[2];
399 clearValue.color.float32[3] = values[3];
400 }
401
402 return clearImpl(context, clearColorBuffers, clearDepth, false, clearValue.color,
403 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400404}
405
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400406angle::Result FramebufferVk::clearBufferuiv(const gl::Context *context,
407 GLenum buffer,
408 GLint drawbuffer,
409 const GLuint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400410{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400411 VkClearValue clearValue;
412
413 gl::DrawBufferMask clearColorBuffers;
414 clearColorBuffers.set(drawbuffer);
415
416 clearValue.color.uint32[0] = values[0];
417 clearValue.color.uint32[1] = values[1];
418 clearValue.color.uint32[2] = values[2];
419 clearValue.color.uint32[3] = values[3];
420
421 return clearImpl(context, clearColorBuffers, false, false, clearValue.color,
422 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400423}
424
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400425angle::Result FramebufferVk::clearBufferiv(const gl::Context *context,
426 GLenum buffer,
427 GLint drawbuffer,
428 const GLint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400429{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400430 VkClearValue clearValue;
431
432 bool clearStencil = false;
433 gl::DrawBufferMask clearColorBuffers;
434
435 if (buffer == GL_STENCIL)
436 {
437 clearStencil = true;
438 clearValue.depthStencil.stencil =
439 gl::clamp(values[0], 0, std::numeric_limits<uint8_t>::max());
440 }
441 else
442 {
443 clearColorBuffers.set(drawbuffer);
444 clearValue.color.int32[0] = values[0];
445 clearValue.color.int32[1] = values[1];
446 clearValue.color.int32[2] = values[2];
447 clearValue.color.int32[3] = values[3];
448 }
449
450 return clearImpl(context, clearColorBuffers, false, clearStencil, clearValue.color,
451 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400452}
453
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400454angle::Result FramebufferVk::clearBufferfi(const gl::Context *context,
455 GLenum buffer,
456 GLint drawbuffer,
457 GLfloat depth,
458 GLint stencil)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400459{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400460 VkClearValue clearValue;
461
462 clearValue.depthStencil.depth = depth;
463 clearValue.depthStencil.stencil = gl::clamp(stencil, 0, std::numeric_limits<uint8_t>::max());
464
465 return clearImpl(context, gl::DrawBufferMask(), true, true, clearValue.color,
466 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400467}
468
Jamie Madill4928b7c2017-06-20 12:57:39 -0400469GLenum FramebufferVk::getImplementationColorReadFormat(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400470{
Jamie Madill66546be2018-03-08 09:47:20 -0500471 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).format;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400472}
473
Jamie Madill4928b7c2017-06-20 12:57:39 -0400474GLenum FramebufferVk::getImplementationColorReadType(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400475{
Jamie Madill66546be2018-03-08 09:47:20 -0500476 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).type;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400477}
478
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400479angle::Result FramebufferVk::readPixels(const gl::Context *context,
480 const gl::Rectangle &area,
481 GLenum format,
482 GLenum type,
483 void *pixels)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400484{
Luc Ferrona1c72422018-05-14 15:58:28 -0400485 // Clip read area to framebuffer.
486 const gl::Extents &fbSize = getState().getReadAttachment()->getSize();
487 const gl::Rectangle fbRect(0, 0, fbSize.width, fbSize.height);
Luc Ferronbf6dc372018-06-28 15:24:19 -0400488 ContextVk *contextVk = vk::GetImpl(context);
489 RendererVk *renderer = contextVk->getRenderer();
490
Luc Ferrona1c72422018-05-14 15:58:28 -0400491 gl::Rectangle clippedArea;
492 if (!ClipRectangle(area, fbRect, &clippedArea))
493 {
494 // nothing to read
Jamie Madill7c985f52018-11-29 18:16:17 -0500495 return angle::Result::Continue;
Luc Ferrona1c72422018-05-14 15:58:28 -0400496 }
Luc Ferronbf6dc372018-06-28 15:24:19 -0400497 gl::Rectangle flippedArea = clippedArea;
Geoff Lange076a232018-07-16 15:34:05 -0400498 if (contextVk->isViewportFlipEnabledForReadFBO())
Luc Ferronbf6dc372018-06-28 15:24:19 -0400499 {
500 flippedArea.y = fbRect.height - flippedArea.y - flippedArea.height;
501 }
Luc Ferrona1c72422018-05-14 15:58:28 -0400502
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500503 const gl::State &glState = context->getState();
Frank Henigman1ffad842018-09-24 23:40:45 -0400504 const gl::PixelPackState &packState = glState.getPackState();
Luc Ferronbf6dc372018-06-28 15:24:19 -0400505
Luc Ferrona1c72422018-05-14 15:58:28 -0400506 const gl::InternalFormat &sizedFormatInfo = gl::GetInternalFormatInfo(format, type);
507
508 GLuint outputPitch = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400509 ANGLE_VK_CHECK_MATH(contextVk,
510 sizedFormatInfo.computeRowPitch(type, area.width, packState.alignment,
511 packState.rowLength, &outputPitch));
Luc Ferrona1c72422018-05-14 15:58:28 -0400512 GLuint outputSkipBytes = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400513 ANGLE_VK_CHECK_MATH(contextVk, sizedFormatInfo.computeSkipBytes(type, outputPitch, 0, packState,
514 false, &outputSkipBytes));
Luc Ferrona1c72422018-05-14 15:58:28 -0400515
516 outputSkipBytes += (clippedArea.x - area.x) * sizedFormatInfo.pixelBytes +
517 (clippedArea.y - area.y) * outputPitch;
Luc Ferron60284222018-03-20 16:01:44 -0400518
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400519 const angle::Format &angleFormat = GetFormatFromFormatType(format, type);
520
Frank Henigman1ffad842018-09-24 23:40:45 -0400521 PackPixelsParams params(flippedArea, angleFormat, outputPitch, packState.reverseRowOrder,
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400522 glState.getTargetBuffer(gl::BufferBinding::PixelPack), 0);
Frank Henigman1ffad842018-09-24 23:40:45 -0400523 if (contextVk->isViewportFlipEnabledForReadFBO())
524 {
525 params.reverseRowOrder = !params.reverseRowOrder;
526 }
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500527
Jamie Madill21061022018-07-12 23:56:30 -0400528 ANGLE_TRY(readPixelsImpl(contextVk, flippedArea, params, VK_IMAGE_ASPECT_COLOR_BIT,
Luc Ferron1617e692018-07-11 11:08:19 -0400529 getColorReadRenderTarget(),
Rafael Cintron05a449a2018-06-20 18:08:04 -0700530 static_cast<uint8_t *>(pixels) + outputSkipBytes));
Jamie Madilld754eb52018-07-19 14:55:03 -0400531 mReadPixelBuffer.releaseRetainedBuffers(renderer);
Jamie Madill7c985f52018-11-29 18:16:17 -0500532 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -0400533}
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500534
Luc Ferron26581112018-06-21 09:43:08 -0400535RenderTargetVk *FramebufferVk::getDepthStencilRenderTarget() const
536{
537 return mRenderTargetCache.getDepthStencil();
538}
539
Jamie Madill16c20142018-10-01 13:58:19 -0400540angle::Result FramebufferVk::blitWithCopy(ContextVk *contextVk,
541 const gl::Rectangle &copyArea,
542 RenderTargetVk *readRenderTarget,
543 RenderTargetVk *drawRenderTarget,
544 bool blitDepthBuffer,
545 bool blitStencilBuffer)
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400546{
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500547 VkImageAspectFlags aspectMask =
548 vk::GetDepthStencilAspectFlagsForCopy(blitDepthBuffer, blitStencilBuffer);
Jamie Madill16c20142018-10-01 13:58:19 -0400549
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400550 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400551 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
552
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500553 vk::ImageHelper *writeImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
554 writeImage->changeLayout(writeImage->getAspectFlags(), vk::ImageLayout::TransferDst,
555 commandBuffer);
556
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400557 vk::ImageHelper *readImage = readRenderTarget->getImageForRead(
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500558 &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400559
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500560 VkImageSubresourceLayers readSubresource = {};
561 readSubresource.aspectMask = aspectMask;
562 readSubresource.mipLevel = 0;
563 readSubresource.baseArrayLayer = 0;
564 readSubresource.layerCount = 1;
565
566 VkImageSubresourceLayers writeSubresource = readSubresource;
567
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400568 vk::ImageHelper::Copy(readImage, writeImage, gl::Offset(), gl::Offset(),
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500569 gl::Extents(copyArea.width, copyArea.height, 1), readSubresource,
570 writeSubresource, commandBuffer);
Jamie Madill7c985f52018-11-29 18:16:17 -0500571 return angle::Result::Continue;
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400572}
573
Jamie Madill58675012018-05-22 14:54:07 -0400574RenderTargetVk *FramebufferVk::getColorReadRenderTarget() const
Luc Ferron018709f2018-05-10 13:53:11 -0400575{
576 RenderTargetVk *renderTarget = mRenderTargetCache.getColorRead(mState);
Jamie Madillbcf467f2018-05-23 09:46:00 -0400577 ASSERT(renderTarget && renderTarget->getImage().valid());
Luc Ferron018709f2018-05-10 13:53:11 -0400578 return renderTarget;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400579}
580
Jamie Madill21061022018-07-12 23:56:30 -0400581angle::Result FramebufferVk::blitWithReadback(ContextVk *contextVk,
Jamie Madilld754eb52018-07-19 14:55:03 -0400582 const gl::Rectangle &copyArea,
Jamie Madillb436aac2018-07-18 17:23:48 -0400583 VkImageAspectFlagBits aspect,
Jamie Madill21061022018-07-12 23:56:30 -0400584 RenderTargetVk *readRenderTarget,
585 RenderTargetVk *drawRenderTarget)
Luc Ferron1617e692018-07-11 11:08:19 -0400586{
Jamie Madillb436aac2018-07-18 17:23:48 -0400587 RendererVk *renderer = contextVk->getRenderer();
588 const angle::Format &readFormat = readRenderTarget->getImageFormat().textureFormat();
Luc Ferron1617e692018-07-11 11:08:19 -0400589
Jamie Madillb436aac2018-07-18 17:23:48 -0400590 ASSERT(aspect == VK_IMAGE_ASPECT_DEPTH_BIT || aspect == VK_IMAGE_ASPECT_STENCIL_BIT);
Luc Ferron1617e692018-07-11 11:08:19 -0400591
Jamie Madillb436aac2018-07-18 17:23:48 -0400592 // This path is only currently used for y-flipping depth/stencil blits.
Luc Ferron1617e692018-07-11 11:08:19 -0400593 PackPixelsParams packPixelsParams;
Jamie Madillb980c562018-11-27 11:34:27 -0500594 packPixelsParams.reverseRowOrder = true;
595 packPixelsParams.area.width = copyArea.width;
596 packPixelsParams.area.height = copyArea.height;
597 packPixelsParams.area.x = copyArea.x;
598 packPixelsParams.area.y = copyArea.y;
Luc Ferron1617e692018-07-11 11:08:19 -0400599
Jamie Madillb436aac2018-07-18 17:23:48 -0400600 // Read back depth values into the destination buffer.
601 const angle::Format &copyFormat = GetDepthStencilImageToBufferFormat(readFormat, aspect);
602 packPixelsParams.destFormat = &copyFormat;
603 packPixelsParams.outputPitch = copyFormat.pixelBytes * copyArea.width;
Luc Ferron1617e692018-07-11 11:08:19 -0400604
Jamie Madillb436aac2018-07-18 17:23:48 -0400605 // Allocate a space in the destination buffer to write to.
606 size_t blitAllocationSize = copyFormat.pixelBytes * copyArea.width * copyArea.height;
607 uint8_t *destPtr = nullptr;
608 VkBuffer destBufferHandle = VK_NULL_HANDLE;
Jamie Madill4c310832018-08-29 13:43:17 -0400609 VkDeviceSize destOffset = 0;
Jamie Madillb436aac2018-07-18 17:23:48 -0400610 ANGLE_TRY(mBlitPixelBuffer.allocate(contextVk, blitAllocationSize, &destPtr, &destBufferHandle,
611 &destOffset, nullptr));
Luc Ferron1617e692018-07-11 11:08:19 -0400612
Jamie Madillb436aac2018-07-18 17:23:48 -0400613 ANGLE_TRY(
614 readPixelsImpl(contextVk, copyArea, packPixelsParams, aspect, readRenderTarget, destPtr));
Luc Ferron1617e692018-07-11 11:08:19 -0400615
Shahbaz Youssefi06270c92018-10-03 17:00:25 -0400616 VkBufferImageCopy copyRegion = {};
Jamie Madillb436aac2018-07-18 17:23:48 -0400617 copyRegion.bufferOffset = destOffset;
618 copyRegion.bufferImageHeight = copyArea.height;
619 copyRegion.bufferRowLength = copyArea.width;
620 copyRegion.imageExtent.width = copyArea.width;
621 copyRegion.imageExtent.height = copyArea.height;
622 copyRegion.imageExtent.depth = 1;
623 copyRegion.imageSubresource.mipLevel = 0;
624 copyRegion.imageSubresource.aspectMask = aspect;
625 copyRegion.imageSubresource.baseArrayLayer = 0;
626 copyRegion.imageSubresource.layerCount = 1;
627 copyRegion.imageOffset.x = copyArea.x;
628 copyRegion.imageOffset.y = copyArea.y;
629 copyRegion.imageOffset.z = 0;
630
Jamie Madill21061022018-07-12 23:56:30 -0400631 ANGLE_TRY(mBlitPixelBuffer.flush(contextVk));
Luc Ferron1617e692018-07-11 11:08:19 -0400632
633 // Reinitialize the commandBuffer after a read pixels because it calls
634 // renderer->finish which makes command buffers obsolete.
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400635 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -0400636 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Luc Ferron1617e692018-07-11 11:08:19 -0400637
638 // We read the bytes of the image in a buffer, now we have to copy them into the
639 // destination target.
Jamie Madille8dd0792018-09-27 15:04:27 -0400640 vk::ImageHelper *imageForWrite = drawRenderTarget->getImageForWrite(&mFramebuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400641
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500642 imageForWrite->changeLayout(imageForWrite->getAspectFlags(), vk::ImageLayout::TransferDst,
643 commandBuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400644
Jamie Madillb436aac2018-07-18 17:23:48 -0400645 commandBuffer->copyBufferToImage(destBufferHandle, imageForWrite->getImage(),
646 VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &copyRegion);
Luc Ferron1617e692018-07-11 11:08:19 -0400647
648 mBlitPixelBuffer.releaseRetainedBuffers(renderer);
Jamie Madillb436aac2018-07-18 17:23:48 -0400649
Jamie Madill7c985f52018-11-29 18:16:17 -0500650 return angle::Result::Continue;
Luc Ferron1617e692018-07-11 11:08:19 -0400651}
652
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400653angle::Result FramebufferVk::blit(const gl::Context *context,
654 const gl::Rectangle &sourceArea,
655 const gl::Rectangle &destArea,
656 GLbitfield mask,
657 GLenum filter)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400658{
Luc Ferron26581112018-06-21 09:43:08 -0400659 ContextVk *contextVk = vk::GetImpl(context);
660 RendererVk *renderer = contextVk->getRenderer();
661
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500662 const gl::State &glState = context->getState();
Luc Ferron26581112018-06-21 09:43:08 -0400663 const gl::Framebuffer *sourceFramebuffer = glState.getReadFramebuffer();
Jamie Madillba365932018-07-18 17:23:46 -0400664 bool blitColorBuffer = (mask & GL_COLOR_BUFFER_BIT) != 0;
665 bool blitDepthBuffer = (mask & GL_DEPTH_BUFFER_BIT) != 0;
666 bool blitStencilBuffer = (mask & GL_STENCIL_BUFFER_BIT) != 0;
Luc Ferron26581112018-06-21 09:43:08 -0400667
Luc Ferron26581112018-06-21 09:43:08 -0400668 FramebufferVk *sourceFramebufferVk = vk::GetImpl(sourceFramebuffer);
Luc Ferron82eda932018-07-09 15:10:22 -0400669 bool flipSource = contextVk->isViewportFlipEnabledForReadFBO();
670 bool flipDest = contextVk->isViewportFlipEnabledForDrawFBO();
671
Jamie Madilld754eb52018-07-19 14:55:03 -0400672 gl::Rectangle readRect = sourceArea;
673 gl::Rectangle drawRect = destArea;
674
675 if (glState.isScissorTestEnabled())
676 {
677 const gl::Rectangle scissorRect = glState.getScissor();
678 if (!ClipRectangle(sourceArea, scissorRect, &readRect))
679 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500680 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400681 }
682
683 if (!ClipRectangle(destArea, scissorRect, &drawRect))
684 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500685 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400686 }
687 }
688
689 // After cropping for the scissor, we also want to crop for the size of the buffers.
690
Luc Ferron26581112018-06-21 09:43:08 -0400691 if (blitColorBuffer)
692 {
693 RenderTargetVk *readRenderTarget = sourceFramebufferVk->getColorReadRenderTarget();
694
Jamie Madilld754eb52018-07-19 14:55:03 -0400695 gl::Rectangle readRenderTargetRect;
696 if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect))
697 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500698 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400699 }
700
Luc Ferron26581112018-06-21 09:43:08 -0400701 for (size_t colorAttachment : mState.getEnabledDrawBuffers())
702 {
703 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorAttachment];
704 ASSERT(drawRenderTarget);
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -0500705 ASSERT(HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget));
Jamie Madilld754eb52018-07-19 14:55:03 -0400706
707 gl::Rectangle drawRenderTargetRect;
708 if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect))
709 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500710 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400711 }
712
Jamie Madill16c20142018-10-01 13:58:19 -0400713 ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect,
714 readRenderTarget, drawRenderTarget, filter, true, false,
715 false, flipSource, flipDest));
Luc Ferron26581112018-06-21 09:43:08 -0400716 }
717 }
718
719 if (blitDepthBuffer || blitStencilBuffer)
720 {
721 RenderTargetVk *readRenderTarget = sourceFramebufferVk->getDepthStencilRenderTarget();
722 ASSERT(readRenderTarget);
723
Jamie Madilld754eb52018-07-19 14:55:03 -0400724 gl::Rectangle readRenderTargetRect;
725 if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect))
726 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500727 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400728 }
729
Luc Ferron26581112018-06-21 09:43:08 -0400730 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getDepthStencil();
Jamie Madilld754eb52018-07-19 14:55:03 -0400731 ASSERT(drawRenderTarget);
732
733 gl::Rectangle drawRenderTargetRect;
734 if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect))
735 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500736 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400737 }
738
739 ASSERT(readRenderTargetRect == drawRenderTargetRect);
740 ASSERT(filter == GL_NEAREST);
Luc Ferron26581112018-06-21 09:43:08 -0400741
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -0500742 if (HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget))
Luc Ferron26581112018-06-21 09:43:08 -0400743 {
Jamie Madill16c20142018-10-01 13:58:19 -0400744 ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect,
745 readRenderTarget, drawRenderTarget, filter, false,
746 blitDepthBuffer, blitStencilBuffer, flipSource, flipDest));
Luc Ferron26581112018-06-21 09:43:08 -0400747 }
748 else
749 {
Luc Ferron1617e692018-07-11 11:08:19 -0400750 if (flipSource || flipDest)
751 {
Jamie Madillb436aac2018-07-18 17:23:48 -0400752 if (blitDepthBuffer)
753 {
754 ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect,
Jamie Madill16c20142018-10-01 13:58:19 -0400755 VK_IMAGE_ASPECT_DEPTH_BIT, readRenderTarget,
756 drawRenderTarget));
Jamie Madillb436aac2018-07-18 17:23:48 -0400757 }
758 if (blitStencilBuffer)
759 {
760 ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect,
Jamie Madill16c20142018-10-01 13:58:19 -0400761 VK_IMAGE_ASPECT_STENCIL_BIT, readRenderTarget,
762 drawRenderTarget));
Jamie Madillb436aac2018-07-18 17:23:48 -0400763 }
Luc Ferron1617e692018-07-11 11:08:19 -0400764 }
765 else
766 {
Jamie Madill16c20142018-10-01 13:58:19 -0400767 ANGLE_TRY(blitWithCopy(contextVk, readRenderTargetRect, readRenderTarget,
768 drawRenderTarget, blitDepthBuffer, blitStencilBuffer));
Luc Ferron1617e692018-07-11 11:08:19 -0400769 }
Luc Ferron26581112018-06-21 09:43:08 -0400770 }
771 }
772
Jamie Madill7c985f52018-11-29 18:16:17 -0500773 return angle::Result::Continue;
Luc Ferron26581112018-06-21 09:43:08 -0400774}
775
Jamie Madill16c20142018-10-01 13:58:19 -0400776angle::Result FramebufferVk::blitWithCommand(ContextVk *contextVk,
777 const gl::Rectangle &readRectIn,
778 const gl::Rectangle &drawRectIn,
779 RenderTargetVk *readRenderTarget,
780 RenderTargetVk *drawRenderTarget,
781 GLenum filter,
782 bool colorBlit,
783 bool depthBlit,
784 bool stencilBlit,
785 bool flipSource,
786 bool flipDest)
Luc Ferron26581112018-06-21 09:43:08 -0400787{
788 // Since blitRenderbufferRect is called for each render buffer that needs to be blitted,
789 // it should never be the case that both color and depth/stencil need to be blitted at
790 // at the same time.
791 ASSERT(colorBlit != (depthBlit || stencilBlit));
792
Jamie Madill16c20142018-10-01 13:58:19 -0400793 vk::ImageHelper *dstImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
794
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400795 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400796 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
797
Luc Ferron26581112018-06-21 09:43:08 -0400798 const vk::Format &readImageFormat = readRenderTarget->getImageFormat();
799 VkImageAspectFlags aspectMask =
800 colorBlit ? VK_IMAGE_ASPECT_COLOR_BIT
801 : vk::GetDepthStencilAspectFlags(readImageFormat.textureFormat());
802 vk::ImageHelper *srcImage = readRenderTarget->getImageForRead(
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500803 &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Luc Ferron26581112018-06-21 09:43:08 -0400804
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400805 const gl::Extents sourceFrameBufferExtents = readRenderTarget->getExtents();
Jamie Madilld754eb52018-07-19 14:55:03 -0400806 gl::Rectangle readRect = readRectIn;
807
Luc Ferron82eda932018-07-09 15:10:22 -0400808 if (flipSource)
809 {
Jamie Madilld754eb52018-07-19 14:55:03 -0400810 readRect.y = sourceFrameBufferExtents.height - readRect.y - readRect.height;
Luc Ferron82eda932018-07-09 15:10:22 -0400811 }
812
Jamie Madillba365932018-07-18 17:23:46 -0400813 VkImageBlit blit = {};
814 blit.srcOffsets[0] = {readRect.x0(), flipSource ? readRect.y1() : readRect.y0(), 0};
815 blit.srcOffsets[1] = {readRect.x1(), flipSource ? readRect.y0() : readRect.y1(), 1};
816 blit.srcSubresource.aspectMask = aspectMask;
817 blit.srcSubresource.mipLevel = 0;
Luc Ferron26581112018-06-21 09:43:08 -0400818 blit.srcSubresource.baseArrayLayer = 0;
819 blit.srcSubresource.layerCount = 1;
820 blit.dstSubresource.aspectMask = aspectMask;
821 blit.dstSubresource.mipLevel = 0;
822 blit.dstSubresource.baseArrayLayer = 0;
823 blit.dstSubresource.layerCount = 1;
824
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400825 const gl::Extents drawFrameBufferExtents = drawRenderTarget->getExtents();
826 gl::Rectangle drawRect = drawRectIn;
Luc Ferron26581112018-06-21 09:43:08 -0400827
Luc Ferron82eda932018-07-09 15:10:22 -0400828 if (flipDest)
829 {
Jamie Madilld754eb52018-07-19 14:55:03 -0400830 drawRect.y = drawFrameBufferExtents.height - drawRect.y - drawRect.height;
Luc Ferron82eda932018-07-09 15:10:22 -0400831 }
832
Jamie Madilld754eb52018-07-19 14:55:03 -0400833 blit.dstOffsets[0] = {drawRect.x0(), flipDest ? drawRect.y1() : drawRect.y0(), 0};
834 blit.dstOffsets[1] = {drawRect.x1(), flipDest ? drawRect.y0() : drawRect.y1(), 1};
Luc Ferron26581112018-06-21 09:43:08 -0400835
Luc Ferron26581112018-06-21 09:43:08 -0400836 // Requirement of the copyImageToBuffer, the dst image must be in
837 // VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout.
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500838 dstImage->changeLayout(aspectMask, vk::ImageLayout::TransferDst, commandBuffer);
Luc Ferron26581112018-06-21 09:43:08 -0400839
840 commandBuffer->blitImage(srcImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL,
841 dstImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &blit,
842 gl_vk::GetFilter(filter));
Jamie Madill16c20142018-10-01 13:58:19 -0400843
Jamie Madill7c985f52018-11-29 18:16:17 -0500844 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400845}
846
Kenneth Russellce8602a2017-10-03 18:23:08 -0700847bool FramebufferVk::checkStatus(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400848{
Luc Ferron5bdf8bd2018-06-20 09:51:37 -0400849 // if we have both a depth and stencil buffer, they must refer to the same object
850 // since we only support packed_depth_stencil and not separate depth and stencil
851 if (mState.hasSeparateDepthAndStencilAttachments())
852 {
853 return false;
854 }
855
Jamie Madillb79e7bb2017-10-24 13:55:50 -0400856 return true;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400857}
858
Jamie Madill6f755b22018-10-09 12:48:54 -0400859angle::Result FramebufferVk::syncState(const gl::Context *context,
860 const gl::Framebuffer::DirtyBits &dirtyBits)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400861{
Jamie Madille1f3ad42017-10-28 23:00:42 -0400862 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madill7bd16662017-10-28 19:40:50 -0400863 RendererVk *renderer = contextVk->getRenderer();
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400864
865 ASSERT(dirtyBits.any());
Jamie Madill57d9cbb2018-04-27 11:45:04 -0400866 for (size_t dirtyBit : dirtyBits)
867 {
868 switch (dirtyBit)
869 {
870 case gl::Framebuffer::DIRTY_BIT_DEPTH_ATTACHMENT:
871 case gl::Framebuffer::DIRTY_BIT_STENCIL_ATTACHMENT:
872 ANGLE_TRY(mRenderTargetCache.updateDepthStencilRenderTarget(context, mState));
873 break;
874 case gl::Framebuffer::DIRTY_BIT_DRAW_BUFFERS:
875 case gl::Framebuffer::DIRTY_BIT_READ_BUFFER:
876 case gl::Framebuffer::DIRTY_BIT_DEFAULT_WIDTH:
877 case gl::Framebuffer::DIRTY_BIT_DEFAULT_HEIGHT:
878 case gl::Framebuffer::DIRTY_BIT_DEFAULT_SAMPLES:
879 case gl::Framebuffer::DIRTY_BIT_DEFAULT_FIXED_SAMPLE_LOCATIONS:
880 break;
881 default:
882 {
883 ASSERT(gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0 == 0 &&
884 dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_MAX);
885 size_t colorIndex =
886 static_cast<size_t>(dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0);
887 ANGLE_TRY(mRenderTargetCache.updateColorRenderTarget(context, mState, colorIndex));
Jamie Madill9aef3672018-04-27 11:45:06 -0400888
889 // Update cached masks for masked clears.
890 RenderTargetVk *renderTarget = mRenderTargetCache.getColors()[colorIndex];
891 if (renderTarget)
892 {
Luc Ferron5fd36932018-06-19 14:55:50 -0400893 const angle::Format &emulatedFormat =
894 renderTarget->getImageFormat().textureFormat();
895 updateActiveColorMasks(
896 colorIndex, emulatedFormat.redBits > 0, emulatedFormat.greenBits > 0,
897 emulatedFormat.blueBits > 0, emulatedFormat.alphaBits > 0);
898
Luc Ferron5fd36932018-06-19 14:55:50 -0400899 const angle::Format &sourceFormat =
900 renderTarget->getImageFormat().angleFormat();
901 mEmulatedAlphaAttachmentMask.set(
902 colorIndex, sourceFormat.alphaBits == 0 && emulatedFormat.alphaBits > 0);
Luc Ferron0bb940a2018-06-22 09:59:34 -0400903
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500904 contextVk->updateColorMask(context->getState().getBlendState());
Jamie Madill9aef3672018-04-27 11:45:06 -0400905 }
906 else
907 {
Jamie Madill58675012018-05-22 14:54:07 -0400908 updateActiveColorMasks(colorIndex, false, false, false, false);
Jamie Madill9aef3672018-04-27 11:45:06 -0400909 }
Jamie Madill57d9cbb2018-04-27 11:45:04 -0400910 break;
911 }
912 }
913 }
Jamie Madill66546be2018-03-08 09:47:20 -0500914
Jamie Madill9aef3672018-04-27 11:45:06 -0400915 mActiveColorComponents = gl_vk::GetColorComponentFlags(
Luc Ferron5fd36932018-06-19 14:55:50 -0400916 mActiveColorComponentMasksForClear[0].any(), mActiveColorComponentMasksForClear[1].any(),
917 mActiveColorComponentMasksForClear[2].any(), mActiveColorComponentMasksForClear[3].any());
Jamie Madill9aef3672018-04-27 11:45:06 -0400918
Jamie Madille8dd0792018-09-27 15:04:27 -0400919 mFramebuffer.release(renderer);
Jamie Madill49ac74b2017-12-21 14:42:33 -0500920
Jamie Madill316c6062018-05-29 10:49:45 -0400921 // Will freeze the current set of dependencies on this FBO. The next time we render we will
Jamie Madilla5e06072018-05-18 14:36:05 -0400922 // create a new entry in the command graph.
Jamie Madille8dd0792018-09-27 15:04:27 -0400923 mFramebuffer.finishCurrentCommands(renderer);
Jamie Madill72106562017-03-24 14:18:50 -0400924
Jamie Madilldbc605c2019-01-04 16:39:14 -0500925 // Notify the ContextVk to update the pipeline desc.
926 updateRenderPassDesc();
927 contextVk->onFramebufferChange(mRenderPassDesc);
Jamie Madill19fa1c62018-03-08 09:47:21 -0500928
Jamie Madill7c985f52018-11-29 18:16:17 -0500929 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500930}
931
Jamie Madilldbc605c2019-01-04 16:39:14 -0500932void FramebufferVk::updateRenderPassDesc()
Jamie Madillab9f9c32017-01-17 17:47:34 -0500933{
Jamie Madilldbc605c2019-01-04 16:39:14 -0500934 mRenderPassDesc = {};
935 mRenderPassDesc.setSamples(getSamples());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500936
Jamie Madill66546be2018-03-08 09:47:20 -0500937 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
938 const auto &colorRenderTargets = mRenderTargetCache.getColors();
939 for (size_t colorIndex : mState.getEnabledDrawBuffers())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500940 {
Jamie Madill66546be2018-03-08 09:47:20 -0500941 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
942 ASSERT(colorRenderTarget);
Jamie Madilldbc605c2019-01-04 16:39:14 -0500943 mRenderPassDesc.packAttachment(colorRenderTarget->getImage().getFormat());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500944 }
945
Jamie Madill66546be2018-03-08 09:47:20 -0500946 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
947 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500948 {
Jamie Madilldbc605c2019-01-04 16:39:14 -0500949 mRenderPassDesc.packAttachment(depthStencilRenderTarget->getImage().getFormat());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500950 }
Jamie Madillab9f9c32017-01-17 17:47:34 -0500951}
952
Jamie Madill21061022018-07-12 23:56:30 -0400953angle::Result FramebufferVk::getFramebuffer(ContextVk *contextVk, vk::Framebuffer **framebufferOut)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500954{
955 // If we've already created our cached Framebuffer, return it.
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400956 if (mFramebuffer.valid())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500957 {
Jamie Madille8dd0792018-09-27 15:04:27 -0400958 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -0500959 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500960 }
961
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400962 vk::RenderPass *compatibleRenderPass = nullptr;
963 ANGLE_TRY(contextVk->getRenderer()->getCompatibleRenderPass(contextVk, mRenderPassDesc,
964 &compatibleRenderPass));
Jamie Madillab9f9c32017-01-17 17:47:34 -0500965
966 // If we've a Framebuffer provided by a Surface (default FBO/backbuffer), query it.
967 if (mBackbuffer)
968 {
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400969 return mBackbuffer->getCurrentFramebuffer(contextVk, *compatibleRenderPass, framebufferOut);
Jamie Madillab9f9c32017-01-17 17:47:34 -0500970 }
971
972 // Gather VkImageViews over all FBO attachments, also size of attached region.
973 std::vector<VkImageView> attachments;
974 gl::Extents attachmentsSize;
975
Jamie Madill66546be2018-03-08 09:47:20 -0500976 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
977 const auto &colorRenderTargets = mRenderTargetCache.getColors();
978 for (size_t colorIndex : mState.getEnabledDrawBuffers())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500979 {
Jamie Madill66546be2018-03-08 09:47:20 -0500980 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
981 ASSERT(colorRenderTarget);
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +0100982 attachments.push_back(colorRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500983
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400984 ASSERT(attachmentsSize.empty() || attachmentsSize == colorRenderTarget->getExtents());
985 attachmentsSize = colorRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500986 }
987
Jamie Madill66546be2018-03-08 09:47:20 -0500988 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
989 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500990 {
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +0100991 attachments.push_back(depthStencilRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500992
Jamie Madillbc543422018-03-30 10:43:19 -0400993 ASSERT(attachmentsSize.empty() ||
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400994 attachmentsSize == depthStencilRenderTarget->getExtents());
995 attachmentsSize = depthStencilRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500996 }
997
998 ASSERT(!attachments.empty());
999
Shahbaz Youssefi06270c92018-10-03 17:00:25 -04001000 VkFramebufferCreateInfo framebufferInfo = {};
Jamie Madillab9f9c32017-01-17 17:47:34 -05001001
1002 framebufferInfo.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO;
Jamie Madillab9f9c32017-01-17 17:47:34 -05001003 framebufferInfo.flags = 0;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001004 framebufferInfo.renderPass = compatibleRenderPass->getHandle();
Jamie Madillab9f9c32017-01-17 17:47:34 -05001005 framebufferInfo.attachmentCount = static_cast<uint32_t>(attachments.size());
1006 framebufferInfo.pAttachments = attachments.data();
1007 framebufferInfo.width = static_cast<uint32_t>(attachmentsSize.width);
1008 framebufferInfo.height = static_cast<uint32_t>(attachmentsSize.height);
1009 framebufferInfo.layers = 1;
1010
Jamie Madill21061022018-07-12 23:56:30 -04001011 ANGLE_TRY(mFramebuffer.init(contextVk, framebufferInfo));
Jamie Madill5deea722017-02-16 10:44:46 -05001012
Jamie Madille8dd0792018-09-27 15:04:27 -04001013 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -05001014 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001015}
1016
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001017angle::Result FramebufferVk::clearWithRenderPassOp(
1018 ContextVk *contextVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001019 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001020 bool clearDepth,
1021 bool clearStencil,
1022 const VkClearColorValue &clearColorValue,
1023 const VkClearDepthStencilValue &clearDepthStencilValue)
1024{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001025 // If render pass hasn't started, start it. If it's started and contains commands, we cannot
1026 // modify its ops, so start a new render pass.
1027 if (!mFramebuffer.valid() || !mFramebuffer.renderPassStartedButEmpty())
1028 {
1029 vk::CommandBuffer *commandBuffer;
1030 ANGLE_TRY(startNewRenderPass(contextVk, &commandBuffer));
1031 }
1032
1033 size_t attachmentIndex = 0;
1034
1035 // Go through clearColorBuffers and set the appropriate loadOp and clear values.
1036 // TODO: Support gaps in RenderTargets. http://anglebug.com/2394
1037 for (size_t colorIndex : mState.getEnabledDrawBuffers())
1038 {
1039 if (clearColorBuffers.test(colorIndex))
1040 {
1041 RenderTargetVk *renderTarget = getColorReadRenderTarget();
1042
1043 // If the render target doesn't have alpha, but its emulated format has it, clear the
1044 // alpha to 1.
1045 VkClearColorValue value = clearColorValue;
1046 if (mEmulatedAlphaAttachmentMask[colorIndex])
1047 {
1048 SetEmulatedAlphaValue(renderTarget->getImageFormat(), &value);
1049 }
1050
1051 mFramebuffer.clearRenderPassColorAttachment(attachmentIndex, value);
1052 }
1053 ++attachmentIndex;
1054 }
1055
1056 // Set the appropriate loadOp and clear values for depth and stencil.
1057 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1058 if (depthStencilRenderTarget)
1059 {
1060 if (clearDepth)
1061 {
1062 mFramebuffer.clearRenderPassDepthAttachment(attachmentIndex,
1063 clearDepthStencilValue.depth);
1064 }
1065
1066 if (clearStencil)
1067 {
1068 mFramebuffer.clearRenderPassStencilAttachment(attachmentIndex,
1069 clearDepthStencilValue.stencil);
1070 }
1071 }
1072
1073 return angle::Result::Continue;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001074}
1075
Shahbaz Youssefid856ca42018-10-31 16:55:12 -04001076angle::Result FramebufferVk::clearWithClearAttachments(
1077 ContextVk *contextVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001078 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefid856ca42018-10-31 16:55:12 -04001079 bool clearDepth,
1080 bool clearStencil,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001081 const VkClearColorValue &clearColorValue,
Shahbaz Youssefid856ca42018-10-31 16:55:12 -04001082 const VkClearDepthStencilValue &clearDepthStencilValue)
Luc Ferron5242d5b2018-02-15 07:14:35 -05001083{
Jamie Madill316c6062018-05-29 10:49:45 -04001084 // Trigger a new command node to ensure overlapping writes happen sequentially.
Jamie Madille8dd0792018-09-27 15:04:27 -04001085 mFramebuffer.finishCurrentCommands(contextVk->getRenderer());
Jamie Madill9aef3672018-04-27 11:45:06 -04001086
Luc Ferron5242d5b2018-02-15 07:14:35 -05001087 // This command can only happen inside a render pass, so obtain one if its already happening
1088 // or create a new one if not.
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001089 vk::CommandBuffer *commandBuffer = nullptr;
1090 vk::RecordingMode mode = vk::RecordingMode::Start;
Jamie Madill316c6062018-05-29 10:49:45 -04001091 ANGLE_TRY(getCommandBufferForDraw(contextVk, &commandBuffer, &mode));
Luc Ferron5242d5b2018-02-15 07:14:35 -05001092
Jamie Madill3f3b3582018-09-14 10:38:44 -04001093 // The array layer is offset by the ImageView. So we shouldn't need to set a base array layer.
Shahbaz Youssefi06270c92018-10-03 17:00:25 -04001094 VkClearRect clearRect = {};
Luc Ferrone4c38be2018-04-17 11:09:16 -04001095 clearRect.baseArrayLayer = 0;
1096 clearRect.layerCount = 1;
1097
1098 // When clearing, the scissor region must be clipped to the renderArea per the validation rules
1099 // in Vulkan.
1100 gl::Rectangle intersection;
Jamie Madillc3dc5d42018-12-30 12:12:04 -05001101 if (!gl::ClipRectangle(contextVk->getState().getScissor(),
Jamie Madille8dd0792018-09-27 15:04:27 -04001102 mFramebuffer.getRenderPassRenderArea(), &intersection))
Luc Ferrone4c38be2018-04-17 11:09:16 -04001103 {
1104 // There is nothing to clear since the scissor is outside of the render area.
Jamie Madill7c985f52018-11-29 18:16:17 -05001105 return angle::Result::Continue;
Luc Ferrone4c38be2018-04-17 11:09:16 -04001106 }
Luc Ferron1a135ad2018-07-04 10:35:31 -04001107
Luc Ferrone4c38be2018-04-17 11:09:16 -04001108 clearRect.rect = gl_vk::GetRect(intersection);
1109
Luc Ferron82eda932018-07-09 15:10:22 -04001110 if (contextVk->isViewportFlipEnabledForDrawFBO())
Luc Ferron1a135ad2018-07-04 10:35:31 -04001111 {
Jamie Madille8dd0792018-09-27 15:04:27 -04001112 clearRect.rect.offset.y = mFramebuffer.getRenderPassRenderArea().height -
1113 clearRect.rect.offset.y - clearRect.rect.extent.height;
Luc Ferron1a135ad2018-07-04 10:35:31 -04001114 }
1115
Luc Ferron5242d5b2018-02-15 07:14:35 -05001116 gl::AttachmentArray<VkClearAttachment> clearAttachments;
1117 int clearAttachmentIndex = 0;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001118
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001119 if (clearColorBuffers.any())
Luc Ferron5242d5b2018-02-15 07:14:35 -05001120 {
Luc Ferronf6e160f2018-06-12 10:13:57 -04001121 RenderTargetVk *renderTarget = getColorReadRenderTarget();
1122 const vk::Format &format = renderTarget->getImageFormat();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001123 VkClearValue modifiedClear = {clearColorValue};
Luc Ferronf6e160f2018-06-12 10:13:57 -04001124
1125 // We need to make sure we are not clearing the alpha channel if we are using a buffer
1126 // format that doesn't have an alpha channel.
1127 if (format.angleFormat().alphaBits == 0)
1128 {
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001129 SetEmulatedAlphaValue(format, &modifiedClear.color);
Luc Ferronf6e160f2018-06-12 10:13:57 -04001130 }
1131
Luc Ferrona8af3a62018-03-29 14:44:24 -04001132 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001133 for (size_t colorIndex : clearColorBuffers)
Luc Ferrona8af3a62018-03-29 14:44:24 -04001134 {
1135 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
1136 clearAttachment.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
1137 clearAttachment.colorAttachment = static_cast<uint32_t>(colorIndex);
Luc Ferronf6e160f2018-06-12 10:13:57 -04001138 clearAttachment.clearValue = modifiedClear;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001139 ++clearAttachmentIndex;
1140 }
1141 }
1142
Shahbaz Youssefid856ca42018-10-31 16:55:12 -04001143 VkClearValue depthStencilClearValue = {};
1144 depthStencilClearValue.depthStencil = clearDepthStencilValue;
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -04001145
Luc Ferrona8af3a62018-03-29 14:44:24 -04001146 if (clearDepth && clearStencil && mState.getDepthStencilAttachment() != nullptr)
1147 {
1148 // When we have a packed depth/stencil attachment we can do 1 clear for both when it
1149 // applies.
Luc Ferron5242d5b2018-02-15 07:14:35 -05001150 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
Luc Ferrona8af3a62018-03-29 14:44:24 -04001151 clearAttachment.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT;
1152 clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED;
Jamie Madill7c985f52018-11-29 18:16:17 -05001153 clearAttachment.clearValue = depthStencilClearValue;
Luc Ferron5242d5b2018-02-15 07:14:35 -05001154 ++clearAttachmentIndex;
1155 }
Luc Ferrona8af3a62018-03-29 14:44:24 -04001156 else
1157 {
1158 if (clearDepth)
1159 {
1160 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
1161 clearAttachment.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT;
1162 clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED;
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -04001163 clearAttachment.clearValue = depthStencilClearValue;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001164 ++clearAttachmentIndex;
1165 }
1166
1167 if (clearStencil)
1168 {
1169 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
1170 clearAttachment.aspectMask = VK_IMAGE_ASPECT_STENCIL_BIT;
1171 clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED;
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -04001172 clearAttachment.clearValue = depthStencilClearValue;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001173 ++clearAttachmentIndex;
1174 }
1175 }
Luc Ferron5242d5b2018-02-15 07:14:35 -05001176
Luc Ferrona8af3a62018-03-29 14:44:24 -04001177 commandBuffer->clearAttachments(static_cast<uint32_t>(clearAttachmentIndex),
Luc Ferron5242d5b2018-02-15 07:14:35 -05001178 clearAttachments.data(), 1, &clearRect);
Jamie Madill7c985f52018-11-29 18:16:17 -05001179 return angle::Result::Continue;
Luc Ferron5242d5b2018-02-15 07:14:35 -05001180}
1181
Jamie Madill21061022018-07-12 23:56:30 -04001182angle::Result FramebufferVk::clearWithDraw(ContextVk *contextVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001183 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001184 bool clearDepth,
1185 bool clearStencil,
1186 VkColorComponentFlags colorMaskFlags,
1187 uint8_t stencilMask,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001188 const VkClearColorValue &clearColorValue,
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001189 const VkClearDepthStencilValue &clearDepthStencilValue)
Jamie Madill9aef3672018-04-27 11:45:06 -04001190{
Jamie Madilldc65c5b2018-11-21 11:07:26 -05001191 RendererVk *renderer = contextVk->getRenderer();
1192
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001193 UtilsVk::ClearFramebufferParameters params = {};
1194 params.renderPassDesc = &getRenderPassDesc();
1195 params.renderAreaHeight = mState.getDimensions().height;
1196 params.colorClearValue = clearColorValue;
1197 params.depthStencilClearValue = clearDepthStencilValue;
1198 params.stencilMask = stencilMask;
1199
1200 params.clearColor = true;
1201 params.clearDepth = clearDepth;
1202 params.clearStencil = clearStencil;
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001203
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001204 const auto &colorRenderTargets = mRenderTargetCache.getColors();
1205 for (size_t colorIndex : clearColorBuffers)
1206 {
1207 const RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
1208 ASSERT(colorRenderTarget);
1209
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001210 params.colorFormat = &colorRenderTarget->getImage().getFormat().textureFormat();
1211 params.colorAttachmentIndex = colorIndex;
1212 params.colorMaskFlags = colorMaskFlags;
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001213 if (mEmulatedAlphaAttachmentMask[colorIndex])
1214 {
1215 params.colorMaskFlags &= ~VK_COLOR_COMPONENT_A_BIT;
1216 }
1217
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001218 ANGLE_TRY(renderer->getUtils().clearFramebuffer(contextVk, this, params));
1219
1220 // Clear depth/stencil only once!
1221 params.clearDepth = false;
1222 params.clearStencil = false;
1223 }
1224
1225 // If there was no color clear, clear depth/stencil alone.
1226 if (params.clearDepth || params.clearStencil)
1227 {
1228 params.clearColor = false;
1229 ANGLE_TRY(renderer->getUtils().clearFramebuffer(contextVk, this, params));
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001230 }
1231
1232 return angle::Result::Continue;
Jamie Madill9aef3672018-04-27 11:45:06 -04001233}
1234
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001235angle::Result FramebufferVk::getSamplePosition(const gl::Context *context,
1236 size_t index,
1237 GLfloat *xy) const
JiangYizhoubddc46b2016-12-09 09:50:51 +08001238{
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001239 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -05001240 return angle::Result::Stop;
JiangYizhoubddc46b2016-12-09 09:50:51 +08001241}
1242
Jamie Madill21061022018-07-12 23:56:30 -04001243angle::Result FramebufferVk::getCommandBufferForDraw(ContextVk *contextVk,
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001244 vk::CommandBuffer **commandBufferOut,
Jamie Madill21061022018-07-12 23:56:30 -04001245 vk::RecordingMode *modeOut)
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001246{
Jamie Madill49ac74b2017-12-21 14:42:33 -05001247 RendererVk *renderer = contextVk->getRenderer();
Jamie Madillbef918c2017-12-13 13:11:30 -05001248
Jamie Madill316c6062018-05-29 10:49:45 -04001249 // This will clear the current write operation if it is complete.
Jamie Madillc759b8b2019-01-03 15:16:50 -05001250 if (appendToStartedRenderPass(renderer->getCurrentQueueSerial(), commandBufferOut))
Jamie Madill4c26fc22017-02-24 11:04:10 -05001251 {
Jamie Madill316c6062018-05-29 10:49:45 -04001252 *modeOut = vk::RecordingMode::Append;
Jamie Madill7c985f52018-11-29 18:16:17 -05001253 return angle::Result::Continue;
Jamie Madill9cceac42018-03-31 14:19:16 -04001254 }
Jamie Madill4c26fc22017-02-24 11:04:10 -05001255
Jamie Madilld1249de2018-08-28 16:58:53 -04001256 return startNewRenderPass(contextVk, commandBufferOut);
1257}
1258
1259angle::Result FramebufferVk::startNewRenderPass(ContextVk *contextVk,
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001260 vk::CommandBuffer **commandBufferOut)
Jamie Madilld1249de2018-08-28 16:58:53 -04001261{
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001262 vk::Framebuffer *framebuffer = nullptr;
Jamie Madill21061022018-07-12 23:56:30 -04001263 ANGLE_TRY(getFramebuffer(contextVk, &framebuffer));
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001264
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001265 vk::AttachmentOpsArray renderPassAttachmentOps;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001266 std::vector<VkClearValue> attachmentClearValues;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001267
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001268 vk::CommandBuffer *writeCommands = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001269 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &writeCommands));
Jamie Madille4c5a232018-03-02 21:00:31 -05001270
Jamie Madillbcf467f2018-05-23 09:46:00 -04001271 vk::RenderPassDesc renderPassDesc;
1272
Jamie Madill49ac74b2017-12-21 14:42:33 -05001273 // Initialize RenderPass info.
Jamie Madill66546be2018-03-08 09:47:20 -05001274 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
1275 const auto &colorRenderTargets = mRenderTargetCache.getColors();
1276 for (size_t colorIndex : mState.getEnabledDrawBuffers())
Jamie Madill4c26fc22017-02-24 11:04:10 -05001277 {
Jamie Madill66546be2018-03-08 09:47:20 -05001278 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
1279 ASSERT(colorRenderTarget);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001280
Courtney Goeltzenleuchter5a604a52019-03-27 14:22:50 -06001281 ANGLE_TRY(colorRenderTarget->onColorDraw(contextVk, &mFramebuffer, writeCommands,
1282 &renderPassDesc));
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001283
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001284 renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(),
1285 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
1286 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL);
1287 attachmentClearValues.emplace_back(kUninitializedClearValue);
Jamie Madill66546be2018-03-08 09:47:20 -05001288 }
1289
1290 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1291 if (depthStencilRenderTarget)
1292 {
Courtney Goeltzenleuchter5a604a52019-03-27 14:22:50 -06001293 ANGLE_TRY(depthStencilRenderTarget->onDepthStencilDraw(contextVk, &mFramebuffer,
1294 writeCommands, &renderPassDesc));
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001295
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001296 renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(),
1297 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL,
1298 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
1299 attachmentClearValues.emplace_back(kUninitializedClearValue);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001300 }
1301
Luc Ferrond17bdfe2018-04-05 13:50:10 -04001302 gl::Rectangle renderArea =
1303 gl::Rectangle(0, 0, mState.getDimensions().width, mState.getDimensions().height);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001304
Jamie Madilldbc605c2019-01-04 16:39:14 -05001305 return mFramebuffer.beginRenderPass(contextVk, *framebuffer, renderArea, mRenderPassDesc,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001306 renderPassAttachmentOps, attachmentClearValues,
1307 commandBufferOut);
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001308}
1309
Jamie Madill9aef3672018-04-27 11:45:06 -04001310void FramebufferVk::updateActiveColorMasks(size_t colorIndex, bool r, bool g, bool b, bool a)
1311{
Luc Ferron5fd36932018-06-19 14:55:50 -04001312 mActiveColorComponentMasksForClear[0].set(colorIndex, r);
1313 mActiveColorComponentMasksForClear[1].set(colorIndex, g);
1314 mActiveColorComponentMasksForClear[2].set(colorIndex, b);
1315 mActiveColorComponentMasksForClear[3].set(colorIndex, a);
1316}
1317
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001318const gl::DrawBufferMask &FramebufferVk::getEmulatedAlphaAttachmentMask() const
Luc Ferron5fd36932018-06-19 14:55:50 -04001319{
1320 return mEmulatedAlphaAttachmentMask;
Jamie Madill9aef3672018-04-27 11:45:06 -04001321}
Luc Ferron018709f2018-05-10 13:53:11 -04001322
Jamie Madill21061022018-07-12 23:56:30 -04001323angle::Result FramebufferVk::readPixelsImpl(ContextVk *contextVk,
1324 const gl::Rectangle &area,
1325 const PackPixelsParams &packPixelsParams,
Jamie Madillb436aac2018-07-18 17:23:48 -04001326 VkImageAspectFlagBits copyAspectFlags,
Jamie Madill21061022018-07-12 23:56:30 -04001327 RenderTargetVk *renderTarget,
1328 void *pixels)
Luc Ferron018709f2018-05-10 13:53:11 -04001329{
Tobin Ehlis4a419142019-02-05 08:50:30 -07001330 TRACE_EVENT0("gpu.angle", "FramebufferVk::readPixelsImpl");
Jamie Madill58675012018-05-22 14:54:07 -04001331
Shahbaz Youssefi29b49412019-01-07 14:03:06 -05001332 ANGLE_TRY(renderTarget->ensureImageInitialized(contextVk));
1333
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001334 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001335 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Jamie Madill58675012018-05-22 14:54:07 -04001336
Jamie Madillbcf467f2018-05-23 09:46:00 -04001337 // Note that although we're reading from the image, we need to update the layout below.
Luc Ferron1617e692018-07-11 11:08:19 -04001338
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -05001339 vk::ImageHelper *srcImage =
1340 renderTarget->getImageForRead(&mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Jamie Madillbcf467f2018-05-23 09:46:00 -04001341
Jamie Madillb436aac2018-07-18 17:23:48 -04001342 const angle::Format *readFormat = &srcImage->getFormat().textureFormat();
Luc Ferron1617e692018-07-11 11:08:19 -04001343
Jamie Madillb436aac2018-07-18 17:23:48 -04001344 if (copyAspectFlags != VK_IMAGE_ASPECT_COLOR_BIT)
Luc Ferron1617e692018-07-11 11:08:19 -04001345 {
Jamie Madillb436aac2018-07-18 17:23:48 -04001346 readFormat = &GetDepthStencilImageToBufferFormat(*readFormat, copyAspectFlags);
Luc Ferron1617e692018-07-11 11:08:19 -04001347 }
1348
Jamie Madillb980c562018-11-27 11:34:27 -05001349 VkBuffer bufferHandle = VK_NULL_HANDLE;
1350 uint8_t *readPixelBuffer = nullptr;
Jamie Madill4c310832018-08-29 13:43:17 -04001351 VkDeviceSize stagingOffset = 0;
Jamie Madillb980c562018-11-27 11:34:27 -05001352 size_t allocationSize = readFormat->pixelBytes * area.width * area.height;
Luc Ferron018709f2018-05-10 13:53:11 -04001353
Jamie Madilld754eb52018-07-19 14:55:03 -04001354 ANGLE_TRY(mReadPixelBuffer.allocate(contextVk, allocationSize, &readPixelBuffer, &bufferHandle,
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -05001355 &stagingOffset, nullptr));
Luc Ferron018709f2018-05-10 13:53:11 -04001356
Shahbaz Youssefi06270c92018-10-03 17:00:25 -04001357 VkBufferImageCopy region = {};
Luc Ferron534b00d2018-05-18 08:16:53 -04001358 region.bufferImageHeight = area.height;
Jamie Madill4c310832018-08-29 13:43:17 -04001359 region.bufferOffset = stagingOffset;
Luc Ferron534b00d2018-05-18 08:16:53 -04001360 region.bufferRowLength = area.width;
1361 region.imageExtent.width = area.width;
1362 region.imageExtent.height = area.height;
1363 region.imageExtent.depth = 1;
1364 region.imageOffset.x = area.x;
1365 region.imageOffset.y = area.y;
1366 region.imageOffset.z = 0;
Luc Ferron1617e692018-07-11 11:08:19 -04001367 region.imageSubresource.aspectMask = copyAspectFlags;
Jamie Madill3f3b3582018-09-14 10:38:44 -04001368 region.imageSubresource.baseArrayLayer = renderTarget->getLayerIndex();
Luc Ferron534b00d2018-05-18 08:16:53 -04001369 region.imageSubresource.layerCount = 1;
Geoff Lang4a298702019-01-18 10:49:36 -05001370 region.imageSubresource.mipLevel = renderTarget->getLevelIndex();
Luc Ferron534b00d2018-05-18 08:16:53 -04001371
Jamie Madillbcf467f2018-05-23 09:46:00 -04001372 commandBuffer->copyImageToBuffer(srcImage->getImage(), srcImage->getCurrentLayout(),
1373 bufferHandle, 1, &region);
Luc Ferron018709f2018-05-10 13:53:11 -04001374
1375 // Triggers a full finish.
1376 // TODO(jmadill): Don't block on asynchronous readback.
Geoff Lang892d1802019-03-27 14:21:34 -04001377 ANGLE_TRY(contextVk->finishImpl());
Luc Ferron018709f2018-05-10 13:53:11 -04001378
Luc Ferron534b00d2018-05-18 08:16:53 -04001379 // The buffer we copied to needs to be invalidated before we read from it because its not been
1380 // created with the host coherent bit.
Jamie Madilld754eb52018-07-19 14:55:03 -04001381 ANGLE_TRY(mReadPixelBuffer.invalidate(contextVk));
Yuly Novikov6c6c76c2018-05-17 18:45:06 +00001382
Jamie Madillb436aac2018-07-18 17:23:48 -04001383 PackPixels(packPixelsParams, *readFormat, area.width * readFormat->pixelBytes, readPixelBuffer,
Rafael Cintron05a449a2018-06-20 18:08:04 -07001384 static_cast<uint8_t *>(pixels));
Luc Ferron018709f2018-05-10 13:53:11 -04001385
Jamie Madill7c985f52018-11-29 18:16:17 -05001386 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -04001387}
Jamie Madill58675012018-05-22 14:54:07 -04001388
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001389gl::Extents FramebufferVk::getReadImageExtents() const
Jamie Madill58675012018-05-22 14:54:07 -04001390{
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001391 return getColorReadRenderTarget()->getExtents();
Jamie Madill58675012018-05-22 14:54:07 -04001392}
Jamie Madill502d2e22018-11-01 11:06:23 -04001393
1394RenderTargetVk *FramebufferVk::getFirstRenderTarget() const
1395{
1396 for (auto *renderTarget : mRenderTargetCache.getColors())
1397 {
1398 if (renderTarget)
1399 {
1400 return renderTarget;
1401 }
1402 }
1403
1404 return mRenderTargetCache.getDepthStencil();
1405}
1406
1407GLint FramebufferVk::getSamples() const
1408{
1409 RenderTargetVk *firstRT = getFirstRenderTarget();
1410 return firstRT ? firstRT->getImage().getSamples() : 0;
1411}
1412
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001413} // namespace rx