Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 1 | // |
| 2 | // Copyright 2016 The ANGLE Project Authors. All rights reserved. |
| 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | // FramebufferVk.cpp: |
| 7 | // Implements the class methods for FramebufferVk. |
| 8 | // |
| 9 | |
| 10 | #include "libANGLE/renderer/vulkan/FramebufferVk.h" |
| 11 | |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 12 | #include <vulkan/vulkan.h> |
Jamie Madill | 231c7f5 | 2017-04-26 13:45:37 -0400 | [diff] [blame] | 13 | #include <array> |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 14 | |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 15 | #include "common/debug.h" |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 16 | #include "libANGLE/Context.h" |
| 17 | #include "libANGLE/Display.h" |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 18 | #include "libANGLE/formatutils.h" |
| 19 | #include "libANGLE/renderer/renderer_utils.h" |
Jamie Madill | 1f46bc1 | 2018-02-20 16:09:43 -0500 | [diff] [blame] | 20 | #include "libANGLE/renderer/vulkan/CommandGraph.h" |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 21 | #include "libANGLE/renderer/vulkan/ContextVk.h" |
Jamie Madill | 5deea72 | 2017-02-16 10:44:46 -0500 | [diff] [blame] | 22 | #include "libANGLE/renderer/vulkan/DisplayVk.h" |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 23 | #include "libANGLE/renderer/vulkan/RenderTargetVk.h" |
| 24 | #include "libANGLE/renderer/vulkan/RendererVk.h" |
| 25 | #include "libANGLE/renderer/vulkan/SurfaceVk.h" |
Jamie Madill | 3c424b4 | 2018-01-19 12:35:09 -0500 | [diff] [blame] | 26 | #include "libANGLE/renderer/vulkan/vk_format_utils.h" |
Tobin Ehlis | 4a41914 | 2019-02-05 08:50:30 -0700 | [diff] [blame] | 27 | #include "third_party/trace_event/trace_event.h" |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 28 | |
| 29 | namespace rx |
| 30 | { |
| 31 | |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 32 | namespace |
| 33 | { |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 34 | // The value to assign an alpha channel that's emulated. The type is unsigned int, though it will |
| 35 | // automatically convert to the actual data type. |
| 36 | constexpr unsigned int kEmulatedAlphaValue = 1; |
| 37 | |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 38 | constexpr size_t kMinReadPixelsBufferSize = 128000; |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 39 | // Clear values are only used when loadOp=Clear is set in clearWithRenderPassOp. When starting a |
| 40 | // new render pass, the clear value is set to an unlikely value (bright pink) to stand out better |
| 41 | // in case of a bug. |
| 42 | constexpr VkClearValue kUninitializedClearValue = {{{0.95, 0.05, 0.95, 0.95}}}; |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 43 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 44 | const gl::InternalFormat &GetReadAttachmentInfo(const gl::Context *context, |
| 45 | RenderTargetVk *renderTarget) |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 46 | { |
Jamie Madill | bc54342 | 2018-03-30 10:43:19 -0400 | [diff] [blame] | 47 | GLenum implFormat = |
Jamie Madill | 0631e19 | 2019-04-18 16:09:12 -0400 | [diff] [blame] | 48 | renderTarget->getImageFormat().imageFormat().fboImplementationInternalFormat; |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 49 | return gl::GetSizedInternalFormatInfo(implFormat); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 50 | } |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 51 | |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 52 | bool ClipToRenderTarget(const gl::Rectangle &area, |
| 53 | RenderTargetVk *renderTarget, |
| 54 | gl::Rectangle *rectOut) |
| 55 | { |
Shahbaz Youssefi | 6854940 | 2019-03-25 23:30:49 -0400 | [diff] [blame] | 56 | const gl::Extents renderTargetExtents = renderTarget->getExtents(); |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 57 | gl::Rectangle renderTargetRect(0, 0, renderTargetExtents.width, renderTargetExtents.height); |
| 58 | return ClipRectangle(area, renderTargetRect, rectOut); |
| 59 | } |
| 60 | |
Shahbaz Youssefi | 96bd8fd | 2018-11-30 14:30:18 -0500 | [diff] [blame] | 61 | bool HasSrcAndDstBlitProperties(RendererVk *renderer, |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 62 | RenderTargetVk *srcRenderTarget, |
| 63 | RenderTargetVk *dstRenderTarget) |
| 64 | { |
Jamie Madill | 0631e19 | 2019-04-18 16:09:12 -0400 | [diff] [blame] | 65 | const VkFormat srcFormat = srcRenderTarget->getImageFormat().vkImageFormat; |
| 66 | const VkFormat dstFormat = dstRenderTarget->getImageFormat().vkImageFormat; |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 67 | |
| 68 | // Verifies if the draw and read images have the necessary prerequisites for blitting. |
Jamie Madill | 0631e19 | 2019-04-18 16:09:12 -0400 | [diff] [blame] | 69 | return renderer->hasImageFormatFeatureBits(srcFormat, VK_FORMAT_FEATURE_BLIT_SRC_BIT) && |
| 70 | renderer->hasImageFormatFeatureBits(dstFormat, VK_FORMAT_FEATURE_BLIT_DST_BIT); |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 71 | } |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 72 | |
| 73 | // Special rules apply to VkBufferImageCopy with depth/stencil. The components are tightly packed |
| 74 | // into a depth or stencil section of the destination buffer. See the spec: |
| 75 | // https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkBufferImageCopy.html |
| 76 | const angle::Format &GetDepthStencilImageToBufferFormat(const angle::Format &imageFormat, |
| 77 | VkImageAspectFlagBits copyAspect) |
| 78 | { |
| 79 | if (copyAspect == VK_IMAGE_ASPECT_STENCIL_BIT) |
| 80 | { |
| 81 | ASSERT(imageFormat.id == angle::FormatID::D24_UNORM_S8_UINT || |
| 82 | imageFormat.id == angle::FormatID::D32_FLOAT_S8X24_UINT || |
| 83 | imageFormat.id == angle::FormatID::S8_UINT); |
| 84 | return angle::Format::Get(angle::FormatID::S8_UINT); |
| 85 | } |
| 86 | |
| 87 | ASSERT(copyAspect == VK_IMAGE_ASPECT_DEPTH_BIT); |
| 88 | |
| 89 | switch (imageFormat.id) |
| 90 | { |
| 91 | case angle::FormatID::D16_UNORM: |
| 92 | return imageFormat; |
| 93 | case angle::FormatID::D24_UNORM_X8_UINT: |
| 94 | return imageFormat; |
| 95 | case angle::FormatID::D24_UNORM_S8_UINT: |
| 96 | return angle::Format::Get(angle::FormatID::D24_UNORM_X8_UINT); |
| 97 | case angle::FormatID::D32_FLOAT: |
| 98 | return imageFormat; |
| 99 | case angle::FormatID::D32_FLOAT_S8X24_UINT: |
| 100 | return angle::Format::Get(angle::FormatID::D32_FLOAT); |
| 101 | default: |
| 102 | UNREACHABLE(); |
| 103 | return imageFormat; |
| 104 | } |
| 105 | } |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 106 | |
| 107 | void SetEmulatedAlphaValue(const vk::Format &format, VkClearColorValue *value) |
| 108 | { |
| 109 | if (format.vkFormatIsInt) |
| 110 | { |
| 111 | if (format.vkFormatIsUnsigned) |
| 112 | { |
| 113 | value->uint32[3] = kEmulatedAlphaValue; |
| 114 | } |
| 115 | else |
| 116 | { |
| 117 | value->int32[3] = kEmulatedAlphaValue; |
| 118 | } |
| 119 | } |
| 120 | else |
| 121 | { |
| 122 | value->float32[3] = kEmulatedAlphaValue; |
| 123 | } |
| 124 | } |
Jamie Madill | bcf467f | 2018-05-23 09:46:00 -0400 | [diff] [blame] | 125 | } // anonymous namespace |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 126 | |
| 127 | // static |
Jamie Madill | 639bc90 | 2018-07-18 17:08:27 -0400 | [diff] [blame] | 128 | FramebufferVk *FramebufferVk::CreateUserFBO(RendererVk *renderer, const gl::FramebufferState &state) |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 129 | { |
Jamie Madill | 639bc90 | 2018-07-18 17:08:27 -0400 | [diff] [blame] | 130 | return new FramebufferVk(renderer, state, nullptr); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 131 | } |
| 132 | |
| 133 | // static |
Jamie Madill | 639bc90 | 2018-07-18 17:08:27 -0400 | [diff] [blame] | 134 | FramebufferVk *FramebufferVk::CreateDefaultFBO(RendererVk *renderer, |
| 135 | const gl::FramebufferState &state, |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 136 | WindowSurfaceVk *backbuffer) |
| 137 | { |
Jamie Madill | 639bc90 | 2018-07-18 17:08:27 -0400 | [diff] [blame] | 138 | return new FramebufferVk(renderer, state, backbuffer); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 139 | } |
| 140 | |
Jamie Madill | 639bc90 | 2018-07-18 17:08:27 -0400 | [diff] [blame] | 141 | FramebufferVk::FramebufferVk(RendererVk *renderer, |
| 142 | const gl::FramebufferState &state, |
| 143 | WindowSurfaceVk *backbuffer) |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 144 | : FramebufferImpl(state), |
| 145 | mBackbuffer(backbuffer), |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 146 | mActiveColorComponents(0), |
Shahbaz Youssefi | 254b32c | 2018-11-26 11:58:03 -0500 | [diff] [blame] | 147 | mReadPixelBuffer(VK_BUFFER_USAGE_TRANSFER_DST_BIT, kMinReadPixelsBufferSize, true), |
| 148 | mBlitPixelBuffer(VK_BUFFER_USAGE_TRANSFER_SRC_BIT, kMinReadPixelsBufferSize, true) |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 149 | { |
Jamie Madill | 639bc90 | 2018-07-18 17:08:27 -0400 | [diff] [blame] | 150 | mBlitPixelBuffer.init(1, renderer); |
Frank Henigman | 49b0f6e | 2018-10-03 23:15:29 -0400 | [diff] [blame] | 151 | mReadPixelBuffer.init(4, renderer); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 152 | } |
| 153 | |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame] | 154 | FramebufferVk::~FramebufferVk() = default; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 155 | |
Jamie Madill | c564c07 | 2017-06-01 12:45:42 -0400 | [diff] [blame] | 156 | void FramebufferVk::destroy(const gl::Context *context) |
Jamie Madill | 5deea72 | 2017-02-16 10:44:46 -0500 | [diff] [blame] | 157 | { |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 158 | ContextVk *contextVk = vk::GetImpl(context); |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 159 | mFramebuffer.release(contextVk); |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 160 | |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 161 | mReadPixelBuffer.release(contextVk); |
| 162 | mBlitPixelBuffer.release(contextVk); |
Jamie Madill | 5deea72 | 2017-02-16 10:44:46 -0500 | [diff] [blame] | 163 | } |
| 164 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 165 | angle::Result FramebufferVk::discard(const gl::Context *context, |
| 166 | size_t count, |
| 167 | const GLenum *attachments) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 168 | { |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 169 | ANGLE_VK_UNREACHABLE(vk::GetImpl(context)); |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 170 | return angle::Result::Stop; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 171 | } |
| 172 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 173 | angle::Result FramebufferVk::invalidate(const gl::Context *context, |
| 174 | size_t count, |
| 175 | const GLenum *attachments) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 176 | { |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 177 | ANGLE_VK_UNREACHABLE(vk::GetImpl(context)); |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 178 | return angle::Result::Stop; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 179 | } |
| 180 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 181 | angle::Result FramebufferVk::invalidateSub(const gl::Context *context, |
| 182 | size_t count, |
| 183 | const GLenum *attachments, |
| 184 | const gl::Rectangle &area) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 185 | { |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 186 | ANGLE_VK_UNREACHABLE(vk::GetImpl(context)); |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 187 | return angle::Result::Stop; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 188 | } |
| 189 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 190 | angle::Result FramebufferVk::clear(const gl::Context *context, GLbitfield mask) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 191 | { |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 192 | ContextVk *contextVk = vk::GetImpl(context); |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 193 | |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 194 | bool clearColor = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_COLOR_BUFFER_BIT)); |
| 195 | bool clearDepth = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_DEPTH_BUFFER_BIT)); |
| 196 | bool clearStencil = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_STENCIL_BUFFER_BIT)); |
| 197 | gl::DrawBufferMask clearColorBuffers; |
| 198 | if (clearColor) |
| 199 | { |
| 200 | clearColorBuffers = mState.getEnabledDrawBuffers(); |
| 201 | } |
| 202 | |
| 203 | const VkClearColorValue &clearColorValue = contextVk->getClearColorValue().color; |
| 204 | const VkClearDepthStencilValue &clearDepthStencilValue = |
| 205 | contextVk->getClearDepthStencilValue().depthStencil; |
| 206 | |
| 207 | return clearImpl(context, clearColorBuffers, clearDepth, clearStencil, clearColorValue, |
| 208 | clearDepthStencilValue); |
| 209 | } |
| 210 | |
| 211 | angle::Result FramebufferVk::clearImpl(const gl::Context *context, |
| 212 | gl::DrawBufferMask clearColorBuffers, |
| 213 | bool clearDepth, |
| 214 | bool clearStencil, |
| 215 | const VkClearColorValue &clearColorValue, |
| 216 | const VkClearDepthStencilValue &clearDepthStencilValue) |
| 217 | { |
| 218 | ContextVk *contextVk = vk::GetImpl(context); |
| 219 | |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 220 | const gl::Rectangle scissoredRenderArea = getScissoredRenderArea(contextVk); |
| 221 | |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 222 | // Discard clear altogether if scissor has 0 width or height. |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 223 | if (scissoredRenderArea.width == 0 || scissoredRenderArea.height == 0) |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 224 | { |
| 225 | return angle::Result::Continue; |
| 226 | } |
| 227 | |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 228 | mFramebuffer.updateQueueSerial(contextVk->getCurrentQueueSerial()); |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 229 | |
| 230 | // This function assumes that only enabled attachments are asked to be cleared. |
| 231 | ASSERT((clearColorBuffers & mState.getEnabledDrawBuffers()) == clearColorBuffers); |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 232 | |
Shahbaz Youssefi | edef895 | 2019-04-04 10:03:09 -0400 | [diff] [blame] | 233 | // Adjust clear behavior based on whether the respective attachments are present; if asked to |
| 234 | // clear a non-existent attachment, don't attempt to clear it. |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 235 | |
| 236 | VkColorComponentFlags colorMaskFlags = contextVk->getClearColorMask(); |
| 237 | bool clearColor = clearColorBuffers.any(); |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 238 | |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 239 | const gl::FramebufferAttachment *depthAttachment = mState.getDepthAttachment(); |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 240 | clearDepth = clearDepth && depthAttachment; |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 241 | ASSERT(!clearDepth || depthAttachment->isAttached()); |
| 242 | |
| 243 | const gl::FramebufferAttachment *stencilAttachment = mState.getStencilAttachment(); |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 244 | clearStencil = clearStencil && stencilAttachment; |
Jamie Madill | 0cec82a | 2018-03-14 09:21:07 -0400 | [diff] [blame] | 245 | ASSERT(!clearStencil || stencilAttachment->isAttached()); |
| 246 | |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 247 | uint8_t stencilMask = |
| 248 | static_cast<uint8_t>(contextVk->getState().getDepthStencilState().stencilWritemask); |
| 249 | |
| 250 | // The front-end should ensure we don't attempt to clear color if all channels are masked. |
| 251 | ASSERT(!clearColor || colorMaskFlags != 0); |
| 252 | // The front-end should ensure we don't attempt to clear depth if depth write is disabled. |
| 253 | ASSERT(!clearDepth || contextVk->getState().getDepthStencilState().depthMask); |
| 254 | // The front-end should ensure we don't attempt to clear stencil if all bits are masked. |
| 255 | ASSERT(!clearStencil || stencilMask != 0); |
| 256 | |
| 257 | // If there is nothing to clear, return right away (for example, if asked to clear depth, but |
| 258 | // there is no depth attachment). |
Shahbaz Youssefi | 02a579e | 2019-03-27 14:21:20 -0400 | [diff] [blame] | 259 | if (!clearColor && !clearDepth && !clearStencil) |
| 260 | { |
| 261 | return angle::Result::Continue; |
| 262 | } |
| 263 | |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 264 | VkClearDepthStencilValue modifiedDepthStencilValue = clearDepthStencilValue; |
Shahbaz Youssefi | d856ca4 | 2018-10-31 16:55:12 -0400 | [diff] [blame] | 265 | |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 266 | // We can use render pass load ops if clearing depth, unmasked color or unmasked stencil. If |
| 267 | // there's a depth mask, depth clearing is already disabled. |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 268 | bool maskedClearColor = |
| 269 | clearColor && (mActiveColorComponents & colorMaskFlags) != mActiveColorComponents; |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 270 | bool maskedClearStencil = stencilMask != 0xFF; |
| 271 | |
| 272 | bool clearColorWithRenderPassLoadOp = clearColor && !maskedClearColor; |
| 273 | bool clearStencilWithRenderPassLoadOp = clearStencil && !maskedClearStencil; |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 274 | |
| 275 | // At least one of color, depth or stencil should be clearable with render pass loadOp for us |
| 276 | // to use this clear path. |
Shahbaz Youssefi | f1153b0 | 2019-03-27 11:22:54 -0400 | [diff] [blame] | 277 | bool clearAnyWithRenderPassLoadOp = |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 278 | clearColorWithRenderPassLoadOp || clearDepth || clearStencilWithRenderPassLoadOp; |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 279 | |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 280 | if (clearAnyWithRenderPassLoadOp) |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 281 | { |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 282 | // Clearing color is indicated by the set bits in this mask. If not clearing colors with |
| 283 | // render pass loadOp, the default value of all-zeros means the clear is not done in |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 284 | // clearWithRenderPassOp below. In that case, only clear depth/stencil with render pass |
| 285 | // loadOp. |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 286 | gl::DrawBufferMask clearBuffersWithRenderPassLoadOp; |
| 287 | if (clearColorWithRenderPassLoadOp) |
| 288 | { |
| 289 | clearBuffersWithRenderPassLoadOp = clearColorBuffers; |
| 290 | } |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 291 | ANGLE_TRY(clearWithRenderPassOp( |
| 292 | contextVk, scissoredRenderArea, clearBuffersWithRenderPassLoadOp, clearDepth, |
| 293 | clearStencilWithRenderPassLoadOp, clearColorValue, modifiedDepthStencilValue)); |
Shahbaz Youssefi | f1153b0 | 2019-03-27 11:22:54 -0400 | [diff] [blame] | 294 | |
Shahbaz Youssefi | 27f115a | 2019-04-01 10:33:21 -0400 | [diff] [blame] | 295 | // On some hardware, having inline commands at this point results in corrupted output. In |
| 296 | // that case, end the render pass immediately. http://anglebug.com/2361 |
Jonah Ryan-Davis | 776694c | 2019-05-08 10:28:55 -0400 | [diff] [blame] | 297 | if (contextVk->getRenderer()->getFeatures().restartRenderPassAfterLoadOpClear.enabled) |
Shahbaz Youssefi | 27f115a | 2019-04-01 10:33:21 -0400 | [diff] [blame] | 298 | { |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 299 | mFramebuffer.finishCurrentCommands(contextVk); |
Shahbaz Youssefi | 27f115a | 2019-04-01 10:33:21 -0400 | [diff] [blame] | 300 | } |
| 301 | |
Shahbaz Youssefi | f1153b0 | 2019-03-27 11:22:54 -0400 | [diff] [blame] | 302 | // Fallback to other methods for whatever isn't cleared here. |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 303 | clearDepth = false; |
Shahbaz Youssefi | f1153b0 | 2019-03-27 11:22:54 -0400 | [diff] [blame] | 304 | if (clearColorWithRenderPassLoadOp) |
| 305 | { |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 306 | clearColorBuffers.reset(); |
Shahbaz Youssefi | f1153b0 | 2019-03-27 11:22:54 -0400 | [diff] [blame] | 307 | clearColor = false; |
| 308 | } |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 309 | if (clearStencilWithRenderPassLoadOp) |
| 310 | { |
| 311 | clearStencil = false; |
| 312 | } |
Shahbaz Youssefi | f1153b0 | 2019-03-27 11:22:54 -0400 | [diff] [blame] | 313 | |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 314 | // If nothing left to clear, early out. |
| 315 | if (!clearColor && !clearStencil) |
Shahbaz Youssefi | f1153b0 | 2019-03-27 11:22:54 -0400 | [diff] [blame] | 316 | { |
| 317 | return angle::Result::Continue; |
| 318 | } |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 319 | } |
| 320 | |
Shahbaz Youssefi | 2249d4a | 2019-04-05 16:48:55 -0400 | [diff] [blame] | 321 | // Note: depth clear is always done through render pass loadOp. |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 322 | ASSERT(clearDepth == false); |
| 323 | |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 324 | // The most costly clear mode is when we need to mask out specific color channels or stencil |
Shahbaz Youssefi | 2249d4a | 2019-04-05 16:48:55 -0400 | [diff] [blame] | 325 | // bits. This can only be done with a draw call. |
| 326 | return clearWithDraw(contextVk, scissoredRenderArea, clearColorBuffers, clearStencil, |
| 327 | colorMaskFlags, stencilMask, clearColorValue, |
| 328 | static_cast<uint8_t>(modifiedDepthStencilValue.stencil)); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 329 | } |
| 330 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 331 | angle::Result FramebufferVk::clearBufferfv(const gl::Context *context, |
| 332 | GLenum buffer, |
| 333 | GLint drawbuffer, |
| 334 | const GLfloat *values) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 335 | { |
Shahbaz Youssefi | edef895 | 2019-04-04 10:03:09 -0400 | [diff] [blame] | 336 | VkClearValue clearValue = {}; |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 337 | |
| 338 | bool clearDepth = false; |
| 339 | gl::DrawBufferMask clearColorBuffers; |
| 340 | |
| 341 | if (buffer == GL_DEPTH) |
| 342 | { |
| 343 | clearDepth = true; |
| 344 | clearValue.depthStencil.depth = values[0]; |
| 345 | } |
| 346 | else |
| 347 | { |
| 348 | clearColorBuffers.set(drawbuffer); |
| 349 | clearValue.color.float32[0] = values[0]; |
| 350 | clearValue.color.float32[1] = values[1]; |
| 351 | clearValue.color.float32[2] = values[2]; |
| 352 | clearValue.color.float32[3] = values[3]; |
| 353 | } |
| 354 | |
| 355 | return clearImpl(context, clearColorBuffers, clearDepth, false, clearValue.color, |
| 356 | clearValue.depthStencil); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 357 | } |
| 358 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 359 | angle::Result FramebufferVk::clearBufferuiv(const gl::Context *context, |
| 360 | GLenum buffer, |
| 361 | GLint drawbuffer, |
| 362 | const GLuint *values) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 363 | { |
Shahbaz Youssefi | edef895 | 2019-04-04 10:03:09 -0400 | [diff] [blame] | 364 | VkClearValue clearValue = {}; |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 365 | |
| 366 | gl::DrawBufferMask clearColorBuffers; |
| 367 | clearColorBuffers.set(drawbuffer); |
| 368 | |
| 369 | clearValue.color.uint32[0] = values[0]; |
| 370 | clearValue.color.uint32[1] = values[1]; |
| 371 | clearValue.color.uint32[2] = values[2]; |
| 372 | clearValue.color.uint32[3] = values[3]; |
| 373 | |
| 374 | return clearImpl(context, clearColorBuffers, false, false, clearValue.color, |
| 375 | clearValue.depthStencil); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 376 | } |
| 377 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 378 | angle::Result FramebufferVk::clearBufferiv(const gl::Context *context, |
| 379 | GLenum buffer, |
| 380 | GLint drawbuffer, |
| 381 | const GLint *values) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 382 | { |
Shahbaz Youssefi | edef895 | 2019-04-04 10:03:09 -0400 | [diff] [blame] | 383 | VkClearValue clearValue = {}; |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 384 | |
| 385 | bool clearStencil = false; |
| 386 | gl::DrawBufferMask clearColorBuffers; |
| 387 | |
| 388 | if (buffer == GL_STENCIL) |
| 389 | { |
| 390 | clearStencil = true; |
| 391 | clearValue.depthStencil.stencil = |
| 392 | gl::clamp(values[0], 0, std::numeric_limits<uint8_t>::max()); |
| 393 | } |
| 394 | else |
| 395 | { |
| 396 | clearColorBuffers.set(drawbuffer); |
| 397 | clearValue.color.int32[0] = values[0]; |
| 398 | clearValue.color.int32[1] = values[1]; |
| 399 | clearValue.color.int32[2] = values[2]; |
| 400 | clearValue.color.int32[3] = values[3]; |
| 401 | } |
| 402 | |
| 403 | return clearImpl(context, clearColorBuffers, false, clearStencil, clearValue.color, |
| 404 | clearValue.depthStencil); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 405 | } |
| 406 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 407 | angle::Result FramebufferVk::clearBufferfi(const gl::Context *context, |
| 408 | GLenum buffer, |
| 409 | GLint drawbuffer, |
| 410 | GLfloat depth, |
| 411 | GLint stencil) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 412 | { |
Shahbaz Youssefi | edef895 | 2019-04-04 10:03:09 -0400 | [diff] [blame] | 413 | VkClearValue clearValue = {}; |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 414 | |
| 415 | clearValue.depthStencil.depth = depth; |
| 416 | clearValue.depthStencil.stencil = gl::clamp(stencil, 0, std::numeric_limits<uint8_t>::max()); |
| 417 | |
| 418 | return clearImpl(context, gl::DrawBufferMask(), true, true, clearValue.color, |
| 419 | clearValue.depthStencil); |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 420 | } |
| 421 | |
Jamie Madill | 4928b7c | 2017-06-20 12:57:39 -0400 | [diff] [blame] | 422 | GLenum FramebufferVk::getImplementationColorReadFormat(const gl::Context *context) const |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 423 | { |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 424 | return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).format; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 425 | } |
| 426 | |
Jamie Madill | 4928b7c | 2017-06-20 12:57:39 -0400 | [diff] [blame] | 427 | GLenum FramebufferVk::getImplementationColorReadType(const gl::Context *context) const |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 428 | { |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 429 | return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).type; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 430 | } |
| 431 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 432 | angle::Result FramebufferVk::readPixels(const gl::Context *context, |
| 433 | const gl::Rectangle &area, |
| 434 | GLenum format, |
| 435 | GLenum type, |
| 436 | void *pixels) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 437 | { |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 438 | // Clip read area to framebuffer. |
| 439 | const gl::Extents &fbSize = getState().getReadAttachment()->getSize(); |
| 440 | const gl::Rectangle fbRect(0, 0, fbSize.width, fbSize.height); |
Luc Ferron | bf6dc37 | 2018-06-28 15:24:19 -0400 | [diff] [blame] | 441 | ContextVk *contextVk = vk::GetImpl(context); |
Luc Ferron | bf6dc37 | 2018-06-28 15:24:19 -0400 | [diff] [blame] | 442 | |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 443 | gl::Rectangle clippedArea; |
| 444 | if (!ClipRectangle(area, fbRect, &clippedArea)) |
| 445 | { |
| 446 | // nothing to read |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 447 | return angle::Result::Continue; |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 448 | } |
Luc Ferron | bf6dc37 | 2018-06-28 15:24:19 -0400 | [diff] [blame] | 449 | gl::Rectangle flippedArea = clippedArea; |
Geoff Lang | e076a23 | 2018-07-16 15:34:05 -0400 | [diff] [blame] | 450 | if (contextVk->isViewportFlipEnabledForReadFBO()) |
Luc Ferron | bf6dc37 | 2018-06-28 15:24:19 -0400 | [diff] [blame] | 451 | { |
| 452 | flippedArea.y = fbRect.height - flippedArea.y - flippedArea.height; |
| 453 | } |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 454 | |
Jamie Madill | c3dc5d4 | 2018-12-30 12:12:04 -0500 | [diff] [blame] | 455 | const gl::State &glState = context->getState(); |
Frank Henigman | 1ffad84 | 2018-09-24 23:40:45 -0400 | [diff] [blame] | 456 | const gl::PixelPackState &packState = glState.getPackState(); |
Luc Ferron | bf6dc37 | 2018-06-28 15:24:19 -0400 | [diff] [blame] | 457 | |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 458 | const gl::InternalFormat &sizedFormatInfo = gl::GetInternalFormatInfo(format, type); |
| 459 | |
| 460 | GLuint outputPitch = 0; |
Jamie Madill | abfbc0f | 2018-10-09 12:48:52 -0400 | [diff] [blame] | 461 | ANGLE_VK_CHECK_MATH(contextVk, |
| 462 | sizedFormatInfo.computeRowPitch(type, area.width, packState.alignment, |
| 463 | packState.rowLength, &outputPitch)); |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 464 | GLuint outputSkipBytes = 0; |
Jamie Madill | abfbc0f | 2018-10-09 12:48:52 -0400 | [diff] [blame] | 465 | ANGLE_VK_CHECK_MATH(contextVk, sizedFormatInfo.computeSkipBytes(type, outputPitch, 0, packState, |
| 466 | false, &outputSkipBytes)); |
Luc Ferron | a1c7242 | 2018-05-14 15:58:28 -0400 | [diff] [blame] | 467 | |
| 468 | outputSkipBytes += (clippedArea.x - area.x) * sizedFormatInfo.pixelBytes + |
| 469 | (clippedArea.y - area.y) * outputPitch; |
Luc Ferron | 6028422 | 2018-03-20 16:01:44 -0400 | [diff] [blame] | 470 | |
Jamie Madill | db9c69e | 2018-07-18 17:23:47 -0400 | [diff] [blame] | 471 | const angle::Format &angleFormat = GetFormatFromFormatType(format, type); |
| 472 | |
Frank Henigman | 1ffad84 | 2018-09-24 23:40:45 -0400 | [diff] [blame] | 473 | PackPixelsParams params(flippedArea, angleFormat, outputPitch, packState.reverseRowOrder, |
Jamie Madill | db9c69e | 2018-07-18 17:23:47 -0400 | [diff] [blame] | 474 | glState.getTargetBuffer(gl::BufferBinding::PixelPack), 0); |
Frank Henigman | 1ffad84 | 2018-09-24 23:40:45 -0400 | [diff] [blame] | 475 | if (contextVk->isViewportFlipEnabledForReadFBO()) |
| 476 | { |
| 477 | params.reverseRowOrder = !params.reverseRowOrder; |
| 478 | } |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 479 | |
Jamie Madill | 2106102 | 2018-07-12 23:56:30 -0400 | [diff] [blame] | 480 | ANGLE_TRY(readPixelsImpl(contextVk, flippedArea, params, VK_IMAGE_ASPECT_COLOR_BIT, |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 481 | getColorReadRenderTarget(), |
Rafael Cintron | 05a449a | 2018-06-20 18:08:04 -0700 | [diff] [blame] | 482 | static_cast<uint8_t *>(pixels) + outputSkipBytes)); |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 483 | mReadPixelBuffer.releaseRetainedBuffers(contextVk); |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 484 | return angle::Result::Continue; |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 485 | } |
Jamie Madill | 7b57b9d | 2017-01-13 09:33:38 -0500 | [diff] [blame] | 486 | |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 487 | RenderTargetVk *FramebufferVk::getDepthStencilRenderTarget() const |
| 488 | { |
| 489 | return mRenderTargetCache.getDepthStencil(); |
| 490 | } |
| 491 | |
Jamie Madill | 16c2014 | 2018-10-01 13:58:19 -0400 | [diff] [blame] | 492 | angle::Result FramebufferVk::blitWithCopy(ContextVk *contextVk, |
| 493 | const gl::Rectangle ©Area, |
| 494 | RenderTargetVk *readRenderTarget, |
| 495 | RenderTargetVk *drawRenderTarget, |
| 496 | bool blitDepthBuffer, |
| 497 | bool blitStencilBuffer) |
Luc Ferron | be30c4f | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 498 | { |
Shahbaz Youssefi | 028df5f | 2019-02-13 12:57:10 -0500 | [diff] [blame] | 499 | VkImageAspectFlags aspectMask = |
| 500 | vk::GetDepthStencilAspectFlagsForCopy(blitDepthBuffer, blitStencilBuffer); |
Jamie Madill | 16c2014 | 2018-10-01 13:58:19 -0400 | [diff] [blame] | 501 | |
Shahbaz Youssefi | 2660b50 | 2019-03-21 12:08:40 -0400 | [diff] [blame] | 502 | vk::CommandBuffer *commandBuffer = nullptr; |
Jamie Madill | 16c2014 | 2018-10-01 13:58:19 -0400 | [diff] [blame] | 503 | ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer)); |
| 504 | |
Shahbaz Youssefi | 028df5f | 2019-02-13 12:57:10 -0500 | [diff] [blame] | 505 | vk::ImageHelper *writeImage = drawRenderTarget->getImageForWrite(&mFramebuffer); |
| 506 | writeImage->changeLayout(writeImage->getAspectFlags(), vk::ImageLayout::TransferDst, |
| 507 | commandBuffer); |
| 508 | |
Luc Ferron | be30c4f | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 509 | vk::ImageHelper *readImage = readRenderTarget->getImageForRead( |
Shahbaz Youssefi | 7dafe3e | 2019-01-28 11:39:15 -0500 | [diff] [blame] | 510 | &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 511 | |
Shahbaz Youssefi | 028df5f | 2019-02-13 12:57:10 -0500 | [diff] [blame] | 512 | VkImageSubresourceLayers readSubresource = {}; |
| 513 | readSubresource.aspectMask = aspectMask; |
| 514 | readSubresource.mipLevel = 0; |
| 515 | readSubresource.baseArrayLayer = 0; |
| 516 | readSubresource.layerCount = 1; |
| 517 | |
| 518 | VkImageSubresourceLayers writeSubresource = readSubresource; |
| 519 | |
Luc Ferron | be30c4f | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 520 | vk::ImageHelper::Copy(readImage, writeImage, gl::Offset(), gl::Offset(), |
Shahbaz Youssefi | 028df5f | 2019-02-13 12:57:10 -0500 | [diff] [blame] | 521 | gl::Extents(copyArea.width, copyArea.height, 1), readSubresource, |
| 522 | writeSubresource, commandBuffer); |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 523 | return angle::Result::Continue; |
Luc Ferron | be30c4f | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 524 | } |
| 525 | |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame] | 526 | RenderTargetVk *FramebufferVk::getColorReadRenderTarget() const |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 527 | { |
| 528 | RenderTargetVk *renderTarget = mRenderTargetCache.getColorRead(mState); |
Jamie Madill | bcf467f | 2018-05-23 09:46:00 -0400 | [diff] [blame] | 529 | ASSERT(renderTarget && renderTarget->getImage().valid()); |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 530 | return renderTarget; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 531 | } |
| 532 | |
Jamie Madill | 2106102 | 2018-07-12 23:56:30 -0400 | [diff] [blame] | 533 | angle::Result FramebufferVk::blitWithReadback(ContextVk *contextVk, |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 534 | const gl::Rectangle ©Area, |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 535 | VkImageAspectFlagBits aspect, |
Jamie Madill | 2106102 | 2018-07-12 23:56:30 -0400 | [diff] [blame] | 536 | RenderTargetVk *readRenderTarget, |
| 537 | RenderTargetVk *drawRenderTarget) |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 538 | { |
Jamie Madill | 0631e19 | 2019-04-18 16:09:12 -0400 | [diff] [blame] | 539 | const angle::Format &readFormat = readRenderTarget->getImageFormat().imageFormat(); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 540 | |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 541 | ASSERT(aspect == VK_IMAGE_ASPECT_DEPTH_BIT || aspect == VK_IMAGE_ASPECT_STENCIL_BIT); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 542 | |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 543 | // This path is only currently used for y-flipping depth/stencil blits. |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 544 | PackPixelsParams packPixelsParams; |
Jamie Madill | b980c56 | 2018-11-27 11:34:27 -0500 | [diff] [blame] | 545 | packPixelsParams.reverseRowOrder = true; |
| 546 | packPixelsParams.area.width = copyArea.width; |
| 547 | packPixelsParams.area.height = copyArea.height; |
| 548 | packPixelsParams.area.x = copyArea.x; |
| 549 | packPixelsParams.area.y = copyArea.y; |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 550 | |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 551 | // Read back depth values into the destination buffer. |
| 552 | const angle::Format ©Format = GetDepthStencilImageToBufferFormat(readFormat, aspect); |
| 553 | packPixelsParams.destFormat = ©Format; |
| 554 | packPixelsParams.outputPitch = copyFormat.pixelBytes * copyArea.width; |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 555 | |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 556 | // Allocate a space in the destination buffer to write to. |
| 557 | size_t blitAllocationSize = copyFormat.pixelBytes * copyArea.width * copyArea.height; |
| 558 | uint8_t *destPtr = nullptr; |
| 559 | VkBuffer destBufferHandle = VK_NULL_HANDLE; |
Jamie Madill | 4c31083 | 2018-08-29 13:43:17 -0400 | [diff] [blame] | 560 | VkDeviceSize destOffset = 0; |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 561 | ANGLE_TRY(mBlitPixelBuffer.allocate(contextVk, blitAllocationSize, &destPtr, &destBufferHandle, |
| 562 | &destOffset, nullptr)); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 563 | |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 564 | ANGLE_TRY( |
| 565 | readPixelsImpl(contextVk, copyArea, packPixelsParams, aspect, readRenderTarget, destPtr)); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 566 | |
Shahbaz Youssefi | 06270c9 | 2018-10-03 17:00:25 -0400 | [diff] [blame] | 567 | VkBufferImageCopy copyRegion = {}; |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 568 | copyRegion.bufferOffset = destOffset; |
| 569 | copyRegion.bufferImageHeight = copyArea.height; |
| 570 | copyRegion.bufferRowLength = copyArea.width; |
| 571 | copyRegion.imageExtent.width = copyArea.width; |
| 572 | copyRegion.imageExtent.height = copyArea.height; |
| 573 | copyRegion.imageExtent.depth = 1; |
| 574 | copyRegion.imageSubresource.mipLevel = 0; |
| 575 | copyRegion.imageSubresource.aspectMask = aspect; |
| 576 | copyRegion.imageSubresource.baseArrayLayer = 0; |
| 577 | copyRegion.imageSubresource.layerCount = 1; |
| 578 | copyRegion.imageOffset.x = copyArea.x; |
| 579 | copyRegion.imageOffset.y = copyArea.y; |
| 580 | copyRegion.imageOffset.z = 0; |
| 581 | |
Jamie Madill | 2106102 | 2018-07-12 23:56:30 -0400 | [diff] [blame] | 582 | ANGLE_TRY(mBlitPixelBuffer.flush(contextVk)); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 583 | |
| 584 | // Reinitialize the commandBuffer after a read pixels because it calls |
| 585 | // renderer->finish which makes command buffers obsolete. |
Shahbaz Youssefi | 2660b50 | 2019-03-21 12:08:40 -0400 | [diff] [blame] | 586 | vk::CommandBuffer *commandBuffer = nullptr; |
Jamie Madill | e8dd079 | 2018-09-27 15:04:27 -0400 | [diff] [blame] | 587 | ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer)); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 588 | |
| 589 | // We read the bytes of the image in a buffer, now we have to copy them into the |
| 590 | // destination target. |
Jamie Madill | e8dd079 | 2018-09-27 15:04:27 -0400 | [diff] [blame] | 591 | vk::ImageHelper *imageForWrite = drawRenderTarget->getImageForWrite(&mFramebuffer); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 592 | |
Shahbaz Youssefi | 7dafe3e | 2019-01-28 11:39:15 -0500 | [diff] [blame] | 593 | imageForWrite->changeLayout(imageForWrite->getAspectFlags(), vk::ImageLayout::TransferDst, |
| 594 | commandBuffer); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 595 | |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 596 | commandBuffer->copyBufferToImage(destBufferHandle, imageForWrite->getImage(), |
| 597 | VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, ©Region); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 598 | |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 599 | mBlitPixelBuffer.releaseRetainedBuffers(contextVk); |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 600 | |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 601 | return angle::Result::Continue; |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 602 | } |
| 603 | |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 604 | angle::Result FramebufferVk::blitWithCommand(ContextVk *contextVk, |
| 605 | const gl::Rectangle &readRectIn, |
| 606 | const gl::Rectangle &drawRectIn, |
| 607 | RenderTargetVk *readRenderTarget, |
| 608 | RenderTargetVk *drawRenderTarget, |
| 609 | GLenum filter, |
| 610 | bool colorBlit, |
| 611 | bool depthBlit, |
| 612 | bool stencilBlit, |
| 613 | bool flipSource, |
| 614 | bool flipDest) |
| 615 | { |
| 616 | // Since blitRenderbufferRect is called for each render buffer that needs to be blitted, |
| 617 | // it should never be the case that both color and depth/stencil need to be blitted at |
| 618 | // at the same time. |
| 619 | ASSERT(colorBlit != (depthBlit || stencilBlit)); |
| 620 | |
| 621 | vk::ImageHelper *dstImage = drawRenderTarget->getImageForWrite(&mFramebuffer); |
| 622 | |
| 623 | vk::CommandBuffer *commandBuffer = nullptr; |
| 624 | ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer)); |
| 625 | |
| 626 | const vk::Format &readImageFormat = readRenderTarget->getImageFormat(); |
| 627 | VkImageAspectFlags aspectMask = |
| 628 | colorBlit ? VK_IMAGE_ASPECT_COLOR_BIT |
| 629 | : vk::GetDepthStencilAspectFlags(readImageFormat.imageFormat()); |
| 630 | vk::ImageHelper *srcImage = readRenderTarget->getImageForRead( |
| 631 | &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer); |
| 632 | |
| 633 | const gl::Extents sourceFrameBufferExtents = readRenderTarget->getExtents(); |
| 634 | gl::Rectangle readRect = readRectIn; |
| 635 | |
| 636 | if (flipSource) |
| 637 | { |
| 638 | readRect.y = sourceFrameBufferExtents.height - readRect.y - readRect.height; |
| 639 | } |
| 640 | |
| 641 | VkImageBlit blit = {}; |
| 642 | blit.srcOffsets[0] = {readRect.x0(), flipSource ? readRect.y1() : readRect.y0(), 0}; |
| 643 | blit.srcOffsets[1] = {readRect.x1(), flipSource ? readRect.y0() : readRect.y1(), 1}; |
| 644 | blit.srcSubresource.aspectMask = aspectMask; |
| 645 | blit.srcSubresource.mipLevel = readRenderTarget->getLevelIndex(); |
| 646 | blit.srcSubresource.baseArrayLayer = readRenderTarget->getLayerIndex(); |
| 647 | blit.srcSubresource.layerCount = 1; |
| 648 | blit.dstSubresource.aspectMask = aspectMask; |
| 649 | blit.dstSubresource.mipLevel = drawRenderTarget->getLevelIndex(); |
| 650 | blit.dstSubresource.baseArrayLayer = drawRenderTarget->getLayerIndex(); |
| 651 | blit.dstSubresource.layerCount = 1; |
| 652 | |
| 653 | const gl::Extents drawFrameBufferExtents = drawRenderTarget->getExtents(); |
| 654 | gl::Rectangle drawRect = drawRectIn; |
| 655 | |
| 656 | if (flipDest) |
| 657 | { |
| 658 | drawRect.y = drawFrameBufferExtents.height - drawRect.y - drawRect.height; |
| 659 | } |
| 660 | |
| 661 | blit.dstOffsets[0] = {drawRect.x0(), flipDest ? drawRect.y1() : drawRect.y0(), 0}; |
| 662 | blit.dstOffsets[1] = {drawRect.x1(), flipDest ? drawRect.y0() : drawRect.y1(), 1}; |
| 663 | |
| 664 | // Requirement of the copyImageToBuffer, the dst image must be in |
| 665 | // VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout. |
| 666 | dstImage->changeLayout(aspectMask, vk::ImageLayout::TransferDst, commandBuffer); |
| 667 | |
| 668 | commandBuffer->blitImage(srcImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, |
| 669 | dstImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &blit, |
| 670 | gl_vk::GetFilter(filter)); |
| 671 | |
| 672 | return angle::Result::Continue; |
| 673 | } |
| 674 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 675 | angle::Result FramebufferVk::blit(const gl::Context *context, |
| 676 | const gl::Rectangle &sourceArea, |
| 677 | const gl::Rectangle &destArea, |
| 678 | GLbitfield mask, |
| 679 | GLenum filter) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 680 | { |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 681 | ContextVk *contextVk = vk::GetImpl(context); |
| 682 | RendererVk *renderer = contextVk->getRenderer(); |
| 683 | |
Jamie Madill | c3dc5d4 | 2018-12-30 12:12:04 -0500 | [diff] [blame] | 684 | const gl::State &glState = context->getState(); |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 685 | const gl::Framebuffer *sourceFramebuffer = glState.getReadFramebuffer(); |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 686 | |
| 687 | bool blitColorBuffer = (mask & GL_COLOR_BUFFER_BIT) != 0; |
| 688 | bool blitDepthBuffer = (mask & GL_DEPTH_BUFFER_BIT) != 0; |
| 689 | bool blitStencilBuffer = (mask & GL_STENCIL_BUFFER_BIT) != 0; |
| 690 | |
| 691 | // If multisampled, blit only does a resolve. |
| 692 | if (sourceFramebuffer->getCachedSamples(context) > 1) |
| 693 | { |
| 694 | // Note: GLES (all 3.x versions) require source and dest area to be identical when |
| 695 | // resolving. |
| 696 | ASSERT(sourceArea.x == destArea.x && sourceArea.y == destArea.y && |
| 697 | sourceArea.width == destArea.width && sourceArea.height == destArea.height); |
| 698 | |
| 699 | return resolve(contextVk, destArea, blitColorBuffer, blitDepthBuffer, blitStencilBuffer); |
| 700 | } |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 701 | |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 702 | FramebufferVk *sourceFramebufferVk = vk::GetImpl(sourceFramebuffer); |
Luc Ferron | 82eda93 | 2018-07-09 15:10:22 -0400 | [diff] [blame] | 703 | bool flipSource = contextVk->isViewportFlipEnabledForReadFBO(); |
| 704 | bool flipDest = contextVk->isViewportFlipEnabledForDrawFBO(); |
| 705 | |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 706 | gl::Rectangle readRect = sourceArea; |
| 707 | gl::Rectangle drawRect = destArea; |
| 708 | |
| 709 | if (glState.isScissorTestEnabled()) |
| 710 | { |
| 711 | const gl::Rectangle scissorRect = glState.getScissor(); |
| 712 | if (!ClipRectangle(sourceArea, scissorRect, &readRect)) |
| 713 | { |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 714 | return angle::Result::Continue; |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 715 | } |
| 716 | |
| 717 | if (!ClipRectangle(destArea, scissorRect, &drawRect)) |
| 718 | { |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 719 | return angle::Result::Continue; |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 720 | } |
| 721 | } |
| 722 | |
| 723 | // After cropping for the scissor, we also want to crop for the size of the buffers. |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 724 | // |
| 725 | // TODO(syoussefi): GL requires that scaling factor is preserved even if further clipping is |
| 726 | // done: |
| 727 | // |
| 728 | // > Whether or not the source or destination regions are altered due to these limits, the |
| 729 | // > scaling and offset applied to pixels being transferred is performed as though no such |
| 730 | // > limits were present. |
| 731 | // |
| 732 | // Using vkCmdBlitFramebuffer after these clippings are done breaks this behavior. This |
| 733 | // function can be turned into a single draw call that does everything, similar to resolve(). |
| 734 | // |
| 735 | // http://anglebug.com/3200 |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 736 | |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 737 | if (blitColorBuffer) |
| 738 | { |
| 739 | RenderTargetVk *readRenderTarget = sourceFramebufferVk->getColorReadRenderTarget(); |
| 740 | |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 741 | gl::Rectangle readRenderTargetRect; |
| 742 | if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect)) |
| 743 | { |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 744 | return angle::Result::Continue; |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 745 | } |
| 746 | |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 747 | for (size_t colorIndexGL : mState.getEnabledDrawBuffers()) |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 748 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 749 | RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorIndexGL]; |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 750 | ASSERT(drawRenderTarget); |
Shahbaz Youssefi | 96bd8fd | 2018-11-30 14:30:18 -0500 | [diff] [blame] | 751 | ASSERT(HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget)); |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 752 | |
| 753 | gl::Rectangle drawRenderTargetRect; |
| 754 | if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect)) |
| 755 | { |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 756 | return angle::Result::Continue; |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 757 | } |
| 758 | |
Jamie Madill | 16c2014 | 2018-10-01 13:58:19 -0400 | [diff] [blame] | 759 | ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect, |
| 760 | readRenderTarget, drawRenderTarget, filter, true, false, |
| 761 | false, flipSource, flipDest)); |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 762 | } |
| 763 | } |
| 764 | |
| 765 | if (blitDepthBuffer || blitStencilBuffer) |
| 766 | { |
| 767 | RenderTargetVk *readRenderTarget = sourceFramebufferVk->getDepthStencilRenderTarget(); |
| 768 | ASSERT(readRenderTarget); |
| 769 | |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 770 | gl::Rectangle readRenderTargetRect; |
| 771 | if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect)) |
| 772 | { |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 773 | return angle::Result::Continue; |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 774 | } |
| 775 | |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 776 | RenderTargetVk *drawRenderTarget = mRenderTargetCache.getDepthStencil(); |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 777 | ASSERT(drawRenderTarget); |
| 778 | |
| 779 | gl::Rectangle drawRenderTargetRect; |
| 780 | if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect)) |
| 781 | { |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 782 | return angle::Result::Continue; |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 783 | } |
| 784 | |
| 785 | ASSERT(readRenderTargetRect == drawRenderTargetRect); |
| 786 | ASSERT(filter == GL_NEAREST); |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 787 | |
Shahbaz Youssefi | 96bd8fd | 2018-11-30 14:30:18 -0500 | [diff] [blame] | 788 | if (HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget)) |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 789 | { |
Jamie Madill | 16c2014 | 2018-10-01 13:58:19 -0400 | [diff] [blame] | 790 | ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect, |
| 791 | readRenderTarget, drawRenderTarget, filter, false, |
| 792 | blitDepthBuffer, blitStencilBuffer, flipSource, flipDest)); |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 793 | } |
| 794 | else |
| 795 | { |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 796 | if (flipSource || flipDest) |
| 797 | { |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 798 | if (blitDepthBuffer) |
| 799 | { |
| 800 | ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect, |
Jamie Madill | 16c2014 | 2018-10-01 13:58:19 -0400 | [diff] [blame] | 801 | VK_IMAGE_ASPECT_DEPTH_BIT, readRenderTarget, |
| 802 | drawRenderTarget)); |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 803 | } |
| 804 | if (blitStencilBuffer) |
| 805 | { |
| 806 | ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect, |
Jamie Madill | 16c2014 | 2018-10-01 13:58:19 -0400 | [diff] [blame] | 807 | VK_IMAGE_ASPECT_STENCIL_BIT, readRenderTarget, |
| 808 | drawRenderTarget)); |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 809 | } |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 810 | } |
| 811 | else |
| 812 | { |
Jamie Madill | 16c2014 | 2018-10-01 13:58:19 -0400 | [diff] [blame] | 813 | ANGLE_TRY(blitWithCopy(contextVk, readRenderTargetRect, readRenderTarget, |
| 814 | drawRenderTarget, blitDepthBuffer, blitStencilBuffer)); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 815 | } |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 816 | } |
| 817 | } |
| 818 | |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 819 | return angle::Result::Continue; |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 820 | } |
| 821 | |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 822 | angle::Result FramebufferVk::resolve(ContextVk *contextVk, |
| 823 | const gl::Rectangle &area, |
| 824 | bool resolveColorBuffer, |
| 825 | bool resolveDepthBuffer, |
| 826 | bool resolveStencilBuffer) |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 827 | { |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 828 | UtilsVk &utilsVk = contextVk->getUtils(); |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 829 | |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 830 | const gl::State &glState = contextVk->getState(); |
| 831 | const gl::Framebuffer *srcFramebuffer = glState.getReadFramebuffer(); |
| 832 | |
| 833 | FramebufferVk *srcFramebufferVk = vk::GetImpl(srcFramebuffer); |
| 834 | bool srcFramebufferFlippedY = contextVk->isViewportFlipEnabledForReadFBO(); |
| 835 | bool destFramebufferFlippedY = contextVk->isViewportFlipEnabledForDrawFBO(); |
| 836 | |
| 837 | gl::Rectangle srcFramebufferDimensions = srcFramebufferVk->mState.getDimensions().toRect(); |
| 838 | |
| 839 | gl::Rectangle sourceArea = area; |
| 840 | gl::Rectangle destArea = area; |
| 841 | |
| 842 | // If framebuffers are flipped in Y, flip the source and dest area first for simplicity. |
| 843 | if (srcFramebufferFlippedY) |
| 844 | { |
| 845 | sourceArea.y = srcFramebufferDimensions.height - sourceArea.y; |
| 846 | sourceArea.height = -sourceArea.height; |
| 847 | } |
| 848 | if (destFramebufferFlippedY) |
| 849 | { |
| 850 | destArea.y = mState.getDimensions().height - destArea.y; |
| 851 | destArea.height = -destArea.height; |
| 852 | } |
| 853 | |
| 854 | // If X (or Y) is flipped in neither source nor dest, or is flipped in both, we want the offset |
| 855 | // to be at the left (or top) of the copy area. If it's flipped in source xor dest, we want |
| 856 | // the offset to be at the right (or bottom) of the copy area (which is what the shader |
| 857 | // expects). x0() already chooses the left or right side of the source area based on whether |
| 858 | // it's flipped, so we just need to test dest for flip and choose x0() or x1() accordingly. |
| 859 | int srcOffset[2] = {destArea.isReversedX() ? sourceArea.x1() : sourceArea.x0(), |
| 860 | destArea.isReversedY() ? sourceArea.y1() : sourceArea.y0()}; |
| 861 | bool flipX = sourceArea.isReversedX() != destArea.isReversedX(); |
| 862 | bool flipY = sourceArea.isReversedY() != destArea.isReversedY(); |
| 863 | |
| 864 | // GLES doesn't allow flipping the parameters of glBlitFramebuffer if performing a resolve. |
| 865 | ASSERT(flipX == false && flipY == (srcFramebufferFlippedY != destFramebufferFlippedY)); |
| 866 | |
| 867 | // Destination offset is always set to the unflipped rectangle, as flipping as handled entirely |
| 868 | // on source side. |
| 869 | gl::Rectangle absDestArea = destArea.removeReversal(); |
| 870 | int destOffset[2] = {absDestArea.x, absDestArea.y}; |
| 871 | |
| 872 | gl::Rectangle scissoredDestArea = absDestArea; |
| 873 | if (contextVk->getState().isScissorTestEnabled()) |
| 874 | { |
| 875 | // Now that the src and dest offsets are calculated (defining the resolve transformation), |
| 876 | // scissor the destination area. |
| 877 | gl::Rectangle scissor = contextVk->getState().getScissor(); |
| 878 | if (destFramebufferFlippedY) |
| 879 | { |
| 880 | scissor.y = mState.getDimensions().height - scissor.y - scissor.height; |
| 881 | } |
| 882 | |
| 883 | if (!gl::ClipRectangle(scissor, absDestArea, &scissoredDestArea)) |
| 884 | { |
| 885 | return angle::Result::Continue; |
| 886 | } |
| 887 | } |
| 888 | |
| 889 | // Clip the resolve area to the destination framebuffer. |
| 890 | gl::Rectangle resolveArea; |
| 891 | if (!gl::ClipRectangle(srcFramebufferDimensions, scissoredDestArea, &resolveArea)) |
| 892 | { |
| 893 | return angle::Result::Continue; |
| 894 | } |
| 895 | |
| 896 | UtilsVk::ResolveParameters params; |
| 897 | params.srcOffset[0] = srcOffset[0]; |
| 898 | params.srcOffset[1] = srcOffset[1]; |
| 899 | params.srcExtents[0] = srcFramebufferDimensions.width; |
| 900 | params.srcExtents[1] = srcFramebufferDimensions.height; |
| 901 | params.destOffset[0] = destOffset[0]; |
| 902 | params.destOffset[1] = destOffset[1]; |
| 903 | params.resolveArea = resolveArea; |
| 904 | params.flipX = flipX; |
| 905 | params.flipY = flipY; |
| 906 | |
| 907 | if (resolveColorBuffer) |
| 908 | { |
| 909 | RenderTargetVk *readRenderTarget = srcFramebufferVk->getColorReadRenderTarget(); |
| 910 | params.srcLayer = readRenderTarget->getLayerIndex(); |
| 911 | |
| 912 | // Multisampled images are not allowed to have mips. |
| 913 | ASSERT(readRenderTarget->getLevelIndex() == 0); |
| 914 | |
| 915 | // If we're not flipping, use Vulkan's builtin resolve. |
| 916 | if (!flipX && !flipY) |
| 917 | { |
| 918 | ANGLE_TRY(resolveColorWithCommand(contextVk, params, &readRenderTarget->getImage())); |
| 919 | } |
| 920 | else |
| 921 | { |
| 922 | ANGLE_TRY(utilsVk.colorResolve(contextVk, this, &readRenderTarget->getImage(), |
| 923 | readRenderTarget->getFetchImageView(), params)); |
| 924 | } |
| 925 | } |
| 926 | |
| 927 | if (resolveDepthBuffer || resolveStencilBuffer) |
| 928 | { |
| 929 | RenderTargetVk *readRenderTarget = srcFramebufferVk->getDepthStencilRenderTarget(); |
| 930 | params.srcLayer = readRenderTarget->getLayerIndex(); |
| 931 | |
| 932 | // Multisampled images are not allowed to have mips. |
| 933 | ASSERT(readRenderTarget->getLevelIndex() == 0); |
| 934 | |
| 935 | // Create depth- and stencil-only views for reading. |
| 936 | vk::Scoped<vk::ImageView> depthView(contextVk->getDevice()); |
| 937 | vk::Scoped<vk::ImageView> stencilView(contextVk->getDevice()); |
| 938 | |
| 939 | vk::ImageHelper *depthStencilImage = &readRenderTarget->getImage(); |
| 940 | uint32_t levelIndex = readRenderTarget->getLevelIndex(); |
| 941 | uint32_t layerIndex = readRenderTarget->getLayerIndex(); |
| 942 | gl::TextureType textureType = vk::Get2DTextureType(depthStencilImage->getLayerCount(), |
| 943 | depthStencilImage->getSamples()); |
| 944 | |
| 945 | if (resolveDepthBuffer) |
| 946 | { |
| 947 | ANGLE_TRY(depthStencilImage->initLayerImageView( |
| 948 | contextVk, textureType, VK_IMAGE_ASPECT_DEPTH_BIT, gl::SwizzleState(), |
| 949 | &depthView.get(), levelIndex, 1, layerIndex, 1)); |
| 950 | } |
| 951 | |
| 952 | if (resolveStencilBuffer) |
| 953 | { |
| 954 | ANGLE_TRY(depthStencilImage->initLayerImageView( |
| 955 | contextVk, textureType, VK_IMAGE_ASPECT_STENCIL_BIT, gl::SwizzleState(), |
| 956 | &stencilView.get(), levelIndex, 1, layerIndex, 1)); |
| 957 | } |
| 958 | |
| 959 | ANGLE_TRY(utilsVk.depthStencilResolve(contextVk, this, depthStencilImage, &depthView.get(), |
| 960 | &stencilView.get(), params)); |
| 961 | |
| 962 | vk::ImageView depthViewObject = depthView.release(); |
| 963 | vk::ImageView stencilViewObject = stencilView.release(); |
| 964 | |
| 965 | contextVk->releaseObject(contextVk->getCurrentQueueSerial(), &depthViewObject); |
| 966 | contextVk->releaseObject(contextVk->getCurrentQueueSerial(), &stencilViewObject); |
| 967 | } |
| 968 | |
| 969 | return angle::Result::Continue; |
| 970 | } |
| 971 | |
| 972 | angle::Result FramebufferVk::resolveColorWithCommand(ContextVk *contextVk, |
| 973 | const UtilsVk::ResolveParameters ¶ms, |
| 974 | vk::ImageHelper *srcImage) |
| 975 | { |
| 976 | if (srcImage->isLayoutChangeNecessary(vk::ImageLayout::TransferSrc)) |
| 977 | { |
| 978 | vk::CommandBuffer *srcLayoutChange; |
| 979 | ANGLE_TRY(srcImage->recordCommands(contextVk, &srcLayoutChange)); |
| 980 | srcImage->changeLayout(VK_IMAGE_ASPECT_COLOR_BIT, vk::ImageLayout::TransferSrc, |
| 981 | srcLayoutChange); |
| 982 | } |
Jamie Madill | 16c2014 | 2018-10-01 13:58:19 -0400 | [diff] [blame] | 983 | |
Shahbaz Youssefi | 2660b50 | 2019-03-21 12:08:40 -0400 | [diff] [blame] | 984 | vk::CommandBuffer *commandBuffer = nullptr; |
Jamie Madill | 16c2014 | 2018-10-01 13:58:19 -0400 | [diff] [blame] | 985 | ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer)); |
| 986 | |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 987 | // Source's layout change should happen before rendering |
| 988 | srcImage->addReadDependency(&mFramebuffer); |
Luc Ferron | 2658111 | 2018-06-21 09:43:08 -0400 | [diff] [blame] | 989 | |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 990 | VkImageResolve resolveRegion = {}; |
| 991 | resolveRegion.srcSubresource.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT; |
| 992 | resolveRegion.srcSubresource.mipLevel = 0; |
| 993 | resolveRegion.srcSubresource.baseArrayLayer = params.srcLayer; |
| 994 | resolveRegion.srcSubresource.layerCount = 1; |
| 995 | resolveRegion.srcOffset.x = params.srcOffset[0]; |
| 996 | resolveRegion.srcOffset.y = params.srcOffset[1]; |
| 997 | resolveRegion.srcOffset.z = 0; |
| 998 | resolveRegion.dstSubresource.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT; |
| 999 | resolveRegion.dstSubresource.layerCount = 1; |
| 1000 | resolveRegion.dstOffset.x = params.destOffset[0]; |
| 1001 | resolveRegion.dstOffset.y = params.destOffset[1]; |
| 1002 | resolveRegion.dstOffset.z = 0; |
| 1003 | resolveRegion.extent.width = params.srcExtents[0]; |
| 1004 | resolveRegion.extent.height = params.srcExtents[1]; |
| 1005 | resolveRegion.extent.depth = 1; |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 1006 | |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 1007 | for (size_t colorIndexGL : mState.getEnabledDrawBuffers()) |
Luc Ferron | 82eda93 | 2018-07-09 15:10:22 -0400 | [diff] [blame] | 1008 | { |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 1009 | RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorIndexGL]; |
| 1010 | |
| 1011 | resolveRegion.dstSubresource.mipLevel = drawRenderTarget->getLevelIndex(); |
| 1012 | resolveRegion.dstSubresource.baseArrayLayer = drawRenderTarget->getLayerIndex(); |
| 1013 | |
| 1014 | srcImage->resolve(&drawRenderTarget->getImage(), resolveRegion, commandBuffer); |
Luc Ferron | 82eda93 | 2018-07-09 15:10:22 -0400 | [diff] [blame] | 1015 | } |
| 1016 | |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 1017 | return angle::Result::Continue; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 1018 | } |
| 1019 | |
Kenneth Russell | ce8602a | 2017-10-03 18:23:08 -0700 | [diff] [blame] | 1020 | bool FramebufferVk::checkStatus(const gl::Context *context) const |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 1021 | { |
Luc Ferron | 5bdf8bd | 2018-06-20 09:51:37 -0400 | [diff] [blame] | 1022 | // if we have both a depth and stencil buffer, they must refer to the same object |
| 1023 | // since we only support packed_depth_stencil and not separate depth and stencil |
| 1024 | if (mState.hasSeparateDepthAndStencilAttachments()) |
| 1025 | { |
| 1026 | return false; |
| 1027 | } |
| 1028 | |
Jamie Madill | b79e7bb | 2017-10-24 13:55:50 -0400 | [diff] [blame] | 1029 | return true; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 1030 | } |
| 1031 | |
Jamie Madill | 6722009 | 2019-05-20 11:12:53 -0400 | [diff] [blame] | 1032 | angle::Result FramebufferVk::updateColorAttachment(const gl::Context *context, size_t colorIndexGL) |
| 1033 | { |
| 1034 | ContextVk *contextVk = vk::GetImpl(context); |
| 1035 | |
| 1036 | ANGLE_TRY(mRenderTargetCache.updateColorRenderTarget(context, mState, colorIndexGL)); |
| 1037 | |
| 1038 | // Update cached masks for masked clears. |
| 1039 | RenderTargetVk *renderTarget = mRenderTargetCache.getColors()[colorIndexGL]; |
| 1040 | if (renderTarget) |
| 1041 | { |
| 1042 | const angle::Format &emulatedFormat = renderTarget->getImageFormat().imageFormat(); |
| 1043 | updateActiveColorMasks(colorIndexGL, emulatedFormat.redBits > 0, |
| 1044 | emulatedFormat.greenBits > 0, emulatedFormat.blueBits > 0, |
| 1045 | emulatedFormat.alphaBits > 0); |
| 1046 | |
| 1047 | const angle::Format &sourceFormat = renderTarget->getImageFormat().angleFormat(); |
| 1048 | mEmulatedAlphaAttachmentMask.set( |
| 1049 | colorIndexGL, sourceFormat.alphaBits == 0 && emulatedFormat.alphaBits > 0); |
| 1050 | |
| 1051 | contextVk->updateColorMask(context->getState().getBlendState()); |
| 1052 | } |
| 1053 | else |
| 1054 | { |
| 1055 | updateActiveColorMasks(colorIndexGL, false, false, false, false); |
| 1056 | } |
| 1057 | |
| 1058 | return angle::Result::Continue; |
| 1059 | } |
| 1060 | |
Jamie Madill | 6f755b2 | 2018-10-09 12:48:54 -0400 | [diff] [blame] | 1061 | angle::Result FramebufferVk::syncState(const gl::Context *context, |
| 1062 | const gl::Framebuffer::DirtyBits &dirtyBits) |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 1063 | { |
Jamie Madill | e1f3ad4 | 2017-10-28 23:00:42 -0400 | [diff] [blame] | 1064 | ContextVk *contextVk = vk::GetImpl(context); |
Jamie Madill | dd43e6c | 2017-03-24 14:18:49 -0400 | [diff] [blame] | 1065 | |
| 1066 | ASSERT(dirtyBits.any()); |
Jamie Madill | 57d9cbb | 2018-04-27 11:45:04 -0400 | [diff] [blame] | 1067 | for (size_t dirtyBit : dirtyBits) |
| 1068 | { |
| 1069 | switch (dirtyBit) |
| 1070 | { |
| 1071 | case gl::Framebuffer::DIRTY_BIT_DEPTH_ATTACHMENT: |
| 1072 | case gl::Framebuffer::DIRTY_BIT_STENCIL_ATTACHMENT: |
| 1073 | ANGLE_TRY(mRenderTargetCache.updateDepthStencilRenderTarget(context, mState)); |
| 1074 | break; |
Jamie Madill | 6722009 | 2019-05-20 11:12:53 -0400 | [diff] [blame] | 1075 | case gl::Framebuffer::DIRTY_BIT_DEPTH_BUFFER_CONTENTS: |
| 1076 | case gl::Framebuffer::DIRTY_BIT_STENCIL_BUFFER_CONTENTS: |
| 1077 | ANGLE_TRY(mRenderTargetCache.getDepthStencil()->flushStagedUpdates(contextVk)); |
| 1078 | break; |
Jamie Madill | 57d9cbb | 2018-04-27 11:45:04 -0400 | [diff] [blame] | 1079 | case gl::Framebuffer::DIRTY_BIT_DRAW_BUFFERS: |
| 1080 | case gl::Framebuffer::DIRTY_BIT_READ_BUFFER: |
| 1081 | case gl::Framebuffer::DIRTY_BIT_DEFAULT_WIDTH: |
| 1082 | case gl::Framebuffer::DIRTY_BIT_DEFAULT_HEIGHT: |
| 1083 | case gl::Framebuffer::DIRTY_BIT_DEFAULT_SAMPLES: |
| 1084 | case gl::Framebuffer::DIRTY_BIT_DEFAULT_FIXED_SAMPLE_LOCATIONS: |
| 1085 | break; |
| 1086 | default: |
| 1087 | { |
Jamie Madill | 6722009 | 2019-05-20 11:12:53 -0400 | [diff] [blame] | 1088 | static_assert(gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0 == 0, "FB dirty bits"); |
| 1089 | if (dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_MAX) |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 1090 | { |
Jamie Madill | 6722009 | 2019-05-20 11:12:53 -0400 | [diff] [blame] | 1091 | size_t colorIndexGL = static_cast<size_t>( |
| 1092 | dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0); |
| 1093 | ANGLE_TRY(updateColorAttachment(context, colorIndexGL)); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 1094 | } |
| 1095 | else |
| 1096 | { |
Jamie Madill | 6722009 | 2019-05-20 11:12:53 -0400 | [diff] [blame] | 1097 | ASSERT(dirtyBit >= gl::Framebuffer::DIRTY_BIT_COLOR_BUFFER_CONTENTS_0 && |
| 1098 | dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_BUFFER_CONTENTS_MAX); |
| 1099 | size_t colorIndexGL = static_cast<size_t>( |
| 1100 | dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_BUFFER_CONTENTS_0); |
| 1101 | ANGLE_TRY(mRenderTargetCache.getColors()[colorIndexGL]->flushStagedUpdates( |
| 1102 | contextVk)); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 1103 | } |
Jamie Madill | 57d9cbb | 2018-04-27 11:45:04 -0400 | [diff] [blame] | 1104 | break; |
| 1105 | } |
| 1106 | } |
| 1107 | } |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 1108 | |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 1109 | mActiveColorComponents = gl_vk::GetColorComponentFlags( |
Luc Ferron | 5fd3693 | 2018-06-19 14:55:50 -0400 | [diff] [blame] | 1110 | mActiveColorComponentMasksForClear[0].any(), mActiveColorComponentMasksForClear[1].any(), |
| 1111 | mActiveColorComponentMasksForClear[2].any(), mActiveColorComponentMasksForClear[3].any()); |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 1112 | |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 1113 | mFramebuffer.release(contextVk); |
Jamie Madill | 49ac74b | 2017-12-21 14:42:33 -0500 | [diff] [blame] | 1114 | |
Jamie Madill | 316c606 | 2018-05-29 10:49:45 -0400 | [diff] [blame] | 1115 | // Will freeze the current set of dependencies on this FBO. The next time we render we will |
Jamie Madill | a5e0607 | 2018-05-18 14:36:05 -0400 | [diff] [blame] | 1116 | // create a new entry in the command graph. |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 1117 | mFramebuffer.finishCurrentCommands(contextVk); |
Jamie Madill | 7210656 | 2017-03-24 14:18:50 -0400 | [diff] [blame] | 1118 | |
Jamie Madill | dbc605c | 2019-01-04 16:39:14 -0500 | [diff] [blame] | 1119 | // Notify the ContextVk to update the pipeline desc. |
| 1120 | updateRenderPassDesc(); |
| 1121 | contextVk->onFramebufferChange(mRenderPassDesc); |
Jamie Madill | 19fa1c6 | 2018-03-08 09:47:21 -0500 | [diff] [blame] | 1122 | |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 1123 | return angle::Result::Continue; |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1124 | } |
| 1125 | |
Jamie Madill | dbc605c | 2019-01-04 16:39:14 -0500 | [diff] [blame] | 1126 | void FramebufferVk::updateRenderPassDesc() |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1127 | { |
Jamie Madill | dbc605c | 2019-01-04 16:39:14 -0500 | [diff] [blame] | 1128 | mRenderPassDesc = {}; |
| 1129 | mRenderPassDesc.setSamples(getSamples()); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1130 | |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1131 | const auto &colorRenderTargets = mRenderTargetCache.getColors(); |
| 1132 | const gl::DrawBufferMask enabledDrawBuffers = mState.getEnabledDrawBuffers(); |
| 1133 | for (size_t colorIndexGL = 0; colorIndexGL < enabledDrawBuffers.size(); ++colorIndexGL) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1134 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1135 | if (enabledDrawBuffers[colorIndexGL]) |
| 1136 | { |
| 1137 | RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL]; |
| 1138 | ASSERT(colorRenderTarget); |
| 1139 | mRenderPassDesc.packColorAttachment( |
| 1140 | colorIndexGL, colorRenderTarget->getImage().getFormat().angleFormatID); |
| 1141 | } |
| 1142 | else |
| 1143 | { |
| 1144 | mRenderPassDesc.packColorAttachmentGap(colorIndexGL); |
| 1145 | } |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1146 | } |
| 1147 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 1148 | RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil(); |
| 1149 | if (depthStencilRenderTarget) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1150 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1151 | mRenderPassDesc.packDepthStencilAttachment( |
| 1152 | depthStencilRenderTarget->getImage().getFormat().angleFormatID); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1153 | } |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1154 | } |
| 1155 | |
Jamie Madill | 2106102 | 2018-07-12 23:56:30 -0400 | [diff] [blame] | 1156 | angle::Result FramebufferVk::getFramebuffer(ContextVk *contextVk, vk::Framebuffer **framebufferOut) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1157 | { |
| 1158 | // If we've already created our cached Framebuffer, return it. |
Jamie Madill | dd43e6c | 2017-03-24 14:18:49 -0400 | [diff] [blame] | 1159 | if (mFramebuffer.valid()) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1160 | { |
Jamie Madill | e8dd079 | 2018-09-27 15:04:27 -0400 | [diff] [blame] | 1161 | *framebufferOut = &mFramebuffer.getFramebuffer(); |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 1162 | return angle::Result::Continue; |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1163 | } |
| 1164 | |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 1165 | vk::RenderPass *compatibleRenderPass = nullptr; |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 1166 | ANGLE_TRY(contextVk->getCompatibleRenderPass(mRenderPassDesc, &compatibleRenderPass)); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1167 | |
| 1168 | // If we've a Framebuffer provided by a Surface (default FBO/backbuffer), query it. |
| 1169 | if (mBackbuffer) |
| 1170 | { |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 1171 | return mBackbuffer->getCurrentFramebuffer(contextVk, *compatibleRenderPass, framebufferOut); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1172 | } |
| 1173 | |
| 1174 | // Gather VkImageViews over all FBO attachments, also size of attached region. |
| 1175 | std::vector<VkImageView> attachments; |
| 1176 | gl::Extents attachmentsSize; |
| 1177 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 1178 | const auto &colorRenderTargets = mRenderTargetCache.getColors(); |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1179 | for (size_t colorIndexGL : mState.getEnabledDrawBuffers()) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1180 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1181 | RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL]; |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 1182 | ASSERT(colorRenderTarget); |
Shahbaz Youssefi | f83a28a | 2018-12-09 03:48:34 +0100 | [diff] [blame] | 1183 | attachments.push_back(colorRenderTarget->getDrawImageView()->getHandle()); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1184 | |
Shahbaz Youssefi | 6854940 | 2019-03-25 23:30:49 -0400 | [diff] [blame] | 1185 | ASSERT(attachmentsSize.empty() || attachmentsSize == colorRenderTarget->getExtents()); |
| 1186 | attachmentsSize = colorRenderTarget->getExtents(); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1187 | } |
| 1188 | |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 1189 | RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil(); |
| 1190 | if (depthStencilRenderTarget) |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1191 | { |
Shahbaz Youssefi | f83a28a | 2018-12-09 03:48:34 +0100 | [diff] [blame] | 1192 | attachments.push_back(depthStencilRenderTarget->getDrawImageView()->getHandle()); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1193 | |
Jamie Madill | bc54342 | 2018-03-30 10:43:19 -0400 | [diff] [blame] | 1194 | ASSERT(attachmentsSize.empty() || |
Shahbaz Youssefi | 6854940 | 2019-03-25 23:30:49 -0400 | [diff] [blame] | 1195 | attachmentsSize == depthStencilRenderTarget->getExtents()); |
| 1196 | attachmentsSize = depthStencilRenderTarget->getExtents(); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1197 | } |
| 1198 | |
Shahbaz Youssefi | 06270c9 | 2018-10-03 17:00:25 -0400 | [diff] [blame] | 1199 | VkFramebufferCreateInfo framebufferInfo = {}; |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1200 | |
| 1201 | framebufferInfo.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO; |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1202 | framebufferInfo.flags = 0; |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 1203 | framebufferInfo.renderPass = compatibleRenderPass->getHandle(); |
Jamie Madill | ab9f9c3 | 2017-01-17 17:47:34 -0500 | [diff] [blame] | 1204 | framebufferInfo.attachmentCount = static_cast<uint32_t>(attachments.size()); |
| 1205 | framebufferInfo.pAttachments = attachments.data(); |
| 1206 | framebufferInfo.width = static_cast<uint32_t>(attachmentsSize.width); |
| 1207 | framebufferInfo.height = static_cast<uint32_t>(attachmentsSize.height); |
| 1208 | framebufferInfo.layers = 1; |
| 1209 | |
Jamie Madill | 2106102 | 2018-07-12 23:56:30 -0400 | [diff] [blame] | 1210 | ANGLE_TRY(mFramebuffer.init(contextVk, framebufferInfo)); |
Jamie Madill | 5deea72 | 2017-02-16 10:44:46 -0500 | [diff] [blame] | 1211 | |
Jamie Madill | e8dd079 | 2018-09-27 15:04:27 -0400 | [diff] [blame] | 1212 | *framebufferOut = &mFramebuffer.getFramebuffer(); |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 1213 | return angle::Result::Continue; |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 1214 | } |
| 1215 | |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 1216 | angle::Result FramebufferVk::clearWithRenderPassOp( |
| 1217 | ContextVk *contextVk, |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 1218 | const gl::Rectangle &clearArea, |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1219 | gl::DrawBufferMask clearColorBuffers, |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 1220 | bool clearDepth, |
| 1221 | bool clearStencil, |
| 1222 | const VkClearColorValue &clearColorValue, |
| 1223 | const VkClearDepthStencilValue &clearDepthStencilValue) |
| 1224 | { |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 1225 | // Start a new render pass if: |
| 1226 | // |
| 1227 | // - no render pass has started, |
| 1228 | // - there is a render pass started but it contains commands; we cannot modify its ops, so new |
| 1229 | // render pass is needed, |
| 1230 | // - the current render area doesn't match the clear area. We need the render area to be |
| 1231 | // exactly as specified by the scissor for the loadOp to clear only that area. See |
| 1232 | // onScissorChange for more information. |
| 1233 | |
| 1234 | if (!mFramebuffer.valid() || !mFramebuffer.renderPassStartedButEmpty() || |
| 1235 | mFramebuffer.getRenderPassRenderArea() != clearArea) |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1236 | { |
| 1237 | vk::CommandBuffer *commandBuffer; |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 1238 | ANGLE_TRY(startNewRenderPass(contextVk, clearArea, &commandBuffer)); |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1239 | } |
| 1240 | |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1241 | size_t attachmentIndexVk = 0; |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1242 | |
| 1243 | // Go through clearColorBuffers and set the appropriate loadOp and clear values. |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1244 | for (size_t colorIndexGL : mState.getEnabledDrawBuffers()) |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1245 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1246 | if (clearColorBuffers.test(colorIndexGL)) |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1247 | { |
| 1248 | RenderTargetVk *renderTarget = getColorReadRenderTarget(); |
| 1249 | |
| 1250 | // If the render target doesn't have alpha, but its emulated format has it, clear the |
| 1251 | // alpha to 1. |
| 1252 | VkClearColorValue value = clearColorValue; |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1253 | if (mEmulatedAlphaAttachmentMask[colorIndexGL]) |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1254 | { |
| 1255 | SetEmulatedAlphaValue(renderTarget->getImageFormat(), &value); |
| 1256 | } |
| 1257 | |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1258 | mFramebuffer.clearRenderPassColorAttachment(attachmentIndexVk, value); |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1259 | } |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1260 | ++attachmentIndexVk; |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1261 | } |
| 1262 | |
| 1263 | // Set the appropriate loadOp and clear values for depth and stencil. |
| 1264 | RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil(); |
| 1265 | if (depthStencilRenderTarget) |
| 1266 | { |
| 1267 | if (clearDepth) |
| 1268 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1269 | mFramebuffer.clearRenderPassDepthAttachment(attachmentIndexVk, |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1270 | clearDepthStencilValue.depth); |
| 1271 | } |
| 1272 | |
| 1273 | if (clearStencil) |
| 1274 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1275 | mFramebuffer.clearRenderPassStencilAttachment(attachmentIndexVk, |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1276 | clearDepthStencilValue.stencil); |
| 1277 | } |
| 1278 | } |
| 1279 | |
| 1280 | return angle::Result::Continue; |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 1281 | } |
| 1282 | |
Jamie Madill | 2106102 | 2018-07-12 23:56:30 -0400 | [diff] [blame] | 1283 | angle::Result FramebufferVk::clearWithDraw(ContextVk *contextVk, |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 1284 | const gl::Rectangle &clearArea, |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1285 | gl::DrawBufferMask clearColorBuffers, |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 1286 | bool clearStencil, |
| 1287 | VkColorComponentFlags colorMaskFlags, |
| 1288 | uint8_t stencilMask, |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1289 | const VkClearColorValue &clearColorValue, |
Shahbaz Youssefi | 2249d4a | 2019-04-05 16:48:55 -0400 | [diff] [blame] | 1290 | uint8_t clearStencilValue) |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 1291 | { |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 1292 | UtilsVk::ClearFramebufferParameters params = {}; |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 1293 | params.clearArea = clearArea; |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 1294 | params.colorClearValue = clearColorValue; |
Shahbaz Youssefi | 2249d4a | 2019-04-05 16:48:55 -0400 | [diff] [blame] | 1295 | params.stencilClearValue = clearStencilValue; |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 1296 | params.stencilMask = stencilMask; |
| 1297 | |
| 1298 | params.clearColor = true; |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 1299 | params.clearStencil = clearStencil; |
Shahbaz Youssefi | e321940 | 2018-12-08 16:54:14 +0100 | [diff] [blame] | 1300 | |
Shahbaz Youssefi | 4399701 | 2019-03-30 23:24:01 -0400 | [diff] [blame] | 1301 | const auto &colorRenderTargets = mRenderTargetCache.getColors(); |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1302 | for (size_t colorIndexGL : clearColorBuffers) |
Shahbaz Youssefi | 4399701 | 2019-03-30 23:24:01 -0400 | [diff] [blame] | 1303 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1304 | const RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL]; |
Shahbaz Youssefi | 4399701 | 2019-03-30 23:24:01 -0400 | [diff] [blame] | 1305 | ASSERT(colorRenderTarget); |
| 1306 | |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1307 | params.colorFormat = &colorRenderTarget->getImage().getFormat().imageFormat(); |
| 1308 | params.colorAttachmentIndexGL = colorIndexGL; |
| 1309 | params.colorMaskFlags = colorMaskFlags; |
| 1310 | if (mEmulatedAlphaAttachmentMask[colorIndexGL]) |
Shahbaz Youssefi | 4399701 | 2019-03-30 23:24:01 -0400 | [diff] [blame] | 1311 | { |
| 1312 | params.colorMaskFlags &= ~VK_COLOR_COMPONENT_A_BIT; |
| 1313 | } |
| 1314 | |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 1315 | ANGLE_TRY(contextVk->getUtils().clearFramebuffer(contextVk, this, params)); |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 1316 | |
Shahbaz Youssefi | 2249d4a | 2019-04-05 16:48:55 -0400 | [diff] [blame] | 1317 | // Clear stencil only once! |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 1318 | params.clearStencil = false; |
| 1319 | } |
| 1320 | |
Shahbaz Youssefi | 2249d4a | 2019-04-05 16:48:55 -0400 | [diff] [blame] | 1321 | // If there was no color clear, clear stencil alone. |
| 1322 | if (params.clearStencil) |
Shahbaz Youssefi | f6c937f | 2019-04-02 17:04:08 -0400 | [diff] [blame] | 1323 | { |
| 1324 | params.clearColor = false; |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 1325 | ANGLE_TRY(contextVk->getUtils().clearFramebuffer(contextVk, this, params)); |
Shahbaz Youssefi | 4399701 | 2019-03-30 23:24:01 -0400 | [diff] [blame] | 1326 | } |
| 1327 | |
| 1328 | return angle::Result::Continue; |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 1329 | } |
| 1330 | |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 1331 | angle::Result FramebufferVk::getSamplePosition(const gl::Context *context, |
| 1332 | size_t index, |
| 1333 | GLfloat *xy) const |
JiangYizhou | bddc46b | 2016-12-09 09:50:51 +0800 | [diff] [blame] | 1334 | { |
Jamie Madill | 64b7c4f | 2018-10-19 11:38:04 -0400 | [diff] [blame] | 1335 | ANGLE_VK_UNREACHABLE(vk::GetImpl(context)); |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 1336 | return angle::Result::Stop; |
JiangYizhou | bddc46b | 2016-12-09 09:50:51 +0800 | [diff] [blame] | 1337 | } |
| 1338 | |
Jamie Madill | d1249de | 2018-08-28 16:58:53 -0400 | [diff] [blame] | 1339 | angle::Result FramebufferVk::startNewRenderPass(ContextVk *contextVk, |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 1340 | const gl::Rectangle &renderArea, |
Shahbaz Youssefi | 2660b50 | 2019-03-21 12:08:40 -0400 | [diff] [blame] | 1341 | vk::CommandBuffer **commandBufferOut) |
Jamie Madill | d1249de | 2018-08-28 16:58:53 -0400 | [diff] [blame] | 1342 | { |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 1343 | vk::Framebuffer *framebuffer = nullptr; |
Jamie Madill | 2106102 | 2018-07-12 23:56:30 -0400 | [diff] [blame] | 1344 | ANGLE_TRY(getFramebuffer(contextVk, &framebuffer)); |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 1345 | |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 1346 | vk::AttachmentOpsArray renderPassAttachmentOps; |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 1347 | std::vector<VkClearValue> attachmentClearValues; |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 1348 | |
Shahbaz Youssefi | 2660b50 | 2019-03-21 12:08:40 -0400 | [diff] [blame] | 1349 | vk::CommandBuffer *writeCommands = nullptr; |
Jamie Madill | e8dd079 | 2018-09-27 15:04:27 -0400 | [diff] [blame] | 1350 | ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &writeCommands)); |
Jamie Madill | e4c5a23 | 2018-03-02 21:00:31 -0500 | [diff] [blame] | 1351 | |
Jamie Madill | 49ac74b | 2017-12-21 14:42:33 -0500 | [diff] [blame] | 1352 | // Initialize RenderPass info. |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 1353 | const auto &colorRenderTargets = mRenderTargetCache.getColors(); |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1354 | for (size_t colorIndexGL : mState.getEnabledDrawBuffers()) |
Jamie Madill | 4c26fc2 | 2017-02-24 11:04:10 -0500 | [diff] [blame] | 1355 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1356 | RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL]; |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 1357 | ASSERT(colorRenderTarget); |
Jamie Madill | 49ac74b | 2017-12-21 14:42:33 -0500 | [diff] [blame] | 1358 | |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1359 | ANGLE_TRY(colorRenderTarget->onColorDraw(contextVk, &mFramebuffer, writeCommands)); |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 1360 | |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1361 | renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(), |
| 1362 | VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL, |
| 1363 | VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL); |
| 1364 | attachmentClearValues.emplace_back(kUninitializedClearValue); |
Jamie Madill | 66546be | 2018-03-08 09:47:20 -0500 | [diff] [blame] | 1365 | } |
| 1366 | |
| 1367 | RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil(); |
| 1368 | if (depthStencilRenderTarget) |
| 1369 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1370 | ANGLE_TRY( |
| 1371 | depthStencilRenderTarget->onDepthStencilDraw(contextVk, &mFramebuffer, writeCommands)); |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 1372 | |
Shahbaz Youssefi | db4ed31 | 2019-03-29 00:32:45 -0400 | [diff] [blame] | 1373 | renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(), |
| 1374 | VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL, |
| 1375 | VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL); |
| 1376 | attachmentClearValues.emplace_back(kUninitializedClearValue); |
Jamie Madill | 49ac74b | 2017-12-21 14:42:33 -0500 | [diff] [blame] | 1377 | } |
| 1378 | |
Jamie Madill | dbc605c | 2019-01-04 16:39:14 -0500 | [diff] [blame] | 1379 | return mFramebuffer.beginRenderPass(contextVk, *framebuffer, renderArea, mRenderPassDesc, |
Shahbaz Youssefi | 0c128e1 | 2019-03-25 23:50:14 -0400 | [diff] [blame] | 1380 | renderPassAttachmentOps, attachmentClearValues, |
| 1381 | commandBufferOut); |
Jamie Madill | df68a6f | 2017-01-13 17:29:53 -0500 | [diff] [blame] | 1382 | } |
| 1383 | |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1384 | void FramebufferVk::updateActiveColorMasks(size_t colorIndexGL, bool r, bool g, bool b, bool a) |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 1385 | { |
Shahbaz Youssefi | 9fa248e | 2019-05-06 14:55:18 -0400 | [diff] [blame] | 1386 | mActiveColorComponentMasksForClear[0].set(colorIndexGL, r); |
| 1387 | mActiveColorComponentMasksForClear[1].set(colorIndexGL, g); |
| 1388 | mActiveColorComponentMasksForClear[2].set(colorIndexGL, b); |
| 1389 | mActiveColorComponentMasksForClear[3].set(colorIndexGL, a); |
Luc Ferron | 5fd3693 | 2018-06-19 14:55:50 -0400 | [diff] [blame] | 1390 | } |
| 1391 | |
Shahbaz Youssefi | e321940 | 2018-12-08 16:54:14 +0100 | [diff] [blame] | 1392 | const gl::DrawBufferMask &FramebufferVk::getEmulatedAlphaAttachmentMask() const |
Luc Ferron | 5fd3693 | 2018-06-19 14:55:50 -0400 | [diff] [blame] | 1393 | { |
| 1394 | return mEmulatedAlphaAttachmentMask; |
Jamie Madill | 9aef367 | 2018-04-27 11:45:06 -0400 | [diff] [blame] | 1395 | } |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 1396 | |
Jamie Madill | 2106102 | 2018-07-12 23:56:30 -0400 | [diff] [blame] | 1397 | angle::Result FramebufferVk::readPixelsImpl(ContextVk *contextVk, |
| 1398 | const gl::Rectangle &area, |
| 1399 | const PackPixelsParams &packPixelsParams, |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 1400 | VkImageAspectFlagBits copyAspectFlags, |
Jamie Madill | 2106102 | 2018-07-12 23:56:30 -0400 | [diff] [blame] | 1401 | RenderTargetVk *renderTarget, |
| 1402 | void *pixels) |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 1403 | { |
Tobin Ehlis | 4a41914 | 2019-02-05 08:50:30 -0700 | [diff] [blame] | 1404 | TRACE_EVENT0("gpu.angle", "FramebufferVk::readPixelsImpl"); |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame] | 1405 | |
Shahbaz Youssefi | b16d69c | 2019-05-13 16:28:27 -0400 | [diff] [blame] | 1406 | RendererVk *renderer = contextVk->getRenderer(); |
| 1407 | |
Shahbaz Youssefi | 2660b50 | 2019-03-21 12:08:40 -0400 | [diff] [blame] | 1408 | vk::CommandBuffer *commandBuffer = nullptr; |
Jamie Madill | e8dd079 | 2018-09-27 15:04:27 -0400 | [diff] [blame] | 1409 | ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer)); |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame] | 1410 | |
Jamie Madill | bcf467f | 2018-05-23 09:46:00 -0400 | [diff] [blame] | 1411 | // Note that although we're reading from the image, we need to update the layout below. |
Shahbaz Youssefi | 7dafe3e | 2019-01-28 11:39:15 -0500 | [diff] [blame] | 1412 | vk::ImageHelper *srcImage = |
| 1413 | renderTarget->getImageForRead(&mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer); |
Jamie Madill | bcf467f | 2018-05-23 09:46:00 -0400 | [diff] [blame] | 1414 | |
Jamie Madill | 0631e19 | 2019-04-18 16:09:12 -0400 | [diff] [blame] | 1415 | const angle::Format *readFormat = &srcImage->getFormat().imageFormat(); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 1416 | |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 1417 | if (copyAspectFlags != VK_IMAGE_ASPECT_COLOR_BIT) |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 1418 | { |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 1419 | readFormat = &GetDepthStencilImageToBufferFormat(*readFormat, copyAspectFlags); |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 1420 | } |
| 1421 | |
Shahbaz Youssefi | b16d69c | 2019-05-13 16:28:27 -0400 | [diff] [blame] | 1422 | size_t level = renderTarget->getLevelIndex(); |
| 1423 | size_t layer = renderTarget->getLayerIndex(); |
| 1424 | VkOffset3D srcOffset = {area.x, area.y, 0}; |
| 1425 | VkExtent3D srcExtent = {static_cast<uint32_t>(area.width), static_cast<uint32_t>(area.height), |
| 1426 | 1}; |
| 1427 | |
| 1428 | // If the source image is multisampled, we need to resolve it into a temporary image before |
| 1429 | // performing a readback. |
| 1430 | bool isMultisampled = srcImage->getSamples() > 1; |
| 1431 | vk::Scoped<vk::ImageHelper> resolvedImage(contextVk->getDevice()); |
| 1432 | if (isMultisampled) |
| 1433 | { |
| 1434 | ANGLE_TRY(resolvedImage.get().init2DStaging( |
| 1435 | contextVk, renderer->getMemoryProperties(), gl::Extents(area.width, area.height, 1), |
| 1436 | srcImage->getFormat(), |
| 1437 | VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT, 1)); |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 1438 | resolvedImage.get().updateQueueSerial(contextVk->getCurrentQueueSerial()); |
Shahbaz Youssefi | b16d69c | 2019-05-13 16:28:27 -0400 | [diff] [blame] | 1439 | |
Shahbaz Youssefi | f2a1c38 | 2019-05-21 16:32:49 -0400 | [diff] [blame^] | 1440 | // Note: resolve only works on color images (not depth/stencil). |
| 1441 | // |
| 1442 | // TODO: Currently, depth/stencil blit can perform a depth/stencil readback, but that code |
| 1443 | // path will be optimized away. http://anglebug.com/3200 |
Shahbaz Youssefi | b16d69c | 2019-05-13 16:28:27 -0400 | [diff] [blame] | 1444 | ASSERT(copyAspectFlags == VK_IMAGE_ASPECT_COLOR_BIT); |
| 1445 | |
| 1446 | VkImageResolve resolveRegion = {}; |
| 1447 | resolveRegion.srcSubresource.aspectMask = copyAspectFlags; |
| 1448 | resolveRegion.srcSubresource.mipLevel = level; |
| 1449 | resolveRegion.srcSubresource.baseArrayLayer = layer; |
| 1450 | resolveRegion.srcSubresource.layerCount = 1; |
| 1451 | resolveRegion.srcOffset = srcOffset; |
| 1452 | resolveRegion.dstSubresource.aspectMask = copyAspectFlags; |
| 1453 | resolveRegion.dstSubresource.mipLevel = 0; |
| 1454 | resolveRegion.dstSubresource.baseArrayLayer = 0; |
| 1455 | resolveRegion.dstSubresource.layerCount = 1; |
| 1456 | resolveRegion.dstOffset = {}; |
| 1457 | resolveRegion.extent = srcExtent; |
| 1458 | |
| 1459 | srcImage->resolve(&resolvedImage.get(), resolveRegion, commandBuffer); |
| 1460 | |
| 1461 | resolvedImage.get().changeLayout(copyAspectFlags, vk::ImageLayout::TransferSrc, |
| 1462 | commandBuffer); |
| 1463 | |
| 1464 | // Make the resolved image the target of buffer copy. |
| 1465 | srcImage = &resolvedImage.get(); |
| 1466 | level = 0; |
| 1467 | layer = 0; |
| 1468 | srcOffset = {0, 0, 0}; |
| 1469 | } |
| 1470 | |
Jamie Madill | b980c56 | 2018-11-27 11:34:27 -0500 | [diff] [blame] | 1471 | VkBuffer bufferHandle = VK_NULL_HANDLE; |
| 1472 | uint8_t *readPixelBuffer = nullptr; |
Jamie Madill | 4c31083 | 2018-08-29 13:43:17 -0400 | [diff] [blame] | 1473 | VkDeviceSize stagingOffset = 0; |
Jamie Madill | b980c56 | 2018-11-27 11:34:27 -0500 | [diff] [blame] | 1474 | size_t allocationSize = readFormat->pixelBytes * area.width * area.height; |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 1475 | |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 1476 | ANGLE_TRY(mReadPixelBuffer.allocate(contextVk, allocationSize, &readPixelBuffer, &bufferHandle, |
Shahbaz Youssefi | 254b32c | 2018-11-26 11:58:03 -0500 | [diff] [blame] | 1477 | &stagingOffset, nullptr)); |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 1478 | |
Shahbaz Youssefi | 06270c9 | 2018-10-03 17:00:25 -0400 | [diff] [blame] | 1479 | VkBufferImageCopy region = {}; |
Shahbaz Youssefi | b16d69c | 2019-05-13 16:28:27 -0400 | [diff] [blame] | 1480 | region.bufferImageHeight = srcExtent.height; |
Jamie Madill | 4c31083 | 2018-08-29 13:43:17 -0400 | [diff] [blame] | 1481 | region.bufferOffset = stagingOffset; |
Shahbaz Youssefi | b16d69c | 2019-05-13 16:28:27 -0400 | [diff] [blame] | 1482 | region.bufferRowLength = srcExtent.width; |
| 1483 | region.imageExtent = srcExtent; |
| 1484 | region.imageOffset = srcOffset; |
Luc Ferron | 1617e69 | 2018-07-11 11:08:19 -0400 | [diff] [blame] | 1485 | region.imageSubresource.aspectMask = copyAspectFlags; |
Shahbaz Youssefi | b16d69c | 2019-05-13 16:28:27 -0400 | [diff] [blame] | 1486 | region.imageSubresource.baseArrayLayer = layer; |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 1487 | region.imageSubresource.layerCount = 1; |
Shahbaz Youssefi | b16d69c | 2019-05-13 16:28:27 -0400 | [diff] [blame] | 1488 | region.imageSubresource.mipLevel = level; |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 1489 | |
Jamie Madill | bcf467f | 2018-05-23 09:46:00 -0400 | [diff] [blame] | 1490 | commandBuffer->copyImageToBuffer(srcImage->getImage(), srcImage->getCurrentLayout(), |
| 1491 | bufferHandle, 1, ®ion); |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 1492 | |
| 1493 | // Triggers a full finish. |
| 1494 | // TODO(jmadill): Don't block on asynchronous readback. |
Geoff Lang | 892d180 | 2019-03-27 14:21:34 -0400 | [diff] [blame] | 1495 | ANGLE_TRY(contextVk->finishImpl()); |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 1496 | |
Luc Ferron | 534b00d | 2018-05-18 08:16:53 -0400 | [diff] [blame] | 1497 | // The buffer we copied to needs to be invalidated before we read from it because its not been |
| 1498 | // created with the host coherent bit. |
Jamie Madill | d754eb5 | 2018-07-19 14:55:03 -0400 | [diff] [blame] | 1499 | ANGLE_TRY(mReadPixelBuffer.invalidate(contextVk)); |
Yuly Novikov | 6c6c76c | 2018-05-17 18:45:06 +0000 | [diff] [blame] | 1500 | |
Jamie Madill | b436aac | 2018-07-18 17:23:48 -0400 | [diff] [blame] | 1501 | PackPixels(packPixelsParams, *readFormat, area.width * readFormat->pixelBytes, readPixelBuffer, |
Rafael Cintron | 05a449a | 2018-06-20 18:08:04 -0700 | [diff] [blame] | 1502 | static_cast<uint8_t *>(pixels)); |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 1503 | |
Jamie Madill | 7c985f5 | 2018-11-29 18:16:17 -0500 | [diff] [blame] | 1504 | return angle::Result::Continue; |
Luc Ferron | 018709f | 2018-05-10 13:53:11 -0400 | [diff] [blame] | 1505 | } |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame] | 1506 | |
Shahbaz Youssefi | 6854940 | 2019-03-25 23:30:49 -0400 | [diff] [blame] | 1507 | gl::Extents FramebufferVk::getReadImageExtents() const |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame] | 1508 | { |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 1509 | ASSERT(getColorReadRenderTarget()->getExtents().width == mState.getDimensions().width); |
| 1510 | ASSERT(getColorReadRenderTarget()->getExtents().height == mState.getDimensions().height); |
| 1511 | |
Shahbaz Youssefi | 6854940 | 2019-03-25 23:30:49 -0400 | [diff] [blame] | 1512 | return getColorReadRenderTarget()->getExtents(); |
Jamie Madill | 5867501 | 2018-05-22 14:54:07 -0400 | [diff] [blame] | 1513 | } |
Jamie Madill | 502d2e2 | 2018-11-01 11:06:23 -0400 | [diff] [blame] | 1514 | |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 1515 | gl::Rectangle FramebufferVk::getCompleteRenderArea() const |
| 1516 | { |
| 1517 | return gl::Rectangle(0, 0, mState.getDimensions().width, mState.getDimensions().height); |
| 1518 | } |
| 1519 | |
| 1520 | gl::Rectangle FramebufferVk::getScissoredRenderArea(ContextVk *contextVk) const |
| 1521 | { |
| 1522 | const gl::Rectangle renderArea(0, 0, mState.getDimensions().width, |
| 1523 | mState.getDimensions().height); |
| 1524 | bool invertViewport = contextVk->isViewportFlipEnabledForDrawFBO(); |
| 1525 | |
| 1526 | return ClipRectToScissor(contextVk->getState(), renderArea, invertViewport); |
| 1527 | } |
| 1528 | |
| 1529 | void FramebufferVk::onScissorChange(ContextVk *contextVk) |
| 1530 | { |
| 1531 | gl::Rectangle scissoredRenderArea = getScissoredRenderArea(contextVk); |
| 1532 | |
| 1533 | // If the scissor has grown beyond the previous scissoredRenderArea, make sure the render pass |
| 1534 | // is restarted. Otherwise, we can continue using the same renderpass area. |
| 1535 | // |
| 1536 | // Without a scissor, the render pass area covers the whole of the framebuffer. With a |
| 1537 | // scissored clear, the render pass area could be smaller than the framebuffer size. When the |
| 1538 | // scissor changes, if the scissor area is completely encompassed by the render pass area, it's |
| 1539 | // possible to continue using the same render pass. However, if the current render pass area |
| 1540 | // is too small, we need to start a new one. The latter can happen if a scissored clear starts |
| 1541 | // a render pass, the scissor is disabled and a draw call is issued to affect the whole |
| 1542 | // framebuffer. |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 1543 | mFramebuffer.updateQueueSerial(contextVk->getCurrentQueueSerial()); |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 1544 | if (mFramebuffer.hasStartedRenderPass() && |
| 1545 | !mFramebuffer.getRenderPassRenderArea().encloses(scissoredRenderArea)) |
| 1546 | { |
Geoff Lang | ee244c7 | 2019-05-06 10:30:18 -0400 | [diff] [blame] | 1547 | mFramebuffer.finishCurrentCommands(contextVk); |
Shahbaz Youssefi | 127990f | 2019-04-04 13:52:04 -0400 | [diff] [blame] | 1548 | } |
| 1549 | } |
| 1550 | |
Jamie Madill | 502d2e2 | 2018-11-01 11:06:23 -0400 | [diff] [blame] | 1551 | RenderTargetVk *FramebufferVk::getFirstRenderTarget() const |
| 1552 | { |
| 1553 | for (auto *renderTarget : mRenderTargetCache.getColors()) |
| 1554 | { |
| 1555 | if (renderTarget) |
| 1556 | { |
| 1557 | return renderTarget; |
| 1558 | } |
| 1559 | } |
| 1560 | |
| 1561 | return mRenderTargetCache.getDepthStencil(); |
| 1562 | } |
| 1563 | |
| 1564 | GLint FramebufferVk::getSamples() const |
| 1565 | { |
| 1566 | RenderTargetVk *firstRT = getFirstRenderTarget(); |
| 1567 | return firstRT ? firstRT->getImage().getSamples() : 0; |
| 1568 | } |
| 1569 | |
Jamie Madill | 9e54b5a | 2016-05-25 12:57:39 -0400 | [diff] [blame] | 1570 | } // namespace rx |