blob: 43cefffc11e60219d532c2f74ca0f97c73c5140d [file] [log] [blame]
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001//
2// Copyright 2016 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6// FramebufferVk.cpp:
7// Implements the class methods for FramebufferVk.
8//
9
10#include "libANGLE/renderer/vulkan/FramebufferVk.h"
11
Jamie Madill7b57b9d2017-01-13 09:33:38 -050012#include <vulkan/vulkan.h>
Jamie Madill231c7f52017-04-26 13:45:37 -040013#include <array>
Jamie Madill7b57b9d2017-01-13 09:33:38 -050014
Jamie Madill9e54b5a2016-05-25 12:57:39 -040015#include "common/debug.h"
Jamie Madillc564c072017-06-01 12:45:42 -040016#include "libANGLE/Context.h"
17#include "libANGLE/Display.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050018#include "libANGLE/formatutils.h"
19#include "libANGLE/renderer/renderer_utils.h"
Jamie Madill1f46bc12018-02-20 16:09:43 -050020#include "libANGLE/renderer/vulkan/CommandGraph.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050021#include "libANGLE/renderer/vulkan/ContextVk.h"
Jamie Madill5deea722017-02-16 10:44:46 -050022#include "libANGLE/renderer/vulkan/DisplayVk.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050023#include "libANGLE/renderer/vulkan/RenderTargetVk.h"
24#include "libANGLE/renderer/vulkan/RendererVk.h"
25#include "libANGLE/renderer/vulkan/SurfaceVk.h"
Jamie Madill3c424b42018-01-19 12:35:09 -050026#include "libANGLE/renderer/vulkan/vk_format_utils.h"
Tobin Ehlis4a419142019-02-05 08:50:30 -070027#include "third_party/trace_event/trace_event.h"
Jamie Madill9e54b5a2016-05-25 12:57:39 -040028
29namespace rx
30{
31
Jamie Madill7b57b9d2017-01-13 09:33:38 -050032namespace
33{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -040034// The value to assign an alpha channel that's emulated. The type is unsigned int, though it will
35// automatically convert to the actual data type.
36constexpr unsigned int kEmulatedAlphaValue = 1;
37
Luc Ferron534b00d2018-05-18 08:16:53 -040038constexpr size_t kMinReadPixelsBufferSize = 128000;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -040039// Clear values are only used when loadOp=Clear is set in clearWithRenderPassOp. When starting a
40// new render pass, the clear value is set to an unlikely value (bright pink) to stand out better
41// in case of a bug.
42constexpr VkClearValue kUninitializedClearValue = {{{0.95, 0.05, 0.95, 0.95}}};
Luc Ferron534b00d2018-05-18 08:16:53 -040043
Jamie Madill66546be2018-03-08 09:47:20 -050044const gl::InternalFormat &GetReadAttachmentInfo(const gl::Context *context,
45 RenderTargetVk *renderTarget)
Jamie Madill7b57b9d2017-01-13 09:33:38 -050046{
Jamie Madillbc543422018-03-30 10:43:19 -040047 GLenum implFormat =
Jamie Madill0631e192019-04-18 16:09:12 -040048 renderTarget->getImageFormat().imageFormat().fboImplementationInternalFormat;
Jamie Madill66546be2018-03-08 09:47:20 -050049 return gl::GetSizedInternalFormatInfo(implFormat);
Jamie Madill7b57b9d2017-01-13 09:33:38 -050050}
Luc Ferron26581112018-06-21 09:43:08 -040051
Jamie Madilld754eb52018-07-19 14:55:03 -040052bool ClipToRenderTarget(const gl::Rectangle &area,
53 RenderTargetVk *renderTarget,
54 gl::Rectangle *rectOut)
55{
Shahbaz Youssefi68549402019-03-25 23:30:49 -040056 const gl::Extents renderTargetExtents = renderTarget->getExtents();
Jamie Madilld754eb52018-07-19 14:55:03 -040057 gl::Rectangle renderTargetRect(0, 0, renderTargetExtents.width, renderTargetExtents.height);
58 return ClipRectangle(area, renderTargetRect, rectOut);
59}
60
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050061bool HasSrcAndDstBlitProperties(RendererVk *renderer,
Luc Ferron26581112018-06-21 09:43:08 -040062 RenderTargetVk *srcRenderTarget,
63 RenderTargetVk *dstRenderTarget)
64{
Jamie Madill0631e192019-04-18 16:09:12 -040065 const VkFormat srcFormat = srcRenderTarget->getImageFormat().vkImageFormat;
66 const VkFormat dstFormat = dstRenderTarget->getImageFormat().vkImageFormat;
Luc Ferron26581112018-06-21 09:43:08 -040067
68 // Verifies if the draw and read images have the necessary prerequisites for blitting.
Jamie Madill0631e192019-04-18 16:09:12 -040069 return renderer->hasImageFormatFeatureBits(srcFormat, VK_FORMAT_FEATURE_BLIT_SRC_BIT) &&
70 renderer->hasImageFormatFeatureBits(dstFormat, VK_FORMAT_FEATURE_BLIT_DST_BIT);
Luc Ferron26581112018-06-21 09:43:08 -040071}
Jamie Madillb436aac2018-07-18 17:23:48 -040072
73// Special rules apply to VkBufferImageCopy with depth/stencil. The components are tightly packed
74// into a depth or stencil section of the destination buffer. See the spec:
75// https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkBufferImageCopy.html
76const angle::Format &GetDepthStencilImageToBufferFormat(const angle::Format &imageFormat,
77 VkImageAspectFlagBits copyAspect)
78{
79 if (copyAspect == VK_IMAGE_ASPECT_STENCIL_BIT)
80 {
81 ASSERT(imageFormat.id == angle::FormatID::D24_UNORM_S8_UINT ||
82 imageFormat.id == angle::FormatID::D32_FLOAT_S8X24_UINT ||
83 imageFormat.id == angle::FormatID::S8_UINT);
84 return angle::Format::Get(angle::FormatID::S8_UINT);
85 }
86
87 ASSERT(copyAspect == VK_IMAGE_ASPECT_DEPTH_BIT);
88
89 switch (imageFormat.id)
90 {
91 case angle::FormatID::D16_UNORM:
92 return imageFormat;
93 case angle::FormatID::D24_UNORM_X8_UINT:
94 return imageFormat;
95 case angle::FormatID::D24_UNORM_S8_UINT:
96 return angle::Format::Get(angle::FormatID::D24_UNORM_X8_UINT);
97 case angle::FormatID::D32_FLOAT:
98 return imageFormat;
99 case angle::FormatID::D32_FLOAT_S8X24_UINT:
100 return angle::Format::Get(angle::FormatID::D32_FLOAT);
101 default:
102 UNREACHABLE();
103 return imageFormat;
104 }
105}
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400106
107void SetEmulatedAlphaValue(const vk::Format &format, VkClearColorValue *value)
108{
109 if (format.vkFormatIsInt)
110 {
111 if (format.vkFormatIsUnsigned)
112 {
113 value->uint32[3] = kEmulatedAlphaValue;
114 }
115 else
116 {
117 value->int32[3] = kEmulatedAlphaValue;
118 }
119 }
120 else
121 {
122 value->float32[3] = kEmulatedAlphaValue;
123 }
124}
Jamie Madillbcf467f2018-05-23 09:46:00 -0400125} // anonymous namespace
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500126
127// static
Jamie Madill639bc902018-07-18 17:08:27 -0400128FramebufferVk *FramebufferVk::CreateUserFBO(RendererVk *renderer, const gl::FramebufferState &state)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500129{
Jamie Madill639bc902018-07-18 17:08:27 -0400130 return new FramebufferVk(renderer, state, nullptr);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500131}
132
133// static
Jamie Madill639bc902018-07-18 17:08:27 -0400134FramebufferVk *FramebufferVk::CreateDefaultFBO(RendererVk *renderer,
135 const gl::FramebufferState &state,
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500136 WindowSurfaceVk *backbuffer)
137{
Jamie Madill639bc902018-07-18 17:08:27 -0400138 return new FramebufferVk(renderer, state, backbuffer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500139}
140
Jamie Madill639bc902018-07-18 17:08:27 -0400141FramebufferVk::FramebufferVk(RendererVk *renderer,
142 const gl::FramebufferState &state,
143 WindowSurfaceVk *backbuffer)
Jamie Madill9aef3672018-04-27 11:45:06 -0400144 : FramebufferImpl(state),
145 mBackbuffer(backbuffer),
Jamie Madill9aef3672018-04-27 11:45:06 -0400146 mActiveColorComponents(0),
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -0500147 mReadPixelBuffer(VK_BUFFER_USAGE_TRANSFER_DST_BIT, kMinReadPixelsBufferSize, true),
148 mBlitPixelBuffer(VK_BUFFER_USAGE_TRANSFER_SRC_BIT, kMinReadPixelsBufferSize, true)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500149{
Jamie Madill639bc902018-07-18 17:08:27 -0400150 mBlitPixelBuffer.init(1, renderer);
Frank Henigman49b0f6e2018-10-03 23:15:29 -0400151 mReadPixelBuffer.init(4, renderer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500152}
153
Jamie Madill58675012018-05-22 14:54:07 -0400154FramebufferVk::~FramebufferVk() = default;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400155
Jamie Madillc564c072017-06-01 12:45:42 -0400156void FramebufferVk::destroy(const gl::Context *context)
Jamie Madill5deea722017-02-16 10:44:46 -0500157{
Luc Ferron534b00d2018-05-18 08:16:53 -0400158 ContextVk *contextVk = vk::GetImpl(context);
Geoff Langee244c72019-05-06 10:30:18 -0400159 mFramebuffer.release(contextVk);
Luc Ferron534b00d2018-05-18 08:16:53 -0400160
Geoff Langee244c72019-05-06 10:30:18 -0400161 mReadPixelBuffer.release(contextVk);
162 mBlitPixelBuffer.release(contextVk);
Jamie Madill5deea722017-02-16 10:44:46 -0500163}
164
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400165angle::Result FramebufferVk::discard(const gl::Context *context,
166 size_t count,
167 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400168{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400169 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500170 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400171}
172
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400173angle::Result FramebufferVk::invalidate(const gl::Context *context,
174 size_t count,
175 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400176{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400177 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500178 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400179}
180
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400181angle::Result FramebufferVk::invalidateSub(const gl::Context *context,
182 size_t count,
183 const GLenum *attachments,
184 const gl::Rectangle &area)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400185{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400186 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500187 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400188}
189
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400190angle::Result FramebufferVk::clear(const gl::Context *context, GLbitfield mask)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400191{
Jamie Madill0cec82a2018-03-14 09:21:07 -0400192 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500193
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400194 bool clearColor = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_COLOR_BUFFER_BIT));
195 bool clearDepth = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_DEPTH_BUFFER_BIT));
196 bool clearStencil = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_STENCIL_BUFFER_BIT));
197 gl::DrawBufferMask clearColorBuffers;
198 if (clearColor)
199 {
200 clearColorBuffers = mState.getEnabledDrawBuffers();
201 }
202
203 const VkClearColorValue &clearColorValue = contextVk->getClearColorValue().color;
204 const VkClearDepthStencilValue &clearDepthStencilValue =
205 contextVk->getClearDepthStencilValue().depthStencil;
206
207 return clearImpl(context, clearColorBuffers, clearDepth, clearStencil, clearColorValue,
208 clearDepthStencilValue);
209}
210
211angle::Result FramebufferVk::clearImpl(const gl::Context *context,
212 gl::DrawBufferMask clearColorBuffers,
213 bool clearDepth,
214 bool clearStencil,
215 const VkClearColorValue &clearColorValue,
216 const VkClearDepthStencilValue &clearDepthStencilValue)
217{
218 ContextVk *contextVk = vk::GetImpl(context);
219
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400220 const gl::Rectangle scissoredRenderArea = getScissoredRenderArea(contextVk);
221
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400222 // Discard clear altogether if scissor has 0 width or height.
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400223 if (scissoredRenderArea.width == 0 || scissoredRenderArea.height == 0)
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400224 {
225 return angle::Result::Continue;
226 }
227
Geoff Langee244c72019-05-06 10:30:18 -0400228 mFramebuffer.updateQueueSerial(contextVk->getCurrentQueueSerial());
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400229
230 // This function assumes that only enabled attachments are asked to be cleared.
231 ASSERT((clearColorBuffers & mState.getEnabledDrawBuffers()) == clearColorBuffers);
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400232
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400233 // Adjust clear behavior based on whether the respective attachments are present; if asked to
234 // clear a non-existent attachment, don't attempt to clear it.
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400235
236 VkColorComponentFlags colorMaskFlags = contextVk->getClearColorMask();
237 bool clearColor = clearColorBuffers.any();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400238
Jamie Madill0cec82a2018-03-14 09:21:07 -0400239 const gl::FramebufferAttachment *depthAttachment = mState.getDepthAttachment();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400240 clearDepth = clearDepth && depthAttachment;
Jamie Madill0cec82a2018-03-14 09:21:07 -0400241 ASSERT(!clearDepth || depthAttachment->isAttached());
242
243 const gl::FramebufferAttachment *stencilAttachment = mState.getStencilAttachment();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400244 clearStencil = clearStencil && stencilAttachment;
Jamie Madill0cec82a2018-03-14 09:21:07 -0400245 ASSERT(!clearStencil || stencilAttachment->isAttached());
246
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400247 uint8_t stencilMask =
248 static_cast<uint8_t>(contextVk->getState().getDepthStencilState().stencilWritemask);
249
250 // The front-end should ensure we don't attempt to clear color if all channels are masked.
251 ASSERT(!clearColor || colorMaskFlags != 0);
252 // The front-end should ensure we don't attempt to clear depth if depth write is disabled.
253 ASSERT(!clearDepth || contextVk->getState().getDepthStencilState().depthMask);
254 // The front-end should ensure we don't attempt to clear stencil if all bits are masked.
255 ASSERT(!clearStencil || stencilMask != 0);
256
257 // If there is nothing to clear, return right away (for example, if asked to clear depth, but
258 // there is no depth attachment).
Shahbaz Youssefi02a579e2019-03-27 14:21:20 -0400259 if (!clearColor && !clearDepth && !clearStencil)
260 {
261 return angle::Result::Continue;
262 }
263
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400264 VkClearDepthStencilValue modifiedDepthStencilValue = clearDepthStencilValue;
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400265
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400266 // We can use render pass load ops if clearing depth, unmasked color or unmasked stencil. If
267 // there's a depth mask, depth clearing is already disabled.
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400268 bool maskedClearColor =
269 clearColor && (mActiveColorComponents & colorMaskFlags) != mActiveColorComponents;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400270 bool maskedClearStencil = stencilMask != 0xFF;
271
272 bool clearColorWithRenderPassLoadOp = clearColor && !maskedClearColor;
273 bool clearStencilWithRenderPassLoadOp = clearStencil && !maskedClearStencil;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400274
275 // At least one of color, depth or stencil should be clearable with render pass loadOp for us
276 // to use this clear path.
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400277 bool clearAnyWithRenderPassLoadOp =
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400278 clearColorWithRenderPassLoadOp || clearDepth || clearStencilWithRenderPassLoadOp;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400279
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400280 if (clearAnyWithRenderPassLoadOp)
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400281 {
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400282 // Clearing color is indicated by the set bits in this mask. If not clearing colors with
283 // render pass loadOp, the default value of all-zeros means the clear is not done in
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400284 // clearWithRenderPassOp below. In that case, only clear depth/stencil with render pass
285 // loadOp.
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400286 gl::DrawBufferMask clearBuffersWithRenderPassLoadOp;
287 if (clearColorWithRenderPassLoadOp)
288 {
289 clearBuffersWithRenderPassLoadOp = clearColorBuffers;
290 }
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400291 ANGLE_TRY(clearWithRenderPassOp(
292 contextVk, scissoredRenderArea, clearBuffersWithRenderPassLoadOp, clearDepth,
293 clearStencilWithRenderPassLoadOp, clearColorValue, modifiedDepthStencilValue));
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400294
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400295 // On some hardware, having inline commands at this point results in corrupted output. In
296 // that case, end the render pass immediately. http://anglebug.com/2361
Jonah Ryan-Davis776694c2019-05-08 10:28:55 -0400297 if (contextVk->getRenderer()->getFeatures().restartRenderPassAfterLoadOpClear.enabled)
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400298 {
Geoff Langee244c72019-05-06 10:30:18 -0400299 mFramebuffer.finishCurrentCommands(contextVk);
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400300 }
301
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400302 // Fallback to other methods for whatever isn't cleared here.
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400303 clearDepth = false;
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400304 if (clearColorWithRenderPassLoadOp)
305 {
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400306 clearColorBuffers.reset();
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400307 clearColor = false;
308 }
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400309 if (clearStencilWithRenderPassLoadOp)
310 {
311 clearStencil = false;
312 }
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400313
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400314 // If nothing left to clear, early out.
315 if (!clearColor && !clearStencil)
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400316 {
317 return angle::Result::Continue;
318 }
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400319 }
320
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -0400321 // Note: depth clear is always done through render pass loadOp.
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400322 ASSERT(clearDepth == false);
323
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400324 // The most costly clear mode is when we need to mask out specific color channels or stencil
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -0400325 // bits. This can only be done with a draw call.
326 return clearWithDraw(contextVk, scissoredRenderArea, clearColorBuffers, clearStencil,
327 colorMaskFlags, stencilMask, clearColorValue,
328 static_cast<uint8_t>(modifiedDepthStencilValue.stencil));
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400329}
330
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400331angle::Result FramebufferVk::clearBufferfv(const gl::Context *context,
332 GLenum buffer,
333 GLint drawbuffer,
334 const GLfloat *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400335{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400336 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400337
338 bool clearDepth = false;
339 gl::DrawBufferMask clearColorBuffers;
340
341 if (buffer == GL_DEPTH)
342 {
343 clearDepth = true;
344 clearValue.depthStencil.depth = values[0];
345 }
346 else
347 {
348 clearColorBuffers.set(drawbuffer);
349 clearValue.color.float32[0] = values[0];
350 clearValue.color.float32[1] = values[1];
351 clearValue.color.float32[2] = values[2];
352 clearValue.color.float32[3] = values[3];
353 }
354
355 return clearImpl(context, clearColorBuffers, clearDepth, false, clearValue.color,
356 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400357}
358
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400359angle::Result FramebufferVk::clearBufferuiv(const gl::Context *context,
360 GLenum buffer,
361 GLint drawbuffer,
362 const GLuint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400363{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400364 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400365
366 gl::DrawBufferMask clearColorBuffers;
367 clearColorBuffers.set(drawbuffer);
368
369 clearValue.color.uint32[0] = values[0];
370 clearValue.color.uint32[1] = values[1];
371 clearValue.color.uint32[2] = values[2];
372 clearValue.color.uint32[3] = values[3];
373
374 return clearImpl(context, clearColorBuffers, false, false, clearValue.color,
375 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400376}
377
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400378angle::Result FramebufferVk::clearBufferiv(const gl::Context *context,
379 GLenum buffer,
380 GLint drawbuffer,
381 const GLint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400382{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400383 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400384
385 bool clearStencil = false;
386 gl::DrawBufferMask clearColorBuffers;
387
388 if (buffer == GL_STENCIL)
389 {
390 clearStencil = true;
391 clearValue.depthStencil.stencil =
392 gl::clamp(values[0], 0, std::numeric_limits<uint8_t>::max());
393 }
394 else
395 {
396 clearColorBuffers.set(drawbuffer);
397 clearValue.color.int32[0] = values[0];
398 clearValue.color.int32[1] = values[1];
399 clearValue.color.int32[2] = values[2];
400 clearValue.color.int32[3] = values[3];
401 }
402
403 return clearImpl(context, clearColorBuffers, false, clearStencil, clearValue.color,
404 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400405}
406
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400407angle::Result FramebufferVk::clearBufferfi(const gl::Context *context,
408 GLenum buffer,
409 GLint drawbuffer,
410 GLfloat depth,
411 GLint stencil)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400412{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400413 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400414
415 clearValue.depthStencil.depth = depth;
416 clearValue.depthStencil.stencil = gl::clamp(stencil, 0, std::numeric_limits<uint8_t>::max());
417
418 return clearImpl(context, gl::DrawBufferMask(), true, true, clearValue.color,
419 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400420}
421
Jamie Madill4928b7c2017-06-20 12:57:39 -0400422GLenum FramebufferVk::getImplementationColorReadFormat(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400423{
Jamie Madill66546be2018-03-08 09:47:20 -0500424 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).format;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400425}
426
Jamie Madill4928b7c2017-06-20 12:57:39 -0400427GLenum FramebufferVk::getImplementationColorReadType(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400428{
Jamie Madill66546be2018-03-08 09:47:20 -0500429 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).type;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400430}
431
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400432angle::Result FramebufferVk::readPixels(const gl::Context *context,
433 const gl::Rectangle &area,
434 GLenum format,
435 GLenum type,
436 void *pixels)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400437{
Luc Ferrona1c72422018-05-14 15:58:28 -0400438 // Clip read area to framebuffer.
439 const gl::Extents &fbSize = getState().getReadAttachment()->getSize();
440 const gl::Rectangle fbRect(0, 0, fbSize.width, fbSize.height);
Luc Ferronbf6dc372018-06-28 15:24:19 -0400441 ContextVk *contextVk = vk::GetImpl(context);
Luc Ferronbf6dc372018-06-28 15:24:19 -0400442
Luc Ferrona1c72422018-05-14 15:58:28 -0400443 gl::Rectangle clippedArea;
444 if (!ClipRectangle(area, fbRect, &clippedArea))
445 {
446 // nothing to read
Jamie Madill7c985f52018-11-29 18:16:17 -0500447 return angle::Result::Continue;
Luc Ferrona1c72422018-05-14 15:58:28 -0400448 }
Luc Ferronbf6dc372018-06-28 15:24:19 -0400449 gl::Rectangle flippedArea = clippedArea;
Geoff Lange076a232018-07-16 15:34:05 -0400450 if (contextVk->isViewportFlipEnabledForReadFBO())
Luc Ferronbf6dc372018-06-28 15:24:19 -0400451 {
452 flippedArea.y = fbRect.height - flippedArea.y - flippedArea.height;
453 }
Luc Ferrona1c72422018-05-14 15:58:28 -0400454
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500455 const gl::State &glState = context->getState();
Frank Henigman1ffad842018-09-24 23:40:45 -0400456 const gl::PixelPackState &packState = glState.getPackState();
Luc Ferronbf6dc372018-06-28 15:24:19 -0400457
Luc Ferrona1c72422018-05-14 15:58:28 -0400458 const gl::InternalFormat &sizedFormatInfo = gl::GetInternalFormatInfo(format, type);
459
460 GLuint outputPitch = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400461 ANGLE_VK_CHECK_MATH(contextVk,
462 sizedFormatInfo.computeRowPitch(type, area.width, packState.alignment,
463 packState.rowLength, &outputPitch));
Luc Ferrona1c72422018-05-14 15:58:28 -0400464 GLuint outputSkipBytes = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400465 ANGLE_VK_CHECK_MATH(contextVk, sizedFormatInfo.computeSkipBytes(type, outputPitch, 0, packState,
466 false, &outputSkipBytes));
Luc Ferrona1c72422018-05-14 15:58:28 -0400467
468 outputSkipBytes += (clippedArea.x - area.x) * sizedFormatInfo.pixelBytes +
469 (clippedArea.y - area.y) * outputPitch;
Luc Ferron60284222018-03-20 16:01:44 -0400470
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400471 const angle::Format &angleFormat = GetFormatFromFormatType(format, type);
472
Frank Henigman1ffad842018-09-24 23:40:45 -0400473 PackPixelsParams params(flippedArea, angleFormat, outputPitch, packState.reverseRowOrder,
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400474 glState.getTargetBuffer(gl::BufferBinding::PixelPack), 0);
Frank Henigman1ffad842018-09-24 23:40:45 -0400475 if (contextVk->isViewportFlipEnabledForReadFBO())
476 {
477 params.reverseRowOrder = !params.reverseRowOrder;
478 }
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500479
Jamie Madill21061022018-07-12 23:56:30 -0400480 ANGLE_TRY(readPixelsImpl(contextVk, flippedArea, params, VK_IMAGE_ASPECT_COLOR_BIT,
Luc Ferron1617e692018-07-11 11:08:19 -0400481 getColorReadRenderTarget(),
Rafael Cintron05a449a2018-06-20 18:08:04 -0700482 static_cast<uint8_t *>(pixels) + outputSkipBytes));
Geoff Langee244c72019-05-06 10:30:18 -0400483 mReadPixelBuffer.releaseRetainedBuffers(contextVk);
Jamie Madill7c985f52018-11-29 18:16:17 -0500484 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -0400485}
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500486
Luc Ferron26581112018-06-21 09:43:08 -0400487RenderTargetVk *FramebufferVk::getDepthStencilRenderTarget() const
488{
489 return mRenderTargetCache.getDepthStencil();
490}
491
Jamie Madill16c20142018-10-01 13:58:19 -0400492angle::Result FramebufferVk::blitWithCopy(ContextVk *contextVk,
493 const gl::Rectangle &copyArea,
494 RenderTargetVk *readRenderTarget,
495 RenderTargetVk *drawRenderTarget,
496 bool blitDepthBuffer,
497 bool blitStencilBuffer)
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400498{
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500499 VkImageAspectFlags aspectMask =
500 vk::GetDepthStencilAspectFlagsForCopy(blitDepthBuffer, blitStencilBuffer);
Jamie Madill16c20142018-10-01 13:58:19 -0400501
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400502 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400503 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
504
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500505 vk::ImageHelper *writeImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
506 writeImage->changeLayout(writeImage->getAspectFlags(), vk::ImageLayout::TransferDst,
507 commandBuffer);
508
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400509 vk::ImageHelper *readImage = readRenderTarget->getImageForRead(
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500510 &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400511
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500512 VkImageSubresourceLayers readSubresource = {};
513 readSubresource.aspectMask = aspectMask;
514 readSubresource.mipLevel = 0;
515 readSubresource.baseArrayLayer = 0;
516 readSubresource.layerCount = 1;
517
518 VkImageSubresourceLayers writeSubresource = readSubresource;
519
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400520 vk::ImageHelper::Copy(readImage, writeImage, gl::Offset(), gl::Offset(),
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500521 gl::Extents(copyArea.width, copyArea.height, 1), readSubresource,
522 writeSubresource, commandBuffer);
Jamie Madill7c985f52018-11-29 18:16:17 -0500523 return angle::Result::Continue;
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400524}
525
Jamie Madill58675012018-05-22 14:54:07 -0400526RenderTargetVk *FramebufferVk::getColorReadRenderTarget() const
Luc Ferron018709f2018-05-10 13:53:11 -0400527{
528 RenderTargetVk *renderTarget = mRenderTargetCache.getColorRead(mState);
Jamie Madillbcf467f2018-05-23 09:46:00 -0400529 ASSERT(renderTarget && renderTarget->getImage().valid());
Luc Ferron018709f2018-05-10 13:53:11 -0400530 return renderTarget;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400531}
532
Jamie Madill21061022018-07-12 23:56:30 -0400533angle::Result FramebufferVk::blitWithReadback(ContextVk *contextVk,
Jamie Madilld754eb52018-07-19 14:55:03 -0400534 const gl::Rectangle &copyArea,
Jamie Madillb436aac2018-07-18 17:23:48 -0400535 VkImageAspectFlagBits aspect,
Jamie Madill21061022018-07-12 23:56:30 -0400536 RenderTargetVk *readRenderTarget,
537 RenderTargetVk *drawRenderTarget)
Luc Ferron1617e692018-07-11 11:08:19 -0400538{
Jamie Madill0631e192019-04-18 16:09:12 -0400539 const angle::Format &readFormat = readRenderTarget->getImageFormat().imageFormat();
Luc Ferron1617e692018-07-11 11:08:19 -0400540
Jamie Madillb436aac2018-07-18 17:23:48 -0400541 ASSERT(aspect == VK_IMAGE_ASPECT_DEPTH_BIT || aspect == VK_IMAGE_ASPECT_STENCIL_BIT);
Luc Ferron1617e692018-07-11 11:08:19 -0400542
Jamie Madillb436aac2018-07-18 17:23:48 -0400543 // This path is only currently used for y-flipping depth/stencil blits.
Luc Ferron1617e692018-07-11 11:08:19 -0400544 PackPixelsParams packPixelsParams;
Jamie Madillb980c562018-11-27 11:34:27 -0500545 packPixelsParams.reverseRowOrder = true;
546 packPixelsParams.area.width = copyArea.width;
547 packPixelsParams.area.height = copyArea.height;
548 packPixelsParams.area.x = copyArea.x;
549 packPixelsParams.area.y = copyArea.y;
Luc Ferron1617e692018-07-11 11:08:19 -0400550
Jamie Madillb436aac2018-07-18 17:23:48 -0400551 // Read back depth values into the destination buffer.
552 const angle::Format &copyFormat = GetDepthStencilImageToBufferFormat(readFormat, aspect);
553 packPixelsParams.destFormat = &copyFormat;
554 packPixelsParams.outputPitch = copyFormat.pixelBytes * copyArea.width;
Luc Ferron1617e692018-07-11 11:08:19 -0400555
Jamie Madillb436aac2018-07-18 17:23:48 -0400556 // Allocate a space in the destination buffer to write to.
557 size_t blitAllocationSize = copyFormat.pixelBytes * copyArea.width * copyArea.height;
558 uint8_t *destPtr = nullptr;
559 VkBuffer destBufferHandle = VK_NULL_HANDLE;
Jamie Madill4c310832018-08-29 13:43:17 -0400560 VkDeviceSize destOffset = 0;
Jamie Madillb436aac2018-07-18 17:23:48 -0400561 ANGLE_TRY(mBlitPixelBuffer.allocate(contextVk, blitAllocationSize, &destPtr, &destBufferHandle,
562 &destOffset, nullptr));
Luc Ferron1617e692018-07-11 11:08:19 -0400563
Jamie Madillb436aac2018-07-18 17:23:48 -0400564 ANGLE_TRY(
565 readPixelsImpl(contextVk, copyArea, packPixelsParams, aspect, readRenderTarget, destPtr));
Luc Ferron1617e692018-07-11 11:08:19 -0400566
Shahbaz Youssefi06270c92018-10-03 17:00:25 -0400567 VkBufferImageCopy copyRegion = {};
Jamie Madillb436aac2018-07-18 17:23:48 -0400568 copyRegion.bufferOffset = destOffset;
569 copyRegion.bufferImageHeight = copyArea.height;
570 copyRegion.bufferRowLength = copyArea.width;
571 copyRegion.imageExtent.width = copyArea.width;
572 copyRegion.imageExtent.height = copyArea.height;
573 copyRegion.imageExtent.depth = 1;
574 copyRegion.imageSubresource.mipLevel = 0;
575 copyRegion.imageSubresource.aspectMask = aspect;
576 copyRegion.imageSubresource.baseArrayLayer = 0;
577 copyRegion.imageSubresource.layerCount = 1;
578 copyRegion.imageOffset.x = copyArea.x;
579 copyRegion.imageOffset.y = copyArea.y;
580 copyRegion.imageOffset.z = 0;
581
Jamie Madill21061022018-07-12 23:56:30 -0400582 ANGLE_TRY(mBlitPixelBuffer.flush(contextVk));
Luc Ferron1617e692018-07-11 11:08:19 -0400583
584 // Reinitialize the commandBuffer after a read pixels because it calls
585 // renderer->finish which makes command buffers obsolete.
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400586 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -0400587 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Luc Ferron1617e692018-07-11 11:08:19 -0400588
589 // We read the bytes of the image in a buffer, now we have to copy them into the
590 // destination target.
Jamie Madille8dd0792018-09-27 15:04:27 -0400591 vk::ImageHelper *imageForWrite = drawRenderTarget->getImageForWrite(&mFramebuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400592
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500593 imageForWrite->changeLayout(imageForWrite->getAspectFlags(), vk::ImageLayout::TransferDst,
594 commandBuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400595
Jamie Madillb436aac2018-07-18 17:23:48 -0400596 commandBuffer->copyBufferToImage(destBufferHandle, imageForWrite->getImage(),
597 VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &copyRegion);
Luc Ferron1617e692018-07-11 11:08:19 -0400598
Geoff Langee244c72019-05-06 10:30:18 -0400599 mBlitPixelBuffer.releaseRetainedBuffers(contextVk);
Jamie Madillb436aac2018-07-18 17:23:48 -0400600
Jamie Madill7c985f52018-11-29 18:16:17 -0500601 return angle::Result::Continue;
Luc Ferron1617e692018-07-11 11:08:19 -0400602}
603
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400604angle::Result FramebufferVk::blitWithCommand(ContextVk *contextVk,
605 const gl::Rectangle &readRectIn,
606 const gl::Rectangle &drawRectIn,
607 RenderTargetVk *readRenderTarget,
608 RenderTargetVk *drawRenderTarget,
609 GLenum filter,
610 bool colorBlit,
611 bool depthBlit,
612 bool stencilBlit,
613 bool flipSource,
614 bool flipDest)
615{
616 // Since blitRenderbufferRect is called for each render buffer that needs to be blitted,
617 // it should never be the case that both color and depth/stencil need to be blitted at
618 // at the same time.
619 ASSERT(colorBlit != (depthBlit || stencilBlit));
620
621 vk::ImageHelper *dstImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
622
623 vk::CommandBuffer *commandBuffer = nullptr;
624 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
625
626 const vk::Format &readImageFormat = readRenderTarget->getImageFormat();
627 VkImageAspectFlags aspectMask =
628 colorBlit ? VK_IMAGE_ASPECT_COLOR_BIT
629 : vk::GetDepthStencilAspectFlags(readImageFormat.imageFormat());
630 vk::ImageHelper *srcImage = readRenderTarget->getImageForRead(
631 &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
632
633 const gl::Extents sourceFrameBufferExtents = readRenderTarget->getExtents();
634 gl::Rectangle readRect = readRectIn;
635
636 if (flipSource)
637 {
638 readRect.y = sourceFrameBufferExtents.height - readRect.y - readRect.height;
639 }
640
641 VkImageBlit blit = {};
642 blit.srcOffsets[0] = {readRect.x0(), flipSource ? readRect.y1() : readRect.y0(), 0};
643 blit.srcOffsets[1] = {readRect.x1(), flipSource ? readRect.y0() : readRect.y1(), 1};
644 blit.srcSubresource.aspectMask = aspectMask;
645 blit.srcSubresource.mipLevel = readRenderTarget->getLevelIndex();
646 blit.srcSubresource.baseArrayLayer = readRenderTarget->getLayerIndex();
647 blit.srcSubresource.layerCount = 1;
648 blit.dstSubresource.aspectMask = aspectMask;
649 blit.dstSubresource.mipLevel = drawRenderTarget->getLevelIndex();
650 blit.dstSubresource.baseArrayLayer = drawRenderTarget->getLayerIndex();
651 blit.dstSubresource.layerCount = 1;
652
653 const gl::Extents drawFrameBufferExtents = drawRenderTarget->getExtents();
654 gl::Rectangle drawRect = drawRectIn;
655
656 if (flipDest)
657 {
658 drawRect.y = drawFrameBufferExtents.height - drawRect.y - drawRect.height;
659 }
660
661 blit.dstOffsets[0] = {drawRect.x0(), flipDest ? drawRect.y1() : drawRect.y0(), 0};
662 blit.dstOffsets[1] = {drawRect.x1(), flipDest ? drawRect.y0() : drawRect.y1(), 1};
663
664 // Requirement of the copyImageToBuffer, the dst image must be in
665 // VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout.
666 dstImage->changeLayout(aspectMask, vk::ImageLayout::TransferDst, commandBuffer);
667
668 commandBuffer->blitImage(srcImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL,
669 dstImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &blit,
670 gl_vk::GetFilter(filter));
671
672 return angle::Result::Continue;
673}
674
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400675angle::Result FramebufferVk::blit(const gl::Context *context,
676 const gl::Rectangle &sourceArea,
677 const gl::Rectangle &destArea,
678 GLbitfield mask,
679 GLenum filter)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400680{
Luc Ferron26581112018-06-21 09:43:08 -0400681 ContextVk *contextVk = vk::GetImpl(context);
682 RendererVk *renderer = contextVk->getRenderer();
683
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500684 const gl::State &glState = context->getState();
Luc Ferron26581112018-06-21 09:43:08 -0400685 const gl::Framebuffer *sourceFramebuffer = glState.getReadFramebuffer();
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400686
687 bool blitColorBuffer = (mask & GL_COLOR_BUFFER_BIT) != 0;
688 bool blitDepthBuffer = (mask & GL_DEPTH_BUFFER_BIT) != 0;
689 bool blitStencilBuffer = (mask & GL_STENCIL_BUFFER_BIT) != 0;
690
691 // If multisampled, blit only does a resolve.
692 if (sourceFramebuffer->getCachedSamples(context) > 1)
693 {
694 // Note: GLES (all 3.x versions) require source and dest area to be identical when
695 // resolving.
696 ASSERT(sourceArea.x == destArea.x && sourceArea.y == destArea.y &&
697 sourceArea.width == destArea.width && sourceArea.height == destArea.height);
698
699 return resolve(contextVk, destArea, blitColorBuffer, blitDepthBuffer, blitStencilBuffer);
700 }
Luc Ferron26581112018-06-21 09:43:08 -0400701
Luc Ferron26581112018-06-21 09:43:08 -0400702 FramebufferVk *sourceFramebufferVk = vk::GetImpl(sourceFramebuffer);
Luc Ferron82eda932018-07-09 15:10:22 -0400703 bool flipSource = contextVk->isViewportFlipEnabledForReadFBO();
704 bool flipDest = contextVk->isViewportFlipEnabledForDrawFBO();
705
Jamie Madilld754eb52018-07-19 14:55:03 -0400706 gl::Rectangle readRect = sourceArea;
707 gl::Rectangle drawRect = destArea;
708
709 if (glState.isScissorTestEnabled())
710 {
711 const gl::Rectangle scissorRect = glState.getScissor();
712 if (!ClipRectangle(sourceArea, scissorRect, &readRect))
713 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500714 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400715 }
716
717 if (!ClipRectangle(destArea, scissorRect, &drawRect))
718 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500719 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400720 }
721 }
722
723 // After cropping for the scissor, we also want to crop for the size of the buffers.
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400724 //
725 // TODO(syoussefi): GL requires that scaling factor is preserved even if further clipping is
726 // done:
727 //
728 // > Whether or not the source or destination regions are altered due to these limits, the
729 // > scaling and offset applied to pixels being transferred is performed as though no such
730 // > limits were present.
731 //
732 // Using vkCmdBlitFramebuffer after these clippings are done breaks this behavior. This
733 // function can be turned into a single draw call that does everything, similar to resolve().
734 //
735 // http://anglebug.com/3200
Jamie Madilld754eb52018-07-19 14:55:03 -0400736
Luc Ferron26581112018-06-21 09:43:08 -0400737 if (blitColorBuffer)
738 {
739 RenderTargetVk *readRenderTarget = sourceFramebufferVk->getColorReadRenderTarget();
740
Jamie Madilld754eb52018-07-19 14:55:03 -0400741 gl::Rectangle readRenderTargetRect;
742 if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect))
743 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500744 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400745 }
746
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400747 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Luc Ferron26581112018-06-21 09:43:08 -0400748 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -0400749 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorIndexGL];
Luc Ferron26581112018-06-21 09:43:08 -0400750 ASSERT(drawRenderTarget);
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -0500751 ASSERT(HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget));
Jamie Madilld754eb52018-07-19 14:55:03 -0400752
753 gl::Rectangle drawRenderTargetRect;
754 if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect))
755 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500756 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400757 }
758
Jamie Madill16c20142018-10-01 13:58:19 -0400759 ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect,
760 readRenderTarget, drawRenderTarget, filter, true, false,
761 false, flipSource, flipDest));
Luc Ferron26581112018-06-21 09:43:08 -0400762 }
763 }
764
765 if (blitDepthBuffer || blitStencilBuffer)
766 {
767 RenderTargetVk *readRenderTarget = sourceFramebufferVk->getDepthStencilRenderTarget();
768 ASSERT(readRenderTarget);
769
Jamie Madilld754eb52018-07-19 14:55:03 -0400770 gl::Rectangle readRenderTargetRect;
771 if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect))
772 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500773 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400774 }
775
Luc Ferron26581112018-06-21 09:43:08 -0400776 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getDepthStencil();
Jamie Madilld754eb52018-07-19 14:55:03 -0400777 ASSERT(drawRenderTarget);
778
779 gl::Rectangle drawRenderTargetRect;
780 if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect))
781 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500782 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400783 }
784
785 ASSERT(readRenderTargetRect == drawRenderTargetRect);
786 ASSERT(filter == GL_NEAREST);
Luc Ferron26581112018-06-21 09:43:08 -0400787
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -0500788 if (HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget))
Luc Ferron26581112018-06-21 09:43:08 -0400789 {
Jamie Madill16c20142018-10-01 13:58:19 -0400790 ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect,
791 readRenderTarget, drawRenderTarget, filter, false,
792 blitDepthBuffer, blitStencilBuffer, flipSource, flipDest));
Luc Ferron26581112018-06-21 09:43:08 -0400793 }
794 else
795 {
Luc Ferron1617e692018-07-11 11:08:19 -0400796 if (flipSource || flipDest)
797 {
Jamie Madillb436aac2018-07-18 17:23:48 -0400798 if (blitDepthBuffer)
799 {
800 ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect,
Jamie Madill16c20142018-10-01 13:58:19 -0400801 VK_IMAGE_ASPECT_DEPTH_BIT, readRenderTarget,
802 drawRenderTarget));
Jamie Madillb436aac2018-07-18 17:23:48 -0400803 }
804 if (blitStencilBuffer)
805 {
806 ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect,
Jamie Madill16c20142018-10-01 13:58:19 -0400807 VK_IMAGE_ASPECT_STENCIL_BIT, readRenderTarget,
808 drawRenderTarget));
Jamie Madillb436aac2018-07-18 17:23:48 -0400809 }
Luc Ferron1617e692018-07-11 11:08:19 -0400810 }
811 else
812 {
Jamie Madill16c20142018-10-01 13:58:19 -0400813 ANGLE_TRY(blitWithCopy(contextVk, readRenderTargetRect, readRenderTarget,
814 drawRenderTarget, blitDepthBuffer, blitStencilBuffer));
Luc Ferron1617e692018-07-11 11:08:19 -0400815 }
Luc Ferron26581112018-06-21 09:43:08 -0400816 }
817 }
818
Jamie Madill7c985f52018-11-29 18:16:17 -0500819 return angle::Result::Continue;
Luc Ferron26581112018-06-21 09:43:08 -0400820}
821
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400822angle::Result FramebufferVk::resolve(ContextVk *contextVk,
823 const gl::Rectangle &area,
824 bool resolveColorBuffer,
825 bool resolveDepthBuffer,
826 bool resolveStencilBuffer)
Luc Ferron26581112018-06-21 09:43:08 -0400827{
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400828 UtilsVk &utilsVk = contextVk->getUtils();
Luc Ferron26581112018-06-21 09:43:08 -0400829
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400830 const gl::State &glState = contextVk->getState();
831 const gl::Framebuffer *srcFramebuffer = glState.getReadFramebuffer();
832
833 FramebufferVk *srcFramebufferVk = vk::GetImpl(srcFramebuffer);
834 bool srcFramebufferFlippedY = contextVk->isViewportFlipEnabledForReadFBO();
835 bool destFramebufferFlippedY = contextVk->isViewportFlipEnabledForDrawFBO();
836
837 gl::Rectangle srcFramebufferDimensions = srcFramebufferVk->mState.getDimensions().toRect();
838
839 gl::Rectangle sourceArea = area;
840 gl::Rectangle destArea = area;
841
842 // If framebuffers are flipped in Y, flip the source and dest area first for simplicity.
843 if (srcFramebufferFlippedY)
844 {
845 sourceArea.y = srcFramebufferDimensions.height - sourceArea.y;
846 sourceArea.height = -sourceArea.height;
847 }
848 if (destFramebufferFlippedY)
849 {
850 destArea.y = mState.getDimensions().height - destArea.y;
851 destArea.height = -destArea.height;
852 }
853
854 // If X (or Y) is flipped in neither source nor dest, or is flipped in both, we want the offset
855 // to be at the left (or top) of the copy area. If it's flipped in source xor dest, we want
856 // the offset to be at the right (or bottom) of the copy area (which is what the shader
857 // expects). x0() already chooses the left or right side of the source area based on whether
858 // it's flipped, so we just need to test dest for flip and choose x0() or x1() accordingly.
859 int srcOffset[2] = {destArea.isReversedX() ? sourceArea.x1() : sourceArea.x0(),
860 destArea.isReversedY() ? sourceArea.y1() : sourceArea.y0()};
861 bool flipX = sourceArea.isReversedX() != destArea.isReversedX();
862 bool flipY = sourceArea.isReversedY() != destArea.isReversedY();
863
864 // GLES doesn't allow flipping the parameters of glBlitFramebuffer if performing a resolve.
865 ASSERT(flipX == false && flipY == (srcFramebufferFlippedY != destFramebufferFlippedY));
866
867 // Destination offset is always set to the unflipped rectangle, as flipping as handled entirely
868 // on source side.
869 gl::Rectangle absDestArea = destArea.removeReversal();
870 int destOffset[2] = {absDestArea.x, absDestArea.y};
871
872 gl::Rectangle scissoredDestArea = absDestArea;
873 if (contextVk->getState().isScissorTestEnabled())
874 {
875 // Now that the src and dest offsets are calculated (defining the resolve transformation),
876 // scissor the destination area.
877 gl::Rectangle scissor = contextVk->getState().getScissor();
878 if (destFramebufferFlippedY)
879 {
880 scissor.y = mState.getDimensions().height - scissor.y - scissor.height;
881 }
882
883 if (!gl::ClipRectangle(scissor, absDestArea, &scissoredDestArea))
884 {
885 return angle::Result::Continue;
886 }
887 }
888
889 // Clip the resolve area to the destination framebuffer.
890 gl::Rectangle resolveArea;
891 if (!gl::ClipRectangle(srcFramebufferDimensions, scissoredDestArea, &resolveArea))
892 {
893 return angle::Result::Continue;
894 }
895
896 UtilsVk::ResolveParameters params;
897 params.srcOffset[0] = srcOffset[0];
898 params.srcOffset[1] = srcOffset[1];
899 params.srcExtents[0] = srcFramebufferDimensions.width;
900 params.srcExtents[1] = srcFramebufferDimensions.height;
901 params.destOffset[0] = destOffset[0];
902 params.destOffset[1] = destOffset[1];
903 params.resolveArea = resolveArea;
904 params.flipX = flipX;
905 params.flipY = flipY;
906
907 if (resolveColorBuffer)
908 {
909 RenderTargetVk *readRenderTarget = srcFramebufferVk->getColorReadRenderTarget();
910 params.srcLayer = readRenderTarget->getLayerIndex();
911
912 // Multisampled images are not allowed to have mips.
913 ASSERT(readRenderTarget->getLevelIndex() == 0);
914
915 // If we're not flipping, use Vulkan's builtin resolve.
916 if (!flipX && !flipY)
917 {
918 ANGLE_TRY(resolveColorWithCommand(contextVk, params, &readRenderTarget->getImage()));
919 }
920 else
921 {
922 ANGLE_TRY(utilsVk.colorResolve(contextVk, this, &readRenderTarget->getImage(),
923 readRenderTarget->getFetchImageView(), params));
924 }
925 }
926
927 if (resolveDepthBuffer || resolveStencilBuffer)
928 {
929 RenderTargetVk *readRenderTarget = srcFramebufferVk->getDepthStencilRenderTarget();
930 params.srcLayer = readRenderTarget->getLayerIndex();
931
932 // Multisampled images are not allowed to have mips.
933 ASSERT(readRenderTarget->getLevelIndex() == 0);
934
935 // Create depth- and stencil-only views for reading.
936 vk::Scoped<vk::ImageView> depthView(contextVk->getDevice());
937 vk::Scoped<vk::ImageView> stencilView(contextVk->getDevice());
938
939 vk::ImageHelper *depthStencilImage = &readRenderTarget->getImage();
940 uint32_t levelIndex = readRenderTarget->getLevelIndex();
941 uint32_t layerIndex = readRenderTarget->getLayerIndex();
942 gl::TextureType textureType = vk::Get2DTextureType(depthStencilImage->getLayerCount(),
943 depthStencilImage->getSamples());
944
945 if (resolveDepthBuffer)
946 {
947 ANGLE_TRY(depthStencilImage->initLayerImageView(
948 contextVk, textureType, VK_IMAGE_ASPECT_DEPTH_BIT, gl::SwizzleState(),
949 &depthView.get(), levelIndex, 1, layerIndex, 1));
950 }
951
952 if (resolveStencilBuffer)
953 {
954 ANGLE_TRY(depthStencilImage->initLayerImageView(
955 contextVk, textureType, VK_IMAGE_ASPECT_STENCIL_BIT, gl::SwizzleState(),
956 &stencilView.get(), levelIndex, 1, layerIndex, 1));
957 }
958
959 ANGLE_TRY(utilsVk.depthStencilResolve(contextVk, this, depthStencilImage, &depthView.get(),
960 &stencilView.get(), params));
961
962 vk::ImageView depthViewObject = depthView.release();
963 vk::ImageView stencilViewObject = stencilView.release();
964
965 contextVk->releaseObject(contextVk->getCurrentQueueSerial(), &depthViewObject);
966 contextVk->releaseObject(contextVk->getCurrentQueueSerial(), &stencilViewObject);
967 }
968
969 return angle::Result::Continue;
970}
971
972angle::Result FramebufferVk::resolveColorWithCommand(ContextVk *contextVk,
973 const UtilsVk::ResolveParameters &params,
974 vk::ImageHelper *srcImage)
975{
976 if (srcImage->isLayoutChangeNecessary(vk::ImageLayout::TransferSrc))
977 {
978 vk::CommandBuffer *srcLayoutChange;
979 ANGLE_TRY(srcImage->recordCommands(contextVk, &srcLayoutChange));
980 srcImage->changeLayout(VK_IMAGE_ASPECT_COLOR_BIT, vk::ImageLayout::TransferSrc,
981 srcLayoutChange);
982 }
Jamie Madill16c20142018-10-01 13:58:19 -0400983
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400984 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400985 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
986
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400987 // Source's layout change should happen before rendering
988 srcImage->addReadDependency(&mFramebuffer);
Luc Ferron26581112018-06-21 09:43:08 -0400989
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400990 VkImageResolve resolveRegion = {};
991 resolveRegion.srcSubresource.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
992 resolveRegion.srcSubresource.mipLevel = 0;
993 resolveRegion.srcSubresource.baseArrayLayer = params.srcLayer;
994 resolveRegion.srcSubresource.layerCount = 1;
995 resolveRegion.srcOffset.x = params.srcOffset[0];
996 resolveRegion.srcOffset.y = params.srcOffset[1];
997 resolveRegion.srcOffset.z = 0;
998 resolveRegion.dstSubresource.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
999 resolveRegion.dstSubresource.layerCount = 1;
1000 resolveRegion.dstOffset.x = params.destOffset[0];
1001 resolveRegion.dstOffset.y = params.destOffset[1];
1002 resolveRegion.dstOffset.z = 0;
1003 resolveRegion.extent.width = params.srcExtents[0];
1004 resolveRegion.extent.height = params.srcExtents[1];
1005 resolveRegion.extent.depth = 1;
Jamie Madilld754eb52018-07-19 14:55:03 -04001006
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -04001007 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Luc Ferron82eda932018-07-09 15:10:22 -04001008 {
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -04001009 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorIndexGL];
1010
1011 resolveRegion.dstSubresource.mipLevel = drawRenderTarget->getLevelIndex();
1012 resolveRegion.dstSubresource.baseArrayLayer = drawRenderTarget->getLayerIndex();
1013
1014 srcImage->resolve(&drawRenderTarget->getImage(), resolveRegion, commandBuffer);
Luc Ferron82eda932018-07-09 15:10:22 -04001015 }
1016
Jamie Madill7c985f52018-11-29 18:16:17 -05001017 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001018}
1019
Kenneth Russellce8602a2017-10-03 18:23:08 -07001020bool FramebufferVk::checkStatus(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001021{
Luc Ferron5bdf8bd2018-06-20 09:51:37 -04001022 // if we have both a depth and stencil buffer, they must refer to the same object
1023 // since we only support packed_depth_stencil and not separate depth and stencil
1024 if (mState.hasSeparateDepthAndStencilAttachments())
1025 {
1026 return false;
1027 }
1028
Jamie Madillb79e7bb2017-10-24 13:55:50 -04001029 return true;
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001030}
1031
Jamie Madill67220092019-05-20 11:12:53 -04001032angle::Result FramebufferVk::updateColorAttachment(const gl::Context *context, size_t colorIndexGL)
1033{
1034 ContextVk *contextVk = vk::GetImpl(context);
1035
1036 ANGLE_TRY(mRenderTargetCache.updateColorRenderTarget(context, mState, colorIndexGL));
1037
1038 // Update cached masks for masked clears.
1039 RenderTargetVk *renderTarget = mRenderTargetCache.getColors()[colorIndexGL];
1040 if (renderTarget)
1041 {
1042 const angle::Format &emulatedFormat = renderTarget->getImageFormat().imageFormat();
1043 updateActiveColorMasks(colorIndexGL, emulatedFormat.redBits > 0,
1044 emulatedFormat.greenBits > 0, emulatedFormat.blueBits > 0,
1045 emulatedFormat.alphaBits > 0);
1046
1047 const angle::Format &sourceFormat = renderTarget->getImageFormat().angleFormat();
1048 mEmulatedAlphaAttachmentMask.set(
1049 colorIndexGL, sourceFormat.alphaBits == 0 && emulatedFormat.alphaBits > 0);
1050
1051 contextVk->updateColorMask(context->getState().getBlendState());
1052 }
1053 else
1054 {
1055 updateActiveColorMasks(colorIndexGL, false, false, false, false);
1056 }
1057
1058 return angle::Result::Continue;
1059}
1060
Jamie Madill6f755b22018-10-09 12:48:54 -04001061angle::Result FramebufferVk::syncState(const gl::Context *context,
1062 const gl::Framebuffer::DirtyBits &dirtyBits)
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001063{
Jamie Madille1f3ad42017-10-28 23:00:42 -04001064 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001065
1066 ASSERT(dirtyBits.any());
Jamie Madill57d9cbb2018-04-27 11:45:04 -04001067 for (size_t dirtyBit : dirtyBits)
1068 {
1069 switch (dirtyBit)
1070 {
1071 case gl::Framebuffer::DIRTY_BIT_DEPTH_ATTACHMENT:
1072 case gl::Framebuffer::DIRTY_BIT_STENCIL_ATTACHMENT:
1073 ANGLE_TRY(mRenderTargetCache.updateDepthStencilRenderTarget(context, mState));
1074 break;
Jamie Madill67220092019-05-20 11:12:53 -04001075 case gl::Framebuffer::DIRTY_BIT_DEPTH_BUFFER_CONTENTS:
1076 case gl::Framebuffer::DIRTY_BIT_STENCIL_BUFFER_CONTENTS:
1077 ANGLE_TRY(mRenderTargetCache.getDepthStencil()->flushStagedUpdates(contextVk));
1078 break;
Jamie Madill57d9cbb2018-04-27 11:45:04 -04001079 case gl::Framebuffer::DIRTY_BIT_DRAW_BUFFERS:
1080 case gl::Framebuffer::DIRTY_BIT_READ_BUFFER:
1081 case gl::Framebuffer::DIRTY_BIT_DEFAULT_WIDTH:
1082 case gl::Framebuffer::DIRTY_BIT_DEFAULT_HEIGHT:
1083 case gl::Framebuffer::DIRTY_BIT_DEFAULT_SAMPLES:
1084 case gl::Framebuffer::DIRTY_BIT_DEFAULT_FIXED_SAMPLE_LOCATIONS:
1085 break;
1086 default:
1087 {
Jamie Madill67220092019-05-20 11:12:53 -04001088 static_assert(gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0 == 0, "FB dirty bits");
1089 if (dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_MAX)
Jamie Madill9aef3672018-04-27 11:45:06 -04001090 {
Jamie Madill67220092019-05-20 11:12:53 -04001091 size_t colorIndexGL = static_cast<size_t>(
1092 dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0);
1093 ANGLE_TRY(updateColorAttachment(context, colorIndexGL));
Jamie Madill9aef3672018-04-27 11:45:06 -04001094 }
1095 else
1096 {
Jamie Madill67220092019-05-20 11:12:53 -04001097 ASSERT(dirtyBit >= gl::Framebuffer::DIRTY_BIT_COLOR_BUFFER_CONTENTS_0 &&
1098 dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_BUFFER_CONTENTS_MAX);
1099 size_t colorIndexGL = static_cast<size_t>(
1100 dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_BUFFER_CONTENTS_0);
1101 ANGLE_TRY(mRenderTargetCache.getColors()[colorIndexGL]->flushStagedUpdates(
1102 contextVk));
Jamie Madill9aef3672018-04-27 11:45:06 -04001103 }
Jamie Madill57d9cbb2018-04-27 11:45:04 -04001104 break;
1105 }
1106 }
1107 }
Jamie Madill66546be2018-03-08 09:47:20 -05001108
Jamie Madill9aef3672018-04-27 11:45:06 -04001109 mActiveColorComponents = gl_vk::GetColorComponentFlags(
Luc Ferron5fd36932018-06-19 14:55:50 -04001110 mActiveColorComponentMasksForClear[0].any(), mActiveColorComponentMasksForClear[1].any(),
1111 mActiveColorComponentMasksForClear[2].any(), mActiveColorComponentMasksForClear[3].any());
Jamie Madill9aef3672018-04-27 11:45:06 -04001112
Geoff Langee244c72019-05-06 10:30:18 -04001113 mFramebuffer.release(contextVk);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001114
Jamie Madill316c6062018-05-29 10:49:45 -04001115 // Will freeze the current set of dependencies on this FBO. The next time we render we will
Jamie Madilla5e06072018-05-18 14:36:05 -04001116 // create a new entry in the command graph.
Geoff Langee244c72019-05-06 10:30:18 -04001117 mFramebuffer.finishCurrentCommands(contextVk);
Jamie Madill72106562017-03-24 14:18:50 -04001118
Jamie Madilldbc605c2019-01-04 16:39:14 -05001119 // Notify the ContextVk to update the pipeline desc.
1120 updateRenderPassDesc();
1121 contextVk->onFramebufferChange(mRenderPassDesc);
Jamie Madill19fa1c62018-03-08 09:47:21 -05001122
Jamie Madill7c985f52018-11-29 18:16:17 -05001123 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -05001124}
1125
Jamie Madilldbc605c2019-01-04 16:39:14 -05001126void FramebufferVk::updateRenderPassDesc()
Jamie Madillab9f9c32017-01-17 17:47:34 -05001127{
Jamie Madilldbc605c2019-01-04 16:39:14 -05001128 mRenderPassDesc = {};
1129 mRenderPassDesc.setSamples(getSamples());
Jamie Madillab9f9c32017-01-17 17:47:34 -05001130
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001131 const auto &colorRenderTargets = mRenderTargetCache.getColors();
1132 const gl::DrawBufferMask enabledDrawBuffers = mState.getEnabledDrawBuffers();
1133 for (size_t colorIndexGL = 0; colorIndexGL < enabledDrawBuffers.size(); ++colorIndexGL)
Jamie Madillab9f9c32017-01-17 17:47:34 -05001134 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001135 if (enabledDrawBuffers[colorIndexGL])
1136 {
1137 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
1138 ASSERT(colorRenderTarget);
1139 mRenderPassDesc.packColorAttachment(
1140 colorIndexGL, colorRenderTarget->getImage().getFormat().angleFormatID);
1141 }
1142 else
1143 {
1144 mRenderPassDesc.packColorAttachmentGap(colorIndexGL);
1145 }
Jamie Madillab9f9c32017-01-17 17:47:34 -05001146 }
1147
Jamie Madill66546be2018-03-08 09:47:20 -05001148 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1149 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -05001150 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001151 mRenderPassDesc.packDepthStencilAttachment(
1152 depthStencilRenderTarget->getImage().getFormat().angleFormatID);
Jamie Madillab9f9c32017-01-17 17:47:34 -05001153 }
Jamie Madillab9f9c32017-01-17 17:47:34 -05001154}
1155
Jamie Madill21061022018-07-12 23:56:30 -04001156angle::Result FramebufferVk::getFramebuffer(ContextVk *contextVk, vk::Framebuffer **framebufferOut)
Jamie Madillab9f9c32017-01-17 17:47:34 -05001157{
1158 // If we've already created our cached Framebuffer, return it.
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001159 if (mFramebuffer.valid())
Jamie Madillab9f9c32017-01-17 17:47:34 -05001160 {
Jamie Madille8dd0792018-09-27 15:04:27 -04001161 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -05001162 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -05001163 }
1164
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001165 vk::RenderPass *compatibleRenderPass = nullptr;
Geoff Langee244c72019-05-06 10:30:18 -04001166 ANGLE_TRY(contextVk->getCompatibleRenderPass(mRenderPassDesc, &compatibleRenderPass));
Jamie Madillab9f9c32017-01-17 17:47:34 -05001167
1168 // If we've a Framebuffer provided by a Surface (default FBO/backbuffer), query it.
1169 if (mBackbuffer)
1170 {
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001171 return mBackbuffer->getCurrentFramebuffer(contextVk, *compatibleRenderPass, framebufferOut);
Jamie Madillab9f9c32017-01-17 17:47:34 -05001172 }
1173
1174 // Gather VkImageViews over all FBO attachments, also size of attached region.
1175 std::vector<VkImageView> attachments;
1176 gl::Extents attachmentsSize;
1177
Jamie Madill66546be2018-03-08 09:47:20 -05001178 const auto &colorRenderTargets = mRenderTargetCache.getColors();
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001179 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Jamie Madillab9f9c32017-01-17 17:47:34 -05001180 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001181 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
Jamie Madill66546be2018-03-08 09:47:20 -05001182 ASSERT(colorRenderTarget);
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +01001183 attachments.push_back(colorRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -05001184
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001185 ASSERT(attachmentsSize.empty() || attachmentsSize == colorRenderTarget->getExtents());
1186 attachmentsSize = colorRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -05001187 }
1188
Jamie Madill66546be2018-03-08 09:47:20 -05001189 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1190 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -05001191 {
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +01001192 attachments.push_back(depthStencilRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -05001193
Jamie Madillbc543422018-03-30 10:43:19 -04001194 ASSERT(attachmentsSize.empty() ||
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001195 attachmentsSize == depthStencilRenderTarget->getExtents());
1196 attachmentsSize = depthStencilRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -05001197 }
1198
Shahbaz Youssefi06270c92018-10-03 17:00:25 -04001199 VkFramebufferCreateInfo framebufferInfo = {};
Jamie Madillab9f9c32017-01-17 17:47:34 -05001200
1201 framebufferInfo.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO;
Jamie Madillab9f9c32017-01-17 17:47:34 -05001202 framebufferInfo.flags = 0;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001203 framebufferInfo.renderPass = compatibleRenderPass->getHandle();
Jamie Madillab9f9c32017-01-17 17:47:34 -05001204 framebufferInfo.attachmentCount = static_cast<uint32_t>(attachments.size());
1205 framebufferInfo.pAttachments = attachments.data();
1206 framebufferInfo.width = static_cast<uint32_t>(attachmentsSize.width);
1207 framebufferInfo.height = static_cast<uint32_t>(attachmentsSize.height);
1208 framebufferInfo.layers = 1;
1209
Jamie Madill21061022018-07-12 23:56:30 -04001210 ANGLE_TRY(mFramebuffer.init(contextVk, framebufferInfo));
Jamie Madill5deea722017-02-16 10:44:46 -05001211
Jamie Madille8dd0792018-09-27 15:04:27 -04001212 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -05001213 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001214}
1215
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001216angle::Result FramebufferVk::clearWithRenderPassOp(
1217 ContextVk *contextVk,
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001218 const gl::Rectangle &clearArea,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001219 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001220 bool clearDepth,
1221 bool clearStencil,
1222 const VkClearColorValue &clearColorValue,
1223 const VkClearDepthStencilValue &clearDepthStencilValue)
1224{
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001225 // Start a new render pass if:
1226 //
1227 // - no render pass has started,
1228 // - there is a render pass started but it contains commands; we cannot modify its ops, so new
1229 // render pass is needed,
1230 // - the current render area doesn't match the clear area. We need the render area to be
1231 // exactly as specified by the scissor for the loadOp to clear only that area. See
1232 // onScissorChange for more information.
1233
1234 if (!mFramebuffer.valid() || !mFramebuffer.renderPassStartedButEmpty() ||
1235 mFramebuffer.getRenderPassRenderArea() != clearArea)
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001236 {
1237 vk::CommandBuffer *commandBuffer;
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001238 ANGLE_TRY(startNewRenderPass(contextVk, clearArea, &commandBuffer));
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001239 }
1240
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001241 size_t attachmentIndexVk = 0;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001242
1243 // Go through clearColorBuffers and set the appropriate loadOp and clear values.
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001244 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001245 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001246 if (clearColorBuffers.test(colorIndexGL))
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001247 {
1248 RenderTargetVk *renderTarget = getColorReadRenderTarget();
1249
1250 // If the render target doesn't have alpha, but its emulated format has it, clear the
1251 // alpha to 1.
1252 VkClearColorValue value = clearColorValue;
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001253 if (mEmulatedAlphaAttachmentMask[colorIndexGL])
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001254 {
1255 SetEmulatedAlphaValue(renderTarget->getImageFormat(), &value);
1256 }
1257
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001258 mFramebuffer.clearRenderPassColorAttachment(attachmentIndexVk, value);
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001259 }
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001260 ++attachmentIndexVk;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001261 }
1262
1263 // Set the appropriate loadOp and clear values for depth and stencil.
1264 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1265 if (depthStencilRenderTarget)
1266 {
1267 if (clearDepth)
1268 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001269 mFramebuffer.clearRenderPassDepthAttachment(attachmentIndexVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001270 clearDepthStencilValue.depth);
1271 }
1272
1273 if (clearStencil)
1274 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001275 mFramebuffer.clearRenderPassStencilAttachment(attachmentIndexVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001276 clearDepthStencilValue.stencil);
1277 }
1278 }
1279
1280 return angle::Result::Continue;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001281}
1282
Jamie Madill21061022018-07-12 23:56:30 -04001283angle::Result FramebufferVk::clearWithDraw(ContextVk *contextVk,
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001284 const gl::Rectangle &clearArea,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001285 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001286 bool clearStencil,
1287 VkColorComponentFlags colorMaskFlags,
1288 uint8_t stencilMask,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001289 const VkClearColorValue &clearColorValue,
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001290 uint8_t clearStencilValue)
Jamie Madill9aef3672018-04-27 11:45:06 -04001291{
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001292 UtilsVk::ClearFramebufferParameters params = {};
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001293 params.clearArea = clearArea;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001294 params.colorClearValue = clearColorValue;
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001295 params.stencilClearValue = clearStencilValue;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001296 params.stencilMask = stencilMask;
1297
1298 params.clearColor = true;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001299 params.clearStencil = clearStencil;
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001300
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001301 const auto &colorRenderTargets = mRenderTargetCache.getColors();
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001302 for (size_t colorIndexGL : clearColorBuffers)
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001303 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001304 const RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001305 ASSERT(colorRenderTarget);
1306
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001307 params.colorFormat = &colorRenderTarget->getImage().getFormat().imageFormat();
1308 params.colorAttachmentIndexGL = colorIndexGL;
1309 params.colorMaskFlags = colorMaskFlags;
1310 if (mEmulatedAlphaAttachmentMask[colorIndexGL])
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001311 {
1312 params.colorMaskFlags &= ~VK_COLOR_COMPONENT_A_BIT;
1313 }
1314
Geoff Langee244c72019-05-06 10:30:18 -04001315 ANGLE_TRY(contextVk->getUtils().clearFramebuffer(contextVk, this, params));
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001316
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001317 // Clear stencil only once!
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001318 params.clearStencil = false;
1319 }
1320
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001321 // If there was no color clear, clear stencil alone.
1322 if (params.clearStencil)
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001323 {
1324 params.clearColor = false;
Geoff Langee244c72019-05-06 10:30:18 -04001325 ANGLE_TRY(contextVk->getUtils().clearFramebuffer(contextVk, this, params));
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001326 }
1327
1328 return angle::Result::Continue;
Jamie Madill9aef3672018-04-27 11:45:06 -04001329}
1330
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001331angle::Result FramebufferVk::getSamplePosition(const gl::Context *context,
1332 size_t index,
1333 GLfloat *xy) const
JiangYizhoubddc46b2016-12-09 09:50:51 +08001334{
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001335 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -05001336 return angle::Result::Stop;
JiangYizhoubddc46b2016-12-09 09:50:51 +08001337}
1338
Jamie Madilld1249de2018-08-28 16:58:53 -04001339angle::Result FramebufferVk::startNewRenderPass(ContextVk *contextVk,
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001340 const gl::Rectangle &renderArea,
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001341 vk::CommandBuffer **commandBufferOut)
Jamie Madilld1249de2018-08-28 16:58:53 -04001342{
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001343 vk::Framebuffer *framebuffer = nullptr;
Jamie Madill21061022018-07-12 23:56:30 -04001344 ANGLE_TRY(getFramebuffer(contextVk, &framebuffer));
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001345
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001346 vk::AttachmentOpsArray renderPassAttachmentOps;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001347 std::vector<VkClearValue> attachmentClearValues;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001348
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001349 vk::CommandBuffer *writeCommands = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001350 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &writeCommands));
Jamie Madille4c5a232018-03-02 21:00:31 -05001351
Jamie Madill49ac74b2017-12-21 14:42:33 -05001352 // Initialize RenderPass info.
Jamie Madill66546be2018-03-08 09:47:20 -05001353 const auto &colorRenderTargets = mRenderTargetCache.getColors();
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001354 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Jamie Madill4c26fc22017-02-24 11:04:10 -05001355 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001356 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
Jamie Madill66546be2018-03-08 09:47:20 -05001357 ASSERT(colorRenderTarget);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001358
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001359 ANGLE_TRY(colorRenderTarget->onColorDraw(contextVk, &mFramebuffer, writeCommands));
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001360
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001361 renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(),
1362 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
1363 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL);
1364 attachmentClearValues.emplace_back(kUninitializedClearValue);
Jamie Madill66546be2018-03-08 09:47:20 -05001365 }
1366
1367 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1368 if (depthStencilRenderTarget)
1369 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001370 ANGLE_TRY(
1371 depthStencilRenderTarget->onDepthStencilDraw(contextVk, &mFramebuffer, writeCommands));
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001372
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001373 renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(),
1374 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL,
1375 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
1376 attachmentClearValues.emplace_back(kUninitializedClearValue);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001377 }
1378
Jamie Madilldbc605c2019-01-04 16:39:14 -05001379 return mFramebuffer.beginRenderPass(contextVk, *framebuffer, renderArea, mRenderPassDesc,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001380 renderPassAttachmentOps, attachmentClearValues,
1381 commandBufferOut);
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001382}
1383
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001384void FramebufferVk::updateActiveColorMasks(size_t colorIndexGL, bool r, bool g, bool b, bool a)
Jamie Madill9aef3672018-04-27 11:45:06 -04001385{
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001386 mActiveColorComponentMasksForClear[0].set(colorIndexGL, r);
1387 mActiveColorComponentMasksForClear[1].set(colorIndexGL, g);
1388 mActiveColorComponentMasksForClear[2].set(colorIndexGL, b);
1389 mActiveColorComponentMasksForClear[3].set(colorIndexGL, a);
Luc Ferron5fd36932018-06-19 14:55:50 -04001390}
1391
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001392const gl::DrawBufferMask &FramebufferVk::getEmulatedAlphaAttachmentMask() const
Luc Ferron5fd36932018-06-19 14:55:50 -04001393{
1394 return mEmulatedAlphaAttachmentMask;
Jamie Madill9aef3672018-04-27 11:45:06 -04001395}
Luc Ferron018709f2018-05-10 13:53:11 -04001396
Jamie Madill21061022018-07-12 23:56:30 -04001397angle::Result FramebufferVk::readPixelsImpl(ContextVk *contextVk,
1398 const gl::Rectangle &area,
1399 const PackPixelsParams &packPixelsParams,
Jamie Madillb436aac2018-07-18 17:23:48 -04001400 VkImageAspectFlagBits copyAspectFlags,
Jamie Madill21061022018-07-12 23:56:30 -04001401 RenderTargetVk *renderTarget,
1402 void *pixels)
Luc Ferron018709f2018-05-10 13:53:11 -04001403{
Tobin Ehlis4a419142019-02-05 08:50:30 -07001404 TRACE_EVENT0("gpu.angle", "FramebufferVk::readPixelsImpl");
Jamie Madill58675012018-05-22 14:54:07 -04001405
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001406 RendererVk *renderer = contextVk->getRenderer();
1407
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001408 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001409 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Jamie Madill58675012018-05-22 14:54:07 -04001410
Jamie Madillbcf467f2018-05-23 09:46:00 -04001411 // Note that although we're reading from the image, we need to update the layout below.
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -05001412 vk::ImageHelper *srcImage =
1413 renderTarget->getImageForRead(&mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Jamie Madillbcf467f2018-05-23 09:46:00 -04001414
Jamie Madill0631e192019-04-18 16:09:12 -04001415 const angle::Format *readFormat = &srcImage->getFormat().imageFormat();
Luc Ferron1617e692018-07-11 11:08:19 -04001416
Jamie Madillb436aac2018-07-18 17:23:48 -04001417 if (copyAspectFlags != VK_IMAGE_ASPECT_COLOR_BIT)
Luc Ferron1617e692018-07-11 11:08:19 -04001418 {
Jamie Madillb436aac2018-07-18 17:23:48 -04001419 readFormat = &GetDepthStencilImageToBufferFormat(*readFormat, copyAspectFlags);
Luc Ferron1617e692018-07-11 11:08:19 -04001420 }
1421
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001422 size_t level = renderTarget->getLevelIndex();
1423 size_t layer = renderTarget->getLayerIndex();
1424 VkOffset3D srcOffset = {area.x, area.y, 0};
1425 VkExtent3D srcExtent = {static_cast<uint32_t>(area.width), static_cast<uint32_t>(area.height),
1426 1};
1427
1428 // If the source image is multisampled, we need to resolve it into a temporary image before
1429 // performing a readback.
1430 bool isMultisampled = srcImage->getSamples() > 1;
1431 vk::Scoped<vk::ImageHelper> resolvedImage(contextVk->getDevice());
1432 if (isMultisampled)
1433 {
1434 ANGLE_TRY(resolvedImage.get().init2DStaging(
1435 contextVk, renderer->getMemoryProperties(), gl::Extents(area.width, area.height, 1),
1436 srcImage->getFormat(),
1437 VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT, 1));
Geoff Langee244c72019-05-06 10:30:18 -04001438 resolvedImage.get().updateQueueSerial(contextVk->getCurrentQueueSerial());
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001439
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -04001440 // Note: resolve only works on color images (not depth/stencil).
1441 //
1442 // TODO: Currently, depth/stencil blit can perform a depth/stencil readback, but that code
1443 // path will be optimized away. http://anglebug.com/3200
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001444 ASSERT(copyAspectFlags == VK_IMAGE_ASPECT_COLOR_BIT);
1445
1446 VkImageResolve resolveRegion = {};
1447 resolveRegion.srcSubresource.aspectMask = copyAspectFlags;
1448 resolveRegion.srcSubresource.mipLevel = level;
1449 resolveRegion.srcSubresource.baseArrayLayer = layer;
1450 resolveRegion.srcSubresource.layerCount = 1;
1451 resolveRegion.srcOffset = srcOffset;
1452 resolveRegion.dstSubresource.aspectMask = copyAspectFlags;
1453 resolveRegion.dstSubresource.mipLevel = 0;
1454 resolveRegion.dstSubresource.baseArrayLayer = 0;
1455 resolveRegion.dstSubresource.layerCount = 1;
1456 resolveRegion.dstOffset = {};
1457 resolveRegion.extent = srcExtent;
1458
1459 srcImage->resolve(&resolvedImage.get(), resolveRegion, commandBuffer);
1460
1461 resolvedImage.get().changeLayout(copyAspectFlags, vk::ImageLayout::TransferSrc,
1462 commandBuffer);
1463
1464 // Make the resolved image the target of buffer copy.
1465 srcImage = &resolvedImage.get();
1466 level = 0;
1467 layer = 0;
1468 srcOffset = {0, 0, 0};
1469 }
1470
Jamie Madillb980c562018-11-27 11:34:27 -05001471 VkBuffer bufferHandle = VK_NULL_HANDLE;
1472 uint8_t *readPixelBuffer = nullptr;
Jamie Madill4c310832018-08-29 13:43:17 -04001473 VkDeviceSize stagingOffset = 0;
Jamie Madillb980c562018-11-27 11:34:27 -05001474 size_t allocationSize = readFormat->pixelBytes * area.width * area.height;
Luc Ferron018709f2018-05-10 13:53:11 -04001475
Jamie Madilld754eb52018-07-19 14:55:03 -04001476 ANGLE_TRY(mReadPixelBuffer.allocate(contextVk, allocationSize, &readPixelBuffer, &bufferHandle,
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -05001477 &stagingOffset, nullptr));
Luc Ferron018709f2018-05-10 13:53:11 -04001478
Shahbaz Youssefi06270c92018-10-03 17:00:25 -04001479 VkBufferImageCopy region = {};
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001480 region.bufferImageHeight = srcExtent.height;
Jamie Madill4c310832018-08-29 13:43:17 -04001481 region.bufferOffset = stagingOffset;
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001482 region.bufferRowLength = srcExtent.width;
1483 region.imageExtent = srcExtent;
1484 region.imageOffset = srcOffset;
Luc Ferron1617e692018-07-11 11:08:19 -04001485 region.imageSubresource.aspectMask = copyAspectFlags;
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001486 region.imageSubresource.baseArrayLayer = layer;
Luc Ferron534b00d2018-05-18 08:16:53 -04001487 region.imageSubresource.layerCount = 1;
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001488 region.imageSubresource.mipLevel = level;
Luc Ferron534b00d2018-05-18 08:16:53 -04001489
Jamie Madillbcf467f2018-05-23 09:46:00 -04001490 commandBuffer->copyImageToBuffer(srcImage->getImage(), srcImage->getCurrentLayout(),
1491 bufferHandle, 1, &region);
Luc Ferron018709f2018-05-10 13:53:11 -04001492
1493 // Triggers a full finish.
1494 // TODO(jmadill): Don't block on asynchronous readback.
Geoff Lang892d1802019-03-27 14:21:34 -04001495 ANGLE_TRY(contextVk->finishImpl());
Luc Ferron018709f2018-05-10 13:53:11 -04001496
Luc Ferron534b00d2018-05-18 08:16:53 -04001497 // The buffer we copied to needs to be invalidated before we read from it because its not been
1498 // created with the host coherent bit.
Jamie Madilld754eb52018-07-19 14:55:03 -04001499 ANGLE_TRY(mReadPixelBuffer.invalidate(contextVk));
Yuly Novikov6c6c76c2018-05-17 18:45:06 +00001500
Jamie Madillb436aac2018-07-18 17:23:48 -04001501 PackPixels(packPixelsParams, *readFormat, area.width * readFormat->pixelBytes, readPixelBuffer,
Rafael Cintron05a449a2018-06-20 18:08:04 -07001502 static_cast<uint8_t *>(pixels));
Luc Ferron018709f2018-05-10 13:53:11 -04001503
Jamie Madill7c985f52018-11-29 18:16:17 -05001504 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -04001505}
Jamie Madill58675012018-05-22 14:54:07 -04001506
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001507gl::Extents FramebufferVk::getReadImageExtents() const
Jamie Madill58675012018-05-22 14:54:07 -04001508{
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001509 ASSERT(getColorReadRenderTarget()->getExtents().width == mState.getDimensions().width);
1510 ASSERT(getColorReadRenderTarget()->getExtents().height == mState.getDimensions().height);
1511
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001512 return getColorReadRenderTarget()->getExtents();
Jamie Madill58675012018-05-22 14:54:07 -04001513}
Jamie Madill502d2e22018-11-01 11:06:23 -04001514
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001515gl::Rectangle FramebufferVk::getCompleteRenderArea() const
1516{
1517 return gl::Rectangle(0, 0, mState.getDimensions().width, mState.getDimensions().height);
1518}
1519
1520gl::Rectangle FramebufferVk::getScissoredRenderArea(ContextVk *contextVk) const
1521{
1522 const gl::Rectangle renderArea(0, 0, mState.getDimensions().width,
1523 mState.getDimensions().height);
1524 bool invertViewport = contextVk->isViewportFlipEnabledForDrawFBO();
1525
1526 return ClipRectToScissor(contextVk->getState(), renderArea, invertViewport);
1527}
1528
1529void FramebufferVk::onScissorChange(ContextVk *contextVk)
1530{
1531 gl::Rectangle scissoredRenderArea = getScissoredRenderArea(contextVk);
1532
1533 // If the scissor has grown beyond the previous scissoredRenderArea, make sure the render pass
1534 // is restarted. Otherwise, we can continue using the same renderpass area.
1535 //
1536 // Without a scissor, the render pass area covers the whole of the framebuffer. With a
1537 // scissored clear, the render pass area could be smaller than the framebuffer size. When the
1538 // scissor changes, if the scissor area is completely encompassed by the render pass area, it's
1539 // possible to continue using the same render pass. However, if the current render pass area
1540 // is too small, we need to start a new one. The latter can happen if a scissored clear starts
1541 // a render pass, the scissor is disabled and a draw call is issued to affect the whole
1542 // framebuffer.
Geoff Langee244c72019-05-06 10:30:18 -04001543 mFramebuffer.updateQueueSerial(contextVk->getCurrentQueueSerial());
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001544 if (mFramebuffer.hasStartedRenderPass() &&
1545 !mFramebuffer.getRenderPassRenderArea().encloses(scissoredRenderArea))
1546 {
Geoff Langee244c72019-05-06 10:30:18 -04001547 mFramebuffer.finishCurrentCommands(contextVk);
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001548 }
1549}
1550
Jamie Madill502d2e22018-11-01 11:06:23 -04001551RenderTargetVk *FramebufferVk::getFirstRenderTarget() const
1552{
1553 for (auto *renderTarget : mRenderTargetCache.getColors())
1554 {
1555 if (renderTarget)
1556 {
1557 return renderTarget;
1558 }
1559 }
1560
1561 return mRenderTargetCache.getDepthStencil();
1562}
1563
1564GLint FramebufferVk::getSamples() const
1565{
1566 RenderTargetVk *firstRT = getFirstRenderTarget();
1567 return firstRT ? firstRT->getImage().getSamples() : 0;
1568}
1569
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001570} // namespace rx