blob: 38851914391d215fccbd4408188e4c77bfb3b3f5 [file] [log] [blame]
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001//
2// Copyright 2016 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6// FramebufferVk.cpp:
7// Implements the class methods for FramebufferVk.
8//
9
10#include "libANGLE/renderer/vulkan/FramebufferVk.h"
11
Jamie Madill7b57b9d2017-01-13 09:33:38 -050012#include <vulkan/vulkan.h>
Jamie Madill231c7f52017-04-26 13:45:37 -040013#include <array>
Jamie Madill7b57b9d2017-01-13 09:33:38 -050014
Jamie Madill9e54b5a2016-05-25 12:57:39 -040015#include "common/debug.h"
Jamie Madillc564c072017-06-01 12:45:42 -040016#include "libANGLE/Context.h"
17#include "libANGLE/Display.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050018#include "libANGLE/formatutils.h"
19#include "libANGLE/renderer/renderer_utils.h"
Jamie Madill1f46bc12018-02-20 16:09:43 -050020#include "libANGLE/renderer/vulkan/CommandGraph.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050021#include "libANGLE/renderer/vulkan/ContextVk.h"
Jamie Madill5deea722017-02-16 10:44:46 -050022#include "libANGLE/renderer/vulkan/DisplayVk.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050023#include "libANGLE/renderer/vulkan/RenderTargetVk.h"
24#include "libANGLE/renderer/vulkan/RendererVk.h"
25#include "libANGLE/renderer/vulkan/SurfaceVk.h"
Jamie Madill3c424b42018-01-19 12:35:09 -050026#include "libANGLE/renderer/vulkan/vk_format_utils.h"
Jamie Madill3ea463b2019-06-19 14:21:33 -040027#include "libANGLE/trace.h"
Jamie Madill9e54b5a2016-05-25 12:57:39 -040028
29namespace rx
30{
31
Jamie Madill7b57b9d2017-01-13 09:33:38 -050032namespace
33{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -040034// The value to assign an alpha channel that's emulated. The type is unsigned int, though it will
35// automatically convert to the actual data type.
36constexpr unsigned int kEmulatedAlphaValue = 1;
37
Luc Ferron534b00d2018-05-18 08:16:53 -040038constexpr size_t kMinReadPixelsBufferSize = 128000;
Mohan Maiya8a43b8c2019-08-02 08:47:13 -070039
40// Alignment value to accommodate the largest known, for now, uncompressed Vulkan format
Shahbaz Youssefic9724352019-08-20 14:55:43 -040041// VK_FORMAT_R64G64B64A64_SFLOAT, while supporting 3-component types such as
42// VK_FORMAT_R16G16B16_SFLOAT.
43constexpr size_t kReadPixelsBufferAlignment = 32 * 3;
Mohan Maiya8a43b8c2019-08-02 08:47:13 -070044
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -040045// Clear values are only used when loadOp=Clear is set in clearWithRenderPassOp. When starting a
46// new render pass, the clear value is set to an unlikely value (bright pink) to stand out better
47// in case of a bug.
48constexpr VkClearValue kUninitializedClearValue = {{{0.95, 0.05, 0.95, 0.95}}};
Luc Ferron534b00d2018-05-18 08:16:53 -040049
Jamie Madill66546be2018-03-08 09:47:20 -050050const gl::InternalFormat &GetReadAttachmentInfo(const gl::Context *context,
51 RenderTargetVk *renderTarget)
Jamie Madill7b57b9d2017-01-13 09:33:38 -050052{
Jamie Madillbc543422018-03-30 10:43:19 -040053 GLenum implFormat =
Jamie Madill0631e192019-04-18 16:09:12 -040054 renderTarget->getImageFormat().imageFormat().fboImplementationInternalFormat;
Jamie Madill66546be2018-03-08 09:47:20 -050055 return gl::GetSizedInternalFormatInfo(implFormat);
Jamie Madill7b57b9d2017-01-13 09:33:38 -050056}
Luc Ferron26581112018-06-21 09:43:08 -040057
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -040058bool HasSrcBlitFeature(RendererVk *renderer, RenderTargetVk *srcRenderTarget)
Luc Ferron26581112018-06-21 09:43:08 -040059{
Jamie Madill0631e192019-04-18 16:09:12 -040060 const VkFormat srcFormat = srcRenderTarget->getImageFormat().vkImageFormat;
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -040061 return renderer->hasImageFormatFeatureBits(srcFormat, VK_FORMAT_FEATURE_BLIT_SRC_BIT);
62}
Luc Ferron26581112018-06-21 09:43:08 -040063
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -040064bool HasDstBlitFeature(RendererVk *renderer, RenderTargetVk *dstRenderTarget)
65{
66 const VkFormat dstFormat = dstRenderTarget->getImageFormat().vkImageFormat;
67 return renderer->hasImageFormatFeatureBits(dstFormat, VK_FORMAT_FEATURE_BLIT_DST_BIT);
68}
69
70// Returns false if destination has any channel the source doesn't. This means that channel was
71// emulated and using the Vulkan blit command would overwrite that emulated channel.
72bool areSrcAndDstColorChannelsBlitCompatible(RenderTargetVk *srcRenderTarget,
73 RenderTargetVk *dstRenderTarget)
74{
75 const angle::Format &srcFormat = srcRenderTarget->getImageFormat().angleFormat();
76 const angle::Format &dstFormat = dstRenderTarget->getImageFormat().angleFormat();
77
78 // Luminance/alpha formats are not renderable, so they can't have ended up in a framebuffer to
79 // participate in a blit.
80 ASSERT(!dstFormat.isLUMA() && !srcFormat.isLUMA());
81
82 // All color formats have the red channel.
83 ASSERT(dstFormat.redBits > 0 && srcFormat.redBits > 0);
84
85 return (dstFormat.greenBits > 0 || srcFormat.greenBits == 0) &&
86 (dstFormat.blueBits > 0 || srcFormat.blueBits == 0) &&
87 (dstFormat.alphaBits > 0 || srcFormat.alphaBits == 0);
88}
89
90bool areSrcAndDstDepthStencilChannelsBlitCompatible(RenderTargetVk *srcRenderTarget,
91 RenderTargetVk *dstRenderTarget)
92{
93 const angle::Format &srcFormat = srcRenderTarget->getImageFormat().angleFormat();
94 const angle::Format &dstFormat = dstRenderTarget->getImageFormat().angleFormat();
95
96 return (dstFormat.depthBits > 0 || srcFormat.depthBits == 0) &&
97 (dstFormat.stencilBits > 0 || srcFormat.stencilBits == 0);
Luc Ferron26581112018-06-21 09:43:08 -040098}
Jamie Madillb436aac2018-07-18 17:23:48 -040099
100// Special rules apply to VkBufferImageCopy with depth/stencil. The components are tightly packed
101// into a depth or stencil section of the destination buffer. See the spec:
102// https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkBufferImageCopy.html
103const angle::Format &GetDepthStencilImageToBufferFormat(const angle::Format &imageFormat,
104 VkImageAspectFlagBits copyAspect)
105{
106 if (copyAspect == VK_IMAGE_ASPECT_STENCIL_BIT)
107 {
108 ASSERT(imageFormat.id == angle::FormatID::D24_UNORM_S8_UINT ||
109 imageFormat.id == angle::FormatID::D32_FLOAT_S8X24_UINT ||
110 imageFormat.id == angle::FormatID::S8_UINT);
111 return angle::Format::Get(angle::FormatID::S8_UINT);
112 }
113
114 ASSERT(copyAspect == VK_IMAGE_ASPECT_DEPTH_BIT);
115
116 switch (imageFormat.id)
117 {
118 case angle::FormatID::D16_UNORM:
119 return imageFormat;
120 case angle::FormatID::D24_UNORM_X8_UINT:
121 return imageFormat;
122 case angle::FormatID::D24_UNORM_S8_UINT:
123 return angle::Format::Get(angle::FormatID::D24_UNORM_X8_UINT);
124 case angle::FormatID::D32_FLOAT:
125 return imageFormat;
126 case angle::FormatID::D32_FLOAT_S8X24_UINT:
127 return angle::Format::Get(angle::FormatID::D32_FLOAT);
128 default:
129 UNREACHABLE();
130 return imageFormat;
131 }
132}
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400133
134void SetEmulatedAlphaValue(const vk::Format &format, VkClearColorValue *value)
135{
136 if (format.vkFormatIsInt)
137 {
138 if (format.vkFormatIsUnsigned)
139 {
140 value->uint32[3] = kEmulatedAlphaValue;
141 }
142 else
143 {
144 value->int32[3] = kEmulatedAlphaValue;
145 }
146 }
147 else
148 {
149 value->float32[3] = kEmulatedAlphaValue;
150 }
151}
Jamie Madillbcf467f2018-05-23 09:46:00 -0400152} // anonymous namespace
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500153
154// static
Jamie Madill639bc902018-07-18 17:08:27 -0400155FramebufferVk *FramebufferVk::CreateUserFBO(RendererVk *renderer, const gl::FramebufferState &state)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500156{
Jamie Madill639bc902018-07-18 17:08:27 -0400157 return new FramebufferVk(renderer, state, nullptr);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500158}
159
160// static
Jamie Madill639bc902018-07-18 17:08:27 -0400161FramebufferVk *FramebufferVk::CreateDefaultFBO(RendererVk *renderer,
162 const gl::FramebufferState &state,
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500163 WindowSurfaceVk *backbuffer)
164{
Jamie Madill639bc902018-07-18 17:08:27 -0400165 return new FramebufferVk(renderer, state, backbuffer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500166}
167
Jamie Madill639bc902018-07-18 17:08:27 -0400168FramebufferVk::FramebufferVk(RendererVk *renderer,
169 const gl::FramebufferState &state,
170 WindowSurfaceVk *backbuffer)
Jamie Madill7f2520f2019-06-26 11:18:33 -0400171 : FramebufferImpl(state), mBackbuffer(backbuffer), mActiveColorComponents(0)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500172{
Mohan Maiya8a43b8c2019-08-02 08:47:13 -0700173 mReadPixelBuffer.init(renderer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, kReadPixelsBufferAlignment,
174 kMinReadPixelsBufferSize, true);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500175}
176
Jamie Madill58675012018-05-22 14:54:07 -0400177FramebufferVk::~FramebufferVk() = default;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400178
Jamie Madillc564c072017-06-01 12:45:42 -0400179void FramebufferVk::destroy(const gl::Context *context)
Jamie Madill5deea722017-02-16 10:44:46 -0500180{
Luc Ferron534b00d2018-05-18 08:16:53 -0400181 ContextVk *contextVk = vk::GetImpl(context);
Geoff Langee244c72019-05-06 10:30:18 -0400182 mFramebuffer.release(contextVk);
Luc Ferron534b00d2018-05-18 08:16:53 -0400183
Geoff Langee244c72019-05-06 10:30:18 -0400184 mReadPixelBuffer.release(contextVk);
Jamie Madill5deea722017-02-16 10:44:46 -0500185}
186
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400187angle::Result FramebufferVk::discard(const gl::Context *context,
188 size_t count,
189 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400190{
Shahbaz Youssefi97123e32019-07-08 15:11:16 -0400191 return invalidate(context, count, attachments);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400192}
193
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400194angle::Result FramebufferVk::invalidate(const gl::Context *context,
195 size_t count,
196 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400197{
Shahbaz Youssefida904482019-07-02 10:49:14 -0400198 mFramebuffer.updateQueueSerial(vk::GetImpl(context)->getCurrentQueueSerial());
199
200 if (mFramebuffer.valid() && mFramebuffer.hasStartedRenderPass())
201 {
202 invalidateImpl(vk::GetImpl(context), count, attachments);
203 }
204
205 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400206}
207
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400208angle::Result FramebufferVk::invalidateSub(const gl::Context *context,
209 size_t count,
210 const GLenum *attachments,
211 const gl::Rectangle &area)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400212{
Shahbaz Youssefida904482019-07-02 10:49:14 -0400213 mFramebuffer.updateQueueSerial(vk::GetImpl(context)->getCurrentQueueSerial());
214
215 // RenderPass' storeOp cannot be made conditional to a specific region, so we only apply this
216 // hint if the requested area encompasses the render area.
217 if (mFramebuffer.valid() && mFramebuffer.hasStartedRenderPass() &&
218 area.encloses(mFramebuffer.getRenderPassRenderArea()))
219 {
220 invalidateImpl(vk::GetImpl(context), count, attachments);
221 }
222
223 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400224}
225
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400226angle::Result FramebufferVk::clear(const gl::Context *context, GLbitfield mask)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400227{
Jamie Madill0cec82a2018-03-14 09:21:07 -0400228 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500229
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400230 bool clearColor = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_COLOR_BUFFER_BIT));
231 bool clearDepth = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_DEPTH_BUFFER_BIT));
232 bool clearStencil = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_STENCIL_BUFFER_BIT));
233 gl::DrawBufferMask clearColorBuffers;
234 if (clearColor)
235 {
236 clearColorBuffers = mState.getEnabledDrawBuffers();
237 }
238
239 const VkClearColorValue &clearColorValue = contextVk->getClearColorValue().color;
240 const VkClearDepthStencilValue &clearDepthStencilValue =
241 contextVk->getClearDepthStencilValue().depthStencil;
242
243 return clearImpl(context, clearColorBuffers, clearDepth, clearStencil, clearColorValue,
244 clearDepthStencilValue);
245}
246
247angle::Result FramebufferVk::clearImpl(const gl::Context *context,
248 gl::DrawBufferMask clearColorBuffers,
249 bool clearDepth,
250 bool clearStencil,
251 const VkClearColorValue &clearColorValue,
252 const VkClearDepthStencilValue &clearDepthStencilValue)
253{
254 ContextVk *contextVk = vk::GetImpl(context);
255
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400256 const gl::Rectangle scissoredRenderArea = getScissoredRenderArea(contextVk);
257
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400258 // Discard clear altogether if scissor has 0 width or height.
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400259 if (scissoredRenderArea.width == 0 || scissoredRenderArea.height == 0)
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400260 {
261 return angle::Result::Continue;
262 }
263
Geoff Langee244c72019-05-06 10:30:18 -0400264 mFramebuffer.updateQueueSerial(contextVk->getCurrentQueueSerial());
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400265
266 // This function assumes that only enabled attachments are asked to be cleared.
267 ASSERT((clearColorBuffers & mState.getEnabledDrawBuffers()) == clearColorBuffers);
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400268
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400269 // Adjust clear behavior based on whether the respective attachments are present; if asked to
270 // clear a non-existent attachment, don't attempt to clear it.
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400271
272 VkColorComponentFlags colorMaskFlags = contextVk->getClearColorMask();
273 bool clearColor = clearColorBuffers.any();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400274
Jamie Madill0cec82a2018-03-14 09:21:07 -0400275 const gl::FramebufferAttachment *depthAttachment = mState.getDepthAttachment();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400276 clearDepth = clearDepth && depthAttachment;
Jamie Madill0cec82a2018-03-14 09:21:07 -0400277 ASSERT(!clearDepth || depthAttachment->isAttached());
278
279 const gl::FramebufferAttachment *stencilAttachment = mState.getStencilAttachment();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400280 clearStencil = clearStencil && stencilAttachment;
Jamie Madill0cec82a2018-03-14 09:21:07 -0400281 ASSERT(!clearStencil || stencilAttachment->isAttached());
282
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400283 uint8_t stencilMask =
284 static_cast<uint8_t>(contextVk->getState().getDepthStencilState().stencilWritemask);
285
286 // The front-end should ensure we don't attempt to clear color if all channels are masked.
287 ASSERT(!clearColor || colorMaskFlags != 0);
288 // The front-end should ensure we don't attempt to clear depth if depth write is disabled.
289 ASSERT(!clearDepth || contextVk->getState().getDepthStencilState().depthMask);
290 // The front-end should ensure we don't attempt to clear stencil if all bits are masked.
291 ASSERT(!clearStencil || stencilMask != 0);
292
293 // If there is nothing to clear, return right away (for example, if asked to clear depth, but
294 // there is no depth attachment).
Shahbaz Youssefi02a579e2019-03-27 14:21:20 -0400295 if (!clearColor && !clearDepth && !clearStencil)
296 {
297 return angle::Result::Continue;
298 }
299
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400300 VkClearDepthStencilValue modifiedDepthStencilValue = clearDepthStencilValue;
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400301
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400302 // We can use render pass load ops if clearing depth, unmasked color or unmasked stencil. If
303 // there's a depth mask, depth clearing is already disabled.
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400304 bool maskedClearColor =
305 clearColor && (mActiveColorComponents & colorMaskFlags) != mActiveColorComponents;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400306 bool maskedClearStencil = stencilMask != 0xFF;
307
308 bool clearColorWithRenderPassLoadOp = clearColor && !maskedClearColor;
309 bool clearStencilWithRenderPassLoadOp = clearStencil && !maskedClearStencil;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400310
311 // At least one of color, depth or stencil should be clearable with render pass loadOp for us
312 // to use this clear path.
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400313 bool clearAnyWithRenderPassLoadOp =
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400314 clearColorWithRenderPassLoadOp || clearDepth || clearStencilWithRenderPassLoadOp;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400315
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400316 if (clearAnyWithRenderPassLoadOp)
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400317 {
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400318 // Clearing color is indicated by the set bits in this mask. If not clearing colors with
319 // render pass loadOp, the default value of all-zeros means the clear is not done in
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400320 // clearWithRenderPassOp below. In that case, only clear depth/stencil with render pass
321 // loadOp.
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400322 gl::DrawBufferMask clearBuffersWithRenderPassLoadOp;
323 if (clearColorWithRenderPassLoadOp)
324 {
325 clearBuffersWithRenderPassLoadOp = clearColorBuffers;
326 }
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400327 ANGLE_TRY(clearWithRenderPassOp(
328 contextVk, scissoredRenderArea, clearBuffersWithRenderPassLoadOp, clearDepth,
329 clearStencilWithRenderPassLoadOp, clearColorValue, modifiedDepthStencilValue));
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400330
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400331 // On some hardware, having inline commands at this point results in corrupted output. In
332 // that case, end the render pass immediately. http://anglebug.com/2361
Jonah Ryan-Davis776694c2019-05-08 10:28:55 -0400333 if (contextVk->getRenderer()->getFeatures().restartRenderPassAfterLoadOpClear.enabled)
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400334 {
Geoff Langee244c72019-05-06 10:30:18 -0400335 mFramebuffer.finishCurrentCommands(contextVk);
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400336 }
337
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400338 // Fallback to other methods for whatever isn't cleared here.
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400339 clearDepth = false;
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400340 if (clearColorWithRenderPassLoadOp)
341 {
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400342 clearColorBuffers.reset();
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400343 clearColor = false;
344 }
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400345 if (clearStencilWithRenderPassLoadOp)
346 {
347 clearStencil = false;
348 }
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400349
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400350 // If nothing left to clear, early out.
351 if (!clearColor && !clearStencil)
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400352 {
353 return angle::Result::Continue;
354 }
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400355 }
356
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -0400357 // Note: depth clear is always done through render pass loadOp.
Shahbaz Youssefi127990f2019-04-04 13:52:04 -0400358 ASSERT(clearDepth == false);
359
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400360 // The most costly clear mode is when we need to mask out specific color channels or stencil
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -0400361 // bits. This can only be done with a draw call.
362 return clearWithDraw(contextVk, scissoredRenderArea, clearColorBuffers, clearStencil,
363 colorMaskFlags, stencilMask, clearColorValue,
364 static_cast<uint8_t>(modifiedDepthStencilValue.stencil));
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400365}
366
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400367angle::Result FramebufferVk::clearBufferfv(const gl::Context *context,
368 GLenum buffer,
369 GLint drawbuffer,
370 const GLfloat *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400371{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400372 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400373
374 bool clearDepth = false;
375 gl::DrawBufferMask clearColorBuffers;
376
377 if (buffer == GL_DEPTH)
378 {
379 clearDepth = true;
380 clearValue.depthStencil.depth = values[0];
381 }
382 else
383 {
384 clearColorBuffers.set(drawbuffer);
385 clearValue.color.float32[0] = values[0];
386 clearValue.color.float32[1] = values[1];
387 clearValue.color.float32[2] = values[2];
388 clearValue.color.float32[3] = values[3];
389 }
390
391 return clearImpl(context, clearColorBuffers, clearDepth, false, clearValue.color,
392 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400393}
394
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400395angle::Result FramebufferVk::clearBufferuiv(const gl::Context *context,
396 GLenum buffer,
397 GLint drawbuffer,
398 const GLuint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400399{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400400 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400401
402 gl::DrawBufferMask clearColorBuffers;
403 clearColorBuffers.set(drawbuffer);
404
405 clearValue.color.uint32[0] = values[0];
406 clearValue.color.uint32[1] = values[1];
407 clearValue.color.uint32[2] = values[2];
408 clearValue.color.uint32[3] = values[3];
409
410 return clearImpl(context, clearColorBuffers, false, false, clearValue.color,
411 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400412}
413
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400414angle::Result FramebufferVk::clearBufferiv(const gl::Context *context,
415 GLenum buffer,
416 GLint drawbuffer,
417 const GLint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400418{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400419 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400420
421 bool clearStencil = false;
422 gl::DrawBufferMask clearColorBuffers;
423
424 if (buffer == GL_STENCIL)
425 {
426 clearStencil = true;
427 clearValue.depthStencil.stencil =
428 gl::clamp(values[0], 0, std::numeric_limits<uint8_t>::max());
429 }
430 else
431 {
432 clearColorBuffers.set(drawbuffer);
433 clearValue.color.int32[0] = values[0];
434 clearValue.color.int32[1] = values[1];
435 clearValue.color.int32[2] = values[2];
436 clearValue.color.int32[3] = values[3];
437 }
438
439 return clearImpl(context, clearColorBuffers, false, clearStencil, clearValue.color,
440 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400441}
442
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400443angle::Result FramebufferVk::clearBufferfi(const gl::Context *context,
444 GLenum buffer,
445 GLint drawbuffer,
446 GLfloat depth,
447 GLint stencil)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400448{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400449 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400450
451 clearValue.depthStencil.depth = depth;
452 clearValue.depthStencil.stencil = gl::clamp(stencil, 0, std::numeric_limits<uint8_t>::max());
453
454 return clearImpl(context, gl::DrawBufferMask(), true, true, clearValue.color,
455 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400456}
457
Jamie Madill4928b7c2017-06-20 12:57:39 -0400458GLenum FramebufferVk::getImplementationColorReadFormat(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400459{
Jamie Madill66546be2018-03-08 09:47:20 -0500460 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).format;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400461}
462
Jamie Madill4928b7c2017-06-20 12:57:39 -0400463GLenum FramebufferVk::getImplementationColorReadType(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400464{
Jamie Madill66546be2018-03-08 09:47:20 -0500465 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).type;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400466}
467
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400468angle::Result FramebufferVk::readPixels(const gl::Context *context,
469 const gl::Rectangle &area,
470 GLenum format,
471 GLenum type,
472 void *pixels)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400473{
Luc Ferrona1c72422018-05-14 15:58:28 -0400474 // Clip read area to framebuffer.
475 const gl::Extents &fbSize = getState().getReadAttachment()->getSize();
476 const gl::Rectangle fbRect(0, 0, fbSize.width, fbSize.height);
Luc Ferronbf6dc372018-06-28 15:24:19 -0400477 ContextVk *contextVk = vk::GetImpl(context);
Luc Ferronbf6dc372018-06-28 15:24:19 -0400478
Luc Ferrona1c72422018-05-14 15:58:28 -0400479 gl::Rectangle clippedArea;
480 if (!ClipRectangle(area, fbRect, &clippedArea))
481 {
482 // nothing to read
Jamie Madill7c985f52018-11-29 18:16:17 -0500483 return angle::Result::Continue;
Luc Ferrona1c72422018-05-14 15:58:28 -0400484 }
Luc Ferronbf6dc372018-06-28 15:24:19 -0400485 gl::Rectangle flippedArea = clippedArea;
Geoff Lange076a232018-07-16 15:34:05 -0400486 if (contextVk->isViewportFlipEnabledForReadFBO())
Luc Ferronbf6dc372018-06-28 15:24:19 -0400487 {
488 flippedArea.y = fbRect.height - flippedArea.y - flippedArea.height;
489 }
Luc Ferrona1c72422018-05-14 15:58:28 -0400490
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500491 const gl::State &glState = context->getState();
Frank Henigman1ffad842018-09-24 23:40:45 -0400492 const gl::PixelPackState &packState = glState.getPackState();
Luc Ferronbf6dc372018-06-28 15:24:19 -0400493
Luc Ferrona1c72422018-05-14 15:58:28 -0400494 const gl::InternalFormat &sizedFormatInfo = gl::GetInternalFormatInfo(format, type);
495
496 GLuint outputPitch = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400497 ANGLE_VK_CHECK_MATH(contextVk,
498 sizedFormatInfo.computeRowPitch(type, area.width, packState.alignment,
499 packState.rowLength, &outputPitch));
Luc Ferrona1c72422018-05-14 15:58:28 -0400500 GLuint outputSkipBytes = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400501 ANGLE_VK_CHECK_MATH(contextVk, sizedFormatInfo.computeSkipBytes(type, outputPitch, 0, packState,
502 false, &outputSkipBytes));
Luc Ferrona1c72422018-05-14 15:58:28 -0400503
504 outputSkipBytes += (clippedArea.x - area.x) * sizedFormatInfo.pixelBytes +
505 (clippedArea.y - area.y) * outputPitch;
Luc Ferron60284222018-03-20 16:01:44 -0400506
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400507 const angle::Format &angleFormat = GetFormatFromFormatType(format, type);
508
Frank Henigman1ffad842018-09-24 23:40:45 -0400509 PackPixelsParams params(flippedArea, angleFormat, outputPitch, packState.reverseRowOrder,
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400510 glState.getTargetBuffer(gl::BufferBinding::PixelPack), 0);
Frank Henigman1ffad842018-09-24 23:40:45 -0400511 if (contextVk->isViewportFlipEnabledForReadFBO())
512 {
513 params.reverseRowOrder = !params.reverseRowOrder;
514 }
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500515
Jamie Madill21061022018-07-12 23:56:30 -0400516 ANGLE_TRY(readPixelsImpl(contextVk, flippedArea, params, VK_IMAGE_ASPECT_COLOR_BIT,
Luc Ferron1617e692018-07-11 11:08:19 -0400517 getColorReadRenderTarget(),
Rafael Cintron05a449a2018-06-20 18:08:04 -0700518 static_cast<uint8_t *>(pixels) + outputSkipBytes));
Jamie Madillc773ab92019-06-25 17:11:58 -0400519 mReadPixelBuffer.releaseInFlightBuffers(contextVk);
Jamie Madill7c985f52018-11-29 18:16:17 -0500520 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -0400521}
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500522
Luc Ferron26581112018-06-21 09:43:08 -0400523RenderTargetVk *FramebufferVk::getDepthStencilRenderTarget() const
524{
525 return mRenderTargetCache.getDepthStencil();
526}
527
Jamie Madill58675012018-05-22 14:54:07 -0400528RenderTargetVk *FramebufferVk::getColorReadRenderTarget() const
Luc Ferron018709f2018-05-10 13:53:11 -0400529{
530 RenderTargetVk *renderTarget = mRenderTargetCache.getColorRead(mState);
Jamie Madillbcf467f2018-05-23 09:46:00 -0400531 ASSERT(renderTarget && renderTarget->getImage().valid());
Luc Ferron018709f2018-05-10 13:53:11 -0400532 return renderTarget;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400533}
534
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400535angle::Result FramebufferVk::blitWithCommand(ContextVk *contextVk,
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400536 const gl::Rectangle &sourceArea,
537 const gl::Rectangle &destArea,
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400538 RenderTargetVk *readRenderTarget,
539 RenderTargetVk *drawRenderTarget,
540 GLenum filter,
541 bool colorBlit,
542 bool depthBlit,
543 bool stencilBlit,
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400544 bool flipX,
545 bool flipY)
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400546{
547 // Since blitRenderbufferRect is called for each render buffer that needs to be blitted,
548 // it should never be the case that both color and depth/stencil need to be blitted at
549 // at the same time.
550 ASSERT(colorBlit != (depthBlit || stencilBlit));
551
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400552 vk::ImageHelper *srcImage = &readRenderTarget->getImage();
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400553 vk::ImageHelper *dstImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
554
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400555 VkImageAspectFlags imageAspectMask = srcImage->getAspectFlags();
556 VkImageAspectFlags blitAspectMask = imageAspectMask;
557
558 // Remove depth or stencil aspects if they are not requested to be blitted.
559 if (!depthBlit)
560 {
561 blitAspectMask &= ~VK_IMAGE_ASPECT_DEPTH_BIT;
562 }
563 if (!stencilBlit)
564 {
565 blitAspectMask &= ~VK_IMAGE_ASPECT_STENCIL_BIT;
566 }
567
568 if (srcImage->isLayoutChangeNecessary(vk::ImageLayout::TransferSrc))
569 {
570 vk::CommandBuffer *srcLayoutChange;
571 ANGLE_TRY(srcImage->recordCommands(contextVk, &srcLayoutChange));
572 srcImage->changeLayout(imageAspectMask, vk::ImageLayout::TransferSrc, srcLayoutChange);
573 }
574
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400575 vk::CommandBuffer *commandBuffer = nullptr;
576 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
577
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400578 srcImage->addReadDependency(&mFramebuffer);
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400579
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400580 VkImageBlit blit = {};
581 blit.srcSubresource.aspectMask = blitAspectMask;
582 blit.srcSubresource.mipLevel = readRenderTarget->getLevelIndex();
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400583 blit.srcSubresource.baseArrayLayer = readRenderTarget->getLayerIndex();
584 blit.srcSubresource.layerCount = 1;
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400585 blit.srcOffsets[0] = {sourceArea.x0(), sourceArea.y0(), 0};
586 blit.srcOffsets[1] = {sourceArea.x1(), sourceArea.y1(), 1};
587 blit.dstSubresource.aspectMask = blitAspectMask;
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400588 blit.dstSubresource.mipLevel = drawRenderTarget->getLevelIndex();
589 blit.dstSubresource.baseArrayLayer = drawRenderTarget->getLayerIndex();
590 blit.dstSubresource.layerCount = 1;
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400591 blit.dstOffsets[0] = {destArea.x0(), destArea.y0(), 0};
592 blit.dstOffsets[1] = {destArea.x1(), destArea.y1(), 1};
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400593
594 // Requirement of the copyImageToBuffer, the dst image must be in
595 // VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout.
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400596 dstImage->changeLayout(imageAspectMask, vk::ImageLayout::TransferDst, commandBuffer);
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400597
598 commandBuffer->blitImage(srcImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL,
599 dstImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &blit,
600 gl_vk::GetFilter(filter));
601
602 return angle::Result::Continue;
603}
604
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400605angle::Result FramebufferVk::blit(const gl::Context *context,
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400606 const gl::Rectangle &sourceAreaIn,
607 const gl::Rectangle &destAreaIn,
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400608 GLbitfield mask,
609 GLenum filter)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400610{
Luc Ferron26581112018-06-21 09:43:08 -0400611 ContextVk *contextVk = vk::GetImpl(context);
612 RendererVk *renderer = contextVk->getRenderer();
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400613 UtilsVk &utilsVk = contextVk->getUtils();
Luc Ferron26581112018-06-21 09:43:08 -0400614
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400615 const gl::State &glState = contextVk->getState();
616 const gl::Framebuffer *srcFramebuffer = glState.getReadFramebuffer();
617
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400618 const bool blitColorBuffer = (mask & GL_COLOR_BUFFER_BIT) != 0;
619 const bool blitDepthBuffer = (mask & GL_DEPTH_BUFFER_BIT) != 0;
620 const bool blitStencilBuffer = (mask & GL_STENCIL_BUFFER_BIT) != 0;
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400621
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400622 const bool isResolve = srcFramebuffer->getCachedSamples(context) > 1;
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400623
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400624 FramebufferVk *srcFramebufferVk = vk::GetImpl(srcFramebuffer);
625 const bool srcFramebufferFlippedY = contextVk->isViewportFlipEnabledForReadFBO();
626 const bool destFramebufferFlippedY = contextVk->isViewportFlipEnabledForDrawFBO();
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400627
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400628 gl::Rectangle sourceArea = sourceAreaIn;
629 gl::Rectangle destArea = destAreaIn;
630
631 // Note: GLES (all 3.x versions) require source and dest area to be identical when
632 // resolving.
633 ASSERT(!isResolve ||
634 (sourceArea.x == destArea.x && sourceArea.y == destArea.y &&
635 sourceArea.width == destArea.width && sourceArea.height == destArea.height));
636
637 const gl::Rectangle srcFramebufferDimensions =
638 srcFramebufferVk->mState.getDimensions().toRect();
639
640 // If the destination is flipped in either direction, we will flip the source instead so that
641 // the destination area is always unflipped.
642 sourceArea = sourceArea.flip(destArea.isReversedX(), destArea.isReversedY());
643 destArea = destArea.removeReversal();
644
645 // Calculate the stretch factor prior to any clipping, as it needs to remain constant.
646 const float stretch[2] = {
647 std::abs(sourceArea.width / static_cast<float>(destArea.width)),
648 std::abs(sourceArea.height / static_cast<float>(destArea.height)),
649 };
650
651 // First, clip the source area to framebuffer. That requires transforming the dest area to
652 // match the clipped source.
653 gl::Rectangle absSourceArea = sourceArea.removeReversal();
654 gl::Rectangle clippedSourceArea;
655 if (!gl::ClipRectangle(srcFramebufferDimensions, absSourceArea, &clippedSourceArea))
656 {
657 return angle::Result::Continue;
658 }
659
660 // Resize the destination area based on the new size of source. Note again that stretch is
661 // calculated as SrcDimension/DestDimension.
662 gl::Rectangle srcClippedDestArea;
663 if (isResolve)
664 {
665 // Source and dest areas are identical in resolve.
666 srcClippedDestArea = clippedSourceArea;
667 }
668 else if (clippedSourceArea == absSourceArea)
669 {
670 // If there was no clipping, keep dest area as is.
671 srcClippedDestArea = destArea;
672 }
673 else
674 {
675 // Shift dest area's x0,y0,x1,y1 by as much as the source area's got shifted (taking
676 // stretching into account)
677 float x0Shift = std::round((clippedSourceArea.x - absSourceArea.x) / stretch[0]);
678 float y0Shift = std::round((clippedSourceArea.y - absSourceArea.y) / stretch[1]);
679 float x1Shift = std::round((absSourceArea.x1() - clippedSourceArea.x1()) / stretch[0]);
680 float y1Shift = std::round((absSourceArea.y1() - clippedSourceArea.y1()) / stretch[1]);
681
682 // If the source area was reversed in any direction, the shift should be applied in the
683 // opposite direction as well.
684 if (sourceArea.isReversedX())
685 {
686 std::swap(x0Shift, x1Shift);
687 }
688
689 if (sourceArea.isReversedY())
690 {
691 std::swap(y0Shift, y1Shift);
692 }
693
694 srcClippedDestArea.x = destArea.x0() + static_cast<int>(x0Shift);
695 srcClippedDestArea.y = destArea.y0() + static_cast<int>(y0Shift);
696 int x1 = destArea.x1() - static_cast<int>(x1Shift);
697 int y1 = destArea.y1() - static_cast<int>(y1Shift);
698
699 srcClippedDestArea.width = x1 - srcClippedDestArea.x;
700 srcClippedDestArea.height = y1 - srcClippedDestArea.y;
701 }
702
703 // If framebuffers are flipped in Y, flip the source and dest area (which define the
704 // transformation regardless of clipping), as well as the blit area (which is the clipped
705 // dest area).
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400706 if (srcFramebufferFlippedY)
707 {
708 sourceArea.y = srcFramebufferDimensions.height - sourceArea.y;
709 sourceArea.height = -sourceArea.height;
710 }
711 if (destFramebufferFlippedY)
712 {
713 destArea.y = mState.getDimensions().height - destArea.y;
714 destArea.height = -destArea.height;
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400715
716 srcClippedDestArea.y =
717 mState.getDimensions().height - srcClippedDestArea.y - srcClippedDestArea.height;
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400718 }
719
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400720 const bool flipX = sourceArea.isReversedX() != destArea.isReversedX();
721 const bool flipY = sourceArea.isReversedY() != destArea.isReversedY();
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400722
723 // GLES doesn't allow flipping the parameters of glBlitFramebuffer if performing a resolve.
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400724 ASSERT(!isResolve ||
725 (flipX == false && flipY == (srcFramebufferFlippedY != destFramebufferFlippedY)));
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400726
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400727 // Again, transfer the destination flip to source, so dest is unflipped. Note that destArea
728 // was not reversed until the final possible Y-flip.
729 ASSERT(!destArea.isReversedX());
730 sourceArea = sourceArea.flip(false, destArea.isReversedY());
731 destArea = destArea.removeReversal();
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400732
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400733 // Clip the destination area to the framebuffer size and scissor. Note that we don't care
734 // about the source area anymore. The offset translation is done based on the original source
735 // and destination rectangles. The stretch factor is already calculated as well.
736 gl::Rectangle blitArea;
737 if (!gl::ClipRectangle(getScissoredRenderArea(contextVk), srcClippedDestArea, &blitArea))
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400738 {
739 return angle::Result::Continue;
740 }
741
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400742 bool noClip = blitArea == destArea && stretch[0] == 1.0f && stretch[1] == 1.0f;
743 bool noFlip = !flipX && !flipY;
744 bool disableFlippingBlitWithCommand =
745 contextVk->getRenderer()->getFeatures().disableFlippingBlitWithCommand.enabled;
746
Shahbaz Youssefide70a712019-06-03 17:05:16 -0400747 UtilsVk::BlitResolveParameters params;
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400748 params.srcOffset[0] = sourceArea.x;
749 params.srcOffset[1] = sourceArea.y;
750 params.destOffset[0] = destArea.x;
751 params.destOffset[1] = destArea.y;
752 params.stretch[0] = stretch[0];
753 params.stretch[1] = stretch[1];
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400754 params.srcExtents[0] = srcFramebufferDimensions.width;
755 params.srcExtents[1] = srcFramebufferDimensions.height;
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400756 params.blitArea = blitArea;
757 params.linear = filter == GL_LINEAR;
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400758 params.flipX = flipX;
759 params.flipY = flipY;
760
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400761 if (blitColorBuffer)
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400762 {
763 RenderTargetVk *readRenderTarget = srcFramebufferVk->getColorReadRenderTarget();
764 params.srcLayer = readRenderTarget->getLayerIndex();
765
766 // Multisampled images are not allowed to have mips.
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400767 ASSERT(!isResolve || readRenderTarget->getLevelIndex() == 0);
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400768
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400769 // If there was no clipping and the format capabilities allow us, use Vulkan's builtin blit.
770 // The reason clipping is prohibited in this path is that due to rounding errors, it would
771 // be hard to guarantee the image stretching remains perfect. That also allows us not to
772 // have to transform back the dest clipping to source.
773 //
774 // For simplicity, we either blit all render targets with a Vulkan command, or none.
775 bool canBlitWithCommand = !isResolve && noClip &&
776 (noFlip || !disableFlippingBlitWithCommand) &&
777 HasSrcBlitFeature(renderer, readRenderTarget);
778 bool areChannelsBlitCompatible = true;
779 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
780 {
781 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorIndexGL];
782 canBlitWithCommand =
783 canBlitWithCommand && HasDstBlitFeature(renderer, drawRenderTarget);
784 areChannelsBlitCompatible =
785 areChannelsBlitCompatible &&
786 areSrcAndDstColorChannelsBlitCompatible(readRenderTarget, drawRenderTarget);
787 }
788
789 if (canBlitWithCommand && areChannelsBlitCompatible)
790 {
791 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
792 {
793 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorIndexGL];
794 ANGLE_TRY(blitWithCommand(contextVk, sourceArea, destArea, readRenderTarget,
795 drawRenderTarget, filter, true, false, false, flipX,
796 flipY));
797 }
798 }
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400799 // If we're not flipping, use Vulkan's builtin resolve.
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400800 else if (isResolve && !flipX && !flipY && areChannelsBlitCompatible)
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400801 {
802 ANGLE_TRY(resolveColorWithCommand(contextVk, params, &readRenderTarget->getImage()));
803 }
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400804 // Otherwise use a shader to do blit or resolve.
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400805 else
806 {
Shahbaz Youssefide70a712019-06-03 17:05:16 -0400807 ANGLE_TRY(utilsVk.colorBlitResolve(contextVk, this, &readRenderTarget->getImage(),
808 readRenderTarget->getFetchImageView(), params));
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400809 }
810 }
811
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400812 if (blitDepthBuffer || blitStencilBuffer)
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400813 {
814 RenderTargetVk *readRenderTarget = srcFramebufferVk->getDepthStencilRenderTarget();
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400815 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getDepthStencil();
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400816 params.srcLayer = readRenderTarget->getLayerIndex();
817
818 // Multisampled images are not allowed to have mips.
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400819 ASSERT(!isResolve || readRenderTarget->getLevelIndex() == 0);
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400820
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400821 // Similarly, only blit if there's been no clipping.
822 bool canBlitWithCommand = !isResolve && noClip &&
823 (noFlip || !disableFlippingBlitWithCommand) &&
824 HasSrcBlitFeature(renderer, readRenderTarget) &&
825 HasDstBlitFeature(renderer, drawRenderTarget);
826 bool areChannelsBlitCompatible =
827 areSrcAndDstDepthStencilChannelsBlitCompatible(readRenderTarget, drawRenderTarget);
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400828
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400829 if (canBlitWithCommand && areChannelsBlitCompatible)
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400830 {
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400831 ANGLE_TRY(blitWithCommand(contextVk, sourceArea, destArea, readRenderTarget,
832 drawRenderTarget, filter, false, blitDepthBuffer,
833 blitStencilBuffer, flipX, flipY));
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400834 }
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400835 else
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400836 {
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400837 // Create depth- and stencil-only views for reading.
838 vk::Scoped<vk::ImageView> depthView(contextVk->getDevice());
839 vk::Scoped<vk::ImageView> stencilView(contextVk->getDevice());
840
841 vk::ImageHelper *depthStencilImage = &readRenderTarget->getImage();
842 uint32_t levelIndex = readRenderTarget->getLevelIndex();
843 uint32_t layerIndex = readRenderTarget->getLayerIndex();
844 gl::TextureType textureType = vk::Get2DTextureType(depthStencilImage->getLayerCount(),
845 depthStencilImage->getSamples());
846
847 if (blitDepthBuffer)
848 {
849 ANGLE_TRY(depthStencilImage->initLayerImageView(
850 contextVk, textureType, VK_IMAGE_ASPECT_DEPTH_BIT, gl::SwizzleState(),
851 &depthView.get(), levelIndex, 1, layerIndex, 1));
852 }
853
854 if (blitStencilBuffer)
855 {
856 ANGLE_TRY(depthStencilImage->initLayerImageView(
857 contextVk, textureType, VK_IMAGE_ASPECT_STENCIL_BIT, gl::SwizzleState(),
858 &stencilView.get(), levelIndex, 1, layerIndex, 1));
859 }
860
861 // If shader stencil export is not possible, defer stencil blit/stencil to another pass.
862 bool hasShaderStencilExport =
863 contextVk->getRenderer()->getFeatures().supportsShaderStencilExport.enabled;
864
865 // Blit depth. If shader stencil export is present, blit stencil as well.
866 if (blitDepthBuffer || (blitStencilBuffer && hasShaderStencilExport))
867 {
868 vk::ImageView *depth = blitDepthBuffer ? &depthView.get() : nullptr;
869 vk::ImageView *stencil =
870 blitStencilBuffer && hasShaderStencilExport ? &stencilView.get() : nullptr;
871
872 ANGLE_TRY(utilsVk.depthStencilBlitResolve(contextVk, this, depthStencilImage, depth,
873 stencil, params));
874 }
875
876 // If shader stencil export is not present, blit stencil through a different path.
877 if (blitStencilBuffer && !hasShaderStencilExport)
878 {
879 ANGLE_TRY(utilsVk.stencilBlitResolveNoShaderExport(
880 contextVk, this, depthStencilImage, &stencilView.get(), params));
881 }
882
883 vk::ImageView depthViewObject = depthView.release();
884 vk::ImageView stencilViewObject = stencilView.release();
885
886 contextVk->releaseObject(contextVk->getCurrentQueueSerial(), &depthViewObject);
887 contextVk->releaseObject(contextVk->getCurrentQueueSerial(), &stencilViewObject);
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400888 }
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400889 }
890
891 return angle::Result::Continue;
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400892} // namespace rx
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400893
894angle::Result FramebufferVk::resolveColorWithCommand(ContextVk *contextVk,
Shahbaz Youssefide70a712019-06-03 17:05:16 -0400895 const UtilsVk::BlitResolveParameters &params,
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400896 vk::ImageHelper *srcImage)
897{
898 if (srcImage->isLayoutChangeNecessary(vk::ImageLayout::TransferSrc))
899 {
900 vk::CommandBuffer *srcLayoutChange;
901 ANGLE_TRY(srcImage->recordCommands(contextVk, &srcLayoutChange));
902 srcImage->changeLayout(VK_IMAGE_ASPECT_COLOR_BIT, vk::ImageLayout::TransferSrc,
903 srcLayoutChange);
904 }
Jamie Madill16c20142018-10-01 13:58:19 -0400905
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400906 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400907 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
908
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400909 // Source's layout change should happen before rendering
910 srcImage->addReadDependency(&mFramebuffer);
Luc Ferron26581112018-06-21 09:43:08 -0400911
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400912 VkImageResolve resolveRegion = {};
913 resolveRegion.srcSubresource.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
914 resolveRegion.srcSubresource.mipLevel = 0;
915 resolveRegion.srcSubresource.baseArrayLayer = params.srcLayer;
916 resolveRegion.srcSubresource.layerCount = 1;
917 resolveRegion.srcOffset.x = params.srcOffset[0];
918 resolveRegion.srcOffset.y = params.srcOffset[1];
919 resolveRegion.srcOffset.z = 0;
920 resolveRegion.dstSubresource.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
921 resolveRegion.dstSubresource.layerCount = 1;
922 resolveRegion.dstOffset.x = params.destOffset[0];
923 resolveRegion.dstOffset.y = params.destOffset[1];
924 resolveRegion.dstOffset.z = 0;
925 resolveRegion.extent.width = params.srcExtents[0];
926 resolveRegion.extent.height = params.srcExtents[1];
927 resolveRegion.extent.depth = 1;
Jamie Madilld754eb52018-07-19 14:55:03 -0400928
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400929 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Luc Ferron82eda932018-07-09 15:10:22 -0400930 {
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400931 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorIndexGL];
Shahbaz Youssefib407e1a2019-06-03 17:15:51 -0400932 vk::ImageHelper *drawImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
933 drawImage->changeLayout(VK_IMAGE_ASPECT_COLOR_BIT, vk::ImageLayout::TransferDst,
934 commandBuffer);
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -0400935
936 resolveRegion.dstSubresource.mipLevel = drawRenderTarget->getLevelIndex();
937 resolveRegion.dstSubresource.baseArrayLayer = drawRenderTarget->getLayerIndex();
938
939 srcImage->resolve(&drawRenderTarget->getImage(), resolveRegion, commandBuffer);
Luc Ferron82eda932018-07-09 15:10:22 -0400940 }
941
Jamie Madill7c985f52018-11-29 18:16:17 -0500942 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400943}
944
Kenneth Russellce8602a2017-10-03 18:23:08 -0700945bool FramebufferVk::checkStatus(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400946{
Luc Ferron5bdf8bd2018-06-20 09:51:37 -0400947 // if we have both a depth and stencil buffer, they must refer to the same object
948 // since we only support packed_depth_stencil and not separate depth and stencil
949 if (mState.hasSeparateDepthAndStencilAttachments())
950 {
951 return false;
952 }
953
Jamie Madillb79e7bb2017-10-24 13:55:50 -0400954 return true;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400955}
956
Jamie Madill67220092019-05-20 11:12:53 -0400957angle::Result FramebufferVk::updateColorAttachment(const gl::Context *context, size_t colorIndexGL)
958{
959 ContextVk *contextVk = vk::GetImpl(context);
960
961 ANGLE_TRY(mRenderTargetCache.updateColorRenderTarget(context, mState, colorIndexGL));
962
963 // Update cached masks for masked clears.
964 RenderTargetVk *renderTarget = mRenderTargetCache.getColors()[colorIndexGL];
965 if (renderTarget)
966 {
967 const angle::Format &emulatedFormat = renderTarget->getImageFormat().imageFormat();
968 updateActiveColorMasks(colorIndexGL, emulatedFormat.redBits > 0,
969 emulatedFormat.greenBits > 0, emulatedFormat.blueBits > 0,
970 emulatedFormat.alphaBits > 0);
971
972 const angle::Format &sourceFormat = renderTarget->getImageFormat().angleFormat();
973 mEmulatedAlphaAttachmentMask.set(
974 colorIndexGL, sourceFormat.alphaBits == 0 && emulatedFormat.alphaBits > 0);
975
976 contextVk->updateColorMask(context->getState().getBlendState());
977 }
978 else
979 {
980 updateActiveColorMasks(colorIndexGL, false, false, false, false);
981 }
982
983 return angle::Result::Continue;
984}
985
Shahbaz Youssefida904482019-07-02 10:49:14 -0400986void FramebufferVk::invalidateImpl(ContextVk *contextVk, size_t count, const GLenum *attachments)
987{
988 ASSERT(mFramebuffer.hasStartedRenderPass());
989
990 gl::DrawBufferMask invalidateColorBuffers;
991 bool invalidateDepthBuffer = false;
992 bool invalidateStencilBuffer = false;
993
994 for (size_t i = 0; i < count; ++i)
995 {
996 const GLenum attachment = attachments[i];
997
998 switch (attachment)
999 {
1000 case GL_DEPTH:
1001 case GL_DEPTH_ATTACHMENT:
1002 invalidateDepthBuffer = true;
1003 break;
1004 case GL_STENCIL:
1005 case GL_STENCIL_ATTACHMENT:
1006 invalidateStencilBuffer = true;
1007 break;
1008 case GL_DEPTH_STENCIL_ATTACHMENT:
1009 invalidateDepthBuffer = true;
1010 invalidateStencilBuffer = true;
1011 break;
1012 default:
1013 ASSERT(
1014 (attachment >= GL_COLOR_ATTACHMENT0 && attachment <= GL_COLOR_ATTACHMENT15) ||
1015 (attachment == GL_COLOR));
1016
1017 invalidateColorBuffers.set(
1018 attachment == GL_COLOR ? 0u : (attachment - GL_COLOR_ATTACHMENT0));
1019 }
1020 }
1021
1022 // Set the appropriate storeOp for attachments.
1023 size_t attachmentIndexVk = 0;
1024 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
1025 {
1026 if (invalidateColorBuffers.test(colorIndexGL))
1027 {
1028 mFramebuffer.invalidateRenderPassColorAttachment(attachmentIndexVk);
1029 }
1030 ++attachmentIndexVk;
1031 }
1032
1033 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1034 if (depthStencilRenderTarget)
1035 {
1036 if (invalidateDepthBuffer)
1037 {
1038 mFramebuffer.invalidateRenderPassDepthAttachment(attachmentIndexVk);
1039 }
1040
1041 if (invalidateStencilBuffer)
1042 {
1043 mFramebuffer.invalidateRenderPassStencilAttachment(attachmentIndexVk);
1044 }
1045 }
1046
1047 // NOTE: Possible future optimization is to delay setting the storeOp and only do so if the
1048 // render pass is closed by itself before another draw call. Otherwise, in a situation like
1049 // this:
1050 //
1051 // draw()
1052 // invalidate()
1053 // draw()
1054 //
1055 // We would be discarding the attachments only to load them for the next draw (which is less
1056 // efficient than keeping the render pass open and not do the discard at all). While dEQP tests
1057 // this pattern, this optimization may not be necessary if no application does this. It is
1058 // expected that an application would invalidate() when it's done with the framebuffer, so the
1059 // render pass would have closed either way.
1060 mFramebuffer.finishCurrentCommands(contextVk);
1061}
1062
Jamie Madill6f755b22018-10-09 12:48:54 -04001063angle::Result FramebufferVk::syncState(const gl::Context *context,
1064 const gl::Framebuffer::DirtyBits &dirtyBits)
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001065{
Jamie Madille1f3ad42017-10-28 23:00:42 -04001066 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001067
1068 ASSERT(dirtyBits.any());
Jamie Madill57d9cbb2018-04-27 11:45:04 -04001069 for (size_t dirtyBit : dirtyBits)
1070 {
1071 switch (dirtyBit)
1072 {
1073 case gl::Framebuffer::DIRTY_BIT_DEPTH_ATTACHMENT:
1074 case gl::Framebuffer::DIRTY_BIT_STENCIL_ATTACHMENT:
1075 ANGLE_TRY(mRenderTargetCache.updateDepthStencilRenderTarget(context, mState));
1076 break;
Jamie Madill67220092019-05-20 11:12:53 -04001077 case gl::Framebuffer::DIRTY_BIT_DEPTH_BUFFER_CONTENTS:
1078 case gl::Framebuffer::DIRTY_BIT_STENCIL_BUFFER_CONTENTS:
1079 ANGLE_TRY(mRenderTargetCache.getDepthStencil()->flushStagedUpdates(contextVk));
1080 break;
Jamie Madill57d9cbb2018-04-27 11:45:04 -04001081 case gl::Framebuffer::DIRTY_BIT_DRAW_BUFFERS:
1082 case gl::Framebuffer::DIRTY_BIT_READ_BUFFER:
1083 case gl::Framebuffer::DIRTY_BIT_DEFAULT_WIDTH:
1084 case gl::Framebuffer::DIRTY_BIT_DEFAULT_HEIGHT:
1085 case gl::Framebuffer::DIRTY_BIT_DEFAULT_SAMPLES:
1086 case gl::Framebuffer::DIRTY_BIT_DEFAULT_FIXED_SAMPLE_LOCATIONS:
1087 break;
1088 default:
1089 {
Jamie Madill67220092019-05-20 11:12:53 -04001090 static_assert(gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0 == 0, "FB dirty bits");
1091 if (dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_MAX)
Jamie Madill9aef3672018-04-27 11:45:06 -04001092 {
Jamie Madill67220092019-05-20 11:12:53 -04001093 size_t colorIndexGL = static_cast<size_t>(
1094 dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0);
1095 ANGLE_TRY(updateColorAttachment(context, colorIndexGL));
Jamie Madill9aef3672018-04-27 11:45:06 -04001096 }
1097 else
1098 {
Jamie Madill67220092019-05-20 11:12:53 -04001099 ASSERT(dirtyBit >= gl::Framebuffer::DIRTY_BIT_COLOR_BUFFER_CONTENTS_0 &&
1100 dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_BUFFER_CONTENTS_MAX);
1101 size_t colorIndexGL = static_cast<size_t>(
1102 dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_BUFFER_CONTENTS_0);
1103 ANGLE_TRY(mRenderTargetCache.getColors()[colorIndexGL]->flushStagedUpdates(
1104 contextVk));
Jamie Madill9aef3672018-04-27 11:45:06 -04001105 }
Jamie Madill57d9cbb2018-04-27 11:45:04 -04001106 }
1107 }
1108 }
Jamie Madill66546be2018-03-08 09:47:20 -05001109
Tim Van Patten626a7282019-07-08 15:11:59 -06001110 // The FBOs new attachment may have changed the renderable area
1111 const gl::State &glState = context->getState();
1112 contextVk->updateScissor(glState);
1113
Jamie Madill9aef3672018-04-27 11:45:06 -04001114 mActiveColorComponents = gl_vk::GetColorComponentFlags(
Luc Ferron5fd36932018-06-19 14:55:50 -04001115 mActiveColorComponentMasksForClear[0].any(), mActiveColorComponentMasksForClear[1].any(),
1116 mActiveColorComponentMasksForClear[2].any(), mActiveColorComponentMasksForClear[3].any());
Jamie Madill9aef3672018-04-27 11:45:06 -04001117
Geoff Langee244c72019-05-06 10:30:18 -04001118 mFramebuffer.release(contextVk);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001119
Jamie Madill316c6062018-05-29 10:49:45 -04001120 // Will freeze the current set of dependencies on this FBO. The next time we render we will
Jamie Madilla5e06072018-05-18 14:36:05 -04001121 // create a new entry in the command graph.
Geoff Langee244c72019-05-06 10:30:18 -04001122 mFramebuffer.finishCurrentCommands(contextVk);
Jamie Madill72106562017-03-24 14:18:50 -04001123
Jamie Madilldbc605c2019-01-04 16:39:14 -05001124 // Notify the ContextVk to update the pipeline desc.
1125 updateRenderPassDesc();
Shahbaz Youssefida904482019-07-02 10:49:14 -04001126
1127 FramebufferVk *currentDrawFramebuffer = vk::GetImpl(context->getState().getDrawFramebuffer());
1128 if (currentDrawFramebuffer == this)
1129 {
1130 contextVk->onDrawFramebufferChange(this);
1131 }
Jamie Madill19fa1c62018-03-08 09:47:21 -05001132
Jamie Madill7c985f52018-11-29 18:16:17 -05001133 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -05001134}
1135
Jamie Madilldbc605c2019-01-04 16:39:14 -05001136void FramebufferVk::updateRenderPassDesc()
Jamie Madillab9f9c32017-01-17 17:47:34 -05001137{
Jamie Madilldbc605c2019-01-04 16:39:14 -05001138 mRenderPassDesc = {};
1139 mRenderPassDesc.setSamples(getSamples());
Jamie Madillab9f9c32017-01-17 17:47:34 -05001140
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001141 const auto &colorRenderTargets = mRenderTargetCache.getColors();
1142 const gl::DrawBufferMask enabledDrawBuffers = mState.getEnabledDrawBuffers();
1143 for (size_t colorIndexGL = 0; colorIndexGL < enabledDrawBuffers.size(); ++colorIndexGL)
Jamie Madillab9f9c32017-01-17 17:47:34 -05001144 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001145 if (enabledDrawBuffers[colorIndexGL])
1146 {
1147 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
1148 ASSERT(colorRenderTarget);
1149 mRenderPassDesc.packColorAttachment(
1150 colorIndexGL, colorRenderTarget->getImage().getFormat().angleFormatID);
1151 }
1152 else
1153 {
1154 mRenderPassDesc.packColorAttachmentGap(colorIndexGL);
1155 }
Jamie Madillab9f9c32017-01-17 17:47:34 -05001156 }
1157
Jamie Madill66546be2018-03-08 09:47:20 -05001158 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1159 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -05001160 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001161 mRenderPassDesc.packDepthStencilAttachment(
1162 depthStencilRenderTarget->getImage().getFormat().angleFormatID);
Jamie Madillab9f9c32017-01-17 17:47:34 -05001163 }
Jamie Madillab9f9c32017-01-17 17:47:34 -05001164}
1165
Jamie Madill21061022018-07-12 23:56:30 -04001166angle::Result FramebufferVk::getFramebuffer(ContextVk *contextVk, vk::Framebuffer **framebufferOut)
Jamie Madillab9f9c32017-01-17 17:47:34 -05001167{
1168 // If we've already created our cached Framebuffer, return it.
Jamie Madilldd43e6c2017-03-24 14:18:49 -04001169 if (mFramebuffer.valid())
Jamie Madillab9f9c32017-01-17 17:47:34 -05001170 {
Jamie Madille8dd0792018-09-27 15:04:27 -04001171 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -05001172 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -05001173 }
1174
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001175 vk::RenderPass *compatibleRenderPass = nullptr;
Geoff Langee244c72019-05-06 10:30:18 -04001176 ANGLE_TRY(contextVk->getCompatibleRenderPass(mRenderPassDesc, &compatibleRenderPass));
Jamie Madillab9f9c32017-01-17 17:47:34 -05001177
1178 // If we've a Framebuffer provided by a Surface (default FBO/backbuffer), query it.
1179 if (mBackbuffer)
1180 {
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001181 return mBackbuffer->getCurrentFramebuffer(contextVk, *compatibleRenderPass, framebufferOut);
Jamie Madillab9f9c32017-01-17 17:47:34 -05001182 }
1183
1184 // Gather VkImageViews over all FBO attachments, also size of attached region.
1185 std::vector<VkImageView> attachments;
1186 gl::Extents attachmentsSize;
1187
Jamie Madill66546be2018-03-08 09:47:20 -05001188 const auto &colorRenderTargets = mRenderTargetCache.getColors();
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001189 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Jamie Madillab9f9c32017-01-17 17:47:34 -05001190 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001191 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
Jamie Madill66546be2018-03-08 09:47:20 -05001192 ASSERT(colorRenderTarget);
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +01001193 attachments.push_back(colorRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -05001194
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001195 ASSERT(attachmentsSize.empty() || attachmentsSize == colorRenderTarget->getExtents());
1196 attachmentsSize = colorRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -05001197 }
1198
Jamie Madill66546be2018-03-08 09:47:20 -05001199 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1200 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -05001201 {
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +01001202 attachments.push_back(depthStencilRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -05001203
Jamie Madillbc543422018-03-30 10:43:19 -04001204 ASSERT(attachmentsSize.empty() ||
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001205 attachmentsSize == depthStencilRenderTarget->getExtents());
1206 attachmentsSize = depthStencilRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -05001207 }
1208
Tim Van Patten626a7282019-07-08 15:11:59 -06001209 if (attachmentsSize.empty())
1210 {
1211 // No attachments, so use the default values.
1212 attachmentsSize.height = mState.getDefaultHeight();
1213 attachmentsSize.width = mState.getDefaultWidth();
1214 attachmentsSize.depth = 0;
1215 }
1216
Shahbaz Youssefi06270c92018-10-03 17:00:25 -04001217 VkFramebufferCreateInfo framebufferInfo = {};
Jamie Madillab9f9c32017-01-17 17:47:34 -05001218
1219 framebufferInfo.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO;
Jamie Madillab9f9c32017-01-17 17:47:34 -05001220 framebufferInfo.flags = 0;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001221 framebufferInfo.renderPass = compatibleRenderPass->getHandle();
Jamie Madillab9f9c32017-01-17 17:47:34 -05001222 framebufferInfo.attachmentCount = static_cast<uint32_t>(attachments.size());
1223 framebufferInfo.pAttachments = attachments.data();
1224 framebufferInfo.width = static_cast<uint32_t>(attachmentsSize.width);
1225 framebufferInfo.height = static_cast<uint32_t>(attachmentsSize.height);
1226 framebufferInfo.layers = 1;
1227
Jamie Madill21061022018-07-12 23:56:30 -04001228 ANGLE_TRY(mFramebuffer.init(contextVk, framebufferInfo));
Jamie Madill5deea722017-02-16 10:44:46 -05001229
Jamie Madille8dd0792018-09-27 15:04:27 -04001230 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -05001231 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001232}
1233
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001234angle::Result FramebufferVk::clearWithRenderPassOp(
1235 ContextVk *contextVk,
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001236 const gl::Rectangle &clearArea,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001237 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001238 bool clearDepth,
1239 bool clearStencil,
1240 const VkClearColorValue &clearColorValue,
1241 const VkClearDepthStencilValue &clearDepthStencilValue)
1242{
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001243 // Start a new render pass if:
1244 //
1245 // - no render pass has started,
1246 // - there is a render pass started but it contains commands; we cannot modify its ops, so new
1247 // render pass is needed,
1248 // - the current render area doesn't match the clear area. We need the render area to be
1249 // exactly as specified by the scissor for the loadOp to clear only that area. See
1250 // onScissorChange for more information.
1251
1252 if (!mFramebuffer.valid() || !mFramebuffer.renderPassStartedButEmpty() ||
1253 mFramebuffer.getRenderPassRenderArea() != clearArea)
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001254 {
1255 vk::CommandBuffer *commandBuffer;
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001256 ANGLE_TRY(startNewRenderPass(contextVk, clearArea, &commandBuffer));
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001257 }
1258
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001259 size_t attachmentIndexVk = 0;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001260
1261 // Go through clearColorBuffers and set the appropriate loadOp and clear values.
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001262 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001263 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001264 if (clearColorBuffers.test(colorIndexGL))
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001265 {
1266 RenderTargetVk *renderTarget = getColorReadRenderTarget();
1267
1268 // If the render target doesn't have alpha, but its emulated format has it, clear the
1269 // alpha to 1.
1270 VkClearColorValue value = clearColorValue;
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001271 if (mEmulatedAlphaAttachmentMask[colorIndexGL])
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001272 {
1273 SetEmulatedAlphaValue(renderTarget->getImageFormat(), &value);
1274 }
1275
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001276 mFramebuffer.clearRenderPassColorAttachment(attachmentIndexVk, value);
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001277 }
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001278 ++attachmentIndexVk;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001279 }
1280
1281 // Set the appropriate loadOp and clear values for depth and stencil.
1282 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1283 if (depthStencilRenderTarget)
1284 {
1285 if (clearDepth)
1286 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001287 mFramebuffer.clearRenderPassDepthAttachment(attachmentIndexVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001288 clearDepthStencilValue.depth);
1289 }
1290
1291 if (clearStencil)
1292 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001293 mFramebuffer.clearRenderPassStencilAttachment(attachmentIndexVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001294 clearDepthStencilValue.stencil);
1295 }
1296 }
1297
1298 return angle::Result::Continue;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001299}
1300
Jamie Madill21061022018-07-12 23:56:30 -04001301angle::Result FramebufferVk::clearWithDraw(ContextVk *contextVk,
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001302 const gl::Rectangle &clearArea,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001303 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001304 bool clearStencil,
1305 VkColorComponentFlags colorMaskFlags,
1306 uint8_t stencilMask,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001307 const VkClearColorValue &clearColorValue,
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001308 uint8_t clearStencilValue)
Jamie Madill9aef3672018-04-27 11:45:06 -04001309{
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001310 UtilsVk::ClearFramebufferParameters params = {};
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001311 params.clearArea = clearArea;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001312 params.colorClearValue = clearColorValue;
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001313 params.stencilClearValue = clearStencilValue;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001314 params.stencilMask = stencilMask;
1315
1316 params.clearColor = true;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001317 params.clearStencil = clearStencil;
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001318
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001319 const auto &colorRenderTargets = mRenderTargetCache.getColors();
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001320 for (size_t colorIndexGL : clearColorBuffers)
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001321 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001322 const RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001323 ASSERT(colorRenderTarget);
1324
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001325 params.colorFormat = &colorRenderTarget->getImage().getFormat().imageFormat();
James Darpinian7e48c9e2019-08-06 17:17:19 -07001326 params.colorAttachmentIndexGL = static_cast<uint32_t>(colorIndexGL);
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001327 params.colorMaskFlags = colorMaskFlags;
1328 if (mEmulatedAlphaAttachmentMask[colorIndexGL])
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001329 {
1330 params.colorMaskFlags &= ~VK_COLOR_COMPONENT_A_BIT;
1331 }
1332
Geoff Langee244c72019-05-06 10:30:18 -04001333 ANGLE_TRY(contextVk->getUtils().clearFramebuffer(contextVk, this, params));
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001334
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001335 // Clear stencil only once!
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001336 params.clearStencil = false;
1337 }
1338
Shahbaz Youssefi2249d4a2019-04-05 16:48:55 -04001339 // If there was no color clear, clear stencil alone.
1340 if (params.clearStencil)
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001341 {
1342 params.clearColor = false;
Geoff Langee244c72019-05-06 10:30:18 -04001343 ANGLE_TRY(contextVk->getUtils().clearFramebuffer(contextVk, this, params));
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001344 }
1345
1346 return angle::Result::Continue;
Jamie Madill9aef3672018-04-27 11:45:06 -04001347}
1348
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001349angle::Result FramebufferVk::getSamplePosition(const gl::Context *context,
1350 size_t index,
1351 GLfloat *xy) const
JiangYizhoubddc46b2016-12-09 09:50:51 +08001352{
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001353 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -05001354 return angle::Result::Stop;
JiangYizhoubddc46b2016-12-09 09:50:51 +08001355}
1356
Jamie Madilld1249de2018-08-28 16:58:53 -04001357angle::Result FramebufferVk::startNewRenderPass(ContextVk *contextVk,
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001358 const gl::Rectangle &renderArea,
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001359 vk::CommandBuffer **commandBufferOut)
Jamie Madilld1249de2018-08-28 16:58:53 -04001360{
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001361 vk::Framebuffer *framebuffer = nullptr;
Jamie Madill21061022018-07-12 23:56:30 -04001362 ANGLE_TRY(getFramebuffer(contextVk, &framebuffer));
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001363
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001364 vk::AttachmentOpsArray renderPassAttachmentOps;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001365 std::vector<VkClearValue> attachmentClearValues;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001366
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001367 vk::CommandBuffer *writeCommands = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001368 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &writeCommands));
Jamie Madille4c5a232018-03-02 21:00:31 -05001369
Jamie Madill49ac74b2017-12-21 14:42:33 -05001370 // Initialize RenderPass info.
Jamie Madill66546be2018-03-08 09:47:20 -05001371 const auto &colorRenderTargets = mRenderTargetCache.getColors();
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001372 for (size_t colorIndexGL : mState.getEnabledDrawBuffers())
Jamie Madill4c26fc22017-02-24 11:04:10 -05001373 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001374 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndexGL];
Jamie Madill66546be2018-03-08 09:47:20 -05001375 ASSERT(colorRenderTarget);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001376
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001377 ANGLE_TRY(colorRenderTarget->onColorDraw(contextVk, &mFramebuffer, writeCommands));
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001378
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001379 renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(),
1380 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
1381 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL);
1382 attachmentClearValues.emplace_back(kUninitializedClearValue);
Jamie Madill66546be2018-03-08 09:47:20 -05001383 }
1384
1385 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1386 if (depthStencilRenderTarget)
1387 {
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001388 ANGLE_TRY(
1389 depthStencilRenderTarget->onDepthStencilDraw(contextVk, &mFramebuffer, writeCommands));
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001390
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001391 renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(),
1392 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL,
1393 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
1394 attachmentClearValues.emplace_back(kUninitializedClearValue);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001395 }
1396
Jamie Madilldbc605c2019-01-04 16:39:14 -05001397 return mFramebuffer.beginRenderPass(contextVk, *framebuffer, renderArea, mRenderPassDesc,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001398 renderPassAttachmentOps, attachmentClearValues,
1399 commandBufferOut);
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001400}
1401
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001402void FramebufferVk::updateActiveColorMasks(size_t colorIndexGL, bool r, bool g, bool b, bool a)
Jamie Madill9aef3672018-04-27 11:45:06 -04001403{
Shahbaz Youssefi9fa248e2019-05-06 14:55:18 -04001404 mActiveColorComponentMasksForClear[0].set(colorIndexGL, r);
1405 mActiveColorComponentMasksForClear[1].set(colorIndexGL, g);
1406 mActiveColorComponentMasksForClear[2].set(colorIndexGL, b);
1407 mActiveColorComponentMasksForClear[3].set(colorIndexGL, a);
Luc Ferron5fd36932018-06-19 14:55:50 -04001408}
1409
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001410const gl::DrawBufferMask &FramebufferVk::getEmulatedAlphaAttachmentMask() const
Luc Ferron5fd36932018-06-19 14:55:50 -04001411{
1412 return mEmulatedAlphaAttachmentMask;
Jamie Madill9aef3672018-04-27 11:45:06 -04001413}
Luc Ferron018709f2018-05-10 13:53:11 -04001414
Jamie Madill21061022018-07-12 23:56:30 -04001415angle::Result FramebufferVk::readPixelsImpl(ContextVk *contextVk,
1416 const gl::Rectangle &area,
1417 const PackPixelsParams &packPixelsParams,
Jamie Madillb436aac2018-07-18 17:23:48 -04001418 VkImageAspectFlagBits copyAspectFlags,
Jamie Madill21061022018-07-12 23:56:30 -04001419 RenderTargetVk *renderTarget,
1420 void *pixels)
Luc Ferron018709f2018-05-10 13:53:11 -04001421{
Jamie Madill3ea463b2019-06-19 14:21:33 -04001422 ANGLE_TRACE_EVENT0("gpu.angle", "FramebufferVk::readPixelsImpl");
Jamie Madill58675012018-05-22 14:54:07 -04001423
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001424 RendererVk *renderer = contextVk->getRenderer();
1425
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001426 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001427 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Jamie Madill58675012018-05-22 14:54:07 -04001428
Jamie Madillbcf467f2018-05-23 09:46:00 -04001429 // Note that although we're reading from the image, we need to update the layout below.
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -05001430 vk::ImageHelper *srcImage =
1431 renderTarget->getImageForRead(&mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Jamie Madillbcf467f2018-05-23 09:46:00 -04001432
Jamie Madill0631e192019-04-18 16:09:12 -04001433 const angle::Format *readFormat = &srcImage->getFormat().imageFormat();
Luc Ferron1617e692018-07-11 11:08:19 -04001434
Jamie Madillb436aac2018-07-18 17:23:48 -04001435 if (copyAspectFlags != VK_IMAGE_ASPECT_COLOR_BIT)
Luc Ferron1617e692018-07-11 11:08:19 -04001436 {
Jamie Madillb436aac2018-07-18 17:23:48 -04001437 readFormat = &GetDepthStencilImageToBufferFormat(*readFormat, copyAspectFlags);
Luc Ferron1617e692018-07-11 11:08:19 -04001438 }
1439
James Darpinian7e48c9e2019-08-06 17:17:19 -07001440 uint32_t level = renderTarget->getLevelIndex();
1441 uint32_t layer = renderTarget->getLayerIndex();
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001442 VkOffset3D srcOffset = {area.x, area.y, 0};
Cody Northropeb0479e2019-07-24 14:15:56 -06001443
1444 VkImageSubresourceLayers srcSubresource = {};
1445 srcSubresource.aspectMask = copyAspectFlags;
1446 srcSubresource.mipLevel = level;
1447 srcSubresource.baseArrayLayer = layer;
1448 srcSubresource.layerCount = 1;
1449
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001450 VkExtent3D srcExtent = {static_cast<uint32_t>(area.width), static_cast<uint32_t>(area.height),
1451 1};
1452
Cody Northropeb0479e2019-07-24 14:15:56 -06001453 if (srcImage->getExtents().depth > 1)
1454 {
1455 // Depth > 1 means this is a 3D texture and we need special handling
1456 srcOffset.z = layer;
1457 srcSubresource.baseArrayLayer = 0;
1458 }
1459
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001460 // If the source image is multisampled, we need to resolve it into a temporary image before
1461 // performing a readback.
1462 bool isMultisampled = srcImage->getSamples() > 1;
1463 vk::Scoped<vk::ImageHelper> resolvedImage(contextVk->getDevice());
1464 if (isMultisampled)
1465 {
1466 ANGLE_TRY(resolvedImage.get().init2DStaging(
1467 contextVk, renderer->getMemoryProperties(), gl::Extents(area.width, area.height, 1),
1468 srcImage->getFormat(),
1469 VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT, 1));
Geoff Langee244c72019-05-06 10:30:18 -04001470 resolvedImage.get().updateQueueSerial(contextVk->getCurrentQueueSerial());
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001471
Shahbaz Youssefif2a1c382019-05-21 16:32:49 -04001472 // Note: resolve only works on color images (not depth/stencil).
1473 //
1474 // TODO: Currently, depth/stencil blit can perform a depth/stencil readback, but that code
1475 // path will be optimized away. http://anglebug.com/3200
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001476 ASSERT(copyAspectFlags == VK_IMAGE_ASPECT_COLOR_BIT);
1477
1478 VkImageResolve resolveRegion = {};
Cody Northropeb0479e2019-07-24 14:15:56 -06001479 resolveRegion.srcSubresource = srcSubresource;
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001480 resolveRegion.srcOffset = srcOffset;
1481 resolveRegion.dstSubresource.aspectMask = copyAspectFlags;
1482 resolveRegion.dstSubresource.mipLevel = 0;
1483 resolveRegion.dstSubresource.baseArrayLayer = 0;
1484 resolveRegion.dstSubresource.layerCount = 1;
1485 resolveRegion.dstOffset = {};
1486 resolveRegion.extent = srcExtent;
1487
1488 srcImage->resolve(&resolvedImage.get(), resolveRegion, commandBuffer);
1489
1490 resolvedImage.get().changeLayout(copyAspectFlags, vk::ImageLayout::TransferSrc,
1491 commandBuffer);
1492
1493 // Make the resolved image the target of buffer copy.
1494 srcImage = &resolvedImage.get();
1495 level = 0;
1496 layer = 0;
1497 srcOffset = {0, 0, 0};
Cody Northropeb0479e2019-07-24 14:15:56 -06001498 srcSubresource.baseArrayLayer = 0;
1499 srcSubresource.layerCount = 1;
1500 srcSubresource.mipLevel = 0;
Shahbaz Youssefib16d69c2019-05-13 16:28:27 -04001501 }
1502
Jamie Madillb980c562018-11-27 11:34:27 -05001503 VkBuffer bufferHandle = VK_NULL_HANDLE;
1504 uint8_t *readPixelBuffer = nullptr;
Jamie Madill4c310832018-08-29 13:43:17 -04001505 VkDeviceSize stagingOffset = 0;
Jamie Madillb980c562018-11-27 11:34:27 -05001506 size_t allocationSize = readFormat->pixelBytes * area.width * area.height;
Luc Ferron018709f2018-05-10 13:53:11 -04001507
Jamie Madilld754eb52018-07-19 14:55:03 -04001508 ANGLE_TRY(mReadPixelBuffer.allocate(contextVk, allocationSize, &readPixelBuffer, &bufferHandle,
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -05001509 &stagingOffset, nullptr));
Luc Ferron018709f2018-05-10 13:53:11 -04001510
Cody Northropeb0479e2019-07-24 14:15:56 -06001511 VkBufferImageCopy region = {};
1512 region.bufferImageHeight = srcExtent.height;
1513 region.bufferOffset = stagingOffset;
1514 region.bufferRowLength = srcExtent.width;
1515 region.imageExtent = srcExtent;
1516 region.imageOffset = srcOffset;
1517 region.imageSubresource = srcSubresource;
Luc Ferron534b00d2018-05-18 08:16:53 -04001518
Jamie Madillbcf467f2018-05-23 09:46:00 -04001519 commandBuffer->copyImageToBuffer(srcImage->getImage(), srcImage->getCurrentLayout(),
1520 bufferHandle, 1, &region);
Luc Ferron018709f2018-05-10 13:53:11 -04001521
1522 // Triggers a full finish.
1523 // TODO(jmadill): Don't block on asynchronous readback.
Geoff Lang892d1802019-03-27 14:21:34 -04001524 ANGLE_TRY(contextVk->finishImpl());
Luc Ferron018709f2018-05-10 13:53:11 -04001525
Luc Ferron534b00d2018-05-18 08:16:53 -04001526 // The buffer we copied to needs to be invalidated before we read from it because its not been
1527 // created with the host coherent bit.
Jamie Madilld754eb52018-07-19 14:55:03 -04001528 ANGLE_TRY(mReadPixelBuffer.invalidate(contextVk));
Yuly Novikov6c6c76c2018-05-17 18:45:06 +00001529
Ian Elliottdc2c5c52019-08-02 09:32:18 -06001530 const gl::State &glState = contextVk->getState();
1531 gl::Buffer *packBuffer = glState.getTargetBuffer(gl::BufferBinding::PixelPack);
1532 if (packBuffer != nullptr)
1533 {
1534 // Must map the PBO in order to read its contents (and then unmap it later)
1535 BufferVk *packBufferVk = vk::GetImpl(packBuffer);
1536 void *mapPtr = nullptr;
1537 ANGLE_TRY(packBufferVk->mapImpl(contextVk, &mapPtr));
1538 uint8_t *dest = static_cast<uint8_t *>(mapPtr) + reinterpret_cast<ptrdiff_t>(pixels);
1539 PackPixels(packPixelsParams, *readFormat, area.width * readFormat->pixelBytes,
1540 readPixelBuffer, static_cast<uint8_t *>(dest));
1541 packBufferVk->unmapImpl(contextVk);
1542 }
1543 else
1544 {
1545 PackPixels(packPixelsParams, *readFormat, area.width * readFormat->pixelBytes,
1546 readPixelBuffer, static_cast<uint8_t *>(pixels));
1547 }
Luc Ferron018709f2018-05-10 13:53:11 -04001548
Jamie Madill7c985f52018-11-29 18:16:17 -05001549 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -04001550}
Jamie Madill58675012018-05-22 14:54:07 -04001551
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001552gl::Extents FramebufferVk::getReadImageExtents() const
Jamie Madill58675012018-05-22 14:54:07 -04001553{
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001554 ASSERT(getColorReadRenderTarget()->getExtents().width == mState.getDimensions().width);
1555 ASSERT(getColorReadRenderTarget()->getExtents().height == mState.getDimensions().height);
1556
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001557 return getColorReadRenderTarget()->getExtents();
Jamie Madill58675012018-05-22 14:54:07 -04001558}
Jamie Madill502d2e22018-11-01 11:06:23 -04001559
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001560gl::Rectangle FramebufferVk::getCompleteRenderArea() const
1561{
Tim Van Patten626a7282019-07-08 15:11:59 -06001562 const gl::Box &dimensions = mState.getDimensions();
1563 return gl::Rectangle(0, 0, dimensions.width, dimensions.height);
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001564}
1565
1566gl::Rectangle FramebufferVk::getScissoredRenderArea(ContextVk *contextVk) const
1567{
Tim Van Patten626a7282019-07-08 15:11:59 -06001568 const gl::Box &dimensions = mState.getDimensions();
1569 const gl::Rectangle renderArea(0, 0, dimensions.width, dimensions.height);
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001570 bool invertViewport = contextVk->isViewportFlipEnabledForDrawFBO();
1571
1572 return ClipRectToScissor(contextVk->getState(), renderArea, invertViewport);
1573}
1574
1575void FramebufferVk::onScissorChange(ContextVk *contextVk)
1576{
1577 gl::Rectangle scissoredRenderArea = getScissoredRenderArea(contextVk);
1578
1579 // If the scissor has grown beyond the previous scissoredRenderArea, make sure the render pass
1580 // is restarted. Otherwise, we can continue using the same renderpass area.
1581 //
1582 // Without a scissor, the render pass area covers the whole of the framebuffer. With a
1583 // scissored clear, the render pass area could be smaller than the framebuffer size. When the
1584 // scissor changes, if the scissor area is completely encompassed by the render pass area, it's
1585 // possible to continue using the same render pass. However, if the current render pass area
1586 // is too small, we need to start a new one. The latter can happen if a scissored clear starts
1587 // a render pass, the scissor is disabled and a draw call is issued to affect the whole
1588 // framebuffer.
Geoff Langee244c72019-05-06 10:30:18 -04001589 mFramebuffer.updateQueueSerial(contextVk->getCurrentQueueSerial());
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001590 if (mFramebuffer.hasStartedRenderPass() &&
1591 !mFramebuffer.getRenderPassRenderArea().encloses(scissoredRenderArea))
1592 {
Geoff Langee244c72019-05-06 10:30:18 -04001593 mFramebuffer.finishCurrentCommands(contextVk);
Shahbaz Youssefi127990f2019-04-04 13:52:04 -04001594 }
1595}
1596
Jamie Madill502d2e22018-11-01 11:06:23 -04001597RenderTargetVk *FramebufferVk::getFirstRenderTarget() const
1598{
1599 for (auto *renderTarget : mRenderTargetCache.getColors())
1600 {
1601 if (renderTarget)
1602 {
1603 return renderTarget;
1604 }
1605 }
1606
1607 return mRenderTargetCache.getDepthStencil();
1608}
1609
1610GLint FramebufferVk::getSamples() const
1611{
1612 RenderTargetVk *firstRT = getFirstRenderTarget();
1613 return firstRT ? firstRT->getImage().getSamples() : 0;
1614}
1615
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001616} // namespace rx