blob: 413be998fd82b8ff1abf057280ce524d87175833 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Jooyung Han1f14ab32020-10-14 13:48:29 +090017#include "aidl.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070018
Jooyung Hane87cdd02020-12-11 16:47:35 +090019#include <android-base/format.h>
Christopher Wileyec31a052016-01-25 07:28:51 -080020#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090021#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070022#include <gtest/gtest.h>
23
Jooyung Han1f14ab32020-10-14 13:48:29 +090024#include <map>
25#include <memory>
26#include <set>
27#include <string>
28#include <vector>
29
Steven Moreland49585242019-12-18 16:06:49 -080030#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070031#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070032#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090033#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090034#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090035#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070036#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070037
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090038using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080040using android::base::StringPrintf;
Jooyung Han1f14ab32020-10-14 13:48:29 +090041using std::map;
Christopher Wiley12e894a2016-01-29 11:55:07 -080042using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070043using std::string;
44using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080045using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070046using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090047using testing::internal::CaptureStderr;
48using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070049
50namespace android {
51namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070052namespace {
53
54const char kExpectedDepFileContents[] =
55R"(place/for/output/p/IFoo.java : \
56 p/IFoo.aidl
57
58p/IFoo.aidl :
59)";
60
Dan Willemsen93298ee2016-11-10 23:55:55 -080061const char kExpectedNinjaDepFileContents[] =
62R"(place/for/output/p/IFoo.java : \
63 p/IFoo.aidl
64)";
65
Jiyong Parkdf202122019-09-30 20:48:35 +090066const char kExpectedParcelableDeclarationDepFileContents[] =
67 R"( : \
68 p/Foo.aidl
69
70p/Foo.aidl :
71)";
72
73const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080074 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070075 p/Foo.aidl
76
77p/Foo.aidl :
78)";
79
Jooyung Hand2fa0232020-10-19 02:51:41 +090080const char kExpectedJavaParcelableOutputContents[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090081 R"(/*
82 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090083 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080084@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090085public class Rect implements android.os.Parcelable
86{
87 // Comment
88
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080089 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090090 public int x = 5;
91
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080092 @android.annotation.Hide
93 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000094 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090095
96 public android.os.ParcelFileDescriptor fd;
Jooyung Hand2fa0232020-10-19 02:51:41 +090097
98 public java.util.List<android.os.ParcelFileDescriptor> fds;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090099 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
100 @Override
101 public Rect createFromParcel(android.os.Parcel _aidl_source) {
102 Rect _aidl_out = new Rect();
103 _aidl_out.readFromParcel(_aidl_source);
104 return _aidl_out;
105 }
106 @Override
107 public Rect[] newArray(int _aidl_size) {
108 return new Rect[_aidl_size];
109 }
110 };
111 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
112 {
113 int _aidl_start_pos = _aidl_parcel.dataPosition();
114 _aidl_parcel.writeInt(0);
115 _aidl_parcel.writeInt(x);
116 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900117 if ((fd!=null)) {
118 _aidl_parcel.writeInt(1);
119 fd.writeToParcel(_aidl_parcel, 0);
120 }
121 else {
122 _aidl_parcel.writeInt(0);
123 }
Jooyung Hana61aa232020-10-20 04:00:08 +0900124 _aidl_parcel.writeTypedList(fds);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900125 int _aidl_end_pos = _aidl_parcel.dataPosition();
126 _aidl_parcel.setDataPosition(_aidl_start_pos);
127 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
128 _aidl_parcel.setDataPosition(_aidl_end_pos);
129 }
130 public final void readFromParcel(android.os.Parcel _aidl_parcel)
131 {
132 int _aidl_start_pos = _aidl_parcel.dataPosition();
133 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900134 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900135 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900136 x = _aidl_parcel.readInt();
137 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
138 y = _aidl_parcel.readInt();
139 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900140 if ((0!=_aidl_parcel.readInt())) {
141 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
142 }
143 else {
144 fd = null;
145 }
146 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jooyung Hana61aa232020-10-20 04:00:08 +0900147 fds = _aidl_parcel.createTypedArrayList(android.os.ParcelFileDescriptor.CREATOR);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900148 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900149 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900150 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
151 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
152 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900153 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
154 }
155 }
Jooyung Hand2fa0232020-10-19 02:51:41 +0900156 @Override
157 public int describeContents() {
158 int _mask = 0;
Jooyung Hanea2147c2020-10-21 18:16:56 +0900159 _mask |= describeContents(fd);
160 _mask |= describeContents(fds);
Jooyung Hand2fa0232020-10-19 02:51:41 +0900161 return _mask;
Jeongik Cha372a8c82018-12-12 16:31:11 +0900162 }
Jooyung Hanea2147c2020-10-21 18:16:56 +0900163 private int describeContents(Object _v) {
164 if (_v == null) return 0;
165 if (_v instanceof java.util.Collection) {
166 int _mask = 0;
167 for (Object o : (java.util.Collection) _v) {
168 _mask |= describeContents(o);
169 }
170 return _mask;
171 }
172 if (_v instanceof android.os.Parcelable) {
173 return ((android.os.Parcelable) _v).describeContents();
174 }
175 return 0;
176 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900177}
178)";
179
Devin Moore2f2077a2020-08-28 11:27:53 -0700180// clang-format off
181const char kExpectedCppHeaderOutput[] =
182 R"(#pragma once
183
184#include <binder/IBinder.h>
185#include <binder/IInterface.h>
186#include <binder/Status.h>
187#include <optional>
188#include <utils/String16.h>
189#include <utils/StrongPointer.h>
190#include <vector>
191
192class IFoo : public ::android::IInterface {
193public:
194 DECLARE_META_INTERFACE(Foo)
195 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
196}; // class IFoo
197class IFooDefault : public IFoo {
198public:
199 ::android::IBinder* onAsBinder() override {
200 return nullptr;
201 }
202 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
203 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
204 }
205}; // class IFooDefault
206)";
207// clang-format on
208
Christopher Wileyf8136192016-04-12 14:19:35 -0700209} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700210
Devin Moore7b8d5c92020-03-17 14:14:08 -0700211class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700212 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900213 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
214 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700215 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700216 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900217 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700218 args.emplace_back("aidl");
219 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700220 for (const string& s : additional_arguments) {
221 args.emplace_back(s);
222 }
223 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900224 args.emplace_back("--preprocessed=" + f);
225 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700226 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900227 args.emplace_back("--include=" + i);
228 }
229 args.emplace_back(path);
230 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900231 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900232 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700233 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900234 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900235
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700236 if (error != nullptr) {
237 *error = actual_error;
238 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900239
240 if (actual_error != AidlError::OK) {
241 return nullptr;
242 }
243
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900244 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900245 EXPECT_EQ(1ul, defined_types.size());
246
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900247 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700248 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700249
Devin Moore7b8d5c92020-03-17 14:14:08 -0700250 Options::Language GetLanguage() { return GetParam(); }
251
Christopher Wiley0522cd52015-10-28 15:39:44 -0700252 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800253 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900254 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900255 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700256};
257
Devin Moore7b8d5c92020-03-17 14:14:08 -0700258// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
259// tests with each of the supported languages as a parameter.
260INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
261 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700262 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700263 [](const testing::TestParamInfo<Options::Language>& info) {
264 return Options::LanguageToString(info.param);
265 });
266
267TEST_P(AidlTest, AcceptMissingPackage) {
268 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700269}
270
Devin Moore7b8d5c92020-03-17 14:14:08 -0700271TEST_P(AidlTest, EndsInSingleLineComment) {
272 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700273}
274
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000275TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
276 const string expected_stderr =
277 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
278 const std::string file_contents = "package a; interface IBar {}";
279 CaptureStderr();
280 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
281 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
282}
283
284TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
285 const string expected_stderr =
286 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
287 const std::string file_contents = "package a; interface Bar {}";
288 CaptureStderr();
289 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
290 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
291}
292
293TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
294 const string expected_stderr =
295 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
296 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
297 CaptureStderr();
298 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
299 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
300}
301
302TEST_P(AidlTest, EnumRequiresCorrectPath) {
303 const string expected_stderr =
304 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
305 const std::string file_contents = "package a; enum Bar { A, }";
306 CaptureStderr();
307 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
308 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
309}
310
Devin Moore7b8d5c92020-03-17 14:14:08 -0700311TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900312 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700313 io_delegate_.SetFileContents("bar/IBar.aidl",
314 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700315 const string path = "foo/IFoo.aidl";
316 const string contents =
317 "package foo;\n"
318 "import bar.IBar;\n"
319 "interface IFoo { void f(in IBar[] input); }";
320 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
321 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700324}
325
Devin Moore7b8d5c92020-03-17 14:14:08 -0700326TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700327 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700328 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900329}
Devin Moore097a3ab2020-03-11 16:08:44 -0700330
Jiyong Park40782d02020-07-24 19:17:43 +0900331TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700332 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
333 const string expected_ibinder_stderr =
Jooyung Han15fd6c62020-10-23 13:54:46 +0900334 "ERROR: a/IBaz.aidl:1.47-51: 'bar' can't be an out parameter because IBinder can only be an "
335 "in parameter.\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700336 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700337 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700338 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900339}
340
Jiyong Park40782d02020-07-24 19:17:43 +0900341TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700342 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
343 const string expected_stderr =
344 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700345 CaptureStderr();
346 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900348}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700349
Jiyong Park40782d02020-07-24 19:17:43 +0900350TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700351 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900352 const string expected_stderr =
353 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700354 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700355 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700356 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700357}
358
Devin Moore7b8d5c92020-03-17 14:14:08 -0700359TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700360 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
361 const string expected_stderr =
362 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
363 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700364 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700365 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700366}
367
Devin Moore7b8d5c92020-03-17 14:14:08 -0700368TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700369 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
370 const string expected_stderr =
371 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
372 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700373 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700374 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800375}
376
Devin Moore2f2077a2020-08-28 11:27:53 -0700377TEST_P(AidlTest, AcceptNullableList) {
378 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
379 const string expected_stderr = "";
380 CaptureStderr();
381 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
382 EXPECT_EQ(expected_stderr, GetCapturedStderr());
383}
384
Devin Moore7b8d5c92020-03-17 14:14:08 -0700385TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700386 const string method = "package a; interface IFoo { void f(int a, int a); }";
387 const string expected_stderr =
388 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
389 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700390 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700391 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700392}
393
Jeongik Cha13066da2020-08-06 15:43:19 +0900394TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
395 const string method = "package a; parcelable Foo { int a; String a; }";
Jooyung Han59af9cc2020-10-25 21:44:14 +0900396 const string expected_stderr = "ERROR: a/Foo.aidl:1.42-44: 'Foo' has duplicate field name 'a'\n";
Jeongik Cha13066da2020-08-06 15:43:19 +0900397 CaptureStderr();
398 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
399 EXPECT_EQ(expected_stderr, GetCapturedStderr());
400}
401
Jooyung Hand902a972020-10-23 17:32:44 +0900402TEST_P(AidlTest, RejectsRepeatedAnnotations) {
403 const string method = R"(@Hide @Hide parcelable Foo {})";
404 const string expected_stderr =
405 "ERROR: Foo.aidl:1.23-27: 'Hide' is repeated, but not allowed. Previous location: "
406 "Foo.aidl:1.1-6\n";
407 CaptureStderr();
408 EXPECT_EQ(nullptr, Parse("Foo.aidl", method, typenames_, GetLanguage()));
409 EXPECT_EQ(expected_stderr, GetCapturedStderr());
410}
411
Devin Moore7b8d5c92020-03-17 14:14:08 -0700412TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700413 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
414 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
415 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100418}
419
Devin Moore7b8d5c92020-03-17 14:14:08 -0700420TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700421 AidlError error;
422 const string method = "package a; @nullable interface IFoo { int f(); }";
423 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800424 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000425 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
426 "JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700427 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700428 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700429 EXPECT_EQ(expected_stderr, GetCapturedStderr());
430 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800431}
432
Devin Moore7b8d5c92020-03-17 14:14:08 -0700433TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700434 AidlError error;
435 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
436 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800437 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900438 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700439 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700440 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700441 EXPECT_EQ(expected_stderr, GetCapturedStderr());
442 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800443}
444
Devin Moore7b8d5c92020-03-17 14:14:08 -0700445TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700446 AidlError error;
447 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
448 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000449 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900450 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900451 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700452 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000453 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700454 EXPECT_EQ(expected_stderr, GetCapturedStderr());
455 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800456}
457
Devin Moore7b8d5c92020-03-17 14:14:08 -0700458TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700459 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000460 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700461 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000462 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jooyung Han90345002020-10-23 15:28:53 +0900463 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDerive, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700464 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700465 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000466 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700467 EXPECT_EQ(expected_stderr, GetCapturedStderr());
468 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800469}
470
Jiyong Park40782d02020-07-24 19:17:43 +0900471TEST_P(AidlTest, ParsesNonNullableAnnotation) {
472 auto parse_result =
473 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
474 ASSERT_NE(nullptr, parse_result);
475 const AidlInterface* interface = parse_result->AsInterface();
476 ASSERT_NE(nullptr, interface);
477 ASSERT_FALSE(interface->GetMethods().empty());
478 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
479}
480
Devin Moore7b8d5c92020-03-17 14:14:08 -0700481TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900482 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
483 typenames_, GetLanguage());
484 ASSERT_NE(nullptr, parse_result);
485 const AidlInterface* interface = parse_result->AsInterface();
486 ASSERT_NE(nullptr, interface);
487 ASSERT_FALSE(interface->GetMethods().empty());
488 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
489}
490
491TEST_P(AidlTest, ParsesNonUtf8Annotations) {
492 auto parse_result =
493 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
494 ASSERT_NE(nullptr, parse_result);
495 const AidlInterface* interface = parse_result->AsInterface();
496 ASSERT_NE(nullptr, interface);
497 ASSERT_FALSE(interface->GetMethods().empty());
498 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800499}
500
Devin Moore7b8d5c92020-03-17 14:14:08 -0700501TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900502 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
503 typenames_, GetLanguage());
504 ASSERT_NE(nullptr, parse_result);
505 const AidlInterface* interface = parse_result->AsInterface();
506 ASSERT_NE(nullptr, interface);
507 ASSERT_FALSE(interface->GetMethods().empty());
508 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800509}
510
Devin Moore7b8d5c92020-03-17 14:14:08 -0700511TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700512 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700513 const string expected_stderr =
514 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
515 "\"vintf\"'\n"
516 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
517 "--structured\n";
518 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700519 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700520 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700521 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700522 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700523}
524
Devin Moore7b8d5c92020-03-17 14:14:08 -0700525TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700526 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700527 const string expected_stderr =
528 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
529 "--structured\n";
530 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700531 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700532 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700533 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700534 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700535}
536
Devin Moore7b8d5c92020-03-17 14:14:08 -0700537TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700538 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700539 const string expected_stderr =
540 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
541 "\"vintf\"'\n";
542 CaptureStderr();
543 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700544 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700545 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700546 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700547}
548
Devin Moore7b8d5c92020-03-17 14:14:08 -0700549TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700550 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700551 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
552 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700553 ASSERT_EQ(AidlError::OK, error);
554 ASSERT_NE(nullptr, parse_result);
555 const AidlInterface* interface = parse_result->AsInterface();
556 ASSERT_NE(nullptr, interface);
557 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700558}
559
Jeongik Cha64783ed2019-06-07 18:30:54 +0900560TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
561 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900562 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
563 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900564 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700565 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900566 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900567 "a/Foo.aidl",
568 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900569
570 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900571 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700572 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900573 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700574 "Parcelable must be defined in AIDL directly.\n";
575 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900576 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700577 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700578
579 CaptureStderr();
580 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
581 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900582}
583
Jooyung Han1cbc4962020-10-25 10:07:15 +0900584TEST_F(AidlTest, ParcelableSupportJavaDeriveToString) {
585 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
586 @JavaDerive(toString=true) parcelable Foo { int a; float b; })");
587 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900588 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
589
590 string java_out;
Jooyung Han1cbc4962020-10-25 10:07:15 +0900591 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
Jiyong Park43113fb2020-07-20 16:26:19 +0900592 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
593
594 // Other backends shouldn't be bothered
Jooyung Han1cbc4962020-10-25 10:07:15 +0900595 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900596 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
597
Jooyung Han1cbc4962020-10-25 10:07:15 +0900598 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
Jiyong Park43113fb2020-07-20 16:26:19 +0900599 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
600}
601
Jooyung Han1cbc4962020-10-25 10:07:15 +0900602TEST_F(AidlTest, UnionSupportJavaDeriveToString) {
603 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
604 @JavaDerive(toString=true) union Foo { int a; int[] b; })");
605 CaptureStderr();
606 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
607 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
608 EXPECT_EQ("", GetCapturedStderr());
609
610 const string expected_to_string_method = R"--(
611 @Override
612 public String toString() {
613 switch (_tag) {
614 case a: return "a.Foo.a(" + (getA()) + ")";
615 case b: return "a.Foo.b(" + (java.util.Arrays.toString(getB())) + ")";
616 }
617 throw new IllegalStateException("unknown field: " + _tag);
618 }
619)--";
620
621 string java_out;
622 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
623 EXPECT_THAT(java_out, testing::HasSubstr(expected_to_string_method));
624}
625
Jiyong Park9aa3d042020-12-04 23:30:02 +0900626TEST_F(AidlTest, ParcelableSupportJavaDeriveEquals) {
627 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
628 @JavaDerive(equals=true) parcelable Foo { int a; float b; })");
629 CaptureStderr();
630 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
631 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
632 EXPECT_EQ("", GetCapturedStderr());
633
634 const std::string expected = R"--(
635 @Override
636 public boolean equals(Object other) {
637 if (this == other) return true;
638 if (other == null) return false;
639 if (!(other instanceof Foo)) return false;
640 Foo that = (Foo)other;
641 if (!java.util.Objects.deepEquals(a, that.a)) return false;
642 if (!java.util.Objects.deepEquals(b, that.b)) return false;
643 return true;
644 }
645
646 @Override
647 public int hashCode() {
648 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(a, b).toArray());
649 }
650)--";
651
652 string java_out;
653 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
654 EXPECT_THAT(java_out, testing::HasSubstr(expected));
655}
656
657TEST_F(AidlTest, UnionSupportJavaDeriveEquals) {
658 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
659 @JavaDerive(equals=true) union Foo { int a; int[] b; })");
660 CaptureStderr();
661 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
662 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
663 EXPECT_EQ("", GetCapturedStderr());
664
665 const std::string expected = R"--(
666 @Override
667 public boolean equals(Object other) {
668 if (this == other) return true;
669 if (other == null) return false;
670 if (!(other instanceof Foo)) return false;
671 Foo that = (Foo)other;
672 if (_tag != that._tag) return false;
673 if (!java.util.Objects.deepEquals(_value, that._value)) return false;
674 return true;
675 }
676
677 @Override
678 public int hashCode() {
679 return java.util.Arrays.deepHashCode(java.util.Arrays.asList(_tag, _value).toArray());
680 }
681)--";
682
683 string java_out;
684 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &java_out));
685 EXPECT_THAT(java_out, testing::HasSubstr(expected));
686}
687
Jooyung Han90345002020-10-23 15:28:53 +0900688TEST_F(AidlTest, RejectsJavaDeriveAnnotation) {
Jiyong Park43113fb2020-07-20 16:26:19 +0900689 {
Jooyung Han90345002020-10-23 15:28:53 +0900690 io_delegate_.SetFileContents("a/Foo.aidl",
691 "package a; @JavaDerive(blah=true) parcelable Foo{}");
692 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
693 CaptureStderr();
694 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
695 const std::string expected_stderr =
696 "ERROR: a/Foo.aidl:1.11-34: Parameter blah not supported for annotation JavaDerive.";
697 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
698 }
699
700 {
701 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive interface IFoo{}");
Jiyong Park43113fb2020-07-20 16:26:19 +0900702 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
703 CaptureStderr();
704 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
705 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900706 "ERROR: a/IFoo.aidl:1.23-33: 'JavaDerive' is not a supported annotation for this node. "
Steven Morelanda7764e52020-10-27 17:29:29 +0000707 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, SensitiveData, "
708 "JavaPassthrough, Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900709 EXPECT_EQ(expected_stderr, GetCapturedStderr());
710 }
711
712 {
Jooyung Han90345002020-10-23 15:28:53 +0900713 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDerive enum IFoo { A=1, }");
Jiyong Park43113fb2020-07-20 16:26:19 +0900714 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
715 CaptureStderr();
716 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
717 const std::string expected_stderr =
Jooyung Han90345002020-10-23 15:28:53 +0900718 "ERROR: a/IFoo.aidl:1.28-33: 'JavaDerive' is not a supported annotation for this node. "
Jiyong Park43113fb2020-07-20 16:26:19 +0900719 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
720 EXPECT_EQ(expected_stderr, GetCapturedStderr());
721 }
722}
723
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900724TEST_P(AidlTest, ParseDescriptorAnnotation) {
725 AidlError error;
726 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
727 typenames_, GetLanguage(), &error, {"--structured"});
728 ASSERT_EQ(AidlError::OK, error);
729 ASSERT_NE(nullptr, parse_result);
730 const AidlInterface* interface = parse_result->AsInterface();
731 ASSERT_NE(nullptr, interface);
732 ASSERT_EQ("IBar", interface->GetDescriptor());
733}
734
Jiyong Park40782d02020-07-24 19:17:43 +0900735TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700736 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700737 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900738}
739
740TEST_P(AidlTest, AcceptsOnewayInterface) {
741 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700742 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700743}
Christopher Wileyef140932015-11-03 09:29:19 -0800744
Devin Moore7b8d5c92020-03-17 14:14:08 -0700745TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700746 const string oneway_method =
747 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700748 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100749}
750
Steven Moreland65297cc2020-04-20 20:17:36 -0700751TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
752 const string oneway_method =
753 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
754 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
755 ASSERT_NE(nullptr, defined);
756 const AidlInterface* iface = defined->AsInterface();
757 ASSERT_NE(nullptr, iface);
758
759 const auto& methods = iface->GetMethods();
760 ASSERT_EQ(1u, methods.size());
761 const auto& method = methods[0];
762 const AidlTypeSpecifier& ret_type = method->GetType();
763
764 // TODO(b/151102494): these annotations should be on the method
765 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
766 ASSERT_TRUE(ret_type.IsHide());
767}
768
Devin Moore7b8d5c92020-03-17 14:14:08 -0700769TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100770 string foo_interface =
771 "package a; /* foo */ interface IFoo {"
772 " /* i */ int i();"
773 " /* j */ @nullable String j();"
774 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
775
Devin Moore7b8d5c92020-03-17 14:14:08 -0700776 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100777 EXPECT_NE(nullptr, parse_result);
778 EXPECT_EQ("/* foo */", parse_result->GetComments());
779
780 const AidlInterface* interface = parse_result->AsInterface();
781 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
782 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
783 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
784}
785
Jooyung Han1a551d32020-10-05 15:37:26 +0900786TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
787 io_delegate_.SetFileContents("p/cpp_header.aidl",
788 R"(package p;
789 parcelable cpp_header cpp_header "bar/header";)");
790 import_paths_.emplace("");
791 const string input_path = "p/IFoo.aidl";
792 const string input = R"(package p;
793 import p.cpp_header;
794 interface IFoo {
795 // get bar
796 cpp_header get();
797 })";
798
799 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
800 EXPECT_NE(nullptr, parse_result);
801 const AidlInterface* interface = parse_result->AsInterface();
802 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
803}
804
Christopher Wileyef140932015-11-03 09:29:19 -0800805TEST_F(AidlTest, ParsesPreprocessedFile) {
806 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
807 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700808 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900809 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700810 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
811 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800812}
813
814TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
815 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
816 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900817
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700818 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900819 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700820 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
821 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800822}
823
Devin Moore7b8d5c92020-03-17 14:14:08 -0700824TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800825 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
826 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
827 "interface IBar {}");
828 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900829 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900830 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700831 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800832 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900833
Christopher Wiley41544372015-11-03 14:52:29 -0800834 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700835 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
836 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800837 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700838 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900839 ambiguous_type.Resolve(typenames_);
840 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800841}
842
Jiyong Park8f6ec462020-01-19 20:52:47 +0900843// Special case of PreferImportToPreprocessed. Imported type should be preferred
844// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700845TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900846 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
847 io_delegate_.SetFileContents("one/IBar.aidl",
848 "package one; "
849 "interface IBar {}");
850 preprocessed_files_.push_back("preprocessed");
851 import_paths_.emplace("");
852 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700853 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900854 EXPECT_NE(nullptr, parse_result);
855
856 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700857 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
858 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900859 // But if we request just "IBar" we should get our imported one.
860 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
861 ambiguous_type.Resolve(typenames_);
862 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
863}
864
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800865TEST_F(AidlTest, WritePreprocessedFile) {
866 io_delegate_.SetFileContents("p/Outer.aidl",
867 "package p; parcelable Outer.Inner;");
868 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
869 "interface IBar {}");
870
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900871 vector<string> args {
872 "aidl",
873 "--preprocess",
874 "preprocessed",
875 "p/Outer.aidl",
876 "one/IBar.aidl"};
877 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800878 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
879
880 string output;
881 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
882 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
883}
884
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900885TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100886 io_delegate_.SetFileContents(
887 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800888 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100889 "parcelable Rect {\n"
890 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800891 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100892 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800893 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100894 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100895 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
896 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100897 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900898 " ParcelFileDescriptor fd;\n"
Jooyung Hand2fa0232020-10-19 02:51:41 +0900899 " List<ParcelFileDescriptor> fds;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100900 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900901
902 vector<string> args{"aidl", "Rect.aidl"};
903 Options options = Options::From(args);
904 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
905
906 string output;
907 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jooyung Hand2fa0232020-10-19 02:51:41 +0900908 EXPECT_EQ(kExpectedJavaParcelableOutputContents, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900909}
910
Devin Moore2f2077a2020-08-28 11:27:53 -0700911TEST_F(AidlTest, CppHeaderIncludes) {
912 io_delegate_.SetFileContents("IFoo.aidl",
913 "interface IFoo {\n"
914 " @nullable List<String> foo();\n"
915 "}");
916
917 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
918 Options options = Options::From(args);
919 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
920 std::vector<std::string> empty;
921 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
922 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
923 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
924
925 // Make sure the optional and String16.h includes are added
926 string output;
927 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
928 EXPECT_EQ(kExpectedCppHeaderOutput, output);
929}
930
Devin Moore7b8d5c92020-03-17 14:14:08 -0700931TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700932 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800933 io_delegate_.SetFileContents("p/Outer.aidl",
934 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900935 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700936 CaptureStderr();
937 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
938 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700939 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700940 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800941}
942
Devin Moore7b8d5c92020-03-17 14:14:08 -0700943TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800944 io_delegate_.SetFileContents("preprocessed",
945 "parcelable p.Outer.Inner;");
946 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900947 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700948 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800949 // TODO(wiley): This should actually return nullptr because we require
950 // the outer class name. However, for legacy reasons,
951 // this behavior must be maintained. b/17415692
952 EXPECT_NE(nullptr, parse_result);
953}
954
Christopher Wiley632801d2015-11-05 14:15:49 -0800955TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700956 const string expected_foo_stderr =
957 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
958 "Declared parcelables should be in their own file and/or cannot be used with --structured "
959 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700960 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
961
Christopher Wiley632801d2015-11-05 14:15:49 -0800962 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700963 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700964 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900965 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700966 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900967
Steven Morelande2c64b42018-09-18 15:06:37 -0700968 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900969 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700970 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900971 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700972 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700973
Devin Moore097a3ab2020-03-11 16:08:44 -0700974 const string expected_bar_stderr =
975 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
976 "Declared parcelables should be in their own file and/or cannot be used with --structured "
977 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700978 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
979
Jiyong Parkda8c6932019-08-12 19:56:08 +0900980 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700981 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700982 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900983 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700984 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700985 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700986 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700987 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700988 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800989}
990
Devin Moore7b8d5c92020-03-17 14:14:08 -0700991TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700992 const string expected_stderr =
993 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
994 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700995 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
996 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700997 AidlError error;
998 CaptureStderr();
999 EXPECT_EQ(
1000 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001001 Parse("p/IFoo.aidl",
1002 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001003 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -07001004 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1005 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -07001006}
1007
Devin Moore7b8d5c92020-03-17 14:14:08 -07001008TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001009 AidlError error;
1010 const string expected_stderr =
1011 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
1012 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001013 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1014 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001015 interface IFoo {
1016 const String DUPLICATED = "d";
1017 const int DUPLICATED = 1;
1018 }
1019 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001020 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001021 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1022 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -07001023}
1024
Steven Morelande689da22020-11-10 02:06:30 +00001025TEST_P(AidlTest, FailOnTooBigConstant) {
1026 AidlError error;
1027 const string expected_stderr =
1028 "ERROR: p/IFoo.aidl:3.48-52: Invalid type specifier for an int32 literal: byte\n";
1029 CaptureStderr();
1030 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1031 R"(package p;
1032 interface IFoo {
1033 const byte type2small = 256;
1034 }
1035 )",
1036 typenames_, GetLanguage(), &error));
1037 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1038 EXPECT_EQ(AidlError::BAD_TYPE, error);
1039}
1040
Jooyung Han30f64ad2020-12-15 08:16:31 +09001041TEST_F(AidlTest, BoolConstantsEvaluatesToIntegers) {
1042 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { const int y = true; }");
1043 CaptureStderr();
1044 auto options = Options::From("aidl --lang java -o out a/Foo.aidl");
1045 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
1046 EXPECT_EQ("", GetCapturedStderr());
1047 string code;
1048 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
1049 EXPECT_THAT(code, testing::HasSubstr("public static final int y = 1;"));
1050}
1051
Devin Moore7b8d5c92020-03-17 14:14:08 -07001052TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001053 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -07001054 const string expected_stderr =
1055 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -07001056 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -07001057 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1058 R"(package p;
1059 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -07001060 parcelable IBar {}
1061 parcelable StructuredParcelable {}
1062 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +09001063 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001064 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -07001065 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -07001066 // Parse success is important for clear error handling even if the cases aren't
1067 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -07001068 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001069}
1070
Devin Moore7b8d5c92020-03-17 14:14:08 -07001071TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001072 AidlError error;
1073 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
1074 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -07001075 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001076 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1077 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -07001078}
1079
Steven Morelandf9e922f2020-07-08 21:15:27 +00001080TEST_P(AidlTest, FailOnEmptyListWithComma) {
1081 AidlError error;
1082 const string expected_stderr =
1083 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
1084 CaptureStderr();
1085 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
1086 typenames_, GetLanguage(), &error));
1087 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1088 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1089}
1090
Devin Moore7b8d5c92020-03-17 14:14:08 -07001091TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001092 AidlError error;
1093 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07001094 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001095 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001096 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
1097 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001098 interface IFoo {
1099 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
1100 }
1101 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001102 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07001103 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1104 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -07001105}
1106
Jiyong Park18132182020-06-08 20:24:40 +09001107TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
1108 AidlError error;
1109 const string expected_stderr =
1110 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
1111 "cpp_header (which can also be used as an identifier)\n";
1112 CaptureStderr();
1113 // Notice the trailing dot(.) in the name, which isn't a correct name
1114 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
1115 GetLanguage(), &error));
1116 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1117 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1118}
1119
1120TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
1121 AidlError error;
1122 const string expected_stderr =
1123 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
1124 "cpp_header (which can also be used as an identifier)\n";
1125 CaptureStderr();
1126 // Notice the trailing dot(.) in the package name
1127 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
1128 GetLanguage(), &error));
1129 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1130 EXPECT_EQ(AidlError::PARSE_ERROR, error);
1131}
1132
Devin Moore7b8d5c92020-03-17 14:14:08 -07001133TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001134 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001135 auto parse_result = Parse("p/IFoo.aidl",
1136 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001137 interface IFoo {
1138 const int POSITIVE_HEX_VALUE = 0xf5;
1139 }
1140 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001141 typenames_, GetLanguage(), &error);
1142 EXPECT_NE(nullptr, parse_result);
1143 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001144 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001145 const auto& cpp_constants = interface->GetConstantDeclarations();
1146 EXPECT_EQ((size_t)1, cpp_constants.size());
1147 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001148 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001149 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001150}
1151
Devin Moore7b8d5c92020-03-17 14:14:08 -07001152TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001153 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001154 auto parse_result = Parse("p/IFoo.aidl",
1155 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -07001156 interface IFoo {
1157 const int NEGATIVE_HEX_VALUE = 0xffffffff;
1158 }
1159 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07001160 typenames_, GetLanguage(), &error);
1161 ASSERT_NE(nullptr, parse_result);
1162 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001163 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001164 const auto& cpp_constants = interface->GetConstantDeclarations();
1165 EXPECT_EQ((size_t)1, cpp_constants.size());
1166 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001167 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001168 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001169}
1170
Devin Moore7b8d5c92020-03-17 14:14:08 -07001171TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001172 io_delegate_.SetFileContents(
1173 "p/Outer.aidl",
1174 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001175 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001176 const string input_path = "p/IFoo.aidl";
1177 const string input = "package p; import p.Outer; interface IFoo"
1178 " { Outer.Inner get(); }";
1179
Devin Moore7b8d5c92020-03-17 14:14:08 -07001180 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1181 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001182
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001183 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001184 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001185 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1186 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001187}
1188
Devin Moore7b8d5c92020-03-17 14:14:08 -07001189TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001190 io_delegate_.SetFileContents(
1191 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001192 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001193 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001194 const string input_path = "p/IFoo.aidl";
1195 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001196 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1197 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001198 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001199 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1200 native_type.Resolve(typenames_);
1201
1202 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1203 // C++ understands C++ specific stuff
1204 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1205 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001206 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001207 EXPECT_EQ(1u, headers.size());
1208 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001209}
1210
Christopher Wileyf8136192016-04-12 14:19:35 -07001211TEST_F(AidlTest, WritesCorrectDependencyFile) {
1212 // While the in tree build system always gives us an output file name,
1213 // other android tools take advantage of our ability to infer the intended
1214 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001215 vector<string> args = {
1216 "aidl",
1217 "-d dep/file/path",
1218 "-o place/for/output",
1219 "p/IFoo.aidl"};
1220 Options options = Options::From(args);
1221 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001222 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001223 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001224 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001225 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1226}
1227
Dan Willemsen93298ee2016-11-10 23:55:55 -08001228TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1229 // While the in tree build system always gives us an output file name,
1230 // other android tools take advantage of our ability to infer the intended
1231 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001232 vector<string> args = {
1233 "aidl",
1234 "-d dep/file/path",
1235 "--ninja",
1236 "-o place/for/output",
1237 "p/IFoo.aidl"};
1238 Options options = Options::From(args);
1239 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001240 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001241 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001242 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001243 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1244}
1245
Jiyong Parkdf202122019-09-30 20:48:35 +09001246TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001247 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1248 // this by calling aidl with every .aidl file it finds, then parsing the
1249 // generated dependency files. Those that reference .java output files are
1250 // for interfaces and those that do not are parcelables. However, for both
1251 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001252 vector<string> args = {
1253 "aidl",
1254 "-o place/for/output",
1255 "-d dep/file/path",
1256 "p/Foo.aidl"};
1257 Options options = Options::From(args);
1258 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001259 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001260 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001261 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001262 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1263}
1264
1265TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1266 vector<string> args = {
1267 "aidl",
1268 "--structured",
1269 "-o place/for/output",
1270 "-d dep/file/path",
1271 "p/Foo.aidl"};
1272 Options options = Options::From(args);
1273 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1274 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1275 string actual_dep_file_contents;
1276 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1277 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001278}
1279
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001280TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1281 vector<string> args = {
1282 "aidl",
1283 "--lang=java",
1284 "-o place/for/output",
1285 "p/Foo.aidl"};
1286 Options options = Options::From(args);
1287 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1288 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1289 string output_file_contents;
1290 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1291}
1292
Devin Moore21b26772020-08-26 16:37:56 -07001293TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001294 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001295 const string list_array_parcelable =
1296 "package a; parcelable Foo {\n"
1297 " List[] lists; }";
1298 CaptureStderr();
1299 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1300 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1301}
1302
Jiyong Parkf8d53612020-05-04 14:06:13 +09001303TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1304 AidlError error;
1305 string expected_stderr =
1306 "ERROR: a/IFoo.aidl:2.7-11: "
1307 "Encountered an untyped List or Map. The use of untyped List/Map is "
1308 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1309 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1310 if (GetLanguage() != Options::Language::JAVA) {
1311 expected_stderr =
1312 "ERROR: a/IFoo.aidl:2.1-7: "
1313 "Currently, only the Java backend supports non-generic List.\n";
1314 }
1315
1316 const string primitive_interface =
1317 "package a; interface IFoo {\n"
1318 " List foo(); }";
1319 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001320 AidlTypenames tn1;
1321 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001322 {"--structured"}));
1323 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001324
1325 string primitive_parcelable =
1326 "package a; parcelable IFoo {\n"
1327 " List foo;}";
1328 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001329 AidlTypenames tn2;
1330 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001331 {"--structured"}));
1332 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1333}
1334
Jeongik Cha225519b2020-08-29 01:55:32 +09001335TEST_P(AidlTest, ExtensionTest) {
1336 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001337 string extendable_parcelable =
1338 "package a; parcelable Data {\n"
1339 " ParcelableHolder extension;\n"
1340 " ParcelableHolder extension2;\n"
1341 "}";
Jeongik Cha8f02a532020-10-14 00:16:28 +09001342 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001343 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1344 EXPECT_EQ(
Jeongik Cha8f02a532020-10-14 00:16:28 +09001345 "ERROR: a/Data.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001346 "yet.\n",
1347 GetCapturedStderr());
1348 } else {
1349 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1350 EXPECT_EQ("", GetCapturedStderr());
1351 }
1352}
1353TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1354 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001355 string parcelableholder_return_interface =
1356 "package a; interface IFoo {\n"
1357 " ParcelableHolder foo();\n"
1358 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001359 EXPECT_EQ(nullptr,
1360 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001361
Jeongik Cha8f02a532020-10-14 00:16:28 +09001362 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001363 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001364 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001365 "ERROR: a/IFoo.aidl:2.1-19: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001366 "yet.\n",
1367 GetCapturedStderr());
1368 return;
1369 }
1370 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1371 GetCapturedStderr());
1372}
1373
1374TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1375 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001376 string extendable_parcelable_arg_interface =
1377 "package a; interface IFoo {\n"
1378 " void foo(in ParcelableHolder ph);\n"
1379 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001380 EXPECT_EQ(nullptr,
1381 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1382
Jeongik Cha8f02a532020-10-14 00:16:28 +09001383 if (GetLanguage() == Options::Language::RUST) {
Jeongik Cha225519b2020-08-29 01:55:32 +09001384 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001385 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha8f02a532020-10-14 00:16:28 +09001386 "ERROR: a/IFoo.aidl:2.14-31: The Rust backend does not support ParcelableHolder "
Jeongik Cha225519b2020-08-29 01:55:32 +09001387 "yet.\n",
1388 GetCapturedStderr());
1389 return;
1390 }
1391 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1392 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001393}
1394
Jeongik Chaf6ec8982020-10-15 00:10:30 +09001395TEST_P(AidlTest, RejectNullableParcelableHolderField) {
1396 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { @nullable ParcelableHolder ext; }");
1397 Options options =
1398 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1399 const string expected_stderr = "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n";
1400 CaptureStderr();
1401 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
1402 if (GetLanguage() == Options::Language::RUST) {
1403 EXPECT_EQ(
1404 "ERROR: Foo.aidl:1.27-44: ParcelableHolder cannot be nullable.\n"
1405 "ERROR: Foo.aidl:1.27-44: The Rust backend does not support ParcelableHolder "
1406 "yet.\n",
1407 GetCapturedStderr());
1408 return;
1409 }
1410 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1411}
1412
Jooyung Han3f347ca2020-12-01 12:41:50 +09001413TEST_P(AidlTest, ParcelablesWithConstants) {
1414 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { const int BIT = 0x1 << 3; }");
1415 Options options =
1416 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1417 CaptureStderr();
1418 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1419 EXPECT_EQ("", GetCapturedStderr());
1420}
1421
1422TEST_P(AidlTest, UnionWithConstants) {
1423 io_delegate_.SetFileContents("Foo.aidl", "union Foo { const int BIT = 0x1 << 3; int n; }");
1424 Options options =
1425 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
1426 CaptureStderr();
1427 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1428 EXPECT_EQ("", GetCapturedStderr());
1429}
1430
Jiyong Park02da7422018-07-16 16:00:26 +09001431TEST_F(AidlTest, ApiDump) {
1432 io_delegate_.SetFileContents(
1433 "foo/bar/IFoo.aidl",
1434 "package foo.bar;\n"
1435 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001436 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001437 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001438 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001439 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1440 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1441 " IFoo foo3(IFoo foo);\n"
1442 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001443 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001444 " const int A = 1;\n"
1445 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001446 "}\n");
1447 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1448 "package foo.bar;\n"
1449 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001450 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001451 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001452 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001453 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001454 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001455 " int y;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001456 " /*@hide2*/\n"
Jooyung Han55f96ad2020-12-13 10:08:33 +09001457 " IFoo foo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001458 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001459 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001460 "}\n");
1461 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001462 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1463 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001464 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001465 bool result = dump_api(options, io_delegate_);
1466 ASSERT_TRUE(result);
1467 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001468 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001469 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001470/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001471interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001472 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001473 int foo(out int[] a, String b, boolean c, inout List<String> d);
1474 int foo2(@utf8InCpp String x, inout List<String> y);
1475 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1476 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001477 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001478 const int A = 1;
1479 const String STR = "Hello";
1480}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001481)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001482
Jiyong Parke59c3682018-09-11 23:10:25 +09001483 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001484 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001485/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001486parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001487 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001488 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001489 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001490 int y;
1491 foo.bar.IFoo foo;
Jeongik Cha997281d2020-01-16 15:23:59 +09001492 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001493 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001494}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001495)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001496}
1497
Jiyong Parked65bf42018-08-28 15:43:27 +09001498TEST_F(AidlTest, ApiDumpWithManualIds) {
1499 io_delegate_.SetFileContents(
1500 "foo/bar/IFoo.aidl",
1501 "package foo.bar;\n"
1502 "interface IFoo {\n"
1503 " int foo() = 1;\n"
1504 " int bar() = 2;\n"
1505 " int baz() = 10;\n"
1506 "}\n");
1507
Jiyong Parke59c3682018-09-11 23:10:25 +09001508 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001509 Options options = Options::From(args);
1510 bool result = dump_api(options, io_delegate_);
1511 ASSERT_TRUE(result);
1512 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001513 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001514 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001515interface IFoo {
1516 int foo() = 1;
1517 int bar() = 2;
1518 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001519}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001520)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001521}
1522
1523TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001524 const string expected_stderr =
1525 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1526 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001527 io_delegate_.SetFileContents(
1528 "foo/bar/IFoo.aidl",
1529 "package foo.bar;\n"
1530 "interface IFoo {\n"
1531 " int foo() = 1;\n"
1532 " int bar();\n"
1533 " int baz() = 10;\n"
1534 "}\n");
1535
Jiyong Parke59c3682018-09-11 23:10:25 +09001536 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001537 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001538 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001539 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001540 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001541}
1542
Jooyung Han965e31d2020-11-27 12:30:16 +09001543TEST_F(AidlTest, ApiDumpConstWithAnnotation) {
1544 io_delegate_.SetFileContents("foo/bar/IFoo.aidl",
1545 "package foo.bar;\n"
1546 "interface IFoo {\n"
1547 " @utf8InCpp String foo();\n"
1548 " const @utf8InCpp String bar = \"bar\";\n"
1549 "}\n");
1550
1551 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
1552 Options options = Options::From(args);
1553 CaptureStderr();
1554 EXPECT_TRUE(dump_api(options, io_delegate_));
1555 EXPECT_EQ("", GetCapturedStderr());
1556 string actual;
1557 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Jooyung Han965e31d2020-11-27 12:30:16 +09001558 EXPECT_EQ(string(kPreamble).append(R"(package foo.bar;
1559interface IFoo {
1560 @utf8InCpp String foo();
Jooyung Hanb3ca6302020-11-27 14:13:27 +09001561 const @utf8InCpp String bar = "bar";
Jooyung Han965e31d2020-11-27 12:30:16 +09001562}
1563)"),
1564 actual);
1565}
1566
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001567TEST_F(AidlTest, ApiDumpWithEnums) {
1568 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1569 "package foo.bar;\n"
1570 "enum Enum {\n"
1571 " FOO,\n"
1572 " BAR = FOO + 1,\n"
1573 "}\n");
1574
1575 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Enum.aidl"};
1576 Options options = Options::From(args);
1577 CaptureStderr();
1578 EXPECT_TRUE(dump_api(options, io_delegate_));
1579 EXPECT_EQ("", GetCapturedStderr());
1580 string actual;
1581 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Enum.aidl", &actual));
1582 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1583 "enum Enum {\n"
1584 " FOO = 0,\n"
1585 " BAR = 1,\n"
1586 "}\n"),
1587 actual);
1588}
1589
1590TEST_F(AidlTest, ApiDumpWithEnumDefaultValues) {
1591 io_delegate_.SetFileContents("foo/bar/Enum.aidl",
1592 "package foo.bar;\n"
1593 "enum Enum {\n"
1594 " FOO,\n"
1595 "}\n");
1596 io_delegate_.SetFileContents("foo/bar/Foo.aidl",
1597 "package foo.bar;\n"
1598 "import foo.bar.Enum;\n"
1599 "parcelable Foo {\n"
1600 " Enum e = Enum.FOO;\n"
1601 "}\n");
1602
1603 vector<string> args = {"aidl", "--dumpapi", "-I . ", "-o dump", "foo/bar/Foo.aidl"};
1604 Options options = Options::From(args);
1605 CaptureStderr();
1606 EXPECT_TRUE(dump_api(options, io_delegate_));
1607 EXPECT_EQ("", GetCapturedStderr());
1608 string actual;
1609 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Foo.aidl", &actual));
1610 EXPECT_EQ(string(kPreamble).append("package foo.bar;\n"
1611 "parcelable Foo {\n"
1612 " foo.bar.Enum e = foo.bar.Enum.FOO;\n"
1613 "}\n"),
1614 actual);
1615}
1616
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001617TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001618 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001619 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1620 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001621 const string expected_map_stderr =
1622 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001623 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1624 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001625 "package p; interface IFoo {"
1626 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001627 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001628 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001629 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001630
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001631 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001632 "package p; interface IFoo {"
1633 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001634 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001635 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001636 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001637}
1638
Jeongik Chae48d9942020-01-02 17:39:00 +09001639TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001640 const string expected_stderr =
1641 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001642 Options options = Options::From("aidl -I p p/IFoo.aidl");
1643 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1644
1645 io_delegate_.SetFileContents("p/IFoo.aidl",
1646 "package p; interface IFoo {"
1647 "Map<String, Bar> foo();}");
1648 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1649
1650 io_delegate_.SetFileContents("p/IFoo.aidl",
1651 "package p; interface IFoo {"
1652 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001653 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001654 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001655 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001656
1657 io_delegate_.SetFileContents("p/IFoo.aidl",
1658 "package p; interface IFoo {"
1659 "Map<String, String> foo();}");
1660 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1661
1662 io_delegate_.SetFileContents("p/IFoo.aidl",
1663 "package p; interface IFoo {"
1664 "Map<String, ParcelFileDescriptor> foo();}");
1665 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1666}
1667
Jeongik Chadf76dc72019-11-28 00:08:47 +09001668TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001669 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001670 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1671 io_delegate_.SetFileContents(options.InputFiles().front(),
1672 "package p; interface IFoo {"
1673 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001674 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001675 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001676 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001677}
1678
1679TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1680 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1681 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001682 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001683 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001684 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1685 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001686
1687 Options options = Options::From("aidl -I p p/IFoo.aidl");
1688 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1689 io_delegate_.SetFileContents("p/IFoo.aidl",
1690 "package p; interface IFoo {"
1691 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001692 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001693 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001694 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001695 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001696 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001697 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001698 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1699 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001700 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1701 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1702 io_delegate_.SetFileContents("p/IFoo.aidl",
1703 "package p; interface IFoo {"
1704 "Bar<String, ParcelFileDescriptor> foo();}");
1705 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001706
1707 io_delegate_.SetFileContents("p/IFoo.aidl",
1708 "package p; interface IFoo {"
1709 "Bar<int, long> foo();}");
1710
1711 io_delegate_.SetFileContents("p/IFoo.aidl",
1712 "package p; interface IFoo {"
1713 "Bar<int[], long[]> foo();}");
1714
1715 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001716}
1717
Jeongik Cha0e426012019-07-29 15:57:02 +09001718TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1719 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001720 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1721 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001722 for (const auto& rawOption : rawOptions) {
1723 string expected_stderr =
1724 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001725 Options options = Options::From(rawOption);
1726 io_delegate_.SetFileContents(options.InputFiles().front(),
1727 "package foo.bar;\n"
1728 "interface IFoo1 { int foo(); }\n"
1729 "interface IFoo2 { int foo(); }\n"
1730 "parcelable Data1 { int a; int b;}\n"
1731 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001732 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001733 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001734 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001735
Jeongik Cha0e426012019-07-29 15:57:02 +09001736 io_delegate_.SetFileContents(options.InputFiles().front(),
1737 "package foo.bar;\n"
1738 "interface IFoo1 { int foo(); }\n"
1739 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001740 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001741 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001742 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001743
Devin Moore5de18ed2020-04-02 13:52:29 -07001744 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001745 io_delegate_.SetFileContents(options.InputFiles().front(),
1746 "package foo.bar;\n"
1747 "parcelable Data1 { int a; int b;}\n"
1748 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001749 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001750 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001751 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001752 }
1753}
1754
Devin Moorebdba2a82020-03-31 15:19:02 -07001755TEST_P(AidlTest, FailParseOnEmptyFile) {
1756 const string contents = "";
1757 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1758 CaptureStderr();
1759 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1760 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1761}
1762
Jiyong Parkb034bf02018-07-30 17:44:33 +09001763TEST_F(AidlTest, MultipleInputFiles) {
1764 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001765 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001766
1767 io_delegate_.SetFileContents(options.InputFiles().at(0),
1768 "package foo.bar;\n"
1769 "import foo.bar.Data;\n"
1770 "interface IFoo { Data getData(); }\n");
1771
1772 io_delegate_.SetFileContents(options.InputFiles().at(1),
1773 "package foo.bar;\n"
1774 "import foo.bar.IFoo;\n"
1775 "parcelable Data { IFoo foo; }\n");
1776
1777 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1778
1779 string content;
1780 for (const auto file : {
1781 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1782 content.clear();
1783 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1784 EXPECT_FALSE(content.empty());
1785 }
1786}
1787
1788TEST_F(AidlTest, MultipleInputFilesCpp) {
1789 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001790 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001791
1792 io_delegate_.SetFileContents(options.InputFiles().at(0),
1793 "package foo.bar;\n"
1794 "import foo.bar.Data;\n"
1795 "interface IFoo { Data getData(); }\n");
1796
1797 io_delegate_.SetFileContents(options.InputFiles().at(1),
1798 "package foo.bar;\n"
1799 "import foo.bar.IFoo;\n"
1800 "parcelable Data { IFoo foo; }\n");
1801
1802 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1803
1804 string content;
1805 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001806 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001807 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1808 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1809 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1810 content.clear();
1811 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1812 EXPECT_FALSE(content.empty());
1813 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001814}
1815
Andrei Homescub62afd92020-05-11 19:24:59 -07001816TEST_F(AidlTest, MultipleInputFilesRust) {
1817 Options options =
1818 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1819
1820 io_delegate_.SetFileContents(options.InputFiles().at(0),
1821 "package foo.bar;\n"
1822 "import foo.bar.Data;\n"
1823 "interface IFoo { Data getData(); }\n");
1824
1825 io_delegate_.SetFileContents(options.InputFiles().at(1),
1826 "package foo.bar;\n"
1827 "import foo.bar.IFoo;\n"
1828 "parcelable Data { IFoo foo; }\n");
1829
1830 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1831
1832 string content;
1833 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1834 content.clear();
1835 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1836 EXPECT_FALSE(content.empty());
1837 }
1838}
1839
Devin Moore097a3ab2020-03-11 16:08:44 -07001840TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1841 const string expected_stderr =
1842 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001843 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1844 // int getInterfaceVersion() is one of the meta transactions
1845 io_delegate_.SetFileContents(options.InputFiles().front(),
1846 "package p; interface IFoo {"
1847 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001848 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001849 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001850 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1851}
Jiyong Park309668e2018-07-28 16:55:44 +09001852
Devin Moore097a3ab2020-03-11 16:08:44 -07001853TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1854 // boolean getInterfaceVersion() is not a meta transaction, but should be
1855 // prevented because return type is not part of a method signature
1856 const string expected_stderr =
1857 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1858 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001859 io_delegate_.SetFileContents(options.InputFiles().front(),
1860 "package p; interface IFoo {"
1861 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001862 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001863 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001864 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1865}
Jiyong Park309668e2018-07-28 16:55:44 +09001866
Devin Moore097a3ab2020-03-11 16:08:44 -07001867TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001868 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001869 const string expected_stderr =
1870 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1871 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001872 io_delegate_.SetFileContents(options.InputFiles().front(),
1873 "package p; interface IFoo {"
1874 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001875 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001876 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001877 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001878
1879 // this is not a meta interface method as it differs type arguments
1880 io_delegate_.SetFileContents(options.InputFiles().front(),
1881 "package p; interface IFoo {"
1882 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001883 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001884}
1885
Daniel Norman85aed542019-08-21 12:01:14 -07001886TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001887 Options options = Options::From("aidl --checkapi old new");
1888 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1889 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1890 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1891 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1892
1893 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1894}
1895
Jiyong Park3656c3c2018-08-01 20:02:01 +09001896TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001897 Options options = Options::From("aidl --checkapi old new");
1898 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1899 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001900
1901 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1902}
1903
Jooyung Hanfdaae1d2020-12-14 13:16:15 +09001904TEST_F(AidlTest, CheckApi_EnumFieldsWithDefaultValues) {
1905 Options options = Options::From("aidl --checkapi old new");
1906 const string foo_definition = "package p; parcelable Foo{ p.Enum e = p.Enum.FOO; }";
1907 const string enum_definition = "package p; enum Enum { FOO }";
1908 io_delegate_.SetFileContents("old/p/Foo.aidl", foo_definition);
1909 io_delegate_.SetFileContents("old/p/Enum.aidl", enum_definition);
1910 io_delegate_.SetFileContents("new/p/Foo.aidl", foo_definition);
1911 io_delegate_.SetFileContents("new/p/Enum.aidl", enum_definition);
1912
1913 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1914}
1915
Daniel Norman85aed542019-08-21 12:01:14 -07001916class AidlTestCompatibleChanges : public AidlTest {
1917 protected:
1918 Options options_ = Options::From("aidl --checkapi old new");
1919};
1920
1921TEST_F(AidlTestCompatibleChanges, NewType) {
1922 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1923 "package p;"
1924 "interface IFoo {"
1925 " void foo(int a);"
1926 "}");
1927 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1928 "package p;"
1929 "interface IFoo {"
1930 " void foo(int a);"
1931 "}");
1932 io_delegate_.SetFileContents("new/p/IBar.aidl",
1933 "package p;"
1934 "interface IBar {"
1935 " void bar();"
1936 "}");
1937 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1938}
1939
1940TEST_F(AidlTestCompatibleChanges, NewMethod) {
1941 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1942 "package p;"
1943 "interface IFoo {"
1944 " void foo(int a);"
1945 "}");
1946 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1947 "package p;"
1948 "interface IFoo {"
1949 " void foo(int a);"
1950 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001951 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001952 "}");
1953 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1954}
1955
1956TEST_F(AidlTestCompatibleChanges, NewField) {
1957 io_delegate_.SetFileContents("old/p/Data.aidl",
1958 "package p;"
1959 "parcelable Data {"
1960 " int foo;"
1961 "}");
1962 io_delegate_.SetFileContents("new/p/Data.aidl",
1963 "package p;"
1964 "parcelable Data {"
1965 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001966 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001967 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001968 "}");
1969 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1970}
1971
1972TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1973 io_delegate_.SetFileContents("old/p/Enum.aidl",
1974 "package p;"
1975 "enum Enum {"
1976 " FOO = 1,"
1977 "}");
1978 io_delegate_.SetFileContents("new/p/Enum.aidl",
1979 "package p;"
1980 "enum Enum {"
1981 " FOO = 1,"
1982 " BAR = 2,"
1983 "}");
1984 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1985}
1986
1987TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1988 io_delegate_.SetFileContents("old/p/Enum.aidl",
1989 "package p;"
1990 "enum Enum {"
1991 " FOO = 1,"
1992 " BAR = 2,"
1993 "}");
1994 io_delegate_.SetFileContents("new/p/Enum.aidl",
1995 "package p;"
1996 "enum Enum {"
1997 " BAR = 2,"
1998 " FOO = 1,"
1999 "}");
2000 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2001}
2002
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002003TEST_F(AidlTestCompatibleChanges, NewUnionField) {
2004 io_delegate_.SetFileContents("old/p/Union.aidl",
2005 "package p;"
2006 "union Union {"
2007 " String foo;"
2008 "}");
2009 io_delegate_.SetFileContents("new/p/Union.aidl",
2010 "package p;"
2011 "union Union {"
2012 " String foo;"
2013 " int num;"
2014 "}");
2015 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2016}
2017
Daniel Norman85aed542019-08-21 12:01:14 -07002018TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002019 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2020 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002021 "interface IFoo {"
2022 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002023 "}");
2024 io_delegate_.SetFileContents("old/p/Data.aidl",
2025 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002026 "parcelable Data {"
2027 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002028 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002029 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2030 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002031 "interface IFoo {"
2032 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002033 "}");
2034 io_delegate_.SetFileContents("new/p/Data.aidl",
2035 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002036 "parcelable Data {"
2037 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09002038 "}");
2039 io_delegate_.SetFileContents("new/q/IFoo.aidl",
2040 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002041 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002042 " void foo(int a);"
2043 "}");
2044 io_delegate_.SetFileContents("new/q/Data.aidl",
2045 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002046 "parcelable Data {"
2047 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002048 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002049 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2050}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002051
Daniel Norman85aed542019-08-21 12:01:14 -07002052TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
2053 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2054 "package p;"
2055 "interface IFoo {"
2056 " void foo(int a);"
2057 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002058 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2059 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002060 "interface IFoo {"
2061 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002062 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002063 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2064}
Jiyong Parke59c3682018-09-11 23:10:25 +09002065
Daniel Norman85aed542019-08-21 12:01:14 -07002066TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002067 io_delegate_.SetFileContents("old/p/I.aidl",
2068 "package p; interface I {"
2069 "const int A = 1; }");
2070 io_delegate_.SetFileContents("new/p/I.aidl",
2071 "package p ; interface I {"
2072 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002073 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2074}
Jiyong Parka428d212018-08-29 22:26:30 +09002075
Daniel Norman85aed542019-08-21 12:01:14 -07002076TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09002077 io_delegate_.SetFileContents("old/p/I.aidl",
2078 "package p; interface I {"
2079 "const int A = 1; const int B = 2;}");
2080 io_delegate_.SetFileContents("new/p/I.aidl",
2081 "package p ; interface I {"
2082 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07002083 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09002084}
2085
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002086TEST_F(AidlTestCompatibleChanges, ReorderedAnnatations) {
2087 io_delegate_.SetFileContents("old/p/Foo.aidl",
2088 "package p;"
2089 "@JavaPassthrough(annotation=\"Alice\")"
2090 "@JavaPassthrough(annotation=\"Bob\")"
2091 "parcelable Foo {}");
2092 io_delegate_.SetFileContents("new/p/Foo.aidl",
2093 "package p;"
2094 "@JavaPassthrough(annotation=\"Bob\")"
2095 "@JavaPassthrough(annotation=\"Alice\")"
2096 "parcelable Foo {}");
2097 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2098}
2099
Jooyung Han00073272020-11-27 14:20:20 +09002100TEST_F(AidlTestCompatibleChanges, OkayToDeprecate) {
2101 io_delegate_.SetFileContents("old/p/Foo.aidl",
2102 "package p;"
2103 "parcelable Foo {}");
2104 io_delegate_.SetFileContents("new/p/Foo.aidl",
2105 "package p;"
2106 "@JavaPassthrough(annotation=\"@Deprecated\")"
2107 "parcelable Foo {}");
2108 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2109}
2110
Jooyung Han636fd2f2020-10-22 11:33:45 +09002111TEST_F(AidlTestCompatibleChanges, NewFieldOfNewType) {
2112 io_delegate_.SetFileContents("old/p/Data.aidl",
2113 "package p;"
2114 "parcelable Data {"
2115 " int num;"
2116 "}");
2117 io_delegate_.SetFileContents(
2118 "new/p/Data.aidl",
2119 "package p;"
2120 "parcelable Data {"
2121 " int num;"
2122 " p.Enum e;" // this is considered as valid since 0(enum default) is valid for "Enum" type
2123 "}");
2124 io_delegate_.SetFileContents("new/p/Enum.aidl",
2125 "package p;"
2126 "enum Enum {"
2127 " FOO = 0,"
2128 " BAR = 1,"
2129 "}");
2130 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
2131}
2132
Daniel Norman85aed542019-08-21 12:01:14 -07002133class AidlTestIncompatibleChanges : public AidlTest {
2134 protected:
2135 Options options_ = Options::From("aidl --checkapi old new");
2136};
2137
2138TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09002139 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002140 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2141 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002142 "interface IFoo {"
2143 " void foo(in String[] str);"
2144 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002145 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07002146 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002147 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07002148 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002149}
2150
2151TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002152 const string expected_stderr =
2153 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002154 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2155 "package p;"
2156 "interface IFoo {"
2157 " void foo(in String[] str);"
2158 " void bar(@utf8InCpp String str);"
2159 "}");
2160 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2161 "package p;"
2162 "interface IFoo {"
2163 " void foo(in String[] str);"
2164 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002165 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002166 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002167 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002168}
2169
Jiyong Parkf8d53612020-05-04 14:06:13 +09002170TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
2171 const string expected_stderr =
2172 "ERROR: new/p/IFoo.aidl:1.61-65: "
2173 "Encountered an untyped List or Map. The use of untyped List/Map is "
2174 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2175 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2176 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
2177 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2178 "package p;"
2179 "interface IFoo {"
2180 " void foo(in String[] str);"
2181 "}");
2182 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2183 "package p;"
2184 "interface IFoo {"
2185 " void foo(in String[] str);"
2186 " void bar(in List arg);"
2187 "}");
2188 CaptureStderr();
2189 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2190 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2191}
2192
2193TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
2194 const string expected_stderr =
2195 "ERROR: new/p/Data.aidl:1.54-59: "
2196 "Encountered an untyped List or Map. The use of untyped List/Map is "
2197 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
2198 "the receiving side. Consider switching to an array or a generic List/Map.\n"
2199 "ERROR: new/p/Data.aidl: Failed to read.\n";
2200 io_delegate_.SetFileContents("old/p/Data.aidl",
2201 "package p;"
2202 "parcelable Data {"
2203 " int foo;"
2204 "}");
2205 io_delegate_.SetFileContents("new/p/Data.aidl",
2206 "package p;"
2207 "parcelable Data {"
2208 " int foo;"
2209 " @nullable List list;"
2210 "}");
2211 CaptureStderr();
2212 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2213 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2214}
2215
Daniel Norman85aed542019-08-21 12:01:14 -07002216TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002217 const string expected_stderr =
2218 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002219 io_delegate_.SetFileContents("old/p/Data.aidl",
2220 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002221 "parcelable Data {"
2222 " int foo;"
2223 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002224 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002225 io_delegate_.SetFileContents("new/p/Data.aidl",
2226 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002227 "parcelable Data {"
2228 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002229 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002230 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002231 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002232 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002233}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002234
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002235TEST_F(AidlTestIncompatibleChanges, NewFieldWithNoDefault) {
2236 const string expected_stderr =
2237 "ERROR: new/p/Data.aidl:1.46-50: Field 'str' does not have a useful default in some "
2238 "backends. Please either provide a default value for this field or mark the field as "
2239 "@nullable. This value or a null value will be used automatically when an old version of "
2240 "this parcelable is sent to a process which understands a new version of this parcelable. In "
2241 "order to make sure your code continues to be backwards compatible, make sure the default or "
2242 "null value does not cause a semantic change to this parcelable.\n";
2243 io_delegate_.SetFileContents("old/p/Data.aidl",
2244 "package p;"
2245 "parcelable Data {"
2246 " int num;"
2247 "}");
2248 io_delegate_.SetFileContents("new/p/Data.aidl",
2249 "package p;"
2250 "parcelable Data {"
2251 " int num;"
2252 " String str;"
2253 "}");
2254 CaptureStderr();
2255 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2256 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2257}
2258
Jooyung Han636fd2f2020-10-22 11:33:45 +09002259TEST_F(AidlTestIncompatibleChanges, NewFieldWithNonZeroEnum) {
2260 const string expected_stderr =
2261 "ERROR: new/p/Data.aidl:1.46-48: Field 'e' of enum 'Enum' can't be initialized as '0'. "
2262 "Please make sure 'Enum' has '0' as a valid value.\n";
2263 io_delegate_.SetFileContents("old/p/Data.aidl",
2264 "package p;"
2265 "parcelable Data {"
2266 " int num;"
2267 "}");
2268 io_delegate_.SetFileContents("new/p/Data.aidl",
2269 "package p;"
2270 "parcelable Data {"
2271 " int num;"
2272 " p.Enum e;"
2273 "}");
2274 io_delegate_.SetFileContents("new/p/Enum.aidl",
2275 "package p;"
2276 "enum Enum {"
2277 " FOO = 1,"
2278 " BAR = 2,"
2279 "}");
2280 CaptureStderr();
2281 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2282 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2283}
2284
Daniel Norman85aed542019-08-21 12:01:14 -07002285TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002286 const string expected_stderr =
2287 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002288 io_delegate_.SetFileContents("old/p/Enum.aidl",
2289 "package p;"
2290 "enum Enum {"
2291 " FOO = 1,"
2292 " BAR = 2,"
2293 "}");
2294 io_delegate_.SetFileContents("new/p/Enum.aidl",
2295 "package p;"
2296 "enum Enum {"
2297 " BAR = 2,"
2298 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002299 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002300 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002301 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002302}
2303
Jooyung Hanb5c55cd2020-10-22 07:59:01 +09002304TEST_F(AidlTestIncompatibleChanges, RemovedUnionField) {
2305 const string expected_stderr =
2306 "ERROR: new/p/Union.aidl:1.16-22: Number of fields in p.Union is reduced from 2 to 1.\n";
2307 io_delegate_.SetFileContents("old/p/Union.aidl",
2308 "package p;"
2309 "union Union {"
2310 " String str;"
2311 " int num;"
2312 "}");
2313 io_delegate_.SetFileContents("new/p/Union.aidl",
2314 "package p;"
2315 "union Union {"
2316 " String str;"
2317 "}");
2318 CaptureStderr();
2319 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2320 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2321}
2322
Daniel Norman85aed542019-08-21 12:01:14 -07002323TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002324 const string expected_stderr =
2325 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002326 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2327 "package p;"
2328 "interface IFoo {"
2329 " void foo(in String[] str);"
2330 " void bar(@utf8InCpp String str);"
2331 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002332 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2333 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002334 "interface IFoo {"
2335 " void foo(in String[] str);"
2336 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002337 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002338 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002339 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002340 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002341}
2342
Daniel Norman85aed542019-08-21 12:01:14 -07002343TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002344 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002345 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2346 "package p;"
2347 "interface IFoo {"
2348 " void foo(in String[] str);"
2349 " void bar(@utf8InCpp String str);"
2350 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002351 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
2352 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002353 "interface IFoo2 {"
2354 " void foo(in String[] str);"
2355 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002356 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002357 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002358 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002359 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002360}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002361
Daniel Norman85aed542019-08-21 12:01:14 -07002362TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002363 const string expected_stderr =
2364 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002365 io_delegate_.SetFileContents("old/p/Enum.aidl",
2366 "package p;"
2367 "enum Enum {"
2368 " FOO = 1,"
2369 " BAR = 2,"
2370 "}");
2371 io_delegate_.SetFileContents("new/p/Enum.aidl",
2372 "package p;"
2373 "enum Enum {"
2374 " FOO = 3,"
2375 " BAR = 2,"
2376 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002377 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002378 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002379 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002380}
2381
2382TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002383 const string expected_stderr =
2384 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2385 "from 0 to 1.\n"
2386 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2387 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002388 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2389 "package p;"
2390 "interface IFoo {"
2391 " void foo(in String[] str);"
2392 " void bar(@utf8InCpp String str);"
2393 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002394 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2395 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002396 "interface IFoo {"
2397 " void bar(@utf8InCpp String str);"
2398 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002399 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002400 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002401 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002402 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002403}
2404
2405TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002406 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002407 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2408 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002409 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002410 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002411 "parcelable Data {"
2412 " int foo;"
2413 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002414 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002415 io_delegate_.SetFileContents("new/p/Data.aidl",
2416 "package p;"
2417 "parcelable Data {"
2418 " int bar;"
2419 " int foo;"
2420 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002421 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002422 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002423 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002424}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002425
Daniel Norman85aed542019-08-21 12:01:14 -07002426TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002427 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002428 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002429 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002430 "interface IFoo {"
2431 " void foo(in String[] str);"
2432 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002433 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002434 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2435 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002436 "interface IFoo {"
2437 " void foo(out String[] str);"
2438 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002439 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002440 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002441 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002442 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002443}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002444
Daniel Norman85aed542019-08-21 12:01:14 -07002445TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002446 const string expected_stderr =
2447 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002448 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2449 "package p;"
2450 "interface IFoo {"
2451 " void foo(in String[] str);"
2452 " void bar(@utf8InCpp String str);"
2453 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002454 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2455 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002456 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002457 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002458 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002459 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002460 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002461 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002462 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002463}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002464
Daniel Norman85aed542019-08-21 12:01:14 -07002465TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002466 const string expected_stderr =
2467 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002468 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2469 "package p;"
2470 "interface IFoo {"
2471 " void foo(in String[] str);"
2472 " void bar(@utf8InCpp String str);"
2473 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002474 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2475 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002476 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002477 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002478 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002479 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002480 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002481 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002482 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002483}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002484
Jooyung Han60b2fde2020-10-29 15:12:40 +09002485TEST_F(AidlTestIncompatibleChanges, ChangedBackingTypeOfEnum) {
2486 const string expected_stderr =
2487 "ERROR: new/p/Foo.aidl:1.11-32: Type changed: byte to long.\n"
2488 "ERROR: new/p/Foo.aidl:1.36-40: Changed backing types.\n";
2489 io_delegate_.SetFileContents("old/p/Foo.aidl",
2490 "package p;"
2491 "@Backing(type=\"byte\")"
2492 "enum Foo {"
2493 " FOO, BAR,"
2494 "}");
2495 io_delegate_.SetFileContents("new/p/Foo.aidl",
2496 "package p;"
2497 "@Backing(type=\"long\")"
2498 "enum Foo {"
2499 " FOO, BAR,"
2500 "}");
2501 CaptureStderr();
2502 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2503 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2504}
2505
Jooyung Han69ea4ba2020-10-29 15:33:37 +09002506TEST_F(AidlTestIncompatibleChanges, ChangedAnnatationParams) {
2507 const string expected_stderr =
2508 "ERROR: new/p/Foo.aidl:1.55-59: Changed annotations: @JavaPassthrough(annotation=\"Alice\") "
2509 "to @JavaPassthrough(annotation=\"Bob\")\n";
2510 io_delegate_.SetFileContents("old/p/Foo.aidl",
2511 "package p;"
2512 "@JavaPassthrough(annotation=\"Alice\")"
2513 "parcelable Foo {}");
2514 io_delegate_.SetFileContents("new/p/Foo.aidl",
2515 "package p;"
2516 "@JavaPassthrough(annotation=\"Bob\")"
2517 "parcelable Foo {}");
2518
2519 CaptureStderr();
2520 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2521 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2522}
2523
Devin Mooredb7ac512020-08-07 11:17:36 -07002524TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2525 const string expected_stderr =
2526 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2527 io_delegate_.SetFileContents("old/p/Foo.aidl",
2528 "package p;"
2529 "parcelable Foo {"
2530 " int A;"
2531 "}");
2532 io_delegate_.SetFileContents("new/p/Foo.aidl",
2533 "package p;"
2534 "@JavaOnlyStableParcelable parcelable Foo {"
2535 " int A;"
2536 "}");
2537 CaptureStderr();
2538 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2539 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2540}
2541
2542TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2543 const string expected_stderr =
2544 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2545 io_delegate_.SetFileContents("old/p/Foo.aidl",
2546 "package p;"
2547 "@JavaOnlyStableParcelable parcelable Foo {"
2548 " int A;"
2549 "}");
2550 io_delegate_.SetFileContents("new/p/Foo.aidl",
2551 "package p;"
2552 "parcelable Foo {"
2553 " int A;"
2554 "}");
2555 CaptureStderr();
2556 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2557 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2558}
2559
Daniel Norman85aed542019-08-21 12:01:14 -07002560TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002561 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002562 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2563 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002564 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002565 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002566 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002567 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002568}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002569
Daniel Norman85aed542019-08-21 12:01:14 -07002570TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002571 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002572 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2573 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002574 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002575 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002576 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002577}
Jiyong Parka428d212018-08-29 22:26:30 +09002578
Daniel Norman85aed542019-08-21 12:01:14 -07002579TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002580 const string expected_stderr =
2581 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002582 io_delegate_.SetFileContents("old/p/I.aidl",
2583 "package p; interface I {"
2584 "const int A = 1; const int B = 2;}");
2585 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002586 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002587 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002588 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002589}
Jiyong Parka428d212018-08-29 22:26:30 +09002590
Daniel Norman85aed542019-08-21 12:01:14 -07002591TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002592 const string expected_stderr =
2593 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002594 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2595 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002596 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002597 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002598 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002599}
2600
Devin Moorec7e47a32020-08-07 10:55:25 -07002601TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2602 const string expected_stderr =
2603 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2604 "This is an incompatible change for FixedSize types.\n";
2605 io_delegate_.SetFileContents("old/p/Foo.aidl",
2606 "package p; @FixedSize parcelable Foo { int A = 1; }");
2607 io_delegate_.SetFileContents("new/p/Foo.aidl",
2608 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2609 CaptureStderr();
2610 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2611 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2612}
2613
2614TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2615 const string expected_stderr =
2616 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2617 io_delegate_.SetFileContents("old/p/Foo.aidl",
2618 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2619 io_delegate_.SetFileContents("new/p/Foo.aidl",
2620 "package p; @FixedSize parcelable Foo { int A = 1; }");
2621 CaptureStderr();
2622 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2623 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2624}
2625
2626TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2627 const string expected_stderr =
2628 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2629 "a.\n"
2630 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2631 "b.\n"
2632 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2633 "c.\n"
2634 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2635 "d.\n"
2636 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2637 "e.\n"
2638 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2639 "f.\n";
2640
2641 io_delegate_.SetFileContents("Foo.aidl",
2642 "@FixedSize parcelable Foo { "
2643 " int[] a;"
2644 " Bar b;"
2645 " String c;"
2646 " ParcelFileDescriptor d;"
2647 " IBinder e;"
2648 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002649 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002650 "}");
2651 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2652 Options options =
2653 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2654
2655 CaptureStderr();
2656 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2657 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2658}
2659
2660TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2661 const string expected_stderr = "";
2662
2663 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2664 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2665 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2666 Options options =
2667 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2668
2669 CaptureStderr();
2670 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2671 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2672}
2673
Jiyong Park8c380532018-08-30 14:55:26 +09002674TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002675 const string expected_stderr =
2676 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2677 "dir1/q/IBar.aidl\n"
2678 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002679 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002680 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2681 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2682 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2683 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2684
Devin Moore097a3ab2020-03-11 16:08:44 -07002685 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002686 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002687 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002688}
2689
Jiyong Parked65bf42018-08-28 15:43:27 +09002690TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002691 const string expected_stderr =
2692 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2693 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002694 Options options = Options::From("aidl --checkapi old new");
2695 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2696 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002697
2698 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2699
Jiyong Parke59c3682018-09-11 23:10:25 +09002700 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002701 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002702 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002703 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002704}
2705
Jiyong Parke05195e2018-10-08 18:24:23 +09002706TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2707 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2708 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002709 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002710
2711 // use without import
2712 io_delegate_.SetFileContents("p/IFoo.aidl",
2713 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2714 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2715 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002716 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002717
Devin Moore7b8d5c92020-03-17 14:14:08 -07002718 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002719 io_delegate_.SetFileContents(
2720 "p/IFoo.aidl",
2721 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2722 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2723 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002724 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002725
2726 // use with import (as before)
2727 io_delegate_.SetFileContents("p/IFoo.aidl",
2728 "package p;"
2729 "import android.os.ParcelFileDescriptor;"
2730 "interface IFoo{"
2731 " void foo(in ParcelFileDescriptor fd);"
2732 "}");
2733 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2734 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002735 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002736}
Jiyong Parked65bf42018-08-28 15:43:27 +09002737
Jiyong Park3633b722019-04-11 15:38:26 +09002738TEST_F(AidlTest, ManualIds) {
2739 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2740 io_delegate_.SetFileContents("IFoo.aidl",
2741 "interface IFoo {\n"
2742 " void foo() = 0;\n"
2743 " void bar() = 1;\n"
2744 "}");
2745 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2746}
2747
2748TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2749 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2750 io_delegate_.SetFileContents("IFoo.aidl",
2751 "interface IFoo {\n"
2752 " void foo() = 0;\n"
2753 " void bar() = 1;\n"
2754 "}");
2755 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2756}
2757
2758TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002759 const string expected_stderr =
2760 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002761 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2762 io_delegate_.SetFileContents("IFoo.aidl",
2763 "interface IFoo {\n"
2764 " void foo() = 3;\n"
2765 " void bar() = 3;\n"
2766 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002767 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002768 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002769 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002770}
2771
2772TEST_F(AidlTest, FailOnOutOfRangeIds) {
2773 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002774 const string expected_stderr =
2775 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2776 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002777 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2778 io_delegate_.SetFileContents("IFoo.aidl",
2779 "interface IFoo {\n"
2780 " void foo() = 3;\n"
2781 " void bar() = 16777115;\n"
2782 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002783 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002784 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002785 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002786}
2787
2788TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002789 const string expected_stderr =
2790 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002791 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2792 io_delegate_.SetFileContents("IFoo.aidl",
2793 "interface IFoo {\n"
2794 " void foo() = 3;\n"
2795 " void bar();\n"
2796 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002797 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002798 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002799 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002800}
2801
Jiyong Parkc6816252019-07-08 08:12:28 +09002802TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2803 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2804 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2805 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2806 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2807}
2808
2809TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002810 const string expected_stderr =
2811 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2812 "dir/IBar.aidl\n"
2813 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002814 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002815
Jiyong Parkc6816252019-07-08 08:12:28 +09002816 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2817 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2818 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2819 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002820 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002821 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002822 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002823}
2824
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002825TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2826 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2827 "package a.b;\n"
2828 "import a.b.IBar;\n"
2829 "import a.b.IQux;\n"
2830 "interface IFoo { IQux foo(); }\n");
2831 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2832 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2833
2834 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2835 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2836
2837 string output;
2838 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2839 // IBar was imported but wasn't used. include is not expected.
2840 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2841 // IBar was imported and used. include is expected.
2842 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2843}
2844
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002845TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002846 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002847 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002848 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2849 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002850 interface IFoo {
2851 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002852 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002853 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002854 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002855 // JavaPassthrough should work with other types as well (e.g. enum)
2856 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2857 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2858 @JavaPassthrough(annotation="@com.android.AliceTwo")
2859 @Backing(type="byte")
2860 enum MyEnum {
2861 a, b, c
2862 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002863
Jooyung Han4cde01d2020-10-13 11:10:47 +09002864 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002865 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2866
2867 string java_out;
2868 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002869 // type-decl-level annotations with newline at the end
2870 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2871 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2872 // member-decl-level annotations with newline at the end
2873 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2874 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2875 // inline annotations with space at the end
2876 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002877
Jooyung Han4cde01d2020-10-13 11:10:47 +09002878 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2879 // type-decl-level annotations with newline at the end
2880 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2881 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2882
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002883 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002884 Options cpp_options =
2885 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002886 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2887
Jooyung Han4cde01d2020-10-13 11:10:47 +09002888 Options ndk_options =
2889 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002890 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002891
Jooyung Han4cde01d2020-10-13 11:10:47 +09002892 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002893 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002894}
2895
Andrei Homescue61feb52020-08-18 15:44:24 -07002896TEST_F(AidlTest, ParseRustDerive) {
2897 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2898 @RustDerive(Clone=true, Copy=false)
2899 parcelable Foo {
2900 int a;
2901 })");
2902
2903 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2904 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2905
2906 string rust_out;
2907 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2908 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2909
2910 // Other backends shouldn't be bothered
2911 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2912 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2913
2914 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2915 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2916
2917 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2918 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2919}
2920
Jiyong Park56f73d72019-06-11 12:20:28 +09002921class AidlOutputPathTest : public AidlTest {
2922 protected:
2923 void SetUp() override {
2924 AidlTest::SetUp();
2925 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2926 }
2927
2928 void Test(const Options& options, const std::string expected_output_path) {
2929 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2930 // check the existence
2931 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2932 }
2933};
2934
2935TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2936 // <out_dir> / <package_name> / <type_name>.java
2937 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2938}
2939
2940TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2941 // when output file is explicitly set, it is always respected. -o option is
2942 // ignored.
2943 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2944}
2945
2946TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2947 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2948}
2949
2950TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2951 // output is the same as the input file except for the suffix
2952 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2953}
2954
Devin Moore7b8d5c92020-03-17 14:14:08 -07002955TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002956 AidlError error;
2957 const string expected_stderr =
2958 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2959 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002960 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2961 R"(package p;
2962 interface IFoo {
2963 const int int32_max_oob = 2147483650;
2964 }
2965 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002966 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002967 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2968 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002969}
2970
Devin Moore7b8d5c92020-03-17 14:14:08 -07002971TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002972 AidlError error;
2973 const string expected_stderr =
2974 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2975 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002976 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2977 R"(package p;
2978 interface IFoo {
2979 const int int32_min_oob = -2147483650;
2980 }
2981 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002982 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002983 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2984 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002985}
2986
Devin Moore7b8d5c92020-03-17 14:14:08 -07002987TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002988 AidlError error;
2989 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002990 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002991 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002992 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2993 R"(package p;
2994 interface IFoo {
2995 const long int64_max_oob = 21474836509999999999999999;
2996 }
2997 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002998 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002999 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3000 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003001}
3002
Devin Moore7b8d5c92020-03-17 14:14:08 -07003003TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003004 AidlError error;
3005 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07003006 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07003007 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07003008 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
3009 R"(package p;
3010 interface IFoo {
3011 const long int64_min_oob = -21474836509999999999999999;
3012 }
3013 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003014 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07003015 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3016 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07003017}
3018
Devin Moore7b8d5c92020-03-17 14:14:08 -07003019TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07003020 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07003021 const string expected_stderr =
Jooyung Han29813842020-12-08 01:28:03 +09003022 "ERROR: p/TestEnum.aidl:5.1-36: Invalid type specifier for an int32 literal: byte\n"
Devin Mooredf93ebb2020-03-25 14:03:35 -07003023 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
3024 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07003025 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3026 R"(package p;
3027 @Backing(type="byte")
3028 enum TestEnum {
3029 FOO = 127,
3030 BAR,
3031 }
3032 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07003033 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07003034 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07003035 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07003036}
3037
Devin Mooredecaf292020-04-30 09:16:40 -07003038TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
3039 AidlError error;
3040 const string expected_stderr =
3041 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
3042 "be one of: type\n"
3043 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
3044 "be one of: type\n";
3045 CaptureStderr();
3046 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
3047 R"(package p;
3048 @Backing(foo="byte")
3049 enum TestEnum {
3050 FOO = 1,
3051 BAR,
3052 }
3053 )",
3054 typenames_, GetLanguage(), &error));
3055 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3056 EXPECT_EQ(AidlError::BAD_TYPE, error);
3057}
3058
Jooyung Han66813932020-10-23 13:24:44 +09003059TEST_F(AidlTest, SupportJavaOnlyImmutableAnnotation) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003060 io_delegate_.SetFileContents("Foo.aidl",
3061 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
3062 "Map<String, Baz> d; Bar[] e; }");
3063 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
3064 io_delegate_.SetFileContents("Baz.aidl",
3065 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003066 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
3067 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3068}
3069
Jooyung Han66813932020-10-23 13:24:44 +09003070TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003071 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09003072 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
Jooyung Hand4057c42020-10-23 13:28:22 +09003073 string expected_error =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003074 "ERROR: Foo.aidl:1.40-44: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
3075 "named 'bar'.\n";
3076 CaptureStderr();
3077 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3078 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3079 EXPECT_EQ(expected_error, GetCapturedStderr());
3080}
3081
3082TEST_F(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableUnion) {
3083 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable union Foo { Bar bar; }");
3084 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
3085 string expected_error =
3086 "ERROR: Foo.aidl:1.35-39: The @JavaOnlyImmutable 'Foo' has a non-immutable field "
Jooyung Hand4057c42020-10-23 13:28:22 +09003087 "named 'bar'.\n";
3088 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003089 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
3090 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Hand4057c42020-10-23 13:28:22 +09003091 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003092}
3093
Jooyung Han66813932020-10-23 13:24:44 +09003094TEST_F(AidlTest, ImmutableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003095 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003096 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo foo); }");
3097 string expected_error =
3098 "ERROR: IBar.aidl:1.35-39: 'foo' can't be an inout parameter because @JavaOnlyImmutable can "
3099 "only be an in parameter.\n";
3100 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003101 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3102 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003103 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003104}
3105
Jooyung Han66813932020-10-23 13:24:44 +09003106TEST_F(AidlTest, ImmutableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003107 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jooyung Han15fd6c62020-10-23 13:54:46 +09003108 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo foo); }");
3109 string expected_error =
3110 "ERROR: IBar.aidl:1.33-37: 'foo' can't be an out parameter because @JavaOnlyImmutable can "
3111 "only be an in parameter.\n";
3112 CaptureStderr();
Jeongik Cha36f76c32020-07-28 00:25:52 +09003113 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
3114 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jooyung Han15fd6c62020-10-23 13:54:46 +09003115 EXPECT_EQ(expected_error, GetCapturedStderr());
Jeongik Cha36f76c32020-07-28 00:25:52 +09003116}
3117
Jooyung Han66813932020-10-23 13:24:44 +09003118TEST_F(AidlTest, ImmutableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09003119 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09003120 Options options = Options::From("aidl --lang=java Foo.aidl");
3121 const string expected_stderr =
Jooyung Han59af9cc2020-10-25 21:44:14 +09003122 "ERROR: Foo.aidl:1.47-49: 'Foo' has duplicate field name 'A' after capitalizing the first "
3123 "letter\n";
Jeongik Cha91180252020-07-31 15:43:11 +09003124 CaptureStderr();
3125 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3126 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3127}
Devin Moore53fc99c2020-08-12 08:07:52 -07003128
Jooyung Han1f14ab32020-10-14 13:48:29 +09003129const char kUnionExampleExpectedOutputCppHeader[] = R"(#pragma once
3130
3131#include <a/ByteEnum.h>
3132#include <binder/Parcel.h>
Jooyung Hand2fa0232020-10-19 02:51:41 +09003133#include <binder/ParcelFileDescriptor.h>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003134#include <binder/Status.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003135#include <cassert>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003136#include <codecvt>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003137#include <cstdint>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003138#include <locale>
3139#include <sstream>
Jooyung Han3df81ae2020-10-17 17:59:59 +09003140#include <type_traits>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003141#include <utility>
3142#include <variant>
3143#include <vector>
3144
Jooyung Handf39e192020-11-23 15:59:46 +09003145#ifndef __BIONIC__
3146#define __assert2(a,b,c,d) ((void)0)
3147#endif
3148
Jooyung Han1f14ab32020-10-14 13:48:29 +09003149namespace a {
3150
3151class Foo : public ::android::Parcelable {
3152public:
Jooyung Han97945de2020-10-15 16:41:38 +09003153 inline bool operator!=(const Foo& rhs) const {
3154 return _value != rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003155 }
Jooyung Han97945de2020-10-15 16:41:38 +09003156 inline bool operator<(const Foo& rhs) const {
3157 return _value < rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003158 }
Jooyung Han97945de2020-10-15 16:41:38 +09003159 inline bool operator<=(const Foo& rhs) const {
3160 return _value <= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003161 }
Jooyung Han97945de2020-10-15 16:41:38 +09003162 inline bool operator==(const Foo& rhs) const {
3163 return _value == rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003164 }
Jooyung Han97945de2020-10-15 16:41:38 +09003165 inline bool operator>(const Foo& rhs) const {
3166 return _value > rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003167 }
Jooyung Han97945de2020-10-15 16:41:38 +09003168 inline bool operator>=(const Foo& rhs) const {
3169 return _value >= rhs._value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003170 }
Jooyung Han97945de2020-10-15 16:41:38 +09003171
Jooyung Han1f14ab32020-10-14 13:48:29 +09003172 enum Tag : int32_t {
Jooyung Han97945de2020-10-15 16:41:38 +09003173 ns = 0, // int[] ns;
3174 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003175 pfd, // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003176 };
Jooyung Han97945de2020-10-15 16:41:38 +09003177
Jooyung Han1f14ab32020-10-14 13:48:29 +09003178 template<typename _Tp>
Jooyung Han97945de2020-10-15 16:41:38 +09003179 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003180
3181 Foo() : _value(std::in_place_index<ns>, ::std::vector<int32_t>({42})) { }
Jooyung Han97945de2020-10-15 16:41:38 +09003182 Foo(const Foo&) = default;
3183 Foo(Foo&&) = default;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003184 Foo& operator=(const Foo&) = default;
3185 Foo& operator=(Foo&&) = default;
3186
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003187 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3188 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han97945de2020-10-15 16:41:38 +09003189 constexpr Foo(_Tp&& _arg)
3190 : _value(std::forward<_Tp>(_arg)) {}
3191
3192 template <typename... _Tp>
3193 constexpr explicit Foo(_Tp&&... _args)
3194 : _value(std::forward<_Tp>(_args)...) {}
3195
3196 template <Tag _tag, typename... _Tp>
3197 static Foo make(_Tp&&... _args) {
3198 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003199 }
Jooyung Han97945de2020-10-15 16:41:38 +09003200
3201 template <Tag _tag, typename _Tp, typename... _Up>
3202 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3203 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003204 }
3205
3206 Tag getTag() const {
Jooyung Han97945de2020-10-15 16:41:38 +09003207 return static_cast<Tag>(_value.index());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003208 }
3209
Jooyung Han97945de2020-10-15 16:41:38 +09003210 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003211 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003212 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003213 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003214 }
3215
Jooyung Han97945de2020-10-15 16:41:38 +09003216 template <Tag _tag>
Jooyung Han1f14ab32020-10-14 13:48:29 +09003217 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003218 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han97945de2020-10-15 16:41:38 +09003219 return std::get<_tag>(_value);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003220 }
3221
Jooyung Han97945de2020-10-15 16:41:38 +09003222 template <Tag _tag, typename... _Tp>
3223 void set(_Tp&&... _args) {
3224 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003225 }
3226
3227 ::android::status_t readFromParcel(const ::android::Parcel* _aidl_parcel) override final;
3228 ::android::status_t writeToParcel(::android::Parcel* _aidl_parcel) const override final;
3229 static const std::string& getParcelableDescriptor() {
3230 static const std::string DESCIPTOR = "a.Foo";
3231 return DESCIPTOR;
3232 }
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003233 template <typename _T> class _has_toString {
3234 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3235 template <typename _U> static std::false_type __has_toString(...);
3236 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3237 };
3238 template <typename _T> inline static std::string _call_toString(const _T& t) {
3239 if constexpr (_has_toString<_T>::value) return t.toString();
3240 return "{no toString() implemented}";
3241 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003242 inline std::string toString() const {
3243 std::ostringstream os;
3244 os << "Foo{";
3245 switch (getTag()) {
3246 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3247 case e: os << "e: " << a::toString(get<e>()); break;
3248 case pfd: os << "pfd: " << ""; break;
3249 }
3250 os << "}";
3251 return os.str();
3252 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003253private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003254 std::variant<::std::vector<int32_t>, ::a::ByteEnum, ::android::os::ParcelFileDescriptor> _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003255}; // class Foo
3256
3257} // namespace a
3258)";
3259
3260const char kUnionExampleExpectedOutputCppSource[] = R"(#include <a/Foo.h>
3261
3262namespace a {
3263
3264::android::status_t Foo::readFromParcel(const ::android::Parcel* _aidl_parcel) {
3265 ::android::status_t _aidl_ret_status;
3266 int32_t _aidl_tag;
3267 if ((_aidl_ret_status = _aidl_parcel->readInt32(&_aidl_tag)) != ::android::OK) return _aidl_ret_status;
3268 switch (_aidl_tag) {
3269 case ns: {
3270 ::std::vector<int32_t> _aidl_value;
3271 if ((_aidl_ret_status = _aidl_parcel->readInt32Vector(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003272 if constexpr (std::is_trivially_copyable_v<::std::vector<int32_t>>) {
3273 set<ns>(_aidl_value);
3274 } else {
3275 // NOLINTNEXTLINE(performance-move-const-arg)
3276 set<ns>(std::move(_aidl_value));
3277 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003278 return ::android::OK; }
3279 case e: {
3280 ::a::ByteEnum _aidl_value;
3281 if ((_aidl_ret_status = _aidl_parcel->readByte(reinterpret_cast<int8_t *>(&_aidl_value))) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003282 if constexpr (std::is_trivially_copyable_v<::a::ByteEnum>) {
3283 set<e>(_aidl_value);
3284 } else {
3285 // NOLINTNEXTLINE(performance-move-const-arg)
3286 set<e>(std::move(_aidl_value));
3287 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003288 return ::android::OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003289 case pfd: {
3290 ::android::os::ParcelFileDescriptor _aidl_value;
3291 if ((_aidl_ret_status = _aidl_parcel->readParcelable(&_aidl_value)) != ::android::OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003292 if constexpr (std::is_trivially_copyable_v<::android::os::ParcelFileDescriptor>) {
3293 set<pfd>(_aidl_value);
3294 } else {
3295 // NOLINTNEXTLINE(performance-move-const-arg)
3296 set<pfd>(std::move(_aidl_value));
3297 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003298 return ::android::OK; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003299 }
3300 return ::android::BAD_VALUE;
3301}
3302
3303::android::status_t Foo::writeToParcel(::android::Parcel* _aidl_parcel) const {
3304 ::android::status_t _aidl_ret_status = _aidl_parcel->writeInt32(getTag());
3305 if (_aidl_ret_status != ::android::OK) return _aidl_ret_status;
3306 switch (getTag()) {
3307 case ns: return _aidl_parcel->writeInt32Vector(get<ns>());
3308 case e: return _aidl_parcel->writeByte(static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003309 case pfd: return _aidl_parcel->writeParcelable(get<pfd>());
Jooyung Han1f14ab32020-10-14 13:48:29 +09003310 }
Jooyung Handf39e192020-11-23 15:59:46 +09003311 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003312}
3313
3314} // namespace a
3315)";
3316
Jooyung Han6beac042020-10-17 21:59:43 +09003317const char kUnionExampleExpectedOutputNdkHeader[] = R"(#pragma once
3318#include <android/binder_interface_utils.h>
3319#include <android/binder_parcelable_utils.h>
Jooyung Han74b1dd42020-11-01 22:17:16 +09003320#include <codecvt>
3321#include <locale>
3322#include <sstream>
Jooyung Han6beac042020-10-17 21:59:43 +09003323
Jooyung Handf39e192020-11-23 15:59:46 +09003324#include <cassert>
Jooyung Han6beac042020-10-17 21:59:43 +09003325#include <type_traits>
3326#include <utility>
3327#include <variant>
3328#include <cstdint>
3329#include <memory>
3330#include <optional>
3331#include <string>
3332#include <vector>
3333#ifdef BINDER_STABILITY_SUPPORT
3334#include <android/binder_stability.h>
3335#endif // BINDER_STABILITY_SUPPORT
3336#include <aidl/a/ByteEnum.h>
Jooyung Handf39e192020-11-23 15:59:46 +09003337
3338#ifndef __BIONIC__
3339#define __assert2(a,b,c,d) ((void)0)
3340#endif
3341
Jooyung Han6beac042020-10-17 21:59:43 +09003342namespace aidl {
3343namespace a {
3344class Foo {
3345public:
3346 typedef std::false_type fixed_size;
3347 static const char* descriptor;
3348
3349 enum Tag : int32_t {
3350 ns = 0, // int[] ns;
3351 e, // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003352 pfd, // ParcelFileDescriptor pfd;
Jooyung Han6beac042020-10-17 21:59:43 +09003353 };
3354
3355 template<typename _Tp>
3356 static constexpr bool _not_self = !std::is_same_v<std::remove_cv_t<std::remove_reference_t<_Tp>>, Foo>;
3357
3358 Foo() : _value(std::in_place_index<ns>, std::vector<int32_t>({42})) { }
3359 Foo(const Foo&) = default;
3360 Foo(Foo&&) = default;
3361 Foo& operator=(const Foo&) = default;
3362 Foo& operator=(Foo&&) = default;
3363
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003364 template <typename _Tp, typename = std::enable_if_t<_not_self<_Tp>>>
3365 // NOLINTNEXTLINE(google-explicit-constructor)
Jooyung Han6beac042020-10-17 21:59:43 +09003366 constexpr Foo(_Tp&& _arg)
3367 : _value(std::forward<_Tp>(_arg)) {}
3368
3369 template <typename... _Tp>
3370 constexpr explicit Foo(_Tp&&... _args)
3371 : _value(std::forward<_Tp>(_args)...) {}
3372
3373 template <Tag _tag, typename... _Tp>
3374 static Foo make(_Tp&&... _args) {
3375 return Foo(std::in_place_index<_tag>, std::forward<_Tp>(_args)...);
3376 }
3377
3378 template <Tag _tag, typename _Tp, typename... _Up>
3379 static Foo make(std::initializer_list<_Tp> _il, _Up&&... _args) {
3380 return Foo(std::in_place_index<_tag>, std::move(_il), std::forward<_Up>(_args)...);
3381 }
3382
3383 Tag getTag() const {
3384 return static_cast<Tag>(_value.index());
3385 }
3386
3387 template <Tag _tag>
3388 const auto& get() const {
Jooyung Handf39e192020-11-23 15:59:46 +09003389 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003390 return std::get<_tag>(_value);
3391 }
3392
3393 template <Tag _tag>
3394 auto& get() {
Jooyung Handf39e192020-11-23 15:59:46 +09003395 if (getTag() != _tag) { __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "bad access: a wrong tag"); }
Jooyung Han6beac042020-10-17 21:59:43 +09003396 return std::get<_tag>(_value);
3397 }
3398
3399 template <Tag _tag, typename... _Tp>
3400 void set(_Tp&&... _args) {
3401 _value.emplace<_tag>(std::forward<_Tp>(_args)...);
3402 }
3403
3404 binder_status_t readFromParcel(const AParcel* _parcel);
3405 binder_status_t writeToParcel(AParcel* _parcel) const;
Steven Morelandf58804a2020-12-07 18:12:15 +00003406
3407 inline bool operator!=(const Foo& rhs) const {
3408 return _value != rhs._value;
3409 }
3410 inline bool operator<(const Foo& rhs) const {
3411 return _value < rhs._value;
3412 }
3413 inline bool operator<=(const Foo& rhs) const {
3414 return _value <= rhs._value;
3415 }
3416 inline bool operator==(const Foo& rhs) const {
3417 return _value == rhs._value;
3418 }
3419 inline bool operator>(const Foo& rhs) const {
3420 return _value > rhs._value;
3421 }
3422 inline bool operator>=(const Foo& rhs) const {
3423 return _value >= rhs._value;
3424 }
3425
Jooyung Han6beac042020-10-17 21:59:43 +09003426 static const ::ndk::parcelable_stability_t _aidl_stability = ::ndk::STABILITY_LOCAL;
Jooyung Hanb8e01b92020-11-01 16:49:13 +09003427 template <typename _T> class _has_toString {
3428 template <typename _U> static std::true_type __has_toString(decltype(&_U::toString));
3429 template <typename _U> static std::false_type __has_toString(...);
3430 public: enum { value = decltype(__has_toString<_T>(nullptr))::value };
3431 };
3432 template <typename _T> inline static std::string _call_toString(const _T& t) {
3433 if constexpr (_has_toString<_T>::value) return t.toString();
3434 return "{no toString() implemented}";
3435 }
Jooyung Han74b1dd42020-11-01 22:17:16 +09003436 inline std::string toString() const {
3437 std::ostringstream os;
3438 os << "Foo{";
3439 switch (getTag()) {
3440 case ns: os << "ns: " << [&](){ std::ostringstream o; o << "["; bool first = true; for (const auto& v: get<ns>()) { (void)v; if (first) first = false; else o << ", "; o << std::to_string(v); }; o << "]"; return o.str(); }(); break;
3441 case e: os << "e: " << a::toString(get<e>()); break;
3442 case pfd: os << "pfd: " << ""; break;
3443 }
3444 os << "}";
3445 return os.str();
3446 }
Jooyung Han6beac042020-10-17 21:59:43 +09003447private:
Jooyung Hand2fa0232020-10-19 02:51:41 +09003448 std::variant<std::vector<int32_t>, ::aidl::a::ByteEnum, ::ndk::ScopedFileDescriptor> _value;
Jooyung Han6beac042020-10-17 21:59:43 +09003449};
3450} // namespace a
3451} // namespace aidl
3452)";
3453
3454const char kUnionExampleExpectedOutputNdkSource[] = R"(#include "aidl/a/Foo.h"
3455
3456#include <android/binder_parcel_utils.h>
3457
3458namespace aidl {
3459namespace a {
3460const char* Foo::descriptor = "a.Foo";
3461
3462binder_status_t Foo::readFromParcel(const AParcel* _parcel) {
3463 binder_status_t _aidl_ret_status;
3464 int32_t _aidl_tag;
3465 if ((_aidl_ret_status = AParcel_readInt32(_parcel, &_aidl_tag)) != STATUS_OK) return _aidl_ret_status;
3466 switch (_aidl_tag) {
3467 case ns: {
3468 std::vector<int32_t> _aidl_value;
3469 if ((_aidl_ret_status = ::ndk::AParcel_readVector(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003470 if constexpr (std::is_trivially_copyable_v<std::vector<int32_t>>) {
3471 set<ns>(_aidl_value);
3472 } else {
3473 // NOLINTNEXTLINE(performance-move-const-arg)
3474 set<ns>(std::move(_aidl_value));
3475 }
Jooyung Han6beac042020-10-17 21:59:43 +09003476 return STATUS_OK; }
3477 case e: {
3478 ::aidl::a::ByteEnum _aidl_value;
3479 if ((_aidl_ret_status = AParcel_readByte(_parcel, reinterpret_cast<int8_t*>(&_aidl_value))) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003480 if constexpr (std::is_trivially_copyable_v<::aidl::a::ByteEnum>) {
3481 set<e>(_aidl_value);
3482 } else {
3483 // NOLINTNEXTLINE(performance-move-const-arg)
3484 set<e>(std::move(_aidl_value));
3485 }
Jooyung Han6beac042020-10-17 21:59:43 +09003486 return STATUS_OK; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003487 case pfd: {
3488 ::ndk::ScopedFileDescriptor _aidl_value;
3489 if ((_aidl_ret_status = ::ndk::AParcel_readRequiredParcelFileDescriptor(_parcel, &_aidl_value)) != STATUS_OK) return _aidl_ret_status;
Jiyong Parkdd57f1a2020-11-16 20:19:55 +09003490 if constexpr (std::is_trivially_copyable_v<::ndk::ScopedFileDescriptor>) {
3491 set<pfd>(_aidl_value);
3492 } else {
3493 // NOLINTNEXTLINE(performance-move-const-arg)
3494 set<pfd>(std::move(_aidl_value));
3495 }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003496 return STATUS_OK; }
Jooyung Han6beac042020-10-17 21:59:43 +09003497 }
3498 return STATUS_BAD_VALUE;
3499}
3500binder_status_t Foo::writeToParcel(AParcel* _parcel) const {
3501 binder_status_t _aidl_ret_status = AParcel_writeInt32(_parcel, getTag());
3502 if (_aidl_ret_status != STATUS_OK) return _aidl_ret_status;
3503 switch (getTag()) {
3504 case ns: return ::ndk::AParcel_writeVector(_parcel, get<ns>());
3505 case e: return AParcel_writeByte(_parcel, static_cast<int8_t>(get<e>()));
Jooyung Hand2fa0232020-10-19 02:51:41 +09003506 case pfd: return ::ndk::AParcel_writeRequiredParcelFileDescriptor(_parcel, get<pfd>());
Jooyung Han6beac042020-10-17 21:59:43 +09003507 }
Jooyung Handf39e192020-11-23 15:59:46 +09003508 __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, "can't reach here");
Jooyung Han6beac042020-10-17 21:59:43 +09003509}
3510
3511} // namespace a
3512} // namespace aidl
3513)";
3514
Jooyung Han1f14ab32020-10-14 13:48:29 +09003515const char kUnionExampleExpectedOutputJava[] = R"(/*
3516 * This file is auto-generated. DO NOT MODIFY.
3517 */
3518package a;
3519
3520
3521public final class Foo implements android.os.Parcelable {
Jooyung Han97945de2020-10-15 16:41:38 +09003522 // tags for union fields
3523 public final static int ns = 0; // int[] ns;
3524 public final static int e = 1; // a.ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003525 public final static int pfd = 2; // ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003526
3527 private int _tag;
3528 private Object _value;
3529
3530 public Foo() {
Jooyung Hance62f932020-10-25 10:21:49 +09003531 int[] _value = {42};
3532 this._tag = ns;
3533 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003534 }
Jooyung Han97945de2020-10-15 16:41:38 +09003535
Jooyung Han1f14ab32020-10-14 13:48:29 +09003536 private Foo(android.os.Parcel _aidl_parcel) {
3537 readFromParcel(_aidl_parcel);
3538 }
Jooyung Han97945de2020-10-15 16:41:38 +09003539
Jooyung Hance62f932020-10-25 10:21:49 +09003540 private Foo(int _tag, Object _value) {
3541 this._tag = _tag;
3542 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003543 }
3544
3545 public int getTag() {
3546 return _tag;
3547 }
3548
Jooyung Han97945de2020-10-15 16:41:38 +09003549 // int[] ns;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003550
3551 public static Foo ns(int[] _value) {
3552 return new Foo(ns, _value);
3553 }
Jooyung Han97945de2020-10-15 16:41:38 +09003554
Jooyung Han1f14ab32020-10-14 13:48:29 +09003555 public int[] getNs() {
3556 _assertTag(ns);
3557 return (int[]) _value;
3558 }
Jooyung Han97945de2020-10-15 16:41:38 +09003559
Jooyung Han1f14ab32020-10-14 13:48:29 +09003560 public void setNs(int[] _value) {
3561 _set(ns, _value);
3562 }
3563
Jooyung Han97945de2020-10-15 16:41:38 +09003564 // a.ByteEnum e;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003565
3566 public static Foo e(byte _value) {
3567 return new Foo(e, _value);
3568 }
Jooyung Han97945de2020-10-15 16:41:38 +09003569
Jooyung Han1f14ab32020-10-14 13:48:29 +09003570 public byte getE() {
3571 _assertTag(e);
3572 return (byte) _value;
3573 }
Jooyung Han97945de2020-10-15 16:41:38 +09003574
Jooyung Han1f14ab32020-10-14 13:48:29 +09003575 public void setE(byte _value) {
3576 _set(e, _value);
3577 }
3578
Jooyung Hand2fa0232020-10-19 02:51:41 +09003579 // ParcelFileDescriptor pfd;
3580
3581 public static Foo pfd(android.os.ParcelFileDescriptor _value) {
3582 return new Foo(pfd, _value);
3583 }
3584
3585 public android.os.ParcelFileDescriptor getPfd() {
3586 _assertTag(pfd);
3587 return (android.os.ParcelFileDescriptor) _value;
3588 }
3589
3590 public void setPfd(android.os.ParcelFileDescriptor _value) {
3591 _set(pfd, _value);
3592 }
3593
Jooyung Han1f14ab32020-10-14 13:48:29 +09003594 public static final android.os.Parcelable.Creator<Foo> CREATOR = new android.os.Parcelable.Creator<Foo>() {
3595 @Override
3596 public Foo createFromParcel(android.os.Parcel _aidl_source) {
Jooyung Han97945de2020-10-15 16:41:38 +09003597 return new Foo(_aidl_source);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003598 }
3599 @Override
3600 public Foo[] newArray(int _aidl_size) {
3601 return new Foo[_aidl_size];
3602 }
3603 };
Jooyung Han97945de2020-10-15 16:41:38 +09003604
Jooyung Han1f14ab32020-10-14 13:48:29 +09003605 @Override
3606 public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag) {
3607 _aidl_parcel.writeInt(_tag);
3608 switch (_tag) {
3609 case ns:
3610 _aidl_parcel.writeIntArray(getNs());
3611 break;
3612 case e:
3613 _aidl_parcel.writeByte(getE());
3614 break;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003615 case pfd:
3616 if ((getPfd()!=null)) {
3617 _aidl_parcel.writeInt(1);
3618 getPfd().writeToParcel(_aidl_parcel, 0);
3619 }
3620 else {
3621 _aidl_parcel.writeInt(0);
3622 }
3623 break;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003624 }
3625 }
Jooyung Han97945de2020-10-15 16:41:38 +09003626
Jooyung Han1f14ab32020-10-14 13:48:29 +09003627 public void readFromParcel(android.os.Parcel _aidl_parcel) {
3628 int _aidl_tag;
3629 _aidl_tag = _aidl_parcel.readInt();
3630 switch (_aidl_tag) {
3631 case ns: {
3632 int[] _aidl_value;
3633 _aidl_value = _aidl_parcel.createIntArray();
3634 _set(_aidl_tag, _aidl_value);
3635 return; }
3636 case e: {
3637 byte _aidl_value;
3638 _aidl_value = _aidl_parcel.readByte();
3639 _set(_aidl_tag, _aidl_value);
3640 return; }
Jooyung Hand2fa0232020-10-19 02:51:41 +09003641 case pfd: {
3642 android.os.ParcelFileDescriptor _aidl_value;
3643 if ((0!=_aidl_parcel.readInt())) {
3644 _aidl_value = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
3645 }
3646 else {
3647 _aidl_value = null;
3648 }
3649 _set(_aidl_tag, _aidl_value);
3650 return; }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003651 }
Jooyung Hanc453bea2020-11-21 01:00:22 +09003652 throw new IllegalArgumentException("union: unknown tag: " + _aidl_tag);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003653 }
Jooyung Han97945de2020-10-15 16:41:38 +09003654
Jooyung Han1f14ab32020-10-14 13:48:29 +09003655 @Override
3656 public int describeContents() {
Jooyung Hand2fa0232020-10-19 02:51:41 +09003657 int _mask = 0;
3658 switch (getTag()) {
3659 case pfd:
Jooyung Hanea2147c2020-10-21 18:16:56 +09003660 _mask |= describeContents(getPfd());
Jooyung Hand2fa0232020-10-19 02:51:41 +09003661 break;
3662 }
3663 return _mask;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003664 }
Jooyung Hanea2147c2020-10-21 18:16:56 +09003665 private int describeContents(Object _v) {
3666 if (_v == null) return 0;
3667 if (_v instanceof android.os.Parcelable) {
3668 return ((android.os.Parcelable) _v).describeContents();
3669 }
3670 return 0;
3671 }
Jooyung Han1f14ab32020-10-14 13:48:29 +09003672
3673 private void _assertTag(int tag) {
3674 if (getTag() != tag) {
Jooyung Hanef9b0f62020-10-14 21:52:55 +09003675 throw new IllegalStateException("bad access: " + _tagString(tag) + ", " + _tagString(getTag()) + " is available.");
Jooyung Han1f14ab32020-10-14 13:48:29 +09003676 }
3677 }
Jooyung Han97945de2020-10-15 16:41:38 +09003678
Jooyung Han1f14ab32020-10-14 13:48:29 +09003679 private String _tagString(int _tag) {
3680 switch (_tag) {
3681 case ns: return "ns";
3682 case e: return "e";
Jooyung Hand2fa0232020-10-19 02:51:41 +09003683 case pfd: return "pfd";
Jooyung Han1f14ab32020-10-14 13:48:29 +09003684 }
3685 throw new IllegalStateException("unknown field: " + _tag);
3686 }
Jooyung Han97945de2020-10-15 16:41:38 +09003687
Jooyung Hance62f932020-10-25 10:21:49 +09003688 private void _set(int _tag, Object _value) {
3689 this._tag = _tag;
3690 this._value = _value;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003691 }
3692}
3693)";
3694
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003695const char kUnionExampleExpectedOutputRust[] = R"(#[derive(Debug)]
3696pub enum Foo {
3697 Ns(Vec<i32>),
3698 E(crate::mangled::_1_a_8_ByteEnum),
3699 Pfd(Option<binder::parcel::ParcelFileDescriptor>),
3700}
3701pub(crate) mod mangled { pub use super::Foo as _1_a_3_Foo; }
3702impl Default for Foo {
3703 fn default() -> Self {
3704 Self::Ns(vec!{42})
3705 }
3706}
3707impl binder::parcel::Serialize for Foo {
3708 fn serialize(&self, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3709 <Self as binder::parcel::SerializeOption>::serialize_option(Some(self), parcel)
3710 }
3711}
3712impl binder::parcel::SerializeArray for Foo {}
3713impl binder::parcel::SerializeOption for Foo {
3714 fn serialize_option(this: Option<&Self>, parcel: &mut binder::parcel::Parcel) -> binder::Result<()> {
3715 let this = if let Some(this) = this {
3716 parcel.write(&1i32)?;
3717 this
3718 } else {
3719 return parcel.write(&0i32);
3720 };
3721 match this {
3722 Self::Ns(v) => {
3723 parcel.write(&0i32)?;
3724 parcel.write(v)
3725 }
3726 Self::E(v) => {
3727 parcel.write(&1i32)?;
3728 parcel.write(v)
3729 }
3730 Self::Pfd(v) => {
3731 parcel.write(&2i32)?;
3732 let __field_ref = v.as_ref().ok_or(binder::StatusCode::UNEXPECTED_NULL)?;
3733 parcel.write(__field_ref)
3734 }
3735 }
3736 }
3737}
3738impl binder::parcel::Deserialize for Foo {
3739 fn deserialize(parcel: &binder::parcel::Parcel) -> binder::Result<Self> {
3740 <Self as binder::parcel::DeserializeOption>::deserialize_option(parcel)
3741 .transpose()
3742 .unwrap_or(Err(binder::StatusCode::UNEXPECTED_NULL))
3743 }
3744}
3745impl binder::parcel::DeserializeArray for Foo {}
3746impl binder::parcel::DeserializeOption for Foo {
3747 fn deserialize_option(parcel: &binder::parcel::Parcel) -> binder::Result<Option<Self>> {
3748 let status: i32 = parcel.read()?;
3749 if status == 0 { return Ok(None); }
3750 let tag: i32 = parcel.read()?;
3751 match tag {
3752 0 => {
3753 let value: Vec<i32> = parcel.read()?;
3754 Ok(Some(Self::Ns(value)))
3755 }
3756 1 => {
3757 let value: crate::mangled::_1_a_8_ByteEnum = parcel.read()?;
3758 Ok(Some(Self::E(value)))
3759 }
3760 2 => {
3761 let value: Option<binder::parcel::ParcelFileDescriptor> = Some(parcel.read()?);
3762 Ok(Some(Self::Pfd(value)))
3763 }
3764 _ => {
3765 Err(binder::StatusCode::BAD_VALUE)
3766 }
3767 }
3768 }
3769}
3770)";
3771
Jooyung Han97945de2020-10-15 16:41:38 +09003772struct AidlUnionTest : ::testing::Test {
3773 void SetUp() override {
3774 io_delegate_.SetFileContents("a/Foo.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003775package a;
3776import a.ByteEnum;
3777union Foo {
3778 int[] ns = {42};
3779 ByteEnum e;
Jooyung Hand2fa0232020-10-19 02:51:41 +09003780 ParcelFileDescriptor pfd;
Jooyung Han1f14ab32020-10-14 13:48:29 +09003781}
3782)");
Jooyung Han97945de2020-10-15 16:41:38 +09003783 io_delegate_.SetFileContents("a/ByteEnum.aidl", R"(
Jooyung Han1f14ab32020-10-14 13:48:29 +09003784package a;
3785@Backing(type="byte")
3786enum ByteEnum {
3787 a, b, c
3788}
3789)");
Jooyung Han97945de2020-10-15 16:41:38 +09003790 }
3791 FakeIoDelegate io_delegate_;
3792 void Compile(string lang) {
3793 string command = "aidl --structured -I. -o out --lang=" + lang;
3794 if (lang == "cpp" || lang == "ndk") {
3795 command += " -h out";
3796 }
3797 command += " a/Foo.aidl";
3798 auto opts = Options::From(command);
Jooyung Han1f14ab32020-10-14 13:48:29 +09003799 CaptureStderr();
3800 auto ret = ::android::aidl::compile_aidl(opts, io_delegate_);
3801 auto err = GetCapturedStderr();
3802 EXPECT_EQ(0, ret) << err;
Jooyung Han97945de2020-10-15 16:41:38 +09003803 }
3804 void EXPECT_COMPILE_OUTPUTS(const map<string, string>& outputs) {
3805 for (const auto& [path, expected] : outputs) {
Jooyung Han1f14ab32020-10-14 13:48:29 +09003806 string actual;
3807 EXPECT_TRUE(io_delegate_.GetWrittenContents(path, &actual)) << path << " not found.";
3808 EXPECT_EQ(expected, actual);
3809 }
Jooyung Han97945de2020-10-15 16:41:38 +09003810 }
3811};
Jooyung Han1f14ab32020-10-14 13:48:29 +09003812
Jooyung Han97945de2020-10-15 16:41:38 +09003813TEST_F(AidlUnionTest, Example_Cpp) {
3814 Compile("cpp");
3815 EXPECT_COMPILE_OUTPUTS(
3816 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputCppSource},
3817 {"out/a/Foo.h", kUnionExampleExpectedOutputCppHeader}}));
3818}
3819
Jooyung Han6beac042020-10-17 21:59:43 +09003820TEST_F(AidlUnionTest, Example_Ndk) {
3821 Compile("ndk");
3822 EXPECT_COMPILE_OUTPUTS(
3823 map<string, string>({{"out/a/Foo.cpp", kUnionExampleExpectedOutputNdkSource},
3824 {"out/aidl/a/Foo.h", kUnionExampleExpectedOutputNdkHeader}}));
3825}
3826
Jooyung Han97945de2020-10-15 16:41:38 +09003827TEST_F(AidlUnionTest, Example_Java) {
3828 Compile("java");
3829 EXPECT_COMPILE_OUTPUTS(
3830 map<string, string>({{"out/a/Foo.java", kUnionExampleExpectedOutputJava}}));
Jooyung Hanf93b5bd2020-10-28 15:12:08 +09003831}
3832
3833TEST_F(AidlUnionTest, Example_Rust) {
3834 Compile("rust");
3835 EXPECT_COMPILE_OUTPUTS(map<string, string>({{"out/a/Foo.rs", kUnionExampleExpectedOutputRust}}));
Jooyung Han1f14ab32020-10-14 13:48:29 +09003836}
3837
Jooyung Hanfe89f122020-10-14 03:49:18 +09003838TEST_P(AidlTest, UnionRejectsEmptyDecl) {
3839 const string method = "package a; union Foo {}";
3840 const string expected_stderr = "ERROR: a/Foo.aidl:1.17-21: The union 'Foo' has no fields.\n";
3841 CaptureStderr();
3842 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3843 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3844}
3845
3846TEST_P(AidlTest, UnionRejectsParcelableHolder) {
3847 const string method = "package a; union Foo { ParcelableHolder x; }";
3848 const string expected_stderr =
3849 "ERROR: a/Foo.aidl:1.40-42: A union can't have a member of ParcelableHolder 'x'\n";
3850 CaptureStderr();
3851 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
3852 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_stderr));
3853}
3854
Jooyung Han53fb4242020-12-17 16:03:49 +09003855TEST_P(AidlTest, UnionRejectsFirstEnumWithNoDefaults) {
3856 import_paths_.insert(".");
3857 io_delegate_.SetFileContents("a/Enum.aidl", "package a; enum Enum { FOO, BAR }");
3858 const string expected_err = "The union's first member should have a useful default value.";
3859 CaptureStderr();
3860 EXPECT_EQ(nullptr,
3861 Parse("a/Foo.aidl", "package a; union Foo { a.Enum e; }", typenames_, GetLanguage()));
3862 EXPECT_THAT(GetCapturedStderr(), testing::HasSubstr(expected_err));
3863}
3864
Devin Moore53fc99c2020-08-12 08:07:52 -07003865TEST_P(AidlTest, GenericStructuredParcelable) {
3866 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
3867 Options options =
3868 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
3869 const string expected_stderr = "";
3870 CaptureStderr();
3871 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3872 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3873}
3874
Jooyung Han3f347ca2020-12-01 12:41:50 +09003875TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Cpp) {
3876 io_delegate_.SetFileContents("Foo.aidl",
3877 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3878 Options options =
3879 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::CPP) +
3880 " -o out -h out");
3881 const string expected_stderr = "";
3882 CaptureStderr();
3883 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3884 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3885
3886 string code;
3887 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3888 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3889const ::android::String16& Foo<T,U>::s() {
3890 static const ::android::String16 value(::android::String16(""));
3891 return value;
3892})--"));
3893}
3894
3895TEST_F(AidlTest, GenericStructuredParcelableWithStringConstants_Ndk) {
3896 io_delegate_.SetFileContents("Foo.aidl",
3897 "parcelable Foo<T, U> { int a; const String s = \"\"; }");
3898 Options options =
3899 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(Options::Language::NDK) +
3900 " -o out -h out");
3901 const string expected_stderr = "";
3902 CaptureStderr();
3903 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3904 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3905
3906 string code;
3907 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3908 EXPECT_THAT(code, testing::HasSubstr(R"--(template <typename T, typename U>
3909const char* Foo<T, U>::s = "";
3910)--"));
3911}
3912
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003913TEST_F(AidlTest, NestedTypeArgs) {
3914 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<A> { }");
Steven Moreland6c07b832020-10-29 23:39:53 +00003915 io_delegate_.SetFileContents("a/Baz.aidl", "package a; parcelable Baz<A, B> { }");
3916
3917 io_delegate_.SetFileContents("a/Foo.aidl",
3918 "package a; import a.Bar; import a.Baz; parcelable Foo { "
3919 "Baz<Bar<Bar<String[]>>[], Bar<String>> barss; }");
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003920 Options options = Options::From("aidl a/Foo.aidl -I . -o out --lang=java");
3921 const string expected_stderr = "";
3922 CaptureStderr();
3923 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3924 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3925
3926 string code;
3927 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.java", &code));
Steven Moreland6c07b832020-10-29 23:39:53 +00003928 EXPECT_THAT(code,
3929 testing::HasSubstr(
3930 "a.Baz<a.Bar<a.Bar<java.lang.String[]>>[],a.Bar<java.lang.String>> barss;"));
3931}
3932
3933TEST_F(AidlTest, DoubleArrayError) {
3934 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { String[][] a; }");
3935
3936 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3937 const string expected_stderr =
3938 "ERROR: a/Bar.aidl:1.28-37: Can only have one dimensional arrays.\n";
3939 CaptureStderr();
3940 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3941 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3942}
3943
3944TEST_F(AidlTest, DoubleGenericError) {
3945 io_delegate_.SetFileContents("a/Bar.aidl",
3946 "package a; parcelable Bar { List<String><String> a; }");
3947
3948 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3949 const string expected_stderr =
3950 "ERROR: a/Bar.aidl:1.28-33: Can only specify one set of type parameters.\n";
3951 CaptureStderr();
3952 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3953 EXPECT_EQ(expected_stderr, GetCapturedStderr());
3954}
3955
3956TEST_F(AidlTest, ArrayBeforeGenericError) {
3957 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar { List[]<String> a; }");
3958
3959 Options options = Options::From("aidl a/Bar.aidl -I . -o out --lang=java");
3960 const string expected_stderr =
3961 "ERROR: a/Bar.aidl:1.28-33: Must specify type parameters (<>) before array ([]).\n";
3962 CaptureStderr();
3963 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
3964 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jooyung Han8c9a4e12020-10-26 15:39:54 +09003965}
3966
Jooyung Han14004ed2020-10-16 03:49:57 +09003967struct GenericAidlTest : ::testing::Test {
3968 FakeIoDelegate io_delegate_;
3969 void Compile(string cmd) {
Steven Moreland6c07b832020-10-29 23:39:53 +00003970 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo { Bar<Baz<Qux>> x; }");
Jooyung Han14004ed2020-10-16 03:49:57 +09003971 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar<T> { }");
3972 io_delegate_.SetFileContents("Baz.aidl", "parcelable Baz<T> { }");
3973 io_delegate_.SetFileContents("Qux.aidl", "parcelable Qux { }");
3974
3975 Options options = Options::From(cmd);
3976 CaptureStderr();
3977 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
3978 EXPECT_EQ("", GetCapturedStderr());
3979 }
3980};
3981
3982TEST_F(GenericAidlTest, ImportGenericParameterTypesCPP) {
3983 Compile("aidl Foo.aidl --lang=cpp -I . -o out -h out");
3984 string code;
3985 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/Foo.h", &code));
3986 EXPECT_THAT(code, testing::HasSubstr("#include <Bar.h>"));
3987 EXPECT_THAT(code, testing::HasSubstr("#include <Baz.h>"));
3988 EXPECT_THAT(code, testing::HasSubstr("#include <Qux.h>"));
3989}
3990
3991TEST_F(GenericAidlTest, ImportGenericParameterTypesNDK) {
3992 Compile("aidl Foo.aidl --lang=ndk -I . -o out -h out");
3993 string code;
3994 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/Foo.h", &code));
3995 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Bar.h>"));
3996 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Baz.h>"));
3997 EXPECT_THAT(code, testing::HasSubstr("#include <aidl/Qux.h>"));
3998}
3999
Devin Moore53fc99c2020-08-12 08:07:52 -07004000TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
4001 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
4002 Options options =
4003 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4004 const string expected_stderr =
4005 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
4006 CaptureStderr();
4007 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4008 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4009}
4010
4011TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
4012 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
4013 Options options =
4014 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4015 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
4016 CaptureStderr();
4017 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4018 EXPECT_EQ(expected_stderr, GetCapturedStderr());
4019}
4020
Jooyung Han7a308842020-10-27 19:06:49 +09004021TEST_P(AidlTest, LongCommentWithinConstExpression) {
4022 io_delegate_.SetFileContents("Foo.aidl", "enum Foo { FOO = (1 << 1) /* comment */ | 0x0 }");
4023 Options options =
4024 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
4025 CaptureStderr();
4026 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
4027 EXPECT_EQ("", GetCapturedStderr());
4028}
4029
Jeongik Chaef44e622020-10-23 16:00:52 +09004030TEST_F(AidlTest, RejectUntypdeListAndMapInUnion) {
4031 io_delegate_.SetFileContents("a/Foo.aidl", "package a; union Foo { List l; Map m; }");
4032 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
4033 std::string expectedErr =
4034 "ERROR: a/Foo.aidl:1.28-30: "
4035 "Encountered an untyped List or Map. The use of untyped List/Map is "
4036 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4037 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4038 "ERROR: a/Foo.aidl:1.35-37: "
4039 "Encountered an untyped List or Map. The use of untyped List/Map is "
4040 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4041 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4042 CaptureStderr();
4043 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4044 EXPECT_EQ(expectedErr, GetCapturedStderr());
4045}
4046
4047TEST_F(AidlTest, RejectUntypdeListAndMapInUnstructuredParcelable) {
Jooyung Hanea2147c2020-10-21 18:16:56 +09004048 io_delegate_.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { List l; Map m; }");
4049 Options options = Options::From("aidl a/Foo.aidl --lang=java -o out");
Jeongik Chaef44e622020-10-23 16:00:52 +09004050 std::string expectedErr =
4051 "ERROR: a/Foo.aidl:1.33-35: "
4052 "Encountered an untyped List or Map. The use of untyped List/Map is "
4053 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4054 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4055 "ERROR: a/Foo.aidl:1.40-42: "
4056 "Encountered an untyped List or Map. The use of untyped List/Map is "
4057 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4058 "the receiving side. Consider switching to an array or a generic List/Map.\n";
Jooyung Hanea2147c2020-10-21 18:16:56 +09004059 CaptureStderr();
Jeongik Chaef44e622020-10-23 16:00:52 +09004060 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4061 EXPECT_EQ(expectedErr, GetCapturedStderr());
4062}
Jooyung Hanea2147c2020-10-21 18:16:56 +09004063
Jeongik Chaef44e622020-10-23 16:00:52 +09004064TEST_F(AidlTest, RejectNestedUntypedListAndMap) {
4065 io_delegate_.SetFileContents("a/Bar.aidl", "package a; parcelable Bar<T>;");
4066 io_delegate_.SetFileContents(
4067 "a/Foo.aidl", "package a; import a.Bar; parcelable Foo { Bar<List> a; Bar<Map> b; }");
4068 Options options = Options::From("aidl a/Foo.aidl -I . --lang=java -o out");
4069 std::string expectedErr =
4070 "ERROR: a/Foo.aidl:1.52-54: "
4071 "Encountered an untyped List or Map. The use of untyped List/Map is "
4072 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4073 "the receiving side. Consider switching to an array or a generic List/Map.\n"
4074 "ERROR: a/Foo.aidl:1.64-66: "
4075 "Encountered an untyped List or Map. The use of untyped List/Map is "
4076 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
4077 "the receiving side. Consider switching to an array or a generic List/Map.\n";
4078 CaptureStderr();
4079 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
4080 EXPECT_EQ(expectedErr, GetCapturedStderr());
Jooyung Hanea2147c2020-10-21 18:16:56 +09004081}
4082
Jooyung Han690f5842020-12-04 13:02:04 +09004083TEST_F(AidlTest, EnumWithDefaults_Java) {
4084 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4085 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4086package p;
4087import p.Enum;
4088parcelable Foo {
4089 Enum e = Enum.BAR;
4090})");
4091 CaptureStderr();
4092 auto options = Options::From("aidl -I a --lang java -o out a/p/Foo.aidl");
4093 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4094 auto err = GetCapturedStderr();
4095 EXPECT_EQ("", err);
4096
4097 string code;
4098 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.java", &code));
Jooyung Han2d833612020-12-17 15:59:27 +09004099 EXPECT_THAT(code, testing::HasSubstr("byte e = p.Enum.BAR"));
Jooyung Han690f5842020-12-04 13:02:04 +09004100}
4101
4102TEST_F(AidlTest, EnumWithDefaults_Cpp) {
4103 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4104 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4105package p;
4106import p.Enum;
4107parcelable Foo {
4108 Enum e = Enum.BAR;
4109})");
4110 CaptureStderr();
4111 auto options = Options::From("aidl -I a --lang cpp -o out -h out a/p/Foo.aidl");
4112 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4113 auto err = GetCapturedStderr();
4114 EXPECT_EQ("", err);
4115
4116 string code;
4117 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.h", &code));
4118 EXPECT_THAT(code, testing::HasSubstr("::p::Enum e = ::p::Enum(::p::Enum::BAR);"));
4119}
4120
4121TEST_F(AidlTest, EnumWithDefaults_Ndk) {
4122 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4123 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4124package p;
4125import p.Enum;
4126parcelable Foo {
4127 Enum e = Enum.BAR;
4128})");
4129 CaptureStderr();
4130 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4131 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4132 auto err = GetCapturedStderr();
4133 EXPECT_EQ("", err);
4134
4135 string code;
4136 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4137 EXPECT_THAT(code, testing::HasSubstr("::aidl::p::Enum e = ::aidl::p::Enum::BAR;"));
4138}
4139
4140TEST_F(AidlTest, EnumWithDefaults_Rust) {
4141 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO, BAR }");
4142 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4143package p;
4144import p.Enum;
4145parcelable Foo {
4146 int n = 42;
4147 Enum e = Enum.BAR;
4148})");
4149 CaptureStderr();
4150 auto options = Options::From("aidl -I a --lang rust -o out -h out a/p/Foo.aidl");
4151 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4152 auto err = GetCapturedStderr();
4153 EXPECT_EQ("", err);
4154
4155 string code;
4156 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/p/Foo.rs", &code));
4157 EXPECT_THAT(code, testing::HasSubstr(R"(
4158 fn default() -> Self {
4159 Self {
4160 n: 42,
4161 e: crate::mangled::_1_p_4_Enum::BAR,
4162 }
4163 })"));
4164}
4165
4166TEST_P(AidlTest, EnumeratorIsConstantValue_DefaultValue) {
4167 import_paths_.insert("a");
4168 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4169 CaptureStderr();
4170 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4171package p;
4172import p.Enum;
4173parcelable Foo {
4174 int e = Enum.FOO | Enum.BAR;
4175})",
4176 typenames_, GetLanguage());
4177 auto err = GetCapturedStderr();
4178 EXPECT_EQ("", err);
4179 EXPECT_TRUE(type);
4180 const auto& fields = type->AsStructuredParcelable()->GetFields();
4181 EXPECT_EQ("int e = 3", fields[0]->ToString());
4182}
4183
4184TEST_P(AidlTest, EnumeratorIsConstantValue_CanDefineOtherEnumerator) {
4185 CaptureStderr();
4186 const AidlDefinedType* type = Parse("a/p/Foo.aidl", R"(
4187@Backing(type="int")
4188enum Foo {
4189 STANDARD_SHIFT = 16,
4190 STANDARD_BT709 = 1 << STANDARD_SHIFT,
4191 STANDARD_BT601_625 = 2 << STANDARD_SHIFT,
4192}
4193)",
4194 typenames_, GetLanguage());
4195 auto err = GetCapturedStderr();
4196 EXPECT_EQ("", err);
4197 EXPECT_TRUE(type);
4198 const auto& enum_type = type->AsEnumDeclaration();
4199 string code;
4200 enum_type->Dump(CodeWriter::ForString(&code).get());
4201 EXPECT_EQ(R"--(@Backing(type="int")
4202enum Foo {
4203 STANDARD_SHIFT = 16,
4204 STANDARD_BT709 = 65536,
4205 STANDARD_BT601_625 = 131072,
4206}
4207)--",
4208 code);
4209}
4210
4211TEST_F(AidlTest, EnumDefaultShouldBeEnumerators) {
4212 io_delegate_.SetFileContents("a/p/Enum.aidl", "package p; enum Enum { FOO = 1, BAR = 2}");
4213 io_delegate_.SetFileContents("a/p/Foo.aidl", R"(
4214package p;
4215import p.Enum;
4216parcelable Foo {
4217 Enum e = Enum.FOO | Enum.BAR;
4218})");
4219 CaptureStderr();
4220 auto options = Options::From("aidl -I a --lang java -o out -h out a/p/Foo.aidl");
4221 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4222 auto err = GetCapturedStderr();
4223 EXPECT_EQ("ERROR: a/p/Foo.aidl:5.11-20: Invalid value (Enum.FOO|Enum.BAR) for enum p.Enum\n",
4224 err);
4225}
4226
4227TEST_P(AidlTest, DefaultWithEmptyArray) {
4228 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; parcelable Foo { p.Bar[] bars = {}; }");
4229 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; parcelable Bar { }");
4230 CaptureStderr();
4231 auto options = Options::From("aidl -I a --lang " + Options::LanguageToString(GetLanguage()) +
4232 " -o out -h out a/p/Foo.aidl");
4233 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4234 auto err = GetCapturedStderr();
4235 EXPECT_EQ("", err);
4236}
4237
4238TEST_P(AidlTest, RejectRefsInAnnotation) {
4239 io_delegate_.SetFileContents("a/p/IFoo.aidl",
4240 "package p; interface IFoo {\n"
4241 " const String ANNOTATION = \"@Annotation\";\n"
4242 " @JavaPassthrough(annotation=ANNOTATION) void foo();\n"
4243 "}");
4244 CaptureStderr();
4245 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4246 " -o out -h out a/p/IFoo.aidl");
4247 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4248 auto err = GetCapturedStderr();
4249 EXPECT_EQ(
4250 "ERROR: a/p/IFoo.aidl:3.31-41: Value must be a constant expression but contains reference to "
4251 "ANNOTATION.\n",
4252 err);
4253}
4254
4255TEST_F(AidlTest, DefaultWithEnumValues) {
4256 io_delegate_.SetFileContents(
4257 "a/p/Foo.aidl",
4258 "package p; import p.Bar; parcelable Foo { Bar[] bars = { Bar.FOO, Bar.FOO }; }");
4259 io_delegate_.SetFileContents("a/p/Bar.aidl", "package p; enum Bar { FOO, BAR }");
4260 CaptureStderr();
4261 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4262 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4263 auto err = GetCapturedStderr();
4264 EXPECT_EQ("", err);
4265 string code;
4266 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/aidl/p/Foo.h", &code));
4267 EXPECT_THAT(
4268 code, testing::HasSubstr(
4269 "std::vector<::aidl::p::Bar> bars = {::aidl::p::Bar::FOO, ::aidl::p::Bar::FOO};"));
4270}
4271
Jooyung Han14259392020-12-07 10:00:08 +09004272TEST_F(AidlTest, RejectsCircularReferencingEnumerators) {
4273 io_delegate_.SetFileContents("a/p/Foo.aidl", "package p; enum Foo { A = B, B }");
4274 CaptureStderr();
4275 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4276 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4277 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004278 EXPECT_EQ(
4279 "ERROR: a/p/Foo.aidl:1.26-28: Found a circular reference: B -> A -> B\n"
4280 "ERROR: a/p/Foo.aidl:1.29-31: Found a circular reference: A -> B -> A\n",
4281 err);
Jooyung Han14259392020-12-07 10:00:08 +09004282}
4283
4284TEST_F(AidlTest, RejectsCircularReferencingConsts) {
4285 io_delegate_.SetFileContents("a/p/Foo.aidl",
4286 "package p; parcelable Foo { const int A = A + 1; }");
4287 CaptureStderr();
4288 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4289 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4290 auto err = GetCapturedStderr();
Jooyung Han29813842020-12-08 01:28:03 +09004291 EXPECT_EQ("ERROR: a/p/Foo.aidl:1.42-44: Found a circular reference: A -> A\n", err);
4292}
4293
4294TEST_F(AidlTest, RecursiveReferences) {
4295 io_delegate_.SetFileContents("a/p/Foo.aidl",
4296 "package p; parcelable Foo { const int A = p.Bar.A + 1; }");
4297 io_delegate_.SetFileContents("a/p/Bar.aidl",
4298 "package p; parcelable Bar { const int A = p.Baz.A + 1; }");
4299 io_delegate_.SetFileContents("a/p/Baz.aidl", "package p; parcelable Baz { const int A = 1; }");
4300 CaptureStderr();
4301 auto options = Options::From("aidl -I a --lang ndk -o out -h out a/p/Foo.aidl");
4302 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4303 EXPECT_EQ("", GetCapturedStderr());
4304}
4305
4306TEST_P(AidlTest, JavaCompatibleBuiltinTypes) {
4307 string contents = R"(
4308import android.os.IBinder;
4309import android.os.IInterface;
4310interface IFoo {}
4311 )";
4312 EXPECT_NE(nullptr, Parse("IFoo.aidl", contents, typenames_, GetLanguage()));
Jooyung Han14259392020-12-07 10:00:08 +09004313}
4314
Jooyung Han888c5bc2020-12-22 17:28:47 +09004315TEST_P(AidlTest, WarningInterfaceName) {
4316 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
4317 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4318 " -Weverything -o out -h out p/Foo.aidl");
4319 CaptureStderr();
4320 EXPECT_EQ(0, aidl::compile_aidl(options, io_delegate_));
4321 EXPECT_EQ("WARNING: p/Foo.aidl:1.1-10: Interface names should start with I.\n",
4322 GetCapturedStderr());
4323}
4324
4325TEST_P(AidlTest, ErrorInterfaceName) {
4326 io_delegate_.SetFileContents("p/Foo.aidl", "interface Foo {}");
4327 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4328 " -Weverything -Werror -o out -h out p/Foo.aidl");
4329 CaptureStderr();
4330 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4331 EXPECT_EQ("ERROR: p/Foo.aidl:1.1-10: Interface names should start with I.\n",
4332 GetCapturedStderr());
4333}
4334
Jooyung Han3b990182020-12-22 17:44:31 +09004335TEST_P(AidlTest, ErrorEnumZero) {
4336 io_delegate_.SetFileContents("p/Foo.aidl", "enum Foo { FOO = 1 }");
4337 auto options = Options::From("aidl --lang " + Options::LanguageToString(GetLanguage()) +
4338 " -Weverything -Werror -o out -h out p/Foo.aidl");
4339 CaptureStderr();
4340 EXPECT_EQ(1, aidl::compile_aidl(options, io_delegate_));
4341 EXPECT_EQ("ERROR: p/Foo.aidl:1.11-15: The first enumerator 'FOO' should be 0, but it is 1.\n",
4342 GetCapturedStderr());
4343}
4344
Jooyung Hanfd3be322020-12-13 09:11:06 +09004345struct TypeParam {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004346 string kind;
4347 string literal;
4348};
4349
Jooyung Hanfd3be322020-12-13 09:11:06 +09004350const TypeParam kTypeParams[] = {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004351 {"primitive", "int"}, {"String", "String"},
4352 {"IBinder", "IBinder"}, {"ParcelFileDescriptor", "ParcelFileDescriptor"},
4353 {"parcelable", "Foo"}, {"enum", "a.Enum"},
4354 {"union", "a.Union"}, {"interface", "a.IBar"},
4355};
4356
4357const std::map<std::string, std::string> kListSupportExpectations = {
4358 {"cpp_primitive", "A generic type cannot have any primitive type parameters."},
4359 {"java_primitive", "A generic type cannot have any primitive type parameters."},
4360 {"ndk_primitive", "A generic type cannot have any primitive type parameters."},
4361 {"rust_primitive", "A generic type cannot have any primitive type parameters."},
4362 {"cpp_String", ""},
4363 {"java_String", ""},
4364 {"ndk_String", ""},
4365 {"rust_String", ""},
4366 {"cpp_IBinder", ""},
4367 {"java_IBinder", ""},
4368 {"ndk_IBinder", "List<IBinder> is not supported. List in NDK doesn't support IBinder."},
4369 {"rust_IBinder", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004370 {"cpp_ParcelFileDescriptor", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004371 {"java_ParcelFileDescriptor", ""},
4372 {"ndk_ParcelFileDescriptor", ""},
4373 {"rust_ParcelFileDescriptor", ""},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004374 {"cpp_interface", "List<a.IBar> is not supported."},
4375 {"java_interface", "List<a.IBar> is not supported."},
4376 {"ndk_interface", "List<a.IBar> is not supported."},
4377 {"rust_interface", "List<a.IBar> is not supported."},
4378 {"cpp_parcelable", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004379 {"java_parcelable", ""},
4380 {"ndk_parcelable", ""},
4381 {"rust_parcelable", ""},
4382 {"cpp_enum", "A generic type cannot have any primitive type parameters."},
4383 {"java_enum", "A generic type cannot have any primitive type parameters."},
4384 {"ndk_enum", "A generic type cannot have any primitive type parameters."},
4385 {"rust_enum", "A generic type cannot have any primitive type parameters."},
Jooyung Han55f96ad2020-12-13 10:08:33 +09004386 {"cpp_union", ""},
Jooyung Hane87cdd02020-12-11 16:47:35 +09004387 {"java_union", ""},
4388 {"ndk_union", ""},
4389 {"rust_union", ""},
4390};
4391
Jooyung Hand236e552020-12-13 09:21:27 +09004392const std::map<std::string, std::string> kArraySupportExpectations = {
4393 {"cpp_primitive", ""},
4394 {"java_primitive", ""},
4395 {"ndk_primitive", ""},
4396 {"rust_primitive", ""},
4397 {"cpp_String", ""},
4398 {"java_String", ""},
4399 {"ndk_String", ""},
4400 {"rust_String", ""},
4401 {"cpp_IBinder", ""},
4402 {"java_IBinder", ""},
4403 {"ndk_IBinder", "The ndk backend does not support array of IBinder"},
4404 {"rust_IBinder", "The rust backend does not support array of IBinder"},
4405 {"cpp_ParcelFileDescriptor", ""},
4406 {"java_ParcelFileDescriptor", ""},
4407 {"ndk_ParcelFileDescriptor", ""},
4408 {"rust_ParcelFileDescriptor", ""},
4409 {"cpp_interface", "Binder type cannot be an array"},
4410 {"java_interface", "Binder type cannot be an array"},
4411 {"ndk_interface", "Binder type cannot be an array"},
4412 {"rust_interface", "Binder type cannot be an array"},
4413 {"cpp_parcelable", ""},
4414 {"java_parcelable", ""},
4415 {"ndk_parcelable", ""},
4416 {"rust_parcelable", ""},
4417 {"cpp_enum", ""},
4418 {"java_enum", ""},
4419 {"ndk_enum", ""},
4420 {"rust_enum", ""},
4421 {"cpp_union", ""},
4422 {"java_union", ""},
4423 {"ndk_union", ""},
4424 {"rust_union", ""},
4425};
4426
Jooyung Hanfd3be322020-12-13 09:11:06 +09004427class AidlTypeParamTest : public testing::TestWithParam<std::tuple<Options::Language, TypeParam>> {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004428 public:
Jooyung Hanfd3be322020-12-13 09:11:06 +09004429 void Run(const std::string& generic_type_decl,
4430 const std::map<std::string, std::string>& expectations) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004431 const auto& param = GetParam();
4432 const auto& lang = Options::LanguageToString(std::get<0>(param));
4433 const auto& kind = std::get<1>(param).kind;
4434
4435 FakeIoDelegate io;
4436 io.SetFileContents("a/IBar.aidl", "package a; interface IBar { }");
4437 io.SetFileContents("a/Enum.aidl", "package a; enum Enum { A }");
4438 io.SetFileContents("a/Union.aidl", "package a; union Union { int a; }");
Jooyung Hanfd3be322020-12-13 09:11:06 +09004439 std::string decl = fmt::format(generic_type_decl, std::get<1>(param).literal);
4440 io.SetFileContents("a/Foo.aidl", "package a; parcelable Foo { " + decl + " f; }");
Jooyung Hane87cdd02020-12-11 16:47:35 +09004441
4442 const auto options =
4443 Options::From(fmt::format("aidl -I . --lang={} a/Foo.aidl -o out -h out", lang));
4444 CaptureStderr();
4445 compile_aidl(options, io);
Jooyung Hanfd3be322020-12-13 09:11:06 +09004446 auto it = expectations.find(lang + "_" + kind);
4447 EXPECT_TRUE(it != expectations.end());
Jooyung Hane87cdd02020-12-11 16:47:35 +09004448 const string err = GetCapturedStderr();
4449 if (it->second.empty()) {
4450 EXPECT_EQ("", err);
4451 } else {
4452 EXPECT_THAT(err, testing::HasSubstr(it->second));
4453 }
4454 }
4455};
4456
4457INSTANTIATE_TEST_SUITE_P(
Jooyung Hanfd3be322020-12-13 09:11:06 +09004458 AidlTestSuite, AidlTypeParamTest,
Jooyung Hane87cdd02020-12-11 16:47:35 +09004459 testing::Combine(testing::Values(Options::Language::CPP, Options::Language::JAVA,
4460 Options::Language::NDK, Options::Language::RUST),
Jooyung Hanfd3be322020-12-13 09:11:06 +09004461 testing::ValuesIn(kTypeParams)),
4462 [](const testing::TestParamInfo<std::tuple<Options::Language, TypeParam>>& info) {
Jooyung Hane87cdd02020-12-11 16:47:35 +09004463 return Options::LanguageToString(std::get<0>(info.param)) + "_" +
4464 std::get<1>(info.param).kind;
4465 });
4466
Jooyung Hanfd3be322020-12-13 09:11:06 +09004467TEST_P(AidlTypeParamTest, ListSupportedTypes) {
4468 Run("List<{}>", kListSupportExpectations);
4469}
Jooyung Hane87cdd02020-12-11 16:47:35 +09004470
Jooyung Hand236e552020-12-13 09:21:27 +09004471TEST_P(AidlTypeParamTest, ArraySupportedTypes) {
4472 Run("{}[]", kArraySupportExpectations);
4473}
4474
Christopher Wiley90be4e32015-10-20 14:55:25 -07004475} // namespace aidl
4476} // namespace android