blob: 00a1a76793f90e19601ca33d229e469a620752bf [file] [log] [blame]
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001//
2// Copyright 2016 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6// FramebufferVk.cpp:
7// Implements the class methods for FramebufferVk.
8//
9
10#include "libANGLE/renderer/vulkan/FramebufferVk.h"
11
Jamie Madill7b57b9d2017-01-13 09:33:38 -050012#include <vulkan/vulkan.h>
Jamie Madill231c7f52017-04-26 13:45:37 -040013#include <array>
Jamie Madill7b57b9d2017-01-13 09:33:38 -050014
Jamie Madill9e54b5a2016-05-25 12:57:39 -040015#include "common/debug.h"
Jamie Madillc564c072017-06-01 12:45:42 -040016#include "libANGLE/Context.h"
17#include "libANGLE/Display.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050018#include "libANGLE/formatutils.h"
19#include "libANGLE/renderer/renderer_utils.h"
Jamie Madill1f46bc12018-02-20 16:09:43 -050020#include "libANGLE/renderer/vulkan/CommandGraph.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050021#include "libANGLE/renderer/vulkan/ContextVk.h"
Jamie Madill5deea722017-02-16 10:44:46 -050022#include "libANGLE/renderer/vulkan/DisplayVk.h"
Jamie Madill7b57b9d2017-01-13 09:33:38 -050023#include "libANGLE/renderer/vulkan/RenderTargetVk.h"
24#include "libANGLE/renderer/vulkan/RendererVk.h"
25#include "libANGLE/renderer/vulkan/SurfaceVk.h"
Jamie Madill3c424b42018-01-19 12:35:09 -050026#include "libANGLE/renderer/vulkan/vk_format_utils.h"
Tobin Ehlis4a419142019-02-05 08:50:30 -070027#include "third_party/trace_event/trace_event.h"
Jamie Madill9e54b5a2016-05-25 12:57:39 -040028
29namespace rx
30{
31
Jamie Madill7b57b9d2017-01-13 09:33:38 -050032namespace
33{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -040034// The value to assign an alpha channel that's emulated. The type is unsigned int, though it will
35// automatically convert to the actual data type.
36constexpr unsigned int kEmulatedAlphaValue = 1;
37
Luc Ferron534b00d2018-05-18 08:16:53 -040038constexpr size_t kMinReadPixelsBufferSize = 128000;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -040039// Clear values are only used when loadOp=Clear is set in clearWithRenderPassOp. When starting a
40// new render pass, the clear value is set to an unlikely value (bright pink) to stand out better
41// in case of a bug.
42constexpr VkClearValue kUninitializedClearValue = {{{0.95, 0.05, 0.95, 0.95}}};
Luc Ferron534b00d2018-05-18 08:16:53 -040043
Jamie Madill66546be2018-03-08 09:47:20 -050044const gl::InternalFormat &GetReadAttachmentInfo(const gl::Context *context,
45 RenderTargetVk *renderTarget)
Jamie Madill7b57b9d2017-01-13 09:33:38 -050046{
Jamie Madillbc543422018-03-30 10:43:19 -040047 GLenum implFormat =
Jamie Madillbcf467f2018-05-23 09:46:00 -040048 renderTarget->getImageFormat().textureFormat().fboImplementationInternalFormat;
Jamie Madill66546be2018-03-08 09:47:20 -050049 return gl::GetSizedInternalFormatInfo(implFormat);
Jamie Madill7b57b9d2017-01-13 09:33:38 -050050}
Luc Ferron26581112018-06-21 09:43:08 -040051
Jamie Madilld754eb52018-07-19 14:55:03 -040052bool ClipToRenderTarget(const gl::Rectangle &area,
53 RenderTargetVk *renderTarget,
54 gl::Rectangle *rectOut)
55{
Shahbaz Youssefi68549402019-03-25 23:30:49 -040056 const gl::Extents renderTargetExtents = renderTarget->getExtents();
Jamie Madilld754eb52018-07-19 14:55:03 -040057 gl::Rectangle renderTargetRect(0, 0, renderTargetExtents.width, renderTargetExtents.height);
58 return ClipRectangle(area, renderTargetRect, rectOut);
59}
60
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050061bool HasSrcAndDstBlitProperties(RendererVk *renderer,
Luc Ferron26581112018-06-21 09:43:08 -040062 RenderTargetVk *srcRenderTarget,
63 RenderTargetVk *dstRenderTarget)
64{
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050065 const VkFormat srcFormat = srcRenderTarget->getImageFormat().vkTextureFormat;
66 const VkFormat dstFormat = dstRenderTarget->getImageFormat().vkTextureFormat;
Luc Ferron26581112018-06-21 09:43:08 -040067
68 // Verifies if the draw and read images have the necessary prerequisites for blitting.
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -050069 return renderer->hasTextureFormatFeatureBits(srcFormat, VK_FORMAT_FEATURE_BLIT_SRC_BIT) &&
70 renderer->hasTextureFormatFeatureBits(dstFormat, VK_FORMAT_FEATURE_BLIT_DST_BIT);
Luc Ferron26581112018-06-21 09:43:08 -040071}
Jamie Madillb436aac2018-07-18 17:23:48 -040072
73// Special rules apply to VkBufferImageCopy with depth/stencil. The components are tightly packed
74// into a depth or stencil section of the destination buffer. See the spec:
75// https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkBufferImageCopy.html
76const angle::Format &GetDepthStencilImageToBufferFormat(const angle::Format &imageFormat,
77 VkImageAspectFlagBits copyAspect)
78{
79 if (copyAspect == VK_IMAGE_ASPECT_STENCIL_BIT)
80 {
81 ASSERT(imageFormat.id == angle::FormatID::D24_UNORM_S8_UINT ||
82 imageFormat.id == angle::FormatID::D32_FLOAT_S8X24_UINT ||
83 imageFormat.id == angle::FormatID::S8_UINT);
84 return angle::Format::Get(angle::FormatID::S8_UINT);
85 }
86
87 ASSERT(copyAspect == VK_IMAGE_ASPECT_DEPTH_BIT);
88
89 switch (imageFormat.id)
90 {
91 case angle::FormatID::D16_UNORM:
92 return imageFormat;
93 case angle::FormatID::D24_UNORM_X8_UINT:
94 return imageFormat;
95 case angle::FormatID::D24_UNORM_S8_UINT:
96 return angle::Format::Get(angle::FormatID::D24_UNORM_X8_UINT);
97 case angle::FormatID::D32_FLOAT:
98 return imageFormat;
99 case angle::FormatID::D32_FLOAT_S8X24_UINT:
100 return angle::Format::Get(angle::FormatID::D32_FLOAT);
101 default:
102 UNREACHABLE();
103 return imageFormat;
104 }
105}
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400106
107void SetEmulatedAlphaValue(const vk::Format &format, VkClearColorValue *value)
108{
109 if (format.vkFormatIsInt)
110 {
111 if (format.vkFormatIsUnsigned)
112 {
113 value->uint32[3] = kEmulatedAlphaValue;
114 }
115 else
116 {
117 value->int32[3] = kEmulatedAlphaValue;
118 }
119 }
120 else
121 {
122 value->float32[3] = kEmulatedAlphaValue;
123 }
124}
Jamie Madillbcf467f2018-05-23 09:46:00 -0400125} // anonymous namespace
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500126
127// static
Jamie Madill639bc902018-07-18 17:08:27 -0400128FramebufferVk *FramebufferVk::CreateUserFBO(RendererVk *renderer, const gl::FramebufferState &state)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500129{
Jamie Madill639bc902018-07-18 17:08:27 -0400130 return new FramebufferVk(renderer, state, nullptr);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500131}
132
133// static
Jamie Madill639bc902018-07-18 17:08:27 -0400134FramebufferVk *FramebufferVk::CreateDefaultFBO(RendererVk *renderer,
135 const gl::FramebufferState &state,
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500136 WindowSurfaceVk *backbuffer)
137{
Jamie Madill639bc902018-07-18 17:08:27 -0400138 return new FramebufferVk(renderer, state, backbuffer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500139}
140
Jamie Madill639bc902018-07-18 17:08:27 -0400141FramebufferVk::FramebufferVk(RendererVk *renderer,
142 const gl::FramebufferState &state,
143 WindowSurfaceVk *backbuffer)
Jamie Madill9aef3672018-04-27 11:45:06 -0400144 : FramebufferImpl(state),
145 mBackbuffer(backbuffer),
Jamie Madill9aef3672018-04-27 11:45:06 -0400146 mActiveColorComponents(0),
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -0500147 mReadPixelBuffer(VK_BUFFER_USAGE_TRANSFER_DST_BIT, kMinReadPixelsBufferSize, true),
148 mBlitPixelBuffer(VK_BUFFER_USAGE_TRANSFER_SRC_BIT, kMinReadPixelsBufferSize, true)
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500149{
Jamie Madill639bc902018-07-18 17:08:27 -0400150 mBlitPixelBuffer.init(1, renderer);
Frank Henigman49b0f6e2018-10-03 23:15:29 -0400151 mReadPixelBuffer.init(4, renderer);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500152}
153
Jamie Madill58675012018-05-22 14:54:07 -0400154FramebufferVk::~FramebufferVk() = default;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400155
Jamie Madillc564c072017-06-01 12:45:42 -0400156void FramebufferVk::destroy(const gl::Context *context)
Jamie Madill5deea722017-02-16 10:44:46 -0500157{
Luc Ferron534b00d2018-05-18 08:16:53 -0400158 ContextVk *contextVk = vk::GetImpl(context);
159 RendererVk *renderer = contextVk->getRenderer();
Jamie Madille8dd0792018-09-27 15:04:27 -0400160 mFramebuffer.release(renderer);
Luc Ferron534b00d2018-05-18 08:16:53 -0400161
Shahbaz Youssefifca8fd62018-11-13 13:55:48 -0500162 mReadPixelBuffer.release(renderer);
163 mBlitPixelBuffer.release(renderer);
Jamie Madill5deea722017-02-16 10:44:46 -0500164}
165
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400166angle::Result FramebufferVk::discard(const gl::Context *context,
167 size_t count,
168 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400169{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400170 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500171 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400172}
173
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400174angle::Result FramebufferVk::invalidate(const gl::Context *context,
175 size_t count,
176 const GLenum *attachments)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400177{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400178 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500179 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400180}
181
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400182angle::Result FramebufferVk::invalidateSub(const gl::Context *context,
183 size_t count,
184 const GLenum *attachments,
185 const gl::Rectangle &area)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400186{
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400187 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -0500188 return angle::Result::Stop;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400189}
190
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400191angle::Result FramebufferVk::clear(const gl::Context *context, GLbitfield mask)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400192{
Jamie Madill0cec82a2018-03-14 09:21:07 -0400193 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500194
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400195 bool clearColor = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_COLOR_BUFFER_BIT));
196 bool clearDepth = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_DEPTH_BUFFER_BIT));
197 bool clearStencil = IsMaskFlagSet(mask, static_cast<GLbitfield>(GL_STENCIL_BUFFER_BIT));
198 gl::DrawBufferMask clearColorBuffers;
199 if (clearColor)
200 {
201 clearColorBuffers = mState.getEnabledDrawBuffers();
202 }
203
204 const VkClearColorValue &clearColorValue = contextVk->getClearColorValue().color;
205 const VkClearDepthStencilValue &clearDepthStencilValue =
206 contextVk->getClearDepthStencilValue().depthStencil;
207
208 return clearImpl(context, clearColorBuffers, clearDepth, clearStencil, clearColorValue,
209 clearDepthStencilValue);
210}
211
212angle::Result FramebufferVk::clearImpl(const gl::Context *context,
213 gl::DrawBufferMask clearColorBuffers,
214 bool clearDepth,
215 bool clearStencil,
216 const VkClearColorValue &clearColorValue,
217 const VkClearDepthStencilValue &clearDepthStencilValue)
218{
219 ContextVk *contextVk = vk::GetImpl(context);
220
221 const gl::State &glState = context->getState();
222 const gl::Rectangle &scissor = glState.getScissor();
223 const gl::Rectangle renderArea(0, 0, mState.getDimensions().width,
224 mState.getDimensions().height);
225 gl::Rectangle scissorRenderAreaIntersection;
226 // Discard clear altogether if scissor has 0 width or height.
227 if (glState.isScissorTestEnabled() &&
228 !gl::ClipRectangle(scissor, renderArea, &scissorRenderAreaIntersection))
229 {
230 return angle::Result::Continue;
231 }
232
233 mFramebuffer.updateQueueSerial(contextVk->getRenderer()->getCurrentQueueSerial());
234
235 // This function assumes that only enabled attachments are asked to be cleared.
236 ASSERT((clearColorBuffers & mState.getEnabledDrawBuffers()) == clearColorBuffers);
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400237
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400238 // Adjust clear behavior based on whether the respective attachments are present; if asked to
239 // clear a non-existent attachment, don't attempt to clear it.
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400240
241 VkColorComponentFlags colorMaskFlags = contextVk->getClearColorMask();
242 bool clearColor = clearColorBuffers.any();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400243
Jamie Madill0cec82a2018-03-14 09:21:07 -0400244 const gl::FramebufferAttachment *depthAttachment = mState.getDepthAttachment();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400245 clearDepth = clearDepth && depthAttachment;
Jamie Madill0cec82a2018-03-14 09:21:07 -0400246 ASSERT(!clearDepth || depthAttachment->isAttached());
247
248 const gl::FramebufferAttachment *stencilAttachment = mState.getStencilAttachment();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400249 clearStencil = clearStencil && stencilAttachment;
Jamie Madill0cec82a2018-03-14 09:21:07 -0400250 ASSERT(!clearStencil || stencilAttachment->isAttached());
251
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400252 uint8_t stencilMask =
253 static_cast<uint8_t>(contextVk->getState().getDepthStencilState().stencilWritemask);
254
255 // The front-end should ensure we don't attempt to clear color if all channels are masked.
256 ASSERT(!clearColor || colorMaskFlags != 0);
257 // The front-end should ensure we don't attempt to clear depth if depth write is disabled.
258 ASSERT(!clearDepth || contextVk->getState().getDepthStencilState().depthMask);
259 // The front-end should ensure we don't attempt to clear stencil if all bits are masked.
260 ASSERT(!clearStencil || stencilMask != 0);
261
262 // If there is nothing to clear, return right away (for example, if asked to clear depth, but
263 // there is no depth attachment).
Shahbaz Youssefi02a579e2019-03-27 14:21:20 -0400264 if (!clearColor && !clearDepth && !clearStencil)
265 {
266 return angle::Result::Continue;
267 }
268
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400269 VkClearDepthStencilValue modifiedDepthStencilValue = clearDepthStencilValue;
Shahbaz Youssefid856ca42018-10-31 16:55:12 -0400270
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400271 // If scissor is enabled, but covers the whole of framebuffer, it can be considered disabled for
272 // the sake of clear.
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400273 bool isScissorTestEffectivelyEnabled =
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400274 glState.isScissorTestEnabled() && scissorRenderAreaIntersection != renderArea;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400275
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400276 // We can use render pass load ops if clearing depth, unmasked color or unmasked stencil. If
277 // there's a depth mask, depth clearing is already disabled.
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400278 bool maskedClearColor =
279 clearColor && (mActiveColorComponents & colorMaskFlags) != mActiveColorComponents;
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400280 bool maskedClearStencil = stencilMask != 0xFF;
281
282 bool clearColorWithRenderPassLoadOp = clearColor && !maskedClearColor;
283 bool clearStencilWithRenderPassLoadOp = clearStencil && !maskedClearStencil;
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400284
285 // At least one of color, depth or stencil should be clearable with render pass loadOp for us
286 // to use this clear path.
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400287 bool clearAnyWithRenderPassLoadOp =
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400288 clearColorWithRenderPassLoadOp || clearDepth || clearStencilWithRenderPassLoadOp;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400289
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400290 if (clearAnyWithRenderPassLoadOp && !isScissorTestEffectivelyEnabled)
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400291 {
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400292 // Clearing color is indicated by the set bits in this mask. If not clearing colors with
293 // render pass loadOp, the default value of all-zeros means the clear is not done in
294 // clearWithRenderPassOp below.
295 gl::DrawBufferMask clearBuffersWithRenderPassLoadOp;
296 if (clearColorWithRenderPassLoadOp)
297 {
298 clearBuffersWithRenderPassLoadOp = clearColorBuffers;
299 }
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400300 // If there's a color mask, only clear depth/stencil with render pass loadOp.
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400301 ANGLE_TRY(clearWithRenderPassOp(contextVk, clearBuffersWithRenderPassLoadOp, clearDepth,
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400302 clearStencilWithRenderPassLoadOp, clearColorValue,
303 modifiedDepthStencilValue));
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400304
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400305 // On some hardware, having inline commands at this point results in corrupted output. In
306 // that case, end the render pass immediately. http://anglebug.com/2361
307 if (contextVk->getRenderer()->getFeatures().restartRenderPassAfterLoadOpClear)
308 {
309 mFramebuffer.finishCurrentCommands(contextVk->getRenderer());
310 }
311
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400312 // Fallback to other methods for whatever isn't cleared here.
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400313 clearDepth = false;
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400314 if (clearColorWithRenderPassLoadOp)
315 {
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400316 clearColorBuffers.reset();
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400317 clearColor = false;
318 }
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400319 if (clearStencilWithRenderPassLoadOp)
320 {
321 clearStencil = false;
322 }
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400323
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400324 // If nothing left to clear, early out.
325 if (!clearColor && !clearStencil)
Shahbaz Youssefif1153b02019-03-27 11:22:54 -0400326 {
327 return angle::Result::Continue;
328 }
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400329 }
330
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400331 // The most costly clear mode is when we need to mask out specific color channels or stencil
332 // bits. This can only be done with a draw call. The scissor region however can easily be
333 // integrated with this method.
334 //
335 // Since we have to have a draw call for the sake of masked color or stencil, we can make sure
336 // everything else is cleared with the draw call at the same time as well.
337 if (maskedClearColor || maskedClearStencil)
Jamie Madill9aef3672018-04-27 11:45:06 -0400338 {
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -0400339 return clearWithDraw(contextVk, clearColorBuffers, clearDepth, clearStencil, colorMaskFlags,
340 stencilMask, clearColorValue, modifiedDepthStencilValue);
Jamie Madill9aef3672018-04-27 11:45:06 -0400341 }
342
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400343 ASSERT(isScissorTestEffectivelyEnabled);
Luc Ferrona8af3a62018-03-29 14:44:24 -0400344
Shahbaz Youssefi27f115a2019-04-01 10:33:21 -0400345 // With scissor test enabled, we clear very differently and we don't need to access
346 // the image inside each attachment we can just use clearCmdAttachments with our
347 // scissor region instead.
348 return clearWithClearAttachments(contextVk, clearColorBuffers, clearDepth, clearStencil,
349 clearColorValue, modifiedDepthStencilValue);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400350}
351
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400352angle::Result FramebufferVk::clearBufferfv(const gl::Context *context,
353 GLenum buffer,
354 GLint drawbuffer,
355 const GLfloat *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400356{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400357 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400358
359 bool clearDepth = false;
360 gl::DrawBufferMask clearColorBuffers;
361
362 if (buffer == GL_DEPTH)
363 {
364 clearDepth = true;
365 clearValue.depthStencil.depth = values[0];
366 }
367 else
368 {
369 clearColorBuffers.set(drawbuffer);
370 clearValue.color.float32[0] = values[0];
371 clearValue.color.float32[1] = values[1];
372 clearValue.color.float32[2] = values[2];
373 clearValue.color.float32[3] = values[3];
374 }
375
376 return clearImpl(context, clearColorBuffers, clearDepth, false, clearValue.color,
377 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400378}
379
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400380angle::Result FramebufferVk::clearBufferuiv(const gl::Context *context,
381 GLenum buffer,
382 GLint drawbuffer,
383 const GLuint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400384{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400385 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400386
387 gl::DrawBufferMask clearColorBuffers;
388 clearColorBuffers.set(drawbuffer);
389
390 clearValue.color.uint32[0] = values[0];
391 clearValue.color.uint32[1] = values[1];
392 clearValue.color.uint32[2] = values[2];
393 clearValue.color.uint32[3] = values[3];
394
395 return clearImpl(context, clearColorBuffers, false, false, clearValue.color,
396 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400397}
398
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400399angle::Result FramebufferVk::clearBufferiv(const gl::Context *context,
400 GLenum buffer,
401 GLint drawbuffer,
402 const GLint *values)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400403{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400404 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400405
406 bool clearStencil = false;
407 gl::DrawBufferMask clearColorBuffers;
408
409 if (buffer == GL_STENCIL)
410 {
411 clearStencil = true;
412 clearValue.depthStencil.stencil =
413 gl::clamp(values[0], 0, std::numeric_limits<uint8_t>::max());
414 }
415 else
416 {
417 clearColorBuffers.set(drawbuffer);
418 clearValue.color.int32[0] = values[0];
419 clearValue.color.int32[1] = values[1];
420 clearValue.color.int32[2] = values[2];
421 clearValue.color.int32[3] = values[3];
422 }
423
424 return clearImpl(context, clearColorBuffers, false, clearStencil, clearValue.color,
425 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400426}
427
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400428angle::Result FramebufferVk::clearBufferfi(const gl::Context *context,
429 GLenum buffer,
430 GLint drawbuffer,
431 GLfloat depth,
432 GLint stencil)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400433{
Shahbaz Youssefiedef8952019-04-04 10:03:09 -0400434 VkClearValue clearValue = {};
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400435
436 clearValue.depthStencil.depth = depth;
437 clearValue.depthStencil.stencil = gl::clamp(stencil, 0, std::numeric_limits<uint8_t>::max());
438
439 return clearImpl(context, gl::DrawBufferMask(), true, true, clearValue.color,
440 clearValue.depthStencil);
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400441}
442
Jamie Madill4928b7c2017-06-20 12:57:39 -0400443GLenum FramebufferVk::getImplementationColorReadFormat(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400444{
Jamie Madill66546be2018-03-08 09:47:20 -0500445 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).format;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400446}
447
Jamie Madill4928b7c2017-06-20 12:57:39 -0400448GLenum FramebufferVk::getImplementationColorReadType(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400449{
Jamie Madill66546be2018-03-08 09:47:20 -0500450 return GetReadAttachmentInfo(context, mRenderTargetCache.getColorRead(mState)).type;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400451}
452
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400453angle::Result FramebufferVk::readPixels(const gl::Context *context,
454 const gl::Rectangle &area,
455 GLenum format,
456 GLenum type,
457 void *pixels)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400458{
Luc Ferrona1c72422018-05-14 15:58:28 -0400459 // Clip read area to framebuffer.
460 const gl::Extents &fbSize = getState().getReadAttachment()->getSize();
461 const gl::Rectangle fbRect(0, 0, fbSize.width, fbSize.height);
Luc Ferronbf6dc372018-06-28 15:24:19 -0400462 ContextVk *contextVk = vk::GetImpl(context);
463 RendererVk *renderer = contextVk->getRenderer();
464
Luc Ferrona1c72422018-05-14 15:58:28 -0400465 gl::Rectangle clippedArea;
466 if (!ClipRectangle(area, fbRect, &clippedArea))
467 {
468 // nothing to read
Jamie Madill7c985f52018-11-29 18:16:17 -0500469 return angle::Result::Continue;
Luc Ferrona1c72422018-05-14 15:58:28 -0400470 }
Luc Ferronbf6dc372018-06-28 15:24:19 -0400471 gl::Rectangle flippedArea = clippedArea;
Geoff Lange076a232018-07-16 15:34:05 -0400472 if (contextVk->isViewportFlipEnabledForReadFBO())
Luc Ferronbf6dc372018-06-28 15:24:19 -0400473 {
474 flippedArea.y = fbRect.height - flippedArea.y - flippedArea.height;
475 }
Luc Ferrona1c72422018-05-14 15:58:28 -0400476
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500477 const gl::State &glState = context->getState();
Frank Henigman1ffad842018-09-24 23:40:45 -0400478 const gl::PixelPackState &packState = glState.getPackState();
Luc Ferronbf6dc372018-06-28 15:24:19 -0400479
Luc Ferrona1c72422018-05-14 15:58:28 -0400480 const gl::InternalFormat &sizedFormatInfo = gl::GetInternalFormatInfo(format, type);
481
482 GLuint outputPitch = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400483 ANGLE_VK_CHECK_MATH(contextVk,
484 sizedFormatInfo.computeRowPitch(type, area.width, packState.alignment,
485 packState.rowLength, &outputPitch));
Luc Ferrona1c72422018-05-14 15:58:28 -0400486 GLuint outputSkipBytes = 0;
Jamie Madillabfbc0f2018-10-09 12:48:52 -0400487 ANGLE_VK_CHECK_MATH(contextVk, sizedFormatInfo.computeSkipBytes(type, outputPitch, 0, packState,
488 false, &outputSkipBytes));
Luc Ferrona1c72422018-05-14 15:58:28 -0400489
490 outputSkipBytes += (clippedArea.x - area.x) * sizedFormatInfo.pixelBytes +
491 (clippedArea.y - area.y) * outputPitch;
Luc Ferron60284222018-03-20 16:01:44 -0400492
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400493 const angle::Format &angleFormat = GetFormatFromFormatType(format, type);
494
Frank Henigman1ffad842018-09-24 23:40:45 -0400495 PackPixelsParams params(flippedArea, angleFormat, outputPitch, packState.reverseRowOrder,
Jamie Madilldb9c69e2018-07-18 17:23:47 -0400496 glState.getTargetBuffer(gl::BufferBinding::PixelPack), 0);
Frank Henigman1ffad842018-09-24 23:40:45 -0400497 if (contextVk->isViewportFlipEnabledForReadFBO())
498 {
499 params.reverseRowOrder = !params.reverseRowOrder;
500 }
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500501
Jamie Madill21061022018-07-12 23:56:30 -0400502 ANGLE_TRY(readPixelsImpl(contextVk, flippedArea, params, VK_IMAGE_ASPECT_COLOR_BIT,
Luc Ferron1617e692018-07-11 11:08:19 -0400503 getColorReadRenderTarget(),
Rafael Cintron05a449a2018-06-20 18:08:04 -0700504 static_cast<uint8_t *>(pixels) + outputSkipBytes));
Jamie Madilld754eb52018-07-19 14:55:03 -0400505 mReadPixelBuffer.releaseRetainedBuffers(renderer);
Jamie Madill7c985f52018-11-29 18:16:17 -0500506 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -0400507}
Jamie Madill7b57b9d2017-01-13 09:33:38 -0500508
Luc Ferron26581112018-06-21 09:43:08 -0400509RenderTargetVk *FramebufferVk::getDepthStencilRenderTarget() const
510{
511 return mRenderTargetCache.getDepthStencil();
512}
513
Jamie Madill16c20142018-10-01 13:58:19 -0400514angle::Result FramebufferVk::blitWithCopy(ContextVk *contextVk,
515 const gl::Rectangle &copyArea,
516 RenderTargetVk *readRenderTarget,
517 RenderTargetVk *drawRenderTarget,
518 bool blitDepthBuffer,
519 bool blitStencilBuffer)
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400520{
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500521 VkImageAspectFlags aspectMask =
522 vk::GetDepthStencilAspectFlagsForCopy(blitDepthBuffer, blitStencilBuffer);
Jamie Madill16c20142018-10-01 13:58:19 -0400523
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400524 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400525 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
526
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500527 vk::ImageHelper *writeImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
528 writeImage->changeLayout(writeImage->getAspectFlags(), vk::ImageLayout::TransferDst,
529 commandBuffer);
530
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400531 vk::ImageHelper *readImage = readRenderTarget->getImageForRead(
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500532 &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400533
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500534 VkImageSubresourceLayers readSubresource = {};
535 readSubresource.aspectMask = aspectMask;
536 readSubresource.mipLevel = 0;
537 readSubresource.baseArrayLayer = 0;
538 readSubresource.layerCount = 1;
539
540 VkImageSubresourceLayers writeSubresource = readSubresource;
541
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400542 vk::ImageHelper::Copy(readImage, writeImage, gl::Offset(), gl::Offset(),
Shahbaz Youssefi028df5f2019-02-13 12:57:10 -0500543 gl::Extents(copyArea.width, copyArea.height, 1), readSubresource,
544 writeSubresource, commandBuffer);
Jamie Madill7c985f52018-11-29 18:16:17 -0500545 return angle::Result::Continue;
Luc Ferronbe30c4f2018-06-21 09:43:08 -0400546}
547
Jamie Madill58675012018-05-22 14:54:07 -0400548RenderTargetVk *FramebufferVk::getColorReadRenderTarget() const
Luc Ferron018709f2018-05-10 13:53:11 -0400549{
550 RenderTargetVk *renderTarget = mRenderTargetCache.getColorRead(mState);
Jamie Madillbcf467f2018-05-23 09:46:00 -0400551 ASSERT(renderTarget && renderTarget->getImage().valid());
Luc Ferron018709f2018-05-10 13:53:11 -0400552 return renderTarget;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400553}
554
Jamie Madill21061022018-07-12 23:56:30 -0400555angle::Result FramebufferVk::blitWithReadback(ContextVk *contextVk,
Jamie Madilld754eb52018-07-19 14:55:03 -0400556 const gl::Rectangle &copyArea,
Jamie Madillb436aac2018-07-18 17:23:48 -0400557 VkImageAspectFlagBits aspect,
Jamie Madill21061022018-07-12 23:56:30 -0400558 RenderTargetVk *readRenderTarget,
559 RenderTargetVk *drawRenderTarget)
Luc Ferron1617e692018-07-11 11:08:19 -0400560{
Jamie Madillb436aac2018-07-18 17:23:48 -0400561 RendererVk *renderer = contextVk->getRenderer();
562 const angle::Format &readFormat = readRenderTarget->getImageFormat().textureFormat();
Luc Ferron1617e692018-07-11 11:08:19 -0400563
Jamie Madillb436aac2018-07-18 17:23:48 -0400564 ASSERT(aspect == VK_IMAGE_ASPECT_DEPTH_BIT || aspect == VK_IMAGE_ASPECT_STENCIL_BIT);
Luc Ferron1617e692018-07-11 11:08:19 -0400565
Jamie Madillb436aac2018-07-18 17:23:48 -0400566 // This path is only currently used for y-flipping depth/stencil blits.
Luc Ferron1617e692018-07-11 11:08:19 -0400567 PackPixelsParams packPixelsParams;
Jamie Madillb980c562018-11-27 11:34:27 -0500568 packPixelsParams.reverseRowOrder = true;
569 packPixelsParams.area.width = copyArea.width;
570 packPixelsParams.area.height = copyArea.height;
571 packPixelsParams.area.x = copyArea.x;
572 packPixelsParams.area.y = copyArea.y;
Luc Ferron1617e692018-07-11 11:08:19 -0400573
Jamie Madillb436aac2018-07-18 17:23:48 -0400574 // Read back depth values into the destination buffer.
575 const angle::Format &copyFormat = GetDepthStencilImageToBufferFormat(readFormat, aspect);
576 packPixelsParams.destFormat = &copyFormat;
577 packPixelsParams.outputPitch = copyFormat.pixelBytes * copyArea.width;
Luc Ferron1617e692018-07-11 11:08:19 -0400578
Jamie Madillb436aac2018-07-18 17:23:48 -0400579 // Allocate a space in the destination buffer to write to.
580 size_t blitAllocationSize = copyFormat.pixelBytes * copyArea.width * copyArea.height;
581 uint8_t *destPtr = nullptr;
582 VkBuffer destBufferHandle = VK_NULL_HANDLE;
Jamie Madill4c310832018-08-29 13:43:17 -0400583 VkDeviceSize destOffset = 0;
Jamie Madillb436aac2018-07-18 17:23:48 -0400584 ANGLE_TRY(mBlitPixelBuffer.allocate(contextVk, blitAllocationSize, &destPtr, &destBufferHandle,
585 &destOffset, nullptr));
Luc Ferron1617e692018-07-11 11:08:19 -0400586
Jamie Madillb436aac2018-07-18 17:23:48 -0400587 ANGLE_TRY(
588 readPixelsImpl(contextVk, copyArea, packPixelsParams, aspect, readRenderTarget, destPtr));
Luc Ferron1617e692018-07-11 11:08:19 -0400589
Shahbaz Youssefi06270c92018-10-03 17:00:25 -0400590 VkBufferImageCopy copyRegion = {};
Jamie Madillb436aac2018-07-18 17:23:48 -0400591 copyRegion.bufferOffset = destOffset;
592 copyRegion.bufferImageHeight = copyArea.height;
593 copyRegion.bufferRowLength = copyArea.width;
594 copyRegion.imageExtent.width = copyArea.width;
595 copyRegion.imageExtent.height = copyArea.height;
596 copyRegion.imageExtent.depth = 1;
597 copyRegion.imageSubresource.mipLevel = 0;
598 copyRegion.imageSubresource.aspectMask = aspect;
599 copyRegion.imageSubresource.baseArrayLayer = 0;
600 copyRegion.imageSubresource.layerCount = 1;
601 copyRegion.imageOffset.x = copyArea.x;
602 copyRegion.imageOffset.y = copyArea.y;
603 copyRegion.imageOffset.z = 0;
604
Jamie Madill21061022018-07-12 23:56:30 -0400605 ANGLE_TRY(mBlitPixelBuffer.flush(contextVk));
Luc Ferron1617e692018-07-11 11:08:19 -0400606
607 // Reinitialize the commandBuffer after a read pixels because it calls
608 // renderer->finish which makes command buffers obsolete.
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400609 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -0400610 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Luc Ferron1617e692018-07-11 11:08:19 -0400611
612 // We read the bytes of the image in a buffer, now we have to copy them into the
613 // destination target.
Jamie Madille8dd0792018-09-27 15:04:27 -0400614 vk::ImageHelper *imageForWrite = drawRenderTarget->getImageForWrite(&mFramebuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400615
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500616 imageForWrite->changeLayout(imageForWrite->getAspectFlags(), vk::ImageLayout::TransferDst,
617 commandBuffer);
Luc Ferron1617e692018-07-11 11:08:19 -0400618
Jamie Madillb436aac2018-07-18 17:23:48 -0400619 commandBuffer->copyBufferToImage(destBufferHandle, imageForWrite->getImage(),
620 VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &copyRegion);
Luc Ferron1617e692018-07-11 11:08:19 -0400621
622 mBlitPixelBuffer.releaseRetainedBuffers(renderer);
Jamie Madillb436aac2018-07-18 17:23:48 -0400623
Jamie Madill7c985f52018-11-29 18:16:17 -0500624 return angle::Result::Continue;
Luc Ferron1617e692018-07-11 11:08:19 -0400625}
626
Jamie Madill64b7c4f2018-10-19 11:38:04 -0400627angle::Result FramebufferVk::blit(const gl::Context *context,
628 const gl::Rectangle &sourceArea,
629 const gl::Rectangle &destArea,
630 GLbitfield mask,
631 GLenum filter)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400632{
Luc Ferron26581112018-06-21 09:43:08 -0400633 ContextVk *contextVk = vk::GetImpl(context);
634 RendererVk *renderer = contextVk->getRenderer();
635
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500636 const gl::State &glState = context->getState();
Luc Ferron26581112018-06-21 09:43:08 -0400637 const gl::Framebuffer *sourceFramebuffer = glState.getReadFramebuffer();
Jamie Madillba365932018-07-18 17:23:46 -0400638 bool blitColorBuffer = (mask & GL_COLOR_BUFFER_BIT) != 0;
639 bool blitDepthBuffer = (mask & GL_DEPTH_BUFFER_BIT) != 0;
640 bool blitStencilBuffer = (mask & GL_STENCIL_BUFFER_BIT) != 0;
Luc Ferron26581112018-06-21 09:43:08 -0400641
Luc Ferron26581112018-06-21 09:43:08 -0400642 FramebufferVk *sourceFramebufferVk = vk::GetImpl(sourceFramebuffer);
Luc Ferron82eda932018-07-09 15:10:22 -0400643 bool flipSource = contextVk->isViewportFlipEnabledForReadFBO();
644 bool flipDest = contextVk->isViewportFlipEnabledForDrawFBO();
645
Jamie Madilld754eb52018-07-19 14:55:03 -0400646 gl::Rectangle readRect = sourceArea;
647 gl::Rectangle drawRect = destArea;
648
649 if (glState.isScissorTestEnabled())
650 {
651 const gl::Rectangle scissorRect = glState.getScissor();
652 if (!ClipRectangle(sourceArea, scissorRect, &readRect))
653 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500654 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400655 }
656
657 if (!ClipRectangle(destArea, scissorRect, &drawRect))
658 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500659 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400660 }
661 }
662
663 // After cropping for the scissor, we also want to crop for the size of the buffers.
664
Luc Ferron26581112018-06-21 09:43:08 -0400665 if (blitColorBuffer)
666 {
667 RenderTargetVk *readRenderTarget = sourceFramebufferVk->getColorReadRenderTarget();
668
Jamie Madilld754eb52018-07-19 14:55:03 -0400669 gl::Rectangle readRenderTargetRect;
670 if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect))
671 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500672 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400673 }
674
Luc Ferron26581112018-06-21 09:43:08 -0400675 for (size_t colorAttachment : mState.getEnabledDrawBuffers())
676 {
677 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getColors()[colorAttachment];
678 ASSERT(drawRenderTarget);
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -0500679 ASSERT(HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget));
Jamie Madilld754eb52018-07-19 14:55:03 -0400680
681 gl::Rectangle drawRenderTargetRect;
682 if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect))
683 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500684 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400685 }
686
Jamie Madill16c20142018-10-01 13:58:19 -0400687 ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect,
688 readRenderTarget, drawRenderTarget, filter, true, false,
689 false, flipSource, flipDest));
Luc Ferron26581112018-06-21 09:43:08 -0400690 }
691 }
692
693 if (blitDepthBuffer || blitStencilBuffer)
694 {
695 RenderTargetVk *readRenderTarget = sourceFramebufferVk->getDepthStencilRenderTarget();
696 ASSERT(readRenderTarget);
697
Jamie Madilld754eb52018-07-19 14:55:03 -0400698 gl::Rectangle readRenderTargetRect;
699 if (!ClipToRenderTarget(readRect, readRenderTarget, &readRenderTargetRect))
700 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500701 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400702 }
703
Luc Ferron26581112018-06-21 09:43:08 -0400704 RenderTargetVk *drawRenderTarget = mRenderTargetCache.getDepthStencil();
Jamie Madilld754eb52018-07-19 14:55:03 -0400705 ASSERT(drawRenderTarget);
706
707 gl::Rectangle drawRenderTargetRect;
708 if (!ClipToRenderTarget(drawRect, drawRenderTarget, &drawRenderTargetRect))
709 {
Jamie Madill7c985f52018-11-29 18:16:17 -0500710 return angle::Result::Continue;
Jamie Madilld754eb52018-07-19 14:55:03 -0400711 }
712
713 ASSERT(readRenderTargetRect == drawRenderTargetRect);
714 ASSERT(filter == GL_NEAREST);
Luc Ferron26581112018-06-21 09:43:08 -0400715
Shahbaz Youssefi96bd8fd2018-11-30 14:30:18 -0500716 if (HasSrcAndDstBlitProperties(renderer, readRenderTarget, drawRenderTarget))
Luc Ferron26581112018-06-21 09:43:08 -0400717 {
Jamie Madill16c20142018-10-01 13:58:19 -0400718 ANGLE_TRY(blitWithCommand(contextVk, readRenderTargetRect, drawRenderTargetRect,
719 readRenderTarget, drawRenderTarget, filter, false,
720 blitDepthBuffer, blitStencilBuffer, flipSource, flipDest));
Luc Ferron26581112018-06-21 09:43:08 -0400721 }
722 else
723 {
Luc Ferron1617e692018-07-11 11:08:19 -0400724 if (flipSource || flipDest)
725 {
Jamie Madillb436aac2018-07-18 17:23:48 -0400726 if (blitDepthBuffer)
727 {
728 ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect,
Jamie Madill16c20142018-10-01 13:58:19 -0400729 VK_IMAGE_ASPECT_DEPTH_BIT, readRenderTarget,
730 drawRenderTarget));
Jamie Madillb436aac2018-07-18 17:23:48 -0400731 }
732 if (blitStencilBuffer)
733 {
734 ANGLE_TRY(blitWithReadback(contextVk, readRenderTargetRect,
Jamie Madill16c20142018-10-01 13:58:19 -0400735 VK_IMAGE_ASPECT_STENCIL_BIT, readRenderTarget,
736 drawRenderTarget));
Jamie Madillb436aac2018-07-18 17:23:48 -0400737 }
Luc Ferron1617e692018-07-11 11:08:19 -0400738 }
739 else
740 {
Jamie Madill16c20142018-10-01 13:58:19 -0400741 ANGLE_TRY(blitWithCopy(contextVk, readRenderTargetRect, readRenderTarget,
742 drawRenderTarget, blitDepthBuffer, blitStencilBuffer));
Luc Ferron1617e692018-07-11 11:08:19 -0400743 }
Luc Ferron26581112018-06-21 09:43:08 -0400744 }
745 }
746
Jamie Madill7c985f52018-11-29 18:16:17 -0500747 return angle::Result::Continue;
Luc Ferron26581112018-06-21 09:43:08 -0400748}
749
Jamie Madill16c20142018-10-01 13:58:19 -0400750angle::Result FramebufferVk::blitWithCommand(ContextVk *contextVk,
751 const gl::Rectangle &readRectIn,
752 const gl::Rectangle &drawRectIn,
753 RenderTargetVk *readRenderTarget,
754 RenderTargetVk *drawRenderTarget,
755 GLenum filter,
756 bool colorBlit,
757 bool depthBlit,
758 bool stencilBlit,
759 bool flipSource,
760 bool flipDest)
Luc Ferron26581112018-06-21 09:43:08 -0400761{
762 // Since blitRenderbufferRect is called for each render buffer that needs to be blitted,
763 // it should never be the case that both color and depth/stencil need to be blitted at
764 // at the same time.
765 ASSERT(colorBlit != (depthBlit || stencilBlit));
766
Jamie Madill16c20142018-10-01 13:58:19 -0400767 vk::ImageHelper *dstImage = drawRenderTarget->getImageForWrite(&mFramebuffer);
768
Shahbaz Youssefi2660b502019-03-21 12:08:40 -0400769 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madill16c20142018-10-01 13:58:19 -0400770 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
771
Luc Ferron26581112018-06-21 09:43:08 -0400772 const vk::Format &readImageFormat = readRenderTarget->getImageFormat();
773 VkImageAspectFlags aspectMask =
774 colorBlit ? VK_IMAGE_ASPECT_COLOR_BIT
775 : vk::GetDepthStencilAspectFlags(readImageFormat.textureFormat());
776 vk::ImageHelper *srcImage = readRenderTarget->getImageForRead(
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500777 &mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Luc Ferron26581112018-06-21 09:43:08 -0400778
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400779 const gl::Extents sourceFrameBufferExtents = readRenderTarget->getExtents();
Jamie Madilld754eb52018-07-19 14:55:03 -0400780 gl::Rectangle readRect = readRectIn;
781
Luc Ferron82eda932018-07-09 15:10:22 -0400782 if (flipSource)
783 {
Jamie Madilld754eb52018-07-19 14:55:03 -0400784 readRect.y = sourceFrameBufferExtents.height - readRect.y - readRect.height;
Luc Ferron82eda932018-07-09 15:10:22 -0400785 }
786
Jamie Madillba365932018-07-18 17:23:46 -0400787 VkImageBlit blit = {};
788 blit.srcOffsets[0] = {readRect.x0(), flipSource ? readRect.y1() : readRect.y0(), 0};
789 blit.srcOffsets[1] = {readRect.x1(), flipSource ? readRect.y0() : readRect.y1(), 1};
790 blit.srcSubresource.aspectMask = aspectMask;
791 blit.srcSubresource.mipLevel = 0;
Luc Ferron26581112018-06-21 09:43:08 -0400792 blit.srcSubresource.baseArrayLayer = 0;
793 blit.srcSubresource.layerCount = 1;
794 blit.dstSubresource.aspectMask = aspectMask;
795 blit.dstSubresource.mipLevel = 0;
796 blit.dstSubresource.baseArrayLayer = 0;
797 blit.dstSubresource.layerCount = 1;
798
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400799 const gl::Extents drawFrameBufferExtents = drawRenderTarget->getExtents();
800 gl::Rectangle drawRect = drawRectIn;
Luc Ferron26581112018-06-21 09:43:08 -0400801
Luc Ferron82eda932018-07-09 15:10:22 -0400802 if (flipDest)
803 {
Jamie Madilld754eb52018-07-19 14:55:03 -0400804 drawRect.y = drawFrameBufferExtents.height - drawRect.y - drawRect.height;
Luc Ferron82eda932018-07-09 15:10:22 -0400805 }
806
Jamie Madilld754eb52018-07-19 14:55:03 -0400807 blit.dstOffsets[0] = {drawRect.x0(), flipDest ? drawRect.y1() : drawRect.y0(), 0};
808 blit.dstOffsets[1] = {drawRect.x1(), flipDest ? drawRect.y0() : drawRect.y1(), 1};
Luc Ferron26581112018-06-21 09:43:08 -0400809
Luc Ferron26581112018-06-21 09:43:08 -0400810 // Requirement of the copyImageToBuffer, the dst image must be in
811 // VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout.
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -0500812 dstImage->changeLayout(aspectMask, vk::ImageLayout::TransferDst, commandBuffer);
Luc Ferron26581112018-06-21 09:43:08 -0400813
814 commandBuffer->blitImage(srcImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL,
815 dstImage->getImage(), VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, 1, &blit,
816 gl_vk::GetFilter(filter));
Jamie Madill16c20142018-10-01 13:58:19 -0400817
Jamie Madill7c985f52018-11-29 18:16:17 -0500818 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400819}
820
Kenneth Russellce8602a2017-10-03 18:23:08 -0700821bool FramebufferVk::checkStatus(const gl::Context *context) const
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400822{
Luc Ferron5bdf8bd2018-06-20 09:51:37 -0400823 // if we have both a depth and stencil buffer, they must refer to the same object
824 // since we only support packed_depth_stencil and not separate depth and stencil
825 if (mState.hasSeparateDepthAndStencilAttachments())
826 {
827 return false;
828 }
829
Jamie Madillb79e7bb2017-10-24 13:55:50 -0400830 return true;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400831}
832
Jamie Madill6f755b22018-10-09 12:48:54 -0400833angle::Result FramebufferVk::syncState(const gl::Context *context,
834 const gl::Framebuffer::DirtyBits &dirtyBits)
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400835{
Jamie Madille1f3ad42017-10-28 23:00:42 -0400836 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madill7bd16662017-10-28 19:40:50 -0400837 RendererVk *renderer = contextVk->getRenderer();
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400838
839 ASSERT(dirtyBits.any());
Jamie Madill57d9cbb2018-04-27 11:45:04 -0400840 for (size_t dirtyBit : dirtyBits)
841 {
842 switch (dirtyBit)
843 {
844 case gl::Framebuffer::DIRTY_BIT_DEPTH_ATTACHMENT:
845 case gl::Framebuffer::DIRTY_BIT_STENCIL_ATTACHMENT:
846 ANGLE_TRY(mRenderTargetCache.updateDepthStencilRenderTarget(context, mState));
847 break;
848 case gl::Framebuffer::DIRTY_BIT_DRAW_BUFFERS:
849 case gl::Framebuffer::DIRTY_BIT_READ_BUFFER:
850 case gl::Framebuffer::DIRTY_BIT_DEFAULT_WIDTH:
851 case gl::Framebuffer::DIRTY_BIT_DEFAULT_HEIGHT:
852 case gl::Framebuffer::DIRTY_BIT_DEFAULT_SAMPLES:
853 case gl::Framebuffer::DIRTY_BIT_DEFAULT_FIXED_SAMPLE_LOCATIONS:
854 break;
855 default:
856 {
857 ASSERT(gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0 == 0 &&
858 dirtyBit < gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_MAX);
859 size_t colorIndex =
860 static_cast<size_t>(dirtyBit - gl::Framebuffer::DIRTY_BIT_COLOR_ATTACHMENT_0);
861 ANGLE_TRY(mRenderTargetCache.updateColorRenderTarget(context, mState, colorIndex));
Jamie Madill9aef3672018-04-27 11:45:06 -0400862
863 // Update cached masks for masked clears.
864 RenderTargetVk *renderTarget = mRenderTargetCache.getColors()[colorIndex];
865 if (renderTarget)
866 {
Luc Ferron5fd36932018-06-19 14:55:50 -0400867 const angle::Format &emulatedFormat =
868 renderTarget->getImageFormat().textureFormat();
869 updateActiveColorMasks(
870 colorIndex, emulatedFormat.redBits > 0, emulatedFormat.greenBits > 0,
871 emulatedFormat.blueBits > 0, emulatedFormat.alphaBits > 0);
872
Luc Ferron5fd36932018-06-19 14:55:50 -0400873 const angle::Format &sourceFormat =
874 renderTarget->getImageFormat().angleFormat();
875 mEmulatedAlphaAttachmentMask.set(
876 colorIndex, sourceFormat.alphaBits == 0 && emulatedFormat.alphaBits > 0);
Luc Ferron0bb940a2018-06-22 09:59:34 -0400877
Jamie Madillc3dc5d42018-12-30 12:12:04 -0500878 contextVk->updateColorMask(context->getState().getBlendState());
Jamie Madill9aef3672018-04-27 11:45:06 -0400879 }
880 else
881 {
Jamie Madill58675012018-05-22 14:54:07 -0400882 updateActiveColorMasks(colorIndex, false, false, false, false);
Jamie Madill9aef3672018-04-27 11:45:06 -0400883 }
Jamie Madill57d9cbb2018-04-27 11:45:04 -0400884 break;
885 }
886 }
887 }
Jamie Madill66546be2018-03-08 09:47:20 -0500888
Jamie Madill9aef3672018-04-27 11:45:06 -0400889 mActiveColorComponents = gl_vk::GetColorComponentFlags(
Luc Ferron5fd36932018-06-19 14:55:50 -0400890 mActiveColorComponentMasksForClear[0].any(), mActiveColorComponentMasksForClear[1].any(),
891 mActiveColorComponentMasksForClear[2].any(), mActiveColorComponentMasksForClear[3].any());
Jamie Madill9aef3672018-04-27 11:45:06 -0400892
Jamie Madille8dd0792018-09-27 15:04:27 -0400893 mFramebuffer.release(renderer);
Jamie Madill49ac74b2017-12-21 14:42:33 -0500894
Jamie Madill316c6062018-05-29 10:49:45 -0400895 // Will freeze the current set of dependencies on this FBO. The next time we render we will
Jamie Madilla5e06072018-05-18 14:36:05 -0400896 // create a new entry in the command graph.
Jamie Madille8dd0792018-09-27 15:04:27 -0400897 mFramebuffer.finishCurrentCommands(renderer);
Jamie Madill72106562017-03-24 14:18:50 -0400898
Jamie Madilldbc605c2019-01-04 16:39:14 -0500899 // Notify the ContextVk to update the pipeline desc.
900 updateRenderPassDesc();
901 contextVk->onFramebufferChange(mRenderPassDesc);
Jamie Madill19fa1c62018-03-08 09:47:21 -0500902
Jamie Madill7c985f52018-11-29 18:16:17 -0500903 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500904}
905
Jamie Madilldbc605c2019-01-04 16:39:14 -0500906void FramebufferVk::updateRenderPassDesc()
Jamie Madillab9f9c32017-01-17 17:47:34 -0500907{
Jamie Madilldbc605c2019-01-04 16:39:14 -0500908 mRenderPassDesc = {};
909 mRenderPassDesc.setSamples(getSamples());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500910
Jamie Madill66546be2018-03-08 09:47:20 -0500911 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
912 const auto &colorRenderTargets = mRenderTargetCache.getColors();
913 for (size_t colorIndex : mState.getEnabledDrawBuffers())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500914 {
Jamie Madill66546be2018-03-08 09:47:20 -0500915 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
916 ASSERT(colorRenderTarget);
Jamie Madilldbc605c2019-01-04 16:39:14 -0500917 mRenderPassDesc.packAttachment(colorRenderTarget->getImage().getFormat());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500918 }
919
Jamie Madill66546be2018-03-08 09:47:20 -0500920 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
921 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500922 {
Jamie Madilldbc605c2019-01-04 16:39:14 -0500923 mRenderPassDesc.packAttachment(depthStencilRenderTarget->getImage().getFormat());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500924 }
Jamie Madillab9f9c32017-01-17 17:47:34 -0500925}
926
Jamie Madill21061022018-07-12 23:56:30 -0400927angle::Result FramebufferVk::getFramebuffer(ContextVk *contextVk, vk::Framebuffer **framebufferOut)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500928{
929 // If we've already created our cached Framebuffer, return it.
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400930 if (mFramebuffer.valid())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500931 {
Jamie Madille8dd0792018-09-27 15:04:27 -0400932 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -0500933 return angle::Result::Continue;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500934 }
935
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400936 vk::RenderPass *compatibleRenderPass = nullptr;
937 ANGLE_TRY(contextVk->getRenderer()->getCompatibleRenderPass(contextVk, mRenderPassDesc,
938 &compatibleRenderPass));
Jamie Madillab9f9c32017-01-17 17:47:34 -0500939
940 // If we've a Framebuffer provided by a Surface (default FBO/backbuffer), query it.
941 if (mBackbuffer)
942 {
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400943 return mBackbuffer->getCurrentFramebuffer(contextVk, *compatibleRenderPass, framebufferOut);
Jamie Madillab9f9c32017-01-17 17:47:34 -0500944 }
945
946 // Gather VkImageViews over all FBO attachments, also size of attached region.
947 std::vector<VkImageView> attachments;
948 gl::Extents attachmentsSize;
949
Jamie Madill66546be2018-03-08 09:47:20 -0500950 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
951 const auto &colorRenderTargets = mRenderTargetCache.getColors();
952 for (size_t colorIndex : mState.getEnabledDrawBuffers())
Jamie Madillab9f9c32017-01-17 17:47:34 -0500953 {
Jamie Madill66546be2018-03-08 09:47:20 -0500954 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
955 ASSERT(colorRenderTarget);
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +0100956 attachments.push_back(colorRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500957
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400958 ASSERT(attachmentsSize.empty() || attachmentsSize == colorRenderTarget->getExtents());
959 attachmentsSize = colorRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500960 }
961
Jamie Madill66546be2018-03-08 09:47:20 -0500962 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
963 if (depthStencilRenderTarget)
Jamie Madillab9f9c32017-01-17 17:47:34 -0500964 {
Shahbaz Youssefif83a28a2018-12-09 03:48:34 +0100965 attachments.push_back(depthStencilRenderTarget->getDrawImageView()->getHandle());
Jamie Madillab9f9c32017-01-17 17:47:34 -0500966
Jamie Madillbc543422018-03-30 10:43:19 -0400967 ASSERT(attachmentsSize.empty() ||
Shahbaz Youssefi68549402019-03-25 23:30:49 -0400968 attachmentsSize == depthStencilRenderTarget->getExtents());
969 attachmentsSize = depthStencilRenderTarget->getExtents();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500970 }
971
972 ASSERT(!attachments.empty());
973
Shahbaz Youssefi06270c92018-10-03 17:00:25 -0400974 VkFramebufferCreateInfo framebufferInfo = {};
Jamie Madillab9f9c32017-01-17 17:47:34 -0500975
976 framebufferInfo.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO;
Jamie Madillab9f9c32017-01-17 17:47:34 -0500977 framebufferInfo.flags = 0;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400978 framebufferInfo.renderPass = compatibleRenderPass->getHandle();
Jamie Madillab9f9c32017-01-17 17:47:34 -0500979 framebufferInfo.attachmentCount = static_cast<uint32_t>(attachments.size());
980 framebufferInfo.pAttachments = attachments.data();
981 framebufferInfo.width = static_cast<uint32_t>(attachmentsSize.width);
982 framebufferInfo.height = static_cast<uint32_t>(attachmentsSize.height);
983 framebufferInfo.layers = 1;
984
Jamie Madill21061022018-07-12 23:56:30 -0400985 ANGLE_TRY(mFramebuffer.init(contextVk, framebufferInfo));
Jamie Madill5deea722017-02-16 10:44:46 -0500986
Jamie Madille8dd0792018-09-27 15:04:27 -0400987 *framebufferOut = &mFramebuffer.getFramebuffer();
Jamie Madill7c985f52018-11-29 18:16:17 -0500988 return angle::Result::Continue;
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400989}
990
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400991angle::Result FramebufferVk::clearWithRenderPassOp(
992 ContextVk *contextVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400993 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -0400994 bool clearDepth,
995 bool clearStencil,
996 const VkClearColorValue &clearColorValue,
997 const VkClearDepthStencilValue &clearDepthStencilValue)
998{
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -0400999 // If render pass hasn't started, start it. If it's started and contains commands, we cannot
1000 // modify its ops, so start a new render pass.
1001 if (!mFramebuffer.valid() || !mFramebuffer.renderPassStartedButEmpty())
1002 {
1003 vk::CommandBuffer *commandBuffer;
1004 ANGLE_TRY(startNewRenderPass(contextVk, &commandBuffer));
1005 }
1006
1007 size_t attachmentIndex = 0;
1008
1009 // Go through clearColorBuffers and set the appropriate loadOp and clear values.
1010 // TODO: Support gaps in RenderTargets. http://anglebug.com/2394
1011 for (size_t colorIndex : mState.getEnabledDrawBuffers())
1012 {
1013 if (clearColorBuffers.test(colorIndex))
1014 {
1015 RenderTargetVk *renderTarget = getColorReadRenderTarget();
1016
1017 // If the render target doesn't have alpha, but its emulated format has it, clear the
1018 // alpha to 1.
1019 VkClearColorValue value = clearColorValue;
1020 if (mEmulatedAlphaAttachmentMask[colorIndex])
1021 {
1022 SetEmulatedAlphaValue(renderTarget->getImageFormat(), &value);
1023 }
1024
1025 mFramebuffer.clearRenderPassColorAttachment(attachmentIndex, value);
1026 }
1027 ++attachmentIndex;
1028 }
1029
1030 // Set the appropriate loadOp and clear values for depth and stencil.
1031 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1032 if (depthStencilRenderTarget)
1033 {
1034 if (clearDepth)
1035 {
1036 mFramebuffer.clearRenderPassDepthAttachment(attachmentIndex,
1037 clearDepthStencilValue.depth);
1038 }
1039
1040 if (clearStencil)
1041 {
1042 mFramebuffer.clearRenderPassStencilAttachment(attachmentIndex,
1043 clearDepthStencilValue.stencil);
1044 }
1045 }
1046
1047 return angle::Result::Continue;
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001048}
1049
Shahbaz Youssefid856ca42018-10-31 16:55:12 -04001050angle::Result FramebufferVk::clearWithClearAttachments(
1051 ContextVk *contextVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001052 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefid856ca42018-10-31 16:55:12 -04001053 bool clearDepth,
1054 bool clearStencil,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001055 const VkClearColorValue &clearColorValue,
Shahbaz Youssefid856ca42018-10-31 16:55:12 -04001056 const VkClearDepthStencilValue &clearDepthStencilValue)
Luc Ferron5242d5b2018-02-15 07:14:35 -05001057{
Jamie Madill316c6062018-05-29 10:49:45 -04001058 // Trigger a new command node to ensure overlapping writes happen sequentially.
Jamie Madille8dd0792018-09-27 15:04:27 -04001059 mFramebuffer.finishCurrentCommands(contextVk->getRenderer());
Jamie Madill9aef3672018-04-27 11:45:06 -04001060
Luc Ferron5242d5b2018-02-15 07:14:35 -05001061 // This command can only happen inside a render pass, so obtain one if its already happening
1062 // or create a new one if not.
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001063 vk::CommandBuffer *commandBuffer = nullptr;
1064 vk::RecordingMode mode = vk::RecordingMode::Start;
Jamie Madill316c6062018-05-29 10:49:45 -04001065 ANGLE_TRY(getCommandBufferForDraw(contextVk, &commandBuffer, &mode));
Luc Ferron5242d5b2018-02-15 07:14:35 -05001066
Jamie Madill3f3b3582018-09-14 10:38:44 -04001067 // The array layer is offset by the ImageView. So we shouldn't need to set a base array layer.
Shahbaz Youssefi06270c92018-10-03 17:00:25 -04001068 VkClearRect clearRect = {};
Luc Ferrone4c38be2018-04-17 11:09:16 -04001069 clearRect.baseArrayLayer = 0;
1070 clearRect.layerCount = 1;
1071
1072 // When clearing, the scissor region must be clipped to the renderArea per the validation rules
1073 // in Vulkan.
1074 gl::Rectangle intersection;
Jamie Madillc3dc5d42018-12-30 12:12:04 -05001075 if (!gl::ClipRectangle(contextVk->getState().getScissor(),
Jamie Madille8dd0792018-09-27 15:04:27 -04001076 mFramebuffer.getRenderPassRenderArea(), &intersection))
Luc Ferrone4c38be2018-04-17 11:09:16 -04001077 {
1078 // There is nothing to clear since the scissor is outside of the render area.
Jamie Madill7c985f52018-11-29 18:16:17 -05001079 return angle::Result::Continue;
Luc Ferrone4c38be2018-04-17 11:09:16 -04001080 }
Luc Ferron1a135ad2018-07-04 10:35:31 -04001081
Luc Ferrone4c38be2018-04-17 11:09:16 -04001082 clearRect.rect = gl_vk::GetRect(intersection);
1083
Luc Ferron82eda932018-07-09 15:10:22 -04001084 if (contextVk->isViewportFlipEnabledForDrawFBO())
Luc Ferron1a135ad2018-07-04 10:35:31 -04001085 {
Jamie Madille8dd0792018-09-27 15:04:27 -04001086 clearRect.rect.offset.y = mFramebuffer.getRenderPassRenderArea().height -
1087 clearRect.rect.offset.y - clearRect.rect.extent.height;
Luc Ferron1a135ad2018-07-04 10:35:31 -04001088 }
1089
Luc Ferron5242d5b2018-02-15 07:14:35 -05001090 gl::AttachmentArray<VkClearAttachment> clearAttachments;
1091 int clearAttachmentIndex = 0;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001092
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001093 if (clearColorBuffers.any())
Luc Ferron5242d5b2018-02-15 07:14:35 -05001094 {
Luc Ferronf6e160f2018-06-12 10:13:57 -04001095 RenderTargetVk *renderTarget = getColorReadRenderTarget();
1096 const vk::Format &format = renderTarget->getImageFormat();
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001097 VkClearValue modifiedClear = {clearColorValue};
Luc Ferronf6e160f2018-06-12 10:13:57 -04001098
1099 // We need to make sure we are not clearing the alpha channel if we are using a buffer
1100 // format that doesn't have an alpha channel.
1101 if (format.angleFormat().alphaBits == 0)
1102 {
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001103 SetEmulatedAlphaValue(format, &modifiedClear.color);
Luc Ferronf6e160f2018-06-12 10:13:57 -04001104 }
1105
Luc Ferrona8af3a62018-03-29 14:44:24 -04001106 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001107 for (size_t colorIndex : clearColorBuffers)
Luc Ferrona8af3a62018-03-29 14:44:24 -04001108 {
1109 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
1110 clearAttachment.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;
1111 clearAttachment.colorAttachment = static_cast<uint32_t>(colorIndex);
Luc Ferronf6e160f2018-06-12 10:13:57 -04001112 clearAttachment.clearValue = modifiedClear;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001113 ++clearAttachmentIndex;
1114 }
1115 }
1116
Shahbaz Youssefid856ca42018-10-31 16:55:12 -04001117 VkClearValue depthStencilClearValue = {};
1118 depthStencilClearValue.depthStencil = clearDepthStencilValue;
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -04001119
Luc Ferrona8af3a62018-03-29 14:44:24 -04001120 if (clearDepth && clearStencil && mState.getDepthStencilAttachment() != nullptr)
1121 {
1122 // When we have a packed depth/stencil attachment we can do 1 clear for both when it
1123 // applies.
Luc Ferron5242d5b2018-02-15 07:14:35 -05001124 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
Luc Ferrona8af3a62018-03-29 14:44:24 -04001125 clearAttachment.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT;
1126 clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED;
Jamie Madill7c985f52018-11-29 18:16:17 -05001127 clearAttachment.clearValue = depthStencilClearValue;
Luc Ferron5242d5b2018-02-15 07:14:35 -05001128 ++clearAttachmentIndex;
1129 }
Luc Ferrona8af3a62018-03-29 14:44:24 -04001130 else
1131 {
1132 if (clearDepth)
1133 {
1134 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
1135 clearAttachment.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT;
1136 clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED;
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -04001137 clearAttachment.clearValue = depthStencilClearValue;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001138 ++clearAttachmentIndex;
1139 }
1140
1141 if (clearStencil)
1142 {
1143 VkClearAttachment &clearAttachment = clearAttachments[clearAttachmentIndex];
1144 clearAttachment.aspectMask = VK_IMAGE_ASPECT_STENCIL_BIT;
1145 clearAttachment.colorAttachment = VK_ATTACHMENT_UNUSED;
Shahbaz Youssefi2197dc52018-10-30 11:29:58 -04001146 clearAttachment.clearValue = depthStencilClearValue;
Luc Ferrona8af3a62018-03-29 14:44:24 -04001147 ++clearAttachmentIndex;
1148 }
1149 }
Luc Ferron5242d5b2018-02-15 07:14:35 -05001150
Luc Ferrona8af3a62018-03-29 14:44:24 -04001151 commandBuffer->clearAttachments(static_cast<uint32_t>(clearAttachmentIndex),
Luc Ferron5242d5b2018-02-15 07:14:35 -05001152 clearAttachments.data(), 1, &clearRect);
Jamie Madill7c985f52018-11-29 18:16:17 -05001153 return angle::Result::Continue;
Luc Ferron5242d5b2018-02-15 07:14:35 -05001154}
1155
Jamie Madill21061022018-07-12 23:56:30 -04001156angle::Result FramebufferVk::clearWithDraw(ContextVk *contextVk,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001157 gl::DrawBufferMask clearColorBuffers,
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001158 bool clearDepth,
1159 bool clearStencil,
1160 VkColorComponentFlags colorMaskFlags,
1161 uint8_t stencilMask,
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001162 const VkClearColorValue &clearColorValue,
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001163 const VkClearDepthStencilValue &clearDepthStencilValue)
Jamie Madill9aef3672018-04-27 11:45:06 -04001164{
Jamie Madilldc65c5b2018-11-21 11:07:26 -05001165 RendererVk *renderer = contextVk->getRenderer();
1166
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001167 UtilsVk::ClearFramebufferParameters params = {};
1168 params.renderPassDesc = &getRenderPassDesc();
1169 params.renderAreaHeight = mState.getDimensions().height;
1170 params.colorClearValue = clearColorValue;
1171 params.depthStencilClearValue = clearDepthStencilValue;
1172 params.stencilMask = stencilMask;
1173
1174 params.clearColor = true;
1175 params.clearDepth = clearDepth;
1176 params.clearStencil = clearStencil;
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001177
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001178 const auto &colorRenderTargets = mRenderTargetCache.getColors();
1179 for (size_t colorIndex : clearColorBuffers)
1180 {
1181 const RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
1182 ASSERT(colorRenderTarget);
1183
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001184 params.colorFormat = &colorRenderTarget->getImage().getFormat().textureFormat();
1185 params.colorAttachmentIndex = colorIndex;
1186 params.colorMaskFlags = colorMaskFlags;
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001187 if (mEmulatedAlphaAttachmentMask[colorIndex])
1188 {
1189 params.colorMaskFlags &= ~VK_COLOR_COMPONENT_A_BIT;
1190 }
1191
Shahbaz Youssefif6c937f2019-04-02 17:04:08 -04001192 ANGLE_TRY(renderer->getUtils().clearFramebuffer(contextVk, this, params));
1193
1194 // Clear depth/stencil only once!
1195 params.clearDepth = false;
1196 params.clearStencil = false;
1197 }
1198
1199 // If there was no color clear, clear depth/stencil alone.
1200 if (params.clearDepth || params.clearStencil)
1201 {
1202 params.clearColor = false;
1203 ANGLE_TRY(renderer->getUtils().clearFramebuffer(contextVk, this, params));
Shahbaz Youssefi43997012019-03-30 23:24:01 -04001204 }
1205
1206 return angle::Result::Continue;
Jamie Madill9aef3672018-04-27 11:45:06 -04001207}
1208
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001209angle::Result FramebufferVk::getSamplePosition(const gl::Context *context,
1210 size_t index,
1211 GLfloat *xy) const
JiangYizhoubddc46b2016-12-09 09:50:51 +08001212{
Jamie Madill64b7c4f2018-10-19 11:38:04 -04001213 ANGLE_VK_UNREACHABLE(vk::GetImpl(context));
Jamie Madill7c985f52018-11-29 18:16:17 -05001214 return angle::Result::Stop;
JiangYizhoubddc46b2016-12-09 09:50:51 +08001215}
1216
Jamie Madill21061022018-07-12 23:56:30 -04001217angle::Result FramebufferVk::getCommandBufferForDraw(ContextVk *contextVk,
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001218 vk::CommandBuffer **commandBufferOut,
Jamie Madill21061022018-07-12 23:56:30 -04001219 vk::RecordingMode *modeOut)
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001220{
Jamie Madill49ac74b2017-12-21 14:42:33 -05001221 RendererVk *renderer = contextVk->getRenderer();
Jamie Madillbef918c2017-12-13 13:11:30 -05001222
Jamie Madill316c6062018-05-29 10:49:45 -04001223 // This will clear the current write operation if it is complete.
Jamie Madillc759b8b2019-01-03 15:16:50 -05001224 if (appendToStartedRenderPass(renderer->getCurrentQueueSerial(), commandBufferOut))
Jamie Madill4c26fc22017-02-24 11:04:10 -05001225 {
Jamie Madill316c6062018-05-29 10:49:45 -04001226 *modeOut = vk::RecordingMode::Append;
Jamie Madill7c985f52018-11-29 18:16:17 -05001227 return angle::Result::Continue;
Jamie Madill9cceac42018-03-31 14:19:16 -04001228 }
Jamie Madill4c26fc22017-02-24 11:04:10 -05001229
Jamie Madilld1249de2018-08-28 16:58:53 -04001230 return startNewRenderPass(contextVk, commandBufferOut);
1231}
1232
1233angle::Result FramebufferVk::startNewRenderPass(ContextVk *contextVk,
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001234 vk::CommandBuffer **commandBufferOut)
Jamie Madilld1249de2018-08-28 16:58:53 -04001235{
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001236 vk::Framebuffer *framebuffer = nullptr;
Jamie Madill21061022018-07-12 23:56:30 -04001237 ANGLE_TRY(getFramebuffer(contextVk, &framebuffer));
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001238
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001239 vk::AttachmentOpsArray renderPassAttachmentOps;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001240 std::vector<VkClearValue> attachmentClearValues;
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001241
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001242 vk::CommandBuffer *writeCommands = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001243 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &writeCommands));
Jamie Madille4c5a232018-03-02 21:00:31 -05001244
Jamie Madillbcf467f2018-05-23 09:46:00 -04001245 vk::RenderPassDesc renderPassDesc;
1246
Jamie Madill49ac74b2017-12-21 14:42:33 -05001247 // Initialize RenderPass info.
Jamie Madill66546be2018-03-08 09:47:20 -05001248 // TODO(jmadill): Support gaps in RenderTargets. http://anglebug.com/2394
1249 const auto &colorRenderTargets = mRenderTargetCache.getColors();
1250 for (size_t colorIndex : mState.getEnabledDrawBuffers())
Jamie Madill4c26fc22017-02-24 11:04:10 -05001251 {
Jamie Madill66546be2018-03-08 09:47:20 -05001252 RenderTargetVk *colorRenderTarget = colorRenderTargets[colorIndex];
1253 ASSERT(colorRenderTarget);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001254
Courtney Goeltzenleuchter5a604a52019-03-27 14:22:50 -06001255 ANGLE_TRY(colorRenderTarget->onColorDraw(contextVk, &mFramebuffer, writeCommands,
1256 &renderPassDesc));
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001257
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001258 renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(),
1259 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
1260 VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL);
1261 attachmentClearValues.emplace_back(kUninitializedClearValue);
Jamie Madill66546be2018-03-08 09:47:20 -05001262 }
1263
1264 RenderTargetVk *depthStencilRenderTarget = mRenderTargetCache.getDepthStencil();
1265 if (depthStencilRenderTarget)
1266 {
Courtney Goeltzenleuchter5a604a52019-03-27 14:22:50 -06001267 ANGLE_TRY(depthStencilRenderTarget->onDepthStencilDraw(contextVk, &mFramebuffer,
1268 writeCommands, &renderPassDesc));
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001269
Shahbaz Youssefidb4ed312019-03-29 00:32:45 -04001270 renderPassAttachmentOps.initWithLoadStore(attachmentClearValues.size(),
1271 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL,
1272 VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL);
1273 attachmentClearValues.emplace_back(kUninitializedClearValue);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001274 }
1275
Luc Ferrond17bdfe2018-04-05 13:50:10 -04001276 gl::Rectangle renderArea =
1277 gl::Rectangle(0, 0, mState.getDimensions().width, mState.getDimensions().height);
Jamie Madill49ac74b2017-12-21 14:42:33 -05001278
Jamie Madilldbc605c2019-01-04 16:39:14 -05001279 return mFramebuffer.beginRenderPass(contextVk, *framebuffer, renderArea, mRenderPassDesc,
Shahbaz Youssefi0c128e12019-03-25 23:50:14 -04001280 renderPassAttachmentOps, attachmentClearValues,
1281 commandBufferOut);
Jamie Madilldf68a6f2017-01-13 17:29:53 -05001282}
1283
Jamie Madill9aef3672018-04-27 11:45:06 -04001284void FramebufferVk::updateActiveColorMasks(size_t colorIndex, bool r, bool g, bool b, bool a)
1285{
Luc Ferron5fd36932018-06-19 14:55:50 -04001286 mActiveColorComponentMasksForClear[0].set(colorIndex, r);
1287 mActiveColorComponentMasksForClear[1].set(colorIndex, g);
1288 mActiveColorComponentMasksForClear[2].set(colorIndex, b);
1289 mActiveColorComponentMasksForClear[3].set(colorIndex, a);
1290}
1291
Shahbaz Youssefie3219402018-12-08 16:54:14 +01001292const gl::DrawBufferMask &FramebufferVk::getEmulatedAlphaAttachmentMask() const
Luc Ferron5fd36932018-06-19 14:55:50 -04001293{
1294 return mEmulatedAlphaAttachmentMask;
Jamie Madill9aef3672018-04-27 11:45:06 -04001295}
Luc Ferron018709f2018-05-10 13:53:11 -04001296
Jamie Madill21061022018-07-12 23:56:30 -04001297angle::Result FramebufferVk::readPixelsImpl(ContextVk *contextVk,
1298 const gl::Rectangle &area,
1299 const PackPixelsParams &packPixelsParams,
Jamie Madillb436aac2018-07-18 17:23:48 -04001300 VkImageAspectFlagBits copyAspectFlags,
Jamie Madill21061022018-07-12 23:56:30 -04001301 RenderTargetVk *renderTarget,
1302 void *pixels)
Luc Ferron018709f2018-05-10 13:53:11 -04001303{
Tobin Ehlis4a419142019-02-05 08:50:30 -07001304 TRACE_EVENT0("gpu.angle", "FramebufferVk::readPixelsImpl");
Jamie Madill58675012018-05-22 14:54:07 -04001305
Shahbaz Youssefi29b49412019-01-07 14:03:06 -05001306 ANGLE_TRY(renderTarget->ensureImageInitialized(contextVk));
1307
Shahbaz Youssefi2660b502019-03-21 12:08:40 -04001308 vk::CommandBuffer *commandBuffer = nullptr;
Jamie Madille8dd0792018-09-27 15:04:27 -04001309 ANGLE_TRY(mFramebuffer.recordCommands(contextVk, &commandBuffer));
Jamie Madill58675012018-05-22 14:54:07 -04001310
Jamie Madillbcf467f2018-05-23 09:46:00 -04001311 // Note that although we're reading from the image, we need to update the layout below.
Luc Ferron1617e692018-07-11 11:08:19 -04001312
Shahbaz Youssefi7dafe3e2019-01-28 11:39:15 -05001313 vk::ImageHelper *srcImage =
1314 renderTarget->getImageForRead(&mFramebuffer, vk::ImageLayout::TransferSrc, commandBuffer);
Jamie Madillbcf467f2018-05-23 09:46:00 -04001315
Jamie Madillb436aac2018-07-18 17:23:48 -04001316 const angle::Format *readFormat = &srcImage->getFormat().textureFormat();
Luc Ferron1617e692018-07-11 11:08:19 -04001317
Jamie Madillb436aac2018-07-18 17:23:48 -04001318 if (copyAspectFlags != VK_IMAGE_ASPECT_COLOR_BIT)
Luc Ferron1617e692018-07-11 11:08:19 -04001319 {
Jamie Madillb436aac2018-07-18 17:23:48 -04001320 readFormat = &GetDepthStencilImageToBufferFormat(*readFormat, copyAspectFlags);
Luc Ferron1617e692018-07-11 11:08:19 -04001321 }
1322
Jamie Madillb980c562018-11-27 11:34:27 -05001323 VkBuffer bufferHandle = VK_NULL_HANDLE;
1324 uint8_t *readPixelBuffer = nullptr;
Jamie Madill4c310832018-08-29 13:43:17 -04001325 VkDeviceSize stagingOffset = 0;
Jamie Madillb980c562018-11-27 11:34:27 -05001326 size_t allocationSize = readFormat->pixelBytes * area.width * area.height;
Luc Ferron018709f2018-05-10 13:53:11 -04001327
Jamie Madilld754eb52018-07-19 14:55:03 -04001328 ANGLE_TRY(mReadPixelBuffer.allocate(contextVk, allocationSize, &readPixelBuffer, &bufferHandle,
Shahbaz Youssefi254b32c2018-11-26 11:58:03 -05001329 &stagingOffset, nullptr));
Luc Ferron018709f2018-05-10 13:53:11 -04001330
Shahbaz Youssefi06270c92018-10-03 17:00:25 -04001331 VkBufferImageCopy region = {};
Luc Ferron534b00d2018-05-18 08:16:53 -04001332 region.bufferImageHeight = area.height;
Jamie Madill4c310832018-08-29 13:43:17 -04001333 region.bufferOffset = stagingOffset;
Luc Ferron534b00d2018-05-18 08:16:53 -04001334 region.bufferRowLength = area.width;
1335 region.imageExtent.width = area.width;
1336 region.imageExtent.height = area.height;
1337 region.imageExtent.depth = 1;
1338 region.imageOffset.x = area.x;
1339 region.imageOffset.y = area.y;
1340 region.imageOffset.z = 0;
Luc Ferron1617e692018-07-11 11:08:19 -04001341 region.imageSubresource.aspectMask = copyAspectFlags;
Jamie Madill3f3b3582018-09-14 10:38:44 -04001342 region.imageSubresource.baseArrayLayer = renderTarget->getLayerIndex();
Luc Ferron534b00d2018-05-18 08:16:53 -04001343 region.imageSubresource.layerCount = 1;
Geoff Lang4a298702019-01-18 10:49:36 -05001344 region.imageSubresource.mipLevel = renderTarget->getLevelIndex();
Luc Ferron534b00d2018-05-18 08:16:53 -04001345
Jamie Madillbcf467f2018-05-23 09:46:00 -04001346 commandBuffer->copyImageToBuffer(srcImage->getImage(), srcImage->getCurrentLayout(),
1347 bufferHandle, 1, &region);
Luc Ferron018709f2018-05-10 13:53:11 -04001348
1349 // Triggers a full finish.
1350 // TODO(jmadill): Don't block on asynchronous readback.
Geoff Lang892d1802019-03-27 14:21:34 -04001351 ANGLE_TRY(contextVk->finishImpl());
Luc Ferron018709f2018-05-10 13:53:11 -04001352
Luc Ferron534b00d2018-05-18 08:16:53 -04001353 // The buffer we copied to needs to be invalidated before we read from it because its not been
1354 // created with the host coherent bit.
Jamie Madilld754eb52018-07-19 14:55:03 -04001355 ANGLE_TRY(mReadPixelBuffer.invalidate(contextVk));
Yuly Novikov6c6c76c2018-05-17 18:45:06 +00001356
Jamie Madillb436aac2018-07-18 17:23:48 -04001357 PackPixels(packPixelsParams, *readFormat, area.width * readFormat->pixelBytes, readPixelBuffer,
Rafael Cintron05a449a2018-06-20 18:08:04 -07001358 static_cast<uint8_t *>(pixels));
Luc Ferron018709f2018-05-10 13:53:11 -04001359
Jamie Madill7c985f52018-11-29 18:16:17 -05001360 return angle::Result::Continue;
Luc Ferron018709f2018-05-10 13:53:11 -04001361}
Jamie Madill58675012018-05-22 14:54:07 -04001362
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001363gl::Extents FramebufferVk::getReadImageExtents() const
Jamie Madill58675012018-05-22 14:54:07 -04001364{
Shahbaz Youssefi68549402019-03-25 23:30:49 -04001365 return getColorReadRenderTarget()->getExtents();
Jamie Madill58675012018-05-22 14:54:07 -04001366}
Jamie Madill502d2e22018-11-01 11:06:23 -04001367
1368RenderTargetVk *FramebufferVk::getFirstRenderTarget() const
1369{
1370 for (auto *renderTarget : mRenderTargetCache.getColors())
1371 {
1372 if (renderTarget)
1373 {
1374 return renderTarget;
1375 }
1376 }
1377
1378 return mRenderTargetCache.getDepthStencil();
1379}
1380
1381GLint FramebufferVk::getSamples() const
1382{
1383 RenderTargetVk *firstRT = getFirstRenderTarget();
1384 return firstRT ? firstRT->getImage().getSamples() : 0;
1385}
1386
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001387} // namespace rx